gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y: Replace "parse_gdbarch" with method call.
   4         * parse.c (write_dollar_variable, insert_type_address_space):
   5         Replace "parse_gdbarch" with method call.
   6         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
   7         call.
   8         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
   9         call.
  10         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
  11         "parse_gdbarch" with method call.
  12         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
  13         with method call.
  14         * f-exp.y (parse_type, parse_f_type, yylex): Replace
  15         "parse_gdbarch" with method call.
  16         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
  17         "parse_gdbarch" with method call.
  18         * c-exp.y (parse_type, parse_number, classify_name): Replace
  19         "parse_gdbarch" with method call.
  20         * ada-lex.l: Replace "parse_gdbarch" with method call.
  21         * ada-exp.y (parse_type, find_primitive_type, type_char)
  22         (type_system_address): Replace "parse_gdbarch" with method call.
  23
  24 2019-04-04  Tom Tromey  <tom@tromey.com>
  25
  26         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
  27         * stap-probe.c (stap_parse_argument): Update.
  28         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
  29         initial_size parameter.
  30         * rust-exp.y (rust_lex_tests): Update.
  31         * parse.c (parser_state): Update.
  32         (parse_exp_in_context): Update.
  33         * parser-defs.h (struct parser_state) <parser_state>: Remove
  34         "initial_size" parameter.
  35
  36 2019-04-04  Tom Tromey  <tom@tromey.com>
  37
  38         * parser-defs.h (increase_expout_size): Don't declare.
  39         * parse.c (increase_expout_size): Now static.
  40
  41 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
  42
  43         * gnu-nat.c (gnu_nat_target::wait): Fix
  44         target_waitstatus_to_string call.
  45
  46 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * eval.c (evaluate_subexp_standard): Handle internal functions
  49         during Fortran function call handling.
  50
  51 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * NEWS: Mention new internal functions.
  54         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  55         (read_base_type): Use dwarf2_init_complex_target_type.
  56         * value.c (creal_internal_fn): New function.
  57         (cimag_internal_fn): New function.
  58         (_initialize_values): Register new internal functions.
  59
  60 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  61
  62         * infrun.c (stop_all_threads): If debug_infrun, always
  63         trace the wait status after wait_one, using
  64         target_waitstatus_to_string and target_pid_to_str.
  65         (handle_inferior_event): Replace various trace of
  66         wait status kind by a single trace.
  67         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
  68         wait status kind image by target_waitstatus_to_string.
  69         * target/waitstatus.c (target_waitstatus_to_string): Fix
  70         obsolete comment.
  71
  72 2019-04-01  Tom Tromey  <tromey@adacore.com>
  73
  74         PR symtab/23331:
  75         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  76
  77 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  78             Pedro Alves  <palves@redhat.com>
  79
  80         * top.c (quit_force): Call 'finalize_values'.
  81         * value.c (finalize_values): New function.
  82         * value.h (finalize_values): Declare.
  83
  84 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  85
  86         * NEWS: Announce $_gdb_major and $_gdb_minor.
  87
  88         * top.c (init_gdb_version_vars): New function.
  89         (gdb_init): Call init_gdb_version_vars.
  90
  91 2019-03-29  Tom Tromey  <tromey@adacore.com>
  92
  93         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  94         help text.  Remove dead code.
  95
  96 2019-03-29  Keith Seitz  <keiths@redhat.com>
  97
  98         From Siddhesh Poyarekar:
  99         * f-lang.h (f77_get_upperbound): Return LONGEST.
 100         (f77_get_lowerbound): Likewise.
 101         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 102         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 103         print them.
 104         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 105         plongest to format print it.
 106         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 107         (f77_get_upperbound): Likewise.
 108         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 109         LOWER_BOUND to LONGEST.
 110         (f77_create_arrayprint_offset_tbl): Likewise.
 111
 112 2019-03-29  Keith Seitz  <keiths@redhat.com>
 113
 114         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 115         %s/pulongest for TYPE_LENGTH instead of %d in format
 116         strings.
 117         * ada-typerint.c (ada_print_type): Likewise.
 118         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 119         * compile/compile-c-support.c (generate_register_struct): Likewise.
 120         * gdbtypes.c (recursive_dump_type): Likewise.
 121         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 122         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 123         instead of %d in format strings.
 124         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 125         to std::min to ULONGEST.
 126         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 127         instead of %d in format strings.
 128         * tracepoint.c (info_scope_command): Likewise.
 129         * typeprint.c (print_offset_data::update)
 130         (print_offset_data::finish): Likewise.
 131         * xtensa-tdep.c (xtensa_store_return_value)
 132         (xtensa_push_dummy_call): Likewise.
 133
 134 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 135
 136         * windows-nat.c (display_selector): Fixed format specifications
 137         for 64-bit Cygwin.
 138
 139 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 140
 141         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 142
 143 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 144
 145         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 146         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 147         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 148         (nios2_linux_init_abi): Install it.
 149
 150 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 151
 152         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 153
 154 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 155
 156         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 157
 158 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 159             Tom Tromey  <tromey@adacore.com>
 160
 161         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 162
 163 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 164
 165         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 166         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 167         method to compute the bounds of range types. Also print "[evaluated]"
 168         if the bounds' values come from a dynamic evaluation.
 169
 170 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 173         whitespace when pretty printing is on.
 174
 175 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 176
 177         * ppc-linux-nat.c: Add include.
 178
 179 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 180
 181         * NEWS: Mention AArch64 Pointer Authentication.
 182
 183 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 184
 185         * arm-linux-nat.c: Add include.
 186
 187 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 188
 189         * source-cache.c (source_cache::get_source_lines): Re-read
 190         fullname after calling open_source_file.
 191
 192 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 193
 194         * NEWS: Mention TLS support for FreeBSD.
 195
 196 2019-03-25  Tom Tromey  <tromey@adacore.com>
 197
 198         * minsyms.c (BUNCH_SIZE): Update comment.
 199         (~minimal_symbol_reader): Remove old comment.
 200         (compact_minimal_symbols): Update comment.
 201         (minimal_symbol_reader::install): Remove old comment.  Update
 202         other comments.
 203
 204 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 205
 206         * s390-linux-nat.c: Add include.
 207
 208 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 209
 210         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 211         Call linux_get_hwcap.
 212         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 213         Likewise.
 214         (aarch64_linux_get_hwcap): Remove function.
 215         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 216         declaration.
 217         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 218         linux_get_hwcap.
 219         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 220         * linux-tdep.c (linux_get_hwcap): Add function.
 221         (linux_get_hwcap2): Likewise.
 222         * linux-tdep.h (linux_get_hwcap): Add declaration.
 223         (linux_get_hwcap2): Likewise.
 224         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 225         (ppc_linux_get_hwcap2): Likewise.
 226         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 227         linux_get_hwcap.
 228         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 229         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 230         (ppc_linux_nat_target::read_description): Likewise.
 231         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 232         * s390-linux-nat.c: Likewise.
 233         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 234
 235 2019-03-24  Tom Tromey  <tom@tromey.com>
 236
 237         * ada-lang.c (standard_lookup): Simplify initialization.
 238         (ada_lookup_symbol_nonlocal): Simplify return.
 239         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 240         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 241         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 242         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 243         initialization.
 244         * solib.c (solib_global_lookup): Simplify.
 245         * symtab.c (null_block_symbol): Remove.
 246         (symbol_cache_lookup): Simplify returns.
 247         (lookup_language_this): Simplify returns.
 248         (lookup_symbol_aux): Simplify return.
 249         (lookup_local_symbol): Simplify returns.
 250         (lookup_global_symbol_from_objfile): Simplify return.
 251         (lookup_symbol_in_objfile_symtabs)
 252         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 253         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 254         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 255         * cp-namespace.c (cp_lookup_bare_symbol)
 256         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 257         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 258         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 259         (cp_lookup_symbol_via_imports): Simplify initialization.
 260         (find_symbol_in_baseclass): Likewise.
 261         * symtab.h (null_block_symbol): Remove.
 262         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 263         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 264         (d_lookup_symbol_module): Likewise.
 265         (find_symbol_in_baseclass): Simplify initialization.
 266
 267 2019-03-24  Tom Tromey  <tom@tromey.com>
 268
 269         * expression.h: Don't include symtab.h.
 270         (struct block): Forward declare.
 271
 272 2019-03-24  Tom Tromey  <tom@tromey.com>
 273
 274         * c-exp.y (typebase): Remove casts.
 275         * gdbtypes.c (lookup_unsigned_typename, )
 276         (lookup_signed_typename): Remove cast.
 277         * eval.c (parse_to_comma_and_eval): Remove cast.
 278         * parse.c (write_dollar_variable): Remove cast.
 279         * block.h (struct block) <superblock>: Now const.
 280         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 281         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 282         (map_block): Make "block" const.
 283         * symfile.h (struct quick_symbol_functions)
 284         <map_matching_symbols>: Constify block argument to "callback".
 285         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 286         const.
 287         (find_pc_sect_compunit_symtab): Make "b" const.
 288         (find_symbol_at_address): Likewise.
 289         (search_symbols): Likewise.
 290         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 291         (dw2_debug_names_lookup_symbol): Likewise.
 292         (dw2_map_matching_symbols): Update.
 293         * p-valprint.c (pascal_val_print): Remove "block".
 294         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 295         (aux_add_nonlocal_symbols): Make "block" const.
 296         (resolve_subexp): Remove cast.
 297         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 298         const.
 299         (iterate_over_file_blocks): Likewise.
 300         * f-exp.y (%union) <bval>: Remove.
 301         * coffread.c (patch_opaque_types): Make "b" const.
 302         * spu-tdep.c (spu_catch_start): Make "block" const.
 303         * c-valprint.c (print_unpacked_pointer): Remove "block".
 304         * symmisc.c (dump_symtab_1): Make "b" const.
 305         (block_depth): Make "block" const.
 306         * d-exp.y (%union) <bval>: Remove.
 307         * cp-support.h (cp_lookup_rtti_type): Update.
 308         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 309         * psymtab.c (psym_lookup_symbol): Make "block" const.
 310         (maintenance_check_psymtabs): Make "b" const.
 311         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 312         (enumerate_locals, enumerate_args): Update.
 313         * python/py-symtab.c (stpy_global_block): Make "block" const.
 314         (stpy_static_block): Likewise.
 315         * inline-frame.c (block_starting_point_at): Make "new_block"
 316         const.
 317         * block.c (find_block_in_blockvector): Make return type const.
 318         (blockvector_for_pc_sect): Make "b" const.
 319         (find_block_in_blockvector): Make "b" const.
 320
 321 2019-03-23  Tom Tromey  <tom@tromey.com>
 322
 323         * varobj.c (varobj_create): Update.
 324         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 325         * printcmd.c (display_command, do_one_display): Don't reset
 326         innermost_block.
 327         * parser-defs.h (enum innermost_block_tracker_type): Move to
 328         expression.h.
 329         (innermost_block): Update comment.
 330         * parse.c (parse_exp_1): Add tracker_types parameter.
 331         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 332         tracker_types parameter.  Reset innermost_block.
 333         (parse_exp_in_context): Remove.
 334         (parse_expression_for_completion): Update.
 335         * objfiles.c (~objfile): Don't reset expression_context_block or
 336         innermost_block.
 337         * expression.h (enum innermost_block_tracker_type): Move from
 338         parser-defs.h.
 339         (parse_exp_1): Add tracker_types parameter.
 340         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 341         reset innermost_block.
 342
 343 2019-03-23  Tom Tromey  <tom@tromey.com>
 344
 345         * objfiles.h: Include bcache.h.
 346
 347 2019-03-23  Tom Tromey  <tom@tromey.com>
 348
 349         * linespec.c (get_current_search_block): Use
 350         scoped_restore_current_language.
 351         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 352
 353 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 354             Jiong Wang  <jiong.wang@arm.com>
 355
 356         * aarch64-linux-tdep.c
 357         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 358         section.
 359         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 360
 361 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 362             Jiong Wang  <jiong.wang@arm.com>
 363
 364         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 365         instructions.
 366         (aarch64_analyze_prologue_test): Add PACIASP test.
 367         (aarch64_prologue_prev_register): Unmask PC value.
 368
 369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 370             Jiong Wang  <jiong.wang@arm.com>
 371
 372         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 373         (aarch64_dwarf2_prev_register): Unmask PC value.
 374         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 375         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 376         DW_CFA_AARCH64_negate_ra_state.
 377         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 378
 379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 380             Jiong Wang  <jiong.wang@arm.com>
 381
 382         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 383         registers.
 384         (aarch64_pseudo_register_name): Likewise.
 385         (aarch64_pseudo_register_type): Likewise.
 386         (aarch64_pseudo_register_reggroup_p): Likewise.
 387         (aarch64_gdbarch_init): Add pauth registers.
 388         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 389         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 390         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 391         (struct gdbarch_tdep): Add regnum for ra_state.
 392
 393 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 394             Jiong Wang  <jiong.wang@arm.com>
 395
 396         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 397
 398 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 399             Jiong Wang  <jiong.wang@arm.com>
 400
 401         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 402         function.
 403         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 404         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 405         (aarch64_gdbarch_init): Add puth registers.
 406         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 407         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 408         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 409
 410 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 411             Jiong Wang  <jiong.wang@arm.com>
 412
 413         * aarch64-linux-nat.c
 414         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 415         * aarch64-linux-tdep.c
 416         (aarch64_linux_core_read_description): Likewise.
 417         (aarch64_linux_get_hwcap): New function.
 418         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 419         (aarch64_linux_get_hwcap): New declaration.
 420
 421 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 422             Jiong Wang  <jiong.wang@arm.com>
 423
 424         * aarch64-linux-nat.c
 425         (aarch64_linux_nat_target::read_description): Add pauth param.
 426         * aarch64-linux-tdep.c
 427         (aarch64_linux_core_read_description): Likewise.
 428         * aarch64-tdep.c (struct target_desc): Add in pauth.
 429         (aarch64_read_description): Add pauth param.
 430         (aarch64_gdbarch_init): Likewise.
 431         * aarch64-tdep.h (aarch64_read_description): Likewise.
 432         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 433         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 434         * features/Makefile: Add new files.
 435         * features/aarch64-pauth.c: New file.
 436         * features/aarch64-pauth.xml: New file.
 437
 438 2019-03-20  Tom Tromey  <tromey@adacore.com>
 439
 440         * infrun.c (handle_inferior_event): Rename from
 441         handle_inferior_event_1.  Create a scoped_value_mark.
 442         (handle_inferior_event): Remove.
 443
 444 2019-03-19  Tom Tromey  <tromey@adacore.com>
 445
 446         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 447         * infrun.h (print_stop_event): Add "displays" parameter.
 448         * infrun.c (print_stop_event): Add "displays" parameter.
 449
 450 2019-03-19  Pedro Alves  <palves@redhat.com>
 451
 452         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 453         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 454         to -1.  Fix TABs vs spaces.
 455         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 456         * tui/tui-out.h (tui_ui_out) Add intro comments.
 457         <m_line, m_start_of_line>: In-class initialize, and add describing
 458         comment.
 459
 460 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 461
 462         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 463         variable names.
 464         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 465
 466 2019-03-18  Pedro Alves  <palves@redhat.com>
 467             Eli Zaretskii <eliz@gnu.org>
 468
 469         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 470         m_line and m_start_of_line.
 471
 472 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 473
 474         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 475         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 476         it returns a newline.  This fixes a regression in TU mode, whereby
 477         the next line is output on the same screen line as the user input.
 478
 479 2019-03-18  Tom Tromey  <tromey@adacore.com>
 480
 481         * minsyms.c (minimal_symbol_reader::install): Remove call to
 482         obstack_blank.
 483
 484 2019-03-18  Pedro Alves  <palves@redhat.com>
 485
 486         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 487         New globals.
 488         (apply_style): New, factored out from ...
 489         (apply_ansi_escape): ... this.  Handle reverse video mode.
 490         (tui_set_reverse_mode): New function.
 491         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 492         * tui/tui-winsource.c (tui_show_source_line): Use
 493         tui_set_reverse_mode instead of setting A_STANDOUT.
 494         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 495         New setter methods.
 496
 497 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 498
 499         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 500         Handle tabs.
 501
 502 2019-03-18  Tom Tromey  <tromey@adacore.com>
 503
 504         * ada-lang.c (empty_array): Add "high" parameter.
 505         (ada_evaluate_subexp): Update.
 506
 507 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 508
 509         * unittests/string_view-selftests.c: Define
 510         _initialize_string_view_selftests unconditionally.
 511
 512 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 513
 514         PR gdb/24350
 515         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 516
 517 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 518
 519         PR gdb/24351
 520         * windows-nat.c (display_selector): Fix format specifiers.
 521
 522 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 523
 524         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 525         tui_refill_source_window instead of tui_refresh_win, to update the
 526         current execution line.  This fixes redisplay of the current line
 527         when stepping through the code with "next" or "step".
 528
 529 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 530
 531         * source-cache.c (source_cache::get_source_lines): Call
 532         find_source_lines to initialize s->nlines.  This fixes vertical
 533         scrolling of TUI source window when the DOWN arrow is pressed.
 534
 535 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 536
 537         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 538         linux-thread-db.c (_initialize_thread_db): Likewise.
 539
 540 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 541
 542         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 543         wclrtoeol in tui_show_source_line".  This reverts changes made in
 544         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 545
 546 2019-03-15  Tom Tromey  <tom@tromey.com>
 547
 548         * symtab.h (struct minimal_symbol): Derive from
 549         general_symbol_info.
 550         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 551         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 552         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 553         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 554         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 555         (MSYMBOL_SEARCH_NAME): Update.
 556         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 557         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 558         * minsyms.c (minimal_symbol_reader::record_full): Update.
 559
 560 2019-03-15  Tom Tromey  <tom@tromey.com>
 561
 562         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 563
 564 2019-03-15  Tom Tromey  <tom@tromey.com>
 565
 566         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 567         unique_xmalloc_ptr.
 568         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 569         Update.
 570         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 571         (build_minimal_symbol_hash_tables)
 572         (minimal_symbol_reader::install): Update.
 573
 574 2019-03-15  Tom Tromey  <tom@tromey.com>
 575
 576         * symtab.c (create_demangled_names_hash): Update.
 577         (symbol_set_names): Update.
 578         * objfiles.h (struct objfile_per_bfd_storage)
 579         <demangled_names_hash>: Now an htab_up.
 580         * objfiles.c (objfile_per_bfd_storage): Simplify.
 581
 582 2019-03-15  Tom Tromey  <tom@tromey.com>
 583
 584         * objfiles.h (struct objfile_per_bfd_storage): Declare
 585         destructor.
 586         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 587         New.
 588         (get_objfile_bfd_data): Use new.  Don't initialize
 589         language_of_main.
 590         (free_objfile_per_bfd_storage): Remove.
 591         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 592
 593 2019-03-15  Tom Tromey  <tom@tromey.com>
 594
 595         * symfile.c (reread_symbols): Update.
 596         * objfiles.c (objfile::objfile): Update.
 597         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 598         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 599         comment.
 600         (minimal_symbol_reader::install): Update.
 601         (terminate_minimal_symbol_table): Remove.
 602         * jit.c (jit_object_close_impl): Update.
 603
 604 2019-03-15  Tom Tromey  <tom@tromey.com>
 605
 606         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 607         initializations.
 608
 609 2019-03-15  Tom Tromey  <tom@tromey.com>
 610
 611         * objfiles.h (struct objfile_per_bfd_storage)
 612         <demangled_hash_languages>: Now a bitset.
 613         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 614         (lookup_minimal_symbol): Update.
 615
 616 2019-03-15  Tom Tromey  <tom@tromey.com>
 617
 618         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 619         Don't return the symbol.
 620         * coffread.c (record_minimal_symbol): Use record_full.
 621
 622 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 623
 624         The MS-Windows port of ncurses fails to switch to a color pair if
 625         one or both of the colors are the implicit default colors.  This
 626         change records the default colors when TUI is initialized, and
 627         then specifies them explicitly when a color pair uses the default
 628         colors.  This allows color styling in TUI mode on MS-Windows.
 629
 630         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 631         ncurses_norm_attr.
 632         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 633         colors in ncurses_norm_attr.
 634         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 635         "none", replace it with the default color recorded in
 636         ncurses_norm_attr.
 637
 638 2019-03-14  Tom Tromey  <tromey@adacore.com>
 639
 640         * source-cache.h (class source_cache) <get_source_lines>: Return
 641         std::string.
 642         * source-cache.c (source_cache::extract_lines): Handle case where
 643         first_pos==npos.  Return std::string.
 644         (source_cache::get_source_lines): Update.
 645
 646 2019-03-14  Tom Tromey  <tromey@adacore.com>
 647
 648         * NEWS: Add item for "style sources" commands.
 649         * source-cache.c (source_cache::get_source_lines): Check
 650         source_styling.
 651         * cli/cli-style.c (source_styling): New global.
 652         (_initialize_cli_style): Add "style sources" commands.
 653         (show_style_sources): New function.
 654         * cli/cli-style.h (source_styling): Declare.
 655
 656 2019-03-14  Pedro Alves  <palves@redhat.com>
 657             Tom Tromey  <tromey@adacore.com>
 658
 659         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 660         * tui/tui-winsource.c (tui_refill_source_window): New function,
 661         from...
 662         (tui_horizontal_source_scroll): ... here.  Move some logic.
 663         * cli/cli-style.c (set_style_enabled): Notify new observable.
 664         * tui/tui-hooks.c (tui_redisplay_source): New function.
 665         (tui_attach_detach_observers): Attach or detach
 666         tui_redisplay_source.
 667         * observable.h (source_styling_changed): New observable.
 668         * observable.c: Define source_styling_changed observable.
 669
 670 2019-03-13  Tom Tromey  <tromey@adacore.com>
 671
 672         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 673         (i386_gnu_nat_target::store_registers): Update.
 674         * target-debug.h (target_debug_print_std_string): New macro.
 675         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 676         * windows-tdep.c (display_one_tib): Update.
 677         * tui/tui-stack.c (tui_make_status_line): Update.
 678         * top.c (print_inferior_quit_action): Update.
 679         * thread.c (thr_try_catch_cmd): Update.
 680         (add_thread_with_info): Update.
 681         (thread_target_id_str): Update.
 682         (thr_try_catch_cmd): Update.
 683         (thread_command): Update.
 684         (thread_find_command): Update.
 685         * record-btrace.c (record_btrace_target::info_record)
 686         (record_btrace_resume_thread, record_btrace_target::resume)
 687         (record_btrace_cancel_resume, record_btrace_step_thread)
 688         (record_btrace_target::wait, record_btrace_target::wait)
 689         (record_btrace_target::wait, record_btrace_target::stop): Update.
 690         * progspace.c (print_program_space): Update.
 691         * process-stratum-target.c
 692         (process_stratum_target::thread_address_space): Update.
 693         * linux-fork.c (linux_fork_mourn_inferior)
 694         (detach_checkpoint_command, info_checkpoints_command)
 695         (linux_fork_context): Update.
 696         (linux_fork_detach): Update.
 697         (class scoped_switch_fork_info): Update.
 698         (delete_checkpoint_command): Update.
 699         * infrun.c (follow_fork_inferior): Update.
 700         (follow_fork_inferior): Update.
 701         (proceed_after_vfork_done): Update.
 702         (handle_vfork_child_exec_or_exit): Update.
 703         (follow_exec): Update.
 704         (displaced_step_prepare_throw): Update.
 705         (displaced_step_restore): Update.
 706         (start_step_over): Update.
 707         (resume_1): Update.
 708         (clear_proceed_status_thread): Update.
 709         (proceed): Update.
 710         (print_target_wait_results): Update.
 711         (do_target_wait): Update.
 712         (context_switch): Update.
 713         (stop_all_threads): Update.
 714         (restart_threads): Update.
 715         (finish_step_over): Update.
 716         (handle_signal_stop): Update.
 717         (switch_back_to_stepped_thread): Update.
 718         (keep_going_pass_signal): Update.
 719         (print_exited_reason): Update.
 720         (normal_stop): Update.
 721         * inferior.c (inferior_pid_to_str): Change return type.
 722         (print_selected_inferior): Update.
 723         (add_inferior): Update.
 724         (detach_inferior): Update.
 725         * dummy-frame.c (fprint_dummy_frames): Update.
 726         * dcache.c (dcache_info_1): Update.
 727         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 728         (btrace_fetch, btrace_clear): Update.
 729         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 730         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 731         type.
 732         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 733         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 734         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 735         * gdbarch.c, gdbarch.h: Rebuild.
 736         * gdbarch.sh (core_pid_to_str): Change return type.
 737         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 738         return type.
 739         (windows_nat_target::pid_to_str): Change return type.
 740         (windows_delete_thread): Update.
 741         (windows_nat_target::attach): Update.
 742         (windows_nat_target::files_info): Update.
 743         * target-delegates.c: Rebuild.
 744         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 745         return type.
 746         (sol_thread_target::pid_to_str): Change return type.
 747         * remote.c (class remote_target) <pid_to_str>: Change return
 748         type.
 749         (remote_target::pid_to_str): Change return type.
 750         (extended_remote_target::attach, remote_target::remote_stop_ns)
 751         (remote_target::remote_notif_remove_queued_reply)
 752         (remote_target::push_stop_reply, remote_target::disable_btrace):
 753         Update.
 754         (extended_remote_target::attach): Update.
 755         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 756         type.
 757         (gdbsim_target::pid_to_str): Change return type.
 758         * ravenscar-thread.c (struct ravenscar_thread_target)
 759         <pid_to_str>: Change return type.
 760         (ravenscar_thread_target::pid_to_str): Change return type.
 761         * procfs.c (class procfs_target) <pid_to_str>: Change return
 762         type.
 763         (procfs_target::pid_to_str): Change return type.
 764         (procfs_target::attach): Update.
 765         (procfs_target::detach): Update.
 766         (procfs_target::fetch_registers): Update.
 767         (procfs_target::store_registers): Update.
 768         (procfs_target::wait): Update.
 769         (procfs_target::files_info): Update.
 770         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 771         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 772         return type.
 773         (nto_procfs_target::pid_to_str): Change return type.
 774         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 775         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 776         return type.
 777         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 778         (exit_lwp): Update.
 779         (attach_proc_task_lwp_callback, get_detach_signal)
 780         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 781         (linux_nat_target::resume, wait_lwp, stop_callback)
 782         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 783         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 784         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 785         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 786         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 787         type.
 788         (inf_ptrace_target::attach): Update.
 789         (inf_ptrace_target::files_info): Update.
 790         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 791         type.
 792         (go32_nat_target::pid_to_str): Change return type.
 793         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 794         (gnu_nat_target::wait): Update.
 795         (gnu_nat_target::wait): Update.
 796         (gnu_nat_target::resume): Update.
 797         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 798         (fbsd_nat_target::wait): Update.
 799         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 800         type.
 801         (darwin_nat_target::attach): Update.
 802         * corelow.c (class core_target) <pid_to_str>: Change return type.
 803         (core_target::pid_to_str): Change return type.
 804         * target.c (normal_pid_to_str): Change return type.
 805         (default_pid_to_str): Likewise.
 806         (target_pid_to_str): Change return type.
 807         (target_translate_tls_address): Update.
 808         (target_announce_detach): Update.
 809         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 810         return type.
 811         (bsd_uthread_target::pid_to_str): Change return type.
 812         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 813         type.
 814         (bsd_kvm_target::pid_to_str): Change return type.
 815         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 816         return type.
 817         (aix_thread_target::pid_to_str): Change return type.
 818         * target.h (struct target_ops) <pid_to_str>: Change return type.
 819         (target_pid_to_str, normal_pid_to_str): Likewise.
 820         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 821         type.
 822         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 823         type.
 824         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 825         return type.
 826         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 827         type.
 828         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 829         type.
 830         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 831         return type.
 832
 833 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 834
 835         * NEWS: Mention that the new default MI version is 3.  Mention
 836         changes to the output of commands and events that deal with
 837         multi-location breakpoints.
 838         * breakpoint.c: Include "mi/mi-out.h".
 839         (print_one_breakpoint): Change output syntax if using MI version
 840         >= 3.
 841         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 842         New.
 843         (mi_multi_location_breakpoint_output_fixed): New.
 844         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 845         (mi_cmd_fix_multi_location_breakpoint_output): New.
 846         (mi_multi_location_breakpoint_output_fixed): New.
 847         * mi/mi-cmds.c (mi_cmds): Register command
 848         -fix-multi-location-breakpoint-output.
 849         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 850         interpreter "mi".
 851
 852 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 853
 854         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 855         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 856         instantiate mi_ui_out based on interpreter name.
 857         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 858         * mi/mi-main.c (mi_load_progress): Likewise.
 859
 860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 861
 862         * NEWS: Combine separate "New targets" sections for 8.3.
 863
 864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 865
 866         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 867         (ppcfbsd_init_abi): Install gdbarch
 868         "fetch_tls_load_module_address" and "get_thread_local_address"
 869         methods.
 870
 871 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 872
 873         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 874         (riscv_fbsd_init_abi): Install gdbarch
 875         "fetch_tls_load_module_address" and "get_thread_local_address"
 876         methods.
 877
 878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 879
 880         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 881         (i386fbsd_init_abi): Install gdbarch
 882         "fetch_tls_load_module_address" and "get_thread_local_address"
 883         methods.
 884
 885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 886
 887         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 888         (amd64fbsd_init_abi): Install gdbarch
 889         "fetch_tls_load_module_address" and "get_thread_local_address"
 890         methods.
 891
 892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 893
 894         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 895         (struct fbsd_pspace_data): New type.
 896         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 897         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 898         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 899         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 900         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 901
 902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 903
 904         * gdbtypes.c (lookup_struct_elt): New function.
 905         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 906         * gdbtypes.h (struct struct_elt): New type.
 907         (lookup_struct_elt): New prototype.
 908
 909 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 910
 911         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 912         remove disabled code block.
 913
 914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 915
 916         * gdbarch.sh (get_thread_local_address): New method.
 917         * gdbarch.h, gdbarch.c: Regenerate.
 918         * target.c (target_translate_tls_address): Use
 919         gdbarch_get_thread_local_address if present instead of
 920         target::get_thread_local_address.
 921
 922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 923
 924         * target.h (target::get_thread_local_address): Update comment.
 925
 926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 927
 928         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 929         objfile->separate_debug_objfile_backlink if not NULL.
 930
 931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 932
 933         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 934         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 935         (amd64bsd_store_inferior_registers): Likewise.
 936         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 937         Enable segment base registers.
 938         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 939         PT_GETFSBASE and PT_GETGSBASE.
 940         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 941         PT_SETGSBASE.
 942         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 943         segment base registers.
 944         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 945
 946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 947
 948         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 949         Update calls to i386_target_description to add 'segments'
 950         parameter.
 951         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 952         add segment base registers.
 953         * arch/i386.c (i386_create_target_description): Add 'segments'
 954         parameter to enable segment base registers.
 955         * arch/i386.h (i386_create_target_description): Likewise.
 956         * features/i386/32bit-segments.xml: New file.
 957         * features/i386/32bit-segments.c: Generate.
 958         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 959         call to i386_target_description to add 'segments' parameter.
 960         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 961         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 962         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 963         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 964         if feature is present.
 965         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 966         Add 'segments' parameter to call to i386_target_description.
 967         (i386_target_description): Add 'segments' parameter to enable
 968         segment base registers.
 969         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 970         to call to i386_target_description.
 971         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 972         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 973         Define I386_NUM_REGS.
 974         (i386_target_description): Add 'segments' parameter to enable
 975         segment base registers.
 976
 977 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 978
 979         PR/24325
 980         * source-cache.c: #undef open and close, to avoid unresolved
 981         externals during linking.
 982
 983 2019-03-12  Tom Tromey  <tromey@adacore.com>
 984
 985         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 986         const.  Add initializers.
 987         (_initialize_remote): Don't initialize ptid globals.
 988
 989 2019-03-12  Pedro Alves  <palves@redhat.com>
 990
 991         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 992
 993 2019-03-12  Pedro Alves  <palves@redhat.com>
 994
 995         * cp-name-parser.y (main): Remove unused 'len' variable.
 996
 997 2019-03-12  Tom Tromey  <tromey@adacore.com>
 998
 999         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1000         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1001
1002 2019-03-12  Tom Tromey  <tromey@adacore.com>
1003
1004         * linux-nat.c (iterate_over_lwps): Update.
1005         (stop_callback): Remove parameter.
1006         (stop_wait_callback, detach_callback, resume_set_callback)
1007         (select_singlestep_lwp_callback, set_ignore_sigint)
1008         (status_callback, resumed_callback, resume_clear_callback)
1009         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1010         data parameter.
1011         (linux_nat_target::detach, linux_nat_target::resume)
1012         (linux_stop_and_wait_all_lwps, select_event_lwp)
1013         (linux_nat_filter_event, linux_nat_wait_1)
1014         (linux_nat_target::kill, linux_nat_target::stop)
1015         (linux_nat_target::stop): Update.
1016         (linux_nat_resume_callback): Change type.
1017         (resume_stopped_resumed_lwps, count_events_callback)
1018         (select_event_lwp_callback): Likewise.
1019         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1020         * arm-linux-nat.c (struct update_registers_data): Remove.
1021         (update_registers_callback): Change type.
1022         (arm_linux_insert_hw_breakpoint1): Update.
1023         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1024         parameter.
1025         (x86_linux_dr_set_addr): Update.
1026         (x86_linux_dr_set_control): Update.
1027         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1028         (iterate_over_lwps): Use gdb::function_view.
1029         * nat/aarch64-linux-hw-point.c (struct
1030         aarch64_dr_update_callback_param): Remove.
1031         (debug_reg_change_callback): Change type.
1032         (aarch64_notify_debug_reg_change): Update.
1033         * s390-linux-nat.c (s390_refresh_per_info): Update.
1034
1035 2019-03-11  Tom Tromey  <tromey@adacore.com>
1036
1037         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1038         redundant assignment to "this_cu".
1039
1040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1041
1042         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1043
1044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1045
1046         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1047         from...
1048         (rank_one_type): ... this.
1049
1050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1051
1052         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1053         from...
1054         (rank_one_type): ... this.
1055
1056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1057
1058         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1059         from...
1060         (rank_one_type): ... this.
1061
1062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1063
1064         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1065         from...
1066         (rank_one_type): ... this.
1067
1068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1069
1070         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1071         from...
1072         (rank_one_type): ... this.
1073
1074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1075
1076         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1077         from...
1078         (rank_one_type): ... this.
1079
1080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1081
1082         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1083         from...
1084         (rank_one_type): ... this.
1085
1086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1087
1088         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1089         from...
1090         (rank_one_type): ... this.
1091
1092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1093
1094         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1095         from...
1096         (rank_one_type): ... this.
1097
1098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1099
1100         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1101         from...
1102         (rank_one_type): ... this.
1103
1104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1105
1106         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1107         from...
1108         (rank_one_type): ... this.
1109
1110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1111
1112         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1113         from...
1114         (rank_one_type): ... this.
1115
1116 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1119         inferior-events' shows the example events.
1120
1121 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1122
1123         Support styling on native MS-Windows console
1124
1125         PR/24315
1126         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1127         on MS-Windows if $TERM is not defined.
1128
1129         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1130
1131         * posix-hdep.c (gdb_console_fputs):
1132         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1133         functions.
1134         * ui-file.h (gdb_console_fputs): Add prototype.
1135
1136         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1137         back to fputs only if the former returns zero.
1138
1139 2019-03-07  Tom Tromey  <tom@tromey.com>
1140
1141         * symmisc.c (print_symbol_bcache_statistics): Update.
1142         (print_objfile_statistics): Update.
1143         * symfile.c (allocate_symtab): Update.
1144         * stabsread.c: Don't include bcache.h.
1145         * psymtab.h (struct psymbol_bcache): Don't declare.
1146         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1147         (psymbol_bcache_init, psymbol_bcache_free)
1148         (psymbol_bcache_get_bcache): Don't declare.
1149         * psymtab.c (struct psymbol_bcache): Remove.
1150         (psymtab_storage::psymtab_storage): Update.
1151         (psymtab_storage::~psymtab_storage): Update.
1152         (psymbol_bcache_init, psymbol_bcache_free)
1153         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1154         (add_psymbol_to_bcache): Update.
1155         (allocate_psymtab): Update.
1156         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1157         macro_cache>: No longer pointers.
1158         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1159         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1160         * macrotab.c (macro_bcache): Update.
1161         * macroexp.c: Don't include bcache.h.
1162         * gdbtypes.c (check_types_worklist): Update.
1163         (types_deeply_equal): Remove TRY/CATCH.  Update.
1164         * elfread.c (elf_symtab_read): Update.
1165         * dwarf2read.c: Don't include bcache.h.
1166         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1167         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1168         (print_bcache_statistics, bcache_memory_used): Don't declare.
1169         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1170         methods.  Rename all data members.
1171         * bcache.c (struct bcache): Move to bcache.h.
1172         (bcache::expand_hash_table): Rename from expand_hash_table.
1173         (bcache): Remove.
1174         (bcache::insert): Rename from bcache_full.
1175         (bcache::compare): Rename from bcache_compare.
1176         (bcache_xmalloc): Remove.
1177         (bcache::~bcache): Rename from bcache_xfree.
1178         (bcache::print_statistics): Rename from print_bcache_statistics.
1179         (bcache::memory_used): Rename from bcache_memory_used.
1180
1181 2019-03-07  Pedro Alves  <palves@redhat.com>
1182
1183         * infrun.c (normal_stop): Also check for
1184         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1185
1186 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * f-lang.c (value_from_host_double): Moved to...
1189         * value.c (value_from_host_double): ...here.
1190         * value.h (value_from_host_double): Declare.
1191         * guile/scm-math.c (vlscm_convert_typed_number): Use
1192         value_from_host_double.
1193         (vlscm_convert_number): Likewise.
1194         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1195         * python/py-value.c (convert_value_from_python): Likewise.
1196
1197 2019-03-06  Tom Tromey  <tom@tromey.com>
1198
1199         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1200
1201 2019-03-06  Tom Tromey  <tom@tromey.com>
1202
1203         * utils.h (free_current_contents): Don't declare.
1204         * utils.c (free_current_contents): Remove.
1205
1206 2019-03-06  Tom Tromey  <tom@tromey.com>
1207
1208         * top.c (quit_force): Update.
1209         * main.c (captured_command_loop): Update.
1210         * common/new-op.c (operator new): Update.
1211         * common/common-exceptions.c (struct catcher)
1212         <save_cleanup_chain>: Remove member.
1213         (exceptions_state_mc_init): Update.
1214         (exception_try_scope_entry): Return nullptr.
1215         (exception_try_scope_exit, exception_rethrow)
1216         (throw_exception_sjlj, throw_exception_cxx): Update.
1217         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1218         (all_cleanups, do_cleanups, discard_cleanups)
1219         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1220         (restore_cleanups, restore_final_cleanups): Don't declare.
1221         (do_final_cleanups): Remove parameter.
1222         * common/cleanups.c (cleanup_chain, make_cleanup)
1223         (make_cleanup_dtor, all_cleanups, do_cleanups)
1224         (discard_my_cleanups, discard_cleanups)
1225         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1226         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1227         (null_cleanup): Remove.
1228         (do_final_cleanups): Remove parameter.
1229
1230 2019-03-06  Tom Tromey  <tom@tromey.com>
1231
1232         * remote.c (remote_target::remote_parse_stop_reply): Use
1233         unique_xmalloc_ptr.
1234
1235 2019-03-06  Tom Tromey  <tom@tromey.com>
1236
1237         * stabsread.c (struct stabs_field_info): Rename from field_info.
1238         <list, fnlist>: Add initializers.
1239         <obstack>: New member.
1240         (read_member_functions, read_struct_fields, read_baseclasses):
1241         Allocate on obstack.  Don't use cleanups.
1242         (read_one_struct_field, read_member_functions, read_struct_fields)
1243         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1244         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1245         (read_struct_type): Update.
1246
1247 2019-03-06  Tom Tromey  <tom@tromey.com>
1248
1249         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1250         * common/filestuff.h (make_cleanup_close): Don't declare.
1251         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1252         Remove.
1253
1254 2019-03-06  Tom Tromey  <tom@tromey.com>
1255
1256         * solib-aix.c: Use make_scope_exit.
1257
1258 2019-03-06  Tom Tromey  <tom@tromey.com>
1259
1260         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1261         Use make_scope_exit.
1262
1263 2019-03-06  Tom Tromey  <tom@tromey.com>
1264
1265         * solib-svr4.c (disable_probes_interface): Remove parameter.
1266         (svr4_handle_solib_event): Use make_scope_exit.
1267
1268 2019-03-06  Tom Tromey  <tom@tromey.com>
1269
1270         * remote.c (struct stop_reply_deleter): Remove.
1271         (stop_reply_up): Update.
1272         (struct stop_reply): Derive from notif_event.  Don't typedef.
1273         <regcache>: Now a std::vector.
1274         (stop_reply_xfree): Remove.
1275         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1276         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1277         (remote_target::discard_pending_stop_replies): Use delete.
1278         (remote_target::remote_parse_stop_reply): Update.
1279         (remote_target::process_stop_reply): Update.
1280         * remote-notif.h (struct notif_event): Add virtual destructor.
1281         Remove "dtr" member.
1282         (struct notif_client) <alloc_event>: Return a unique_ptr.
1283         (notif_event_xfree): Don't declare.
1284         (notif_event_up): New typedef.
1285         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1286         (notif_event_xfree, do_notif_event_xfree): Remove.
1287         (remote_notif_state_xfree): Update.
1288
1289 2019-03-06  Tom Tromey  <tom@tromey.com>
1290
1291         * infrun.c (displaced_step_clear_cleanup): Now a
1292         forward_scope_exit type.
1293         (displaced_step_prepare_throw): Update.
1294         (displaced_step_fixup): Update.
1295
1296 2019-03-06  Tom Tromey  <tom@tromey.com>
1297
1298         * inferior.h (class inferior): Update comment.
1299         * gdbthread.h (class thread_info): Update comment.
1300
1301 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1302             Tom Tromey  <tom@tromey.com>
1303
1304         * stabsread.h (struct stab_section_list): Remove.
1305         (coffstab_build_psymtabs): Update.
1306         * dbxread.c (symbuf_sections): Now a std::vector.
1307         (sect_idx): New global.
1308         (fill_symbuf): Update.
1309         (coffstab_build_psymtabs): Change type of stabsects parameter.
1310         Update.
1311         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1312         std::vector.
1313         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1314         (coff_locate_sections): Update.
1315         (coff_symfile_read): Remove cleanups.  Update.
1316         (init_stringtab): Add storage parameter.
1317         (free_stringtab, free_stringtab_cleanup): Remove.
1318         (init_lineno): Add storage parameter.
1319         (free_linetab, free_linetab_cleanup): Remove.
1320
1321 2019-03-06  Pedro Alves  <palves@redhat.com>
1322
1323         * linux-fork.c (fork_info::clobber_regs): Delete.
1324         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1325         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1326         comment.  Adjust.
1327         (scoped_switch_fork_info::scoped_switch_fork_info)
1328         (checkpoint_command, linux_fork_context): Adjust
1329         fork_save_infrun_state calls.
1330
1331 2019-03-06  Pedro Alves  <palves@redhat.com>
1332
1333         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1334         (inf_has_multiple_threads): Return 'bool' and rewrite using
1335         inferior_info::threads().
1336
1337 2019-03-06  Pedro Alves  <palves@redhat.com>
1338
1339         * linux-fork.c: Include <list>.
1340         (fork_list): Now a std::list instance.
1341         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1342         (forks_exist_p, find_last_fork): Adjust.
1343         (new_fork): Delete.
1344         (one_fork_p): New.
1345         (add_fork): Adjust.
1346         (free_fork): Delete, folded into fork_info::~fork_info().
1347         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1348         Adjust.
1349         (init_fork_list): Delete.
1350         (linux_fork_killall, linux_fork_mourn_inferior)
1351         (linux_fork_detach, info_checkpoints_command): Adjust.
1352         (_initialize_linux_fork): No longer call init_fork_list.
1353
1354 2019-03-06  Pedro Alves  <palves@redhat.com>
1355
1356         * linux-fork.c (new_fork): New, split out of ...
1357         (add_fork): ... this.  Return void.  Move "first fork" special
1358         case from here, to ...
1359         (checkpoint_command): ... here.
1360         * linux-linux.h (add_fork): Return void.
1361
1362 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1365
1366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1367             Chris January  <chris.january@arm.com>
1368             David Lecomber  <david.lecomber@arm.com>
1369
1370         * f-exp.y: New token, UNOP_INTRINSIC.
1371         (exp): New pattern using UNOP_INTRINSIC token.
1372         (f77_keywords): Add 'abs' keyword.
1373         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1374         (value_from_host_double): New function.
1375         (evaluate_subexp_f): Support UNOP_ABS.
1376
1377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1380         types.
1381
1382 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1385         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1386         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1387
1388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1391
1392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1393             Chris January  <chris.january@arm.com>
1394
1395         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1396         * f-exp.y: Define 'KIND' token.
1397         (exp): New pattern for KIND expressions.
1398         (ptype): Handle types with a kind extension.
1399         (direct_abs_decl): Extend to spot kind extensions.
1400         (f77_keywords): Add 'kind' to the list.
1401         (push_kind_type): New function.
1402         (convert_to_kind_type): New function.
1403         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1404         * parse.c (operator_length_standard): Likewise.
1405         * parser-defs.h (enum type_pieces): Add tp_kind.
1406         * std-operator.def: Add UNOP_KIND.
1407
1408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1409
1410         * f-exp.y (f_parse): Set yydebug.
1411
1412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * f-lang.c (evaluate_subexp_f): New function.
1415         (exp_descriptor_f): New global.
1416         (f_language_defn): Use exp_descriptor_f instead of
1417         exp_descriptor_standard.
1418
1419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * f-exp.y (struct token): Add comments.
1422         (dot_ops): Remove uppercase versions and the end marker.
1423         (f77_keywords): Likewise.
1424         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1425         entries in the dot_ops array are case insensitive, and use
1426         strncasecmp to compare strings.  Also some whitespace cleanup in
1427         this area.  Similar for the f77_keywords array, except entries in
1428         this list might be case sensitive.
1429
1430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * f-exp.y (struct f77_boolean_val): Add comments.
1433         (boolean_values): Remove uppercase versions, and end marker.
1434         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1435         and use strncasecmp to achieve case insensitivity.  Additionally,
1436         perform whitespace cleanup around this code.
1437
1438 2019-03-06  Tom Tromey  <tromey@adacore.com>
1439
1440         * remote-sim.c (gdbsim_target_open): Use result of
1441         gdb_argv::release.
1442
1443 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1444         Dirk Schubert  <dirk.schubert@arm.com>
1445         Chris January  <chris.january@arm.com>
1446
1447         * eval.c (evaluate_subexp_standard): Call Fortran argument
1448         wrapping logic.
1449         * f-lang.c (struct value): A value which can be passed into a
1450         Fortran function call.
1451         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1452         where appropriate.
1453         (struct type): Value ready for a Fortran function call.
1454         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1455         is needed.
1456         * f-lang.h (fortran_argument_convert): Declaration.
1457         (fortran_preserve_arg_pointer): Declaration.
1458         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1459
1460 2019-03-05  Tom Tromey  <tromey@adacore.com>
1461
1462         * python/py-prettyprint.c (print_string_repr): Remove #if.
1463         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1464
1465 2019-03-05  Tom Tromey  <tromey@adacore.com>
1466
1467         * target.c (the_dummy_target): Move later.  Change type to
1468         "dummy_target".
1469         (initialize_targets): Don't initialize the_dummy_target.
1470
1471 2019-03-05  Tom Tromey  <tromey@adacore.com>
1472
1473         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1474         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1475
1476 2019-03-05  Tom Tromey  <tromey@adacore.com>
1477
1478         * windows-nat.c (windows_nat_target::attach)
1479         (windows_nat_target::detach): Don't call gdb_flush.
1480         * valprint.c (generic_val_print, val_print, val_print_string):
1481         Don't call gdb_flush.
1482         * utils.c (defaulted_query): Don't call gdb_flush.
1483         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1484         * target.c (target_announce_detach): Don't call gdb_flush.
1485         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1486         * remote.c (extended_remote_target::attach): Don't call
1487         gdb_flush.
1488         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1489         * printcmd.c (do_examine): Don't call gdb_flush.
1490         (info_display_command): Don't call gdb_flush.
1491         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1492         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1493         * memattr.c (info_mem_command): Don't call gdb_flush.
1494         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1495         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1496         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1497         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1498         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1499         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1500         (gnu_nat_target::detach): Don't call gdb_flush.
1501         * f-valprint.c (f_val_print): Don't call gdb_flush.
1502         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1503         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1504         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1505         gdb_flush.
1506         * c-valprint.c (c_val_print): Don't call gdb_flush.
1507         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1508
1509 2019-03-05  Tom Tromey  <tromey@adacore.com>
1510
1511         * varobj.c (update_dynamic_varobj_children): Update.
1512         (install_default_visualizer): Use reset, not release.
1513         * value.c (set_internalvar): Update.
1514         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1515         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1516         ATTRIBUTE_UNUSED_RESULT.
1517
1518 2019-03-05  Tom Tromey  <tromey@adacore.com>
1519
1520         * remote.c (class scoped_remote_fd) <release>: Add
1521         ATTRIBUTE_UNUSED_RESULT.
1522
1523 2019-03-05  Tom Tromey  <tromey@adacore.com>
1524
1525         * macroexp.c (struct macro_buffer) <release>: Add
1526         ATTRIBUTE_UNUSED_RESULT.
1527
1528 2019-03-05  Tom Tromey  <tromey@adacore.com>
1529
1530         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1531         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1532         ATTRIBUTE_UNUSED_RESULT.
1533
1534 2019-03-05  Tom Tromey  <tromey@adacore.com>
1535
1536         * common/scoped_fd.h (class scoped_fd) <release>: Add
1537         ATTRIBUTE_UNUSED_RESULT.
1538
1539 2019-03-05  Tom Tromey  <tromey@adacore.com>
1540
1541         * parser-defs.h (struct parser_state) <release>: Add
1542         ATTRIBUTE_UNUSED_RESULT.
1543
1544 2019-03-05  Tom Tromey  <tromey@adacore.com>
1545
1546         * utils.h (class gdb_argv) <release>: Add
1547         ATTRIBUTE_UNUSED_RESULT.
1548         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1549
1550 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1551
1552         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1553         for-loop range, to avoid compiler warnings.
1554
1555         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1556         avoid compiler warnings about unused variables.
1557
1558         * NEWS: Mention end of support for native debugging on MS-Windows
1559         before XP.
1560
1561         PR gdb/24292
1562         * common/netstuff.c:
1563         * gdbserver/gdbreplay.c
1564         * gdbserver/remote-utils.c:
1565         * ser-tcp.c:
1566         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1567         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1568         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1569         'getaddrinfo' and 'freeaddrinfo' were not available before
1570         Windows XP, and mingw.org's MinGW headers by default define
1571         _WIN32_WINNT to 0x500.
1572
1573 2019-03-01  Gary Benson <gbenson@redhat.com>
1574
1575         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1576
1577 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1578             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1579
1580         PR gdb/8527
1581         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1582         set_sigint_trap, clear_sigint_trap.
1583
1584 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1585
1586         * target.c (target_detach): Clear the regcache and the
1587         frame cache.
1588
1589 2019-02-27  Pedro Alves  <palves@redhat.com>
1590
1591         * utils.c (set_screen_size): When we cap the height/width sizes,
1592         tweak the corresponding command variable to show "unlimited":
1593
1594 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1595             Pedro Alves  <palves@redhat.com>
1596
1597         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1598         before calling rl_set_screen_size.
1599
1600 2019-02-27  Tom Tromey  <tromey@adacore.com>
1601
1602         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1603         define.
1604         * python/py-value.c: Remove Python 2.4 workaround.
1605         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1606         workaround.
1607         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1608         Python 2.4 workaround.
1609         * python/python-internal.h: Remove Python 2.4 comment.
1610         (Py_ssize_t): Don't define.
1611         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1612         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1613         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1614         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1615         * python/python.c (do_start_initialization): Remove Python 2.4
1616         workaround.
1617         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1618         (print_children): Remove Python 2.4 workaround.
1619         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1620         workaround.
1621         (CHARBUFFERPROC_NAME): Remove.
1622         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1623         Python 2.4 workaround.
1624
1625 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1626
1627         * NEWS: Note minimum Python version.
1628
1629 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1630
1631         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1632         code from these functions.  Remove corresponding ifdefs.  Use
1633         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1634         Remove gotos and target of gotos.
1635         (infpy_search_memory): Likewise.
1636
1637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1638
1639         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1640         (hppa_gdbarch_init): Don't register deleted functions with
1641         gdbarch.
1642
1643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1646         (h8300_unwind_sp): Delete.
1647         (h8300_dummy_id): Delete.
1648         (h8300_gdbarch_init): Don't register deleted functions with
1649         gdbarch.
1650
1651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1654         (ft32_unwind_pc): Delete.
1655         (ft32_unwind_sp): Delete.
1656         (ft32_gdbarch_init): Don't register deleted functions with
1657         gdbarch.
1658
1659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1662         (frv_unwind_pc): Delete.
1663         (frv_unwind_sp): Delete.
1664         (frv_gdbarch_init): Don't register deleted functions with
1665         gdbarch.
1666
1667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1668
1669         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1670         (riscv_unwind_pc): Delete.
1671         (riscv_unwind_sp): Delete.
1672         (riscv_gdbarch_init): Don't register deleted functions with
1673         gdbarch.
1674
1675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1676
1677         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1678         (csky_unwind_pc): Delete.
1679         (csky_unwind_sp): Delete.
1680         (csky_gdbarch_init): Don't register deleted functions with
1681         gdbarch.
1682
1683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1686         (cris_unwind_pc): Delete.
1687         (cris_unwind_sp): Delete.
1688         (cris_gdbarch_init): Don't register deleted functions with
1689         gdbarch.
1690
1691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1694         (bfin_unwind_pc): Delete.
1695         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1696
1697 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1698
1699         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1700         (arm_unwind_pc): Delete.
1701         (arm_unwind_sp): Delete.
1702         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1703
1704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1705
1706         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1707         (arc_unwind_pc): Delete.
1708         (arc_unwind_sp): Delete.
1709         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1710
1711 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1712
1713         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1714         (alpha_unwind_pc): Delete.
1715         (alpha_gdbarch_init): Don't register deleted functions with
1716         gdbarch.
1717
1718 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1721         (aarch64_unwind_pc): Delete.
1722         (aarch64_unwind_sp): Delete.
1723         (aarch64_gdbarch_init): Don't register deleted functions with
1724         gdbarch.
1725
1726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * gdbtypes.c (type_align): Don't consider static members when
1729         computing structure alignment.
1730
1731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1734         return 0 for other types.
1735         * arch-utils.c (default_type_align): Always return 0.
1736         * gdbarch.h: Regenerate.
1737         * gdbarch.sh (type_align): Extend comment.
1738         * gdbtypes.c (type_align): Add additional comments, always call
1739         gdbarch_type_align before applying the default rules.
1740         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1741         generic code will then apply a suitable default.
1742         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1743         types, return 0 for other types.
1744
1745 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1746
1747         * NEWS: Create a new section for the next release branch.
1748         Rename the section of the current branch, now that it has
1749         been cut.
1750
1751 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1752
1753         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1754         * version.in: Bump version to 8.3.50.DATE-git.
1755
1756 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1757
1758         * aix-thread.c (ptid_cmp): Remove unused variable.
1759         (get_signaled_thread): Likewise.
1760         (store_regs_user_thread): Likewise.
1761         (store_regs_kernel_thread): Likewise.
1762         (fetch_regs_kernel_thread): Remove shadowed variable.
1763
1764 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1765
1766         * features/riscv/32bit-cpu.xml: Add register numbers.
1767         * features/riscv/32bit-fpu.c: Regenerate.
1768         * features/riscv/32bit-fpu.xml: Add register numbers.
1769         * features/riscv/64bit-cpu.xml: Add register numbers.
1770         * features/riscv/64bit-fpu.c: Regenerate.
1771         * features/riscv/64bit-fpu.xml: Add register numbers.
1772
1773 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1774
1775         * NEWS: Mention two argument form of gdb.Value constructor.
1776         * python/py-value.c (convert_buffer_and_type_to_value): New
1777         function.
1778         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1779         Add support for handling an optional second argument.  Call
1780         convert_buffer_and_type_to_value as appropriate.
1781         * python/python-internal.h (Py_buffer_deleter): New struct.
1782         (Py_buffer_up): New typedef.
1783
1784 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1785
1786         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1787         instead of releasing ownership.
1788
1789 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1790
1791         * dwarf2read.c (open_and_init_dwp_file): Call
1792         elf_numsections instead of bfd_count_sections to initialize
1793         dwp_file->num_sections.
1794
1795 2019-02-25  Tom Tromey  <tromey@adacore.com>
1796
1797         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1798
1799 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1800
1801         * gcore.in: Add '--readnever' option when invoking GDB.
1802
1803 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1804
1805         * MAINTAINERS: Update my email address.
1806
1807 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1808
1809         * build-id.c (build_id_to_debug_bfd_1): New function.
1810         (build_id_to_debug_bfd): Look for separate debug file in
1811         sysroot.
1812
1813 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1814
1815         * gdbarch.sh: Update the copyright year range that is placed into
1816         generated files.
1817
1818 2019-02-22  Keith Seitz  <keiths@redhat.com>
1819
1820         PR symtab/23853
1821         * linespec.c (create_sals_line_offset): Search for the default
1822         symtab's filename instead of its fullname.
1823
1824 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1825
1826         * NEWS: Update style defaults.
1827
1828 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1829
1830         * main.c (captured_main_1): Disable styling in batch mode.
1831
1832 2019-02-20  Tom Tromey  <tom@tromey.com>
1833
1834         * symtab.c (symtab_symbol_info): Fix typos.
1835
1836 2019-02-20  Tom Tromey  <tromey@adacore.com>
1837
1838         * findcmd.c (_initialize_mem_search): Use upper case for
1839         metasyntactic variables.
1840
1841 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1842
1843         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1844         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1845
1846 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1847
1848         * top.h (source_file_name): Change to std::string.
1849         * top.c (source_file_name): Likewise.
1850         (command_line_input): Adjust.
1851         * cli/cli-script.c (script_from_file): Adjust.
1852
1853 2019-02-19  Tom Tromey  <tromey@adacore.com>
1854
1855         * ravenscar-thread.c
1856         (ravenscar_thread_target::update_thread_list): Don't call
1857         ada_build_task_list.
1858         * ada-lang.h (ada_build_task_list): Don't declare.
1859         * ada-tasks.c (struct ada_tasks_inferior_data)
1860         <task_list_valid_p>: Now bool.
1861         (read_known_tasks, ada_task_list_changed)
1862         (ada_tasks_invalidate_inferior_data): Update.
1863         (read_known_tasks_array): Return bool.
1864         (read_known_tasks_list): Likewise.
1865         (read_known_tasks): Return void.
1866         (ada_build_task_list): Now static.
1867
1868 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1871         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1872
1873 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1874
1875         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1876         variant for ada_tasks_pspace_data_handle and
1877         ada_tasks_inferior_data_handle.
1878         (ada_tasks_pspace_data_cleanup): New function.
1879         (ada_tasks_inferior_data_cleanup): New function.
1880
1881 2019-02-17  Tom Tromey  <tom@tromey.com>
1882
1883         * macrotab.h (macro_source_fullname): Return a std::string.
1884         * macrotab.c (macro_include, check_for_redefinition)
1885         (macro_undef, macro_lookup_definition, foreach_macro)
1886         (foreach_macro_in_scope): Update.
1887         (macro_source_fullname): Return a std::string.
1888         * macrocmd.c (show_pp_source_pos): Update.
1889
1890 2019-02-17  Tom Tromey  <tom@tromey.com>
1891
1892         * macrocmd.c (show_pp_source_pos): Style the file names.
1893
1894 2019-02-17  Tom Tromey  <tom@tromey.com>
1895
1896         PR tui/24197:
1897         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1898
1899 2019-02-17  Tom Tromey  <tom@tromey.com>
1900
1901         * ada-lang.c (user_select_syms): Use filtered printing.
1902         * utils.c (wrap_style): New global.
1903         (desired_style): Remove.
1904         (emit_style_escape): Add stream parameter.
1905         (set_output_style, reset_terminal_style, prompt_for_continue):
1906         Update.
1907         (flush_wrap_buffer): Only flush gdb_stdout.
1908         (wrap_here): Set wrap_style.
1909         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1910         treat escape sequences as a character.  Change when wrap buffer is
1911         flushed.
1912         (fputs_styled): Do not set the output style when the default is
1913         requested.
1914         * ui-style.h (struct ui_file_style) <is_default>: New method.
1915         * source.c (print_source_lines_base): Emit escape sequences in one
1916         piece.
1917
1918 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1919
1920         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1921         integers and enumeration types.
1922
1923 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1924
1925         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1926         instead of lookup_symbol_in_language
1927         (do_exact_match): New function.
1928         (ada_get_symbol_name_matcher): Return do_exact_match when
1929         doing a verbatim match.
1930
1931 2019-02-15  Tom Tromey  <tromey@adacore.com>
1932
1933         * ravenscar-thread.c (ravenscar_thread_target::resume)
1934         (ravenscar_thread_target::wait): Special case wildcard requests.
1935
1936 2019-02-15  Tom Tromey  <tromey@adacore.com>
1937
1938         * ravenscar-thread.c (base_ptid): Remove.
1939         (struct ravenscar_thread_target) <close>: New method.
1940         <m_base_ptid>: New member.
1941         <update_inferior_ptid, active_task, task_is_currently_active,
1942         runtime_initialized>: Declare methods.
1943         <ravenscar_thread_target>: Add constructor.
1944         (ravenscar_thread_target::task_is_currently_active)
1945         (ravenscar_thread_target::update_inferior_ptid)
1946         (ravenscar_runtime_initialized): Rename.  Now methods.
1947         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1948         (ravenscar_thread_target::update_thread_list): Update.
1949         (ravenscar_thread_target::active_task): Now method.
1950         (ravenscar_thread_target::store_registers)
1951         (ravenscar_thread_target::prepare_to_store)
1952         (ravenscar_thread_target::prepare_to_store)
1953         (ravenscar_thread_target::mourn_inferior): Update.
1954         (ravenscar_inferior_created): Use "new" to create target.
1955         (ravenscar_thread_target::get_ada_task_ptid): Update.
1956         (_initialize_ravenscar): Don't initialize base_ptid.
1957         (ravenscar_ops): Remove global.
1958
1959 2019-02-15  Tom Tromey  <tromey@adacore.com>
1960
1961         * target.h (push_target): Declare new overload.
1962         * target.c (push_target): New overload, taking an rvalue reference.
1963         * remote.c (remote_target::open_1): Use push_target overload.
1964         * corelow.c (core_target_open): Use push_target overload.
1965
1966 2019-02-15  Tom Tromey  <tromey@adacore.com>
1967
1968         * ravenscar-thread.c (is_ravenscar_task)
1969         (ravenscar_task_is_currently_active): Return bool.
1970         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1971         (_initialize_ravenscar): Remove "(void)".
1972         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1973         Return bool.
1974
1975 2019-02-15  Tom Tromey  <tromey@adacore.com>
1976
1977         * ravenscar-thread.c (ravenscar_runtime_initializer)
1978         (has_ravenscar_runtime, get_running_thread_id)
1979         (ravenscar_thread_target::resume): Fix indentation.
1980
1981 2019-02-15  Tom Tromey  <tromey@adacore.com>
1982
1983         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1984         from ravenscar_arch_ops.
1985         (sparc_ravenscar_ops::fetch_registers)
1986         (sparc_ravenscar_ops::store_registers): Now methods.
1987         (sparc_ravenscar_prepare_to_store): Remove.
1988         (sparc_ravenscar_ops): Redefine.
1989         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1990         methods and destructor.  Remove members.
1991         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1992         (ravenscar_thread_target::store_registers)
1993         (ravenscar_thread_target::prepare_to_store): Update.
1994         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1995         Remove.
1996         (struct ppc_ravenscar_powerpc_ops): Derive from
1997         ravenscar_arch_ops.
1998         (ppc_ravenscar_powerpc_ops::fetch_registers)
1999         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2000         (ppc_ravenscar_powerpc_ops): Redefine.
2001         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2002         (ppc_ravenscar_e500_ops::fetch_registers)
2003         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2004         (ppc_ravenscar_e500_ops): Redefine.
2005         * aarch64-ravenscar-thread.c
2006         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2007         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2008         (aarch64_ravenscar_fetch_registers)
2009         (aarch64_ravenscar_store_registers): Now methods.
2010         (aarch64_ravenscar_ops): Redefine.
2011
2012 2019-02-15  Tom Tromey  <tromey@adacore.com>
2013
2014         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2015         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2016         (ravenscar_thread_target::stopped_by_watchpoint)
2017         (ravenscar_thread_target::stopped_data_address)
2018         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2019
2020 2019-02-15  Tom Tromey  <tromey@adacore.com>
2021
2022         * ravenscar-thread.c: Fix some typos.
2023
2024 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2025             Tom Tromey  <tromey@adacore.com>
2026
2027         * ada-lang.c (ada_exception_sal): Change addr_string to a
2028         std::string.
2029         (create_ada_exception_catchpoint): Update.
2030
2031 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2032             Tom Tromey  <tromey@adacore.com>
2033
2034         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2035         (bp_location_ops): Remove.
2036         (base_breakpoint_allocate_location): Update.
2037         (free_bp_location): Update.
2038         * ada-lang.c (class ada_catchpoint_location)
2039         <ada_catchpoint_location>: Remove ops parameter.
2040         (ada_catchpoint_location_dtor): Remove.
2041         (ada_catchpoint_location_ops): Remove.
2042         (allocate_location_exception): Update.
2043         * breakpoint.h (struct bp_location_ops): Remove.
2044         (class bp_location) <bp_location>: Remove bp_location_ops
2045         parameter.
2046         <~bp_location>: Add destructor.
2047         <ops>: Remove.
2048
2049 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2050             Pedro Alves  <palves@redhat.com>
2051
2052         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2053         'PATH_MAX'.
2054
2055 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2056             Samuel Thibault  <samuel.thibault@gnu.org>
2057             Thomas Schwinge  <thomas@codesourcery.com>
2058
2059         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2060         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2061
2062 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2063
2064         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2065         (check_empty): Use "const char *".
2066
2067         * gnu-nat.c (gnu_nat_target::detach): Instead of
2068         'detach_inferior (pid)' call
2069         'detach_inferior (find_inferior_pid (pid))'.
2070
2071         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2072         'nat/fork-inferior.o'.
2073         * gnu-nat.c: #include "nat/fork-inferior.h".
2074
2075         * gnu-nat.c (gnu_nat_target::detach): Instead of
2076         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2077         * gnu-nat.h: #include "inf-child.h".
2078         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2079         'i386_gnu_nat_target::fetch_registers'.
2080         (gnu_store_registers): Rename/move to
2081         'i386_gnu_nat_target::store_registers'.
2082
2083         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2084         * gnu-nat.h (mach_thread_info): New function.
2085         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2086
2087         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2088
2089 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2090
2091         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2092
2093 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2094
2095         * windows-nat.c (windows_add_thread): Add new parameter
2096         "main_thread_p" with default value set to false.  Update
2097         function documentation as well as all callers.
2098         (windows_delete_thread): Likewise.
2099         (fake_create_process): Update call to windows_add_thread.
2100         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2101         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2102         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2103         call to windows_delete_thread.
2104
2105 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2106
2107         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2108
2109 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2110
2111         * symfile.c (find_separate_debug_file): Use canonical path of
2112         sysroot with child_path instead of gdb_sysroot if it is valid.
2113
2114 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2115
2116         * symfile.c (find_separate_debug_file): Use child_path to
2117         determine if an object file is under a sysroot.
2118
2119 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2120
2121         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2122         unittests/child-path-selftests.c.
2123         * common/pathstuff.c (child_path): New function.
2124         * common/pathstuff.h (child_path): New prototype.
2125         * unittests/child-path-selftests.c: New file.
2126
2127 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2128
2129         * symfile.c (find_separate_debug_file): Look for separate debug
2130         files in debug directories under the sysroot.
2131
2132 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2133
2134         * symtab.h (struct minimal_symbol data_p): New const method.
2135         (struct minimal_symbol text_p): Likewise.
2136         * symtab.c (output_source_filename): Use file name style
2137         to print file name.
2138         (print_symbol_info): Likewise.
2139         (print_msymbol_info): Use address style to print addresses.
2140         Use function name style to print executable text symbols.
2141         (expand_symtab_containing_pc): Use data_p.
2142         (find_pc_sect_compunit_symtab): Likewise.
2143
2144 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2145
2146         * breakpoint.c (describe_other_breakpoints): Use address style
2147         to print addresses.
2148         (say_where): Likewise.
2149
2150 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2151
2152         * ada-typeprint.c (print_func_type): Print function name
2153         style to print function name.
2154         * c-typeprint.c (c_print_type_1): Likewise.
2155
2156 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2157
2158         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2159         for execve.
2160
2161 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2162
2163         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2164         type_stack.
2165
2166 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2167
2168         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2169         TYPE_CODE_REF types.
2170
2171 2019-02-08  Jim Wilson  <jimw@sifive.com>
2172
2173         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2174         (riscv_linux_fregset): New.
2175         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2176
2177 2019-02-07  Tom Tromey  <tom@tromey.com>
2178
2179         * thread.c (thread_cancel_execution_command): Update.
2180         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2181         methods.
2182         (struct thread_fsm_ops): Remove.
2183         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2184         (thread_fsm_should_stop, thread_fsm_return_value)
2185         (thread_fsm_set_finished, thread_fsm_finished_p)
2186         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2187         Don't declare.
2188         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2189         * infrun.c (clear_proceed_status_thread)
2190         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2191         (print_stop_event): Update.
2192         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2193         Add constructor.
2194         (step_command_fsm_ops): Remove.
2195         (new_step_command_fsm): Remove.
2196         (step_1): Update.
2197         (step_command_fsm::should_stop): Rename from
2198         step_command_fsm_should_stop.
2199         (step_command_fsm::clean_up): Rename from
2200         step_command_fsm_clean_up.
2201         (step_command_fsm::do_async_reply_reason): Rename from
2202         step_command_fsm_async_reply_reason.
2203         (struct until_next_fsm): Inherit from thread_fsm.  Add
2204         constructor.
2205         (until_next_fsm_ops): Remove.
2206         (new_until_next_fsm): Remove.
2207         (until_next_fsm::should_stop): Rename from
2208         until_next_fsm_should_stop.
2209         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2210         (until_next_fsm::do_async_reply_reason): Rename from
2211         until_next_fsm_async_reply_reason.
2212         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2213         constructor.  Change type of breakpoint.
2214         (finish_command_fsm_ops): Remove.
2215         (new_finish_command_fsm): Remove.
2216         (finish_command_fsm::should_stop): Rename from
2217         finish_command_fsm_should_stop.
2218         (finish_command_fsm::clean_up): Rename from
2219         finish_command_fsm_clean_up.
2220         (finish_command_fsm::return_value): Rename from
2221         finish_command_fsm_return_value.
2222         (finish_command_fsm::do_async_reply_reason): Rename from
2223         finish_command_fsm_async_reply_reason.
2224         (finish_command): Update.
2225         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2226         Add constructor.
2227         (call_thread_fsm_ops): Remove.
2228         (call_thread_fsm::call_thread_fsm): Rename from
2229         new_call_thread_fsm.
2230         (call_thread_fsm::should_stop): Rename from
2231         call_thread_fsm_should_stop.
2232         (call_thread_fsm::should_notify_stop): Rename from
2233         call_thread_fsm_should_notify_stop.
2234         (run_inferior_call, call_function_by_hand_dummy): Update.
2235         * cli/cli-interp.c (should_print_stop_to_console): Update.
2236         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2237         Add constructor.  Change type of location_breakpoint,
2238         caller_breakpoint.
2239         (until_break_fsm_ops): Remove.
2240         (new_until_break_fsm): Remove.
2241         (until_break_fsm::should_stop): Rename from
2242         until_break_fsm_should_stop.
2243         (until_break_fsm::clean_up): Rename from
2244         until_break_fsm_clean_up.
2245         (until_break_fsm::do_async_reply_reason): Rename from
2246         until_break_fsm_async_reply_reason.
2247         (until_break_command): Update.
2248         * thread-fsm.c: Remove.
2249         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2250
2251 2019-02-07  Tom Tromey  <tom@tromey.com>
2252
2253         * yy-remap.h: Add include guard.
2254         * xtensa-tdep.h: Add include guard.
2255         * xcoffread.h: Rename include guard.
2256         * varobj-iter.h: Add include guard.
2257         * tui/tui.h: Rename include guard.
2258         * tui/tui-winsource.h: Rename include guard.
2259         * tui/tui-wingeneral.h: Rename include guard.
2260         * tui/tui-windata.h: Rename include guard.
2261         * tui/tui-win.h: Rename include guard.
2262         * tui/tui-stack.h: Rename include guard.
2263         * tui/tui-source.h: Rename include guard.
2264         * tui/tui-regs.h: Rename include guard.
2265         * tui/tui-out.h: Rename include guard.
2266         * tui/tui-layout.h: Rename include guard.
2267         * tui/tui-io.h: Rename include guard.
2268         * tui/tui-hooks.h: Rename include guard.
2269         * tui/tui-file.h: Rename include guard.
2270         * tui/tui-disasm.h: Rename include guard.
2271         * tui/tui-data.h: Rename include guard.
2272         * tui/tui-command.h: Rename include guard.
2273         * tic6x-tdep.h: Add include guard.
2274         * target/waitstatus.h: Rename include guard.
2275         * target/wait.h: Rename include guard.
2276         * target/target.h: Rename include guard.
2277         * target/resume.h: Rename include guard.
2278         * target-float.h: Rename include guard.
2279         * stabsread.h: Add include guard.
2280         * rs6000-tdep.h: Add include guard.
2281         * riscv-fbsd-tdep.h: Add include guard.
2282         * regformats/regdef.h: Rename include guard.
2283         * record.h: Rename include guard.
2284         * python/python.h: Rename include guard.
2285         * python/python-internal.h: Rename include guard.
2286         * python/py-stopevent.h: Rename include guard.
2287         * python/py-ref.h: Rename include guard.
2288         * python/py-record.h: Rename include guard.
2289         * python/py-record-full.h: Rename include guard.
2290         * python/py-record-btrace.h: Rename include guard.
2291         * python/py-instruction.h: Rename include guard.
2292         * python/py-events.h: Rename include guard.
2293         * python/py-event.h: Rename include guard.
2294         * procfs.h: Add include guard.
2295         * proc-utils.h: Add include guard.
2296         * p-lang.h: Add include guard.
2297         * or1k-tdep.h: Rename include guard.
2298         * observable.h: Rename include guard.
2299         * nto-tdep.h: Rename include guard.
2300         * nat/x86-linux.h: Rename include guard.
2301         * nat/x86-linux-dregs.h: Rename include guard.
2302         * nat/x86-gcc-cpuid.h: Add include guard.
2303         * nat/x86-dregs.h: Rename include guard.
2304         * nat/x86-cpuid.h: Rename include guard.
2305         * nat/ppc-linux.h: Rename include guard.
2306         * nat/mips-linux-watch.h: Rename include guard.
2307         * nat/linux-waitpid.h: Rename include guard.
2308         * nat/linux-ptrace.h: Rename include guard.
2309         * nat/linux-procfs.h: Rename include guard.
2310         * nat/linux-osdata.h: Rename include guard.
2311         * nat/linux-nat.h: Rename include guard.
2312         * nat/linux-namespaces.h: Rename include guard.
2313         * nat/linux-btrace.h: Rename include guard.
2314         * nat/glibc_thread_db.h: Rename include guard.
2315         * nat/gdb_thread_db.h: Rename include guard.
2316         * nat/gdb_ptrace.h: Rename include guard.
2317         * nat/fork-inferior.h: Rename include guard.
2318         * nat/amd64-linux-siginfo.h: Rename include guard.
2319         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2320         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2321         * nat/aarch64-linux.h: Rename include guard.
2322         * nat/aarch64-linux-hw-point.h: Rename include guard.
2323         * mn10300-tdep.h: Add include guard.
2324         * mips-linux-tdep.h: Add include guard.
2325         * mi/mi-parse.h: Rename include guard.
2326         * mi/mi-out.h: Rename include guard.
2327         * mi/mi-main.h: Rename include guard.
2328         * mi/mi-interp.h: Rename include guard.
2329         * mi/mi-getopt.h: Rename include guard.
2330         * mi/mi-console.h: Rename include guard.
2331         * mi/mi-common.h: Rename include guard.
2332         * mi/mi-cmds.h: Rename include guard.
2333         * mi/mi-cmd-break.h: Rename include guard.
2334         * m2-lang.h: Add include guard.
2335         * location.h: Rename include guard.
2336         * linux-record.h: Rename include guard.
2337         * linux-nat.h: Add include guard.
2338         * linux-fork.h: Add include guard.
2339         * i386-darwin-tdep.h: Rename include guard.
2340         * hppa-linux-offsets.h: Add include guard.
2341         * guile/guile.h: Rename include guard.
2342         * guile/guile-internal.h: Rename include guard.
2343         * gnu-nat.h: Rename include guard.
2344         * gdb-stabs.h: Rename include guard.
2345         * frv-tdep.h: Add include guard.
2346         * f-lang.h: Add include guard.
2347         * event-loop.h: Add include guard.
2348         * darwin-nat.h: Rename include guard.
2349         * cp-abi.h: Rename include guard.
2350         * config/sparc/nm-sol2.h: Rename include guard.
2351         * config/nm-nto.h: Rename include guard.
2352         * config/nm-linux.h: Add include guard.
2353         * config/i386/nm-i386gnu.h: Rename include guard.
2354         * config/djgpp/nl_types.h: Rename include guard.
2355         * config/djgpp/langinfo.h: Rename include guard.
2356         * compile/gcc-cp-plugin.h: Add include guard.
2357         * compile/gcc-c-plugin.h: Add include guard.
2358         * compile/compile.h: Rename include guard.
2359         * compile/compile-object-run.h: Rename include guard.
2360         * compile/compile-object-load.h: Rename include guard.
2361         * compile/compile-internal.h: Rename include guard.
2362         * compile/compile-cplus.h: Rename include guard.
2363         * compile/compile-c.h: Rename include guard.
2364         * common/xml-utils.h: Rename include guard.
2365         * common/x86-xstate.h: Rename include guard.
2366         * common/version.h: Rename include guard.
2367         * common/vec.h: Rename include guard.
2368         * common/tdesc.h: Rename include guard.
2369         * common/selftest.h: Rename include guard.
2370         * common/scoped_restore.h: Rename include guard.
2371         * common/scoped_mmap.h: Rename include guard.
2372         * common/scoped_fd.h: Rename include guard.
2373         * common/safe-iterator.h: Rename include guard.
2374         * common/run-time-clock.h: Rename include guard.
2375         * common/refcounted-object.h: Rename include guard.
2376         * common/queue.h: Rename include guard.
2377         * common/ptid.h: Rename include guard.
2378         * common/print-utils.h: Rename include guard.
2379         * common/preprocessor.h: Rename include guard.
2380         * common/pathstuff.h: Rename include guard.
2381         * common/observable.h: Rename include guard.
2382         * common/netstuff.h: Rename include guard.
2383         * common/job-control.h: Rename include guard.
2384         * common/host-defs.h: Rename include guard.
2385         * common/gdb_wait.h: Rename include guard.
2386         * common/gdb_vecs.h: Rename include guard.
2387         * common/gdb_unlinker.h: Rename include guard.
2388         * common/gdb_unique_ptr.h: Rename include guard.
2389         * common/gdb_tilde_expand.h: Rename include guard.
2390         * common/gdb_sys_time.h: Rename include guard.
2391         * common/gdb_string_view.h: Rename include guard.
2392         * common/gdb_splay_tree.h: Rename include guard.
2393         * common/gdb_setjmp.h: Rename include guard.
2394         * common/gdb_ref_ptr.h: Rename include guard.
2395         * common/gdb_optional.h: Rename include guard.
2396         * common/gdb_locale.h: Rename include guard.
2397         * common/gdb_assert.h: Rename include guard.
2398         * common/filtered-iterator.h: Rename include guard.
2399         * common/filestuff.h: Rename include guard.
2400         * common/fileio.h: Rename include guard.
2401         * common/environ.h: Rename include guard.
2402         * common/common-utils.h: Rename include guard.
2403         * common/common-types.h: Rename include guard.
2404         * common/common-regcache.h: Rename include guard.
2405         * common/common-inferior.h: Rename include guard.
2406         * common/common-gdbthread.h: Rename include guard.
2407         * common/common-exceptions.h: Rename include guard.
2408         * common/common-defs.h: Rename include guard.
2409         * common/common-debug.h: Rename include guard.
2410         * common/cleanups.h: Rename include guard.
2411         * common/buffer.h: Rename include guard.
2412         * common/btrace-common.h: Rename include guard.
2413         * common/break-common.h: Rename include guard.
2414         * cli/cli-utils.h: Rename include guard.
2415         * cli/cli-style.h: Rename include guard.
2416         * cli/cli-setshow.h: Rename include guard.
2417         * cli/cli-script.h: Rename include guard.
2418         * cli/cli-interp.h: Rename include guard.
2419         * cli/cli-decode.h: Rename include guard.
2420         * cli/cli-cmds.h: Rename include guard.
2421         * charset-list.h: Add include guard.
2422         * buildsym-legacy.h: Rename include guard.
2423         * bfin-tdep.h: Add include guard.
2424         * ax.h: Rename include guard.
2425         * arm-linux-tdep.h: Add include guard.
2426         * arm-fbsd-tdep.h: Add include guard.
2427         * arch/xtensa.h: Rename include guard.
2428         * arch/tic6x.h: Add include guard.
2429         * arch/i386.h: Add include guard.
2430         * arch/arm.h: Rename include guard.
2431         * arch/arm-linux.h: Rename include guard.
2432         * arch/arm-get-next-pcs.h: Rename include guard.
2433         * arch/amd64.h: Add include guard.
2434         * arch/aarch64-insn.h: Rename include guard.
2435         * arch-utils.h: Rename include guard.
2436         * annotate.h: Add include guard.
2437         * amd64-darwin-tdep.h: Rename include guard.
2438         * aarch64-linux-tdep.h: Add include guard.
2439         * aarch64-fbsd-tdep.h: Add include guard.
2440         * aarch32-linux-nat.h: Add include guard.
2441
2442 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2443
2444         * macrotab.c (macro_define_internal): New function that
2445         factorizes macro_define_object_internal and macro_define_function
2446         code.
2447         (macro_define_object_internal): Use macro_define_internal.
2448         (macro_define_function): Likewise.
2449
2450 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2451
2452         * macrocmd.c (extract_identifier): Return
2453         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2454         callers.
2455
2456 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2457
2458         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2459
2460 2019-02-05  Tom Tromey  <tom@tromey.com>
2461
2462         * target.c (target_stack::unpush): Move assertion earlier.
2463
2464 2019-01-30  Tom Tromey  <tom@tromey.com>
2465
2466         PR python/23615:
2467         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2468         (gdbpy_parse_and_eval): Likewise.
2469         * python/python-internal.h (gdbpy_allow_threads): New class.
2470
2471 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2472
2473         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2474         (aarch64_fbsd_fpregmap): Move earlier.
2475         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2476         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2477         instead of individual calls to trad_frame_set_reg_addr.
2478         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2479         earlier.
2480         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2481         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2482         instead of individual calls to trad_frame_set_reg_addr.
2483
2484 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2485
2486         * CONTRIBUTE: Replace contribution list with wiki link.
2487
2488 2019-01-25  Tom Tromey  <tom@tromey.com>
2489
2490         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2491
2492 2019-01-25  Tom Tromey  <tom@tromey.com>
2493
2494         * xtensa-linux-nat.c: Fix common/ includes.
2495         * xml-support.h: Fix common/ includes.
2496         * xml-support.c: Fix common/ includes.
2497         * x86-linux-nat.c: Fix common/ includes.
2498         * windows-nat.c: Fix common/ includes.
2499         * varobj.h: Fix common/ includes.
2500         * varobj.c: Fix common/ includes.
2501         * value.c: Fix common/ includes.
2502         * valops.c: Fix common/ includes.
2503         * utils.c: Fix common/ includes.
2504         * unittests/xml-utils-selftests.c: Fix common/ includes.
2505         * unittests/utils-selftests.c: Fix common/ includes.
2506         * unittests/unpack-selftests.c: Fix common/ includes.
2507         * unittests/tracepoint-selftests.c: Fix common/ includes.
2508         * unittests/style-selftests.c: Fix common/ includes.
2509         * unittests/string_view-selftests.c: Fix common/ includes.
2510         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2511         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2512         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2513         * unittests/rsp-low-selftests.c: Fix common/ includes.
2514         * unittests/parse-connection-spec-selftests.c: Fix common/
2515         includes.
2516         * unittests/optional-selftests.c: Fix common/ includes.
2517         * unittests/offset-type-selftests.c: Fix common/ includes.
2518         * unittests/observable-selftests.c: Fix common/ includes.
2519         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2520         * unittests/memrange-selftests.c: Fix common/ includes.
2521         * unittests/memory-map-selftests.c: Fix common/ includes.
2522         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2523         * unittests/function-view-selftests.c: Fix common/ includes.
2524         * unittests/environ-selftests.c: Fix common/ includes.
2525         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2526         * unittests/common-utils-selftests.c: Fix common/ includes.
2527         * unittests/cli-utils-selftests.c: Fix common/ includes.
2528         * unittests/array-view-selftests.c: Fix common/ includes.
2529         * ui-file.c: Fix common/ includes.
2530         * tui/tui-io.c: Fix common/ includes.
2531         * tracepoint.h: Fix common/ includes.
2532         * tracepoint.c: Fix common/ includes.
2533         * tracefile-tfile.c: Fix common/ includes.
2534         * top.h: Fix common/ includes.
2535         * top.c: Fix common/ includes.
2536         * thread.c: Fix common/ includes.
2537         * target/waitstatus.h: Fix common/ includes.
2538         * target/waitstatus.c: Fix common/ includes.
2539         * target.h: Fix common/ includes.
2540         * target.c: Fix common/ includes.
2541         * target-memory.c: Fix common/ includes.
2542         * target-descriptions.c: Fix common/ includes.
2543         * symtab.h: Fix common/ includes.
2544         * symfile.c: Fix common/ includes.
2545         * stap-probe.c: Fix common/ includes.
2546         * spu-linux-nat.c: Fix common/ includes.
2547         * sparc-nat.c: Fix common/ includes.
2548         * source.c: Fix common/ includes.
2549         * solib.c: Fix common/ includes.
2550         * solib-target.c: Fix common/ includes.
2551         * ser-unix.c: Fix common/ includes.
2552         * ser-tcp.c: Fix common/ includes.
2553         * ser-pipe.c: Fix common/ includes.
2554         * ser-base.c: Fix common/ includes.
2555         * selftest-arch.c: Fix common/ includes.
2556         * s12z-tdep.c: Fix common/ includes.
2557         * rust-exp.y: Fix common/ includes.
2558         * rs6000-aix-tdep.c: Fix common/ includes.
2559         * riscv-tdep.c: Fix common/ includes.
2560         * remote.c: Fix common/ includes.
2561         * remote-notif.h: Fix common/ includes.
2562         * remote-fileio.h: Fix common/ includes.
2563         * remote-fileio.c: Fix common/ includes.
2564         * regcache.h: Fix common/ includes.
2565         * regcache.c: Fix common/ includes.
2566         * record-btrace.c: Fix common/ includes.
2567         * python/python.c: Fix common/ includes.
2568         * python/py-type.c: Fix common/ includes.
2569         * python/py-inferior.c: Fix common/ includes.
2570         * progspace.h: Fix common/ includes.
2571         * producer.c: Fix common/ includes.
2572         * procfs.c: Fix common/ includes.
2573         * proc-api.c: Fix common/ includes.
2574         * printcmd.c: Fix common/ includes.
2575         * ppc-linux-nat.c: Fix common/ includes.
2576         * parser-defs.h: Fix common/ includes.
2577         * osdata.c: Fix common/ includes.
2578         * obsd-nat.c: Fix common/ includes.
2579         * nat/x86-linux.c: Fix common/ includes.
2580         * nat/x86-linux-dregs.c: Fix common/ includes.
2581         * nat/x86-dregs.h: Fix common/ includes.
2582         * nat/x86-dregs.c: Fix common/ includes.
2583         * nat/ppc-linux.c: Fix common/ includes.
2584         * nat/mips-linux-watch.h: Fix common/ includes.
2585         * nat/mips-linux-watch.c: Fix common/ includes.
2586         * nat/linux-waitpid.c: Fix common/ includes.
2587         * nat/linux-ptrace.h: Fix common/ includes.
2588         * nat/linux-ptrace.c: Fix common/ includes.
2589         * nat/linux-procfs.c: Fix common/ includes.
2590         * nat/linux-personality.c: Fix common/ includes.
2591         * nat/linux-osdata.c: Fix common/ includes.
2592         * nat/linux-namespaces.c: Fix common/ includes.
2593         * nat/linux-btrace.h: Fix common/ includes.
2594         * nat/linux-btrace.c: Fix common/ includes.
2595         * nat/fork-inferior.c: Fix common/ includes.
2596         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2597         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2598         * nat/aarch64-linux.c: Fix common/ includes.
2599         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2600         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2601         * namespace.h: Fix common/ includes.
2602         * mips-linux-tdep.c: Fix common/ includes.
2603         * minsyms.c: Fix common/ includes.
2604         * mi/mi-parse.h: Fix common/ includes.
2605         * mi/mi-main.c: Fix common/ includes.
2606         * mi/mi-cmd-env.c: Fix common/ includes.
2607         * memrange.h: Fix common/ includes.
2608         * memattr.c: Fix common/ includes.
2609         * maint.h: Fix common/ includes.
2610         * maint.c: Fix common/ includes.
2611         * main.c: Fix common/ includes.
2612         * machoread.c: Fix common/ includes.
2613         * location.c: Fix common/ includes.
2614         * linux-thread-db.c: Fix common/ includes.
2615         * linux-nat.c: Fix common/ includes.
2616         * linux-fork.c: Fix common/ includes.
2617         * inline-frame.c: Fix common/ includes.
2618         * infrun.c: Fix common/ includes.
2619         * inflow.c: Fix common/ includes.
2620         * inferior.h: Fix common/ includes.
2621         * inferior.c: Fix common/ includes.
2622         * infcmd.c: Fix common/ includes.
2623         * inf-ptrace.c: Fix common/ includes.
2624         * inf-child.c: Fix common/ includes.
2625         * ia64-linux-nat.c: Fix common/ includes.
2626         * i387-tdep.c: Fix common/ includes.
2627         * i386-tdep.c: Fix common/ includes.
2628         * i386-linux-tdep.c: Fix common/ includes.
2629         * i386-linux-nat.c: Fix common/ includes.
2630         * i386-go32-tdep.c: Fix common/ includes.
2631         * i386-fbsd-tdep.c: Fix common/ includes.
2632         * i386-fbsd-nat.c: Fix common/ includes.
2633         * guile/scm-type.c: Fix common/ includes.
2634         * guile/guile.c: Fix common/ includes.
2635         * go32-nat.c: Fix common/ includes.
2636         * gnu-nat.c: Fix common/ includes.
2637         * gdbthread.h: Fix common/ includes.
2638         * gdbarch-selftests.c: Fix common/ includes.
2639         * gdb_usleep.c: Fix common/ includes.
2640         * gdb_select.h: Fix common/ includes.
2641         * gdb_bfd.c: Fix common/ includes.
2642         * gcore.c: Fix common/ includes.
2643         * fork-child.c: Fix common/ includes.
2644         * findvar.c: Fix common/ includes.
2645         * fbsd-nat.c: Fix common/ includes.
2646         * event-top.c: Fix common/ includes.
2647         * event-loop.c: Fix common/ includes.
2648         * dwarf2read.c: Fix common/ includes.
2649         * dwarf2loc.c: Fix common/ includes.
2650         * dwarf2-frame.c: Fix common/ includes.
2651         * dwarf-index-cache.c: Fix common/ includes.
2652         * dtrace-probe.c: Fix common/ includes.
2653         * disasm-selftests.c: Fix common/ includes.
2654         * defs.h: Fix common/ includes.
2655         * csky-tdep.c: Fix common/ includes.
2656         * cp-valprint.c: Fix common/ includes.
2657         * cp-support.h: Fix common/ includes.
2658         * cp-support.c: Fix common/ includes.
2659         * corelow.c: Fix common/ includes.
2660         * completer.h: Fix common/ includes.
2661         * completer.c: Fix common/ includes.
2662         * compile/compile.c: Fix common/ includes.
2663         * compile/compile-loc2c.c: Fix common/ includes.
2664         * compile/compile-cplus-types.c: Fix common/ includes.
2665         * compile/compile-cplus-symbols.c: Fix common/ includes.
2666         * command.h: Fix common/ includes.
2667         * cli/cli-dump.c: Fix common/ includes.
2668         * cli/cli-cmds.c: Fix common/ includes.
2669         * charset.c: Fix common/ includes.
2670         * build-id.c: Fix common/ includes.
2671         * btrace.h: Fix common/ includes.
2672         * btrace.c: Fix common/ includes.
2673         * breakpoint.h: Fix common/ includes.
2674         * breakpoint.c: Fix common/ includes.
2675         * ax.h:
2676         (enum agent_op): Fix common/ includes.
2677         * ax-general.c (struct aop_map): Fix common/ includes.
2678         * ax-gdb.c: Fix common/ includes.
2679         * auxv.c: Fix common/ includes.
2680         * auto-load.c: Fix common/ includes.
2681         * arm-tdep.c: Fix common/ includes.
2682         * arch/riscv.c: Fix common/ includes.
2683         * arch/ppc-linux-common.c: Fix common/ includes.
2684         * arch/i386.c: Fix common/ includes.
2685         * arch/arm.c: Fix common/ includes.
2686         * arch/arm-linux.c: Fix common/ includes.
2687         * arch/arm-get-next-pcs.c: Fix common/ includes.
2688         * arch/amd64.c: Fix common/ includes.
2689         * arch/aarch64.c: Fix common/ includes.
2690         * arch/aarch64-insn.c: Fix common/ includes.
2691         * arch-utils.c: Fix common/ includes.
2692         * amd64-windows-tdep.c: Fix common/ includes.
2693         * amd64-tdep.c: Fix common/ includes.
2694         * amd64-sol2-tdep.c: Fix common/ includes.
2695         * amd64-obsd-tdep.c: Fix common/ includes.
2696         * amd64-nbsd-tdep.c: Fix common/ includes.
2697         * amd64-linux-tdep.c: Fix common/ includes.
2698         * amd64-linux-nat.c: Fix common/ includes.
2699         * amd64-fbsd-tdep.c: Fix common/ includes.
2700         * amd64-fbsd-nat.c: Fix common/ includes.
2701         * amd64-dicos-tdep.c: Fix common/ includes.
2702         * amd64-darwin-tdep.c: Fix common/ includes.
2703         * agent.c: Fix common/ includes.
2704         * ada-lang.h: Fix common/ includes.
2705         * ada-lang.c: Fix common/ includes.
2706         * aarch64-tdep.c: Fix common/ includes.
2707
2708 2019-01-25  Tom Tromey  <tom@tromey.com>
2709
2710         * common/create-version.sh: Use common/version.h.
2711
2712 2019-01-24  Pedro Alves  <palves@redhat.com>
2713
2714         * infrun.c (signal_stop, signal_print, signal_program)
2715         (signal_catch, signal_pass): Now arrays instead of pointers.
2716         (update_signals_program_target, do_target_resume)
2717         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2718         * linux-nat.c (linux_nat_target::pass_signals)
2719         (linux_nat_target::create_inferior, linux_nat_target::attach):
2720         Adjust.
2721         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2722         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2723         * procfs.c (procfs_target::pass_signals): Adjust.
2724         * record-full.c (record_full_target::resume): Adjust.
2725         * remote.c (remote_target::pass_signals)
2726         (remote_target::program_signals): Adjust.
2727         * target-debug.h (target_debug_print_signals): Now takes a
2728         gdb::array_view as parameter.  Adjust.
2729         * target.h (target_ops) <pass_signals, program_signals>: Replace
2730         pointer and length parameters with gdb::array_view.
2731         (target_pass_signals, target_program_signals): Likewise.
2732         * target-delegates.c: Regenerate.
2733
2734 2019-01-24  Pedro Alves  <palves@redhat.com>
2735
2736         * common/forward-scope-exit.h
2737         (forward_scope_exit::forward_scope_exit): Pass arguments to
2738         m_bind_function directly, instead of creating a std::bind and
2739         copying that.
2740
2741 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2744         for static members.
2745         (pass_in_v_vfp_candidate): Likewise.
2746
2747 2019-01-23  Tom Tromey  <tom@tromey.com>
2748             Pedro Alves  <palves@redhat.com>
2749
2750         * regcache.c (class regcache_invalidator): Remove.
2751         (regcache::raw_write): Use make_scope_exit.
2752
2753 2019-01-23  Tom Tromey  <tom@tromey.com>
2754
2755         * ui-out.h (class ui_out_emit_type): Update comment.
2756
2757 2019-01-23  Tom Tromey  <tom@tromey.com>
2758
2759         * infrun.c (fetch_inferior_event): Update comment.
2760
2761 2019-01-23  Tom Tromey  <tom@tromey.com>
2762             Pedro Alves  <palves@redhat.com>
2763
2764         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2765         parameter.
2766         (fetch_inferior_event): Use SCOPE_EXIT.
2767
2768
2769 2019-01-23  Tom Tromey  <tom@tromey.com>
2770             Pedro Alves  <palves@redhat.com>
2771
2772         * infrun.c (disable_thread_events): Delete.
2773         (stop_all_threads): Use SCOPE_EXIT.
2774
2775 2019-01-23  Tom Tromey  <tom@tromey.com>
2776             Pedro Alves  <palves@redhat.com>
2777
2778         * symfile.c: Include forward-scope-exit.h.
2779         (clear_symtab_users_cleanup): Replace forward declaration with
2780         a FORWARD_SCOPE_EXIT.
2781         (syms_from_objfile_1): Use the forward_scope_exit and
2782         gdb::optional instead of cleanup_function.
2783         (reread_symbols): Use the forward_scope_exit instead of
2784         cleanup_function.
2785         (clear_symtab_users_cleanup): Remove function.
2786
2787 2019-01-23  Tom Tromey  <tom@tromey.com>
2788             Pedro Alves  <palves@redhat.com>
2789
2790         * linux-nat.c: Include scope-exit.h.
2791         (cleanup_target_stop): Remove.
2792         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2793         SCOPE_EXIT.
2794
2795 2019-01-23  Tom Tromey  <tom@tromey.com>
2796             Pedro Alves  <palves@redhat.com>
2797
2798         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2799         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2800
2801 2019-01-23  Tom Tromey  <tom@tromey.com>
2802             Andrew Burgess  <andrew.burgess@embecosm.com>
2803             Pedro Alves  <palves@redhat.com>
2804
2805         * infrun.c (fetch_inferior_event): Use scope_exit.
2806         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2807         * top.c (execute_command): Use scope_exit.
2808         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2809         * utils.c (do_bpstat_clear_actions_cleanup)
2810         (make_bpstat_clear_actions_cleanup): Remove.
2811
2812 2019-01-23  Tom Tromey  <tom@tromey.com>
2813             Pedro Alves  <palves@redhat.com>
2814
2815         * infrun.c: Include "common/scope-exit.h"
2816         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2817         (wait_for_inferior): Use SCOPE_EXIT.
2818         (fetch_inferior_event): Use scope_exit.
2819
2820 2019-01-23  Tom Tromey  <tom@tromey.com>
2821             Pedro Alves  <palves@redhat.com>
2822
2823         * breakpoint.c (create_breakpoint): Remove cleanup.
2824
2825 2019-01-23  Tom Tromey  <tom@tromey.com>
2826             Andrew Burgess  <andrew.burgess@embecosm.com>
2827             Pedro Alves  <palves@redhat.com>
2828
2829 2019-01-23  Pedro Alves  <palves@redhat.com>
2830
2831         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2832
2833 2019-01-23  Pedro Alves  <palves@redhat.com>
2834             Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * gdbthread.h: Include "common/forward-scope-exit.h".
2837         (scoped_finish_thread_state): Redefine custom class in terms of
2838         forward_scope_exit.
2839
2840 2019-01-23  Pedro Alves  <palves@redhat.com>
2841             Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * common/forward-scope-exit.h: New file.
2844
2845 2019-01-23  Pedro Alves  <palves@redhat.com>
2846             Andrew Burgess  <andrew.burgess@embecosm.com>
2847             Tom Tromey  <tom@tromey.com>
2848
2849         * common/scope-exit.h: New file.
2850
2851 2019-01-23  Pedro Alves  <palves@redhat.com>
2852
2853         * common/preprocessor.h (ESC): Rename to ...
2854         (ESC_PARENS): ... this.
2855         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2856         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2857
2858 2019-01-23  Tom Tromey  <tom@tromey.com>
2859
2860         * language.h (class scoped_switch_to_sym_language_if_auto):
2861         Initialize m_lang in both cases.
2862
2863 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2864
2865         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2866         with XCNEW.
2867
2868 2019-01-22  Tom Tromey  <tom@tromey.com>
2869
2870         * corelow.c: Do not include sys/file.h.
2871
2872 2019-01-22  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-wingeneral.h: Include gdb_curses.h.
2875
2876 2019-01-22  Tom Tromey  <tom@tromey.com>
2877
2878         * source-cache.h (class source_cache) <get_source_lines,
2879         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2880
2881 2019-01-22  Tom Tromey  <tom@tromey.com>
2882
2883         * remote-fileio.h (struct remote_target): Declare.
2884
2885 2019-01-22  Tom Tromey  <tom@tromey.com>
2886
2887         * python/py-arch.c: Do not include py-ref.h.
2888         * python/py-bpevent.c: Do not include py-ref.h.
2889         * python/py-cmd.c: Do not include py-ref.h.
2890         * python/py-continueevent.c: Do not include py-ref.h.
2891         * python/py-event.h: Do not include py-ref.h.
2892         * python/py-evtregistry.c: Do not include py-ref.h.
2893         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2894         * python/py-frame.c: Do not include py-ref.h.
2895         * python/py-framefilter.c: Do not include py-ref.h.
2896         * python/py-function.c: Do not include py-ref.h.
2897         * python/py-infevents.c: Do not include py-ref.h.
2898         * python/py-linetable.c: Do not include py-ref.h.
2899         * python/py-objfile.c: Do not include py-ref.h.
2900         * python/py-param.c: Do not include py-ref.h.
2901         * python/py-prettyprint.c: Do not include py-ref.h.
2902         * python/py-progspace.c: Do not include py-ref.h.
2903         * python/py-symbol.c: Do not include py-ref.h.
2904         * python/py-symtab.c: Do not include py-ref.h.
2905         * python/py-type.c: Do not include py-ref.h.
2906         * python/py-unwind.c: Do not include py-ref.h.
2907         * python/py-utils.c: Do not include py-ref.h.
2908         * python/py-value.c: Do not include py-ref.h.
2909         * python/py-varobj.c: Do not include py-ref.h.
2910         * python/py-xmethods.c: Do not include py-ref.h.
2911         * python/python.c: Do not include py-ref.h.
2912         * varobj.c: Do not include py-ref.h.
2913
2914 2019-01-22  Tom Tromey  <tom@tromey.com>
2915
2916         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2917         keyword for bcache.
2918
2919 2019-01-22  Tom Tromey  <tom@tromey.com>
2920
2921         * compile/compile-cplus-types.c: Remove a comment by #include.
2922
2923 2019-01-22  Tom Tromey  <tom@tromey.com>
2924
2925         * compile/gcc-c-plugin.h: Include compile-internal.h.
2926
2927 2019-01-22  Tom Tromey  <tom@tromey.com>
2928
2929         * stabsread.c (EXTERN): Do not define.
2930         (symnum, next_symbol_text_func, processing_gcc_compilation)
2931         (within_function, global_sym_chain, global_stabs)
2932         (previous_stab_code, this_object_header_files)
2933         (n_this_object_header_files)
2934         (n_allocated_this_object_header_files): Define.
2935         * stabsread.h (EXTERN): Never define.  Use "extern".
2936
2937 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2938
2939         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2940         history_value.
2941
2942 2019-01-21  Tom Tromey  <tom@tromey.com>
2943
2944         * ui-out.c: Fix includes.
2945         * tui/tui-source.c: Fix includes.
2946         * target.c: Fix includes.
2947         * remote.c: Fix includes.
2948         * regcache.c: Fix includes.
2949         * python/py-block.c: Fix includes.
2950         * printcmd.c: Fix includes.
2951         * or1k-tdep.c: Fix includes.
2952         * mi/mi-main.c: Fix includes.
2953         * m32r-tdep.c: Fix includes.
2954         * csky-tdep.c: Fix includes.
2955         * compile/compile-cplus-types.c: Fix includes.
2956         * cli/cli-interp.c: Fix includes.
2957
2958 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2959
2960         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2961         for padding.
2962
2963 2019-01-16  Tom Tromey  <tom@tromey.com>
2964
2965         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2966         earlier.
2967         (struct objfile) <msymbols_range>: Move from top level.
2968         <msymbols>: New method.
2969         (class objfile_msymbols): Remove.
2970         * symtab.c (default_collect_symbol_completion_matches_break_on):
2971         Update.
2972         * symmisc.c (dump_msymbols): Update.
2973         * stabsread.c (scan_file_globals): Update.
2974         * objc-lang.c (info_selectors_command, info_classes_command)
2975         (find_methods): Update.
2976         * minsyms.c (find_solib_trampoline_target): Update.
2977         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2978         * coffread.c (coff_symfile_read): Update.
2979         * ada-lang.c (ada_lookup_simple_minsym)
2980         (ada_collect_symbol_completion_matches): Update.
2981
2982 2019-01-16  Tom Tromey  <tom@tromey.com>
2983
2984         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2985         type.  Remove no-argument constructor.
2986         <iterator::operator++>: Simplify.
2987         <begin>: Update.
2988         <end>: Use minimal_symbol_count.
2989
2990 2019-01-16  Tom Tromey  <tom@tromey.com>
2991
2992         * objfiles.h (struct objfile) <psymtabs>: New method.
2993         (class objfile_psymtabs): Remove.
2994         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2995         typedef.
2996         <range>: New method.
2997         (require_partial_symbols): Change return type.
2998         * psymtab.c (require_partial_symbols)
2999         (psym_expand_symtabs_matching): Update.
3000         * mdebugread.c (parse_partial_symbols): Update.
3001         * dbxread.c (dbx_end_psymtab): Update.
3002
3003 2019-01-15  Tom Tromey  <tom@tromey.com>
3004
3005         * symtab.c (lookup_objfile_from_block)
3006         (lookup_symbol_in_objfile_symtabs)
3007         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3008         (find_line_symtab, info_sources_command)
3009         (default_collect_symbol_completion_matches_break_on)
3010         (make_source_files_completion_list): Update.
3011         * symmisc.c (print_objfile_statistics, dump_objfile)
3012         (maintenance_print_symbols, maintenance_info_symtabs)
3013         (maintenance_check_symtabs, maintenance_info_line_tables):
3014         Update.
3015         * source.c (select_source_symtab)
3016         (forget_cached_source_info_for_objfile): Update.
3017         * objfiles.h (class objfile_compunits): Remove.
3018         (struct objfile) <compunits_range>: New typedef.
3019         (compunits): New method.
3020         * objfiles.c (objfile_relocate1): Update.
3021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3022         * maint.c (count_symtabs_and_blocks): Update.
3023         * linespec.c (iterate_over_all_matching_symtabs): Update.
3024         * cp-support.c (add_symbol_overload_list_qualified): Update.
3025         * coffread.c (coff_symtab_read): Update.
3026         * ada-lang.c (add_nonlocal_symbols)
3027         (ada_collect_symbol_completion_matches)
3028         (ada_add_global_exceptions): Update.
3029
3030 2019-01-15  Tom Tromey  <tom@tromey.com>
3031
3032         * progspace.h (program_space) <objfiles_safe_range>: New
3033         typedef.
3034         <objfiles_safe>: New method.
3035         * objfiles.h (class all_objfiles_safe): Remove.
3036         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3037         * jit.c (jit_inferior_exit_hook): Update.
3038
3039 2019-01-17  Tom Tromey  <tom@tromey.com>
3040
3041         * progspace.h (program_space) <objfiles_range>: New typedef.
3042         <objfiles>: New method.
3043         <objfiles_head>: Rename from objfiles.
3044         (object_files): Update.
3045         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3046         * guile/scm-pretty-print.c
3047         (ppscm_find_pretty_printer_from_objfiles): Update.
3048         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3049         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3050         Update.
3051         * python/py-progspace.c (pspy_get_objfiles): Update.
3052         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3053         Update.
3054         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3055         (objfpy_lookup_objfile_by_build_id): Update.
3056         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3057         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3058         Update.
3059         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3060         (expand_symtab_containing_pc, lookup_objfile_from_block)
3061         (lookup_static_symbol, basic_lookup_transparent_type)
3062         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3063         (find_line_symtab, info_sources_command)
3064         (default_collect_symbol_completion_matches_break_on)
3065         (make_source_files_completion_list, find_main_name): Update.
3066         * symmisc.c (print_symbol_bcache_statistics)
3067         (print_objfile_statistics, maintenance_print_symbols)
3068         (maintenance_print_msymbols, maintenance_print_objfiles)
3069         (maintenance_info_symtabs, maintenance_check_symtabs)
3070         (maintenance_expand_symtabs, maintenance_info_line_tables):
3071         Update.
3072         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3073         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3074         (map_overlay_command, unmap_overlay_command)
3075         (simple_overlay_update, expand_symtabs_matching)
3076         (map_symbol_filenames): Update.
3077         * symfile-debug.c (set_debug_symfile): Update.
3078         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3079         Update.
3080         * source.c (select_source_symtab, forget_cached_source_info):
3081         Update.
3082         * solib.c (solib_read_symbols): Update.
3083         * solib-spu.c (append_ocl_sos): Update.
3084         * psymtab.c (maintenance_print_psymbols)
3085         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3086         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3087         * printcmd.c (info_symbol_command): Update.
3088         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3089         Update.
3090         * objfiles.h (class all_objfiles): Remove.
3091         * objfiles.c (have_partial_symbols, have_full_symbols)
3092         (have_minimal_symbols, qsort_cmp, update_section_map)
3093         (shared_objfile_contains_address_p)
3094         (default_iterate_over_objfiles_in_search_order): Update.
3095         * objc-lang.c (info_selectors_command, info_classes_command)
3096         (find_methods): Update.
3097         * minsyms.c (find_solib_trampoline_target): Update.
3098         * maint.c (maintenance_info_sections)
3099         (maintenance_translate_address, count_symtabs_and_blocks):
3100         Update.
3101         * main.c (captured_main_1): Update.
3102         * linux-thread-db.c (try_thread_db_load_from_pdir)
3103         (has_libpthread): Update.
3104         * linespec.c (iterate_over_all_matching_symtabs)
3105         (search_minsyms_for_name): Update.
3106         * jit.c (jit_find_objf_with_entry_addr): Update.
3107         * hppa-tdep.c (find_unwind_entry)
3108         (hppa_lookup_stub_minimal_symbol): Update.
3109         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3110         Update.
3111         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3112         (elf_gnu_ifunc_resolve_by_got): Update.
3113         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3114         * dwarf-index-write.c (save_gdb_index_command): Update.
3115         * cp-support.c (add_symbol_overload_list_qualified): Update.
3116         * breakpoint.c (create_overlay_event_breakpoint)
3117         (create_longjmp_master_breakpoint)
3118         (create_std_terminate_master_breakpoint)
3119         (create_exception_master_breakpoint): Update.
3120         * blockframe.c (find_pc_partial_function): Update.
3121         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3122         (ada_collect_symbol_completion_matches)
3123         (ada_add_global_exceptions): Update.
3124
3125 2019-01-17  Tom Tromey  <tom@tromey.com>
3126
3127         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3128         declare VEC.
3129         (solib_target_parse_libraries): Change return type.
3130         (library_list_start_segment, library_list_start_section)
3131         (library_list_end_library, library_list_start_library); Update.
3132         (solib_target_free_library_list): Remove.
3133         (solib_target_parse_libraries): Remove cleanup.  Change return
3134         type.
3135         (solib_target_current_sos): Update.
3136
3137 2019-01-17  Tom Tromey  <tromey@bapiya>
3138
3139         * valprint.c: Replace "the the" with "the".
3140         * symtab.c: Replace "the the" with "the".
3141         * solib.c: Replace "the the" with "the".
3142         * solib-dsbt.c: Replace "the the" with "the".
3143         * linespec.c: Replace "the the" with "the".
3144         * dwarf2loc.h: Replace "the the" with "the".
3145         * amd64-windows-tdep.c: Replace "the the" with "the".
3146         * aarch64-tdep.c: Replace "the the" with "the".
3147
3148 2019-01-16  Keith Seitz  <keiths@redhat.com>
3149
3150         PR gdb/23773
3151         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3152         <builder>: Rename to ..
3153         <m_builder>: ... this and make private.
3154         (dwarf2_cu::get_builder): New method.  Change all users of
3155         `builder' to use this method.
3156         (dwarf2_start_symtab): Move to ...
3157         (dwarf2_cu::start_symtab): ... here.  Update all callers
3158         (setup_type_unit_groups): Move to ...
3159         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3160         callers.
3161         (dwarf2_cu::reset_builder): New method.
3162         (process_full_compunit, process_full_type_unit): Use
3163         dwarf2_cu::reset_builder.
3164         (follow_die_offset): Record the ancestor CU if it is different
3165         from the followed DIE's CU.
3166         (follow_die_sig_1): Likewise.
3167
3168 2019-01-15  Tom Tromey  <tom@tromey.com>
3169
3170         * remote.c (class remote_state) <buf>: Now a char_vector.
3171         <buf_size>: Remove.
3172         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3173         parameter.
3174         (remote_target::getpkt_or_notif_sane_1)
3175         (remote_target::getpkt_sane)
3176         (remote_target::getpkt_or_notif_sane): Likewise.
3177         (class remote_target) <putpkt>: New overload.
3178         (remote_target::read_frame): Change type of "buf_p".  Remove
3179         sizeof_p parameter.
3180         (packet_ok): New overload.
3181         (packet_check_result): New overload.
3182         Update all uses.
3183
3184 2019-01-14  Tom Tromey  <tom@tromey.com>
3185
3186         * remote-notif.c (handle_notification, remote_notif_ack)
3187         (remote_notif_parse): Make "buf" const.
3188         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3189         const.
3190         (remote_notif_parse, remote_notif_ack, handle_notification):
3191         Likewise.
3192         * remote.c (remote_notif_stop_parse): Make "buf" const.
3193         (remote_target::remote_parse_stop_reply): Make "buf" const.
3194         (remote_notif_stop_ack): Make "buf" const.
3195
3196 2019-01-14  Tom Tromey  <tom@tromey.com>
3197
3198         * remote.c (remote_console_output): Make parameter const.
3199
3200 2019-01-14  Tom Tromey  <tom@tromey.com>
3201
3202         * target-debug.h (target_debug_print_signals): Constify.
3203         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3204         * procfs.c (procfs_target::pass_signals): Update.
3205         * linux-nat.c (linux_nat_target::pass_signals): Update.
3206         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3207         * target-delegates.c: Rebuild.
3208         * remote.c (remote_target::program_signals): Update.
3209         (remote_target::pass_signals): Update.
3210         * target.c (target_pass_signals): Constify argument.
3211         (target_program_signals): Likewise.
3212         * target.h (struct target_ops) <pass_signals, program_signals>:
3213         Constify argument.
3214         (target_pass_signals, target_program_signals): Constify argument.
3215
3216 2019-01-14  Tom Tromey  <tom@tromey.com>
3217
3218         PR tui/28819:
3219         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3220
3221 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3222
3223         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3224         field.
3225         * rs6000-tdep.c: Include reggroups.h.
3226         (IS_V_ALIAS_PSEUDOREG): Define.
3227         (rs6000_register_name): Return names for the "vX" aliases.
3228         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3229         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3230         aliases.  Call default_register_reggroup_p for all other
3231         pseudo-registers.
3232         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3233         New functions.
3234         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3235         Handle "vX" aliases.
3236         (v_alias_pseudo_register_collect): New function.
3237         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3238         (rs6000_gdbarch_init): Initialize "vX" aliases as
3239         pseudo-registers.  Restore registration of
3240         rs6000_pseudo_register_reggroup_p with
3241         set_tdesc_pseudo_register_reggroup_p.
3242
3243 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3244
3245         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3246         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3247         set_gdbarch_num_pseudo_regs.
3248
3249 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3250
3251         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3252         Remove arg prefixname, add do_set and do_show.
3253         Add member functions set_list and show_list.
3254         * cli/cli-style.c (class cli_style_option): Update accordingly.
3255         (style_set_list): Move to file scope.
3256         (style_show_list): Likewise.
3257         (set_style): Call help_list.
3258         (show_style): Call cmd_show_list.
3259         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3260         Update to use the new macro.
3261
3262 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3263
3264         * ada-lang.c (_initialize_ada_language): Expand the help text
3265         for the "catch exception" command.
3266
3267 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3268
3269         * symtab.c (matching_obj_sections): Initialize obj,
3270         declare it closer to its usage.
3271
3272 2019-01-10  Tom Tromey  <tom@tromey.com>
3273
3274         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3275         (basic_inf_threads_range): Remove.
3276         (inf_threads_range, inf_non_exited_threads_range)
3277         (safe_inf_threads_range): Use next_adapter.
3278
3279 2019-01-10  Keith Seitz  <keiths@redhat.com>
3280
3281         PR gdb/23712
3282         PR symtab/23010
3283         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3284         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3285
3286 2019-01-10  Keith Seitz  <keiths@redhat.com>
3287
3288         PR gdb/23712
3289         PR symtab/23010
3290         * dictionary.c (pending_to_vector): Remove.
3291         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3292         Remove _1 suffix, replacing functions of the same name.  Update
3293         all callers.
3294         (dict_create_hashed, dict_create_hashed_expandable)
3295         (dict_create_linear, dict_create_linear_expandable, dict_free)
3296         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3297         Make functions static.
3298
3299 2019-01-10  Keith Seitz  <keiths@redhat.com>
3300
3301         PR gdb/23712
3302         PR symtab/23010
3303         * dictionary.h (struct dictionary): Replace declaration with
3304         multidictionary.
3305         (dict_create_hashed, dict_create_hashed_expandable)
3306         (dict_create_linear, dict_create_linear_expandable)
3307         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3308         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3309         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3310         taking multidictionary argument.
3311         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3312         * block.h (struct block) <dict>: Change to multidictionary
3313         and rename `multidict'.
3314         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3315         symmisc.c: Update all dictionary references to multidictionary.
3316
3317 2019-01-10  Keith Seitz  <keiths@redhat.com>
3318
3319         PR gdb/23712
3320         PR symtab/23010
3321         * dictionary.c: Include unordered_map.
3322         (pending_to_vector): New function.
3323         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3324         Rewrite the non-"_1" functions to take vector instead
3325         of linked list.
3326         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3327         "new" _1 versions of the same name.
3328         (multidictionary): Define.
3329         (std::hash<enum language): New definition.
3330         (collate_pending_symbols_by_language, mdict_create_hashed)
3331         (mdict_create_hashed_expandable, mdict_create_linear)
3332         (mdict_create_linear_expandable, mdict_free)
3333         (find_language_dictionary, create_new_language_dictionary)
3334         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3335         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3336         (mdict_size, mdict_empty): New functions.
3337         * dictionary.h (mdict_iterator): Define.
3338
3339 2019-01-10  Pedro Alves  <palves@redhat.com>
3340
3341         * breakpoint.c (read_uploaded_action)
3342         (create_tracepoint_from_upload): Adjust to use
3343         gdb::unique_xmalloc_ptr.
3344         * ctf.c (ctf_write_uploaded_tp):
3345         (SET_ARRAY_FIELD): Use emplace_back.
3346         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3347         * tracefile-tfile.c (tfile_write_uploaded_tp):
3348         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3349         gdb::unique_xmalloc_ptr.
3350         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3351         at_string, cond_string, cmd_strings>: Replace char pointers
3352         with gdb::unique_xmalloc_ptr.
3353
3354 2019-01-10  Pedro Alves  <palves@redhat.com>
3355
3356         * solib-target.c (library_list_start_library): Don't xstrdup name.
3357
3358 2019-01-10  Pedro Alves  <palves@redhat.com>
3359
3360         * mdebugread.c (parse_partial_symbols): Use
3361         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3362
3363 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * linux-fork.c (scoped_switch_fork_info)
3366         <~scoped_switch_fork_info>: Fix incorrect variable name.
3367
3368 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * linux-fork.c (scoped_switch_fork_info)
3371         <scoped_switch_fork_info>: Make explicit.
3372         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3373
3374 2019-01-10  Tom Tromey  <tom@tromey.com>
3375
3376         * objfiles.h (objfile::reset_psymtabs): Update.
3377         * objfiles.c (objfile::objfile): Update.
3378         * psymtab.h (psymtab_storage::obstack): Update.
3379         (psymtab_storage::m_obstack): Use gdb::optional.
3380         (class psymtab_storage): Update comment.  Remove objfile
3381         parameter.
3382         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3383
3384 2019-01-10  Tom Tromey  <tom@tromey.com>
3385
3386         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3387         <free_psymtabs>: Now private.
3388         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3389         (allocate_psymtab): Use new method.
3390
3391 2019-01-10  Tom Tromey  <tom@tromey.com>
3392
3393         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3394         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3395         * mdebugread.c (parse_partial_symbols): Use
3396         allocate_dependencies.
3397         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3398         allocate_dependencies.
3399         (process_psymtab_comp_unit_reader)
3400         (build_type_psymtab_dependencies): Likewise.
3401         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3402
3403 2019-01-10  Tom Tromey  <tom@tromey.com>
3404
3405         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3406         PSYMBOL_SET_LANGUAGE.
3407         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3408
3409 2019-01-10  Tom Tromey  <tom@tromey.com>
3410
3411         * psymtab.h (psymtab_storage::obstack): New method.
3412         <m_obstack>: Rename from obstack; now private.
3413         * psymtab.c (psymtab_storage): Update.
3414         * dwarf2read.c (create_addrmap_from_index)
3415         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3416         Update.
3417
3418 2019-01-10  Tom Tromey  <tom@tromey.com>
3419
3420         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3421         * objfiles.h (objfile::reset_psymtabs): New method.
3422
3423 2019-01-10  Tom Tromey  <tom@tromey.com>
3424
3425         * symmisc.c (print_symbol_bcache_statistics): Update.
3426         (print_objfile_statistics): Update.
3427         * symfile.c (reread_symbols): Update.
3428         * psymtab.h (class psymtab_storage): New.
3429         * psymtab.c (psymtab_storage): New constructor.
3430         (~psymtab_storage): New destructor.
3431         (require_partial_symbols): Update.
3432         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3433         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3434         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3435         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3436         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3437         (start_psymtab_common, end_psymtab_common)
3438         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3439         (allocate_psymtab): Update.
3440         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3441         Update.
3442         (dump_psymtab_addrmap, maintenance_print_psymbols)
3443         (maintenance_check_psymtabs): Update.
3444         (class objfile_psymtabs): Move to objfiles.h.
3445         * psympriv.h (discard_psymtab): Now inline.
3446         (psymtab_discarder::psymtab_discarder): Update.
3447         (psymtab_discarder::~psymtab_discarder): Update.
3448         (ALL_OBJFILE_PSYMTABS): Rewrite.
3449         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3450         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3451         Remove fields.
3452         <partial_symtabs>: New field.
3453         (class objfile_psymtabs): Move from psymtab.h.  Update.
3454         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3455         psymbol_cache.
3456         (objfile::~objfile): Don't destroy psymbol_cache.
3457         * mdebugread.c (parse_partial_symbols): Update.
3458         * dwarf2read.c (create_addrmap_from_index)
3459         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3460         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3461         (add_partial_subprogram, dwarf2_ranges_read): Update.
3462         * dwarf-index-write.c (write_address_map)
3463         (write_one_signatured_type, recursively_write_psymbols)
3464         (class debug_names, class debug_names, write_psymtabs_to_index):
3465         Update.
3466
3467 2019-01-10  Tom Tromey  <tom@tromey.com>
3468
3469         * symtab.h (SYMBOL_SET_NAMES): Update.
3470         (symbol_set_names): Update.
3471         (MSYMBOL_SET_NAMES): Update.
3472         * symtab.c (symbol_set_names): Change argument to be an
3473         objfile_per_bfd_storage.
3474         * psymtab.c (add_psymbol_to_bcache): Update.
3475         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3476
3477 2019-01-10  Tom Tromey  <tom@tromey.com>
3478
3479         * symtab.c (create_demangled_names_hash): Change argument to be an
3480         objfile_per_bfd_storage.
3481         (symbol_set_names): Update.
3482
3483 2019-01-10  Tom Tromey  <tom@tromey.com>
3484
3485         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3486         init_psymbol_list.
3487         * psymtab.c (init_psymbol_list): Do nothing if already called.
3488         * psympriv.h (init_psymbol_list): Add comment.
3489         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3490         init_psymbol_list.
3491         * dbxread.c (dbx_symfile_read): Unconditionally call
3492         init_psymbol_list.
3493
3494 2019-01-10  Tom Tromey  <tom@tromey.com>
3495
3496         * xcoffread.c (scan_xcoff_symtab): Update.
3497         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3498         "where".
3499         * mdebugread.c (parse_partial_symbols)
3500         (handle_psymbol_enumerators): Update.
3501         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3502         * dbxread.c (read_dbx_symtab): Update.
3503         * psympriv.h (psymbol_placement): New enum.
3504         (add_psymbol_to_list): Update.
3505
3506 2019-01-10  Tom Tromey  <tom@tromey.com>
3507
3508         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3509         static_psymbols parameters.
3510         (scan_xcoff_symtab): Update.
3511         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3512         static_psymbols parameters.
3513         * psympriv.h (start_psymtab_common): Update.
3514         * mdebugread.c (parse_partial_symbols): Update.
3515         * dwarf2read.c (create_partial_symtab): Update.
3516         * dbxread.c (read_dbx_symtab): Update.
3517         (start_psymtab): Remove global_psymbols and static_psymbols
3518         parameters.
3519
3520 2019-01-10  Tom Tromey  <tom@tromey.com>
3521
3522         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3523         * psymtab.c (allocate_psymtab): Add comment.
3524         * psympriv.h (allocate_psymtab): Add comment.
3525         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3526         initializations.
3527         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3528
3529 2019-01-10  Tom Tromey  <tom@tromey.com>
3530
3531         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3532         Don't declare.
3533         * mipsread.c: Include mdebugread.h.
3534         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3535         Declare.
3536         * elfread.c: Include mdebugread.h.
3537
3538 2019-01-09  Tom Tromey  <tom@tromey.com>
3539
3540         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3541         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3542         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3543         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3544         (psym_lookup_symbol, psym_find_last_source_symtab)
3545         (psym_forget_cached_source_info, psym_print_stats)
3546         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3547         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3548         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3549         (psym_find_compunit_symtab_by_address)
3550         (maintenance_print_psymbols, maintenance_info_psymtabs)
3551         (maintenance_check_psymtabs): Use ranged for.
3552         * psymtab.h (class objfile_psymtabs): New.
3553         (require_partial_symbols): Return objfile_psymtabs.
3554         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3555
3556 2019-01-09  Tom Tromey  <tom@tromey.com>
3557
3558         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3559         (find_pc_mapped_section, list_overlays_command)
3560         (map_overlay_command, unmap_overlay_command)
3561         (simple_overlay_update): Use all_objfiles.
3562         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3563         * printcmd.c (info_symbol_command): Use all_objfiles.
3564         * objfiles.h (ALL_OBJSECTIONS): Remove.
3565         * maint.c (maintenance_translate_address): Use all_objfiles.
3566         * gcore.c (gcore_create_callback): Use all_objfiles.
3567         (objfile_find_memory_regions): Likewise.
3568
3569 2019-01-09  Tom Tromey  <tom@tromey.com>
3570
3571         * symtab.c (find_line_symtab, info_sources_command)
3572         (make_source_files_completion_list): Use objfile_compunits.
3573         * source.c (select_source_symtab): Use objfile_compunits.
3574         * objfiles.h (struct objfile): Update comment.
3575         (ALL_OBJFILES): Remove.
3576         (ALL_FILETABS): Remove.
3577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3578         objfile_compunits.
3579
3580 2019-01-09  Tom Tromey  <tom@tromey.com>
3581
3582         * symmisc.c (print_objfile_statistics, dump_objfile)
3583         (maintenance_print_symbols): Use compunit_filetabs.
3584         * source.c (forget_cached_source_info_for_objfile): Use
3585         compunit_filetabs.
3586         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3587         (ALL_FILETABS): Use compunit_filetabs.
3588         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3589         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3590
3591 2019-01-09  Tom Tromey  <tom@tromey.com>
3592
3593         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3594         (compunit_filetabs): New.
3595         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3596         compunit_filetabs.
3597         (info_sources_command, make_source_files_completion_list): Remove
3598         declaration.
3599         * symmisc.c (print_objfile_statistics, dump_objfile)
3600         (maintenance_print_symbols): Remove declaration.
3601         (maintenance_info_symtabs): Use compunit_filetabs.
3602         (maintenance_info_line_tables): Likewise.
3603         * source.c (select_source_symtab): Change local variable name.
3604         (forget_cached_source_info_for_objfile): Remove declaration.
3605         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3606         * objfiles.c (objfile_relocate1): Remove declaration.
3607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3608         declaration.
3609         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3610         * coffread.c (coff_symtab_read): Remove declaration.
3611         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3612         compunit_filetabs.
3613
3614 2019-01-09  Tom Tromey  <tom@tromey.com>
3615
3616         * symtab.c (lookup_objfile_from_block)
3617         (find_pc_sect_compunit_symtab, search_symbols)
3618         (default_collect_symbol_completion_matches_break_on): Use
3619         objfile_compunits.
3620         * objfiles.h (ALL_COMPUNITS): Remove.
3621         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3622         * cp-support.c (add_symbol_overload_list_qualified): Use
3623         objfile_compunits.
3624         * ada-lang.c (ada_collect_symbol_completion_matches)
3625         (ada_add_global_exceptions): Use objfile_compunits.
3626
3627 2019-01-09  Tom Tromey  <tom@tromey.com>
3628
3629         * source.c (select_source_symtab)
3630         (forget_cached_source_info_for_objfile): Remove declaration.
3631         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3632         declaration.
3633         * maint.c (count_symtabs_and_blocks): Remove declaration.
3634         * cp-support.c (add_symbol_overload_list_qualified): Remove
3635         declaration.
3636         * coffread.c (coff_symtab_read): Remove declaration.
3637         * symtab.c (lookup_symbol_in_objfile_symtabs)
3638         (basic_lookup_transparent_type_1): Use objfile_compunits.
3639         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3640         (info_sources_command, search_symbols)
3641         (default_collect_symbol_completion_matches_break_on)
3642         (make_source_files_completion_list): Remove declaration.
3643         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3644         (ada_collect_symbol_completion_matches)
3645         (ada_add_global_exceptions): Remove declaration.
3646         * linespec.c (iterate_over_all_matching_symtabs): Use
3647         objfile_compunits.
3648         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3649         (class objfile_compunits): New.
3650         (ALL_COMPUNITS): Use objfile_compunits.
3651         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3652         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3653         objfile_compunits.
3654         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3655
3656 2019-01-09  Tom Tromey  <tom@tromey.com>
3657
3658         * symtab.c (search_symbols)
3659         (default_collect_symbol_completion_matches_break_on): Use
3660         objfile_msymbols.
3661         * ada-lang.c (ada_lookup_simple_minsym)
3662         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3663         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3664         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3665         objfile_msymbols.
3666         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3667         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3668         * objc-lang.c (find_methods): Use objfile_msymbols.
3669         (info_selectors_command, info_classes_command): Likewise.
3670         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3671         * objfiles.h (class objfile_msymbols): New.
3672         (ALL_OBJFILE_MSYMBOLS): Remove.
3673         (ALL_MSYMBOLS): Remove.
3674
3675 2019-01-09  Tom Tromey  <tom@tromey.com>
3676
3677         * common/next-iterator.h (next_adapter): Add Iterator template
3678         parameter.
3679         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3680         (class all_objfiles_safe): New.
3681         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3682         * objfiles.c (put_objfile_before): Update comment.
3683         (add_separate_debug_objfile): Likewise.
3684         (free_all_objfiles): Use all_objfiles_safe.
3685         (objfile_purge_solibs): Likewise.
3686
3687 2019-01-09  Tom Tromey  <tom@tromey.com>
3688
3689         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3690         (expand_symtab_containing_pc, lookup_static_symbol)
3691         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3692         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3693         all_objfiles.
3694         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3695         * breakpoint.c (create_overlay_event_breakpoint)
3696         (create_longjmp_master_breakpoint)
3697         (create_std_terminate_master_breakpoint)
3698         (create_exception_master_breakpoint): Use all_objfiles.
3699         * linux-thread-db.c (try_thread_db_load_from_pdir)
3700         (has_libpthread): Use all_objfiles.
3701         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3702         * linespec.c (iterate_over_all_matching_symtabs)
3703         (search_minsyms_for_name): Use all_objfiles.
3704         * maint.c (maintenance_info_sections): Use all_objfiles.
3705         * main.c (captured_main_1): Use all_objfiles.
3706         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3707         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3708         * guile/scm-pretty-print.c
3709         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3710         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3711         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3712         (maintenance_print_msymbols): Use all_objfiles.
3713         * source.c (select_source_symtab): Use all_objfiles.
3714         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3715         * symfile.c (remove_symbol_file_command)
3716         (expand_symtabs_matching, map_symbol_filenames): Use
3717         all_objfiles.
3718         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3719         all_objfiles.
3720         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3721         * objc-lang.c (find_methods): Use all_objfiles.
3722         * objfiles.c (have_partial_symbols, have_full_symbols)
3723         (have_minimal_symbols, qsort_cmp)
3724         (default_iterate_over_objfiles_in_search_order): Use
3725         all_objfiles.
3726         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3727         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3728         (maintenance_check_psymtabs): Use all_objfiles.
3729         (ALL_PSYMTABS): Remove.
3730         * compile/compile-object-run.c (do_module_cleanup): Use
3731         all_objfiles.
3732         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3733         * cp-support.c (add_symbol_overload_list_qualified): Use
3734         all_objfiles.
3735         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3736         Use all_objfiles.
3737         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3738         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3739         all_objfiles.
3740         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3741         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3742         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3743         Uses all_objfiles.
3744         * solib.c (solib_read_symbols): Use all_objfiles
3745
3746 2019-01-09  Tom Tromey  <tom@tromey.com>
3747
3748         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3749         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3750         all_objfiles.
3751         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3752         * symmisc.c (print_symbol_bcache_statistics)
3753         (print_objfile_statistics, maintenance_print_objfiles)
3754         (maintenance_info_symtabs, maintenance_check_symtabs)
3755         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3756         all_objfiles.
3757         * source.c (forget_cached_source_info): Use all_objfiles.
3758         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3759         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3760         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3761         * objfiles.c (update_section_map): Use all_objfiles.
3762         (shared_objfile_contains_address_p): Likewise.
3763         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3764         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3765
3766 2019-01-09  Tom Tromey  <tom@tromey.com>
3767
3768         * common/next-iterator.h: New file.
3769         * objfiles.h (class all_objfiles): New.
3770         (struct objfile_iterator): New.
3771
3772 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3773
3774         * NEWS: Move the description of the changed "frame", "select-frame",
3775          and "info frame" commands to the Changed commands section.
3776
3777 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3778
3779         * gdbtypes.c (check_stub_method_group): Remove handling of old
3780         mangling schemes.
3781         * linespec.c (find_methods): Likewise.
3782         * stabsread.c (read_member_functions): Likewise.
3783         * valops.c (search_struct_method): Likewise.
3784         (value_struct_elt_for_reference): Likewise.
3785         * NEWS: Mention this change.
3786
3787 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3790         print_source_lines.
3791         * source.c (print_source_lines_base): Update line number check.
3792         (print_source_lines): New function.
3793         (source_lines_range::source_lines_range): New function.
3794         * source.h (class source_lines_range): New class.
3795         (print_source_lines): New declaration.
3796
3797 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3798
3799         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3800
3801 2019-01-08  Tom Tromey  <tom@tromey.com>
3802             Simon Marchi  <simon.marchi@ericsson.com>
3803
3804         PR gdb/24060
3805         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3806         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3807         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3808         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3809         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3810         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3811
3812 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * source.c (select_source_symtab): Move header comment to
3815         declaration in source.h.
3816         (forget_cached_source_info_for_objfile): Likewise.
3817         (forget_cached_source_info): Likewise.
3818         (identify_source_line): Likewise.
3819         * source.h (identify_source_line): Move declaration from symtab.h
3820         and add comment from source.c
3821         (print_source_lines): Likewise.
3822         (forget_cached_source_info_for_objfile): Likewise.
3823         (forget_cached_source_info): Likewise.
3824         (select_source_symtab): Likewise.
3825         (enum print_source_lines_flag): Move definition from symtab.h.
3826         * symtab.h (identify_source_line): Move declaration to source.h.
3827         (print_source_lines): Likewise.
3828         (forget_cached_source_info_for_objfile): Likewise.
3829         (forget_cached_source_info): Likewise.
3830         (select_source_symtab): Likewise.
3831         (enum print_source_lines_flag): Move definition to source.h.
3832         * tui/tui-hooks.c: Add 'source.h' include.
3833
3834 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * source.c (print_source_lines_base): Handle requests to print
3837         reverse line number sequences, and guard against empty lines
3838         string.
3839
3840 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3841
3842         * source.c (print_source_lines_base): Fix skip of '\r' if next
3843         character is '\n'.
3844
3845 2019-01-06  Tom Tromey  <tom@tromey.com>
3846
3847         * c-exp.y (struct c_parse_state) <macro_original_text,
3848         expansion_obstack>: New member.
3849         (macro_original_text, expansion_obstack): Remove globals.
3850         (scan_macro_expansion, scanning_macro_expansion)
3851         (finished_macro_expansion): Update.
3852         (scan_macro_cleanup): Remove.
3853         (yylex, c_parse): Update.
3854
3855 2019-01-06  Tom Tromey  <tom@tromey.com>
3856
3857         * c-exp.y (struct c_parse_state) <strings>: New member.
3858         (operator_stoken): Update.
3859
3860 2019-01-06  Tom Tromey  <tom@tromey.com>
3861
3862         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3863         (union type_stack_elt) <typelist_val>: Now a pointer to
3864         std::vector.
3865         (type_stack_cleanup): Don't declare.
3866         (push_typelist): Update.
3867         * parse.c (pop_typelist): Return a std::vector.
3868         (push_typelist): Take a std::vector.
3869         (follow_types): Update.  Do not free args.
3870         (type_stack_cleanup): Remove.
3871         * c-exp.y (struct c_parse_state): New.
3872         (cpstate): New global.
3873         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3874         (nonempty_typelist): Update.
3875         (func_mod): Create a new vector.
3876         (c_parse): Create a c_parse_state.
3877         (check_parameter_typelist): Do not delete params.
3878         (function_method): Update.  Do not delete type_list.
3879
3880 2019-01-06  Tom Tromey  <tom@tromey.com>
3881
3882         PR gdb/28155:
3883         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3884         check_typedef.
3885         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3886         (print_return_value): Likewise.
3887
3888 2019-01-05  Tom Tromey  <tom@tromey.com>
3889
3890         * contrib/cleanup_check.py: Remove.
3891         * contrib/gcc-with-excheck: Remove.
3892         * contrib/exsummary.py: Remove.
3893         * contrib/excheck.py: Remove.
3894
3895 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3896
3897         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3898         NULL. Initialize tpprev to NULL instead of assigning it
3899         to NULL on the next statement.
3900         * windows-nat.c (windows_delete_thread): Remove check for
3901         main_thread_id before printing thread exit notifications.
3902         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3903         Remove thread ID check against main_thread_id.
3904         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3905         windows_delete_thread.
3906         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3907
3908 2019-01-04  Tom Tromey  <tom@tromey.com>
3909
3910         * compile/compile.c (_initialize_compile): Use upper case for
3911         metasyntactic variables.
3912         * symmisc.c (_initialize_symmisc): Use upper case for
3913         metasyntactic variables.
3914         * psymtab.c (_initialize_psymtab): Use upper case for
3915         metasyntactic variables.
3916         * demangle.c (demangle_command): Use upper case for metasyntactic
3917         variables.
3918         (_initialize_demangler): Likewise.
3919         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3920         variables.
3921
3922 2019-01-03  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3925
3926 2019-01-03  Tom Tromey  <tom@tromey.com>
3927
3928         * python/py-symtab.c (salpy_str): Update.
3929         (struct salpy_sal_object) <symtab>: Now a PyObject.
3930         (salpy_dealloc): Update.
3931         (del_objfile_sal): Use gdbpy_ref.
3932
3933 2019-01-03  Tom Tromey  <tom@tromey.com>
3934
3935         * python/py-type.c (convert_field): Use new_reference.  Return
3936         gdbpy_ref.
3937         (make_fielditem): Return gdbpy_ref.
3938         (typy_fields): Update.
3939         (typy_getitem): Update.
3940         (field_name): Return gdbpy_ref.  Use new_reference.
3941         (typy_iterator_iternext): Update.
3942
3943 2019-01-03  Tom Tromey  <tom@tromey.com>
3944
3945         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3946
3947 2019-01-03  Tom Tromey  <tom@tromey.com>
3948
3949         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3950         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3951         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3952         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3953         (pspy_set_type_printers): Likewise.
3954         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3955         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3956         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3957         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3958         (objfpy_set_type_printers): Likewise.
3959
3960 2019-01-03  Tom Tromey  <tom@tromey.com>
3961
3962         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3963         (gdbpy_print_stack): Use gdbpy_err_fetch.
3964         * python/python-internal.h (class gdbpy_err_fetch): New class.
3965         (class gdbpy_enter) <m_error_type, m_error_value,
3966         m_error_traceback>: Remove.
3967         <m_error>: New member.
3968         (gdbpy_exception_to_string): Don't declare.
3969         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3970         * python/py-value.c (convert_value_from_python): Use
3971         gdbpy_err_fetch.
3972         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3973         gdbpy_exception_to_string.
3974         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3975         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3976         gdbpy_err_fetch.
3977
3978 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * linux-nat.c (delete_lwp_cleanup): Delete.
3981         (struct lwp_deleter): New struct.
3982         (lwp_info_up): New typedef.
3983         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3984         lwp_info_up.
3985
3986 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3987
3988         * linux-fork.c (class scoped_switch_fork_info): New class.
3989         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3990
3991 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * valops.c (find_overload_match): Remove use of null_cleanup, and
3994         calls to do_cleanups.
3995
3996 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * compile/compile-cplus-types.c
3999         (compile_cplus_instance::decl_name): Handle changes to
4000         cp_func_name.
4001         * cp-support.c (cp_func_name): Update header comment, update
4002         return type.
4003         * cp-support.h (cp_func_name): Update return type in declaration.
4004         * valops.c (find_overload_match): Move temp_func local to top
4005         level of function and change its type.  Use temp_func to hold and
4006         delete temporary string obtained from cp_func_name.
4007
4008 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4011         gdb::char_vector, remove cleanup, and update uses of `msg`.
4012
4013 2019-01-03  Jim Wilson  <jimw@sifive.com>
4014
4015         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4016
4017 2019-01-02  Tom Tromey  <tom@tromey.com>
4018
4019         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4020         (tdesc_parse_xml): Remove cleanups.
4021         * target-descriptions.h (make_cleanup_free_target_description):
4022         Don't declare.
4023         (target_desc_deleter): New struct.
4024         (target_desc_up): New typedef.
4025         * target-descriptions.c (target_desc_deleter::operator()): Rename
4026         from free_target_description.
4027         (make_cleanup_free_target_description): Remove.
4028
4029 2019-01-02  Tom Tromey  <tom@tromey.com>
4030
4031         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4032         constructor, destructor.
4033         (linespec_parser): Remove typedef.
4034         (~linespec_parser): Rename from linespec_parser_delete.
4035         (linespec_lex_to_end, linespec_complete_label)
4036         (linespec_complete): Update.
4037         (decode_line_full): Remove cleanups.
4038         (decode_line_1): Update.
4039
4040 2019-01-02  Tom Tromey  <tom@tromey.com>
4041
4042         * python/python-internal.h (inferior_to_inferior_object): Change
4043         return type.
4044         * python/py-exitedevent.c (create_exited_event_object): Update.
4045         * python/py-inferior.c (inferior_to_inferior_object): Return
4046         gdbpy_ref.
4047         (python_new_inferior, python_inferior_deleted)
4048         (thread_to_thread_object, delete_thread_object)
4049         (build_inferior_list, gdbpy_selected_inferior): Update.
4050         * python/py-infthread.c (create_thread_object): Update.  Also fail
4051         if inferior_to_inferior_object fails.
4052
4053 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4054
4055         * inferior.h (class inferior) <displaced_step_state>: New field.
4056         * infrun.h (struct displaced_step_state): Move here from
4057         infrun.c.  Initialize fields, add constructor.
4058         <inf>: Remove field.
4059         <reset>: New method.
4060         * infrun.c (struct displaced_step_inferior_state): Move to
4061         infrun.h.
4062         (displaced_step_inferior_states): Remove.
4063         (get_displaced_stepping_state): Adust.
4064         (displaced_step_in_progress_any_inferior): Adjust.
4065         (displaced_step_in_progress_thread): Adjust.
4066         (displaced_step_in_progress): Adjust.
4067         (add_displaced_stepping_state): Remove.
4068         (get_displaced_step_closure_by_addr): Adjust.
4069         (remove_displaced_stepping_state): Remove.
4070         (infrun_inferior_exit): Call displaced_step_state.reset.
4071         (use_displaced_stepping): Don't check for NULL.
4072         (displaced_step_prepare_throw): Call
4073         get_displaced_stepping_state.
4074         (displaced_step_fixup): Don't check for NULL.
4075         (prepare_for_detach): Don't check for NULL.
4076
4077 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4080          in case of call that did not complete.
4081
4082 2019-01-02  Andrey Utkin  <autkin@undo.io>
4083
4084         * symfile.c (find_separate_debug_file): Fix search of debug files for
4085         remote debuggee.
4086
4087 2019-01-02  Tom Tromey  <tom@tromey.com>
4088
4089         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4090         indentation.
4091         * python/py-frame.c (frapy_older): Remove cast.
4092         (frapy_newer): Likewise.
4093         * python/py-breakpoint.c (local_setattro): Remove cast.
4094         * python/py-arch.c (archpy_name): Remove local variable.
4095         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4096
4097 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4098
4099         * unittests/basic_string_view/element_access/char/empty.cc:
4100         Fix year range in copyright header.
4101
4102 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4105         Delete.
4106         <operator==>: Update with for removed field.
4107         <hash>: Likewise.
4108         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4109         <isa_features>: ...this.
4110         <abi_features>: New field.
4111         (riscv_isa_flen): Update comment.
4112         (riscv_abi_xlen): New declaration.
4113         (riscv_abi_flen): New declaration.
4114         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4115         isa_features.
4116         (riscv_abi_xlen): New function.
4117         (riscv_isa_flen): Update to get answer from isa_features.
4118         (riscv_abi_flen): New function.
4119         (riscv_has_fp_abi): Update to get answer from abi_features.
4120         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4121         xlen and flen.
4122         (riscv_call_info) <xlen, flen>: Update comment.
4123         (riscv_call_arg_struct): Remove invalid assertions
4124         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4125         is removed.
4126         (riscv_gdbarch_init): Gather isa features and abi features
4127         separately, ensure both match on the gdbarch when reusing an old
4128         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4129         a target with 64-bit float hardware.
4130
4131 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4132
4133         * source.c (search_command_helper): Stop reverse search
4134         when line 1 has been searched.
4135
4136 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4137
4138         * record-full.c (record_full_base_target::close): Rewrite
4139         record_full_core_buf_list free logic.
4140
4141 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4142
4143         * break-catch-syscall.c (print_one_catch_syscall): xfree
4144         the last text.
4145
4146 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4147
4148         * top.c (print_gdb_version): Update Copyright year in version
4149         message.
4150
4151 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4152
4153         Update copyright year range in all GDB files.
4154
4155 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4156
4157         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4158
4159 For older changes see ChangeLog-2018.
4160 \f
4161 Local Variables:
4162 mode: change-log
4163 left-margin: 8
4164 fill-column: 74
4165 version-control: never
4166 coding: utf-8
4167 End:
4168