gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window): Use
   4         DISABLE_COPY_AND_ASSIGN.
   5         <regs_content>: Change type, removing unique_ptr.
   6         <tui_data_window>: Add move constructor.
   7         * tui/tui-regs.c (tui_data_window::show_registers)
   8         (tui_data_window::show_register_group)
   9         (tui_data_window::display_registers_from)
  10         (tui_data_window::display_registers_from)
  11         (tui_data_window::first_data_item_displayed)
  12         (tui_data_window::delete_data_content_windows)
  13         (tui_data_window::rerender, tui_data_window::refresh_window)
  14         (tui_data_window::check_register_values): Update.
  15
  16 2019-08-20  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  19         show_register_group>: Declare.
  20         (tui_show_register_group): Don't declare.
  21         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  22         tui_show_registers.
  23         (tui_data_window::show_register_group): Rename from
  24         tui_show_register_group.
  25         (tui_data_window::check_register_values, tui_reg_command):
  26         Update.
  27         * tui/tui-layout.c (tui_set_layout): Update.
  28
  29 2019-08-20  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  32         Declare.
  33         (tui_check_register_values): Don't declare.
  34         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  35         from tui_check_register_values.
  36         * tui/tui-hooks.c (tui_register_changed): Update.
  37
  38 2019-08-20  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-regs.c (tui_reg_layout): Move later.
  41         (tui_show_registers): Don't enable TUI mode or change layout.
  42
  43 2019-08-20  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-regs.h (struct tui_data_item_window)
  46         <~tui_data_item_window>: Remove.
  47         <content>: Now a unique_xmalloc_ptr.
  48         * tui/tui-regs.c (tui_register_format): Return a
  49         unique_xmalloc_ptr.
  50         (tui_get_register): Update.
  51         (~tui_data_item_window): Remove.
  52         (tui_data_window::display_registers_from, tui_display_register):
  53         Update.
  54         * tui/tui-io.h (tui_expand_tabs): Update.
  55         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  56         Remove "col" parameter.
  57
  58 2019-08-20  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  61         field.
  62         * tui/tui-regs.c (~tui_data_item_window): Update.
  63
  64 2019-08-20  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  67         earlier.
  68
  69 2019-08-20  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
  72
  73 2019-08-20  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-source.h (struct tui_source_window): Update.
  76         * tui/tui-regs.c (tui_show_registers): Update.
  77         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  78         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  79         (NO_REGS_STRING): Remove defines.
  80
  81 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  82
  83         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  84         unnecessary thread walk if remote doesn't support the packet.
  85
  86 2019-08-19  Tom Tromey  <tromey@adacore.com>
  87
  88         * python/py-value.c (value_has_field): Fix indentation.
  89
  90 2019-08-19  Tom Tromey  <tromey@adacore.com>
  91
  92         * printcmd.c (do_one_display, info_display_command): Update.
  93         * block.h (contained_in): Return bool.  Add allow_nested
  94         parameter.
  95         * block.c (contained_in): Return bool.  Add allow_nested
  96         parameter.
  97
  98 2019-08-19  Tom Tromey  <tom@tromey.com>
  99
 100         * configure: Rebuild.
 101         * configure.ac: Disallow the combination of -static-libstdc++ and
 102         source highlight.
 103         * source-cache.c (get_language_name): Handle rust.
 104         (source_cache::get_source_lines): Ignore highlighting exceptions.
 105
 106 2019-08-16  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 109         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 110         (struct tui_source_window_base) <make_visible, refresh_window,
 111         resize>: Remove methods.
 112         <execution_info>: Remove field.
 113         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 114         (tui_show_source_line, tui_source_window_base)
 115         (~tui_source_window_base): Update.
 116         (tui_source_window_base::resize)
 117         (tui_source_window_base::make_visible)
 118         (tui_source_window_base::refresh_window): Remove.
 119         (tui_source_window_base::update_exec_info): Update.
 120         * tui/tui-source.c (tui_source_window::set_contents): Update.
 121         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 122
 123 2019-08-16  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 126         deprecated_query_hook.
 127
 128 2019-08-16  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 131         (tui_update_source_windows_with_line): Update.
 132         * tui/tui-source.h (struct tui_source_window)
 133         <show_symtab_source>: Declare.
 134         (tui_show_symtab_source): Don't declare.
 135         * tui/tui-source.c (tui_show_symtab_source): Rename from
 136         tui_show_symtab_source.
 137
 138 2019-08-16  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.h (struct tui_source_window_base)
 141         <set_contents>: Declare.
 142         * tui/tui-winsource.c
 143         (tui_source_window_base::update_source_window_as_is): Update.
 144         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 145         Declare.
 146         (tui_set_source_content): Don't declare.
 147         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 148         tui_set_source_content.
 149         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 150         Declare.
 151         (tui_set_disassem_content): Don't declare.
 152         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 153         tui_set_disassem_content.
 154
 155 2019-08-16  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-winsource.h (struct tui_source_window_base)
 158         <update_breakpoint_info>: Declare.
 159         (tui_update_breakpoint_info): Don't declare.
 160         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 161         (tui_update_all_breakpoint_info): Update.
 162         (tui_source_window_base::update_breakpoint_info): Rename from
 163         tui_update_breakpoint_info.
 164         (tui_source_window_base::update_exec_info): Update.
 165
 166 2019-08-16  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-winsource.h (struct tui_source_window_base)
 169         <update_source_window>: Declare.
 170         (tui_update_source_window): Don't declare.
 171         * tui/tui-winsource.c
 172         (tui_source_window_base::update_source_window): Rename from
 173         tui_update_source_window.
 174         (tui_source_window_base::rerender): Update.
 175         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 176         * tui/tui-disasm.c (tui_show_disassem)
 177         (tui_show_disassem_and_update_source)
 178         (tui_disasm_window::maybe_update): Update.
 179
 180 2019-08-16  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-winsource.h (struct tui_source_window_base)
 183         <update_source_window_as_is>: Declare.
 184         (tui_update_source_window_as_is): Don't declare.
 185         * tui/tui-winsource.c (tui_update_source_window): Update
 186         (tui_source_window_base::update_source_window_as_is): Rename from
 187         tui_update_source_window_as_is.
 188         (tui_source_window_base::refill): Update.
 189         * tui/tui-source.c (tui_show_symtab_source): Update.
 190         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 191         Update.
 192
 193 2019-08-16  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-winsource.h (tui_update_source_window)
 196         (tui_update_source_window_as_is): Remove "noerror" parameter.
 197         * tui/tui-winsource.c (tui_update_source_window)
 198         (tui_update_source_window_as_is): Remove "noerror" parameter.
 199         (tui_update_source_windows_with_addr)
 200         (tui_update_source_windows_with_line)
 201         (tui_source_window_base::rerender)
 202         (tui_source_window_base::refill): Update.
 203         * tui/tui-source.h (tui_set_source_content)
 204         (tui_show_symtab_source): Remove "noerror" parameter.
 205         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 206         parameter.
 207         (tui_show_symtab_source): Likewise.
 208         (tui_source_window::maybe_update): Update.
 209         * tui/tui-disasm.c (tui_show_disassem)
 210         (tui_show_disassem_and_update_source)
 211         (tui_disasm_window::do_scroll_vertical)
 212         (tui_disasm_window::maybe_update): Update.
 213
 214 2019-08-16  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui.c (tui_is_window_visible): Update.
 217         * tui/tui-wingeneral.c (tui_make_window)
 218         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 219         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 220         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 221         (tui_set_win_height_command, parse_scrolling_args): Update.
 222         * tui/tui-source.c (tui_source_window::style_changed): Update.
 223         * tui/tui-regs.c (tui_show_registers)
 224         (tui_data_window::first_data_item_displayed)
 225         (tui_data_window::delete_data_content_windows)
 226         (tui_check_register_values, tui_reg_command): Update.
 227         * tui/tui-disasm.c (tui_show_disassem): Update.
 228         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 229         method.
 230         <is_visible>: Remove field.
 231         * tui/tui-data.c (tui_next_win, tui_prev_win)
 232         (tui_delete_invisible_windows): Update.
 233
 234 2019-08-16  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-winsource.h (struct tui_source_window_base)
 237         <m_has_locator>: Remove.
 238         * tui/tui-layout.c (show_source_disasm_command, show_data)
 239         (show_source_or_disasm_and_command): Update.
 240
 241 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 242
 243         * NEWS (Other MI changes): New subsection.
 244         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 245         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 246         * arch-utils.c (default_get_pc_address_flags): New function.
 247         * arch-utils.h (default_get_pc_address_flags): New declaration.
 248         * gdbarch.sh: Add get_pc_address_flags.
 249         * gdbarch.c: Regenerate.
 250         * gdbarch.h: Likewise.
 251         * stack.c (print_pc): New function.
 252         (print_frame_info) (print_frame): Call print_pc.
 253
 254 2019-08-16  Tom de Vries  <tdevries@suse.de>
 255
 256         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 257         print_objfile_section_info.
 258
 259 2019-08-15  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 262         calling update_cmdwin_start_line.
 263         * tui/tui-winsource.h (struct tui_source_window_base)
 264         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 265         <rerender>: Declare.
 266         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 267         Call rerender.
 268         (tui_source_window_base::set_new_height): Remove.
 269         (tui_source_window_base::rerender): Rename from
 270         do_make_visible_with_new_height.
 271         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 272         resize method.
 273         (tui_win_info::make_invisible_and_set_new_height)
 274         (tui_win_info::make_visible_with_new_height): Remove.
 275         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 276         Declare.
 277         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 278         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 279         do_make_visible_with_new_height>: Don't declare.
 280         <rerender>: Declare.
 281         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 282         set_new_height.
 283         (tui_data_window::do_make_visible_with_new_height): Remove.
 284         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 285         call tui_show_locator_content.
 286         (tui_gen_win_info::resize): Call rerender.
 287         (show_source_or_disasm_and_command): Don't call
 288         tui_show_locator_content.
 289         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 290         method.
 291         (struct tui_win_info) <rerender>: Declare.
 292         <set_new_height, make_invisible_and_set_new_height,
 293         make_visible_with_new_height>: Don't declare.
 294         * tui/tui-data.c (tui_win_list::rerender): New method.
 295         * tui/tui-command.h (struct tui_cmd_window)
 296         <do_make_visible_with_new_height>: Don't declare.
 297         * tui/tui-command.c
 298         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 299
 300 2019-08-15  Tom Tromey  <tromey@adacore.com>
 301
 302         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 303         * ada-lang.c (ada_enum_name): Likewise.
 304
 305 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 306
 307         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 308         leading underscore.
 309         (GdbOutputErrorFile): Likewise.
 310         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 311         accordingly.
 312         (execute_unwinders): Rename to have a leading underscore.
 313         (auto_load_packages): Likewise.
 314         (global scope): Adjust call to auto_load_packages accordingly.
 315         (GdbSetPythonDirectory): Likewise.
 316         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 317         instead of execute_unwinders.
 318
 319 2019-08-15  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 322         (show_data): Don't change window visibility.
 323         (tui_gen_win_info::resize): Remove special case for command
 324         window.  Use wresize, when available.
 325         (show_source_or_disasm_and_command): Don't change window
 326         visibility.
 327         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 328         <make_visible>: New method.
 329         * tui/tui-command.c (tui_cmd_window::resize): New method.
 330
 331 2019-08-15  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 334         (struct tui_source_windows): New.
 335         * tui/tui-winsource.c (tui_display_main): Update.
 336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 337         (new_height_ok, parse_scrolling_args): Update.
 338         * tui/tui-layout.c (show_layout, show_data): Update.
 339         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 340         (tui_add_to_source_windows): Don't declare.
 341         * tui/tui-data.c (source_windows, tui_source_windows)
 342         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 343
 344 2019-08-15  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 347         Rename from reset.
 348         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 349         * tui/tui-layout.c (show_source_disasm_command, show_data):
 350         Update.
 351         (tui_gen_win_info::resize): Rename.
 352         (show_source_or_disasm_and_command): Update.
 353         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 354         reset.
 355
 356 2019-08-15  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 359         * tui/tui-interp.c (tui_interp::init): Don't call
 360         tui_initialize_static_data.
 361         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 362
 363 2019-08-15  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 366         examine tui_win_list.
 367
 368 2019-08-15  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 371         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 372         tui_clear_source_content.
 373         (tui_clear_source_content): Remove.
 374         (tui_source_window_base::do_erase_source_content): Hoist call to
 375         content.clear().
 376         * tui/tui-stack.c (tui_show_frame_info): Don't call
 377         tui_clear_source_content.
 378
 379 2019-08-15  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-winsource.h (struct tui_source_window_base)
 382         <do_erase_source_content>: New method.
 383         <erase_source_content>: New method.
 384         (tui_erase_source_content): Don't declare.
 385         * tui/tui-winsource.c (tui_clear_source_content): Update.
 386         (tui_source_window_base::do_erase_source_content): Rename from
 387         tui_erase_source_content.
 388         (tui_source_window_base::show_source_content): Update.
 389         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 390         * tui/tui-source.h (struct tui_source_window)
 391         <erase_source_content>: New method.
 392         * tui/tui-disasm.h (struct tui_disasm_window)
 393         <erase_source_content>: New method.
 394
 395 2019-08-15  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 398         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 399         constructor.
 400         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 401         * tui/tui-source.c (tui_set_source_content): Update.
 402         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 403
 404 2019-08-15  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 407         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 408         tui-source.c.
 409         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 410         Declare.
 411         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 412         method.
 413         (tui_source_window::maybe_update): Update.
 414
 415 2019-08-15  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 418         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 419         tui-disasm.c.
 420         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 421         Declare.
 422         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 423         method.
 424         (tui_disasm_window::maybe_update): Update.
 425
 426 2019-08-15  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.h (struct tui_source_window_base)
 429         <maybe_update>: Declare.
 430         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 431         method.
 432         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 433         Declare.
 434         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 435         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 436         Declare.
 437         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 438
 439 2019-08-15  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 442
 443 2019-08-15  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-wingeneral.c: Include tui-stack.h.
 446         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 447         (struct tui_locator_window): Move from tui-data.h.
 448         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 449         (tui_initialize_static_data): Move from tui-data.c.
 450         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 451         (struct tui_locator_window): Move to tui-stack.c.
 452         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 453         (tui_initialize_static_data): Move to tui-stack.c.
 454
 455 2019-08-15  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-layout.c (show_source_disasm_command)
 458         (show_source_or_disasm_and_command): Use make_visible method, not
 459         tui_make_window.
 460         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 461         Remove.
 462
 463 2019-08-15  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-wingeneral.h (tui_make_window): Update.
 466         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 467         parameter.
 468         (tui_gen_win_info::make_visible): Update.
 469         * tui/tui-regs.c (tui_data_window::display_registers_from):
 470         Update.
 471         * tui/tui-layout.c (show_source_disasm_command)
 472         (show_source_or_disasm_and_command): Update.
 473         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 474         (enum tui_box): Remove.
 475         (struct tui_win_info) <can_box>: New method.
 476         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 477         method.
 478
 479 2019-08-15  Tom de Vries  <tdevries@suse.de>
 480
 481         * linux-nat-trad.c: Include gdbarch.h.
 482
 483 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 484
 485         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 486         register sizes.
 487
 488 2019-08-14  Tom Tromey  <tromey@adacore.com>
 489
 490         * darwin-nat.c: Include gdbarch.h.
 491         * darwin-nat-info.c: Include gdbarch.h.
 492
 493 2019-08-13  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 496         Remove.
 497         * tui/tui-data.c (tui_initialize_static_data): Update.
 498
 499 2019-08-13  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-winsource.h (struct tui_exec_info_window)
 502         <~tui_exec_info_window, maybe_allocate_content, get_content,
 503         m_content>: Remove.
 504         (struct tui_source_window_base) <set_exec_info_content,
 505         show_exec_info_content>: Don't declare.
 506         * tui/tui-winsource.c
 507         (tui_exec_info_window::maybe_allocate_content): Remove.
 508         (tui_source_window_base::update_exec_info): Rename from
 509         set_exec_info_content.
 510         (tui_source_window_base::show_exec_info_content)
 511         (tui_source_window_base::update_exec_info): Remove.
 512
 513 2019-08-13  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 516         declare.
 517         * tui/tui-winsource.c (tui_update_source_window_as_is)
 518         (tui_update_source_windows_with_addr, tui_erase_source_content):
 519         Update.
 520         (tui_clear_exec_info_content): Remove.
 521
 522 2019-08-13  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 525         declare.
 526         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 527         call tui_erase_exec_info_content.
 528         (tui_clear_exec_info_content): Rename from
 529         tui_erase_exec_info_content.
 530         (tui_clear_exec_info_content): Delete.
 531
 532 2019-08-13  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-winsource.h (struct tui_source_window_base)
 535         <show_exec_info_content>: Declare.
 536         (tui_show_exec_info_content): Don't declare.
 537         * tui/tui-winsource.c
 538         (tui_source_window_base::show_exec_info_content): Rename from
 539         tui_show_exec_info_content.
 540         (tui_source_window_base::update_exec_info): Update.
 541
 542 2019-08-13  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 545         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 546         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 547         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 548         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 549         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 550         ... here.
 551
 552 2019-08-13  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.h (struct tui_source_window_base)
 555         <update_exec_info>: Declare.
 556         (tui_update_exec_info): Don't declare.
 557         * tui/tui-winsource.c (tui_update_source_window_as_is)
 558         (tui_source_window_base::refresh_all)
 559         (tui_update_all_breakpoint_info): Update.
 560         (tui_source_window_base::update_exec_info): Rename from
 561         tui_update_exec_info.
 562         * tui/tui-stack.c (tui_show_frame_info): Update.
 563
 564 2019-08-13  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-winsource.h (struct tui_source_window_base)
 567         <set_exec_info_content>: Declare.
 568         (tui_set_exec_info_content): Don't declare.
 569         * tui/tui-winsource.c
 570         (tui_source_window_base::set_exec_info_content): Rename from
 571         tui_set_exec_info_content.
 572         (tui_update_exec_info): Update.
 573
 574 2019-08-13  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-winsource.h (struct tui_source_window_base)
 577         <show_source_content>: Declare.
 578         (tui_show_source_content): Don't declare.
 579         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 580         (tui_source_window_base::show_source_content): Rename from
 581         tui_show_source_content.
 582         (tui_source_window_base::refresh_all): Update.
 583         * tui/tui-layout.c (show_source_disasm_command)
 584         (show_source_or_disasm_and_command): Update.
 585
 586 2019-08-13  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-winsource.c (tui_erase_source_content)
 589         (tui_show_source_content, tui_source_window_base::refresh_all):
 590         Update.
 591         * tui/tui-wingeneral.h
 592         (tui_check_and_display_highlight_if_needed): Don't declare.
 593         * tui/tui-wingeneral.c
 594         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 595         check_and_display_highlight_if_needed.
 596         * tui/tui-win.c (tui_rehighlight_all)
 597         (tui_win_info::make_visible_with_new_height): Update.
 598         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 599         (tui_data_window::erase_data_content)
 600         (tui_data_window::display_all_data): Update.
 601         * tui/tui-data.h (struct tui_win_info)
 602         <check_and_display_highlight_if_needed>: Declare.
 603
 604 2019-08-13  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-win.c (tui_resize_all): Call
 607         tui_delete_invisible_windows.
 608         * tui/tui-layout.c (show_layout): Call
 609         tui_delete_invisible_windows.
 610         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 611         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 612
 613 2019-08-13  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 616         tui_add_win_to_layout.
 617
 618 2019-08-13  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 621         * tui/tui-layout.c (tui_default_win_height): Now static.
 622
 623 2019-08-13  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 626         single switch.
 627         (show_source_disasm_command, show_source_or_disasm_and_command):
 628         Don't check current layout.
 629
 630 2019-08-13  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-wingeneral.c (make_all_visible): Remove.
 633         (tui_make_all_invisible): Simplify.
 634         * tui/tui-layout.c (tui_make_all_invisible): Move from
 635         tui-wingeneral.c; simplify.
 636         (show_layout): Hoist call to tui_make_all_invisible.
 637         (show_data): Don't call tui_make_all_invisible.
 638
 639 2019-08-13  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 642         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 643
 644 2019-08-13  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 647         tui-data.c.
 648         (show_source_disasm_command, show_data)
 649         (show_source_or_disasm_and_command): Don't use
 650         tui_set_current_layout_to.
 651         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 652         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 653         tui-layout.c.
 654         (tui_set_current_layout_to): Remove.
 655
 656 2019-08-13  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-layout.c (tui_set_layout): Update.
 659         * tui/tui-data.h (struct tui_layout_def): Remove.
 660         (tui_layout_def): Don't declare.
 661         * tui/tui-data.c (layout_def): Remove.
 662         (tui_layout_def): Remove.
 663
 664 2019-08-13  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.h (struct tui_source_window_base)
 667         <clear_detail>: No longer "override".
 668         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 669         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 670         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 671         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 672         Remove.
 673         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 674
 675 2019-08-13  Tom Tromey  <tromey@adacore.com>
 676
 677         * tracepoint.c: Don't include readline.h or history.h.
 678
 679 2019-08-12  Tom Tromey  <tom@tromey.com>
 680
 681         * configure: Rebuild.
 682         * configure.ac: Check for readline 7.
 683         * NEWS: Mention readline 7 requirement.
 684         * README: Update.
 685
 686 2019-08-12  Tom Tromey  <tom@tromey.com>
 687
 688         * mingw-hdep.c (gdb_select): Remove readline hack.
 689
 690 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 691
 692         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 693         when the function fails.
 694
 695 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 696
 697         * s390-tdep.c (s390_type_align): New function.
 698         (s390_gdbarch_init): Set it as type_align gdbarch method.
 699
 700 2019-08-09  Tom de Vries  <tdevries@suse.de>
 701
 702         PR gdb/24591
 703         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 704         pc_low with relocation offset.
 705
 706 2019-08-07  Tom Tromey  <tromey@adacore.com>
 707
 708         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 709         (print_frame_args): Update.
 710         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 711         Update.
 712         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 713         * frame.h (struct frame_arg): Add initializers.
 714         <error>: Now a unique_xmalloc_ptr.
 715
 716 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 717
 718         * NEWS: Expand the Pointer Authentication entry.
 719         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 720         (aarch64_frame_unmask_lr): ... to this.
 721         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 722         Call aarch64_frame_unmask_lr.
 723         * frame.c (struct frame_info): Add "masked" variable.
 724         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 725         (fprint_frame): Check for masked pc.
 726         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 727         declarations.
 728         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 729         * stack.c (print_frame): Check for masked pc.
 730
 731 2019-08-06  Tom Tromey  <tom@tromey.com>
 732
 733         * stabsread.c (patch_block_stabs, read_one_struct_field)
 734         (read_enum_type): Use obstack_strndup.
 735         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 736         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 737         * dwarf2read.c (guess_full_die_structure_name)
 738         (anonymous_struct_prefix): Use obstack_strndup.
 739         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 740         * c-exp.y (yylex): Use obstack_strndup.
 741         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 742         (write_var_or_type): Use obstack_strndup.
 743
 744 2019-08-06  Tom Tromey  <tom@tromey.com>
 745
 746         * symfile.c (reread_symbols): Use obstack_strdup.
 747         * stabsread.c (read_type): Use obstack_strdup.
 748         * gdb_obstack.h (obstack_strdup): New overload.
 749         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 750         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 751         (dwarf2_canonicalize_name): Use obstack_strdup.
 752         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 753         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 754         Use obstack_strdup.
 755
 756 2019-08-06  Tom Tromey  <tom@tromey.com>
 757
 758         * gdb_obstack.h (obstack_strdup): Define.
 759         * gdb_obstack.c (obstack_strdup): Don't define.
 760
 761 2019-08-06  Tom Tromey  <tom@tromey.com>
 762
 763         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 764         obstack_strdup.
 765         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 766         obstack_strdup.
 767         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 768         * stabsread.c (common_block_start): Use obstack_strdup.
 769         * objfiles.c (set_objfile_main_name, objfile): Use
 770         obstack_strdup.
 771         * namespace.c (add_using_directive): Use obstack_strdup.
 772         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 773         * jit.c (finalize_symtab): Use obstack_strdup.
 774         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 775         (guess_partial_die_structure_name, partial_die_info::fixup)
 776         (dwarf2_name): Use obstack_strdup.
 777         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 778         obstack_strdup.
 779         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 780         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 781         obstack_strdup.
 782         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 783
 784 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 785
 786         * unittests/help-doc-selftests.c: New file.
 787         * Makefile.in: Add the new file.
 788
 789 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 790
 791         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 792         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 793         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 794         the trailing '.' is not output, and the first character is uppercased.
 795         (print_help_for_command): Update call to print_doc_line.
 796         (print_doc_of_command): Likewise.
 797         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 798         * cli/cli-option.c (append_indented_doc): Do not append newline.
 799         (build_help_option): Append newline after first appended_indented_doc
 800         only if a second call is done.
 801         (build_help): Append 2 new lines before each option, except the first
 802         one.
 803         * compile/compile.c (_initialize_compile): Add new lines after
 804         %OPTIONS%, when not at the end of the help.
 805         Change help doc or code
 806         producing the help doc to respect the invariants.
 807         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 808         Also removed the new line after 'Options:', as all other commands
 809         do not put an empty line between 'Options:' and the first option.
 810         * printcmd.c (_initialize_printcmd): Likewise.
 811         * stack.c (_initialize_stack): Likewise.
 812         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 813         incorrectly telling COMMAND is optional.
 814         * ada-lang.c (_initialize_ada_language): Change help doc or code
 815         producing the help doc to respect the invariants.
 816         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 817         * breakpoint.c (_initialize_breakpoint): Likewise.
 818         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 819         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 820         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 821         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 822         _initialize_cli_style): Likewise.
 823         * corelow.c (core_target_info): Likewise.
 824         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 825         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 826         * filesystem.c (_initialize_filesystem): Likewise.
 827         * frame.c (_initialize_frame): Likewise.
 828         * gnu-nat.c (add_task_commands): Likewise.
 829         * infcall.c (_initialize_infcall): Likewise.
 830         * infcmd.c (_initialize_infcmd): Likewise.
 831         * interps.c (_initialize_interpreter): Likewise.
 832         * language.c (_initialize_language): Likewise.
 833         * linux-fork.c (_initialize_linux_fork): Likewise.
 834         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 835         * maint.c (_initialize_maint_cmds): Likewise.
 836         * memattr.c (_initialize_mem): Likewise.
 837         * printcmd.c (_initialize_printcmd): Likewise.
 838         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 839         _RegEx): Likewise.
 840         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 841         * record-btrace.c (_initialize_record_btrace): Likewise.
 842         * record-full.c (_initialize_record_full): Likewise.
 843         * record.c (_initialize_record): Likewise.
 844         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 845         * regcache.c (_initialize_regcache): Likewise.
 846         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 847         _initialize_remote): Likewise.
 848         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 849         * serial.c (_initialize_serial): Likewise.
 850         * skip.c (_initialize_step_skip): Likewise.
 851         * source.c (_initialize_source): Likewise.
 852         * stack.c (_initialize_stack): Likewise.
 853         * symfile.c (_initialize_symfile): Likewise.
 854         * symtab.c (_initialize_symtab): Likewise.
 855         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 856         * top.c (init_main): Likewise.
 857         * tracefile-tfile.c (tfile_target_info): Likewise.
 858         * tracepoint.c (_initialize_tracepoint): Likewise.
 859         * tui/tui-win.c (_initialize_tui_win): Likewise.
 860         * utils.c (add_internal_problem_command): Likewise.
 861         * valprint.c (value_print_option_defs): Likewise.
 862
 863 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 864
 865         PR build/24886
 866         * configure.ac: Drop enable-libmcheck support.
 867         * configure, config.in: Rebuild.
 868         * libmcheck.m4: Remove.
 869         * acinclude.m4: Don't include it.
 870         * Makefile.in: Don't distribute it.
 871         * top.c (print_gdb_configuration): Don't mention it.
 872
 873 2019-08-06  Tom Tromey  <tom@tromey.com>
 874
 875         * utils.c (set_output_style): Sometimes pass stream to
 876         emit_style_escape.
 877         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 878         * record-btrace.c (btrace_insn_history): Update.
 879         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 880         method.
 881         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 882         Update initializers.
 883         <m_uiout>: New field.
 884         <m_di>: Move lower.
 885         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 886         Remove "uiout" parameter.
 887         (dump_insns): Update.
 888         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 889         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 890
 891 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 892
 893         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 894         (error_in_psymtab_expansion): Likewise.
 895         (lookup_symbol_via_quick_fns): Likewise.
 896         (basic_lookup_transparent_type_quick): Likewise.
 897         (basic_lookup_transparent_type_1): Likewise.
 898
 899 2019-08-06  Tom Tromey  <tromey@adacore.com>
 900
 901         * source.c (last_source_error): Now bool.
 902         (print_source_lines_base): Make "noprint" bool.  Only open
 903         source file when last_source_visited changes.
 904
 905 2019-08-06  Tom Tromey  <tromey@adacore.com>
 906
 907         * annotate.c (annotate_source_line): Use g_source_cache.
 908         * source-cache.c (source_cache::get_plain_source_lines): Change
 909         parameters.  Populate m_offset_cache.
 910         (source_cache::ensure): New method.
 911         (source_cache::get_line_charpos): New method.
 912         (extract_lines): Move lower.  Change parameters.
 913         (source_cache::get_source_lines): Move lower.
 914         * source-cache.h (class source_cache): Update comment.
 915         <get_line_charpos>: New method.
 916         <get_source_lines>: Update comment.
 917         <clear>: Clear m_offset_cache.
 918         <get_plain_source_lines>: Change parameters.
 919         <ensure>: New method
 920         <m_offset_cache>: New member.
 921         * source.c (forget_cached_source_info_for_objfile): Update.
 922         (info_source_command): Use g_source_cache.
 923         (find_source_lines, open_source_file_with_line_charpos): Remove.
 924         (print_source_lines_base, search_command_helper): Use g_source_cache.
 925         * source.h (open_source_file_with_line_charpos): Don't declare.
 926         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 927         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 928         Use g_source_cache.
 929
 930 2019-08-06  Tom Tromey  <tromey@adacore.com>
 931
 932         * source-cache.c (source_cache::get_plain_source_lines):
 933         Remove "first_line" and "last_line" parameters.
 934         (source_cache::get_source_lines): Cache plain text.
 935         * source-cache.h (class source_cache)
 936         <get_plain_source_lines>: Update.
 937
 938 2019-08-06  Tom Tromey  <tromey@adacore.com>
 939
 940         * source-cache.c (extract_lines): No longer a method.
 941         Changed type of parameter.  Include final newline.
 942         (selftests::extract_lines_test): New function.
 943         (_initialize_source_cache): Likewise.
 944         * source-cache.h (class source_cache)
 945         <extract_lines>: Don't declare.
 946
 947 2019-08-06  Tom Tromey  <tromey@adacore.com>
 948
 949         * breakpoint.c (init_breakpoint_sal): Update.
 950         (breakpoint): Update.
 951         * breakpoint.h (struct breakpoint) <filter>: Now a
 952         unique_xmalloc_ptr.
 953
 954 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 955
 956         * NEWS: Mention dictionary access on blocks.
 957         * python/py-block.c (blpy_getitem): New function.
 958         (block_object_as_mapping): New struct.
 959         (block_object_type): Use new struct for tp_as_mapping field.
 960
 961 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 962
 963         * objfiles.h (objfile): Add a comment describing partial symbols.
 964
 965 2019-08-05  Tom Tromey  <tromey@adacore.com>
 966
 967         * compile/compile.c (_initialize_compile): Use _(), not N_().
 968         * thread.c (_initialize_thread): Use _(), not N_().
 969         * stack.c (_initialize_stack): Use _(), not N_().
 970         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 971
 972 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 973
 974         * dwarf2read.c (struct dw2_symtab_iterator):
 975         <want_specific_block>: Remove.
 976         <block_index>: Change type to gdb::optional.
 977         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 978         change type of BLOCK_INDEX parameter to gdb::optional.
 979         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 980         (dw2_lookup_symbol): Don't pass argument for
 981         WANT_SPECIFIC_BLOCK.
 982         (dw2_expand_symtabs_for_function): Don't pass argument for
 983         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 984         (class dw2_debug_names_iterator)
 985         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 986         parameter, change BLOCK_INDEX type to gdb::optional.
 987         <m_want_specific_block>: Remove.
 988         <m_block_index>: Change type to gdb::optional.
 989         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 990         gdb::optional.  Re-write in function of gdb::optional.
 991         (dw2_debug_names_lookup_symbol): Don't pass argument for
 992         WANT_SPECIFIC_BLOCK.
 993         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 994         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 995         BLOCK_INDEX.
 996
 997 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 998
 999         * NEWS: Mention changes to "info sources" command.
1000
1001 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1002
1003         * symtab.c (filename_partial_match_opts): New struct type.
1004         (struct output_source_filename_data): New members
1005         regexp, c_regexp, partial_match.
1006         (output_source_filename): Use new members to decide to print file.
1007         (info_sources_option_defs): New variable.
1008         (make_info_sources_options_def_group, print_info_sources_header,
1009         info_sources_command_completer):
1010         New functions.
1011         (info_sources_command): Read new optional arguments.
1012         (_initialize_symtab): Update info sources help.
1013
1014 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1015
1016         * ada-lang.c (exception_support_info_v0): Renamed from...
1017         (default_exception_support_info): ... this.  Create new
1018         definition for v1.
1019         (ada_has_this_exception_support): Look up catch_handlers_sym.
1020         (ada_exception_support_info_sniffer): Try v0 after default.
1021
1022 2019-08-01  Tom Tromey  <tromey@adacore.com>
1023
1024         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1025         gdbarch.h.
1026
1027 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1028
1029         * s12z-tdep.c: Fix include path for s12z-opc.h.
1030
1031 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1032
1033         * NEWS: Require GNU make 3.82.
1034
1035 2019-07-16  Tom Tromey  <tom@tromey.com>
1036
1037         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1038         declare.
1039
1040 2019-07-30  Tom Tromey  <tromey@adacore.com>
1041
1042         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1043
1044 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1045
1046         * printcmd.c (print_address_symbolic): Print negative offsets.
1047         (build_address_symbolic): Force signed arithmetic when computing
1048         offset.
1049
1050 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1051
1052         PR/24474: Add a function to lookup static variables.
1053         * NEWS: Mention this new function.
1054         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1055         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1056         * python/python.c (python_GdbMethods): Add new function.
1057
1058 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1059
1060         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1061         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1062         (objfpy_lookup_static_symbol): New function.
1063         (objfile_object_methods): Add new functions.
1064
1065 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1066
1067         * NEWS: Mention 'set|show print frame-info'.  Mention new
1068         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1069         backtrace argument.  Mention that python frame filtering code
1070         is now consistent with what 'backtrace' command prints.
1071
1072 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1073
1074         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1075         comments.
1076         (print_frame_info_auto, print_frame_info_source_line,
1077         print_frame_info_location, print_frame_info_source_and_location,
1078         print_frame_info_location_and_address, print_frame_info_short_location):
1079         New declarations.
1080         (struct frame_print_options): New member print_frame_info.
1081         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1082         * stack.h (get_user_print_what_frame_info): New declaration.
1083         (frame_show_address): New declaration.
1084         * stack.c (print_frame_arguments_choices): New value 'presence'.
1085         (print_frame_info_auto, print_frame_info_source_line,
1086         print_frame_info_location, print_frame_info_source_and_location,
1087         print_frame_info_location_and_address, print_frame_info_short_location,
1088         print_frame_info_choices, print_frame_info_print_what): New definitions.
1089         (print_frame_args): Only print dots for args if print frame-arguments
1090         is 'presence'.
1091         (frame_print_option_defs): New element for "frame-info".
1092         (get_user_print_what_frame_info): New function.
1093         (frame_show_address): Make non static.  Move comment to stack.h.
1094         (print_frame_info_to_print_what): New function.
1095         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1096         to decide what to print.
1097         (backtrace_command_1): Handle the new print_frame_arguments_presence
1098         value.
1099         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1100         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1101         (py_print_frame): In non-mi mode, use LOCATION as default for
1102         print_what, similarly to frame information printed directly by
1103         backtrace command. Handle frame-info user option in non MI mode.
1104
1105 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1106
1107         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1108         Add case for debugging 32-bit target on 64-bit host.  Revise
1109         comment.
1110
1111 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1112
1113         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1114         instead of find_function_entry_range_from_pc.
1115
1116 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1117
1118         * stack.c (find_frame_funname): Remove code which preferred
1119         minsym over symtab sym in "certain pathological cases".
1120
1121         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1122         parameter.  Change type of "do_demangle" to bool.
1123         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1124         Pass suitable "prefer_sym_over_minsym" flag to
1125         build_address_symbolic().  Don't output "+" for negative offsets.
1126         * printcmd.c (print_address_symbolic): Update invocation of
1127         build_address_symbolic to include a "prefer_sym_over_minsym"
1128         flag.
1129         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1130         Restrict cases in which use of minimal symbol is preferred to that
1131         of a found symbol.  Update comments.
1132
1133         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1134         for entry pc when entry pc is out of range for that FDE.
1135
1136 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1137
1138         PR gdb/24839:
1139         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1140         type.
1141
1142 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1143
1144         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1145         this function's Python signature.
1146
1147
1148 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1149
1150         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1151         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1152         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1153         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1154         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1155
1156
1157 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1158
1159         * h8300-tdep.c (h8300_register_name_common): New.
1160         h8300_register_name): Use h8300_register_name_common.
1161         (h8300s_register_name): Likewise.
1162         (h8300sx_register_name): Likewise.
1163         (h8300h_register_nam): New.
1164         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1165
1166
1167 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1168
1169         * arm-tdep.c (arm_skip_cmse_entry): New function.
1170         (arm_is_sgstubs_section): New function.
1171         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1172
1173 2019-07-22  Tom Tromey  <tom@tromey.com>
1174
1175         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1176         Don't self-assign.
1177
1178 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1181         type_print.
1182
1183 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1186         so that GDB doesn't match any msymbols when searching in the
1187         TYPES_DOMAIN.
1188         (print_symbol_info): Print using typedef_print or type_print based
1189         on the type of the symbol.  Add updated FIXME comment moved from...
1190         (_initialize_symtab): ... move and update FIXME comment to above.
1191
1192 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * NEWS: Mention adding -q option to "info types".
1195         * symtab.c (struct info_types_options): New struct.
1196         (info_types_options_defs): New variable.
1197         (make_info_types_options_def_group): New function.
1198         (info_types_command): Use gdb::option framework to parse options.
1199         (info_types_command_completer): New function.
1200         (_initialize_symtab): Extend the help text on "info types" and
1201         register command completer.
1202
1203 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1204
1205         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1206         (lookup_symbol_in_objfile): Change int to block_enum and add a
1207         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1208
1209 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1210
1211         * MAINTAINERS (Write After Approval): Add self.
1212
1213 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1216         instruction to the dummy code region.
1217
1218 2019-07-19  Tom Tromey  <tromey@adacore.com>
1219
1220         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1221         (ARGSUSED, PARAMS, __func__): Remove rules.
1222
1223 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1224
1225         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1226         * features/arm/arm-with-iwmmxt.c: Remove.
1227         * features/arm/arm-with-iwmmxt.xml: Remove.
1228         * features/arm/arm-with-m-fpa-layout.c: Remove.
1229         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1230         * features/arm/arm-with-m-vfp-d16.c: Remove.
1231         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1232         * features/arm/arm-with-m.c: Remove.
1233         * features/arm/arm-with-m.xml: Remove.
1234         * features/arm/arm-with-neon.c: Remove.
1235         * features/arm/arm-with-neon.xml: Remove.
1236         * features/arm/arm-with-vfpv2.c: Remove.
1237         * features/arm/arm-with-vfpv2.xml: Remove.
1238         * features/arm/arm-with-vfpv3.c: Remove.
1239         * features/arm/arm-with-vfpv3.xml: Remove.
1240
1241 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1242
1243         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1244
1245 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1246
1247         * arch/aarch32.c (aarch32_create_target_description): Create
1248         target descriptions using features.
1249         * arch/arm.c (arm_create_target_description)
1250         (arm_create_mprofile_target_description): Likewise.
1251         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1252
1253 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1254
1255         * Makefile.in: Add new files.
1256         * aarch32-tdep.c: New file.
1257         * aarch32-tdep.h: New file.
1258         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1259         Call aarch32_read_description.
1260         * arch/aarch32.c: New file.
1261         * arch/aarch32.h: New file.
1262         * arch/arm.c (arm_create_target_description)
1263         (arm_create_mprofile_target_description): New function.
1264         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1265         (arm_create_target_description)
1266         (arm_create_mprofile_target_description): New declaration.
1267         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1268         read_description functions.
1269         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1270         Likewise.
1271         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1272         * arm-tdep.c (tdesc_arm_list): New variable.
1273         (arm_register_g_packet_guesses): Call create description functions.
1274         (arm_read_description) (arm_read_mprofile_description): New
1275         function.
1276         * arm-tdep.h (arm_read_description)
1277         (arm_read_mprofile_description): Add declaration.
1278         * configure.tgt: Add new files.
1279
1280 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1281
1282         * top.c (new_ui_command): Open specified terminal just once.
1283
1284 2019-07-18  Tom Tromey  <tromey@adacore.com>
1285
1286         * symtab.c (main_name): Constify return type.
1287         * symfile.c (set_initial_language): Update.
1288         * symtab.h (main_name): Constify return type.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.c (tui_update_source_window)
1293         (tui_update_source_window_as_is)
1294         (tui_update_source_windows_with_line): Remove return.
1295         * tui/tui-disasm.c (tui_show_disassem)
1296         (tui_show_disassem_and_update_source): Remove return.
1297         * tui/tui.c (tui_reset): Remove return.
1298         * tui/tui-wingeneral.c
1299         (tui_check_and_display_highlight_if_needed): Remove return.
1300
1301 2019-07-17  Tom Tromey  <tom@tromey.com>
1302
1303         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-winsource.h (struct tui_exec_info_window)
1308         (struct tui_source_window_base): Move from tui-data.h.
1309         * tui/tui-winsource.c: Move many method definitions from
1310         elsewhere.  Remove "structuring" comments.
1311         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1312         (tui_source_window_base::refresh_window): Move to
1313         tui-winsource.c.
1314         * tui/tui-win.c (tui_source_window_base::refresh_all)
1315         (tui_source_window_base::update_tab_width)
1316         (tui_source_window_base::set_new_height)
1317         (tui_source_window_base::do_make_visible_with_new_height): Move to
1318         tui-winsource.c.
1319         * tui/tui-source.h: Update.
1320         * tui/tui-source.c (tui_source_window_base::reset): Move to
1321         tui-winsource.c.
1322         * tui/tui-disasm.h: Update.
1323         * tui/tui-data.h (struct tui_exec_info_window): Move to
1324         tui-winsource.h.
1325         (struct tui_source_window_base): Likewise.
1326         * tui/tui-data.c (tui_source_window_base::clear_detail)
1327         (tui_source_window_base, ~tui_source_window_base): Move to
1328         tui-winsource.c.
1329
1330 2019-07-17  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-win.c (tui_resize_all)
1333         (tui_source_window_base::update_tab_width)
1334         (tui_adjust_win_heights): Update.
1335         (tui_win_info::make_invisible_and_set_new_height): Rename from
1336         make_invisible_and_set_new_height.
1337         * tui/tui-data.h (struct tui_win_info)
1338         <make_invisible_and_set_new_height>: New method.
1339
1340 2019-07-17  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui.c: Update.
1343         * tui/tui-source.h (struct tui_source_window): Move from
1344         tui-data.h.
1345         * tui/tui-layout.c: Update.
1346         * tui/tui-disasm.c: Update.
1347         * tui/tui-data.h (struct tui_source_window): Move to
1348         tui-source.h.
1349
1350 2019-07-17  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1353         tui-data.h.
1354         * tui/tui-data.h (struct tui_disasm_window): Move to
1355         tui-disasm.h.
1356
1357 2019-07-17  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-regs.h (struct tui_data_item_window): Move from
1360         tui-data.h.
1361         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1362         * tui/tui-data.h (struct tui_data_item_window): Move to
1363         tui-regs.h.
1364         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1365
1366 2019-07-17  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui.c: Update.
1369         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1370         (tui_cmd_window::max_height): Move to tui-command.c.
1371         * tui/tui-layout.c: Update.
1372         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1373         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1374         tui-command.c.
1375         * tui/tui-command.h (struct tui_cmd_window): Move from
1376         tui-data.h.
1377         * tui/tui-command.c: Remove "structuring" comments.
1378         (tui_cmd_window::clear_detail)
1379         (tui_cmd_window::do_make_visible_with_new_height)
1380         (tui_cmd_window::max_height): Move from elsewhere.
1381
1382 2019-07-17  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1385         Now static.
1386         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1387         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1388
1389 2019-07-17  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui.c: Update.
1392         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1393         tui-regs.c.
1394         * tui/tui-windata.h: Remove file.
1395         * tui/tui-windata.c: Remove file.
1396         * tui/tui-win.c (tui_data_window::set_new_height)
1397         (tui_data_window::do_make_visible_with_new_height): Move to
1398         tui-regs.c.
1399         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1400         * tui/tui-regs.c: Remove "structuring" comments.
1401         (tui_data_window::first_data_item_displayed)
1402         (tui_data_window::delete_data_content_windows)
1403         (tui_data_window::erase_data_content)
1404         (tui_data_window::display_all_data)
1405         (tui_data_window::refresh_all)
1406         (tui_data_window::do_scroll_vertical)
1407         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1408         (tui_data_window::do_make_visible_with_new_height)
1409         (tui_data_window::refresh_window): Move from elsewhere.
1410         (_initialize_tui_regs): Move to end of file.
1411         * tui/tui-layout.c: Update.
1412         * tui/tui-hooks.c: Update.
1413         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1414         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1415         tui-regs.c.
1416         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1417
1418 2019-07-17  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1421         seen.
1422
1423 2019-07-17  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-win.c (tui_source_window_base::set_new_height)
1426         (tui_source_window_base::do_make_visible_with_new_height): Use
1427         m_has_locator field directly.
1428         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1429         method.
1430         (struct tui_source_window_base) <has_locator>: Likewise.
1431
1432 2019-07-17  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1435         Don't declare.
1436         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1437         Remove.
1438         * tui/tui-win.c (tui_source_window_base::set_new_height)
1439         (tui_source_window_base::set_new_height)
1440         (make_invisible_and_set_new_height)
1441         (tui_source_window_base::do_make_visible_with_new_height)
1442         (tui_source_window_base::do_make_visible_with_new_height):
1443         Update.
1444         * tui/tui-layout.c (show_source_disasm_command, show_data)
1445         (show_source_or_disasm_and_command): Update.
1446         * tui/tui-layout.c (show_layout): Update.
1447
1448 2019-07-17  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-layout.c (make_data_window): Remove.
1451         (show_data): Unify creation and re-initialization cases.
1452
1453 2019-07-17  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-layout.c (make_source_window, make_disasm_window):
1456         Remove.
1457         (show_data): Unify creation and re-initialization cases.
1458
1459 2019-07-17  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-layout.c (make_command_window): Remove.
1462         (show_source_disasm_command, show_source_or_disasm_and_command):
1463         Unify creation and re-initialization cases.
1464
1465 2019-07-17  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1468         creation and re-initialization cases.
1469
1470 2019-07-17  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-regs.c (tui_get_register): Return void.
1473
1474 2019-07-17  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1477         Simplify.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1482         resetting.
1483
1484 2019-07-17  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1487         * tui/tui-regs.c (tui_reg_layout): New function.
1488         (tui_show_registers, tui_reg_command): Use it.
1489         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1490         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1491         parameters.
1492         (tui_layout_command): Remove.
1493
1494 2019-07-17  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-layout.h (tui/tui-layout): Return void.
1497         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1498
1499 2019-07-17  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-layout.c (show_source_disasm_command, show_data):
1502         Update.
1503         (reset_locator): Remove.
1504         (show_source_or_disasm_and_command): Update.
1505
1506 2019-07-17  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-source.c (tui_source_window_base::reset): Remove
1509         win_type parameter.
1510         * tui/tui-layout.c (make_command_window, make_source_window)
1511         (make_disasm_window, make_data_window)
1512         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1513         (reset_locator, show_source_or_disasm_and_command): Update.
1514         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1515         win_type parameter.
1516         (struct tui_source_window_base) <reset>: Likewise.
1517
1518 2019-07-17  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-layout.c (show_source_disasm_command): Use
1521         reset_locator.
1522         (reset_locator): New function.
1523         (init_and_make_win): Remove.
1524         (show_source_or_disasm_and_command): Use reset_locator.
1525
1526 2019-07-17  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1529         condition.
1530         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1531         Remove condition.
1532         * tui/tui-source.c (tui_source_window_base::reset): New method.
1533         * tui/tui-layout.c (make_command_window): Don't call
1534         init_and_make_win.
1535         (make_source_window, make_disasm_window): Don't call
1536         make_source_or_disasm_window.
1537         (make_data_window): Don't call init_and_make_win.  Change calling
1538         convention.
1539         (show_source_disasm_command, show_data): Simplify.
1540         (make_source_or_disasm_window): Remove.
1541         (show_source_or_disasm_and_command): Simplify.
1542         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1543         (struct tui_source_window_base) <reset>: Likewise.
1544         <execution_info>: Remove initializer.
1545         * tui/tui-data.c (tui_source_window_base): Initialize
1546         execution_info.
1547
1548 2019-07-17  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1551         variable.
1552
1553 2019-07-17  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui.c (tui_rl_other_window): Update.
1556         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1557         superclass method first.  Always iterate over regs_content.
1558         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1559         method.
1560         * tui/tui-win.c (tui_set_focus_command): Update.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-win.c (tui_set_focus_command): Rename from
1565         tui_set_focus.  Call tui_enable.
1566         (tui_set_focus_command): Remove.
1567
1568 2019-07-17  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1571         refresh_window.
1572         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1573         touchwin.
1574         (tui_data_window::refresh_window): Call refresh_window on data
1575         items.  Always call superclass refresh_window.
1576         (tui_win_info::refresh): Remove.
1577         (tui_source_window_base::refresh_window): Update.
1578         (tui_refresh_all): Update.
1579         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1580         refresh_window.
1581         (show_source_or_disasm_and_command): Likewise.
1582         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1583         (struct tui_source_window_base) <refresh>: Likewise.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-winsource.c (tui_clear_source_content)
1588         (tui_show_source_content): Update.
1589         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1590         whether content is empty.
1591         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1592         Remove.
1593
1594 2019-07-17  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1597         window's contents.
1598         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1599         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1600
1601 2019-07-17  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1604         (struct tui_data_item_window): Update.
1605
1606 2019-07-17  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1609         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1610         defines.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-winsource.h (tui_erase_source_content)
1615         (tui_clear_source_content): Remove "display_prompt" parameter.
1616         * tui/tui-winsource.c (tui_update_source_window_as_is)
1617         (tui_update_source_windows_with_addr): Update.
1618         (tui_clear_source_content): Remove "display_prompt" parameter.
1619         (tui_erase_source_content): Likewise.  Simplify.
1620         (tui_show_source_content): Update.
1621         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1622         * tui/tui-stack.c (tui_show_frame_info): Update.
1623         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1624         Remove defines.
1625
1626 2019-07-17  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1629         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1630         parameter.
1631         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1632         parameter.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-winsource.c (tui_clear_source_content)
1637         (tui_show_source_content, tui_show_exec_info_content)
1638         (tui_clear_exec_info_content): Update.
1639         * tui/tui-stack.c (tui_show_locator_content): Update.
1640         (tui_show_frame_info): Update.
1641         * tui/tui-source.h (tui_source_window): Don't declare.
1642         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1643         from tui_source_is_displayed.
1644         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1645         Remove field.
1646         (struct tui_source_window_base) <content_in_use>: New field.  Now
1647         bool.
1648         (struct tui_source_window) <showing_source_p>: New method.
1649         (TUI_SRC_WIN): Change cast.
1650         * tui/tui-data.c (tui_initialize_static_data): Update.
1651
1652 2019-07-17  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1655         location_matches_p.
1656         * tui/tui-source.c (tui_source_window::location_matches_p): New
1657         method.
1658         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1659         method.
1660         * tui/tui-data.h (struct tui_source_window_base)
1661         <location_matches_p>: New method.
1662         (struct tui_source_window, struct tui_disasm_window)
1663         <location_matches_p>: Likewise.
1664
1665 2019-07-17  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-win.c (tui_set_win_height_command): Rename from
1668         tui_set_win_height.
1669         (tui_set_win_height_command): Remove.
1670
1671 2019-07-17  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-source.c (tui_source_window): New constructor.  Add
1674         observer.
1675         (~tui_source_window): New destructor.
1676         (tui_source_window::style_changed): New method.
1677         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1678         (tui_attach_detach_observers): Update.
1679         * tui/tui-data.h (struct tui_source_window): Make constructor not
1680         inline.  Add destructor.
1681         (struct tui_source_window) <style_changed>: New method.
1682         <m_observable>: New member.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1687         * tui/tui-win.c (tui_resize_all): Fix typo.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1692         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1693         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1694         * tui/tui-win.c (window_name_completer): Use foreach.
1695         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1696         (update_tab_width): Likewise.
1697         * tui/tui-layout.c (show_layout): Update.
1698         * tui/tui-data.h (class tui_window_iterator): New.
1699         (struct all_tui_windows): New.
1700         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1705         parameter.  Don't reference globals.
1706         (tui_reg_command): Update.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-regs.c (tui_show_registers): Simplify.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-regs.c (tui_show_registers): Update.
1715         (tui_show_register_group): Add win_info parameter.
1716
1717 2019-07-17  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1720         Rename from tui_display_reg_element_at_line.
1721         (tui_data_window::display_registers_from_line): Update.
1722         * tui/tui-data.h (struct tui_data_window)
1723         <display_reg_element_at_line>: New method.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-regs.h (tui_display_registers_from)
1728         (tui_display_registers_from_line): Don't declare.
1729         * tui/tui-windata.c (tui_data_window::display_all_data)
1730         (tui_data_window::refresh_all)
1731         (tui_data_window::do_scroll_vertical): Update.
1732         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1733         from tui_display_registers_from.
1734         (tui_display_reg_element_at_line): Update.
1735         (tui_data_window::display_registers_from_line): Rename from
1736         tui_display_registers_from_line.
1737         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1738         display_registers_from_line>: New methods.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1743         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1744         from tui_erase_data_content.
1745         (tui_data_window::display_all_data)
1746         (tui_data_window::refresh_all)
1747         (tui_data_window::do_scroll_vertical): Update.
1748         * tui/tui-regs.c (tui_show_registers): Update.
1749         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1750         New method.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1755         declare.
1756         * tui/tui-windata.c
1757         (tui_data_window::delete_data_content_windows): Rename from
1758         tui_delete_data_content_windows.
1759         (tui_data_window::display_all_data)
1760         (tui_data_window::do_scroll_vertical): Update.
1761         * tui/tui-data.h (struct tui_data_window)
1762         <delete_data_content_windows>: New method.
1763
1764 2019-07-17  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1767         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1772         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1773         from tui_display_all_data.
1774         * tui/tui-win.c
1775         (tui_data_window::do_make_visible_with_new_height): Update.
1776         * tui/tui-regs.c (tui_show_registers): Update.
1777         * tui/tui-layout.c (tui_set_layout): Update.
1778         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1779         method.
1780
1781 2019-07-17  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1784         * tui/tui-windata.c (tui_display_data_from): Remove.
1785         (tui_data_window::refresh_all): Update.
1786
1787 2019-07-17  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1790         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1791         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1792         tui_display_registers_from_line.
1793         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1794         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1795         "force_display" parameter.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1800         declare.
1801         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1802         Rename from tui_first_reg_element_no_inline.
1803         (tui_display_reg_element_at_line)
1804         (tui_display_registers_from_line): Update.
1805         * tui/tui-data.h (struct tui_data_window)
1806         <first_reg_element_no_inline>: New method.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-windata.c (tui_display_data_from)
1811         (tui_data_window::do_scroll_vertical): Update.
1812         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1813         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1814         Rename from tui_line_from_reg_element_no.
1815         (tui_display_registers_from_line): Update.
1816         * tui/tui-data.h (struct tui_data_window)
1817         <line_from_reg_element_no>: New method.
1818
1819 2019-07-17  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1822         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1823         tui_last_regs_line_no.
1824         (tui_display_reg_element_at_line)
1825         (tui_display_registers_from_line): Update.
1826         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1827         method.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         PR tui/24722:
1832         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1833         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1834         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1835         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1836         (tui_update_breakpoint_info): Likewise.
1837         * tui/tui-hooks.c (tui_event_create_breakpoint)
1838         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1839         Update.
1840
1841 2019-07-17  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1844
1845 2019-07-17  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-winsource.c (tui_update_source_window_as_is)
1848         (tui_update_source_windows_with_addr): Update.
1849         * tui/tui-source.h (tui_set_source_content)
1850         (tui_show_symtab_source): Add "win_info" parameter.
1851         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1852         parameter.
1853         (tui_show_symtab_source): Likewise.
1854
1855 2019-07-17  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-wingeneral.c
1858         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1859
1860 2019-07-17  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1863         (struct tui_cmd_window) <can_scroll>: New method.
1864         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1865         method.
1866
1867 2019-07-17  Tom Tromey  <tromey@adacore.com>
1868
1869         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1870         do_field_signed>: Rename.  Change type of "value".
1871         * ui-out.c (ui_out::field_signed): Rename from field_int.
1872         Change type of "value".
1873         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1874         type of "value".
1875         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1876         do_field_int.  Change type of "value".
1877         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1878         do_field_int.  Change type of "value".
1879         * tracepoint.c (trace_status_mi, tfind_1)
1880         (print_one_static_tracepoint_marker): Update.
1881         * thread.c (print_thread_info_1, print_selected_thread_frame):
1882         Update.
1883         * stack.c (print_frame, print_frame_info): Update.
1884         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1885         Update.
1886         * source.c (print_source_lines_base): Update.
1887         * skip.c (info_skip_command): Update.
1888         * record-btrace.c (btrace_ui_out_decode_error)
1889         (btrace_call_history_src_line): Update.
1890         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1891         Update.
1892         * progspace.c (print_program_space): Update.
1893         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1894         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1895         do_field_int.  Change type of "value".
1896         * mi/mi-out.c (mi_ui_out::do_table_begin)
1897         (mi_ui_out::do_table_header): Update.
1898         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1899         type of "value".
1900         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1901         (mi_cmd_data_list_changed_registers, output_register)
1902         (mi_cmd_data_read_memory, mi_load_progress)
1903         (mi_cmd_trace_frame_collected): Update.
1904         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1905         Update.
1906         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1907         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1908         (mi_cmd_var_list_children, varobj_update_one): Update.
1909         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1910         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1911         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1912         * inferior.c (print_inferior): Update.
1913         * gdb_bfd.c (print_one_bfd): Update.
1914         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1915         Update.
1916         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1917         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1918         do_field_int.  Change type of "value".
1919         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1920         do_field_int.  Change type of "value".
1921         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1922         (print_one_breakpoint_location, print_it_catch_fork)
1923         (print_one_catch_fork, print_it_catch_vfork)
1924         (print_one_catch_vfork, print_it_catch_solib)
1925         (print_it_catch_exec, print_it_ranged_breakpoint)
1926         (print_mention_watchpoint, print_mention_masked_watchpoint)
1927         (bkpt_print_it, update_static_tracepoint): Update.
1928         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1929         * break-catch-syscall.c (print_it_catch_syscall): Update.
1930         * ada-tasks.c (print_ada_task_info): Update.
1931         * ada-lang.c (print_it_exception, print_mention_exception):
1932         Update.
1933
1934 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1935
1936         PR breakpoints/24541
1937         * gdbarch.c: Regenerate.
1938         * gdbarch.h: Regenerate.
1939         * gdbarch.sh: Adjust return type and parameter types for
1940         'stap_adjust_register'.
1941         (i386_stap_adjust_register): Adjust signature and return new
1942         register name.
1943         * stap-probe.c (stap_parse_register_operand): Adjust use of
1944         'gdbarch_stap_adjust_register'.
1945
1946 2019-07-17  Tom Tromey  <tromey@adacore.com>
1947
1948         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1949         declare VEC.
1950         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1951         std::vector.
1952         (struct s390_process_info): Add initializers.
1953         (s390_add_process): Use new.
1954         (s390_linux_nat_target::low_forget_process): Use delete.
1955         (s390_linux_nat_target::low_new_fork)
1956         (s390_linux_nat_target::stopped_by_watchpoint)
1957         (s390_linux_nat_target::low_prepare_to_resume)
1958         (s390_linux_nat_target::insert_watchpoint)
1959         (s390_linux_nat_target::insert_hw_breakpoint)
1960         (s390_linux_nat_target::remove_watchpoint)
1961         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1962
1963 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1964
1965         * aarch64-fbsd-nat.c: Include regcache.h.
1966         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1967         argument.
1968         (aarch64_fbsd_nat_target::fetch_registers)
1969         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1970         variable.
1971         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1972
1973 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1974
1975         * fbsd-nat.c: Include gdbarch.h.
1976
1977 2019-07-15  Tom Tromey  <tromey@adacore.com>
1978
1979         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1980
1981 2019-07-15  Tom Tromey  <tromey@adacore.com>
1982
1983         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1984         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1985         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1986         * cli-out.c (cli_ui_out::do_field_int): New method.
1987         * ui-out.c (ui_out::field_unsigned): New method.
1988         * symfile.c (generic_load): Use field_unsigned.
1989         (print_transfer_performance): Likewise.
1990         * record-btrace.c (ui_out_field_uint): Remove.
1991         (btrace_call_history_insn_range, btrace_call_history): Use
1992         field_unsigned.
1993         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1994         field_unsigned.
1995         * ui-out.h (class ui_out) <field_unsigned>: New method.
1996         <do_field_unsigned>: Likewise.
1997
1998 2019-07-15  Tom Tromey  <tromey@adacore.com>
1999
2000         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2001         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2002         * target.c (flash_erase_command): Use field_string.
2003         * infrun.c (print_signal_received_reason): Use field_string.
2004         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2005         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2006         field_string.
2007         * ada-tasks.c (print_ada_task_info): Use field_string.
2008
2009 2019-07-15  Tom Tromey  <tromey@adacore.com>
2010
2011         * target.c (flash_erase_command): Use field_core_addr.
2012         * symfile.c (generic_load): Use field_core_addr.
2013         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2014         Use field_core_addr.
2015         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2016         field_core_addr.
2017
2018 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2019
2020         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2021         value if its desired type is smaller than a CORE_ADDR and signed.
2022
2023 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2026         of changes to field names, and use new is_reference field to
2027         decide if a property is a reference or not.
2028         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2029         field.
2030         (struct dwarf2_property_baton): Update header comment, rename
2031         'referenced_type' to 'property_type' and update comments.
2032         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2033         default property type, store in property baton, update to take
2034         accound of renamed field.
2035         (read_func_scope): Update call to attr_to_dynamic_prop.
2036         (read_array_type): Likewise.
2037         (dwarf2_per_cu_addr_sized_int_type): New function.
2038         (read_subrange_index_type): Move type finding code to
2039         dwarf2_per_cu_addr_sized_int_type.
2040         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2041         (dwarf2_per_cu_addr_type): New function.
2042         (set_die_type): Update calls to attr_to_dynamic_prop.
2043
2044 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2045
2046         * dwarf2read.c (read_subrange_index_type): New function.
2047         (read_subrange_type): Move code into new function and call it.
2048         * gdbtypes.c (create_range_type): Add some asserts.
2049
2050 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2053         update return statements.
2054         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2055         declaration, and update comment to match.
2056         * gdbtypes.c (resolve_dynamic_array): Update call to
2057         dwarf2_evaluate_property to match new return type.
2058
2059 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2060
2061         * valarith.c (value_subscripted_rvalue): Change lowerbound
2062         parameter type from int to LONGEST.
2063         * value.h (value_subscripted_rvalue): Likewise in declaration.
2064
2065 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2066
2067         * cli/cli-utils.c (info_print_command_completer): New function.
2068         * cli/cli-utils.h: Add 'completer.h' include, and forward
2069         declaration for 'struct cmd_list_element'.
2070         (info_print_command_completer): Declare.
2071         * stack.c (_initialize_stack): Add completer for 'info locals' and
2072         'info args'.
2073         * symtab.c (_initialize_symtab): Add completer for 'info
2074         variables' and 'info functions'.
2075         * NEWS: Mention completion for additional info commands.
2076
2077 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2078
2079         * cli/cli-utils.c (extract_info_print_args): Delete.
2080         (extract_arg_maybe_quoted): Delete.
2081         (info_print_options_defs): New variable.
2082         (make_info_print_options_def_group): New function.
2083         (extract_info_print_options): Define new function.
2084         * cli/cli-utils.h (extract_info_print_args): Delete.
2085         (struct info_print_options): New structure.
2086         (extract_info_print_options): Declare new function.
2087         * stack.c (info_locals_command): Update to use new
2088         extract_info_print_options, also add a header comment.
2089         (info_args_command): Likewise.
2090         * symtab.c (info_variables_command): Likewise.
2091         (info_functions_command): Likewise.
2092
2093 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2094
2095         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2096         to extract string arguments.
2097         * common/common-utils.c (extract_string_maybe_quoted): New function.
2098         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2099
2100 2019-07-11  Tom Tromey  <tromey@adacore.com>
2101
2102         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2103         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2104         * top.h (gdbinit): Don't declare.
2105         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2106         into...
2107         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2108         * top.c (gdb_init): Don't call init_cli_cmds.
2109         (gdbinit): Remove.
2110         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2111
2112 2019-07-11  Tom Tromey  <tromey@adacore.com>
2113
2114         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2115         after it has been moved.
2116
2117 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2118
2119         * valops.c (value_must_coerce_to_target): Change return type to
2120         bool.
2121         * value.h (value_must_coerce_to_target): Likewise.
2122
2123 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2124
2125         * breakpoint.c (is_hardware_watchpoint): Remove
2126         forward-declaration.
2127         (is_masked_watchpoint): Change return type to bool.
2128         (is_tracepoint): Likewise.
2129         (is_breakpoint): Likewise.
2130         (is_hardware_watchpoint): Likewise.
2131         (is_watchpoint): Likewise.
2132         (is_no_memory_software_watchpoint): Likewise.
2133         (is_catchpoint): Likewise.
2134         (breakpoint_1): Make FILTER parameter's return type bool.
2135         is_masked_watchpoint): Change return type to bool.
2136         (save_breakpoints): Make FILTER parameter's return type bool.
2137         * breakpoint.h (is_breakpoint): Change return type to bool.
2138         (is_watchpoint): Likewise.
2139         (is_catchpoint): Likewise.
2140         (is_tracepoint): Likewise.
2141
2142 2019-07-10  Tom Tromey  <tom@tromey.com>
2143
2144         * defs.h: Don't include gdbarch.h.
2145         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2146         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2147         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2148         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2149         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2150         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2151         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2152         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2153         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2154         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2155         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2156         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2157         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2158         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2159         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2160         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2161         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2162         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2163         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2164         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2165         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2166         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2167         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2168         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2169         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2170         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2171         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2172
2173 2019-07-10  Tom Tromey  <tromey@adacore.com>
2174
2175         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2176         * breakpoint.c (init_ada_exception_breakpoint): Register as
2177         bp_catchpoint.
2178         (print_one_breakpoint_location, print_one_breakpoint): Use
2179         is_ada_exception_catchpoint.
2180         * ada-lang.c (class ada_catchpoint_location): Pass
2181         bp_loc_software_breakpoint to bp_location constructor.
2182         (is_ada_exception_catchpoint): New function.
2183
2184 2019-07-10  Tom Tromey  <tromey@adacore.com>
2185
2186         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2187         VEC.
2188         (struct arm_exidx_entry): New method operator<.
2189         (struct arm_exidx_data) <section_maps>: Change type.
2190         (arm_exidx_data_free): Remove.
2191         (arm_exidx_data_key): Change type.  Move lower.
2192         (arm_exidx_new_objfile): Update.
2193         (arm_compare_exidx_entries): Remove.
2194         (arm_find_exidx_entry, _initialize_arm_tdep)
2195
2196 2019-07-10  Tom Tromey  <tromey@adacore.com>
2197
2198         * solib-spu.c (ocl_program_data_key): Change type.
2199         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2200         Update.
2201
2202 2019-07-10  Tom Tromey  <tromey@adacore.com>
2203
2204         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2205         (struct solib_aix_inferior_data) <library_list>: Change type.
2206         (solib_aix_inferior_data_handle): Change type.
2207         (get_solib_aix_inferior_data): Update.
2208         (solib_aix_free_library_list): Remove.
2209         (library_list_start_library): Update.
2210         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2211         return type.
2212         (solib_aix_get_library_list)
2213         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2214         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2215
2216 2019-07-10  Tom Tromey  <tromey@adacore.com>
2217
2218         * solib-dsbt.c (struct dsbt_info): Add initializers.
2219         (solib_dsbt_pspace_data): Change type.
2220         (dsbt_pspace_data_cleanup): Remove.
2221         (get_dsbt_info, _initialize_dsbt_solib): Update.
2222
2223 2019-07-10  Tom Tromey  <tromey@adacore.com>
2224
2225         * spu-tdep.c (spu_overlay_data): Change type.
2226         (spu_get_overlay_table, spu_overlay_new_objfile)
2227         (_initialize_spu_tdep): Update.
2228
2229 2019-07-10  Tom Tromey  <tromey@adacore.com>
2230
2231         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2232         destructor.
2233         (dbx_objfile_data_key): Change type and declare later.
2234         (DBX_SYMFILE_INFO): Rewrite.
2235         * dbxread.c (dbx_objfile_data_key): Change type.
2236         (dbx_symfile_init): Update.
2237         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2238         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2239         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2240
2241 2019-07-10  Tom Tromey  <tromey@adacore.com>
2242
2243         * jit.c (jit_program_space_key): Change type.  Move lower.
2244         (get_jit_program_space_data): Update.
2245         (jit_program_space_data_cleanup): Remove.
2246         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2247         Update.
2248         (struct jit_program_space_data): Add initializers.
2249
2250 2019-07-10  Tom Tromey  <tromey@adacore.com>
2251
2252         * solib-darwin.c (struct darwin_info): Add initializers.
2253         (solib_darwin_pspace_data): Change type.
2254         (darwin_pspace_data_cleanup): Remove.
2255         (get_darwin_info, _initialize_darwin_solib): Update.
2256
2257 2019-07-10  Tom Tromey  <tromey@adacore.com>
2258
2259         * remote-sim.c (struct sim_inferior_data): Add initializers,
2260         constructor, and destructor.
2261         (sim_inferior_data_key): Change type.  Move lower.
2262         (check_for_duplicate_sim_descriptor): Update.
2263         (get_sim_inferior_data): Use new.  Update.
2264         (~sim_inferior_data_cleanup): Rename from
2265         sim_inferior_data_cleanup.  Simplify.
2266         (gdbsim_close_inferior, simulator_command)
2267         (sim_command_completer, _initialize_remote_sim): Update.
2268         (next_pid, INITIAL_PID): Move earlier.
2269
2270 2019-07-10  Tom Tromey  <tromey@adacore.com>
2271
2272         * python/python-internal.h (create_thread_object): Return
2273         gdbpy_ref.
2274         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2275         * python/py-inferior.c (struct threadlist_entry): Add
2276         constructor.
2277         <thread_obj>: Now a gdbpy_ref.
2278         (thread_to_thread_object): Update.
2279         (add_thread_object): Use new.
2280         (delete_thread_object): Use delete.
2281         (infpy_threads): Update.
2282         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2283         GIL.
2284
2285 2019-07-10  Tom Tromey  <tromey@adacore.com>
2286
2287         * valops.c (value_cast): Specialize error message for Ada.
2288
2289 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2290
2291         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2292
2293 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2294
2295         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2296         bpstat_should_step): Return bool, adjust comments.
2297         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2298         bpstat_should_step): Likewise.
2299
2300 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2301
2302         * features/Makefile: Use feature target descriptions for Arm.
2303         * features/arm/arm-core.c: Generate new file.
2304         * features/arm/arm-fpa.c: Likewise.
2305         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2306         * features/arm/arm-m-profile.c: Likewise.
2307         * features/arm/arm-vfpv2.c: Likewise.
2308         * features/arm/arm-vfpv3.c: Likewise.
2309         * features/arm/xscale-iwmmxt.c: Likewise.
2310         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2311
2312 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2313
2314         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2315         ptrace earlier.
2316
2317 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2318
2319         * features/aarch64-pauth.c: Regenerate.
2320
2321 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2322
2323         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2324         bool.
2325         (bpstat_what): Use false instead of 0.
2326
2327 2019-07-09  Pedro Alves  <palves@redhat.com>
2328
2329         * break-catch-throw.c (is_exception_catchpoint): New.
2330         * breakpoint.c (print_one_breakpoint_location): New parameter
2331         'raw_loc'.  Handle it.  Use
2332         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2333         looking at the breakpoint's type.
2334         (print_one_breakpoint): If handling "maint info breakpoints", also
2335         print locations of exception catchpoints.
2336         * breakpoint.h (is_exception_catchpoint): Declare.
2337
2338 2019-07-09  Pedro Alves  <palves@redhat.com>
2339
2340         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2341         "addr" field.
2342         (allocate_location_exception_catchpoint): New.
2343         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2344         (initialize_throw_catchpoint_ops): Install
2345         allocate_location_exception_catchpoint as allocate_location
2346         method.
2347         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2348         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2349         bp_loc_other.
2350         (breakpoint_address_is_meaningful): Delete.
2351         (bl_address_is_meaningful): New.
2352         (breakpoint_locations_match): Adjust comment.
2353         (bp_location_from_bp_type): New, factored out of...
2354         (bp_location::bp_location(breakpoint *)): ... this.
2355         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2356         factored out of...
2357         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2358         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2359         breakpoint_address_is_meaningful.
2360         (bp_locations_compare): Adjust comment.
2361         (update_global_location_list): Use bl_address_is_meaningful
2362         instead of breakpoint_address_is_meaningful.
2363         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2364         explicit.
2365         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2366         * python/py-breakpoint.c (bppy_get_location): No longer check
2367         whether location is null.
2368
2369 2019-07-09  Pedro Alves  <palves@redhat.com>
2370
2371         PR c++/15468
2372         * breakpoint.c (print_one_breakpoint_location): Remove
2373         single-location assert.
2374
2375 2019-07-09  Tom Tromey  <tom@tromey.com>
2376
2377         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2378         * configure: Rebuild.
2379         * configure.ac: Change common to gdbsupport.
2380         * gdbsupport: Rename from common.
2381         * acinclude.m4: Change common to gdbsupport.
2382         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2383         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2384         gdbsupport.
2385         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2386         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2387         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2388         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2389         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2390         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2391         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2392         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2393         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2394         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2395         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2396         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2397         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2398         coff-pe-read.c, command.h, compile/compile-c-support.c,
2399         compile/compile-c.h, compile/compile-cplus-symbols.c,
2400         compile/compile-cplus-types.c, compile/compile-cplus.h,
2401         compile/compile-loc2c.c, compile/compile.c, completer.c,
2402         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2403         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2404         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2405         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2406         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2407         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2408         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2409         features/aarch64-core.c, features/aarch64-fpu.c,
2410         features/aarch64-pauth.c, features/aarch64-sve.c,
2411         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2412         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2413         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2414         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2415         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2416         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2417         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2418         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2419         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2420         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2421         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2422         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2423         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2424         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2425         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2426         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2427         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2428         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2429         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2430         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2431         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2432         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2433         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2434         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2435         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2436         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2437         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2438         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2439         minsyms.c, mips-linux-tdep.c, namespace.h,
2440         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2441         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2442         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2443         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2444         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2445         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2446         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2447         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2448         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2449         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2450         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2451         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2452         procfs.c, producer.c, progspace.h, psymtab.h,
2453         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2454         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2455         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2456         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2457         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2458         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2459         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2460         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2461         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2462         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2463         target-memory.c, target.c, target.h, target/waitstatus.c,
2464         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2465         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2466         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2467         unittests/array-view-selftests.c,
2468         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2469         unittests/common-utils-selftests.c,
2470         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2471         unittests/format_pieces-selftests.c,
2472         unittests/function-view-selftests.c,
2473         unittests/lookup_name_info-selftests.c,
2474         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2475         unittests/mkdir-recursive-selftests.c,
2476         unittests/observable-selftests.c,
2477         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2478         unittests/parse-connection-spec-selftests.c,
2479         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2480         unittests/scoped_fd-selftests.c,
2481         unittests/scoped_mmap-selftests.c,
2482         unittests/scoped_restore-selftests.c,
2483         unittests/string_view-selftests.c, unittests/style-selftests.c,
2484         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2485         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2486         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2487         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2488         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2489         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2490
2491 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2494         bool value.
2495         (decode_digits_ordinary): Set explicit_line field in sal.
2496         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2497         symtab_and_line that was set on an explicit line number in
2498         assembler code.  Do always update the recorded symtab and line if
2499         we do skip the prologue.
2500
2501 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * breakpoint.c (set_breakpoint_location_function): Remove
2504         explicit_loc parameter.
2505         (momentary_breakpoint_from_master): Update call to
2506         set_breakpoint_location_function.
2507         (add_location_to_breakpoint): Likewise.
2508
2509 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2512         required features based on default bfd type when no specific bfd
2513         is present.
2514
2515 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2516
2517         * NEWS: Mention that GDB printf and eval commands can now print
2518         C-style and Ada-style convenience var strings without
2519         calling the inferior.
2520         * printcmd.c (printf_c_string): Locally print GDB internal var
2521         instead of transiting via the inferior.
2522         (printf_wide_c_string): Likewise.
2523
2524 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2527
2528 2019-07-04  Tom Tromey  <tom@tromey.com>
2529
2530         PR tui/24724:
2531         * tui/tui-winsource.c (tui_clear_source_content): Update.
2532         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2533         (tui_update_breakpoint_info): Update.
2534         (tui_set_exec_info_content): Update.
2535         * tui/tui-source.c (tui_set_source_content_nil): Update.
2536         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2537         has_break.
2538         * tui/tui-data.h (enum tui_bp_flag): New.
2539         (tui_bp_flags): New enum flags type.
2540         (struct tui_source_element) <break_mode>: Change type.  Rename
2541         from has_break.
2542         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2543         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2544         constants.
2545         * tui/tui-winsource.h: Fix comment.
2546
2547 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2548
2549         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2550         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2551         (store_fpregs_to_thread)
2552         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2553         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2554         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2555         (IWMMXT_REGS_SIZE): Add define.
2556         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2557         (fetch_vfp_regs, store_vfp_regs)
2558         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2559         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2560
2561 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2562
2563         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2564         defines.
2565         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2566         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2567         (ARM_INT_REGISTER_SIZE): ...to this.
2568         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2569         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2570         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2571         (arm_linux_collect_gregset, supply_nwfpe_register)
2572         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2573         defines.
2574         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2575         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2576         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2577         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2578         (arm_return_in_memory, arm_store_return_value)
2579         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2580         (arm_record_ld_st_multiple): Likewise.
2581         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2582         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2583
2584 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2587         AARCH64_DISPLACED_MODIFIED_INSNS.
2588         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2589         (aarch64_displaced_step_copy_insn): Likewise.
2590         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2591         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2592         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2593         ARM_DISPLACED_MODIFIED_INSNS.
2594         * arm-tdep.c (arm_gdbarch_init): Likewise.
2595         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2596         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2597         (struct arm_displaced_step_closure): Use
2598         ARM_DISPLACED_MODIFIED_INSNS.
2599
2600 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2601
2602         * features/Makefile: Remove unused xml files.
2603         * features/aarch64.xml: Remove.
2604         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2605         * features/i386/amd64-avx-avx512.xml: Remove.
2606         * features/i386/amd64-avx-linux.xml: Remove.
2607         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2608         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2609         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2610         * features/i386/amd64-avx-mpx.xml: Remove.
2611         * features/i386/amd64-avx.xml: Remove.
2612         * features/i386/amd64-linux.xml: Remove.
2613         * features/i386/amd64-mpx-linux.xml: Remove.
2614         * features/i386/amd64-mpx.xml: Remove.
2615         * features/i386/amd64.xml: Remove.
2616         * features/i386/i386-avx-avx512-linux.xml: Remove.
2617         * features/i386/i386-avx-avx512.xml: Remove.
2618         * features/i386/i386-avx-linux.xml: Remove.
2619         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2620         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2621         * features/i386/i386-avx-mpx-linux.xml: Remove.
2622         * features/i386/i386-avx-mpx.xml: Remove.
2623         * features/i386/i386-avx.xml: Remove.
2624         * features/i386/i386-linux.xml: Remove.
2625         * features/i386/i386-mmx-linux.xml: Remove.
2626         * features/i386/i386-mmx.xml: Remove.
2627         * features/i386/i386-mpx-linux.xml: Remove.
2628         * features/i386/i386-mpx.xml: Remove.
2629         * features/i386/i386.xml: Remove.
2630         * features/i386/x32-avx-avx512-linux.xml: Remove.
2631         * features/i386/x32-avx-linux.xml: Remove.
2632         * features/i386/x32-linux.xml: Remove.
2633
2634 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2635
2636         * regformats/aarch64.dat: Remove.
2637         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2638         * regformats/i386/amd64-avx-linux.dat: Remove.
2639         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2640         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2641         * regformats/i386/amd64-linux.dat: Remove.
2642         * regformats/i386/amd64-mpx-linux.dat: Remove.
2643         * regformats/i386/amd64.dat: Remove.
2644         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2645         * regformats/i386/i386-avx-linux.dat: Remove.
2646         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2647         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2648         * regformats/i386/i386-linux.dat: Remove.
2649         * regformats/i386/i386-mmx-linux.dat: Remove.
2650         * regformats/i386/i386-mpx-linux.dat: Remove.
2651         * regformats/i386/i386.dat: Remove.
2652         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2653         * regformats/i386/x32-avx-linux.dat: Remove.
2654         * regformats/i386/x32-linux.dat: Remove.
2655
2656 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * aarch64-tdep.c: Remove xml self tests.
2659         * amd64-linux-tdep.c: Likewise.
2660         * amd64-tdep.c: Likewise.
2661         * i386-linux-tdep.c: Likewise.
2662         * i386-tdep.c: Likewise.
2663
2664 2019-07-03  Pedro Alves  <palves@redhat.com>
2665
2666         PR cli/24732
2667         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2668         (pipe_cmd_option_defs): New.
2669         (make_pipe_cmd_options_def_group): New.
2670         (pipe_command): Use gdb::option::process_options.
2671         (pipe_command_completer): New function.
2672         (_initialize_cli_cmds): Install completer for "pipe" command.
2673
2674 2019-07-03  Pedro Alves  <palves@redhat.com>
2675
2676         * cli/cli-option.c (union option_value) <string>: New field.
2677         (struct option_def_and_value): Add ctor, move ctor, dtor and
2678         use DISABLE_COPY_AND_ASSIGN.
2679         (option_def_and_value::clear_value): New.
2680         (parse_option, save_option_value_in_ctx, get_val_type_str)
2681         (add_setshow_cmds_for_options): Handle var_string.
2682         * cli-option.h (union option_def::var_address) <string>: New
2683         field.
2684         (struct string_option_def): New.
2685         * maint-test-options.c (struct test_options_opts): Add default
2686         ctor and use DISABLE_COPY_AND_ASSIGN.
2687         <string_opt>: New field.
2688         (test_options_opts::~test_options_opts): New.
2689         (test_options_opts::dump): Also dump "-string".
2690         (test_options_option_defs): Install "string.
2691
2692 2019-07-03  Pedro Alves  <palves@redhat.com>
2693
2694         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2695         option_value with a null enumeration.
2696         (complete_options): Save the option values in the context.
2697         (save_option_value_in_ctx): New, factored out from ...
2698         (process_options): ... here.
2699         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2700         of the function.
2701         * maint-test-options.c (test_options_opts::dump): New, factored
2702         out from ...
2703         (maintenance_test_options_command_mode): ... here.
2704         (maintenance_test_options_command_completion_result): Delete.
2705         (maintenance_test_options_command_completion_text): Update
2706         comment.
2707         (maintenance_show_test_options_completion_result): Change
2708         prototype.  Just print
2709         maintenance_test_options_command_completion_text.
2710         (save_completion_result): New.
2711         (maintenance_test_options_completer_mode): Pass options context to
2712         complete_options, and then save a dump.
2713         (_initialize_maint_test_options): Use add_cmd to install "maint
2714         show test-options-completion-result".
2715
2716 2019-07-03  Pedro Alves  <palves@redhat.com>
2717
2718         * NEWS (New commands): Mention "with" and "maint with".
2719         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2720         (with_command, with_command_completer): New.
2721         (pipe_command): Adjust to new repeat_previous
2722         interface.
2723         (_initialize_cli_cmds): Install the "with" command and its "w"
2724         alias.
2725         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2726         declarations.
2727         * cli/cli-setshow.c (parse_cli_var_uinteger)
2728         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2729         argument strings for all var_types.
2730         (get_setshow_command_value_string): New, factored out from ...
2731         (do_show_command): ... this.
2732         * cli/cli-setshow.h: Include <string>.
2733         (get_setshow_command_value_string): Declare.
2734         * command.h (repeat_previous): Now returns const char *.  Adjust
2735         comment.
2736         * maint.c: Include "cli/cli-cmds.h".
2737         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2738         (_initialize_maint_cmds): Register the "maintenance with" command.
2739         * top.c (repeat_previous): Move bits from pipe_command here:
2740         Return the saved command line, if any; error out if there's no
2741         command to relaunch.
2742
2743 2019-07-03  Pedro Alves  <palves@redhat.com>
2744
2745         * NEWS (New commands): Mention "maint set/show test-settings"
2746         instead of "maint test-settings".
2747         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2748         (maintenance_test_settings_set_list): Rename to ...
2749         (maintenance_set_test_settings_list): ... this.
2750         (maintenance_test_settings_show_list): Rename to  ...
2751         (maintenance_show_test_settings_list): ... this.
2752         (maintenance_test_settings_cmd): Delete.
2753         (maintenance_test_settings_set_cmd): ...
2754         (maintenance_set_test_settings_cmd): ... this.
2755         (maintenance_test_settings_show_cmd): ...
2756         (maintenance_show_test_settings_cmd): ... this.
2757         (maintenance_test_settings_show_value_cmd):
2758         (maintenance_show_test_settings_value_cmd): ... this.
2759         (_initialize_maint_test_settings): No longer install the "maint
2760         test-settings" prefix command.  Rename "maint test-settings set"
2761         to "maint set test-settings", and "maint test-settings show" to
2762         "maint show test-settings".  Adjust all subcommands.
2763
2764 2019-07-03  Pedro Alves  <palves@redhat.com>
2765
2766         * maint-test-settings.c: Fix file's intro comment.  Replace all
2767         references to "test-options" with references to "test-settings",
2768         in comments.
2769
2770 2019-07-03  Pedro Alves  <palves@redhat.com>
2771
2772         * maint-test-settings.c (maintenance_test_settings_xxx)
2773         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2774         New.
2775         (maintenance_test_settings_enums): Use them.
2776         (maintenance_test_settings_enum): Default to
2777         maintenance_test_settings_xxx.
2778         (_initialize_maint_test_settings): Initialize
2779         MAINTENANCE_TEST_SETTINGS_FILENAME.
2780
2781 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2782
2783         * breakpoint.h (remove_breakpoints_inf): Change return type to
2784         void, move function documentation here.
2785         * breakpoint.c (remove_breakpoints_inf): Change return type to
2786         void, move function documentation to header.
2787
2788 2019-07-02  Pedro Alves  <palves@redhat.com>
2789
2790         * NEWS (Completion improvements): Mention "info threads".
2791         * thread.c (struct info_threads_opts, info_threads_option_defs)
2792         (make_info_threads_options_def_group): New.
2793         (info_threads_command): Use gdb::option::process_options.
2794         (info_threads_command_completer): New.
2795         (_initialize_thread): Use gdb::option::build_help to build the
2796         help text for "info threads".
2797
2798 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2799
2800         * defs.h (generic_load): Move from here...
2801         * symfile.h (generic_load): ... to here.  Rename name parameter
2802         to args.
2803         * symfile.c (generic_load): Add comment.
2804
2805 2019-07-01  Tom Tromey  <tromey@adacore.com>
2806
2807         * dwarf2read.c
2808         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2809         declaration of without_params.  Fix formatting.
2810
2811 2019-07-01  Tom Tromey  <tromey@adacore.com>
2812
2813         * ada-exp.y (find_primitive_type): Update.
2814         * ada-lang.h (ada_lookup_symbol): Update.
2815         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2816         parameter.
2817         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2818
2819 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2820
2821         PR breakpoints/24541
2822         * gdbarch.c: Regenerate.
2823         * gdbarch.h: Regenerate.
2824         * gdbarch.sh: Add 'stap_adjust_register'.
2825         * i386-tdep.c: Include '<unordered_set>'.
2826         (i386_stap_adjust_register): New function.
2827         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2828         * stap-probe.c (stap_parse_register_operand): Call
2829         'gdbarch_stap_adjust_register'.
2830
2831 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2832
2833         PR python/24742
2834         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2835         * python/python.c (do_start_initialization): Use 'xmalloc'
2836         instead of 'PyMem_Malloc'.
2837
2838 2019-06-28  Tom Tromey  <tromey@adacore.com>
2839
2840         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2841         for Ada.
2842
2843 2019-06-27  Tom Tromey  <tromey@adacore.com>
2844
2845         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2846         objfile_key.
2847         (arm_find_mapping_symbol, arm_record_special_symbol)
2848         (_initialize_arm_tdep): Update.
2849         (arm_objfile_data_free): Remove.
2850
2851 2019-06-27  Tom Tromey  <tromey@adacore.com>
2852
2853         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2854         to cp_print_static_field.
2855
2856 2019-06-26  Tom Tromey  <tromey@adacore.com>
2857
2858         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2859         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2860         declare.
2861
2862 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2863
2864         * features/aarch64-core.c (create_feature_aarch64_core):
2865         Regenerate.
2866         * features/aarch64-core.xml: Add cpsr flags.
2867
2868 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2869
2870         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2871         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2872
2873 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2874
2875         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2876         field.
2877         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2878         use.
2879         (arm_record_special_symbol): Don't insert new symbol in sorted
2880         position, push it at the end.
2881
2882 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2883
2884         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2885         (arm_mapping_symbol_s): Remove.
2886         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2887         (arm_mapping_symbol_vec): New typedef.
2888         (struct arm_per_objfile): Add constructor.
2889         <section_maps>: Change type to
2890         std::unique_ptr<arm_mapping_symbol_vec[]>.
2891         (arm_compare_mapping_symbols): Remove.
2892         (arm_find_mapping_symbol): Adjust to section_maps type change.
2893         (arm_objfile_data_free): Call delete on arm_per_objfile.
2894         (arm_record_special_symbol): Adjust to section_maps type change.
2895         Allocate arm_per_objfile with new.
2896
2897 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2898
2899         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2900         with the command prefix.
2901
2902 2019-06-25  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2905         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2906
2907 2019-06-25  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2910         type.
2911         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2912         protected.
2913
2914 2019-06-25  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-winsource.c
2917         (tui_source_window_base::set_is_exec_point_at): Add check against
2918         LOA_ADDRESS.
2919
2920 2019-06-25  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-source.c (tui_set_source_content): Don't check before
2923         xfree.
2924         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2925
2926 2019-06-25  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-winsource.h (tui_update_source_window_as_is)
2929         (tui_alloc_source_buffer, tui_line_is_displayed)
2930         (tui_addr_is_displayed): Change type of win_info.
2931         * tui/tui-winsource.c (tui_update_source_window_as_is)
2932         (tui_clear_source_content, tui_show_source_line)
2933         (tui_show_source_content, tui_source_window_base::refill)
2934         (tui_source_window_base::set_is_exec_point_at)
2935         (tui_source_window_base::set_is_exec_point_at)
2936         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2937         (tui_alloc_source_buffer, tui_line_is_displayed)
2938         (tui_addr_is_displayed): Change type of win_info.  Update.
2939         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2940         (tui_source_window_base::do_make_visible_with_new_height):
2941         Update.
2942         * tui/tui-source.c (tui_set_source_content)
2943         (tui_set_source_content_nil)
2944         (tui_source_window::do_scroll_vertical): Update.
2945         * tui/tui-layout.c (show_layout): Update.
2946         * tui/tui-disasm.c (tui_set_disassem_content)
2947         (tui_disasm_window::do_scroll_vertical): Update.
2948         * tui/tui-data.h (tui_win_content): Remove.
2949         (struct tui_gen_win_info) <content, content_size>: Remove.
2950         (struct tui_source_element): Add initializers and destructor.
2951         (union tui_which_element, struct tui_win_element): Remove.
2952         (struct tui_source_window_base) <content>: New field.
2953         (struct tui_data_window): Remove destructor.
2954         (tui_alloc_content, tui_free_win_content)
2955         (tui_free_all_source_wins_content): Don't declare.
2956         * tui/tui-data.c (tui_initialize_static_data): Update.
2957         (init_content_element, tui_alloc_content): Remove.
2958         (~tui_gen_win_info): Update.
2959         (~tui_data_window, tui_free_all_source_wins_content)
2960         (tui_free_win_content, free_content, free_content_elements):
2961         Remove.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.h (tui_clear_source_content)
2966         (tui_erase_source_content, tui_show_source_content): Change type
2967         of win_info.
2968         * tui/tui-winsource.c (tui_clear_source_content)
2969         (tui_erase_source_content, tui_show_source_content): Change type
2970         of win_info.
2971         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2972         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2973         win_info.
2974         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2975         win_info.
2976         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2977
2978 2019-06-25  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-winsource.c (tui_clear_source_content)
2981         (tui_source_window_base::set_is_exec_point_at): Update.
2982         * tui/tui-source.c (tui_set_source_content_nil): Update.
2983         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2984         a bool.
2985         * tui/tui-data.c (init_content_element): Update.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2990         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2991         * tui/tui-layout.c (init_and_make_win): Update.
2992         * tui/tui.h (enum tui_win_type): Update.
2993         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2994         tui_win_is_auxillary.
2995         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2996         tui_win_is_auxillary.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3001         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3002         (tui_delete_data_content_windows, tui_display_all_data)
3003         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3004         Update.
3005         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3006         * tui/tui-regs.c (tui_last_regs_line_no)
3007         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3008         (tui_show_registers): Update.
3009         (tui_show_register_group): Return void.  Update.
3010         (tui_display_registers_from, tui_display_reg_element_at_line)
3011         (tui_display_registers_from_line, tui_check_register_values):
3012         Update.
3013         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3014         member.
3015         (struct tui_data_window) <regs_content>: Now a std::vector.
3016         <regs_content_count>: Remove.
3017         (tui_add_content_elements, tui_free_data_content): Don't declare.
3018         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3019         (init_content_element): Remove DATA_WIN case.  Add assert.
3020         (tui_add_content_elements): Remove.
3021         (tui_data_window): Update.
3022         (tui_free_data_content): Remove.
3023         (free_content_elements): Remove DATA_WIN case.
3024
3025 2019-06-25  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-data.c (tui_data_item_window): Update.
3028         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3029         * tui/tui-windata.c (tui_display_all_data)
3030         (tui_display_data_from_line): Update.
3031         (tui_check_data_values): Remove.
3032         * tui/tui-regs.c (tui_show_register_group)
3033         (tui_display_reg_element_at_line): Update.
3034         * tui/tui-hooks.c (tui_register_changed)
3035         (tui_refresh_frame_and_register_information): Call
3036         tui_check_register_values.
3037         * tui/tui-data.h (struct tui_data_window) <data_content,
3038         data_content_count, data_type>: Remove.
3039         (enum tui_data_type): Remove.
3040
3041         * tui/tui-data.c (tui_data_window::clear_detail)
3042         (~tui_data_window): Update.
3043
3044 2019-06-25  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3047         declare.
3048         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3049         Rename from tui_first_data_item_displayed.  Update.
3050         (tui_data_window::refresh_all)
3051         (tui_data_window::do_scroll_vertical): Update.
3052         * tui/tui-data.h (struct tui_data_window)
3053         <first_data_item_displayed>: Declare new method.
3054
3055 2019-06-25  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3058         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3059         contents...
3060         (tui_initialize_static_data): ...here.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3065         (tui_display_registers_from, tui_check_register_values): Update.
3066         (tui_display_register): Remove win_info parameter; update.
3067         (tui_get_register): Change type of parameters.
3068         * tui/tui-data.h (struct tui_data_element): Remove.
3069         (union tui_which_element) <data>: Remove.
3070         <data_window>: Change type.
3071         (struct tui_data_item_window): New.
3072         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3073         case.  Add assert.
3074         (~tui_data_item_window): New destructor.
3075         (free_content_elements): Remove DATA_ITEM_WIN case.
3076
3077 2019-06-25  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3080         Remove.
3081
3082 2019-06-25  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-data.h (struct tui_command_element): Remove.
3085         (union tui_which_element) <command>: Remove.
3086         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3087         assert.
3088         (free_content_elements): Remove CMD_WIN case.
3089
3090 2019-06-25  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-layout.c (tui_set_layout): Update.
3093         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3094         * tui/tui-data.c (layout_def): Update.
3095
3096 2019-06-25  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3099         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3100         (tui_source_window_base::set_new_height): Update.
3101         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3102         Update.
3103         (tui_set_locator_fullname, tui_set_locator_info)
3104         (tui_show_frame_info): Update.
3105         * tui/tui-source.c (tui_set_source_content)
3106         (tui_source_is_displayed): Update.
3107         * tui/tui-layout.c (show_source_disasm_command, show_data)
3108         (show_source_or_disasm_and_command): Update.
3109         * tui/tui-disasm.c (tui_set_disassem_content)
3110         (tui_get_begin_asm_address): Update.
3111         * tui/tui-data.h (struct tui_locator_element): Remove.
3112         (union tui_which_element) <locator>: Remove.
3113         (struct tui_locator_window): New.
3114         (tui_locator_win_info_ptr): Change return type.
3115         * tui/tui-data.c (_locator): Change type.
3116         (tui_locator_win_info_ptr): Change return type.
3117         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3118         (tui_alloc_content): Add assert.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-winsource.c
3123         (tui_exec_info_window::maybe_allocate_content): New method.
3124         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3125         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3126         (make_source_or_disasm_window): Add cast.
3127         * tui/tui-data.h (union tui_which_element) <simple_string>:
3128         Remove.
3129         (struct tui_source_info): New.
3130         (struct tui_source_window_base) <execution_info>: Change type.
3131         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3132         case, and add assert.
3133         (tui_alloc_content): Add assert.
3134
3135 2019-06-25  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3138         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3139         * tui/tui-data.c (tui_alloc_win_info): Remove.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3144         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3145         can_highlight.
3146
3147 2019-06-25  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3150         make_visible_with_new_height method.
3151         (tui_win_info::make_visible_with_new_height): New method.
3152         (tui_source_window_base::do_make_visible_with_new_height)
3153         (tui_data_window::do_make_visible_with_new_height)
3154         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3155         (make_visible_with_new_height): Remove.
3156         (tui_resize_all, tui_adjust_win_heights): Use
3157         make_visible_with_new_height method.
3158         * tui/tui-data.h (struct tui_win_info)
3159         <do_make_visible_with_new_height, make_visible_with_new_height>:
3160         New methods.
3161         (struct tui_source_window_base, struct tui_data_window)
3162         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3163         methods.
3164
3165 2019-06-25  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3168         method.
3169         (update_tab_width): Call update_tab_width method.
3170         * tui/tui-data.h (struct tui_win_info)
3171         (struct tui_source_window_base) <update_tab_width>: New methods.
3172
3173 2019-06-25  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3176         parameter.
3177         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3178         parameter.
3179         (tui_gen_win_info::make_visible): Update.
3180         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3181         parameter.
3182         * tui/tui-data.h (enum tui_box): New enum.
3183         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3188         init_and_make_win for EXEC_INFO_WIN.
3189         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3190         longer inline.
3191         (struct tui_win_info) <~tui_win_info>: Inline.
3192         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3193         Don't declare.
3194         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3195         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3196         Remove.
3197         (tui_initialize_static_data): Update.
3198         (~tui_gen_win_info): Handle more cleanup here.
3199         (~tui_source_window_base): Delete "execution_info".
3200         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3201
3202 2019-06-25  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-layout.c (make_command_window): Don't set
3205         can_highlight.
3206         (show_source_disasm_command): Call the reset method.
3207         (show_data): Don't set can_highlight.  Call the reset method.
3208         (tui_gen_win_info::reset): Rename from init_gen_win_info
3209         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3210         (show_source_or_disasm_and_command): Call the reset method.
3211         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3212         (struct tui_cmd_window): Set can_highlight.
3213
3214 2019-06-25  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3217         from make_visible.
3218         (tui_make_visible, tui_make_invisible): Rewrite.
3219         (tui_win_info::make_visible): Remove.
3220         (tui_source_window_base::make_visible): Update.
3221         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3222         method.  Moved from...
3223         (struct tui_win_info) <make_visible>: ...here.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-winsource.c
3228         (tui_source_window_base::do_scroll_horizontal): Remove direction
3229         parameter.
3230         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3231         direction parameter.
3232         * tui/tui-win.c (tui_win_info::forward_scroll)
3233         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3234         (tui_win_info::right_scroll): Update.
3235         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3236         direction parameter.
3237         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3238         direction parameter.
3239         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3240         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3241         Remove direction parameter.
3242         (struct tui_source_window_base, struct tui_source_window)
3243         (struct tui_disasm_window, struct tui_data_window)
3244         (struct tui_cmd_window): Update.
3245
3246 2019-06-25  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-winsource.h (tui_set_exec_info_content)
3249         (tui_show_exec_info_content, tui_erase_exec_info_content)
3250         (tui_clear_exec_info_content, tui_update_exec_info): Change
3251         argument to tui_source_window_base.
3252         * tui/tui-winsource.c (tui_set_exec_info_content)
3253         (tui_show_exec_info_content, tui_erase_exec_info_content)
3254         (tui_clear_exec_info_content, tui_update_exec_info): Change
3255         argument to tui_source_window_base.
3256
3257 2019-06-25  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3260         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3261
3262 2019-06-25  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3265         check.
3266
3267 2019-06-25  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3270         type to void.
3271         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3272         type to void.
3273         * tui/tui-source.c (tui_set_source_content): Update.
3274         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3275
3276 2019-06-25  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-win.c (window_name_completer, tui_set_focus)
3279         (tui_all_windows_info): Use name method.
3280         * tui/tui-data.h (struct tui_gen_win_info)
3281         (struct tui_source_window, struct tui_disasm_window)
3282         (struct tui_data_window, struct tui_cmd_window) <name>: New
3283         method.
3284         (tui_win_name): Don't declare.
3285         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3286         (tui_win_name): Remove.
3287
3288 2019-06-25  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-winsource.h (tui_update_source_window)
3291         (tui_update_source_window_as_is): Change parameter type.
3292         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3293         to be a tui_source_window_base.
3294         (tui_update_source_window_as_is): Likewise.
3295         * tui/tui-win.c (make_visible_with_new_height): Update.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-winsource.c (tui_erase_source_content)
3300         (tui_show_source_content, tui_show_exec_info_content)
3301         (tui_erase_exec_info_content): Use refresh_window method.
3302         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3303         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3304         from tui_refresh_win.
3305         (tui_data_window::refresh_window): New method.
3306         (tui_win_info::refresh, tui_source_window_base::refresh)
3307         (tui_refresh_all): Use refresh_window method.
3308         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3309         method.
3310         * tui/tui-regs.c (tui_display_register): Call refresh_window
3311         method.
3312         * tui/tui-layout.c (show_source_disasm_command)
3313         (show_source_or_disasm_and_command): Call refresh_window method.
3314         * tui/tui-data.h (struct tui_gen_win_info)
3315         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3316         New method.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui.c (tui_rl_other_window, tui_enable)
3321         (tui_is_window_visible, tui_get_command_dimension): Update.
3322         * tui/tui-winsource.c (tui_update_source_window_as_is)
3323         (tui_clear_source_content, tui_erase_source_content)
3324         (tui_show_source_line, tui_source_window_base::refill)
3325         (tui_source_window_base::do_scroll_horizontal)
3326         (tui_source_window_base::set_is_exec_point_at)
3327         (tui_update_breakpoint_info, tui_set_exec_info_content)
3328         (tui_alloc_source_buffer, tui_line_is_displayed)
3329         (tui_addr_is_displayed): Update.
3330         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3331         (tui_check_and_display_highlight_if_needed)
3332         (tui_win_info::make_visible, tui_win_info::refresh)
3333         (tui_refresh_all): Update.
3334         * tui/tui-windata.c (tui_first_data_item_displayed)
3335         (tui_delete_data_content_windows, tui_erase_data_content)
3336         (tui_display_all_data, tui_data_window::refresh_all)
3337         (tui_check_data_values): Update.
3338         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3339         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3340         (tui_win_info::backward_scroll, tui_refresh_all_win)
3341         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3342         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3343         (tui_source_window_base::set_new_height)
3344         (tui_data_window::set_new_height)
3345         (make_invisible_and_set_new_height)
3346         (make_visible_with_new_height, new_height_ok)
3347         (parse_scrolling_args): Update.
3348         * tui/tui-stack.c (tui_show_frame_info): Update.
3349         * tui/tui-source.c (tui_set_source_content)
3350         (tui_set_source_content_nil, tui_source_is_displayed)
3351         (tui_source_window::do_scroll_vertical): Update.
3352         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3353         (tui_display_registers_from, tui_display_reg_element_at_line)
3354         (tui_check_register_values, tui_reg_command): Update.
3355         * tui/tui-layout.c (tui_default_win_height)
3356         (show_source_disasm_command, show_data, init_and_make_win)
3357         (show_source_or_disasm_and_command): Update.
3358         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3359         (tui_redisplay_readline, tui_mld_flush)
3360         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3361         (tui_getc): Update.
3362         * tui/tui-disasm.c (tui_set_disassem_content)
3363         (tui_disasm_window::do_scroll_vertical): Update.
3364         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3365         Now virtual.
3366         (struct tui_win_info): Derive from tui_gen_win_info.
3367         <~tui_win_info>: Mark as override.
3368         <generic>: Remove member.
3369         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3370         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3371         (~tui_data_window, ~tui_win_info)
3372         (tui_free_all_source_wins_content): Update.
3373         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-layout.c (init_and_make_win): Use new.
3378         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3379         destructor, initializers.
3380         (tui_alloc_generic_win_info): Don't declare.
3381         * tui/tui-data.c (_locator): Add argument to constructor.
3382         (source_win, disasm_win): New globals.
3383         (exec_info): Remove.
3384         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3385         Update.
3386         (tui_alloc_generic_win_info): Remove.
3387         (init_content_element): Use new.
3388         (tui_win_info::tui_win_info): Update.
3389         (free_content_elements) <case DATA_WIN>: Use delete.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3394         * tui/tui-windata.c (tui_first_data_item_displayed)
3395         (tui_delete_data_content_windows): Update.
3396         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3397         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3398         (tui_display_registers_from, tui_check_register_values): Update.
3399         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3400         pointer.
3401         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3402         window.
3403         (tui_free_data_content): Update.
3404         (free_content_elements) <case DATA_WIN>: Free the window.
3405
3406 2019-06-25  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3409         Update.
3410         * tui/tui-layout.c (make_command_window)
3411         (show_source_disasm_command, show_data, init_and_make_win)
3412         (show_source_or_disasm_and_command): Update.
3413         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3414         method.
3415         <can_highight, is_highlighted>: Now bool.
3416         (tui_set_win_highlight): Don't declare.
3417         * tui/tui-data.c (tui_set_win_highlight): Remove.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-wingeneral.c (make_visible): Remove check of window
3422         type.
3423
3424 2019-06-25  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-win.c (tui_win_info::max_height)
3427         (tui_cmd_window::max_height): New methods.
3428         (new_height_ok): Call max_height.
3429         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3430         <max_height>: New method.
3431
3432 2019-06-25  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-win.c (tui_source_window_base::set_new_height)
3435         (tui_data_window::set_new_height): New methods.
3436         (make_invisible_and_set_new_height): Call set_new_height method.
3437         * tui/tui-data.h (struct tui_win_info)
3438         (struct tui_source_window_base, struct tui_data_window)
3439         <set_new_height>: New method.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3444         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3445         tui_refresh_data_win.
3446         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3447         method.
3448         (tui_refresh_all_win): Call the refresh_all method.
3449         (tui_set_focus): Likewise.
3450         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3451         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3452         Likewise.
3453
3454 2019-06-25  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-winsource.h (tui_refill_source_window)
3457         (tui_set_is_exec_point_at): Don't declare.
3458         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3459         (tui_source_window_base::refill): Rename from
3460         tui_refill_source_window.
3461         (tui_source_window_base::do_scroll_horizontal): Update.
3462         (tui_source_window_base::set_is_exec_point_at): Rename from
3463         tui_set_is_exec_point_at.
3464         (tui_update_all_breakpoint_info): Update.
3465         * tui/tui-stack.c (tui_show_frame_info): Update.
3466         * tui/tui-layout.c (show_data): Add cast.
3467         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3468         * tui/tui-data.h (struct tui_source_window_base) <refill,
3469         set_is_exec_point_at>: New methods.
3470         (tui_source_windows, tui_add_to_source_windows): Update types.
3471         (tui_add_to_source_windows): Remove redundant declaration.
3472         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3473         (tui_source_windows): Change return type.
3474         (tui_clear_source_windows_detail): Update.
3475         (tui_add_to_source_windows): Change type of parameter.
3476         (tui_free_all_source_wins_content): Update.
3477
3478 2019-06-25  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-wingeneral.c (tui_win_info::refresh)
3481         (tui_source_window_base::refresh): New methods.
3482         (tui_refresh_all): Call the refresh method.
3483         * tui/tui-data.h (struct tui_win_info)
3484         (struct tui_source_window_base) <refresh>: New method.
3485
3486 2019-06-25  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui.h (tui_is_window_visible): Return bool.
3489         * tui/tui.c (tui_is_window_visible): Return bool.
3490         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3491         (tui_make_visible, tui_make_invisible)
3492         (tui_win_info::make_visible)
3493         (tui_source_window_base::make_visible, make_all_visible)
3494         (tui_make_all_visible, tui_make_all_invisible): Update.
3495         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3496         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3497         bool.
3498         (struct tui_win_info, struct tui_source_window_base)
3499         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3500         * tui/tui-data.c (tui_init_generic_part): Update.
3501
3502 2019-06-25  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3505         (tui_source_window_base::make_visible): New methods.
3506         (make_all_visible): Make method call.
3507         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3508         (struct tui_source_window_base, struct tui_cmd_window): Override
3509         make_visible.
3510         (tui_win_is_source_type): Don't declare.
3511         * tui/tui-data.c (tui_win_is_source_type): Remove.
3512
3513 2019-06-25  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3516         NULL check.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3521         Inline constructor.  Add initializers for members.
3522         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3523         constructors; now inline in class.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-regs.c (tui_show_registers): Update.
3528         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3529         bool.
3530         * tui/tui-data.c (tui_data_window::clear_detail)
3531         (tui_data_window): Update.
3532
3533 2019-06-25  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-windata.c (tui_display_all_data)
3536         (tui_display_data_from_line, tui_display_data_from)
3537         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3538         Update.
3539         * tui/tui-regs.c (tui_last_regs_line_no)
3540         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3541         (tui_show_registers, tui_show_register_group)
3542         (tui_display_registers_from, tui_display_reg_element_at_line)
3543         (tui_display_registers_from_line, tui_check_register_values)
3544         (tui_reg_next, tui_reg_prev): Update.
3545         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3546         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3547         tui_data_window.
3548         (struct tui_win_info) <detail>: Remove.  Add new fields from
3549         tui_data_info.
3550         (TUI_DATA_WIN): Add cast.
3551         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3552         (~tui_data_window): Simplify.
3553
3554 2019-06-25  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-layout.c (show_source_disasm_command)
3557         (show_source_or_disasm_and_command): Update.
3558         * tui/tui-io.c (update_cmdwin_start_line)
3559         (tui_redisplay_readline): Update.
3560         * tui/tui-data.h (struct tui_command_info): Remove.
3561         (struct tui_win_info) <detail>: Remove command_info member.
3562         (struct tui_data_window) <start_line>: New member, from
3563         tui_command_info.
3564         (TUI_CMD_WIN): Add casts.
3565
3566 2019-06-25  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-winsource.c (tui_update_source_window)
3569         (tui_refill_source_window)
3570         (tui_source_window_base::do_scroll_horizontal)
3571         (tui_update_breakpoint_info, tui_set_exec_info_content)
3572         (tui_show_exec_info_content, tui_erase_exec_info_content)
3573         (tui_clear_exec_info_content): Update.
3574         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3575         Update.
3576         * tui/tui-win.c (make_invisible_and_set_new_height)
3577         (make_visible_with_new_height): Update.
3578         * tui/tui-source.c (tui_set_source_content)
3579         (tui_show_symtab_source): Update.
3580         * tui/tui-layout.c (extract_display_start_addr)
3581         (show_source_disasm_command, show_data)
3582         (make_source_or_disasm_window)
3583         (show_source_or_disasm_and_command): Update.
3584         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3585         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3586         "gdbarch".
3587         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3588         to tui_source_window_base.
3589         (struct tui_win_info) <detail>: Remove source_info member.
3590         (struct tui_source_window_base) <has_locator>: Inline.
3591         Move contents from tui_source_info; rename has_locator member to
3592         m_has_locator.
3593         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3594         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3595         header file.
3596         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3597         Simplify.
3598         (tui_free_all_source_wins_content): Cast to
3599         tui_source_window_base.
3600
3601 2019-06-25  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-win.c (make_invisible_and_set_new_height)
3604         (make_visible_with_new_height): Call has_locator method.
3605         * tui/tui-layout.c (show_source_disasm_command, show_data)
3606         (show_source_or_disasm_and_command): Update for bool change.
3607         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3608         (tui_win_info) <has_locator>: New method.
3609         (struct tui_source_window_base) <has_locator>: New method.
3610         (tui_win_has_locator): Don't declare.
3611         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3612         from tui_win_has_locator.
3613         (tui_source_window_base): Use false, not FALSE.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3618         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3619         clear_detail method directly.
3620         (tui_clear_win_detail): Remove.
3621
3622 2019-06-25  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3625         "this", not TUI_DISASM_WIN.
3626
3627 2019-06-25  Tom Tromey  <tom@tromey.com>
3628
3629         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3630         declare.
3631         * tui/tui-winsource.c
3632         (tui_source_window_base::do_scroll_horizontal): Rename from
3633         tui_horizontal_source_scroll.
3634         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3635         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3636         from tui_vertical_data_scroll.
3637         * tui/tui-win.h (tui_scroll): Don't declare.
3638         * tui/tui-win.c (tui_win_info::forward_scroll)
3639         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3640         (tui_win_info::right_scroll): Rename and update.
3641         (tui_scroll_forward_command, tui_scroll_backward_command)
3642         (tui_scroll_left_command, tui_scroll_right_command): Update.
3643         (tui_scroll): Remove.
3644         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3645         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3646         from tui_vertical_source_scroll.
3647         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3648         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3649         from tui_vertical_disassem_scroll.
3650         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3651         do_scroll_horizontal>: New methods.
3652         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3653         Likewise.
3654         (struct tui_source_window_base): Add do_scroll_horizontal.
3655         (struct tui_source_window, struct tui_disasm_window): Add
3656         do_scroll_vertical.
3657         (struct tui_data_window, struct tui_cmd_window): Add
3658         do_scroll_horizontal and do_scroll_vertical.
3659         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-data.h (struct tui_source_window_base): New struct.
3664         (struct tui_source_window): Derive from tui_source_window_base.
3665         (struct tui_disasm_window): New struct.
3666         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3667         from tui_source_window::clear_detail.
3668         (tui_source_window_base): Rename from tui_source_window.
3669         (~tui_source_window_base): Rename from ~tui_source_window.
3670         (tui_alloc_win_info): Create a tui_disasm_window.
3671
3672 2019-06-25  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-data.h (struct tui_source_window)
3675         (struct tui_data_window): Declare destructors.
3676         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3677         destructors.
3678         (tui_win_info): Simplify.
3679
3680 2019-06-25  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-winsource.c (tui_display_main)
3683         (tui_update_source_windows_with_addr)
3684         (tui_update_all_breakpoint_info): Update.
3685         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3686         (new_height_ok, parse_scrolling_args): Update.
3687         * tui/tui-stack.c (tui_show_frame_info): Update.
3688         * tui/tui-data.h (struct tui_list): Remove.
3689         (tui_source_windows): Return a reference to a std::vector.
3690         * tui/tui-data.c (source_windows): Now a std::vector.
3691         (tui_source_windows): Change return type.
3692         (tui_clear_source_windows): Rewrite.
3693         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3694         (tui_free_all_source_wins_content): Rewrite.
3695
3696 2019-06-25  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3699         (struct tui_data_window, struct tui_cmd_window): Declare
3700         clear_detail method.
3701         * tui/tui-data.c (tui_source_window::clear_detail)
3702         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3703         methods.
3704         (tui_clear_win_detail): Simplify.
3705
3706 2019-06-25  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-layout.c (make_source_window, make_disasm_window)
3709         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3710         Return the new window.
3711         (show_source_disasm_command, show_data)
3712         (show_source_or_disasm_and_command): Update.
3713
3714 2019-06-25  Tom Tromey  <tom@tromey.com>
3715
3716         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3717         parameter.  Return the new window.
3718         (show_source_disasm_command): Update and remove NULL check.
3719         (show_source_or_disasm_and_command): Update.
3720
3721 2019-06-25  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3724
3725 2019-06-25  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-data.h (struct tui_win_info): Make constructor
3728         protected.  Make destructor virtual.  Add initializers.
3729         (tui_source_window, tui_data_window, tui_cmd_window): New
3730         classes.
3731         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3732         constructor.  Add "type" parameter.
3733         (tui_source_window, tui_data_window, tui_cmd_window): New
3734         constructors.
3735         (tui_alloc_win_info): Instantiate the appropriate subclass.
3736
3737 2019-06-25  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-win.c (tui_resize_all): Use delete.
3740         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3741         destructor.
3742         (tui_free_window): Don't declare.
3743         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3744         Update.
3745
3746 2019-06-25  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-data.h (struct tui_win_info): Add constructor.
3749         * tui/tui-data.c (tui_alloc_win_info): Use new.
3750         (tui_free_window): Use delete.
3751
3752 2019-06-22  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3755         declare.
3756         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3757
3758 2019-06-22  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3761         declare.
3762         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3763
3764 2019-06-22  Tom de Vries  <tdevries@suse.de>
3765
3766         * dwarf2read.c (create_addrmap_from_aranges)
3767         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3768         instead of '%zu'.
3769
3770 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3771
3772         * dwarf2read.h (dwarf2_section_info_def): Remove.
3773         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3774         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3775         std::vector<dwarf2_section_info>.
3776         (struct dwo_file) <~dwo_file>: Remove.
3777         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3778         types field.
3779         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3780         (dwarf2_read_debug_names): Likewise.
3781         (create_debug_types_hash_table): Change parameter type to
3782         array_view, adjust code accordingly.
3783         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3784         (partial_die_info::fixup): Likewise.
3785         (determine_prefix): Likewise.
3786         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3787
3788 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3789
3790         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3791         gdb_bfd_ref_ptr.
3792         <~dwo_file>: Remove call to gdb_bfd_unref.
3793         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3794         gdb_bfd_ref_ptr::get.
3795
3796 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3797
3798         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3799         type to htab_up.
3800         * dwarf2read.c (struct dwo_file): Initialize fields.
3801         <~dwo_file>: New.
3802         (free_dwo_file): Remove, move content to ~dwo_file.
3803         (struct dwo_file_deleter): Remove.
3804         (dwo_file_up>: Remove custom deleter.
3805         (free_dwo_files): Remove.
3806         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3807         dwo_files.
3808         (process_skeletonless_type_units): Call unique_ptr::get.
3809         (allocate_dwo_file_hash_table): Add deleter to created hash
3810         table.  Change return type to htab_up.
3811         (lookup_dwo_file_slot): Don't memset dwo_file, call
3812         unique_ptr::get.
3813         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3814         (create_dwo_unit_in_dwp_v2): Likewise.
3815         (open_and_init_dwo_file): Likewise.
3816         (free_dwo_file_from_slot): Remove.
3817
3818 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3819
3820         * dwarf2read.h (struct dwarf2_section_info) <readin,
3821         is_virtual>: Change type to bool.
3822         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3823         true instead of 1.
3824
3825 2019-06-19  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-data.h (tui_init_content_element): Don't declare.
3828
3829 2019-06-19  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-data.h (tui_init_win_info): Don't declare.
3832
3833 2019-06-19  Tom de Vries  <tdevries@suse.de>
3834
3835         * dwarf2read.h (abstract_to_concrete): Change type to
3836         std::unordered_map<sect_offset, std::vector<sect_offset>,
3837         gdb::hash_enum<sect_offset>>.
3838
3839 2019-06-19  Tom Tromey  <tromey@adacore.com>
3840
3841         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3842         EVAL_AVOID_SIDE_EFFECTS specially.
3843
3844 2019-06-19  Tom Tromey  <tromey@adacore.com>
3845
3846         * source-cache.c (highlighter): New global.
3847         (source_cache::get_source_lines): Create a highlighter on demand.
3848
3849 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * defs.h (deprecated_interactive_hook): Delete declaration.
3852         * interps.c (clear_interpreter_hooks): Remove use of
3853         deprecated_interactive_hook.
3854         * top.c (deprecated_interactive_hook): Delete definition.
3855         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3856
3857 2019-06-18  Tom de Vries  <tdevries@suse.de>
3858
3859         PR gdb/24515
3860         * dwarf2read.h (abstract_to_concrete): Change type from
3861         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3862         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3863         * dwarf2read.c (read_variable): Update.
3864         (dwarf2_fetch_die_loc_sect_off): Update.
3865
3866 2019-06-17  Tom de Vries  <tdevries@suse.de>
3867
3868         PR gdb/24617
3869         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3870         accessing parent[parent_len - 1].
3871
3872 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3873
3874         PR gdb/24364
3875         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3876         call dtrace_process_dof with NULL dof.
3877
3878 2019-06-16  Tom de Vries  <tdevries@suse.de>
3879
3880         PR gdb/24445
3881         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3882
3883 2019-06-16  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3886         (make_all_visible): Use address of member.
3887
3888 2019-06-16  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3891         (tui_free_window, free_content, free_content_elements): Remove
3892         unnecessary cast.
3893         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3894         cast.
3895         * tui/tui-regs.c (tui_show_register_group)
3896         (tui_display_registers_from, tui_display_reg_element_at_line):
3897         Remove unnecessary cast.
3898
3899 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * linux-nat.c (normal_mask): Delete.
3902         (_initialize_linux_nat): Don't initialise normal_mask.
3903
3904 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3905
3906         PR gdb/24445
3907         * dwarf-index-write.h (write_psymtabs_to_index): Add
3908         dwz_basename parameter.
3909         * dwarf-index-write.c (write_gdbindex): Move file writing to
3910         write_gdbindex_1.  Change return type void.
3911         (assert_file_size): Move up, remove filename parameter.
3912         (write_gdbindex_1): New function.
3913         (write_debug_names): Change return type to void, call
3914         assert_file_size.
3915         (struct index_wip_file): New struct.
3916         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3917         file logic to index_wip_file.  Write index for dwz file if
3918         needed.
3919         (save_gdb_index_command): Pass basename of dwz file, if present.
3920         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3921         build-id of dwz file, if present.
3922         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3923         (dwarf2_get_dwz_file): Likewise.
3924         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3925         (dwarf2_get_dwz_file): Likewise.
3926
3927 2019-06-16  Tom Tromey  <tom@tromey.com>
3928
3929         * coffread.c (process_coff_symbol): Use xstrdup.
3930         * value.c (create_internalvar): Use xstrdup.
3931
3932 2019-06-16  Tom Tromey  <tom@tromey.com>
3933
3934         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3935         * breakpoint.c (stopin_command, stopat_command)
3936         (until_break_command, decode_location_default): Remove unnecessary
3937         cast.
3938         * utils.c (subset_compare): Remove unnecessary cast.
3939         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3940         cast.
3941         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3942         cast.
3943         * infcmd.c (path_command): Remove unnecessary cast.
3944         * coffread.c (decode_type): Remove unnecessary cast.
3945         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3946         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3947         * tui/tui-stack.c (tui_show_locator_content)
3948         (tui_show_frame_info): Remove unnecessary cast.
3949         * tui/tui-win.c (tui_scroll_forward_command)
3950         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3951         (parse_scrolling_args): Remove unnecessary cast.
3952         * tui/tui-data.c (init_win_info, tui_del_window)
3953         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3954         (free_content_elements): Remove unnecessary cast.
3955         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3956         unnecessary cast.
3957         * tui/tui-source.c (tui_set_source_content)
3958         (tui_vertical_source_scroll): Remove unnecessary cast.
3959         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3960         cast.
3961         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3962         * tui/tui-regs.c (tui_display_registers_from)
3963         (tui_display_register): Remove unnecessary cast.
3964         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3965         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3966         (make_visible): Remove unnecessary cast.
3967         * tui/tui-winsource.c (tui_erase_source_content)
3968         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3969         unnecessary cast.
3970         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3971         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3972         * stabsread.c (read_type, read_array_type, read_range_type):
3973         Remove unnecessary cast.
3974         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3975         (parse_symbol, parse_type, upgrade_type, parse_external)
3976         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3977         unnecessary cast.
3978         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3979
3980 2019-06-16  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-data.c (tui_alloc_generic_win_info)
3983         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3984         checks.
3985
3986 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3987             Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * f-typeprint.c (f_print_type): Don't return early for not
3990         associated or not allocated types.
3991         (f_type_print_varspec_suffix): Add print_rank parameter and print
3992         ranks of array types in case they dangling.
3993         (f_type_print_base): Add print_rank parameter.
3994
3995 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * NEWS: Mention new MI commands.
3998         * break-catch-throw.c (enum exception_event_kind): Move to
3999         breakpoint.h.
4000         (print_mention_exception_catchpoint): Output text as a single
4001         message.
4002         (catch_exception_command_1): Rename to...
4003         (catch_exception_event): ...this, make non-static, update header
4004         command, and change some parameter types.
4005         (catch_catch_command): Update for changes to
4006         catch_exception_command_1.
4007         (catch_throw_command): Likewise.
4008         (catch_rethrow_command): Likewise.
4009         * breakpoint.c (enum exception_event_kind): Delete.
4010         * breakpoint.h (enum exception_event_kind): Moved here from
4011         break-catch-throw.c.
4012         (catch_exception_event): Declare.
4013         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4014         (mi_cmd_catch_throw): New function.
4015         (mi_cmd_catch_rethrow): New function.
4016         (mi_cmd_catch_catch): New function.
4017         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4018         'catch-catch' entries.
4019         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4020         (mi_cmd_catch_rethrow): Declare.
4021         (mi_cmd_catch_catch): Declare.
4022
4023 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         * annotate.c (annotate_source_line): Change return type to void,
4026         update implementation to match.
4027         * annotate.h (annotate_source_line): Change return type to void,
4028         update header comment.
4029         * stack.c (print_frame_info): Don't change what frame information
4030         is printed based on whether annotations are on or not.
4031
4032 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4035         (annotate_source): Make static.
4036         (annotate_source_line): Moved from source.c and renamed from
4037         identify_source_line.  Update the return type.
4038         * annotate.h (annotate_source): Delete declaration.
4039         (annotate_source_line): Declaration moved from source.h, and
4040         renamed from identify_source_line.  Return type updated.
4041         * source.c (identify_source_line): Moved to annotate.c and renamed
4042         to annotate_source_line.
4043         (info_line_command): Remove check of annotation_level.
4044         * source.h (identify_source_line): Move declaration to annotate.h
4045         and rename to annotate_source_line.
4046         * stack.c: Add 'annotate.h' include.
4047         (print_frame_info): Remove check of annotation_level before
4048         calling annotate_source_line.
4049
4050 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * source-cache.c (source_cache::get_plain_source_lines): Use
4053         open_source_file_with_line_charpos instead of just
4054         open_source_file, remove call to find_source_lines.
4055         (source_cache::get_source_lines): Likewise.
4056         * source.c (find_source_lines): Make static.
4057         (get_filename_and_charpos): Renamed into...
4058         (open_source_file_with_line_charpos): ..this along with changes to
4059         return a scoped_fd, and some other minor clean ups.
4060         (identify_source_line): Use open_source_file_with_line_charpos.
4061         (search_command_helper): Use open_source_file_with_line_charpos
4062         instead of just open_source_file, remove call to
4063         find_source_lines.
4064         * source.h (open_source_file_with_line_charpos): Declare new
4065         function.
4066         (find_source_lines): Delete declaration.
4067
4068 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * source.c (get_filename_and_charpos): Remove fullname
4071         parameter.
4072         (identify_source_line): Update call to get_filename_and_charpos.
4073
4074 2019-06-14  Tom Tromey  <tromey@adacore.com>
4075
4076         PR gdb/24502:
4077         * ui-style.h (skip_ansi_escape): Update comment.
4078         * ui-file.h (class no_terminal_escape_file): New class.
4079         * ui-file.c (no_terminal_escape_file::write)
4080         (no_terminal_escape_file::puts): New methods.
4081         * cli/cli-logging.c (handle_redirections): Use
4082         no_terminal_escape_file.
4083
4084 2019-06-14  Tom Tromey  <tromey@adacore.com>
4085
4086         * NEWS: Move convenience variable news above Python news.
4087
4088 2019-06-14  Tom Tromey  <tom@tromey.com>
4089
4090         * gnulib: Move directory to top-level.
4091         * configure.ac: Don't configure gnulib.
4092         * configure: Rebuild.
4093         * common/common-defs.h: Use new path to gnulib.
4094         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4095         (GNULIB_H): Remove.
4096         (INCGNU): Look in new gnulib location.
4097         (HFILES_NO_SRCDIR): Remove gnulib files.
4098         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4099         (generated_files): Remove GNULIB_H.
4100         ($(LIBGNU), all-lib): Remove targets.
4101         (distclean): Don't mention GNULIB_BUILDDIR.
4102         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4103
4104 2019-06-14  Tom Tromey  <tromey@adacore.com>
4105
4106         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4107         Warn if symbol file does not provide any symbols.
4108
4109 2019-06-14  Tom Tromey  <tromey@adacore.com>
4110
4111         * source.c (find_and_open_source): Respect basenames_may_differ.
4112
4113 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * annotate.c (annotate_breakpoints_invalid): Make use of
4116         scoped_restore_terminal_state.
4117         (annotate_frames_invalid): Likewise.
4118
4119 2019-06-14  Tom Tromey  <tromey@adacore.com>
4120
4121         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4122         allow assignment to an internalvar.
4123
4124 2019-06-14  Tom Tromey  <tromey@adacore.com>
4125
4126         * ada-lex.l: Allow "_" in attribute names.
4127
4128 2019-06-14  Tom Tromey  <tromey@adacore.com>
4129
4130         PR gdb/24653:
4131         * regcache.c (registers_changed): Don't call alloca.
4132         * top.c (execute_command): Don't call alloca.
4133
4134 2019-06-13  Pedro Alves  <palves@redhat.com>
4135
4136         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4137         'expression'.  When parsing an expression, error out if there's
4138         junk after "unlimited".
4139         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4140         (do_set_command): Adjust calls to is_unlimited_literal.
4141
4142 2019-06-13  Pedro Alves  <palves@redhat.com>
4143
4144         * compile/compile.c (make_compile_options_def_group): Add braces
4145         around array_view initializer.
4146         * thread.c (make_thread_apply_all_options_def_group)
4147         (make_thread_apply_all_options_def_group): Likewise.
4148
4149 2019-06-13  Pedro Alves  <palves@redhat.com>
4150
4151         * NEWS (New commands): Mention "maint test-options
4152         require-delimiter", "maint test-options unknown-is-error", "maint
4153         test-options unknown-is-operand" and "maint show
4154         test-options-completion-result".
4155         (New command options, command completion): New section.
4156         (Completion improvements): New section.
4157         Mention that you can abbreviate "unlimited".
4158
4159 2019-06-13  Pedro Alves  <palves@redhat.com>
4160
4161         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4162         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4163         * unittests/cli-utils-selftests.c (test_parse_flags)
4164         (test_parse_flags_qcs): Delete.
4165         (test_cli_utils): Don't call deleted functions.
4166
4167 2019-06-13  Pedro Alves  <palves@redhat.com>
4168
4169         * thread.c: Include "cli/cli-option.h".
4170         (tp_array_compar_ascending): Global.
4171         (tp_array_compar): Delete function.
4172         (tp_array_compar_ascending, tp_array_compar_descending): New
4173         functions.
4174         (ascending_option_def, qcs_flag_option_def)
4175         (thr_qcs_flags_option_defs)
4176         (make_thread_apply_all_options_def_group)
4177         (make_thread_apply_options_def_group): New.
4178         (thread_apply_all_command): Use gdb::option::process_options.
4179         (thread_apply_command_completer)
4180         (thread_apply_all_command_completer): New.
4181         (thread_apply_command): Use gdb::option::process_options.
4182         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4183         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4184         to generate help text of "thread apply".  Adjust "taas"'s help.
4185         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4186         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4187
4188 2019-06-13  Pedro Alves  <palves@redhat.com>
4189
4190         * thread.c (thread_apply_command): Check for invalid TID with
4191         isdigit instead of !isalpha.
4192
4193 2019-06-13  Pedro Alves  <palves@redhat.com>
4194
4195         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4196         (validate_flags_qcs): New.
4197         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4198         (validate_flags_qcs): Declare.
4199         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4200         (make_frame_apply_options_def_group): New.
4201         (frame_apply_command_count): Process options with
4202         gdb::option::process_options.
4203         (frame_apply_completer): New.
4204         (frame_apply_level_completer, frame_apply_all_completer)
4205         (frame_apply_completer): New.
4206         (_initialize_stack): Update help of "frame apply", "frame apply
4207         level", "frame apply all" and "faas" to mention supported options
4208         and install command completers.
4209         * stack.h (frame_apply_all_completer): Declare.
4210         * thread.c: Include "stack.h".
4211         (tfaas_command): Add "--".
4212         (_initialize_thread): Update help "tfaas" to mention supported
4213         options and install command completer.
4214
4215 2019-06-13  Pedro Alves  <palves@redhat.com>
4216
4217         * completer.c (complete_nested_command_line): New.
4218         (gdb_completion_word_break_characters_throw): Add assertion.
4219         * completer.h (complete_nested_command_line): Declare.
4220
4221 2019-06-13  Pedro Alves  <palves@redhat.com>
4222
4223         * stack.c (parse_backtrace_qualifiers): New.
4224         (backtrace_command): Use it.
4225         (backtrace_command_completer): Complete on qualifiers.
4226
4227 2019-06-13  Pedro Alves  <palves@redhat.com>
4228
4229         * frame.c: Include "cli/cli-option.h.
4230         (user_set_backtrace_options): New.
4231         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4232         Delete.
4233         (get_prev_frame): Adjust.
4234         (boolean_option_def, uinteger_option_def)
4235         (set_backtrace_option_defs): New.
4236         (_initialize_frame): Adjust and use
4237         gdb::option::add_setshow_cmds_for_options to install "set
4238         backtrace past-main" and "set backtrace past-entry".
4239         * frame.h: Include "cli/cli-option.h".
4240         (struct frame_print_options): Forward declare.
4241         (print_frame_arguments_all, print_frame_arguments_scalars)
4242         (print_frame_arguments_none): Declare.
4243         (print_entry_values): Delete declaration.
4244         (struct frame_print_options, user_frame_print_options): New.
4245         (struct set_backtrace_options): New.
4246         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4247         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4248         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4249         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4250         (list_args_or_locals): Add frame_print_options parameter.
4251         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4252         * python/py-framefilter.c (enumerate_args): Pass down
4253         USER_FRAME_PRINT_OPTIONS.
4254         * stack.c: Include "cli/cli-option.h".
4255         (print_frame_arguments_all, print_frame_arguments_scalars)
4256         (print_frame_arguments_none): Declare.
4257         (print_raw_frame_arguments, print_entry_values): Delete.
4258         (user_frame_print_options): New.
4259         (boolean_option_def, enum_option_def, frame_print_option_defs):
4260         New.
4261         (struct backtrace_cmd_options): New.
4262         (bt_flag_option_def): New.
4263         (backtrace_command_option_defs): New.
4264         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4265         (print_frame_arg, read_frame_arg, print_frame_args)
4266         (print_frame_info, print_frame): Add frame_print_options parameter
4267         and use it.
4268         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4269         (backtrace_command_1): Add frame_print_options and
4270         backtrace_cmd_options parameters and use them.
4271         (make_backtrace_options_def_group): New.
4272         (backtrace_command): Process command options with
4273         gdb::option::process_options.
4274         (backtrace_command_completer): New.
4275         (_initialize_stack): Extend "backtrace"'s help to mention
4276         supported options.  Install completer for "backtrace".
4277         Install some settings commands with add_setshow_cmds_for_options.
4278
4279 2019-06-13  Pedro Alves  <palves@redhat.com>
4280
4281         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4282         and that "set/show print raw frame-arguments" are now deprecated.
4283
4284         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4285         command.
4286         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4287         * stack.c (_initialize_stack): Install "set/show print
4288         raw-frame-arguments", and deprecate "set/show print raw
4289         frame-arguments".
4290         * valprint.c (_initialize_valprint): Deprecate "set/show print
4291         raw".
4292
4293 2019-06-13  Pedro Alves  <palves@redhat.com>
4294
4295         * compile/compile.c (struct compile_options): New.
4296         (compile_flag_option_def, compile_command_option_defs)
4297         (make_compile_options_def_group): New.
4298         (compile_file_command): Handle options with
4299         gdb::option::process_options.
4300         (compile_file_command_completer): New function.
4301         (compile_code_command): Handle options with
4302         gdb::option::process_options.
4303         (compile_code_command_completer): New function.
4304         (_initialize_compiler): Install completers for "compile code" and
4305         "compile file".  Mention available options in "compile code" and
4306         "compile code"'s help.
4307         * completer.c (advance_to_completion_word): New, factored out from
4308         ...
4309         (advance_to_expression_complete_word_point): ... this.
4310         (advance_to_filename_complete_word_point): New.
4311         * completer.h (advance_to_filename_complete_word_point): New
4312         declaration.
4313
4314 2019-06-13  Pedro Alves  <palves@redhat.com>
4315
4316         * compile/compile.c: Include "cli/cli-option.h".
4317         (compile_print_value): Scope data pointer is now a
4318         value_print_options pointer; adjust.
4319         (compile_print_command): Process options.  Scope data pointer is
4320         now a value_print_options pointer; adjust.
4321         (_initialize_compile): Update "compile print"'s help to include
4322         supported options.  Install a completer for "compile print".
4323         * cp-valprint.c (show_vtblprint, show_objectprint)
4324         (show_static_field_print): Delete.
4325         (_initialize_cp_valprint): Don't install "set print
4326         static-members", "set print vtbl", "set print object" here.
4327         * printcmd.c: Include "cli/cli-option.h" and
4328         "common/gdb_optional.h".
4329         (print_command_parse_format): Rework to fill in a
4330         value_print_options instead of a format_data.
4331         (print_value): Change parameter type from format_data pointer to
4332         value_print_options reference.  Adjust.
4333         (print_command_1): Process options.  Adjust to pass down a
4334         value_print_options.
4335         (print_command_completer): New.
4336         (_initialize_printcmd): Install print_command_completer as
4337         handle_brkchars completer for the "print" command.  Update
4338         "print"'s help to include supported options.
4339         * valprint.c: Include "cli/cli-option.h".
4340         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4341         here from cp-valprint.c.
4342         (boolean_option_def, uinteger_option_def)
4343         (value_print_option_defs, make_value_print_options_def_group):
4344         New.  Use gdb::option::add_setshow_cmds_for_options to install
4345         "set print elements", "set print null-stop", "set print repeats",
4346         "set print pretty", "set print union", "set print array", "set
4347         print address", "set print symbol", "set print array-indexes".
4348         * valprint.h: Include <string> and "cli/cli-option.h".
4349         (make_value_print_options_def_group): Declare.
4350         (print_value): Change parameter type from format_data pointer to
4351         value_print_options reference.
4352         (print_command_completer): Declare.
4353
4354 2019-06-13  Pedro Alves  <palves@redhat.com>
4355
4356         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4357         (COMMON_SFILES): Add maint-test-settings.c.
4358         * cli/cli-decode.c (boolean_enums): New global, factored out from
4359         ...
4360         (add_setshow_boolean_cmd): ... here.
4361         * cli/cli-decode.h (boolean_enums): Declare.
4362         * cli/cli-option.c: New file.
4363         * cli/cli-option.h: New file.
4364         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4365         factored out from ...
4366         (parse_cli_boolean_value(const char *)): ... this.
4367         (is_unlimited_literal): Change parameter type to pointer to
4368         pointer.  Adjust and advance ARG pointer.
4369         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4370         (parse_cli_var_enum): New, factored out from ...
4371         (do_set_command): ... this.  Adjust.
4372         * cli/cli-setshow.h (parse_cli_boolean_value)
4373         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4374         (parse_cli_var_enum): Declare.
4375         * cli/cli-utils.c: Include "cli/cli-option.h".
4376         (get_ulongest): New.
4377         * cli/cli-utils.h (get_ulongest): Declare.
4378         (check_for_argument): New overloads.
4379         * maint-test-options.c: New file.
4380
4381 2019-06-13  Pedro Alves  <palves@redhat.com>
4382
4383         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4384         parse a range if "-" is at the end of the string.
4385
4386 2019-06-13  Pedro Alves  <palves@redhat.com>
4387
4388         * cli/cli-setshow.c (parse_auto_binary_operation)
4389         (parse_cli_boolean_value): Don't allow "o".
4390
4391 2019-06-13  Pedro Alves  <palves@redhat.com>
4392
4393         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4394         * NEWS: Mention maint test-settings KIND.
4395         * maint-test-settings.c: New file.
4396
4397 2019-06-13  Pedro Alves  <palves@redhat.com>
4398
4399         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4400         completer.
4401         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4402         "set" completers.
4403
4404 2019-06-13  Pedro Alves  <palves@redhat.com>
4405
4406         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4407         after item.
4408
4409 2019-06-13  Pedro Alves  <palves@redhat.com>
4410
4411         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4412
4413 2019-06-13  Pedro Alves <palves@redhat.com>
4414
4415         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4416         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4417         call.
4418         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4419         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4420         calls.
4421         (check_for_argument): Skip spaces after argument.
4422
4423 2019-06-13  Pedro Alves  <palves@redhat.com>
4424
4425         * thread.c (thread_apply_command): Adjust TID parsing.
4426         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4427         detected before end of string.
4428         (tid_is_in_list): Error out if LIST is invalid.
4429
4430 2019-06-13  Pedro Alves  <palves@redhat.com>
4431
4432         * completer.c (complete_line_internal_1): Rewind completion word
4433         point.
4434         (completion_tracker::advance_custom_word_point_by): Change
4435         parameter type to int.
4436         * completer.h (completion_tracker::advance_custom_word_point_by):
4437         Likewise.
4438
4439 2019-06-13  Pedro Alves  <palves@redhat.com>
4440
4441         * completer.c (advance_to_completion_word): Handle delimiters.
4442
4443 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4444
4445         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4446
4447 2019-06-11  Tom Tromey  <tom@tromey.com>
4448
4449         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4450         (xmalloc_failed): Move to alloc.c.
4451         * alloc.c: New file.
4452         * Makefile.in (COMMON_SFILES): Add alloc.c.
4453
4454 2019-06-11  Tom Tromey  <tom@tromey.com>
4455
4456         * nat/linux-waitpid.c: Don't include server.h.
4457         (linux_debug): Remove.
4458         (my_waitpid): Update.
4459
4460 2019-06-11  Tom Tromey  <tromey@adacore.com>
4461
4462         * infcall.c (_initialize_infcall): Remove trailing newline from
4463         help.
4464         * user-regs.c (_initialize_user_regs): Remove trailing newline
4465         from help.
4466         * typeprint.c (_initialize_typeprint): Remove trailing newline
4467         from help.
4468         * reverse.c (_initialize_reverse): Remove trailing newlines from
4469         help.
4470         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4471         from help.
4472         * language.c (add_set_language_command): Remove trailing newline
4473         from help.
4474         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4475         help.
4476         * disasm.c (_initialize_disasm): Remove trailing newline from
4477         help.
4478         * top.c (init_main): Remove trailing newline from help.
4479         * interps.c (_initialize_interpreter): Remove trailing newline
4480         from help.
4481         * btrace.c (_initialize_btrace): Remove trailing newlines from
4482         help.
4483         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4484         from help.
4485         * python/python.c (_initialize_python): Remove trailing newline
4486         from help.
4487         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4488         help.
4489         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4490         from help.  Reformat some text.
4491         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4492         from help.
4493         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4494         newline from help.
4495
4496 2019-06-11  Tom Tromey  <tromey@adacore.com>
4497
4498         * darwin-nat.c (darwin_decode_exception_message)
4499         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4500
4501 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * valops.c (value_slice): Check for not allocated or not
4504         associated values.
4505
4506 2019-06-10  Tom de Vries  <tdevries@suse.de>
4507
4508         PR gdb/24618
4509         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4510         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4511         invalid.
4512
4513 2019-06-10  Tom de Vries  <tdevries@suse.de>
4514
4515         PR gdb/24611
4516         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4517         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4518
4519 2019-06-10  Tom de Vries  <tdevries@suse.de>
4520
4521         PR symtab/24545
4522         * symtab.c (struct demangled_name_entry): Add language field.
4523         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4524         static minimal symbol".  Set and use language field.
4525
4526 2019-06-10  Tom Tromey  <tromey@adacore.com>
4527
4528         * ada-lang.c (_initialize_ada_language): Update help text.
4529
4530 2019-06-10  Tom Tromey  <tromey@adacore.com>
4531
4532         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4533         with a newline.
4534         * guile/guile.c (handle_boot_error): Don't end warning with a
4535         newline.
4536         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4537         warning with a newline.
4538         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4539         newline.
4540         (s12z_frame_cache): Likewise.
4541         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4542         a newline.
4543         * solib-svr4.c (disable_probes_interface): Don't end warning with
4544         a newline.
4545         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4546         newline.
4547         * python/python.c (do_finish_initialization): Don't end warning
4548         with a newline.
4549
4550 2019-06-10  Tom Tromey  <tom@tromey.com>
4551
4552         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4553         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4554         gdbpy_enter.
4555
4556 2019-06-10  Tom Tromey  <tromey@adacore.com>
4557
4558         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4559         data.
4560         (elf_new_init): Don't call stabsread_new_init.
4561         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4562         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4563         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4564
4565 2019-06-10  Tom de Vries  <tdevries@suse.de>
4566
4567         PR symtab/16264
4568         PR symtab/24517
4569         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4570
4571 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4572
4573         * source.c (find_and_open_source): Also rewrite relative file
4574         names.
4575
4576 2019-04-26  Amos Bird  <amosbird@gmail.com>
4577
4578         * annotate.c (annotate_thread_exited): Add "thread-exited"
4579         annotation.
4580
4581 2019-06-06  Tom Tromey  <tromey@adacore.com>
4582
4583         * maint.h (class scoped_command_stats): Use
4584         DISABLE_COPY_AND_ASSIGN.
4585         <print_time>: New method.
4586         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4587         print_time.
4588         (scoped_command_stats::print_time): New method.
4589
4590 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4593         instructions of lengths 6 or 8 bytes.
4594
4595 2019-06-04  Pedro Alves  <palves@redhat.com>
4596
4597         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4598
4599         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4600         * breakpoint.c (condition_completer): Likewise.
4601         * cli/cli-dump.c (scan_expression): Likewise.
4602         * common/filestuff.c (mkdir_recursive): Likewise.
4603         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4604         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4605         (gdb_abspath): Likewise.
4606         * compile/compile-cplus-types.c
4607         (compile_cplus_instance::decl_name): Likewise.
4608         * completer.c (complete_explicit_location):
4609         (signal_completer, reg_or_group_completer_1): Likewise.
4610         * cp-support.c (cp_remove_params_if_any): Likewise.
4611         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4612         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4613         * infcmd.c (strip_bg_char): Likewise.
4614         * linespec.c (copy_token_string): Likewise.
4615         * mi/mi-main.c (output_cores): Likewise.
4616         * psymtab.c (psymtab_search_name):
4617         * symfile.c (test_set_ext_lang_command): Likewise.
4618         * target.c (target_fileio_read_stralloc): Likewise.
4619         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4620         * value.c (complete_internalvar): Likewise.
4621
4622 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4623
4624         Add objfile property to gdb.Type.
4625         * NEWS: Mention Python API addition.
4626         * python/py-type.c (typy_get_objfile): New method.
4627
4628 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4629
4630         * NEWS: Mention the new set|show style [title|highlight].
4631         Mention changes to "show style", "help" and "apropos".
4632
4633 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4634
4635         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4636         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4637         instead of print_help_for_command.
4638         (print_doc_of_command): New function.
4639         (help_list): Add 'apropos -v word' suggestion.
4640         (print_help_for_command): Style the command name using title style.
4641         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4642         (_initialize_cli_cmds): Describe -v in apropos_command help.
4643
4644 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4645
4646         * cli/cli-style.h (cli_style_option): Add name in constructor,
4647         add m_name class member, add constructor with intensity,
4648         add name class function.
4649         (cli_style_option::add_setshow_commands): Remove name argument.
4650         (highlight_style, title_style): New styles.
4651         * cli/cli-style.c (do_show): New function that shows a style
4652         characteristic styling the style name with itself.
4653         (set_style_name): New function.
4654         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4655         Update all callers according to the changes in cli/cli-style.h.
4656         * utils.h (fputs_highlighted): New function.
4657         * utils.c (fputs_highlighted): Likewise.
4658
4659 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4660
4661         * NEWS: Mention new pipe command and new convenience variables.
4662
4663 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4664
4665         * cli/cli-cmds.c (pipe_command): New function.
4666         (_initialize_cli_cmds): Call add_com for pipe_command.
4667         Define | as an alias for pipe.
4668         (exit_status_set_internal_vars): New function.
4669         (shell_escape): Call exit_status_set_internal_vars.
4670         cli/cli-decode.c (find_command_name_length): Recognize | as
4671         a single character command.
4672
4673 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4674
4675         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4676         top.c (execute_command_to_ui_file): New function, mostly a copy
4677         of execute_command_to_string.
4678         (execute_command_to_string): Implement by calling
4679         execute_command_to_ui_file.
4680
4681 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4682
4683         * top.h (saved_command_line): Remove declaration.
4684         * top.c (previous_saved_command_line, previous_repeat_arguments):
4685         New variables.
4686         (saved_command_line): Make static, define together with other
4687         'repeat variables'.
4688         (dont_repeat): Clear repeat_arguments.
4689         (repeat_previous, get_saved_command_line, save_command_line):
4690         New functions.
4691         (gdb_init): Initialize saved_command_line
4692         and previous_saved_command_line.
4693         * main.c (captured_main_1): Remove saved_command_line initialization.
4694         * event-top.c (handle_line_of_input): Update to use
4695         the new 'repeat' related functions instead of direct access to
4696         saved_command_line.
4697         * command.h (repeat_previous, get_saved_command_line,
4698         save_command_line): New declarations.
4699         (dont_repeat): Add comment.
4700
4701 2019-05-30  Tom Tromey  <tromey@adacore.com>
4702
4703         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4704         Fix comment.
4705         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4706
4707 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4708
4709         PR cli/24587
4710         * completer.c (complete): Initialize variable word.
4711
4712 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4713
4714         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4715         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4716         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4717         'body' is NULL to the outter 'if', protecting the '!is_define'
4718         situation as well.
4719
4720 2019-05-29  Tom Tromey  <tromey@adacore.com>
4721
4722         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4723         (dwarf_unknown): New function.
4724         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4725         (dwarf_type_encoding_name): Use dwarf_unknown.
4726
4727 2019-05-29  Tom Tromey  <tromey@adacore.com>
4728
4729         PR c++/20020:
4730         * cp-valprint.c (cp_print_value_fields): Call
4731         cp_print_static_field inside "try".
4732
4733 2019-05-29  Tom Tromey  <tromey@adacore.com>
4734
4735         * inflow.c (struct terminal_info): Add default operator=.
4736         * configure: Rebuild.
4737         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4738         -Wdeprecated-copy-dtor, -Wredundant-move.
4739
4740 2019-05-29  Tom Tromey  <tromey@adacore.com>
4741
4742         * NEWS: Add entry.
4743         * infcmd.c (print_return_value_1): Handle finish_print
4744         option.
4745         (show_print_finish): New function.
4746         (_initialize_infcmd): Add "set/show print finish" commands.
4747         * valprint.c (user_print_options): Initialize new member.
4748         * valprint.h (struct value_print_options) <finish_print>: New
4749         member.
4750
4751 2019-05-28  Tom Tromey  <tromey@adacore.com>
4752
4753         * ada-lang.c (ada_remove_Xbn_suffix)
4754         (find_old_style_renaming_symbol)
4755         (parse_old_style_renaming): Remove.
4756         (ada_find_renaming_symbol): Don't call
4757         find_old_style_renaming_symbol.
4758         (ada_is_renaming_symbol): Rename from
4759         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4760         bool.  Now static.
4761         (ada_read_var_value): Update and simplify.
4762         * ada-exp.y (write_var_or_type): Remove old code.
4763
4764 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4765
4766         * event-top.c: Remove include comment.
4767         * inflow.c (class scoped_ignore_sigttou): Move from here...
4768         * inflow.h (class scoped_ignore_sigttou): ...to here.
4769         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4770         * top.c:  Remove include comment.
4771
4772 2019-05-27  Tom Tromey  <tom@tromey.com>
4773
4774         * NEWS: Fix typo.
4775
4776 2019-05-22  Tom Tromey  <tromey@adacore.com>
4777
4778         * target.c (target_follow_exec): Constify parameter.
4779         * target-delegates.c: Rebuild.
4780         * remote.c (remote_target::follow_exec): Constify parameter.
4781         * infrun.c (follow_exec): Constify parameter.
4782         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4783         (target_follow_exec): Likewise.
4784
4785 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4786
4787         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4788         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4789
4790 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4791
4792         * NEWS: Add debugredirect and testsuite sections.
4793
4794 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4795
4796         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4797         target descriptions using exclusively floating point register name
4798         aliases.
4799
4800 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         PR gdb/18644:
4803         * f-lang.c (build_fortran_types): Handle the case where
4804         gdbarch_floatformat_for_type returns a nullptr.
4805
4806 2019-05-21  Tom de Vries  <tdevries@suse.de>
4807
4808         PR cli/24587
4809         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4810
4811 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         PR gdb/18644:
4814         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4815         16-byte floats.
4816         * i386-tdep.c (i386_floatformat_for_type): Use
4817         floatformats_ia64_quad for the 16-byte floating point component
4818         within a fortran 32-byte complex number.
4819
4820 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4821
4822         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4823         delete default constructor.
4824         (find_partial_die): Update to return const struct.
4825         (partial_die_parent_scope): Move variable declaration into scope
4826         of its use and change its type to auto.
4827         (guess_partial_die_structure_name): Likewise.
4828         (partial_die_info::fixup): Likewise.
4829
4830 2019-05-17  Tom Tromey  <tromey@adacore.com>
4831
4832         * source.c (find_and_open_source): Remove cast.
4833
4834 2019-05-17  Tom Tromey  <tromey@adacore.com>
4835
4836         * annotate.c (annotate_source): Make "filename" const.
4837         * annotate.h (annotate_source): Use const.
4838
4839 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4840
4841         * disasm.c (set_disassembler_options): Send errors to stderr.
4842
4843 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4844
4845         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4846         (cli_interp_base::set_logging): Check debug_redirect.
4847         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4848         * cli/cli-logging.c (debug_redirect): Add static variable.
4849         (pop_output_files): Add default param.
4850         (handle_redirections): Print debug setting.
4851         (show_logging_command): Likewise.
4852         (_initialize_cli_logging): Add debugredirect command.
4853         * interps.c (current_interp_set_logging): Add debug_redirect
4854         parameter.
4855         * interps.h (set_logging): Add debug_redirect parameter.
4856         (current_interp_set_logging): Likewise.
4857         * mi/mi-common.h: Likewise.
4858         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4859
4860 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4861             Tom Tromey  <tromey@adacore.com>
4862
4863         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4864         directly.
4865         * cli/cli-interp.h (make_logging_output): Remove declaration.
4866         * cli/cli-logging.c (make_logging_output): Remove function.
4867         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4868         directly.
4869         * ui-file.c (tee_file::tee_file): Remove bools.
4870         (tee_file::~tee_file): Remove deletes.
4871         * ui-file.h (tee_file): Remove bools.
4872
4873 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4874
4875         * mi/mi-cmds.h (mi_cmd_complete): New function.
4876         * mi/mi-main.c (mi_cmd_complete): Likewise.
4877         * mi/mi-cmds.c: Define new MI command -complete.
4878         * NEWS: Mention new -complete command.
4879
4880 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4881
4882         * completer.h (complete): New function.
4883         * completer.c (complete): Likewise.
4884         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4885         function defined in completer.h.
4886
4887 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4888
4889         * MAINTAINERS (Write After Approval): Add myself.
4890
4891 2019-05-17  Tom de Vries  <tdevries@suse.de>
4892
4893         PR gdb/24094
4894         * dwarf2read.c (struct cu_partial_die_info): New struct.
4895         (find_partial_die): Return cu_partial_die_info.
4896         (partial_die_parent_scope, guess_partial_die_structure_name)
4897         (partial_die_info::fixup): Handle new return type of find_partial_die.
4898
4899 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4900
4901         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4902         "std::string", simplifying the algorithm.
4903
4904 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4905
4906         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4907         (stap_static_probe_ops::get_probes): Likewise.
4908
4909 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4910
4911         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4912         '-')" and "else if".
4913         (stap_parse_single_operand): Join checks for
4914         "gdbarch_stap_parse_special_token_p" and
4915         "gdbarch_stap_parse_special_token" in the same "if" statement.
4916         Invert check when verifying for operation on register
4917         displacement.
4918
4919 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4920
4921         * stap-probe.c (stap_get_opcode): Update comment.
4922         (stap_get_expected_argument_type): Likewise.
4923         (handle_stap_probe): Likewise.
4924
4925 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4926
4927         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4928         return type to 'bool'.  Adjust comment.  Use 'bool' when
4929         appropriate.
4930         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4931         * stap-probe.c (stap_parse_argument_1): Likewise.
4932         (stap_is_operator): Likewise.
4933         (stap_is_generic_prefix): Likewise.
4934         (stap_is_register_prefix): Likewise.
4935         (stap_is_register_indirection_prefix): Likewise.
4936         (stap_is_integer_prefix): Likewise.
4937         (stap_generic_check_suffix): Likewise.
4938         (stap_check_integer_suffix): Likewise.
4939         (stap_check_register_suffix): Likewise.
4940         (stap_check_register_indirection_suffix): Likewise.
4941         (stap_parse_register_operand): Likewise.
4942         (stap_parse_single_operand): Likewise.
4943         (stap_parse_argument_1): Likewise.
4944         (stap_probe::get_argument_count): Likewise.
4945         (stap_is_operator): Likewise.
4946
4947 2019-05-16  Tom Tromey  <tromey@adacore.com>
4948
4949         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4950         keyword to foreach.
4951
4952 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4953
4954         * linux-thread-db.c (try_thread_db_load_1): Change return type
4955         to bool.
4956         (try_thread_db_load): Likewise.
4957         (try_thread_db_load_from_pdir_1): Likewise.
4958         (try_thread_db_load_from_pdir): Likewise.
4959         (try_thread_db_load_from_sdir): Likewise.
4960         (try_thread_db_load_from_dir): Likewise.
4961         (thread_db_load_search): Likewise.
4962         (has_libpthread): Likewise.
4963         (thread_db_load): Likewise.
4964
4965 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4966
4967         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4968         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4969         NULL, and complain/return if that's the case.
4970
4971 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4972
4973         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4974         (advance, posn, abstract_read_memory): New functions.
4975         [struct mem_read_abstraction]: New struct.
4976         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4977
4978 2019-05-14  Tom Tromey  <tromey@adacore.com>
4979
4980         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4981         value is not lval_memory.
4982
4983 2019-05-14  Tom Tromey  <tromey@adacore.com>
4984
4985         * solib.c (info_sharedlibrary_command): Style the file name.
4986
4987 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4988
4989         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4990         (aarch64_vnv_type): Likewise.
4991         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4992         * common/tdesc.c: Likewise.
4993         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4994         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4995         * features/aarch64-fpu.xml: Add ieee half view.
4996         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4997         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4998         * gdbtypes.h (struct builtin_type): Likewise.
4999         (struct objfile_type): Likewise.
5000
5001 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5002
5003         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5004         typo.
5005         * location.h (string_to_event_location): Likewise.
5006
5007 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5008
5009         GDB 8.3 released.
5010
5011 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5012
5013         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5014         New variable declaration.
5015         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5016         New variable.
5017         (print_one_breakpoint): Use ui_out::test_flags and new global
5018         variable to compute use_fixed_output.
5019         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5020         Remove.
5021         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5022         (mi_multi_location_breakpoint_output_fixed): Remove.
5023         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5024         new variable.
5025         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5026         fix_multi_location_breakpoint_output flag if version >= 3.
5027         * ui-out.h (enum ui_out_flag)
5028         <fix_multi_location_breakpoint_output>: New enumerator.
5029
5030 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5031
5032         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5033
5034 2019-05-10  Tom Tromey  <tromey@adacore.com>
5035
5036         * ada-lang.c (catch_ada_completer): New function.
5037         (_initialize_ada_language): Use it.
5038
5039 2019-05-10  Tom Tromey  <tromey@adacore.com>
5040
5041         * thread.c (print_thread_info): Make "requested_threads" const.
5042         * gdbthread.h (print_thread_info): Make "requested_threads"
5043         const.
5044         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5045         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5046
5047 2019-05-08  Tom Tromey  <tom@tromey.com>
5048
5049         * gdbtypes.c (objfile_type_data): Change type.
5050         (objfile_type, _initialize_gdbtypes): Update.
5051
5052 2019-05-08  Tom Tromey  <tom@tromey.com>
5053
5054         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5055         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5056         (_initialize_dwarf2_frame): Update.
5057
5058 2019-05-08  Tom Tromey  <tom@tromey.com>
5059
5060         * objc-lang.c (objc_objfile_data): Change type.
5061         (find_methods): Update.
5062         (_initialize_objc_lang): Remove.
5063
5064 2019-05-08  Tom Tromey  <tom@tromey.com>
5065
5066         * stabsread.c (rs6000_builtin_type_data): Change type.
5067         (rs6000_builtin_type, _initialize_stabsread): Update.
5068
5069 2019-05-08  Tom Tromey  <tom@tromey.com>
5070
5071         * mips-tdep.c (mips_pdr_data): Remove.
5072         (_initialize_mips_tdep): Update.
5073
5074 2019-05-08  Tom Tromey  <tom@tromey.com>
5075
5076         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5077         (hppa_init_objfile_priv_data, read_unwind_info)
5078         (find_unwind_entry, _initialize_hppa_tdep): Update.
5079
5080 2019-05-08  Tom Tromey  <tom@tromey.com>
5081
5082         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5083         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5084         on obstack.
5085         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5086
5087 2019-05-08  Tom Tromey  <tom@tromey.com>
5088
5089         * mdebugread.c (basic_type_data): Change type.
5090         (basic_type, _initialize_mdebugread): Update.
5091
5092 2019-05-08  Tom Tromey  <tom@tromey.com>
5093
5094         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5095
5096 2019-05-08  Tom Tromey  <tom@tromey.com>
5097
5098         * nto-tdep.c (nto_inferior_data_reg): Change type.
5099         (nto_inferior_data): Update.
5100         (nto_inferior_data_cleanup, nto_new_inferior_data)
5101         (_initialize_nto_tdep): Remove.
5102         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5103
5104 2019-05-08  Tom Tromey  <tom@tromey.com>
5105
5106         * ada-lang.c (struct ada_inferior_data): Add initializers.
5107         (ada_inferior_data): Change type.
5108         (ada_inferior_data_cleanup): Remove.
5109         (get_ada_inferior_data, ada_inferior_exit)
5110         (struct ada_pspace_data): Add initializers, destructor.
5111         (ada_pspace_data_handle): Change type.
5112         (get_ada_pspace_data): Update.
5113         (ada_pspace_data_cleanup): Remove.
5114
5115 2019-05-08  Tom Tromey  <tom@tromey.com>
5116
5117         * coffread.c (struct coff_symfile_info): Add initializers.
5118         (coff_objfile_data_key): Move lower.  Change type.
5119         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5120         Update.
5121         (coff_free_info): Remove.
5122
5123 2019-05-08  Tom Tromey  <tom@tromey.com>
5124
5125         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5126         (fbsd_pspace_data_handle): Move lower.  Change type.
5127         (get_fbsd_pspace_data): Update.
5128         (fbsd_pspace_data_cleanup): Remove.
5129         (_initialize_fbsd_tdep): Update.
5130
5131 2019-05-08  Tom Tromey  <tom@tromey.com>
5132
5133         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5134         (get_ada_tasks_pspace_data): Update.
5135         (ada_tasks_pspace_data_cleanup): Remove.
5136         (_initialize_tasks): Update.
5137         (ada_tasks_inferior_data_handle): Change type.
5138         (get_ada_tasks_inferior_data): Update.
5139         (ada_tasks_inferior_data_cleanup): Remove.
5140         (struct ada_tasks_pspace_data): Add initializers.
5141
5142 2019-05-08  Tom Tromey  <tom@tromey.com>
5143
5144         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5145         * symfile-debug.c (debug_sym_get_probes): Change type.
5146         * stap-probe.c (handle_stap_probe):
5147         (stap_static_probe_ops::get_probes): Change type.
5148         * probe.h (class static_probe_ops) <get_probes>: Change type.
5149         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5150         (parse_probes_in_pspace): Update.
5151         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5152         Update.
5153         (any_static_probe_ops::get_probes): Change type.
5154         * elfread.c (elfread_data): New typedef.
5155         (probe_key): Change type.
5156         (elf_get_probes): Likewise.  Update.
5157         (probe_key_free): Remove.
5158         (_initialize_elfread): Update.
5159         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5160         Change type.
5161         (dtrace_process_dof_probe, dtrace_process_dof)
5162         (dtrace_static_probe_ops::get_probe): Change type.
5163
5164 2019-05-08  Tom Tromey  <tom@tromey.com>
5165
5166         * xcoffread.c (struct xcoff_symfile_info): Rename from
5167         coff_symfile_info.  Add initializers.
5168         (xcoff_objfile_data_key): Move lower.  Change type.
5169         (XCOFF_DATA): Rewrite.
5170         (xcoff_free_info): Remove.
5171         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5172         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5173         (xcoff_initial_scan): Update.
5174
5175 2019-05-08  Tom Tromey  <tom@tromey.com>
5176
5177         * solib-svr4.c (struct svr4_info): Add initializers and
5178         destructor.
5179         <probes_table>: Now an htab_up.
5180         (solib_svr4_pspace_data): Change type.
5181         (free_probes_table): Simplify.
5182         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5183         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5184         (probes_table_remove_objfile_probes, register_solib_event_probe)
5185         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5186         (_initialize_svr4_solib): Update.
5187
5188 2019-05-08  Tom Tromey  <tom@tromey.com>
5189
5190         * remote.c (remote_pspace_data): Change type.
5191         (remote_pspace_data_cleanup): Remove.
5192         (get_remote_exec_file, set_pspace_remote_exec_file)
5193         (_initialize_remote): Update.
5194
5195 2019-05-08  Tom Tromey  <tom@tromey.com>
5196
5197         * breakpoint.c (breakpoint_objfile_key): Change type.
5198         (get_breakpoint_objfile_data): Update.
5199         (free_breakpoint_objfile_data): Remove.
5200         (_initialize_breakpoint): Update.
5201
5202 2019-05-08  Tom Tromey  <tom@tromey.com>
5203
5204         * linux-tdep.c (struct linux_info): Add initializers.
5205         (linux_inferior_data): Move.  Change type.
5206         (invalidate_linux_cache_inf): Update.
5207         (linux_inferior_data_cleanup): Remove.
5208         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5209
5210 2019-05-08  Tom Tromey  <tom@tromey.com>
5211
5212         * auxv.c (auxv_inferior_data): Move.  Change type.
5213         (auxv_inferior_data_cleanup): Remove.
5214         (invalidate_auxv_cache_inf): Rewrite.
5215         (get_auxv_inferior_data, _initialize_auxv): Update.
5216
5217 2019-05-08  Tom Tromey  <tom@tromey.com>
5218
5219         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5220         (symfile_debug_objfile_data_key): Change type.
5221         (symfile_debug_installed, debug_qf_has_symbols)
5222         (debug_qf_find_last_source_symtab)
5223         (debug_qf_forget_cached_source_info)
5224         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5225         (debug_qf_print_stats, debug_qf_dump)
5226         (debug_qf_expand_symtabs_for_function)
5227         (debug_qf_expand_all_symtabs)
5228         (debug_qf_expand_symtabs_with_fullname)
5229         (debug_qf_map_matching_symbols)
5230         (debug_qf_expand_symtabs_matching)
5231         (debug_qf_find_pc_sect_compunit_symtab)
5232         (debug_qf_map_symbol_filenames)
5233         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5234         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5235         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5236         (debug_sym_read_linetable, debug_sym_relocate): Update.
5237         (symfile_debug_free_objfile): Remove.
5238         (install_symfile_debug_logging, _initialize_symfile_debug):
5239         Update.
5240
5241 2019-05-08  Tom Tromey  <tom@tromey.com>
5242
5243         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5244         allocate_on_obstack.
5245         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5246         (get_dwarf2_per_objfile): Update.
5247         (set_dwarf2_per_objfile): Remove.
5248         (dwarf2_has_info, dwarf2_get_section_info): Update.
5249         (dwarf2_free_objfile): Remove.
5250         (_initialize_dwarf2_read): Update.
5251
5252 2019-05-08  Tom Tromey  <tom@tromey.com>
5253
5254         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5255         initializers.
5256         <unsupported_script_warning_printed,
5257         script_not_found_warning_printed>: Now bool.
5258         (auto_load_pspace_data): Change type.
5259         (~auto_load_pspace_info): Rename from
5260         auto_load_pspace_data_cleanup.
5261         (get_auto_load_pspace_data, init_loaded_scripts_info)
5262         (clear_section_scripts, maybe_print_unsupported_script_warning)
5263         (maybe_print_script_not_found_warning, _initialize_auto_load):
5264         Update.
5265
5266 2019-05-08  Tom Tromey  <tom@tromey.com>
5267
5268         * objfiles.c (objfile_pspace_info): Add destructor and
5269         initializers.
5270         (objfiles_pspace_data): Change type.
5271         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5272         (get_objfile_pspace_data): Update.
5273         (objfiles_bfd_data): Change type.
5274         (get_objfile_bfd_data): Update.
5275         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5276
5277 2019-05-08  Tom Tromey  <tom@tromey.com>
5278
5279         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5280         Change type.
5281         (get_catch_syscall_inferior_data): Update.
5282         (catch_syscall_inferior_data_cleanup): Remove.
5283         (_initialize_break_catch_syscall): Update.
5284
5285 2019-05-08  Tom Tromey  <tom@tromey.com>
5286
5287         * inflow.c (struct terminal_info): Add destructor and
5288         initializers.
5289         (inflow_inferior_data): Change type.
5290         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5291         (get_inflow_inferior_data, inflow_inferior_exit)
5292         (swap_terminal_info, _initialize_inflow): Update.
5293
5294 2019-05-08  Tom Tromey  <tom@tromey.com>
5295
5296         * target-dcache.c (target_dcache_cleanup): Remove.
5297         (target_dcache_aspace_key): Change type.
5298         (target_dcache_init_p, target_dcache_invalidate)
5299         (target_dcache_get, target_dcache_get_or_init)
5300         (_initialize_target_dcache): Update.
5301         * dcache.h (struct dcache_deleter): New.
5302
5303 2019-05-08  Tom Tromey  <tom@tromey.com>
5304
5305         * symtab.c (struct symbol_cache): Add destructor and
5306         initializers.
5307         (symbol_cache_key): Move.  Change type.
5308         (make_symbol_cache, free_symbol_cache): Remove.
5309         (get_symbol_cache): Update.
5310         (symbol_cache_cleanup): Remove.
5311         (ALL_PSPACES, symbol_cache_flush)
5312         (maintenance_print_symbol_cache)
5313         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5314         Update.
5315
5316 2019-05-08  Tom Tromey  <tom@tromey.com>
5317
5318         * symtab.c (struct main_info): Add destructor and initializers.
5319         (main_progspace_key): Move.  Change type.
5320         (get_main_info): Update.
5321         (main_info_cleanup): Remove.
5322         (_initialize_symtab): Update.
5323
5324 2019-05-08  Tom Tromey  <tom@tromey.com>
5325
5326         * registry.h (DECLARE_REGISTRY): Define the _key class.
5327
5328 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * NEWS: Merge two 'New commands' sections.
5331
5332 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5333
5334         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5335         parameter and use Ada language definition instead.
5336         (ada_val_print_ptr): Remove unused language parameter.
5337         (ada_val_print_num): Remove language parameter and use Ada language
5338         definition instead.
5339         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5340         parameter.
5341         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5342         parameter and use Ada language definition instead.
5343         (ada_val_print_1): Update all ada_val_print_xxx calls.
5344         Remove language parameter.
5345         (ada_val_print): Update ada_val_print_1 call.
5346
5347 2019-05-08  Tom Tromey  <tromey@adacore.com>
5348
5349         * remote.c (remote_hw_watchpoint_limit)
5350         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5351         Now static.
5352
5353 2019-05-08  Tom Tromey  <tromey@adacore.com>
5354
5355         * maint.c (_initialize_maint_cmds): Move initialization code to
5356         remote.c.
5357         (watchdog, show_watchdog): Move to remote.c.
5358         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5359         "watchdog" static.
5360         (_initialize_remote): Move initialization code from maint.c.
5361         * defs.h (watchdog): Don't declare.
5362
5363 2019-05-08  Tom Tromey  <tromey@adacore.com>
5364
5365         * tui/tui-interp.c: Include main.h.
5366         * interps.c: Include main.h.
5367         * main.h (interpreter_p): Declare.
5368         * defs.h (interpreter_p): Don't declare.
5369
5370 2019-05-08  Tom Tromey  <tromey@adacore.com>
5371
5372         * dwarf2loc.c: Include dwarf2read.h.
5373         * defs.h (read_unsigned_leb128): Don't declare.
5374         * dwarf2read.h (read_unsigned_leb128): Declare.
5375
5376 2019-05-08  Tom Tromey  <tromey@adacore.com>
5377
5378         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5379         method.
5380
5381 2019-05-08  Tom Tromey  <tromey@adacore.com>
5382
5383         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5384         when no wrap column is set.
5385
5386 2019-05-08  Tom Tromey  <tromey@adacore.com>
5387
5388         * c-lang.c (c_get_string): Handle non-C-style arrays.
5389
5390 2019-05-08  Tom Tromey  <tromey@adacore.com>
5391
5392         * typeprint.c (print_offset_data::update): Print the bit offset,
5393         not the number of bits remaining.
5394
5395 2019-05-08  Tom Tromey  <tromey@adacore.com>
5396
5397         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5398         padding at end of comment.
5399
5400 2019-05-08  Tom Tromey  <tromey@adacore.com>
5401
5402         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5403         Compare main types.
5404
5405 2019-05-06  Tom Tromey  <tom@tromey.com>
5406
5407         * common/scoped_mmap.c: Include common-defs.h.
5408         * common/scoped_mmap.h: Don't include config.h.
5409
5410 2019-05-04  Tom Tromey  <tom@tromey.com>
5411
5412         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5413         (struct aarch64_call_info): Add initializers.
5414         <si>: Now a std::vector.
5415         (pass_on_stack, aarch64_push_dummy_call): Update.
5416
5417 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5418             Tom Tromey  <tom@tromey.com>
5419
5420         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5421         (ppc_threads): Now a std::vector.  Now static.
5422         (hwdebug_find_thread_points_by_tid)
5423         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5424         Update.
5425
5426 2019-05-04  Tom Tromey  <tom@tromey.com>
5427
5428         * arc-tdep.c (arc_tdesc_init): Return bool.
5429
5430 2019-05-04  Tom Tromey  <tom@tromey.com>
5431
5432         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5433         Use gdb_assert_not_reached.
5434
5435 2019-05-04  Tom Tromey  <tom@tromey.com>
5436
5437         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5438         "false".
5439
5440 2019-05-04  Tom Tromey  <tom@tromey.com>
5441
5442         * arc-tdep.c (arc_tdesc_init): Use bool.
5443
5444 2019-05-04  Tom Tromey  <tom@tromey.com>
5445
5446         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5447
5448 2019-05-04  Tom Tromey  <tom@tromey.com>
5449
5450         * cli/cli-cmds.c (valid_command_p): Return bool.
5451
5452 2019-05-04  Tom Tromey  <tom@tromey.com>
5453
5454         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5455         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5456
5457 2019-05-04  Raul Tambre  <raul@tambre.ee>
5458
5459         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5460         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5461         operator for comparison.
5462
5463 2019-05-04  Tom Tromey  <tom@tromey.com>
5464
5465         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5466         (lookup_partial_symbol, print_partial_symbols)
5467         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5468         (psymbol_compare): Update.
5469         (add_psymbol_to_bcache): Clear the entire psymbol.
5470         (maintenance_check_psymtabs): Update.
5471         * psympriv.h (struct partial_symbol): Don't derive from
5472         general_symbol_info.
5473         <obj_section, unrelocated_address, address,
5474         set_unrelocated_address>: Update.
5475         <ginfo>: New member.
5476         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5477         (debug_names::write_psymbols): Update.
5478
5479 2019-05-04  Tom de Vries  <tdevries@suse.de>
5480
5481         * contrib/cc-with-tweaks.sh: Support -n arg.
5482
5483 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5484
5485         * corelow.c (core_target::detach): Ensure frame cache and
5486         register caches are cleared.
5487         inferior.c (exit_inferior_1): Likewise.
5488
5489 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5490             Tom Tromey  <tom@tromey.com>
5491
5492         * dictionary.c (collate_pending_symbols_by_language): Remove
5493         "struct" from foreach.
5494         * symtab.c (lookup_global_symbol_from_objfile)
5495         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5496         foreach.
5497         * ser-tcp.c (net_open): Remove "struct" from foreach.
5498         * objfiles.c (objfile_relocate, objfile_rebase)
5499         (objfile_has_symbols): Remove "struct" from foreach.
5500         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5501         from foreach.
5502         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5503         foreach.
5504         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5505         "struct" from foreach.
5506         * ada-lang.c (create_excep_cond_exprs)
5507         (ada_exception_catchpoint_cond_string): Remove "struct" from
5508         foreach.
5509
5510 2019-05-03  Tom Tromey  <tromey@adacore.com>
5511
5512         * ada-exp.y (convert_char_literal): Check suffix of each
5513         enumerator.
5514
5515 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5516
5517         PR ada/21406:
5518         * ada-exp.y (yywrap): Don't define.
5519         * ada-lex.l (%option): Add noyywrap
5520         (yywrap): Remove.
5521
5522 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5523
5524         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5525         _WIN32_WINNT to the XP level, unless already defined to a higher
5526         level.
5527
5528         * unittests/parse-connection-spec-selftests.c:
5529         * ser-tcp.c:
5530         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5531         override.
5532
5533         * symfile.c (find_separate_debug_file): Remove colon from the
5534         drive spec of DOS/Windows file names of the target, so that the
5535         file name produced from DEBUGDIR and the target's directory will
5536         be valid on DOS/Windows systems.
5537
5538 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5539
5540         * rust-lang.c (val_print_struct): Handle printing structures
5541         containing strings.
5542
5543 2019-05-02  Tom Tromey  <tromey@adacore.com>
5544
5545         * valarith.c (_initialize_valarith): Remove.
5546
5547 2019-05-01  Tom Tromey  <tromey@adacore.com>
5548
5549         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5550         bitfields.
5551
5552 2019-05-01  Tom Tromey  <tromey@adacore.com>
5553
5554         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5555         for big-endian copies.
5556
5557 2019-04-30  Ali Tamur  <tamur@google.com>
5558         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5559         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5560         (read_3_bytes): New function.
5561
5562 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5563
5564         * windows-nat.c (main_thread_id): Delete.
5565         (handle_output_debug_string): Replace main_thread_id by
5566         current_event.dwThreadId.
5567         (fake_create_process): Likewise.
5568         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5569         Do not set main_thread_id.
5570         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5571         current_event.dwThreadId.
5572         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5573
5574 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5575
5576         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5577         Use current_event.dwThreadId instead of main_thread_id.
5578
5579 2019-04-30  Tom Tromey  <tromey@adacore.com>
5580
5581         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5582         (create_excep_cond_exprs): Iterate over program spaces.
5583         (ada_exception_catchpoint_cond_string): Examine all minimal
5584         symbols for exception types.
5585
5586 2019-04-30  Tom Tromey  <tromey@adacore.com>
5587
5588         PR c++/24470:
5589         * dwarf2read.c (process_structure_scope): Handle case where type
5590         has template parameters but no symbol was created.
5591
5592 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5593             Chris January  <chris.january@arm.com>
5594
5595         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5596         qualifier.
5597         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5598
5599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * f-typeprint.c (f_print_type): Update rules for printing
5602         whitespace.
5603         (f_type_print_varspec_suffix): Likewise.
5604
5605 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5606             Chris January  <chris.january@arm.com>
5607
5608         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5609         function arguments.
5610
5611 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * f-lang.c (build_fortran_types): Change name of void type to
5614         lower case.
5615         * f-typeprint.c (f_type_print_base): Print the name of the void
5616         type, rather than a fixed string.
5617         * f-valprint.c (f_decorations): Use lower case void string.
5618
5619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5620             Chris January  <chris.january@arm.com>
5621
5622         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5623         types for Fortran.
5624
5625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5626             Chris January  <chris.january@arm.com>
5627             David Lecomber  <david.lecomber@arm.com>
5628
5629         * f-exp.y (BINOP_INTRINSIC): New token.
5630         (exp): New parser rule handling BINOP_INTRINSIC.
5631         (f77_keywords): Add new builtin procedures.
5632         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5633         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5634         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5635         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5636         (print_unop_subexp_f): New function.
5637         (print_binop_subexp_f): New function.
5638         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5639         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5640         (dump_subexp_body_f): Likewise.
5641         (operator_check_f): Likewise.
5642         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5643         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5644
5645 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5648         UNOP_KIND.
5649         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5650         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5651         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5652         (operator_length_f): New fuction.
5653         (print_subexp_f): New function.
5654         (op_name_f): New function.
5655         (dump_subexp_body_f): New function.
5656         (operator_check_f): New function.
5657         (exp_descriptor_f): Replace standard expression handling functions
5658         with new functions.
5659         * gdb/fortran-operator.def: New file.
5660         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5661         * gdb/std-operator.def: Remove UNOP_KIND.
5662
5663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5664
5665         * std-operator.def: Remove unbalanced, stray double quote
5666         character.
5667
5668 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5669             Chris January  <chris.january@arm.com>
5670             Daniel Everett  <daniel.everett@arm.com>
5671             Nick Forrington  <nick.forrington@arm.com>
5672             Richard Bunt  <richard.bunt@arm.com>
5673
5674         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5675         of depth when printing anonymous structs or unions.
5676         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5677         Don't print either the top-level value, or the children if the
5678         max-depth is exceeded.
5679         (ppscm_print_children): When printing the key of a map, allow one
5680         extra level of depth.
5681         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5682         print either the top-level value, or the children if the max-depth
5683         is exceeded.
5684         (print_children): When printing the key of a map, allow one extra
5685         level of depth.
5686         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5687         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5688         (user_print_options): Initialise max_depth field.
5689         (val_print_scalar_or_string_type_p): New function.
5690         (val_print): Check to see if the max depth has been reached.
5691         (val_print_check_max_depth): Define new function.
5692         (show_print_max_depth): New function.
5693         (_initialize_valprint): Add 'print max-depth' option.
5694         * valprint.h (struct value_print_options) <max_depth>: New field.
5695         (val_print_check_max_depth): Declare new function.
5696         * NEWS: Document new feature.
5697
5698 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * ada-lang.c (ada_language_defn): Initialise new field.
5701         * c-lang.c (c_is_string_type_p): New function.
5702         (c_language_defn): Initialise new field.
5703         (cplus_language_defn): Initialise new field.
5704         (asm_language_defn): Initialise new field.
5705         (minimal_language_defn): Initialise new field.
5706         * c-lang.h (c_is_string_type_p): Declare new function.
5707         * d-lang.c (d_language_defn): Initialise new field.
5708         * f-lang.c (f_is_string_type_p): New function.
5709         (f_language_defn): Initialise new field.
5710         * go-lang.c (go_is_string_type_p): New function.
5711         (go_language_defn): Initialise new field.
5712         * language.c (default_is_string_type_p): New function.
5713         (unknown_language_defn): Initialise new field.
5714         (auto_language_defn): Initialise new field.
5715         * language.h (struct language_defn) <la_is_string_type_p>: New
5716         member variable.
5717         (default_is_string_type_p): Declare new function.
5718         * m2-lang.c (m2_language_defn): Initialise new field.
5719         * objc-lang.c (objc_language_defn): Initialise new field.
5720         * opencl-lang.c (opencl_language_defn): Initialise new field.
5721         * p-lang.c (pascal_is_string_type_p): New function.
5722         (pascal_language_defn): Initialise new field.
5723         * rust-lang.c (rust_is_string_type_p): New function.
5724         (rust_language_defn): Initialise new field.
5725
5726 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5729         New field.
5730         * ada-lang.c (ada_language_defn): Initialise new field.
5731         * c-lang.c (c_language_defn): Likewise.
5732         (cplus_language_defn): Likewise.
5733         (asm_language_defn): Likewise.
5734         (minimal_language_defn): Likewise.
5735         * d-lang.c (d_language_defn): Likewise.
5736         * f-lang.c (f_language_defn): Likewise.
5737         * go-lang.c (go_language_defn): Likewise.
5738         * language.c (unknown_language_defn): Likewise.
5739         (auto_language_defn): Likewise.
5740         * m2-lang.c (m2_language_defn): Likewise.
5741         * objc-lang.c (objc_language_defn): Likewise.
5742         * opencl-lang.c (opencl_language_defn): Likewise.
5743         * p-lang.c (pascal_language_defn): Likewise.
5744         * rust-lang.c (rust_language_defn): Likewise.
5745
5746 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5747
5748         * ada-lang.c (ada_is_character_type): Change return type to bool.
5749         (ada_is_string_type): Likewise.
5750         * ada-lang.h (ada_is_character_type): Update declaration
5751         (ada_is_string_type): Likewise.
5752
5753 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5754
5755         Support style in 'frame|thread apply'
5756
5757         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5758         * record.c (record_start, record_stop): Update callers of
5759         execute_command_to_string with false.
5760         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5761         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5762         methods.
5763         (class string_file): New constructor with term_out parameter.
5764         Override methods term_out and can_emit_style_escape.  New member
5765         term_out.
5766         (class stdio_file): Override can_emit_style_escape.
5767         (class tee_file): Override term_out and can_emit_style_escape.
5768         * utils.h (can_emit_style_escape): Remove.
5769         * utils.c (can_emit_style_escape): Likewise.
5770         Update all callers of can_emit_style_escape (SOMESTREAM) to
5771         SOMESTREAM->can_emit_style_escape.
5772         * source-cache.c (source_cache::get_source_lines): Likewise.
5773         * stack.c (frame_apply_command_count): Call execute_command_to_string
5774         passing the term_out characteristic of the current gdb_stdout.
5775         * thread.c (thr_try_catch_cmd): Likewise.
5776         * top.c (execute_command_to_string): pass term_out parameter
5777         to construct the string_file for the command output.
5778         * ui-file.c (term_cli_styling): New function (most code moved
5779         from utils.c can_emit_style_escape).
5780         (string_file::string_file, string_file::can_emit_style_escape,
5781         stdio_file::can_emit_style_escape, tee_file::term_out,
5782         tee_file::can_emit_style_escape): New functions.
5783
5784 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5785
5786         * NEWS: Mention the new set|show may-call-functions.
5787         * infcall.c (may_call_functions_p): New variable.
5788         (show_may_call_functions_p): New function.
5789         (call_function_by_hand_dummy): Throws an error if not
5790         may-call-functions.
5791         (_initialize_infcall): Call add_setshow_boolean_cmd for
5792         may-call-functions.
5793
5794 2019-04-25  Keith Seitz  <keiths@redhat.com>
5795
5796         PR c++/24367
5797         * cp-support.c (inspect_type): Don't attempt substitutions
5798         of symbol with the same name.
5799
5800 2019-04-25  Tom Tromey  <tromey@adacore.com>
5801
5802         PR gdb/24475:
5803         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5804         static.
5805
5806 2019-04-25  Tom Tromey  <tromey@adacore.com>
5807
5808         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5809         rvalue reference.
5810         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5811         (gdb_xml_parser::parse): Use std::move.
5812         * python/python-internal.h (gdbpy_convert_exception): Take a const
5813         reference.
5814         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5815         std::move.
5816         * python/py-utils.c (gdbpy_convert_exception): Take a const
5817         reference.
5818         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5819         Use std::move.
5820         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5821         Use std::move.
5822         * mi/mi-main.c (mi_print_exception): Take a const reference.
5823         * main.c (handle_command_errors): Take a const reference.
5824         * linespec.c (parse_linespec): Use std::move.
5825         * infcall.c (run_inferior_call): Use std::move.
5826         (call_function_by_hand_dummy): Use std::move.
5827         * exec.c (try_open_exec_file): Use std::move.
5828         * exceptions.h (exception_print, exception_fprintf)
5829         (exception_print_same): Update.
5830         * exceptions.c (print_exception, exception_print)
5831         (exception_fprintf, exception_print_same): Change parameters to
5832         const reference.
5833         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5834         * common/new-op.c: Use std::move.
5835         * common/common-exceptions.h (struct gdb_exception): Add move
5836         constructor.
5837         (struct gdb_exception_error, struct gdb_exception_quit, struct
5838         gdb_quit_bad_alloc): Change constructor to move constructor.
5839         (throw_exception): Change parameter to rvalue reference.
5840         * common/common-exceptions.c (throw_exception): Take rvalue
5841         reference.
5842         * cli/cli-interp.c (safe_execute_command): Use std::move.
5843         * breakpoint.c (insert_bp_location, location_to_sals): Use
5844         std::move.
5845
5846 2019-04-25  Tom Tromey  <tromey@adacore.com>
5847
5848         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5849         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5850         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5851         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5852         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5853         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5854         guile/scm-value.c: Use unpack.
5855         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5856         gdbscm_gdb_exception.
5857         (gdbscm_throw_gdb_exception): Likewise.
5858         (struct gdbscm_gdb_exception): New.
5859         (unpack): New function.
5860         (gdbscm_wrap): Use unpack.
5861
5862 2019-04-25  Tom Tromey  <tromey@adacore.com>
5863
5864         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5865         (gdb_rl_callback_handler): Use std::move.
5866         * common/common-exceptions.h (struct gdb_exception): Add move
5867         assignment operator.
5868         (throw_exception_sjlj): Change "exception" to const reference.
5869         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5870         (throw_exception_sjlj): Change "exception" to const reference.
5871
5872 2019-04-25  Tom Tromey  <tromey@adacore.com>
5873
5874         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5875         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5876         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5877         Update.
5878         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5879         Update.
5880         * mi/mi-interp.c (mi_interp::exec): Update.
5881         * linespec.c (parse_linespec): Update.
5882         * infcall.c (run_inferior_call): Update.
5883         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5884         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5885         (gdbscm_lookup_global_symbol): Update.
5886         * guile/scm-param.c (gdbscm_parameter_value): Update.
5887         * guile/scm-frame.c (gdbscm_frame_read_register)
5888         (gdbscm_frame_read_var): Update.
5889         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5890         * exec.c (try_open_exec_file): Update.
5891         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5892         (gdb_rl_callback_handler): Update.
5893         * common/common-exceptions.h (exception_none): Don't declare.
5894         * common/common-exceptions.c (exception_none): Don't define.
5895         (struct catcher) <exception>: Update.
5896         * cli/cli-interp.c (safe_execute_command): Update.
5897         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5898
5899 2019-04-25  Ali Tamur  <tamur@google.com>
5900
5901         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5902         (read_attribute_value): Likewise.
5903         (dwarf2_read_addr_index): Update comment.
5904         (read_str_index): Add DW_FORM_strx.
5905         (dwarf2_string_attr): Likewise.
5906         (dwarf2_const_value_attr): Likewise.
5907         (dump_die_shallow): Likewise.
5908         (dwarf2_fetch_constant_bytes): Likewise.
5909         (skip_form_bytes): Likewise.
5910         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5911
5912 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5913
5914         PR corefiles/11608
5915         PR corefiles/18187
5916         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5917         OFFSET.  Verify if current mapping contains an ELF header.
5918         (linux_find_memory_regions_full): Adjust call to
5919         dump_mapping_p.
5920
5921 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5922             Kang Li <kanglictf@gmail.com>
5923
5924         PR gdb/21600
5925
5926         * dwarf2-frame.c (read_initial_length): Be consistent about using
5927         unsigned representation of length.
5928         (decode_frame_entry_1): Likewise.  Check for wraparound of
5929         end pointer as well as buffer overflow.
5930
5931 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5932
5933         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5934         "vq".
5935
5936 2019-04-24  Tom Tromey  <tromey@adacore.com>
5937
5938         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5939
5940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * s12z-tdep.c (s12z_unwind_pc): Delete.
5943         (s12z_unwind_sp): Delete.
5944         (s12z_gdbarch_init): Don't register deleted functions with
5945         gdbarch.
5946
5947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5948
5949         * rl78-tdep.c (rl78_unwind_sp): Delete.
5950         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5951
5952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5953
5954         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5955         (xstormy16_unwind_pc): Delete.
5956         (xstormy16_dummy_id): Delete.
5957         (xstormy16_gdbarch_init): Don't register deleted functions with
5958         gdbarch.
5959
5960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * vax-tdep.c (vax_unwind_pc): Delete.
5963         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5964
5965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5966
5967         * v850-tdep.c (v850_unwind_sp): Delete.
5968         (v850_unwind_pc): Delete.
5969         (v850_dummy_id): Delete.
5970         (v850_gdbarch_init): Don't register deleted functions with
5971         gdbarch.
5972
5973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5976         (tilegx_unwind_pc): Delete.
5977         (tilegx_unwind_dummy_id): Delete.
5978         (tilegx_gdbarch_init): Don't register deleted functions with
5979         gdbarch.
5980
5981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5984         (tic6x_dummy_id): Delete.
5985         (tic6x_gdbarch_init): Don't register deleted functions with
5986         gdbarch.
5987
5988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5989
5990         * sparc-tdep.c (sparc_unwind_pc): Delete.
5991         (sparc32_gdbarch_init): Don't register deleted function with
5992         gdbarch.
5993
5994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5995
5996         * sh-tdep.c (sh_unwind_sp): Delete.
5997         (sh_unwind_pc): Delete.
5998         (sh_dummy_id): Delete.
5999         (sh_gdbarch_init): Don't register deleted functions with
6000         gdbarch.
6001
6002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * score-tdep.c (score_unwind_sp): Delete.
6005         (score_unwind_pc): Delete.
6006         (score_dummy_id): Delete.
6007         (score_gdbarch_init): Don't register deleted functions with
6008         gdbarch.
6009
6010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6011
6012         * rx-tdep.c (rx_unwind_pc): Delete.
6013         (rx_unwind_sp): Delete.
6014         (rx_dummy_id): Delete.
6015         (rx_gdbarch_init): Don't register deleted functions with
6016         gdbarch.  Update comment.
6017
6018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6021         (rs6000_dummy_id): Delete.
6022         (rs6000_gdbarch_init): Don't register deleted functions with
6023         gdbarch.
6024
6025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * or1k-tdep.c (or1k_dummy_id): Delete.
6028         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6029
6030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6031
6032         * nios2-tdep.c (nios2_dummy_id): Delete.
6033         (nios2_unwind_sp): Delete.
6034         (nios2_gdbarch_init): Don't register deleted functions with
6035         gdbarch.
6036
6037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6038
6039         * nds32-tdep.c (nds32_dummy_id): Delete.
6040         (nds32_unwind_pc): Delete.
6041         (nds32_unwind_sp): Delete.
6042         (nds32_gdbarch_init): Don't register deleted functions with
6043         gdbarch.
6044
6045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * msp430-tdep.c (msp430_unwind_pc): Delete.
6048         (msp430_unwind_sp): Delete.
6049         (msp430_dummy_id): Delete.
6050         (msp430_gdbarch_init): Don't register deleted functions with
6051         gdbarch.
6052
6053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * moxie-tdep.c (moxie_unwind_sp): Delete.
6056         (moxie_unwind_pc): Delete.
6057         (moxie_dummy_id): Delete.
6058         (moxie_gdbarch_init): Don't register deleted functions with
6059         gdbarch.
6060
6061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6064         (mn10300_unwind_pc): Delete.
6065         (mn10300_unwind_sp): Delete.
6066         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6067         mn10300_unwind_sp.
6068         (mn10300_frame_unwind_init): Don't register deleted functions with
6069         gdbarch.
6070
6071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * mep-tdep.c (mep_unwind_pc): Delete.
6074         (mep_unwind_sp): Delete.
6075         (mep_dummy_id): Delete.
6076         (mep_gdbarch_init): Don't register deleted functions with
6077         gdbarch.
6078
6079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6082         (m68hc11_unwind_sp): Delete.
6083         (m68hc11_gdbarch_init): Don't register deleted functions with
6084         gdbarch.
6085
6086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * m32r-tdep.c (m32r_unwind_sp): Delete.
6089         (m32r_unwind_pc): Delete.
6090         (m32r_dummy_id): Delete.
6091         (m32r_gdbarch_init): Don't register deleted functions with
6092         gdbarch.
6093
6094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6095
6096         * m32c-tdep.c (m32c_unwind_pc): Delete.
6097         (m32c_unwind_sp): Delete.
6098         (m32c_dummy_id): Delete.
6099         (m32c_gdbarch_init): Don't register deleted functions with
6100         gdbarch.
6101
6102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6103
6104         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6105         (lm32_unwind_pc): Delete.
6106         (lm32_dummy_id): Delete.
6107         (lm32_gdbarch_init): Don't register deleted functions with
6108         gdbarch.
6109
6110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6111
6112         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6113         (iq2000_unwind_pc): Delete.
6114         (iq2000_dummy_id): Delete.
6115         (iq2000_gdbarch_init): Don't register deleted functions with
6116         gdbarch.
6117
6118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6119
6120         * nds32-tdep.c (nds32_type_align): Delete.
6121         (nds32_push_dummy_call): Use type_align instead.
6122
6123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * arm-tdep.c (arm_type_align): Only handle vector override case.
6126         (arm_push_dummy_call): Use type_align.
6127         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6128
6129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6130
6131         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6132         case.
6133         (pass_on_stack): Use type_align.
6134         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6135         function.
6136
6137 2019-04-23  Tom Tromey  <tromey@adacore.com>
6138
6139         * dwarf2read.c (line_header::file_name_at): Remove unused
6140         overload.
6141
6142 2019-04-23  Tom de Vries  <tdevries@suse.de>
6143
6144         PR gdb/24438
6145         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6146         invocation.
6147
6148
6149 2019-03-27  Ali Tamur  <tamur@google.com>
6150
6151         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6152         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6153         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6154         (dwarf_expr_context::get_addr_index): Likewise
6155         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6156         (symbol_needs_eval_context::get_addr_index): Likewise
6157         (disassemble_dwarf_expression): Add DW_OP_addrx
6158         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6159         (read_cutu_die_from_dwo): Update comment
6160         (skip_one_die): Add DW_FORM_addrx
6161         (read_attribute_value): Likewise
6162         (var_decode_location): Add DW_OP_addrx
6163         (dwarf2_const_value_attr): Add DW_FORM_addrx
6164         (dump_die_shallow): Likewise
6165         (dwarf2_fetch_constant_bytes): Likewise
6166         (decode_locdesc): Add DW_OP_addrx
6167         (skip_form_bytes): Add DW_FORM_addrx
6168
6169 2019-04-22  Ali Tamur  <tamur@google.com>
6170
6171         * MAINTAINERS (Write After Approval): Add self.
6172
6173 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6174
6175         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6176         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6177         (open_symbol_file_object): Likewise.
6178         (svr4_default_sos): Add info parameter.
6179         (svr4_read_so_list): Likewise.
6180         (svr4_current_sos_direct): Adjust functions calls to pass down
6181         info.
6182         (svr4_current_sos_1): Add info parameter.
6183         (svr4_current_sos): Call get_svr4_info, pass info down to
6184         svr4_current_sos_1.
6185         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6186         get_svr4_info.
6187         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6188         get_svr4_info.
6189         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6190         to get_svr4_info.
6191         (probes_table_remove_objfile_probes): Likewise.
6192         (register_solib_event_probe): Add info parameter.
6193         (solist_update_incremental): Pass info parameter down to
6194         svr4_read_so_list.
6195         (disable_probes_interface): Add info parameter.
6196         (svr4_handle_solib_event): Pass current_program_space to
6197         get_svr4_info.  Adjust disable_probes_interface cleanup.
6198         (svr4_create_probe_breakpoints): Add info parameter, pass it
6199         down to register_solib_event_probe.
6200         (svr4_create_solib_event_breakpoints): Add info parameter,
6201         pass it down to svr4_create_probe_breakpoints.
6202         (enable_break): Pass info down to
6203         svr4_create_solib_event_breakpoints.
6204         (svr4_solib_create_inferior_hook): Pass current_program_space to
6205         get_svr4_info.
6206         (svr4_clear_solib): Likewise.
6207
6208 2019-04-22  Pedro Alves  <palves@redhat.com>
6209
6210         * solib-svr4.c (svr4_free_objfile_observer): New.
6211         (probe_and_action::objfile): New field.
6212         (probes_table_htab_remove_objfile_probes)
6213         (probes_table_remove_objfile_probes): New functions.
6214         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6215         in the new probe_and_action.  Don't store the probe in 'lookup'.
6216         (svr4_create_probe_breakpoints): Pass objfile to
6217         register_solib_event_probe.
6218         (_initialize_svr4_solib): Register a free_objfile observer.
6219
6220 2019-04-19  Tom Tromey  <tom@tromey.com>
6221
6222         * common/queue.h: Remove.
6223
6224 2019-04-19  Tom Tromey  <tom@tromey.com>
6225
6226         * event-loop.c: Don't include "common/queue.h".
6227
6228 2019-04-19  Tom Tromey  <tom@tromey.com>
6229
6230         * remote.c (remote_target): Use delete.
6231         * remote-notif.h: Include <list>, not "common/queue.h".
6232         (notif_client_p): Remove typedef.
6233         (remote_notif_state): Add constructor, destructor, initializer.
6234         <notif_queue>: Now a std::list.
6235         (remote_notif_state_xfree): Don't declare.
6236         * remote-notif.c (remote_notif_process, handle_notification)
6237         (remote_notif_state_allocate): Update.
6238         (~remote_notif_state): Rename from remote_notif_state_xfree.
6239
6240 2019-04-19  Tom Tromey  <tom@tromey.com>
6241
6242         * symfile.c (reread_symbols): Update.
6243         * objfiles.c (objfile_register_static_link)
6244         (objfile_lookup_static_link): Update
6245         (~objfile) Don't delete static_links.
6246         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6247
6248 2019-04-19  Tom Tromey  <tom@tromey.com>
6249
6250         * type-stack.h (struct type_stack) <insert>: Constify string.
6251         * type-stack.c (type_stack::insert): Constify string.
6252         * gdbtypes.h (lookup_template_type): Update.
6253         (address_space_name_to_int): Update.
6254         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6255         const.
6256         (lookup_template_type): Make name const.
6257         * c-exp.y: Update rules.
6258         (lex_one_token, classify_name, classify_inner_name)
6259         (c_print_token): Update.
6260         * p-exp.y: Update rules.
6261         (yylex): Update.
6262         * f-exp.y: Update rules.
6263         (yylex): Update.
6264         * d-exp.y: Update rules.
6265         (lex_one_token, classify_name, classify_inner_name): Update.
6266         * parse.c (write_dollar_variable, copy_name): Return std::string.
6267         * parser-defs.h (copy_name): Change return type.
6268         * m2-exp.y: Update rules.
6269         (yylex): Update.
6270         * go-exp.y (lex_one_token): Update.
6271         Update rules.
6272         (classify_unsafe_function, classify_packaged_name)
6273         (classify_name, yylex): Update.
6274
6275 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6276
6277         * configure.ac: add --enable-source-highlight switch.
6278         * configure: Regenerate.
6279         * top.c (print_gdb_version): plumb --enable-source-highlight
6280         status to "show configuration".
6281
6282 2019-04-19  Tom Tromey  <tromey@adacore.com>
6283
6284         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6285         Check ADA_TYPE_P.
6286         (empty_record, ada_template_to_fixed_record_type_1)
6287         (template_to_static_fixed_type)
6288         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6289         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6290         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6291         macros.
6292
6293 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6294
6295         PR symtab/24423:
6296         * source.c (print_source_lines_base): Advance "iter" when a
6297         control character is seen.
6298
6299 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6300
6301         * inferior.h (struct infcall_suspend_state_deleter):
6302         Catch exception in destructor to avoid crash.
6303
6304 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6305
6306         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6307         close to the add_com "shell".
6308
6309 2019-04-18  Tom Tromey  <tromey@adacore.com>
6310
6311         * process-stratum-target.h (class process_stratum_target)
6312         <stratum>: Add "final".
6313
6314 2019-04-17  Tom Tromey  <tromey@adacore.com>
6315
6316         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6317         against nullptr before use.
6318
6319 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6320
6321         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6322
6323 2019-04-17  Jim Wilson  <jimw@sifive.com>
6324             Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6327         code read might fail, assume 4-byte breakpoint in that case.
6328
6329 2019-04-15  Leszek Swirski  <leszeks@google.com>
6330
6331         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6332         rather than a hand-rolled POD check when checking for forced MEMORY
6333         classification.
6334
6335 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6336
6337         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6338         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6339         function.
6340         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6341         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6342         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6343         declaration.
6344
6345 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6346
6347         * aarch64-linux-nat.c
6348         (aarch64_linux_nat_target::thread_architecture): Add override.
6349         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6350         each VQ.
6351
6352 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6353
6354         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6355
6356 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6359         target types of size 96-bits, add some additional comments, and
6360         check that the builtin type we found was the correct size.
6361
6362 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6363
6364         * utils.c (prompt_for_continue): Don't restore the styling at the
6365         end, as applied_style has the wrong value.  This fixes styling in
6366         long lists of file names that are interrupted by the "Continue?"
6367         prompt.
6368
6369 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6370
6371         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6372         * c-lang.c (c_language_defn): Likewise.
6373         (cplus_language_defn): Likewise.
6374         (asm_language_defn): Likewise.
6375         (minimal_language_defn): Likewise.
6376         * d-lang.c (d_language_defn): Likewise.
6377         * f-lang.c (f_language_defn): Likewise.
6378         * go-lang.c (go_language_defn): Likewise.
6379         * language.c (unknown_language_defn): Likewise.
6380         (auto_language_defn): Likewise.
6381         * language.h (struct language_defn): Remove la_magic field.
6382         (LANG_MAGIC): Delete.
6383         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6384         * objc-lang.c (objc_language_defn): Likewise.
6385         * opencl-lang.c (opencl_language_defn): Likewise.
6386         * p-lang.c (pascal_language_defn): Likewise.
6387         * rust-lang.c (rust_language_defn): Likewise.
6388
6389 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * riscv-tdep.c (riscv_type_align): New function.
6392         (riscv_type_alignment): Delete.
6393         (riscv_arg_location): Use 'type_align'.
6394         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6395
6396 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * gdbtypes.c (type_align): A struct with no non-static fields also
6399         has alignment of 1.
6400
6401 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6404         component to 0.
6405         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6406         member.
6407         (riscv_struct_info::analyse): New implementation using new
6408         analyse_inner member function.
6409         (riscv_struct_info::field_offset): New member function.
6410         (riscv_struct_info::m_offsets): New member variable.
6411         (riscv_struct_info::analyse_inner): New private member function,
6412         takes the old implementation of riscv_struct_info::analyse but
6413         extended to track field offsets.
6414         (riscv_call_arg_struct): Update the struct folding special cases
6415         to handle cases where empty C++ structs, which are non-zero
6416         length, are found.
6417         (riscv_arg_location): Initialise the length of each location, a
6418         non-zero length now indicates the location is in use.
6419         (riscv_push_dummy_call): Allow for the first location having a
6420         non-zero offset when setting up arguments.
6421         (riscv_return_value): Likewise, but for return values.
6422
6423 2019-04-11  Tom Tromey  <tromey@adacore.com>
6424
6425         * utils.c (internal_vproblem): Make "msg" const.
6426
6427 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6428
6429         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6430         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6431         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6432         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6433
6434 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6435
6436         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6437         function.
6438         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6439         of amd64_collect_native_gregset.
6440         (amd64_linux_nat_target::store_registers): Likewise.
6441
6442 2019-04-10  Tom Tromey  <tom@tromey.com>
6443
6444         * symtab.c (lookup_global_symbol_from_objfile)
6445         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6446         * objfiles.h (class separate_debug_iterator): New.
6447         (class separate_debug_range): New.
6448         (struct objfile) <separate_debug_objfiles>: New method.
6449         (objfile_separate_debug_iterate): Don't declare.
6450         * objfiles.c (separate_debug_iterator::operator++): Rename from
6451         objfile_separate_debug_iterate.
6452         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6453         iterator.
6454         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6455         iterator.
6456
6457 2019-04-10  Tom Tromey  <tom@tromey.com>
6458
6459         * symfile.c (reread_symbols): Remove old comment.
6460         * objfiles.c (free_all_objfiles): Fix a typo.
6461
6462 2019-04-10  Tom Tromey  <tom@tromey.com>
6463
6464         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6465         * minsyms.c (lookup_minimal_symbol): Use foreach.
6466         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6467         (lookup_minimal_symbol_solib_trampoline): Likewise.
6468         * symfile.c (reread_symbols): Use foreach.
6469
6470 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6471             Tom Tromey  <tromey@adacore.com>
6472
6473         PR rust/24414:
6474         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6475         (rust_lex_int_test): Change "value" to be LONGEST.
6476         (rust_lex_tests): Add test for long integer literal.
6477
6478 2019-04-09  Tom Tromey  <tromey@adacore.com>
6479
6480         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6481         to bool.
6482         (extended_remote_target::attach): Update.
6483         (remote_target::remote_notice_new_inferior): Update.
6484         (remote_target::add_current_inferior_and_thread): Update.
6485         * inferior.c (exit_inferior_1): Use "false".
6486         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6487
6488 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6489
6490         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6491         the "start" command.
6492
6493 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6494
6495         * python/py-inferior.c (infpy_thread_from_thread_handle):
6496         Adjust comments to reflect renaming of thread_from_thread_handle
6497         to thread_from_handle.  Adjust keywords.  Fix type error message.
6498         (inferior_object_methods): Add thread_from_handle.  Retain
6499         thread_from_thread_handle, but mark it as deprecated.
6500
6501 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6502
6503         * gdbthread.h (find_thread_by_handle): Revise declaration.
6504         * thread.c (find_thread_by_handle): Likewise.  Adjust
6505         implementation too.
6506         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6507         support for buffer objects as handles.
6508
6509 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6510
6511         * python/py-infthread.c (thpy_thread_handle): New function.
6512         (thread_object_methods): Register thpy_thread_handle.
6513
6514 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6515
6516         * gdbthread.h (thread_to_thread_handle): Declare.
6517         * thread.c (gdbtypes.h): Include.
6518         (thread_to_thread_handle): New function.
6519
6520         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6521         (target_thread_info_to_thread_handle): Declare.
6522         * target.c (target_thread_info_to_thread_handle): New function.
6523         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6524         * target-delegates.c: Regenerate.
6525
6526         * linux-thread-db.c (class thread_db_target): Add method
6527         thread_info_to_thread_handle.
6528         (thread_db_target::thread_info_to_thread_handle): Define.
6529         * remote.c (class remote_target): Add new method
6530         thread_info_to_thread_handle.
6531         (remote_target::thread_info_to_thread_handle): Define.
6532
6533 2019-04-08  Pedro Alves  <palves@redhat.com>
6534
6535         * common/common-exceptions.c (throw_exception): Don't create
6536         named object to throw; throw directly.
6537         (throw_it): Likewise.  Don't initialize gdb_exception::message
6538         here, with new; pass FMT and AP to the ctor instead.
6539         * common/common-exceptions.h: Include <string>.
6540         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6541         const char *, va_list)): New ctor.  Use std::make_shared.
6542         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6543         errors)): Delete.
6544         (gdb_exception_error::gdb_exception_error(enum errors, const char
6545         *, va_list)): New.
6546         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6547         Add assertion.
6548         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6549         errors)): Delete.
6550         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6551         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6552         Add assertion.
6553
6554 2019-04-08  Tom Tromey  <tom@tromey.com>
6555
6556         * valops.c (value_rtti_indirect_type): Replace throw_exception
6557         with throw.
6558         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6559         with throw.
6560         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6561         throw.
6562         * target.c (target_translate_tls_address): Replace throw_exception
6563         with throw.
6564         * stack.c (frame_apply_command_count): Replace throw_exception
6565         with throw.
6566         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6567         throw.
6568         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6569         with throw.
6570         * rs6000-tdep.c (rs6000_frame_cache)
6571         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6572         * remote.c: Replace throw_exception with throw.
6573         * record-full.c (record_full_message, record_full_wait_1)
6574         (record_full_restore): Replace throw_exception with throw.
6575         * record-btrace.c:
6576         (get_thread_current_frame_id, record_btrace_start_replaying)
6577         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6578         (cmd_record_btrace_start): Replace throw_exception with throw.
6579         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6580         throw.
6581         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6582         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6583         * linespec.c:
6584         (find_linespec_symbols): Replace throw_exception with throw.
6585         * infrun.c (displaced_step_prepare, resume): Replace
6586         throw_exception with throw.
6587         * infcmd.c (post_create_inferior): Replace throw_exception with
6588         throw.
6589         * inf-loop.c (inferior_event_handler): Replace throw_exception
6590         with throw.
6591         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6592         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6593         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6594         (get_prev_frame_always, get_frame_pc_if_available)
6595         (get_frame_address_in_block_if_available, get_frame_language):
6596         Replace throw_exception with throw.
6597         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6598         throw_exception with throw.
6599         * eval.c (fetch_subexp_value, evaluate_var_value)
6600         (evaluate_funcall, evaluate_subexp_standard): Replace
6601         throw_exception with throw.
6602         * dwarf2loc.c (call_site_find_chain)
6603         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6604         Replace throw_exception with throw.
6605         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6606         with throw.
6607         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6608         throw.
6609         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6610         * completer.c (complete_line_internal): Replace throw_exception
6611         with throw.
6612         * compile/compile-object-run.c (compile_object_run): Replace
6613         throw_exception with throw.
6614         * cli/cli-script.c (process_next_line): Replace throw_exception
6615         with throw.
6616         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6617         (btrace_enable, btrace_maint_update_pt_packets): Replace
6618         throw_exception with throw.
6619         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6620         throw_exception with throw.
6621         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6622         throw_exception with throw.
6623         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6624         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6625         * aarch64-tdep.c (aarch64_make_prologue_cache)
6626         (aarch64_make_stub_cache): Replace throw_exception with throw.
6627
6628 2019-04-08  Tom Tromey  <tom@tromey.com>
6629
6630         * common/common-exceptions.c (throw_exception): Rename from
6631         throw_exception_cxx.  Remove old copy.  Make argument const.
6632         (throw_it): Create and throw exception objects directly.
6633         * common/common-exceptions.h (throw_exception): Make argument
6634         const.
6635         (struct gdb_exception_error): Add constructor.
6636         (struct gdb_exception_quit): Add constructor.
6637
6638 2019-04-08  Tom Tromey  <tom@tromey.com>
6639
6640         * common/common-exceptions.h (exception_rethrow): Don't declare.
6641         (TRY_SJLJ): Update comment.
6642         (TRY, CATCH, END_CATCH): Remove.
6643         * common/common-exceptions.c (exception_rethrow): Remove.
6644
6645 2019-04-08  Tom Tromey  <tom@tromey.com>
6646
6647         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6648         Remove.
6649         (gdb_exception_error): Rename from
6650         gdb_exception_RETURN_MASK_ERROR.
6651         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6652         (gdb_quit_bad_alloc): Update.
6653         * aarch64-tdep.c: Update.
6654         * ada-lang.c: Update.
6655         * ada-typeprint.c: Update.
6656         * ada-valprint.c: Update.
6657         * amd64-tdep.c: Update.
6658         * arch-utils.c: Update.
6659         * break-catch-throw.c: Update.
6660         * breakpoint.c: Update.
6661         * btrace.c: Update.
6662         * c-varobj.c: Update.
6663         * cli/cli-cmds.c: Update.
6664         * cli/cli-interp.c: Update.
6665         * cli/cli-script.c: Update.
6666         * common/common-exceptions.c: Update.
6667         * common/new-op.c: Update.
6668         * common/selftest.c: Update.
6669         * compile/compile-c-symbols.c: Update.
6670         * compile/compile-cplus-symbols.c: Update.
6671         * compile/compile-object-load.c: Update.
6672         * compile/compile-object-run.c: Update.
6673         * completer.c: Update.
6674         * corelow.c: Update.
6675         * cp-abi.c: Update.
6676         * cp-support.c: Update.
6677         * cp-valprint.c: Update.
6678         * darwin-nat.c: Update.
6679         * disasm-selftests.c: Update.
6680         * dtrace-probe.c: Update.
6681         * dwarf-index-cache.c: Update.
6682         * dwarf-index-write.c: Update.
6683         * dwarf2-frame-tailcall.c: Update.
6684         * dwarf2-frame.c: Update.
6685         * dwarf2loc.c: Update.
6686         * dwarf2read.c: Update.
6687         * eval.c: Update.
6688         * event-loop.c: Update.
6689         * event-top.c: Update.
6690         * exec.c: Update.
6691         * f-valprint.c: Update.
6692         * fbsd-tdep.c: Update.
6693         * frame-unwind.c: Update.
6694         * frame.c: Update.
6695         * gdbtypes.c: Update.
6696         * gnu-v3-abi.c: Update.
6697         * guile/guile-internal.h: Update.
6698         * guile/scm-block.c: Update.
6699         * guile/scm-breakpoint.c: Update.
6700         * guile/scm-cmd.c: Update.
6701         * guile/scm-disasm.c: Update.
6702         * guile/scm-frame.c: Update.
6703         * guile/scm-lazy-string.c: Update.
6704         * guile/scm-math.c: Update.
6705         * guile/scm-param.c: Update.
6706         * guile/scm-ports.c: Update.
6707         * guile/scm-pretty-print.c: Update.
6708         * guile/scm-symbol.c: Update.
6709         * guile/scm-symtab.c: Update.
6710         * guile/scm-type.c: Update.
6711         * guile/scm-value.c: Update.
6712         * i386-linux-tdep.c: Update.
6713         * i386-tdep.c: Update.
6714         * inf-loop.c: Update.
6715         * infcall.c: Update.
6716         * infcmd.c: Update.
6717         * infrun.c: Update.
6718         * jit.c: Update.
6719         * language.c: Update.
6720         * linespec.c: Update.
6721         * linux-fork.c: Update.
6722         * linux-nat.c: Update.
6723         * linux-tdep.c: Update.
6724         * linux-thread-db.c: Update.
6725         * main.c: Update.
6726         * mi/mi-cmd-break.c: Update.
6727         * mi/mi-cmd-stack.c: Update.
6728         * mi/mi-interp.c: Update.
6729         * mi/mi-main.c: Update.
6730         * objc-lang.c: Update.
6731         * p-valprint.c: Update.
6732         * parse.c: Update.
6733         * ppc-linux-tdep.c: Update.
6734         * printcmd.c: Update.
6735         * python/py-arch.c: Update.
6736         * python/py-breakpoint.c: Update.
6737         * python/py-cmd.c: Update.
6738         * python/py-finishbreakpoint.c: Update.
6739         * python/py-frame.c: Update.
6740         * python/py-framefilter.c: Update.
6741         * python/py-gdb-readline.c: Update.
6742         * python/py-inferior.c: Update.
6743         * python/py-infthread.c: Update.
6744         * python/py-lazy-string.c: Update.
6745         * python/py-linetable.c: Update.
6746         * python/py-objfile.c: Update.
6747         * python/py-param.c: Update.
6748         * python/py-prettyprint.c: Update.
6749         * python/py-progspace.c: Update.
6750         * python/py-record-btrace.c: Update.
6751         * python/py-record.c: Update.
6752         * python/py-symbol.c: Update.
6753         * python/py-type.c: Update.
6754         * python/py-unwind.c: Update.
6755         * python/py-utils.c: Update.
6756         * python/py-value.c: Update.
6757         * python/python.c: Update.
6758         * record-btrace.c: Update.
6759         * record-full.c: Update.
6760         * remote-fileio.c: Update.
6761         * remote.c: Update.
6762         * riscv-tdep.c: Update.
6763         * rs6000-aix-tdep.c: Update.
6764         * rs6000-tdep.c: Update.
6765         * rust-exp.y: Update.
6766         * rust-lang.c: Update.
6767         * s390-tdep.c: Update.
6768         * selftest-arch.c: Update.
6769         * solib-dsbt.c: Update.
6770         * solib-frv.c: Update.
6771         * solib-spu.c: Update.
6772         * solib-svr4.c: Update.
6773         * solib.c: Update.
6774         * sparc64-linux-tdep.c: Update.
6775         * stack.c: Update.
6776         * symfile-mem.c: Update.
6777         * symmisc.c: Update.
6778         * target.c: Update.
6779         * thread.c: Update.
6780         * top.c: Update.
6781         * tracefile-tfile.c: Update.
6782         * tui/tui.c: Update.
6783         * typeprint.c: Update.
6784         * unittests/cli-utils-selftests.c: Update.
6785         * unittests/parse-connection-spec-selftests.c: Update.
6786         * valops.c: Update.
6787         * valprint.c: Update.
6788         * value.c: Update.
6789         * varobj.c: Update.
6790         * windows-nat.c: Update.
6791         * x86-linux-nat.c: Update.
6792         * xml-support.c: Update.
6793
6794 2019-04-08  Tom Tromey  <tom@tromey.com>
6795
6796         * xml-support.c: Use C++ exception handling.
6797         * x86-linux-nat.c: Use C++ exception handling.
6798         * windows-nat.c: Use C++ exception handling.
6799         * varobj.c: Use C++ exception handling.
6800         * value.c: Use C++ exception handling.
6801         * valprint.c: Use C++ exception handling.
6802         * valops.c: Use C++ exception handling.
6803         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6804         handling.
6805         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6806         * typeprint.c: Use C++ exception handling.
6807         * tui/tui.c: Use C++ exception handling.
6808         * tracefile-tfile.c: Use C++ exception handling.
6809         * top.c: Use C++ exception handling.
6810         * thread.c: Use C++ exception handling.
6811         * target.c: Use C++ exception handling.
6812         * symmisc.c: Use C++ exception handling.
6813         * symfile-mem.c: Use C++ exception handling.
6814         * stack.c: Use C++ exception handling.
6815         * sparc64-linux-tdep.c: Use C++ exception handling.
6816         * solib.c: Use C++ exception handling.
6817         * solib-svr4.c: Use C++ exception handling.
6818         * solib-spu.c: Use C++ exception handling.
6819         * solib-frv.c: Use C++ exception handling.
6820         * solib-dsbt.c: Use C++ exception handling.
6821         * selftest-arch.c: Use C++ exception handling.
6822         * s390-tdep.c: Use C++ exception handling.
6823         * rust-lang.c: Use C++ exception handling.
6824         * rust-exp.y: Use C++ exception handling.
6825         * rs6000-tdep.c: Use C++ exception handling.
6826         * rs6000-aix-tdep.c: Use C++ exception handling.
6827         * riscv-tdep.c: Use C++ exception handling.
6828         * remote.c: Use C++ exception handling.
6829         * remote-fileio.c: Use C++ exception handling.
6830         * record-full.c: Use C++ exception handling.
6831         * record-btrace.c: Use C++ exception handling.
6832         * python/python.c: Use C++ exception handling.
6833         * python/py-value.c: Use C++ exception handling.
6834         * python/py-utils.c: Use C++ exception handling.
6835         * python/py-unwind.c: Use C++ exception handling.
6836         * python/py-type.c: Use C++ exception handling.
6837         * python/py-symbol.c: Use C++ exception handling.
6838         * python/py-record.c: Use C++ exception handling.
6839         * python/py-record-btrace.c: Use C++ exception handling.
6840         * python/py-progspace.c: Use C++ exception handling.
6841         * python/py-prettyprint.c: Use C++ exception handling.
6842         * python/py-param.c: Use C++ exception handling.
6843         * python/py-objfile.c: Use C++ exception handling.
6844         * python/py-linetable.c: Use C++ exception handling.
6845         * python/py-lazy-string.c: Use C++ exception handling.
6846         * python/py-infthread.c: Use C++ exception handling.
6847         * python/py-inferior.c: Use C++ exception handling.
6848         * python/py-gdb-readline.c: Use C++ exception handling.
6849         * python/py-framefilter.c: Use C++ exception handling.
6850         * python/py-frame.c: Use C++ exception handling.
6851         * python/py-finishbreakpoint.c: Use C++ exception handling.
6852         * python/py-cmd.c: Use C++ exception handling.
6853         * python/py-breakpoint.c: Use C++ exception handling.
6854         * python/py-arch.c: Use C++ exception handling.
6855         * printcmd.c: Use C++ exception handling.
6856         * ppc-linux-tdep.c: Use C++ exception handling.
6857         * parse.c: Use C++ exception handling.
6858         * p-valprint.c: Use C++ exception handling.
6859         * objc-lang.c: Use C++ exception handling.
6860         * mi/mi-main.c: Use C++ exception handling.
6861         * mi/mi-interp.c: Use C++ exception handling.
6862         * mi/mi-cmd-stack.c: Use C++ exception handling.
6863         * mi/mi-cmd-break.c: Use C++ exception handling.
6864         * main.c: Use C++ exception handling.
6865         * linux-thread-db.c: Use C++ exception handling.
6866         * linux-tdep.c: Use C++ exception handling.
6867         * linux-nat.c: Use C++ exception handling.
6868         * linux-fork.c: Use C++ exception handling.
6869         * linespec.c: Use C++ exception handling.
6870         * language.c: Use C++ exception handling.
6871         * jit.c: Use C++ exception handling.
6872         * infrun.c: Use C++ exception handling.
6873         * infcmd.c: Use C++ exception handling.
6874         * infcall.c: Use C++ exception handling.
6875         * inf-loop.c: Use C++ exception handling.
6876         * i386-tdep.c: Use C++ exception handling.
6877         * i386-linux-tdep.c: Use C++ exception handling.
6878         * guile/scm-value.c: Use C++ exception handling.
6879         * guile/scm-type.c: Use C++ exception handling.
6880         * guile/scm-symtab.c: Use C++ exception handling.
6881         * guile/scm-symbol.c: Use C++ exception handling.
6882         * guile/scm-pretty-print.c: Use C++ exception handling.
6883         * guile/scm-ports.c: Use C++ exception handling.
6884         * guile/scm-param.c: Use C++ exception handling.
6885         * guile/scm-math.c: Use C++ exception handling.
6886         * guile/scm-lazy-string.c: Use C++ exception handling.
6887         * guile/scm-frame.c: Use C++ exception handling.
6888         * guile/scm-disasm.c: Use C++ exception handling.
6889         * guile/scm-cmd.c: Use C++ exception handling.
6890         * guile/scm-breakpoint.c: Use C++ exception handling.
6891         * guile/scm-block.c: Use C++ exception handling.
6892         * guile/guile-internal.h: Use C++ exception handling.
6893         * gnu-v3-abi.c: Use C++ exception handling.
6894         * gdbtypes.c: Use C++ exception handling.
6895         * frame.c: Use C++ exception handling.
6896         * frame-unwind.c: Use C++ exception handling.
6897         * fbsd-tdep.c: Use C++ exception handling.
6898         * f-valprint.c: Use C++ exception handling.
6899         * exec.c: Use C++ exception handling.
6900         * event-top.c: Use C++ exception handling.
6901         * event-loop.c: Use C++ exception handling.
6902         * eval.c: Use C++ exception handling.
6903         * dwarf2read.c: Use C++ exception handling.
6904         * dwarf2loc.c: Use C++ exception handling.
6905         * dwarf2-frame.c: Use C++ exception handling.
6906         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6907         * dwarf-index-write.c: Use C++ exception handling.
6908         * dwarf-index-cache.c: Use C++ exception handling.
6909         * dtrace-probe.c: Use C++ exception handling.
6910         * disasm-selftests.c: Use C++ exception handling.
6911         * darwin-nat.c: Use C++ exception handling.
6912         * cp-valprint.c: Use C++ exception handling.
6913         * cp-support.c: Use C++ exception handling.
6914         * cp-abi.c: Use C++ exception handling.
6915         * corelow.c: Use C++ exception handling.
6916         * completer.c: Use C++ exception handling.
6917         * compile/compile-object-run.c: Use C++ exception handling.
6918         * compile/compile-object-load.c: Use C++ exception handling.
6919         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6920         * compile/compile-c-symbols.c: Use C++ exception handling.
6921         * common/selftest.c: Use C++ exception handling.
6922         * common/new-op.c: Use C++ exception handling.
6923         * cli/cli-script.c: Use C++ exception handling.
6924         * cli/cli-interp.c: Use C++ exception handling.
6925         * cli/cli-cmds.c: Use C++ exception handling.
6926         * c-varobj.c: Use C++ exception handling.
6927         * btrace.c: Use C++ exception handling.
6928         * breakpoint.c: Use C++ exception handling.
6929         * break-catch-throw.c: Use C++ exception handling.
6930         * arch-utils.c: Use C++ exception handling.
6931         * amd64-tdep.c: Use C++ exception handling.
6932         * ada-valprint.c: Use C++ exception handling.
6933         * ada-typeprint.c: Use C++ exception handling.
6934         * ada-lang.c: Use C++ exception handling.
6935         * aarch64-tdep.c: Use C++ exception handling.
6936
6937 2019-04-08  Tom Tromey  <tom@tromey.com>
6938
6939         * xml-support.c (gdb_xml_parser::parse): Update.
6940         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6941         * value.c (show_convenience): Update.
6942         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6943         (test_parse_flags_qcs): Update.
6944         * thread.c (thr_try_catch_cmd): Update.
6945         * target.c (target_translate_tls_address): Update.
6946         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6947         (info_frame_command_core, frame_apply_command_count): Update.
6948         * rust-exp.y (rust_lex_exception_test): Update.
6949         * riscv-tdep.c (riscv_print_one_register_info): Update.
6950         * remote.c (remote_target::enable_btrace): Update.
6951         * record-btrace.c (record_btrace_enable_warn): Update.
6952         * python/py-utils.c (gdbpy_convert_exception): Update.
6953         * printcmd.c (do_one_display, print_variable_and_value): Update.
6954         * mi/mi-main.c (mi_print_exception): Update.
6955         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6956         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6957         * linux-nat.c (linux_nat_target::attach): Update.
6958         * linux-fork.c (class scoped_switch_fork_info): Update.
6959         * infrun.c (displaced_step_prepare): Update.
6960         * infcall.c (call_function_by_hand_dummy): Update.
6961         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6962         * gnu-v3-abi.c (print_one_vtable): Update.
6963         * frame.c (get_prev_frame_always): Update.
6964         * f-valprint.c (info_common_command_for_block): Update.
6965         * exec.c (try_open_exec_file): Update.
6966         * exceptions.c (print_exception, exception_print)
6967         (exception_fprintf, exception_print_same): Update.
6968         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6969         * dwarf-index-cache.c (index_cache::store)
6970         (index_cache::lookup_gdb_index): Update.
6971         * darwin-nat.c (maybe_cache_shell): Update.
6972         * cp-valprint.c (cp_print_value_fields): Update.
6973         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6974         (gcc_cplus_symbol_address): Update.
6975         * compile/compile-c-symbols.c (gcc_convert_symbol)
6976         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6977         * common/selftest.c: Update.
6978         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6979         a std::string.
6980         (exception_try_scope_entry, exception_try_scope_exit): Don't
6981         declare.
6982         (struct exception_try_scope): Remove.
6983         (TRY): Don't use exception_try_scope.
6984         (struct gdb_exception): Add constructor, operator=.
6985         <what>: New method.
6986         (struct gdb_exception_RETURN_MASK_ALL)
6987         (struct gdb_exception_RETURN_MASK_ERROR)
6988         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6989         (struct gdb_quit_bad_alloc): Update.
6990         * common/common-exceptions.c (exception_none): Change
6991         initializer.
6992         (struct catcher) <state, exception>: Initialize inline.
6993         <prev>: Remove member.
6994         (current_catcher): Remove.
6995         (catchers): New global.
6996         (exceptions_state_mc_init): Simplify.
6997         (catcher_pop): Remove.
6998         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6999         (try_scope_depth, exception_try_scope_entry)
7000         (exception_try_scope_exit): Remove.
7001         (throw_exception_sjlj): Update.
7002         (exception_messages, exception_messages_size): Remove.
7003         (throw_it): Simplify.
7004         (gdb_exception_sliced_copy): Remove.
7005         (throw_exception_cxx): Update.
7006         * cli/cli-script.c (script_from_file): Update.
7007         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7008         Update.
7009         * ada-valprint.c (ada_val_print): Update.
7010         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7011         (create_excep_cond_exprs): Update.
7012
7013 2019-04-08  Tom Tromey  <tom@tromey.com>
7014
7015         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7016         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7017         (TRY, CATCH, END_CATCH): Remove some definitions.
7018         * common/common-exceptions.c: Don't use GDB_XCPT.
7019         (catcher_list_size): Remove.
7020         (throw_exception, throw_it): Simplify.
7021
7022 2019-04-05  Tom Tromey  <tom@tromey.com>
7023
7024         Revert the header-sorting patch.
7025         * ft32-tdep.c: Revert.
7026         * frv-tdep.c: Revert.
7027         * frv-linux-tdep.c: Revert.
7028         * frame.c: Revert.
7029         * frame-unwind.c: Revert.
7030         * frame-base.c: Revert.
7031         * fork-child.c: Revert.
7032         * findvar.c: Revert.
7033         * findcmd.c: Revert.
7034         * filesystem.c: Revert.
7035         * filename-seen-cache.h: Revert.
7036         * filename-seen-cache.c: Revert.
7037         * fbsd-tdep.c: Revert.
7038         * fbsd-nat.h: Revert.
7039         * fbsd-nat.c: Revert.
7040         * f-valprint.c: Revert.
7041         * f-typeprint.c: Revert.
7042         * f-lang.c: Revert.
7043         * extension.h: Revert.
7044         * extension.c: Revert.
7045         * extension-priv.h: Revert.
7046         * expprint.c: Revert.
7047         * exec.h: Revert.
7048         * exec.c: Revert.
7049         * exceptions.c: Revert.
7050         * event-top.c: Revert.
7051         * event-loop.c: Revert.
7052         * eval.c: Revert.
7053         * elfread.c: Revert.
7054         * dwarf2read.h: Revert.
7055         * dwarf2read.c: Revert.
7056         * dwarf2loc.c: Revert.
7057         * dwarf2expr.h: Revert.
7058         * dwarf2expr.c: Revert.
7059         * dwarf2-frame.c: Revert.
7060         * dwarf2-frame-tailcall.c: Revert.
7061         * dwarf-index-write.h: Revert.
7062         * dwarf-index-write.c: Revert.
7063         * dwarf-index-common.c: Revert.
7064         * dwarf-index-cache.h: Revert.
7065         * dwarf-index-cache.c: Revert.
7066         * dummy-frame.c: Revert.
7067         * dtrace-probe.c: Revert.
7068         * disasm.h: Revert.
7069         * disasm.c: Revert.
7070         * disasm-selftests.c: Revert.
7071         * dictionary.c: Revert.
7072         * dicos-tdep.c: Revert.
7073         * demangle.c: Revert.
7074         * dcache.h: Revert.
7075         * dcache.c: Revert.
7076         * darwin-nat.h: Revert.
7077         * darwin-nat.c: Revert.
7078         * darwin-nat-info.c: Revert.
7079         * d-valprint.c: Revert.
7080         * d-namespace.c: Revert.
7081         * d-lang.c: Revert.
7082         * ctf.c: Revert.
7083         * csky-tdep.c: Revert.
7084         * csky-linux-tdep.c: Revert.
7085         * cris-tdep.c: Revert.
7086         * cris-linux-tdep.c: Revert.
7087         * cp-valprint.c: Revert.
7088         * cp-support.c: Revert.
7089         * cp-namespace.c: Revert.
7090         * cp-abi.c: Revert.
7091         * corelow.c: Revert.
7092         * corefile.c: Revert.
7093         * continuations.c: Revert.
7094         * completer.h: Revert.
7095         * completer.c: Revert.
7096         * complaints.c: Revert.
7097         * coffread.c: Revert.
7098         * coff-pe-read.c: Revert.
7099         * cli-out.h: Revert.
7100         * cli-out.c: Revert.
7101         * charset.c: Revert.
7102         * c-varobj.c: Revert.
7103         * c-valprint.c: Revert.
7104         * c-typeprint.c: Revert.
7105         * c-lang.c: Revert.
7106         * buildsym.c: Revert.
7107         * buildsym-legacy.c: Revert.
7108         * build-id.h: Revert.
7109         * build-id.c: Revert.
7110         * btrace.c: Revert.
7111         * bsd-uthread.c: Revert.
7112         * breakpoint.h: Revert.
7113         * breakpoint.c: Revert.
7114         * break-catch-throw.c: Revert.
7115         * break-catch-syscall.c: Revert.
7116         * break-catch-sig.c: Revert.
7117         * blockframe.c: Revert.
7118         * block.c: Revert.
7119         * bfin-tdep.c: Revert.
7120         * bfin-linux-tdep.c: Revert.
7121         * bfd-target.c: Revert.
7122         * bcache.c: Revert.
7123         * ax-general.c: Revert.
7124         * ax-gdb.h: Revert.
7125         * ax-gdb.c: Revert.
7126         * avr-tdep.c: Revert.
7127         * auxv.c: Revert.
7128         * auto-load.c: Revert.
7129         * arm-wince-tdep.c: Revert.
7130         * arm-tdep.c: Revert.
7131         * arm-symbian-tdep.c: Revert.
7132         * arm-pikeos-tdep.c: Revert.
7133         * arm-obsd-tdep.c: Revert.
7134         * arm-nbsd-tdep.c: Revert.
7135         * arm-nbsd-nat.c: Revert.
7136         * arm-linux-tdep.c: Revert.
7137         * arm-linux-nat.c: Revert.
7138         * arm-fbsd-tdep.c: Revert.
7139         * arm-fbsd-nat.c: Revert.
7140         * arm-bsd-tdep.c: Revert.
7141         * arch-utils.c: Revert.
7142         * arc-tdep.c: Revert.
7143         * arc-newlib-tdep.c: Revert.
7144         * annotate.h: Revert.
7145         * annotate.c: Revert.
7146         * amd64-windows-tdep.c: Revert.
7147         * amd64-windows-nat.c: Revert.
7148         * amd64-tdep.c: Revert.
7149         * amd64-sol2-tdep.c: Revert.
7150         * amd64-obsd-tdep.c: Revert.
7151         * amd64-obsd-nat.c: Revert.
7152         * amd64-nbsd-tdep.c: Revert.
7153         * amd64-nbsd-nat.c: Revert.
7154         * amd64-nat.c: Revert.
7155         * amd64-linux-tdep.c: Revert.
7156         * amd64-linux-nat.c: Revert.
7157         * amd64-fbsd-tdep.c: Revert.
7158         * amd64-fbsd-nat.c: Revert.
7159         * amd64-dicos-tdep.c: Revert.
7160         * amd64-darwin-tdep.c: Revert.
7161         * amd64-bsd-nat.c: Revert.
7162         * alpha-tdep.c: Revert.
7163         * alpha-obsd-tdep.c: Revert.
7164         * alpha-nbsd-tdep.c: Revert.
7165         * alpha-mdebug-tdep.c: Revert.
7166         * alpha-linux-tdep.c: Revert.
7167         * alpha-linux-nat.c: Revert.
7168         * alpha-bsd-tdep.c: Revert.
7169         * alpha-bsd-nat.c: Revert.
7170         * aix-thread.c: Revert.
7171         * agent.c: Revert.
7172         * addrmap.c: Revert.
7173         * ada-varobj.c: Revert.
7174         * ada-valprint.c: Revert.
7175         * ada-typeprint.c: Revert.
7176         * ada-tasks.c: Revert.
7177         * ada-lang.c: Revert.
7178         * aarch64-tdep.c: Revert.
7179         * aarch64-ravenscar-thread.c: Revert.
7180         * aarch64-newlib-tdep.c: Revert.
7181         * aarch64-linux-tdep.c: Revert.
7182         * aarch64-linux-nat.c: Revert.
7183         * aarch64-fbsd-tdep.c: Revert.
7184         * aarch64-fbsd-nat.c: Revert.
7185         * aarch32-linux-nat.c: Revert.
7186
7187 2019-04-05  Tom Tromey  <tom@tromey.com>
7188
7189         * ft32-tdep.c: Sort headers.
7190         * frv-tdep.c: Sort headers.
7191         * frv-linux-tdep.c: Sort headers.
7192         * frame.c: Sort headers.
7193         * frame-unwind.c: Sort headers.
7194         * frame-base.c: Sort headers.
7195         * fork-child.c: Sort headers.
7196         * findvar.c: Sort headers.
7197         * findcmd.c: Sort headers.
7198         * filesystem.c: Sort headers.
7199         * filename-seen-cache.h: Sort headers.
7200         * filename-seen-cache.c: Sort headers.
7201         * fbsd-tdep.c: Sort headers.
7202         * fbsd-nat.h: Sort headers.
7203         * fbsd-nat.c: Sort headers.
7204         * f-valprint.c: Sort headers.
7205         * f-typeprint.c: Sort headers.
7206         * f-lang.c: Sort headers.
7207         * extension.h: Sort headers.
7208         * extension.c: Sort headers.
7209         * extension-priv.h: Sort headers.
7210         * expprint.c: Sort headers.
7211         * exec.h: Sort headers.
7212         * exec.c: Sort headers.
7213         * exceptions.c: Sort headers.
7214         * event-top.c: Sort headers.
7215         * event-loop.c: Sort headers.
7216         * eval.c: Sort headers.
7217         * elfread.c: Sort headers.
7218         * dwarf2read.h: Sort headers.
7219         * dwarf2read.c: Sort headers.
7220         * dwarf2loc.c: Sort headers.
7221         * dwarf2expr.h: Sort headers.
7222         * dwarf2expr.c: Sort headers.
7223         * dwarf2-frame.c: Sort headers.
7224         * dwarf2-frame-tailcall.c: Sort headers.
7225         * dwarf-index-write.h: Sort headers.
7226         * dwarf-index-write.c: Sort headers.
7227         * dwarf-index-common.c: Sort headers.
7228         * dwarf-index-cache.h: Sort headers.
7229         * dwarf-index-cache.c: Sort headers.
7230         * dummy-frame.c: Sort headers.
7231         * dtrace-probe.c: Sort headers.
7232         * disasm.h: Sort headers.
7233         * disasm.c: Sort headers.
7234         * disasm-selftests.c: Sort headers.
7235         * dictionary.c: Sort headers.
7236         * dicos-tdep.c: Sort headers.
7237         * demangle.c: Sort headers.
7238         * dcache.h: Sort headers.
7239         * dcache.c: Sort headers.
7240         * darwin-nat.h: Sort headers.
7241         * darwin-nat.c: Sort headers.
7242         * darwin-nat-info.c: Sort headers.
7243         * d-valprint.c: Sort headers.
7244         * d-namespace.c: Sort headers.
7245         * d-lang.c: Sort headers.
7246         * ctf.c: Sort headers.
7247         * csky-tdep.c: Sort headers.
7248         * csky-linux-tdep.c: Sort headers.
7249         * cris-tdep.c: Sort headers.
7250         * cris-linux-tdep.c: Sort headers.
7251         * cp-valprint.c: Sort headers.
7252         * cp-support.c: Sort headers.
7253         * cp-namespace.c: Sort headers.
7254         * cp-abi.c: Sort headers.
7255         * corelow.c: Sort headers.
7256         * corefile.c: Sort headers.
7257         * continuations.c: Sort headers.
7258         * completer.h: Sort headers.
7259         * completer.c: Sort headers.
7260         * complaints.c: Sort headers.
7261         * coffread.c: Sort headers.
7262         * coff-pe-read.c: Sort headers.
7263         * cli-out.h: Sort headers.
7264         * cli-out.c: Sort headers.
7265         * charset.c: Sort headers.
7266         * c-varobj.c: Sort headers.
7267         * c-valprint.c: Sort headers.
7268         * c-typeprint.c: Sort headers.
7269         * c-lang.c: Sort headers.
7270         * buildsym.c: Sort headers.
7271         * buildsym-legacy.c: Sort headers.
7272         * build-id.h: Sort headers.
7273         * build-id.c: Sort headers.
7274         * btrace.c: Sort headers.
7275         * bsd-uthread.c: Sort headers.
7276         * breakpoint.h: Sort headers.
7277         * breakpoint.c: Sort headers.
7278         * break-catch-throw.c: Sort headers.
7279         * break-catch-syscall.c: Sort headers.
7280         * break-catch-sig.c: Sort headers.
7281         * blockframe.c: Sort headers.
7282         * block.c: Sort headers.
7283         * bfin-tdep.c: Sort headers.
7284         * bfin-linux-tdep.c: Sort headers.
7285         * bfd-target.c: Sort headers.
7286         * bcache.c: Sort headers.
7287         * ax-general.c: Sort headers.
7288         * ax-gdb.h: Sort headers.
7289         * ax-gdb.c: Sort headers.
7290         * avr-tdep.c: Sort headers.
7291         * auxv.c: Sort headers.
7292         * auto-load.c: Sort headers.
7293         * arm-wince-tdep.c: Sort headers.
7294         * arm-tdep.c: Sort headers.
7295         * arm-symbian-tdep.c: Sort headers.
7296         * arm-pikeos-tdep.c: Sort headers.
7297         * arm-obsd-tdep.c: Sort headers.
7298         * arm-nbsd-tdep.c: Sort headers.
7299         * arm-nbsd-nat.c: Sort headers.
7300         * arm-linux-tdep.c: Sort headers.
7301         * arm-linux-nat.c: Sort headers.
7302         * arm-fbsd-tdep.c: Sort headers.
7303         * arm-fbsd-nat.c: Sort headers.
7304         * arm-bsd-tdep.c: Sort headers.
7305         * arch-utils.c: Sort headers.
7306         * arc-tdep.c: Sort headers.
7307         * arc-newlib-tdep.c: Sort headers.
7308         * annotate.h: Sort headers.
7309         * annotate.c: Sort headers.
7310         * amd64-windows-tdep.c: Sort headers.
7311         * amd64-windows-nat.c: Sort headers.
7312         * amd64-tdep.c: Sort headers.
7313         * amd64-sol2-tdep.c: Sort headers.
7314         * amd64-obsd-tdep.c: Sort headers.
7315         * amd64-obsd-nat.c: Sort headers.
7316         * amd64-nbsd-tdep.c: Sort headers.
7317         * amd64-nbsd-nat.c: Sort headers.
7318         * amd64-nat.c: Sort headers.
7319         * amd64-linux-tdep.c: Sort headers.
7320         * amd64-linux-nat.c: Sort headers.
7321         * amd64-fbsd-tdep.c: Sort headers.
7322         * amd64-fbsd-nat.c: Sort headers.
7323         * amd64-dicos-tdep.c: Sort headers.
7324         * amd64-darwin-tdep.c: Sort headers.
7325         * amd64-bsd-nat.c: Sort headers.
7326         * alpha-tdep.c: Sort headers.
7327         * alpha-obsd-tdep.c: Sort headers.
7328         * alpha-nbsd-tdep.c: Sort headers.
7329         * alpha-mdebug-tdep.c: Sort headers.
7330         * alpha-linux-tdep.c: Sort headers.
7331         * alpha-linux-nat.c: Sort headers.
7332         * alpha-bsd-tdep.c: Sort headers.
7333         * alpha-bsd-nat.c: Sort headers.
7334         * aix-thread.c: Sort headers.
7335         * agent.c: Sort headers.
7336         * addrmap.c: Sort headers.
7337         * ada-varobj.c: Sort headers.
7338         * ada-valprint.c: Sort headers.
7339         * ada-typeprint.c: Sort headers.
7340         * ada-tasks.c: Sort headers.
7341         * ada-lang.c: Sort headers.
7342         * aarch64-tdep.c: Sort headers.
7343         * aarch64-ravenscar-thread.c: Sort headers.
7344         * aarch64-newlib-tdep.c: Sort headers.
7345         * aarch64-linux-tdep.c: Sort headers.
7346         * aarch64-linux-nat.c: Sort headers.
7347         * aarch64-fbsd-tdep.c: Sort headers.
7348         * aarch64-fbsd-nat.c: Sort headers.
7349         * aarch32-linux-nat.c: Sort headers.
7350
7351 2019-04-04  Tom Tromey  <tom@tromey.com>
7352
7353         * varobj.c (varobj_create): Update.
7354         * rust-exp.y (struct rust_parser) <update_innermost_block,
7355         lookup_symbol>: New methods.
7356         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7357         Rename.
7358         (rust_parser::rust_lookup_type)
7359         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7360         * printcmd.c (display_command, do_one_display): Update.
7361         * parser-defs.h (struct parser_state) <parser_state>: Add
7362         "tracker" parameter.
7363         (block_tracker): New member.
7364         (class innermost_block_tracker) <innermost_block_tracker>: Add
7365         "types" parameter.
7366         <reset>: Remove method.
7367         (innermost_block): Don't declare.
7368         (null_post_parser): Update.
7369         * parse.c (innermost_block): Remove global.
7370         (write_dollar_variable): Update.
7371         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7372         Remove "tracker_types" parameter.
7373         (parse_expression): Add "tracker" parameter.
7374         (parse_expression_for_completion): Update.
7375         (null_post_parser): Add "tracker" parameter.
7376         * p-exp.y: Update rules.
7377         * m2-exp.y: Update rules.
7378         * language.h (struct language_defn) <la_post_parser>: Add
7379         "tracker" parameter.
7380         * go-exp.y: Update rules.
7381         * f-exp.y: Update rules.
7382         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7383         parameter.
7384         * d-exp.y: Update rules.
7385         * c-exp.y: Update rules.
7386         * breakpoint.c (set_breakpoint_condition): Create an
7387         innermost_block_tracker.
7388         (watch_command_1): Likewise.
7389         * ada-lang.c (resolve): Add "tracker" parameter.
7390         (resolve_subexp): Likewise.
7391         * ada-exp.y (write_var_from_sym): Update.
7392
7393 2019-04-04  Tom Tromey  <tom@tromey.com>
7394
7395         * type-stack.h: New file.
7396         * type-stack.c: New file.
7397         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7398         type-stack.h.
7399         (insert_into_type_stack, insert_type, push_type, push_type_int)
7400         (insert_type_address_space, pop_type, pop_type_int)
7401         (pop_typelist, pop_type_stack, append_type_stack)
7402         (push_type_stack, get_type_stack, push_typelist)
7403         (follow_type_instance_flags, follow_types): Don't declare.
7404         * parse.c (type_stack): Remove global.
7405         (parse_exp_in_context): Update.
7406         (insert_into_type_stack, insert_type, push_type, push_type_int)
7407         (insert_type_address_space, pop_type, pop_type_int)
7408         (pop_typelist, pop_type_stack, append_type_stack)
7409         (push_type_stack, get_type_stack, push_typelist)
7410         (follow_type_instance_flags, follow_types): Remove (moved to
7411         type-stack.c).
7412         * f-exp.y (type_stack): New global.
7413         Update rules.
7414         (push_kind_type, f_parse): Update.
7415         * d-exp.y (type_stack): New global.
7416         Update rules.
7417         (d_parse): Update.
7418         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7419         Update rules.
7420         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7421         (HFILES_NO_SRCDIR): Add type-stack.h.
7422
7423 2019-04-04  Tom Tromey  <tom@tromey.com>
7424
7425         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7426         (rust_parser::convert_ast_to_expression, rust_parse)
7427         (rust_lex_test_completion, rust_lex_tests): Update.
7428         * parser-defs.h (struct expr_completion_state): New.
7429         (struct parser_state) <parser_state>: Add completion parameter.
7430         <mark_struct_expression, mark_completion_tag>: New methods.
7431         <parse_completion, m_completion_state>: New members.
7432         (prefixify_expression, null_post_parser): Update.
7433         (mark_struct_expression, mark_completion_tag): Don't declare.
7434         * parse.c (parse_completion, expout_last_struct)
7435         (expout_tag_completion_type, expout_completion_name): Remove
7436         globals.
7437         (parser_state::mark_struct_expression)
7438         (parser_state::mark_completion_tag): Now methods.
7439         (prefixify_expression): Add last_struct parameter.
7440         (prefixify_subexp): Likewise.
7441         (parse_exp_1): Update.
7442         (parse_exp_in_context): Add cstate parameter.  Update.
7443         (parse_expression_for_completion): Create an
7444         expr_completion_state.
7445         (null_post_parser): Add "completion" parameter.
7446         * p-exp.y: Update rules.
7447         (yylex): Update.
7448         * language.h (struct language_defn) <la_post_parser>: Add
7449         "completing" parameter.
7450         * go-exp.y: Update rules.
7451         (lex_one_token): Update.
7452         * expression.h (parse_completion): Don't declare.
7453         * d-exp.y: Update rules.
7454         (lex_one_token): Update rules.
7455         * c-exp.y: Update rules.
7456         (lex_one_token): Update.
7457         * ada-lang.c (resolve): Add "parse_completion" parameter.
7458         (resolve_subexp): Likewise.
7459         (ada_resolve_function): Likewise.
7460
7461 2019-04-04  Tom Tromey  <tom@tromey.com>
7462
7463         * parser-defs.h (struct parser_state) <start_arglist,
7464         end_arglist>: New methods.
7465         <arglist_len, m_funcall_chain>: New members.
7466         (arglist_len, start_arglist, end_arglist): Don't declare.
7467         * parse.c (arglist_len, funcall_chain): Remove global.
7468         (start_arglist, end_arglist): Remove functions.
7469         (parse_exp_in_context): Update.
7470         * p-exp.y: Update rules.
7471         * m2-exp.y: Update rules.
7472         * go-exp.y: Update rules.
7473         * f-exp.y: Update rules.
7474         * d-exp.y: Update rules.
7475         * c-exp.y: Update rules.
7476
7477 2019-04-04  Tom Tromey  <tom@tromey.com>
7478
7479         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7480         lex_operator, push_back>: New methods.
7481         Update all rules.
7482         (rust_parser::lex_hex, lex_escape): Rename and update.
7483         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7484         (rust_parser::lex_operator): Rename and update.
7485         (rust_parser::lex_number, rustyylex, rustyyerror)
7486         (rust_lex_test_init, rust_lex_test_sequence)
7487         (rust_lex_test_push_back, rust_lex_tests): Update.
7488         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7489         parameter.
7490         <lexptr, prev_lexptr>: New members.
7491         (lexptr, prev_lexptr): Don't declare.
7492         * parse.c (lexptr, prev_lexptr): Remove globals.
7493         (parse_exp_in_context): Update.
7494         * p-exp.y (yylex, yyerror): Update.
7495         * m2-exp.y (parse_number, yylex, yyerror): Update.
7496         * go-exp.y (lex_one_token, yyerror): Update.
7497         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7498         * d-exp.y (lex_one_token, yyerror): Update.
7499         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7500         (lex_one_token, yyerror): Update.
7501         * ada-lex.l (YY_INPUT): Update.
7502         (rewind_to_char): Update.
7503         * ada-exp.y (yyerror): Update.
7504
7505 2019-04-04  Tom Tromey  <tom@tromey.com>
7506
7507         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7508         * parser-defs.h (struct parser_state) <parser_state>: Add new
7509         parameter.
7510         <comma_terminates>: New member.
7511         (comma_terminates): Don't declare global.
7512         * parse.c (comma_terminates): Remove global.
7513         (parse_exp_in_context): Update.
7514         * p-exp.y (yylex): Update.
7515         * m2-exp.y (yylex): Update.
7516         * go-exp.y (lex_one_token): Update.
7517         * f-exp.y (yylex): Update.
7518         * d-exp.y (lex_one_token): Update.
7519         * c-exp.y (lex_one_token): Update.
7520         * ada-lex.l: Update.
7521
7522 2019-04-04  Tom Tromey  <tom@tromey.com>
7523
7524         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7525         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7526         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7527         * parser-defs.h (paren_depth): Don't declare.
7528         * parse.c (paren_depth): Remove global.
7529         (parse_exp_in_context): Update.
7530         * p-exp.y (paren_depth): New global.
7531         (pascal_parse): Initialize it.
7532         * m2-exp.y (paren_depth): New global.
7533         (m2_parse): Initialize it.
7534         * go-exp.y (paren_depth): New global.
7535         (go_parse): Initialize it.
7536         * f-exp.y (paren_depth): New global.
7537         (f_parse): Initialize it.
7538         * d-exp.y (paren_depth): New global.
7539         (d_parse): Initialize it.
7540         * c-exp.y (paren_depth): New global.
7541         (c_parse): Initialize it.
7542         * ada-lex.l (paren_depth): New global.
7543         (lexer_init): Initialize it.
7544
7545 2019-04-04  Tom Tromey  <tom@tromey.com>
7546
7547         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7548         (rust_parser::convert_ast_to_type)
7549         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7550         * parser-defs.h (struct parser_state) <parser_state>: Add
7551         parameters.  Initialize new members.
7552         <expression_context_block, expression_context_pc>: New members.
7553         * parse.c (expression_context_block, expression_context_pc):
7554         Remove globals.
7555         (parse_exp_in_context): Update.
7556         * p-exp.y: Update all rules.
7557         (yylex): Update.
7558         * m2-exp.y: Update all rules.
7559         (yylex): Update.
7560         * go-exp.y (yylex): Update.
7561         * f-exp.y (yylex): Update.
7562         * d-exp.y: Update all rules.
7563         (yylex): Update.
7564         * c-exp.y: Update all rules.
7565         (lex_one_token, classify_name, yylex, c_parse): Update.
7566         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7567
7568 2019-04-04  Tom Tromey  <tom@tromey.com>
7569
7570         * gdbarch.h, gdbarch.c: Rebuild.
7571         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7572         * stap-probe.h:
7573         (struct stap_parse_info): Replace "parser_state" with
7574         "expr_builder".
7575         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7576         (parser_state): New class.
7577         * parse.c (expr_builder): Rename.
7578         (expr_builder::release): Rename.
7579         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7580         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7581         (write_exp_elt_longcst, write_exp_elt_floatcst)
7582         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7583         (write_exp_string_vector, write_exp_bitstring)
7584         (write_exp_msymbol, mark_struct_expression)
7585         (write_dollar_variable)
7586         (insert_type_address_space, increase_expout_size): Replace
7587         "parser_state" with "expr_builder".
7588         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7589         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7590         "parser_state" with "expr_builder".
7591
7592 2019-04-04  Tom Tromey  <tom@tromey.com>
7593
7594         * rust-exp.y: Replace "parse_language" with method call.
7595         * p-exp.y:
7596         (yylex): Replace "parse_language" with method call.
7597         * m2-exp.y:
7598         (yylex): Replace "parse_language" with method call.
7599         * go-exp.y (classify_name): Replace "parse_language" with method
7600         call.
7601         * f-exp.y (yylex): Replace "parse_language" with method call.
7602         * d-exp.y (lex_one_token): Replace "parse_language" with method
7603         call.
7604         * c-exp.y:
7605         (lex_one_token, classify_name, yylex): Replace "parse_language"
7606         with method call.
7607         * ada-exp.y (find_primitive_type, type_char)
7608         (type_system_address): Replace "parse_language" with method call.
7609
7610 2019-04-04  Tom Tromey  <tom@tromey.com>
7611
7612         * rust-exp.y: Replace "parse_gdbarch" with method call.
7613         * parse.c (write_dollar_variable, insert_type_address_space):
7614         Replace "parse_gdbarch" with method call.
7615         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7616         call.
7617         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7618         call.
7619         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7620         "parse_gdbarch" with method call.
7621         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7622         with method call.
7623         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7624         "parse_gdbarch" with method call.
7625         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7626         "parse_gdbarch" with method call.
7627         * c-exp.y (parse_type, parse_number, classify_name): Replace
7628         "parse_gdbarch" with method call.
7629         * ada-lex.l: Replace "parse_gdbarch" with method call.
7630         * ada-exp.y (parse_type, find_primitive_type, type_char)
7631         (type_system_address): Replace "parse_gdbarch" with method call.
7632
7633 2019-04-04  Tom Tromey  <tom@tromey.com>
7634
7635         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7636         * stap-probe.c (stap_parse_argument): Update.
7637         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7638         initial_size parameter.
7639         * rust-exp.y (rust_lex_tests): Update.
7640         * parse.c (parser_state): Update.
7641         (parse_exp_in_context): Update.
7642         * parser-defs.h (struct parser_state) <parser_state>: Remove
7643         "initial_size" parameter.
7644
7645 2019-04-04  Tom Tromey  <tom@tromey.com>
7646
7647         * parser-defs.h (increase_expout_size): Don't declare.
7648         * parse.c (increase_expout_size): Now static.
7649
7650 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7651
7652         * gnu-nat.c (gnu_nat_target::wait): Fix
7653         target_waitstatus_to_string call.
7654
7655 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7656
7657         * eval.c (evaluate_subexp_standard): Handle internal functions
7658         during Fortran function call handling.
7659
7660 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * NEWS: Mention new internal functions.
7663         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7664         (read_base_type): Use dwarf2_init_complex_target_type.
7665         * value.c (creal_internal_fn): New function.
7666         (cimag_internal_fn): New function.
7667         (_initialize_values): Register new internal functions.
7668
7669 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7670
7671         * infrun.c (stop_all_threads): If debug_infrun, always
7672         trace the wait status after wait_one, using
7673         target_waitstatus_to_string and target_pid_to_str.
7674         (handle_inferior_event): Replace various trace of
7675         wait status kind by a single trace.
7676         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7677         wait status kind image by target_waitstatus_to_string.
7678         * target/waitstatus.c (target_waitstatus_to_string): Fix
7679         obsolete comment.
7680
7681 2019-04-01  Tom Tromey  <tromey@adacore.com>
7682
7683         PR symtab/23331:
7684         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7685
7686 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7687             Pedro Alves  <palves@redhat.com>
7688
7689         * top.c (quit_force): Call 'finalize_values'.
7690         * value.c (finalize_values): New function.
7691         * value.h (finalize_values): Declare.
7692
7693 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7694
7695         * NEWS: Announce $_gdb_major and $_gdb_minor.
7696
7697         * top.c (init_gdb_version_vars): New function.
7698         (gdb_init): Call init_gdb_version_vars.
7699
7700 2019-03-29  Tom Tromey  <tromey@adacore.com>
7701
7702         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7703         help text.  Remove dead code.
7704
7705 2019-03-29  Keith Seitz  <keiths@redhat.com>
7706
7707         From Siddhesh Poyarekar:
7708         * f-lang.h (f77_get_upperbound): Return LONGEST.
7709         (f77_get_lowerbound): Likewise.
7710         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7711         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7712         print them.
7713         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7714         plongest to format print it.
7715         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7716         (f77_get_upperbound): Likewise.
7717         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7718         LOWER_BOUND to LONGEST.
7719         (f77_create_arrayprint_offset_tbl): Likewise.
7720
7721 2019-03-29  Keith Seitz  <keiths@redhat.com>
7722
7723         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7724         %s/pulongest for TYPE_LENGTH instead of %d in format
7725         strings.
7726         * ada-typerint.c (ada_print_type): Likewise.
7727         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7728         * compile/compile-c-support.c (generate_register_struct): Likewise.
7729         * gdbtypes.c (recursive_dump_type): Likewise.
7730         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7731         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7732         instead of %d in format strings.
7733         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7734         to std::min to ULONGEST.
7735         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7736         instead of %d in format strings.
7737         * tracepoint.c (info_scope_command): Likewise.
7738         * typeprint.c (print_offset_data::update)
7739         (print_offset_data::finish): Likewise.
7740         * xtensa-tdep.c (xtensa_store_return_value)
7741         (xtensa_push_dummy_call): Likewise.
7742
7743 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7744
7745         * windows-nat.c (display_selector): Fixed format specifications
7746         for 64-bit Cygwin.
7747
7748 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7749
7750         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7751
7752 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7753
7754         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7755         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7756         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7757         (nios2_linux_init_abi): Install it.
7758
7759 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7760
7761         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7762
7763 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7764
7765         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7766
7767 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7768             Tom Tromey  <tromey@adacore.com>
7769
7770         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7771
7772 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7773
7774         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7775         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7776         method to compute the bounds of range types. Also print "[evaluated]"
7777         if the bounds' values come from a dynamic evaluation.
7778
7779 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7782         whitespace when pretty printing is on.
7783
7784 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7785
7786         * ppc-linux-nat.c: Add include.
7787
7788 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7789
7790         * NEWS: Mention AArch64 Pointer Authentication.
7791
7792 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7793
7794         * arm-linux-nat.c: Add include.
7795
7796 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7797
7798         * source-cache.c (source_cache::get_source_lines): Re-read
7799         fullname after calling open_source_file.
7800
7801 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7802
7803         * NEWS: Mention TLS support for FreeBSD.
7804
7805 2019-03-25  Tom Tromey  <tromey@adacore.com>
7806
7807         * minsyms.c (BUNCH_SIZE): Update comment.
7808         (~minimal_symbol_reader): Remove old comment.
7809         (compact_minimal_symbols): Update comment.
7810         (minimal_symbol_reader::install): Remove old comment.  Update
7811         other comments.
7812
7813 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7814
7815         * s390-linux-nat.c: Add include.
7816
7817 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7818
7819         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7820         Call linux_get_hwcap.
7821         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7822         Likewise.
7823         (aarch64_linux_get_hwcap): Remove function.
7824         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7825         declaration.
7826         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7827         linux_get_hwcap.
7828         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7829         * linux-tdep.c (linux_get_hwcap): Add function.
7830         (linux_get_hwcap2): Likewise.
7831         * linux-tdep.h (linux_get_hwcap): Add declaration.
7832         (linux_get_hwcap2): Likewise.
7833         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7834         (ppc_linux_get_hwcap2): Likewise.
7835         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7836         linux_get_hwcap.
7837         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7838         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7839         (ppc_linux_nat_target::read_description): Likewise.
7840         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7841         * s390-linux-nat.c: Likewise.
7842         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7843
7844 2019-03-24  Tom Tromey  <tom@tromey.com>
7845
7846         * ada-lang.c (standard_lookup): Simplify initialization.
7847         (ada_lookup_symbol_nonlocal): Simplify return.
7848         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7849         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7850         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7851         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7852         initialization.
7853         * solib.c (solib_global_lookup): Simplify.
7854         * symtab.c (null_block_symbol): Remove.
7855         (symbol_cache_lookup): Simplify returns.
7856         (lookup_language_this): Simplify returns.
7857         (lookup_symbol_aux): Simplify return.
7858         (lookup_local_symbol): Simplify returns.
7859         (lookup_global_symbol_from_objfile): Simplify return.
7860         (lookup_symbol_in_objfile_symtabs)
7861         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7862         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7863         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7864         * cp-namespace.c (cp_lookup_bare_symbol)
7865         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7866         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7867         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7868         (cp_lookup_symbol_via_imports): Simplify initialization.
7869         (find_symbol_in_baseclass): Likewise.
7870         * symtab.h (null_block_symbol): Remove.
7871         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7872         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7873         (d_lookup_symbol_module): Likewise.
7874         (find_symbol_in_baseclass): Simplify initialization.
7875
7876 2019-03-24  Tom Tromey  <tom@tromey.com>
7877
7878         * expression.h: Don't include symtab.h.
7879         (struct block): Forward declare.
7880
7881 2019-03-24  Tom Tromey  <tom@tromey.com>
7882
7883         * c-exp.y (typebase): Remove casts.
7884         * gdbtypes.c (lookup_unsigned_typename, )
7885         (lookup_signed_typename): Remove cast.
7886         * eval.c (parse_to_comma_and_eval): Remove cast.
7887         * parse.c (write_dollar_variable): Remove cast.
7888         * block.h (struct block) <superblock>: Now const.
7889         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7890         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7891         (map_block): Make "block" const.
7892         * symfile.h (struct quick_symbol_functions)
7893         <map_matching_symbols>: Constify block argument to "callback".
7894         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7895         const.
7896         (find_pc_sect_compunit_symtab): Make "b" const.
7897         (find_symbol_at_address): Likewise.
7898         (search_symbols): Likewise.
7899         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7900         (dw2_debug_names_lookup_symbol): Likewise.
7901         (dw2_map_matching_symbols): Update.
7902         * p-valprint.c (pascal_val_print): Remove "block".
7903         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7904         (aux_add_nonlocal_symbols): Make "block" const.
7905         (resolve_subexp): Remove cast.
7906         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7907         const.
7908         (iterate_over_file_blocks): Likewise.
7909         * f-exp.y (%union) <bval>: Remove.
7910         * coffread.c (patch_opaque_types): Make "b" const.
7911         * spu-tdep.c (spu_catch_start): Make "block" const.
7912         * c-valprint.c (print_unpacked_pointer): Remove "block".
7913         * symmisc.c (dump_symtab_1): Make "b" const.
7914         (block_depth): Make "block" const.
7915         * d-exp.y (%union) <bval>: Remove.
7916         * cp-support.h (cp_lookup_rtti_type): Update.
7917         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7918         * psymtab.c (psym_lookup_symbol): Make "block" const.
7919         (maintenance_check_psymtabs): Make "b" const.
7920         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7921         (enumerate_locals, enumerate_args): Update.
7922         * python/py-symtab.c (stpy_global_block): Make "block" const.
7923         (stpy_static_block): Likewise.
7924         * inline-frame.c (block_starting_point_at): Make "new_block"
7925         const.
7926         * block.c (find_block_in_blockvector): Make return type const.
7927         (blockvector_for_pc_sect): Make "b" const.
7928         (find_block_in_blockvector): Make "b" const.
7929
7930 2019-03-23  Tom Tromey  <tom@tromey.com>
7931
7932         * varobj.c (varobj_create): Update.
7933         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7934         * printcmd.c (display_command, do_one_display): Don't reset
7935         innermost_block.
7936         * parser-defs.h (enum innermost_block_tracker_type): Move to
7937         expression.h.
7938         (innermost_block): Update comment.
7939         * parse.c (parse_exp_1): Add tracker_types parameter.
7940         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7941         tracker_types parameter.  Reset innermost_block.
7942         (parse_exp_in_context): Remove.
7943         (parse_expression_for_completion): Update.
7944         * objfiles.c (~objfile): Don't reset expression_context_block or
7945         innermost_block.
7946         * expression.h (enum innermost_block_tracker_type): Move from
7947         parser-defs.h.
7948         (parse_exp_1): Add tracker_types parameter.
7949         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7950         reset innermost_block.
7951
7952 2019-03-23  Tom Tromey  <tom@tromey.com>
7953
7954         * objfiles.h: Include bcache.h.
7955
7956 2019-03-23  Tom Tromey  <tom@tromey.com>
7957
7958         * linespec.c (get_current_search_block): Use
7959         scoped_restore_current_language.
7960         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7961
7962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7963             Jiong Wang  <jiong.wang@arm.com>
7964
7965         * aarch64-linux-tdep.c
7966         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7967         section.
7968         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7969
7970 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7971             Jiong Wang  <jiong.wang@arm.com>
7972
7973         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7974         instructions.
7975         (aarch64_analyze_prologue_test): Add PACIASP test.
7976         (aarch64_prologue_prev_register): Unmask PC value.
7977
7978 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7979             Jiong Wang  <jiong.wang@arm.com>
7980
7981         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7982         (aarch64_dwarf2_prev_register): Unmask PC value.
7983         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7984         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7985         DW_CFA_AARCH64_negate_ra_state.
7986         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7987
7988 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7989             Jiong Wang  <jiong.wang@arm.com>
7990
7991         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7992         registers.
7993         (aarch64_pseudo_register_name): Likewise.
7994         (aarch64_pseudo_register_type): Likewise.
7995         (aarch64_pseudo_register_reggroup_p): Likewise.
7996         (aarch64_gdbarch_init): Add pauth registers.
7997         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7998         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7999         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8000         (struct gdbarch_tdep): Add regnum for ra_state.
8001
8002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8003             Jiong Wang  <jiong.wang@arm.com>
8004
8005         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8006
8007 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8008             Jiong Wang  <jiong.wang@arm.com>
8009
8010         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8011         function.
8012         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8013         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8014         (aarch64_gdbarch_init): Add puth registers.
8015         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8016         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8017         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8018
8019 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8020             Jiong Wang  <jiong.wang@arm.com>
8021
8022         * aarch64-linux-nat.c
8023         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8024         * aarch64-linux-tdep.c
8025         (aarch64_linux_core_read_description): Likewise.
8026         (aarch64_linux_get_hwcap): New function.
8027         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8028         (aarch64_linux_get_hwcap): New declaration.
8029
8030 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8031             Jiong Wang  <jiong.wang@arm.com>
8032
8033         * aarch64-linux-nat.c
8034         (aarch64_linux_nat_target::read_description): Add pauth param.
8035         * aarch64-linux-tdep.c
8036         (aarch64_linux_core_read_description): Likewise.
8037         * aarch64-tdep.c (struct target_desc): Add in pauth.
8038         (aarch64_read_description): Add pauth param.
8039         (aarch64_gdbarch_init): Likewise.
8040         * aarch64-tdep.h (aarch64_read_description): Likewise.
8041         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8042         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8043         * features/Makefile: Add new files.
8044         * features/aarch64-pauth.c: New file.
8045         * features/aarch64-pauth.xml: New file.
8046
8047 2019-03-20  Tom Tromey  <tromey@adacore.com>
8048
8049         * infrun.c (handle_inferior_event): Rename from
8050         handle_inferior_event_1.  Create a scoped_value_mark.
8051         (handle_inferior_event): Remove.
8052
8053 2019-03-19  Tom Tromey  <tromey@adacore.com>
8054
8055         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8056         * infrun.h (print_stop_event): Add "displays" parameter.
8057         * infrun.c (print_stop_event): Add "displays" parameter.
8058
8059 2019-03-19  Pedro Alves  <palves@redhat.com>
8060
8061         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8062         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8063         to -1.  Fix TABs vs spaces.
8064         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8065         * tui/tui-out.h (tui_ui_out) Add intro comments.
8066         <m_line, m_start_of_line>: In-class initialize, and add describing
8067         comment.
8068
8069 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8070
8071         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8072         variable names.
8073         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8074
8075 2019-03-18  Pedro Alves  <palves@redhat.com>
8076             Eli Zaretskii <eliz@gnu.org>
8077
8078         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8079         m_line and m_start_of_line.
8080
8081 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8082
8083         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8084         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8085         it returns a newline.  This fixes a regression in TU mode, whereby
8086         the next line is output on the same screen line as the user input.
8087
8088 2019-03-18  Tom Tromey  <tromey@adacore.com>
8089
8090         * minsyms.c (minimal_symbol_reader::install): Remove call to
8091         obstack_blank.
8092
8093 2019-03-18  Pedro Alves  <palves@redhat.com>
8094
8095         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8096         New globals.
8097         (apply_style): New, factored out from ...
8098         (apply_ansi_escape): ... this.  Handle reverse video mode.
8099         (tui_set_reverse_mode): New function.
8100         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8101         * tui/tui-winsource.c (tui_show_source_line): Use
8102         tui_set_reverse_mode instead of setting A_STANDOUT.
8103         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8104         New setter methods.
8105
8106 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8107
8108         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8109         Handle tabs.
8110
8111 2019-03-18  Tom Tromey  <tromey@adacore.com>
8112
8113         * ada-lang.c (empty_array): Add "high" parameter.
8114         (ada_evaluate_subexp): Update.
8115
8116 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8117
8118         * unittests/string_view-selftests.c: Define
8119         _initialize_string_view_selftests unconditionally.
8120
8121 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8122
8123         PR gdb/24350
8124         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8125
8126 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8127
8128         PR gdb/24351
8129         * windows-nat.c (display_selector): Fix format specifiers.
8130
8131 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8132
8133         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8134         tui_refill_source_window instead of tui_refresh_win, to update the
8135         current execution line.  This fixes redisplay of the current line
8136         when stepping through the code with "next" or "step".
8137
8138 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8139
8140         * source-cache.c (source_cache::get_source_lines): Call
8141         find_source_lines to initialize s->nlines.  This fixes vertical
8142         scrolling of TUI source window when the DOWN arrow is pressed.
8143
8144 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8145
8146         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8147         linux-thread-db.c (_initialize_thread_db): Likewise.
8148
8149 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8150
8151         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8152         wclrtoeol in tui_show_source_line".  This reverts changes made in
8153         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8154
8155 2019-03-15  Tom Tromey  <tom@tromey.com>
8156
8157         * symtab.h (struct minimal_symbol): Derive from
8158         general_symbol_info.
8159         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8160         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8161         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8162         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8163         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8164         (MSYMBOL_SEARCH_NAME): Update.
8165         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8166         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8167         * minsyms.c (minimal_symbol_reader::record_full): Update.
8168
8169 2019-03-15  Tom Tromey  <tom@tromey.com>
8170
8171         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8172
8173 2019-03-15  Tom Tromey  <tom@tromey.com>
8174
8175         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8176         unique_xmalloc_ptr.
8177         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8178         Update.
8179         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8180         (build_minimal_symbol_hash_tables)
8181         (minimal_symbol_reader::install): Update.
8182
8183 2019-03-15  Tom Tromey  <tom@tromey.com>
8184
8185         * symtab.c (create_demangled_names_hash): Update.
8186         (symbol_set_names): Update.
8187         * objfiles.h (struct objfile_per_bfd_storage)
8188         <demangled_names_hash>: Now an htab_up.
8189         * objfiles.c (objfile_per_bfd_storage): Simplify.
8190
8191 2019-03-15  Tom Tromey  <tom@tromey.com>
8192
8193         * objfiles.h (struct objfile_per_bfd_storage): Declare
8194         destructor.
8195         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8196         New.
8197         (get_objfile_bfd_data): Use new.  Don't initialize
8198         language_of_main.
8199         (free_objfile_per_bfd_storage): Remove.
8200         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8201
8202 2019-03-15  Tom Tromey  <tom@tromey.com>
8203
8204         * symfile.c (reread_symbols): Update.
8205         * objfiles.c (objfile::objfile): Update.
8206         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8207         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8208         comment.
8209         (minimal_symbol_reader::install): Update.
8210         (terminate_minimal_symbol_table): Remove.
8211         * jit.c (jit_object_close_impl): Update.
8212
8213 2019-03-15  Tom Tromey  <tom@tromey.com>
8214
8215         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8216         initializations.
8217
8218 2019-03-15  Tom Tromey  <tom@tromey.com>
8219
8220         * objfiles.h (struct objfile_per_bfd_storage)
8221         <demangled_hash_languages>: Now a bitset.
8222         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8223         (lookup_minimal_symbol): Update.
8224
8225 2019-03-15  Tom Tromey  <tom@tromey.com>
8226
8227         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8228         Don't return the symbol.
8229         * coffread.c (record_minimal_symbol): Use record_full.
8230
8231 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8232
8233         The MS-Windows port of ncurses fails to switch to a color pair if
8234         one or both of the colors are the implicit default colors.  This
8235         change records the default colors when TUI is initialized, and
8236         then specifies them explicitly when a color pair uses the default
8237         colors.  This allows color styling in TUI mode on MS-Windows.
8238
8239         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8240         ncurses_norm_attr.
8241         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8242         colors in ncurses_norm_attr.
8243         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8244         "none", replace it with the default color recorded in
8245         ncurses_norm_attr.
8246
8247 2019-03-14  Tom Tromey  <tromey@adacore.com>
8248
8249         * source-cache.h (class source_cache) <get_source_lines>: Return
8250         std::string.
8251         * source-cache.c (source_cache::extract_lines): Handle case where
8252         first_pos==npos.  Return std::string.
8253         (source_cache::get_source_lines): Update.
8254
8255 2019-03-14  Tom Tromey  <tromey@adacore.com>
8256
8257         * NEWS: Add item for "style sources" commands.
8258         * source-cache.c (source_cache::get_source_lines): Check
8259         source_styling.
8260         * cli/cli-style.c (source_styling): New global.
8261         (_initialize_cli_style): Add "style sources" commands.
8262         (show_style_sources): New function.
8263         * cli/cli-style.h (source_styling): Declare.
8264
8265 2019-03-14  Pedro Alves  <palves@redhat.com>
8266             Tom Tromey  <tromey@adacore.com>
8267
8268         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8269         * tui/tui-winsource.c (tui_refill_source_window): New function,
8270         from...
8271         (tui_horizontal_source_scroll): ... here.  Move some logic.
8272         * cli/cli-style.c (set_style_enabled): Notify new observable.
8273         * tui/tui-hooks.c (tui_redisplay_source): New function.
8274         (tui_attach_detach_observers): Attach or detach
8275         tui_redisplay_source.
8276         * observable.h (source_styling_changed): New observable.
8277         * observable.c: Define source_styling_changed observable.
8278
8279 2019-03-13  Tom Tromey  <tromey@adacore.com>
8280
8281         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8282         (i386_gnu_nat_target::store_registers): Update.
8283         * target-debug.h (target_debug_print_std_string): New macro.
8284         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8285         * windows-tdep.c (display_one_tib): Update.
8286         * tui/tui-stack.c (tui_make_status_line): Update.
8287         * top.c (print_inferior_quit_action): Update.
8288         * thread.c (thr_try_catch_cmd): Update.
8289         (add_thread_with_info): Update.
8290         (thread_target_id_str): Update.
8291         (thr_try_catch_cmd): Update.
8292         (thread_command): Update.
8293         (thread_find_command): Update.
8294         * record-btrace.c (record_btrace_target::info_record)
8295         (record_btrace_resume_thread, record_btrace_target::resume)
8296         (record_btrace_cancel_resume, record_btrace_step_thread)
8297         (record_btrace_target::wait, record_btrace_target::wait)
8298         (record_btrace_target::wait, record_btrace_target::stop): Update.
8299         * progspace.c (print_program_space): Update.
8300         * process-stratum-target.c
8301         (process_stratum_target::thread_address_space): Update.
8302         * linux-fork.c (linux_fork_mourn_inferior)
8303         (detach_checkpoint_command, info_checkpoints_command)
8304         (linux_fork_context): Update.
8305         (linux_fork_detach): Update.
8306         (class scoped_switch_fork_info): Update.
8307         (delete_checkpoint_command): Update.
8308         * infrun.c (follow_fork_inferior): Update.
8309         (follow_fork_inferior): Update.
8310         (proceed_after_vfork_done): Update.
8311         (handle_vfork_child_exec_or_exit): Update.
8312         (follow_exec): Update.
8313         (displaced_step_prepare_throw): Update.
8314         (displaced_step_restore): Update.
8315         (start_step_over): Update.
8316         (resume_1): Update.
8317         (clear_proceed_status_thread): Update.
8318         (proceed): Update.
8319         (print_target_wait_results): Update.
8320         (do_target_wait): Update.
8321         (context_switch): Update.
8322         (stop_all_threads): Update.
8323         (restart_threads): Update.
8324         (finish_step_over): Update.
8325         (handle_signal_stop): Update.
8326         (switch_back_to_stepped_thread): Update.
8327         (keep_going_pass_signal): Update.
8328         (print_exited_reason): Update.
8329         (normal_stop): Update.
8330         * inferior.c (inferior_pid_to_str): Change return type.
8331         (print_selected_inferior): Update.
8332         (add_inferior): Update.
8333         (detach_inferior): Update.
8334         * dummy-frame.c (fprint_dummy_frames): Update.
8335         * dcache.c (dcache_info_1): Update.
8336         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8337         (btrace_fetch, btrace_clear): Update.
8338         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8339         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8340         type.
8341         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8342         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8343         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8344         * gdbarch.c, gdbarch.h: Rebuild.
8345         * gdbarch.sh (core_pid_to_str): Change return type.
8346         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8347         return type.
8348         (windows_nat_target::pid_to_str): Change return type.
8349         (windows_delete_thread): Update.
8350         (windows_nat_target::attach): Update.
8351         (windows_nat_target::files_info): Update.
8352         * target-delegates.c: Rebuild.
8353         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8354         return type.
8355         (sol_thread_target::pid_to_str): Change return type.
8356         * remote.c (class remote_target) <pid_to_str>: Change return
8357         type.
8358         (remote_target::pid_to_str): Change return type.
8359         (extended_remote_target::attach, remote_target::remote_stop_ns)
8360         (remote_target::remote_notif_remove_queued_reply)
8361         (remote_target::push_stop_reply, remote_target::disable_btrace):
8362         Update.
8363         (extended_remote_target::attach): Update.
8364         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8365         type.
8366         (gdbsim_target::pid_to_str): Change return type.
8367         * ravenscar-thread.c (struct ravenscar_thread_target)
8368         <pid_to_str>: Change return type.
8369         (ravenscar_thread_target::pid_to_str): Change return type.
8370         * procfs.c (class procfs_target) <pid_to_str>: Change return
8371         type.
8372         (procfs_target::pid_to_str): Change return type.
8373         (procfs_target::attach): Update.
8374         (procfs_target::detach): Update.
8375         (procfs_target::fetch_registers): Update.
8376         (procfs_target::store_registers): Update.
8377         (procfs_target::wait): Update.
8378         (procfs_target::files_info): Update.
8379         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8380         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8381         return type.
8382         (nto_procfs_target::pid_to_str): Change return type.
8383         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8384         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8385         return type.
8386         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8387         (exit_lwp): Update.
8388         (attach_proc_task_lwp_callback, get_detach_signal)
8389         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8390         (linux_nat_target::resume, wait_lwp, stop_callback)
8391         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8392         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8393         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8394         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8395         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8396         type.
8397         (inf_ptrace_target::attach): Update.
8398         (inf_ptrace_target::files_info): Update.
8399         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8400         type.
8401         (go32_nat_target::pid_to_str): Change return type.
8402         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8403         (gnu_nat_target::wait): Update.
8404         (gnu_nat_target::wait): Update.
8405         (gnu_nat_target::resume): Update.
8406         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8407         (fbsd_nat_target::wait): Update.
8408         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8409         type.
8410         (darwin_nat_target::attach): Update.
8411         * corelow.c (class core_target) <pid_to_str>: Change return type.
8412         (core_target::pid_to_str): Change return type.
8413         * target.c (normal_pid_to_str): Change return type.
8414         (default_pid_to_str): Likewise.
8415         (target_pid_to_str): Change return type.
8416         (target_translate_tls_address): Update.
8417         (target_announce_detach): Update.
8418         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8419         return type.
8420         (bsd_uthread_target::pid_to_str): Change return type.
8421         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8422         type.
8423         (bsd_kvm_target::pid_to_str): Change return type.
8424         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8425         return type.
8426         (aix_thread_target::pid_to_str): Change return type.
8427         * target.h (struct target_ops) <pid_to_str>: Change return type.
8428         (target_pid_to_str, normal_pid_to_str): Likewise.
8429         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8430         type.
8431         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8432         type.
8433         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8434         return type.
8435         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8436         type.
8437         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8438         type.
8439         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8440         return type.
8441
8442 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8443
8444         * NEWS: Mention that the new default MI version is 3.  Mention
8445         changes to the output of commands and events that deal with
8446         multi-location breakpoints.
8447         * breakpoint.c: Include "mi/mi-out.h".
8448         (print_one_breakpoint): Change output syntax if using MI version
8449         >= 3.
8450         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8451         New.
8452         (mi_multi_location_breakpoint_output_fixed): New.
8453         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8454         (mi_cmd_fix_multi_location_breakpoint_output): New.
8455         (mi_multi_location_breakpoint_output_fixed): New.
8456         * mi/mi-cmds.c (mi_cmds): Register command
8457         -fix-multi-location-breakpoint-output.
8458         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8459         interpreter "mi".
8460
8461 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8462
8463         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8464         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8465         instantiate mi_ui_out based on interpreter name.
8466         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8467         * mi/mi-main.c (mi_load_progress): Likewise.
8468
8469 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8470
8471         * NEWS: Combine separate "New targets" sections for 8.3.
8472
8473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8474
8475         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8476         (ppcfbsd_init_abi): Install gdbarch
8477         "fetch_tls_load_module_address" and "get_thread_local_address"
8478         methods.
8479
8480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8481
8482         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8483         (riscv_fbsd_init_abi): Install gdbarch
8484         "fetch_tls_load_module_address" and "get_thread_local_address"
8485         methods.
8486
8487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8488
8489         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8490         (i386fbsd_init_abi): Install gdbarch
8491         "fetch_tls_load_module_address" and "get_thread_local_address"
8492         methods.
8493
8494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8495
8496         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8497         (amd64fbsd_init_abi): Install gdbarch
8498         "fetch_tls_load_module_address" and "get_thread_local_address"
8499         methods.
8500
8501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8502
8503         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8504         (struct fbsd_pspace_data): New type.
8505         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8506         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8507         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8508         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8509         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8510
8511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8512
8513         * gdbtypes.c (lookup_struct_elt): New function.
8514         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8515         * gdbtypes.h (struct struct_elt): New type.
8516         (lookup_struct_elt): New prototype.
8517
8518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8519
8520         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8521         remove disabled code block.
8522
8523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8524
8525         * gdbarch.sh (get_thread_local_address): New method.
8526         * gdbarch.h, gdbarch.c: Regenerate.
8527         * target.c (target_translate_tls_address): Use
8528         gdbarch_get_thread_local_address if present instead of
8529         target::get_thread_local_address.
8530
8531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8532
8533         * target.h (target::get_thread_local_address): Update comment.
8534
8535 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8536
8537         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8538         objfile->separate_debug_objfile_backlink if not NULL.
8539
8540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8541
8542         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8543         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8544         (amd64bsd_store_inferior_registers): Likewise.
8545         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8546         Enable segment base registers.
8547         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8548         PT_GETFSBASE and PT_GETGSBASE.
8549         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8550         PT_SETGSBASE.
8551         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8552         segment base registers.
8553         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8554
8555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8556
8557         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8558         Update calls to i386_target_description to add 'segments'
8559         parameter.
8560         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8561         add segment base registers.
8562         * arch/i386.c (i386_create_target_description): Add 'segments'
8563         parameter to enable segment base registers.
8564         * arch/i386.h (i386_create_target_description): Likewise.
8565         * features/i386/32bit-segments.xml: New file.
8566         * features/i386/32bit-segments.c: Generate.
8567         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8568         call to i386_target_description to add 'segments' parameter.
8569         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8570         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8571         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8572         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8573         if feature is present.
8574         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8575         Add 'segments' parameter to call to i386_target_description.
8576         (i386_target_description): Add 'segments' parameter to enable
8577         segment base registers.
8578         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8579         to call to i386_target_description.
8580         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8581         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8582         Define I386_NUM_REGS.
8583         (i386_target_description): Add 'segments' parameter to enable
8584         segment base registers.
8585
8586 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8587
8588         PR/24325
8589         * source-cache.c: #undef open and close, to avoid unresolved
8590         externals during linking.
8591
8592 2019-03-12  Tom Tromey  <tromey@adacore.com>
8593
8594         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8595         const.  Add initializers.
8596         (_initialize_remote): Don't initialize ptid globals.
8597
8598 2019-03-12  Pedro Alves  <palves@redhat.com>
8599
8600         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8601
8602 2019-03-12  Pedro Alves  <palves@redhat.com>
8603
8604         * cp-name-parser.y (main): Remove unused 'len' variable.
8605
8606 2019-03-12  Tom Tromey  <tromey@adacore.com>
8607
8608         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8609         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8610
8611 2019-03-12  Tom Tromey  <tromey@adacore.com>
8612
8613         * linux-nat.c (iterate_over_lwps): Update.
8614         (stop_callback): Remove parameter.
8615         (stop_wait_callback, detach_callback, resume_set_callback)
8616         (select_singlestep_lwp_callback, set_ignore_sigint)
8617         (status_callback, resumed_callback, resume_clear_callback)
8618         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8619         data parameter.
8620         (linux_nat_target::detach, linux_nat_target::resume)
8621         (linux_stop_and_wait_all_lwps, select_event_lwp)
8622         (linux_nat_filter_event, linux_nat_wait_1)
8623         (linux_nat_target::kill, linux_nat_target::stop)
8624         (linux_nat_target::stop): Update.
8625         (linux_nat_resume_callback): Change type.
8626         (resume_stopped_resumed_lwps, count_events_callback)
8627         (select_event_lwp_callback): Likewise.
8628         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8629         * arm-linux-nat.c (struct update_registers_data): Remove.
8630         (update_registers_callback): Change type.
8631         (arm_linux_insert_hw_breakpoint1): Update.
8632         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8633         parameter.
8634         (x86_linux_dr_set_addr): Update.
8635         (x86_linux_dr_set_control): Update.
8636         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8637         (iterate_over_lwps): Use gdb::function_view.
8638         * nat/aarch64-linux-hw-point.c (struct
8639         aarch64_dr_update_callback_param): Remove.
8640         (debug_reg_change_callback): Change type.
8641         (aarch64_notify_debug_reg_change): Update.
8642         * s390-linux-nat.c (s390_refresh_per_info): Update.
8643
8644 2019-03-11  Tom Tromey  <tromey@adacore.com>
8645
8646         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8647         redundant assignment to "this_cu".
8648
8649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8650
8651         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8652
8653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8654
8655         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8656         from...
8657         (rank_one_type): ... this.
8658
8659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8660
8661         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8662         from...
8663         (rank_one_type): ... this.
8664
8665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8666
8667         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8668         from...
8669         (rank_one_type): ... this.
8670
8671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8672
8673         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8674         from...
8675         (rank_one_type): ... this.
8676
8677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8678
8679         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8680         from...
8681         (rank_one_type): ... this.
8682
8683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8684
8685         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8686         from...
8687         (rank_one_type): ... this.
8688
8689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8690
8691         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8692         from...
8693         (rank_one_type): ... this.
8694
8695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8696
8697         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8698         from...
8699         (rank_one_type): ... this.
8700
8701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8702
8703         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8704         from...
8705         (rank_one_type): ... this.
8706
8707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8708
8709         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8710         from...
8711         (rank_one_type): ... this.
8712
8713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8714
8715         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8716         from...
8717         (rank_one_type): ... this.
8718
8719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8720
8721         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8722         from...
8723         (rank_one_type): ... this.
8724
8725 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8726
8727         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8728         inferior-events' shows the example events.
8729
8730 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8731
8732         Support styling on native MS-Windows console
8733
8734         PR/24315
8735         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8736         on MS-Windows if $TERM is not defined.
8737
8738         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8739
8740         * posix-hdep.c (gdb_console_fputs):
8741         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8742         functions.
8743         * ui-file.h (gdb_console_fputs): Add prototype.
8744
8745         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8746         back to fputs only if the former returns zero.
8747
8748 2019-03-07  Tom Tromey  <tom@tromey.com>
8749
8750         * symmisc.c (print_symbol_bcache_statistics): Update.
8751         (print_objfile_statistics): Update.
8752         * symfile.c (allocate_symtab): Update.
8753         * stabsread.c: Don't include bcache.h.
8754         * psymtab.h (struct psymbol_bcache): Don't declare.
8755         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8756         (psymbol_bcache_init, psymbol_bcache_free)
8757         (psymbol_bcache_get_bcache): Don't declare.
8758         * psymtab.c (struct psymbol_bcache): Remove.
8759         (psymtab_storage::psymtab_storage): Update.
8760         (psymtab_storage::~psymtab_storage): Update.
8761         (psymbol_bcache_init, psymbol_bcache_free)
8762         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8763         (add_psymbol_to_bcache): Update.
8764         (allocate_psymtab): Update.
8765         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8766         macro_cache>: No longer pointers.
8767         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8768         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8769         * macrotab.c (macro_bcache): Update.
8770         * macroexp.c: Don't include bcache.h.
8771         * gdbtypes.c (check_types_worklist): Update.
8772         (types_deeply_equal): Remove TRY/CATCH.  Update.
8773         * elfread.c (elf_symtab_read): Update.
8774         * dwarf2read.c: Don't include bcache.h.
8775         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8776         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8777         (print_bcache_statistics, bcache_memory_used): Don't declare.
8778         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8779         methods.  Rename all data members.
8780         * bcache.c (struct bcache): Move to bcache.h.
8781         (bcache::expand_hash_table): Rename from expand_hash_table.
8782         (bcache): Remove.
8783         (bcache::insert): Rename from bcache_full.
8784         (bcache::compare): Rename from bcache_compare.
8785         (bcache_xmalloc): Remove.
8786         (bcache::~bcache): Rename from bcache_xfree.
8787         (bcache::print_statistics): Rename from print_bcache_statistics.
8788         (bcache::memory_used): Rename from bcache_memory_used.
8789
8790 2019-03-07  Pedro Alves  <palves@redhat.com>
8791
8792         * infrun.c (normal_stop): Also check for
8793         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8794
8795 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8796
8797         * f-lang.c (value_from_host_double): Moved to...
8798         * value.c (value_from_host_double): ...here.
8799         * value.h (value_from_host_double): Declare.
8800         * guile/scm-math.c (vlscm_convert_typed_number): Use
8801         value_from_host_double.
8802         (vlscm_convert_number): Likewise.
8803         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8804         * python/py-value.c (convert_value_from_python): Likewise.
8805
8806 2019-03-06  Tom Tromey  <tom@tromey.com>
8807
8808         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8809
8810 2019-03-06  Tom Tromey  <tom@tromey.com>
8811
8812         * utils.h (free_current_contents): Don't declare.
8813         * utils.c (free_current_contents): Remove.
8814
8815 2019-03-06  Tom Tromey  <tom@tromey.com>
8816
8817         * top.c (quit_force): Update.
8818         * main.c (captured_command_loop): Update.
8819         * common/new-op.c (operator new): Update.
8820         * common/common-exceptions.c (struct catcher)
8821         <save_cleanup_chain>: Remove member.
8822         (exceptions_state_mc_init): Update.
8823         (exception_try_scope_entry): Return nullptr.
8824         (exception_try_scope_exit, exception_rethrow)
8825         (throw_exception_sjlj, throw_exception_cxx): Update.
8826         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8827         (all_cleanups, do_cleanups, discard_cleanups)
8828         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8829         (restore_cleanups, restore_final_cleanups): Don't declare.
8830         (do_final_cleanups): Remove parameter.
8831         * common/cleanups.c (cleanup_chain, make_cleanup)
8832         (make_cleanup_dtor, all_cleanups, do_cleanups)
8833         (discard_my_cleanups, discard_cleanups)
8834         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8835         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8836         (null_cleanup): Remove.
8837         (do_final_cleanups): Remove parameter.
8838
8839 2019-03-06  Tom Tromey  <tom@tromey.com>
8840
8841         * remote.c (remote_target::remote_parse_stop_reply): Use
8842         unique_xmalloc_ptr.
8843
8844 2019-03-06  Tom Tromey  <tom@tromey.com>
8845
8846         * stabsread.c (struct stabs_field_info): Rename from field_info.
8847         <list, fnlist>: Add initializers.
8848         <obstack>: New member.
8849         (read_member_functions, read_struct_fields, read_baseclasses):
8850         Allocate on obstack.  Don't use cleanups.
8851         (read_one_struct_field, read_member_functions, read_struct_fields)
8852         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8853         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8854         (read_struct_type): Update.
8855
8856 2019-03-06  Tom Tromey  <tom@tromey.com>
8857
8858         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8859         * common/filestuff.h (make_cleanup_close): Don't declare.
8860         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8861         Remove.
8862
8863 2019-03-06  Tom Tromey  <tom@tromey.com>
8864
8865         * solib-aix.c: Use make_scope_exit.
8866
8867 2019-03-06  Tom Tromey  <tom@tromey.com>
8868
8869         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8870         Use make_scope_exit.
8871
8872 2019-03-06  Tom Tromey  <tom@tromey.com>
8873
8874         * solib-svr4.c (disable_probes_interface): Remove parameter.
8875         (svr4_handle_solib_event): Use make_scope_exit.
8876
8877 2019-03-06  Tom Tromey  <tom@tromey.com>
8878
8879         * remote.c (struct stop_reply_deleter): Remove.
8880         (stop_reply_up): Update.
8881         (struct stop_reply): Derive from notif_event.  Don't typedef.
8882         <regcache>: Now a std::vector.
8883         (stop_reply_xfree): Remove.
8884         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8885         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8886         (remote_target::discard_pending_stop_replies): Use delete.
8887         (remote_target::remote_parse_stop_reply): Update.
8888         (remote_target::process_stop_reply): Update.
8889         * remote-notif.h (struct notif_event): Add virtual destructor.
8890         Remove "dtr" member.
8891         (struct notif_client) <alloc_event>: Return a unique_ptr.
8892         (notif_event_xfree): Don't declare.
8893         (notif_event_up): New typedef.
8894         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8895         (notif_event_xfree, do_notif_event_xfree): Remove.
8896         (remote_notif_state_xfree): Update.
8897
8898 2019-03-06  Tom Tromey  <tom@tromey.com>
8899
8900         * infrun.c (displaced_step_clear_cleanup): Now a
8901         forward_scope_exit type.
8902         (displaced_step_prepare_throw): Update.
8903         (displaced_step_fixup): Update.
8904
8905 2019-03-06  Tom Tromey  <tom@tromey.com>
8906
8907         * inferior.h (class inferior): Update comment.
8908         * gdbthread.h (class thread_info): Update comment.
8909
8910 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8911             Tom Tromey  <tom@tromey.com>
8912
8913         * stabsread.h (struct stab_section_list): Remove.
8914         (coffstab_build_psymtabs): Update.
8915         * dbxread.c (symbuf_sections): Now a std::vector.
8916         (sect_idx): New global.
8917         (fill_symbuf): Update.
8918         (coffstab_build_psymtabs): Change type of stabsects parameter.
8919         Update.
8920         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8921         std::vector.
8922         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8923         (coff_locate_sections): Update.
8924         (coff_symfile_read): Remove cleanups.  Update.
8925         (init_stringtab): Add storage parameter.
8926         (free_stringtab, free_stringtab_cleanup): Remove.
8927         (init_lineno): Add storage parameter.
8928         (free_linetab, free_linetab_cleanup): Remove.
8929
8930 2019-03-06  Pedro Alves  <palves@redhat.com>
8931
8932         * linux-fork.c (fork_info::clobber_regs): Delete.
8933         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8934         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8935         comment.  Adjust.
8936         (scoped_switch_fork_info::scoped_switch_fork_info)
8937         (checkpoint_command, linux_fork_context): Adjust
8938         fork_save_infrun_state calls.
8939
8940 2019-03-06  Pedro Alves  <palves@redhat.com>
8941
8942         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8943         (inf_has_multiple_threads): Return 'bool' and rewrite using
8944         inferior_info::threads().
8945
8946 2019-03-06  Pedro Alves  <palves@redhat.com>
8947
8948         * linux-fork.c: Include <list>.
8949         (fork_list): Now a std::list instance.
8950         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8951         (forks_exist_p, find_last_fork): Adjust.
8952         (new_fork): Delete.
8953         (one_fork_p): New.
8954         (add_fork): Adjust.
8955         (free_fork): Delete, folded into fork_info::~fork_info().
8956         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8957         Adjust.
8958         (init_fork_list): Delete.
8959         (linux_fork_killall, linux_fork_mourn_inferior)
8960         (linux_fork_detach, info_checkpoints_command): Adjust.
8961         (_initialize_linux_fork): No longer call init_fork_list.
8962
8963 2019-03-06  Pedro Alves  <palves@redhat.com>
8964
8965         * linux-fork.c (new_fork): New, split out of ...
8966         (add_fork): ... this.  Return void.  Move "first fork" special
8967         case from here, to ...
8968         (checkpoint_command): ... here.
8969         * linux-linux.h (add_fork): Return void.
8970
8971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8972
8973         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8974
8975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8976             Chris January  <chris.january@arm.com>
8977             David Lecomber  <david.lecomber@arm.com>
8978
8979         * f-exp.y: New token, UNOP_INTRINSIC.
8980         (exp): New pattern using UNOP_INTRINSIC token.
8981         (f77_keywords): Add 'abs' keyword.
8982         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8983         (value_from_host_double): New function.
8984         (evaluate_subexp_f): Support UNOP_ABS.
8985
8986 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8987
8988         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8989         types.
8990
8991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8992
8993         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8994         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8995         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8996
8997 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9000
9001 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9002             Chris January  <chris.january@arm.com>
9003
9004         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9005         * f-exp.y: Define 'KIND' token.
9006         (exp): New pattern for KIND expressions.
9007         (ptype): Handle types with a kind extension.
9008         (direct_abs_decl): Extend to spot kind extensions.
9009         (f77_keywords): Add 'kind' to the list.
9010         (push_kind_type): New function.
9011         (convert_to_kind_type): New function.
9012         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9013         * parse.c (operator_length_standard): Likewise.
9014         * parser-defs.h (enum type_pieces): Add tp_kind.
9015         * std-operator.def: Add UNOP_KIND.
9016
9017 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9018
9019         * f-exp.y (f_parse): Set yydebug.
9020
9021 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * f-lang.c (evaluate_subexp_f): New function.
9024         (exp_descriptor_f): New global.
9025         (f_language_defn): Use exp_descriptor_f instead of
9026         exp_descriptor_standard.
9027
9028 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * f-exp.y (struct token): Add comments.
9031         (dot_ops): Remove uppercase versions and the end marker.
9032         (f77_keywords): Likewise.
9033         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9034         entries in the dot_ops array are case insensitive, and use
9035         strncasecmp to compare strings.  Also some whitespace cleanup in
9036         this area.  Similar for the f77_keywords array, except entries in
9037         this list might be case sensitive.
9038
9039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9040
9041         * f-exp.y (struct f77_boolean_val): Add comments.
9042         (boolean_values): Remove uppercase versions, and end marker.
9043         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9044         and use strncasecmp to achieve case insensitivity.  Additionally,
9045         perform whitespace cleanup around this code.
9046
9047 2019-03-06  Tom Tromey  <tromey@adacore.com>
9048
9049         * remote-sim.c (gdbsim_target_open): Use result of
9050         gdb_argv::release.
9051
9052 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9053         Dirk Schubert  <dirk.schubert@arm.com>
9054         Chris January  <chris.january@arm.com>
9055
9056         * eval.c (evaluate_subexp_standard): Call Fortran argument
9057         wrapping logic.
9058         * f-lang.c (struct value): A value which can be passed into a
9059         Fortran function call.
9060         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9061         where appropriate.
9062         (struct type): Value ready for a Fortran function call.
9063         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9064         is needed.
9065         * f-lang.h (fortran_argument_convert): Declaration.
9066         (fortran_preserve_arg_pointer): Declaration.
9067         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9068
9069 2019-03-05  Tom Tromey  <tromey@adacore.com>
9070
9071         * python/py-prettyprint.c (print_string_repr): Remove #if.
9072         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9073
9074 2019-03-05  Tom Tromey  <tromey@adacore.com>
9075
9076         * target.c (the_dummy_target): Move later.  Change type to
9077         "dummy_target".
9078         (initialize_targets): Don't initialize the_dummy_target.
9079
9080 2019-03-05  Tom Tromey  <tromey@adacore.com>
9081
9082         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9083         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9084
9085 2019-03-05  Tom Tromey  <tromey@adacore.com>
9086
9087         * windows-nat.c (windows_nat_target::attach)
9088         (windows_nat_target::detach): Don't call gdb_flush.
9089         * valprint.c (generic_val_print, val_print, val_print_string):
9090         Don't call gdb_flush.
9091         * utils.c (defaulted_query): Don't call gdb_flush.
9092         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9093         * target.c (target_announce_detach): Don't call gdb_flush.
9094         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9095         * remote.c (extended_remote_target::attach): Don't call
9096         gdb_flush.
9097         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9098         * printcmd.c (do_examine): Don't call gdb_flush.
9099         (info_display_command): Don't call gdb_flush.
9100         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9101         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9102         * memattr.c (info_mem_command): Don't call gdb_flush.
9103         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9104         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9105         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9106         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9107         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9108         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9109         (gnu_nat_target::detach): Don't call gdb_flush.
9110         * f-valprint.c (f_val_print): Don't call gdb_flush.
9111         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9112         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9113         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9114         gdb_flush.
9115         * c-valprint.c (c_val_print): Don't call gdb_flush.
9116         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9117
9118 2019-03-05  Tom Tromey  <tromey@adacore.com>
9119
9120         * varobj.c (update_dynamic_varobj_children): Update.
9121         (install_default_visualizer): Use reset, not release.
9122         * value.c (set_internalvar): Update.
9123         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9124         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9125         ATTRIBUTE_UNUSED_RESULT.
9126
9127 2019-03-05  Tom Tromey  <tromey@adacore.com>
9128
9129         * remote.c (class scoped_remote_fd) <release>: Add
9130         ATTRIBUTE_UNUSED_RESULT.
9131
9132 2019-03-05  Tom Tromey  <tromey@adacore.com>
9133
9134         * macroexp.c (struct macro_buffer) <release>: Add
9135         ATTRIBUTE_UNUSED_RESULT.
9136
9137 2019-03-05  Tom Tromey  <tromey@adacore.com>
9138
9139         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9140         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9141         ATTRIBUTE_UNUSED_RESULT.
9142
9143 2019-03-05  Tom Tromey  <tromey@adacore.com>
9144
9145         * common/scoped_fd.h (class scoped_fd) <release>: Add
9146         ATTRIBUTE_UNUSED_RESULT.
9147
9148 2019-03-05  Tom Tromey  <tromey@adacore.com>
9149
9150         * parser-defs.h (struct parser_state) <release>: Add
9151         ATTRIBUTE_UNUSED_RESULT.
9152
9153 2019-03-05  Tom Tromey  <tromey@adacore.com>
9154
9155         * utils.h (class gdb_argv) <release>: Add
9156         ATTRIBUTE_UNUSED_RESULT.
9157         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9158
9159 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9160
9161         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9162         for-loop range, to avoid compiler warnings.
9163
9164         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9165         avoid compiler warnings about unused variables.
9166
9167         * NEWS: Mention end of support for native debugging on MS-Windows
9168         before XP.
9169
9170         PR gdb/24292
9171         * common/netstuff.c:
9172         * gdbserver/gdbreplay.c
9173         * gdbserver/remote-utils.c:
9174         * ser-tcp.c:
9175         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9176         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9177         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9178         'getaddrinfo' and 'freeaddrinfo' were not available before
9179         Windows XP, and mingw.org's MinGW headers by default define
9180         _WIN32_WINNT to 0x500.
9181
9182 2019-03-01  Gary Benson <gbenson@redhat.com>
9183
9184         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9185
9186 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9187             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9188
9189         PR gdb/8527
9190         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9191         set_sigint_trap, clear_sigint_trap.
9192
9193 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9194
9195         * target.c (target_detach): Clear the regcache and the
9196         frame cache.
9197
9198 2019-02-27  Pedro Alves  <palves@redhat.com>
9199
9200         * utils.c (set_screen_size): When we cap the height/width sizes,
9201         tweak the corresponding command variable to show "unlimited":
9202
9203 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9204             Pedro Alves  <palves@redhat.com>
9205
9206         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9207         before calling rl_set_screen_size.
9208
9209 2019-02-27  Tom Tromey  <tromey@adacore.com>
9210
9211         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9212         define.
9213         * python/py-value.c: Remove Python 2.4 workaround.
9214         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9215         workaround.
9216         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9217         Python 2.4 workaround.
9218         * python/python-internal.h: Remove Python 2.4 comment.
9219         (Py_ssize_t): Don't define.
9220         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9221         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9222         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9223         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9224         * python/python.c (do_start_initialization): Remove Python 2.4
9225         workaround.
9226         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9227         (print_children): Remove Python 2.4 workaround.
9228         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9229         workaround.
9230         (CHARBUFFERPROC_NAME): Remove.
9231         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9232         Python 2.4 workaround.
9233
9234 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9235
9236         * NEWS: Note minimum Python version.
9237
9238 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9239
9240         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9241         code from these functions.  Remove corresponding ifdefs.  Use
9242         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9243         Remove gotos and target of gotos.
9244         (infpy_search_memory): Likewise.
9245
9246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9247
9248         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9249         (hppa_gdbarch_init): Don't register deleted functions with
9250         gdbarch.
9251
9252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9253
9254         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9255         (h8300_unwind_sp): Delete.
9256         (h8300_dummy_id): Delete.
9257         (h8300_gdbarch_init): Don't register deleted functions with
9258         gdbarch.
9259
9260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9261
9262         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9263         (ft32_unwind_pc): Delete.
9264         (ft32_unwind_sp): Delete.
9265         (ft32_gdbarch_init): Don't register deleted functions with
9266         gdbarch.
9267
9268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9271         (frv_unwind_pc): Delete.
9272         (frv_unwind_sp): Delete.
9273         (frv_gdbarch_init): Don't register deleted functions with
9274         gdbarch.
9275
9276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9277
9278         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9279         (riscv_unwind_pc): Delete.
9280         (riscv_unwind_sp): Delete.
9281         (riscv_gdbarch_init): Don't register deleted functions with
9282         gdbarch.
9283
9284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9287         (csky_unwind_pc): Delete.
9288         (csky_unwind_sp): Delete.
9289         (csky_gdbarch_init): Don't register deleted functions with
9290         gdbarch.
9291
9292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9293
9294         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9295         (cris_unwind_pc): Delete.
9296         (cris_unwind_sp): Delete.
9297         (cris_gdbarch_init): Don't register deleted functions with
9298         gdbarch.
9299
9300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9303         (bfin_unwind_pc): Delete.
9304         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9305
9306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9309         (arm_unwind_pc): Delete.
9310         (arm_unwind_sp): Delete.
9311         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9312
9313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9316         (arc_unwind_pc): Delete.
9317         (arc_unwind_sp): Delete.
9318         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9319
9320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9323         (alpha_unwind_pc): Delete.
9324         (alpha_gdbarch_init): Don't register deleted functions with
9325         gdbarch.
9326
9327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9328
9329         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9330         (aarch64_unwind_pc): Delete.
9331         (aarch64_unwind_sp): Delete.
9332         (aarch64_gdbarch_init): Don't register deleted functions with
9333         gdbarch.
9334
9335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9336
9337         * gdbtypes.c (type_align): Don't consider static members when
9338         computing structure alignment.
9339
9340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9341
9342         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9343         return 0 for other types.
9344         * arch-utils.c (default_type_align): Always return 0.
9345         * gdbarch.h: Regenerate.
9346         * gdbarch.sh (type_align): Extend comment.
9347         * gdbtypes.c (type_align): Add additional comments, always call
9348         gdbarch_type_align before applying the default rules.
9349         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9350         generic code will then apply a suitable default.
9351         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9352         types, return 0 for other types.
9353
9354 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9355
9356         * NEWS: Create a new section for the next release branch.
9357         Rename the section of the current branch, now that it has
9358         been cut.
9359
9360 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9361
9362         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9363         * version.in: Bump version to 8.3.50.DATE-git.
9364
9365 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9366
9367         * aix-thread.c (ptid_cmp): Remove unused variable.
9368         (get_signaled_thread): Likewise.
9369         (store_regs_user_thread): Likewise.
9370         (store_regs_kernel_thread): Likewise.
9371         (fetch_regs_kernel_thread): Remove shadowed variable.
9372
9373 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9374
9375         * features/riscv/32bit-cpu.xml: Add register numbers.
9376         * features/riscv/32bit-fpu.c: Regenerate.
9377         * features/riscv/32bit-fpu.xml: Add register numbers.
9378         * features/riscv/64bit-cpu.xml: Add register numbers.
9379         * features/riscv/64bit-fpu.c: Regenerate.
9380         * features/riscv/64bit-fpu.xml: Add register numbers.
9381
9382 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9383
9384         * NEWS: Mention two argument form of gdb.Value constructor.
9385         * python/py-value.c (convert_buffer_and_type_to_value): New
9386         function.
9387         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9388         Add support for handling an optional second argument.  Call
9389         convert_buffer_and_type_to_value as appropriate.
9390         * python/python-internal.h (Py_buffer_deleter): New struct.
9391         (Py_buffer_up): New typedef.
9392
9393 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9394
9395         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9396         instead of releasing ownership.
9397
9398 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9399
9400         * dwarf2read.c (open_and_init_dwp_file): Call
9401         elf_numsections instead of bfd_count_sections to initialize
9402         dwp_file->num_sections.
9403
9404 2019-02-25  Tom Tromey  <tromey@adacore.com>
9405
9406         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9407
9408 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9409
9410         * gcore.in: Add '--readnever' option when invoking GDB.
9411
9412 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9413
9414         * MAINTAINERS: Update my email address.
9415
9416 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9417
9418         * build-id.c (build_id_to_debug_bfd_1): New function.
9419         (build_id_to_debug_bfd): Look for separate debug file in
9420         sysroot.
9421
9422 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9423
9424         * gdbarch.sh: Update the copyright year range that is placed into
9425         generated files.
9426
9427 2019-02-22  Keith Seitz  <keiths@redhat.com>
9428
9429         PR symtab/23853
9430         * linespec.c (create_sals_line_offset): Search for the default
9431         symtab's filename instead of its fullname.
9432
9433 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9434
9435         * NEWS: Update style defaults.
9436
9437 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9438
9439         * main.c (captured_main_1): Disable styling in batch mode.
9440
9441 2019-02-20  Tom Tromey  <tom@tromey.com>
9442
9443         * symtab.c (symtab_symbol_info): Fix typos.
9444
9445 2019-02-20  Tom Tromey  <tromey@adacore.com>
9446
9447         * findcmd.c (_initialize_mem_search): Use upper case for
9448         metasyntactic variables.
9449
9450 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9451
9452         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9453         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9454
9455 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9456
9457         * top.h (source_file_name): Change to std::string.
9458         * top.c (source_file_name): Likewise.
9459         (command_line_input): Adjust.
9460         * cli/cli-script.c (script_from_file): Adjust.
9461
9462 2019-02-19  Tom Tromey  <tromey@adacore.com>
9463
9464         * ravenscar-thread.c
9465         (ravenscar_thread_target::update_thread_list): Don't call
9466         ada_build_task_list.
9467         * ada-lang.h (ada_build_task_list): Don't declare.
9468         * ada-tasks.c (struct ada_tasks_inferior_data)
9469         <task_list_valid_p>: Now bool.
9470         (read_known_tasks, ada_task_list_changed)
9471         (ada_tasks_invalidate_inferior_data): Update.
9472         (read_known_tasks_array): Return bool.
9473         (read_known_tasks_list): Likewise.
9474         (read_known_tasks): Return void.
9475         (ada_build_task_list): Now static.
9476
9477 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9478
9479         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9480         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9481
9482 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9483
9484         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9485         variant for ada_tasks_pspace_data_handle and
9486         ada_tasks_inferior_data_handle.
9487         (ada_tasks_pspace_data_cleanup): New function.
9488         (ada_tasks_inferior_data_cleanup): New function.
9489
9490 2019-02-17  Tom Tromey  <tom@tromey.com>
9491
9492         * macrotab.h (macro_source_fullname): Return a std::string.
9493         * macrotab.c (macro_include, check_for_redefinition)
9494         (macro_undef, macro_lookup_definition, foreach_macro)
9495         (foreach_macro_in_scope): Update.
9496         (macro_source_fullname): Return a std::string.
9497         * macrocmd.c (show_pp_source_pos): Update.
9498
9499 2019-02-17  Tom Tromey  <tom@tromey.com>
9500
9501         * macrocmd.c (show_pp_source_pos): Style the file names.
9502
9503 2019-02-17  Tom Tromey  <tom@tromey.com>
9504
9505         PR tui/24197:
9506         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9507
9508 2019-02-17  Tom Tromey  <tom@tromey.com>
9509
9510         * ada-lang.c (user_select_syms): Use filtered printing.
9511         * utils.c (wrap_style): New global.
9512         (desired_style): Remove.
9513         (emit_style_escape): Add stream parameter.
9514         (set_output_style, reset_terminal_style, prompt_for_continue):
9515         Update.
9516         (flush_wrap_buffer): Only flush gdb_stdout.
9517         (wrap_here): Set wrap_style.
9518         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9519         treat escape sequences as a character.  Change when wrap buffer is
9520         flushed.
9521         (fputs_styled): Do not set the output style when the default is
9522         requested.
9523         * ui-style.h (struct ui_file_style) <is_default>: New method.
9524         * source.c (print_source_lines_base): Emit escape sequences in one
9525         piece.
9526
9527 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9528
9529         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9530         integers and enumeration types.
9531
9532 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9533
9534         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9535         instead of lookup_symbol_in_language
9536         (do_exact_match): New function.
9537         (ada_get_symbol_name_matcher): Return do_exact_match when
9538         doing a verbatim match.
9539
9540 2019-02-15  Tom Tromey  <tromey@adacore.com>
9541
9542         * ravenscar-thread.c (ravenscar_thread_target::resume)
9543         (ravenscar_thread_target::wait): Special case wildcard requests.
9544
9545 2019-02-15  Tom Tromey  <tromey@adacore.com>
9546
9547         * ravenscar-thread.c (base_ptid): Remove.
9548         (struct ravenscar_thread_target) <close>: New method.
9549         <m_base_ptid>: New member.
9550         <update_inferior_ptid, active_task, task_is_currently_active,
9551         runtime_initialized>: Declare methods.
9552         <ravenscar_thread_target>: Add constructor.
9553         (ravenscar_thread_target::task_is_currently_active)
9554         (ravenscar_thread_target::update_inferior_ptid)
9555         (ravenscar_runtime_initialized): Rename.  Now methods.
9556         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9557         (ravenscar_thread_target::update_thread_list): Update.
9558         (ravenscar_thread_target::active_task): Now method.
9559         (ravenscar_thread_target::store_registers)
9560         (ravenscar_thread_target::prepare_to_store)
9561         (ravenscar_thread_target::prepare_to_store)
9562         (ravenscar_thread_target::mourn_inferior): Update.
9563         (ravenscar_inferior_created): Use "new" to create target.
9564         (ravenscar_thread_target::get_ada_task_ptid): Update.
9565         (_initialize_ravenscar): Don't initialize base_ptid.
9566         (ravenscar_ops): Remove global.
9567
9568 2019-02-15  Tom Tromey  <tromey@adacore.com>
9569
9570         * target.h (push_target): Declare new overload.
9571         * target.c (push_target): New overload, taking an rvalue reference.
9572         * remote.c (remote_target::open_1): Use push_target overload.
9573         * corelow.c (core_target_open): Use push_target overload.
9574
9575 2019-02-15  Tom Tromey  <tromey@adacore.com>
9576
9577         * ravenscar-thread.c (is_ravenscar_task)
9578         (ravenscar_task_is_currently_active): Return bool.
9579         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9580         (_initialize_ravenscar): Remove "(void)".
9581         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9582         Return bool.
9583
9584 2019-02-15  Tom Tromey  <tromey@adacore.com>
9585
9586         * ravenscar-thread.c (ravenscar_runtime_initializer)
9587         (has_ravenscar_runtime, get_running_thread_id)
9588         (ravenscar_thread_target::resume): Fix indentation.
9589
9590 2019-02-15  Tom Tromey  <tromey@adacore.com>
9591
9592         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9593         from ravenscar_arch_ops.
9594         (sparc_ravenscar_ops::fetch_registers)
9595         (sparc_ravenscar_ops::store_registers): Now methods.
9596         (sparc_ravenscar_prepare_to_store): Remove.
9597         (sparc_ravenscar_ops): Redefine.
9598         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9599         methods and destructor.  Remove members.
9600         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9601         (ravenscar_thread_target::store_registers)
9602         (ravenscar_thread_target::prepare_to_store): Update.
9603         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9604         Remove.
9605         (struct ppc_ravenscar_powerpc_ops): Derive from
9606         ravenscar_arch_ops.
9607         (ppc_ravenscar_powerpc_ops::fetch_registers)
9608         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9609         (ppc_ravenscar_powerpc_ops): Redefine.
9610         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9611         (ppc_ravenscar_e500_ops::fetch_registers)
9612         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9613         (ppc_ravenscar_e500_ops): Redefine.
9614         * aarch64-ravenscar-thread.c
9615         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9616         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9617         (aarch64_ravenscar_fetch_registers)
9618         (aarch64_ravenscar_store_registers): Now methods.
9619         (aarch64_ravenscar_ops): Redefine.
9620
9621 2019-02-15  Tom Tromey  <tromey@adacore.com>
9622
9623         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9624         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9625         (ravenscar_thread_target::stopped_by_watchpoint)
9626         (ravenscar_thread_target::stopped_data_address)
9627         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9628
9629 2019-02-15  Tom Tromey  <tromey@adacore.com>
9630
9631         * ravenscar-thread.c: Fix some typos.
9632
9633 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9634             Tom Tromey  <tromey@adacore.com>
9635
9636         * ada-lang.c (ada_exception_sal): Change addr_string to a
9637         std::string.
9638         (create_ada_exception_catchpoint): Update.
9639
9640 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9641             Tom Tromey  <tromey@adacore.com>
9642
9643         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9644         (bp_location_ops): Remove.
9645         (base_breakpoint_allocate_location): Update.
9646         (free_bp_location): Update.
9647         * ada-lang.c (class ada_catchpoint_location)
9648         <ada_catchpoint_location>: Remove ops parameter.
9649         (ada_catchpoint_location_dtor): Remove.
9650         (ada_catchpoint_location_ops): Remove.
9651         (allocate_location_exception): Update.
9652         * breakpoint.h (struct bp_location_ops): Remove.
9653         (class bp_location) <bp_location>: Remove bp_location_ops
9654         parameter.
9655         <~bp_location>: Add destructor.
9656         <ops>: Remove.
9657
9658 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9659             Pedro Alves  <palves@redhat.com>
9660
9661         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9662         'PATH_MAX'.
9663
9664 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9665             Samuel Thibault  <samuel.thibault@gnu.org>
9666             Thomas Schwinge  <thomas@codesourcery.com>
9667
9668         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9669         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9670
9671 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9672
9673         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9674         (check_empty): Use "const char *".
9675
9676         * gnu-nat.c (gnu_nat_target::detach): Instead of
9677         'detach_inferior (pid)' call
9678         'detach_inferior (find_inferior_pid (pid))'.
9679
9680         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9681         'nat/fork-inferior.o'.
9682         * gnu-nat.c: #include "nat/fork-inferior.h".
9683
9684         * gnu-nat.c (gnu_nat_target::detach): Instead of
9685         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9686         * gnu-nat.h: #include "inf-child.h".
9687         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9688         'i386_gnu_nat_target::fetch_registers'.
9689         (gnu_store_registers): Rename/move to
9690         'i386_gnu_nat_target::store_registers'.
9691
9692         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9693         * gnu-nat.h (mach_thread_info): New function.
9694         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9695
9696         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9697
9698 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9699
9700         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9701
9702 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9703
9704         * windows-nat.c (windows_add_thread): Add new parameter
9705         "main_thread_p" with default value set to false.  Update
9706         function documentation as well as all callers.
9707         (windows_delete_thread): Likewise.
9708         (fake_create_process): Update call to windows_add_thread.
9709         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9710         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9711         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9712         call to windows_delete_thread.
9713
9714 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9715
9716         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9717
9718 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9719
9720         * symfile.c (find_separate_debug_file): Use canonical path of
9721         sysroot with child_path instead of gdb_sysroot if it is valid.
9722
9723 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9724
9725         * symfile.c (find_separate_debug_file): Use child_path to
9726         determine if an object file is under a sysroot.
9727
9728 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9729
9730         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9731         unittests/child-path-selftests.c.
9732         * common/pathstuff.c (child_path): New function.
9733         * common/pathstuff.h (child_path): New prototype.
9734         * unittests/child-path-selftests.c: New file.
9735
9736 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9737
9738         * symfile.c (find_separate_debug_file): Look for separate debug
9739         files in debug directories under the sysroot.
9740
9741 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9742
9743         * symtab.h (struct minimal_symbol data_p): New const method.
9744         (struct minimal_symbol text_p): Likewise.
9745         * symtab.c (output_source_filename): Use file name style
9746         to print file name.
9747         (print_symbol_info): Likewise.
9748         (print_msymbol_info): Use address style to print addresses.
9749         Use function name style to print executable text symbols.
9750         (expand_symtab_containing_pc): Use data_p.
9751         (find_pc_sect_compunit_symtab): Likewise.
9752
9753 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9754
9755         * breakpoint.c (describe_other_breakpoints): Use address style
9756         to print addresses.
9757         (say_where): Likewise.
9758
9759 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9760
9761         * ada-typeprint.c (print_func_type): Print function name
9762         style to print function name.
9763         * c-typeprint.c (c_print_type_1): Likewise.
9764
9765 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9766
9767         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9768         for execve.
9769
9770 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9771
9772         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9773         type_stack.
9774
9775 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9776
9777         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9778         TYPE_CODE_REF types.
9779
9780 2019-02-08  Jim Wilson  <jimw@sifive.com>
9781
9782         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9783         (riscv_linux_fregset): New.
9784         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9785
9786 2019-02-07  Tom Tromey  <tom@tromey.com>
9787
9788         * thread.c (thread_cancel_execution_command): Update.
9789         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9790         methods.
9791         (struct thread_fsm_ops): Remove.
9792         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9793         (thread_fsm_should_stop, thread_fsm_return_value)
9794         (thread_fsm_set_finished, thread_fsm_finished_p)
9795         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9796         Don't declare.
9797         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9798         * infrun.c (clear_proceed_status_thread)
9799         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9800         (print_stop_event): Update.
9801         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9802         Add constructor.
9803         (step_command_fsm_ops): Remove.
9804         (new_step_command_fsm): Remove.
9805         (step_1): Update.
9806         (step_command_fsm::should_stop): Rename from
9807         step_command_fsm_should_stop.
9808         (step_command_fsm::clean_up): Rename from
9809         step_command_fsm_clean_up.
9810         (step_command_fsm::do_async_reply_reason): Rename from
9811         step_command_fsm_async_reply_reason.
9812         (struct until_next_fsm): Inherit from thread_fsm.  Add
9813         constructor.
9814         (until_next_fsm_ops): Remove.
9815         (new_until_next_fsm): Remove.
9816         (until_next_fsm::should_stop): Rename from
9817         until_next_fsm_should_stop.
9818         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9819         (until_next_fsm::do_async_reply_reason): Rename from
9820         until_next_fsm_async_reply_reason.
9821         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9822         constructor.  Change type of breakpoint.
9823         (finish_command_fsm_ops): Remove.
9824         (new_finish_command_fsm): Remove.
9825         (finish_command_fsm::should_stop): Rename from
9826         finish_command_fsm_should_stop.
9827         (finish_command_fsm::clean_up): Rename from
9828         finish_command_fsm_clean_up.
9829         (finish_command_fsm::return_value): Rename from
9830         finish_command_fsm_return_value.
9831         (finish_command_fsm::do_async_reply_reason): Rename from
9832         finish_command_fsm_async_reply_reason.
9833         (finish_command): Update.
9834         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9835         Add constructor.
9836         (call_thread_fsm_ops): Remove.
9837         (call_thread_fsm::call_thread_fsm): Rename from
9838         new_call_thread_fsm.
9839         (call_thread_fsm::should_stop): Rename from
9840         call_thread_fsm_should_stop.
9841         (call_thread_fsm::should_notify_stop): Rename from
9842         call_thread_fsm_should_notify_stop.
9843         (run_inferior_call, call_function_by_hand_dummy): Update.
9844         * cli/cli-interp.c (should_print_stop_to_console): Update.
9845         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9846         Add constructor.  Change type of location_breakpoint,
9847         caller_breakpoint.
9848         (until_break_fsm_ops): Remove.
9849         (new_until_break_fsm): Remove.
9850         (until_break_fsm::should_stop): Rename from
9851         until_break_fsm_should_stop.
9852         (until_break_fsm::clean_up): Rename from
9853         until_break_fsm_clean_up.
9854         (until_break_fsm::do_async_reply_reason): Rename from
9855         until_break_fsm_async_reply_reason.
9856         (until_break_command): Update.
9857         * thread-fsm.c: Remove.
9858         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9859
9860 2019-02-07  Tom Tromey  <tom@tromey.com>
9861
9862         * yy-remap.h: Add include guard.
9863         * xtensa-tdep.h: Add include guard.
9864         * xcoffread.h: Rename include guard.
9865         * varobj-iter.h: Add include guard.
9866         * tui/tui.h: Rename include guard.
9867         * tui/tui-winsource.h: Rename include guard.
9868         * tui/tui-wingeneral.h: Rename include guard.
9869         * tui/tui-windata.h: Rename include guard.
9870         * tui/tui-win.h: Rename include guard.
9871         * tui/tui-stack.h: Rename include guard.
9872         * tui/tui-source.h: Rename include guard.
9873         * tui/tui-regs.h: Rename include guard.
9874         * tui/tui-out.h: Rename include guard.
9875         * tui/tui-layout.h: Rename include guard.
9876         * tui/tui-io.h: Rename include guard.
9877         * tui/tui-hooks.h: Rename include guard.
9878         * tui/tui-file.h: Rename include guard.
9879         * tui/tui-disasm.h: Rename include guard.
9880         * tui/tui-data.h: Rename include guard.
9881         * tui/tui-command.h: Rename include guard.
9882         * tic6x-tdep.h: Add include guard.
9883         * target/waitstatus.h: Rename include guard.
9884         * target/wait.h: Rename include guard.
9885         * target/target.h: Rename include guard.
9886         * target/resume.h: Rename include guard.
9887         * target-float.h: Rename include guard.
9888         * stabsread.h: Add include guard.
9889         * rs6000-tdep.h: Add include guard.
9890         * riscv-fbsd-tdep.h: Add include guard.
9891         * regformats/regdef.h: Rename include guard.
9892         * record.h: Rename include guard.
9893         * python/python.h: Rename include guard.
9894         * python/python-internal.h: Rename include guard.
9895         * python/py-stopevent.h: Rename include guard.
9896         * python/py-ref.h: Rename include guard.
9897         * python/py-record.h: Rename include guard.
9898         * python/py-record-full.h: Rename include guard.
9899         * python/py-record-btrace.h: Rename include guard.
9900         * python/py-instruction.h: Rename include guard.
9901         * python/py-events.h: Rename include guard.
9902         * python/py-event.h: Rename include guard.
9903         * procfs.h: Add include guard.
9904         * proc-utils.h: Add include guard.
9905         * p-lang.h: Add include guard.
9906         * or1k-tdep.h: Rename include guard.
9907         * observable.h: Rename include guard.
9908         * nto-tdep.h: Rename include guard.
9909         * nat/x86-linux.h: Rename include guard.
9910         * nat/x86-linux-dregs.h: Rename include guard.
9911         * nat/x86-gcc-cpuid.h: Add include guard.
9912         * nat/x86-dregs.h: Rename include guard.
9913         * nat/x86-cpuid.h: Rename include guard.
9914         * nat/ppc-linux.h: Rename include guard.
9915         * nat/mips-linux-watch.h: Rename include guard.
9916         * nat/linux-waitpid.h: Rename include guard.
9917         * nat/linux-ptrace.h: Rename include guard.
9918         * nat/linux-procfs.h: Rename include guard.
9919         * nat/linux-osdata.h: Rename include guard.
9920         * nat/linux-nat.h: Rename include guard.
9921         * nat/linux-namespaces.h: Rename include guard.
9922         * nat/linux-btrace.h: Rename include guard.
9923         * nat/glibc_thread_db.h: Rename include guard.
9924         * nat/gdb_thread_db.h: Rename include guard.
9925         * nat/gdb_ptrace.h: Rename include guard.
9926         * nat/fork-inferior.h: Rename include guard.
9927         * nat/amd64-linux-siginfo.h: Rename include guard.
9928         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9929         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9930         * nat/aarch64-linux.h: Rename include guard.
9931         * nat/aarch64-linux-hw-point.h: Rename include guard.
9932         * mn10300-tdep.h: Add include guard.
9933         * mips-linux-tdep.h: Add include guard.
9934         * mi/mi-parse.h: Rename include guard.
9935         * mi/mi-out.h: Rename include guard.
9936         * mi/mi-main.h: Rename include guard.
9937         * mi/mi-interp.h: Rename include guard.
9938         * mi/mi-getopt.h: Rename include guard.
9939         * mi/mi-console.h: Rename include guard.
9940         * mi/mi-common.h: Rename include guard.
9941         * mi/mi-cmds.h: Rename include guard.
9942         * mi/mi-cmd-break.h: Rename include guard.
9943         * m2-lang.h: Add include guard.
9944         * location.h: Rename include guard.
9945         * linux-record.h: Rename include guard.
9946         * linux-nat.h: Add include guard.
9947         * linux-fork.h: Add include guard.
9948         * i386-darwin-tdep.h: Rename include guard.
9949         * hppa-linux-offsets.h: Add include guard.
9950         * guile/guile.h: Rename include guard.
9951         * guile/guile-internal.h: Rename include guard.
9952         * gnu-nat.h: Rename include guard.
9953         * gdb-stabs.h: Rename include guard.
9954         * frv-tdep.h: Add include guard.
9955         * f-lang.h: Add include guard.
9956         * event-loop.h: Add include guard.
9957         * darwin-nat.h: Rename include guard.
9958         * cp-abi.h: Rename include guard.
9959         * config/sparc/nm-sol2.h: Rename include guard.
9960         * config/nm-nto.h: Rename include guard.
9961         * config/nm-linux.h: Add include guard.
9962         * config/i386/nm-i386gnu.h: Rename include guard.
9963         * config/djgpp/nl_types.h: Rename include guard.
9964         * config/djgpp/langinfo.h: Rename include guard.
9965         * compile/gcc-cp-plugin.h: Add include guard.
9966         * compile/gcc-c-plugin.h: Add include guard.
9967         * compile/compile.h: Rename include guard.
9968         * compile/compile-object-run.h: Rename include guard.
9969         * compile/compile-object-load.h: Rename include guard.
9970         * compile/compile-internal.h: Rename include guard.
9971         * compile/compile-cplus.h: Rename include guard.
9972         * compile/compile-c.h: Rename include guard.
9973         * common/xml-utils.h: Rename include guard.
9974         * common/x86-xstate.h: Rename include guard.
9975         * common/version.h: Rename include guard.
9976         * common/vec.h: Rename include guard.
9977         * common/tdesc.h: Rename include guard.
9978         * common/selftest.h: Rename include guard.
9979         * common/scoped_restore.h: Rename include guard.
9980         * common/scoped_mmap.h: Rename include guard.
9981         * common/scoped_fd.h: Rename include guard.
9982         * common/safe-iterator.h: Rename include guard.
9983         * common/run-time-clock.h: Rename include guard.
9984         * common/refcounted-object.h: Rename include guard.
9985         * common/queue.h: Rename include guard.
9986         * common/ptid.h: Rename include guard.
9987         * common/print-utils.h: Rename include guard.
9988         * common/preprocessor.h: Rename include guard.
9989         * common/pathstuff.h: Rename include guard.
9990         * common/observable.h: Rename include guard.
9991         * common/netstuff.h: Rename include guard.
9992         * common/job-control.h: Rename include guard.
9993         * common/host-defs.h: Rename include guard.
9994         * common/gdb_wait.h: Rename include guard.
9995         * common/gdb_vecs.h: Rename include guard.
9996         * common/gdb_unlinker.h: Rename include guard.
9997         * common/gdb_unique_ptr.h: Rename include guard.
9998         * common/gdb_tilde_expand.h: Rename include guard.
9999         * common/gdb_sys_time.h: Rename include guard.
10000         * common/gdb_string_view.h: Rename include guard.
10001         * common/gdb_splay_tree.h: Rename include guard.
10002         * common/gdb_setjmp.h: Rename include guard.
10003         * common/gdb_ref_ptr.h: Rename include guard.
10004         * common/gdb_optional.h: Rename include guard.
10005         * common/gdb_locale.h: Rename include guard.
10006         * common/gdb_assert.h: Rename include guard.
10007         * common/filtered-iterator.h: Rename include guard.
10008         * common/filestuff.h: Rename include guard.
10009         * common/fileio.h: Rename include guard.
10010         * common/environ.h: Rename include guard.
10011         * common/common-utils.h: Rename include guard.
10012         * common/common-types.h: Rename include guard.
10013         * common/common-regcache.h: Rename include guard.
10014         * common/common-inferior.h: Rename include guard.
10015         * common/common-gdbthread.h: Rename include guard.
10016         * common/common-exceptions.h: Rename include guard.
10017         * common/common-defs.h: Rename include guard.
10018         * common/common-debug.h: Rename include guard.
10019         * common/cleanups.h: Rename include guard.
10020         * common/buffer.h: Rename include guard.
10021         * common/btrace-common.h: Rename include guard.
10022         * common/break-common.h: Rename include guard.
10023         * cli/cli-utils.h: Rename include guard.
10024         * cli/cli-style.h: Rename include guard.
10025         * cli/cli-setshow.h: Rename include guard.
10026         * cli/cli-script.h: Rename include guard.
10027         * cli/cli-interp.h: Rename include guard.
10028         * cli/cli-decode.h: Rename include guard.
10029         * cli/cli-cmds.h: Rename include guard.
10030         * charset-list.h: Add include guard.
10031         * buildsym-legacy.h: Rename include guard.
10032         * bfin-tdep.h: Add include guard.
10033         * ax.h: Rename include guard.
10034         * arm-linux-tdep.h: Add include guard.
10035         * arm-fbsd-tdep.h: Add include guard.
10036         * arch/xtensa.h: Rename include guard.
10037         * arch/tic6x.h: Add include guard.
10038         * arch/i386.h: Add include guard.
10039         * arch/arm.h: Rename include guard.
10040         * arch/arm-linux.h: Rename include guard.
10041         * arch/arm-get-next-pcs.h: Rename include guard.
10042         * arch/amd64.h: Add include guard.
10043         * arch/aarch64-insn.h: Rename include guard.
10044         * arch-utils.h: Rename include guard.
10045         * annotate.h: Add include guard.
10046         * amd64-darwin-tdep.h: Rename include guard.
10047         * aarch64-linux-tdep.h: Add include guard.
10048         * aarch64-fbsd-tdep.h: Add include guard.
10049         * aarch32-linux-nat.h: Add include guard.
10050
10051 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10052
10053         * macrotab.c (macro_define_internal): New function that
10054         factorizes macro_define_object_internal and macro_define_function
10055         code.
10056         (macro_define_object_internal): Use macro_define_internal.
10057         (macro_define_function): Likewise.
10058
10059 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10060
10061         * macrocmd.c (extract_identifier): Return
10062         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10063         callers.
10064
10065 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10066
10067         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10068
10069 2019-02-05  Tom Tromey  <tom@tromey.com>
10070
10071         * target.c (target_stack::unpush): Move assertion earlier.
10072
10073 2019-01-30  Tom Tromey  <tom@tromey.com>
10074
10075         PR python/23615:
10076         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10077         (gdbpy_parse_and_eval): Likewise.
10078         * python/python-internal.h (gdbpy_allow_threads): New class.
10079
10080 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10081
10082         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10083         (aarch64_fbsd_fpregmap): Move earlier.
10084         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10085         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10086         instead of individual calls to trad_frame_set_reg_addr.
10087         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10088         earlier.
10089         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10090         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10091         instead of individual calls to trad_frame_set_reg_addr.
10092
10093 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10094
10095         * CONTRIBUTE: Replace contribution list with wiki link.
10096
10097 2019-01-25  Tom Tromey  <tom@tromey.com>
10098
10099         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10100
10101 2019-01-25  Tom Tromey  <tom@tromey.com>
10102
10103         * xtensa-linux-nat.c: Fix common/ includes.
10104         * xml-support.h: Fix common/ includes.
10105         * xml-support.c: Fix common/ includes.
10106         * x86-linux-nat.c: Fix common/ includes.
10107         * windows-nat.c: Fix common/ includes.
10108         * varobj.h: Fix common/ includes.
10109         * varobj.c: Fix common/ includes.
10110         * value.c: Fix common/ includes.
10111         * valops.c: Fix common/ includes.
10112         * utils.c: Fix common/ includes.
10113         * unittests/xml-utils-selftests.c: Fix common/ includes.
10114         * unittests/utils-selftests.c: Fix common/ includes.
10115         * unittests/unpack-selftests.c: Fix common/ includes.
10116         * unittests/tracepoint-selftests.c: Fix common/ includes.
10117         * unittests/style-selftests.c: Fix common/ includes.
10118         * unittests/string_view-selftests.c: Fix common/ includes.
10119         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10120         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10121         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10122         * unittests/rsp-low-selftests.c: Fix common/ includes.
10123         * unittests/parse-connection-spec-selftests.c: Fix common/
10124         includes.
10125         * unittests/optional-selftests.c: Fix common/ includes.
10126         * unittests/offset-type-selftests.c: Fix common/ includes.
10127         * unittests/observable-selftests.c: Fix common/ includes.
10128         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10129         * unittests/memrange-selftests.c: Fix common/ includes.
10130         * unittests/memory-map-selftests.c: Fix common/ includes.
10131         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10132         * unittests/function-view-selftests.c: Fix common/ includes.
10133         * unittests/environ-selftests.c: Fix common/ includes.
10134         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10135         * unittests/common-utils-selftests.c: Fix common/ includes.
10136         * unittests/cli-utils-selftests.c: Fix common/ includes.
10137         * unittests/array-view-selftests.c: Fix common/ includes.
10138         * ui-file.c: Fix common/ includes.
10139         * tui/tui-io.c: Fix common/ includes.
10140         * tracepoint.h: Fix common/ includes.
10141         * tracepoint.c: Fix common/ includes.
10142         * tracefile-tfile.c: Fix common/ includes.
10143         * top.h: Fix common/ includes.
10144         * top.c: Fix common/ includes.
10145         * thread.c: Fix common/ includes.
10146         * target/waitstatus.h: Fix common/ includes.
10147         * target/waitstatus.c: Fix common/ includes.
10148         * target.h: Fix common/ includes.
10149         * target.c: Fix common/ includes.
10150         * target-memory.c: Fix common/ includes.
10151         * target-descriptions.c: Fix common/ includes.
10152         * symtab.h: Fix common/ includes.
10153         * symfile.c: Fix common/ includes.
10154         * stap-probe.c: Fix common/ includes.
10155         * spu-linux-nat.c: Fix common/ includes.
10156         * sparc-nat.c: Fix common/ includes.
10157         * source.c: Fix common/ includes.
10158         * solib.c: Fix common/ includes.
10159         * solib-target.c: Fix common/ includes.
10160         * ser-unix.c: Fix common/ includes.
10161         * ser-tcp.c: Fix common/ includes.
10162         * ser-pipe.c: Fix common/ includes.
10163         * ser-base.c: Fix common/ includes.
10164         * selftest-arch.c: Fix common/ includes.
10165         * s12z-tdep.c: Fix common/ includes.
10166         * rust-exp.y: Fix common/ includes.
10167         * rs6000-aix-tdep.c: Fix common/ includes.
10168         * riscv-tdep.c: Fix common/ includes.
10169         * remote.c: Fix common/ includes.
10170         * remote-notif.h: Fix common/ includes.
10171         * remote-fileio.h: Fix common/ includes.
10172         * remote-fileio.c: Fix common/ includes.
10173         * regcache.h: Fix common/ includes.
10174         * regcache.c: Fix common/ includes.
10175         * record-btrace.c: Fix common/ includes.
10176         * python/python.c: Fix common/ includes.
10177         * python/py-type.c: Fix common/ includes.
10178         * python/py-inferior.c: Fix common/ includes.
10179         * progspace.h: Fix common/ includes.
10180         * producer.c: Fix common/ includes.
10181         * procfs.c: Fix common/ includes.
10182         * proc-api.c: Fix common/ includes.
10183         * printcmd.c: Fix common/ includes.
10184         * ppc-linux-nat.c: Fix common/ includes.
10185         * parser-defs.h: Fix common/ includes.
10186         * osdata.c: Fix common/ includes.
10187         * obsd-nat.c: Fix common/ includes.
10188         * nat/x86-linux.c: Fix common/ includes.
10189         * nat/x86-linux-dregs.c: Fix common/ includes.
10190         * nat/x86-dregs.h: Fix common/ includes.
10191         * nat/x86-dregs.c: Fix common/ includes.
10192         * nat/ppc-linux.c: Fix common/ includes.
10193         * nat/mips-linux-watch.h: Fix common/ includes.
10194         * nat/mips-linux-watch.c: Fix common/ includes.
10195         * nat/linux-waitpid.c: Fix common/ includes.
10196         * nat/linux-ptrace.h: Fix common/ includes.
10197         * nat/linux-ptrace.c: Fix common/ includes.
10198         * nat/linux-procfs.c: Fix common/ includes.
10199         * nat/linux-personality.c: Fix common/ includes.
10200         * nat/linux-osdata.c: Fix common/ includes.
10201         * nat/linux-namespaces.c: Fix common/ includes.
10202         * nat/linux-btrace.h: Fix common/ includes.
10203         * nat/linux-btrace.c: Fix common/ includes.
10204         * nat/fork-inferior.c: Fix common/ includes.
10205         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10206         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10207         * nat/aarch64-linux.c: Fix common/ includes.
10208         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10209         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10210         * namespace.h: Fix common/ includes.
10211         * mips-linux-tdep.c: Fix common/ includes.
10212         * minsyms.c: Fix common/ includes.
10213         * mi/mi-parse.h: Fix common/ includes.
10214         * mi/mi-main.c: Fix common/ includes.
10215         * mi/mi-cmd-env.c: Fix common/ includes.
10216         * memrange.h: Fix common/ includes.
10217         * memattr.c: Fix common/ includes.
10218         * maint.h: Fix common/ includes.
10219         * maint.c: Fix common/ includes.
10220         * main.c: Fix common/ includes.
10221         * machoread.c: Fix common/ includes.
10222         * location.c: Fix common/ includes.
10223         * linux-thread-db.c: Fix common/ includes.
10224         * linux-nat.c: Fix common/ includes.
10225         * linux-fork.c: Fix common/ includes.
10226         * inline-frame.c: Fix common/ includes.
10227         * infrun.c: Fix common/ includes.
10228         * inflow.c: Fix common/ includes.
10229         * inferior.h: Fix common/ includes.
10230         * inferior.c: Fix common/ includes.
10231         * infcmd.c: Fix common/ includes.
10232         * inf-ptrace.c: Fix common/ includes.
10233         * inf-child.c: Fix common/ includes.
10234         * ia64-linux-nat.c: Fix common/ includes.
10235         * i387-tdep.c: Fix common/ includes.
10236         * i386-tdep.c: Fix common/ includes.
10237         * i386-linux-tdep.c: Fix common/ includes.
10238         * i386-linux-nat.c: Fix common/ includes.
10239         * i386-go32-tdep.c: Fix common/ includes.
10240         * i386-fbsd-tdep.c: Fix common/ includes.
10241         * i386-fbsd-nat.c: Fix common/ includes.
10242         * guile/scm-type.c: Fix common/ includes.
10243         * guile/guile.c: Fix common/ includes.
10244         * go32-nat.c: Fix common/ includes.
10245         * gnu-nat.c: Fix common/ includes.
10246         * gdbthread.h: Fix common/ includes.
10247         * gdbarch-selftests.c: Fix common/ includes.
10248         * gdb_usleep.c: Fix common/ includes.
10249         * gdb_select.h: Fix common/ includes.
10250         * gdb_bfd.c: Fix common/ includes.
10251         * gcore.c: Fix common/ includes.
10252         * fork-child.c: Fix common/ includes.
10253         * findvar.c: Fix common/ includes.
10254         * fbsd-nat.c: Fix common/ includes.
10255         * event-top.c: Fix common/ includes.
10256         * event-loop.c: Fix common/ includes.
10257         * dwarf2read.c: Fix common/ includes.
10258         * dwarf2loc.c: Fix common/ includes.
10259         * dwarf2-frame.c: Fix common/ includes.
10260         * dwarf-index-cache.c: Fix common/ includes.
10261         * dtrace-probe.c: Fix common/ includes.
10262         * disasm-selftests.c: Fix common/ includes.
10263         * defs.h: Fix common/ includes.
10264         * csky-tdep.c: Fix common/ includes.
10265         * cp-valprint.c: Fix common/ includes.
10266         * cp-support.h: Fix common/ includes.
10267         * cp-support.c: Fix common/ includes.
10268         * corelow.c: Fix common/ includes.
10269         * completer.h: Fix common/ includes.
10270         * completer.c: Fix common/ includes.
10271         * compile/compile.c: Fix common/ includes.
10272         * compile/compile-loc2c.c: Fix common/ includes.
10273         * compile/compile-cplus-types.c: Fix common/ includes.
10274         * compile/compile-cplus-symbols.c: Fix common/ includes.
10275         * command.h: Fix common/ includes.
10276         * cli/cli-dump.c: Fix common/ includes.
10277         * cli/cli-cmds.c: Fix common/ includes.
10278         * charset.c: Fix common/ includes.
10279         * build-id.c: Fix common/ includes.
10280         * btrace.h: Fix common/ includes.
10281         * btrace.c: Fix common/ includes.
10282         * breakpoint.h: Fix common/ includes.
10283         * breakpoint.c: Fix common/ includes.
10284         * ax.h:
10285         (enum agent_op): Fix common/ includes.
10286         * ax-general.c (struct aop_map): Fix common/ includes.
10287         * ax-gdb.c: Fix common/ includes.
10288         * auxv.c: Fix common/ includes.
10289         * auto-load.c: Fix common/ includes.
10290         * arm-tdep.c: Fix common/ includes.
10291         * arch/riscv.c: Fix common/ includes.
10292         * arch/ppc-linux-common.c: Fix common/ includes.
10293         * arch/i386.c: Fix common/ includes.
10294         * arch/arm.c: Fix common/ includes.
10295         * arch/arm-linux.c: Fix common/ includes.
10296         * arch/arm-get-next-pcs.c: Fix common/ includes.
10297         * arch/amd64.c: Fix common/ includes.
10298         * arch/aarch64.c: Fix common/ includes.
10299         * arch/aarch64-insn.c: Fix common/ includes.
10300         * arch-utils.c: Fix common/ includes.
10301         * amd64-windows-tdep.c: Fix common/ includes.
10302         * amd64-tdep.c: Fix common/ includes.
10303         * amd64-sol2-tdep.c: Fix common/ includes.
10304         * amd64-obsd-tdep.c: Fix common/ includes.
10305         * amd64-nbsd-tdep.c: Fix common/ includes.
10306         * amd64-linux-tdep.c: Fix common/ includes.
10307         * amd64-linux-nat.c: Fix common/ includes.
10308         * amd64-fbsd-tdep.c: Fix common/ includes.
10309         * amd64-fbsd-nat.c: Fix common/ includes.
10310         * amd64-dicos-tdep.c: Fix common/ includes.
10311         * amd64-darwin-tdep.c: Fix common/ includes.
10312         * agent.c: Fix common/ includes.
10313         * ada-lang.h: Fix common/ includes.
10314         * ada-lang.c: Fix common/ includes.
10315         * aarch64-tdep.c: Fix common/ includes.
10316
10317 2019-01-25  Tom Tromey  <tom@tromey.com>
10318
10319         * common/create-version.sh: Use common/version.h.
10320
10321 2019-01-24  Pedro Alves  <palves@redhat.com>
10322
10323         * infrun.c (signal_stop, signal_print, signal_program)
10324         (signal_catch, signal_pass): Now arrays instead of pointers.
10325         (update_signals_program_target, do_target_resume)
10326         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10327         * linux-nat.c (linux_nat_target::pass_signals)
10328         (linux_nat_target::create_inferior, linux_nat_target::attach):
10329         Adjust.
10330         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10331         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10332         * procfs.c (procfs_target::pass_signals): Adjust.
10333         * record-full.c (record_full_target::resume): Adjust.
10334         * remote.c (remote_target::pass_signals)
10335         (remote_target::program_signals): Adjust.
10336         * target-debug.h (target_debug_print_signals): Now takes a
10337         gdb::array_view as parameter.  Adjust.
10338         * target.h (target_ops) <pass_signals, program_signals>: Replace
10339         pointer and length parameters with gdb::array_view.
10340         (target_pass_signals, target_program_signals): Likewise.
10341         * target-delegates.c: Regenerate.
10342
10343 2019-01-24  Pedro Alves  <palves@redhat.com>
10344
10345         * common/forward-scope-exit.h
10346         (forward_scope_exit::forward_scope_exit): Pass arguments to
10347         m_bind_function directly, instead of creating a std::bind and
10348         copying that.
10349
10350 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10351
10352         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10353         for static members.
10354         (pass_in_v_vfp_candidate): Likewise.
10355
10356 2019-01-23  Tom Tromey  <tom@tromey.com>
10357             Pedro Alves  <palves@redhat.com>
10358
10359         * regcache.c (class regcache_invalidator): Remove.
10360         (regcache::raw_write): Use make_scope_exit.
10361
10362 2019-01-23  Tom Tromey  <tom@tromey.com>
10363
10364         * ui-out.h (class ui_out_emit_type): Update comment.
10365
10366 2019-01-23  Tom Tromey  <tom@tromey.com>
10367
10368         * infrun.c (fetch_inferior_event): Update comment.
10369
10370 2019-01-23  Tom Tromey  <tom@tromey.com>
10371             Pedro Alves  <palves@redhat.com>
10372
10373         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10374         parameter.
10375         (fetch_inferior_event): Use SCOPE_EXIT.
10376
10377
10378 2019-01-23  Tom Tromey  <tom@tromey.com>
10379             Pedro Alves  <palves@redhat.com>
10380
10381         * infrun.c (disable_thread_events): Delete.
10382         (stop_all_threads): Use SCOPE_EXIT.
10383
10384 2019-01-23  Tom Tromey  <tom@tromey.com>
10385             Pedro Alves  <palves@redhat.com>
10386
10387         * symfile.c: Include forward-scope-exit.h.
10388         (clear_symtab_users_cleanup): Replace forward declaration with
10389         a FORWARD_SCOPE_EXIT.
10390         (syms_from_objfile_1): Use the forward_scope_exit and
10391         gdb::optional instead of cleanup_function.
10392         (reread_symbols): Use the forward_scope_exit instead of
10393         cleanup_function.
10394         (clear_symtab_users_cleanup): Remove function.
10395
10396 2019-01-23  Tom Tromey  <tom@tromey.com>
10397             Pedro Alves  <palves@redhat.com>
10398
10399         * linux-nat.c: Include scope-exit.h.
10400         (cleanup_target_stop): Remove.
10401         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10402         SCOPE_EXIT.
10403
10404 2019-01-23  Tom Tromey  <tom@tromey.com>
10405             Pedro Alves  <palves@redhat.com>
10406
10407         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10408         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10409
10410 2019-01-23  Tom Tromey  <tom@tromey.com>
10411             Andrew Burgess  <andrew.burgess@embecosm.com>
10412             Pedro Alves  <palves@redhat.com>
10413
10414         * infrun.c (fetch_inferior_event): Use scope_exit.
10415         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10416         * top.c (execute_command): Use scope_exit.
10417         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10418         * utils.c (do_bpstat_clear_actions_cleanup)
10419         (make_bpstat_clear_actions_cleanup): Remove.
10420
10421 2019-01-23  Tom Tromey  <tom@tromey.com>
10422             Pedro Alves  <palves@redhat.com>
10423
10424         * infrun.c: Include "common/scope-exit.h"
10425         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10426         (wait_for_inferior): Use SCOPE_EXIT.
10427         (fetch_inferior_event): Use scope_exit.
10428
10429 2019-01-23  Tom Tromey  <tom@tromey.com>
10430             Pedro Alves  <palves@redhat.com>
10431
10432         * breakpoint.c (create_breakpoint): Remove cleanup.
10433
10434 2019-01-23  Tom Tromey  <tom@tromey.com>
10435             Andrew Burgess  <andrew.burgess@embecosm.com>
10436             Pedro Alves  <palves@redhat.com>
10437
10438 2019-01-23  Pedro Alves  <palves@redhat.com>
10439
10440         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10441
10442 2019-01-23  Pedro Alves  <palves@redhat.com>
10443             Andrew Burgess  <andrew.burgess@embecosm.com>
10444
10445         * gdbthread.h: Include "common/forward-scope-exit.h".
10446         (scoped_finish_thread_state): Redefine custom class in terms of
10447         forward_scope_exit.
10448
10449 2019-01-23  Pedro Alves  <palves@redhat.com>
10450             Andrew Burgess  <andrew.burgess@embecosm.com>
10451
10452         * common/forward-scope-exit.h: New file.
10453
10454 2019-01-23  Pedro Alves  <palves@redhat.com>
10455             Andrew Burgess  <andrew.burgess@embecosm.com>
10456             Tom Tromey  <tom@tromey.com>
10457
10458         * common/scope-exit.h: New file.
10459
10460 2019-01-23  Pedro Alves  <palves@redhat.com>
10461
10462         * common/preprocessor.h (ESC): Rename to ...
10463         (ESC_PARENS): ... this.
10464         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10465         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10466
10467 2019-01-23  Tom Tromey  <tom@tromey.com>
10468
10469         * language.h (class scoped_switch_to_sym_language_if_auto):
10470         Initialize m_lang in both cases.
10471
10472 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10473
10474         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10475         with XCNEW.
10476
10477 2019-01-22  Tom Tromey  <tom@tromey.com>
10478
10479         * corelow.c: Do not include sys/file.h.
10480
10481 2019-01-22  Tom Tromey  <tom@tromey.com>
10482
10483         * tui/tui-wingeneral.h: Include gdb_curses.h.
10484
10485 2019-01-22  Tom Tromey  <tom@tromey.com>
10486
10487         * source-cache.h (class source_cache) <get_source_lines,
10488         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10489
10490 2019-01-22  Tom Tromey  <tom@tromey.com>
10491
10492         * remote-fileio.h (struct remote_target): Declare.
10493
10494 2019-01-22  Tom Tromey  <tom@tromey.com>
10495
10496         * python/py-arch.c: Do not include py-ref.h.
10497         * python/py-bpevent.c: Do not include py-ref.h.
10498         * python/py-cmd.c: Do not include py-ref.h.
10499         * python/py-continueevent.c: Do not include py-ref.h.
10500         * python/py-event.h: Do not include py-ref.h.
10501         * python/py-evtregistry.c: Do not include py-ref.h.
10502         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10503         * python/py-frame.c: Do not include py-ref.h.
10504         * python/py-framefilter.c: Do not include py-ref.h.
10505         * python/py-function.c: Do not include py-ref.h.
10506         * python/py-infevents.c: Do not include py-ref.h.
10507         * python/py-linetable.c: Do not include py-ref.h.
10508         * python/py-objfile.c: Do not include py-ref.h.
10509         * python/py-param.c: Do not include py-ref.h.
10510         * python/py-prettyprint.c: Do not include py-ref.h.
10511         * python/py-progspace.c: Do not include py-ref.h.
10512         * python/py-symbol.c: Do not include py-ref.h.
10513         * python/py-symtab.c: Do not include py-ref.h.
10514         * python/py-type.c: Do not include py-ref.h.
10515         * python/py-unwind.c: Do not include py-ref.h.
10516         * python/py-utils.c: Do not include py-ref.h.
10517         * python/py-value.c: Do not include py-ref.h.
10518         * python/py-varobj.c: Do not include py-ref.h.
10519         * python/py-xmethods.c: Do not include py-ref.h.
10520         * python/python.c: Do not include py-ref.h.
10521         * varobj.c: Do not include py-ref.h.
10522
10523 2019-01-22  Tom Tromey  <tom@tromey.com>
10524
10525         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10526         keyword for bcache.
10527
10528 2019-01-22  Tom Tromey  <tom@tromey.com>
10529
10530         * compile/compile-cplus-types.c: Remove a comment by #include.
10531
10532 2019-01-22  Tom Tromey  <tom@tromey.com>
10533
10534         * compile/gcc-c-plugin.h: Include compile-internal.h.
10535
10536 2019-01-22  Tom Tromey  <tom@tromey.com>
10537
10538         * stabsread.c (EXTERN): Do not define.
10539         (symnum, next_symbol_text_func, processing_gcc_compilation)
10540         (within_function, global_sym_chain, global_stabs)
10541         (previous_stab_code, this_object_header_files)
10542         (n_this_object_header_files)
10543         (n_allocated_this_object_header_files): Define.
10544         * stabsread.h (EXTERN): Never define.  Use "extern".
10545
10546 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10547
10548         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10549         history_value.
10550
10551 2019-01-21  Tom Tromey  <tom@tromey.com>
10552
10553         * ui-out.c: Fix includes.
10554         * tui/tui-source.c: Fix includes.
10555         * target.c: Fix includes.
10556         * remote.c: Fix includes.
10557         * regcache.c: Fix includes.
10558         * python/py-block.c: Fix includes.
10559         * printcmd.c: Fix includes.
10560         * or1k-tdep.c: Fix includes.
10561         * mi/mi-main.c: Fix includes.
10562         * m32r-tdep.c: Fix includes.
10563         * csky-tdep.c: Fix includes.
10564         * compile/compile-cplus-types.c: Fix includes.
10565         * cli/cli-interp.c: Fix includes.
10566
10567 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10568
10569         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10570         for padding.
10571
10572 2019-01-16  Tom Tromey  <tom@tromey.com>
10573
10574         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10575         earlier.
10576         (struct objfile) <msymbols_range>: Move from top level.
10577         <msymbols>: New method.
10578         (class objfile_msymbols): Remove.
10579         * symtab.c (default_collect_symbol_completion_matches_break_on):
10580         Update.
10581         * symmisc.c (dump_msymbols): Update.
10582         * stabsread.c (scan_file_globals): Update.
10583         * objc-lang.c (info_selectors_command, info_classes_command)
10584         (find_methods): Update.
10585         * minsyms.c (find_solib_trampoline_target): Update.
10586         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10587         * coffread.c (coff_symfile_read): Update.
10588         * ada-lang.c (ada_lookup_simple_minsym)
10589         (ada_collect_symbol_completion_matches): Update.
10590
10591 2019-01-16  Tom Tromey  <tom@tromey.com>
10592
10593         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10594         type.  Remove no-argument constructor.
10595         <iterator::operator++>: Simplify.
10596         <begin>: Update.
10597         <end>: Use minimal_symbol_count.
10598
10599 2019-01-16  Tom Tromey  <tom@tromey.com>
10600
10601         * objfiles.h (struct objfile) <psymtabs>: New method.
10602         (class objfile_psymtabs): Remove.
10603         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10604         typedef.
10605         <range>: New method.
10606         (require_partial_symbols): Change return type.
10607         * psymtab.c (require_partial_symbols)
10608         (psym_expand_symtabs_matching): Update.
10609         * mdebugread.c (parse_partial_symbols): Update.
10610         * dbxread.c (dbx_end_psymtab): Update.
10611
10612 2019-01-15  Tom Tromey  <tom@tromey.com>
10613
10614         * symtab.c (lookup_objfile_from_block)
10615         (lookup_symbol_in_objfile_symtabs)
10616         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10617         (find_line_symtab, info_sources_command)
10618         (default_collect_symbol_completion_matches_break_on)
10619         (make_source_files_completion_list): Update.
10620         * symmisc.c (print_objfile_statistics, dump_objfile)
10621         (maintenance_print_symbols, maintenance_info_symtabs)
10622         (maintenance_check_symtabs, maintenance_info_line_tables):
10623         Update.
10624         * source.c (select_source_symtab)
10625         (forget_cached_source_info_for_objfile): Update.
10626         * objfiles.h (class objfile_compunits): Remove.
10627         (struct objfile) <compunits_range>: New typedef.
10628         (compunits): New method.
10629         * objfiles.c (objfile_relocate1): Update.
10630         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10631         * maint.c (count_symtabs_and_blocks): Update.
10632         * linespec.c (iterate_over_all_matching_symtabs): Update.
10633         * cp-support.c (add_symbol_overload_list_qualified): Update.
10634         * coffread.c (coff_symtab_read): Update.
10635         * ada-lang.c (add_nonlocal_symbols)
10636         (ada_collect_symbol_completion_matches)
10637         (ada_add_global_exceptions): Update.
10638
10639 2019-01-15  Tom Tromey  <tom@tromey.com>
10640
10641         * progspace.h (program_space) <objfiles_safe_range>: New
10642         typedef.
10643         <objfiles_safe>: New method.
10644         * objfiles.h (class all_objfiles_safe): Remove.
10645         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10646         * jit.c (jit_inferior_exit_hook): Update.
10647
10648 2019-01-17  Tom Tromey  <tom@tromey.com>
10649
10650         * progspace.h (program_space) <objfiles_range>: New typedef.
10651         <objfiles>: New method.
10652         <objfiles_head>: Rename from objfiles.
10653         (object_files): Update.
10654         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10655         * guile/scm-pretty-print.c
10656         (ppscm_find_pretty_printer_from_objfiles): Update.
10657         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10658         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10659         Update.
10660         * python/py-progspace.c (pspy_get_objfiles): Update.
10661         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10662         Update.
10663         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10664         (objfpy_lookup_objfile_by_build_id): Update.
10665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10666         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10667         Update.
10668         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10669         (expand_symtab_containing_pc, lookup_objfile_from_block)
10670         (lookup_static_symbol, basic_lookup_transparent_type)
10671         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10672         (find_line_symtab, info_sources_command)
10673         (default_collect_symbol_completion_matches_break_on)
10674         (make_source_files_completion_list, find_main_name): Update.
10675         * symmisc.c (print_symbol_bcache_statistics)
10676         (print_objfile_statistics, maintenance_print_symbols)
10677         (maintenance_print_msymbols, maintenance_print_objfiles)
10678         (maintenance_info_symtabs, maintenance_check_symtabs)
10679         (maintenance_expand_symtabs, maintenance_info_line_tables):
10680         Update.
10681         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10682         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10683         (map_overlay_command, unmap_overlay_command)
10684         (simple_overlay_update, expand_symtabs_matching)
10685         (map_symbol_filenames): Update.
10686         * symfile-debug.c (set_debug_symfile): Update.
10687         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10688         Update.
10689         * source.c (select_source_symtab, forget_cached_source_info):
10690         Update.
10691         * solib.c (solib_read_symbols): Update.
10692         * solib-spu.c (append_ocl_sos): Update.
10693         * psymtab.c (maintenance_print_psymbols)
10694         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10695         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10696         * printcmd.c (info_symbol_command): Update.
10697         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10698         Update.
10699         * objfiles.h (class all_objfiles): Remove.
10700         * objfiles.c (have_partial_symbols, have_full_symbols)
10701         (have_minimal_symbols, qsort_cmp, update_section_map)
10702         (shared_objfile_contains_address_p)
10703         (default_iterate_over_objfiles_in_search_order): Update.
10704         * objc-lang.c (info_selectors_command, info_classes_command)
10705         (find_methods): Update.
10706         * minsyms.c (find_solib_trampoline_target): Update.
10707         * maint.c (maintenance_info_sections)
10708         (maintenance_translate_address, count_symtabs_and_blocks):
10709         Update.
10710         * main.c (captured_main_1): Update.
10711         * linux-thread-db.c (try_thread_db_load_from_pdir)
10712         (has_libpthread): Update.
10713         * linespec.c (iterate_over_all_matching_symtabs)
10714         (search_minsyms_for_name): Update.
10715         * jit.c (jit_find_objf_with_entry_addr): Update.
10716         * hppa-tdep.c (find_unwind_entry)
10717         (hppa_lookup_stub_minimal_symbol): Update.
10718         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10719         Update.
10720         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10721         (elf_gnu_ifunc_resolve_by_got): Update.
10722         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10723         * dwarf-index-write.c (save_gdb_index_command): Update.
10724         * cp-support.c (add_symbol_overload_list_qualified): Update.
10725         * breakpoint.c (create_overlay_event_breakpoint)
10726         (create_longjmp_master_breakpoint)
10727         (create_std_terminate_master_breakpoint)
10728         (create_exception_master_breakpoint): Update.
10729         * blockframe.c (find_pc_partial_function): Update.
10730         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10731         (ada_collect_symbol_completion_matches)
10732         (ada_add_global_exceptions): Update.
10733
10734 2019-01-17  Tom Tromey  <tom@tromey.com>
10735
10736         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10737         declare VEC.
10738         (solib_target_parse_libraries): Change return type.
10739         (library_list_start_segment, library_list_start_section)
10740         (library_list_end_library, library_list_start_library); Update.
10741         (solib_target_free_library_list): Remove.
10742         (solib_target_parse_libraries): Remove cleanup.  Change return
10743         type.
10744         (solib_target_current_sos): Update.
10745
10746 2019-01-17  Tom Tromey  <tromey@bapiya>
10747
10748         * valprint.c: Replace "the the" with "the".
10749         * symtab.c: Replace "the the" with "the".
10750         * solib.c: Replace "the the" with "the".
10751         * solib-dsbt.c: Replace "the the" with "the".
10752         * linespec.c: Replace "the the" with "the".
10753         * dwarf2loc.h: Replace "the the" with "the".
10754         * amd64-windows-tdep.c: Replace "the the" with "the".
10755         * aarch64-tdep.c: Replace "the the" with "the".
10756
10757 2019-01-16  Keith Seitz  <keiths@redhat.com>
10758
10759         PR gdb/23773
10760         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10761         <builder>: Rename to ..
10762         <m_builder>: ... this and make private.
10763         (dwarf2_cu::get_builder): New method.  Change all users of
10764         `builder' to use this method.
10765         (dwarf2_start_symtab): Move to ...
10766         (dwarf2_cu::start_symtab): ... here.  Update all callers
10767         (setup_type_unit_groups): Move to ...
10768         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10769         callers.
10770         (dwarf2_cu::reset_builder): New method.
10771         (process_full_compunit, process_full_type_unit): Use
10772         dwarf2_cu::reset_builder.
10773         (follow_die_offset): Record the ancestor CU if it is different
10774         from the followed DIE's CU.
10775         (follow_die_sig_1): Likewise.
10776
10777 2019-01-15  Tom Tromey  <tom@tromey.com>
10778
10779         * remote.c (class remote_state) <buf>: Now a char_vector.
10780         <buf_size>: Remove.
10781         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10782         parameter.
10783         (remote_target::getpkt_or_notif_sane_1)
10784         (remote_target::getpkt_sane)
10785         (remote_target::getpkt_or_notif_sane): Likewise.
10786         (class remote_target) <putpkt>: New overload.
10787         (remote_target::read_frame): Change type of "buf_p".  Remove
10788         sizeof_p parameter.
10789         (packet_ok): New overload.
10790         (packet_check_result): New overload.
10791         Update all uses.
10792
10793 2019-01-14  Tom Tromey  <tom@tromey.com>
10794
10795         * remote-notif.c (handle_notification, remote_notif_ack)
10796         (remote_notif_parse): Make "buf" const.
10797         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10798         const.
10799         (remote_notif_parse, remote_notif_ack, handle_notification):
10800         Likewise.
10801         * remote.c (remote_notif_stop_parse): Make "buf" const.
10802         (remote_target::remote_parse_stop_reply): Make "buf" const.
10803         (remote_notif_stop_ack): Make "buf" const.
10804
10805 2019-01-14  Tom Tromey  <tom@tromey.com>
10806
10807         * remote.c (remote_console_output): Make parameter const.
10808
10809 2019-01-14  Tom Tromey  <tom@tromey.com>
10810
10811         * target-debug.h (target_debug_print_signals): Constify.
10812         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10813         * procfs.c (procfs_target::pass_signals): Update.
10814         * linux-nat.c (linux_nat_target::pass_signals): Update.
10815         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10816         * target-delegates.c: Rebuild.
10817         * remote.c (remote_target::program_signals): Update.
10818         (remote_target::pass_signals): Update.
10819         * target.c (target_pass_signals): Constify argument.
10820         (target_program_signals): Likewise.
10821         * target.h (struct target_ops) <pass_signals, program_signals>:
10822         Constify argument.
10823         (target_pass_signals, target_program_signals): Constify argument.
10824
10825 2019-01-14  Tom Tromey  <tom@tromey.com>
10826
10827         PR tui/28819:
10828         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10829
10830 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10831
10832         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10833         field.
10834         * rs6000-tdep.c: Include reggroups.h.
10835         (IS_V_ALIAS_PSEUDOREG): Define.
10836         (rs6000_register_name): Return names for the "vX" aliases.
10837         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10838         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10839         aliases.  Call default_register_reggroup_p for all other
10840         pseudo-registers.
10841         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10842         New functions.
10843         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10844         Handle "vX" aliases.
10845         (v_alias_pseudo_register_collect): New function.
10846         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10847         (rs6000_gdbarch_init): Initialize "vX" aliases as
10848         pseudo-registers.  Restore registration of
10849         rs6000_pseudo_register_reggroup_p with
10850         set_tdesc_pseudo_register_reggroup_p.
10851
10852 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10853
10854         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10855         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10856         set_gdbarch_num_pseudo_regs.
10857
10858 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10859
10860         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10861         Remove arg prefixname, add do_set and do_show.
10862         Add member functions set_list and show_list.
10863         * cli/cli-style.c (class cli_style_option): Update accordingly.
10864         (style_set_list): Move to file scope.
10865         (style_show_list): Likewise.
10866         (set_style): Call help_list.
10867         (show_style): Call cmd_show_list.
10868         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10869         Update to use the new macro.
10870
10871 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10872
10873         * ada-lang.c (_initialize_ada_language): Expand the help text
10874         for the "catch exception" command.
10875
10876 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10877
10878         * symtab.c (matching_obj_sections): Initialize obj,
10879         declare it closer to its usage.
10880
10881 2019-01-10  Tom Tromey  <tom@tromey.com>
10882
10883         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10884         (basic_inf_threads_range): Remove.
10885         (inf_threads_range, inf_non_exited_threads_range)
10886         (safe_inf_threads_range): Use next_adapter.
10887
10888 2019-01-10  Keith Seitz  <keiths@redhat.com>
10889
10890         PR gdb/23712
10891         PR symtab/23010
10892         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10893         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10894
10895 2019-01-10  Keith Seitz  <keiths@redhat.com>
10896
10897         PR gdb/23712
10898         PR symtab/23010
10899         * dictionary.c (pending_to_vector): Remove.
10900         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10901         Remove _1 suffix, replacing functions of the same name.  Update
10902         all callers.
10903         (dict_create_hashed, dict_create_hashed_expandable)
10904         (dict_create_linear, dict_create_linear_expandable, dict_free)
10905         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10906         Make functions static.
10907
10908 2019-01-10  Keith Seitz  <keiths@redhat.com>
10909
10910         PR gdb/23712
10911         PR symtab/23010
10912         * dictionary.h (struct dictionary): Replace declaration with
10913         multidictionary.
10914         (dict_create_hashed, dict_create_hashed_expandable)
10915         (dict_create_linear, dict_create_linear_expandable)
10916         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10917         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10918         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10919         taking multidictionary argument.
10920         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10921         * block.h (struct block) <dict>: Change to multidictionary
10922         and rename `multidict'.
10923         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10924         symmisc.c: Update all dictionary references to multidictionary.
10925
10926 2019-01-10  Keith Seitz  <keiths@redhat.com>
10927
10928         PR gdb/23712
10929         PR symtab/23010
10930         * dictionary.c: Include unordered_map.
10931         (pending_to_vector): New function.
10932         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10933         Rewrite the non-"_1" functions to take vector instead
10934         of linked list.
10935         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10936         "new" _1 versions of the same name.
10937         (multidictionary): Define.
10938         (std::hash<enum language): New definition.
10939         (collate_pending_symbols_by_language, mdict_create_hashed)
10940         (mdict_create_hashed_expandable, mdict_create_linear)
10941         (mdict_create_linear_expandable, mdict_free)
10942         (find_language_dictionary, create_new_language_dictionary)
10943         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10944         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10945         (mdict_size, mdict_empty): New functions.
10946         * dictionary.h (mdict_iterator): Define.
10947
10948 2019-01-10  Pedro Alves  <palves@redhat.com>
10949
10950         * breakpoint.c (read_uploaded_action)
10951         (create_tracepoint_from_upload): Adjust to use
10952         gdb::unique_xmalloc_ptr.
10953         * ctf.c (ctf_write_uploaded_tp):
10954         (SET_ARRAY_FIELD): Use emplace_back.
10955         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10956         * tracefile-tfile.c (tfile_write_uploaded_tp):
10957         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10958         gdb::unique_xmalloc_ptr.
10959         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10960         at_string, cond_string, cmd_strings>: Replace char pointers
10961         with gdb::unique_xmalloc_ptr.
10962
10963 2019-01-10  Pedro Alves  <palves@redhat.com>
10964
10965         * solib-target.c (library_list_start_library): Don't xstrdup name.
10966
10967 2019-01-10  Pedro Alves  <palves@redhat.com>
10968
10969         * mdebugread.c (parse_partial_symbols): Use
10970         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10971
10972 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10973
10974         * linux-fork.c (scoped_switch_fork_info)
10975         <~scoped_switch_fork_info>: Fix incorrect variable name.
10976
10977 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10978
10979         * linux-fork.c (scoped_switch_fork_info)
10980         <scoped_switch_fork_info>: Make explicit.
10981         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10982
10983 2019-01-10  Tom Tromey  <tom@tromey.com>
10984
10985         * objfiles.h (objfile::reset_psymtabs): Update.
10986         * objfiles.c (objfile::objfile): Update.
10987         * psymtab.h (psymtab_storage::obstack): Update.
10988         (psymtab_storage::m_obstack): Use gdb::optional.
10989         (class psymtab_storage): Update comment.  Remove objfile
10990         parameter.
10991         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10992
10993 2019-01-10  Tom Tromey  <tom@tromey.com>
10994
10995         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10996         <free_psymtabs>: Now private.
10997         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10998         (allocate_psymtab): Use new method.
10999
11000 2019-01-10  Tom Tromey  <tom@tromey.com>
11001
11002         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11003         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11004         * mdebugread.c (parse_partial_symbols): Use
11005         allocate_dependencies.
11006         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11007         allocate_dependencies.
11008         (process_psymtab_comp_unit_reader)
11009         (build_type_psymtab_dependencies): Likewise.
11010         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11011
11012 2019-01-10  Tom Tromey  <tom@tromey.com>
11013
11014         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11015         PSYMBOL_SET_LANGUAGE.
11016         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11017
11018 2019-01-10  Tom Tromey  <tom@tromey.com>
11019
11020         * psymtab.h (psymtab_storage::obstack): New method.
11021         <m_obstack>: Rename from obstack; now private.
11022         * psymtab.c (psymtab_storage): Update.
11023         * dwarf2read.c (create_addrmap_from_index)
11024         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11025         Update.
11026
11027 2019-01-10  Tom Tromey  <tom@tromey.com>
11028
11029         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11030         * objfiles.h (objfile::reset_psymtabs): New method.
11031
11032 2019-01-10  Tom Tromey  <tom@tromey.com>
11033
11034         * symmisc.c (print_symbol_bcache_statistics): Update.
11035         (print_objfile_statistics): Update.
11036         * symfile.c (reread_symbols): Update.
11037         * psymtab.h (class psymtab_storage): New.
11038         * psymtab.c (psymtab_storage): New constructor.
11039         (~psymtab_storage): New destructor.
11040         (require_partial_symbols): Update.
11041         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11042         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11043         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11044         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11045         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11046         (start_psymtab_common, end_psymtab_common)
11047         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11048         (allocate_psymtab): Update.
11049         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11050         Update.
11051         (dump_psymtab_addrmap, maintenance_print_psymbols)
11052         (maintenance_check_psymtabs): Update.
11053         (class objfile_psymtabs): Move to objfiles.h.
11054         * psympriv.h (discard_psymtab): Now inline.
11055         (psymtab_discarder::psymtab_discarder): Update.
11056         (psymtab_discarder::~psymtab_discarder): Update.
11057         (ALL_OBJFILE_PSYMTABS): Rewrite.
11058         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11059         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11060         Remove fields.
11061         <partial_symtabs>: New field.
11062         (class objfile_psymtabs): Move from psymtab.h.  Update.
11063         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11064         psymbol_cache.
11065         (objfile::~objfile): Don't destroy psymbol_cache.
11066         * mdebugread.c (parse_partial_symbols): Update.
11067         * dwarf2read.c (create_addrmap_from_index)
11068         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11069         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11070         (add_partial_subprogram, dwarf2_ranges_read): Update.
11071         * dwarf-index-write.c (write_address_map)
11072         (write_one_signatured_type, recursively_write_psymbols)
11073         (class debug_names, class debug_names, write_psymtabs_to_index):
11074         Update.
11075
11076 2019-01-10  Tom Tromey  <tom@tromey.com>
11077
11078         * symtab.h (SYMBOL_SET_NAMES): Update.
11079         (symbol_set_names): Update.
11080         (MSYMBOL_SET_NAMES): Update.
11081         * symtab.c (symbol_set_names): Change argument to be an
11082         objfile_per_bfd_storage.
11083         * psymtab.c (add_psymbol_to_bcache): Update.
11084         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11085
11086 2019-01-10  Tom Tromey  <tom@tromey.com>
11087
11088         * symtab.c (create_demangled_names_hash): Change argument to be an
11089         objfile_per_bfd_storage.
11090         (symbol_set_names): Update.
11091
11092 2019-01-10  Tom Tromey  <tom@tromey.com>
11093
11094         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11095         init_psymbol_list.
11096         * psymtab.c (init_psymbol_list): Do nothing if already called.
11097         * psympriv.h (init_psymbol_list): Add comment.
11098         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11099         init_psymbol_list.
11100         * dbxread.c (dbx_symfile_read): Unconditionally call
11101         init_psymbol_list.
11102
11103 2019-01-10  Tom Tromey  <tom@tromey.com>
11104
11105         * xcoffread.c (scan_xcoff_symtab): Update.
11106         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11107         "where".
11108         * mdebugread.c (parse_partial_symbols)
11109         (handle_psymbol_enumerators): Update.
11110         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11111         * dbxread.c (read_dbx_symtab): Update.
11112         * psympriv.h (psymbol_placement): New enum.
11113         (add_psymbol_to_list): Update.
11114
11115 2019-01-10  Tom Tromey  <tom@tromey.com>
11116
11117         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11118         static_psymbols parameters.
11119         (scan_xcoff_symtab): Update.
11120         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11121         static_psymbols parameters.
11122         * psympriv.h (start_psymtab_common): Update.
11123         * mdebugread.c (parse_partial_symbols): Update.
11124         * dwarf2read.c (create_partial_symtab): Update.
11125         * dbxread.c (read_dbx_symtab): Update.
11126         (start_psymtab): Remove global_psymbols and static_psymbols
11127         parameters.
11128
11129 2019-01-10  Tom Tromey  <tom@tromey.com>
11130
11131         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11132         * psymtab.c (allocate_psymtab): Add comment.
11133         * psympriv.h (allocate_psymtab): Add comment.
11134         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11135         initializations.
11136         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11137
11138 2019-01-10  Tom Tromey  <tom@tromey.com>
11139
11140         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11141         Don't declare.
11142         * mipsread.c: Include mdebugread.h.
11143         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11144         Declare.
11145         * elfread.c: Include mdebugread.h.
11146
11147 2019-01-09  Tom Tromey  <tom@tromey.com>
11148
11149         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11150         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11151         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11152         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11153         (psym_lookup_symbol, psym_find_last_source_symtab)
11154         (psym_forget_cached_source_info, psym_print_stats)
11155         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11156         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11157         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11158         (psym_find_compunit_symtab_by_address)
11159         (maintenance_print_psymbols, maintenance_info_psymtabs)
11160         (maintenance_check_psymtabs): Use ranged for.
11161         * psymtab.h (class objfile_psymtabs): New.
11162         (require_partial_symbols): Return objfile_psymtabs.
11163         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11164
11165 2019-01-09  Tom Tromey  <tom@tromey.com>
11166
11167         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11168         (find_pc_mapped_section, list_overlays_command)
11169         (map_overlay_command, unmap_overlay_command)
11170         (simple_overlay_update): Use all_objfiles.
11171         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11172         * printcmd.c (info_symbol_command): Use all_objfiles.
11173         * objfiles.h (ALL_OBJSECTIONS): Remove.
11174         * maint.c (maintenance_translate_address): Use all_objfiles.
11175         * gcore.c (gcore_create_callback): Use all_objfiles.
11176         (objfile_find_memory_regions): Likewise.
11177
11178 2019-01-09  Tom Tromey  <tom@tromey.com>
11179
11180         * symtab.c (find_line_symtab, info_sources_command)
11181         (make_source_files_completion_list): Use objfile_compunits.
11182         * source.c (select_source_symtab): Use objfile_compunits.
11183         * objfiles.h (struct objfile): Update comment.
11184         (ALL_OBJFILES): Remove.
11185         (ALL_FILETABS): Remove.
11186         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11187         objfile_compunits.
11188
11189 2019-01-09  Tom Tromey  <tom@tromey.com>
11190
11191         * symmisc.c (print_objfile_statistics, dump_objfile)
11192         (maintenance_print_symbols): Use compunit_filetabs.
11193         * source.c (forget_cached_source_info_for_objfile): Use
11194         compunit_filetabs.
11195         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11196         (ALL_FILETABS): Use compunit_filetabs.
11197         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11198         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11199
11200 2019-01-09  Tom Tromey  <tom@tromey.com>
11201
11202         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11203         (compunit_filetabs): New.
11204         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11205         compunit_filetabs.
11206         (info_sources_command, make_source_files_completion_list): Remove
11207         declaration.
11208         * symmisc.c (print_objfile_statistics, dump_objfile)
11209         (maintenance_print_symbols): Remove declaration.
11210         (maintenance_info_symtabs): Use compunit_filetabs.
11211         (maintenance_info_line_tables): Likewise.
11212         * source.c (select_source_symtab): Change local variable name.
11213         (forget_cached_source_info_for_objfile): Remove declaration.
11214         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11215         * objfiles.c (objfile_relocate1): Remove declaration.
11216         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11217         declaration.
11218         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11219         * coffread.c (coff_symtab_read): Remove declaration.
11220         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11221         compunit_filetabs.
11222
11223 2019-01-09  Tom Tromey  <tom@tromey.com>
11224
11225         * symtab.c (lookup_objfile_from_block)
11226         (find_pc_sect_compunit_symtab, search_symbols)
11227         (default_collect_symbol_completion_matches_break_on): Use
11228         objfile_compunits.
11229         * objfiles.h (ALL_COMPUNITS): Remove.
11230         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11231         * cp-support.c (add_symbol_overload_list_qualified): Use
11232         objfile_compunits.
11233         * ada-lang.c (ada_collect_symbol_completion_matches)
11234         (ada_add_global_exceptions): Use objfile_compunits.
11235
11236 2019-01-09  Tom Tromey  <tom@tromey.com>
11237
11238         * source.c (select_source_symtab)
11239         (forget_cached_source_info_for_objfile): Remove declaration.
11240         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11241         declaration.
11242         * maint.c (count_symtabs_and_blocks): Remove declaration.
11243         * cp-support.c (add_symbol_overload_list_qualified): Remove
11244         declaration.
11245         * coffread.c (coff_symtab_read): Remove declaration.
11246         * symtab.c (lookup_symbol_in_objfile_symtabs)
11247         (basic_lookup_transparent_type_1): Use objfile_compunits.
11248         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11249         (info_sources_command, search_symbols)
11250         (default_collect_symbol_completion_matches_break_on)
11251         (make_source_files_completion_list): Remove declaration.
11252         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11253         (ada_collect_symbol_completion_matches)
11254         (ada_add_global_exceptions): Remove declaration.
11255         * linespec.c (iterate_over_all_matching_symtabs): Use
11256         objfile_compunits.
11257         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11258         (class objfile_compunits): New.
11259         (ALL_COMPUNITS): Use objfile_compunits.
11260         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11261         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11262         objfile_compunits.
11263         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11264
11265 2019-01-09  Tom Tromey  <tom@tromey.com>
11266
11267         * symtab.c (search_symbols)
11268         (default_collect_symbol_completion_matches_break_on): Use
11269         objfile_msymbols.
11270         * ada-lang.c (ada_lookup_simple_minsym)
11271         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11272         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11273         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11274         objfile_msymbols.
11275         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11276         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11277         * objc-lang.c (find_methods): Use objfile_msymbols.
11278         (info_selectors_command, info_classes_command): Likewise.
11279         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11280         * objfiles.h (class objfile_msymbols): New.
11281         (ALL_OBJFILE_MSYMBOLS): Remove.
11282         (ALL_MSYMBOLS): Remove.
11283
11284 2019-01-09  Tom Tromey  <tom@tromey.com>
11285
11286         * common/next-iterator.h (next_adapter): Add Iterator template
11287         parameter.
11288         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11289         (class all_objfiles_safe): New.
11290         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11291         * objfiles.c (put_objfile_before): Update comment.
11292         (add_separate_debug_objfile): Likewise.
11293         (free_all_objfiles): Use all_objfiles_safe.
11294         (objfile_purge_solibs): Likewise.
11295
11296 2019-01-09  Tom Tromey  <tom@tromey.com>
11297
11298         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11299         (expand_symtab_containing_pc, lookup_static_symbol)
11300         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11301         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11302         all_objfiles.
11303         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11304         * breakpoint.c (create_overlay_event_breakpoint)
11305         (create_longjmp_master_breakpoint)
11306         (create_std_terminate_master_breakpoint)
11307         (create_exception_master_breakpoint): Use all_objfiles.
11308         * linux-thread-db.c (try_thread_db_load_from_pdir)
11309         (has_libpthread): Use all_objfiles.
11310         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11311         * linespec.c (iterate_over_all_matching_symtabs)
11312         (search_minsyms_for_name): Use all_objfiles.
11313         * maint.c (maintenance_info_sections): Use all_objfiles.
11314         * main.c (captured_main_1): Use all_objfiles.
11315         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11316         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11317         * guile/scm-pretty-print.c
11318         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11319         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11320         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11321         (maintenance_print_msymbols): Use all_objfiles.
11322         * source.c (select_source_symtab): Use all_objfiles.
11323         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11324         * symfile.c (remove_symbol_file_command)
11325         (expand_symtabs_matching, map_symbol_filenames): Use
11326         all_objfiles.
11327         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11328         all_objfiles.
11329         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11330         * objc-lang.c (find_methods): Use all_objfiles.
11331         * objfiles.c (have_partial_symbols, have_full_symbols)
11332         (have_minimal_symbols, qsort_cmp)
11333         (default_iterate_over_objfiles_in_search_order): Use
11334         all_objfiles.
11335         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11336         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11337         (maintenance_check_psymtabs): Use all_objfiles.
11338         (ALL_PSYMTABS): Remove.
11339         * compile/compile-object-run.c (do_module_cleanup): Use
11340         all_objfiles.
11341         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11342         * cp-support.c (add_symbol_overload_list_qualified): Use
11343         all_objfiles.
11344         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11345         Use all_objfiles.
11346         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11347         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11348         all_objfiles.
11349         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11350         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11351         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11352         Uses all_objfiles.
11353         * solib.c (solib_read_symbols): Use all_objfiles
11354
11355 2019-01-09  Tom Tromey  <tom@tromey.com>
11356
11357         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11358         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11359         all_objfiles.
11360         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11361         * symmisc.c (print_symbol_bcache_statistics)
11362         (print_objfile_statistics, maintenance_print_objfiles)
11363         (maintenance_info_symtabs, maintenance_check_symtabs)
11364         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11365         all_objfiles.
11366         * source.c (forget_cached_source_info): Use all_objfiles.
11367         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11368         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11369         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11370         * objfiles.c (update_section_map): Use all_objfiles.
11371         (shared_objfile_contains_address_p): Likewise.
11372         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11373         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11374
11375 2019-01-09  Tom Tromey  <tom@tromey.com>
11376
11377         * common/next-iterator.h: New file.
11378         * objfiles.h (class all_objfiles): New.
11379         (struct objfile_iterator): New.
11380
11381 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11382
11383         * NEWS: Move the description of the changed "frame", "select-frame",
11384          and "info frame" commands to the Changed commands section.
11385
11386 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11387
11388         * gdbtypes.c (check_stub_method_group): Remove handling of old
11389         mangling schemes.
11390         * linespec.c (find_methods): Likewise.
11391         * stabsread.c (read_member_functions): Likewise.
11392         * valops.c (search_struct_method): Likewise.
11393         (value_struct_elt_for_reference): Likewise.
11394         * NEWS: Mention this change.
11395
11396 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11397
11398         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11399         print_source_lines.
11400         * source.c (print_source_lines_base): Update line number check.
11401         (print_source_lines): New function.
11402         (source_lines_range::source_lines_range): New function.
11403         * source.h (class source_lines_range): New class.
11404         (print_source_lines): New declaration.
11405
11406 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11407
11408         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11409
11410 2019-01-08  Tom Tromey  <tom@tromey.com>
11411             Simon Marchi  <simon.marchi@ericsson.com>
11412
11413         PR gdb/24060
11414         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11415         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11416         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11417         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11418         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11419         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11420
11421 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11422
11423         * source.c (select_source_symtab): Move header comment to
11424         declaration in source.h.
11425         (forget_cached_source_info_for_objfile): Likewise.
11426         (forget_cached_source_info): Likewise.
11427         (identify_source_line): Likewise.
11428         * source.h (identify_source_line): Move declaration from symtab.h
11429         and add comment from source.c
11430         (print_source_lines): Likewise.
11431         (forget_cached_source_info_for_objfile): Likewise.
11432         (forget_cached_source_info): Likewise.
11433         (select_source_symtab): Likewise.
11434         (enum print_source_lines_flag): Move definition from symtab.h.
11435         * symtab.h (identify_source_line): Move declaration to source.h.
11436         (print_source_lines): Likewise.
11437         (forget_cached_source_info_for_objfile): Likewise.
11438         (forget_cached_source_info): Likewise.
11439         (select_source_symtab): Likewise.
11440         (enum print_source_lines_flag): Move definition to source.h.
11441         * tui/tui-hooks.c: Add 'source.h' include.
11442
11443 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11444
11445         * source.c (print_source_lines_base): Handle requests to print
11446         reverse line number sequences, and guard against empty lines
11447         string.
11448
11449 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11450
11451         * source.c (print_source_lines_base): Fix skip of '\r' if next
11452         character is '\n'.
11453
11454 2019-01-06  Tom Tromey  <tom@tromey.com>
11455
11456         * c-exp.y (struct c_parse_state) <macro_original_text,
11457         expansion_obstack>: New member.
11458         (macro_original_text, expansion_obstack): Remove globals.
11459         (scan_macro_expansion, scanning_macro_expansion)
11460         (finished_macro_expansion): Update.
11461         (scan_macro_cleanup): Remove.
11462         (yylex, c_parse): Update.
11463
11464 2019-01-06  Tom Tromey  <tom@tromey.com>
11465
11466         * c-exp.y (struct c_parse_state) <strings>: New member.
11467         (operator_stoken): Update.
11468
11469 2019-01-06  Tom Tromey  <tom@tromey.com>
11470
11471         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11472         (union type_stack_elt) <typelist_val>: Now a pointer to
11473         std::vector.
11474         (type_stack_cleanup): Don't declare.
11475         (push_typelist): Update.
11476         * parse.c (pop_typelist): Return a std::vector.
11477         (push_typelist): Take a std::vector.
11478         (follow_types): Update.  Do not free args.
11479         (type_stack_cleanup): Remove.
11480         * c-exp.y (struct c_parse_state): New.
11481         (cpstate): New global.
11482         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11483         (nonempty_typelist): Update.
11484         (func_mod): Create a new vector.
11485         (c_parse): Create a c_parse_state.
11486         (check_parameter_typelist): Do not delete params.
11487         (function_method): Update.  Do not delete type_list.
11488
11489 2019-01-06  Tom Tromey  <tom@tromey.com>
11490
11491         PR gdb/28155:
11492         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11493         check_typedef.
11494         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11495         (print_return_value): Likewise.
11496
11497 2019-01-05  Tom Tromey  <tom@tromey.com>
11498
11499         * contrib/cleanup_check.py: Remove.
11500         * contrib/gcc-with-excheck: Remove.
11501         * contrib/exsummary.py: Remove.
11502         * contrib/excheck.py: Remove.
11503
11504 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11505
11506         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11507         NULL. Initialize tpprev to NULL instead of assigning it
11508         to NULL on the next statement.
11509         * windows-nat.c (windows_delete_thread): Remove check for
11510         main_thread_id before printing thread exit notifications.
11511         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11512         Remove thread ID check against main_thread_id.
11513         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11514         windows_delete_thread.
11515         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11516
11517 2019-01-04  Tom Tromey  <tom@tromey.com>
11518
11519         * compile/compile.c (_initialize_compile): Use upper case for
11520         metasyntactic variables.
11521         * symmisc.c (_initialize_symmisc): Use upper case for
11522         metasyntactic variables.
11523         * psymtab.c (_initialize_psymtab): Use upper case for
11524         metasyntactic variables.
11525         * demangle.c (demangle_command): Use upper case for metasyntactic
11526         variables.
11527         (_initialize_demangler): Likewise.
11528         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11529         variables.
11530
11531 2019-01-03  Tom Tromey  <tom@tromey.com>
11532
11533         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11534
11535 2019-01-03  Tom Tromey  <tom@tromey.com>
11536
11537         * python/py-symtab.c (salpy_str): Update.
11538         (struct salpy_sal_object) <symtab>: Now a PyObject.
11539         (salpy_dealloc): Update.
11540         (del_objfile_sal): Use gdbpy_ref.
11541
11542 2019-01-03  Tom Tromey  <tom@tromey.com>
11543
11544         * python/py-type.c (convert_field): Use new_reference.  Return
11545         gdbpy_ref.
11546         (make_fielditem): Return gdbpy_ref.
11547         (typy_fields): Update.
11548         (typy_getitem): Update.
11549         (field_name): Return gdbpy_ref.  Use new_reference.
11550         (typy_iterator_iternext): Update.
11551
11552 2019-01-03  Tom Tromey  <tom@tromey.com>
11553
11554         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11555
11556 2019-01-03  Tom Tromey  <tom@tromey.com>
11557
11558         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11559         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11560         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11561         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11562         (pspy_set_type_printers): Likewise.
11563         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11564         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11565         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11566         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11567         (objfpy_set_type_printers): Likewise.
11568
11569 2019-01-03  Tom Tromey  <tom@tromey.com>
11570
11571         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11572         (gdbpy_print_stack): Use gdbpy_err_fetch.
11573         * python/python-internal.h (class gdbpy_err_fetch): New class.
11574         (class gdbpy_enter) <m_error_type, m_error_value,
11575         m_error_traceback>: Remove.
11576         <m_error>: New member.
11577         (gdbpy_exception_to_string): Don't declare.
11578         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11579         * python/py-value.c (convert_value_from_python): Use
11580         gdbpy_err_fetch.
11581         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11582         gdbpy_exception_to_string.
11583         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11584         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11585         gdbpy_err_fetch.
11586
11587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11588
11589         * linux-nat.c (delete_lwp_cleanup): Delete.
11590         (struct lwp_deleter): New struct.
11591         (lwp_info_up): New typedef.
11592         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11593         lwp_info_up.
11594
11595 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11596
11597         * linux-fork.c (class scoped_switch_fork_info): New class.
11598         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11599
11600 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11601
11602         * valops.c (find_overload_match): Remove use of null_cleanup, and
11603         calls to do_cleanups.
11604
11605 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11606
11607         * compile/compile-cplus-types.c
11608         (compile_cplus_instance::decl_name): Handle changes to
11609         cp_func_name.
11610         * cp-support.c (cp_func_name): Update header comment, update
11611         return type.
11612         * cp-support.h (cp_func_name): Update return type in declaration.
11613         * valops.c (find_overload_match): Move temp_func local to top
11614         level of function and change its type.  Use temp_func to hold and
11615         delete temporary string obtained from cp_func_name.
11616
11617 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11618
11619         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11620         gdb::char_vector, remove cleanup, and update uses of `msg`.
11621
11622 2019-01-03  Jim Wilson  <jimw@sifive.com>
11623
11624         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11625
11626 2019-01-02  Tom Tromey  <tom@tromey.com>
11627
11628         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11629         (tdesc_parse_xml): Remove cleanups.
11630         * target-descriptions.h (make_cleanup_free_target_description):
11631         Don't declare.
11632         (target_desc_deleter): New struct.
11633         (target_desc_up): New typedef.
11634         * target-descriptions.c (target_desc_deleter::operator()): Rename
11635         from free_target_description.
11636         (make_cleanup_free_target_description): Remove.
11637
11638 2019-01-02  Tom Tromey  <tom@tromey.com>
11639
11640         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11641         constructor, destructor.
11642         (linespec_parser): Remove typedef.
11643         (~linespec_parser): Rename from linespec_parser_delete.
11644         (linespec_lex_to_end, linespec_complete_label)
11645         (linespec_complete): Update.
11646         (decode_line_full): Remove cleanups.
11647         (decode_line_1): Update.
11648
11649 2019-01-02  Tom Tromey  <tom@tromey.com>
11650
11651         * python/python-internal.h (inferior_to_inferior_object): Change
11652         return type.
11653         * python/py-exitedevent.c (create_exited_event_object): Update.
11654         * python/py-inferior.c (inferior_to_inferior_object): Return
11655         gdbpy_ref.
11656         (python_new_inferior, python_inferior_deleted)
11657         (thread_to_thread_object, delete_thread_object)
11658         (build_inferior_list, gdbpy_selected_inferior): Update.
11659         * python/py-infthread.c (create_thread_object): Update.  Also fail
11660         if inferior_to_inferior_object fails.
11661
11662 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11663
11664         * inferior.h (class inferior) <displaced_step_state>: New field.
11665         * infrun.h (struct displaced_step_state): Move here from
11666         infrun.c.  Initialize fields, add constructor.
11667         <inf>: Remove field.
11668         <reset>: New method.
11669         * infrun.c (struct displaced_step_inferior_state): Move to
11670         infrun.h.
11671         (displaced_step_inferior_states): Remove.
11672         (get_displaced_stepping_state): Adust.
11673         (displaced_step_in_progress_any_inferior): Adjust.
11674         (displaced_step_in_progress_thread): Adjust.
11675         (displaced_step_in_progress): Adjust.
11676         (add_displaced_stepping_state): Remove.
11677         (get_displaced_step_closure_by_addr): Adjust.
11678         (remove_displaced_stepping_state): Remove.
11679         (infrun_inferior_exit): Call displaced_step_state.reset.
11680         (use_displaced_stepping): Don't check for NULL.
11681         (displaced_step_prepare_throw): Call
11682         get_displaced_stepping_state.
11683         (displaced_step_fixup): Don't check for NULL.
11684         (prepare_for_detach): Don't check for NULL.
11685
11686 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11687
11688         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11689          in case of call that did not complete.
11690
11691 2019-01-02  Andrey Utkin  <autkin@undo.io>
11692
11693         * symfile.c (find_separate_debug_file): Fix search of debug files for
11694         remote debuggee.
11695
11696 2019-01-02  Tom Tromey  <tom@tromey.com>
11697
11698         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11699         indentation.
11700         * python/py-frame.c (frapy_older): Remove cast.
11701         (frapy_newer): Likewise.
11702         * python/py-breakpoint.c (local_setattro): Remove cast.
11703         * python/py-arch.c (archpy_name): Remove local variable.
11704         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11705
11706 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11707
11708         * unittests/basic_string_view/element_access/char/empty.cc:
11709         Fix year range in copyright header.
11710
11711 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11712
11713         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11714         Delete.
11715         <operator==>: Update with for removed field.
11716         <hash>: Likewise.
11717         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11718         <isa_features>: ...this.
11719         <abi_features>: New field.
11720         (riscv_isa_flen): Update comment.
11721         (riscv_abi_xlen): New declaration.
11722         (riscv_abi_flen): New declaration.
11723         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11724         isa_features.
11725         (riscv_abi_xlen): New function.
11726         (riscv_isa_flen): Update to get answer from isa_features.
11727         (riscv_abi_flen): New function.
11728         (riscv_has_fp_abi): Update to get answer from abi_features.
11729         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11730         xlen and flen.
11731         (riscv_call_info) <xlen, flen>: Update comment.
11732         (riscv_call_arg_struct): Remove invalid assertions
11733         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11734         is removed.
11735         (riscv_gdbarch_init): Gather isa features and abi features
11736         separately, ensure both match on the gdbarch when reusing an old
11737         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11738         a target with 64-bit float hardware.
11739
11740 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11741
11742         * source.c (search_command_helper): Stop reverse search
11743         when line 1 has been searched.
11744
11745 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11746
11747         * record-full.c (record_full_base_target::close): Rewrite
11748         record_full_core_buf_list free logic.
11749
11750 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11751
11752         * break-catch-syscall.c (print_one_catch_syscall): xfree
11753         the last text.
11754
11755 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11756
11757         * top.c (print_gdb_version): Update Copyright year in version
11758         message.
11759
11760 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11761
11762         Update copyright year range in all GDB files.
11763
11764 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11765
11766         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11767
11768 For older changes see ChangeLog-2018.
11769 \f
11770 Local Variables:
11771 mode: change-log
11772 left-margin: 8
11773 fill-column: 74
11774 version-control: never
11775 coding: utf-8
11776 End:
11777