gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_clear_source_content)
   4         (tui_show_source_content): Update.
   5         * tui/tui-source.c (tui_source_window::showing_source_p): Check
   6         whether content is empty.
   7         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
   8         Remove.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  13         window's contents.
  14         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  15         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  16
  17 2019-07-17  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  20         (struct tui_data_item_window): Update.
  21
  22 2019-07-17  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  25         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  26         defines.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-winsource.h (tui_erase_source_content)
  31         (tui_clear_source_content): Remove "display_prompt" parameter.
  32         * tui/tui-winsource.c (tui_update_source_window_as_is)
  33         (tui_update_source_windows_with_addr): Update.
  34         (tui_clear_source_content): Remove "display_prompt" parameter.
  35         (tui_erase_source_content): Likewise.  Simplify.
  36         (tui_show_source_content): Update.
  37         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  38         * tui/tui-stack.c (tui_show_frame_info): Update.
  39         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  40         Remove defines.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  45         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  46         parameter.
  47         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  48         parameter.
  49
  50 2019-07-17  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-winsource.c (tui_clear_source_content)
  53         (tui_show_source_content, tui_show_exec_info_content)
  54         (tui_clear_exec_info_content): Update.
  55         * tui/tui-stack.c (tui_show_locator_content): Update.
  56         (tui_show_frame_info): Update.
  57         * tui/tui-source.h (tui_source_window): Don't declare.
  58         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  59         from tui_source_is_displayed.
  60         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  61         Remove field.
  62         (struct tui_source_window_base) <content_in_use>: New field.  Now
  63         bool.
  64         (struct tui_source_window) <showing_source_p>: New method.
  65         (TUI_SRC_WIN): Change cast.
  66         * tui/tui-data.c (tui_initialize_static_data): Update.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  71         location_matches_p.
  72         * tui/tui-source.c (tui_source_window::location_matches_p): New
  73         method.
  74         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  75         method.
  76         * tui/tui-data.h (struct tui_source_window_base)
  77         <location_matches_p>: New method.
  78         (struct tui_source_window, struct tui_disasm_window)
  79         <location_matches_p>: Likewise.
  80
  81 2019-07-17  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-win.c (tui_set_win_height_command): Rename from
  84         tui_set_win_height.
  85         (tui_set_win_height_command): Remove.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-source.c (tui_source_window): New constructor.  Add
  90         observer.
  91         (~tui_source_window): New destructor.
  92         (tui_source_window::style_changed): New method.
  93         * tui/tui-hooks.c (tui_redisplay_source): Remove.
  94         (tui_attach_detach_observers): Update.
  95         * tui/tui-data.h (struct tui_source_window): Make constructor not
  96         inline.  Add destructor.
  97         (struct tui_source_window) <style_changed>: New method.
  98         <m_observable>: New member.
  99
 100 2019-07-17  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 103         * tui/tui-win.c (tui_resize_all): Fix typo.
 104
 105 2019-07-17  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 108         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 109         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 110         * tui/tui-win.c (window_name_completer): Use foreach.
 111         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 112         (update_tab_width): Likewise.
 113         * tui/tui-layout.c (show_layout): Update.
 114         * tui/tui-data.h (class tui_window_iterator): New.
 115         (struct all_tui_windows): New.
 116         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 121         parameter.  Don't reference globals.
 122         (tui_reg_command): Update.
 123
 124 2019-07-17  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-regs.c (tui_show_registers): Simplify.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-regs.c (tui_show_registers): Update.
 131         (tui_show_register_group): Add win_info parameter.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 136         Rename from tui_display_reg_element_at_line.
 137         (tui_data_window::display_registers_from_line): Update.
 138         * tui/tui-data.h (struct tui_data_window)
 139         <display_reg_element_at_line>: New method.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-regs.h (tui_display_registers_from)
 144         (tui_display_registers_from_line): Don't declare.
 145         * tui/tui-windata.c (tui_data_window::display_all_data)
 146         (tui_data_window::refresh_all)
 147         (tui_data_window::do_scroll_vertical): Update.
 148         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 149         from tui_display_registers_from.
 150         (tui_display_reg_element_at_line): Update.
 151         (tui_data_window::display_registers_from_line): Rename from
 152         tui_display_registers_from_line.
 153         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 154         display_registers_from_line>: New methods.
 155
 156 2019-07-17  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 159         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 160         from tui_erase_data_content.
 161         (tui_data_window::display_all_data)
 162         (tui_data_window::refresh_all)
 163         (tui_data_window::do_scroll_vertical): Update.
 164         * tui/tui-regs.c (tui_show_registers): Update.
 165         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 166         New method.
 167
 168 2019-07-17  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 171         declare.
 172         * tui/tui-windata.c
 173         (tui_data_window::delete_data_content_windows): Rename from
 174         tui_delete_data_content_windows.
 175         (tui_data_window::display_all_data)
 176         (tui_data_window::do_scroll_vertical): Update.
 177         * tui/tui-data.h (struct tui_data_window)
 178         <delete_data_content_windows>: New method.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 183         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 184
 185 2019-07-17  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 188         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 189         from tui_display_all_data.
 190         * tui/tui-win.c
 191         (tui_data_window::do_make_visible_with_new_height): Update.
 192         * tui/tui-regs.c (tui_show_registers): Update.
 193         * tui/tui-layout.c (tui_set_layout): Update.
 194         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 195         method.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 200         * tui/tui-windata.c (tui_display_data_from): Remove.
 201         (tui_data_window::refresh_all): Update.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 206         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 207         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 208         tui_display_registers_from_line.
 209         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 210         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 211         "force_display" parameter.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 216         declare.
 217         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 218         Rename from tui_first_reg_element_no_inline.
 219         (tui_display_reg_element_at_line)
 220         (tui_display_registers_from_line): Update.
 221         * tui/tui-data.h (struct tui_data_window)
 222         <first_reg_element_no_inline>: New method.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-windata.c (tui_display_data_from)
 227         (tui_data_window::do_scroll_vertical): Update.
 228         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 229         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 230         Rename from tui_line_from_reg_element_no.
 231         (tui_display_registers_from_line): Update.
 232         * tui/tui-data.h (struct tui_data_window)
 233         <line_from_reg_element_no>: New method.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 238         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 239         tui_last_regs_line_no.
 240         (tui_display_reg_element_at_line)
 241         (tui_display_registers_from_line): Update.
 242         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 243         method.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         PR tui/24722:
 248         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 249         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 250         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 251         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 252         (tui_update_breakpoint_info): Likewise.
 253         * tui/tui-hooks.c (tui_event_create_breakpoint)
 254         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 255         Update.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 260
 261 2019-07-17  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-winsource.c (tui_update_source_window_as_is)
 264         (tui_update_source_windows_with_addr): Update.
 265         * tui/tui-source.h (tui_set_source_content)
 266         (tui_show_symtab_source): Add "win_info" parameter.
 267         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 268         parameter.
 269         (tui_show_symtab_source): Likewise.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-wingeneral.c
 274         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 279         (struct tui_cmd_window) <can_scroll>: New method.
 280         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 281         method.
 282
 283 2019-07-17  Tom Tromey  <tromey@adacore.com>
 284
 285         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 286         do_field_signed>: Rename.  Change type of "value".
 287         * ui-out.c (ui_out::field_signed): Rename from field_int.
 288         Change type of "value".
 289         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 290         type of "value".
 291         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 292         do_field_int.  Change type of "value".
 293         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 294         do_field_int.  Change type of "value".
 295         * tracepoint.c (trace_status_mi, tfind_1)
 296         (print_one_static_tracepoint_marker): Update.
 297         * thread.c (print_thread_info_1, print_selected_thread_frame):
 298         Update.
 299         * stack.c (print_frame, print_frame_info): Update.
 300         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 301         Update.
 302         * source.c (print_source_lines_base): Update.
 303         * skip.c (info_skip_command): Update.
 304         * record-btrace.c (btrace_ui_out_decode_error)
 305         (btrace_call_history_src_line): Update.
 306         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 307         Update.
 308         * progspace.c (print_program_space): Update.
 309         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 310         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 311         do_field_int.  Change type of "value".
 312         * mi/mi-out.c (mi_ui_out::do_table_begin)
 313         (mi_ui_out::do_table_header): Update.
 314         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 315         type of "value".
 316         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 317         (mi_cmd_data_list_changed_registers, output_register)
 318         (mi_cmd_data_read_memory, mi_load_progress)
 319         (mi_cmd_trace_frame_collected): Update.
 320         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 321         Update.
 322         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 323         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 324         (mi_cmd_var_list_children, varobj_update_one): Update.
 325         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 326         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 327         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 328         * inferior.c (print_inferior): Update.
 329         * gdb_bfd.c (print_one_bfd): Update.
 330         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 331         Update.
 332         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 333         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 334         do_field_int.  Change type of "value".
 335         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 336         do_field_int.  Change type of "value".
 337         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 338         (print_one_breakpoint_location, print_it_catch_fork)
 339         (print_one_catch_fork, print_it_catch_vfork)
 340         (print_one_catch_vfork, print_it_catch_solib)
 341         (print_it_catch_exec, print_it_ranged_breakpoint)
 342         (print_mention_watchpoint, print_mention_masked_watchpoint)
 343         (bkpt_print_it, update_static_tracepoint): Update.
 344         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 345         * break-catch-syscall.c (print_it_catch_syscall): Update.
 346         * ada-tasks.c (print_ada_task_info): Update.
 347         * ada-lang.c (print_it_exception, print_mention_exception):
 348         Update.
 349
 350 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 351
 352         PR breakpoints/24541
 353         * gdbarch.c: Regenerate.
 354         * gdbarch.h: Regenerate.
 355         * gdbarch.sh: Adjust return type and parameter types for
 356         'stap_adjust_register'.
 357         (i386_stap_adjust_register): Adjust signature and return new
 358         register name.
 359         * stap-probe.c (stap_parse_register_operand): Adjust use of
 360         'gdbarch_stap_adjust_register'.
 361
 362 2019-07-17  Tom Tromey  <tromey@adacore.com>
 363
 364         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 365         declare VEC.
 366         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 367         std::vector.
 368         (struct s390_process_info): Add initializers.
 369         (s390_add_process): Use new.
 370         (s390_linux_nat_target::low_forget_process): Use delete.
 371         (s390_linux_nat_target::low_new_fork)
 372         (s390_linux_nat_target::stopped_by_watchpoint)
 373         (s390_linux_nat_target::low_prepare_to_resume)
 374         (s390_linux_nat_target::insert_watchpoint)
 375         (s390_linux_nat_target::insert_hw_breakpoint)
 376         (s390_linux_nat_target::remove_watchpoint)
 377         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 378
 379 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 380
 381         * aarch64-fbsd-nat.c: Include regcache.h.
 382         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 383         argument.
 384         (aarch64_fbsd_nat_target::fetch_registers)
 385         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 386         variable.
 387         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 388
 389 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 390
 391         * fbsd-nat.c: Include gdbarch.h.
 392
 393 2019-07-15  Tom Tromey  <tromey@adacore.com>
 394
 395         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 396
 397 2019-07-15  Tom Tromey  <tromey@adacore.com>
 398
 399         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 400         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 401         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 402         * cli-out.c (cli_ui_out::do_field_int): New method.
 403         * ui-out.c (ui_out::field_unsigned): New method.
 404         * symfile.c (generic_load): Use field_unsigned.
 405         (print_transfer_performance): Likewise.
 406         * record-btrace.c (ui_out_field_uint): Remove.
 407         (btrace_call_history_insn_range, btrace_call_history): Use
 408         field_unsigned.
 409         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 410         field_unsigned.
 411         * ui-out.h (class ui_out) <field_unsigned>: New method.
 412         <do_field_unsigned>: Likewise.
 413
 414 2019-07-15  Tom Tromey  <tromey@adacore.com>
 415
 416         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 417         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 418         * target.c (flash_erase_command): Use field_string.
 419         * infrun.c (print_signal_received_reason): Use field_string.
 420         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 421         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 422         field_string.
 423         * ada-tasks.c (print_ada_task_info): Use field_string.
 424
 425 2019-07-15  Tom Tromey  <tromey@adacore.com>
 426
 427         * target.c (flash_erase_command): Use field_core_addr.
 428         * symfile.c (generic_load): Use field_core_addr.
 429         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 430         Use field_core_addr.
 431         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 432         field_core_addr.
 433
 434 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 437         value if its desired type is smaller than a CORE_ADDR and signed.
 438
 439 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 442         of changes to field names, and use new is_reference field to
 443         decide if a property is a reference or not.
 444         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 445         field.
 446         (struct dwarf2_property_baton): Update header comment, rename
 447         'referenced_type' to 'property_type' and update comments.
 448         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 449         default property type, store in property baton, update to take
 450         accound of renamed field.
 451         (read_func_scope): Update call to attr_to_dynamic_prop.
 452         (read_array_type): Likewise.
 453         (dwarf2_per_cu_addr_sized_int_type): New function.
 454         (read_subrange_index_type): Move type finding code to
 455         dwarf2_per_cu_addr_sized_int_type.
 456         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 457         (dwarf2_per_cu_addr_type): New function.
 458         (set_die_type): Update calls to attr_to_dynamic_prop.
 459
 460 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * dwarf2read.c (read_subrange_index_type): New function.
 463         (read_subrange_type): Move code into new function and call it.
 464         * gdbtypes.c (create_range_type): Add some asserts.
 465
 466 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 467
 468         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 469         update return statements.
 470         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 471         declaration, and update comment to match.
 472         * gdbtypes.c (resolve_dynamic_array): Update call to
 473         dwarf2_evaluate_property to match new return type.
 474
 475 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 476
 477         * valarith.c (value_subscripted_rvalue): Change lowerbound
 478         parameter type from int to LONGEST.
 479         * value.h (value_subscripted_rvalue): Likewise in declaration.
 480
 481 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * cli/cli-utils.c (info_print_command_completer): New function.
 484         * cli/cli-utils.h: Add 'completer.h' include, and forward
 485         declaration for 'struct cmd_list_element'.
 486         (info_print_command_completer): Declare.
 487         * stack.c (_initialize_stack): Add completer for 'info locals' and
 488         'info args'.
 489         * symtab.c (_initialize_symtab): Add completer for 'info
 490         variables' and 'info functions'.
 491         * NEWS: Mention completion for additional info commands.
 492
 493 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * cli/cli-utils.c (extract_info_print_args): Delete.
 496         (extract_arg_maybe_quoted): Delete.
 497         (info_print_options_defs): New variable.
 498         (make_info_print_options_def_group): New function.
 499         (extract_info_print_options): Define new function.
 500         * cli/cli-utils.h (extract_info_print_args): Delete.
 501         (struct info_print_options): New structure.
 502         (extract_info_print_options): Declare new function.
 503         * stack.c (info_locals_command): Update to use new
 504         extract_info_print_options, also add a header comment.
 505         (info_args_command): Likewise.
 506         * symtab.c (info_variables_command): Likewise.
 507         (info_functions_command): Likewise.
 508
 509 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 512         to extract string arguments.
 513         * common/common-utils.c (extract_string_maybe_quoted): New function.
 514         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 515
 516 2019-07-11  Tom Tromey  <tromey@adacore.com>
 517
 518         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 519         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 520         * top.h (gdbinit): Don't declare.
 521         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 522         into...
 523         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 524         * top.c (gdb_init): Don't call init_cli_cmds.
 525         (gdbinit): Remove.
 526         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 527
 528 2019-07-11  Tom Tromey  <tromey@adacore.com>
 529
 530         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 531         after it has been moved.
 532
 533 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 534
 535         * valops.c (value_must_coerce_to_target): Change return type to
 536         bool.
 537         * value.h (value_must_coerce_to_target): Likewise.
 538
 539 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 540
 541         * breakpoint.c (is_hardware_watchpoint): Remove
 542         forward-declaration.
 543         (is_masked_watchpoint): Change return type to bool.
 544         (is_tracepoint): Likewise.
 545         (is_breakpoint): Likewise.
 546         (is_hardware_watchpoint): Likewise.
 547         (is_watchpoint): Likewise.
 548         (is_no_memory_software_watchpoint): Likewise.
 549         (is_catchpoint): Likewise.
 550         (breakpoint_1): Make FILTER parameter's return type bool.
 551         is_masked_watchpoint): Change return type to bool.
 552         (save_breakpoints): Make FILTER parameter's return type bool.
 553         * breakpoint.h (is_breakpoint): Change return type to bool.
 554         (is_watchpoint): Likewise.
 555         (is_catchpoint): Likewise.
 556         (is_tracepoint): Likewise.
 557
 558 2019-07-10  Tom Tromey  <tom@tromey.com>
 559
 560         * defs.h: Don't include gdbarch.h.
 561         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 562         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 563         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 564         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 565         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 566         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 567         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 568         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 569         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 570         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 571         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 572         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 573         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 574         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 575         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 576         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 577         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 578         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 579         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 580         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 581         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 582         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 583         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 584         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 585         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 586         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 587         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 588
 589 2019-07-10  Tom Tromey  <tromey@adacore.com>
 590
 591         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 592         * breakpoint.c (init_ada_exception_breakpoint): Register as
 593         bp_catchpoint.
 594         (print_one_breakpoint_location, print_one_breakpoint): Use
 595         is_ada_exception_catchpoint.
 596         * ada-lang.c (class ada_catchpoint_location): Pass
 597         bp_loc_software_breakpoint to bp_location constructor.
 598         (is_ada_exception_catchpoint): New function.
 599
 600 2019-07-10  Tom Tromey  <tromey@adacore.com>
 601
 602         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 603         VEC.
 604         (struct arm_exidx_entry): New method operator<.
 605         (struct arm_exidx_data) <section_maps>: Change type.
 606         (arm_exidx_data_free): Remove.
 607         (arm_exidx_data_key): Change type.  Move lower.
 608         (arm_exidx_new_objfile): Update.
 609         (arm_compare_exidx_entries): Remove.
 610         (arm_find_exidx_entry, _initialize_arm_tdep)
 611
 612 2019-07-10  Tom Tromey  <tromey@adacore.com>
 613
 614         * solib-spu.c (ocl_program_data_key): Change type.
 615         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 616         Update.
 617
 618 2019-07-10  Tom Tromey  <tromey@adacore.com>
 619
 620         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 621         (struct solib_aix_inferior_data) <library_list>: Change type.
 622         (solib_aix_inferior_data_handle): Change type.
 623         (get_solib_aix_inferior_data): Update.
 624         (solib_aix_free_library_list): Remove.
 625         (library_list_start_library): Update.
 626         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 627         return type.
 628         (solib_aix_get_library_list)
 629         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 630         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 631
 632 2019-07-10  Tom Tromey  <tromey@adacore.com>
 633
 634         * solib-dsbt.c (struct dsbt_info): Add initializers.
 635         (solib_dsbt_pspace_data): Change type.
 636         (dsbt_pspace_data_cleanup): Remove.
 637         (get_dsbt_info, _initialize_dsbt_solib): Update.
 638
 639 2019-07-10  Tom Tromey  <tromey@adacore.com>
 640
 641         * spu-tdep.c (spu_overlay_data): Change type.
 642         (spu_get_overlay_table, spu_overlay_new_objfile)
 643         (_initialize_spu_tdep): Update.
 644
 645 2019-07-10  Tom Tromey  <tromey@adacore.com>
 646
 647         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 648         destructor.
 649         (dbx_objfile_data_key): Change type and declare later.
 650         (DBX_SYMFILE_INFO): Rewrite.
 651         * dbxread.c (dbx_objfile_data_key): Change type.
 652         (dbx_symfile_init): Update.
 653         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 654         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 655         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 656
 657 2019-07-10  Tom Tromey  <tromey@adacore.com>
 658
 659         * jit.c (jit_program_space_key): Change type.  Move lower.
 660         (get_jit_program_space_data): Update.
 661         (jit_program_space_data_cleanup): Remove.
 662         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 663         Update.
 664         (struct jit_program_space_data): Add initializers.
 665
 666 2019-07-10  Tom Tromey  <tromey@adacore.com>
 667
 668         * solib-darwin.c (struct darwin_info): Add initializers.
 669         (solib_darwin_pspace_data): Change type.
 670         (darwin_pspace_data_cleanup): Remove.
 671         (get_darwin_info, _initialize_darwin_solib): Update.
 672
 673 2019-07-10  Tom Tromey  <tromey@adacore.com>
 674
 675         * remote-sim.c (struct sim_inferior_data): Add initializers,
 676         constructor, and destructor.
 677         (sim_inferior_data_key): Change type.  Move lower.
 678         (check_for_duplicate_sim_descriptor): Update.
 679         (get_sim_inferior_data): Use new.  Update.
 680         (~sim_inferior_data_cleanup): Rename from
 681         sim_inferior_data_cleanup.  Simplify.
 682         (gdbsim_close_inferior, simulator_command)
 683         (sim_command_completer, _initialize_remote_sim): Update.
 684         (next_pid, INITIAL_PID): Move earlier.
 685
 686 2019-07-10  Tom Tromey  <tromey@adacore.com>
 687
 688         * python/python-internal.h (create_thread_object): Return
 689         gdbpy_ref.
 690         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 691         * python/py-inferior.c (struct threadlist_entry): Add
 692         constructor.
 693         <thread_obj>: Now a gdbpy_ref.
 694         (thread_to_thread_object): Update.
 695         (add_thread_object): Use new.
 696         (delete_thread_object): Use delete.
 697         (infpy_threads): Update.
 698         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 699         GIL.
 700
 701 2019-07-10  Tom Tromey  <tromey@adacore.com>
 702
 703         * valops.c (value_cast): Specialize error message for Ada.
 704
 705 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 706
 707         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 708
 709 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 710
 711         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 712         bpstat_should_step): Return bool, adjust comments.
 713         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 714         bpstat_should_step): Likewise.
 715
 716 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 717
 718         * features/Makefile: Use feature target descriptions for Arm.
 719         * features/arm/arm-core.c: Generate new file.
 720         * features/arm/arm-fpa.c: Likewise.
 721         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 722         * features/arm/arm-m-profile.c: Likewise.
 723         * features/arm/arm-vfpv2.c: Likewise.
 724         * features/arm/arm-vfpv3.c: Likewise.
 725         * features/arm/xscale-iwmmxt.c: Likewise.
 726         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 727
 728 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 729
 730         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 731         ptrace earlier.
 732
 733 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 734
 735         * features/aarch64-pauth.c: Regenerate.
 736
 737 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 738
 739         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 740         bool.
 741         (bpstat_what): Use false instead of 0.
 742
 743 2019-07-09  Pedro Alves  <palves@redhat.com>
 744
 745         * break-catch-throw.c (is_exception_catchpoint): New.
 746         * breakpoint.c (print_one_breakpoint_location): New parameter
 747         'raw_loc'.  Handle it.  Use
 748         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 749         looking at the breakpoint's type.
 750         (print_one_breakpoint): If handling "maint info breakpoints", also
 751         print locations of exception catchpoints.
 752         * breakpoint.h (is_exception_catchpoint): Declare.
 753
 754 2019-07-09  Pedro Alves  <palves@redhat.com>
 755
 756         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 757         "addr" field.
 758         (allocate_location_exception_catchpoint): New.
 759         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 760         (initialize_throw_catchpoint_ops): Install
 761         allocate_location_exception_catchpoint as allocate_location
 762         method.
 763         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 764         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 765         bp_loc_other.
 766         (breakpoint_address_is_meaningful): Delete.
 767         (bl_address_is_meaningful): New.
 768         (breakpoint_locations_match): Adjust comment.
 769         (bp_location_from_bp_type): New, factored out of...
 770         (bp_location::bp_location(breakpoint *)): ... this.
 771         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 772         factored out of...
 773         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 774         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 775         breakpoint_address_is_meaningful.
 776         (bp_locations_compare): Adjust comment.
 777         (update_global_location_list): Use bl_address_is_meaningful
 778         instead of breakpoint_address_is_meaningful.
 779         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 780         explicit.
 781         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 782         * python/py-breakpoint.c (bppy_get_location): No longer check
 783         whether location is null.
 784
 785 2019-07-09  Pedro Alves  <palves@redhat.com>
 786
 787         PR c++/15468
 788         * breakpoint.c (print_one_breakpoint_location): Remove
 789         single-location assert.
 790
 791 2019-07-09  Tom Tromey  <tom@tromey.com>
 792
 793         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 794         * configure: Rebuild.
 795         * configure.ac: Change common to gdbsupport.
 796         * gdbsupport: Rename from common.
 797         * acinclude.m4: Change common to gdbsupport.
 798         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 799         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 800         gdbsupport.
 801         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 802         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 803         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 804         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 805         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 806         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 807         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 808         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 809         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 810         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 811         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 812         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 813         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 814         coff-pe-read.c, command.h, compile/compile-c-support.c,
 815         compile/compile-c.h, compile/compile-cplus-symbols.c,
 816         compile/compile-cplus-types.c, compile/compile-cplus.h,
 817         compile/compile-loc2c.c, compile/compile.c, completer.c,
 818         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 819         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 820         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 821         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 822         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 823         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 824         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 825         features/aarch64-core.c, features/aarch64-fpu.c,
 826         features/aarch64-pauth.c, features/aarch64-sve.c,
 827         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 828         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 829         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 830         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 831         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 832         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 833         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 834         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 835         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 836         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 837         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 838         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 839         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 840         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 841         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 842         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 843         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 844         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 845         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 846         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 847         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 848         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 849         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 850         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 851         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 852         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 853         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 854         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 855         minsyms.c, mips-linux-tdep.c, namespace.h,
 856         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 857         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 858         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 859         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 860         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 861         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 862         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 863         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 864         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 865         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 866         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 867         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 868         procfs.c, producer.c, progspace.h, psymtab.h,
 869         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 870         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 871         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 872         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 873         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 874         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 875         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 876         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 877         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 878         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 879         target-memory.c, target.c, target.h, target/waitstatus.c,
 880         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 881         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 882         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 883         unittests/array-view-selftests.c,
 884         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 885         unittests/common-utils-selftests.c,
 886         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 887         unittests/format_pieces-selftests.c,
 888         unittests/function-view-selftests.c,
 889         unittests/lookup_name_info-selftests.c,
 890         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 891         unittests/mkdir-recursive-selftests.c,
 892         unittests/observable-selftests.c,
 893         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 894         unittests/parse-connection-spec-selftests.c,
 895         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 896         unittests/scoped_fd-selftests.c,
 897         unittests/scoped_mmap-selftests.c,
 898         unittests/scoped_restore-selftests.c,
 899         unittests/string_view-selftests.c, unittests/style-selftests.c,
 900         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 901         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 902         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 903         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 904         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 905         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 906
 907 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 910         bool value.
 911         (decode_digits_ordinary): Set explicit_line field in sal.
 912         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 913         symtab_and_line that was set on an explicit line number in
 914         assembler code.  Do always update the recorded symtab and line if
 915         we do skip the prologue.
 916
 917 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * breakpoint.c (set_breakpoint_location_function): Remove
 920         explicit_loc parameter.
 921         (momentary_breakpoint_from_master): Update call to
 922         set_breakpoint_location_function.
 923         (add_location_to_breakpoint): Likewise.
 924
 925 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 928         required features based on default bfd type when no specific bfd
 929         is present.
 930
 931 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 932
 933         * NEWS: Mention that GDB printf and eval commands can now print
 934         C-style and Ada-style convenience var strings without
 935         calling the inferior.
 936         * printcmd.c (printf_c_string): Locally print GDB internal var
 937         instead of transiting via the inferior.
 938         (printf_wide_c_string): Likewise.
 939
 940 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 941
 942         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 943
 944 2019-07-04  Tom Tromey  <tom@tromey.com>
 945
 946         PR tui/24724:
 947         * tui/tui-winsource.c (tui_clear_source_content): Update.
 948         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 949         (tui_update_breakpoint_info): Update.
 950         (tui_set_exec_info_content): Update.
 951         * tui/tui-source.c (tui_set_source_content_nil): Update.
 952         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 953         has_break.
 954         * tui/tui-data.h (enum tui_bp_flag): New.
 955         (tui_bp_flags): New enum flags type.
 956         (struct tui_source_element) <break_mode>: Change type.  Rename
 957         from has_break.
 958         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 959         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 960         constants.
 961         * tui/tui-winsource.h: Fix comment.
 962
 963 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 966         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 967         (store_fpregs_to_thread)
 968         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 969         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 970         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 971         (IWMMXT_REGS_SIZE): Add define.
 972         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 973         (fetch_vfp_regs, store_vfp_regs)
 974         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 975         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 976
 977 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 978
 979         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 980         defines.
 981         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 982         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 983         (ARM_INT_REGISTER_SIZE): ...to this.
 984         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 985         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 986         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 987         (arm_linux_collect_gregset, supply_nwfpe_register)
 988         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 989         defines.
 990         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 991         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 992         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 993         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 994         (arm_return_in_memory, arm_store_return_value)
 995         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 996         (arm_record_ld_st_multiple): Likewise.
 997         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 998         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 999
1000 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1003         AARCH64_DISPLACED_MODIFIED_INSNS.
1004         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1005         (aarch64_displaced_step_copy_insn): Likewise.
1006         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1007         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1008         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1009         ARM_DISPLACED_MODIFIED_INSNS.
1010         * arm-tdep.c (arm_gdbarch_init): Likewise.
1011         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1012         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1013         (struct arm_displaced_step_closure): Use
1014         ARM_DISPLACED_MODIFIED_INSNS.
1015
1016 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1017
1018         * features/Makefile: Remove unused xml files.
1019         * features/aarch64.xml: Remove.
1020         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1021         * features/i386/amd64-avx-avx512.xml: Remove.
1022         * features/i386/amd64-avx-linux.xml: Remove.
1023         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1024         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1025         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1026         * features/i386/amd64-avx-mpx.xml: Remove.
1027         * features/i386/amd64-avx.xml: Remove.
1028         * features/i386/amd64-linux.xml: Remove.
1029         * features/i386/amd64-mpx-linux.xml: Remove.
1030         * features/i386/amd64-mpx.xml: Remove.
1031         * features/i386/amd64.xml: Remove.
1032         * features/i386/i386-avx-avx512-linux.xml: Remove.
1033         * features/i386/i386-avx-avx512.xml: Remove.
1034         * features/i386/i386-avx-linux.xml: Remove.
1035         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1036         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1037         * features/i386/i386-avx-mpx-linux.xml: Remove.
1038         * features/i386/i386-avx-mpx.xml: Remove.
1039         * features/i386/i386-avx.xml: Remove.
1040         * features/i386/i386-linux.xml: Remove.
1041         * features/i386/i386-mmx-linux.xml: Remove.
1042         * features/i386/i386-mmx.xml: Remove.
1043         * features/i386/i386-mpx-linux.xml: Remove.
1044         * features/i386/i386-mpx.xml: Remove.
1045         * features/i386/i386.xml: Remove.
1046         * features/i386/x32-avx-avx512-linux.xml: Remove.
1047         * features/i386/x32-avx-linux.xml: Remove.
1048         * features/i386/x32-linux.xml: Remove.
1049
1050 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1051
1052         * regformats/aarch64.dat: Remove.
1053         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1054         * regformats/i386/amd64-avx-linux.dat: Remove.
1055         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1056         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1057         * regformats/i386/amd64-linux.dat: Remove.
1058         * regformats/i386/amd64-mpx-linux.dat: Remove.
1059         * regformats/i386/amd64.dat: Remove.
1060         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1061         * regformats/i386/i386-avx-linux.dat: Remove.
1062         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1063         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1064         * regformats/i386/i386-linux.dat: Remove.
1065         * regformats/i386/i386-mmx-linux.dat: Remove.
1066         * regformats/i386/i386-mpx-linux.dat: Remove.
1067         * regformats/i386/i386.dat: Remove.
1068         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1069         * regformats/i386/x32-avx-linux.dat: Remove.
1070         * regformats/i386/x32-linux.dat: Remove.
1071
1072 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1073
1074         * aarch64-tdep.c: Remove xml self tests.
1075         * amd64-linux-tdep.c: Likewise.
1076         * amd64-tdep.c: Likewise.
1077         * i386-linux-tdep.c: Likewise.
1078         * i386-tdep.c: Likewise.
1079
1080 2019-07-03  Pedro Alves  <palves@redhat.com>
1081
1082         PR cli/24732
1083         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1084         (pipe_cmd_option_defs): New.
1085         (make_pipe_cmd_options_def_group): New.
1086         (pipe_command): Use gdb::option::process_options.
1087         (pipe_command_completer): New function.
1088         (_initialize_cli_cmds): Install completer for "pipe" command.
1089
1090 2019-07-03  Pedro Alves  <palves@redhat.com>
1091
1092         * cli/cli-option.c (union option_value) <string>: New field.
1093         (struct option_def_and_value): Add ctor, move ctor, dtor and
1094         use DISABLE_COPY_AND_ASSIGN.
1095         (option_def_and_value::clear_value): New.
1096         (parse_option, save_option_value_in_ctx, get_val_type_str)
1097         (add_setshow_cmds_for_options): Handle var_string.
1098         * cli-option.h (union option_def::var_address) <string>: New
1099         field.
1100         (struct string_option_def): New.
1101         * maint-test-options.c (struct test_options_opts): Add default
1102         ctor and use DISABLE_COPY_AND_ASSIGN.
1103         <string_opt>: New field.
1104         (test_options_opts::~test_options_opts): New.
1105         (test_options_opts::dump): Also dump "-string".
1106         (test_options_option_defs): Install "string.
1107
1108 2019-07-03  Pedro Alves  <palves@redhat.com>
1109
1110         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1111         option_value with a null enumeration.
1112         (complete_options): Save the option values in the context.
1113         (save_option_value_in_ctx): New, factored out from ...
1114         (process_options): ... here.
1115         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1116         of the function.
1117         * maint-test-options.c (test_options_opts::dump): New, factored
1118         out from ...
1119         (maintenance_test_options_command_mode): ... here.
1120         (maintenance_test_options_command_completion_result): Delete.
1121         (maintenance_test_options_command_completion_text): Update
1122         comment.
1123         (maintenance_show_test_options_completion_result): Change
1124         prototype.  Just print
1125         maintenance_test_options_command_completion_text.
1126         (save_completion_result): New.
1127         (maintenance_test_options_completer_mode): Pass options context to
1128         complete_options, and then save a dump.
1129         (_initialize_maint_test_options): Use add_cmd to install "maint
1130         show test-options-completion-result".
1131
1132 2019-07-03  Pedro Alves  <palves@redhat.com>
1133
1134         * NEWS (New commands): Mention "with" and "maint with".
1135         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1136         (with_command, with_command_completer): New.
1137         (pipe_command): Adjust to new repeat_previous
1138         interface.
1139         (_initialize_cli_cmds): Install the "with" command and its "w"
1140         alias.
1141         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1142         declarations.
1143         * cli/cli-setshow.c (parse_cli_var_uinteger)
1144         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1145         argument strings for all var_types.
1146         (get_setshow_command_value_string): New, factored out from ...
1147         (do_show_command): ... this.
1148         * cli/cli-setshow.h: Include <string>.
1149         (get_setshow_command_value_string): Declare.
1150         * command.h (repeat_previous): Now returns const char *.  Adjust
1151         comment.
1152         * maint.c: Include "cli/cli-cmds.h".
1153         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1154         (_initialize_maint_cmds): Register the "maintenance with" command.
1155         * top.c (repeat_previous): Move bits from pipe_command here:
1156         Return the saved command line, if any; error out if there's no
1157         command to relaunch.
1158
1159 2019-07-03  Pedro Alves  <palves@redhat.com>
1160
1161         * NEWS (New commands): Mention "maint set/show test-settings"
1162         instead of "maint test-settings".
1163         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1164         (maintenance_test_settings_set_list): Rename to ...
1165         (maintenance_set_test_settings_list): ... this.
1166         (maintenance_test_settings_show_list): Rename to  ...
1167         (maintenance_show_test_settings_list): ... this.
1168         (maintenance_test_settings_cmd): Delete.
1169         (maintenance_test_settings_set_cmd): ...
1170         (maintenance_set_test_settings_cmd): ... this.
1171         (maintenance_test_settings_show_cmd): ...
1172         (maintenance_show_test_settings_cmd): ... this.
1173         (maintenance_test_settings_show_value_cmd):
1174         (maintenance_show_test_settings_value_cmd): ... this.
1175         (_initialize_maint_test_settings): No longer install the "maint
1176         test-settings" prefix command.  Rename "maint test-settings set"
1177         to "maint set test-settings", and "maint test-settings show" to
1178         "maint show test-settings".  Adjust all subcommands.
1179
1180 2019-07-03  Pedro Alves  <palves@redhat.com>
1181
1182         * maint-test-settings.c: Fix file's intro comment.  Replace all
1183         references to "test-options" with references to "test-settings",
1184         in comments.
1185
1186 2019-07-03  Pedro Alves  <palves@redhat.com>
1187
1188         * maint-test-settings.c (maintenance_test_settings_xxx)
1189         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1190         New.
1191         (maintenance_test_settings_enums): Use them.
1192         (maintenance_test_settings_enum): Default to
1193         maintenance_test_settings_xxx.
1194         (_initialize_maint_test_settings): Initialize
1195         MAINTENANCE_TEST_SETTINGS_FILENAME.
1196
1197 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1198
1199         * breakpoint.h (remove_breakpoints_inf): Change return type to
1200         void, move function documentation here.
1201         * breakpoint.c (remove_breakpoints_inf): Change return type to
1202         void, move function documentation to header.
1203
1204 2019-07-02  Pedro Alves  <palves@redhat.com>
1205
1206         * NEWS (Completion improvements): Mention "info threads".
1207         * thread.c (struct info_threads_opts, info_threads_option_defs)
1208         (make_info_threads_options_def_group): New.
1209         (info_threads_command): Use gdb::option::process_options.
1210         (info_threads_command_completer): New.
1211         (_initialize_thread): Use gdb::option::build_help to build the
1212         help text for "info threads".
1213
1214 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1215
1216         * defs.h (generic_load): Move from here...
1217         * symfile.h (generic_load): ... to here.  Rename name parameter
1218         to args.
1219         * symfile.c (generic_load): Add comment.
1220
1221 2019-07-01  Tom Tromey  <tromey@adacore.com>
1222
1223         * dwarf2read.c
1224         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1225         declaration of without_params.  Fix formatting.
1226
1227 2019-07-01  Tom Tromey  <tromey@adacore.com>
1228
1229         * ada-exp.y (find_primitive_type): Update.
1230         * ada-lang.h (ada_lookup_symbol): Update.
1231         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1232         parameter.
1233         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1234
1235 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1236
1237         PR breakpoints/24541
1238         * gdbarch.c: Regenerate.
1239         * gdbarch.h: Regenerate.
1240         * gdbarch.sh: Add 'stap_adjust_register'.
1241         * i386-tdep.c: Include '<unordered_set>'.
1242         (i386_stap_adjust_register): New function.
1243         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1244         * stap-probe.c (stap_parse_register_operand): Call
1245         'gdbarch_stap_adjust_register'.
1246
1247 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1248
1249         PR python/24742
1250         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1251         * python/python.c (do_start_initialization): Use 'xmalloc'
1252         instead of 'PyMem_Malloc'.
1253
1254 2019-06-28  Tom Tromey  <tromey@adacore.com>
1255
1256         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1257         for Ada.
1258
1259 2019-06-27  Tom Tromey  <tromey@adacore.com>
1260
1261         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1262         objfile_key.
1263         (arm_find_mapping_symbol, arm_record_special_symbol)
1264         (_initialize_arm_tdep): Update.
1265         (arm_objfile_data_free): Remove.
1266
1267 2019-06-27  Tom Tromey  <tromey@adacore.com>
1268
1269         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1270         to cp_print_static_field.
1271
1272 2019-06-26  Tom Tromey  <tromey@adacore.com>
1273
1274         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1275         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1276         declare.
1277
1278 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * features/aarch64-core.c (create_feature_aarch64_core):
1281         Regenerate.
1282         * features/aarch64-core.xml: Add cpsr flags.
1283
1284 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1287         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1288
1289 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1290
1291         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1292         field.
1293         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1294         use.
1295         (arm_record_special_symbol): Don't insert new symbol in sorted
1296         position, push it at the end.
1297
1298 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1301         (arm_mapping_symbol_s): Remove.
1302         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1303         (arm_mapping_symbol_vec): New typedef.
1304         (struct arm_per_objfile): Add constructor.
1305         <section_maps>: Change type to
1306         std::unique_ptr<arm_mapping_symbol_vec[]>.
1307         (arm_compare_mapping_symbols): Remove.
1308         (arm_find_mapping_symbol): Adjust to section_maps type change.
1309         (arm_objfile_data_free): Call delete on arm_per_objfile.
1310         (arm_record_special_symbol): Adjust to section_maps type change.
1311         Allocate arm_per_objfile with new.
1312
1313 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1314
1315         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1316         with the command prefix.
1317
1318 2019-06-25  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1321         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1322
1323 2019-06-25  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1326         type.
1327         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1328         protected.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-winsource.c
1333         (tui_source_window_base::set_is_exec_point_at): Add check against
1334         LOA_ADDRESS.
1335
1336 2019-06-25  Tom Tromey  <tom@tromey.com>
1337
1338         * tui/tui-source.c (tui_set_source_content): Don't check before
1339         xfree.
1340         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-winsource.h (tui_update_source_window_as_is)
1345         (tui_alloc_source_buffer, tui_line_is_displayed)
1346         (tui_addr_is_displayed): Change type of win_info.
1347         * tui/tui-winsource.c (tui_update_source_window_as_is)
1348         (tui_clear_source_content, tui_show_source_line)
1349         (tui_show_source_content, tui_source_window_base::refill)
1350         (tui_source_window_base::set_is_exec_point_at)
1351         (tui_source_window_base::set_is_exec_point_at)
1352         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1353         (tui_alloc_source_buffer, tui_line_is_displayed)
1354         (tui_addr_is_displayed): Change type of win_info.  Update.
1355         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1356         (tui_source_window_base::do_make_visible_with_new_height):
1357         Update.
1358         * tui/tui-source.c (tui_set_source_content)
1359         (tui_set_source_content_nil)
1360         (tui_source_window::do_scroll_vertical): Update.
1361         * tui/tui-layout.c (show_layout): Update.
1362         * tui/tui-disasm.c (tui_set_disassem_content)
1363         (tui_disasm_window::do_scroll_vertical): Update.
1364         * tui/tui-data.h (tui_win_content): Remove.
1365         (struct tui_gen_win_info) <content, content_size>: Remove.
1366         (struct tui_source_element): Add initializers and destructor.
1367         (union tui_which_element, struct tui_win_element): Remove.
1368         (struct tui_source_window_base) <content>: New field.
1369         (struct tui_data_window): Remove destructor.
1370         (tui_alloc_content, tui_free_win_content)
1371         (tui_free_all_source_wins_content): Don't declare.
1372         * tui/tui-data.c (tui_initialize_static_data): Update.
1373         (init_content_element, tui_alloc_content): Remove.
1374         (~tui_gen_win_info): Update.
1375         (~tui_data_window, tui_free_all_source_wins_content)
1376         (tui_free_win_content, free_content, free_content_elements):
1377         Remove.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-winsource.h (tui_clear_source_content)
1382         (tui_erase_source_content, tui_show_source_content): Change type
1383         of win_info.
1384         * tui/tui-winsource.c (tui_clear_source_content)
1385         (tui_erase_source_content, tui_show_source_content): Change type
1386         of win_info.
1387         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1388         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1389         win_info.
1390         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1391         win_info.
1392         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-winsource.c (tui_clear_source_content)
1397         (tui_source_window_base::set_is_exec_point_at): Update.
1398         * tui/tui-source.c (tui_set_source_content_nil): Update.
1399         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1400         a bool.
1401         * tui/tui-data.c (init_content_element): Update.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1406         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1407         * tui/tui-layout.c (init_and_make_win): Update.
1408         * tui/tui.h (enum tui_win_type): Update.
1409         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1410         tui_win_is_auxillary.
1411         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1412         tui_win_is_auxillary.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1417         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1418         (tui_delete_data_content_windows, tui_display_all_data)
1419         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1420         Update.
1421         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1422         * tui/tui-regs.c (tui_last_regs_line_no)
1423         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1424         (tui_show_registers): Update.
1425         (tui_show_register_group): Return void.  Update.
1426         (tui_display_registers_from, tui_display_reg_element_at_line)
1427         (tui_display_registers_from_line, tui_check_register_values):
1428         Update.
1429         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1430         member.
1431         (struct tui_data_window) <regs_content>: Now a std::vector.
1432         <regs_content_count>: Remove.
1433         (tui_add_content_elements, tui_free_data_content): Don't declare.
1434         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1435         (init_content_element): Remove DATA_WIN case.  Add assert.
1436         (tui_add_content_elements): Remove.
1437         (tui_data_window): Update.
1438         (tui_free_data_content): Remove.
1439         (free_content_elements): Remove DATA_WIN case.
1440
1441 2019-06-25  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-data.c (tui_data_item_window): Update.
1444         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1445         * tui/tui-windata.c (tui_display_all_data)
1446         (tui_display_data_from_line): Update.
1447         (tui_check_data_values): Remove.
1448         * tui/tui-regs.c (tui_show_register_group)
1449         (tui_display_reg_element_at_line): Update.
1450         * tui/tui-hooks.c (tui_register_changed)
1451         (tui_refresh_frame_and_register_information): Call
1452         tui_check_register_values.
1453         * tui/tui-data.h (struct tui_data_window) <data_content,
1454         data_content_count, data_type>: Remove.
1455         (enum tui_data_type): Remove.
1456
1457         * tui/tui-data.c (tui_data_window::clear_detail)
1458         (~tui_data_window): Update.
1459
1460 2019-06-25  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1463         declare.
1464         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1465         Rename from tui_first_data_item_displayed.  Update.
1466         (tui_data_window::refresh_all)
1467         (tui_data_window::do_scroll_vertical): Update.
1468         * tui/tui-data.h (struct tui_data_window)
1469         <first_data_item_displayed>: Declare new method.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1474         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1475         contents...
1476         (tui_initialize_static_data): ...here.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1481         (tui_display_registers_from, tui_check_register_values): Update.
1482         (tui_display_register): Remove win_info parameter; update.
1483         (tui_get_register): Change type of parameters.
1484         * tui/tui-data.h (struct tui_data_element): Remove.
1485         (union tui_which_element) <data>: Remove.
1486         <data_window>: Change type.
1487         (struct tui_data_item_window): New.
1488         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1489         case.  Add assert.
1490         (~tui_data_item_window): New destructor.
1491         (free_content_elements): Remove DATA_ITEM_WIN case.
1492
1493 2019-06-25  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1496         Remove.
1497
1498 2019-06-25  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-data.h (struct tui_command_element): Remove.
1501         (union tui_which_element) <command>: Remove.
1502         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1503         assert.
1504         (free_content_elements): Remove CMD_WIN case.
1505
1506 2019-06-25  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-layout.c (tui_set_layout): Update.
1509         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1510         * tui/tui-data.c (layout_def): Update.
1511
1512 2019-06-25  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1515         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1516         (tui_source_window_base::set_new_height): Update.
1517         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1518         Update.
1519         (tui_set_locator_fullname, tui_set_locator_info)
1520         (tui_show_frame_info): Update.
1521         * tui/tui-source.c (tui_set_source_content)
1522         (tui_source_is_displayed): Update.
1523         * tui/tui-layout.c (show_source_disasm_command, show_data)
1524         (show_source_or_disasm_and_command): Update.
1525         * tui/tui-disasm.c (tui_set_disassem_content)
1526         (tui_get_begin_asm_address): Update.
1527         * tui/tui-data.h (struct tui_locator_element): Remove.
1528         (union tui_which_element) <locator>: Remove.
1529         (struct tui_locator_window): New.
1530         (tui_locator_win_info_ptr): Change return type.
1531         * tui/tui-data.c (_locator): Change type.
1532         (tui_locator_win_info_ptr): Change return type.
1533         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1534         (tui_alloc_content): Add assert.
1535
1536 2019-06-25  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-winsource.c
1539         (tui_exec_info_window::maybe_allocate_content): New method.
1540         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1541         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1542         (make_source_or_disasm_window): Add cast.
1543         * tui/tui-data.h (union tui_which_element) <simple_string>:
1544         Remove.
1545         (struct tui_source_info): New.
1546         (struct tui_source_window_base) <execution_info>: Change type.
1547         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1548         case, and add assert.
1549         (tui_alloc_content): Add assert.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1554         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1555         * tui/tui-data.c (tui_alloc_win_info): Remove.
1556
1557 2019-06-25  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1560         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1561         can_highlight.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1566         make_visible_with_new_height method.
1567         (tui_win_info::make_visible_with_new_height): New method.
1568         (tui_source_window_base::do_make_visible_with_new_height)
1569         (tui_data_window::do_make_visible_with_new_height)
1570         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1571         (make_visible_with_new_height): Remove.
1572         (tui_resize_all, tui_adjust_win_heights): Use
1573         make_visible_with_new_height method.
1574         * tui/tui-data.h (struct tui_win_info)
1575         <do_make_visible_with_new_height, make_visible_with_new_height>:
1576         New methods.
1577         (struct tui_source_window_base, struct tui_data_window)
1578         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1579         methods.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1584         method.
1585         (update_tab_width): Call update_tab_width method.
1586         * tui/tui-data.h (struct tui_win_info)
1587         (struct tui_source_window_base) <update_tab_width>: New methods.
1588
1589 2019-06-25  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1592         parameter.
1593         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1594         parameter.
1595         (tui_gen_win_info::make_visible): Update.
1596         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1597         parameter.
1598         * tui/tui-data.h (enum tui_box): New enum.
1599         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1600
1601 2019-06-25  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1604         init_and_make_win for EXEC_INFO_WIN.
1605         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1606         longer inline.
1607         (struct tui_win_info) <~tui_win_info>: Inline.
1608         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1609         Don't declare.
1610         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1611         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1612         Remove.
1613         (tui_initialize_static_data): Update.
1614         (~tui_gen_win_info): Handle more cleanup here.
1615         (~tui_source_window_base): Delete "execution_info".
1616         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-layout.c (make_command_window): Don't set
1621         can_highlight.
1622         (show_source_disasm_command): Call the reset method.
1623         (show_data): Don't set can_highlight.  Call the reset method.
1624         (tui_gen_win_info::reset): Rename from init_gen_win_info
1625         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1626         (show_source_or_disasm_and_command): Call the reset method.
1627         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1628         (struct tui_cmd_window): Set can_highlight.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1633         from make_visible.
1634         (tui_make_visible, tui_make_invisible): Rewrite.
1635         (tui_win_info::make_visible): Remove.
1636         (tui_source_window_base::make_visible): Update.
1637         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1638         method.  Moved from...
1639         (struct tui_win_info) <make_visible>: ...here.
1640
1641 2019-06-25  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-winsource.c
1644         (tui_source_window_base::do_scroll_horizontal): Remove direction
1645         parameter.
1646         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1647         direction parameter.
1648         * tui/tui-win.c (tui_win_info::forward_scroll)
1649         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1650         (tui_win_info::right_scroll): Update.
1651         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1652         direction parameter.
1653         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1654         direction parameter.
1655         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1656         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1657         Remove direction parameter.
1658         (struct tui_source_window_base, struct tui_source_window)
1659         (struct tui_disasm_window, struct tui_data_window)
1660         (struct tui_cmd_window): Update.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.h (tui_set_exec_info_content)
1665         (tui_show_exec_info_content, tui_erase_exec_info_content)
1666         (tui_clear_exec_info_content, tui_update_exec_info): Change
1667         argument to tui_source_window_base.
1668         * tui/tui-winsource.c (tui_set_exec_info_content)
1669         (tui_show_exec_info_content, tui_erase_exec_info_content)
1670         (tui_clear_exec_info_content, tui_update_exec_info): Change
1671         argument to tui_source_window_base.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1676         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1677
1678 2019-06-25  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1681         check.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1686         type to void.
1687         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1688         type to void.
1689         * tui/tui-source.c (tui_set_source_content): Update.
1690         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-win.c (window_name_completer, tui_set_focus)
1695         (tui_all_windows_info): Use name method.
1696         * tui/tui-data.h (struct tui_gen_win_info)
1697         (struct tui_source_window, struct tui_disasm_window)
1698         (struct tui_data_window, struct tui_cmd_window) <name>: New
1699         method.
1700         (tui_win_name): Don't declare.
1701         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1702         (tui_win_name): Remove.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-winsource.h (tui_update_source_window)
1707         (tui_update_source_window_as_is): Change parameter type.
1708         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1709         to be a tui_source_window_base.
1710         (tui_update_source_window_as_is): Likewise.
1711         * tui/tui-win.c (make_visible_with_new_height): Update.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-winsource.c (tui_erase_source_content)
1716         (tui_show_source_content, tui_show_exec_info_content)
1717         (tui_erase_exec_info_content): Use refresh_window method.
1718         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1719         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1720         from tui_refresh_win.
1721         (tui_data_window::refresh_window): New method.
1722         (tui_win_info::refresh, tui_source_window_base::refresh)
1723         (tui_refresh_all): Use refresh_window method.
1724         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1725         method.
1726         * tui/tui-regs.c (tui_display_register): Call refresh_window
1727         method.
1728         * tui/tui-layout.c (show_source_disasm_command)
1729         (show_source_or_disasm_and_command): Call refresh_window method.
1730         * tui/tui-data.h (struct tui_gen_win_info)
1731         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1732         New method.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui.c (tui_rl_other_window, tui_enable)
1737         (tui_is_window_visible, tui_get_command_dimension): Update.
1738         * tui/tui-winsource.c (tui_update_source_window_as_is)
1739         (tui_clear_source_content, tui_erase_source_content)
1740         (tui_show_source_line, tui_source_window_base::refill)
1741         (tui_source_window_base::do_scroll_horizontal)
1742         (tui_source_window_base::set_is_exec_point_at)
1743         (tui_update_breakpoint_info, tui_set_exec_info_content)
1744         (tui_alloc_source_buffer, tui_line_is_displayed)
1745         (tui_addr_is_displayed): Update.
1746         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1747         (tui_check_and_display_highlight_if_needed)
1748         (tui_win_info::make_visible, tui_win_info::refresh)
1749         (tui_refresh_all): Update.
1750         * tui/tui-windata.c (tui_first_data_item_displayed)
1751         (tui_delete_data_content_windows, tui_erase_data_content)
1752         (tui_display_all_data, tui_data_window::refresh_all)
1753         (tui_check_data_values): Update.
1754         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1755         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1756         (tui_win_info::backward_scroll, tui_refresh_all_win)
1757         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1758         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1759         (tui_source_window_base::set_new_height)
1760         (tui_data_window::set_new_height)
1761         (make_invisible_and_set_new_height)
1762         (make_visible_with_new_height, new_height_ok)
1763         (parse_scrolling_args): Update.
1764         * tui/tui-stack.c (tui_show_frame_info): Update.
1765         * tui/tui-source.c (tui_set_source_content)
1766         (tui_set_source_content_nil, tui_source_is_displayed)
1767         (tui_source_window::do_scroll_vertical): Update.
1768         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1769         (tui_display_registers_from, tui_display_reg_element_at_line)
1770         (tui_check_register_values, tui_reg_command): Update.
1771         * tui/tui-layout.c (tui_default_win_height)
1772         (show_source_disasm_command, show_data, init_and_make_win)
1773         (show_source_or_disasm_and_command): Update.
1774         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1775         (tui_redisplay_readline, tui_mld_flush)
1776         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1777         (tui_getc): Update.
1778         * tui/tui-disasm.c (tui_set_disassem_content)
1779         (tui_disasm_window::do_scroll_vertical): Update.
1780         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1781         Now virtual.
1782         (struct tui_win_info): Derive from tui_gen_win_info.
1783         <~tui_win_info>: Mark as override.
1784         <generic>: Remove member.
1785         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1786         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1787         (~tui_data_window, ~tui_win_info)
1788         (tui_free_all_source_wins_content): Update.
1789         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-layout.c (init_and_make_win): Use new.
1794         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1795         destructor, initializers.
1796         (tui_alloc_generic_win_info): Don't declare.
1797         * tui/tui-data.c (_locator): Add argument to constructor.
1798         (source_win, disasm_win): New globals.
1799         (exec_info): Remove.
1800         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1801         Update.
1802         (tui_alloc_generic_win_info): Remove.
1803         (init_content_element): Use new.
1804         (tui_win_info::tui_win_info): Update.
1805         (free_content_elements) <case DATA_WIN>: Use delete.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1810         * tui/tui-windata.c (tui_first_data_item_displayed)
1811         (tui_delete_data_content_windows): Update.
1812         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1813         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1814         (tui_display_registers_from, tui_check_register_values): Update.
1815         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1816         pointer.
1817         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1818         window.
1819         (tui_free_data_content): Update.
1820         (free_content_elements) <case DATA_WIN>: Free the window.
1821
1822 2019-06-25  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1825         Update.
1826         * tui/tui-layout.c (make_command_window)
1827         (show_source_disasm_command, show_data, init_and_make_win)
1828         (show_source_or_disasm_and_command): Update.
1829         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1830         method.
1831         <can_highight, is_highlighted>: Now bool.
1832         (tui_set_win_highlight): Don't declare.
1833         * tui/tui-data.c (tui_set_win_highlight): Remove.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-wingeneral.c (make_visible): Remove check of window
1838         type.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-win.c (tui_win_info::max_height)
1843         (tui_cmd_window::max_height): New methods.
1844         (new_height_ok): Call max_height.
1845         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1846         <max_height>: New method.
1847
1848 2019-06-25  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-win.c (tui_source_window_base::set_new_height)
1851         (tui_data_window::set_new_height): New methods.
1852         (make_invisible_and_set_new_height): Call set_new_height method.
1853         * tui/tui-data.h (struct tui_win_info)
1854         (struct tui_source_window_base, struct tui_data_window)
1855         <set_new_height>: New method.
1856
1857 2019-06-25  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1860         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1861         tui_refresh_data_win.
1862         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1863         method.
1864         (tui_refresh_all_win): Call the refresh_all method.
1865         (tui_set_focus): Likewise.
1866         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1867         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1868         Likewise.
1869
1870 2019-06-25  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-winsource.h (tui_refill_source_window)
1873         (tui_set_is_exec_point_at): Don't declare.
1874         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1875         (tui_source_window_base::refill): Rename from
1876         tui_refill_source_window.
1877         (tui_source_window_base::do_scroll_horizontal): Update.
1878         (tui_source_window_base::set_is_exec_point_at): Rename from
1879         tui_set_is_exec_point_at.
1880         (tui_update_all_breakpoint_info): Update.
1881         * tui/tui-stack.c (tui_show_frame_info): Update.
1882         * tui/tui-layout.c (show_data): Add cast.
1883         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1884         * tui/tui-data.h (struct tui_source_window_base) <refill,
1885         set_is_exec_point_at>: New methods.
1886         (tui_source_windows, tui_add_to_source_windows): Update types.
1887         (tui_add_to_source_windows): Remove redundant declaration.
1888         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1889         (tui_source_windows): Change return type.
1890         (tui_clear_source_windows_detail): Update.
1891         (tui_add_to_source_windows): Change type of parameter.
1892         (tui_free_all_source_wins_content): Update.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-wingeneral.c (tui_win_info::refresh)
1897         (tui_source_window_base::refresh): New methods.
1898         (tui_refresh_all): Call the refresh method.
1899         * tui/tui-data.h (struct tui_win_info)
1900         (struct tui_source_window_base) <refresh>: New method.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui.h (tui_is_window_visible): Return bool.
1905         * tui/tui.c (tui_is_window_visible): Return bool.
1906         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1907         (tui_make_visible, tui_make_invisible)
1908         (tui_win_info::make_visible)
1909         (tui_source_window_base::make_visible, make_all_visible)
1910         (tui_make_all_visible, tui_make_all_invisible): Update.
1911         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1912         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1913         bool.
1914         (struct tui_win_info, struct tui_source_window_base)
1915         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1916         * tui/tui-data.c (tui_init_generic_part): Update.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1921         (tui_source_window_base::make_visible): New methods.
1922         (make_all_visible): Make method call.
1923         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1924         (struct tui_source_window_base, struct tui_cmd_window): Override
1925         make_visible.
1926         (tui_win_is_source_type): Don't declare.
1927         * tui/tui-data.c (tui_win_is_source_type): Remove.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1932         NULL check.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1937         Inline constructor.  Add initializers for members.
1938         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1939         constructors; now inline in class.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-regs.c (tui_show_registers): Update.
1944         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1945         bool.
1946         * tui/tui-data.c (tui_data_window::clear_detail)
1947         (tui_data_window): Update.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-windata.c (tui_display_all_data)
1952         (tui_display_data_from_line, tui_display_data_from)
1953         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1954         Update.
1955         * tui/tui-regs.c (tui_last_regs_line_no)
1956         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1957         (tui_show_registers, tui_show_register_group)
1958         (tui_display_registers_from, tui_display_reg_element_at_line)
1959         (tui_display_registers_from_line, tui_check_register_values)
1960         (tui_reg_next, tui_reg_prev): Update.
1961         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1962         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1963         tui_data_window.
1964         (struct tui_win_info) <detail>: Remove.  Add new fields from
1965         tui_data_info.
1966         (TUI_DATA_WIN): Add cast.
1967         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1968         (~tui_data_window): Simplify.
1969
1970 2019-06-25  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-layout.c (show_source_disasm_command)
1973         (show_source_or_disasm_and_command): Update.
1974         * tui/tui-io.c (update_cmdwin_start_line)
1975         (tui_redisplay_readline): Update.
1976         * tui/tui-data.h (struct tui_command_info): Remove.
1977         (struct tui_win_info) <detail>: Remove command_info member.
1978         (struct tui_data_window) <start_line>: New member, from
1979         tui_command_info.
1980         (TUI_CMD_WIN): Add casts.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-winsource.c (tui_update_source_window)
1985         (tui_refill_source_window)
1986         (tui_source_window_base::do_scroll_horizontal)
1987         (tui_update_breakpoint_info, tui_set_exec_info_content)
1988         (tui_show_exec_info_content, tui_erase_exec_info_content)
1989         (tui_clear_exec_info_content): Update.
1990         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1991         Update.
1992         * tui/tui-win.c (make_invisible_and_set_new_height)
1993         (make_visible_with_new_height): Update.
1994         * tui/tui-source.c (tui_set_source_content)
1995         (tui_show_symtab_source): Update.
1996         * tui/tui-layout.c (extract_display_start_addr)
1997         (show_source_disasm_command, show_data)
1998         (make_source_or_disasm_window)
1999         (show_source_or_disasm_and_command): Update.
2000         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2001         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2002         "gdbarch".
2003         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2004         to tui_source_window_base.
2005         (struct tui_win_info) <detail>: Remove source_info member.
2006         (struct tui_source_window_base) <has_locator>: Inline.
2007         Move contents from tui_source_info; rename has_locator member to
2008         m_has_locator.
2009         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2010         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2011         header file.
2012         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2013         Simplify.
2014         (tui_free_all_source_wins_content): Cast to
2015         tui_source_window_base.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-win.c (make_invisible_and_set_new_height)
2020         (make_visible_with_new_height): Call has_locator method.
2021         * tui/tui-layout.c (show_source_disasm_command, show_data)
2022         (show_source_or_disasm_and_command): Update for bool change.
2023         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2024         (tui_win_info) <has_locator>: New method.
2025         (struct tui_source_window_base) <has_locator>: New method.
2026         (tui_win_has_locator): Don't declare.
2027         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2028         from tui_win_has_locator.
2029         (tui_source_window_base): Use false, not FALSE.
2030
2031 2019-06-25  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2034         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2035         clear_detail method directly.
2036         (tui_clear_win_detail): Remove.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2041         "this", not TUI_DISASM_WIN.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2046         declare.
2047         * tui/tui-winsource.c
2048         (tui_source_window_base::do_scroll_horizontal): Rename from
2049         tui_horizontal_source_scroll.
2050         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2051         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2052         from tui_vertical_data_scroll.
2053         * tui/tui-win.h (tui_scroll): Don't declare.
2054         * tui/tui-win.c (tui_win_info::forward_scroll)
2055         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2056         (tui_win_info::right_scroll): Rename and update.
2057         (tui_scroll_forward_command, tui_scroll_backward_command)
2058         (tui_scroll_left_command, tui_scroll_right_command): Update.
2059         (tui_scroll): Remove.
2060         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2061         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2062         from tui_vertical_source_scroll.
2063         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2064         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2065         from tui_vertical_disassem_scroll.
2066         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2067         do_scroll_horizontal>: New methods.
2068         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2069         Likewise.
2070         (struct tui_source_window_base): Add do_scroll_horizontal.
2071         (struct tui_source_window, struct tui_disasm_window): Add
2072         do_scroll_vertical.
2073         (struct tui_data_window, struct tui_cmd_window): Add
2074         do_scroll_horizontal and do_scroll_vertical.
2075         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2076
2077 2019-06-25  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-data.h (struct tui_source_window_base): New struct.
2080         (struct tui_source_window): Derive from tui_source_window_base.
2081         (struct tui_disasm_window): New struct.
2082         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2083         from tui_source_window::clear_detail.
2084         (tui_source_window_base): Rename from tui_source_window.
2085         (~tui_source_window_base): Rename from ~tui_source_window.
2086         (tui_alloc_win_info): Create a tui_disasm_window.
2087
2088 2019-06-25  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-data.h (struct tui_source_window)
2091         (struct tui_data_window): Declare destructors.
2092         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2093         destructors.
2094         (tui_win_info): Simplify.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-winsource.c (tui_display_main)
2099         (tui_update_source_windows_with_addr)
2100         (tui_update_all_breakpoint_info): Update.
2101         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2102         (new_height_ok, parse_scrolling_args): Update.
2103         * tui/tui-stack.c (tui_show_frame_info): Update.
2104         * tui/tui-data.h (struct tui_list): Remove.
2105         (tui_source_windows): Return a reference to a std::vector.
2106         * tui/tui-data.c (source_windows): Now a std::vector.
2107         (tui_source_windows): Change return type.
2108         (tui_clear_source_windows): Rewrite.
2109         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2110         (tui_free_all_source_wins_content): Rewrite.
2111
2112 2019-06-25  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2115         (struct tui_data_window, struct tui_cmd_window): Declare
2116         clear_detail method.
2117         * tui/tui-data.c (tui_source_window::clear_detail)
2118         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2119         methods.
2120         (tui_clear_win_detail): Simplify.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-layout.c (make_source_window, make_disasm_window)
2125         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2126         Return the new window.
2127         (show_source_disasm_command, show_data)
2128         (show_source_or_disasm_and_command): Update.
2129
2130 2019-06-25  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2133         parameter.  Return the new window.
2134         (show_source_disasm_command): Update and remove NULL check.
2135         (show_source_or_disasm_and_command): Update.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-data.h (struct tui_win_info): Make constructor
2144         protected.  Make destructor virtual.  Add initializers.
2145         (tui_source_window, tui_data_window, tui_cmd_window): New
2146         classes.
2147         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2148         constructor.  Add "type" parameter.
2149         (tui_source_window, tui_data_window, tui_cmd_window): New
2150         constructors.
2151         (tui_alloc_win_info): Instantiate the appropriate subclass.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-win.c (tui_resize_all): Use delete.
2156         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2157         destructor.
2158         (tui_free_window): Don't declare.
2159         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2160         Update.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-data.h (struct tui_win_info): Add constructor.
2165         * tui/tui-data.c (tui_alloc_win_info): Use new.
2166         (tui_free_window): Use delete.
2167
2168 2019-06-22  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2171         declare.
2172         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2173
2174 2019-06-22  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2177         declare.
2178         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2179
2180 2019-06-22  Tom de Vries  <tdevries@suse.de>
2181
2182         * dwarf2read.c (create_addrmap_from_aranges)
2183         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2184         instead of '%zu'.
2185
2186 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2187
2188         * dwarf2read.h (dwarf2_section_info_def): Remove.
2189         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2190         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2191         std::vector<dwarf2_section_info>.
2192         (struct dwo_file) <~dwo_file>: Remove.
2193         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2194         types field.
2195         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2196         (dwarf2_read_debug_names): Likewise.
2197         (create_debug_types_hash_table): Change parameter type to
2198         array_view, adjust code accordingly.
2199         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2200         (partial_die_info::fixup): Likewise.
2201         (determine_prefix): Likewise.
2202         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2203
2204 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2205
2206         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2207         gdb_bfd_ref_ptr.
2208         <~dwo_file>: Remove call to gdb_bfd_unref.
2209         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2210         gdb_bfd_ref_ptr::get.
2211
2212 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2213
2214         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2215         type to htab_up.
2216         * dwarf2read.c (struct dwo_file): Initialize fields.
2217         <~dwo_file>: New.
2218         (free_dwo_file): Remove, move content to ~dwo_file.
2219         (struct dwo_file_deleter): Remove.
2220         (dwo_file_up>: Remove custom deleter.
2221         (free_dwo_files): Remove.
2222         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2223         dwo_files.
2224         (process_skeletonless_type_units): Call unique_ptr::get.
2225         (allocate_dwo_file_hash_table): Add deleter to created hash
2226         table.  Change return type to htab_up.
2227         (lookup_dwo_file_slot): Don't memset dwo_file, call
2228         unique_ptr::get.
2229         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2230         (create_dwo_unit_in_dwp_v2): Likewise.
2231         (open_and_init_dwo_file): Likewise.
2232         (free_dwo_file_from_slot): Remove.
2233
2234 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2235
2236         * dwarf2read.h (struct dwarf2_section_info) <readin,
2237         is_virtual>: Change type to bool.
2238         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2239         true instead of 1.
2240
2241 2019-06-19  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-data.h (tui_init_content_element): Don't declare.
2244
2245 2019-06-19  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-data.h (tui_init_win_info): Don't declare.
2248
2249 2019-06-19  Tom de Vries  <tdevries@suse.de>
2250
2251         * dwarf2read.h (abstract_to_concrete): Change type to
2252         std::unordered_map<sect_offset, std::vector<sect_offset>,
2253         gdb::hash_enum<sect_offset>>.
2254
2255 2019-06-19  Tom Tromey  <tromey@adacore.com>
2256
2257         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2258         EVAL_AVOID_SIDE_EFFECTS specially.
2259
2260 2019-06-19  Tom Tromey  <tromey@adacore.com>
2261
2262         * source-cache.c (highlighter): New global.
2263         (source_cache::get_source_lines): Create a highlighter on demand.
2264
2265 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2266
2267         * defs.h (deprecated_interactive_hook): Delete declaration.
2268         * interps.c (clear_interpreter_hooks): Remove use of
2269         deprecated_interactive_hook.
2270         * top.c (deprecated_interactive_hook): Delete definition.
2271         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2272
2273 2019-06-18  Tom de Vries  <tdevries@suse.de>
2274
2275         PR gdb/24515
2276         * dwarf2read.h (abstract_to_concrete): Change type from
2277         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2278         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2279         * dwarf2read.c (read_variable): Update.
2280         (dwarf2_fetch_die_loc_sect_off): Update.
2281
2282 2019-06-17  Tom de Vries  <tdevries@suse.de>
2283
2284         PR gdb/24617
2285         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2286         accessing parent[parent_len - 1].
2287
2288 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2289
2290         PR gdb/24364
2291         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2292         call dtrace_process_dof with NULL dof.
2293
2294 2019-06-16  Tom de Vries  <tdevries@suse.de>
2295
2296         PR gdb/24445
2297         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2298
2299 2019-06-16  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2302         (make_all_visible): Use address of member.
2303
2304 2019-06-16  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2307         (tui_free_window, free_content, free_content_elements): Remove
2308         unnecessary cast.
2309         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2310         cast.
2311         * tui/tui-regs.c (tui_show_register_group)
2312         (tui_display_registers_from, tui_display_reg_element_at_line):
2313         Remove unnecessary cast.
2314
2315 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * linux-nat.c (normal_mask): Delete.
2318         (_initialize_linux_nat): Don't initialise normal_mask.
2319
2320 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2321
2322         PR gdb/24445
2323         * dwarf-index-write.h (write_psymtabs_to_index): Add
2324         dwz_basename parameter.
2325         * dwarf-index-write.c (write_gdbindex): Move file writing to
2326         write_gdbindex_1.  Change return type void.
2327         (assert_file_size): Move up, remove filename parameter.
2328         (write_gdbindex_1): New function.
2329         (write_debug_names): Change return type to void, call
2330         assert_file_size.
2331         (struct index_wip_file): New struct.
2332         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2333         file logic to index_wip_file.  Write index for dwz file if
2334         needed.
2335         (save_gdb_index_command): Pass basename of dwz file, if present.
2336         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2337         build-id of dwz file, if present.
2338         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2339         (dwarf2_get_dwz_file): Likewise.
2340         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2341         (dwarf2_get_dwz_file): Likewise.
2342
2343 2019-06-16  Tom Tromey  <tom@tromey.com>
2344
2345         * coffread.c (process_coff_symbol): Use xstrdup.
2346         * value.c (create_internalvar): Use xstrdup.
2347
2348 2019-06-16  Tom Tromey  <tom@tromey.com>
2349
2350         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2351         * breakpoint.c (stopin_command, stopat_command)
2352         (until_break_command, decode_location_default): Remove unnecessary
2353         cast.
2354         * utils.c (subset_compare): Remove unnecessary cast.
2355         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2356         cast.
2357         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2358         cast.
2359         * infcmd.c (path_command): Remove unnecessary cast.
2360         * coffread.c (decode_type): Remove unnecessary cast.
2361         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2362         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2363         * tui/tui-stack.c (tui_show_locator_content)
2364         (tui_show_frame_info): Remove unnecessary cast.
2365         * tui/tui-win.c (tui_scroll_forward_command)
2366         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2367         (parse_scrolling_args): Remove unnecessary cast.
2368         * tui/tui-data.c (init_win_info, tui_del_window)
2369         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2370         (free_content_elements): Remove unnecessary cast.
2371         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2372         unnecessary cast.
2373         * tui/tui-source.c (tui_set_source_content)
2374         (tui_vertical_source_scroll): Remove unnecessary cast.
2375         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2376         cast.
2377         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2378         * tui/tui-regs.c (tui_display_registers_from)
2379         (tui_display_register): Remove unnecessary cast.
2380         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2381         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2382         (make_visible): Remove unnecessary cast.
2383         * tui/tui-winsource.c (tui_erase_source_content)
2384         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2385         unnecessary cast.
2386         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2387         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2388         * stabsread.c (read_type, read_array_type, read_range_type):
2389         Remove unnecessary cast.
2390         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2391         (parse_symbol, parse_type, upgrade_type, parse_external)
2392         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2393         unnecessary cast.
2394         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2395
2396 2019-06-16  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-data.c (tui_alloc_generic_win_info)
2399         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2400         checks.
2401
2402 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2403             Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * f-typeprint.c (f_print_type): Don't return early for not
2406         associated or not allocated types.
2407         (f_type_print_varspec_suffix): Add print_rank parameter and print
2408         ranks of array types in case they dangling.
2409         (f_type_print_base): Add print_rank parameter.
2410
2411 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * NEWS: Mention new MI commands.
2414         * break-catch-throw.c (enum exception_event_kind): Move to
2415         breakpoint.h.
2416         (print_mention_exception_catchpoint): Output text as a single
2417         message.
2418         (catch_exception_command_1): Rename to...
2419         (catch_exception_event): ...this, make non-static, update header
2420         command, and change some parameter types.
2421         (catch_catch_command): Update for changes to
2422         catch_exception_command_1.
2423         (catch_throw_command): Likewise.
2424         (catch_rethrow_command): Likewise.
2425         * breakpoint.c (enum exception_event_kind): Delete.
2426         * breakpoint.h (enum exception_event_kind): Moved here from
2427         break-catch-throw.c.
2428         (catch_exception_event): Declare.
2429         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2430         (mi_cmd_catch_throw): New function.
2431         (mi_cmd_catch_rethrow): New function.
2432         (mi_cmd_catch_catch): New function.
2433         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2434         'catch-catch' entries.
2435         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2436         (mi_cmd_catch_rethrow): Declare.
2437         (mi_cmd_catch_catch): Declare.
2438
2439 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * annotate.c (annotate_source_line): Change return type to void,
2442         update implementation to match.
2443         * annotate.h (annotate_source_line): Change return type to void,
2444         update header comment.
2445         * stack.c (print_frame_info): Don't change what frame information
2446         is printed based on whether annotations are on or not.
2447
2448 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2451         (annotate_source): Make static.
2452         (annotate_source_line): Moved from source.c and renamed from
2453         identify_source_line.  Update the return type.
2454         * annotate.h (annotate_source): Delete declaration.
2455         (annotate_source_line): Declaration moved from source.h, and
2456         renamed from identify_source_line.  Return type updated.
2457         * source.c (identify_source_line): Moved to annotate.c and renamed
2458         to annotate_source_line.
2459         (info_line_command): Remove check of annotation_level.
2460         * source.h (identify_source_line): Move declaration to annotate.h
2461         and rename to annotate_source_line.
2462         * stack.c: Add 'annotate.h' include.
2463         (print_frame_info): Remove check of annotation_level before
2464         calling annotate_source_line.
2465
2466 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2467
2468         * source-cache.c (source_cache::get_plain_source_lines): Use
2469         open_source_file_with_line_charpos instead of just
2470         open_source_file, remove call to find_source_lines.
2471         (source_cache::get_source_lines): Likewise.
2472         * source.c (find_source_lines): Make static.
2473         (get_filename_and_charpos): Renamed into...
2474         (open_source_file_with_line_charpos): ..this along with changes to
2475         return a scoped_fd, and some other minor clean ups.
2476         (identify_source_line): Use open_source_file_with_line_charpos.
2477         (search_command_helper): Use open_source_file_with_line_charpos
2478         instead of just open_source_file, remove call to
2479         find_source_lines.
2480         * source.h (open_source_file_with_line_charpos): Declare new
2481         function.
2482         (find_source_lines): Delete declaration.
2483
2484 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2485
2486         * source.c (get_filename_and_charpos): Remove fullname
2487         parameter.
2488         (identify_source_line): Update call to get_filename_and_charpos.
2489
2490 2019-06-14  Tom Tromey  <tromey@adacore.com>
2491
2492         PR gdb/24502:
2493         * ui-style.h (skip_ansi_escape): Update comment.
2494         * ui-file.h (class no_terminal_escape_file): New class.
2495         * ui-file.c (no_terminal_escape_file::write)
2496         (no_terminal_escape_file::puts): New methods.
2497         * cli/cli-logging.c (handle_redirections): Use
2498         no_terminal_escape_file.
2499
2500 2019-06-14  Tom Tromey  <tromey@adacore.com>
2501
2502         * NEWS: Move convenience variable news above Python news.
2503
2504 2019-06-14  Tom Tromey  <tom@tromey.com>
2505
2506         * gnulib: Move directory to top-level.
2507         * configure.ac: Don't configure gnulib.
2508         * configure: Rebuild.
2509         * common/common-defs.h: Use new path to gnulib.
2510         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2511         (GNULIB_H): Remove.
2512         (INCGNU): Look in new gnulib location.
2513         (HFILES_NO_SRCDIR): Remove gnulib files.
2514         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2515         (generated_files): Remove GNULIB_H.
2516         ($(LIBGNU), all-lib): Remove targets.
2517         (distclean): Don't mention GNULIB_BUILDDIR.
2518         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2519
2520 2019-06-14  Tom Tromey  <tromey@adacore.com>
2521
2522         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2523         Warn if symbol file does not provide any symbols.
2524
2525 2019-06-14  Tom Tromey  <tromey@adacore.com>
2526
2527         * source.c (find_and_open_source): Respect basenames_may_differ.
2528
2529 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * annotate.c (annotate_breakpoints_invalid): Make use of
2532         scoped_restore_terminal_state.
2533         (annotate_frames_invalid): Likewise.
2534
2535 2019-06-14  Tom Tromey  <tromey@adacore.com>
2536
2537         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2538         allow assignment to an internalvar.
2539
2540 2019-06-14  Tom Tromey  <tromey@adacore.com>
2541
2542         * ada-lex.l: Allow "_" in attribute names.
2543
2544 2019-06-14  Tom Tromey  <tromey@adacore.com>
2545
2546         PR gdb/24653:
2547         * regcache.c (registers_changed): Don't call alloca.
2548         * top.c (execute_command): Don't call alloca.
2549
2550 2019-06-13  Pedro Alves  <palves@redhat.com>
2551
2552         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2553         'expression'.  When parsing an expression, error out if there's
2554         junk after "unlimited".
2555         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2556         (do_set_command): Adjust calls to is_unlimited_literal.
2557
2558 2019-06-13  Pedro Alves  <palves@redhat.com>
2559
2560         * compile/compile.c (make_compile_options_def_group): Add braces
2561         around array_view initializer.
2562         * thread.c (make_thread_apply_all_options_def_group)
2563         (make_thread_apply_all_options_def_group): Likewise.
2564
2565 2019-06-13  Pedro Alves  <palves@redhat.com>
2566
2567         * NEWS (New commands): Mention "maint test-options
2568         require-delimiter", "maint test-options unknown-is-error", "maint
2569         test-options unknown-is-operand" and "maint show
2570         test-options-completion-result".
2571         (New command options, command completion): New section.
2572         (Completion improvements): New section.
2573         Mention that you can abbreviate "unlimited".
2574
2575 2019-06-13  Pedro Alves  <palves@redhat.com>
2576
2577         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2578         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2579         * unittests/cli-utils-selftests.c (test_parse_flags)
2580         (test_parse_flags_qcs): Delete.
2581         (test_cli_utils): Don't call deleted functions.
2582
2583 2019-06-13  Pedro Alves  <palves@redhat.com>
2584
2585         * thread.c: Include "cli/cli-option.h".
2586         (tp_array_compar_ascending): Global.
2587         (tp_array_compar): Delete function.
2588         (tp_array_compar_ascending, tp_array_compar_descending): New
2589         functions.
2590         (ascending_option_def, qcs_flag_option_def)
2591         (thr_qcs_flags_option_defs)
2592         (make_thread_apply_all_options_def_group)
2593         (make_thread_apply_options_def_group): New.
2594         (thread_apply_all_command): Use gdb::option::process_options.
2595         (thread_apply_command_completer)
2596         (thread_apply_all_command_completer): New.
2597         (thread_apply_command): Use gdb::option::process_options.
2598         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2599         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2600         to generate help text of "thread apply".  Adjust "taas"'s help.
2601         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2602         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2603
2604 2019-06-13  Pedro Alves  <palves@redhat.com>
2605
2606         * thread.c (thread_apply_command): Check for invalid TID with
2607         isdigit instead of !isalpha.
2608
2609 2019-06-13  Pedro Alves  <palves@redhat.com>
2610
2611         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2612         (validate_flags_qcs): New.
2613         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2614         (validate_flags_qcs): Declare.
2615         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2616         (make_frame_apply_options_def_group): New.
2617         (frame_apply_command_count): Process options with
2618         gdb::option::process_options.
2619         (frame_apply_completer): New.
2620         (frame_apply_level_completer, frame_apply_all_completer)
2621         (frame_apply_completer): New.
2622         (_initialize_stack): Update help of "frame apply", "frame apply
2623         level", "frame apply all" and "faas" to mention supported options
2624         and install command completers.
2625         * stack.h (frame_apply_all_completer): Declare.
2626         * thread.c: Include "stack.h".
2627         (tfaas_command): Add "--".
2628         (_initialize_thread): Update help "tfaas" to mention supported
2629         options and install command completer.
2630
2631 2019-06-13  Pedro Alves  <palves@redhat.com>
2632
2633         * completer.c (complete_nested_command_line): New.
2634         (gdb_completion_word_break_characters_throw): Add assertion.
2635         * completer.h (complete_nested_command_line): Declare.
2636
2637 2019-06-13  Pedro Alves  <palves@redhat.com>
2638
2639         * stack.c (parse_backtrace_qualifiers): New.
2640         (backtrace_command): Use it.
2641         (backtrace_command_completer): Complete on qualifiers.
2642
2643 2019-06-13  Pedro Alves  <palves@redhat.com>
2644
2645         * frame.c: Include "cli/cli-option.h.
2646         (user_set_backtrace_options): New.
2647         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2648         Delete.
2649         (get_prev_frame): Adjust.
2650         (boolean_option_def, uinteger_option_def)
2651         (set_backtrace_option_defs): New.
2652         (_initialize_frame): Adjust and use
2653         gdb::option::add_setshow_cmds_for_options to install "set
2654         backtrace past-main" and "set backtrace past-entry".
2655         * frame.h: Include "cli/cli-option.h".
2656         (struct frame_print_options): Forward declare.
2657         (print_frame_arguments_all, print_frame_arguments_scalars)
2658         (print_frame_arguments_none): Declare.
2659         (print_entry_values): Delete declaration.
2660         (struct frame_print_options, user_frame_print_options): New.
2661         (struct set_backtrace_options): New.
2662         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2663         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2664         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2665         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2666         (list_args_or_locals): Add frame_print_options parameter.
2667         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2668         * python/py-framefilter.c (enumerate_args): Pass down
2669         USER_FRAME_PRINT_OPTIONS.
2670         * stack.c: Include "cli/cli-option.h".
2671         (print_frame_arguments_all, print_frame_arguments_scalars)
2672         (print_frame_arguments_none): Declare.
2673         (print_raw_frame_arguments, print_entry_values): Delete.
2674         (user_frame_print_options): New.
2675         (boolean_option_def, enum_option_def, frame_print_option_defs):
2676         New.
2677         (struct backtrace_cmd_options): New.
2678         (bt_flag_option_def): New.
2679         (backtrace_command_option_defs): New.
2680         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2681         (print_frame_arg, read_frame_arg, print_frame_args)
2682         (print_frame_info, print_frame): Add frame_print_options parameter
2683         and use it.
2684         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2685         (backtrace_command_1): Add frame_print_options and
2686         backtrace_cmd_options parameters and use them.
2687         (make_backtrace_options_def_group): New.
2688         (backtrace_command): Process command options with
2689         gdb::option::process_options.
2690         (backtrace_command_completer): New.
2691         (_initialize_stack): Extend "backtrace"'s help to mention
2692         supported options.  Install completer for "backtrace".
2693         Install some settings commands with add_setshow_cmds_for_options.
2694
2695 2019-06-13  Pedro Alves  <palves@redhat.com>
2696
2697         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2698         and that "set/show print raw frame-arguments" are now deprecated.
2699
2700         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2701         command.
2702         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2703         * stack.c (_initialize_stack): Install "set/show print
2704         raw-frame-arguments", and deprecate "set/show print raw
2705         frame-arguments".
2706         * valprint.c (_initialize_valprint): Deprecate "set/show print
2707         raw".
2708
2709 2019-06-13  Pedro Alves  <palves@redhat.com>
2710
2711         * compile/compile.c (struct compile_options): New.
2712         (compile_flag_option_def, compile_command_option_defs)
2713         (make_compile_options_def_group): New.
2714         (compile_file_command): Handle options with
2715         gdb::option::process_options.
2716         (compile_file_command_completer): New function.
2717         (compile_code_command): Handle options with
2718         gdb::option::process_options.
2719         (compile_code_command_completer): New function.
2720         (_initialize_compiler): Install completers for "compile code" and
2721         "compile file".  Mention available options in "compile code" and
2722         "compile code"'s help.
2723         * completer.c (advance_to_completion_word): New, factored out from
2724         ...
2725         (advance_to_expression_complete_word_point): ... this.
2726         (advance_to_filename_complete_word_point): New.
2727         * completer.h (advance_to_filename_complete_word_point): New
2728         declaration.
2729
2730 2019-06-13  Pedro Alves  <palves@redhat.com>
2731
2732         * compile/compile.c: Include "cli/cli-option.h".
2733         (compile_print_value): Scope data pointer is now a
2734         value_print_options pointer; adjust.
2735         (compile_print_command): Process options.  Scope data pointer is
2736         now a value_print_options pointer; adjust.
2737         (_initialize_compile): Update "compile print"'s help to include
2738         supported options.  Install a completer for "compile print".
2739         * cp-valprint.c (show_vtblprint, show_objectprint)
2740         (show_static_field_print): Delete.
2741         (_initialize_cp_valprint): Don't install "set print
2742         static-members", "set print vtbl", "set print object" here.
2743         * printcmd.c: Include "cli/cli-option.h" and
2744         "common/gdb_optional.h".
2745         (print_command_parse_format): Rework to fill in a
2746         value_print_options instead of a format_data.
2747         (print_value): Change parameter type from format_data pointer to
2748         value_print_options reference.  Adjust.
2749         (print_command_1): Process options.  Adjust to pass down a
2750         value_print_options.
2751         (print_command_completer): New.
2752         (_initialize_printcmd): Install print_command_completer as
2753         handle_brkchars completer for the "print" command.  Update
2754         "print"'s help to include supported options.
2755         * valprint.c: Include "cli/cli-option.h".
2756         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2757         here from cp-valprint.c.
2758         (boolean_option_def, uinteger_option_def)
2759         (value_print_option_defs, make_value_print_options_def_group):
2760         New.  Use gdb::option::add_setshow_cmds_for_options to install
2761         "set print elements", "set print null-stop", "set print repeats",
2762         "set print pretty", "set print union", "set print array", "set
2763         print address", "set print symbol", "set print array-indexes".
2764         * valprint.h: Include <string> and "cli/cli-option.h".
2765         (make_value_print_options_def_group): Declare.
2766         (print_value): Change parameter type from format_data pointer to
2767         value_print_options reference.
2768         (print_command_completer): Declare.
2769
2770 2019-06-13  Pedro Alves  <palves@redhat.com>
2771
2772         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2773         (COMMON_SFILES): Add maint-test-settings.c.
2774         * cli/cli-decode.c (boolean_enums): New global, factored out from
2775         ...
2776         (add_setshow_boolean_cmd): ... here.
2777         * cli/cli-decode.h (boolean_enums): Declare.
2778         * cli/cli-option.c: New file.
2779         * cli/cli-option.h: New file.
2780         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2781         factored out from ...
2782         (parse_cli_boolean_value(const char *)): ... this.
2783         (is_unlimited_literal): Change parameter type to pointer to
2784         pointer.  Adjust and advance ARG pointer.
2785         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2786         (parse_cli_var_enum): New, factored out from ...
2787         (do_set_command): ... this.  Adjust.
2788         * cli/cli-setshow.h (parse_cli_boolean_value)
2789         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2790         (parse_cli_var_enum): Declare.
2791         * cli/cli-utils.c: Include "cli/cli-option.h".
2792         (get_ulongest): New.
2793         * cli/cli-utils.h (get_ulongest): Declare.
2794         (check_for_argument): New overloads.
2795         * maint-test-options.c: New file.
2796
2797 2019-06-13  Pedro Alves  <palves@redhat.com>
2798
2799         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2800         parse a range if "-" is at the end of the string.
2801
2802 2019-06-13  Pedro Alves  <palves@redhat.com>
2803
2804         * cli/cli-setshow.c (parse_auto_binary_operation)
2805         (parse_cli_boolean_value): Don't allow "o".
2806
2807 2019-06-13  Pedro Alves  <palves@redhat.com>
2808
2809         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2810         * NEWS: Mention maint test-settings KIND.
2811         * maint-test-settings.c: New file.
2812
2813 2019-06-13  Pedro Alves  <palves@redhat.com>
2814
2815         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2816         completer.
2817         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2818         "set" completers.
2819
2820 2019-06-13  Pedro Alves  <palves@redhat.com>
2821
2822         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2823         after item.
2824
2825 2019-06-13  Pedro Alves  <palves@redhat.com>
2826
2827         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2828
2829 2019-06-13  Pedro Alves <palves@redhat.com>
2830
2831         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2832         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2833         call.
2834         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2835         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2836         calls.
2837         (check_for_argument): Skip spaces after argument.
2838
2839 2019-06-13  Pedro Alves  <palves@redhat.com>
2840
2841         * thread.c (thread_apply_command): Adjust TID parsing.
2842         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2843         detected before end of string.
2844         (tid_is_in_list): Error out if LIST is invalid.
2845
2846 2019-06-13  Pedro Alves  <palves@redhat.com>
2847
2848         * completer.c (complete_line_internal_1): Rewind completion word
2849         point.
2850         (completion_tracker::advance_custom_word_point_by): Change
2851         parameter type to int.
2852         * completer.h (completion_tracker::advance_custom_word_point_by):
2853         Likewise.
2854
2855 2019-06-13  Pedro Alves  <palves@redhat.com>
2856
2857         * completer.c (advance_to_completion_word): Handle delimiters.
2858
2859 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2860
2861         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2862
2863 2019-06-11  Tom Tromey  <tom@tromey.com>
2864
2865         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2866         (xmalloc_failed): Move to alloc.c.
2867         * alloc.c: New file.
2868         * Makefile.in (COMMON_SFILES): Add alloc.c.
2869
2870 2019-06-11  Tom Tromey  <tom@tromey.com>
2871
2872         * nat/linux-waitpid.c: Don't include server.h.
2873         (linux_debug): Remove.
2874         (my_waitpid): Update.
2875
2876 2019-06-11  Tom Tromey  <tromey@adacore.com>
2877
2878         * infcall.c (_initialize_infcall): Remove trailing newline from
2879         help.
2880         * user-regs.c (_initialize_user_regs): Remove trailing newline
2881         from help.
2882         * typeprint.c (_initialize_typeprint): Remove trailing newline
2883         from help.
2884         * reverse.c (_initialize_reverse): Remove trailing newlines from
2885         help.
2886         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2887         from help.
2888         * language.c (add_set_language_command): Remove trailing newline
2889         from help.
2890         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2891         help.
2892         * disasm.c (_initialize_disasm): Remove trailing newline from
2893         help.
2894         * top.c (init_main): Remove trailing newline from help.
2895         * interps.c (_initialize_interpreter): Remove trailing newline
2896         from help.
2897         * btrace.c (_initialize_btrace): Remove trailing newlines from
2898         help.
2899         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2900         from help.
2901         * python/python.c (_initialize_python): Remove trailing newline
2902         from help.
2903         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2904         help.
2905         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2906         from help.  Reformat some text.
2907         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2908         from help.
2909         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2910         newline from help.
2911
2912 2019-06-11  Tom Tromey  <tromey@adacore.com>
2913
2914         * darwin-nat.c (darwin_decode_exception_message)
2915         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2916
2917 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * valops.c (value_slice): Check for not allocated or not
2920         associated values.
2921
2922 2019-06-10  Tom de Vries  <tdevries@suse.de>
2923
2924         PR gdb/24618
2925         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2926         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2927         invalid.
2928
2929 2019-06-10  Tom de Vries  <tdevries@suse.de>
2930
2931         PR gdb/24611
2932         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2933         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2934
2935 2019-06-10  Tom de Vries  <tdevries@suse.de>
2936
2937         PR symtab/24545
2938         * symtab.c (struct demangled_name_entry): Add language field.
2939         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2940         static minimal symbol".  Set and use language field.
2941
2942 2019-06-10  Tom Tromey  <tromey@adacore.com>
2943
2944         * ada-lang.c (_initialize_ada_language): Update help text.
2945
2946 2019-06-10  Tom Tromey  <tromey@adacore.com>
2947
2948         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2949         with a newline.
2950         * guile/guile.c (handle_boot_error): Don't end warning with a
2951         newline.
2952         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2953         warning with a newline.
2954         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2955         newline.
2956         (s12z_frame_cache): Likewise.
2957         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2958         a newline.
2959         * solib-svr4.c (disable_probes_interface): Don't end warning with
2960         a newline.
2961         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2962         newline.
2963         * python/python.c (do_finish_initialization): Don't end warning
2964         with a newline.
2965
2966 2019-06-10  Tom Tromey  <tom@tromey.com>
2967
2968         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2969         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2970         gdbpy_enter.
2971
2972 2019-06-10  Tom Tromey  <tromey@adacore.com>
2973
2974         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2975         data.
2976         (elf_new_init): Don't call stabsread_new_init.
2977         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2978         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2979         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2980
2981 2019-06-10  Tom de Vries  <tdevries@suse.de>
2982
2983         PR symtab/16264
2984         PR symtab/24517
2985         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2986
2987 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2988
2989         * source.c (find_and_open_source): Also rewrite relative file
2990         names.
2991
2992 2019-04-26  Amos Bird  <amosbird@gmail.com>
2993
2994         * annotate.c (annotate_thread_exited): Add "thread-exited"
2995         annotation.
2996
2997 2019-06-06  Tom Tromey  <tromey@adacore.com>
2998
2999         * maint.h (class scoped_command_stats): Use
3000         DISABLE_COPY_AND_ASSIGN.
3001         <print_time>: New method.
3002         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3003         print_time.
3004         (scoped_command_stats::print_time): New method.
3005
3006 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3007
3008         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3009         instructions of lengths 6 or 8 bytes.
3010
3011 2019-06-04  Pedro Alves  <palves@redhat.com>
3012
3013         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3014
3015         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3016         * breakpoint.c (condition_completer): Likewise.
3017         * cli/cli-dump.c (scan_expression): Likewise.
3018         * common/filestuff.c (mkdir_recursive): Likewise.
3019         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3020         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3021         (gdb_abspath): Likewise.
3022         * compile/compile-cplus-types.c
3023         (compile_cplus_instance::decl_name): Likewise.
3024         * completer.c (complete_explicit_location):
3025         (signal_completer, reg_or_group_completer_1): Likewise.
3026         * cp-support.c (cp_remove_params_if_any): Likewise.
3027         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3028         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3029         * infcmd.c (strip_bg_char): Likewise.
3030         * linespec.c (copy_token_string): Likewise.
3031         * mi/mi-main.c (output_cores): Likewise.
3032         * psymtab.c (psymtab_search_name):
3033         * symfile.c (test_set_ext_lang_command): Likewise.
3034         * target.c (target_fileio_read_stralloc): Likewise.
3035         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3036         * value.c (complete_internalvar): Likewise.
3037
3038 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3039
3040         Add objfile property to gdb.Type.
3041         * NEWS: Mention Python API addition.
3042         * python/py-type.c (typy_get_objfile): New method.
3043
3044 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3045
3046         * NEWS: Mention the new set|show style [title|highlight].
3047         Mention changes to "show style", "help" and "apropos".
3048
3049 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3050
3051         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3052         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3053         instead of print_help_for_command.
3054         (print_doc_of_command): New function.
3055         (help_list): Add 'apropos -v word' suggestion.
3056         (print_help_for_command): Style the command name using title style.
3057         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3058         (_initialize_cli_cmds): Describe -v in apropos_command help.
3059
3060 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3061
3062         * cli/cli-style.h (cli_style_option): Add name in constructor,
3063         add m_name class member, add constructor with intensity,
3064         add name class function.
3065         (cli_style_option::add_setshow_commands): Remove name argument.
3066         (highlight_style, title_style): New styles.
3067         * cli/cli-style.c (do_show): New function that shows a style
3068         characteristic styling the style name with itself.
3069         (set_style_name): New function.
3070         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3071         Update all callers according to the changes in cli/cli-style.h.
3072         * utils.h (fputs_highlighted): New function.
3073         * utils.c (fputs_highlighted): Likewise.
3074
3075 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3076
3077         * NEWS: Mention new pipe command and new convenience variables.
3078
3079 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3080
3081         * cli/cli-cmds.c (pipe_command): New function.
3082         (_initialize_cli_cmds): Call add_com for pipe_command.
3083         Define | as an alias for pipe.
3084         (exit_status_set_internal_vars): New function.
3085         (shell_escape): Call exit_status_set_internal_vars.
3086         cli/cli-decode.c (find_command_name_length): Recognize | as
3087         a single character command.
3088
3089 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3090
3091         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3092         top.c (execute_command_to_ui_file): New function, mostly a copy
3093         of execute_command_to_string.
3094         (execute_command_to_string): Implement by calling
3095         execute_command_to_ui_file.
3096
3097 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3098
3099         * top.h (saved_command_line): Remove declaration.
3100         * top.c (previous_saved_command_line, previous_repeat_arguments):
3101         New variables.
3102         (saved_command_line): Make static, define together with other
3103         'repeat variables'.
3104         (dont_repeat): Clear repeat_arguments.
3105         (repeat_previous, get_saved_command_line, save_command_line):
3106         New functions.
3107         (gdb_init): Initialize saved_command_line
3108         and previous_saved_command_line.
3109         * main.c (captured_main_1): Remove saved_command_line initialization.
3110         * event-top.c (handle_line_of_input): Update to use
3111         the new 'repeat' related functions instead of direct access to
3112         saved_command_line.
3113         * command.h (repeat_previous, get_saved_command_line,
3114         save_command_line): New declarations.
3115         (dont_repeat): Add comment.
3116
3117 2019-05-30  Tom Tromey  <tromey@adacore.com>
3118
3119         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3120         Fix comment.
3121         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3122
3123 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3124
3125         PR cli/24587
3126         * completer.c (complete): Initialize variable word.
3127
3128 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3129
3130         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3131         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3132         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3133         'body' is NULL to the outter 'if', protecting the '!is_define'
3134         situation as well.
3135
3136 2019-05-29  Tom Tromey  <tromey@adacore.com>
3137
3138         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3139         (dwarf_unknown): New function.
3140         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3141         (dwarf_type_encoding_name): Use dwarf_unknown.
3142
3143 2019-05-29  Tom Tromey  <tromey@adacore.com>
3144
3145         PR c++/20020:
3146         * cp-valprint.c (cp_print_value_fields): Call
3147         cp_print_static_field inside "try".
3148
3149 2019-05-29  Tom Tromey  <tromey@adacore.com>
3150
3151         * inflow.c (struct terminal_info): Add default operator=.
3152         * configure: Rebuild.
3153         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3154         -Wdeprecated-copy-dtor, -Wredundant-move.
3155
3156 2019-05-29  Tom Tromey  <tromey@adacore.com>
3157
3158         * NEWS: Add entry.
3159         * infcmd.c (print_return_value_1): Handle finish_print
3160         option.
3161         (show_print_finish): New function.
3162         (_initialize_infcmd): Add "set/show print finish" commands.
3163         * valprint.c (user_print_options): Initialize new member.
3164         * valprint.h (struct value_print_options) <finish_print>: New
3165         member.
3166
3167 2019-05-28  Tom Tromey  <tromey@adacore.com>
3168
3169         * ada-lang.c (ada_remove_Xbn_suffix)
3170         (find_old_style_renaming_symbol)
3171         (parse_old_style_renaming): Remove.
3172         (ada_find_renaming_symbol): Don't call
3173         find_old_style_renaming_symbol.
3174         (ada_is_renaming_symbol): Rename from
3175         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3176         bool.  Now static.
3177         (ada_read_var_value): Update and simplify.
3178         * ada-exp.y (write_var_or_type): Remove old code.
3179
3180 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3181
3182         * event-top.c: Remove include comment.
3183         * inflow.c (class scoped_ignore_sigttou): Move from here...
3184         * inflow.h (class scoped_ignore_sigttou): ...to here.
3185         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3186         * top.c:  Remove include comment.
3187
3188 2019-05-27  Tom Tromey  <tom@tromey.com>
3189
3190         * NEWS: Fix typo.
3191
3192 2019-05-22  Tom Tromey  <tromey@adacore.com>
3193
3194         * target.c (target_follow_exec): Constify parameter.
3195         * target-delegates.c: Rebuild.
3196         * remote.c (remote_target::follow_exec): Constify parameter.
3197         * infrun.c (follow_exec): Constify parameter.
3198         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3199         (target_follow_exec): Likewise.
3200
3201 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3202
3203         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3204         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3205
3206 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3207
3208         * NEWS: Add debugredirect and testsuite sections.
3209
3210 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3211
3212         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3213         target descriptions using exclusively floating point register name
3214         aliases.
3215
3216 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3217
3218         PR gdb/18644:
3219         * f-lang.c (build_fortran_types): Handle the case where
3220         gdbarch_floatformat_for_type returns a nullptr.
3221
3222 2019-05-21  Tom de Vries  <tdevries@suse.de>
3223
3224         PR cli/24587
3225         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3226
3227 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3228
3229         PR gdb/18644:
3230         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3231         16-byte floats.
3232         * i386-tdep.c (i386_floatformat_for_type): Use
3233         floatformats_ia64_quad for the 16-byte floating point component
3234         within a fortran 32-byte complex number.
3235
3236 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3237
3238         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3239         delete default constructor.
3240         (find_partial_die): Update to return const struct.
3241         (partial_die_parent_scope): Move variable declaration into scope
3242         of its use and change its type to auto.
3243         (guess_partial_die_structure_name): Likewise.
3244         (partial_die_info::fixup): Likewise.
3245
3246 2019-05-17  Tom Tromey  <tromey@adacore.com>
3247
3248         * source.c (find_and_open_source): Remove cast.
3249
3250 2019-05-17  Tom Tromey  <tromey@adacore.com>
3251
3252         * annotate.c (annotate_source): Make "filename" const.
3253         * annotate.h (annotate_source): Use const.
3254
3255 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3256
3257         * disasm.c (set_disassembler_options): Send errors to stderr.
3258
3259 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3260
3261         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3262         (cli_interp_base::set_logging): Check debug_redirect.
3263         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3264         * cli/cli-logging.c (debug_redirect): Add static variable.
3265         (pop_output_files): Add default param.
3266         (handle_redirections): Print debug setting.
3267         (show_logging_command): Likewise.
3268         (_initialize_cli_logging): Add debugredirect command.
3269         * interps.c (current_interp_set_logging): Add debug_redirect
3270         parameter.
3271         * interps.h (set_logging): Add debug_redirect parameter.
3272         (current_interp_set_logging): Likewise.
3273         * mi/mi-common.h: Likewise.
3274         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3275
3276 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3277             Tom Tromey  <tromey@adacore.com>
3278
3279         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3280         directly.
3281         * cli/cli-interp.h (make_logging_output): Remove declaration.
3282         * cli/cli-logging.c (make_logging_output): Remove function.
3283         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3284         directly.
3285         * ui-file.c (tee_file::tee_file): Remove bools.
3286         (tee_file::~tee_file): Remove deletes.
3287         * ui-file.h (tee_file): Remove bools.
3288
3289 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3290
3291         * mi/mi-cmds.h (mi_cmd_complete): New function.
3292         * mi/mi-main.c (mi_cmd_complete): Likewise.
3293         * mi/mi-cmds.c: Define new MI command -complete.
3294         * NEWS: Mention new -complete command.
3295
3296 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3297
3298         * completer.h (complete): New function.
3299         * completer.c (complete): Likewise.
3300         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3301         function defined in completer.h.
3302
3303 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3304
3305         * MAINTAINERS (Write After Approval): Add myself.
3306
3307 2019-05-17  Tom de Vries  <tdevries@suse.de>
3308
3309         PR gdb/24094
3310         * dwarf2read.c (struct cu_partial_die_info): New struct.
3311         (find_partial_die): Return cu_partial_die_info.
3312         (partial_die_parent_scope, guess_partial_die_structure_name)
3313         (partial_die_info::fixup): Handle new return type of find_partial_die.
3314
3315 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3316
3317         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3318         "std::string", simplifying the algorithm.
3319
3320 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3321
3322         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3323         (stap_static_probe_ops::get_probes): Likewise.
3324
3325 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3326
3327         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3328         '-')" and "else if".
3329         (stap_parse_single_operand): Join checks for
3330         "gdbarch_stap_parse_special_token_p" and
3331         "gdbarch_stap_parse_special_token" in the same "if" statement.
3332         Invert check when verifying for operation on register
3333         displacement.
3334
3335 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3336
3337         * stap-probe.c (stap_get_opcode): Update comment.
3338         (stap_get_expected_argument_type): Likewise.
3339         (handle_stap_probe): Likewise.
3340
3341 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3342
3343         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3344         return type to 'bool'.  Adjust comment.  Use 'bool' when
3345         appropriate.
3346         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3347         * stap-probe.c (stap_parse_argument_1): Likewise.
3348         (stap_is_operator): Likewise.
3349         (stap_is_generic_prefix): Likewise.
3350         (stap_is_register_prefix): Likewise.
3351         (stap_is_register_indirection_prefix): Likewise.
3352         (stap_is_integer_prefix): Likewise.
3353         (stap_generic_check_suffix): Likewise.
3354         (stap_check_integer_suffix): Likewise.
3355         (stap_check_register_suffix): Likewise.
3356         (stap_check_register_indirection_suffix): Likewise.
3357         (stap_parse_register_operand): Likewise.
3358         (stap_parse_single_operand): Likewise.
3359         (stap_parse_argument_1): Likewise.
3360         (stap_probe::get_argument_count): Likewise.
3361         (stap_is_operator): Likewise.
3362
3363 2019-05-16  Tom Tromey  <tromey@adacore.com>
3364
3365         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3366         keyword to foreach.
3367
3368 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3369
3370         * linux-thread-db.c (try_thread_db_load_1): Change return type
3371         to bool.
3372         (try_thread_db_load): Likewise.
3373         (try_thread_db_load_from_pdir_1): Likewise.
3374         (try_thread_db_load_from_pdir): Likewise.
3375         (try_thread_db_load_from_sdir): Likewise.
3376         (try_thread_db_load_from_dir): Likewise.
3377         (thread_db_load_search): Likewise.
3378         (has_libpthread): Likewise.
3379         (thread_db_load): Likewise.
3380
3381 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3382
3383         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3384         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3385         NULL, and complain/return if that's the case.
3386
3387 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3388
3389         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3390         (advance, posn, abstract_read_memory): New functions.
3391         [struct mem_read_abstraction]: New struct.
3392         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3393
3394 2019-05-14  Tom Tromey  <tromey@adacore.com>
3395
3396         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3397         value is not lval_memory.
3398
3399 2019-05-14  Tom Tromey  <tromey@adacore.com>
3400
3401         * solib.c (info_sharedlibrary_command): Style the file name.
3402
3403 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3404
3405         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3406         (aarch64_vnv_type): Likewise.
3407         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3408         * common/tdesc.c: Likewise.
3409         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3410         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3411         * features/aarch64-fpu.xml: Add ieee half view.
3412         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3413         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3414         * gdbtypes.h (struct builtin_type): Likewise.
3415         (struct objfile_type): Likewise.
3416
3417 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3418
3419         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3420         typo.
3421         * location.h (string_to_event_location): Likewise.
3422
3423 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3424
3425         GDB 8.3 released.
3426
3427 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3428
3429         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3430         New variable declaration.
3431         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3432         New variable.
3433         (print_one_breakpoint): Use ui_out::test_flags and new global
3434         variable to compute use_fixed_output.
3435         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3436         Remove.
3437         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3438         (mi_multi_location_breakpoint_output_fixed): Remove.
3439         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3440         new variable.
3441         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3442         fix_multi_location_breakpoint_output flag if version >= 3.
3443         * ui-out.h (enum ui_out_flag)
3444         <fix_multi_location_breakpoint_output>: New enumerator.
3445
3446 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3447
3448         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3449
3450 2019-05-10  Tom Tromey  <tromey@adacore.com>
3451
3452         * ada-lang.c (catch_ada_completer): New function.
3453         (_initialize_ada_language): Use it.
3454
3455 2019-05-10  Tom Tromey  <tromey@adacore.com>
3456
3457         * thread.c (print_thread_info): Make "requested_threads" const.
3458         * gdbthread.h (print_thread_info): Make "requested_threads"
3459         const.
3460         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3461         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3462
3463 2019-05-08  Tom Tromey  <tom@tromey.com>
3464
3465         * gdbtypes.c (objfile_type_data): Change type.
3466         (objfile_type, _initialize_gdbtypes): Update.
3467
3468 2019-05-08  Tom Tromey  <tom@tromey.com>
3469
3470         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3471         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3472         (_initialize_dwarf2_frame): Update.
3473
3474 2019-05-08  Tom Tromey  <tom@tromey.com>
3475
3476         * objc-lang.c (objc_objfile_data): Change type.
3477         (find_methods): Update.
3478         (_initialize_objc_lang): Remove.
3479
3480 2019-05-08  Tom Tromey  <tom@tromey.com>
3481
3482         * stabsread.c (rs6000_builtin_type_data): Change type.
3483         (rs6000_builtin_type, _initialize_stabsread): Update.
3484
3485 2019-05-08  Tom Tromey  <tom@tromey.com>
3486
3487         * mips-tdep.c (mips_pdr_data): Remove.
3488         (_initialize_mips_tdep): Update.
3489
3490 2019-05-08  Tom Tromey  <tom@tromey.com>
3491
3492         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3493         (hppa_init_objfile_priv_data, read_unwind_info)
3494         (find_unwind_entry, _initialize_hppa_tdep): Update.
3495
3496 2019-05-08  Tom Tromey  <tom@tromey.com>
3497
3498         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3499         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3500         on obstack.
3501         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3502
3503 2019-05-08  Tom Tromey  <tom@tromey.com>
3504
3505         * mdebugread.c (basic_type_data): Change type.
3506         (basic_type, _initialize_mdebugread): Update.
3507
3508 2019-05-08  Tom Tromey  <tom@tromey.com>
3509
3510         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3511
3512 2019-05-08  Tom Tromey  <tom@tromey.com>
3513
3514         * nto-tdep.c (nto_inferior_data_reg): Change type.
3515         (nto_inferior_data): Update.
3516         (nto_inferior_data_cleanup, nto_new_inferior_data)
3517         (_initialize_nto_tdep): Remove.
3518         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3519
3520 2019-05-08  Tom Tromey  <tom@tromey.com>
3521
3522         * ada-lang.c (struct ada_inferior_data): Add initializers.
3523         (ada_inferior_data): Change type.
3524         (ada_inferior_data_cleanup): Remove.
3525         (get_ada_inferior_data, ada_inferior_exit)
3526         (struct ada_pspace_data): Add initializers, destructor.
3527         (ada_pspace_data_handle): Change type.
3528         (get_ada_pspace_data): Update.
3529         (ada_pspace_data_cleanup): Remove.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * coffread.c (struct coff_symfile_info): Add initializers.
3534         (coff_objfile_data_key): Move lower.  Change type.
3535         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3536         Update.
3537         (coff_free_info): Remove.
3538
3539 2019-05-08  Tom Tromey  <tom@tromey.com>
3540
3541         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3542         (fbsd_pspace_data_handle): Move lower.  Change type.
3543         (get_fbsd_pspace_data): Update.
3544         (fbsd_pspace_data_cleanup): Remove.
3545         (_initialize_fbsd_tdep): Update.
3546
3547 2019-05-08  Tom Tromey  <tom@tromey.com>
3548
3549         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3550         (get_ada_tasks_pspace_data): Update.
3551         (ada_tasks_pspace_data_cleanup): Remove.
3552         (_initialize_tasks): Update.
3553         (ada_tasks_inferior_data_handle): Change type.
3554         (get_ada_tasks_inferior_data): Update.
3555         (ada_tasks_inferior_data_cleanup): Remove.
3556         (struct ada_tasks_pspace_data): Add initializers.
3557
3558 2019-05-08  Tom Tromey  <tom@tromey.com>
3559
3560         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3561         * symfile-debug.c (debug_sym_get_probes): Change type.
3562         * stap-probe.c (handle_stap_probe):
3563         (stap_static_probe_ops::get_probes): Change type.
3564         * probe.h (class static_probe_ops) <get_probes>: Change type.
3565         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3566         (parse_probes_in_pspace): Update.
3567         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3568         Update.
3569         (any_static_probe_ops::get_probes): Change type.
3570         * elfread.c (elfread_data): New typedef.
3571         (probe_key): Change type.
3572         (elf_get_probes): Likewise.  Update.
3573         (probe_key_free): Remove.
3574         (_initialize_elfread): Update.
3575         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3576         Change type.
3577         (dtrace_process_dof_probe, dtrace_process_dof)
3578         (dtrace_static_probe_ops::get_probe): Change type.
3579
3580 2019-05-08  Tom Tromey  <tom@tromey.com>
3581
3582         * xcoffread.c (struct xcoff_symfile_info): Rename from
3583         coff_symfile_info.  Add initializers.
3584         (xcoff_objfile_data_key): Move lower.  Change type.
3585         (XCOFF_DATA): Rewrite.
3586         (xcoff_free_info): Remove.
3587         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3588         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3589         (xcoff_initial_scan): Update.
3590
3591 2019-05-08  Tom Tromey  <tom@tromey.com>
3592
3593         * solib-svr4.c (struct svr4_info): Add initializers and
3594         destructor.
3595         <probes_table>: Now an htab_up.
3596         (solib_svr4_pspace_data): Change type.
3597         (free_probes_table): Simplify.
3598         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3599         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3600         (probes_table_remove_objfile_probes, register_solib_event_probe)
3601         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3602         (_initialize_svr4_solib): Update.
3603
3604 2019-05-08  Tom Tromey  <tom@tromey.com>
3605
3606         * remote.c (remote_pspace_data): Change type.
3607         (remote_pspace_data_cleanup): Remove.
3608         (get_remote_exec_file, set_pspace_remote_exec_file)
3609         (_initialize_remote): Update.
3610
3611 2019-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * breakpoint.c (breakpoint_objfile_key): Change type.
3614         (get_breakpoint_objfile_data): Update.
3615         (free_breakpoint_objfile_data): Remove.
3616         (_initialize_breakpoint): Update.
3617
3618 2019-05-08  Tom Tromey  <tom@tromey.com>
3619
3620         * linux-tdep.c (struct linux_info): Add initializers.
3621         (linux_inferior_data): Move.  Change type.
3622         (invalidate_linux_cache_inf): Update.
3623         (linux_inferior_data_cleanup): Remove.
3624         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3625
3626 2019-05-08  Tom Tromey  <tom@tromey.com>
3627
3628         * auxv.c (auxv_inferior_data): Move.  Change type.
3629         (auxv_inferior_data_cleanup): Remove.
3630         (invalidate_auxv_cache_inf): Rewrite.
3631         (get_auxv_inferior_data, _initialize_auxv): Update.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3636         (symfile_debug_objfile_data_key): Change type.
3637         (symfile_debug_installed, debug_qf_has_symbols)
3638         (debug_qf_find_last_source_symtab)
3639         (debug_qf_forget_cached_source_info)
3640         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3641         (debug_qf_print_stats, debug_qf_dump)
3642         (debug_qf_expand_symtabs_for_function)
3643         (debug_qf_expand_all_symtabs)
3644         (debug_qf_expand_symtabs_with_fullname)
3645         (debug_qf_map_matching_symbols)
3646         (debug_qf_expand_symtabs_matching)
3647         (debug_qf_find_pc_sect_compunit_symtab)
3648         (debug_qf_map_symbol_filenames)
3649         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3650         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3651         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3652         (debug_sym_read_linetable, debug_sym_relocate): Update.
3653         (symfile_debug_free_objfile): Remove.
3654         (install_symfile_debug_logging, _initialize_symfile_debug):
3655         Update.
3656
3657 2019-05-08  Tom Tromey  <tom@tromey.com>
3658
3659         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3660         allocate_on_obstack.
3661         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3662         (get_dwarf2_per_objfile): Update.
3663         (set_dwarf2_per_objfile): Remove.
3664         (dwarf2_has_info, dwarf2_get_section_info): Update.
3665         (dwarf2_free_objfile): Remove.
3666         (_initialize_dwarf2_read): Update.
3667
3668 2019-05-08  Tom Tromey  <tom@tromey.com>
3669
3670         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3671         initializers.
3672         <unsupported_script_warning_printed,
3673         script_not_found_warning_printed>: Now bool.
3674         (auto_load_pspace_data): Change type.
3675         (~auto_load_pspace_info): Rename from
3676         auto_load_pspace_data_cleanup.
3677         (get_auto_load_pspace_data, init_loaded_scripts_info)
3678         (clear_section_scripts, maybe_print_unsupported_script_warning)
3679         (maybe_print_script_not_found_warning, _initialize_auto_load):
3680         Update.
3681
3682 2019-05-08  Tom Tromey  <tom@tromey.com>
3683
3684         * objfiles.c (objfile_pspace_info): Add destructor and
3685         initializers.
3686         (objfiles_pspace_data): Change type.
3687         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3688         (get_objfile_pspace_data): Update.
3689         (objfiles_bfd_data): Change type.
3690         (get_objfile_bfd_data): Update.
3691         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3692
3693 2019-05-08  Tom Tromey  <tom@tromey.com>
3694
3695         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3696         Change type.
3697         (get_catch_syscall_inferior_data): Update.
3698         (catch_syscall_inferior_data_cleanup): Remove.
3699         (_initialize_break_catch_syscall): Update.
3700
3701 2019-05-08  Tom Tromey  <tom@tromey.com>
3702
3703         * inflow.c (struct terminal_info): Add destructor and
3704         initializers.
3705         (inflow_inferior_data): Change type.
3706         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3707         (get_inflow_inferior_data, inflow_inferior_exit)
3708         (swap_terminal_info, _initialize_inflow): Update.
3709
3710 2019-05-08  Tom Tromey  <tom@tromey.com>
3711
3712         * target-dcache.c (target_dcache_cleanup): Remove.
3713         (target_dcache_aspace_key): Change type.
3714         (target_dcache_init_p, target_dcache_invalidate)
3715         (target_dcache_get, target_dcache_get_or_init)
3716         (_initialize_target_dcache): Update.
3717         * dcache.h (struct dcache_deleter): New.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * symtab.c (struct symbol_cache): Add destructor and
3722         initializers.
3723         (symbol_cache_key): Move.  Change type.
3724         (make_symbol_cache, free_symbol_cache): Remove.
3725         (get_symbol_cache): Update.
3726         (symbol_cache_cleanup): Remove.
3727         (ALL_PSPACES, symbol_cache_flush)
3728         (maintenance_print_symbol_cache)
3729         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3730         Update.
3731
3732 2019-05-08  Tom Tromey  <tom@tromey.com>
3733
3734         * symtab.c (struct main_info): Add destructor and initializers.
3735         (main_progspace_key): Move.  Change type.
3736         (get_main_info): Update.
3737         (main_info_cleanup): Remove.
3738         (_initialize_symtab): Update.
3739
3740 2019-05-08  Tom Tromey  <tom@tromey.com>
3741
3742         * registry.h (DECLARE_REGISTRY): Define the _key class.
3743
3744 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * NEWS: Merge two 'New commands' sections.
3747
3748 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3749
3750         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3751         parameter and use Ada language definition instead.
3752         (ada_val_print_ptr): Remove unused language parameter.
3753         (ada_val_print_num): Remove language parameter and use Ada language
3754         definition instead.
3755         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3756         parameter.
3757         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3758         parameter and use Ada language definition instead.
3759         (ada_val_print_1): Update all ada_val_print_xxx calls.
3760         Remove language parameter.
3761         (ada_val_print): Update ada_val_print_1 call.
3762
3763 2019-05-08  Tom Tromey  <tromey@adacore.com>
3764
3765         * remote.c (remote_hw_watchpoint_limit)
3766         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3767         Now static.
3768
3769 2019-05-08  Tom Tromey  <tromey@adacore.com>
3770
3771         * maint.c (_initialize_maint_cmds): Move initialization code to
3772         remote.c.
3773         (watchdog, show_watchdog): Move to remote.c.
3774         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3775         "watchdog" static.
3776         (_initialize_remote): Move initialization code from maint.c.
3777         * defs.h (watchdog): Don't declare.
3778
3779 2019-05-08  Tom Tromey  <tromey@adacore.com>
3780
3781         * tui/tui-interp.c: Include main.h.
3782         * interps.c: Include main.h.
3783         * main.h (interpreter_p): Declare.
3784         * defs.h (interpreter_p): Don't declare.
3785
3786 2019-05-08  Tom Tromey  <tromey@adacore.com>
3787
3788         * dwarf2loc.c: Include dwarf2read.h.
3789         * defs.h (read_unsigned_leb128): Don't declare.
3790         * dwarf2read.h (read_unsigned_leb128): Declare.
3791
3792 2019-05-08  Tom Tromey  <tromey@adacore.com>
3793
3794         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3795         method.
3796
3797 2019-05-08  Tom Tromey  <tromey@adacore.com>
3798
3799         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3800         when no wrap column is set.
3801
3802 2019-05-08  Tom Tromey  <tromey@adacore.com>
3803
3804         * c-lang.c (c_get_string): Handle non-C-style arrays.
3805
3806 2019-05-08  Tom Tromey  <tromey@adacore.com>
3807
3808         * typeprint.c (print_offset_data::update): Print the bit offset,
3809         not the number of bits remaining.
3810
3811 2019-05-08  Tom Tromey  <tromey@adacore.com>
3812
3813         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3814         padding at end of comment.
3815
3816 2019-05-08  Tom Tromey  <tromey@adacore.com>
3817
3818         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3819         Compare main types.
3820
3821 2019-05-06  Tom Tromey  <tom@tromey.com>
3822
3823         * common/scoped_mmap.c: Include common-defs.h.
3824         * common/scoped_mmap.h: Don't include config.h.
3825
3826 2019-05-04  Tom Tromey  <tom@tromey.com>
3827
3828         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3829         (struct aarch64_call_info): Add initializers.
3830         <si>: Now a std::vector.
3831         (pass_on_stack, aarch64_push_dummy_call): Update.
3832
3833 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3834             Tom Tromey  <tom@tromey.com>
3835
3836         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3837         (ppc_threads): Now a std::vector.  Now static.
3838         (hwdebug_find_thread_points_by_tid)
3839         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3840         Update.
3841
3842 2019-05-04  Tom Tromey  <tom@tromey.com>
3843
3844         * arc-tdep.c (arc_tdesc_init): Return bool.
3845
3846 2019-05-04  Tom Tromey  <tom@tromey.com>
3847
3848         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3849         Use gdb_assert_not_reached.
3850
3851 2019-05-04  Tom Tromey  <tom@tromey.com>
3852
3853         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3854         "false".
3855
3856 2019-05-04  Tom Tromey  <tom@tromey.com>
3857
3858         * arc-tdep.c (arc_tdesc_init): Use bool.
3859
3860 2019-05-04  Tom Tromey  <tom@tromey.com>
3861
3862         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3863
3864 2019-05-04  Tom Tromey  <tom@tromey.com>
3865
3866         * cli/cli-cmds.c (valid_command_p): Return bool.
3867
3868 2019-05-04  Tom Tromey  <tom@tromey.com>
3869
3870         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3871         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3872
3873 2019-05-04  Raul Tambre  <raul@tambre.ee>
3874
3875         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3876         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3877         operator for comparison.
3878
3879 2019-05-04  Tom Tromey  <tom@tromey.com>
3880
3881         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3882         (lookup_partial_symbol, print_partial_symbols)
3883         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3884         (psymbol_compare): Update.
3885         (add_psymbol_to_bcache): Clear the entire psymbol.
3886         (maintenance_check_psymtabs): Update.
3887         * psympriv.h (struct partial_symbol): Don't derive from
3888         general_symbol_info.
3889         <obj_section, unrelocated_address, address,
3890         set_unrelocated_address>: Update.
3891         <ginfo>: New member.
3892         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3893         (debug_names::write_psymbols): Update.
3894
3895 2019-05-04  Tom de Vries  <tdevries@suse.de>
3896
3897         * contrib/cc-with-tweaks.sh: Support -n arg.
3898
3899 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3900
3901         * corelow.c (core_target::detach): Ensure frame cache and
3902         register caches are cleared.
3903         inferior.c (exit_inferior_1): Likewise.
3904
3905 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3906             Tom Tromey  <tom@tromey.com>
3907
3908         * dictionary.c (collate_pending_symbols_by_language): Remove
3909         "struct" from foreach.
3910         * symtab.c (lookup_global_symbol_from_objfile)
3911         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3912         foreach.
3913         * ser-tcp.c (net_open): Remove "struct" from foreach.
3914         * objfiles.c (objfile_relocate, objfile_rebase)
3915         (objfile_has_symbols): Remove "struct" from foreach.
3916         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3917         from foreach.
3918         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3919         foreach.
3920         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3921         "struct" from foreach.
3922         * ada-lang.c (create_excep_cond_exprs)
3923         (ada_exception_catchpoint_cond_string): Remove "struct" from
3924         foreach.
3925
3926 2019-05-03  Tom Tromey  <tromey@adacore.com>
3927
3928         * ada-exp.y (convert_char_literal): Check suffix of each
3929         enumerator.
3930
3931 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3932
3933         PR ada/21406:
3934         * ada-exp.y (yywrap): Don't define.
3935         * ada-lex.l (%option): Add noyywrap
3936         (yywrap): Remove.
3937
3938 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3939
3940         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3941         _WIN32_WINNT to the XP level, unless already defined to a higher
3942         level.
3943
3944         * unittests/parse-connection-spec-selftests.c:
3945         * ser-tcp.c:
3946         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3947         override.
3948
3949         * symfile.c (find_separate_debug_file): Remove colon from the
3950         drive spec of DOS/Windows file names of the target, so that the
3951         file name produced from DEBUGDIR and the target's directory will
3952         be valid on DOS/Windows systems.
3953
3954 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3955
3956         * rust-lang.c (val_print_struct): Handle printing structures
3957         containing strings.
3958
3959 2019-05-02  Tom Tromey  <tromey@adacore.com>
3960
3961         * valarith.c (_initialize_valarith): Remove.
3962
3963 2019-05-01  Tom Tromey  <tromey@adacore.com>
3964
3965         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3966         bitfields.
3967
3968 2019-05-01  Tom Tromey  <tromey@adacore.com>
3969
3970         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3971         for big-endian copies.
3972
3973 2019-04-30  Ali Tamur  <tamur@google.com>
3974         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3975         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3976         (read_3_bytes): New function.
3977
3978 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3979
3980         * windows-nat.c (main_thread_id): Delete.
3981         (handle_output_debug_string): Replace main_thread_id by
3982         current_event.dwThreadId.
3983         (fake_create_process): Likewise.
3984         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3985         Do not set main_thread_id.
3986         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3987         current_event.dwThreadId.
3988         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3989
3990 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3991
3992         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3993         Use current_event.dwThreadId instead of main_thread_id.
3994
3995 2019-04-30  Tom Tromey  <tromey@adacore.com>
3996
3997         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3998         (create_excep_cond_exprs): Iterate over program spaces.
3999         (ada_exception_catchpoint_cond_string): Examine all minimal
4000         symbols for exception types.
4001
4002 2019-04-30  Tom Tromey  <tromey@adacore.com>
4003
4004         PR c++/24470:
4005         * dwarf2read.c (process_structure_scope): Handle case where type
4006         has template parameters but no symbol was created.
4007
4008 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4009             Chris January  <chris.january@arm.com>
4010
4011         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4012         qualifier.
4013         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4014
4015 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * f-typeprint.c (f_print_type): Update rules for printing
4018         whitespace.
4019         (f_type_print_varspec_suffix): Likewise.
4020
4021 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4022             Chris January  <chris.january@arm.com>
4023
4024         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4025         function arguments.
4026
4027 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * f-lang.c (build_fortran_types): Change name of void type to
4030         lower case.
4031         * f-typeprint.c (f_type_print_base): Print the name of the void
4032         type, rather than a fixed string.
4033         * f-valprint.c (f_decorations): Use lower case void string.
4034
4035 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4036             Chris January  <chris.january@arm.com>
4037
4038         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4039         types for Fortran.
4040
4041 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4042             Chris January  <chris.january@arm.com>
4043             David Lecomber  <david.lecomber@arm.com>
4044
4045         * f-exp.y (BINOP_INTRINSIC): New token.
4046         (exp): New parser rule handling BINOP_INTRINSIC.
4047         (f77_keywords): Add new builtin procedures.
4048         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4049         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4050         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4051         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4052         (print_unop_subexp_f): New function.
4053         (print_binop_subexp_f): New function.
4054         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4055         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4056         (dump_subexp_body_f): Likewise.
4057         (operator_check_f): Likewise.
4058         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4059         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4060
4061 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4064         UNOP_KIND.
4065         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4066         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4067         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4068         (operator_length_f): New fuction.
4069         (print_subexp_f): New function.
4070         (op_name_f): New function.
4071         (dump_subexp_body_f): New function.
4072         (operator_check_f): New function.
4073         (exp_descriptor_f): Replace standard expression handling functions
4074         with new functions.
4075         * gdb/fortran-operator.def: New file.
4076         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4077         * gdb/std-operator.def: Remove UNOP_KIND.
4078
4079 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4080
4081         * std-operator.def: Remove unbalanced, stray double quote
4082         character.
4083
4084 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4085             Chris January  <chris.january@arm.com>
4086             Daniel Everett  <daniel.everett@arm.com>
4087             Nick Forrington  <nick.forrington@arm.com>
4088             Richard Bunt  <richard.bunt@arm.com>
4089
4090         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4091         of depth when printing anonymous structs or unions.
4092         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4093         Don't print either the top-level value, or the children if the
4094         max-depth is exceeded.
4095         (ppscm_print_children): When printing the key of a map, allow one
4096         extra level of depth.
4097         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4098         print either the top-level value, or the children if the max-depth
4099         is exceeded.
4100         (print_children): When printing the key of a map, allow one extra
4101         level of depth.
4102         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4103         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4104         (user_print_options): Initialise max_depth field.
4105         (val_print_scalar_or_string_type_p): New function.
4106         (val_print): Check to see if the max depth has been reached.
4107         (val_print_check_max_depth): Define new function.
4108         (show_print_max_depth): New function.
4109         (_initialize_valprint): Add 'print max-depth' option.
4110         * valprint.h (struct value_print_options) <max_depth>: New field.
4111         (val_print_check_max_depth): Declare new function.
4112         * NEWS: Document new feature.
4113
4114 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4115
4116         * ada-lang.c (ada_language_defn): Initialise new field.
4117         * c-lang.c (c_is_string_type_p): New function.
4118         (c_language_defn): Initialise new field.
4119         (cplus_language_defn): Initialise new field.
4120         (asm_language_defn): Initialise new field.
4121         (minimal_language_defn): Initialise new field.
4122         * c-lang.h (c_is_string_type_p): Declare new function.
4123         * d-lang.c (d_language_defn): Initialise new field.
4124         * f-lang.c (f_is_string_type_p): New function.
4125         (f_language_defn): Initialise new field.
4126         * go-lang.c (go_is_string_type_p): New function.
4127         (go_language_defn): Initialise new field.
4128         * language.c (default_is_string_type_p): New function.
4129         (unknown_language_defn): Initialise new field.
4130         (auto_language_defn): Initialise new field.
4131         * language.h (struct language_defn) <la_is_string_type_p>: New
4132         member variable.
4133         (default_is_string_type_p): Declare new function.
4134         * m2-lang.c (m2_language_defn): Initialise new field.
4135         * objc-lang.c (objc_language_defn): Initialise new field.
4136         * opencl-lang.c (opencl_language_defn): Initialise new field.
4137         * p-lang.c (pascal_is_string_type_p): New function.
4138         (pascal_language_defn): Initialise new field.
4139         * rust-lang.c (rust_is_string_type_p): New function.
4140         (rust_language_defn): Initialise new field.
4141
4142 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4145         New field.
4146         * ada-lang.c (ada_language_defn): Initialise new field.
4147         * c-lang.c (c_language_defn): Likewise.
4148         (cplus_language_defn): Likewise.
4149         (asm_language_defn): Likewise.
4150         (minimal_language_defn): Likewise.
4151         * d-lang.c (d_language_defn): Likewise.
4152         * f-lang.c (f_language_defn): Likewise.
4153         * go-lang.c (go_language_defn): Likewise.
4154         * language.c (unknown_language_defn): Likewise.
4155         (auto_language_defn): Likewise.
4156         * m2-lang.c (m2_language_defn): Likewise.
4157         * objc-lang.c (objc_language_defn): Likewise.
4158         * opencl-lang.c (opencl_language_defn): Likewise.
4159         * p-lang.c (pascal_language_defn): Likewise.
4160         * rust-lang.c (rust_language_defn): Likewise.
4161
4162 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * ada-lang.c (ada_is_character_type): Change return type to bool.
4165         (ada_is_string_type): Likewise.
4166         * ada-lang.h (ada_is_character_type): Update declaration
4167         (ada_is_string_type): Likewise.
4168
4169 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4170
4171         Support style in 'frame|thread apply'
4172
4173         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4174         * record.c (record_start, record_stop): Update callers of
4175         execute_command_to_string with false.
4176         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4177         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4178         methods.
4179         (class string_file): New constructor with term_out parameter.
4180         Override methods term_out and can_emit_style_escape.  New member
4181         term_out.
4182         (class stdio_file): Override can_emit_style_escape.
4183         (class tee_file): Override term_out and can_emit_style_escape.
4184         * utils.h (can_emit_style_escape): Remove.
4185         * utils.c (can_emit_style_escape): Likewise.
4186         Update all callers of can_emit_style_escape (SOMESTREAM) to
4187         SOMESTREAM->can_emit_style_escape.
4188         * source-cache.c (source_cache::get_source_lines): Likewise.
4189         * stack.c (frame_apply_command_count): Call execute_command_to_string
4190         passing the term_out characteristic of the current gdb_stdout.
4191         * thread.c (thr_try_catch_cmd): Likewise.
4192         * top.c (execute_command_to_string): pass term_out parameter
4193         to construct the string_file for the command output.
4194         * ui-file.c (term_cli_styling): New function (most code moved
4195         from utils.c can_emit_style_escape).
4196         (string_file::string_file, string_file::can_emit_style_escape,
4197         stdio_file::can_emit_style_escape, tee_file::term_out,
4198         tee_file::can_emit_style_escape): New functions.
4199
4200 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4201
4202         * NEWS: Mention the new set|show may-call-functions.
4203         * infcall.c (may_call_functions_p): New variable.
4204         (show_may_call_functions_p): New function.
4205         (call_function_by_hand_dummy): Throws an error if not
4206         may-call-functions.
4207         (_initialize_infcall): Call add_setshow_boolean_cmd for
4208         may-call-functions.
4209
4210 2019-04-25  Keith Seitz  <keiths@redhat.com>
4211
4212         PR c++/24367
4213         * cp-support.c (inspect_type): Don't attempt substitutions
4214         of symbol with the same name.
4215
4216 2019-04-25  Tom Tromey  <tromey@adacore.com>
4217
4218         PR gdb/24475:
4219         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4220         static.
4221
4222 2019-04-25  Tom Tromey  <tromey@adacore.com>
4223
4224         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4225         rvalue reference.
4226         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4227         (gdb_xml_parser::parse): Use std::move.
4228         * python/python-internal.h (gdbpy_convert_exception): Take a const
4229         reference.
4230         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4231         std::move.
4232         * python/py-utils.c (gdbpy_convert_exception): Take a const
4233         reference.
4234         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4235         Use std::move.
4236         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4237         Use std::move.
4238         * mi/mi-main.c (mi_print_exception): Take a const reference.
4239         * main.c (handle_command_errors): Take a const reference.
4240         * linespec.c (parse_linespec): Use std::move.
4241         * infcall.c (run_inferior_call): Use std::move.
4242         (call_function_by_hand_dummy): Use std::move.
4243         * exec.c (try_open_exec_file): Use std::move.
4244         * exceptions.h (exception_print, exception_fprintf)
4245         (exception_print_same): Update.
4246         * exceptions.c (print_exception, exception_print)
4247         (exception_fprintf, exception_print_same): Change parameters to
4248         const reference.
4249         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4250         * common/new-op.c: Use std::move.
4251         * common/common-exceptions.h (struct gdb_exception): Add move
4252         constructor.
4253         (struct gdb_exception_error, struct gdb_exception_quit, struct
4254         gdb_quit_bad_alloc): Change constructor to move constructor.
4255         (throw_exception): Change parameter to rvalue reference.
4256         * common/common-exceptions.c (throw_exception): Take rvalue
4257         reference.
4258         * cli/cli-interp.c (safe_execute_command): Use std::move.
4259         * breakpoint.c (insert_bp_location, location_to_sals): Use
4260         std::move.
4261
4262 2019-04-25  Tom Tromey  <tromey@adacore.com>
4263
4264         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4265         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4266         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4267         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4268         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4269         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4270         guile/scm-value.c: Use unpack.
4271         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4272         gdbscm_gdb_exception.
4273         (gdbscm_throw_gdb_exception): Likewise.
4274         (struct gdbscm_gdb_exception): New.
4275         (unpack): New function.
4276         (gdbscm_wrap): Use unpack.
4277
4278 2019-04-25  Tom Tromey  <tromey@adacore.com>
4279
4280         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4281         (gdb_rl_callback_handler): Use std::move.
4282         * common/common-exceptions.h (struct gdb_exception): Add move
4283         assignment operator.
4284         (throw_exception_sjlj): Change "exception" to const reference.
4285         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4286         (throw_exception_sjlj): Change "exception" to const reference.
4287
4288 2019-04-25  Tom Tromey  <tromey@adacore.com>
4289
4290         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4291         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4292         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4293         Update.
4294         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4295         Update.
4296         * mi/mi-interp.c (mi_interp::exec): Update.
4297         * linespec.c (parse_linespec): Update.
4298         * infcall.c (run_inferior_call): Update.
4299         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4300         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4301         (gdbscm_lookup_global_symbol): Update.
4302         * guile/scm-param.c (gdbscm_parameter_value): Update.
4303         * guile/scm-frame.c (gdbscm_frame_read_register)
4304         (gdbscm_frame_read_var): Update.
4305         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4306         * exec.c (try_open_exec_file): Update.
4307         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4308         (gdb_rl_callback_handler): Update.
4309         * common/common-exceptions.h (exception_none): Don't declare.
4310         * common/common-exceptions.c (exception_none): Don't define.
4311         (struct catcher) <exception>: Update.
4312         * cli/cli-interp.c (safe_execute_command): Update.
4313         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4314
4315 2019-04-25  Ali Tamur  <tamur@google.com>
4316
4317         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4318         (read_attribute_value): Likewise.
4319         (dwarf2_read_addr_index): Update comment.
4320         (read_str_index): Add DW_FORM_strx.
4321         (dwarf2_string_attr): Likewise.
4322         (dwarf2_const_value_attr): Likewise.
4323         (dump_die_shallow): Likewise.
4324         (dwarf2_fetch_constant_bytes): Likewise.
4325         (skip_form_bytes): Likewise.
4326         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4327
4328 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4329
4330         PR corefiles/11608
4331         PR corefiles/18187
4332         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4333         OFFSET.  Verify if current mapping contains an ELF header.
4334         (linux_find_memory_regions_full): Adjust call to
4335         dump_mapping_p.
4336
4337 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4338             Kang Li <kanglictf@gmail.com>
4339
4340         PR gdb/21600
4341
4342         * dwarf2-frame.c (read_initial_length): Be consistent about using
4343         unsigned representation of length.
4344         (decode_frame_entry_1): Likewise.  Check for wraparound of
4345         end pointer as well as buffer overflow.
4346
4347 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4348
4349         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4350         "vq".
4351
4352 2019-04-24  Tom Tromey  <tromey@adacore.com>
4353
4354         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4355
4356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * s12z-tdep.c (s12z_unwind_pc): Delete.
4359         (s12z_unwind_sp): Delete.
4360         (s12z_gdbarch_init): Don't register deleted functions with
4361         gdbarch.
4362
4363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4364
4365         * rl78-tdep.c (rl78_unwind_sp): Delete.
4366         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4367
4368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4371         (xstormy16_unwind_pc): Delete.
4372         (xstormy16_dummy_id): Delete.
4373         (xstormy16_gdbarch_init): Don't register deleted functions with
4374         gdbarch.
4375
4376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * vax-tdep.c (vax_unwind_pc): Delete.
4379         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4380
4381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * v850-tdep.c (v850_unwind_sp): Delete.
4384         (v850_unwind_pc): Delete.
4385         (v850_dummy_id): Delete.
4386         (v850_gdbarch_init): Don't register deleted functions with
4387         gdbarch.
4388
4389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4392         (tilegx_unwind_pc): Delete.
4393         (tilegx_unwind_dummy_id): Delete.
4394         (tilegx_gdbarch_init): Don't register deleted functions with
4395         gdbarch.
4396
4397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4400         (tic6x_dummy_id): Delete.
4401         (tic6x_gdbarch_init): Don't register deleted functions with
4402         gdbarch.
4403
4404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * sparc-tdep.c (sparc_unwind_pc): Delete.
4407         (sparc32_gdbarch_init): Don't register deleted function with
4408         gdbarch.
4409
4410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4411
4412         * sh-tdep.c (sh_unwind_sp): Delete.
4413         (sh_unwind_pc): Delete.
4414         (sh_dummy_id): Delete.
4415         (sh_gdbarch_init): Don't register deleted functions with
4416         gdbarch.
4417
4418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4419
4420         * score-tdep.c (score_unwind_sp): Delete.
4421         (score_unwind_pc): Delete.
4422         (score_dummy_id): Delete.
4423         (score_gdbarch_init): Don't register deleted functions with
4424         gdbarch.
4425
4426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * rx-tdep.c (rx_unwind_pc): Delete.
4429         (rx_unwind_sp): Delete.
4430         (rx_dummy_id): Delete.
4431         (rx_gdbarch_init): Don't register deleted functions with
4432         gdbarch.  Update comment.
4433
4434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4437         (rs6000_dummy_id): Delete.
4438         (rs6000_gdbarch_init): Don't register deleted functions with
4439         gdbarch.
4440
4441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * or1k-tdep.c (or1k_dummy_id): Delete.
4444         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4445
4446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * nios2-tdep.c (nios2_dummy_id): Delete.
4449         (nios2_unwind_sp): Delete.
4450         (nios2_gdbarch_init): Don't register deleted functions with
4451         gdbarch.
4452
4453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * nds32-tdep.c (nds32_dummy_id): Delete.
4456         (nds32_unwind_pc): Delete.
4457         (nds32_unwind_sp): Delete.
4458         (nds32_gdbarch_init): Don't register deleted functions with
4459         gdbarch.
4460
4461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * msp430-tdep.c (msp430_unwind_pc): Delete.
4464         (msp430_unwind_sp): Delete.
4465         (msp430_dummy_id): Delete.
4466         (msp430_gdbarch_init): Don't register deleted functions with
4467         gdbarch.
4468
4469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * moxie-tdep.c (moxie_unwind_sp): Delete.
4472         (moxie_unwind_pc): Delete.
4473         (moxie_dummy_id): Delete.
4474         (moxie_gdbarch_init): Don't register deleted functions with
4475         gdbarch.
4476
4477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4480         (mn10300_unwind_pc): Delete.
4481         (mn10300_unwind_sp): Delete.
4482         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4483         mn10300_unwind_sp.
4484         (mn10300_frame_unwind_init): Don't register deleted functions with
4485         gdbarch.
4486
4487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * mep-tdep.c (mep_unwind_pc): Delete.
4490         (mep_unwind_sp): Delete.
4491         (mep_dummy_id): Delete.
4492         (mep_gdbarch_init): Don't register deleted functions with
4493         gdbarch.
4494
4495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4498         (m68hc11_unwind_sp): Delete.
4499         (m68hc11_gdbarch_init): Don't register deleted functions with
4500         gdbarch.
4501
4502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * m32r-tdep.c (m32r_unwind_sp): Delete.
4505         (m32r_unwind_pc): Delete.
4506         (m32r_dummy_id): Delete.
4507         (m32r_gdbarch_init): Don't register deleted functions with
4508         gdbarch.
4509
4510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * m32c-tdep.c (m32c_unwind_pc): Delete.
4513         (m32c_unwind_sp): Delete.
4514         (m32c_dummy_id): Delete.
4515         (m32c_gdbarch_init): Don't register deleted functions with
4516         gdbarch.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4521         (lm32_unwind_pc): Delete.
4522         (lm32_dummy_id): Delete.
4523         (lm32_gdbarch_init): Don't register deleted functions with
4524         gdbarch.
4525
4526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4529         (iq2000_unwind_pc): Delete.
4530         (iq2000_dummy_id): Delete.
4531         (iq2000_gdbarch_init): Don't register deleted functions with
4532         gdbarch.
4533
4534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * nds32-tdep.c (nds32_type_align): Delete.
4537         (nds32_push_dummy_call): Use type_align instead.
4538
4539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * arm-tdep.c (arm_type_align): Only handle vector override case.
4542         (arm_push_dummy_call): Use type_align.
4543         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4544
4545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4548         case.
4549         (pass_on_stack): Use type_align.
4550         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4551         function.
4552
4553 2019-04-23  Tom Tromey  <tromey@adacore.com>
4554
4555         * dwarf2read.c (line_header::file_name_at): Remove unused
4556         overload.
4557
4558 2019-04-23  Tom de Vries  <tdevries@suse.de>
4559
4560         PR gdb/24438
4561         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4562         invocation.
4563
4564
4565 2019-03-27  Ali Tamur  <tamur@google.com>
4566
4567         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4568         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4569         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4570         (dwarf_expr_context::get_addr_index): Likewise
4571         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4572         (symbol_needs_eval_context::get_addr_index): Likewise
4573         (disassemble_dwarf_expression): Add DW_OP_addrx
4574         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4575         (read_cutu_die_from_dwo): Update comment
4576         (skip_one_die): Add DW_FORM_addrx
4577         (read_attribute_value): Likewise
4578         (var_decode_location): Add DW_OP_addrx
4579         (dwarf2_const_value_attr): Add DW_FORM_addrx
4580         (dump_die_shallow): Likewise
4581         (dwarf2_fetch_constant_bytes): Likewise
4582         (decode_locdesc): Add DW_OP_addrx
4583         (skip_form_bytes): Add DW_FORM_addrx
4584
4585 2019-04-22  Ali Tamur  <tamur@google.com>
4586
4587         * MAINTAINERS (Write After Approval): Add self.
4588
4589 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4590
4591         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4592         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4593         (open_symbol_file_object): Likewise.
4594         (svr4_default_sos): Add info parameter.
4595         (svr4_read_so_list): Likewise.
4596         (svr4_current_sos_direct): Adjust functions calls to pass down
4597         info.
4598         (svr4_current_sos_1): Add info parameter.
4599         (svr4_current_sos): Call get_svr4_info, pass info down to
4600         svr4_current_sos_1.
4601         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4602         get_svr4_info.
4603         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4604         get_svr4_info.
4605         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4606         to get_svr4_info.
4607         (probes_table_remove_objfile_probes): Likewise.
4608         (register_solib_event_probe): Add info parameter.
4609         (solist_update_incremental): Pass info parameter down to
4610         svr4_read_so_list.
4611         (disable_probes_interface): Add info parameter.
4612         (svr4_handle_solib_event): Pass current_program_space to
4613         get_svr4_info.  Adjust disable_probes_interface cleanup.
4614         (svr4_create_probe_breakpoints): Add info parameter, pass it
4615         down to register_solib_event_probe.
4616         (svr4_create_solib_event_breakpoints): Add info parameter,
4617         pass it down to svr4_create_probe_breakpoints.
4618         (enable_break): Pass info down to
4619         svr4_create_solib_event_breakpoints.
4620         (svr4_solib_create_inferior_hook): Pass current_program_space to
4621         get_svr4_info.
4622         (svr4_clear_solib): Likewise.
4623
4624 2019-04-22  Pedro Alves  <palves@redhat.com>
4625
4626         * solib-svr4.c (svr4_free_objfile_observer): New.
4627         (probe_and_action::objfile): New field.
4628         (probes_table_htab_remove_objfile_probes)
4629         (probes_table_remove_objfile_probes): New functions.
4630         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4631         in the new probe_and_action.  Don't store the probe in 'lookup'.
4632         (svr4_create_probe_breakpoints): Pass objfile to
4633         register_solib_event_probe.
4634         (_initialize_svr4_solib): Register a free_objfile observer.
4635
4636 2019-04-19  Tom Tromey  <tom@tromey.com>
4637
4638         * common/queue.h: Remove.
4639
4640 2019-04-19  Tom Tromey  <tom@tromey.com>
4641
4642         * event-loop.c: Don't include "common/queue.h".
4643
4644 2019-04-19  Tom Tromey  <tom@tromey.com>
4645
4646         * remote.c (remote_target): Use delete.
4647         * remote-notif.h: Include <list>, not "common/queue.h".
4648         (notif_client_p): Remove typedef.
4649         (remote_notif_state): Add constructor, destructor, initializer.
4650         <notif_queue>: Now a std::list.
4651         (remote_notif_state_xfree): Don't declare.
4652         * remote-notif.c (remote_notif_process, handle_notification)
4653         (remote_notif_state_allocate): Update.
4654         (~remote_notif_state): Rename from remote_notif_state_xfree.
4655
4656 2019-04-19  Tom Tromey  <tom@tromey.com>
4657
4658         * symfile.c (reread_symbols): Update.
4659         * objfiles.c (objfile_register_static_link)
4660         (objfile_lookup_static_link): Update
4661         (~objfile) Don't delete static_links.
4662         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4663
4664 2019-04-19  Tom Tromey  <tom@tromey.com>
4665
4666         * type-stack.h (struct type_stack) <insert>: Constify string.
4667         * type-stack.c (type_stack::insert): Constify string.
4668         * gdbtypes.h (lookup_template_type): Update.
4669         (address_space_name_to_int): Update.
4670         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4671         const.
4672         (lookup_template_type): Make name const.
4673         * c-exp.y: Update rules.
4674         (lex_one_token, classify_name, classify_inner_name)
4675         (c_print_token): Update.
4676         * p-exp.y: Update rules.
4677         (yylex): Update.
4678         * f-exp.y: Update rules.
4679         (yylex): Update.
4680         * d-exp.y: Update rules.
4681         (lex_one_token, classify_name, classify_inner_name): Update.
4682         * parse.c (write_dollar_variable, copy_name): Return std::string.
4683         * parser-defs.h (copy_name): Change return type.
4684         * m2-exp.y: Update rules.
4685         (yylex): Update.
4686         * go-exp.y (lex_one_token): Update.
4687         Update rules.
4688         (classify_unsafe_function, classify_packaged_name)
4689         (classify_name, yylex): Update.
4690
4691 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4692
4693         * configure.ac: add --enable-source-highlight switch.
4694         * configure: Regenerate.
4695         * top.c (print_gdb_version): plumb --enable-source-highlight
4696         status to "show configuration".
4697
4698 2019-04-19  Tom Tromey  <tromey@adacore.com>
4699
4700         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4701         Check ADA_TYPE_P.
4702         (empty_record, ada_template_to_fixed_record_type_1)
4703         (template_to_static_fixed_type)
4704         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4705         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4706         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4707         macros.
4708
4709 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4710
4711         PR symtab/24423:
4712         * source.c (print_source_lines_base): Advance "iter" when a
4713         control character is seen.
4714
4715 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4716
4717         * inferior.h (struct infcall_suspend_state_deleter):
4718         Catch exception in destructor to avoid crash.
4719
4720 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4721
4722         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4723         close to the add_com "shell".
4724
4725 2019-04-18  Tom Tromey  <tromey@adacore.com>
4726
4727         * process-stratum-target.h (class process_stratum_target)
4728         <stratum>: Add "final".
4729
4730 2019-04-17  Tom Tromey  <tromey@adacore.com>
4731
4732         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4733         against nullptr before use.
4734
4735 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4736
4737         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4738
4739 2019-04-17  Jim Wilson  <jimw@sifive.com>
4740             Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4743         code read might fail, assume 4-byte breakpoint in that case.
4744
4745 2019-04-15  Leszek Swirski  <leszeks@google.com>
4746
4747         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4748         rather than a hand-rolled POD check when checking for forced MEMORY
4749         classification.
4750
4751 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4752
4753         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4754         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4755         function.
4756         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4757         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4758         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4759         declaration.
4760
4761 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4762
4763         * aarch64-linux-nat.c
4764         (aarch64_linux_nat_target::thread_architecture): Add override.
4765         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4766         each VQ.
4767
4768 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4769
4770         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4771
4772 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4775         target types of size 96-bits, add some additional comments, and
4776         check that the builtin type we found was the correct size.
4777
4778 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4779
4780         * utils.c (prompt_for_continue): Don't restore the styling at the
4781         end, as applied_style has the wrong value.  This fixes styling in
4782         long lists of file names that are interrupted by the "Continue?"
4783         prompt.
4784
4785 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4788         * c-lang.c (c_language_defn): Likewise.
4789         (cplus_language_defn): Likewise.
4790         (asm_language_defn): Likewise.
4791         (minimal_language_defn): Likewise.
4792         * d-lang.c (d_language_defn): Likewise.
4793         * f-lang.c (f_language_defn): Likewise.
4794         * go-lang.c (go_language_defn): Likewise.
4795         * language.c (unknown_language_defn): Likewise.
4796         (auto_language_defn): Likewise.
4797         * language.h (struct language_defn): Remove la_magic field.
4798         (LANG_MAGIC): Delete.
4799         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4800         * objc-lang.c (objc_language_defn): Likewise.
4801         * opencl-lang.c (opencl_language_defn): Likewise.
4802         * p-lang.c (pascal_language_defn): Likewise.
4803         * rust-lang.c (rust_language_defn): Likewise.
4804
4805 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * riscv-tdep.c (riscv_type_align): New function.
4808         (riscv_type_alignment): Delete.
4809         (riscv_arg_location): Use 'type_align'.
4810         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4811
4812 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4813
4814         * gdbtypes.c (type_align): A struct with no non-static fields also
4815         has alignment of 1.
4816
4817 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4820         component to 0.
4821         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4822         member.
4823         (riscv_struct_info::analyse): New implementation using new
4824         analyse_inner member function.
4825         (riscv_struct_info::field_offset): New member function.
4826         (riscv_struct_info::m_offsets): New member variable.
4827         (riscv_struct_info::analyse_inner): New private member function,
4828         takes the old implementation of riscv_struct_info::analyse but
4829         extended to track field offsets.
4830         (riscv_call_arg_struct): Update the struct folding special cases
4831         to handle cases where empty C++ structs, which are non-zero
4832         length, are found.
4833         (riscv_arg_location): Initialise the length of each location, a
4834         non-zero length now indicates the location is in use.
4835         (riscv_push_dummy_call): Allow for the first location having a
4836         non-zero offset when setting up arguments.
4837         (riscv_return_value): Likewise, but for return values.
4838
4839 2019-04-11  Tom Tromey  <tromey@adacore.com>
4840
4841         * utils.c (internal_vproblem): Make "msg" const.
4842
4843 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4844
4845         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4846         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4847         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4848         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4849
4850 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4851
4852         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4853         function.
4854         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4855         of amd64_collect_native_gregset.
4856         (amd64_linux_nat_target::store_registers): Likewise.
4857
4858 2019-04-10  Tom Tromey  <tom@tromey.com>
4859
4860         * symtab.c (lookup_global_symbol_from_objfile)
4861         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4862         * objfiles.h (class separate_debug_iterator): New.
4863         (class separate_debug_range): New.
4864         (struct objfile) <separate_debug_objfiles>: New method.
4865         (objfile_separate_debug_iterate): Don't declare.
4866         * objfiles.c (separate_debug_iterator::operator++): Rename from
4867         objfile_separate_debug_iterate.
4868         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4869         iterator.
4870         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4871         iterator.
4872
4873 2019-04-10  Tom Tromey  <tom@tromey.com>
4874
4875         * symfile.c (reread_symbols): Remove old comment.
4876         * objfiles.c (free_all_objfiles): Fix a typo.
4877
4878 2019-04-10  Tom Tromey  <tom@tromey.com>
4879
4880         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4881         * minsyms.c (lookup_minimal_symbol): Use foreach.
4882         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4883         (lookup_minimal_symbol_solib_trampoline): Likewise.
4884         * symfile.c (reread_symbols): Use foreach.
4885
4886 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4887             Tom Tromey  <tromey@adacore.com>
4888
4889         PR rust/24414:
4890         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4891         (rust_lex_int_test): Change "value" to be LONGEST.
4892         (rust_lex_tests): Add test for long integer literal.
4893
4894 2019-04-09  Tom Tromey  <tromey@adacore.com>
4895
4896         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4897         to bool.
4898         (extended_remote_target::attach): Update.
4899         (remote_target::remote_notice_new_inferior): Update.
4900         (remote_target::add_current_inferior_and_thread): Update.
4901         * inferior.c (exit_inferior_1): Use "false".
4902         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4903
4904 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4905
4906         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4907         the "start" command.
4908
4909 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4910
4911         * python/py-inferior.c (infpy_thread_from_thread_handle):
4912         Adjust comments to reflect renaming of thread_from_thread_handle
4913         to thread_from_handle.  Adjust keywords.  Fix type error message.
4914         (inferior_object_methods): Add thread_from_handle.  Retain
4915         thread_from_thread_handle, but mark it as deprecated.
4916
4917 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4918
4919         * gdbthread.h (find_thread_by_handle): Revise declaration.
4920         * thread.c (find_thread_by_handle): Likewise.  Adjust
4921         implementation too.
4922         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4923         support for buffer objects as handles.
4924
4925 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4926
4927         * python/py-infthread.c (thpy_thread_handle): New function.
4928         (thread_object_methods): Register thpy_thread_handle.
4929
4930 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4931
4932         * gdbthread.h (thread_to_thread_handle): Declare.
4933         * thread.c (gdbtypes.h): Include.
4934         (thread_to_thread_handle): New function.
4935
4936         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4937         (target_thread_info_to_thread_handle): Declare.
4938         * target.c (target_thread_info_to_thread_handle): New function.
4939         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4940         * target-delegates.c: Regenerate.
4941
4942         * linux-thread-db.c (class thread_db_target): Add method
4943         thread_info_to_thread_handle.
4944         (thread_db_target::thread_info_to_thread_handle): Define.
4945         * remote.c (class remote_target): Add new method
4946         thread_info_to_thread_handle.
4947         (remote_target::thread_info_to_thread_handle): Define.
4948
4949 2019-04-08  Pedro Alves  <palves@redhat.com>
4950
4951         * common/common-exceptions.c (throw_exception): Don't create
4952         named object to throw; throw directly.
4953         (throw_it): Likewise.  Don't initialize gdb_exception::message
4954         here, with new; pass FMT and AP to the ctor instead.
4955         * common/common-exceptions.h: Include <string>.
4956         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4957         const char *, va_list)): New ctor.  Use std::make_shared.
4958         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4959         errors)): Delete.
4960         (gdb_exception_error::gdb_exception_error(enum errors, const char
4961         *, va_list)): New.
4962         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4963         Add assertion.
4964         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4965         errors)): Delete.
4966         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4967         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4968         Add assertion.
4969
4970 2019-04-08  Tom Tromey  <tom@tromey.com>
4971
4972         * valops.c (value_rtti_indirect_type): Replace throw_exception
4973         with throw.
4974         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4975         with throw.
4976         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4977         throw.
4978         * target.c (target_translate_tls_address): Replace throw_exception
4979         with throw.
4980         * stack.c (frame_apply_command_count): Replace throw_exception
4981         with throw.
4982         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4983         throw.
4984         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4985         with throw.
4986         * rs6000-tdep.c (rs6000_frame_cache)
4987         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4988         * remote.c: Replace throw_exception with throw.
4989         * record-full.c (record_full_message, record_full_wait_1)
4990         (record_full_restore): Replace throw_exception with throw.
4991         * record-btrace.c:
4992         (get_thread_current_frame_id, record_btrace_start_replaying)
4993         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4994         (cmd_record_btrace_start): Replace throw_exception with throw.
4995         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4996         throw.
4997         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4998         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4999         * linespec.c:
5000         (find_linespec_symbols): Replace throw_exception with throw.
5001         * infrun.c (displaced_step_prepare, resume): Replace
5002         throw_exception with throw.
5003         * infcmd.c (post_create_inferior): Replace throw_exception with
5004         throw.
5005         * inf-loop.c (inferior_event_handler): Replace throw_exception
5006         with throw.
5007         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5008         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5009         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5010         (get_prev_frame_always, get_frame_pc_if_available)
5011         (get_frame_address_in_block_if_available, get_frame_language):
5012         Replace throw_exception with throw.
5013         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5014         throw_exception with throw.
5015         * eval.c (fetch_subexp_value, evaluate_var_value)
5016         (evaluate_funcall, evaluate_subexp_standard): Replace
5017         throw_exception with throw.
5018         * dwarf2loc.c (call_site_find_chain)
5019         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5020         Replace throw_exception with throw.
5021         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5022         with throw.
5023         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5024         throw.
5025         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5026         * completer.c (complete_line_internal): Replace throw_exception
5027         with throw.
5028         * compile/compile-object-run.c (compile_object_run): Replace
5029         throw_exception with throw.
5030         * cli/cli-script.c (process_next_line): Replace throw_exception
5031         with throw.
5032         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5033         (btrace_enable, btrace_maint_update_pt_packets): Replace
5034         throw_exception with throw.
5035         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5036         throw_exception with throw.
5037         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5038         throw_exception with throw.
5039         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5040         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5041         * aarch64-tdep.c (aarch64_make_prologue_cache)
5042         (aarch64_make_stub_cache): Replace throw_exception with throw.
5043
5044 2019-04-08  Tom Tromey  <tom@tromey.com>
5045
5046         * common/common-exceptions.c (throw_exception): Rename from
5047         throw_exception_cxx.  Remove old copy.  Make argument const.
5048         (throw_it): Create and throw exception objects directly.
5049         * common/common-exceptions.h (throw_exception): Make argument
5050         const.
5051         (struct gdb_exception_error): Add constructor.
5052         (struct gdb_exception_quit): Add constructor.
5053
5054 2019-04-08  Tom Tromey  <tom@tromey.com>
5055
5056         * common/common-exceptions.h (exception_rethrow): Don't declare.
5057         (TRY_SJLJ): Update comment.
5058         (TRY, CATCH, END_CATCH): Remove.
5059         * common/common-exceptions.c (exception_rethrow): Remove.
5060
5061 2019-04-08  Tom Tromey  <tom@tromey.com>
5062
5063         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5064         Remove.
5065         (gdb_exception_error): Rename from
5066         gdb_exception_RETURN_MASK_ERROR.
5067         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5068         (gdb_quit_bad_alloc): Update.
5069         * aarch64-tdep.c: Update.
5070         * ada-lang.c: Update.
5071         * ada-typeprint.c: Update.
5072         * ada-valprint.c: Update.
5073         * amd64-tdep.c: Update.
5074         * arch-utils.c: Update.
5075         * break-catch-throw.c: Update.
5076         * breakpoint.c: Update.
5077         * btrace.c: Update.
5078         * c-varobj.c: Update.
5079         * cli/cli-cmds.c: Update.
5080         * cli/cli-interp.c: Update.
5081         * cli/cli-script.c: Update.
5082         * common/common-exceptions.c: Update.
5083         * common/new-op.c: Update.
5084         * common/selftest.c: Update.
5085         * compile/compile-c-symbols.c: Update.
5086         * compile/compile-cplus-symbols.c: Update.
5087         * compile/compile-object-load.c: Update.
5088         * compile/compile-object-run.c: Update.
5089         * completer.c: Update.
5090         * corelow.c: Update.
5091         * cp-abi.c: Update.
5092         * cp-support.c: Update.
5093         * cp-valprint.c: Update.
5094         * darwin-nat.c: Update.
5095         * disasm-selftests.c: Update.
5096         * dtrace-probe.c: Update.
5097         * dwarf-index-cache.c: Update.
5098         * dwarf-index-write.c: Update.
5099         * dwarf2-frame-tailcall.c: Update.
5100         * dwarf2-frame.c: Update.
5101         * dwarf2loc.c: Update.
5102         * dwarf2read.c: Update.
5103         * eval.c: Update.
5104         * event-loop.c: Update.
5105         * event-top.c: Update.
5106         * exec.c: Update.
5107         * f-valprint.c: Update.
5108         * fbsd-tdep.c: Update.
5109         * frame-unwind.c: Update.
5110         * frame.c: Update.
5111         * gdbtypes.c: Update.
5112         * gnu-v3-abi.c: Update.
5113         * guile/guile-internal.h: Update.
5114         * guile/scm-block.c: Update.
5115         * guile/scm-breakpoint.c: Update.
5116         * guile/scm-cmd.c: Update.
5117         * guile/scm-disasm.c: Update.
5118         * guile/scm-frame.c: Update.
5119         * guile/scm-lazy-string.c: Update.
5120         * guile/scm-math.c: Update.
5121         * guile/scm-param.c: Update.
5122         * guile/scm-ports.c: Update.
5123         * guile/scm-pretty-print.c: Update.
5124         * guile/scm-symbol.c: Update.
5125         * guile/scm-symtab.c: Update.
5126         * guile/scm-type.c: Update.
5127         * guile/scm-value.c: Update.
5128         * i386-linux-tdep.c: Update.
5129         * i386-tdep.c: Update.
5130         * inf-loop.c: Update.
5131         * infcall.c: Update.
5132         * infcmd.c: Update.
5133         * infrun.c: Update.
5134         * jit.c: Update.
5135         * language.c: Update.
5136         * linespec.c: Update.
5137         * linux-fork.c: Update.
5138         * linux-nat.c: Update.
5139         * linux-tdep.c: Update.
5140         * linux-thread-db.c: Update.
5141         * main.c: Update.
5142         * mi/mi-cmd-break.c: Update.
5143         * mi/mi-cmd-stack.c: Update.
5144         * mi/mi-interp.c: Update.
5145         * mi/mi-main.c: Update.
5146         * objc-lang.c: Update.
5147         * p-valprint.c: Update.
5148         * parse.c: Update.
5149         * ppc-linux-tdep.c: Update.
5150         * printcmd.c: Update.
5151         * python/py-arch.c: Update.
5152         * python/py-breakpoint.c: Update.
5153         * python/py-cmd.c: Update.
5154         * python/py-finishbreakpoint.c: Update.
5155         * python/py-frame.c: Update.
5156         * python/py-framefilter.c: Update.
5157         * python/py-gdb-readline.c: Update.
5158         * python/py-inferior.c: Update.
5159         * python/py-infthread.c: Update.
5160         * python/py-lazy-string.c: Update.
5161         * python/py-linetable.c: Update.
5162         * python/py-objfile.c: Update.
5163         * python/py-param.c: Update.
5164         * python/py-prettyprint.c: Update.
5165         * python/py-progspace.c: Update.
5166         * python/py-record-btrace.c: Update.
5167         * python/py-record.c: Update.
5168         * python/py-symbol.c: Update.
5169         * python/py-type.c: Update.
5170         * python/py-unwind.c: Update.
5171         * python/py-utils.c: Update.
5172         * python/py-value.c: Update.
5173         * python/python.c: Update.
5174         * record-btrace.c: Update.
5175         * record-full.c: Update.
5176         * remote-fileio.c: Update.
5177         * remote.c: Update.
5178         * riscv-tdep.c: Update.
5179         * rs6000-aix-tdep.c: Update.
5180         * rs6000-tdep.c: Update.
5181         * rust-exp.y: Update.
5182         * rust-lang.c: Update.
5183         * s390-tdep.c: Update.
5184         * selftest-arch.c: Update.
5185         * solib-dsbt.c: Update.
5186         * solib-frv.c: Update.
5187         * solib-spu.c: Update.
5188         * solib-svr4.c: Update.
5189         * solib.c: Update.
5190         * sparc64-linux-tdep.c: Update.
5191         * stack.c: Update.
5192         * symfile-mem.c: Update.
5193         * symmisc.c: Update.
5194         * target.c: Update.
5195         * thread.c: Update.
5196         * top.c: Update.
5197         * tracefile-tfile.c: Update.
5198         * tui/tui.c: Update.
5199         * typeprint.c: Update.
5200         * unittests/cli-utils-selftests.c: Update.
5201         * unittests/parse-connection-spec-selftests.c: Update.
5202         * valops.c: Update.
5203         * valprint.c: Update.
5204         * value.c: Update.
5205         * varobj.c: Update.
5206         * windows-nat.c: Update.
5207         * x86-linux-nat.c: Update.
5208         * xml-support.c: Update.
5209
5210 2019-04-08  Tom Tromey  <tom@tromey.com>
5211
5212         * xml-support.c: Use C++ exception handling.
5213         * x86-linux-nat.c: Use C++ exception handling.
5214         * windows-nat.c: Use C++ exception handling.
5215         * varobj.c: Use C++ exception handling.
5216         * value.c: Use C++ exception handling.
5217         * valprint.c: Use C++ exception handling.
5218         * valops.c: Use C++ exception handling.
5219         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5220         handling.
5221         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5222         * typeprint.c: Use C++ exception handling.
5223         * tui/tui.c: Use C++ exception handling.
5224         * tracefile-tfile.c: Use C++ exception handling.
5225         * top.c: Use C++ exception handling.
5226         * thread.c: Use C++ exception handling.
5227         * target.c: Use C++ exception handling.
5228         * symmisc.c: Use C++ exception handling.
5229         * symfile-mem.c: Use C++ exception handling.
5230         * stack.c: Use C++ exception handling.
5231         * sparc64-linux-tdep.c: Use C++ exception handling.
5232         * solib.c: Use C++ exception handling.
5233         * solib-svr4.c: Use C++ exception handling.
5234         * solib-spu.c: Use C++ exception handling.
5235         * solib-frv.c: Use C++ exception handling.
5236         * solib-dsbt.c: Use C++ exception handling.
5237         * selftest-arch.c: Use C++ exception handling.
5238         * s390-tdep.c: Use C++ exception handling.
5239         * rust-lang.c: Use C++ exception handling.
5240         * rust-exp.y: Use C++ exception handling.
5241         * rs6000-tdep.c: Use C++ exception handling.
5242         * rs6000-aix-tdep.c: Use C++ exception handling.
5243         * riscv-tdep.c: Use C++ exception handling.
5244         * remote.c: Use C++ exception handling.
5245         * remote-fileio.c: Use C++ exception handling.
5246         * record-full.c: Use C++ exception handling.
5247         * record-btrace.c: Use C++ exception handling.
5248         * python/python.c: Use C++ exception handling.
5249         * python/py-value.c: Use C++ exception handling.
5250         * python/py-utils.c: Use C++ exception handling.
5251         * python/py-unwind.c: Use C++ exception handling.
5252         * python/py-type.c: Use C++ exception handling.
5253         * python/py-symbol.c: Use C++ exception handling.
5254         * python/py-record.c: Use C++ exception handling.
5255         * python/py-record-btrace.c: Use C++ exception handling.
5256         * python/py-progspace.c: Use C++ exception handling.
5257         * python/py-prettyprint.c: Use C++ exception handling.
5258         * python/py-param.c: Use C++ exception handling.
5259         * python/py-objfile.c: Use C++ exception handling.
5260         * python/py-linetable.c: Use C++ exception handling.
5261         * python/py-lazy-string.c: Use C++ exception handling.
5262         * python/py-infthread.c: Use C++ exception handling.
5263         * python/py-inferior.c: Use C++ exception handling.
5264         * python/py-gdb-readline.c: Use C++ exception handling.
5265         * python/py-framefilter.c: Use C++ exception handling.
5266         * python/py-frame.c: Use C++ exception handling.
5267         * python/py-finishbreakpoint.c: Use C++ exception handling.
5268         * python/py-cmd.c: Use C++ exception handling.
5269         * python/py-breakpoint.c: Use C++ exception handling.
5270         * python/py-arch.c: Use C++ exception handling.
5271         * printcmd.c: Use C++ exception handling.
5272         * ppc-linux-tdep.c: Use C++ exception handling.
5273         * parse.c: Use C++ exception handling.
5274         * p-valprint.c: Use C++ exception handling.
5275         * objc-lang.c: Use C++ exception handling.
5276         * mi/mi-main.c: Use C++ exception handling.
5277         * mi/mi-interp.c: Use C++ exception handling.
5278         * mi/mi-cmd-stack.c: Use C++ exception handling.
5279         * mi/mi-cmd-break.c: Use C++ exception handling.
5280         * main.c: Use C++ exception handling.
5281         * linux-thread-db.c: Use C++ exception handling.
5282         * linux-tdep.c: Use C++ exception handling.
5283         * linux-nat.c: Use C++ exception handling.
5284         * linux-fork.c: Use C++ exception handling.
5285         * linespec.c: Use C++ exception handling.
5286         * language.c: Use C++ exception handling.
5287         * jit.c: Use C++ exception handling.
5288         * infrun.c: Use C++ exception handling.
5289         * infcmd.c: Use C++ exception handling.
5290         * infcall.c: Use C++ exception handling.
5291         * inf-loop.c: Use C++ exception handling.
5292         * i386-tdep.c: Use C++ exception handling.
5293         * i386-linux-tdep.c: Use C++ exception handling.
5294         * guile/scm-value.c: Use C++ exception handling.
5295         * guile/scm-type.c: Use C++ exception handling.
5296         * guile/scm-symtab.c: Use C++ exception handling.
5297         * guile/scm-symbol.c: Use C++ exception handling.
5298         * guile/scm-pretty-print.c: Use C++ exception handling.
5299         * guile/scm-ports.c: Use C++ exception handling.
5300         * guile/scm-param.c: Use C++ exception handling.
5301         * guile/scm-math.c: Use C++ exception handling.
5302         * guile/scm-lazy-string.c: Use C++ exception handling.
5303         * guile/scm-frame.c: Use C++ exception handling.
5304         * guile/scm-disasm.c: Use C++ exception handling.
5305         * guile/scm-cmd.c: Use C++ exception handling.
5306         * guile/scm-breakpoint.c: Use C++ exception handling.
5307         * guile/scm-block.c: Use C++ exception handling.
5308         * guile/guile-internal.h: Use C++ exception handling.
5309         * gnu-v3-abi.c: Use C++ exception handling.
5310         * gdbtypes.c: Use C++ exception handling.
5311         * frame.c: Use C++ exception handling.
5312         * frame-unwind.c: Use C++ exception handling.
5313         * fbsd-tdep.c: Use C++ exception handling.
5314         * f-valprint.c: Use C++ exception handling.
5315         * exec.c: Use C++ exception handling.
5316         * event-top.c: Use C++ exception handling.
5317         * event-loop.c: Use C++ exception handling.
5318         * eval.c: Use C++ exception handling.
5319         * dwarf2read.c: Use C++ exception handling.
5320         * dwarf2loc.c: Use C++ exception handling.
5321         * dwarf2-frame.c: Use C++ exception handling.
5322         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5323         * dwarf-index-write.c: Use C++ exception handling.
5324         * dwarf-index-cache.c: Use C++ exception handling.
5325         * dtrace-probe.c: Use C++ exception handling.
5326         * disasm-selftests.c: Use C++ exception handling.
5327         * darwin-nat.c: Use C++ exception handling.
5328         * cp-valprint.c: Use C++ exception handling.
5329         * cp-support.c: Use C++ exception handling.
5330         * cp-abi.c: Use C++ exception handling.
5331         * corelow.c: Use C++ exception handling.
5332         * completer.c: Use C++ exception handling.
5333         * compile/compile-object-run.c: Use C++ exception handling.
5334         * compile/compile-object-load.c: Use C++ exception handling.
5335         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5336         * compile/compile-c-symbols.c: Use C++ exception handling.
5337         * common/selftest.c: Use C++ exception handling.
5338         * common/new-op.c: Use C++ exception handling.
5339         * cli/cli-script.c: Use C++ exception handling.
5340         * cli/cli-interp.c: Use C++ exception handling.
5341         * cli/cli-cmds.c: Use C++ exception handling.
5342         * c-varobj.c: Use C++ exception handling.
5343         * btrace.c: Use C++ exception handling.
5344         * breakpoint.c: Use C++ exception handling.
5345         * break-catch-throw.c: Use C++ exception handling.
5346         * arch-utils.c: Use C++ exception handling.
5347         * amd64-tdep.c: Use C++ exception handling.
5348         * ada-valprint.c: Use C++ exception handling.
5349         * ada-typeprint.c: Use C++ exception handling.
5350         * ada-lang.c: Use C++ exception handling.
5351         * aarch64-tdep.c: Use C++ exception handling.
5352
5353 2019-04-08  Tom Tromey  <tom@tromey.com>
5354
5355         * xml-support.c (gdb_xml_parser::parse): Update.
5356         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5357         * value.c (show_convenience): Update.
5358         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5359         (test_parse_flags_qcs): Update.
5360         * thread.c (thr_try_catch_cmd): Update.
5361         * target.c (target_translate_tls_address): Update.
5362         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5363         (info_frame_command_core, frame_apply_command_count): Update.
5364         * rust-exp.y (rust_lex_exception_test): Update.
5365         * riscv-tdep.c (riscv_print_one_register_info): Update.
5366         * remote.c (remote_target::enable_btrace): Update.
5367         * record-btrace.c (record_btrace_enable_warn): Update.
5368         * python/py-utils.c (gdbpy_convert_exception): Update.
5369         * printcmd.c (do_one_display, print_variable_and_value): Update.
5370         * mi/mi-main.c (mi_print_exception): Update.
5371         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5372         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5373         * linux-nat.c (linux_nat_target::attach): Update.
5374         * linux-fork.c (class scoped_switch_fork_info): Update.
5375         * infrun.c (displaced_step_prepare): Update.
5376         * infcall.c (call_function_by_hand_dummy): Update.
5377         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5378         * gnu-v3-abi.c (print_one_vtable): Update.
5379         * frame.c (get_prev_frame_always): Update.
5380         * f-valprint.c (info_common_command_for_block): Update.
5381         * exec.c (try_open_exec_file): Update.
5382         * exceptions.c (print_exception, exception_print)
5383         (exception_fprintf, exception_print_same): Update.
5384         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5385         * dwarf-index-cache.c (index_cache::store)
5386         (index_cache::lookup_gdb_index): Update.
5387         * darwin-nat.c (maybe_cache_shell): Update.
5388         * cp-valprint.c (cp_print_value_fields): Update.
5389         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5390         (gcc_cplus_symbol_address): Update.
5391         * compile/compile-c-symbols.c (gcc_convert_symbol)
5392         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5393         * common/selftest.c: Update.
5394         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5395         a std::string.
5396         (exception_try_scope_entry, exception_try_scope_exit): Don't
5397         declare.
5398         (struct exception_try_scope): Remove.
5399         (TRY): Don't use exception_try_scope.
5400         (struct gdb_exception): Add constructor, operator=.
5401         <what>: New method.
5402         (struct gdb_exception_RETURN_MASK_ALL)
5403         (struct gdb_exception_RETURN_MASK_ERROR)
5404         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5405         (struct gdb_quit_bad_alloc): Update.
5406         * common/common-exceptions.c (exception_none): Change
5407         initializer.
5408         (struct catcher) <state, exception>: Initialize inline.
5409         <prev>: Remove member.
5410         (current_catcher): Remove.
5411         (catchers): New global.
5412         (exceptions_state_mc_init): Simplify.
5413         (catcher_pop): Remove.
5414         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5415         (try_scope_depth, exception_try_scope_entry)
5416         (exception_try_scope_exit): Remove.
5417         (throw_exception_sjlj): Update.
5418         (exception_messages, exception_messages_size): Remove.
5419         (throw_it): Simplify.
5420         (gdb_exception_sliced_copy): Remove.
5421         (throw_exception_cxx): Update.
5422         * cli/cli-script.c (script_from_file): Update.
5423         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5424         Update.
5425         * ada-valprint.c (ada_val_print): Update.
5426         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5427         (create_excep_cond_exprs): Update.
5428
5429 2019-04-08  Tom Tromey  <tom@tromey.com>
5430
5431         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5432         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5433         (TRY, CATCH, END_CATCH): Remove some definitions.
5434         * common/common-exceptions.c: Don't use GDB_XCPT.
5435         (catcher_list_size): Remove.
5436         (throw_exception, throw_it): Simplify.
5437
5438 2019-04-05  Tom Tromey  <tom@tromey.com>
5439
5440         Revert the header-sorting patch.
5441         * ft32-tdep.c: Revert.
5442         * frv-tdep.c: Revert.
5443         * frv-linux-tdep.c: Revert.
5444         * frame.c: Revert.
5445         * frame-unwind.c: Revert.
5446         * frame-base.c: Revert.
5447         * fork-child.c: Revert.
5448         * findvar.c: Revert.
5449         * findcmd.c: Revert.
5450         * filesystem.c: Revert.
5451         * filename-seen-cache.h: Revert.
5452         * filename-seen-cache.c: Revert.
5453         * fbsd-tdep.c: Revert.
5454         * fbsd-nat.h: Revert.
5455         * fbsd-nat.c: Revert.
5456         * f-valprint.c: Revert.
5457         * f-typeprint.c: Revert.
5458         * f-lang.c: Revert.
5459         * extension.h: Revert.
5460         * extension.c: Revert.
5461         * extension-priv.h: Revert.
5462         * expprint.c: Revert.
5463         * exec.h: Revert.
5464         * exec.c: Revert.
5465         * exceptions.c: Revert.
5466         * event-top.c: Revert.
5467         * event-loop.c: Revert.
5468         * eval.c: Revert.
5469         * elfread.c: Revert.
5470         * dwarf2read.h: Revert.
5471         * dwarf2read.c: Revert.
5472         * dwarf2loc.c: Revert.
5473         * dwarf2expr.h: Revert.
5474         * dwarf2expr.c: Revert.
5475         * dwarf2-frame.c: Revert.
5476         * dwarf2-frame-tailcall.c: Revert.
5477         * dwarf-index-write.h: Revert.
5478         * dwarf-index-write.c: Revert.
5479         * dwarf-index-common.c: Revert.
5480         * dwarf-index-cache.h: Revert.
5481         * dwarf-index-cache.c: Revert.
5482         * dummy-frame.c: Revert.
5483         * dtrace-probe.c: Revert.
5484         * disasm.h: Revert.
5485         * disasm.c: Revert.
5486         * disasm-selftests.c: Revert.
5487         * dictionary.c: Revert.
5488         * dicos-tdep.c: Revert.
5489         * demangle.c: Revert.
5490         * dcache.h: Revert.
5491         * dcache.c: Revert.
5492         * darwin-nat.h: Revert.
5493         * darwin-nat.c: Revert.
5494         * darwin-nat-info.c: Revert.
5495         * d-valprint.c: Revert.
5496         * d-namespace.c: Revert.
5497         * d-lang.c: Revert.
5498         * ctf.c: Revert.
5499         * csky-tdep.c: Revert.
5500         * csky-linux-tdep.c: Revert.
5501         * cris-tdep.c: Revert.
5502         * cris-linux-tdep.c: Revert.
5503         * cp-valprint.c: Revert.
5504         * cp-support.c: Revert.
5505         * cp-namespace.c: Revert.
5506         * cp-abi.c: Revert.
5507         * corelow.c: Revert.
5508         * corefile.c: Revert.
5509         * continuations.c: Revert.
5510         * completer.h: Revert.
5511         * completer.c: Revert.
5512         * complaints.c: Revert.
5513         * coffread.c: Revert.
5514         * coff-pe-read.c: Revert.
5515         * cli-out.h: Revert.
5516         * cli-out.c: Revert.
5517         * charset.c: Revert.
5518         * c-varobj.c: Revert.
5519         * c-valprint.c: Revert.
5520         * c-typeprint.c: Revert.
5521         * c-lang.c: Revert.
5522         * buildsym.c: Revert.
5523         * buildsym-legacy.c: Revert.
5524         * build-id.h: Revert.
5525         * build-id.c: Revert.
5526         * btrace.c: Revert.
5527         * bsd-uthread.c: Revert.
5528         * breakpoint.h: Revert.
5529         * breakpoint.c: Revert.
5530         * break-catch-throw.c: Revert.
5531         * break-catch-syscall.c: Revert.
5532         * break-catch-sig.c: Revert.
5533         * blockframe.c: Revert.
5534         * block.c: Revert.
5535         * bfin-tdep.c: Revert.
5536         * bfin-linux-tdep.c: Revert.
5537         * bfd-target.c: Revert.
5538         * bcache.c: Revert.
5539         * ax-general.c: Revert.
5540         * ax-gdb.h: Revert.
5541         * ax-gdb.c: Revert.
5542         * avr-tdep.c: Revert.
5543         * auxv.c: Revert.
5544         * auto-load.c: Revert.
5545         * arm-wince-tdep.c: Revert.
5546         * arm-tdep.c: Revert.
5547         * arm-symbian-tdep.c: Revert.
5548         * arm-pikeos-tdep.c: Revert.
5549         * arm-obsd-tdep.c: Revert.
5550         * arm-nbsd-tdep.c: Revert.
5551         * arm-nbsd-nat.c: Revert.
5552         * arm-linux-tdep.c: Revert.
5553         * arm-linux-nat.c: Revert.
5554         * arm-fbsd-tdep.c: Revert.
5555         * arm-fbsd-nat.c: Revert.
5556         * arm-bsd-tdep.c: Revert.
5557         * arch-utils.c: Revert.
5558         * arc-tdep.c: Revert.
5559         * arc-newlib-tdep.c: Revert.
5560         * annotate.h: Revert.
5561         * annotate.c: Revert.
5562         * amd64-windows-tdep.c: Revert.
5563         * amd64-windows-nat.c: Revert.
5564         * amd64-tdep.c: Revert.
5565         * amd64-sol2-tdep.c: Revert.
5566         * amd64-obsd-tdep.c: Revert.
5567         * amd64-obsd-nat.c: Revert.
5568         * amd64-nbsd-tdep.c: Revert.
5569         * amd64-nbsd-nat.c: Revert.
5570         * amd64-nat.c: Revert.
5571         * amd64-linux-tdep.c: Revert.
5572         * amd64-linux-nat.c: Revert.
5573         * amd64-fbsd-tdep.c: Revert.
5574         * amd64-fbsd-nat.c: Revert.
5575         * amd64-dicos-tdep.c: Revert.
5576         * amd64-darwin-tdep.c: Revert.
5577         * amd64-bsd-nat.c: Revert.
5578         * alpha-tdep.c: Revert.
5579         * alpha-obsd-tdep.c: Revert.
5580         * alpha-nbsd-tdep.c: Revert.
5581         * alpha-mdebug-tdep.c: Revert.
5582         * alpha-linux-tdep.c: Revert.
5583         * alpha-linux-nat.c: Revert.
5584         * alpha-bsd-tdep.c: Revert.
5585         * alpha-bsd-nat.c: Revert.
5586         * aix-thread.c: Revert.
5587         * agent.c: Revert.
5588         * addrmap.c: Revert.
5589         * ada-varobj.c: Revert.
5590         * ada-valprint.c: Revert.
5591         * ada-typeprint.c: Revert.
5592         * ada-tasks.c: Revert.
5593         * ada-lang.c: Revert.
5594         * aarch64-tdep.c: Revert.
5595         * aarch64-ravenscar-thread.c: Revert.
5596         * aarch64-newlib-tdep.c: Revert.
5597         * aarch64-linux-tdep.c: Revert.
5598         * aarch64-linux-nat.c: Revert.
5599         * aarch64-fbsd-tdep.c: Revert.
5600         * aarch64-fbsd-nat.c: Revert.
5601         * aarch32-linux-nat.c: Revert.
5602
5603 2019-04-05  Tom Tromey  <tom@tromey.com>
5604
5605         * ft32-tdep.c: Sort headers.
5606         * frv-tdep.c: Sort headers.
5607         * frv-linux-tdep.c: Sort headers.
5608         * frame.c: Sort headers.
5609         * frame-unwind.c: Sort headers.
5610         * frame-base.c: Sort headers.
5611         * fork-child.c: Sort headers.
5612         * findvar.c: Sort headers.
5613         * findcmd.c: Sort headers.
5614         * filesystem.c: Sort headers.
5615         * filename-seen-cache.h: Sort headers.
5616         * filename-seen-cache.c: Sort headers.
5617         * fbsd-tdep.c: Sort headers.
5618         * fbsd-nat.h: Sort headers.
5619         * fbsd-nat.c: Sort headers.
5620         * f-valprint.c: Sort headers.
5621         * f-typeprint.c: Sort headers.
5622         * f-lang.c: Sort headers.
5623         * extension.h: Sort headers.
5624         * extension.c: Sort headers.
5625         * extension-priv.h: Sort headers.
5626         * expprint.c: Sort headers.
5627         * exec.h: Sort headers.
5628         * exec.c: Sort headers.
5629         * exceptions.c: Sort headers.
5630         * event-top.c: Sort headers.
5631         * event-loop.c: Sort headers.
5632         * eval.c: Sort headers.
5633         * elfread.c: Sort headers.
5634         * dwarf2read.h: Sort headers.
5635         * dwarf2read.c: Sort headers.
5636         * dwarf2loc.c: Sort headers.
5637         * dwarf2expr.h: Sort headers.
5638         * dwarf2expr.c: Sort headers.
5639         * dwarf2-frame.c: Sort headers.
5640         * dwarf2-frame-tailcall.c: Sort headers.
5641         * dwarf-index-write.h: Sort headers.
5642         * dwarf-index-write.c: Sort headers.
5643         * dwarf-index-common.c: Sort headers.
5644         * dwarf-index-cache.h: Sort headers.
5645         * dwarf-index-cache.c: Sort headers.
5646         * dummy-frame.c: Sort headers.
5647         * dtrace-probe.c: Sort headers.
5648         * disasm.h: Sort headers.
5649         * disasm.c: Sort headers.
5650         * disasm-selftests.c: Sort headers.
5651         * dictionary.c: Sort headers.
5652         * dicos-tdep.c: Sort headers.
5653         * demangle.c: Sort headers.
5654         * dcache.h: Sort headers.
5655         * dcache.c: Sort headers.
5656         * darwin-nat.h: Sort headers.
5657         * darwin-nat.c: Sort headers.
5658         * darwin-nat-info.c: Sort headers.
5659         * d-valprint.c: Sort headers.
5660         * d-namespace.c: Sort headers.
5661         * d-lang.c: Sort headers.
5662         * ctf.c: Sort headers.
5663         * csky-tdep.c: Sort headers.
5664         * csky-linux-tdep.c: Sort headers.
5665         * cris-tdep.c: Sort headers.
5666         * cris-linux-tdep.c: Sort headers.
5667         * cp-valprint.c: Sort headers.
5668         * cp-support.c: Sort headers.
5669         * cp-namespace.c: Sort headers.
5670         * cp-abi.c: Sort headers.
5671         * corelow.c: Sort headers.
5672         * corefile.c: Sort headers.
5673         * continuations.c: Sort headers.
5674         * completer.h: Sort headers.
5675         * completer.c: Sort headers.
5676         * complaints.c: Sort headers.
5677         * coffread.c: Sort headers.
5678         * coff-pe-read.c: Sort headers.
5679         * cli-out.h: Sort headers.
5680         * cli-out.c: Sort headers.
5681         * charset.c: Sort headers.
5682         * c-varobj.c: Sort headers.
5683         * c-valprint.c: Sort headers.
5684         * c-typeprint.c: Sort headers.
5685         * c-lang.c: Sort headers.
5686         * buildsym.c: Sort headers.
5687         * buildsym-legacy.c: Sort headers.
5688         * build-id.h: Sort headers.
5689         * build-id.c: Sort headers.
5690         * btrace.c: Sort headers.
5691         * bsd-uthread.c: Sort headers.
5692         * breakpoint.h: Sort headers.
5693         * breakpoint.c: Sort headers.
5694         * break-catch-throw.c: Sort headers.
5695         * break-catch-syscall.c: Sort headers.
5696         * break-catch-sig.c: Sort headers.
5697         * blockframe.c: Sort headers.
5698         * block.c: Sort headers.
5699         * bfin-tdep.c: Sort headers.
5700         * bfin-linux-tdep.c: Sort headers.
5701         * bfd-target.c: Sort headers.
5702         * bcache.c: Sort headers.
5703         * ax-general.c: Sort headers.
5704         * ax-gdb.h: Sort headers.
5705         * ax-gdb.c: Sort headers.
5706         * avr-tdep.c: Sort headers.
5707         * auxv.c: Sort headers.
5708         * auto-load.c: Sort headers.
5709         * arm-wince-tdep.c: Sort headers.
5710         * arm-tdep.c: Sort headers.
5711         * arm-symbian-tdep.c: Sort headers.
5712         * arm-pikeos-tdep.c: Sort headers.
5713         * arm-obsd-tdep.c: Sort headers.
5714         * arm-nbsd-tdep.c: Sort headers.
5715         * arm-nbsd-nat.c: Sort headers.
5716         * arm-linux-tdep.c: Sort headers.
5717         * arm-linux-nat.c: Sort headers.
5718         * arm-fbsd-tdep.c: Sort headers.
5719         * arm-fbsd-nat.c: Sort headers.
5720         * arm-bsd-tdep.c: Sort headers.
5721         * arch-utils.c: Sort headers.
5722         * arc-tdep.c: Sort headers.
5723         * arc-newlib-tdep.c: Sort headers.
5724         * annotate.h: Sort headers.
5725         * annotate.c: Sort headers.
5726         * amd64-windows-tdep.c: Sort headers.
5727         * amd64-windows-nat.c: Sort headers.
5728         * amd64-tdep.c: Sort headers.
5729         * amd64-sol2-tdep.c: Sort headers.
5730         * amd64-obsd-tdep.c: Sort headers.
5731         * amd64-obsd-nat.c: Sort headers.
5732         * amd64-nbsd-tdep.c: Sort headers.
5733         * amd64-nbsd-nat.c: Sort headers.
5734         * amd64-nat.c: Sort headers.
5735         * amd64-linux-tdep.c: Sort headers.
5736         * amd64-linux-nat.c: Sort headers.
5737         * amd64-fbsd-tdep.c: Sort headers.
5738         * amd64-fbsd-nat.c: Sort headers.
5739         * amd64-dicos-tdep.c: Sort headers.
5740         * amd64-darwin-tdep.c: Sort headers.
5741         * amd64-bsd-nat.c: Sort headers.
5742         * alpha-tdep.c: Sort headers.
5743         * alpha-obsd-tdep.c: Sort headers.
5744         * alpha-nbsd-tdep.c: Sort headers.
5745         * alpha-mdebug-tdep.c: Sort headers.
5746         * alpha-linux-tdep.c: Sort headers.
5747         * alpha-linux-nat.c: Sort headers.
5748         * alpha-bsd-tdep.c: Sort headers.
5749         * alpha-bsd-nat.c: Sort headers.
5750         * aix-thread.c: Sort headers.
5751         * agent.c: Sort headers.
5752         * addrmap.c: Sort headers.
5753         * ada-varobj.c: Sort headers.
5754         * ada-valprint.c: Sort headers.
5755         * ada-typeprint.c: Sort headers.
5756         * ada-tasks.c: Sort headers.
5757         * ada-lang.c: Sort headers.
5758         * aarch64-tdep.c: Sort headers.
5759         * aarch64-ravenscar-thread.c: Sort headers.
5760         * aarch64-newlib-tdep.c: Sort headers.
5761         * aarch64-linux-tdep.c: Sort headers.
5762         * aarch64-linux-nat.c: Sort headers.
5763         * aarch64-fbsd-tdep.c: Sort headers.
5764         * aarch64-fbsd-nat.c: Sort headers.
5765         * aarch32-linux-nat.c: Sort headers.
5766
5767 2019-04-04  Tom Tromey  <tom@tromey.com>
5768
5769         * varobj.c (varobj_create): Update.
5770         * rust-exp.y (struct rust_parser) <update_innermost_block,
5771         lookup_symbol>: New methods.
5772         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5773         Rename.
5774         (rust_parser::rust_lookup_type)
5775         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5776         * printcmd.c (display_command, do_one_display): Update.
5777         * parser-defs.h (struct parser_state) <parser_state>: Add
5778         "tracker" parameter.
5779         (block_tracker): New member.
5780         (class innermost_block_tracker) <innermost_block_tracker>: Add
5781         "types" parameter.
5782         <reset>: Remove method.
5783         (innermost_block): Don't declare.
5784         (null_post_parser): Update.
5785         * parse.c (innermost_block): Remove global.
5786         (write_dollar_variable): Update.
5787         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5788         Remove "tracker_types" parameter.
5789         (parse_expression): Add "tracker" parameter.
5790         (parse_expression_for_completion): Update.
5791         (null_post_parser): Add "tracker" parameter.
5792         * p-exp.y: Update rules.
5793         * m2-exp.y: Update rules.
5794         * language.h (struct language_defn) <la_post_parser>: Add
5795         "tracker" parameter.
5796         * go-exp.y: Update rules.
5797         * f-exp.y: Update rules.
5798         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5799         parameter.
5800         * d-exp.y: Update rules.
5801         * c-exp.y: Update rules.
5802         * breakpoint.c (set_breakpoint_condition): Create an
5803         innermost_block_tracker.
5804         (watch_command_1): Likewise.
5805         * ada-lang.c (resolve): Add "tracker" parameter.
5806         (resolve_subexp): Likewise.
5807         * ada-exp.y (write_var_from_sym): Update.
5808
5809 2019-04-04  Tom Tromey  <tom@tromey.com>
5810
5811         * type-stack.h: New file.
5812         * type-stack.c: New file.
5813         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5814         type-stack.h.
5815         (insert_into_type_stack, insert_type, push_type, push_type_int)
5816         (insert_type_address_space, pop_type, pop_type_int)
5817         (pop_typelist, pop_type_stack, append_type_stack)
5818         (push_type_stack, get_type_stack, push_typelist)
5819         (follow_type_instance_flags, follow_types): Don't declare.
5820         * parse.c (type_stack): Remove global.
5821         (parse_exp_in_context): Update.
5822         (insert_into_type_stack, insert_type, push_type, push_type_int)
5823         (insert_type_address_space, pop_type, pop_type_int)
5824         (pop_typelist, pop_type_stack, append_type_stack)
5825         (push_type_stack, get_type_stack, push_typelist)
5826         (follow_type_instance_flags, follow_types): Remove (moved to
5827         type-stack.c).
5828         * f-exp.y (type_stack): New global.
5829         Update rules.
5830         (push_kind_type, f_parse): Update.
5831         * d-exp.y (type_stack): New global.
5832         Update rules.
5833         (d_parse): Update.
5834         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5835         Update rules.
5836         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5837         (HFILES_NO_SRCDIR): Add type-stack.h.
5838
5839 2019-04-04  Tom Tromey  <tom@tromey.com>
5840
5841         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5842         (rust_parser::convert_ast_to_expression, rust_parse)
5843         (rust_lex_test_completion, rust_lex_tests): Update.
5844         * parser-defs.h (struct expr_completion_state): New.
5845         (struct parser_state) <parser_state>: Add completion parameter.
5846         <mark_struct_expression, mark_completion_tag>: New methods.
5847         <parse_completion, m_completion_state>: New members.
5848         (prefixify_expression, null_post_parser): Update.
5849         (mark_struct_expression, mark_completion_tag): Don't declare.
5850         * parse.c (parse_completion, expout_last_struct)
5851         (expout_tag_completion_type, expout_completion_name): Remove
5852         globals.
5853         (parser_state::mark_struct_expression)
5854         (parser_state::mark_completion_tag): Now methods.
5855         (prefixify_expression): Add last_struct parameter.
5856         (prefixify_subexp): Likewise.
5857         (parse_exp_1): Update.
5858         (parse_exp_in_context): Add cstate parameter.  Update.
5859         (parse_expression_for_completion): Create an
5860         expr_completion_state.
5861         (null_post_parser): Add "completion" parameter.
5862         * p-exp.y: Update rules.
5863         (yylex): Update.
5864         * language.h (struct language_defn) <la_post_parser>: Add
5865         "completing" parameter.
5866         * go-exp.y: Update rules.
5867         (lex_one_token): Update.
5868         * expression.h (parse_completion): Don't declare.
5869         * d-exp.y: Update rules.
5870         (lex_one_token): Update rules.
5871         * c-exp.y: Update rules.
5872         (lex_one_token): Update.
5873         * ada-lang.c (resolve): Add "parse_completion" parameter.
5874         (resolve_subexp): Likewise.
5875         (ada_resolve_function): Likewise.
5876
5877 2019-04-04  Tom Tromey  <tom@tromey.com>
5878
5879         * parser-defs.h (struct parser_state) <start_arglist,
5880         end_arglist>: New methods.
5881         <arglist_len, m_funcall_chain>: New members.
5882         (arglist_len, start_arglist, end_arglist): Don't declare.
5883         * parse.c (arglist_len, funcall_chain): Remove global.
5884         (start_arglist, end_arglist): Remove functions.
5885         (parse_exp_in_context): Update.
5886         * p-exp.y: Update rules.
5887         * m2-exp.y: Update rules.
5888         * go-exp.y: Update rules.
5889         * f-exp.y: Update rules.
5890         * d-exp.y: Update rules.
5891         * c-exp.y: Update rules.
5892
5893 2019-04-04  Tom Tromey  <tom@tromey.com>
5894
5895         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5896         lex_operator, push_back>: New methods.
5897         Update all rules.
5898         (rust_parser::lex_hex, lex_escape): Rename and update.
5899         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5900         (rust_parser::lex_operator): Rename and update.
5901         (rust_parser::lex_number, rustyylex, rustyyerror)
5902         (rust_lex_test_init, rust_lex_test_sequence)
5903         (rust_lex_test_push_back, rust_lex_tests): Update.
5904         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5905         parameter.
5906         <lexptr, prev_lexptr>: New members.
5907         (lexptr, prev_lexptr): Don't declare.
5908         * parse.c (lexptr, prev_lexptr): Remove globals.
5909         (parse_exp_in_context): Update.
5910         * p-exp.y (yylex, yyerror): Update.
5911         * m2-exp.y (parse_number, yylex, yyerror): Update.
5912         * go-exp.y (lex_one_token, yyerror): Update.
5913         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5914         * d-exp.y (lex_one_token, yyerror): Update.
5915         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5916         (lex_one_token, yyerror): Update.
5917         * ada-lex.l (YY_INPUT): Update.
5918         (rewind_to_char): Update.
5919         * ada-exp.y (yyerror): Update.
5920
5921 2019-04-04  Tom Tromey  <tom@tromey.com>
5922
5923         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5924         * parser-defs.h (struct parser_state) <parser_state>: Add new
5925         parameter.
5926         <comma_terminates>: New member.
5927         (comma_terminates): Don't declare global.
5928         * parse.c (comma_terminates): Remove global.
5929         (parse_exp_in_context): Update.
5930         * p-exp.y (yylex): Update.
5931         * m2-exp.y (yylex): Update.
5932         * go-exp.y (lex_one_token): Update.
5933         * f-exp.y (yylex): Update.
5934         * d-exp.y (lex_one_token): Update.
5935         * c-exp.y (lex_one_token): Update.
5936         * ada-lex.l: Update.
5937
5938 2019-04-04  Tom Tromey  <tom@tromey.com>
5939
5940         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5941         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5942         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5943         * parser-defs.h (paren_depth): Don't declare.
5944         * parse.c (paren_depth): Remove global.
5945         (parse_exp_in_context): Update.
5946         * p-exp.y (paren_depth): New global.
5947         (pascal_parse): Initialize it.
5948         * m2-exp.y (paren_depth): New global.
5949         (m2_parse): Initialize it.
5950         * go-exp.y (paren_depth): New global.
5951         (go_parse): Initialize it.
5952         * f-exp.y (paren_depth): New global.
5953         (f_parse): Initialize it.
5954         * d-exp.y (paren_depth): New global.
5955         (d_parse): Initialize it.
5956         * c-exp.y (paren_depth): New global.
5957         (c_parse): Initialize it.
5958         * ada-lex.l (paren_depth): New global.
5959         (lexer_init): Initialize it.
5960
5961 2019-04-04  Tom Tromey  <tom@tromey.com>
5962
5963         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5964         (rust_parser::convert_ast_to_type)
5965         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5966         * parser-defs.h (struct parser_state) <parser_state>: Add
5967         parameters.  Initialize new members.
5968         <expression_context_block, expression_context_pc>: New members.
5969         * parse.c (expression_context_block, expression_context_pc):
5970         Remove globals.
5971         (parse_exp_in_context): Update.
5972         * p-exp.y: Update all rules.
5973         (yylex): Update.
5974         * m2-exp.y: Update all rules.
5975         (yylex): Update.
5976         * go-exp.y (yylex): Update.
5977         * f-exp.y (yylex): Update.
5978         * d-exp.y: Update all rules.
5979         (yylex): Update.
5980         * c-exp.y: Update all rules.
5981         (lex_one_token, classify_name, yylex, c_parse): Update.
5982         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5983
5984 2019-04-04  Tom Tromey  <tom@tromey.com>
5985
5986         * gdbarch.h, gdbarch.c: Rebuild.
5987         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5988         * stap-probe.h:
5989         (struct stap_parse_info): Replace "parser_state" with
5990         "expr_builder".
5991         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5992         (parser_state): New class.
5993         * parse.c (expr_builder): Rename.
5994         (expr_builder::release): Rename.
5995         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5996         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5997         (write_exp_elt_longcst, write_exp_elt_floatcst)
5998         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5999         (write_exp_string_vector, write_exp_bitstring)
6000         (write_exp_msymbol, mark_struct_expression)
6001         (write_dollar_variable)
6002         (insert_type_address_space, increase_expout_size): Replace
6003         "parser_state" with "expr_builder".
6004         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6005         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6006         "parser_state" with "expr_builder".
6007
6008 2019-04-04  Tom Tromey  <tom@tromey.com>
6009
6010         * rust-exp.y: Replace "parse_language" with method call.
6011         * p-exp.y:
6012         (yylex): Replace "parse_language" with method call.
6013         * m2-exp.y:
6014         (yylex): Replace "parse_language" with method call.
6015         * go-exp.y (classify_name): Replace "parse_language" with method
6016         call.
6017         * f-exp.y (yylex): Replace "parse_language" with method call.
6018         * d-exp.y (lex_one_token): Replace "parse_language" with method
6019         call.
6020         * c-exp.y:
6021         (lex_one_token, classify_name, yylex): Replace "parse_language"
6022         with method call.
6023         * ada-exp.y (find_primitive_type, type_char)
6024         (type_system_address): Replace "parse_language" with method call.
6025
6026 2019-04-04  Tom Tromey  <tom@tromey.com>
6027
6028         * rust-exp.y: Replace "parse_gdbarch" with method call.
6029         * parse.c (write_dollar_variable, insert_type_address_space):
6030         Replace "parse_gdbarch" with method call.
6031         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6032         call.
6033         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6034         call.
6035         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6036         "parse_gdbarch" with method call.
6037         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6038         with method call.
6039         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6040         "parse_gdbarch" with method call.
6041         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6042         "parse_gdbarch" with method call.
6043         * c-exp.y (parse_type, parse_number, classify_name): Replace
6044         "parse_gdbarch" with method call.
6045         * ada-lex.l: Replace "parse_gdbarch" with method call.
6046         * ada-exp.y (parse_type, find_primitive_type, type_char)
6047         (type_system_address): Replace "parse_gdbarch" with method call.
6048
6049 2019-04-04  Tom Tromey  <tom@tromey.com>
6050
6051         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6052         * stap-probe.c (stap_parse_argument): Update.
6053         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6054         initial_size parameter.
6055         * rust-exp.y (rust_lex_tests): Update.
6056         * parse.c (parser_state): Update.
6057         (parse_exp_in_context): Update.
6058         * parser-defs.h (struct parser_state) <parser_state>: Remove
6059         "initial_size" parameter.
6060
6061 2019-04-04  Tom Tromey  <tom@tromey.com>
6062
6063         * parser-defs.h (increase_expout_size): Don't declare.
6064         * parse.c (increase_expout_size): Now static.
6065
6066 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6067
6068         * gnu-nat.c (gnu_nat_target::wait): Fix
6069         target_waitstatus_to_string call.
6070
6071 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * eval.c (evaluate_subexp_standard): Handle internal functions
6074         during Fortran function call handling.
6075
6076 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6077
6078         * NEWS: Mention new internal functions.
6079         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6080         (read_base_type): Use dwarf2_init_complex_target_type.
6081         * value.c (creal_internal_fn): New function.
6082         (cimag_internal_fn): New function.
6083         (_initialize_values): Register new internal functions.
6084
6085 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6086
6087         * infrun.c (stop_all_threads): If debug_infrun, always
6088         trace the wait status after wait_one, using
6089         target_waitstatus_to_string and target_pid_to_str.
6090         (handle_inferior_event): Replace various trace of
6091         wait status kind by a single trace.
6092         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6093         wait status kind image by target_waitstatus_to_string.
6094         * target/waitstatus.c (target_waitstatus_to_string): Fix
6095         obsolete comment.
6096
6097 2019-04-01  Tom Tromey  <tromey@adacore.com>
6098
6099         PR symtab/23331:
6100         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6101
6102 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6103             Pedro Alves  <palves@redhat.com>
6104
6105         * top.c (quit_force): Call 'finalize_values'.
6106         * value.c (finalize_values): New function.
6107         * value.h (finalize_values): Declare.
6108
6109 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6110
6111         * NEWS: Announce $_gdb_major and $_gdb_minor.
6112
6113         * top.c (init_gdb_version_vars): New function.
6114         (gdb_init): Call init_gdb_version_vars.
6115
6116 2019-03-29  Tom Tromey  <tromey@adacore.com>
6117
6118         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6119         help text.  Remove dead code.
6120
6121 2019-03-29  Keith Seitz  <keiths@redhat.com>
6122
6123         From Siddhesh Poyarekar:
6124         * f-lang.h (f77_get_upperbound): Return LONGEST.
6125         (f77_get_lowerbound): Likewise.
6126         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6127         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6128         print them.
6129         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6130         plongest to format print it.
6131         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6132         (f77_get_upperbound): Likewise.
6133         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6134         LOWER_BOUND to LONGEST.
6135         (f77_create_arrayprint_offset_tbl): Likewise.
6136
6137 2019-03-29  Keith Seitz  <keiths@redhat.com>
6138
6139         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6140         %s/pulongest for TYPE_LENGTH instead of %d in format
6141         strings.
6142         * ada-typerint.c (ada_print_type): Likewise.
6143         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6144         * compile/compile-c-support.c (generate_register_struct): Likewise.
6145         * gdbtypes.c (recursive_dump_type): Likewise.
6146         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6147         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6148         instead of %d in format strings.
6149         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6150         to std::min to ULONGEST.
6151         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6152         instead of %d in format strings.
6153         * tracepoint.c (info_scope_command): Likewise.
6154         * typeprint.c (print_offset_data::update)
6155         (print_offset_data::finish): Likewise.
6156         * xtensa-tdep.c (xtensa_store_return_value)
6157         (xtensa_push_dummy_call): Likewise.
6158
6159 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6160
6161         * windows-nat.c (display_selector): Fixed format specifications
6162         for 64-bit Cygwin.
6163
6164 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6165
6166         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6167
6168 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6169
6170         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6171         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6172         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6173         (nios2_linux_init_abi): Install it.
6174
6175 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6176
6177         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6178
6179 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6180
6181         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6182
6183 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6184             Tom Tromey  <tromey@adacore.com>
6185
6186         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6187
6188 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6189
6190         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6191         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6192         method to compute the bounds of range types. Also print "[evaluated]"
6193         if the bounds' values come from a dynamic evaluation.
6194
6195 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6196
6197         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6198         whitespace when pretty printing is on.
6199
6200 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6201
6202         * ppc-linux-nat.c: Add include.
6203
6204 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6205
6206         * NEWS: Mention AArch64 Pointer Authentication.
6207
6208 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6209
6210         * arm-linux-nat.c: Add include.
6211
6212 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6213
6214         * source-cache.c (source_cache::get_source_lines): Re-read
6215         fullname after calling open_source_file.
6216
6217 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6218
6219         * NEWS: Mention TLS support for FreeBSD.
6220
6221 2019-03-25  Tom Tromey  <tromey@adacore.com>
6222
6223         * minsyms.c (BUNCH_SIZE): Update comment.
6224         (~minimal_symbol_reader): Remove old comment.
6225         (compact_minimal_symbols): Update comment.
6226         (minimal_symbol_reader::install): Remove old comment.  Update
6227         other comments.
6228
6229 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6230
6231         * s390-linux-nat.c: Add include.
6232
6233 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6234
6235         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6236         Call linux_get_hwcap.
6237         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6238         Likewise.
6239         (aarch64_linux_get_hwcap): Remove function.
6240         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6241         declaration.
6242         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6243         linux_get_hwcap.
6244         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6245         * linux-tdep.c (linux_get_hwcap): Add function.
6246         (linux_get_hwcap2): Likewise.
6247         * linux-tdep.h (linux_get_hwcap): Add declaration.
6248         (linux_get_hwcap2): Likewise.
6249         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6250         (ppc_linux_get_hwcap2): Likewise.
6251         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6252         linux_get_hwcap.
6253         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6254         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6255         (ppc_linux_nat_target::read_description): Likewise.
6256         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6257         * s390-linux-nat.c: Likewise.
6258         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6259
6260 2019-03-24  Tom Tromey  <tom@tromey.com>
6261
6262         * ada-lang.c (standard_lookup): Simplify initialization.
6263         (ada_lookup_symbol_nonlocal): Simplify return.
6264         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6265         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6266         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6267         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6268         initialization.
6269         * solib.c (solib_global_lookup): Simplify.
6270         * symtab.c (null_block_symbol): Remove.
6271         (symbol_cache_lookup): Simplify returns.
6272         (lookup_language_this): Simplify returns.
6273         (lookup_symbol_aux): Simplify return.
6274         (lookup_local_symbol): Simplify returns.
6275         (lookup_global_symbol_from_objfile): Simplify return.
6276         (lookup_symbol_in_objfile_symtabs)
6277         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6278         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6279         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6280         * cp-namespace.c (cp_lookup_bare_symbol)
6281         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6282         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6283         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6284         (cp_lookup_symbol_via_imports): Simplify initialization.
6285         (find_symbol_in_baseclass): Likewise.
6286         * symtab.h (null_block_symbol): Remove.
6287         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6288         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6289         (d_lookup_symbol_module): Likewise.
6290         (find_symbol_in_baseclass): Simplify initialization.
6291
6292 2019-03-24  Tom Tromey  <tom@tromey.com>
6293
6294         * expression.h: Don't include symtab.h.
6295         (struct block): Forward declare.
6296
6297 2019-03-24  Tom Tromey  <tom@tromey.com>
6298
6299         * c-exp.y (typebase): Remove casts.
6300         * gdbtypes.c (lookup_unsigned_typename, )
6301         (lookup_signed_typename): Remove cast.
6302         * eval.c (parse_to_comma_and_eval): Remove cast.
6303         * parse.c (write_dollar_variable): Remove cast.
6304         * block.h (struct block) <superblock>: Now const.
6305         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6306         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6307         (map_block): Make "block" const.
6308         * symfile.h (struct quick_symbol_functions)
6309         <map_matching_symbols>: Constify block argument to "callback".
6310         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6311         const.
6312         (find_pc_sect_compunit_symtab): Make "b" const.
6313         (find_symbol_at_address): Likewise.
6314         (search_symbols): Likewise.
6315         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6316         (dw2_debug_names_lookup_symbol): Likewise.
6317         (dw2_map_matching_symbols): Update.
6318         * p-valprint.c (pascal_val_print): Remove "block".
6319         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6320         (aux_add_nonlocal_symbols): Make "block" const.
6321         (resolve_subexp): Remove cast.
6322         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6323         const.
6324         (iterate_over_file_blocks): Likewise.
6325         * f-exp.y (%union) <bval>: Remove.
6326         * coffread.c (patch_opaque_types): Make "b" const.
6327         * spu-tdep.c (spu_catch_start): Make "block" const.
6328         * c-valprint.c (print_unpacked_pointer): Remove "block".
6329         * symmisc.c (dump_symtab_1): Make "b" const.
6330         (block_depth): Make "block" const.
6331         * d-exp.y (%union) <bval>: Remove.
6332         * cp-support.h (cp_lookup_rtti_type): Update.
6333         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6334         * psymtab.c (psym_lookup_symbol): Make "block" const.
6335         (maintenance_check_psymtabs): Make "b" const.
6336         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6337         (enumerate_locals, enumerate_args): Update.
6338         * python/py-symtab.c (stpy_global_block): Make "block" const.
6339         (stpy_static_block): Likewise.
6340         * inline-frame.c (block_starting_point_at): Make "new_block"
6341         const.
6342         * block.c (find_block_in_blockvector): Make return type const.
6343         (blockvector_for_pc_sect): Make "b" const.
6344         (find_block_in_blockvector): Make "b" const.
6345
6346 2019-03-23  Tom Tromey  <tom@tromey.com>
6347
6348         * varobj.c (varobj_create): Update.
6349         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6350         * printcmd.c (display_command, do_one_display): Don't reset
6351         innermost_block.
6352         * parser-defs.h (enum innermost_block_tracker_type): Move to
6353         expression.h.
6354         (innermost_block): Update comment.
6355         * parse.c (parse_exp_1): Add tracker_types parameter.
6356         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6357         tracker_types parameter.  Reset innermost_block.
6358         (parse_exp_in_context): Remove.
6359         (parse_expression_for_completion): Update.
6360         * objfiles.c (~objfile): Don't reset expression_context_block or
6361         innermost_block.
6362         * expression.h (enum innermost_block_tracker_type): Move from
6363         parser-defs.h.
6364         (parse_exp_1): Add tracker_types parameter.
6365         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6366         reset innermost_block.
6367
6368 2019-03-23  Tom Tromey  <tom@tromey.com>
6369
6370         * objfiles.h: Include bcache.h.
6371
6372 2019-03-23  Tom Tromey  <tom@tromey.com>
6373
6374         * linespec.c (get_current_search_block): Use
6375         scoped_restore_current_language.
6376         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6377
6378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6379             Jiong Wang  <jiong.wang@arm.com>
6380
6381         * aarch64-linux-tdep.c
6382         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6383         section.
6384         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6385
6386 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6387             Jiong Wang  <jiong.wang@arm.com>
6388
6389         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6390         instructions.
6391         (aarch64_analyze_prologue_test): Add PACIASP test.
6392         (aarch64_prologue_prev_register): Unmask PC value.
6393
6394 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6395             Jiong Wang  <jiong.wang@arm.com>
6396
6397         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6398         (aarch64_dwarf2_prev_register): Unmask PC value.
6399         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6400         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6401         DW_CFA_AARCH64_negate_ra_state.
6402         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6403
6404 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6405             Jiong Wang  <jiong.wang@arm.com>
6406
6407         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6408         registers.
6409         (aarch64_pseudo_register_name): Likewise.
6410         (aarch64_pseudo_register_type): Likewise.
6411         (aarch64_pseudo_register_reggroup_p): Likewise.
6412         (aarch64_gdbarch_init): Add pauth registers.
6413         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6414         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6415         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6416         (struct gdbarch_tdep): Add regnum for ra_state.
6417
6418 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6419             Jiong Wang  <jiong.wang@arm.com>
6420
6421         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6422
6423 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6424             Jiong Wang  <jiong.wang@arm.com>
6425
6426         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6427         function.
6428         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6429         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6430         (aarch64_gdbarch_init): Add puth registers.
6431         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6432         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6433         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6434
6435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6436             Jiong Wang  <jiong.wang@arm.com>
6437
6438         * aarch64-linux-nat.c
6439         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6440         * aarch64-linux-tdep.c
6441         (aarch64_linux_core_read_description): Likewise.
6442         (aarch64_linux_get_hwcap): New function.
6443         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6444         (aarch64_linux_get_hwcap): New declaration.
6445
6446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6447             Jiong Wang  <jiong.wang@arm.com>
6448
6449         * aarch64-linux-nat.c
6450         (aarch64_linux_nat_target::read_description): Add pauth param.
6451         * aarch64-linux-tdep.c
6452         (aarch64_linux_core_read_description): Likewise.
6453         * aarch64-tdep.c (struct target_desc): Add in pauth.
6454         (aarch64_read_description): Add pauth param.
6455         (aarch64_gdbarch_init): Likewise.
6456         * aarch64-tdep.h (aarch64_read_description): Likewise.
6457         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6458         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6459         * features/Makefile: Add new files.
6460         * features/aarch64-pauth.c: New file.
6461         * features/aarch64-pauth.xml: New file.
6462
6463 2019-03-20  Tom Tromey  <tromey@adacore.com>
6464
6465         * infrun.c (handle_inferior_event): Rename from
6466         handle_inferior_event_1.  Create a scoped_value_mark.
6467         (handle_inferior_event): Remove.
6468
6469 2019-03-19  Tom Tromey  <tromey@adacore.com>
6470
6471         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6472         * infrun.h (print_stop_event): Add "displays" parameter.
6473         * infrun.c (print_stop_event): Add "displays" parameter.
6474
6475 2019-03-19  Pedro Alves  <palves@redhat.com>
6476
6477         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6478         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6479         to -1.  Fix TABs vs spaces.
6480         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6481         * tui/tui-out.h (tui_ui_out) Add intro comments.
6482         <m_line, m_start_of_line>: In-class initialize, and add describing
6483         comment.
6484
6485 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6486
6487         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6488         variable names.
6489         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6490
6491 2019-03-18  Pedro Alves  <palves@redhat.com>
6492             Eli Zaretskii <eliz@gnu.org>
6493
6494         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6495         m_line and m_start_of_line.
6496
6497 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6498
6499         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6500         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6501         it returns a newline.  This fixes a regression in TU mode, whereby
6502         the next line is output on the same screen line as the user input.
6503
6504 2019-03-18  Tom Tromey  <tromey@adacore.com>
6505
6506         * minsyms.c (minimal_symbol_reader::install): Remove call to
6507         obstack_blank.
6508
6509 2019-03-18  Pedro Alves  <palves@redhat.com>
6510
6511         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6512         New globals.
6513         (apply_style): New, factored out from ...
6514         (apply_ansi_escape): ... this.  Handle reverse video mode.
6515         (tui_set_reverse_mode): New function.
6516         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6517         * tui/tui-winsource.c (tui_show_source_line): Use
6518         tui_set_reverse_mode instead of setting A_STANDOUT.
6519         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6520         New setter methods.
6521
6522 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6523
6524         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6525         Handle tabs.
6526
6527 2019-03-18  Tom Tromey  <tromey@adacore.com>
6528
6529         * ada-lang.c (empty_array): Add "high" parameter.
6530         (ada_evaluate_subexp): Update.
6531
6532 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6533
6534         * unittests/string_view-selftests.c: Define
6535         _initialize_string_view_selftests unconditionally.
6536
6537 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6538
6539         PR gdb/24350
6540         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6541
6542 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6543
6544         PR gdb/24351
6545         * windows-nat.c (display_selector): Fix format specifiers.
6546
6547 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6548
6549         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6550         tui_refill_source_window instead of tui_refresh_win, to update the
6551         current execution line.  This fixes redisplay of the current line
6552         when stepping through the code with "next" or "step".
6553
6554 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6555
6556         * source-cache.c (source_cache::get_source_lines): Call
6557         find_source_lines to initialize s->nlines.  This fixes vertical
6558         scrolling of TUI source window when the DOWN arrow is pressed.
6559
6560 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6561
6562         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6563         linux-thread-db.c (_initialize_thread_db): Likewise.
6564
6565 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6566
6567         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6568         wclrtoeol in tui_show_source_line".  This reverts changes made in
6569         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6570
6571 2019-03-15  Tom Tromey  <tom@tromey.com>
6572
6573         * symtab.h (struct minimal_symbol): Derive from
6574         general_symbol_info.
6575         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6576         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6577         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6578         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6579         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6580         (MSYMBOL_SEARCH_NAME): Update.
6581         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6582         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6583         * minsyms.c (minimal_symbol_reader::record_full): Update.
6584
6585 2019-03-15  Tom Tromey  <tom@tromey.com>
6586
6587         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6588
6589 2019-03-15  Tom Tromey  <tom@tromey.com>
6590
6591         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6592         unique_xmalloc_ptr.
6593         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6594         Update.
6595         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6596         (build_minimal_symbol_hash_tables)
6597         (minimal_symbol_reader::install): Update.
6598
6599 2019-03-15  Tom Tromey  <tom@tromey.com>
6600
6601         * symtab.c (create_demangled_names_hash): Update.
6602         (symbol_set_names): Update.
6603         * objfiles.h (struct objfile_per_bfd_storage)
6604         <demangled_names_hash>: Now an htab_up.
6605         * objfiles.c (objfile_per_bfd_storage): Simplify.
6606
6607 2019-03-15  Tom Tromey  <tom@tromey.com>
6608
6609         * objfiles.h (struct objfile_per_bfd_storage): Declare
6610         destructor.
6611         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6612         New.
6613         (get_objfile_bfd_data): Use new.  Don't initialize
6614         language_of_main.
6615         (free_objfile_per_bfd_storage): Remove.
6616         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6617
6618 2019-03-15  Tom Tromey  <tom@tromey.com>
6619
6620         * symfile.c (reread_symbols): Update.
6621         * objfiles.c (objfile::objfile): Update.
6622         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6623         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6624         comment.
6625         (minimal_symbol_reader::install): Update.
6626         (terminate_minimal_symbol_table): Remove.
6627         * jit.c (jit_object_close_impl): Update.
6628
6629 2019-03-15  Tom Tromey  <tom@tromey.com>
6630
6631         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6632         initializations.
6633
6634 2019-03-15  Tom Tromey  <tom@tromey.com>
6635
6636         * objfiles.h (struct objfile_per_bfd_storage)
6637         <demangled_hash_languages>: Now a bitset.
6638         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6639         (lookup_minimal_symbol): Update.
6640
6641 2019-03-15  Tom Tromey  <tom@tromey.com>
6642
6643         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6644         Don't return the symbol.
6645         * coffread.c (record_minimal_symbol): Use record_full.
6646
6647 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6648
6649         The MS-Windows port of ncurses fails to switch to a color pair if
6650         one or both of the colors are the implicit default colors.  This
6651         change records the default colors when TUI is initialized, and
6652         then specifies them explicitly when a color pair uses the default
6653         colors.  This allows color styling in TUI mode on MS-Windows.
6654
6655         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6656         ncurses_norm_attr.
6657         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6658         colors in ncurses_norm_attr.
6659         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6660         "none", replace it with the default color recorded in
6661         ncurses_norm_attr.
6662
6663 2019-03-14  Tom Tromey  <tromey@adacore.com>
6664
6665         * source-cache.h (class source_cache) <get_source_lines>: Return
6666         std::string.
6667         * source-cache.c (source_cache::extract_lines): Handle case where
6668         first_pos==npos.  Return std::string.
6669         (source_cache::get_source_lines): Update.
6670
6671 2019-03-14  Tom Tromey  <tromey@adacore.com>
6672
6673         * NEWS: Add item for "style sources" commands.
6674         * source-cache.c (source_cache::get_source_lines): Check
6675         source_styling.
6676         * cli/cli-style.c (source_styling): New global.
6677         (_initialize_cli_style): Add "style sources" commands.
6678         (show_style_sources): New function.
6679         * cli/cli-style.h (source_styling): Declare.
6680
6681 2019-03-14  Pedro Alves  <palves@redhat.com>
6682             Tom Tromey  <tromey@adacore.com>
6683
6684         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6685         * tui/tui-winsource.c (tui_refill_source_window): New function,
6686         from...
6687         (tui_horizontal_source_scroll): ... here.  Move some logic.
6688         * cli/cli-style.c (set_style_enabled): Notify new observable.
6689         * tui/tui-hooks.c (tui_redisplay_source): New function.
6690         (tui_attach_detach_observers): Attach or detach
6691         tui_redisplay_source.
6692         * observable.h (source_styling_changed): New observable.
6693         * observable.c: Define source_styling_changed observable.
6694
6695 2019-03-13  Tom Tromey  <tromey@adacore.com>
6696
6697         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6698         (i386_gnu_nat_target::store_registers): Update.
6699         * target-debug.h (target_debug_print_std_string): New macro.
6700         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6701         * windows-tdep.c (display_one_tib): Update.
6702         * tui/tui-stack.c (tui_make_status_line): Update.
6703         * top.c (print_inferior_quit_action): Update.
6704         * thread.c (thr_try_catch_cmd): Update.
6705         (add_thread_with_info): Update.
6706         (thread_target_id_str): Update.
6707         (thr_try_catch_cmd): Update.
6708         (thread_command): Update.
6709         (thread_find_command): Update.
6710         * record-btrace.c (record_btrace_target::info_record)
6711         (record_btrace_resume_thread, record_btrace_target::resume)
6712         (record_btrace_cancel_resume, record_btrace_step_thread)
6713         (record_btrace_target::wait, record_btrace_target::wait)
6714         (record_btrace_target::wait, record_btrace_target::stop): Update.
6715         * progspace.c (print_program_space): Update.
6716         * process-stratum-target.c
6717         (process_stratum_target::thread_address_space): Update.
6718         * linux-fork.c (linux_fork_mourn_inferior)
6719         (detach_checkpoint_command, info_checkpoints_command)
6720         (linux_fork_context): Update.
6721         (linux_fork_detach): Update.
6722         (class scoped_switch_fork_info): Update.
6723         (delete_checkpoint_command): Update.
6724         * infrun.c (follow_fork_inferior): Update.
6725         (follow_fork_inferior): Update.
6726         (proceed_after_vfork_done): Update.
6727         (handle_vfork_child_exec_or_exit): Update.
6728         (follow_exec): Update.
6729         (displaced_step_prepare_throw): Update.
6730         (displaced_step_restore): Update.
6731         (start_step_over): Update.
6732         (resume_1): Update.
6733         (clear_proceed_status_thread): Update.
6734         (proceed): Update.
6735         (print_target_wait_results): Update.
6736         (do_target_wait): Update.
6737         (context_switch): Update.
6738         (stop_all_threads): Update.
6739         (restart_threads): Update.
6740         (finish_step_over): Update.
6741         (handle_signal_stop): Update.
6742         (switch_back_to_stepped_thread): Update.
6743         (keep_going_pass_signal): Update.
6744         (print_exited_reason): Update.
6745         (normal_stop): Update.
6746         * inferior.c (inferior_pid_to_str): Change return type.
6747         (print_selected_inferior): Update.
6748         (add_inferior): Update.
6749         (detach_inferior): Update.
6750         * dummy-frame.c (fprint_dummy_frames): Update.
6751         * dcache.c (dcache_info_1): Update.
6752         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6753         (btrace_fetch, btrace_clear): Update.
6754         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6755         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6756         type.
6757         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6758         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6759         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6760         * gdbarch.c, gdbarch.h: Rebuild.
6761         * gdbarch.sh (core_pid_to_str): Change return type.
6762         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6763         return type.
6764         (windows_nat_target::pid_to_str): Change return type.
6765         (windows_delete_thread): Update.
6766         (windows_nat_target::attach): Update.
6767         (windows_nat_target::files_info): Update.
6768         * target-delegates.c: Rebuild.
6769         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6770         return type.
6771         (sol_thread_target::pid_to_str): Change return type.
6772         * remote.c (class remote_target) <pid_to_str>: Change return
6773         type.
6774         (remote_target::pid_to_str): Change return type.
6775         (extended_remote_target::attach, remote_target::remote_stop_ns)
6776         (remote_target::remote_notif_remove_queued_reply)
6777         (remote_target::push_stop_reply, remote_target::disable_btrace):
6778         Update.
6779         (extended_remote_target::attach): Update.
6780         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6781         type.
6782         (gdbsim_target::pid_to_str): Change return type.
6783         * ravenscar-thread.c (struct ravenscar_thread_target)
6784         <pid_to_str>: Change return type.
6785         (ravenscar_thread_target::pid_to_str): Change return type.
6786         * procfs.c (class procfs_target) <pid_to_str>: Change return
6787         type.
6788         (procfs_target::pid_to_str): Change return type.
6789         (procfs_target::attach): Update.
6790         (procfs_target::detach): Update.
6791         (procfs_target::fetch_registers): Update.
6792         (procfs_target::store_registers): Update.
6793         (procfs_target::wait): Update.
6794         (procfs_target::files_info): Update.
6795         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6796         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6797         return type.
6798         (nto_procfs_target::pid_to_str): Change return type.
6799         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6800         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6801         return type.
6802         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6803         (exit_lwp): Update.
6804         (attach_proc_task_lwp_callback, get_detach_signal)
6805         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6806         (linux_nat_target::resume, wait_lwp, stop_callback)
6807         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6808         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6809         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6810         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6811         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6812         type.
6813         (inf_ptrace_target::attach): Update.
6814         (inf_ptrace_target::files_info): Update.
6815         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6816         type.
6817         (go32_nat_target::pid_to_str): Change return type.
6818         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6819         (gnu_nat_target::wait): Update.
6820         (gnu_nat_target::wait): Update.
6821         (gnu_nat_target::resume): Update.
6822         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6823         (fbsd_nat_target::wait): Update.
6824         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6825         type.
6826         (darwin_nat_target::attach): Update.
6827         * corelow.c (class core_target) <pid_to_str>: Change return type.
6828         (core_target::pid_to_str): Change return type.
6829         * target.c (normal_pid_to_str): Change return type.
6830         (default_pid_to_str): Likewise.
6831         (target_pid_to_str): Change return type.
6832         (target_translate_tls_address): Update.
6833         (target_announce_detach): Update.
6834         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6835         return type.
6836         (bsd_uthread_target::pid_to_str): Change return type.
6837         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6838         type.
6839         (bsd_kvm_target::pid_to_str): Change return type.
6840         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6841         return type.
6842         (aix_thread_target::pid_to_str): Change return type.
6843         * target.h (struct target_ops) <pid_to_str>: Change return type.
6844         (target_pid_to_str, normal_pid_to_str): Likewise.
6845         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6846         type.
6847         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6848         type.
6849         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6850         return type.
6851         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6852         type.
6853         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6854         type.
6855         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6856         return type.
6857
6858 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6859
6860         * NEWS: Mention that the new default MI version is 3.  Mention
6861         changes to the output of commands and events that deal with
6862         multi-location breakpoints.
6863         * breakpoint.c: Include "mi/mi-out.h".
6864         (print_one_breakpoint): Change output syntax if using MI version
6865         >= 3.
6866         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6867         New.
6868         (mi_multi_location_breakpoint_output_fixed): New.
6869         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6870         (mi_cmd_fix_multi_location_breakpoint_output): New.
6871         (mi_multi_location_breakpoint_output_fixed): New.
6872         * mi/mi-cmds.c (mi_cmds): Register command
6873         -fix-multi-location-breakpoint-output.
6874         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6875         interpreter "mi".
6876
6877 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6878
6879         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6880         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6881         instantiate mi_ui_out based on interpreter name.
6882         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6883         * mi/mi-main.c (mi_load_progress): Likewise.
6884
6885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6886
6887         * NEWS: Combine separate "New targets" sections for 8.3.
6888
6889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6890
6891         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6892         (ppcfbsd_init_abi): Install gdbarch
6893         "fetch_tls_load_module_address" and "get_thread_local_address"
6894         methods.
6895
6896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6897
6898         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6899         (riscv_fbsd_init_abi): Install gdbarch
6900         "fetch_tls_load_module_address" and "get_thread_local_address"
6901         methods.
6902
6903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6904
6905         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6906         (i386fbsd_init_abi): Install gdbarch
6907         "fetch_tls_load_module_address" and "get_thread_local_address"
6908         methods.
6909
6910 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6911
6912         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6913         (amd64fbsd_init_abi): Install gdbarch
6914         "fetch_tls_load_module_address" and "get_thread_local_address"
6915         methods.
6916
6917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6918
6919         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6920         (struct fbsd_pspace_data): New type.
6921         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6922         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6923         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6924         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6925         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6926
6927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6928
6929         * gdbtypes.c (lookup_struct_elt): New function.
6930         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6931         * gdbtypes.h (struct struct_elt): New type.
6932         (lookup_struct_elt): New prototype.
6933
6934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6935
6936         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6937         remove disabled code block.
6938
6939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6940
6941         * gdbarch.sh (get_thread_local_address): New method.
6942         * gdbarch.h, gdbarch.c: Regenerate.
6943         * target.c (target_translate_tls_address): Use
6944         gdbarch_get_thread_local_address if present instead of
6945         target::get_thread_local_address.
6946
6947 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6948
6949         * target.h (target::get_thread_local_address): Update comment.
6950
6951 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6952
6953         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6954         objfile->separate_debug_objfile_backlink if not NULL.
6955
6956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6957
6958         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6959         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6960         (amd64bsd_store_inferior_registers): Likewise.
6961         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6962         Enable segment base registers.
6963         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6964         PT_GETFSBASE and PT_GETGSBASE.
6965         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6966         PT_SETGSBASE.
6967         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6968         segment base registers.
6969         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6970
6971 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6972
6973         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6974         Update calls to i386_target_description to add 'segments'
6975         parameter.
6976         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6977         add segment base registers.
6978         * arch/i386.c (i386_create_target_description): Add 'segments'
6979         parameter to enable segment base registers.
6980         * arch/i386.h (i386_create_target_description): Likewise.
6981         * features/i386/32bit-segments.xml: New file.
6982         * features/i386/32bit-segments.c: Generate.
6983         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6984         call to i386_target_description to add 'segments' parameter.
6985         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6986         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6987         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6988         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6989         if feature is present.
6990         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6991         Add 'segments' parameter to call to i386_target_description.
6992         (i386_target_description): Add 'segments' parameter to enable
6993         segment base registers.
6994         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6995         to call to i386_target_description.
6996         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6997         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6998         Define I386_NUM_REGS.
6999         (i386_target_description): Add 'segments' parameter to enable
7000         segment base registers.
7001
7002 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7003
7004         PR/24325
7005         * source-cache.c: #undef open and close, to avoid unresolved
7006         externals during linking.
7007
7008 2019-03-12  Tom Tromey  <tromey@adacore.com>
7009
7010         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7011         const.  Add initializers.
7012         (_initialize_remote): Don't initialize ptid globals.
7013
7014 2019-03-12  Pedro Alves  <palves@redhat.com>
7015
7016         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7017
7018 2019-03-12  Pedro Alves  <palves@redhat.com>
7019
7020         * cp-name-parser.y (main): Remove unused 'len' variable.
7021
7022 2019-03-12  Tom Tromey  <tromey@adacore.com>
7023
7024         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7025         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7026
7027 2019-03-12  Tom Tromey  <tromey@adacore.com>
7028
7029         * linux-nat.c (iterate_over_lwps): Update.
7030         (stop_callback): Remove parameter.
7031         (stop_wait_callback, detach_callback, resume_set_callback)
7032         (select_singlestep_lwp_callback, set_ignore_sigint)
7033         (status_callback, resumed_callback, resume_clear_callback)
7034         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7035         data parameter.
7036         (linux_nat_target::detach, linux_nat_target::resume)
7037         (linux_stop_and_wait_all_lwps, select_event_lwp)
7038         (linux_nat_filter_event, linux_nat_wait_1)
7039         (linux_nat_target::kill, linux_nat_target::stop)
7040         (linux_nat_target::stop): Update.
7041         (linux_nat_resume_callback): Change type.
7042         (resume_stopped_resumed_lwps, count_events_callback)
7043         (select_event_lwp_callback): Likewise.
7044         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7045         * arm-linux-nat.c (struct update_registers_data): Remove.
7046         (update_registers_callback): Change type.
7047         (arm_linux_insert_hw_breakpoint1): Update.
7048         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7049         parameter.
7050         (x86_linux_dr_set_addr): Update.
7051         (x86_linux_dr_set_control): Update.
7052         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7053         (iterate_over_lwps): Use gdb::function_view.
7054         * nat/aarch64-linux-hw-point.c (struct
7055         aarch64_dr_update_callback_param): Remove.
7056         (debug_reg_change_callback): Change type.
7057         (aarch64_notify_debug_reg_change): Update.
7058         * s390-linux-nat.c (s390_refresh_per_info): Update.
7059
7060 2019-03-11  Tom Tromey  <tromey@adacore.com>
7061
7062         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7063         redundant assignment to "this_cu".
7064
7065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7066
7067         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7068
7069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7070
7071         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7072         from...
7073         (rank_one_type): ... this.
7074
7075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7076
7077         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7078         from...
7079         (rank_one_type): ... this.
7080
7081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7082
7083         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7084         from...
7085         (rank_one_type): ... this.
7086
7087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7088
7089         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7090         from...
7091         (rank_one_type): ... this.
7092
7093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7094
7095         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7096         from...
7097         (rank_one_type): ... this.
7098
7099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7100
7101         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7102         from...
7103         (rank_one_type): ... this.
7104
7105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7106
7107         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7108         from...
7109         (rank_one_type): ... this.
7110
7111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7112
7113         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7114         from...
7115         (rank_one_type): ... this.
7116
7117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7118
7119         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7120         from...
7121         (rank_one_type): ... this.
7122
7123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7124
7125         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7126         from...
7127         (rank_one_type): ... this.
7128
7129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7130
7131         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7132         from...
7133         (rank_one_type): ... this.
7134
7135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7136
7137         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7138         from...
7139         (rank_one_type): ... this.
7140
7141 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7142
7143         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7144         inferior-events' shows the example events.
7145
7146 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7147
7148         Support styling on native MS-Windows console
7149
7150         PR/24315
7151         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7152         on MS-Windows if $TERM is not defined.
7153
7154         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7155
7156         * posix-hdep.c (gdb_console_fputs):
7157         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7158         functions.
7159         * ui-file.h (gdb_console_fputs): Add prototype.
7160
7161         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7162         back to fputs only if the former returns zero.
7163
7164 2019-03-07  Tom Tromey  <tom@tromey.com>
7165
7166         * symmisc.c (print_symbol_bcache_statistics): Update.
7167         (print_objfile_statistics): Update.
7168         * symfile.c (allocate_symtab): Update.
7169         * stabsread.c: Don't include bcache.h.
7170         * psymtab.h (struct psymbol_bcache): Don't declare.
7171         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7172         (psymbol_bcache_init, psymbol_bcache_free)
7173         (psymbol_bcache_get_bcache): Don't declare.
7174         * psymtab.c (struct psymbol_bcache): Remove.
7175         (psymtab_storage::psymtab_storage): Update.
7176         (psymtab_storage::~psymtab_storage): Update.
7177         (psymbol_bcache_init, psymbol_bcache_free)
7178         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7179         (add_psymbol_to_bcache): Update.
7180         (allocate_psymtab): Update.
7181         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7182         macro_cache>: No longer pointers.
7183         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7184         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7185         * macrotab.c (macro_bcache): Update.
7186         * macroexp.c: Don't include bcache.h.
7187         * gdbtypes.c (check_types_worklist): Update.
7188         (types_deeply_equal): Remove TRY/CATCH.  Update.
7189         * elfread.c (elf_symtab_read): Update.
7190         * dwarf2read.c: Don't include bcache.h.
7191         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7192         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7193         (print_bcache_statistics, bcache_memory_used): Don't declare.
7194         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7195         methods.  Rename all data members.
7196         * bcache.c (struct bcache): Move to bcache.h.
7197         (bcache::expand_hash_table): Rename from expand_hash_table.
7198         (bcache): Remove.
7199         (bcache::insert): Rename from bcache_full.
7200         (bcache::compare): Rename from bcache_compare.
7201         (bcache_xmalloc): Remove.
7202         (bcache::~bcache): Rename from bcache_xfree.
7203         (bcache::print_statistics): Rename from print_bcache_statistics.
7204         (bcache::memory_used): Rename from bcache_memory_used.
7205
7206 2019-03-07  Pedro Alves  <palves@redhat.com>
7207
7208         * infrun.c (normal_stop): Also check for
7209         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7210
7211 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7212
7213         * f-lang.c (value_from_host_double): Moved to...
7214         * value.c (value_from_host_double): ...here.
7215         * value.h (value_from_host_double): Declare.
7216         * guile/scm-math.c (vlscm_convert_typed_number): Use
7217         value_from_host_double.
7218         (vlscm_convert_number): Likewise.
7219         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7220         * python/py-value.c (convert_value_from_python): Likewise.
7221
7222 2019-03-06  Tom Tromey  <tom@tromey.com>
7223
7224         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7225
7226 2019-03-06  Tom Tromey  <tom@tromey.com>
7227
7228         * utils.h (free_current_contents): Don't declare.
7229         * utils.c (free_current_contents): Remove.
7230
7231 2019-03-06  Tom Tromey  <tom@tromey.com>
7232
7233         * top.c (quit_force): Update.
7234         * main.c (captured_command_loop): Update.
7235         * common/new-op.c (operator new): Update.
7236         * common/common-exceptions.c (struct catcher)
7237         <save_cleanup_chain>: Remove member.
7238         (exceptions_state_mc_init): Update.
7239         (exception_try_scope_entry): Return nullptr.
7240         (exception_try_scope_exit, exception_rethrow)
7241         (throw_exception_sjlj, throw_exception_cxx): Update.
7242         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7243         (all_cleanups, do_cleanups, discard_cleanups)
7244         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7245         (restore_cleanups, restore_final_cleanups): Don't declare.
7246         (do_final_cleanups): Remove parameter.
7247         * common/cleanups.c (cleanup_chain, make_cleanup)
7248         (make_cleanup_dtor, all_cleanups, do_cleanups)
7249         (discard_my_cleanups, discard_cleanups)
7250         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7251         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7252         (null_cleanup): Remove.
7253         (do_final_cleanups): Remove parameter.
7254
7255 2019-03-06  Tom Tromey  <tom@tromey.com>
7256
7257         * remote.c (remote_target::remote_parse_stop_reply): Use
7258         unique_xmalloc_ptr.
7259
7260 2019-03-06  Tom Tromey  <tom@tromey.com>
7261
7262         * stabsread.c (struct stabs_field_info): Rename from field_info.
7263         <list, fnlist>: Add initializers.
7264         <obstack>: New member.
7265         (read_member_functions, read_struct_fields, read_baseclasses):
7266         Allocate on obstack.  Don't use cleanups.
7267         (read_one_struct_field, read_member_functions, read_struct_fields)
7268         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7269         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7270         (read_struct_type): Update.
7271
7272 2019-03-06  Tom Tromey  <tom@tromey.com>
7273
7274         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7275         * common/filestuff.h (make_cleanup_close): Don't declare.
7276         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7277         Remove.
7278
7279 2019-03-06  Tom Tromey  <tom@tromey.com>
7280
7281         * solib-aix.c: Use make_scope_exit.
7282
7283 2019-03-06  Tom Tromey  <tom@tromey.com>
7284
7285         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7286         Use make_scope_exit.
7287
7288 2019-03-06  Tom Tromey  <tom@tromey.com>
7289
7290         * solib-svr4.c (disable_probes_interface): Remove parameter.
7291         (svr4_handle_solib_event): Use make_scope_exit.
7292
7293 2019-03-06  Tom Tromey  <tom@tromey.com>
7294
7295         * remote.c (struct stop_reply_deleter): Remove.
7296         (stop_reply_up): Update.
7297         (struct stop_reply): Derive from notif_event.  Don't typedef.
7298         <regcache>: Now a std::vector.
7299         (stop_reply_xfree): Remove.
7300         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7301         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7302         (remote_target::discard_pending_stop_replies): Use delete.
7303         (remote_target::remote_parse_stop_reply): Update.
7304         (remote_target::process_stop_reply): Update.
7305         * remote-notif.h (struct notif_event): Add virtual destructor.
7306         Remove "dtr" member.
7307         (struct notif_client) <alloc_event>: Return a unique_ptr.
7308         (notif_event_xfree): Don't declare.
7309         (notif_event_up): New typedef.
7310         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7311         (notif_event_xfree, do_notif_event_xfree): Remove.
7312         (remote_notif_state_xfree): Update.
7313
7314 2019-03-06  Tom Tromey  <tom@tromey.com>
7315
7316         * infrun.c (displaced_step_clear_cleanup): Now a
7317         forward_scope_exit type.
7318         (displaced_step_prepare_throw): Update.
7319         (displaced_step_fixup): Update.
7320
7321 2019-03-06  Tom Tromey  <tom@tromey.com>
7322
7323         * inferior.h (class inferior): Update comment.
7324         * gdbthread.h (class thread_info): Update comment.
7325
7326 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7327             Tom Tromey  <tom@tromey.com>
7328
7329         * stabsread.h (struct stab_section_list): Remove.
7330         (coffstab_build_psymtabs): Update.
7331         * dbxread.c (symbuf_sections): Now a std::vector.
7332         (sect_idx): New global.
7333         (fill_symbuf): Update.
7334         (coffstab_build_psymtabs): Change type of stabsects parameter.
7335         Update.
7336         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7337         std::vector.
7338         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7339         (coff_locate_sections): Update.
7340         (coff_symfile_read): Remove cleanups.  Update.
7341         (init_stringtab): Add storage parameter.
7342         (free_stringtab, free_stringtab_cleanup): Remove.
7343         (init_lineno): Add storage parameter.
7344         (free_linetab, free_linetab_cleanup): Remove.
7345
7346 2019-03-06  Pedro Alves  <palves@redhat.com>
7347
7348         * linux-fork.c (fork_info::clobber_regs): Delete.
7349         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7350         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7351         comment.  Adjust.
7352         (scoped_switch_fork_info::scoped_switch_fork_info)
7353         (checkpoint_command, linux_fork_context): Adjust
7354         fork_save_infrun_state calls.
7355
7356 2019-03-06  Pedro Alves  <palves@redhat.com>
7357
7358         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7359         (inf_has_multiple_threads): Return 'bool' and rewrite using
7360         inferior_info::threads().
7361
7362 2019-03-06  Pedro Alves  <palves@redhat.com>
7363
7364         * linux-fork.c: Include <list>.
7365         (fork_list): Now a std::list instance.
7366         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7367         (forks_exist_p, find_last_fork): Adjust.
7368         (new_fork): Delete.
7369         (one_fork_p): New.
7370         (add_fork): Adjust.
7371         (free_fork): Delete, folded into fork_info::~fork_info().
7372         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7373         Adjust.
7374         (init_fork_list): Delete.
7375         (linux_fork_killall, linux_fork_mourn_inferior)
7376         (linux_fork_detach, info_checkpoints_command): Adjust.
7377         (_initialize_linux_fork): No longer call init_fork_list.
7378
7379 2019-03-06  Pedro Alves  <palves@redhat.com>
7380
7381         * linux-fork.c (new_fork): New, split out of ...
7382         (add_fork): ... this.  Return void.  Move "first fork" special
7383         case from here, to ...
7384         (checkpoint_command): ... here.
7385         * linux-linux.h (add_fork): Return void.
7386
7387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7388
7389         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7390
7391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7392             Chris January  <chris.january@arm.com>
7393             David Lecomber  <david.lecomber@arm.com>
7394
7395         * f-exp.y: New token, UNOP_INTRINSIC.
7396         (exp): New pattern using UNOP_INTRINSIC token.
7397         (f77_keywords): Add 'abs' keyword.
7398         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7399         (value_from_host_double): New function.
7400         (evaluate_subexp_f): Support UNOP_ABS.
7401
7402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7405         types.
7406
7407 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7410         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7411         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7412
7413 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7416
7417 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7418             Chris January  <chris.january@arm.com>
7419
7420         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7421         * f-exp.y: Define 'KIND' token.
7422         (exp): New pattern for KIND expressions.
7423         (ptype): Handle types with a kind extension.
7424         (direct_abs_decl): Extend to spot kind extensions.
7425         (f77_keywords): Add 'kind' to the list.
7426         (push_kind_type): New function.
7427         (convert_to_kind_type): New function.
7428         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7429         * parse.c (operator_length_standard): Likewise.
7430         * parser-defs.h (enum type_pieces): Add tp_kind.
7431         * std-operator.def: Add UNOP_KIND.
7432
7433 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7434
7435         * f-exp.y (f_parse): Set yydebug.
7436
7437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7438
7439         * f-lang.c (evaluate_subexp_f): New function.
7440         (exp_descriptor_f): New global.
7441         (f_language_defn): Use exp_descriptor_f instead of
7442         exp_descriptor_standard.
7443
7444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * f-exp.y (struct token): Add comments.
7447         (dot_ops): Remove uppercase versions and the end marker.
7448         (f77_keywords): Likewise.
7449         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7450         entries in the dot_ops array are case insensitive, and use
7451         strncasecmp to compare strings.  Also some whitespace cleanup in
7452         this area.  Similar for the f77_keywords array, except entries in
7453         this list might be case sensitive.
7454
7455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7456
7457         * f-exp.y (struct f77_boolean_val): Add comments.
7458         (boolean_values): Remove uppercase versions, and end marker.
7459         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7460         and use strncasecmp to achieve case insensitivity.  Additionally,
7461         perform whitespace cleanup around this code.
7462
7463 2019-03-06  Tom Tromey  <tromey@adacore.com>
7464
7465         * remote-sim.c (gdbsim_target_open): Use result of
7466         gdb_argv::release.
7467
7468 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7469         Dirk Schubert  <dirk.schubert@arm.com>
7470         Chris January  <chris.january@arm.com>
7471
7472         * eval.c (evaluate_subexp_standard): Call Fortran argument
7473         wrapping logic.
7474         * f-lang.c (struct value): A value which can be passed into a
7475         Fortran function call.
7476         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7477         where appropriate.
7478         (struct type): Value ready for a Fortran function call.
7479         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7480         is needed.
7481         * f-lang.h (fortran_argument_convert): Declaration.
7482         (fortran_preserve_arg_pointer): Declaration.
7483         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7484
7485 2019-03-05  Tom Tromey  <tromey@adacore.com>
7486
7487         * python/py-prettyprint.c (print_string_repr): Remove #if.
7488         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7489
7490 2019-03-05  Tom Tromey  <tromey@adacore.com>
7491
7492         * target.c (the_dummy_target): Move later.  Change type to
7493         "dummy_target".
7494         (initialize_targets): Don't initialize the_dummy_target.
7495
7496 2019-03-05  Tom Tromey  <tromey@adacore.com>
7497
7498         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7499         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7500
7501 2019-03-05  Tom Tromey  <tromey@adacore.com>
7502
7503         * windows-nat.c (windows_nat_target::attach)
7504         (windows_nat_target::detach): Don't call gdb_flush.
7505         * valprint.c (generic_val_print, val_print, val_print_string):
7506         Don't call gdb_flush.
7507         * utils.c (defaulted_query): Don't call gdb_flush.
7508         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7509         * target.c (target_announce_detach): Don't call gdb_flush.
7510         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7511         * remote.c (extended_remote_target::attach): Don't call
7512         gdb_flush.
7513         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7514         * printcmd.c (do_examine): Don't call gdb_flush.
7515         (info_display_command): Don't call gdb_flush.
7516         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7517         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7518         * memattr.c (info_mem_command): Don't call gdb_flush.
7519         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7520         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7521         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7522         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7523         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7524         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7525         (gnu_nat_target::detach): Don't call gdb_flush.
7526         * f-valprint.c (f_val_print): Don't call gdb_flush.
7527         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7528         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7529         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7530         gdb_flush.
7531         * c-valprint.c (c_val_print): Don't call gdb_flush.
7532         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7533
7534 2019-03-05  Tom Tromey  <tromey@adacore.com>
7535
7536         * varobj.c (update_dynamic_varobj_children): Update.
7537         (install_default_visualizer): Use reset, not release.
7538         * value.c (set_internalvar): Update.
7539         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7540         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7541         ATTRIBUTE_UNUSED_RESULT.
7542
7543 2019-03-05  Tom Tromey  <tromey@adacore.com>
7544
7545         * remote.c (class scoped_remote_fd) <release>: Add
7546         ATTRIBUTE_UNUSED_RESULT.
7547
7548 2019-03-05  Tom Tromey  <tromey@adacore.com>
7549
7550         * macroexp.c (struct macro_buffer) <release>: Add
7551         ATTRIBUTE_UNUSED_RESULT.
7552
7553 2019-03-05  Tom Tromey  <tromey@adacore.com>
7554
7555         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7556         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7557         ATTRIBUTE_UNUSED_RESULT.
7558
7559 2019-03-05  Tom Tromey  <tromey@adacore.com>
7560
7561         * common/scoped_fd.h (class scoped_fd) <release>: Add
7562         ATTRIBUTE_UNUSED_RESULT.
7563
7564 2019-03-05  Tom Tromey  <tromey@adacore.com>
7565
7566         * parser-defs.h (struct parser_state) <release>: Add
7567         ATTRIBUTE_UNUSED_RESULT.
7568
7569 2019-03-05  Tom Tromey  <tromey@adacore.com>
7570
7571         * utils.h (class gdb_argv) <release>: Add
7572         ATTRIBUTE_UNUSED_RESULT.
7573         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7574
7575 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7576
7577         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7578         for-loop range, to avoid compiler warnings.
7579
7580         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7581         avoid compiler warnings about unused variables.
7582
7583         * NEWS: Mention end of support for native debugging on MS-Windows
7584         before XP.
7585
7586         PR gdb/24292
7587         * common/netstuff.c:
7588         * gdbserver/gdbreplay.c
7589         * gdbserver/remote-utils.c:
7590         * ser-tcp.c:
7591         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7592         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7593         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7594         'getaddrinfo' and 'freeaddrinfo' were not available before
7595         Windows XP, and mingw.org's MinGW headers by default define
7596         _WIN32_WINNT to 0x500.
7597
7598 2019-03-01  Gary Benson <gbenson@redhat.com>
7599
7600         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7601
7602 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7603             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7604
7605         PR gdb/8527
7606         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7607         set_sigint_trap, clear_sigint_trap.
7608
7609 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7610
7611         * target.c (target_detach): Clear the regcache and the
7612         frame cache.
7613
7614 2019-02-27  Pedro Alves  <palves@redhat.com>
7615
7616         * utils.c (set_screen_size): When we cap the height/width sizes,
7617         tweak the corresponding command variable to show "unlimited":
7618
7619 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7620             Pedro Alves  <palves@redhat.com>
7621
7622         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7623         before calling rl_set_screen_size.
7624
7625 2019-02-27  Tom Tromey  <tromey@adacore.com>
7626
7627         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7628         define.
7629         * python/py-value.c: Remove Python 2.4 workaround.
7630         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7631         workaround.
7632         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7633         Python 2.4 workaround.
7634         * python/python-internal.h: Remove Python 2.4 comment.
7635         (Py_ssize_t): Don't define.
7636         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7637         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7638         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7639         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7640         * python/python.c (do_start_initialization): Remove Python 2.4
7641         workaround.
7642         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7643         (print_children): Remove Python 2.4 workaround.
7644         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7645         workaround.
7646         (CHARBUFFERPROC_NAME): Remove.
7647         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7648         Python 2.4 workaround.
7649
7650 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7651
7652         * NEWS: Note minimum Python version.
7653
7654 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7655
7656         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7657         code from these functions.  Remove corresponding ifdefs.  Use
7658         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7659         Remove gotos and target of gotos.
7660         (infpy_search_memory): Likewise.
7661
7662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7663
7664         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7665         (hppa_gdbarch_init): Don't register deleted functions with
7666         gdbarch.
7667
7668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7671         (h8300_unwind_sp): Delete.
7672         (h8300_dummy_id): Delete.
7673         (h8300_gdbarch_init): Don't register deleted functions with
7674         gdbarch.
7675
7676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7679         (ft32_unwind_pc): Delete.
7680         (ft32_unwind_sp): Delete.
7681         (ft32_gdbarch_init): Don't register deleted functions with
7682         gdbarch.
7683
7684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7687         (frv_unwind_pc): Delete.
7688         (frv_unwind_sp): Delete.
7689         (frv_gdbarch_init): Don't register deleted functions with
7690         gdbarch.
7691
7692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7695         (riscv_unwind_pc): Delete.
7696         (riscv_unwind_sp): Delete.
7697         (riscv_gdbarch_init): Don't register deleted functions with
7698         gdbarch.
7699
7700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7701
7702         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7703         (csky_unwind_pc): Delete.
7704         (csky_unwind_sp): Delete.
7705         (csky_gdbarch_init): Don't register deleted functions with
7706         gdbarch.
7707
7708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7711         (cris_unwind_pc): Delete.
7712         (cris_unwind_sp): Delete.
7713         (cris_gdbarch_init): Don't register deleted functions with
7714         gdbarch.
7715
7716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7717
7718         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7719         (bfin_unwind_pc): Delete.
7720         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7721
7722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7725         (arm_unwind_pc): Delete.
7726         (arm_unwind_sp): Delete.
7727         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7728
7729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7730
7731         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7732         (arc_unwind_pc): Delete.
7733         (arc_unwind_sp): Delete.
7734         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7735
7736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7737
7738         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7739         (alpha_unwind_pc): Delete.
7740         (alpha_gdbarch_init): Don't register deleted functions with
7741         gdbarch.
7742
7743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7744
7745         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7746         (aarch64_unwind_pc): Delete.
7747         (aarch64_unwind_sp): Delete.
7748         (aarch64_gdbarch_init): Don't register deleted functions with
7749         gdbarch.
7750
7751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * gdbtypes.c (type_align): Don't consider static members when
7754         computing structure alignment.
7755
7756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7757
7758         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7759         return 0 for other types.
7760         * arch-utils.c (default_type_align): Always return 0.
7761         * gdbarch.h: Regenerate.
7762         * gdbarch.sh (type_align): Extend comment.
7763         * gdbtypes.c (type_align): Add additional comments, always call
7764         gdbarch_type_align before applying the default rules.
7765         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7766         generic code will then apply a suitable default.
7767         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7768         types, return 0 for other types.
7769
7770 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7771
7772         * NEWS: Create a new section for the next release branch.
7773         Rename the section of the current branch, now that it has
7774         been cut.
7775
7776 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7777
7778         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7779         * version.in: Bump version to 8.3.50.DATE-git.
7780
7781 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7782
7783         * aix-thread.c (ptid_cmp): Remove unused variable.
7784         (get_signaled_thread): Likewise.
7785         (store_regs_user_thread): Likewise.
7786         (store_regs_kernel_thread): Likewise.
7787         (fetch_regs_kernel_thread): Remove shadowed variable.
7788
7789 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * features/riscv/32bit-cpu.xml: Add register numbers.
7792         * features/riscv/32bit-fpu.c: Regenerate.
7793         * features/riscv/32bit-fpu.xml: Add register numbers.
7794         * features/riscv/64bit-cpu.xml: Add register numbers.
7795         * features/riscv/64bit-fpu.c: Regenerate.
7796         * features/riscv/64bit-fpu.xml: Add register numbers.
7797
7798 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7799
7800         * NEWS: Mention two argument form of gdb.Value constructor.
7801         * python/py-value.c (convert_buffer_and_type_to_value): New
7802         function.
7803         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7804         Add support for handling an optional second argument.  Call
7805         convert_buffer_and_type_to_value as appropriate.
7806         * python/python-internal.h (Py_buffer_deleter): New struct.
7807         (Py_buffer_up): New typedef.
7808
7809 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7810
7811         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7812         instead of releasing ownership.
7813
7814 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7815
7816         * dwarf2read.c (open_and_init_dwp_file): Call
7817         elf_numsections instead of bfd_count_sections to initialize
7818         dwp_file->num_sections.
7819
7820 2019-02-25  Tom Tromey  <tromey@adacore.com>
7821
7822         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7823
7824 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7825
7826         * gcore.in: Add '--readnever' option when invoking GDB.
7827
7828 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7829
7830         * MAINTAINERS: Update my email address.
7831
7832 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7833
7834         * build-id.c (build_id_to_debug_bfd_1): New function.
7835         (build_id_to_debug_bfd): Look for separate debug file in
7836         sysroot.
7837
7838 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7839
7840         * gdbarch.sh: Update the copyright year range that is placed into
7841         generated files.
7842
7843 2019-02-22  Keith Seitz  <keiths@redhat.com>
7844
7845         PR symtab/23853
7846         * linespec.c (create_sals_line_offset): Search for the default
7847         symtab's filename instead of its fullname.
7848
7849 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7850
7851         * NEWS: Update style defaults.
7852
7853 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7854
7855         * main.c (captured_main_1): Disable styling in batch mode.
7856
7857 2019-02-20  Tom Tromey  <tom@tromey.com>
7858
7859         * symtab.c (symtab_symbol_info): Fix typos.
7860
7861 2019-02-20  Tom Tromey  <tromey@adacore.com>
7862
7863         * findcmd.c (_initialize_mem_search): Use upper case for
7864         metasyntactic variables.
7865
7866 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7867
7868         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7869         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7870
7871 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7872
7873         * top.h (source_file_name): Change to std::string.
7874         * top.c (source_file_name): Likewise.
7875         (command_line_input): Adjust.
7876         * cli/cli-script.c (script_from_file): Adjust.
7877
7878 2019-02-19  Tom Tromey  <tromey@adacore.com>
7879
7880         * ravenscar-thread.c
7881         (ravenscar_thread_target::update_thread_list): Don't call
7882         ada_build_task_list.
7883         * ada-lang.h (ada_build_task_list): Don't declare.
7884         * ada-tasks.c (struct ada_tasks_inferior_data)
7885         <task_list_valid_p>: Now bool.
7886         (read_known_tasks, ada_task_list_changed)
7887         (ada_tasks_invalidate_inferior_data): Update.
7888         (read_known_tasks_array): Return bool.
7889         (read_known_tasks_list): Likewise.
7890         (read_known_tasks): Return void.
7891         (ada_build_task_list): Now static.
7892
7893 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7896         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7897
7898 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7899
7900         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7901         variant for ada_tasks_pspace_data_handle and
7902         ada_tasks_inferior_data_handle.
7903         (ada_tasks_pspace_data_cleanup): New function.
7904         (ada_tasks_inferior_data_cleanup): New function.
7905
7906 2019-02-17  Tom Tromey  <tom@tromey.com>
7907
7908         * macrotab.h (macro_source_fullname): Return a std::string.
7909         * macrotab.c (macro_include, check_for_redefinition)
7910         (macro_undef, macro_lookup_definition, foreach_macro)
7911         (foreach_macro_in_scope): Update.
7912         (macro_source_fullname): Return a std::string.
7913         * macrocmd.c (show_pp_source_pos): Update.
7914
7915 2019-02-17  Tom Tromey  <tom@tromey.com>
7916
7917         * macrocmd.c (show_pp_source_pos): Style the file names.
7918
7919 2019-02-17  Tom Tromey  <tom@tromey.com>
7920
7921         PR tui/24197:
7922         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7923
7924 2019-02-17  Tom Tromey  <tom@tromey.com>
7925
7926         * ada-lang.c (user_select_syms): Use filtered printing.
7927         * utils.c (wrap_style): New global.
7928         (desired_style): Remove.
7929         (emit_style_escape): Add stream parameter.
7930         (set_output_style, reset_terminal_style, prompt_for_continue):
7931         Update.
7932         (flush_wrap_buffer): Only flush gdb_stdout.
7933         (wrap_here): Set wrap_style.
7934         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7935         treat escape sequences as a character.  Change when wrap buffer is
7936         flushed.
7937         (fputs_styled): Do not set the output style when the default is
7938         requested.
7939         * ui-style.h (struct ui_file_style) <is_default>: New method.
7940         * source.c (print_source_lines_base): Emit escape sequences in one
7941         piece.
7942
7943 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7944
7945         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7946         integers and enumeration types.
7947
7948 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7949
7950         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7951         instead of lookup_symbol_in_language
7952         (do_exact_match): New function.
7953         (ada_get_symbol_name_matcher): Return do_exact_match when
7954         doing a verbatim match.
7955
7956 2019-02-15  Tom Tromey  <tromey@adacore.com>
7957
7958         * ravenscar-thread.c (ravenscar_thread_target::resume)
7959         (ravenscar_thread_target::wait): Special case wildcard requests.
7960
7961 2019-02-15  Tom Tromey  <tromey@adacore.com>
7962
7963         * ravenscar-thread.c (base_ptid): Remove.
7964         (struct ravenscar_thread_target) <close>: New method.
7965         <m_base_ptid>: New member.
7966         <update_inferior_ptid, active_task, task_is_currently_active,
7967         runtime_initialized>: Declare methods.
7968         <ravenscar_thread_target>: Add constructor.
7969         (ravenscar_thread_target::task_is_currently_active)
7970         (ravenscar_thread_target::update_inferior_ptid)
7971         (ravenscar_runtime_initialized): Rename.  Now methods.
7972         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7973         (ravenscar_thread_target::update_thread_list): Update.
7974         (ravenscar_thread_target::active_task): Now method.
7975         (ravenscar_thread_target::store_registers)
7976         (ravenscar_thread_target::prepare_to_store)
7977         (ravenscar_thread_target::prepare_to_store)
7978         (ravenscar_thread_target::mourn_inferior): Update.
7979         (ravenscar_inferior_created): Use "new" to create target.
7980         (ravenscar_thread_target::get_ada_task_ptid): Update.
7981         (_initialize_ravenscar): Don't initialize base_ptid.
7982         (ravenscar_ops): Remove global.
7983
7984 2019-02-15  Tom Tromey  <tromey@adacore.com>
7985
7986         * target.h (push_target): Declare new overload.
7987         * target.c (push_target): New overload, taking an rvalue reference.
7988         * remote.c (remote_target::open_1): Use push_target overload.
7989         * corelow.c (core_target_open): Use push_target overload.
7990
7991 2019-02-15  Tom Tromey  <tromey@adacore.com>
7992
7993         * ravenscar-thread.c (is_ravenscar_task)
7994         (ravenscar_task_is_currently_active): Return bool.
7995         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7996         (_initialize_ravenscar): Remove "(void)".
7997         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7998         Return bool.
7999
8000 2019-02-15  Tom Tromey  <tromey@adacore.com>
8001
8002         * ravenscar-thread.c (ravenscar_runtime_initializer)
8003         (has_ravenscar_runtime, get_running_thread_id)
8004         (ravenscar_thread_target::resume): Fix indentation.
8005
8006 2019-02-15  Tom Tromey  <tromey@adacore.com>
8007
8008         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8009         from ravenscar_arch_ops.
8010         (sparc_ravenscar_ops::fetch_registers)
8011         (sparc_ravenscar_ops::store_registers): Now methods.
8012         (sparc_ravenscar_prepare_to_store): Remove.
8013         (sparc_ravenscar_ops): Redefine.
8014         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8015         methods and destructor.  Remove members.
8016         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8017         (ravenscar_thread_target::store_registers)
8018         (ravenscar_thread_target::prepare_to_store): Update.
8019         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8020         Remove.
8021         (struct ppc_ravenscar_powerpc_ops): Derive from
8022         ravenscar_arch_ops.
8023         (ppc_ravenscar_powerpc_ops::fetch_registers)
8024         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8025         (ppc_ravenscar_powerpc_ops): Redefine.
8026         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8027         (ppc_ravenscar_e500_ops::fetch_registers)
8028         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8029         (ppc_ravenscar_e500_ops): Redefine.
8030         * aarch64-ravenscar-thread.c
8031         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8032         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8033         (aarch64_ravenscar_fetch_registers)
8034         (aarch64_ravenscar_store_registers): Now methods.
8035         (aarch64_ravenscar_ops): Redefine.
8036
8037 2019-02-15  Tom Tromey  <tromey@adacore.com>
8038
8039         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8040         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8041         (ravenscar_thread_target::stopped_by_watchpoint)
8042         (ravenscar_thread_target::stopped_data_address)
8043         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8044
8045 2019-02-15  Tom Tromey  <tromey@adacore.com>
8046
8047         * ravenscar-thread.c: Fix some typos.
8048
8049 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8050             Tom Tromey  <tromey@adacore.com>
8051
8052         * ada-lang.c (ada_exception_sal): Change addr_string to a
8053         std::string.
8054         (create_ada_exception_catchpoint): Update.
8055
8056 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8057             Tom Tromey  <tromey@adacore.com>
8058
8059         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8060         (bp_location_ops): Remove.
8061         (base_breakpoint_allocate_location): Update.
8062         (free_bp_location): Update.
8063         * ada-lang.c (class ada_catchpoint_location)
8064         <ada_catchpoint_location>: Remove ops parameter.
8065         (ada_catchpoint_location_dtor): Remove.
8066         (ada_catchpoint_location_ops): Remove.
8067         (allocate_location_exception): Update.
8068         * breakpoint.h (struct bp_location_ops): Remove.
8069         (class bp_location) <bp_location>: Remove bp_location_ops
8070         parameter.
8071         <~bp_location>: Add destructor.
8072         <ops>: Remove.
8073
8074 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8075             Pedro Alves  <palves@redhat.com>
8076
8077         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8078         'PATH_MAX'.
8079
8080 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8081             Samuel Thibault  <samuel.thibault@gnu.org>
8082             Thomas Schwinge  <thomas@codesourcery.com>
8083
8084         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8085         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8086
8087 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8088
8089         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8090         (check_empty): Use "const char *".
8091
8092         * gnu-nat.c (gnu_nat_target::detach): Instead of
8093         'detach_inferior (pid)' call
8094         'detach_inferior (find_inferior_pid (pid))'.
8095
8096         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8097         'nat/fork-inferior.o'.
8098         * gnu-nat.c: #include "nat/fork-inferior.h".
8099
8100         * gnu-nat.c (gnu_nat_target::detach): Instead of
8101         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8102         * gnu-nat.h: #include "inf-child.h".
8103         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8104         'i386_gnu_nat_target::fetch_registers'.
8105         (gnu_store_registers): Rename/move to
8106         'i386_gnu_nat_target::store_registers'.
8107
8108         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8109         * gnu-nat.h (mach_thread_info): New function.
8110         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8111
8112         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8113
8114 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8115
8116         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8117
8118 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8119
8120         * windows-nat.c (windows_add_thread): Add new parameter
8121         "main_thread_p" with default value set to false.  Update
8122         function documentation as well as all callers.
8123         (windows_delete_thread): Likewise.
8124         (fake_create_process): Update call to windows_add_thread.
8125         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8126         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8127         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8128         call to windows_delete_thread.
8129
8130 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8131
8132         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8133
8134 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8135
8136         * symfile.c (find_separate_debug_file): Use canonical path of
8137         sysroot with child_path instead of gdb_sysroot if it is valid.
8138
8139 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8140
8141         * symfile.c (find_separate_debug_file): Use child_path to
8142         determine if an object file is under a sysroot.
8143
8144 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8145
8146         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8147         unittests/child-path-selftests.c.
8148         * common/pathstuff.c (child_path): New function.
8149         * common/pathstuff.h (child_path): New prototype.
8150         * unittests/child-path-selftests.c: New file.
8151
8152 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8153
8154         * symfile.c (find_separate_debug_file): Look for separate debug
8155         files in debug directories under the sysroot.
8156
8157 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8158
8159         * symtab.h (struct minimal_symbol data_p): New const method.
8160         (struct minimal_symbol text_p): Likewise.
8161         * symtab.c (output_source_filename): Use file name style
8162         to print file name.
8163         (print_symbol_info): Likewise.
8164         (print_msymbol_info): Use address style to print addresses.
8165         Use function name style to print executable text symbols.
8166         (expand_symtab_containing_pc): Use data_p.
8167         (find_pc_sect_compunit_symtab): Likewise.
8168
8169 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8170
8171         * breakpoint.c (describe_other_breakpoints): Use address style
8172         to print addresses.
8173         (say_where): Likewise.
8174
8175 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8176
8177         * ada-typeprint.c (print_func_type): Print function name
8178         style to print function name.
8179         * c-typeprint.c (c_print_type_1): Likewise.
8180
8181 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8182
8183         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8184         for execve.
8185
8186 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8187
8188         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8189         type_stack.
8190
8191 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8192
8193         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8194         TYPE_CODE_REF types.
8195
8196 2019-02-08  Jim Wilson  <jimw@sifive.com>
8197
8198         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8199         (riscv_linux_fregset): New.
8200         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8201
8202 2019-02-07  Tom Tromey  <tom@tromey.com>
8203
8204         * thread.c (thread_cancel_execution_command): Update.
8205         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8206         methods.
8207         (struct thread_fsm_ops): Remove.
8208         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8209         (thread_fsm_should_stop, thread_fsm_return_value)
8210         (thread_fsm_set_finished, thread_fsm_finished_p)
8211         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8212         Don't declare.
8213         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8214         * infrun.c (clear_proceed_status_thread)
8215         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8216         (print_stop_event): Update.
8217         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8218         Add constructor.
8219         (step_command_fsm_ops): Remove.
8220         (new_step_command_fsm): Remove.
8221         (step_1): Update.
8222         (step_command_fsm::should_stop): Rename from
8223         step_command_fsm_should_stop.
8224         (step_command_fsm::clean_up): Rename from
8225         step_command_fsm_clean_up.
8226         (step_command_fsm::do_async_reply_reason): Rename from
8227         step_command_fsm_async_reply_reason.
8228         (struct until_next_fsm): Inherit from thread_fsm.  Add
8229         constructor.
8230         (until_next_fsm_ops): Remove.
8231         (new_until_next_fsm): Remove.
8232         (until_next_fsm::should_stop): Rename from
8233         until_next_fsm_should_stop.
8234         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8235         (until_next_fsm::do_async_reply_reason): Rename from
8236         until_next_fsm_async_reply_reason.
8237         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8238         constructor.  Change type of breakpoint.
8239         (finish_command_fsm_ops): Remove.
8240         (new_finish_command_fsm): Remove.
8241         (finish_command_fsm::should_stop): Rename from
8242         finish_command_fsm_should_stop.
8243         (finish_command_fsm::clean_up): Rename from
8244         finish_command_fsm_clean_up.
8245         (finish_command_fsm::return_value): Rename from
8246         finish_command_fsm_return_value.
8247         (finish_command_fsm::do_async_reply_reason): Rename from
8248         finish_command_fsm_async_reply_reason.
8249         (finish_command): Update.
8250         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8251         Add constructor.
8252         (call_thread_fsm_ops): Remove.
8253         (call_thread_fsm::call_thread_fsm): Rename from
8254         new_call_thread_fsm.
8255         (call_thread_fsm::should_stop): Rename from
8256         call_thread_fsm_should_stop.
8257         (call_thread_fsm::should_notify_stop): Rename from
8258         call_thread_fsm_should_notify_stop.
8259         (run_inferior_call, call_function_by_hand_dummy): Update.
8260         * cli/cli-interp.c (should_print_stop_to_console): Update.
8261         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8262         Add constructor.  Change type of location_breakpoint,
8263         caller_breakpoint.
8264         (until_break_fsm_ops): Remove.
8265         (new_until_break_fsm): Remove.
8266         (until_break_fsm::should_stop): Rename from
8267         until_break_fsm_should_stop.
8268         (until_break_fsm::clean_up): Rename from
8269         until_break_fsm_clean_up.
8270         (until_break_fsm::do_async_reply_reason): Rename from
8271         until_break_fsm_async_reply_reason.
8272         (until_break_command): Update.
8273         * thread-fsm.c: Remove.
8274         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8275
8276 2019-02-07  Tom Tromey  <tom@tromey.com>
8277
8278         * yy-remap.h: Add include guard.
8279         * xtensa-tdep.h: Add include guard.
8280         * xcoffread.h: Rename include guard.
8281         * varobj-iter.h: Add include guard.
8282         * tui/tui.h: Rename include guard.
8283         * tui/tui-winsource.h: Rename include guard.
8284         * tui/tui-wingeneral.h: Rename include guard.
8285         * tui/tui-windata.h: Rename include guard.
8286         * tui/tui-win.h: Rename include guard.
8287         * tui/tui-stack.h: Rename include guard.
8288         * tui/tui-source.h: Rename include guard.
8289         * tui/tui-regs.h: Rename include guard.
8290         * tui/tui-out.h: Rename include guard.
8291         * tui/tui-layout.h: Rename include guard.
8292         * tui/tui-io.h: Rename include guard.
8293         * tui/tui-hooks.h: Rename include guard.
8294         * tui/tui-file.h: Rename include guard.
8295         * tui/tui-disasm.h: Rename include guard.
8296         * tui/tui-data.h: Rename include guard.
8297         * tui/tui-command.h: Rename include guard.
8298         * tic6x-tdep.h: Add include guard.
8299         * target/waitstatus.h: Rename include guard.
8300         * target/wait.h: Rename include guard.
8301         * target/target.h: Rename include guard.
8302         * target/resume.h: Rename include guard.
8303         * target-float.h: Rename include guard.
8304         * stabsread.h: Add include guard.
8305         * rs6000-tdep.h: Add include guard.
8306         * riscv-fbsd-tdep.h: Add include guard.
8307         * regformats/regdef.h: Rename include guard.
8308         * record.h: Rename include guard.
8309         * python/python.h: Rename include guard.
8310         * python/python-internal.h: Rename include guard.
8311         * python/py-stopevent.h: Rename include guard.
8312         * python/py-ref.h: Rename include guard.
8313         * python/py-record.h: Rename include guard.
8314         * python/py-record-full.h: Rename include guard.
8315         * python/py-record-btrace.h: Rename include guard.
8316         * python/py-instruction.h: Rename include guard.
8317         * python/py-events.h: Rename include guard.
8318         * python/py-event.h: Rename include guard.
8319         * procfs.h: Add include guard.
8320         * proc-utils.h: Add include guard.
8321         * p-lang.h: Add include guard.
8322         * or1k-tdep.h: Rename include guard.
8323         * observable.h: Rename include guard.
8324         * nto-tdep.h: Rename include guard.
8325         * nat/x86-linux.h: Rename include guard.
8326         * nat/x86-linux-dregs.h: Rename include guard.
8327         * nat/x86-gcc-cpuid.h: Add include guard.
8328         * nat/x86-dregs.h: Rename include guard.
8329         * nat/x86-cpuid.h: Rename include guard.
8330         * nat/ppc-linux.h: Rename include guard.
8331         * nat/mips-linux-watch.h: Rename include guard.
8332         * nat/linux-waitpid.h: Rename include guard.
8333         * nat/linux-ptrace.h: Rename include guard.
8334         * nat/linux-procfs.h: Rename include guard.
8335         * nat/linux-osdata.h: Rename include guard.
8336         * nat/linux-nat.h: Rename include guard.
8337         * nat/linux-namespaces.h: Rename include guard.
8338         * nat/linux-btrace.h: Rename include guard.
8339         * nat/glibc_thread_db.h: Rename include guard.
8340         * nat/gdb_thread_db.h: Rename include guard.
8341         * nat/gdb_ptrace.h: Rename include guard.
8342         * nat/fork-inferior.h: Rename include guard.
8343         * nat/amd64-linux-siginfo.h: Rename include guard.
8344         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8345         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8346         * nat/aarch64-linux.h: Rename include guard.
8347         * nat/aarch64-linux-hw-point.h: Rename include guard.
8348         * mn10300-tdep.h: Add include guard.
8349         * mips-linux-tdep.h: Add include guard.
8350         * mi/mi-parse.h: Rename include guard.
8351         * mi/mi-out.h: Rename include guard.
8352         * mi/mi-main.h: Rename include guard.
8353         * mi/mi-interp.h: Rename include guard.
8354         * mi/mi-getopt.h: Rename include guard.
8355         * mi/mi-console.h: Rename include guard.
8356         * mi/mi-common.h: Rename include guard.
8357         * mi/mi-cmds.h: Rename include guard.
8358         * mi/mi-cmd-break.h: Rename include guard.
8359         * m2-lang.h: Add include guard.
8360         * location.h: Rename include guard.
8361         * linux-record.h: Rename include guard.
8362         * linux-nat.h: Add include guard.
8363         * linux-fork.h: Add include guard.
8364         * i386-darwin-tdep.h: Rename include guard.
8365         * hppa-linux-offsets.h: Add include guard.
8366         * guile/guile.h: Rename include guard.
8367         * guile/guile-internal.h: Rename include guard.
8368         * gnu-nat.h: Rename include guard.
8369         * gdb-stabs.h: Rename include guard.
8370         * frv-tdep.h: Add include guard.
8371         * f-lang.h: Add include guard.
8372         * event-loop.h: Add include guard.
8373         * darwin-nat.h: Rename include guard.
8374         * cp-abi.h: Rename include guard.
8375         * config/sparc/nm-sol2.h: Rename include guard.
8376         * config/nm-nto.h: Rename include guard.
8377         * config/nm-linux.h: Add include guard.
8378         * config/i386/nm-i386gnu.h: Rename include guard.
8379         * config/djgpp/nl_types.h: Rename include guard.
8380         * config/djgpp/langinfo.h: Rename include guard.
8381         * compile/gcc-cp-plugin.h: Add include guard.
8382         * compile/gcc-c-plugin.h: Add include guard.
8383         * compile/compile.h: Rename include guard.
8384         * compile/compile-object-run.h: Rename include guard.
8385         * compile/compile-object-load.h: Rename include guard.
8386         * compile/compile-internal.h: Rename include guard.
8387         * compile/compile-cplus.h: Rename include guard.
8388         * compile/compile-c.h: Rename include guard.
8389         * common/xml-utils.h: Rename include guard.
8390         * common/x86-xstate.h: Rename include guard.
8391         * common/version.h: Rename include guard.
8392         * common/vec.h: Rename include guard.
8393         * common/tdesc.h: Rename include guard.
8394         * common/selftest.h: Rename include guard.
8395         * common/scoped_restore.h: Rename include guard.
8396         * common/scoped_mmap.h: Rename include guard.
8397         * common/scoped_fd.h: Rename include guard.
8398         * common/safe-iterator.h: Rename include guard.
8399         * common/run-time-clock.h: Rename include guard.
8400         * common/refcounted-object.h: Rename include guard.
8401         * common/queue.h: Rename include guard.
8402         * common/ptid.h: Rename include guard.
8403         * common/print-utils.h: Rename include guard.
8404         * common/preprocessor.h: Rename include guard.
8405         * common/pathstuff.h: Rename include guard.
8406         * common/observable.h: Rename include guard.
8407         * common/netstuff.h: Rename include guard.
8408         * common/job-control.h: Rename include guard.
8409         * common/host-defs.h: Rename include guard.
8410         * common/gdb_wait.h: Rename include guard.
8411         * common/gdb_vecs.h: Rename include guard.
8412         * common/gdb_unlinker.h: Rename include guard.
8413         * common/gdb_unique_ptr.h: Rename include guard.
8414         * common/gdb_tilde_expand.h: Rename include guard.
8415         * common/gdb_sys_time.h: Rename include guard.
8416         * common/gdb_string_view.h: Rename include guard.
8417         * common/gdb_splay_tree.h: Rename include guard.
8418         * common/gdb_setjmp.h: Rename include guard.
8419         * common/gdb_ref_ptr.h: Rename include guard.
8420         * common/gdb_optional.h: Rename include guard.
8421         * common/gdb_locale.h: Rename include guard.
8422         * common/gdb_assert.h: Rename include guard.
8423         * common/filtered-iterator.h: Rename include guard.
8424         * common/filestuff.h: Rename include guard.
8425         * common/fileio.h: Rename include guard.
8426         * common/environ.h: Rename include guard.
8427         * common/common-utils.h: Rename include guard.
8428         * common/common-types.h: Rename include guard.
8429         * common/common-regcache.h: Rename include guard.
8430         * common/common-inferior.h: Rename include guard.
8431         * common/common-gdbthread.h: Rename include guard.
8432         * common/common-exceptions.h: Rename include guard.
8433         * common/common-defs.h: Rename include guard.
8434         * common/common-debug.h: Rename include guard.
8435         * common/cleanups.h: Rename include guard.
8436         * common/buffer.h: Rename include guard.
8437         * common/btrace-common.h: Rename include guard.
8438         * common/break-common.h: Rename include guard.
8439         * cli/cli-utils.h: Rename include guard.
8440         * cli/cli-style.h: Rename include guard.
8441         * cli/cli-setshow.h: Rename include guard.
8442         * cli/cli-script.h: Rename include guard.
8443         * cli/cli-interp.h: Rename include guard.
8444         * cli/cli-decode.h: Rename include guard.
8445         * cli/cli-cmds.h: Rename include guard.
8446         * charset-list.h: Add include guard.
8447         * buildsym-legacy.h: Rename include guard.
8448         * bfin-tdep.h: Add include guard.
8449         * ax.h: Rename include guard.
8450         * arm-linux-tdep.h: Add include guard.
8451         * arm-fbsd-tdep.h: Add include guard.
8452         * arch/xtensa.h: Rename include guard.
8453         * arch/tic6x.h: Add include guard.
8454         * arch/i386.h: Add include guard.
8455         * arch/arm.h: Rename include guard.
8456         * arch/arm-linux.h: Rename include guard.
8457         * arch/arm-get-next-pcs.h: Rename include guard.
8458         * arch/amd64.h: Add include guard.
8459         * arch/aarch64-insn.h: Rename include guard.
8460         * arch-utils.h: Rename include guard.
8461         * annotate.h: Add include guard.
8462         * amd64-darwin-tdep.h: Rename include guard.
8463         * aarch64-linux-tdep.h: Add include guard.
8464         * aarch64-fbsd-tdep.h: Add include guard.
8465         * aarch32-linux-nat.h: Add include guard.
8466
8467 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8468
8469         * macrotab.c (macro_define_internal): New function that
8470         factorizes macro_define_object_internal and macro_define_function
8471         code.
8472         (macro_define_object_internal): Use macro_define_internal.
8473         (macro_define_function): Likewise.
8474
8475 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8476
8477         * macrocmd.c (extract_identifier): Return
8478         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8479         callers.
8480
8481 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8482
8483         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8484
8485 2019-02-05  Tom Tromey  <tom@tromey.com>
8486
8487         * target.c (target_stack::unpush): Move assertion earlier.
8488
8489 2019-01-30  Tom Tromey  <tom@tromey.com>
8490
8491         PR python/23615:
8492         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8493         (gdbpy_parse_and_eval): Likewise.
8494         * python/python-internal.h (gdbpy_allow_threads): New class.
8495
8496 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8497
8498         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8499         (aarch64_fbsd_fpregmap): Move earlier.
8500         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8501         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8502         instead of individual calls to trad_frame_set_reg_addr.
8503         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8504         earlier.
8505         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8506         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8507         instead of individual calls to trad_frame_set_reg_addr.
8508
8509 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8510
8511         * CONTRIBUTE: Replace contribution list with wiki link.
8512
8513 2019-01-25  Tom Tromey  <tom@tromey.com>
8514
8515         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8516
8517 2019-01-25  Tom Tromey  <tom@tromey.com>
8518
8519         * xtensa-linux-nat.c: Fix common/ includes.
8520         * xml-support.h: Fix common/ includes.
8521         * xml-support.c: Fix common/ includes.
8522         * x86-linux-nat.c: Fix common/ includes.
8523         * windows-nat.c: Fix common/ includes.
8524         * varobj.h: Fix common/ includes.
8525         * varobj.c: Fix common/ includes.
8526         * value.c: Fix common/ includes.
8527         * valops.c: Fix common/ includes.
8528         * utils.c: Fix common/ includes.
8529         * unittests/xml-utils-selftests.c: Fix common/ includes.
8530         * unittests/utils-selftests.c: Fix common/ includes.
8531         * unittests/unpack-selftests.c: Fix common/ includes.
8532         * unittests/tracepoint-selftests.c: Fix common/ includes.
8533         * unittests/style-selftests.c: Fix common/ includes.
8534         * unittests/string_view-selftests.c: Fix common/ includes.
8535         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8536         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8537         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8538         * unittests/rsp-low-selftests.c: Fix common/ includes.
8539         * unittests/parse-connection-spec-selftests.c: Fix common/
8540         includes.
8541         * unittests/optional-selftests.c: Fix common/ includes.
8542         * unittests/offset-type-selftests.c: Fix common/ includes.
8543         * unittests/observable-selftests.c: Fix common/ includes.
8544         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8545         * unittests/memrange-selftests.c: Fix common/ includes.
8546         * unittests/memory-map-selftests.c: Fix common/ includes.
8547         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8548         * unittests/function-view-selftests.c: Fix common/ includes.
8549         * unittests/environ-selftests.c: Fix common/ includes.
8550         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8551         * unittests/common-utils-selftests.c: Fix common/ includes.
8552         * unittests/cli-utils-selftests.c: Fix common/ includes.
8553         * unittests/array-view-selftests.c: Fix common/ includes.
8554         * ui-file.c: Fix common/ includes.
8555         * tui/tui-io.c: Fix common/ includes.
8556         * tracepoint.h: Fix common/ includes.
8557         * tracepoint.c: Fix common/ includes.
8558         * tracefile-tfile.c: Fix common/ includes.
8559         * top.h: Fix common/ includes.
8560         * top.c: Fix common/ includes.
8561         * thread.c: Fix common/ includes.
8562         * target/waitstatus.h: Fix common/ includes.
8563         * target/waitstatus.c: Fix common/ includes.
8564         * target.h: Fix common/ includes.
8565         * target.c: Fix common/ includes.
8566         * target-memory.c: Fix common/ includes.
8567         * target-descriptions.c: Fix common/ includes.
8568         * symtab.h: Fix common/ includes.
8569         * symfile.c: Fix common/ includes.
8570         * stap-probe.c: Fix common/ includes.
8571         * spu-linux-nat.c: Fix common/ includes.
8572         * sparc-nat.c: Fix common/ includes.
8573         * source.c: Fix common/ includes.
8574         * solib.c: Fix common/ includes.
8575         * solib-target.c: Fix common/ includes.
8576         * ser-unix.c: Fix common/ includes.
8577         * ser-tcp.c: Fix common/ includes.
8578         * ser-pipe.c: Fix common/ includes.
8579         * ser-base.c: Fix common/ includes.
8580         * selftest-arch.c: Fix common/ includes.
8581         * s12z-tdep.c: Fix common/ includes.
8582         * rust-exp.y: Fix common/ includes.
8583         * rs6000-aix-tdep.c: Fix common/ includes.
8584         * riscv-tdep.c: Fix common/ includes.
8585         * remote.c: Fix common/ includes.
8586         * remote-notif.h: Fix common/ includes.
8587         * remote-fileio.h: Fix common/ includes.
8588         * remote-fileio.c: Fix common/ includes.
8589         * regcache.h: Fix common/ includes.
8590         * regcache.c: Fix common/ includes.
8591         * record-btrace.c: Fix common/ includes.
8592         * python/python.c: Fix common/ includes.
8593         * python/py-type.c: Fix common/ includes.
8594         * python/py-inferior.c: Fix common/ includes.
8595         * progspace.h: Fix common/ includes.
8596         * producer.c: Fix common/ includes.
8597         * procfs.c: Fix common/ includes.
8598         * proc-api.c: Fix common/ includes.
8599         * printcmd.c: Fix common/ includes.
8600         * ppc-linux-nat.c: Fix common/ includes.
8601         * parser-defs.h: Fix common/ includes.
8602         * osdata.c: Fix common/ includes.
8603         * obsd-nat.c: Fix common/ includes.
8604         * nat/x86-linux.c: Fix common/ includes.
8605         * nat/x86-linux-dregs.c: Fix common/ includes.
8606         * nat/x86-dregs.h: Fix common/ includes.
8607         * nat/x86-dregs.c: Fix common/ includes.
8608         * nat/ppc-linux.c: Fix common/ includes.
8609         * nat/mips-linux-watch.h: Fix common/ includes.
8610         * nat/mips-linux-watch.c: Fix common/ includes.
8611         * nat/linux-waitpid.c: Fix common/ includes.
8612         * nat/linux-ptrace.h: Fix common/ includes.
8613         * nat/linux-ptrace.c: Fix common/ includes.
8614         * nat/linux-procfs.c: Fix common/ includes.
8615         * nat/linux-personality.c: Fix common/ includes.
8616         * nat/linux-osdata.c: Fix common/ includes.
8617         * nat/linux-namespaces.c: Fix common/ includes.
8618         * nat/linux-btrace.h: Fix common/ includes.
8619         * nat/linux-btrace.c: Fix common/ includes.
8620         * nat/fork-inferior.c: Fix common/ includes.
8621         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8622         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8623         * nat/aarch64-linux.c: Fix common/ includes.
8624         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8625         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8626         * namespace.h: Fix common/ includes.
8627         * mips-linux-tdep.c: Fix common/ includes.
8628         * minsyms.c: Fix common/ includes.
8629         * mi/mi-parse.h: Fix common/ includes.
8630         * mi/mi-main.c: Fix common/ includes.
8631         * mi/mi-cmd-env.c: Fix common/ includes.
8632         * memrange.h: Fix common/ includes.
8633         * memattr.c: Fix common/ includes.
8634         * maint.h: Fix common/ includes.
8635         * maint.c: Fix common/ includes.
8636         * main.c: Fix common/ includes.
8637         * machoread.c: Fix common/ includes.
8638         * location.c: Fix common/ includes.
8639         * linux-thread-db.c: Fix common/ includes.
8640         * linux-nat.c: Fix common/ includes.
8641         * linux-fork.c: Fix common/ includes.
8642         * inline-frame.c: Fix common/ includes.
8643         * infrun.c: Fix common/ includes.
8644         * inflow.c: Fix common/ includes.
8645         * inferior.h: Fix common/ includes.
8646         * inferior.c: Fix common/ includes.
8647         * infcmd.c: Fix common/ includes.
8648         * inf-ptrace.c: Fix common/ includes.
8649         * inf-child.c: Fix common/ includes.
8650         * ia64-linux-nat.c: Fix common/ includes.
8651         * i387-tdep.c: Fix common/ includes.
8652         * i386-tdep.c: Fix common/ includes.
8653         * i386-linux-tdep.c: Fix common/ includes.
8654         * i386-linux-nat.c: Fix common/ includes.
8655         * i386-go32-tdep.c: Fix common/ includes.
8656         * i386-fbsd-tdep.c: Fix common/ includes.
8657         * i386-fbsd-nat.c: Fix common/ includes.
8658         * guile/scm-type.c: Fix common/ includes.
8659         * guile/guile.c: Fix common/ includes.
8660         * go32-nat.c: Fix common/ includes.
8661         * gnu-nat.c: Fix common/ includes.
8662         * gdbthread.h: Fix common/ includes.
8663         * gdbarch-selftests.c: Fix common/ includes.
8664         * gdb_usleep.c: Fix common/ includes.
8665         * gdb_select.h: Fix common/ includes.
8666         * gdb_bfd.c: Fix common/ includes.
8667         * gcore.c: Fix common/ includes.
8668         * fork-child.c: Fix common/ includes.
8669         * findvar.c: Fix common/ includes.
8670         * fbsd-nat.c: Fix common/ includes.
8671         * event-top.c: Fix common/ includes.
8672         * event-loop.c: Fix common/ includes.
8673         * dwarf2read.c: Fix common/ includes.
8674         * dwarf2loc.c: Fix common/ includes.
8675         * dwarf2-frame.c: Fix common/ includes.
8676         * dwarf-index-cache.c: Fix common/ includes.
8677         * dtrace-probe.c: Fix common/ includes.
8678         * disasm-selftests.c: Fix common/ includes.
8679         * defs.h: Fix common/ includes.
8680         * csky-tdep.c: Fix common/ includes.
8681         * cp-valprint.c: Fix common/ includes.
8682         * cp-support.h: Fix common/ includes.
8683         * cp-support.c: Fix common/ includes.
8684         * corelow.c: Fix common/ includes.
8685         * completer.h: Fix common/ includes.
8686         * completer.c: Fix common/ includes.
8687         * compile/compile.c: Fix common/ includes.
8688         * compile/compile-loc2c.c: Fix common/ includes.
8689         * compile/compile-cplus-types.c: Fix common/ includes.
8690         * compile/compile-cplus-symbols.c: Fix common/ includes.
8691         * command.h: Fix common/ includes.
8692         * cli/cli-dump.c: Fix common/ includes.
8693         * cli/cli-cmds.c: Fix common/ includes.
8694         * charset.c: Fix common/ includes.
8695         * build-id.c: Fix common/ includes.
8696         * btrace.h: Fix common/ includes.
8697         * btrace.c: Fix common/ includes.
8698         * breakpoint.h: Fix common/ includes.
8699         * breakpoint.c: Fix common/ includes.
8700         * ax.h:
8701         (enum agent_op): Fix common/ includes.
8702         * ax-general.c (struct aop_map): Fix common/ includes.
8703         * ax-gdb.c: Fix common/ includes.
8704         * auxv.c: Fix common/ includes.
8705         * auto-load.c: Fix common/ includes.
8706         * arm-tdep.c: Fix common/ includes.
8707         * arch/riscv.c: Fix common/ includes.
8708         * arch/ppc-linux-common.c: Fix common/ includes.
8709         * arch/i386.c: Fix common/ includes.
8710         * arch/arm.c: Fix common/ includes.
8711         * arch/arm-linux.c: Fix common/ includes.
8712         * arch/arm-get-next-pcs.c: Fix common/ includes.
8713         * arch/amd64.c: Fix common/ includes.
8714         * arch/aarch64.c: Fix common/ includes.
8715         * arch/aarch64-insn.c: Fix common/ includes.
8716         * arch-utils.c: Fix common/ includes.
8717         * amd64-windows-tdep.c: Fix common/ includes.
8718         * amd64-tdep.c: Fix common/ includes.
8719         * amd64-sol2-tdep.c: Fix common/ includes.
8720         * amd64-obsd-tdep.c: Fix common/ includes.
8721         * amd64-nbsd-tdep.c: Fix common/ includes.
8722         * amd64-linux-tdep.c: Fix common/ includes.
8723         * amd64-linux-nat.c: Fix common/ includes.
8724         * amd64-fbsd-tdep.c: Fix common/ includes.
8725         * amd64-fbsd-nat.c: Fix common/ includes.
8726         * amd64-dicos-tdep.c: Fix common/ includes.
8727         * amd64-darwin-tdep.c: Fix common/ includes.
8728         * agent.c: Fix common/ includes.
8729         * ada-lang.h: Fix common/ includes.
8730         * ada-lang.c: Fix common/ includes.
8731         * aarch64-tdep.c: Fix common/ includes.
8732
8733 2019-01-25  Tom Tromey  <tom@tromey.com>
8734
8735         * common/create-version.sh: Use common/version.h.
8736
8737 2019-01-24  Pedro Alves  <palves@redhat.com>
8738
8739         * infrun.c (signal_stop, signal_print, signal_program)
8740         (signal_catch, signal_pass): Now arrays instead of pointers.
8741         (update_signals_program_target, do_target_resume)
8742         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8743         * linux-nat.c (linux_nat_target::pass_signals)
8744         (linux_nat_target::create_inferior, linux_nat_target::attach):
8745         Adjust.
8746         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8747         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8748         * procfs.c (procfs_target::pass_signals): Adjust.
8749         * record-full.c (record_full_target::resume): Adjust.
8750         * remote.c (remote_target::pass_signals)
8751         (remote_target::program_signals): Adjust.
8752         * target-debug.h (target_debug_print_signals): Now takes a
8753         gdb::array_view as parameter.  Adjust.
8754         * target.h (target_ops) <pass_signals, program_signals>: Replace
8755         pointer and length parameters with gdb::array_view.
8756         (target_pass_signals, target_program_signals): Likewise.
8757         * target-delegates.c: Regenerate.
8758
8759 2019-01-24  Pedro Alves  <palves@redhat.com>
8760
8761         * common/forward-scope-exit.h
8762         (forward_scope_exit::forward_scope_exit): Pass arguments to
8763         m_bind_function directly, instead of creating a std::bind and
8764         copying that.
8765
8766 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8767
8768         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8769         for static members.
8770         (pass_in_v_vfp_candidate): Likewise.
8771
8772 2019-01-23  Tom Tromey  <tom@tromey.com>
8773             Pedro Alves  <palves@redhat.com>
8774
8775         * regcache.c (class regcache_invalidator): Remove.
8776         (regcache::raw_write): Use make_scope_exit.
8777
8778 2019-01-23  Tom Tromey  <tom@tromey.com>
8779
8780         * ui-out.h (class ui_out_emit_type): Update comment.
8781
8782 2019-01-23  Tom Tromey  <tom@tromey.com>
8783
8784         * infrun.c (fetch_inferior_event): Update comment.
8785
8786 2019-01-23  Tom Tromey  <tom@tromey.com>
8787             Pedro Alves  <palves@redhat.com>
8788
8789         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8790         parameter.
8791         (fetch_inferior_event): Use SCOPE_EXIT.
8792
8793
8794 2019-01-23  Tom Tromey  <tom@tromey.com>
8795             Pedro Alves  <palves@redhat.com>
8796
8797         * infrun.c (disable_thread_events): Delete.
8798         (stop_all_threads): Use SCOPE_EXIT.
8799
8800 2019-01-23  Tom Tromey  <tom@tromey.com>
8801             Pedro Alves  <palves@redhat.com>
8802
8803         * symfile.c: Include forward-scope-exit.h.
8804         (clear_symtab_users_cleanup): Replace forward declaration with
8805         a FORWARD_SCOPE_EXIT.
8806         (syms_from_objfile_1): Use the forward_scope_exit and
8807         gdb::optional instead of cleanup_function.
8808         (reread_symbols): Use the forward_scope_exit instead of
8809         cleanup_function.
8810         (clear_symtab_users_cleanup): Remove function.
8811
8812 2019-01-23  Tom Tromey  <tom@tromey.com>
8813             Pedro Alves  <palves@redhat.com>
8814
8815         * linux-nat.c: Include scope-exit.h.
8816         (cleanup_target_stop): Remove.
8817         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8818         SCOPE_EXIT.
8819
8820 2019-01-23  Tom Tromey  <tom@tromey.com>
8821             Pedro Alves  <palves@redhat.com>
8822
8823         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8824         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8825
8826 2019-01-23  Tom Tromey  <tom@tromey.com>
8827             Andrew Burgess  <andrew.burgess@embecosm.com>
8828             Pedro Alves  <palves@redhat.com>
8829
8830         * infrun.c (fetch_inferior_event): Use scope_exit.
8831         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8832         * top.c (execute_command): Use scope_exit.
8833         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8834         * utils.c (do_bpstat_clear_actions_cleanup)
8835         (make_bpstat_clear_actions_cleanup): Remove.
8836
8837 2019-01-23  Tom Tromey  <tom@tromey.com>
8838             Pedro Alves  <palves@redhat.com>
8839
8840         * infrun.c: Include "common/scope-exit.h"
8841         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8842         (wait_for_inferior): Use SCOPE_EXIT.
8843         (fetch_inferior_event): Use scope_exit.
8844
8845 2019-01-23  Tom Tromey  <tom@tromey.com>
8846             Pedro Alves  <palves@redhat.com>
8847
8848         * breakpoint.c (create_breakpoint): Remove cleanup.
8849
8850 2019-01-23  Tom Tromey  <tom@tromey.com>
8851             Andrew Burgess  <andrew.burgess@embecosm.com>
8852             Pedro Alves  <palves@redhat.com>
8853
8854 2019-01-23  Pedro Alves  <palves@redhat.com>
8855
8856         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8857
8858 2019-01-23  Pedro Alves  <palves@redhat.com>
8859             Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * gdbthread.h: Include "common/forward-scope-exit.h".
8862         (scoped_finish_thread_state): Redefine custom class in terms of
8863         forward_scope_exit.
8864
8865 2019-01-23  Pedro Alves  <palves@redhat.com>
8866             Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * common/forward-scope-exit.h: New file.
8869
8870 2019-01-23  Pedro Alves  <palves@redhat.com>
8871             Andrew Burgess  <andrew.burgess@embecosm.com>
8872             Tom Tromey  <tom@tromey.com>
8873
8874         * common/scope-exit.h: New file.
8875
8876 2019-01-23  Pedro Alves  <palves@redhat.com>
8877
8878         * common/preprocessor.h (ESC): Rename to ...
8879         (ESC_PARENS): ... this.
8880         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8881         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8882
8883 2019-01-23  Tom Tromey  <tom@tromey.com>
8884
8885         * language.h (class scoped_switch_to_sym_language_if_auto):
8886         Initialize m_lang in both cases.
8887
8888 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8889
8890         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8891         with XCNEW.
8892
8893 2019-01-22  Tom Tromey  <tom@tromey.com>
8894
8895         * corelow.c: Do not include sys/file.h.
8896
8897 2019-01-22  Tom Tromey  <tom@tromey.com>
8898
8899         * tui/tui-wingeneral.h: Include gdb_curses.h.
8900
8901 2019-01-22  Tom Tromey  <tom@tromey.com>
8902
8903         * source-cache.h (class source_cache) <get_source_lines,
8904         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8905
8906 2019-01-22  Tom Tromey  <tom@tromey.com>
8907
8908         * remote-fileio.h (struct remote_target): Declare.
8909
8910 2019-01-22  Tom Tromey  <tom@tromey.com>
8911
8912         * python/py-arch.c: Do not include py-ref.h.
8913         * python/py-bpevent.c: Do not include py-ref.h.
8914         * python/py-cmd.c: Do not include py-ref.h.
8915         * python/py-continueevent.c: Do not include py-ref.h.
8916         * python/py-event.h: Do not include py-ref.h.
8917         * python/py-evtregistry.c: Do not include py-ref.h.
8918         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8919         * python/py-frame.c: Do not include py-ref.h.
8920         * python/py-framefilter.c: Do not include py-ref.h.
8921         * python/py-function.c: Do not include py-ref.h.
8922         * python/py-infevents.c: Do not include py-ref.h.
8923         * python/py-linetable.c: Do not include py-ref.h.
8924         * python/py-objfile.c: Do not include py-ref.h.
8925         * python/py-param.c: Do not include py-ref.h.
8926         * python/py-prettyprint.c: Do not include py-ref.h.
8927         * python/py-progspace.c: Do not include py-ref.h.
8928         * python/py-symbol.c: Do not include py-ref.h.
8929         * python/py-symtab.c: Do not include py-ref.h.
8930         * python/py-type.c: Do not include py-ref.h.
8931         * python/py-unwind.c: Do not include py-ref.h.
8932         * python/py-utils.c: Do not include py-ref.h.
8933         * python/py-value.c: Do not include py-ref.h.
8934         * python/py-varobj.c: Do not include py-ref.h.
8935         * python/py-xmethods.c: Do not include py-ref.h.
8936         * python/python.c: Do not include py-ref.h.
8937         * varobj.c: Do not include py-ref.h.
8938
8939 2019-01-22  Tom Tromey  <tom@tromey.com>
8940
8941         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8942         keyword for bcache.
8943
8944 2019-01-22  Tom Tromey  <tom@tromey.com>
8945
8946         * compile/compile-cplus-types.c: Remove a comment by #include.
8947
8948 2019-01-22  Tom Tromey  <tom@tromey.com>
8949
8950         * compile/gcc-c-plugin.h: Include compile-internal.h.
8951
8952 2019-01-22  Tom Tromey  <tom@tromey.com>
8953
8954         * stabsread.c (EXTERN): Do not define.
8955         (symnum, next_symbol_text_func, processing_gcc_compilation)
8956         (within_function, global_sym_chain, global_stabs)
8957         (previous_stab_code, this_object_header_files)
8958         (n_this_object_header_files)
8959         (n_allocated_this_object_header_files): Define.
8960         * stabsread.h (EXTERN): Never define.  Use "extern".
8961
8962 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8963
8964         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8965         history_value.
8966
8967 2019-01-21  Tom Tromey  <tom@tromey.com>
8968
8969         * ui-out.c: Fix includes.
8970         * tui/tui-source.c: Fix includes.
8971         * target.c: Fix includes.
8972         * remote.c: Fix includes.
8973         * regcache.c: Fix includes.
8974         * python/py-block.c: Fix includes.
8975         * printcmd.c: Fix includes.
8976         * or1k-tdep.c: Fix includes.
8977         * mi/mi-main.c: Fix includes.
8978         * m32r-tdep.c: Fix includes.
8979         * csky-tdep.c: Fix includes.
8980         * compile/compile-cplus-types.c: Fix includes.
8981         * cli/cli-interp.c: Fix includes.
8982
8983 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8984
8985         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8986         for padding.
8987
8988 2019-01-16  Tom Tromey  <tom@tromey.com>
8989
8990         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8991         earlier.
8992         (struct objfile) <msymbols_range>: Move from top level.
8993         <msymbols>: New method.
8994         (class objfile_msymbols): Remove.
8995         * symtab.c (default_collect_symbol_completion_matches_break_on):
8996         Update.
8997         * symmisc.c (dump_msymbols): Update.
8998         * stabsread.c (scan_file_globals): Update.
8999         * objc-lang.c (info_selectors_command, info_classes_command)
9000         (find_methods): Update.
9001         * minsyms.c (find_solib_trampoline_target): Update.
9002         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9003         * coffread.c (coff_symfile_read): Update.
9004         * ada-lang.c (ada_lookup_simple_minsym)
9005         (ada_collect_symbol_completion_matches): Update.
9006
9007 2019-01-16  Tom Tromey  <tom@tromey.com>
9008
9009         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9010         type.  Remove no-argument constructor.
9011         <iterator::operator++>: Simplify.
9012         <begin>: Update.
9013         <end>: Use minimal_symbol_count.
9014
9015 2019-01-16  Tom Tromey  <tom@tromey.com>
9016
9017         * objfiles.h (struct objfile) <psymtabs>: New method.
9018         (class objfile_psymtabs): Remove.
9019         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9020         typedef.
9021         <range>: New method.
9022         (require_partial_symbols): Change return type.
9023         * psymtab.c (require_partial_symbols)
9024         (psym_expand_symtabs_matching): Update.
9025         * mdebugread.c (parse_partial_symbols): Update.
9026         * dbxread.c (dbx_end_psymtab): Update.
9027
9028 2019-01-15  Tom Tromey  <tom@tromey.com>
9029
9030         * symtab.c (lookup_objfile_from_block)
9031         (lookup_symbol_in_objfile_symtabs)
9032         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9033         (find_line_symtab, info_sources_command)
9034         (default_collect_symbol_completion_matches_break_on)
9035         (make_source_files_completion_list): Update.
9036         * symmisc.c (print_objfile_statistics, dump_objfile)
9037         (maintenance_print_symbols, maintenance_info_symtabs)
9038         (maintenance_check_symtabs, maintenance_info_line_tables):
9039         Update.
9040         * source.c (select_source_symtab)
9041         (forget_cached_source_info_for_objfile): Update.
9042         * objfiles.h (class objfile_compunits): Remove.
9043         (struct objfile) <compunits_range>: New typedef.
9044         (compunits): New method.
9045         * objfiles.c (objfile_relocate1): Update.
9046         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9047         * maint.c (count_symtabs_and_blocks): Update.
9048         * linespec.c (iterate_over_all_matching_symtabs): Update.
9049         * cp-support.c (add_symbol_overload_list_qualified): Update.
9050         * coffread.c (coff_symtab_read): Update.
9051         * ada-lang.c (add_nonlocal_symbols)
9052         (ada_collect_symbol_completion_matches)
9053         (ada_add_global_exceptions): Update.
9054
9055 2019-01-15  Tom Tromey  <tom@tromey.com>
9056
9057         * progspace.h (program_space) <objfiles_safe_range>: New
9058         typedef.
9059         <objfiles_safe>: New method.
9060         * objfiles.h (class all_objfiles_safe): Remove.
9061         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9062         * jit.c (jit_inferior_exit_hook): Update.
9063
9064 2019-01-17  Tom Tromey  <tom@tromey.com>
9065
9066         * progspace.h (program_space) <objfiles_range>: New typedef.
9067         <objfiles>: New method.
9068         <objfiles_head>: Rename from objfiles.
9069         (object_files): Update.
9070         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9071         * guile/scm-pretty-print.c
9072         (ppscm_find_pretty_printer_from_objfiles): Update.
9073         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9074         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9075         Update.
9076         * python/py-progspace.c (pspy_get_objfiles): Update.
9077         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9078         Update.
9079         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9080         (objfpy_lookup_objfile_by_build_id): Update.
9081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9082         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9083         Update.
9084         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9085         (expand_symtab_containing_pc, lookup_objfile_from_block)
9086         (lookup_static_symbol, basic_lookup_transparent_type)
9087         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9088         (find_line_symtab, info_sources_command)
9089         (default_collect_symbol_completion_matches_break_on)
9090         (make_source_files_completion_list, find_main_name): Update.
9091         * symmisc.c (print_symbol_bcache_statistics)
9092         (print_objfile_statistics, maintenance_print_symbols)
9093         (maintenance_print_msymbols, maintenance_print_objfiles)
9094         (maintenance_info_symtabs, maintenance_check_symtabs)
9095         (maintenance_expand_symtabs, maintenance_info_line_tables):
9096         Update.
9097         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9098         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9099         (map_overlay_command, unmap_overlay_command)
9100         (simple_overlay_update, expand_symtabs_matching)
9101         (map_symbol_filenames): Update.
9102         * symfile-debug.c (set_debug_symfile): Update.
9103         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9104         Update.
9105         * source.c (select_source_symtab, forget_cached_source_info):
9106         Update.
9107         * solib.c (solib_read_symbols): Update.
9108         * solib-spu.c (append_ocl_sos): Update.
9109         * psymtab.c (maintenance_print_psymbols)
9110         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9111         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9112         * printcmd.c (info_symbol_command): Update.
9113         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9114         Update.
9115         * objfiles.h (class all_objfiles): Remove.
9116         * objfiles.c (have_partial_symbols, have_full_symbols)
9117         (have_minimal_symbols, qsort_cmp, update_section_map)
9118         (shared_objfile_contains_address_p)
9119         (default_iterate_over_objfiles_in_search_order): Update.
9120         * objc-lang.c (info_selectors_command, info_classes_command)
9121         (find_methods): Update.
9122         * minsyms.c (find_solib_trampoline_target): Update.
9123         * maint.c (maintenance_info_sections)
9124         (maintenance_translate_address, count_symtabs_and_blocks):
9125         Update.
9126         * main.c (captured_main_1): Update.
9127         * linux-thread-db.c (try_thread_db_load_from_pdir)
9128         (has_libpthread): Update.
9129         * linespec.c (iterate_over_all_matching_symtabs)
9130         (search_minsyms_for_name): Update.
9131         * jit.c (jit_find_objf_with_entry_addr): Update.
9132         * hppa-tdep.c (find_unwind_entry)
9133         (hppa_lookup_stub_minimal_symbol): Update.
9134         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9135         Update.
9136         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9137         (elf_gnu_ifunc_resolve_by_got): Update.
9138         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9139         * dwarf-index-write.c (save_gdb_index_command): Update.
9140         * cp-support.c (add_symbol_overload_list_qualified): Update.
9141         * breakpoint.c (create_overlay_event_breakpoint)
9142         (create_longjmp_master_breakpoint)
9143         (create_std_terminate_master_breakpoint)
9144         (create_exception_master_breakpoint): Update.
9145         * blockframe.c (find_pc_partial_function): Update.
9146         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9147         (ada_collect_symbol_completion_matches)
9148         (ada_add_global_exceptions): Update.
9149
9150 2019-01-17  Tom Tromey  <tom@tromey.com>
9151
9152         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9153         declare VEC.
9154         (solib_target_parse_libraries): Change return type.
9155         (library_list_start_segment, library_list_start_section)
9156         (library_list_end_library, library_list_start_library); Update.
9157         (solib_target_free_library_list): Remove.
9158         (solib_target_parse_libraries): Remove cleanup.  Change return
9159         type.
9160         (solib_target_current_sos): Update.
9161
9162 2019-01-17  Tom Tromey  <tromey@bapiya>
9163
9164         * valprint.c: Replace "the the" with "the".
9165         * symtab.c: Replace "the the" with "the".
9166         * solib.c: Replace "the the" with "the".
9167         * solib-dsbt.c: Replace "the the" with "the".
9168         * linespec.c: Replace "the the" with "the".
9169         * dwarf2loc.h: Replace "the the" with "the".
9170         * amd64-windows-tdep.c: Replace "the the" with "the".
9171         * aarch64-tdep.c: Replace "the the" with "the".
9172
9173 2019-01-16  Keith Seitz  <keiths@redhat.com>
9174
9175         PR gdb/23773
9176         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9177         <builder>: Rename to ..
9178         <m_builder>: ... this and make private.
9179         (dwarf2_cu::get_builder): New method.  Change all users of
9180         `builder' to use this method.
9181         (dwarf2_start_symtab): Move to ...
9182         (dwarf2_cu::start_symtab): ... here.  Update all callers
9183         (setup_type_unit_groups): Move to ...
9184         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9185         callers.
9186         (dwarf2_cu::reset_builder): New method.
9187         (process_full_compunit, process_full_type_unit): Use
9188         dwarf2_cu::reset_builder.
9189         (follow_die_offset): Record the ancestor CU if it is different
9190         from the followed DIE's CU.
9191         (follow_die_sig_1): Likewise.
9192
9193 2019-01-15  Tom Tromey  <tom@tromey.com>
9194
9195         * remote.c (class remote_state) <buf>: Now a char_vector.
9196         <buf_size>: Remove.
9197         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9198         parameter.
9199         (remote_target::getpkt_or_notif_sane_1)
9200         (remote_target::getpkt_sane)
9201         (remote_target::getpkt_or_notif_sane): Likewise.
9202         (class remote_target) <putpkt>: New overload.
9203         (remote_target::read_frame): Change type of "buf_p".  Remove
9204         sizeof_p parameter.
9205         (packet_ok): New overload.
9206         (packet_check_result): New overload.
9207         Update all uses.
9208
9209 2019-01-14  Tom Tromey  <tom@tromey.com>
9210
9211         * remote-notif.c (handle_notification, remote_notif_ack)
9212         (remote_notif_parse): Make "buf" const.
9213         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9214         const.
9215         (remote_notif_parse, remote_notif_ack, handle_notification):
9216         Likewise.
9217         * remote.c (remote_notif_stop_parse): Make "buf" const.
9218         (remote_target::remote_parse_stop_reply): Make "buf" const.
9219         (remote_notif_stop_ack): Make "buf" const.
9220
9221 2019-01-14  Tom Tromey  <tom@tromey.com>
9222
9223         * remote.c (remote_console_output): Make parameter const.
9224
9225 2019-01-14  Tom Tromey  <tom@tromey.com>
9226
9227         * target-debug.h (target_debug_print_signals): Constify.
9228         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9229         * procfs.c (procfs_target::pass_signals): Update.
9230         * linux-nat.c (linux_nat_target::pass_signals): Update.
9231         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9232         * target-delegates.c: Rebuild.
9233         * remote.c (remote_target::program_signals): Update.
9234         (remote_target::pass_signals): Update.
9235         * target.c (target_pass_signals): Constify argument.
9236         (target_program_signals): Likewise.
9237         * target.h (struct target_ops) <pass_signals, program_signals>:
9238         Constify argument.
9239         (target_pass_signals, target_program_signals): Constify argument.
9240
9241 2019-01-14  Tom Tromey  <tom@tromey.com>
9242
9243         PR tui/28819:
9244         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9245
9246 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9247
9248         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9249         field.
9250         * rs6000-tdep.c: Include reggroups.h.
9251         (IS_V_ALIAS_PSEUDOREG): Define.
9252         (rs6000_register_name): Return names for the "vX" aliases.
9253         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9254         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9255         aliases.  Call default_register_reggroup_p for all other
9256         pseudo-registers.
9257         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9258         New functions.
9259         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9260         Handle "vX" aliases.
9261         (v_alias_pseudo_register_collect): New function.
9262         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9263         (rs6000_gdbarch_init): Initialize "vX" aliases as
9264         pseudo-registers.  Restore registration of
9265         rs6000_pseudo_register_reggroup_p with
9266         set_tdesc_pseudo_register_reggroup_p.
9267
9268 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9269
9270         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9271         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9272         set_gdbarch_num_pseudo_regs.
9273
9274 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9275
9276         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9277         Remove arg prefixname, add do_set and do_show.
9278         Add member functions set_list and show_list.
9279         * cli/cli-style.c (class cli_style_option): Update accordingly.
9280         (style_set_list): Move to file scope.
9281         (style_show_list): Likewise.
9282         (set_style): Call help_list.
9283         (show_style): Call cmd_show_list.
9284         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9285         Update to use the new macro.
9286
9287 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9288
9289         * ada-lang.c (_initialize_ada_language): Expand the help text
9290         for the "catch exception" command.
9291
9292 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9293
9294         * symtab.c (matching_obj_sections): Initialize obj,
9295         declare it closer to its usage.
9296
9297 2019-01-10  Tom Tromey  <tom@tromey.com>
9298
9299         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9300         (basic_inf_threads_range): Remove.
9301         (inf_threads_range, inf_non_exited_threads_range)
9302         (safe_inf_threads_range): Use next_adapter.
9303
9304 2019-01-10  Keith Seitz  <keiths@redhat.com>
9305
9306         PR gdb/23712
9307         PR symtab/23010
9308         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9309         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9310
9311 2019-01-10  Keith Seitz  <keiths@redhat.com>
9312
9313         PR gdb/23712
9314         PR symtab/23010
9315         * dictionary.c (pending_to_vector): Remove.
9316         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9317         Remove _1 suffix, replacing functions of the same name.  Update
9318         all callers.
9319         (dict_create_hashed, dict_create_hashed_expandable)
9320         (dict_create_linear, dict_create_linear_expandable, dict_free)
9321         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9322         Make functions static.
9323
9324 2019-01-10  Keith Seitz  <keiths@redhat.com>
9325
9326         PR gdb/23712
9327         PR symtab/23010
9328         * dictionary.h (struct dictionary): Replace declaration with
9329         multidictionary.
9330         (dict_create_hashed, dict_create_hashed_expandable)
9331         (dict_create_linear, dict_create_linear_expandable)
9332         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9333         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9334         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9335         taking multidictionary argument.
9336         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9337         * block.h (struct block) <dict>: Change to multidictionary
9338         and rename `multidict'.
9339         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9340         symmisc.c: Update all dictionary references to multidictionary.
9341
9342 2019-01-10  Keith Seitz  <keiths@redhat.com>
9343
9344         PR gdb/23712
9345         PR symtab/23010
9346         * dictionary.c: Include unordered_map.
9347         (pending_to_vector): New function.
9348         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9349         Rewrite the non-"_1" functions to take vector instead
9350         of linked list.
9351         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9352         "new" _1 versions of the same name.
9353         (multidictionary): Define.
9354         (std::hash<enum language): New definition.
9355         (collate_pending_symbols_by_language, mdict_create_hashed)
9356         (mdict_create_hashed_expandable, mdict_create_linear)
9357         (mdict_create_linear_expandable, mdict_free)
9358         (find_language_dictionary, create_new_language_dictionary)
9359         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9360         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9361         (mdict_size, mdict_empty): New functions.
9362         * dictionary.h (mdict_iterator): Define.
9363
9364 2019-01-10  Pedro Alves  <palves@redhat.com>
9365
9366         * breakpoint.c (read_uploaded_action)
9367         (create_tracepoint_from_upload): Adjust to use
9368         gdb::unique_xmalloc_ptr.
9369         * ctf.c (ctf_write_uploaded_tp):
9370         (SET_ARRAY_FIELD): Use emplace_back.
9371         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9372         * tracefile-tfile.c (tfile_write_uploaded_tp):
9373         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9374         gdb::unique_xmalloc_ptr.
9375         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9376         at_string, cond_string, cmd_strings>: Replace char pointers
9377         with gdb::unique_xmalloc_ptr.
9378
9379 2019-01-10  Pedro Alves  <palves@redhat.com>
9380
9381         * solib-target.c (library_list_start_library): Don't xstrdup name.
9382
9383 2019-01-10  Pedro Alves  <palves@redhat.com>
9384
9385         * mdebugread.c (parse_partial_symbols): Use
9386         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9387
9388 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9389
9390         * linux-fork.c (scoped_switch_fork_info)
9391         <~scoped_switch_fork_info>: Fix incorrect variable name.
9392
9393 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9394
9395         * linux-fork.c (scoped_switch_fork_info)
9396         <scoped_switch_fork_info>: Make explicit.
9397         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9398
9399 2019-01-10  Tom Tromey  <tom@tromey.com>
9400
9401         * objfiles.h (objfile::reset_psymtabs): Update.
9402         * objfiles.c (objfile::objfile): Update.
9403         * psymtab.h (psymtab_storage::obstack): Update.
9404         (psymtab_storage::m_obstack): Use gdb::optional.
9405         (class psymtab_storage): Update comment.  Remove objfile
9406         parameter.
9407         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9408
9409 2019-01-10  Tom Tromey  <tom@tromey.com>
9410
9411         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9412         <free_psymtabs>: Now private.
9413         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9414         (allocate_psymtab): Use new method.
9415
9416 2019-01-10  Tom Tromey  <tom@tromey.com>
9417
9418         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9419         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9420         * mdebugread.c (parse_partial_symbols): Use
9421         allocate_dependencies.
9422         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9423         allocate_dependencies.
9424         (process_psymtab_comp_unit_reader)
9425         (build_type_psymtab_dependencies): Likewise.
9426         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9427
9428 2019-01-10  Tom Tromey  <tom@tromey.com>
9429
9430         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9431         PSYMBOL_SET_LANGUAGE.
9432         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9433
9434 2019-01-10  Tom Tromey  <tom@tromey.com>
9435
9436         * psymtab.h (psymtab_storage::obstack): New method.
9437         <m_obstack>: Rename from obstack; now private.
9438         * psymtab.c (psymtab_storage): Update.
9439         * dwarf2read.c (create_addrmap_from_index)
9440         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9441         Update.
9442
9443 2019-01-10  Tom Tromey  <tom@tromey.com>
9444
9445         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9446         * objfiles.h (objfile::reset_psymtabs): New method.
9447
9448 2019-01-10  Tom Tromey  <tom@tromey.com>
9449
9450         * symmisc.c (print_symbol_bcache_statistics): Update.
9451         (print_objfile_statistics): Update.
9452         * symfile.c (reread_symbols): Update.
9453         * psymtab.h (class psymtab_storage): New.
9454         * psymtab.c (psymtab_storage): New constructor.
9455         (~psymtab_storage): New destructor.
9456         (require_partial_symbols): Update.
9457         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9458         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9459         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9460         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9461         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9462         (start_psymtab_common, end_psymtab_common)
9463         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9464         (allocate_psymtab): Update.
9465         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9466         Update.
9467         (dump_psymtab_addrmap, maintenance_print_psymbols)
9468         (maintenance_check_psymtabs): Update.
9469         (class objfile_psymtabs): Move to objfiles.h.
9470         * psympriv.h (discard_psymtab): Now inline.
9471         (psymtab_discarder::psymtab_discarder): Update.
9472         (psymtab_discarder::~psymtab_discarder): Update.
9473         (ALL_OBJFILE_PSYMTABS): Rewrite.
9474         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9475         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9476         Remove fields.
9477         <partial_symtabs>: New field.
9478         (class objfile_psymtabs): Move from psymtab.h.  Update.
9479         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9480         psymbol_cache.
9481         (objfile::~objfile): Don't destroy psymbol_cache.
9482         * mdebugread.c (parse_partial_symbols): Update.
9483         * dwarf2read.c (create_addrmap_from_index)
9484         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9485         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9486         (add_partial_subprogram, dwarf2_ranges_read): Update.
9487         * dwarf-index-write.c (write_address_map)
9488         (write_one_signatured_type, recursively_write_psymbols)
9489         (class debug_names, class debug_names, write_psymtabs_to_index):
9490         Update.
9491
9492 2019-01-10  Tom Tromey  <tom@tromey.com>
9493
9494         * symtab.h (SYMBOL_SET_NAMES): Update.
9495         (symbol_set_names): Update.
9496         (MSYMBOL_SET_NAMES): Update.
9497         * symtab.c (symbol_set_names): Change argument to be an
9498         objfile_per_bfd_storage.
9499         * psymtab.c (add_psymbol_to_bcache): Update.
9500         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9501
9502 2019-01-10  Tom Tromey  <tom@tromey.com>
9503
9504         * symtab.c (create_demangled_names_hash): Change argument to be an
9505         objfile_per_bfd_storage.
9506         (symbol_set_names): Update.
9507
9508 2019-01-10  Tom Tromey  <tom@tromey.com>
9509
9510         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9511         init_psymbol_list.
9512         * psymtab.c (init_psymbol_list): Do nothing if already called.
9513         * psympriv.h (init_psymbol_list): Add comment.
9514         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9515         init_psymbol_list.
9516         * dbxread.c (dbx_symfile_read): Unconditionally call
9517         init_psymbol_list.
9518
9519 2019-01-10  Tom Tromey  <tom@tromey.com>
9520
9521         * xcoffread.c (scan_xcoff_symtab): Update.
9522         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9523         "where".
9524         * mdebugread.c (parse_partial_symbols)
9525         (handle_psymbol_enumerators): Update.
9526         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9527         * dbxread.c (read_dbx_symtab): Update.
9528         * psympriv.h (psymbol_placement): New enum.
9529         (add_psymbol_to_list): Update.
9530
9531 2019-01-10  Tom Tromey  <tom@tromey.com>
9532
9533         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9534         static_psymbols parameters.
9535         (scan_xcoff_symtab): Update.
9536         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9537         static_psymbols parameters.
9538         * psympriv.h (start_psymtab_common): Update.
9539         * mdebugread.c (parse_partial_symbols): Update.
9540         * dwarf2read.c (create_partial_symtab): Update.
9541         * dbxread.c (read_dbx_symtab): Update.
9542         (start_psymtab): Remove global_psymbols and static_psymbols
9543         parameters.
9544
9545 2019-01-10  Tom Tromey  <tom@tromey.com>
9546
9547         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9548         * psymtab.c (allocate_psymtab): Add comment.
9549         * psympriv.h (allocate_psymtab): Add comment.
9550         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9551         initializations.
9552         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9553
9554 2019-01-10  Tom Tromey  <tom@tromey.com>
9555
9556         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9557         Don't declare.
9558         * mipsread.c: Include mdebugread.h.
9559         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9560         Declare.
9561         * elfread.c: Include mdebugread.h.
9562
9563 2019-01-09  Tom Tromey  <tom@tromey.com>
9564
9565         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9566         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9567         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9568         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9569         (psym_lookup_symbol, psym_find_last_source_symtab)
9570         (psym_forget_cached_source_info, psym_print_stats)
9571         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9572         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9573         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9574         (psym_find_compunit_symtab_by_address)
9575         (maintenance_print_psymbols, maintenance_info_psymtabs)
9576         (maintenance_check_psymtabs): Use ranged for.
9577         * psymtab.h (class objfile_psymtabs): New.
9578         (require_partial_symbols): Return objfile_psymtabs.
9579         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9580
9581 2019-01-09  Tom Tromey  <tom@tromey.com>
9582
9583         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9584         (find_pc_mapped_section, list_overlays_command)
9585         (map_overlay_command, unmap_overlay_command)
9586         (simple_overlay_update): Use all_objfiles.
9587         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9588         * printcmd.c (info_symbol_command): Use all_objfiles.
9589         * objfiles.h (ALL_OBJSECTIONS): Remove.
9590         * maint.c (maintenance_translate_address): Use all_objfiles.
9591         * gcore.c (gcore_create_callback): Use all_objfiles.
9592         (objfile_find_memory_regions): Likewise.
9593
9594 2019-01-09  Tom Tromey  <tom@tromey.com>
9595
9596         * symtab.c (find_line_symtab, info_sources_command)
9597         (make_source_files_completion_list): Use objfile_compunits.
9598         * source.c (select_source_symtab): Use objfile_compunits.
9599         * objfiles.h (struct objfile): Update comment.
9600         (ALL_OBJFILES): Remove.
9601         (ALL_FILETABS): Remove.
9602         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9603         objfile_compunits.
9604
9605 2019-01-09  Tom Tromey  <tom@tromey.com>
9606
9607         * symmisc.c (print_objfile_statistics, dump_objfile)
9608         (maintenance_print_symbols): Use compunit_filetabs.
9609         * source.c (forget_cached_source_info_for_objfile): Use
9610         compunit_filetabs.
9611         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9612         (ALL_FILETABS): Use compunit_filetabs.
9613         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9614         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9615
9616 2019-01-09  Tom Tromey  <tom@tromey.com>
9617
9618         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9619         (compunit_filetabs): New.
9620         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9621         compunit_filetabs.
9622         (info_sources_command, make_source_files_completion_list): Remove
9623         declaration.
9624         * symmisc.c (print_objfile_statistics, dump_objfile)
9625         (maintenance_print_symbols): Remove declaration.
9626         (maintenance_info_symtabs): Use compunit_filetabs.
9627         (maintenance_info_line_tables): Likewise.
9628         * source.c (select_source_symtab): Change local variable name.
9629         (forget_cached_source_info_for_objfile): Remove declaration.
9630         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9631         * objfiles.c (objfile_relocate1): Remove declaration.
9632         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9633         declaration.
9634         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9635         * coffread.c (coff_symtab_read): Remove declaration.
9636         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9637         compunit_filetabs.
9638
9639 2019-01-09  Tom Tromey  <tom@tromey.com>
9640
9641         * symtab.c (lookup_objfile_from_block)
9642         (find_pc_sect_compunit_symtab, search_symbols)
9643         (default_collect_symbol_completion_matches_break_on): Use
9644         objfile_compunits.
9645         * objfiles.h (ALL_COMPUNITS): Remove.
9646         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9647         * cp-support.c (add_symbol_overload_list_qualified): Use
9648         objfile_compunits.
9649         * ada-lang.c (ada_collect_symbol_completion_matches)
9650         (ada_add_global_exceptions): Use objfile_compunits.
9651
9652 2019-01-09  Tom Tromey  <tom@tromey.com>
9653
9654         * source.c (select_source_symtab)
9655         (forget_cached_source_info_for_objfile): Remove declaration.
9656         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9657         declaration.
9658         * maint.c (count_symtabs_and_blocks): Remove declaration.
9659         * cp-support.c (add_symbol_overload_list_qualified): Remove
9660         declaration.
9661         * coffread.c (coff_symtab_read): Remove declaration.
9662         * symtab.c (lookup_symbol_in_objfile_symtabs)
9663         (basic_lookup_transparent_type_1): Use objfile_compunits.
9664         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9665         (info_sources_command, search_symbols)
9666         (default_collect_symbol_completion_matches_break_on)
9667         (make_source_files_completion_list): Remove declaration.
9668         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9669         (ada_collect_symbol_completion_matches)
9670         (ada_add_global_exceptions): Remove declaration.
9671         * linespec.c (iterate_over_all_matching_symtabs): Use
9672         objfile_compunits.
9673         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9674         (class objfile_compunits): New.
9675         (ALL_COMPUNITS): Use objfile_compunits.
9676         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9677         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9678         objfile_compunits.
9679         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9680
9681 2019-01-09  Tom Tromey  <tom@tromey.com>
9682
9683         * symtab.c (search_symbols)
9684         (default_collect_symbol_completion_matches_break_on): Use
9685         objfile_msymbols.
9686         * ada-lang.c (ada_lookup_simple_minsym)
9687         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9688         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9689         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9690         objfile_msymbols.
9691         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9692         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9693         * objc-lang.c (find_methods): Use objfile_msymbols.
9694         (info_selectors_command, info_classes_command): Likewise.
9695         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9696         * objfiles.h (class objfile_msymbols): New.
9697         (ALL_OBJFILE_MSYMBOLS): Remove.
9698         (ALL_MSYMBOLS): Remove.
9699
9700 2019-01-09  Tom Tromey  <tom@tromey.com>
9701
9702         * common/next-iterator.h (next_adapter): Add Iterator template
9703         parameter.
9704         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9705         (class all_objfiles_safe): New.
9706         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9707         * objfiles.c (put_objfile_before): Update comment.
9708         (add_separate_debug_objfile): Likewise.
9709         (free_all_objfiles): Use all_objfiles_safe.
9710         (objfile_purge_solibs): Likewise.
9711
9712 2019-01-09  Tom Tromey  <tom@tromey.com>
9713
9714         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9715         (expand_symtab_containing_pc, lookup_static_symbol)
9716         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9717         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9718         all_objfiles.
9719         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9720         * breakpoint.c (create_overlay_event_breakpoint)
9721         (create_longjmp_master_breakpoint)
9722         (create_std_terminate_master_breakpoint)
9723         (create_exception_master_breakpoint): Use all_objfiles.
9724         * linux-thread-db.c (try_thread_db_load_from_pdir)
9725         (has_libpthread): Use all_objfiles.
9726         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9727         * linespec.c (iterate_over_all_matching_symtabs)
9728         (search_minsyms_for_name): Use all_objfiles.
9729         * maint.c (maintenance_info_sections): Use all_objfiles.
9730         * main.c (captured_main_1): Use all_objfiles.
9731         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9732         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9733         * guile/scm-pretty-print.c
9734         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9735         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9736         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9737         (maintenance_print_msymbols): Use all_objfiles.
9738         * source.c (select_source_symtab): Use all_objfiles.
9739         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9740         * symfile.c (remove_symbol_file_command)
9741         (expand_symtabs_matching, map_symbol_filenames): Use
9742         all_objfiles.
9743         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9744         all_objfiles.
9745         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9746         * objc-lang.c (find_methods): Use all_objfiles.
9747         * objfiles.c (have_partial_symbols, have_full_symbols)
9748         (have_minimal_symbols, qsort_cmp)
9749         (default_iterate_over_objfiles_in_search_order): Use
9750         all_objfiles.
9751         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9752         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9753         (maintenance_check_psymtabs): Use all_objfiles.
9754         (ALL_PSYMTABS): Remove.
9755         * compile/compile-object-run.c (do_module_cleanup): Use
9756         all_objfiles.
9757         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9758         * cp-support.c (add_symbol_overload_list_qualified): Use
9759         all_objfiles.
9760         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9761         Use all_objfiles.
9762         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9763         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9764         all_objfiles.
9765         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9766         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9767         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9768         Uses all_objfiles.
9769         * solib.c (solib_read_symbols): Use all_objfiles
9770
9771 2019-01-09  Tom Tromey  <tom@tromey.com>
9772
9773         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9774         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9775         all_objfiles.
9776         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9777         * symmisc.c (print_symbol_bcache_statistics)
9778         (print_objfile_statistics, maintenance_print_objfiles)
9779         (maintenance_info_symtabs, maintenance_check_symtabs)
9780         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9781         all_objfiles.
9782         * source.c (forget_cached_source_info): Use all_objfiles.
9783         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9784         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9785         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9786         * objfiles.c (update_section_map): Use all_objfiles.
9787         (shared_objfile_contains_address_p): Likewise.
9788         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9789         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9790
9791 2019-01-09  Tom Tromey  <tom@tromey.com>
9792
9793         * common/next-iterator.h: New file.
9794         * objfiles.h (class all_objfiles): New.
9795         (struct objfile_iterator): New.
9796
9797 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9798
9799         * NEWS: Move the description of the changed "frame", "select-frame",
9800          and "info frame" commands to the Changed commands section.
9801
9802 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9803
9804         * gdbtypes.c (check_stub_method_group): Remove handling of old
9805         mangling schemes.
9806         * linespec.c (find_methods): Likewise.
9807         * stabsread.c (read_member_functions): Likewise.
9808         * valops.c (search_struct_method): Likewise.
9809         (value_struct_elt_for_reference): Likewise.
9810         * NEWS: Mention this change.
9811
9812 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9813
9814         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9815         print_source_lines.
9816         * source.c (print_source_lines_base): Update line number check.
9817         (print_source_lines): New function.
9818         (source_lines_range::source_lines_range): New function.
9819         * source.h (class source_lines_range): New class.
9820         (print_source_lines): New declaration.
9821
9822 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9823
9824         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9825
9826 2019-01-08  Tom Tromey  <tom@tromey.com>
9827             Simon Marchi  <simon.marchi@ericsson.com>
9828
9829         PR gdb/24060
9830         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9831         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9832         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9833         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9834         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9835         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9836
9837 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9838
9839         * source.c (select_source_symtab): Move header comment to
9840         declaration in source.h.
9841         (forget_cached_source_info_for_objfile): Likewise.
9842         (forget_cached_source_info): Likewise.
9843         (identify_source_line): Likewise.
9844         * source.h (identify_source_line): Move declaration from symtab.h
9845         and add comment from source.c
9846         (print_source_lines): Likewise.
9847         (forget_cached_source_info_for_objfile): Likewise.
9848         (forget_cached_source_info): Likewise.
9849         (select_source_symtab): Likewise.
9850         (enum print_source_lines_flag): Move definition from symtab.h.
9851         * symtab.h (identify_source_line): Move declaration to source.h.
9852         (print_source_lines): Likewise.
9853         (forget_cached_source_info_for_objfile): Likewise.
9854         (forget_cached_source_info): Likewise.
9855         (select_source_symtab): Likewise.
9856         (enum print_source_lines_flag): Move definition to source.h.
9857         * tui/tui-hooks.c: Add 'source.h' include.
9858
9859 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9860
9861         * source.c (print_source_lines_base): Handle requests to print
9862         reverse line number sequences, and guard against empty lines
9863         string.
9864
9865 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9866
9867         * source.c (print_source_lines_base): Fix skip of '\r' if next
9868         character is '\n'.
9869
9870 2019-01-06  Tom Tromey  <tom@tromey.com>
9871
9872         * c-exp.y (struct c_parse_state) <macro_original_text,
9873         expansion_obstack>: New member.
9874         (macro_original_text, expansion_obstack): Remove globals.
9875         (scan_macro_expansion, scanning_macro_expansion)
9876         (finished_macro_expansion): Update.
9877         (scan_macro_cleanup): Remove.
9878         (yylex, c_parse): Update.
9879
9880 2019-01-06  Tom Tromey  <tom@tromey.com>
9881
9882         * c-exp.y (struct c_parse_state) <strings>: New member.
9883         (operator_stoken): Update.
9884
9885 2019-01-06  Tom Tromey  <tom@tromey.com>
9886
9887         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9888         (union type_stack_elt) <typelist_val>: Now a pointer to
9889         std::vector.
9890         (type_stack_cleanup): Don't declare.
9891         (push_typelist): Update.
9892         * parse.c (pop_typelist): Return a std::vector.
9893         (push_typelist): Take a std::vector.
9894         (follow_types): Update.  Do not free args.
9895         (type_stack_cleanup): Remove.
9896         * c-exp.y (struct c_parse_state): New.
9897         (cpstate): New global.
9898         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9899         (nonempty_typelist): Update.
9900         (func_mod): Create a new vector.
9901         (c_parse): Create a c_parse_state.
9902         (check_parameter_typelist): Do not delete params.
9903         (function_method): Update.  Do not delete type_list.
9904
9905 2019-01-06  Tom Tromey  <tom@tromey.com>
9906
9907         PR gdb/28155:
9908         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9909         check_typedef.
9910         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9911         (print_return_value): Likewise.
9912
9913 2019-01-05  Tom Tromey  <tom@tromey.com>
9914
9915         * contrib/cleanup_check.py: Remove.
9916         * contrib/gcc-with-excheck: Remove.
9917         * contrib/exsummary.py: Remove.
9918         * contrib/excheck.py: Remove.
9919
9920 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9921
9922         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9923         NULL. Initialize tpprev to NULL instead of assigning it
9924         to NULL on the next statement.
9925         * windows-nat.c (windows_delete_thread): Remove check for
9926         main_thread_id before printing thread exit notifications.
9927         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9928         Remove thread ID check against main_thread_id.
9929         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9930         windows_delete_thread.
9931         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9932
9933 2019-01-04  Tom Tromey  <tom@tromey.com>
9934
9935         * compile/compile.c (_initialize_compile): Use upper case for
9936         metasyntactic variables.
9937         * symmisc.c (_initialize_symmisc): Use upper case for
9938         metasyntactic variables.
9939         * psymtab.c (_initialize_psymtab): Use upper case for
9940         metasyntactic variables.
9941         * demangle.c (demangle_command): Use upper case for metasyntactic
9942         variables.
9943         (_initialize_demangler): Likewise.
9944         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9945         variables.
9946
9947 2019-01-03  Tom Tromey  <tom@tromey.com>
9948
9949         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9950
9951 2019-01-03  Tom Tromey  <tom@tromey.com>
9952
9953         * python/py-symtab.c (salpy_str): Update.
9954         (struct salpy_sal_object) <symtab>: Now a PyObject.
9955         (salpy_dealloc): Update.
9956         (del_objfile_sal): Use gdbpy_ref.
9957
9958 2019-01-03  Tom Tromey  <tom@tromey.com>
9959
9960         * python/py-type.c (convert_field): Use new_reference.  Return
9961         gdbpy_ref.
9962         (make_fielditem): Return gdbpy_ref.
9963         (typy_fields): Update.
9964         (typy_getitem): Update.
9965         (field_name): Return gdbpy_ref.  Use new_reference.
9966         (typy_iterator_iternext): Update.
9967
9968 2019-01-03  Tom Tromey  <tom@tromey.com>
9969
9970         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9971
9972 2019-01-03  Tom Tromey  <tom@tromey.com>
9973
9974         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9975         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9976         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9977         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9978         (pspy_set_type_printers): Likewise.
9979         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9980         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9981         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9982         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9983         (objfpy_set_type_printers): Likewise.
9984
9985 2019-01-03  Tom Tromey  <tom@tromey.com>
9986
9987         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9988         (gdbpy_print_stack): Use gdbpy_err_fetch.
9989         * python/python-internal.h (class gdbpy_err_fetch): New class.
9990         (class gdbpy_enter) <m_error_type, m_error_value,
9991         m_error_traceback>: Remove.
9992         <m_error>: New member.
9993         (gdbpy_exception_to_string): Don't declare.
9994         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9995         * python/py-value.c (convert_value_from_python): Use
9996         gdbpy_err_fetch.
9997         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9998         gdbpy_exception_to_string.
9999         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10000         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10001         gdbpy_err_fetch.
10002
10003 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10004
10005         * linux-nat.c (delete_lwp_cleanup): Delete.
10006         (struct lwp_deleter): New struct.
10007         (lwp_info_up): New typedef.
10008         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10009         lwp_info_up.
10010
10011 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10012
10013         * linux-fork.c (class scoped_switch_fork_info): New class.
10014         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10015
10016 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10017
10018         * valops.c (find_overload_match): Remove use of null_cleanup, and
10019         calls to do_cleanups.
10020
10021 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10022
10023         * compile/compile-cplus-types.c
10024         (compile_cplus_instance::decl_name): Handle changes to
10025         cp_func_name.
10026         * cp-support.c (cp_func_name): Update header comment, update
10027         return type.
10028         * cp-support.h (cp_func_name): Update return type in declaration.
10029         * valops.c (find_overload_match): Move temp_func local to top
10030         level of function and change its type.  Use temp_func to hold and
10031         delete temporary string obtained from cp_func_name.
10032
10033 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10034
10035         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10036         gdb::char_vector, remove cleanup, and update uses of `msg`.
10037
10038 2019-01-03  Jim Wilson  <jimw@sifive.com>
10039
10040         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10041
10042 2019-01-02  Tom Tromey  <tom@tromey.com>
10043
10044         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10045         (tdesc_parse_xml): Remove cleanups.
10046         * target-descriptions.h (make_cleanup_free_target_description):
10047         Don't declare.
10048         (target_desc_deleter): New struct.
10049         (target_desc_up): New typedef.
10050         * target-descriptions.c (target_desc_deleter::operator()): Rename
10051         from free_target_description.
10052         (make_cleanup_free_target_description): Remove.
10053
10054 2019-01-02  Tom Tromey  <tom@tromey.com>
10055
10056         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10057         constructor, destructor.
10058         (linespec_parser): Remove typedef.
10059         (~linespec_parser): Rename from linespec_parser_delete.
10060         (linespec_lex_to_end, linespec_complete_label)
10061         (linespec_complete): Update.
10062         (decode_line_full): Remove cleanups.
10063         (decode_line_1): Update.
10064
10065 2019-01-02  Tom Tromey  <tom@tromey.com>
10066
10067         * python/python-internal.h (inferior_to_inferior_object): Change
10068         return type.
10069         * python/py-exitedevent.c (create_exited_event_object): Update.
10070         * python/py-inferior.c (inferior_to_inferior_object): Return
10071         gdbpy_ref.
10072         (python_new_inferior, python_inferior_deleted)
10073         (thread_to_thread_object, delete_thread_object)
10074         (build_inferior_list, gdbpy_selected_inferior): Update.
10075         * python/py-infthread.c (create_thread_object): Update.  Also fail
10076         if inferior_to_inferior_object fails.
10077
10078 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10079
10080         * inferior.h (class inferior) <displaced_step_state>: New field.
10081         * infrun.h (struct displaced_step_state): Move here from
10082         infrun.c.  Initialize fields, add constructor.
10083         <inf>: Remove field.
10084         <reset>: New method.
10085         * infrun.c (struct displaced_step_inferior_state): Move to
10086         infrun.h.
10087         (displaced_step_inferior_states): Remove.
10088         (get_displaced_stepping_state): Adust.
10089         (displaced_step_in_progress_any_inferior): Adjust.
10090         (displaced_step_in_progress_thread): Adjust.
10091         (displaced_step_in_progress): Adjust.
10092         (add_displaced_stepping_state): Remove.
10093         (get_displaced_step_closure_by_addr): Adjust.
10094         (remove_displaced_stepping_state): Remove.
10095         (infrun_inferior_exit): Call displaced_step_state.reset.
10096         (use_displaced_stepping): Don't check for NULL.
10097         (displaced_step_prepare_throw): Call
10098         get_displaced_stepping_state.
10099         (displaced_step_fixup): Don't check for NULL.
10100         (prepare_for_detach): Don't check for NULL.
10101
10102 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10103
10104         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10105          in case of call that did not complete.
10106
10107 2019-01-02  Andrey Utkin  <autkin@undo.io>
10108
10109         * symfile.c (find_separate_debug_file): Fix search of debug files for
10110         remote debuggee.
10111
10112 2019-01-02  Tom Tromey  <tom@tromey.com>
10113
10114         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10115         indentation.
10116         * python/py-frame.c (frapy_older): Remove cast.
10117         (frapy_newer): Likewise.
10118         * python/py-breakpoint.c (local_setattro): Remove cast.
10119         * python/py-arch.c (archpy_name): Remove local variable.
10120         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10121
10122 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10123
10124         * unittests/basic_string_view/element_access/char/empty.cc:
10125         Fix year range in copyright header.
10126
10127 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10128
10129         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10130         Delete.
10131         <operator==>: Update with for removed field.
10132         <hash>: Likewise.
10133         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10134         <isa_features>: ...this.
10135         <abi_features>: New field.
10136         (riscv_isa_flen): Update comment.
10137         (riscv_abi_xlen): New declaration.
10138         (riscv_abi_flen): New declaration.
10139         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10140         isa_features.
10141         (riscv_abi_xlen): New function.
10142         (riscv_isa_flen): Update to get answer from isa_features.
10143         (riscv_abi_flen): New function.
10144         (riscv_has_fp_abi): Update to get answer from abi_features.
10145         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10146         xlen and flen.
10147         (riscv_call_info) <xlen, flen>: Update comment.
10148         (riscv_call_arg_struct): Remove invalid assertions
10149         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10150         is removed.
10151         (riscv_gdbarch_init): Gather isa features and abi features
10152         separately, ensure both match on the gdbarch when reusing an old
10153         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10154         a target with 64-bit float hardware.
10155
10156 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10157
10158         * source.c (search_command_helper): Stop reverse search
10159         when line 1 has been searched.
10160
10161 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10162
10163         * record-full.c (record_full_base_target::close): Rewrite
10164         record_full_core_buf_list free logic.
10165
10166 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10167
10168         * break-catch-syscall.c (print_one_catch_syscall): xfree
10169         the last text.
10170
10171 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10172
10173         * top.c (print_gdb_version): Update Copyright year in version
10174         message.
10175
10176 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10177
10178         Update copyright year range in all GDB files.
10179
10180 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10181
10182         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10183
10184 For older changes see ChangeLog-2018.
10185 \f
10186 Local Variables:
10187 mode: change-log
10188 left-margin: 8
10189 fill-column: 74
10190 version-control: never
10191 coding: utf-8
10192 End:
10193