gdb/ChangeLog

   1 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * symfile.c (find_separate_debug_file): Use canonical path of
   4         sysroot with child_path instead of gdb_sysroot if it is valid.
   5
   6 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
   7
   8         * symfile.c (find_separate_debug_file): Use child_path to
   9         determine if an object file is under a sysroot.
  10
  11 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  12
  13         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  14         unittests/child-path-selftests.c.
  15         * common/pathstuff.c (child_path): New function.
  16         * common/pathstuff.h (child_path): New prototype.
  17         * unittests/child-path-selftests.c: New file.
  18
  19 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  20
  21         * symfile.c (find_separate_debug_file): Look for separate debug
  22         files in debug directories under the sysroot.
  23
  24 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  25
  26         * symtab.h (struct minimal_symbol data_p): New const method.
  27         (struct minimal_symbol text_p): Likewise.
  28         * symtab.c (output_source_filename): Use file name style
  29         to print file name.
  30         (print_symbol_info): Likewise.
  31         (print_msymbol_info): Use address style to print addresses.
  32         Use function name style to print executable text symbols.
  33         (expand_symtab_containing_pc): Use data_p.
  34         (find_pc_sect_compunit_symtab): Likewise.
  35
  36 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  37
  38         * breakpoint.c (describe_other_breakpoints): Use address style
  39         to print addresses.
  40         (say_where): Likewise.
  41
  42 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  43
  44         * ada-typeprint.c (print_func_type): Print function name
  45         style to print function name.
  46         * c-typeprint.c (c_print_type_1): Likewise.
  47
  48 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
  49
  50         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
  51         for execve.
  52
  53 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  54
  55         * c-exp.y (direct_abs_decl): Use emplace_back to record the
  56         type_stack.
  57
  58 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
  59
  60         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
  61         TYPE_CODE_REF types.
  62
  63 2019-02-08  Jim Wilson  <jimw@sifive.com>
  64
  65         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
  66         (riscv_linux_fregset): New.
  67         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
  68
  69 2019-02-07  Tom Tromey  <tom@tromey.com>
  70
  71         * thread.c (thread_cancel_execution_command): Update.
  72         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
  73         methods.
  74         (struct thread_fsm_ops): Remove.
  75         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
  76         (thread_fsm_should_stop, thread_fsm_return_value)
  77         (thread_fsm_set_finished, thread_fsm_finished_p)
  78         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
  79         Don't declare.
  80         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
  81         * infrun.c (clear_proceed_status_thread)
  82         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
  83         (print_stop_event): Update.
  84         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
  85         Add constructor.
  86         (step_command_fsm_ops): Remove.
  87         (new_step_command_fsm): Remove.
  88         (step_1): Update.
  89         (step_command_fsm::should_stop): Rename from
  90         step_command_fsm_should_stop.
  91         (step_command_fsm::clean_up): Rename from
  92         step_command_fsm_clean_up.
  93         (step_command_fsm::do_async_reply_reason): Rename from
  94         step_command_fsm_async_reply_reason.
  95         (struct until_next_fsm): Inherit from thread_fsm.  Add
  96         constructor.
  97         (until_next_fsm_ops): Remove.
  98         (new_until_next_fsm): Remove.
  99         (until_next_fsm::should_stop): Rename from
 100         until_next_fsm_should_stop.
 101         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 102         (until_next_fsm::do_async_reply_reason): Rename from
 103         until_next_fsm_async_reply_reason.
 104         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 105         constructor.  Change type of breakpoint.
 106         (finish_command_fsm_ops): Remove.
 107         (new_finish_command_fsm): Remove.
 108         (finish_command_fsm::should_stop): Rename from
 109         finish_command_fsm_should_stop.
 110         (finish_command_fsm::clean_up): Rename from
 111         finish_command_fsm_clean_up.
 112         (finish_command_fsm::return_value): Rename from
 113         finish_command_fsm_return_value.
 114         (finish_command_fsm::do_async_reply_reason): Rename from
 115         finish_command_fsm_async_reply_reason.
 116         (finish_command): Update.
 117         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 118         Add constructor.
 119         (call_thread_fsm_ops): Remove.
 120         (call_thread_fsm::call_thread_fsm): Rename from
 121         new_call_thread_fsm.
 122         (call_thread_fsm::should_stop): Rename from
 123         call_thread_fsm_should_stop.
 124         (call_thread_fsm::should_notify_stop): Rename from
 125         call_thread_fsm_should_notify_stop.
 126         (run_inferior_call, call_function_by_hand_dummy): Update.
 127         * cli/cli-interp.c (should_print_stop_to_console): Update.
 128         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 129         Add constructor.  Change type of location_breakpoint,
 130         caller_breakpoint.
 131         (until_break_fsm_ops): Remove.
 132         (new_until_break_fsm): Remove.
 133         (until_break_fsm::should_stop): Rename from
 134         until_break_fsm_should_stop.
 135         (until_break_fsm::clean_up): Rename from
 136         until_break_fsm_clean_up.
 137         (until_break_fsm::do_async_reply_reason): Rename from
 138         until_break_fsm_async_reply_reason.
 139         (until_break_command): Update.
 140         * thread-fsm.c: Remove.
 141         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 142
 143 2019-02-07  Tom Tromey  <tom@tromey.com>
 144
 145         * yy-remap.h: Add include guard.
 146         * xtensa-tdep.h: Add include guard.
 147         * xcoffread.h: Rename include guard.
 148         * varobj-iter.h: Add include guard.
 149         * tui/tui.h: Rename include guard.
 150         * tui/tui-winsource.h: Rename include guard.
 151         * tui/tui-wingeneral.h: Rename include guard.
 152         * tui/tui-windata.h: Rename include guard.
 153         * tui/tui-win.h: Rename include guard.
 154         * tui/tui-stack.h: Rename include guard.
 155         * tui/tui-source.h: Rename include guard.
 156         * tui/tui-regs.h: Rename include guard.
 157         * tui/tui-out.h: Rename include guard.
 158         * tui/tui-layout.h: Rename include guard.
 159         * tui/tui-io.h: Rename include guard.
 160         * tui/tui-hooks.h: Rename include guard.
 161         * tui/tui-file.h: Rename include guard.
 162         * tui/tui-disasm.h: Rename include guard.
 163         * tui/tui-data.h: Rename include guard.
 164         * tui/tui-command.h: Rename include guard.
 165         * tic6x-tdep.h: Add include guard.
 166         * target/waitstatus.h: Rename include guard.
 167         * target/wait.h: Rename include guard.
 168         * target/target.h: Rename include guard.
 169         * target/resume.h: Rename include guard.
 170         * target-float.h: Rename include guard.
 171         * stabsread.h: Add include guard.
 172         * rs6000-tdep.h: Add include guard.
 173         * riscv-fbsd-tdep.h: Add include guard.
 174         * regformats/regdef.h: Rename include guard.
 175         * record.h: Rename include guard.
 176         * python/python.h: Rename include guard.
 177         * python/python-internal.h: Rename include guard.
 178         * python/py-stopevent.h: Rename include guard.
 179         * python/py-ref.h: Rename include guard.
 180         * python/py-record.h: Rename include guard.
 181         * python/py-record-full.h: Rename include guard.
 182         * python/py-record-btrace.h: Rename include guard.
 183         * python/py-instruction.h: Rename include guard.
 184         * python/py-events.h: Rename include guard.
 185         * python/py-event.h: Rename include guard.
 186         * procfs.h: Add include guard.
 187         * proc-utils.h: Add include guard.
 188         * p-lang.h: Add include guard.
 189         * or1k-tdep.h: Rename include guard.
 190         * observable.h: Rename include guard.
 191         * nto-tdep.h: Rename include guard.
 192         * nat/x86-linux.h: Rename include guard.
 193         * nat/x86-linux-dregs.h: Rename include guard.
 194         * nat/x86-gcc-cpuid.h: Add include guard.
 195         * nat/x86-dregs.h: Rename include guard.
 196         * nat/x86-cpuid.h: Rename include guard.
 197         * nat/ppc-linux.h: Rename include guard.
 198         * nat/mips-linux-watch.h: Rename include guard.
 199         * nat/linux-waitpid.h: Rename include guard.
 200         * nat/linux-ptrace.h: Rename include guard.
 201         * nat/linux-procfs.h: Rename include guard.
 202         * nat/linux-osdata.h: Rename include guard.
 203         * nat/linux-nat.h: Rename include guard.
 204         * nat/linux-namespaces.h: Rename include guard.
 205         * nat/linux-btrace.h: Rename include guard.
 206         * nat/glibc_thread_db.h: Rename include guard.
 207         * nat/gdb_thread_db.h: Rename include guard.
 208         * nat/gdb_ptrace.h: Rename include guard.
 209         * nat/fork-inferior.h: Rename include guard.
 210         * nat/amd64-linux-siginfo.h: Rename include guard.
 211         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 212         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 213         * nat/aarch64-linux.h: Rename include guard.
 214         * nat/aarch64-linux-hw-point.h: Rename include guard.
 215         * mn10300-tdep.h: Add include guard.
 216         * mips-linux-tdep.h: Add include guard.
 217         * mi/mi-parse.h: Rename include guard.
 218         * mi/mi-out.h: Rename include guard.
 219         * mi/mi-main.h: Rename include guard.
 220         * mi/mi-interp.h: Rename include guard.
 221         * mi/mi-getopt.h: Rename include guard.
 222         * mi/mi-console.h: Rename include guard.
 223         * mi/mi-common.h: Rename include guard.
 224         * mi/mi-cmds.h: Rename include guard.
 225         * mi/mi-cmd-break.h: Rename include guard.
 226         * m2-lang.h: Add include guard.
 227         * location.h: Rename include guard.
 228         * linux-record.h: Rename include guard.
 229         * linux-nat.h: Add include guard.
 230         * linux-fork.h: Add include guard.
 231         * i386-darwin-tdep.h: Rename include guard.
 232         * hppa-linux-offsets.h: Add include guard.
 233         * guile/guile.h: Rename include guard.
 234         * guile/guile-internal.h: Rename include guard.
 235         * gnu-nat.h: Rename include guard.
 236         * gdb-stabs.h: Rename include guard.
 237         * frv-tdep.h: Add include guard.
 238         * f-lang.h: Add include guard.
 239         * event-loop.h: Add include guard.
 240         * darwin-nat.h: Rename include guard.
 241         * cp-abi.h: Rename include guard.
 242         * config/sparc/nm-sol2.h: Rename include guard.
 243         * config/nm-nto.h: Rename include guard.
 244         * config/nm-linux.h: Add include guard.
 245         * config/i386/nm-i386gnu.h: Rename include guard.
 246         * config/djgpp/nl_types.h: Rename include guard.
 247         * config/djgpp/langinfo.h: Rename include guard.
 248         * compile/gcc-cp-plugin.h: Add include guard.
 249         * compile/gcc-c-plugin.h: Add include guard.
 250         * compile/compile.h: Rename include guard.
 251         * compile/compile-object-run.h: Rename include guard.
 252         * compile/compile-object-load.h: Rename include guard.
 253         * compile/compile-internal.h: Rename include guard.
 254         * compile/compile-cplus.h: Rename include guard.
 255         * compile/compile-c.h: Rename include guard.
 256         * common/xml-utils.h: Rename include guard.
 257         * common/x86-xstate.h: Rename include guard.
 258         * common/version.h: Rename include guard.
 259         * common/vec.h: Rename include guard.
 260         * common/tdesc.h: Rename include guard.
 261         * common/selftest.h: Rename include guard.
 262         * common/scoped_restore.h: Rename include guard.
 263         * common/scoped_mmap.h: Rename include guard.
 264         * common/scoped_fd.h: Rename include guard.
 265         * common/safe-iterator.h: Rename include guard.
 266         * common/run-time-clock.h: Rename include guard.
 267         * common/refcounted-object.h: Rename include guard.
 268         * common/queue.h: Rename include guard.
 269         * common/ptid.h: Rename include guard.
 270         * common/print-utils.h: Rename include guard.
 271         * common/preprocessor.h: Rename include guard.
 272         * common/pathstuff.h: Rename include guard.
 273         * common/observable.h: Rename include guard.
 274         * common/netstuff.h: Rename include guard.
 275         * common/job-control.h: Rename include guard.
 276         * common/host-defs.h: Rename include guard.
 277         * common/gdb_wait.h: Rename include guard.
 278         * common/gdb_vecs.h: Rename include guard.
 279         * common/gdb_unlinker.h: Rename include guard.
 280         * common/gdb_unique_ptr.h: Rename include guard.
 281         * common/gdb_tilde_expand.h: Rename include guard.
 282         * common/gdb_sys_time.h: Rename include guard.
 283         * common/gdb_string_view.h: Rename include guard.
 284         * common/gdb_splay_tree.h: Rename include guard.
 285         * common/gdb_setjmp.h: Rename include guard.
 286         * common/gdb_ref_ptr.h: Rename include guard.
 287         * common/gdb_optional.h: Rename include guard.
 288         * common/gdb_locale.h: Rename include guard.
 289         * common/gdb_assert.h: Rename include guard.
 290         * common/filtered-iterator.h: Rename include guard.
 291         * common/filestuff.h: Rename include guard.
 292         * common/fileio.h: Rename include guard.
 293         * common/environ.h: Rename include guard.
 294         * common/common-utils.h: Rename include guard.
 295         * common/common-types.h: Rename include guard.
 296         * common/common-regcache.h: Rename include guard.
 297         * common/common-inferior.h: Rename include guard.
 298         * common/common-gdbthread.h: Rename include guard.
 299         * common/common-exceptions.h: Rename include guard.
 300         * common/common-defs.h: Rename include guard.
 301         * common/common-debug.h: Rename include guard.
 302         * common/cleanups.h: Rename include guard.
 303         * common/buffer.h: Rename include guard.
 304         * common/btrace-common.h: Rename include guard.
 305         * common/break-common.h: Rename include guard.
 306         * cli/cli-utils.h: Rename include guard.
 307         * cli/cli-style.h: Rename include guard.
 308         * cli/cli-setshow.h: Rename include guard.
 309         * cli/cli-script.h: Rename include guard.
 310         * cli/cli-interp.h: Rename include guard.
 311         * cli/cli-decode.h: Rename include guard.
 312         * cli/cli-cmds.h: Rename include guard.
 313         * charset-list.h: Add include guard.
 314         * buildsym-legacy.h: Rename include guard.
 315         * bfin-tdep.h: Add include guard.
 316         * ax.h: Rename include guard.
 317         * arm-linux-tdep.h: Add include guard.
 318         * arm-fbsd-tdep.h: Add include guard.
 319         * arch/xtensa.h: Rename include guard.
 320         * arch/tic6x.h: Add include guard.
 321         * arch/i386.h: Add include guard.
 322         * arch/arm.h: Rename include guard.
 323         * arch/arm-linux.h: Rename include guard.
 324         * arch/arm-get-next-pcs.h: Rename include guard.
 325         * arch/amd64.h: Add include guard.
 326         * arch/aarch64-insn.h: Rename include guard.
 327         * arch-utils.h: Rename include guard.
 328         * annotate.h: Add include guard.
 329         * amd64-darwin-tdep.h: Rename include guard.
 330         * aarch64-linux-tdep.h: Add include guard.
 331         * aarch64-fbsd-tdep.h: Add include guard.
 332         * aarch32-linux-nat.h: Add include guard.
 333
 334 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 335
 336         * macrotab.c (macro_define_internal): New function that
 337         factorizes macro_define_object_internal and macro_define_function
 338         code.
 339         (macro_define_object_internal): Use macro_define_internal.
 340         (macro_define_function): Likewise.
 341
 342 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 343
 344         * macrocmd.c (extract_identifier): Return
 345         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 346         callers.
 347
 348 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 349
 350         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 351
 352 2019-02-05  Tom Tromey  <tom@tromey.com>
 353
 354         * target.c (target_stack::unpush): Move assertion earlier.
 355
 356 2019-01-30  Tom Tromey  <tom@tromey.com>
 357
 358         PR python/23615:
 359         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 360         (gdbpy_parse_and_eval): Likewise.
 361         * python/python-internal.h (gdbpy_allow_threads): New class.
 362
 363 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 364
 365         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 366         (aarch64_fbsd_fpregmap): Move earlier.
 367         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 368         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 369         instead of individual calls to trad_frame_set_reg_addr.
 370         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 371         earlier.
 372         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 373         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 374         instead of individual calls to trad_frame_set_reg_addr.
 375
 376 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 377
 378         * CONTRIBUTE: Replace contribution list with wiki link.
 379
 380 2019-01-25  Tom Tromey  <tom@tromey.com>
 381
 382         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 383
 384 2019-01-25  Tom Tromey  <tom@tromey.com>
 385
 386         * xtensa-linux-nat.c: Fix common/ includes.
 387         * xml-support.h: Fix common/ includes.
 388         * xml-support.c: Fix common/ includes.
 389         * x86-linux-nat.c: Fix common/ includes.
 390         * windows-nat.c: Fix common/ includes.
 391         * varobj.h: Fix common/ includes.
 392         * varobj.c: Fix common/ includes.
 393         * value.c: Fix common/ includes.
 394         * valops.c: Fix common/ includes.
 395         * utils.c: Fix common/ includes.
 396         * unittests/xml-utils-selftests.c: Fix common/ includes.
 397         * unittests/utils-selftests.c: Fix common/ includes.
 398         * unittests/unpack-selftests.c: Fix common/ includes.
 399         * unittests/tracepoint-selftests.c: Fix common/ includes.
 400         * unittests/style-selftests.c: Fix common/ includes.
 401         * unittests/string_view-selftests.c: Fix common/ includes.
 402         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 403         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 404         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 405         * unittests/rsp-low-selftests.c: Fix common/ includes.
 406         * unittests/parse-connection-spec-selftests.c: Fix common/
 407         includes.
 408         * unittests/optional-selftests.c: Fix common/ includes.
 409         * unittests/offset-type-selftests.c: Fix common/ includes.
 410         * unittests/observable-selftests.c: Fix common/ includes.
 411         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 412         * unittests/memrange-selftests.c: Fix common/ includes.
 413         * unittests/memory-map-selftests.c: Fix common/ includes.
 414         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 415         * unittests/function-view-selftests.c: Fix common/ includes.
 416         * unittests/environ-selftests.c: Fix common/ includes.
 417         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 418         * unittests/common-utils-selftests.c: Fix common/ includes.
 419         * unittests/cli-utils-selftests.c: Fix common/ includes.
 420         * unittests/array-view-selftests.c: Fix common/ includes.
 421         * ui-file.c: Fix common/ includes.
 422         * tui/tui-io.c: Fix common/ includes.
 423         * tracepoint.h: Fix common/ includes.
 424         * tracepoint.c: Fix common/ includes.
 425         * tracefile-tfile.c: Fix common/ includes.
 426         * top.h: Fix common/ includes.
 427         * top.c: Fix common/ includes.
 428         * thread.c: Fix common/ includes.
 429         * target/waitstatus.h: Fix common/ includes.
 430         * target/waitstatus.c: Fix common/ includes.
 431         * target.h: Fix common/ includes.
 432         * target.c: Fix common/ includes.
 433         * target-memory.c: Fix common/ includes.
 434         * target-descriptions.c: Fix common/ includes.
 435         * symtab.h: Fix common/ includes.
 436         * symfile.c: Fix common/ includes.
 437         * stap-probe.c: Fix common/ includes.
 438         * spu-linux-nat.c: Fix common/ includes.
 439         * sparc-nat.c: Fix common/ includes.
 440         * source.c: Fix common/ includes.
 441         * solib.c: Fix common/ includes.
 442         * solib-target.c: Fix common/ includes.
 443         * ser-unix.c: Fix common/ includes.
 444         * ser-tcp.c: Fix common/ includes.
 445         * ser-pipe.c: Fix common/ includes.
 446         * ser-base.c: Fix common/ includes.
 447         * selftest-arch.c: Fix common/ includes.
 448         * s12z-tdep.c: Fix common/ includes.
 449         * rust-exp.y: Fix common/ includes.
 450         * rs6000-aix-tdep.c: Fix common/ includes.
 451         * riscv-tdep.c: Fix common/ includes.
 452         * remote.c: Fix common/ includes.
 453         * remote-notif.h: Fix common/ includes.
 454         * remote-fileio.h: Fix common/ includes.
 455         * remote-fileio.c: Fix common/ includes.
 456         * regcache.h: Fix common/ includes.
 457         * regcache.c: Fix common/ includes.
 458         * record-btrace.c: Fix common/ includes.
 459         * python/python.c: Fix common/ includes.
 460         * python/py-type.c: Fix common/ includes.
 461         * python/py-inferior.c: Fix common/ includes.
 462         * progspace.h: Fix common/ includes.
 463         * producer.c: Fix common/ includes.
 464         * procfs.c: Fix common/ includes.
 465         * proc-api.c: Fix common/ includes.
 466         * printcmd.c: Fix common/ includes.
 467         * ppc-linux-nat.c: Fix common/ includes.
 468         * parser-defs.h: Fix common/ includes.
 469         * osdata.c: Fix common/ includes.
 470         * obsd-nat.c: Fix common/ includes.
 471         * nat/x86-linux.c: Fix common/ includes.
 472         * nat/x86-linux-dregs.c: Fix common/ includes.
 473         * nat/x86-dregs.h: Fix common/ includes.
 474         * nat/x86-dregs.c: Fix common/ includes.
 475         * nat/ppc-linux.c: Fix common/ includes.
 476         * nat/mips-linux-watch.h: Fix common/ includes.
 477         * nat/mips-linux-watch.c: Fix common/ includes.
 478         * nat/linux-waitpid.c: Fix common/ includes.
 479         * nat/linux-ptrace.h: Fix common/ includes.
 480         * nat/linux-ptrace.c: Fix common/ includes.
 481         * nat/linux-procfs.c: Fix common/ includes.
 482         * nat/linux-personality.c: Fix common/ includes.
 483         * nat/linux-osdata.c: Fix common/ includes.
 484         * nat/linux-namespaces.c: Fix common/ includes.
 485         * nat/linux-btrace.h: Fix common/ includes.
 486         * nat/linux-btrace.c: Fix common/ includes.
 487         * nat/fork-inferior.c: Fix common/ includes.
 488         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 489         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 490         * nat/aarch64-linux.c: Fix common/ includes.
 491         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 492         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 493         * namespace.h: Fix common/ includes.
 494         * mips-linux-tdep.c: Fix common/ includes.
 495         * minsyms.c: Fix common/ includes.
 496         * mi/mi-parse.h: Fix common/ includes.
 497         * mi/mi-main.c: Fix common/ includes.
 498         * mi/mi-cmd-env.c: Fix common/ includes.
 499         * memrange.h: Fix common/ includes.
 500         * memattr.c: Fix common/ includes.
 501         * maint.h: Fix common/ includes.
 502         * maint.c: Fix common/ includes.
 503         * main.c: Fix common/ includes.
 504         * machoread.c: Fix common/ includes.
 505         * location.c: Fix common/ includes.
 506         * linux-thread-db.c: Fix common/ includes.
 507         * linux-nat.c: Fix common/ includes.
 508         * linux-fork.c: Fix common/ includes.
 509         * inline-frame.c: Fix common/ includes.
 510         * infrun.c: Fix common/ includes.
 511         * inflow.c: Fix common/ includes.
 512         * inferior.h: Fix common/ includes.
 513         * inferior.c: Fix common/ includes.
 514         * infcmd.c: Fix common/ includes.
 515         * inf-ptrace.c: Fix common/ includes.
 516         * inf-child.c: Fix common/ includes.
 517         * ia64-linux-nat.c: Fix common/ includes.
 518         * i387-tdep.c: Fix common/ includes.
 519         * i386-tdep.c: Fix common/ includes.
 520         * i386-linux-tdep.c: Fix common/ includes.
 521         * i386-linux-nat.c: Fix common/ includes.
 522         * i386-go32-tdep.c: Fix common/ includes.
 523         * i386-fbsd-tdep.c: Fix common/ includes.
 524         * i386-fbsd-nat.c: Fix common/ includes.
 525         * guile/scm-type.c: Fix common/ includes.
 526         * guile/guile.c: Fix common/ includes.
 527         * go32-nat.c: Fix common/ includes.
 528         * gnu-nat.c: Fix common/ includes.
 529         * gdbthread.h: Fix common/ includes.
 530         * gdbarch-selftests.c: Fix common/ includes.
 531         * gdb_usleep.c: Fix common/ includes.
 532         * gdb_select.h: Fix common/ includes.
 533         * gdb_bfd.c: Fix common/ includes.
 534         * gcore.c: Fix common/ includes.
 535         * fork-child.c: Fix common/ includes.
 536         * findvar.c: Fix common/ includes.
 537         * fbsd-nat.c: Fix common/ includes.
 538         * event-top.c: Fix common/ includes.
 539         * event-loop.c: Fix common/ includes.
 540         * dwarf2read.c: Fix common/ includes.
 541         * dwarf2loc.c: Fix common/ includes.
 542         * dwarf2-frame.c: Fix common/ includes.
 543         * dwarf-index-cache.c: Fix common/ includes.
 544         * dtrace-probe.c: Fix common/ includes.
 545         * disasm-selftests.c: Fix common/ includes.
 546         * defs.h: Fix common/ includes.
 547         * csky-tdep.c: Fix common/ includes.
 548         * cp-valprint.c: Fix common/ includes.
 549         * cp-support.h: Fix common/ includes.
 550         * cp-support.c: Fix common/ includes.
 551         * corelow.c: Fix common/ includes.
 552         * completer.h: Fix common/ includes.
 553         * completer.c: Fix common/ includes.
 554         * compile/compile.c: Fix common/ includes.
 555         * compile/compile-loc2c.c: Fix common/ includes.
 556         * compile/compile-cplus-types.c: Fix common/ includes.
 557         * compile/compile-cplus-symbols.c: Fix common/ includes.
 558         * command.h: Fix common/ includes.
 559         * cli/cli-dump.c: Fix common/ includes.
 560         * cli/cli-cmds.c: Fix common/ includes.
 561         * charset.c: Fix common/ includes.
 562         * build-id.c: Fix common/ includes.
 563         * btrace.h: Fix common/ includes.
 564         * btrace.c: Fix common/ includes.
 565         * breakpoint.h: Fix common/ includes.
 566         * breakpoint.c: Fix common/ includes.
 567         * ax.h:
 568         (enum agent_op): Fix common/ includes.
 569         * ax-general.c (struct aop_map): Fix common/ includes.
 570         * ax-gdb.c: Fix common/ includes.
 571         * auxv.c: Fix common/ includes.
 572         * auto-load.c: Fix common/ includes.
 573         * arm-tdep.c: Fix common/ includes.
 574         * arch/riscv.c: Fix common/ includes.
 575         * arch/ppc-linux-common.c: Fix common/ includes.
 576         * arch/i386.c: Fix common/ includes.
 577         * arch/arm.c: Fix common/ includes.
 578         * arch/arm-linux.c: Fix common/ includes.
 579         * arch/arm-get-next-pcs.c: Fix common/ includes.
 580         * arch/amd64.c: Fix common/ includes.
 581         * arch/aarch64.c: Fix common/ includes.
 582         * arch/aarch64-insn.c: Fix common/ includes.
 583         * arch-utils.c: Fix common/ includes.
 584         * amd64-windows-tdep.c: Fix common/ includes.
 585         * amd64-tdep.c: Fix common/ includes.
 586         * amd64-sol2-tdep.c: Fix common/ includes.
 587         * amd64-obsd-tdep.c: Fix common/ includes.
 588         * amd64-nbsd-tdep.c: Fix common/ includes.
 589         * amd64-linux-tdep.c: Fix common/ includes.
 590         * amd64-linux-nat.c: Fix common/ includes.
 591         * amd64-fbsd-tdep.c: Fix common/ includes.
 592         * amd64-fbsd-nat.c: Fix common/ includes.
 593         * amd64-dicos-tdep.c: Fix common/ includes.
 594         * amd64-darwin-tdep.c: Fix common/ includes.
 595         * agent.c: Fix common/ includes.
 596         * ada-lang.h: Fix common/ includes.
 597         * ada-lang.c: Fix common/ includes.
 598         * aarch64-tdep.c: Fix common/ includes.
 599
 600 2019-01-25  Tom Tromey  <tom@tromey.com>
 601
 602         * common/create-version.sh: Use common/version.h.
 603
 604 2019-01-24  Pedro Alves  <palves@redhat.com>
 605
 606         * infrun.c (signal_stop, signal_print, signal_program)
 607         (signal_catch, signal_pass): Now arrays instead of pointers.
 608         (update_signals_program_target, do_target_resume)
 609         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 610         * linux-nat.c (linux_nat_target::pass_signals)
 611         (linux_nat_target::create_inferior, linux_nat_target::attach):
 612         Adjust.
 613         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 614         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 615         * procfs.c (procfs_target::pass_signals): Adjust.
 616         * record-full.c (record_full_target::resume): Adjust.
 617         * remote.c (remote_target::pass_signals)
 618         (remote_target::program_signals): Adjust.
 619         * target-debug.h (target_debug_print_signals): Now takes a
 620         gdb::array_view as parameter.  Adjust.
 621         * target.h (target_ops) <pass_signals, program_signals>: Replace
 622         pointer and length parameters with gdb::array_view.
 623         (target_pass_signals, target_program_signals): Likewise.
 624         * target-delegates.c: Regenerate.
 625
 626 2019-01-24  Pedro Alves  <palves@redhat.com>
 627
 628         * common/forward-scope-exit.h
 629         (forward_scope_exit::forward_scope_exit): Pass arguments to
 630         m_bind_function directly, instead of creating a std::bind and
 631         copying that.
 632
 633 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 634
 635         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 636         for static members.
 637         (pass_in_v_vfp_candidate): Likewise.
 638
 639 2019-01-23  Tom Tromey  <tom@tromey.com>
 640             Pedro Alves  <palves@redhat.com>
 641
 642         * regcache.c (class regcache_invalidator): Remove.
 643         (regcache::raw_write): Use make_scope_exit.
 644
 645 2019-01-23  Tom Tromey  <tom@tromey.com>
 646
 647         * ui-out.h (class ui_out_emit_type): Update comment.
 648
 649 2019-01-23  Tom Tromey  <tom@tromey.com>
 650
 651         * infrun.c (fetch_inferior_event): Update comment.
 652
 653 2019-01-23  Tom Tromey  <tom@tromey.com>
 654             Pedro Alves  <palves@redhat.com>
 655
 656         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 657         parameter.
 658         (fetch_inferior_event): Use SCOPE_EXIT.
 659
 660
 661 2019-01-23  Tom Tromey  <tom@tromey.com>
 662             Pedro Alves  <palves@redhat.com>
 663
 664         * infrun.c (disable_thread_events): Delete.
 665         (stop_all_threads): Use SCOPE_EXIT.
 666
 667 2019-01-23  Tom Tromey  <tom@tromey.com>
 668             Pedro Alves  <palves@redhat.com>
 669
 670         * symfile.c: Include forward-scope-exit.h.
 671         (clear_symtab_users_cleanup): Replace forward declaration with
 672         a FORWARD_SCOPE_EXIT.
 673         (syms_from_objfile_1): Use the forward_scope_exit and
 674         gdb::optional instead of cleanup_function.
 675         (reread_symbols): Use the forward_scope_exit instead of
 676         cleanup_function.
 677         (clear_symtab_users_cleanup): Remove function.
 678
 679 2019-01-23  Tom Tromey  <tom@tromey.com>
 680             Pedro Alves  <palves@redhat.com>
 681
 682         * linux-nat.c: Include scope-exit.h.
 683         (cleanup_target_stop): Remove.
 684         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 685         SCOPE_EXIT.
 686
 687 2019-01-23  Tom Tromey  <tom@tromey.com>
 688             Pedro Alves  <palves@redhat.com>
 689
 690         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 691         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 692
 693 2019-01-23  Tom Tromey  <tom@tromey.com>
 694             Andrew Burgess  <andrew.burgess@embecosm.com>
 695             Pedro Alves  <palves@redhat.com>
 696
 697         * infrun.c (fetch_inferior_event): Use scope_exit.
 698         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 699         * top.c (execute_command): Use scope_exit.
 700         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 701         * utils.c (do_bpstat_clear_actions_cleanup)
 702         (make_bpstat_clear_actions_cleanup): Remove.
 703
 704 2019-01-23  Tom Tromey  <tom@tromey.com>
 705             Pedro Alves  <palves@redhat.com>
 706
 707         * infrun.c: Include "common/scope-exit.h"
 708         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 709         (wait_for_inferior): Use SCOPE_EXIT.
 710         (fetch_inferior_event): Use scope_exit.
 711
 712 2019-01-23  Tom Tromey  <tom@tromey.com>
 713             Pedro Alves  <palves@redhat.com>
 714
 715         * breakpoint.c (create_breakpoint): Remove cleanup.
 716
 717 2019-01-23  Tom Tromey  <tom@tromey.com>
 718             Andrew Burgess  <andrew.burgess@embecosm.com>
 719             Pedro Alves  <palves@redhat.com>
 720
 721 2019-01-23  Pedro Alves  <palves@redhat.com>
 722
 723         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 724
 725 2019-01-23  Pedro Alves  <palves@redhat.com>
 726             Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * gdbthread.h: Include "common/forward-scope-exit.h".
 729         (scoped_finish_thread_state): Redefine custom class in terms of
 730         forward_scope_exit.
 731
 732 2019-01-23  Pedro Alves  <palves@redhat.com>
 733             Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * common/forward-scope-exit.h: New file.
 736
 737 2019-01-23  Pedro Alves  <palves@redhat.com>
 738             Andrew Burgess  <andrew.burgess@embecosm.com>
 739             Tom Tromey  <tom@tromey.com>
 740
 741         * common/scope-exit.h: New file.
 742
 743 2019-01-23  Pedro Alves  <palves@redhat.com>
 744
 745         * common/preprocessor.h (ESC): Rename to ...
 746         (ESC_PARENS): ... this.
 747         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 748         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 749
 750 2019-01-23  Tom Tromey  <tom@tromey.com>
 751
 752         * language.h (class scoped_switch_to_sym_language_if_auto):
 753         Initialize m_lang in both cases.
 754
 755 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 756
 757         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 758         with XCNEW.
 759
 760 2019-01-22  Tom Tromey  <tom@tromey.com>
 761
 762         * corelow.c: Do not include sys/file.h.
 763
 764 2019-01-22  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-wingeneral.h: Include gdb_curses.h.
 767
 768 2019-01-22  Tom Tromey  <tom@tromey.com>
 769
 770         * source-cache.h (class source_cache) <get_source_lines,
 771         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 772
 773 2019-01-22  Tom Tromey  <tom@tromey.com>
 774
 775         * remote-fileio.h (struct remote_target): Declare.
 776
 777 2019-01-22  Tom Tromey  <tom@tromey.com>
 778
 779         * python/py-arch.c: Do not include py-ref.h.
 780         * python/py-bpevent.c: Do not include py-ref.h.
 781         * python/py-cmd.c: Do not include py-ref.h.
 782         * python/py-continueevent.c: Do not include py-ref.h.
 783         * python/py-event.h: Do not include py-ref.h.
 784         * python/py-evtregistry.c: Do not include py-ref.h.
 785         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 786         * python/py-frame.c: Do not include py-ref.h.
 787         * python/py-framefilter.c: Do not include py-ref.h.
 788         * python/py-function.c: Do not include py-ref.h.
 789         * python/py-infevents.c: Do not include py-ref.h.
 790         * python/py-linetable.c: Do not include py-ref.h.
 791         * python/py-objfile.c: Do not include py-ref.h.
 792         * python/py-param.c: Do not include py-ref.h.
 793         * python/py-prettyprint.c: Do not include py-ref.h.
 794         * python/py-progspace.c: Do not include py-ref.h.
 795         * python/py-symbol.c: Do not include py-ref.h.
 796         * python/py-symtab.c: Do not include py-ref.h.
 797         * python/py-type.c: Do not include py-ref.h.
 798         * python/py-unwind.c: Do not include py-ref.h.
 799         * python/py-utils.c: Do not include py-ref.h.
 800         * python/py-value.c: Do not include py-ref.h.
 801         * python/py-varobj.c: Do not include py-ref.h.
 802         * python/py-xmethods.c: Do not include py-ref.h.
 803         * python/python.c: Do not include py-ref.h.
 804         * varobj.c: Do not include py-ref.h.
 805
 806 2019-01-22  Tom Tromey  <tom@tromey.com>
 807
 808         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 809         keyword for bcache.
 810
 811 2019-01-22  Tom Tromey  <tom@tromey.com>
 812
 813         * compile/compile-cplus-types.c: Remove a comment by #include.
 814
 815 2019-01-22  Tom Tromey  <tom@tromey.com>
 816
 817         * compile/gcc-c-plugin.h: Include compile-internal.h.
 818
 819 2019-01-22  Tom Tromey  <tom@tromey.com>
 820
 821         * stabsread.c (EXTERN): Do not define.
 822         (symnum, next_symbol_text_func, processing_gcc_compilation)
 823         (within_function, global_sym_chain, global_stabs)
 824         (previous_stab_code, this_object_header_files)
 825         (n_this_object_header_files)
 826         (n_allocated_this_object_header_files): Define.
 827         * stabsread.h (EXTERN): Never define.  Use "extern".
 828
 829 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 830
 831         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 832         history_value.
 833
 834 2019-01-21  Tom Tromey  <tom@tromey.com>
 835
 836         * ui-out.c: Fix includes.
 837         * tui/tui-source.c: Fix includes.
 838         * target.c: Fix includes.
 839         * remote.c: Fix includes.
 840         * regcache.c: Fix includes.
 841         * python/py-block.c: Fix includes.
 842         * printcmd.c: Fix includes.
 843         * or1k-tdep.c: Fix includes.
 844         * mi/mi-main.c: Fix includes.
 845         * m32r-tdep.c: Fix includes.
 846         * csky-tdep.c: Fix includes.
 847         * compile/compile-cplus-types.c: Fix includes.
 848         * cli/cli-interp.c: Fix includes.
 849
 850 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 851
 852         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 853         for padding.
 854
 855 2019-01-16  Tom Tromey  <tom@tromey.com>
 856
 857         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 858         earlier.
 859         (struct objfile) <msymbols_range>: Move from top level.
 860         <msymbols>: New method.
 861         (class objfile_msymbols): Remove.
 862         * symtab.c (default_collect_symbol_completion_matches_break_on):
 863         Update.
 864         * symmisc.c (dump_msymbols): Update.
 865         * stabsread.c (scan_file_globals): Update.
 866         * objc-lang.c (info_selectors_command, info_classes_command)
 867         (find_methods): Update.
 868         * minsyms.c (find_solib_trampoline_target): Update.
 869         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 870         * coffread.c (coff_symfile_read): Update.
 871         * ada-lang.c (ada_lookup_simple_minsym)
 872         (ada_collect_symbol_completion_matches): Update.
 873
 874 2019-01-16  Tom Tromey  <tom@tromey.com>
 875
 876         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 877         type.  Remove no-argument constructor.
 878         <iterator::operator++>: Simplify.
 879         <begin>: Update.
 880         <end>: Use minimal_symbol_count.
 881
 882 2019-01-16  Tom Tromey  <tom@tromey.com>
 883
 884         * objfiles.h (struct objfile) <psymtabs>: New method.
 885         (class objfile_psymtabs): Remove.
 886         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 887         typedef.
 888         <range>: New method.
 889         (require_partial_symbols): Change return type.
 890         * psymtab.c (require_partial_symbols)
 891         (psym_expand_symtabs_matching): Update.
 892         * mdebugread.c (parse_partial_symbols): Update.
 893         * dbxread.c (dbx_end_psymtab): Update.
 894
 895 2019-01-15  Tom Tromey  <tom@tromey.com>
 896
 897         * symtab.c (lookup_objfile_from_block)
 898         (lookup_symbol_in_objfile_symtabs)
 899         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 900         (find_line_symtab, info_sources_command)
 901         (default_collect_symbol_completion_matches_break_on)
 902         (make_source_files_completion_list): Update.
 903         * symmisc.c (print_objfile_statistics, dump_objfile)
 904         (maintenance_print_symbols, maintenance_info_symtabs)
 905         (maintenance_check_symtabs, maintenance_info_line_tables):
 906         Update.
 907         * source.c (select_source_symtab)
 908         (forget_cached_source_info_for_objfile): Update.
 909         * objfiles.h (class objfile_compunits): Remove.
 910         (struct objfile) <compunits_range>: New typedef.
 911         (compunits): New method.
 912         * objfiles.c (objfile_relocate1): Update.
 913         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 914         * maint.c (count_symtabs_and_blocks): Update.
 915         * linespec.c (iterate_over_all_matching_symtabs): Update.
 916         * cp-support.c (add_symbol_overload_list_qualified): Update.
 917         * coffread.c (coff_symtab_read): Update.
 918         * ada-lang.c (add_nonlocal_symbols)
 919         (ada_collect_symbol_completion_matches)
 920         (ada_add_global_exceptions): Update.
 921
 922 2019-01-15  Tom Tromey  <tom@tromey.com>
 923
 924         * progspace.h (program_space) <objfiles_safe_range>: New
 925         typedef.
 926         <objfiles_safe>: New method.
 927         * objfiles.h (class all_objfiles_safe): Remove.
 928         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 929         * jit.c (jit_inferior_exit_hook): Update.
 930
 931 2019-01-17  Tom Tromey  <tom@tromey.com>
 932
 933         * progspace.h (program_space) <objfiles_range>: New typedef.
 934         <objfiles>: New method.
 935         <objfiles_head>: Rename from objfiles.
 936         (object_files): Update.
 937         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 938         * guile/scm-pretty-print.c
 939         (ppscm_find_pretty_printer_from_objfiles): Update.
 940         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 941         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 942         Update.
 943         * python/py-progspace.c (pspy_get_objfiles): Update.
 944         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 945         Update.
 946         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 947         (objfpy_lookup_objfile_by_build_id): Update.
 948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 949         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 950         Update.
 951         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 952         (expand_symtab_containing_pc, lookup_objfile_from_block)
 953         (lookup_static_symbol, basic_lookup_transparent_type)
 954         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 955         (find_line_symtab, info_sources_command)
 956         (default_collect_symbol_completion_matches_break_on)
 957         (make_source_files_completion_list, find_main_name): Update.
 958         * symmisc.c (print_symbol_bcache_statistics)
 959         (print_objfile_statistics, maintenance_print_symbols)
 960         (maintenance_print_msymbols, maintenance_print_objfiles)
 961         (maintenance_info_symtabs, maintenance_check_symtabs)
 962         (maintenance_expand_symtabs, maintenance_info_line_tables):
 963         Update.
 964         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 965         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 966         (map_overlay_command, unmap_overlay_command)
 967         (simple_overlay_update, expand_symtabs_matching)
 968         (map_symbol_filenames): Update.
 969         * symfile-debug.c (set_debug_symfile): Update.
 970         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 971         Update.
 972         * source.c (select_source_symtab, forget_cached_source_info):
 973         Update.
 974         * solib.c (solib_read_symbols): Update.
 975         * solib-spu.c (append_ocl_sos): Update.
 976         * psymtab.c (maintenance_print_psymbols)
 977         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 978         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 979         * printcmd.c (info_symbol_command): Update.
 980         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 981         Update.
 982         * objfiles.h (class all_objfiles): Remove.
 983         * objfiles.c (have_partial_symbols, have_full_symbols)
 984         (have_minimal_symbols, qsort_cmp, update_section_map)
 985         (shared_objfile_contains_address_p)
 986         (default_iterate_over_objfiles_in_search_order): Update.
 987         * objc-lang.c (info_selectors_command, info_classes_command)
 988         (find_methods): Update.
 989         * minsyms.c (find_solib_trampoline_target): Update.
 990         * maint.c (maintenance_info_sections)
 991         (maintenance_translate_address, count_symtabs_and_blocks):
 992         Update.
 993         * main.c (captured_main_1): Update.
 994         * linux-thread-db.c (try_thread_db_load_from_pdir)
 995         (has_libpthread): Update.
 996         * linespec.c (iterate_over_all_matching_symtabs)
 997         (search_minsyms_for_name): Update.
 998         * jit.c (jit_find_objf_with_entry_addr): Update.
 999         * hppa-tdep.c (find_unwind_entry)
1000         (hppa_lookup_stub_minimal_symbol): Update.
1001         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1002         Update.
1003         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1004         (elf_gnu_ifunc_resolve_by_got): Update.
1005         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1006         * dwarf-index-write.c (save_gdb_index_command): Update.
1007         * cp-support.c (add_symbol_overload_list_qualified): Update.
1008         * breakpoint.c (create_overlay_event_breakpoint)
1009         (create_longjmp_master_breakpoint)
1010         (create_std_terminate_master_breakpoint)
1011         (create_exception_master_breakpoint): Update.
1012         * blockframe.c (find_pc_partial_function): Update.
1013         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1014         (ada_collect_symbol_completion_matches)
1015         (ada_add_global_exceptions): Update.
1016
1017 2019-01-17  Tom Tromey  <tom@tromey.com>
1018
1019         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1020         declare VEC.
1021         (solib_target_parse_libraries): Change return type.
1022         (library_list_start_segment, library_list_start_section)
1023         (library_list_end_library, library_list_start_library); Update.
1024         (solib_target_free_library_list): Remove.
1025         (solib_target_parse_libraries): Remove cleanup.  Change return
1026         type.
1027         (solib_target_current_sos): Update.
1028
1029 2019-01-17  Tom Tromey  <tromey@bapiya>
1030
1031         * valprint.c: Replace "the the" with "the".
1032         * symtab.c: Replace "the the" with "the".
1033         * solib.c: Replace "the the" with "the".
1034         * solib-dsbt.c: Replace "the the" with "the".
1035         * linespec.c: Replace "the the" with "the".
1036         * dwarf2loc.h: Replace "the the" with "the".
1037         * amd64-windows-tdep.c: Replace "the the" with "the".
1038         * aarch64-tdep.c: Replace "the the" with "the".
1039
1040 2019-01-16  Keith Seitz  <keiths@redhat.com>
1041
1042         PR gdb/23773
1043         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1044         <builder>: Rename to ..
1045         <m_builder>: ... this and make private.
1046         (dwarf2_cu::get_builder): New method.  Change all users of
1047         `builder' to use this method.
1048         (dwarf2_start_symtab): Move to ...
1049         (dwarf2_cu::start_symtab): ... here.  Update all callers
1050         (setup_type_unit_groups): Move to ...
1051         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1052         callers.
1053         (dwarf2_cu::reset_builder): New method.
1054         (process_full_compunit, process_full_type_unit): Use
1055         dwarf2_cu::reset_builder.
1056         (follow_die_offset): Record the ancestor CU if it is different
1057         from the followed DIE's CU.
1058         (follow_die_sig_1): Likewise.
1059
1060 2019-01-15  Tom Tromey  <tom@tromey.com>
1061
1062         * remote.c (class remote_state) <buf>: Now a char_vector.
1063         <buf_size>: Remove.
1064         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1065         parameter.
1066         (remote_target::getpkt_or_notif_sane_1)
1067         (remote_target::getpkt_sane)
1068         (remote_target::getpkt_or_notif_sane): Likewise.
1069         (class remote_target) <putpkt>: New overload.
1070         (remote_target::read_frame): Change type of "buf_p".  Remove
1071         sizeof_p parameter.
1072         (packet_ok): New overload.
1073         (packet_check_result): New overload.
1074         Update all uses.
1075
1076 2019-01-14  Tom Tromey  <tom@tromey.com>
1077
1078         * remote-notif.c (handle_notification, remote_notif_ack)
1079         (remote_notif_parse): Make "buf" const.
1080         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1081         const.
1082         (remote_notif_parse, remote_notif_ack, handle_notification):
1083         Likewise.
1084         * remote.c (remote_notif_stop_parse): Make "buf" const.
1085         (remote_target::remote_parse_stop_reply): Make "buf" const.
1086         (remote_notif_stop_ack): Make "buf" const.
1087
1088 2019-01-14  Tom Tromey  <tom@tromey.com>
1089
1090         * remote.c (remote_console_output): Make parameter const.
1091
1092 2019-01-14  Tom Tromey  <tom@tromey.com>
1093
1094         * target-debug.h (target_debug_print_signals): Constify.
1095         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1096         * procfs.c (procfs_target::pass_signals): Update.
1097         * linux-nat.c (linux_nat_target::pass_signals): Update.
1098         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1099         * target-delegates.c: Rebuild.
1100         * remote.c (remote_target::program_signals): Update.
1101         (remote_target::pass_signals): Update.
1102         * target.c (target_pass_signals): Constify argument.
1103         (target_program_signals): Likewise.
1104         * target.h (struct target_ops) <pass_signals, program_signals>:
1105         Constify argument.
1106         (target_pass_signals, target_program_signals): Constify argument.
1107
1108 2019-01-14  Tom Tromey  <tom@tromey.com>
1109
1110         PR tui/28819:
1111         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1112
1113 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1114
1115         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1116         field.
1117         * rs6000-tdep.c: Include reggroups.h.
1118         (IS_V_ALIAS_PSEUDOREG): Define.
1119         (rs6000_register_name): Return names for the "vX" aliases.
1120         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1121         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1122         aliases.  Call default_register_reggroup_p for all other
1123         pseudo-registers.
1124         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1125         New functions.
1126         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1127         Handle "vX" aliases.
1128         (v_alias_pseudo_register_collect): New function.
1129         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1130         (rs6000_gdbarch_init): Initialize "vX" aliases as
1131         pseudo-registers.  Restore registration of
1132         rs6000_pseudo_register_reggroup_p with
1133         set_tdesc_pseudo_register_reggroup_p.
1134
1135 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1136
1137         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1138         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1139         set_gdbarch_num_pseudo_regs.
1140
1141 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1142
1143         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1144         Remove arg prefixname, add do_set and do_show.
1145         Add member functions set_list and show_list.
1146         * cli/cli-style.c (class cli_style_option): Update accordingly.
1147         (style_set_list): Move to file scope.
1148         (style_show_list): Likewise.
1149         (set_style): Call help_list.
1150         (show_style): Call cmd_show_list.
1151         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1152         Update to use the new macro.
1153
1154 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1155
1156         * ada-lang.c (_initialize_ada_language): Expand the help text
1157         for the "catch exception" command.
1158
1159 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1160
1161         * symtab.c (matching_obj_sections): Initialize obj,
1162         declare it closer to its usage.
1163
1164 2019-01-10  Tom Tromey  <tom@tromey.com>
1165
1166         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1167         (basic_inf_threads_range): Remove.
1168         (inf_threads_range, inf_non_exited_threads_range)
1169         (safe_inf_threads_range): Use next_adapter.
1170
1171 2019-01-10  Keith Seitz  <keiths@redhat.com>
1172
1173         PR gdb/23712
1174         PR symtab/23010
1175         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1176         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1177
1178 2019-01-10  Keith Seitz  <keiths@redhat.com>
1179
1180         PR gdb/23712
1181         PR symtab/23010
1182         * dictionary.c (pending_to_vector): Remove.
1183         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1184         Remove _1 suffix, replacing functions of the same name.  Update
1185         all callers.
1186         (dict_create_hashed, dict_create_hashed_expandable)
1187         (dict_create_linear, dict_create_linear_expandable, dict_free)
1188         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1189         Make functions static.
1190
1191 2019-01-10  Keith Seitz  <keiths@redhat.com>
1192
1193         PR gdb/23712
1194         PR symtab/23010
1195         * dictionary.h (struct dictionary): Replace declaration with
1196         multidictionary.
1197         (dict_create_hashed, dict_create_hashed_expandable)
1198         (dict_create_linear, dict_create_linear_expandable)
1199         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1200         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1201         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1202         taking multidictionary argument.
1203         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1204         * block.h (struct block) <dict>: Change to multidictionary
1205         and rename `multidict'.
1206         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1207         symmisc.c: Update all dictionary references to multidictionary.
1208
1209 2019-01-10  Keith Seitz  <keiths@redhat.com>
1210
1211         PR gdb/23712
1212         PR symtab/23010
1213         * dictionary.c: Include unordered_map.
1214         (pending_to_vector): New function.
1215         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1216         Rewrite the non-"_1" functions to take vector instead
1217         of linked list.
1218         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1219         "new" _1 versions of the same name.
1220         (multidictionary): Define.
1221         (std::hash<enum language): New definition.
1222         (collate_pending_symbols_by_language, mdict_create_hashed)
1223         (mdict_create_hashed_expandable, mdict_create_linear)
1224         (mdict_create_linear_expandable, mdict_free)
1225         (find_language_dictionary, create_new_language_dictionary)
1226         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1227         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1228         (mdict_size, mdict_empty): New functions.
1229         * dictionary.h (mdict_iterator): Define.
1230
1231 2019-01-10  Pedro Alves  <palves@redhat.com>
1232
1233         * breakpoint.c (read_uploaded_action)
1234         (create_tracepoint_from_upload): Adjust to use
1235         gdb::unique_xmalloc_ptr.
1236         * ctf.c (ctf_write_uploaded_tp):
1237         (SET_ARRAY_FIELD): Use emplace_back.
1238         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1239         * tracefile-tfile.c (tfile_write_uploaded_tp):
1240         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1241         gdb::unique_xmalloc_ptr.
1242         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1243         at_string, cond_string, cmd_strings>: Replace char pointers
1244         with gdb::unique_xmalloc_ptr.
1245
1246 2019-01-10  Pedro Alves  <palves@redhat.com>
1247
1248         * solib-target.c (library_list_start_library): Don't xstrdup name.
1249
1250 2019-01-10  Pedro Alves  <palves@redhat.com>
1251
1252         * mdebugread.c (parse_partial_symbols): Use
1253         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1254
1255 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * linux-fork.c (scoped_switch_fork_info)
1258         <~scoped_switch_fork_info>: Fix incorrect variable name.
1259
1260 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * linux-fork.c (scoped_switch_fork_info)
1263         <scoped_switch_fork_info>: Make explicit.
1264         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1265
1266 2019-01-10  Tom Tromey  <tom@tromey.com>
1267
1268         * objfiles.h (objfile::reset_psymtabs): Update.
1269         * objfiles.c (objfile::objfile): Update.
1270         * psymtab.h (psymtab_storage::obstack): Update.
1271         (psymtab_storage::m_obstack): Use gdb::optional.
1272         (class psymtab_storage): Update comment.  Remove objfile
1273         parameter.
1274         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1275
1276 2019-01-10  Tom Tromey  <tom@tromey.com>
1277
1278         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1279         <free_psymtabs>: Now private.
1280         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1281         (allocate_psymtab): Use new method.
1282
1283 2019-01-10  Tom Tromey  <tom@tromey.com>
1284
1285         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1286         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1287         * mdebugread.c (parse_partial_symbols): Use
1288         allocate_dependencies.
1289         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1290         allocate_dependencies.
1291         (process_psymtab_comp_unit_reader)
1292         (build_type_psymtab_dependencies): Likewise.
1293         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1294
1295 2019-01-10  Tom Tromey  <tom@tromey.com>
1296
1297         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1298         PSYMBOL_SET_LANGUAGE.
1299         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1300
1301 2019-01-10  Tom Tromey  <tom@tromey.com>
1302
1303         * psymtab.h (psymtab_storage::obstack): New method.
1304         <m_obstack>: Rename from obstack; now private.
1305         * psymtab.c (psymtab_storage): Update.
1306         * dwarf2read.c (create_addrmap_from_index)
1307         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1308         Update.
1309
1310 2019-01-10  Tom Tromey  <tom@tromey.com>
1311
1312         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1313         * objfiles.h (objfile::reset_psymtabs): New method.
1314
1315 2019-01-10  Tom Tromey  <tom@tromey.com>
1316
1317         * symmisc.c (print_symbol_bcache_statistics): Update.
1318         (print_objfile_statistics): Update.
1319         * symfile.c (reread_symbols): Update.
1320         * psymtab.h (class psymtab_storage): New.
1321         * psymtab.c (psymtab_storage): New constructor.
1322         (~psymtab_storage): New destructor.
1323         (require_partial_symbols): Update.
1324         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1325         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1326         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1327         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1328         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1329         (start_psymtab_common, end_psymtab_common)
1330         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1331         (allocate_psymtab): Update.
1332         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1333         Update.
1334         (dump_psymtab_addrmap, maintenance_print_psymbols)
1335         (maintenance_check_psymtabs): Update.
1336         (class objfile_psymtabs): Move to objfiles.h.
1337         * psympriv.h (discard_psymtab): Now inline.
1338         (psymtab_discarder::psymtab_discarder): Update.
1339         (psymtab_discarder::~psymtab_discarder): Update.
1340         (ALL_OBJFILE_PSYMTABS): Rewrite.
1341         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1342         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1343         Remove fields.
1344         <partial_symtabs>: New field.
1345         (class objfile_psymtabs): Move from psymtab.h.  Update.
1346         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1347         psymbol_cache.
1348         (objfile::~objfile): Don't destroy psymbol_cache.
1349         * mdebugread.c (parse_partial_symbols): Update.
1350         * dwarf2read.c (create_addrmap_from_index)
1351         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1352         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1353         (add_partial_subprogram, dwarf2_ranges_read): Update.
1354         * dwarf-index-write.c (write_address_map)
1355         (write_one_signatured_type, recursively_write_psymbols)
1356         (class debug_names, class debug_names, write_psymtabs_to_index):
1357         Update.
1358
1359 2019-01-10  Tom Tromey  <tom@tromey.com>
1360
1361         * symtab.h (SYMBOL_SET_NAMES): Update.
1362         (symbol_set_names): Update.
1363         (MSYMBOL_SET_NAMES): Update.
1364         * symtab.c (symbol_set_names): Change argument to be an
1365         objfile_per_bfd_storage.
1366         * psymtab.c (add_psymbol_to_bcache): Update.
1367         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1368
1369 2019-01-10  Tom Tromey  <tom@tromey.com>
1370
1371         * symtab.c (create_demangled_names_hash): Change argument to be an
1372         objfile_per_bfd_storage.
1373         (symbol_set_names): Update.
1374
1375 2019-01-10  Tom Tromey  <tom@tromey.com>
1376
1377         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1378         init_psymbol_list.
1379         * psymtab.c (init_psymbol_list): Do nothing if already called.
1380         * psympriv.h (init_psymbol_list): Add comment.
1381         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1382         init_psymbol_list.
1383         * dbxread.c (dbx_symfile_read): Unconditionally call
1384         init_psymbol_list.
1385
1386 2019-01-10  Tom Tromey  <tom@tromey.com>
1387
1388         * xcoffread.c (scan_xcoff_symtab): Update.
1389         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1390         "where".
1391         * mdebugread.c (parse_partial_symbols)
1392         (handle_psymbol_enumerators): Update.
1393         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1394         * dbxread.c (read_dbx_symtab): Update.
1395         * psympriv.h (psymbol_placement): New enum.
1396         (add_psymbol_to_list): Update.
1397
1398 2019-01-10  Tom Tromey  <tom@tromey.com>
1399
1400         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1401         static_psymbols parameters.
1402         (scan_xcoff_symtab): Update.
1403         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1404         static_psymbols parameters.
1405         * psympriv.h (start_psymtab_common): Update.
1406         * mdebugread.c (parse_partial_symbols): Update.
1407         * dwarf2read.c (create_partial_symtab): Update.
1408         * dbxread.c (read_dbx_symtab): Update.
1409         (start_psymtab): Remove global_psymbols and static_psymbols
1410         parameters.
1411
1412 2019-01-10  Tom Tromey  <tom@tromey.com>
1413
1414         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1415         * psymtab.c (allocate_psymtab): Add comment.
1416         * psympriv.h (allocate_psymtab): Add comment.
1417         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1418         initializations.
1419         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1420
1421 2019-01-10  Tom Tromey  <tom@tromey.com>
1422
1423         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1424         Don't declare.
1425         * mipsread.c: Include mdebugread.h.
1426         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1427         Declare.
1428         * elfread.c: Include mdebugread.h.
1429
1430 2019-01-09  Tom Tromey  <tom@tromey.com>
1431
1432         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1433         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1434         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1435         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1436         (psym_lookup_symbol, psym_find_last_source_symtab)
1437         (psym_forget_cached_source_info, psym_print_stats)
1438         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1439         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1440         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1441         (psym_find_compunit_symtab_by_address)
1442         (maintenance_print_psymbols, maintenance_info_psymtabs)
1443         (maintenance_check_psymtabs): Use ranged for.
1444         * psymtab.h (class objfile_psymtabs): New.
1445         (require_partial_symbols): Return objfile_psymtabs.
1446         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1447
1448 2019-01-09  Tom Tromey  <tom@tromey.com>
1449
1450         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1451         (find_pc_mapped_section, list_overlays_command)
1452         (map_overlay_command, unmap_overlay_command)
1453         (simple_overlay_update): Use all_objfiles.
1454         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1455         * printcmd.c (info_symbol_command): Use all_objfiles.
1456         * objfiles.h (ALL_OBJSECTIONS): Remove.
1457         * maint.c (maintenance_translate_address): Use all_objfiles.
1458         * gcore.c (gcore_create_callback): Use all_objfiles.
1459         (objfile_find_memory_regions): Likewise.
1460
1461 2019-01-09  Tom Tromey  <tom@tromey.com>
1462
1463         * symtab.c (find_line_symtab, info_sources_command)
1464         (make_source_files_completion_list): Use objfile_compunits.
1465         * source.c (select_source_symtab): Use objfile_compunits.
1466         * objfiles.h (struct objfile): Update comment.
1467         (ALL_OBJFILES): Remove.
1468         (ALL_FILETABS): Remove.
1469         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1470         objfile_compunits.
1471
1472 2019-01-09  Tom Tromey  <tom@tromey.com>
1473
1474         * symmisc.c (print_objfile_statistics, dump_objfile)
1475         (maintenance_print_symbols): Use compunit_filetabs.
1476         * source.c (forget_cached_source_info_for_objfile): Use
1477         compunit_filetabs.
1478         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1479         (ALL_FILETABS): Use compunit_filetabs.
1480         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1481         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1482
1483 2019-01-09  Tom Tromey  <tom@tromey.com>
1484
1485         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1486         (compunit_filetabs): New.
1487         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1488         compunit_filetabs.
1489         (info_sources_command, make_source_files_completion_list): Remove
1490         declaration.
1491         * symmisc.c (print_objfile_statistics, dump_objfile)
1492         (maintenance_print_symbols): Remove declaration.
1493         (maintenance_info_symtabs): Use compunit_filetabs.
1494         (maintenance_info_line_tables): Likewise.
1495         * source.c (select_source_symtab): Change local variable name.
1496         (forget_cached_source_info_for_objfile): Remove declaration.
1497         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1498         * objfiles.c (objfile_relocate1): Remove declaration.
1499         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1500         declaration.
1501         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1502         * coffread.c (coff_symtab_read): Remove declaration.
1503         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1504         compunit_filetabs.
1505
1506 2019-01-09  Tom Tromey  <tom@tromey.com>
1507
1508         * symtab.c (lookup_objfile_from_block)
1509         (find_pc_sect_compunit_symtab, search_symbols)
1510         (default_collect_symbol_completion_matches_break_on): Use
1511         objfile_compunits.
1512         * objfiles.h (ALL_COMPUNITS): Remove.
1513         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1514         * cp-support.c (add_symbol_overload_list_qualified): Use
1515         objfile_compunits.
1516         * ada-lang.c (ada_collect_symbol_completion_matches)
1517         (ada_add_global_exceptions): Use objfile_compunits.
1518
1519 2019-01-09  Tom Tromey  <tom@tromey.com>
1520
1521         * source.c (select_source_symtab)
1522         (forget_cached_source_info_for_objfile): Remove declaration.
1523         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1524         declaration.
1525         * maint.c (count_symtabs_and_blocks): Remove declaration.
1526         * cp-support.c (add_symbol_overload_list_qualified): Remove
1527         declaration.
1528         * coffread.c (coff_symtab_read): Remove declaration.
1529         * symtab.c (lookup_symbol_in_objfile_symtabs)
1530         (basic_lookup_transparent_type_1): Use objfile_compunits.
1531         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1532         (info_sources_command, search_symbols)
1533         (default_collect_symbol_completion_matches_break_on)
1534         (make_source_files_completion_list): Remove declaration.
1535         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1536         (ada_collect_symbol_completion_matches)
1537         (ada_add_global_exceptions): Remove declaration.
1538         * linespec.c (iterate_over_all_matching_symtabs): Use
1539         objfile_compunits.
1540         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1541         (class objfile_compunits): New.
1542         (ALL_COMPUNITS): Use objfile_compunits.
1543         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1544         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1545         objfile_compunits.
1546         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1547
1548 2019-01-09  Tom Tromey  <tom@tromey.com>
1549
1550         * symtab.c (search_symbols)
1551         (default_collect_symbol_completion_matches_break_on): Use
1552         objfile_msymbols.
1553         * ada-lang.c (ada_lookup_simple_minsym)
1554         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1555         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1556         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1557         objfile_msymbols.
1558         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1559         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1560         * objc-lang.c (find_methods): Use objfile_msymbols.
1561         (info_selectors_command, info_classes_command): Likewise.
1562         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1563         * objfiles.h (class objfile_msymbols): New.
1564         (ALL_OBJFILE_MSYMBOLS): Remove.
1565         (ALL_MSYMBOLS): Remove.
1566
1567 2019-01-09  Tom Tromey  <tom@tromey.com>
1568
1569         * common/next-iterator.h (next_adapter): Add Iterator template
1570         parameter.
1571         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1572         (class all_objfiles_safe): New.
1573         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1574         * objfiles.c (put_objfile_before): Update comment.
1575         (add_separate_debug_objfile): Likewise.
1576         (free_all_objfiles): Use all_objfiles_safe.
1577         (objfile_purge_solibs): Likewise.
1578
1579 2019-01-09  Tom Tromey  <tom@tromey.com>
1580
1581         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1582         (expand_symtab_containing_pc, lookup_static_symbol)
1583         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1584         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1585         all_objfiles.
1586         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1587         * breakpoint.c (create_overlay_event_breakpoint)
1588         (create_longjmp_master_breakpoint)
1589         (create_std_terminate_master_breakpoint)
1590         (create_exception_master_breakpoint): Use all_objfiles.
1591         * linux-thread-db.c (try_thread_db_load_from_pdir)
1592         (has_libpthread): Use all_objfiles.
1593         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1594         * linespec.c (iterate_over_all_matching_symtabs)
1595         (search_minsyms_for_name): Use all_objfiles.
1596         * maint.c (maintenance_info_sections): Use all_objfiles.
1597         * main.c (captured_main_1): Use all_objfiles.
1598         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1599         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1600         * guile/scm-pretty-print.c
1601         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1602         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1603         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1604         (maintenance_print_msymbols): Use all_objfiles.
1605         * source.c (select_source_symtab): Use all_objfiles.
1606         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1607         * symfile.c (remove_symbol_file_command)
1608         (expand_symtabs_matching, map_symbol_filenames): Use
1609         all_objfiles.
1610         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1611         all_objfiles.
1612         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1613         * objc-lang.c (find_methods): Use all_objfiles.
1614         * objfiles.c (have_partial_symbols, have_full_symbols)
1615         (have_minimal_symbols, qsort_cmp)
1616         (default_iterate_over_objfiles_in_search_order): Use
1617         all_objfiles.
1618         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1619         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1620         (maintenance_check_psymtabs): Use all_objfiles.
1621         (ALL_PSYMTABS): Remove.
1622         * compile/compile-object-run.c (do_module_cleanup): Use
1623         all_objfiles.
1624         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1625         * cp-support.c (add_symbol_overload_list_qualified): Use
1626         all_objfiles.
1627         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1628         Use all_objfiles.
1629         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1630         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1631         all_objfiles.
1632         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1633         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1634         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1635         Uses all_objfiles.
1636         * solib.c (solib_read_symbols): Use all_objfiles
1637
1638 2019-01-09  Tom Tromey  <tom@tromey.com>
1639
1640         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1641         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1642         all_objfiles.
1643         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1644         * symmisc.c (print_symbol_bcache_statistics)
1645         (print_objfile_statistics, maintenance_print_objfiles)
1646         (maintenance_info_symtabs, maintenance_check_symtabs)
1647         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1648         all_objfiles.
1649         * source.c (forget_cached_source_info): Use all_objfiles.
1650         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1651         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1652         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1653         * objfiles.c (update_section_map): Use all_objfiles.
1654         (shared_objfile_contains_address_p): Likewise.
1655         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1656         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1657
1658 2019-01-09  Tom Tromey  <tom@tromey.com>
1659
1660         * common/next-iterator.h: New file.
1661         * objfiles.h (class all_objfiles): New.
1662         (struct objfile_iterator): New.
1663
1664 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1665
1666         * NEWS: Move the description of the changed "frame", "select-frame",
1667          and "info frame" commands to the Changed commands section.
1668
1669 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1670
1671         * gdbtypes.c (check_stub_method_group): Remove handling of old
1672         mangling schemes.
1673         * linespec.c (find_methods): Likewise.
1674         * stabsread.c (read_member_functions): Likewise.
1675         * valops.c (search_struct_method): Likewise.
1676         (value_struct_elt_for_reference): Likewise.
1677         * NEWS: Mention this change.
1678
1679 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1680
1681         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1682         print_source_lines.
1683         * source.c (print_source_lines_base): Update line number check.
1684         (print_source_lines): New function.
1685         (source_lines_range::source_lines_range): New function.
1686         * source.h (class source_lines_range): New class.
1687         (print_source_lines): New declaration.
1688
1689 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1690
1691         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1692
1693 2019-01-08  Tom Tromey  <tom@tromey.com>
1694             Simon Marchi  <simon.marchi@ericsson.com>
1695
1696         PR gdb/24060
1697         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1698         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1699         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1700         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1701         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1702         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1703
1704 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1705
1706         * source.c (select_source_symtab): Move header comment to
1707         declaration in source.h.
1708         (forget_cached_source_info_for_objfile): Likewise.
1709         (forget_cached_source_info): Likewise.
1710         (identify_source_line): Likewise.
1711         * source.h (identify_source_line): Move declaration from symtab.h
1712         and add comment from source.c
1713         (print_source_lines): Likewise.
1714         (forget_cached_source_info_for_objfile): Likewise.
1715         (forget_cached_source_info): Likewise.
1716         (select_source_symtab): Likewise.
1717         (enum print_source_lines_flag): Move definition from symtab.h.
1718         * symtab.h (identify_source_line): Move declaration to source.h.
1719         (print_source_lines): Likewise.
1720         (forget_cached_source_info_for_objfile): Likewise.
1721         (forget_cached_source_info): Likewise.
1722         (select_source_symtab): Likewise.
1723         (enum print_source_lines_flag): Move definition to source.h.
1724         * tui/tui-hooks.c: Add 'source.h' include.
1725
1726 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * source.c (print_source_lines_base): Handle requests to print
1729         reverse line number sequences, and guard against empty lines
1730         string.
1731
1732 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1733
1734         * source.c (print_source_lines_base): Fix skip of '\r' if next
1735         character is '\n'.
1736
1737 2019-01-06  Tom Tromey  <tom@tromey.com>
1738
1739         * c-exp.y (struct c_parse_state) <macro_original_text,
1740         expansion_obstack>: New member.
1741         (macro_original_text, expansion_obstack): Remove globals.
1742         (scan_macro_expansion, scanning_macro_expansion)
1743         (finished_macro_expansion): Update.
1744         (scan_macro_cleanup): Remove.
1745         (yylex, c_parse): Update.
1746
1747 2019-01-06  Tom Tromey  <tom@tromey.com>
1748
1749         * c-exp.y (struct c_parse_state) <strings>: New member.
1750         (operator_stoken): Update.
1751
1752 2019-01-06  Tom Tromey  <tom@tromey.com>
1753
1754         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1755         (union type_stack_elt) <typelist_val>: Now a pointer to
1756         std::vector.
1757         (type_stack_cleanup): Don't declare.
1758         (push_typelist): Update.
1759         * parse.c (pop_typelist): Return a std::vector.
1760         (push_typelist): Take a std::vector.
1761         (follow_types): Update.  Do not free args.
1762         (type_stack_cleanup): Remove.
1763         * c-exp.y (struct c_parse_state): New.
1764         (cpstate): New global.
1765         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1766         (nonempty_typelist): Update.
1767         (func_mod): Create a new vector.
1768         (c_parse): Create a c_parse_state.
1769         (check_parameter_typelist): Do not delete params.
1770         (function_method): Update.  Do not delete type_list.
1771
1772 2019-01-06  Tom Tromey  <tom@tromey.com>
1773
1774         PR gdb/28155:
1775         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1776         check_typedef.
1777         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1778         (print_return_value): Likewise.
1779
1780 2019-01-05  Tom Tromey  <tom@tromey.com>
1781
1782         * contrib/cleanup_check.py: Remove.
1783         * contrib/gcc-with-excheck: Remove.
1784         * contrib/exsummary.py: Remove.
1785         * contrib/excheck.py: Remove.
1786
1787 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1788
1789         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1790         NULL. Initialize tpprev to NULL instead of assigning it
1791         to NULL on the next statement.
1792         * windows-nat.c (windows_delete_thread): Remove check for
1793         main_thread_id before printing thread exit notifications.
1794         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1795         Remove thread ID check against main_thread_id.
1796         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1797         windows_delete_thread.
1798         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1799
1800 2019-01-04  Tom Tromey  <tom@tromey.com>
1801
1802         * compile/compile.c (_initialize_compile): Use upper case for
1803         metasyntactic variables.
1804         * symmisc.c (_initialize_symmisc): Use upper case for
1805         metasyntactic variables.
1806         * psymtab.c (_initialize_psymtab): Use upper case for
1807         metasyntactic variables.
1808         * demangle.c (demangle_command): Use upper case for metasyntactic
1809         variables.
1810         (_initialize_demangler): Likewise.
1811         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1812         variables.
1813
1814 2019-01-03  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1817
1818 2019-01-03  Tom Tromey  <tom@tromey.com>
1819
1820         * python/py-symtab.c (salpy_str): Update.
1821         (struct salpy_sal_object) <symtab>: Now a PyObject.
1822         (salpy_dealloc): Update.
1823         (del_objfile_sal): Use gdbpy_ref.
1824
1825 2019-01-03  Tom Tromey  <tom@tromey.com>
1826
1827         * python/py-type.c (convert_field): Use new_reference.  Return
1828         gdbpy_ref.
1829         (make_fielditem): Return gdbpy_ref.
1830         (typy_fields): Update.
1831         (typy_getitem): Update.
1832         (field_name): Return gdbpy_ref.  Use new_reference.
1833         (typy_iterator_iternext): Update.
1834
1835 2019-01-03  Tom Tromey  <tom@tromey.com>
1836
1837         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1838
1839 2019-01-03  Tom Tromey  <tom@tromey.com>
1840
1841         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1842         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1843         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1844         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1845         (pspy_set_type_printers): Likewise.
1846         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1847         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1848         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1849         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1850         (objfpy_set_type_printers): Likewise.
1851
1852 2019-01-03  Tom Tromey  <tom@tromey.com>
1853
1854         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1855         (gdbpy_print_stack): Use gdbpy_err_fetch.
1856         * python/python-internal.h (class gdbpy_err_fetch): New class.
1857         (class gdbpy_enter) <m_error_type, m_error_value,
1858         m_error_traceback>: Remove.
1859         <m_error>: New member.
1860         (gdbpy_exception_to_string): Don't declare.
1861         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1862         * python/py-value.c (convert_value_from_python): Use
1863         gdbpy_err_fetch.
1864         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1865         gdbpy_exception_to_string.
1866         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1867         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1868         gdbpy_err_fetch.
1869
1870 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1871
1872         * linux-nat.c (delete_lwp_cleanup): Delete.
1873         (struct lwp_deleter): New struct.
1874         (lwp_info_up): New typedef.
1875         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1876         lwp_info_up.
1877
1878 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * linux-fork.c (class scoped_switch_fork_info): New class.
1881         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1882
1883 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1884
1885         * valops.c (find_overload_match): Remove use of null_cleanup, and
1886         calls to do_cleanups.
1887
1888 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * compile/compile-cplus-types.c
1891         (compile_cplus_instance::decl_name): Handle changes to
1892         cp_func_name.
1893         * cp-support.c (cp_func_name): Update header comment, update
1894         return type.
1895         * cp-support.h (cp_func_name): Update return type in declaration.
1896         * valops.c (find_overload_match): Move temp_func local to top
1897         level of function and change its type.  Use temp_func to hold and
1898         delete temporary string obtained from cp_func_name.
1899
1900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1903         gdb::char_vector, remove cleanup, and update uses of `msg`.
1904
1905 2019-01-03  Jim Wilson  <jimw@sifive.com>
1906
1907         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1908
1909 2019-01-02  Tom Tromey  <tom@tromey.com>
1910
1911         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1912         (tdesc_parse_xml): Remove cleanups.
1913         * target-descriptions.h (make_cleanup_free_target_description):
1914         Don't declare.
1915         (target_desc_deleter): New struct.
1916         (target_desc_up): New typedef.
1917         * target-descriptions.c (target_desc_deleter::operator()): Rename
1918         from free_target_description.
1919         (make_cleanup_free_target_description): Remove.
1920
1921 2019-01-02  Tom Tromey  <tom@tromey.com>
1922
1923         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1924         constructor, destructor.
1925         (linespec_parser): Remove typedef.
1926         (~linespec_parser): Rename from linespec_parser_delete.
1927         (linespec_lex_to_end, linespec_complete_label)
1928         (linespec_complete): Update.
1929         (decode_line_full): Remove cleanups.
1930         (decode_line_1): Update.
1931
1932 2019-01-02  Tom Tromey  <tom@tromey.com>
1933
1934         * python/python-internal.h (inferior_to_inferior_object): Change
1935         return type.
1936         * python/py-exitedevent.c (create_exited_event_object): Update.
1937         * python/py-inferior.c (inferior_to_inferior_object): Return
1938         gdbpy_ref.
1939         (python_new_inferior, python_inferior_deleted)
1940         (thread_to_thread_object, delete_thread_object)
1941         (build_inferior_list, gdbpy_selected_inferior): Update.
1942         * python/py-infthread.c (create_thread_object): Update.  Also fail
1943         if inferior_to_inferior_object fails.
1944
1945 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1946
1947         * inferior.h (class inferior) <displaced_step_state>: New field.
1948         * infrun.h (struct displaced_step_state): Move here from
1949         infrun.c.  Initialize fields, add constructor.
1950         <inf>: Remove field.
1951         <reset>: New method.
1952         * infrun.c (struct displaced_step_inferior_state): Move to
1953         infrun.h.
1954         (displaced_step_inferior_states): Remove.
1955         (get_displaced_stepping_state): Adust.
1956         (displaced_step_in_progress_any_inferior): Adjust.
1957         (displaced_step_in_progress_thread): Adjust.
1958         (displaced_step_in_progress): Adjust.
1959         (add_displaced_stepping_state): Remove.
1960         (get_displaced_step_closure_by_addr): Adjust.
1961         (remove_displaced_stepping_state): Remove.
1962         (infrun_inferior_exit): Call displaced_step_state.reset.
1963         (use_displaced_stepping): Don't check for NULL.
1964         (displaced_step_prepare_throw): Call
1965         get_displaced_stepping_state.
1966         (displaced_step_fixup): Don't check for NULL.
1967         (prepare_for_detach): Don't check for NULL.
1968
1969 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1970
1971         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1972          in case of call that did not complete.
1973
1974 2019-01-02  Andrey Utkin  <autkin@undo.io>
1975
1976         * symfile.c (find_separate_debug_file): Fix search of debug files for
1977         remote debuggee.
1978
1979 2019-01-02  Tom Tromey  <tom@tromey.com>
1980
1981         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1982         indentation.
1983         * python/py-frame.c (frapy_older): Remove cast.
1984         (frapy_newer): Likewise.
1985         * python/py-breakpoint.c (local_setattro): Remove cast.
1986         * python/py-arch.c (archpy_name): Remove local variable.
1987         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1988
1989 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1990
1991         * unittests/basic_string_view/element_access/char/empty.cc:
1992         Fix year range in copyright header.
1993
1994 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1995
1996         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1997         Delete.
1998         <operator==>: Update with for removed field.
1999         <hash>: Likewise.
2000         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2001         <isa_features>: ...this.
2002         <abi_features>: New field.
2003         (riscv_isa_flen): Update comment.
2004         (riscv_abi_xlen): New declaration.
2005         (riscv_abi_flen): New declaration.
2006         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2007         isa_features.
2008         (riscv_abi_xlen): New function.
2009         (riscv_isa_flen): Update to get answer from isa_features.
2010         (riscv_abi_flen): New function.
2011         (riscv_has_fp_abi): Update to get answer from abi_features.
2012         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2013         xlen and flen.
2014         (riscv_call_info) <xlen, flen>: Update comment.
2015         (riscv_call_arg_struct): Remove invalid assertions
2016         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2017         is removed.
2018         (riscv_gdbarch_init): Gather isa features and abi features
2019         separately, ensure both match on the gdbarch when reusing an old
2020         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2021         a target with 64-bit float hardware.
2022
2023 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2024
2025         * source.c (search_command_helper): Stop reverse search
2026         when line 1 has been searched.
2027
2028 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2029
2030         * record-full.c (record_full_base_target::close): Rewrite
2031         record_full_core_buf_list free logic.
2032
2033 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2034
2035         * break-catch-syscall.c (print_one_catch_syscall): xfree
2036         the last text.
2037
2038 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2039
2040         * top.c (print_gdb_version): Update Copyright year in version
2041         message.
2042
2043 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2044
2045         Update copyright year range in all GDB files.
2046
2047 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2048
2049         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2050
2051 For older changes see ChangeLog-2018.
2052 \f
2053 Local Variables:
2054 mode: change-log
2055 left-margin: 8
2056 fill-column: 74
2057 version-control: never
2058 coding: utf-8
2059 End:
2060