gdb/ChangeLog

   1 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
   4
   5 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * arch/aarch32.c (aarch32_create_target_description): Create
   8         target descriptions using features.
   9         * arch/arm.c (arm_create_target_description)
  10         (arm_create_mprofile_target_description): Likewise.
  11         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  12
  13 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  14
  15         * Makefile.in: Add new files.
  16         * aarch32-tdep.c: New file.
  17         * aarch32-tdep.h: New file.
  18         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  19         Call aarch32_read_description.
  20         * arch/aarch32.c: New file.
  21         * arch/aarch32.h: New file.
  22         * arch/arm.c (arm_create_target_description)
  23         (arm_create_mprofile_target_description): New function.
  24         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  25         (arm_create_target_description)
  26         (arm_create_mprofile_target_description): New declaration.
  27         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  28         read_description functions.
  29         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  30         Likewise.
  31         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  32         * arm-tdep.c (tdesc_arm_list): New variable.
  33         (arm_register_g_packet_guesses): Call create description functions.
  34         (arm_read_description) (arm_read_mprofile_description): New
  35         function.
  36         * arm-tdep.h (arm_read_description)
  37         (arm_read_mprofile_description): Add declaration.
  38         * configure.tgt: Add new files.
  39
  40 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  41
  42         * top.c (new_ui_command): Open specified terminal just once.
  43
  44 2019-07-18  Tom Tromey  <tromey@adacore.com>
  45
  46         * symtab.c (main_name): Constify return type.
  47         * symfile.c (set_initial_language): Update.
  48         * symtab.h (main_name): Constify return type.
  49
  50 2019-07-17  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-winsource.c (tui_update_source_window)
  53         (tui_update_source_window_as_is)
  54         (tui_update_source_windows_with_line): Remove return.
  55         * tui/tui-disasm.c (tui_show_disassem)
  56         (tui_show_disassem_and_update_source): Remove return.
  57         * tui/tui.c (tui_reset): Remove return.
  58         * tui/tui-wingeneral.c
  59         (tui_check_and_display_highlight_if_needed): Remove return.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-winsource.h (struct tui_exec_info_window)
  68         (struct tui_source_window_base): Move from tui-data.h.
  69         * tui/tui-winsource.c: Move many method definitions from
  70         elsewhere.  Remove "structuring" comments.
  71         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  72         (tui_source_window_base::refresh_window): Move to
  73         tui-winsource.c.
  74         * tui/tui-win.c (tui_source_window_base::refresh_all)
  75         (tui_source_window_base::update_tab_width)
  76         (tui_source_window_base::set_new_height)
  77         (tui_source_window_base::do_make_visible_with_new_height): Move to
  78         tui-winsource.c.
  79         * tui/tui-source.h: Update.
  80         * tui/tui-source.c (tui_source_window_base::reset): Move to
  81         tui-winsource.c.
  82         * tui/tui-disasm.h: Update.
  83         * tui/tui-data.h (struct tui_exec_info_window): Move to
  84         tui-winsource.h.
  85         (struct tui_source_window_base): Likewise.
  86         * tui/tui-data.c (tui_source_window_base::clear_detail)
  87         (tui_source_window_base, ~tui_source_window_base): Move to
  88         tui-winsource.c.
  89
  90 2019-07-17  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-win.c (tui_resize_all)
  93         (tui_source_window_base::update_tab_width)
  94         (tui_adjust_win_heights): Update.
  95         (tui_win_info::make_invisible_and_set_new_height): Rename from
  96         make_invisible_and_set_new_height.
  97         * tui/tui-data.h (struct tui_win_info)
  98         <make_invisible_and_set_new_height>: New method.
  99
 100 2019-07-17  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui.c: Update.
 103         * tui/tui-source.h (struct tui_source_window): Move from
 104         tui-data.h.
 105         * tui/tui-layout.c: Update.
 106         * tui/tui-disasm.c: Update.
 107         * tui/tui-data.h (struct tui_source_window): Move to
 108         tui-source.h.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 113         tui-data.h.
 114         * tui/tui-data.h (struct tui_disasm_window): Move to
 115         tui-disasm.h.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-regs.h (struct tui_data_item_window): Move from
 120         tui-data.h.
 121         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 122         * tui/tui-data.h (struct tui_data_item_window): Move to
 123         tui-regs.h.
 124         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 125
 126 2019-07-17  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui.c: Update.
 129         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 130         (tui_cmd_window::max_height): Move to tui-command.c.
 131         * tui/tui-layout.c: Update.
 132         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 133         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 134         tui-command.c.
 135         * tui/tui-command.h (struct tui_cmd_window): Move from
 136         tui-data.h.
 137         * tui/tui-command.c: Remove "structuring" comments.
 138         (tui_cmd_window::clear_detail)
 139         (tui_cmd_window::do_make_visible_with_new_height)
 140         (tui_cmd_window::max_height): Move from elsewhere.
 141
 142 2019-07-17  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 145         Now static.
 146         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 147         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui.c: Update.
 152         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 153         tui-regs.c.
 154         * tui/tui-windata.h: Remove file.
 155         * tui/tui-windata.c: Remove file.
 156         * tui/tui-win.c (tui_data_window::set_new_height)
 157         (tui_data_window::do_make_visible_with_new_height): Move to
 158         tui-regs.c.
 159         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 160         * tui/tui-regs.c: Remove "structuring" comments.
 161         (tui_data_window::first_data_item_displayed)
 162         (tui_data_window::delete_data_content_windows)
 163         (tui_data_window::erase_data_content)
 164         (tui_data_window::display_all_data)
 165         (tui_data_window::refresh_all)
 166         (tui_data_window::do_scroll_vertical)
 167         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 168         (tui_data_window::do_make_visible_with_new_height)
 169         (tui_data_window::refresh_window): Move from elsewhere.
 170         (_initialize_tui_regs): Move to end of file.
 171         * tui/tui-layout.c: Update.
 172         * tui/tui-hooks.c: Update.
 173         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 174         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 175         tui-regs.c.
 176         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 177
 178 2019-07-17  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 181         seen.
 182
 183 2019-07-17  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-win.c (tui_source_window_base::set_new_height)
 186         (tui_source_window_base::do_make_visible_with_new_height): Use
 187         m_has_locator field directly.
 188         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 189         method.
 190         (struct tui_source_window_base) <has_locator>: Likewise.
 191
 192 2019-07-17  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 195         Don't declare.
 196         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 197         Remove.
 198         * tui/tui-win.c (tui_source_window_base::set_new_height)
 199         (tui_source_window_base::set_new_height)
 200         (make_invisible_and_set_new_height)
 201         (tui_source_window_base::do_make_visible_with_new_height)
 202         (tui_source_window_base::do_make_visible_with_new_height):
 203         Update.
 204         * tui/tui-layout.c (show_source_disasm_command, show_data)
 205         (show_source_or_disasm_and_command): Update.
 206         * tui/tui-layout.c (show_layout): Update.
 207
 208 2019-07-17  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-layout.c (make_data_window): Remove.
 211         (show_data): Unify creation and re-initialization cases.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-layout.c (make_source_window, make_disasm_window):
 216         Remove.
 217         (show_data): Unify creation and re-initialization cases.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-layout.c (make_command_window): Remove.
 222         (show_source_disasm_command, show_source_or_disasm_and_command):
 223         Unify creation and re-initialization cases.
 224
 225 2019-07-17  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 228         creation and re-initialization cases.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-regs.c (tui_get_register): Return void.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 237         Simplify.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 242         resetting.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 247         * tui/tui-regs.c (tui_reg_layout): New function.
 248         (tui_show_registers, tui_reg_command): Use it.
 249         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 250         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 251         parameters.
 252         (tui_layout_command): Remove.
 253
 254 2019-07-17  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-layout.h (tui/tui-layout): Return void.
 257         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 258
 259 2019-07-17  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-layout.c (show_source_disasm_command, show_data):
 262         Update.
 263         (reset_locator): Remove.
 264         (show_source_or_disasm_and_command): Update.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-source.c (tui_source_window_base::reset): Remove
 269         win_type parameter.
 270         * tui/tui-layout.c (make_command_window, make_source_window)
 271         (make_disasm_window, make_data_window)
 272         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 273         (reset_locator, show_source_or_disasm_and_command): Update.
 274         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 275         win_type parameter.
 276         (struct tui_source_window_base) <reset>: Likewise.
 277
 278 2019-07-17  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-layout.c (show_source_disasm_command): Use
 281         reset_locator.
 282         (reset_locator): New function.
 283         (init_and_make_win): Remove.
 284         (show_source_or_disasm_and_command): Use reset_locator.
 285
 286 2019-07-17  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 289         condition.
 290         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 291         Remove condition.
 292         * tui/tui-source.c (tui_source_window_base::reset): New method.
 293         * tui/tui-layout.c (make_command_window): Don't call
 294         init_and_make_win.
 295         (make_source_window, make_disasm_window): Don't call
 296         make_source_or_disasm_window.
 297         (make_data_window): Don't call init_and_make_win.  Change calling
 298         convention.
 299         (show_source_disasm_command, show_data): Simplify.
 300         (make_source_or_disasm_window): Remove.
 301         (show_source_or_disasm_and_command): Simplify.
 302         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 303         (struct tui_source_window_base) <reset>: Likewise.
 304         <execution_info>: Remove initializer.
 305         * tui/tui-data.c (tui_source_window_base): Initialize
 306         execution_info.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 311         variable.
 312
 313 2019-07-17  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui.c (tui_rl_other_window): Update.
 316         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 317         superclass method first.  Always iterate over regs_content.
 318         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 319         method.
 320         * tui/tui-win.c (tui_set_focus_command): Update.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-win.c (tui_set_focus_command): Rename from
 325         tui_set_focus.  Call tui_enable.
 326         (tui_set_focus_command): Remove.
 327
 328 2019-07-17  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 331         refresh_window.
 332         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 333         touchwin.
 334         (tui_data_window::refresh_window): Call refresh_window on data
 335         items.  Always call superclass refresh_window.
 336         (tui_win_info::refresh): Remove.
 337         (tui_source_window_base::refresh_window): Update.
 338         (tui_refresh_all): Update.
 339         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 340         refresh_window.
 341         (show_source_or_disasm_and_command): Likewise.
 342         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 343         (struct tui_source_window_base) <refresh>: Likewise.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.c (tui_clear_source_content)
 348         (tui_show_source_content): Update.
 349         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 350         whether content is empty.
 351         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 352         Remove.
 353
 354 2019-07-17  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 357         window's contents.
 358         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 359         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 364         (struct tui_data_item_window): Update.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 369         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 370         defines.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-winsource.h (tui_erase_source_content)
 375         (tui_clear_source_content): Remove "display_prompt" parameter.
 376         * tui/tui-winsource.c (tui_update_source_window_as_is)
 377         (tui_update_source_windows_with_addr): Update.
 378         (tui_clear_source_content): Remove "display_prompt" parameter.
 379         (tui_erase_source_content): Likewise.  Simplify.
 380         (tui_show_source_content): Update.
 381         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 382         * tui/tui-stack.c (tui_show_frame_info): Update.
 383         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 384         Remove defines.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 389         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 390         parameter.
 391         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 392         parameter.
 393
 394 2019-07-17  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-winsource.c (tui_clear_source_content)
 397         (tui_show_source_content, tui_show_exec_info_content)
 398         (tui_clear_exec_info_content): Update.
 399         * tui/tui-stack.c (tui_show_locator_content): Update.
 400         (tui_show_frame_info): Update.
 401         * tui/tui-source.h (tui_source_window): Don't declare.
 402         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 403         from tui_source_is_displayed.
 404         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 405         Remove field.
 406         (struct tui_source_window_base) <content_in_use>: New field.  Now
 407         bool.
 408         (struct tui_source_window) <showing_source_p>: New method.
 409         (TUI_SRC_WIN): Change cast.
 410         * tui/tui-data.c (tui_initialize_static_data): Update.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 415         location_matches_p.
 416         * tui/tui-source.c (tui_source_window::location_matches_p): New
 417         method.
 418         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 419         method.
 420         * tui/tui-data.h (struct tui_source_window_base)
 421         <location_matches_p>: New method.
 422         (struct tui_source_window, struct tui_disasm_window)
 423         <location_matches_p>: Likewise.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-win.c (tui_set_win_height_command): Rename from
 428         tui_set_win_height.
 429         (tui_set_win_height_command): Remove.
 430
 431 2019-07-17  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-source.c (tui_source_window): New constructor.  Add
 434         observer.
 435         (~tui_source_window): New destructor.
 436         (tui_source_window::style_changed): New method.
 437         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 438         (tui_attach_detach_observers): Update.
 439         * tui/tui-data.h (struct tui_source_window): Make constructor not
 440         inline.  Add destructor.
 441         (struct tui_source_window) <style_changed>: New method.
 442         <m_observable>: New member.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 447         * tui/tui-win.c (tui_resize_all): Fix typo.
 448
 449 2019-07-17  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 452         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 453         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 454         * tui/tui-win.c (window_name_completer): Use foreach.
 455         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 456         (update_tab_width): Likewise.
 457         * tui/tui-layout.c (show_layout): Update.
 458         * tui/tui-data.h (class tui_window_iterator): New.
 459         (struct all_tui_windows): New.
 460         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 461
 462 2019-07-17  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 465         parameter.  Don't reference globals.
 466         (tui_reg_command): Update.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-regs.c (tui_show_registers): Simplify.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-regs.c (tui_show_registers): Update.
 475         (tui_show_register_group): Add win_info parameter.
 476
 477 2019-07-17  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 480         Rename from tui_display_reg_element_at_line.
 481         (tui_data_window::display_registers_from_line): Update.
 482         * tui/tui-data.h (struct tui_data_window)
 483         <display_reg_element_at_line>: New method.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-regs.h (tui_display_registers_from)
 488         (tui_display_registers_from_line): Don't declare.
 489         * tui/tui-windata.c (tui_data_window::display_all_data)
 490         (tui_data_window::refresh_all)
 491         (tui_data_window::do_scroll_vertical): Update.
 492         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 493         from tui_display_registers_from.
 494         (tui_display_reg_element_at_line): Update.
 495         (tui_data_window::display_registers_from_line): Rename from
 496         tui_display_registers_from_line.
 497         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 498         display_registers_from_line>: New methods.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 503         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 504         from tui_erase_data_content.
 505         (tui_data_window::display_all_data)
 506         (tui_data_window::refresh_all)
 507         (tui_data_window::do_scroll_vertical): Update.
 508         * tui/tui-regs.c (tui_show_registers): Update.
 509         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 510         New method.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 515         declare.
 516         * tui/tui-windata.c
 517         (tui_data_window::delete_data_content_windows): Rename from
 518         tui_delete_data_content_windows.
 519         (tui_data_window::display_all_data)
 520         (tui_data_window::do_scroll_vertical): Update.
 521         * tui/tui-data.h (struct tui_data_window)
 522         <delete_data_content_windows>: New method.
 523
 524 2019-07-17  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 527         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 528
 529 2019-07-17  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 532         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 533         from tui_display_all_data.
 534         * tui/tui-win.c
 535         (tui_data_window::do_make_visible_with_new_height): Update.
 536         * tui/tui-regs.c (tui_show_registers): Update.
 537         * tui/tui-layout.c (tui_set_layout): Update.
 538         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 539         method.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 544         * tui/tui-windata.c (tui_display_data_from): Remove.
 545         (tui_data_window::refresh_all): Update.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 550         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 551         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 552         tui_display_registers_from_line.
 553         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 554         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 555         "force_display" parameter.
 556
 557 2019-07-17  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 560         declare.
 561         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 562         Rename from tui_first_reg_element_no_inline.
 563         (tui_display_reg_element_at_line)
 564         (tui_display_registers_from_line): Update.
 565         * tui/tui-data.h (struct tui_data_window)
 566         <first_reg_element_no_inline>: New method.
 567
 568 2019-07-17  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-windata.c (tui_display_data_from)
 571         (tui_data_window::do_scroll_vertical): Update.
 572         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 573         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 574         Rename from tui_line_from_reg_element_no.
 575         (tui_display_registers_from_line): Update.
 576         * tui/tui-data.h (struct tui_data_window)
 577         <line_from_reg_element_no>: New method.
 578
 579 2019-07-17  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 582         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 583         tui_last_regs_line_no.
 584         (tui_display_reg_element_at_line)
 585         (tui_display_registers_from_line): Update.
 586         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 587         method.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         PR tui/24722:
 592         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 593         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 594         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 595         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 596         (tui_update_breakpoint_info): Likewise.
 597         * tui/tui-hooks.c (tui_event_create_breakpoint)
 598         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 599         Update.
 600
 601 2019-07-17  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-winsource.c (tui_update_source_window_as_is)
 608         (tui_update_source_windows_with_addr): Update.
 609         * tui/tui-source.h (tui_set_source_content)
 610         (tui_show_symtab_source): Add "win_info" parameter.
 611         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 612         parameter.
 613         (tui_show_symtab_source): Likewise.
 614
 615 2019-07-17  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-wingeneral.c
 618         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 619
 620 2019-07-17  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 623         (struct tui_cmd_window) <can_scroll>: New method.
 624         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 625         method.
 626
 627 2019-07-17  Tom Tromey  <tromey@adacore.com>
 628
 629         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 630         do_field_signed>: Rename.  Change type of "value".
 631         * ui-out.c (ui_out::field_signed): Rename from field_int.
 632         Change type of "value".
 633         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 634         type of "value".
 635         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 636         do_field_int.  Change type of "value".
 637         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 638         do_field_int.  Change type of "value".
 639         * tracepoint.c (trace_status_mi, tfind_1)
 640         (print_one_static_tracepoint_marker): Update.
 641         * thread.c (print_thread_info_1, print_selected_thread_frame):
 642         Update.
 643         * stack.c (print_frame, print_frame_info): Update.
 644         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 645         Update.
 646         * source.c (print_source_lines_base): Update.
 647         * skip.c (info_skip_command): Update.
 648         * record-btrace.c (btrace_ui_out_decode_error)
 649         (btrace_call_history_src_line): Update.
 650         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 651         Update.
 652         * progspace.c (print_program_space): Update.
 653         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 654         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 655         do_field_int.  Change type of "value".
 656         * mi/mi-out.c (mi_ui_out::do_table_begin)
 657         (mi_ui_out::do_table_header): Update.
 658         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 659         type of "value".
 660         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 661         (mi_cmd_data_list_changed_registers, output_register)
 662         (mi_cmd_data_read_memory, mi_load_progress)
 663         (mi_cmd_trace_frame_collected): Update.
 664         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 665         Update.
 666         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 667         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 668         (mi_cmd_var_list_children, varobj_update_one): Update.
 669         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 670         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 671         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 672         * inferior.c (print_inferior): Update.
 673         * gdb_bfd.c (print_one_bfd): Update.
 674         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 675         Update.
 676         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 677         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 678         do_field_int.  Change type of "value".
 679         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 680         do_field_int.  Change type of "value".
 681         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 682         (print_one_breakpoint_location, print_it_catch_fork)
 683         (print_one_catch_fork, print_it_catch_vfork)
 684         (print_one_catch_vfork, print_it_catch_solib)
 685         (print_it_catch_exec, print_it_ranged_breakpoint)
 686         (print_mention_watchpoint, print_mention_masked_watchpoint)
 687         (bkpt_print_it, update_static_tracepoint): Update.
 688         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 689         * break-catch-syscall.c (print_it_catch_syscall): Update.
 690         * ada-tasks.c (print_ada_task_info): Update.
 691         * ada-lang.c (print_it_exception, print_mention_exception):
 692         Update.
 693
 694 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         PR breakpoints/24541
 697         * gdbarch.c: Regenerate.
 698         * gdbarch.h: Regenerate.
 699         * gdbarch.sh: Adjust return type and parameter types for
 700         'stap_adjust_register'.
 701         (i386_stap_adjust_register): Adjust signature and return new
 702         register name.
 703         * stap-probe.c (stap_parse_register_operand): Adjust use of
 704         'gdbarch_stap_adjust_register'.
 705
 706 2019-07-17  Tom Tromey  <tromey@adacore.com>
 707
 708         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 709         declare VEC.
 710         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 711         std::vector.
 712         (struct s390_process_info): Add initializers.
 713         (s390_add_process): Use new.
 714         (s390_linux_nat_target::low_forget_process): Use delete.
 715         (s390_linux_nat_target::low_new_fork)
 716         (s390_linux_nat_target::stopped_by_watchpoint)
 717         (s390_linux_nat_target::low_prepare_to_resume)
 718         (s390_linux_nat_target::insert_watchpoint)
 719         (s390_linux_nat_target::insert_hw_breakpoint)
 720         (s390_linux_nat_target::remove_watchpoint)
 721         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 722
 723 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 724
 725         * aarch64-fbsd-nat.c: Include regcache.h.
 726         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 727         argument.
 728         (aarch64_fbsd_nat_target::fetch_registers)
 729         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 730         variable.
 731         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 732
 733 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 734
 735         * fbsd-nat.c: Include gdbarch.h.
 736
 737 2019-07-15  Tom Tromey  <tromey@adacore.com>
 738
 739         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 740
 741 2019-07-15  Tom Tromey  <tromey@adacore.com>
 742
 743         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 744         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 745         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 746         * cli-out.c (cli_ui_out::do_field_int): New method.
 747         * ui-out.c (ui_out::field_unsigned): New method.
 748         * symfile.c (generic_load): Use field_unsigned.
 749         (print_transfer_performance): Likewise.
 750         * record-btrace.c (ui_out_field_uint): Remove.
 751         (btrace_call_history_insn_range, btrace_call_history): Use
 752         field_unsigned.
 753         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 754         field_unsigned.
 755         * ui-out.h (class ui_out) <field_unsigned>: New method.
 756         <do_field_unsigned>: Likewise.
 757
 758 2019-07-15  Tom Tromey  <tromey@adacore.com>
 759
 760         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 761         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 762         * target.c (flash_erase_command): Use field_string.
 763         * infrun.c (print_signal_received_reason): Use field_string.
 764         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 765         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 766         field_string.
 767         * ada-tasks.c (print_ada_task_info): Use field_string.
 768
 769 2019-07-15  Tom Tromey  <tromey@adacore.com>
 770
 771         * target.c (flash_erase_command): Use field_core_addr.
 772         * symfile.c (generic_load): Use field_core_addr.
 773         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 774         Use field_core_addr.
 775         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 776         field_core_addr.
 777
 778 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 781         value if its desired type is smaller than a CORE_ADDR and signed.
 782
 783 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 784
 785         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 786         of changes to field names, and use new is_reference field to
 787         decide if a property is a reference or not.
 788         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 789         field.
 790         (struct dwarf2_property_baton): Update header comment, rename
 791         'referenced_type' to 'property_type' and update comments.
 792         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 793         default property type, store in property baton, update to take
 794         accound of renamed field.
 795         (read_func_scope): Update call to attr_to_dynamic_prop.
 796         (read_array_type): Likewise.
 797         (dwarf2_per_cu_addr_sized_int_type): New function.
 798         (read_subrange_index_type): Move type finding code to
 799         dwarf2_per_cu_addr_sized_int_type.
 800         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 801         (dwarf2_per_cu_addr_type): New function.
 802         (set_die_type): Update calls to attr_to_dynamic_prop.
 803
 804 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * dwarf2read.c (read_subrange_index_type): New function.
 807         (read_subrange_type): Move code into new function and call it.
 808         * gdbtypes.c (create_range_type): Add some asserts.
 809
 810 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 813         update return statements.
 814         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 815         declaration, and update comment to match.
 816         * gdbtypes.c (resolve_dynamic_array): Update call to
 817         dwarf2_evaluate_property to match new return type.
 818
 819 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * valarith.c (value_subscripted_rvalue): Change lowerbound
 822         parameter type from int to LONGEST.
 823         * value.h (value_subscripted_rvalue): Likewise in declaration.
 824
 825 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * cli/cli-utils.c (info_print_command_completer): New function.
 828         * cli/cli-utils.h: Add 'completer.h' include, and forward
 829         declaration for 'struct cmd_list_element'.
 830         (info_print_command_completer): Declare.
 831         * stack.c (_initialize_stack): Add completer for 'info locals' and
 832         'info args'.
 833         * symtab.c (_initialize_symtab): Add completer for 'info
 834         variables' and 'info functions'.
 835         * NEWS: Mention completion for additional info commands.
 836
 837 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * cli/cli-utils.c (extract_info_print_args): Delete.
 840         (extract_arg_maybe_quoted): Delete.
 841         (info_print_options_defs): New variable.
 842         (make_info_print_options_def_group): New function.
 843         (extract_info_print_options): Define new function.
 844         * cli/cli-utils.h (extract_info_print_args): Delete.
 845         (struct info_print_options): New structure.
 846         (extract_info_print_options): Declare new function.
 847         * stack.c (info_locals_command): Update to use new
 848         extract_info_print_options, also add a header comment.
 849         (info_args_command): Likewise.
 850         * symtab.c (info_variables_command): Likewise.
 851         (info_functions_command): Likewise.
 852
 853 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 856         to extract string arguments.
 857         * common/common-utils.c (extract_string_maybe_quoted): New function.
 858         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 859
 860 2019-07-11  Tom Tromey  <tromey@adacore.com>
 861
 862         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 863         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 864         * top.h (gdbinit): Don't declare.
 865         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 866         into...
 867         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 868         * top.c (gdb_init): Don't call init_cli_cmds.
 869         (gdbinit): Remove.
 870         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 871
 872 2019-07-11  Tom Tromey  <tromey@adacore.com>
 873
 874         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 875         after it has been moved.
 876
 877 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 878
 879         * valops.c (value_must_coerce_to_target): Change return type to
 880         bool.
 881         * value.h (value_must_coerce_to_target): Likewise.
 882
 883 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 884
 885         * breakpoint.c (is_hardware_watchpoint): Remove
 886         forward-declaration.
 887         (is_masked_watchpoint): Change return type to bool.
 888         (is_tracepoint): Likewise.
 889         (is_breakpoint): Likewise.
 890         (is_hardware_watchpoint): Likewise.
 891         (is_watchpoint): Likewise.
 892         (is_no_memory_software_watchpoint): Likewise.
 893         (is_catchpoint): Likewise.
 894         (breakpoint_1): Make FILTER parameter's return type bool.
 895         is_masked_watchpoint): Change return type to bool.
 896         (save_breakpoints): Make FILTER parameter's return type bool.
 897         * breakpoint.h (is_breakpoint): Change return type to bool.
 898         (is_watchpoint): Likewise.
 899         (is_catchpoint): Likewise.
 900         (is_tracepoint): Likewise.
 901
 902 2019-07-10  Tom Tromey  <tom@tromey.com>
 903
 904         * defs.h: Don't include gdbarch.h.
 905         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 906         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 907         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 908         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 909         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 910         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 911         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 912         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 913         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 914         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 915         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 916         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 917         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 918         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 919         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 920         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 921         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 922         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 923         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 924         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 925         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 926         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 927         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 928         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 929         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 930         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 931         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 932
 933 2019-07-10  Tom Tromey  <tromey@adacore.com>
 934
 935         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 936         * breakpoint.c (init_ada_exception_breakpoint): Register as
 937         bp_catchpoint.
 938         (print_one_breakpoint_location, print_one_breakpoint): Use
 939         is_ada_exception_catchpoint.
 940         * ada-lang.c (class ada_catchpoint_location): Pass
 941         bp_loc_software_breakpoint to bp_location constructor.
 942         (is_ada_exception_catchpoint): New function.
 943
 944 2019-07-10  Tom Tromey  <tromey@adacore.com>
 945
 946         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 947         VEC.
 948         (struct arm_exidx_entry): New method operator<.
 949         (struct arm_exidx_data) <section_maps>: Change type.
 950         (arm_exidx_data_free): Remove.
 951         (arm_exidx_data_key): Change type.  Move lower.
 952         (arm_exidx_new_objfile): Update.
 953         (arm_compare_exidx_entries): Remove.
 954         (arm_find_exidx_entry, _initialize_arm_tdep)
 955
 956 2019-07-10  Tom Tromey  <tromey@adacore.com>
 957
 958         * solib-spu.c (ocl_program_data_key): Change type.
 959         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 960         Update.
 961
 962 2019-07-10  Tom Tromey  <tromey@adacore.com>
 963
 964         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 965         (struct solib_aix_inferior_data) <library_list>: Change type.
 966         (solib_aix_inferior_data_handle): Change type.
 967         (get_solib_aix_inferior_data): Update.
 968         (solib_aix_free_library_list): Remove.
 969         (library_list_start_library): Update.
 970         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 971         return type.
 972         (solib_aix_get_library_list)
 973         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 974         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 975
 976 2019-07-10  Tom Tromey  <tromey@adacore.com>
 977
 978         * solib-dsbt.c (struct dsbt_info): Add initializers.
 979         (solib_dsbt_pspace_data): Change type.
 980         (dsbt_pspace_data_cleanup): Remove.
 981         (get_dsbt_info, _initialize_dsbt_solib): Update.
 982
 983 2019-07-10  Tom Tromey  <tromey@adacore.com>
 984
 985         * spu-tdep.c (spu_overlay_data): Change type.
 986         (spu_get_overlay_table, spu_overlay_new_objfile)
 987         (_initialize_spu_tdep): Update.
 988
 989 2019-07-10  Tom Tromey  <tromey@adacore.com>
 990
 991         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 992         destructor.
 993         (dbx_objfile_data_key): Change type and declare later.
 994         (DBX_SYMFILE_INFO): Rewrite.
 995         * dbxread.c (dbx_objfile_data_key): Change type.
 996         (dbx_symfile_init): Update.
 997         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 998         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 999         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1000
1001 2019-07-10  Tom Tromey  <tromey@adacore.com>
1002
1003         * jit.c (jit_program_space_key): Change type.  Move lower.
1004         (get_jit_program_space_data): Update.
1005         (jit_program_space_data_cleanup): Remove.
1006         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1007         Update.
1008         (struct jit_program_space_data): Add initializers.
1009
1010 2019-07-10  Tom Tromey  <tromey@adacore.com>
1011
1012         * solib-darwin.c (struct darwin_info): Add initializers.
1013         (solib_darwin_pspace_data): Change type.
1014         (darwin_pspace_data_cleanup): Remove.
1015         (get_darwin_info, _initialize_darwin_solib): Update.
1016
1017 2019-07-10  Tom Tromey  <tromey@adacore.com>
1018
1019         * remote-sim.c (struct sim_inferior_data): Add initializers,
1020         constructor, and destructor.
1021         (sim_inferior_data_key): Change type.  Move lower.
1022         (check_for_duplicate_sim_descriptor): Update.
1023         (get_sim_inferior_data): Use new.  Update.
1024         (~sim_inferior_data_cleanup): Rename from
1025         sim_inferior_data_cleanup.  Simplify.
1026         (gdbsim_close_inferior, simulator_command)
1027         (sim_command_completer, _initialize_remote_sim): Update.
1028         (next_pid, INITIAL_PID): Move earlier.
1029
1030 2019-07-10  Tom Tromey  <tromey@adacore.com>
1031
1032         * python/python-internal.h (create_thread_object): Return
1033         gdbpy_ref.
1034         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1035         * python/py-inferior.c (struct threadlist_entry): Add
1036         constructor.
1037         <thread_obj>: Now a gdbpy_ref.
1038         (thread_to_thread_object): Update.
1039         (add_thread_object): Use new.
1040         (delete_thread_object): Use delete.
1041         (infpy_threads): Update.
1042         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1043         GIL.
1044
1045 2019-07-10  Tom Tromey  <tromey@adacore.com>
1046
1047         * valops.c (value_cast): Specialize error message for Ada.
1048
1049 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1050
1051         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1052
1053 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1054
1055         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1056         bpstat_should_step): Return bool, adjust comments.
1057         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1058         bpstat_should_step): Likewise.
1059
1060 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1061
1062         * features/Makefile: Use feature target descriptions for Arm.
1063         * features/arm/arm-core.c: Generate new file.
1064         * features/arm/arm-fpa.c: Likewise.
1065         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1066         * features/arm/arm-m-profile.c: Likewise.
1067         * features/arm/arm-vfpv2.c: Likewise.
1068         * features/arm/arm-vfpv3.c: Likewise.
1069         * features/arm/xscale-iwmmxt.c: Likewise.
1070         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1071
1072 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1073
1074         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1075         ptrace earlier.
1076
1077 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1078
1079         * features/aarch64-pauth.c: Regenerate.
1080
1081 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1082
1083         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1084         bool.
1085         (bpstat_what): Use false instead of 0.
1086
1087 2019-07-09  Pedro Alves  <palves@redhat.com>
1088
1089         * break-catch-throw.c (is_exception_catchpoint): New.
1090         * breakpoint.c (print_one_breakpoint_location): New parameter
1091         'raw_loc'.  Handle it.  Use
1092         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1093         looking at the breakpoint's type.
1094         (print_one_breakpoint): If handling "maint info breakpoints", also
1095         print locations of exception catchpoints.
1096         * breakpoint.h (is_exception_catchpoint): Declare.
1097
1098 2019-07-09  Pedro Alves  <palves@redhat.com>
1099
1100         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1101         "addr" field.
1102         (allocate_location_exception_catchpoint): New.
1103         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1104         (initialize_throw_catchpoint_ops): Install
1105         allocate_location_exception_catchpoint as allocate_location
1106         method.
1107         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1108         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1109         bp_loc_other.
1110         (breakpoint_address_is_meaningful): Delete.
1111         (bl_address_is_meaningful): New.
1112         (breakpoint_locations_match): Adjust comment.
1113         (bp_location_from_bp_type): New, factored out of...
1114         (bp_location::bp_location(breakpoint *)): ... this.
1115         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1116         factored out of...
1117         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1118         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1119         breakpoint_address_is_meaningful.
1120         (bp_locations_compare): Adjust comment.
1121         (update_global_location_list): Use bl_address_is_meaningful
1122         instead of breakpoint_address_is_meaningful.
1123         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1124         explicit.
1125         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1126         * python/py-breakpoint.c (bppy_get_location): No longer check
1127         whether location is null.
1128
1129 2019-07-09  Pedro Alves  <palves@redhat.com>
1130
1131         PR c++/15468
1132         * breakpoint.c (print_one_breakpoint_location): Remove
1133         single-location assert.
1134
1135 2019-07-09  Tom Tromey  <tom@tromey.com>
1136
1137         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1138         * configure: Rebuild.
1139         * configure.ac: Change common to gdbsupport.
1140         * gdbsupport: Rename from common.
1141         * acinclude.m4: Change common to gdbsupport.
1142         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1143         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1144         gdbsupport.
1145         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1146         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1147         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1148         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1149         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1150         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1151         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1152         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1153         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1154         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1155         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1156         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1157         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1158         coff-pe-read.c, command.h, compile/compile-c-support.c,
1159         compile/compile-c.h, compile/compile-cplus-symbols.c,
1160         compile/compile-cplus-types.c, compile/compile-cplus.h,
1161         compile/compile-loc2c.c, compile/compile.c, completer.c,
1162         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1163         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1164         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1165         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1166         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1167         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1168         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1169         features/aarch64-core.c, features/aarch64-fpu.c,
1170         features/aarch64-pauth.c, features/aarch64-sve.c,
1171         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1172         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1173         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1174         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1175         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1176         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1177         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1178         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1179         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1180         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1181         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1182         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1183         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1184         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1185         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1186         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1187         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1188         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1189         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1190         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1191         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1192         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1193         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1194         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1195         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1196         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1197         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1198         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1199         minsyms.c, mips-linux-tdep.c, namespace.h,
1200         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1201         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1202         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1203         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1204         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1205         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1206         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1207         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1208         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1209         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1210         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1211         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1212         procfs.c, producer.c, progspace.h, psymtab.h,
1213         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1214         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1215         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1216         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1217         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1218         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1219         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1220         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1221         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1222         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1223         target-memory.c, target.c, target.h, target/waitstatus.c,
1224         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1225         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1226         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1227         unittests/array-view-selftests.c,
1228         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1229         unittests/common-utils-selftests.c,
1230         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1231         unittests/format_pieces-selftests.c,
1232         unittests/function-view-selftests.c,
1233         unittests/lookup_name_info-selftests.c,
1234         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1235         unittests/mkdir-recursive-selftests.c,
1236         unittests/observable-selftests.c,
1237         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1238         unittests/parse-connection-spec-selftests.c,
1239         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1240         unittests/scoped_fd-selftests.c,
1241         unittests/scoped_mmap-selftests.c,
1242         unittests/scoped_restore-selftests.c,
1243         unittests/string_view-selftests.c, unittests/style-selftests.c,
1244         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1245         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1246         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1247         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1248         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1249         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1250
1251 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1254         bool value.
1255         (decode_digits_ordinary): Set explicit_line field in sal.
1256         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1257         symtab_and_line that was set on an explicit line number in
1258         assembler code.  Do always update the recorded symtab and line if
1259         we do skip the prologue.
1260
1261 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * breakpoint.c (set_breakpoint_location_function): Remove
1264         explicit_loc parameter.
1265         (momentary_breakpoint_from_master): Update call to
1266         set_breakpoint_location_function.
1267         (add_location_to_breakpoint): Likewise.
1268
1269 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1272         required features based on default bfd type when no specific bfd
1273         is present.
1274
1275 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1276
1277         * NEWS: Mention that GDB printf and eval commands can now print
1278         C-style and Ada-style convenience var strings without
1279         calling the inferior.
1280         * printcmd.c (printf_c_string): Locally print GDB internal var
1281         instead of transiting via the inferior.
1282         (printf_wide_c_string): Likewise.
1283
1284 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1287
1288 2019-07-04  Tom Tromey  <tom@tromey.com>
1289
1290         PR tui/24724:
1291         * tui/tui-winsource.c (tui_clear_source_content): Update.
1292         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1293         (tui_update_breakpoint_info): Update.
1294         (tui_set_exec_info_content): Update.
1295         * tui/tui-source.c (tui_set_source_content_nil): Update.
1296         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1297         has_break.
1298         * tui/tui-data.h (enum tui_bp_flag): New.
1299         (tui_bp_flags): New enum flags type.
1300         (struct tui_source_element) <break_mode>: Change type.  Rename
1301         from has_break.
1302         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1303         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1304         constants.
1305         * tui/tui-winsource.h: Fix comment.
1306
1307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1310         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1311         (store_fpregs_to_thread)
1312         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1313         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1314         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1315         (IWMMXT_REGS_SIZE): Add define.
1316         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1317         (fetch_vfp_regs, store_vfp_regs)
1318         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1319         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1320
1321 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1322
1323         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1324         defines.
1325         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1326         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1327         (ARM_INT_REGISTER_SIZE): ...to this.
1328         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1329         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1330         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1331         (arm_linux_collect_gregset, supply_nwfpe_register)
1332         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1333         defines.
1334         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1335         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1336         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1337         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1338         (arm_return_in_memory, arm_store_return_value)
1339         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1340         (arm_record_ld_st_multiple): Likewise.
1341         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1342         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1343
1344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1345
1346         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1347         AARCH64_DISPLACED_MODIFIED_INSNS.
1348         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1349         (aarch64_displaced_step_copy_insn): Likewise.
1350         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1351         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1352         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1353         ARM_DISPLACED_MODIFIED_INSNS.
1354         * arm-tdep.c (arm_gdbarch_init): Likewise.
1355         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1356         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1357         (struct arm_displaced_step_closure): Use
1358         ARM_DISPLACED_MODIFIED_INSNS.
1359
1360 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1361
1362         * features/Makefile: Remove unused xml files.
1363         * features/aarch64.xml: Remove.
1364         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1365         * features/i386/amd64-avx-avx512.xml: Remove.
1366         * features/i386/amd64-avx-linux.xml: Remove.
1367         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1368         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1369         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1370         * features/i386/amd64-avx-mpx.xml: Remove.
1371         * features/i386/amd64-avx.xml: Remove.
1372         * features/i386/amd64-linux.xml: Remove.
1373         * features/i386/amd64-mpx-linux.xml: Remove.
1374         * features/i386/amd64-mpx.xml: Remove.
1375         * features/i386/amd64.xml: Remove.
1376         * features/i386/i386-avx-avx512-linux.xml: Remove.
1377         * features/i386/i386-avx-avx512.xml: Remove.
1378         * features/i386/i386-avx-linux.xml: Remove.
1379         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1380         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1381         * features/i386/i386-avx-mpx-linux.xml: Remove.
1382         * features/i386/i386-avx-mpx.xml: Remove.
1383         * features/i386/i386-avx.xml: Remove.
1384         * features/i386/i386-linux.xml: Remove.
1385         * features/i386/i386-mmx-linux.xml: Remove.
1386         * features/i386/i386-mmx.xml: Remove.
1387         * features/i386/i386-mpx-linux.xml: Remove.
1388         * features/i386/i386-mpx.xml: Remove.
1389         * features/i386/i386.xml: Remove.
1390         * features/i386/x32-avx-avx512-linux.xml: Remove.
1391         * features/i386/x32-avx-linux.xml: Remove.
1392         * features/i386/x32-linux.xml: Remove.
1393
1394 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1395
1396         * regformats/aarch64.dat: Remove.
1397         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1398         * regformats/i386/amd64-avx-linux.dat: Remove.
1399         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1400         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1401         * regformats/i386/amd64-linux.dat: Remove.
1402         * regformats/i386/amd64-mpx-linux.dat: Remove.
1403         * regformats/i386/amd64.dat: Remove.
1404         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1405         * regformats/i386/i386-avx-linux.dat: Remove.
1406         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1407         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1408         * regformats/i386/i386-linux.dat: Remove.
1409         * regformats/i386/i386-mmx-linux.dat: Remove.
1410         * regformats/i386/i386-mpx-linux.dat: Remove.
1411         * regformats/i386/i386.dat: Remove.
1412         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1413         * regformats/i386/x32-avx-linux.dat: Remove.
1414         * regformats/i386/x32-linux.dat: Remove.
1415
1416 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1417
1418         * aarch64-tdep.c: Remove xml self tests.
1419         * amd64-linux-tdep.c: Likewise.
1420         * amd64-tdep.c: Likewise.
1421         * i386-linux-tdep.c: Likewise.
1422         * i386-tdep.c: Likewise.
1423
1424 2019-07-03  Pedro Alves  <palves@redhat.com>
1425
1426         PR cli/24732
1427         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1428         (pipe_cmd_option_defs): New.
1429         (make_pipe_cmd_options_def_group): New.
1430         (pipe_command): Use gdb::option::process_options.
1431         (pipe_command_completer): New function.
1432         (_initialize_cli_cmds): Install completer for "pipe" command.
1433
1434 2019-07-03  Pedro Alves  <palves@redhat.com>
1435
1436         * cli/cli-option.c (union option_value) <string>: New field.
1437         (struct option_def_and_value): Add ctor, move ctor, dtor and
1438         use DISABLE_COPY_AND_ASSIGN.
1439         (option_def_and_value::clear_value): New.
1440         (parse_option, save_option_value_in_ctx, get_val_type_str)
1441         (add_setshow_cmds_for_options): Handle var_string.
1442         * cli-option.h (union option_def::var_address) <string>: New
1443         field.
1444         (struct string_option_def): New.
1445         * maint-test-options.c (struct test_options_opts): Add default
1446         ctor and use DISABLE_COPY_AND_ASSIGN.
1447         <string_opt>: New field.
1448         (test_options_opts::~test_options_opts): New.
1449         (test_options_opts::dump): Also dump "-string".
1450         (test_options_option_defs): Install "string.
1451
1452 2019-07-03  Pedro Alves  <palves@redhat.com>
1453
1454         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1455         option_value with a null enumeration.
1456         (complete_options): Save the option values in the context.
1457         (save_option_value_in_ctx): New, factored out from ...
1458         (process_options): ... here.
1459         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1460         of the function.
1461         * maint-test-options.c (test_options_opts::dump): New, factored
1462         out from ...
1463         (maintenance_test_options_command_mode): ... here.
1464         (maintenance_test_options_command_completion_result): Delete.
1465         (maintenance_test_options_command_completion_text): Update
1466         comment.
1467         (maintenance_show_test_options_completion_result): Change
1468         prototype.  Just print
1469         maintenance_test_options_command_completion_text.
1470         (save_completion_result): New.
1471         (maintenance_test_options_completer_mode): Pass options context to
1472         complete_options, and then save a dump.
1473         (_initialize_maint_test_options): Use add_cmd to install "maint
1474         show test-options-completion-result".
1475
1476 2019-07-03  Pedro Alves  <palves@redhat.com>
1477
1478         * NEWS (New commands): Mention "with" and "maint with".
1479         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1480         (with_command, with_command_completer): New.
1481         (pipe_command): Adjust to new repeat_previous
1482         interface.
1483         (_initialize_cli_cmds): Install the "with" command and its "w"
1484         alias.
1485         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1486         declarations.
1487         * cli/cli-setshow.c (parse_cli_var_uinteger)
1488         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1489         argument strings for all var_types.
1490         (get_setshow_command_value_string): New, factored out from ...
1491         (do_show_command): ... this.
1492         * cli/cli-setshow.h: Include <string>.
1493         (get_setshow_command_value_string): Declare.
1494         * command.h (repeat_previous): Now returns const char *.  Adjust
1495         comment.
1496         * maint.c: Include "cli/cli-cmds.h".
1497         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1498         (_initialize_maint_cmds): Register the "maintenance with" command.
1499         * top.c (repeat_previous): Move bits from pipe_command here:
1500         Return the saved command line, if any; error out if there's no
1501         command to relaunch.
1502
1503 2019-07-03  Pedro Alves  <palves@redhat.com>
1504
1505         * NEWS (New commands): Mention "maint set/show test-settings"
1506         instead of "maint test-settings".
1507         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1508         (maintenance_test_settings_set_list): Rename to ...
1509         (maintenance_set_test_settings_list): ... this.
1510         (maintenance_test_settings_show_list): Rename to  ...
1511         (maintenance_show_test_settings_list): ... this.
1512         (maintenance_test_settings_cmd): Delete.
1513         (maintenance_test_settings_set_cmd): ...
1514         (maintenance_set_test_settings_cmd): ... this.
1515         (maintenance_test_settings_show_cmd): ...
1516         (maintenance_show_test_settings_cmd): ... this.
1517         (maintenance_test_settings_show_value_cmd):
1518         (maintenance_show_test_settings_value_cmd): ... this.
1519         (_initialize_maint_test_settings): No longer install the "maint
1520         test-settings" prefix command.  Rename "maint test-settings set"
1521         to "maint set test-settings", and "maint test-settings show" to
1522         "maint show test-settings".  Adjust all subcommands.
1523
1524 2019-07-03  Pedro Alves  <palves@redhat.com>
1525
1526         * maint-test-settings.c: Fix file's intro comment.  Replace all
1527         references to "test-options" with references to "test-settings",
1528         in comments.
1529
1530 2019-07-03  Pedro Alves  <palves@redhat.com>
1531
1532         * maint-test-settings.c (maintenance_test_settings_xxx)
1533         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1534         New.
1535         (maintenance_test_settings_enums): Use them.
1536         (maintenance_test_settings_enum): Default to
1537         maintenance_test_settings_xxx.
1538         (_initialize_maint_test_settings): Initialize
1539         MAINTENANCE_TEST_SETTINGS_FILENAME.
1540
1541 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1542
1543         * breakpoint.h (remove_breakpoints_inf): Change return type to
1544         void, move function documentation here.
1545         * breakpoint.c (remove_breakpoints_inf): Change return type to
1546         void, move function documentation to header.
1547
1548 2019-07-02  Pedro Alves  <palves@redhat.com>
1549
1550         * NEWS (Completion improvements): Mention "info threads".
1551         * thread.c (struct info_threads_opts, info_threads_option_defs)
1552         (make_info_threads_options_def_group): New.
1553         (info_threads_command): Use gdb::option::process_options.
1554         (info_threads_command_completer): New.
1555         (_initialize_thread): Use gdb::option::build_help to build the
1556         help text for "info threads".
1557
1558 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1559
1560         * defs.h (generic_load): Move from here...
1561         * symfile.h (generic_load): ... to here.  Rename name parameter
1562         to args.
1563         * symfile.c (generic_load): Add comment.
1564
1565 2019-07-01  Tom Tromey  <tromey@adacore.com>
1566
1567         * dwarf2read.c
1568         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1569         declaration of without_params.  Fix formatting.
1570
1571 2019-07-01  Tom Tromey  <tromey@adacore.com>
1572
1573         * ada-exp.y (find_primitive_type): Update.
1574         * ada-lang.h (ada_lookup_symbol): Update.
1575         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1576         parameter.
1577         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1578
1579 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1580
1581         PR breakpoints/24541
1582         * gdbarch.c: Regenerate.
1583         * gdbarch.h: Regenerate.
1584         * gdbarch.sh: Add 'stap_adjust_register'.
1585         * i386-tdep.c: Include '<unordered_set>'.
1586         (i386_stap_adjust_register): New function.
1587         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1588         * stap-probe.c (stap_parse_register_operand): Call
1589         'gdbarch_stap_adjust_register'.
1590
1591 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1592
1593         PR python/24742
1594         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1595         * python/python.c (do_start_initialization): Use 'xmalloc'
1596         instead of 'PyMem_Malloc'.
1597
1598 2019-06-28  Tom Tromey  <tromey@adacore.com>
1599
1600         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1601         for Ada.
1602
1603 2019-06-27  Tom Tromey  <tromey@adacore.com>
1604
1605         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1606         objfile_key.
1607         (arm_find_mapping_symbol, arm_record_special_symbol)
1608         (_initialize_arm_tdep): Update.
1609         (arm_objfile_data_free): Remove.
1610
1611 2019-06-27  Tom Tromey  <tromey@adacore.com>
1612
1613         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1614         to cp_print_static_field.
1615
1616 2019-06-26  Tom Tromey  <tromey@adacore.com>
1617
1618         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1619         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1620         declare.
1621
1622 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1623
1624         * features/aarch64-core.c (create_feature_aarch64_core):
1625         Regenerate.
1626         * features/aarch64-core.xml: Add cpsr flags.
1627
1628 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1629
1630         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1631         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1632
1633 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1634
1635         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1636         field.
1637         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1638         use.
1639         (arm_record_special_symbol): Don't insert new symbol in sorted
1640         position, push it at the end.
1641
1642 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1643
1644         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1645         (arm_mapping_symbol_s): Remove.
1646         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1647         (arm_mapping_symbol_vec): New typedef.
1648         (struct arm_per_objfile): Add constructor.
1649         <section_maps>: Change type to
1650         std::unique_ptr<arm_mapping_symbol_vec[]>.
1651         (arm_compare_mapping_symbols): Remove.
1652         (arm_find_mapping_symbol): Adjust to section_maps type change.
1653         (arm_objfile_data_free): Call delete on arm_per_objfile.
1654         (arm_record_special_symbol): Adjust to section_maps type change.
1655         Allocate arm_per_objfile with new.
1656
1657 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1658
1659         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1660         with the command prefix.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1665         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1670         type.
1671         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1672         protected.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-winsource.c
1677         (tui_source_window_base::set_is_exec_point_at): Add check against
1678         LOA_ADDRESS.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-source.c (tui_set_source_content): Don't check before
1683         xfree.
1684         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1685
1686 2019-06-25  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-winsource.h (tui_update_source_window_as_is)
1689         (tui_alloc_source_buffer, tui_line_is_displayed)
1690         (tui_addr_is_displayed): Change type of win_info.
1691         * tui/tui-winsource.c (tui_update_source_window_as_is)
1692         (tui_clear_source_content, tui_show_source_line)
1693         (tui_show_source_content, tui_source_window_base::refill)
1694         (tui_source_window_base::set_is_exec_point_at)
1695         (tui_source_window_base::set_is_exec_point_at)
1696         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1697         (tui_alloc_source_buffer, tui_line_is_displayed)
1698         (tui_addr_is_displayed): Change type of win_info.  Update.
1699         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1700         (tui_source_window_base::do_make_visible_with_new_height):
1701         Update.
1702         * tui/tui-source.c (tui_set_source_content)
1703         (tui_set_source_content_nil)
1704         (tui_source_window::do_scroll_vertical): Update.
1705         * tui/tui-layout.c (show_layout): Update.
1706         * tui/tui-disasm.c (tui_set_disassem_content)
1707         (tui_disasm_window::do_scroll_vertical): Update.
1708         * tui/tui-data.h (tui_win_content): Remove.
1709         (struct tui_gen_win_info) <content, content_size>: Remove.
1710         (struct tui_source_element): Add initializers and destructor.
1711         (union tui_which_element, struct tui_win_element): Remove.
1712         (struct tui_source_window_base) <content>: New field.
1713         (struct tui_data_window): Remove destructor.
1714         (tui_alloc_content, tui_free_win_content)
1715         (tui_free_all_source_wins_content): Don't declare.
1716         * tui/tui-data.c (tui_initialize_static_data): Update.
1717         (init_content_element, tui_alloc_content): Remove.
1718         (~tui_gen_win_info): Update.
1719         (~tui_data_window, tui_free_all_source_wins_content)
1720         (tui_free_win_content, free_content, free_content_elements):
1721         Remove.
1722
1723 2019-06-25  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-winsource.h (tui_clear_source_content)
1726         (tui_erase_source_content, tui_show_source_content): Change type
1727         of win_info.
1728         * tui/tui-winsource.c (tui_clear_source_content)
1729         (tui_erase_source_content, tui_show_source_content): Change type
1730         of win_info.
1731         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1732         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1733         win_info.
1734         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1735         win_info.
1736         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-winsource.c (tui_clear_source_content)
1741         (tui_source_window_base::set_is_exec_point_at): Update.
1742         * tui/tui-source.c (tui_set_source_content_nil): Update.
1743         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1744         a bool.
1745         * tui/tui-data.c (init_content_element): Update.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1750         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1751         * tui/tui-layout.c (init_and_make_win): Update.
1752         * tui/tui.h (enum tui_win_type): Update.
1753         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1754         tui_win_is_auxillary.
1755         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1756         tui_win_is_auxillary.
1757
1758 2019-06-25  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1761         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1762         (tui_delete_data_content_windows, tui_display_all_data)
1763         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1764         Update.
1765         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1766         * tui/tui-regs.c (tui_last_regs_line_no)
1767         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1768         (tui_show_registers): Update.
1769         (tui_show_register_group): Return void.  Update.
1770         (tui_display_registers_from, tui_display_reg_element_at_line)
1771         (tui_display_registers_from_line, tui_check_register_values):
1772         Update.
1773         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1774         member.
1775         (struct tui_data_window) <regs_content>: Now a std::vector.
1776         <regs_content_count>: Remove.
1777         (tui_add_content_elements, tui_free_data_content): Don't declare.
1778         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1779         (init_content_element): Remove DATA_WIN case.  Add assert.
1780         (tui_add_content_elements): Remove.
1781         (tui_data_window): Update.
1782         (tui_free_data_content): Remove.
1783         (free_content_elements): Remove DATA_WIN case.
1784
1785 2019-06-25  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-data.c (tui_data_item_window): Update.
1788         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1789         * tui/tui-windata.c (tui_display_all_data)
1790         (tui_display_data_from_line): Update.
1791         (tui_check_data_values): Remove.
1792         * tui/tui-regs.c (tui_show_register_group)
1793         (tui_display_reg_element_at_line): Update.
1794         * tui/tui-hooks.c (tui_register_changed)
1795         (tui_refresh_frame_and_register_information): Call
1796         tui_check_register_values.
1797         * tui/tui-data.h (struct tui_data_window) <data_content,
1798         data_content_count, data_type>: Remove.
1799         (enum tui_data_type): Remove.
1800
1801         * tui/tui-data.c (tui_data_window::clear_detail)
1802         (~tui_data_window): Update.
1803
1804 2019-06-25  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1807         declare.
1808         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1809         Rename from tui_first_data_item_displayed.  Update.
1810         (tui_data_window::refresh_all)
1811         (tui_data_window::do_scroll_vertical): Update.
1812         * tui/tui-data.h (struct tui_data_window)
1813         <first_data_item_displayed>: Declare new method.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1818         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1819         contents...
1820         (tui_initialize_static_data): ...here.
1821
1822 2019-06-25  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1825         (tui_display_registers_from, tui_check_register_values): Update.
1826         (tui_display_register): Remove win_info parameter; update.
1827         (tui_get_register): Change type of parameters.
1828         * tui/tui-data.h (struct tui_data_element): Remove.
1829         (union tui_which_element) <data>: Remove.
1830         <data_window>: Change type.
1831         (struct tui_data_item_window): New.
1832         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1833         case.  Add assert.
1834         (~tui_data_item_window): New destructor.
1835         (free_content_elements): Remove DATA_ITEM_WIN case.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1840         Remove.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-data.h (struct tui_command_element): Remove.
1845         (union tui_which_element) <command>: Remove.
1846         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1847         assert.
1848         (free_content_elements): Remove CMD_WIN case.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-layout.c (tui_set_layout): Update.
1853         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1854         * tui/tui-data.c (layout_def): Update.
1855
1856 2019-06-25  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1859         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1860         (tui_source_window_base::set_new_height): Update.
1861         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1862         Update.
1863         (tui_set_locator_fullname, tui_set_locator_info)
1864         (tui_show_frame_info): Update.
1865         * tui/tui-source.c (tui_set_source_content)
1866         (tui_source_is_displayed): Update.
1867         * tui/tui-layout.c (show_source_disasm_command, show_data)
1868         (show_source_or_disasm_and_command): Update.
1869         * tui/tui-disasm.c (tui_set_disassem_content)
1870         (tui_get_begin_asm_address): Update.
1871         * tui/tui-data.h (struct tui_locator_element): Remove.
1872         (union tui_which_element) <locator>: Remove.
1873         (struct tui_locator_window): New.
1874         (tui_locator_win_info_ptr): Change return type.
1875         * tui/tui-data.c (_locator): Change type.
1876         (tui_locator_win_info_ptr): Change return type.
1877         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1878         (tui_alloc_content): Add assert.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.c
1883         (tui_exec_info_window::maybe_allocate_content): New method.
1884         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1885         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1886         (make_source_or_disasm_window): Add cast.
1887         * tui/tui-data.h (union tui_which_element) <simple_string>:
1888         Remove.
1889         (struct tui_source_info): New.
1890         (struct tui_source_window_base) <execution_info>: Change type.
1891         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1892         case, and add assert.
1893         (tui_alloc_content): Add assert.
1894
1895 2019-06-25  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1898         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1899         * tui/tui-data.c (tui_alloc_win_info): Remove.
1900
1901 2019-06-25  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1904         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1905         can_highlight.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1910         make_visible_with_new_height method.
1911         (tui_win_info::make_visible_with_new_height): New method.
1912         (tui_source_window_base::do_make_visible_with_new_height)
1913         (tui_data_window::do_make_visible_with_new_height)
1914         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1915         (make_visible_with_new_height): Remove.
1916         (tui_resize_all, tui_adjust_win_heights): Use
1917         make_visible_with_new_height method.
1918         * tui/tui-data.h (struct tui_win_info)
1919         <do_make_visible_with_new_height, make_visible_with_new_height>:
1920         New methods.
1921         (struct tui_source_window_base, struct tui_data_window)
1922         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1923         methods.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1928         method.
1929         (update_tab_width): Call update_tab_width method.
1930         * tui/tui-data.h (struct tui_win_info)
1931         (struct tui_source_window_base) <update_tab_width>: New methods.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1936         parameter.
1937         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1938         parameter.
1939         (tui_gen_win_info::make_visible): Update.
1940         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1941         parameter.
1942         * tui/tui-data.h (enum tui_box): New enum.
1943         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1944
1945 2019-06-25  Tom Tromey  <tom@tromey.com>
1946
1947         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1948         init_and_make_win for EXEC_INFO_WIN.
1949         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1950         longer inline.
1951         (struct tui_win_info) <~tui_win_info>: Inline.
1952         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1953         Don't declare.
1954         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1955         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1956         Remove.
1957         (tui_initialize_static_data): Update.
1958         (~tui_gen_win_info): Handle more cleanup here.
1959         (~tui_source_window_base): Delete "execution_info".
1960         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-layout.c (make_command_window): Don't set
1965         can_highlight.
1966         (show_source_disasm_command): Call the reset method.
1967         (show_data): Don't set can_highlight.  Call the reset method.
1968         (tui_gen_win_info::reset): Rename from init_gen_win_info
1969         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1970         (show_source_or_disasm_and_command): Call the reset method.
1971         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1972         (struct tui_cmd_window): Set can_highlight.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1977         from make_visible.
1978         (tui_make_visible, tui_make_invisible): Rewrite.
1979         (tui_win_info::make_visible): Remove.
1980         (tui_source_window_base::make_visible): Update.
1981         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1982         method.  Moved from...
1983         (struct tui_win_info) <make_visible>: ...here.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.c
1988         (tui_source_window_base::do_scroll_horizontal): Remove direction
1989         parameter.
1990         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1991         direction parameter.
1992         * tui/tui-win.c (tui_win_info::forward_scroll)
1993         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1994         (tui_win_info::right_scroll): Update.
1995         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1996         direction parameter.
1997         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1998         direction parameter.
1999         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2000         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2001         Remove direction parameter.
2002         (struct tui_source_window_base, struct tui_source_window)
2003         (struct tui_disasm_window, struct tui_data_window)
2004         (struct tui_cmd_window): Update.
2005
2006 2019-06-25  Tom Tromey  <tom@tromey.com>
2007
2008         * tui/tui-winsource.h (tui_set_exec_info_content)
2009         (tui_show_exec_info_content, tui_erase_exec_info_content)
2010         (tui_clear_exec_info_content, tui_update_exec_info): Change
2011         argument to tui_source_window_base.
2012         * tui/tui-winsource.c (tui_set_exec_info_content)
2013         (tui_show_exec_info_content, tui_erase_exec_info_content)
2014         (tui_clear_exec_info_content, tui_update_exec_info): Change
2015         argument to tui_source_window_base.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2020         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2025         check.
2026
2027 2019-06-25  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2030         type to void.
2031         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2032         type to void.
2033         * tui/tui-source.c (tui_set_source_content): Update.
2034         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-win.c (window_name_completer, tui_set_focus)
2039         (tui_all_windows_info): Use name method.
2040         * tui/tui-data.h (struct tui_gen_win_info)
2041         (struct tui_source_window, struct tui_disasm_window)
2042         (struct tui_data_window, struct tui_cmd_window) <name>: New
2043         method.
2044         (tui_win_name): Don't declare.
2045         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2046         (tui_win_name): Remove.
2047
2048 2019-06-25  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-winsource.h (tui_update_source_window)
2051         (tui_update_source_window_as_is): Change parameter type.
2052         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2053         to be a tui_source_window_base.
2054         (tui_update_source_window_as_is): Likewise.
2055         * tui/tui-win.c (make_visible_with_new_height): Update.
2056
2057 2019-06-25  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-winsource.c (tui_erase_source_content)
2060         (tui_show_source_content, tui_show_exec_info_content)
2061         (tui_erase_exec_info_content): Use refresh_window method.
2062         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2063         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2064         from tui_refresh_win.
2065         (tui_data_window::refresh_window): New method.
2066         (tui_win_info::refresh, tui_source_window_base::refresh)
2067         (tui_refresh_all): Use refresh_window method.
2068         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2069         method.
2070         * tui/tui-regs.c (tui_display_register): Call refresh_window
2071         method.
2072         * tui/tui-layout.c (show_source_disasm_command)
2073         (show_source_or_disasm_and_command): Call refresh_window method.
2074         * tui/tui-data.h (struct tui_gen_win_info)
2075         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2076         New method.
2077
2078 2019-06-25  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui.c (tui_rl_other_window, tui_enable)
2081         (tui_is_window_visible, tui_get_command_dimension): Update.
2082         * tui/tui-winsource.c (tui_update_source_window_as_is)
2083         (tui_clear_source_content, tui_erase_source_content)
2084         (tui_show_source_line, tui_source_window_base::refill)
2085         (tui_source_window_base::do_scroll_horizontal)
2086         (tui_source_window_base::set_is_exec_point_at)
2087         (tui_update_breakpoint_info, tui_set_exec_info_content)
2088         (tui_alloc_source_buffer, tui_line_is_displayed)
2089         (tui_addr_is_displayed): Update.
2090         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2091         (tui_check_and_display_highlight_if_needed)
2092         (tui_win_info::make_visible, tui_win_info::refresh)
2093         (tui_refresh_all): Update.
2094         * tui/tui-windata.c (tui_first_data_item_displayed)
2095         (tui_delete_data_content_windows, tui_erase_data_content)
2096         (tui_display_all_data, tui_data_window::refresh_all)
2097         (tui_check_data_values): Update.
2098         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2099         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2100         (tui_win_info::backward_scroll, tui_refresh_all_win)
2101         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2102         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2103         (tui_source_window_base::set_new_height)
2104         (tui_data_window::set_new_height)
2105         (make_invisible_and_set_new_height)
2106         (make_visible_with_new_height, new_height_ok)
2107         (parse_scrolling_args): Update.
2108         * tui/tui-stack.c (tui_show_frame_info): Update.
2109         * tui/tui-source.c (tui_set_source_content)
2110         (tui_set_source_content_nil, tui_source_is_displayed)
2111         (tui_source_window::do_scroll_vertical): Update.
2112         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2113         (tui_display_registers_from, tui_display_reg_element_at_line)
2114         (tui_check_register_values, tui_reg_command): Update.
2115         * tui/tui-layout.c (tui_default_win_height)
2116         (show_source_disasm_command, show_data, init_and_make_win)
2117         (show_source_or_disasm_and_command): Update.
2118         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2119         (tui_redisplay_readline, tui_mld_flush)
2120         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2121         (tui_getc): Update.
2122         * tui/tui-disasm.c (tui_set_disassem_content)
2123         (tui_disasm_window::do_scroll_vertical): Update.
2124         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2125         Now virtual.
2126         (struct tui_win_info): Derive from tui_gen_win_info.
2127         <~tui_win_info>: Mark as override.
2128         <generic>: Remove member.
2129         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2130         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2131         (~tui_data_window, ~tui_win_info)
2132         (tui_free_all_source_wins_content): Update.
2133         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-layout.c (init_and_make_win): Use new.
2138         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2139         destructor, initializers.
2140         (tui_alloc_generic_win_info): Don't declare.
2141         * tui/tui-data.c (_locator): Add argument to constructor.
2142         (source_win, disasm_win): New globals.
2143         (exec_info): Remove.
2144         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2145         Update.
2146         (tui_alloc_generic_win_info): Remove.
2147         (init_content_element): Use new.
2148         (tui_win_info::tui_win_info): Update.
2149         (free_content_elements) <case DATA_WIN>: Use delete.
2150
2151 2019-06-25  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2154         * tui/tui-windata.c (tui_first_data_item_displayed)
2155         (tui_delete_data_content_windows): Update.
2156         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2157         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2158         (tui_display_registers_from, tui_check_register_values): Update.
2159         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2160         pointer.
2161         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2162         window.
2163         (tui_free_data_content): Update.
2164         (free_content_elements) <case DATA_WIN>: Free the window.
2165
2166 2019-06-25  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2169         Update.
2170         * tui/tui-layout.c (make_command_window)
2171         (show_source_disasm_command, show_data, init_and_make_win)
2172         (show_source_or_disasm_and_command): Update.
2173         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2174         method.
2175         <can_highight, is_highlighted>: Now bool.
2176         (tui_set_win_highlight): Don't declare.
2177         * tui/tui-data.c (tui_set_win_highlight): Remove.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-wingeneral.c (make_visible): Remove check of window
2182         type.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-win.c (tui_win_info::max_height)
2187         (tui_cmd_window::max_height): New methods.
2188         (new_height_ok): Call max_height.
2189         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2190         <max_height>: New method.
2191
2192 2019-06-25  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-win.c (tui_source_window_base::set_new_height)
2195         (tui_data_window::set_new_height): New methods.
2196         (make_invisible_and_set_new_height): Call set_new_height method.
2197         * tui/tui-data.h (struct tui_win_info)
2198         (struct tui_source_window_base, struct tui_data_window)
2199         <set_new_height>: New method.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2204         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2205         tui_refresh_data_win.
2206         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2207         method.
2208         (tui_refresh_all_win): Call the refresh_all method.
2209         (tui_set_focus): Likewise.
2210         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2211         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2212         Likewise.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-winsource.h (tui_refill_source_window)
2217         (tui_set_is_exec_point_at): Don't declare.
2218         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2219         (tui_source_window_base::refill): Rename from
2220         tui_refill_source_window.
2221         (tui_source_window_base::do_scroll_horizontal): Update.
2222         (tui_source_window_base::set_is_exec_point_at): Rename from
2223         tui_set_is_exec_point_at.
2224         (tui_update_all_breakpoint_info): Update.
2225         * tui/tui-stack.c (tui_show_frame_info): Update.
2226         * tui/tui-layout.c (show_data): Add cast.
2227         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2228         * tui/tui-data.h (struct tui_source_window_base) <refill,
2229         set_is_exec_point_at>: New methods.
2230         (tui_source_windows, tui_add_to_source_windows): Update types.
2231         (tui_add_to_source_windows): Remove redundant declaration.
2232         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2233         (tui_source_windows): Change return type.
2234         (tui_clear_source_windows_detail): Update.
2235         (tui_add_to_source_windows): Change type of parameter.
2236         (tui_free_all_source_wins_content): Update.
2237
2238 2019-06-25  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-wingeneral.c (tui_win_info::refresh)
2241         (tui_source_window_base::refresh): New methods.
2242         (tui_refresh_all): Call the refresh method.
2243         * tui/tui-data.h (struct tui_win_info)
2244         (struct tui_source_window_base) <refresh>: New method.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui.h (tui_is_window_visible): Return bool.
2249         * tui/tui.c (tui_is_window_visible): Return bool.
2250         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2251         (tui_make_visible, tui_make_invisible)
2252         (tui_win_info::make_visible)
2253         (tui_source_window_base::make_visible, make_all_visible)
2254         (tui_make_all_visible, tui_make_all_invisible): Update.
2255         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2256         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2257         bool.
2258         (struct tui_win_info, struct tui_source_window_base)
2259         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2260         * tui/tui-data.c (tui_init_generic_part): Update.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2265         (tui_source_window_base::make_visible): New methods.
2266         (make_all_visible): Make method call.
2267         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2268         (struct tui_source_window_base, struct tui_cmd_window): Override
2269         make_visible.
2270         (tui_win_is_source_type): Don't declare.
2271         * tui/tui-data.c (tui_win_is_source_type): Remove.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2276         NULL check.
2277
2278 2019-06-25  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2281         Inline constructor.  Add initializers for members.
2282         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2283         constructors; now inline in class.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-regs.c (tui_show_registers): Update.
2288         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2289         bool.
2290         * tui/tui-data.c (tui_data_window::clear_detail)
2291         (tui_data_window): Update.
2292
2293 2019-06-25  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-windata.c (tui_display_all_data)
2296         (tui_display_data_from_line, tui_display_data_from)
2297         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2298         Update.
2299         * tui/tui-regs.c (tui_last_regs_line_no)
2300         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2301         (tui_show_registers, tui_show_register_group)
2302         (tui_display_registers_from, tui_display_reg_element_at_line)
2303         (tui_display_registers_from_line, tui_check_register_values)
2304         (tui_reg_next, tui_reg_prev): Update.
2305         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2306         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2307         tui_data_window.
2308         (struct tui_win_info) <detail>: Remove.  Add new fields from
2309         tui_data_info.
2310         (TUI_DATA_WIN): Add cast.
2311         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2312         (~tui_data_window): Simplify.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-layout.c (show_source_disasm_command)
2317         (show_source_or_disasm_and_command): Update.
2318         * tui/tui-io.c (update_cmdwin_start_line)
2319         (tui_redisplay_readline): Update.
2320         * tui/tui-data.h (struct tui_command_info): Remove.
2321         (struct tui_win_info) <detail>: Remove command_info member.
2322         (struct tui_data_window) <start_line>: New member, from
2323         tui_command_info.
2324         (TUI_CMD_WIN): Add casts.
2325
2326 2019-06-25  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-winsource.c (tui_update_source_window)
2329         (tui_refill_source_window)
2330         (tui_source_window_base::do_scroll_horizontal)
2331         (tui_update_breakpoint_info, tui_set_exec_info_content)
2332         (tui_show_exec_info_content, tui_erase_exec_info_content)
2333         (tui_clear_exec_info_content): Update.
2334         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2335         Update.
2336         * tui/tui-win.c (make_invisible_and_set_new_height)
2337         (make_visible_with_new_height): Update.
2338         * tui/tui-source.c (tui_set_source_content)
2339         (tui_show_symtab_source): Update.
2340         * tui/tui-layout.c (extract_display_start_addr)
2341         (show_source_disasm_command, show_data)
2342         (make_source_or_disasm_window)
2343         (show_source_or_disasm_and_command): Update.
2344         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2345         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2346         "gdbarch".
2347         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2348         to tui_source_window_base.
2349         (struct tui_win_info) <detail>: Remove source_info member.
2350         (struct tui_source_window_base) <has_locator>: Inline.
2351         Move contents from tui_source_info; rename has_locator member to
2352         m_has_locator.
2353         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2354         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2355         header file.
2356         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2357         Simplify.
2358         (tui_free_all_source_wins_content): Cast to
2359         tui_source_window_base.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-win.c (make_invisible_and_set_new_height)
2364         (make_visible_with_new_height): Call has_locator method.
2365         * tui/tui-layout.c (show_source_disasm_command, show_data)
2366         (show_source_or_disasm_and_command): Update for bool change.
2367         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2368         (tui_win_info) <has_locator>: New method.
2369         (struct tui_source_window_base) <has_locator>: New method.
2370         (tui_win_has_locator): Don't declare.
2371         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2372         from tui_win_has_locator.
2373         (tui_source_window_base): Use false, not FALSE.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2378         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2379         clear_detail method directly.
2380         (tui_clear_win_detail): Remove.
2381
2382 2019-06-25  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2385         "this", not TUI_DISASM_WIN.
2386
2387 2019-06-25  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2390         declare.
2391         * tui/tui-winsource.c
2392         (tui_source_window_base::do_scroll_horizontal): Rename from
2393         tui_horizontal_source_scroll.
2394         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2395         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2396         from tui_vertical_data_scroll.
2397         * tui/tui-win.h (tui_scroll): Don't declare.
2398         * tui/tui-win.c (tui_win_info::forward_scroll)
2399         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2400         (tui_win_info::right_scroll): Rename and update.
2401         (tui_scroll_forward_command, tui_scroll_backward_command)
2402         (tui_scroll_left_command, tui_scroll_right_command): Update.
2403         (tui_scroll): Remove.
2404         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2405         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2406         from tui_vertical_source_scroll.
2407         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2408         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2409         from tui_vertical_disassem_scroll.
2410         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2411         do_scroll_horizontal>: New methods.
2412         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2413         Likewise.
2414         (struct tui_source_window_base): Add do_scroll_horizontal.
2415         (struct tui_source_window, struct tui_disasm_window): Add
2416         do_scroll_vertical.
2417         (struct tui_data_window, struct tui_cmd_window): Add
2418         do_scroll_horizontal and do_scroll_vertical.
2419         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2420
2421 2019-06-25  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-data.h (struct tui_source_window_base): New struct.
2424         (struct tui_source_window): Derive from tui_source_window_base.
2425         (struct tui_disasm_window): New struct.
2426         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2427         from tui_source_window::clear_detail.
2428         (tui_source_window_base): Rename from tui_source_window.
2429         (~tui_source_window_base): Rename from ~tui_source_window.
2430         (tui_alloc_win_info): Create a tui_disasm_window.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-data.h (struct tui_source_window)
2435         (struct tui_data_window): Declare destructors.
2436         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2437         destructors.
2438         (tui_win_info): Simplify.
2439
2440 2019-06-25  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui-winsource.c (tui_display_main)
2443         (tui_update_source_windows_with_addr)
2444         (tui_update_all_breakpoint_info): Update.
2445         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2446         (new_height_ok, parse_scrolling_args): Update.
2447         * tui/tui-stack.c (tui_show_frame_info): Update.
2448         * tui/tui-data.h (struct tui_list): Remove.
2449         (tui_source_windows): Return a reference to a std::vector.
2450         * tui/tui-data.c (source_windows): Now a std::vector.
2451         (tui_source_windows): Change return type.
2452         (tui_clear_source_windows): Rewrite.
2453         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2454         (tui_free_all_source_wins_content): Rewrite.
2455
2456 2019-06-25  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2459         (struct tui_data_window, struct tui_cmd_window): Declare
2460         clear_detail method.
2461         * tui/tui-data.c (tui_source_window::clear_detail)
2462         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2463         methods.
2464         (tui_clear_win_detail): Simplify.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-layout.c (make_source_window, make_disasm_window)
2469         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2470         Return the new window.
2471         (show_source_disasm_command, show_data)
2472         (show_source_or_disasm_and_command): Update.
2473
2474 2019-06-25  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2477         parameter.  Return the new window.
2478         (show_source_disasm_command): Update and remove NULL check.
2479         (show_source_or_disasm_and_command): Update.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2484
2485 2019-06-25  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-data.h (struct tui_win_info): Make constructor
2488         protected.  Make destructor virtual.  Add initializers.
2489         (tui_source_window, tui_data_window, tui_cmd_window): New
2490         classes.
2491         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2492         constructor.  Add "type" parameter.
2493         (tui_source_window, tui_data_window, tui_cmd_window): New
2494         constructors.
2495         (tui_alloc_win_info): Instantiate the appropriate subclass.
2496
2497 2019-06-25  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-win.c (tui_resize_all): Use delete.
2500         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2501         destructor.
2502         (tui_free_window): Don't declare.
2503         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2504         Update.
2505
2506 2019-06-25  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-data.h (struct tui_win_info): Add constructor.
2509         * tui/tui-data.c (tui_alloc_win_info): Use new.
2510         (tui_free_window): Use delete.
2511
2512 2019-06-22  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2515         declare.
2516         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2517
2518 2019-06-22  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2521         declare.
2522         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2523
2524 2019-06-22  Tom de Vries  <tdevries@suse.de>
2525
2526         * dwarf2read.c (create_addrmap_from_aranges)
2527         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2528         instead of '%zu'.
2529
2530 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2531
2532         * dwarf2read.h (dwarf2_section_info_def): Remove.
2533         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2534         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2535         std::vector<dwarf2_section_info>.
2536         (struct dwo_file) <~dwo_file>: Remove.
2537         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2538         types field.
2539         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2540         (dwarf2_read_debug_names): Likewise.
2541         (create_debug_types_hash_table): Change parameter type to
2542         array_view, adjust code accordingly.
2543         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2544         (partial_die_info::fixup): Likewise.
2545         (determine_prefix): Likewise.
2546         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2547
2548 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2549
2550         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2551         gdb_bfd_ref_ptr.
2552         <~dwo_file>: Remove call to gdb_bfd_unref.
2553         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2554         gdb_bfd_ref_ptr::get.
2555
2556 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2557
2558         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2559         type to htab_up.
2560         * dwarf2read.c (struct dwo_file): Initialize fields.
2561         <~dwo_file>: New.
2562         (free_dwo_file): Remove, move content to ~dwo_file.
2563         (struct dwo_file_deleter): Remove.
2564         (dwo_file_up>: Remove custom deleter.
2565         (free_dwo_files): Remove.
2566         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2567         dwo_files.
2568         (process_skeletonless_type_units): Call unique_ptr::get.
2569         (allocate_dwo_file_hash_table): Add deleter to created hash
2570         table.  Change return type to htab_up.
2571         (lookup_dwo_file_slot): Don't memset dwo_file, call
2572         unique_ptr::get.
2573         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2574         (create_dwo_unit_in_dwp_v2): Likewise.
2575         (open_and_init_dwo_file): Likewise.
2576         (free_dwo_file_from_slot): Remove.
2577
2578 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2579
2580         * dwarf2read.h (struct dwarf2_section_info) <readin,
2581         is_virtual>: Change type to bool.
2582         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2583         true instead of 1.
2584
2585 2019-06-19  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-data.h (tui_init_content_element): Don't declare.
2588
2589 2019-06-19  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-data.h (tui_init_win_info): Don't declare.
2592
2593 2019-06-19  Tom de Vries  <tdevries@suse.de>
2594
2595         * dwarf2read.h (abstract_to_concrete): Change type to
2596         std::unordered_map<sect_offset, std::vector<sect_offset>,
2597         gdb::hash_enum<sect_offset>>.
2598
2599 2019-06-19  Tom Tromey  <tromey@adacore.com>
2600
2601         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2602         EVAL_AVOID_SIDE_EFFECTS specially.
2603
2604 2019-06-19  Tom Tromey  <tromey@adacore.com>
2605
2606         * source-cache.c (highlighter): New global.
2607         (source_cache::get_source_lines): Create a highlighter on demand.
2608
2609 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * defs.h (deprecated_interactive_hook): Delete declaration.
2612         * interps.c (clear_interpreter_hooks): Remove use of
2613         deprecated_interactive_hook.
2614         * top.c (deprecated_interactive_hook): Delete definition.
2615         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2616
2617 2019-06-18  Tom de Vries  <tdevries@suse.de>
2618
2619         PR gdb/24515
2620         * dwarf2read.h (abstract_to_concrete): Change type from
2621         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2622         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2623         * dwarf2read.c (read_variable): Update.
2624         (dwarf2_fetch_die_loc_sect_off): Update.
2625
2626 2019-06-17  Tom de Vries  <tdevries@suse.de>
2627
2628         PR gdb/24617
2629         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2630         accessing parent[parent_len - 1].
2631
2632 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2633
2634         PR gdb/24364
2635         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2636         call dtrace_process_dof with NULL dof.
2637
2638 2019-06-16  Tom de Vries  <tdevries@suse.de>
2639
2640         PR gdb/24445
2641         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2642
2643 2019-06-16  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2646         (make_all_visible): Use address of member.
2647
2648 2019-06-16  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2651         (tui_free_window, free_content, free_content_elements): Remove
2652         unnecessary cast.
2653         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2654         cast.
2655         * tui/tui-regs.c (tui_show_register_group)
2656         (tui_display_registers_from, tui_display_reg_element_at_line):
2657         Remove unnecessary cast.
2658
2659 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2660
2661         * linux-nat.c (normal_mask): Delete.
2662         (_initialize_linux_nat): Don't initialise normal_mask.
2663
2664 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2665
2666         PR gdb/24445
2667         * dwarf-index-write.h (write_psymtabs_to_index): Add
2668         dwz_basename parameter.
2669         * dwarf-index-write.c (write_gdbindex): Move file writing to
2670         write_gdbindex_1.  Change return type void.
2671         (assert_file_size): Move up, remove filename parameter.
2672         (write_gdbindex_1): New function.
2673         (write_debug_names): Change return type to void, call
2674         assert_file_size.
2675         (struct index_wip_file): New struct.
2676         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2677         file logic to index_wip_file.  Write index for dwz file if
2678         needed.
2679         (save_gdb_index_command): Pass basename of dwz file, if present.
2680         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2681         build-id of dwz file, if present.
2682         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2683         (dwarf2_get_dwz_file): Likewise.
2684         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2685         (dwarf2_get_dwz_file): Likewise.
2686
2687 2019-06-16  Tom Tromey  <tom@tromey.com>
2688
2689         * coffread.c (process_coff_symbol): Use xstrdup.
2690         * value.c (create_internalvar): Use xstrdup.
2691
2692 2019-06-16  Tom Tromey  <tom@tromey.com>
2693
2694         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2695         * breakpoint.c (stopin_command, stopat_command)
2696         (until_break_command, decode_location_default): Remove unnecessary
2697         cast.
2698         * utils.c (subset_compare): Remove unnecessary cast.
2699         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2700         cast.
2701         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2702         cast.
2703         * infcmd.c (path_command): Remove unnecessary cast.
2704         * coffread.c (decode_type): Remove unnecessary cast.
2705         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2706         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2707         * tui/tui-stack.c (tui_show_locator_content)
2708         (tui_show_frame_info): Remove unnecessary cast.
2709         * tui/tui-win.c (tui_scroll_forward_command)
2710         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2711         (parse_scrolling_args): Remove unnecessary cast.
2712         * tui/tui-data.c (init_win_info, tui_del_window)
2713         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2714         (free_content_elements): Remove unnecessary cast.
2715         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2716         unnecessary cast.
2717         * tui/tui-source.c (tui_set_source_content)
2718         (tui_vertical_source_scroll): Remove unnecessary cast.
2719         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2720         cast.
2721         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2722         * tui/tui-regs.c (tui_display_registers_from)
2723         (tui_display_register): Remove unnecessary cast.
2724         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2725         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2726         (make_visible): Remove unnecessary cast.
2727         * tui/tui-winsource.c (tui_erase_source_content)
2728         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2729         unnecessary cast.
2730         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2731         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2732         * stabsread.c (read_type, read_array_type, read_range_type):
2733         Remove unnecessary cast.
2734         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2735         (parse_symbol, parse_type, upgrade_type, parse_external)
2736         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2737         unnecessary cast.
2738         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2739
2740 2019-06-16  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-data.c (tui_alloc_generic_win_info)
2743         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2744         checks.
2745
2746 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2747             Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * f-typeprint.c (f_print_type): Don't return early for not
2750         associated or not allocated types.
2751         (f_type_print_varspec_suffix): Add print_rank parameter and print
2752         ranks of array types in case they dangling.
2753         (f_type_print_base): Add print_rank parameter.
2754
2755 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * NEWS: Mention new MI commands.
2758         * break-catch-throw.c (enum exception_event_kind): Move to
2759         breakpoint.h.
2760         (print_mention_exception_catchpoint): Output text as a single
2761         message.
2762         (catch_exception_command_1): Rename to...
2763         (catch_exception_event): ...this, make non-static, update header
2764         command, and change some parameter types.
2765         (catch_catch_command): Update for changes to
2766         catch_exception_command_1.
2767         (catch_throw_command): Likewise.
2768         (catch_rethrow_command): Likewise.
2769         * breakpoint.c (enum exception_event_kind): Delete.
2770         * breakpoint.h (enum exception_event_kind): Moved here from
2771         break-catch-throw.c.
2772         (catch_exception_event): Declare.
2773         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2774         (mi_cmd_catch_throw): New function.
2775         (mi_cmd_catch_rethrow): New function.
2776         (mi_cmd_catch_catch): New function.
2777         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2778         'catch-catch' entries.
2779         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2780         (mi_cmd_catch_rethrow): Declare.
2781         (mi_cmd_catch_catch): Declare.
2782
2783 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2784
2785         * annotate.c (annotate_source_line): Change return type to void,
2786         update implementation to match.
2787         * annotate.h (annotate_source_line): Change return type to void,
2788         update header comment.
2789         * stack.c (print_frame_info): Don't change what frame information
2790         is printed based on whether annotations are on or not.
2791
2792 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2795         (annotate_source): Make static.
2796         (annotate_source_line): Moved from source.c and renamed from
2797         identify_source_line.  Update the return type.
2798         * annotate.h (annotate_source): Delete declaration.
2799         (annotate_source_line): Declaration moved from source.h, and
2800         renamed from identify_source_line.  Return type updated.
2801         * source.c (identify_source_line): Moved to annotate.c and renamed
2802         to annotate_source_line.
2803         (info_line_command): Remove check of annotation_level.
2804         * source.h (identify_source_line): Move declaration to annotate.h
2805         and rename to annotate_source_line.
2806         * stack.c: Add 'annotate.h' include.
2807         (print_frame_info): Remove check of annotation_level before
2808         calling annotate_source_line.
2809
2810 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * source-cache.c (source_cache::get_plain_source_lines): Use
2813         open_source_file_with_line_charpos instead of just
2814         open_source_file, remove call to find_source_lines.
2815         (source_cache::get_source_lines): Likewise.
2816         * source.c (find_source_lines): Make static.
2817         (get_filename_and_charpos): Renamed into...
2818         (open_source_file_with_line_charpos): ..this along with changes to
2819         return a scoped_fd, and some other minor clean ups.
2820         (identify_source_line): Use open_source_file_with_line_charpos.
2821         (search_command_helper): Use open_source_file_with_line_charpos
2822         instead of just open_source_file, remove call to
2823         find_source_lines.
2824         * source.h (open_source_file_with_line_charpos): Declare new
2825         function.
2826         (find_source_lines): Delete declaration.
2827
2828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * source.c (get_filename_and_charpos): Remove fullname
2831         parameter.
2832         (identify_source_line): Update call to get_filename_and_charpos.
2833
2834 2019-06-14  Tom Tromey  <tromey@adacore.com>
2835
2836         PR gdb/24502:
2837         * ui-style.h (skip_ansi_escape): Update comment.
2838         * ui-file.h (class no_terminal_escape_file): New class.
2839         * ui-file.c (no_terminal_escape_file::write)
2840         (no_terminal_escape_file::puts): New methods.
2841         * cli/cli-logging.c (handle_redirections): Use
2842         no_terminal_escape_file.
2843
2844 2019-06-14  Tom Tromey  <tromey@adacore.com>
2845
2846         * NEWS: Move convenience variable news above Python news.
2847
2848 2019-06-14  Tom Tromey  <tom@tromey.com>
2849
2850         * gnulib: Move directory to top-level.
2851         * configure.ac: Don't configure gnulib.
2852         * configure: Rebuild.
2853         * common/common-defs.h: Use new path to gnulib.
2854         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2855         (GNULIB_H): Remove.
2856         (INCGNU): Look in new gnulib location.
2857         (HFILES_NO_SRCDIR): Remove gnulib files.
2858         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2859         (generated_files): Remove GNULIB_H.
2860         ($(LIBGNU), all-lib): Remove targets.
2861         (distclean): Don't mention GNULIB_BUILDDIR.
2862         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2863
2864 2019-06-14  Tom Tromey  <tromey@adacore.com>
2865
2866         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2867         Warn if symbol file does not provide any symbols.
2868
2869 2019-06-14  Tom Tromey  <tromey@adacore.com>
2870
2871         * source.c (find_and_open_source): Respect basenames_may_differ.
2872
2873 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * annotate.c (annotate_breakpoints_invalid): Make use of
2876         scoped_restore_terminal_state.
2877         (annotate_frames_invalid): Likewise.
2878
2879 2019-06-14  Tom Tromey  <tromey@adacore.com>
2880
2881         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2882         allow assignment to an internalvar.
2883
2884 2019-06-14  Tom Tromey  <tromey@adacore.com>
2885
2886         * ada-lex.l: Allow "_" in attribute names.
2887
2888 2019-06-14  Tom Tromey  <tromey@adacore.com>
2889
2890         PR gdb/24653:
2891         * regcache.c (registers_changed): Don't call alloca.
2892         * top.c (execute_command): Don't call alloca.
2893
2894 2019-06-13  Pedro Alves  <palves@redhat.com>
2895
2896         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2897         'expression'.  When parsing an expression, error out if there's
2898         junk after "unlimited".
2899         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2900         (do_set_command): Adjust calls to is_unlimited_literal.
2901
2902 2019-06-13  Pedro Alves  <palves@redhat.com>
2903
2904         * compile/compile.c (make_compile_options_def_group): Add braces
2905         around array_view initializer.
2906         * thread.c (make_thread_apply_all_options_def_group)
2907         (make_thread_apply_all_options_def_group): Likewise.
2908
2909 2019-06-13  Pedro Alves  <palves@redhat.com>
2910
2911         * NEWS (New commands): Mention "maint test-options
2912         require-delimiter", "maint test-options unknown-is-error", "maint
2913         test-options unknown-is-operand" and "maint show
2914         test-options-completion-result".
2915         (New command options, command completion): New section.
2916         (Completion improvements): New section.
2917         Mention that you can abbreviate "unlimited".
2918
2919 2019-06-13  Pedro Alves  <palves@redhat.com>
2920
2921         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2922         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2923         * unittests/cli-utils-selftests.c (test_parse_flags)
2924         (test_parse_flags_qcs): Delete.
2925         (test_cli_utils): Don't call deleted functions.
2926
2927 2019-06-13  Pedro Alves  <palves@redhat.com>
2928
2929         * thread.c: Include "cli/cli-option.h".
2930         (tp_array_compar_ascending): Global.
2931         (tp_array_compar): Delete function.
2932         (tp_array_compar_ascending, tp_array_compar_descending): New
2933         functions.
2934         (ascending_option_def, qcs_flag_option_def)
2935         (thr_qcs_flags_option_defs)
2936         (make_thread_apply_all_options_def_group)
2937         (make_thread_apply_options_def_group): New.
2938         (thread_apply_all_command): Use gdb::option::process_options.
2939         (thread_apply_command_completer)
2940         (thread_apply_all_command_completer): New.
2941         (thread_apply_command): Use gdb::option::process_options.
2942         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2943         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2944         to generate help text of "thread apply".  Adjust "taas"'s help.
2945         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2946         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2947
2948 2019-06-13  Pedro Alves  <palves@redhat.com>
2949
2950         * thread.c (thread_apply_command): Check for invalid TID with
2951         isdigit instead of !isalpha.
2952
2953 2019-06-13  Pedro Alves  <palves@redhat.com>
2954
2955         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2956         (validate_flags_qcs): New.
2957         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2958         (validate_flags_qcs): Declare.
2959         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2960         (make_frame_apply_options_def_group): New.
2961         (frame_apply_command_count): Process options with
2962         gdb::option::process_options.
2963         (frame_apply_completer): New.
2964         (frame_apply_level_completer, frame_apply_all_completer)
2965         (frame_apply_completer): New.
2966         (_initialize_stack): Update help of "frame apply", "frame apply
2967         level", "frame apply all" and "faas" to mention supported options
2968         and install command completers.
2969         * stack.h (frame_apply_all_completer): Declare.
2970         * thread.c: Include "stack.h".
2971         (tfaas_command): Add "--".
2972         (_initialize_thread): Update help "tfaas" to mention supported
2973         options and install command completer.
2974
2975 2019-06-13  Pedro Alves  <palves@redhat.com>
2976
2977         * completer.c (complete_nested_command_line): New.
2978         (gdb_completion_word_break_characters_throw): Add assertion.
2979         * completer.h (complete_nested_command_line): Declare.
2980
2981 2019-06-13  Pedro Alves  <palves@redhat.com>
2982
2983         * stack.c (parse_backtrace_qualifiers): New.
2984         (backtrace_command): Use it.
2985         (backtrace_command_completer): Complete on qualifiers.
2986
2987 2019-06-13  Pedro Alves  <palves@redhat.com>
2988
2989         * frame.c: Include "cli/cli-option.h.
2990         (user_set_backtrace_options): New.
2991         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2992         Delete.
2993         (get_prev_frame): Adjust.
2994         (boolean_option_def, uinteger_option_def)
2995         (set_backtrace_option_defs): New.
2996         (_initialize_frame): Adjust and use
2997         gdb::option::add_setshow_cmds_for_options to install "set
2998         backtrace past-main" and "set backtrace past-entry".
2999         * frame.h: Include "cli/cli-option.h".
3000         (struct frame_print_options): Forward declare.
3001         (print_frame_arguments_all, print_frame_arguments_scalars)
3002         (print_frame_arguments_none): Declare.
3003         (print_entry_values): Delete declaration.
3004         (struct frame_print_options, user_frame_print_options): New.
3005         (struct set_backtrace_options): New.
3006         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3007         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3008         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3009         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3010         (list_args_or_locals): Add frame_print_options parameter.
3011         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3012         * python/py-framefilter.c (enumerate_args): Pass down
3013         USER_FRAME_PRINT_OPTIONS.
3014         * stack.c: Include "cli/cli-option.h".
3015         (print_frame_arguments_all, print_frame_arguments_scalars)
3016         (print_frame_arguments_none): Declare.
3017         (print_raw_frame_arguments, print_entry_values): Delete.
3018         (user_frame_print_options): New.
3019         (boolean_option_def, enum_option_def, frame_print_option_defs):
3020         New.
3021         (struct backtrace_cmd_options): New.
3022         (bt_flag_option_def): New.
3023         (backtrace_command_option_defs): New.
3024         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3025         (print_frame_arg, read_frame_arg, print_frame_args)
3026         (print_frame_info, print_frame): Add frame_print_options parameter
3027         and use it.
3028         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3029         (backtrace_command_1): Add frame_print_options and
3030         backtrace_cmd_options parameters and use them.
3031         (make_backtrace_options_def_group): New.
3032         (backtrace_command): Process command options with
3033         gdb::option::process_options.
3034         (backtrace_command_completer): New.
3035         (_initialize_stack): Extend "backtrace"'s help to mention
3036         supported options.  Install completer for "backtrace".
3037         Install some settings commands with add_setshow_cmds_for_options.
3038
3039 2019-06-13  Pedro Alves  <palves@redhat.com>
3040
3041         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3042         and that "set/show print raw frame-arguments" are now deprecated.
3043
3044         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3045         command.
3046         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3047         * stack.c (_initialize_stack): Install "set/show print
3048         raw-frame-arguments", and deprecate "set/show print raw
3049         frame-arguments".
3050         * valprint.c (_initialize_valprint): Deprecate "set/show print
3051         raw".
3052
3053 2019-06-13  Pedro Alves  <palves@redhat.com>
3054
3055         * compile/compile.c (struct compile_options): New.
3056         (compile_flag_option_def, compile_command_option_defs)
3057         (make_compile_options_def_group): New.
3058         (compile_file_command): Handle options with
3059         gdb::option::process_options.
3060         (compile_file_command_completer): New function.
3061         (compile_code_command): Handle options with
3062         gdb::option::process_options.
3063         (compile_code_command_completer): New function.
3064         (_initialize_compiler): Install completers for "compile code" and
3065         "compile file".  Mention available options in "compile code" and
3066         "compile code"'s help.
3067         * completer.c (advance_to_completion_word): New, factored out from
3068         ...
3069         (advance_to_expression_complete_word_point): ... this.
3070         (advance_to_filename_complete_word_point): New.
3071         * completer.h (advance_to_filename_complete_word_point): New
3072         declaration.
3073
3074 2019-06-13  Pedro Alves  <palves@redhat.com>
3075
3076         * compile/compile.c: Include "cli/cli-option.h".
3077         (compile_print_value): Scope data pointer is now a
3078         value_print_options pointer; adjust.
3079         (compile_print_command): Process options.  Scope data pointer is
3080         now a value_print_options pointer; adjust.
3081         (_initialize_compile): Update "compile print"'s help to include
3082         supported options.  Install a completer for "compile print".
3083         * cp-valprint.c (show_vtblprint, show_objectprint)
3084         (show_static_field_print): Delete.
3085         (_initialize_cp_valprint): Don't install "set print
3086         static-members", "set print vtbl", "set print object" here.
3087         * printcmd.c: Include "cli/cli-option.h" and
3088         "common/gdb_optional.h".
3089         (print_command_parse_format): Rework to fill in a
3090         value_print_options instead of a format_data.
3091         (print_value): Change parameter type from format_data pointer to
3092         value_print_options reference.  Adjust.
3093         (print_command_1): Process options.  Adjust to pass down a
3094         value_print_options.
3095         (print_command_completer): New.
3096         (_initialize_printcmd): Install print_command_completer as
3097         handle_brkchars completer for the "print" command.  Update
3098         "print"'s help to include supported options.
3099         * valprint.c: Include "cli/cli-option.h".
3100         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3101         here from cp-valprint.c.
3102         (boolean_option_def, uinteger_option_def)
3103         (value_print_option_defs, make_value_print_options_def_group):
3104         New.  Use gdb::option::add_setshow_cmds_for_options to install
3105         "set print elements", "set print null-stop", "set print repeats",
3106         "set print pretty", "set print union", "set print array", "set
3107         print address", "set print symbol", "set print array-indexes".
3108         * valprint.h: Include <string> and "cli/cli-option.h".
3109         (make_value_print_options_def_group): Declare.
3110         (print_value): Change parameter type from format_data pointer to
3111         value_print_options reference.
3112         (print_command_completer): Declare.
3113
3114 2019-06-13  Pedro Alves  <palves@redhat.com>
3115
3116         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3117         (COMMON_SFILES): Add maint-test-settings.c.
3118         * cli/cli-decode.c (boolean_enums): New global, factored out from
3119         ...
3120         (add_setshow_boolean_cmd): ... here.
3121         * cli/cli-decode.h (boolean_enums): Declare.
3122         * cli/cli-option.c: New file.
3123         * cli/cli-option.h: New file.
3124         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3125         factored out from ...
3126         (parse_cli_boolean_value(const char *)): ... this.
3127         (is_unlimited_literal): Change parameter type to pointer to
3128         pointer.  Adjust and advance ARG pointer.
3129         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3130         (parse_cli_var_enum): New, factored out from ...
3131         (do_set_command): ... this.  Adjust.
3132         * cli/cli-setshow.h (parse_cli_boolean_value)
3133         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3134         (parse_cli_var_enum): Declare.
3135         * cli/cli-utils.c: Include "cli/cli-option.h".
3136         (get_ulongest): New.
3137         * cli/cli-utils.h (get_ulongest): Declare.
3138         (check_for_argument): New overloads.
3139         * maint-test-options.c: New file.
3140
3141 2019-06-13  Pedro Alves  <palves@redhat.com>
3142
3143         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3144         parse a range if "-" is at the end of the string.
3145
3146 2019-06-13  Pedro Alves  <palves@redhat.com>
3147
3148         * cli/cli-setshow.c (parse_auto_binary_operation)
3149         (parse_cli_boolean_value): Don't allow "o".
3150
3151 2019-06-13  Pedro Alves  <palves@redhat.com>
3152
3153         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3154         * NEWS: Mention maint test-settings KIND.
3155         * maint-test-settings.c: New file.
3156
3157 2019-06-13  Pedro Alves  <palves@redhat.com>
3158
3159         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3160         completer.
3161         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3162         "set" completers.
3163
3164 2019-06-13  Pedro Alves  <palves@redhat.com>
3165
3166         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3167         after item.
3168
3169 2019-06-13  Pedro Alves  <palves@redhat.com>
3170
3171         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3172
3173 2019-06-13  Pedro Alves <palves@redhat.com>
3174
3175         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3176         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3177         call.
3178         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3179         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3180         calls.
3181         (check_for_argument): Skip spaces after argument.
3182
3183 2019-06-13  Pedro Alves  <palves@redhat.com>
3184
3185         * thread.c (thread_apply_command): Adjust TID parsing.
3186         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3187         detected before end of string.
3188         (tid_is_in_list): Error out if LIST is invalid.
3189
3190 2019-06-13  Pedro Alves  <palves@redhat.com>
3191
3192         * completer.c (complete_line_internal_1): Rewind completion word
3193         point.
3194         (completion_tracker::advance_custom_word_point_by): Change
3195         parameter type to int.
3196         * completer.h (completion_tracker::advance_custom_word_point_by):
3197         Likewise.
3198
3199 2019-06-13  Pedro Alves  <palves@redhat.com>
3200
3201         * completer.c (advance_to_completion_word): Handle delimiters.
3202
3203 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3204
3205         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3206
3207 2019-06-11  Tom Tromey  <tom@tromey.com>
3208
3209         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3210         (xmalloc_failed): Move to alloc.c.
3211         * alloc.c: New file.
3212         * Makefile.in (COMMON_SFILES): Add alloc.c.
3213
3214 2019-06-11  Tom Tromey  <tom@tromey.com>
3215
3216         * nat/linux-waitpid.c: Don't include server.h.
3217         (linux_debug): Remove.
3218         (my_waitpid): Update.
3219
3220 2019-06-11  Tom Tromey  <tromey@adacore.com>
3221
3222         * infcall.c (_initialize_infcall): Remove trailing newline from
3223         help.
3224         * user-regs.c (_initialize_user_regs): Remove trailing newline
3225         from help.
3226         * typeprint.c (_initialize_typeprint): Remove trailing newline
3227         from help.
3228         * reverse.c (_initialize_reverse): Remove trailing newlines from
3229         help.
3230         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3231         from help.
3232         * language.c (add_set_language_command): Remove trailing newline
3233         from help.
3234         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3235         help.
3236         * disasm.c (_initialize_disasm): Remove trailing newline from
3237         help.
3238         * top.c (init_main): Remove trailing newline from help.
3239         * interps.c (_initialize_interpreter): Remove trailing newline
3240         from help.
3241         * btrace.c (_initialize_btrace): Remove trailing newlines from
3242         help.
3243         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3244         from help.
3245         * python/python.c (_initialize_python): Remove trailing newline
3246         from help.
3247         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3248         help.
3249         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3250         from help.  Reformat some text.
3251         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3252         from help.
3253         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3254         newline from help.
3255
3256 2019-06-11  Tom Tromey  <tromey@adacore.com>
3257
3258         * darwin-nat.c (darwin_decode_exception_message)
3259         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3260
3261 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * valops.c (value_slice): Check for not allocated or not
3264         associated values.
3265
3266 2019-06-10  Tom de Vries  <tdevries@suse.de>
3267
3268         PR gdb/24618
3269         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3270         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3271         invalid.
3272
3273 2019-06-10  Tom de Vries  <tdevries@suse.de>
3274
3275         PR gdb/24611
3276         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3277         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3278
3279 2019-06-10  Tom de Vries  <tdevries@suse.de>
3280
3281         PR symtab/24545
3282         * symtab.c (struct demangled_name_entry): Add language field.
3283         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3284         static minimal symbol".  Set and use language field.
3285
3286 2019-06-10  Tom Tromey  <tromey@adacore.com>
3287
3288         * ada-lang.c (_initialize_ada_language): Update help text.
3289
3290 2019-06-10  Tom Tromey  <tromey@adacore.com>
3291
3292         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3293         with a newline.
3294         * guile/guile.c (handle_boot_error): Don't end warning with a
3295         newline.
3296         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3297         warning with a newline.
3298         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3299         newline.
3300         (s12z_frame_cache): Likewise.
3301         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3302         a newline.
3303         * solib-svr4.c (disable_probes_interface): Don't end warning with
3304         a newline.
3305         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3306         newline.
3307         * python/python.c (do_finish_initialization): Don't end warning
3308         with a newline.
3309
3310 2019-06-10  Tom Tromey  <tom@tromey.com>
3311
3312         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3313         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3314         gdbpy_enter.
3315
3316 2019-06-10  Tom Tromey  <tromey@adacore.com>
3317
3318         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3319         data.
3320         (elf_new_init): Don't call stabsread_new_init.
3321         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3322         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3323         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3324
3325 2019-06-10  Tom de Vries  <tdevries@suse.de>
3326
3327         PR symtab/16264
3328         PR symtab/24517
3329         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3330
3331 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3332
3333         * source.c (find_and_open_source): Also rewrite relative file
3334         names.
3335
3336 2019-04-26  Amos Bird  <amosbird@gmail.com>
3337
3338         * annotate.c (annotate_thread_exited): Add "thread-exited"
3339         annotation.
3340
3341 2019-06-06  Tom Tromey  <tromey@adacore.com>
3342
3343         * maint.h (class scoped_command_stats): Use
3344         DISABLE_COPY_AND_ASSIGN.
3345         <print_time>: New method.
3346         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3347         print_time.
3348         (scoped_command_stats::print_time): New method.
3349
3350 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3351
3352         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3353         instructions of lengths 6 or 8 bytes.
3354
3355 2019-06-04  Pedro Alves  <palves@redhat.com>
3356
3357         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3358
3359         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3360         * breakpoint.c (condition_completer): Likewise.
3361         * cli/cli-dump.c (scan_expression): Likewise.
3362         * common/filestuff.c (mkdir_recursive): Likewise.
3363         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3364         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3365         (gdb_abspath): Likewise.
3366         * compile/compile-cplus-types.c
3367         (compile_cplus_instance::decl_name): Likewise.
3368         * completer.c (complete_explicit_location):
3369         (signal_completer, reg_or_group_completer_1): Likewise.
3370         * cp-support.c (cp_remove_params_if_any): Likewise.
3371         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3372         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3373         * infcmd.c (strip_bg_char): Likewise.
3374         * linespec.c (copy_token_string): Likewise.
3375         * mi/mi-main.c (output_cores): Likewise.
3376         * psymtab.c (psymtab_search_name):
3377         * symfile.c (test_set_ext_lang_command): Likewise.
3378         * target.c (target_fileio_read_stralloc): Likewise.
3379         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3380         * value.c (complete_internalvar): Likewise.
3381
3382 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3383
3384         Add objfile property to gdb.Type.
3385         * NEWS: Mention Python API addition.
3386         * python/py-type.c (typy_get_objfile): New method.
3387
3388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3389
3390         * NEWS: Mention the new set|show style [title|highlight].
3391         Mention changes to "show style", "help" and "apropos".
3392
3393 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3394
3395         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3396         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3397         instead of print_help_for_command.
3398         (print_doc_of_command): New function.
3399         (help_list): Add 'apropos -v word' suggestion.
3400         (print_help_for_command): Style the command name using title style.
3401         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3402         (_initialize_cli_cmds): Describe -v in apropos_command help.
3403
3404 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3405
3406         * cli/cli-style.h (cli_style_option): Add name in constructor,
3407         add m_name class member, add constructor with intensity,
3408         add name class function.
3409         (cli_style_option::add_setshow_commands): Remove name argument.
3410         (highlight_style, title_style): New styles.
3411         * cli/cli-style.c (do_show): New function that shows a style
3412         characteristic styling the style name with itself.
3413         (set_style_name): New function.
3414         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3415         Update all callers according to the changes in cli/cli-style.h.
3416         * utils.h (fputs_highlighted): New function.
3417         * utils.c (fputs_highlighted): Likewise.
3418
3419 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3420
3421         * NEWS: Mention new pipe command and new convenience variables.
3422
3423 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3424
3425         * cli/cli-cmds.c (pipe_command): New function.
3426         (_initialize_cli_cmds): Call add_com for pipe_command.
3427         Define | as an alias for pipe.
3428         (exit_status_set_internal_vars): New function.
3429         (shell_escape): Call exit_status_set_internal_vars.
3430         cli/cli-decode.c (find_command_name_length): Recognize | as
3431         a single character command.
3432
3433 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3434
3435         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3436         top.c (execute_command_to_ui_file): New function, mostly a copy
3437         of execute_command_to_string.
3438         (execute_command_to_string): Implement by calling
3439         execute_command_to_ui_file.
3440
3441 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3442
3443         * top.h (saved_command_line): Remove declaration.
3444         * top.c (previous_saved_command_line, previous_repeat_arguments):
3445         New variables.
3446         (saved_command_line): Make static, define together with other
3447         'repeat variables'.
3448         (dont_repeat): Clear repeat_arguments.
3449         (repeat_previous, get_saved_command_line, save_command_line):
3450         New functions.
3451         (gdb_init): Initialize saved_command_line
3452         and previous_saved_command_line.
3453         * main.c (captured_main_1): Remove saved_command_line initialization.
3454         * event-top.c (handle_line_of_input): Update to use
3455         the new 'repeat' related functions instead of direct access to
3456         saved_command_line.
3457         * command.h (repeat_previous, get_saved_command_line,
3458         save_command_line): New declarations.
3459         (dont_repeat): Add comment.
3460
3461 2019-05-30  Tom Tromey  <tromey@adacore.com>
3462
3463         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3464         Fix comment.
3465         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3466
3467 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3468
3469         PR cli/24587
3470         * completer.c (complete): Initialize variable word.
3471
3472 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3473
3474         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3475         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3476         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3477         'body' is NULL to the outter 'if', protecting the '!is_define'
3478         situation as well.
3479
3480 2019-05-29  Tom Tromey  <tromey@adacore.com>
3481
3482         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3483         (dwarf_unknown): New function.
3484         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3485         (dwarf_type_encoding_name): Use dwarf_unknown.
3486
3487 2019-05-29  Tom Tromey  <tromey@adacore.com>
3488
3489         PR c++/20020:
3490         * cp-valprint.c (cp_print_value_fields): Call
3491         cp_print_static_field inside "try".
3492
3493 2019-05-29  Tom Tromey  <tromey@adacore.com>
3494
3495         * inflow.c (struct terminal_info): Add default operator=.
3496         * configure: Rebuild.
3497         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3498         -Wdeprecated-copy-dtor, -Wredundant-move.
3499
3500 2019-05-29  Tom Tromey  <tromey@adacore.com>
3501
3502         * NEWS: Add entry.
3503         * infcmd.c (print_return_value_1): Handle finish_print
3504         option.
3505         (show_print_finish): New function.
3506         (_initialize_infcmd): Add "set/show print finish" commands.
3507         * valprint.c (user_print_options): Initialize new member.
3508         * valprint.h (struct value_print_options) <finish_print>: New
3509         member.
3510
3511 2019-05-28  Tom Tromey  <tromey@adacore.com>
3512
3513         * ada-lang.c (ada_remove_Xbn_suffix)
3514         (find_old_style_renaming_symbol)
3515         (parse_old_style_renaming): Remove.
3516         (ada_find_renaming_symbol): Don't call
3517         find_old_style_renaming_symbol.
3518         (ada_is_renaming_symbol): Rename from
3519         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3520         bool.  Now static.
3521         (ada_read_var_value): Update and simplify.
3522         * ada-exp.y (write_var_or_type): Remove old code.
3523
3524 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3525
3526         * event-top.c: Remove include comment.
3527         * inflow.c (class scoped_ignore_sigttou): Move from here...
3528         * inflow.h (class scoped_ignore_sigttou): ...to here.
3529         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3530         * top.c:  Remove include comment.
3531
3532 2019-05-27  Tom Tromey  <tom@tromey.com>
3533
3534         * NEWS: Fix typo.
3535
3536 2019-05-22  Tom Tromey  <tromey@adacore.com>
3537
3538         * target.c (target_follow_exec): Constify parameter.
3539         * target-delegates.c: Rebuild.
3540         * remote.c (remote_target::follow_exec): Constify parameter.
3541         * infrun.c (follow_exec): Constify parameter.
3542         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3543         (target_follow_exec): Likewise.
3544
3545 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3546
3547         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3548         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3549
3550 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3551
3552         * NEWS: Add debugredirect and testsuite sections.
3553
3554 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3555
3556         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3557         target descriptions using exclusively floating point register name
3558         aliases.
3559
3560 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3561
3562         PR gdb/18644:
3563         * f-lang.c (build_fortran_types): Handle the case where
3564         gdbarch_floatformat_for_type returns a nullptr.
3565
3566 2019-05-21  Tom de Vries  <tdevries@suse.de>
3567
3568         PR cli/24587
3569         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3570
3571 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3572
3573         PR gdb/18644:
3574         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3575         16-byte floats.
3576         * i386-tdep.c (i386_floatformat_for_type): Use
3577         floatformats_ia64_quad for the 16-byte floating point component
3578         within a fortran 32-byte complex number.
3579
3580 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3581
3582         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3583         delete default constructor.
3584         (find_partial_die): Update to return const struct.
3585         (partial_die_parent_scope): Move variable declaration into scope
3586         of its use and change its type to auto.
3587         (guess_partial_die_structure_name): Likewise.
3588         (partial_die_info::fixup): Likewise.
3589
3590 2019-05-17  Tom Tromey  <tromey@adacore.com>
3591
3592         * source.c (find_and_open_source): Remove cast.
3593
3594 2019-05-17  Tom Tromey  <tromey@adacore.com>
3595
3596         * annotate.c (annotate_source): Make "filename" const.
3597         * annotate.h (annotate_source): Use const.
3598
3599 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3600
3601         * disasm.c (set_disassembler_options): Send errors to stderr.
3602
3603 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3604
3605         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3606         (cli_interp_base::set_logging): Check debug_redirect.
3607         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3608         * cli/cli-logging.c (debug_redirect): Add static variable.
3609         (pop_output_files): Add default param.
3610         (handle_redirections): Print debug setting.
3611         (show_logging_command): Likewise.
3612         (_initialize_cli_logging): Add debugredirect command.
3613         * interps.c (current_interp_set_logging): Add debug_redirect
3614         parameter.
3615         * interps.h (set_logging): Add debug_redirect parameter.
3616         (current_interp_set_logging): Likewise.
3617         * mi/mi-common.h: Likewise.
3618         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3619
3620 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3621             Tom Tromey  <tromey@adacore.com>
3622
3623         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3624         directly.
3625         * cli/cli-interp.h (make_logging_output): Remove declaration.
3626         * cli/cli-logging.c (make_logging_output): Remove function.
3627         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3628         directly.
3629         * ui-file.c (tee_file::tee_file): Remove bools.
3630         (tee_file::~tee_file): Remove deletes.
3631         * ui-file.h (tee_file): Remove bools.
3632
3633 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3634
3635         * mi/mi-cmds.h (mi_cmd_complete): New function.
3636         * mi/mi-main.c (mi_cmd_complete): Likewise.
3637         * mi/mi-cmds.c: Define new MI command -complete.
3638         * NEWS: Mention new -complete command.
3639
3640 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3641
3642         * completer.h (complete): New function.
3643         * completer.c (complete): Likewise.
3644         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3645         function defined in completer.h.
3646
3647 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3648
3649         * MAINTAINERS (Write After Approval): Add myself.
3650
3651 2019-05-17  Tom de Vries  <tdevries@suse.de>
3652
3653         PR gdb/24094
3654         * dwarf2read.c (struct cu_partial_die_info): New struct.
3655         (find_partial_die): Return cu_partial_die_info.
3656         (partial_die_parent_scope, guess_partial_die_structure_name)
3657         (partial_die_info::fixup): Handle new return type of find_partial_die.
3658
3659 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3660
3661         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3662         "std::string", simplifying the algorithm.
3663
3664 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3665
3666         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3667         (stap_static_probe_ops::get_probes): Likewise.
3668
3669 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3670
3671         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3672         '-')" and "else if".
3673         (stap_parse_single_operand): Join checks for
3674         "gdbarch_stap_parse_special_token_p" and
3675         "gdbarch_stap_parse_special_token" in the same "if" statement.
3676         Invert check when verifying for operation on register
3677         displacement.
3678
3679 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3680
3681         * stap-probe.c (stap_get_opcode): Update comment.
3682         (stap_get_expected_argument_type): Likewise.
3683         (handle_stap_probe): Likewise.
3684
3685 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3686
3687         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3688         return type to 'bool'.  Adjust comment.  Use 'bool' when
3689         appropriate.
3690         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3691         * stap-probe.c (stap_parse_argument_1): Likewise.
3692         (stap_is_operator): Likewise.
3693         (stap_is_generic_prefix): Likewise.
3694         (stap_is_register_prefix): Likewise.
3695         (stap_is_register_indirection_prefix): Likewise.
3696         (stap_is_integer_prefix): Likewise.
3697         (stap_generic_check_suffix): Likewise.
3698         (stap_check_integer_suffix): Likewise.
3699         (stap_check_register_suffix): Likewise.
3700         (stap_check_register_indirection_suffix): Likewise.
3701         (stap_parse_register_operand): Likewise.
3702         (stap_parse_single_operand): Likewise.
3703         (stap_parse_argument_1): Likewise.
3704         (stap_probe::get_argument_count): Likewise.
3705         (stap_is_operator): Likewise.
3706
3707 2019-05-16  Tom Tromey  <tromey@adacore.com>
3708
3709         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3710         keyword to foreach.
3711
3712 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3713
3714         * linux-thread-db.c (try_thread_db_load_1): Change return type
3715         to bool.
3716         (try_thread_db_load): Likewise.
3717         (try_thread_db_load_from_pdir_1): Likewise.
3718         (try_thread_db_load_from_pdir): Likewise.
3719         (try_thread_db_load_from_sdir): Likewise.
3720         (try_thread_db_load_from_dir): Likewise.
3721         (thread_db_load_search): Likewise.
3722         (has_libpthread): Likewise.
3723         (thread_db_load): Likewise.
3724
3725 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3726
3727         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3728         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3729         NULL, and complain/return if that's the case.
3730
3731 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3732
3733         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3734         (advance, posn, abstract_read_memory): New functions.
3735         [struct mem_read_abstraction]: New struct.
3736         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3737
3738 2019-05-14  Tom Tromey  <tromey@adacore.com>
3739
3740         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3741         value is not lval_memory.
3742
3743 2019-05-14  Tom Tromey  <tromey@adacore.com>
3744
3745         * solib.c (info_sharedlibrary_command): Style the file name.
3746
3747 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3748
3749         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3750         (aarch64_vnv_type): Likewise.
3751         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3752         * common/tdesc.c: Likewise.
3753         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3754         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3755         * features/aarch64-fpu.xml: Add ieee half view.
3756         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3757         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3758         * gdbtypes.h (struct builtin_type): Likewise.
3759         (struct objfile_type): Likewise.
3760
3761 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3762
3763         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3764         typo.
3765         * location.h (string_to_event_location): Likewise.
3766
3767 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3768
3769         GDB 8.3 released.
3770
3771 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3772
3773         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3774         New variable declaration.
3775         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3776         New variable.
3777         (print_one_breakpoint): Use ui_out::test_flags and new global
3778         variable to compute use_fixed_output.
3779         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3780         Remove.
3781         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3782         (mi_multi_location_breakpoint_output_fixed): Remove.
3783         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3784         new variable.
3785         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3786         fix_multi_location_breakpoint_output flag if version >= 3.
3787         * ui-out.h (enum ui_out_flag)
3788         <fix_multi_location_breakpoint_output>: New enumerator.
3789
3790 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3791
3792         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3793
3794 2019-05-10  Tom Tromey  <tromey@adacore.com>
3795
3796         * ada-lang.c (catch_ada_completer): New function.
3797         (_initialize_ada_language): Use it.
3798
3799 2019-05-10  Tom Tromey  <tromey@adacore.com>
3800
3801         * thread.c (print_thread_info): Make "requested_threads" const.
3802         * gdbthread.h (print_thread_info): Make "requested_threads"
3803         const.
3804         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3805         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3806
3807 2019-05-08  Tom Tromey  <tom@tromey.com>
3808
3809         * gdbtypes.c (objfile_type_data): Change type.
3810         (objfile_type, _initialize_gdbtypes): Update.
3811
3812 2019-05-08  Tom Tromey  <tom@tromey.com>
3813
3814         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3815         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3816         (_initialize_dwarf2_frame): Update.
3817
3818 2019-05-08  Tom Tromey  <tom@tromey.com>
3819
3820         * objc-lang.c (objc_objfile_data): Change type.
3821         (find_methods): Update.
3822         (_initialize_objc_lang): Remove.
3823
3824 2019-05-08  Tom Tromey  <tom@tromey.com>
3825
3826         * stabsread.c (rs6000_builtin_type_data): Change type.
3827         (rs6000_builtin_type, _initialize_stabsread): Update.
3828
3829 2019-05-08  Tom Tromey  <tom@tromey.com>
3830
3831         * mips-tdep.c (mips_pdr_data): Remove.
3832         (_initialize_mips_tdep): Update.
3833
3834 2019-05-08  Tom Tromey  <tom@tromey.com>
3835
3836         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3837         (hppa_init_objfile_priv_data, read_unwind_info)
3838         (find_unwind_entry, _initialize_hppa_tdep): Update.
3839
3840 2019-05-08  Tom Tromey  <tom@tromey.com>
3841
3842         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3843         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3844         on obstack.
3845         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3846
3847 2019-05-08  Tom Tromey  <tom@tromey.com>
3848
3849         * mdebugread.c (basic_type_data): Change type.
3850         (basic_type, _initialize_mdebugread): Update.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3855
3856 2019-05-08  Tom Tromey  <tom@tromey.com>
3857
3858         * nto-tdep.c (nto_inferior_data_reg): Change type.
3859         (nto_inferior_data): Update.
3860         (nto_inferior_data_cleanup, nto_new_inferior_data)
3861         (_initialize_nto_tdep): Remove.
3862         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3863
3864 2019-05-08  Tom Tromey  <tom@tromey.com>
3865
3866         * ada-lang.c (struct ada_inferior_data): Add initializers.
3867         (ada_inferior_data): Change type.
3868         (ada_inferior_data_cleanup): Remove.
3869         (get_ada_inferior_data, ada_inferior_exit)
3870         (struct ada_pspace_data): Add initializers, destructor.
3871         (ada_pspace_data_handle): Change type.
3872         (get_ada_pspace_data): Update.
3873         (ada_pspace_data_cleanup): Remove.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * coffread.c (struct coff_symfile_info): Add initializers.
3878         (coff_objfile_data_key): Move lower.  Change type.
3879         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3880         Update.
3881         (coff_free_info): Remove.
3882
3883 2019-05-08  Tom Tromey  <tom@tromey.com>
3884
3885         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3886         (fbsd_pspace_data_handle): Move lower.  Change type.
3887         (get_fbsd_pspace_data): Update.
3888         (fbsd_pspace_data_cleanup): Remove.
3889         (_initialize_fbsd_tdep): Update.
3890
3891 2019-05-08  Tom Tromey  <tom@tromey.com>
3892
3893         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3894         (get_ada_tasks_pspace_data): Update.
3895         (ada_tasks_pspace_data_cleanup): Remove.
3896         (_initialize_tasks): Update.
3897         (ada_tasks_inferior_data_handle): Change type.
3898         (get_ada_tasks_inferior_data): Update.
3899         (ada_tasks_inferior_data_cleanup): Remove.
3900         (struct ada_tasks_pspace_data): Add initializers.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3905         * symfile-debug.c (debug_sym_get_probes): Change type.
3906         * stap-probe.c (handle_stap_probe):
3907         (stap_static_probe_ops::get_probes): Change type.
3908         * probe.h (class static_probe_ops) <get_probes>: Change type.
3909         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3910         (parse_probes_in_pspace): Update.
3911         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3912         Update.
3913         (any_static_probe_ops::get_probes): Change type.
3914         * elfread.c (elfread_data): New typedef.
3915         (probe_key): Change type.
3916         (elf_get_probes): Likewise.  Update.
3917         (probe_key_free): Remove.
3918         (_initialize_elfread): Update.
3919         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3920         Change type.
3921         (dtrace_process_dof_probe, dtrace_process_dof)
3922         (dtrace_static_probe_ops::get_probe): Change type.
3923
3924 2019-05-08  Tom Tromey  <tom@tromey.com>
3925
3926         * xcoffread.c (struct xcoff_symfile_info): Rename from
3927         coff_symfile_info.  Add initializers.
3928         (xcoff_objfile_data_key): Move lower.  Change type.
3929         (XCOFF_DATA): Rewrite.
3930         (xcoff_free_info): Remove.
3931         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3932         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3933         (xcoff_initial_scan): Update.
3934
3935 2019-05-08  Tom Tromey  <tom@tromey.com>
3936
3937         * solib-svr4.c (struct svr4_info): Add initializers and
3938         destructor.
3939         <probes_table>: Now an htab_up.
3940         (solib_svr4_pspace_data): Change type.
3941         (free_probes_table): Simplify.
3942         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3943         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3944         (probes_table_remove_objfile_probes, register_solib_event_probe)
3945         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3946         (_initialize_svr4_solib): Update.
3947
3948 2019-05-08  Tom Tromey  <tom@tromey.com>
3949
3950         * remote.c (remote_pspace_data): Change type.
3951         (remote_pspace_data_cleanup): Remove.
3952         (get_remote_exec_file, set_pspace_remote_exec_file)
3953         (_initialize_remote): Update.
3954
3955 2019-05-08  Tom Tromey  <tom@tromey.com>
3956
3957         * breakpoint.c (breakpoint_objfile_key): Change type.
3958         (get_breakpoint_objfile_data): Update.
3959         (free_breakpoint_objfile_data): Remove.
3960         (_initialize_breakpoint): Update.
3961
3962 2019-05-08  Tom Tromey  <tom@tromey.com>
3963
3964         * linux-tdep.c (struct linux_info): Add initializers.
3965         (linux_inferior_data): Move.  Change type.
3966         (invalidate_linux_cache_inf): Update.
3967         (linux_inferior_data_cleanup): Remove.
3968         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3969
3970 2019-05-08  Tom Tromey  <tom@tromey.com>
3971
3972         * auxv.c (auxv_inferior_data): Move.  Change type.
3973         (auxv_inferior_data_cleanup): Remove.
3974         (invalidate_auxv_cache_inf): Rewrite.
3975         (get_auxv_inferior_data, _initialize_auxv): Update.
3976
3977 2019-05-08  Tom Tromey  <tom@tromey.com>
3978
3979         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3980         (symfile_debug_objfile_data_key): Change type.
3981         (symfile_debug_installed, debug_qf_has_symbols)
3982         (debug_qf_find_last_source_symtab)
3983         (debug_qf_forget_cached_source_info)
3984         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3985         (debug_qf_print_stats, debug_qf_dump)
3986         (debug_qf_expand_symtabs_for_function)
3987         (debug_qf_expand_all_symtabs)
3988         (debug_qf_expand_symtabs_with_fullname)
3989         (debug_qf_map_matching_symbols)
3990         (debug_qf_expand_symtabs_matching)
3991         (debug_qf_find_pc_sect_compunit_symtab)
3992         (debug_qf_map_symbol_filenames)
3993         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3994         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3995         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3996         (debug_sym_read_linetable, debug_sym_relocate): Update.
3997         (symfile_debug_free_objfile): Remove.
3998         (install_symfile_debug_logging, _initialize_symfile_debug):
3999         Update.
4000
4001 2019-05-08  Tom Tromey  <tom@tromey.com>
4002
4003         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4004         allocate_on_obstack.
4005         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4006         (get_dwarf2_per_objfile): Update.
4007         (set_dwarf2_per_objfile): Remove.
4008         (dwarf2_has_info, dwarf2_get_section_info): Update.
4009         (dwarf2_free_objfile): Remove.
4010         (_initialize_dwarf2_read): Update.
4011
4012 2019-05-08  Tom Tromey  <tom@tromey.com>
4013
4014         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4015         initializers.
4016         <unsupported_script_warning_printed,
4017         script_not_found_warning_printed>: Now bool.
4018         (auto_load_pspace_data): Change type.
4019         (~auto_load_pspace_info): Rename from
4020         auto_load_pspace_data_cleanup.
4021         (get_auto_load_pspace_data, init_loaded_scripts_info)
4022         (clear_section_scripts, maybe_print_unsupported_script_warning)
4023         (maybe_print_script_not_found_warning, _initialize_auto_load):
4024         Update.
4025
4026 2019-05-08  Tom Tromey  <tom@tromey.com>
4027
4028         * objfiles.c (objfile_pspace_info): Add destructor and
4029         initializers.
4030         (objfiles_pspace_data): Change type.
4031         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4032         (get_objfile_pspace_data): Update.
4033         (objfiles_bfd_data): Change type.
4034         (get_objfile_bfd_data): Update.
4035         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4036
4037 2019-05-08  Tom Tromey  <tom@tromey.com>
4038
4039         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4040         Change type.
4041         (get_catch_syscall_inferior_data): Update.
4042         (catch_syscall_inferior_data_cleanup): Remove.
4043         (_initialize_break_catch_syscall): Update.
4044
4045 2019-05-08  Tom Tromey  <tom@tromey.com>
4046
4047         * inflow.c (struct terminal_info): Add destructor and
4048         initializers.
4049         (inflow_inferior_data): Change type.
4050         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4051         (get_inflow_inferior_data, inflow_inferior_exit)
4052         (swap_terminal_info, _initialize_inflow): Update.
4053
4054 2019-05-08  Tom Tromey  <tom@tromey.com>
4055
4056         * target-dcache.c (target_dcache_cleanup): Remove.
4057         (target_dcache_aspace_key): Change type.
4058         (target_dcache_init_p, target_dcache_invalidate)
4059         (target_dcache_get, target_dcache_get_or_init)
4060         (_initialize_target_dcache): Update.
4061         * dcache.h (struct dcache_deleter): New.
4062
4063 2019-05-08  Tom Tromey  <tom@tromey.com>
4064
4065         * symtab.c (struct symbol_cache): Add destructor and
4066         initializers.
4067         (symbol_cache_key): Move.  Change type.
4068         (make_symbol_cache, free_symbol_cache): Remove.
4069         (get_symbol_cache): Update.
4070         (symbol_cache_cleanup): Remove.
4071         (ALL_PSPACES, symbol_cache_flush)
4072         (maintenance_print_symbol_cache)
4073         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4074         Update.
4075
4076 2019-05-08  Tom Tromey  <tom@tromey.com>
4077
4078         * symtab.c (struct main_info): Add destructor and initializers.
4079         (main_progspace_key): Move.  Change type.
4080         (get_main_info): Update.
4081         (main_info_cleanup): Remove.
4082         (_initialize_symtab): Update.
4083
4084 2019-05-08  Tom Tromey  <tom@tromey.com>
4085
4086         * registry.h (DECLARE_REGISTRY): Define the _key class.
4087
4088 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * NEWS: Merge two 'New commands' sections.
4091
4092 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4093
4094         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4095         parameter and use Ada language definition instead.
4096         (ada_val_print_ptr): Remove unused language parameter.
4097         (ada_val_print_num): Remove language parameter and use Ada language
4098         definition instead.
4099         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4100         parameter.
4101         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4102         parameter and use Ada language definition instead.
4103         (ada_val_print_1): Update all ada_val_print_xxx calls.
4104         Remove language parameter.
4105         (ada_val_print): Update ada_val_print_1 call.
4106
4107 2019-05-08  Tom Tromey  <tromey@adacore.com>
4108
4109         * remote.c (remote_hw_watchpoint_limit)
4110         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4111         Now static.
4112
4113 2019-05-08  Tom Tromey  <tromey@adacore.com>
4114
4115         * maint.c (_initialize_maint_cmds): Move initialization code to
4116         remote.c.
4117         (watchdog, show_watchdog): Move to remote.c.
4118         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4119         "watchdog" static.
4120         (_initialize_remote): Move initialization code from maint.c.
4121         * defs.h (watchdog): Don't declare.
4122
4123 2019-05-08  Tom Tromey  <tromey@adacore.com>
4124
4125         * tui/tui-interp.c: Include main.h.
4126         * interps.c: Include main.h.
4127         * main.h (interpreter_p): Declare.
4128         * defs.h (interpreter_p): Don't declare.
4129
4130 2019-05-08  Tom Tromey  <tromey@adacore.com>
4131
4132         * dwarf2loc.c: Include dwarf2read.h.
4133         * defs.h (read_unsigned_leb128): Don't declare.
4134         * dwarf2read.h (read_unsigned_leb128): Declare.
4135
4136 2019-05-08  Tom Tromey  <tromey@adacore.com>
4137
4138         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4139         method.
4140
4141 2019-05-08  Tom Tromey  <tromey@adacore.com>
4142
4143         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4144         when no wrap column is set.
4145
4146 2019-05-08  Tom Tromey  <tromey@adacore.com>
4147
4148         * c-lang.c (c_get_string): Handle non-C-style arrays.
4149
4150 2019-05-08  Tom Tromey  <tromey@adacore.com>
4151
4152         * typeprint.c (print_offset_data::update): Print the bit offset,
4153         not the number of bits remaining.
4154
4155 2019-05-08  Tom Tromey  <tromey@adacore.com>
4156
4157         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4158         padding at end of comment.
4159
4160 2019-05-08  Tom Tromey  <tromey@adacore.com>
4161
4162         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4163         Compare main types.
4164
4165 2019-05-06  Tom Tromey  <tom@tromey.com>
4166
4167         * common/scoped_mmap.c: Include common-defs.h.
4168         * common/scoped_mmap.h: Don't include config.h.
4169
4170 2019-05-04  Tom Tromey  <tom@tromey.com>
4171
4172         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4173         (struct aarch64_call_info): Add initializers.
4174         <si>: Now a std::vector.
4175         (pass_on_stack, aarch64_push_dummy_call): Update.
4176
4177 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4178             Tom Tromey  <tom@tromey.com>
4179
4180         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4181         (ppc_threads): Now a std::vector.  Now static.
4182         (hwdebug_find_thread_points_by_tid)
4183         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4184         Update.
4185
4186 2019-05-04  Tom Tromey  <tom@tromey.com>
4187
4188         * arc-tdep.c (arc_tdesc_init): Return bool.
4189
4190 2019-05-04  Tom Tromey  <tom@tromey.com>
4191
4192         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4193         Use gdb_assert_not_reached.
4194
4195 2019-05-04  Tom Tromey  <tom@tromey.com>
4196
4197         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4198         "false".
4199
4200 2019-05-04  Tom Tromey  <tom@tromey.com>
4201
4202         * arc-tdep.c (arc_tdesc_init): Use bool.
4203
4204 2019-05-04  Tom Tromey  <tom@tromey.com>
4205
4206         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4207
4208 2019-05-04  Tom Tromey  <tom@tromey.com>
4209
4210         * cli/cli-cmds.c (valid_command_p): Return bool.
4211
4212 2019-05-04  Tom Tromey  <tom@tromey.com>
4213
4214         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4215         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4216
4217 2019-05-04  Raul Tambre  <raul@tambre.ee>
4218
4219         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4220         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4221         operator for comparison.
4222
4223 2019-05-04  Tom Tromey  <tom@tromey.com>
4224
4225         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4226         (lookup_partial_symbol, print_partial_symbols)
4227         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4228         (psymbol_compare): Update.
4229         (add_psymbol_to_bcache): Clear the entire psymbol.
4230         (maintenance_check_psymtabs): Update.
4231         * psympriv.h (struct partial_symbol): Don't derive from
4232         general_symbol_info.
4233         <obj_section, unrelocated_address, address,
4234         set_unrelocated_address>: Update.
4235         <ginfo>: New member.
4236         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4237         (debug_names::write_psymbols): Update.
4238
4239 2019-05-04  Tom de Vries  <tdevries@suse.de>
4240
4241         * contrib/cc-with-tweaks.sh: Support -n arg.
4242
4243 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4244
4245         * corelow.c (core_target::detach): Ensure frame cache and
4246         register caches are cleared.
4247         inferior.c (exit_inferior_1): Likewise.
4248
4249 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4250             Tom Tromey  <tom@tromey.com>
4251
4252         * dictionary.c (collate_pending_symbols_by_language): Remove
4253         "struct" from foreach.
4254         * symtab.c (lookup_global_symbol_from_objfile)
4255         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4256         foreach.
4257         * ser-tcp.c (net_open): Remove "struct" from foreach.
4258         * objfiles.c (objfile_relocate, objfile_rebase)
4259         (objfile_has_symbols): Remove "struct" from foreach.
4260         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4261         from foreach.
4262         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4263         foreach.
4264         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4265         "struct" from foreach.
4266         * ada-lang.c (create_excep_cond_exprs)
4267         (ada_exception_catchpoint_cond_string): Remove "struct" from
4268         foreach.
4269
4270 2019-05-03  Tom Tromey  <tromey@adacore.com>
4271
4272         * ada-exp.y (convert_char_literal): Check suffix of each
4273         enumerator.
4274
4275 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4276
4277         PR ada/21406:
4278         * ada-exp.y (yywrap): Don't define.
4279         * ada-lex.l (%option): Add noyywrap
4280         (yywrap): Remove.
4281
4282 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4283
4284         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4285         _WIN32_WINNT to the XP level, unless already defined to a higher
4286         level.
4287
4288         * unittests/parse-connection-spec-selftests.c:
4289         * ser-tcp.c:
4290         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4291         override.
4292
4293         * symfile.c (find_separate_debug_file): Remove colon from the
4294         drive spec of DOS/Windows file names of the target, so that the
4295         file name produced from DEBUGDIR and the target's directory will
4296         be valid on DOS/Windows systems.
4297
4298 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * rust-lang.c (val_print_struct): Handle printing structures
4301         containing strings.
4302
4303 2019-05-02  Tom Tromey  <tromey@adacore.com>
4304
4305         * valarith.c (_initialize_valarith): Remove.
4306
4307 2019-05-01  Tom Tromey  <tromey@adacore.com>
4308
4309         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4310         bitfields.
4311
4312 2019-05-01  Tom Tromey  <tromey@adacore.com>
4313
4314         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4315         for big-endian copies.
4316
4317 2019-04-30  Ali Tamur  <tamur@google.com>
4318         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4319         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4320         (read_3_bytes): New function.
4321
4322 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4323
4324         * windows-nat.c (main_thread_id): Delete.
4325         (handle_output_debug_string): Replace main_thread_id by
4326         current_event.dwThreadId.
4327         (fake_create_process): Likewise.
4328         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4329         Do not set main_thread_id.
4330         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4331         current_event.dwThreadId.
4332         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4333
4334 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4335
4336         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4337         Use current_event.dwThreadId instead of main_thread_id.
4338
4339 2019-04-30  Tom Tromey  <tromey@adacore.com>
4340
4341         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4342         (create_excep_cond_exprs): Iterate over program spaces.
4343         (ada_exception_catchpoint_cond_string): Examine all minimal
4344         symbols for exception types.
4345
4346 2019-04-30  Tom Tromey  <tromey@adacore.com>
4347
4348         PR c++/24470:
4349         * dwarf2read.c (process_structure_scope): Handle case where type
4350         has template parameters but no symbol was created.
4351
4352 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4353             Chris January  <chris.january@arm.com>
4354
4355         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4356         qualifier.
4357         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4358
4359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * f-typeprint.c (f_print_type): Update rules for printing
4362         whitespace.
4363         (f_type_print_varspec_suffix): Likewise.
4364
4365 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4366             Chris January  <chris.january@arm.com>
4367
4368         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4369         function arguments.
4370
4371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4372
4373         * f-lang.c (build_fortran_types): Change name of void type to
4374         lower case.
4375         * f-typeprint.c (f_type_print_base): Print the name of the void
4376         type, rather than a fixed string.
4377         * f-valprint.c (f_decorations): Use lower case void string.
4378
4379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4380             Chris January  <chris.january@arm.com>
4381
4382         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4383         types for Fortran.
4384
4385 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4386             Chris January  <chris.january@arm.com>
4387             David Lecomber  <david.lecomber@arm.com>
4388
4389         * f-exp.y (BINOP_INTRINSIC): New token.
4390         (exp): New parser rule handling BINOP_INTRINSIC.
4391         (f77_keywords): Add new builtin procedures.
4392         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4393         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4394         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4395         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4396         (print_unop_subexp_f): New function.
4397         (print_binop_subexp_f): New function.
4398         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4399         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4400         (dump_subexp_body_f): Likewise.
4401         (operator_check_f): Likewise.
4402         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4403         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4404
4405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4408         UNOP_KIND.
4409         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4410         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4411         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4412         (operator_length_f): New fuction.
4413         (print_subexp_f): New function.
4414         (op_name_f): New function.
4415         (dump_subexp_body_f): New function.
4416         (operator_check_f): New function.
4417         (exp_descriptor_f): Replace standard expression handling functions
4418         with new functions.
4419         * gdb/fortran-operator.def: New file.
4420         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4421         * gdb/std-operator.def: Remove UNOP_KIND.
4422
4423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4424
4425         * std-operator.def: Remove unbalanced, stray double quote
4426         character.
4427
4428 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4429             Chris January  <chris.january@arm.com>
4430             Daniel Everett  <daniel.everett@arm.com>
4431             Nick Forrington  <nick.forrington@arm.com>
4432             Richard Bunt  <richard.bunt@arm.com>
4433
4434         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4435         of depth when printing anonymous structs or unions.
4436         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4437         Don't print either the top-level value, or the children if the
4438         max-depth is exceeded.
4439         (ppscm_print_children): When printing the key of a map, allow one
4440         extra level of depth.
4441         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4442         print either the top-level value, or the children if the max-depth
4443         is exceeded.
4444         (print_children): When printing the key of a map, allow one extra
4445         level of depth.
4446         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4447         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4448         (user_print_options): Initialise max_depth field.
4449         (val_print_scalar_or_string_type_p): New function.
4450         (val_print): Check to see if the max depth has been reached.
4451         (val_print_check_max_depth): Define new function.
4452         (show_print_max_depth): New function.
4453         (_initialize_valprint): Add 'print max-depth' option.
4454         * valprint.h (struct value_print_options) <max_depth>: New field.
4455         (val_print_check_max_depth): Declare new function.
4456         * NEWS: Document new feature.
4457
4458 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4459
4460         * ada-lang.c (ada_language_defn): Initialise new field.
4461         * c-lang.c (c_is_string_type_p): New function.
4462         (c_language_defn): Initialise new field.
4463         (cplus_language_defn): Initialise new field.
4464         (asm_language_defn): Initialise new field.
4465         (minimal_language_defn): Initialise new field.
4466         * c-lang.h (c_is_string_type_p): Declare new function.
4467         * d-lang.c (d_language_defn): Initialise new field.
4468         * f-lang.c (f_is_string_type_p): New function.
4469         (f_language_defn): Initialise new field.
4470         * go-lang.c (go_is_string_type_p): New function.
4471         (go_language_defn): Initialise new field.
4472         * language.c (default_is_string_type_p): New function.
4473         (unknown_language_defn): Initialise new field.
4474         (auto_language_defn): Initialise new field.
4475         * language.h (struct language_defn) <la_is_string_type_p>: New
4476         member variable.
4477         (default_is_string_type_p): Declare new function.
4478         * m2-lang.c (m2_language_defn): Initialise new field.
4479         * objc-lang.c (objc_language_defn): Initialise new field.
4480         * opencl-lang.c (opencl_language_defn): Initialise new field.
4481         * p-lang.c (pascal_is_string_type_p): New function.
4482         (pascal_language_defn): Initialise new field.
4483         * rust-lang.c (rust_is_string_type_p): New function.
4484         (rust_language_defn): Initialise new field.
4485
4486 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4489         New field.
4490         * ada-lang.c (ada_language_defn): Initialise new field.
4491         * c-lang.c (c_language_defn): Likewise.
4492         (cplus_language_defn): Likewise.
4493         (asm_language_defn): Likewise.
4494         (minimal_language_defn): Likewise.
4495         * d-lang.c (d_language_defn): Likewise.
4496         * f-lang.c (f_language_defn): Likewise.
4497         * go-lang.c (go_language_defn): Likewise.
4498         * language.c (unknown_language_defn): Likewise.
4499         (auto_language_defn): Likewise.
4500         * m2-lang.c (m2_language_defn): Likewise.
4501         * objc-lang.c (objc_language_defn): Likewise.
4502         * opencl-lang.c (opencl_language_defn): Likewise.
4503         * p-lang.c (pascal_language_defn): Likewise.
4504         * rust-lang.c (rust_language_defn): Likewise.
4505
4506 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4507
4508         * ada-lang.c (ada_is_character_type): Change return type to bool.
4509         (ada_is_string_type): Likewise.
4510         * ada-lang.h (ada_is_character_type): Update declaration
4511         (ada_is_string_type): Likewise.
4512
4513 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4514
4515         Support style in 'frame|thread apply'
4516
4517         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4518         * record.c (record_start, record_stop): Update callers of
4519         execute_command_to_string with false.
4520         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4521         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4522         methods.
4523         (class string_file): New constructor with term_out parameter.
4524         Override methods term_out and can_emit_style_escape.  New member
4525         term_out.
4526         (class stdio_file): Override can_emit_style_escape.
4527         (class tee_file): Override term_out and can_emit_style_escape.
4528         * utils.h (can_emit_style_escape): Remove.
4529         * utils.c (can_emit_style_escape): Likewise.
4530         Update all callers of can_emit_style_escape (SOMESTREAM) to
4531         SOMESTREAM->can_emit_style_escape.
4532         * source-cache.c (source_cache::get_source_lines): Likewise.
4533         * stack.c (frame_apply_command_count): Call execute_command_to_string
4534         passing the term_out characteristic of the current gdb_stdout.
4535         * thread.c (thr_try_catch_cmd): Likewise.
4536         * top.c (execute_command_to_string): pass term_out parameter
4537         to construct the string_file for the command output.
4538         * ui-file.c (term_cli_styling): New function (most code moved
4539         from utils.c can_emit_style_escape).
4540         (string_file::string_file, string_file::can_emit_style_escape,
4541         stdio_file::can_emit_style_escape, tee_file::term_out,
4542         tee_file::can_emit_style_escape): New functions.
4543
4544 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4545
4546         * NEWS: Mention the new set|show may-call-functions.
4547         * infcall.c (may_call_functions_p): New variable.
4548         (show_may_call_functions_p): New function.
4549         (call_function_by_hand_dummy): Throws an error if not
4550         may-call-functions.
4551         (_initialize_infcall): Call add_setshow_boolean_cmd for
4552         may-call-functions.
4553
4554 2019-04-25  Keith Seitz  <keiths@redhat.com>
4555
4556         PR c++/24367
4557         * cp-support.c (inspect_type): Don't attempt substitutions
4558         of symbol with the same name.
4559
4560 2019-04-25  Tom Tromey  <tromey@adacore.com>
4561
4562         PR gdb/24475:
4563         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4564         static.
4565
4566 2019-04-25  Tom Tromey  <tromey@adacore.com>
4567
4568         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4569         rvalue reference.
4570         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4571         (gdb_xml_parser::parse): Use std::move.
4572         * python/python-internal.h (gdbpy_convert_exception): Take a const
4573         reference.
4574         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4575         std::move.
4576         * python/py-utils.c (gdbpy_convert_exception): Take a const
4577         reference.
4578         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4579         Use std::move.
4580         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4581         Use std::move.
4582         * mi/mi-main.c (mi_print_exception): Take a const reference.
4583         * main.c (handle_command_errors): Take a const reference.
4584         * linespec.c (parse_linespec): Use std::move.
4585         * infcall.c (run_inferior_call): Use std::move.
4586         (call_function_by_hand_dummy): Use std::move.
4587         * exec.c (try_open_exec_file): Use std::move.
4588         * exceptions.h (exception_print, exception_fprintf)
4589         (exception_print_same): Update.
4590         * exceptions.c (print_exception, exception_print)
4591         (exception_fprintf, exception_print_same): Change parameters to
4592         const reference.
4593         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4594         * common/new-op.c: Use std::move.
4595         * common/common-exceptions.h (struct gdb_exception): Add move
4596         constructor.
4597         (struct gdb_exception_error, struct gdb_exception_quit, struct
4598         gdb_quit_bad_alloc): Change constructor to move constructor.
4599         (throw_exception): Change parameter to rvalue reference.
4600         * common/common-exceptions.c (throw_exception): Take rvalue
4601         reference.
4602         * cli/cli-interp.c (safe_execute_command): Use std::move.
4603         * breakpoint.c (insert_bp_location, location_to_sals): Use
4604         std::move.
4605
4606 2019-04-25  Tom Tromey  <tromey@adacore.com>
4607
4608         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4609         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4610         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4611         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4612         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4613         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4614         guile/scm-value.c: Use unpack.
4615         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4616         gdbscm_gdb_exception.
4617         (gdbscm_throw_gdb_exception): Likewise.
4618         (struct gdbscm_gdb_exception): New.
4619         (unpack): New function.
4620         (gdbscm_wrap): Use unpack.
4621
4622 2019-04-25  Tom Tromey  <tromey@adacore.com>
4623
4624         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4625         (gdb_rl_callback_handler): Use std::move.
4626         * common/common-exceptions.h (struct gdb_exception): Add move
4627         assignment operator.
4628         (throw_exception_sjlj): Change "exception" to const reference.
4629         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4630         (throw_exception_sjlj): Change "exception" to const reference.
4631
4632 2019-04-25  Tom Tromey  <tromey@adacore.com>
4633
4634         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4635         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4636         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4637         Update.
4638         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4639         Update.
4640         * mi/mi-interp.c (mi_interp::exec): Update.
4641         * linespec.c (parse_linespec): Update.
4642         * infcall.c (run_inferior_call): Update.
4643         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4644         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4645         (gdbscm_lookup_global_symbol): Update.
4646         * guile/scm-param.c (gdbscm_parameter_value): Update.
4647         * guile/scm-frame.c (gdbscm_frame_read_register)
4648         (gdbscm_frame_read_var): Update.
4649         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4650         * exec.c (try_open_exec_file): Update.
4651         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4652         (gdb_rl_callback_handler): Update.
4653         * common/common-exceptions.h (exception_none): Don't declare.
4654         * common/common-exceptions.c (exception_none): Don't define.
4655         (struct catcher) <exception>: Update.
4656         * cli/cli-interp.c (safe_execute_command): Update.
4657         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4658
4659 2019-04-25  Ali Tamur  <tamur@google.com>
4660
4661         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4662         (read_attribute_value): Likewise.
4663         (dwarf2_read_addr_index): Update comment.
4664         (read_str_index): Add DW_FORM_strx.
4665         (dwarf2_string_attr): Likewise.
4666         (dwarf2_const_value_attr): Likewise.
4667         (dump_die_shallow): Likewise.
4668         (dwarf2_fetch_constant_bytes): Likewise.
4669         (skip_form_bytes): Likewise.
4670         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4671
4672 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4673
4674         PR corefiles/11608
4675         PR corefiles/18187
4676         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4677         OFFSET.  Verify if current mapping contains an ELF header.
4678         (linux_find_memory_regions_full): Adjust call to
4679         dump_mapping_p.
4680
4681 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4682             Kang Li <kanglictf@gmail.com>
4683
4684         PR gdb/21600
4685
4686         * dwarf2-frame.c (read_initial_length): Be consistent about using
4687         unsigned representation of length.
4688         (decode_frame_entry_1): Likewise.  Check for wraparound of
4689         end pointer as well as buffer overflow.
4690
4691 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4692
4693         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4694         "vq".
4695
4696 2019-04-24  Tom Tromey  <tromey@adacore.com>
4697
4698         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4699
4700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4701
4702         * s12z-tdep.c (s12z_unwind_pc): Delete.
4703         (s12z_unwind_sp): Delete.
4704         (s12z_gdbarch_init): Don't register deleted functions with
4705         gdbarch.
4706
4707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4708
4709         * rl78-tdep.c (rl78_unwind_sp): Delete.
4710         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4711
4712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4713
4714         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4715         (xstormy16_unwind_pc): Delete.
4716         (xstormy16_dummy_id): Delete.
4717         (xstormy16_gdbarch_init): Don't register deleted functions with
4718         gdbarch.
4719
4720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4721
4722         * vax-tdep.c (vax_unwind_pc): Delete.
4723         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4724
4725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * v850-tdep.c (v850_unwind_sp): Delete.
4728         (v850_unwind_pc): Delete.
4729         (v850_dummy_id): Delete.
4730         (v850_gdbarch_init): Don't register deleted functions with
4731         gdbarch.
4732
4733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4734
4735         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4736         (tilegx_unwind_pc): Delete.
4737         (tilegx_unwind_dummy_id): Delete.
4738         (tilegx_gdbarch_init): Don't register deleted functions with
4739         gdbarch.
4740
4741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4744         (tic6x_dummy_id): Delete.
4745         (tic6x_gdbarch_init): Don't register deleted functions with
4746         gdbarch.
4747
4748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4749
4750         * sparc-tdep.c (sparc_unwind_pc): Delete.
4751         (sparc32_gdbarch_init): Don't register deleted function with
4752         gdbarch.
4753
4754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * sh-tdep.c (sh_unwind_sp): Delete.
4757         (sh_unwind_pc): Delete.
4758         (sh_dummy_id): Delete.
4759         (sh_gdbarch_init): Don't register deleted functions with
4760         gdbarch.
4761
4762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4763
4764         * score-tdep.c (score_unwind_sp): Delete.
4765         (score_unwind_pc): Delete.
4766         (score_dummy_id): Delete.
4767         (score_gdbarch_init): Don't register deleted functions with
4768         gdbarch.
4769
4770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4771
4772         * rx-tdep.c (rx_unwind_pc): Delete.
4773         (rx_unwind_sp): Delete.
4774         (rx_dummy_id): Delete.
4775         (rx_gdbarch_init): Don't register deleted functions with
4776         gdbarch.  Update comment.
4777
4778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4779
4780         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4781         (rs6000_dummy_id): Delete.
4782         (rs6000_gdbarch_init): Don't register deleted functions with
4783         gdbarch.
4784
4785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * or1k-tdep.c (or1k_dummy_id): Delete.
4788         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4789
4790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * nios2-tdep.c (nios2_dummy_id): Delete.
4793         (nios2_unwind_sp): Delete.
4794         (nios2_gdbarch_init): Don't register deleted functions with
4795         gdbarch.
4796
4797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * nds32-tdep.c (nds32_dummy_id): Delete.
4800         (nds32_unwind_pc): Delete.
4801         (nds32_unwind_sp): Delete.
4802         (nds32_gdbarch_init): Don't register deleted functions with
4803         gdbarch.
4804
4805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * msp430-tdep.c (msp430_unwind_pc): Delete.
4808         (msp430_unwind_sp): Delete.
4809         (msp430_dummy_id): Delete.
4810         (msp430_gdbarch_init): Don't register deleted functions with
4811         gdbarch.
4812
4813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * moxie-tdep.c (moxie_unwind_sp): Delete.
4816         (moxie_unwind_pc): Delete.
4817         (moxie_dummy_id): Delete.
4818         (moxie_gdbarch_init): Don't register deleted functions with
4819         gdbarch.
4820
4821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4822
4823         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4824         (mn10300_unwind_pc): Delete.
4825         (mn10300_unwind_sp): Delete.
4826         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4827         mn10300_unwind_sp.
4828         (mn10300_frame_unwind_init): Don't register deleted functions with
4829         gdbarch.
4830
4831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * mep-tdep.c (mep_unwind_pc): Delete.
4834         (mep_unwind_sp): Delete.
4835         (mep_dummy_id): Delete.
4836         (mep_gdbarch_init): Don't register deleted functions with
4837         gdbarch.
4838
4839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4842         (m68hc11_unwind_sp): Delete.
4843         (m68hc11_gdbarch_init): Don't register deleted functions with
4844         gdbarch.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * m32r-tdep.c (m32r_unwind_sp): Delete.
4849         (m32r_unwind_pc): Delete.
4850         (m32r_dummy_id): Delete.
4851         (m32r_gdbarch_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * m32c-tdep.c (m32c_unwind_pc): Delete.
4857         (m32c_unwind_sp): Delete.
4858         (m32c_dummy_id): Delete.
4859         (m32c_gdbarch_init): Don't register deleted functions with
4860         gdbarch.
4861
4862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4865         (lm32_unwind_pc): Delete.
4866         (lm32_dummy_id): Delete.
4867         (lm32_gdbarch_init): Don't register deleted functions with
4868         gdbarch.
4869
4870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4873         (iq2000_unwind_pc): Delete.
4874         (iq2000_dummy_id): Delete.
4875         (iq2000_gdbarch_init): Don't register deleted functions with
4876         gdbarch.
4877
4878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4879
4880         * nds32-tdep.c (nds32_type_align): Delete.
4881         (nds32_push_dummy_call): Use type_align instead.
4882
4883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * arm-tdep.c (arm_type_align): Only handle vector override case.
4886         (arm_push_dummy_call): Use type_align.
4887         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4888
4889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4892         case.
4893         (pass_on_stack): Use type_align.
4894         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4895         function.
4896
4897 2019-04-23  Tom Tromey  <tromey@adacore.com>
4898
4899         * dwarf2read.c (line_header::file_name_at): Remove unused
4900         overload.
4901
4902 2019-04-23  Tom de Vries  <tdevries@suse.de>
4903
4904         PR gdb/24438
4905         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4906         invocation.
4907
4908
4909 2019-03-27  Ali Tamur  <tamur@google.com>
4910
4911         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4912         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4913         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4914         (dwarf_expr_context::get_addr_index): Likewise
4915         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4916         (symbol_needs_eval_context::get_addr_index): Likewise
4917         (disassemble_dwarf_expression): Add DW_OP_addrx
4918         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4919         (read_cutu_die_from_dwo): Update comment
4920         (skip_one_die): Add DW_FORM_addrx
4921         (read_attribute_value): Likewise
4922         (var_decode_location): Add DW_OP_addrx
4923         (dwarf2_const_value_attr): Add DW_FORM_addrx
4924         (dump_die_shallow): Likewise
4925         (dwarf2_fetch_constant_bytes): Likewise
4926         (decode_locdesc): Add DW_OP_addrx
4927         (skip_form_bytes): Add DW_FORM_addrx
4928
4929 2019-04-22  Ali Tamur  <tamur@google.com>
4930
4931         * MAINTAINERS (Write After Approval): Add self.
4932
4933 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4934
4935         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4936         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4937         (open_symbol_file_object): Likewise.
4938         (svr4_default_sos): Add info parameter.
4939         (svr4_read_so_list): Likewise.
4940         (svr4_current_sos_direct): Adjust functions calls to pass down
4941         info.
4942         (svr4_current_sos_1): Add info parameter.
4943         (svr4_current_sos): Call get_svr4_info, pass info down to
4944         svr4_current_sos_1.
4945         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4946         get_svr4_info.
4947         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4948         get_svr4_info.
4949         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4950         to get_svr4_info.
4951         (probes_table_remove_objfile_probes): Likewise.
4952         (register_solib_event_probe): Add info parameter.
4953         (solist_update_incremental): Pass info parameter down to
4954         svr4_read_so_list.
4955         (disable_probes_interface): Add info parameter.
4956         (svr4_handle_solib_event): Pass current_program_space to
4957         get_svr4_info.  Adjust disable_probes_interface cleanup.
4958         (svr4_create_probe_breakpoints): Add info parameter, pass it
4959         down to register_solib_event_probe.
4960         (svr4_create_solib_event_breakpoints): Add info parameter,
4961         pass it down to svr4_create_probe_breakpoints.
4962         (enable_break): Pass info down to
4963         svr4_create_solib_event_breakpoints.
4964         (svr4_solib_create_inferior_hook): Pass current_program_space to
4965         get_svr4_info.
4966         (svr4_clear_solib): Likewise.
4967
4968 2019-04-22  Pedro Alves  <palves@redhat.com>
4969
4970         * solib-svr4.c (svr4_free_objfile_observer): New.
4971         (probe_and_action::objfile): New field.
4972         (probes_table_htab_remove_objfile_probes)
4973         (probes_table_remove_objfile_probes): New functions.
4974         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4975         in the new probe_and_action.  Don't store the probe in 'lookup'.
4976         (svr4_create_probe_breakpoints): Pass objfile to
4977         register_solib_event_probe.
4978         (_initialize_svr4_solib): Register a free_objfile observer.
4979
4980 2019-04-19  Tom Tromey  <tom@tromey.com>
4981
4982         * common/queue.h: Remove.
4983
4984 2019-04-19  Tom Tromey  <tom@tromey.com>
4985
4986         * event-loop.c: Don't include "common/queue.h".
4987
4988 2019-04-19  Tom Tromey  <tom@tromey.com>
4989
4990         * remote.c (remote_target): Use delete.
4991         * remote-notif.h: Include <list>, not "common/queue.h".
4992         (notif_client_p): Remove typedef.
4993         (remote_notif_state): Add constructor, destructor, initializer.
4994         <notif_queue>: Now a std::list.
4995         (remote_notif_state_xfree): Don't declare.
4996         * remote-notif.c (remote_notif_process, handle_notification)
4997         (remote_notif_state_allocate): Update.
4998         (~remote_notif_state): Rename from remote_notif_state_xfree.
4999
5000 2019-04-19  Tom Tromey  <tom@tromey.com>
5001
5002         * symfile.c (reread_symbols): Update.
5003         * objfiles.c (objfile_register_static_link)
5004         (objfile_lookup_static_link): Update
5005         (~objfile) Don't delete static_links.
5006         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5007
5008 2019-04-19  Tom Tromey  <tom@tromey.com>
5009
5010         * type-stack.h (struct type_stack) <insert>: Constify string.
5011         * type-stack.c (type_stack::insert): Constify string.
5012         * gdbtypes.h (lookup_template_type): Update.
5013         (address_space_name_to_int): Update.
5014         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5015         const.
5016         (lookup_template_type): Make name const.
5017         * c-exp.y: Update rules.
5018         (lex_one_token, classify_name, classify_inner_name)
5019         (c_print_token): Update.
5020         * p-exp.y: Update rules.
5021         (yylex): Update.
5022         * f-exp.y: Update rules.
5023         (yylex): Update.
5024         * d-exp.y: Update rules.
5025         (lex_one_token, classify_name, classify_inner_name): Update.
5026         * parse.c (write_dollar_variable, copy_name): Return std::string.
5027         * parser-defs.h (copy_name): Change return type.
5028         * m2-exp.y: Update rules.
5029         (yylex): Update.
5030         * go-exp.y (lex_one_token): Update.
5031         Update rules.
5032         (classify_unsafe_function, classify_packaged_name)
5033         (classify_name, yylex): Update.
5034
5035 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5036
5037         * configure.ac: add --enable-source-highlight switch.
5038         * configure: Regenerate.
5039         * top.c (print_gdb_version): plumb --enable-source-highlight
5040         status to "show configuration".
5041
5042 2019-04-19  Tom Tromey  <tromey@adacore.com>
5043
5044         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5045         Check ADA_TYPE_P.
5046         (empty_record, ada_template_to_fixed_record_type_1)
5047         (template_to_static_fixed_type)
5048         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5049         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5050         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5051         macros.
5052
5053 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5054
5055         PR symtab/24423:
5056         * source.c (print_source_lines_base): Advance "iter" when a
5057         control character is seen.
5058
5059 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5060
5061         * inferior.h (struct infcall_suspend_state_deleter):
5062         Catch exception in destructor to avoid crash.
5063
5064 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5067         close to the add_com "shell".
5068
5069 2019-04-18  Tom Tromey  <tromey@adacore.com>
5070
5071         * process-stratum-target.h (class process_stratum_target)
5072         <stratum>: Add "final".
5073
5074 2019-04-17  Tom Tromey  <tromey@adacore.com>
5075
5076         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5077         against nullptr before use.
5078
5079 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5080
5081         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5082
5083 2019-04-17  Jim Wilson  <jimw@sifive.com>
5084             Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5087         code read might fail, assume 4-byte breakpoint in that case.
5088
5089 2019-04-15  Leszek Swirski  <leszeks@google.com>
5090
5091         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5092         rather than a hand-rolled POD check when checking for forced MEMORY
5093         classification.
5094
5095 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5096
5097         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5098         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5099         function.
5100         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5101         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5102         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5103         declaration.
5104
5105 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5106
5107         * aarch64-linux-nat.c
5108         (aarch64_linux_nat_target::thread_architecture): Add override.
5109         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5110         each VQ.
5111
5112 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5113
5114         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5115
5116 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5119         target types of size 96-bits, add some additional comments, and
5120         check that the builtin type we found was the correct size.
5121
5122 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5123
5124         * utils.c (prompt_for_continue): Don't restore the styling at the
5125         end, as applied_style has the wrong value.  This fixes styling in
5126         long lists of file names that are interrupted by the "Continue?"
5127         prompt.
5128
5129 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5132         * c-lang.c (c_language_defn): Likewise.
5133         (cplus_language_defn): Likewise.
5134         (asm_language_defn): Likewise.
5135         (minimal_language_defn): Likewise.
5136         * d-lang.c (d_language_defn): Likewise.
5137         * f-lang.c (f_language_defn): Likewise.
5138         * go-lang.c (go_language_defn): Likewise.
5139         * language.c (unknown_language_defn): Likewise.
5140         (auto_language_defn): Likewise.
5141         * language.h (struct language_defn): Remove la_magic field.
5142         (LANG_MAGIC): Delete.
5143         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5144         * objc-lang.c (objc_language_defn): Likewise.
5145         * opencl-lang.c (opencl_language_defn): Likewise.
5146         * p-lang.c (pascal_language_defn): Likewise.
5147         * rust-lang.c (rust_language_defn): Likewise.
5148
5149 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * riscv-tdep.c (riscv_type_align): New function.
5152         (riscv_type_alignment): Delete.
5153         (riscv_arg_location): Use 'type_align'.
5154         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5155
5156 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5157
5158         * gdbtypes.c (type_align): A struct with no non-static fields also
5159         has alignment of 1.
5160
5161 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5162
5163         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5164         component to 0.
5165         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5166         member.
5167         (riscv_struct_info::analyse): New implementation using new
5168         analyse_inner member function.
5169         (riscv_struct_info::field_offset): New member function.
5170         (riscv_struct_info::m_offsets): New member variable.
5171         (riscv_struct_info::analyse_inner): New private member function,
5172         takes the old implementation of riscv_struct_info::analyse but
5173         extended to track field offsets.
5174         (riscv_call_arg_struct): Update the struct folding special cases
5175         to handle cases where empty C++ structs, which are non-zero
5176         length, are found.
5177         (riscv_arg_location): Initialise the length of each location, a
5178         non-zero length now indicates the location is in use.
5179         (riscv_push_dummy_call): Allow for the first location having a
5180         non-zero offset when setting up arguments.
5181         (riscv_return_value): Likewise, but for return values.
5182
5183 2019-04-11  Tom Tromey  <tromey@adacore.com>
5184
5185         * utils.c (internal_vproblem): Make "msg" const.
5186
5187 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5188
5189         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5190         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5191         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5192         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5193
5194 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5195
5196         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5197         function.
5198         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5199         of amd64_collect_native_gregset.
5200         (amd64_linux_nat_target::store_registers): Likewise.
5201
5202 2019-04-10  Tom Tromey  <tom@tromey.com>
5203
5204         * symtab.c (lookup_global_symbol_from_objfile)
5205         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5206         * objfiles.h (class separate_debug_iterator): New.
5207         (class separate_debug_range): New.
5208         (struct objfile) <separate_debug_objfiles>: New method.
5209         (objfile_separate_debug_iterate): Don't declare.
5210         * objfiles.c (separate_debug_iterator::operator++): Rename from
5211         objfile_separate_debug_iterate.
5212         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5213         iterator.
5214         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5215         iterator.
5216
5217 2019-04-10  Tom Tromey  <tom@tromey.com>
5218
5219         * symfile.c (reread_symbols): Remove old comment.
5220         * objfiles.c (free_all_objfiles): Fix a typo.
5221
5222 2019-04-10  Tom Tromey  <tom@tromey.com>
5223
5224         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5225         * minsyms.c (lookup_minimal_symbol): Use foreach.
5226         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5227         (lookup_minimal_symbol_solib_trampoline): Likewise.
5228         * symfile.c (reread_symbols): Use foreach.
5229
5230 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5231             Tom Tromey  <tromey@adacore.com>
5232
5233         PR rust/24414:
5234         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5235         (rust_lex_int_test): Change "value" to be LONGEST.
5236         (rust_lex_tests): Add test for long integer literal.
5237
5238 2019-04-09  Tom Tromey  <tromey@adacore.com>
5239
5240         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5241         to bool.
5242         (extended_remote_target::attach): Update.
5243         (remote_target::remote_notice_new_inferior): Update.
5244         (remote_target::add_current_inferior_and_thread): Update.
5245         * inferior.c (exit_inferior_1): Use "false".
5246         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5247
5248 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5249
5250         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5251         the "start" command.
5252
5253 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5254
5255         * python/py-inferior.c (infpy_thread_from_thread_handle):
5256         Adjust comments to reflect renaming of thread_from_thread_handle
5257         to thread_from_handle.  Adjust keywords.  Fix type error message.
5258         (inferior_object_methods): Add thread_from_handle.  Retain
5259         thread_from_thread_handle, but mark it as deprecated.
5260
5261 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5262
5263         * gdbthread.h (find_thread_by_handle): Revise declaration.
5264         * thread.c (find_thread_by_handle): Likewise.  Adjust
5265         implementation too.
5266         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5267         support for buffer objects as handles.
5268
5269 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5270
5271         * python/py-infthread.c (thpy_thread_handle): New function.
5272         (thread_object_methods): Register thpy_thread_handle.
5273
5274 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5275
5276         * gdbthread.h (thread_to_thread_handle): Declare.
5277         * thread.c (gdbtypes.h): Include.
5278         (thread_to_thread_handle): New function.
5279
5280         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5281         (target_thread_info_to_thread_handle): Declare.
5282         * target.c (target_thread_info_to_thread_handle): New function.
5283         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5284         * target-delegates.c: Regenerate.
5285
5286         * linux-thread-db.c (class thread_db_target): Add method
5287         thread_info_to_thread_handle.
5288         (thread_db_target::thread_info_to_thread_handle): Define.
5289         * remote.c (class remote_target): Add new method
5290         thread_info_to_thread_handle.
5291         (remote_target::thread_info_to_thread_handle): Define.
5292
5293 2019-04-08  Pedro Alves  <palves@redhat.com>
5294
5295         * common/common-exceptions.c (throw_exception): Don't create
5296         named object to throw; throw directly.
5297         (throw_it): Likewise.  Don't initialize gdb_exception::message
5298         here, with new; pass FMT and AP to the ctor instead.
5299         * common/common-exceptions.h: Include <string>.
5300         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5301         const char *, va_list)): New ctor.  Use std::make_shared.
5302         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5303         errors)): Delete.
5304         (gdb_exception_error::gdb_exception_error(enum errors, const char
5305         *, va_list)): New.
5306         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5307         Add assertion.
5308         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5309         errors)): Delete.
5310         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5311         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5312         Add assertion.
5313
5314 2019-04-08  Tom Tromey  <tom@tromey.com>
5315
5316         * valops.c (value_rtti_indirect_type): Replace throw_exception
5317         with throw.
5318         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5319         with throw.
5320         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5321         throw.
5322         * target.c (target_translate_tls_address): Replace throw_exception
5323         with throw.
5324         * stack.c (frame_apply_command_count): Replace throw_exception
5325         with throw.
5326         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5327         throw.
5328         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5329         with throw.
5330         * rs6000-tdep.c (rs6000_frame_cache)
5331         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5332         * remote.c: Replace throw_exception with throw.
5333         * record-full.c (record_full_message, record_full_wait_1)
5334         (record_full_restore): Replace throw_exception with throw.
5335         * record-btrace.c:
5336         (get_thread_current_frame_id, record_btrace_start_replaying)
5337         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5338         (cmd_record_btrace_start): Replace throw_exception with throw.
5339         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5340         throw.
5341         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5342         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5343         * linespec.c:
5344         (find_linespec_symbols): Replace throw_exception with throw.
5345         * infrun.c (displaced_step_prepare, resume): Replace
5346         throw_exception with throw.
5347         * infcmd.c (post_create_inferior): Replace throw_exception with
5348         throw.
5349         * inf-loop.c (inferior_event_handler): Replace throw_exception
5350         with throw.
5351         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5352         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5353         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5354         (get_prev_frame_always, get_frame_pc_if_available)
5355         (get_frame_address_in_block_if_available, get_frame_language):
5356         Replace throw_exception with throw.
5357         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5358         throw_exception with throw.
5359         * eval.c (fetch_subexp_value, evaluate_var_value)
5360         (evaluate_funcall, evaluate_subexp_standard): Replace
5361         throw_exception with throw.
5362         * dwarf2loc.c (call_site_find_chain)
5363         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5364         Replace throw_exception with throw.
5365         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5366         with throw.
5367         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5368         throw.
5369         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5370         * completer.c (complete_line_internal): Replace throw_exception
5371         with throw.
5372         * compile/compile-object-run.c (compile_object_run): Replace
5373         throw_exception with throw.
5374         * cli/cli-script.c (process_next_line): Replace throw_exception
5375         with throw.
5376         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5377         (btrace_enable, btrace_maint_update_pt_packets): Replace
5378         throw_exception with throw.
5379         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5380         throw_exception with throw.
5381         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5382         throw_exception with throw.
5383         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5384         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5385         * aarch64-tdep.c (aarch64_make_prologue_cache)
5386         (aarch64_make_stub_cache): Replace throw_exception with throw.
5387
5388 2019-04-08  Tom Tromey  <tom@tromey.com>
5389
5390         * common/common-exceptions.c (throw_exception): Rename from
5391         throw_exception_cxx.  Remove old copy.  Make argument const.
5392         (throw_it): Create and throw exception objects directly.
5393         * common/common-exceptions.h (throw_exception): Make argument
5394         const.
5395         (struct gdb_exception_error): Add constructor.
5396         (struct gdb_exception_quit): Add constructor.
5397
5398 2019-04-08  Tom Tromey  <tom@tromey.com>
5399
5400         * common/common-exceptions.h (exception_rethrow): Don't declare.
5401         (TRY_SJLJ): Update comment.
5402         (TRY, CATCH, END_CATCH): Remove.
5403         * common/common-exceptions.c (exception_rethrow): Remove.
5404
5405 2019-04-08  Tom Tromey  <tom@tromey.com>
5406
5407         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5408         Remove.
5409         (gdb_exception_error): Rename from
5410         gdb_exception_RETURN_MASK_ERROR.
5411         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5412         (gdb_quit_bad_alloc): Update.
5413         * aarch64-tdep.c: Update.
5414         * ada-lang.c: Update.
5415         * ada-typeprint.c: Update.
5416         * ada-valprint.c: Update.
5417         * amd64-tdep.c: Update.
5418         * arch-utils.c: Update.
5419         * break-catch-throw.c: Update.
5420         * breakpoint.c: Update.
5421         * btrace.c: Update.
5422         * c-varobj.c: Update.
5423         * cli/cli-cmds.c: Update.
5424         * cli/cli-interp.c: Update.
5425         * cli/cli-script.c: Update.
5426         * common/common-exceptions.c: Update.
5427         * common/new-op.c: Update.
5428         * common/selftest.c: Update.
5429         * compile/compile-c-symbols.c: Update.
5430         * compile/compile-cplus-symbols.c: Update.
5431         * compile/compile-object-load.c: Update.
5432         * compile/compile-object-run.c: Update.
5433         * completer.c: Update.
5434         * corelow.c: Update.
5435         * cp-abi.c: Update.
5436         * cp-support.c: Update.
5437         * cp-valprint.c: Update.
5438         * darwin-nat.c: Update.
5439         * disasm-selftests.c: Update.
5440         * dtrace-probe.c: Update.
5441         * dwarf-index-cache.c: Update.
5442         * dwarf-index-write.c: Update.
5443         * dwarf2-frame-tailcall.c: Update.
5444         * dwarf2-frame.c: Update.
5445         * dwarf2loc.c: Update.
5446         * dwarf2read.c: Update.
5447         * eval.c: Update.
5448         * event-loop.c: Update.
5449         * event-top.c: Update.
5450         * exec.c: Update.
5451         * f-valprint.c: Update.
5452         * fbsd-tdep.c: Update.
5453         * frame-unwind.c: Update.
5454         * frame.c: Update.
5455         * gdbtypes.c: Update.
5456         * gnu-v3-abi.c: Update.
5457         * guile/guile-internal.h: Update.
5458         * guile/scm-block.c: Update.
5459         * guile/scm-breakpoint.c: Update.
5460         * guile/scm-cmd.c: Update.
5461         * guile/scm-disasm.c: Update.
5462         * guile/scm-frame.c: Update.
5463         * guile/scm-lazy-string.c: Update.
5464         * guile/scm-math.c: Update.
5465         * guile/scm-param.c: Update.
5466         * guile/scm-ports.c: Update.
5467         * guile/scm-pretty-print.c: Update.
5468         * guile/scm-symbol.c: Update.
5469         * guile/scm-symtab.c: Update.
5470         * guile/scm-type.c: Update.
5471         * guile/scm-value.c: Update.
5472         * i386-linux-tdep.c: Update.
5473         * i386-tdep.c: Update.
5474         * inf-loop.c: Update.
5475         * infcall.c: Update.
5476         * infcmd.c: Update.
5477         * infrun.c: Update.
5478         * jit.c: Update.
5479         * language.c: Update.
5480         * linespec.c: Update.
5481         * linux-fork.c: Update.
5482         * linux-nat.c: Update.
5483         * linux-tdep.c: Update.
5484         * linux-thread-db.c: Update.
5485         * main.c: Update.
5486         * mi/mi-cmd-break.c: Update.
5487         * mi/mi-cmd-stack.c: Update.
5488         * mi/mi-interp.c: Update.
5489         * mi/mi-main.c: Update.
5490         * objc-lang.c: Update.
5491         * p-valprint.c: Update.
5492         * parse.c: Update.
5493         * ppc-linux-tdep.c: Update.
5494         * printcmd.c: Update.
5495         * python/py-arch.c: Update.
5496         * python/py-breakpoint.c: Update.
5497         * python/py-cmd.c: Update.
5498         * python/py-finishbreakpoint.c: Update.
5499         * python/py-frame.c: Update.
5500         * python/py-framefilter.c: Update.
5501         * python/py-gdb-readline.c: Update.
5502         * python/py-inferior.c: Update.
5503         * python/py-infthread.c: Update.
5504         * python/py-lazy-string.c: Update.
5505         * python/py-linetable.c: Update.
5506         * python/py-objfile.c: Update.
5507         * python/py-param.c: Update.
5508         * python/py-prettyprint.c: Update.
5509         * python/py-progspace.c: Update.
5510         * python/py-record-btrace.c: Update.
5511         * python/py-record.c: Update.
5512         * python/py-symbol.c: Update.
5513         * python/py-type.c: Update.
5514         * python/py-unwind.c: Update.
5515         * python/py-utils.c: Update.
5516         * python/py-value.c: Update.
5517         * python/python.c: Update.
5518         * record-btrace.c: Update.
5519         * record-full.c: Update.
5520         * remote-fileio.c: Update.
5521         * remote.c: Update.
5522         * riscv-tdep.c: Update.
5523         * rs6000-aix-tdep.c: Update.
5524         * rs6000-tdep.c: Update.
5525         * rust-exp.y: Update.
5526         * rust-lang.c: Update.
5527         * s390-tdep.c: Update.
5528         * selftest-arch.c: Update.
5529         * solib-dsbt.c: Update.
5530         * solib-frv.c: Update.
5531         * solib-spu.c: Update.
5532         * solib-svr4.c: Update.
5533         * solib.c: Update.
5534         * sparc64-linux-tdep.c: Update.
5535         * stack.c: Update.
5536         * symfile-mem.c: Update.
5537         * symmisc.c: Update.
5538         * target.c: Update.
5539         * thread.c: Update.
5540         * top.c: Update.
5541         * tracefile-tfile.c: Update.
5542         * tui/tui.c: Update.
5543         * typeprint.c: Update.
5544         * unittests/cli-utils-selftests.c: Update.
5545         * unittests/parse-connection-spec-selftests.c: Update.
5546         * valops.c: Update.
5547         * valprint.c: Update.
5548         * value.c: Update.
5549         * varobj.c: Update.
5550         * windows-nat.c: Update.
5551         * x86-linux-nat.c: Update.
5552         * xml-support.c: Update.
5553
5554 2019-04-08  Tom Tromey  <tom@tromey.com>
5555
5556         * xml-support.c: Use C++ exception handling.
5557         * x86-linux-nat.c: Use C++ exception handling.
5558         * windows-nat.c: Use C++ exception handling.
5559         * varobj.c: Use C++ exception handling.
5560         * value.c: Use C++ exception handling.
5561         * valprint.c: Use C++ exception handling.
5562         * valops.c: Use C++ exception handling.
5563         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5564         handling.
5565         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5566         * typeprint.c: Use C++ exception handling.
5567         * tui/tui.c: Use C++ exception handling.
5568         * tracefile-tfile.c: Use C++ exception handling.
5569         * top.c: Use C++ exception handling.
5570         * thread.c: Use C++ exception handling.
5571         * target.c: Use C++ exception handling.
5572         * symmisc.c: Use C++ exception handling.
5573         * symfile-mem.c: Use C++ exception handling.
5574         * stack.c: Use C++ exception handling.
5575         * sparc64-linux-tdep.c: Use C++ exception handling.
5576         * solib.c: Use C++ exception handling.
5577         * solib-svr4.c: Use C++ exception handling.
5578         * solib-spu.c: Use C++ exception handling.
5579         * solib-frv.c: Use C++ exception handling.
5580         * solib-dsbt.c: Use C++ exception handling.
5581         * selftest-arch.c: Use C++ exception handling.
5582         * s390-tdep.c: Use C++ exception handling.
5583         * rust-lang.c: Use C++ exception handling.
5584         * rust-exp.y: Use C++ exception handling.
5585         * rs6000-tdep.c: Use C++ exception handling.
5586         * rs6000-aix-tdep.c: Use C++ exception handling.
5587         * riscv-tdep.c: Use C++ exception handling.
5588         * remote.c: Use C++ exception handling.
5589         * remote-fileio.c: Use C++ exception handling.
5590         * record-full.c: Use C++ exception handling.
5591         * record-btrace.c: Use C++ exception handling.
5592         * python/python.c: Use C++ exception handling.
5593         * python/py-value.c: Use C++ exception handling.
5594         * python/py-utils.c: Use C++ exception handling.
5595         * python/py-unwind.c: Use C++ exception handling.
5596         * python/py-type.c: Use C++ exception handling.
5597         * python/py-symbol.c: Use C++ exception handling.
5598         * python/py-record.c: Use C++ exception handling.
5599         * python/py-record-btrace.c: Use C++ exception handling.
5600         * python/py-progspace.c: Use C++ exception handling.
5601         * python/py-prettyprint.c: Use C++ exception handling.
5602         * python/py-param.c: Use C++ exception handling.
5603         * python/py-objfile.c: Use C++ exception handling.
5604         * python/py-linetable.c: Use C++ exception handling.
5605         * python/py-lazy-string.c: Use C++ exception handling.
5606         * python/py-infthread.c: Use C++ exception handling.
5607         * python/py-inferior.c: Use C++ exception handling.
5608         * python/py-gdb-readline.c: Use C++ exception handling.
5609         * python/py-framefilter.c: Use C++ exception handling.
5610         * python/py-frame.c: Use C++ exception handling.
5611         * python/py-finishbreakpoint.c: Use C++ exception handling.
5612         * python/py-cmd.c: Use C++ exception handling.
5613         * python/py-breakpoint.c: Use C++ exception handling.
5614         * python/py-arch.c: Use C++ exception handling.
5615         * printcmd.c: Use C++ exception handling.
5616         * ppc-linux-tdep.c: Use C++ exception handling.
5617         * parse.c: Use C++ exception handling.
5618         * p-valprint.c: Use C++ exception handling.
5619         * objc-lang.c: Use C++ exception handling.
5620         * mi/mi-main.c: Use C++ exception handling.
5621         * mi/mi-interp.c: Use C++ exception handling.
5622         * mi/mi-cmd-stack.c: Use C++ exception handling.
5623         * mi/mi-cmd-break.c: Use C++ exception handling.
5624         * main.c: Use C++ exception handling.
5625         * linux-thread-db.c: Use C++ exception handling.
5626         * linux-tdep.c: Use C++ exception handling.
5627         * linux-nat.c: Use C++ exception handling.
5628         * linux-fork.c: Use C++ exception handling.
5629         * linespec.c: Use C++ exception handling.
5630         * language.c: Use C++ exception handling.
5631         * jit.c: Use C++ exception handling.
5632         * infrun.c: Use C++ exception handling.
5633         * infcmd.c: Use C++ exception handling.
5634         * infcall.c: Use C++ exception handling.
5635         * inf-loop.c: Use C++ exception handling.
5636         * i386-tdep.c: Use C++ exception handling.
5637         * i386-linux-tdep.c: Use C++ exception handling.
5638         * guile/scm-value.c: Use C++ exception handling.
5639         * guile/scm-type.c: Use C++ exception handling.
5640         * guile/scm-symtab.c: Use C++ exception handling.
5641         * guile/scm-symbol.c: Use C++ exception handling.
5642         * guile/scm-pretty-print.c: Use C++ exception handling.
5643         * guile/scm-ports.c: Use C++ exception handling.
5644         * guile/scm-param.c: Use C++ exception handling.
5645         * guile/scm-math.c: Use C++ exception handling.
5646         * guile/scm-lazy-string.c: Use C++ exception handling.
5647         * guile/scm-frame.c: Use C++ exception handling.
5648         * guile/scm-disasm.c: Use C++ exception handling.
5649         * guile/scm-cmd.c: Use C++ exception handling.
5650         * guile/scm-breakpoint.c: Use C++ exception handling.
5651         * guile/scm-block.c: Use C++ exception handling.
5652         * guile/guile-internal.h: Use C++ exception handling.
5653         * gnu-v3-abi.c: Use C++ exception handling.
5654         * gdbtypes.c: Use C++ exception handling.
5655         * frame.c: Use C++ exception handling.
5656         * frame-unwind.c: Use C++ exception handling.
5657         * fbsd-tdep.c: Use C++ exception handling.
5658         * f-valprint.c: Use C++ exception handling.
5659         * exec.c: Use C++ exception handling.
5660         * event-top.c: Use C++ exception handling.
5661         * event-loop.c: Use C++ exception handling.
5662         * eval.c: Use C++ exception handling.
5663         * dwarf2read.c: Use C++ exception handling.
5664         * dwarf2loc.c: Use C++ exception handling.
5665         * dwarf2-frame.c: Use C++ exception handling.
5666         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5667         * dwarf-index-write.c: Use C++ exception handling.
5668         * dwarf-index-cache.c: Use C++ exception handling.
5669         * dtrace-probe.c: Use C++ exception handling.
5670         * disasm-selftests.c: Use C++ exception handling.
5671         * darwin-nat.c: Use C++ exception handling.
5672         * cp-valprint.c: Use C++ exception handling.
5673         * cp-support.c: Use C++ exception handling.
5674         * cp-abi.c: Use C++ exception handling.
5675         * corelow.c: Use C++ exception handling.
5676         * completer.c: Use C++ exception handling.
5677         * compile/compile-object-run.c: Use C++ exception handling.
5678         * compile/compile-object-load.c: Use C++ exception handling.
5679         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5680         * compile/compile-c-symbols.c: Use C++ exception handling.
5681         * common/selftest.c: Use C++ exception handling.
5682         * common/new-op.c: Use C++ exception handling.
5683         * cli/cli-script.c: Use C++ exception handling.
5684         * cli/cli-interp.c: Use C++ exception handling.
5685         * cli/cli-cmds.c: Use C++ exception handling.
5686         * c-varobj.c: Use C++ exception handling.
5687         * btrace.c: Use C++ exception handling.
5688         * breakpoint.c: Use C++ exception handling.
5689         * break-catch-throw.c: Use C++ exception handling.
5690         * arch-utils.c: Use C++ exception handling.
5691         * amd64-tdep.c: Use C++ exception handling.
5692         * ada-valprint.c: Use C++ exception handling.
5693         * ada-typeprint.c: Use C++ exception handling.
5694         * ada-lang.c: Use C++ exception handling.
5695         * aarch64-tdep.c: Use C++ exception handling.
5696
5697 2019-04-08  Tom Tromey  <tom@tromey.com>
5698
5699         * xml-support.c (gdb_xml_parser::parse): Update.
5700         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5701         * value.c (show_convenience): Update.
5702         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5703         (test_parse_flags_qcs): Update.
5704         * thread.c (thr_try_catch_cmd): Update.
5705         * target.c (target_translate_tls_address): Update.
5706         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5707         (info_frame_command_core, frame_apply_command_count): Update.
5708         * rust-exp.y (rust_lex_exception_test): Update.
5709         * riscv-tdep.c (riscv_print_one_register_info): Update.
5710         * remote.c (remote_target::enable_btrace): Update.
5711         * record-btrace.c (record_btrace_enable_warn): Update.
5712         * python/py-utils.c (gdbpy_convert_exception): Update.
5713         * printcmd.c (do_one_display, print_variable_and_value): Update.
5714         * mi/mi-main.c (mi_print_exception): Update.
5715         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5716         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5717         * linux-nat.c (linux_nat_target::attach): Update.
5718         * linux-fork.c (class scoped_switch_fork_info): Update.
5719         * infrun.c (displaced_step_prepare): Update.
5720         * infcall.c (call_function_by_hand_dummy): Update.
5721         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5722         * gnu-v3-abi.c (print_one_vtable): Update.
5723         * frame.c (get_prev_frame_always): Update.
5724         * f-valprint.c (info_common_command_for_block): Update.
5725         * exec.c (try_open_exec_file): Update.
5726         * exceptions.c (print_exception, exception_print)
5727         (exception_fprintf, exception_print_same): Update.
5728         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5729         * dwarf-index-cache.c (index_cache::store)
5730         (index_cache::lookup_gdb_index): Update.
5731         * darwin-nat.c (maybe_cache_shell): Update.
5732         * cp-valprint.c (cp_print_value_fields): Update.
5733         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5734         (gcc_cplus_symbol_address): Update.
5735         * compile/compile-c-symbols.c (gcc_convert_symbol)
5736         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5737         * common/selftest.c: Update.
5738         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5739         a std::string.
5740         (exception_try_scope_entry, exception_try_scope_exit): Don't
5741         declare.
5742         (struct exception_try_scope): Remove.
5743         (TRY): Don't use exception_try_scope.
5744         (struct gdb_exception): Add constructor, operator=.
5745         <what>: New method.
5746         (struct gdb_exception_RETURN_MASK_ALL)
5747         (struct gdb_exception_RETURN_MASK_ERROR)
5748         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5749         (struct gdb_quit_bad_alloc): Update.
5750         * common/common-exceptions.c (exception_none): Change
5751         initializer.
5752         (struct catcher) <state, exception>: Initialize inline.
5753         <prev>: Remove member.
5754         (current_catcher): Remove.
5755         (catchers): New global.
5756         (exceptions_state_mc_init): Simplify.
5757         (catcher_pop): Remove.
5758         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5759         (try_scope_depth, exception_try_scope_entry)
5760         (exception_try_scope_exit): Remove.
5761         (throw_exception_sjlj): Update.
5762         (exception_messages, exception_messages_size): Remove.
5763         (throw_it): Simplify.
5764         (gdb_exception_sliced_copy): Remove.
5765         (throw_exception_cxx): Update.
5766         * cli/cli-script.c (script_from_file): Update.
5767         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5768         Update.
5769         * ada-valprint.c (ada_val_print): Update.
5770         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5771         (create_excep_cond_exprs): Update.
5772
5773 2019-04-08  Tom Tromey  <tom@tromey.com>
5774
5775         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5776         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5777         (TRY, CATCH, END_CATCH): Remove some definitions.
5778         * common/common-exceptions.c: Don't use GDB_XCPT.
5779         (catcher_list_size): Remove.
5780         (throw_exception, throw_it): Simplify.
5781
5782 2019-04-05  Tom Tromey  <tom@tromey.com>
5783
5784         Revert the header-sorting patch.
5785         * ft32-tdep.c: Revert.
5786         * frv-tdep.c: Revert.
5787         * frv-linux-tdep.c: Revert.
5788         * frame.c: Revert.
5789         * frame-unwind.c: Revert.
5790         * frame-base.c: Revert.
5791         * fork-child.c: Revert.
5792         * findvar.c: Revert.
5793         * findcmd.c: Revert.
5794         * filesystem.c: Revert.
5795         * filename-seen-cache.h: Revert.
5796         * filename-seen-cache.c: Revert.
5797         * fbsd-tdep.c: Revert.
5798         * fbsd-nat.h: Revert.
5799         * fbsd-nat.c: Revert.
5800         * f-valprint.c: Revert.
5801         * f-typeprint.c: Revert.
5802         * f-lang.c: Revert.
5803         * extension.h: Revert.
5804         * extension.c: Revert.
5805         * extension-priv.h: Revert.
5806         * expprint.c: Revert.
5807         * exec.h: Revert.
5808         * exec.c: Revert.
5809         * exceptions.c: Revert.
5810         * event-top.c: Revert.
5811         * event-loop.c: Revert.
5812         * eval.c: Revert.
5813         * elfread.c: Revert.
5814         * dwarf2read.h: Revert.
5815         * dwarf2read.c: Revert.
5816         * dwarf2loc.c: Revert.
5817         * dwarf2expr.h: Revert.
5818         * dwarf2expr.c: Revert.
5819         * dwarf2-frame.c: Revert.
5820         * dwarf2-frame-tailcall.c: Revert.
5821         * dwarf-index-write.h: Revert.
5822         * dwarf-index-write.c: Revert.
5823         * dwarf-index-common.c: Revert.
5824         * dwarf-index-cache.h: Revert.
5825         * dwarf-index-cache.c: Revert.
5826         * dummy-frame.c: Revert.
5827         * dtrace-probe.c: Revert.
5828         * disasm.h: Revert.
5829         * disasm.c: Revert.
5830         * disasm-selftests.c: Revert.
5831         * dictionary.c: Revert.
5832         * dicos-tdep.c: Revert.
5833         * demangle.c: Revert.
5834         * dcache.h: Revert.
5835         * dcache.c: Revert.
5836         * darwin-nat.h: Revert.
5837         * darwin-nat.c: Revert.
5838         * darwin-nat-info.c: Revert.
5839         * d-valprint.c: Revert.
5840         * d-namespace.c: Revert.
5841         * d-lang.c: Revert.
5842         * ctf.c: Revert.
5843         * csky-tdep.c: Revert.
5844         * csky-linux-tdep.c: Revert.
5845         * cris-tdep.c: Revert.
5846         * cris-linux-tdep.c: Revert.
5847         * cp-valprint.c: Revert.
5848         * cp-support.c: Revert.
5849         * cp-namespace.c: Revert.
5850         * cp-abi.c: Revert.
5851         * corelow.c: Revert.
5852         * corefile.c: Revert.
5853         * continuations.c: Revert.
5854         * completer.h: Revert.
5855         * completer.c: Revert.
5856         * complaints.c: Revert.
5857         * coffread.c: Revert.
5858         * coff-pe-read.c: Revert.
5859         * cli-out.h: Revert.
5860         * cli-out.c: Revert.
5861         * charset.c: Revert.
5862         * c-varobj.c: Revert.
5863         * c-valprint.c: Revert.
5864         * c-typeprint.c: Revert.
5865         * c-lang.c: Revert.
5866         * buildsym.c: Revert.
5867         * buildsym-legacy.c: Revert.
5868         * build-id.h: Revert.
5869         * build-id.c: Revert.
5870         * btrace.c: Revert.
5871         * bsd-uthread.c: Revert.
5872         * breakpoint.h: Revert.
5873         * breakpoint.c: Revert.
5874         * break-catch-throw.c: Revert.
5875         * break-catch-syscall.c: Revert.
5876         * break-catch-sig.c: Revert.
5877         * blockframe.c: Revert.
5878         * block.c: Revert.
5879         * bfin-tdep.c: Revert.
5880         * bfin-linux-tdep.c: Revert.
5881         * bfd-target.c: Revert.
5882         * bcache.c: Revert.
5883         * ax-general.c: Revert.
5884         * ax-gdb.h: Revert.
5885         * ax-gdb.c: Revert.
5886         * avr-tdep.c: Revert.
5887         * auxv.c: Revert.
5888         * auto-load.c: Revert.
5889         * arm-wince-tdep.c: Revert.
5890         * arm-tdep.c: Revert.
5891         * arm-symbian-tdep.c: Revert.
5892         * arm-pikeos-tdep.c: Revert.
5893         * arm-obsd-tdep.c: Revert.
5894         * arm-nbsd-tdep.c: Revert.
5895         * arm-nbsd-nat.c: Revert.
5896         * arm-linux-tdep.c: Revert.
5897         * arm-linux-nat.c: Revert.
5898         * arm-fbsd-tdep.c: Revert.
5899         * arm-fbsd-nat.c: Revert.
5900         * arm-bsd-tdep.c: Revert.
5901         * arch-utils.c: Revert.
5902         * arc-tdep.c: Revert.
5903         * arc-newlib-tdep.c: Revert.
5904         * annotate.h: Revert.
5905         * annotate.c: Revert.
5906         * amd64-windows-tdep.c: Revert.
5907         * amd64-windows-nat.c: Revert.
5908         * amd64-tdep.c: Revert.
5909         * amd64-sol2-tdep.c: Revert.
5910         * amd64-obsd-tdep.c: Revert.
5911         * amd64-obsd-nat.c: Revert.
5912         * amd64-nbsd-tdep.c: Revert.
5913         * amd64-nbsd-nat.c: Revert.
5914         * amd64-nat.c: Revert.
5915         * amd64-linux-tdep.c: Revert.
5916         * amd64-linux-nat.c: Revert.
5917         * amd64-fbsd-tdep.c: Revert.
5918         * amd64-fbsd-nat.c: Revert.
5919         * amd64-dicos-tdep.c: Revert.
5920         * amd64-darwin-tdep.c: Revert.
5921         * amd64-bsd-nat.c: Revert.
5922         * alpha-tdep.c: Revert.
5923         * alpha-obsd-tdep.c: Revert.
5924         * alpha-nbsd-tdep.c: Revert.
5925         * alpha-mdebug-tdep.c: Revert.
5926         * alpha-linux-tdep.c: Revert.
5927         * alpha-linux-nat.c: Revert.
5928         * alpha-bsd-tdep.c: Revert.
5929         * alpha-bsd-nat.c: Revert.
5930         * aix-thread.c: Revert.
5931         * agent.c: Revert.
5932         * addrmap.c: Revert.
5933         * ada-varobj.c: Revert.
5934         * ada-valprint.c: Revert.
5935         * ada-typeprint.c: Revert.
5936         * ada-tasks.c: Revert.
5937         * ada-lang.c: Revert.
5938         * aarch64-tdep.c: Revert.
5939         * aarch64-ravenscar-thread.c: Revert.
5940         * aarch64-newlib-tdep.c: Revert.
5941         * aarch64-linux-tdep.c: Revert.
5942         * aarch64-linux-nat.c: Revert.
5943         * aarch64-fbsd-tdep.c: Revert.
5944         * aarch64-fbsd-nat.c: Revert.
5945         * aarch32-linux-nat.c: Revert.
5946
5947 2019-04-05  Tom Tromey  <tom@tromey.com>
5948
5949         * ft32-tdep.c: Sort headers.
5950         * frv-tdep.c: Sort headers.
5951         * frv-linux-tdep.c: Sort headers.
5952         * frame.c: Sort headers.
5953         * frame-unwind.c: Sort headers.
5954         * frame-base.c: Sort headers.
5955         * fork-child.c: Sort headers.
5956         * findvar.c: Sort headers.
5957         * findcmd.c: Sort headers.
5958         * filesystem.c: Sort headers.
5959         * filename-seen-cache.h: Sort headers.
5960         * filename-seen-cache.c: Sort headers.
5961         * fbsd-tdep.c: Sort headers.
5962         * fbsd-nat.h: Sort headers.
5963         * fbsd-nat.c: Sort headers.
5964         * f-valprint.c: Sort headers.
5965         * f-typeprint.c: Sort headers.
5966         * f-lang.c: Sort headers.
5967         * extension.h: Sort headers.
5968         * extension.c: Sort headers.
5969         * extension-priv.h: Sort headers.
5970         * expprint.c: Sort headers.
5971         * exec.h: Sort headers.
5972         * exec.c: Sort headers.
5973         * exceptions.c: Sort headers.
5974         * event-top.c: Sort headers.
5975         * event-loop.c: Sort headers.
5976         * eval.c: Sort headers.
5977         * elfread.c: Sort headers.
5978         * dwarf2read.h: Sort headers.
5979         * dwarf2read.c: Sort headers.
5980         * dwarf2loc.c: Sort headers.
5981         * dwarf2expr.h: Sort headers.
5982         * dwarf2expr.c: Sort headers.
5983         * dwarf2-frame.c: Sort headers.
5984         * dwarf2-frame-tailcall.c: Sort headers.
5985         * dwarf-index-write.h: Sort headers.
5986         * dwarf-index-write.c: Sort headers.
5987         * dwarf-index-common.c: Sort headers.
5988         * dwarf-index-cache.h: Sort headers.
5989         * dwarf-index-cache.c: Sort headers.
5990         * dummy-frame.c: Sort headers.
5991         * dtrace-probe.c: Sort headers.
5992         * disasm.h: Sort headers.
5993         * disasm.c: Sort headers.
5994         * disasm-selftests.c: Sort headers.
5995         * dictionary.c: Sort headers.
5996         * dicos-tdep.c: Sort headers.
5997         * demangle.c: Sort headers.
5998         * dcache.h: Sort headers.
5999         * dcache.c: Sort headers.
6000         * darwin-nat.h: Sort headers.
6001         * darwin-nat.c: Sort headers.
6002         * darwin-nat-info.c: Sort headers.
6003         * d-valprint.c: Sort headers.
6004         * d-namespace.c: Sort headers.
6005         * d-lang.c: Sort headers.
6006         * ctf.c: Sort headers.
6007         * csky-tdep.c: Sort headers.
6008         * csky-linux-tdep.c: Sort headers.
6009         * cris-tdep.c: Sort headers.
6010         * cris-linux-tdep.c: Sort headers.
6011         * cp-valprint.c: Sort headers.
6012         * cp-support.c: Sort headers.
6013         * cp-namespace.c: Sort headers.
6014         * cp-abi.c: Sort headers.
6015         * corelow.c: Sort headers.
6016         * corefile.c: Sort headers.
6017         * continuations.c: Sort headers.
6018         * completer.h: Sort headers.
6019         * completer.c: Sort headers.
6020         * complaints.c: Sort headers.
6021         * coffread.c: Sort headers.
6022         * coff-pe-read.c: Sort headers.
6023         * cli-out.h: Sort headers.
6024         * cli-out.c: Sort headers.
6025         * charset.c: Sort headers.
6026         * c-varobj.c: Sort headers.
6027         * c-valprint.c: Sort headers.
6028         * c-typeprint.c: Sort headers.
6029         * c-lang.c: Sort headers.
6030         * buildsym.c: Sort headers.
6031         * buildsym-legacy.c: Sort headers.
6032         * build-id.h: Sort headers.
6033         * build-id.c: Sort headers.
6034         * btrace.c: Sort headers.
6035         * bsd-uthread.c: Sort headers.
6036         * breakpoint.h: Sort headers.
6037         * breakpoint.c: Sort headers.
6038         * break-catch-throw.c: Sort headers.
6039         * break-catch-syscall.c: Sort headers.
6040         * break-catch-sig.c: Sort headers.
6041         * blockframe.c: Sort headers.
6042         * block.c: Sort headers.
6043         * bfin-tdep.c: Sort headers.
6044         * bfin-linux-tdep.c: Sort headers.
6045         * bfd-target.c: Sort headers.
6046         * bcache.c: Sort headers.
6047         * ax-general.c: Sort headers.
6048         * ax-gdb.h: Sort headers.
6049         * ax-gdb.c: Sort headers.
6050         * avr-tdep.c: Sort headers.
6051         * auxv.c: Sort headers.
6052         * auto-load.c: Sort headers.
6053         * arm-wince-tdep.c: Sort headers.
6054         * arm-tdep.c: Sort headers.
6055         * arm-symbian-tdep.c: Sort headers.
6056         * arm-pikeos-tdep.c: Sort headers.
6057         * arm-obsd-tdep.c: Sort headers.
6058         * arm-nbsd-tdep.c: Sort headers.
6059         * arm-nbsd-nat.c: Sort headers.
6060         * arm-linux-tdep.c: Sort headers.
6061         * arm-linux-nat.c: Sort headers.
6062         * arm-fbsd-tdep.c: Sort headers.
6063         * arm-fbsd-nat.c: Sort headers.
6064         * arm-bsd-tdep.c: Sort headers.
6065         * arch-utils.c: Sort headers.
6066         * arc-tdep.c: Sort headers.
6067         * arc-newlib-tdep.c: Sort headers.
6068         * annotate.h: Sort headers.
6069         * annotate.c: Sort headers.
6070         * amd64-windows-tdep.c: Sort headers.
6071         * amd64-windows-nat.c: Sort headers.
6072         * amd64-tdep.c: Sort headers.
6073         * amd64-sol2-tdep.c: Sort headers.
6074         * amd64-obsd-tdep.c: Sort headers.
6075         * amd64-obsd-nat.c: Sort headers.
6076         * amd64-nbsd-tdep.c: Sort headers.
6077         * amd64-nbsd-nat.c: Sort headers.
6078         * amd64-nat.c: Sort headers.
6079         * amd64-linux-tdep.c: Sort headers.
6080         * amd64-linux-nat.c: Sort headers.
6081         * amd64-fbsd-tdep.c: Sort headers.
6082         * amd64-fbsd-nat.c: Sort headers.
6083         * amd64-dicos-tdep.c: Sort headers.
6084         * amd64-darwin-tdep.c: Sort headers.
6085         * amd64-bsd-nat.c: Sort headers.
6086         * alpha-tdep.c: Sort headers.
6087         * alpha-obsd-tdep.c: Sort headers.
6088         * alpha-nbsd-tdep.c: Sort headers.
6089         * alpha-mdebug-tdep.c: Sort headers.
6090         * alpha-linux-tdep.c: Sort headers.
6091         * alpha-linux-nat.c: Sort headers.
6092         * alpha-bsd-tdep.c: Sort headers.
6093         * alpha-bsd-nat.c: Sort headers.
6094         * aix-thread.c: Sort headers.
6095         * agent.c: Sort headers.
6096         * addrmap.c: Sort headers.
6097         * ada-varobj.c: Sort headers.
6098         * ada-valprint.c: Sort headers.
6099         * ada-typeprint.c: Sort headers.
6100         * ada-tasks.c: Sort headers.
6101         * ada-lang.c: Sort headers.
6102         * aarch64-tdep.c: Sort headers.
6103         * aarch64-ravenscar-thread.c: Sort headers.
6104         * aarch64-newlib-tdep.c: Sort headers.
6105         * aarch64-linux-tdep.c: Sort headers.
6106         * aarch64-linux-nat.c: Sort headers.
6107         * aarch64-fbsd-tdep.c: Sort headers.
6108         * aarch64-fbsd-nat.c: Sort headers.
6109         * aarch32-linux-nat.c: Sort headers.
6110
6111 2019-04-04  Tom Tromey  <tom@tromey.com>
6112
6113         * varobj.c (varobj_create): Update.
6114         * rust-exp.y (struct rust_parser) <update_innermost_block,
6115         lookup_symbol>: New methods.
6116         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6117         Rename.
6118         (rust_parser::rust_lookup_type)
6119         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6120         * printcmd.c (display_command, do_one_display): Update.
6121         * parser-defs.h (struct parser_state) <parser_state>: Add
6122         "tracker" parameter.
6123         (block_tracker): New member.
6124         (class innermost_block_tracker) <innermost_block_tracker>: Add
6125         "types" parameter.
6126         <reset>: Remove method.
6127         (innermost_block): Don't declare.
6128         (null_post_parser): Update.
6129         * parse.c (innermost_block): Remove global.
6130         (write_dollar_variable): Update.
6131         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6132         Remove "tracker_types" parameter.
6133         (parse_expression): Add "tracker" parameter.
6134         (parse_expression_for_completion): Update.
6135         (null_post_parser): Add "tracker" parameter.
6136         * p-exp.y: Update rules.
6137         * m2-exp.y: Update rules.
6138         * language.h (struct language_defn) <la_post_parser>: Add
6139         "tracker" parameter.
6140         * go-exp.y: Update rules.
6141         * f-exp.y: Update rules.
6142         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6143         parameter.
6144         * d-exp.y: Update rules.
6145         * c-exp.y: Update rules.
6146         * breakpoint.c (set_breakpoint_condition): Create an
6147         innermost_block_tracker.
6148         (watch_command_1): Likewise.
6149         * ada-lang.c (resolve): Add "tracker" parameter.
6150         (resolve_subexp): Likewise.
6151         * ada-exp.y (write_var_from_sym): Update.
6152
6153 2019-04-04  Tom Tromey  <tom@tromey.com>
6154
6155         * type-stack.h: New file.
6156         * type-stack.c: New file.
6157         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6158         type-stack.h.
6159         (insert_into_type_stack, insert_type, push_type, push_type_int)
6160         (insert_type_address_space, pop_type, pop_type_int)
6161         (pop_typelist, pop_type_stack, append_type_stack)
6162         (push_type_stack, get_type_stack, push_typelist)
6163         (follow_type_instance_flags, follow_types): Don't declare.
6164         * parse.c (type_stack): Remove global.
6165         (parse_exp_in_context): Update.
6166         (insert_into_type_stack, insert_type, push_type, push_type_int)
6167         (insert_type_address_space, pop_type, pop_type_int)
6168         (pop_typelist, pop_type_stack, append_type_stack)
6169         (push_type_stack, get_type_stack, push_typelist)
6170         (follow_type_instance_flags, follow_types): Remove (moved to
6171         type-stack.c).
6172         * f-exp.y (type_stack): New global.
6173         Update rules.
6174         (push_kind_type, f_parse): Update.
6175         * d-exp.y (type_stack): New global.
6176         Update rules.
6177         (d_parse): Update.
6178         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6179         Update rules.
6180         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6181         (HFILES_NO_SRCDIR): Add type-stack.h.
6182
6183 2019-04-04  Tom Tromey  <tom@tromey.com>
6184
6185         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6186         (rust_parser::convert_ast_to_expression, rust_parse)
6187         (rust_lex_test_completion, rust_lex_tests): Update.
6188         * parser-defs.h (struct expr_completion_state): New.
6189         (struct parser_state) <parser_state>: Add completion parameter.
6190         <mark_struct_expression, mark_completion_tag>: New methods.
6191         <parse_completion, m_completion_state>: New members.
6192         (prefixify_expression, null_post_parser): Update.
6193         (mark_struct_expression, mark_completion_tag): Don't declare.
6194         * parse.c (parse_completion, expout_last_struct)
6195         (expout_tag_completion_type, expout_completion_name): Remove
6196         globals.
6197         (parser_state::mark_struct_expression)
6198         (parser_state::mark_completion_tag): Now methods.
6199         (prefixify_expression): Add last_struct parameter.
6200         (prefixify_subexp): Likewise.
6201         (parse_exp_1): Update.
6202         (parse_exp_in_context): Add cstate parameter.  Update.
6203         (parse_expression_for_completion): Create an
6204         expr_completion_state.
6205         (null_post_parser): Add "completion" parameter.
6206         * p-exp.y: Update rules.
6207         (yylex): Update.
6208         * language.h (struct language_defn) <la_post_parser>: Add
6209         "completing" parameter.
6210         * go-exp.y: Update rules.
6211         (lex_one_token): Update.
6212         * expression.h (parse_completion): Don't declare.
6213         * d-exp.y: Update rules.
6214         (lex_one_token): Update rules.
6215         * c-exp.y: Update rules.
6216         (lex_one_token): Update.
6217         * ada-lang.c (resolve): Add "parse_completion" parameter.
6218         (resolve_subexp): Likewise.
6219         (ada_resolve_function): Likewise.
6220
6221 2019-04-04  Tom Tromey  <tom@tromey.com>
6222
6223         * parser-defs.h (struct parser_state) <start_arglist,
6224         end_arglist>: New methods.
6225         <arglist_len, m_funcall_chain>: New members.
6226         (arglist_len, start_arglist, end_arglist): Don't declare.
6227         * parse.c (arglist_len, funcall_chain): Remove global.
6228         (start_arglist, end_arglist): Remove functions.
6229         (parse_exp_in_context): Update.
6230         * p-exp.y: Update rules.
6231         * m2-exp.y: Update rules.
6232         * go-exp.y: Update rules.
6233         * f-exp.y: Update rules.
6234         * d-exp.y: Update rules.
6235         * c-exp.y: Update rules.
6236
6237 2019-04-04  Tom Tromey  <tom@tromey.com>
6238
6239         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6240         lex_operator, push_back>: New methods.
6241         Update all rules.
6242         (rust_parser::lex_hex, lex_escape): Rename and update.
6243         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6244         (rust_parser::lex_operator): Rename and update.
6245         (rust_parser::lex_number, rustyylex, rustyyerror)
6246         (rust_lex_test_init, rust_lex_test_sequence)
6247         (rust_lex_test_push_back, rust_lex_tests): Update.
6248         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6249         parameter.
6250         <lexptr, prev_lexptr>: New members.
6251         (lexptr, prev_lexptr): Don't declare.
6252         * parse.c (lexptr, prev_lexptr): Remove globals.
6253         (parse_exp_in_context): Update.
6254         * p-exp.y (yylex, yyerror): Update.
6255         * m2-exp.y (parse_number, yylex, yyerror): Update.
6256         * go-exp.y (lex_one_token, yyerror): Update.
6257         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6258         * d-exp.y (lex_one_token, yyerror): Update.
6259         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6260         (lex_one_token, yyerror): Update.
6261         * ada-lex.l (YY_INPUT): Update.
6262         (rewind_to_char): Update.
6263         * ada-exp.y (yyerror): Update.
6264
6265 2019-04-04  Tom Tromey  <tom@tromey.com>
6266
6267         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6268         * parser-defs.h (struct parser_state) <parser_state>: Add new
6269         parameter.
6270         <comma_terminates>: New member.
6271         (comma_terminates): Don't declare global.
6272         * parse.c (comma_terminates): Remove global.
6273         (parse_exp_in_context): Update.
6274         * p-exp.y (yylex): Update.
6275         * m2-exp.y (yylex): Update.
6276         * go-exp.y (lex_one_token): Update.
6277         * f-exp.y (yylex): Update.
6278         * d-exp.y (lex_one_token): Update.
6279         * c-exp.y (lex_one_token): Update.
6280         * ada-lex.l: Update.
6281
6282 2019-04-04  Tom Tromey  <tom@tromey.com>
6283
6284         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6285         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6286         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6287         * parser-defs.h (paren_depth): Don't declare.
6288         * parse.c (paren_depth): Remove global.
6289         (parse_exp_in_context): Update.
6290         * p-exp.y (paren_depth): New global.
6291         (pascal_parse): Initialize it.
6292         * m2-exp.y (paren_depth): New global.
6293         (m2_parse): Initialize it.
6294         * go-exp.y (paren_depth): New global.
6295         (go_parse): Initialize it.
6296         * f-exp.y (paren_depth): New global.
6297         (f_parse): Initialize it.
6298         * d-exp.y (paren_depth): New global.
6299         (d_parse): Initialize it.
6300         * c-exp.y (paren_depth): New global.
6301         (c_parse): Initialize it.
6302         * ada-lex.l (paren_depth): New global.
6303         (lexer_init): Initialize it.
6304
6305 2019-04-04  Tom Tromey  <tom@tromey.com>
6306
6307         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6308         (rust_parser::convert_ast_to_type)
6309         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6310         * parser-defs.h (struct parser_state) <parser_state>: Add
6311         parameters.  Initialize new members.
6312         <expression_context_block, expression_context_pc>: New members.
6313         * parse.c (expression_context_block, expression_context_pc):
6314         Remove globals.
6315         (parse_exp_in_context): Update.
6316         * p-exp.y: Update all rules.
6317         (yylex): Update.
6318         * m2-exp.y: Update all rules.
6319         (yylex): Update.
6320         * go-exp.y (yylex): Update.
6321         * f-exp.y (yylex): Update.
6322         * d-exp.y: Update all rules.
6323         (yylex): Update.
6324         * c-exp.y: Update all rules.
6325         (lex_one_token, classify_name, yylex, c_parse): Update.
6326         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6327
6328 2019-04-04  Tom Tromey  <tom@tromey.com>
6329
6330         * gdbarch.h, gdbarch.c: Rebuild.
6331         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6332         * stap-probe.h:
6333         (struct stap_parse_info): Replace "parser_state" with
6334         "expr_builder".
6335         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6336         (parser_state): New class.
6337         * parse.c (expr_builder): Rename.
6338         (expr_builder::release): Rename.
6339         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6340         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6341         (write_exp_elt_longcst, write_exp_elt_floatcst)
6342         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6343         (write_exp_string_vector, write_exp_bitstring)
6344         (write_exp_msymbol, mark_struct_expression)
6345         (write_dollar_variable)
6346         (insert_type_address_space, increase_expout_size): Replace
6347         "parser_state" with "expr_builder".
6348         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6349         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6350         "parser_state" with "expr_builder".
6351
6352 2019-04-04  Tom Tromey  <tom@tromey.com>
6353
6354         * rust-exp.y: Replace "parse_language" with method call.
6355         * p-exp.y:
6356         (yylex): Replace "parse_language" with method call.
6357         * m2-exp.y:
6358         (yylex): Replace "parse_language" with method call.
6359         * go-exp.y (classify_name): Replace "parse_language" with method
6360         call.
6361         * f-exp.y (yylex): Replace "parse_language" with method call.
6362         * d-exp.y (lex_one_token): Replace "parse_language" with method
6363         call.
6364         * c-exp.y:
6365         (lex_one_token, classify_name, yylex): Replace "parse_language"
6366         with method call.
6367         * ada-exp.y (find_primitive_type, type_char)
6368         (type_system_address): Replace "parse_language" with method call.
6369
6370 2019-04-04  Tom Tromey  <tom@tromey.com>
6371
6372         * rust-exp.y: Replace "parse_gdbarch" with method call.
6373         * parse.c (write_dollar_variable, insert_type_address_space):
6374         Replace "parse_gdbarch" with method call.
6375         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6376         call.
6377         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6378         call.
6379         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6380         "parse_gdbarch" with method call.
6381         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6382         with method call.
6383         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6384         "parse_gdbarch" with method call.
6385         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6386         "parse_gdbarch" with method call.
6387         * c-exp.y (parse_type, parse_number, classify_name): Replace
6388         "parse_gdbarch" with method call.
6389         * ada-lex.l: Replace "parse_gdbarch" with method call.
6390         * ada-exp.y (parse_type, find_primitive_type, type_char)
6391         (type_system_address): Replace "parse_gdbarch" with method call.
6392
6393 2019-04-04  Tom Tromey  <tom@tromey.com>
6394
6395         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6396         * stap-probe.c (stap_parse_argument): Update.
6397         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6398         initial_size parameter.
6399         * rust-exp.y (rust_lex_tests): Update.
6400         * parse.c (parser_state): Update.
6401         (parse_exp_in_context): Update.
6402         * parser-defs.h (struct parser_state) <parser_state>: Remove
6403         "initial_size" parameter.
6404
6405 2019-04-04  Tom Tromey  <tom@tromey.com>
6406
6407         * parser-defs.h (increase_expout_size): Don't declare.
6408         * parse.c (increase_expout_size): Now static.
6409
6410 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6411
6412         * gnu-nat.c (gnu_nat_target::wait): Fix
6413         target_waitstatus_to_string call.
6414
6415 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * eval.c (evaluate_subexp_standard): Handle internal functions
6418         during Fortran function call handling.
6419
6420 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * NEWS: Mention new internal functions.
6423         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6424         (read_base_type): Use dwarf2_init_complex_target_type.
6425         * value.c (creal_internal_fn): New function.
6426         (cimag_internal_fn): New function.
6427         (_initialize_values): Register new internal functions.
6428
6429 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6430
6431         * infrun.c (stop_all_threads): If debug_infrun, always
6432         trace the wait status after wait_one, using
6433         target_waitstatus_to_string and target_pid_to_str.
6434         (handle_inferior_event): Replace various trace of
6435         wait status kind by a single trace.
6436         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6437         wait status kind image by target_waitstatus_to_string.
6438         * target/waitstatus.c (target_waitstatus_to_string): Fix
6439         obsolete comment.
6440
6441 2019-04-01  Tom Tromey  <tromey@adacore.com>
6442
6443         PR symtab/23331:
6444         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6445
6446 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6447             Pedro Alves  <palves@redhat.com>
6448
6449         * top.c (quit_force): Call 'finalize_values'.
6450         * value.c (finalize_values): New function.
6451         * value.h (finalize_values): Declare.
6452
6453 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6454
6455         * NEWS: Announce $_gdb_major and $_gdb_minor.
6456
6457         * top.c (init_gdb_version_vars): New function.
6458         (gdb_init): Call init_gdb_version_vars.
6459
6460 2019-03-29  Tom Tromey  <tromey@adacore.com>
6461
6462         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6463         help text.  Remove dead code.
6464
6465 2019-03-29  Keith Seitz  <keiths@redhat.com>
6466
6467         From Siddhesh Poyarekar:
6468         * f-lang.h (f77_get_upperbound): Return LONGEST.
6469         (f77_get_lowerbound): Likewise.
6470         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6471         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6472         print them.
6473         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6474         plongest to format print it.
6475         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6476         (f77_get_upperbound): Likewise.
6477         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6478         LOWER_BOUND to LONGEST.
6479         (f77_create_arrayprint_offset_tbl): Likewise.
6480
6481 2019-03-29  Keith Seitz  <keiths@redhat.com>
6482
6483         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6484         %s/pulongest for TYPE_LENGTH instead of %d in format
6485         strings.
6486         * ada-typerint.c (ada_print_type): Likewise.
6487         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6488         * compile/compile-c-support.c (generate_register_struct): Likewise.
6489         * gdbtypes.c (recursive_dump_type): Likewise.
6490         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6491         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6492         instead of %d in format strings.
6493         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6494         to std::min to ULONGEST.
6495         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6496         instead of %d in format strings.
6497         * tracepoint.c (info_scope_command): Likewise.
6498         * typeprint.c (print_offset_data::update)
6499         (print_offset_data::finish): Likewise.
6500         * xtensa-tdep.c (xtensa_store_return_value)
6501         (xtensa_push_dummy_call): Likewise.
6502
6503 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6504
6505         * windows-nat.c (display_selector): Fixed format specifications
6506         for 64-bit Cygwin.
6507
6508 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6509
6510         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6511
6512 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6513
6514         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6515         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6516         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6517         (nios2_linux_init_abi): Install it.
6518
6519 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6520
6521         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6522
6523 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6524
6525         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6526
6527 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6528             Tom Tromey  <tromey@adacore.com>
6529
6530         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6531
6532 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6533
6534         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6535         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6536         method to compute the bounds of range types. Also print "[evaluated]"
6537         if the bounds' values come from a dynamic evaluation.
6538
6539 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6542         whitespace when pretty printing is on.
6543
6544 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6545
6546         * ppc-linux-nat.c: Add include.
6547
6548 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6549
6550         * NEWS: Mention AArch64 Pointer Authentication.
6551
6552 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * arm-linux-nat.c: Add include.
6555
6556 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6557
6558         * source-cache.c (source_cache::get_source_lines): Re-read
6559         fullname after calling open_source_file.
6560
6561 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6562
6563         * NEWS: Mention TLS support for FreeBSD.
6564
6565 2019-03-25  Tom Tromey  <tromey@adacore.com>
6566
6567         * minsyms.c (BUNCH_SIZE): Update comment.
6568         (~minimal_symbol_reader): Remove old comment.
6569         (compact_minimal_symbols): Update comment.
6570         (minimal_symbol_reader::install): Remove old comment.  Update
6571         other comments.
6572
6573 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6574
6575         * s390-linux-nat.c: Add include.
6576
6577 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6578
6579         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6580         Call linux_get_hwcap.
6581         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6582         Likewise.
6583         (aarch64_linux_get_hwcap): Remove function.
6584         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6585         declaration.
6586         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6587         linux_get_hwcap.
6588         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6589         * linux-tdep.c (linux_get_hwcap): Add function.
6590         (linux_get_hwcap2): Likewise.
6591         * linux-tdep.h (linux_get_hwcap): Add declaration.
6592         (linux_get_hwcap2): Likewise.
6593         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6594         (ppc_linux_get_hwcap2): Likewise.
6595         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6596         linux_get_hwcap.
6597         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6598         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6599         (ppc_linux_nat_target::read_description): Likewise.
6600         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6601         * s390-linux-nat.c: Likewise.
6602         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6603
6604 2019-03-24  Tom Tromey  <tom@tromey.com>
6605
6606         * ada-lang.c (standard_lookup): Simplify initialization.
6607         (ada_lookup_symbol_nonlocal): Simplify return.
6608         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6609         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6610         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6611         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6612         initialization.
6613         * solib.c (solib_global_lookup): Simplify.
6614         * symtab.c (null_block_symbol): Remove.
6615         (symbol_cache_lookup): Simplify returns.
6616         (lookup_language_this): Simplify returns.
6617         (lookup_symbol_aux): Simplify return.
6618         (lookup_local_symbol): Simplify returns.
6619         (lookup_global_symbol_from_objfile): Simplify return.
6620         (lookup_symbol_in_objfile_symtabs)
6621         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6622         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6623         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6624         * cp-namespace.c (cp_lookup_bare_symbol)
6625         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6626         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6627         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6628         (cp_lookup_symbol_via_imports): Simplify initialization.
6629         (find_symbol_in_baseclass): Likewise.
6630         * symtab.h (null_block_symbol): Remove.
6631         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6632         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6633         (d_lookup_symbol_module): Likewise.
6634         (find_symbol_in_baseclass): Simplify initialization.
6635
6636 2019-03-24  Tom Tromey  <tom@tromey.com>
6637
6638         * expression.h: Don't include symtab.h.
6639         (struct block): Forward declare.
6640
6641 2019-03-24  Tom Tromey  <tom@tromey.com>
6642
6643         * c-exp.y (typebase): Remove casts.
6644         * gdbtypes.c (lookup_unsigned_typename, )
6645         (lookup_signed_typename): Remove cast.
6646         * eval.c (parse_to_comma_and_eval): Remove cast.
6647         * parse.c (write_dollar_variable): Remove cast.
6648         * block.h (struct block) <superblock>: Now const.
6649         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6650         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6651         (map_block): Make "block" const.
6652         * symfile.h (struct quick_symbol_functions)
6653         <map_matching_symbols>: Constify block argument to "callback".
6654         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6655         const.
6656         (find_pc_sect_compunit_symtab): Make "b" const.
6657         (find_symbol_at_address): Likewise.
6658         (search_symbols): Likewise.
6659         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6660         (dw2_debug_names_lookup_symbol): Likewise.
6661         (dw2_map_matching_symbols): Update.
6662         * p-valprint.c (pascal_val_print): Remove "block".
6663         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6664         (aux_add_nonlocal_symbols): Make "block" const.
6665         (resolve_subexp): Remove cast.
6666         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6667         const.
6668         (iterate_over_file_blocks): Likewise.
6669         * f-exp.y (%union) <bval>: Remove.
6670         * coffread.c (patch_opaque_types): Make "b" const.
6671         * spu-tdep.c (spu_catch_start): Make "block" const.
6672         * c-valprint.c (print_unpacked_pointer): Remove "block".
6673         * symmisc.c (dump_symtab_1): Make "b" const.
6674         (block_depth): Make "block" const.
6675         * d-exp.y (%union) <bval>: Remove.
6676         * cp-support.h (cp_lookup_rtti_type): Update.
6677         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6678         * psymtab.c (psym_lookup_symbol): Make "block" const.
6679         (maintenance_check_psymtabs): Make "b" const.
6680         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6681         (enumerate_locals, enumerate_args): Update.
6682         * python/py-symtab.c (stpy_global_block): Make "block" const.
6683         (stpy_static_block): Likewise.
6684         * inline-frame.c (block_starting_point_at): Make "new_block"
6685         const.
6686         * block.c (find_block_in_blockvector): Make return type const.
6687         (blockvector_for_pc_sect): Make "b" const.
6688         (find_block_in_blockvector): Make "b" const.
6689
6690 2019-03-23  Tom Tromey  <tom@tromey.com>
6691
6692         * varobj.c (varobj_create): Update.
6693         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6694         * printcmd.c (display_command, do_one_display): Don't reset
6695         innermost_block.
6696         * parser-defs.h (enum innermost_block_tracker_type): Move to
6697         expression.h.
6698         (innermost_block): Update comment.
6699         * parse.c (parse_exp_1): Add tracker_types parameter.
6700         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6701         tracker_types parameter.  Reset innermost_block.
6702         (parse_exp_in_context): Remove.
6703         (parse_expression_for_completion): Update.
6704         * objfiles.c (~objfile): Don't reset expression_context_block or
6705         innermost_block.
6706         * expression.h (enum innermost_block_tracker_type): Move from
6707         parser-defs.h.
6708         (parse_exp_1): Add tracker_types parameter.
6709         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6710         reset innermost_block.
6711
6712 2019-03-23  Tom Tromey  <tom@tromey.com>
6713
6714         * objfiles.h: Include bcache.h.
6715
6716 2019-03-23  Tom Tromey  <tom@tromey.com>
6717
6718         * linespec.c (get_current_search_block): Use
6719         scoped_restore_current_language.
6720         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6721
6722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6723             Jiong Wang  <jiong.wang@arm.com>
6724
6725         * aarch64-linux-tdep.c
6726         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6727         section.
6728         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6729
6730 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6731             Jiong Wang  <jiong.wang@arm.com>
6732
6733         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6734         instructions.
6735         (aarch64_analyze_prologue_test): Add PACIASP test.
6736         (aarch64_prologue_prev_register): Unmask PC value.
6737
6738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6739             Jiong Wang  <jiong.wang@arm.com>
6740
6741         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6742         (aarch64_dwarf2_prev_register): Unmask PC value.
6743         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6744         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6745         DW_CFA_AARCH64_negate_ra_state.
6746         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6747
6748 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6749             Jiong Wang  <jiong.wang@arm.com>
6750
6751         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6752         registers.
6753         (aarch64_pseudo_register_name): Likewise.
6754         (aarch64_pseudo_register_type): Likewise.
6755         (aarch64_pseudo_register_reggroup_p): Likewise.
6756         (aarch64_gdbarch_init): Add pauth registers.
6757         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6758         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6759         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6760         (struct gdbarch_tdep): Add regnum for ra_state.
6761
6762 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6763             Jiong Wang  <jiong.wang@arm.com>
6764
6765         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6766
6767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6768             Jiong Wang  <jiong.wang@arm.com>
6769
6770         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6771         function.
6772         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6773         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6774         (aarch64_gdbarch_init): Add puth registers.
6775         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6776         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6777         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6778
6779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6780             Jiong Wang  <jiong.wang@arm.com>
6781
6782         * aarch64-linux-nat.c
6783         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6784         * aarch64-linux-tdep.c
6785         (aarch64_linux_core_read_description): Likewise.
6786         (aarch64_linux_get_hwcap): New function.
6787         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6788         (aarch64_linux_get_hwcap): New declaration.
6789
6790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6791             Jiong Wang  <jiong.wang@arm.com>
6792
6793         * aarch64-linux-nat.c
6794         (aarch64_linux_nat_target::read_description): Add pauth param.
6795         * aarch64-linux-tdep.c
6796         (aarch64_linux_core_read_description): Likewise.
6797         * aarch64-tdep.c (struct target_desc): Add in pauth.
6798         (aarch64_read_description): Add pauth param.
6799         (aarch64_gdbarch_init): Likewise.
6800         * aarch64-tdep.h (aarch64_read_description): Likewise.
6801         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6802         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6803         * features/Makefile: Add new files.
6804         * features/aarch64-pauth.c: New file.
6805         * features/aarch64-pauth.xml: New file.
6806
6807 2019-03-20  Tom Tromey  <tromey@adacore.com>
6808
6809         * infrun.c (handle_inferior_event): Rename from
6810         handle_inferior_event_1.  Create a scoped_value_mark.
6811         (handle_inferior_event): Remove.
6812
6813 2019-03-19  Tom Tromey  <tromey@adacore.com>
6814
6815         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6816         * infrun.h (print_stop_event): Add "displays" parameter.
6817         * infrun.c (print_stop_event): Add "displays" parameter.
6818
6819 2019-03-19  Pedro Alves  <palves@redhat.com>
6820
6821         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6822         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6823         to -1.  Fix TABs vs spaces.
6824         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6825         * tui/tui-out.h (tui_ui_out) Add intro comments.
6826         <m_line, m_start_of_line>: In-class initialize, and add describing
6827         comment.
6828
6829 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6830
6831         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6832         variable names.
6833         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6834
6835 2019-03-18  Pedro Alves  <palves@redhat.com>
6836             Eli Zaretskii <eliz@gnu.org>
6837
6838         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6839         m_line and m_start_of_line.
6840
6841 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6842
6843         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6844         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6845         it returns a newline.  This fixes a regression in TU mode, whereby
6846         the next line is output on the same screen line as the user input.
6847
6848 2019-03-18  Tom Tromey  <tromey@adacore.com>
6849
6850         * minsyms.c (minimal_symbol_reader::install): Remove call to
6851         obstack_blank.
6852
6853 2019-03-18  Pedro Alves  <palves@redhat.com>
6854
6855         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6856         New globals.
6857         (apply_style): New, factored out from ...
6858         (apply_ansi_escape): ... this.  Handle reverse video mode.
6859         (tui_set_reverse_mode): New function.
6860         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6861         * tui/tui-winsource.c (tui_show_source_line): Use
6862         tui_set_reverse_mode instead of setting A_STANDOUT.
6863         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6864         New setter methods.
6865
6866 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6867
6868         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6869         Handle tabs.
6870
6871 2019-03-18  Tom Tromey  <tromey@adacore.com>
6872
6873         * ada-lang.c (empty_array): Add "high" parameter.
6874         (ada_evaluate_subexp): Update.
6875
6876 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6877
6878         * unittests/string_view-selftests.c: Define
6879         _initialize_string_view_selftests unconditionally.
6880
6881 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6882
6883         PR gdb/24350
6884         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6885
6886 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6887
6888         PR gdb/24351
6889         * windows-nat.c (display_selector): Fix format specifiers.
6890
6891 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6892
6893         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6894         tui_refill_source_window instead of tui_refresh_win, to update the
6895         current execution line.  This fixes redisplay of the current line
6896         when stepping through the code with "next" or "step".
6897
6898 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6899
6900         * source-cache.c (source_cache::get_source_lines): Call
6901         find_source_lines to initialize s->nlines.  This fixes vertical
6902         scrolling of TUI source window when the DOWN arrow is pressed.
6903
6904 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6905
6906         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6907         linux-thread-db.c (_initialize_thread_db): Likewise.
6908
6909 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6910
6911         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6912         wclrtoeol in tui_show_source_line".  This reverts changes made in
6913         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6914
6915 2019-03-15  Tom Tromey  <tom@tromey.com>
6916
6917         * symtab.h (struct minimal_symbol): Derive from
6918         general_symbol_info.
6919         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6920         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6921         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6922         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6923         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6924         (MSYMBOL_SEARCH_NAME): Update.
6925         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6926         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6927         * minsyms.c (minimal_symbol_reader::record_full): Update.
6928
6929 2019-03-15  Tom Tromey  <tom@tromey.com>
6930
6931         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6932
6933 2019-03-15  Tom Tromey  <tom@tromey.com>
6934
6935         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6936         unique_xmalloc_ptr.
6937         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6938         Update.
6939         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6940         (build_minimal_symbol_hash_tables)
6941         (minimal_symbol_reader::install): Update.
6942
6943 2019-03-15  Tom Tromey  <tom@tromey.com>
6944
6945         * symtab.c (create_demangled_names_hash): Update.
6946         (symbol_set_names): Update.
6947         * objfiles.h (struct objfile_per_bfd_storage)
6948         <demangled_names_hash>: Now an htab_up.
6949         * objfiles.c (objfile_per_bfd_storage): Simplify.
6950
6951 2019-03-15  Tom Tromey  <tom@tromey.com>
6952
6953         * objfiles.h (struct objfile_per_bfd_storage): Declare
6954         destructor.
6955         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6956         New.
6957         (get_objfile_bfd_data): Use new.  Don't initialize
6958         language_of_main.
6959         (free_objfile_per_bfd_storage): Remove.
6960         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6961
6962 2019-03-15  Tom Tromey  <tom@tromey.com>
6963
6964         * symfile.c (reread_symbols): Update.
6965         * objfiles.c (objfile::objfile): Update.
6966         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6967         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6968         comment.
6969         (minimal_symbol_reader::install): Update.
6970         (terminate_minimal_symbol_table): Remove.
6971         * jit.c (jit_object_close_impl): Update.
6972
6973 2019-03-15  Tom Tromey  <tom@tromey.com>
6974
6975         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6976         initializations.
6977
6978 2019-03-15  Tom Tromey  <tom@tromey.com>
6979
6980         * objfiles.h (struct objfile_per_bfd_storage)
6981         <demangled_hash_languages>: Now a bitset.
6982         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6983         (lookup_minimal_symbol): Update.
6984
6985 2019-03-15  Tom Tromey  <tom@tromey.com>
6986
6987         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6988         Don't return the symbol.
6989         * coffread.c (record_minimal_symbol): Use record_full.
6990
6991 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6992
6993         The MS-Windows port of ncurses fails to switch to a color pair if
6994         one or both of the colors are the implicit default colors.  This
6995         change records the default colors when TUI is initialized, and
6996         then specifies them explicitly when a color pair uses the default
6997         colors.  This allows color styling in TUI mode on MS-Windows.
6998
6999         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7000         ncurses_norm_attr.
7001         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7002         colors in ncurses_norm_attr.
7003         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7004         "none", replace it with the default color recorded in
7005         ncurses_norm_attr.
7006
7007 2019-03-14  Tom Tromey  <tromey@adacore.com>
7008
7009         * source-cache.h (class source_cache) <get_source_lines>: Return
7010         std::string.
7011         * source-cache.c (source_cache::extract_lines): Handle case where
7012         first_pos==npos.  Return std::string.
7013         (source_cache::get_source_lines): Update.
7014
7015 2019-03-14  Tom Tromey  <tromey@adacore.com>
7016
7017         * NEWS: Add item for "style sources" commands.
7018         * source-cache.c (source_cache::get_source_lines): Check
7019         source_styling.
7020         * cli/cli-style.c (source_styling): New global.
7021         (_initialize_cli_style): Add "style sources" commands.
7022         (show_style_sources): New function.
7023         * cli/cli-style.h (source_styling): Declare.
7024
7025 2019-03-14  Pedro Alves  <palves@redhat.com>
7026             Tom Tromey  <tromey@adacore.com>
7027
7028         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7029         * tui/tui-winsource.c (tui_refill_source_window): New function,
7030         from...
7031         (tui_horizontal_source_scroll): ... here.  Move some logic.
7032         * cli/cli-style.c (set_style_enabled): Notify new observable.
7033         * tui/tui-hooks.c (tui_redisplay_source): New function.
7034         (tui_attach_detach_observers): Attach or detach
7035         tui_redisplay_source.
7036         * observable.h (source_styling_changed): New observable.
7037         * observable.c: Define source_styling_changed observable.
7038
7039 2019-03-13  Tom Tromey  <tromey@adacore.com>
7040
7041         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7042         (i386_gnu_nat_target::store_registers): Update.
7043         * target-debug.h (target_debug_print_std_string): New macro.
7044         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7045         * windows-tdep.c (display_one_tib): Update.
7046         * tui/tui-stack.c (tui_make_status_line): Update.
7047         * top.c (print_inferior_quit_action): Update.
7048         * thread.c (thr_try_catch_cmd): Update.
7049         (add_thread_with_info): Update.
7050         (thread_target_id_str): Update.
7051         (thr_try_catch_cmd): Update.
7052         (thread_command): Update.
7053         (thread_find_command): Update.
7054         * record-btrace.c (record_btrace_target::info_record)
7055         (record_btrace_resume_thread, record_btrace_target::resume)
7056         (record_btrace_cancel_resume, record_btrace_step_thread)
7057         (record_btrace_target::wait, record_btrace_target::wait)
7058         (record_btrace_target::wait, record_btrace_target::stop): Update.
7059         * progspace.c (print_program_space): Update.
7060         * process-stratum-target.c
7061         (process_stratum_target::thread_address_space): Update.
7062         * linux-fork.c (linux_fork_mourn_inferior)
7063         (detach_checkpoint_command, info_checkpoints_command)
7064         (linux_fork_context): Update.
7065         (linux_fork_detach): Update.
7066         (class scoped_switch_fork_info): Update.
7067         (delete_checkpoint_command): Update.
7068         * infrun.c (follow_fork_inferior): Update.
7069         (follow_fork_inferior): Update.
7070         (proceed_after_vfork_done): Update.
7071         (handle_vfork_child_exec_or_exit): Update.
7072         (follow_exec): Update.
7073         (displaced_step_prepare_throw): Update.
7074         (displaced_step_restore): Update.
7075         (start_step_over): Update.
7076         (resume_1): Update.
7077         (clear_proceed_status_thread): Update.
7078         (proceed): Update.
7079         (print_target_wait_results): Update.
7080         (do_target_wait): Update.
7081         (context_switch): Update.
7082         (stop_all_threads): Update.
7083         (restart_threads): Update.
7084         (finish_step_over): Update.
7085         (handle_signal_stop): Update.
7086         (switch_back_to_stepped_thread): Update.
7087         (keep_going_pass_signal): Update.
7088         (print_exited_reason): Update.
7089         (normal_stop): Update.
7090         * inferior.c (inferior_pid_to_str): Change return type.
7091         (print_selected_inferior): Update.
7092         (add_inferior): Update.
7093         (detach_inferior): Update.
7094         * dummy-frame.c (fprint_dummy_frames): Update.
7095         * dcache.c (dcache_info_1): Update.
7096         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7097         (btrace_fetch, btrace_clear): Update.
7098         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7099         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7100         type.
7101         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7102         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7103         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7104         * gdbarch.c, gdbarch.h: Rebuild.
7105         * gdbarch.sh (core_pid_to_str): Change return type.
7106         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7107         return type.
7108         (windows_nat_target::pid_to_str): Change return type.
7109         (windows_delete_thread): Update.
7110         (windows_nat_target::attach): Update.
7111         (windows_nat_target::files_info): Update.
7112         * target-delegates.c: Rebuild.
7113         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7114         return type.
7115         (sol_thread_target::pid_to_str): Change return type.
7116         * remote.c (class remote_target) <pid_to_str>: Change return
7117         type.
7118         (remote_target::pid_to_str): Change return type.
7119         (extended_remote_target::attach, remote_target::remote_stop_ns)
7120         (remote_target::remote_notif_remove_queued_reply)
7121         (remote_target::push_stop_reply, remote_target::disable_btrace):
7122         Update.
7123         (extended_remote_target::attach): Update.
7124         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7125         type.
7126         (gdbsim_target::pid_to_str): Change return type.
7127         * ravenscar-thread.c (struct ravenscar_thread_target)
7128         <pid_to_str>: Change return type.
7129         (ravenscar_thread_target::pid_to_str): Change return type.
7130         * procfs.c (class procfs_target) <pid_to_str>: Change return
7131         type.
7132         (procfs_target::pid_to_str): Change return type.
7133         (procfs_target::attach): Update.
7134         (procfs_target::detach): Update.
7135         (procfs_target::fetch_registers): Update.
7136         (procfs_target::store_registers): Update.
7137         (procfs_target::wait): Update.
7138         (procfs_target::files_info): Update.
7139         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7140         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7141         return type.
7142         (nto_procfs_target::pid_to_str): Change return type.
7143         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7144         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7145         return type.
7146         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7147         (exit_lwp): Update.
7148         (attach_proc_task_lwp_callback, get_detach_signal)
7149         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7150         (linux_nat_target::resume, wait_lwp, stop_callback)
7151         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7152         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7153         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7154         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7155         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7156         type.
7157         (inf_ptrace_target::attach): Update.
7158         (inf_ptrace_target::files_info): Update.
7159         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7160         type.
7161         (go32_nat_target::pid_to_str): Change return type.
7162         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7163         (gnu_nat_target::wait): Update.
7164         (gnu_nat_target::wait): Update.
7165         (gnu_nat_target::resume): Update.
7166         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7167         (fbsd_nat_target::wait): Update.
7168         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7169         type.
7170         (darwin_nat_target::attach): Update.
7171         * corelow.c (class core_target) <pid_to_str>: Change return type.
7172         (core_target::pid_to_str): Change return type.
7173         * target.c (normal_pid_to_str): Change return type.
7174         (default_pid_to_str): Likewise.
7175         (target_pid_to_str): Change return type.
7176         (target_translate_tls_address): Update.
7177         (target_announce_detach): Update.
7178         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7179         return type.
7180         (bsd_uthread_target::pid_to_str): Change return type.
7181         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7182         type.
7183         (bsd_kvm_target::pid_to_str): Change return type.
7184         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7185         return type.
7186         (aix_thread_target::pid_to_str): Change return type.
7187         * target.h (struct target_ops) <pid_to_str>: Change return type.
7188         (target_pid_to_str, normal_pid_to_str): Likewise.
7189         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7190         type.
7191         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7192         type.
7193         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7194         return type.
7195         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7196         type.
7197         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7198         type.
7199         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7200         return type.
7201
7202 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7203
7204         * NEWS: Mention that the new default MI version is 3.  Mention
7205         changes to the output of commands and events that deal with
7206         multi-location breakpoints.
7207         * breakpoint.c: Include "mi/mi-out.h".
7208         (print_one_breakpoint): Change output syntax if using MI version
7209         >= 3.
7210         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7211         New.
7212         (mi_multi_location_breakpoint_output_fixed): New.
7213         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7214         (mi_cmd_fix_multi_location_breakpoint_output): New.
7215         (mi_multi_location_breakpoint_output_fixed): New.
7216         * mi/mi-cmds.c (mi_cmds): Register command
7217         -fix-multi-location-breakpoint-output.
7218         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7219         interpreter "mi".
7220
7221 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7222
7223         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7224         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7225         instantiate mi_ui_out based on interpreter name.
7226         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7227         * mi/mi-main.c (mi_load_progress): Likewise.
7228
7229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7230
7231         * NEWS: Combine separate "New targets" sections for 8.3.
7232
7233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7234
7235         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7236         (ppcfbsd_init_abi): Install gdbarch
7237         "fetch_tls_load_module_address" and "get_thread_local_address"
7238         methods.
7239
7240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7241
7242         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7243         (riscv_fbsd_init_abi): Install gdbarch
7244         "fetch_tls_load_module_address" and "get_thread_local_address"
7245         methods.
7246
7247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7248
7249         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7250         (i386fbsd_init_abi): Install gdbarch
7251         "fetch_tls_load_module_address" and "get_thread_local_address"
7252         methods.
7253
7254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7255
7256         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7257         (amd64fbsd_init_abi): Install gdbarch
7258         "fetch_tls_load_module_address" and "get_thread_local_address"
7259         methods.
7260
7261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7262
7263         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7264         (struct fbsd_pspace_data): New type.
7265         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7266         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7267         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7268         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7269         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7270
7271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7272
7273         * gdbtypes.c (lookup_struct_elt): New function.
7274         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7275         * gdbtypes.h (struct struct_elt): New type.
7276         (lookup_struct_elt): New prototype.
7277
7278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7279
7280         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7281         remove disabled code block.
7282
7283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7284
7285         * gdbarch.sh (get_thread_local_address): New method.
7286         * gdbarch.h, gdbarch.c: Regenerate.
7287         * target.c (target_translate_tls_address): Use
7288         gdbarch_get_thread_local_address if present instead of
7289         target::get_thread_local_address.
7290
7291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7292
7293         * target.h (target::get_thread_local_address): Update comment.
7294
7295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7296
7297         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7298         objfile->separate_debug_objfile_backlink if not NULL.
7299
7300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7301
7302         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7303         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7304         (amd64bsd_store_inferior_registers): Likewise.
7305         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7306         Enable segment base registers.
7307         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7308         PT_GETFSBASE and PT_GETGSBASE.
7309         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7310         PT_SETGSBASE.
7311         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7312         segment base registers.
7313         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7314
7315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7316
7317         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7318         Update calls to i386_target_description to add 'segments'
7319         parameter.
7320         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7321         add segment base registers.
7322         * arch/i386.c (i386_create_target_description): Add 'segments'
7323         parameter to enable segment base registers.
7324         * arch/i386.h (i386_create_target_description): Likewise.
7325         * features/i386/32bit-segments.xml: New file.
7326         * features/i386/32bit-segments.c: Generate.
7327         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7328         call to i386_target_description to add 'segments' parameter.
7329         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7330         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7331         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7332         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7333         if feature is present.
7334         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7335         Add 'segments' parameter to call to i386_target_description.
7336         (i386_target_description): Add 'segments' parameter to enable
7337         segment base registers.
7338         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7339         to call to i386_target_description.
7340         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7341         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7342         Define I386_NUM_REGS.
7343         (i386_target_description): Add 'segments' parameter to enable
7344         segment base registers.
7345
7346 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7347
7348         PR/24325
7349         * source-cache.c: #undef open and close, to avoid unresolved
7350         externals during linking.
7351
7352 2019-03-12  Tom Tromey  <tromey@adacore.com>
7353
7354         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7355         const.  Add initializers.
7356         (_initialize_remote): Don't initialize ptid globals.
7357
7358 2019-03-12  Pedro Alves  <palves@redhat.com>
7359
7360         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7361
7362 2019-03-12  Pedro Alves  <palves@redhat.com>
7363
7364         * cp-name-parser.y (main): Remove unused 'len' variable.
7365
7366 2019-03-12  Tom Tromey  <tromey@adacore.com>
7367
7368         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7369         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7370
7371 2019-03-12  Tom Tromey  <tromey@adacore.com>
7372
7373         * linux-nat.c (iterate_over_lwps): Update.
7374         (stop_callback): Remove parameter.
7375         (stop_wait_callback, detach_callback, resume_set_callback)
7376         (select_singlestep_lwp_callback, set_ignore_sigint)
7377         (status_callback, resumed_callback, resume_clear_callback)
7378         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7379         data parameter.
7380         (linux_nat_target::detach, linux_nat_target::resume)
7381         (linux_stop_and_wait_all_lwps, select_event_lwp)
7382         (linux_nat_filter_event, linux_nat_wait_1)
7383         (linux_nat_target::kill, linux_nat_target::stop)
7384         (linux_nat_target::stop): Update.
7385         (linux_nat_resume_callback): Change type.
7386         (resume_stopped_resumed_lwps, count_events_callback)
7387         (select_event_lwp_callback): Likewise.
7388         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7389         * arm-linux-nat.c (struct update_registers_data): Remove.
7390         (update_registers_callback): Change type.
7391         (arm_linux_insert_hw_breakpoint1): Update.
7392         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7393         parameter.
7394         (x86_linux_dr_set_addr): Update.
7395         (x86_linux_dr_set_control): Update.
7396         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7397         (iterate_over_lwps): Use gdb::function_view.
7398         * nat/aarch64-linux-hw-point.c (struct
7399         aarch64_dr_update_callback_param): Remove.
7400         (debug_reg_change_callback): Change type.
7401         (aarch64_notify_debug_reg_change): Update.
7402         * s390-linux-nat.c (s390_refresh_per_info): Update.
7403
7404 2019-03-11  Tom Tromey  <tromey@adacore.com>
7405
7406         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7407         redundant assignment to "this_cu".
7408
7409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7410
7411         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7412
7413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7414
7415         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7416         from...
7417         (rank_one_type): ... this.
7418
7419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7420
7421         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7422         from...
7423         (rank_one_type): ... this.
7424
7425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7426
7427         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7428         from...
7429         (rank_one_type): ... this.
7430
7431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7432
7433         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7434         from...
7435         (rank_one_type): ... this.
7436
7437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7438
7439         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7440         from...
7441         (rank_one_type): ... this.
7442
7443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7444
7445         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7446         from...
7447         (rank_one_type): ... this.
7448
7449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7450
7451         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7452         from...
7453         (rank_one_type): ... this.
7454
7455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7456
7457         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7458         from...
7459         (rank_one_type): ... this.
7460
7461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7462
7463         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7464         from...
7465         (rank_one_type): ... this.
7466
7467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7468
7469         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7470         from...
7471         (rank_one_type): ... this.
7472
7473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7474
7475         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7476         from...
7477         (rank_one_type): ... this.
7478
7479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7480
7481         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7482         from...
7483         (rank_one_type): ... this.
7484
7485 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7486
7487         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7488         inferior-events' shows the example events.
7489
7490 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7491
7492         Support styling on native MS-Windows console
7493
7494         PR/24315
7495         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7496         on MS-Windows if $TERM is not defined.
7497
7498         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7499
7500         * posix-hdep.c (gdb_console_fputs):
7501         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7502         functions.
7503         * ui-file.h (gdb_console_fputs): Add prototype.
7504
7505         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7506         back to fputs only if the former returns zero.
7507
7508 2019-03-07  Tom Tromey  <tom@tromey.com>
7509
7510         * symmisc.c (print_symbol_bcache_statistics): Update.
7511         (print_objfile_statistics): Update.
7512         * symfile.c (allocate_symtab): Update.
7513         * stabsread.c: Don't include bcache.h.
7514         * psymtab.h (struct psymbol_bcache): Don't declare.
7515         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7516         (psymbol_bcache_init, psymbol_bcache_free)
7517         (psymbol_bcache_get_bcache): Don't declare.
7518         * psymtab.c (struct psymbol_bcache): Remove.
7519         (psymtab_storage::psymtab_storage): Update.
7520         (psymtab_storage::~psymtab_storage): Update.
7521         (psymbol_bcache_init, psymbol_bcache_free)
7522         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7523         (add_psymbol_to_bcache): Update.
7524         (allocate_psymtab): Update.
7525         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7526         macro_cache>: No longer pointers.
7527         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7528         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7529         * macrotab.c (macro_bcache): Update.
7530         * macroexp.c: Don't include bcache.h.
7531         * gdbtypes.c (check_types_worklist): Update.
7532         (types_deeply_equal): Remove TRY/CATCH.  Update.
7533         * elfread.c (elf_symtab_read): Update.
7534         * dwarf2read.c: Don't include bcache.h.
7535         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7536         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7537         (print_bcache_statistics, bcache_memory_used): Don't declare.
7538         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7539         methods.  Rename all data members.
7540         * bcache.c (struct bcache): Move to bcache.h.
7541         (bcache::expand_hash_table): Rename from expand_hash_table.
7542         (bcache): Remove.
7543         (bcache::insert): Rename from bcache_full.
7544         (bcache::compare): Rename from bcache_compare.
7545         (bcache_xmalloc): Remove.
7546         (bcache::~bcache): Rename from bcache_xfree.
7547         (bcache::print_statistics): Rename from print_bcache_statistics.
7548         (bcache::memory_used): Rename from bcache_memory_used.
7549
7550 2019-03-07  Pedro Alves  <palves@redhat.com>
7551
7552         * infrun.c (normal_stop): Also check for
7553         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7554
7555 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7556
7557         * f-lang.c (value_from_host_double): Moved to...
7558         * value.c (value_from_host_double): ...here.
7559         * value.h (value_from_host_double): Declare.
7560         * guile/scm-math.c (vlscm_convert_typed_number): Use
7561         value_from_host_double.
7562         (vlscm_convert_number): Likewise.
7563         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7564         * python/py-value.c (convert_value_from_python): Likewise.
7565
7566 2019-03-06  Tom Tromey  <tom@tromey.com>
7567
7568         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7569
7570 2019-03-06  Tom Tromey  <tom@tromey.com>
7571
7572         * utils.h (free_current_contents): Don't declare.
7573         * utils.c (free_current_contents): Remove.
7574
7575 2019-03-06  Tom Tromey  <tom@tromey.com>
7576
7577         * top.c (quit_force): Update.
7578         * main.c (captured_command_loop): Update.
7579         * common/new-op.c (operator new): Update.
7580         * common/common-exceptions.c (struct catcher)
7581         <save_cleanup_chain>: Remove member.
7582         (exceptions_state_mc_init): Update.
7583         (exception_try_scope_entry): Return nullptr.
7584         (exception_try_scope_exit, exception_rethrow)
7585         (throw_exception_sjlj, throw_exception_cxx): Update.
7586         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7587         (all_cleanups, do_cleanups, discard_cleanups)
7588         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7589         (restore_cleanups, restore_final_cleanups): Don't declare.
7590         (do_final_cleanups): Remove parameter.
7591         * common/cleanups.c (cleanup_chain, make_cleanup)
7592         (make_cleanup_dtor, all_cleanups, do_cleanups)
7593         (discard_my_cleanups, discard_cleanups)
7594         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7595         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7596         (null_cleanup): Remove.
7597         (do_final_cleanups): Remove parameter.
7598
7599 2019-03-06  Tom Tromey  <tom@tromey.com>
7600
7601         * remote.c (remote_target::remote_parse_stop_reply): Use
7602         unique_xmalloc_ptr.
7603
7604 2019-03-06  Tom Tromey  <tom@tromey.com>
7605
7606         * stabsread.c (struct stabs_field_info): Rename from field_info.
7607         <list, fnlist>: Add initializers.
7608         <obstack>: New member.
7609         (read_member_functions, read_struct_fields, read_baseclasses):
7610         Allocate on obstack.  Don't use cleanups.
7611         (read_one_struct_field, read_member_functions, read_struct_fields)
7612         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7613         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7614         (read_struct_type): Update.
7615
7616 2019-03-06  Tom Tromey  <tom@tromey.com>
7617
7618         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7619         * common/filestuff.h (make_cleanup_close): Don't declare.
7620         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7621         Remove.
7622
7623 2019-03-06  Tom Tromey  <tom@tromey.com>
7624
7625         * solib-aix.c: Use make_scope_exit.
7626
7627 2019-03-06  Tom Tromey  <tom@tromey.com>
7628
7629         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7630         Use make_scope_exit.
7631
7632 2019-03-06  Tom Tromey  <tom@tromey.com>
7633
7634         * solib-svr4.c (disable_probes_interface): Remove parameter.
7635         (svr4_handle_solib_event): Use make_scope_exit.
7636
7637 2019-03-06  Tom Tromey  <tom@tromey.com>
7638
7639         * remote.c (struct stop_reply_deleter): Remove.
7640         (stop_reply_up): Update.
7641         (struct stop_reply): Derive from notif_event.  Don't typedef.
7642         <regcache>: Now a std::vector.
7643         (stop_reply_xfree): Remove.
7644         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7645         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7646         (remote_target::discard_pending_stop_replies): Use delete.
7647         (remote_target::remote_parse_stop_reply): Update.
7648         (remote_target::process_stop_reply): Update.
7649         * remote-notif.h (struct notif_event): Add virtual destructor.
7650         Remove "dtr" member.
7651         (struct notif_client) <alloc_event>: Return a unique_ptr.
7652         (notif_event_xfree): Don't declare.
7653         (notif_event_up): New typedef.
7654         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7655         (notif_event_xfree, do_notif_event_xfree): Remove.
7656         (remote_notif_state_xfree): Update.
7657
7658 2019-03-06  Tom Tromey  <tom@tromey.com>
7659
7660         * infrun.c (displaced_step_clear_cleanup): Now a
7661         forward_scope_exit type.
7662         (displaced_step_prepare_throw): Update.
7663         (displaced_step_fixup): Update.
7664
7665 2019-03-06  Tom Tromey  <tom@tromey.com>
7666
7667         * inferior.h (class inferior): Update comment.
7668         * gdbthread.h (class thread_info): Update comment.
7669
7670 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7671             Tom Tromey  <tom@tromey.com>
7672
7673         * stabsread.h (struct stab_section_list): Remove.
7674         (coffstab_build_psymtabs): Update.
7675         * dbxread.c (symbuf_sections): Now a std::vector.
7676         (sect_idx): New global.
7677         (fill_symbuf): Update.
7678         (coffstab_build_psymtabs): Change type of stabsects parameter.
7679         Update.
7680         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7681         std::vector.
7682         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7683         (coff_locate_sections): Update.
7684         (coff_symfile_read): Remove cleanups.  Update.
7685         (init_stringtab): Add storage parameter.
7686         (free_stringtab, free_stringtab_cleanup): Remove.
7687         (init_lineno): Add storage parameter.
7688         (free_linetab, free_linetab_cleanup): Remove.
7689
7690 2019-03-06  Pedro Alves  <palves@redhat.com>
7691
7692         * linux-fork.c (fork_info::clobber_regs): Delete.
7693         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7694         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7695         comment.  Adjust.
7696         (scoped_switch_fork_info::scoped_switch_fork_info)
7697         (checkpoint_command, linux_fork_context): Adjust
7698         fork_save_infrun_state calls.
7699
7700 2019-03-06  Pedro Alves  <palves@redhat.com>
7701
7702         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7703         (inf_has_multiple_threads): Return 'bool' and rewrite using
7704         inferior_info::threads().
7705
7706 2019-03-06  Pedro Alves  <palves@redhat.com>
7707
7708         * linux-fork.c: Include <list>.
7709         (fork_list): Now a std::list instance.
7710         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7711         (forks_exist_p, find_last_fork): Adjust.
7712         (new_fork): Delete.
7713         (one_fork_p): New.
7714         (add_fork): Adjust.
7715         (free_fork): Delete, folded into fork_info::~fork_info().
7716         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7717         Adjust.
7718         (init_fork_list): Delete.
7719         (linux_fork_killall, linux_fork_mourn_inferior)
7720         (linux_fork_detach, info_checkpoints_command): Adjust.
7721         (_initialize_linux_fork): No longer call init_fork_list.
7722
7723 2019-03-06  Pedro Alves  <palves@redhat.com>
7724
7725         * linux-fork.c (new_fork): New, split out of ...
7726         (add_fork): ... this.  Return void.  Move "first fork" special
7727         case from here, to ...
7728         (checkpoint_command): ... here.
7729         * linux-linux.h (add_fork): Return void.
7730
7731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7732
7733         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7734
7735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7736             Chris January  <chris.january@arm.com>
7737             David Lecomber  <david.lecomber@arm.com>
7738
7739         * f-exp.y: New token, UNOP_INTRINSIC.
7740         (exp): New pattern using UNOP_INTRINSIC token.
7741         (f77_keywords): Add 'abs' keyword.
7742         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7743         (value_from_host_double): New function.
7744         (evaluate_subexp_f): Support UNOP_ABS.
7745
7746 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7747
7748         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7749         types.
7750
7751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7754         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7755         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7756
7757 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7758
7759         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7760
7761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7762             Chris January  <chris.january@arm.com>
7763
7764         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7765         * f-exp.y: Define 'KIND' token.
7766         (exp): New pattern for KIND expressions.
7767         (ptype): Handle types with a kind extension.
7768         (direct_abs_decl): Extend to spot kind extensions.
7769         (f77_keywords): Add 'kind' to the list.
7770         (push_kind_type): New function.
7771         (convert_to_kind_type): New function.
7772         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7773         * parse.c (operator_length_standard): Likewise.
7774         * parser-defs.h (enum type_pieces): Add tp_kind.
7775         * std-operator.def: Add UNOP_KIND.
7776
7777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * f-exp.y (f_parse): Set yydebug.
7780
7781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7782
7783         * f-lang.c (evaluate_subexp_f): New function.
7784         (exp_descriptor_f): New global.
7785         (f_language_defn): Use exp_descriptor_f instead of
7786         exp_descriptor_standard.
7787
7788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * f-exp.y (struct token): Add comments.
7791         (dot_ops): Remove uppercase versions and the end marker.
7792         (f77_keywords): Likewise.
7793         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7794         entries in the dot_ops array are case insensitive, and use
7795         strncasecmp to compare strings.  Also some whitespace cleanup in
7796         this area.  Similar for the f77_keywords array, except entries in
7797         this list might be case sensitive.
7798
7799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * f-exp.y (struct f77_boolean_val): Add comments.
7802         (boolean_values): Remove uppercase versions, and end marker.
7803         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7804         and use strncasecmp to achieve case insensitivity.  Additionally,
7805         perform whitespace cleanup around this code.
7806
7807 2019-03-06  Tom Tromey  <tromey@adacore.com>
7808
7809         * remote-sim.c (gdbsim_target_open): Use result of
7810         gdb_argv::release.
7811
7812 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7813         Dirk Schubert  <dirk.schubert@arm.com>
7814         Chris January  <chris.january@arm.com>
7815
7816         * eval.c (evaluate_subexp_standard): Call Fortran argument
7817         wrapping logic.
7818         * f-lang.c (struct value): A value which can be passed into a
7819         Fortran function call.
7820         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7821         where appropriate.
7822         (struct type): Value ready for a Fortran function call.
7823         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7824         is needed.
7825         * f-lang.h (fortran_argument_convert): Declaration.
7826         (fortran_preserve_arg_pointer): Declaration.
7827         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7828
7829 2019-03-05  Tom Tromey  <tromey@adacore.com>
7830
7831         * python/py-prettyprint.c (print_string_repr): Remove #if.
7832         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7833
7834 2019-03-05  Tom Tromey  <tromey@adacore.com>
7835
7836         * target.c (the_dummy_target): Move later.  Change type to
7837         "dummy_target".
7838         (initialize_targets): Don't initialize the_dummy_target.
7839
7840 2019-03-05  Tom Tromey  <tromey@adacore.com>
7841
7842         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7843         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7844
7845 2019-03-05  Tom Tromey  <tromey@adacore.com>
7846
7847         * windows-nat.c (windows_nat_target::attach)
7848         (windows_nat_target::detach): Don't call gdb_flush.
7849         * valprint.c (generic_val_print, val_print, val_print_string):
7850         Don't call gdb_flush.
7851         * utils.c (defaulted_query): Don't call gdb_flush.
7852         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7853         * target.c (target_announce_detach): Don't call gdb_flush.
7854         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7855         * remote.c (extended_remote_target::attach): Don't call
7856         gdb_flush.
7857         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7858         * printcmd.c (do_examine): Don't call gdb_flush.
7859         (info_display_command): Don't call gdb_flush.
7860         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7861         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7862         * memattr.c (info_mem_command): Don't call gdb_flush.
7863         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7864         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7865         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7866         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7867         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7868         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7869         (gnu_nat_target::detach): Don't call gdb_flush.
7870         * f-valprint.c (f_val_print): Don't call gdb_flush.
7871         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7872         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7873         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7874         gdb_flush.
7875         * c-valprint.c (c_val_print): Don't call gdb_flush.
7876         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7877
7878 2019-03-05  Tom Tromey  <tromey@adacore.com>
7879
7880         * varobj.c (update_dynamic_varobj_children): Update.
7881         (install_default_visualizer): Use reset, not release.
7882         * value.c (set_internalvar): Update.
7883         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7884         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7885         ATTRIBUTE_UNUSED_RESULT.
7886
7887 2019-03-05  Tom Tromey  <tromey@adacore.com>
7888
7889         * remote.c (class scoped_remote_fd) <release>: Add
7890         ATTRIBUTE_UNUSED_RESULT.
7891
7892 2019-03-05  Tom Tromey  <tromey@adacore.com>
7893
7894         * macroexp.c (struct macro_buffer) <release>: Add
7895         ATTRIBUTE_UNUSED_RESULT.
7896
7897 2019-03-05  Tom Tromey  <tromey@adacore.com>
7898
7899         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7900         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7901         ATTRIBUTE_UNUSED_RESULT.
7902
7903 2019-03-05  Tom Tromey  <tromey@adacore.com>
7904
7905         * common/scoped_fd.h (class scoped_fd) <release>: Add
7906         ATTRIBUTE_UNUSED_RESULT.
7907
7908 2019-03-05  Tom Tromey  <tromey@adacore.com>
7909
7910         * parser-defs.h (struct parser_state) <release>: Add
7911         ATTRIBUTE_UNUSED_RESULT.
7912
7913 2019-03-05  Tom Tromey  <tromey@adacore.com>
7914
7915         * utils.h (class gdb_argv) <release>: Add
7916         ATTRIBUTE_UNUSED_RESULT.
7917         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7918
7919 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7920
7921         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7922         for-loop range, to avoid compiler warnings.
7923
7924         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7925         avoid compiler warnings about unused variables.
7926
7927         * NEWS: Mention end of support for native debugging on MS-Windows
7928         before XP.
7929
7930         PR gdb/24292
7931         * common/netstuff.c:
7932         * gdbserver/gdbreplay.c
7933         * gdbserver/remote-utils.c:
7934         * ser-tcp.c:
7935         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7936         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7937         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7938         'getaddrinfo' and 'freeaddrinfo' were not available before
7939         Windows XP, and mingw.org's MinGW headers by default define
7940         _WIN32_WINNT to 0x500.
7941
7942 2019-03-01  Gary Benson <gbenson@redhat.com>
7943
7944         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7945
7946 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7947             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7948
7949         PR gdb/8527
7950         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7951         set_sigint_trap, clear_sigint_trap.
7952
7953 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7954
7955         * target.c (target_detach): Clear the regcache and the
7956         frame cache.
7957
7958 2019-02-27  Pedro Alves  <palves@redhat.com>
7959
7960         * utils.c (set_screen_size): When we cap the height/width sizes,
7961         tweak the corresponding command variable to show "unlimited":
7962
7963 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7964             Pedro Alves  <palves@redhat.com>
7965
7966         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7967         before calling rl_set_screen_size.
7968
7969 2019-02-27  Tom Tromey  <tromey@adacore.com>
7970
7971         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7972         define.
7973         * python/py-value.c: Remove Python 2.4 workaround.
7974         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7975         workaround.
7976         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7977         Python 2.4 workaround.
7978         * python/python-internal.h: Remove Python 2.4 comment.
7979         (Py_ssize_t): Don't define.
7980         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7981         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7982         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7983         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7984         * python/python.c (do_start_initialization): Remove Python 2.4
7985         workaround.
7986         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7987         (print_children): Remove Python 2.4 workaround.
7988         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7989         workaround.
7990         (CHARBUFFERPROC_NAME): Remove.
7991         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7992         Python 2.4 workaround.
7993
7994 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7995
7996         * NEWS: Note minimum Python version.
7997
7998 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7999
8000         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8001         code from these functions.  Remove corresponding ifdefs.  Use
8002         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8003         Remove gotos and target of gotos.
8004         (infpy_search_memory): Likewise.
8005
8006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8007
8008         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8009         (hppa_gdbarch_init): Don't register deleted functions with
8010         gdbarch.
8011
8012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8015         (h8300_unwind_sp): Delete.
8016         (h8300_dummy_id): Delete.
8017         (h8300_gdbarch_init): Don't register deleted functions with
8018         gdbarch.
8019
8020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8021
8022         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8023         (ft32_unwind_pc): Delete.
8024         (ft32_unwind_sp): Delete.
8025         (ft32_gdbarch_init): Don't register deleted functions with
8026         gdbarch.
8027
8028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8029
8030         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8031         (frv_unwind_pc): Delete.
8032         (frv_unwind_sp): Delete.
8033         (frv_gdbarch_init): Don't register deleted functions with
8034         gdbarch.
8035
8036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8037
8038         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8039         (riscv_unwind_pc): Delete.
8040         (riscv_unwind_sp): Delete.
8041         (riscv_gdbarch_init): Don't register deleted functions with
8042         gdbarch.
8043
8044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8047         (csky_unwind_pc): Delete.
8048         (csky_unwind_sp): Delete.
8049         (csky_gdbarch_init): Don't register deleted functions with
8050         gdbarch.
8051
8052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8055         (cris_unwind_pc): Delete.
8056         (cris_unwind_sp): Delete.
8057         (cris_gdbarch_init): Don't register deleted functions with
8058         gdbarch.
8059
8060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8063         (bfin_unwind_pc): Delete.
8064         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8065
8066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8069         (arm_unwind_pc): Delete.
8070         (arm_unwind_sp): Delete.
8071         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8072
8073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8074
8075         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8076         (arc_unwind_pc): Delete.
8077         (arc_unwind_sp): Delete.
8078         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8079
8080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8081
8082         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8083         (alpha_unwind_pc): Delete.
8084         (alpha_gdbarch_init): Don't register deleted functions with
8085         gdbarch.
8086
8087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8088
8089         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8090         (aarch64_unwind_pc): Delete.
8091         (aarch64_unwind_sp): Delete.
8092         (aarch64_gdbarch_init): Don't register deleted functions with
8093         gdbarch.
8094
8095 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8096
8097         * gdbtypes.c (type_align): Don't consider static members when
8098         computing structure alignment.
8099
8100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8101
8102         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8103         return 0 for other types.
8104         * arch-utils.c (default_type_align): Always return 0.
8105         * gdbarch.h: Regenerate.
8106         * gdbarch.sh (type_align): Extend comment.
8107         * gdbtypes.c (type_align): Add additional comments, always call
8108         gdbarch_type_align before applying the default rules.
8109         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8110         generic code will then apply a suitable default.
8111         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8112         types, return 0 for other types.
8113
8114 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8115
8116         * NEWS: Create a new section for the next release branch.
8117         Rename the section of the current branch, now that it has
8118         been cut.
8119
8120 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8121
8122         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8123         * version.in: Bump version to 8.3.50.DATE-git.
8124
8125 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8126
8127         * aix-thread.c (ptid_cmp): Remove unused variable.
8128         (get_signaled_thread): Likewise.
8129         (store_regs_user_thread): Likewise.
8130         (store_regs_kernel_thread): Likewise.
8131         (fetch_regs_kernel_thread): Remove shadowed variable.
8132
8133 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8134
8135         * features/riscv/32bit-cpu.xml: Add register numbers.
8136         * features/riscv/32bit-fpu.c: Regenerate.
8137         * features/riscv/32bit-fpu.xml: Add register numbers.
8138         * features/riscv/64bit-cpu.xml: Add register numbers.
8139         * features/riscv/64bit-fpu.c: Regenerate.
8140         * features/riscv/64bit-fpu.xml: Add register numbers.
8141
8142 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8143
8144         * NEWS: Mention two argument form of gdb.Value constructor.
8145         * python/py-value.c (convert_buffer_and_type_to_value): New
8146         function.
8147         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8148         Add support for handling an optional second argument.  Call
8149         convert_buffer_and_type_to_value as appropriate.
8150         * python/python-internal.h (Py_buffer_deleter): New struct.
8151         (Py_buffer_up): New typedef.
8152
8153 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8154
8155         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8156         instead of releasing ownership.
8157
8158 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8159
8160         * dwarf2read.c (open_and_init_dwp_file): Call
8161         elf_numsections instead of bfd_count_sections to initialize
8162         dwp_file->num_sections.
8163
8164 2019-02-25  Tom Tromey  <tromey@adacore.com>
8165
8166         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8167
8168 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8169
8170         * gcore.in: Add '--readnever' option when invoking GDB.
8171
8172 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8173
8174         * MAINTAINERS: Update my email address.
8175
8176 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8177
8178         * build-id.c (build_id_to_debug_bfd_1): New function.
8179         (build_id_to_debug_bfd): Look for separate debug file in
8180         sysroot.
8181
8182 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * gdbarch.sh: Update the copyright year range that is placed into
8185         generated files.
8186
8187 2019-02-22  Keith Seitz  <keiths@redhat.com>
8188
8189         PR symtab/23853
8190         * linespec.c (create_sals_line_offset): Search for the default
8191         symtab's filename instead of its fullname.
8192
8193 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8194
8195         * NEWS: Update style defaults.
8196
8197 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8198
8199         * main.c (captured_main_1): Disable styling in batch mode.
8200
8201 2019-02-20  Tom Tromey  <tom@tromey.com>
8202
8203         * symtab.c (symtab_symbol_info): Fix typos.
8204
8205 2019-02-20  Tom Tromey  <tromey@adacore.com>
8206
8207         * findcmd.c (_initialize_mem_search): Use upper case for
8208         metasyntactic variables.
8209
8210 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8211
8212         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8213         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8214
8215 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8216
8217         * top.h (source_file_name): Change to std::string.
8218         * top.c (source_file_name): Likewise.
8219         (command_line_input): Adjust.
8220         * cli/cli-script.c (script_from_file): Adjust.
8221
8222 2019-02-19  Tom Tromey  <tromey@adacore.com>
8223
8224         * ravenscar-thread.c
8225         (ravenscar_thread_target::update_thread_list): Don't call
8226         ada_build_task_list.
8227         * ada-lang.h (ada_build_task_list): Don't declare.
8228         * ada-tasks.c (struct ada_tasks_inferior_data)
8229         <task_list_valid_p>: Now bool.
8230         (read_known_tasks, ada_task_list_changed)
8231         (ada_tasks_invalidate_inferior_data): Update.
8232         (read_known_tasks_array): Return bool.
8233         (read_known_tasks_list): Likewise.
8234         (read_known_tasks): Return void.
8235         (ada_build_task_list): Now static.
8236
8237 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8238
8239         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8240         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8241
8242 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8243
8244         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8245         variant for ada_tasks_pspace_data_handle and
8246         ada_tasks_inferior_data_handle.
8247         (ada_tasks_pspace_data_cleanup): New function.
8248         (ada_tasks_inferior_data_cleanup): New function.
8249
8250 2019-02-17  Tom Tromey  <tom@tromey.com>
8251
8252         * macrotab.h (macro_source_fullname): Return a std::string.
8253         * macrotab.c (macro_include, check_for_redefinition)
8254         (macro_undef, macro_lookup_definition, foreach_macro)
8255         (foreach_macro_in_scope): Update.
8256         (macro_source_fullname): Return a std::string.
8257         * macrocmd.c (show_pp_source_pos): Update.
8258
8259 2019-02-17  Tom Tromey  <tom@tromey.com>
8260
8261         * macrocmd.c (show_pp_source_pos): Style the file names.
8262
8263 2019-02-17  Tom Tromey  <tom@tromey.com>
8264
8265         PR tui/24197:
8266         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8267
8268 2019-02-17  Tom Tromey  <tom@tromey.com>
8269
8270         * ada-lang.c (user_select_syms): Use filtered printing.
8271         * utils.c (wrap_style): New global.
8272         (desired_style): Remove.
8273         (emit_style_escape): Add stream parameter.
8274         (set_output_style, reset_terminal_style, prompt_for_continue):
8275         Update.
8276         (flush_wrap_buffer): Only flush gdb_stdout.
8277         (wrap_here): Set wrap_style.
8278         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8279         treat escape sequences as a character.  Change when wrap buffer is
8280         flushed.
8281         (fputs_styled): Do not set the output style when the default is
8282         requested.
8283         * ui-style.h (struct ui_file_style) <is_default>: New method.
8284         * source.c (print_source_lines_base): Emit escape sequences in one
8285         piece.
8286
8287 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8288
8289         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8290         integers and enumeration types.
8291
8292 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8293
8294         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8295         instead of lookup_symbol_in_language
8296         (do_exact_match): New function.
8297         (ada_get_symbol_name_matcher): Return do_exact_match when
8298         doing a verbatim match.
8299
8300 2019-02-15  Tom Tromey  <tromey@adacore.com>
8301
8302         * ravenscar-thread.c (ravenscar_thread_target::resume)
8303         (ravenscar_thread_target::wait): Special case wildcard requests.
8304
8305 2019-02-15  Tom Tromey  <tromey@adacore.com>
8306
8307         * ravenscar-thread.c (base_ptid): Remove.
8308         (struct ravenscar_thread_target) <close>: New method.
8309         <m_base_ptid>: New member.
8310         <update_inferior_ptid, active_task, task_is_currently_active,
8311         runtime_initialized>: Declare methods.
8312         <ravenscar_thread_target>: Add constructor.
8313         (ravenscar_thread_target::task_is_currently_active)
8314         (ravenscar_thread_target::update_inferior_ptid)
8315         (ravenscar_runtime_initialized): Rename.  Now methods.
8316         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8317         (ravenscar_thread_target::update_thread_list): Update.
8318         (ravenscar_thread_target::active_task): Now method.
8319         (ravenscar_thread_target::store_registers)
8320         (ravenscar_thread_target::prepare_to_store)
8321         (ravenscar_thread_target::prepare_to_store)
8322         (ravenscar_thread_target::mourn_inferior): Update.
8323         (ravenscar_inferior_created): Use "new" to create target.
8324         (ravenscar_thread_target::get_ada_task_ptid): Update.
8325         (_initialize_ravenscar): Don't initialize base_ptid.
8326         (ravenscar_ops): Remove global.
8327
8328 2019-02-15  Tom Tromey  <tromey@adacore.com>
8329
8330         * target.h (push_target): Declare new overload.
8331         * target.c (push_target): New overload, taking an rvalue reference.
8332         * remote.c (remote_target::open_1): Use push_target overload.
8333         * corelow.c (core_target_open): Use push_target overload.
8334
8335 2019-02-15  Tom Tromey  <tromey@adacore.com>
8336
8337         * ravenscar-thread.c (is_ravenscar_task)
8338         (ravenscar_task_is_currently_active): Return bool.
8339         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8340         (_initialize_ravenscar): Remove "(void)".
8341         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8342         Return bool.
8343
8344 2019-02-15  Tom Tromey  <tromey@adacore.com>
8345
8346         * ravenscar-thread.c (ravenscar_runtime_initializer)
8347         (has_ravenscar_runtime, get_running_thread_id)
8348         (ravenscar_thread_target::resume): Fix indentation.
8349
8350 2019-02-15  Tom Tromey  <tromey@adacore.com>
8351
8352         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8353         from ravenscar_arch_ops.
8354         (sparc_ravenscar_ops::fetch_registers)
8355         (sparc_ravenscar_ops::store_registers): Now methods.
8356         (sparc_ravenscar_prepare_to_store): Remove.
8357         (sparc_ravenscar_ops): Redefine.
8358         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8359         methods and destructor.  Remove members.
8360         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8361         (ravenscar_thread_target::store_registers)
8362         (ravenscar_thread_target::prepare_to_store): Update.
8363         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8364         Remove.
8365         (struct ppc_ravenscar_powerpc_ops): Derive from
8366         ravenscar_arch_ops.
8367         (ppc_ravenscar_powerpc_ops::fetch_registers)
8368         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8369         (ppc_ravenscar_powerpc_ops): Redefine.
8370         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8371         (ppc_ravenscar_e500_ops::fetch_registers)
8372         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8373         (ppc_ravenscar_e500_ops): Redefine.
8374         * aarch64-ravenscar-thread.c
8375         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8376         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8377         (aarch64_ravenscar_fetch_registers)
8378         (aarch64_ravenscar_store_registers): Now methods.
8379         (aarch64_ravenscar_ops): Redefine.
8380
8381 2019-02-15  Tom Tromey  <tromey@adacore.com>
8382
8383         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8384         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8385         (ravenscar_thread_target::stopped_by_watchpoint)
8386         (ravenscar_thread_target::stopped_data_address)
8387         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8388
8389 2019-02-15  Tom Tromey  <tromey@adacore.com>
8390
8391         * ravenscar-thread.c: Fix some typos.
8392
8393 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8394             Tom Tromey  <tromey@adacore.com>
8395
8396         * ada-lang.c (ada_exception_sal): Change addr_string to a
8397         std::string.
8398         (create_ada_exception_catchpoint): Update.
8399
8400 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8401             Tom Tromey  <tromey@adacore.com>
8402
8403         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8404         (bp_location_ops): Remove.
8405         (base_breakpoint_allocate_location): Update.
8406         (free_bp_location): Update.
8407         * ada-lang.c (class ada_catchpoint_location)
8408         <ada_catchpoint_location>: Remove ops parameter.
8409         (ada_catchpoint_location_dtor): Remove.
8410         (ada_catchpoint_location_ops): Remove.
8411         (allocate_location_exception): Update.
8412         * breakpoint.h (struct bp_location_ops): Remove.
8413         (class bp_location) <bp_location>: Remove bp_location_ops
8414         parameter.
8415         <~bp_location>: Add destructor.
8416         <ops>: Remove.
8417
8418 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8419             Pedro Alves  <palves@redhat.com>
8420
8421         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8422         'PATH_MAX'.
8423
8424 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8425             Samuel Thibault  <samuel.thibault@gnu.org>
8426             Thomas Schwinge  <thomas@codesourcery.com>
8427
8428         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8429         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8430
8431 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8432
8433         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8434         (check_empty): Use "const char *".
8435
8436         * gnu-nat.c (gnu_nat_target::detach): Instead of
8437         'detach_inferior (pid)' call
8438         'detach_inferior (find_inferior_pid (pid))'.
8439
8440         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8441         'nat/fork-inferior.o'.
8442         * gnu-nat.c: #include "nat/fork-inferior.h".
8443
8444         * gnu-nat.c (gnu_nat_target::detach): Instead of
8445         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8446         * gnu-nat.h: #include "inf-child.h".
8447         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8448         'i386_gnu_nat_target::fetch_registers'.
8449         (gnu_store_registers): Rename/move to
8450         'i386_gnu_nat_target::store_registers'.
8451
8452         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8453         * gnu-nat.h (mach_thread_info): New function.
8454         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8455
8456         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8457
8458 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8459
8460         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8461
8462 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8463
8464         * windows-nat.c (windows_add_thread): Add new parameter
8465         "main_thread_p" with default value set to false.  Update
8466         function documentation as well as all callers.
8467         (windows_delete_thread): Likewise.
8468         (fake_create_process): Update call to windows_add_thread.
8469         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8470         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8471         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8472         call to windows_delete_thread.
8473
8474 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8475
8476         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8477
8478 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8479
8480         * symfile.c (find_separate_debug_file): Use canonical path of
8481         sysroot with child_path instead of gdb_sysroot if it is valid.
8482
8483 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8484
8485         * symfile.c (find_separate_debug_file): Use child_path to
8486         determine if an object file is under a sysroot.
8487
8488 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8489
8490         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8491         unittests/child-path-selftests.c.
8492         * common/pathstuff.c (child_path): New function.
8493         * common/pathstuff.h (child_path): New prototype.
8494         * unittests/child-path-selftests.c: New file.
8495
8496 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8497
8498         * symfile.c (find_separate_debug_file): Look for separate debug
8499         files in debug directories under the sysroot.
8500
8501 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8502
8503         * symtab.h (struct minimal_symbol data_p): New const method.
8504         (struct minimal_symbol text_p): Likewise.
8505         * symtab.c (output_source_filename): Use file name style
8506         to print file name.
8507         (print_symbol_info): Likewise.
8508         (print_msymbol_info): Use address style to print addresses.
8509         Use function name style to print executable text symbols.
8510         (expand_symtab_containing_pc): Use data_p.
8511         (find_pc_sect_compunit_symtab): Likewise.
8512
8513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8514
8515         * breakpoint.c (describe_other_breakpoints): Use address style
8516         to print addresses.
8517         (say_where): Likewise.
8518
8519 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8520
8521         * ada-typeprint.c (print_func_type): Print function name
8522         style to print function name.
8523         * c-typeprint.c (c_print_type_1): Likewise.
8524
8525 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8526
8527         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8528         for execve.
8529
8530 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8531
8532         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8533         type_stack.
8534
8535 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8536
8537         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8538         TYPE_CODE_REF types.
8539
8540 2019-02-08  Jim Wilson  <jimw@sifive.com>
8541
8542         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8543         (riscv_linux_fregset): New.
8544         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8545
8546 2019-02-07  Tom Tromey  <tom@tromey.com>
8547
8548         * thread.c (thread_cancel_execution_command): Update.
8549         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8550         methods.
8551         (struct thread_fsm_ops): Remove.
8552         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8553         (thread_fsm_should_stop, thread_fsm_return_value)
8554         (thread_fsm_set_finished, thread_fsm_finished_p)
8555         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8556         Don't declare.
8557         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8558         * infrun.c (clear_proceed_status_thread)
8559         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8560         (print_stop_event): Update.
8561         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8562         Add constructor.
8563         (step_command_fsm_ops): Remove.
8564         (new_step_command_fsm): Remove.
8565         (step_1): Update.
8566         (step_command_fsm::should_stop): Rename from
8567         step_command_fsm_should_stop.
8568         (step_command_fsm::clean_up): Rename from
8569         step_command_fsm_clean_up.
8570         (step_command_fsm::do_async_reply_reason): Rename from
8571         step_command_fsm_async_reply_reason.
8572         (struct until_next_fsm): Inherit from thread_fsm.  Add
8573         constructor.
8574         (until_next_fsm_ops): Remove.
8575         (new_until_next_fsm): Remove.
8576         (until_next_fsm::should_stop): Rename from
8577         until_next_fsm_should_stop.
8578         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8579         (until_next_fsm::do_async_reply_reason): Rename from
8580         until_next_fsm_async_reply_reason.
8581         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8582         constructor.  Change type of breakpoint.
8583         (finish_command_fsm_ops): Remove.
8584         (new_finish_command_fsm): Remove.
8585         (finish_command_fsm::should_stop): Rename from
8586         finish_command_fsm_should_stop.
8587         (finish_command_fsm::clean_up): Rename from
8588         finish_command_fsm_clean_up.
8589         (finish_command_fsm::return_value): Rename from
8590         finish_command_fsm_return_value.
8591         (finish_command_fsm::do_async_reply_reason): Rename from
8592         finish_command_fsm_async_reply_reason.
8593         (finish_command): Update.
8594         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8595         Add constructor.
8596         (call_thread_fsm_ops): Remove.
8597         (call_thread_fsm::call_thread_fsm): Rename from
8598         new_call_thread_fsm.
8599         (call_thread_fsm::should_stop): Rename from
8600         call_thread_fsm_should_stop.
8601         (call_thread_fsm::should_notify_stop): Rename from
8602         call_thread_fsm_should_notify_stop.
8603         (run_inferior_call, call_function_by_hand_dummy): Update.
8604         * cli/cli-interp.c (should_print_stop_to_console): Update.
8605         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8606         Add constructor.  Change type of location_breakpoint,
8607         caller_breakpoint.
8608         (until_break_fsm_ops): Remove.
8609         (new_until_break_fsm): Remove.
8610         (until_break_fsm::should_stop): Rename from
8611         until_break_fsm_should_stop.
8612         (until_break_fsm::clean_up): Rename from
8613         until_break_fsm_clean_up.
8614         (until_break_fsm::do_async_reply_reason): Rename from
8615         until_break_fsm_async_reply_reason.
8616         (until_break_command): Update.
8617         * thread-fsm.c: Remove.
8618         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8619
8620 2019-02-07  Tom Tromey  <tom@tromey.com>
8621
8622         * yy-remap.h: Add include guard.
8623         * xtensa-tdep.h: Add include guard.
8624         * xcoffread.h: Rename include guard.
8625         * varobj-iter.h: Add include guard.
8626         * tui/tui.h: Rename include guard.
8627         * tui/tui-winsource.h: Rename include guard.
8628         * tui/tui-wingeneral.h: Rename include guard.
8629         * tui/tui-windata.h: Rename include guard.
8630         * tui/tui-win.h: Rename include guard.
8631         * tui/tui-stack.h: Rename include guard.
8632         * tui/tui-source.h: Rename include guard.
8633         * tui/tui-regs.h: Rename include guard.
8634         * tui/tui-out.h: Rename include guard.
8635         * tui/tui-layout.h: Rename include guard.
8636         * tui/tui-io.h: Rename include guard.
8637         * tui/tui-hooks.h: Rename include guard.
8638         * tui/tui-file.h: Rename include guard.
8639         * tui/tui-disasm.h: Rename include guard.
8640         * tui/tui-data.h: Rename include guard.
8641         * tui/tui-command.h: Rename include guard.
8642         * tic6x-tdep.h: Add include guard.
8643         * target/waitstatus.h: Rename include guard.
8644         * target/wait.h: Rename include guard.
8645         * target/target.h: Rename include guard.
8646         * target/resume.h: Rename include guard.
8647         * target-float.h: Rename include guard.
8648         * stabsread.h: Add include guard.
8649         * rs6000-tdep.h: Add include guard.
8650         * riscv-fbsd-tdep.h: Add include guard.
8651         * regformats/regdef.h: Rename include guard.
8652         * record.h: Rename include guard.
8653         * python/python.h: Rename include guard.
8654         * python/python-internal.h: Rename include guard.
8655         * python/py-stopevent.h: Rename include guard.
8656         * python/py-ref.h: Rename include guard.
8657         * python/py-record.h: Rename include guard.
8658         * python/py-record-full.h: Rename include guard.
8659         * python/py-record-btrace.h: Rename include guard.
8660         * python/py-instruction.h: Rename include guard.
8661         * python/py-events.h: Rename include guard.
8662         * python/py-event.h: Rename include guard.
8663         * procfs.h: Add include guard.
8664         * proc-utils.h: Add include guard.
8665         * p-lang.h: Add include guard.
8666         * or1k-tdep.h: Rename include guard.
8667         * observable.h: Rename include guard.
8668         * nto-tdep.h: Rename include guard.
8669         * nat/x86-linux.h: Rename include guard.
8670         * nat/x86-linux-dregs.h: Rename include guard.
8671         * nat/x86-gcc-cpuid.h: Add include guard.
8672         * nat/x86-dregs.h: Rename include guard.
8673         * nat/x86-cpuid.h: Rename include guard.
8674         * nat/ppc-linux.h: Rename include guard.
8675         * nat/mips-linux-watch.h: Rename include guard.
8676         * nat/linux-waitpid.h: Rename include guard.
8677         * nat/linux-ptrace.h: Rename include guard.
8678         * nat/linux-procfs.h: Rename include guard.
8679         * nat/linux-osdata.h: Rename include guard.
8680         * nat/linux-nat.h: Rename include guard.
8681         * nat/linux-namespaces.h: Rename include guard.
8682         * nat/linux-btrace.h: Rename include guard.
8683         * nat/glibc_thread_db.h: Rename include guard.
8684         * nat/gdb_thread_db.h: Rename include guard.
8685         * nat/gdb_ptrace.h: Rename include guard.
8686         * nat/fork-inferior.h: Rename include guard.
8687         * nat/amd64-linux-siginfo.h: Rename include guard.
8688         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8689         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8690         * nat/aarch64-linux.h: Rename include guard.
8691         * nat/aarch64-linux-hw-point.h: Rename include guard.
8692         * mn10300-tdep.h: Add include guard.
8693         * mips-linux-tdep.h: Add include guard.
8694         * mi/mi-parse.h: Rename include guard.
8695         * mi/mi-out.h: Rename include guard.
8696         * mi/mi-main.h: Rename include guard.
8697         * mi/mi-interp.h: Rename include guard.
8698         * mi/mi-getopt.h: Rename include guard.
8699         * mi/mi-console.h: Rename include guard.
8700         * mi/mi-common.h: Rename include guard.
8701         * mi/mi-cmds.h: Rename include guard.
8702         * mi/mi-cmd-break.h: Rename include guard.
8703         * m2-lang.h: Add include guard.
8704         * location.h: Rename include guard.
8705         * linux-record.h: Rename include guard.
8706         * linux-nat.h: Add include guard.
8707         * linux-fork.h: Add include guard.
8708         * i386-darwin-tdep.h: Rename include guard.
8709         * hppa-linux-offsets.h: Add include guard.
8710         * guile/guile.h: Rename include guard.
8711         * guile/guile-internal.h: Rename include guard.
8712         * gnu-nat.h: Rename include guard.
8713         * gdb-stabs.h: Rename include guard.
8714         * frv-tdep.h: Add include guard.
8715         * f-lang.h: Add include guard.
8716         * event-loop.h: Add include guard.
8717         * darwin-nat.h: Rename include guard.
8718         * cp-abi.h: Rename include guard.
8719         * config/sparc/nm-sol2.h: Rename include guard.
8720         * config/nm-nto.h: Rename include guard.
8721         * config/nm-linux.h: Add include guard.
8722         * config/i386/nm-i386gnu.h: Rename include guard.
8723         * config/djgpp/nl_types.h: Rename include guard.
8724         * config/djgpp/langinfo.h: Rename include guard.
8725         * compile/gcc-cp-plugin.h: Add include guard.
8726         * compile/gcc-c-plugin.h: Add include guard.
8727         * compile/compile.h: Rename include guard.
8728         * compile/compile-object-run.h: Rename include guard.
8729         * compile/compile-object-load.h: Rename include guard.
8730         * compile/compile-internal.h: Rename include guard.
8731         * compile/compile-cplus.h: Rename include guard.
8732         * compile/compile-c.h: Rename include guard.
8733         * common/xml-utils.h: Rename include guard.
8734         * common/x86-xstate.h: Rename include guard.
8735         * common/version.h: Rename include guard.
8736         * common/vec.h: Rename include guard.
8737         * common/tdesc.h: Rename include guard.
8738         * common/selftest.h: Rename include guard.
8739         * common/scoped_restore.h: Rename include guard.
8740         * common/scoped_mmap.h: Rename include guard.
8741         * common/scoped_fd.h: Rename include guard.
8742         * common/safe-iterator.h: Rename include guard.
8743         * common/run-time-clock.h: Rename include guard.
8744         * common/refcounted-object.h: Rename include guard.
8745         * common/queue.h: Rename include guard.
8746         * common/ptid.h: Rename include guard.
8747         * common/print-utils.h: Rename include guard.
8748         * common/preprocessor.h: Rename include guard.
8749         * common/pathstuff.h: Rename include guard.
8750         * common/observable.h: Rename include guard.
8751         * common/netstuff.h: Rename include guard.
8752         * common/job-control.h: Rename include guard.
8753         * common/host-defs.h: Rename include guard.
8754         * common/gdb_wait.h: Rename include guard.
8755         * common/gdb_vecs.h: Rename include guard.
8756         * common/gdb_unlinker.h: Rename include guard.
8757         * common/gdb_unique_ptr.h: Rename include guard.
8758         * common/gdb_tilde_expand.h: Rename include guard.
8759         * common/gdb_sys_time.h: Rename include guard.
8760         * common/gdb_string_view.h: Rename include guard.
8761         * common/gdb_splay_tree.h: Rename include guard.
8762         * common/gdb_setjmp.h: Rename include guard.
8763         * common/gdb_ref_ptr.h: Rename include guard.
8764         * common/gdb_optional.h: Rename include guard.
8765         * common/gdb_locale.h: Rename include guard.
8766         * common/gdb_assert.h: Rename include guard.
8767         * common/filtered-iterator.h: Rename include guard.
8768         * common/filestuff.h: Rename include guard.
8769         * common/fileio.h: Rename include guard.
8770         * common/environ.h: Rename include guard.
8771         * common/common-utils.h: Rename include guard.
8772         * common/common-types.h: Rename include guard.
8773         * common/common-regcache.h: Rename include guard.
8774         * common/common-inferior.h: Rename include guard.
8775         * common/common-gdbthread.h: Rename include guard.
8776         * common/common-exceptions.h: Rename include guard.
8777         * common/common-defs.h: Rename include guard.
8778         * common/common-debug.h: Rename include guard.
8779         * common/cleanups.h: Rename include guard.
8780         * common/buffer.h: Rename include guard.
8781         * common/btrace-common.h: Rename include guard.
8782         * common/break-common.h: Rename include guard.
8783         * cli/cli-utils.h: Rename include guard.
8784         * cli/cli-style.h: Rename include guard.
8785         * cli/cli-setshow.h: Rename include guard.
8786         * cli/cli-script.h: Rename include guard.
8787         * cli/cli-interp.h: Rename include guard.
8788         * cli/cli-decode.h: Rename include guard.
8789         * cli/cli-cmds.h: Rename include guard.
8790         * charset-list.h: Add include guard.
8791         * buildsym-legacy.h: Rename include guard.
8792         * bfin-tdep.h: Add include guard.
8793         * ax.h: Rename include guard.
8794         * arm-linux-tdep.h: Add include guard.
8795         * arm-fbsd-tdep.h: Add include guard.
8796         * arch/xtensa.h: Rename include guard.
8797         * arch/tic6x.h: Add include guard.
8798         * arch/i386.h: Add include guard.
8799         * arch/arm.h: Rename include guard.
8800         * arch/arm-linux.h: Rename include guard.
8801         * arch/arm-get-next-pcs.h: Rename include guard.
8802         * arch/amd64.h: Add include guard.
8803         * arch/aarch64-insn.h: Rename include guard.
8804         * arch-utils.h: Rename include guard.
8805         * annotate.h: Add include guard.
8806         * amd64-darwin-tdep.h: Rename include guard.
8807         * aarch64-linux-tdep.h: Add include guard.
8808         * aarch64-fbsd-tdep.h: Add include guard.
8809         * aarch32-linux-nat.h: Add include guard.
8810
8811 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8812
8813         * macrotab.c (macro_define_internal): New function that
8814         factorizes macro_define_object_internal and macro_define_function
8815         code.
8816         (macro_define_object_internal): Use macro_define_internal.
8817         (macro_define_function): Likewise.
8818
8819 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8820
8821         * macrocmd.c (extract_identifier): Return
8822         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8823         callers.
8824
8825 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8826
8827         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8828
8829 2019-02-05  Tom Tromey  <tom@tromey.com>
8830
8831         * target.c (target_stack::unpush): Move assertion earlier.
8832
8833 2019-01-30  Tom Tromey  <tom@tromey.com>
8834
8835         PR python/23615:
8836         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8837         (gdbpy_parse_and_eval): Likewise.
8838         * python/python-internal.h (gdbpy_allow_threads): New class.
8839
8840 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8841
8842         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8843         (aarch64_fbsd_fpregmap): Move earlier.
8844         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8845         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8846         instead of individual calls to trad_frame_set_reg_addr.
8847         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8848         earlier.
8849         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8850         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8851         instead of individual calls to trad_frame_set_reg_addr.
8852
8853 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8854
8855         * CONTRIBUTE: Replace contribution list with wiki link.
8856
8857 2019-01-25  Tom Tromey  <tom@tromey.com>
8858
8859         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8860
8861 2019-01-25  Tom Tromey  <tom@tromey.com>
8862
8863         * xtensa-linux-nat.c: Fix common/ includes.
8864         * xml-support.h: Fix common/ includes.
8865         * xml-support.c: Fix common/ includes.
8866         * x86-linux-nat.c: Fix common/ includes.
8867         * windows-nat.c: Fix common/ includes.
8868         * varobj.h: Fix common/ includes.
8869         * varobj.c: Fix common/ includes.
8870         * value.c: Fix common/ includes.
8871         * valops.c: Fix common/ includes.
8872         * utils.c: Fix common/ includes.
8873         * unittests/xml-utils-selftests.c: Fix common/ includes.
8874         * unittests/utils-selftests.c: Fix common/ includes.
8875         * unittests/unpack-selftests.c: Fix common/ includes.
8876         * unittests/tracepoint-selftests.c: Fix common/ includes.
8877         * unittests/style-selftests.c: Fix common/ includes.
8878         * unittests/string_view-selftests.c: Fix common/ includes.
8879         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8880         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8881         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8882         * unittests/rsp-low-selftests.c: Fix common/ includes.
8883         * unittests/parse-connection-spec-selftests.c: Fix common/
8884         includes.
8885         * unittests/optional-selftests.c: Fix common/ includes.
8886         * unittests/offset-type-selftests.c: Fix common/ includes.
8887         * unittests/observable-selftests.c: Fix common/ includes.
8888         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8889         * unittests/memrange-selftests.c: Fix common/ includes.
8890         * unittests/memory-map-selftests.c: Fix common/ includes.
8891         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8892         * unittests/function-view-selftests.c: Fix common/ includes.
8893         * unittests/environ-selftests.c: Fix common/ includes.
8894         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8895         * unittests/common-utils-selftests.c: Fix common/ includes.
8896         * unittests/cli-utils-selftests.c: Fix common/ includes.
8897         * unittests/array-view-selftests.c: Fix common/ includes.
8898         * ui-file.c: Fix common/ includes.
8899         * tui/tui-io.c: Fix common/ includes.
8900         * tracepoint.h: Fix common/ includes.
8901         * tracepoint.c: Fix common/ includes.
8902         * tracefile-tfile.c: Fix common/ includes.
8903         * top.h: Fix common/ includes.
8904         * top.c: Fix common/ includes.
8905         * thread.c: Fix common/ includes.
8906         * target/waitstatus.h: Fix common/ includes.
8907         * target/waitstatus.c: Fix common/ includes.
8908         * target.h: Fix common/ includes.
8909         * target.c: Fix common/ includes.
8910         * target-memory.c: Fix common/ includes.
8911         * target-descriptions.c: Fix common/ includes.
8912         * symtab.h: Fix common/ includes.
8913         * symfile.c: Fix common/ includes.
8914         * stap-probe.c: Fix common/ includes.
8915         * spu-linux-nat.c: Fix common/ includes.
8916         * sparc-nat.c: Fix common/ includes.
8917         * source.c: Fix common/ includes.
8918         * solib.c: Fix common/ includes.
8919         * solib-target.c: Fix common/ includes.
8920         * ser-unix.c: Fix common/ includes.
8921         * ser-tcp.c: Fix common/ includes.
8922         * ser-pipe.c: Fix common/ includes.
8923         * ser-base.c: Fix common/ includes.
8924         * selftest-arch.c: Fix common/ includes.
8925         * s12z-tdep.c: Fix common/ includes.
8926         * rust-exp.y: Fix common/ includes.
8927         * rs6000-aix-tdep.c: Fix common/ includes.
8928         * riscv-tdep.c: Fix common/ includes.
8929         * remote.c: Fix common/ includes.
8930         * remote-notif.h: Fix common/ includes.
8931         * remote-fileio.h: Fix common/ includes.
8932         * remote-fileio.c: Fix common/ includes.
8933         * regcache.h: Fix common/ includes.
8934         * regcache.c: Fix common/ includes.
8935         * record-btrace.c: Fix common/ includes.
8936         * python/python.c: Fix common/ includes.
8937         * python/py-type.c: Fix common/ includes.
8938         * python/py-inferior.c: Fix common/ includes.
8939         * progspace.h: Fix common/ includes.
8940         * producer.c: Fix common/ includes.
8941         * procfs.c: Fix common/ includes.
8942         * proc-api.c: Fix common/ includes.
8943         * printcmd.c: Fix common/ includes.
8944         * ppc-linux-nat.c: Fix common/ includes.
8945         * parser-defs.h: Fix common/ includes.
8946         * osdata.c: Fix common/ includes.
8947         * obsd-nat.c: Fix common/ includes.
8948         * nat/x86-linux.c: Fix common/ includes.
8949         * nat/x86-linux-dregs.c: Fix common/ includes.
8950         * nat/x86-dregs.h: Fix common/ includes.
8951         * nat/x86-dregs.c: Fix common/ includes.
8952         * nat/ppc-linux.c: Fix common/ includes.
8953         * nat/mips-linux-watch.h: Fix common/ includes.
8954         * nat/mips-linux-watch.c: Fix common/ includes.
8955         * nat/linux-waitpid.c: Fix common/ includes.
8956         * nat/linux-ptrace.h: Fix common/ includes.
8957         * nat/linux-ptrace.c: Fix common/ includes.
8958         * nat/linux-procfs.c: Fix common/ includes.
8959         * nat/linux-personality.c: Fix common/ includes.
8960         * nat/linux-osdata.c: Fix common/ includes.
8961         * nat/linux-namespaces.c: Fix common/ includes.
8962         * nat/linux-btrace.h: Fix common/ includes.
8963         * nat/linux-btrace.c: Fix common/ includes.
8964         * nat/fork-inferior.c: Fix common/ includes.
8965         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8966         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8967         * nat/aarch64-linux.c: Fix common/ includes.
8968         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8969         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8970         * namespace.h: Fix common/ includes.
8971         * mips-linux-tdep.c: Fix common/ includes.
8972         * minsyms.c: Fix common/ includes.
8973         * mi/mi-parse.h: Fix common/ includes.
8974         * mi/mi-main.c: Fix common/ includes.
8975         * mi/mi-cmd-env.c: Fix common/ includes.
8976         * memrange.h: Fix common/ includes.
8977         * memattr.c: Fix common/ includes.
8978         * maint.h: Fix common/ includes.
8979         * maint.c: Fix common/ includes.
8980         * main.c: Fix common/ includes.
8981         * machoread.c: Fix common/ includes.
8982         * location.c: Fix common/ includes.
8983         * linux-thread-db.c: Fix common/ includes.
8984         * linux-nat.c: Fix common/ includes.
8985         * linux-fork.c: Fix common/ includes.
8986         * inline-frame.c: Fix common/ includes.
8987         * infrun.c: Fix common/ includes.
8988         * inflow.c: Fix common/ includes.
8989         * inferior.h: Fix common/ includes.
8990         * inferior.c: Fix common/ includes.
8991         * infcmd.c: Fix common/ includes.
8992         * inf-ptrace.c: Fix common/ includes.
8993         * inf-child.c: Fix common/ includes.
8994         * ia64-linux-nat.c: Fix common/ includes.
8995         * i387-tdep.c: Fix common/ includes.
8996         * i386-tdep.c: Fix common/ includes.
8997         * i386-linux-tdep.c: Fix common/ includes.
8998         * i386-linux-nat.c: Fix common/ includes.
8999         * i386-go32-tdep.c: Fix common/ includes.
9000         * i386-fbsd-tdep.c: Fix common/ includes.
9001         * i386-fbsd-nat.c: Fix common/ includes.
9002         * guile/scm-type.c: Fix common/ includes.
9003         * guile/guile.c: Fix common/ includes.
9004         * go32-nat.c: Fix common/ includes.
9005         * gnu-nat.c: Fix common/ includes.
9006         * gdbthread.h: Fix common/ includes.
9007         * gdbarch-selftests.c: Fix common/ includes.
9008         * gdb_usleep.c: Fix common/ includes.
9009         * gdb_select.h: Fix common/ includes.
9010         * gdb_bfd.c: Fix common/ includes.
9011         * gcore.c: Fix common/ includes.
9012         * fork-child.c: Fix common/ includes.
9013         * findvar.c: Fix common/ includes.
9014         * fbsd-nat.c: Fix common/ includes.
9015         * event-top.c: Fix common/ includes.
9016         * event-loop.c: Fix common/ includes.
9017         * dwarf2read.c: Fix common/ includes.
9018         * dwarf2loc.c: Fix common/ includes.
9019         * dwarf2-frame.c: Fix common/ includes.
9020         * dwarf-index-cache.c: Fix common/ includes.
9021         * dtrace-probe.c: Fix common/ includes.
9022         * disasm-selftests.c: Fix common/ includes.
9023         * defs.h: Fix common/ includes.
9024         * csky-tdep.c: Fix common/ includes.
9025         * cp-valprint.c: Fix common/ includes.
9026         * cp-support.h: Fix common/ includes.
9027         * cp-support.c: Fix common/ includes.
9028         * corelow.c: Fix common/ includes.
9029         * completer.h: Fix common/ includes.
9030         * completer.c: Fix common/ includes.
9031         * compile/compile.c: Fix common/ includes.
9032         * compile/compile-loc2c.c: Fix common/ includes.
9033         * compile/compile-cplus-types.c: Fix common/ includes.
9034         * compile/compile-cplus-symbols.c: Fix common/ includes.
9035         * command.h: Fix common/ includes.
9036         * cli/cli-dump.c: Fix common/ includes.
9037         * cli/cli-cmds.c: Fix common/ includes.
9038         * charset.c: Fix common/ includes.
9039         * build-id.c: Fix common/ includes.
9040         * btrace.h: Fix common/ includes.
9041         * btrace.c: Fix common/ includes.
9042         * breakpoint.h: Fix common/ includes.
9043         * breakpoint.c: Fix common/ includes.
9044         * ax.h:
9045         (enum agent_op): Fix common/ includes.
9046         * ax-general.c (struct aop_map): Fix common/ includes.
9047         * ax-gdb.c: Fix common/ includes.
9048         * auxv.c: Fix common/ includes.
9049         * auto-load.c: Fix common/ includes.
9050         * arm-tdep.c: Fix common/ includes.
9051         * arch/riscv.c: Fix common/ includes.
9052         * arch/ppc-linux-common.c: Fix common/ includes.
9053         * arch/i386.c: Fix common/ includes.
9054         * arch/arm.c: Fix common/ includes.
9055         * arch/arm-linux.c: Fix common/ includes.
9056         * arch/arm-get-next-pcs.c: Fix common/ includes.
9057         * arch/amd64.c: Fix common/ includes.
9058         * arch/aarch64.c: Fix common/ includes.
9059         * arch/aarch64-insn.c: Fix common/ includes.
9060         * arch-utils.c: Fix common/ includes.
9061         * amd64-windows-tdep.c: Fix common/ includes.
9062         * amd64-tdep.c: Fix common/ includes.
9063         * amd64-sol2-tdep.c: Fix common/ includes.
9064         * amd64-obsd-tdep.c: Fix common/ includes.
9065         * amd64-nbsd-tdep.c: Fix common/ includes.
9066         * amd64-linux-tdep.c: Fix common/ includes.
9067         * amd64-linux-nat.c: Fix common/ includes.
9068         * amd64-fbsd-tdep.c: Fix common/ includes.
9069         * amd64-fbsd-nat.c: Fix common/ includes.
9070         * amd64-dicos-tdep.c: Fix common/ includes.
9071         * amd64-darwin-tdep.c: Fix common/ includes.
9072         * agent.c: Fix common/ includes.
9073         * ada-lang.h: Fix common/ includes.
9074         * ada-lang.c: Fix common/ includes.
9075         * aarch64-tdep.c: Fix common/ includes.
9076
9077 2019-01-25  Tom Tromey  <tom@tromey.com>
9078
9079         * common/create-version.sh: Use common/version.h.
9080
9081 2019-01-24  Pedro Alves  <palves@redhat.com>
9082
9083         * infrun.c (signal_stop, signal_print, signal_program)
9084         (signal_catch, signal_pass): Now arrays instead of pointers.
9085         (update_signals_program_target, do_target_resume)
9086         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9087         * linux-nat.c (linux_nat_target::pass_signals)
9088         (linux_nat_target::create_inferior, linux_nat_target::attach):
9089         Adjust.
9090         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9091         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9092         * procfs.c (procfs_target::pass_signals): Adjust.
9093         * record-full.c (record_full_target::resume): Adjust.
9094         * remote.c (remote_target::pass_signals)
9095         (remote_target::program_signals): Adjust.
9096         * target-debug.h (target_debug_print_signals): Now takes a
9097         gdb::array_view as parameter.  Adjust.
9098         * target.h (target_ops) <pass_signals, program_signals>: Replace
9099         pointer and length parameters with gdb::array_view.
9100         (target_pass_signals, target_program_signals): Likewise.
9101         * target-delegates.c: Regenerate.
9102
9103 2019-01-24  Pedro Alves  <palves@redhat.com>
9104
9105         * common/forward-scope-exit.h
9106         (forward_scope_exit::forward_scope_exit): Pass arguments to
9107         m_bind_function directly, instead of creating a std::bind and
9108         copying that.
9109
9110 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9111
9112         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9113         for static members.
9114         (pass_in_v_vfp_candidate): Likewise.
9115
9116 2019-01-23  Tom Tromey  <tom@tromey.com>
9117             Pedro Alves  <palves@redhat.com>
9118
9119         * regcache.c (class regcache_invalidator): Remove.
9120         (regcache::raw_write): Use make_scope_exit.
9121
9122 2019-01-23  Tom Tromey  <tom@tromey.com>
9123
9124         * ui-out.h (class ui_out_emit_type): Update comment.
9125
9126 2019-01-23  Tom Tromey  <tom@tromey.com>
9127
9128         * infrun.c (fetch_inferior_event): Update comment.
9129
9130 2019-01-23  Tom Tromey  <tom@tromey.com>
9131             Pedro Alves  <palves@redhat.com>
9132
9133         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9134         parameter.
9135         (fetch_inferior_event): Use SCOPE_EXIT.
9136
9137
9138 2019-01-23  Tom Tromey  <tom@tromey.com>
9139             Pedro Alves  <palves@redhat.com>
9140
9141         * infrun.c (disable_thread_events): Delete.
9142         (stop_all_threads): Use SCOPE_EXIT.
9143
9144 2019-01-23  Tom Tromey  <tom@tromey.com>
9145             Pedro Alves  <palves@redhat.com>
9146
9147         * symfile.c: Include forward-scope-exit.h.
9148         (clear_symtab_users_cleanup): Replace forward declaration with
9149         a FORWARD_SCOPE_EXIT.
9150         (syms_from_objfile_1): Use the forward_scope_exit and
9151         gdb::optional instead of cleanup_function.
9152         (reread_symbols): Use the forward_scope_exit instead of
9153         cleanup_function.
9154         (clear_symtab_users_cleanup): Remove function.
9155
9156 2019-01-23  Tom Tromey  <tom@tromey.com>
9157             Pedro Alves  <palves@redhat.com>
9158
9159         * linux-nat.c: Include scope-exit.h.
9160         (cleanup_target_stop): Remove.
9161         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9162         SCOPE_EXIT.
9163
9164 2019-01-23  Tom Tromey  <tom@tromey.com>
9165             Pedro Alves  <palves@redhat.com>
9166
9167         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9168         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9169
9170 2019-01-23  Tom Tromey  <tom@tromey.com>
9171             Andrew Burgess  <andrew.burgess@embecosm.com>
9172             Pedro Alves  <palves@redhat.com>
9173
9174         * infrun.c (fetch_inferior_event): Use scope_exit.
9175         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9176         * top.c (execute_command): Use scope_exit.
9177         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9178         * utils.c (do_bpstat_clear_actions_cleanup)
9179         (make_bpstat_clear_actions_cleanup): Remove.
9180
9181 2019-01-23  Tom Tromey  <tom@tromey.com>
9182             Pedro Alves  <palves@redhat.com>
9183
9184         * infrun.c: Include "common/scope-exit.h"
9185         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9186         (wait_for_inferior): Use SCOPE_EXIT.
9187         (fetch_inferior_event): Use scope_exit.
9188
9189 2019-01-23  Tom Tromey  <tom@tromey.com>
9190             Pedro Alves  <palves@redhat.com>
9191
9192         * breakpoint.c (create_breakpoint): Remove cleanup.
9193
9194 2019-01-23  Tom Tromey  <tom@tromey.com>
9195             Andrew Burgess  <andrew.burgess@embecosm.com>
9196             Pedro Alves  <palves@redhat.com>
9197
9198 2019-01-23  Pedro Alves  <palves@redhat.com>
9199
9200         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9201
9202 2019-01-23  Pedro Alves  <palves@redhat.com>
9203             Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * gdbthread.h: Include "common/forward-scope-exit.h".
9206         (scoped_finish_thread_state): Redefine custom class in terms of
9207         forward_scope_exit.
9208
9209 2019-01-23  Pedro Alves  <palves@redhat.com>
9210             Andrew Burgess  <andrew.burgess@embecosm.com>
9211
9212         * common/forward-scope-exit.h: New file.
9213
9214 2019-01-23  Pedro Alves  <palves@redhat.com>
9215             Andrew Burgess  <andrew.burgess@embecosm.com>
9216             Tom Tromey  <tom@tromey.com>
9217
9218         * common/scope-exit.h: New file.
9219
9220 2019-01-23  Pedro Alves  <palves@redhat.com>
9221
9222         * common/preprocessor.h (ESC): Rename to ...
9223         (ESC_PARENS): ... this.
9224         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9225         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9226
9227 2019-01-23  Tom Tromey  <tom@tromey.com>
9228
9229         * language.h (class scoped_switch_to_sym_language_if_auto):
9230         Initialize m_lang in both cases.
9231
9232 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9233
9234         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9235         with XCNEW.
9236
9237 2019-01-22  Tom Tromey  <tom@tromey.com>
9238
9239         * corelow.c: Do not include sys/file.h.
9240
9241 2019-01-22  Tom Tromey  <tom@tromey.com>
9242
9243         * tui/tui-wingeneral.h: Include gdb_curses.h.
9244
9245 2019-01-22  Tom Tromey  <tom@tromey.com>
9246
9247         * source-cache.h (class source_cache) <get_source_lines,
9248         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9249
9250 2019-01-22  Tom Tromey  <tom@tromey.com>
9251
9252         * remote-fileio.h (struct remote_target): Declare.
9253
9254 2019-01-22  Tom Tromey  <tom@tromey.com>
9255
9256         * python/py-arch.c: Do not include py-ref.h.
9257         * python/py-bpevent.c: Do not include py-ref.h.
9258         * python/py-cmd.c: Do not include py-ref.h.
9259         * python/py-continueevent.c: Do not include py-ref.h.
9260         * python/py-event.h: Do not include py-ref.h.
9261         * python/py-evtregistry.c: Do not include py-ref.h.
9262         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9263         * python/py-frame.c: Do not include py-ref.h.
9264         * python/py-framefilter.c: Do not include py-ref.h.
9265         * python/py-function.c: Do not include py-ref.h.
9266         * python/py-infevents.c: Do not include py-ref.h.
9267         * python/py-linetable.c: Do not include py-ref.h.
9268         * python/py-objfile.c: Do not include py-ref.h.
9269         * python/py-param.c: Do not include py-ref.h.
9270         * python/py-prettyprint.c: Do not include py-ref.h.
9271         * python/py-progspace.c: Do not include py-ref.h.
9272         * python/py-symbol.c: Do not include py-ref.h.
9273         * python/py-symtab.c: Do not include py-ref.h.
9274         * python/py-type.c: Do not include py-ref.h.
9275         * python/py-unwind.c: Do not include py-ref.h.
9276         * python/py-utils.c: Do not include py-ref.h.
9277         * python/py-value.c: Do not include py-ref.h.
9278         * python/py-varobj.c: Do not include py-ref.h.
9279         * python/py-xmethods.c: Do not include py-ref.h.
9280         * python/python.c: Do not include py-ref.h.
9281         * varobj.c: Do not include py-ref.h.
9282
9283 2019-01-22  Tom Tromey  <tom@tromey.com>
9284
9285         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9286         keyword for bcache.
9287
9288 2019-01-22  Tom Tromey  <tom@tromey.com>
9289
9290         * compile/compile-cplus-types.c: Remove a comment by #include.
9291
9292 2019-01-22  Tom Tromey  <tom@tromey.com>
9293
9294         * compile/gcc-c-plugin.h: Include compile-internal.h.
9295
9296 2019-01-22  Tom Tromey  <tom@tromey.com>
9297
9298         * stabsread.c (EXTERN): Do not define.
9299         (symnum, next_symbol_text_func, processing_gcc_compilation)
9300         (within_function, global_sym_chain, global_stabs)
9301         (previous_stab_code, this_object_header_files)
9302         (n_this_object_header_files)
9303         (n_allocated_this_object_header_files): Define.
9304         * stabsread.h (EXTERN): Never define.  Use "extern".
9305
9306 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9307
9308         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9309         history_value.
9310
9311 2019-01-21  Tom Tromey  <tom@tromey.com>
9312
9313         * ui-out.c: Fix includes.
9314         * tui/tui-source.c: Fix includes.
9315         * target.c: Fix includes.
9316         * remote.c: Fix includes.
9317         * regcache.c: Fix includes.
9318         * python/py-block.c: Fix includes.
9319         * printcmd.c: Fix includes.
9320         * or1k-tdep.c: Fix includes.
9321         * mi/mi-main.c: Fix includes.
9322         * m32r-tdep.c: Fix includes.
9323         * csky-tdep.c: Fix includes.
9324         * compile/compile-cplus-types.c: Fix includes.
9325         * cli/cli-interp.c: Fix includes.
9326
9327 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9328
9329         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9330         for padding.
9331
9332 2019-01-16  Tom Tromey  <tom@tromey.com>
9333
9334         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9335         earlier.
9336         (struct objfile) <msymbols_range>: Move from top level.
9337         <msymbols>: New method.
9338         (class objfile_msymbols): Remove.
9339         * symtab.c (default_collect_symbol_completion_matches_break_on):
9340         Update.
9341         * symmisc.c (dump_msymbols): Update.
9342         * stabsread.c (scan_file_globals): Update.
9343         * objc-lang.c (info_selectors_command, info_classes_command)
9344         (find_methods): Update.
9345         * minsyms.c (find_solib_trampoline_target): Update.
9346         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9347         * coffread.c (coff_symfile_read): Update.
9348         * ada-lang.c (ada_lookup_simple_minsym)
9349         (ada_collect_symbol_completion_matches): Update.
9350
9351 2019-01-16  Tom Tromey  <tom@tromey.com>
9352
9353         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9354         type.  Remove no-argument constructor.
9355         <iterator::operator++>: Simplify.
9356         <begin>: Update.
9357         <end>: Use minimal_symbol_count.
9358
9359 2019-01-16  Tom Tromey  <tom@tromey.com>
9360
9361         * objfiles.h (struct objfile) <psymtabs>: New method.
9362         (class objfile_psymtabs): Remove.
9363         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9364         typedef.
9365         <range>: New method.
9366         (require_partial_symbols): Change return type.
9367         * psymtab.c (require_partial_symbols)
9368         (psym_expand_symtabs_matching): Update.
9369         * mdebugread.c (parse_partial_symbols): Update.
9370         * dbxread.c (dbx_end_psymtab): Update.
9371
9372 2019-01-15  Tom Tromey  <tom@tromey.com>
9373
9374         * symtab.c (lookup_objfile_from_block)
9375         (lookup_symbol_in_objfile_symtabs)
9376         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9377         (find_line_symtab, info_sources_command)
9378         (default_collect_symbol_completion_matches_break_on)
9379         (make_source_files_completion_list): Update.
9380         * symmisc.c (print_objfile_statistics, dump_objfile)
9381         (maintenance_print_symbols, maintenance_info_symtabs)
9382         (maintenance_check_symtabs, maintenance_info_line_tables):
9383         Update.
9384         * source.c (select_source_symtab)
9385         (forget_cached_source_info_for_objfile): Update.
9386         * objfiles.h (class objfile_compunits): Remove.
9387         (struct objfile) <compunits_range>: New typedef.
9388         (compunits): New method.
9389         * objfiles.c (objfile_relocate1): Update.
9390         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9391         * maint.c (count_symtabs_and_blocks): Update.
9392         * linespec.c (iterate_over_all_matching_symtabs): Update.
9393         * cp-support.c (add_symbol_overload_list_qualified): Update.
9394         * coffread.c (coff_symtab_read): Update.
9395         * ada-lang.c (add_nonlocal_symbols)
9396         (ada_collect_symbol_completion_matches)
9397         (ada_add_global_exceptions): Update.
9398
9399 2019-01-15  Tom Tromey  <tom@tromey.com>
9400
9401         * progspace.h (program_space) <objfiles_safe_range>: New
9402         typedef.
9403         <objfiles_safe>: New method.
9404         * objfiles.h (class all_objfiles_safe): Remove.
9405         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9406         * jit.c (jit_inferior_exit_hook): Update.
9407
9408 2019-01-17  Tom Tromey  <tom@tromey.com>
9409
9410         * progspace.h (program_space) <objfiles_range>: New typedef.
9411         <objfiles>: New method.
9412         <objfiles_head>: Rename from objfiles.
9413         (object_files): Update.
9414         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9415         * guile/scm-pretty-print.c
9416         (ppscm_find_pretty_printer_from_objfiles): Update.
9417         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9419         Update.
9420         * python/py-progspace.c (pspy_get_objfiles): Update.
9421         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9422         Update.
9423         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9424         (objfpy_lookup_objfile_by_build_id): Update.
9425         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9426         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9427         Update.
9428         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9429         (expand_symtab_containing_pc, lookup_objfile_from_block)
9430         (lookup_static_symbol, basic_lookup_transparent_type)
9431         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9432         (find_line_symtab, info_sources_command)
9433         (default_collect_symbol_completion_matches_break_on)
9434         (make_source_files_completion_list, find_main_name): Update.
9435         * symmisc.c (print_symbol_bcache_statistics)
9436         (print_objfile_statistics, maintenance_print_symbols)
9437         (maintenance_print_msymbols, maintenance_print_objfiles)
9438         (maintenance_info_symtabs, maintenance_check_symtabs)
9439         (maintenance_expand_symtabs, maintenance_info_line_tables):
9440         Update.
9441         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9442         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9443         (map_overlay_command, unmap_overlay_command)
9444         (simple_overlay_update, expand_symtabs_matching)
9445         (map_symbol_filenames): Update.
9446         * symfile-debug.c (set_debug_symfile): Update.
9447         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9448         Update.
9449         * source.c (select_source_symtab, forget_cached_source_info):
9450         Update.
9451         * solib.c (solib_read_symbols): Update.
9452         * solib-spu.c (append_ocl_sos): Update.
9453         * psymtab.c (maintenance_print_psymbols)
9454         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9455         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9456         * printcmd.c (info_symbol_command): Update.
9457         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9458         Update.
9459         * objfiles.h (class all_objfiles): Remove.
9460         * objfiles.c (have_partial_symbols, have_full_symbols)
9461         (have_minimal_symbols, qsort_cmp, update_section_map)
9462         (shared_objfile_contains_address_p)
9463         (default_iterate_over_objfiles_in_search_order): Update.
9464         * objc-lang.c (info_selectors_command, info_classes_command)
9465         (find_methods): Update.
9466         * minsyms.c (find_solib_trampoline_target): Update.
9467         * maint.c (maintenance_info_sections)
9468         (maintenance_translate_address, count_symtabs_and_blocks):
9469         Update.
9470         * main.c (captured_main_1): Update.
9471         * linux-thread-db.c (try_thread_db_load_from_pdir)
9472         (has_libpthread): Update.
9473         * linespec.c (iterate_over_all_matching_symtabs)
9474         (search_minsyms_for_name): Update.
9475         * jit.c (jit_find_objf_with_entry_addr): Update.
9476         * hppa-tdep.c (find_unwind_entry)
9477         (hppa_lookup_stub_minimal_symbol): Update.
9478         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9479         Update.
9480         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9481         (elf_gnu_ifunc_resolve_by_got): Update.
9482         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9483         * dwarf-index-write.c (save_gdb_index_command): Update.
9484         * cp-support.c (add_symbol_overload_list_qualified): Update.
9485         * breakpoint.c (create_overlay_event_breakpoint)
9486         (create_longjmp_master_breakpoint)
9487         (create_std_terminate_master_breakpoint)
9488         (create_exception_master_breakpoint): Update.
9489         * blockframe.c (find_pc_partial_function): Update.
9490         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9491         (ada_collect_symbol_completion_matches)
9492         (ada_add_global_exceptions): Update.
9493
9494 2019-01-17  Tom Tromey  <tom@tromey.com>
9495
9496         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9497         declare VEC.
9498         (solib_target_parse_libraries): Change return type.
9499         (library_list_start_segment, library_list_start_section)
9500         (library_list_end_library, library_list_start_library); Update.
9501         (solib_target_free_library_list): Remove.
9502         (solib_target_parse_libraries): Remove cleanup.  Change return
9503         type.
9504         (solib_target_current_sos): Update.
9505
9506 2019-01-17  Tom Tromey  <tromey@bapiya>
9507
9508         * valprint.c: Replace "the the" with "the".
9509         * symtab.c: Replace "the the" with "the".
9510         * solib.c: Replace "the the" with "the".
9511         * solib-dsbt.c: Replace "the the" with "the".
9512         * linespec.c: Replace "the the" with "the".
9513         * dwarf2loc.h: Replace "the the" with "the".
9514         * amd64-windows-tdep.c: Replace "the the" with "the".
9515         * aarch64-tdep.c: Replace "the the" with "the".
9516
9517 2019-01-16  Keith Seitz  <keiths@redhat.com>
9518
9519         PR gdb/23773
9520         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9521         <builder>: Rename to ..
9522         <m_builder>: ... this and make private.
9523         (dwarf2_cu::get_builder): New method.  Change all users of
9524         `builder' to use this method.
9525         (dwarf2_start_symtab): Move to ...
9526         (dwarf2_cu::start_symtab): ... here.  Update all callers
9527         (setup_type_unit_groups): Move to ...
9528         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9529         callers.
9530         (dwarf2_cu::reset_builder): New method.
9531         (process_full_compunit, process_full_type_unit): Use
9532         dwarf2_cu::reset_builder.
9533         (follow_die_offset): Record the ancestor CU if it is different
9534         from the followed DIE's CU.
9535         (follow_die_sig_1): Likewise.
9536
9537 2019-01-15  Tom Tromey  <tom@tromey.com>
9538
9539         * remote.c (class remote_state) <buf>: Now a char_vector.
9540         <buf_size>: Remove.
9541         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9542         parameter.
9543         (remote_target::getpkt_or_notif_sane_1)
9544         (remote_target::getpkt_sane)
9545         (remote_target::getpkt_or_notif_sane): Likewise.
9546         (class remote_target) <putpkt>: New overload.
9547         (remote_target::read_frame): Change type of "buf_p".  Remove
9548         sizeof_p parameter.
9549         (packet_ok): New overload.
9550         (packet_check_result): New overload.
9551         Update all uses.
9552
9553 2019-01-14  Tom Tromey  <tom@tromey.com>
9554
9555         * remote-notif.c (handle_notification, remote_notif_ack)
9556         (remote_notif_parse): Make "buf" const.
9557         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9558         const.
9559         (remote_notif_parse, remote_notif_ack, handle_notification):
9560         Likewise.
9561         * remote.c (remote_notif_stop_parse): Make "buf" const.
9562         (remote_target::remote_parse_stop_reply): Make "buf" const.
9563         (remote_notif_stop_ack): Make "buf" const.
9564
9565 2019-01-14  Tom Tromey  <tom@tromey.com>
9566
9567         * remote.c (remote_console_output): Make parameter const.
9568
9569 2019-01-14  Tom Tromey  <tom@tromey.com>
9570
9571         * target-debug.h (target_debug_print_signals): Constify.
9572         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9573         * procfs.c (procfs_target::pass_signals): Update.
9574         * linux-nat.c (linux_nat_target::pass_signals): Update.
9575         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9576         * target-delegates.c: Rebuild.
9577         * remote.c (remote_target::program_signals): Update.
9578         (remote_target::pass_signals): Update.
9579         * target.c (target_pass_signals): Constify argument.
9580         (target_program_signals): Likewise.
9581         * target.h (struct target_ops) <pass_signals, program_signals>:
9582         Constify argument.
9583         (target_pass_signals, target_program_signals): Constify argument.
9584
9585 2019-01-14  Tom Tromey  <tom@tromey.com>
9586
9587         PR tui/28819:
9588         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9589
9590 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9591
9592         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9593         field.
9594         * rs6000-tdep.c: Include reggroups.h.
9595         (IS_V_ALIAS_PSEUDOREG): Define.
9596         (rs6000_register_name): Return names for the "vX" aliases.
9597         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9598         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9599         aliases.  Call default_register_reggroup_p for all other
9600         pseudo-registers.
9601         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9602         New functions.
9603         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9604         Handle "vX" aliases.
9605         (v_alias_pseudo_register_collect): New function.
9606         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9607         (rs6000_gdbarch_init): Initialize "vX" aliases as
9608         pseudo-registers.  Restore registration of
9609         rs6000_pseudo_register_reggroup_p with
9610         set_tdesc_pseudo_register_reggroup_p.
9611
9612 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9613
9614         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9615         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9616         set_gdbarch_num_pseudo_regs.
9617
9618 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9619
9620         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9621         Remove arg prefixname, add do_set and do_show.
9622         Add member functions set_list and show_list.
9623         * cli/cli-style.c (class cli_style_option): Update accordingly.
9624         (style_set_list): Move to file scope.
9625         (style_show_list): Likewise.
9626         (set_style): Call help_list.
9627         (show_style): Call cmd_show_list.
9628         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9629         Update to use the new macro.
9630
9631 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9632
9633         * ada-lang.c (_initialize_ada_language): Expand the help text
9634         for the "catch exception" command.
9635
9636 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9637
9638         * symtab.c (matching_obj_sections): Initialize obj,
9639         declare it closer to its usage.
9640
9641 2019-01-10  Tom Tromey  <tom@tromey.com>
9642
9643         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9644         (basic_inf_threads_range): Remove.
9645         (inf_threads_range, inf_non_exited_threads_range)
9646         (safe_inf_threads_range): Use next_adapter.
9647
9648 2019-01-10  Keith Seitz  <keiths@redhat.com>
9649
9650         PR gdb/23712
9651         PR symtab/23010
9652         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9653         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9654
9655 2019-01-10  Keith Seitz  <keiths@redhat.com>
9656
9657         PR gdb/23712
9658         PR symtab/23010
9659         * dictionary.c (pending_to_vector): Remove.
9660         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9661         Remove _1 suffix, replacing functions of the same name.  Update
9662         all callers.
9663         (dict_create_hashed, dict_create_hashed_expandable)
9664         (dict_create_linear, dict_create_linear_expandable, dict_free)
9665         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9666         Make functions static.
9667
9668 2019-01-10  Keith Seitz  <keiths@redhat.com>
9669
9670         PR gdb/23712
9671         PR symtab/23010
9672         * dictionary.h (struct dictionary): Replace declaration with
9673         multidictionary.
9674         (dict_create_hashed, dict_create_hashed_expandable)
9675         (dict_create_linear, dict_create_linear_expandable)
9676         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9677         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9678         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9679         taking multidictionary argument.
9680         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9681         * block.h (struct block) <dict>: Change to multidictionary
9682         and rename `multidict'.
9683         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9684         symmisc.c: Update all dictionary references to multidictionary.
9685
9686 2019-01-10  Keith Seitz  <keiths@redhat.com>
9687
9688         PR gdb/23712
9689         PR symtab/23010
9690         * dictionary.c: Include unordered_map.
9691         (pending_to_vector): New function.
9692         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9693         Rewrite the non-"_1" functions to take vector instead
9694         of linked list.
9695         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9696         "new" _1 versions of the same name.
9697         (multidictionary): Define.
9698         (std::hash<enum language): New definition.
9699         (collate_pending_symbols_by_language, mdict_create_hashed)
9700         (mdict_create_hashed_expandable, mdict_create_linear)
9701         (mdict_create_linear_expandable, mdict_free)
9702         (find_language_dictionary, create_new_language_dictionary)
9703         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9704         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9705         (mdict_size, mdict_empty): New functions.
9706         * dictionary.h (mdict_iterator): Define.
9707
9708 2019-01-10  Pedro Alves  <palves@redhat.com>
9709
9710         * breakpoint.c (read_uploaded_action)
9711         (create_tracepoint_from_upload): Adjust to use
9712         gdb::unique_xmalloc_ptr.
9713         * ctf.c (ctf_write_uploaded_tp):
9714         (SET_ARRAY_FIELD): Use emplace_back.
9715         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9716         * tracefile-tfile.c (tfile_write_uploaded_tp):
9717         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9718         gdb::unique_xmalloc_ptr.
9719         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9720         at_string, cond_string, cmd_strings>: Replace char pointers
9721         with gdb::unique_xmalloc_ptr.
9722
9723 2019-01-10  Pedro Alves  <palves@redhat.com>
9724
9725         * solib-target.c (library_list_start_library): Don't xstrdup name.
9726
9727 2019-01-10  Pedro Alves  <palves@redhat.com>
9728
9729         * mdebugread.c (parse_partial_symbols): Use
9730         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9731
9732 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * linux-fork.c (scoped_switch_fork_info)
9735         <~scoped_switch_fork_info>: Fix incorrect variable name.
9736
9737 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9738
9739         * linux-fork.c (scoped_switch_fork_info)
9740         <scoped_switch_fork_info>: Make explicit.
9741         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9742
9743 2019-01-10  Tom Tromey  <tom@tromey.com>
9744
9745         * objfiles.h (objfile::reset_psymtabs): Update.
9746         * objfiles.c (objfile::objfile): Update.
9747         * psymtab.h (psymtab_storage::obstack): Update.
9748         (psymtab_storage::m_obstack): Use gdb::optional.
9749         (class psymtab_storage): Update comment.  Remove objfile
9750         parameter.
9751         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9752
9753 2019-01-10  Tom Tromey  <tom@tromey.com>
9754
9755         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9756         <free_psymtabs>: Now private.
9757         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9758         (allocate_psymtab): Use new method.
9759
9760 2019-01-10  Tom Tromey  <tom@tromey.com>
9761
9762         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9763         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9764         * mdebugread.c (parse_partial_symbols): Use
9765         allocate_dependencies.
9766         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9767         allocate_dependencies.
9768         (process_psymtab_comp_unit_reader)
9769         (build_type_psymtab_dependencies): Likewise.
9770         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9771
9772 2019-01-10  Tom Tromey  <tom@tromey.com>
9773
9774         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9775         PSYMBOL_SET_LANGUAGE.
9776         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9777
9778 2019-01-10  Tom Tromey  <tom@tromey.com>
9779
9780         * psymtab.h (psymtab_storage::obstack): New method.
9781         <m_obstack>: Rename from obstack; now private.
9782         * psymtab.c (psymtab_storage): Update.
9783         * dwarf2read.c (create_addrmap_from_index)
9784         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9785         Update.
9786
9787 2019-01-10  Tom Tromey  <tom@tromey.com>
9788
9789         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9790         * objfiles.h (objfile::reset_psymtabs): New method.
9791
9792 2019-01-10  Tom Tromey  <tom@tromey.com>
9793
9794         * symmisc.c (print_symbol_bcache_statistics): Update.
9795         (print_objfile_statistics): Update.
9796         * symfile.c (reread_symbols): Update.
9797         * psymtab.h (class psymtab_storage): New.
9798         * psymtab.c (psymtab_storage): New constructor.
9799         (~psymtab_storage): New destructor.
9800         (require_partial_symbols): Update.
9801         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9802         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9803         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9804         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9805         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9806         (start_psymtab_common, end_psymtab_common)
9807         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9808         (allocate_psymtab): Update.
9809         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9810         Update.
9811         (dump_psymtab_addrmap, maintenance_print_psymbols)
9812         (maintenance_check_psymtabs): Update.
9813         (class objfile_psymtabs): Move to objfiles.h.
9814         * psympriv.h (discard_psymtab): Now inline.
9815         (psymtab_discarder::psymtab_discarder): Update.
9816         (psymtab_discarder::~psymtab_discarder): Update.
9817         (ALL_OBJFILE_PSYMTABS): Rewrite.
9818         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9819         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9820         Remove fields.
9821         <partial_symtabs>: New field.
9822         (class objfile_psymtabs): Move from psymtab.h.  Update.
9823         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9824         psymbol_cache.
9825         (objfile::~objfile): Don't destroy psymbol_cache.
9826         * mdebugread.c (parse_partial_symbols): Update.
9827         * dwarf2read.c (create_addrmap_from_index)
9828         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9829         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9830         (add_partial_subprogram, dwarf2_ranges_read): Update.
9831         * dwarf-index-write.c (write_address_map)
9832         (write_one_signatured_type, recursively_write_psymbols)
9833         (class debug_names, class debug_names, write_psymtabs_to_index):
9834         Update.
9835
9836 2019-01-10  Tom Tromey  <tom@tromey.com>
9837
9838         * symtab.h (SYMBOL_SET_NAMES): Update.
9839         (symbol_set_names): Update.
9840         (MSYMBOL_SET_NAMES): Update.
9841         * symtab.c (symbol_set_names): Change argument to be an
9842         objfile_per_bfd_storage.
9843         * psymtab.c (add_psymbol_to_bcache): Update.
9844         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9845
9846 2019-01-10  Tom Tromey  <tom@tromey.com>
9847
9848         * symtab.c (create_demangled_names_hash): Change argument to be an
9849         objfile_per_bfd_storage.
9850         (symbol_set_names): Update.
9851
9852 2019-01-10  Tom Tromey  <tom@tromey.com>
9853
9854         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9855         init_psymbol_list.
9856         * psymtab.c (init_psymbol_list): Do nothing if already called.
9857         * psympriv.h (init_psymbol_list): Add comment.
9858         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9859         init_psymbol_list.
9860         * dbxread.c (dbx_symfile_read): Unconditionally call
9861         init_psymbol_list.
9862
9863 2019-01-10  Tom Tromey  <tom@tromey.com>
9864
9865         * xcoffread.c (scan_xcoff_symtab): Update.
9866         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9867         "where".
9868         * mdebugread.c (parse_partial_symbols)
9869         (handle_psymbol_enumerators): Update.
9870         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9871         * dbxread.c (read_dbx_symtab): Update.
9872         * psympriv.h (psymbol_placement): New enum.
9873         (add_psymbol_to_list): Update.
9874
9875 2019-01-10  Tom Tromey  <tom@tromey.com>
9876
9877         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9878         static_psymbols parameters.
9879         (scan_xcoff_symtab): Update.
9880         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9881         static_psymbols parameters.
9882         * psympriv.h (start_psymtab_common): Update.
9883         * mdebugread.c (parse_partial_symbols): Update.
9884         * dwarf2read.c (create_partial_symtab): Update.
9885         * dbxread.c (read_dbx_symtab): Update.
9886         (start_psymtab): Remove global_psymbols and static_psymbols
9887         parameters.
9888
9889 2019-01-10  Tom Tromey  <tom@tromey.com>
9890
9891         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9892         * psymtab.c (allocate_psymtab): Add comment.
9893         * psympriv.h (allocate_psymtab): Add comment.
9894         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9895         initializations.
9896         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9897
9898 2019-01-10  Tom Tromey  <tom@tromey.com>
9899
9900         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9901         Don't declare.
9902         * mipsread.c: Include mdebugread.h.
9903         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9904         Declare.
9905         * elfread.c: Include mdebugread.h.
9906
9907 2019-01-09  Tom Tromey  <tom@tromey.com>
9908
9909         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9910         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9911         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9912         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9913         (psym_lookup_symbol, psym_find_last_source_symtab)
9914         (psym_forget_cached_source_info, psym_print_stats)
9915         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9916         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9917         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9918         (psym_find_compunit_symtab_by_address)
9919         (maintenance_print_psymbols, maintenance_info_psymtabs)
9920         (maintenance_check_psymtabs): Use ranged for.
9921         * psymtab.h (class objfile_psymtabs): New.
9922         (require_partial_symbols): Return objfile_psymtabs.
9923         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9924
9925 2019-01-09  Tom Tromey  <tom@tromey.com>
9926
9927         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9928         (find_pc_mapped_section, list_overlays_command)
9929         (map_overlay_command, unmap_overlay_command)
9930         (simple_overlay_update): Use all_objfiles.
9931         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9932         * printcmd.c (info_symbol_command): Use all_objfiles.
9933         * objfiles.h (ALL_OBJSECTIONS): Remove.
9934         * maint.c (maintenance_translate_address): Use all_objfiles.
9935         * gcore.c (gcore_create_callback): Use all_objfiles.
9936         (objfile_find_memory_regions): Likewise.
9937
9938 2019-01-09  Tom Tromey  <tom@tromey.com>
9939
9940         * symtab.c (find_line_symtab, info_sources_command)
9941         (make_source_files_completion_list): Use objfile_compunits.
9942         * source.c (select_source_symtab): Use objfile_compunits.
9943         * objfiles.h (struct objfile): Update comment.
9944         (ALL_OBJFILES): Remove.
9945         (ALL_FILETABS): Remove.
9946         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9947         objfile_compunits.
9948
9949 2019-01-09  Tom Tromey  <tom@tromey.com>
9950
9951         * symmisc.c (print_objfile_statistics, dump_objfile)
9952         (maintenance_print_symbols): Use compunit_filetabs.
9953         * source.c (forget_cached_source_info_for_objfile): Use
9954         compunit_filetabs.
9955         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9956         (ALL_FILETABS): Use compunit_filetabs.
9957         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9958         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9959
9960 2019-01-09  Tom Tromey  <tom@tromey.com>
9961
9962         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9963         (compunit_filetabs): New.
9964         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9965         compunit_filetabs.
9966         (info_sources_command, make_source_files_completion_list): Remove
9967         declaration.
9968         * symmisc.c (print_objfile_statistics, dump_objfile)
9969         (maintenance_print_symbols): Remove declaration.
9970         (maintenance_info_symtabs): Use compunit_filetabs.
9971         (maintenance_info_line_tables): Likewise.
9972         * source.c (select_source_symtab): Change local variable name.
9973         (forget_cached_source_info_for_objfile): Remove declaration.
9974         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9975         * objfiles.c (objfile_relocate1): Remove declaration.
9976         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9977         declaration.
9978         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9979         * coffread.c (coff_symtab_read): Remove declaration.
9980         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9981         compunit_filetabs.
9982
9983 2019-01-09  Tom Tromey  <tom@tromey.com>
9984
9985         * symtab.c (lookup_objfile_from_block)
9986         (find_pc_sect_compunit_symtab, search_symbols)
9987         (default_collect_symbol_completion_matches_break_on): Use
9988         objfile_compunits.
9989         * objfiles.h (ALL_COMPUNITS): Remove.
9990         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9991         * cp-support.c (add_symbol_overload_list_qualified): Use
9992         objfile_compunits.
9993         * ada-lang.c (ada_collect_symbol_completion_matches)
9994         (ada_add_global_exceptions): Use objfile_compunits.
9995
9996 2019-01-09  Tom Tromey  <tom@tromey.com>
9997
9998         * source.c (select_source_symtab)
9999         (forget_cached_source_info_for_objfile): Remove declaration.
10000         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10001         declaration.
10002         * maint.c (count_symtabs_and_blocks): Remove declaration.
10003         * cp-support.c (add_symbol_overload_list_qualified): Remove
10004         declaration.
10005         * coffread.c (coff_symtab_read): Remove declaration.
10006         * symtab.c (lookup_symbol_in_objfile_symtabs)
10007         (basic_lookup_transparent_type_1): Use objfile_compunits.
10008         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10009         (info_sources_command, search_symbols)
10010         (default_collect_symbol_completion_matches_break_on)
10011         (make_source_files_completion_list): Remove declaration.
10012         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10013         (ada_collect_symbol_completion_matches)
10014         (ada_add_global_exceptions): Remove declaration.
10015         * linespec.c (iterate_over_all_matching_symtabs): Use
10016         objfile_compunits.
10017         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10018         (class objfile_compunits): New.
10019         (ALL_COMPUNITS): Use objfile_compunits.
10020         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10021         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10022         objfile_compunits.
10023         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10024
10025 2019-01-09  Tom Tromey  <tom@tromey.com>
10026
10027         * symtab.c (search_symbols)
10028         (default_collect_symbol_completion_matches_break_on): Use
10029         objfile_msymbols.
10030         * ada-lang.c (ada_lookup_simple_minsym)
10031         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10032         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10033         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10034         objfile_msymbols.
10035         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10036         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10037         * objc-lang.c (find_methods): Use objfile_msymbols.
10038         (info_selectors_command, info_classes_command): Likewise.
10039         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10040         * objfiles.h (class objfile_msymbols): New.
10041         (ALL_OBJFILE_MSYMBOLS): Remove.
10042         (ALL_MSYMBOLS): Remove.
10043
10044 2019-01-09  Tom Tromey  <tom@tromey.com>
10045
10046         * common/next-iterator.h (next_adapter): Add Iterator template
10047         parameter.
10048         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10049         (class all_objfiles_safe): New.
10050         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10051         * objfiles.c (put_objfile_before): Update comment.
10052         (add_separate_debug_objfile): Likewise.
10053         (free_all_objfiles): Use all_objfiles_safe.
10054         (objfile_purge_solibs): Likewise.
10055
10056 2019-01-09  Tom Tromey  <tom@tromey.com>
10057
10058         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10059         (expand_symtab_containing_pc, lookup_static_symbol)
10060         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10061         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10062         all_objfiles.
10063         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10064         * breakpoint.c (create_overlay_event_breakpoint)
10065         (create_longjmp_master_breakpoint)
10066         (create_std_terminate_master_breakpoint)
10067         (create_exception_master_breakpoint): Use all_objfiles.
10068         * linux-thread-db.c (try_thread_db_load_from_pdir)
10069         (has_libpthread): Use all_objfiles.
10070         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10071         * linespec.c (iterate_over_all_matching_symtabs)
10072         (search_minsyms_for_name): Use all_objfiles.
10073         * maint.c (maintenance_info_sections): Use all_objfiles.
10074         * main.c (captured_main_1): Use all_objfiles.
10075         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10076         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10077         * guile/scm-pretty-print.c
10078         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10079         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10080         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10081         (maintenance_print_msymbols): Use all_objfiles.
10082         * source.c (select_source_symtab): Use all_objfiles.
10083         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10084         * symfile.c (remove_symbol_file_command)
10085         (expand_symtabs_matching, map_symbol_filenames): Use
10086         all_objfiles.
10087         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10088         all_objfiles.
10089         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10090         * objc-lang.c (find_methods): Use all_objfiles.
10091         * objfiles.c (have_partial_symbols, have_full_symbols)
10092         (have_minimal_symbols, qsort_cmp)
10093         (default_iterate_over_objfiles_in_search_order): Use
10094         all_objfiles.
10095         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10096         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10097         (maintenance_check_psymtabs): Use all_objfiles.
10098         (ALL_PSYMTABS): Remove.
10099         * compile/compile-object-run.c (do_module_cleanup): Use
10100         all_objfiles.
10101         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10102         * cp-support.c (add_symbol_overload_list_qualified): Use
10103         all_objfiles.
10104         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10105         Use all_objfiles.
10106         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10107         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10108         all_objfiles.
10109         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10110         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10111         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10112         Uses all_objfiles.
10113         * solib.c (solib_read_symbols): Use all_objfiles
10114
10115 2019-01-09  Tom Tromey  <tom@tromey.com>
10116
10117         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10118         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10119         all_objfiles.
10120         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10121         * symmisc.c (print_symbol_bcache_statistics)
10122         (print_objfile_statistics, maintenance_print_objfiles)
10123         (maintenance_info_symtabs, maintenance_check_symtabs)
10124         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10125         all_objfiles.
10126         * source.c (forget_cached_source_info): Use all_objfiles.
10127         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10128         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10129         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10130         * objfiles.c (update_section_map): Use all_objfiles.
10131         (shared_objfile_contains_address_p): Likewise.
10132         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10133         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10134
10135 2019-01-09  Tom Tromey  <tom@tromey.com>
10136
10137         * common/next-iterator.h: New file.
10138         * objfiles.h (class all_objfiles): New.
10139         (struct objfile_iterator): New.
10140
10141 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10142
10143         * NEWS: Move the description of the changed "frame", "select-frame",
10144          and "info frame" commands to the Changed commands section.
10145
10146 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10147
10148         * gdbtypes.c (check_stub_method_group): Remove handling of old
10149         mangling schemes.
10150         * linespec.c (find_methods): Likewise.
10151         * stabsread.c (read_member_functions): Likewise.
10152         * valops.c (search_struct_method): Likewise.
10153         (value_struct_elt_for_reference): Likewise.
10154         * NEWS: Mention this change.
10155
10156 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10157
10158         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10159         print_source_lines.
10160         * source.c (print_source_lines_base): Update line number check.
10161         (print_source_lines): New function.
10162         (source_lines_range::source_lines_range): New function.
10163         * source.h (class source_lines_range): New class.
10164         (print_source_lines): New declaration.
10165
10166 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10167
10168         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10169
10170 2019-01-08  Tom Tromey  <tom@tromey.com>
10171             Simon Marchi  <simon.marchi@ericsson.com>
10172
10173         PR gdb/24060
10174         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10175         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10176         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10177         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10178         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10179         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10180
10181 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10182
10183         * source.c (select_source_symtab): Move header comment to
10184         declaration in source.h.
10185         (forget_cached_source_info_for_objfile): Likewise.
10186         (forget_cached_source_info): Likewise.
10187         (identify_source_line): Likewise.
10188         * source.h (identify_source_line): Move declaration from symtab.h
10189         and add comment from source.c
10190         (print_source_lines): Likewise.
10191         (forget_cached_source_info_for_objfile): Likewise.
10192         (forget_cached_source_info): Likewise.
10193         (select_source_symtab): Likewise.
10194         (enum print_source_lines_flag): Move definition from symtab.h.
10195         * symtab.h (identify_source_line): Move declaration to source.h.
10196         (print_source_lines): Likewise.
10197         (forget_cached_source_info_for_objfile): Likewise.
10198         (forget_cached_source_info): Likewise.
10199         (select_source_symtab): Likewise.
10200         (enum print_source_lines_flag): Move definition to source.h.
10201         * tui/tui-hooks.c: Add 'source.h' include.
10202
10203 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10204
10205         * source.c (print_source_lines_base): Handle requests to print
10206         reverse line number sequences, and guard against empty lines
10207         string.
10208
10209 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10210
10211         * source.c (print_source_lines_base): Fix skip of '\r' if next
10212         character is '\n'.
10213
10214 2019-01-06  Tom Tromey  <tom@tromey.com>
10215
10216         * c-exp.y (struct c_parse_state) <macro_original_text,
10217         expansion_obstack>: New member.
10218         (macro_original_text, expansion_obstack): Remove globals.
10219         (scan_macro_expansion, scanning_macro_expansion)
10220         (finished_macro_expansion): Update.
10221         (scan_macro_cleanup): Remove.
10222         (yylex, c_parse): Update.
10223
10224 2019-01-06  Tom Tromey  <tom@tromey.com>
10225
10226         * c-exp.y (struct c_parse_state) <strings>: New member.
10227         (operator_stoken): Update.
10228
10229 2019-01-06  Tom Tromey  <tom@tromey.com>
10230
10231         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10232         (union type_stack_elt) <typelist_val>: Now a pointer to
10233         std::vector.
10234         (type_stack_cleanup): Don't declare.
10235         (push_typelist): Update.
10236         * parse.c (pop_typelist): Return a std::vector.
10237         (push_typelist): Take a std::vector.
10238         (follow_types): Update.  Do not free args.
10239         (type_stack_cleanup): Remove.
10240         * c-exp.y (struct c_parse_state): New.
10241         (cpstate): New global.
10242         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10243         (nonempty_typelist): Update.
10244         (func_mod): Create a new vector.
10245         (c_parse): Create a c_parse_state.
10246         (check_parameter_typelist): Do not delete params.
10247         (function_method): Update.  Do not delete type_list.
10248
10249 2019-01-06  Tom Tromey  <tom@tromey.com>
10250
10251         PR gdb/28155:
10252         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10253         check_typedef.
10254         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10255         (print_return_value): Likewise.
10256
10257 2019-01-05  Tom Tromey  <tom@tromey.com>
10258
10259         * contrib/cleanup_check.py: Remove.
10260         * contrib/gcc-with-excheck: Remove.
10261         * contrib/exsummary.py: Remove.
10262         * contrib/excheck.py: Remove.
10263
10264 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10265
10266         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10267         NULL. Initialize tpprev to NULL instead of assigning it
10268         to NULL on the next statement.
10269         * windows-nat.c (windows_delete_thread): Remove check for
10270         main_thread_id before printing thread exit notifications.
10271         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10272         Remove thread ID check against main_thread_id.
10273         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10274         windows_delete_thread.
10275         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10276
10277 2019-01-04  Tom Tromey  <tom@tromey.com>
10278
10279         * compile/compile.c (_initialize_compile): Use upper case for
10280         metasyntactic variables.
10281         * symmisc.c (_initialize_symmisc): Use upper case for
10282         metasyntactic variables.
10283         * psymtab.c (_initialize_psymtab): Use upper case for
10284         metasyntactic variables.
10285         * demangle.c (demangle_command): Use upper case for metasyntactic
10286         variables.
10287         (_initialize_demangler): Likewise.
10288         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10289         variables.
10290
10291 2019-01-03  Tom Tromey  <tom@tromey.com>
10292
10293         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10294
10295 2019-01-03  Tom Tromey  <tom@tromey.com>
10296
10297         * python/py-symtab.c (salpy_str): Update.
10298         (struct salpy_sal_object) <symtab>: Now a PyObject.
10299         (salpy_dealloc): Update.
10300         (del_objfile_sal): Use gdbpy_ref.
10301
10302 2019-01-03  Tom Tromey  <tom@tromey.com>
10303
10304         * python/py-type.c (convert_field): Use new_reference.  Return
10305         gdbpy_ref.
10306         (make_fielditem): Return gdbpy_ref.
10307         (typy_fields): Update.
10308         (typy_getitem): Update.
10309         (field_name): Return gdbpy_ref.  Use new_reference.
10310         (typy_iterator_iternext): Update.
10311
10312 2019-01-03  Tom Tromey  <tom@tromey.com>
10313
10314         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10315
10316 2019-01-03  Tom Tromey  <tom@tromey.com>
10317
10318         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10319         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10320         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10321         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10322         (pspy_set_type_printers): Likewise.
10323         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10324         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10325         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10326         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10327         (objfpy_set_type_printers): Likewise.
10328
10329 2019-01-03  Tom Tromey  <tom@tromey.com>
10330
10331         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10332         (gdbpy_print_stack): Use gdbpy_err_fetch.
10333         * python/python-internal.h (class gdbpy_err_fetch): New class.
10334         (class gdbpy_enter) <m_error_type, m_error_value,
10335         m_error_traceback>: Remove.
10336         <m_error>: New member.
10337         (gdbpy_exception_to_string): Don't declare.
10338         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10339         * python/py-value.c (convert_value_from_python): Use
10340         gdbpy_err_fetch.
10341         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10342         gdbpy_exception_to_string.
10343         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10344         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10345         gdbpy_err_fetch.
10346
10347 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10348
10349         * linux-nat.c (delete_lwp_cleanup): Delete.
10350         (struct lwp_deleter): New struct.
10351         (lwp_info_up): New typedef.
10352         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10353         lwp_info_up.
10354
10355 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10356
10357         * linux-fork.c (class scoped_switch_fork_info): New class.
10358         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10359
10360 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * valops.c (find_overload_match): Remove use of null_cleanup, and
10363         calls to do_cleanups.
10364
10365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * compile/compile-cplus-types.c
10368         (compile_cplus_instance::decl_name): Handle changes to
10369         cp_func_name.
10370         * cp-support.c (cp_func_name): Update header comment, update
10371         return type.
10372         * cp-support.h (cp_func_name): Update return type in declaration.
10373         * valops.c (find_overload_match): Move temp_func local to top
10374         level of function and change its type.  Use temp_func to hold and
10375         delete temporary string obtained from cp_func_name.
10376
10377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10378
10379         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10380         gdb::char_vector, remove cleanup, and update uses of `msg`.
10381
10382 2019-01-03  Jim Wilson  <jimw@sifive.com>
10383
10384         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10385
10386 2019-01-02  Tom Tromey  <tom@tromey.com>
10387
10388         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10389         (tdesc_parse_xml): Remove cleanups.
10390         * target-descriptions.h (make_cleanup_free_target_description):
10391         Don't declare.
10392         (target_desc_deleter): New struct.
10393         (target_desc_up): New typedef.
10394         * target-descriptions.c (target_desc_deleter::operator()): Rename
10395         from free_target_description.
10396         (make_cleanup_free_target_description): Remove.
10397
10398 2019-01-02  Tom Tromey  <tom@tromey.com>
10399
10400         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10401         constructor, destructor.
10402         (linespec_parser): Remove typedef.
10403         (~linespec_parser): Rename from linespec_parser_delete.
10404         (linespec_lex_to_end, linespec_complete_label)
10405         (linespec_complete): Update.
10406         (decode_line_full): Remove cleanups.
10407         (decode_line_1): Update.
10408
10409 2019-01-02  Tom Tromey  <tom@tromey.com>
10410
10411         * python/python-internal.h (inferior_to_inferior_object): Change
10412         return type.
10413         * python/py-exitedevent.c (create_exited_event_object): Update.
10414         * python/py-inferior.c (inferior_to_inferior_object): Return
10415         gdbpy_ref.
10416         (python_new_inferior, python_inferior_deleted)
10417         (thread_to_thread_object, delete_thread_object)
10418         (build_inferior_list, gdbpy_selected_inferior): Update.
10419         * python/py-infthread.c (create_thread_object): Update.  Also fail
10420         if inferior_to_inferior_object fails.
10421
10422 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10423
10424         * inferior.h (class inferior) <displaced_step_state>: New field.
10425         * infrun.h (struct displaced_step_state): Move here from
10426         infrun.c.  Initialize fields, add constructor.
10427         <inf>: Remove field.
10428         <reset>: New method.
10429         * infrun.c (struct displaced_step_inferior_state): Move to
10430         infrun.h.
10431         (displaced_step_inferior_states): Remove.
10432         (get_displaced_stepping_state): Adust.
10433         (displaced_step_in_progress_any_inferior): Adjust.
10434         (displaced_step_in_progress_thread): Adjust.
10435         (displaced_step_in_progress): Adjust.
10436         (add_displaced_stepping_state): Remove.
10437         (get_displaced_step_closure_by_addr): Adjust.
10438         (remove_displaced_stepping_state): Remove.
10439         (infrun_inferior_exit): Call displaced_step_state.reset.
10440         (use_displaced_stepping): Don't check for NULL.
10441         (displaced_step_prepare_throw): Call
10442         get_displaced_stepping_state.
10443         (displaced_step_fixup): Don't check for NULL.
10444         (prepare_for_detach): Don't check for NULL.
10445
10446 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10447
10448         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10449          in case of call that did not complete.
10450
10451 2019-01-02  Andrey Utkin  <autkin@undo.io>
10452
10453         * symfile.c (find_separate_debug_file): Fix search of debug files for
10454         remote debuggee.
10455
10456 2019-01-02  Tom Tromey  <tom@tromey.com>
10457
10458         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10459         indentation.
10460         * python/py-frame.c (frapy_older): Remove cast.
10461         (frapy_newer): Likewise.
10462         * python/py-breakpoint.c (local_setattro): Remove cast.
10463         * python/py-arch.c (archpy_name): Remove local variable.
10464         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10465
10466 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10467
10468         * unittests/basic_string_view/element_access/char/empty.cc:
10469         Fix year range in copyright header.
10470
10471 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10472
10473         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10474         Delete.
10475         <operator==>: Update with for removed field.
10476         <hash>: Likewise.
10477         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10478         <isa_features>: ...this.
10479         <abi_features>: New field.
10480         (riscv_isa_flen): Update comment.
10481         (riscv_abi_xlen): New declaration.
10482         (riscv_abi_flen): New declaration.
10483         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10484         isa_features.
10485         (riscv_abi_xlen): New function.
10486         (riscv_isa_flen): Update to get answer from isa_features.
10487         (riscv_abi_flen): New function.
10488         (riscv_has_fp_abi): Update to get answer from abi_features.
10489         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10490         xlen and flen.
10491         (riscv_call_info) <xlen, flen>: Update comment.
10492         (riscv_call_arg_struct): Remove invalid assertions
10493         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10494         is removed.
10495         (riscv_gdbarch_init): Gather isa features and abi features
10496         separately, ensure both match on the gdbarch when reusing an old
10497         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10498         a target with 64-bit float hardware.
10499
10500 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10501
10502         * source.c (search_command_helper): Stop reverse search
10503         when line 1 has been searched.
10504
10505 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10506
10507         * record-full.c (record_full_base_target::close): Rewrite
10508         record_full_core_buf_list free logic.
10509
10510 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10511
10512         * break-catch-syscall.c (print_one_catch_syscall): xfree
10513         the last text.
10514
10515 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10516
10517         * top.c (print_gdb_version): Update Copyright year in version
10518         message.
10519
10520 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10521
10522         Update copyright year range in all GDB files.
10523
10524 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10525
10526         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10527
10528 For older changes see ChangeLog-2018.
10529 \f
10530 Local Variables:
10531 mode: change-log
10532 left-margin: 8
10533 fill-column: 74
10534 version-control: never
10535 coding: utf-8
10536 End:
10537