Fix GDB crash when registers cannot be modified.
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Tom Tromey  <tom@tromey.com>
2
3         * common/queue.h: Remove.
4
5 2019-04-19  Tom Tromey  <tom@tromey.com>
6
7         * event-loop.c: Don't include "common/queue.h".
8
9 2019-04-19  Tom Tromey  <tom@tromey.com>
10
11         * remote.c (remote_target): Use delete.
12         * remote-notif.h: Include <list>, not "common/queue.h".
13         (notif_client_p): Remove typedef.
14         (remote_notif_state): Add constructor, destructor, initializer.
15         <notif_queue>: Now a std::list.
16         (remote_notif_state_xfree): Don't declare.
17         * remote-notif.c (remote_notif_process, handle_notification)
18         (remote_notif_state_allocate): Update.
19         (~remote_notif_state): Rename from remote_notif_state_xfree.
20
21 2019-04-19  Tom Tromey  <tom@tromey.com>
22
23         * symfile.c (reread_symbols): Update.
24         * objfiles.c (objfile_register_static_link)
25         (objfile_lookup_static_link): Update
26         (~objfile) Don't delete static_links.
27         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
28
29 2019-04-19  Tom Tromey  <tom@tromey.com>
30
31         * type-stack.h (struct type_stack) <insert>: Constify string.
32         * type-stack.c (type_stack::insert): Constify string.
33         * gdbtypes.h (lookup_template_type): Update.
34         (address_space_name_to_int): Update.
35         * gdbtypes.c (address_space_name_to_int): Make space_identifier
36         const.
37         (lookup_template_type): Make name const.
38         * c-exp.y: Update rules.
39         (lex_one_token, classify_name, classify_inner_name)
40         (c_print_token): Update.
41         * p-exp.y: Update rules.
42         (yylex): Update.
43         * f-exp.y: Update rules.
44         (yylex): Update.
45         * d-exp.y: Update rules.
46         (lex_one_token, classify_name, classify_inner_name): Update.
47         * parse.c (write_dollar_variable, copy_name): Return std::string.
48         * parser-defs.h (copy_name): Change return type.
49         * m2-exp.y: Update rules.
50         (yylex): Update.
51         * go-exp.y (lex_one_token): Update.
52         Update rules.
53         (classify_unsafe_function, classify_packaged_name)
54         (classify_name, yylex): Update.
55
56 2019-04-19  Sergei Trofimovich <siarheit@google.com>
57
58         * configure.ac: add --enable-source-highlight switch.
59         * configure: Regenerate.
60         * top.c (print_gdb_version): plumb --enable-source-highlight
61         status to "show configuration".
62
63 2019-04-19  Tom Tromey  <tromey@adacore.com>
64
65         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
66         Check ADA_TYPE_P.
67         (empty_record, ada_template_to_fixed_record_type_1)
68         (template_to_static_fixed_type)
69         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
70         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
71         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
72         macros.
73
74 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
75
76         PR symtab/24423:
77         * source.c (print_source_lines_base): Advance "iter" when a
78         control character is seen.
79
80 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
81
82         * inferior.h (struct infcall_suspend_state_deleter):
83         Catch exception in destructor to avoid crash.
84
85 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
86
87         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
88         close to the add_com "shell".
89
90 2019-04-18  Tom Tromey  <tromey@adacore.com>
91
92         * process-stratum-target.h (class process_stratum_target)
93         <stratum>: Add "final".
94
95 2019-04-17  Tom Tromey  <tromey@adacore.com>
96
97         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
98         against nullptr before use.
99
100 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
101
102         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
103
104 2019-04-17  Jim Wilson  <jimw@sifive.com>
105             Andrew Burgess  <andrew.burgess@embecosm.com>
106
107         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
108         code read might fail, assume 4-byte breakpoint in that case.
109
110 2019-04-15  Leszek Swirski  <leszeks@google.com>
111
112         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
113         rather than a hand-rolled POD check when checking for forced MEMORY
114         classification.
115
116 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
117
118         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
119         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
120         function.
121         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
122         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
123         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
124         declaration.
125
126 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
127
128         * aarch64-linux-nat.c
129         (aarch64_linux_nat_target::thread_architecture): Add override.
130         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
131         each VQ.
132
133 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
134
135         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
136
137 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
138
139         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
140         target types of size 96-bits, add some additional comments, and
141         check that the builtin type we found was the correct size.
142
143 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
144
145         * utils.c (prompt_for_continue): Don't restore the styling at the
146         end, as applied_style has the wrong value.  This fixes styling in
147         long lists of file names that are interrupted by the "Continue?"
148         prompt.
149
150 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
151
152         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
153         * c-lang.c (c_language_defn): Likewise.
154         (cplus_language_defn): Likewise.
155         (asm_language_defn): Likewise.
156         (minimal_language_defn): Likewise.
157         * d-lang.c (d_language_defn): Likewise.
158         * f-lang.c (f_language_defn): Likewise.
159         * go-lang.c (go_language_defn): Likewise.
160         * language.c (unknown_language_defn): Likewise.
161         (auto_language_defn): Likewise.
162         * language.h (struct language_defn): Remove la_magic field.
163         (LANG_MAGIC): Delete.
164         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
165         * objc-lang.c (objc_language_defn): Likewise.
166         * opencl-lang.c (opencl_language_defn): Likewise.
167         * p-lang.c (pascal_language_defn): Likewise.
168         * rust-lang.c (rust_language_defn): Likewise.
169
170 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
171
172         * riscv-tdep.c (riscv_type_align): New function.
173         (riscv_type_alignment): Delete.
174         (riscv_arg_location): Use 'type_align'.
175         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
176
177 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
178
179         * gdbtypes.c (type_align): A struct with no non-static fields also
180         has alignment of 1.
181
182 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
183
184         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
185         component to 0.
186         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
187         member.
188         (riscv_struct_info::analyse): New implementation using new
189         analyse_inner member function.
190         (riscv_struct_info::field_offset): New member function.
191         (riscv_struct_info::m_offsets): New member variable.
192         (riscv_struct_info::analyse_inner): New private member function,
193         takes the old implementation of riscv_struct_info::analyse but
194         extended to track field offsets.
195         (riscv_call_arg_struct): Update the struct folding special cases
196         to handle cases where empty C++ structs, which are non-zero
197         length, are found.
198         (riscv_arg_location): Initialise the length of each location, a
199         non-zero length now indicates the location is in use.
200         (riscv_push_dummy_call): Allow for the first location having a
201         non-zero offset when setting up arguments.
202         (riscv_return_value): Likewise, but for return values.
203
204 2019-04-11  Tom Tromey  <tromey@adacore.com>
205
206         * utils.c (internal_vproblem): Make "msg" const.
207
208 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
209
210         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
211         * trad-frame.c (trad_frame_reset_saved_regs): New function.
212         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
213         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
214
215 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
216
217         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
218         function.
219         (fill_gregset): Call amd64_linux_collect_native_gregset instead
220         of amd64_collect_native_gregset.
221         (amd64_linux_nat_target::store_registers): Likewise.
222
223 2019-04-10  Tom Tromey  <tom@tromey.com>
224
225         * symtab.c (lookup_global_symbol_from_objfile)
226         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
227         * objfiles.h (class separate_debug_iterator): New.
228         (class separate_debug_range): New.
229         (struct objfile) <separate_debug_objfiles>: New method.
230         (objfile_separate_debug_iterate): Don't declare.
231         * objfiles.c (separate_debug_iterator::operator++): Rename from
232         objfile_separate_debug_iterate.
233         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
234         iterator.
235         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
236         iterator.
237
238 2019-04-10  Tom Tromey  <tom@tromey.com>
239
240         * symfile.c (reread_symbols): Remove old comment.
241         * objfiles.c (free_all_objfiles): Fix a typo.
242
243 2019-04-10  Tom Tromey  <tom@tromey.com>
244
245         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
246         * minsyms.c (lookup_minimal_symbol): Use foreach.
247         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
248         (lookup_minimal_symbol_solib_trampoline): Likewise.
249         * symfile.c (reread_symbols): Use foreach.
250
251 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
252             Tom Tromey  <tromey@adacore.com>
253
254         PR rust/24414:
255         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
256         (rust_lex_int_test): Change "value" to be LONGEST.
257         (rust_lex_tests): Add test for long integer literal.
258
259 2019-04-09  Tom Tromey  <tromey@adacore.com>
260
261         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
262         to bool.
263         (extended_remote_target::attach): Update.
264         (remote_target::remote_notice_new_inferior): Update.
265         (remote_target::add_current_inferior_and_thread): Update.
266         * inferior.c (exit_inferior_1): Use "false".
267         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
268
269 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
270
271         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
272         the "start" command.
273
274 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
275
276         * python/py-inferior.c (infpy_thread_from_thread_handle):
277         Adjust comments to reflect renaming of thread_from_thread_handle
278         to thread_from_handle.  Adjust keywords.  Fix type error message.
279         (inferior_object_methods): Add thread_from_handle.  Retain
280         thread_from_thread_handle, but mark it as deprecated.
281
282 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
283
284         * gdbthread.h (find_thread_by_handle): Revise declaration.
285         * thread.c (find_thread_by_handle): Likewise.  Adjust
286         implementation too.
287         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
288         support for buffer objects as handles.
289
290 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
291
292         * python/py-infthread.c (thpy_thread_handle): New function.
293         (thread_object_methods): Register thpy_thread_handle.
294
295 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
296
297         * gdbthread.h (thread_to_thread_handle): Declare.
298         * thread.c (gdbtypes.h): Include.
299         (thread_to_thread_handle): New function.
300
301         * target.h (struct target_ops): Add thread_info_to_thread_handle.
302         (target_thread_info_to_thread_handle): Declare.
303         * target.c (target_thread_info_to_thread_handle): New function.
304         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
305         * target-delegates.c: Regenerate.
306
307         * linux-thread-db.c (class thread_db_target): Add method
308         thread_info_to_thread_handle.
309         (thread_db_target::thread_info_to_thread_handle): Define.
310         * remote.c (class remote_target): Add new method
311         thread_info_to_thread_handle.
312         (remote_target::thread_info_to_thread_handle): Define.
313
314 2019-04-08  Pedro Alves  <palves@redhat.com>
315
316         * common/common-exceptions.c (throw_exception): Don't create
317         named object to throw; throw directly.
318         (throw_it): Likewise.  Don't initialize gdb_exception::message
319         here, with new; pass FMT and AP to the ctor instead.
320         * common/common-exceptions.h: Include <string>.
321         (gdb_exception::gdb_exception(enum return_reason, enum errors,
322         const char *, va_list)): New ctor.  Use std::make_shared.
323         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
324         errors)): Delete.
325         (gdb_exception_error::gdb_exception_error(enum errors, const char
326         *, va_list)): New.
327         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
328         Add assertion.
329         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
330         errors)): Delete.
331         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
332         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
333         Add assertion.
334
335 2019-04-08  Tom Tromey  <tom@tromey.com>
336
337         * valops.c (value_rtti_indirect_type): Replace throw_exception
338         with throw.
339         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
340         with throw.
341         * thread.c (thr_try_catch_cmd): Replace throw_exception with
342         throw.
343         * target.c (target_translate_tls_address): Replace throw_exception
344         with throw.
345         * stack.c (frame_apply_command_count): Replace throw_exception
346         with throw.
347         * solib-spu.c (append_ocl_sos): Replace throw_exception with
348         throw.
349         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
350         with throw.
351         * rs6000-tdep.c (rs6000_frame_cache)
352         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
353         * remote.c: Replace throw_exception with throw.
354         * record-full.c (record_full_message, record_full_wait_1)
355         (record_full_restore): Replace throw_exception with throw.
356         * record-btrace.c:
357         (get_thread_current_frame_id, record_btrace_start_replaying)
358         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
359         (cmd_record_btrace_start): Replace throw_exception with throw.
360         * parse.c (parse_exp_in_context_1): Replace throw_exception with
361         throw.
362         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
363         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
364         * linespec.c:
365         (find_linespec_symbols): Replace throw_exception with throw.
366         * infrun.c (displaced_step_prepare, resume): Replace
367         throw_exception with throw.
368         * infcmd.c (post_create_inferior): Replace throw_exception with
369         throw.
370         * inf-loop.c (inferior_event_handler): Replace throw_exception
371         with throw.
372         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
373         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
374         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
375         (get_prev_frame_always, get_frame_pc_if_available)
376         (get_frame_address_in_block_if_available, get_frame_language):
377         Replace throw_exception with throw.
378         * frame-unwind.c (frame_unwind_try_unwinder): Replace
379         throw_exception with throw.
380         * eval.c (fetch_subexp_value, evaluate_var_value)
381         (evaluate_funcall, evaluate_subexp_standard): Replace
382         throw_exception with throw.
383         * dwarf2loc.c (call_site_find_chain)
384         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
385         Replace throw_exception with throw.
386         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
387         with throw.
388         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
389         throw.
390         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
391         * completer.c (complete_line_internal): Replace throw_exception
392         with throw.
393         * compile/compile-object-run.c (compile_object_run): Replace
394         throw_exception with throw.
395         * cli/cli-script.c (process_next_line): Replace throw_exception
396         with throw.
397         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
398         (btrace_enable, btrace_maint_update_pt_packets): Replace
399         throw_exception with throw.
400         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
401         throw_exception with throw.
402         * break-catch-throw.c (re_set_exception_catchpoint): Replace
403         throw_exception with throw.
404         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
405         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
406         * aarch64-tdep.c (aarch64_make_prologue_cache)
407         (aarch64_make_stub_cache): Replace throw_exception with throw.
408
409 2019-04-08  Tom Tromey  <tom@tromey.com>
410
411         * common/common-exceptions.c (throw_exception): Rename from
412         throw_exception_cxx.  Remove old copy.  Make argument const.
413         (throw_it): Create and throw exception objects directly.
414         * common/common-exceptions.h (throw_exception): Make argument
415         const.
416         (struct gdb_exception_error): Add constructor.
417         (struct gdb_exception_quit): Add constructor.
418
419 2019-04-08  Tom Tromey  <tom@tromey.com>
420
421         * common/common-exceptions.h (exception_rethrow): Don't declare.
422         (TRY_SJLJ): Update comment.
423         (TRY, CATCH, END_CATCH): Remove.
424         * common/common-exceptions.c (exception_rethrow): Remove.
425
426 2019-04-08  Tom Tromey  <tom@tromey.com>
427
428         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
429         Remove.
430         (gdb_exception_error): Rename from
431         gdb_exception_RETURN_MASK_ERROR.
432         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
433         (gdb_quit_bad_alloc): Update.
434         * aarch64-tdep.c: Update.
435         * ada-lang.c: Update.
436         * ada-typeprint.c: Update.
437         * ada-valprint.c: Update.
438         * amd64-tdep.c: Update.
439         * arch-utils.c: Update.
440         * break-catch-throw.c: Update.
441         * breakpoint.c: Update.
442         * btrace.c: Update.
443         * c-varobj.c: Update.
444         * cli/cli-cmds.c: Update.
445         * cli/cli-interp.c: Update.
446         * cli/cli-script.c: Update.
447         * common/common-exceptions.c: Update.
448         * common/new-op.c: Update.
449         * common/selftest.c: Update.
450         * compile/compile-c-symbols.c: Update.
451         * compile/compile-cplus-symbols.c: Update.
452         * compile/compile-object-load.c: Update.
453         * compile/compile-object-run.c: Update.
454         * completer.c: Update.
455         * corelow.c: Update.
456         * cp-abi.c: Update.
457         * cp-support.c: Update.
458         * cp-valprint.c: Update.
459         * darwin-nat.c: Update.
460         * disasm-selftests.c: Update.
461         * dtrace-probe.c: Update.
462         * dwarf-index-cache.c: Update.
463         * dwarf-index-write.c: Update.
464         * dwarf2-frame-tailcall.c: Update.
465         * dwarf2-frame.c: Update.
466         * dwarf2loc.c: Update.
467         * dwarf2read.c: Update.
468         * eval.c: Update.
469         * event-loop.c: Update.
470         * event-top.c: Update.
471         * exec.c: Update.
472         * f-valprint.c: Update.
473         * fbsd-tdep.c: Update.
474         * frame-unwind.c: Update.
475         * frame.c: Update.
476         * gdbtypes.c: Update.
477         * gnu-v3-abi.c: Update.
478         * guile/guile-internal.h: Update.
479         * guile/scm-block.c: Update.
480         * guile/scm-breakpoint.c: Update.
481         * guile/scm-cmd.c: Update.
482         * guile/scm-disasm.c: Update.
483         * guile/scm-frame.c: Update.
484         * guile/scm-lazy-string.c: Update.
485         * guile/scm-math.c: Update.
486         * guile/scm-param.c: Update.
487         * guile/scm-ports.c: Update.
488         * guile/scm-pretty-print.c: Update.
489         * guile/scm-symbol.c: Update.
490         * guile/scm-symtab.c: Update.
491         * guile/scm-type.c: Update.
492         * guile/scm-value.c: Update.
493         * i386-linux-tdep.c: Update.
494         * i386-tdep.c: Update.
495         * inf-loop.c: Update.
496         * infcall.c: Update.
497         * infcmd.c: Update.
498         * infrun.c: Update.
499         * jit.c: Update.
500         * language.c: Update.
501         * linespec.c: Update.
502         * linux-fork.c: Update.
503         * linux-nat.c: Update.
504         * linux-tdep.c: Update.
505         * linux-thread-db.c: Update.
506         * main.c: Update.
507         * mi/mi-cmd-break.c: Update.
508         * mi/mi-cmd-stack.c: Update.
509         * mi/mi-interp.c: Update.
510         * mi/mi-main.c: Update.
511         * objc-lang.c: Update.
512         * p-valprint.c: Update.
513         * parse.c: Update.
514         * ppc-linux-tdep.c: Update.
515         * printcmd.c: Update.
516         * python/py-arch.c: Update.
517         * python/py-breakpoint.c: Update.
518         * python/py-cmd.c: Update.
519         * python/py-finishbreakpoint.c: Update.
520         * python/py-frame.c: Update.
521         * python/py-framefilter.c: Update.
522         * python/py-gdb-readline.c: Update.
523         * python/py-inferior.c: Update.
524         * python/py-infthread.c: Update.
525         * python/py-lazy-string.c: Update.
526         * python/py-linetable.c: Update.
527         * python/py-objfile.c: Update.
528         * python/py-param.c: Update.
529         * python/py-prettyprint.c: Update.
530         * python/py-progspace.c: Update.
531         * python/py-record-btrace.c: Update.
532         * python/py-record.c: Update.
533         * python/py-symbol.c: Update.
534         * python/py-type.c: Update.
535         * python/py-unwind.c: Update.
536         * python/py-utils.c: Update.
537         * python/py-value.c: Update.
538         * python/python.c: Update.
539         * record-btrace.c: Update.
540         * record-full.c: Update.
541         * remote-fileio.c: Update.
542         * remote.c: Update.
543         * riscv-tdep.c: Update.
544         * rs6000-aix-tdep.c: Update.
545         * rs6000-tdep.c: Update.
546         * rust-exp.y: Update.
547         * rust-lang.c: Update.
548         * s390-tdep.c: Update.
549         * selftest-arch.c: Update.
550         * solib-dsbt.c: Update.
551         * solib-frv.c: Update.
552         * solib-spu.c: Update.
553         * solib-svr4.c: Update.
554         * solib.c: Update.
555         * sparc64-linux-tdep.c: Update.
556         * stack.c: Update.
557         * symfile-mem.c: Update.
558         * symmisc.c: Update.
559         * target.c: Update.
560         * thread.c: Update.
561         * top.c: Update.
562         * tracefile-tfile.c: Update.
563         * tui/tui.c: Update.
564         * typeprint.c: Update.
565         * unittests/cli-utils-selftests.c: Update.
566         * unittests/parse-connection-spec-selftests.c: Update.
567         * valops.c: Update.
568         * valprint.c: Update.
569         * value.c: Update.
570         * varobj.c: Update.
571         * windows-nat.c: Update.
572         * x86-linux-nat.c: Update.
573         * xml-support.c: Update.
574
575 2019-04-08  Tom Tromey  <tom@tromey.com>
576
577         * xml-support.c: Use C++ exception handling.
578         * x86-linux-nat.c: Use C++ exception handling.
579         * windows-nat.c: Use C++ exception handling.
580         * varobj.c: Use C++ exception handling.
581         * value.c: Use C++ exception handling.
582         * valprint.c: Use C++ exception handling.
583         * valops.c: Use C++ exception handling.
584         * unittests/parse-connection-spec-selftests.c: Use C++ exception
585         handling.
586         * unittests/cli-utils-selftests.c: Use C++ exception handling.
587         * typeprint.c: Use C++ exception handling.
588         * tui/tui.c: Use C++ exception handling.
589         * tracefile-tfile.c: Use C++ exception handling.
590         * top.c: Use C++ exception handling.
591         * thread.c: Use C++ exception handling.
592         * target.c: Use C++ exception handling.
593         * symmisc.c: Use C++ exception handling.
594         * symfile-mem.c: Use C++ exception handling.
595         * stack.c: Use C++ exception handling.
596         * sparc64-linux-tdep.c: Use C++ exception handling.
597         * solib.c: Use C++ exception handling.
598         * solib-svr4.c: Use C++ exception handling.
599         * solib-spu.c: Use C++ exception handling.
600         * solib-frv.c: Use C++ exception handling.
601         * solib-dsbt.c: Use C++ exception handling.
602         * selftest-arch.c: Use C++ exception handling.
603         * s390-tdep.c: Use C++ exception handling.
604         * rust-lang.c: Use C++ exception handling.
605         * rust-exp.y: Use C++ exception handling.
606         * rs6000-tdep.c: Use C++ exception handling.
607         * rs6000-aix-tdep.c: Use C++ exception handling.
608         * riscv-tdep.c: Use C++ exception handling.
609         * remote.c: Use C++ exception handling.
610         * remote-fileio.c: Use C++ exception handling.
611         * record-full.c: Use C++ exception handling.
612         * record-btrace.c: Use C++ exception handling.
613         * python/python.c: Use C++ exception handling.
614         * python/py-value.c: Use C++ exception handling.
615         * python/py-utils.c: Use C++ exception handling.
616         * python/py-unwind.c: Use C++ exception handling.
617         * python/py-type.c: Use C++ exception handling.
618         * python/py-symbol.c: Use C++ exception handling.
619         * python/py-record.c: Use C++ exception handling.
620         * python/py-record-btrace.c: Use C++ exception handling.
621         * python/py-progspace.c: Use C++ exception handling.
622         * python/py-prettyprint.c: Use C++ exception handling.
623         * python/py-param.c: Use C++ exception handling.
624         * python/py-objfile.c: Use C++ exception handling.
625         * python/py-linetable.c: Use C++ exception handling.
626         * python/py-lazy-string.c: Use C++ exception handling.
627         * python/py-infthread.c: Use C++ exception handling.
628         * python/py-inferior.c: Use C++ exception handling.
629         * python/py-gdb-readline.c: Use C++ exception handling.
630         * python/py-framefilter.c: Use C++ exception handling.
631         * python/py-frame.c: Use C++ exception handling.
632         * python/py-finishbreakpoint.c: Use C++ exception handling.
633         * python/py-cmd.c: Use C++ exception handling.
634         * python/py-breakpoint.c: Use C++ exception handling.
635         * python/py-arch.c: Use C++ exception handling.
636         * printcmd.c: Use C++ exception handling.
637         * ppc-linux-tdep.c: Use C++ exception handling.
638         * parse.c: Use C++ exception handling.
639         * p-valprint.c: Use C++ exception handling.
640         * objc-lang.c: Use C++ exception handling.
641         * mi/mi-main.c: Use C++ exception handling.
642         * mi/mi-interp.c: Use C++ exception handling.
643         * mi/mi-cmd-stack.c: Use C++ exception handling.
644         * mi/mi-cmd-break.c: Use C++ exception handling.
645         * main.c: Use C++ exception handling.
646         * linux-thread-db.c: Use C++ exception handling.
647         * linux-tdep.c: Use C++ exception handling.
648         * linux-nat.c: Use C++ exception handling.
649         * linux-fork.c: Use C++ exception handling.
650         * linespec.c: Use C++ exception handling.
651         * language.c: Use C++ exception handling.
652         * jit.c: Use C++ exception handling.
653         * infrun.c: Use C++ exception handling.
654         * infcmd.c: Use C++ exception handling.
655         * infcall.c: Use C++ exception handling.
656         * inf-loop.c: Use C++ exception handling.
657         * i386-tdep.c: Use C++ exception handling.
658         * i386-linux-tdep.c: Use C++ exception handling.
659         * guile/scm-value.c: Use C++ exception handling.
660         * guile/scm-type.c: Use C++ exception handling.
661         * guile/scm-symtab.c: Use C++ exception handling.
662         * guile/scm-symbol.c: Use C++ exception handling.
663         * guile/scm-pretty-print.c: Use C++ exception handling.
664         * guile/scm-ports.c: Use C++ exception handling.
665         * guile/scm-param.c: Use C++ exception handling.
666         * guile/scm-math.c: Use C++ exception handling.
667         * guile/scm-lazy-string.c: Use C++ exception handling.
668         * guile/scm-frame.c: Use C++ exception handling.
669         * guile/scm-disasm.c: Use C++ exception handling.
670         * guile/scm-cmd.c: Use C++ exception handling.
671         * guile/scm-breakpoint.c: Use C++ exception handling.
672         * guile/scm-block.c: Use C++ exception handling.
673         * guile/guile-internal.h: Use C++ exception handling.
674         * gnu-v3-abi.c: Use C++ exception handling.
675         * gdbtypes.c: Use C++ exception handling.
676         * frame.c: Use C++ exception handling.
677         * frame-unwind.c: Use C++ exception handling.
678         * fbsd-tdep.c: Use C++ exception handling.
679         * f-valprint.c: Use C++ exception handling.
680         * exec.c: Use C++ exception handling.
681         * event-top.c: Use C++ exception handling.
682         * event-loop.c: Use C++ exception handling.
683         * eval.c: Use C++ exception handling.
684         * dwarf2read.c: Use C++ exception handling.
685         * dwarf2loc.c: Use C++ exception handling.
686         * dwarf2-frame.c: Use C++ exception handling.
687         * dwarf2-frame-tailcall.c: Use C++ exception handling.
688         * dwarf-index-write.c: Use C++ exception handling.
689         * dwarf-index-cache.c: Use C++ exception handling.
690         * dtrace-probe.c: Use C++ exception handling.
691         * disasm-selftests.c: Use C++ exception handling.
692         * darwin-nat.c: Use C++ exception handling.
693         * cp-valprint.c: Use C++ exception handling.
694         * cp-support.c: Use C++ exception handling.
695         * cp-abi.c: Use C++ exception handling.
696         * corelow.c: Use C++ exception handling.
697         * completer.c: Use C++ exception handling.
698         * compile/compile-object-run.c: Use C++ exception handling.
699         * compile/compile-object-load.c: Use C++ exception handling.
700         * compile/compile-cplus-symbols.c: Use C++ exception handling.
701         * compile/compile-c-symbols.c: Use C++ exception handling.
702         * common/selftest.c: Use C++ exception handling.
703         * common/new-op.c: Use C++ exception handling.
704         * cli/cli-script.c: Use C++ exception handling.
705         * cli/cli-interp.c: Use C++ exception handling.
706         * cli/cli-cmds.c: Use C++ exception handling.
707         * c-varobj.c: Use C++ exception handling.
708         * btrace.c: Use C++ exception handling.
709         * breakpoint.c: Use C++ exception handling.
710         * break-catch-throw.c: Use C++ exception handling.
711         * arch-utils.c: Use C++ exception handling.
712         * amd64-tdep.c: Use C++ exception handling.
713         * ada-valprint.c: Use C++ exception handling.
714         * ada-typeprint.c: Use C++ exception handling.
715         * ada-lang.c: Use C++ exception handling.
716         * aarch64-tdep.c: Use C++ exception handling.
717
718 2019-04-08  Tom Tromey  <tom@tromey.com>
719
720         * xml-support.c (gdb_xml_parser::parse): Update.
721         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
722         * value.c (show_convenience): Update.
723         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
724         (test_parse_flags_qcs): Update.
725         * thread.c (thr_try_catch_cmd): Update.
726         * target.c (target_translate_tls_address): Update.
727         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
728         (info_frame_command_core, frame_apply_command_count): Update.
729         * rust-exp.y (rust_lex_exception_test): Update.
730         * riscv-tdep.c (riscv_print_one_register_info): Update.
731         * remote.c (remote_target::enable_btrace): Update.
732         * record-btrace.c (record_btrace_enable_warn): Update.
733         * python/py-utils.c (gdbpy_convert_exception): Update.
734         * printcmd.c (do_one_display, print_variable_and_value): Update.
735         * mi/mi-main.c (mi_print_exception): Update.
736         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
737         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
738         * linux-nat.c (linux_nat_target::attach): Update.
739         * linux-fork.c (class scoped_switch_fork_info): Update.
740         * infrun.c (displaced_step_prepare): Update.
741         * infcall.c (call_function_by_hand_dummy): Update.
742         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
743         * gnu-v3-abi.c (print_one_vtable): Update.
744         * frame.c (get_prev_frame_always): Update.
745         * f-valprint.c (info_common_command_for_block): Update.
746         * exec.c (try_open_exec_file): Update.
747         * exceptions.c (print_exception, exception_print)
748         (exception_fprintf, exception_print_same): Update.
749         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
750         * dwarf-index-cache.c (index_cache::store)
751         (index_cache::lookup_gdb_index): Update.
752         * darwin-nat.c (maybe_cache_shell): Update.
753         * cp-valprint.c (cp_print_value_fields): Update.
754         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
755         (gcc_cplus_symbol_address): Update.
756         * compile/compile-c-symbols.c (gcc_convert_symbol)
757         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
758         * common/selftest.c: Update.
759         * common/common-exceptions.h (struct gdb_exception) <message>: Now
760         a std::string.
761         (exception_try_scope_entry, exception_try_scope_exit): Don't
762         declare.
763         (struct exception_try_scope): Remove.
764         (TRY): Don't use exception_try_scope.
765         (struct gdb_exception): Add constructor, operator=.
766         <what>: New method.
767         (struct gdb_exception_RETURN_MASK_ALL)
768         (struct gdb_exception_RETURN_MASK_ERROR)
769         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
770         (struct gdb_quit_bad_alloc): Update.
771         * common/common-exceptions.c (exception_none): Change
772         initializer.
773         (struct catcher) <state, exception>: Initialize inline.
774         <prev>: Remove member.
775         (current_catcher): Remove.
776         (catchers): New global.
777         (exceptions_state_mc_init): Simplify.
778         (catcher_pop): Remove.
779         (exceptions_state_mc, exceptions_state_mc_catch): Update.
780         (try_scope_depth, exception_try_scope_entry)
781         (exception_try_scope_exit): Remove.
782         (throw_exception_sjlj): Update.
783         (exception_messages, exception_messages_size): Remove.
784         (throw_it): Simplify.
785         (gdb_exception_sliced_copy): Remove.
786         (throw_exception_cxx): Update.
787         * cli/cli-script.c (script_from_file): Update.
788         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
789         Update.
790         * ada-valprint.c (ada_val_print): Update.
791         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
792         (create_excep_cond_exprs): Update.
793
794 2019-04-08  Tom Tromey  <tom@tromey.com>
795
796         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
797         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
798         (TRY, CATCH, END_CATCH): Remove some definitions.
799         * common/common-exceptions.c: Don't use GDB_XCPT.
800         (catcher_list_size): Remove.
801         (throw_exception, throw_it): Simplify.
802
803 2019-04-05  Tom Tromey  <tom@tromey.com>
804
805         Revert the header-sorting patch.
806         * ft32-tdep.c: Revert.
807         * frv-tdep.c: Revert.
808         * frv-linux-tdep.c: Revert.
809         * frame.c: Revert.
810         * frame-unwind.c: Revert.
811         * frame-base.c: Revert.
812         * fork-child.c: Revert.
813         * findvar.c: Revert.
814         * findcmd.c: Revert.
815         * filesystem.c: Revert.
816         * filename-seen-cache.h: Revert.
817         * filename-seen-cache.c: Revert.
818         * fbsd-tdep.c: Revert.
819         * fbsd-nat.h: Revert.
820         * fbsd-nat.c: Revert.
821         * f-valprint.c: Revert.
822         * f-typeprint.c: Revert.
823         * f-lang.c: Revert.
824         * extension.h: Revert.
825         * extension.c: Revert.
826         * extension-priv.h: Revert.
827         * expprint.c: Revert.
828         * exec.h: Revert.
829         * exec.c: Revert.
830         * exceptions.c: Revert.
831         * event-top.c: Revert.
832         * event-loop.c: Revert.
833         * eval.c: Revert.
834         * elfread.c: Revert.
835         * dwarf2read.h: Revert.
836         * dwarf2read.c: Revert.
837         * dwarf2loc.c: Revert.
838         * dwarf2expr.h: Revert.
839         * dwarf2expr.c: Revert.
840         * dwarf2-frame.c: Revert.
841         * dwarf2-frame-tailcall.c: Revert.
842         * dwarf-index-write.h: Revert.
843         * dwarf-index-write.c: Revert.
844         * dwarf-index-common.c: Revert.
845         * dwarf-index-cache.h: Revert.
846         * dwarf-index-cache.c: Revert.
847         * dummy-frame.c: Revert.
848         * dtrace-probe.c: Revert.
849         * disasm.h: Revert.
850         * disasm.c: Revert.
851         * disasm-selftests.c: Revert.
852         * dictionary.c: Revert.
853         * dicos-tdep.c: Revert.
854         * demangle.c: Revert.
855         * dcache.h: Revert.
856         * dcache.c: Revert.
857         * darwin-nat.h: Revert.
858         * darwin-nat.c: Revert.
859         * darwin-nat-info.c: Revert.
860         * d-valprint.c: Revert.
861         * d-namespace.c: Revert.
862         * d-lang.c: Revert.
863         * ctf.c: Revert.
864         * csky-tdep.c: Revert.
865         * csky-linux-tdep.c: Revert.
866         * cris-tdep.c: Revert.
867         * cris-linux-tdep.c: Revert.
868         * cp-valprint.c: Revert.
869         * cp-support.c: Revert.
870         * cp-namespace.c: Revert.
871         * cp-abi.c: Revert.
872         * corelow.c: Revert.
873         * corefile.c: Revert.
874         * continuations.c: Revert.
875         * completer.h: Revert.
876         * completer.c: Revert.
877         * complaints.c: Revert.
878         * coffread.c: Revert.
879         * coff-pe-read.c: Revert.
880         * cli-out.h: Revert.
881         * cli-out.c: Revert.
882         * charset.c: Revert.
883         * c-varobj.c: Revert.
884         * c-valprint.c: Revert.
885         * c-typeprint.c: Revert.
886         * c-lang.c: Revert.
887         * buildsym.c: Revert.
888         * buildsym-legacy.c: Revert.
889         * build-id.h: Revert.
890         * build-id.c: Revert.
891         * btrace.c: Revert.
892         * bsd-uthread.c: Revert.
893         * breakpoint.h: Revert.
894         * breakpoint.c: Revert.
895         * break-catch-throw.c: Revert.
896         * break-catch-syscall.c: Revert.
897         * break-catch-sig.c: Revert.
898         * blockframe.c: Revert.
899         * block.c: Revert.
900         * bfin-tdep.c: Revert.
901         * bfin-linux-tdep.c: Revert.
902         * bfd-target.c: Revert.
903         * bcache.c: Revert.
904         * ax-general.c: Revert.
905         * ax-gdb.h: Revert.
906         * ax-gdb.c: Revert.
907         * avr-tdep.c: Revert.
908         * auxv.c: Revert.
909         * auto-load.c: Revert.
910         * arm-wince-tdep.c: Revert.
911         * arm-tdep.c: Revert.
912         * arm-symbian-tdep.c: Revert.
913         * arm-pikeos-tdep.c: Revert.
914         * arm-obsd-tdep.c: Revert.
915         * arm-nbsd-tdep.c: Revert.
916         * arm-nbsd-nat.c: Revert.
917         * arm-linux-tdep.c: Revert.
918         * arm-linux-nat.c: Revert.
919         * arm-fbsd-tdep.c: Revert.
920         * arm-fbsd-nat.c: Revert.
921         * arm-bsd-tdep.c: Revert.
922         * arch-utils.c: Revert.
923         * arc-tdep.c: Revert.
924         * arc-newlib-tdep.c: Revert.
925         * annotate.h: Revert.
926         * annotate.c: Revert.
927         * amd64-windows-tdep.c: Revert.
928         * amd64-windows-nat.c: Revert.
929         * amd64-tdep.c: Revert.
930         * amd64-sol2-tdep.c: Revert.
931         * amd64-obsd-tdep.c: Revert.
932         * amd64-obsd-nat.c: Revert.
933         * amd64-nbsd-tdep.c: Revert.
934         * amd64-nbsd-nat.c: Revert.
935         * amd64-nat.c: Revert.
936         * amd64-linux-tdep.c: Revert.
937         * amd64-linux-nat.c: Revert.
938         * amd64-fbsd-tdep.c: Revert.
939         * amd64-fbsd-nat.c: Revert.
940         * amd64-dicos-tdep.c: Revert.
941         * amd64-darwin-tdep.c: Revert.
942         * amd64-bsd-nat.c: Revert.
943         * alpha-tdep.c: Revert.
944         * alpha-obsd-tdep.c: Revert.
945         * alpha-nbsd-tdep.c: Revert.
946         * alpha-mdebug-tdep.c: Revert.
947         * alpha-linux-tdep.c: Revert.
948         * alpha-linux-nat.c: Revert.
949         * alpha-bsd-tdep.c: Revert.
950         * alpha-bsd-nat.c: Revert.
951         * aix-thread.c: Revert.
952         * agent.c: Revert.
953         * addrmap.c: Revert.
954         * ada-varobj.c: Revert.
955         * ada-valprint.c: Revert.
956         * ada-typeprint.c: Revert.
957         * ada-tasks.c: Revert.
958         * ada-lang.c: Revert.
959         * aarch64-tdep.c: Revert.
960         * aarch64-ravenscar-thread.c: Revert.
961         * aarch64-newlib-tdep.c: Revert.
962         * aarch64-linux-tdep.c: Revert.
963         * aarch64-linux-nat.c: Revert.
964         * aarch64-fbsd-tdep.c: Revert.
965         * aarch64-fbsd-nat.c: Revert.
966         * aarch32-linux-nat.c: Revert.
967
968 2019-04-05  Tom Tromey  <tom@tromey.com>
969
970         * ft32-tdep.c: Sort headers.
971         * frv-tdep.c: Sort headers.
972         * frv-linux-tdep.c: Sort headers.
973         * frame.c: Sort headers.
974         * frame-unwind.c: Sort headers.
975         * frame-base.c: Sort headers.
976         * fork-child.c: Sort headers.
977         * findvar.c: Sort headers.
978         * findcmd.c: Sort headers.
979         * filesystem.c: Sort headers.
980         * filename-seen-cache.h: Sort headers.
981         * filename-seen-cache.c: Sort headers.
982         * fbsd-tdep.c: Sort headers.
983         * fbsd-nat.h: Sort headers.
984         * fbsd-nat.c: Sort headers.
985         * f-valprint.c: Sort headers.
986         * f-typeprint.c: Sort headers.
987         * f-lang.c: Sort headers.
988         * extension.h: Sort headers.
989         * extension.c: Sort headers.
990         * extension-priv.h: Sort headers.
991         * expprint.c: Sort headers.
992         * exec.h: Sort headers.
993         * exec.c: Sort headers.
994         * exceptions.c: Sort headers.
995         * event-top.c: Sort headers.
996         * event-loop.c: Sort headers.
997         * eval.c: Sort headers.
998         * elfread.c: Sort headers.
999         * dwarf2read.h: Sort headers.
1000         * dwarf2read.c: Sort headers.
1001         * dwarf2loc.c: Sort headers.
1002         * dwarf2expr.h: Sort headers.
1003         * dwarf2expr.c: Sort headers.
1004         * dwarf2-frame.c: Sort headers.
1005         * dwarf2-frame-tailcall.c: Sort headers.
1006         * dwarf-index-write.h: Sort headers.
1007         * dwarf-index-write.c: Sort headers.
1008         * dwarf-index-common.c: Sort headers.
1009         * dwarf-index-cache.h: Sort headers.
1010         * dwarf-index-cache.c: Sort headers.
1011         * dummy-frame.c: Sort headers.
1012         * dtrace-probe.c: Sort headers.
1013         * disasm.h: Sort headers.
1014         * disasm.c: Sort headers.
1015         * disasm-selftests.c: Sort headers.
1016         * dictionary.c: Sort headers.
1017         * dicos-tdep.c: Sort headers.
1018         * demangle.c: Sort headers.
1019         * dcache.h: Sort headers.
1020         * dcache.c: Sort headers.
1021         * darwin-nat.h: Sort headers.
1022         * darwin-nat.c: Sort headers.
1023         * darwin-nat-info.c: Sort headers.
1024         * d-valprint.c: Sort headers.
1025         * d-namespace.c: Sort headers.
1026         * d-lang.c: Sort headers.
1027         * ctf.c: Sort headers.
1028         * csky-tdep.c: Sort headers.
1029         * csky-linux-tdep.c: Sort headers.
1030         * cris-tdep.c: Sort headers.
1031         * cris-linux-tdep.c: Sort headers.
1032         * cp-valprint.c: Sort headers.
1033         * cp-support.c: Sort headers.
1034         * cp-namespace.c: Sort headers.
1035         * cp-abi.c: Sort headers.
1036         * corelow.c: Sort headers.
1037         * corefile.c: Sort headers.
1038         * continuations.c: Sort headers.
1039         * completer.h: Sort headers.
1040         * completer.c: Sort headers.
1041         * complaints.c: Sort headers.
1042         * coffread.c: Sort headers.
1043         * coff-pe-read.c: Sort headers.
1044         * cli-out.h: Sort headers.
1045         * cli-out.c: Sort headers.
1046         * charset.c: Sort headers.
1047         * c-varobj.c: Sort headers.
1048         * c-valprint.c: Sort headers.
1049         * c-typeprint.c: Sort headers.
1050         * c-lang.c: Sort headers.
1051         * buildsym.c: Sort headers.
1052         * buildsym-legacy.c: Sort headers.
1053         * build-id.h: Sort headers.
1054         * build-id.c: Sort headers.
1055         * btrace.c: Sort headers.
1056         * bsd-uthread.c: Sort headers.
1057         * breakpoint.h: Sort headers.
1058         * breakpoint.c: Sort headers.
1059         * break-catch-throw.c: Sort headers.
1060         * break-catch-syscall.c: Sort headers.
1061         * break-catch-sig.c: Sort headers.
1062         * blockframe.c: Sort headers.
1063         * block.c: Sort headers.
1064         * bfin-tdep.c: Sort headers.
1065         * bfin-linux-tdep.c: Sort headers.
1066         * bfd-target.c: Sort headers.
1067         * bcache.c: Sort headers.
1068         * ax-general.c: Sort headers.
1069         * ax-gdb.h: Sort headers.
1070         * ax-gdb.c: Sort headers.
1071         * avr-tdep.c: Sort headers.
1072         * auxv.c: Sort headers.
1073         * auto-load.c: Sort headers.
1074         * arm-wince-tdep.c: Sort headers.
1075         * arm-tdep.c: Sort headers.
1076         * arm-symbian-tdep.c: Sort headers.
1077         * arm-pikeos-tdep.c: Sort headers.
1078         * arm-obsd-tdep.c: Sort headers.
1079         * arm-nbsd-tdep.c: Sort headers.
1080         * arm-nbsd-nat.c: Sort headers.
1081         * arm-linux-tdep.c: Sort headers.
1082         * arm-linux-nat.c: Sort headers.
1083         * arm-fbsd-tdep.c: Sort headers.
1084         * arm-fbsd-nat.c: Sort headers.
1085         * arm-bsd-tdep.c: Sort headers.
1086         * arch-utils.c: Sort headers.
1087         * arc-tdep.c: Sort headers.
1088         * arc-newlib-tdep.c: Sort headers.
1089         * annotate.h: Sort headers.
1090         * annotate.c: Sort headers.
1091         * amd64-windows-tdep.c: Sort headers.
1092         * amd64-windows-nat.c: Sort headers.
1093         * amd64-tdep.c: Sort headers.
1094         * amd64-sol2-tdep.c: Sort headers.
1095         * amd64-obsd-tdep.c: Sort headers.
1096         * amd64-obsd-nat.c: Sort headers.
1097         * amd64-nbsd-tdep.c: Sort headers.
1098         * amd64-nbsd-nat.c: Sort headers.
1099         * amd64-nat.c: Sort headers.
1100         * amd64-linux-tdep.c: Sort headers.
1101         * amd64-linux-nat.c: Sort headers.
1102         * amd64-fbsd-tdep.c: Sort headers.
1103         * amd64-fbsd-nat.c: Sort headers.
1104         * amd64-dicos-tdep.c: Sort headers.
1105         * amd64-darwin-tdep.c: Sort headers.
1106         * amd64-bsd-nat.c: Sort headers.
1107         * alpha-tdep.c: Sort headers.
1108         * alpha-obsd-tdep.c: Sort headers.
1109         * alpha-nbsd-tdep.c: Sort headers.
1110         * alpha-mdebug-tdep.c: Sort headers.
1111         * alpha-linux-tdep.c: Sort headers.
1112         * alpha-linux-nat.c: Sort headers.
1113         * alpha-bsd-tdep.c: Sort headers.
1114         * alpha-bsd-nat.c: Sort headers.
1115         * aix-thread.c: Sort headers.
1116         * agent.c: Sort headers.
1117         * addrmap.c: Sort headers.
1118         * ada-varobj.c: Sort headers.
1119         * ada-valprint.c: Sort headers.
1120         * ada-typeprint.c: Sort headers.
1121         * ada-tasks.c: Sort headers.
1122         * ada-lang.c: Sort headers.
1123         * aarch64-tdep.c: Sort headers.
1124         * aarch64-ravenscar-thread.c: Sort headers.
1125         * aarch64-newlib-tdep.c: Sort headers.
1126         * aarch64-linux-tdep.c: Sort headers.
1127         * aarch64-linux-nat.c: Sort headers.
1128         * aarch64-fbsd-tdep.c: Sort headers.
1129         * aarch64-fbsd-nat.c: Sort headers.
1130         * aarch32-linux-nat.c: Sort headers.
1131
1132 2019-04-04  Tom Tromey  <tom@tromey.com>
1133
1134         * varobj.c (varobj_create): Update.
1135         * rust-exp.y (struct rust_parser) <update_innermost_block,
1136         lookup_symbol>: New methods.
1137         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1138         Rename.
1139         (rust_parser::rust_lookup_type)
1140         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1141         * printcmd.c (display_command, do_one_display): Update.
1142         * parser-defs.h (struct parser_state) <parser_state>: Add
1143         "tracker" parameter.
1144         (block_tracker): New member.
1145         (class innermost_block_tracker) <innermost_block_tracker>: Add
1146         "types" parameter.
1147         <reset>: Remove method.
1148         (innermost_block): Don't declare.
1149         (null_post_parser): Update.
1150         * parse.c (innermost_block): Remove global.
1151         (write_dollar_variable): Update.
1152         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1153         Remove "tracker_types" parameter.
1154         (parse_expression): Add "tracker" parameter.
1155         (parse_expression_for_completion): Update.
1156         (null_post_parser): Add "tracker" parameter.
1157         * p-exp.y: Update rules.
1158         * m2-exp.y: Update rules.
1159         * language.h (struct language_defn) <la_post_parser>: Add
1160         "tracker" parameter.
1161         * go-exp.y: Update rules.
1162         * f-exp.y: Update rules.
1163         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1164         parameter.
1165         * d-exp.y: Update rules.
1166         * c-exp.y: Update rules.
1167         * breakpoint.c (set_breakpoint_condition): Create an
1168         innermost_block_tracker.
1169         (watch_command_1): Likewise.
1170         * ada-lang.c (resolve): Add "tracker" parameter.
1171         (resolve_subexp): Likewise.
1172         * ada-exp.y (write_var_from_sym): Update.
1173
1174 2019-04-04  Tom Tromey  <tom@tromey.com>
1175
1176         * type-stack.h: New file.
1177         * type-stack.c: New file.
1178         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1179         type-stack.h.
1180         (insert_into_type_stack, insert_type, push_type, push_type_int)
1181         (insert_type_address_space, pop_type, pop_type_int)
1182         (pop_typelist, pop_type_stack, append_type_stack)
1183         (push_type_stack, get_type_stack, push_typelist)
1184         (follow_type_instance_flags, follow_types): Don't declare.
1185         * parse.c (type_stack): Remove global.
1186         (parse_exp_in_context): Update.
1187         (insert_into_type_stack, insert_type, push_type, push_type_int)
1188         (insert_type_address_space, pop_type, pop_type_int)
1189         (pop_typelist, pop_type_stack, append_type_stack)
1190         (push_type_stack, get_type_stack, push_typelist)
1191         (follow_type_instance_flags, follow_types): Remove (moved to
1192         type-stack.c).
1193         * f-exp.y (type_stack): New global.
1194         Update rules.
1195         (push_kind_type, f_parse): Update.
1196         * d-exp.y (type_stack): New global.
1197         Update rules.
1198         (d_parse): Update.
1199         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1200         Update rules.
1201         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1202         (HFILES_NO_SRCDIR): Add type-stack.h.
1203
1204 2019-04-04  Tom Tromey  <tom@tromey.com>
1205
1206         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1207         (rust_parser::convert_ast_to_expression, rust_parse)
1208         (rust_lex_test_completion, rust_lex_tests): Update.
1209         * parser-defs.h (struct expr_completion_state): New.
1210         (struct parser_state) <parser_state>: Add completion parameter.
1211         <mark_struct_expression, mark_completion_tag>: New methods.
1212         <parse_completion, m_completion_state>: New members.
1213         (prefixify_expression, null_post_parser): Update.
1214         (mark_struct_expression, mark_completion_tag): Don't declare.
1215         * parse.c (parse_completion, expout_last_struct)
1216         (expout_tag_completion_type, expout_completion_name): Remove
1217         globals.
1218         (parser_state::mark_struct_expression)
1219         (parser_state::mark_completion_tag): Now methods.
1220         (prefixify_expression): Add last_struct parameter.
1221         (prefixify_subexp): Likewise.
1222         (parse_exp_1): Update.
1223         (parse_exp_in_context): Add cstate parameter.  Update.
1224         (parse_expression_for_completion): Create an
1225         expr_completion_state.
1226         (null_post_parser): Add "completion" parameter.
1227         * p-exp.y: Update rules.
1228         (yylex): Update.
1229         * language.h (struct language_defn) <la_post_parser>: Add
1230         "completing" parameter.
1231         * go-exp.y: Update rules.
1232         (lex_one_token): Update.
1233         * expression.h (parse_completion): Don't declare.
1234         * d-exp.y: Update rules.
1235         (lex_one_token): Update rules.
1236         * c-exp.y: Update rules.
1237         (lex_one_token): Update.
1238         * ada-lang.c (resolve): Add "parse_completion" parameter.
1239         (resolve_subexp): Likewise.
1240         (ada_resolve_function): Likewise.
1241
1242 2019-04-04  Tom Tromey  <tom@tromey.com>
1243
1244         * parser-defs.h (struct parser_state) <start_arglist,
1245         end_arglist>: New methods.
1246         <arglist_len, m_funcall_chain>: New members.
1247         (arglist_len, start_arglist, end_arglist): Don't declare.
1248         * parse.c (arglist_len, funcall_chain): Remove global.
1249         (start_arglist, end_arglist): Remove functions.
1250         (parse_exp_in_context): Update.
1251         * p-exp.y: Update rules.
1252         * m2-exp.y: Update rules.
1253         * go-exp.y: Update rules.
1254         * f-exp.y: Update rules.
1255         * d-exp.y: Update rules.
1256         * c-exp.y: Update rules.
1257
1258 2019-04-04  Tom Tromey  <tom@tromey.com>
1259
1260         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1261         lex_operator, push_back>: New methods.
1262         Update all rules.
1263         (rust_parser::lex_hex, lex_escape): Rename and update.
1264         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1265         (rust_parser::lex_operator): Rename and update.
1266         (rust_parser::lex_number, rustyylex, rustyyerror)
1267         (rust_lex_test_init, rust_lex_test_sequence)
1268         (rust_lex_test_push_back, rust_lex_tests): Update.
1269         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1270         parameter.
1271         <lexptr, prev_lexptr>: New members.
1272         (lexptr, prev_lexptr): Don't declare.
1273         * parse.c (lexptr, prev_lexptr): Remove globals.
1274         (parse_exp_in_context): Update.
1275         * p-exp.y (yylex, yyerror): Update.
1276         * m2-exp.y (parse_number, yylex, yyerror): Update.
1277         * go-exp.y (lex_one_token, yyerror): Update.
1278         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1279         * d-exp.y (lex_one_token, yyerror): Update.
1280         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1281         (lex_one_token, yyerror): Update.
1282         * ada-lex.l (YY_INPUT): Update.
1283         (rewind_to_char): Update.
1284         * ada-exp.y (yyerror): Update.
1285
1286 2019-04-04  Tom Tromey  <tom@tromey.com>
1287
1288         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1289         * parser-defs.h (struct parser_state) <parser_state>: Add new
1290         parameter.
1291         <comma_terminates>: New member.
1292         (comma_terminates): Don't declare global.
1293         * parse.c (comma_terminates): Remove global.
1294         (parse_exp_in_context): Update.
1295         * p-exp.y (yylex): Update.
1296         * m2-exp.y (yylex): Update.
1297         * go-exp.y (lex_one_token): Update.
1298         * f-exp.y (yylex): Update.
1299         * d-exp.y (lex_one_token): Update.
1300         * c-exp.y (lex_one_token): Update.
1301         * ada-lex.l: Update.
1302
1303 2019-04-04  Tom Tromey  <tom@tromey.com>
1304
1305         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1306         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1307         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1308         * parser-defs.h (paren_depth): Don't declare.
1309         * parse.c (paren_depth): Remove global.
1310         (parse_exp_in_context): Update.
1311         * p-exp.y (paren_depth): New global.
1312         (pascal_parse): Initialize it.
1313         * m2-exp.y (paren_depth): New global.
1314         (m2_parse): Initialize it.
1315         * go-exp.y (paren_depth): New global.
1316         (go_parse): Initialize it.
1317         * f-exp.y (paren_depth): New global.
1318         (f_parse): Initialize it.
1319         * d-exp.y (paren_depth): New global.
1320         (d_parse): Initialize it.
1321         * c-exp.y (paren_depth): New global.
1322         (c_parse): Initialize it.
1323         * ada-lex.l (paren_depth): New global.
1324         (lexer_init): Initialize it.
1325
1326 2019-04-04  Tom Tromey  <tom@tromey.com>
1327
1328         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1329         (rust_parser::convert_ast_to_type)
1330         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1331         * parser-defs.h (struct parser_state) <parser_state>: Add
1332         parameters.  Initialize new members.
1333         <expression_context_block, expression_context_pc>: New members.
1334         * parse.c (expression_context_block, expression_context_pc):
1335         Remove globals.
1336         (parse_exp_in_context): Update.
1337         * p-exp.y: Update all rules.
1338         (yylex): Update.
1339         * m2-exp.y: Update all rules.
1340         (yylex): Update.
1341         * go-exp.y (yylex): Update.
1342         * f-exp.y (yylex): Update.
1343         * d-exp.y: Update all rules.
1344         (yylex): Update.
1345         * c-exp.y: Update all rules.
1346         (lex_one_token, classify_name, yylex, c_parse): Update.
1347         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1348
1349 2019-04-04  Tom Tromey  <tom@tromey.com>
1350
1351         * gdbarch.h, gdbarch.c: Rebuild.
1352         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1353         * stap-probe.h: 
1354         (struct stap_parse_info): Replace "parser_state" with
1355         "expr_builder".
1356         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1357         (parser_state): New class.
1358         * parse.c (expr_builder): Rename.
1359         (expr_builder::release): Rename.
1360         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1361         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1362         (write_exp_elt_longcst, write_exp_elt_floatcst)
1363         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1364         (write_exp_string_vector, write_exp_bitstring)
1365         (write_exp_msymbol, mark_struct_expression)
1366         (write_dollar_variable)
1367         (insert_type_address_space, increase_expout_size): Replace
1368         "parser_state" with "expr_builder".
1369         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1370         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1371         "parser_state" with "expr_builder".
1372
1373 2019-04-04  Tom Tromey  <tom@tromey.com>
1374
1375         * rust-exp.y: Replace "parse_language" with method call.
1376         * p-exp.y: 
1377         (yylex): Replace "parse_language" with method call.
1378         * m2-exp.y: 
1379         (yylex): Replace "parse_language" with method call.
1380         * go-exp.y (classify_name): Replace "parse_language" with method
1381         call.
1382         * f-exp.y (yylex): Replace "parse_language" with method call.
1383         * d-exp.y (lex_one_token): Replace "parse_language" with method
1384         call.
1385         * c-exp.y: 
1386         (lex_one_token, classify_name, yylex): Replace "parse_language"
1387         with method call.
1388         * ada-exp.y (find_primitive_type, type_char)
1389         (type_system_address): Replace "parse_language" with method call.
1390
1391 2019-04-04  Tom Tromey  <tom@tromey.com>
1392
1393         * rust-exp.y: Replace "parse_gdbarch" with method call.
1394         * parse.c (write_dollar_variable, insert_type_address_space):
1395         Replace "parse_gdbarch" with method call.
1396         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1397         call.
1398         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1399         call.
1400         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1401         "parse_gdbarch" with method call.
1402         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1403         with method call.
1404         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1405         "parse_gdbarch" with method call.
1406         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1407         "parse_gdbarch" with method call.
1408         * c-exp.y (parse_type, parse_number, classify_name): Replace
1409         "parse_gdbarch" with method call.
1410         * ada-lex.l: Replace "parse_gdbarch" with method call.
1411         * ada-exp.y (parse_type, find_primitive_type, type_char)
1412         (type_system_address): Replace "parse_gdbarch" with method call.
1413
1414 2019-04-04  Tom Tromey  <tom@tromey.com>
1415
1416         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1417         * stap-probe.c (stap_parse_argument): Update.
1418         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1419         initial_size parameter.
1420         * rust-exp.y (rust_lex_tests): Update.
1421         * parse.c (parser_state): Update.
1422         (parse_exp_in_context): Update.
1423         * parser-defs.h (struct parser_state) <parser_state>: Remove
1424         "initial_size" parameter.
1425
1426 2019-04-04  Tom Tromey  <tom@tromey.com>
1427
1428         * parser-defs.h (increase_expout_size): Don't declare.
1429         * parse.c (increase_expout_size): Now static.
1430
1431 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1432
1433         * gnu-nat.c (gnu_nat_target::wait): Fix
1434         target_waitstatus_to_string call.
1435
1436 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1437
1438         * eval.c (evaluate_subexp_standard): Handle internal functions
1439         during Fortran function call handling.
1440
1441 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * NEWS: Mention new internal functions.
1444         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1445         (read_base_type): Use dwarf2_init_complex_target_type.
1446         * value.c (creal_internal_fn): New function.
1447         (cimag_internal_fn): New function.
1448         (_initialize_values): Register new internal functions.
1449
1450 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451
1452         * infrun.c (stop_all_threads): If debug_infrun, always
1453         trace the wait status after wait_one, using
1454         target_waitstatus_to_string and target_pid_to_str.
1455         (handle_inferior_event): Replace various trace of
1456         wait status kind by a single trace.
1457         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1458         wait status kind image by target_waitstatus_to_string.
1459         * target/waitstatus.c (target_waitstatus_to_string): Fix
1460         obsolete comment.
1461
1462 2019-04-01  Tom Tromey  <tromey@adacore.com>
1463
1464         PR symtab/23331:
1465         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1466
1467 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1468             Pedro Alves  <palves@redhat.com>
1469
1470         * top.c (quit_force): Call 'finalize_values'.
1471         * value.c (finalize_values): New function.
1472         * value.h (finalize_values): Declare.
1473
1474 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1475
1476         * NEWS: Announce $_gdb_major and $_gdb_minor.
1477
1478         * top.c (init_gdb_version_vars): New function.
1479         (gdb_init): Call init_gdb_version_vars.
1480
1481 2019-03-29  Tom Tromey  <tromey@adacore.com>
1482
1483         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1484         help text.  Remove dead code.
1485
1486 2019-03-29  Keith Seitz  <keiths@redhat.com>
1487
1488         From Siddhesh Poyarekar:
1489         * f-lang.h (f77_get_upperbound): Return LONGEST.
1490         (f77_get_lowerbound): Likewise.
1491         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1492         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1493         print them.
1494         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1495         plongest to format print it.
1496         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1497         (f77_get_upperbound): Likewise.
1498         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1499         LOWER_BOUND to LONGEST.
1500         (f77_create_arrayprint_offset_tbl): Likewise.
1501
1502 2019-03-29  Keith Seitz  <keiths@redhat.com>
1503
1504         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1505         %s/pulongest for TYPE_LENGTH instead of %d in format
1506         strings.
1507         * ada-typerint.c (ada_print_type): Likewise.
1508         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1509         * compile/compile-c-support.c (generate_register_struct): Likewise.
1510         * gdbtypes.c (recursive_dump_type): Likewise.
1511         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1512         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1513         instead of %d in format strings.
1514         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1515         to std::min to ULONGEST.
1516         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1517         instead of %d in format strings.
1518         * tracepoint.c (info_scope_command): Likewise.
1519         * typeprint.c (print_offset_data::update)
1520         (print_offset_data::finish): Likewise.
1521         * xtensa-tdep.c (xtensa_store_return_value)
1522         (xtensa_push_dummy_call): Likewise.
1523
1524 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1525
1526         * windows-nat.c (display_selector): Fixed format specifications
1527         for 64-bit Cygwin.
1528
1529 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1532
1533 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1534
1535         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1536         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1537         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1538         (nios2_linux_init_abi): Install it.
1539
1540 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1543
1544 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1545
1546         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1547
1548 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1549             Tom Tromey  <tromey@adacore.com>
1550
1551         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1552
1553 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1554
1555         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1556         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1557         method to compute the bounds of range types. Also print "[evaluated]"
1558         if the bounds' values come from a dynamic evaluation.
1559
1560 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1561
1562         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1563         whitespace when pretty printing is on.
1564
1565 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1566
1567         * ppc-linux-nat.c: Add include.
1568
1569 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1570
1571         * NEWS: Mention AArch64 Pointer Authentication.
1572
1573 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1574
1575         * arm-linux-nat.c: Add include.
1576
1577 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1578
1579         * source-cache.c (source_cache::get_source_lines): Re-read
1580         fullname after calling open_source_file.
1581
1582 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1583
1584         * NEWS: Mention TLS support for FreeBSD.
1585
1586 2019-03-25  Tom Tromey  <tromey@adacore.com>
1587
1588         * minsyms.c (BUNCH_SIZE): Update comment.
1589         (~minimal_symbol_reader): Remove old comment.
1590         (compact_minimal_symbols): Update comment.
1591         (minimal_symbol_reader::install): Remove old comment.  Update
1592         other comments.
1593
1594 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1595
1596         * s390-linux-nat.c: Add include.
1597
1598 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1599
1600         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1601         Call linux_get_hwcap.
1602         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1603         Likewise.
1604         (aarch64_linux_get_hwcap): Remove function.
1605         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1606         declaration.
1607         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1608         linux_get_hwcap.
1609         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1610         * linux-tdep.c (linux_get_hwcap): Add function.
1611         (linux_get_hwcap2): Likewise.
1612         * linux-tdep.h (linux_get_hwcap): Add declaration.
1613         (linux_get_hwcap2): Likewise.
1614         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1615         (ppc_linux_get_hwcap2): Likewise.
1616         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1617         linux_get_hwcap.
1618         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1619         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1620         (ppc_linux_nat_target::read_description): Likewise.
1621         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1622         * s390-linux-nat.c: Likewise.
1623         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1624
1625 2019-03-24  Tom Tromey  <tom@tromey.com>
1626
1627         * ada-lang.c (standard_lookup): Simplify initialization.
1628         (ada_lookup_symbol_nonlocal): Simplify return.
1629         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1630         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1631         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1632         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1633         initialization.
1634         * solib.c (solib_global_lookup): Simplify.
1635         * symtab.c (null_block_symbol): Remove.
1636         (symbol_cache_lookup): Simplify returns.
1637         (lookup_language_this): Simplify returns.
1638         (lookup_symbol_aux): Simplify return.
1639         (lookup_local_symbol): Simplify returns.
1640         (lookup_global_symbol_from_objfile): Simplify return.
1641         (lookup_symbol_in_objfile_symtabs)
1642         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1643         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1644         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1645         * cp-namespace.c (cp_lookup_bare_symbol)
1646         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1647         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1648         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1649         (cp_lookup_symbol_via_imports): Simplify initialization.
1650         (find_symbol_in_baseclass): Likewise.
1651         * symtab.h (null_block_symbol): Remove.
1652         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1653         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1654         (d_lookup_symbol_module): Likewise.
1655         (find_symbol_in_baseclass): Simplify initialization.
1656
1657 2019-03-24  Tom Tromey  <tom@tromey.com>
1658
1659         * expression.h: Don't include symtab.h.
1660         (struct block): Forward declare.
1661
1662 2019-03-24  Tom Tromey  <tom@tromey.com>
1663
1664         * c-exp.y (typebase): Remove casts.
1665         * gdbtypes.c (lookup_unsigned_typename, )
1666         (lookup_signed_typename): Remove cast.
1667         * eval.c (parse_to_comma_and_eval): Remove cast.
1668         * parse.c (write_dollar_variable): Remove cast.
1669         * block.h (struct block) <superblock>: Now const.
1670         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1671         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1672         (map_block): Make "block" const.
1673         * symfile.h (struct quick_symbol_functions)
1674         <map_matching_symbols>: Constify block argument to "callback".
1675         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1676         const.
1677         (find_pc_sect_compunit_symtab): Make "b" const.
1678         (find_symbol_at_address): Likewise.
1679         (search_symbols): Likewise.
1680         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1681         (dw2_debug_names_lookup_symbol): Likewise.
1682         (dw2_map_matching_symbols): Update.
1683         * p-valprint.c (pascal_val_print): Remove "block".
1684         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1685         (aux_add_nonlocal_symbols): Make "block" const.
1686         (resolve_subexp): Remove cast.
1687         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1688         const.
1689         (iterate_over_file_blocks): Likewise.
1690         * f-exp.y (%union) <bval>: Remove.
1691         * coffread.c (patch_opaque_types): Make "b" const.
1692         * spu-tdep.c (spu_catch_start): Make "block" const.
1693         * c-valprint.c (print_unpacked_pointer): Remove "block".
1694         * symmisc.c (dump_symtab_1): Make "b" const.
1695         (block_depth): Make "block" const.
1696         * d-exp.y (%union) <bval>: Remove.
1697         * cp-support.h (cp_lookup_rtti_type): Update.
1698         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1699         * psymtab.c (psym_lookup_symbol): Make "block" const.
1700         (maintenance_check_psymtabs): Make "b" const.
1701         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1702         (enumerate_locals, enumerate_args): Update.
1703         * python/py-symtab.c (stpy_global_block): Make "block" const.
1704         (stpy_static_block): Likewise.
1705         * inline-frame.c (block_starting_point_at): Make "new_block"
1706         const.
1707         * block.c (find_block_in_blockvector): Make return type const.
1708         (blockvector_for_pc_sect): Make "b" const.
1709         (find_block_in_blockvector): Make "b" const.
1710
1711 2019-03-23  Tom Tromey  <tom@tromey.com>
1712
1713         * varobj.c (varobj_create): Update.
1714         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1715         * printcmd.c (display_command, do_one_display): Don't reset
1716         innermost_block.
1717         * parser-defs.h (enum innermost_block_tracker_type): Move to
1718         expression.h.
1719         (innermost_block): Update comment.
1720         * parse.c (parse_exp_1): Add tracker_types parameter.
1721         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1722         tracker_types parameter.  Reset innermost_block.
1723         (parse_exp_in_context): Remove.
1724         (parse_expression_for_completion): Update.
1725         * objfiles.c (~objfile): Don't reset expression_context_block or
1726         innermost_block.
1727         * expression.h (enum innermost_block_tracker_type): Move from
1728         parser-defs.h.
1729         (parse_exp_1): Add tracker_types parameter.
1730         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1731         reset innermost_block.
1732
1733 2019-03-23  Tom Tromey  <tom@tromey.com>
1734
1735         * objfiles.h: Include bcache.h.
1736
1737 2019-03-23  Tom Tromey  <tom@tromey.com>
1738
1739         * linespec.c (get_current_search_block): Use
1740         scoped_restore_current_language.
1741         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1742
1743 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1744             Jiong Wang  <jiong.wang@arm.com>
1745
1746         * aarch64-linux-tdep.c
1747         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1748         section.
1749         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1750
1751 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1752             Jiong Wang  <jiong.wang@arm.com>
1753
1754         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1755         instructions.
1756         (aarch64_analyze_prologue_test): Add PACIASP test.
1757         (aarch64_prologue_prev_register): Unmask PC value.
1758
1759 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1760             Jiong Wang  <jiong.wang@arm.com>
1761
1762         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1763         (aarch64_dwarf2_prev_register): Unmask PC value.
1764         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1765         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1766         DW_CFA_AARCH64_negate_ra_state.
1767         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1768
1769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1770             Jiong Wang  <jiong.wang@arm.com>
1771
1772         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1773         registers.
1774         (aarch64_pseudo_register_name): Likewise.
1775         (aarch64_pseudo_register_type): Likewise.
1776         (aarch64_pseudo_register_reggroup_p): Likewise.
1777         (aarch64_gdbarch_init): Add pauth registers.
1778         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1779         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1780         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1781         (struct gdbarch_tdep): Add regnum for ra_state.
1782
1783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1784             Jiong Wang  <jiong.wang@arm.com>
1785
1786         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1787
1788 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1789             Jiong Wang  <jiong.wang@arm.com>
1790
1791         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1792         function.
1793         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1794         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1795         (aarch64_gdbarch_init): Add puth registers.
1796         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1797         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1798         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1799
1800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1801             Jiong Wang  <jiong.wang@arm.com>
1802
1803         * aarch64-linux-nat.c
1804         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1805         * aarch64-linux-tdep.c
1806         (aarch64_linux_core_read_description): Likewise.
1807         (aarch64_linux_get_hwcap): New function.
1808         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1809         (aarch64_linux_get_hwcap): New declaration.
1810
1811 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1812             Jiong Wang  <jiong.wang@arm.com>
1813
1814         * aarch64-linux-nat.c
1815         (aarch64_linux_nat_target::read_description): Add pauth param.
1816         * aarch64-linux-tdep.c
1817         (aarch64_linux_core_read_description): Likewise.
1818         * aarch64-tdep.c (struct target_desc): Add in pauth.
1819         (aarch64_read_description): Add pauth param.
1820         (aarch64_gdbarch_init): Likewise.
1821         * aarch64-tdep.h (aarch64_read_description): Likewise.
1822         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1823         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1824         * features/Makefile: Add new files.
1825         * features/aarch64-pauth.c: New file.
1826         * features/aarch64-pauth.xml: New file.
1827
1828 2019-03-20  Tom Tromey  <tromey@adacore.com>
1829
1830         * infrun.c (handle_inferior_event): Rename from
1831         handle_inferior_event_1.  Create a scoped_value_mark.
1832         (handle_inferior_event): Remove.
1833
1834 2019-03-19  Tom Tromey  <tromey@adacore.com>
1835
1836         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1837         * infrun.h (print_stop_event): Add "displays" parameter.
1838         * infrun.c (print_stop_event): Add "displays" parameter.
1839
1840 2019-03-19  Pedro Alves  <palves@redhat.com>
1841
1842         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1843         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1844         to -1.  Fix TABs vs spaces.
1845         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1846         * tui/tui-out.h (tui_ui_out) Add intro comments.
1847         <m_line, m_start_of_line>: In-class initialize, and add describing
1848         comment.
1849
1850 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1851
1852         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1853         variable names.
1854         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1855
1856 2019-03-18  Pedro Alves  <palves@redhat.com>
1857             Eli Zaretskii <eliz@gnu.org>
1858
1859         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1860         m_line and m_start_of_line.
1861
1862 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1863
1864         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1865         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1866         it returns a newline.  This fixes a regression in TU mode, whereby
1867         the next line is output on the same screen line as the user input.
1868
1869 2019-03-18  Tom Tromey  <tromey@adacore.com>
1870
1871         * minsyms.c (minimal_symbol_reader::install): Remove call to
1872         obstack_blank.
1873
1874 2019-03-18  Pedro Alves  <palves@redhat.com>
1875
1876         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1877         New globals.
1878         (apply_style): New, factored out from ...
1879         (apply_ansi_escape): ... this.  Handle reverse video mode.
1880         (tui_set_reverse_mode): New function.
1881         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1882         * tui/tui-winsource.c (tui_show_source_line): Use
1883         tui_set_reverse_mode instead of setting A_STANDOUT.
1884         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1885         New setter methods.
1886
1887 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1888
1889         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1890         Handle tabs.
1891
1892 2019-03-18  Tom Tromey  <tromey@adacore.com>
1893
1894         * ada-lang.c (empty_array): Add "high" parameter.
1895         (ada_evaluate_subexp): Update.
1896
1897 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1898
1899         * unittests/string_view-selftests.c: Define
1900         _initialize_string_view_selftests unconditionally.
1901
1902 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1903
1904         PR gdb/24350
1905         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1906
1907 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1908
1909         PR gdb/24351
1910         * windows-nat.c (display_selector): Fix format specifiers.
1911
1912 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1913
1914         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1915         tui_refill_source_window instead of tui_refresh_win, to update the
1916         current execution line.  This fixes redisplay of the current line
1917         when stepping through the code with "next" or "step".
1918
1919 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1920
1921         * source-cache.c (source_cache::get_source_lines): Call
1922         find_source_lines to initialize s->nlines.  This fixes vertical
1923         scrolling of TUI source window when the DOWN arrow is pressed.
1924
1925 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1926
1927         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1928         linux-thread-db.c (_initialize_thread_db): Likewise.
1929
1930 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1931
1932         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1933         wclrtoeol in tui_show_source_line".  This reverts changes made in
1934         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1935
1936 2019-03-15  Tom Tromey  <tom@tromey.com>
1937
1938         * symtab.h (struct minimal_symbol): Derive from
1939         general_symbol_info.
1940         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1941         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1942         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1943         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1944         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1945         (MSYMBOL_SEARCH_NAME): Update.
1946         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1947         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1948         * minsyms.c (minimal_symbol_reader::record_full): Update.
1949
1950 2019-03-15  Tom Tromey  <tom@tromey.com>
1951
1952         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1953
1954 2019-03-15  Tom Tromey  <tom@tromey.com>
1955
1956         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1957         unique_xmalloc_ptr.
1958         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1959         Update.
1960         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1961         (build_minimal_symbol_hash_tables)
1962         (minimal_symbol_reader::install): Update.
1963
1964 2019-03-15  Tom Tromey  <tom@tromey.com>
1965
1966         * symtab.c (create_demangled_names_hash): Update.
1967         (symbol_set_names): Update.
1968         * objfiles.h (struct objfile_per_bfd_storage)
1969         <demangled_names_hash>: Now an htab_up.
1970         * objfiles.c (objfile_per_bfd_storage): Simplify.
1971
1972 2019-03-15  Tom Tromey  <tom@tromey.com>
1973
1974         * objfiles.h (struct objfile_per_bfd_storage): Declare
1975         destructor.
1976         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1977         New.
1978         (get_objfile_bfd_data): Use new.  Don't initialize
1979         language_of_main.
1980         (free_objfile_per_bfd_storage): Remove.
1981         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1982
1983 2019-03-15  Tom Tromey  <tom@tromey.com>
1984
1985         * symfile.c (reread_symbols): Update.
1986         * objfiles.c (objfile::objfile): Update.
1987         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1988         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1989         comment.
1990         (minimal_symbol_reader::install): Update.
1991         (terminate_minimal_symbol_table): Remove.
1992         * jit.c (jit_object_close_impl): Update.
1993
1994 2019-03-15  Tom Tromey  <tom@tromey.com>
1995
1996         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1997         initializations.
1998
1999 2019-03-15  Tom Tromey  <tom@tromey.com>
2000
2001         * objfiles.h (struct objfile_per_bfd_storage)
2002         <demangled_hash_languages>: Now a bitset.
2003         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2004         (lookup_minimal_symbol): Update.
2005
2006 2019-03-15  Tom Tromey  <tom@tromey.com>
2007
2008         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2009         Don't return the symbol.
2010         * coffread.c (record_minimal_symbol): Use record_full.
2011
2012 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2013
2014         The MS-Windows port of ncurses fails to switch to a color pair if
2015         one or both of the colors are the implicit default colors.  This
2016         change records the default colors when TUI is initialized, and
2017         then specifies them explicitly when a color pair uses the default
2018         colors.  This allows color styling in TUI mode on MS-Windows.
2019
2020         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2021         ncurses_norm_attr.
2022         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2023         colors in ncurses_norm_attr.
2024         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2025         "none", replace it with the default color recorded in
2026         ncurses_norm_attr.
2027
2028 2019-03-14  Tom Tromey  <tromey@adacore.com>
2029
2030         * source-cache.h (class source_cache) <get_source_lines>: Return
2031         std::string.
2032         * source-cache.c (source_cache::extract_lines): Handle case where
2033         first_pos==npos.  Return std::string.
2034         (source_cache::get_source_lines): Update.
2035
2036 2019-03-14  Tom Tromey  <tromey@adacore.com>
2037
2038         * NEWS: Add item for "style sources" commands.
2039         * source-cache.c (source_cache::get_source_lines): Check
2040         source_styling.
2041         * cli/cli-style.c (source_styling): New global.
2042         (_initialize_cli_style): Add "style sources" commands.
2043         (show_style_sources): New function.
2044         * cli/cli-style.h (source_styling): Declare.
2045
2046 2019-03-14  Pedro Alves  <palves@redhat.com>
2047             Tom Tromey  <tromey@adacore.com>
2048
2049         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2050         * tui/tui-winsource.c (tui_refill_source_window): New function,
2051         from...
2052         (tui_horizontal_source_scroll): ... here.  Move some logic.
2053         * cli/cli-style.c (set_style_enabled): Notify new observable.
2054         * tui/tui-hooks.c (tui_redisplay_source): New function.
2055         (tui_attach_detach_observers): Attach or detach
2056         tui_redisplay_source.
2057         * observable.h (source_styling_changed): New observable.
2058         * observable.c: Define source_styling_changed observable.
2059
2060 2019-03-13  Tom Tromey  <tromey@adacore.com>
2061
2062         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2063         (i386_gnu_nat_target::store_registers): Update.
2064         * target-debug.h (target_debug_print_std_string): New macro.
2065         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2066         * windows-tdep.c (display_one_tib): Update.
2067         * tui/tui-stack.c (tui_make_status_line): Update.
2068         * top.c (print_inferior_quit_action): Update.
2069         * thread.c (thr_try_catch_cmd): Update.
2070         (add_thread_with_info): Update.
2071         (thread_target_id_str): Update.
2072         (thr_try_catch_cmd): Update.
2073         (thread_command): Update.
2074         (thread_find_command): Update.
2075         * record-btrace.c (record_btrace_target::info_record)
2076         (record_btrace_resume_thread, record_btrace_target::resume)
2077         (record_btrace_cancel_resume, record_btrace_step_thread)
2078         (record_btrace_target::wait, record_btrace_target::wait)
2079         (record_btrace_target::wait, record_btrace_target::stop): Update.
2080         * progspace.c (print_program_space): Update.
2081         * process-stratum-target.c
2082         (process_stratum_target::thread_address_space): Update.
2083         * linux-fork.c (linux_fork_mourn_inferior)
2084         (detach_checkpoint_command, info_checkpoints_command)
2085         (linux_fork_context): Update.
2086         (linux_fork_detach): Update.
2087         (class scoped_switch_fork_info): Update.
2088         (delete_checkpoint_command): Update.
2089         * infrun.c (follow_fork_inferior): Update.
2090         (follow_fork_inferior): Update.
2091         (proceed_after_vfork_done): Update.
2092         (handle_vfork_child_exec_or_exit): Update.
2093         (follow_exec): Update.
2094         (displaced_step_prepare_throw): Update.
2095         (displaced_step_restore): Update.
2096         (start_step_over): Update.
2097         (resume_1): Update.
2098         (clear_proceed_status_thread): Update.
2099         (proceed): Update.
2100         (print_target_wait_results): Update.
2101         (do_target_wait): Update.
2102         (context_switch): Update.
2103         (stop_all_threads): Update.
2104         (restart_threads): Update.
2105         (finish_step_over): Update.
2106         (handle_signal_stop): Update.
2107         (switch_back_to_stepped_thread): Update.
2108         (keep_going_pass_signal): Update.
2109         (print_exited_reason): Update.
2110         (normal_stop): Update.
2111         * inferior.c (inferior_pid_to_str): Change return type.
2112         (print_selected_inferior): Update.
2113         (add_inferior): Update.
2114         (detach_inferior): Update.
2115         * dummy-frame.c (fprint_dummy_frames): Update.
2116         * dcache.c (dcache_info_1): Update.
2117         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2118         (btrace_fetch, btrace_clear): Update.
2119         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2120         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2121         type.
2122         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2123         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2124         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2125         * gdbarch.c, gdbarch.h: Rebuild.
2126         * gdbarch.sh (core_pid_to_str): Change return type.
2127         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2128         return type.
2129         (windows_nat_target::pid_to_str): Change return type.
2130         (windows_delete_thread): Update.
2131         (windows_nat_target::attach): Update.
2132         (windows_nat_target::files_info): Update.
2133         * target-delegates.c: Rebuild.
2134         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2135         return type.
2136         (sol_thread_target::pid_to_str): Change return type.
2137         * remote.c (class remote_target) <pid_to_str>: Change return
2138         type.
2139         (remote_target::pid_to_str): Change return type.
2140         (extended_remote_target::attach, remote_target::remote_stop_ns)
2141         (remote_target::remote_notif_remove_queued_reply)
2142         (remote_target::push_stop_reply, remote_target::disable_btrace):
2143         Update.
2144         (extended_remote_target::attach): Update.
2145         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2146         type.
2147         (gdbsim_target::pid_to_str): Change return type.
2148         * ravenscar-thread.c (struct ravenscar_thread_target)
2149         <pid_to_str>: Change return type.
2150         (ravenscar_thread_target::pid_to_str): Change return type.
2151         * procfs.c (class procfs_target) <pid_to_str>: Change return
2152         type.
2153         (procfs_target::pid_to_str): Change return type.
2154         (procfs_target::attach): Update.
2155         (procfs_target::detach): Update.
2156         (procfs_target::fetch_registers): Update.
2157         (procfs_target::store_registers): Update.
2158         (procfs_target::wait): Update.
2159         (procfs_target::files_info): Update.
2160         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2161         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2162         return type.
2163         (nto_procfs_target::pid_to_str): Change return type.
2164         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2165         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2166         return type.
2167         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2168         (exit_lwp): Update.
2169         (attach_proc_task_lwp_callback, get_detach_signal)
2170         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2171         (linux_nat_target::resume, wait_lwp, stop_callback)
2172         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2173         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2174         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2175         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2176         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2177         type.
2178         (inf_ptrace_target::attach): Update.
2179         (inf_ptrace_target::files_info): Update.
2180         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2181         type.
2182         (go32_nat_target::pid_to_str): Change return type.
2183         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2184         (gnu_nat_target::wait): Update.
2185         (gnu_nat_target::wait): Update.
2186         (gnu_nat_target::resume): Update.
2187         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2188         (fbsd_nat_target::wait): Update.
2189         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2190         type.
2191         (darwin_nat_target::attach): Update.
2192         * corelow.c (class core_target) <pid_to_str>: Change return type.
2193         (core_target::pid_to_str): Change return type.
2194         * target.c (normal_pid_to_str): Change return type.
2195         (default_pid_to_str): Likewise.
2196         (target_pid_to_str): Change return type.
2197         (target_translate_tls_address): Update.
2198         (target_announce_detach): Update.
2199         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2200         return type.
2201         (bsd_uthread_target::pid_to_str): Change return type.
2202         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2203         type.
2204         (bsd_kvm_target::pid_to_str): Change return type.
2205         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2206         return type.
2207         (aix_thread_target::pid_to_str): Change return type.
2208         * target.h (struct target_ops) <pid_to_str>: Change return type.
2209         (target_pid_to_str, normal_pid_to_str): Likewise.
2210         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2211         type.
2212         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2213         type.
2214         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2215         return type.
2216         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2217         type.
2218         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2219         type.
2220         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2221         return type.
2222
2223 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2224
2225         * NEWS: Mention that the new default MI version is 3.  Mention
2226         changes to the output of commands and events that deal with
2227         multi-location breakpoints.
2228         * breakpoint.c: Include "mi/mi-out.h".
2229         (print_one_breakpoint): Change output syntax if using MI version
2230         >= 3.
2231         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2232         New.
2233         (mi_multi_location_breakpoint_output_fixed): New.
2234         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2235         (mi_cmd_fix_multi_location_breakpoint_output): New.
2236         (mi_multi_location_breakpoint_output_fixed): New.
2237         * mi/mi-cmds.c (mi_cmds): Register command
2238         -fix-multi-location-breakpoint-output.
2239         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2240         interpreter "mi".
2241
2242 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2243
2244         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2245         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2246         instantiate mi_ui_out based on interpreter name.
2247         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2248         * mi/mi-main.c (mi_load_progress): Likewise.
2249
2250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2251
2252         * NEWS: Combine separate "New targets" sections for 8.3.
2253
2254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2255
2256         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2257         (ppcfbsd_init_abi): Install gdbarch
2258         "fetch_tls_load_module_address" and "get_thread_local_address"
2259         methods.
2260
2261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2262
2263         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2264         (riscv_fbsd_init_abi): Install gdbarch
2265         "fetch_tls_load_module_address" and "get_thread_local_address"
2266         methods.
2267
2268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2269
2270         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2271         (i386fbsd_init_abi): Install gdbarch
2272         "fetch_tls_load_module_address" and "get_thread_local_address"
2273         methods.
2274
2275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2276
2277         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2278         (amd64fbsd_init_abi): Install gdbarch
2279         "fetch_tls_load_module_address" and "get_thread_local_address"
2280         methods.
2281
2282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2283
2284         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2285         (struct fbsd_pspace_data): New type.
2286         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2287         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2288         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2289         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2290         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2291
2292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2293
2294         * gdbtypes.c (lookup_struct_elt): New function.
2295         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2296         * gdbtypes.h (struct struct_elt): New type.
2297         (lookup_struct_elt): New prototype.
2298
2299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2300
2301         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2302         remove disabled code block.
2303
2304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2305
2306         * gdbarch.sh (get_thread_local_address): New method.
2307         * gdbarch.h, gdbarch.c: Regenerate.
2308         * target.c (target_translate_tls_address): Use
2309         gdbarch_get_thread_local_address if present instead of
2310         target::get_thread_local_address.
2311
2312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2313
2314         * target.h (target::get_thread_local_address): Update comment.
2315
2316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2317
2318         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2319         objfile->separate_debug_objfile_backlink if not NULL.
2320
2321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2322
2323         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2324         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2325         (amd64bsd_store_inferior_registers): Likewise.
2326         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2327         Enable segment base registers.
2328         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2329         PT_GETFSBASE and PT_GETGSBASE.
2330         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2331         PT_SETGSBASE.
2332         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2333         segment base registers.
2334         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2335
2336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2337
2338         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2339         Update calls to i386_target_description to add 'segments'
2340         parameter.
2341         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2342         add segment base registers.
2343         * arch/i386.c (i386_create_target_description): Add 'segments'
2344         parameter to enable segment base registers.
2345         * arch/i386.h (i386_create_target_description): Likewise.
2346         * features/i386/32bit-segments.xml: New file.
2347         * features/i386/32bit-segments.c: Generate.
2348         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2349         call to i386_target_description to add 'segments' parameter.
2350         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2351         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2352         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2353         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2354         if feature is present.
2355         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2356         Add 'segments' parameter to call to i386_target_description.
2357         (i386_target_description): Add 'segments' parameter to enable
2358         segment base registers.
2359         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2360         to call to i386_target_description.
2361         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2362         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2363         Define I386_NUM_REGS.
2364         (i386_target_description): Add 'segments' parameter to enable
2365         segment base registers.
2366
2367 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2368
2369         PR/24325
2370         * source-cache.c: #undef open and close, to avoid unresolved
2371         externals during linking.
2372
2373 2019-03-12  Tom Tromey  <tromey@adacore.com>
2374
2375         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2376         const.  Add initializers.
2377         (_initialize_remote): Don't initialize ptid globals.
2378
2379 2019-03-12  Pedro Alves  <palves@redhat.com>
2380
2381         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2382
2383 2019-03-12  Pedro Alves  <palves@redhat.com>
2384
2385         * cp-name-parser.y (main): Remove unused 'len' variable.
2386
2387 2019-03-12  Tom Tromey  <tromey@adacore.com>
2388
2389         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2390         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2391
2392 2019-03-12  Tom Tromey  <tromey@adacore.com>
2393
2394         * linux-nat.c (iterate_over_lwps): Update.
2395         (stop_callback): Remove parameter.
2396         (stop_wait_callback, detach_callback, resume_set_callback)
2397         (select_singlestep_lwp_callback, set_ignore_sigint)
2398         (status_callback, resumed_callback, resume_clear_callback)
2399         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2400         data parameter.
2401         (linux_nat_target::detach, linux_nat_target::resume)
2402         (linux_stop_and_wait_all_lwps, select_event_lwp)
2403         (linux_nat_filter_event, linux_nat_wait_1)
2404         (linux_nat_target::kill, linux_nat_target::stop)
2405         (linux_nat_target::stop): Update.
2406         (linux_nat_resume_callback): Change type.
2407         (resume_stopped_resumed_lwps, count_events_callback)
2408         (select_event_lwp_callback): Likewise.
2409         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2410         * arm-linux-nat.c (struct update_registers_data): Remove.
2411         (update_registers_callback): Change type.
2412         (arm_linux_insert_hw_breakpoint1): Update.
2413         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2414         parameter.
2415         (x86_linux_dr_set_addr): Update.
2416         (x86_linux_dr_set_control): Update.
2417         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2418         (iterate_over_lwps): Use gdb::function_view.
2419         * nat/aarch64-linux-hw-point.c (struct
2420         aarch64_dr_update_callback_param): Remove.
2421         (debug_reg_change_callback): Change type.
2422         (aarch64_notify_debug_reg_change): Update.
2423         * s390-linux-nat.c (s390_refresh_per_info): Update.
2424
2425 2019-03-11  Tom Tromey  <tromey@adacore.com>
2426
2427         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2428         redundant assignment to "this_cu".
2429
2430 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2431
2432         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2433
2434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2435
2436         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2437         from...
2438         (rank_one_type): ... this.
2439
2440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2441
2442         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2443         from...
2444         (rank_one_type): ... this.
2445
2446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2447
2448         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2449         from...
2450         (rank_one_type): ... this.
2451
2452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2453
2454         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2455         from...
2456         (rank_one_type): ... this.
2457
2458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2459
2460         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2461         from...
2462         (rank_one_type): ... this.
2463
2464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2465
2466         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2467         from...
2468         (rank_one_type): ... this.
2469
2470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2471
2472         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2473         from...
2474         (rank_one_type): ... this.
2475
2476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2477
2478         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2479         from...
2480         (rank_one_type): ... this.
2481
2482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2483
2484         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2485         from...
2486         (rank_one_type): ... this.
2487
2488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2489
2490         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2491         from...
2492         (rank_one_type): ... this.
2493
2494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2495
2496         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2497         from...
2498         (rank_one_type): ... this.
2499
2500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2501
2502         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2503         from...
2504         (rank_one_type): ... this.
2505
2506 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2507
2508         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2509         inferior-events' shows the example events.
2510
2511 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2512
2513         Support styling on native MS-Windows console
2514
2515         PR/24315
2516         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2517         on MS-Windows if $TERM is not defined.
2518
2519         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2520
2521         * posix-hdep.c (gdb_console_fputs):
2522         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2523         functions.
2524         * ui-file.h (gdb_console_fputs): Add prototype.
2525
2526         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2527         back to fputs only if the former returns zero.
2528
2529 2019-03-07  Tom Tromey  <tom@tromey.com>
2530
2531         * symmisc.c (print_symbol_bcache_statistics): Update.
2532         (print_objfile_statistics): Update.
2533         * symfile.c (allocate_symtab): Update.
2534         * stabsread.c: Don't include bcache.h.
2535         * psymtab.h (struct psymbol_bcache): Don't declare.
2536         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2537         (psymbol_bcache_init, psymbol_bcache_free)
2538         (psymbol_bcache_get_bcache): Don't declare.
2539         * psymtab.c (struct psymbol_bcache): Remove.
2540         (psymtab_storage::psymtab_storage): Update.
2541         (psymtab_storage::~psymtab_storage): Update.
2542         (psymbol_bcache_init, psymbol_bcache_free)
2543         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2544         (add_psymbol_to_bcache): Update.
2545         (allocate_psymtab): Update.
2546         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2547         macro_cache>: No longer pointers.
2548         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2549         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2550         * macrotab.c (macro_bcache): Update.
2551         * macroexp.c: Don't include bcache.h.
2552         * gdbtypes.c (check_types_worklist): Update.
2553         (types_deeply_equal): Remove TRY/CATCH.  Update.
2554         * elfread.c (elf_symtab_read): Update.
2555         * dwarf2read.c: Don't include bcache.h.
2556         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2557         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2558         (print_bcache_statistics, bcache_memory_used): Don't declare.
2559         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2560         methods.  Rename all data members.
2561         * bcache.c (struct bcache): Move to bcache.h.
2562         (bcache::expand_hash_table): Rename from expand_hash_table.
2563         (bcache): Remove.
2564         (bcache::insert): Rename from bcache_full.
2565         (bcache::compare): Rename from bcache_compare.
2566         (bcache_xmalloc): Remove.
2567         (bcache::~bcache): Rename from bcache_xfree.
2568         (bcache::print_statistics): Rename from print_bcache_statistics.
2569         (bcache::memory_used): Rename from bcache_memory_used.
2570
2571 2019-03-07  Pedro Alves  <palves@redhat.com>
2572
2573         * infrun.c (normal_stop): Also check for
2574         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2575
2576 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * f-lang.c (value_from_host_double): Moved to...
2579         * value.c (value_from_host_double): ...here.
2580         * value.h (value_from_host_double): Declare.
2581         * guile/scm-math.c (vlscm_convert_typed_number): Use
2582         value_from_host_double.
2583         (vlscm_convert_number): Likewise.
2584         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2585         * python/py-value.c (convert_value_from_python): Likewise.
2586
2587 2019-03-06  Tom Tromey  <tom@tromey.com>
2588
2589         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2590
2591 2019-03-06  Tom Tromey  <tom@tromey.com>
2592
2593         * utils.h (free_current_contents): Don't declare.
2594         * utils.c (free_current_contents): Remove.
2595
2596 2019-03-06  Tom Tromey  <tom@tromey.com>
2597
2598         * top.c (quit_force): Update.
2599         * main.c (captured_command_loop): Update.
2600         * common/new-op.c (operator new): Update.
2601         * common/common-exceptions.c (struct catcher)
2602         <save_cleanup_chain>: Remove member.
2603         (exceptions_state_mc_init): Update.
2604         (exception_try_scope_entry): Return nullptr.
2605         (exception_try_scope_exit, exception_rethrow)
2606         (throw_exception_sjlj, throw_exception_cxx): Update.
2607         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2608         (all_cleanups, do_cleanups, discard_cleanups)
2609         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2610         (restore_cleanups, restore_final_cleanups): Don't declare.
2611         (do_final_cleanups): Remove parameter.
2612         * common/cleanups.c (cleanup_chain, make_cleanup)
2613         (make_cleanup_dtor, all_cleanups, do_cleanups)
2614         (discard_my_cleanups, discard_cleanups)
2615         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2616         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2617         (null_cleanup): Remove.
2618         (do_final_cleanups): Remove parameter.
2619
2620 2019-03-06  Tom Tromey  <tom@tromey.com>
2621
2622         * remote.c (remote_target::remote_parse_stop_reply): Use
2623         unique_xmalloc_ptr.
2624
2625 2019-03-06  Tom Tromey  <tom@tromey.com>
2626
2627         * stabsread.c (struct stabs_field_info): Rename from field_info.
2628         <list, fnlist>: Add initializers.
2629         <obstack>: New member.
2630         (read_member_functions, read_struct_fields, read_baseclasses):
2631         Allocate on obstack.  Don't use cleanups.
2632         (read_one_struct_field, read_member_functions, read_struct_fields)
2633         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2634         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2635         (read_struct_type): Update.
2636
2637 2019-03-06  Tom Tromey  <tom@tromey.com>
2638
2639         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2640         * common/filestuff.h (make_cleanup_close): Don't declare.
2641         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2642         Remove.
2643
2644 2019-03-06  Tom Tromey  <tom@tromey.com>
2645
2646         * solib-aix.c: Use make_scope_exit.
2647
2648 2019-03-06  Tom Tromey  <tom@tromey.com>
2649
2650         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2651         Use make_scope_exit.
2652
2653 2019-03-06  Tom Tromey  <tom@tromey.com>
2654
2655         * solib-svr4.c (disable_probes_interface): Remove parameter.
2656         (svr4_handle_solib_event): Use make_scope_exit.
2657
2658 2019-03-06  Tom Tromey  <tom@tromey.com>
2659
2660         * remote.c (struct stop_reply_deleter): Remove.
2661         (stop_reply_up): Update.
2662         (struct stop_reply): Derive from notif_event.  Don't typedef.
2663         <regcache>: Now a std::vector.
2664         (stop_reply_xfree): Remove.
2665         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2666         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2667         (remote_target::discard_pending_stop_replies): Use delete.
2668         (remote_target::remote_parse_stop_reply): Update.
2669         (remote_target::process_stop_reply): Update.
2670         * remote-notif.h (struct notif_event): Add virtual destructor.
2671         Remove "dtr" member.
2672         (struct notif_client) <alloc_event>: Return a unique_ptr.
2673         (notif_event_xfree): Don't declare.
2674         (notif_event_up): New typedef.
2675         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2676         (notif_event_xfree, do_notif_event_xfree): Remove.
2677         (remote_notif_state_xfree): Update.
2678
2679 2019-03-06  Tom Tromey  <tom@tromey.com>
2680
2681         * infrun.c (displaced_step_clear_cleanup): Now a
2682         forward_scope_exit type.
2683         (displaced_step_prepare_throw): Update.
2684         (displaced_step_fixup): Update.
2685
2686 2019-03-06  Tom Tromey  <tom@tromey.com>
2687
2688         * inferior.h (class inferior): Update comment.
2689         * gdbthread.h (class thread_info): Update comment.
2690
2691 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2692             Tom Tromey  <tom@tromey.com>
2693
2694         * stabsread.h (struct stab_section_list): Remove.
2695         (coffstab_build_psymtabs): Update.
2696         * dbxread.c (symbuf_sections): Now a std::vector.
2697         (sect_idx): New global.
2698         (fill_symbuf): Update.
2699         (coffstab_build_psymtabs): Change type of stabsects parameter.
2700         Update.
2701         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2702         std::vector.
2703         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2704         (coff_locate_sections): Update.
2705         (coff_symfile_read): Remove cleanups.  Update.
2706         (init_stringtab): Add storage parameter.
2707         (free_stringtab, free_stringtab_cleanup): Remove.
2708         (init_lineno): Add storage parameter.
2709         (free_linetab, free_linetab_cleanup): Remove.
2710
2711 2019-03-06  Pedro Alves  <palves@redhat.com>
2712
2713         * linux-fork.c (fork_info::clobber_regs): Delete.
2714         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2715         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2716         comment.  Adjust.
2717         (scoped_switch_fork_info::scoped_switch_fork_info)
2718         (checkpoint_command, linux_fork_context): Adjust
2719         fork_save_infrun_state calls.
2720
2721 2019-03-06  Pedro Alves  <palves@redhat.com>
2722
2723         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2724         (inf_has_multiple_threads): Return 'bool' and rewrite using
2725         inferior_info::threads().
2726
2727 2019-03-06  Pedro Alves  <palves@redhat.com>
2728
2729         * linux-fork.c: Include <list>.
2730         (fork_list): Now a std::list instance.
2731         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2732         (forks_exist_p, find_last_fork): Adjust.
2733         (new_fork): Delete.
2734         (one_fork_p): New.
2735         (add_fork): Adjust.
2736         (free_fork): Delete, folded into fork_info::~fork_info().
2737         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2738         Adjust.
2739         (init_fork_list): Delete.
2740         (linux_fork_killall, linux_fork_mourn_inferior)
2741         (linux_fork_detach, info_checkpoints_command): Adjust.
2742         (_initialize_linux_fork): No longer call init_fork_list.
2743
2744 2019-03-06  Pedro Alves  <palves@redhat.com>
2745
2746         * linux-fork.c (new_fork): New, split out of ...
2747         (add_fork): ... this.  Return void.  Move "first fork" special
2748         case from here, to ...
2749         (checkpoint_command): ... here.
2750         * linux-linux.h (add_fork): Return void.
2751
2752 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2753
2754         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2755
2756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2757             Chris January  <chris.january@arm.com>
2758             David Lecomber  <david.lecomber@arm.com>
2759
2760         * f-exp.y: New token, UNOP_INTRINSIC.
2761         (exp): New pattern using UNOP_INTRINSIC token.
2762         (f77_keywords): Add 'abs' keyword.
2763         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2764         (value_from_host_double): New function.
2765         (evaluate_subexp_f): Support UNOP_ABS.
2766
2767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2768
2769         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2770         types.
2771
2772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2773
2774         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2775         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2776         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2777
2778 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2779
2780         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2781
2782 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2783             Chris January  <chris.january@arm.com>
2784
2785         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2786         * f-exp.y: Define 'KIND' token.
2787         (exp): New pattern for KIND expressions.
2788         (ptype): Handle types with a kind extension.
2789         (direct_abs_decl): Extend to spot kind extensions.
2790         (f77_keywords): Add 'kind' to the list.
2791         (push_kind_type): New function.
2792         (convert_to_kind_type): New function.
2793         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2794         * parse.c (operator_length_standard): Likewise.
2795         * parser-defs.h (enum type_pieces): Add tp_kind.
2796         * std-operator.def: Add UNOP_KIND.
2797
2798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * f-exp.y (f_parse): Set yydebug.
2801
2802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2803
2804         * f-lang.c (evaluate_subexp_f): New function.
2805         (exp_descriptor_f): New global.
2806         (f_language_defn): Use exp_descriptor_f instead of
2807         exp_descriptor_standard.
2808
2809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * f-exp.y (struct token): Add comments.
2812         (dot_ops): Remove uppercase versions and the end marker.
2813         (f77_keywords): Likewise.
2814         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2815         entries in the dot_ops array are case insensitive, and use
2816         strncasecmp to compare strings.  Also some whitespace cleanup in
2817         this area.  Similar for the f77_keywords array, except entries in
2818         this list might be case sensitive.
2819
2820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * f-exp.y (struct f77_boolean_val): Add comments.
2823         (boolean_values): Remove uppercase versions, and end marker.
2824         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2825         and use strncasecmp to achieve case insensitivity.  Additionally,
2826         perform whitespace cleanup around this code.
2827
2828 2019-03-06  Tom Tromey  <tromey@adacore.com>
2829
2830         * remote-sim.c (gdbsim_target_open): Use result of
2831         gdb_argv::release.
2832
2833 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2834         Dirk Schubert  <dirk.schubert@arm.com>
2835         Chris January  <chris.january@arm.com>
2836
2837         * eval.c (evaluate_subexp_standard): Call Fortran argument
2838         wrapping logic.
2839         * f-lang.c (struct value): A value which can be passed into a
2840         Fortran function call.
2841         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2842         where appropriate.
2843         (struct type): Value ready for a Fortran function call.
2844         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2845         is needed.
2846         * f-lang.h (fortran_argument_convert): Declaration.
2847         (fortran_preserve_arg_pointer): Declaration.
2848         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2849
2850 2019-03-05  Tom Tromey  <tromey@adacore.com>
2851
2852         * python/py-prettyprint.c (print_string_repr): Remove #if.
2853         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2854
2855 2019-03-05  Tom Tromey  <tromey@adacore.com>
2856
2857         * target.c (the_dummy_target): Move later.  Change type to
2858         "dummy_target".
2859         (initialize_targets): Don't initialize the_dummy_target.
2860
2861 2019-03-05  Tom Tromey  <tromey@adacore.com>
2862
2863         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2864         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2865
2866 2019-03-05  Tom Tromey  <tromey@adacore.com>
2867
2868         * windows-nat.c (windows_nat_target::attach)
2869         (windows_nat_target::detach): Don't call gdb_flush.
2870         * valprint.c (generic_val_print, val_print, val_print_string):
2871         Don't call gdb_flush.
2872         * utils.c (defaulted_query): Don't call gdb_flush.
2873         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2874         * target.c (target_announce_detach): Don't call gdb_flush.
2875         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2876         * remote.c (extended_remote_target::attach): Don't call
2877         gdb_flush.
2878         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2879         * printcmd.c (do_examine): Don't call gdb_flush.
2880         (info_display_command): Don't call gdb_flush.
2881         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2882         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2883         * memattr.c (info_mem_command): Don't call gdb_flush.
2884         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2885         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2886         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2887         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2888         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2889         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2890         (gnu_nat_target::detach): Don't call gdb_flush.
2891         * f-valprint.c (f_val_print): Don't call gdb_flush.
2892         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2893         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2894         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2895         gdb_flush.
2896         * c-valprint.c (c_val_print): Don't call gdb_flush.
2897         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2898
2899 2019-03-05  Tom Tromey  <tromey@adacore.com>
2900
2901         * varobj.c (update_dynamic_varobj_children): Update.
2902         (install_default_visualizer): Use reset, not release.
2903         * value.c (set_internalvar): Update.
2904         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2905         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2906         ATTRIBUTE_UNUSED_RESULT.
2907
2908 2019-03-05  Tom Tromey  <tromey@adacore.com>
2909
2910         * remote.c (class scoped_remote_fd) <release>: Add
2911         ATTRIBUTE_UNUSED_RESULT.
2912
2913 2019-03-05  Tom Tromey  <tromey@adacore.com>
2914
2915         * macroexp.c (struct macro_buffer) <release>: Add
2916         ATTRIBUTE_UNUSED_RESULT.
2917
2918 2019-03-05  Tom Tromey  <tromey@adacore.com>
2919
2920         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2921         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2922         ATTRIBUTE_UNUSED_RESULT.
2923
2924 2019-03-05  Tom Tromey  <tromey@adacore.com>
2925
2926         * common/scoped_fd.h (class scoped_fd) <release>: Add
2927         ATTRIBUTE_UNUSED_RESULT.
2928
2929 2019-03-05  Tom Tromey  <tromey@adacore.com>
2930
2931         * parser-defs.h (struct parser_state) <release>: Add
2932         ATTRIBUTE_UNUSED_RESULT.
2933
2934 2019-03-05  Tom Tromey  <tromey@adacore.com>
2935
2936         * utils.h (class gdb_argv) <release>: Add
2937         ATTRIBUTE_UNUSED_RESULT.
2938         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2939
2940 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2941
2942         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2943         for-loop range, to avoid compiler warnings.
2944
2945         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2946         avoid compiler warnings about unused variables.
2947
2948         * NEWS: Mention end of support for native debugging on MS-Windows
2949         before XP.
2950
2951         PR gdb/24292
2952         * common/netstuff.c:
2953         * gdbserver/gdbreplay.c
2954         * gdbserver/remote-utils.c:
2955         * ser-tcp.c:
2956         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2957         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2958         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2959         'getaddrinfo' and 'freeaddrinfo' were not available before
2960         Windows XP, and mingw.org's MinGW headers by default define
2961         _WIN32_WINNT to 0x500.
2962
2963 2019-03-01  Gary Benson <gbenson@redhat.com>
2964
2965         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2966
2967 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2968             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2969
2970         PR gdb/8527
2971         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2972         set_sigint_trap, clear_sigint_trap.
2973
2974 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2975
2976         * target.c (target_detach): Clear the regcache and the
2977         frame cache.
2978
2979 2019-02-27  Pedro Alves  <palves@redhat.com>
2980
2981         * utils.c (set_screen_size): When we cap the height/width sizes,
2982         tweak the corresponding command variable to show "unlimited":
2983
2984 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2985             Pedro Alves  <palves@redhat.com>
2986
2987         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2988         before calling rl_set_screen_size.
2989
2990 2019-02-27  Tom Tromey  <tromey@adacore.com>
2991
2992         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2993         define.
2994         * python/py-value.c: Remove Python 2.4 workaround.
2995         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2996         workaround.
2997         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2998         Python 2.4 workaround.
2999         * python/python-internal.h: Remove Python 2.4 comment.
3000         (Py_ssize_t): Don't define.
3001         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3002         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3003         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3004         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3005         * python/python.c (do_start_initialization): Remove Python 2.4
3006         workaround.
3007         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3008         (print_children): Remove Python 2.4 workaround.
3009         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3010         workaround.
3011         (CHARBUFFERPROC_NAME): Remove.
3012         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3013         Python 2.4 workaround.
3014
3015 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3016
3017         * NEWS: Note minimum Python version.
3018
3019 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3020
3021         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3022         code from these functions.  Remove corresponding ifdefs.  Use
3023         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3024         Remove gotos and target of gotos.
3025         (infpy_search_memory): Likewise.
3026
3027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3030         (hppa_gdbarch_init): Don't register deleted functions with
3031         gdbarch.
3032
3033 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3034
3035         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3036         (h8300_unwind_sp): Delete.
3037         (h8300_dummy_id): Delete.
3038         (h8300_gdbarch_init): Don't register deleted functions with
3039         gdbarch.
3040
3041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3044         (ft32_unwind_pc): Delete.
3045         (ft32_unwind_sp): Delete.
3046         (ft32_gdbarch_init): Don't register deleted functions with
3047         gdbarch.
3048
3049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3052         (frv_unwind_pc): Delete.
3053         (frv_unwind_sp): Delete.
3054         (frv_gdbarch_init): Don't register deleted functions with
3055         gdbarch.
3056
3057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3058
3059         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3060         (riscv_unwind_pc): Delete.
3061         (riscv_unwind_sp): Delete.
3062         (riscv_gdbarch_init): Don't register deleted functions with
3063         gdbarch.
3064
3065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3068         (csky_unwind_pc): Delete.
3069         (csky_unwind_sp): Delete.
3070         (csky_gdbarch_init): Don't register deleted functions with
3071         gdbarch.
3072
3073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3076         (cris_unwind_pc): Delete.
3077         (cris_unwind_sp): Delete.
3078         (cris_gdbarch_init): Don't register deleted functions with
3079         gdbarch.
3080
3081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3084         (bfin_unwind_pc): Delete.
3085         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3086
3087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3090         (arm_unwind_pc): Delete.
3091         (arm_unwind_sp): Delete.
3092         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3093
3094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3095
3096         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3097         (arc_unwind_pc): Delete.
3098         (arc_unwind_sp): Delete.
3099         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3100
3101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3102
3103         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3104         (alpha_unwind_pc): Delete.
3105         (alpha_gdbarch_init): Don't register deleted functions with
3106         gdbarch.
3107
3108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3109
3110         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3111         (aarch64_unwind_pc): Delete.
3112         (aarch64_unwind_sp): Delete.
3113         (aarch64_gdbarch_init): Don't register deleted functions with
3114         gdbarch.
3115
3116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3117
3118         * gdbtypes.c (type_align): Don't consider static members when
3119         computing structure alignment.
3120
3121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3124         return 0 for other types.
3125         * arch-utils.c (default_type_align): Always return 0.
3126         * gdbarch.h: Regenerate.
3127         * gdbarch.sh (type_align): Extend comment.
3128         * gdbtypes.c (type_align): Add additional comments, always call
3129         gdbarch_type_align before applying the default rules.
3130         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3131         generic code will then apply a suitable default.
3132         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3133         types, return 0 for other types.
3134
3135 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3136
3137         * NEWS: Create a new section for the next release branch.
3138         Rename the section of the current branch, now that it has
3139         been cut.
3140
3141 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3142
3143         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3144         * version.in: Bump version to 8.3.50.DATE-git.
3145
3146 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3147
3148         * aix-thread.c (ptid_cmp): Remove unused variable.
3149         (get_signaled_thread): Likewise.
3150         (store_regs_user_thread): Likewise.
3151         (store_regs_kernel_thread): Likewise.
3152         (fetch_regs_kernel_thread): Remove shadowed variable.
3153
3154 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3155
3156         * features/riscv/32bit-cpu.xml: Add register numbers.
3157         * features/riscv/32bit-fpu.c: Regenerate.
3158         * features/riscv/32bit-fpu.xml: Add register numbers.
3159         * features/riscv/64bit-cpu.xml: Add register numbers.
3160         * features/riscv/64bit-fpu.c: Regenerate.
3161         * features/riscv/64bit-fpu.xml: Add register numbers.
3162
3163 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3164
3165         * NEWS: Mention two argument form of gdb.Value constructor.
3166         * python/py-value.c (convert_buffer_and_type_to_value): New
3167         function.
3168         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3169         Add support for handling an optional second argument.  Call
3170         convert_buffer_and_type_to_value as appropriate.
3171         * python/python-internal.h (Py_buffer_deleter): New struct.
3172         (Py_buffer_up): New typedef.
3173
3174 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3175
3176         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3177         instead of releasing ownership.
3178
3179 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3180
3181         * dwarf2read.c (open_and_init_dwp_file): Call
3182         elf_numsections instead of bfd_count_sections to initialize
3183         dwp_file->num_sections.
3184
3185 2019-02-25  Tom Tromey  <tromey@adacore.com>
3186
3187         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3188
3189 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3190
3191         * gcore.in: Add '--readnever' option when invoking GDB.
3192
3193 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3194
3195         * MAINTAINERS: Update my email address.
3196
3197 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3198
3199         * build-id.c (build_id_to_debug_bfd_1): New function.
3200         (build_id_to_debug_bfd): Look for separate debug file in
3201         sysroot.
3202
3203 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * gdbarch.sh: Update the copyright year range that is placed into
3206         generated files.
3207
3208 2019-02-22  Keith Seitz  <keiths@redhat.com>
3209
3210         PR symtab/23853
3211         * linespec.c (create_sals_line_offset): Search for the default
3212         symtab's filename instead of its fullname.
3213
3214 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3215
3216         * NEWS: Update style defaults.
3217
3218 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3219
3220         * main.c (captured_main_1): Disable styling in batch mode.
3221
3222 2019-02-20  Tom Tromey  <tom@tromey.com>
3223
3224         * symtab.c (symtab_symbol_info): Fix typos.
3225
3226 2019-02-20  Tom Tromey  <tromey@adacore.com>
3227
3228         * findcmd.c (_initialize_mem_search): Use upper case for
3229         metasyntactic variables.
3230
3231 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3232
3233         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3234         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3235
3236 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3237
3238         * top.h (source_file_name): Change to std::string.
3239         * top.c (source_file_name): Likewise.
3240         (command_line_input): Adjust.
3241         * cli/cli-script.c (script_from_file): Adjust.
3242
3243 2019-02-19  Tom Tromey  <tromey@adacore.com>
3244
3245         * ravenscar-thread.c
3246         (ravenscar_thread_target::update_thread_list): Don't call
3247         ada_build_task_list.
3248         * ada-lang.h (ada_build_task_list): Don't declare.
3249         * ada-tasks.c (struct ada_tasks_inferior_data)
3250         <task_list_valid_p>: Now bool.
3251         (read_known_tasks, ada_task_list_changed)
3252         (ada_tasks_invalidate_inferior_data): Update.
3253         (read_known_tasks_array): Return bool.
3254         (read_known_tasks_list): Likewise.
3255         (read_known_tasks): Return void.
3256         (ada_build_task_list): Now static.
3257
3258 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3259
3260         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3261         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3262
3263 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3264
3265         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3266         variant for ada_tasks_pspace_data_handle and
3267         ada_tasks_inferior_data_handle.
3268         (ada_tasks_pspace_data_cleanup): New function.
3269         (ada_tasks_inferior_data_cleanup): New function.
3270
3271 2019-02-17  Tom Tromey  <tom@tromey.com>
3272
3273         * macrotab.h (macro_source_fullname): Return a std::string.
3274         * macrotab.c (macro_include, check_for_redefinition)
3275         (macro_undef, macro_lookup_definition, foreach_macro)
3276         (foreach_macro_in_scope): Update.
3277         (macro_source_fullname): Return a std::string.
3278         * macrocmd.c (show_pp_source_pos): Update.
3279
3280 2019-02-17  Tom Tromey  <tom@tromey.com>
3281
3282         * macrocmd.c (show_pp_source_pos): Style the file names.
3283
3284 2019-02-17  Tom Tromey  <tom@tromey.com>
3285
3286         PR tui/24197:
3287         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3288
3289 2019-02-17  Tom Tromey  <tom@tromey.com>
3290
3291         * ada-lang.c (user_select_syms): Use filtered printing.
3292         * utils.c (wrap_style): New global.
3293         (desired_style): Remove.
3294         (emit_style_escape): Add stream parameter.
3295         (set_output_style, reset_terminal_style, prompt_for_continue):
3296         Update.
3297         (flush_wrap_buffer): Only flush gdb_stdout.
3298         (wrap_here): Set wrap_style.
3299         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3300         treat escape sequences as a character.  Change when wrap buffer is
3301         flushed.
3302         (fputs_styled): Do not set the output style when the default is
3303         requested.
3304         * ui-style.h (struct ui_file_style) <is_default>: New method.
3305         * source.c (print_source_lines_base): Emit escape sequences in one
3306         piece.
3307
3308 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3309
3310         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3311         integers and enumeration types.
3312
3313 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3314
3315         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3316         instead of lookup_symbol_in_language
3317         (do_exact_match): New function.
3318         (ada_get_symbol_name_matcher): Return do_exact_match when
3319         doing a verbatim match.
3320
3321 2019-02-15  Tom Tromey  <tromey@adacore.com>
3322
3323         * ravenscar-thread.c (ravenscar_thread_target::resume)
3324         (ravenscar_thread_target::wait): Special case wildcard requests.
3325
3326 2019-02-15  Tom Tromey  <tromey@adacore.com>
3327
3328         * ravenscar-thread.c (base_ptid): Remove.
3329         (struct ravenscar_thread_target) <close>: New method.
3330         <m_base_ptid>: New member.
3331         <update_inferior_ptid, active_task, task_is_currently_active,
3332         runtime_initialized>: Declare methods.
3333         <ravenscar_thread_target>: Add constructor.
3334         (ravenscar_thread_target::task_is_currently_active)
3335         (ravenscar_thread_target::update_inferior_ptid)
3336         (ravenscar_runtime_initialized): Rename.  Now methods.
3337         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3338         (ravenscar_thread_target::update_thread_list): Update.
3339         (ravenscar_thread_target::active_task): Now method.
3340         (ravenscar_thread_target::store_registers)
3341         (ravenscar_thread_target::prepare_to_store)
3342         (ravenscar_thread_target::prepare_to_store)
3343         (ravenscar_thread_target::mourn_inferior): Update.
3344         (ravenscar_inferior_created): Use "new" to create target.
3345         (ravenscar_thread_target::get_ada_task_ptid): Update.
3346         (_initialize_ravenscar): Don't initialize base_ptid.
3347         (ravenscar_ops): Remove global.
3348
3349 2019-02-15  Tom Tromey  <tromey@adacore.com>
3350
3351         * target.h (push_target): Declare new overload.
3352         * target.c (push_target): New overload, taking an rvalue reference.
3353         * remote.c (remote_target::open_1): Use push_target overload.
3354         * corelow.c (core_target_open): Use push_target overload.
3355
3356 2019-02-15  Tom Tromey  <tromey@adacore.com>
3357
3358         * ravenscar-thread.c (is_ravenscar_task)
3359         (ravenscar_task_is_currently_active): Return bool.
3360         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3361         (_initialize_ravenscar): Remove "(void)".
3362         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3363         Return bool.
3364
3365 2019-02-15  Tom Tromey  <tromey@adacore.com>
3366
3367         * ravenscar-thread.c (ravenscar_runtime_initializer)
3368         (has_ravenscar_runtime, get_running_thread_id)
3369         (ravenscar_thread_target::resume): Fix indentation.
3370
3371 2019-02-15  Tom Tromey  <tromey@adacore.com>
3372
3373         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3374         from ravenscar_arch_ops.
3375         (sparc_ravenscar_ops::fetch_registers)
3376         (sparc_ravenscar_ops::store_registers): Now methods.
3377         (sparc_ravenscar_prepare_to_store): Remove.
3378         (sparc_ravenscar_ops): Redefine.
3379         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3380         methods and destructor.  Remove members.
3381         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3382         (ravenscar_thread_target::store_registers)
3383         (ravenscar_thread_target::prepare_to_store): Update.
3384         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3385         Remove.
3386         (struct ppc_ravenscar_powerpc_ops): Derive from
3387         ravenscar_arch_ops.
3388         (ppc_ravenscar_powerpc_ops::fetch_registers)
3389         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3390         (ppc_ravenscar_powerpc_ops): Redefine.
3391         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3392         (ppc_ravenscar_e500_ops::fetch_registers)
3393         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3394         (ppc_ravenscar_e500_ops): Redefine.
3395         * aarch64-ravenscar-thread.c
3396         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3397         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3398         (aarch64_ravenscar_fetch_registers)
3399         (aarch64_ravenscar_store_registers): Now methods.
3400         (aarch64_ravenscar_ops): Redefine.
3401
3402 2019-02-15  Tom Tromey  <tromey@adacore.com>
3403
3404         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3405         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3406         (ravenscar_thread_target::stopped_by_watchpoint)
3407         (ravenscar_thread_target::stopped_data_address)
3408         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3409
3410 2019-02-15  Tom Tromey  <tromey@adacore.com>
3411
3412         * ravenscar-thread.c: Fix some typos.
3413
3414 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3415             Tom Tromey  <tromey@adacore.com>
3416
3417         * ada-lang.c (ada_exception_sal): Change addr_string to a
3418         std::string.
3419         (create_ada_exception_catchpoint): Update.
3420
3421 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3422             Tom Tromey  <tromey@adacore.com>
3423
3424         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3425         (bp_location_ops): Remove.
3426         (base_breakpoint_allocate_location): Update.
3427         (free_bp_location): Update.
3428         * ada-lang.c (class ada_catchpoint_location)
3429         <ada_catchpoint_location>: Remove ops parameter.
3430         (ada_catchpoint_location_dtor): Remove.
3431         (ada_catchpoint_location_ops): Remove.
3432         (allocate_location_exception): Update.
3433         * breakpoint.h (struct bp_location_ops): Remove.
3434         (class bp_location) <bp_location>: Remove bp_location_ops
3435         parameter.
3436         <~bp_location>: Add destructor.
3437         <ops>: Remove.
3438
3439 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3440             Pedro Alves  <palves@redhat.com>
3441
3442         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3443         'PATH_MAX'.
3444
3445 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3446             Samuel Thibault  <samuel.thibault@gnu.org>
3447             Thomas Schwinge  <thomas@codesourcery.com>
3448
3449         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3450         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3451
3452 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3453
3454         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3455         (check_empty): Use "const char *".
3456
3457         * gnu-nat.c (gnu_nat_target::detach): Instead of
3458         'detach_inferior (pid)' call
3459         'detach_inferior (find_inferior_pid (pid))'.
3460
3461         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3462         'nat/fork-inferior.o'.
3463         * gnu-nat.c: #include "nat/fork-inferior.h".
3464
3465         * gnu-nat.c (gnu_nat_target::detach): Instead of
3466         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3467         * gnu-nat.h: #include "inf-child.h".
3468         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3469         'i386_gnu_nat_target::fetch_registers'.
3470         (gnu_store_registers): Rename/move to
3471         'i386_gnu_nat_target::store_registers'.
3472
3473         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3474         * gnu-nat.h (mach_thread_info): New function.
3475         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3476
3477         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3478
3479 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3480
3481         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3482
3483 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3484
3485         * windows-nat.c (windows_add_thread): Add new parameter
3486         "main_thread_p" with default value set to false.  Update
3487         function documentation as well as all callers.
3488         (windows_delete_thread): Likewise.
3489         (fake_create_process): Update call to windows_add_thread.
3490         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3491         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3492         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3493         call to windows_delete_thread.
3494
3495 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3496
3497         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3498
3499 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3500
3501         * symfile.c (find_separate_debug_file): Use canonical path of
3502         sysroot with child_path instead of gdb_sysroot if it is valid.
3503
3504 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3505
3506         * symfile.c (find_separate_debug_file): Use child_path to
3507         determine if an object file is under a sysroot.
3508
3509 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3510
3511         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3512         unittests/child-path-selftests.c.
3513         * common/pathstuff.c (child_path): New function.
3514         * common/pathstuff.h (child_path): New prototype.
3515         * unittests/child-path-selftests.c: New file.
3516
3517 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3518
3519         * symfile.c (find_separate_debug_file): Look for separate debug
3520         files in debug directories under the sysroot.
3521
3522 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3523
3524         * symtab.h (struct minimal_symbol data_p): New const method.
3525         (struct minimal_symbol text_p): Likewise.
3526         * symtab.c (output_source_filename): Use file name style
3527         to print file name.
3528         (print_symbol_info): Likewise.
3529         (print_msymbol_info): Use address style to print addresses.
3530         Use function name style to print executable text symbols.
3531         (expand_symtab_containing_pc): Use data_p.
3532         (find_pc_sect_compunit_symtab): Likewise.
3533
3534 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3535
3536         * breakpoint.c (describe_other_breakpoints): Use address style
3537         to print addresses.
3538         (say_where): Likewise.
3539
3540 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3541
3542         * ada-typeprint.c (print_func_type): Print function name
3543         style to print function name.
3544         * c-typeprint.c (c_print_type_1): Likewise.
3545
3546 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3547
3548         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3549         for execve.
3550
3551 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3552
3553         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3554         type_stack.
3555
3556 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3557
3558         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3559         TYPE_CODE_REF types.
3560
3561 2019-02-08  Jim Wilson  <jimw@sifive.com>
3562
3563         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3564         (riscv_linux_fregset): New.
3565         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3566
3567 2019-02-07  Tom Tromey  <tom@tromey.com>
3568
3569         * thread.c (thread_cancel_execution_command): Update.
3570         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3571         methods.
3572         (struct thread_fsm_ops): Remove.
3573         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3574         (thread_fsm_should_stop, thread_fsm_return_value)
3575         (thread_fsm_set_finished, thread_fsm_finished_p)
3576         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3577         Don't declare.
3578         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3579         * infrun.c (clear_proceed_status_thread)
3580         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3581         (print_stop_event): Update.
3582         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3583         Add constructor.
3584         (step_command_fsm_ops): Remove.
3585         (new_step_command_fsm): Remove.
3586         (step_1): Update.
3587         (step_command_fsm::should_stop): Rename from
3588         step_command_fsm_should_stop.
3589         (step_command_fsm::clean_up): Rename from
3590         step_command_fsm_clean_up.
3591         (step_command_fsm::do_async_reply_reason): Rename from
3592         step_command_fsm_async_reply_reason.
3593         (struct until_next_fsm): Inherit from thread_fsm.  Add
3594         constructor.
3595         (until_next_fsm_ops): Remove.
3596         (new_until_next_fsm): Remove.
3597         (until_next_fsm::should_stop): Rename from
3598         until_next_fsm_should_stop.
3599         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3600         (until_next_fsm::do_async_reply_reason): Rename from
3601         until_next_fsm_async_reply_reason.
3602         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3603         constructor.  Change type of breakpoint.
3604         (finish_command_fsm_ops): Remove.
3605         (new_finish_command_fsm): Remove.
3606         (finish_command_fsm::should_stop): Rename from
3607         finish_command_fsm_should_stop.
3608         (finish_command_fsm::clean_up): Rename from
3609         finish_command_fsm_clean_up.
3610         (finish_command_fsm::return_value): Rename from
3611         finish_command_fsm_return_value.
3612         (finish_command_fsm::do_async_reply_reason): Rename from
3613         finish_command_fsm_async_reply_reason.
3614         (finish_command): Update.
3615         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3616         Add constructor.
3617         (call_thread_fsm_ops): Remove.
3618         (call_thread_fsm::call_thread_fsm): Rename from
3619         new_call_thread_fsm.
3620         (call_thread_fsm::should_stop): Rename from
3621         call_thread_fsm_should_stop.
3622         (call_thread_fsm::should_notify_stop): Rename from
3623         call_thread_fsm_should_notify_stop.
3624         (run_inferior_call, call_function_by_hand_dummy): Update.
3625         * cli/cli-interp.c (should_print_stop_to_console): Update.
3626         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3627         Add constructor.  Change type of location_breakpoint,
3628         caller_breakpoint.
3629         (until_break_fsm_ops): Remove.
3630         (new_until_break_fsm): Remove.
3631         (until_break_fsm::should_stop): Rename from
3632         until_break_fsm_should_stop.
3633         (until_break_fsm::clean_up): Rename from
3634         until_break_fsm_clean_up.
3635         (until_break_fsm::do_async_reply_reason): Rename from
3636         until_break_fsm_async_reply_reason.
3637         (until_break_command): Update.
3638         * thread-fsm.c: Remove.
3639         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3640
3641 2019-02-07  Tom Tromey  <tom@tromey.com>
3642
3643         * yy-remap.h: Add include guard.
3644         * xtensa-tdep.h: Add include guard.
3645         * xcoffread.h: Rename include guard.
3646         * varobj-iter.h: Add include guard.
3647         * tui/tui.h: Rename include guard.
3648         * tui/tui-winsource.h: Rename include guard.
3649         * tui/tui-wingeneral.h: Rename include guard.
3650         * tui/tui-windata.h: Rename include guard.
3651         * tui/tui-win.h: Rename include guard.
3652         * tui/tui-stack.h: Rename include guard.
3653         * tui/tui-source.h: Rename include guard.
3654         * tui/tui-regs.h: Rename include guard.
3655         * tui/tui-out.h: Rename include guard.
3656         * tui/tui-layout.h: Rename include guard.
3657         * tui/tui-io.h: Rename include guard.
3658         * tui/tui-hooks.h: Rename include guard.
3659         * tui/tui-file.h: Rename include guard.
3660         * tui/tui-disasm.h: Rename include guard.
3661         * tui/tui-data.h: Rename include guard.
3662         * tui/tui-command.h: Rename include guard.
3663         * tic6x-tdep.h: Add include guard.
3664         * target/waitstatus.h: Rename include guard.
3665         * target/wait.h: Rename include guard.
3666         * target/target.h: Rename include guard.
3667         * target/resume.h: Rename include guard.
3668         * target-float.h: Rename include guard.
3669         * stabsread.h: Add include guard.
3670         * rs6000-tdep.h: Add include guard.
3671         * riscv-fbsd-tdep.h: Add include guard.
3672         * regformats/regdef.h: Rename include guard.
3673         * record.h: Rename include guard.
3674         * python/python.h: Rename include guard.
3675         * python/python-internal.h: Rename include guard.
3676         * python/py-stopevent.h: Rename include guard.
3677         * python/py-ref.h: Rename include guard.
3678         * python/py-record.h: Rename include guard.
3679         * python/py-record-full.h: Rename include guard.
3680         * python/py-record-btrace.h: Rename include guard.
3681         * python/py-instruction.h: Rename include guard.
3682         * python/py-events.h: Rename include guard.
3683         * python/py-event.h: Rename include guard.
3684         * procfs.h: Add include guard.
3685         * proc-utils.h: Add include guard.
3686         * p-lang.h: Add include guard.
3687         * or1k-tdep.h: Rename include guard.
3688         * observable.h: Rename include guard.
3689         * nto-tdep.h: Rename include guard.
3690         * nat/x86-linux.h: Rename include guard.
3691         * nat/x86-linux-dregs.h: Rename include guard.
3692         * nat/x86-gcc-cpuid.h: Add include guard.
3693         * nat/x86-dregs.h: Rename include guard.
3694         * nat/x86-cpuid.h: Rename include guard.
3695         * nat/ppc-linux.h: Rename include guard.
3696         * nat/mips-linux-watch.h: Rename include guard.
3697         * nat/linux-waitpid.h: Rename include guard.
3698         * nat/linux-ptrace.h: Rename include guard.
3699         * nat/linux-procfs.h: Rename include guard.
3700         * nat/linux-osdata.h: Rename include guard.
3701         * nat/linux-nat.h: Rename include guard.
3702         * nat/linux-namespaces.h: Rename include guard.
3703         * nat/linux-btrace.h: Rename include guard.
3704         * nat/glibc_thread_db.h: Rename include guard.
3705         * nat/gdb_thread_db.h: Rename include guard.
3706         * nat/gdb_ptrace.h: Rename include guard.
3707         * nat/fork-inferior.h: Rename include guard.
3708         * nat/amd64-linux-siginfo.h: Rename include guard.
3709         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3710         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3711         * nat/aarch64-linux.h: Rename include guard.
3712         * nat/aarch64-linux-hw-point.h: Rename include guard.
3713         * mn10300-tdep.h: Add include guard.
3714         * mips-linux-tdep.h: Add include guard.
3715         * mi/mi-parse.h: Rename include guard.
3716         * mi/mi-out.h: Rename include guard.
3717         * mi/mi-main.h: Rename include guard.
3718         * mi/mi-interp.h: Rename include guard.
3719         * mi/mi-getopt.h: Rename include guard.
3720         * mi/mi-console.h: Rename include guard.
3721         * mi/mi-common.h: Rename include guard.
3722         * mi/mi-cmds.h: Rename include guard.
3723         * mi/mi-cmd-break.h: Rename include guard.
3724         * m2-lang.h: Add include guard.
3725         * location.h: Rename include guard.
3726         * linux-record.h: Rename include guard.
3727         * linux-nat.h: Add include guard.
3728         * linux-fork.h: Add include guard.
3729         * i386-darwin-tdep.h: Rename include guard.
3730         * hppa-linux-offsets.h: Add include guard.
3731         * guile/guile.h: Rename include guard.
3732         * guile/guile-internal.h: Rename include guard.
3733         * gnu-nat.h: Rename include guard.
3734         * gdb-stabs.h: Rename include guard.
3735         * frv-tdep.h: Add include guard.
3736         * f-lang.h: Add include guard.
3737         * event-loop.h: Add include guard.
3738         * darwin-nat.h: Rename include guard.
3739         * cp-abi.h: Rename include guard.
3740         * config/sparc/nm-sol2.h: Rename include guard.
3741         * config/nm-nto.h: Rename include guard.
3742         * config/nm-linux.h: Add include guard.
3743         * config/i386/nm-i386gnu.h: Rename include guard.
3744         * config/djgpp/nl_types.h: Rename include guard.
3745         * config/djgpp/langinfo.h: Rename include guard.
3746         * compile/gcc-cp-plugin.h: Add include guard.
3747         * compile/gcc-c-plugin.h: Add include guard.
3748         * compile/compile.h: Rename include guard.
3749         * compile/compile-object-run.h: Rename include guard.
3750         * compile/compile-object-load.h: Rename include guard.
3751         * compile/compile-internal.h: Rename include guard.
3752         * compile/compile-cplus.h: Rename include guard.
3753         * compile/compile-c.h: Rename include guard.
3754         * common/xml-utils.h: Rename include guard.
3755         * common/x86-xstate.h: Rename include guard.
3756         * common/version.h: Rename include guard.
3757         * common/vec.h: Rename include guard.
3758         * common/tdesc.h: Rename include guard.
3759         * common/selftest.h: Rename include guard.
3760         * common/scoped_restore.h: Rename include guard.
3761         * common/scoped_mmap.h: Rename include guard.
3762         * common/scoped_fd.h: Rename include guard.
3763         * common/safe-iterator.h: Rename include guard.
3764         * common/run-time-clock.h: Rename include guard.
3765         * common/refcounted-object.h: Rename include guard.
3766         * common/queue.h: Rename include guard.
3767         * common/ptid.h: Rename include guard.
3768         * common/print-utils.h: Rename include guard.
3769         * common/preprocessor.h: Rename include guard.
3770         * common/pathstuff.h: Rename include guard.
3771         * common/observable.h: Rename include guard.
3772         * common/netstuff.h: Rename include guard.
3773         * common/job-control.h: Rename include guard.
3774         * common/host-defs.h: Rename include guard.
3775         * common/gdb_wait.h: Rename include guard.
3776         * common/gdb_vecs.h: Rename include guard.
3777         * common/gdb_unlinker.h: Rename include guard.
3778         * common/gdb_unique_ptr.h: Rename include guard.
3779         * common/gdb_tilde_expand.h: Rename include guard.
3780         * common/gdb_sys_time.h: Rename include guard.
3781         * common/gdb_string_view.h: Rename include guard.
3782         * common/gdb_splay_tree.h: Rename include guard.
3783         * common/gdb_setjmp.h: Rename include guard.
3784         * common/gdb_ref_ptr.h: Rename include guard.
3785         * common/gdb_optional.h: Rename include guard.
3786         * common/gdb_locale.h: Rename include guard.
3787         * common/gdb_assert.h: Rename include guard.
3788         * common/filtered-iterator.h: Rename include guard.
3789         * common/filestuff.h: Rename include guard.
3790         * common/fileio.h: Rename include guard.
3791         * common/environ.h: Rename include guard.
3792         * common/common-utils.h: Rename include guard.
3793         * common/common-types.h: Rename include guard.
3794         * common/common-regcache.h: Rename include guard.
3795         * common/common-inferior.h: Rename include guard.
3796         * common/common-gdbthread.h: Rename include guard.
3797         * common/common-exceptions.h: Rename include guard.
3798         * common/common-defs.h: Rename include guard.
3799         * common/common-debug.h: Rename include guard.
3800         * common/cleanups.h: Rename include guard.
3801         * common/buffer.h: Rename include guard.
3802         * common/btrace-common.h: Rename include guard.
3803         * common/break-common.h: Rename include guard.
3804         * cli/cli-utils.h: Rename include guard.
3805         * cli/cli-style.h: Rename include guard.
3806         * cli/cli-setshow.h: Rename include guard.
3807         * cli/cli-script.h: Rename include guard.
3808         * cli/cli-interp.h: Rename include guard.
3809         * cli/cli-decode.h: Rename include guard.
3810         * cli/cli-cmds.h: Rename include guard.
3811         * charset-list.h: Add include guard.
3812         * buildsym-legacy.h: Rename include guard.
3813         * bfin-tdep.h: Add include guard.
3814         * ax.h: Rename include guard.
3815         * arm-linux-tdep.h: Add include guard.
3816         * arm-fbsd-tdep.h: Add include guard.
3817         * arch/xtensa.h: Rename include guard.
3818         * arch/tic6x.h: Add include guard.
3819         * arch/i386.h: Add include guard.
3820         * arch/arm.h: Rename include guard.
3821         * arch/arm-linux.h: Rename include guard.
3822         * arch/arm-get-next-pcs.h: Rename include guard.
3823         * arch/amd64.h: Add include guard.
3824         * arch/aarch64-insn.h: Rename include guard.
3825         * arch-utils.h: Rename include guard.
3826         * annotate.h: Add include guard.
3827         * amd64-darwin-tdep.h: Rename include guard.
3828         * aarch64-linux-tdep.h: Add include guard.
3829         * aarch64-fbsd-tdep.h: Add include guard.
3830         * aarch32-linux-nat.h: Add include guard.
3831
3832 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3833
3834         * macrotab.c (macro_define_internal): New function that
3835         factorizes macro_define_object_internal and macro_define_function
3836         code.
3837         (macro_define_object_internal): Use macro_define_internal.
3838         (macro_define_function): Likewise.
3839
3840 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3841
3842         * macrocmd.c (extract_identifier): Return
3843         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3844         callers.
3845
3846 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3847
3848         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3849
3850 2019-02-05  Tom Tromey  <tom@tromey.com>
3851
3852         * target.c (target_stack::unpush): Move assertion earlier.
3853
3854 2019-01-30  Tom Tromey  <tom@tromey.com>
3855
3856         PR python/23615:
3857         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3858         (gdbpy_parse_and_eval): Likewise.
3859         * python/python-internal.h (gdbpy_allow_threads): New class.
3860
3861 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3862
3863         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3864         (aarch64_fbsd_fpregmap): Move earlier.
3865         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3866         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3867         instead of individual calls to trad_frame_set_reg_addr.
3868         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3869         earlier.
3870         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3871         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3872         instead of individual calls to trad_frame_set_reg_addr.
3873
3874 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3875
3876         * CONTRIBUTE: Replace contribution list with wiki link.
3877
3878 2019-01-25  Tom Tromey  <tom@tromey.com>
3879
3880         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3881
3882 2019-01-25  Tom Tromey  <tom@tromey.com>
3883
3884         * xtensa-linux-nat.c: Fix common/ includes.
3885         * xml-support.h: Fix common/ includes.
3886         * xml-support.c: Fix common/ includes.
3887         * x86-linux-nat.c: Fix common/ includes.
3888         * windows-nat.c: Fix common/ includes.
3889         * varobj.h: Fix common/ includes.
3890         * varobj.c: Fix common/ includes.
3891         * value.c: Fix common/ includes.
3892         * valops.c: Fix common/ includes.
3893         * utils.c: Fix common/ includes.
3894         * unittests/xml-utils-selftests.c: Fix common/ includes.
3895         * unittests/utils-selftests.c: Fix common/ includes.
3896         * unittests/unpack-selftests.c: Fix common/ includes.
3897         * unittests/tracepoint-selftests.c: Fix common/ includes.
3898         * unittests/style-selftests.c: Fix common/ includes.
3899         * unittests/string_view-selftests.c: Fix common/ includes.
3900         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3901         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3902         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3903         * unittests/rsp-low-selftests.c: Fix common/ includes.
3904         * unittests/parse-connection-spec-selftests.c: Fix common/
3905         includes.
3906         * unittests/optional-selftests.c: Fix common/ includes.
3907         * unittests/offset-type-selftests.c: Fix common/ includes.
3908         * unittests/observable-selftests.c: Fix common/ includes.
3909         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3910         * unittests/memrange-selftests.c: Fix common/ includes.
3911         * unittests/memory-map-selftests.c: Fix common/ includes.
3912         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3913         * unittests/function-view-selftests.c: Fix common/ includes.
3914         * unittests/environ-selftests.c: Fix common/ includes.
3915         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3916         * unittests/common-utils-selftests.c: Fix common/ includes.
3917         * unittests/cli-utils-selftests.c: Fix common/ includes.
3918         * unittests/array-view-selftests.c: Fix common/ includes.
3919         * ui-file.c: Fix common/ includes.
3920         * tui/tui-io.c: Fix common/ includes.
3921         * tracepoint.h: Fix common/ includes.
3922         * tracepoint.c: Fix common/ includes.
3923         * tracefile-tfile.c: Fix common/ includes.
3924         * top.h: Fix common/ includes.
3925         * top.c: Fix common/ includes.
3926         * thread.c: Fix common/ includes.
3927         * target/waitstatus.h: Fix common/ includes.
3928         * target/waitstatus.c: Fix common/ includes.
3929         * target.h: Fix common/ includes.
3930         * target.c: Fix common/ includes.
3931         * target-memory.c: Fix common/ includes.
3932         * target-descriptions.c: Fix common/ includes.
3933         * symtab.h: Fix common/ includes.
3934         * symfile.c: Fix common/ includes.
3935         * stap-probe.c: Fix common/ includes.
3936         * spu-linux-nat.c: Fix common/ includes.
3937         * sparc-nat.c: Fix common/ includes.
3938         * source.c: Fix common/ includes.
3939         * solib.c: Fix common/ includes.
3940         * solib-target.c: Fix common/ includes.
3941         * ser-unix.c: Fix common/ includes.
3942         * ser-tcp.c: Fix common/ includes.
3943         * ser-pipe.c: Fix common/ includes.
3944         * ser-base.c: Fix common/ includes.
3945         * selftest-arch.c: Fix common/ includes.
3946         * s12z-tdep.c: Fix common/ includes.
3947         * rust-exp.y: Fix common/ includes.
3948         * rs6000-aix-tdep.c: Fix common/ includes.
3949         * riscv-tdep.c: Fix common/ includes.
3950         * remote.c: Fix common/ includes.
3951         * remote-notif.h: Fix common/ includes.
3952         * remote-fileio.h: Fix common/ includes.
3953         * remote-fileio.c: Fix common/ includes.
3954         * regcache.h: Fix common/ includes.
3955         * regcache.c: Fix common/ includes.
3956         * record-btrace.c: Fix common/ includes.
3957         * python/python.c: Fix common/ includes.
3958         * python/py-type.c: Fix common/ includes.
3959         * python/py-inferior.c: Fix common/ includes.
3960         * progspace.h: Fix common/ includes.
3961         * producer.c: Fix common/ includes.
3962         * procfs.c: Fix common/ includes.
3963         * proc-api.c: Fix common/ includes.
3964         * printcmd.c: Fix common/ includes.
3965         * ppc-linux-nat.c: Fix common/ includes.
3966         * parser-defs.h: Fix common/ includes.
3967         * osdata.c: Fix common/ includes.
3968         * obsd-nat.c: Fix common/ includes.
3969         * nat/x86-linux.c: Fix common/ includes.
3970         * nat/x86-linux-dregs.c: Fix common/ includes.
3971         * nat/x86-dregs.h: Fix common/ includes.
3972         * nat/x86-dregs.c: Fix common/ includes.
3973         * nat/ppc-linux.c: Fix common/ includes.
3974         * nat/mips-linux-watch.h: Fix common/ includes.
3975         * nat/mips-linux-watch.c: Fix common/ includes.
3976         * nat/linux-waitpid.c: Fix common/ includes.
3977         * nat/linux-ptrace.h: Fix common/ includes.
3978         * nat/linux-ptrace.c: Fix common/ includes.
3979         * nat/linux-procfs.c: Fix common/ includes.
3980         * nat/linux-personality.c: Fix common/ includes.
3981         * nat/linux-osdata.c: Fix common/ includes.
3982         * nat/linux-namespaces.c: Fix common/ includes.
3983         * nat/linux-btrace.h: Fix common/ includes.
3984         * nat/linux-btrace.c: Fix common/ includes.
3985         * nat/fork-inferior.c: Fix common/ includes.
3986         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3987         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3988         * nat/aarch64-linux.c: Fix common/ includes.
3989         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3990         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3991         * namespace.h: Fix common/ includes.
3992         * mips-linux-tdep.c: Fix common/ includes.
3993         * minsyms.c: Fix common/ includes.
3994         * mi/mi-parse.h: Fix common/ includes.
3995         * mi/mi-main.c: Fix common/ includes.
3996         * mi/mi-cmd-env.c: Fix common/ includes.
3997         * memrange.h: Fix common/ includes.
3998         * memattr.c: Fix common/ includes.
3999         * maint.h: Fix common/ includes.
4000         * maint.c: Fix common/ includes.
4001         * main.c: Fix common/ includes.
4002         * machoread.c: Fix common/ includes.
4003         * location.c: Fix common/ includes.
4004         * linux-thread-db.c: Fix common/ includes.
4005         * linux-nat.c: Fix common/ includes.
4006         * linux-fork.c: Fix common/ includes.
4007         * inline-frame.c: Fix common/ includes.
4008         * infrun.c: Fix common/ includes.
4009         * inflow.c: Fix common/ includes.
4010         * inferior.h: Fix common/ includes.
4011         * inferior.c: Fix common/ includes.
4012         * infcmd.c: Fix common/ includes.
4013         * inf-ptrace.c: Fix common/ includes.
4014         * inf-child.c: Fix common/ includes.
4015         * ia64-linux-nat.c: Fix common/ includes.
4016         * i387-tdep.c: Fix common/ includes.
4017         * i386-tdep.c: Fix common/ includes.
4018         * i386-linux-tdep.c: Fix common/ includes.
4019         * i386-linux-nat.c: Fix common/ includes.
4020         * i386-go32-tdep.c: Fix common/ includes.
4021         * i386-fbsd-tdep.c: Fix common/ includes.
4022         * i386-fbsd-nat.c: Fix common/ includes.
4023         * guile/scm-type.c: Fix common/ includes.
4024         * guile/guile.c: Fix common/ includes.
4025         * go32-nat.c: Fix common/ includes.
4026         * gnu-nat.c: Fix common/ includes.
4027         * gdbthread.h: Fix common/ includes.
4028         * gdbarch-selftests.c: Fix common/ includes.
4029         * gdb_usleep.c: Fix common/ includes.
4030         * gdb_select.h: Fix common/ includes.
4031         * gdb_bfd.c: Fix common/ includes.
4032         * gcore.c: Fix common/ includes.
4033         * fork-child.c: Fix common/ includes.
4034         * findvar.c: Fix common/ includes.
4035         * fbsd-nat.c: Fix common/ includes.
4036         * event-top.c: Fix common/ includes.
4037         * event-loop.c: Fix common/ includes.
4038         * dwarf2read.c: Fix common/ includes.
4039         * dwarf2loc.c: Fix common/ includes.
4040         * dwarf2-frame.c: Fix common/ includes.
4041         * dwarf-index-cache.c: Fix common/ includes.
4042         * dtrace-probe.c: Fix common/ includes.
4043         * disasm-selftests.c: Fix common/ includes.
4044         * defs.h: Fix common/ includes.
4045         * csky-tdep.c: Fix common/ includes.
4046         * cp-valprint.c: Fix common/ includes.
4047         * cp-support.h: Fix common/ includes.
4048         * cp-support.c: Fix common/ includes.
4049         * corelow.c: Fix common/ includes.
4050         * completer.h: Fix common/ includes.
4051         * completer.c: Fix common/ includes.
4052         * compile/compile.c: Fix common/ includes.
4053         * compile/compile-loc2c.c: Fix common/ includes.
4054         * compile/compile-cplus-types.c: Fix common/ includes.
4055         * compile/compile-cplus-symbols.c: Fix common/ includes.
4056         * command.h: Fix common/ includes.
4057         * cli/cli-dump.c: Fix common/ includes.
4058         * cli/cli-cmds.c: Fix common/ includes.
4059         * charset.c: Fix common/ includes.
4060         * build-id.c: Fix common/ includes.
4061         * btrace.h: Fix common/ includes.
4062         * btrace.c: Fix common/ includes.
4063         * breakpoint.h: Fix common/ includes.
4064         * breakpoint.c: Fix common/ includes.
4065         * ax.h: 
4066         (enum agent_op): Fix common/ includes.
4067         * ax-general.c (struct aop_map): Fix common/ includes.
4068         * ax-gdb.c: Fix common/ includes.
4069         * auxv.c: Fix common/ includes.
4070         * auto-load.c: Fix common/ includes.
4071         * arm-tdep.c: Fix common/ includes.
4072         * arch/riscv.c: Fix common/ includes.
4073         * arch/ppc-linux-common.c: Fix common/ includes.
4074         * arch/i386.c: Fix common/ includes.
4075         * arch/arm.c: Fix common/ includes.
4076         * arch/arm-linux.c: Fix common/ includes.
4077         * arch/arm-get-next-pcs.c: Fix common/ includes.
4078         * arch/amd64.c: Fix common/ includes.
4079         * arch/aarch64.c: Fix common/ includes.
4080         * arch/aarch64-insn.c: Fix common/ includes.
4081         * arch-utils.c: Fix common/ includes.
4082         * amd64-windows-tdep.c: Fix common/ includes.
4083         * amd64-tdep.c: Fix common/ includes.
4084         * amd64-sol2-tdep.c: Fix common/ includes.
4085         * amd64-obsd-tdep.c: Fix common/ includes.
4086         * amd64-nbsd-tdep.c: Fix common/ includes.
4087         * amd64-linux-tdep.c: Fix common/ includes.
4088         * amd64-linux-nat.c: Fix common/ includes.
4089         * amd64-fbsd-tdep.c: Fix common/ includes.
4090         * amd64-fbsd-nat.c: Fix common/ includes.
4091         * amd64-dicos-tdep.c: Fix common/ includes.
4092         * amd64-darwin-tdep.c: Fix common/ includes.
4093         * agent.c: Fix common/ includes.
4094         * ada-lang.h: Fix common/ includes.
4095         * ada-lang.c: Fix common/ includes.
4096         * aarch64-tdep.c: Fix common/ includes.
4097
4098 2019-01-25  Tom Tromey  <tom@tromey.com>
4099
4100         * common/create-version.sh: Use common/version.h.
4101
4102 2019-01-24  Pedro Alves  <palves@redhat.com>
4103
4104         * infrun.c (signal_stop, signal_print, signal_program)
4105         (signal_catch, signal_pass): Now arrays instead of pointers.
4106         (update_signals_program_target, do_target_resume)
4107         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4108         * linux-nat.c (linux_nat_target::pass_signals)
4109         (linux_nat_target::create_inferior, linux_nat_target::attach):
4110         Adjust.
4111         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4112         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4113         * procfs.c (procfs_target::pass_signals): Adjust.
4114         * record-full.c (record_full_target::resume): Adjust.
4115         * remote.c (remote_target::pass_signals)
4116         (remote_target::program_signals): Adjust.
4117         * target-debug.h (target_debug_print_signals): Now takes a
4118         gdb::array_view as parameter.  Adjust.
4119         * target.h (target_ops) <pass_signals, program_signals>: Replace
4120         pointer and length parameters with gdb::array_view.
4121         (target_pass_signals, target_program_signals): Likewise.
4122         * target-delegates.c: Regenerate.
4123
4124 2019-01-24  Pedro Alves  <palves@redhat.com>
4125
4126         * common/forward-scope-exit.h
4127         (forward_scope_exit::forward_scope_exit): Pass arguments to
4128         m_bind_function directly, instead of creating a std::bind and
4129         copying that.
4130
4131 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4132
4133         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4134         for static members.
4135         (pass_in_v_vfp_candidate): Likewise.
4136
4137 2019-01-23  Tom Tromey  <tom@tromey.com>
4138             Pedro Alves  <palves@redhat.com>
4139
4140         * regcache.c (class regcache_invalidator): Remove.
4141         (regcache::raw_write): Use make_scope_exit.
4142
4143 2019-01-23  Tom Tromey  <tom@tromey.com>
4144
4145         * ui-out.h (class ui_out_emit_type): Update comment.
4146
4147 2019-01-23  Tom Tromey  <tom@tromey.com>
4148
4149         * infrun.c (fetch_inferior_event): Update comment.
4150
4151 2019-01-23  Tom Tromey  <tom@tromey.com>
4152             Pedro Alves  <palves@redhat.com>
4153
4154         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4155         parameter.
4156         (fetch_inferior_event): Use SCOPE_EXIT.
4157
4158
4159 2019-01-23  Tom Tromey  <tom@tromey.com>
4160             Pedro Alves  <palves@redhat.com>
4161
4162         * infrun.c (disable_thread_events): Delete.
4163         (stop_all_threads): Use SCOPE_EXIT.
4164
4165 2019-01-23  Tom Tromey  <tom@tromey.com>
4166             Pedro Alves  <palves@redhat.com>
4167
4168         * symfile.c: Include forward-scope-exit.h.
4169         (clear_symtab_users_cleanup): Replace forward declaration with
4170         a FORWARD_SCOPE_EXIT.
4171         (syms_from_objfile_1): Use the forward_scope_exit and
4172         gdb::optional instead of cleanup_function.
4173         (reread_symbols): Use the forward_scope_exit instead of
4174         cleanup_function.
4175         (clear_symtab_users_cleanup): Remove function.
4176
4177 2019-01-23  Tom Tromey  <tom@tromey.com>
4178             Pedro Alves  <palves@redhat.com>
4179
4180         * linux-nat.c: Include scope-exit.h.
4181         (cleanup_target_stop): Remove.
4182         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4183         SCOPE_EXIT.
4184
4185 2019-01-23  Tom Tromey  <tom@tromey.com>
4186             Pedro Alves  <palves@redhat.com>
4187
4188         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4189         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4190
4191 2019-01-23  Tom Tromey  <tom@tromey.com>
4192             Andrew Burgess  <andrew.burgess@embecosm.com>
4193             Pedro Alves  <palves@redhat.com>
4194
4195         * infrun.c (fetch_inferior_event): Use scope_exit.
4196         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4197         * top.c (execute_command): Use scope_exit.
4198         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4199         * utils.c (do_bpstat_clear_actions_cleanup)
4200         (make_bpstat_clear_actions_cleanup): Remove.
4201
4202 2019-01-23  Tom Tromey  <tom@tromey.com>
4203             Pedro Alves  <palves@redhat.com>
4204
4205         * infrun.c: Include "common/scope-exit.h"
4206         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4207         (wait_for_inferior): Use SCOPE_EXIT.
4208         (fetch_inferior_event): Use scope_exit.
4209
4210 2019-01-23  Tom Tromey  <tom@tromey.com>
4211             Pedro Alves  <palves@redhat.com>
4212
4213         * breakpoint.c (create_breakpoint): Remove cleanup.
4214
4215 2019-01-23  Tom Tromey  <tom@tromey.com>
4216             Andrew Burgess  <andrew.burgess@embecosm.com>
4217             Pedro Alves  <palves@redhat.com>
4218
4219 2019-01-23  Pedro Alves  <palves@redhat.com>
4220
4221         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4222
4223 2019-01-23  Pedro Alves  <palves@redhat.com>
4224             Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * gdbthread.h: Include "common/forward-scope-exit.h".
4227         (scoped_finish_thread_state): Redefine custom class in terms of
4228         forward_scope_exit.
4229
4230 2019-01-23  Pedro Alves  <palves@redhat.com>
4231             Andrew Burgess  <andrew.burgess@embecosm.com>
4232
4233         * common/forward-scope-exit.h: New file.
4234
4235 2019-01-23  Pedro Alves  <palves@redhat.com>
4236             Andrew Burgess  <andrew.burgess@embecosm.com>
4237             Tom Tromey  <tom@tromey.com>
4238
4239         * common/scope-exit.h: New file.
4240
4241 2019-01-23  Pedro Alves  <palves@redhat.com>
4242
4243         * common/preprocessor.h (ESC): Rename to ...
4244         (ESC_PARENS): ... this.
4245         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4246         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4247
4248 2019-01-23  Tom Tromey  <tom@tromey.com>
4249
4250         * language.h (class scoped_switch_to_sym_language_if_auto):
4251         Initialize m_lang in both cases.
4252
4253 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4254
4255         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4256         with XCNEW.
4257
4258 2019-01-22  Tom Tromey  <tom@tromey.com>
4259
4260         * corelow.c: Do not include sys/file.h.
4261
4262 2019-01-22  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-wingeneral.h: Include gdb_curses.h.
4265
4266 2019-01-22  Tom Tromey  <tom@tromey.com>
4267
4268         * source-cache.h (class source_cache) <get_source_lines,
4269         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4270
4271 2019-01-22  Tom Tromey  <tom@tromey.com>
4272
4273         * remote-fileio.h (struct remote_target): Declare.
4274
4275 2019-01-22  Tom Tromey  <tom@tromey.com>
4276
4277         * python/py-arch.c: Do not include py-ref.h.
4278         * python/py-bpevent.c: Do not include py-ref.h.
4279         * python/py-cmd.c: Do not include py-ref.h.
4280         * python/py-continueevent.c: Do not include py-ref.h.
4281         * python/py-event.h: Do not include py-ref.h.
4282         * python/py-evtregistry.c: Do not include py-ref.h.
4283         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4284         * python/py-frame.c: Do not include py-ref.h.
4285         * python/py-framefilter.c: Do not include py-ref.h.
4286         * python/py-function.c: Do not include py-ref.h.
4287         * python/py-infevents.c: Do not include py-ref.h.
4288         * python/py-linetable.c: Do not include py-ref.h.
4289         * python/py-objfile.c: Do not include py-ref.h.
4290         * python/py-param.c: Do not include py-ref.h.
4291         * python/py-prettyprint.c: Do not include py-ref.h.
4292         * python/py-progspace.c: Do not include py-ref.h.
4293         * python/py-symbol.c: Do not include py-ref.h.
4294         * python/py-symtab.c: Do not include py-ref.h.
4295         * python/py-type.c: Do not include py-ref.h.
4296         * python/py-unwind.c: Do not include py-ref.h.
4297         * python/py-utils.c: Do not include py-ref.h.
4298         * python/py-value.c: Do not include py-ref.h.
4299         * python/py-varobj.c: Do not include py-ref.h.
4300         * python/py-xmethods.c: Do not include py-ref.h.
4301         * python/python.c: Do not include py-ref.h.
4302         * varobj.c: Do not include py-ref.h.
4303
4304 2019-01-22  Tom Tromey  <tom@tromey.com>
4305
4306         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4307         keyword for bcache.
4308
4309 2019-01-22  Tom Tromey  <tom@tromey.com>
4310
4311         * compile/compile-cplus-types.c: Remove a comment by #include.
4312
4313 2019-01-22  Tom Tromey  <tom@tromey.com>
4314
4315         * compile/gcc-c-plugin.h: Include compile-internal.h.
4316
4317 2019-01-22  Tom Tromey  <tom@tromey.com>
4318
4319         * stabsread.c (EXTERN): Do not define.
4320         (symnum, next_symbol_text_func, processing_gcc_compilation)
4321         (within_function, global_sym_chain, global_stabs)
4322         (previous_stab_code, this_object_header_files)
4323         (n_this_object_header_files)
4324         (n_allocated_this_object_header_files): Define.
4325         * stabsread.h (EXTERN): Never define.  Use "extern".
4326
4327 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4328
4329         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4330         history_value.
4331
4332 2019-01-21  Tom Tromey  <tom@tromey.com>
4333
4334         * ui-out.c: Fix includes.
4335         * tui/tui-source.c: Fix includes.
4336         * target.c: Fix includes.
4337         * remote.c: Fix includes.
4338         * regcache.c: Fix includes.
4339         * python/py-block.c: Fix includes.
4340         * printcmd.c: Fix includes.
4341         * or1k-tdep.c: Fix includes.
4342         * mi/mi-main.c: Fix includes.
4343         * m32r-tdep.c: Fix includes.
4344         * csky-tdep.c: Fix includes.
4345         * compile/compile-cplus-types.c: Fix includes.
4346         * cli/cli-interp.c: Fix includes.
4347
4348 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4349
4350         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4351         for padding.
4352
4353 2019-01-16  Tom Tromey  <tom@tromey.com>
4354
4355         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4356         earlier.
4357         (struct objfile) <msymbols_range>: Move from top level.
4358         <msymbols>: New method.
4359         (class objfile_msymbols): Remove.
4360         * symtab.c (default_collect_symbol_completion_matches_break_on):
4361         Update.
4362         * symmisc.c (dump_msymbols): Update.
4363         * stabsread.c (scan_file_globals): Update.
4364         * objc-lang.c (info_selectors_command, info_classes_command)
4365         (find_methods): Update.
4366         * minsyms.c (find_solib_trampoline_target): Update.
4367         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4368         * coffread.c (coff_symfile_read): Update.
4369         * ada-lang.c (ada_lookup_simple_minsym)
4370         (ada_collect_symbol_completion_matches): Update.
4371
4372 2019-01-16  Tom Tromey  <tom@tromey.com>
4373
4374         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4375         type.  Remove no-argument constructor.
4376         <iterator::operator++>: Simplify.
4377         <begin>: Update.
4378         <end>: Use minimal_symbol_count.
4379
4380 2019-01-16  Tom Tromey  <tom@tromey.com>
4381
4382         * objfiles.h (struct objfile) <psymtabs>: New method.
4383         (class objfile_psymtabs): Remove.
4384         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4385         typedef.
4386         <range>: New method.
4387         (require_partial_symbols): Change return type.
4388         * psymtab.c (require_partial_symbols)
4389         (psym_expand_symtabs_matching): Update.
4390         * mdebugread.c (parse_partial_symbols): Update.
4391         * dbxread.c (dbx_end_psymtab): Update.
4392
4393 2019-01-15  Tom Tromey  <tom@tromey.com>
4394
4395         * symtab.c (lookup_objfile_from_block)
4396         (lookup_symbol_in_objfile_symtabs)
4397         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4398         (find_line_symtab, info_sources_command)
4399         (default_collect_symbol_completion_matches_break_on)
4400         (make_source_files_completion_list): Update.
4401         * symmisc.c (print_objfile_statistics, dump_objfile)
4402         (maintenance_print_symbols, maintenance_info_symtabs)
4403         (maintenance_check_symtabs, maintenance_info_line_tables):
4404         Update.
4405         * source.c (select_source_symtab)
4406         (forget_cached_source_info_for_objfile): Update.
4407         * objfiles.h (class objfile_compunits): Remove.
4408         (struct objfile) <compunits_range>: New typedef.
4409         (compunits): New method.
4410         * objfiles.c (objfile_relocate1): Update.
4411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4412         * maint.c (count_symtabs_and_blocks): Update.
4413         * linespec.c (iterate_over_all_matching_symtabs): Update.
4414         * cp-support.c (add_symbol_overload_list_qualified): Update.
4415         * coffread.c (coff_symtab_read): Update.
4416         * ada-lang.c (add_nonlocal_symbols)
4417         (ada_collect_symbol_completion_matches)
4418         (ada_add_global_exceptions): Update.
4419
4420 2019-01-15  Tom Tromey  <tom@tromey.com>
4421
4422         * progspace.h (program_space) <objfiles_safe_range>: New
4423         typedef.
4424         <objfiles_safe>: New method.
4425         * objfiles.h (class all_objfiles_safe): Remove.
4426         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4427         * jit.c (jit_inferior_exit_hook): Update.
4428
4429 2019-01-17  Tom Tromey  <tom@tromey.com>
4430
4431         * progspace.h (program_space) <objfiles_range>: New typedef.
4432         <objfiles>: New method.
4433         <objfiles_head>: Rename from objfiles.
4434         (object_files): Update.
4435         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4436         * guile/scm-pretty-print.c
4437         (ppscm_find_pretty_printer_from_objfiles): Update.
4438         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4439         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4440         Update.
4441         * python/py-progspace.c (pspy_get_objfiles): Update.
4442         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4443         Update.
4444         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4445         (objfpy_lookup_objfile_by_build_id): Update.
4446         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4447         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4448         Update.
4449         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4450         (expand_symtab_containing_pc, lookup_objfile_from_block)
4451         (lookup_static_symbol, basic_lookup_transparent_type)
4452         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4453         (find_line_symtab, info_sources_command)
4454         (default_collect_symbol_completion_matches_break_on)
4455         (make_source_files_completion_list, find_main_name): Update.
4456         * symmisc.c (print_symbol_bcache_statistics)
4457         (print_objfile_statistics, maintenance_print_symbols)
4458         (maintenance_print_msymbols, maintenance_print_objfiles)
4459         (maintenance_info_symtabs, maintenance_check_symtabs)
4460         (maintenance_expand_symtabs, maintenance_info_line_tables):
4461         Update.
4462         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4463         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4464         (map_overlay_command, unmap_overlay_command)
4465         (simple_overlay_update, expand_symtabs_matching)
4466         (map_symbol_filenames): Update.
4467         * symfile-debug.c (set_debug_symfile): Update.
4468         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4469         Update.
4470         * source.c (select_source_symtab, forget_cached_source_info):
4471         Update.
4472         * solib.c (solib_read_symbols): Update.
4473         * solib-spu.c (append_ocl_sos): Update.
4474         * psymtab.c (maintenance_print_psymbols)
4475         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4476         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4477         * printcmd.c (info_symbol_command): Update.
4478         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4479         Update.
4480         * objfiles.h (class all_objfiles): Remove.
4481         * objfiles.c (have_partial_symbols, have_full_symbols)
4482         (have_minimal_symbols, qsort_cmp, update_section_map)
4483         (shared_objfile_contains_address_p)
4484         (default_iterate_over_objfiles_in_search_order): Update.
4485         * objc-lang.c (info_selectors_command, info_classes_command)
4486         (find_methods): Update.
4487         * minsyms.c (find_solib_trampoline_target): Update.
4488         * maint.c (maintenance_info_sections)
4489         (maintenance_translate_address, count_symtabs_and_blocks):
4490         Update.
4491         * main.c (captured_main_1): Update.
4492         * linux-thread-db.c (try_thread_db_load_from_pdir)
4493         (has_libpthread): Update.
4494         * linespec.c (iterate_over_all_matching_symtabs)
4495         (search_minsyms_for_name): Update.
4496         * jit.c (jit_find_objf_with_entry_addr): Update.
4497         * hppa-tdep.c (find_unwind_entry)
4498         (hppa_lookup_stub_minimal_symbol): Update.
4499         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4500         Update.
4501         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4502         (elf_gnu_ifunc_resolve_by_got): Update.
4503         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4504         * dwarf-index-write.c (save_gdb_index_command): Update.
4505         * cp-support.c (add_symbol_overload_list_qualified): Update.
4506         * breakpoint.c (create_overlay_event_breakpoint)
4507         (create_longjmp_master_breakpoint)
4508         (create_std_terminate_master_breakpoint)
4509         (create_exception_master_breakpoint): Update.
4510         * blockframe.c (find_pc_partial_function): Update.
4511         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4512         (ada_collect_symbol_completion_matches)
4513         (ada_add_global_exceptions): Update.
4514
4515 2019-01-17  Tom Tromey  <tom@tromey.com>
4516
4517         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4518         declare VEC.
4519         (solib_target_parse_libraries): Change return type.
4520         (library_list_start_segment, library_list_start_section)
4521         (library_list_end_library, library_list_start_library); Update.
4522         (solib_target_free_library_list): Remove.
4523         (solib_target_parse_libraries): Remove cleanup.  Change return
4524         type.
4525         (solib_target_current_sos): Update.
4526
4527 2019-01-17  Tom Tromey  <tromey@bapiya>
4528
4529         * valprint.c: Replace "the the" with "the".
4530         * symtab.c: Replace "the the" with "the".
4531         * solib.c: Replace "the the" with "the".
4532         * solib-dsbt.c: Replace "the the" with "the".
4533         * linespec.c: Replace "the the" with "the".
4534         * dwarf2loc.h: Replace "the the" with "the".
4535         * amd64-windows-tdep.c: Replace "the the" with "the".
4536         * aarch64-tdep.c: Replace "the the" with "the".
4537
4538 2019-01-16  Keith Seitz  <keiths@redhat.com>
4539
4540         PR gdb/23773
4541         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4542         <builder>: Rename to ..
4543         <m_builder>: ... this and make private.
4544         (dwarf2_cu::get_builder): New method.  Change all users of
4545         `builder' to use this method.
4546         (dwarf2_start_symtab): Move to ...
4547         (dwarf2_cu::start_symtab): ... here.  Update all callers
4548         (setup_type_unit_groups): Move to ...
4549         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4550         callers.
4551         (dwarf2_cu::reset_builder): New method.
4552         (process_full_compunit, process_full_type_unit): Use
4553         dwarf2_cu::reset_builder.
4554         (follow_die_offset): Record the ancestor CU if it is different
4555         from the followed DIE's CU.
4556         (follow_die_sig_1): Likewise.
4557
4558 2019-01-15  Tom Tromey  <tom@tromey.com>
4559
4560         * remote.c (class remote_state) <buf>: Now a char_vector.
4561         <buf_size>: Remove.
4562         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4563         parameter.
4564         (remote_target::getpkt_or_notif_sane_1)
4565         (remote_target::getpkt_sane)
4566         (remote_target::getpkt_or_notif_sane): Likewise.
4567         (class remote_target) <putpkt>: New overload.
4568         (remote_target::read_frame): Change type of "buf_p".  Remove
4569         sizeof_p parameter.
4570         (packet_ok): New overload.
4571         (packet_check_result): New overload.
4572         Update all uses.
4573
4574 2019-01-14  Tom Tromey  <tom@tromey.com>
4575
4576         * remote-notif.c (handle_notification, remote_notif_ack)
4577         (remote_notif_parse): Make "buf" const.
4578         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4579         const.
4580         (remote_notif_parse, remote_notif_ack, handle_notification):
4581         Likewise.
4582         * remote.c (remote_notif_stop_parse): Make "buf" const.
4583         (remote_target::remote_parse_stop_reply): Make "buf" const.
4584         (remote_notif_stop_ack): Make "buf" const.
4585
4586 2019-01-14  Tom Tromey  <tom@tromey.com>
4587
4588         * remote.c (remote_console_output): Make parameter const.
4589
4590 2019-01-14  Tom Tromey  <tom@tromey.com>
4591
4592         * target-debug.h (target_debug_print_signals): Constify.
4593         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4594         * procfs.c (procfs_target::pass_signals): Update.
4595         * linux-nat.c (linux_nat_target::pass_signals): Update.
4596         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4597         * target-delegates.c: Rebuild.
4598         * remote.c (remote_target::program_signals): Update.
4599         (remote_target::pass_signals): Update.
4600         * target.c (target_pass_signals): Constify argument.
4601         (target_program_signals): Likewise.
4602         * target.h (struct target_ops) <pass_signals, program_signals>:
4603         Constify argument.
4604         (target_pass_signals, target_program_signals): Constify argument.
4605
4606 2019-01-14  Tom Tromey  <tom@tromey.com>
4607
4608         PR tui/28819:
4609         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4610
4611 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4612
4613         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4614         field.
4615         * rs6000-tdep.c: Include reggroups.h.
4616         (IS_V_ALIAS_PSEUDOREG): Define.
4617         (rs6000_register_name): Return names for the "vX" aliases.
4618         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4619         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4620         aliases.  Call default_register_reggroup_p for all other
4621         pseudo-registers.
4622         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4623         New functions.
4624         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4625         Handle "vX" aliases.
4626         (v_alias_pseudo_register_collect): New function.
4627         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4628         (rs6000_gdbarch_init): Initialize "vX" aliases as
4629         pseudo-registers.  Restore registration of
4630         rs6000_pseudo_register_reggroup_p with
4631         set_tdesc_pseudo_register_reggroup_p.
4632
4633 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4634
4635         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4636         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4637         set_gdbarch_num_pseudo_regs.
4638
4639 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4640
4641         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4642         Remove arg prefixname, add do_set and do_show.
4643         Add member functions set_list and show_list.
4644         * cli/cli-style.c (class cli_style_option): Update accordingly.
4645         (style_set_list): Move to file scope.
4646         (style_show_list): Likewise.
4647         (set_style): Call help_list.
4648         (show_style): Call cmd_show_list.
4649         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4650         Update to use the new macro.
4651
4652 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4653
4654         * ada-lang.c (_initialize_ada_language): Expand the help text
4655         for the "catch exception" command.
4656
4657 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4658
4659         * symtab.c (matching_obj_sections): Initialize obj,
4660         declare it closer to its usage.
4661
4662 2019-01-10  Tom Tromey  <tom@tromey.com>
4663
4664         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4665         (basic_inf_threads_range): Remove.
4666         (inf_threads_range, inf_non_exited_threads_range)
4667         (safe_inf_threads_range): Use next_adapter.
4668
4669 2019-01-10  Keith Seitz  <keiths@redhat.com>
4670
4671         PR gdb/23712
4672         PR symtab/23010
4673         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4674         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4675
4676 2019-01-10  Keith Seitz  <keiths@redhat.com>
4677
4678         PR gdb/23712
4679         PR symtab/23010
4680         * dictionary.c (pending_to_vector): Remove.
4681         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4682         Remove _1 suffix, replacing functions of the same name.  Update
4683         all callers.
4684         (dict_create_hashed, dict_create_hashed_expandable)
4685         (dict_create_linear, dict_create_linear_expandable, dict_free)
4686         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4687         Make functions static.
4688
4689 2019-01-10  Keith Seitz  <keiths@redhat.com>
4690
4691         PR gdb/23712
4692         PR symtab/23010
4693         * dictionary.h (struct dictionary): Replace declaration with
4694         multidictionary.
4695         (dict_create_hashed, dict_create_hashed_expandable)
4696         (dict_create_linear, dict_create_linear_expandable)
4697         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4698         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4699         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4700         taking multidictionary argument.
4701         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4702         * block.h (struct block) <dict>: Change to multidictionary
4703         and rename `multidict'.
4704         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4705         symmisc.c: Update all dictionary references to multidictionary.
4706
4707 2019-01-10  Keith Seitz  <keiths@redhat.com>
4708
4709         PR gdb/23712
4710         PR symtab/23010
4711         * dictionary.c: Include unordered_map.
4712         (pending_to_vector): New function.
4713         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4714         Rewrite the non-"_1" functions to take vector instead
4715         of linked list.
4716         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4717         "new" _1 versions of the same name.
4718         (multidictionary): Define.
4719         (std::hash<enum language): New definition.
4720         (collate_pending_symbols_by_language, mdict_create_hashed)
4721         (mdict_create_hashed_expandable, mdict_create_linear)
4722         (mdict_create_linear_expandable, mdict_free)
4723         (find_language_dictionary, create_new_language_dictionary)
4724         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4725         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4726         (mdict_size, mdict_empty): New functions.
4727         * dictionary.h (mdict_iterator): Define.
4728
4729 2019-01-10  Pedro Alves  <palves@redhat.com>
4730
4731         * breakpoint.c (read_uploaded_action)
4732         (create_tracepoint_from_upload): Adjust to use
4733         gdb::unique_xmalloc_ptr.
4734         * ctf.c (ctf_write_uploaded_tp):
4735         (SET_ARRAY_FIELD): Use emplace_back.
4736         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4737         * tracefile-tfile.c (tfile_write_uploaded_tp):
4738         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4739         gdb::unique_xmalloc_ptr.
4740         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4741         at_string, cond_string, cmd_strings>: Replace char pointers
4742         with gdb::unique_xmalloc_ptr.
4743
4744 2019-01-10  Pedro Alves  <palves@redhat.com>
4745
4746         * solib-target.c (library_list_start_library): Don't xstrdup name.
4747
4748 2019-01-10  Pedro Alves  <palves@redhat.com>
4749
4750         * mdebugread.c (parse_partial_symbols): Use
4751         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4752
4753 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * linux-fork.c (scoped_switch_fork_info)
4756         <~scoped_switch_fork_info>: Fix incorrect variable name.
4757
4758 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * linux-fork.c (scoped_switch_fork_info)
4761         <scoped_switch_fork_info>: Make explicit.
4762         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4763
4764 2019-01-10  Tom Tromey  <tom@tromey.com>
4765
4766         * objfiles.h (objfile::reset_psymtabs): Update.
4767         * objfiles.c (objfile::objfile): Update.
4768         * psymtab.h (psymtab_storage::obstack): Update.
4769         (psymtab_storage::m_obstack): Use gdb::optional.
4770         (class psymtab_storage): Update comment.  Remove objfile
4771         parameter.
4772         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4773
4774 2019-01-10  Tom Tromey  <tom@tromey.com>
4775
4776         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4777         <free_psymtabs>: Now private.
4778         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4779         (allocate_psymtab): Use new method.
4780
4781 2019-01-10  Tom Tromey  <tom@tromey.com>
4782
4783         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4784         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4785         * mdebugread.c (parse_partial_symbols): Use
4786         allocate_dependencies.
4787         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4788         allocate_dependencies.
4789         (process_psymtab_comp_unit_reader)
4790         (build_type_psymtab_dependencies): Likewise.
4791         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4792
4793 2019-01-10  Tom Tromey  <tom@tromey.com>
4794
4795         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4796         PSYMBOL_SET_LANGUAGE.
4797         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4798
4799 2019-01-10  Tom Tromey  <tom@tromey.com>
4800
4801         * psymtab.h (psymtab_storage::obstack): New method.
4802         <m_obstack>: Rename from obstack; now private.
4803         * psymtab.c (psymtab_storage): Update.
4804         * dwarf2read.c (create_addrmap_from_index)
4805         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4806         Update.
4807
4808 2019-01-10  Tom Tromey  <tom@tromey.com>
4809
4810         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4811         * objfiles.h (objfile::reset_psymtabs): New method.
4812
4813 2019-01-10  Tom Tromey  <tom@tromey.com>
4814
4815         * symmisc.c (print_symbol_bcache_statistics): Update.
4816         (print_objfile_statistics): Update.
4817         * symfile.c (reread_symbols): Update.
4818         * psymtab.h (class psymtab_storage): New.
4819         * psymtab.c (psymtab_storage): New constructor.
4820         (~psymtab_storage): New destructor.
4821         (require_partial_symbols): Update.
4822         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4823         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4824         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4825         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4826         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4827         (start_psymtab_common, end_psymtab_common)
4828         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4829         (allocate_psymtab): Update.
4830         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4831         Update.
4832         (dump_psymtab_addrmap, maintenance_print_psymbols)
4833         (maintenance_check_psymtabs): Update.
4834         (class objfile_psymtabs): Move to objfiles.h.
4835         * psympriv.h (discard_psymtab): Now inline.
4836         (psymtab_discarder::psymtab_discarder): Update.
4837         (psymtab_discarder::~psymtab_discarder): Update.
4838         (ALL_OBJFILE_PSYMTABS): Rewrite.
4839         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4840         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4841         Remove fields.
4842         <partial_symtabs>: New field.
4843         (class objfile_psymtabs): Move from psymtab.h.  Update.
4844         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4845         psymbol_cache.
4846         (objfile::~objfile): Don't destroy psymbol_cache.
4847         * mdebugread.c (parse_partial_symbols): Update.
4848         * dwarf2read.c (create_addrmap_from_index)
4849         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4850         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4851         (add_partial_subprogram, dwarf2_ranges_read): Update.
4852         * dwarf-index-write.c (write_address_map)
4853         (write_one_signatured_type, recursively_write_psymbols)
4854         (class debug_names, class debug_names, write_psymtabs_to_index):
4855         Update.
4856
4857 2019-01-10  Tom Tromey  <tom@tromey.com>
4858
4859         * symtab.h (SYMBOL_SET_NAMES): Update.
4860         (symbol_set_names): Update.
4861         (MSYMBOL_SET_NAMES): Update.
4862         * symtab.c (symbol_set_names): Change argument to be an
4863         objfile_per_bfd_storage.
4864         * psymtab.c (add_psymbol_to_bcache): Update.
4865         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4866
4867 2019-01-10  Tom Tromey  <tom@tromey.com>
4868
4869         * symtab.c (create_demangled_names_hash): Change argument to be an
4870         objfile_per_bfd_storage.
4871         (symbol_set_names): Update.
4872
4873 2019-01-10  Tom Tromey  <tom@tromey.com>
4874
4875         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4876         init_psymbol_list.
4877         * psymtab.c (init_psymbol_list): Do nothing if already called.
4878         * psympriv.h (init_psymbol_list): Add comment.
4879         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4880         init_psymbol_list.
4881         * dbxread.c (dbx_symfile_read): Unconditionally call
4882         init_psymbol_list.
4883
4884 2019-01-10  Tom Tromey  <tom@tromey.com>
4885
4886         * xcoffread.c (scan_xcoff_symtab): Update.
4887         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4888         "where".
4889         * mdebugread.c (parse_partial_symbols)
4890         (handle_psymbol_enumerators): Update.
4891         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4892         * dbxread.c (read_dbx_symtab): Update.
4893         * psympriv.h (psymbol_placement): New enum.
4894         (add_psymbol_to_list): Update.
4895
4896 2019-01-10  Tom Tromey  <tom@tromey.com>
4897
4898         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4899         static_psymbols parameters.
4900         (scan_xcoff_symtab): Update.
4901         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4902         static_psymbols parameters.
4903         * psympriv.h (start_psymtab_common): Update.
4904         * mdebugread.c (parse_partial_symbols): Update.
4905         * dwarf2read.c (create_partial_symtab): Update.
4906         * dbxread.c (read_dbx_symtab): Update.
4907         (start_psymtab): Remove global_psymbols and static_psymbols
4908         parameters.
4909
4910 2019-01-10  Tom Tromey  <tom@tromey.com>
4911
4912         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4913         * psymtab.c (allocate_psymtab): Add comment.
4914         * psympriv.h (allocate_psymtab): Add comment.
4915         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4916         initializations.
4917         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4918
4919 2019-01-10  Tom Tromey  <tom@tromey.com>
4920
4921         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4922         Don't declare.
4923         * mipsread.c: Include mdebugread.h.
4924         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4925         Declare.
4926         * elfread.c: Include mdebugread.h.
4927
4928 2019-01-09  Tom Tromey  <tom@tromey.com>
4929
4930         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4931         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4932         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4933         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4934         (psym_lookup_symbol, psym_find_last_source_symtab)
4935         (psym_forget_cached_source_info, psym_print_stats)
4936         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4937         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4938         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4939         (psym_find_compunit_symtab_by_address)
4940         (maintenance_print_psymbols, maintenance_info_psymtabs)
4941         (maintenance_check_psymtabs): Use ranged for.
4942         * psymtab.h (class objfile_psymtabs): New.
4943         (require_partial_symbols): Return objfile_psymtabs.
4944         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4945
4946 2019-01-09  Tom Tromey  <tom@tromey.com>
4947
4948         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4949         (find_pc_mapped_section, list_overlays_command)
4950         (map_overlay_command, unmap_overlay_command)
4951         (simple_overlay_update): Use all_objfiles.
4952         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4953         * printcmd.c (info_symbol_command): Use all_objfiles.
4954         * objfiles.h (ALL_OBJSECTIONS): Remove.
4955         * maint.c (maintenance_translate_address): Use all_objfiles.
4956         * gcore.c (gcore_create_callback): Use all_objfiles.
4957         (objfile_find_memory_regions): Likewise.
4958
4959 2019-01-09  Tom Tromey  <tom@tromey.com>
4960
4961         * symtab.c (find_line_symtab, info_sources_command)
4962         (make_source_files_completion_list): Use objfile_compunits.
4963         * source.c (select_source_symtab): Use objfile_compunits.
4964         * objfiles.h (struct objfile): Update comment.
4965         (ALL_OBJFILES): Remove.
4966         (ALL_FILETABS): Remove.
4967         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4968         objfile_compunits.
4969
4970 2019-01-09  Tom Tromey  <tom@tromey.com>
4971
4972         * symmisc.c (print_objfile_statistics, dump_objfile)
4973         (maintenance_print_symbols): Use compunit_filetabs.
4974         * source.c (forget_cached_source_info_for_objfile): Use
4975         compunit_filetabs.
4976         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4977         (ALL_FILETABS): Use compunit_filetabs.
4978         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4979         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4980
4981 2019-01-09  Tom Tromey  <tom@tromey.com>
4982
4983         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4984         (compunit_filetabs): New.
4985         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4986         compunit_filetabs.
4987         (info_sources_command, make_source_files_completion_list): Remove
4988         declaration.
4989         * symmisc.c (print_objfile_statistics, dump_objfile)
4990         (maintenance_print_symbols): Remove declaration.
4991         (maintenance_info_symtabs): Use compunit_filetabs.
4992         (maintenance_info_line_tables): Likewise.
4993         * source.c (select_source_symtab): Change local variable name.
4994         (forget_cached_source_info_for_objfile): Remove declaration.
4995         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4996         * objfiles.c (objfile_relocate1): Remove declaration.
4997         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4998         declaration.
4999         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5000         * coffread.c (coff_symtab_read): Remove declaration.
5001         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5002         compunit_filetabs.
5003
5004 2019-01-09  Tom Tromey  <tom@tromey.com>
5005
5006         * symtab.c (lookup_objfile_from_block)
5007         (find_pc_sect_compunit_symtab, search_symbols)
5008         (default_collect_symbol_completion_matches_break_on): Use
5009         objfile_compunits.
5010         * objfiles.h (ALL_COMPUNITS): Remove.
5011         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5012         * cp-support.c (add_symbol_overload_list_qualified): Use
5013         objfile_compunits.
5014         * ada-lang.c (ada_collect_symbol_completion_matches)
5015         (ada_add_global_exceptions): Use objfile_compunits.
5016
5017 2019-01-09  Tom Tromey  <tom@tromey.com>
5018
5019         * source.c (select_source_symtab)
5020         (forget_cached_source_info_for_objfile): Remove declaration.
5021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5022         declaration.
5023         * maint.c (count_symtabs_and_blocks): Remove declaration.
5024         * cp-support.c (add_symbol_overload_list_qualified): Remove
5025         declaration.
5026         * coffread.c (coff_symtab_read): Remove declaration.
5027         * symtab.c (lookup_symbol_in_objfile_symtabs)
5028         (basic_lookup_transparent_type_1): Use objfile_compunits.
5029         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5030         (info_sources_command, search_symbols)
5031         (default_collect_symbol_completion_matches_break_on)
5032         (make_source_files_completion_list): Remove declaration.
5033         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5034         (ada_collect_symbol_completion_matches)
5035         (ada_add_global_exceptions): Remove declaration.
5036         * linespec.c (iterate_over_all_matching_symtabs): Use
5037         objfile_compunits.
5038         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5039         (class objfile_compunits): New.
5040         (ALL_COMPUNITS): Use objfile_compunits.
5041         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5042         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5043         objfile_compunits.
5044         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5045
5046 2019-01-09  Tom Tromey  <tom@tromey.com>
5047
5048         * symtab.c (search_symbols)
5049         (default_collect_symbol_completion_matches_break_on): Use
5050         objfile_msymbols.
5051         * ada-lang.c (ada_lookup_simple_minsym)
5052         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5053         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5054         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5055         objfile_msymbols.
5056         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5057         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5058         * objc-lang.c (find_methods): Use objfile_msymbols.
5059         (info_selectors_command, info_classes_command): Likewise.
5060         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5061         * objfiles.h (class objfile_msymbols): New.
5062         (ALL_OBJFILE_MSYMBOLS): Remove.
5063         (ALL_MSYMBOLS): Remove.
5064
5065 2019-01-09  Tom Tromey  <tom@tromey.com>
5066
5067         * common/next-iterator.h (next_adapter): Add Iterator template
5068         parameter.
5069         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5070         (class all_objfiles_safe): New.
5071         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5072         * objfiles.c (put_objfile_before): Update comment.
5073         (add_separate_debug_objfile): Likewise.
5074         (free_all_objfiles): Use all_objfiles_safe.
5075         (objfile_purge_solibs): Likewise.
5076
5077 2019-01-09  Tom Tromey  <tom@tromey.com>
5078
5079         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5080         (expand_symtab_containing_pc, lookup_static_symbol)
5081         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5082         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5083         all_objfiles.
5084         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5085         * breakpoint.c (create_overlay_event_breakpoint)
5086         (create_longjmp_master_breakpoint)
5087         (create_std_terminate_master_breakpoint)
5088         (create_exception_master_breakpoint): Use all_objfiles.
5089         * linux-thread-db.c (try_thread_db_load_from_pdir)
5090         (has_libpthread): Use all_objfiles.
5091         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5092         * linespec.c (iterate_over_all_matching_symtabs)
5093         (search_minsyms_for_name): Use all_objfiles.
5094         * maint.c (maintenance_info_sections): Use all_objfiles.
5095         * main.c (captured_main_1): Use all_objfiles.
5096         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5097         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5098         * guile/scm-pretty-print.c
5099         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5100         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5101         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5102         (maintenance_print_msymbols): Use all_objfiles.
5103         * source.c (select_source_symtab): Use all_objfiles.
5104         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5105         * symfile.c (remove_symbol_file_command)
5106         (expand_symtabs_matching, map_symbol_filenames): Use
5107         all_objfiles.
5108         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5109         all_objfiles.
5110         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5111         * objc-lang.c (find_methods): Use all_objfiles.
5112         * objfiles.c (have_partial_symbols, have_full_symbols)
5113         (have_minimal_symbols, qsort_cmp)
5114         (default_iterate_over_objfiles_in_search_order): Use
5115         all_objfiles.
5116         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5117         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5118         (maintenance_check_psymtabs): Use all_objfiles.
5119         (ALL_PSYMTABS): Remove.
5120         * compile/compile-object-run.c (do_module_cleanup): Use
5121         all_objfiles.
5122         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5123         * cp-support.c (add_symbol_overload_list_qualified): Use
5124         all_objfiles.
5125         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5126         Use all_objfiles.
5127         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5128         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5129         all_objfiles.
5130         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5131         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5132         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5133         Uses all_objfiles.
5134         * solib.c (solib_read_symbols): Use all_objfiles
5135
5136 2019-01-09  Tom Tromey  <tom@tromey.com>
5137
5138         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5139         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5140         all_objfiles.
5141         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5142         * symmisc.c (print_symbol_bcache_statistics)
5143         (print_objfile_statistics, maintenance_print_objfiles)
5144         (maintenance_info_symtabs, maintenance_check_symtabs)
5145         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5146         all_objfiles.
5147         * source.c (forget_cached_source_info): Use all_objfiles.
5148         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5149         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5150         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5151         * objfiles.c (update_section_map): Use all_objfiles.
5152         (shared_objfile_contains_address_p): Likewise.
5153         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5154         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5155
5156 2019-01-09  Tom Tromey  <tom@tromey.com>
5157
5158         * common/next-iterator.h: New file.
5159         * objfiles.h (class all_objfiles): New.
5160         (struct objfile_iterator): New.
5161
5162 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5163
5164         * NEWS: Move the description of the changed "frame", "select-frame",
5165          and "info frame" commands to the Changed commands section.
5166
5167 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5168
5169         * gdbtypes.c (check_stub_method_group): Remove handling of old
5170         mangling schemes.
5171         * linespec.c (find_methods): Likewise.
5172         * stabsread.c (read_member_functions): Likewise.
5173         * valops.c (search_struct_method): Likewise.
5174         (value_struct_elt_for_reference): Likewise.
5175         * NEWS: Mention this change.
5176
5177 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5180         print_source_lines.
5181         * source.c (print_source_lines_base): Update line number check.
5182         (print_source_lines): New function.
5183         (source_lines_range::source_lines_range): New function.
5184         * source.h (class source_lines_range): New class.
5185         (print_source_lines): New declaration.
5186
5187 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5188
5189         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5190
5191 2019-01-08  Tom Tromey  <tom@tromey.com>
5192             Simon Marchi  <simon.marchi@ericsson.com>
5193
5194         PR gdb/24060
5195         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5196         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5197         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5198         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5199         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5200         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5201
5202 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5203
5204         * source.c (select_source_symtab): Move header comment to
5205         declaration in source.h.
5206         (forget_cached_source_info_for_objfile): Likewise.
5207         (forget_cached_source_info): Likewise.
5208         (identify_source_line): Likewise.
5209         * source.h (identify_source_line): Move declaration from symtab.h
5210         and add comment from source.c
5211         (print_source_lines): Likewise.
5212         (forget_cached_source_info_for_objfile): Likewise.
5213         (forget_cached_source_info): Likewise.
5214         (select_source_symtab): Likewise.
5215         (enum print_source_lines_flag): Move definition from symtab.h.
5216         * symtab.h (identify_source_line): Move declaration to source.h.
5217         (print_source_lines): Likewise.
5218         (forget_cached_source_info_for_objfile): Likewise.
5219         (forget_cached_source_info): Likewise.
5220         (select_source_symtab): Likewise.
5221         (enum print_source_lines_flag): Move definition to source.h.
5222         * tui/tui-hooks.c: Add 'source.h' include.
5223
5224 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5225
5226         * source.c (print_source_lines_base): Handle requests to print
5227         reverse line number sequences, and guard against empty lines
5228         string.
5229
5230 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * source.c (print_source_lines_base): Fix skip of '\r' if next
5233         character is '\n'.
5234
5235 2019-01-06  Tom Tromey  <tom@tromey.com>
5236
5237         * c-exp.y (struct c_parse_state) <macro_original_text,
5238         expansion_obstack>: New member.
5239         (macro_original_text, expansion_obstack): Remove globals.
5240         (scan_macro_expansion, scanning_macro_expansion)
5241         (finished_macro_expansion): Update.
5242         (scan_macro_cleanup): Remove.
5243         (yylex, c_parse): Update.
5244
5245 2019-01-06  Tom Tromey  <tom@tromey.com>
5246
5247         * c-exp.y (struct c_parse_state) <strings>: New member.
5248         (operator_stoken): Update.
5249
5250 2019-01-06  Tom Tromey  <tom@tromey.com>
5251
5252         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5253         (union type_stack_elt) <typelist_val>: Now a pointer to
5254         std::vector.
5255         (type_stack_cleanup): Don't declare.
5256         (push_typelist): Update.
5257         * parse.c (pop_typelist): Return a std::vector.
5258         (push_typelist): Take a std::vector.
5259         (follow_types): Update.  Do not free args.
5260         (type_stack_cleanup): Remove.
5261         * c-exp.y (struct c_parse_state): New.
5262         (cpstate): New global.
5263         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5264         (nonempty_typelist): Update.
5265         (func_mod): Create a new vector.
5266         (c_parse): Create a c_parse_state.
5267         (check_parameter_typelist): Do not delete params.
5268         (function_method): Update.  Do not delete type_list.
5269
5270 2019-01-06  Tom Tromey  <tom@tromey.com>
5271
5272         PR gdb/28155:
5273         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5274         check_typedef.
5275         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5276         (print_return_value): Likewise.
5277
5278 2019-01-05  Tom Tromey  <tom@tromey.com>
5279
5280         * contrib/cleanup_check.py: Remove.
5281         * contrib/gcc-with-excheck: Remove.
5282         * contrib/exsummary.py: Remove.
5283         * contrib/excheck.py: Remove.
5284
5285 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5286
5287         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5288         NULL. Initialize tpprev to NULL instead of assigning it
5289         to NULL on the next statement.
5290         * windows-nat.c (windows_delete_thread): Remove check for
5291         main_thread_id before printing thread exit notifications.
5292         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5293         Remove thread ID check against main_thread_id.
5294         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5295         windows_delete_thread.
5296         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5297
5298 2019-01-04  Tom Tromey  <tom@tromey.com>
5299
5300         * compile/compile.c (_initialize_compile): Use upper case for
5301         metasyntactic variables.
5302         * symmisc.c (_initialize_symmisc): Use upper case for
5303         metasyntactic variables.
5304         * psymtab.c (_initialize_psymtab): Use upper case for
5305         metasyntactic variables.
5306         * demangle.c (demangle_command): Use upper case for metasyntactic
5307         variables.
5308         (_initialize_demangler): Likewise.
5309         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5310         variables.
5311
5312 2019-01-03  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5315
5316 2019-01-03  Tom Tromey  <tom@tromey.com>
5317
5318         * python/py-symtab.c (salpy_str): Update.
5319         (struct salpy_sal_object) <symtab>: Now a PyObject.
5320         (salpy_dealloc): Update.
5321         (del_objfile_sal): Use gdbpy_ref.
5322
5323 2019-01-03  Tom Tromey  <tom@tromey.com>
5324
5325         * python/py-type.c (convert_field): Use new_reference.  Return
5326         gdbpy_ref.
5327         (make_fielditem): Return gdbpy_ref.
5328         (typy_fields): Update.
5329         (typy_getitem): Update.
5330         (field_name): Return gdbpy_ref.  Use new_reference.
5331         (typy_iterator_iternext): Update.
5332
5333 2019-01-03  Tom Tromey  <tom@tromey.com>
5334
5335         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5336
5337 2019-01-03  Tom Tromey  <tom@tromey.com>
5338
5339         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5340         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5341         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5342         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5343         (pspy_set_type_printers): Likewise.
5344         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5345         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5346         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5347         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5348         (objfpy_set_type_printers): Likewise.
5349
5350 2019-01-03  Tom Tromey  <tom@tromey.com>
5351
5352         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5353         (gdbpy_print_stack): Use gdbpy_err_fetch.
5354         * python/python-internal.h (class gdbpy_err_fetch): New class.
5355         (class gdbpy_enter) <m_error_type, m_error_value,
5356         m_error_traceback>: Remove.
5357         <m_error>: New member.
5358         (gdbpy_exception_to_string): Don't declare.
5359         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5360         * python/py-value.c (convert_value_from_python): Use
5361         gdbpy_err_fetch.
5362         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5363         gdbpy_exception_to_string.
5364         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5365         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5366         gdbpy_err_fetch.
5367
5368 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * linux-nat.c (delete_lwp_cleanup): Delete.
5371         (struct lwp_deleter): New struct.
5372         (lwp_info_up): New typedef.
5373         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5374         lwp_info_up.
5375
5376 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5377
5378         * linux-fork.c (class scoped_switch_fork_info): New class.
5379         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5380
5381 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         * valops.c (find_overload_match): Remove use of null_cleanup, and
5384         calls to do_cleanups.
5385
5386 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * compile/compile-cplus-types.c
5389         (compile_cplus_instance::decl_name): Handle changes to
5390         cp_func_name.
5391         * cp-support.c (cp_func_name): Update header comment, update
5392         return type.
5393         * cp-support.h (cp_func_name): Update return type in declaration.
5394         * valops.c (find_overload_match): Move temp_func local to top
5395         level of function and change its type.  Use temp_func to hold and
5396         delete temporary string obtained from cp_func_name.
5397
5398 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5401         gdb::char_vector, remove cleanup, and update uses of `msg`.
5402
5403 2019-01-03  Jim Wilson  <jimw@sifive.com>
5404
5405         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5406
5407 2019-01-02  Tom Tromey  <tom@tromey.com>
5408
5409         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5410         (tdesc_parse_xml): Remove cleanups.
5411         * target-descriptions.h (make_cleanup_free_target_description):
5412         Don't declare.
5413         (target_desc_deleter): New struct.
5414         (target_desc_up): New typedef.
5415         * target-descriptions.c (target_desc_deleter::operator()): Rename
5416         from free_target_description.
5417         (make_cleanup_free_target_description): Remove.
5418
5419 2019-01-02  Tom Tromey  <tom@tromey.com>
5420
5421         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5422         constructor, destructor.
5423         (linespec_parser): Remove typedef.
5424         (~linespec_parser): Rename from linespec_parser_delete.
5425         (linespec_lex_to_end, linespec_complete_label)
5426         (linespec_complete): Update.
5427         (decode_line_full): Remove cleanups.
5428         (decode_line_1): Update.
5429
5430 2019-01-02  Tom Tromey  <tom@tromey.com>
5431
5432         * python/python-internal.h (inferior_to_inferior_object): Change
5433         return type.
5434         * python/py-exitedevent.c (create_exited_event_object): Update.
5435         * python/py-inferior.c (inferior_to_inferior_object): Return
5436         gdbpy_ref.
5437         (python_new_inferior, python_inferior_deleted)
5438         (thread_to_thread_object, delete_thread_object)
5439         (build_inferior_list, gdbpy_selected_inferior): Update.
5440         * python/py-infthread.c (create_thread_object): Update.  Also fail
5441         if inferior_to_inferior_object fails.
5442
5443 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5444
5445         * inferior.h (class inferior) <displaced_step_state>: New field.
5446         * infrun.h (struct displaced_step_state): Move here from
5447         infrun.c.  Initialize fields, add constructor.
5448         <inf>: Remove field.
5449         <reset>: New method.
5450         * infrun.c (struct displaced_step_inferior_state): Move to
5451         infrun.h.
5452         (displaced_step_inferior_states): Remove.
5453         (get_displaced_stepping_state): Adust.
5454         (displaced_step_in_progress_any_inferior): Adjust.
5455         (displaced_step_in_progress_thread): Adjust.
5456         (displaced_step_in_progress): Adjust.
5457         (add_displaced_stepping_state): Remove.
5458         (get_displaced_step_closure_by_addr): Adjust.
5459         (remove_displaced_stepping_state): Remove.
5460         (infrun_inferior_exit): Call displaced_step_state.reset.
5461         (use_displaced_stepping): Don't check for NULL.
5462         (displaced_step_prepare_throw): Call
5463         get_displaced_stepping_state.
5464         (displaced_step_fixup): Don't check for NULL.
5465         (prepare_for_detach): Don't check for NULL.
5466
5467 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5468
5469         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5470          in case of call that did not complete.
5471
5472 2019-01-02  Andrey Utkin  <autkin@undo.io>
5473
5474         * symfile.c (find_separate_debug_file): Fix search of debug files for
5475         remote debuggee.
5476
5477 2019-01-02  Tom Tromey  <tom@tromey.com>
5478
5479         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5480         indentation.
5481         * python/py-frame.c (frapy_older): Remove cast.
5482         (frapy_newer): Likewise.
5483         * python/py-breakpoint.c (local_setattro): Remove cast.
5484         * python/py-arch.c (archpy_name): Remove local variable.
5485         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5486
5487 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5488
5489         * unittests/basic_string_view/element_access/char/empty.cc:
5490         Fix year range in copyright header.
5491
5492 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5493
5494         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5495         Delete.
5496         <operator==>: Update with for removed field.
5497         <hash>: Likewise.
5498         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5499         <isa_features>: ...this.
5500         <abi_features>: New field.
5501         (riscv_isa_flen): Update comment.
5502         (riscv_abi_xlen): New declaration.
5503         (riscv_abi_flen): New declaration.
5504         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5505         isa_features.
5506         (riscv_abi_xlen): New function.
5507         (riscv_isa_flen): Update to get answer from isa_features.
5508         (riscv_abi_flen): New function.
5509         (riscv_has_fp_abi): Update to get answer from abi_features.
5510         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5511         xlen and flen.
5512         (riscv_call_info) <xlen, flen>: Update comment.
5513         (riscv_call_arg_struct): Remove invalid assertions
5514         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5515         is removed.
5516         (riscv_gdbarch_init): Gather isa features and abi features
5517         separately, ensure both match on the gdbarch when reusing an old
5518         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5519         a target with 64-bit float hardware.
5520
5521 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5522
5523         * source.c (search_command_helper): Stop reverse search
5524         when line 1 has been searched.
5525
5526 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5527
5528         * record-full.c (record_full_base_target::close): Rewrite
5529         record_full_core_buf_list free logic.
5530
5531 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5532
5533         * break-catch-syscall.c (print_one_catch_syscall): xfree
5534         the last text.
5535
5536 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5537
5538         * top.c (print_gdb_version): Update Copyright year in version
5539         message.
5540
5541 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5542
5543         Update copyright year range in all GDB files.
5544
5545 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5546
5547         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5548
5549 For older changes see ChangeLog-2018.
5550 \f
5551 Local Variables:
5552 mode: change-log
5553 left-margin: 8
5554 fill-column: 74
5555 version-control: never
5556 coding: utf-8
5557 End:
5558