gdb/ChangeLog

   1 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * arch/aarch32.c (aarch32_create_target_description): Create
   4         target descriptions using features.
   5         * arch/arm.c (arm_create_target_description)
   6         (arm_create_mprofile_target_description): Likewise.
   7         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
   8
   9 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  10
  11         * Makefile.in: Add new files.
  12         * aarch32-tdep.c: New file.
  13         * aarch32-tdep.h: New file.
  14         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  15         Call aarch32_read_description.
  16         * arch/aarch32.c: New file.
  17         * arch/aarch32.h: New file.
  18         * arch/arm.c (arm_create_target_description)
  19         (arm_create_mprofile_target_description): New function.
  20         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  21         (arm_create_target_description)
  22         (arm_create_mprofile_target_description): New declaration.
  23         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  24         read_description functions.
  25         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  26         Likewise.
  27         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  28         * arm-tdep.c (tdesc_arm_list): New variable.
  29         (arm_register_g_packet_guesses): Call create description functions.
  30         (arm_read_description) (arm_read_mprofile_description): New
  31         function.
  32         * arm-tdep.h (arm_read_description)
  33         (arm_read_mprofile_description): Add declaration.
  34         * configure.tgt: Add new files.
  35
  36 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  37
  38         * top.c (new_ui_command): Open specified terminal just once.
  39
  40 2019-07-18  Tom Tromey  <tromey@adacore.com>
  41
  42         * symtab.c (main_name): Constify return type.
  43         * symfile.c (set_initial_language): Update.
  44         * symtab.h (main_name): Constify return type.
  45
  46 2019-07-17  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-winsource.c (tui_update_source_window)
  49         (tui_update_source_window_as_is)
  50         (tui_update_source_windows_with_line): Remove return.
  51         * tui/tui-disasm.c (tui_show_disassem)
  52         (tui_show_disassem_and_update_source): Remove return.
  53         * tui/tui.c (tui_reset): Remove return.
  54         * tui/tui-wingeneral.c
  55         (tui_check_and_display_highlight_if_needed): Remove return.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  60
  61 2019-07-17  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-winsource.h (struct tui_exec_info_window)
  64         (struct tui_source_window_base): Move from tui-data.h.
  65         * tui/tui-winsource.c: Move many method definitions from
  66         elsewhere.  Remove "structuring" comments.
  67         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  68         (tui_source_window_base::refresh_window): Move to
  69         tui-winsource.c.
  70         * tui/tui-win.c (tui_source_window_base::refresh_all)
  71         (tui_source_window_base::update_tab_width)
  72         (tui_source_window_base::set_new_height)
  73         (tui_source_window_base::do_make_visible_with_new_height): Move to
  74         tui-winsource.c.
  75         * tui/tui-source.h: Update.
  76         * tui/tui-source.c (tui_source_window_base::reset): Move to
  77         tui-winsource.c.
  78         * tui/tui-disasm.h: Update.
  79         * tui/tui-data.h (struct tui_exec_info_window): Move to
  80         tui-winsource.h.
  81         (struct tui_source_window_base): Likewise.
  82         * tui/tui-data.c (tui_source_window_base::clear_detail)
  83         (tui_source_window_base, ~tui_source_window_base): Move to
  84         tui-winsource.c.
  85
  86 2019-07-17  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-win.c (tui_resize_all)
  89         (tui_source_window_base::update_tab_width)
  90         (tui_adjust_win_heights): Update.
  91         (tui_win_info::make_invisible_and_set_new_height): Rename from
  92         make_invisible_and_set_new_height.
  93         * tui/tui-data.h (struct tui_win_info)
  94         <make_invisible_and_set_new_height>: New method.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui.c: Update.
  99         * tui/tui-source.h (struct tui_source_window): Move from
 100         tui-data.h.
 101         * tui/tui-layout.c: Update.
 102         * tui/tui-disasm.c: Update.
 103         * tui/tui-data.h (struct tui_source_window): Move to
 104         tui-source.h.
 105
 106 2019-07-17  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 109         tui-data.h.
 110         * tui/tui-data.h (struct tui_disasm_window): Move to
 111         tui-disasm.h.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-regs.h (struct tui_data_item_window): Move from
 116         tui-data.h.
 117         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 118         * tui/tui-data.h (struct tui_data_item_window): Move to
 119         tui-regs.h.
 120         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 121
 122 2019-07-17  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui.c: Update.
 125         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 126         (tui_cmd_window::max_height): Move to tui-command.c.
 127         * tui/tui-layout.c: Update.
 128         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 129         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 130         tui-command.c.
 131         * tui/tui-command.h (struct tui_cmd_window): Move from
 132         tui-data.h.
 133         * tui/tui-command.c: Remove "structuring" comments.
 134         (tui_cmd_window::clear_detail)
 135         (tui_cmd_window::do_make_visible_with_new_height)
 136         (tui_cmd_window::max_height): Move from elsewhere.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 141         Now static.
 142         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 143         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui.c: Update.
 148         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 149         tui-regs.c.
 150         * tui/tui-windata.h: Remove file.
 151         * tui/tui-windata.c: Remove file.
 152         * tui/tui-win.c (tui_data_window::set_new_height)
 153         (tui_data_window::do_make_visible_with_new_height): Move to
 154         tui-regs.c.
 155         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 156         * tui/tui-regs.c: Remove "structuring" comments.
 157         (tui_data_window::first_data_item_displayed)
 158         (tui_data_window::delete_data_content_windows)
 159         (tui_data_window::erase_data_content)
 160         (tui_data_window::display_all_data)
 161         (tui_data_window::refresh_all)
 162         (tui_data_window::do_scroll_vertical)
 163         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 164         (tui_data_window::do_make_visible_with_new_height)
 165         (tui_data_window::refresh_window): Move from elsewhere.
 166         (_initialize_tui_regs): Move to end of file.
 167         * tui/tui-layout.c: Update.
 168         * tui/tui-hooks.c: Update.
 169         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 170         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 171         tui-regs.c.
 172         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 177         seen.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-win.c (tui_source_window_base::set_new_height)
 182         (tui_source_window_base::do_make_visible_with_new_height): Use
 183         m_has_locator field directly.
 184         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 185         method.
 186         (struct tui_source_window_base) <has_locator>: Likewise.
 187
 188 2019-07-17  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 191         Don't declare.
 192         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 193         Remove.
 194         * tui/tui-win.c (tui_source_window_base::set_new_height)
 195         (tui_source_window_base::set_new_height)
 196         (make_invisible_and_set_new_height)
 197         (tui_source_window_base::do_make_visible_with_new_height)
 198         (tui_source_window_base::do_make_visible_with_new_height):
 199         Update.
 200         * tui/tui-layout.c (show_source_disasm_command, show_data)
 201         (show_source_or_disasm_and_command): Update.
 202         * tui/tui-layout.c (show_layout): Update.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-layout.c (make_data_window): Remove.
 207         (show_data): Unify creation and re-initialization cases.
 208
 209 2019-07-17  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-layout.c (make_source_window, make_disasm_window):
 212         Remove.
 213         (show_data): Unify creation and re-initialization cases.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-layout.c (make_command_window): Remove.
 218         (show_source_disasm_command, show_source_or_disasm_and_command):
 219         Unify creation and re-initialization cases.
 220
 221 2019-07-17  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 224         creation and re-initialization cases.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-regs.c (tui_get_register): Return void.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 233         Simplify.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 238         resetting.
 239
 240 2019-07-17  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 243         * tui/tui-regs.c (tui_reg_layout): New function.
 244         (tui_show_registers, tui_reg_command): Use it.
 245         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 246         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 247         parameters.
 248         (tui_layout_command): Remove.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-layout.h (tui/tui-layout): Return void.
 253         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-layout.c (show_source_disasm_command, show_data):
 258         Update.
 259         (reset_locator): Remove.
 260         (show_source_or_disasm_and_command): Update.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-source.c (tui_source_window_base::reset): Remove
 265         win_type parameter.
 266         * tui/tui-layout.c (make_command_window, make_source_window)
 267         (make_disasm_window, make_data_window)
 268         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 269         (reset_locator, show_source_or_disasm_and_command): Update.
 270         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 271         win_type parameter.
 272         (struct tui_source_window_base) <reset>: Likewise.
 273
 274 2019-07-17  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-layout.c (show_source_disasm_command): Use
 277         reset_locator.
 278         (reset_locator): New function.
 279         (init_and_make_win): Remove.
 280         (show_source_or_disasm_and_command): Use reset_locator.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 285         condition.
 286         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 287         Remove condition.
 288         * tui/tui-source.c (tui_source_window_base::reset): New method.
 289         * tui/tui-layout.c (make_command_window): Don't call
 290         init_and_make_win.
 291         (make_source_window, make_disasm_window): Don't call
 292         make_source_or_disasm_window.
 293         (make_data_window): Don't call init_and_make_win.  Change calling
 294         convention.
 295         (show_source_disasm_command, show_data): Simplify.
 296         (make_source_or_disasm_window): Remove.
 297         (show_source_or_disasm_and_command): Simplify.
 298         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 299         (struct tui_source_window_base) <reset>: Likewise.
 300         <execution_info>: Remove initializer.
 301         * tui/tui-data.c (tui_source_window_base): Initialize
 302         execution_info.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 307         variable.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui.c (tui_rl_other_window): Update.
 312         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 313         superclass method first.  Always iterate over regs_content.
 314         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 315         method.
 316         * tui/tui-win.c (tui_set_focus_command): Update.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-win.c (tui_set_focus_command): Rename from
 321         tui_set_focus.  Call tui_enable.
 322         (tui_set_focus_command): Remove.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 327         refresh_window.
 328         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 329         touchwin.
 330         (tui_data_window::refresh_window): Call refresh_window on data
 331         items.  Always call superclass refresh_window.
 332         (tui_win_info::refresh): Remove.
 333         (tui_source_window_base::refresh_window): Update.
 334         (tui_refresh_all): Update.
 335         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 336         refresh_window.
 337         (show_source_or_disasm_and_command): Likewise.
 338         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 339         (struct tui_source_window_base) <refresh>: Likewise.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-winsource.c (tui_clear_source_content)
 344         (tui_show_source_content): Update.
 345         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 346         whether content is empty.
 347         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 348         Remove.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 353         window's contents.
 354         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 355         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 356
 357 2019-07-17  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 360         (struct tui_data_item_window): Update.
 361
 362 2019-07-17  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 365         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 366         defines.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.h (tui_erase_source_content)
 371         (tui_clear_source_content): Remove "display_prompt" parameter.
 372         * tui/tui-winsource.c (tui_update_source_window_as_is)
 373         (tui_update_source_windows_with_addr): Update.
 374         (tui_clear_source_content): Remove "display_prompt" parameter.
 375         (tui_erase_source_content): Likewise.  Simplify.
 376         (tui_show_source_content): Update.
 377         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 378         * tui/tui-stack.c (tui_show_frame_info): Update.
 379         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 380         Remove defines.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 385         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 386         parameter.
 387         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 388         parameter.
 389
 390 2019-07-17  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-winsource.c (tui_clear_source_content)
 393         (tui_show_source_content, tui_show_exec_info_content)
 394         (tui_clear_exec_info_content): Update.
 395         * tui/tui-stack.c (tui_show_locator_content): Update.
 396         (tui_show_frame_info): Update.
 397         * tui/tui-source.h (tui_source_window): Don't declare.
 398         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 399         from tui_source_is_displayed.
 400         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 401         Remove field.
 402         (struct tui_source_window_base) <content_in_use>: New field.  Now
 403         bool.
 404         (struct tui_source_window) <showing_source_p>: New method.
 405         (TUI_SRC_WIN): Change cast.
 406         * tui/tui-data.c (tui_initialize_static_data): Update.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 411         location_matches_p.
 412         * tui/tui-source.c (tui_source_window::location_matches_p): New
 413         method.
 414         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 415         method.
 416         * tui/tui-data.h (struct tui_source_window_base)
 417         <location_matches_p>: New method.
 418         (struct tui_source_window, struct tui_disasm_window)
 419         <location_matches_p>: Likewise.
 420
 421 2019-07-17  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-win.c (tui_set_win_height_command): Rename from
 424         tui_set_win_height.
 425         (tui_set_win_height_command): Remove.
 426
 427 2019-07-17  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-source.c (tui_source_window): New constructor.  Add
 430         observer.
 431         (~tui_source_window): New destructor.
 432         (tui_source_window::style_changed): New method.
 433         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 434         (tui_attach_detach_observers): Update.
 435         * tui/tui-data.h (struct tui_source_window): Make constructor not
 436         inline.  Add destructor.
 437         (struct tui_source_window) <style_changed>: New method.
 438         <m_observable>: New member.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 443         * tui/tui-win.c (tui_resize_all): Fix typo.
 444
 445 2019-07-17  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 448         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 449         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 450         * tui/tui-win.c (window_name_completer): Use foreach.
 451         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 452         (update_tab_width): Likewise.
 453         * tui/tui-layout.c (show_layout): Update.
 454         * tui/tui-data.h (class tui_window_iterator): New.
 455         (struct all_tui_windows): New.
 456         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 461         parameter.  Don't reference globals.
 462         (tui_reg_command): Update.
 463
 464 2019-07-17  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-regs.c (tui_show_registers): Simplify.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-regs.c (tui_show_registers): Update.
 471         (tui_show_register_group): Add win_info parameter.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 476         Rename from tui_display_reg_element_at_line.
 477         (tui_data_window::display_registers_from_line): Update.
 478         * tui/tui-data.h (struct tui_data_window)
 479         <display_reg_element_at_line>: New method.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-regs.h (tui_display_registers_from)
 484         (tui_display_registers_from_line): Don't declare.
 485         * tui/tui-windata.c (tui_data_window::display_all_data)
 486         (tui_data_window::refresh_all)
 487         (tui_data_window::do_scroll_vertical): Update.
 488         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 489         from tui_display_registers_from.
 490         (tui_display_reg_element_at_line): Update.
 491         (tui_data_window::display_registers_from_line): Rename from
 492         tui_display_registers_from_line.
 493         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 494         display_registers_from_line>: New methods.
 495
 496 2019-07-17  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 499         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 500         from tui_erase_data_content.
 501         (tui_data_window::display_all_data)
 502         (tui_data_window::refresh_all)
 503         (tui_data_window::do_scroll_vertical): Update.
 504         * tui/tui-regs.c (tui_show_registers): Update.
 505         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 506         New method.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 511         declare.
 512         * tui/tui-windata.c
 513         (tui_data_window::delete_data_content_windows): Rename from
 514         tui_delete_data_content_windows.
 515         (tui_data_window::display_all_data)
 516         (tui_data_window::do_scroll_vertical): Update.
 517         * tui/tui-data.h (struct tui_data_window)
 518         <delete_data_content_windows>: New method.
 519
 520 2019-07-17  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 523         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 524
 525 2019-07-17  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 528         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 529         from tui_display_all_data.
 530         * tui/tui-win.c
 531         (tui_data_window::do_make_visible_with_new_height): Update.
 532         * tui/tui-regs.c (tui_show_registers): Update.
 533         * tui/tui-layout.c (tui_set_layout): Update.
 534         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 535         method.
 536
 537 2019-07-17  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 540         * tui/tui-windata.c (tui_display_data_from): Remove.
 541         (tui_data_window::refresh_all): Update.
 542
 543 2019-07-17  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 546         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 547         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 548         tui_display_registers_from_line.
 549         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 550         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 551         "force_display" parameter.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 556         declare.
 557         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 558         Rename from tui_first_reg_element_no_inline.
 559         (tui_display_reg_element_at_line)
 560         (tui_display_registers_from_line): Update.
 561         * tui/tui-data.h (struct tui_data_window)
 562         <first_reg_element_no_inline>: New method.
 563
 564 2019-07-17  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-windata.c (tui_display_data_from)
 567         (tui_data_window::do_scroll_vertical): Update.
 568         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 569         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 570         Rename from tui_line_from_reg_element_no.
 571         (tui_display_registers_from_line): Update.
 572         * tui/tui-data.h (struct tui_data_window)
 573         <line_from_reg_element_no>: New method.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 578         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 579         tui_last_regs_line_no.
 580         (tui_display_reg_element_at_line)
 581         (tui_display_registers_from_line): Update.
 582         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 583         method.
 584
 585 2019-07-17  Tom Tromey  <tom@tromey.com>
 586
 587         PR tui/24722:
 588         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 589         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 590         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 591         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 592         (tui_update_breakpoint_info): Likewise.
 593         * tui/tui-hooks.c (tui_event_create_breakpoint)
 594         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 595         Update.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 600
 601 2019-07-17  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-winsource.c (tui_update_source_window_as_is)
 604         (tui_update_source_windows_with_addr): Update.
 605         * tui/tui-source.h (tui_set_source_content)
 606         (tui_show_symtab_source): Add "win_info" parameter.
 607         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 608         parameter.
 609         (tui_show_symtab_source): Likewise.
 610
 611 2019-07-17  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-wingeneral.c
 614         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 619         (struct tui_cmd_window) <can_scroll>: New method.
 620         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 621         method.
 622
 623 2019-07-17  Tom Tromey  <tromey@adacore.com>
 624
 625         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 626         do_field_signed>: Rename.  Change type of "value".
 627         * ui-out.c (ui_out::field_signed): Rename from field_int.
 628         Change type of "value".
 629         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 630         type of "value".
 631         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 632         do_field_int.  Change type of "value".
 633         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 634         do_field_int.  Change type of "value".
 635         * tracepoint.c (trace_status_mi, tfind_1)
 636         (print_one_static_tracepoint_marker): Update.
 637         * thread.c (print_thread_info_1, print_selected_thread_frame):
 638         Update.
 639         * stack.c (print_frame, print_frame_info): Update.
 640         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 641         Update.
 642         * source.c (print_source_lines_base): Update.
 643         * skip.c (info_skip_command): Update.
 644         * record-btrace.c (btrace_ui_out_decode_error)
 645         (btrace_call_history_src_line): Update.
 646         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 647         Update.
 648         * progspace.c (print_program_space): Update.
 649         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 650         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 651         do_field_int.  Change type of "value".
 652         * mi/mi-out.c (mi_ui_out::do_table_begin)
 653         (mi_ui_out::do_table_header): Update.
 654         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 655         type of "value".
 656         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 657         (mi_cmd_data_list_changed_registers, output_register)
 658         (mi_cmd_data_read_memory, mi_load_progress)
 659         (mi_cmd_trace_frame_collected): Update.
 660         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 661         Update.
 662         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 663         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 664         (mi_cmd_var_list_children, varobj_update_one): Update.
 665         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 666         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 667         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 668         * inferior.c (print_inferior): Update.
 669         * gdb_bfd.c (print_one_bfd): Update.
 670         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 671         Update.
 672         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 673         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 674         do_field_int.  Change type of "value".
 675         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 676         do_field_int.  Change type of "value".
 677         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 678         (print_one_breakpoint_location, print_it_catch_fork)
 679         (print_one_catch_fork, print_it_catch_vfork)
 680         (print_one_catch_vfork, print_it_catch_solib)
 681         (print_it_catch_exec, print_it_ranged_breakpoint)
 682         (print_mention_watchpoint, print_mention_masked_watchpoint)
 683         (bkpt_print_it, update_static_tracepoint): Update.
 684         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 685         * break-catch-syscall.c (print_it_catch_syscall): Update.
 686         * ada-tasks.c (print_ada_task_info): Update.
 687         * ada-lang.c (print_it_exception, print_mention_exception):
 688         Update.
 689
 690 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         PR breakpoints/24541
 693         * gdbarch.c: Regenerate.
 694         * gdbarch.h: Regenerate.
 695         * gdbarch.sh: Adjust return type and parameter types for
 696         'stap_adjust_register'.
 697         (i386_stap_adjust_register): Adjust signature and return new
 698         register name.
 699         * stap-probe.c (stap_parse_register_operand): Adjust use of
 700         'gdbarch_stap_adjust_register'.
 701
 702 2019-07-17  Tom Tromey  <tromey@adacore.com>
 703
 704         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 705         declare VEC.
 706         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 707         std::vector.
 708         (struct s390_process_info): Add initializers.
 709         (s390_add_process): Use new.
 710         (s390_linux_nat_target::low_forget_process): Use delete.
 711         (s390_linux_nat_target::low_new_fork)
 712         (s390_linux_nat_target::stopped_by_watchpoint)
 713         (s390_linux_nat_target::low_prepare_to_resume)
 714         (s390_linux_nat_target::insert_watchpoint)
 715         (s390_linux_nat_target::insert_hw_breakpoint)
 716         (s390_linux_nat_target::remove_watchpoint)
 717         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 718
 719 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 720
 721         * aarch64-fbsd-nat.c: Include regcache.h.
 722         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 723         argument.
 724         (aarch64_fbsd_nat_target::fetch_registers)
 725         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 726         variable.
 727         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 728
 729 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 730
 731         * fbsd-nat.c: Include gdbarch.h.
 732
 733 2019-07-15  Tom Tromey  <tromey@adacore.com>
 734
 735         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 736
 737 2019-07-15  Tom Tromey  <tromey@adacore.com>
 738
 739         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 740         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 741         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 742         * cli-out.c (cli_ui_out::do_field_int): New method.
 743         * ui-out.c (ui_out::field_unsigned): New method.
 744         * symfile.c (generic_load): Use field_unsigned.
 745         (print_transfer_performance): Likewise.
 746         * record-btrace.c (ui_out_field_uint): Remove.
 747         (btrace_call_history_insn_range, btrace_call_history): Use
 748         field_unsigned.
 749         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 750         field_unsigned.
 751         * ui-out.h (class ui_out) <field_unsigned>: New method.
 752         <do_field_unsigned>: Likewise.
 753
 754 2019-07-15  Tom Tromey  <tromey@adacore.com>
 755
 756         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 757         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 758         * target.c (flash_erase_command): Use field_string.
 759         * infrun.c (print_signal_received_reason): Use field_string.
 760         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 761         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 762         field_string.
 763         * ada-tasks.c (print_ada_task_info): Use field_string.
 764
 765 2019-07-15  Tom Tromey  <tromey@adacore.com>
 766
 767         * target.c (flash_erase_command): Use field_core_addr.
 768         * symfile.c (generic_load): Use field_core_addr.
 769         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 770         Use field_core_addr.
 771         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 772         field_core_addr.
 773
 774 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 777         value if its desired type is smaller than a CORE_ADDR and signed.
 778
 779 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 782         of changes to field names, and use new is_reference field to
 783         decide if a property is a reference or not.
 784         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 785         field.
 786         (struct dwarf2_property_baton): Update header comment, rename
 787         'referenced_type' to 'property_type' and update comments.
 788         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 789         default property type, store in property baton, update to take
 790         accound of renamed field.
 791         (read_func_scope): Update call to attr_to_dynamic_prop.
 792         (read_array_type): Likewise.
 793         (dwarf2_per_cu_addr_sized_int_type): New function.
 794         (read_subrange_index_type): Move type finding code to
 795         dwarf2_per_cu_addr_sized_int_type.
 796         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 797         (dwarf2_per_cu_addr_type): New function.
 798         (set_die_type): Update calls to attr_to_dynamic_prop.
 799
 800 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * dwarf2read.c (read_subrange_index_type): New function.
 803         (read_subrange_type): Move code into new function and call it.
 804         * gdbtypes.c (create_range_type): Add some asserts.
 805
 806 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 809         update return statements.
 810         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 811         declaration, and update comment to match.
 812         * gdbtypes.c (resolve_dynamic_array): Update call to
 813         dwarf2_evaluate_property to match new return type.
 814
 815 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * valarith.c (value_subscripted_rvalue): Change lowerbound
 818         parameter type from int to LONGEST.
 819         * value.h (value_subscripted_rvalue): Likewise in declaration.
 820
 821 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * cli/cli-utils.c (info_print_command_completer): New function.
 824         * cli/cli-utils.h: Add 'completer.h' include, and forward
 825         declaration for 'struct cmd_list_element'.
 826         (info_print_command_completer): Declare.
 827         * stack.c (_initialize_stack): Add completer for 'info locals' and
 828         'info args'.
 829         * symtab.c (_initialize_symtab): Add completer for 'info
 830         variables' and 'info functions'.
 831         * NEWS: Mention completion for additional info commands.
 832
 833 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * cli/cli-utils.c (extract_info_print_args): Delete.
 836         (extract_arg_maybe_quoted): Delete.
 837         (info_print_options_defs): New variable.
 838         (make_info_print_options_def_group): New function.
 839         (extract_info_print_options): Define new function.
 840         * cli/cli-utils.h (extract_info_print_args): Delete.
 841         (struct info_print_options): New structure.
 842         (extract_info_print_options): Declare new function.
 843         * stack.c (info_locals_command): Update to use new
 844         extract_info_print_options, also add a header comment.
 845         (info_args_command): Likewise.
 846         * symtab.c (info_variables_command): Likewise.
 847         (info_functions_command): Likewise.
 848
 849 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 852         to extract string arguments.
 853         * common/common-utils.c (extract_string_maybe_quoted): New function.
 854         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 855
 856 2019-07-11  Tom Tromey  <tromey@adacore.com>
 857
 858         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 859         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 860         * top.h (gdbinit): Don't declare.
 861         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 862         into...
 863         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 864         * top.c (gdb_init): Don't call init_cli_cmds.
 865         (gdbinit): Remove.
 866         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 867
 868 2019-07-11  Tom Tromey  <tromey@adacore.com>
 869
 870         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 871         after it has been moved.
 872
 873 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 874
 875         * valops.c (value_must_coerce_to_target): Change return type to
 876         bool.
 877         * value.h (value_must_coerce_to_target): Likewise.
 878
 879 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 880
 881         * breakpoint.c (is_hardware_watchpoint): Remove
 882         forward-declaration.
 883         (is_masked_watchpoint): Change return type to bool.
 884         (is_tracepoint): Likewise.
 885         (is_breakpoint): Likewise.
 886         (is_hardware_watchpoint): Likewise.
 887         (is_watchpoint): Likewise.
 888         (is_no_memory_software_watchpoint): Likewise.
 889         (is_catchpoint): Likewise.
 890         (breakpoint_1): Make FILTER parameter's return type bool.
 891         is_masked_watchpoint): Change return type to bool.
 892         (save_breakpoints): Make FILTER parameter's return type bool.
 893         * breakpoint.h (is_breakpoint): Change return type to bool.
 894         (is_watchpoint): Likewise.
 895         (is_catchpoint): Likewise.
 896         (is_tracepoint): Likewise.
 897
 898 2019-07-10  Tom Tromey  <tom@tromey.com>
 899
 900         * defs.h: Don't include gdbarch.h.
 901         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 902         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 903         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 904         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 905         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 906         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 907         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 908         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 909         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 910         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 911         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 912         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 913         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 914         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 915         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 916         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 917         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 918         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 919         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 920         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 921         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 922         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 923         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 924         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 925         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 926         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 927         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 928
 929 2019-07-10  Tom Tromey  <tromey@adacore.com>
 930
 931         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 932         * breakpoint.c (init_ada_exception_breakpoint): Register as
 933         bp_catchpoint.
 934         (print_one_breakpoint_location, print_one_breakpoint): Use
 935         is_ada_exception_catchpoint.
 936         * ada-lang.c (class ada_catchpoint_location): Pass
 937         bp_loc_software_breakpoint to bp_location constructor.
 938         (is_ada_exception_catchpoint): New function.
 939
 940 2019-07-10  Tom Tromey  <tromey@adacore.com>
 941
 942         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 943         VEC.
 944         (struct arm_exidx_entry): New method operator<.
 945         (struct arm_exidx_data) <section_maps>: Change type.
 946         (arm_exidx_data_free): Remove.
 947         (arm_exidx_data_key): Change type.  Move lower.
 948         (arm_exidx_new_objfile): Update.
 949         (arm_compare_exidx_entries): Remove.
 950         (arm_find_exidx_entry, _initialize_arm_tdep)
 951
 952 2019-07-10  Tom Tromey  <tromey@adacore.com>
 953
 954         * solib-spu.c (ocl_program_data_key): Change type.
 955         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 956         Update.
 957
 958 2019-07-10  Tom Tromey  <tromey@adacore.com>
 959
 960         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 961         (struct solib_aix_inferior_data) <library_list>: Change type.
 962         (solib_aix_inferior_data_handle): Change type.
 963         (get_solib_aix_inferior_data): Update.
 964         (solib_aix_free_library_list): Remove.
 965         (library_list_start_library): Update.
 966         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 967         return type.
 968         (solib_aix_get_library_list)
 969         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 970         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 971
 972 2019-07-10  Tom Tromey  <tromey@adacore.com>
 973
 974         * solib-dsbt.c (struct dsbt_info): Add initializers.
 975         (solib_dsbt_pspace_data): Change type.
 976         (dsbt_pspace_data_cleanup): Remove.
 977         (get_dsbt_info, _initialize_dsbt_solib): Update.
 978
 979 2019-07-10  Tom Tromey  <tromey@adacore.com>
 980
 981         * spu-tdep.c (spu_overlay_data): Change type.
 982         (spu_get_overlay_table, spu_overlay_new_objfile)
 983         (_initialize_spu_tdep): Update.
 984
 985 2019-07-10  Tom Tromey  <tromey@adacore.com>
 986
 987         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 988         destructor.
 989         (dbx_objfile_data_key): Change type and declare later.
 990         (DBX_SYMFILE_INFO): Rewrite.
 991         * dbxread.c (dbx_objfile_data_key): Change type.
 992         (dbx_symfile_init): Update.
 993         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 994         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 995         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 996
 997 2019-07-10  Tom Tromey  <tromey@adacore.com>
 998
 999         * jit.c (jit_program_space_key): Change type.  Move lower.
1000         (get_jit_program_space_data): Update.
1001         (jit_program_space_data_cleanup): Remove.
1002         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1003         Update.
1004         (struct jit_program_space_data): Add initializers.
1005
1006 2019-07-10  Tom Tromey  <tromey@adacore.com>
1007
1008         * solib-darwin.c (struct darwin_info): Add initializers.
1009         (solib_darwin_pspace_data): Change type.
1010         (darwin_pspace_data_cleanup): Remove.
1011         (get_darwin_info, _initialize_darwin_solib): Update.
1012
1013 2019-07-10  Tom Tromey  <tromey@adacore.com>
1014
1015         * remote-sim.c (struct sim_inferior_data): Add initializers,
1016         constructor, and destructor.
1017         (sim_inferior_data_key): Change type.  Move lower.
1018         (check_for_duplicate_sim_descriptor): Update.
1019         (get_sim_inferior_data): Use new.  Update.
1020         (~sim_inferior_data_cleanup): Rename from
1021         sim_inferior_data_cleanup.  Simplify.
1022         (gdbsim_close_inferior, simulator_command)
1023         (sim_command_completer, _initialize_remote_sim): Update.
1024         (next_pid, INITIAL_PID): Move earlier.
1025
1026 2019-07-10  Tom Tromey  <tromey@adacore.com>
1027
1028         * python/python-internal.h (create_thread_object): Return
1029         gdbpy_ref.
1030         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1031         * python/py-inferior.c (struct threadlist_entry): Add
1032         constructor.
1033         <thread_obj>: Now a gdbpy_ref.
1034         (thread_to_thread_object): Update.
1035         (add_thread_object): Use new.
1036         (delete_thread_object): Use delete.
1037         (infpy_threads): Update.
1038         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1039         GIL.
1040
1041 2019-07-10  Tom Tromey  <tromey@adacore.com>
1042
1043         * valops.c (value_cast): Specialize error message for Ada.
1044
1045 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1046
1047         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1048
1049 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1050
1051         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1052         bpstat_should_step): Return bool, adjust comments.
1053         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1054         bpstat_should_step): Likewise.
1055
1056 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1057
1058         * features/Makefile: Use feature target descriptions for Arm.
1059         * features/arm/arm-core.c: Generate new file.
1060         * features/arm/arm-fpa.c: Likewise.
1061         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1062         * features/arm/arm-m-profile.c: Likewise.
1063         * features/arm/arm-vfpv2.c: Likewise.
1064         * features/arm/arm-vfpv3.c: Likewise.
1065         * features/arm/xscale-iwmmxt.c: Likewise.
1066         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1067
1068 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1069
1070         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1071         ptrace earlier.
1072
1073 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1074
1075         * features/aarch64-pauth.c: Regenerate.
1076
1077 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1078
1079         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1080         bool.
1081         (bpstat_what): Use false instead of 0.
1082
1083 2019-07-09  Pedro Alves  <palves@redhat.com>
1084
1085         * break-catch-throw.c (is_exception_catchpoint): New.
1086         * breakpoint.c (print_one_breakpoint_location): New parameter
1087         'raw_loc'.  Handle it.  Use
1088         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1089         looking at the breakpoint's type.
1090         (print_one_breakpoint): If handling "maint info breakpoints", also
1091         print locations of exception catchpoints.
1092         * breakpoint.h (is_exception_catchpoint): Declare.
1093
1094 2019-07-09  Pedro Alves  <palves@redhat.com>
1095
1096         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1097         "addr" field.
1098         (allocate_location_exception_catchpoint): New.
1099         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1100         (initialize_throw_catchpoint_ops): Install
1101         allocate_location_exception_catchpoint as allocate_location
1102         method.
1103         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1104         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1105         bp_loc_other.
1106         (breakpoint_address_is_meaningful): Delete.
1107         (bl_address_is_meaningful): New.
1108         (breakpoint_locations_match): Adjust comment.
1109         (bp_location_from_bp_type): New, factored out of...
1110         (bp_location::bp_location(breakpoint *)): ... this.
1111         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1112         factored out of...
1113         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1114         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1115         breakpoint_address_is_meaningful.
1116         (bp_locations_compare): Adjust comment.
1117         (update_global_location_list): Use bl_address_is_meaningful
1118         instead of breakpoint_address_is_meaningful.
1119         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1120         explicit.
1121         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1122         * python/py-breakpoint.c (bppy_get_location): No longer check
1123         whether location is null.
1124
1125 2019-07-09  Pedro Alves  <palves@redhat.com>
1126
1127         PR c++/15468
1128         * breakpoint.c (print_one_breakpoint_location): Remove
1129         single-location assert.
1130
1131 2019-07-09  Tom Tromey  <tom@tromey.com>
1132
1133         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1134         * configure: Rebuild.
1135         * configure.ac: Change common to gdbsupport.
1136         * gdbsupport: Rename from common.
1137         * acinclude.m4: Change common to gdbsupport.
1138         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1139         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1140         gdbsupport.
1141         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1142         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1143         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1144         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1145         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1146         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1147         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1148         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1149         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1150         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1151         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1152         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1153         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1154         coff-pe-read.c, command.h, compile/compile-c-support.c,
1155         compile/compile-c.h, compile/compile-cplus-symbols.c,
1156         compile/compile-cplus-types.c, compile/compile-cplus.h,
1157         compile/compile-loc2c.c, compile/compile.c, completer.c,
1158         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1159         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1160         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1161         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1162         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1163         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1164         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1165         features/aarch64-core.c, features/aarch64-fpu.c,
1166         features/aarch64-pauth.c, features/aarch64-sve.c,
1167         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1168         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1169         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1170         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1171         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1172         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1173         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1174         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1175         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1176         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1177         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1178         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1179         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1180         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1181         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1182         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1183         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1184         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1185         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1186         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1187         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1188         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1189         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1190         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1191         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1192         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1193         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1194         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1195         minsyms.c, mips-linux-tdep.c, namespace.h,
1196         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1197         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1198         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1199         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1200         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1201         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1202         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1203         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1204         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1205         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1206         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1207         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1208         procfs.c, producer.c, progspace.h, psymtab.h,
1209         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1210         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1211         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1212         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1213         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1214         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1215         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1216         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1217         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1218         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1219         target-memory.c, target.c, target.h, target/waitstatus.c,
1220         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1221         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1222         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1223         unittests/array-view-selftests.c,
1224         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1225         unittests/common-utils-selftests.c,
1226         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1227         unittests/format_pieces-selftests.c,
1228         unittests/function-view-selftests.c,
1229         unittests/lookup_name_info-selftests.c,
1230         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1231         unittests/mkdir-recursive-selftests.c,
1232         unittests/observable-selftests.c,
1233         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1234         unittests/parse-connection-spec-selftests.c,
1235         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1236         unittests/scoped_fd-selftests.c,
1237         unittests/scoped_mmap-selftests.c,
1238         unittests/scoped_restore-selftests.c,
1239         unittests/string_view-selftests.c, unittests/style-selftests.c,
1240         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1241         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1242         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1243         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1244         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1245         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1246
1247 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1250         bool value.
1251         (decode_digits_ordinary): Set explicit_line field in sal.
1252         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1253         symtab_and_line that was set on an explicit line number in
1254         assembler code.  Do always update the recorded symtab and line if
1255         we do skip the prologue.
1256
1257 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * breakpoint.c (set_breakpoint_location_function): Remove
1260         explicit_loc parameter.
1261         (momentary_breakpoint_from_master): Update call to
1262         set_breakpoint_location_function.
1263         (add_location_to_breakpoint): Likewise.
1264
1265 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1268         required features based on default bfd type when no specific bfd
1269         is present.
1270
1271 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1272
1273         * NEWS: Mention that GDB printf and eval commands can now print
1274         C-style and Ada-style convenience var strings without
1275         calling the inferior.
1276         * printcmd.c (printf_c_string): Locally print GDB internal var
1277         instead of transiting via the inferior.
1278         (printf_wide_c_string): Likewise.
1279
1280 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1281
1282         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1283
1284 2019-07-04  Tom Tromey  <tom@tromey.com>
1285
1286         PR tui/24724:
1287         * tui/tui-winsource.c (tui_clear_source_content): Update.
1288         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1289         (tui_update_breakpoint_info): Update.
1290         (tui_set_exec_info_content): Update.
1291         * tui/tui-source.c (tui_set_source_content_nil): Update.
1292         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1293         has_break.
1294         * tui/tui-data.h (enum tui_bp_flag): New.
1295         (tui_bp_flags): New enum flags type.
1296         (struct tui_source_element) <break_mode>: Change type.  Rename
1297         from has_break.
1298         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1299         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1300         constants.
1301         * tui/tui-winsource.h: Fix comment.
1302
1303 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1304
1305         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1306         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1307         (store_fpregs_to_thread)
1308         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1309         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1310         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1311         (IWMMXT_REGS_SIZE): Add define.
1312         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1313         (fetch_vfp_regs, store_vfp_regs)
1314         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1315         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1316
1317 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1320         defines.
1321         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1322         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1323         (ARM_INT_REGISTER_SIZE): ...to this.
1324         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1325         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1326         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1327         (arm_linux_collect_gregset, supply_nwfpe_register)
1328         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1329         defines.
1330         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1331         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1332         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1333         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1334         (arm_return_in_memory, arm_store_return_value)
1335         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1336         (arm_record_ld_st_multiple): Likewise.
1337         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1338         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1339
1340 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1341
1342         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1343         AARCH64_DISPLACED_MODIFIED_INSNS.
1344         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1345         (aarch64_displaced_step_copy_insn): Likewise.
1346         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1347         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1348         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1349         ARM_DISPLACED_MODIFIED_INSNS.
1350         * arm-tdep.c (arm_gdbarch_init): Likewise.
1351         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1352         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1353         (struct arm_displaced_step_closure): Use
1354         ARM_DISPLACED_MODIFIED_INSNS.
1355
1356 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1357
1358         * features/Makefile: Remove unused xml files.
1359         * features/aarch64.xml: Remove.
1360         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1361         * features/i386/amd64-avx-avx512.xml: Remove.
1362         * features/i386/amd64-avx-linux.xml: Remove.
1363         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1364         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1365         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1366         * features/i386/amd64-avx-mpx.xml: Remove.
1367         * features/i386/amd64-avx.xml: Remove.
1368         * features/i386/amd64-linux.xml: Remove.
1369         * features/i386/amd64-mpx-linux.xml: Remove.
1370         * features/i386/amd64-mpx.xml: Remove.
1371         * features/i386/amd64.xml: Remove.
1372         * features/i386/i386-avx-avx512-linux.xml: Remove.
1373         * features/i386/i386-avx-avx512.xml: Remove.
1374         * features/i386/i386-avx-linux.xml: Remove.
1375         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1376         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1377         * features/i386/i386-avx-mpx-linux.xml: Remove.
1378         * features/i386/i386-avx-mpx.xml: Remove.
1379         * features/i386/i386-avx.xml: Remove.
1380         * features/i386/i386-linux.xml: Remove.
1381         * features/i386/i386-mmx-linux.xml: Remove.
1382         * features/i386/i386-mmx.xml: Remove.
1383         * features/i386/i386-mpx-linux.xml: Remove.
1384         * features/i386/i386-mpx.xml: Remove.
1385         * features/i386/i386.xml: Remove.
1386         * features/i386/x32-avx-avx512-linux.xml: Remove.
1387         * features/i386/x32-avx-linux.xml: Remove.
1388         * features/i386/x32-linux.xml: Remove.
1389
1390 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1391
1392         * regformats/aarch64.dat: Remove.
1393         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1394         * regformats/i386/amd64-avx-linux.dat: Remove.
1395         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1396         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1397         * regformats/i386/amd64-linux.dat: Remove.
1398         * regformats/i386/amd64-mpx-linux.dat: Remove.
1399         * regformats/i386/amd64.dat: Remove.
1400         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1401         * regformats/i386/i386-avx-linux.dat: Remove.
1402         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1403         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1404         * regformats/i386/i386-linux.dat: Remove.
1405         * regformats/i386/i386-mmx-linux.dat: Remove.
1406         * regformats/i386/i386-mpx-linux.dat: Remove.
1407         * regformats/i386/i386.dat: Remove.
1408         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1409         * regformats/i386/x32-avx-linux.dat: Remove.
1410         * regformats/i386/x32-linux.dat: Remove.
1411
1412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * aarch64-tdep.c: Remove xml self tests.
1415         * amd64-linux-tdep.c: Likewise.
1416         * amd64-tdep.c: Likewise.
1417         * i386-linux-tdep.c: Likewise.
1418         * i386-tdep.c: Likewise.
1419
1420 2019-07-03  Pedro Alves  <palves@redhat.com>
1421
1422         PR cli/24732
1423         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1424         (pipe_cmd_option_defs): New.
1425         (make_pipe_cmd_options_def_group): New.
1426         (pipe_command): Use gdb::option::process_options.
1427         (pipe_command_completer): New function.
1428         (_initialize_cli_cmds): Install completer for "pipe" command.
1429
1430 2019-07-03  Pedro Alves  <palves@redhat.com>
1431
1432         * cli/cli-option.c (union option_value) <string>: New field.
1433         (struct option_def_and_value): Add ctor, move ctor, dtor and
1434         use DISABLE_COPY_AND_ASSIGN.
1435         (option_def_and_value::clear_value): New.
1436         (parse_option, save_option_value_in_ctx, get_val_type_str)
1437         (add_setshow_cmds_for_options): Handle var_string.
1438         * cli-option.h (union option_def::var_address) <string>: New
1439         field.
1440         (struct string_option_def): New.
1441         * maint-test-options.c (struct test_options_opts): Add default
1442         ctor and use DISABLE_COPY_AND_ASSIGN.
1443         <string_opt>: New field.
1444         (test_options_opts::~test_options_opts): New.
1445         (test_options_opts::dump): Also dump "-string".
1446         (test_options_option_defs): Install "string.
1447
1448 2019-07-03  Pedro Alves  <palves@redhat.com>
1449
1450         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1451         option_value with a null enumeration.
1452         (complete_options): Save the option values in the context.
1453         (save_option_value_in_ctx): New, factored out from ...
1454         (process_options): ... here.
1455         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1456         of the function.
1457         * maint-test-options.c (test_options_opts::dump): New, factored
1458         out from ...
1459         (maintenance_test_options_command_mode): ... here.
1460         (maintenance_test_options_command_completion_result): Delete.
1461         (maintenance_test_options_command_completion_text): Update
1462         comment.
1463         (maintenance_show_test_options_completion_result): Change
1464         prototype.  Just print
1465         maintenance_test_options_command_completion_text.
1466         (save_completion_result): New.
1467         (maintenance_test_options_completer_mode): Pass options context to
1468         complete_options, and then save a dump.
1469         (_initialize_maint_test_options): Use add_cmd to install "maint
1470         show test-options-completion-result".
1471
1472 2019-07-03  Pedro Alves  <palves@redhat.com>
1473
1474         * NEWS (New commands): Mention "with" and "maint with".
1475         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1476         (with_command, with_command_completer): New.
1477         (pipe_command): Adjust to new repeat_previous
1478         interface.
1479         (_initialize_cli_cmds): Install the "with" command and its "w"
1480         alias.
1481         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1482         declarations.
1483         * cli/cli-setshow.c (parse_cli_var_uinteger)
1484         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1485         argument strings for all var_types.
1486         (get_setshow_command_value_string): New, factored out from ...
1487         (do_show_command): ... this.
1488         * cli/cli-setshow.h: Include <string>.
1489         (get_setshow_command_value_string): Declare.
1490         * command.h (repeat_previous): Now returns const char *.  Adjust
1491         comment.
1492         * maint.c: Include "cli/cli-cmds.h".
1493         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1494         (_initialize_maint_cmds): Register the "maintenance with" command.
1495         * top.c (repeat_previous): Move bits from pipe_command here:
1496         Return the saved command line, if any; error out if there's no
1497         command to relaunch.
1498
1499 2019-07-03  Pedro Alves  <palves@redhat.com>
1500
1501         * NEWS (New commands): Mention "maint set/show test-settings"
1502         instead of "maint test-settings".
1503         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1504         (maintenance_test_settings_set_list): Rename to ...
1505         (maintenance_set_test_settings_list): ... this.
1506         (maintenance_test_settings_show_list): Rename to  ...
1507         (maintenance_show_test_settings_list): ... this.
1508         (maintenance_test_settings_cmd): Delete.
1509         (maintenance_test_settings_set_cmd): ...
1510         (maintenance_set_test_settings_cmd): ... this.
1511         (maintenance_test_settings_show_cmd): ...
1512         (maintenance_show_test_settings_cmd): ... this.
1513         (maintenance_test_settings_show_value_cmd):
1514         (maintenance_show_test_settings_value_cmd): ... this.
1515         (_initialize_maint_test_settings): No longer install the "maint
1516         test-settings" prefix command.  Rename "maint test-settings set"
1517         to "maint set test-settings", and "maint test-settings show" to
1518         "maint show test-settings".  Adjust all subcommands.
1519
1520 2019-07-03  Pedro Alves  <palves@redhat.com>
1521
1522         * maint-test-settings.c: Fix file's intro comment.  Replace all
1523         references to "test-options" with references to "test-settings",
1524         in comments.
1525
1526 2019-07-03  Pedro Alves  <palves@redhat.com>
1527
1528         * maint-test-settings.c (maintenance_test_settings_xxx)
1529         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1530         New.
1531         (maintenance_test_settings_enums): Use them.
1532         (maintenance_test_settings_enum): Default to
1533         maintenance_test_settings_xxx.
1534         (_initialize_maint_test_settings): Initialize
1535         MAINTENANCE_TEST_SETTINGS_FILENAME.
1536
1537 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1538
1539         * breakpoint.h (remove_breakpoints_inf): Change return type to
1540         void, move function documentation here.
1541         * breakpoint.c (remove_breakpoints_inf): Change return type to
1542         void, move function documentation to header.
1543
1544 2019-07-02  Pedro Alves  <palves@redhat.com>
1545
1546         * NEWS (Completion improvements): Mention "info threads".
1547         * thread.c (struct info_threads_opts, info_threads_option_defs)
1548         (make_info_threads_options_def_group): New.
1549         (info_threads_command): Use gdb::option::process_options.
1550         (info_threads_command_completer): New.
1551         (_initialize_thread): Use gdb::option::build_help to build the
1552         help text for "info threads".
1553
1554 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1555
1556         * defs.h (generic_load): Move from here...
1557         * symfile.h (generic_load): ... to here.  Rename name parameter
1558         to args.
1559         * symfile.c (generic_load): Add comment.
1560
1561 2019-07-01  Tom Tromey  <tromey@adacore.com>
1562
1563         * dwarf2read.c
1564         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1565         declaration of without_params.  Fix formatting.
1566
1567 2019-07-01  Tom Tromey  <tromey@adacore.com>
1568
1569         * ada-exp.y (find_primitive_type): Update.
1570         * ada-lang.h (ada_lookup_symbol): Update.
1571         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1572         parameter.
1573         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1574
1575 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1576
1577         PR breakpoints/24541
1578         * gdbarch.c: Regenerate.
1579         * gdbarch.h: Regenerate.
1580         * gdbarch.sh: Add 'stap_adjust_register'.
1581         * i386-tdep.c: Include '<unordered_set>'.
1582         (i386_stap_adjust_register): New function.
1583         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1584         * stap-probe.c (stap_parse_register_operand): Call
1585         'gdbarch_stap_adjust_register'.
1586
1587 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1588
1589         PR python/24742
1590         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1591         * python/python.c (do_start_initialization): Use 'xmalloc'
1592         instead of 'PyMem_Malloc'.
1593
1594 2019-06-28  Tom Tromey  <tromey@adacore.com>
1595
1596         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1597         for Ada.
1598
1599 2019-06-27  Tom Tromey  <tromey@adacore.com>
1600
1601         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1602         objfile_key.
1603         (arm_find_mapping_symbol, arm_record_special_symbol)
1604         (_initialize_arm_tdep): Update.
1605         (arm_objfile_data_free): Remove.
1606
1607 2019-06-27  Tom Tromey  <tromey@adacore.com>
1608
1609         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1610         to cp_print_static_field.
1611
1612 2019-06-26  Tom Tromey  <tromey@adacore.com>
1613
1614         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1615         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1616         declare.
1617
1618 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1619
1620         * features/aarch64-core.c (create_feature_aarch64_core):
1621         Regenerate.
1622         * features/aarch64-core.xml: Add cpsr flags.
1623
1624 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1625
1626         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1627         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1628
1629 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1630
1631         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1632         field.
1633         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1634         use.
1635         (arm_record_special_symbol): Don't insert new symbol in sorted
1636         position, push it at the end.
1637
1638 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1639
1640         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1641         (arm_mapping_symbol_s): Remove.
1642         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1643         (arm_mapping_symbol_vec): New typedef.
1644         (struct arm_per_objfile): Add constructor.
1645         <section_maps>: Change type to
1646         std::unique_ptr<arm_mapping_symbol_vec[]>.
1647         (arm_compare_mapping_symbols): Remove.
1648         (arm_find_mapping_symbol): Adjust to section_maps type change.
1649         (arm_objfile_data_free): Call delete on arm_per_objfile.
1650         (arm_record_special_symbol): Adjust to section_maps type change.
1651         Allocate arm_per_objfile with new.
1652
1653 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1654
1655         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1656         with the command prefix.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1661         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1662
1663 2019-06-25  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1666         type.
1667         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1668         protected.
1669
1670 2019-06-25  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-winsource.c
1673         (tui_source_window_base::set_is_exec_point_at): Add check against
1674         LOA_ADDRESS.
1675
1676 2019-06-25  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-source.c (tui_set_source_content): Don't check before
1679         xfree.
1680         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1681
1682 2019-06-25  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-winsource.h (tui_update_source_window_as_is)
1685         (tui_alloc_source_buffer, tui_line_is_displayed)
1686         (tui_addr_is_displayed): Change type of win_info.
1687         * tui/tui-winsource.c (tui_update_source_window_as_is)
1688         (tui_clear_source_content, tui_show_source_line)
1689         (tui_show_source_content, tui_source_window_base::refill)
1690         (tui_source_window_base::set_is_exec_point_at)
1691         (tui_source_window_base::set_is_exec_point_at)
1692         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1693         (tui_alloc_source_buffer, tui_line_is_displayed)
1694         (tui_addr_is_displayed): Change type of win_info.  Update.
1695         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1696         (tui_source_window_base::do_make_visible_with_new_height):
1697         Update.
1698         * tui/tui-source.c (tui_set_source_content)
1699         (tui_set_source_content_nil)
1700         (tui_source_window::do_scroll_vertical): Update.
1701         * tui/tui-layout.c (show_layout): Update.
1702         * tui/tui-disasm.c (tui_set_disassem_content)
1703         (tui_disasm_window::do_scroll_vertical): Update.
1704         * tui/tui-data.h (tui_win_content): Remove.
1705         (struct tui_gen_win_info) <content, content_size>: Remove.
1706         (struct tui_source_element): Add initializers and destructor.
1707         (union tui_which_element, struct tui_win_element): Remove.
1708         (struct tui_source_window_base) <content>: New field.
1709         (struct tui_data_window): Remove destructor.
1710         (tui_alloc_content, tui_free_win_content)
1711         (tui_free_all_source_wins_content): Don't declare.
1712         * tui/tui-data.c (tui_initialize_static_data): Update.
1713         (init_content_element, tui_alloc_content): Remove.
1714         (~tui_gen_win_info): Update.
1715         (~tui_data_window, tui_free_all_source_wins_content)
1716         (tui_free_win_content, free_content, free_content_elements):
1717         Remove.
1718
1719 2019-06-25  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-winsource.h (tui_clear_source_content)
1722         (tui_erase_source_content, tui_show_source_content): Change type
1723         of win_info.
1724         * tui/tui-winsource.c (tui_clear_source_content)
1725         (tui_erase_source_content, tui_show_source_content): Change type
1726         of win_info.
1727         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1728         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1729         win_info.
1730         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1731         win_info.
1732         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-winsource.c (tui_clear_source_content)
1737         (tui_source_window_base::set_is_exec_point_at): Update.
1738         * tui/tui-source.c (tui_set_source_content_nil): Update.
1739         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1740         a bool.
1741         * tui/tui-data.c (init_content_element): Update.
1742
1743 2019-06-25  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1746         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1747         * tui/tui-layout.c (init_and_make_win): Update.
1748         * tui/tui.h (enum tui_win_type): Update.
1749         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1750         tui_win_is_auxillary.
1751         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1752         tui_win_is_auxillary.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1757         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1758         (tui_delete_data_content_windows, tui_display_all_data)
1759         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1760         Update.
1761         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1762         * tui/tui-regs.c (tui_last_regs_line_no)
1763         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1764         (tui_show_registers): Update.
1765         (tui_show_register_group): Return void.  Update.
1766         (tui_display_registers_from, tui_display_reg_element_at_line)
1767         (tui_display_registers_from_line, tui_check_register_values):
1768         Update.
1769         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1770         member.
1771         (struct tui_data_window) <regs_content>: Now a std::vector.
1772         <regs_content_count>: Remove.
1773         (tui_add_content_elements, tui_free_data_content): Don't declare.
1774         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1775         (init_content_element): Remove DATA_WIN case.  Add assert.
1776         (tui_add_content_elements): Remove.
1777         (tui_data_window): Update.
1778         (tui_free_data_content): Remove.
1779         (free_content_elements): Remove DATA_WIN case.
1780
1781 2019-06-25  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-data.c (tui_data_item_window): Update.
1784         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1785         * tui/tui-windata.c (tui_display_all_data)
1786         (tui_display_data_from_line): Update.
1787         (tui_check_data_values): Remove.
1788         * tui/tui-regs.c (tui_show_register_group)
1789         (tui_display_reg_element_at_line): Update.
1790         * tui/tui-hooks.c (tui_register_changed)
1791         (tui_refresh_frame_and_register_information): Call
1792         tui_check_register_values.
1793         * tui/tui-data.h (struct tui_data_window) <data_content,
1794         data_content_count, data_type>: Remove.
1795         (enum tui_data_type): Remove.
1796
1797         * tui/tui-data.c (tui_data_window::clear_detail)
1798         (~tui_data_window): Update.
1799
1800 2019-06-25  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1803         declare.
1804         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1805         Rename from tui_first_data_item_displayed.  Update.
1806         (tui_data_window::refresh_all)
1807         (tui_data_window::do_scroll_vertical): Update.
1808         * tui/tui-data.h (struct tui_data_window)
1809         <first_data_item_displayed>: Declare new method.
1810
1811 2019-06-25  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1814         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1815         contents...
1816         (tui_initialize_static_data): ...here.
1817
1818 2019-06-25  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1821         (tui_display_registers_from, tui_check_register_values): Update.
1822         (tui_display_register): Remove win_info parameter; update.
1823         (tui_get_register): Change type of parameters.
1824         * tui/tui-data.h (struct tui_data_element): Remove.
1825         (union tui_which_element) <data>: Remove.
1826         <data_window>: Change type.
1827         (struct tui_data_item_window): New.
1828         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1829         case.  Add assert.
1830         (~tui_data_item_window): New destructor.
1831         (free_content_elements): Remove DATA_ITEM_WIN case.
1832
1833 2019-06-25  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1836         Remove.
1837
1838 2019-06-25  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-data.h (struct tui_command_element): Remove.
1841         (union tui_which_element) <command>: Remove.
1842         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1843         assert.
1844         (free_content_elements): Remove CMD_WIN case.
1845
1846 2019-06-25  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-layout.c (tui_set_layout): Update.
1849         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1850         * tui/tui-data.c (layout_def): Update.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1855         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1856         (tui_source_window_base::set_new_height): Update.
1857         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1858         Update.
1859         (tui_set_locator_fullname, tui_set_locator_info)
1860         (tui_show_frame_info): Update.
1861         * tui/tui-source.c (tui_set_source_content)
1862         (tui_source_is_displayed): Update.
1863         * tui/tui-layout.c (show_source_disasm_command, show_data)
1864         (show_source_or_disasm_and_command): Update.
1865         * tui/tui-disasm.c (tui_set_disassem_content)
1866         (tui_get_begin_asm_address): Update.
1867         * tui/tui-data.h (struct tui_locator_element): Remove.
1868         (union tui_which_element) <locator>: Remove.
1869         (struct tui_locator_window): New.
1870         (tui_locator_win_info_ptr): Change return type.
1871         * tui/tui-data.c (_locator): Change type.
1872         (tui_locator_win_info_ptr): Change return type.
1873         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1874         (tui_alloc_content): Add assert.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-winsource.c
1879         (tui_exec_info_window::maybe_allocate_content): New method.
1880         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1881         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1882         (make_source_or_disasm_window): Add cast.
1883         * tui/tui-data.h (union tui_which_element) <simple_string>:
1884         Remove.
1885         (struct tui_source_info): New.
1886         (struct tui_source_window_base) <execution_info>: Change type.
1887         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1888         case, and add assert.
1889         (tui_alloc_content): Add assert.
1890
1891 2019-06-25  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1894         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1895         * tui/tui-data.c (tui_alloc_win_info): Remove.
1896
1897 2019-06-25  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1900         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1901         can_highlight.
1902
1903 2019-06-25  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1906         make_visible_with_new_height method.
1907         (tui_win_info::make_visible_with_new_height): New method.
1908         (tui_source_window_base::do_make_visible_with_new_height)
1909         (tui_data_window::do_make_visible_with_new_height)
1910         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1911         (make_visible_with_new_height): Remove.
1912         (tui_resize_all, tui_adjust_win_heights): Use
1913         make_visible_with_new_height method.
1914         * tui/tui-data.h (struct tui_win_info)
1915         <do_make_visible_with_new_height, make_visible_with_new_height>:
1916         New methods.
1917         (struct tui_source_window_base, struct tui_data_window)
1918         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1919         methods.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1924         method.
1925         (update_tab_width): Call update_tab_width method.
1926         * tui/tui-data.h (struct tui_win_info)
1927         (struct tui_source_window_base) <update_tab_width>: New methods.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1932         parameter.
1933         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1934         parameter.
1935         (tui_gen_win_info::make_visible): Update.
1936         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1937         parameter.
1938         * tui/tui-data.h (enum tui_box): New enum.
1939         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1944         init_and_make_win for EXEC_INFO_WIN.
1945         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1946         longer inline.
1947         (struct tui_win_info) <~tui_win_info>: Inline.
1948         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1949         Don't declare.
1950         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1951         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1952         Remove.
1953         (tui_initialize_static_data): Update.
1954         (~tui_gen_win_info): Handle more cleanup here.
1955         (~tui_source_window_base): Delete "execution_info".
1956         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-layout.c (make_command_window): Don't set
1961         can_highlight.
1962         (show_source_disasm_command): Call the reset method.
1963         (show_data): Don't set can_highlight.  Call the reset method.
1964         (tui_gen_win_info::reset): Rename from init_gen_win_info
1965         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1966         (show_source_or_disasm_and_command): Call the reset method.
1967         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1968         (struct tui_cmd_window): Set can_highlight.
1969
1970 2019-06-25  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1973         from make_visible.
1974         (tui_make_visible, tui_make_invisible): Rewrite.
1975         (tui_win_info::make_visible): Remove.
1976         (tui_source_window_base::make_visible): Update.
1977         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1978         method.  Moved from...
1979         (struct tui_win_info) <make_visible>: ...here.
1980
1981 2019-06-25  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-winsource.c
1984         (tui_source_window_base::do_scroll_horizontal): Remove direction
1985         parameter.
1986         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1987         direction parameter.
1988         * tui/tui-win.c (tui_win_info::forward_scroll)
1989         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1990         (tui_win_info::right_scroll): Update.
1991         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1992         direction parameter.
1993         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1994         direction parameter.
1995         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1996         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1997         Remove direction parameter.
1998         (struct tui_source_window_base, struct tui_source_window)
1999         (struct tui_disasm_window, struct tui_data_window)
2000         (struct tui_cmd_window): Update.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-winsource.h (tui_set_exec_info_content)
2005         (tui_show_exec_info_content, tui_erase_exec_info_content)
2006         (tui_clear_exec_info_content, tui_update_exec_info): Change
2007         argument to tui_source_window_base.
2008         * tui/tui-winsource.c (tui_set_exec_info_content)
2009         (tui_show_exec_info_content, tui_erase_exec_info_content)
2010         (tui_clear_exec_info_content, tui_update_exec_info): Change
2011         argument to tui_source_window_base.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2016         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2021         check.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2026         type to void.
2027         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2028         type to void.
2029         * tui/tui-source.c (tui_set_source_content): Update.
2030         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-win.c (window_name_completer, tui_set_focus)
2035         (tui_all_windows_info): Use name method.
2036         * tui/tui-data.h (struct tui_gen_win_info)
2037         (struct tui_source_window, struct tui_disasm_window)
2038         (struct tui_data_window, struct tui_cmd_window) <name>: New
2039         method.
2040         (tui_win_name): Don't declare.
2041         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2042         (tui_win_name): Remove.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-winsource.h (tui_update_source_window)
2047         (tui_update_source_window_as_is): Change parameter type.
2048         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2049         to be a tui_source_window_base.
2050         (tui_update_source_window_as_is): Likewise.
2051         * tui/tui-win.c (make_visible_with_new_height): Update.
2052
2053 2019-06-25  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-winsource.c (tui_erase_source_content)
2056         (tui_show_source_content, tui_show_exec_info_content)
2057         (tui_erase_exec_info_content): Use refresh_window method.
2058         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2059         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2060         from tui_refresh_win.
2061         (tui_data_window::refresh_window): New method.
2062         (tui_win_info::refresh, tui_source_window_base::refresh)
2063         (tui_refresh_all): Use refresh_window method.
2064         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2065         method.
2066         * tui/tui-regs.c (tui_display_register): Call refresh_window
2067         method.
2068         * tui/tui-layout.c (show_source_disasm_command)
2069         (show_source_or_disasm_and_command): Call refresh_window method.
2070         * tui/tui-data.h (struct tui_gen_win_info)
2071         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2072         New method.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui.c (tui_rl_other_window, tui_enable)
2077         (tui_is_window_visible, tui_get_command_dimension): Update.
2078         * tui/tui-winsource.c (tui_update_source_window_as_is)
2079         (tui_clear_source_content, tui_erase_source_content)
2080         (tui_show_source_line, tui_source_window_base::refill)
2081         (tui_source_window_base::do_scroll_horizontal)
2082         (tui_source_window_base::set_is_exec_point_at)
2083         (tui_update_breakpoint_info, tui_set_exec_info_content)
2084         (tui_alloc_source_buffer, tui_line_is_displayed)
2085         (tui_addr_is_displayed): Update.
2086         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2087         (tui_check_and_display_highlight_if_needed)
2088         (tui_win_info::make_visible, tui_win_info::refresh)
2089         (tui_refresh_all): Update.
2090         * tui/tui-windata.c (tui_first_data_item_displayed)
2091         (tui_delete_data_content_windows, tui_erase_data_content)
2092         (tui_display_all_data, tui_data_window::refresh_all)
2093         (tui_check_data_values): Update.
2094         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2095         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2096         (tui_win_info::backward_scroll, tui_refresh_all_win)
2097         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2098         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2099         (tui_source_window_base::set_new_height)
2100         (tui_data_window::set_new_height)
2101         (make_invisible_and_set_new_height)
2102         (make_visible_with_new_height, new_height_ok)
2103         (parse_scrolling_args): Update.
2104         * tui/tui-stack.c (tui_show_frame_info): Update.
2105         * tui/tui-source.c (tui_set_source_content)
2106         (tui_set_source_content_nil, tui_source_is_displayed)
2107         (tui_source_window::do_scroll_vertical): Update.
2108         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2109         (tui_display_registers_from, tui_display_reg_element_at_line)
2110         (tui_check_register_values, tui_reg_command): Update.
2111         * tui/tui-layout.c (tui_default_win_height)
2112         (show_source_disasm_command, show_data, init_and_make_win)
2113         (show_source_or_disasm_and_command): Update.
2114         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2115         (tui_redisplay_readline, tui_mld_flush)
2116         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2117         (tui_getc): Update.
2118         * tui/tui-disasm.c (tui_set_disassem_content)
2119         (tui_disasm_window::do_scroll_vertical): Update.
2120         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2121         Now virtual.
2122         (struct tui_win_info): Derive from tui_gen_win_info.
2123         <~tui_win_info>: Mark as override.
2124         <generic>: Remove member.
2125         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2126         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2127         (~tui_data_window, ~tui_win_info)
2128         (tui_free_all_source_wins_content): Update.
2129         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2130
2131 2019-06-25  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-layout.c (init_and_make_win): Use new.
2134         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2135         destructor, initializers.
2136         (tui_alloc_generic_win_info): Don't declare.
2137         * tui/tui-data.c (_locator): Add argument to constructor.
2138         (source_win, disasm_win): New globals.
2139         (exec_info): Remove.
2140         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2141         Update.
2142         (tui_alloc_generic_win_info): Remove.
2143         (init_content_element): Use new.
2144         (tui_win_info::tui_win_info): Update.
2145         (free_content_elements) <case DATA_WIN>: Use delete.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2150         * tui/tui-windata.c (tui_first_data_item_displayed)
2151         (tui_delete_data_content_windows): Update.
2152         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2153         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2154         (tui_display_registers_from, tui_check_register_values): Update.
2155         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2156         pointer.
2157         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2158         window.
2159         (tui_free_data_content): Update.
2160         (free_content_elements) <case DATA_WIN>: Free the window.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2165         Update.
2166         * tui/tui-layout.c (make_command_window)
2167         (show_source_disasm_command, show_data, init_and_make_win)
2168         (show_source_or_disasm_and_command): Update.
2169         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2170         method.
2171         <can_highight, is_highlighted>: Now bool.
2172         (tui_set_win_highlight): Don't declare.
2173         * tui/tui-data.c (tui_set_win_highlight): Remove.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-wingeneral.c (make_visible): Remove check of window
2178         type.
2179
2180 2019-06-25  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-win.c (tui_win_info::max_height)
2183         (tui_cmd_window::max_height): New methods.
2184         (new_height_ok): Call max_height.
2185         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2186         <max_height>: New method.
2187
2188 2019-06-25  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-win.c (tui_source_window_base::set_new_height)
2191         (tui_data_window::set_new_height): New methods.
2192         (make_invisible_and_set_new_height): Call set_new_height method.
2193         * tui/tui-data.h (struct tui_win_info)
2194         (struct tui_source_window_base, struct tui_data_window)
2195         <set_new_height>: New method.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2200         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2201         tui_refresh_data_win.
2202         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2203         method.
2204         (tui_refresh_all_win): Call the refresh_all method.
2205         (tui_set_focus): Likewise.
2206         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2207         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2208         Likewise.
2209
2210 2019-06-25  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-winsource.h (tui_refill_source_window)
2213         (tui_set_is_exec_point_at): Don't declare.
2214         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2215         (tui_source_window_base::refill): Rename from
2216         tui_refill_source_window.
2217         (tui_source_window_base::do_scroll_horizontal): Update.
2218         (tui_source_window_base::set_is_exec_point_at): Rename from
2219         tui_set_is_exec_point_at.
2220         (tui_update_all_breakpoint_info): Update.
2221         * tui/tui-stack.c (tui_show_frame_info): Update.
2222         * tui/tui-layout.c (show_data): Add cast.
2223         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2224         * tui/tui-data.h (struct tui_source_window_base) <refill,
2225         set_is_exec_point_at>: New methods.
2226         (tui_source_windows, tui_add_to_source_windows): Update types.
2227         (tui_add_to_source_windows): Remove redundant declaration.
2228         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2229         (tui_source_windows): Change return type.
2230         (tui_clear_source_windows_detail): Update.
2231         (tui_add_to_source_windows): Change type of parameter.
2232         (tui_free_all_source_wins_content): Update.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-wingeneral.c (tui_win_info::refresh)
2237         (tui_source_window_base::refresh): New methods.
2238         (tui_refresh_all): Call the refresh method.
2239         * tui/tui-data.h (struct tui_win_info)
2240         (struct tui_source_window_base) <refresh>: New method.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui.h (tui_is_window_visible): Return bool.
2245         * tui/tui.c (tui_is_window_visible): Return bool.
2246         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2247         (tui_make_visible, tui_make_invisible)
2248         (tui_win_info::make_visible)
2249         (tui_source_window_base::make_visible, make_all_visible)
2250         (tui_make_all_visible, tui_make_all_invisible): Update.
2251         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2252         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2253         bool.
2254         (struct tui_win_info, struct tui_source_window_base)
2255         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2256         * tui/tui-data.c (tui_init_generic_part): Update.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2261         (tui_source_window_base::make_visible): New methods.
2262         (make_all_visible): Make method call.
2263         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2264         (struct tui_source_window_base, struct tui_cmd_window): Override
2265         make_visible.
2266         (tui_win_is_source_type): Don't declare.
2267         * tui/tui-data.c (tui_win_is_source_type): Remove.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2272         NULL check.
2273
2274 2019-06-25  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2277         Inline constructor.  Add initializers for members.
2278         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2279         constructors; now inline in class.
2280
2281 2019-06-25  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-regs.c (tui_show_registers): Update.
2284         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2285         bool.
2286         * tui/tui-data.c (tui_data_window::clear_detail)
2287         (tui_data_window): Update.
2288
2289 2019-06-25  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-windata.c (tui_display_all_data)
2292         (tui_display_data_from_line, tui_display_data_from)
2293         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2294         Update.
2295         * tui/tui-regs.c (tui_last_regs_line_no)
2296         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2297         (tui_show_registers, tui_show_register_group)
2298         (tui_display_registers_from, tui_display_reg_element_at_line)
2299         (tui_display_registers_from_line, tui_check_register_values)
2300         (tui_reg_next, tui_reg_prev): Update.
2301         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2302         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2303         tui_data_window.
2304         (struct tui_win_info) <detail>: Remove.  Add new fields from
2305         tui_data_info.
2306         (TUI_DATA_WIN): Add cast.
2307         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2308         (~tui_data_window): Simplify.
2309
2310 2019-06-25  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-layout.c (show_source_disasm_command)
2313         (show_source_or_disasm_and_command): Update.
2314         * tui/tui-io.c (update_cmdwin_start_line)
2315         (tui_redisplay_readline): Update.
2316         * tui/tui-data.h (struct tui_command_info): Remove.
2317         (struct tui_win_info) <detail>: Remove command_info member.
2318         (struct tui_data_window) <start_line>: New member, from
2319         tui_command_info.
2320         (TUI_CMD_WIN): Add casts.
2321
2322 2019-06-25  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-winsource.c (tui_update_source_window)
2325         (tui_refill_source_window)
2326         (tui_source_window_base::do_scroll_horizontal)
2327         (tui_update_breakpoint_info, tui_set_exec_info_content)
2328         (tui_show_exec_info_content, tui_erase_exec_info_content)
2329         (tui_clear_exec_info_content): Update.
2330         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2331         Update.
2332         * tui/tui-win.c (make_invisible_and_set_new_height)
2333         (make_visible_with_new_height): Update.
2334         * tui/tui-source.c (tui_set_source_content)
2335         (tui_show_symtab_source): Update.
2336         * tui/tui-layout.c (extract_display_start_addr)
2337         (show_source_disasm_command, show_data)
2338         (make_source_or_disasm_window)
2339         (show_source_or_disasm_and_command): Update.
2340         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2341         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2342         "gdbarch".
2343         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2344         to tui_source_window_base.
2345         (struct tui_win_info) <detail>: Remove source_info member.
2346         (struct tui_source_window_base) <has_locator>: Inline.
2347         Move contents from tui_source_info; rename has_locator member to
2348         m_has_locator.
2349         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2350         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2351         header file.
2352         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2353         Simplify.
2354         (tui_free_all_source_wins_content): Cast to
2355         tui_source_window_base.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-win.c (make_invisible_and_set_new_height)
2360         (make_visible_with_new_height): Call has_locator method.
2361         * tui/tui-layout.c (show_source_disasm_command, show_data)
2362         (show_source_or_disasm_and_command): Update for bool change.
2363         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2364         (tui_win_info) <has_locator>: New method.
2365         (struct tui_source_window_base) <has_locator>: New method.
2366         (tui_win_has_locator): Don't declare.
2367         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2368         from tui_win_has_locator.
2369         (tui_source_window_base): Use false, not FALSE.
2370
2371 2019-06-25  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2374         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2375         clear_detail method directly.
2376         (tui_clear_win_detail): Remove.
2377
2378 2019-06-25  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2381         "this", not TUI_DISASM_WIN.
2382
2383 2019-06-25  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2386         declare.
2387         * tui/tui-winsource.c
2388         (tui_source_window_base::do_scroll_horizontal): Rename from
2389         tui_horizontal_source_scroll.
2390         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2391         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2392         from tui_vertical_data_scroll.
2393         * tui/tui-win.h (tui_scroll): Don't declare.
2394         * tui/tui-win.c (tui_win_info::forward_scroll)
2395         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2396         (tui_win_info::right_scroll): Rename and update.
2397         (tui_scroll_forward_command, tui_scroll_backward_command)
2398         (tui_scroll_left_command, tui_scroll_right_command): Update.
2399         (tui_scroll): Remove.
2400         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2401         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2402         from tui_vertical_source_scroll.
2403         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2404         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2405         from tui_vertical_disassem_scroll.
2406         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2407         do_scroll_horizontal>: New methods.
2408         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2409         Likewise.
2410         (struct tui_source_window_base): Add do_scroll_horizontal.
2411         (struct tui_source_window, struct tui_disasm_window): Add
2412         do_scroll_vertical.
2413         (struct tui_data_window, struct tui_cmd_window): Add
2414         do_scroll_horizontal and do_scroll_vertical.
2415         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-data.h (struct tui_source_window_base): New struct.
2420         (struct tui_source_window): Derive from tui_source_window_base.
2421         (struct tui_disasm_window): New struct.
2422         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2423         from tui_source_window::clear_detail.
2424         (tui_source_window_base): Rename from tui_source_window.
2425         (~tui_source_window_base): Rename from ~tui_source_window.
2426         (tui_alloc_win_info): Create a tui_disasm_window.
2427
2428 2019-06-25  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui-data.h (struct tui_source_window)
2431         (struct tui_data_window): Declare destructors.
2432         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2433         destructors.
2434         (tui_win_info): Simplify.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-winsource.c (tui_display_main)
2439         (tui_update_source_windows_with_addr)
2440         (tui_update_all_breakpoint_info): Update.
2441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2442         (new_height_ok, parse_scrolling_args): Update.
2443         * tui/tui-stack.c (tui_show_frame_info): Update.
2444         * tui/tui-data.h (struct tui_list): Remove.
2445         (tui_source_windows): Return a reference to a std::vector.
2446         * tui/tui-data.c (source_windows): Now a std::vector.
2447         (tui_source_windows): Change return type.
2448         (tui_clear_source_windows): Rewrite.
2449         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2450         (tui_free_all_source_wins_content): Rewrite.
2451
2452 2019-06-25  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2455         (struct tui_data_window, struct tui_cmd_window): Declare
2456         clear_detail method.
2457         * tui/tui-data.c (tui_source_window::clear_detail)
2458         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2459         methods.
2460         (tui_clear_win_detail): Simplify.
2461
2462 2019-06-25  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-layout.c (make_source_window, make_disasm_window)
2465         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2466         Return the new window.
2467         (show_source_disasm_command, show_data)
2468         (show_source_or_disasm_and_command): Update.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2473         parameter.  Return the new window.
2474         (show_source_disasm_command): Update and remove NULL check.
2475         (show_source_or_disasm_and_command): Update.
2476
2477 2019-06-25  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-data.h (struct tui_win_info): Make constructor
2484         protected.  Make destructor virtual.  Add initializers.
2485         (tui_source_window, tui_data_window, tui_cmd_window): New
2486         classes.
2487         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2488         constructor.  Add "type" parameter.
2489         (tui_source_window, tui_data_window, tui_cmd_window): New
2490         constructors.
2491         (tui_alloc_win_info): Instantiate the appropriate subclass.
2492
2493 2019-06-25  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-win.c (tui_resize_all): Use delete.
2496         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2497         destructor.
2498         (tui_free_window): Don't declare.
2499         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2500         Update.
2501
2502 2019-06-25  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-data.h (struct tui_win_info): Add constructor.
2505         * tui/tui-data.c (tui_alloc_win_info): Use new.
2506         (tui_free_window): Use delete.
2507
2508 2019-06-22  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2511         declare.
2512         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2513
2514 2019-06-22  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2517         declare.
2518         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2519
2520 2019-06-22  Tom de Vries  <tdevries@suse.de>
2521
2522         * dwarf2read.c (create_addrmap_from_aranges)
2523         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2524         instead of '%zu'.
2525
2526 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2527
2528         * dwarf2read.h (dwarf2_section_info_def): Remove.
2529         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2530         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2531         std::vector<dwarf2_section_info>.
2532         (struct dwo_file) <~dwo_file>: Remove.
2533         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2534         types field.
2535         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2536         (dwarf2_read_debug_names): Likewise.
2537         (create_debug_types_hash_table): Change parameter type to
2538         array_view, adjust code accordingly.
2539         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2540         (partial_die_info::fixup): Likewise.
2541         (determine_prefix): Likewise.
2542         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2543
2544 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2545
2546         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2547         gdb_bfd_ref_ptr.
2548         <~dwo_file>: Remove call to gdb_bfd_unref.
2549         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2550         gdb_bfd_ref_ptr::get.
2551
2552 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2553
2554         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2555         type to htab_up.
2556         * dwarf2read.c (struct dwo_file): Initialize fields.
2557         <~dwo_file>: New.
2558         (free_dwo_file): Remove, move content to ~dwo_file.
2559         (struct dwo_file_deleter): Remove.
2560         (dwo_file_up>: Remove custom deleter.
2561         (free_dwo_files): Remove.
2562         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2563         dwo_files.
2564         (process_skeletonless_type_units): Call unique_ptr::get.
2565         (allocate_dwo_file_hash_table): Add deleter to created hash
2566         table.  Change return type to htab_up.
2567         (lookup_dwo_file_slot): Don't memset dwo_file, call
2568         unique_ptr::get.
2569         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2570         (create_dwo_unit_in_dwp_v2): Likewise.
2571         (open_and_init_dwo_file): Likewise.
2572         (free_dwo_file_from_slot): Remove.
2573
2574 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2575
2576         * dwarf2read.h (struct dwarf2_section_info) <readin,
2577         is_virtual>: Change type to bool.
2578         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2579         true instead of 1.
2580
2581 2019-06-19  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-data.h (tui_init_content_element): Don't declare.
2584
2585 2019-06-19  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-data.h (tui_init_win_info): Don't declare.
2588
2589 2019-06-19  Tom de Vries  <tdevries@suse.de>
2590
2591         * dwarf2read.h (abstract_to_concrete): Change type to
2592         std::unordered_map<sect_offset, std::vector<sect_offset>,
2593         gdb::hash_enum<sect_offset>>.
2594
2595 2019-06-19  Tom Tromey  <tromey@adacore.com>
2596
2597         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2598         EVAL_AVOID_SIDE_EFFECTS specially.
2599
2600 2019-06-19  Tom Tromey  <tromey@adacore.com>
2601
2602         * source-cache.c (highlighter): New global.
2603         (source_cache::get_source_lines): Create a highlighter on demand.
2604
2605 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * defs.h (deprecated_interactive_hook): Delete declaration.
2608         * interps.c (clear_interpreter_hooks): Remove use of
2609         deprecated_interactive_hook.
2610         * top.c (deprecated_interactive_hook): Delete definition.
2611         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2612
2613 2019-06-18  Tom de Vries  <tdevries@suse.de>
2614
2615         PR gdb/24515
2616         * dwarf2read.h (abstract_to_concrete): Change type from
2617         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2618         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2619         * dwarf2read.c (read_variable): Update.
2620         (dwarf2_fetch_die_loc_sect_off): Update.
2621
2622 2019-06-17  Tom de Vries  <tdevries@suse.de>
2623
2624         PR gdb/24617
2625         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2626         accessing parent[parent_len - 1].
2627
2628 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2629
2630         PR gdb/24364
2631         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2632         call dtrace_process_dof with NULL dof.
2633
2634 2019-06-16  Tom de Vries  <tdevries@suse.de>
2635
2636         PR gdb/24445
2637         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2638
2639 2019-06-16  Tom Tromey  <tom@tromey.com>
2640
2641         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2642         (make_all_visible): Use address of member.
2643
2644 2019-06-16  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2647         (tui_free_window, free_content, free_content_elements): Remove
2648         unnecessary cast.
2649         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2650         cast.
2651         * tui/tui-regs.c (tui_show_register_group)
2652         (tui_display_registers_from, tui_display_reg_element_at_line):
2653         Remove unnecessary cast.
2654
2655 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * linux-nat.c (normal_mask): Delete.
2658         (_initialize_linux_nat): Don't initialise normal_mask.
2659
2660 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2661
2662         PR gdb/24445
2663         * dwarf-index-write.h (write_psymtabs_to_index): Add
2664         dwz_basename parameter.
2665         * dwarf-index-write.c (write_gdbindex): Move file writing to
2666         write_gdbindex_1.  Change return type void.
2667         (assert_file_size): Move up, remove filename parameter.
2668         (write_gdbindex_1): New function.
2669         (write_debug_names): Change return type to void, call
2670         assert_file_size.
2671         (struct index_wip_file): New struct.
2672         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2673         file logic to index_wip_file.  Write index for dwz file if
2674         needed.
2675         (save_gdb_index_command): Pass basename of dwz file, if present.
2676         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2677         build-id of dwz file, if present.
2678         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2679         (dwarf2_get_dwz_file): Likewise.
2680         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2681         (dwarf2_get_dwz_file): Likewise.
2682
2683 2019-06-16  Tom Tromey  <tom@tromey.com>
2684
2685         * coffread.c (process_coff_symbol): Use xstrdup.
2686         * value.c (create_internalvar): Use xstrdup.
2687
2688 2019-06-16  Tom Tromey  <tom@tromey.com>
2689
2690         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2691         * breakpoint.c (stopin_command, stopat_command)
2692         (until_break_command, decode_location_default): Remove unnecessary
2693         cast.
2694         * utils.c (subset_compare): Remove unnecessary cast.
2695         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2696         cast.
2697         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2698         cast.
2699         * infcmd.c (path_command): Remove unnecessary cast.
2700         * coffread.c (decode_type): Remove unnecessary cast.
2701         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2702         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2703         * tui/tui-stack.c (tui_show_locator_content)
2704         (tui_show_frame_info): Remove unnecessary cast.
2705         * tui/tui-win.c (tui_scroll_forward_command)
2706         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2707         (parse_scrolling_args): Remove unnecessary cast.
2708         * tui/tui-data.c (init_win_info, tui_del_window)
2709         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2710         (free_content_elements): Remove unnecessary cast.
2711         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2712         unnecessary cast.
2713         * tui/tui-source.c (tui_set_source_content)
2714         (tui_vertical_source_scroll): Remove unnecessary cast.
2715         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2716         cast.
2717         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2718         * tui/tui-regs.c (tui_display_registers_from)
2719         (tui_display_register): Remove unnecessary cast.
2720         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2721         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2722         (make_visible): Remove unnecessary cast.
2723         * tui/tui-winsource.c (tui_erase_source_content)
2724         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2725         unnecessary cast.
2726         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2727         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2728         * stabsread.c (read_type, read_array_type, read_range_type):
2729         Remove unnecessary cast.
2730         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2731         (parse_symbol, parse_type, upgrade_type, parse_external)
2732         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2733         unnecessary cast.
2734         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2735
2736 2019-06-16  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-data.c (tui_alloc_generic_win_info)
2739         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2740         checks.
2741
2742 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2743             Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * f-typeprint.c (f_print_type): Don't return early for not
2746         associated or not allocated types.
2747         (f_type_print_varspec_suffix): Add print_rank parameter and print
2748         ranks of array types in case they dangling.
2749         (f_type_print_base): Add print_rank parameter.
2750
2751 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         * NEWS: Mention new MI commands.
2754         * break-catch-throw.c (enum exception_event_kind): Move to
2755         breakpoint.h.
2756         (print_mention_exception_catchpoint): Output text as a single
2757         message.
2758         (catch_exception_command_1): Rename to...
2759         (catch_exception_event): ...this, make non-static, update header
2760         command, and change some parameter types.
2761         (catch_catch_command): Update for changes to
2762         catch_exception_command_1.
2763         (catch_throw_command): Likewise.
2764         (catch_rethrow_command): Likewise.
2765         * breakpoint.c (enum exception_event_kind): Delete.
2766         * breakpoint.h (enum exception_event_kind): Moved here from
2767         break-catch-throw.c.
2768         (catch_exception_event): Declare.
2769         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2770         (mi_cmd_catch_throw): New function.
2771         (mi_cmd_catch_rethrow): New function.
2772         (mi_cmd_catch_catch): New function.
2773         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2774         'catch-catch' entries.
2775         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2776         (mi_cmd_catch_rethrow): Declare.
2777         (mi_cmd_catch_catch): Declare.
2778
2779 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2780
2781         * annotate.c (annotate_source_line): Change return type to void,
2782         update implementation to match.
2783         * annotate.h (annotate_source_line): Change return type to void,
2784         update header comment.
2785         * stack.c (print_frame_info): Don't change what frame information
2786         is printed based on whether annotations are on or not.
2787
2788 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2789
2790         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2791         (annotate_source): Make static.
2792         (annotate_source_line): Moved from source.c and renamed from
2793         identify_source_line.  Update the return type.
2794         * annotate.h (annotate_source): Delete declaration.
2795         (annotate_source_line): Declaration moved from source.h, and
2796         renamed from identify_source_line.  Return type updated.
2797         * source.c (identify_source_line): Moved to annotate.c and renamed
2798         to annotate_source_line.
2799         (info_line_command): Remove check of annotation_level.
2800         * source.h (identify_source_line): Move declaration to annotate.h
2801         and rename to annotate_source_line.
2802         * stack.c: Add 'annotate.h' include.
2803         (print_frame_info): Remove check of annotation_level before
2804         calling annotate_source_line.
2805
2806 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * source-cache.c (source_cache::get_plain_source_lines): Use
2809         open_source_file_with_line_charpos instead of just
2810         open_source_file, remove call to find_source_lines.
2811         (source_cache::get_source_lines): Likewise.
2812         * source.c (find_source_lines): Make static.
2813         (get_filename_and_charpos): Renamed into...
2814         (open_source_file_with_line_charpos): ..this along with changes to
2815         return a scoped_fd, and some other minor clean ups.
2816         (identify_source_line): Use open_source_file_with_line_charpos.
2817         (search_command_helper): Use open_source_file_with_line_charpos
2818         instead of just open_source_file, remove call to
2819         find_source_lines.
2820         * source.h (open_source_file_with_line_charpos): Declare new
2821         function.
2822         (find_source_lines): Delete declaration.
2823
2824 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * source.c (get_filename_and_charpos): Remove fullname
2827         parameter.
2828         (identify_source_line): Update call to get_filename_and_charpos.
2829
2830 2019-06-14  Tom Tromey  <tromey@adacore.com>
2831
2832         PR gdb/24502:
2833         * ui-style.h (skip_ansi_escape): Update comment.
2834         * ui-file.h (class no_terminal_escape_file): New class.
2835         * ui-file.c (no_terminal_escape_file::write)
2836         (no_terminal_escape_file::puts): New methods.
2837         * cli/cli-logging.c (handle_redirections): Use
2838         no_terminal_escape_file.
2839
2840 2019-06-14  Tom Tromey  <tromey@adacore.com>
2841
2842         * NEWS: Move convenience variable news above Python news.
2843
2844 2019-06-14  Tom Tromey  <tom@tromey.com>
2845
2846         * gnulib: Move directory to top-level.
2847         * configure.ac: Don't configure gnulib.
2848         * configure: Rebuild.
2849         * common/common-defs.h: Use new path to gnulib.
2850         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2851         (GNULIB_H): Remove.
2852         (INCGNU): Look in new gnulib location.
2853         (HFILES_NO_SRCDIR): Remove gnulib files.
2854         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2855         (generated_files): Remove GNULIB_H.
2856         ($(LIBGNU), all-lib): Remove targets.
2857         (distclean): Don't mention GNULIB_BUILDDIR.
2858         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2859
2860 2019-06-14  Tom Tromey  <tromey@adacore.com>
2861
2862         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2863         Warn if symbol file does not provide any symbols.
2864
2865 2019-06-14  Tom Tromey  <tromey@adacore.com>
2866
2867         * source.c (find_and_open_source): Respect basenames_may_differ.
2868
2869 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * annotate.c (annotate_breakpoints_invalid): Make use of
2872         scoped_restore_terminal_state.
2873         (annotate_frames_invalid): Likewise.
2874
2875 2019-06-14  Tom Tromey  <tromey@adacore.com>
2876
2877         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2878         allow assignment to an internalvar.
2879
2880 2019-06-14  Tom Tromey  <tromey@adacore.com>
2881
2882         * ada-lex.l: Allow "_" in attribute names.
2883
2884 2019-06-14  Tom Tromey  <tromey@adacore.com>
2885
2886         PR gdb/24653:
2887         * regcache.c (registers_changed): Don't call alloca.
2888         * top.c (execute_command): Don't call alloca.
2889
2890 2019-06-13  Pedro Alves  <palves@redhat.com>
2891
2892         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2893         'expression'.  When parsing an expression, error out if there's
2894         junk after "unlimited".
2895         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2896         (do_set_command): Adjust calls to is_unlimited_literal.
2897
2898 2019-06-13  Pedro Alves  <palves@redhat.com>
2899
2900         * compile/compile.c (make_compile_options_def_group): Add braces
2901         around array_view initializer.
2902         * thread.c (make_thread_apply_all_options_def_group)
2903         (make_thread_apply_all_options_def_group): Likewise.
2904
2905 2019-06-13  Pedro Alves  <palves@redhat.com>
2906
2907         * NEWS (New commands): Mention "maint test-options
2908         require-delimiter", "maint test-options unknown-is-error", "maint
2909         test-options unknown-is-operand" and "maint show
2910         test-options-completion-result".
2911         (New command options, command completion): New section.
2912         (Completion improvements): New section.
2913         Mention that you can abbreviate "unlimited".
2914
2915 2019-06-13  Pedro Alves  <palves@redhat.com>
2916
2917         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2918         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2919         * unittests/cli-utils-selftests.c (test_parse_flags)
2920         (test_parse_flags_qcs): Delete.
2921         (test_cli_utils): Don't call deleted functions.
2922
2923 2019-06-13  Pedro Alves  <palves@redhat.com>
2924
2925         * thread.c: Include "cli/cli-option.h".
2926         (tp_array_compar_ascending): Global.
2927         (tp_array_compar): Delete function.
2928         (tp_array_compar_ascending, tp_array_compar_descending): New
2929         functions.
2930         (ascending_option_def, qcs_flag_option_def)
2931         (thr_qcs_flags_option_defs)
2932         (make_thread_apply_all_options_def_group)
2933         (make_thread_apply_options_def_group): New.
2934         (thread_apply_all_command): Use gdb::option::process_options.
2935         (thread_apply_command_completer)
2936         (thread_apply_all_command_completer): New.
2937         (thread_apply_command): Use gdb::option::process_options.
2938         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2939         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2940         to generate help text of "thread apply".  Adjust "taas"'s help.
2941         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2942         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2943
2944 2019-06-13  Pedro Alves  <palves@redhat.com>
2945
2946         * thread.c (thread_apply_command): Check for invalid TID with
2947         isdigit instead of !isalpha.
2948
2949 2019-06-13  Pedro Alves  <palves@redhat.com>
2950
2951         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2952         (validate_flags_qcs): New.
2953         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2954         (validate_flags_qcs): Declare.
2955         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2956         (make_frame_apply_options_def_group): New.
2957         (frame_apply_command_count): Process options with
2958         gdb::option::process_options.
2959         (frame_apply_completer): New.
2960         (frame_apply_level_completer, frame_apply_all_completer)
2961         (frame_apply_completer): New.
2962         (_initialize_stack): Update help of "frame apply", "frame apply
2963         level", "frame apply all" and "faas" to mention supported options
2964         and install command completers.
2965         * stack.h (frame_apply_all_completer): Declare.
2966         * thread.c: Include "stack.h".
2967         (tfaas_command): Add "--".
2968         (_initialize_thread): Update help "tfaas" to mention supported
2969         options and install command completer.
2970
2971 2019-06-13  Pedro Alves  <palves@redhat.com>
2972
2973         * completer.c (complete_nested_command_line): New.
2974         (gdb_completion_word_break_characters_throw): Add assertion.
2975         * completer.h (complete_nested_command_line): Declare.
2976
2977 2019-06-13  Pedro Alves  <palves@redhat.com>
2978
2979         * stack.c (parse_backtrace_qualifiers): New.
2980         (backtrace_command): Use it.
2981         (backtrace_command_completer): Complete on qualifiers.
2982
2983 2019-06-13  Pedro Alves  <palves@redhat.com>
2984
2985         * frame.c: Include "cli/cli-option.h.
2986         (user_set_backtrace_options): New.
2987         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2988         Delete.
2989         (get_prev_frame): Adjust.
2990         (boolean_option_def, uinteger_option_def)
2991         (set_backtrace_option_defs): New.
2992         (_initialize_frame): Adjust and use
2993         gdb::option::add_setshow_cmds_for_options to install "set
2994         backtrace past-main" and "set backtrace past-entry".
2995         * frame.h: Include "cli/cli-option.h".
2996         (struct frame_print_options): Forward declare.
2997         (print_frame_arguments_all, print_frame_arguments_scalars)
2998         (print_frame_arguments_none): Declare.
2999         (print_entry_values): Delete declaration.
3000         (struct frame_print_options, user_frame_print_options): New.
3001         (struct set_backtrace_options): New.
3002         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3003         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3004         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3005         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3006         (list_args_or_locals): Add frame_print_options parameter.
3007         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3008         * python/py-framefilter.c (enumerate_args): Pass down
3009         USER_FRAME_PRINT_OPTIONS.
3010         * stack.c: Include "cli/cli-option.h".
3011         (print_frame_arguments_all, print_frame_arguments_scalars)
3012         (print_frame_arguments_none): Declare.
3013         (print_raw_frame_arguments, print_entry_values): Delete.
3014         (user_frame_print_options): New.
3015         (boolean_option_def, enum_option_def, frame_print_option_defs):
3016         New.
3017         (struct backtrace_cmd_options): New.
3018         (bt_flag_option_def): New.
3019         (backtrace_command_option_defs): New.
3020         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3021         (print_frame_arg, read_frame_arg, print_frame_args)
3022         (print_frame_info, print_frame): Add frame_print_options parameter
3023         and use it.
3024         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3025         (backtrace_command_1): Add frame_print_options and
3026         backtrace_cmd_options parameters and use them.
3027         (make_backtrace_options_def_group): New.
3028         (backtrace_command): Process command options with
3029         gdb::option::process_options.
3030         (backtrace_command_completer): New.
3031         (_initialize_stack): Extend "backtrace"'s help to mention
3032         supported options.  Install completer for "backtrace".
3033         Install some settings commands with add_setshow_cmds_for_options.
3034
3035 2019-06-13  Pedro Alves  <palves@redhat.com>
3036
3037         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3038         and that "set/show print raw frame-arguments" are now deprecated.
3039
3040         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3041         command.
3042         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3043         * stack.c (_initialize_stack): Install "set/show print
3044         raw-frame-arguments", and deprecate "set/show print raw
3045         frame-arguments".
3046         * valprint.c (_initialize_valprint): Deprecate "set/show print
3047         raw".
3048
3049 2019-06-13  Pedro Alves  <palves@redhat.com>
3050
3051         * compile/compile.c (struct compile_options): New.
3052         (compile_flag_option_def, compile_command_option_defs)
3053         (make_compile_options_def_group): New.
3054         (compile_file_command): Handle options with
3055         gdb::option::process_options.
3056         (compile_file_command_completer): New function.
3057         (compile_code_command): Handle options with
3058         gdb::option::process_options.
3059         (compile_code_command_completer): New function.
3060         (_initialize_compiler): Install completers for "compile code" and
3061         "compile file".  Mention available options in "compile code" and
3062         "compile code"'s help.
3063         * completer.c (advance_to_completion_word): New, factored out from
3064         ...
3065         (advance_to_expression_complete_word_point): ... this.
3066         (advance_to_filename_complete_word_point): New.
3067         * completer.h (advance_to_filename_complete_word_point): New
3068         declaration.
3069
3070 2019-06-13  Pedro Alves  <palves@redhat.com>
3071
3072         * compile/compile.c: Include "cli/cli-option.h".
3073         (compile_print_value): Scope data pointer is now a
3074         value_print_options pointer; adjust.
3075         (compile_print_command): Process options.  Scope data pointer is
3076         now a value_print_options pointer; adjust.
3077         (_initialize_compile): Update "compile print"'s help to include
3078         supported options.  Install a completer for "compile print".
3079         * cp-valprint.c (show_vtblprint, show_objectprint)
3080         (show_static_field_print): Delete.
3081         (_initialize_cp_valprint): Don't install "set print
3082         static-members", "set print vtbl", "set print object" here.
3083         * printcmd.c: Include "cli/cli-option.h" and
3084         "common/gdb_optional.h".
3085         (print_command_parse_format): Rework to fill in a
3086         value_print_options instead of a format_data.
3087         (print_value): Change parameter type from format_data pointer to
3088         value_print_options reference.  Adjust.
3089         (print_command_1): Process options.  Adjust to pass down a
3090         value_print_options.
3091         (print_command_completer): New.
3092         (_initialize_printcmd): Install print_command_completer as
3093         handle_brkchars completer for the "print" command.  Update
3094         "print"'s help to include supported options.
3095         * valprint.c: Include "cli/cli-option.h".
3096         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3097         here from cp-valprint.c.
3098         (boolean_option_def, uinteger_option_def)
3099         (value_print_option_defs, make_value_print_options_def_group):
3100         New.  Use gdb::option::add_setshow_cmds_for_options to install
3101         "set print elements", "set print null-stop", "set print repeats",
3102         "set print pretty", "set print union", "set print array", "set
3103         print address", "set print symbol", "set print array-indexes".
3104         * valprint.h: Include <string> and "cli/cli-option.h".
3105         (make_value_print_options_def_group): Declare.
3106         (print_value): Change parameter type from format_data pointer to
3107         value_print_options reference.
3108         (print_command_completer): Declare.
3109
3110 2019-06-13  Pedro Alves  <palves@redhat.com>
3111
3112         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3113         (COMMON_SFILES): Add maint-test-settings.c.
3114         * cli/cli-decode.c (boolean_enums): New global, factored out from
3115         ...
3116         (add_setshow_boolean_cmd): ... here.
3117         * cli/cli-decode.h (boolean_enums): Declare.
3118         * cli/cli-option.c: New file.
3119         * cli/cli-option.h: New file.
3120         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3121         factored out from ...
3122         (parse_cli_boolean_value(const char *)): ... this.
3123         (is_unlimited_literal): Change parameter type to pointer to
3124         pointer.  Adjust and advance ARG pointer.
3125         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3126         (parse_cli_var_enum): New, factored out from ...
3127         (do_set_command): ... this.  Adjust.
3128         * cli/cli-setshow.h (parse_cli_boolean_value)
3129         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3130         (parse_cli_var_enum): Declare.
3131         * cli/cli-utils.c: Include "cli/cli-option.h".
3132         (get_ulongest): New.
3133         * cli/cli-utils.h (get_ulongest): Declare.
3134         (check_for_argument): New overloads.
3135         * maint-test-options.c: New file.
3136
3137 2019-06-13  Pedro Alves  <palves@redhat.com>
3138
3139         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3140         parse a range if "-" is at the end of the string.
3141
3142 2019-06-13  Pedro Alves  <palves@redhat.com>
3143
3144         * cli/cli-setshow.c (parse_auto_binary_operation)
3145         (parse_cli_boolean_value): Don't allow "o".
3146
3147 2019-06-13  Pedro Alves  <palves@redhat.com>
3148
3149         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3150         * NEWS: Mention maint test-settings KIND.
3151         * maint-test-settings.c: New file.
3152
3153 2019-06-13  Pedro Alves  <palves@redhat.com>
3154
3155         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3156         completer.
3157         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3158         "set" completers.
3159
3160 2019-06-13  Pedro Alves  <palves@redhat.com>
3161
3162         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3163         after item.
3164
3165 2019-06-13  Pedro Alves  <palves@redhat.com>
3166
3167         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3168
3169 2019-06-13  Pedro Alves <palves@redhat.com>
3170
3171         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3172         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3173         call.
3174         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3175         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3176         calls.
3177         (check_for_argument): Skip spaces after argument.
3178
3179 2019-06-13  Pedro Alves  <palves@redhat.com>
3180
3181         * thread.c (thread_apply_command): Adjust TID parsing.
3182         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3183         detected before end of string.
3184         (tid_is_in_list): Error out if LIST is invalid.
3185
3186 2019-06-13  Pedro Alves  <palves@redhat.com>
3187
3188         * completer.c (complete_line_internal_1): Rewind completion word
3189         point.
3190         (completion_tracker::advance_custom_word_point_by): Change
3191         parameter type to int.
3192         * completer.h (completion_tracker::advance_custom_word_point_by):
3193         Likewise.
3194
3195 2019-06-13  Pedro Alves  <palves@redhat.com>
3196
3197         * completer.c (advance_to_completion_word): Handle delimiters.
3198
3199 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3200
3201         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3202
3203 2019-06-11  Tom Tromey  <tom@tromey.com>
3204
3205         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3206         (xmalloc_failed): Move to alloc.c.
3207         * alloc.c: New file.
3208         * Makefile.in (COMMON_SFILES): Add alloc.c.
3209
3210 2019-06-11  Tom Tromey  <tom@tromey.com>
3211
3212         * nat/linux-waitpid.c: Don't include server.h.
3213         (linux_debug): Remove.
3214         (my_waitpid): Update.
3215
3216 2019-06-11  Tom Tromey  <tromey@adacore.com>
3217
3218         * infcall.c (_initialize_infcall): Remove trailing newline from
3219         help.
3220         * user-regs.c (_initialize_user_regs): Remove trailing newline
3221         from help.
3222         * typeprint.c (_initialize_typeprint): Remove trailing newline
3223         from help.
3224         * reverse.c (_initialize_reverse): Remove trailing newlines from
3225         help.
3226         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3227         from help.
3228         * language.c (add_set_language_command): Remove trailing newline
3229         from help.
3230         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3231         help.
3232         * disasm.c (_initialize_disasm): Remove trailing newline from
3233         help.
3234         * top.c (init_main): Remove trailing newline from help.
3235         * interps.c (_initialize_interpreter): Remove trailing newline
3236         from help.
3237         * btrace.c (_initialize_btrace): Remove trailing newlines from
3238         help.
3239         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3240         from help.
3241         * python/python.c (_initialize_python): Remove trailing newline
3242         from help.
3243         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3244         help.
3245         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3246         from help.  Reformat some text.
3247         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3248         from help.
3249         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3250         newline from help.
3251
3252 2019-06-11  Tom Tromey  <tromey@adacore.com>
3253
3254         * darwin-nat.c (darwin_decode_exception_message)
3255         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3256
3257 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * valops.c (value_slice): Check for not allocated or not
3260         associated values.
3261
3262 2019-06-10  Tom de Vries  <tdevries@suse.de>
3263
3264         PR gdb/24618
3265         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3266         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3267         invalid.
3268
3269 2019-06-10  Tom de Vries  <tdevries@suse.de>
3270
3271         PR gdb/24611
3272         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3273         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3274
3275 2019-06-10  Tom de Vries  <tdevries@suse.de>
3276
3277         PR symtab/24545
3278         * symtab.c (struct demangled_name_entry): Add language field.
3279         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3280         static minimal symbol".  Set and use language field.
3281
3282 2019-06-10  Tom Tromey  <tromey@adacore.com>
3283
3284         * ada-lang.c (_initialize_ada_language): Update help text.
3285
3286 2019-06-10  Tom Tromey  <tromey@adacore.com>
3287
3288         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3289         with a newline.
3290         * guile/guile.c (handle_boot_error): Don't end warning with a
3291         newline.
3292         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3293         warning with a newline.
3294         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3295         newline.
3296         (s12z_frame_cache): Likewise.
3297         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3298         a newline.
3299         * solib-svr4.c (disable_probes_interface): Don't end warning with
3300         a newline.
3301         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3302         newline.
3303         * python/python.c (do_finish_initialization): Don't end warning
3304         with a newline.
3305
3306 2019-06-10  Tom Tromey  <tom@tromey.com>
3307
3308         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3309         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3310         gdbpy_enter.
3311
3312 2019-06-10  Tom Tromey  <tromey@adacore.com>
3313
3314         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3315         data.
3316         (elf_new_init): Don't call stabsread_new_init.
3317         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3318         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3319         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3320
3321 2019-06-10  Tom de Vries  <tdevries@suse.de>
3322
3323         PR symtab/16264
3324         PR symtab/24517
3325         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3326
3327 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3328
3329         * source.c (find_and_open_source): Also rewrite relative file
3330         names.
3331
3332 2019-04-26  Amos Bird  <amosbird@gmail.com>
3333
3334         * annotate.c (annotate_thread_exited): Add "thread-exited"
3335         annotation.
3336
3337 2019-06-06  Tom Tromey  <tromey@adacore.com>
3338
3339         * maint.h (class scoped_command_stats): Use
3340         DISABLE_COPY_AND_ASSIGN.
3341         <print_time>: New method.
3342         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3343         print_time.
3344         (scoped_command_stats::print_time): New method.
3345
3346 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3347
3348         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3349         instructions of lengths 6 or 8 bytes.
3350
3351 2019-06-04  Pedro Alves  <palves@redhat.com>
3352
3353         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3354
3355         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3356         * breakpoint.c (condition_completer): Likewise.
3357         * cli/cli-dump.c (scan_expression): Likewise.
3358         * common/filestuff.c (mkdir_recursive): Likewise.
3359         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3360         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3361         (gdb_abspath): Likewise.
3362         * compile/compile-cplus-types.c
3363         (compile_cplus_instance::decl_name): Likewise.
3364         * completer.c (complete_explicit_location):
3365         (signal_completer, reg_or_group_completer_1): Likewise.
3366         * cp-support.c (cp_remove_params_if_any): Likewise.
3367         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3368         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3369         * infcmd.c (strip_bg_char): Likewise.
3370         * linespec.c (copy_token_string): Likewise.
3371         * mi/mi-main.c (output_cores): Likewise.
3372         * psymtab.c (psymtab_search_name):
3373         * symfile.c (test_set_ext_lang_command): Likewise.
3374         * target.c (target_fileio_read_stralloc): Likewise.
3375         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3376         * value.c (complete_internalvar): Likewise.
3377
3378 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3379
3380         Add objfile property to gdb.Type.
3381         * NEWS: Mention Python API addition.
3382         * python/py-type.c (typy_get_objfile): New method.
3383
3384 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3385
3386         * NEWS: Mention the new set|show style [title|highlight].
3387         Mention changes to "show style", "help" and "apropos".
3388
3389 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3390
3391         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3392         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3393         instead of print_help_for_command.
3394         (print_doc_of_command): New function.
3395         (help_list): Add 'apropos -v word' suggestion.
3396         (print_help_for_command): Style the command name using title style.
3397         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3398         (_initialize_cli_cmds): Describe -v in apropos_command help.
3399
3400 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3401
3402         * cli/cli-style.h (cli_style_option): Add name in constructor,
3403         add m_name class member, add constructor with intensity,
3404         add name class function.
3405         (cli_style_option::add_setshow_commands): Remove name argument.
3406         (highlight_style, title_style): New styles.
3407         * cli/cli-style.c (do_show): New function that shows a style
3408         characteristic styling the style name with itself.
3409         (set_style_name): New function.
3410         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3411         Update all callers according to the changes in cli/cli-style.h.
3412         * utils.h (fputs_highlighted): New function.
3413         * utils.c (fputs_highlighted): Likewise.
3414
3415 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3416
3417         * NEWS: Mention new pipe command and new convenience variables.
3418
3419 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3420
3421         * cli/cli-cmds.c (pipe_command): New function.
3422         (_initialize_cli_cmds): Call add_com for pipe_command.
3423         Define | as an alias for pipe.
3424         (exit_status_set_internal_vars): New function.
3425         (shell_escape): Call exit_status_set_internal_vars.
3426         cli/cli-decode.c (find_command_name_length): Recognize | as
3427         a single character command.
3428
3429 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3430
3431         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3432         top.c (execute_command_to_ui_file): New function, mostly a copy
3433         of execute_command_to_string.
3434         (execute_command_to_string): Implement by calling
3435         execute_command_to_ui_file.
3436
3437 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3438
3439         * top.h (saved_command_line): Remove declaration.
3440         * top.c (previous_saved_command_line, previous_repeat_arguments):
3441         New variables.
3442         (saved_command_line): Make static, define together with other
3443         'repeat variables'.
3444         (dont_repeat): Clear repeat_arguments.
3445         (repeat_previous, get_saved_command_line, save_command_line):
3446         New functions.
3447         (gdb_init): Initialize saved_command_line
3448         and previous_saved_command_line.
3449         * main.c (captured_main_1): Remove saved_command_line initialization.
3450         * event-top.c (handle_line_of_input): Update to use
3451         the new 'repeat' related functions instead of direct access to
3452         saved_command_line.
3453         * command.h (repeat_previous, get_saved_command_line,
3454         save_command_line): New declarations.
3455         (dont_repeat): Add comment.
3456
3457 2019-05-30  Tom Tromey  <tromey@adacore.com>
3458
3459         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3460         Fix comment.
3461         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3462
3463 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3464
3465         PR cli/24587
3466         * completer.c (complete): Initialize variable word.
3467
3468 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3469
3470         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3471         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3472         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3473         'body' is NULL to the outter 'if', protecting the '!is_define'
3474         situation as well.
3475
3476 2019-05-29  Tom Tromey  <tromey@adacore.com>
3477
3478         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3479         (dwarf_unknown): New function.
3480         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3481         (dwarf_type_encoding_name): Use dwarf_unknown.
3482
3483 2019-05-29  Tom Tromey  <tromey@adacore.com>
3484
3485         PR c++/20020:
3486         * cp-valprint.c (cp_print_value_fields): Call
3487         cp_print_static_field inside "try".
3488
3489 2019-05-29  Tom Tromey  <tromey@adacore.com>
3490
3491         * inflow.c (struct terminal_info): Add default operator=.
3492         * configure: Rebuild.
3493         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3494         -Wdeprecated-copy-dtor, -Wredundant-move.
3495
3496 2019-05-29  Tom Tromey  <tromey@adacore.com>
3497
3498         * NEWS: Add entry.
3499         * infcmd.c (print_return_value_1): Handle finish_print
3500         option.
3501         (show_print_finish): New function.
3502         (_initialize_infcmd): Add "set/show print finish" commands.
3503         * valprint.c (user_print_options): Initialize new member.
3504         * valprint.h (struct value_print_options) <finish_print>: New
3505         member.
3506
3507 2019-05-28  Tom Tromey  <tromey@adacore.com>
3508
3509         * ada-lang.c (ada_remove_Xbn_suffix)
3510         (find_old_style_renaming_symbol)
3511         (parse_old_style_renaming): Remove.
3512         (ada_find_renaming_symbol): Don't call
3513         find_old_style_renaming_symbol.
3514         (ada_is_renaming_symbol): Rename from
3515         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3516         bool.  Now static.
3517         (ada_read_var_value): Update and simplify.
3518         * ada-exp.y (write_var_or_type): Remove old code.
3519
3520 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3521
3522         * event-top.c: Remove include comment.
3523         * inflow.c (class scoped_ignore_sigttou): Move from here...
3524         * inflow.h (class scoped_ignore_sigttou): ...to here.
3525         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3526         * top.c:  Remove include comment.
3527
3528 2019-05-27  Tom Tromey  <tom@tromey.com>
3529
3530         * NEWS: Fix typo.
3531
3532 2019-05-22  Tom Tromey  <tromey@adacore.com>
3533
3534         * target.c (target_follow_exec): Constify parameter.
3535         * target-delegates.c: Rebuild.
3536         * remote.c (remote_target::follow_exec): Constify parameter.
3537         * infrun.c (follow_exec): Constify parameter.
3538         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3539         (target_follow_exec): Likewise.
3540
3541 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3542
3543         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3544         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3545
3546 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3547
3548         * NEWS: Add debugredirect and testsuite sections.
3549
3550 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3551
3552         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3553         target descriptions using exclusively floating point register name
3554         aliases.
3555
3556 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3557
3558         PR gdb/18644:
3559         * f-lang.c (build_fortran_types): Handle the case where
3560         gdbarch_floatformat_for_type returns a nullptr.
3561
3562 2019-05-21  Tom de Vries  <tdevries@suse.de>
3563
3564         PR cli/24587
3565         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3566
3567 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         PR gdb/18644:
3570         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3571         16-byte floats.
3572         * i386-tdep.c (i386_floatformat_for_type): Use
3573         floatformats_ia64_quad for the 16-byte floating point component
3574         within a fortran 32-byte complex number.
3575
3576 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3577
3578         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3579         delete default constructor.
3580         (find_partial_die): Update to return const struct.
3581         (partial_die_parent_scope): Move variable declaration into scope
3582         of its use and change its type to auto.
3583         (guess_partial_die_structure_name): Likewise.
3584         (partial_die_info::fixup): Likewise.
3585
3586 2019-05-17  Tom Tromey  <tromey@adacore.com>
3587
3588         * source.c (find_and_open_source): Remove cast.
3589
3590 2019-05-17  Tom Tromey  <tromey@adacore.com>
3591
3592         * annotate.c (annotate_source): Make "filename" const.
3593         * annotate.h (annotate_source): Use const.
3594
3595 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3596
3597         * disasm.c (set_disassembler_options): Send errors to stderr.
3598
3599 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3600
3601         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3602         (cli_interp_base::set_logging): Check debug_redirect.
3603         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3604         * cli/cli-logging.c (debug_redirect): Add static variable.
3605         (pop_output_files): Add default param.
3606         (handle_redirections): Print debug setting.
3607         (show_logging_command): Likewise.
3608         (_initialize_cli_logging): Add debugredirect command.
3609         * interps.c (current_interp_set_logging): Add debug_redirect
3610         parameter.
3611         * interps.h (set_logging): Add debug_redirect parameter.
3612         (current_interp_set_logging): Likewise.
3613         * mi/mi-common.h: Likewise.
3614         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3615
3616 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3617             Tom Tromey  <tromey@adacore.com>
3618
3619         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3620         directly.
3621         * cli/cli-interp.h (make_logging_output): Remove declaration.
3622         * cli/cli-logging.c (make_logging_output): Remove function.
3623         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3624         directly.
3625         * ui-file.c (tee_file::tee_file): Remove bools.
3626         (tee_file::~tee_file): Remove deletes.
3627         * ui-file.h (tee_file): Remove bools.
3628
3629 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3630
3631         * mi/mi-cmds.h (mi_cmd_complete): New function.
3632         * mi/mi-main.c (mi_cmd_complete): Likewise.
3633         * mi/mi-cmds.c: Define new MI command -complete.
3634         * NEWS: Mention new -complete command.
3635
3636 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3637
3638         * completer.h (complete): New function.
3639         * completer.c (complete): Likewise.
3640         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3641         function defined in completer.h.
3642
3643 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3644
3645         * MAINTAINERS (Write After Approval): Add myself.
3646
3647 2019-05-17  Tom de Vries  <tdevries@suse.de>
3648
3649         PR gdb/24094
3650         * dwarf2read.c (struct cu_partial_die_info): New struct.
3651         (find_partial_die): Return cu_partial_die_info.
3652         (partial_die_parent_scope, guess_partial_die_structure_name)
3653         (partial_die_info::fixup): Handle new return type of find_partial_die.
3654
3655 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3656
3657         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3658         "std::string", simplifying the algorithm.
3659
3660 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3661
3662         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3663         (stap_static_probe_ops::get_probes): Likewise.
3664
3665 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3666
3667         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3668         '-')" and "else if".
3669         (stap_parse_single_operand): Join checks for
3670         "gdbarch_stap_parse_special_token_p" and
3671         "gdbarch_stap_parse_special_token" in the same "if" statement.
3672         Invert check when verifying for operation on register
3673         displacement.
3674
3675 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3676
3677         * stap-probe.c (stap_get_opcode): Update comment.
3678         (stap_get_expected_argument_type): Likewise.
3679         (handle_stap_probe): Likewise.
3680
3681 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3682
3683         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3684         return type to 'bool'.  Adjust comment.  Use 'bool' when
3685         appropriate.
3686         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3687         * stap-probe.c (stap_parse_argument_1): Likewise.
3688         (stap_is_operator): Likewise.
3689         (stap_is_generic_prefix): Likewise.
3690         (stap_is_register_prefix): Likewise.
3691         (stap_is_register_indirection_prefix): Likewise.
3692         (stap_is_integer_prefix): Likewise.
3693         (stap_generic_check_suffix): Likewise.
3694         (stap_check_integer_suffix): Likewise.
3695         (stap_check_register_suffix): Likewise.
3696         (stap_check_register_indirection_suffix): Likewise.
3697         (stap_parse_register_operand): Likewise.
3698         (stap_parse_single_operand): Likewise.
3699         (stap_parse_argument_1): Likewise.
3700         (stap_probe::get_argument_count): Likewise.
3701         (stap_is_operator): Likewise.
3702
3703 2019-05-16  Tom Tromey  <tromey@adacore.com>
3704
3705         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3706         keyword to foreach.
3707
3708 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3709
3710         * linux-thread-db.c (try_thread_db_load_1): Change return type
3711         to bool.
3712         (try_thread_db_load): Likewise.
3713         (try_thread_db_load_from_pdir_1): Likewise.
3714         (try_thread_db_load_from_pdir): Likewise.
3715         (try_thread_db_load_from_sdir): Likewise.
3716         (try_thread_db_load_from_dir): Likewise.
3717         (thread_db_load_search): Likewise.
3718         (has_libpthread): Likewise.
3719         (thread_db_load): Likewise.
3720
3721 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3722
3723         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3724         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3725         NULL, and complain/return if that's the case.
3726
3727 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3728
3729         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3730         (advance, posn, abstract_read_memory): New functions.
3731         [struct mem_read_abstraction]: New struct.
3732         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3733
3734 2019-05-14  Tom Tromey  <tromey@adacore.com>
3735
3736         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3737         value is not lval_memory.
3738
3739 2019-05-14  Tom Tromey  <tromey@adacore.com>
3740
3741         * solib.c (info_sharedlibrary_command): Style the file name.
3742
3743 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3744
3745         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3746         (aarch64_vnv_type): Likewise.
3747         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3748         * common/tdesc.c: Likewise.
3749         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3750         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3751         * features/aarch64-fpu.xml: Add ieee half view.
3752         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3753         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3754         * gdbtypes.h (struct builtin_type): Likewise.
3755         (struct objfile_type): Likewise.
3756
3757 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3758
3759         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3760         typo.
3761         * location.h (string_to_event_location): Likewise.
3762
3763 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3764
3765         GDB 8.3 released.
3766
3767 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3768
3769         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3770         New variable declaration.
3771         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3772         New variable.
3773         (print_one_breakpoint): Use ui_out::test_flags and new global
3774         variable to compute use_fixed_output.
3775         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3776         Remove.
3777         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3778         (mi_multi_location_breakpoint_output_fixed): Remove.
3779         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3780         new variable.
3781         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3782         fix_multi_location_breakpoint_output flag if version >= 3.
3783         * ui-out.h (enum ui_out_flag)
3784         <fix_multi_location_breakpoint_output>: New enumerator.
3785
3786 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3787
3788         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3789
3790 2019-05-10  Tom Tromey  <tromey@adacore.com>
3791
3792         * ada-lang.c (catch_ada_completer): New function.
3793         (_initialize_ada_language): Use it.
3794
3795 2019-05-10  Tom Tromey  <tromey@adacore.com>
3796
3797         * thread.c (print_thread_info): Make "requested_threads" const.
3798         * gdbthread.h (print_thread_info): Make "requested_threads"
3799         const.
3800         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3801         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3802
3803 2019-05-08  Tom Tromey  <tom@tromey.com>
3804
3805         * gdbtypes.c (objfile_type_data): Change type.
3806         (objfile_type, _initialize_gdbtypes): Update.
3807
3808 2019-05-08  Tom Tromey  <tom@tromey.com>
3809
3810         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3811         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3812         (_initialize_dwarf2_frame): Update.
3813
3814 2019-05-08  Tom Tromey  <tom@tromey.com>
3815
3816         * objc-lang.c (objc_objfile_data): Change type.
3817         (find_methods): Update.
3818         (_initialize_objc_lang): Remove.
3819
3820 2019-05-08  Tom Tromey  <tom@tromey.com>
3821
3822         * stabsread.c (rs6000_builtin_type_data): Change type.
3823         (rs6000_builtin_type, _initialize_stabsread): Update.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * mips-tdep.c (mips_pdr_data): Remove.
3828         (_initialize_mips_tdep): Update.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3833         (hppa_init_objfile_priv_data, read_unwind_info)
3834         (find_unwind_entry, _initialize_hppa_tdep): Update.
3835
3836 2019-05-08  Tom Tromey  <tom@tromey.com>
3837
3838         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3839         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3840         on obstack.
3841         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3842
3843 2019-05-08  Tom Tromey  <tom@tromey.com>
3844
3845         * mdebugread.c (basic_type_data): Change type.
3846         (basic_type, _initialize_mdebugread): Update.
3847
3848 2019-05-08  Tom Tromey  <tom@tromey.com>
3849
3850         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * nto-tdep.c (nto_inferior_data_reg): Change type.
3855         (nto_inferior_data): Update.
3856         (nto_inferior_data_cleanup, nto_new_inferior_data)
3857         (_initialize_nto_tdep): Remove.
3858         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3859
3860 2019-05-08  Tom Tromey  <tom@tromey.com>
3861
3862         * ada-lang.c (struct ada_inferior_data): Add initializers.
3863         (ada_inferior_data): Change type.
3864         (ada_inferior_data_cleanup): Remove.
3865         (get_ada_inferior_data, ada_inferior_exit)
3866         (struct ada_pspace_data): Add initializers, destructor.
3867         (ada_pspace_data_handle): Change type.
3868         (get_ada_pspace_data): Update.
3869         (ada_pspace_data_cleanup): Remove.
3870
3871 2019-05-08  Tom Tromey  <tom@tromey.com>
3872
3873         * coffread.c (struct coff_symfile_info): Add initializers.
3874         (coff_objfile_data_key): Move lower.  Change type.
3875         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3876         Update.
3877         (coff_free_info): Remove.
3878
3879 2019-05-08  Tom Tromey  <tom@tromey.com>
3880
3881         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3882         (fbsd_pspace_data_handle): Move lower.  Change type.
3883         (get_fbsd_pspace_data): Update.
3884         (fbsd_pspace_data_cleanup): Remove.
3885         (_initialize_fbsd_tdep): Update.
3886
3887 2019-05-08  Tom Tromey  <tom@tromey.com>
3888
3889         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3890         (get_ada_tasks_pspace_data): Update.
3891         (ada_tasks_pspace_data_cleanup): Remove.
3892         (_initialize_tasks): Update.
3893         (ada_tasks_inferior_data_handle): Change type.
3894         (get_ada_tasks_inferior_data): Update.
3895         (ada_tasks_inferior_data_cleanup): Remove.
3896         (struct ada_tasks_pspace_data): Add initializers.
3897
3898 2019-05-08  Tom Tromey  <tom@tromey.com>
3899
3900         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3901         * symfile-debug.c (debug_sym_get_probes): Change type.
3902         * stap-probe.c (handle_stap_probe):
3903         (stap_static_probe_ops::get_probes): Change type.
3904         * probe.h (class static_probe_ops) <get_probes>: Change type.
3905         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3906         (parse_probes_in_pspace): Update.
3907         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3908         Update.
3909         (any_static_probe_ops::get_probes): Change type.
3910         * elfread.c (elfread_data): New typedef.
3911         (probe_key): Change type.
3912         (elf_get_probes): Likewise.  Update.
3913         (probe_key_free): Remove.
3914         (_initialize_elfread): Update.
3915         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3916         Change type.
3917         (dtrace_process_dof_probe, dtrace_process_dof)
3918         (dtrace_static_probe_ops::get_probe): Change type.
3919
3920 2019-05-08  Tom Tromey  <tom@tromey.com>
3921
3922         * xcoffread.c (struct xcoff_symfile_info): Rename from
3923         coff_symfile_info.  Add initializers.
3924         (xcoff_objfile_data_key): Move lower.  Change type.
3925         (XCOFF_DATA): Rewrite.
3926         (xcoff_free_info): Remove.
3927         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3928         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3929         (xcoff_initial_scan): Update.
3930
3931 2019-05-08  Tom Tromey  <tom@tromey.com>
3932
3933         * solib-svr4.c (struct svr4_info): Add initializers and
3934         destructor.
3935         <probes_table>: Now an htab_up.
3936         (solib_svr4_pspace_data): Change type.
3937         (free_probes_table): Simplify.
3938         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3939         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3940         (probes_table_remove_objfile_probes, register_solib_event_probe)
3941         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3942         (_initialize_svr4_solib): Update.
3943
3944 2019-05-08  Tom Tromey  <tom@tromey.com>
3945
3946         * remote.c (remote_pspace_data): Change type.
3947         (remote_pspace_data_cleanup): Remove.
3948         (get_remote_exec_file, set_pspace_remote_exec_file)
3949         (_initialize_remote): Update.
3950
3951 2019-05-08  Tom Tromey  <tom@tromey.com>
3952
3953         * breakpoint.c (breakpoint_objfile_key): Change type.
3954         (get_breakpoint_objfile_data): Update.
3955         (free_breakpoint_objfile_data): Remove.
3956         (_initialize_breakpoint): Update.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * linux-tdep.c (struct linux_info): Add initializers.
3961         (linux_inferior_data): Move.  Change type.
3962         (invalidate_linux_cache_inf): Update.
3963         (linux_inferior_data_cleanup): Remove.
3964         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3965
3966 2019-05-08  Tom Tromey  <tom@tromey.com>
3967
3968         * auxv.c (auxv_inferior_data): Move.  Change type.
3969         (auxv_inferior_data_cleanup): Remove.
3970         (invalidate_auxv_cache_inf): Rewrite.
3971         (get_auxv_inferior_data, _initialize_auxv): Update.
3972
3973 2019-05-08  Tom Tromey  <tom@tromey.com>
3974
3975         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3976         (symfile_debug_objfile_data_key): Change type.
3977         (symfile_debug_installed, debug_qf_has_symbols)
3978         (debug_qf_find_last_source_symtab)
3979         (debug_qf_forget_cached_source_info)
3980         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3981         (debug_qf_print_stats, debug_qf_dump)
3982         (debug_qf_expand_symtabs_for_function)
3983         (debug_qf_expand_all_symtabs)
3984         (debug_qf_expand_symtabs_with_fullname)
3985         (debug_qf_map_matching_symbols)
3986         (debug_qf_expand_symtabs_matching)
3987         (debug_qf_find_pc_sect_compunit_symtab)
3988         (debug_qf_map_symbol_filenames)
3989         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3990         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3991         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3992         (debug_sym_read_linetable, debug_sym_relocate): Update.
3993         (symfile_debug_free_objfile): Remove.
3994         (install_symfile_debug_logging, _initialize_symfile_debug):
3995         Update.
3996
3997 2019-05-08  Tom Tromey  <tom@tromey.com>
3998
3999         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4000         allocate_on_obstack.
4001         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4002         (get_dwarf2_per_objfile): Update.
4003         (set_dwarf2_per_objfile): Remove.
4004         (dwarf2_has_info, dwarf2_get_section_info): Update.
4005         (dwarf2_free_objfile): Remove.
4006         (_initialize_dwarf2_read): Update.
4007
4008 2019-05-08  Tom Tromey  <tom@tromey.com>
4009
4010         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4011         initializers.
4012         <unsupported_script_warning_printed,
4013         script_not_found_warning_printed>: Now bool.
4014         (auto_load_pspace_data): Change type.
4015         (~auto_load_pspace_info): Rename from
4016         auto_load_pspace_data_cleanup.
4017         (get_auto_load_pspace_data, init_loaded_scripts_info)
4018         (clear_section_scripts, maybe_print_unsupported_script_warning)
4019         (maybe_print_script_not_found_warning, _initialize_auto_load):
4020         Update.
4021
4022 2019-05-08  Tom Tromey  <tom@tromey.com>
4023
4024         * objfiles.c (objfile_pspace_info): Add destructor and
4025         initializers.
4026         (objfiles_pspace_data): Change type.
4027         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4028         (get_objfile_pspace_data): Update.
4029         (objfiles_bfd_data): Change type.
4030         (get_objfile_bfd_data): Update.
4031         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4032
4033 2019-05-08  Tom Tromey  <tom@tromey.com>
4034
4035         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4036         Change type.
4037         (get_catch_syscall_inferior_data): Update.
4038         (catch_syscall_inferior_data_cleanup): Remove.
4039         (_initialize_break_catch_syscall): Update.
4040
4041 2019-05-08  Tom Tromey  <tom@tromey.com>
4042
4043         * inflow.c (struct terminal_info): Add destructor and
4044         initializers.
4045         (inflow_inferior_data): Change type.
4046         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4047         (get_inflow_inferior_data, inflow_inferior_exit)
4048         (swap_terminal_info, _initialize_inflow): Update.
4049
4050 2019-05-08  Tom Tromey  <tom@tromey.com>
4051
4052         * target-dcache.c (target_dcache_cleanup): Remove.
4053         (target_dcache_aspace_key): Change type.
4054         (target_dcache_init_p, target_dcache_invalidate)
4055         (target_dcache_get, target_dcache_get_or_init)
4056         (_initialize_target_dcache): Update.
4057         * dcache.h (struct dcache_deleter): New.
4058
4059 2019-05-08  Tom Tromey  <tom@tromey.com>
4060
4061         * symtab.c (struct symbol_cache): Add destructor and
4062         initializers.
4063         (symbol_cache_key): Move.  Change type.
4064         (make_symbol_cache, free_symbol_cache): Remove.
4065         (get_symbol_cache): Update.
4066         (symbol_cache_cleanup): Remove.
4067         (ALL_PSPACES, symbol_cache_flush)
4068         (maintenance_print_symbol_cache)
4069         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4070         Update.
4071
4072 2019-05-08  Tom Tromey  <tom@tromey.com>
4073
4074         * symtab.c (struct main_info): Add destructor and initializers.
4075         (main_progspace_key): Move.  Change type.
4076         (get_main_info): Update.
4077         (main_info_cleanup): Remove.
4078         (_initialize_symtab): Update.
4079
4080 2019-05-08  Tom Tromey  <tom@tromey.com>
4081
4082         * registry.h (DECLARE_REGISTRY): Define the _key class.
4083
4084 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * NEWS: Merge two 'New commands' sections.
4087
4088 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4089
4090         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4091         parameter and use Ada language definition instead.
4092         (ada_val_print_ptr): Remove unused language parameter.
4093         (ada_val_print_num): Remove language parameter and use Ada language
4094         definition instead.
4095         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4096         parameter.
4097         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4098         parameter and use Ada language definition instead.
4099         (ada_val_print_1): Update all ada_val_print_xxx calls.
4100         Remove language parameter.
4101         (ada_val_print): Update ada_val_print_1 call.
4102
4103 2019-05-08  Tom Tromey  <tromey@adacore.com>
4104
4105         * remote.c (remote_hw_watchpoint_limit)
4106         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4107         Now static.
4108
4109 2019-05-08  Tom Tromey  <tromey@adacore.com>
4110
4111         * maint.c (_initialize_maint_cmds): Move initialization code to
4112         remote.c.
4113         (watchdog, show_watchdog): Move to remote.c.
4114         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4115         "watchdog" static.
4116         (_initialize_remote): Move initialization code from maint.c.
4117         * defs.h (watchdog): Don't declare.
4118
4119 2019-05-08  Tom Tromey  <tromey@adacore.com>
4120
4121         * tui/tui-interp.c: Include main.h.
4122         * interps.c: Include main.h.
4123         * main.h (interpreter_p): Declare.
4124         * defs.h (interpreter_p): Don't declare.
4125
4126 2019-05-08  Tom Tromey  <tromey@adacore.com>
4127
4128         * dwarf2loc.c: Include dwarf2read.h.
4129         * defs.h (read_unsigned_leb128): Don't declare.
4130         * dwarf2read.h (read_unsigned_leb128): Declare.
4131
4132 2019-05-08  Tom Tromey  <tromey@adacore.com>
4133
4134         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4135         method.
4136
4137 2019-05-08  Tom Tromey  <tromey@adacore.com>
4138
4139         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4140         when no wrap column is set.
4141
4142 2019-05-08  Tom Tromey  <tromey@adacore.com>
4143
4144         * c-lang.c (c_get_string): Handle non-C-style arrays.
4145
4146 2019-05-08  Tom Tromey  <tromey@adacore.com>
4147
4148         * typeprint.c (print_offset_data::update): Print the bit offset,
4149         not the number of bits remaining.
4150
4151 2019-05-08  Tom Tromey  <tromey@adacore.com>
4152
4153         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4154         padding at end of comment.
4155
4156 2019-05-08  Tom Tromey  <tromey@adacore.com>
4157
4158         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4159         Compare main types.
4160
4161 2019-05-06  Tom Tromey  <tom@tromey.com>
4162
4163         * common/scoped_mmap.c: Include common-defs.h.
4164         * common/scoped_mmap.h: Don't include config.h.
4165
4166 2019-05-04  Tom Tromey  <tom@tromey.com>
4167
4168         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4169         (struct aarch64_call_info): Add initializers.
4170         <si>: Now a std::vector.
4171         (pass_on_stack, aarch64_push_dummy_call): Update.
4172
4173 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4174             Tom Tromey  <tom@tromey.com>
4175
4176         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4177         (ppc_threads): Now a std::vector.  Now static.
4178         (hwdebug_find_thread_points_by_tid)
4179         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4180         Update.
4181
4182 2019-05-04  Tom Tromey  <tom@tromey.com>
4183
4184         * arc-tdep.c (arc_tdesc_init): Return bool.
4185
4186 2019-05-04  Tom Tromey  <tom@tromey.com>
4187
4188         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4189         Use gdb_assert_not_reached.
4190
4191 2019-05-04  Tom Tromey  <tom@tromey.com>
4192
4193         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4194         "false".
4195
4196 2019-05-04  Tom Tromey  <tom@tromey.com>
4197
4198         * arc-tdep.c (arc_tdesc_init): Use bool.
4199
4200 2019-05-04  Tom Tromey  <tom@tromey.com>
4201
4202         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4203
4204 2019-05-04  Tom Tromey  <tom@tromey.com>
4205
4206         * cli/cli-cmds.c (valid_command_p): Return bool.
4207
4208 2019-05-04  Tom Tromey  <tom@tromey.com>
4209
4210         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4211         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4212
4213 2019-05-04  Raul Tambre  <raul@tambre.ee>
4214
4215         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4216         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4217         operator for comparison.
4218
4219 2019-05-04  Tom Tromey  <tom@tromey.com>
4220
4221         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4222         (lookup_partial_symbol, print_partial_symbols)
4223         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4224         (psymbol_compare): Update.
4225         (add_psymbol_to_bcache): Clear the entire psymbol.
4226         (maintenance_check_psymtabs): Update.
4227         * psympriv.h (struct partial_symbol): Don't derive from
4228         general_symbol_info.
4229         <obj_section, unrelocated_address, address,
4230         set_unrelocated_address>: Update.
4231         <ginfo>: New member.
4232         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4233         (debug_names::write_psymbols): Update.
4234
4235 2019-05-04  Tom de Vries  <tdevries@suse.de>
4236
4237         * contrib/cc-with-tweaks.sh: Support -n arg.
4238
4239 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240
4241         * corelow.c (core_target::detach): Ensure frame cache and
4242         register caches are cleared.
4243         inferior.c (exit_inferior_1): Likewise.
4244
4245 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4246             Tom Tromey  <tom@tromey.com>
4247
4248         * dictionary.c (collate_pending_symbols_by_language): Remove
4249         "struct" from foreach.
4250         * symtab.c (lookup_global_symbol_from_objfile)
4251         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4252         foreach.
4253         * ser-tcp.c (net_open): Remove "struct" from foreach.
4254         * objfiles.c (objfile_relocate, objfile_rebase)
4255         (objfile_has_symbols): Remove "struct" from foreach.
4256         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4257         from foreach.
4258         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4259         foreach.
4260         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4261         "struct" from foreach.
4262         * ada-lang.c (create_excep_cond_exprs)
4263         (ada_exception_catchpoint_cond_string): Remove "struct" from
4264         foreach.
4265
4266 2019-05-03  Tom Tromey  <tromey@adacore.com>
4267
4268         * ada-exp.y (convert_char_literal): Check suffix of each
4269         enumerator.
4270
4271 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4272
4273         PR ada/21406:
4274         * ada-exp.y (yywrap): Don't define.
4275         * ada-lex.l (%option): Add noyywrap
4276         (yywrap): Remove.
4277
4278 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4279
4280         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4281         _WIN32_WINNT to the XP level, unless already defined to a higher
4282         level.
4283
4284         * unittests/parse-connection-spec-selftests.c:
4285         * ser-tcp.c:
4286         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4287         override.
4288
4289         * symfile.c (find_separate_debug_file): Remove colon from the
4290         drive spec of DOS/Windows file names of the target, so that the
4291         file name produced from DEBUGDIR and the target's directory will
4292         be valid on DOS/Windows systems.
4293
4294 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * rust-lang.c (val_print_struct): Handle printing structures
4297         containing strings.
4298
4299 2019-05-02  Tom Tromey  <tromey@adacore.com>
4300
4301         * valarith.c (_initialize_valarith): Remove.
4302
4303 2019-05-01  Tom Tromey  <tromey@adacore.com>
4304
4305         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4306         bitfields.
4307
4308 2019-05-01  Tom Tromey  <tromey@adacore.com>
4309
4310         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4311         for big-endian copies.
4312
4313 2019-04-30  Ali Tamur  <tamur@google.com>
4314         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4315         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4316         (read_3_bytes): New function.
4317
4318 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4319
4320         * windows-nat.c (main_thread_id): Delete.
4321         (handle_output_debug_string): Replace main_thread_id by
4322         current_event.dwThreadId.
4323         (fake_create_process): Likewise.
4324         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4325         Do not set main_thread_id.
4326         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4327         current_event.dwThreadId.
4328         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4329
4330 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4331
4332         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4333         Use current_event.dwThreadId instead of main_thread_id.
4334
4335 2019-04-30  Tom Tromey  <tromey@adacore.com>
4336
4337         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4338         (create_excep_cond_exprs): Iterate over program spaces.
4339         (ada_exception_catchpoint_cond_string): Examine all minimal
4340         symbols for exception types.
4341
4342 2019-04-30  Tom Tromey  <tromey@adacore.com>
4343
4344         PR c++/24470:
4345         * dwarf2read.c (process_structure_scope): Handle case where type
4346         has template parameters but no symbol was created.
4347
4348 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4349             Chris January  <chris.january@arm.com>
4350
4351         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4352         qualifier.
4353         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4354
4355 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * f-typeprint.c (f_print_type): Update rules for printing
4358         whitespace.
4359         (f_type_print_varspec_suffix): Likewise.
4360
4361 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4362             Chris January  <chris.january@arm.com>
4363
4364         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4365         function arguments.
4366
4367 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * f-lang.c (build_fortran_types): Change name of void type to
4370         lower case.
4371         * f-typeprint.c (f_type_print_base): Print the name of the void
4372         type, rather than a fixed string.
4373         * f-valprint.c (f_decorations): Use lower case void string.
4374
4375 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4376             Chris January  <chris.january@arm.com>
4377
4378         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4379         types for Fortran.
4380
4381 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4382             Chris January  <chris.january@arm.com>
4383             David Lecomber  <david.lecomber@arm.com>
4384
4385         * f-exp.y (BINOP_INTRINSIC): New token.
4386         (exp): New parser rule handling BINOP_INTRINSIC.
4387         (f77_keywords): Add new builtin procedures.
4388         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4389         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4390         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4391         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4392         (print_unop_subexp_f): New function.
4393         (print_binop_subexp_f): New function.
4394         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4395         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4396         (dump_subexp_body_f): Likewise.
4397         (operator_check_f): Likewise.
4398         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4399         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4400
4401 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4404         UNOP_KIND.
4405         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4406         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4407         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4408         (operator_length_f): New fuction.
4409         (print_subexp_f): New function.
4410         (op_name_f): New function.
4411         (dump_subexp_body_f): New function.
4412         (operator_check_f): New function.
4413         (exp_descriptor_f): Replace standard expression handling functions
4414         with new functions.
4415         * gdb/fortran-operator.def: New file.
4416         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4417         * gdb/std-operator.def: Remove UNOP_KIND.
4418
4419 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * std-operator.def: Remove unbalanced, stray double quote
4422         character.
4423
4424 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4425             Chris January  <chris.january@arm.com>
4426             Daniel Everett  <daniel.everett@arm.com>
4427             Nick Forrington  <nick.forrington@arm.com>
4428             Richard Bunt  <richard.bunt@arm.com>
4429
4430         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4431         of depth when printing anonymous structs or unions.
4432         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4433         Don't print either the top-level value, or the children if the
4434         max-depth is exceeded.
4435         (ppscm_print_children): When printing the key of a map, allow one
4436         extra level of depth.
4437         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4438         print either the top-level value, or the children if the max-depth
4439         is exceeded.
4440         (print_children): When printing the key of a map, allow one extra
4441         level of depth.
4442         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4443         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4444         (user_print_options): Initialise max_depth field.
4445         (val_print_scalar_or_string_type_p): New function.
4446         (val_print): Check to see if the max depth has been reached.
4447         (val_print_check_max_depth): Define new function.
4448         (show_print_max_depth): New function.
4449         (_initialize_valprint): Add 'print max-depth' option.
4450         * valprint.h (struct value_print_options) <max_depth>: New field.
4451         (val_print_check_max_depth): Declare new function.
4452         * NEWS: Document new feature.
4453
4454 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * ada-lang.c (ada_language_defn): Initialise new field.
4457         * c-lang.c (c_is_string_type_p): New function.
4458         (c_language_defn): Initialise new field.
4459         (cplus_language_defn): Initialise new field.
4460         (asm_language_defn): Initialise new field.
4461         (minimal_language_defn): Initialise new field.
4462         * c-lang.h (c_is_string_type_p): Declare new function.
4463         * d-lang.c (d_language_defn): Initialise new field.
4464         * f-lang.c (f_is_string_type_p): New function.
4465         (f_language_defn): Initialise new field.
4466         * go-lang.c (go_is_string_type_p): New function.
4467         (go_language_defn): Initialise new field.
4468         * language.c (default_is_string_type_p): New function.
4469         (unknown_language_defn): Initialise new field.
4470         (auto_language_defn): Initialise new field.
4471         * language.h (struct language_defn) <la_is_string_type_p>: New
4472         member variable.
4473         (default_is_string_type_p): Declare new function.
4474         * m2-lang.c (m2_language_defn): Initialise new field.
4475         * objc-lang.c (objc_language_defn): Initialise new field.
4476         * opencl-lang.c (opencl_language_defn): Initialise new field.
4477         * p-lang.c (pascal_is_string_type_p): New function.
4478         (pascal_language_defn): Initialise new field.
4479         * rust-lang.c (rust_is_string_type_p): New function.
4480         (rust_language_defn): Initialise new field.
4481
4482 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4483
4484         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4485         New field.
4486         * ada-lang.c (ada_language_defn): Initialise new field.
4487         * c-lang.c (c_language_defn): Likewise.
4488         (cplus_language_defn): Likewise.
4489         (asm_language_defn): Likewise.
4490         (minimal_language_defn): Likewise.
4491         * d-lang.c (d_language_defn): Likewise.
4492         * f-lang.c (f_language_defn): Likewise.
4493         * go-lang.c (go_language_defn): Likewise.
4494         * language.c (unknown_language_defn): Likewise.
4495         (auto_language_defn): Likewise.
4496         * m2-lang.c (m2_language_defn): Likewise.
4497         * objc-lang.c (objc_language_defn): Likewise.
4498         * opencl-lang.c (opencl_language_defn): Likewise.
4499         * p-lang.c (pascal_language_defn): Likewise.
4500         * rust-lang.c (rust_language_defn): Likewise.
4501
4502 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * ada-lang.c (ada_is_character_type): Change return type to bool.
4505         (ada_is_string_type): Likewise.
4506         * ada-lang.h (ada_is_character_type): Update declaration
4507         (ada_is_string_type): Likewise.
4508
4509 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4510
4511         Support style in 'frame|thread apply'
4512
4513         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4514         * record.c (record_start, record_stop): Update callers of
4515         execute_command_to_string with false.
4516         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4517         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4518         methods.
4519         (class string_file): New constructor with term_out parameter.
4520         Override methods term_out and can_emit_style_escape.  New member
4521         term_out.
4522         (class stdio_file): Override can_emit_style_escape.
4523         (class tee_file): Override term_out and can_emit_style_escape.
4524         * utils.h (can_emit_style_escape): Remove.
4525         * utils.c (can_emit_style_escape): Likewise.
4526         Update all callers of can_emit_style_escape (SOMESTREAM) to
4527         SOMESTREAM->can_emit_style_escape.
4528         * source-cache.c (source_cache::get_source_lines): Likewise.
4529         * stack.c (frame_apply_command_count): Call execute_command_to_string
4530         passing the term_out characteristic of the current gdb_stdout.
4531         * thread.c (thr_try_catch_cmd): Likewise.
4532         * top.c (execute_command_to_string): pass term_out parameter
4533         to construct the string_file for the command output.
4534         * ui-file.c (term_cli_styling): New function (most code moved
4535         from utils.c can_emit_style_escape).
4536         (string_file::string_file, string_file::can_emit_style_escape,
4537         stdio_file::can_emit_style_escape, tee_file::term_out,
4538         tee_file::can_emit_style_escape): New functions.
4539
4540 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4541
4542         * NEWS: Mention the new set|show may-call-functions.
4543         * infcall.c (may_call_functions_p): New variable.
4544         (show_may_call_functions_p): New function.
4545         (call_function_by_hand_dummy): Throws an error if not
4546         may-call-functions.
4547         (_initialize_infcall): Call add_setshow_boolean_cmd for
4548         may-call-functions.
4549
4550 2019-04-25  Keith Seitz  <keiths@redhat.com>
4551
4552         PR c++/24367
4553         * cp-support.c (inspect_type): Don't attempt substitutions
4554         of symbol with the same name.
4555
4556 2019-04-25  Tom Tromey  <tromey@adacore.com>
4557
4558         PR gdb/24475:
4559         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4560         static.
4561
4562 2019-04-25  Tom Tromey  <tromey@adacore.com>
4563
4564         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4565         rvalue reference.
4566         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4567         (gdb_xml_parser::parse): Use std::move.
4568         * python/python-internal.h (gdbpy_convert_exception): Take a const
4569         reference.
4570         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4571         std::move.
4572         * python/py-utils.c (gdbpy_convert_exception): Take a const
4573         reference.
4574         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4575         Use std::move.
4576         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4577         Use std::move.
4578         * mi/mi-main.c (mi_print_exception): Take a const reference.
4579         * main.c (handle_command_errors): Take a const reference.
4580         * linespec.c (parse_linespec): Use std::move.
4581         * infcall.c (run_inferior_call): Use std::move.
4582         (call_function_by_hand_dummy): Use std::move.
4583         * exec.c (try_open_exec_file): Use std::move.
4584         * exceptions.h (exception_print, exception_fprintf)
4585         (exception_print_same): Update.
4586         * exceptions.c (print_exception, exception_print)
4587         (exception_fprintf, exception_print_same): Change parameters to
4588         const reference.
4589         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4590         * common/new-op.c: Use std::move.
4591         * common/common-exceptions.h (struct gdb_exception): Add move
4592         constructor.
4593         (struct gdb_exception_error, struct gdb_exception_quit, struct
4594         gdb_quit_bad_alloc): Change constructor to move constructor.
4595         (throw_exception): Change parameter to rvalue reference.
4596         * common/common-exceptions.c (throw_exception): Take rvalue
4597         reference.
4598         * cli/cli-interp.c (safe_execute_command): Use std::move.
4599         * breakpoint.c (insert_bp_location, location_to_sals): Use
4600         std::move.
4601
4602 2019-04-25  Tom Tromey  <tromey@adacore.com>
4603
4604         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4605         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4606         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4607         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4608         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4609         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4610         guile/scm-value.c: Use unpack.
4611         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4612         gdbscm_gdb_exception.
4613         (gdbscm_throw_gdb_exception): Likewise.
4614         (struct gdbscm_gdb_exception): New.
4615         (unpack): New function.
4616         (gdbscm_wrap): Use unpack.
4617
4618 2019-04-25  Tom Tromey  <tromey@adacore.com>
4619
4620         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4621         (gdb_rl_callback_handler): Use std::move.
4622         * common/common-exceptions.h (struct gdb_exception): Add move
4623         assignment operator.
4624         (throw_exception_sjlj): Change "exception" to const reference.
4625         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4626         (throw_exception_sjlj): Change "exception" to const reference.
4627
4628 2019-04-25  Tom Tromey  <tromey@adacore.com>
4629
4630         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4631         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4632         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4633         Update.
4634         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4635         Update.
4636         * mi/mi-interp.c (mi_interp::exec): Update.
4637         * linespec.c (parse_linespec): Update.
4638         * infcall.c (run_inferior_call): Update.
4639         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4640         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4641         (gdbscm_lookup_global_symbol): Update.
4642         * guile/scm-param.c (gdbscm_parameter_value): Update.
4643         * guile/scm-frame.c (gdbscm_frame_read_register)
4644         (gdbscm_frame_read_var): Update.
4645         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4646         * exec.c (try_open_exec_file): Update.
4647         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4648         (gdb_rl_callback_handler): Update.
4649         * common/common-exceptions.h (exception_none): Don't declare.
4650         * common/common-exceptions.c (exception_none): Don't define.
4651         (struct catcher) <exception>: Update.
4652         * cli/cli-interp.c (safe_execute_command): Update.
4653         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4654
4655 2019-04-25  Ali Tamur  <tamur@google.com>
4656
4657         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4658         (read_attribute_value): Likewise.
4659         (dwarf2_read_addr_index): Update comment.
4660         (read_str_index): Add DW_FORM_strx.
4661         (dwarf2_string_attr): Likewise.
4662         (dwarf2_const_value_attr): Likewise.
4663         (dump_die_shallow): Likewise.
4664         (dwarf2_fetch_constant_bytes): Likewise.
4665         (skip_form_bytes): Likewise.
4666         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4667
4668 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4669
4670         PR corefiles/11608
4671         PR corefiles/18187
4672         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4673         OFFSET.  Verify if current mapping contains an ELF header.
4674         (linux_find_memory_regions_full): Adjust call to
4675         dump_mapping_p.
4676
4677 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4678             Kang Li <kanglictf@gmail.com>
4679
4680         PR gdb/21600
4681
4682         * dwarf2-frame.c (read_initial_length): Be consistent about using
4683         unsigned representation of length.
4684         (decode_frame_entry_1): Likewise.  Check for wraparound of
4685         end pointer as well as buffer overflow.
4686
4687 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4688
4689         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4690         "vq".
4691
4692 2019-04-24  Tom Tromey  <tromey@adacore.com>
4693
4694         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4695
4696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * s12z-tdep.c (s12z_unwind_pc): Delete.
4699         (s12z_unwind_sp): Delete.
4700         (s12z_gdbarch_init): Don't register deleted functions with
4701         gdbarch.
4702
4703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4704
4705         * rl78-tdep.c (rl78_unwind_sp): Delete.
4706         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4707
4708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4711         (xstormy16_unwind_pc): Delete.
4712         (xstormy16_dummy_id): Delete.
4713         (xstormy16_gdbarch_init): Don't register deleted functions with
4714         gdbarch.
4715
4716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4717
4718         * vax-tdep.c (vax_unwind_pc): Delete.
4719         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4720
4721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * v850-tdep.c (v850_unwind_sp): Delete.
4724         (v850_unwind_pc): Delete.
4725         (v850_dummy_id): Delete.
4726         (v850_gdbarch_init): Don't register deleted functions with
4727         gdbarch.
4728
4729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4732         (tilegx_unwind_pc): Delete.
4733         (tilegx_unwind_dummy_id): Delete.
4734         (tilegx_gdbarch_init): Don't register deleted functions with
4735         gdbarch.
4736
4737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4740         (tic6x_dummy_id): Delete.
4741         (tic6x_gdbarch_init): Don't register deleted functions with
4742         gdbarch.
4743
4744 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4745
4746         * sparc-tdep.c (sparc_unwind_pc): Delete.
4747         (sparc32_gdbarch_init): Don't register deleted function with
4748         gdbarch.
4749
4750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * sh-tdep.c (sh_unwind_sp): Delete.
4753         (sh_unwind_pc): Delete.
4754         (sh_dummy_id): Delete.
4755         (sh_gdbarch_init): Don't register deleted functions with
4756         gdbarch.
4757
4758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * score-tdep.c (score_unwind_sp): Delete.
4761         (score_unwind_pc): Delete.
4762         (score_dummy_id): Delete.
4763         (score_gdbarch_init): Don't register deleted functions with
4764         gdbarch.
4765
4766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * rx-tdep.c (rx_unwind_pc): Delete.
4769         (rx_unwind_sp): Delete.
4770         (rx_dummy_id): Delete.
4771         (rx_gdbarch_init): Don't register deleted functions with
4772         gdbarch.  Update comment.
4773
4774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4777         (rs6000_dummy_id): Delete.
4778         (rs6000_gdbarch_init): Don't register deleted functions with
4779         gdbarch.
4780
4781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4782
4783         * or1k-tdep.c (or1k_dummy_id): Delete.
4784         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4785
4786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * nios2-tdep.c (nios2_dummy_id): Delete.
4789         (nios2_unwind_sp): Delete.
4790         (nios2_gdbarch_init): Don't register deleted functions with
4791         gdbarch.
4792
4793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * nds32-tdep.c (nds32_dummy_id): Delete.
4796         (nds32_unwind_pc): Delete.
4797         (nds32_unwind_sp): Delete.
4798         (nds32_gdbarch_init): Don't register deleted functions with
4799         gdbarch.
4800
4801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * msp430-tdep.c (msp430_unwind_pc): Delete.
4804         (msp430_unwind_sp): Delete.
4805         (msp430_dummy_id): Delete.
4806         (msp430_gdbarch_init): Don't register deleted functions with
4807         gdbarch.
4808
4809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * moxie-tdep.c (moxie_unwind_sp): Delete.
4812         (moxie_unwind_pc): Delete.
4813         (moxie_dummy_id): Delete.
4814         (moxie_gdbarch_init): Don't register deleted functions with
4815         gdbarch.
4816
4817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4820         (mn10300_unwind_pc): Delete.
4821         (mn10300_unwind_sp): Delete.
4822         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4823         mn10300_unwind_sp.
4824         (mn10300_frame_unwind_init): Don't register deleted functions with
4825         gdbarch.
4826
4827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4828
4829         * mep-tdep.c (mep_unwind_pc): Delete.
4830         (mep_unwind_sp): Delete.
4831         (mep_dummy_id): Delete.
4832         (mep_gdbarch_init): Don't register deleted functions with
4833         gdbarch.
4834
4835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4836
4837         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4838         (m68hc11_unwind_sp): Delete.
4839         (m68hc11_gdbarch_init): Don't register deleted functions with
4840         gdbarch.
4841
4842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * m32r-tdep.c (m32r_unwind_sp): Delete.
4845         (m32r_unwind_pc): Delete.
4846         (m32r_dummy_id): Delete.
4847         (m32r_gdbarch_init): Don't register deleted functions with
4848         gdbarch.
4849
4850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * m32c-tdep.c (m32c_unwind_pc): Delete.
4853         (m32c_unwind_sp): Delete.
4854         (m32c_dummy_id): Delete.
4855         (m32c_gdbarch_init): Don't register deleted functions with
4856         gdbarch.
4857
4858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4861         (lm32_unwind_pc): Delete.
4862         (lm32_dummy_id): Delete.
4863         (lm32_gdbarch_init): Don't register deleted functions with
4864         gdbarch.
4865
4866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4869         (iq2000_unwind_pc): Delete.
4870         (iq2000_dummy_id): Delete.
4871         (iq2000_gdbarch_init): Don't register deleted functions with
4872         gdbarch.
4873
4874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4875
4876         * nds32-tdep.c (nds32_type_align): Delete.
4877         (nds32_push_dummy_call): Use type_align instead.
4878
4879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4880
4881         * arm-tdep.c (arm_type_align): Only handle vector override case.
4882         (arm_push_dummy_call): Use type_align.
4883         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4884
4885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4888         case.
4889         (pass_on_stack): Use type_align.
4890         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4891         function.
4892
4893 2019-04-23  Tom Tromey  <tromey@adacore.com>
4894
4895         * dwarf2read.c (line_header::file_name_at): Remove unused
4896         overload.
4897
4898 2019-04-23  Tom de Vries  <tdevries@suse.de>
4899
4900         PR gdb/24438
4901         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4902         invocation.
4903
4904
4905 2019-03-27  Ali Tamur  <tamur@google.com>
4906
4907         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4908         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4909         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4910         (dwarf_expr_context::get_addr_index): Likewise
4911         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4912         (symbol_needs_eval_context::get_addr_index): Likewise
4913         (disassemble_dwarf_expression): Add DW_OP_addrx
4914         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4915         (read_cutu_die_from_dwo): Update comment
4916         (skip_one_die): Add DW_FORM_addrx
4917         (read_attribute_value): Likewise
4918         (var_decode_location): Add DW_OP_addrx
4919         (dwarf2_const_value_attr): Add DW_FORM_addrx
4920         (dump_die_shallow): Likewise
4921         (dwarf2_fetch_constant_bytes): Likewise
4922         (decode_locdesc): Add DW_OP_addrx
4923         (skip_form_bytes): Add DW_FORM_addrx
4924
4925 2019-04-22  Ali Tamur  <tamur@google.com>
4926
4927         * MAINTAINERS (Write After Approval): Add self.
4928
4929 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4930
4931         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4932         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4933         (open_symbol_file_object): Likewise.
4934         (svr4_default_sos): Add info parameter.
4935         (svr4_read_so_list): Likewise.
4936         (svr4_current_sos_direct): Adjust functions calls to pass down
4937         info.
4938         (svr4_current_sos_1): Add info parameter.
4939         (svr4_current_sos): Call get_svr4_info, pass info down to
4940         svr4_current_sos_1.
4941         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4942         get_svr4_info.
4943         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4944         get_svr4_info.
4945         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4946         to get_svr4_info.
4947         (probes_table_remove_objfile_probes): Likewise.
4948         (register_solib_event_probe): Add info parameter.
4949         (solist_update_incremental): Pass info parameter down to
4950         svr4_read_so_list.
4951         (disable_probes_interface): Add info parameter.
4952         (svr4_handle_solib_event): Pass current_program_space to
4953         get_svr4_info.  Adjust disable_probes_interface cleanup.
4954         (svr4_create_probe_breakpoints): Add info parameter, pass it
4955         down to register_solib_event_probe.
4956         (svr4_create_solib_event_breakpoints): Add info parameter,
4957         pass it down to svr4_create_probe_breakpoints.
4958         (enable_break): Pass info down to
4959         svr4_create_solib_event_breakpoints.
4960         (svr4_solib_create_inferior_hook): Pass current_program_space to
4961         get_svr4_info.
4962         (svr4_clear_solib): Likewise.
4963
4964 2019-04-22  Pedro Alves  <palves@redhat.com>
4965
4966         * solib-svr4.c (svr4_free_objfile_observer): New.
4967         (probe_and_action::objfile): New field.
4968         (probes_table_htab_remove_objfile_probes)
4969         (probes_table_remove_objfile_probes): New functions.
4970         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4971         in the new probe_and_action.  Don't store the probe in 'lookup'.
4972         (svr4_create_probe_breakpoints): Pass objfile to
4973         register_solib_event_probe.
4974         (_initialize_svr4_solib): Register a free_objfile observer.
4975
4976 2019-04-19  Tom Tromey  <tom@tromey.com>
4977
4978         * common/queue.h: Remove.
4979
4980 2019-04-19  Tom Tromey  <tom@tromey.com>
4981
4982         * event-loop.c: Don't include "common/queue.h".
4983
4984 2019-04-19  Tom Tromey  <tom@tromey.com>
4985
4986         * remote.c (remote_target): Use delete.
4987         * remote-notif.h: Include <list>, not "common/queue.h".
4988         (notif_client_p): Remove typedef.
4989         (remote_notif_state): Add constructor, destructor, initializer.
4990         <notif_queue>: Now a std::list.
4991         (remote_notif_state_xfree): Don't declare.
4992         * remote-notif.c (remote_notif_process, handle_notification)
4993         (remote_notif_state_allocate): Update.
4994         (~remote_notif_state): Rename from remote_notif_state_xfree.
4995
4996 2019-04-19  Tom Tromey  <tom@tromey.com>
4997
4998         * symfile.c (reread_symbols): Update.
4999         * objfiles.c (objfile_register_static_link)
5000         (objfile_lookup_static_link): Update
5001         (~objfile) Don't delete static_links.
5002         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5003
5004 2019-04-19  Tom Tromey  <tom@tromey.com>
5005
5006         * type-stack.h (struct type_stack) <insert>: Constify string.
5007         * type-stack.c (type_stack::insert): Constify string.
5008         * gdbtypes.h (lookup_template_type): Update.
5009         (address_space_name_to_int): Update.
5010         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5011         const.
5012         (lookup_template_type): Make name const.
5013         * c-exp.y: Update rules.
5014         (lex_one_token, classify_name, classify_inner_name)
5015         (c_print_token): Update.
5016         * p-exp.y: Update rules.
5017         (yylex): Update.
5018         * f-exp.y: Update rules.
5019         (yylex): Update.
5020         * d-exp.y: Update rules.
5021         (lex_one_token, classify_name, classify_inner_name): Update.
5022         * parse.c (write_dollar_variable, copy_name): Return std::string.
5023         * parser-defs.h (copy_name): Change return type.
5024         * m2-exp.y: Update rules.
5025         (yylex): Update.
5026         * go-exp.y (lex_one_token): Update.
5027         Update rules.
5028         (classify_unsafe_function, classify_packaged_name)
5029         (classify_name, yylex): Update.
5030
5031 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5032
5033         * configure.ac: add --enable-source-highlight switch.
5034         * configure: Regenerate.
5035         * top.c (print_gdb_version): plumb --enable-source-highlight
5036         status to "show configuration".
5037
5038 2019-04-19  Tom Tromey  <tromey@adacore.com>
5039
5040         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5041         Check ADA_TYPE_P.
5042         (empty_record, ada_template_to_fixed_record_type_1)
5043         (template_to_static_fixed_type)
5044         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5045         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5046         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5047         macros.
5048
5049 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5050
5051         PR symtab/24423:
5052         * source.c (print_source_lines_base): Advance "iter" when a
5053         control character is seen.
5054
5055 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5056
5057         * inferior.h (struct infcall_suspend_state_deleter):
5058         Catch exception in destructor to avoid crash.
5059
5060 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5061
5062         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5063         close to the add_com "shell".
5064
5065 2019-04-18  Tom Tromey  <tromey@adacore.com>
5066
5067         * process-stratum-target.h (class process_stratum_target)
5068         <stratum>: Add "final".
5069
5070 2019-04-17  Tom Tromey  <tromey@adacore.com>
5071
5072         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5073         against nullptr before use.
5074
5075 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5076
5077         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5078
5079 2019-04-17  Jim Wilson  <jimw@sifive.com>
5080             Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5083         code read might fail, assume 4-byte breakpoint in that case.
5084
5085 2019-04-15  Leszek Swirski  <leszeks@google.com>
5086
5087         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5088         rather than a hand-rolled POD check when checking for forced MEMORY
5089         classification.
5090
5091 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5092
5093         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5094         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5095         function.
5096         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5097         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5098         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5099         declaration.
5100
5101 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5102
5103         * aarch64-linux-nat.c
5104         (aarch64_linux_nat_target::thread_architecture): Add override.
5105         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5106         each VQ.
5107
5108 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5109
5110         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5111
5112 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5115         target types of size 96-bits, add some additional comments, and
5116         check that the builtin type we found was the correct size.
5117
5118 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5119
5120         * utils.c (prompt_for_continue): Don't restore the styling at the
5121         end, as applied_style has the wrong value.  This fixes styling in
5122         long lists of file names that are interrupted by the "Continue?"
5123         prompt.
5124
5125 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5126
5127         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5128         * c-lang.c (c_language_defn): Likewise.
5129         (cplus_language_defn): Likewise.
5130         (asm_language_defn): Likewise.
5131         (minimal_language_defn): Likewise.
5132         * d-lang.c (d_language_defn): Likewise.
5133         * f-lang.c (f_language_defn): Likewise.
5134         * go-lang.c (go_language_defn): Likewise.
5135         * language.c (unknown_language_defn): Likewise.
5136         (auto_language_defn): Likewise.
5137         * language.h (struct language_defn): Remove la_magic field.
5138         (LANG_MAGIC): Delete.
5139         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5140         * objc-lang.c (objc_language_defn): Likewise.
5141         * opencl-lang.c (opencl_language_defn): Likewise.
5142         * p-lang.c (pascal_language_defn): Likewise.
5143         * rust-lang.c (rust_language_defn): Likewise.
5144
5145 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5146
5147         * riscv-tdep.c (riscv_type_align): New function.
5148         (riscv_type_alignment): Delete.
5149         (riscv_arg_location): Use 'type_align'.
5150         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5151
5152 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * gdbtypes.c (type_align): A struct with no non-static fields also
5155         has alignment of 1.
5156
5157 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5160         component to 0.
5161         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5162         member.
5163         (riscv_struct_info::analyse): New implementation using new
5164         analyse_inner member function.
5165         (riscv_struct_info::field_offset): New member function.
5166         (riscv_struct_info::m_offsets): New member variable.
5167         (riscv_struct_info::analyse_inner): New private member function,
5168         takes the old implementation of riscv_struct_info::analyse but
5169         extended to track field offsets.
5170         (riscv_call_arg_struct): Update the struct folding special cases
5171         to handle cases where empty C++ structs, which are non-zero
5172         length, are found.
5173         (riscv_arg_location): Initialise the length of each location, a
5174         non-zero length now indicates the location is in use.
5175         (riscv_push_dummy_call): Allow for the first location having a
5176         non-zero offset when setting up arguments.
5177         (riscv_return_value): Likewise, but for return values.
5178
5179 2019-04-11  Tom Tromey  <tromey@adacore.com>
5180
5181         * utils.c (internal_vproblem): Make "msg" const.
5182
5183 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5184
5185         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5186         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5187         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5188         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5189
5190 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5191
5192         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5193         function.
5194         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5195         of amd64_collect_native_gregset.
5196         (amd64_linux_nat_target::store_registers): Likewise.
5197
5198 2019-04-10  Tom Tromey  <tom@tromey.com>
5199
5200         * symtab.c (lookup_global_symbol_from_objfile)
5201         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5202         * objfiles.h (class separate_debug_iterator): New.
5203         (class separate_debug_range): New.
5204         (struct objfile) <separate_debug_objfiles>: New method.
5205         (objfile_separate_debug_iterate): Don't declare.
5206         * objfiles.c (separate_debug_iterator::operator++): Rename from
5207         objfile_separate_debug_iterate.
5208         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5209         iterator.
5210         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5211         iterator.
5212
5213 2019-04-10  Tom Tromey  <tom@tromey.com>
5214
5215         * symfile.c (reread_symbols): Remove old comment.
5216         * objfiles.c (free_all_objfiles): Fix a typo.
5217
5218 2019-04-10  Tom Tromey  <tom@tromey.com>
5219
5220         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5221         * minsyms.c (lookup_minimal_symbol): Use foreach.
5222         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5223         (lookup_minimal_symbol_solib_trampoline): Likewise.
5224         * symfile.c (reread_symbols): Use foreach.
5225
5226 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5227             Tom Tromey  <tromey@adacore.com>
5228
5229         PR rust/24414:
5230         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5231         (rust_lex_int_test): Change "value" to be LONGEST.
5232         (rust_lex_tests): Add test for long integer literal.
5233
5234 2019-04-09  Tom Tromey  <tromey@adacore.com>
5235
5236         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5237         to bool.
5238         (extended_remote_target::attach): Update.
5239         (remote_target::remote_notice_new_inferior): Update.
5240         (remote_target::add_current_inferior_and_thread): Update.
5241         * inferior.c (exit_inferior_1): Use "false".
5242         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5243
5244 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5245
5246         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5247         the "start" command.
5248
5249 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5250
5251         * python/py-inferior.c (infpy_thread_from_thread_handle):
5252         Adjust comments to reflect renaming of thread_from_thread_handle
5253         to thread_from_handle.  Adjust keywords.  Fix type error message.
5254         (inferior_object_methods): Add thread_from_handle.  Retain
5255         thread_from_thread_handle, but mark it as deprecated.
5256
5257 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5258
5259         * gdbthread.h (find_thread_by_handle): Revise declaration.
5260         * thread.c (find_thread_by_handle): Likewise.  Adjust
5261         implementation too.
5262         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5263         support for buffer objects as handles.
5264
5265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5266
5267         * python/py-infthread.c (thpy_thread_handle): New function.
5268         (thread_object_methods): Register thpy_thread_handle.
5269
5270 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5271
5272         * gdbthread.h (thread_to_thread_handle): Declare.
5273         * thread.c (gdbtypes.h): Include.
5274         (thread_to_thread_handle): New function.
5275
5276         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5277         (target_thread_info_to_thread_handle): Declare.
5278         * target.c (target_thread_info_to_thread_handle): New function.
5279         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5280         * target-delegates.c: Regenerate.
5281
5282         * linux-thread-db.c (class thread_db_target): Add method
5283         thread_info_to_thread_handle.
5284         (thread_db_target::thread_info_to_thread_handle): Define.
5285         * remote.c (class remote_target): Add new method
5286         thread_info_to_thread_handle.
5287         (remote_target::thread_info_to_thread_handle): Define.
5288
5289 2019-04-08  Pedro Alves  <palves@redhat.com>
5290
5291         * common/common-exceptions.c (throw_exception): Don't create
5292         named object to throw; throw directly.
5293         (throw_it): Likewise.  Don't initialize gdb_exception::message
5294         here, with new; pass FMT and AP to the ctor instead.
5295         * common/common-exceptions.h: Include <string>.
5296         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5297         const char *, va_list)): New ctor.  Use std::make_shared.
5298         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5299         errors)): Delete.
5300         (gdb_exception_error::gdb_exception_error(enum errors, const char
5301         *, va_list)): New.
5302         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5303         Add assertion.
5304         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5305         errors)): Delete.
5306         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5307         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5308         Add assertion.
5309
5310 2019-04-08  Tom Tromey  <tom@tromey.com>
5311
5312         * valops.c (value_rtti_indirect_type): Replace throw_exception
5313         with throw.
5314         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5315         with throw.
5316         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5317         throw.
5318         * target.c (target_translate_tls_address): Replace throw_exception
5319         with throw.
5320         * stack.c (frame_apply_command_count): Replace throw_exception
5321         with throw.
5322         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5323         throw.
5324         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5325         with throw.
5326         * rs6000-tdep.c (rs6000_frame_cache)
5327         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5328         * remote.c: Replace throw_exception with throw.
5329         * record-full.c (record_full_message, record_full_wait_1)
5330         (record_full_restore): Replace throw_exception with throw.
5331         * record-btrace.c:
5332         (get_thread_current_frame_id, record_btrace_start_replaying)
5333         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5334         (cmd_record_btrace_start): Replace throw_exception with throw.
5335         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5336         throw.
5337         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5338         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5339         * linespec.c:
5340         (find_linespec_symbols): Replace throw_exception with throw.
5341         * infrun.c (displaced_step_prepare, resume): Replace
5342         throw_exception with throw.
5343         * infcmd.c (post_create_inferior): Replace throw_exception with
5344         throw.
5345         * inf-loop.c (inferior_event_handler): Replace throw_exception
5346         with throw.
5347         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5348         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5349         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5350         (get_prev_frame_always, get_frame_pc_if_available)
5351         (get_frame_address_in_block_if_available, get_frame_language):
5352         Replace throw_exception with throw.
5353         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5354         throw_exception with throw.
5355         * eval.c (fetch_subexp_value, evaluate_var_value)
5356         (evaluate_funcall, evaluate_subexp_standard): Replace
5357         throw_exception with throw.
5358         * dwarf2loc.c (call_site_find_chain)
5359         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5360         Replace throw_exception with throw.
5361         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5362         with throw.
5363         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5364         throw.
5365         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5366         * completer.c (complete_line_internal): Replace throw_exception
5367         with throw.
5368         * compile/compile-object-run.c (compile_object_run): Replace
5369         throw_exception with throw.
5370         * cli/cli-script.c (process_next_line): Replace throw_exception
5371         with throw.
5372         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5373         (btrace_enable, btrace_maint_update_pt_packets): Replace
5374         throw_exception with throw.
5375         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5376         throw_exception with throw.
5377         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5378         throw_exception with throw.
5379         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5380         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5381         * aarch64-tdep.c (aarch64_make_prologue_cache)
5382         (aarch64_make_stub_cache): Replace throw_exception with throw.
5383
5384 2019-04-08  Tom Tromey  <tom@tromey.com>
5385
5386         * common/common-exceptions.c (throw_exception): Rename from
5387         throw_exception_cxx.  Remove old copy.  Make argument const.
5388         (throw_it): Create and throw exception objects directly.
5389         * common/common-exceptions.h (throw_exception): Make argument
5390         const.
5391         (struct gdb_exception_error): Add constructor.
5392         (struct gdb_exception_quit): Add constructor.
5393
5394 2019-04-08  Tom Tromey  <tom@tromey.com>
5395
5396         * common/common-exceptions.h (exception_rethrow): Don't declare.
5397         (TRY_SJLJ): Update comment.
5398         (TRY, CATCH, END_CATCH): Remove.
5399         * common/common-exceptions.c (exception_rethrow): Remove.
5400
5401 2019-04-08  Tom Tromey  <tom@tromey.com>
5402
5403         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5404         Remove.
5405         (gdb_exception_error): Rename from
5406         gdb_exception_RETURN_MASK_ERROR.
5407         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5408         (gdb_quit_bad_alloc): Update.
5409         * aarch64-tdep.c: Update.
5410         * ada-lang.c: Update.
5411         * ada-typeprint.c: Update.
5412         * ada-valprint.c: Update.
5413         * amd64-tdep.c: Update.
5414         * arch-utils.c: Update.
5415         * break-catch-throw.c: Update.
5416         * breakpoint.c: Update.
5417         * btrace.c: Update.
5418         * c-varobj.c: Update.
5419         * cli/cli-cmds.c: Update.
5420         * cli/cli-interp.c: Update.
5421         * cli/cli-script.c: Update.
5422         * common/common-exceptions.c: Update.
5423         * common/new-op.c: Update.
5424         * common/selftest.c: Update.
5425         * compile/compile-c-symbols.c: Update.
5426         * compile/compile-cplus-symbols.c: Update.
5427         * compile/compile-object-load.c: Update.
5428         * compile/compile-object-run.c: Update.
5429         * completer.c: Update.
5430         * corelow.c: Update.
5431         * cp-abi.c: Update.
5432         * cp-support.c: Update.
5433         * cp-valprint.c: Update.
5434         * darwin-nat.c: Update.
5435         * disasm-selftests.c: Update.
5436         * dtrace-probe.c: Update.
5437         * dwarf-index-cache.c: Update.
5438         * dwarf-index-write.c: Update.
5439         * dwarf2-frame-tailcall.c: Update.
5440         * dwarf2-frame.c: Update.
5441         * dwarf2loc.c: Update.
5442         * dwarf2read.c: Update.
5443         * eval.c: Update.
5444         * event-loop.c: Update.
5445         * event-top.c: Update.
5446         * exec.c: Update.
5447         * f-valprint.c: Update.
5448         * fbsd-tdep.c: Update.
5449         * frame-unwind.c: Update.
5450         * frame.c: Update.
5451         * gdbtypes.c: Update.
5452         * gnu-v3-abi.c: Update.
5453         * guile/guile-internal.h: Update.
5454         * guile/scm-block.c: Update.
5455         * guile/scm-breakpoint.c: Update.
5456         * guile/scm-cmd.c: Update.
5457         * guile/scm-disasm.c: Update.
5458         * guile/scm-frame.c: Update.
5459         * guile/scm-lazy-string.c: Update.
5460         * guile/scm-math.c: Update.
5461         * guile/scm-param.c: Update.
5462         * guile/scm-ports.c: Update.
5463         * guile/scm-pretty-print.c: Update.
5464         * guile/scm-symbol.c: Update.
5465         * guile/scm-symtab.c: Update.
5466         * guile/scm-type.c: Update.
5467         * guile/scm-value.c: Update.
5468         * i386-linux-tdep.c: Update.
5469         * i386-tdep.c: Update.
5470         * inf-loop.c: Update.
5471         * infcall.c: Update.
5472         * infcmd.c: Update.
5473         * infrun.c: Update.
5474         * jit.c: Update.
5475         * language.c: Update.
5476         * linespec.c: Update.
5477         * linux-fork.c: Update.
5478         * linux-nat.c: Update.
5479         * linux-tdep.c: Update.
5480         * linux-thread-db.c: Update.
5481         * main.c: Update.
5482         * mi/mi-cmd-break.c: Update.
5483         * mi/mi-cmd-stack.c: Update.
5484         * mi/mi-interp.c: Update.
5485         * mi/mi-main.c: Update.
5486         * objc-lang.c: Update.
5487         * p-valprint.c: Update.
5488         * parse.c: Update.
5489         * ppc-linux-tdep.c: Update.
5490         * printcmd.c: Update.
5491         * python/py-arch.c: Update.
5492         * python/py-breakpoint.c: Update.
5493         * python/py-cmd.c: Update.
5494         * python/py-finishbreakpoint.c: Update.
5495         * python/py-frame.c: Update.
5496         * python/py-framefilter.c: Update.
5497         * python/py-gdb-readline.c: Update.
5498         * python/py-inferior.c: Update.
5499         * python/py-infthread.c: Update.
5500         * python/py-lazy-string.c: Update.
5501         * python/py-linetable.c: Update.
5502         * python/py-objfile.c: Update.
5503         * python/py-param.c: Update.
5504         * python/py-prettyprint.c: Update.
5505         * python/py-progspace.c: Update.
5506         * python/py-record-btrace.c: Update.
5507         * python/py-record.c: Update.
5508         * python/py-symbol.c: Update.
5509         * python/py-type.c: Update.
5510         * python/py-unwind.c: Update.
5511         * python/py-utils.c: Update.
5512         * python/py-value.c: Update.
5513         * python/python.c: Update.
5514         * record-btrace.c: Update.
5515         * record-full.c: Update.
5516         * remote-fileio.c: Update.
5517         * remote.c: Update.
5518         * riscv-tdep.c: Update.
5519         * rs6000-aix-tdep.c: Update.
5520         * rs6000-tdep.c: Update.
5521         * rust-exp.y: Update.
5522         * rust-lang.c: Update.
5523         * s390-tdep.c: Update.
5524         * selftest-arch.c: Update.
5525         * solib-dsbt.c: Update.
5526         * solib-frv.c: Update.
5527         * solib-spu.c: Update.
5528         * solib-svr4.c: Update.
5529         * solib.c: Update.
5530         * sparc64-linux-tdep.c: Update.
5531         * stack.c: Update.
5532         * symfile-mem.c: Update.
5533         * symmisc.c: Update.
5534         * target.c: Update.
5535         * thread.c: Update.
5536         * top.c: Update.
5537         * tracefile-tfile.c: Update.
5538         * tui/tui.c: Update.
5539         * typeprint.c: Update.
5540         * unittests/cli-utils-selftests.c: Update.
5541         * unittests/parse-connection-spec-selftests.c: Update.
5542         * valops.c: Update.
5543         * valprint.c: Update.
5544         * value.c: Update.
5545         * varobj.c: Update.
5546         * windows-nat.c: Update.
5547         * x86-linux-nat.c: Update.
5548         * xml-support.c: Update.
5549
5550 2019-04-08  Tom Tromey  <tom@tromey.com>
5551
5552         * xml-support.c: Use C++ exception handling.
5553         * x86-linux-nat.c: Use C++ exception handling.
5554         * windows-nat.c: Use C++ exception handling.
5555         * varobj.c: Use C++ exception handling.
5556         * value.c: Use C++ exception handling.
5557         * valprint.c: Use C++ exception handling.
5558         * valops.c: Use C++ exception handling.
5559         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5560         handling.
5561         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5562         * typeprint.c: Use C++ exception handling.
5563         * tui/tui.c: Use C++ exception handling.
5564         * tracefile-tfile.c: Use C++ exception handling.
5565         * top.c: Use C++ exception handling.
5566         * thread.c: Use C++ exception handling.
5567         * target.c: Use C++ exception handling.
5568         * symmisc.c: Use C++ exception handling.
5569         * symfile-mem.c: Use C++ exception handling.
5570         * stack.c: Use C++ exception handling.
5571         * sparc64-linux-tdep.c: Use C++ exception handling.
5572         * solib.c: Use C++ exception handling.
5573         * solib-svr4.c: Use C++ exception handling.
5574         * solib-spu.c: Use C++ exception handling.
5575         * solib-frv.c: Use C++ exception handling.
5576         * solib-dsbt.c: Use C++ exception handling.
5577         * selftest-arch.c: Use C++ exception handling.
5578         * s390-tdep.c: Use C++ exception handling.
5579         * rust-lang.c: Use C++ exception handling.
5580         * rust-exp.y: Use C++ exception handling.
5581         * rs6000-tdep.c: Use C++ exception handling.
5582         * rs6000-aix-tdep.c: Use C++ exception handling.
5583         * riscv-tdep.c: Use C++ exception handling.
5584         * remote.c: Use C++ exception handling.
5585         * remote-fileio.c: Use C++ exception handling.
5586         * record-full.c: Use C++ exception handling.
5587         * record-btrace.c: Use C++ exception handling.
5588         * python/python.c: Use C++ exception handling.
5589         * python/py-value.c: Use C++ exception handling.
5590         * python/py-utils.c: Use C++ exception handling.
5591         * python/py-unwind.c: Use C++ exception handling.
5592         * python/py-type.c: Use C++ exception handling.
5593         * python/py-symbol.c: Use C++ exception handling.
5594         * python/py-record.c: Use C++ exception handling.
5595         * python/py-record-btrace.c: Use C++ exception handling.
5596         * python/py-progspace.c: Use C++ exception handling.
5597         * python/py-prettyprint.c: Use C++ exception handling.
5598         * python/py-param.c: Use C++ exception handling.
5599         * python/py-objfile.c: Use C++ exception handling.
5600         * python/py-linetable.c: Use C++ exception handling.
5601         * python/py-lazy-string.c: Use C++ exception handling.
5602         * python/py-infthread.c: Use C++ exception handling.
5603         * python/py-inferior.c: Use C++ exception handling.
5604         * python/py-gdb-readline.c: Use C++ exception handling.
5605         * python/py-framefilter.c: Use C++ exception handling.
5606         * python/py-frame.c: Use C++ exception handling.
5607         * python/py-finishbreakpoint.c: Use C++ exception handling.
5608         * python/py-cmd.c: Use C++ exception handling.
5609         * python/py-breakpoint.c: Use C++ exception handling.
5610         * python/py-arch.c: Use C++ exception handling.
5611         * printcmd.c: Use C++ exception handling.
5612         * ppc-linux-tdep.c: Use C++ exception handling.
5613         * parse.c: Use C++ exception handling.
5614         * p-valprint.c: Use C++ exception handling.
5615         * objc-lang.c: Use C++ exception handling.
5616         * mi/mi-main.c: Use C++ exception handling.
5617         * mi/mi-interp.c: Use C++ exception handling.
5618         * mi/mi-cmd-stack.c: Use C++ exception handling.
5619         * mi/mi-cmd-break.c: Use C++ exception handling.
5620         * main.c: Use C++ exception handling.
5621         * linux-thread-db.c: Use C++ exception handling.
5622         * linux-tdep.c: Use C++ exception handling.
5623         * linux-nat.c: Use C++ exception handling.
5624         * linux-fork.c: Use C++ exception handling.
5625         * linespec.c: Use C++ exception handling.
5626         * language.c: Use C++ exception handling.
5627         * jit.c: Use C++ exception handling.
5628         * infrun.c: Use C++ exception handling.
5629         * infcmd.c: Use C++ exception handling.
5630         * infcall.c: Use C++ exception handling.
5631         * inf-loop.c: Use C++ exception handling.
5632         * i386-tdep.c: Use C++ exception handling.
5633         * i386-linux-tdep.c: Use C++ exception handling.
5634         * guile/scm-value.c: Use C++ exception handling.
5635         * guile/scm-type.c: Use C++ exception handling.
5636         * guile/scm-symtab.c: Use C++ exception handling.
5637         * guile/scm-symbol.c: Use C++ exception handling.
5638         * guile/scm-pretty-print.c: Use C++ exception handling.
5639         * guile/scm-ports.c: Use C++ exception handling.
5640         * guile/scm-param.c: Use C++ exception handling.
5641         * guile/scm-math.c: Use C++ exception handling.
5642         * guile/scm-lazy-string.c: Use C++ exception handling.
5643         * guile/scm-frame.c: Use C++ exception handling.
5644         * guile/scm-disasm.c: Use C++ exception handling.
5645         * guile/scm-cmd.c: Use C++ exception handling.
5646         * guile/scm-breakpoint.c: Use C++ exception handling.
5647         * guile/scm-block.c: Use C++ exception handling.
5648         * guile/guile-internal.h: Use C++ exception handling.
5649         * gnu-v3-abi.c: Use C++ exception handling.
5650         * gdbtypes.c: Use C++ exception handling.
5651         * frame.c: Use C++ exception handling.
5652         * frame-unwind.c: Use C++ exception handling.
5653         * fbsd-tdep.c: Use C++ exception handling.
5654         * f-valprint.c: Use C++ exception handling.
5655         * exec.c: Use C++ exception handling.
5656         * event-top.c: Use C++ exception handling.
5657         * event-loop.c: Use C++ exception handling.
5658         * eval.c: Use C++ exception handling.
5659         * dwarf2read.c: Use C++ exception handling.
5660         * dwarf2loc.c: Use C++ exception handling.
5661         * dwarf2-frame.c: Use C++ exception handling.
5662         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5663         * dwarf-index-write.c: Use C++ exception handling.
5664         * dwarf-index-cache.c: Use C++ exception handling.
5665         * dtrace-probe.c: Use C++ exception handling.
5666         * disasm-selftests.c: Use C++ exception handling.
5667         * darwin-nat.c: Use C++ exception handling.
5668         * cp-valprint.c: Use C++ exception handling.
5669         * cp-support.c: Use C++ exception handling.
5670         * cp-abi.c: Use C++ exception handling.
5671         * corelow.c: Use C++ exception handling.
5672         * completer.c: Use C++ exception handling.
5673         * compile/compile-object-run.c: Use C++ exception handling.
5674         * compile/compile-object-load.c: Use C++ exception handling.
5675         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5676         * compile/compile-c-symbols.c: Use C++ exception handling.
5677         * common/selftest.c: Use C++ exception handling.
5678         * common/new-op.c: Use C++ exception handling.
5679         * cli/cli-script.c: Use C++ exception handling.
5680         * cli/cli-interp.c: Use C++ exception handling.
5681         * cli/cli-cmds.c: Use C++ exception handling.
5682         * c-varobj.c: Use C++ exception handling.
5683         * btrace.c: Use C++ exception handling.
5684         * breakpoint.c: Use C++ exception handling.
5685         * break-catch-throw.c: Use C++ exception handling.
5686         * arch-utils.c: Use C++ exception handling.
5687         * amd64-tdep.c: Use C++ exception handling.
5688         * ada-valprint.c: Use C++ exception handling.
5689         * ada-typeprint.c: Use C++ exception handling.
5690         * ada-lang.c: Use C++ exception handling.
5691         * aarch64-tdep.c: Use C++ exception handling.
5692
5693 2019-04-08  Tom Tromey  <tom@tromey.com>
5694
5695         * xml-support.c (gdb_xml_parser::parse): Update.
5696         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5697         * value.c (show_convenience): Update.
5698         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5699         (test_parse_flags_qcs): Update.
5700         * thread.c (thr_try_catch_cmd): Update.
5701         * target.c (target_translate_tls_address): Update.
5702         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5703         (info_frame_command_core, frame_apply_command_count): Update.
5704         * rust-exp.y (rust_lex_exception_test): Update.
5705         * riscv-tdep.c (riscv_print_one_register_info): Update.
5706         * remote.c (remote_target::enable_btrace): Update.
5707         * record-btrace.c (record_btrace_enable_warn): Update.
5708         * python/py-utils.c (gdbpy_convert_exception): Update.
5709         * printcmd.c (do_one_display, print_variable_and_value): Update.
5710         * mi/mi-main.c (mi_print_exception): Update.
5711         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5712         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5713         * linux-nat.c (linux_nat_target::attach): Update.
5714         * linux-fork.c (class scoped_switch_fork_info): Update.
5715         * infrun.c (displaced_step_prepare): Update.
5716         * infcall.c (call_function_by_hand_dummy): Update.
5717         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5718         * gnu-v3-abi.c (print_one_vtable): Update.
5719         * frame.c (get_prev_frame_always): Update.
5720         * f-valprint.c (info_common_command_for_block): Update.
5721         * exec.c (try_open_exec_file): Update.
5722         * exceptions.c (print_exception, exception_print)
5723         (exception_fprintf, exception_print_same): Update.
5724         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5725         * dwarf-index-cache.c (index_cache::store)
5726         (index_cache::lookup_gdb_index): Update.
5727         * darwin-nat.c (maybe_cache_shell): Update.
5728         * cp-valprint.c (cp_print_value_fields): Update.
5729         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5730         (gcc_cplus_symbol_address): Update.
5731         * compile/compile-c-symbols.c (gcc_convert_symbol)
5732         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5733         * common/selftest.c: Update.
5734         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5735         a std::string.
5736         (exception_try_scope_entry, exception_try_scope_exit): Don't
5737         declare.
5738         (struct exception_try_scope): Remove.
5739         (TRY): Don't use exception_try_scope.
5740         (struct gdb_exception): Add constructor, operator=.
5741         <what>: New method.
5742         (struct gdb_exception_RETURN_MASK_ALL)
5743         (struct gdb_exception_RETURN_MASK_ERROR)
5744         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5745         (struct gdb_quit_bad_alloc): Update.
5746         * common/common-exceptions.c (exception_none): Change
5747         initializer.
5748         (struct catcher) <state, exception>: Initialize inline.
5749         <prev>: Remove member.
5750         (current_catcher): Remove.
5751         (catchers): New global.
5752         (exceptions_state_mc_init): Simplify.
5753         (catcher_pop): Remove.
5754         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5755         (try_scope_depth, exception_try_scope_entry)
5756         (exception_try_scope_exit): Remove.
5757         (throw_exception_sjlj): Update.
5758         (exception_messages, exception_messages_size): Remove.
5759         (throw_it): Simplify.
5760         (gdb_exception_sliced_copy): Remove.
5761         (throw_exception_cxx): Update.
5762         * cli/cli-script.c (script_from_file): Update.
5763         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5764         Update.
5765         * ada-valprint.c (ada_val_print): Update.
5766         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5767         (create_excep_cond_exprs): Update.
5768
5769 2019-04-08  Tom Tromey  <tom@tromey.com>
5770
5771         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5772         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5773         (TRY, CATCH, END_CATCH): Remove some definitions.
5774         * common/common-exceptions.c: Don't use GDB_XCPT.
5775         (catcher_list_size): Remove.
5776         (throw_exception, throw_it): Simplify.
5777
5778 2019-04-05  Tom Tromey  <tom@tromey.com>
5779
5780         Revert the header-sorting patch.
5781         * ft32-tdep.c: Revert.
5782         * frv-tdep.c: Revert.
5783         * frv-linux-tdep.c: Revert.
5784         * frame.c: Revert.
5785         * frame-unwind.c: Revert.
5786         * frame-base.c: Revert.
5787         * fork-child.c: Revert.
5788         * findvar.c: Revert.
5789         * findcmd.c: Revert.
5790         * filesystem.c: Revert.
5791         * filename-seen-cache.h: Revert.
5792         * filename-seen-cache.c: Revert.
5793         * fbsd-tdep.c: Revert.
5794         * fbsd-nat.h: Revert.
5795         * fbsd-nat.c: Revert.
5796         * f-valprint.c: Revert.
5797         * f-typeprint.c: Revert.
5798         * f-lang.c: Revert.
5799         * extension.h: Revert.
5800         * extension.c: Revert.
5801         * extension-priv.h: Revert.
5802         * expprint.c: Revert.
5803         * exec.h: Revert.
5804         * exec.c: Revert.
5805         * exceptions.c: Revert.
5806         * event-top.c: Revert.
5807         * event-loop.c: Revert.
5808         * eval.c: Revert.
5809         * elfread.c: Revert.
5810         * dwarf2read.h: Revert.
5811         * dwarf2read.c: Revert.
5812         * dwarf2loc.c: Revert.
5813         * dwarf2expr.h: Revert.
5814         * dwarf2expr.c: Revert.
5815         * dwarf2-frame.c: Revert.
5816         * dwarf2-frame-tailcall.c: Revert.
5817         * dwarf-index-write.h: Revert.
5818         * dwarf-index-write.c: Revert.
5819         * dwarf-index-common.c: Revert.
5820         * dwarf-index-cache.h: Revert.
5821         * dwarf-index-cache.c: Revert.
5822         * dummy-frame.c: Revert.
5823         * dtrace-probe.c: Revert.
5824         * disasm.h: Revert.
5825         * disasm.c: Revert.
5826         * disasm-selftests.c: Revert.
5827         * dictionary.c: Revert.
5828         * dicos-tdep.c: Revert.
5829         * demangle.c: Revert.
5830         * dcache.h: Revert.
5831         * dcache.c: Revert.
5832         * darwin-nat.h: Revert.
5833         * darwin-nat.c: Revert.
5834         * darwin-nat-info.c: Revert.
5835         * d-valprint.c: Revert.
5836         * d-namespace.c: Revert.
5837         * d-lang.c: Revert.
5838         * ctf.c: Revert.
5839         * csky-tdep.c: Revert.
5840         * csky-linux-tdep.c: Revert.
5841         * cris-tdep.c: Revert.
5842         * cris-linux-tdep.c: Revert.
5843         * cp-valprint.c: Revert.
5844         * cp-support.c: Revert.
5845         * cp-namespace.c: Revert.
5846         * cp-abi.c: Revert.
5847         * corelow.c: Revert.
5848         * corefile.c: Revert.
5849         * continuations.c: Revert.
5850         * completer.h: Revert.
5851         * completer.c: Revert.
5852         * complaints.c: Revert.
5853         * coffread.c: Revert.
5854         * coff-pe-read.c: Revert.
5855         * cli-out.h: Revert.
5856         * cli-out.c: Revert.
5857         * charset.c: Revert.
5858         * c-varobj.c: Revert.
5859         * c-valprint.c: Revert.
5860         * c-typeprint.c: Revert.
5861         * c-lang.c: Revert.
5862         * buildsym.c: Revert.
5863         * buildsym-legacy.c: Revert.
5864         * build-id.h: Revert.
5865         * build-id.c: Revert.
5866         * btrace.c: Revert.
5867         * bsd-uthread.c: Revert.
5868         * breakpoint.h: Revert.
5869         * breakpoint.c: Revert.
5870         * break-catch-throw.c: Revert.
5871         * break-catch-syscall.c: Revert.
5872         * break-catch-sig.c: Revert.
5873         * blockframe.c: Revert.
5874         * block.c: Revert.
5875         * bfin-tdep.c: Revert.
5876         * bfin-linux-tdep.c: Revert.
5877         * bfd-target.c: Revert.
5878         * bcache.c: Revert.
5879         * ax-general.c: Revert.
5880         * ax-gdb.h: Revert.
5881         * ax-gdb.c: Revert.
5882         * avr-tdep.c: Revert.
5883         * auxv.c: Revert.
5884         * auto-load.c: Revert.
5885         * arm-wince-tdep.c: Revert.
5886         * arm-tdep.c: Revert.
5887         * arm-symbian-tdep.c: Revert.
5888         * arm-pikeos-tdep.c: Revert.
5889         * arm-obsd-tdep.c: Revert.
5890         * arm-nbsd-tdep.c: Revert.
5891         * arm-nbsd-nat.c: Revert.
5892         * arm-linux-tdep.c: Revert.
5893         * arm-linux-nat.c: Revert.
5894         * arm-fbsd-tdep.c: Revert.
5895         * arm-fbsd-nat.c: Revert.
5896         * arm-bsd-tdep.c: Revert.
5897         * arch-utils.c: Revert.
5898         * arc-tdep.c: Revert.
5899         * arc-newlib-tdep.c: Revert.
5900         * annotate.h: Revert.
5901         * annotate.c: Revert.
5902         * amd64-windows-tdep.c: Revert.
5903         * amd64-windows-nat.c: Revert.
5904         * amd64-tdep.c: Revert.
5905         * amd64-sol2-tdep.c: Revert.
5906         * amd64-obsd-tdep.c: Revert.
5907         * amd64-obsd-nat.c: Revert.
5908         * amd64-nbsd-tdep.c: Revert.
5909         * amd64-nbsd-nat.c: Revert.
5910         * amd64-nat.c: Revert.
5911         * amd64-linux-tdep.c: Revert.
5912         * amd64-linux-nat.c: Revert.
5913         * amd64-fbsd-tdep.c: Revert.
5914         * amd64-fbsd-nat.c: Revert.
5915         * amd64-dicos-tdep.c: Revert.
5916         * amd64-darwin-tdep.c: Revert.
5917         * amd64-bsd-nat.c: Revert.
5918         * alpha-tdep.c: Revert.
5919         * alpha-obsd-tdep.c: Revert.
5920         * alpha-nbsd-tdep.c: Revert.
5921         * alpha-mdebug-tdep.c: Revert.
5922         * alpha-linux-tdep.c: Revert.
5923         * alpha-linux-nat.c: Revert.
5924         * alpha-bsd-tdep.c: Revert.
5925         * alpha-bsd-nat.c: Revert.
5926         * aix-thread.c: Revert.
5927         * agent.c: Revert.
5928         * addrmap.c: Revert.
5929         * ada-varobj.c: Revert.
5930         * ada-valprint.c: Revert.
5931         * ada-typeprint.c: Revert.
5932         * ada-tasks.c: Revert.
5933         * ada-lang.c: Revert.
5934         * aarch64-tdep.c: Revert.
5935         * aarch64-ravenscar-thread.c: Revert.
5936         * aarch64-newlib-tdep.c: Revert.
5937         * aarch64-linux-tdep.c: Revert.
5938         * aarch64-linux-nat.c: Revert.
5939         * aarch64-fbsd-tdep.c: Revert.
5940         * aarch64-fbsd-nat.c: Revert.
5941         * aarch32-linux-nat.c: Revert.
5942
5943 2019-04-05  Tom Tromey  <tom@tromey.com>
5944
5945         * ft32-tdep.c: Sort headers.
5946         * frv-tdep.c: Sort headers.
5947         * frv-linux-tdep.c: Sort headers.
5948         * frame.c: Sort headers.
5949         * frame-unwind.c: Sort headers.
5950         * frame-base.c: Sort headers.
5951         * fork-child.c: Sort headers.
5952         * findvar.c: Sort headers.
5953         * findcmd.c: Sort headers.
5954         * filesystem.c: Sort headers.
5955         * filename-seen-cache.h: Sort headers.
5956         * filename-seen-cache.c: Sort headers.
5957         * fbsd-tdep.c: Sort headers.
5958         * fbsd-nat.h: Sort headers.
5959         * fbsd-nat.c: Sort headers.
5960         * f-valprint.c: Sort headers.
5961         * f-typeprint.c: Sort headers.
5962         * f-lang.c: Sort headers.
5963         * extension.h: Sort headers.
5964         * extension.c: Sort headers.
5965         * extension-priv.h: Sort headers.
5966         * expprint.c: Sort headers.
5967         * exec.h: Sort headers.
5968         * exec.c: Sort headers.
5969         * exceptions.c: Sort headers.
5970         * event-top.c: Sort headers.
5971         * event-loop.c: Sort headers.
5972         * eval.c: Sort headers.
5973         * elfread.c: Sort headers.
5974         * dwarf2read.h: Sort headers.
5975         * dwarf2read.c: Sort headers.
5976         * dwarf2loc.c: Sort headers.
5977         * dwarf2expr.h: Sort headers.
5978         * dwarf2expr.c: Sort headers.
5979         * dwarf2-frame.c: Sort headers.
5980         * dwarf2-frame-tailcall.c: Sort headers.
5981         * dwarf-index-write.h: Sort headers.
5982         * dwarf-index-write.c: Sort headers.
5983         * dwarf-index-common.c: Sort headers.
5984         * dwarf-index-cache.h: Sort headers.
5985         * dwarf-index-cache.c: Sort headers.
5986         * dummy-frame.c: Sort headers.
5987         * dtrace-probe.c: Sort headers.
5988         * disasm.h: Sort headers.
5989         * disasm.c: Sort headers.
5990         * disasm-selftests.c: Sort headers.
5991         * dictionary.c: Sort headers.
5992         * dicos-tdep.c: Sort headers.
5993         * demangle.c: Sort headers.
5994         * dcache.h: Sort headers.
5995         * dcache.c: Sort headers.
5996         * darwin-nat.h: Sort headers.
5997         * darwin-nat.c: Sort headers.
5998         * darwin-nat-info.c: Sort headers.
5999         * d-valprint.c: Sort headers.
6000         * d-namespace.c: Sort headers.
6001         * d-lang.c: Sort headers.
6002         * ctf.c: Sort headers.
6003         * csky-tdep.c: Sort headers.
6004         * csky-linux-tdep.c: Sort headers.
6005         * cris-tdep.c: Sort headers.
6006         * cris-linux-tdep.c: Sort headers.
6007         * cp-valprint.c: Sort headers.
6008         * cp-support.c: Sort headers.
6009         * cp-namespace.c: Sort headers.
6010         * cp-abi.c: Sort headers.
6011         * corelow.c: Sort headers.
6012         * corefile.c: Sort headers.
6013         * continuations.c: Sort headers.
6014         * completer.h: Sort headers.
6015         * completer.c: Sort headers.
6016         * complaints.c: Sort headers.
6017         * coffread.c: Sort headers.
6018         * coff-pe-read.c: Sort headers.
6019         * cli-out.h: Sort headers.
6020         * cli-out.c: Sort headers.
6021         * charset.c: Sort headers.
6022         * c-varobj.c: Sort headers.
6023         * c-valprint.c: Sort headers.
6024         * c-typeprint.c: Sort headers.
6025         * c-lang.c: Sort headers.
6026         * buildsym.c: Sort headers.
6027         * buildsym-legacy.c: Sort headers.
6028         * build-id.h: Sort headers.
6029         * build-id.c: Sort headers.
6030         * btrace.c: Sort headers.
6031         * bsd-uthread.c: Sort headers.
6032         * breakpoint.h: Sort headers.
6033         * breakpoint.c: Sort headers.
6034         * break-catch-throw.c: Sort headers.
6035         * break-catch-syscall.c: Sort headers.
6036         * break-catch-sig.c: Sort headers.
6037         * blockframe.c: Sort headers.
6038         * block.c: Sort headers.
6039         * bfin-tdep.c: Sort headers.
6040         * bfin-linux-tdep.c: Sort headers.
6041         * bfd-target.c: Sort headers.
6042         * bcache.c: Sort headers.
6043         * ax-general.c: Sort headers.
6044         * ax-gdb.h: Sort headers.
6045         * ax-gdb.c: Sort headers.
6046         * avr-tdep.c: Sort headers.
6047         * auxv.c: Sort headers.
6048         * auto-load.c: Sort headers.
6049         * arm-wince-tdep.c: Sort headers.
6050         * arm-tdep.c: Sort headers.
6051         * arm-symbian-tdep.c: Sort headers.
6052         * arm-pikeos-tdep.c: Sort headers.
6053         * arm-obsd-tdep.c: Sort headers.
6054         * arm-nbsd-tdep.c: Sort headers.
6055         * arm-nbsd-nat.c: Sort headers.
6056         * arm-linux-tdep.c: Sort headers.
6057         * arm-linux-nat.c: Sort headers.
6058         * arm-fbsd-tdep.c: Sort headers.
6059         * arm-fbsd-nat.c: Sort headers.
6060         * arm-bsd-tdep.c: Sort headers.
6061         * arch-utils.c: Sort headers.
6062         * arc-tdep.c: Sort headers.
6063         * arc-newlib-tdep.c: Sort headers.
6064         * annotate.h: Sort headers.
6065         * annotate.c: Sort headers.
6066         * amd64-windows-tdep.c: Sort headers.
6067         * amd64-windows-nat.c: Sort headers.
6068         * amd64-tdep.c: Sort headers.
6069         * amd64-sol2-tdep.c: Sort headers.
6070         * amd64-obsd-tdep.c: Sort headers.
6071         * amd64-obsd-nat.c: Sort headers.
6072         * amd64-nbsd-tdep.c: Sort headers.
6073         * amd64-nbsd-nat.c: Sort headers.
6074         * amd64-nat.c: Sort headers.
6075         * amd64-linux-tdep.c: Sort headers.
6076         * amd64-linux-nat.c: Sort headers.
6077         * amd64-fbsd-tdep.c: Sort headers.
6078         * amd64-fbsd-nat.c: Sort headers.
6079         * amd64-dicos-tdep.c: Sort headers.
6080         * amd64-darwin-tdep.c: Sort headers.
6081         * amd64-bsd-nat.c: Sort headers.
6082         * alpha-tdep.c: Sort headers.
6083         * alpha-obsd-tdep.c: Sort headers.
6084         * alpha-nbsd-tdep.c: Sort headers.
6085         * alpha-mdebug-tdep.c: Sort headers.
6086         * alpha-linux-tdep.c: Sort headers.
6087         * alpha-linux-nat.c: Sort headers.
6088         * alpha-bsd-tdep.c: Sort headers.
6089         * alpha-bsd-nat.c: Sort headers.
6090         * aix-thread.c: Sort headers.
6091         * agent.c: Sort headers.
6092         * addrmap.c: Sort headers.
6093         * ada-varobj.c: Sort headers.
6094         * ada-valprint.c: Sort headers.
6095         * ada-typeprint.c: Sort headers.
6096         * ada-tasks.c: Sort headers.
6097         * ada-lang.c: Sort headers.
6098         * aarch64-tdep.c: Sort headers.
6099         * aarch64-ravenscar-thread.c: Sort headers.
6100         * aarch64-newlib-tdep.c: Sort headers.
6101         * aarch64-linux-tdep.c: Sort headers.
6102         * aarch64-linux-nat.c: Sort headers.
6103         * aarch64-fbsd-tdep.c: Sort headers.
6104         * aarch64-fbsd-nat.c: Sort headers.
6105         * aarch32-linux-nat.c: Sort headers.
6106
6107 2019-04-04  Tom Tromey  <tom@tromey.com>
6108
6109         * varobj.c (varobj_create): Update.
6110         * rust-exp.y (struct rust_parser) <update_innermost_block,
6111         lookup_symbol>: New methods.
6112         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6113         Rename.
6114         (rust_parser::rust_lookup_type)
6115         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6116         * printcmd.c (display_command, do_one_display): Update.
6117         * parser-defs.h (struct parser_state) <parser_state>: Add
6118         "tracker" parameter.
6119         (block_tracker): New member.
6120         (class innermost_block_tracker) <innermost_block_tracker>: Add
6121         "types" parameter.
6122         <reset>: Remove method.
6123         (innermost_block): Don't declare.
6124         (null_post_parser): Update.
6125         * parse.c (innermost_block): Remove global.
6126         (write_dollar_variable): Update.
6127         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6128         Remove "tracker_types" parameter.
6129         (parse_expression): Add "tracker" parameter.
6130         (parse_expression_for_completion): Update.
6131         (null_post_parser): Add "tracker" parameter.
6132         * p-exp.y: Update rules.
6133         * m2-exp.y: Update rules.
6134         * language.h (struct language_defn) <la_post_parser>: Add
6135         "tracker" parameter.
6136         * go-exp.y: Update rules.
6137         * f-exp.y: Update rules.
6138         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6139         parameter.
6140         * d-exp.y: Update rules.
6141         * c-exp.y: Update rules.
6142         * breakpoint.c (set_breakpoint_condition): Create an
6143         innermost_block_tracker.
6144         (watch_command_1): Likewise.
6145         * ada-lang.c (resolve): Add "tracker" parameter.
6146         (resolve_subexp): Likewise.
6147         * ada-exp.y (write_var_from_sym): Update.
6148
6149 2019-04-04  Tom Tromey  <tom@tromey.com>
6150
6151         * type-stack.h: New file.
6152         * type-stack.c: New file.
6153         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6154         type-stack.h.
6155         (insert_into_type_stack, insert_type, push_type, push_type_int)
6156         (insert_type_address_space, pop_type, pop_type_int)
6157         (pop_typelist, pop_type_stack, append_type_stack)
6158         (push_type_stack, get_type_stack, push_typelist)
6159         (follow_type_instance_flags, follow_types): Don't declare.
6160         * parse.c (type_stack): Remove global.
6161         (parse_exp_in_context): Update.
6162         (insert_into_type_stack, insert_type, push_type, push_type_int)
6163         (insert_type_address_space, pop_type, pop_type_int)
6164         (pop_typelist, pop_type_stack, append_type_stack)
6165         (push_type_stack, get_type_stack, push_typelist)
6166         (follow_type_instance_flags, follow_types): Remove (moved to
6167         type-stack.c).
6168         * f-exp.y (type_stack): New global.
6169         Update rules.
6170         (push_kind_type, f_parse): Update.
6171         * d-exp.y (type_stack): New global.
6172         Update rules.
6173         (d_parse): Update.
6174         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6175         Update rules.
6176         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6177         (HFILES_NO_SRCDIR): Add type-stack.h.
6178
6179 2019-04-04  Tom Tromey  <tom@tromey.com>
6180
6181         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6182         (rust_parser::convert_ast_to_expression, rust_parse)
6183         (rust_lex_test_completion, rust_lex_tests): Update.
6184         * parser-defs.h (struct expr_completion_state): New.
6185         (struct parser_state) <parser_state>: Add completion parameter.
6186         <mark_struct_expression, mark_completion_tag>: New methods.
6187         <parse_completion, m_completion_state>: New members.
6188         (prefixify_expression, null_post_parser): Update.
6189         (mark_struct_expression, mark_completion_tag): Don't declare.
6190         * parse.c (parse_completion, expout_last_struct)
6191         (expout_tag_completion_type, expout_completion_name): Remove
6192         globals.
6193         (parser_state::mark_struct_expression)
6194         (parser_state::mark_completion_tag): Now methods.
6195         (prefixify_expression): Add last_struct parameter.
6196         (prefixify_subexp): Likewise.
6197         (parse_exp_1): Update.
6198         (parse_exp_in_context): Add cstate parameter.  Update.
6199         (parse_expression_for_completion): Create an
6200         expr_completion_state.
6201         (null_post_parser): Add "completion" parameter.
6202         * p-exp.y: Update rules.
6203         (yylex): Update.
6204         * language.h (struct language_defn) <la_post_parser>: Add
6205         "completing" parameter.
6206         * go-exp.y: Update rules.
6207         (lex_one_token): Update.
6208         * expression.h (parse_completion): Don't declare.
6209         * d-exp.y: Update rules.
6210         (lex_one_token): Update rules.
6211         * c-exp.y: Update rules.
6212         (lex_one_token): Update.
6213         * ada-lang.c (resolve): Add "parse_completion" parameter.
6214         (resolve_subexp): Likewise.
6215         (ada_resolve_function): Likewise.
6216
6217 2019-04-04  Tom Tromey  <tom@tromey.com>
6218
6219         * parser-defs.h (struct parser_state) <start_arglist,
6220         end_arglist>: New methods.
6221         <arglist_len, m_funcall_chain>: New members.
6222         (arglist_len, start_arglist, end_arglist): Don't declare.
6223         * parse.c (arglist_len, funcall_chain): Remove global.
6224         (start_arglist, end_arglist): Remove functions.
6225         (parse_exp_in_context): Update.
6226         * p-exp.y: Update rules.
6227         * m2-exp.y: Update rules.
6228         * go-exp.y: Update rules.
6229         * f-exp.y: Update rules.
6230         * d-exp.y: Update rules.
6231         * c-exp.y: Update rules.
6232
6233 2019-04-04  Tom Tromey  <tom@tromey.com>
6234
6235         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6236         lex_operator, push_back>: New methods.
6237         Update all rules.
6238         (rust_parser::lex_hex, lex_escape): Rename and update.
6239         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6240         (rust_parser::lex_operator): Rename and update.
6241         (rust_parser::lex_number, rustyylex, rustyyerror)
6242         (rust_lex_test_init, rust_lex_test_sequence)
6243         (rust_lex_test_push_back, rust_lex_tests): Update.
6244         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6245         parameter.
6246         <lexptr, prev_lexptr>: New members.
6247         (lexptr, prev_lexptr): Don't declare.
6248         * parse.c (lexptr, prev_lexptr): Remove globals.
6249         (parse_exp_in_context): Update.
6250         * p-exp.y (yylex, yyerror): Update.
6251         * m2-exp.y (parse_number, yylex, yyerror): Update.
6252         * go-exp.y (lex_one_token, yyerror): Update.
6253         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6254         * d-exp.y (lex_one_token, yyerror): Update.
6255         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6256         (lex_one_token, yyerror): Update.
6257         * ada-lex.l (YY_INPUT): Update.
6258         (rewind_to_char): Update.
6259         * ada-exp.y (yyerror): Update.
6260
6261 2019-04-04  Tom Tromey  <tom@tromey.com>
6262
6263         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6264         * parser-defs.h (struct parser_state) <parser_state>: Add new
6265         parameter.
6266         <comma_terminates>: New member.
6267         (comma_terminates): Don't declare global.
6268         * parse.c (comma_terminates): Remove global.
6269         (parse_exp_in_context): Update.
6270         * p-exp.y (yylex): Update.
6271         * m2-exp.y (yylex): Update.
6272         * go-exp.y (lex_one_token): Update.
6273         * f-exp.y (yylex): Update.
6274         * d-exp.y (lex_one_token): Update.
6275         * c-exp.y (lex_one_token): Update.
6276         * ada-lex.l: Update.
6277
6278 2019-04-04  Tom Tromey  <tom@tromey.com>
6279
6280         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6281         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6282         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6283         * parser-defs.h (paren_depth): Don't declare.
6284         * parse.c (paren_depth): Remove global.
6285         (parse_exp_in_context): Update.
6286         * p-exp.y (paren_depth): New global.
6287         (pascal_parse): Initialize it.
6288         * m2-exp.y (paren_depth): New global.
6289         (m2_parse): Initialize it.
6290         * go-exp.y (paren_depth): New global.
6291         (go_parse): Initialize it.
6292         * f-exp.y (paren_depth): New global.
6293         (f_parse): Initialize it.
6294         * d-exp.y (paren_depth): New global.
6295         (d_parse): Initialize it.
6296         * c-exp.y (paren_depth): New global.
6297         (c_parse): Initialize it.
6298         * ada-lex.l (paren_depth): New global.
6299         (lexer_init): Initialize it.
6300
6301 2019-04-04  Tom Tromey  <tom@tromey.com>
6302
6303         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6304         (rust_parser::convert_ast_to_type)
6305         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6306         * parser-defs.h (struct parser_state) <parser_state>: Add
6307         parameters.  Initialize new members.
6308         <expression_context_block, expression_context_pc>: New members.
6309         * parse.c (expression_context_block, expression_context_pc):
6310         Remove globals.
6311         (parse_exp_in_context): Update.
6312         * p-exp.y: Update all rules.
6313         (yylex): Update.
6314         * m2-exp.y: Update all rules.
6315         (yylex): Update.
6316         * go-exp.y (yylex): Update.
6317         * f-exp.y (yylex): Update.
6318         * d-exp.y: Update all rules.
6319         (yylex): Update.
6320         * c-exp.y: Update all rules.
6321         (lex_one_token, classify_name, yylex, c_parse): Update.
6322         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6323
6324 2019-04-04  Tom Tromey  <tom@tromey.com>
6325
6326         * gdbarch.h, gdbarch.c: Rebuild.
6327         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6328         * stap-probe.h:
6329         (struct stap_parse_info): Replace "parser_state" with
6330         "expr_builder".
6331         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6332         (parser_state): New class.
6333         * parse.c (expr_builder): Rename.
6334         (expr_builder::release): Rename.
6335         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6336         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6337         (write_exp_elt_longcst, write_exp_elt_floatcst)
6338         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6339         (write_exp_string_vector, write_exp_bitstring)
6340         (write_exp_msymbol, mark_struct_expression)
6341         (write_dollar_variable)
6342         (insert_type_address_space, increase_expout_size): Replace
6343         "parser_state" with "expr_builder".
6344         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6345         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6346         "parser_state" with "expr_builder".
6347
6348 2019-04-04  Tom Tromey  <tom@tromey.com>
6349
6350         * rust-exp.y: Replace "parse_language" with method call.
6351         * p-exp.y:
6352         (yylex): Replace "parse_language" with method call.
6353         * m2-exp.y:
6354         (yylex): Replace "parse_language" with method call.
6355         * go-exp.y (classify_name): Replace "parse_language" with method
6356         call.
6357         * f-exp.y (yylex): Replace "parse_language" with method call.
6358         * d-exp.y (lex_one_token): Replace "parse_language" with method
6359         call.
6360         * c-exp.y:
6361         (lex_one_token, classify_name, yylex): Replace "parse_language"
6362         with method call.
6363         * ada-exp.y (find_primitive_type, type_char)
6364         (type_system_address): Replace "parse_language" with method call.
6365
6366 2019-04-04  Tom Tromey  <tom@tromey.com>
6367
6368         * rust-exp.y: Replace "parse_gdbarch" with method call.
6369         * parse.c (write_dollar_variable, insert_type_address_space):
6370         Replace "parse_gdbarch" with method call.
6371         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6372         call.
6373         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6374         call.
6375         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6376         "parse_gdbarch" with method call.
6377         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6378         with method call.
6379         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6380         "parse_gdbarch" with method call.
6381         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6382         "parse_gdbarch" with method call.
6383         * c-exp.y (parse_type, parse_number, classify_name): Replace
6384         "parse_gdbarch" with method call.
6385         * ada-lex.l: Replace "parse_gdbarch" with method call.
6386         * ada-exp.y (parse_type, find_primitive_type, type_char)
6387         (type_system_address): Replace "parse_gdbarch" with method call.
6388
6389 2019-04-04  Tom Tromey  <tom@tromey.com>
6390
6391         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6392         * stap-probe.c (stap_parse_argument): Update.
6393         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6394         initial_size parameter.
6395         * rust-exp.y (rust_lex_tests): Update.
6396         * parse.c (parser_state): Update.
6397         (parse_exp_in_context): Update.
6398         * parser-defs.h (struct parser_state) <parser_state>: Remove
6399         "initial_size" parameter.
6400
6401 2019-04-04  Tom Tromey  <tom@tromey.com>
6402
6403         * parser-defs.h (increase_expout_size): Don't declare.
6404         * parse.c (increase_expout_size): Now static.
6405
6406 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6407
6408         * gnu-nat.c (gnu_nat_target::wait): Fix
6409         target_waitstatus_to_string call.
6410
6411 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * eval.c (evaluate_subexp_standard): Handle internal functions
6414         during Fortran function call handling.
6415
6416 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6417
6418         * NEWS: Mention new internal functions.
6419         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6420         (read_base_type): Use dwarf2_init_complex_target_type.
6421         * value.c (creal_internal_fn): New function.
6422         (cimag_internal_fn): New function.
6423         (_initialize_values): Register new internal functions.
6424
6425 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6426
6427         * infrun.c (stop_all_threads): If debug_infrun, always
6428         trace the wait status after wait_one, using
6429         target_waitstatus_to_string and target_pid_to_str.
6430         (handle_inferior_event): Replace various trace of
6431         wait status kind by a single trace.
6432         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6433         wait status kind image by target_waitstatus_to_string.
6434         * target/waitstatus.c (target_waitstatus_to_string): Fix
6435         obsolete comment.
6436
6437 2019-04-01  Tom Tromey  <tromey@adacore.com>
6438
6439         PR symtab/23331:
6440         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6441
6442 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6443             Pedro Alves  <palves@redhat.com>
6444
6445         * top.c (quit_force): Call 'finalize_values'.
6446         * value.c (finalize_values): New function.
6447         * value.h (finalize_values): Declare.
6448
6449 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6450
6451         * NEWS: Announce $_gdb_major and $_gdb_minor.
6452
6453         * top.c (init_gdb_version_vars): New function.
6454         (gdb_init): Call init_gdb_version_vars.
6455
6456 2019-03-29  Tom Tromey  <tromey@adacore.com>
6457
6458         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6459         help text.  Remove dead code.
6460
6461 2019-03-29  Keith Seitz  <keiths@redhat.com>
6462
6463         From Siddhesh Poyarekar:
6464         * f-lang.h (f77_get_upperbound): Return LONGEST.
6465         (f77_get_lowerbound): Likewise.
6466         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6467         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6468         print them.
6469         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6470         plongest to format print it.
6471         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6472         (f77_get_upperbound): Likewise.
6473         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6474         LOWER_BOUND to LONGEST.
6475         (f77_create_arrayprint_offset_tbl): Likewise.
6476
6477 2019-03-29  Keith Seitz  <keiths@redhat.com>
6478
6479         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6480         %s/pulongest for TYPE_LENGTH instead of %d in format
6481         strings.
6482         * ada-typerint.c (ada_print_type): Likewise.
6483         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6484         * compile/compile-c-support.c (generate_register_struct): Likewise.
6485         * gdbtypes.c (recursive_dump_type): Likewise.
6486         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6487         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6488         instead of %d in format strings.
6489         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6490         to std::min to ULONGEST.
6491         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6492         instead of %d in format strings.
6493         * tracepoint.c (info_scope_command): Likewise.
6494         * typeprint.c (print_offset_data::update)
6495         (print_offset_data::finish): Likewise.
6496         * xtensa-tdep.c (xtensa_store_return_value)
6497         (xtensa_push_dummy_call): Likewise.
6498
6499 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6500
6501         * windows-nat.c (display_selector): Fixed format specifications
6502         for 64-bit Cygwin.
6503
6504 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6505
6506         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6507
6508 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6509
6510         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6511         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6512         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6513         (nios2_linux_init_abi): Install it.
6514
6515 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6516
6517         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6518
6519 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6520
6521         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6522
6523 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6524             Tom Tromey  <tromey@adacore.com>
6525
6526         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6527
6528 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6529
6530         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6531         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6532         method to compute the bounds of range types. Also print "[evaluated]"
6533         if the bounds' values come from a dynamic evaluation.
6534
6535 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6538         whitespace when pretty printing is on.
6539
6540 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6541
6542         * ppc-linux-nat.c: Add include.
6543
6544 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6545
6546         * NEWS: Mention AArch64 Pointer Authentication.
6547
6548 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6549
6550         * arm-linux-nat.c: Add include.
6551
6552 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6553
6554         * source-cache.c (source_cache::get_source_lines): Re-read
6555         fullname after calling open_source_file.
6556
6557 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6558
6559         * NEWS: Mention TLS support for FreeBSD.
6560
6561 2019-03-25  Tom Tromey  <tromey@adacore.com>
6562
6563         * minsyms.c (BUNCH_SIZE): Update comment.
6564         (~minimal_symbol_reader): Remove old comment.
6565         (compact_minimal_symbols): Update comment.
6566         (minimal_symbol_reader::install): Remove old comment.  Update
6567         other comments.
6568
6569 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6570
6571         * s390-linux-nat.c: Add include.
6572
6573 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6574
6575         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6576         Call linux_get_hwcap.
6577         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6578         Likewise.
6579         (aarch64_linux_get_hwcap): Remove function.
6580         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6581         declaration.
6582         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6583         linux_get_hwcap.
6584         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6585         * linux-tdep.c (linux_get_hwcap): Add function.
6586         (linux_get_hwcap2): Likewise.
6587         * linux-tdep.h (linux_get_hwcap): Add declaration.
6588         (linux_get_hwcap2): Likewise.
6589         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6590         (ppc_linux_get_hwcap2): Likewise.
6591         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6592         linux_get_hwcap.
6593         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6594         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6595         (ppc_linux_nat_target::read_description): Likewise.
6596         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6597         * s390-linux-nat.c: Likewise.
6598         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6599
6600 2019-03-24  Tom Tromey  <tom@tromey.com>
6601
6602         * ada-lang.c (standard_lookup): Simplify initialization.
6603         (ada_lookup_symbol_nonlocal): Simplify return.
6604         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6605         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6606         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6607         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6608         initialization.
6609         * solib.c (solib_global_lookup): Simplify.
6610         * symtab.c (null_block_symbol): Remove.
6611         (symbol_cache_lookup): Simplify returns.
6612         (lookup_language_this): Simplify returns.
6613         (lookup_symbol_aux): Simplify return.
6614         (lookup_local_symbol): Simplify returns.
6615         (lookup_global_symbol_from_objfile): Simplify return.
6616         (lookup_symbol_in_objfile_symtabs)
6617         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6618         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6619         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6620         * cp-namespace.c (cp_lookup_bare_symbol)
6621         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6622         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6623         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6624         (cp_lookup_symbol_via_imports): Simplify initialization.
6625         (find_symbol_in_baseclass): Likewise.
6626         * symtab.h (null_block_symbol): Remove.
6627         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6628         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6629         (d_lookup_symbol_module): Likewise.
6630         (find_symbol_in_baseclass): Simplify initialization.
6631
6632 2019-03-24  Tom Tromey  <tom@tromey.com>
6633
6634         * expression.h: Don't include symtab.h.
6635         (struct block): Forward declare.
6636
6637 2019-03-24  Tom Tromey  <tom@tromey.com>
6638
6639         * c-exp.y (typebase): Remove casts.
6640         * gdbtypes.c (lookup_unsigned_typename, )
6641         (lookup_signed_typename): Remove cast.
6642         * eval.c (parse_to_comma_and_eval): Remove cast.
6643         * parse.c (write_dollar_variable): Remove cast.
6644         * block.h (struct block) <superblock>: Now const.
6645         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6646         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6647         (map_block): Make "block" const.
6648         * symfile.h (struct quick_symbol_functions)
6649         <map_matching_symbols>: Constify block argument to "callback".
6650         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6651         const.
6652         (find_pc_sect_compunit_symtab): Make "b" const.
6653         (find_symbol_at_address): Likewise.
6654         (search_symbols): Likewise.
6655         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6656         (dw2_debug_names_lookup_symbol): Likewise.
6657         (dw2_map_matching_symbols): Update.
6658         * p-valprint.c (pascal_val_print): Remove "block".
6659         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6660         (aux_add_nonlocal_symbols): Make "block" const.
6661         (resolve_subexp): Remove cast.
6662         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6663         const.
6664         (iterate_over_file_blocks): Likewise.
6665         * f-exp.y (%union) <bval>: Remove.
6666         * coffread.c (patch_opaque_types): Make "b" const.
6667         * spu-tdep.c (spu_catch_start): Make "block" const.
6668         * c-valprint.c (print_unpacked_pointer): Remove "block".
6669         * symmisc.c (dump_symtab_1): Make "b" const.
6670         (block_depth): Make "block" const.
6671         * d-exp.y (%union) <bval>: Remove.
6672         * cp-support.h (cp_lookup_rtti_type): Update.
6673         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6674         * psymtab.c (psym_lookup_symbol): Make "block" const.
6675         (maintenance_check_psymtabs): Make "b" const.
6676         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6677         (enumerate_locals, enumerate_args): Update.
6678         * python/py-symtab.c (stpy_global_block): Make "block" const.
6679         (stpy_static_block): Likewise.
6680         * inline-frame.c (block_starting_point_at): Make "new_block"
6681         const.
6682         * block.c (find_block_in_blockvector): Make return type const.
6683         (blockvector_for_pc_sect): Make "b" const.
6684         (find_block_in_blockvector): Make "b" const.
6685
6686 2019-03-23  Tom Tromey  <tom@tromey.com>
6687
6688         * varobj.c (varobj_create): Update.
6689         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6690         * printcmd.c (display_command, do_one_display): Don't reset
6691         innermost_block.
6692         * parser-defs.h (enum innermost_block_tracker_type): Move to
6693         expression.h.
6694         (innermost_block): Update comment.
6695         * parse.c (parse_exp_1): Add tracker_types parameter.
6696         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6697         tracker_types parameter.  Reset innermost_block.
6698         (parse_exp_in_context): Remove.
6699         (parse_expression_for_completion): Update.
6700         * objfiles.c (~objfile): Don't reset expression_context_block or
6701         innermost_block.
6702         * expression.h (enum innermost_block_tracker_type): Move from
6703         parser-defs.h.
6704         (parse_exp_1): Add tracker_types parameter.
6705         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6706         reset innermost_block.
6707
6708 2019-03-23  Tom Tromey  <tom@tromey.com>
6709
6710         * objfiles.h: Include bcache.h.
6711
6712 2019-03-23  Tom Tromey  <tom@tromey.com>
6713
6714         * linespec.c (get_current_search_block): Use
6715         scoped_restore_current_language.
6716         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6717
6718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6719             Jiong Wang  <jiong.wang@arm.com>
6720
6721         * aarch64-linux-tdep.c
6722         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6723         section.
6724         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6725
6726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6727             Jiong Wang  <jiong.wang@arm.com>
6728
6729         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6730         instructions.
6731         (aarch64_analyze_prologue_test): Add PACIASP test.
6732         (aarch64_prologue_prev_register): Unmask PC value.
6733
6734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6735             Jiong Wang  <jiong.wang@arm.com>
6736
6737         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6738         (aarch64_dwarf2_prev_register): Unmask PC value.
6739         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6740         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6741         DW_CFA_AARCH64_negate_ra_state.
6742         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6743
6744 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6745             Jiong Wang  <jiong.wang@arm.com>
6746
6747         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6748         registers.
6749         (aarch64_pseudo_register_name): Likewise.
6750         (aarch64_pseudo_register_type): Likewise.
6751         (aarch64_pseudo_register_reggroup_p): Likewise.
6752         (aarch64_gdbarch_init): Add pauth registers.
6753         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6754         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6755         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6756         (struct gdbarch_tdep): Add regnum for ra_state.
6757
6758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6759             Jiong Wang  <jiong.wang@arm.com>
6760
6761         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6762
6763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6764             Jiong Wang  <jiong.wang@arm.com>
6765
6766         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6767         function.
6768         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6769         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6770         (aarch64_gdbarch_init): Add puth registers.
6771         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6772         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6773         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6774
6775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6776             Jiong Wang  <jiong.wang@arm.com>
6777
6778         * aarch64-linux-nat.c
6779         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6780         * aarch64-linux-tdep.c
6781         (aarch64_linux_core_read_description): Likewise.
6782         (aarch64_linux_get_hwcap): New function.
6783         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6784         (aarch64_linux_get_hwcap): New declaration.
6785
6786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6787             Jiong Wang  <jiong.wang@arm.com>
6788
6789         * aarch64-linux-nat.c
6790         (aarch64_linux_nat_target::read_description): Add pauth param.
6791         * aarch64-linux-tdep.c
6792         (aarch64_linux_core_read_description): Likewise.
6793         * aarch64-tdep.c (struct target_desc): Add in pauth.
6794         (aarch64_read_description): Add pauth param.
6795         (aarch64_gdbarch_init): Likewise.
6796         * aarch64-tdep.h (aarch64_read_description): Likewise.
6797         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6798         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6799         * features/Makefile: Add new files.
6800         * features/aarch64-pauth.c: New file.
6801         * features/aarch64-pauth.xml: New file.
6802
6803 2019-03-20  Tom Tromey  <tromey@adacore.com>
6804
6805         * infrun.c (handle_inferior_event): Rename from
6806         handle_inferior_event_1.  Create a scoped_value_mark.
6807         (handle_inferior_event): Remove.
6808
6809 2019-03-19  Tom Tromey  <tromey@adacore.com>
6810
6811         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6812         * infrun.h (print_stop_event): Add "displays" parameter.
6813         * infrun.c (print_stop_event): Add "displays" parameter.
6814
6815 2019-03-19  Pedro Alves  <palves@redhat.com>
6816
6817         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6818         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6819         to -1.  Fix TABs vs spaces.
6820         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6821         * tui/tui-out.h (tui_ui_out) Add intro comments.
6822         <m_line, m_start_of_line>: In-class initialize, and add describing
6823         comment.
6824
6825 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6826
6827         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6828         variable names.
6829         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6830
6831 2019-03-18  Pedro Alves  <palves@redhat.com>
6832             Eli Zaretskii <eliz@gnu.org>
6833
6834         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6835         m_line and m_start_of_line.
6836
6837 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6838
6839         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6840         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6841         it returns a newline.  This fixes a regression in TU mode, whereby
6842         the next line is output on the same screen line as the user input.
6843
6844 2019-03-18  Tom Tromey  <tromey@adacore.com>
6845
6846         * minsyms.c (minimal_symbol_reader::install): Remove call to
6847         obstack_blank.
6848
6849 2019-03-18  Pedro Alves  <palves@redhat.com>
6850
6851         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6852         New globals.
6853         (apply_style): New, factored out from ...
6854         (apply_ansi_escape): ... this.  Handle reverse video mode.
6855         (tui_set_reverse_mode): New function.
6856         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6857         * tui/tui-winsource.c (tui_show_source_line): Use
6858         tui_set_reverse_mode instead of setting A_STANDOUT.
6859         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6860         New setter methods.
6861
6862 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6863
6864         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6865         Handle tabs.
6866
6867 2019-03-18  Tom Tromey  <tromey@adacore.com>
6868
6869         * ada-lang.c (empty_array): Add "high" parameter.
6870         (ada_evaluate_subexp): Update.
6871
6872 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6873
6874         * unittests/string_view-selftests.c: Define
6875         _initialize_string_view_selftests unconditionally.
6876
6877 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6878
6879         PR gdb/24350
6880         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6881
6882 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6883
6884         PR gdb/24351
6885         * windows-nat.c (display_selector): Fix format specifiers.
6886
6887 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6888
6889         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6890         tui_refill_source_window instead of tui_refresh_win, to update the
6891         current execution line.  This fixes redisplay of the current line
6892         when stepping through the code with "next" or "step".
6893
6894 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6895
6896         * source-cache.c (source_cache::get_source_lines): Call
6897         find_source_lines to initialize s->nlines.  This fixes vertical
6898         scrolling of TUI source window when the DOWN arrow is pressed.
6899
6900 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6901
6902         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6903         linux-thread-db.c (_initialize_thread_db): Likewise.
6904
6905 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6906
6907         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6908         wclrtoeol in tui_show_source_line".  This reverts changes made in
6909         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6910
6911 2019-03-15  Tom Tromey  <tom@tromey.com>
6912
6913         * symtab.h (struct minimal_symbol): Derive from
6914         general_symbol_info.
6915         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6916         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6917         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6918         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6919         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6920         (MSYMBOL_SEARCH_NAME): Update.
6921         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6922         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6923         * minsyms.c (minimal_symbol_reader::record_full): Update.
6924
6925 2019-03-15  Tom Tromey  <tom@tromey.com>
6926
6927         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6928
6929 2019-03-15  Tom Tromey  <tom@tromey.com>
6930
6931         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6932         unique_xmalloc_ptr.
6933         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6934         Update.
6935         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6936         (build_minimal_symbol_hash_tables)
6937         (minimal_symbol_reader::install): Update.
6938
6939 2019-03-15  Tom Tromey  <tom@tromey.com>
6940
6941         * symtab.c (create_demangled_names_hash): Update.
6942         (symbol_set_names): Update.
6943         * objfiles.h (struct objfile_per_bfd_storage)
6944         <demangled_names_hash>: Now an htab_up.
6945         * objfiles.c (objfile_per_bfd_storage): Simplify.
6946
6947 2019-03-15  Tom Tromey  <tom@tromey.com>
6948
6949         * objfiles.h (struct objfile_per_bfd_storage): Declare
6950         destructor.
6951         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6952         New.
6953         (get_objfile_bfd_data): Use new.  Don't initialize
6954         language_of_main.
6955         (free_objfile_per_bfd_storage): Remove.
6956         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6957
6958 2019-03-15  Tom Tromey  <tom@tromey.com>
6959
6960         * symfile.c (reread_symbols): Update.
6961         * objfiles.c (objfile::objfile): Update.
6962         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6963         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6964         comment.
6965         (minimal_symbol_reader::install): Update.
6966         (terminate_minimal_symbol_table): Remove.
6967         * jit.c (jit_object_close_impl): Update.
6968
6969 2019-03-15  Tom Tromey  <tom@tromey.com>
6970
6971         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6972         initializations.
6973
6974 2019-03-15  Tom Tromey  <tom@tromey.com>
6975
6976         * objfiles.h (struct objfile_per_bfd_storage)
6977         <demangled_hash_languages>: Now a bitset.
6978         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6979         (lookup_minimal_symbol): Update.
6980
6981 2019-03-15  Tom Tromey  <tom@tromey.com>
6982
6983         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6984         Don't return the symbol.
6985         * coffread.c (record_minimal_symbol): Use record_full.
6986
6987 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6988
6989         The MS-Windows port of ncurses fails to switch to a color pair if
6990         one or both of the colors are the implicit default colors.  This
6991         change records the default colors when TUI is initialized, and
6992         then specifies them explicitly when a color pair uses the default
6993         colors.  This allows color styling in TUI mode on MS-Windows.
6994
6995         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6996         ncurses_norm_attr.
6997         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6998         colors in ncurses_norm_attr.
6999         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7000         "none", replace it with the default color recorded in
7001         ncurses_norm_attr.
7002
7003 2019-03-14  Tom Tromey  <tromey@adacore.com>
7004
7005         * source-cache.h (class source_cache) <get_source_lines>: Return
7006         std::string.
7007         * source-cache.c (source_cache::extract_lines): Handle case where
7008         first_pos==npos.  Return std::string.
7009         (source_cache::get_source_lines): Update.
7010
7011 2019-03-14  Tom Tromey  <tromey@adacore.com>
7012
7013         * NEWS: Add item for "style sources" commands.
7014         * source-cache.c (source_cache::get_source_lines): Check
7015         source_styling.
7016         * cli/cli-style.c (source_styling): New global.
7017         (_initialize_cli_style): Add "style sources" commands.
7018         (show_style_sources): New function.
7019         * cli/cli-style.h (source_styling): Declare.
7020
7021 2019-03-14  Pedro Alves  <palves@redhat.com>
7022             Tom Tromey  <tromey@adacore.com>
7023
7024         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7025         * tui/tui-winsource.c (tui_refill_source_window): New function,
7026         from...
7027         (tui_horizontal_source_scroll): ... here.  Move some logic.
7028         * cli/cli-style.c (set_style_enabled): Notify new observable.
7029         * tui/tui-hooks.c (tui_redisplay_source): New function.
7030         (tui_attach_detach_observers): Attach or detach
7031         tui_redisplay_source.
7032         * observable.h (source_styling_changed): New observable.
7033         * observable.c: Define source_styling_changed observable.
7034
7035 2019-03-13  Tom Tromey  <tromey@adacore.com>
7036
7037         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7038         (i386_gnu_nat_target::store_registers): Update.
7039         * target-debug.h (target_debug_print_std_string): New macro.
7040         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7041         * windows-tdep.c (display_one_tib): Update.
7042         * tui/tui-stack.c (tui_make_status_line): Update.
7043         * top.c (print_inferior_quit_action): Update.
7044         * thread.c (thr_try_catch_cmd): Update.
7045         (add_thread_with_info): Update.
7046         (thread_target_id_str): Update.
7047         (thr_try_catch_cmd): Update.
7048         (thread_command): Update.
7049         (thread_find_command): Update.
7050         * record-btrace.c (record_btrace_target::info_record)
7051         (record_btrace_resume_thread, record_btrace_target::resume)
7052         (record_btrace_cancel_resume, record_btrace_step_thread)
7053         (record_btrace_target::wait, record_btrace_target::wait)
7054         (record_btrace_target::wait, record_btrace_target::stop): Update.
7055         * progspace.c (print_program_space): Update.
7056         * process-stratum-target.c
7057         (process_stratum_target::thread_address_space): Update.
7058         * linux-fork.c (linux_fork_mourn_inferior)
7059         (detach_checkpoint_command, info_checkpoints_command)
7060         (linux_fork_context): Update.
7061         (linux_fork_detach): Update.
7062         (class scoped_switch_fork_info): Update.
7063         (delete_checkpoint_command): Update.
7064         * infrun.c (follow_fork_inferior): Update.
7065         (follow_fork_inferior): Update.
7066         (proceed_after_vfork_done): Update.
7067         (handle_vfork_child_exec_or_exit): Update.
7068         (follow_exec): Update.
7069         (displaced_step_prepare_throw): Update.
7070         (displaced_step_restore): Update.
7071         (start_step_over): Update.
7072         (resume_1): Update.
7073         (clear_proceed_status_thread): Update.
7074         (proceed): Update.
7075         (print_target_wait_results): Update.
7076         (do_target_wait): Update.
7077         (context_switch): Update.
7078         (stop_all_threads): Update.
7079         (restart_threads): Update.
7080         (finish_step_over): Update.
7081         (handle_signal_stop): Update.
7082         (switch_back_to_stepped_thread): Update.
7083         (keep_going_pass_signal): Update.
7084         (print_exited_reason): Update.
7085         (normal_stop): Update.
7086         * inferior.c (inferior_pid_to_str): Change return type.
7087         (print_selected_inferior): Update.
7088         (add_inferior): Update.
7089         (detach_inferior): Update.
7090         * dummy-frame.c (fprint_dummy_frames): Update.
7091         * dcache.c (dcache_info_1): Update.
7092         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7093         (btrace_fetch, btrace_clear): Update.
7094         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7095         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7096         type.
7097         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7098         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7099         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7100         * gdbarch.c, gdbarch.h: Rebuild.
7101         * gdbarch.sh (core_pid_to_str): Change return type.
7102         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7103         return type.
7104         (windows_nat_target::pid_to_str): Change return type.
7105         (windows_delete_thread): Update.
7106         (windows_nat_target::attach): Update.
7107         (windows_nat_target::files_info): Update.
7108         * target-delegates.c: Rebuild.
7109         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7110         return type.
7111         (sol_thread_target::pid_to_str): Change return type.
7112         * remote.c (class remote_target) <pid_to_str>: Change return
7113         type.
7114         (remote_target::pid_to_str): Change return type.
7115         (extended_remote_target::attach, remote_target::remote_stop_ns)
7116         (remote_target::remote_notif_remove_queued_reply)
7117         (remote_target::push_stop_reply, remote_target::disable_btrace):
7118         Update.
7119         (extended_remote_target::attach): Update.
7120         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7121         type.
7122         (gdbsim_target::pid_to_str): Change return type.
7123         * ravenscar-thread.c (struct ravenscar_thread_target)
7124         <pid_to_str>: Change return type.
7125         (ravenscar_thread_target::pid_to_str): Change return type.
7126         * procfs.c (class procfs_target) <pid_to_str>: Change return
7127         type.
7128         (procfs_target::pid_to_str): Change return type.
7129         (procfs_target::attach): Update.
7130         (procfs_target::detach): Update.
7131         (procfs_target::fetch_registers): Update.
7132         (procfs_target::store_registers): Update.
7133         (procfs_target::wait): Update.
7134         (procfs_target::files_info): Update.
7135         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7136         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7137         return type.
7138         (nto_procfs_target::pid_to_str): Change return type.
7139         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7140         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7141         return type.
7142         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7143         (exit_lwp): Update.
7144         (attach_proc_task_lwp_callback, get_detach_signal)
7145         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7146         (linux_nat_target::resume, wait_lwp, stop_callback)
7147         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7148         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7149         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7150         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7151         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7152         type.
7153         (inf_ptrace_target::attach): Update.
7154         (inf_ptrace_target::files_info): Update.
7155         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7156         type.
7157         (go32_nat_target::pid_to_str): Change return type.
7158         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7159         (gnu_nat_target::wait): Update.
7160         (gnu_nat_target::wait): Update.
7161         (gnu_nat_target::resume): Update.
7162         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7163         (fbsd_nat_target::wait): Update.
7164         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7165         type.
7166         (darwin_nat_target::attach): Update.
7167         * corelow.c (class core_target) <pid_to_str>: Change return type.
7168         (core_target::pid_to_str): Change return type.
7169         * target.c (normal_pid_to_str): Change return type.
7170         (default_pid_to_str): Likewise.
7171         (target_pid_to_str): Change return type.
7172         (target_translate_tls_address): Update.
7173         (target_announce_detach): Update.
7174         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7175         return type.
7176         (bsd_uthread_target::pid_to_str): Change return type.
7177         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7178         type.
7179         (bsd_kvm_target::pid_to_str): Change return type.
7180         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7181         return type.
7182         (aix_thread_target::pid_to_str): Change return type.
7183         * target.h (struct target_ops) <pid_to_str>: Change return type.
7184         (target_pid_to_str, normal_pid_to_str): Likewise.
7185         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7186         type.
7187         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7188         type.
7189         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7190         return type.
7191         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7192         type.
7193         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7194         type.
7195         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7196         return type.
7197
7198 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7199
7200         * NEWS: Mention that the new default MI version is 3.  Mention
7201         changes to the output of commands and events that deal with
7202         multi-location breakpoints.
7203         * breakpoint.c: Include "mi/mi-out.h".
7204         (print_one_breakpoint): Change output syntax if using MI version
7205         >= 3.
7206         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7207         New.
7208         (mi_multi_location_breakpoint_output_fixed): New.
7209         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7210         (mi_cmd_fix_multi_location_breakpoint_output): New.
7211         (mi_multi_location_breakpoint_output_fixed): New.
7212         * mi/mi-cmds.c (mi_cmds): Register command
7213         -fix-multi-location-breakpoint-output.
7214         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7215         interpreter "mi".
7216
7217 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7218
7219         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7220         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7221         instantiate mi_ui_out based on interpreter name.
7222         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7223         * mi/mi-main.c (mi_load_progress): Likewise.
7224
7225 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7226
7227         * NEWS: Combine separate "New targets" sections for 8.3.
7228
7229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7230
7231         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7232         (ppcfbsd_init_abi): Install gdbarch
7233         "fetch_tls_load_module_address" and "get_thread_local_address"
7234         methods.
7235
7236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7237
7238         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7239         (riscv_fbsd_init_abi): Install gdbarch
7240         "fetch_tls_load_module_address" and "get_thread_local_address"
7241         methods.
7242
7243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7244
7245         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7246         (i386fbsd_init_abi): Install gdbarch
7247         "fetch_tls_load_module_address" and "get_thread_local_address"
7248         methods.
7249
7250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7251
7252         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7253         (amd64fbsd_init_abi): Install gdbarch
7254         "fetch_tls_load_module_address" and "get_thread_local_address"
7255         methods.
7256
7257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7258
7259         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7260         (struct fbsd_pspace_data): New type.
7261         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7262         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7263         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7264         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7265         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7266
7267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7268
7269         * gdbtypes.c (lookup_struct_elt): New function.
7270         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7271         * gdbtypes.h (struct struct_elt): New type.
7272         (lookup_struct_elt): New prototype.
7273
7274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7275
7276         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7277         remove disabled code block.
7278
7279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7280
7281         * gdbarch.sh (get_thread_local_address): New method.
7282         * gdbarch.h, gdbarch.c: Regenerate.
7283         * target.c (target_translate_tls_address): Use
7284         gdbarch_get_thread_local_address if present instead of
7285         target::get_thread_local_address.
7286
7287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7288
7289         * target.h (target::get_thread_local_address): Update comment.
7290
7291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7292
7293         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7294         objfile->separate_debug_objfile_backlink if not NULL.
7295
7296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7297
7298         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7299         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7300         (amd64bsd_store_inferior_registers): Likewise.
7301         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7302         Enable segment base registers.
7303         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7304         PT_GETFSBASE and PT_GETGSBASE.
7305         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7306         PT_SETGSBASE.
7307         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7308         segment base registers.
7309         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7310
7311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7312
7313         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7314         Update calls to i386_target_description to add 'segments'
7315         parameter.
7316         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7317         add segment base registers.
7318         * arch/i386.c (i386_create_target_description): Add 'segments'
7319         parameter to enable segment base registers.
7320         * arch/i386.h (i386_create_target_description): Likewise.
7321         * features/i386/32bit-segments.xml: New file.
7322         * features/i386/32bit-segments.c: Generate.
7323         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7324         call to i386_target_description to add 'segments' parameter.
7325         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7326         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7327         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7328         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7329         if feature is present.
7330         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7331         Add 'segments' parameter to call to i386_target_description.
7332         (i386_target_description): Add 'segments' parameter to enable
7333         segment base registers.
7334         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7335         to call to i386_target_description.
7336         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7337         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7338         Define I386_NUM_REGS.
7339         (i386_target_description): Add 'segments' parameter to enable
7340         segment base registers.
7341
7342 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7343
7344         PR/24325
7345         * source-cache.c: #undef open and close, to avoid unresolved
7346         externals during linking.
7347
7348 2019-03-12  Tom Tromey  <tromey@adacore.com>
7349
7350         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7351         const.  Add initializers.
7352         (_initialize_remote): Don't initialize ptid globals.
7353
7354 2019-03-12  Pedro Alves  <palves@redhat.com>
7355
7356         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7357
7358 2019-03-12  Pedro Alves  <palves@redhat.com>
7359
7360         * cp-name-parser.y (main): Remove unused 'len' variable.
7361
7362 2019-03-12  Tom Tromey  <tromey@adacore.com>
7363
7364         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7365         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7366
7367 2019-03-12  Tom Tromey  <tromey@adacore.com>
7368
7369         * linux-nat.c (iterate_over_lwps): Update.
7370         (stop_callback): Remove parameter.
7371         (stop_wait_callback, detach_callback, resume_set_callback)
7372         (select_singlestep_lwp_callback, set_ignore_sigint)
7373         (status_callback, resumed_callback, resume_clear_callback)
7374         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7375         data parameter.
7376         (linux_nat_target::detach, linux_nat_target::resume)
7377         (linux_stop_and_wait_all_lwps, select_event_lwp)
7378         (linux_nat_filter_event, linux_nat_wait_1)
7379         (linux_nat_target::kill, linux_nat_target::stop)
7380         (linux_nat_target::stop): Update.
7381         (linux_nat_resume_callback): Change type.
7382         (resume_stopped_resumed_lwps, count_events_callback)
7383         (select_event_lwp_callback): Likewise.
7384         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7385         * arm-linux-nat.c (struct update_registers_data): Remove.
7386         (update_registers_callback): Change type.
7387         (arm_linux_insert_hw_breakpoint1): Update.
7388         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7389         parameter.
7390         (x86_linux_dr_set_addr): Update.
7391         (x86_linux_dr_set_control): Update.
7392         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7393         (iterate_over_lwps): Use gdb::function_view.
7394         * nat/aarch64-linux-hw-point.c (struct
7395         aarch64_dr_update_callback_param): Remove.
7396         (debug_reg_change_callback): Change type.
7397         (aarch64_notify_debug_reg_change): Update.
7398         * s390-linux-nat.c (s390_refresh_per_info): Update.
7399
7400 2019-03-11  Tom Tromey  <tromey@adacore.com>
7401
7402         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7403         redundant assignment to "this_cu".
7404
7405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7406
7407         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7408
7409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7410
7411         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7412         from...
7413         (rank_one_type): ... this.
7414
7415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7416
7417         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7418         from...
7419         (rank_one_type): ... this.
7420
7421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7422
7423         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7424         from...
7425         (rank_one_type): ... this.
7426
7427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7428
7429         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7430         from...
7431         (rank_one_type): ... this.
7432
7433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7434
7435         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7436         from...
7437         (rank_one_type): ... this.
7438
7439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7440
7441         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7442         from...
7443         (rank_one_type): ... this.
7444
7445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7446
7447         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7448         from...
7449         (rank_one_type): ... this.
7450
7451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7452
7453         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7454         from...
7455         (rank_one_type): ... this.
7456
7457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7458
7459         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7460         from...
7461         (rank_one_type): ... this.
7462
7463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7464
7465         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7466         from...
7467         (rank_one_type): ... this.
7468
7469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7470
7471         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7472         from...
7473         (rank_one_type): ... this.
7474
7475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7476
7477         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7478         from...
7479         (rank_one_type): ... this.
7480
7481 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7482
7483         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7484         inferior-events' shows the example events.
7485
7486 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7487
7488         Support styling on native MS-Windows console
7489
7490         PR/24315
7491         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7492         on MS-Windows if $TERM is not defined.
7493
7494         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7495
7496         * posix-hdep.c (gdb_console_fputs):
7497         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7498         functions.
7499         * ui-file.h (gdb_console_fputs): Add prototype.
7500
7501         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7502         back to fputs only if the former returns zero.
7503
7504 2019-03-07  Tom Tromey  <tom@tromey.com>
7505
7506         * symmisc.c (print_symbol_bcache_statistics): Update.
7507         (print_objfile_statistics): Update.
7508         * symfile.c (allocate_symtab): Update.
7509         * stabsread.c: Don't include bcache.h.
7510         * psymtab.h (struct psymbol_bcache): Don't declare.
7511         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7512         (psymbol_bcache_init, psymbol_bcache_free)
7513         (psymbol_bcache_get_bcache): Don't declare.
7514         * psymtab.c (struct psymbol_bcache): Remove.
7515         (psymtab_storage::psymtab_storage): Update.
7516         (psymtab_storage::~psymtab_storage): Update.
7517         (psymbol_bcache_init, psymbol_bcache_free)
7518         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7519         (add_psymbol_to_bcache): Update.
7520         (allocate_psymtab): Update.
7521         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7522         macro_cache>: No longer pointers.
7523         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7524         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7525         * macrotab.c (macro_bcache): Update.
7526         * macroexp.c: Don't include bcache.h.
7527         * gdbtypes.c (check_types_worklist): Update.
7528         (types_deeply_equal): Remove TRY/CATCH.  Update.
7529         * elfread.c (elf_symtab_read): Update.
7530         * dwarf2read.c: Don't include bcache.h.
7531         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7532         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7533         (print_bcache_statistics, bcache_memory_used): Don't declare.
7534         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7535         methods.  Rename all data members.
7536         * bcache.c (struct bcache): Move to bcache.h.
7537         (bcache::expand_hash_table): Rename from expand_hash_table.
7538         (bcache): Remove.
7539         (bcache::insert): Rename from bcache_full.
7540         (bcache::compare): Rename from bcache_compare.
7541         (bcache_xmalloc): Remove.
7542         (bcache::~bcache): Rename from bcache_xfree.
7543         (bcache::print_statistics): Rename from print_bcache_statistics.
7544         (bcache::memory_used): Rename from bcache_memory_used.
7545
7546 2019-03-07  Pedro Alves  <palves@redhat.com>
7547
7548         * infrun.c (normal_stop): Also check for
7549         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7550
7551 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7552
7553         * f-lang.c (value_from_host_double): Moved to...
7554         * value.c (value_from_host_double): ...here.
7555         * value.h (value_from_host_double): Declare.
7556         * guile/scm-math.c (vlscm_convert_typed_number): Use
7557         value_from_host_double.
7558         (vlscm_convert_number): Likewise.
7559         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7560         * python/py-value.c (convert_value_from_python): Likewise.
7561
7562 2019-03-06  Tom Tromey  <tom@tromey.com>
7563
7564         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7565
7566 2019-03-06  Tom Tromey  <tom@tromey.com>
7567
7568         * utils.h (free_current_contents): Don't declare.
7569         * utils.c (free_current_contents): Remove.
7570
7571 2019-03-06  Tom Tromey  <tom@tromey.com>
7572
7573         * top.c (quit_force): Update.
7574         * main.c (captured_command_loop): Update.
7575         * common/new-op.c (operator new): Update.
7576         * common/common-exceptions.c (struct catcher)
7577         <save_cleanup_chain>: Remove member.
7578         (exceptions_state_mc_init): Update.
7579         (exception_try_scope_entry): Return nullptr.
7580         (exception_try_scope_exit, exception_rethrow)
7581         (throw_exception_sjlj, throw_exception_cxx): Update.
7582         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7583         (all_cleanups, do_cleanups, discard_cleanups)
7584         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7585         (restore_cleanups, restore_final_cleanups): Don't declare.
7586         (do_final_cleanups): Remove parameter.
7587         * common/cleanups.c (cleanup_chain, make_cleanup)
7588         (make_cleanup_dtor, all_cleanups, do_cleanups)
7589         (discard_my_cleanups, discard_cleanups)
7590         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7591         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7592         (null_cleanup): Remove.
7593         (do_final_cleanups): Remove parameter.
7594
7595 2019-03-06  Tom Tromey  <tom@tromey.com>
7596
7597         * remote.c (remote_target::remote_parse_stop_reply): Use
7598         unique_xmalloc_ptr.
7599
7600 2019-03-06  Tom Tromey  <tom@tromey.com>
7601
7602         * stabsread.c (struct stabs_field_info): Rename from field_info.
7603         <list, fnlist>: Add initializers.
7604         <obstack>: New member.
7605         (read_member_functions, read_struct_fields, read_baseclasses):
7606         Allocate on obstack.  Don't use cleanups.
7607         (read_one_struct_field, read_member_functions, read_struct_fields)
7608         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7609         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7610         (read_struct_type): Update.
7611
7612 2019-03-06  Tom Tromey  <tom@tromey.com>
7613
7614         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7615         * common/filestuff.h (make_cleanup_close): Don't declare.
7616         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7617         Remove.
7618
7619 2019-03-06  Tom Tromey  <tom@tromey.com>
7620
7621         * solib-aix.c: Use make_scope_exit.
7622
7623 2019-03-06  Tom Tromey  <tom@tromey.com>
7624
7625         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7626         Use make_scope_exit.
7627
7628 2019-03-06  Tom Tromey  <tom@tromey.com>
7629
7630         * solib-svr4.c (disable_probes_interface): Remove parameter.
7631         (svr4_handle_solib_event): Use make_scope_exit.
7632
7633 2019-03-06  Tom Tromey  <tom@tromey.com>
7634
7635         * remote.c (struct stop_reply_deleter): Remove.
7636         (stop_reply_up): Update.
7637         (struct stop_reply): Derive from notif_event.  Don't typedef.
7638         <regcache>: Now a std::vector.
7639         (stop_reply_xfree): Remove.
7640         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7641         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7642         (remote_target::discard_pending_stop_replies): Use delete.
7643         (remote_target::remote_parse_stop_reply): Update.
7644         (remote_target::process_stop_reply): Update.
7645         * remote-notif.h (struct notif_event): Add virtual destructor.
7646         Remove "dtr" member.
7647         (struct notif_client) <alloc_event>: Return a unique_ptr.
7648         (notif_event_xfree): Don't declare.
7649         (notif_event_up): New typedef.
7650         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7651         (notif_event_xfree, do_notif_event_xfree): Remove.
7652         (remote_notif_state_xfree): Update.
7653
7654 2019-03-06  Tom Tromey  <tom@tromey.com>
7655
7656         * infrun.c (displaced_step_clear_cleanup): Now a
7657         forward_scope_exit type.
7658         (displaced_step_prepare_throw): Update.
7659         (displaced_step_fixup): Update.
7660
7661 2019-03-06  Tom Tromey  <tom@tromey.com>
7662
7663         * inferior.h (class inferior): Update comment.
7664         * gdbthread.h (class thread_info): Update comment.
7665
7666 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7667             Tom Tromey  <tom@tromey.com>
7668
7669         * stabsread.h (struct stab_section_list): Remove.
7670         (coffstab_build_psymtabs): Update.
7671         * dbxread.c (symbuf_sections): Now a std::vector.
7672         (sect_idx): New global.
7673         (fill_symbuf): Update.
7674         (coffstab_build_psymtabs): Change type of stabsects parameter.
7675         Update.
7676         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7677         std::vector.
7678         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7679         (coff_locate_sections): Update.
7680         (coff_symfile_read): Remove cleanups.  Update.
7681         (init_stringtab): Add storage parameter.
7682         (free_stringtab, free_stringtab_cleanup): Remove.
7683         (init_lineno): Add storage parameter.
7684         (free_linetab, free_linetab_cleanup): Remove.
7685
7686 2019-03-06  Pedro Alves  <palves@redhat.com>
7687
7688         * linux-fork.c (fork_info::clobber_regs): Delete.
7689         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7690         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7691         comment.  Adjust.
7692         (scoped_switch_fork_info::scoped_switch_fork_info)
7693         (checkpoint_command, linux_fork_context): Adjust
7694         fork_save_infrun_state calls.
7695
7696 2019-03-06  Pedro Alves  <palves@redhat.com>
7697
7698         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7699         (inf_has_multiple_threads): Return 'bool' and rewrite using
7700         inferior_info::threads().
7701
7702 2019-03-06  Pedro Alves  <palves@redhat.com>
7703
7704         * linux-fork.c: Include <list>.
7705         (fork_list): Now a std::list instance.
7706         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7707         (forks_exist_p, find_last_fork): Adjust.
7708         (new_fork): Delete.
7709         (one_fork_p): New.
7710         (add_fork): Adjust.
7711         (free_fork): Delete, folded into fork_info::~fork_info().
7712         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7713         Adjust.
7714         (init_fork_list): Delete.
7715         (linux_fork_killall, linux_fork_mourn_inferior)
7716         (linux_fork_detach, info_checkpoints_command): Adjust.
7717         (_initialize_linux_fork): No longer call init_fork_list.
7718
7719 2019-03-06  Pedro Alves  <palves@redhat.com>
7720
7721         * linux-fork.c (new_fork): New, split out of ...
7722         (add_fork): ... this.  Return void.  Move "first fork" special
7723         case from here, to ...
7724         (checkpoint_command): ... here.
7725         * linux-linux.h (add_fork): Return void.
7726
7727 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7728
7729         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7730
7731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7732             Chris January  <chris.january@arm.com>
7733             David Lecomber  <david.lecomber@arm.com>
7734
7735         * f-exp.y: New token, UNOP_INTRINSIC.
7736         (exp): New pattern using UNOP_INTRINSIC token.
7737         (f77_keywords): Add 'abs' keyword.
7738         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7739         (value_from_host_double): New function.
7740         (evaluate_subexp_f): Support UNOP_ABS.
7741
7742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7745         types.
7746
7747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7748
7749         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7750         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7751         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7752
7753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7756
7757 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7758             Chris January  <chris.january@arm.com>
7759
7760         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7761         * f-exp.y: Define 'KIND' token.
7762         (exp): New pattern for KIND expressions.
7763         (ptype): Handle types with a kind extension.
7764         (direct_abs_decl): Extend to spot kind extensions.
7765         (f77_keywords): Add 'kind' to the list.
7766         (push_kind_type): New function.
7767         (convert_to_kind_type): New function.
7768         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7769         * parse.c (operator_length_standard): Likewise.
7770         * parser-defs.h (enum type_pieces): Add tp_kind.
7771         * std-operator.def: Add UNOP_KIND.
7772
7773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * f-exp.y (f_parse): Set yydebug.
7776
7777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * f-lang.c (evaluate_subexp_f): New function.
7780         (exp_descriptor_f): New global.
7781         (f_language_defn): Use exp_descriptor_f instead of
7782         exp_descriptor_standard.
7783
7784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7785
7786         * f-exp.y (struct token): Add comments.
7787         (dot_ops): Remove uppercase versions and the end marker.
7788         (f77_keywords): Likewise.
7789         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7790         entries in the dot_ops array are case insensitive, and use
7791         strncasecmp to compare strings.  Also some whitespace cleanup in
7792         this area.  Similar for the f77_keywords array, except entries in
7793         this list might be case sensitive.
7794
7795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * f-exp.y (struct f77_boolean_val): Add comments.
7798         (boolean_values): Remove uppercase versions, and end marker.
7799         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7800         and use strncasecmp to achieve case insensitivity.  Additionally,
7801         perform whitespace cleanup around this code.
7802
7803 2019-03-06  Tom Tromey  <tromey@adacore.com>
7804
7805         * remote-sim.c (gdbsim_target_open): Use result of
7806         gdb_argv::release.
7807
7808 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7809         Dirk Schubert  <dirk.schubert@arm.com>
7810         Chris January  <chris.january@arm.com>
7811
7812         * eval.c (evaluate_subexp_standard): Call Fortran argument
7813         wrapping logic.
7814         * f-lang.c (struct value): A value which can be passed into a
7815         Fortran function call.
7816         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7817         where appropriate.
7818         (struct type): Value ready for a Fortran function call.
7819         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7820         is needed.
7821         * f-lang.h (fortran_argument_convert): Declaration.
7822         (fortran_preserve_arg_pointer): Declaration.
7823         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7824
7825 2019-03-05  Tom Tromey  <tromey@adacore.com>
7826
7827         * python/py-prettyprint.c (print_string_repr): Remove #if.
7828         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7829
7830 2019-03-05  Tom Tromey  <tromey@adacore.com>
7831
7832         * target.c (the_dummy_target): Move later.  Change type to
7833         "dummy_target".
7834         (initialize_targets): Don't initialize the_dummy_target.
7835
7836 2019-03-05  Tom Tromey  <tromey@adacore.com>
7837
7838         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7839         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7840
7841 2019-03-05  Tom Tromey  <tromey@adacore.com>
7842
7843         * windows-nat.c (windows_nat_target::attach)
7844         (windows_nat_target::detach): Don't call gdb_flush.
7845         * valprint.c (generic_val_print, val_print, val_print_string):
7846         Don't call gdb_flush.
7847         * utils.c (defaulted_query): Don't call gdb_flush.
7848         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7849         * target.c (target_announce_detach): Don't call gdb_flush.
7850         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7851         * remote.c (extended_remote_target::attach): Don't call
7852         gdb_flush.
7853         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7854         * printcmd.c (do_examine): Don't call gdb_flush.
7855         (info_display_command): Don't call gdb_flush.
7856         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7857         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7858         * memattr.c (info_mem_command): Don't call gdb_flush.
7859         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7860         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7861         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7862         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7863         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7864         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7865         (gnu_nat_target::detach): Don't call gdb_flush.
7866         * f-valprint.c (f_val_print): Don't call gdb_flush.
7867         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7868         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7869         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7870         gdb_flush.
7871         * c-valprint.c (c_val_print): Don't call gdb_flush.
7872         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7873
7874 2019-03-05  Tom Tromey  <tromey@adacore.com>
7875
7876         * varobj.c (update_dynamic_varobj_children): Update.
7877         (install_default_visualizer): Use reset, not release.
7878         * value.c (set_internalvar): Update.
7879         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7880         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7881         ATTRIBUTE_UNUSED_RESULT.
7882
7883 2019-03-05  Tom Tromey  <tromey@adacore.com>
7884
7885         * remote.c (class scoped_remote_fd) <release>: Add
7886         ATTRIBUTE_UNUSED_RESULT.
7887
7888 2019-03-05  Tom Tromey  <tromey@adacore.com>
7889
7890         * macroexp.c (struct macro_buffer) <release>: Add
7891         ATTRIBUTE_UNUSED_RESULT.
7892
7893 2019-03-05  Tom Tromey  <tromey@adacore.com>
7894
7895         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7896         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7897         ATTRIBUTE_UNUSED_RESULT.
7898
7899 2019-03-05  Tom Tromey  <tromey@adacore.com>
7900
7901         * common/scoped_fd.h (class scoped_fd) <release>: Add
7902         ATTRIBUTE_UNUSED_RESULT.
7903
7904 2019-03-05  Tom Tromey  <tromey@adacore.com>
7905
7906         * parser-defs.h (struct parser_state) <release>: Add
7907         ATTRIBUTE_UNUSED_RESULT.
7908
7909 2019-03-05  Tom Tromey  <tromey@adacore.com>
7910
7911         * utils.h (class gdb_argv) <release>: Add
7912         ATTRIBUTE_UNUSED_RESULT.
7913         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7914
7915 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7916
7917         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7918         for-loop range, to avoid compiler warnings.
7919
7920         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7921         avoid compiler warnings about unused variables.
7922
7923         * NEWS: Mention end of support for native debugging on MS-Windows
7924         before XP.
7925
7926         PR gdb/24292
7927         * common/netstuff.c:
7928         * gdbserver/gdbreplay.c
7929         * gdbserver/remote-utils.c:
7930         * ser-tcp.c:
7931         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7932         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7933         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7934         'getaddrinfo' and 'freeaddrinfo' were not available before
7935         Windows XP, and mingw.org's MinGW headers by default define
7936         _WIN32_WINNT to 0x500.
7937
7938 2019-03-01  Gary Benson <gbenson@redhat.com>
7939
7940         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7941
7942 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7943             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7944
7945         PR gdb/8527
7946         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7947         set_sigint_trap, clear_sigint_trap.
7948
7949 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7950
7951         * target.c (target_detach): Clear the regcache and the
7952         frame cache.
7953
7954 2019-02-27  Pedro Alves  <palves@redhat.com>
7955
7956         * utils.c (set_screen_size): When we cap the height/width sizes,
7957         tweak the corresponding command variable to show "unlimited":
7958
7959 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7960             Pedro Alves  <palves@redhat.com>
7961
7962         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7963         before calling rl_set_screen_size.
7964
7965 2019-02-27  Tom Tromey  <tromey@adacore.com>
7966
7967         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7968         define.
7969         * python/py-value.c: Remove Python 2.4 workaround.
7970         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7971         workaround.
7972         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7973         Python 2.4 workaround.
7974         * python/python-internal.h: Remove Python 2.4 comment.
7975         (Py_ssize_t): Don't define.
7976         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7977         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7978         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7979         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7980         * python/python.c (do_start_initialization): Remove Python 2.4
7981         workaround.
7982         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7983         (print_children): Remove Python 2.4 workaround.
7984         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7985         workaround.
7986         (CHARBUFFERPROC_NAME): Remove.
7987         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7988         Python 2.4 workaround.
7989
7990 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7991
7992         * NEWS: Note minimum Python version.
7993
7994 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7995
7996         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7997         code from these functions.  Remove corresponding ifdefs.  Use
7998         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7999         Remove gotos and target of gotos.
8000         (infpy_search_memory): Likewise.
8001
8002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8003
8004         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8005         (hppa_gdbarch_init): Don't register deleted functions with
8006         gdbarch.
8007
8008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8011         (h8300_unwind_sp): Delete.
8012         (h8300_dummy_id): Delete.
8013         (h8300_gdbarch_init): Don't register deleted functions with
8014         gdbarch.
8015
8016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8017
8018         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8019         (ft32_unwind_pc): Delete.
8020         (ft32_unwind_sp): Delete.
8021         (ft32_gdbarch_init): Don't register deleted functions with
8022         gdbarch.
8023
8024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8027         (frv_unwind_pc): Delete.
8028         (frv_unwind_sp): Delete.
8029         (frv_gdbarch_init): Don't register deleted functions with
8030         gdbarch.
8031
8032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8033
8034         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8035         (riscv_unwind_pc): Delete.
8036         (riscv_unwind_sp): Delete.
8037         (riscv_gdbarch_init): Don't register deleted functions with
8038         gdbarch.
8039
8040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8043         (csky_unwind_pc): Delete.
8044         (csky_unwind_sp): Delete.
8045         (csky_gdbarch_init): Don't register deleted functions with
8046         gdbarch.
8047
8048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8051         (cris_unwind_pc): Delete.
8052         (cris_unwind_sp): Delete.
8053         (cris_gdbarch_init): Don't register deleted functions with
8054         gdbarch.
8055
8056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8059         (bfin_unwind_pc): Delete.
8060         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8061
8062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8063
8064         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8065         (arm_unwind_pc): Delete.
8066         (arm_unwind_sp): Delete.
8067         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8068
8069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8070
8071         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8072         (arc_unwind_pc): Delete.
8073         (arc_unwind_sp): Delete.
8074         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8075
8076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8079         (alpha_unwind_pc): Delete.
8080         (alpha_gdbarch_init): Don't register deleted functions with
8081         gdbarch.
8082
8083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8086         (aarch64_unwind_pc): Delete.
8087         (aarch64_unwind_sp): Delete.
8088         (aarch64_gdbarch_init): Don't register deleted functions with
8089         gdbarch.
8090
8091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8092
8093         * gdbtypes.c (type_align): Don't consider static members when
8094         computing structure alignment.
8095
8096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8099         return 0 for other types.
8100         * arch-utils.c (default_type_align): Always return 0.
8101         * gdbarch.h: Regenerate.
8102         * gdbarch.sh (type_align): Extend comment.
8103         * gdbtypes.c (type_align): Add additional comments, always call
8104         gdbarch_type_align before applying the default rules.
8105         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8106         generic code will then apply a suitable default.
8107         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8108         types, return 0 for other types.
8109
8110 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8111
8112         * NEWS: Create a new section for the next release branch.
8113         Rename the section of the current branch, now that it has
8114         been cut.
8115
8116 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8117
8118         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8119         * version.in: Bump version to 8.3.50.DATE-git.
8120
8121 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8122
8123         * aix-thread.c (ptid_cmp): Remove unused variable.
8124         (get_signaled_thread): Likewise.
8125         (store_regs_user_thread): Likewise.
8126         (store_regs_kernel_thread): Likewise.
8127         (fetch_regs_kernel_thread): Remove shadowed variable.
8128
8129 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * features/riscv/32bit-cpu.xml: Add register numbers.
8132         * features/riscv/32bit-fpu.c: Regenerate.
8133         * features/riscv/32bit-fpu.xml: Add register numbers.
8134         * features/riscv/64bit-cpu.xml: Add register numbers.
8135         * features/riscv/64bit-fpu.c: Regenerate.
8136         * features/riscv/64bit-fpu.xml: Add register numbers.
8137
8138 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8139
8140         * NEWS: Mention two argument form of gdb.Value constructor.
8141         * python/py-value.c (convert_buffer_and_type_to_value): New
8142         function.
8143         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8144         Add support for handling an optional second argument.  Call
8145         convert_buffer_and_type_to_value as appropriate.
8146         * python/python-internal.h (Py_buffer_deleter): New struct.
8147         (Py_buffer_up): New typedef.
8148
8149 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8150
8151         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8152         instead of releasing ownership.
8153
8154 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8155
8156         * dwarf2read.c (open_and_init_dwp_file): Call
8157         elf_numsections instead of bfd_count_sections to initialize
8158         dwp_file->num_sections.
8159
8160 2019-02-25  Tom Tromey  <tromey@adacore.com>
8161
8162         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8163
8164 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8165
8166         * gcore.in: Add '--readnever' option when invoking GDB.
8167
8168 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8169
8170         * MAINTAINERS: Update my email address.
8171
8172 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8173
8174         * build-id.c (build_id_to_debug_bfd_1): New function.
8175         (build_id_to_debug_bfd): Look for separate debug file in
8176         sysroot.
8177
8178 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8179
8180         * gdbarch.sh: Update the copyright year range that is placed into
8181         generated files.
8182
8183 2019-02-22  Keith Seitz  <keiths@redhat.com>
8184
8185         PR symtab/23853
8186         * linespec.c (create_sals_line_offset): Search for the default
8187         symtab's filename instead of its fullname.
8188
8189 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8190
8191         * NEWS: Update style defaults.
8192
8193 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8194
8195         * main.c (captured_main_1): Disable styling in batch mode.
8196
8197 2019-02-20  Tom Tromey  <tom@tromey.com>
8198
8199         * symtab.c (symtab_symbol_info): Fix typos.
8200
8201 2019-02-20  Tom Tromey  <tromey@adacore.com>
8202
8203         * findcmd.c (_initialize_mem_search): Use upper case for
8204         metasyntactic variables.
8205
8206 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8207
8208         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8209         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8210
8211 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8212
8213         * top.h (source_file_name): Change to std::string.
8214         * top.c (source_file_name): Likewise.
8215         (command_line_input): Adjust.
8216         * cli/cli-script.c (script_from_file): Adjust.
8217
8218 2019-02-19  Tom Tromey  <tromey@adacore.com>
8219
8220         * ravenscar-thread.c
8221         (ravenscar_thread_target::update_thread_list): Don't call
8222         ada_build_task_list.
8223         * ada-lang.h (ada_build_task_list): Don't declare.
8224         * ada-tasks.c (struct ada_tasks_inferior_data)
8225         <task_list_valid_p>: Now bool.
8226         (read_known_tasks, ada_task_list_changed)
8227         (ada_tasks_invalidate_inferior_data): Update.
8228         (read_known_tasks_array): Return bool.
8229         (read_known_tasks_list): Likewise.
8230         (read_known_tasks): Return void.
8231         (ada_build_task_list): Now static.
8232
8233 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8236         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8237
8238 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8239
8240         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8241         variant for ada_tasks_pspace_data_handle and
8242         ada_tasks_inferior_data_handle.
8243         (ada_tasks_pspace_data_cleanup): New function.
8244         (ada_tasks_inferior_data_cleanup): New function.
8245
8246 2019-02-17  Tom Tromey  <tom@tromey.com>
8247
8248         * macrotab.h (macro_source_fullname): Return a std::string.
8249         * macrotab.c (macro_include, check_for_redefinition)
8250         (macro_undef, macro_lookup_definition, foreach_macro)
8251         (foreach_macro_in_scope): Update.
8252         (macro_source_fullname): Return a std::string.
8253         * macrocmd.c (show_pp_source_pos): Update.
8254
8255 2019-02-17  Tom Tromey  <tom@tromey.com>
8256
8257         * macrocmd.c (show_pp_source_pos): Style the file names.
8258
8259 2019-02-17  Tom Tromey  <tom@tromey.com>
8260
8261         PR tui/24197:
8262         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8263
8264 2019-02-17  Tom Tromey  <tom@tromey.com>
8265
8266         * ada-lang.c (user_select_syms): Use filtered printing.
8267         * utils.c (wrap_style): New global.
8268         (desired_style): Remove.
8269         (emit_style_escape): Add stream parameter.
8270         (set_output_style, reset_terminal_style, prompt_for_continue):
8271         Update.
8272         (flush_wrap_buffer): Only flush gdb_stdout.
8273         (wrap_here): Set wrap_style.
8274         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8275         treat escape sequences as a character.  Change when wrap buffer is
8276         flushed.
8277         (fputs_styled): Do not set the output style when the default is
8278         requested.
8279         * ui-style.h (struct ui_file_style) <is_default>: New method.
8280         * source.c (print_source_lines_base): Emit escape sequences in one
8281         piece.
8282
8283 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8284
8285         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8286         integers and enumeration types.
8287
8288 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8289
8290         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8291         instead of lookup_symbol_in_language
8292         (do_exact_match): New function.
8293         (ada_get_symbol_name_matcher): Return do_exact_match when
8294         doing a verbatim match.
8295
8296 2019-02-15  Tom Tromey  <tromey@adacore.com>
8297
8298         * ravenscar-thread.c (ravenscar_thread_target::resume)
8299         (ravenscar_thread_target::wait): Special case wildcard requests.
8300
8301 2019-02-15  Tom Tromey  <tromey@adacore.com>
8302
8303         * ravenscar-thread.c (base_ptid): Remove.
8304         (struct ravenscar_thread_target) <close>: New method.
8305         <m_base_ptid>: New member.
8306         <update_inferior_ptid, active_task, task_is_currently_active,
8307         runtime_initialized>: Declare methods.
8308         <ravenscar_thread_target>: Add constructor.
8309         (ravenscar_thread_target::task_is_currently_active)
8310         (ravenscar_thread_target::update_inferior_ptid)
8311         (ravenscar_runtime_initialized): Rename.  Now methods.
8312         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8313         (ravenscar_thread_target::update_thread_list): Update.
8314         (ravenscar_thread_target::active_task): Now method.
8315         (ravenscar_thread_target::store_registers)
8316         (ravenscar_thread_target::prepare_to_store)
8317         (ravenscar_thread_target::prepare_to_store)
8318         (ravenscar_thread_target::mourn_inferior): Update.
8319         (ravenscar_inferior_created): Use "new" to create target.
8320         (ravenscar_thread_target::get_ada_task_ptid): Update.
8321         (_initialize_ravenscar): Don't initialize base_ptid.
8322         (ravenscar_ops): Remove global.
8323
8324 2019-02-15  Tom Tromey  <tromey@adacore.com>
8325
8326         * target.h (push_target): Declare new overload.
8327         * target.c (push_target): New overload, taking an rvalue reference.
8328         * remote.c (remote_target::open_1): Use push_target overload.
8329         * corelow.c (core_target_open): Use push_target overload.
8330
8331 2019-02-15  Tom Tromey  <tromey@adacore.com>
8332
8333         * ravenscar-thread.c (is_ravenscar_task)
8334         (ravenscar_task_is_currently_active): Return bool.
8335         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8336         (_initialize_ravenscar): Remove "(void)".
8337         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8338         Return bool.
8339
8340 2019-02-15  Tom Tromey  <tromey@adacore.com>
8341
8342         * ravenscar-thread.c (ravenscar_runtime_initializer)
8343         (has_ravenscar_runtime, get_running_thread_id)
8344         (ravenscar_thread_target::resume): Fix indentation.
8345
8346 2019-02-15  Tom Tromey  <tromey@adacore.com>
8347
8348         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8349         from ravenscar_arch_ops.
8350         (sparc_ravenscar_ops::fetch_registers)
8351         (sparc_ravenscar_ops::store_registers): Now methods.
8352         (sparc_ravenscar_prepare_to_store): Remove.
8353         (sparc_ravenscar_ops): Redefine.
8354         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8355         methods and destructor.  Remove members.
8356         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8357         (ravenscar_thread_target::store_registers)
8358         (ravenscar_thread_target::prepare_to_store): Update.
8359         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8360         Remove.
8361         (struct ppc_ravenscar_powerpc_ops): Derive from
8362         ravenscar_arch_ops.
8363         (ppc_ravenscar_powerpc_ops::fetch_registers)
8364         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8365         (ppc_ravenscar_powerpc_ops): Redefine.
8366         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8367         (ppc_ravenscar_e500_ops::fetch_registers)
8368         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8369         (ppc_ravenscar_e500_ops): Redefine.
8370         * aarch64-ravenscar-thread.c
8371         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8372         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8373         (aarch64_ravenscar_fetch_registers)
8374         (aarch64_ravenscar_store_registers): Now methods.
8375         (aarch64_ravenscar_ops): Redefine.
8376
8377 2019-02-15  Tom Tromey  <tromey@adacore.com>
8378
8379         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8380         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8381         (ravenscar_thread_target::stopped_by_watchpoint)
8382         (ravenscar_thread_target::stopped_data_address)
8383         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8384
8385 2019-02-15  Tom Tromey  <tromey@adacore.com>
8386
8387         * ravenscar-thread.c: Fix some typos.
8388
8389 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8390             Tom Tromey  <tromey@adacore.com>
8391
8392         * ada-lang.c (ada_exception_sal): Change addr_string to a
8393         std::string.
8394         (create_ada_exception_catchpoint): Update.
8395
8396 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8397             Tom Tromey  <tromey@adacore.com>
8398
8399         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8400         (bp_location_ops): Remove.
8401         (base_breakpoint_allocate_location): Update.
8402         (free_bp_location): Update.
8403         * ada-lang.c (class ada_catchpoint_location)
8404         <ada_catchpoint_location>: Remove ops parameter.
8405         (ada_catchpoint_location_dtor): Remove.
8406         (ada_catchpoint_location_ops): Remove.
8407         (allocate_location_exception): Update.
8408         * breakpoint.h (struct bp_location_ops): Remove.
8409         (class bp_location) <bp_location>: Remove bp_location_ops
8410         parameter.
8411         <~bp_location>: Add destructor.
8412         <ops>: Remove.
8413
8414 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8415             Pedro Alves  <palves@redhat.com>
8416
8417         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8418         'PATH_MAX'.
8419
8420 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8421             Samuel Thibault  <samuel.thibault@gnu.org>
8422             Thomas Schwinge  <thomas@codesourcery.com>
8423
8424         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8425         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8426
8427 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8428
8429         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8430         (check_empty): Use "const char *".
8431
8432         * gnu-nat.c (gnu_nat_target::detach): Instead of
8433         'detach_inferior (pid)' call
8434         'detach_inferior (find_inferior_pid (pid))'.
8435
8436         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8437         'nat/fork-inferior.o'.
8438         * gnu-nat.c: #include "nat/fork-inferior.h".
8439
8440         * gnu-nat.c (gnu_nat_target::detach): Instead of
8441         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8442         * gnu-nat.h: #include "inf-child.h".
8443         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8444         'i386_gnu_nat_target::fetch_registers'.
8445         (gnu_store_registers): Rename/move to
8446         'i386_gnu_nat_target::store_registers'.
8447
8448         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8449         * gnu-nat.h (mach_thread_info): New function.
8450         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8451
8452         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8453
8454 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8455
8456         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8457
8458 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8459
8460         * windows-nat.c (windows_add_thread): Add new parameter
8461         "main_thread_p" with default value set to false.  Update
8462         function documentation as well as all callers.
8463         (windows_delete_thread): Likewise.
8464         (fake_create_process): Update call to windows_add_thread.
8465         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8466         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8467         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8468         call to windows_delete_thread.
8469
8470 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8471
8472         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8473
8474 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8475
8476         * symfile.c (find_separate_debug_file): Use canonical path of
8477         sysroot with child_path instead of gdb_sysroot if it is valid.
8478
8479 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8480
8481         * symfile.c (find_separate_debug_file): Use child_path to
8482         determine if an object file is under a sysroot.
8483
8484 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8485
8486         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8487         unittests/child-path-selftests.c.
8488         * common/pathstuff.c (child_path): New function.
8489         * common/pathstuff.h (child_path): New prototype.
8490         * unittests/child-path-selftests.c: New file.
8491
8492 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8493
8494         * symfile.c (find_separate_debug_file): Look for separate debug
8495         files in debug directories under the sysroot.
8496
8497 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8498
8499         * symtab.h (struct minimal_symbol data_p): New const method.
8500         (struct minimal_symbol text_p): Likewise.
8501         * symtab.c (output_source_filename): Use file name style
8502         to print file name.
8503         (print_symbol_info): Likewise.
8504         (print_msymbol_info): Use address style to print addresses.
8505         Use function name style to print executable text symbols.
8506         (expand_symtab_containing_pc): Use data_p.
8507         (find_pc_sect_compunit_symtab): Likewise.
8508
8509 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8510
8511         * breakpoint.c (describe_other_breakpoints): Use address style
8512         to print addresses.
8513         (say_where): Likewise.
8514
8515 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8516
8517         * ada-typeprint.c (print_func_type): Print function name
8518         style to print function name.
8519         * c-typeprint.c (c_print_type_1): Likewise.
8520
8521 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8522
8523         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8524         for execve.
8525
8526 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8527
8528         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8529         type_stack.
8530
8531 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8532
8533         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8534         TYPE_CODE_REF types.
8535
8536 2019-02-08  Jim Wilson  <jimw@sifive.com>
8537
8538         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8539         (riscv_linux_fregset): New.
8540         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8541
8542 2019-02-07  Tom Tromey  <tom@tromey.com>
8543
8544         * thread.c (thread_cancel_execution_command): Update.
8545         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8546         methods.
8547         (struct thread_fsm_ops): Remove.
8548         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8549         (thread_fsm_should_stop, thread_fsm_return_value)
8550         (thread_fsm_set_finished, thread_fsm_finished_p)
8551         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8552         Don't declare.
8553         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8554         * infrun.c (clear_proceed_status_thread)
8555         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8556         (print_stop_event): Update.
8557         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8558         Add constructor.
8559         (step_command_fsm_ops): Remove.
8560         (new_step_command_fsm): Remove.
8561         (step_1): Update.
8562         (step_command_fsm::should_stop): Rename from
8563         step_command_fsm_should_stop.
8564         (step_command_fsm::clean_up): Rename from
8565         step_command_fsm_clean_up.
8566         (step_command_fsm::do_async_reply_reason): Rename from
8567         step_command_fsm_async_reply_reason.
8568         (struct until_next_fsm): Inherit from thread_fsm.  Add
8569         constructor.
8570         (until_next_fsm_ops): Remove.
8571         (new_until_next_fsm): Remove.
8572         (until_next_fsm::should_stop): Rename from
8573         until_next_fsm_should_stop.
8574         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8575         (until_next_fsm::do_async_reply_reason): Rename from
8576         until_next_fsm_async_reply_reason.
8577         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8578         constructor.  Change type of breakpoint.
8579         (finish_command_fsm_ops): Remove.
8580         (new_finish_command_fsm): Remove.
8581         (finish_command_fsm::should_stop): Rename from
8582         finish_command_fsm_should_stop.
8583         (finish_command_fsm::clean_up): Rename from
8584         finish_command_fsm_clean_up.
8585         (finish_command_fsm::return_value): Rename from
8586         finish_command_fsm_return_value.
8587         (finish_command_fsm::do_async_reply_reason): Rename from
8588         finish_command_fsm_async_reply_reason.
8589         (finish_command): Update.
8590         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8591         Add constructor.
8592         (call_thread_fsm_ops): Remove.
8593         (call_thread_fsm::call_thread_fsm): Rename from
8594         new_call_thread_fsm.
8595         (call_thread_fsm::should_stop): Rename from
8596         call_thread_fsm_should_stop.
8597         (call_thread_fsm::should_notify_stop): Rename from
8598         call_thread_fsm_should_notify_stop.
8599         (run_inferior_call, call_function_by_hand_dummy): Update.
8600         * cli/cli-interp.c (should_print_stop_to_console): Update.
8601         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8602         Add constructor.  Change type of location_breakpoint,
8603         caller_breakpoint.
8604         (until_break_fsm_ops): Remove.
8605         (new_until_break_fsm): Remove.
8606         (until_break_fsm::should_stop): Rename from
8607         until_break_fsm_should_stop.
8608         (until_break_fsm::clean_up): Rename from
8609         until_break_fsm_clean_up.
8610         (until_break_fsm::do_async_reply_reason): Rename from
8611         until_break_fsm_async_reply_reason.
8612         (until_break_command): Update.
8613         * thread-fsm.c: Remove.
8614         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8615
8616 2019-02-07  Tom Tromey  <tom@tromey.com>
8617
8618         * yy-remap.h: Add include guard.
8619         * xtensa-tdep.h: Add include guard.
8620         * xcoffread.h: Rename include guard.
8621         * varobj-iter.h: Add include guard.
8622         * tui/tui.h: Rename include guard.
8623         * tui/tui-winsource.h: Rename include guard.
8624         * tui/tui-wingeneral.h: Rename include guard.
8625         * tui/tui-windata.h: Rename include guard.
8626         * tui/tui-win.h: Rename include guard.
8627         * tui/tui-stack.h: Rename include guard.
8628         * tui/tui-source.h: Rename include guard.
8629         * tui/tui-regs.h: Rename include guard.
8630         * tui/tui-out.h: Rename include guard.
8631         * tui/tui-layout.h: Rename include guard.
8632         * tui/tui-io.h: Rename include guard.
8633         * tui/tui-hooks.h: Rename include guard.
8634         * tui/tui-file.h: Rename include guard.
8635         * tui/tui-disasm.h: Rename include guard.
8636         * tui/tui-data.h: Rename include guard.
8637         * tui/tui-command.h: Rename include guard.
8638         * tic6x-tdep.h: Add include guard.
8639         * target/waitstatus.h: Rename include guard.
8640         * target/wait.h: Rename include guard.
8641         * target/target.h: Rename include guard.
8642         * target/resume.h: Rename include guard.
8643         * target-float.h: Rename include guard.
8644         * stabsread.h: Add include guard.
8645         * rs6000-tdep.h: Add include guard.
8646         * riscv-fbsd-tdep.h: Add include guard.
8647         * regformats/regdef.h: Rename include guard.
8648         * record.h: Rename include guard.
8649         * python/python.h: Rename include guard.
8650         * python/python-internal.h: Rename include guard.
8651         * python/py-stopevent.h: Rename include guard.
8652         * python/py-ref.h: Rename include guard.
8653         * python/py-record.h: Rename include guard.
8654         * python/py-record-full.h: Rename include guard.
8655         * python/py-record-btrace.h: Rename include guard.
8656         * python/py-instruction.h: Rename include guard.
8657         * python/py-events.h: Rename include guard.
8658         * python/py-event.h: Rename include guard.
8659         * procfs.h: Add include guard.
8660         * proc-utils.h: Add include guard.
8661         * p-lang.h: Add include guard.
8662         * or1k-tdep.h: Rename include guard.
8663         * observable.h: Rename include guard.
8664         * nto-tdep.h: Rename include guard.
8665         * nat/x86-linux.h: Rename include guard.
8666         * nat/x86-linux-dregs.h: Rename include guard.
8667         * nat/x86-gcc-cpuid.h: Add include guard.
8668         * nat/x86-dregs.h: Rename include guard.
8669         * nat/x86-cpuid.h: Rename include guard.
8670         * nat/ppc-linux.h: Rename include guard.
8671         * nat/mips-linux-watch.h: Rename include guard.
8672         * nat/linux-waitpid.h: Rename include guard.
8673         * nat/linux-ptrace.h: Rename include guard.
8674         * nat/linux-procfs.h: Rename include guard.
8675         * nat/linux-osdata.h: Rename include guard.
8676         * nat/linux-nat.h: Rename include guard.
8677         * nat/linux-namespaces.h: Rename include guard.
8678         * nat/linux-btrace.h: Rename include guard.
8679         * nat/glibc_thread_db.h: Rename include guard.
8680         * nat/gdb_thread_db.h: Rename include guard.
8681         * nat/gdb_ptrace.h: Rename include guard.
8682         * nat/fork-inferior.h: Rename include guard.
8683         * nat/amd64-linux-siginfo.h: Rename include guard.
8684         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8685         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8686         * nat/aarch64-linux.h: Rename include guard.
8687         * nat/aarch64-linux-hw-point.h: Rename include guard.
8688         * mn10300-tdep.h: Add include guard.
8689         * mips-linux-tdep.h: Add include guard.
8690         * mi/mi-parse.h: Rename include guard.
8691         * mi/mi-out.h: Rename include guard.
8692         * mi/mi-main.h: Rename include guard.
8693         * mi/mi-interp.h: Rename include guard.
8694         * mi/mi-getopt.h: Rename include guard.
8695         * mi/mi-console.h: Rename include guard.
8696         * mi/mi-common.h: Rename include guard.
8697         * mi/mi-cmds.h: Rename include guard.
8698         * mi/mi-cmd-break.h: Rename include guard.
8699         * m2-lang.h: Add include guard.
8700         * location.h: Rename include guard.
8701         * linux-record.h: Rename include guard.
8702         * linux-nat.h: Add include guard.
8703         * linux-fork.h: Add include guard.
8704         * i386-darwin-tdep.h: Rename include guard.
8705         * hppa-linux-offsets.h: Add include guard.
8706         * guile/guile.h: Rename include guard.
8707         * guile/guile-internal.h: Rename include guard.
8708         * gnu-nat.h: Rename include guard.
8709         * gdb-stabs.h: Rename include guard.
8710         * frv-tdep.h: Add include guard.
8711         * f-lang.h: Add include guard.
8712         * event-loop.h: Add include guard.
8713         * darwin-nat.h: Rename include guard.
8714         * cp-abi.h: Rename include guard.
8715         * config/sparc/nm-sol2.h: Rename include guard.
8716         * config/nm-nto.h: Rename include guard.
8717         * config/nm-linux.h: Add include guard.
8718         * config/i386/nm-i386gnu.h: Rename include guard.
8719         * config/djgpp/nl_types.h: Rename include guard.
8720         * config/djgpp/langinfo.h: Rename include guard.
8721         * compile/gcc-cp-plugin.h: Add include guard.
8722         * compile/gcc-c-plugin.h: Add include guard.
8723         * compile/compile.h: Rename include guard.
8724         * compile/compile-object-run.h: Rename include guard.
8725         * compile/compile-object-load.h: Rename include guard.
8726         * compile/compile-internal.h: Rename include guard.
8727         * compile/compile-cplus.h: Rename include guard.
8728         * compile/compile-c.h: Rename include guard.
8729         * common/xml-utils.h: Rename include guard.
8730         * common/x86-xstate.h: Rename include guard.
8731         * common/version.h: Rename include guard.
8732         * common/vec.h: Rename include guard.
8733         * common/tdesc.h: Rename include guard.
8734         * common/selftest.h: Rename include guard.
8735         * common/scoped_restore.h: Rename include guard.
8736         * common/scoped_mmap.h: Rename include guard.
8737         * common/scoped_fd.h: Rename include guard.
8738         * common/safe-iterator.h: Rename include guard.
8739         * common/run-time-clock.h: Rename include guard.
8740         * common/refcounted-object.h: Rename include guard.
8741         * common/queue.h: Rename include guard.
8742         * common/ptid.h: Rename include guard.
8743         * common/print-utils.h: Rename include guard.
8744         * common/preprocessor.h: Rename include guard.
8745         * common/pathstuff.h: Rename include guard.
8746         * common/observable.h: Rename include guard.
8747         * common/netstuff.h: Rename include guard.
8748         * common/job-control.h: Rename include guard.
8749         * common/host-defs.h: Rename include guard.
8750         * common/gdb_wait.h: Rename include guard.
8751         * common/gdb_vecs.h: Rename include guard.
8752         * common/gdb_unlinker.h: Rename include guard.
8753         * common/gdb_unique_ptr.h: Rename include guard.
8754         * common/gdb_tilde_expand.h: Rename include guard.
8755         * common/gdb_sys_time.h: Rename include guard.
8756         * common/gdb_string_view.h: Rename include guard.
8757         * common/gdb_splay_tree.h: Rename include guard.
8758         * common/gdb_setjmp.h: Rename include guard.
8759         * common/gdb_ref_ptr.h: Rename include guard.
8760         * common/gdb_optional.h: Rename include guard.
8761         * common/gdb_locale.h: Rename include guard.
8762         * common/gdb_assert.h: Rename include guard.
8763         * common/filtered-iterator.h: Rename include guard.
8764         * common/filestuff.h: Rename include guard.
8765         * common/fileio.h: Rename include guard.
8766         * common/environ.h: Rename include guard.
8767         * common/common-utils.h: Rename include guard.
8768         * common/common-types.h: Rename include guard.
8769         * common/common-regcache.h: Rename include guard.
8770         * common/common-inferior.h: Rename include guard.
8771         * common/common-gdbthread.h: Rename include guard.
8772         * common/common-exceptions.h: Rename include guard.
8773         * common/common-defs.h: Rename include guard.
8774         * common/common-debug.h: Rename include guard.
8775         * common/cleanups.h: Rename include guard.
8776         * common/buffer.h: Rename include guard.
8777         * common/btrace-common.h: Rename include guard.
8778         * common/break-common.h: Rename include guard.
8779         * cli/cli-utils.h: Rename include guard.
8780         * cli/cli-style.h: Rename include guard.
8781         * cli/cli-setshow.h: Rename include guard.
8782         * cli/cli-script.h: Rename include guard.
8783         * cli/cli-interp.h: Rename include guard.
8784         * cli/cli-decode.h: Rename include guard.
8785         * cli/cli-cmds.h: Rename include guard.
8786         * charset-list.h: Add include guard.
8787         * buildsym-legacy.h: Rename include guard.
8788         * bfin-tdep.h: Add include guard.
8789         * ax.h: Rename include guard.
8790         * arm-linux-tdep.h: Add include guard.
8791         * arm-fbsd-tdep.h: Add include guard.
8792         * arch/xtensa.h: Rename include guard.
8793         * arch/tic6x.h: Add include guard.
8794         * arch/i386.h: Add include guard.
8795         * arch/arm.h: Rename include guard.
8796         * arch/arm-linux.h: Rename include guard.
8797         * arch/arm-get-next-pcs.h: Rename include guard.
8798         * arch/amd64.h: Add include guard.
8799         * arch/aarch64-insn.h: Rename include guard.
8800         * arch-utils.h: Rename include guard.
8801         * annotate.h: Add include guard.
8802         * amd64-darwin-tdep.h: Rename include guard.
8803         * aarch64-linux-tdep.h: Add include guard.
8804         * aarch64-fbsd-tdep.h: Add include guard.
8805         * aarch32-linux-nat.h: Add include guard.
8806
8807 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8808
8809         * macrotab.c (macro_define_internal): New function that
8810         factorizes macro_define_object_internal and macro_define_function
8811         code.
8812         (macro_define_object_internal): Use macro_define_internal.
8813         (macro_define_function): Likewise.
8814
8815 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8816
8817         * macrocmd.c (extract_identifier): Return
8818         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8819         callers.
8820
8821 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8822
8823         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8824
8825 2019-02-05  Tom Tromey  <tom@tromey.com>
8826
8827         * target.c (target_stack::unpush): Move assertion earlier.
8828
8829 2019-01-30  Tom Tromey  <tom@tromey.com>
8830
8831         PR python/23615:
8832         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8833         (gdbpy_parse_and_eval): Likewise.
8834         * python/python-internal.h (gdbpy_allow_threads): New class.
8835
8836 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8837
8838         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8839         (aarch64_fbsd_fpregmap): Move earlier.
8840         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8841         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8842         instead of individual calls to trad_frame_set_reg_addr.
8843         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8844         earlier.
8845         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8846         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8847         instead of individual calls to trad_frame_set_reg_addr.
8848
8849 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8850
8851         * CONTRIBUTE: Replace contribution list with wiki link.
8852
8853 2019-01-25  Tom Tromey  <tom@tromey.com>
8854
8855         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8856
8857 2019-01-25  Tom Tromey  <tom@tromey.com>
8858
8859         * xtensa-linux-nat.c: Fix common/ includes.
8860         * xml-support.h: Fix common/ includes.
8861         * xml-support.c: Fix common/ includes.
8862         * x86-linux-nat.c: Fix common/ includes.
8863         * windows-nat.c: Fix common/ includes.
8864         * varobj.h: Fix common/ includes.
8865         * varobj.c: Fix common/ includes.
8866         * value.c: Fix common/ includes.
8867         * valops.c: Fix common/ includes.
8868         * utils.c: Fix common/ includes.
8869         * unittests/xml-utils-selftests.c: Fix common/ includes.
8870         * unittests/utils-selftests.c: Fix common/ includes.
8871         * unittests/unpack-selftests.c: Fix common/ includes.
8872         * unittests/tracepoint-selftests.c: Fix common/ includes.
8873         * unittests/style-selftests.c: Fix common/ includes.
8874         * unittests/string_view-selftests.c: Fix common/ includes.
8875         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8876         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8877         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8878         * unittests/rsp-low-selftests.c: Fix common/ includes.
8879         * unittests/parse-connection-spec-selftests.c: Fix common/
8880         includes.
8881         * unittests/optional-selftests.c: Fix common/ includes.
8882         * unittests/offset-type-selftests.c: Fix common/ includes.
8883         * unittests/observable-selftests.c: Fix common/ includes.
8884         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8885         * unittests/memrange-selftests.c: Fix common/ includes.
8886         * unittests/memory-map-selftests.c: Fix common/ includes.
8887         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8888         * unittests/function-view-selftests.c: Fix common/ includes.
8889         * unittests/environ-selftests.c: Fix common/ includes.
8890         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8891         * unittests/common-utils-selftests.c: Fix common/ includes.
8892         * unittests/cli-utils-selftests.c: Fix common/ includes.
8893         * unittests/array-view-selftests.c: Fix common/ includes.
8894         * ui-file.c: Fix common/ includes.
8895         * tui/tui-io.c: Fix common/ includes.
8896         * tracepoint.h: Fix common/ includes.
8897         * tracepoint.c: Fix common/ includes.
8898         * tracefile-tfile.c: Fix common/ includes.
8899         * top.h: Fix common/ includes.
8900         * top.c: Fix common/ includes.
8901         * thread.c: Fix common/ includes.
8902         * target/waitstatus.h: Fix common/ includes.
8903         * target/waitstatus.c: Fix common/ includes.
8904         * target.h: Fix common/ includes.
8905         * target.c: Fix common/ includes.
8906         * target-memory.c: Fix common/ includes.
8907         * target-descriptions.c: Fix common/ includes.
8908         * symtab.h: Fix common/ includes.
8909         * symfile.c: Fix common/ includes.
8910         * stap-probe.c: Fix common/ includes.
8911         * spu-linux-nat.c: Fix common/ includes.
8912         * sparc-nat.c: Fix common/ includes.
8913         * source.c: Fix common/ includes.
8914         * solib.c: Fix common/ includes.
8915         * solib-target.c: Fix common/ includes.
8916         * ser-unix.c: Fix common/ includes.
8917         * ser-tcp.c: Fix common/ includes.
8918         * ser-pipe.c: Fix common/ includes.
8919         * ser-base.c: Fix common/ includes.
8920         * selftest-arch.c: Fix common/ includes.
8921         * s12z-tdep.c: Fix common/ includes.
8922         * rust-exp.y: Fix common/ includes.
8923         * rs6000-aix-tdep.c: Fix common/ includes.
8924         * riscv-tdep.c: Fix common/ includes.
8925         * remote.c: Fix common/ includes.
8926         * remote-notif.h: Fix common/ includes.
8927         * remote-fileio.h: Fix common/ includes.
8928         * remote-fileio.c: Fix common/ includes.
8929         * regcache.h: Fix common/ includes.
8930         * regcache.c: Fix common/ includes.
8931         * record-btrace.c: Fix common/ includes.
8932         * python/python.c: Fix common/ includes.
8933         * python/py-type.c: Fix common/ includes.
8934         * python/py-inferior.c: Fix common/ includes.
8935         * progspace.h: Fix common/ includes.
8936         * producer.c: Fix common/ includes.
8937         * procfs.c: Fix common/ includes.
8938         * proc-api.c: Fix common/ includes.
8939         * printcmd.c: Fix common/ includes.
8940         * ppc-linux-nat.c: Fix common/ includes.
8941         * parser-defs.h: Fix common/ includes.
8942         * osdata.c: Fix common/ includes.
8943         * obsd-nat.c: Fix common/ includes.
8944         * nat/x86-linux.c: Fix common/ includes.
8945         * nat/x86-linux-dregs.c: Fix common/ includes.
8946         * nat/x86-dregs.h: Fix common/ includes.
8947         * nat/x86-dregs.c: Fix common/ includes.
8948         * nat/ppc-linux.c: Fix common/ includes.
8949         * nat/mips-linux-watch.h: Fix common/ includes.
8950         * nat/mips-linux-watch.c: Fix common/ includes.
8951         * nat/linux-waitpid.c: Fix common/ includes.
8952         * nat/linux-ptrace.h: Fix common/ includes.
8953         * nat/linux-ptrace.c: Fix common/ includes.
8954         * nat/linux-procfs.c: Fix common/ includes.
8955         * nat/linux-personality.c: Fix common/ includes.
8956         * nat/linux-osdata.c: Fix common/ includes.
8957         * nat/linux-namespaces.c: Fix common/ includes.
8958         * nat/linux-btrace.h: Fix common/ includes.
8959         * nat/linux-btrace.c: Fix common/ includes.
8960         * nat/fork-inferior.c: Fix common/ includes.
8961         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8962         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8963         * nat/aarch64-linux.c: Fix common/ includes.
8964         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8965         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8966         * namespace.h: Fix common/ includes.
8967         * mips-linux-tdep.c: Fix common/ includes.
8968         * minsyms.c: Fix common/ includes.
8969         * mi/mi-parse.h: Fix common/ includes.
8970         * mi/mi-main.c: Fix common/ includes.
8971         * mi/mi-cmd-env.c: Fix common/ includes.
8972         * memrange.h: Fix common/ includes.
8973         * memattr.c: Fix common/ includes.
8974         * maint.h: Fix common/ includes.
8975         * maint.c: Fix common/ includes.
8976         * main.c: Fix common/ includes.
8977         * machoread.c: Fix common/ includes.
8978         * location.c: Fix common/ includes.
8979         * linux-thread-db.c: Fix common/ includes.
8980         * linux-nat.c: Fix common/ includes.
8981         * linux-fork.c: Fix common/ includes.
8982         * inline-frame.c: Fix common/ includes.
8983         * infrun.c: Fix common/ includes.
8984         * inflow.c: Fix common/ includes.
8985         * inferior.h: Fix common/ includes.
8986         * inferior.c: Fix common/ includes.
8987         * infcmd.c: Fix common/ includes.
8988         * inf-ptrace.c: Fix common/ includes.
8989         * inf-child.c: Fix common/ includes.
8990         * ia64-linux-nat.c: Fix common/ includes.
8991         * i387-tdep.c: Fix common/ includes.
8992         * i386-tdep.c: Fix common/ includes.
8993         * i386-linux-tdep.c: Fix common/ includes.
8994         * i386-linux-nat.c: Fix common/ includes.
8995         * i386-go32-tdep.c: Fix common/ includes.
8996         * i386-fbsd-tdep.c: Fix common/ includes.
8997         * i386-fbsd-nat.c: Fix common/ includes.
8998         * guile/scm-type.c: Fix common/ includes.
8999         * guile/guile.c: Fix common/ includes.
9000         * go32-nat.c: Fix common/ includes.
9001         * gnu-nat.c: Fix common/ includes.
9002         * gdbthread.h: Fix common/ includes.
9003         * gdbarch-selftests.c: Fix common/ includes.
9004         * gdb_usleep.c: Fix common/ includes.
9005         * gdb_select.h: Fix common/ includes.
9006         * gdb_bfd.c: Fix common/ includes.
9007         * gcore.c: Fix common/ includes.
9008         * fork-child.c: Fix common/ includes.
9009         * findvar.c: Fix common/ includes.
9010         * fbsd-nat.c: Fix common/ includes.
9011         * event-top.c: Fix common/ includes.
9012         * event-loop.c: Fix common/ includes.
9013         * dwarf2read.c: Fix common/ includes.
9014         * dwarf2loc.c: Fix common/ includes.
9015         * dwarf2-frame.c: Fix common/ includes.
9016         * dwarf-index-cache.c: Fix common/ includes.
9017         * dtrace-probe.c: Fix common/ includes.
9018         * disasm-selftests.c: Fix common/ includes.
9019         * defs.h: Fix common/ includes.
9020         * csky-tdep.c: Fix common/ includes.
9021         * cp-valprint.c: Fix common/ includes.
9022         * cp-support.h: Fix common/ includes.
9023         * cp-support.c: Fix common/ includes.
9024         * corelow.c: Fix common/ includes.
9025         * completer.h: Fix common/ includes.
9026         * completer.c: Fix common/ includes.
9027         * compile/compile.c: Fix common/ includes.
9028         * compile/compile-loc2c.c: Fix common/ includes.
9029         * compile/compile-cplus-types.c: Fix common/ includes.
9030         * compile/compile-cplus-symbols.c: Fix common/ includes.
9031         * command.h: Fix common/ includes.
9032         * cli/cli-dump.c: Fix common/ includes.
9033         * cli/cli-cmds.c: Fix common/ includes.
9034         * charset.c: Fix common/ includes.
9035         * build-id.c: Fix common/ includes.
9036         * btrace.h: Fix common/ includes.
9037         * btrace.c: Fix common/ includes.
9038         * breakpoint.h: Fix common/ includes.
9039         * breakpoint.c: Fix common/ includes.
9040         * ax.h:
9041         (enum agent_op): Fix common/ includes.
9042         * ax-general.c (struct aop_map): Fix common/ includes.
9043         * ax-gdb.c: Fix common/ includes.
9044         * auxv.c: Fix common/ includes.
9045         * auto-load.c: Fix common/ includes.
9046         * arm-tdep.c: Fix common/ includes.
9047         * arch/riscv.c: Fix common/ includes.
9048         * arch/ppc-linux-common.c: Fix common/ includes.
9049         * arch/i386.c: Fix common/ includes.
9050         * arch/arm.c: Fix common/ includes.
9051         * arch/arm-linux.c: Fix common/ includes.
9052         * arch/arm-get-next-pcs.c: Fix common/ includes.
9053         * arch/amd64.c: Fix common/ includes.
9054         * arch/aarch64.c: Fix common/ includes.
9055         * arch/aarch64-insn.c: Fix common/ includes.
9056         * arch-utils.c: Fix common/ includes.
9057         * amd64-windows-tdep.c: Fix common/ includes.
9058         * amd64-tdep.c: Fix common/ includes.
9059         * amd64-sol2-tdep.c: Fix common/ includes.
9060         * amd64-obsd-tdep.c: Fix common/ includes.
9061         * amd64-nbsd-tdep.c: Fix common/ includes.
9062         * amd64-linux-tdep.c: Fix common/ includes.
9063         * amd64-linux-nat.c: Fix common/ includes.
9064         * amd64-fbsd-tdep.c: Fix common/ includes.
9065         * amd64-fbsd-nat.c: Fix common/ includes.
9066         * amd64-dicos-tdep.c: Fix common/ includes.
9067         * amd64-darwin-tdep.c: Fix common/ includes.
9068         * agent.c: Fix common/ includes.
9069         * ada-lang.h: Fix common/ includes.
9070         * ada-lang.c: Fix common/ includes.
9071         * aarch64-tdep.c: Fix common/ includes.
9072
9073 2019-01-25  Tom Tromey  <tom@tromey.com>
9074
9075         * common/create-version.sh: Use common/version.h.
9076
9077 2019-01-24  Pedro Alves  <palves@redhat.com>
9078
9079         * infrun.c (signal_stop, signal_print, signal_program)
9080         (signal_catch, signal_pass): Now arrays instead of pointers.
9081         (update_signals_program_target, do_target_resume)
9082         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9083         * linux-nat.c (linux_nat_target::pass_signals)
9084         (linux_nat_target::create_inferior, linux_nat_target::attach):
9085         Adjust.
9086         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9087         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9088         * procfs.c (procfs_target::pass_signals): Adjust.
9089         * record-full.c (record_full_target::resume): Adjust.
9090         * remote.c (remote_target::pass_signals)
9091         (remote_target::program_signals): Adjust.
9092         * target-debug.h (target_debug_print_signals): Now takes a
9093         gdb::array_view as parameter.  Adjust.
9094         * target.h (target_ops) <pass_signals, program_signals>: Replace
9095         pointer and length parameters with gdb::array_view.
9096         (target_pass_signals, target_program_signals): Likewise.
9097         * target-delegates.c: Regenerate.
9098
9099 2019-01-24  Pedro Alves  <palves@redhat.com>
9100
9101         * common/forward-scope-exit.h
9102         (forward_scope_exit::forward_scope_exit): Pass arguments to
9103         m_bind_function directly, instead of creating a std::bind and
9104         copying that.
9105
9106 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9107
9108         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9109         for static members.
9110         (pass_in_v_vfp_candidate): Likewise.
9111
9112 2019-01-23  Tom Tromey  <tom@tromey.com>
9113             Pedro Alves  <palves@redhat.com>
9114
9115         * regcache.c (class regcache_invalidator): Remove.
9116         (regcache::raw_write): Use make_scope_exit.
9117
9118 2019-01-23  Tom Tromey  <tom@tromey.com>
9119
9120         * ui-out.h (class ui_out_emit_type): Update comment.
9121
9122 2019-01-23  Tom Tromey  <tom@tromey.com>
9123
9124         * infrun.c (fetch_inferior_event): Update comment.
9125
9126 2019-01-23  Tom Tromey  <tom@tromey.com>
9127             Pedro Alves  <palves@redhat.com>
9128
9129         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9130         parameter.
9131         (fetch_inferior_event): Use SCOPE_EXIT.
9132
9133
9134 2019-01-23  Tom Tromey  <tom@tromey.com>
9135             Pedro Alves  <palves@redhat.com>
9136
9137         * infrun.c (disable_thread_events): Delete.
9138         (stop_all_threads): Use SCOPE_EXIT.
9139
9140 2019-01-23  Tom Tromey  <tom@tromey.com>
9141             Pedro Alves  <palves@redhat.com>
9142
9143         * symfile.c: Include forward-scope-exit.h.
9144         (clear_symtab_users_cleanup): Replace forward declaration with
9145         a FORWARD_SCOPE_EXIT.
9146         (syms_from_objfile_1): Use the forward_scope_exit and
9147         gdb::optional instead of cleanup_function.
9148         (reread_symbols): Use the forward_scope_exit instead of
9149         cleanup_function.
9150         (clear_symtab_users_cleanup): Remove function.
9151
9152 2019-01-23  Tom Tromey  <tom@tromey.com>
9153             Pedro Alves  <palves@redhat.com>
9154
9155         * linux-nat.c: Include scope-exit.h.
9156         (cleanup_target_stop): Remove.
9157         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9158         SCOPE_EXIT.
9159
9160 2019-01-23  Tom Tromey  <tom@tromey.com>
9161             Pedro Alves  <palves@redhat.com>
9162
9163         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9164         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9165
9166 2019-01-23  Tom Tromey  <tom@tromey.com>
9167             Andrew Burgess  <andrew.burgess@embecosm.com>
9168             Pedro Alves  <palves@redhat.com>
9169
9170         * infrun.c (fetch_inferior_event): Use scope_exit.
9171         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9172         * top.c (execute_command): Use scope_exit.
9173         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9174         * utils.c (do_bpstat_clear_actions_cleanup)
9175         (make_bpstat_clear_actions_cleanup): Remove.
9176
9177 2019-01-23  Tom Tromey  <tom@tromey.com>
9178             Pedro Alves  <palves@redhat.com>
9179
9180         * infrun.c: Include "common/scope-exit.h"
9181         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9182         (wait_for_inferior): Use SCOPE_EXIT.
9183         (fetch_inferior_event): Use scope_exit.
9184
9185 2019-01-23  Tom Tromey  <tom@tromey.com>
9186             Pedro Alves  <palves@redhat.com>
9187
9188         * breakpoint.c (create_breakpoint): Remove cleanup.
9189
9190 2019-01-23  Tom Tromey  <tom@tromey.com>
9191             Andrew Burgess  <andrew.burgess@embecosm.com>
9192             Pedro Alves  <palves@redhat.com>
9193
9194 2019-01-23  Pedro Alves  <palves@redhat.com>
9195
9196         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9197
9198 2019-01-23  Pedro Alves  <palves@redhat.com>
9199             Andrew Burgess  <andrew.burgess@embecosm.com>
9200
9201         * gdbthread.h: Include "common/forward-scope-exit.h".
9202         (scoped_finish_thread_state): Redefine custom class in terms of
9203         forward_scope_exit.
9204
9205 2019-01-23  Pedro Alves  <palves@redhat.com>
9206             Andrew Burgess  <andrew.burgess@embecosm.com>
9207
9208         * common/forward-scope-exit.h: New file.
9209
9210 2019-01-23  Pedro Alves  <palves@redhat.com>
9211             Andrew Burgess  <andrew.burgess@embecosm.com>
9212             Tom Tromey  <tom@tromey.com>
9213
9214         * common/scope-exit.h: New file.
9215
9216 2019-01-23  Pedro Alves  <palves@redhat.com>
9217
9218         * common/preprocessor.h (ESC): Rename to ...
9219         (ESC_PARENS): ... this.
9220         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9221         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9222
9223 2019-01-23  Tom Tromey  <tom@tromey.com>
9224
9225         * language.h (class scoped_switch_to_sym_language_if_auto):
9226         Initialize m_lang in both cases.
9227
9228 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9229
9230         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9231         with XCNEW.
9232
9233 2019-01-22  Tom Tromey  <tom@tromey.com>
9234
9235         * corelow.c: Do not include sys/file.h.
9236
9237 2019-01-22  Tom Tromey  <tom@tromey.com>
9238
9239         * tui/tui-wingeneral.h: Include gdb_curses.h.
9240
9241 2019-01-22  Tom Tromey  <tom@tromey.com>
9242
9243         * source-cache.h (class source_cache) <get_source_lines,
9244         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9245
9246 2019-01-22  Tom Tromey  <tom@tromey.com>
9247
9248         * remote-fileio.h (struct remote_target): Declare.
9249
9250 2019-01-22  Tom Tromey  <tom@tromey.com>
9251
9252         * python/py-arch.c: Do not include py-ref.h.
9253         * python/py-bpevent.c: Do not include py-ref.h.
9254         * python/py-cmd.c: Do not include py-ref.h.
9255         * python/py-continueevent.c: Do not include py-ref.h.
9256         * python/py-event.h: Do not include py-ref.h.
9257         * python/py-evtregistry.c: Do not include py-ref.h.
9258         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9259         * python/py-frame.c: Do not include py-ref.h.
9260         * python/py-framefilter.c: Do not include py-ref.h.
9261         * python/py-function.c: Do not include py-ref.h.
9262         * python/py-infevents.c: Do not include py-ref.h.
9263         * python/py-linetable.c: Do not include py-ref.h.
9264         * python/py-objfile.c: Do not include py-ref.h.
9265         * python/py-param.c: Do not include py-ref.h.
9266         * python/py-prettyprint.c: Do not include py-ref.h.
9267         * python/py-progspace.c: Do not include py-ref.h.
9268         * python/py-symbol.c: Do not include py-ref.h.
9269         * python/py-symtab.c: Do not include py-ref.h.
9270         * python/py-type.c: Do not include py-ref.h.
9271         * python/py-unwind.c: Do not include py-ref.h.
9272         * python/py-utils.c: Do not include py-ref.h.
9273         * python/py-value.c: Do not include py-ref.h.
9274         * python/py-varobj.c: Do not include py-ref.h.
9275         * python/py-xmethods.c: Do not include py-ref.h.
9276         * python/python.c: Do not include py-ref.h.
9277         * varobj.c: Do not include py-ref.h.
9278
9279 2019-01-22  Tom Tromey  <tom@tromey.com>
9280
9281         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9282         keyword for bcache.
9283
9284 2019-01-22  Tom Tromey  <tom@tromey.com>
9285
9286         * compile/compile-cplus-types.c: Remove a comment by #include.
9287
9288 2019-01-22  Tom Tromey  <tom@tromey.com>
9289
9290         * compile/gcc-c-plugin.h: Include compile-internal.h.
9291
9292 2019-01-22  Tom Tromey  <tom@tromey.com>
9293
9294         * stabsread.c (EXTERN): Do not define.
9295         (symnum, next_symbol_text_func, processing_gcc_compilation)
9296         (within_function, global_sym_chain, global_stabs)
9297         (previous_stab_code, this_object_header_files)
9298         (n_this_object_header_files)
9299         (n_allocated_this_object_header_files): Define.
9300         * stabsread.h (EXTERN): Never define.  Use "extern".
9301
9302 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9303
9304         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9305         history_value.
9306
9307 2019-01-21  Tom Tromey  <tom@tromey.com>
9308
9309         * ui-out.c: Fix includes.
9310         * tui/tui-source.c: Fix includes.
9311         * target.c: Fix includes.
9312         * remote.c: Fix includes.
9313         * regcache.c: Fix includes.
9314         * python/py-block.c: Fix includes.
9315         * printcmd.c: Fix includes.
9316         * or1k-tdep.c: Fix includes.
9317         * mi/mi-main.c: Fix includes.
9318         * m32r-tdep.c: Fix includes.
9319         * csky-tdep.c: Fix includes.
9320         * compile/compile-cplus-types.c: Fix includes.
9321         * cli/cli-interp.c: Fix includes.
9322
9323 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9324
9325         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9326         for padding.
9327
9328 2019-01-16  Tom Tromey  <tom@tromey.com>
9329
9330         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9331         earlier.
9332         (struct objfile) <msymbols_range>: Move from top level.
9333         <msymbols>: New method.
9334         (class objfile_msymbols): Remove.
9335         * symtab.c (default_collect_symbol_completion_matches_break_on):
9336         Update.
9337         * symmisc.c (dump_msymbols): Update.
9338         * stabsread.c (scan_file_globals): Update.
9339         * objc-lang.c (info_selectors_command, info_classes_command)
9340         (find_methods): Update.
9341         * minsyms.c (find_solib_trampoline_target): Update.
9342         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9343         * coffread.c (coff_symfile_read): Update.
9344         * ada-lang.c (ada_lookup_simple_minsym)
9345         (ada_collect_symbol_completion_matches): Update.
9346
9347 2019-01-16  Tom Tromey  <tom@tromey.com>
9348
9349         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9350         type.  Remove no-argument constructor.
9351         <iterator::operator++>: Simplify.
9352         <begin>: Update.
9353         <end>: Use minimal_symbol_count.
9354
9355 2019-01-16  Tom Tromey  <tom@tromey.com>
9356
9357         * objfiles.h (struct objfile) <psymtabs>: New method.
9358         (class objfile_psymtabs): Remove.
9359         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9360         typedef.
9361         <range>: New method.
9362         (require_partial_symbols): Change return type.
9363         * psymtab.c (require_partial_symbols)
9364         (psym_expand_symtabs_matching): Update.
9365         * mdebugread.c (parse_partial_symbols): Update.
9366         * dbxread.c (dbx_end_psymtab): Update.
9367
9368 2019-01-15  Tom Tromey  <tom@tromey.com>
9369
9370         * symtab.c (lookup_objfile_from_block)
9371         (lookup_symbol_in_objfile_symtabs)
9372         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9373         (find_line_symtab, info_sources_command)
9374         (default_collect_symbol_completion_matches_break_on)
9375         (make_source_files_completion_list): Update.
9376         * symmisc.c (print_objfile_statistics, dump_objfile)
9377         (maintenance_print_symbols, maintenance_info_symtabs)
9378         (maintenance_check_symtabs, maintenance_info_line_tables):
9379         Update.
9380         * source.c (select_source_symtab)
9381         (forget_cached_source_info_for_objfile): Update.
9382         * objfiles.h (class objfile_compunits): Remove.
9383         (struct objfile) <compunits_range>: New typedef.
9384         (compunits): New method.
9385         * objfiles.c (objfile_relocate1): Update.
9386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9387         * maint.c (count_symtabs_and_blocks): Update.
9388         * linespec.c (iterate_over_all_matching_symtabs): Update.
9389         * cp-support.c (add_symbol_overload_list_qualified): Update.
9390         * coffread.c (coff_symtab_read): Update.
9391         * ada-lang.c (add_nonlocal_symbols)
9392         (ada_collect_symbol_completion_matches)
9393         (ada_add_global_exceptions): Update.
9394
9395 2019-01-15  Tom Tromey  <tom@tromey.com>
9396
9397         * progspace.h (program_space) <objfiles_safe_range>: New
9398         typedef.
9399         <objfiles_safe>: New method.
9400         * objfiles.h (class all_objfiles_safe): Remove.
9401         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9402         * jit.c (jit_inferior_exit_hook): Update.
9403
9404 2019-01-17  Tom Tromey  <tom@tromey.com>
9405
9406         * progspace.h (program_space) <objfiles_range>: New typedef.
9407         <objfiles>: New method.
9408         <objfiles_head>: Rename from objfiles.
9409         (object_files): Update.
9410         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9411         * guile/scm-pretty-print.c
9412         (ppscm_find_pretty_printer_from_objfiles): Update.
9413         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9414         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9415         Update.
9416         * python/py-progspace.c (pspy_get_objfiles): Update.
9417         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9418         Update.
9419         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9420         (objfpy_lookup_objfile_by_build_id): Update.
9421         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9422         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9423         Update.
9424         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9425         (expand_symtab_containing_pc, lookup_objfile_from_block)
9426         (lookup_static_symbol, basic_lookup_transparent_type)
9427         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9428         (find_line_symtab, info_sources_command)
9429         (default_collect_symbol_completion_matches_break_on)
9430         (make_source_files_completion_list, find_main_name): Update.
9431         * symmisc.c (print_symbol_bcache_statistics)
9432         (print_objfile_statistics, maintenance_print_symbols)
9433         (maintenance_print_msymbols, maintenance_print_objfiles)
9434         (maintenance_info_symtabs, maintenance_check_symtabs)
9435         (maintenance_expand_symtabs, maintenance_info_line_tables):
9436         Update.
9437         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9438         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9439         (map_overlay_command, unmap_overlay_command)
9440         (simple_overlay_update, expand_symtabs_matching)
9441         (map_symbol_filenames): Update.
9442         * symfile-debug.c (set_debug_symfile): Update.
9443         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9444         Update.
9445         * source.c (select_source_symtab, forget_cached_source_info):
9446         Update.
9447         * solib.c (solib_read_symbols): Update.
9448         * solib-spu.c (append_ocl_sos): Update.
9449         * psymtab.c (maintenance_print_psymbols)
9450         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9451         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9452         * printcmd.c (info_symbol_command): Update.
9453         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9454         Update.
9455         * objfiles.h (class all_objfiles): Remove.
9456         * objfiles.c (have_partial_symbols, have_full_symbols)
9457         (have_minimal_symbols, qsort_cmp, update_section_map)
9458         (shared_objfile_contains_address_p)
9459         (default_iterate_over_objfiles_in_search_order): Update.
9460         * objc-lang.c (info_selectors_command, info_classes_command)
9461         (find_methods): Update.
9462         * minsyms.c (find_solib_trampoline_target): Update.
9463         * maint.c (maintenance_info_sections)
9464         (maintenance_translate_address, count_symtabs_and_blocks):
9465         Update.
9466         * main.c (captured_main_1): Update.
9467         * linux-thread-db.c (try_thread_db_load_from_pdir)
9468         (has_libpthread): Update.
9469         * linespec.c (iterate_over_all_matching_symtabs)
9470         (search_minsyms_for_name): Update.
9471         * jit.c (jit_find_objf_with_entry_addr): Update.
9472         * hppa-tdep.c (find_unwind_entry)
9473         (hppa_lookup_stub_minimal_symbol): Update.
9474         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9475         Update.
9476         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9477         (elf_gnu_ifunc_resolve_by_got): Update.
9478         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9479         * dwarf-index-write.c (save_gdb_index_command): Update.
9480         * cp-support.c (add_symbol_overload_list_qualified): Update.
9481         * breakpoint.c (create_overlay_event_breakpoint)
9482         (create_longjmp_master_breakpoint)
9483         (create_std_terminate_master_breakpoint)
9484         (create_exception_master_breakpoint): Update.
9485         * blockframe.c (find_pc_partial_function): Update.
9486         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9487         (ada_collect_symbol_completion_matches)
9488         (ada_add_global_exceptions): Update.
9489
9490 2019-01-17  Tom Tromey  <tom@tromey.com>
9491
9492         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9493         declare VEC.
9494         (solib_target_parse_libraries): Change return type.
9495         (library_list_start_segment, library_list_start_section)
9496         (library_list_end_library, library_list_start_library); Update.
9497         (solib_target_free_library_list): Remove.
9498         (solib_target_parse_libraries): Remove cleanup.  Change return
9499         type.
9500         (solib_target_current_sos): Update.
9501
9502 2019-01-17  Tom Tromey  <tromey@bapiya>
9503
9504         * valprint.c: Replace "the the" with "the".
9505         * symtab.c: Replace "the the" with "the".
9506         * solib.c: Replace "the the" with "the".
9507         * solib-dsbt.c: Replace "the the" with "the".
9508         * linespec.c: Replace "the the" with "the".
9509         * dwarf2loc.h: Replace "the the" with "the".
9510         * amd64-windows-tdep.c: Replace "the the" with "the".
9511         * aarch64-tdep.c: Replace "the the" with "the".
9512
9513 2019-01-16  Keith Seitz  <keiths@redhat.com>
9514
9515         PR gdb/23773
9516         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9517         <builder>: Rename to ..
9518         <m_builder>: ... this and make private.
9519         (dwarf2_cu::get_builder): New method.  Change all users of
9520         `builder' to use this method.
9521         (dwarf2_start_symtab): Move to ...
9522         (dwarf2_cu::start_symtab): ... here.  Update all callers
9523         (setup_type_unit_groups): Move to ...
9524         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9525         callers.
9526         (dwarf2_cu::reset_builder): New method.
9527         (process_full_compunit, process_full_type_unit): Use
9528         dwarf2_cu::reset_builder.
9529         (follow_die_offset): Record the ancestor CU if it is different
9530         from the followed DIE's CU.
9531         (follow_die_sig_1): Likewise.
9532
9533 2019-01-15  Tom Tromey  <tom@tromey.com>
9534
9535         * remote.c (class remote_state) <buf>: Now a char_vector.
9536         <buf_size>: Remove.
9537         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9538         parameter.
9539         (remote_target::getpkt_or_notif_sane_1)
9540         (remote_target::getpkt_sane)
9541         (remote_target::getpkt_or_notif_sane): Likewise.
9542         (class remote_target) <putpkt>: New overload.
9543         (remote_target::read_frame): Change type of "buf_p".  Remove
9544         sizeof_p parameter.
9545         (packet_ok): New overload.
9546         (packet_check_result): New overload.
9547         Update all uses.
9548
9549 2019-01-14  Tom Tromey  <tom@tromey.com>
9550
9551         * remote-notif.c (handle_notification, remote_notif_ack)
9552         (remote_notif_parse): Make "buf" const.
9553         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9554         const.
9555         (remote_notif_parse, remote_notif_ack, handle_notification):
9556         Likewise.
9557         * remote.c (remote_notif_stop_parse): Make "buf" const.
9558         (remote_target::remote_parse_stop_reply): Make "buf" const.
9559         (remote_notif_stop_ack): Make "buf" const.
9560
9561 2019-01-14  Tom Tromey  <tom@tromey.com>
9562
9563         * remote.c (remote_console_output): Make parameter const.
9564
9565 2019-01-14  Tom Tromey  <tom@tromey.com>
9566
9567         * target-debug.h (target_debug_print_signals): Constify.
9568         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9569         * procfs.c (procfs_target::pass_signals): Update.
9570         * linux-nat.c (linux_nat_target::pass_signals): Update.
9571         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9572         * target-delegates.c: Rebuild.
9573         * remote.c (remote_target::program_signals): Update.
9574         (remote_target::pass_signals): Update.
9575         * target.c (target_pass_signals): Constify argument.
9576         (target_program_signals): Likewise.
9577         * target.h (struct target_ops) <pass_signals, program_signals>:
9578         Constify argument.
9579         (target_pass_signals, target_program_signals): Constify argument.
9580
9581 2019-01-14  Tom Tromey  <tom@tromey.com>
9582
9583         PR tui/28819:
9584         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9585
9586 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9587
9588         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9589         field.
9590         * rs6000-tdep.c: Include reggroups.h.
9591         (IS_V_ALIAS_PSEUDOREG): Define.
9592         (rs6000_register_name): Return names for the "vX" aliases.
9593         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9594         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9595         aliases.  Call default_register_reggroup_p for all other
9596         pseudo-registers.
9597         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9598         New functions.
9599         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9600         Handle "vX" aliases.
9601         (v_alias_pseudo_register_collect): New function.
9602         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9603         (rs6000_gdbarch_init): Initialize "vX" aliases as
9604         pseudo-registers.  Restore registration of
9605         rs6000_pseudo_register_reggroup_p with
9606         set_tdesc_pseudo_register_reggroup_p.
9607
9608 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9609
9610         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9611         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9612         set_gdbarch_num_pseudo_regs.
9613
9614 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9615
9616         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9617         Remove arg prefixname, add do_set and do_show.
9618         Add member functions set_list and show_list.
9619         * cli/cli-style.c (class cli_style_option): Update accordingly.
9620         (style_set_list): Move to file scope.
9621         (style_show_list): Likewise.
9622         (set_style): Call help_list.
9623         (show_style): Call cmd_show_list.
9624         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9625         Update to use the new macro.
9626
9627 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9628
9629         * ada-lang.c (_initialize_ada_language): Expand the help text
9630         for the "catch exception" command.
9631
9632 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9633
9634         * symtab.c (matching_obj_sections): Initialize obj,
9635         declare it closer to its usage.
9636
9637 2019-01-10  Tom Tromey  <tom@tromey.com>
9638
9639         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9640         (basic_inf_threads_range): Remove.
9641         (inf_threads_range, inf_non_exited_threads_range)
9642         (safe_inf_threads_range): Use next_adapter.
9643
9644 2019-01-10  Keith Seitz  <keiths@redhat.com>
9645
9646         PR gdb/23712
9647         PR symtab/23010
9648         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9649         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9650
9651 2019-01-10  Keith Seitz  <keiths@redhat.com>
9652
9653         PR gdb/23712
9654         PR symtab/23010
9655         * dictionary.c (pending_to_vector): Remove.
9656         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9657         Remove _1 suffix, replacing functions of the same name.  Update
9658         all callers.
9659         (dict_create_hashed, dict_create_hashed_expandable)
9660         (dict_create_linear, dict_create_linear_expandable, dict_free)
9661         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9662         Make functions static.
9663
9664 2019-01-10  Keith Seitz  <keiths@redhat.com>
9665
9666         PR gdb/23712
9667         PR symtab/23010
9668         * dictionary.h (struct dictionary): Replace declaration with
9669         multidictionary.
9670         (dict_create_hashed, dict_create_hashed_expandable)
9671         (dict_create_linear, dict_create_linear_expandable)
9672         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9673         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9674         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9675         taking multidictionary argument.
9676         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9677         * block.h (struct block) <dict>: Change to multidictionary
9678         and rename `multidict'.
9679         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9680         symmisc.c: Update all dictionary references to multidictionary.
9681
9682 2019-01-10  Keith Seitz  <keiths@redhat.com>
9683
9684         PR gdb/23712
9685         PR symtab/23010
9686         * dictionary.c: Include unordered_map.
9687         (pending_to_vector): New function.
9688         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9689         Rewrite the non-"_1" functions to take vector instead
9690         of linked list.
9691         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9692         "new" _1 versions of the same name.
9693         (multidictionary): Define.
9694         (std::hash<enum language): New definition.
9695         (collate_pending_symbols_by_language, mdict_create_hashed)
9696         (mdict_create_hashed_expandable, mdict_create_linear)
9697         (mdict_create_linear_expandable, mdict_free)
9698         (find_language_dictionary, create_new_language_dictionary)
9699         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9700         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9701         (mdict_size, mdict_empty): New functions.
9702         * dictionary.h (mdict_iterator): Define.
9703
9704 2019-01-10  Pedro Alves  <palves@redhat.com>
9705
9706         * breakpoint.c (read_uploaded_action)
9707         (create_tracepoint_from_upload): Adjust to use
9708         gdb::unique_xmalloc_ptr.
9709         * ctf.c (ctf_write_uploaded_tp):
9710         (SET_ARRAY_FIELD): Use emplace_back.
9711         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9712         * tracefile-tfile.c (tfile_write_uploaded_tp):
9713         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9714         gdb::unique_xmalloc_ptr.
9715         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9716         at_string, cond_string, cmd_strings>: Replace char pointers
9717         with gdb::unique_xmalloc_ptr.
9718
9719 2019-01-10  Pedro Alves  <palves@redhat.com>
9720
9721         * solib-target.c (library_list_start_library): Don't xstrdup name.
9722
9723 2019-01-10  Pedro Alves  <palves@redhat.com>
9724
9725         * mdebugread.c (parse_partial_symbols): Use
9726         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9727
9728 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9729
9730         * linux-fork.c (scoped_switch_fork_info)
9731         <~scoped_switch_fork_info>: Fix incorrect variable name.
9732
9733 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * linux-fork.c (scoped_switch_fork_info)
9736         <scoped_switch_fork_info>: Make explicit.
9737         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9738
9739 2019-01-10  Tom Tromey  <tom@tromey.com>
9740
9741         * objfiles.h (objfile::reset_psymtabs): Update.
9742         * objfiles.c (objfile::objfile): Update.
9743         * psymtab.h (psymtab_storage::obstack): Update.
9744         (psymtab_storage::m_obstack): Use gdb::optional.
9745         (class psymtab_storage): Update comment.  Remove objfile
9746         parameter.
9747         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9748
9749 2019-01-10  Tom Tromey  <tom@tromey.com>
9750
9751         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9752         <free_psymtabs>: Now private.
9753         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9754         (allocate_psymtab): Use new method.
9755
9756 2019-01-10  Tom Tromey  <tom@tromey.com>
9757
9758         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9759         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9760         * mdebugread.c (parse_partial_symbols): Use
9761         allocate_dependencies.
9762         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9763         allocate_dependencies.
9764         (process_psymtab_comp_unit_reader)
9765         (build_type_psymtab_dependencies): Likewise.
9766         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9767
9768 2019-01-10  Tom Tromey  <tom@tromey.com>
9769
9770         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9771         PSYMBOL_SET_LANGUAGE.
9772         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9773
9774 2019-01-10  Tom Tromey  <tom@tromey.com>
9775
9776         * psymtab.h (psymtab_storage::obstack): New method.
9777         <m_obstack>: Rename from obstack; now private.
9778         * psymtab.c (psymtab_storage): Update.
9779         * dwarf2read.c (create_addrmap_from_index)
9780         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9781         Update.
9782
9783 2019-01-10  Tom Tromey  <tom@tromey.com>
9784
9785         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9786         * objfiles.h (objfile::reset_psymtabs): New method.
9787
9788 2019-01-10  Tom Tromey  <tom@tromey.com>
9789
9790         * symmisc.c (print_symbol_bcache_statistics): Update.
9791         (print_objfile_statistics): Update.
9792         * symfile.c (reread_symbols): Update.
9793         * psymtab.h (class psymtab_storage): New.
9794         * psymtab.c (psymtab_storage): New constructor.
9795         (~psymtab_storage): New destructor.
9796         (require_partial_symbols): Update.
9797         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9798         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9799         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9800         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9801         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9802         (start_psymtab_common, end_psymtab_common)
9803         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9804         (allocate_psymtab): Update.
9805         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9806         Update.
9807         (dump_psymtab_addrmap, maintenance_print_psymbols)
9808         (maintenance_check_psymtabs): Update.
9809         (class objfile_psymtabs): Move to objfiles.h.
9810         * psympriv.h (discard_psymtab): Now inline.
9811         (psymtab_discarder::psymtab_discarder): Update.
9812         (psymtab_discarder::~psymtab_discarder): Update.
9813         (ALL_OBJFILE_PSYMTABS): Rewrite.
9814         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9815         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9816         Remove fields.
9817         <partial_symtabs>: New field.
9818         (class objfile_psymtabs): Move from psymtab.h.  Update.
9819         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9820         psymbol_cache.
9821         (objfile::~objfile): Don't destroy psymbol_cache.
9822         * mdebugread.c (parse_partial_symbols): Update.
9823         * dwarf2read.c (create_addrmap_from_index)
9824         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9825         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9826         (add_partial_subprogram, dwarf2_ranges_read): Update.
9827         * dwarf-index-write.c (write_address_map)
9828         (write_one_signatured_type, recursively_write_psymbols)
9829         (class debug_names, class debug_names, write_psymtabs_to_index):
9830         Update.
9831
9832 2019-01-10  Tom Tromey  <tom@tromey.com>
9833
9834         * symtab.h (SYMBOL_SET_NAMES): Update.
9835         (symbol_set_names): Update.
9836         (MSYMBOL_SET_NAMES): Update.
9837         * symtab.c (symbol_set_names): Change argument to be an
9838         objfile_per_bfd_storage.
9839         * psymtab.c (add_psymbol_to_bcache): Update.
9840         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9841
9842 2019-01-10  Tom Tromey  <tom@tromey.com>
9843
9844         * symtab.c (create_demangled_names_hash): Change argument to be an
9845         objfile_per_bfd_storage.
9846         (symbol_set_names): Update.
9847
9848 2019-01-10  Tom Tromey  <tom@tromey.com>
9849
9850         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9851         init_psymbol_list.
9852         * psymtab.c (init_psymbol_list): Do nothing if already called.
9853         * psympriv.h (init_psymbol_list): Add comment.
9854         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9855         init_psymbol_list.
9856         * dbxread.c (dbx_symfile_read): Unconditionally call
9857         init_psymbol_list.
9858
9859 2019-01-10  Tom Tromey  <tom@tromey.com>
9860
9861         * xcoffread.c (scan_xcoff_symtab): Update.
9862         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9863         "where".
9864         * mdebugread.c (parse_partial_symbols)
9865         (handle_psymbol_enumerators): Update.
9866         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9867         * dbxread.c (read_dbx_symtab): Update.
9868         * psympriv.h (psymbol_placement): New enum.
9869         (add_psymbol_to_list): Update.
9870
9871 2019-01-10  Tom Tromey  <tom@tromey.com>
9872
9873         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9874         static_psymbols parameters.
9875         (scan_xcoff_symtab): Update.
9876         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9877         static_psymbols parameters.
9878         * psympriv.h (start_psymtab_common): Update.
9879         * mdebugread.c (parse_partial_symbols): Update.
9880         * dwarf2read.c (create_partial_symtab): Update.
9881         * dbxread.c (read_dbx_symtab): Update.
9882         (start_psymtab): Remove global_psymbols and static_psymbols
9883         parameters.
9884
9885 2019-01-10  Tom Tromey  <tom@tromey.com>
9886
9887         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9888         * psymtab.c (allocate_psymtab): Add comment.
9889         * psympriv.h (allocate_psymtab): Add comment.
9890         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9891         initializations.
9892         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9893
9894 2019-01-10  Tom Tromey  <tom@tromey.com>
9895
9896         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9897         Don't declare.
9898         * mipsread.c: Include mdebugread.h.
9899         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9900         Declare.
9901         * elfread.c: Include mdebugread.h.
9902
9903 2019-01-09  Tom Tromey  <tom@tromey.com>
9904
9905         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9906         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9907         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9908         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9909         (psym_lookup_symbol, psym_find_last_source_symtab)
9910         (psym_forget_cached_source_info, psym_print_stats)
9911         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9912         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9913         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9914         (psym_find_compunit_symtab_by_address)
9915         (maintenance_print_psymbols, maintenance_info_psymtabs)
9916         (maintenance_check_psymtabs): Use ranged for.
9917         * psymtab.h (class objfile_psymtabs): New.
9918         (require_partial_symbols): Return objfile_psymtabs.
9919         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9920
9921 2019-01-09  Tom Tromey  <tom@tromey.com>
9922
9923         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9924         (find_pc_mapped_section, list_overlays_command)
9925         (map_overlay_command, unmap_overlay_command)
9926         (simple_overlay_update): Use all_objfiles.
9927         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9928         * printcmd.c (info_symbol_command): Use all_objfiles.
9929         * objfiles.h (ALL_OBJSECTIONS): Remove.
9930         * maint.c (maintenance_translate_address): Use all_objfiles.
9931         * gcore.c (gcore_create_callback): Use all_objfiles.
9932         (objfile_find_memory_regions): Likewise.
9933
9934 2019-01-09  Tom Tromey  <tom@tromey.com>
9935
9936         * symtab.c (find_line_symtab, info_sources_command)
9937         (make_source_files_completion_list): Use objfile_compunits.
9938         * source.c (select_source_symtab): Use objfile_compunits.
9939         * objfiles.h (struct objfile): Update comment.
9940         (ALL_OBJFILES): Remove.
9941         (ALL_FILETABS): Remove.
9942         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9943         objfile_compunits.
9944
9945 2019-01-09  Tom Tromey  <tom@tromey.com>
9946
9947         * symmisc.c (print_objfile_statistics, dump_objfile)
9948         (maintenance_print_symbols): Use compunit_filetabs.
9949         * source.c (forget_cached_source_info_for_objfile): Use
9950         compunit_filetabs.
9951         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9952         (ALL_FILETABS): Use compunit_filetabs.
9953         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9954         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9955
9956 2019-01-09  Tom Tromey  <tom@tromey.com>
9957
9958         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9959         (compunit_filetabs): New.
9960         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9961         compunit_filetabs.
9962         (info_sources_command, make_source_files_completion_list): Remove
9963         declaration.
9964         * symmisc.c (print_objfile_statistics, dump_objfile)
9965         (maintenance_print_symbols): Remove declaration.
9966         (maintenance_info_symtabs): Use compunit_filetabs.
9967         (maintenance_info_line_tables): Likewise.
9968         * source.c (select_source_symtab): Change local variable name.
9969         (forget_cached_source_info_for_objfile): Remove declaration.
9970         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9971         * objfiles.c (objfile_relocate1): Remove declaration.
9972         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9973         declaration.
9974         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9975         * coffread.c (coff_symtab_read): Remove declaration.
9976         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9977         compunit_filetabs.
9978
9979 2019-01-09  Tom Tromey  <tom@tromey.com>
9980
9981         * symtab.c (lookup_objfile_from_block)
9982         (find_pc_sect_compunit_symtab, search_symbols)
9983         (default_collect_symbol_completion_matches_break_on): Use
9984         objfile_compunits.
9985         * objfiles.h (ALL_COMPUNITS): Remove.
9986         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9987         * cp-support.c (add_symbol_overload_list_qualified): Use
9988         objfile_compunits.
9989         * ada-lang.c (ada_collect_symbol_completion_matches)
9990         (ada_add_global_exceptions): Use objfile_compunits.
9991
9992 2019-01-09  Tom Tromey  <tom@tromey.com>
9993
9994         * source.c (select_source_symtab)
9995         (forget_cached_source_info_for_objfile): Remove declaration.
9996         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9997         declaration.
9998         * maint.c (count_symtabs_and_blocks): Remove declaration.
9999         * cp-support.c (add_symbol_overload_list_qualified): Remove
10000         declaration.
10001         * coffread.c (coff_symtab_read): Remove declaration.
10002         * symtab.c (lookup_symbol_in_objfile_symtabs)
10003         (basic_lookup_transparent_type_1): Use objfile_compunits.
10004         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10005         (info_sources_command, search_symbols)
10006         (default_collect_symbol_completion_matches_break_on)
10007         (make_source_files_completion_list): Remove declaration.
10008         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10009         (ada_collect_symbol_completion_matches)
10010         (ada_add_global_exceptions): Remove declaration.
10011         * linespec.c (iterate_over_all_matching_symtabs): Use
10012         objfile_compunits.
10013         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10014         (class objfile_compunits): New.
10015         (ALL_COMPUNITS): Use objfile_compunits.
10016         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10017         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10018         objfile_compunits.
10019         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10020
10021 2019-01-09  Tom Tromey  <tom@tromey.com>
10022
10023         * symtab.c (search_symbols)
10024         (default_collect_symbol_completion_matches_break_on): Use
10025         objfile_msymbols.
10026         * ada-lang.c (ada_lookup_simple_minsym)
10027         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10028         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10029         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10030         objfile_msymbols.
10031         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10032         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10033         * objc-lang.c (find_methods): Use objfile_msymbols.
10034         (info_selectors_command, info_classes_command): Likewise.
10035         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10036         * objfiles.h (class objfile_msymbols): New.
10037         (ALL_OBJFILE_MSYMBOLS): Remove.
10038         (ALL_MSYMBOLS): Remove.
10039
10040 2019-01-09  Tom Tromey  <tom@tromey.com>
10041
10042         * common/next-iterator.h (next_adapter): Add Iterator template
10043         parameter.
10044         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10045         (class all_objfiles_safe): New.
10046         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10047         * objfiles.c (put_objfile_before): Update comment.
10048         (add_separate_debug_objfile): Likewise.
10049         (free_all_objfiles): Use all_objfiles_safe.
10050         (objfile_purge_solibs): Likewise.
10051
10052 2019-01-09  Tom Tromey  <tom@tromey.com>
10053
10054         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10055         (expand_symtab_containing_pc, lookup_static_symbol)
10056         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10057         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10058         all_objfiles.
10059         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10060         * breakpoint.c (create_overlay_event_breakpoint)
10061         (create_longjmp_master_breakpoint)
10062         (create_std_terminate_master_breakpoint)
10063         (create_exception_master_breakpoint): Use all_objfiles.
10064         * linux-thread-db.c (try_thread_db_load_from_pdir)
10065         (has_libpthread): Use all_objfiles.
10066         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10067         * linespec.c (iterate_over_all_matching_symtabs)
10068         (search_minsyms_for_name): Use all_objfiles.
10069         * maint.c (maintenance_info_sections): Use all_objfiles.
10070         * main.c (captured_main_1): Use all_objfiles.
10071         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10072         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10073         * guile/scm-pretty-print.c
10074         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10075         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10076         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10077         (maintenance_print_msymbols): Use all_objfiles.
10078         * source.c (select_source_symtab): Use all_objfiles.
10079         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10080         * symfile.c (remove_symbol_file_command)
10081         (expand_symtabs_matching, map_symbol_filenames): Use
10082         all_objfiles.
10083         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10084         all_objfiles.
10085         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10086         * objc-lang.c (find_methods): Use all_objfiles.
10087         * objfiles.c (have_partial_symbols, have_full_symbols)
10088         (have_minimal_symbols, qsort_cmp)
10089         (default_iterate_over_objfiles_in_search_order): Use
10090         all_objfiles.
10091         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10092         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10093         (maintenance_check_psymtabs): Use all_objfiles.
10094         (ALL_PSYMTABS): Remove.
10095         * compile/compile-object-run.c (do_module_cleanup): Use
10096         all_objfiles.
10097         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10098         * cp-support.c (add_symbol_overload_list_qualified): Use
10099         all_objfiles.
10100         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10101         Use all_objfiles.
10102         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10103         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10104         all_objfiles.
10105         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10106         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10107         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10108         Uses all_objfiles.
10109         * solib.c (solib_read_symbols): Use all_objfiles
10110
10111 2019-01-09  Tom Tromey  <tom@tromey.com>
10112
10113         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10114         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10115         all_objfiles.
10116         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10117         * symmisc.c (print_symbol_bcache_statistics)
10118         (print_objfile_statistics, maintenance_print_objfiles)
10119         (maintenance_info_symtabs, maintenance_check_symtabs)
10120         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10121         all_objfiles.
10122         * source.c (forget_cached_source_info): Use all_objfiles.
10123         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10124         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10125         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10126         * objfiles.c (update_section_map): Use all_objfiles.
10127         (shared_objfile_contains_address_p): Likewise.
10128         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10129         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10130
10131 2019-01-09  Tom Tromey  <tom@tromey.com>
10132
10133         * common/next-iterator.h: New file.
10134         * objfiles.h (class all_objfiles): New.
10135         (struct objfile_iterator): New.
10136
10137 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10138
10139         * NEWS: Move the description of the changed "frame", "select-frame",
10140          and "info frame" commands to the Changed commands section.
10141
10142 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10143
10144         * gdbtypes.c (check_stub_method_group): Remove handling of old
10145         mangling schemes.
10146         * linespec.c (find_methods): Likewise.
10147         * stabsread.c (read_member_functions): Likewise.
10148         * valops.c (search_struct_method): Likewise.
10149         (value_struct_elt_for_reference): Likewise.
10150         * NEWS: Mention this change.
10151
10152 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10153
10154         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10155         print_source_lines.
10156         * source.c (print_source_lines_base): Update line number check.
10157         (print_source_lines): New function.
10158         (source_lines_range::source_lines_range): New function.
10159         * source.h (class source_lines_range): New class.
10160         (print_source_lines): New declaration.
10161
10162 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10163
10164         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10165
10166 2019-01-08  Tom Tromey  <tom@tromey.com>
10167             Simon Marchi  <simon.marchi@ericsson.com>
10168
10169         PR gdb/24060
10170         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10171         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10172         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10173         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10174         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10175         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10176
10177 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10178
10179         * source.c (select_source_symtab): Move header comment to
10180         declaration in source.h.
10181         (forget_cached_source_info_for_objfile): Likewise.
10182         (forget_cached_source_info): Likewise.
10183         (identify_source_line): Likewise.
10184         * source.h (identify_source_line): Move declaration from symtab.h
10185         and add comment from source.c
10186         (print_source_lines): Likewise.
10187         (forget_cached_source_info_for_objfile): Likewise.
10188         (forget_cached_source_info): Likewise.
10189         (select_source_symtab): Likewise.
10190         (enum print_source_lines_flag): Move definition from symtab.h.
10191         * symtab.h (identify_source_line): Move declaration to source.h.
10192         (print_source_lines): Likewise.
10193         (forget_cached_source_info_for_objfile): Likewise.
10194         (forget_cached_source_info): Likewise.
10195         (select_source_symtab): Likewise.
10196         (enum print_source_lines_flag): Move definition to source.h.
10197         * tui/tui-hooks.c: Add 'source.h' include.
10198
10199 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10200
10201         * source.c (print_source_lines_base): Handle requests to print
10202         reverse line number sequences, and guard against empty lines
10203         string.
10204
10205 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10206
10207         * source.c (print_source_lines_base): Fix skip of '\r' if next
10208         character is '\n'.
10209
10210 2019-01-06  Tom Tromey  <tom@tromey.com>
10211
10212         * c-exp.y (struct c_parse_state) <macro_original_text,
10213         expansion_obstack>: New member.
10214         (macro_original_text, expansion_obstack): Remove globals.
10215         (scan_macro_expansion, scanning_macro_expansion)
10216         (finished_macro_expansion): Update.
10217         (scan_macro_cleanup): Remove.
10218         (yylex, c_parse): Update.
10219
10220 2019-01-06  Tom Tromey  <tom@tromey.com>
10221
10222         * c-exp.y (struct c_parse_state) <strings>: New member.
10223         (operator_stoken): Update.
10224
10225 2019-01-06  Tom Tromey  <tom@tromey.com>
10226
10227         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10228         (union type_stack_elt) <typelist_val>: Now a pointer to
10229         std::vector.
10230         (type_stack_cleanup): Don't declare.
10231         (push_typelist): Update.
10232         * parse.c (pop_typelist): Return a std::vector.
10233         (push_typelist): Take a std::vector.
10234         (follow_types): Update.  Do not free args.
10235         (type_stack_cleanup): Remove.
10236         * c-exp.y (struct c_parse_state): New.
10237         (cpstate): New global.
10238         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10239         (nonempty_typelist): Update.
10240         (func_mod): Create a new vector.
10241         (c_parse): Create a c_parse_state.
10242         (check_parameter_typelist): Do not delete params.
10243         (function_method): Update.  Do not delete type_list.
10244
10245 2019-01-06  Tom Tromey  <tom@tromey.com>
10246
10247         PR gdb/28155:
10248         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10249         check_typedef.
10250         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10251         (print_return_value): Likewise.
10252
10253 2019-01-05  Tom Tromey  <tom@tromey.com>
10254
10255         * contrib/cleanup_check.py: Remove.
10256         * contrib/gcc-with-excheck: Remove.
10257         * contrib/exsummary.py: Remove.
10258         * contrib/excheck.py: Remove.
10259
10260 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10261
10262         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10263         NULL. Initialize tpprev to NULL instead of assigning it
10264         to NULL on the next statement.
10265         * windows-nat.c (windows_delete_thread): Remove check for
10266         main_thread_id before printing thread exit notifications.
10267         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10268         Remove thread ID check against main_thread_id.
10269         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10270         windows_delete_thread.
10271         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10272
10273 2019-01-04  Tom Tromey  <tom@tromey.com>
10274
10275         * compile/compile.c (_initialize_compile): Use upper case for
10276         metasyntactic variables.
10277         * symmisc.c (_initialize_symmisc): Use upper case for
10278         metasyntactic variables.
10279         * psymtab.c (_initialize_psymtab): Use upper case for
10280         metasyntactic variables.
10281         * demangle.c (demangle_command): Use upper case for metasyntactic
10282         variables.
10283         (_initialize_demangler): Likewise.
10284         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10285         variables.
10286
10287 2019-01-03  Tom Tromey  <tom@tromey.com>
10288
10289         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10290
10291 2019-01-03  Tom Tromey  <tom@tromey.com>
10292
10293         * python/py-symtab.c (salpy_str): Update.
10294         (struct salpy_sal_object) <symtab>: Now a PyObject.
10295         (salpy_dealloc): Update.
10296         (del_objfile_sal): Use gdbpy_ref.
10297
10298 2019-01-03  Tom Tromey  <tom@tromey.com>
10299
10300         * python/py-type.c (convert_field): Use new_reference.  Return
10301         gdbpy_ref.
10302         (make_fielditem): Return gdbpy_ref.
10303         (typy_fields): Update.
10304         (typy_getitem): Update.
10305         (field_name): Return gdbpy_ref.  Use new_reference.
10306         (typy_iterator_iternext): Update.
10307
10308 2019-01-03  Tom Tromey  <tom@tromey.com>
10309
10310         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10311
10312 2019-01-03  Tom Tromey  <tom@tromey.com>
10313
10314         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10315         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10316         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10317         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10318         (pspy_set_type_printers): Likewise.
10319         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10320         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10321         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10322         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10323         (objfpy_set_type_printers): Likewise.
10324
10325 2019-01-03  Tom Tromey  <tom@tromey.com>
10326
10327         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10328         (gdbpy_print_stack): Use gdbpy_err_fetch.
10329         * python/python-internal.h (class gdbpy_err_fetch): New class.
10330         (class gdbpy_enter) <m_error_type, m_error_value,
10331         m_error_traceback>: Remove.
10332         <m_error>: New member.
10333         (gdbpy_exception_to_string): Don't declare.
10334         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10335         * python/py-value.c (convert_value_from_python): Use
10336         gdbpy_err_fetch.
10337         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10338         gdbpy_exception_to_string.
10339         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10340         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10341         gdbpy_err_fetch.
10342
10343 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * linux-nat.c (delete_lwp_cleanup): Delete.
10346         (struct lwp_deleter): New struct.
10347         (lwp_info_up): New typedef.
10348         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10349         lwp_info_up.
10350
10351 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10352
10353         * linux-fork.c (class scoped_switch_fork_info): New class.
10354         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10355
10356 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10357
10358         * valops.c (find_overload_match): Remove use of null_cleanup, and
10359         calls to do_cleanups.
10360
10361 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10362
10363         * compile/compile-cplus-types.c
10364         (compile_cplus_instance::decl_name): Handle changes to
10365         cp_func_name.
10366         * cp-support.c (cp_func_name): Update header comment, update
10367         return type.
10368         * cp-support.h (cp_func_name): Update return type in declaration.
10369         * valops.c (find_overload_match): Move temp_func local to top
10370         level of function and change its type.  Use temp_func to hold and
10371         delete temporary string obtained from cp_func_name.
10372
10373 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10374
10375         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10376         gdb::char_vector, remove cleanup, and update uses of `msg`.
10377
10378 2019-01-03  Jim Wilson  <jimw@sifive.com>
10379
10380         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10381
10382 2019-01-02  Tom Tromey  <tom@tromey.com>
10383
10384         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10385         (tdesc_parse_xml): Remove cleanups.
10386         * target-descriptions.h (make_cleanup_free_target_description):
10387         Don't declare.
10388         (target_desc_deleter): New struct.
10389         (target_desc_up): New typedef.
10390         * target-descriptions.c (target_desc_deleter::operator()): Rename
10391         from free_target_description.
10392         (make_cleanup_free_target_description): Remove.
10393
10394 2019-01-02  Tom Tromey  <tom@tromey.com>
10395
10396         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10397         constructor, destructor.
10398         (linespec_parser): Remove typedef.
10399         (~linespec_parser): Rename from linespec_parser_delete.
10400         (linespec_lex_to_end, linespec_complete_label)
10401         (linespec_complete): Update.
10402         (decode_line_full): Remove cleanups.
10403         (decode_line_1): Update.
10404
10405 2019-01-02  Tom Tromey  <tom@tromey.com>
10406
10407         * python/python-internal.h (inferior_to_inferior_object): Change
10408         return type.
10409         * python/py-exitedevent.c (create_exited_event_object): Update.
10410         * python/py-inferior.c (inferior_to_inferior_object): Return
10411         gdbpy_ref.
10412         (python_new_inferior, python_inferior_deleted)
10413         (thread_to_thread_object, delete_thread_object)
10414         (build_inferior_list, gdbpy_selected_inferior): Update.
10415         * python/py-infthread.c (create_thread_object): Update.  Also fail
10416         if inferior_to_inferior_object fails.
10417
10418 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10419
10420         * inferior.h (class inferior) <displaced_step_state>: New field.
10421         * infrun.h (struct displaced_step_state): Move here from
10422         infrun.c.  Initialize fields, add constructor.
10423         <inf>: Remove field.
10424         <reset>: New method.
10425         * infrun.c (struct displaced_step_inferior_state): Move to
10426         infrun.h.
10427         (displaced_step_inferior_states): Remove.
10428         (get_displaced_stepping_state): Adust.
10429         (displaced_step_in_progress_any_inferior): Adjust.
10430         (displaced_step_in_progress_thread): Adjust.
10431         (displaced_step_in_progress): Adjust.
10432         (add_displaced_stepping_state): Remove.
10433         (get_displaced_step_closure_by_addr): Adjust.
10434         (remove_displaced_stepping_state): Remove.
10435         (infrun_inferior_exit): Call displaced_step_state.reset.
10436         (use_displaced_stepping): Don't check for NULL.
10437         (displaced_step_prepare_throw): Call
10438         get_displaced_stepping_state.
10439         (displaced_step_fixup): Don't check for NULL.
10440         (prepare_for_detach): Don't check for NULL.
10441
10442 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10443
10444         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10445          in case of call that did not complete.
10446
10447 2019-01-02  Andrey Utkin  <autkin@undo.io>
10448
10449         * symfile.c (find_separate_debug_file): Fix search of debug files for
10450         remote debuggee.
10451
10452 2019-01-02  Tom Tromey  <tom@tromey.com>
10453
10454         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10455         indentation.
10456         * python/py-frame.c (frapy_older): Remove cast.
10457         (frapy_newer): Likewise.
10458         * python/py-breakpoint.c (local_setattro): Remove cast.
10459         * python/py-arch.c (archpy_name): Remove local variable.
10460         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10461
10462 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10463
10464         * unittests/basic_string_view/element_access/char/empty.cc:
10465         Fix year range in copyright header.
10466
10467 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10468
10469         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10470         Delete.
10471         <operator==>: Update with for removed field.
10472         <hash>: Likewise.
10473         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10474         <isa_features>: ...this.
10475         <abi_features>: New field.
10476         (riscv_isa_flen): Update comment.
10477         (riscv_abi_xlen): New declaration.
10478         (riscv_abi_flen): New declaration.
10479         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10480         isa_features.
10481         (riscv_abi_xlen): New function.
10482         (riscv_isa_flen): Update to get answer from isa_features.
10483         (riscv_abi_flen): New function.
10484         (riscv_has_fp_abi): Update to get answer from abi_features.
10485         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10486         xlen and flen.
10487         (riscv_call_info) <xlen, flen>: Update comment.
10488         (riscv_call_arg_struct): Remove invalid assertions
10489         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10490         is removed.
10491         (riscv_gdbarch_init): Gather isa features and abi features
10492         separately, ensure both match on the gdbarch when reusing an old
10493         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10494         a target with 64-bit float hardware.
10495
10496 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10497
10498         * source.c (search_command_helper): Stop reverse search
10499         when line 1 has been searched.
10500
10501 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10502
10503         * record-full.c (record_full_base_target::close): Rewrite
10504         record_full_core_buf_list free logic.
10505
10506 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10507
10508         * break-catch-syscall.c (print_one_catch_syscall): xfree
10509         the last text.
10510
10511 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10512
10513         * top.c (print_gdb_version): Update Copyright year in version
10514         message.
10515
10516 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10517
10518         Update copyright year range in all GDB files.
10519
10520 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10521
10522         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10523
10524 For older changes see ChangeLog-2018.
10525 \f
10526 Local Variables:
10527 mode: change-log
10528 left-margin: 8
10529 fill-column: 74
10530 version-control: never
10531 coding: utf-8
10532 End:
10533