breakpoint: Make is_*point functions return bool
[external/binutils.git] / gdb / ChangeLog
1 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2
3         * breakpoint.c (is_hardware_watchpoint): Remove
4         forward-declaration.
5         (is_masked_watchpoint): Change return type to bool.
6         (is_tracepoint): Likewise.
7         (is_breakpoint): Likewise.
8         (is_hardware_watchpoint): Likewise.
9         (is_watchpoint): Likewise.
10         (is_no_memory_software_watchpoint): Likewise.
11         (is_catchpoint): Likewise.
12         (breakpoint_1): Make FILTER parameter's return type bool.
13         is_masked_watchpoint): Change return type to bool.
14         (save_breakpoints): Make FILTER parameter's return type bool.
15         * breakpoint.h (is_breakpoint): Change return type to bool.
16         (is_watchpoint): Likewise.
17         (is_catchpoint): Likewise.
18         (is_tracepoint): Likewise.
19
20 2019-07-10  Tom Tromey  <tom@tromey.com>
21
22         * defs.h: Don't include gdbarch.h.
23         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
24         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
25         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
26         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
27         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
28         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
29         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
30         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
31         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
32         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
33         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
34         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
35         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
36         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
37         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
38         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
39         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
40         record-btrace.c, record.h, regcache-dump.c, regcache.h,
41         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
42         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
43         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
44         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
45         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
46         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
47         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
48         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
49         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
50
51 2019-07-10  Tom Tromey  <tromey@adacore.com>
52
53         * ada-lang.h (is_ada_exception_catchpoint): Declare.
54         * breakpoint.c (init_ada_exception_breakpoint): Register as
55         bp_catchpoint.
56         (print_one_breakpoint_location, print_one_breakpoint): Use
57         is_ada_exception_catchpoint.
58         * ada-lang.c (class ada_catchpoint_location): Pass
59         bp_loc_software_breakpoint to bp_location constructor.
60         (is_ada_exception_catchpoint): New function.
61
62 2019-07-10  Tom Tromey  <tromey@adacore.com>
63
64         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
65         VEC.
66         (struct arm_exidx_entry): New method operator<.
67         (struct arm_exidx_data) <section_maps>: Change type.
68         (arm_exidx_data_free): Remove.
69         (arm_exidx_data_key): Change type.  Move lower.
70         (arm_exidx_new_objfile): Update.
71         (arm_compare_exidx_entries): Remove.
72         (arm_find_exidx_entry, _initialize_arm_tdep)
73
74 2019-07-10  Tom Tromey  <tromey@adacore.com>
75
76         * solib-spu.c (ocl_program_data_key): Change type.
77         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
78         Update.
79
80 2019-07-10  Tom Tromey  <tromey@adacore.com>
81
82         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
83         (struct solib_aix_inferior_data) <library_list>: Change type.
84         (solib_aix_inferior_data_handle): Change type.
85         (get_solib_aix_inferior_data): Update.
86         (solib_aix_free_library_list): Remove.
87         (library_list_start_library): Update.
88         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
89         return type.
90         (solib_aix_get_library_list)
91         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
92         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
93
94 2019-07-10  Tom Tromey  <tromey@adacore.com>
95
96         * solib-dsbt.c (struct dsbt_info): Add initializers.
97         (solib_dsbt_pspace_data): Change type.
98         (dsbt_pspace_data_cleanup): Remove.
99         (get_dsbt_info, _initialize_dsbt_solib): Update.
100
101 2019-07-10  Tom Tromey  <tromey@adacore.com>
102
103         * spu-tdep.c (spu_overlay_data): Change type.
104         (spu_get_overlay_table, spu_overlay_new_objfile)
105         (_initialize_spu_tdep): Update.
106
107 2019-07-10  Tom Tromey  <tromey@adacore.com>
108
109         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
110         destructor.
111         (dbx_objfile_data_key): Change type and declare later.
112         (DBX_SYMFILE_INFO): Rewrite.
113         * dbxread.c (dbx_objfile_data_key): Change type.
114         (dbx_symfile_init): Update.
115         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
116         (coffstab_build_psymtabs, elfstab_build_psymtabs)
117         (stabsect_build_psymtabs, _initialize_dbxread): Update.
118
119 2019-07-10  Tom Tromey  <tromey@adacore.com>
120
121         * jit.c (jit_program_space_key): Change type.  Move lower.
122         (get_jit_program_space_data): Update.
123         (jit_program_space_data_cleanup): Remove.
124         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
125         Update.
126         (struct jit_program_space_data): Add initializers.
127
128 2019-07-10  Tom Tromey  <tromey@adacore.com>
129
130         * solib-darwin.c (struct darwin_info): Add initializers.
131         (solib_darwin_pspace_data): Change type.
132         (darwin_pspace_data_cleanup): Remove.
133         (get_darwin_info, _initialize_darwin_solib): Update.
134
135 2019-07-10  Tom Tromey  <tromey@adacore.com>
136
137         * remote-sim.c (struct sim_inferior_data): Add initializers,
138         constructor, and destructor.
139         (sim_inferior_data_key): Change type.  Move lower.
140         (check_for_duplicate_sim_descriptor): Update.
141         (get_sim_inferior_data): Use new.  Update.
142         (~sim_inferior_data_cleanup): Rename from
143         sim_inferior_data_cleanup.  Simplify.
144         (gdbsim_close_inferior, simulator_command)
145         (sim_command_completer, _initialize_remote_sim): Update.
146         (next_pid, INITIAL_PID): Move earlier.
147
148 2019-07-10  Tom Tromey  <tromey@adacore.com>
149
150         * python/python-internal.h (create_thread_object): Return
151         gdbpy_ref.
152         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
153         * python/py-inferior.c (struct threadlist_entry): Add
154         constructor.
155         <thread_obj>: Now a gdbpy_ref.
156         (thread_to_thread_object): Update.
157         (add_thread_object): Use new.
158         (delete_thread_object): Use delete.
159         (infpy_threads): Update.
160         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
161         GIL.
162
163 2019-07-10  Tom Tromey  <tromey@adacore.com>
164
165         * valops.c (value_cast): Specialize error message for Ada.
166
167 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
168
169         * breakpoint.c (breakpoint_1): Update doc and parameter names.
170
171 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
172
173         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
174         bpstat_should_step): Return bool, adjust comments.
175         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
176         bpstat_should_step): Likewise.
177
178 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
179
180         * features/Makefile: Use feature target descriptions for Arm.
181         * features/arm/arm-core.c: Generate new file.
182         * features/arm/arm-fpa.c: Likewise.
183         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
184         * features/arm/arm-m-profile.c: Likewise.
185         * features/arm/arm-vfpv2.c: Likewise.
186         * features/arm/arm-vfpv3.c: Likewise.
187         * features/arm/xscale-iwmmxt.c: Likewise.
188         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
189
190 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
191
192         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
193         ptrace earlier.
194
195 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
196
197         * features/aarch64-pauth.c: Regenerate.
198
199 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
200
201         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
202         bool.
203         (bpstat_what): Use false instead of 0.
204
205 2019-07-09  Pedro Alves  <palves@redhat.com>
206
207         * break-catch-throw.c (is_exception_catchpoint): New.
208         * breakpoint.c (print_one_breakpoint_location): New parameter
209         'raw_loc'.  Handle it.  Use
210         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
211         looking at the breakpoint's type.
212         (print_one_breakpoint): If handling "maint info breakpoints", also
213         print locations of exception catchpoints.
214         * breakpoint.h (is_exception_catchpoint): Declare.
215
216 2019-07-09  Pedro Alves  <palves@redhat.com>
217
218         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
219         "addr" field.
220         (allocate_location_exception_catchpoint): New.
221         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
222         (initialize_throw_catchpoint_ops): Install
223         allocate_location_exception_catchpoint as allocate_location
224         method.
225         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
226         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
227         bp_loc_other.
228         (breakpoint_address_is_meaningful): Delete.
229         (bl_address_is_meaningful): New.
230         (breakpoint_locations_match): Adjust comment.
231         (bp_location_from_bp_type): New, factored out of...
232         (bp_location::bp_location(breakpoint *)): ... this.
233         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
234         factored out of...
235         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
236         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
237         breakpoint_address_is_meaningful.
238         (bp_locations_compare): Adjust comment.
239         (update_global_location_list): Use bl_address_is_meaningful
240         instead of breakpoint_address_is_meaningful.
241         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
242         explicit.
243         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
244         * python/py-breakpoint.c (bppy_get_location): No longer check
245         whether location is null.
246
247 2019-07-09  Pedro Alves  <palves@redhat.com>
248
249         PR c++/15468
250         * breakpoint.c (print_one_breakpoint_location): Remove
251         single-location assert.
252
253 2019-07-09  Tom Tromey  <tom@tromey.com>
254
255         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
256         * configure: Rebuild.
257         * configure.ac: Change common to gdbsupport.
258         * gdbsupport: Rename from common.
259         * acinclude.m4: Change common to gdbsupport.
260         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
261         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
262         gdbsupport.
263         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
264         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
265         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
266         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
267         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
268         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
269         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
270         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
271         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
272         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
273         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
274         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
275         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
276         coff-pe-read.c, command.h, compile/compile-c-support.c,
277         compile/compile-c.h, compile/compile-cplus-symbols.c,
278         compile/compile-cplus-types.c, compile/compile-cplus.h,
279         compile/compile-loc2c.c, compile/compile.c, completer.c,
280         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
281         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
282         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
283         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
284         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
285         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
286         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
287         features/aarch64-core.c, features/aarch64-fpu.c,
288         features/aarch64-pauth.c, features/aarch64-sve.c,
289         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
290         features/i386/32bit-core.c, features/i386/32bit-linux.c,
291         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
292         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
293         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
294         features/i386/64bit-core.c, features/i386/64bit-linux.c,
295         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
296         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
297         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
298         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
299         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
300         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
301         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
302         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
303         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
304         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
305         go32-nat.c, guile/guile.c, guile/scm-ports.c,
306         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
307         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
308         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
309         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
310         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
311         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
312         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
313         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
314         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
315         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
316         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
317         minsyms.c, mips-linux-tdep.c, namespace.h,
318         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
319         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
320         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
321         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
322         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
323         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
324         nat/linux-waitpid.c, nat/mips-linux-watch.c,
325         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
326         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
327         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
328         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
329         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
330         procfs.c, producer.c, progspace.h, psymtab.h,
331         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
332         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
333         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
334         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
335         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
336         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
337         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
338         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
339         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
340         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
341         target-memory.c, target.c, target.h, target/waitstatus.c,
342         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
343         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
344         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
345         unittests/array-view-selftests.c,
346         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
347         unittests/common-utils-selftests.c,
348         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
349         unittests/format_pieces-selftests.c,
350         unittests/function-view-selftests.c,
351         unittests/lookup_name_info-selftests.c,
352         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
353         unittests/mkdir-recursive-selftests.c,
354         unittests/observable-selftests.c,
355         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
356         unittests/parse-connection-spec-selftests.c,
357         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
358         unittests/scoped_fd-selftests.c,
359         unittests/scoped_mmap-selftests.c,
360         unittests/scoped_restore-selftests.c,
361         unittests/string_view-selftests.c, unittests/style-selftests.c,
362         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
363         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
364         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
365         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
366         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
367         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
368
369 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
370
371         * linespec.c (decode_digits_list_mode): Set explicit_line to a
372         bool value.
373         (decode_digits_ordinary): Set explicit_line field in sal.
374         * symtab.c (skip_prologue_sal): Don't skip prologue for a
375         symtab_and_line that was set on an explicit line number in
376         assembler code.  Do always update the recorded symtab and line if
377         we do skip the prologue.
378
379 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
380
381         * breakpoint.c (set_breakpoint_location_function): Remove
382         explicit_loc parameter.
383         (momentary_breakpoint_from_master): Update call to
384         set_breakpoint_location_function.
385         (add_location_to_breakpoint): Likewise.
386
387 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
388
389         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
390         required features based on default bfd type when no specific bfd
391         is present.
392
393 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
394
395         * NEWS: Mention that GDB printf and eval commands can now print
396         C-style and Ada-style convenience var strings without
397         calling the inferior.
398         * printcmd.c (printf_c_string): Locally print GDB internal var
399         instead of transiting via the inferior.
400         (printf_wide_c_string): Likewise.
401
402 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
403
404         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
405
406 2019-07-04  Tom Tromey  <tom@tromey.com>
407
408         PR tui/24724:
409         * tui/tui-winsource.c (tui_clear_source_content): Update.
410         (tui_source_window_base::set_is_exec_point_at): Fix comment.
411         (tui_update_breakpoint_info): Update.
412         (tui_set_exec_info_content): Update.
413         * tui/tui-source.c (tui_set_source_content_nil): Update.
414         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
415         has_break.
416         * tui/tui-data.h (enum tui_bp_flag): New.
417         (tui_bp_flags): New enum flags type.
418         (struct tui_source_element) <break_mode>: Change type.  Rename
419         from has_break.
420         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
421         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
422         constants.
423         * tui/tui-winsource.h: Fix comment.
424
425 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
426
427         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
428         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
429         (store_fpregs_to_thread)
430         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
431         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
432         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
433         (IWMMXT_REGS_SIZE): Add define.
434         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
435         (fetch_vfp_regs, store_vfp_regs)
436         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
437         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
438
439 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
440
441         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
442         defines.
443         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
444         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
445         (ARM_INT_REGISTER_SIZE): ...to this.
446         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
447         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
448         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
449         (arm_linux_collect_gregset, supply_nwfpe_register)
450         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
451         defines.
452         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
453         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
454         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
455         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
456         (arm_return_in_memory, arm_store_return_value)
457         (arm_get_longjmp_target, arm_register_g_packet_guesses)
458         (arm_record_ld_st_multiple): Likewise.
459         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
460         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
461
462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
463
464         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
465         AARCH64_DISPLACED_MODIFIED_INSNS.
466         * aarch64-tdep.c (struct aarch64_displaced_step_data)
467         (aarch64_displaced_step_copy_insn): Likewise.
468         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
469         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
470         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
471         ARM_DISPLACED_MODIFIED_INSNS.
472         * arm-tdep.c (arm_gdbarch_init): Likewise.
473         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
474         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
475         (struct arm_displaced_step_closure): Use
476         ARM_DISPLACED_MODIFIED_INSNS.
477
478 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
479
480         * features/Makefile: Remove unused xml files.
481         * features/aarch64.xml: Remove.
482         * features/i386/amd64-avx-avx512-linux.xml: Remove.
483         * features/i386/amd64-avx-avx512.xml: Remove.
484         * features/i386/amd64-avx-linux.xml: Remove.
485         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
486         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
487         * features/i386/amd64-avx-mpx-linux.xml: Remove.
488         * features/i386/amd64-avx-mpx.xml: Remove.
489         * features/i386/amd64-avx.xml: Remove.
490         * features/i386/amd64-linux.xml: Remove.
491         * features/i386/amd64-mpx-linux.xml: Remove.
492         * features/i386/amd64-mpx.xml: Remove.
493         * features/i386/amd64.xml: Remove.
494         * features/i386/i386-avx-avx512-linux.xml: Remove.
495         * features/i386/i386-avx-avx512.xml: Remove.
496         * features/i386/i386-avx-linux.xml: Remove.
497         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
498         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
499         * features/i386/i386-avx-mpx-linux.xml: Remove.
500         * features/i386/i386-avx-mpx.xml: Remove.
501         * features/i386/i386-avx.xml: Remove.
502         * features/i386/i386-linux.xml: Remove.
503         * features/i386/i386-mmx-linux.xml: Remove.
504         * features/i386/i386-mmx.xml: Remove.
505         * features/i386/i386-mpx-linux.xml: Remove.
506         * features/i386/i386-mpx.xml: Remove.
507         * features/i386/i386.xml: Remove.
508         * features/i386/x32-avx-avx512-linux.xml: Remove.
509         * features/i386/x32-avx-linux.xml: Remove.
510         * features/i386/x32-linux.xml: Remove.
511
512 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
513
514         * regformats/aarch64.dat: Remove.
515         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
516         * regformats/i386/amd64-avx-linux.dat: Remove.
517         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
518         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
519         * regformats/i386/amd64-linux.dat: Remove.
520         * regformats/i386/amd64-mpx-linux.dat: Remove.
521         * regformats/i386/amd64.dat: Remove.
522         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
523         * regformats/i386/i386-avx-linux.dat: Remove.
524         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
525         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
526         * regformats/i386/i386-linux.dat: Remove.
527         * regformats/i386/i386-mmx-linux.dat: Remove.
528         * regformats/i386/i386-mpx-linux.dat: Remove.
529         * regformats/i386/i386.dat: Remove.
530         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
531         * regformats/i386/x32-avx-linux.dat: Remove.
532         * regformats/i386/x32-linux.dat: Remove.
533
534 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
535
536         * aarch64-tdep.c: Remove xml self tests.
537         * amd64-linux-tdep.c: Likewise.
538         * amd64-tdep.c: Likewise.
539         * i386-linux-tdep.c: Likewise.
540         * i386-tdep.c: Likewise.
541
542 2019-07-03  Pedro Alves  <palves@redhat.com>
543
544         PR cli/24732
545         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
546         (pipe_cmd_option_defs): New.
547         (make_pipe_cmd_options_def_group): New.
548         (pipe_command): Use gdb::option::process_options.
549         (pipe_command_completer): New function.
550         (_initialize_cli_cmds): Install completer for "pipe" command.
551
552 2019-07-03  Pedro Alves  <palves@redhat.com>
553
554         * cli/cli-option.c (union option_value) <string>: New field.
555         (struct option_def_and_value): Add ctor, move ctor, dtor and
556         use DISABLE_COPY_AND_ASSIGN.
557         (option_def_and_value::clear_value): New.
558         (parse_option, save_option_value_in_ctx, get_val_type_str)
559         (add_setshow_cmds_for_options): Handle var_string.
560         * cli-option.h (union option_def::var_address) <string>: New
561         field.
562         (struct string_option_def): New.
563         * maint-test-options.c (struct test_options_opts): Add default
564         ctor and use DISABLE_COPY_AND_ASSIGN.
565         <string_opt>: New field.
566         (test_options_opts::~test_options_opts): New.
567         (test_options_opts::dump): Also dump "-string".
568         (test_options_option_defs): Install "string.
569
570 2019-07-03  Pedro Alves  <palves@redhat.com>
571
572         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
573         option_value with a null enumeration.
574         (complete_options): Save the option values in the context.
575         (save_option_value_in_ctx): New, factored out from ...
576         (process_options): ... here.
577         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
578         of the function.
579         * maint-test-options.c (test_options_opts::dump): New, factored
580         out from ...
581         (maintenance_test_options_command_mode): ... here.
582         (maintenance_test_options_command_completion_result): Delete.
583         (maintenance_test_options_command_completion_text): Update
584         comment.
585         (maintenance_show_test_options_completion_result): Change
586         prototype.  Just print
587         maintenance_test_options_command_completion_text.
588         (save_completion_result): New.
589         (maintenance_test_options_completer_mode): Pass options context to
590         complete_options, and then save a dump.
591         (_initialize_maint_test_options): Use add_cmd to install "maint
592         show test-options-completion-result".
593
594 2019-07-03  Pedro Alves  <palves@redhat.com>
595
596         * NEWS (New commands): Mention "with" and "maint with".
597         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
598         (with_command, with_command_completer): New.
599         (pipe_command): Adjust to new repeat_previous
600         interface.
601         (_initialize_cli_cmds): Install the "with" command and its "w"
602         alias.
603         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
604         declarations.
605         * cli/cli-setshow.c (parse_cli_var_uinteger)
606         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
607         argument strings for all var_types.
608         (get_setshow_command_value_string): New, factored out from ...
609         (do_show_command): ... this.
610         * cli/cli-setshow.h: Include <string>.
611         (get_setshow_command_value_string): Declare.
612         * command.h (repeat_previous): Now returns const char *.  Adjust
613         comment.
614         * maint.c: Include "cli/cli-cmds.h".
615         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
616         (_initialize_maint_cmds): Register the "maintenance with" command.
617         * top.c (repeat_previous): Move bits from pipe_command here:
618         Return the saved command line, if any; error out if there's no
619         command to relaunch.
620
621 2019-07-03  Pedro Alves  <palves@redhat.com>
622
623         * NEWS (New commands): Mention "maint set/show test-settings"
624         instead of "maint test-settings".
625         * maint-test-settings.c (maintenance_test_settings_list): Delete.
626         (maintenance_test_settings_set_list): Rename to ...
627         (maintenance_set_test_settings_list): ... this.
628         (maintenance_test_settings_show_list): Rename to  ...
629         (maintenance_show_test_settings_list): ... this.
630         (maintenance_test_settings_cmd): Delete.
631         (maintenance_test_settings_set_cmd): ...
632         (maintenance_set_test_settings_cmd): ... this.
633         (maintenance_test_settings_show_cmd): ...
634         (maintenance_show_test_settings_cmd): ... this.
635         (maintenance_test_settings_show_value_cmd):
636         (maintenance_show_test_settings_value_cmd): ... this.
637         (_initialize_maint_test_settings): No longer install the "maint
638         test-settings" prefix command.  Rename "maint test-settings set"
639         to "maint set test-settings", and "maint test-settings show" to
640         "maint show test-settings".  Adjust all subcommands.
641
642 2019-07-03  Pedro Alves  <palves@redhat.com>
643
644         * maint-test-settings.c: Fix file's intro comment.  Replace all
645         references to "test-options" with references to "test-settings",
646         in comments.
647
648 2019-07-03  Pedro Alves  <palves@redhat.com>
649
650         * maint-test-settings.c (maintenance_test_settings_xxx)
651         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
652         New.
653         (maintenance_test_settings_enums): Use them.
654         (maintenance_test_settings_enum): Default to
655         maintenance_test_settings_xxx.
656         (_initialize_maint_test_settings): Initialize
657         MAINTENANCE_TEST_SETTINGS_FILENAME.
658
659 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
660
661         * breakpoint.h (remove_breakpoints_inf): Change return type to
662         void, move function documentation here.
663         * breakpoint.c (remove_breakpoints_inf): Change return type to
664         void, move function documentation to header.
665
666 2019-07-02  Pedro Alves  <palves@redhat.com>
667
668         * NEWS (Completion improvements): Mention "info threads".
669         * thread.c (struct info_threads_opts, info_threads_option_defs)
670         (make_info_threads_options_def_group): New.
671         (info_threads_command): Use gdb::option::process_options.
672         (info_threads_command_completer): New.
673         (_initialize_thread): Use gdb::option::build_help to build the
674         help text for "info threads".
675
676 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
677
678         * defs.h (generic_load): Move from here...
679         * symfile.h (generic_load): ... to here.  Rename name parameter
680         to args.
681         * symfile.c (generic_load): Add comment.
682
683 2019-07-01  Tom Tromey  <tromey@adacore.com>
684
685         * dwarf2read.c
686         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
687         declaration of without_params.  Fix formatting.
688
689 2019-07-01  Tom Tromey  <tromey@adacore.com>
690
691         * ada-exp.y (find_primitive_type): Update.
692         * ada-lang.h (ada_lookup_symbol): Update.
693         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
694         parameter.
695         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
696
697 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
698
699         PR breakpoints/24541
700         * gdbarch.c: Regenerate.
701         * gdbarch.h: Regenerate.
702         * gdbarch.sh: Add 'stap_adjust_register'.
703         * i386-tdep.c: Include '<unordered_set>'.
704         (i386_stap_adjust_register): New function.
705         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
706         * stap-probe.c (stap_parse_register_operand): Call
707         'gdbarch_stap_adjust_register'.
708
709 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
710
711         PR python/24742
712         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
713         * python/python.c (do_start_initialization): Use 'xmalloc'
714         instead of 'PyMem_Malloc'.
715
716 2019-06-28  Tom Tromey  <tromey@adacore.com>
717
718         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
719         for Ada.
720
721 2019-06-27  Tom Tromey  <tromey@adacore.com>
722
723         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
724         objfile_key.
725         (arm_find_mapping_symbol, arm_record_special_symbol)
726         (_initialize_arm_tdep): Update.
727         (arm_objfile_data_free): Remove.
728
729 2019-06-27  Tom Tromey  <tromey@adacore.com>
730
731         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
732         to cp_print_static_field.
733
734 2019-06-26  Tom Tromey  <tromey@adacore.com>
735
736         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
737         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
738         declare.
739
740 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
741
742         * features/aarch64-core.c (create_feature_aarch64_core):
743         Regenerate.
744         * features/aarch64-core.xml: Add cpsr flags.
745
746 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
747
748         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
749         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
750
751 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
752
753         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
754         field.
755         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
756         use.
757         (arm_record_special_symbol): Don't insert new symbol in sorted
758         position, push it at the end.
759
760 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
761
762         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
763         (arm_mapping_symbol_s): Remove.
764         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
765         (arm_mapping_symbol_vec): New typedef.
766         (struct arm_per_objfile): Add constructor.
767         <section_maps>: Change type to
768         std::unique_ptr<arm_mapping_symbol_vec[]>.
769         (arm_compare_mapping_symbols): Remove.
770         (arm_find_mapping_symbol): Adjust to section_maps type change.
771         (arm_objfile_data_free): Call delete on arm_per_objfile.
772         (arm_record_special_symbol): Adjust to section_maps type change.
773         Allocate arm_per_objfile with new.
774
775 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
776
777         * cli/cli-cmds.c (alias_command): Compare the alias prefix
778         with the command prefix.
779
780 2019-06-25  Tom Tromey  <tom@tromey.com>
781
782         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
783         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
784
785 2019-06-25  Tom Tromey  <tom@tromey.com>
786
787         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
788         type.
789         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
790         protected.
791
792 2019-06-25  Tom Tromey  <tom@tromey.com>
793
794         * tui/tui-winsource.c
795         (tui_source_window_base::set_is_exec_point_at): Add check against
796         LOA_ADDRESS.
797
798 2019-06-25  Tom Tromey  <tom@tromey.com>
799
800         * tui/tui-source.c (tui_set_source_content): Don't check before
801         xfree.
802         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
803
804 2019-06-25  Tom Tromey  <tom@tromey.com>
805
806         * tui/tui-winsource.h (tui_update_source_window_as_is)
807         (tui_alloc_source_buffer, tui_line_is_displayed)
808         (tui_addr_is_displayed): Change type of win_info.
809         * tui/tui-winsource.c (tui_update_source_window_as_is)
810         (tui_clear_source_content, tui_show_source_line)
811         (tui_show_source_content, tui_source_window_base::refill)
812         (tui_source_window_base::set_is_exec_point_at)
813         (tui_source_window_base::set_is_exec_point_at)
814         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
815         (tui_alloc_source_buffer, tui_line_is_displayed)
816         (tui_addr_is_displayed): Change type of win_info.  Update.
817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
818         (tui_source_window_base::do_make_visible_with_new_height):
819         Update.
820         * tui/tui-source.c (tui_set_source_content)
821         (tui_set_source_content_nil)
822         (tui_source_window::do_scroll_vertical): Update.
823         * tui/tui-layout.c (show_layout): Update.
824         * tui/tui-disasm.c (tui_set_disassem_content)
825         (tui_disasm_window::do_scroll_vertical): Update.
826         * tui/tui-data.h (tui_win_content): Remove.
827         (struct tui_gen_win_info) <content, content_size>: Remove.
828         (struct tui_source_element): Add initializers and destructor.
829         (union tui_which_element, struct tui_win_element): Remove.
830         (struct tui_source_window_base) <content>: New field.
831         (struct tui_data_window): Remove destructor.
832         (tui_alloc_content, tui_free_win_content)
833         (tui_free_all_source_wins_content): Don't declare.
834         * tui/tui-data.c (tui_initialize_static_data): Update.
835         (init_content_element, tui_alloc_content): Remove.
836         (~tui_gen_win_info): Update.
837         (~tui_data_window, tui_free_all_source_wins_content)
838         (tui_free_win_content, free_content, free_content_elements):
839         Remove.
840
841 2019-06-25  Tom Tromey  <tom@tromey.com>
842
843         * tui/tui-winsource.h (tui_clear_source_content)
844         (tui_erase_source_content, tui_show_source_content): Change type
845         of win_info.
846         * tui/tui-winsource.c (tui_clear_source_content)
847         (tui_erase_source_content, tui_show_source_content): Change type
848         of win_info.
849         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
850         * tui/tui-source.h (tui_set_source_content_nil): Change type of
851         win_info.
852         * tui/tui-source.c (tui_set_source_content_nil): Change type of
853         win_info.
854         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
855
856 2019-06-25  Tom Tromey  <tom@tromey.com>
857
858         * tui/tui-winsource.c (tui_clear_source_content)
859         (tui_source_window_base::set_is_exec_point_at): Update.
860         * tui/tui-source.c (tui_set_source_content_nil): Update.
861         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
862         a bool.
863         * tui/tui-data.c (init_content_element): Update.
864
865 2019-06-25  Tom Tromey  <tom@tromey.com>
866
867         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
868         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
869         * tui/tui-layout.c (init_and_make_win): Update.
870         * tui/tui.h (enum tui_win_type): Update.
871         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
872         tui_win_is_auxillary.
873         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
874         tui_win_is_auxillary.
875
876 2019-06-25  Tom Tromey  <tom@tromey.com>
877
878         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
879         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
880         (tui_delete_data_content_windows, tui_display_all_data)
881         (tui_data_window::do_scroll_vertical, tui_display_data_from):
882         Update.
883         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
884         * tui/tui-regs.c (tui_last_regs_line_no)
885         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
886         (tui_show_registers): Update.
887         (tui_show_register_group): Return void.  Update.
888         (tui_display_registers_from, tui_display_reg_element_at_line)
889         (tui_display_registers_from_line, tui_check_register_values):
890         Update.
891         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
892         member.
893         (struct tui_data_window) <regs_content>: Now a std::vector.
894         <regs_content_count>: Remove.
895         (tui_add_content_elements, tui_free_data_content): Don't declare.
896         * tui/tui-data.c (tui_data_window::clear_detail): Update.
897         (init_content_element): Remove DATA_WIN case.  Add assert.
898         (tui_add_content_elements): Remove.
899         (tui_data_window): Update.
900         (tui_free_data_content): Remove.
901         (free_content_elements): Remove DATA_WIN case.
902
903 2019-06-25  Tom Tromey  <tom@tromey.com>
904
905         * tui/tui-data.c (tui_data_item_window): Update.
906         * tui/tui-windata.h (tui_check_data_values): Don't declare.
907         * tui/tui-windata.c (tui_display_all_data)
908         (tui_display_data_from_line): Update.
909         (tui_check_data_values): Remove.
910         * tui/tui-regs.c (tui_show_register_group)
911         (tui_display_reg_element_at_line): Update.
912         * tui/tui-hooks.c (tui_register_changed)
913         (tui_refresh_frame_and_register_information): Call
914         tui_check_register_values.
915         * tui/tui-data.h (struct tui_data_window) <data_content,
916         data_content_count, data_type>: Remove.
917         (enum tui_data_type): Remove.
918
919         * tui/tui-data.c (tui_data_window::clear_detail)
920         (~tui_data_window): Update.
921
922 2019-06-25  Tom Tromey  <tom@tromey.com>
923
924         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
925         declare.
926         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
927         Rename from tui_first_data_item_displayed.  Update.
928         (tui_data_window::refresh_all)
929         (tui_data_window::do_scroll_vertical): Update.
930         * tui/tui-data.h (struct tui_data_window)
931         <first_data_item_displayed>: Declare new method.
932
933 2019-06-25  Tom Tromey  <tom@tromey.com>
934
935         * tui/tui-data.h (tui_init_generic_part): Don't declare.
936         * tui/tui-data.c (tui_init_generic_part): Remove, moving
937         contents...
938         (tui_initialize_static_data): ...here.
939
940 2019-06-25  Tom Tromey  <tom@tromey.com>
941
942         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
943         (tui_display_registers_from, tui_check_register_values): Update.
944         (tui_display_register): Remove win_info parameter; update.
945         (tui_get_register): Change type of parameters.
946         * tui/tui-data.h (struct tui_data_element): Remove.
947         (union tui_which_element) <data>: Remove.
948         <data_window>: Change type.
949         (struct tui_data_item_window): New.
950         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
951         case.  Add assert.
952         (~tui_data_item_window): New destructor.
953         (free_content_elements): Remove DATA_ITEM_WIN case.
954
955 2019-06-25  Tom Tromey  <tom@tromey.com>
956
957         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
958         Remove.
959
960 2019-06-25  Tom Tromey  <tom@tromey.com>
961
962         * tui/tui-data.h (struct tui_command_element): Remove.
963         (union tui_which_element) <command>: Remove.
964         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
965         assert.
966         (free_content_elements): Remove CMD_WIN case.
967
968 2019-06-25  Tom Tromey  <tom@tromey.com>
969
970         * tui/tui-layout.c (tui_set_layout): Update.
971         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
972         * tui/tui-data.c (layout_def): Update.
973
974 2019-06-25  Tom Tromey  <tom@tromey.com>
975
976         * tui/tui-wingeneral.c (tui_refresh_all): Update.
977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
978         (tui_source_window_base::set_new_height): Update.
979         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
980         Update.
981         (tui_set_locator_fullname, tui_set_locator_info)
982         (tui_show_frame_info): Update.
983         * tui/tui-source.c (tui_set_source_content)
984         (tui_source_is_displayed): Update.
985         * tui/tui-layout.c (show_source_disasm_command, show_data)
986         (show_source_or_disasm_and_command): Update.
987         * tui/tui-disasm.c (tui_set_disassem_content)
988         (tui_get_begin_asm_address): Update.
989         * tui/tui-data.h (struct tui_locator_element): Remove.
990         (union tui_which_element) <locator>: Remove.
991         (struct tui_locator_window): New.
992         (tui_locator_win_info_ptr): Change return type.
993         * tui/tui-data.c (_locator): Change type.
994         (tui_locator_win_info_ptr): Change return type.
995         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
996         (tui_alloc_content): Add assert.
997
998 2019-06-25  Tom Tromey  <tom@tromey.com>
999
1000         * tui/tui-winsource.c
1001         (tui_exec_info_window::maybe_allocate_content): New method.
1002         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1003         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1004         (make_source_or_disasm_window): Add cast.
1005         * tui/tui-data.h (union tui_which_element) <simple_string>:
1006         Remove.
1007         (struct tui_source_info): New.
1008         (struct tui_source_window_base) <execution_info>: Change type.
1009         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1010         case, and add assert.
1011         (tui_alloc_content): Add assert.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1016         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1017         * tui/tui-data.c (tui_alloc_win_info): Remove.
1018
1019 2019-06-25  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1022         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1023         can_highlight.
1024
1025 2019-06-25  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1028         make_visible_with_new_height method.
1029         (tui_win_info::make_visible_with_new_height): New method.
1030         (tui_source_window_base::do_make_visible_with_new_height)
1031         (tui_data_window::do_make_visible_with_new_height)
1032         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1033         (make_visible_with_new_height): Remove.
1034         (tui_resize_all, tui_adjust_win_heights): Use
1035         make_visible_with_new_height method.
1036         * tui/tui-data.h (struct tui_win_info)
1037         <do_make_visible_with_new_height, make_visible_with_new_height>:
1038         New methods.
1039         (struct tui_source_window_base, struct tui_data_window)
1040         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1041         methods.
1042
1043 2019-06-25  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1046         method.
1047         (update_tab_width): Call update_tab_width method.
1048         * tui/tui-data.h (struct tui_win_info)
1049         (struct tui_source_window_base) <update_tab_width>: New methods.
1050
1051 2019-06-25  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1054         parameter.
1055         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1056         parameter.
1057         (tui_gen_win_info::make_visible): Update.
1058         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1059         parameter.
1060         * tui/tui-data.h (enum tui_box): New enum.
1061         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1062
1063 2019-06-25  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1066         init_and_make_win for EXEC_INFO_WIN.
1067         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1068         longer inline.
1069         (struct tui_win_info) <~tui_win_info>: Inline.
1070         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1071         Don't declare.
1072         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1073         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1074         Remove.
1075         (tui_initialize_static_data): Update.
1076         (~tui_gen_win_info): Handle more cleanup here.
1077         (~tui_source_window_base): Delete "execution_info".
1078         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1079
1080 2019-06-25  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-layout.c (make_command_window): Don't set
1083         can_highlight.
1084         (show_source_disasm_command): Call the reset method.
1085         (show_data): Don't set can_highlight.  Call the reset method.
1086         (tui_gen_win_info::reset): Rename from init_gen_win_info
1087         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1088         (show_source_or_disasm_and_command): Call the reset method.
1089         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1090         (struct tui_cmd_window): Set can_highlight.
1091
1092 2019-06-25  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1095         from make_visible.
1096         (tui_make_visible, tui_make_invisible): Rewrite.
1097         (tui_win_info::make_visible): Remove.
1098         (tui_source_window_base::make_visible): Update.
1099         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1100         method.  Moved from...
1101         (struct tui_win_info) <make_visible>: ...here.
1102
1103 2019-06-25  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-winsource.c
1106         (tui_source_window_base::do_scroll_horizontal): Remove direction
1107         parameter.
1108         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1109         direction parameter.
1110         * tui/tui-win.c (tui_win_info::forward_scroll)
1111         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1112         (tui_win_info::right_scroll): Update.
1113         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1114         direction parameter.
1115         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1116         direction parameter.
1117         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1118         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1119         Remove direction parameter.
1120         (struct tui_source_window_base, struct tui_source_window)
1121         (struct tui_disasm_window, struct tui_data_window)
1122         (struct tui_cmd_window): Update.
1123
1124 2019-06-25  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-winsource.h (tui_set_exec_info_content)
1127         (tui_show_exec_info_content, tui_erase_exec_info_content)
1128         (tui_clear_exec_info_content, tui_update_exec_info): Change
1129         argument to tui_source_window_base.
1130         * tui/tui-winsource.c (tui_set_exec_info_content)
1131         (tui_show_exec_info_content, tui_erase_exec_info_content)
1132         (tui_clear_exec_info_content, tui_update_exec_info): Change
1133         argument to tui_source_window_base.
1134
1135 2019-06-25  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1138         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1139
1140 2019-06-25  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1143         check.
1144
1145 2019-06-25  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1148         type to void.
1149         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1150         type to void.
1151         * tui/tui-source.c (tui_set_source_content): Update.
1152         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1153
1154 2019-06-25  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-win.c (window_name_completer, tui_set_focus)
1157         (tui_all_windows_info): Use name method.
1158         * tui/tui-data.h (struct tui_gen_win_info)
1159         (struct tui_source_window, struct tui_disasm_window)
1160         (struct tui_data_window, struct tui_cmd_window) <name>: New
1161         method.
1162         (tui_win_name): Don't declare.
1163         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1164         (tui_win_name): Remove.
1165
1166 2019-06-25  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-winsource.h (tui_update_source_window)
1169         (tui_update_source_window_as_is): Change parameter type.
1170         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1171         to be a tui_source_window_base.
1172         (tui_update_source_window_as_is): Likewise.
1173         * tui/tui-win.c (make_visible_with_new_height): Update.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-winsource.c (tui_erase_source_content)
1178         (tui_show_source_content, tui_show_exec_info_content)
1179         (tui_erase_exec_info_content): Use refresh_window method.
1180         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1181         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1182         from tui_refresh_win.
1183         (tui_data_window::refresh_window): New method.
1184         (tui_win_info::refresh, tui_source_window_base::refresh)
1185         (tui_refresh_all): Use refresh_window method.
1186         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1187         method.
1188         * tui/tui-regs.c (tui_display_register): Call refresh_window
1189         method.
1190         * tui/tui-layout.c (show_source_disasm_command)
1191         (show_source_or_disasm_and_command): Call refresh_window method.
1192         * tui/tui-data.h (struct tui_gen_win_info)
1193         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1194         New method.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui.c (tui_rl_other_window, tui_enable)
1199         (tui_is_window_visible, tui_get_command_dimension): Update.
1200         * tui/tui-winsource.c (tui_update_source_window_as_is)
1201         (tui_clear_source_content, tui_erase_source_content)
1202         (tui_show_source_line, tui_source_window_base::refill)
1203         (tui_source_window_base::do_scroll_horizontal)
1204         (tui_source_window_base::set_is_exec_point_at)
1205         (tui_update_breakpoint_info, tui_set_exec_info_content)
1206         (tui_alloc_source_buffer, tui_line_is_displayed)
1207         (tui_addr_is_displayed): Update.
1208         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1209         (tui_check_and_display_highlight_if_needed)
1210         (tui_win_info::make_visible, tui_win_info::refresh)
1211         (tui_refresh_all): Update.
1212         * tui/tui-windata.c (tui_first_data_item_displayed)
1213         (tui_delete_data_content_windows, tui_erase_data_content)
1214         (tui_display_all_data, tui_data_window::refresh_all)
1215         (tui_check_data_values): Update.
1216         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1217         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1218         (tui_win_info::backward_scroll, tui_refresh_all_win)
1219         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1220         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1221         (tui_source_window_base::set_new_height)
1222         (tui_data_window::set_new_height)
1223         (make_invisible_and_set_new_height)
1224         (make_visible_with_new_height, new_height_ok)
1225         (parse_scrolling_args): Update.
1226         * tui/tui-stack.c (tui_show_frame_info): Update.
1227         * tui/tui-source.c (tui_set_source_content)
1228         (tui_set_source_content_nil, tui_source_is_displayed)
1229         (tui_source_window::do_scroll_vertical): Update.
1230         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1231         (tui_display_registers_from, tui_display_reg_element_at_line)
1232         (tui_check_register_values, tui_reg_command): Update.
1233         * tui/tui-layout.c (tui_default_win_height)
1234         (show_source_disasm_command, show_data, init_and_make_win)
1235         (show_source_or_disasm_and_command): Update.
1236         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1237         (tui_redisplay_readline, tui_mld_flush)
1238         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1239         (tui_getc): Update.
1240         * tui/tui-disasm.c (tui_set_disassem_content)
1241         (tui_disasm_window::do_scroll_vertical): Update.
1242         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1243         Now virtual.
1244         (struct tui_win_info): Derive from tui_gen_win_info.
1245         <~tui_win_info>: Mark as override.
1246         <generic>: Remove member.
1247         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1248         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1249         (~tui_data_window, ~tui_win_info)
1250         (tui_free_all_source_wins_content): Update.
1251         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1252
1253 2019-06-25  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-layout.c (init_and_make_win): Use new.
1256         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1257         destructor, initializers.
1258         (tui_alloc_generic_win_info): Don't declare.
1259         * tui/tui-data.c (_locator): Add argument to constructor.
1260         (source_win, disasm_win): New globals.
1261         (exec_info): Remove.
1262         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1263         Update.
1264         (tui_alloc_generic_win_info): Remove.
1265         (init_content_element): Use new.
1266         (tui_win_info::tui_win_info): Update.
1267         (free_content_elements) <case DATA_WIN>: Use delete.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1272         * tui/tui-windata.c (tui_first_data_item_displayed)
1273         (tui_delete_data_content_windows): Update.
1274         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1275         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1276         (tui_display_registers_from, tui_check_register_values): Update.
1277         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1278         pointer.
1279         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1280         window.
1281         (tui_free_data_content): Update.
1282         (free_content_elements) <case DATA_WIN>: Free the window.
1283
1284 2019-06-25  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1287         Update.
1288         * tui/tui-layout.c (make_command_window)
1289         (show_source_disasm_command, show_data, init_and_make_win)
1290         (show_source_or_disasm_and_command): Update.
1291         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1292         method.
1293         <can_highight, is_highlighted>: Now bool.
1294         (tui_set_win_highlight): Don't declare.
1295         * tui/tui-data.c (tui_set_win_highlight): Remove.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-wingeneral.c (make_visible): Remove check of window
1300         type.
1301
1302 2019-06-25  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-win.c (tui_win_info::max_height)
1305         (tui_cmd_window::max_height): New methods.
1306         (new_height_ok): Call max_height.
1307         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1308         <max_height>: New method.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-win.c (tui_source_window_base::set_new_height)
1313         (tui_data_window::set_new_height): New methods.
1314         (make_invisible_and_set_new_height): Call set_new_height method.
1315         * tui/tui-data.h (struct tui_win_info)
1316         (struct tui_source_window_base, struct tui_data_window)
1317         <set_new_height>: New method.
1318
1319 2019-06-25  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1322         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1323         tui_refresh_data_win.
1324         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1325         method.
1326         (tui_refresh_all_win): Call the refresh_all method.
1327         (tui_set_focus): Likewise.
1328         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1329         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1330         Likewise.
1331
1332 2019-06-25  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-winsource.h (tui_refill_source_window)
1335         (tui_set_is_exec_point_at): Don't declare.
1336         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1337         (tui_source_window_base::refill): Rename from
1338         tui_refill_source_window.
1339         (tui_source_window_base::do_scroll_horizontal): Update.
1340         (tui_source_window_base::set_is_exec_point_at): Rename from
1341         tui_set_is_exec_point_at.
1342         (tui_update_all_breakpoint_info): Update.
1343         * tui/tui-stack.c (tui_show_frame_info): Update.
1344         * tui/tui-layout.c (show_data): Add cast.
1345         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1346         * tui/tui-data.h (struct tui_source_window_base) <refill,
1347         set_is_exec_point_at>: New methods.
1348         (tui_source_windows, tui_add_to_source_windows): Update types.
1349         (tui_add_to_source_windows): Remove redundant declaration.
1350         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1351         (tui_source_windows): Change return type.
1352         (tui_clear_source_windows_detail): Update.
1353         (tui_add_to_source_windows): Change type of parameter.
1354         (tui_free_all_source_wins_content): Update.
1355
1356 2019-06-25  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-wingeneral.c (tui_win_info::refresh)
1359         (tui_source_window_base::refresh): New methods.
1360         (tui_refresh_all): Call the refresh method.
1361         * tui/tui-data.h (struct tui_win_info)
1362         (struct tui_source_window_base) <refresh>: New method.
1363
1364 2019-06-25  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui.h (tui_is_window_visible): Return bool.
1367         * tui/tui.c (tui_is_window_visible): Return bool.
1368         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1369         (tui_make_visible, tui_make_invisible)
1370         (tui_win_info::make_visible)
1371         (tui_source_window_base::make_visible, make_all_visible)
1372         (tui_make_all_visible, tui_make_all_invisible): Update.
1373         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1374         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1375         bool.
1376         (struct tui_win_info, struct tui_source_window_base)
1377         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1378         * tui/tui-data.c (tui_init_generic_part): Update.
1379
1380 2019-06-25  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1383         (tui_source_window_base::make_visible): New methods.
1384         (make_all_visible): Make method call.
1385         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1386         (struct tui_source_window_base, struct tui_cmd_window): Override
1387         make_visible.
1388         (tui_win_is_source_type): Don't declare.
1389         * tui/tui-data.c (tui_win_is_source_type): Remove.
1390
1391 2019-06-25  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1394         NULL check.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1399         Inline constructor.  Add initializers for members.
1400         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1401         constructors; now inline in class.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-regs.c (tui_show_registers): Update.
1406         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1407         bool.
1408         * tui/tui-data.c (tui_data_window::clear_detail)
1409         (tui_data_window): Update.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-windata.c (tui_display_all_data)
1414         (tui_display_data_from_line, tui_display_data_from)
1415         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1416         Update.
1417         * tui/tui-regs.c (tui_last_regs_line_no)
1418         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1419         (tui_show_registers, tui_show_register_group)
1420         (tui_display_registers_from, tui_display_reg_element_at_line)
1421         (tui_display_registers_from_line, tui_check_register_values)
1422         (tui_reg_next, tui_reg_prev): Update.
1423         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1424         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1425         tui_data_window.
1426         (struct tui_win_info) <detail>: Remove.  Add new fields from
1427         tui_data_info.
1428         (TUI_DATA_WIN): Add cast.
1429         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1430         (~tui_data_window): Simplify.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-layout.c (show_source_disasm_command)
1435         (show_source_or_disasm_and_command): Update.
1436         * tui/tui-io.c (update_cmdwin_start_line)
1437         (tui_redisplay_readline): Update.
1438         * tui/tui-data.h (struct tui_command_info): Remove.
1439         (struct tui_win_info) <detail>: Remove command_info member.
1440         (struct tui_data_window) <start_line>: New member, from
1441         tui_command_info.
1442         (TUI_CMD_WIN): Add casts.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-winsource.c (tui_update_source_window)
1447         (tui_refill_source_window)
1448         (tui_source_window_base::do_scroll_horizontal)
1449         (tui_update_breakpoint_info, tui_set_exec_info_content)
1450         (tui_show_exec_info_content, tui_erase_exec_info_content)
1451         (tui_clear_exec_info_content): Update.
1452         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1453         Update.
1454         * tui/tui-win.c (make_invisible_and_set_new_height)
1455         (make_visible_with_new_height): Update.
1456         * tui/tui-source.c (tui_set_source_content)
1457         (tui_show_symtab_source): Update.
1458         * tui/tui-layout.c (extract_display_start_addr)
1459         (show_source_disasm_command, show_data)
1460         (make_source_or_disasm_window)
1461         (show_source_or_disasm_and_command): Update.
1462         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1463         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1464         "gdbarch".
1465         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1466         to tui_source_window_base.
1467         (struct tui_win_info) <detail>: Remove source_info member.
1468         (struct tui_source_window_base) <has_locator>: Inline.
1469         Move contents from tui_source_info; rename has_locator member to
1470         m_has_locator.
1471         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1472         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1473         header file.
1474         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1475         Simplify.
1476         (tui_free_all_source_wins_content): Cast to
1477         tui_source_window_base.
1478
1479 2019-06-25  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-win.c (make_invisible_and_set_new_height)
1482         (make_visible_with_new_height): Call has_locator method.
1483         * tui/tui-layout.c (show_source_disasm_command, show_data)
1484         (show_source_or_disasm_and_command): Update for bool change.
1485         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1486         (tui_win_info) <has_locator>: New method.
1487         (struct tui_source_window_base) <has_locator>: New method.
1488         (tui_win_has_locator): Don't declare.
1489         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1490         from tui_win_has_locator.
1491         (tui_source_window_base): Use false, not FALSE.
1492
1493 2019-06-25  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1496         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1497         clear_detail method directly.
1498         (tui_clear_win_detail): Remove.
1499
1500 2019-06-25  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1503         "this", not TUI_DISASM_WIN.
1504
1505 2019-06-25  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1508         declare.
1509         * tui/tui-winsource.c
1510         (tui_source_window_base::do_scroll_horizontal): Rename from
1511         tui_horizontal_source_scroll.
1512         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1513         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1514         from tui_vertical_data_scroll.
1515         * tui/tui-win.h (tui_scroll): Don't declare.
1516         * tui/tui-win.c (tui_win_info::forward_scroll)
1517         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1518         (tui_win_info::right_scroll): Rename and update.
1519         (tui_scroll_forward_command, tui_scroll_backward_command)
1520         (tui_scroll_left_command, tui_scroll_right_command): Update.
1521         (tui_scroll): Remove.
1522         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1523         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1524         from tui_vertical_source_scroll.
1525         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1526         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1527         from tui_vertical_disassem_scroll.
1528         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1529         do_scroll_horizontal>: New methods.
1530         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1531         Likewise.
1532         (struct tui_source_window_base): Add do_scroll_horizontal.
1533         (struct tui_source_window, struct tui_disasm_window): Add
1534         do_scroll_vertical.
1535         (struct tui_data_window, struct tui_cmd_window): Add
1536         do_scroll_horizontal and do_scroll_vertical.
1537         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1538
1539 2019-06-25  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-data.h (struct tui_source_window_base): New struct.
1542         (struct tui_source_window): Derive from tui_source_window_base.
1543         (struct tui_disasm_window): New struct.
1544         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1545         from tui_source_window::clear_detail.
1546         (tui_source_window_base): Rename from tui_source_window.
1547         (~tui_source_window_base): Rename from ~tui_source_window.
1548         (tui_alloc_win_info): Create a tui_disasm_window.
1549
1550 2019-06-25  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-data.h (struct tui_source_window)
1553         (struct tui_data_window): Declare destructors.
1554         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1555         destructors.
1556         (tui_win_info): Simplify.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.c (tui_display_main)
1561         (tui_update_source_windows_with_addr)
1562         (tui_update_all_breakpoint_info): Update.
1563         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1564         (new_height_ok, parse_scrolling_args): Update.
1565         * tui/tui-stack.c (tui_show_frame_info): Update.
1566         * tui/tui-data.h (struct tui_list): Remove.
1567         (tui_source_windows): Return a reference to a std::vector.
1568         * tui/tui-data.c (source_windows): Now a std::vector.
1569         (tui_source_windows): Change return type.
1570         (tui_clear_source_windows): Rewrite.
1571         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1572         (tui_free_all_source_wins_content): Rewrite.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1577         (struct tui_data_window, struct tui_cmd_window): Declare
1578         clear_detail method.
1579         * tui/tui-data.c (tui_source_window::clear_detail)
1580         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1581         methods.
1582         (tui_clear_win_detail): Simplify.
1583
1584 2019-06-25  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-layout.c (make_source_window, make_disasm_window)
1587         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1588         Return the new window.
1589         (show_source_disasm_command, show_data)
1590         (show_source_or_disasm_and_command): Update.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1595         parameter.  Return the new window.
1596         (show_source_disasm_command): Update and remove NULL check.
1597         (show_source_or_disasm_and_command): Update.
1598
1599 2019-06-25  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-data.h (struct tui_win_info): Make constructor
1606         protected.  Make destructor virtual.  Add initializers.
1607         (tui_source_window, tui_data_window, tui_cmd_window): New
1608         classes.
1609         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1610         constructor.  Add "type" parameter.
1611         (tui_source_window, tui_data_window, tui_cmd_window): New
1612         constructors.
1613         (tui_alloc_win_info): Instantiate the appropriate subclass.
1614
1615 2019-06-25  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-win.c (tui_resize_all): Use delete.
1618         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1619         destructor.
1620         (tui_free_window): Don't declare.
1621         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1622         Update.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-data.h (struct tui_win_info): Add constructor.
1627         * tui/tui-data.c (tui_alloc_win_info): Use new.
1628         (tui_free_window): Use delete.
1629
1630 2019-06-22  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1633         declare.
1634         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1635
1636 2019-06-22  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1639         declare.
1640         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1641
1642 2019-06-22  Tom de Vries  <tdevries@suse.de>
1643
1644         * dwarf2read.c (create_addrmap_from_aranges)
1645         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1646         instead of '%zu'.
1647
1648 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1649
1650         * dwarf2read.h (dwarf2_section_info_def): Remove.
1651         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1652         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1653         std::vector<dwarf2_section_info>.
1654         (struct dwo_file) <~dwo_file>: Remove.
1655         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1656         types field.
1657         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1658         (dwarf2_read_debug_names): Likewise.
1659         (create_debug_types_hash_table): Change parameter type to
1660         array_view, adjust code accordingly.
1661         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1662         (partial_die_info::fixup): Likewise.
1663         (determine_prefix): Likewise.
1664         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1665
1666 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1667
1668         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1669         gdb_bfd_ref_ptr.
1670         <~dwo_file>: Remove call to gdb_bfd_unref.
1671         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1672         gdb_bfd_ref_ptr::get.
1673
1674 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1675
1676         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1677         type to htab_up.
1678         * dwarf2read.c (struct dwo_file): Initialize fields.
1679         <~dwo_file>: New.
1680         (free_dwo_file): Remove, move content to ~dwo_file.
1681         (struct dwo_file_deleter): Remove.
1682         (dwo_file_up>: Remove custom deleter.
1683         (free_dwo_files): Remove.
1684         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1685         dwo_files.
1686         (process_skeletonless_type_units): Call unique_ptr::get.
1687         (allocate_dwo_file_hash_table): Add deleter to created hash
1688         table.  Change return type to htab_up.
1689         (lookup_dwo_file_slot): Don't memset dwo_file, call
1690         unique_ptr::get.
1691         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1692         (create_dwo_unit_in_dwp_v2): Likewise.
1693         (open_and_init_dwo_file): Likewise.
1694         (free_dwo_file_from_slot): Remove.
1695
1696 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1697
1698         * dwarf2read.h (struct dwarf2_section_info) <readin,
1699         is_virtual>: Change type to bool.
1700         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1701         true instead of 1.
1702
1703 2019-06-19  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-data.h (tui_init_content_element): Don't declare.
1706
1707 2019-06-19  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-data.h (tui_init_win_info): Don't declare.
1710
1711 2019-06-19  Tom de Vries  <tdevries@suse.de>
1712
1713         * dwarf2read.h (abstract_to_concrete): Change type to
1714         std::unordered_map<sect_offset, std::vector<sect_offset>,
1715         gdb::hash_enum<sect_offset>>.
1716
1717 2019-06-19  Tom Tromey  <tromey@adacore.com>
1718
1719         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1720         EVAL_AVOID_SIDE_EFFECTS specially.
1721
1722 2019-06-19  Tom Tromey  <tromey@adacore.com>
1723
1724         * source-cache.c (highlighter): New global.
1725         (source_cache::get_source_lines): Create a highlighter on demand.
1726
1727 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * defs.h (deprecated_interactive_hook): Delete declaration.
1730         * interps.c (clear_interpreter_hooks): Remove use of
1731         deprecated_interactive_hook.
1732         * top.c (deprecated_interactive_hook): Delete definition.
1733         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1734
1735 2019-06-18  Tom de Vries  <tdevries@suse.de>
1736
1737         PR gdb/24515
1738         * dwarf2read.h (abstract_to_concrete): Change type from
1739         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1740         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1741         * dwarf2read.c (read_variable): Update.
1742         (dwarf2_fetch_die_loc_sect_off): Update.
1743
1744 2019-06-17  Tom de Vries  <tdevries@suse.de>
1745
1746         PR gdb/24617
1747         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1748         accessing parent[parent_len - 1].
1749
1750 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1751
1752         PR gdb/24364
1753         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1754         call dtrace_process_dof with NULL dof.
1755
1756 2019-06-16  Tom de Vries  <tdevries@suse.de>
1757
1758         PR gdb/24445
1759         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1760
1761 2019-06-16  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1764         (make_all_visible): Use address of member.
1765
1766 2019-06-16  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1769         (tui_free_window, free_content, free_content_elements): Remove
1770         unnecessary cast.
1771         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1772         cast.
1773         * tui/tui-regs.c (tui_show_register_group)
1774         (tui_display_registers_from, tui_display_reg_element_at_line):
1775         Remove unnecessary cast.
1776
1777 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1778
1779         * linux-nat.c (normal_mask): Delete.
1780         (_initialize_linux_nat): Don't initialise normal_mask.
1781
1782 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1783
1784         PR gdb/24445
1785         * dwarf-index-write.h (write_psymtabs_to_index): Add
1786         dwz_basename parameter.
1787         * dwarf-index-write.c (write_gdbindex): Move file writing to
1788         write_gdbindex_1.  Change return type void.
1789         (assert_file_size): Move up, remove filename parameter.
1790         (write_gdbindex_1): New function.
1791         (write_debug_names): Change return type to void, call
1792         assert_file_size.
1793         (struct index_wip_file): New struct.
1794         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1795         file logic to index_wip_file.  Write index for dwz file if
1796         needed.
1797         (save_gdb_index_command): Pass basename of dwz file, if present.
1798         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1799         build-id of dwz file, if present.
1800         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1801         (dwarf2_get_dwz_file): Likewise.
1802         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1803         (dwarf2_get_dwz_file): Likewise.
1804
1805 2019-06-16  Tom Tromey  <tom@tromey.com>
1806
1807         * coffread.c (process_coff_symbol): Use xstrdup.
1808         * value.c (create_internalvar): Use xstrdup.
1809
1810 2019-06-16  Tom Tromey  <tom@tromey.com>
1811
1812         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1813         * breakpoint.c (stopin_command, stopat_command)
1814         (until_break_command, decode_location_default): Remove unnecessary
1815         cast.
1816         * utils.c (subset_compare): Remove unnecessary cast.
1817         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1818         cast.
1819         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1820         cast.
1821         * infcmd.c (path_command): Remove unnecessary cast.
1822         * coffread.c (decode_type): Remove unnecessary cast.
1823         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1824         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1825         * tui/tui-stack.c (tui_show_locator_content)
1826         (tui_show_frame_info): Remove unnecessary cast.
1827         * tui/tui-win.c (tui_scroll_forward_command)
1828         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1829         (parse_scrolling_args): Remove unnecessary cast.
1830         * tui/tui-data.c (init_win_info, tui_del_window)
1831         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1832         (free_content_elements): Remove unnecessary cast.
1833         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1834         unnecessary cast.
1835         * tui/tui-source.c (tui_set_source_content)
1836         (tui_vertical_source_scroll): Remove unnecessary cast.
1837         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1838         cast.
1839         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1840         * tui/tui-regs.c (tui_display_registers_from)
1841         (tui_display_register): Remove unnecessary cast.
1842         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1843         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1844         (make_visible): Remove unnecessary cast.
1845         * tui/tui-winsource.c (tui_erase_source_content)
1846         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1847         unnecessary cast.
1848         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1849         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1850         * stabsread.c (read_type, read_array_type, read_range_type):
1851         Remove unnecessary cast.
1852         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1853         (parse_symbol, parse_type, upgrade_type, parse_external)
1854         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1855         unnecessary cast.
1856         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1857
1858 2019-06-16  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-data.c (tui_alloc_generic_win_info)
1861         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1862         checks.
1863
1864 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1865             Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * f-typeprint.c (f_print_type): Don't return early for not
1868         associated or not allocated types.
1869         (f_type_print_varspec_suffix): Add print_rank parameter and print
1870         ranks of array types in case they dangling.
1871         (f_type_print_base): Add print_rank parameter.
1872
1873 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * NEWS: Mention new MI commands.
1876         * break-catch-throw.c (enum exception_event_kind): Move to
1877         breakpoint.h.
1878         (print_mention_exception_catchpoint): Output text as a single
1879         message.
1880         (catch_exception_command_1): Rename to...
1881         (catch_exception_event): ...this, make non-static, update header
1882         command, and change some parameter types.
1883         (catch_catch_command): Update for changes to
1884         catch_exception_command_1.
1885         (catch_throw_command): Likewise.
1886         (catch_rethrow_command): Likewise.
1887         * breakpoint.c (enum exception_event_kind): Delete.
1888         * breakpoint.h (enum exception_event_kind): Moved here from
1889         break-catch-throw.c.
1890         (catch_exception_event): Declare.
1891         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1892         (mi_cmd_catch_throw): New function.
1893         (mi_cmd_catch_rethrow): New function.
1894         (mi_cmd_catch_catch): New function.
1895         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1896         'catch-catch' entries.
1897         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1898         (mi_cmd_catch_rethrow): Declare.
1899         (mi_cmd_catch_catch): Declare.
1900
1901 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1902
1903         * annotate.c (annotate_source_line): Change return type to void,
1904         update implementation to match.
1905         * annotate.h (annotate_source_line): Change return type to void,
1906         update header comment.
1907         * stack.c (print_frame_info): Don't change what frame information
1908         is printed based on whether annotations are on or not.
1909
1910 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1913         (annotate_source): Make static.
1914         (annotate_source_line): Moved from source.c and renamed from
1915         identify_source_line.  Update the return type.
1916         * annotate.h (annotate_source): Delete declaration.
1917         (annotate_source_line): Declaration moved from source.h, and
1918         renamed from identify_source_line.  Return type updated.
1919         * source.c (identify_source_line): Moved to annotate.c and renamed
1920         to annotate_source_line.
1921         (info_line_command): Remove check of annotation_level.
1922         * source.h (identify_source_line): Move declaration to annotate.h
1923         and rename to annotate_source_line.
1924         * stack.c: Add 'annotate.h' include.
1925         (print_frame_info): Remove check of annotation_level before
1926         calling annotate_source_line.
1927
1928 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * source-cache.c (source_cache::get_plain_source_lines): Use
1931         open_source_file_with_line_charpos instead of just
1932         open_source_file, remove call to find_source_lines.
1933         (source_cache::get_source_lines): Likewise.
1934         * source.c (find_source_lines): Make static.
1935         (get_filename_and_charpos): Renamed into...
1936         (open_source_file_with_line_charpos): ..this along with changes to
1937         return a scoped_fd, and some other minor clean ups.
1938         (identify_source_line): Use open_source_file_with_line_charpos.
1939         (search_command_helper): Use open_source_file_with_line_charpos
1940         instead of just open_source_file, remove call to
1941         find_source_lines.
1942         * source.h (open_source_file_with_line_charpos): Declare new
1943         function.
1944         (find_source_lines): Delete declaration.
1945
1946 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * source.c (get_filename_and_charpos): Remove fullname
1949         parameter.
1950         (identify_source_line): Update call to get_filename_and_charpos.
1951
1952 2019-06-14  Tom Tromey  <tromey@adacore.com>
1953
1954         PR gdb/24502:
1955         * ui-style.h (skip_ansi_escape): Update comment.
1956         * ui-file.h (class no_terminal_escape_file): New class.
1957         * ui-file.c (no_terminal_escape_file::write)
1958         (no_terminal_escape_file::puts): New methods.
1959         * cli/cli-logging.c (handle_redirections): Use
1960         no_terminal_escape_file.
1961
1962 2019-06-14  Tom Tromey  <tromey@adacore.com>
1963
1964         * NEWS: Move convenience variable news above Python news.
1965
1966 2019-06-14  Tom Tromey  <tom@tromey.com>
1967
1968         * gnulib: Move directory to top-level.
1969         * configure.ac: Don't configure gnulib.
1970         * configure: Rebuild.
1971         * common/common-defs.h: Use new path to gnulib.
1972         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1973         (GNULIB_H): Remove.
1974         (INCGNU): Look in new gnulib location.
1975         (HFILES_NO_SRCDIR): Remove gnulib files.
1976         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1977         (generated_files): Remove GNULIB_H.
1978         ($(LIBGNU), all-lib): Remove targets.
1979         (distclean): Don't mention GNULIB_BUILDDIR.
1980         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1981
1982 2019-06-14  Tom Tromey  <tromey@adacore.com>
1983
1984         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1985         Warn if symbol file does not provide any symbols.
1986
1987 2019-06-14  Tom Tromey  <tromey@adacore.com>
1988
1989         * source.c (find_and_open_source): Respect basenames_may_differ.
1990
1991 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1992
1993         * annotate.c (annotate_breakpoints_invalid): Make use of
1994         scoped_restore_terminal_state.
1995         (annotate_frames_invalid): Likewise.
1996
1997 2019-06-14  Tom Tromey  <tromey@adacore.com>
1998
1999         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2000         allow assignment to an internalvar.
2001
2002 2019-06-14  Tom Tromey  <tromey@adacore.com>
2003
2004         * ada-lex.l: Allow "_" in attribute names.
2005
2006 2019-06-14  Tom Tromey  <tromey@adacore.com>
2007
2008         PR gdb/24653:
2009         * regcache.c (registers_changed): Don't call alloca.
2010         * top.c (execute_command): Don't call alloca.
2011
2012 2019-06-13  Pedro Alves  <palves@redhat.com>
2013
2014         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2015         'expression'.  When parsing an expression, error out if there's
2016         junk after "unlimited".
2017         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2018         (do_set_command): Adjust calls to is_unlimited_literal.
2019
2020 2019-06-13  Pedro Alves  <palves@redhat.com>
2021
2022         * compile/compile.c (make_compile_options_def_group): Add braces
2023         around array_view initializer.
2024         * thread.c (make_thread_apply_all_options_def_group)
2025         (make_thread_apply_all_options_def_group): Likewise.
2026
2027 2019-06-13  Pedro Alves  <palves@redhat.com>
2028
2029         * NEWS (New commands): Mention "maint test-options
2030         require-delimiter", "maint test-options unknown-is-error", "maint
2031         test-options unknown-is-operand" and "maint show
2032         test-options-completion-result".
2033         (New command options, command completion): New section.
2034         (Completion improvements): New section.
2035         Mention that you can abbreviate "unlimited".
2036
2037 2019-06-13  Pedro Alves  <palves@redhat.com>
2038
2039         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2040         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2041         * unittests/cli-utils-selftests.c (test_parse_flags)
2042         (test_parse_flags_qcs): Delete.
2043         (test_cli_utils): Don't call deleted functions.
2044
2045 2019-06-13  Pedro Alves  <palves@redhat.com>
2046
2047         * thread.c: Include "cli/cli-option.h".
2048         (tp_array_compar_ascending): Global.
2049         (tp_array_compar): Delete function.
2050         (tp_array_compar_ascending, tp_array_compar_descending): New
2051         functions.
2052         (ascending_option_def, qcs_flag_option_def)
2053         (thr_qcs_flags_option_defs)
2054         (make_thread_apply_all_options_def_group)
2055         (make_thread_apply_options_def_group): New.
2056         (thread_apply_all_command): Use gdb::option::process_options.
2057         (thread_apply_command_completer)
2058         (thread_apply_all_command_completer): New.
2059         (thread_apply_command): Use gdb::option::process_options.
2060         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2061         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2062         to generate help text of "thread apply".  Adjust "taas"'s help.
2063         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2064         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2065
2066 2019-06-13  Pedro Alves  <palves@redhat.com>
2067
2068         * thread.c (thread_apply_command): Check for invalid TID with
2069         isdigit instead of !isalpha.
2070
2071 2019-06-13  Pedro Alves  <palves@redhat.com>
2072
2073         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2074         (validate_flags_qcs): New.
2075         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2076         (validate_flags_qcs): Declare.
2077         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2078         (make_frame_apply_options_def_group): New.
2079         (frame_apply_command_count): Process options with
2080         gdb::option::process_options.
2081         (frame_apply_completer): New.
2082         (frame_apply_level_completer, frame_apply_all_completer)
2083         (frame_apply_completer): New.
2084         (_initialize_stack): Update help of "frame apply", "frame apply
2085         level", "frame apply all" and "faas" to mention supported options
2086         and install command completers.
2087         * stack.h (frame_apply_all_completer): Declare.
2088         * thread.c: Include "stack.h".
2089         (tfaas_command): Add "--".
2090         (_initialize_thread): Update help "tfaas" to mention supported
2091         options and install command completer.
2092
2093 2019-06-13  Pedro Alves  <palves@redhat.com>
2094
2095         * completer.c (complete_nested_command_line): New.
2096         (gdb_completion_word_break_characters_throw): Add assertion.
2097         * completer.h (complete_nested_command_line): Declare.
2098
2099 2019-06-13  Pedro Alves  <palves@redhat.com>
2100
2101         * stack.c (parse_backtrace_qualifiers): New.
2102         (backtrace_command): Use it.
2103         (backtrace_command_completer): Complete on qualifiers.
2104
2105 2019-06-13  Pedro Alves  <palves@redhat.com>
2106
2107         * frame.c: Include "cli/cli-option.h.
2108         (user_set_backtrace_options): New.
2109         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2110         Delete.
2111         (get_prev_frame): Adjust.
2112         (boolean_option_def, uinteger_option_def)
2113         (set_backtrace_option_defs): New.
2114         (_initialize_frame): Adjust and use
2115         gdb::option::add_setshow_cmds_for_options to install "set
2116         backtrace past-main" and "set backtrace past-entry".
2117         * frame.h: Include "cli/cli-option.h".
2118         (struct frame_print_options): Forward declare.
2119         (print_frame_arguments_all, print_frame_arguments_scalars)
2120         (print_frame_arguments_none): Declare.
2121         (print_entry_values): Delete declaration.
2122         (struct frame_print_options, user_frame_print_options): New.
2123         (struct set_backtrace_options): New.
2124         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2125         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2126         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2127         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2128         (list_args_or_locals): Add frame_print_options parameter.
2129         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2130         * python/py-framefilter.c (enumerate_args): Pass down
2131         USER_FRAME_PRINT_OPTIONS.
2132         * stack.c: Include "cli/cli-option.h".
2133         (print_frame_arguments_all, print_frame_arguments_scalars)
2134         (print_frame_arguments_none): Declare.
2135         (print_raw_frame_arguments, print_entry_values): Delete.
2136         (user_frame_print_options): New.
2137         (boolean_option_def, enum_option_def, frame_print_option_defs):
2138         New.
2139         (struct backtrace_cmd_options): New.
2140         (bt_flag_option_def): New.
2141         (backtrace_command_option_defs): New.
2142         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2143         (print_frame_arg, read_frame_arg, print_frame_args)
2144         (print_frame_info, print_frame): Add frame_print_options parameter
2145         and use it.
2146         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2147         (backtrace_command_1): Add frame_print_options and
2148         backtrace_cmd_options parameters and use them.
2149         (make_backtrace_options_def_group): New.
2150         (backtrace_command): Process command options with
2151         gdb::option::process_options.
2152         (backtrace_command_completer): New.
2153         (_initialize_stack): Extend "backtrace"'s help to mention
2154         supported options.  Install completer for "backtrace".
2155         Install some settings commands with add_setshow_cmds_for_options.
2156
2157 2019-06-13  Pedro Alves  <palves@redhat.com>
2158
2159         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2160         and that "set/show print raw frame-arguments" are now deprecated.
2161
2162         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2163         command.
2164         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2165         * stack.c (_initialize_stack): Install "set/show print
2166         raw-frame-arguments", and deprecate "set/show print raw
2167         frame-arguments".
2168         * valprint.c (_initialize_valprint): Deprecate "set/show print
2169         raw".
2170
2171 2019-06-13  Pedro Alves  <palves@redhat.com>
2172
2173         * compile/compile.c (struct compile_options): New.
2174         (compile_flag_option_def, compile_command_option_defs)
2175         (make_compile_options_def_group): New.
2176         (compile_file_command): Handle options with
2177         gdb::option::process_options.
2178         (compile_file_command_completer): New function.
2179         (compile_code_command): Handle options with
2180         gdb::option::process_options.
2181         (compile_code_command_completer): New function.
2182         (_initialize_compiler): Install completers for "compile code" and
2183         "compile file".  Mention available options in "compile code" and
2184         "compile code"'s help.
2185         * completer.c (advance_to_completion_word): New, factored out from
2186         ...
2187         (advance_to_expression_complete_word_point): ... this.
2188         (advance_to_filename_complete_word_point): New.
2189         * completer.h (advance_to_filename_complete_word_point): New
2190         declaration.
2191
2192 2019-06-13  Pedro Alves  <palves@redhat.com>
2193
2194         * compile/compile.c: Include "cli/cli-option.h".
2195         (compile_print_value): Scope data pointer is now a
2196         value_print_options pointer; adjust.
2197         (compile_print_command): Process options.  Scope data pointer is
2198         now a value_print_options pointer; adjust.
2199         (_initialize_compile): Update "compile print"'s help to include
2200         supported options.  Install a completer for "compile print".
2201         * cp-valprint.c (show_vtblprint, show_objectprint)
2202         (show_static_field_print): Delete.
2203         (_initialize_cp_valprint): Don't install "set print
2204         static-members", "set print vtbl", "set print object" here.
2205         * printcmd.c: Include "cli/cli-option.h" and
2206         "common/gdb_optional.h".
2207         (print_command_parse_format): Rework to fill in a
2208         value_print_options instead of a format_data.
2209         (print_value): Change parameter type from format_data pointer to
2210         value_print_options reference.  Adjust.
2211         (print_command_1): Process options.  Adjust to pass down a
2212         value_print_options.
2213         (print_command_completer): New.
2214         (_initialize_printcmd): Install print_command_completer as
2215         handle_brkchars completer for the "print" command.  Update
2216         "print"'s help to include supported options.
2217         * valprint.c: Include "cli/cli-option.h".
2218         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2219         here from cp-valprint.c.
2220         (boolean_option_def, uinteger_option_def)
2221         (value_print_option_defs, make_value_print_options_def_group):
2222         New.  Use gdb::option::add_setshow_cmds_for_options to install
2223         "set print elements", "set print null-stop", "set print repeats",
2224         "set print pretty", "set print union", "set print array", "set
2225         print address", "set print symbol", "set print array-indexes".
2226         * valprint.h: Include <string> and "cli/cli-option.h".
2227         (make_value_print_options_def_group): Declare.
2228         (print_value): Change parameter type from format_data pointer to
2229         value_print_options reference.
2230         (print_command_completer): Declare.
2231
2232 2019-06-13  Pedro Alves  <palves@redhat.com>
2233
2234         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2235         (COMMON_SFILES): Add maint-test-settings.c.
2236         * cli/cli-decode.c (boolean_enums): New global, factored out from
2237         ...
2238         (add_setshow_boolean_cmd): ... here.
2239         * cli/cli-decode.h (boolean_enums): Declare.
2240         * cli/cli-option.c: New file.
2241         * cli/cli-option.h: New file.
2242         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2243         factored out from ...
2244         (parse_cli_boolean_value(const char *)): ... this.
2245         (is_unlimited_literal): Change parameter type to pointer to
2246         pointer.  Adjust and advance ARG pointer.
2247         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2248         (parse_cli_var_enum): New, factored out from ...
2249         (do_set_command): ... this.  Adjust.
2250         * cli/cli-setshow.h (parse_cli_boolean_value)
2251         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2252         (parse_cli_var_enum): Declare.
2253         * cli/cli-utils.c: Include "cli/cli-option.h".
2254         (get_ulongest): New.
2255         * cli/cli-utils.h (get_ulongest): Declare.
2256         (check_for_argument): New overloads.
2257         * maint-test-options.c: New file.
2258
2259 2019-06-13  Pedro Alves  <palves@redhat.com>
2260
2261         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2262         parse a range if "-" is at the end of the string.
2263
2264 2019-06-13  Pedro Alves  <palves@redhat.com>
2265
2266         * cli/cli-setshow.c (parse_auto_binary_operation)
2267         (parse_cli_boolean_value): Don't allow "o".
2268
2269 2019-06-13  Pedro Alves  <palves@redhat.com>
2270
2271         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2272         * NEWS: Mention maint test-settings KIND.
2273         * maint-test-settings.c: New file.
2274
2275 2019-06-13  Pedro Alves  <palves@redhat.com>
2276
2277         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2278         completer.
2279         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2280         "set" completers.
2281
2282 2019-06-13  Pedro Alves  <palves@redhat.com>
2283
2284         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2285         after item.
2286
2287 2019-06-13  Pedro Alves  <palves@redhat.com>
2288
2289         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2290
2291 2019-06-13  Pedro Alves <palves@redhat.com>
2292
2293         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2294         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2295         call.
2296         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2297         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2298         calls.
2299         (check_for_argument): Skip spaces after argument.
2300
2301 2019-06-13  Pedro Alves  <palves@redhat.com>
2302
2303         * thread.c (thread_apply_command): Adjust TID parsing.
2304         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2305         detected before end of string.
2306         (tid_is_in_list): Error out if LIST is invalid.
2307
2308 2019-06-13  Pedro Alves  <palves@redhat.com>
2309
2310         * completer.c (complete_line_internal_1): Rewind completion word
2311         point.
2312         (completion_tracker::advance_custom_word_point_by): Change
2313         parameter type to int.
2314         * completer.h (completion_tracker::advance_custom_word_point_by):
2315         Likewise.
2316
2317 2019-06-13  Pedro Alves  <palves@redhat.com>
2318
2319         * completer.c (advance_to_completion_word): Handle delimiters.
2320
2321 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2322
2323         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2324
2325 2019-06-11  Tom Tromey  <tom@tromey.com>
2326
2327         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2328         (xmalloc_failed): Move to alloc.c.
2329         * alloc.c: New file.
2330         * Makefile.in (COMMON_SFILES): Add alloc.c.
2331
2332 2019-06-11  Tom Tromey  <tom@tromey.com>
2333
2334         * nat/linux-waitpid.c: Don't include server.h.
2335         (linux_debug): Remove.
2336         (my_waitpid): Update.
2337
2338 2019-06-11  Tom Tromey  <tromey@adacore.com>
2339
2340         * infcall.c (_initialize_infcall): Remove trailing newline from
2341         help.
2342         * user-regs.c (_initialize_user_regs): Remove trailing newline
2343         from help.
2344         * typeprint.c (_initialize_typeprint): Remove trailing newline
2345         from help.
2346         * reverse.c (_initialize_reverse): Remove trailing newlines from
2347         help.
2348         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2349         from help.
2350         * language.c (add_set_language_command): Remove trailing newline
2351         from help.
2352         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2353         help.
2354         * disasm.c (_initialize_disasm): Remove trailing newline from
2355         help.
2356         * top.c (init_main): Remove trailing newline from help.
2357         * interps.c (_initialize_interpreter): Remove trailing newline
2358         from help.
2359         * btrace.c (_initialize_btrace): Remove trailing newlines from
2360         help.
2361         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2362         from help.
2363         * python/python.c (_initialize_python): Remove trailing newline
2364         from help.
2365         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2366         help.
2367         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2368         from help.  Reformat some text.
2369         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2370         from help.
2371         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2372         newline from help.
2373
2374 2019-06-11  Tom Tromey  <tromey@adacore.com>
2375
2376         * darwin-nat.c (darwin_decode_exception_message)
2377         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2378
2379 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2380
2381         * valops.c (value_slice): Check for not allocated or not
2382         associated values.
2383
2384 2019-06-10  Tom de Vries  <tdevries@suse.de>
2385
2386         PR gdb/24618
2387         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2388         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2389         invalid.
2390
2391 2019-06-10  Tom de Vries  <tdevries@suse.de>
2392
2393         PR gdb/24611
2394         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2395         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2396
2397 2019-06-10  Tom de Vries  <tdevries@suse.de>
2398
2399         PR symtab/24545
2400         * symtab.c (struct demangled_name_entry): Add language field.
2401         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2402         static minimal symbol".  Set and use language field.
2403
2404 2019-06-10  Tom Tromey  <tromey@adacore.com>
2405
2406         * ada-lang.c (_initialize_ada_language): Update help text.
2407
2408 2019-06-10  Tom Tromey  <tromey@adacore.com>
2409
2410         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2411         with a newline.
2412         * guile/guile.c (handle_boot_error): Don't end warning with a
2413         newline.
2414         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2415         warning with a newline.
2416         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2417         newline.
2418         (s12z_frame_cache): Likewise.
2419         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2420         a newline.
2421         * solib-svr4.c (disable_probes_interface): Don't end warning with
2422         a newline.
2423         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2424         newline.
2425         * python/python.c (do_finish_initialization): Don't end warning
2426         with a newline.
2427
2428 2019-06-10  Tom Tromey  <tom@tromey.com>
2429
2430         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2431         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2432         gdbpy_enter.
2433
2434 2019-06-10  Tom Tromey  <tromey@adacore.com>
2435
2436         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2437         data.
2438         (elf_new_init): Don't call stabsread_new_init.
2439         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2440         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2441         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2442
2443 2019-06-10  Tom de Vries  <tdevries@suse.de>
2444
2445         PR symtab/16264
2446         PR symtab/24517
2447         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2448
2449 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2450
2451         * source.c (find_and_open_source): Also rewrite relative file
2452         names.
2453
2454 2019-04-26  Amos Bird  <amosbird@gmail.com>
2455
2456         * annotate.c (annotate_thread_exited): Add "thread-exited"
2457         annotation.
2458
2459 2019-06-06  Tom Tromey  <tromey@adacore.com>
2460
2461         * maint.h (class scoped_command_stats): Use
2462         DISABLE_COPY_AND_ASSIGN.
2463         <print_time>: New method.
2464         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2465         print_time.
2466         (scoped_command_stats::print_time): New method.
2467
2468 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2471         instructions of lengths 6 or 8 bytes.
2472
2473 2019-06-04  Pedro Alves  <palves@redhat.com>
2474
2475         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2476
2477         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2478         * breakpoint.c (condition_completer): Likewise.
2479         * cli/cli-dump.c (scan_expression): Likewise.
2480         * common/filestuff.c (mkdir_recursive): Likewise.
2481         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2482         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2483         (gdb_abspath): Likewise.
2484         * compile/compile-cplus-types.c
2485         (compile_cplus_instance::decl_name): Likewise.
2486         * completer.c (complete_explicit_location):
2487         (signal_completer, reg_or_group_completer_1): Likewise.
2488         * cp-support.c (cp_remove_params_if_any): Likewise.
2489         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2490         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2491         * infcmd.c (strip_bg_char): Likewise.
2492         * linespec.c (copy_token_string): Likewise.
2493         * mi/mi-main.c (output_cores): Likewise.
2494         * psymtab.c (psymtab_search_name):
2495         * symfile.c (test_set_ext_lang_command): Likewise.
2496         * target.c (target_fileio_read_stralloc): Likewise.
2497         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2498         * value.c (complete_internalvar): Likewise.
2499
2500 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2501
2502         Add objfile property to gdb.Type.
2503         * NEWS: Mention Python API addition.
2504         * python/py-type.c (typy_get_objfile): New method.
2505
2506 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2507
2508         * NEWS: Mention the new set|show style [title|highlight].
2509         Mention changes to "show style", "help" and "apropos".
2510
2511 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2512
2513         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2514         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2515         instead of print_help_for_command.
2516         (print_doc_of_command): New function.
2517         (help_list): Add 'apropos -v word' suggestion.
2518         (print_help_for_command): Style the command name using title style.
2519         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2520         (_initialize_cli_cmds): Describe -v in apropos_command help.
2521
2522 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2523
2524         * cli/cli-style.h (cli_style_option): Add name in constructor,
2525         add m_name class member, add constructor with intensity,
2526         add name class function.
2527         (cli_style_option::add_setshow_commands): Remove name argument.
2528         (highlight_style, title_style): New styles.
2529         * cli/cli-style.c (do_show): New function that shows a style
2530         characteristic styling the style name with itself.
2531         (set_style_name): New function.
2532         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2533         Update all callers according to the changes in cli/cli-style.h.
2534         * utils.h (fputs_highlighted): New function.
2535         * utils.c (fputs_highlighted): Likewise.
2536
2537 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2538
2539         * NEWS: Mention new pipe command and new convenience variables.
2540
2541 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2542
2543         * cli/cli-cmds.c (pipe_command): New function.
2544         (_initialize_cli_cmds): Call add_com for pipe_command.
2545         Define | as an alias for pipe.
2546         (exit_status_set_internal_vars): New function.
2547         (shell_escape): Call exit_status_set_internal_vars.
2548         cli/cli-decode.c (find_command_name_length): Recognize | as
2549         a single character command.
2550
2551 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2552
2553         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2554         top.c (execute_command_to_ui_file): New function, mostly a copy
2555         of execute_command_to_string.
2556         (execute_command_to_string): Implement by calling
2557         execute_command_to_ui_file.
2558
2559 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2560
2561         * top.h (saved_command_line): Remove declaration.
2562         * top.c (previous_saved_command_line, previous_repeat_arguments):
2563         New variables.
2564         (saved_command_line): Make static, define together with other
2565         'repeat variables'.
2566         (dont_repeat): Clear repeat_arguments.
2567         (repeat_previous, get_saved_command_line, save_command_line):
2568         New functions.
2569         (gdb_init): Initialize saved_command_line
2570         and previous_saved_command_line.
2571         * main.c (captured_main_1): Remove saved_command_line initialization.
2572         * event-top.c (handle_line_of_input): Update to use
2573         the new 'repeat' related functions instead of direct access to
2574         saved_command_line.
2575         * command.h (repeat_previous, get_saved_command_line,
2576         save_command_line): New declarations.
2577         (dont_repeat): Add comment.
2578
2579 2019-05-30  Tom Tromey  <tromey@adacore.com>
2580
2581         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2582         Fix comment.
2583         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2584
2585 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2586
2587         PR cli/24587
2588         * completer.c (complete): Initialize variable word.
2589
2590 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2591
2592         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2593         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2594         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2595         'body' is NULL to the outter 'if', protecting the '!is_define'
2596         situation as well.
2597
2598 2019-05-29  Tom Tromey  <tromey@adacore.com>
2599
2600         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2601         (dwarf_unknown): New function.
2602         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2603         (dwarf_type_encoding_name): Use dwarf_unknown.
2604
2605 2019-05-29  Tom Tromey  <tromey@adacore.com>
2606
2607         PR c++/20020:
2608         * cp-valprint.c (cp_print_value_fields): Call
2609         cp_print_static_field inside "try".
2610
2611 2019-05-29  Tom Tromey  <tromey@adacore.com>
2612
2613         * inflow.c (struct terminal_info): Add default operator=.
2614         * configure: Rebuild.
2615         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2616         -Wdeprecated-copy-dtor, -Wredundant-move.
2617
2618 2019-05-29  Tom Tromey  <tromey@adacore.com>
2619
2620         * NEWS: Add entry.
2621         * infcmd.c (print_return_value_1): Handle finish_print
2622         option.
2623         (show_print_finish): New function.
2624         (_initialize_infcmd): Add "set/show print finish" commands.
2625         * valprint.c (user_print_options): Initialize new member.
2626         * valprint.h (struct value_print_options) <finish_print>: New
2627         member.
2628
2629 2019-05-28  Tom Tromey  <tromey@adacore.com>
2630
2631         * ada-lang.c (ada_remove_Xbn_suffix)
2632         (find_old_style_renaming_symbol)
2633         (parse_old_style_renaming): Remove.
2634         (ada_find_renaming_symbol): Don't call
2635         find_old_style_renaming_symbol.
2636         (ada_is_renaming_symbol): Rename from
2637         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2638         bool.  Now static.
2639         (ada_read_var_value): Update and simplify.
2640         * ada-exp.y (write_var_or_type): Remove old code.
2641
2642 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2643
2644         * event-top.c: Remove include comment.
2645         * inflow.c (class scoped_ignore_sigttou): Move from here...
2646         * inflow.h (class scoped_ignore_sigttou): ...to here.
2647         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2648         * top.c:  Remove include comment.
2649
2650 2019-05-27  Tom Tromey  <tom@tromey.com>
2651
2652         * NEWS: Fix typo.
2653
2654 2019-05-22  Tom Tromey  <tromey@adacore.com>
2655
2656         * target.c (target_follow_exec): Constify parameter.
2657         * target-delegates.c: Rebuild.
2658         * remote.c (remote_target::follow_exec): Constify parameter.
2659         * infrun.c (follow_exec): Constify parameter.
2660         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2661         (target_follow_exec): Likewise.
2662
2663 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2664
2665         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2666         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2667
2668 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2669
2670         * NEWS: Add debugredirect and testsuite sections.
2671
2672 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2673
2674         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2675         target descriptions using exclusively floating point register name
2676         aliases.
2677
2678 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         PR gdb/18644:
2681         * f-lang.c (build_fortran_types): Handle the case where
2682         gdbarch_floatformat_for_type returns a nullptr.
2683
2684 2019-05-21  Tom de Vries  <tdevries@suse.de>
2685
2686         PR cli/24587
2687         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2688
2689 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         PR gdb/18644:
2692         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2693         16-byte floats.
2694         * i386-tdep.c (i386_floatformat_for_type): Use
2695         floatformats_ia64_quad for the 16-byte floating point component
2696         within a fortran 32-byte complex number.
2697
2698 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2701         delete default constructor.
2702         (find_partial_die): Update to return const struct.
2703         (partial_die_parent_scope): Move variable declaration into scope
2704         of its use and change its type to auto.
2705         (guess_partial_die_structure_name): Likewise.
2706         (partial_die_info::fixup): Likewise.
2707
2708 2019-05-17  Tom Tromey  <tromey@adacore.com>
2709
2710         * source.c (find_and_open_source): Remove cast.
2711
2712 2019-05-17  Tom Tromey  <tromey@adacore.com>
2713
2714         * annotate.c (annotate_source): Make "filename" const.
2715         * annotate.h (annotate_source): Use const.
2716
2717 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2718
2719         * disasm.c (set_disassembler_options): Send errors to stderr.
2720
2721 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2722
2723         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2724         (cli_interp_base::set_logging): Check debug_redirect.
2725         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2726         * cli/cli-logging.c (debug_redirect): Add static variable.
2727         (pop_output_files): Add default param.
2728         (handle_redirections): Print debug setting.
2729         (show_logging_command): Likewise.
2730         (_initialize_cli_logging): Add debugredirect command.
2731         * interps.c (current_interp_set_logging): Add debug_redirect
2732         parameter.
2733         * interps.h (set_logging): Add debug_redirect parameter.
2734         (current_interp_set_logging): Likewise.
2735         * mi/mi-common.h: Likewise.
2736         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2737
2738 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2739             Tom Tromey  <tromey@adacore.com>
2740
2741         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2742         directly.
2743         * cli/cli-interp.h (make_logging_output): Remove declaration.
2744         * cli/cli-logging.c (make_logging_output): Remove function.
2745         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2746         directly.
2747         * ui-file.c (tee_file::tee_file): Remove bools.
2748         (tee_file::~tee_file): Remove deletes.
2749         * ui-file.h (tee_file): Remove bools.
2750
2751 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2752
2753         * mi/mi-cmds.h (mi_cmd_complete): New function.
2754         * mi/mi-main.c (mi_cmd_complete): Likewise.
2755         * mi/mi-cmds.c: Define new MI command -complete.
2756         * NEWS: Mention new -complete command.
2757
2758 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2759
2760         * completer.h (complete): New function.
2761         * completer.c (complete): Likewise.
2762         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2763         function defined in completer.h.
2764
2765 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2766
2767         * MAINTAINERS (Write After Approval): Add myself.
2768
2769 2019-05-17  Tom de Vries  <tdevries@suse.de>
2770
2771         PR gdb/24094
2772         * dwarf2read.c (struct cu_partial_die_info): New struct.
2773         (find_partial_die): Return cu_partial_die_info.
2774         (partial_die_parent_scope, guess_partial_die_structure_name)
2775         (partial_die_info::fixup): Handle new return type of find_partial_die.
2776
2777 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2778
2779         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2780         "std::string", simplifying the algorithm.
2781
2782 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2783
2784         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2785         (stap_static_probe_ops::get_probes): Likewise.
2786
2787 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2788
2789         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2790         '-')" and "else if".
2791         (stap_parse_single_operand): Join checks for
2792         "gdbarch_stap_parse_special_token_p" and
2793         "gdbarch_stap_parse_special_token" in the same "if" statement.
2794         Invert check when verifying for operation on register
2795         displacement.
2796
2797 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2798
2799         * stap-probe.c (stap_get_opcode): Update comment.
2800         (stap_get_expected_argument_type): Likewise.
2801         (handle_stap_probe): Likewise.
2802
2803 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2804
2805         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2806         return type to 'bool'.  Adjust comment.  Use 'bool' when
2807         appropriate.
2808         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2809         * stap-probe.c (stap_parse_argument_1): Likewise.
2810         (stap_is_operator): Likewise.
2811         (stap_is_generic_prefix): Likewise.
2812         (stap_is_register_prefix): Likewise.
2813         (stap_is_register_indirection_prefix): Likewise.
2814         (stap_is_integer_prefix): Likewise.
2815         (stap_generic_check_suffix): Likewise.
2816         (stap_check_integer_suffix): Likewise.
2817         (stap_check_register_suffix): Likewise.
2818         (stap_check_register_indirection_suffix): Likewise.
2819         (stap_parse_register_operand): Likewise.
2820         (stap_parse_single_operand): Likewise.
2821         (stap_parse_argument_1): Likewise.
2822         (stap_probe::get_argument_count): Likewise.
2823         (stap_is_operator): Likewise.
2824
2825 2019-05-16  Tom Tromey  <tromey@adacore.com>
2826
2827         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2828         keyword to foreach.
2829
2830 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2831
2832         * linux-thread-db.c (try_thread_db_load_1): Change return type
2833         to bool.
2834         (try_thread_db_load): Likewise.
2835         (try_thread_db_load_from_pdir_1): Likewise.
2836         (try_thread_db_load_from_pdir): Likewise.
2837         (try_thread_db_load_from_sdir): Likewise.
2838         (try_thread_db_load_from_dir): Likewise.
2839         (thread_db_load_search): Likewise.
2840         (has_libpthread): Likewise.
2841         (thread_db_load): Likewise.
2842
2843 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2844
2845         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2846         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2847         NULL, and complain/return if that's the case.
2848
2849 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2850
2851         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2852         (advance, posn, abstract_read_memory): New functions.
2853         [struct mem_read_abstraction]: New struct.
2854         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2855
2856 2019-05-14  Tom Tromey  <tromey@adacore.com>
2857
2858         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2859         value is not lval_memory.
2860
2861 2019-05-14  Tom Tromey  <tromey@adacore.com>
2862
2863         * solib.c (info_sharedlibrary_command): Style the file name.
2864
2865 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2866
2867         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2868         (aarch64_vnv_type): Likewise.
2869         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2870         * common/tdesc.c: Likewise.
2871         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2872         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2873         * features/aarch64-fpu.xml: Add ieee half view.
2874         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2875         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2876         * gdbtypes.h (struct builtin_type): Likewise.
2877         (struct objfile_type): Likewise.
2878
2879 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2880
2881         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2882         typo.
2883         * location.h (string_to_event_location): Likewise.
2884
2885 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2886
2887         GDB 8.3 released.
2888
2889 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2890
2891         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2892         New variable declaration.
2893         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2894         New variable.
2895         (print_one_breakpoint): Use ui_out::test_flags and new global
2896         variable to compute use_fixed_output.
2897         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2898         Remove.
2899         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2900         (mi_multi_location_breakpoint_output_fixed): Remove.
2901         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2902         new variable.
2903         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2904         fix_multi_location_breakpoint_output flag if version >= 3.
2905         * ui-out.h (enum ui_out_flag)
2906         <fix_multi_location_breakpoint_output>: New enumerator.
2907
2908 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2909
2910         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2911
2912 2019-05-10  Tom Tromey  <tromey@adacore.com>
2913
2914         * ada-lang.c (catch_ada_completer): New function.
2915         (_initialize_ada_language): Use it.
2916
2917 2019-05-10  Tom Tromey  <tromey@adacore.com>
2918
2919         * thread.c (print_thread_info): Make "requested_threads" const.
2920         * gdbthread.h (print_thread_info): Make "requested_threads"
2921         const.
2922         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2923         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2924
2925 2019-05-08  Tom Tromey  <tom@tromey.com>
2926
2927         * gdbtypes.c (objfile_type_data): Change type.
2928         (objfile_type, _initialize_gdbtypes): Update.
2929
2930 2019-05-08  Tom Tromey  <tom@tromey.com>
2931
2932         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2933         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2934         (_initialize_dwarf2_frame): Update.
2935
2936 2019-05-08  Tom Tromey  <tom@tromey.com>
2937
2938         * objc-lang.c (objc_objfile_data): Change type.
2939         (find_methods): Update.
2940         (_initialize_objc_lang): Remove.
2941
2942 2019-05-08  Tom Tromey  <tom@tromey.com>
2943
2944         * stabsread.c (rs6000_builtin_type_data): Change type.
2945         (rs6000_builtin_type, _initialize_stabsread): Update.
2946
2947 2019-05-08  Tom Tromey  <tom@tromey.com>
2948
2949         * mips-tdep.c (mips_pdr_data): Remove.
2950         (_initialize_mips_tdep): Update.
2951
2952 2019-05-08  Tom Tromey  <tom@tromey.com>
2953
2954         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2955         (hppa_init_objfile_priv_data, read_unwind_info)
2956         (find_unwind_entry, _initialize_hppa_tdep): Update.
2957
2958 2019-05-08  Tom Tromey  <tom@tromey.com>
2959
2960         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2961         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2962         on obstack.
2963         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2964
2965 2019-05-08  Tom Tromey  <tom@tromey.com>
2966
2967         * mdebugread.c (basic_type_data): Change type.
2968         (basic_type, _initialize_mdebugread): Update.
2969
2970 2019-05-08  Tom Tromey  <tom@tromey.com>
2971
2972         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2973
2974 2019-05-08  Tom Tromey  <tom@tromey.com>
2975
2976         * nto-tdep.c (nto_inferior_data_reg): Change type.
2977         (nto_inferior_data): Update.
2978         (nto_inferior_data_cleanup, nto_new_inferior_data)
2979         (_initialize_nto_tdep): Remove.
2980         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2981
2982 2019-05-08  Tom Tromey  <tom@tromey.com>
2983
2984         * ada-lang.c (struct ada_inferior_data): Add initializers.
2985         (ada_inferior_data): Change type.
2986         (ada_inferior_data_cleanup): Remove.
2987         (get_ada_inferior_data, ada_inferior_exit)
2988         (struct ada_pspace_data): Add initializers, destructor.
2989         (ada_pspace_data_handle): Change type.
2990         (get_ada_pspace_data): Update.
2991         (ada_pspace_data_cleanup): Remove.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * coffread.c (struct coff_symfile_info): Add initializers.
2996         (coff_objfile_data_key): Move lower.  Change type.
2997         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2998         Update.
2999         (coff_free_info): Remove.
3000
3001 2019-05-08  Tom Tromey  <tom@tromey.com>
3002
3003         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3004         (fbsd_pspace_data_handle): Move lower.  Change type.
3005         (get_fbsd_pspace_data): Update.
3006         (fbsd_pspace_data_cleanup): Remove.
3007         (_initialize_fbsd_tdep): Update.
3008
3009 2019-05-08  Tom Tromey  <tom@tromey.com>
3010
3011         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3012         (get_ada_tasks_pspace_data): Update.
3013         (ada_tasks_pspace_data_cleanup): Remove.
3014         (_initialize_tasks): Update.
3015         (ada_tasks_inferior_data_handle): Change type.
3016         (get_ada_tasks_inferior_data): Update.
3017         (ada_tasks_inferior_data_cleanup): Remove.
3018         (struct ada_tasks_pspace_data): Add initializers.
3019
3020 2019-05-08  Tom Tromey  <tom@tromey.com>
3021
3022         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3023         * symfile-debug.c (debug_sym_get_probes): Change type.
3024         * stap-probe.c (handle_stap_probe):
3025         (stap_static_probe_ops::get_probes): Change type.
3026         * probe.h (class static_probe_ops) <get_probes>: Change type.
3027         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3028         (parse_probes_in_pspace): Update.
3029         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3030         Update.
3031         (any_static_probe_ops::get_probes): Change type.
3032         * elfread.c (elfread_data): New typedef.
3033         (probe_key): Change type.
3034         (elf_get_probes): Likewise.  Update.
3035         (probe_key_free): Remove.
3036         (_initialize_elfread): Update.
3037         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3038         Change type.
3039         (dtrace_process_dof_probe, dtrace_process_dof)
3040         (dtrace_static_probe_ops::get_probe): Change type.
3041
3042 2019-05-08  Tom Tromey  <tom@tromey.com>
3043
3044         * xcoffread.c (struct xcoff_symfile_info): Rename from
3045         coff_symfile_info.  Add initializers.
3046         (xcoff_objfile_data_key): Move lower.  Change type.
3047         (XCOFF_DATA): Rewrite.
3048         (xcoff_free_info): Remove.
3049         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3050         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3051         (xcoff_initial_scan): Update.
3052
3053 2019-05-08  Tom Tromey  <tom@tromey.com>
3054
3055         * solib-svr4.c (struct svr4_info): Add initializers and
3056         destructor.
3057         <probes_table>: Now an htab_up.
3058         (solib_svr4_pspace_data): Change type.
3059         (free_probes_table): Simplify.
3060         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3061         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3062         (probes_table_remove_objfile_probes, register_solib_event_probe)
3063         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3064         (_initialize_svr4_solib): Update.
3065
3066 2019-05-08  Tom Tromey  <tom@tromey.com>
3067
3068         * remote.c (remote_pspace_data): Change type.
3069         (remote_pspace_data_cleanup): Remove.
3070         (get_remote_exec_file, set_pspace_remote_exec_file)
3071         (_initialize_remote): Update.
3072
3073 2019-05-08  Tom Tromey  <tom@tromey.com>
3074
3075         * breakpoint.c (breakpoint_objfile_key): Change type.
3076         (get_breakpoint_objfile_data): Update.
3077         (free_breakpoint_objfile_data): Remove.
3078         (_initialize_breakpoint): Update.
3079
3080 2019-05-08  Tom Tromey  <tom@tromey.com>
3081
3082         * linux-tdep.c (struct linux_info): Add initializers.
3083         (linux_inferior_data): Move.  Change type.
3084         (invalidate_linux_cache_inf): Update.
3085         (linux_inferior_data_cleanup): Remove.
3086         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3087
3088 2019-05-08  Tom Tromey  <tom@tromey.com>
3089
3090         * auxv.c (auxv_inferior_data): Move.  Change type.
3091         (auxv_inferior_data_cleanup): Remove.
3092         (invalidate_auxv_cache_inf): Rewrite.
3093         (get_auxv_inferior_data, _initialize_auxv): Update.
3094
3095 2019-05-08  Tom Tromey  <tom@tromey.com>
3096
3097         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3098         (symfile_debug_objfile_data_key): Change type.
3099         (symfile_debug_installed, debug_qf_has_symbols)
3100         (debug_qf_find_last_source_symtab)
3101         (debug_qf_forget_cached_source_info)
3102         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3103         (debug_qf_print_stats, debug_qf_dump)
3104         (debug_qf_expand_symtabs_for_function)
3105         (debug_qf_expand_all_symtabs)
3106         (debug_qf_expand_symtabs_with_fullname)
3107         (debug_qf_map_matching_symbols)
3108         (debug_qf_expand_symtabs_matching)
3109         (debug_qf_find_pc_sect_compunit_symtab)
3110         (debug_qf_map_symbol_filenames)
3111         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3112         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3113         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3114         (debug_sym_read_linetable, debug_sym_relocate): Update.
3115         (symfile_debug_free_objfile): Remove.
3116         (install_symfile_debug_logging, _initialize_symfile_debug):
3117         Update.
3118
3119 2019-05-08  Tom Tromey  <tom@tromey.com>
3120
3121         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3122         allocate_on_obstack.
3123         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3124         (get_dwarf2_per_objfile): Update.
3125         (set_dwarf2_per_objfile): Remove.
3126         (dwarf2_has_info, dwarf2_get_section_info): Update.
3127         (dwarf2_free_objfile): Remove.
3128         (_initialize_dwarf2_read): Update.
3129
3130 2019-05-08  Tom Tromey  <tom@tromey.com>
3131
3132         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3133         initializers.
3134         <unsupported_script_warning_printed,
3135         script_not_found_warning_printed>: Now bool.
3136         (auto_load_pspace_data): Change type.
3137         (~auto_load_pspace_info): Rename from
3138         auto_load_pspace_data_cleanup.
3139         (get_auto_load_pspace_data, init_loaded_scripts_info)
3140         (clear_section_scripts, maybe_print_unsupported_script_warning)
3141         (maybe_print_script_not_found_warning, _initialize_auto_load):
3142         Update.
3143
3144 2019-05-08  Tom Tromey  <tom@tromey.com>
3145
3146         * objfiles.c (objfile_pspace_info): Add destructor and
3147         initializers.
3148         (objfiles_pspace_data): Change type.
3149         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3150         (get_objfile_pspace_data): Update.
3151         (objfiles_bfd_data): Change type.
3152         (get_objfile_bfd_data): Update.
3153         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3154
3155 2019-05-08  Tom Tromey  <tom@tromey.com>
3156
3157         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3158         Change type.
3159         (get_catch_syscall_inferior_data): Update.
3160         (catch_syscall_inferior_data_cleanup): Remove.
3161         (_initialize_break_catch_syscall): Update.
3162
3163 2019-05-08  Tom Tromey  <tom@tromey.com>
3164
3165         * inflow.c (struct terminal_info): Add destructor and
3166         initializers.
3167         (inflow_inferior_data): Change type.
3168         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3169         (get_inflow_inferior_data, inflow_inferior_exit)
3170         (swap_terminal_info, _initialize_inflow): Update.
3171
3172 2019-05-08  Tom Tromey  <tom@tromey.com>
3173
3174         * target-dcache.c (target_dcache_cleanup): Remove.
3175         (target_dcache_aspace_key): Change type.
3176         (target_dcache_init_p, target_dcache_invalidate)
3177         (target_dcache_get, target_dcache_get_or_init)
3178         (_initialize_target_dcache): Update.
3179         * dcache.h (struct dcache_deleter): New.
3180
3181 2019-05-08  Tom Tromey  <tom@tromey.com>
3182
3183         * symtab.c (struct symbol_cache): Add destructor and
3184         initializers.
3185         (symbol_cache_key): Move.  Change type.
3186         (make_symbol_cache, free_symbol_cache): Remove.
3187         (get_symbol_cache): Update.
3188         (symbol_cache_cleanup): Remove.
3189         (ALL_PSPACES, symbol_cache_flush)
3190         (maintenance_print_symbol_cache)
3191         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3192         Update.
3193
3194 2019-05-08  Tom Tromey  <tom@tromey.com>
3195
3196         * symtab.c (struct main_info): Add destructor and initializers.
3197         (main_progspace_key): Move.  Change type.
3198         (get_main_info): Update.
3199         (main_info_cleanup): Remove.
3200         (_initialize_symtab): Update.
3201
3202 2019-05-08  Tom Tromey  <tom@tromey.com>
3203
3204         * registry.h (DECLARE_REGISTRY): Define the _key class.
3205
3206 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * NEWS: Merge two 'New commands' sections.
3209
3210 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3211
3212         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3213         parameter and use Ada language definition instead.
3214         (ada_val_print_ptr): Remove unused language parameter.
3215         (ada_val_print_num): Remove language parameter and use Ada language
3216         definition instead.
3217         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3218         parameter.
3219         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3220         parameter and use Ada language definition instead.
3221         (ada_val_print_1): Update all ada_val_print_xxx calls.
3222         Remove language parameter.
3223         (ada_val_print): Update ada_val_print_1 call.
3224
3225 2019-05-08  Tom Tromey  <tromey@adacore.com>
3226
3227         * remote.c (remote_hw_watchpoint_limit)
3228         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3229         Now static.
3230
3231 2019-05-08  Tom Tromey  <tromey@adacore.com>
3232
3233         * maint.c (_initialize_maint_cmds): Move initialization code to
3234         remote.c.
3235         (watchdog, show_watchdog): Move to remote.c.
3236         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3237         "watchdog" static.
3238         (_initialize_remote): Move initialization code from maint.c.
3239         * defs.h (watchdog): Don't declare.
3240
3241 2019-05-08  Tom Tromey  <tromey@adacore.com>
3242
3243         * tui/tui-interp.c: Include main.h.
3244         * interps.c: Include main.h.
3245         * main.h (interpreter_p): Declare.
3246         * defs.h (interpreter_p): Don't declare.
3247
3248 2019-05-08  Tom Tromey  <tromey@adacore.com>
3249
3250         * dwarf2loc.c: Include dwarf2read.h.
3251         * defs.h (read_unsigned_leb128): Don't declare.
3252         * dwarf2read.h (read_unsigned_leb128): Declare.
3253
3254 2019-05-08  Tom Tromey  <tromey@adacore.com>
3255
3256         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3257         method.
3258
3259 2019-05-08  Tom Tromey  <tromey@adacore.com>
3260
3261         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3262         when no wrap column is set.
3263
3264 2019-05-08  Tom Tromey  <tromey@adacore.com>
3265
3266         * c-lang.c (c_get_string): Handle non-C-style arrays.
3267
3268 2019-05-08  Tom Tromey  <tromey@adacore.com>
3269
3270         * typeprint.c (print_offset_data::update): Print the bit offset,
3271         not the number of bits remaining.
3272
3273 2019-05-08  Tom Tromey  <tromey@adacore.com>
3274
3275         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3276         padding at end of comment.
3277
3278 2019-05-08  Tom Tromey  <tromey@adacore.com>
3279
3280         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3281         Compare main types.
3282
3283 2019-05-06  Tom Tromey  <tom@tromey.com>
3284
3285         * common/scoped_mmap.c: Include common-defs.h.
3286         * common/scoped_mmap.h: Don't include config.h.
3287
3288 2019-05-04  Tom Tromey  <tom@tromey.com>
3289
3290         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3291         (struct aarch64_call_info): Add initializers.
3292         <si>: Now a std::vector.
3293         (pass_on_stack, aarch64_push_dummy_call): Update.
3294
3295 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3296             Tom Tromey  <tom@tromey.com>
3297
3298         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3299         (ppc_threads): Now a std::vector.  Now static.
3300         (hwdebug_find_thread_points_by_tid)
3301         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3302         Update.
3303
3304 2019-05-04  Tom Tromey  <tom@tromey.com>
3305
3306         * arc-tdep.c (arc_tdesc_init): Return bool.
3307
3308 2019-05-04  Tom Tromey  <tom@tromey.com>
3309
3310         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3311         Use gdb_assert_not_reached.
3312
3313 2019-05-04  Tom Tromey  <tom@tromey.com>
3314
3315         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3316         "false".
3317
3318 2019-05-04  Tom Tromey  <tom@tromey.com>
3319
3320         * arc-tdep.c (arc_tdesc_init): Use bool.
3321
3322 2019-05-04  Tom Tromey  <tom@tromey.com>
3323
3324         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3325
3326 2019-05-04  Tom Tromey  <tom@tromey.com>
3327
3328         * cli/cli-cmds.c (valid_command_p): Return bool.
3329
3330 2019-05-04  Tom Tromey  <tom@tromey.com>
3331
3332         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3333         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3334
3335 2019-05-04  Raul Tambre  <raul@tambre.ee>
3336
3337         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3338         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3339         operator for comparison.
3340
3341 2019-05-04  Tom Tromey  <tom@tromey.com>
3342
3343         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3344         (lookup_partial_symbol, print_partial_symbols)
3345         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3346         (psymbol_compare): Update.
3347         (add_psymbol_to_bcache): Clear the entire psymbol.
3348         (maintenance_check_psymtabs): Update.
3349         * psympriv.h (struct partial_symbol): Don't derive from
3350         general_symbol_info.
3351         <obj_section, unrelocated_address, address,
3352         set_unrelocated_address>: Update.
3353         <ginfo>: New member.
3354         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3355         (debug_names::write_psymbols): Update.
3356
3357 2019-05-04  Tom de Vries  <tdevries@suse.de>
3358
3359         * contrib/cc-with-tweaks.sh: Support -n arg.
3360
3361 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3362
3363         * corelow.c (core_target::detach): Ensure frame cache and
3364         register caches are cleared.
3365         inferior.c (exit_inferior_1): Likewise.
3366
3367 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3368             Tom Tromey  <tom@tromey.com>
3369
3370         * dictionary.c (collate_pending_symbols_by_language): Remove
3371         "struct" from foreach.
3372         * symtab.c (lookup_global_symbol_from_objfile)
3373         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3374         foreach.
3375         * ser-tcp.c (net_open): Remove "struct" from foreach.
3376         * objfiles.c (objfile_relocate, objfile_rebase)
3377         (objfile_has_symbols): Remove "struct" from foreach.
3378         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3379         from foreach.
3380         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3381         foreach.
3382         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3383         "struct" from foreach.
3384         * ada-lang.c (create_excep_cond_exprs)
3385         (ada_exception_catchpoint_cond_string): Remove "struct" from
3386         foreach.
3387
3388 2019-05-03  Tom Tromey  <tromey@adacore.com>
3389
3390         * ada-exp.y (convert_char_literal): Check suffix of each
3391         enumerator.
3392
3393 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3394
3395         PR ada/21406:
3396         * ada-exp.y (yywrap): Don't define.
3397         * ada-lex.l (%option): Add noyywrap
3398         (yywrap): Remove.
3399
3400 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3401
3402         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3403         _WIN32_WINNT to the XP level, unless already defined to a higher
3404         level.
3405
3406         * unittests/parse-connection-spec-selftests.c:
3407         * ser-tcp.c:
3408         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3409         override.
3410
3411         * symfile.c (find_separate_debug_file): Remove colon from the
3412         drive spec of DOS/Windows file names of the target, so that the
3413         file name produced from DEBUGDIR and the target's directory will
3414         be valid on DOS/Windows systems.
3415
3416 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3417
3418         * rust-lang.c (val_print_struct): Handle printing structures
3419         containing strings.
3420
3421 2019-05-02  Tom Tromey  <tromey@adacore.com>
3422
3423         * valarith.c (_initialize_valarith): Remove.
3424
3425 2019-05-01  Tom Tromey  <tromey@adacore.com>
3426
3427         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3428         bitfields.
3429
3430 2019-05-01  Tom Tromey  <tromey@adacore.com>
3431
3432         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3433         for big-endian copies.
3434
3435 2019-04-30  Ali Tamur  <tamur@google.com>
3436         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3437         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3438         (read_3_bytes): New function.
3439
3440 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3441
3442         * windows-nat.c (main_thread_id): Delete.
3443         (handle_output_debug_string): Replace main_thread_id by
3444         current_event.dwThreadId.
3445         (fake_create_process): Likewise.
3446         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3447         Do not set main_thread_id.
3448         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3449         current_event.dwThreadId.
3450         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3451
3452 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3453
3454         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3455         Use current_event.dwThreadId instead of main_thread_id.
3456
3457 2019-04-30  Tom Tromey  <tromey@adacore.com>
3458
3459         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3460         (create_excep_cond_exprs): Iterate over program spaces.
3461         (ada_exception_catchpoint_cond_string): Examine all minimal
3462         symbols for exception types.
3463
3464 2019-04-30  Tom Tromey  <tromey@adacore.com>
3465
3466         PR c++/24470:
3467         * dwarf2read.c (process_structure_scope): Handle case where type
3468         has template parameters but no symbol was created.
3469
3470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3471             Chris January  <chris.january@arm.com>
3472
3473         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3474         qualifier.
3475         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3476
3477 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * f-typeprint.c (f_print_type): Update rules for printing
3480         whitespace.
3481         (f_type_print_varspec_suffix): Likewise.
3482
3483 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3484             Chris January  <chris.january@arm.com>
3485
3486         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3487         function arguments.
3488
3489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3490
3491         * f-lang.c (build_fortran_types): Change name of void type to
3492         lower case.
3493         * f-typeprint.c (f_type_print_base): Print the name of the void
3494         type, rather than a fixed string.
3495         * f-valprint.c (f_decorations): Use lower case void string.
3496
3497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3498             Chris January  <chris.january@arm.com>
3499
3500         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3501         types for Fortran.
3502
3503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3504             Chris January  <chris.january@arm.com>
3505             David Lecomber  <david.lecomber@arm.com>
3506
3507         * f-exp.y (BINOP_INTRINSIC): New token.
3508         (exp): New parser rule handling BINOP_INTRINSIC.
3509         (f77_keywords): Add new builtin procedures.
3510         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3511         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3512         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3513         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3514         (print_unop_subexp_f): New function.
3515         (print_binop_subexp_f): New function.
3516         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3517         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3518         (dump_subexp_body_f): Likewise.
3519         (operator_check_f): Likewise.
3520         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3521         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3522
3523 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3526         UNOP_KIND.
3527         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3528         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3529         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3530         (operator_length_f): New fuction.
3531         (print_subexp_f): New function.
3532         (op_name_f): New function.
3533         (dump_subexp_body_f): New function.
3534         (operator_check_f): New function.
3535         (exp_descriptor_f): Replace standard expression handling functions
3536         with new functions.
3537         * gdb/fortran-operator.def: New file.
3538         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3539         * gdb/std-operator.def: Remove UNOP_KIND.
3540
3541 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3542
3543         * std-operator.def: Remove unbalanced, stray double quote
3544         character.
3545
3546 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3547             Chris January  <chris.january@arm.com>
3548             Daniel Everett  <daniel.everett@arm.com>
3549             Nick Forrington  <nick.forrington@arm.com>
3550             Richard Bunt  <richard.bunt@arm.com>
3551
3552         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3553         of depth when printing anonymous structs or unions.
3554         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3555         Don't print either the top-level value, or the children if the
3556         max-depth is exceeded.
3557         (ppscm_print_children): When printing the key of a map, allow one
3558         extra level of depth.
3559         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3560         print either the top-level value, or the children if the max-depth
3561         is exceeded.
3562         (print_children): When printing the key of a map, allow one extra
3563         level of depth.
3564         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3565         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3566         (user_print_options): Initialise max_depth field.
3567         (val_print_scalar_or_string_type_p): New function.
3568         (val_print): Check to see if the max depth has been reached.
3569         (val_print_check_max_depth): Define new function.
3570         (show_print_max_depth): New function.
3571         (_initialize_valprint): Add 'print max-depth' option.
3572         * valprint.h (struct value_print_options) <max_depth>: New field.
3573         (val_print_check_max_depth): Declare new function.
3574         * NEWS: Document new feature.
3575
3576 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3577
3578         * ada-lang.c (ada_language_defn): Initialise new field.
3579         * c-lang.c (c_is_string_type_p): New function.
3580         (c_language_defn): Initialise new field.
3581         (cplus_language_defn): Initialise new field.
3582         (asm_language_defn): Initialise new field.
3583         (minimal_language_defn): Initialise new field.
3584         * c-lang.h (c_is_string_type_p): Declare new function.
3585         * d-lang.c (d_language_defn): Initialise new field.
3586         * f-lang.c (f_is_string_type_p): New function.
3587         (f_language_defn): Initialise new field.
3588         * go-lang.c (go_is_string_type_p): New function.
3589         (go_language_defn): Initialise new field.
3590         * language.c (default_is_string_type_p): New function.
3591         (unknown_language_defn): Initialise new field.
3592         (auto_language_defn): Initialise new field.
3593         * language.h (struct language_defn) <la_is_string_type_p>: New
3594         member variable.
3595         (default_is_string_type_p): Declare new function.
3596         * m2-lang.c (m2_language_defn): Initialise new field.
3597         * objc-lang.c (objc_language_defn): Initialise new field.
3598         * opencl-lang.c (opencl_language_defn): Initialise new field.
3599         * p-lang.c (pascal_is_string_type_p): New function.
3600         (pascal_language_defn): Initialise new field.
3601         * rust-lang.c (rust_is_string_type_p): New function.
3602         (rust_language_defn): Initialise new field.
3603
3604 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3605
3606         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3607         New field.
3608         * ada-lang.c (ada_language_defn): Initialise new field.
3609         * c-lang.c (c_language_defn): Likewise.
3610         (cplus_language_defn): Likewise.
3611         (asm_language_defn): Likewise.
3612         (minimal_language_defn): Likewise.
3613         * d-lang.c (d_language_defn): Likewise.
3614         * f-lang.c (f_language_defn): Likewise.
3615         * go-lang.c (go_language_defn): Likewise.
3616         * language.c (unknown_language_defn): Likewise.
3617         (auto_language_defn): Likewise.
3618         * m2-lang.c (m2_language_defn): Likewise.
3619         * objc-lang.c (objc_language_defn): Likewise.
3620         * opencl-lang.c (opencl_language_defn): Likewise.
3621         * p-lang.c (pascal_language_defn): Likewise.
3622         * rust-lang.c (rust_language_defn): Likewise.
3623
3624 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3625
3626         * ada-lang.c (ada_is_character_type): Change return type to bool.
3627         (ada_is_string_type): Likewise.
3628         * ada-lang.h (ada_is_character_type): Update declaration
3629         (ada_is_string_type): Likewise.
3630
3631 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3632
3633         Support style in 'frame|thread apply'
3634
3635         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3636         * record.c (record_start, record_stop): Update callers of
3637         execute_command_to_string with false.
3638         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3639         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3640         methods.
3641         (class string_file): New constructor with term_out parameter.
3642         Override methods term_out and can_emit_style_escape.  New member
3643         term_out.
3644         (class stdio_file): Override can_emit_style_escape.
3645         (class tee_file): Override term_out and can_emit_style_escape.
3646         * utils.h (can_emit_style_escape): Remove.
3647         * utils.c (can_emit_style_escape): Likewise.
3648         Update all callers of can_emit_style_escape (SOMESTREAM) to
3649         SOMESTREAM->can_emit_style_escape.
3650         * source-cache.c (source_cache::get_source_lines): Likewise.
3651         * stack.c (frame_apply_command_count): Call execute_command_to_string
3652         passing the term_out characteristic of the current gdb_stdout.
3653         * thread.c (thr_try_catch_cmd): Likewise.
3654         * top.c (execute_command_to_string): pass term_out parameter
3655         to construct the string_file for the command output.
3656         * ui-file.c (term_cli_styling): New function (most code moved
3657         from utils.c can_emit_style_escape).
3658         (string_file::string_file, string_file::can_emit_style_escape,
3659         stdio_file::can_emit_style_escape, tee_file::term_out,
3660         tee_file::can_emit_style_escape): New functions.
3661
3662 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3663
3664         * NEWS: Mention the new set|show may-call-functions.
3665         * infcall.c (may_call_functions_p): New variable.
3666         (show_may_call_functions_p): New function.
3667         (call_function_by_hand_dummy): Throws an error if not
3668         may-call-functions.
3669         (_initialize_infcall): Call add_setshow_boolean_cmd for
3670         may-call-functions.
3671
3672 2019-04-25  Keith Seitz  <keiths@redhat.com>
3673
3674         PR c++/24367
3675         * cp-support.c (inspect_type): Don't attempt substitutions
3676         of symbol with the same name.
3677
3678 2019-04-25  Tom Tromey  <tromey@adacore.com>
3679
3680         PR gdb/24475:
3681         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3682         static.
3683
3684 2019-04-25  Tom Tromey  <tromey@adacore.com>
3685
3686         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3687         rvalue reference.
3688         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3689         (gdb_xml_parser::parse): Use std::move.
3690         * python/python-internal.h (gdbpy_convert_exception): Take a const
3691         reference.
3692         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3693         std::move.
3694         * python/py-utils.c (gdbpy_convert_exception): Take a const
3695         reference.
3696         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3697         Use std::move.
3698         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3699         Use std::move.
3700         * mi/mi-main.c (mi_print_exception): Take a const reference.
3701         * main.c (handle_command_errors): Take a const reference.
3702         * linespec.c (parse_linespec): Use std::move.
3703         * infcall.c (run_inferior_call): Use std::move.
3704         (call_function_by_hand_dummy): Use std::move.
3705         * exec.c (try_open_exec_file): Use std::move.
3706         * exceptions.h (exception_print, exception_fprintf)
3707         (exception_print_same): Update.
3708         * exceptions.c (print_exception, exception_print)
3709         (exception_fprintf, exception_print_same): Change parameters to
3710         const reference.
3711         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3712         * common/new-op.c: Use std::move.
3713         * common/common-exceptions.h (struct gdb_exception): Add move
3714         constructor.
3715         (struct gdb_exception_error, struct gdb_exception_quit, struct
3716         gdb_quit_bad_alloc): Change constructor to move constructor.
3717         (throw_exception): Change parameter to rvalue reference.
3718         * common/common-exceptions.c (throw_exception): Take rvalue
3719         reference.
3720         * cli/cli-interp.c (safe_execute_command): Use std::move.
3721         * breakpoint.c (insert_bp_location, location_to_sals): Use
3722         std::move.
3723
3724 2019-04-25  Tom Tromey  <tromey@adacore.com>
3725
3726         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3727         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3728         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3729         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3730         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3731         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3732         guile/scm-value.c: Use unpack.
3733         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3734         gdbscm_gdb_exception.
3735         (gdbscm_throw_gdb_exception): Likewise.
3736         (struct gdbscm_gdb_exception): New.
3737         (unpack): New function.
3738         (gdbscm_wrap): Use unpack.
3739
3740 2019-04-25  Tom Tromey  <tromey@adacore.com>
3741
3742         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3743         (gdb_rl_callback_handler): Use std::move.
3744         * common/common-exceptions.h (struct gdb_exception): Add move
3745         assignment operator.
3746         (throw_exception_sjlj): Change "exception" to const reference.
3747         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3748         (throw_exception_sjlj): Change "exception" to const reference.
3749
3750 2019-04-25  Tom Tromey  <tromey@adacore.com>
3751
3752         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3753         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3754         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3755         Update.
3756         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3757         Update.
3758         * mi/mi-interp.c (mi_interp::exec): Update.
3759         * linespec.c (parse_linespec): Update.
3760         * infcall.c (run_inferior_call): Update.
3761         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3762         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3763         (gdbscm_lookup_global_symbol): Update.
3764         * guile/scm-param.c (gdbscm_parameter_value): Update.
3765         * guile/scm-frame.c (gdbscm_frame_read_register)
3766         (gdbscm_frame_read_var): Update.
3767         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3768         * exec.c (try_open_exec_file): Update.
3769         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3770         (gdb_rl_callback_handler): Update.
3771         * common/common-exceptions.h (exception_none): Don't declare.
3772         * common/common-exceptions.c (exception_none): Don't define.
3773         (struct catcher) <exception>: Update.
3774         * cli/cli-interp.c (safe_execute_command): Update.
3775         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3776
3777 2019-04-25  Ali Tamur  <tamur@google.com>
3778
3779         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3780         (read_attribute_value): Likewise.
3781         (dwarf2_read_addr_index): Update comment.
3782         (read_str_index): Add DW_FORM_strx.
3783         (dwarf2_string_attr): Likewise.
3784         (dwarf2_const_value_attr): Likewise.
3785         (dump_die_shallow): Likewise.
3786         (dwarf2_fetch_constant_bytes): Likewise.
3787         (skip_form_bytes): Likewise.
3788         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3789
3790 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3791
3792         PR corefiles/11608
3793         PR corefiles/18187
3794         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3795         OFFSET.  Verify if current mapping contains an ELF header.
3796         (linux_find_memory_regions_full): Adjust call to
3797         dump_mapping_p.
3798
3799 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3800             Kang Li <kanglictf@gmail.com>
3801
3802         PR gdb/21600
3803
3804         * dwarf2-frame.c (read_initial_length): Be consistent about using
3805         unsigned representation of length.
3806         (decode_frame_entry_1): Likewise.  Check for wraparound of
3807         end pointer as well as buffer overflow.
3808
3809 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3810
3811         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3812         "vq".
3813
3814 2019-04-24  Tom Tromey  <tromey@adacore.com>
3815
3816         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3817
3818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * s12z-tdep.c (s12z_unwind_pc): Delete.
3821         (s12z_unwind_sp): Delete.
3822         (s12z_gdbarch_init): Don't register deleted functions with
3823         gdbarch.
3824
3825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * rl78-tdep.c (rl78_unwind_sp): Delete.
3828         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3833         (xstormy16_unwind_pc): Delete.
3834         (xstormy16_dummy_id): Delete.
3835         (xstormy16_gdbarch_init): Don't register deleted functions with
3836         gdbarch.
3837
3838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * vax-tdep.c (vax_unwind_pc): Delete.
3841         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3842
3843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * v850-tdep.c (v850_unwind_sp): Delete.
3846         (v850_unwind_pc): Delete.
3847         (v850_dummy_id): Delete.
3848         (v850_gdbarch_init): Don't register deleted functions with
3849         gdbarch.
3850
3851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3852
3853         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3854         (tilegx_unwind_pc): Delete.
3855         (tilegx_unwind_dummy_id): Delete.
3856         (tilegx_gdbarch_init): Don't register deleted functions with
3857         gdbarch.
3858
3859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3862         (tic6x_dummy_id): Delete.
3863         (tic6x_gdbarch_init): Don't register deleted functions with
3864         gdbarch.
3865
3866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * sparc-tdep.c (sparc_unwind_pc): Delete.
3869         (sparc32_gdbarch_init): Don't register deleted function with
3870         gdbarch.
3871
3872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * sh-tdep.c (sh_unwind_sp): Delete.
3875         (sh_unwind_pc): Delete.
3876         (sh_dummy_id): Delete.
3877         (sh_gdbarch_init): Don't register deleted functions with
3878         gdbarch.
3879
3880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * score-tdep.c (score_unwind_sp): Delete.
3883         (score_unwind_pc): Delete.
3884         (score_dummy_id): Delete.
3885         (score_gdbarch_init): Don't register deleted functions with
3886         gdbarch.
3887
3888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * rx-tdep.c (rx_unwind_pc): Delete.
3891         (rx_unwind_sp): Delete.
3892         (rx_dummy_id): Delete.
3893         (rx_gdbarch_init): Don't register deleted functions with
3894         gdbarch.  Update comment.
3895
3896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3899         (rs6000_dummy_id): Delete.
3900         (rs6000_gdbarch_init): Don't register deleted functions with
3901         gdbarch.
3902
3903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * or1k-tdep.c (or1k_dummy_id): Delete.
3906         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3907
3908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3909
3910         * nios2-tdep.c (nios2_dummy_id): Delete.
3911         (nios2_unwind_sp): Delete.
3912         (nios2_gdbarch_init): Don't register deleted functions with
3913         gdbarch.
3914
3915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * nds32-tdep.c (nds32_dummy_id): Delete.
3918         (nds32_unwind_pc): Delete.
3919         (nds32_unwind_sp): Delete.
3920         (nds32_gdbarch_init): Don't register deleted functions with
3921         gdbarch.
3922
3923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * msp430-tdep.c (msp430_unwind_pc): Delete.
3926         (msp430_unwind_sp): Delete.
3927         (msp430_dummy_id): Delete.
3928         (msp430_gdbarch_init): Don't register deleted functions with
3929         gdbarch.
3930
3931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * moxie-tdep.c (moxie_unwind_sp): Delete.
3934         (moxie_unwind_pc): Delete.
3935         (moxie_dummy_id): Delete.
3936         (moxie_gdbarch_init): Don't register deleted functions with
3937         gdbarch.
3938
3939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3940
3941         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3942         (mn10300_unwind_pc): Delete.
3943         (mn10300_unwind_sp): Delete.
3944         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3945         mn10300_unwind_sp.
3946         (mn10300_frame_unwind_init): Don't register deleted functions with
3947         gdbarch.
3948
3949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         * mep-tdep.c (mep_unwind_pc): Delete.
3952         (mep_unwind_sp): Delete.
3953         (mep_dummy_id): Delete.
3954         (mep_gdbarch_init): Don't register deleted functions with
3955         gdbarch.
3956
3957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3958
3959         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3960         (m68hc11_unwind_sp): Delete.
3961         (m68hc11_gdbarch_init): Don't register deleted functions with
3962         gdbarch.
3963
3964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3965
3966         * m32r-tdep.c (m32r_unwind_sp): Delete.
3967         (m32r_unwind_pc): Delete.
3968         (m32r_dummy_id): Delete.
3969         (m32r_gdbarch_init): Don't register deleted functions with
3970         gdbarch.
3971
3972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * m32c-tdep.c (m32c_unwind_pc): Delete.
3975         (m32c_unwind_sp): Delete.
3976         (m32c_dummy_id): Delete.
3977         (m32c_gdbarch_init): Don't register deleted functions with
3978         gdbarch.
3979
3980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3983         (lm32_unwind_pc): Delete.
3984         (lm32_dummy_id): Delete.
3985         (lm32_gdbarch_init): Don't register deleted functions with
3986         gdbarch.
3987
3988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3991         (iq2000_unwind_pc): Delete.
3992         (iq2000_dummy_id): Delete.
3993         (iq2000_gdbarch_init): Don't register deleted functions with
3994         gdbarch.
3995
3996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * nds32-tdep.c (nds32_type_align): Delete.
3999         (nds32_push_dummy_call): Use type_align instead.
4000
4001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * arm-tdep.c (arm_type_align): Only handle vector override case.
4004         (arm_push_dummy_call): Use type_align.
4005         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4006
4007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4010         case.
4011         (pass_on_stack): Use type_align.
4012         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4013         function.
4014
4015 2019-04-23  Tom Tromey  <tromey@adacore.com>
4016
4017         * dwarf2read.c (line_header::file_name_at): Remove unused
4018         overload.
4019
4020 2019-04-23  Tom de Vries  <tdevries@suse.de>
4021
4022         PR gdb/24438
4023         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4024         invocation.
4025
4026
4027 2019-03-27  Ali Tamur  <tamur@google.com>
4028
4029         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4030         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4031         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4032         (dwarf_expr_context::get_addr_index): Likewise
4033         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4034         (symbol_needs_eval_context::get_addr_index): Likewise
4035         (disassemble_dwarf_expression): Add DW_OP_addrx
4036         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4037         (read_cutu_die_from_dwo): Update comment
4038         (skip_one_die): Add DW_FORM_addrx
4039         (read_attribute_value): Likewise
4040         (var_decode_location): Add DW_OP_addrx
4041         (dwarf2_const_value_attr): Add DW_FORM_addrx
4042         (dump_die_shallow): Likewise
4043         (dwarf2_fetch_constant_bytes): Likewise
4044         (decode_locdesc): Add DW_OP_addrx
4045         (skip_form_bytes): Add DW_FORM_addrx
4046
4047 2019-04-22  Ali Tamur  <tamur@google.com>
4048
4049         * MAINTAINERS (Write After Approval): Add self.
4050
4051 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4052
4053         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4054         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4055         (open_symbol_file_object): Likewise.
4056         (svr4_default_sos): Add info parameter.
4057         (svr4_read_so_list): Likewise.
4058         (svr4_current_sos_direct): Adjust functions calls to pass down
4059         info.
4060         (svr4_current_sos_1): Add info parameter.
4061         (svr4_current_sos): Call get_svr4_info, pass info down to
4062         svr4_current_sos_1.
4063         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4064         get_svr4_info.
4065         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4066         get_svr4_info.
4067         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4068         to get_svr4_info.
4069         (probes_table_remove_objfile_probes): Likewise.
4070         (register_solib_event_probe): Add info parameter.
4071         (solist_update_incremental): Pass info parameter down to
4072         svr4_read_so_list.
4073         (disable_probes_interface): Add info parameter.
4074         (svr4_handle_solib_event): Pass current_program_space to
4075         get_svr4_info.  Adjust disable_probes_interface cleanup.
4076         (svr4_create_probe_breakpoints): Add info parameter, pass it
4077         down to register_solib_event_probe.
4078         (svr4_create_solib_event_breakpoints): Add info parameter,
4079         pass it down to svr4_create_probe_breakpoints.
4080         (enable_break): Pass info down to
4081         svr4_create_solib_event_breakpoints.
4082         (svr4_solib_create_inferior_hook): Pass current_program_space to
4083         get_svr4_info.
4084         (svr4_clear_solib): Likewise.
4085
4086 2019-04-22  Pedro Alves  <palves@redhat.com>
4087
4088         * solib-svr4.c (svr4_free_objfile_observer): New.
4089         (probe_and_action::objfile): New field.
4090         (probes_table_htab_remove_objfile_probes)
4091         (probes_table_remove_objfile_probes): New functions.
4092         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4093         in the new probe_and_action.  Don't store the probe in 'lookup'.
4094         (svr4_create_probe_breakpoints): Pass objfile to
4095         register_solib_event_probe.
4096         (_initialize_svr4_solib): Register a free_objfile observer.
4097
4098 2019-04-19  Tom Tromey  <tom@tromey.com>
4099
4100         * common/queue.h: Remove.
4101
4102 2019-04-19  Tom Tromey  <tom@tromey.com>
4103
4104         * event-loop.c: Don't include "common/queue.h".
4105
4106 2019-04-19  Tom Tromey  <tom@tromey.com>
4107
4108         * remote.c (remote_target): Use delete.
4109         * remote-notif.h: Include <list>, not "common/queue.h".
4110         (notif_client_p): Remove typedef.
4111         (remote_notif_state): Add constructor, destructor, initializer.
4112         <notif_queue>: Now a std::list.
4113         (remote_notif_state_xfree): Don't declare.
4114         * remote-notif.c (remote_notif_process, handle_notification)
4115         (remote_notif_state_allocate): Update.
4116         (~remote_notif_state): Rename from remote_notif_state_xfree.
4117
4118 2019-04-19  Tom Tromey  <tom@tromey.com>
4119
4120         * symfile.c (reread_symbols): Update.
4121         * objfiles.c (objfile_register_static_link)
4122         (objfile_lookup_static_link): Update
4123         (~objfile) Don't delete static_links.
4124         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4125
4126 2019-04-19  Tom Tromey  <tom@tromey.com>
4127
4128         * type-stack.h (struct type_stack) <insert>: Constify string.
4129         * type-stack.c (type_stack::insert): Constify string.
4130         * gdbtypes.h (lookup_template_type): Update.
4131         (address_space_name_to_int): Update.
4132         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4133         const.
4134         (lookup_template_type): Make name const.
4135         * c-exp.y: Update rules.
4136         (lex_one_token, classify_name, classify_inner_name)
4137         (c_print_token): Update.
4138         * p-exp.y: Update rules.
4139         (yylex): Update.
4140         * f-exp.y: Update rules.
4141         (yylex): Update.
4142         * d-exp.y: Update rules.
4143         (lex_one_token, classify_name, classify_inner_name): Update.
4144         * parse.c (write_dollar_variable, copy_name): Return std::string.
4145         * parser-defs.h (copy_name): Change return type.
4146         * m2-exp.y: Update rules.
4147         (yylex): Update.
4148         * go-exp.y (lex_one_token): Update.
4149         Update rules.
4150         (classify_unsafe_function, classify_packaged_name)
4151         (classify_name, yylex): Update.
4152
4153 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4154
4155         * configure.ac: add --enable-source-highlight switch.
4156         * configure: Regenerate.
4157         * top.c (print_gdb_version): plumb --enable-source-highlight
4158         status to "show configuration".
4159
4160 2019-04-19  Tom Tromey  <tromey@adacore.com>
4161
4162         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4163         Check ADA_TYPE_P.
4164         (empty_record, ada_template_to_fixed_record_type_1)
4165         (template_to_static_fixed_type)
4166         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4167         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4168         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4169         macros.
4170
4171 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4172
4173         PR symtab/24423:
4174         * source.c (print_source_lines_base): Advance "iter" when a
4175         control character is seen.
4176
4177 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4178
4179         * inferior.h (struct infcall_suspend_state_deleter):
4180         Catch exception in destructor to avoid crash.
4181
4182 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4183
4184         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4185         close to the add_com "shell".
4186
4187 2019-04-18  Tom Tromey  <tromey@adacore.com>
4188
4189         * process-stratum-target.h (class process_stratum_target)
4190         <stratum>: Add "final".
4191
4192 2019-04-17  Tom Tromey  <tromey@adacore.com>
4193
4194         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4195         against nullptr before use.
4196
4197 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4198
4199         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4200
4201 2019-04-17  Jim Wilson  <jimw@sifive.com>
4202             Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4205         code read might fail, assume 4-byte breakpoint in that case.
4206
4207 2019-04-15  Leszek Swirski  <leszeks@google.com>
4208
4209         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4210         rather than a hand-rolled POD check when checking for forced MEMORY
4211         classification.
4212
4213 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4214
4215         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4216         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4217         function.
4218         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4219         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4220         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4221         declaration.
4222
4223 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4224
4225         * aarch64-linux-nat.c
4226         (aarch64_linux_nat_target::thread_architecture): Add override.
4227         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4228         each VQ.
4229
4230 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4231
4232         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4233
4234 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4237         target types of size 96-bits, add some additional comments, and
4238         check that the builtin type we found was the correct size.
4239
4240 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4241
4242         * utils.c (prompt_for_continue): Don't restore the styling at the
4243         end, as applied_style has the wrong value.  This fixes styling in
4244         long lists of file names that are interrupted by the "Continue?"
4245         prompt.
4246
4247 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4248
4249         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4250         * c-lang.c (c_language_defn): Likewise.
4251         (cplus_language_defn): Likewise.
4252         (asm_language_defn): Likewise.
4253         (minimal_language_defn): Likewise.
4254         * d-lang.c (d_language_defn): Likewise.
4255         * f-lang.c (f_language_defn): Likewise.
4256         * go-lang.c (go_language_defn): Likewise.
4257         * language.c (unknown_language_defn): Likewise.
4258         (auto_language_defn): Likewise.
4259         * language.h (struct language_defn): Remove la_magic field.
4260         (LANG_MAGIC): Delete.
4261         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4262         * objc-lang.c (objc_language_defn): Likewise.
4263         * opencl-lang.c (opencl_language_defn): Likewise.
4264         * p-lang.c (pascal_language_defn): Likewise.
4265         * rust-lang.c (rust_language_defn): Likewise.
4266
4267 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * riscv-tdep.c (riscv_type_align): New function.
4270         (riscv_type_alignment): Delete.
4271         (riscv_arg_location): Use 'type_align'.
4272         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4273
4274 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * gdbtypes.c (type_align): A struct with no non-static fields also
4277         has alignment of 1.
4278
4279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4282         component to 0.
4283         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4284         member.
4285         (riscv_struct_info::analyse): New implementation using new
4286         analyse_inner member function.
4287         (riscv_struct_info::field_offset): New member function.
4288         (riscv_struct_info::m_offsets): New member variable.
4289         (riscv_struct_info::analyse_inner): New private member function,
4290         takes the old implementation of riscv_struct_info::analyse but
4291         extended to track field offsets.
4292         (riscv_call_arg_struct): Update the struct folding special cases
4293         to handle cases where empty C++ structs, which are non-zero
4294         length, are found.
4295         (riscv_arg_location): Initialise the length of each location, a
4296         non-zero length now indicates the location is in use.
4297         (riscv_push_dummy_call): Allow for the first location having a
4298         non-zero offset when setting up arguments.
4299         (riscv_return_value): Likewise, but for return values.
4300
4301 2019-04-11  Tom Tromey  <tromey@adacore.com>
4302
4303         * utils.c (internal_vproblem): Make "msg" const.
4304
4305 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4306
4307         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4308         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4309         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4310         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4311
4312 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4313
4314         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4315         function.
4316         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4317         of amd64_collect_native_gregset.
4318         (amd64_linux_nat_target::store_registers): Likewise.
4319
4320 2019-04-10  Tom Tromey  <tom@tromey.com>
4321
4322         * symtab.c (lookup_global_symbol_from_objfile)
4323         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4324         * objfiles.h (class separate_debug_iterator): New.
4325         (class separate_debug_range): New.
4326         (struct objfile) <separate_debug_objfiles>: New method.
4327         (objfile_separate_debug_iterate): Don't declare.
4328         * objfiles.c (separate_debug_iterator::operator++): Rename from
4329         objfile_separate_debug_iterate.
4330         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4331         iterator.
4332         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4333         iterator.
4334
4335 2019-04-10  Tom Tromey  <tom@tromey.com>
4336
4337         * symfile.c (reread_symbols): Remove old comment.
4338         * objfiles.c (free_all_objfiles): Fix a typo.
4339
4340 2019-04-10  Tom Tromey  <tom@tromey.com>
4341
4342         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4343         * minsyms.c (lookup_minimal_symbol): Use foreach.
4344         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4345         (lookup_minimal_symbol_solib_trampoline): Likewise.
4346         * symfile.c (reread_symbols): Use foreach.
4347
4348 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4349             Tom Tromey  <tromey@adacore.com>
4350
4351         PR rust/24414:
4352         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4353         (rust_lex_int_test): Change "value" to be LONGEST.
4354         (rust_lex_tests): Add test for long integer literal.
4355
4356 2019-04-09  Tom Tromey  <tromey@adacore.com>
4357
4358         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4359         to bool.
4360         (extended_remote_target::attach): Update.
4361         (remote_target::remote_notice_new_inferior): Update.
4362         (remote_target::add_current_inferior_and_thread): Update.
4363         * inferior.c (exit_inferior_1): Use "false".
4364         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4365
4366 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4367
4368         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4369         the "start" command.
4370
4371 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4372
4373         * python/py-inferior.c (infpy_thread_from_thread_handle):
4374         Adjust comments to reflect renaming of thread_from_thread_handle
4375         to thread_from_handle.  Adjust keywords.  Fix type error message.
4376         (inferior_object_methods): Add thread_from_handle.  Retain
4377         thread_from_thread_handle, but mark it as deprecated.
4378
4379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4380
4381         * gdbthread.h (find_thread_by_handle): Revise declaration.
4382         * thread.c (find_thread_by_handle): Likewise.  Adjust
4383         implementation too.
4384         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4385         support for buffer objects as handles.
4386
4387 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4388
4389         * python/py-infthread.c (thpy_thread_handle): New function.
4390         (thread_object_methods): Register thpy_thread_handle.
4391
4392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4393
4394         * gdbthread.h (thread_to_thread_handle): Declare.
4395         * thread.c (gdbtypes.h): Include.
4396         (thread_to_thread_handle): New function.
4397
4398         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4399         (target_thread_info_to_thread_handle): Declare.
4400         * target.c (target_thread_info_to_thread_handle): New function.
4401         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4402         * target-delegates.c: Regenerate.
4403
4404         * linux-thread-db.c (class thread_db_target): Add method
4405         thread_info_to_thread_handle.
4406         (thread_db_target::thread_info_to_thread_handle): Define.
4407         * remote.c (class remote_target): Add new method
4408         thread_info_to_thread_handle.
4409         (remote_target::thread_info_to_thread_handle): Define.
4410
4411 2019-04-08  Pedro Alves  <palves@redhat.com>
4412
4413         * common/common-exceptions.c (throw_exception): Don't create
4414         named object to throw; throw directly.
4415         (throw_it): Likewise.  Don't initialize gdb_exception::message
4416         here, with new; pass FMT and AP to the ctor instead.
4417         * common/common-exceptions.h: Include <string>.
4418         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4419         const char *, va_list)): New ctor.  Use std::make_shared.
4420         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4421         errors)): Delete.
4422         (gdb_exception_error::gdb_exception_error(enum errors, const char
4423         *, va_list)): New.
4424         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4425         Add assertion.
4426         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4427         errors)): Delete.
4428         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4429         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4430         Add assertion.
4431
4432 2019-04-08  Tom Tromey  <tom@tromey.com>
4433
4434         * valops.c (value_rtti_indirect_type): Replace throw_exception
4435         with throw.
4436         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4437         with throw.
4438         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4439         throw.
4440         * target.c (target_translate_tls_address): Replace throw_exception
4441         with throw.
4442         * stack.c (frame_apply_command_count): Replace throw_exception
4443         with throw.
4444         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4445         throw.
4446         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4447         with throw.
4448         * rs6000-tdep.c (rs6000_frame_cache)
4449         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4450         * remote.c: Replace throw_exception with throw.
4451         * record-full.c (record_full_message, record_full_wait_1)
4452         (record_full_restore): Replace throw_exception with throw.
4453         * record-btrace.c:
4454         (get_thread_current_frame_id, record_btrace_start_replaying)
4455         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4456         (cmd_record_btrace_start): Replace throw_exception with throw.
4457         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4458         throw.
4459         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4460         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4461         * linespec.c:
4462         (find_linespec_symbols): Replace throw_exception with throw.
4463         * infrun.c (displaced_step_prepare, resume): Replace
4464         throw_exception with throw.
4465         * infcmd.c (post_create_inferior): Replace throw_exception with
4466         throw.
4467         * inf-loop.c (inferior_event_handler): Replace throw_exception
4468         with throw.
4469         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4470         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4471         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4472         (get_prev_frame_always, get_frame_pc_if_available)
4473         (get_frame_address_in_block_if_available, get_frame_language):
4474         Replace throw_exception with throw.
4475         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4476         throw_exception with throw.
4477         * eval.c (fetch_subexp_value, evaluate_var_value)
4478         (evaluate_funcall, evaluate_subexp_standard): Replace
4479         throw_exception with throw.
4480         * dwarf2loc.c (call_site_find_chain)
4481         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4482         Replace throw_exception with throw.
4483         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4484         with throw.
4485         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4486         throw.
4487         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4488         * completer.c (complete_line_internal): Replace throw_exception
4489         with throw.
4490         * compile/compile-object-run.c (compile_object_run): Replace
4491         throw_exception with throw.
4492         * cli/cli-script.c (process_next_line): Replace throw_exception
4493         with throw.
4494         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4495         (btrace_enable, btrace_maint_update_pt_packets): Replace
4496         throw_exception with throw.
4497         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4498         throw_exception with throw.
4499         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4500         throw_exception with throw.
4501         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4502         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4503         * aarch64-tdep.c (aarch64_make_prologue_cache)
4504         (aarch64_make_stub_cache): Replace throw_exception with throw.
4505
4506 2019-04-08  Tom Tromey  <tom@tromey.com>
4507
4508         * common/common-exceptions.c (throw_exception): Rename from
4509         throw_exception_cxx.  Remove old copy.  Make argument const.
4510         (throw_it): Create and throw exception objects directly.
4511         * common/common-exceptions.h (throw_exception): Make argument
4512         const.
4513         (struct gdb_exception_error): Add constructor.
4514         (struct gdb_exception_quit): Add constructor.
4515
4516 2019-04-08  Tom Tromey  <tom@tromey.com>
4517
4518         * common/common-exceptions.h (exception_rethrow): Don't declare.
4519         (TRY_SJLJ): Update comment.
4520         (TRY, CATCH, END_CATCH): Remove.
4521         * common/common-exceptions.c (exception_rethrow): Remove.
4522
4523 2019-04-08  Tom Tromey  <tom@tromey.com>
4524
4525         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4526         Remove.
4527         (gdb_exception_error): Rename from
4528         gdb_exception_RETURN_MASK_ERROR.
4529         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4530         (gdb_quit_bad_alloc): Update.
4531         * aarch64-tdep.c: Update.
4532         * ada-lang.c: Update.
4533         * ada-typeprint.c: Update.
4534         * ada-valprint.c: Update.
4535         * amd64-tdep.c: Update.
4536         * arch-utils.c: Update.
4537         * break-catch-throw.c: Update.
4538         * breakpoint.c: Update.
4539         * btrace.c: Update.
4540         * c-varobj.c: Update.
4541         * cli/cli-cmds.c: Update.
4542         * cli/cli-interp.c: Update.
4543         * cli/cli-script.c: Update.
4544         * common/common-exceptions.c: Update.
4545         * common/new-op.c: Update.
4546         * common/selftest.c: Update.
4547         * compile/compile-c-symbols.c: Update.
4548         * compile/compile-cplus-symbols.c: Update.
4549         * compile/compile-object-load.c: Update.
4550         * compile/compile-object-run.c: Update.
4551         * completer.c: Update.
4552         * corelow.c: Update.
4553         * cp-abi.c: Update.
4554         * cp-support.c: Update.
4555         * cp-valprint.c: Update.
4556         * darwin-nat.c: Update.
4557         * disasm-selftests.c: Update.
4558         * dtrace-probe.c: Update.
4559         * dwarf-index-cache.c: Update.
4560         * dwarf-index-write.c: Update.
4561         * dwarf2-frame-tailcall.c: Update.
4562         * dwarf2-frame.c: Update.
4563         * dwarf2loc.c: Update.
4564         * dwarf2read.c: Update.
4565         * eval.c: Update.
4566         * event-loop.c: Update.
4567         * event-top.c: Update.
4568         * exec.c: Update.
4569         * f-valprint.c: Update.
4570         * fbsd-tdep.c: Update.
4571         * frame-unwind.c: Update.
4572         * frame.c: Update.
4573         * gdbtypes.c: Update.
4574         * gnu-v3-abi.c: Update.
4575         * guile/guile-internal.h: Update.
4576         * guile/scm-block.c: Update.
4577         * guile/scm-breakpoint.c: Update.
4578         * guile/scm-cmd.c: Update.
4579         * guile/scm-disasm.c: Update.
4580         * guile/scm-frame.c: Update.
4581         * guile/scm-lazy-string.c: Update.
4582         * guile/scm-math.c: Update.
4583         * guile/scm-param.c: Update.
4584         * guile/scm-ports.c: Update.
4585         * guile/scm-pretty-print.c: Update.
4586         * guile/scm-symbol.c: Update.
4587         * guile/scm-symtab.c: Update.
4588         * guile/scm-type.c: Update.
4589         * guile/scm-value.c: Update.
4590         * i386-linux-tdep.c: Update.
4591         * i386-tdep.c: Update.
4592         * inf-loop.c: Update.
4593         * infcall.c: Update.
4594         * infcmd.c: Update.
4595         * infrun.c: Update.
4596         * jit.c: Update.
4597         * language.c: Update.
4598         * linespec.c: Update.
4599         * linux-fork.c: Update.
4600         * linux-nat.c: Update.
4601         * linux-tdep.c: Update.
4602         * linux-thread-db.c: Update.
4603         * main.c: Update.
4604         * mi/mi-cmd-break.c: Update.
4605         * mi/mi-cmd-stack.c: Update.
4606         * mi/mi-interp.c: Update.
4607         * mi/mi-main.c: Update.
4608         * objc-lang.c: Update.
4609         * p-valprint.c: Update.
4610         * parse.c: Update.
4611         * ppc-linux-tdep.c: Update.
4612         * printcmd.c: Update.
4613         * python/py-arch.c: Update.
4614         * python/py-breakpoint.c: Update.
4615         * python/py-cmd.c: Update.
4616         * python/py-finishbreakpoint.c: Update.
4617         * python/py-frame.c: Update.
4618         * python/py-framefilter.c: Update.
4619         * python/py-gdb-readline.c: Update.
4620         * python/py-inferior.c: Update.
4621         * python/py-infthread.c: Update.
4622         * python/py-lazy-string.c: Update.
4623         * python/py-linetable.c: Update.
4624         * python/py-objfile.c: Update.
4625         * python/py-param.c: Update.
4626         * python/py-prettyprint.c: Update.
4627         * python/py-progspace.c: Update.
4628         * python/py-record-btrace.c: Update.
4629         * python/py-record.c: Update.
4630         * python/py-symbol.c: Update.
4631         * python/py-type.c: Update.
4632         * python/py-unwind.c: Update.
4633         * python/py-utils.c: Update.
4634         * python/py-value.c: Update.
4635         * python/python.c: Update.
4636         * record-btrace.c: Update.
4637         * record-full.c: Update.
4638         * remote-fileio.c: Update.
4639         * remote.c: Update.
4640         * riscv-tdep.c: Update.
4641         * rs6000-aix-tdep.c: Update.
4642         * rs6000-tdep.c: Update.
4643         * rust-exp.y: Update.
4644         * rust-lang.c: Update.
4645         * s390-tdep.c: Update.
4646         * selftest-arch.c: Update.
4647         * solib-dsbt.c: Update.
4648         * solib-frv.c: Update.
4649         * solib-spu.c: Update.
4650         * solib-svr4.c: Update.
4651         * solib.c: Update.
4652         * sparc64-linux-tdep.c: Update.
4653         * stack.c: Update.
4654         * symfile-mem.c: Update.
4655         * symmisc.c: Update.
4656         * target.c: Update.
4657         * thread.c: Update.
4658         * top.c: Update.
4659         * tracefile-tfile.c: Update.
4660         * tui/tui.c: Update.
4661         * typeprint.c: Update.
4662         * unittests/cli-utils-selftests.c: Update.
4663         * unittests/parse-connection-spec-selftests.c: Update.
4664         * valops.c: Update.
4665         * valprint.c: Update.
4666         * value.c: Update.
4667         * varobj.c: Update.
4668         * windows-nat.c: Update.
4669         * x86-linux-nat.c: Update.
4670         * xml-support.c: Update.
4671
4672 2019-04-08  Tom Tromey  <tom@tromey.com>
4673
4674         * xml-support.c: Use C++ exception handling.
4675         * x86-linux-nat.c: Use C++ exception handling.
4676         * windows-nat.c: Use C++ exception handling.
4677         * varobj.c: Use C++ exception handling.
4678         * value.c: Use C++ exception handling.
4679         * valprint.c: Use C++ exception handling.
4680         * valops.c: Use C++ exception handling.
4681         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4682         handling.
4683         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4684         * typeprint.c: Use C++ exception handling.
4685         * tui/tui.c: Use C++ exception handling.
4686         * tracefile-tfile.c: Use C++ exception handling.
4687         * top.c: Use C++ exception handling.
4688         * thread.c: Use C++ exception handling.
4689         * target.c: Use C++ exception handling.
4690         * symmisc.c: Use C++ exception handling.
4691         * symfile-mem.c: Use C++ exception handling.
4692         * stack.c: Use C++ exception handling.
4693         * sparc64-linux-tdep.c: Use C++ exception handling.
4694         * solib.c: Use C++ exception handling.
4695         * solib-svr4.c: Use C++ exception handling.
4696         * solib-spu.c: Use C++ exception handling.
4697         * solib-frv.c: Use C++ exception handling.
4698         * solib-dsbt.c: Use C++ exception handling.
4699         * selftest-arch.c: Use C++ exception handling.
4700         * s390-tdep.c: Use C++ exception handling.
4701         * rust-lang.c: Use C++ exception handling.
4702         * rust-exp.y: Use C++ exception handling.
4703         * rs6000-tdep.c: Use C++ exception handling.
4704         * rs6000-aix-tdep.c: Use C++ exception handling.
4705         * riscv-tdep.c: Use C++ exception handling.
4706         * remote.c: Use C++ exception handling.
4707         * remote-fileio.c: Use C++ exception handling.
4708         * record-full.c: Use C++ exception handling.
4709         * record-btrace.c: Use C++ exception handling.
4710         * python/python.c: Use C++ exception handling.
4711         * python/py-value.c: Use C++ exception handling.
4712         * python/py-utils.c: Use C++ exception handling.
4713         * python/py-unwind.c: Use C++ exception handling.
4714         * python/py-type.c: Use C++ exception handling.
4715         * python/py-symbol.c: Use C++ exception handling.
4716         * python/py-record.c: Use C++ exception handling.
4717         * python/py-record-btrace.c: Use C++ exception handling.
4718         * python/py-progspace.c: Use C++ exception handling.
4719         * python/py-prettyprint.c: Use C++ exception handling.
4720         * python/py-param.c: Use C++ exception handling.
4721         * python/py-objfile.c: Use C++ exception handling.
4722         * python/py-linetable.c: Use C++ exception handling.
4723         * python/py-lazy-string.c: Use C++ exception handling.
4724         * python/py-infthread.c: Use C++ exception handling.
4725         * python/py-inferior.c: Use C++ exception handling.
4726         * python/py-gdb-readline.c: Use C++ exception handling.
4727         * python/py-framefilter.c: Use C++ exception handling.
4728         * python/py-frame.c: Use C++ exception handling.
4729         * python/py-finishbreakpoint.c: Use C++ exception handling.
4730         * python/py-cmd.c: Use C++ exception handling.
4731         * python/py-breakpoint.c: Use C++ exception handling.
4732         * python/py-arch.c: Use C++ exception handling.
4733         * printcmd.c: Use C++ exception handling.
4734         * ppc-linux-tdep.c: Use C++ exception handling.
4735         * parse.c: Use C++ exception handling.
4736         * p-valprint.c: Use C++ exception handling.
4737         * objc-lang.c: Use C++ exception handling.
4738         * mi/mi-main.c: Use C++ exception handling.
4739         * mi/mi-interp.c: Use C++ exception handling.
4740         * mi/mi-cmd-stack.c: Use C++ exception handling.
4741         * mi/mi-cmd-break.c: Use C++ exception handling.
4742         * main.c: Use C++ exception handling.
4743         * linux-thread-db.c: Use C++ exception handling.
4744         * linux-tdep.c: Use C++ exception handling.
4745         * linux-nat.c: Use C++ exception handling.
4746         * linux-fork.c: Use C++ exception handling.
4747         * linespec.c: Use C++ exception handling.
4748         * language.c: Use C++ exception handling.
4749         * jit.c: Use C++ exception handling.
4750         * infrun.c: Use C++ exception handling.
4751         * infcmd.c: Use C++ exception handling.
4752         * infcall.c: Use C++ exception handling.
4753         * inf-loop.c: Use C++ exception handling.
4754         * i386-tdep.c: Use C++ exception handling.
4755         * i386-linux-tdep.c: Use C++ exception handling.
4756         * guile/scm-value.c: Use C++ exception handling.
4757         * guile/scm-type.c: Use C++ exception handling.
4758         * guile/scm-symtab.c: Use C++ exception handling.
4759         * guile/scm-symbol.c: Use C++ exception handling.
4760         * guile/scm-pretty-print.c: Use C++ exception handling.
4761         * guile/scm-ports.c: Use C++ exception handling.
4762         * guile/scm-param.c: Use C++ exception handling.
4763         * guile/scm-math.c: Use C++ exception handling.
4764         * guile/scm-lazy-string.c: Use C++ exception handling.
4765         * guile/scm-frame.c: Use C++ exception handling.
4766         * guile/scm-disasm.c: Use C++ exception handling.
4767         * guile/scm-cmd.c: Use C++ exception handling.
4768         * guile/scm-breakpoint.c: Use C++ exception handling.
4769         * guile/scm-block.c: Use C++ exception handling.
4770         * guile/guile-internal.h: Use C++ exception handling.
4771         * gnu-v3-abi.c: Use C++ exception handling.
4772         * gdbtypes.c: Use C++ exception handling.
4773         * frame.c: Use C++ exception handling.
4774         * frame-unwind.c: Use C++ exception handling.
4775         * fbsd-tdep.c: Use C++ exception handling.
4776         * f-valprint.c: Use C++ exception handling.
4777         * exec.c: Use C++ exception handling.
4778         * event-top.c: Use C++ exception handling.
4779         * event-loop.c: Use C++ exception handling.
4780         * eval.c: Use C++ exception handling.
4781         * dwarf2read.c: Use C++ exception handling.
4782         * dwarf2loc.c: Use C++ exception handling.
4783         * dwarf2-frame.c: Use C++ exception handling.
4784         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4785         * dwarf-index-write.c: Use C++ exception handling.
4786         * dwarf-index-cache.c: Use C++ exception handling.
4787         * dtrace-probe.c: Use C++ exception handling.
4788         * disasm-selftests.c: Use C++ exception handling.
4789         * darwin-nat.c: Use C++ exception handling.
4790         * cp-valprint.c: Use C++ exception handling.
4791         * cp-support.c: Use C++ exception handling.
4792         * cp-abi.c: Use C++ exception handling.
4793         * corelow.c: Use C++ exception handling.
4794         * completer.c: Use C++ exception handling.
4795         * compile/compile-object-run.c: Use C++ exception handling.
4796         * compile/compile-object-load.c: Use C++ exception handling.
4797         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4798         * compile/compile-c-symbols.c: Use C++ exception handling.
4799         * common/selftest.c: Use C++ exception handling.
4800         * common/new-op.c: Use C++ exception handling.
4801         * cli/cli-script.c: Use C++ exception handling.
4802         * cli/cli-interp.c: Use C++ exception handling.
4803         * cli/cli-cmds.c: Use C++ exception handling.
4804         * c-varobj.c: Use C++ exception handling.
4805         * btrace.c: Use C++ exception handling.
4806         * breakpoint.c: Use C++ exception handling.
4807         * break-catch-throw.c: Use C++ exception handling.
4808         * arch-utils.c: Use C++ exception handling.
4809         * amd64-tdep.c: Use C++ exception handling.
4810         * ada-valprint.c: Use C++ exception handling.
4811         * ada-typeprint.c: Use C++ exception handling.
4812         * ada-lang.c: Use C++ exception handling.
4813         * aarch64-tdep.c: Use C++ exception handling.
4814
4815 2019-04-08  Tom Tromey  <tom@tromey.com>
4816
4817         * xml-support.c (gdb_xml_parser::parse): Update.
4818         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4819         * value.c (show_convenience): Update.
4820         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4821         (test_parse_flags_qcs): Update.
4822         * thread.c (thr_try_catch_cmd): Update.
4823         * target.c (target_translate_tls_address): Update.
4824         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4825         (info_frame_command_core, frame_apply_command_count): Update.
4826         * rust-exp.y (rust_lex_exception_test): Update.
4827         * riscv-tdep.c (riscv_print_one_register_info): Update.
4828         * remote.c (remote_target::enable_btrace): Update.
4829         * record-btrace.c (record_btrace_enable_warn): Update.
4830         * python/py-utils.c (gdbpy_convert_exception): Update.
4831         * printcmd.c (do_one_display, print_variable_and_value): Update.
4832         * mi/mi-main.c (mi_print_exception): Update.
4833         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4834         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4835         * linux-nat.c (linux_nat_target::attach): Update.
4836         * linux-fork.c (class scoped_switch_fork_info): Update.
4837         * infrun.c (displaced_step_prepare): Update.
4838         * infcall.c (call_function_by_hand_dummy): Update.
4839         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4840         * gnu-v3-abi.c (print_one_vtable): Update.
4841         * frame.c (get_prev_frame_always): Update.
4842         * f-valprint.c (info_common_command_for_block): Update.
4843         * exec.c (try_open_exec_file): Update.
4844         * exceptions.c (print_exception, exception_print)
4845         (exception_fprintf, exception_print_same): Update.
4846         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4847         * dwarf-index-cache.c (index_cache::store)
4848         (index_cache::lookup_gdb_index): Update.
4849         * darwin-nat.c (maybe_cache_shell): Update.
4850         * cp-valprint.c (cp_print_value_fields): Update.
4851         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4852         (gcc_cplus_symbol_address): Update.
4853         * compile/compile-c-symbols.c (gcc_convert_symbol)
4854         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4855         * common/selftest.c: Update.
4856         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4857         a std::string.
4858         (exception_try_scope_entry, exception_try_scope_exit): Don't
4859         declare.
4860         (struct exception_try_scope): Remove.
4861         (TRY): Don't use exception_try_scope.
4862         (struct gdb_exception): Add constructor, operator=.
4863         <what>: New method.
4864         (struct gdb_exception_RETURN_MASK_ALL)
4865         (struct gdb_exception_RETURN_MASK_ERROR)
4866         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4867         (struct gdb_quit_bad_alloc): Update.
4868         * common/common-exceptions.c (exception_none): Change
4869         initializer.
4870         (struct catcher) <state, exception>: Initialize inline.
4871         <prev>: Remove member.
4872         (current_catcher): Remove.
4873         (catchers): New global.
4874         (exceptions_state_mc_init): Simplify.
4875         (catcher_pop): Remove.
4876         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4877         (try_scope_depth, exception_try_scope_entry)
4878         (exception_try_scope_exit): Remove.
4879         (throw_exception_sjlj): Update.
4880         (exception_messages, exception_messages_size): Remove.
4881         (throw_it): Simplify.
4882         (gdb_exception_sliced_copy): Remove.
4883         (throw_exception_cxx): Update.
4884         * cli/cli-script.c (script_from_file): Update.
4885         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4886         Update.
4887         * ada-valprint.c (ada_val_print): Update.
4888         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4889         (create_excep_cond_exprs): Update.
4890
4891 2019-04-08  Tom Tromey  <tom@tromey.com>
4892
4893         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4894         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4895         (TRY, CATCH, END_CATCH): Remove some definitions.
4896         * common/common-exceptions.c: Don't use GDB_XCPT.
4897         (catcher_list_size): Remove.
4898         (throw_exception, throw_it): Simplify.
4899
4900 2019-04-05  Tom Tromey  <tom@tromey.com>
4901
4902         Revert the header-sorting patch.
4903         * ft32-tdep.c: Revert.
4904         * frv-tdep.c: Revert.
4905         * frv-linux-tdep.c: Revert.
4906         * frame.c: Revert.
4907         * frame-unwind.c: Revert.
4908         * frame-base.c: Revert.
4909         * fork-child.c: Revert.
4910         * findvar.c: Revert.
4911         * findcmd.c: Revert.
4912         * filesystem.c: Revert.
4913         * filename-seen-cache.h: Revert.
4914         * filename-seen-cache.c: Revert.
4915         * fbsd-tdep.c: Revert.
4916         * fbsd-nat.h: Revert.
4917         * fbsd-nat.c: Revert.
4918         * f-valprint.c: Revert.
4919         * f-typeprint.c: Revert.
4920         * f-lang.c: Revert.
4921         * extension.h: Revert.
4922         * extension.c: Revert.
4923         * extension-priv.h: Revert.
4924         * expprint.c: Revert.
4925         * exec.h: Revert.
4926         * exec.c: Revert.
4927         * exceptions.c: Revert.
4928         * event-top.c: Revert.
4929         * event-loop.c: Revert.
4930         * eval.c: Revert.
4931         * elfread.c: Revert.
4932         * dwarf2read.h: Revert.
4933         * dwarf2read.c: Revert.
4934         * dwarf2loc.c: Revert.
4935         * dwarf2expr.h: Revert.
4936         * dwarf2expr.c: Revert.
4937         * dwarf2-frame.c: Revert.
4938         * dwarf2-frame-tailcall.c: Revert.
4939         * dwarf-index-write.h: Revert.
4940         * dwarf-index-write.c: Revert.
4941         * dwarf-index-common.c: Revert.
4942         * dwarf-index-cache.h: Revert.
4943         * dwarf-index-cache.c: Revert.
4944         * dummy-frame.c: Revert.
4945         * dtrace-probe.c: Revert.
4946         * disasm.h: Revert.
4947         * disasm.c: Revert.
4948         * disasm-selftests.c: Revert.
4949         * dictionary.c: Revert.
4950         * dicos-tdep.c: Revert.
4951         * demangle.c: Revert.
4952         * dcache.h: Revert.
4953         * dcache.c: Revert.
4954         * darwin-nat.h: Revert.
4955         * darwin-nat.c: Revert.
4956         * darwin-nat-info.c: Revert.
4957         * d-valprint.c: Revert.
4958         * d-namespace.c: Revert.
4959         * d-lang.c: Revert.
4960         * ctf.c: Revert.
4961         * csky-tdep.c: Revert.
4962         * csky-linux-tdep.c: Revert.
4963         * cris-tdep.c: Revert.
4964         * cris-linux-tdep.c: Revert.
4965         * cp-valprint.c: Revert.
4966         * cp-support.c: Revert.
4967         * cp-namespace.c: Revert.
4968         * cp-abi.c: Revert.
4969         * corelow.c: Revert.
4970         * corefile.c: Revert.
4971         * continuations.c: Revert.
4972         * completer.h: Revert.
4973         * completer.c: Revert.
4974         * complaints.c: Revert.
4975         * coffread.c: Revert.
4976         * coff-pe-read.c: Revert.
4977         * cli-out.h: Revert.
4978         * cli-out.c: Revert.
4979         * charset.c: Revert.
4980         * c-varobj.c: Revert.
4981         * c-valprint.c: Revert.
4982         * c-typeprint.c: Revert.
4983         * c-lang.c: Revert.
4984         * buildsym.c: Revert.
4985         * buildsym-legacy.c: Revert.
4986         * build-id.h: Revert.
4987         * build-id.c: Revert.
4988         * btrace.c: Revert.
4989         * bsd-uthread.c: Revert.
4990         * breakpoint.h: Revert.
4991         * breakpoint.c: Revert.
4992         * break-catch-throw.c: Revert.
4993         * break-catch-syscall.c: Revert.
4994         * break-catch-sig.c: Revert.
4995         * blockframe.c: Revert.
4996         * block.c: Revert.
4997         * bfin-tdep.c: Revert.
4998         * bfin-linux-tdep.c: Revert.
4999         * bfd-target.c: Revert.
5000         * bcache.c: Revert.
5001         * ax-general.c: Revert.
5002         * ax-gdb.h: Revert.
5003         * ax-gdb.c: Revert.
5004         * avr-tdep.c: Revert.
5005         * auxv.c: Revert.
5006         * auto-load.c: Revert.
5007         * arm-wince-tdep.c: Revert.
5008         * arm-tdep.c: Revert.
5009         * arm-symbian-tdep.c: Revert.
5010         * arm-pikeos-tdep.c: Revert.
5011         * arm-obsd-tdep.c: Revert.
5012         * arm-nbsd-tdep.c: Revert.
5013         * arm-nbsd-nat.c: Revert.
5014         * arm-linux-tdep.c: Revert.
5015         * arm-linux-nat.c: Revert.
5016         * arm-fbsd-tdep.c: Revert.
5017         * arm-fbsd-nat.c: Revert.
5018         * arm-bsd-tdep.c: Revert.
5019         * arch-utils.c: Revert.
5020         * arc-tdep.c: Revert.
5021         * arc-newlib-tdep.c: Revert.
5022         * annotate.h: Revert.
5023         * annotate.c: Revert.
5024         * amd64-windows-tdep.c: Revert.
5025         * amd64-windows-nat.c: Revert.
5026         * amd64-tdep.c: Revert.
5027         * amd64-sol2-tdep.c: Revert.
5028         * amd64-obsd-tdep.c: Revert.
5029         * amd64-obsd-nat.c: Revert.
5030         * amd64-nbsd-tdep.c: Revert.
5031         * amd64-nbsd-nat.c: Revert.
5032         * amd64-nat.c: Revert.
5033         * amd64-linux-tdep.c: Revert.
5034         * amd64-linux-nat.c: Revert.
5035         * amd64-fbsd-tdep.c: Revert.
5036         * amd64-fbsd-nat.c: Revert.
5037         * amd64-dicos-tdep.c: Revert.
5038         * amd64-darwin-tdep.c: Revert.
5039         * amd64-bsd-nat.c: Revert.
5040         * alpha-tdep.c: Revert.
5041         * alpha-obsd-tdep.c: Revert.
5042         * alpha-nbsd-tdep.c: Revert.
5043         * alpha-mdebug-tdep.c: Revert.
5044         * alpha-linux-tdep.c: Revert.
5045         * alpha-linux-nat.c: Revert.
5046         * alpha-bsd-tdep.c: Revert.
5047         * alpha-bsd-nat.c: Revert.
5048         * aix-thread.c: Revert.
5049         * agent.c: Revert.
5050         * addrmap.c: Revert.
5051         * ada-varobj.c: Revert.
5052         * ada-valprint.c: Revert.
5053         * ada-typeprint.c: Revert.
5054         * ada-tasks.c: Revert.
5055         * ada-lang.c: Revert.
5056         * aarch64-tdep.c: Revert.
5057         * aarch64-ravenscar-thread.c: Revert.
5058         * aarch64-newlib-tdep.c: Revert.
5059         * aarch64-linux-tdep.c: Revert.
5060         * aarch64-linux-nat.c: Revert.
5061         * aarch64-fbsd-tdep.c: Revert.
5062         * aarch64-fbsd-nat.c: Revert.
5063         * aarch32-linux-nat.c: Revert.
5064
5065 2019-04-05  Tom Tromey  <tom@tromey.com>
5066
5067         * ft32-tdep.c: Sort headers.
5068         * frv-tdep.c: Sort headers.
5069         * frv-linux-tdep.c: Sort headers.
5070         * frame.c: Sort headers.
5071         * frame-unwind.c: Sort headers.
5072         * frame-base.c: Sort headers.
5073         * fork-child.c: Sort headers.
5074         * findvar.c: Sort headers.
5075         * findcmd.c: Sort headers.
5076         * filesystem.c: Sort headers.
5077         * filename-seen-cache.h: Sort headers.
5078         * filename-seen-cache.c: Sort headers.
5079         * fbsd-tdep.c: Sort headers.
5080         * fbsd-nat.h: Sort headers.
5081         * fbsd-nat.c: Sort headers.
5082         * f-valprint.c: Sort headers.
5083         * f-typeprint.c: Sort headers.
5084         * f-lang.c: Sort headers.
5085         * extension.h: Sort headers.
5086         * extension.c: Sort headers.
5087         * extension-priv.h: Sort headers.
5088         * expprint.c: Sort headers.
5089         * exec.h: Sort headers.
5090         * exec.c: Sort headers.
5091         * exceptions.c: Sort headers.
5092         * event-top.c: Sort headers.
5093         * event-loop.c: Sort headers.
5094         * eval.c: Sort headers.
5095         * elfread.c: Sort headers.
5096         * dwarf2read.h: Sort headers.
5097         * dwarf2read.c: Sort headers.
5098         * dwarf2loc.c: Sort headers.
5099         * dwarf2expr.h: Sort headers.
5100         * dwarf2expr.c: Sort headers.
5101         * dwarf2-frame.c: Sort headers.
5102         * dwarf2-frame-tailcall.c: Sort headers.
5103         * dwarf-index-write.h: Sort headers.
5104         * dwarf-index-write.c: Sort headers.
5105         * dwarf-index-common.c: Sort headers.
5106         * dwarf-index-cache.h: Sort headers.
5107         * dwarf-index-cache.c: Sort headers.
5108         * dummy-frame.c: Sort headers.
5109         * dtrace-probe.c: Sort headers.
5110         * disasm.h: Sort headers.
5111         * disasm.c: Sort headers.
5112         * disasm-selftests.c: Sort headers.
5113         * dictionary.c: Sort headers.
5114         * dicos-tdep.c: Sort headers.
5115         * demangle.c: Sort headers.
5116         * dcache.h: Sort headers.
5117         * dcache.c: Sort headers.
5118         * darwin-nat.h: Sort headers.
5119         * darwin-nat.c: Sort headers.
5120         * darwin-nat-info.c: Sort headers.
5121         * d-valprint.c: Sort headers.
5122         * d-namespace.c: Sort headers.
5123         * d-lang.c: Sort headers.
5124         * ctf.c: Sort headers.
5125         * csky-tdep.c: Sort headers.
5126         * csky-linux-tdep.c: Sort headers.
5127         * cris-tdep.c: Sort headers.
5128         * cris-linux-tdep.c: Sort headers.
5129         * cp-valprint.c: Sort headers.
5130         * cp-support.c: Sort headers.
5131         * cp-namespace.c: Sort headers.
5132         * cp-abi.c: Sort headers.
5133         * corelow.c: Sort headers.
5134         * corefile.c: Sort headers.
5135         * continuations.c: Sort headers.
5136         * completer.h: Sort headers.
5137         * completer.c: Sort headers.
5138         * complaints.c: Sort headers.
5139         * coffread.c: Sort headers.
5140         * coff-pe-read.c: Sort headers.
5141         * cli-out.h: Sort headers.
5142         * cli-out.c: Sort headers.
5143         * charset.c: Sort headers.
5144         * c-varobj.c: Sort headers.
5145         * c-valprint.c: Sort headers.
5146         * c-typeprint.c: Sort headers.
5147         * c-lang.c: Sort headers.
5148         * buildsym.c: Sort headers.
5149         * buildsym-legacy.c: Sort headers.
5150         * build-id.h: Sort headers.
5151         * build-id.c: Sort headers.
5152         * btrace.c: Sort headers.
5153         * bsd-uthread.c: Sort headers.
5154         * breakpoint.h: Sort headers.
5155         * breakpoint.c: Sort headers.
5156         * break-catch-throw.c: Sort headers.
5157         * break-catch-syscall.c: Sort headers.
5158         * break-catch-sig.c: Sort headers.
5159         * blockframe.c: Sort headers.
5160         * block.c: Sort headers.
5161         * bfin-tdep.c: Sort headers.
5162         * bfin-linux-tdep.c: Sort headers.
5163         * bfd-target.c: Sort headers.
5164         * bcache.c: Sort headers.
5165         * ax-general.c: Sort headers.
5166         * ax-gdb.h: Sort headers.
5167         * ax-gdb.c: Sort headers.
5168         * avr-tdep.c: Sort headers.
5169         * auxv.c: Sort headers.
5170         * auto-load.c: Sort headers.
5171         * arm-wince-tdep.c: Sort headers.
5172         * arm-tdep.c: Sort headers.
5173         * arm-symbian-tdep.c: Sort headers.
5174         * arm-pikeos-tdep.c: Sort headers.
5175         * arm-obsd-tdep.c: Sort headers.
5176         * arm-nbsd-tdep.c: Sort headers.
5177         * arm-nbsd-nat.c: Sort headers.
5178         * arm-linux-tdep.c: Sort headers.
5179         * arm-linux-nat.c: Sort headers.
5180         * arm-fbsd-tdep.c: Sort headers.
5181         * arm-fbsd-nat.c: Sort headers.
5182         * arm-bsd-tdep.c: Sort headers.
5183         * arch-utils.c: Sort headers.
5184         * arc-tdep.c: Sort headers.
5185         * arc-newlib-tdep.c: Sort headers.
5186         * annotate.h: Sort headers.
5187         * annotate.c: Sort headers.
5188         * amd64-windows-tdep.c: Sort headers.
5189         * amd64-windows-nat.c: Sort headers.
5190         * amd64-tdep.c: Sort headers.
5191         * amd64-sol2-tdep.c: Sort headers.
5192         * amd64-obsd-tdep.c: Sort headers.
5193         * amd64-obsd-nat.c: Sort headers.
5194         * amd64-nbsd-tdep.c: Sort headers.
5195         * amd64-nbsd-nat.c: Sort headers.
5196         * amd64-nat.c: Sort headers.
5197         * amd64-linux-tdep.c: Sort headers.
5198         * amd64-linux-nat.c: Sort headers.
5199         * amd64-fbsd-tdep.c: Sort headers.
5200         * amd64-fbsd-nat.c: Sort headers.
5201         * amd64-dicos-tdep.c: Sort headers.
5202         * amd64-darwin-tdep.c: Sort headers.
5203         * amd64-bsd-nat.c: Sort headers.
5204         * alpha-tdep.c: Sort headers.
5205         * alpha-obsd-tdep.c: Sort headers.
5206         * alpha-nbsd-tdep.c: Sort headers.
5207         * alpha-mdebug-tdep.c: Sort headers.
5208         * alpha-linux-tdep.c: Sort headers.
5209         * alpha-linux-nat.c: Sort headers.
5210         * alpha-bsd-tdep.c: Sort headers.
5211         * alpha-bsd-nat.c: Sort headers.
5212         * aix-thread.c: Sort headers.
5213         * agent.c: Sort headers.
5214         * addrmap.c: Sort headers.
5215         * ada-varobj.c: Sort headers.
5216         * ada-valprint.c: Sort headers.
5217         * ada-typeprint.c: Sort headers.
5218         * ada-tasks.c: Sort headers.
5219         * ada-lang.c: Sort headers.
5220         * aarch64-tdep.c: Sort headers.
5221         * aarch64-ravenscar-thread.c: Sort headers.
5222         * aarch64-newlib-tdep.c: Sort headers.
5223         * aarch64-linux-tdep.c: Sort headers.
5224         * aarch64-linux-nat.c: Sort headers.
5225         * aarch64-fbsd-tdep.c: Sort headers.
5226         * aarch64-fbsd-nat.c: Sort headers.
5227         * aarch32-linux-nat.c: Sort headers.
5228
5229 2019-04-04  Tom Tromey  <tom@tromey.com>
5230
5231         * varobj.c (varobj_create): Update.
5232         * rust-exp.y (struct rust_parser) <update_innermost_block,
5233         lookup_symbol>: New methods.
5234         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5235         Rename.
5236         (rust_parser::rust_lookup_type)
5237         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5238         * printcmd.c (display_command, do_one_display): Update.
5239         * parser-defs.h (struct parser_state) <parser_state>: Add
5240         "tracker" parameter.
5241         (block_tracker): New member.
5242         (class innermost_block_tracker) <innermost_block_tracker>: Add
5243         "types" parameter.
5244         <reset>: Remove method.
5245         (innermost_block): Don't declare.
5246         (null_post_parser): Update.
5247         * parse.c (innermost_block): Remove global.
5248         (write_dollar_variable): Update.
5249         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5250         Remove "tracker_types" parameter.
5251         (parse_expression): Add "tracker" parameter.
5252         (parse_expression_for_completion): Update.
5253         (null_post_parser): Add "tracker" parameter.
5254         * p-exp.y: Update rules.
5255         * m2-exp.y: Update rules.
5256         * language.h (struct language_defn) <la_post_parser>: Add
5257         "tracker" parameter.
5258         * go-exp.y: Update rules.
5259         * f-exp.y: Update rules.
5260         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5261         parameter.
5262         * d-exp.y: Update rules.
5263         * c-exp.y: Update rules.
5264         * breakpoint.c (set_breakpoint_condition): Create an
5265         innermost_block_tracker.
5266         (watch_command_1): Likewise.
5267         * ada-lang.c (resolve): Add "tracker" parameter.
5268         (resolve_subexp): Likewise.
5269         * ada-exp.y (write_var_from_sym): Update.
5270
5271 2019-04-04  Tom Tromey  <tom@tromey.com>
5272
5273         * type-stack.h: New file.
5274         * type-stack.c: New file.
5275         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5276         type-stack.h.
5277         (insert_into_type_stack, insert_type, push_type, push_type_int)
5278         (insert_type_address_space, pop_type, pop_type_int)
5279         (pop_typelist, pop_type_stack, append_type_stack)
5280         (push_type_stack, get_type_stack, push_typelist)
5281         (follow_type_instance_flags, follow_types): Don't declare.
5282         * parse.c (type_stack): Remove global.
5283         (parse_exp_in_context): Update.
5284         (insert_into_type_stack, insert_type, push_type, push_type_int)
5285         (insert_type_address_space, pop_type, pop_type_int)
5286         (pop_typelist, pop_type_stack, append_type_stack)
5287         (push_type_stack, get_type_stack, push_typelist)
5288         (follow_type_instance_flags, follow_types): Remove (moved to
5289         type-stack.c).
5290         * f-exp.y (type_stack): New global.
5291         Update rules.
5292         (push_kind_type, f_parse): Update.
5293         * d-exp.y (type_stack): New global.
5294         Update rules.
5295         (d_parse): Update.
5296         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5297         Update rules.
5298         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5299         (HFILES_NO_SRCDIR): Add type-stack.h.
5300
5301 2019-04-04  Tom Tromey  <tom@tromey.com>
5302
5303         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5304         (rust_parser::convert_ast_to_expression, rust_parse)
5305         (rust_lex_test_completion, rust_lex_tests): Update.
5306         * parser-defs.h (struct expr_completion_state): New.
5307         (struct parser_state) <parser_state>: Add completion parameter.
5308         <mark_struct_expression, mark_completion_tag>: New methods.
5309         <parse_completion, m_completion_state>: New members.
5310         (prefixify_expression, null_post_parser): Update.
5311         (mark_struct_expression, mark_completion_tag): Don't declare.
5312         * parse.c (parse_completion, expout_last_struct)
5313         (expout_tag_completion_type, expout_completion_name): Remove
5314         globals.
5315         (parser_state::mark_struct_expression)
5316         (parser_state::mark_completion_tag): Now methods.
5317         (prefixify_expression): Add last_struct parameter.
5318         (prefixify_subexp): Likewise.
5319         (parse_exp_1): Update.
5320         (parse_exp_in_context): Add cstate parameter.  Update.
5321         (parse_expression_for_completion): Create an
5322         expr_completion_state.
5323         (null_post_parser): Add "completion" parameter.
5324         * p-exp.y: Update rules.
5325         (yylex): Update.
5326         * language.h (struct language_defn) <la_post_parser>: Add
5327         "completing" parameter.
5328         * go-exp.y: Update rules.
5329         (lex_one_token): Update.
5330         * expression.h (parse_completion): Don't declare.
5331         * d-exp.y: Update rules.
5332         (lex_one_token): Update rules.
5333         * c-exp.y: Update rules.
5334         (lex_one_token): Update.
5335         * ada-lang.c (resolve): Add "parse_completion" parameter.
5336         (resolve_subexp): Likewise.
5337         (ada_resolve_function): Likewise.
5338
5339 2019-04-04  Tom Tromey  <tom@tromey.com>
5340
5341         * parser-defs.h (struct parser_state) <start_arglist,
5342         end_arglist>: New methods.
5343         <arglist_len, m_funcall_chain>: New members.
5344         (arglist_len, start_arglist, end_arglist): Don't declare.
5345         * parse.c (arglist_len, funcall_chain): Remove global.
5346         (start_arglist, end_arglist): Remove functions.
5347         (parse_exp_in_context): Update.
5348         * p-exp.y: Update rules.
5349         * m2-exp.y: Update rules.
5350         * go-exp.y: Update rules.
5351         * f-exp.y: Update rules.
5352         * d-exp.y: Update rules.
5353         * c-exp.y: Update rules.
5354
5355 2019-04-04  Tom Tromey  <tom@tromey.com>
5356
5357         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5358         lex_operator, push_back>: New methods.
5359         Update all rules.
5360         (rust_parser::lex_hex, lex_escape): Rename and update.
5361         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5362         (rust_parser::lex_operator): Rename and update.
5363         (rust_parser::lex_number, rustyylex, rustyyerror)
5364         (rust_lex_test_init, rust_lex_test_sequence)
5365         (rust_lex_test_push_back, rust_lex_tests): Update.
5366         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5367         parameter.
5368         <lexptr, prev_lexptr>: New members.
5369         (lexptr, prev_lexptr): Don't declare.
5370         * parse.c (lexptr, prev_lexptr): Remove globals.
5371         (parse_exp_in_context): Update.
5372         * p-exp.y (yylex, yyerror): Update.
5373         * m2-exp.y (parse_number, yylex, yyerror): Update.
5374         * go-exp.y (lex_one_token, yyerror): Update.
5375         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5376         * d-exp.y (lex_one_token, yyerror): Update.
5377         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5378         (lex_one_token, yyerror): Update.
5379         * ada-lex.l (YY_INPUT): Update.
5380         (rewind_to_char): Update.
5381         * ada-exp.y (yyerror): Update.
5382
5383 2019-04-04  Tom Tromey  <tom@tromey.com>
5384
5385         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5386         * parser-defs.h (struct parser_state) <parser_state>: Add new
5387         parameter.
5388         <comma_terminates>: New member.
5389         (comma_terminates): Don't declare global.
5390         * parse.c (comma_terminates): Remove global.
5391         (parse_exp_in_context): Update.
5392         * p-exp.y (yylex): Update.
5393         * m2-exp.y (yylex): Update.
5394         * go-exp.y (lex_one_token): Update.
5395         * f-exp.y (yylex): Update.
5396         * d-exp.y (lex_one_token): Update.
5397         * c-exp.y (lex_one_token): Update.
5398         * ada-lex.l: Update.
5399
5400 2019-04-04  Tom Tromey  <tom@tromey.com>
5401
5402         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5403         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5404         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5405         * parser-defs.h (paren_depth): Don't declare.
5406         * parse.c (paren_depth): Remove global.
5407         (parse_exp_in_context): Update.
5408         * p-exp.y (paren_depth): New global.
5409         (pascal_parse): Initialize it.
5410         * m2-exp.y (paren_depth): New global.
5411         (m2_parse): Initialize it.
5412         * go-exp.y (paren_depth): New global.
5413         (go_parse): Initialize it.
5414         * f-exp.y (paren_depth): New global.
5415         (f_parse): Initialize it.
5416         * d-exp.y (paren_depth): New global.
5417         (d_parse): Initialize it.
5418         * c-exp.y (paren_depth): New global.
5419         (c_parse): Initialize it.
5420         * ada-lex.l (paren_depth): New global.
5421         (lexer_init): Initialize it.
5422
5423 2019-04-04  Tom Tromey  <tom@tromey.com>
5424
5425         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5426         (rust_parser::convert_ast_to_type)
5427         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5428         * parser-defs.h (struct parser_state) <parser_state>: Add
5429         parameters.  Initialize new members.
5430         <expression_context_block, expression_context_pc>: New members.
5431         * parse.c (expression_context_block, expression_context_pc):
5432         Remove globals.
5433         (parse_exp_in_context): Update.
5434         * p-exp.y: Update all rules.
5435         (yylex): Update.
5436         * m2-exp.y: Update all rules.
5437         (yylex): Update.
5438         * go-exp.y (yylex): Update.
5439         * f-exp.y (yylex): Update.
5440         * d-exp.y: Update all rules.
5441         (yylex): Update.
5442         * c-exp.y: Update all rules.
5443         (lex_one_token, classify_name, yylex, c_parse): Update.
5444         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5445
5446 2019-04-04  Tom Tromey  <tom@tromey.com>
5447
5448         * gdbarch.h, gdbarch.c: Rebuild.
5449         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5450         * stap-probe.h: 
5451         (struct stap_parse_info): Replace "parser_state" with
5452         "expr_builder".
5453         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5454         (parser_state): New class.
5455         * parse.c (expr_builder): Rename.
5456         (expr_builder::release): Rename.
5457         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5458         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5459         (write_exp_elt_longcst, write_exp_elt_floatcst)
5460         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5461         (write_exp_string_vector, write_exp_bitstring)
5462         (write_exp_msymbol, mark_struct_expression)
5463         (write_dollar_variable)
5464         (insert_type_address_space, increase_expout_size): Replace
5465         "parser_state" with "expr_builder".
5466         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5467         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5468         "parser_state" with "expr_builder".
5469
5470 2019-04-04  Tom Tromey  <tom@tromey.com>
5471
5472         * rust-exp.y: Replace "parse_language" with method call.
5473         * p-exp.y: 
5474         (yylex): Replace "parse_language" with method call.
5475         * m2-exp.y: 
5476         (yylex): Replace "parse_language" with method call.
5477         * go-exp.y (classify_name): Replace "parse_language" with method
5478         call.
5479         * f-exp.y (yylex): Replace "parse_language" with method call.
5480         * d-exp.y (lex_one_token): Replace "parse_language" with method
5481         call.
5482         * c-exp.y: 
5483         (lex_one_token, classify_name, yylex): Replace "parse_language"
5484         with method call.
5485         * ada-exp.y (find_primitive_type, type_char)
5486         (type_system_address): Replace "parse_language" with method call.
5487
5488 2019-04-04  Tom Tromey  <tom@tromey.com>
5489
5490         * rust-exp.y: Replace "parse_gdbarch" with method call.
5491         * parse.c (write_dollar_variable, insert_type_address_space):
5492         Replace "parse_gdbarch" with method call.
5493         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5494         call.
5495         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5496         call.
5497         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5498         "parse_gdbarch" with method call.
5499         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5500         with method call.
5501         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5502         "parse_gdbarch" with method call.
5503         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5504         "parse_gdbarch" with method call.
5505         * c-exp.y (parse_type, parse_number, classify_name): Replace
5506         "parse_gdbarch" with method call.
5507         * ada-lex.l: Replace "parse_gdbarch" with method call.
5508         * ada-exp.y (parse_type, find_primitive_type, type_char)
5509         (type_system_address): Replace "parse_gdbarch" with method call.
5510
5511 2019-04-04  Tom Tromey  <tom@tromey.com>
5512
5513         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5514         * stap-probe.c (stap_parse_argument): Update.
5515         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5516         initial_size parameter.
5517         * rust-exp.y (rust_lex_tests): Update.
5518         * parse.c (parser_state): Update.
5519         (parse_exp_in_context): Update.
5520         * parser-defs.h (struct parser_state) <parser_state>: Remove
5521         "initial_size" parameter.
5522
5523 2019-04-04  Tom Tromey  <tom@tromey.com>
5524
5525         * parser-defs.h (increase_expout_size): Don't declare.
5526         * parse.c (increase_expout_size): Now static.
5527
5528 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5529
5530         * gnu-nat.c (gnu_nat_target::wait): Fix
5531         target_waitstatus_to_string call.
5532
5533 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5534
5535         * eval.c (evaluate_subexp_standard): Handle internal functions
5536         during Fortran function call handling.
5537
5538 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5539
5540         * NEWS: Mention new internal functions.
5541         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5542         (read_base_type): Use dwarf2_init_complex_target_type.
5543         * value.c (creal_internal_fn): New function.
5544         (cimag_internal_fn): New function.
5545         (_initialize_values): Register new internal functions.
5546
5547 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5548
5549         * infrun.c (stop_all_threads): If debug_infrun, always
5550         trace the wait status after wait_one, using
5551         target_waitstatus_to_string and target_pid_to_str.
5552         (handle_inferior_event): Replace various trace of
5553         wait status kind by a single trace.
5554         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5555         wait status kind image by target_waitstatus_to_string.
5556         * target/waitstatus.c (target_waitstatus_to_string): Fix
5557         obsolete comment.
5558
5559 2019-04-01  Tom Tromey  <tromey@adacore.com>
5560
5561         PR symtab/23331:
5562         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5563
5564 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5565             Pedro Alves  <palves@redhat.com>
5566
5567         * top.c (quit_force): Call 'finalize_values'.
5568         * value.c (finalize_values): New function.
5569         * value.h (finalize_values): Declare.
5570
5571 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5572
5573         * NEWS: Announce $_gdb_major and $_gdb_minor.
5574
5575         * top.c (init_gdb_version_vars): New function.
5576         (gdb_init): Call init_gdb_version_vars.
5577
5578 2019-03-29  Tom Tromey  <tromey@adacore.com>
5579
5580         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5581         help text.  Remove dead code.
5582
5583 2019-03-29  Keith Seitz  <keiths@redhat.com>
5584
5585         From Siddhesh Poyarekar:
5586         * f-lang.h (f77_get_upperbound): Return LONGEST.
5587         (f77_get_lowerbound): Likewise.
5588         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5589         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5590         print them.
5591         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5592         plongest to format print it.
5593         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5594         (f77_get_upperbound): Likewise.
5595         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5596         LOWER_BOUND to LONGEST.
5597         (f77_create_arrayprint_offset_tbl): Likewise.
5598
5599 2019-03-29  Keith Seitz  <keiths@redhat.com>
5600
5601         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5602         %s/pulongest for TYPE_LENGTH instead of %d in format
5603         strings.
5604         * ada-typerint.c (ada_print_type): Likewise.
5605         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5606         * compile/compile-c-support.c (generate_register_struct): Likewise.
5607         * gdbtypes.c (recursive_dump_type): Likewise.
5608         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5609         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5610         instead of %d in format strings.
5611         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5612         to std::min to ULONGEST.
5613         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5614         instead of %d in format strings.
5615         * tracepoint.c (info_scope_command): Likewise.
5616         * typeprint.c (print_offset_data::update)
5617         (print_offset_data::finish): Likewise.
5618         * xtensa-tdep.c (xtensa_store_return_value)
5619         (xtensa_push_dummy_call): Likewise.
5620
5621 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5622
5623         * windows-nat.c (display_selector): Fixed format specifications
5624         for 64-bit Cygwin.
5625
5626 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5627
5628         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5629
5630 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5631
5632         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5633         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5634         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5635         (nios2_linux_init_abi): Install it.
5636
5637 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5638
5639         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5640
5641 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5642
5643         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5644
5645 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5646             Tom Tromey  <tromey@adacore.com>
5647
5648         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5649
5650 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5651
5652         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5653         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5654         method to compute the bounds of range types. Also print "[evaluated]"
5655         if the bounds' values come from a dynamic evaluation.
5656
5657 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5658
5659         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5660         whitespace when pretty printing is on.
5661
5662 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5663
5664         * ppc-linux-nat.c: Add include.
5665
5666 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5667
5668         * NEWS: Mention AArch64 Pointer Authentication.
5669
5670 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5671
5672         * arm-linux-nat.c: Add include.
5673
5674 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5675
5676         * source-cache.c (source_cache::get_source_lines): Re-read
5677         fullname after calling open_source_file.
5678
5679 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5680
5681         * NEWS: Mention TLS support for FreeBSD.
5682
5683 2019-03-25  Tom Tromey  <tromey@adacore.com>
5684
5685         * minsyms.c (BUNCH_SIZE): Update comment.
5686         (~minimal_symbol_reader): Remove old comment.
5687         (compact_minimal_symbols): Update comment.
5688         (minimal_symbol_reader::install): Remove old comment.  Update
5689         other comments.
5690
5691 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5692
5693         * s390-linux-nat.c: Add include.
5694
5695 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5696
5697         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5698         Call linux_get_hwcap.
5699         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5700         Likewise.
5701         (aarch64_linux_get_hwcap): Remove function.
5702         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5703         declaration.
5704         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5705         linux_get_hwcap.
5706         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5707         * linux-tdep.c (linux_get_hwcap): Add function.
5708         (linux_get_hwcap2): Likewise.
5709         * linux-tdep.h (linux_get_hwcap): Add declaration.
5710         (linux_get_hwcap2): Likewise.
5711         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5712         (ppc_linux_get_hwcap2): Likewise.
5713         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5714         linux_get_hwcap.
5715         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5716         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5717         (ppc_linux_nat_target::read_description): Likewise.
5718         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5719         * s390-linux-nat.c: Likewise.
5720         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5721
5722 2019-03-24  Tom Tromey  <tom@tromey.com>
5723
5724         * ada-lang.c (standard_lookup): Simplify initialization.
5725         (ada_lookup_symbol_nonlocal): Simplify return.
5726         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5727         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5728         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5729         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5730         initialization.
5731         * solib.c (solib_global_lookup): Simplify.
5732         * symtab.c (null_block_symbol): Remove.
5733         (symbol_cache_lookup): Simplify returns.
5734         (lookup_language_this): Simplify returns.
5735         (lookup_symbol_aux): Simplify return.
5736         (lookup_local_symbol): Simplify returns.
5737         (lookup_global_symbol_from_objfile): Simplify return.
5738         (lookup_symbol_in_objfile_symtabs)
5739         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5740         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5741         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5742         * cp-namespace.c (cp_lookup_bare_symbol)
5743         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5744         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5745         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5746         (cp_lookup_symbol_via_imports): Simplify initialization.
5747         (find_symbol_in_baseclass): Likewise.
5748         * symtab.h (null_block_symbol): Remove.
5749         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5750         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5751         (d_lookup_symbol_module): Likewise.
5752         (find_symbol_in_baseclass): Simplify initialization.
5753
5754 2019-03-24  Tom Tromey  <tom@tromey.com>
5755
5756         * expression.h: Don't include symtab.h.
5757         (struct block): Forward declare.
5758
5759 2019-03-24  Tom Tromey  <tom@tromey.com>
5760
5761         * c-exp.y (typebase): Remove casts.
5762         * gdbtypes.c (lookup_unsigned_typename, )
5763         (lookup_signed_typename): Remove cast.
5764         * eval.c (parse_to_comma_and_eval): Remove cast.
5765         * parse.c (write_dollar_variable): Remove cast.
5766         * block.h (struct block) <superblock>: Now const.
5767         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5768         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5769         (map_block): Make "block" const.
5770         * symfile.h (struct quick_symbol_functions)
5771         <map_matching_symbols>: Constify block argument to "callback".
5772         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5773         const.
5774         (find_pc_sect_compunit_symtab): Make "b" const.
5775         (find_symbol_at_address): Likewise.
5776         (search_symbols): Likewise.
5777         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5778         (dw2_debug_names_lookup_symbol): Likewise.
5779         (dw2_map_matching_symbols): Update.
5780         * p-valprint.c (pascal_val_print): Remove "block".
5781         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5782         (aux_add_nonlocal_symbols): Make "block" const.
5783         (resolve_subexp): Remove cast.
5784         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5785         const.
5786         (iterate_over_file_blocks): Likewise.
5787         * f-exp.y (%union) <bval>: Remove.
5788         * coffread.c (patch_opaque_types): Make "b" const.
5789         * spu-tdep.c (spu_catch_start): Make "block" const.
5790         * c-valprint.c (print_unpacked_pointer): Remove "block".
5791         * symmisc.c (dump_symtab_1): Make "b" const.
5792         (block_depth): Make "block" const.
5793         * d-exp.y (%union) <bval>: Remove.
5794         * cp-support.h (cp_lookup_rtti_type): Update.
5795         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5796         * psymtab.c (psym_lookup_symbol): Make "block" const.
5797         (maintenance_check_psymtabs): Make "b" const.
5798         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5799         (enumerate_locals, enumerate_args): Update.
5800         * python/py-symtab.c (stpy_global_block): Make "block" const.
5801         (stpy_static_block): Likewise.
5802         * inline-frame.c (block_starting_point_at): Make "new_block"
5803         const.
5804         * block.c (find_block_in_blockvector): Make return type const.
5805         (blockvector_for_pc_sect): Make "b" const.
5806         (find_block_in_blockvector): Make "b" const.
5807
5808 2019-03-23  Tom Tromey  <tom@tromey.com>
5809
5810         * varobj.c (varobj_create): Update.
5811         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5812         * printcmd.c (display_command, do_one_display): Don't reset
5813         innermost_block.
5814         * parser-defs.h (enum innermost_block_tracker_type): Move to
5815         expression.h.
5816         (innermost_block): Update comment.
5817         * parse.c (parse_exp_1): Add tracker_types parameter.
5818         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5819         tracker_types parameter.  Reset innermost_block.
5820         (parse_exp_in_context): Remove.
5821         (parse_expression_for_completion): Update.
5822         * objfiles.c (~objfile): Don't reset expression_context_block or
5823         innermost_block.
5824         * expression.h (enum innermost_block_tracker_type): Move from
5825         parser-defs.h.
5826         (parse_exp_1): Add tracker_types parameter.
5827         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5828         reset innermost_block.
5829
5830 2019-03-23  Tom Tromey  <tom@tromey.com>
5831
5832         * objfiles.h: Include bcache.h.
5833
5834 2019-03-23  Tom Tromey  <tom@tromey.com>
5835
5836         * linespec.c (get_current_search_block): Use
5837         scoped_restore_current_language.
5838         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5839
5840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5841             Jiong Wang  <jiong.wang@arm.com>
5842
5843         * aarch64-linux-tdep.c
5844         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5845         section.
5846         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5847
5848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5849             Jiong Wang  <jiong.wang@arm.com>
5850
5851         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5852         instructions.
5853         (aarch64_analyze_prologue_test): Add PACIASP test.
5854         (aarch64_prologue_prev_register): Unmask PC value.
5855
5856 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5857             Jiong Wang  <jiong.wang@arm.com>
5858
5859         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5860         (aarch64_dwarf2_prev_register): Unmask PC value.
5861         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5862         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5863         DW_CFA_AARCH64_negate_ra_state.
5864         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5865
5866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5867             Jiong Wang  <jiong.wang@arm.com>
5868
5869         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5870         registers.
5871         (aarch64_pseudo_register_name): Likewise.
5872         (aarch64_pseudo_register_type): Likewise.
5873         (aarch64_pseudo_register_reggroup_p): Likewise.
5874         (aarch64_gdbarch_init): Add pauth registers.
5875         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5876         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5877         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5878         (struct gdbarch_tdep): Add regnum for ra_state.
5879
5880 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5881             Jiong Wang  <jiong.wang@arm.com>
5882
5883         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5884
5885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5886             Jiong Wang  <jiong.wang@arm.com>
5887
5888         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5889         function.
5890         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5891         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5892         (aarch64_gdbarch_init): Add puth registers.
5893         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5894         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5895         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5896
5897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5898             Jiong Wang  <jiong.wang@arm.com>
5899
5900         * aarch64-linux-nat.c
5901         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5902         * aarch64-linux-tdep.c
5903         (aarch64_linux_core_read_description): Likewise.
5904         (aarch64_linux_get_hwcap): New function.
5905         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5906         (aarch64_linux_get_hwcap): New declaration.
5907
5908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5909             Jiong Wang  <jiong.wang@arm.com>
5910
5911         * aarch64-linux-nat.c
5912         (aarch64_linux_nat_target::read_description): Add pauth param.
5913         * aarch64-linux-tdep.c
5914         (aarch64_linux_core_read_description): Likewise.
5915         * aarch64-tdep.c (struct target_desc): Add in pauth.
5916         (aarch64_read_description): Add pauth param.
5917         (aarch64_gdbarch_init): Likewise.
5918         * aarch64-tdep.h (aarch64_read_description): Likewise.
5919         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5920         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5921         * features/Makefile: Add new files.
5922         * features/aarch64-pauth.c: New file.
5923         * features/aarch64-pauth.xml: New file.
5924
5925 2019-03-20  Tom Tromey  <tromey@adacore.com>
5926
5927         * infrun.c (handle_inferior_event): Rename from
5928         handle_inferior_event_1.  Create a scoped_value_mark.
5929         (handle_inferior_event): Remove.
5930
5931 2019-03-19  Tom Tromey  <tromey@adacore.com>
5932
5933         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5934         * infrun.h (print_stop_event): Add "displays" parameter.
5935         * infrun.c (print_stop_event): Add "displays" parameter.
5936
5937 2019-03-19  Pedro Alves  <palves@redhat.com>
5938
5939         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5940         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5941         to -1.  Fix TABs vs spaces.
5942         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5943         * tui/tui-out.h (tui_ui_out) Add intro comments.
5944         <m_line, m_start_of_line>: In-class initialize, and add describing
5945         comment.
5946
5947 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5948
5949         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5950         variable names.
5951         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5952
5953 2019-03-18  Pedro Alves  <palves@redhat.com>
5954             Eli Zaretskii <eliz@gnu.org>
5955
5956         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5957         m_line and m_start_of_line.
5958
5959 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5960
5961         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5962         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5963         it returns a newline.  This fixes a regression in TU mode, whereby
5964         the next line is output on the same screen line as the user input.
5965
5966 2019-03-18  Tom Tromey  <tromey@adacore.com>
5967
5968         * minsyms.c (minimal_symbol_reader::install): Remove call to
5969         obstack_blank.
5970
5971 2019-03-18  Pedro Alves  <palves@redhat.com>
5972
5973         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5974         New globals.
5975         (apply_style): New, factored out from ...
5976         (apply_ansi_escape): ... this.  Handle reverse video mode.
5977         (tui_set_reverse_mode): New function.
5978         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5979         * tui/tui-winsource.c (tui_show_source_line): Use
5980         tui_set_reverse_mode instead of setting A_STANDOUT.
5981         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5982         New setter methods.
5983
5984 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5985
5986         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5987         Handle tabs.
5988
5989 2019-03-18  Tom Tromey  <tromey@adacore.com>
5990
5991         * ada-lang.c (empty_array): Add "high" parameter.
5992         (ada_evaluate_subexp): Update.
5993
5994 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5995
5996         * unittests/string_view-selftests.c: Define
5997         _initialize_string_view_selftests unconditionally.
5998
5999 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6000
6001         PR gdb/24350
6002         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6003
6004 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6005
6006         PR gdb/24351
6007         * windows-nat.c (display_selector): Fix format specifiers.
6008
6009 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6010
6011         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6012         tui_refill_source_window instead of tui_refresh_win, to update the
6013         current execution line.  This fixes redisplay of the current line
6014         when stepping through the code with "next" or "step".
6015
6016 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6017
6018         * source-cache.c (source_cache::get_source_lines): Call
6019         find_source_lines to initialize s->nlines.  This fixes vertical
6020         scrolling of TUI source window when the DOWN arrow is pressed.
6021
6022 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6023
6024         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6025         linux-thread-db.c (_initialize_thread_db): Likewise.
6026
6027 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6028
6029         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6030         wclrtoeol in tui_show_source_line".  This reverts changes made in
6031         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6032
6033 2019-03-15  Tom Tromey  <tom@tromey.com>
6034
6035         * symtab.h (struct minimal_symbol): Derive from
6036         general_symbol_info.
6037         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6038         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6039         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6040         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6041         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6042         (MSYMBOL_SEARCH_NAME): Update.
6043         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6044         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6045         * minsyms.c (minimal_symbol_reader::record_full): Update.
6046
6047 2019-03-15  Tom Tromey  <tom@tromey.com>
6048
6049         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6050
6051 2019-03-15  Tom Tromey  <tom@tromey.com>
6052
6053         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6054         unique_xmalloc_ptr.
6055         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6056         Update.
6057         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6058         (build_minimal_symbol_hash_tables)
6059         (minimal_symbol_reader::install): Update.
6060
6061 2019-03-15  Tom Tromey  <tom@tromey.com>
6062
6063         * symtab.c (create_demangled_names_hash): Update.
6064         (symbol_set_names): Update.
6065         * objfiles.h (struct objfile_per_bfd_storage)
6066         <demangled_names_hash>: Now an htab_up.
6067         * objfiles.c (objfile_per_bfd_storage): Simplify.
6068
6069 2019-03-15  Tom Tromey  <tom@tromey.com>
6070
6071         * objfiles.h (struct objfile_per_bfd_storage): Declare
6072         destructor.
6073         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6074         New.
6075         (get_objfile_bfd_data): Use new.  Don't initialize
6076         language_of_main.
6077         (free_objfile_per_bfd_storage): Remove.
6078         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6079
6080 2019-03-15  Tom Tromey  <tom@tromey.com>
6081
6082         * symfile.c (reread_symbols): Update.
6083         * objfiles.c (objfile::objfile): Update.
6084         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6085         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6086         comment.
6087         (minimal_symbol_reader::install): Update.
6088         (terminate_minimal_symbol_table): Remove.
6089         * jit.c (jit_object_close_impl): Update.
6090
6091 2019-03-15  Tom Tromey  <tom@tromey.com>
6092
6093         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6094         initializations.
6095
6096 2019-03-15  Tom Tromey  <tom@tromey.com>
6097
6098         * objfiles.h (struct objfile_per_bfd_storage)
6099         <demangled_hash_languages>: Now a bitset.
6100         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6101         (lookup_minimal_symbol): Update.
6102
6103 2019-03-15  Tom Tromey  <tom@tromey.com>
6104
6105         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6106         Don't return the symbol.
6107         * coffread.c (record_minimal_symbol): Use record_full.
6108
6109 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6110
6111         The MS-Windows port of ncurses fails to switch to a color pair if
6112         one or both of the colors are the implicit default colors.  This
6113         change records the default colors when TUI is initialized, and
6114         then specifies them explicitly when a color pair uses the default
6115         colors.  This allows color styling in TUI mode on MS-Windows.
6116
6117         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6118         ncurses_norm_attr.
6119         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6120         colors in ncurses_norm_attr.
6121         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6122         "none", replace it with the default color recorded in
6123         ncurses_norm_attr.
6124
6125 2019-03-14  Tom Tromey  <tromey@adacore.com>
6126
6127         * source-cache.h (class source_cache) <get_source_lines>: Return
6128         std::string.
6129         * source-cache.c (source_cache::extract_lines): Handle case where
6130         first_pos==npos.  Return std::string.
6131         (source_cache::get_source_lines): Update.
6132
6133 2019-03-14  Tom Tromey  <tromey@adacore.com>
6134
6135         * NEWS: Add item for "style sources" commands.
6136         * source-cache.c (source_cache::get_source_lines): Check
6137         source_styling.
6138         * cli/cli-style.c (source_styling): New global.
6139         (_initialize_cli_style): Add "style sources" commands.
6140         (show_style_sources): New function.
6141         * cli/cli-style.h (source_styling): Declare.
6142
6143 2019-03-14  Pedro Alves  <palves@redhat.com>
6144             Tom Tromey  <tromey@adacore.com>
6145
6146         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6147         * tui/tui-winsource.c (tui_refill_source_window): New function,
6148         from...
6149         (tui_horizontal_source_scroll): ... here.  Move some logic.
6150         * cli/cli-style.c (set_style_enabled): Notify new observable.
6151         * tui/tui-hooks.c (tui_redisplay_source): New function.
6152         (tui_attach_detach_observers): Attach or detach
6153         tui_redisplay_source.
6154         * observable.h (source_styling_changed): New observable.
6155         * observable.c: Define source_styling_changed observable.
6156
6157 2019-03-13  Tom Tromey  <tromey@adacore.com>
6158
6159         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6160         (i386_gnu_nat_target::store_registers): Update.
6161         * target-debug.h (target_debug_print_std_string): New macro.
6162         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6163         * windows-tdep.c (display_one_tib): Update.
6164         * tui/tui-stack.c (tui_make_status_line): Update.
6165         * top.c (print_inferior_quit_action): Update.
6166         * thread.c (thr_try_catch_cmd): Update.
6167         (add_thread_with_info): Update.
6168         (thread_target_id_str): Update.
6169         (thr_try_catch_cmd): Update.
6170         (thread_command): Update.
6171         (thread_find_command): Update.
6172         * record-btrace.c (record_btrace_target::info_record)
6173         (record_btrace_resume_thread, record_btrace_target::resume)
6174         (record_btrace_cancel_resume, record_btrace_step_thread)
6175         (record_btrace_target::wait, record_btrace_target::wait)
6176         (record_btrace_target::wait, record_btrace_target::stop): Update.
6177         * progspace.c (print_program_space): Update.
6178         * process-stratum-target.c
6179         (process_stratum_target::thread_address_space): Update.
6180         * linux-fork.c (linux_fork_mourn_inferior)
6181         (detach_checkpoint_command, info_checkpoints_command)
6182         (linux_fork_context): Update.
6183         (linux_fork_detach): Update.
6184         (class scoped_switch_fork_info): Update.
6185         (delete_checkpoint_command): Update.
6186         * infrun.c (follow_fork_inferior): Update.
6187         (follow_fork_inferior): Update.
6188         (proceed_after_vfork_done): Update.
6189         (handle_vfork_child_exec_or_exit): Update.
6190         (follow_exec): Update.
6191         (displaced_step_prepare_throw): Update.
6192         (displaced_step_restore): Update.
6193         (start_step_over): Update.
6194         (resume_1): Update.
6195         (clear_proceed_status_thread): Update.
6196         (proceed): Update.
6197         (print_target_wait_results): Update.
6198         (do_target_wait): Update.
6199         (context_switch): Update.
6200         (stop_all_threads): Update.
6201         (restart_threads): Update.
6202         (finish_step_over): Update.
6203         (handle_signal_stop): Update.
6204         (switch_back_to_stepped_thread): Update.
6205         (keep_going_pass_signal): Update.
6206         (print_exited_reason): Update.
6207         (normal_stop): Update.
6208         * inferior.c (inferior_pid_to_str): Change return type.
6209         (print_selected_inferior): Update.
6210         (add_inferior): Update.
6211         (detach_inferior): Update.
6212         * dummy-frame.c (fprint_dummy_frames): Update.
6213         * dcache.c (dcache_info_1): Update.
6214         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6215         (btrace_fetch, btrace_clear): Update.
6216         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6217         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6218         type.
6219         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6220         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6221         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6222         * gdbarch.c, gdbarch.h: Rebuild.
6223         * gdbarch.sh (core_pid_to_str): Change return type.
6224         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6225         return type.
6226         (windows_nat_target::pid_to_str): Change return type.
6227         (windows_delete_thread): Update.
6228         (windows_nat_target::attach): Update.
6229         (windows_nat_target::files_info): Update.
6230         * target-delegates.c: Rebuild.
6231         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6232         return type.
6233         (sol_thread_target::pid_to_str): Change return type.
6234         * remote.c (class remote_target) <pid_to_str>: Change return
6235         type.
6236         (remote_target::pid_to_str): Change return type.
6237         (extended_remote_target::attach, remote_target::remote_stop_ns)
6238         (remote_target::remote_notif_remove_queued_reply)
6239         (remote_target::push_stop_reply, remote_target::disable_btrace):
6240         Update.
6241         (extended_remote_target::attach): Update.
6242         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6243         type.
6244         (gdbsim_target::pid_to_str): Change return type.
6245         * ravenscar-thread.c (struct ravenscar_thread_target)
6246         <pid_to_str>: Change return type.
6247         (ravenscar_thread_target::pid_to_str): Change return type.
6248         * procfs.c (class procfs_target) <pid_to_str>: Change return
6249         type.
6250         (procfs_target::pid_to_str): Change return type.
6251         (procfs_target::attach): Update.
6252         (procfs_target::detach): Update.
6253         (procfs_target::fetch_registers): Update.
6254         (procfs_target::store_registers): Update.
6255         (procfs_target::wait): Update.
6256         (procfs_target::files_info): Update.
6257         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6258         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6259         return type.
6260         (nto_procfs_target::pid_to_str): Change return type.
6261         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6262         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6263         return type.
6264         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6265         (exit_lwp): Update.
6266         (attach_proc_task_lwp_callback, get_detach_signal)
6267         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6268         (linux_nat_target::resume, wait_lwp, stop_callback)
6269         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6270         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6271         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6272         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6273         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6274         type.
6275         (inf_ptrace_target::attach): Update.
6276         (inf_ptrace_target::files_info): Update.
6277         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6278         type.
6279         (go32_nat_target::pid_to_str): Change return type.
6280         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6281         (gnu_nat_target::wait): Update.
6282         (gnu_nat_target::wait): Update.
6283         (gnu_nat_target::resume): Update.
6284         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6285         (fbsd_nat_target::wait): Update.
6286         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6287         type.
6288         (darwin_nat_target::attach): Update.
6289         * corelow.c (class core_target) <pid_to_str>: Change return type.
6290         (core_target::pid_to_str): Change return type.
6291         * target.c (normal_pid_to_str): Change return type.
6292         (default_pid_to_str): Likewise.
6293         (target_pid_to_str): Change return type.
6294         (target_translate_tls_address): Update.
6295         (target_announce_detach): Update.
6296         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6297         return type.
6298         (bsd_uthread_target::pid_to_str): Change return type.
6299         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6300         type.
6301         (bsd_kvm_target::pid_to_str): Change return type.
6302         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6303         return type.
6304         (aix_thread_target::pid_to_str): Change return type.
6305         * target.h (struct target_ops) <pid_to_str>: Change return type.
6306         (target_pid_to_str, normal_pid_to_str): Likewise.
6307         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6308         type.
6309         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6310         type.
6311         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6312         return type.
6313         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6314         type.
6315         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6316         type.
6317         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6318         return type.
6319
6320 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6321
6322         * NEWS: Mention that the new default MI version is 3.  Mention
6323         changes to the output of commands and events that deal with
6324         multi-location breakpoints.
6325         * breakpoint.c: Include "mi/mi-out.h".
6326         (print_one_breakpoint): Change output syntax if using MI version
6327         >= 3.
6328         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6329         New.
6330         (mi_multi_location_breakpoint_output_fixed): New.
6331         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6332         (mi_cmd_fix_multi_location_breakpoint_output): New.
6333         (mi_multi_location_breakpoint_output_fixed): New.
6334         * mi/mi-cmds.c (mi_cmds): Register command
6335         -fix-multi-location-breakpoint-output.
6336         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6337         interpreter "mi".
6338
6339 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6340
6341         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6342         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6343         instantiate mi_ui_out based on interpreter name.
6344         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6345         * mi/mi-main.c (mi_load_progress): Likewise.
6346
6347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6348
6349         * NEWS: Combine separate "New targets" sections for 8.3.
6350
6351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6352
6353         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6354         (ppcfbsd_init_abi): Install gdbarch
6355         "fetch_tls_load_module_address" and "get_thread_local_address"
6356         methods.
6357
6358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6359
6360         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6361         (riscv_fbsd_init_abi): Install gdbarch
6362         "fetch_tls_load_module_address" and "get_thread_local_address"
6363         methods.
6364
6365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6366
6367         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6368         (i386fbsd_init_abi): Install gdbarch
6369         "fetch_tls_load_module_address" and "get_thread_local_address"
6370         methods.
6371
6372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6373
6374         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6375         (amd64fbsd_init_abi): Install gdbarch
6376         "fetch_tls_load_module_address" and "get_thread_local_address"
6377         methods.
6378
6379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6380
6381         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6382         (struct fbsd_pspace_data): New type.
6383         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6384         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6385         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6386         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6387         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6388
6389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6390
6391         * gdbtypes.c (lookup_struct_elt): New function.
6392         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6393         * gdbtypes.h (struct struct_elt): New type.
6394         (lookup_struct_elt): New prototype.
6395
6396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6397
6398         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6399         remove disabled code block.
6400
6401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6402
6403         * gdbarch.sh (get_thread_local_address): New method.
6404         * gdbarch.h, gdbarch.c: Regenerate.
6405         * target.c (target_translate_tls_address): Use
6406         gdbarch_get_thread_local_address if present instead of
6407         target::get_thread_local_address.
6408
6409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6410
6411         * target.h (target::get_thread_local_address): Update comment.
6412
6413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6414
6415         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6416         objfile->separate_debug_objfile_backlink if not NULL.
6417
6418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6419
6420         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6421         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6422         (amd64bsd_store_inferior_registers): Likewise.
6423         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6424         Enable segment base registers.
6425         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6426         PT_GETFSBASE and PT_GETGSBASE.
6427         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6428         PT_SETGSBASE.
6429         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6430         segment base registers.
6431         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6432
6433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6434
6435         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6436         Update calls to i386_target_description to add 'segments'
6437         parameter.
6438         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6439         add segment base registers.
6440         * arch/i386.c (i386_create_target_description): Add 'segments'
6441         parameter to enable segment base registers.
6442         * arch/i386.h (i386_create_target_description): Likewise.
6443         * features/i386/32bit-segments.xml: New file.
6444         * features/i386/32bit-segments.c: Generate.
6445         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6446         call to i386_target_description to add 'segments' parameter.
6447         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6448         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6449         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6450         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6451         if feature is present.
6452         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6453         Add 'segments' parameter to call to i386_target_description.
6454         (i386_target_description): Add 'segments' parameter to enable
6455         segment base registers.
6456         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6457         to call to i386_target_description.
6458         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6459         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6460         Define I386_NUM_REGS.
6461         (i386_target_description): Add 'segments' parameter to enable
6462         segment base registers.
6463
6464 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6465
6466         PR/24325
6467         * source-cache.c: #undef open and close, to avoid unresolved
6468         externals during linking.
6469
6470 2019-03-12  Tom Tromey  <tromey@adacore.com>
6471
6472         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6473         const.  Add initializers.
6474         (_initialize_remote): Don't initialize ptid globals.
6475
6476 2019-03-12  Pedro Alves  <palves@redhat.com>
6477
6478         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6479
6480 2019-03-12  Pedro Alves  <palves@redhat.com>
6481
6482         * cp-name-parser.y (main): Remove unused 'len' variable.
6483
6484 2019-03-12  Tom Tromey  <tromey@adacore.com>
6485
6486         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6487         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6488
6489 2019-03-12  Tom Tromey  <tromey@adacore.com>
6490
6491         * linux-nat.c (iterate_over_lwps): Update.
6492         (stop_callback): Remove parameter.
6493         (stop_wait_callback, detach_callback, resume_set_callback)
6494         (select_singlestep_lwp_callback, set_ignore_sigint)
6495         (status_callback, resumed_callback, resume_clear_callback)
6496         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6497         data parameter.
6498         (linux_nat_target::detach, linux_nat_target::resume)
6499         (linux_stop_and_wait_all_lwps, select_event_lwp)
6500         (linux_nat_filter_event, linux_nat_wait_1)
6501         (linux_nat_target::kill, linux_nat_target::stop)
6502         (linux_nat_target::stop): Update.
6503         (linux_nat_resume_callback): Change type.
6504         (resume_stopped_resumed_lwps, count_events_callback)
6505         (select_event_lwp_callback): Likewise.
6506         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6507         * arm-linux-nat.c (struct update_registers_data): Remove.
6508         (update_registers_callback): Change type.
6509         (arm_linux_insert_hw_breakpoint1): Update.
6510         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6511         parameter.
6512         (x86_linux_dr_set_addr): Update.
6513         (x86_linux_dr_set_control): Update.
6514         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6515         (iterate_over_lwps): Use gdb::function_view.
6516         * nat/aarch64-linux-hw-point.c (struct
6517         aarch64_dr_update_callback_param): Remove.
6518         (debug_reg_change_callback): Change type.
6519         (aarch64_notify_debug_reg_change): Update.
6520         * s390-linux-nat.c (s390_refresh_per_info): Update.
6521
6522 2019-03-11  Tom Tromey  <tromey@adacore.com>
6523
6524         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6525         redundant assignment to "this_cu".
6526
6527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6528
6529         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6530
6531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6532
6533         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6534         from...
6535         (rank_one_type): ... this.
6536
6537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6538
6539         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6540         from...
6541         (rank_one_type): ... this.
6542
6543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6544
6545         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6546         from...
6547         (rank_one_type): ... this.
6548
6549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6550
6551         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6552         from...
6553         (rank_one_type): ... this.
6554
6555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6556
6557         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6558         from...
6559         (rank_one_type): ... this.
6560
6561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6562
6563         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6564         from...
6565         (rank_one_type): ... this.
6566
6567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6568
6569         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6570         from...
6571         (rank_one_type): ... this.
6572
6573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6574
6575         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6576         from...
6577         (rank_one_type): ... this.
6578
6579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6580
6581         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6582         from...
6583         (rank_one_type): ... this.
6584
6585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6586
6587         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6588         from...
6589         (rank_one_type): ... this.
6590
6591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6592
6593         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6594         from...
6595         (rank_one_type): ... this.
6596
6597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6598
6599         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6600         from...
6601         (rank_one_type): ... this.
6602
6603 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6604
6605         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6606         inferior-events' shows the example events.
6607
6608 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6609
6610         Support styling on native MS-Windows console
6611
6612         PR/24315
6613         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6614         on MS-Windows if $TERM is not defined.
6615
6616         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6617
6618         * posix-hdep.c (gdb_console_fputs):
6619         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6620         functions.
6621         * ui-file.h (gdb_console_fputs): Add prototype.
6622
6623         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6624         back to fputs only if the former returns zero.
6625
6626 2019-03-07  Tom Tromey  <tom@tromey.com>
6627
6628         * symmisc.c (print_symbol_bcache_statistics): Update.
6629         (print_objfile_statistics): Update.
6630         * symfile.c (allocate_symtab): Update.
6631         * stabsread.c: Don't include bcache.h.
6632         * psymtab.h (struct psymbol_bcache): Don't declare.
6633         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6634         (psymbol_bcache_init, psymbol_bcache_free)
6635         (psymbol_bcache_get_bcache): Don't declare.
6636         * psymtab.c (struct psymbol_bcache): Remove.
6637         (psymtab_storage::psymtab_storage): Update.
6638         (psymtab_storage::~psymtab_storage): Update.
6639         (psymbol_bcache_init, psymbol_bcache_free)
6640         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6641         (add_psymbol_to_bcache): Update.
6642         (allocate_psymtab): Update.
6643         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6644         macro_cache>: No longer pointers.
6645         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6646         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6647         * macrotab.c (macro_bcache): Update.
6648         * macroexp.c: Don't include bcache.h.
6649         * gdbtypes.c (check_types_worklist): Update.
6650         (types_deeply_equal): Remove TRY/CATCH.  Update.
6651         * elfread.c (elf_symtab_read): Update.
6652         * dwarf2read.c: Don't include bcache.h.
6653         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6654         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6655         (print_bcache_statistics, bcache_memory_used): Don't declare.
6656         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6657         methods.  Rename all data members.
6658         * bcache.c (struct bcache): Move to bcache.h.
6659         (bcache::expand_hash_table): Rename from expand_hash_table.
6660         (bcache): Remove.
6661         (bcache::insert): Rename from bcache_full.
6662         (bcache::compare): Rename from bcache_compare.
6663         (bcache_xmalloc): Remove.
6664         (bcache::~bcache): Rename from bcache_xfree.
6665         (bcache::print_statistics): Rename from print_bcache_statistics.
6666         (bcache::memory_used): Rename from bcache_memory_used.
6667
6668 2019-03-07  Pedro Alves  <palves@redhat.com>
6669
6670         * infrun.c (normal_stop): Also check for
6671         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6672
6673 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6674
6675         * f-lang.c (value_from_host_double): Moved to...
6676         * value.c (value_from_host_double): ...here.
6677         * value.h (value_from_host_double): Declare.
6678         * guile/scm-math.c (vlscm_convert_typed_number): Use
6679         value_from_host_double.
6680         (vlscm_convert_number): Likewise.
6681         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6682         * python/py-value.c (convert_value_from_python): Likewise.
6683
6684 2019-03-06  Tom Tromey  <tom@tromey.com>
6685
6686         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6687
6688 2019-03-06  Tom Tromey  <tom@tromey.com>
6689
6690         * utils.h (free_current_contents): Don't declare.
6691         * utils.c (free_current_contents): Remove.
6692
6693 2019-03-06  Tom Tromey  <tom@tromey.com>
6694
6695         * top.c (quit_force): Update.
6696         * main.c (captured_command_loop): Update.
6697         * common/new-op.c (operator new): Update.
6698         * common/common-exceptions.c (struct catcher)
6699         <save_cleanup_chain>: Remove member.
6700         (exceptions_state_mc_init): Update.
6701         (exception_try_scope_entry): Return nullptr.
6702         (exception_try_scope_exit, exception_rethrow)
6703         (throw_exception_sjlj, throw_exception_cxx): Update.
6704         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6705         (all_cleanups, do_cleanups, discard_cleanups)
6706         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6707         (restore_cleanups, restore_final_cleanups): Don't declare.
6708         (do_final_cleanups): Remove parameter.
6709         * common/cleanups.c (cleanup_chain, make_cleanup)
6710         (make_cleanup_dtor, all_cleanups, do_cleanups)
6711         (discard_my_cleanups, discard_cleanups)
6712         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6713         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6714         (null_cleanup): Remove.
6715         (do_final_cleanups): Remove parameter.
6716
6717 2019-03-06  Tom Tromey  <tom@tromey.com>
6718
6719         * remote.c (remote_target::remote_parse_stop_reply): Use
6720         unique_xmalloc_ptr.
6721
6722 2019-03-06  Tom Tromey  <tom@tromey.com>
6723
6724         * stabsread.c (struct stabs_field_info): Rename from field_info.
6725         <list, fnlist>: Add initializers.
6726         <obstack>: New member.
6727         (read_member_functions, read_struct_fields, read_baseclasses):
6728         Allocate on obstack.  Don't use cleanups.
6729         (read_one_struct_field, read_member_functions, read_struct_fields)
6730         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6731         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6732         (read_struct_type): Update.
6733
6734 2019-03-06  Tom Tromey  <tom@tromey.com>
6735
6736         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6737         * common/filestuff.h (make_cleanup_close): Don't declare.
6738         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6739         Remove.
6740
6741 2019-03-06  Tom Tromey  <tom@tromey.com>
6742
6743         * solib-aix.c: Use make_scope_exit.
6744
6745 2019-03-06  Tom Tromey  <tom@tromey.com>
6746
6747         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6748         Use make_scope_exit.
6749
6750 2019-03-06  Tom Tromey  <tom@tromey.com>
6751
6752         * solib-svr4.c (disable_probes_interface): Remove parameter.
6753         (svr4_handle_solib_event): Use make_scope_exit.
6754
6755 2019-03-06  Tom Tromey  <tom@tromey.com>
6756
6757         * remote.c (struct stop_reply_deleter): Remove.
6758         (stop_reply_up): Update.
6759         (struct stop_reply): Derive from notif_event.  Don't typedef.
6760         <regcache>: Now a std::vector.
6761         (stop_reply_xfree): Remove.
6762         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6763         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6764         (remote_target::discard_pending_stop_replies): Use delete.
6765         (remote_target::remote_parse_stop_reply): Update.
6766         (remote_target::process_stop_reply): Update.
6767         * remote-notif.h (struct notif_event): Add virtual destructor.
6768         Remove "dtr" member.
6769         (struct notif_client) <alloc_event>: Return a unique_ptr.
6770         (notif_event_xfree): Don't declare.
6771         (notif_event_up): New typedef.
6772         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6773         (notif_event_xfree, do_notif_event_xfree): Remove.
6774         (remote_notif_state_xfree): Update.
6775
6776 2019-03-06  Tom Tromey  <tom@tromey.com>
6777
6778         * infrun.c (displaced_step_clear_cleanup): Now a
6779         forward_scope_exit type.
6780         (displaced_step_prepare_throw): Update.
6781         (displaced_step_fixup): Update.
6782
6783 2019-03-06  Tom Tromey  <tom@tromey.com>
6784
6785         * inferior.h (class inferior): Update comment.
6786         * gdbthread.h (class thread_info): Update comment.
6787
6788 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6789             Tom Tromey  <tom@tromey.com>
6790
6791         * stabsread.h (struct stab_section_list): Remove.
6792         (coffstab_build_psymtabs): Update.
6793         * dbxread.c (symbuf_sections): Now a std::vector.
6794         (sect_idx): New global.
6795         (fill_symbuf): Update.
6796         (coffstab_build_psymtabs): Change type of stabsects parameter.
6797         Update.
6798         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6799         std::vector.
6800         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6801         (coff_locate_sections): Update.
6802         (coff_symfile_read): Remove cleanups.  Update.
6803         (init_stringtab): Add storage parameter.
6804         (free_stringtab, free_stringtab_cleanup): Remove.
6805         (init_lineno): Add storage parameter.
6806         (free_linetab, free_linetab_cleanup): Remove.
6807
6808 2019-03-06  Pedro Alves  <palves@redhat.com>
6809
6810         * linux-fork.c (fork_info::clobber_regs): Delete.
6811         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6812         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6813         comment.  Adjust.
6814         (scoped_switch_fork_info::scoped_switch_fork_info)
6815         (checkpoint_command, linux_fork_context): Adjust
6816         fork_save_infrun_state calls.
6817
6818 2019-03-06  Pedro Alves  <palves@redhat.com>
6819
6820         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6821         (inf_has_multiple_threads): Return 'bool' and rewrite using
6822         inferior_info::threads().
6823
6824 2019-03-06  Pedro Alves  <palves@redhat.com>
6825
6826         * linux-fork.c: Include <list>.
6827         (fork_list): Now a std::list instance.
6828         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6829         (forks_exist_p, find_last_fork): Adjust.
6830         (new_fork): Delete.
6831         (one_fork_p): New.
6832         (add_fork): Adjust.
6833         (free_fork): Delete, folded into fork_info::~fork_info().
6834         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6835         Adjust.
6836         (init_fork_list): Delete.
6837         (linux_fork_killall, linux_fork_mourn_inferior)
6838         (linux_fork_detach, info_checkpoints_command): Adjust.
6839         (_initialize_linux_fork): No longer call init_fork_list.
6840
6841 2019-03-06  Pedro Alves  <palves@redhat.com>
6842
6843         * linux-fork.c (new_fork): New, split out of ...
6844         (add_fork): ... this.  Return void.  Move "first fork" special
6845         case from here, to ...
6846         (checkpoint_command): ... here.
6847         * linux-linux.h (add_fork): Return void.
6848
6849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6850
6851         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6852
6853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6854             Chris January  <chris.january@arm.com>
6855             David Lecomber  <david.lecomber@arm.com>
6856
6857         * f-exp.y: New token, UNOP_INTRINSIC.
6858         (exp): New pattern using UNOP_INTRINSIC token.
6859         (f77_keywords): Add 'abs' keyword.
6860         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6861         (value_from_host_double): New function.
6862         (evaluate_subexp_f): Support UNOP_ABS.
6863
6864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6865
6866         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6867         types.
6868
6869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6870
6871         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6872         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6873         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6874
6875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6876
6877         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6878
6879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6880             Chris January  <chris.january@arm.com>
6881
6882         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6883         * f-exp.y: Define 'KIND' token.
6884         (exp): New pattern for KIND expressions.
6885         (ptype): Handle types with a kind extension.
6886         (direct_abs_decl): Extend to spot kind extensions.
6887         (f77_keywords): Add 'kind' to the list.
6888         (push_kind_type): New function.
6889         (convert_to_kind_type): New function.
6890         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6891         * parse.c (operator_length_standard): Likewise.
6892         * parser-defs.h (enum type_pieces): Add tp_kind.
6893         * std-operator.def: Add UNOP_KIND.
6894
6895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6896
6897         * f-exp.y (f_parse): Set yydebug.
6898
6899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6900
6901         * f-lang.c (evaluate_subexp_f): New function.
6902         (exp_descriptor_f): New global.
6903         (f_language_defn): Use exp_descriptor_f instead of
6904         exp_descriptor_standard.
6905
6906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * f-exp.y (struct token): Add comments.
6909         (dot_ops): Remove uppercase versions and the end marker.
6910         (f77_keywords): Likewise.
6911         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6912         entries in the dot_ops array are case insensitive, and use
6913         strncasecmp to compare strings.  Also some whitespace cleanup in
6914         this area.  Similar for the f77_keywords array, except entries in
6915         this list might be case sensitive.
6916
6917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * f-exp.y (struct f77_boolean_val): Add comments.
6920         (boolean_values): Remove uppercase versions, and end marker.
6921         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6922         and use strncasecmp to achieve case insensitivity.  Additionally,
6923         perform whitespace cleanup around this code.
6924
6925 2019-03-06  Tom Tromey  <tromey@adacore.com>
6926
6927         * remote-sim.c (gdbsim_target_open): Use result of
6928         gdb_argv::release.
6929
6930 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6931         Dirk Schubert  <dirk.schubert@arm.com>
6932         Chris January  <chris.january@arm.com>
6933
6934         * eval.c (evaluate_subexp_standard): Call Fortran argument
6935         wrapping logic.
6936         * f-lang.c (struct value): A value which can be passed into a
6937         Fortran function call.
6938         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6939         where appropriate.
6940         (struct type): Value ready for a Fortran function call.
6941         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6942         is needed.
6943         * f-lang.h (fortran_argument_convert): Declaration.
6944         (fortran_preserve_arg_pointer): Declaration.
6945         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6946
6947 2019-03-05  Tom Tromey  <tromey@adacore.com>
6948
6949         * python/py-prettyprint.c (print_string_repr): Remove #if.
6950         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6951
6952 2019-03-05  Tom Tromey  <tromey@adacore.com>
6953
6954         * target.c (the_dummy_target): Move later.  Change type to
6955         "dummy_target".
6956         (initialize_targets): Don't initialize the_dummy_target.
6957
6958 2019-03-05  Tom Tromey  <tromey@adacore.com>
6959
6960         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6961         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6962
6963 2019-03-05  Tom Tromey  <tromey@adacore.com>
6964
6965         * windows-nat.c (windows_nat_target::attach)
6966         (windows_nat_target::detach): Don't call gdb_flush.
6967         * valprint.c (generic_val_print, val_print, val_print_string):
6968         Don't call gdb_flush.
6969         * utils.c (defaulted_query): Don't call gdb_flush.
6970         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6971         * target.c (target_announce_detach): Don't call gdb_flush.
6972         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6973         * remote.c (extended_remote_target::attach): Don't call
6974         gdb_flush.
6975         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6976         * printcmd.c (do_examine): Don't call gdb_flush.
6977         (info_display_command): Don't call gdb_flush.
6978         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6979         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6980         * memattr.c (info_mem_command): Don't call gdb_flush.
6981         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6982         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6983         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6984         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6985         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6986         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6987         (gnu_nat_target::detach): Don't call gdb_flush.
6988         * f-valprint.c (f_val_print): Don't call gdb_flush.
6989         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6990         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6991         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6992         gdb_flush.
6993         * c-valprint.c (c_val_print): Don't call gdb_flush.
6994         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6995
6996 2019-03-05  Tom Tromey  <tromey@adacore.com>
6997
6998         * varobj.c (update_dynamic_varobj_children): Update.
6999         (install_default_visualizer): Use reset, not release.
7000         * value.c (set_internalvar): Update.
7001         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7002         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7003         ATTRIBUTE_UNUSED_RESULT.
7004
7005 2019-03-05  Tom Tromey  <tromey@adacore.com>
7006
7007         * remote.c (class scoped_remote_fd) <release>: Add
7008         ATTRIBUTE_UNUSED_RESULT.
7009
7010 2019-03-05  Tom Tromey  <tromey@adacore.com>
7011
7012         * macroexp.c (struct macro_buffer) <release>: Add
7013         ATTRIBUTE_UNUSED_RESULT.
7014
7015 2019-03-05  Tom Tromey  <tromey@adacore.com>
7016
7017         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7018         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7019         ATTRIBUTE_UNUSED_RESULT.
7020
7021 2019-03-05  Tom Tromey  <tromey@adacore.com>
7022
7023         * common/scoped_fd.h (class scoped_fd) <release>: Add
7024         ATTRIBUTE_UNUSED_RESULT.
7025
7026 2019-03-05  Tom Tromey  <tromey@adacore.com>
7027
7028         * parser-defs.h (struct parser_state) <release>: Add
7029         ATTRIBUTE_UNUSED_RESULT.
7030
7031 2019-03-05  Tom Tromey  <tromey@adacore.com>
7032
7033         * utils.h (class gdb_argv) <release>: Add
7034         ATTRIBUTE_UNUSED_RESULT.
7035         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7036
7037 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7038
7039         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7040         for-loop range, to avoid compiler warnings.
7041
7042         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7043         avoid compiler warnings about unused variables.
7044
7045         * NEWS: Mention end of support for native debugging on MS-Windows
7046         before XP.
7047
7048         PR gdb/24292
7049         * common/netstuff.c:
7050         * gdbserver/gdbreplay.c
7051         * gdbserver/remote-utils.c:
7052         * ser-tcp.c:
7053         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7054         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7055         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7056         'getaddrinfo' and 'freeaddrinfo' were not available before
7057         Windows XP, and mingw.org's MinGW headers by default define
7058         _WIN32_WINNT to 0x500.
7059
7060 2019-03-01  Gary Benson <gbenson@redhat.com>
7061
7062         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7063
7064 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7065             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7066
7067         PR gdb/8527
7068         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7069         set_sigint_trap, clear_sigint_trap.
7070
7071 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7072
7073         * target.c (target_detach): Clear the regcache and the
7074         frame cache.
7075
7076 2019-02-27  Pedro Alves  <palves@redhat.com>
7077
7078         * utils.c (set_screen_size): When we cap the height/width sizes,
7079         tweak the corresponding command variable to show "unlimited":
7080
7081 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7082             Pedro Alves  <palves@redhat.com>
7083
7084         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7085         before calling rl_set_screen_size.
7086
7087 2019-02-27  Tom Tromey  <tromey@adacore.com>
7088
7089         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7090         define.
7091         * python/py-value.c: Remove Python 2.4 workaround.
7092         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7093         workaround.
7094         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7095         Python 2.4 workaround.
7096         * python/python-internal.h: Remove Python 2.4 comment.
7097         (Py_ssize_t): Don't define.
7098         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7099         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7100         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7101         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7102         * python/python.c (do_start_initialization): Remove Python 2.4
7103         workaround.
7104         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7105         (print_children): Remove Python 2.4 workaround.
7106         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7107         workaround.
7108         (CHARBUFFERPROC_NAME): Remove.
7109         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7110         Python 2.4 workaround.
7111
7112 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7113
7114         * NEWS: Note minimum Python version.
7115
7116 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7117
7118         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7119         code from these functions.  Remove corresponding ifdefs.  Use
7120         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7121         Remove gotos and target of gotos.
7122         (infpy_search_memory): Likewise.
7123
7124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7125
7126         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7127         (hppa_gdbarch_init): Don't register deleted functions with
7128         gdbarch.
7129
7130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7131
7132         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7133         (h8300_unwind_sp): Delete.
7134         (h8300_dummy_id): Delete.
7135         (h8300_gdbarch_init): Don't register deleted functions with
7136         gdbarch.
7137
7138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7139
7140         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7141         (ft32_unwind_pc): Delete.
7142         (ft32_unwind_sp): Delete.
7143         (ft32_gdbarch_init): Don't register deleted functions with
7144         gdbarch.
7145
7146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7149         (frv_unwind_pc): Delete.
7150         (frv_unwind_sp): Delete.
7151         (frv_gdbarch_init): Don't register deleted functions with
7152         gdbarch.
7153
7154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7155
7156         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7157         (riscv_unwind_pc): Delete.
7158         (riscv_unwind_sp): Delete.
7159         (riscv_gdbarch_init): Don't register deleted functions with
7160         gdbarch.
7161
7162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7163
7164         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7165         (csky_unwind_pc): Delete.
7166         (csky_unwind_sp): Delete.
7167         (csky_gdbarch_init): Don't register deleted functions with
7168         gdbarch.
7169
7170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7171
7172         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7173         (cris_unwind_pc): Delete.
7174         (cris_unwind_sp): Delete.
7175         (cris_gdbarch_init): Don't register deleted functions with
7176         gdbarch.
7177
7178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7181         (bfin_unwind_pc): Delete.
7182         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7183
7184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7187         (arm_unwind_pc): Delete.
7188         (arm_unwind_sp): Delete.
7189         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7190
7191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7192
7193         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7194         (arc_unwind_pc): Delete.
7195         (arc_unwind_sp): Delete.
7196         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7197
7198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7199
7200         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7201         (alpha_unwind_pc): Delete.
7202         (alpha_gdbarch_init): Don't register deleted functions with
7203         gdbarch.
7204
7205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7206
7207         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7208         (aarch64_unwind_pc): Delete.
7209         (aarch64_unwind_sp): Delete.
7210         (aarch64_gdbarch_init): Don't register deleted functions with
7211         gdbarch.
7212
7213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7214
7215         * gdbtypes.c (type_align): Don't consider static members when
7216         computing structure alignment.
7217
7218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7219
7220         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7221         return 0 for other types.
7222         * arch-utils.c (default_type_align): Always return 0.
7223         * gdbarch.h: Regenerate.
7224         * gdbarch.sh (type_align): Extend comment.
7225         * gdbtypes.c (type_align): Add additional comments, always call
7226         gdbarch_type_align before applying the default rules.
7227         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7228         generic code will then apply a suitable default.
7229         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7230         types, return 0 for other types.
7231
7232 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7233
7234         * NEWS: Create a new section for the next release branch.
7235         Rename the section of the current branch, now that it has
7236         been cut.
7237
7238 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7239
7240         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7241         * version.in: Bump version to 8.3.50.DATE-git.
7242
7243 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7244
7245         * aix-thread.c (ptid_cmp): Remove unused variable.
7246         (get_signaled_thread): Likewise.
7247         (store_regs_user_thread): Likewise.
7248         (store_regs_kernel_thread): Likewise.
7249         (fetch_regs_kernel_thread): Remove shadowed variable.
7250
7251 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * features/riscv/32bit-cpu.xml: Add register numbers.
7254         * features/riscv/32bit-fpu.c: Regenerate.
7255         * features/riscv/32bit-fpu.xml: Add register numbers.
7256         * features/riscv/64bit-cpu.xml: Add register numbers.
7257         * features/riscv/64bit-fpu.c: Regenerate.
7258         * features/riscv/64bit-fpu.xml: Add register numbers.
7259
7260 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7261
7262         * NEWS: Mention two argument form of gdb.Value constructor.
7263         * python/py-value.c (convert_buffer_and_type_to_value): New
7264         function.
7265         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7266         Add support for handling an optional second argument.  Call
7267         convert_buffer_and_type_to_value as appropriate.
7268         * python/python-internal.h (Py_buffer_deleter): New struct.
7269         (Py_buffer_up): New typedef.
7270
7271 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7272
7273         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7274         instead of releasing ownership.
7275
7276 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7277
7278         * dwarf2read.c (open_and_init_dwp_file): Call
7279         elf_numsections instead of bfd_count_sections to initialize
7280         dwp_file->num_sections.
7281
7282 2019-02-25  Tom Tromey  <tromey@adacore.com>
7283
7284         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7285
7286 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7287
7288         * gcore.in: Add '--readnever' option when invoking GDB.
7289
7290 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7291
7292         * MAINTAINERS: Update my email address.
7293
7294 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7295
7296         * build-id.c (build_id_to_debug_bfd_1): New function.
7297         (build_id_to_debug_bfd): Look for separate debug file in
7298         sysroot.
7299
7300 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * gdbarch.sh: Update the copyright year range that is placed into
7303         generated files.
7304
7305 2019-02-22  Keith Seitz  <keiths@redhat.com>
7306
7307         PR symtab/23853
7308         * linespec.c (create_sals_line_offset): Search for the default
7309         symtab's filename instead of its fullname.
7310
7311 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7312
7313         * NEWS: Update style defaults.
7314
7315 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7316
7317         * main.c (captured_main_1): Disable styling in batch mode.
7318
7319 2019-02-20  Tom Tromey  <tom@tromey.com>
7320
7321         * symtab.c (symtab_symbol_info): Fix typos.
7322
7323 2019-02-20  Tom Tromey  <tromey@adacore.com>
7324
7325         * findcmd.c (_initialize_mem_search): Use upper case for
7326         metasyntactic variables.
7327
7328 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7329
7330         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7331         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7332
7333 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7334
7335         * top.h (source_file_name): Change to std::string.
7336         * top.c (source_file_name): Likewise.
7337         (command_line_input): Adjust.
7338         * cli/cli-script.c (script_from_file): Adjust.
7339
7340 2019-02-19  Tom Tromey  <tromey@adacore.com>
7341
7342         * ravenscar-thread.c
7343         (ravenscar_thread_target::update_thread_list): Don't call
7344         ada_build_task_list.
7345         * ada-lang.h (ada_build_task_list): Don't declare.
7346         * ada-tasks.c (struct ada_tasks_inferior_data)
7347         <task_list_valid_p>: Now bool.
7348         (read_known_tasks, ada_task_list_changed)
7349         (ada_tasks_invalidate_inferior_data): Update.
7350         (read_known_tasks_array): Return bool.
7351         (read_known_tasks_list): Likewise.
7352         (read_known_tasks): Return void.
7353         (ada_build_task_list): Now static.
7354
7355 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7358         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7359
7360 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7361
7362         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7363         variant for ada_tasks_pspace_data_handle and
7364         ada_tasks_inferior_data_handle.
7365         (ada_tasks_pspace_data_cleanup): New function.
7366         (ada_tasks_inferior_data_cleanup): New function.
7367
7368 2019-02-17  Tom Tromey  <tom@tromey.com>
7369
7370         * macrotab.h (macro_source_fullname): Return a std::string.
7371         * macrotab.c (macro_include, check_for_redefinition)
7372         (macro_undef, macro_lookup_definition, foreach_macro)
7373         (foreach_macro_in_scope): Update.
7374         (macro_source_fullname): Return a std::string.
7375         * macrocmd.c (show_pp_source_pos): Update.
7376
7377 2019-02-17  Tom Tromey  <tom@tromey.com>
7378
7379         * macrocmd.c (show_pp_source_pos): Style the file names.
7380
7381 2019-02-17  Tom Tromey  <tom@tromey.com>
7382
7383         PR tui/24197:
7384         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7385
7386 2019-02-17  Tom Tromey  <tom@tromey.com>
7387
7388         * ada-lang.c (user_select_syms): Use filtered printing.
7389         * utils.c (wrap_style): New global.
7390         (desired_style): Remove.
7391         (emit_style_escape): Add stream parameter.
7392         (set_output_style, reset_terminal_style, prompt_for_continue):
7393         Update.
7394         (flush_wrap_buffer): Only flush gdb_stdout.
7395         (wrap_here): Set wrap_style.
7396         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7397         treat escape sequences as a character.  Change when wrap buffer is
7398         flushed.
7399         (fputs_styled): Do not set the output style when the default is
7400         requested.
7401         * ui-style.h (struct ui_file_style) <is_default>: New method.
7402         * source.c (print_source_lines_base): Emit escape sequences in one
7403         piece.
7404
7405 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7406
7407         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7408         integers and enumeration types.
7409
7410 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7411
7412         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7413         instead of lookup_symbol_in_language
7414         (do_exact_match): New function.
7415         (ada_get_symbol_name_matcher): Return do_exact_match when
7416         doing a verbatim match.
7417
7418 2019-02-15  Tom Tromey  <tromey@adacore.com>
7419
7420         * ravenscar-thread.c (ravenscar_thread_target::resume)
7421         (ravenscar_thread_target::wait): Special case wildcard requests.
7422
7423 2019-02-15  Tom Tromey  <tromey@adacore.com>
7424
7425         * ravenscar-thread.c (base_ptid): Remove.
7426         (struct ravenscar_thread_target) <close>: New method.
7427         <m_base_ptid>: New member.
7428         <update_inferior_ptid, active_task, task_is_currently_active,
7429         runtime_initialized>: Declare methods.
7430         <ravenscar_thread_target>: Add constructor.
7431         (ravenscar_thread_target::task_is_currently_active)
7432         (ravenscar_thread_target::update_inferior_ptid)
7433         (ravenscar_runtime_initialized): Rename.  Now methods.
7434         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7435         (ravenscar_thread_target::update_thread_list): Update.
7436         (ravenscar_thread_target::active_task): Now method.
7437         (ravenscar_thread_target::store_registers)
7438         (ravenscar_thread_target::prepare_to_store)
7439         (ravenscar_thread_target::prepare_to_store)
7440         (ravenscar_thread_target::mourn_inferior): Update.
7441         (ravenscar_inferior_created): Use "new" to create target.
7442         (ravenscar_thread_target::get_ada_task_ptid): Update.
7443         (_initialize_ravenscar): Don't initialize base_ptid.
7444         (ravenscar_ops): Remove global.
7445
7446 2019-02-15  Tom Tromey  <tromey@adacore.com>
7447
7448         * target.h (push_target): Declare new overload.
7449         * target.c (push_target): New overload, taking an rvalue reference.
7450         * remote.c (remote_target::open_1): Use push_target overload.
7451         * corelow.c (core_target_open): Use push_target overload.
7452
7453 2019-02-15  Tom Tromey  <tromey@adacore.com>
7454
7455         * ravenscar-thread.c (is_ravenscar_task)
7456         (ravenscar_task_is_currently_active): Return bool.
7457         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7458         (_initialize_ravenscar): Remove "(void)".
7459         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7460         Return bool.
7461
7462 2019-02-15  Tom Tromey  <tromey@adacore.com>
7463
7464         * ravenscar-thread.c (ravenscar_runtime_initializer)
7465         (has_ravenscar_runtime, get_running_thread_id)
7466         (ravenscar_thread_target::resume): Fix indentation.
7467
7468 2019-02-15  Tom Tromey  <tromey@adacore.com>
7469
7470         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7471         from ravenscar_arch_ops.
7472         (sparc_ravenscar_ops::fetch_registers)
7473         (sparc_ravenscar_ops::store_registers): Now methods.
7474         (sparc_ravenscar_prepare_to_store): Remove.
7475         (sparc_ravenscar_ops): Redefine.
7476         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7477         methods and destructor.  Remove members.
7478         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7479         (ravenscar_thread_target::store_registers)
7480         (ravenscar_thread_target::prepare_to_store): Update.
7481         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7482         Remove.
7483         (struct ppc_ravenscar_powerpc_ops): Derive from
7484         ravenscar_arch_ops.
7485         (ppc_ravenscar_powerpc_ops::fetch_registers)
7486         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7487         (ppc_ravenscar_powerpc_ops): Redefine.
7488         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7489         (ppc_ravenscar_e500_ops::fetch_registers)
7490         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7491         (ppc_ravenscar_e500_ops): Redefine.
7492         * aarch64-ravenscar-thread.c
7493         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7494         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7495         (aarch64_ravenscar_fetch_registers)
7496         (aarch64_ravenscar_store_registers): Now methods.
7497         (aarch64_ravenscar_ops): Redefine.
7498
7499 2019-02-15  Tom Tromey  <tromey@adacore.com>
7500
7501         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7502         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7503         (ravenscar_thread_target::stopped_by_watchpoint)
7504         (ravenscar_thread_target::stopped_data_address)
7505         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7506
7507 2019-02-15  Tom Tromey  <tromey@adacore.com>
7508
7509         * ravenscar-thread.c: Fix some typos.
7510
7511 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7512             Tom Tromey  <tromey@adacore.com>
7513
7514         * ada-lang.c (ada_exception_sal): Change addr_string to a
7515         std::string.
7516         (create_ada_exception_catchpoint): Update.
7517
7518 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7519             Tom Tromey  <tromey@adacore.com>
7520
7521         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7522         (bp_location_ops): Remove.
7523         (base_breakpoint_allocate_location): Update.
7524         (free_bp_location): Update.
7525         * ada-lang.c (class ada_catchpoint_location)
7526         <ada_catchpoint_location>: Remove ops parameter.
7527         (ada_catchpoint_location_dtor): Remove.
7528         (ada_catchpoint_location_ops): Remove.
7529         (allocate_location_exception): Update.
7530         * breakpoint.h (struct bp_location_ops): Remove.
7531         (class bp_location) <bp_location>: Remove bp_location_ops
7532         parameter.
7533         <~bp_location>: Add destructor.
7534         <ops>: Remove.
7535
7536 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7537             Pedro Alves  <palves@redhat.com>
7538
7539         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7540         'PATH_MAX'.
7541
7542 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7543             Samuel Thibault  <samuel.thibault@gnu.org>
7544             Thomas Schwinge  <thomas@codesourcery.com>
7545
7546         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7547         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7548
7549 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7550
7551         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7552         (check_empty): Use "const char *".
7553
7554         * gnu-nat.c (gnu_nat_target::detach): Instead of
7555         'detach_inferior (pid)' call
7556         'detach_inferior (find_inferior_pid (pid))'.
7557
7558         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7559         'nat/fork-inferior.o'.
7560         * gnu-nat.c: #include "nat/fork-inferior.h".
7561
7562         * gnu-nat.c (gnu_nat_target::detach): Instead of
7563         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7564         * gnu-nat.h: #include "inf-child.h".
7565         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7566         'i386_gnu_nat_target::fetch_registers'.
7567         (gnu_store_registers): Rename/move to
7568         'i386_gnu_nat_target::store_registers'.
7569
7570         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7571         * gnu-nat.h (mach_thread_info): New function.
7572         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7573
7574         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7575
7576 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7577
7578         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7579
7580 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7581
7582         * windows-nat.c (windows_add_thread): Add new parameter
7583         "main_thread_p" with default value set to false.  Update
7584         function documentation as well as all callers.
7585         (windows_delete_thread): Likewise.
7586         (fake_create_process): Update call to windows_add_thread.
7587         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7588         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7589         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7590         call to windows_delete_thread.
7591
7592 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7593
7594         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7595
7596 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7597
7598         * symfile.c (find_separate_debug_file): Use canonical path of
7599         sysroot with child_path instead of gdb_sysroot if it is valid.
7600
7601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7602
7603         * symfile.c (find_separate_debug_file): Use child_path to
7604         determine if an object file is under a sysroot.
7605
7606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7607
7608         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7609         unittests/child-path-selftests.c.
7610         * common/pathstuff.c (child_path): New function.
7611         * common/pathstuff.h (child_path): New prototype.
7612         * unittests/child-path-selftests.c: New file.
7613
7614 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7615
7616         * symfile.c (find_separate_debug_file): Look for separate debug
7617         files in debug directories under the sysroot.
7618
7619 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7620
7621         * symtab.h (struct minimal_symbol data_p): New const method.
7622         (struct minimal_symbol text_p): Likewise.
7623         * symtab.c (output_source_filename): Use file name style
7624         to print file name.
7625         (print_symbol_info): Likewise.
7626         (print_msymbol_info): Use address style to print addresses.
7627         Use function name style to print executable text symbols.
7628         (expand_symtab_containing_pc): Use data_p.
7629         (find_pc_sect_compunit_symtab): Likewise.
7630
7631 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7632
7633         * breakpoint.c (describe_other_breakpoints): Use address style
7634         to print addresses.
7635         (say_where): Likewise.
7636
7637 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7638
7639         * ada-typeprint.c (print_func_type): Print function name
7640         style to print function name.
7641         * c-typeprint.c (c_print_type_1): Likewise.
7642
7643 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7644
7645         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7646         for execve.
7647
7648 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7649
7650         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7651         type_stack.
7652
7653 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7654
7655         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7656         TYPE_CODE_REF types.
7657
7658 2019-02-08  Jim Wilson  <jimw@sifive.com>
7659
7660         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7661         (riscv_linux_fregset): New.
7662         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7663
7664 2019-02-07  Tom Tromey  <tom@tromey.com>
7665
7666         * thread.c (thread_cancel_execution_command): Update.
7667         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7668         methods.
7669         (struct thread_fsm_ops): Remove.
7670         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7671         (thread_fsm_should_stop, thread_fsm_return_value)
7672         (thread_fsm_set_finished, thread_fsm_finished_p)
7673         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7674         Don't declare.
7675         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7676         * infrun.c (clear_proceed_status_thread)
7677         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7678         (print_stop_event): Update.
7679         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7680         Add constructor.
7681         (step_command_fsm_ops): Remove.
7682         (new_step_command_fsm): Remove.
7683         (step_1): Update.
7684         (step_command_fsm::should_stop): Rename from
7685         step_command_fsm_should_stop.
7686         (step_command_fsm::clean_up): Rename from
7687         step_command_fsm_clean_up.
7688         (step_command_fsm::do_async_reply_reason): Rename from
7689         step_command_fsm_async_reply_reason.
7690         (struct until_next_fsm): Inherit from thread_fsm.  Add
7691         constructor.
7692         (until_next_fsm_ops): Remove.
7693         (new_until_next_fsm): Remove.
7694         (until_next_fsm::should_stop): Rename from
7695         until_next_fsm_should_stop.
7696         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7697         (until_next_fsm::do_async_reply_reason): Rename from
7698         until_next_fsm_async_reply_reason.
7699         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7700         constructor.  Change type of breakpoint.
7701         (finish_command_fsm_ops): Remove.
7702         (new_finish_command_fsm): Remove.
7703         (finish_command_fsm::should_stop): Rename from
7704         finish_command_fsm_should_stop.
7705         (finish_command_fsm::clean_up): Rename from
7706         finish_command_fsm_clean_up.
7707         (finish_command_fsm::return_value): Rename from
7708         finish_command_fsm_return_value.
7709         (finish_command_fsm::do_async_reply_reason): Rename from
7710         finish_command_fsm_async_reply_reason.
7711         (finish_command): Update.
7712         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7713         Add constructor.
7714         (call_thread_fsm_ops): Remove.
7715         (call_thread_fsm::call_thread_fsm): Rename from
7716         new_call_thread_fsm.
7717         (call_thread_fsm::should_stop): Rename from
7718         call_thread_fsm_should_stop.
7719         (call_thread_fsm::should_notify_stop): Rename from
7720         call_thread_fsm_should_notify_stop.
7721         (run_inferior_call, call_function_by_hand_dummy): Update.
7722         * cli/cli-interp.c (should_print_stop_to_console): Update.
7723         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7724         Add constructor.  Change type of location_breakpoint,
7725         caller_breakpoint.
7726         (until_break_fsm_ops): Remove.
7727         (new_until_break_fsm): Remove.
7728         (until_break_fsm::should_stop): Rename from
7729         until_break_fsm_should_stop.
7730         (until_break_fsm::clean_up): Rename from
7731         until_break_fsm_clean_up.
7732         (until_break_fsm::do_async_reply_reason): Rename from
7733         until_break_fsm_async_reply_reason.
7734         (until_break_command): Update.
7735         * thread-fsm.c: Remove.
7736         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7737
7738 2019-02-07  Tom Tromey  <tom@tromey.com>
7739
7740         * yy-remap.h: Add include guard.
7741         * xtensa-tdep.h: Add include guard.
7742         * xcoffread.h: Rename include guard.
7743         * varobj-iter.h: Add include guard.
7744         * tui/tui.h: Rename include guard.
7745         * tui/tui-winsource.h: Rename include guard.
7746         * tui/tui-wingeneral.h: Rename include guard.
7747         * tui/tui-windata.h: Rename include guard.
7748         * tui/tui-win.h: Rename include guard.
7749         * tui/tui-stack.h: Rename include guard.
7750         * tui/tui-source.h: Rename include guard.
7751         * tui/tui-regs.h: Rename include guard.
7752         * tui/tui-out.h: Rename include guard.
7753         * tui/tui-layout.h: Rename include guard.
7754         * tui/tui-io.h: Rename include guard.
7755         * tui/tui-hooks.h: Rename include guard.
7756         * tui/tui-file.h: Rename include guard.
7757         * tui/tui-disasm.h: Rename include guard.
7758         * tui/tui-data.h: Rename include guard.
7759         * tui/tui-command.h: Rename include guard.
7760         * tic6x-tdep.h: Add include guard.
7761         * target/waitstatus.h: Rename include guard.
7762         * target/wait.h: Rename include guard.
7763         * target/target.h: Rename include guard.
7764         * target/resume.h: Rename include guard.
7765         * target-float.h: Rename include guard.
7766         * stabsread.h: Add include guard.
7767         * rs6000-tdep.h: Add include guard.
7768         * riscv-fbsd-tdep.h: Add include guard.
7769         * regformats/regdef.h: Rename include guard.
7770         * record.h: Rename include guard.
7771         * python/python.h: Rename include guard.
7772         * python/python-internal.h: Rename include guard.
7773         * python/py-stopevent.h: Rename include guard.
7774         * python/py-ref.h: Rename include guard.
7775         * python/py-record.h: Rename include guard.
7776         * python/py-record-full.h: Rename include guard.
7777         * python/py-record-btrace.h: Rename include guard.
7778         * python/py-instruction.h: Rename include guard.
7779         * python/py-events.h: Rename include guard.
7780         * python/py-event.h: Rename include guard.
7781         * procfs.h: Add include guard.
7782         * proc-utils.h: Add include guard.
7783         * p-lang.h: Add include guard.
7784         * or1k-tdep.h: Rename include guard.
7785         * observable.h: Rename include guard.
7786         * nto-tdep.h: Rename include guard.
7787         * nat/x86-linux.h: Rename include guard.
7788         * nat/x86-linux-dregs.h: Rename include guard.
7789         * nat/x86-gcc-cpuid.h: Add include guard.
7790         * nat/x86-dregs.h: Rename include guard.
7791         * nat/x86-cpuid.h: Rename include guard.
7792         * nat/ppc-linux.h: Rename include guard.
7793         * nat/mips-linux-watch.h: Rename include guard.
7794         * nat/linux-waitpid.h: Rename include guard.
7795         * nat/linux-ptrace.h: Rename include guard.
7796         * nat/linux-procfs.h: Rename include guard.
7797         * nat/linux-osdata.h: Rename include guard.
7798         * nat/linux-nat.h: Rename include guard.
7799         * nat/linux-namespaces.h: Rename include guard.
7800         * nat/linux-btrace.h: Rename include guard.
7801         * nat/glibc_thread_db.h: Rename include guard.
7802         * nat/gdb_thread_db.h: Rename include guard.
7803         * nat/gdb_ptrace.h: Rename include guard.
7804         * nat/fork-inferior.h: Rename include guard.
7805         * nat/amd64-linux-siginfo.h: Rename include guard.
7806         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7807         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7808         * nat/aarch64-linux.h: Rename include guard.
7809         * nat/aarch64-linux-hw-point.h: Rename include guard.
7810         * mn10300-tdep.h: Add include guard.
7811         * mips-linux-tdep.h: Add include guard.
7812         * mi/mi-parse.h: Rename include guard.
7813         * mi/mi-out.h: Rename include guard.
7814         * mi/mi-main.h: Rename include guard.
7815         * mi/mi-interp.h: Rename include guard.
7816         * mi/mi-getopt.h: Rename include guard.
7817         * mi/mi-console.h: Rename include guard.
7818         * mi/mi-common.h: Rename include guard.
7819         * mi/mi-cmds.h: Rename include guard.
7820         * mi/mi-cmd-break.h: Rename include guard.
7821         * m2-lang.h: Add include guard.
7822         * location.h: Rename include guard.
7823         * linux-record.h: Rename include guard.
7824         * linux-nat.h: Add include guard.
7825         * linux-fork.h: Add include guard.
7826         * i386-darwin-tdep.h: Rename include guard.
7827         * hppa-linux-offsets.h: Add include guard.
7828         * guile/guile.h: Rename include guard.
7829         * guile/guile-internal.h: Rename include guard.
7830         * gnu-nat.h: Rename include guard.
7831         * gdb-stabs.h: Rename include guard.
7832         * frv-tdep.h: Add include guard.
7833         * f-lang.h: Add include guard.
7834         * event-loop.h: Add include guard.
7835         * darwin-nat.h: Rename include guard.
7836         * cp-abi.h: Rename include guard.
7837         * config/sparc/nm-sol2.h: Rename include guard.
7838         * config/nm-nto.h: Rename include guard.
7839         * config/nm-linux.h: Add include guard.
7840         * config/i386/nm-i386gnu.h: Rename include guard.
7841         * config/djgpp/nl_types.h: Rename include guard.
7842         * config/djgpp/langinfo.h: Rename include guard.
7843         * compile/gcc-cp-plugin.h: Add include guard.
7844         * compile/gcc-c-plugin.h: Add include guard.
7845         * compile/compile.h: Rename include guard.
7846         * compile/compile-object-run.h: Rename include guard.
7847         * compile/compile-object-load.h: Rename include guard.
7848         * compile/compile-internal.h: Rename include guard.
7849         * compile/compile-cplus.h: Rename include guard.
7850         * compile/compile-c.h: Rename include guard.
7851         * common/xml-utils.h: Rename include guard.
7852         * common/x86-xstate.h: Rename include guard.
7853         * common/version.h: Rename include guard.
7854         * common/vec.h: Rename include guard.
7855         * common/tdesc.h: Rename include guard.
7856         * common/selftest.h: Rename include guard.
7857         * common/scoped_restore.h: Rename include guard.
7858         * common/scoped_mmap.h: Rename include guard.
7859         * common/scoped_fd.h: Rename include guard.
7860         * common/safe-iterator.h: Rename include guard.
7861         * common/run-time-clock.h: Rename include guard.
7862         * common/refcounted-object.h: Rename include guard.
7863         * common/queue.h: Rename include guard.
7864         * common/ptid.h: Rename include guard.
7865         * common/print-utils.h: Rename include guard.
7866         * common/preprocessor.h: Rename include guard.
7867         * common/pathstuff.h: Rename include guard.
7868         * common/observable.h: Rename include guard.
7869         * common/netstuff.h: Rename include guard.
7870         * common/job-control.h: Rename include guard.
7871         * common/host-defs.h: Rename include guard.
7872         * common/gdb_wait.h: Rename include guard.
7873         * common/gdb_vecs.h: Rename include guard.
7874         * common/gdb_unlinker.h: Rename include guard.
7875         * common/gdb_unique_ptr.h: Rename include guard.
7876         * common/gdb_tilde_expand.h: Rename include guard.
7877         * common/gdb_sys_time.h: Rename include guard.
7878         * common/gdb_string_view.h: Rename include guard.
7879         * common/gdb_splay_tree.h: Rename include guard.
7880         * common/gdb_setjmp.h: Rename include guard.
7881         * common/gdb_ref_ptr.h: Rename include guard.
7882         * common/gdb_optional.h: Rename include guard.
7883         * common/gdb_locale.h: Rename include guard.
7884         * common/gdb_assert.h: Rename include guard.
7885         * common/filtered-iterator.h: Rename include guard.
7886         * common/filestuff.h: Rename include guard.
7887         * common/fileio.h: Rename include guard.
7888         * common/environ.h: Rename include guard.
7889         * common/common-utils.h: Rename include guard.
7890         * common/common-types.h: Rename include guard.
7891         * common/common-regcache.h: Rename include guard.
7892         * common/common-inferior.h: Rename include guard.
7893         * common/common-gdbthread.h: Rename include guard.
7894         * common/common-exceptions.h: Rename include guard.
7895         * common/common-defs.h: Rename include guard.
7896         * common/common-debug.h: Rename include guard.
7897         * common/cleanups.h: Rename include guard.
7898         * common/buffer.h: Rename include guard.
7899         * common/btrace-common.h: Rename include guard.
7900         * common/break-common.h: Rename include guard.
7901         * cli/cli-utils.h: Rename include guard.
7902         * cli/cli-style.h: Rename include guard.
7903         * cli/cli-setshow.h: Rename include guard.
7904         * cli/cli-script.h: Rename include guard.
7905         * cli/cli-interp.h: Rename include guard.
7906         * cli/cli-decode.h: Rename include guard.
7907         * cli/cli-cmds.h: Rename include guard.
7908         * charset-list.h: Add include guard.
7909         * buildsym-legacy.h: Rename include guard.
7910         * bfin-tdep.h: Add include guard.
7911         * ax.h: Rename include guard.
7912         * arm-linux-tdep.h: Add include guard.
7913         * arm-fbsd-tdep.h: Add include guard.
7914         * arch/xtensa.h: Rename include guard.
7915         * arch/tic6x.h: Add include guard.
7916         * arch/i386.h: Add include guard.
7917         * arch/arm.h: Rename include guard.
7918         * arch/arm-linux.h: Rename include guard.
7919         * arch/arm-get-next-pcs.h: Rename include guard.
7920         * arch/amd64.h: Add include guard.
7921         * arch/aarch64-insn.h: Rename include guard.
7922         * arch-utils.h: Rename include guard.
7923         * annotate.h: Add include guard.
7924         * amd64-darwin-tdep.h: Rename include guard.
7925         * aarch64-linux-tdep.h: Add include guard.
7926         * aarch64-fbsd-tdep.h: Add include guard.
7927         * aarch32-linux-nat.h: Add include guard.
7928
7929 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7930
7931         * macrotab.c (macro_define_internal): New function that
7932         factorizes macro_define_object_internal and macro_define_function
7933         code.
7934         (macro_define_object_internal): Use macro_define_internal.
7935         (macro_define_function): Likewise.
7936
7937 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7938
7939         * macrocmd.c (extract_identifier): Return
7940         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7941         callers.
7942
7943 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7944
7945         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7946
7947 2019-02-05  Tom Tromey  <tom@tromey.com>
7948
7949         * target.c (target_stack::unpush): Move assertion earlier.
7950
7951 2019-01-30  Tom Tromey  <tom@tromey.com>
7952
7953         PR python/23615:
7954         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7955         (gdbpy_parse_and_eval): Likewise.
7956         * python/python-internal.h (gdbpy_allow_threads): New class.
7957
7958 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7959
7960         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7961         (aarch64_fbsd_fpregmap): Move earlier.
7962         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7963         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7964         instead of individual calls to trad_frame_set_reg_addr.
7965         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7966         earlier.
7967         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7968         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7969         instead of individual calls to trad_frame_set_reg_addr.
7970
7971 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7972
7973         * CONTRIBUTE: Replace contribution list with wiki link.
7974
7975 2019-01-25  Tom Tromey  <tom@tromey.com>
7976
7977         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7978
7979 2019-01-25  Tom Tromey  <tom@tromey.com>
7980
7981         * xtensa-linux-nat.c: Fix common/ includes.
7982         * xml-support.h: Fix common/ includes.
7983         * xml-support.c: Fix common/ includes.
7984         * x86-linux-nat.c: Fix common/ includes.
7985         * windows-nat.c: Fix common/ includes.
7986         * varobj.h: Fix common/ includes.
7987         * varobj.c: Fix common/ includes.
7988         * value.c: Fix common/ includes.
7989         * valops.c: Fix common/ includes.
7990         * utils.c: Fix common/ includes.
7991         * unittests/xml-utils-selftests.c: Fix common/ includes.
7992         * unittests/utils-selftests.c: Fix common/ includes.
7993         * unittests/unpack-selftests.c: Fix common/ includes.
7994         * unittests/tracepoint-selftests.c: Fix common/ includes.
7995         * unittests/style-selftests.c: Fix common/ includes.
7996         * unittests/string_view-selftests.c: Fix common/ includes.
7997         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7998         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7999         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8000         * unittests/rsp-low-selftests.c: Fix common/ includes.
8001         * unittests/parse-connection-spec-selftests.c: Fix common/
8002         includes.
8003         * unittests/optional-selftests.c: Fix common/ includes.
8004         * unittests/offset-type-selftests.c: Fix common/ includes.
8005         * unittests/observable-selftests.c: Fix common/ includes.
8006         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8007         * unittests/memrange-selftests.c: Fix common/ includes.
8008         * unittests/memory-map-selftests.c: Fix common/ includes.
8009         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8010         * unittests/function-view-selftests.c: Fix common/ includes.
8011         * unittests/environ-selftests.c: Fix common/ includes.
8012         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8013         * unittests/common-utils-selftests.c: Fix common/ includes.
8014         * unittests/cli-utils-selftests.c: Fix common/ includes.
8015         * unittests/array-view-selftests.c: Fix common/ includes.
8016         * ui-file.c: Fix common/ includes.
8017         * tui/tui-io.c: Fix common/ includes.
8018         * tracepoint.h: Fix common/ includes.
8019         * tracepoint.c: Fix common/ includes.
8020         * tracefile-tfile.c: Fix common/ includes.
8021         * top.h: Fix common/ includes.
8022         * top.c: Fix common/ includes.
8023         * thread.c: Fix common/ includes.
8024         * target/waitstatus.h: Fix common/ includes.
8025         * target/waitstatus.c: Fix common/ includes.
8026         * target.h: Fix common/ includes.
8027         * target.c: Fix common/ includes.
8028         * target-memory.c: Fix common/ includes.
8029         * target-descriptions.c: Fix common/ includes.
8030         * symtab.h: Fix common/ includes.
8031         * symfile.c: Fix common/ includes.
8032         * stap-probe.c: Fix common/ includes.
8033         * spu-linux-nat.c: Fix common/ includes.
8034         * sparc-nat.c: Fix common/ includes.
8035         * source.c: Fix common/ includes.
8036         * solib.c: Fix common/ includes.
8037         * solib-target.c: Fix common/ includes.
8038         * ser-unix.c: Fix common/ includes.
8039         * ser-tcp.c: Fix common/ includes.
8040         * ser-pipe.c: Fix common/ includes.
8041         * ser-base.c: Fix common/ includes.
8042         * selftest-arch.c: Fix common/ includes.
8043         * s12z-tdep.c: Fix common/ includes.
8044         * rust-exp.y: Fix common/ includes.
8045         * rs6000-aix-tdep.c: Fix common/ includes.
8046         * riscv-tdep.c: Fix common/ includes.
8047         * remote.c: Fix common/ includes.
8048         * remote-notif.h: Fix common/ includes.
8049         * remote-fileio.h: Fix common/ includes.
8050         * remote-fileio.c: Fix common/ includes.
8051         * regcache.h: Fix common/ includes.
8052         * regcache.c: Fix common/ includes.
8053         * record-btrace.c: Fix common/ includes.
8054         * python/python.c: Fix common/ includes.
8055         * python/py-type.c: Fix common/ includes.
8056         * python/py-inferior.c: Fix common/ includes.
8057         * progspace.h: Fix common/ includes.
8058         * producer.c: Fix common/ includes.
8059         * procfs.c: Fix common/ includes.
8060         * proc-api.c: Fix common/ includes.
8061         * printcmd.c: Fix common/ includes.
8062         * ppc-linux-nat.c: Fix common/ includes.
8063         * parser-defs.h: Fix common/ includes.
8064         * osdata.c: Fix common/ includes.
8065         * obsd-nat.c: Fix common/ includes.
8066         * nat/x86-linux.c: Fix common/ includes.
8067         * nat/x86-linux-dregs.c: Fix common/ includes.
8068         * nat/x86-dregs.h: Fix common/ includes.
8069         * nat/x86-dregs.c: Fix common/ includes.
8070         * nat/ppc-linux.c: Fix common/ includes.
8071         * nat/mips-linux-watch.h: Fix common/ includes.
8072         * nat/mips-linux-watch.c: Fix common/ includes.
8073         * nat/linux-waitpid.c: Fix common/ includes.
8074         * nat/linux-ptrace.h: Fix common/ includes.
8075         * nat/linux-ptrace.c: Fix common/ includes.
8076         * nat/linux-procfs.c: Fix common/ includes.
8077         * nat/linux-personality.c: Fix common/ includes.
8078         * nat/linux-osdata.c: Fix common/ includes.
8079         * nat/linux-namespaces.c: Fix common/ includes.
8080         * nat/linux-btrace.h: Fix common/ includes.
8081         * nat/linux-btrace.c: Fix common/ includes.
8082         * nat/fork-inferior.c: Fix common/ includes.
8083         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8084         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8085         * nat/aarch64-linux.c: Fix common/ includes.
8086         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8087         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8088         * namespace.h: Fix common/ includes.
8089         * mips-linux-tdep.c: Fix common/ includes.
8090         * minsyms.c: Fix common/ includes.
8091         * mi/mi-parse.h: Fix common/ includes.
8092         * mi/mi-main.c: Fix common/ includes.
8093         * mi/mi-cmd-env.c: Fix common/ includes.
8094         * memrange.h: Fix common/ includes.
8095         * memattr.c: Fix common/ includes.
8096         * maint.h: Fix common/ includes.
8097         * maint.c: Fix common/ includes.
8098         * main.c: Fix common/ includes.
8099         * machoread.c: Fix common/ includes.
8100         * location.c: Fix common/ includes.
8101         * linux-thread-db.c: Fix common/ includes.
8102         * linux-nat.c: Fix common/ includes.
8103         * linux-fork.c: Fix common/ includes.
8104         * inline-frame.c: Fix common/ includes.
8105         * infrun.c: Fix common/ includes.
8106         * inflow.c: Fix common/ includes.
8107         * inferior.h: Fix common/ includes.
8108         * inferior.c: Fix common/ includes.
8109         * infcmd.c: Fix common/ includes.
8110         * inf-ptrace.c: Fix common/ includes.
8111         * inf-child.c: Fix common/ includes.
8112         * ia64-linux-nat.c: Fix common/ includes.
8113         * i387-tdep.c: Fix common/ includes.
8114         * i386-tdep.c: Fix common/ includes.
8115         * i386-linux-tdep.c: Fix common/ includes.
8116         * i386-linux-nat.c: Fix common/ includes.
8117         * i386-go32-tdep.c: Fix common/ includes.
8118         * i386-fbsd-tdep.c: Fix common/ includes.
8119         * i386-fbsd-nat.c: Fix common/ includes.
8120         * guile/scm-type.c: Fix common/ includes.
8121         * guile/guile.c: Fix common/ includes.
8122         * go32-nat.c: Fix common/ includes.
8123         * gnu-nat.c: Fix common/ includes.
8124         * gdbthread.h: Fix common/ includes.
8125         * gdbarch-selftests.c: Fix common/ includes.
8126         * gdb_usleep.c: Fix common/ includes.
8127         * gdb_select.h: Fix common/ includes.
8128         * gdb_bfd.c: Fix common/ includes.
8129         * gcore.c: Fix common/ includes.
8130         * fork-child.c: Fix common/ includes.
8131         * findvar.c: Fix common/ includes.
8132         * fbsd-nat.c: Fix common/ includes.
8133         * event-top.c: Fix common/ includes.
8134         * event-loop.c: Fix common/ includes.
8135         * dwarf2read.c: Fix common/ includes.
8136         * dwarf2loc.c: Fix common/ includes.
8137         * dwarf2-frame.c: Fix common/ includes.
8138         * dwarf-index-cache.c: Fix common/ includes.
8139         * dtrace-probe.c: Fix common/ includes.
8140         * disasm-selftests.c: Fix common/ includes.
8141         * defs.h: Fix common/ includes.
8142         * csky-tdep.c: Fix common/ includes.
8143         * cp-valprint.c: Fix common/ includes.
8144         * cp-support.h: Fix common/ includes.
8145         * cp-support.c: Fix common/ includes.
8146         * corelow.c: Fix common/ includes.
8147         * completer.h: Fix common/ includes.
8148         * completer.c: Fix common/ includes.
8149         * compile/compile.c: Fix common/ includes.
8150         * compile/compile-loc2c.c: Fix common/ includes.
8151         * compile/compile-cplus-types.c: Fix common/ includes.
8152         * compile/compile-cplus-symbols.c: Fix common/ includes.
8153         * command.h: Fix common/ includes.
8154         * cli/cli-dump.c: Fix common/ includes.
8155         * cli/cli-cmds.c: Fix common/ includes.
8156         * charset.c: Fix common/ includes.
8157         * build-id.c: Fix common/ includes.
8158         * btrace.h: Fix common/ includes.
8159         * btrace.c: Fix common/ includes.
8160         * breakpoint.h: Fix common/ includes.
8161         * breakpoint.c: Fix common/ includes.
8162         * ax.h: 
8163         (enum agent_op): Fix common/ includes.
8164         * ax-general.c (struct aop_map): Fix common/ includes.
8165         * ax-gdb.c: Fix common/ includes.
8166         * auxv.c: Fix common/ includes.
8167         * auto-load.c: Fix common/ includes.
8168         * arm-tdep.c: Fix common/ includes.
8169         * arch/riscv.c: Fix common/ includes.
8170         * arch/ppc-linux-common.c: Fix common/ includes.
8171         * arch/i386.c: Fix common/ includes.
8172         * arch/arm.c: Fix common/ includes.
8173         * arch/arm-linux.c: Fix common/ includes.
8174         * arch/arm-get-next-pcs.c: Fix common/ includes.
8175         * arch/amd64.c: Fix common/ includes.
8176         * arch/aarch64.c: Fix common/ includes.
8177         * arch/aarch64-insn.c: Fix common/ includes.
8178         * arch-utils.c: Fix common/ includes.
8179         * amd64-windows-tdep.c: Fix common/ includes.
8180         * amd64-tdep.c: Fix common/ includes.
8181         * amd64-sol2-tdep.c: Fix common/ includes.
8182         * amd64-obsd-tdep.c: Fix common/ includes.
8183         * amd64-nbsd-tdep.c: Fix common/ includes.
8184         * amd64-linux-tdep.c: Fix common/ includes.
8185         * amd64-linux-nat.c: Fix common/ includes.
8186         * amd64-fbsd-tdep.c: Fix common/ includes.
8187         * amd64-fbsd-nat.c: Fix common/ includes.
8188         * amd64-dicos-tdep.c: Fix common/ includes.
8189         * amd64-darwin-tdep.c: Fix common/ includes.
8190         * agent.c: Fix common/ includes.
8191         * ada-lang.h: Fix common/ includes.
8192         * ada-lang.c: Fix common/ includes.
8193         * aarch64-tdep.c: Fix common/ includes.
8194
8195 2019-01-25  Tom Tromey  <tom@tromey.com>
8196
8197         * common/create-version.sh: Use common/version.h.
8198
8199 2019-01-24  Pedro Alves  <palves@redhat.com>
8200
8201         * infrun.c (signal_stop, signal_print, signal_program)
8202         (signal_catch, signal_pass): Now arrays instead of pointers.
8203         (update_signals_program_target, do_target_resume)
8204         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8205         * linux-nat.c (linux_nat_target::pass_signals)
8206         (linux_nat_target::create_inferior, linux_nat_target::attach):
8207         Adjust.
8208         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8209         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8210         * procfs.c (procfs_target::pass_signals): Adjust.
8211         * record-full.c (record_full_target::resume): Adjust.
8212         * remote.c (remote_target::pass_signals)
8213         (remote_target::program_signals): Adjust.
8214         * target-debug.h (target_debug_print_signals): Now takes a
8215         gdb::array_view as parameter.  Adjust.
8216         * target.h (target_ops) <pass_signals, program_signals>: Replace
8217         pointer and length parameters with gdb::array_view.
8218         (target_pass_signals, target_program_signals): Likewise.
8219         * target-delegates.c: Regenerate.
8220
8221 2019-01-24  Pedro Alves  <palves@redhat.com>
8222
8223         * common/forward-scope-exit.h
8224         (forward_scope_exit::forward_scope_exit): Pass arguments to
8225         m_bind_function directly, instead of creating a std::bind and
8226         copying that.
8227
8228 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8229
8230         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8231         for static members.
8232         (pass_in_v_vfp_candidate): Likewise.
8233
8234 2019-01-23  Tom Tromey  <tom@tromey.com>
8235             Pedro Alves  <palves@redhat.com>
8236
8237         * regcache.c (class regcache_invalidator): Remove.
8238         (regcache::raw_write): Use make_scope_exit.
8239
8240 2019-01-23  Tom Tromey  <tom@tromey.com>
8241
8242         * ui-out.h (class ui_out_emit_type): Update comment.
8243
8244 2019-01-23  Tom Tromey  <tom@tromey.com>
8245
8246         * infrun.c (fetch_inferior_event): Update comment.
8247
8248 2019-01-23  Tom Tromey  <tom@tromey.com>
8249             Pedro Alves  <palves@redhat.com>
8250
8251         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8252         parameter.
8253         (fetch_inferior_event): Use SCOPE_EXIT.
8254
8255
8256 2019-01-23  Tom Tromey  <tom@tromey.com>
8257             Pedro Alves  <palves@redhat.com>
8258
8259         * infrun.c (disable_thread_events): Delete.
8260         (stop_all_threads): Use SCOPE_EXIT.
8261
8262 2019-01-23  Tom Tromey  <tom@tromey.com>
8263             Pedro Alves  <palves@redhat.com>
8264
8265         * symfile.c: Include forward-scope-exit.h.
8266         (clear_symtab_users_cleanup): Replace forward declaration with
8267         a FORWARD_SCOPE_EXIT.
8268         (syms_from_objfile_1): Use the forward_scope_exit and
8269         gdb::optional instead of cleanup_function.
8270         (reread_symbols): Use the forward_scope_exit instead of
8271         cleanup_function.
8272         (clear_symtab_users_cleanup): Remove function.
8273
8274 2019-01-23  Tom Tromey  <tom@tromey.com>
8275             Pedro Alves  <palves@redhat.com>
8276
8277         * linux-nat.c: Include scope-exit.h.
8278         (cleanup_target_stop): Remove.
8279         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8280         SCOPE_EXIT.
8281
8282 2019-01-23  Tom Tromey  <tom@tromey.com>
8283             Pedro Alves  <palves@redhat.com>
8284
8285         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8286         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8287
8288 2019-01-23  Tom Tromey  <tom@tromey.com>
8289             Andrew Burgess  <andrew.burgess@embecosm.com>
8290             Pedro Alves  <palves@redhat.com>
8291
8292         * infrun.c (fetch_inferior_event): Use scope_exit.
8293         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8294         * top.c (execute_command): Use scope_exit.
8295         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8296         * utils.c (do_bpstat_clear_actions_cleanup)
8297         (make_bpstat_clear_actions_cleanup): Remove.
8298
8299 2019-01-23  Tom Tromey  <tom@tromey.com>
8300             Pedro Alves  <palves@redhat.com>
8301
8302         * infrun.c: Include "common/scope-exit.h"
8303         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8304         (wait_for_inferior): Use SCOPE_EXIT.
8305         (fetch_inferior_event): Use scope_exit.
8306
8307 2019-01-23  Tom Tromey  <tom@tromey.com>
8308             Pedro Alves  <palves@redhat.com>
8309
8310         * breakpoint.c (create_breakpoint): Remove cleanup.
8311
8312 2019-01-23  Tom Tromey  <tom@tromey.com>
8313             Andrew Burgess  <andrew.burgess@embecosm.com>
8314             Pedro Alves  <palves@redhat.com>
8315
8316 2019-01-23  Pedro Alves  <palves@redhat.com>
8317
8318         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8319
8320 2019-01-23  Pedro Alves  <palves@redhat.com>
8321             Andrew Burgess  <andrew.burgess@embecosm.com>
8322
8323         * gdbthread.h: Include "common/forward-scope-exit.h".
8324         (scoped_finish_thread_state): Redefine custom class in terms of
8325         forward_scope_exit.
8326
8327 2019-01-23  Pedro Alves  <palves@redhat.com>
8328             Andrew Burgess  <andrew.burgess@embecosm.com>
8329
8330         * common/forward-scope-exit.h: New file.
8331
8332 2019-01-23  Pedro Alves  <palves@redhat.com>
8333             Andrew Burgess  <andrew.burgess@embecosm.com>
8334             Tom Tromey  <tom@tromey.com>
8335
8336         * common/scope-exit.h: New file.
8337
8338 2019-01-23  Pedro Alves  <palves@redhat.com>
8339
8340         * common/preprocessor.h (ESC): Rename to ...
8341         (ESC_PARENS): ... this.
8342         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8343         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8344
8345 2019-01-23  Tom Tromey  <tom@tromey.com>
8346
8347         * language.h (class scoped_switch_to_sym_language_if_auto):
8348         Initialize m_lang in both cases.
8349
8350 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8351
8352         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8353         with XCNEW.
8354
8355 2019-01-22  Tom Tromey  <tom@tromey.com>
8356
8357         * corelow.c: Do not include sys/file.h.
8358
8359 2019-01-22  Tom Tromey  <tom@tromey.com>
8360
8361         * tui/tui-wingeneral.h: Include gdb_curses.h.
8362
8363 2019-01-22  Tom Tromey  <tom@tromey.com>
8364
8365         * source-cache.h (class source_cache) <get_source_lines,
8366         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8367
8368 2019-01-22  Tom Tromey  <tom@tromey.com>
8369
8370         * remote-fileio.h (struct remote_target): Declare.
8371
8372 2019-01-22  Tom Tromey  <tom@tromey.com>
8373
8374         * python/py-arch.c: Do not include py-ref.h.
8375         * python/py-bpevent.c: Do not include py-ref.h.
8376         * python/py-cmd.c: Do not include py-ref.h.
8377         * python/py-continueevent.c: Do not include py-ref.h.
8378         * python/py-event.h: Do not include py-ref.h.
8379         * python/py-evtregistry.c: Do not include py-ref.h.
8380         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8381         * python/py-frame.c: Do not include py-ref.h.
8382         * python/py-framefilter.c: Do not include py-ref.h.
8383         * python/py-function.c: Do not include py-ref.h.
8384         * python/py-infevents.c: Do not include py-ref.h.
8385         * python/py-linetable.c: Do not include py-ref.h.
8386         * python/py-objfile.c: Do not include py-ref.h.
8387         * python/py-param.c: Do not include py-ref.h.
8388         * python/py-prettyprint.c: Do not include py-ref.h.
8389         * python/py-progspace.c: Do not include py-ref.h.
8390         * python/py-symbol.c: Do not include py-ref.h.
8391         * python/py-symtab.c: Do not include py-ref.h.
8392         * python/py-type.c: Do not include py-ref.h.
8393         * python/py-unwind.c: Do not include py-ref.h.
8394         * python/py-utils.c: Do not include py-ref.h.
8395         * python/py-value.c: Do not include py-ref.h.
8396         * python/py-varobj.c: Do not include py-ref.h.
8397         * python/py-xmethods.c: Do not include py-ref.h.
8398         * python/python.c: Do not include py-ref.h.
8399         * varobj.c: Do not include py-ref.h.
8400
8401 2019-01-22  Tom Tromey  <tom@tromey.com>
8402
8403         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8404         keyword for bcache.
8405
8406 2019-01-22  Tom Tromey  <tom@tromey.com>
8407
8408         * compile/compile-cplus-types.c: Remove a comment by #include.
8409
8410 2019-01-22  Tom Tromey  <tom@tromey.com>
8411
8412         * compile/gcc-c-plugin.h: Include compile-internal.h.
8413
8414 2019-01-22  Tom Tromey  <tom@tromey.com>
8415
8416         * stabsread.c (EXTERN): Do not define.
8417         (symnum, next_symbol_text_func, processing_gcc_compilation)
8418         (within_function, global_sym_chain, global_stabs)
8419         (previous_stab_code, this_object_header_files)
8420         (n_this_object_header_files)
8421         (n_allocated_this_object_header_files): Define.
8422         * stabsread.h (EXTERN): Never define.  Use "extern".
8423
8424 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8425
8426         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8427         history_value.
8428
8429 2019-01-21  Tom Tromey  <tom@tromey.com>
8430
8431         * ui-out.c: Fix includes.
8432         * tui/tui-source.c: Fix includes.
8433         * target.c: Fix includes.
8434         * remote.c: Fix includes.
8435         * regcache.c: Fix includes.
8436         * python/py-block.c: Fix includes.
8437         * printcmd.c: Fix includes.
8438         * or1k-tdep.c: Fix includes.
8439         * mi/mi-main.c: Fix includes.
8440         * m32r-tdep.c: Fix includes.
8441         * csky-tdep.c: Fix includes.
8442         * compile/compile-cplus-types.c: Fix includes.
8443         * cli/cli-interp.c: Fix includes.
8444
8445 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8446
8447         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8448         for padding.
8449
8450 2019-01-16  Tom Tromey  <tom@tromey.com>
8451
8452         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8453         earlier.
8454         (struct objfile) <msymbols_range>: Move from top level.
8455         <msymbols>: New method.
8456         (class objfile_msymbols): Remove.
8457         * symtab.c (default_collect_symbol_completion_matches_break_on):
8458         Update.
8459         * symmisc.c (dump_msymbols): Update.
8460         * stabsread.c (scan_file_globals): Update.
8461         * objc-lang.c (info_selectors_command, info_classes_command)
8462         (find_methods): Update.
8463         * minsyms.c (find_solib_trampoline_target): Update.
8464         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8465         * coffread.c (coff_symfile_read): Update.
8466         * ada-lang.c (ada_lookup_simple_minsym)
8467         (ada_collect_symbol_completion_matches): Update.
8468
8469 2019-01-16  Tom Tromey  <tom@tromey.com>
8470
8471         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8472         type.  Remove no-argument constructor.
8473         <iterator::operator++>: Simplify.
8474         <begin>: Update.
8475         <end>: Use minimal_symbol_count.
8476
8477 2019-01-16  Tom Tromey  <tom@tromey.com>
8478
8479         * objfiles.h (struct objfile) <psymtabs>: New method.
8480         (class objfile_psymtabs): Remove.
8481         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8482         typedef.
8483         <range>: New method.
8484         (require_partial_symbols): Change return type.
8485         * psymtab.c (require_partial_symbols)
8486         (psym_expand_symtabs_matching): Update.
8487         * mdebugread.c (parse_partial_symbols): Update.
8488         * dbxread.c (dbx_end_psymtab): Update.
8489
8490 2019-01-15  Tom Tromey  <tom@tromey.com>
8491
8492         * symtab.c (lookup_objfile_from_block)
8493         (lookup_symbol_in_objfile_symtabs)
8494         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8495         (find_line_symtab, info_sources_command)
8496         (default_collect_symbol_completion_matches_break_on)
8497         (make_source_files_completion_list): Update.
8498         * symmisc.c (print_objfile_statistics, dump_objfile)
8499         (maintenance_print_symbols, maintenance_info_symtabs)
8500         (maintenance_check_symtabs, maintenance_info_line_tables):
8501         Update.
8502         * source.c (select_source_symtab)
8503         (forget_cached_source_info_for_objfile): Update.
8504         * objfiles.h (class objfile_compunits): Remove.
8505         (struct objfile) <compunits_range>: New typedef.
8506         (compunits): New method.
8507         * objfiles.c (objfile_relocate1): Update.
8508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8509         * maint.c (count_symtabs_and_blocks): Update.
8510         * linespec.c (iterate_over_all_matching_symtabs): Update.
8511         * cp-support.c (add_symbol_overload_list_qualified): Update.
8512         * coffread.c (coff_symtab_read): Update.
8513         * ada-lang.c (add_nonlocal_symbols)
8514         (ada_collect_symbol_completion_matches)
8515         (ada_add_global_exceptions): Update.
8516
8517 2019-01-15  Tom Tromey  <tom@tromey.com>
8518
8519         * progspace.h (program_space) <objfiles_safe_range>: New
8520         typedef.
8521         <objfiles_safe>: New method.
8522         * objfiles.h (class all_objfiles_safe): Remove.
8523         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8524         * jit.c (jit_inferior_exit_hook): Update.
8525
8526 2019-01-17  Tom Tromey  <tom@tromey.com>
8527
8528         * progspace.h (program_space) <objfiles_range>: New typedef.
8529         <objfiles>: New method.
8530         <objfiles_head>: Rename from objfiles.
8531         (object_files): Update.
8532         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8533         * guile/scm-pretty-print.c
8534         (ppscm_find_pretty_printer_from_objfiles): Update.
8535         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8536         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8537         Update.
8538         * python/py-progspace.c (pspy_get_objfiles): Update.
8539         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8540         Update.
8541         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8542         (objfpy_lookup_objfile_by_build_id): Update.
8543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8544         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8545         Update.
8546         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8547         (expand_symtab_containing_pc, lookup_objfile_from_block)
8548         (lookup_static_symbol, basic_lookup_transparent_type)
8549         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8550         (find_line_symtab, info_sources_command)
8551         (default_collect_symbol_completion_matches_break_on)
8552         (make_source_files_completion_list, find_main_name): Update.
8553         * symmisc.c (print_symbol_bcache_statistics)
8554         (print_objfile_statistics, maintenance_print_symbols)
8555         (maintenance_print_msymbols, maintenance_print_objfiles)
8556         (maintenance_info_symtabs, maintenance_check_symtabs)
8557         (maintenance_expand_symtabs, maintenance_info_line_tables):
8558         Update.
8559         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8560         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8561         (map_overlay_command, unmap_overlay_command)
8562         (simple_overlay_update, expand_symtabs_matching)
8563         (map_symbol_filenames): Update.
8564         * symfile-debug.c (set_debug_symfile): Update.
8565         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8566         Update.
8567         * source.c (select_source_symtab, forget_cached_source_info):
8568         Update.
8569         * solib.c (solib_read_symbols): Update.
8570         * solib-spu.c (append_ocl_sos): Update.
8571         * psymtab.c (maintenance_print_psymbols)
8572         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8573         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8574         * printcmd.c (info_symbol_command): Update.
8575         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8576         Update.
8577         * objfiles.h (class all_objfiles): Remove.
8578         * objfiles.c (have_partial_symbols, have_full_symbols)
8579         (have_minimal_symbols, qsort_cmp, update_section_map)
8580         (shared_objfile_contains_address_p)
8581         (default_iterate_over_objfiles_in_search_order): Update.
8582         * objc-lang.c (info_selectors_command, info_classes_command)
8583         (find_methods): Update.
8584         * minsyms.c (find_solib_trampoline_target): Update.
8585         * maint.c (maintenance_info_sections)
8586         (maintenance_translate_address, count_symtabs_and_blocks):
8587         Update.
8588         * main.c (captured_main_1): Update.
8589         * linux-thread-db.c (try_thread_db_load_from_pdir)
8590         (has_libpthread): Update.
8591         * linespec.c (iterate_over_all_matching_symtabs)
8592         (search_minsyms_for_name): Update.
8593         * jit.c (jit_find_objf_with_entry_addr): Update.
8594         * hppa-tdep.c (find_unwind_entry)
8595         (hppa_lookup_stub_minimal_symbol): Update.
8596         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8597         Update.
8598         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8599         (elf_gnu_ifunc_resolve_by_got): Update.
8600         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8601         * dwarf-index-write.c (save_gdb_index_command): Update.
8602         * cp-support.c (add_symbol_overload_list_qualified): Update.
8603         * breakpoint.c (create_overlay_event_breakpoint)
8604         (create_longjmp_master_breakpoint)
8605         (create_std_terminate_master_breakpoint)
8606         (create_exception_master_breakpoint): Update.
8607         * blockframe.c (find_pc_partial_function): Update.
8608         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8609         (ada_collect_symbol_completion_matches)
8610         (ada_add_global_exceptions): Update.
8611
8612 2019-01-17  Tom Tromey  <tom@tromey.com>
8613
8614         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8615         declare VEC.
8616         (solib_target_parse_libraries): Change return type.
8617         (library_list_start_segment, library_list_start_section)
8618         (library_list_end_library, library_list_start_library); Update.
8619         (solib_target_free_library_list): Remove.
8620         (solib_target_parse_libraries): Remove cleanup.  Change return
8621         type.
8622         (solib_target_current_sos): Update.
8623
8624 2019-01-17  Tom Tromey  <tromey@bapiya>
8625
8626         * valprint.c: Replace "the the" with "the".
8627         * symtab.c: Replace "the the" with "the".
8628         * solib.c: Replace "the the" with "the".
8629         * solib-dsbt.c: Replace "the the" with "the".
8630         * linespec.c: Replace "the the" with "the".
8631         * dwarf2loc.h: Replace "the the" with "the".
8632         * amd64-windows-tdep.c: Replace "the the" with "the".
8633         * aarch64-tdep.c: Replace "the the" with "the".
8634
8635 2019-01-16  Keith Seitz  <keiths@redhat.com>
8636
8637         PR gdb/23773
8638         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8639         <builder>: Rename to ..
8640         <m_builder>: ... this and make private.
8641         (dwarf2_cu::get_builder): New method.  Change all users of
8642         `builder' to use this method.
8643         (dwarf2_start_symtab): Move to ...
8644         (dwarf2_cu::start_symtab): ... here.  Update all callers
8645         (setup_type_unit_groups): Move to ...
8646         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8647         callers.
8648         (dwarf2_cu::reset_builder): New method.
8649         (process_full_compunit, process_full_type_unit): Use
8650         dwarf2_cu::reset_builder.
8651         (follow_die_offset): Record the ancestor CU if it is different
8652         from the followed DIE's CU.
8653         (follow_die_sig_1): Likewise.
8654
8655 2019-01-15  Tom Tromey  <tom@tromey.com>
8656
8657         * remote.c (class remote_state) <buf>: Now a char_vector.
8658         <buf_size>: Remove.
8659         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8660         parameter.
8661         (remote_target::getpkt_or_notif_sane_1)
8662         (remote_target::getpkt_sane)
8663         (remote_target::getpkt_or_notif_sane): Likewise.
8664         (class remote_target) <putpkt>: New overload.
8665         (remote_target::read_frame): Change type of "buf_p".  Remove
8666         sizeof_p parameter.
8667         (packet_ok): New overload.
8668         (packet_check_result): New overload.
8669         Update all uses.
8670
8671 2019-01-14  Tom Tromey  <tom@tromey.com>
8672
8673         * remote-notif.c (handle_notification, remote_notif_ack)
8674         (remote_notif_parse): Make "buf" const.
8675         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8676         const.
8677         (remote_notif_parse, remote_notif_ack, handle_notification):
8678         Likewise.
8679         * remote.c (remote_notif_stop_parse): Make "buf" const.
8680         (remote_target::remote_parse_stop_reply): Make "buf" const.
8681         (remote_notif_stop_ack): Make "buf" const.
8682
8683 2019-01-14  Tom Tromey  <tom@tromey.com>
8684
8685         * remote.c (remote_console_output): Make parameter const.
8686
8687 2019-01-14  Tom Tromey  <tom@tromey.com>
8688
8689         * target-debug.h (target_debug_print_signals): Constify.
8690         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8691         * procfs.c (procfs_target::pass_signals): Update.
8692         * linux-nat.c (linux_nat_target::pass_signals): Update.
8693         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8694         * target-delegates.c: Rebuild.
8695         * remote.c (remote_target::program_signals): Update.
8696         (remote_target::pass_signals): Update.
8697         * target.c (target_pass_signals): Constify argument.
8698         (target_program_signals): Likewise.
8699         * target.h (struct target_ops) <pass_signals, program_signals>:
8700         Constify argument.
8701         (target_pass_signals, target_program_signals): Constify argument.
8702
8703 2019-01-14  Tom Tromey  <tom@tromey.com>
8704
8705         PR tui/28819:
8706         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8707
8708 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8709
8710         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8711         field.
8712         * rs6000-tdep.c: Include reggroups.h.
8713         (IS_V_ALIAS_PSEUDOREG): Define.
8714         (rs6000_register_name): Return names for the "vX" aliases.
8715         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8716         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8717         aliases.  Call default_register_reggroup_p for all other
8718         pseudo-registers.
8719         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8720         New functions.
8721         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8722         Handle "vX" aliases.
8723         (v_alias_pseudo_register_collect): New function.
8724         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8725         (rs6000_gdbarch_init): Initialize "vX" aliases as
8726         pseudo-registers.  Restore registration of
8727         rs6000_pseudo_register_reggroup_p with
8728         set_tdesc_pseudo_register_reggroup_p.
8729
8730 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8731
8732         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8733         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8734         set_gdbarch_num_pseudo_regs.
8735
8736 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8737
8738         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8739         Remove arg prefixname, add do_set and do_show.
8740         Add member functions set_list and show_list.
8741         * cli/cli-style.c (class cli_style_option): Update accordingly.
8742         (style_set_list): Move to file scope.
8743         (style_show_list): Likewise.
8744         (set_style): Call help_list.
8745         (show_style): Call cmd_show_list.
8746         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8747         Update to use the new macro.
8748
8749 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8750
8751         * ada-lang.c (_initialize_ada_language): Expand the help text
8752         for the "catch exception" command.
8753
8754 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8755
8756         * symtab.c (matching_obj_sections): Initialize obj,
8757         declare it closer to its usage.
8758
8759 2019-01-10  Tom Tromey  <tom@tromey.com>
8760
8761         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8762         (basic_inf_threads_range): Remove.
8763         (inf_threads_range, inf_non_exited_threads_range)
8764         (safe_inf_threads_range): Use next_adapter.
8765
8766 2019-01-10  Keith Seitz  <keiths@redhat.com>
8767
8768         PR gdb/23712
8769         PR symtab/23010
8770         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8771         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8772
8773 2019-01-10  Keith Seitz  <keiths@redhat.com>
8774
8775         PR gdb/23712
8776         PR symtab/23010
8777         * dictionary.c (pending_to_vector): Remove.
8778         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8779         Remove _1 suffix, replacing functions of the same name.  Update
8780         all callers.
8781         (dict_create_hashed, dict_create_hashed_expandable)
8782         (dict_create_linear, dict_create_linear_expandable, dict_free)
8783         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8784         Make functions static.
8785
8786 2019-01-10  Keith Seitz  <keiths@redhat.com>
8787
8788         PR gdb/23712
8789         PR symtab/23010
8790         * dictionary.h (struct dictionary): Replace declaration with
8791         multidictionary.
8792         (dict_create_hashed, dict_create_hashed_expandable)
8793         (dict_create_linear, dict_create_linear_expandable)
8794         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8795         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8796         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8797         taking multidictionary argument.
8798         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8799         * block.h (struct block) <dict>: Change to multidictionary
8800         and rename `multidict'.
8801         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8802         symmisc.c: Update all dictionary references to multidictionary.
8803
8804 2019-01-10  Keith Seitz  <keiths@redhat.com>
8805
8806         PR gdb/23712
8807         PR symtab/23010
8808         * dictionary.c: Include unordered_map.
8809         (pending_to_vector): New function.
8810         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8811         Rewrite the non-"_1" functions to take vector instead
8812         of linked list.
8813         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8814         "new" _1 versions of the same name.
8815         (multidictionary): Define.
8816         (std::hash<enum language): New definition.
8817         (collate_pending_symbols_by_language, mdict_create_hashed)
8818         (mdict_create_hashed_expandable, mdict_create_linear)
8819         (mdict_create_linear_expandable, mdict_free)
8820         (find_language_dictionary, create_new_language_dictionary)
8821         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8822         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8823         (mdict_size, mdict_empty): New functions.
8824         * dictionary.h (mdict_iterator): Define.
8825
8826 2019-01-10  Pedro Alves  <palves@redhat.com>
8827
8828         * breakpoint.c (read_uploaded_action)
8829         (create_tracepoint_from_upload): Adjust to use
8830         gdb::unique_xmalloc_ptr.
8831         * ctf.c (ctf_write_uploaded_tp):
8832         (SET_ARRAY_FIELD): Use emplace_back.
8833         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8834         * tracefile-tfile.c (tfile_write_uploaded_tp):
8835         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8836         gdb::unique_xmalloc_ptr.
8837         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8838         at_string, cond_string, cmd_strings>: Replace char pointers
8839         with gdb::unique_xmalloc_ptr.
8840
8841 2019-01-10  Pedro Alves  <palves@redhat.com>
8842
8843         * solib-target.c (library_list_start_library): Don't xstrdup name.
8844
8845 2019-01-10  Pedro Alves  <palves@redhat.com>
8846
8847         * mdebugread.c (parse_partial_symbols): Use
8848         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8849
8850 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * linux-fork.c (scoped_switch_fork_info)
8853         <~scoped_switch_fork_info>: Fix incorrect variable name.
8854
8855 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * linux-fork.c (scoped_switch_fork_info)
8858         <scoped_switch_fork_info>: Make explicit.
8859         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8860
8861 2019-01-10  Tom Tromey  <tom@tromey.com>
8862
8863         * objfiles.h (objfile::reset_psymtabs): Update.
8864         * objfiles.c (objfile::objfile): Update.
8865         * psymtab.h (psymtab_storage::obstack): Update.
8866         (psymtab_storage::m_obstack): Use gdb::optional.
8867         (class psymtab_storage): Update comment.  Remove objfile
8868         parameter.
8869         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8870
8871 2019-01-10  Tom Tromey  <tom@tromey.com>
8872
8873         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8874         <free_psymtabs>: Now private.
8875         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8876         (allocate_psymtab): Use new method.
8877
8878 2019-01-10  Tom Tromey  <tom@tromey.com>
8879
8880         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8881         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8882         * mdebugread.c (parse_partial_symbols): Use
8883         allocate_dependencies.
8884         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8885         allocate_dependencies.
8886         (process_psymtab_comp_unit_reader)
8887         (build_type_psymtab_dependencies): Likewise.
8888         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8889
8890 2019-01-10  Tom Tromey  <tom@tromey.com>
8891
8892         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8893         PSYMBOL_SET_LANGUAGE.
8894         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8895
8896 2019-01-10  Tom Tromey  <tom@tromey.com>
8897
8898         * psymtab.h (psymtab_storage::obstack): New method.
8899         <m_obstack>: Rename from obstack; now private.
8900         * psymtab.c (psymtab_storage): Update.
8901         * dwarf2read.c (create_addrmap_from_index)
8902         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8903         Update.
8904
8905 2019-01-10  Tom Tromey  <tom@tromey.com>
8906
8907         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8908         * objfiles.h (objfile::reset_psymtabs): New method.
8909
8910 2019-01-10  Tom Tromey  <tom@tromey.com>
8911
8912         * symmisc.c (print_symbol_bcache_statistics): Update.
8913         (print_objfile_statistics): Update.
8914         * symfile.c (reread_symbols): Update.
8915         * psymtab.h (class psymtab_storage): New.
8916         * psymtab.c (psymtab_storage): New constructor.
8917         (~psymtab_storage): New destructor.
8918         (require_partial_symbols): Update.
8919         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8920         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8921         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8922         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8923         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8924         (start_psymtab_common, end_psymtab_common)
8925         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8926         (allocate_psymtab): Update.
8927         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8928         Update.
8929         (dump_psymtab_addrmap, maintenance_print_psymbols)
8930         (maintenance_check_psymtabs): Update.
8931         (class objfile_psymtabs): Move to objfiles.h.
8932         * psympriv.h (discard_psymtab): Now inline.
8933         (psymtab_discarder::psymtab_discarder): Update.
8934         (psymtab_discarder::~psymtab_discarder): Update.
8935         (ALL_OBJFILE_PSYMTABS): Rewrite.
8936         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8937         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8938         Remove fields.
8939         <partial_symtabs>: New field.
8940         (class objfile_psymtabs): Move from psymtab.h.  Update.
8941         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8942         psymbol_cache.
8943         (objfile::~objfile): Don't destroy psymbol_cache.
8944         * mdebugread.c (parse_partial_symbols): Update.
8945         * dwarf2read.c (create_addrmap_from_index)
8946         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8947         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8948         (add_partial_subprogram, dwarf2_ranges_read): Update.
8949         * dwarf-index-write.c (write_address_map)
8950         (write_one_signatured_type, recursively_write_psymbols)
8951         (class debug_names, class debug_names, write_psymtabs_to_index):
8952         Update.
8953
8954 2019-01-10  Tom Tromey  <tom@tromey.com>
8955
8956         * symtab.h (SYMBOL_SET_NAMES): Update.
8957         (symbol_set_names): Update.
8958         (MSYMBOL_SET_NAMES): Update.
8959         * symtab.c (symbol_set_names): Change argument to be an
8960         objfile_per_bfd_storage.
8961         * psymtab.c (add_psymbol_to_bcache): Update.
8962         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8963
8964 2019-01-10  Tom Tromey  <tom@tromey.com>
8965
8966         * symtab.c (create_demangled_names_hash): Change argument to be an
8967         objfile_per_bfd_storage.
8968         (symbol_set_names): Update.
8969
8970 2019-01-10  Tom Tromey  <tom@tromey.com>
8971
8972         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8973         init_psymbol_list.
8974         * psymtab.c (init_psymbol_list): Do nothing if already called.
8975         * psympriv.h (init_psymbol_list): Add comment.
8976         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8977         init_psymbol_list.
8978         * dbxread.c (dbx_symfile_read): Unconditionally call
8979         init_psymbol_list.
8980
8981 2019-01-10  Tom Tromey  <tom@tromey.com>
8982
8983         * xcoffread.c (scan_xcoff_symtab): Update.
8984         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8985         "where".
8986         * mdebugread.c (parse_partial_symbols)
8987         (handle_psymbol_enumerators): Update.
8988         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8989         * dbxread.c (read_dbx_symtab): Update.
8990         * psympriv.h (psymbol_placement): New enum.
8991         (add_psymbol_to_list): Update.
8992
8993 2019-01-10  Tom Tromey  <tom@tromey.com>
8994
8995         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8996         static_psymbols parameters.
8997         (scan_xcoff_symtab): Update.
8998         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8999         static_psymbols parameters.
9000         * psympriv.h (start_psymtab_common): Update.
9001         * mdebugread.c (parse_partial_symbols): Update.
9002         * dwarf2read.c (create_partial_symtab): Update.
9003         * dbxread.c (read_dbx_symtab): Update.
9004         (start_psymtab): Remove global_psymbols and static_psymbols
9005         parameters.
9006
9007 2019-01-10  Tom Tromey  <tom@tromey.com>
9008
9009         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9010         * psymtab.c (allocate_psymtab): Add comment.
9011         * psympriv.h (allocate_psymtab): Add comment.
9012         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9013         initializations.
9014         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9015
9016 2019-01-10  Tom Tromey  <tom@tromey.com>
9017
9018         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9019         Don't declare.
9020         * mipsread.c: Include mdebugread.h.
9021         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9022         Declare.
9023         * elfread.c: Include mdebugread.h.
9024
9025 2019-01-09  Tom Tromey  <tom@tromey.com>
9026
9027         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9028         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9029         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9030         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9031         (psym_lookup_symbol, psym_find_last_source_symtab)
9032         (psym_forget_cached_source_info, psym_print_stats)
9033         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9034         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9035         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9036         (psym_find_compunit_symtab_by_address)
9037         (maintenance_print_psymbols, maintenance_info_psymtabs)
9038         (maintenance_check_psymtabs): Use ranged for.
9039         * psymtab.h (class objfile_psymtabs): New.
9040         (require_partial_symbols): Return objfile_psymtabs.
9041         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9042
9043 2019-01-09  Tom Tromey  <tom@tromey.com>
9044
9045         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9046         (find_pc_mapped_section, list_overlays_command)
9047         (map_overlay_command, unmap_overlay_command)
9048         (simple_overlay_update): Use all_objfiles.
9049         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9050         * printcmd.c (info_symbol_command): Use all_objfiles.
9051         * objfiles.h (ALL_OBJSECTIONS): Remove.
9052         * maint.c (maintenance_translate_address): Use all_objfiles.
9053         * gcore.c (gcore_create_callback): Use all_objfiles.
9054         (objfile_find_memory_regions): Likewise.
9055
9056 2019-01-09  Tom Tromey  <tom@tromey.com>
9057
9058         * symtab.c (find_line_symtab, info_sources_command)
9059         (make_source_files_completion_list): Use objfile_compunits.
9060         * source.c (select_source_symtab): Use objfile_compunits.
9061         * objfiles.h (struct objfile): Update comment.
9062         (ALL_OBJFILES): Remove.
9063         (ALL_FILETABS): Remove.
9064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9065         objfile_compunits.
9066
9067 2019-01-09  Tom Tromey  <tom@tromey.com>
9068
9069         * symmisc.c (print_objfile_statistics, dump_objfile)
9070         (maintenance_print_symbols): Use compunit_filetabs.
9071         * source.c (forget_cached_source_info_for_objfile): Use
9072         compunit_filetabs.
9073         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9074         (ALL_FILETABS): Use compunit_filetabs.
9075         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9076         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9077
9078 2019-01-09  Tom Tromey  <tom@tromey.com>
9079
9080         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9081         (compunit_filetabs): New.
9082         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9083         compunit_filetabs.
9084         (info_sources_command, make_source_files_completion_list): Remove
9085         declaration.
9086         * symmisc.c (print_objfile_statistics, dump_objfile)
9087         (maintenance_print_symbols): Remove declaration.
9088         (maintenance_info_symtabs): Use compunit_filetabs.
9089         (maintenance_info_line_tables): Likewise.
9090         * source.c (select_source_symtab): Change local variable name.
9091         (forget_cached_source_info_for_objfile): Remove declaration.
9092         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9093         * objfiles.c (objfile_relocate1): Remove declaration.
9094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9095         declaration.
9096         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9097         * coffread.c (coff_symtab_read): Remove declaration.
9098         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9099         compunit_filetabs.
9100
9101 2019-01-09  Tom Tromey  <tom@tromey.com>
9102
9103         * symtab.c (lookup_objfile_from_block)
9104         (find_pc_sect_compunit_symtab, search_symbols)
9105         (default_collect_symbol_completion_matches_break_on): Use
9106         objfile_compunits.
9107         * objfiles.h (ALL_COMPUNITS): Remove.
9108         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9109         * cp-support.c (add_symbol_overload_list_qualified): Use
9110         objfile_compunits.
9111         * ada-lang.c (ada_collect_symbol_completion_matches)
9112         (ada_add_global_exceptions): Use objfile_compunits.
9113
9114 2019-01-09  Tom Tromey  <tom@tromey.com>
9115
9116         * source.c (select_source_symtab)
9117         (forget_cached_source_info_for_objfile): Remove declaration.
9118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9119         declaration.
9120         * maint.c (count_symtabs_and_blocks): Remove declaration.
9121         * cp-support.c (add_symbol_overload_list_qualified): Remove
9122         declaration.
9123         * coffread.c (coff_symtab_read): Remove declaration.
9124         * symtab.c (lookup_symbol_in_objfile_symtabs)
9125         (basic_lookup_transparent_type_1): Use objfile_compunits.
9126         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9127         (info_sources_command, search_symbols)
9128         (default_collect_symbol_completion_matches_break_on)
9129         (make_source_files_completion_list): Remove declaration.
9130         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9131         (ada_collect_symbol_completion_matches)
9132         (ada_add_global_exceptions): Remove declaration.
9133         * linespec.c (iterate_over_all_matching_symtabs): Use
9134         objfile_compunits.
9135         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9136         (class objfile_compunits): New.
9137         (ALL_COMPUNITS): Use objfile_compunits.
9138         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9139         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9140         objfile_compunits.
9141         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9142
9143 2019-01-09  Tom Tromey  <tom@tromey.com>
9144
9145         * symtab.c (search_symbols)
9146         (default_collect_symbol_completion_matches_break_on): Use
9147         objfile_msymbols.
9148         * ada-lang.c (ada_lookup_simple_minsym)
9149         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9150         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9151         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9152         objfile_msymbols.
9153         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9154         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9155         * objc-lang.c (find_methods): Use objfile_msymbols.
9156         (info_selectors_command, info_classes_command): Likewise.
9157         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9158         * objfiles.h (class objfile_msymbols): New.
9159         (ALL_OBJFILE_MSYMBOLS): Remove.
9160         (ALL_MSYMBOLS): Remove.
9161
9162 2019-01-09  Tom Tromey  <tom@tromey.com>
9163
9164         * common/next-iterator.h (next_adapter): Add Iterator template
9165         parameter.
9166         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9167         (class all_objfiles_safe): New.
9168         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9169         * objfiles.c (put_objfile_before): Update comment.
9170         (add_separate_debug_objfile): Likewise.
9171         (free_all_objfiles): Use all_objfiles_safe.
9172         (objfile_purge_solibs): Likewise.
9173
9174 2019-01-09  Tom Tromey  <tom@tromey.com>
9175
9176         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9177         (expand_symtab_containing_pc, lookup_static_symbol)
9178         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9179         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9180         all_objfiles.
9181         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9182         * breakpoint.c (create_overlay_event_breakpoint)
9183         (create_longjmp_master_breakpoint)
9184         (create_std_terminate_master_breakpoint)
9185         (create_exception_master_breakpoint): Use all_objfiles.
9186         * linux-thread-db.c (try_thread_db_load_from_pdir)
9187         (has_libpthread): Use all_objfiles.
9188         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9189         * linespec.c (iterate_over_all_matching_symtabs)
9190         (search_minsyms_for_name): Use all_objfiles.
9191         * maint.c (maintenance_info_sections): Use all_objfiles.
9192         * main.c (captured_main_1): Use all_objfiles.
9193         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9194         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9195         * guile/scm-pretty-print.c
9196         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9197         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9198         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9199         (maintenance_print_msymbols): Use all_objfiles.
9200         * source.c (select_source_symtab): Use all_objfiles.
9201         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9202         * symfile.c (remove_symbol_file_command)
9203         (expand_symtabs_matching, map_symbol_filenames): Use
9204         all_objfiles.
9205         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9206         all_objfiles.
9207         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9208         * objc-lang.c (find_methods): Use all_objfiles.
9209         * objfiles.c (have_partial_symbols, have_full_symbols)
9210         (have_minimal_symbols, qsort_cmp)
9211         (default_iterate_over_objfiles_in_search_order): Use
9212         all_objfiles.
9213         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9214         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9215         (maintenance_check_psymtabs): Use all_objfiles.
9216         (ALL_PSYMTABS): Remove.
9217         * compile/compile-object-run.c (do_module_cleanup): Use
9218         all_objfiles.
9219         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9220         * cp-support.c (add_symbol_overload_list_qualified): Use
9221         all_objfiles.
9222         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9223         Use all_objfiles.
9224         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9225         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9226         all_objfiles.
9227         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9228         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9229         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9230         Uses all_objfiles.
9231         * solib.c (solib_read_symbols): Use all_objfiles
9232
9233 2019-01-09  Tom Tromey  <tom@tromey.com>
9234
9235         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9236         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9237         all_objfiles.
9238         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9239         * symmisc.c (print_symbol_bcache_statistics)
9240         (print_objfile_statistics, maintenance_print_objfiles)
9241         (maintenance_info_symtabs, maintenance_check_symtabs)
9242         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9243         all_objfiles.
9244         * source.c (forget_cached_source_info): Use all_objfiles.
9245         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9246         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9247         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9248         * objfiles.c (update_section_map): Use all_objfiles.
9249         (shared_objfile_contains_address_p): Likewise.
9250         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9251         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9252
9253 2019-01-09  Tom Tromey  <tom@tromey.com>
9254
9255         * common/next-iterator.h: New file.
9256         * objfiles.h (class all_objfiles): New.
9257         (struct objfile_iterator): New.
9258
9259 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9260
9261         * NEWS: Move the description of the changed "frame", "select-frame",
9262          and "info frame" commands to the Changed commands section.
9263
9264 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9265
9266         * gdbtypes.c (check_stub_method_group): Remove handling of old
9267         mangling schemes.
9268         * linespec.c (find_methods): Likewise.
9269         * stabsread.c (read_member_functions): Likewise.
9270         * valops.c (search_struct_method): Likewise.
9271         (value_struct_elt_for_reference): Likewise.
9272         * NEWS: Mention this change.
9273
9274 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9277         print_source_lines.
9278         * source.c (print_source_lines_base): Update line number check.
9279         (print_source_lines): New function.
9280         (source_lines_range::source_lines_range): New function.
9281         * source.h (class source_lines_range): New class.
9282         (print_source_lines): New declaration.
9283
9284 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9285
9286         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9287
9288 2019-01-08  Tom Tromey  <tom@tromey.com>
9289             Simon Marchi  <simon.marchi@ericsson.com>
9290
9291         PR gdb/24060
9292         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9293         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9294         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9295         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9296         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9297         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9298
9299 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * source.c (select_source_symtab): Move header comment to
9302         declaration in source.h.
9303         (forget_cached_source_info_for_objfile): Likewise.
9304         (forget_cached_source_info): Likewise.
9305         (identify_source_line): Likewise.
9306         * source.h (identify_source_line): Move declaration from symtab.h
9307         and add comment from source.c
9308         (print_source_lines): Likewise.
9309         (forget_cached_source_info_for_objfile): Likewise.
9310         (forget_cached_source_info): Likewise.
9311         (select_source_symtab): Likewise.
9312         (enum print_source_lines_flag): Move definition from symtab.h.
9313         * symtab.h (identify_source_line): Move declaration to source.h.
9314         (print_source_lines): Likewise.
9315         (forget_cached_source_info_for_objfile): Likewise.
9316         (forget_cached_source_info): Likewise.
9317         (select_source_symtab): Likewise.
9318         (enum print_source_lines_flag): Move definition to source.h.
9319         * tui/tui-hooks.c: Add 'source.h' include.
9320
9321 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * source.c (print_source_lines_base): Handle requests to print
9324         reverse line number sequences, and guard against empty lines
9325         string.
9326
9327 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9328
9329         * source.c (print_source_lines_base): Fix skip of '\r' if next
9330         character is '\n'.
9331
9332 2019-01-06  Tom Tromey  <tom@tromey.com>
9333
9334         * c-exp.y (struct c_parse_state) <macro_original_text,
9335         expansion_obstack>: New member.
9336         (macro_original_text, expansion_obstack): Remove globals.
9337         (scan_macro_expansion, scanning_macro_expansion)
9338         (finished_macro_expansion): Update.
9339         (scan_macro_cleanup): Remove.
9340         (yylex, c_parse): Update.
9341
9342 2019-01-06  Tom Tromey  <tom@tromey.com>
9343
9344         * c-exp.y (struct c_parse_state) <strings>: New member.
9345         (operator_stoken): Update.
9346
9347 2019-01-06  Tom Tromey  <tom@tromey.com>
9348
9349         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9350         (union type_stack_elt) <typelist_val>: Now a pointer to
9351         std::vector.
9352         (type_stack_cleanup): Don't declare.
9353         (push_typelist): Update.
9354         * parse.c (pop_typelist): Return a std::vector.
9355         (push_typelist): Take a std::vector.
9356         (follow_types): Update.  Do not free args.
9357         (type_stack_cleanup): Remove.
9358         * c-exp.y (struct c_parse_state): New.
9359         (cpstate): New global.
9360         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9361         (nonempty_typelist): Update.
9362         (func_mod): Create a new vector.
9363         (c_parse): Create a c_parse_state.
9364         (check_parameter_typelist): Do not delete params.
9365         (function_method): Update.  Do not delete type_list.
9366
9367 2019-01-06  Tom Tromey  <tom@tromey.com>
9368
9369         PR gdb/28155:
9370         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9371         check_typedef.
9372         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9373         (print_return_value): Likewise.
9374
9375 2019-01-05  Tom Tromey  <tom@tromey.com>
9376
9377         * contrib/cleanup_check.py: Remove.
9378         * contrib/gcc-with-excheck: Remove.
9379         * contrib/exsummary.py: Remove.
9380         * contrib/excheck.py: Remove.
9381
9382 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9383
9384         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9385         NULL. Initialize tpprev to NULL instead of assigning it
9386         to NULL on the next statement.
9387         * windows-nat.c (windows_delete_thread): Remove check for
9388         main_thread_id before printing thread exit notifications.
9389         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9390         Remove thread ID check against main_thread_id.
9391         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9392         windows_delete_thread.
9393         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9394
9395 2019-01-04  Tom Tromey  <tom@tromey.com>
9396
9397         * compile/compile.c (_initialize_compile): Use upper case for
9398         metasyntactic variables.
9399         * symmisc.c (_initialize_symmisc): Use upper case for
9400         metasyntactic variables.
9401         * psymtab.c (_initialize_psymtab): Use upper case for
9402         metasyntactic variables.
9403         * demangle.c (demangle_command): Use upper case for metasyntactic
9404         variables.
9405         (_initialize_demangler): Likewise.
9406         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9407         variables.
9408
9409 2019-01-03  Tom Tromey  <tom@tromey.com>
9410
9411         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9412
9413 2019-01-03  Tom Tromey  <tom@tromey.com>
9414
9415         * python/py-symtab.c (salpy_str): Update.
9416         (struct salpy_sal_object) <symtab>: Now a PyObject.
9417         (salpy_dealloc): Update.
9418         (del_objfile_sal): Use gdbpy_ref.
9419
9420 2019-01-03  Tom Tromey  <tom@tromey.com>
9421
9422         * python/py-type.c (convert_field): Use new_reference.  Return
9423         gdbpy_ref.
9424         (make_fielditem): Return gdbpy_ref.
9425         (typy_fields): Update.
9426         (typy_getitem): Update.
9427         (field_name): Return gdbpy_ref.  Use new_reference.
9428         (typy_iterator_iternext): Update.
9429
9430 2019-01-03  Tom Tromey  <tom@tromey.com>
9431
9432         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9433
9434 2019-01-03  Tom Tromey  <tom@tromey.com>
9435
9436         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9437         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9438         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9439         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9440         (pspy_set_type_printers): Likewise.
9441         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9442         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9443         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9444         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9445         (objfpy_set_type_printers): Likewise.
9446
9447 2019-01-03  Tom Tromey  <tom@tromey.com>
9448
9449         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9450         (gdbpy_print_stack): Use gdbpy_err_fetch.
9451         * python/python-internal.h (class gdbpy_err_fetch): New class.
9452         (class gdbpy_enter) <m_error_type, m_error_value,
9453         m_error_traceback>: Remove.
9454         <m_error>: New member.
9455         (gdbpy_exception_to_string): Don't declare.
9456         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9457         * python/py-value.c (convert_value_from_python): Use
9458         gdbpy_err_fetch.
9459         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9460         gdbpy_exception_to_string.
9461         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9462         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9463         gdbpy_err_fetch.
9464
9465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9466
9467         * linux-nat.c (delete_lwp_cleanup): Delete.
9468         (struct lwp_deleter): New struct.
9469         (lwp_info_up): New typedef.
9470         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9471         lwp_info_up.
9472
9473 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * linux-fork.c (class scoped_switch_fork_info): New class.
9476         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9477
9478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9479
9480         * valops.c (find_overload_match): Remove use of null_cleanup, and
9481         calls to do_cleanups.
9482
9483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * compile/compile-cplus-types.c
9486         (compile_cplus_instance::decl_name): Handle changes to
9487         cp_func_name.
9488         * cp-support.c (cp_func_name): Update header comment, update
9489         return type.
9490         * cp-support.h (cp_func_name): Update return type in declaration.
9491         * valops.c (find_overload_match): Move temp_func local to top
9492         level of function and change its type.  Use temp_func to hold and
9493         delete temporary string obtained from cp_func_name.
9494
9495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9496
9497         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9498         gdb::char_vector, remove cleanup, and update uses of `msg`.
9499
9500 2019-01-03  Jim Wilson  <jimw@sifive.com>
9501
9502         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9503
9504 2019-01-02  Tom Tromey  <tom@tromey.com>
9505
9506         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9507         (tdesc_parse_xml): Remove cleanups.
9508         * target-descriptions.h (make_cleanup_free_target_description):
9509         Don't declare.
9510         (target_desc_deleter): New struct.
9511         (target_desc_up): New typedef.
9512         * target-descriptions.c (target_desc_deleter::operator()): Rename
9513         from free_target_description.
9514         (make_cleanup_free_target_description): Remove.
9515
9516 2019-01-02  Tom Tromey  <tom@tromey.com>
9517
9518         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9519         constructor, destructor.
9520         (linespec_parser): Remove typedef.
9521         (~linespec_parser): Rename from linespec_parser_delete.
9522         (linespec_lex_to_end, linespec_complete_label)
9523         (linespec_complete): Update.
9524         (decode_line_full): Remove cleanups.
9525         (decode_line_1): Update.
9526
9527 2019-01-02  Tom Tromey  <tom@tromey.com>
9528
9529         * python/python-internal.h (inferior_to_inferior_object): Change
9530         return type.
9531         * python/py-exitedevent.c (create_exited_event_object): Update.
9532         * python/py-inferior.c (inferior_to_inferior_object): Return
9533         gdbpy_ref.
9534         (python_new_inferior, python_inferior_deleted)
9535         (thread_to_thread_object, delete_thread_object)
9536         (build_inferior_list, gdbpy_selected_inferior): Update.
9537         * python/py-infthread.c (create_thread_object): Update.  Also fail
9538         if inferior_to_inferior_object fails.
9539
9540 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9541
9542         * inferior.h (class inferior) <displaced_step_state>: New field.
9543         * infrun.h (struct displaced_step_state): Move here from
9544         infrun.c.  Initialize fields, add constructor.
9545         <inf>: Remove field.
9546         <reset>: New method.
9547         * infrun.c (struct displaced_step_inferior_state): Move to
9548         infrun.h.
9549         (displaced_step_inferior_states): Remove.
9550         (get_displaced_stepping_state): Adust.
9551         (displaced_step_in_progress_any_inferior): Adjust.
9552         (displaced_step_in_progress_thread): Adjust.
9553         (displaced_step_in_progress): Adjust.
9554         (add_displaced_stepping_state): Remove.
9555         (get_displaced_step_closure_by_addr): Adjust.
9556         (remove_displaced_stepping_state): Remove.
9557         (infrun_inferior_exit): Call displaced_step_state.reset.
9558         (use_displaced_stepping): Don't check for NULL.
9559         (displaced_step_prepare_throw): Call
9560         get_displaced_stepping_state.
9561         (displaced_step_fixup): Don't check for NULL.
9562         (prepare_for_detach): Don't check for NULL.
9563
9564 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9565
9566         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9567          in case of call that did not complete.
9568
9569 2019-01-02  Andrey Utkin  <autkin@undo.io>
9570
9571         * symfile.c (find_separate_debug_file): Fix search of debug files for
9572         remote debuggee.
9573
9574 2019-01-02  Tom Tromey  <tom@tromey.com>
9575
9576         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9577         indentation.
9578         * python/py-frame.c (frapy_older): Remove cast.
9579         (frapy_newer): Likewise.
9580         * python/py-breakpoint.c (local_setattro): Remove cast.
9581         * python/py-arch.c (archpy_name): Remove local variable.
9582         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9583
9584 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9585
9586         * unittests/basic_string_view/element_access/char/empty.cc:
9587         Fix year range in copyright header.
9588
9589 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9590
9591         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9592         Delete.
9593         <operator==>: Update with for removed field.
9594         <hash>: Likewise.
9595         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9596         <isa_features>: ...this.
9597         <abi_features>: New field.
9598         (riscv_isa_flen): Update comment.
9599         (riscv_abi_xlen): New declaration.
9600         (riscv_abi_flen): New declaration.
9601         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9602         isa_features.
9603         (riscv_abi_xlen): New function.
9604         (riscv_isa_flen): Update to get answer from isa_features.
9605         (riscv_abi_flen): New function.
9606         (riscv_has_fp_abi): Update to get answer from abi_features.
9607         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9608         xlen and flen.
9609         (riscv_call_info) <xlen, flen>: Update comment.
9610         (riscv_call_arg_struct): Remove invalid assertions
9611         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9612         is removed.
9613         (riscv_gdbarch_init): Gather isa features and abi features
9614         separately, ensure both match on the gdbarch when reusing an old
9615         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9616         a target with 64-bit float hardware.
9617
9618 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9619
9620         * source.c (search_command_helper): Stop reverse search
9621         when line 1 has been searched.
9622
9623 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9624
9625         * record-full.c (record_full_base_target::close): Rewrite
9626         record_full_core_buf_list free logic.
9627
9628 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9629
9630         * break-catch-syscall.c (print_one_catch_syscall): xfree
9631         the last text.
9632
9633 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9634
9635         * top.c (print_gdb_version): Update Copyright year in version
9636         message.
9637
9638 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9639
9640         Update copyright year range in all GDB files.
9641
9642 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9643
9644         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9645
9646 For older changes see ChangeLog-2018.
9647 \f
9648 Local Variables:
9649 mode: change-log
9650 left-margin: 8
9651 fill-column: 74
9652 version-control: never
9653 coding: utf-8
9654 End:
9655