gdb/ChangeLog

   1 2019-08-01  Tom Tromey  <tromey@adacore.com>
   2
   3         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
   4         gdbarch.h.
   5
   6 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * s12z-tdep.c: Fix include path for s12z-opc.h.
   9
  10 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  11
  12         * NEWS: Require GNU make 3.82.
  13
  14 2019-07-16  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  17         declare.
  18
  19 2019-07-30  Tom Tromey  <tromey@adacore.com>
  20
  21         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  22
  23 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  24
  25         * printcmd.c (print_address_symbolic): Print negative offsets.
  26         (build_address_symbolic): Force signed arithmetic when computing
  27         offset.
  28
  29 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  30
  31         PR/24474: Add a function to lookup static variables.
  32         * NEWS: Mention this new function.
  33         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  34         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  35         * python/python.c (python_GdbMethods): Add new function.
  36
  37 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  38
  39         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  40         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  41         (objfpy_lookup_static_symbol): New function.
  42         (objfile_object_methods): Add new functions.
  43
  44 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  45
  46         * NEWS: Mention 'set|show print frame-info'.  Mention new
  47         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  48         backtrace argument.  Mention that python frame filtering code
  49         is now consistent with what 'backtrace' command prints.
  50
  51 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  52
  53         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  54         comments.
  55         (print_frame_info_auto, print_frame_info_source_line,
  56         print_frame_info_location, print_frame_info_source_and_location,
  57         print_frame_info_location_and_address, print_frame_info_short_location):
  58         New declarations.
  59         (struct frame_print_options): New member print_frame_info.
  60         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  61         * stack.h (get_user_print_what_frame_info): New declaration.
  62         (frame_show_address): New declaration.
  63         * stack.c (print_frame_arguments_choices): New value 'presence'.
  64         (print_frame_info_auto, print_frame_info_source_line,
  65         print_frame_info_location, print_frame_info_source_and_location,
  66         print_frame_info_location_and_address, print_frame_info_short_location,
  67         print_frame_info_choices, print_frame_info_print_what): New definitions.
  68         (print_frame_args): Only print dots for args if print frame-arguments
  69         is 'presence'.
  70         (frame_print_option_defs): New element for "frame-info".
  71         (get_user_print_what_frame_info): New function.
  72         (frame_show_address): Make non static.  Move comment to stack.h.
  73         (print_frame_info_to_print_what): New function.
  74         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  75         to decide what to print.
  76         (backtrace_command_1): Handle the new print_frame_arguments_presence
  77         value.
  78         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  79         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  80         (py_print_frame): In non-mi mode, use LOCATION as default for
  81         print_what, similarly to frame information printed directly by
  82         backtrace command. Handle frame-info user option in non MI mode.
  83
  84 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  85
  86         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  87         Add case for debugging 32-bit target on 64-bit host.  Revise
  88         comment.
  89
  90 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  91
  92         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  93         instead of find_function_entry_range_from_pc.
  94
  95 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  96
  97         * stack.c (find_frame_funname): Remove code which preferred
  98         minsym over symtab sym in "certain pathological cases".
  99
 100         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 101         parameter.  Change type of "do_demangle" to bool.
 102         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 103         Pass suitable "prefer_sym_over_minsym" flag to
 104         build_address_symbolic().  Don't output "+" for negative offsets.
 105         * printcmd.c (print_address_symbolic): Update invocation of
 106         build_address_symbolic to include a "prefer_sym_over_minsym"
 107         flag.
 108         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 109         Restrict cases in which use of minimal symbol is preferred to that
 110         of a found symbol.  Update comments.
 111
 112         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 113         for entry pc when entry pc is out of range for that FDE.
 114
 115 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 116
 117         PR gdb/24839:
 118         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 119         type.
 120
 121 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 122
 123         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 124         this function's Python signature.
 125
 126
 127 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 128
 129         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 130         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 131         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 132         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 133         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 134
 135
 136 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 137
 138         * h8300-tdep.c (h8300_register_name_common): New.
 139         h8300_register_name): Use h8300_register_name_common.
 140         (h8300s_register_name): Likewise.
 141         (h8300sx_register_name): Likewise.
 142         (h8300h_register_nam): New.
 143         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 144
 145
 146 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 147
 148         * arm-tdep.c (arm_skip_cmse_entry): New function.
 149         (arm_is_sgstubs_section): New function.
 150         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 151
 152 2019-07-22  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 155         Don't self-assign.
 156
 157 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 160         type_print.
 161
 162 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 163
 164         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 165         so that GDB doesn't match any msymbols when searching in the
 166         TYPES_DOMAIN.
 167         (print_symbol_info): Print using typedef_print or type_print based
 168         on the type of the symbol.  Add updated FIXME comment moved from...
 169         (_initialize_symtab): ... move and update FIXME comment to above.
 170
 171 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * NEWS: Mention adding -q option to "info types".
 174         * symtab.c (struct info_types_options): New struct.
 175         (info_types_options_defs): New variable.
 176         (make_info_types_options_def_group): New function.
 177         (info_types_command): Use gdb::option framework to parse options.
 178         (info_types_command_completer): New function.
 179         (_initialize_symtab): Extend the help text on "info types" and
 180         register command completer.
 181
 182 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 183
 184         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 185         (lookup_symbol_in_objfile): Change int to block_enum and add a
 186         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 187
 188 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 189
 190         * MAINTAINERS (Write After Approval): Add self.
 191
 192 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 193
 194         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 195         instruction to the dummy code region.
 196
 197 2019-07-19  Tom Tromey  <tromey@adacore.com>
 198
 199         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 200         (ARGSUSED, PARAMS, __func__): Remove rules.
 201
 202 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 203
 204         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 205         * features/arm/arm-with-iwmmxt.c: Remove.
 206         * features/arm/arm-with-iwmmxt.xml: Remove.
 207         * features/arm/arm-with-m-fpa-layout.c: Remove.
 208         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 209         * features/arm/arm-with-m-vfp-d16.c: Remove.
 210         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 211         * features/arm/arm-with-m.c: Remove.
 212         * features/arm/arm-with-m.xml: Remove.
 213         * features/arm/arm-with-neon.c: Remove.
 214         * features/arm/arm-with-neon.xml: Remove.
 215         * features/arm/arm-with-vfpv2.c: Remove.
 216         * features/arm/arm-with-vfpv2.xml: Remove.
 217         * features/arm/arm-with-vfpv3.c: Remove.
 218         * features/arm/arm-with-vfpv3.xml: Remove.
 219
 220 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 221
 222         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 223
 224 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 225
 226         * arch/aarch32.c (aarch32_create_target_description): Create
 227         target descriptions using features.
 228         * arch/arm.c (arm_create_target_description)
 229         (arm_create_mprofile_target_description): Likewise.
 230         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 231
 232 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 233
 234         * Makefile.in: Add new files.
 235         * aarch32-tdep.c: New file.
 236         * aarch32-tdep.h: New file.
 237         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 238         Call aarch32_read_description.
 239         * arch/aarch32.c: New file.
 240         * arch/aarch32.h: New file.
 241         * arch/arm.c (arm_create_target_description)
 242         (arm_create_mprofile_target_description): New function.
 243         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 244         (arm_create_target_description)
 245         (arm_create_mprofile_target_description): New declaration.
 246         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 247         read_description functions.
 248         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 249         Likewise.
 250         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 251         * arm-tdep.c (tdesc_arm_list): New variable.
 252         (arm_register_g_packet_guesses): Call create description functions.
 253         (arm_read_description) (arm_read_mprofile_description): New
 254         function.
 255         * arm-tdep.h (arm_read_description)
 256         (arm_read_mprofile_description): Add declaration.
 257         * configure.tgt: Add new files.
 258
 259 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 260
 261         * top.c (new_ui_command): Open specified terminal just once.
 262
 263 2019-07-18  Tom Tromey  <tromey@adacore.com>
 264
 265         * symtab.c (main_name): Constify return type.
 266         * symfile.c (set_initial_language): Update.
 267         * symtab.h (main_name): Constify return type.
 268
 269 2019-07-17  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-winsource.c (tui_update_source_window)
 272         (tui_update_source_window_as_is)
 273         (tui_update_source_windows_with_line): Remove return.
 274         * tui/tui-disasm.c (tui_show_disassem)
 275         (tui_show_disassem_and_update_source): Remove return.
 276         * tui/tui.c (tui_reset): Remove return.
 277         * tui/tui-wingeneral.c
 278         (tui_check_and_display_highlight_if_needed): Remove return.
 279
 280 2019-07-17  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 283
 284 2019-07-17  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-winsource.h (struct tui_exec_info_window)
 287         (struct tui_source_window_base): Move from tui-data.h.
 288         * tui/tui-winsource.c: Move many method definitions from
 289         elsewhere.  Remove "structuring" comments.
 290         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 291         (tui_source_window_base::refresh_window): Move to
 292         tui-winsource.c.
 293         * tui/tui-win.c (tui_source_window_base::refresh_all)
 294         (tui_source_window_base::update_tab_width)
 295         (tui_source_window_base::set_new_height)
 296         (tui_source_window_base::do_make_visible_with_new_height): Move to
 297         tui-winsource.c.
 298         * tui/tui-source.h: Update.
 299         * tui/tui-source.c (tui_source_window_base::reset): Move to
 300         tui-winsource.c.
 301         * tui/tui-disasm.h: Update.
 302         * tui/tui-data.h (struct tui_exec_info_window): Move to
 303         tui-winsource.h.
 304         (struct tui_source_window_base): Likewise.
 305         * tui/tui-data.c (tui_source_window_base::clear_detail)
 306         (tui_source_window_base, ~tui_source_window_base): Move to
 307         tui-winsource.c.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-win.c (tui_resize_all)
 312         (tui_source_window_base::update_tab_width)
 313         (tui_adjust_win_heights): Update.
 314         (tui_win_info::make_invisible_and_set_new_height): Rename from
 315         make_invisible_and_set_new_height.
 316         * tui/tui-data.h (struct tui_win_info)
 317         <make_invisible_and_set_new_height>: New method.
 318
 319 2019-07-17  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui.c: Update.
 322         * tui/tui-source.h (struct tui_source_window): Move from
 323         tui-data.h.
 324         * tui/tui-layout.c: Update.
 325         * tui/tui-disasm.c: Update.
 326         * tui/tui-data.h (struct tui_source_window): Move to
 327         tui-source.h.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 332         tui-data.h.
 333         * tui/tui-data.h (struct tui_disasm_window): Move to
 334         tui-disasm.h.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-regs.h (struct tui_data_item_window): Move from
 339         tui-data.h.
 340         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 341         * tui/tui-data.h (struct tui_data_item_window): Move to
 342         tui-regs.h.
 343         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui.c: Update.
 348         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 349         (tui_cmd_window::max_height): Move to tui-command.c.
 350         * tui/tui-layout.c: Update.
 351         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 352         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 353         tui-command.c.
 354         * tui/tui-command.h (struct tui_cmd_window): Move from
 355         tui-data.h.
 356         * tui/tui-command.c: Remove "structuring" comments.
 357         (tui_cmd_window::clear_detail)
 358         (tui_cmd_window::do_make_visible_with_new_height)
 359         (tui_cmd_window::max_height): Move from elsewhere.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 364         Now static.
 365         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 366         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui.c: Update.
 371         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 372         tui-regs.c.
 373         * tui/tui-windata.h: Remove file.
 374         * tui/tui-windata.c: Remove file.
 375         * tui/tui-win.c (tui_data_window::set_new_height)
 376         (tui_data_window::do_make_visible_with_new_height): Move to
 377         tui-regs.c.
 378         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 379         * tui/tui-regs.c: Remove "structuring" comments.
 380         (tui_data_window::first_data_item_displayed)
 381         (tui_data_window::delete_data_content_windows)
 382         (tui_data_window::erase_data_content)
 383         (tui_data_window::display_all_data)
 384         (tui_data_window::refresh_all)
 385         (tui_data_window::do_scroll_vertical)
 386         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 387         (tui_data_window::do_make_visible_with_new_height)
 388         (tui_data_window::refresh_window): Move from elsewhere.
 389         (_initialize_tui_regs): Move to end of file.
 390         * tui/tui-layout.c: Update.
 391         * tui/tui-hooks.c: Update.
 392         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 393         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 394         tui-regs.c.
 395         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 400         seen.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-win.c (tui_source_window_base::set_new_height)
 405         (tui_source_window_base::do_make_visible_with_new_height): Use
 406         m_has_locator field directly.
 407         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 408         method.
 409         (struct tui_source_window_base) <has_locator>: Likewise.
 410
 411 2019-07-17  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 414         Don't declare.
 415         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 416         Remove.
 417         * tui/tui-win.c (tui_source_window_base::set_new_height)
 418         (tui_source_window_base::set_new_height)
 419         (make_invisible_and_set_new_height)
 420         (tui_source_window_base::do_make_visible_with_new_height)
 421         (tui_source_window_base::do_make_visible_with_new_height):
 422         Update.
 423         * tui/tui-layout.c (show_source_disasm_command, show_data)
 424         (show_source_or_disasm_and_command): Update.
 425         * tui/tui-layout.c (show_layout): Update.
 426
 427 2019-07-17  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.c (make_data_window): Remove.
 430         (show_data): Unify creation and re-initialization cases.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-layout.c (make_source_window, make_disasm_window):
 435         Remove.
 436         (show_data): Unify creation and re-initialization cases.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-layout.c (make_command_window): Remove.
 441         (show_source_disasm_command, show_source_or_disasm_and_command):
 442         Unify creation and re-initialization cases.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 447         creation and re-initialization cases.
 448
 449 2019-07-17  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-regs.c (tui_get_register): Return void.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 456         Simplify.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 461         resetting.
 462
 463 2019-07-17  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 466         * tui/tui-regs.c (tui_reg_layout): New function.
 467         (tui_show_registers, tui_reg_command): Use it.
 468         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 469         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 470         parameters.
 471         (tui_layout_command): Remove.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-layout.h (tui/tui-layout): Return void.
 476         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 477
 478 2019-07-17  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-layout.c (show_source_disasm_command, show_data):
 481         Update.
 482         (reset_locator): Remove.
 483         (show_source_or_disasm_and_command): Update.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-source.c (tui_source_window_base::reset): Remove
 488         win_type parameter.
 489         * tui/tui-layout.c (make_command_window, make_source_window)
 490         (make_disasm_window, make_data_window)
 491         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 492         (reset_locator, show_source_or_disasm_and_command): Update.
 493         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 494         win_type parameter.
 495         (struct tui_source_window_base) <reset>: Likewise.
 496
 497 2019-07-17  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-layout.c (show_source_disasm_command): Use
 500         reset_locator.
 501         (reset_locator): New function.
 502         (init_and_make_win): Remove.
 503         (show_source_or_disasm_and_command): Use reset_locator.
 504
 505 2019-07-17  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 508         condition.
 509         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 510         Remove condition.
 511         * tui/tui-source.c (tui_source_window_base::reset): New method.
 512         * tui/tui-layout.c (make_command_window): Don't call
 513         init_and_make_win.
 514         (make_source_window, make_disasm_window): Don't call
 515         make_source_or_disasm_window.
 516         (make_data_window): Don't call init_and_make_win.  Change calling
 517         convention.
 518         (show_source_disasm_command, show_data): Simplify.
 519         (make_source_or_disasm_window): Remove.
 520         (show_source_or_disasm_and_command): Simplify.
 521         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 522         (struct tui_source_window_base) <reset>: Likewise.
 523         <execution_info>: Remove initializer.
 524         * tui/tui-data.c (tui_source_window_base): Initialize
 525         execution_info.
 526
 527 2019-07-17  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 530         variable.
 531
 532 2019-07-17  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui.c (tui_rl_other_window): Update.
 535         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 536         superclass method first.  Always iterate over regs_content.
 537         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 538         method.
 539         * tui/tui-win.c (tui_set_focus_command): Update.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-win.c (tui_set_focus_command): Rename from
 544         tui_set_focus.  Call tui_enable.
 545         (tui_set_focus_command): Remove.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 550         refresh_window.
 551         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 552         touchwin.
 553         (tui_data_window::refresh_window): Call refresh_window on data
 554         items.  Always call superclass refresh_window.
 555         (tui_win_info::refresh): Remove.
 556         (tui_source_window_base::refresh_window): Update.
 557         (tui_refresh_all): Update.
 558         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 559         refresh_window.
 560         (show_source_or_disasm_and_command): Likewise.
 561         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 562         (struct tui_source_window_base) <refresh>: Likewise.
 563
 564 2019-07-17  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-winsource.c (tui_clear_source_content)
 567         (tui_show_source_content): Update.
 568         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 569         whether content is empty.
 570         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 571         Remove.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 576         window's contents.
 577         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 578         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 583         (struct tui_data_item_window): Update.
 584
 585 2019-07-17  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 588         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 589         defines.
 590
 591 2019-07-17  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-winsource.h (tui_erase_source_content)
 594         (tui_clear_source_content): Remove "display_prompt" parameter.
 595         * tui/tui-winsource.c (tui_update_source_window_as_is)
 596         (tui_update_source_windows_with_addr): Update.
 597         (tui_clear_source_content): Remove "display_prompt" parameter.
 598         (tui_erase_source_content): Likewise.  Simplify.
 599         (tui_show_source_content): Update.
 600         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 601         * tui/tui-stack.c (tui_show_frame_info): Update.
 602         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 603         Remove defines.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 608         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 609         parameter.
 610         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 611         parameter.
 612
 613 2019-07-17  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.c (tui_clear_source_content)
 616         (tui_show_source_content, tui_show_exec_info_content)
 617         (tui_clear_exec_info_content): Update.
 618         * tui/tui-stack.c (tui_show_locator_content): Update.
 619         (tui_show_frame_info): Update.
 620         * tui/tui-source.h (tui_source_window): Don't declare.
 621         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 622         from tui_source_is_displayed.
 623         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 624         Remove field.
 625         (struct tui_source_window_base) <content_in_use>: New field.  Now
 626         bool.
 627         (struct tui_source_window) <showing_source_p>: New method.
 628         (TUI_SRC_WIN): Change cast.
 629         * tui/tui-data.c (tui_initialize_static_data): Update.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 634         location_matches_p.
 635         * tui/tui-source.c (tui_source_window::location_matches_p): New
 636         method.
 637         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 638         method.
 639         * tui/tui-data.h (struct tui_source_window_base)
 640         <location_matches_p>: New method.
 641         (struct tui_source_window, struct tui_disasm_window)
 642         <location_matches_p>: Likewise.
 643
 644 2019-07-17  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-win.c (tui_set_win_height_command): Rename from
 647         tui_set_win_height.
 648         (tui_set_win_height_command): Remove.
 649
 650 2019-07-17  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-source.c (tui_source_window): New constructor.  Add
 653         observer.
 654         (~tui_source_window): New destructor.
 655         (tui_source_window::style_changed): New method.
 656         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 657         (tui_attach_detach_observers): Update.
 658         * tui/tui-data.h (struct tui_source_window): Make constructor not
 659         inline.  Add destructor.
 660         (struct tui_source_window) <style_changed>: New method.
 661         <m_observable>: New member.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 666         * tui/tui-win.c (tui_resize_all): Fix typo.
 667
 668 2019-07-17  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 671         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 672         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 673         * tui/tui-win.c (window_name_completer): Use foreach.
 674         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 675         (update_tab_width): Likewise.
 676         * tui/tui-layout.c (show_layout): Update.
 677         * tui/tui-data.h (class tui_window_iterator): New.
 678         (struct all_tui_windows): New.
 679         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 684         parameter.  Don't reference globals.
 685         (tui_reg_command): Update.
 686
 687 2019-07-17  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-regs.c (tui_show_registers): Simplify.
 690
 691 2019-07-17  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-regs.c (tui_show_registers): Update.
 694         (tui_show_register_group): Add win_info parameter.
 695
 696 2019-07-17  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 699         Rename from tui_display_reg_element_at_line.
 700         (tui_data_window::display_registers_from_line): Update.
 701         * tui/tui-data.h (struct tui_data_window)
 702         <display_reg_element_at_line>: New method.
 703
 704 2019-07-17  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-regs.h (tui_display_registers_from)
 707         (tui_display_registers_from_line): Don't declare.
 708         * tui/tui-windata.c (tui_data_window::display_all_data)
 709         (tui_data_window::refresh_all)
 710         (tui_data_window::do_scroll_vertical): Update.
 711         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 712         from tui_display_registers_from.
 713         (tui_display_reg_element_at_line): Update.
 714         (tui_data_window::display_registers_from_line): Rename from
 715         tui_display_registers_from_line.
 716         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 717         display_registers_from_line>: New methods.
 718
 719 2019-07-17  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 722         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 723         from tui_erase_data_content.
 724         (tui_data_window::display_all_data)
 725         (tui_data_window::refresh_all)
 726         (tui_data_window::do_scroll_vertical): Update.
 727         * tui/tui-regs.c (tui_show_registers): Update.
 728         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 729         New method.
 730
 731 2019-07-17  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 734         declare.
 735         * tui/tui-windata.c
 736         (tui_data_window::delete_data_content_windows): Rename from
 737         tui_delete_data_content_windows.
 738         (tui_data_window::display_all_data)
 739         (tui_data_window::do_scroll_vertical): Update.
 740         * tui/tui-data.h (struct tui_data_window)
 741         <delete_data_content_windows>: New method.
 742
 743 2019-07-17  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 746         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 747
 748 2019-07-17  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 751         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 752         from tui_display_all_data.
 753         * tui/tui-win.c
 754         (tui_data_window::do_make_visible_with_new_height): Update.
 755         * tui/tui-regs.c (tui_show_registers): Update.
 756         * tui/tui-layout.c (tui_set_layout): Update.
 757         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 758         method.
 759
 760 2019-07-17  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 763         * tui/tui-windata.c (tui_display_data_from): Remove.
 764         (tui_data_window::refresh_all): Update.
 765
 766 2019-07-17  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 769         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 770         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 771         tui_display_registers_from_line.
 772         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 773         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 774         "force_display" parameter.
 775
 776 2019-07-17  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 779         declare.
 780         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 781         Rename from tui_first_reg_element_no_inline.
 782         (tui_display_reg_element_at_line)
 783         (tui_display_registers_from_line): Update.
 784         * tui/tui-data.h (struct tui_data_window)
 785         <first_reg_element_no_inline>: New method.
 786
 787 2019-07-17  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-windata.c (tui_display_data_from)
 790         (tui_data_window::do_scroll_vertical): Update.
 791         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 792         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 793         Rename from tui_line_from_reg_element_no.
 794         (tui_display_registers_from_line): Update.
 795         * tui/tui-data.h (struct tui_data_window)
 796         <line_from_reg_element_no>: New method.
 797
 798 2019-07-17  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 801         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 802         tui_last_regs_line_no.
 803         (tui_display_reg_element_at_line)
 804         (tui_display_registers_from_line): Update.
 805         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 806         method.
 807
 808 2019-07-17  Tom Tromey  <tom@tromey.com>
 809
 810         PR tui/24722:
 811         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 812         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 813         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 814         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 815         (tui_update_breakpoint_info): Likewise.
 816         * tui/tui-hooks.c (tui_event_create_breakpoint)
 817         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 818         Update.
 819
 820 2019-07-17  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 823
 824 2019-07-17  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-winsource.c (tui_update_source_window_as_is)
 827         (tui_update_source_windows_with_addr): Update.
 828         * tui/tui-source.h (tui_set_source_content)
 829         (tui_show_symtab_source): Add "win_info" parameter.
 830         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 831         parameter.
 832         (tui_show_symtab_source): Likewise.
 833
 834 2019-07-17  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-wingeneral.c
 837         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 838
 839 2019-07-17  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 842         (struct tui_cmd_window) <can_scroll>: New method.
 843         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 844         method.
 845
 846 2019-07-17  Tom Tromey  <tromey@adacore.com>
 847
 848         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 849         do_field_signed>: Rename.  Change type of "value".
 850         * ui-out.c (ui_out::field_signed): Rename from field_int.
 851         Change type of "value".
 852         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 853         type of "value".
 854         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 855         do_field_int.  Change type of "value".
 856         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 857         do_field_int.  Change type of "value".
 858         * tracepoint.c (trace_status_mi, tfind_1)
 859         (print_one_static_tracepoint_marker): Update.
 860         * thread.c (print_thread_info_1, print_selected_thread_frame):
 861         Update.
 862         * stack.c (print_frame, print_frame_info): Update.
 863         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 864         Update.
 865         * source.c (print_source_lines_base): Update.
 866         * skip.c (info_skip_command): Update.
 867         * record-btrace.c (btrace_ui_out_decode_error)
 868         (btrace_call_history_src_line): Update.
 869         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 870         Update.
 871         * progspace.c (print_program_space): Update.
 872         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 873         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 874         do_field_int.  Change type of "value".
 875         * mi/mi-out.c (mi_ui_out::do_table_begin)
 876         (mi_ui_out::do_table_header): Update.
 877         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 878         type of "value".
 879         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 880         (mi_cmd_data_list_changed_registers, output_register)
 881         (mi_cmd_data_read_memory, mi_load_progress)
 882         (mi_cmd_trace_frame_collected): Update.
 883         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 884         Update.
 885         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 886         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 887         (mi_cmd_var_list_children, varobj_update_one): Update.
 888         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 889         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 890         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 891         * inferior.c (print_inferior): Update.
 892         * gdb_bfd.c (print_one_bfd): Update.
 893         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 894         Update.
 895         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 896         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 897         do_field_int.  Change type of "value".
 898         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 899         do_field_int.  Change type of "value".
 900         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 901         (print_one_breakpoint_location, print_it_catch_fork)
 902         (print_one_catch_fork, print_it_catch_vfork)
 903         (print_one_catch_vfork, print_it_catch_solib)
 904         (print_it_catch_exec, print_it_ranged_breakpoint)
 905         (print_mention_watchpoint, print_mention_masked_watchpoint)
 906         (bkpt_print_it, update_static_tracepoint): Update.
 907         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 908         * break-catch-syscall.c (print_it_catch_syscall): Update.
 909         * ada-tasks.c (print_ada_task_info): Update.
 910         * ada-lang.c (print_it_exception, print_mention_exception):
 911         Update.
 912
 913 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         PR breakpoints/24541
 916         * gdbarch.c: Regenerate.
 917         * gdbarch.h: Regenerate.
 918         * gdbarch.sh: Adjust return type and parameter types for
 919         'stap_adjust_register'.
 920         (i386_stap_adjust_register): Adjust signature and return new
 921         register name.
 922         * stap-probe.c (stap_parse_register_operand): Adjust use of
 923         'gdbarch_stap_adjust_register'.
 924
 925 2019-07-17  Tom Tromey  <tromey@adacore.com>
 926
 927         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 928         declare VEC.
 929         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 930         std::vector.
 931         (struct s390_process_info): Add initializers.
 932         (s390_add_process): Use new.
 933         (s390_linux_nat_target::low_forget_process): Use delete.
 934         (s390_linux_nat_target::low_new_fork)
 935         (s390_linux_nat_target::stopped_by_watchpoint)
 936         (s390_linux_nat_target::low_prepare_to_resume)
 937         (s390_linux_nat_target::insert_watchpoint)
 938         (s390_linux_nat_target::insert_hw_breakpoint)
 939         (s390_linux_nat_target::remove_watchpoint)
 940         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 941
 942 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 943
 944         * aarch64-fbsd-nat.c: Include regcache.h.
 945         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 946         argument.
 947         (aarch64_fbsd_nat_target::fetch_registers)
 948         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 949         variable.
 950         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 951
 952 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 953
 954         * fbsd-nat.c: Include gdbarch.h.
 955
 956 2019-07-15  Tom Tromey  <tromey@adacore.com>
 957
 958         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 959
 960 2019-07-15  Tom Tromey  <tromey@adacore.com>
 961
 962         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 963         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 964         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 965         * cli-out.c (cli_ui_out::do_field_int): New method.
 966         * ui-out.c (ui_out::field_unsigned): New method.
 967         * symfile.c (generic_load): Use field_unsigned.
 968         (print_transfer_performance): Likewise.
 969         * record-btrace.c (ui_out_field_uint): Remove.
 970         (btrace_call_history_insn_range, btrace_call_history): Use
 971         field_unsigned.
 972         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 973         field_unsigned.
 974         * ui-out.h (class ui_out) <field_unsigned>: New method.
 975         <do_field_unsigned>: Likewise.
 976
 977 2019-07-15  Tom Tromey  <tromey@adacore.com>
 978
 979         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 980         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 981         * target.c (flash_erase_command): Use field_string.
 982         * infrun.c (print_signal_received_reason): Use field_string.
 983         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 984         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 985         field_string.
 986         * ada-tasks.c (print_ada_task_info): Use field_string.
 987
 988 2019-07-15  Tom Tromey  <tromey@adacore.com>
 989
 990         * target.c (flash_erase_command): Use field_core_addr.
 991         * symfile.c (generic_load): Use field_core_addr.
 992         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 993         Use field_core_addr.
 994         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 995         field_core_addr.
 996
 997 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1000         value if its desired type is smaller than a CORE_ADDR and signed.
1001
1002 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1005         of changes to field names, and use new is_reference field to
1006         decide if a property is a reference or not.
1007         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1008         field.
1009         (struct dwarf2_property_baton): Update header comment, rename
1010         'referenced_type' to 'property_type' and update comments.
1011         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1012         default property type, store in property baton, update to take
1013         accound of renamed field.
1014         (read_func_scope): Update call to attr_to_dynamic_prop.
1015         (read_array_type): Likewise.
1016         (dwarf2_per_cu_addr_sized_int_type): New function.
1017         (read_subrange_index_type): Move type finding code to
1018         dwarf2_per_cu_addr_sized_int_type.
1019         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1020         (dwarf2_per_cu_addr_type): New function.
1021         (set_die_type): Update calls to attr_to_dynamic_prop.
1022
1023 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * dwarf2read.c (read_subrange_index_type): New function.
1026         (read_subrange_type): Move code into new function and call it.
1027         * gdbtypes.c (create_range_type): Add some asserts.
1028
1029 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1032         update return statements.
1033         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1034         declaration, and update comment to match.
1035         * gdbtypes.c (resolve_dynamic_array): Update call to
1036         dwarf2_evaluate_property to match new return type.
1037
1038 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * valarith.c (value_subscripted_rvalue): Change lowerbound
1041         parameter type from int to LONGEST.
1042         * value.h (value_subscripted_rvalue): Likewise in declaration.
1043
1044 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * cli/cli-utils.c (info_print_command_completer): New function.
1047         * cli/cli-utils.h: Add 'completer.h' include, and forward
1048         declaration for 'struct cmd_list_element'.
1049         (info_print_command_completer): Declare.
1050         * stack.c (_initialize_stack): Add completer for 'info locals' and
1051         'info args'.
1052         * symtab.c (_initialize_symtab): Add completer for 'info
1053         variables' and 'info functions'.
1054         * NEWS: Mention completion for additional info commands.
1055
1056 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * cli/cli-utils.c (extract_info_print_args): Delete.
1059         (extract_arg_maybe_quoted): Delete.
1060         (info_print_options_defs): New variable.
1061         (make_info_print_options_def_group): New function.
1062         (extract_info_print_options): Define new function.
1063         * cli/cli-utils.h (extract_info_print_args): Delete.
1064         (struct info_print_options): New structure.
1065         (extract_info_print_options): Declare new function.
1066         * stack.c (info_locals_command): Update to use new
1067         extract_info_print_options, also add a header comment.
1068         (info_args_command): Likewise.
1069         * symtab.c (info_variables_command): Likewise.
1070         (info_functions_command): Likewise.
1071
1072 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1075         to extract string arguments.
1076         * common/common-utils.c (extract_string_maybe_quoted): New function.
1077         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1078
1079 2019-07-11  Tom Tromey  <tromey@adacore.com>
1080
1081         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1082         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1083         * top.h (gdbinit): Don't declare.
1084         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1085         into...
1086         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1087         * top.c (gdb_init): Don't call init_cli_cmds.
1088         (gdbinit): Remove.
1089         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1090
1091 2019-07-11  Tom Tromey  <tromey@adacore.com>
1092
1093         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1094         after it has been moved.
1095
1096 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1097
1098         * valops.c (value_must_coerce_to_target): Change return type to
1099         bool.
1100         * value.h (value_must_coerce_to_target): Likewise.
1101
1102 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1103
1104         * breakpoint.c (is_hardware_watchpoint): Remove
1105         forward-declaration.
1106         (is_masked_watchpoint): Change return type to bool.
1107         (is_tracepoint): Likewise.
1108         (is_breakpoint): Likewise.
1109         (is_hardware_watchpoint): Likewise.
1110         (is_watchpoint): Likewise.
1111         (is_no_memory_software_watchpoint): Likewise.
1112         (is_catchpoint): Likewise.
1113         (breakpoint_1): Make FILTER parameter's return type bool.
1114         is_masked_watchpoint): Change return type to bool.
1115         (save_breakpoints): Make FILTER parameter's return type bool.
1116         * breakpoint.h (is_breakpoint): Change return type to bool.
1117         (is_watchpoint): Likewise.
1118         (is_catchpoint): Likewise.
1119         (is_tracepoint): Likewise.
1120
1121 2019-07-10  Tom Tromey  <tom@tromey.com>
1122
1123         * defs.h: Don't include gdbarch.h.
1124         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1125         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1126         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1127         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1128         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1129         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1130         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1131         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1132         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1133         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1134         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1135         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1136         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1137         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1138         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1139         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1140         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1141         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1142         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1143         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1144         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1145         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1146         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1147         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1148         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1149         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1150         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1151
1152 2019-07-10  Tom Tromey  <tromey@adacore.com>
1153
1154         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1155         * breakpoint.c (init_ada_exception_breakpoint): Register as
1156         bp_catchpoint.
1157         (print_one_breakpoint_location, print_one_breakpoint): Use
1158         is_ada_exception_catchpoint.
1159         * ada-lang.c (class ada_catchpoint_location): Pass
1160         bp_loc_software_breakpoint to bp_location constructor.
1161         (is_ada_exception_catchpoint): New function.
1162
1163 2019-07-10  Tom Tromey  <tromey@adacore.com>
1164
1165         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1166         VEC.
1167         (struct arm_exidx_entry): New method operator<.
1168         (struct arm_exidx_data) <section_maps>: Change type.
1169         (arm_exidx_data_free): Remove.
1170         (arm_exidx_data_key): Change type.  Move lower.
1171         (arm_exidx_new_objfile): Update.
1172         (arm_compare_exidx_entries): Remove.
1173         (arm_find_exidx_entry, _initialize_arm_tdep)
1174
1175 2019-07-10  Tom Tromey  <tromey@adacore.com>
1176
1177         * solib-spu.c (ocl_program_data_key): Change type.
1178         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1179         Update.
1180
1181 2019-07-10  Tom Tromey  <tromey@adacore.com>
1182
1183         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1184         (struct solib_aix_inferior_data) <library_list>: Change type.
1185         (solib_aix_inferior_data_handle): Change type.
1186         (get_solib_aix_inferior_data): Update.
1187         (solib_aix_free_library_list): Remove.
1188         (library_list_start_library): Update.
1189         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1190         return type.
1191         (solib_aix_get_library_list)
1192         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1193         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1194
1195 2019-07-10  Tom Tromey  <tromey@adacore.com>
1196
1197         * solib-dsbt.c (struct dsbt_info): Add initializers.
1198         (solib_dsbt_pspace_data): Change type.
1199         (dsbt_pspace_data_cleanup): Remove.
1200         (get_dsbt_info, _initialize_dsbt_solib): Update.
1201
1202 2019-07-10  Tom Tromey  <tromey@adacore.com>
1203
1204         * spu-tdep.c (spu_overlay_data): Change type.
1205         (spu_get_overlay_table, spu_overlay_new_objfile)
1206         (_initialize_spu_tdep): Update.
1207
1208 2019-07-10  Tom Tromey  <tromey@adacore.com>
1209
1210         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1211         destructor.
1212         (dbx_objfile_data_key): Change type and declare later.
1213         (DBX_SYMFILE_INFO): Rewrite.
1214         * dbxread.c (dbx_objfile_data_key): Change type.
1215         (dbx_symfile_init): Update.
1216         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1217         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1218         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1219
1220 2019-07-10  Tom Tromey  <tromey@adacore.com>
1221
1222         * jit.c (jit_program_space_key): Change type.  Move lower.
1223         (get_jit_program_space_data): Update.
1224         (jit_program_space_data_cleanup): Remove.
1225         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1226         Update.
1227         (struct jit_program_space_data): Add initializers.
1228
1229 2019-07-10  Tom Tromey  <tromey@adacore.com>
1230
1231         * solib-darwin.c (struct darwin_info): Add initializers.
1232         (solib_darwin_pspace_data): Change type.
1233         (darwin_pspace_data_cleanup): Remove.
1234         (get_darwin_info, _initialize_darwin_solib): Update.
1235
1236 2019-07-10  Tom Tromey  <tromey@adacore.com>
1237
1238         * remote-sim.c (struct sim_inferior_data): Add initializers,
1239         constructor, and destructor.
1240         (sim_inferior_data_key): Change type.  Move lower.
1241         (check_for_duplicate_sim_descriptor): Update.
1242         (get_sim_inferior_data): Use new.  Update.
1243         (~sim_inferior_data_cleanup): Rename from
1244         sim_inferior_data_cleanup.  Simplify.
1245         (gdbsim_close_inferior, simulator_command)
1246         (sim_command_completer, _initialize_remote_sim): Update.
1247         (next_pid, INITIAL_PID): Move earlier.
1248
1249 2019-07-10  Tom Tromey  <tromey@adacore.com>
1250
1251         * python/python-internal.h (create_thread_object): Return
1252         gdbpy_ref.
1253         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1254         * python/py-inferior.c (struct threadlist_entry): Add
1255         constructor.
1256         <thread_obj>: Now a gdbpy_ref.
1257         (thread_to_thread_object): Update.
1258         (add_thread_object): Use new.
1259         (delete_thread_object): Use delete.
1260         (infpy_threads): Update.
1261         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1262         GIL.
1263
1264 2019-07-10  Tom Tromey  <tromey@adacore.com>
1265
1266         * valops.c (value_cast): Specialize error message for Ada.
1267
1268 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1269
1270         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1271
1272 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1273
1274         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1275         bpstat_should_step): Return bool, adjust comments.
1276         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1277         bpstat_should_step): Likewise.
1278
1279 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * features/Makefile: Use feature target descriptions for Arm.
1282         * features/arm/arm-core.c: Generate new file.
1283         * features/arm/arm-fpa.c: Likewise.
1284         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1285         * features/arm/arm-m-profile.c: Likewise.
1286         * features/arm/arm-vfpv2.c: Likewise.
1287         * features/arm/arm-vfpv3.c: Likewise.
1288         * features/arm/xscale-iwmmxt.c: Likewise.
1289         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1290
1291 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1292
1293         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1294         ptrace earlier.
1295
1296 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1297
1298         * features/aarch64-pauth.c: Regenerate.
1299
1300 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1301
1302         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1303         bool.
1304         (bpstat_what): Use false instead of 0.
1305
1306 2019-07-09  Pedro Alves  <palves@redhat.com>
1307
1308         * break-catch-throw.c (is_exception_catchpoint): New.
1309         * breakpoint.c (print_one_breakpoint_location): New parameter
1310         'raw_loc'.  Handle it.  Use
1311         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1312         looking at the breakpoint's type.
1313         (print_one_breakpoint): If handling "maint info breakpoints", also
1314         print locations of exception catchpoints.
1315         * breakpoint.h (is_exception_catchpoint): Declare.
1316
1317 2019-07-09  Pedro Alves  <palves@redhat.com>
1318
1319         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1320         "addr" field.
1321         (allocate_location_exception_catchpoint): New.
1322         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1323         (initialize_throw_catchpoint_ops): Install
1324         allocate_location_exception_catchpoint as allocate_location
1325         method.
1326         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1327         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1328         bp_loc_other.
1329         (breakpoint_address_is_meaningful): Delete.
1330         (bl_address_is_meaningful): New.
1331         (breakpoint_locations_match): Adjust comment.
1332         (bp_location_from_bp_type): New, factored out of...
1333         (bp_location::bp_location(breakpoint *)): ... this.
1334         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1335         factored out of...
1336         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1337         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1338         breakpoint_address_is_meaningful.
1339         (bp_locations_compare): Adjust comment.
1340         (update_global_location_list): Use bl_address_is_meaningful
1341         instead of breakpoint_address_is_meaningful.
1342         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1343         explicit.
1344         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1345         * python/py-breakpoint.c (bppy_get_location): No longer check
1346         whether location is null.
1347
1348 2019-07-09  Pedro Alves  <palves@redhat.com>
1349
1350         PR c++/15468
1351         * breakpoint.c (print_one_breakpoint_location): Remove
1352         single-location assert.
1353
1354 2019-07-09  Tom Tromey  <tom@tromey.com>
1355
1356         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1357         * configure: Rebuild.
1358         * configure.ac: Change common to gdbsupport.
1359         * gdbsupport: Rename from common.
1360         * acinclude.m4: Change common to gdbsupport.
1361         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1362         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1363         gdbsupport.
1364         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1365         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1366         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1367         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1368         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1369         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1370         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1371         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1372         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1373         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1374         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1375         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1376         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1377         coff-pe-read.c, command.h, compile/compile-c-support.c,
1378         compile/compile-c.h, compile/compile-cplus-symbols.c,
1379         compile/compile-cplus-types.c, compile/compile-cplus.h,
1380         compile/compile-loc2c.c, compile/compile.c, completer.c,
1381         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1382         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1383         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1384         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1385         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1386         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1387         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1388         features/aarch64-core.c, features/aarch64-fpu.c,
1389         features/aarch64-pauth.c, features/aarch64-sve.c,
1390         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1391         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1392         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1393         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1394         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1395         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1396         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1397         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1398         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1399         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1400         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1401         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1402         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1403         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1404         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1405         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1406         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1407         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1408         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1409         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1410         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1411         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1412         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1413         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1414         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1415         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1416         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1417         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1418         minsyms.c, mips-linux-tdep.c, namespace.h,
1419         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1420         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1421         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1422         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1423         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1424         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1425         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1426         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1427         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1428         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1429         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1430         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1431         procfs.c, producer.c, progspace.h, psymtab.h,
1432         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1433         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1434         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1435         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1436         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1437         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1438         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1439         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1440         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1441         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1442         target-memory.c, target.c, target.h, target/waitstatus.c,
1443         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1444         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1445         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1446         unittests/array-view-selftests.c,
1447         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1448         unittests/common-utils-selftests.c,
1449         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1450         unittests/format_pieces-selftests.c,
1451         unittests/function-view-selftests.c,
1452         unittests/lookup_name_info-selftests.c,
1453         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1454         unittests/mkdir-recursive-selftests.c,
1455         unittests/observable-selftests.c,
1456         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1457         unittests/parse-connection-spec-selftests.c,
1458         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1459         unittests/scoped_fd-selftests.c,
1460         unittests/scoped_mmap-selftests.c,
1461         unittests/scoped_restore-selftests.c,
1462         unittests/string_view-selftests.c, unittests/style-selftests.c,
1463         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1464         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1465         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1466         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1467         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1468         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1469
1470 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1473         bool value.
1474         (decode_digits_ordinary): Set explicit_line field in sal.
1475         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1476         symtab_and_line that was set on an explicit line number in
1477         assembler code.  Do always update the recorded symtab and line if
1478         we do skip the prologue.
1479
1480 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * breakpoint.c (set_breakpoint_location_function): Remove
1483         explicit_loc parameter.
1484         (momentary_breakpoint_from_master): Update call to
1485         set_breakpoint_location_function.
1486         (add_location_to_breakpoint): Likewise.
1487
1488 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1491         required features based on default bfd type when no specific bfd
1492         is present.
1493
1494 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1495
1496         * NEWS: Mention that GDB printf and eval commands can now print
1497         C-style and Ada-style convenience var strings without
1498         calling the inferior.
1499         * printcmd.c (printf_c_string): Locally print GDB internal var
1500         instead of transiting via the inferior.
1501         (printf_wide_c_string): Likewise.
1502
1503 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1504
1505         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1506
1507 2019-07-04  Tom Tromey  <tom@tromey.com>
1508
1509         PR tui/24724:
1510         * tui/tui-winsource.c (tui_clear_source_content): Update.
1511         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1512         (tui_update_breakpoint_info): Update.
1513         (tui_set_exec_info_content): Update.
1514         * tui/tui-source.c (tui_set_source_content_nil): Update.
1515         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1516         has_break.
1517         * tui/tui-data.h (enum tui_bp_flag): New.
1518         (tui_bp_flags): New enum flags type.
1519         (struct tui_source_element) <break_mode>: Change type.  Rename
1520         from has_break.
1521         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1522         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1523         constants.
1524         * tui/tui-winsource.h: Fix comment.
1525
1526 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1527
1528         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1529         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1530         (store_fpregs_to_thread)
1531         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1532         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1533         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1534         (IWMMXT_REGS_SIZE): Add define.
1535         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1536         (fetch_vfp_regs, store_vfp_regs)
1537         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1538         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1539
1540 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1543         defines.
1544         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1545         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1546         (ARM_INT_REGISTER_SIZE): ...to this.
1547         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1548         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1549         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1550         (arm_linux_collect_gregset, supply_nwfpe_register)
1551         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1552         defines.
1553         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1554         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1555         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1556         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1557         (arm_return_in_memory, arm_store_return_value)
1558         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1559         (arm_record_ld_st_multiple): Likewise.
1560         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1561         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1562
1563 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1564
1565         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1566         AARCH64_DISPLACED_MODIFIED_INSNS.
1567         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1568         (aarch64_displaced_step_copy_insn): Likewise.
1569         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1570         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1571         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1572         ARM_DISPLACED_MODIFIED_INSNS.
1573         * arm-tdep.c (arm_gdbarch_init): Likewise.
1574         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1575         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1576         (struct arm_displaced_step_closure): Use
1577         ARM_DISPLACED_MODIFIED_INSNS.
1578
1579 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1580
1581         * features/Makefile: Remove unused xml files.
1582         * features/aarch64.xml: Remove.
1583         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1584         * features/i386/amd64-avx-avx512.xml: Remove.
1585         * features/i386/amd64-avx-linux.xml: Remove.
1586         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1587         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1588         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1589         * features/i386/amd64-avx-mpx.xml: Remove.
1590         * features/i386/amd64-avx.xml: Remove.
1591         * features/i386/amd64-linux.xml: Remove.
1592         * features/i386/amd64-mpx-linux.xml: Remove.
1593         * features/i386/amd64-mpx.xml: Remove.
1594         * features/i386/amd64.xml: Remove.
1595         * features/i386/i386-avx-avx512-linux.xml: Remove.
1596         * features/i386/i386-avx-avx512.xml: Remove.
1597         * features/i386/i386-avx-linux.xml: Remove.
1598         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1599         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1600         * features/i386/i386-avx-mpx-linux.xml: Remove.
1601         * features/i386/i386-avx-mpx.xml: Remove.
1602         * features/i386/i386-avx.xml: Remove.
1603         * features/i386/i386-linux.xml: Remove.
1604         * features/i386/i386-mmx-linux.xml: Remove.
1605         * features/i386/i386-mmx.xml: Remove.
1606         * features/i386/i386-mpx-linux.xml: Remove.
1607         * features/i386/i386-mpx.xml: Remove.
1608         * features/i386/i386.xml: Remove.
1609         * features/i386/x32-avx-avx512-linux.xml: Remove.
1610         * features/i386/x32-avx-linux.xml: Remove.
1611         * features/i386/x32-linux.xml: Remove.
1612
1613 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * regformats/aarch64.dat: Remove.
1616         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1617         * regformats/i386/amd64-avx-linux.dat: Remove.
1618         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1619         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1620         * regformats/i386/amd64-linux.dat: Remove.
1621         * regformats/i386/amd64-mpx-linux.dat: Remove.
1622         * regformats/i386/amd64.dat: Remove.
1623         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1624         * regformats/i386/i386-avx-linux.dat: Remove.
1625         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1626         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1627         * regformats/i386/i386-linux.dat: Remove.
1628         * regformats/i386/i386-mmx-linux.dat: Remove.
1629         * regformats/i386/i386-mpx-linux.dat: Remove.
1630         * regformats/i386/i386.dat: Remove.
1631         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1632         * regformats/i386/x32-avx-linux.dat: Remove.
1633         * regformats/i386/x32-linux.dat: Remove.
1634
1635 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1636
1637         * aarch64-tdep.c: Remove xml self tests.
1638         * amd64-linux-tdep.c: Likewise.
1639         * amd64-tdep.c: Likewise.
1640         * i386-linux-tdep.c: Likewise.
1641         * i386-tdep.c: Likewise.
1642
1643 2019-07-03  Pedro Alves  <palves@redhat.com>
1644
1645         PR cli/24732
1646         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1647         (pipe_cmd_option_defs): New.
1648         (make_pipe_cmd_options_def_group): New.
1649         (pipe_command): Use gdb::option::process_options.
1650         (pipe_command_completer): New function.
1651         (_initialize_cli_cmds): Install completer for "pipe" command.
1652
1653 2019-07-03  Pedro Alves  <palves@redhat.com>
1654
1655         * cli/cli-option.c (union option_value) <string>: New field.
1656         (struct option_def_and_value): Add ctor, move ctor, dtor and
1657         use DISABLE_COPY_AND_ASSIGN.
1658         (option_def_and_value::clear_value): New.
1659         (parse_option, save_option_value_in_ctx, get_val_type_str)
1660         (add_setshow_cmds_for_options): Handle var_string.
1661         * cli-option.h (union option_def::var_address) <string>: New
1662         field.
1663         (struct string_option_def): New.
1664         * maint-test-options.c (struct test_options_opts): Add default
1665         ctor and use DISABLE_COPY_AND_ASSIGN.
1666         <string_opt>: New field.
1667         (test_options_opts::~test_options_opts): New.
1668         (test_options_opts::dump): Also dump "-string".
1669         (test_options_option_defs): Install "string.
1670
1671 2019-07-03  Pedro Alves  <palves@redhat.com>
1672
1673         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1674         option_value with a null enumeration.
1675         (complete_options): Save the option values in the context.
1676         (save_option_value_in_ctx): New, factored out from ...
1677         (process_options): ... here.
1678         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1679         of the function.
1680         * maint-test-options.c (test_options_opts::dump): New, factored
1681         out from ...
1682         (maintenance_test_options_command_mode): ... here.
1683         (maintenance_test_options_command_completion_result): Delete.
1684         (maintenance_test_options_command_completion_text): Update
1685         comment.
1686         (maintenance_show_test_options_completion_result): Change
1687         prototype.  Just print
1688         maintenance_test_options_command_completion_text.
1689         (save_completion_result): New.
1690         (maintenance_test_options_completer_mode): Pass options context to
1691         complete_options, and then save a dump.
1692         (_initialize_maint_test_options): Use add_cmd to install "maint
1693         show test-options-completion-result".
1694
1695 2019-07-03  Pedro Alves  <palves@redhat.com>
1696
1697         * NEWS (New commands): Mention "with" and "maint with".
1698         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1699         (with_command, with_command_completer): New.
1700         (pipe_command): Adjust to new repeat_previous
1701         interface.
1702         (_initialize_cli_cmds): Install the "with" command and its "w"
1703         alias.
1704         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1705         declarations.
1706         * cli/cli-setshow.c (parse_cli_var_uinteger)
1707         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1708         argument strings for all var_types.
1709         (get_setshow_command_value_string): New, factored out from ...
1710         (do_show_command): ... this.
1711         * cli/cli-setshow.h: Include <string>.
1712         (get_setshow_command_value_string): Declare.
1713         * command.h (repeat_previous): Now returns const char *.  Adjust
1714         comment.
1715         * maint.c: Include "cli/cli-cmds.h".
1716         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1717         (_initialize_maint_cmds): Register the "maintenance with" command.
1718         * top.c (repeat_previous): Move bits from pipe_command here:
1719         Return the saved command line, if any; error out if there's no
1720         command to relaunch.
1721
1722 2019-07-03  Pedro Alves  <palves@redhat.com>
1723
1724         * NEWS (New commands): Mention "maint set/show test-settings"
1725         instead of "maint test-settings".
1726         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1727         (maintenance_test_settings_set_list): Rename to ...
1728         (maintenance_set_test_settings_list): ... this.
1729         (maintenance_test_settings_show_list): Rename to  ...
1730         (maintenance_show_test_settings_list): ... this.
1731         (maintenance_test_settings_cmd): Delete.
1732         (maintenance_test_settings_set_cmd): ...
1733         (maintenance_set_test_settings_cmd): ... this.
1734         (maintenance_test_settings_show_cmd): ...
1735         (maintenance_show_test_settings_cmd): ... this.
1736         (maintenance_test_settings_show_value_cmd):
1737         (maintenance_show_test_settings_value_cmd): ... this.
1738         (_initialize_maint_test_settings): No longer install the "maint
1739         test-settings" prefix command.  Rename "maint test-settings set"
1740         to "maint set test-settings", and "maint test-settings show" to
1741         "maint show test-settings".  Adjust all subcommands.
1742
1743 2019-07-03  Pedro Alves  <palves@redhat.com>
1744
1745         * maint-test-settings.c: Fix file's intro comment.  Replace all
1746         references to "test-options" with references to "test-settings",
1747         in comments.
1748
1749 2019-07-03  Pedro Alves  <palves@redhat.com>
1750
1751         * maint-test-settings.c (maintenance_test_settings_xxx)
1752         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1753         New.
1754         (maintenance_test_settings_enums): Use them.
1755         (maintenance_test_settings_enum): Default to
1756         maintenance_test_settings_xxx.
1757         (_initialize_maint_test_settings): Initialize
1758         MAINTENANCE_TEST_SETTINGS_FILENAME.
1759
1760 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1761
1762         * breakpoint.h (remove_breakpoints_inf): Change return type to
1763         void, move function documentation here.
1764         * breakpoint.c (remove_breakpoints_inf): Change return type to
1765         void, move function documentation to header.
1766
1767 2019-07-02  Pedro Alves  <palves@redhat.com>
1768
1769         * NEWS (Completion improvements): Mention "info threads".
1770         * thread.c (struct info_threads_opts, info_threads_option_defs)
1771         (make_info_threads_options_def_group): New.
1772         (info_threads_command): Use gdb::option::process_options.
1773         (info_threads_command_completer): New.
1774         (_initialize_thread): Use gdb::option::build_help to build the
1775         help text for "info threads".
1776
1777 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1778
1779         * defs.h (generic_load): Move from here...
1780         * symfile.h (generic_load): ... to here.  Rename name parameter
1781         to args.
1782         * symfile.c (generic_load): Add comment.
1783
1784 2019-07-01  Tom Tromey  <tromey@adacore.com>
1785
1786         * dwarf2read.c
1787         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1788         declaration of without_params.  Fix formatting.
1789
1790 2019-07-01  Tom Tromey  <tromey@adacore.com>
1791
1792         * ada-exp.y (find_primitive_type): Update.
1793         * ada-lang.h (ada_lookup_symbol): Update.
1794         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1795         parameter.
1796         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1797
1798 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1799
1800         PR breakpoints/24541
1801         * gdbarch.c: Regenerate.
1802         * gdbarch.h: Regenerate.
1803         * gdbarch.sh: Add 'stap_adjust_register'.
1804         * i386-tdep.c: Include '<unordered_set>'.
1805         (i386_stap_adjust_register): New function.
1806         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1807         * stap-probe.c (stap_parse_register_operand): Call
1808         'gdbarch_stap_adjust_register'.
1809
1810 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1811
1812         PR python/24742
1813         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1814         * python/python.c (do_start_initialization): Use 'xmalloc'
1815         instead of 'PyMem_Malloc'.
1816
1817 2019-06-28  Tom Tromey  <tromey@adacore.com>
1818
1819         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1820         for Ada.
1821
1822 2019-06-27  Tom Tromey  <tromey@adacore.com>
1823
1824         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1825         objfile_key.
1826         (arm_find_mapping_symbol, arm_record_special_symbol)
1827         (_initialize_arm_tdep): Update.
1828         (arm_objfile_data_free): Remove.
1829
1830 2019-06-27  Tom Tromey  <tromey@adacore.com>
1831
1832         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1833         to cp_print_static_field.
1834
1835 2019-06-26  Tom Tromey  <tromey@adacore.com>
1836
1837         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1838         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1839         declare.
1840
1841 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1842
1843         * features/aarch64-core.c (create_feature_aarch64_core):
1844         Regenerate.
1845         * features/aarch64-core.xml: Add cpsr flags.
1846
1847 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1848
1849         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1850         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1851
1852 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1853
1854         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1855         field.
1856         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1857         use.
1858         (arm_record_special_symbol): Don't insert new symbol in sorted
1859         position, push it at the end.
1860
1861 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1862
1863         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1864         (arm_mapping_symbol_s): Remove.
1865         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1866         (arm_mapping_symbol_vec): New typedef.
1867         (struct arm_per_objfile): Add constructor.
1868         <section_maps>: Change type to
1869         std::unique_ptr<arm_mapping_symbol_vec[]>.
1870         (arm_compare_mapping_symbols): Remove.
1871         (arm_find_mapping_symbol): Adjust to section_maps type change.
1872         (arm_objfile_data_free): Call delete on arm_per_objfile.
1873         (arm_record_special_symbol): Adjust to section_maps type change.
1874         Allocate arm_per_objfile with new.
1875
1876 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1877
1878         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1879         with the command prefix.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1884         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1889         type.
1890         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1891         protected.
1892
1893 2019-06-25  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-winsource.c
1896         (tui_source_window_base::set_is_exec_point_at): Add check against
1897         LOA_ADDRESS.
1898
1899 2019-06-25  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-source.c (tui_set_source_content): Don't check before
1902         xfree.
1903         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1904
1905 2019-06-25  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-winsource.h (tui_update_source_window_as_is)
1908         (tui_alloc_source_buffer, tui_line_is_displayed)
1909         (tui_addr_is_displayed): Change type of win_info.
1910         * tui/tui-winsource.c (tui_update_source_window_as_is)
1911         (tui_clear_source_content, tui_show_source_line)
1912         (tui_show_source_content, tui_source_window_base::refill)
1913         (tui_source_window_base::set_is_exec_point_at)
1914         (tui_source_window_base::set_is_exec_point_at)
1915         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1916         (tui_alloc_source_buffer, tui_line_is_displayed)
1917         (tui_addr_is_displayed): Change type of win_info.  Update.
1918         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1919         (tui_source_window_base::do_make_visible_with_new_height):
1920         Update.
1921         * tui/tui-source.c (tui_set_source_content)
1922         (tui_set_source_content_nil)
1923         (tui_source_window::do_scroll_vertical): Update.
1924         * tui/tui-layout.c (show_layout): Update.
1925         * tui/tui-disasm.c (tui_set_disassem_content)
1926         (tui_disasm_window::do_scroll_vertical): Update.
1927         * tui/tui-data.h (tui_win_content): Remove.
1928         (struct tui_gen_win_info) <content, content_size>: Remove.
1929         (struct tui_source_element): Add initializers and destructor.
1930         (union tui_which_element, struct tui_win_element): Remove.
1931         (struct tui_source_window_base) <content>: New field.
1932         (struct tui_data_window): Remove destructor.
1933         (tui_alloc_content, tui_free_win_content)
1934         (tui_free_all_source_wins_content): Don't declare.
1935         * tui/tui-data.c (tui_initialize_static_data): Update.
1936         (init_content_element, tui_alloc_content): Remove.
1937         (~tui_gen_win_info): Update.
1938         (~tui_data_window, tui_free_all_source_wins_content)
1939         (tui_free_win_content, free_content, free_content_elements):
1940         Remove.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-winsource.h (tui_clear_source_content)
1945         (tui_erase_source_content, tui_show_source_content): Change type
1946         of win_info.
1947         * tui/tui-winsource.c (tui_clear_source_content)
1948         (tui_erase_source_content, tui_show_source_content): Change type
1949         of win_info.
1950         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1951         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1952         win_info.
1953         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1954         win_info.
1955         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-winsource.c (tui_clear_source_content)
1960         (tui_source_window_base::set_is_exec_point_at): Update.
1961         * tui/tui-source.c (tui_set_source_content_nil): Update.
1962         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1963         a bool.
1964         * tui/tui-data.c (init_content_element): Update.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1969         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1970         * tui/tui-layout.c (init_and_make_win): Update.
1971         * tui/tui.h (enum tui_win_type): Update.
1972         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1973         tui_win_is_auxillary.
1974         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1975         tui_win_is_auxillary.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1980         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1981         (tui_delete_data_content_windows, tui_display_all_data)
1982         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1983         Update.
1984         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1985         * tui/tui-regs.c (tui_last_regs_line_no)
1986         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1987         (tui_show_registers): Update.
1988         (tui_show_register_group): Return void.  Update.
1989         (tui_display_registers_from, tui_display_reg_element_at_line)
1990         (tui_display_registers_from_line, tui_check_register_values):
1991         Update.
1992         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1993         member.
1994         (struct tui_data_window) <regs_content>: Now a std::vector.
1995         <regs_content_count>: Remove.
1996         (tui_add_content_elements, tui_free_data_content): Don't declare.
1997         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1998         (init_content_element): Remove DATA_WIN case.  Add assert.
1999         (tui_add_content_elements): Remove.
2000         (tui_data_window): Update.
2001         (tui_free_data_content): Remove.
2002         (free_content_elements): Remove DATA_WIN case.
2003
2004 2019-06-25  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-data.c (tui_data_item_window): Update.
2007         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2008         * tui/tui-windata.c (tui_display_all_data)
2009         (tui_display_data_from_line): Update.
2010         (tui_check_data_values): Remove.
2011         * tui/tui-regs.c (tui_show_register_group)
2012         (tui_display_reg_element_at_line): Update.
2013         * tui/tui-hooks.c (tui_register_changed)
2014         (tui_refresh_frame_and_register_information): Call
2015         tui_check_register_values.
2016         * tui/tui-data.h (struct tui_data_window) <data_content,
2017         data_content_count, data_type>: Remove.
2018         (enum tui_data_type): Remove.
2019
2020         * tui/tui-data.c (tui_data_window::clear_detail)
2021         (~tui_data_window): Update.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2026         declare.
2027         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2028         Rename from tui_first_data_item_displayed.  Update.
2029         (tui_data_window::refresh_all)
2030         (tui_data_window::do_scroll_vertical): Update.
2031         * tui/tui-data.h (struct tui_data_window)
2032         <first_data_item_displayed>: Declare new method.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2037         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2038         contents...
2039         (tui_initialize_static_data): ...here.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2044         (tui_display_registers_from, tui_check_register_values): Update.
2045         (tui_display_register): Remove win_info parameter; update.
2046         (tui_get_register): Change type of parameters.
2047         * tui/tui-data.h (struct tui_data_element): Remove.
2048         (union tui_which_element) <data>: Remove.
2049         <data_window>: Change type.
2050         (struct tui_data_item_window): New.
2051         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2052         case.  Add assert.
2053         (~tui_data_item_window): New destructor.
2054         (free_content_elements): Remove DATA_ITEM_WIN case.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2059         Remove.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-data.h (struct tui_command_element): Remove.
2064         (union tui_which_element) <command>: Remove.
2065         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2066         assert.
2067         (free_content_elements): Remove CMD_WIN case.
2068
2069 2019-06-25  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-layout.c (tui_set_layout): Update.
2072         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2073         * tui/tui-data.c (layout_def): Update.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2078         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2079         (tui_source_window_base::set_new_height): Update.
2080         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2081         Update.
2082         (tui_set_locator_fullname, tui_set_locator_info)
2083         (tui_show_frame_info): Update.
2084         * tui/tui-source.c (tui_set_source_content)
2085         (tui_source_is_displayed): Update.
2086         * tui/tui-layout.c (show_source_disasm_command, show_data)
2087         (show_source_or_disasm_and_command): Update.
2088         * tui/tui-disasm.c (tui_set_disassem_content)
2089         (tui_get_begin_asm_address): Update.
2090         * tui/tui-data.h (struct tui_locator_element): Remove.
2091         (union tui_which_element) <locator>: Remove.
2092         (struct tui_locator_window): New.
2093         (tui_locator_win_info_ptr): Change return type.
2094         * tui/tui-data.c (_locator): Change type.
2095         (tui_locator_win_info_ptr): Change return type.
2096         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2097         (tui_alloc_content): Add assert.
2098
2099 2019-06-25  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-winsource.c
2102         (tui_exec_info_window::maybe_allocate_content): New method.
2103         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2104         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2105         (make_source_or_disasm_window): Add cast.
2106         * tui/tui-data.h (union tui_which_element) <simple_string>:
2107         Remove.
2108         (struct tui_source_info): New.
2109         (struct tui_source_window_base) <execution_info>: Change type.
2110         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2111         case, and add assert.
2112         (tui_alloc_content): Add assert.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2117         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2118         * tui/tui-data.c (tui_alloc_win_info): Remove.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2123         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2124         can_highlight.
2125
2126 2019-06-25  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2129         make_visible_with_new_height method.
2130         (tui_win_info::make_visible_with_new_height): New method.
2131         (tui_source_window_base::do_make_visible_with_new_height)
2132         (tui_data_window::do_make_visible_with_new_height)
2133         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2134         (make_visible_with_new_height): Remove.
2135         (tui_resize_all, tui_adjust_win_heights): Use
2136         make_visible_with_new_height method.
2137         * tui/tui-data.h (struct tui_win_info)
2138         <do_make_visible_with_new_height, make_visible_with_new_height>:
2139         New methods.
2140         (struct tui_source_window_base, struct tui_data_window)
2141         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2142         methods.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2147         method.
2148         (update_tab_width): Call update_tab_width method.
2149         * tui/tui-data.h (struct tui_win_info)
2150         (struct tui_source_window_base) <update_tab_width>: New methods.
2151
2152 2019-06-25  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2155         parameter.
2156         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2157         parameter.
2158         (tui_gen_win_info::make_visible): Update.
2159         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2160         parameter.
2161         * tui/tui-data.h (enum tui_box): New enum.
2162         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2163
2164 2019-06-25  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2167         init_and_make_win for EXEC_INFO_WIN.
2168         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2169         longer inline.
2170         (struct tui_win_info) <~tui_win_info>: Inline.
2171         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2172         Don't declare.
2173         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2174         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2175         Remove.
2176         (tui_initialize_static_data): Update.
2177         (~tui_gen_win_info): Handle more cleanup here.
2178         (~tui_source_window_base): Delete "execution_info".
2179         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2180
2181 2019-06-25  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-layout.c (make_command_window): Don't set
2184         can_highlight.
2185         (show_source_disasm_command): Call the reset method.
2186         (show_data): Don't set can_highlight.  Call the reset method.
2187         (tui_gen_win_info::reset): Rename from init_gen_win_info
2188         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2189         (show_source_or_disasm_and_command): Call the reset method.
2190         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2191         (struct tui_cmd_window): Set can_highlight.
2192
2193 2019-06-25  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2196         from make_visible.
2197         (tui_make_visible, tui_make_invisible): Rewrite.
2198         (tui_win_info::make_visible): Remove.
2199         (tui_source_window_base::make_visible): Update.
2200         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2201         method.  Moved from...
2202         (struct tui_win_info) <make_visible>: ...here.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-winsource.c
2207         (tui_source_window_base::do_scroll_horizontal): Remove direction
2208         parameter.
2209         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2210         direction parameter.
2211         * tui/tui-win.c (tui_win_info::forward_scroll)
2212         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2213         (tui_win_info::right_scroll): Update.
2214         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2215         direction parameter.
2216         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2217         direction parameter.
2218         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2219         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2220         Remove direction parameter.
2221         (struct tui_source_window_base, struct tui_source_window)
2222         (struct tui_disasm_window, struct tui_data_window)
2223         (struct tui_cmd_window): Update.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-winsource.h (tui_set_exec_info_content)
2228         (tui_show_exec_info_content, tui_erase_exec_info_content)
2229         (tui_clear_exec_info_content, tui_update_exec_info): Change
2230         argument to tui_source_window_base.
2231         * tui/tui-winsource.c (tui_set_exec_info_content)
2232         (tui_show_exec_info_content, tui_erase_exec_info_content)
2233         (tui_clear_exec_info_content, tui_update_exec_info): Change
2234         argument to tui_source_window_base.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2239         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2244         check.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2249         type to void.
2250         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2251         type to void.
2252         * tui/tui-source.c (tui_set_source_content): Update.
2253         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2254
2255 2019-06-25  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-win.c (window_name_completer, tui_set_focus)
2258         (tui_all_windows_info): Use name method.
2259         * tui/tui-data.h (struct tui_gen_win_info)
2260         (struct tui_source_window, struct tui_disasm_window)
2261         (struct tui_data_window, struct tui_cmd_window) <name>: New
2262         method.
2263         (tui_win_name): Don't declare.
2264         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2265         (tui_win_name): Remove.
2266
2267 2019-06-25  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-winsource.h (tui_update_source_window)
2270         (tui_update_source_window_as_is): Change parameter type.
2271         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2272         to be a tui_source_window_base.
2273         (tui_update_source_window_as_is): Likewise.
2274         * tui/tui-win.c (make_visible_with_new_height): Update.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-winsource.c (tui_erase_source_content)
2279         (tui_show_source_content, tui_show_exec_info_content)
2280         (tui_erase_exec_info_content): Use refresh_window method.
2281         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2282         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2283         from tui_refresh_win.
2284         (tui_data_window::refresh_window): New method.
2285         (tui_win_info::refresh, tui_source_window_base::refresh)
2286         (tui_refresh_all): Use refresh_window method.
2287         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2288         method.
2289         * tui/tui-regs.c (tui_display_register): Call refresh_window
2290         method.
2291         * tui/tui-layout.c (show_source_disasm_command)
2292         (show_source_or_disasm_and_command): Call refresh_window method.
2293         * tui/tui-data.h (struct tui_gen_win_info)
2294         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2295         New method.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui.c (tui_rl_other_window, tui_enable)
2300         (tui_is_window_visible, tui_get_command_dimension): Update.
2301         * tui/tui-winsource.c (tui_update_source_window_as_is)
2302         (tui_clear_source_content, tui_erase_source_content)
2303         (tui_show_source_line, tui_source_window_base::refill)
2304         (tui_source_window_base::do_scroll_horizontal)
2305         (tui_source_window_base::set_is_exec_point_at)
2306         (tui_update_breakpoint_info, tui_set_exec_info_content)
2307         (tui_alloc_source_buffer, tui_line_is_displayed)
2308         (tui_addr_is_displayed): Update.
2309         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2310         (tui_check_and_display_highlight_if_needed)
2311         (tui_win_info::make_visible, tui_win_info::refresh)
2312         (tui_refresh_all): Update.
2313         * tui/tui-windata.c (tui_first_data_item_displayed)
2314         (tui_delete_data_content_windows, tui_erase_data_content)
2315         (tui_display_all_data, tui_data_window::refresh_all)
2316         (tui_check_data_values): Update.
2317         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2318         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2319         (tui_win_info::backward_scroll, tui_refresh_all_win)
2320         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2321         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2322         (tui_source_window_base::set_new_height)
2323         (tui_data_window::set_new_height)
2324         (make_invisible_and_set_new_height)
2325         (make_visible_with_new_height, new_height_ok)
2326         (parse_scrolling_args): Update.
2327         * tui/tui-stack.c (tui_show_frame_info): Update.
2328         * tui/tui-source.c (tui_set_source_content)
2329         (tui_set_source_content_nil, tui_source_is_displayed)
2330         (tui_source_window::do_scroll_vertical): Update.
2331         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2332         (tui_display_registers_from, tui_display_reg_element_at_line)
2333         (tui_check_register_values, tui_reg_command): Update.
2334         * tui/tui-layout.c (tui_default_win_height)
2335         (show_source_disasm_command, show_data, init_and_make_win)
2336         (show_source_or_disasm_and_command): Update.
2337         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2338         (tui_redisplay_readline, tui_mld_flush)
2339         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2340         (tui_getc): Update.
2341         * tui/tui-disasm.c (tui_set_disassem_content)
2342         (tui_disasm_window::do_scroll_vertical): Update.
2343         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2344         Now virtual.
2345         (struct tui_win_info): Derive from tui_gen_win_info.
2346         <~tui_win_info>: Mark as override.
2347         <generic>: Remove member.
2348         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2349         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2350         (~tui_data_window, ~tui_win_info)
2351         (tui_free_all_source_wins_content): Update.
2352         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2353
2354 2019-06-25  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-layout.c (init_and_make_win): Use new.
2357         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2358         destructor, initializers.
2359         (tui_alloc_generic_win_info): Don't declare.
2360         * tui/tui-data.c (_locator): Add argument to constructor.
2361         (source_win, disasm_win): New globals.
2362         (exec_info): Remove.
2363         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2364         Update.
2365         (tui_alloc_generic_win_info): Remove.
2366         (init_content_element): Use new.
2367         (tui_win_info::tui_win_info): Update.
2368         (free_content_elements) <case DATA_WIN>: Use delete.
2369
2370 2019-06-25  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2373         * tui/tui-windata.c (tui_first_data_item_displayed)
2374         (tui_delete_data_content_windows): Update.
2375         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2376         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2377         (tui_display_registers_from, tui_check_register_values): Update.
2378         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2379         pointer.
2380         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2381         window.
2382         (tui_free_data_content): Update.
2383         (free_content_elements) <case DATA_WIN>: Free the window.
2384
2385 2019-06-25  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2388         Update.
2389         * tui/tui-layout.c (make_command_window)
2390         (show_source_disasm_command, show_data, init_and_make_win)
2391         (show_source_or_disasm_and_command): Update.
2392         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2393         method.
2394         <can_highight, is_highlighted>: Now bool.
2395         (tui_set_win_highlight): Don't declare.
2396         * tui/tui-data.c (tui_set_win_highlight): Remove.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-wingeneral.c (make_visible): Remove check of window
2401         type.
2402
2403 2019-06-25  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-win.c (tui_win_info::max_height)
2406         (tui_cmd_window::max_height): New methods.
2407         (new_height_ok): Call max_height.
2408         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2409         <max_height>: New method.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-win.c (tui_source_window_base::set_new_height)
2414         (tui_data_window::set_new_height): New methods.
2415         (make_invisible_and_set_new_height): Call set_new_height method.
2416         * tui/tui-data.h (struct tui_win_info)
2417         (struct tui_source_window_base, struct tui_data_window)
2418         <set_new_height>: New method.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2423         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2424         tui_refresh_data_win.
2425         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2426         method.
2427         (tui_refresh_all_win): Call the refresh_all method.
2428         (tui_set_focus): Likewise.
2429         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2430         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2431         Likewise.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-winsource.h (tui_refill_source_window)
2436         (tui_set_is_exec_point_at): Don't declare.
2437         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2438         (tui_source_window_base::refill): Rename from
2439         tui_refill_source_window.
2440         (tui_source_window_base::do_scroll_horizontal): Update.
2441         (tui_source_window_base::set_is_exec_point_at): Rename from
2442         tui_set_is_exec_point_at.
2443         (tui_update_all_breakpoint_info): Update.
2444         * tui/tui-stack.c (tui_show_frame_info): Update.
2445         * tui/tui-layout.c (show_data): Add cast.
2446         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2447         * tui/tui-data.h (struct tui_source_window_base) <refill,
2448         set_is_exec_point_at>: New methods.
2449         (tui_source_windows, tui_add_to_source_windows): Update types.
2450         (tui_add_to_source_windows): Remove redundant declaration.
2451         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2452         (tui_source_windows): Change return type.
2453         (tui_clear_source_windows_detail): Update.
2454         (tui_add_to_source_windows): Change type of parameter.
2455         (tui_free_all_source_wins_content): Update.
2456
2457 2019-06-25  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-wingeneral.c (tui_win_info::refresh)
2460         (tui_source_window_base::refresh): New methods.
2461         (tui_refresh_all): Call the refresh method.
2462         * tui/tui-data.h (struct tui_win_info)
2463         (struct tui_source_window_base) <refresh>: New method.
2464
2465 2019-06-25  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui.h (tui_is_window_visible): Return bool.
2468         * tui/tui.c (tui_is_window_visible): Return bool.
2469         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2470         (tui_make_visible, tui_make_invisible)
2471         (tui_win_info::make_visible)
2472         (tui_source_window_base::make_visible, make_all_visible)
2473         (tui_make_all_visible, tui_make_all_invisible): Update.
2474         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2475         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2476         bool.
2477         (struct tui_win_info, struct tui_source_window_base)
2478         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2479         * tui/tui-data.c (tui_init_generic_part): Update.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2484         (tui_source_window_base::make_visible): New methods.
2485         (make_all_visible): Make method call.
2486         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2487         (struct tui_source_window_base, struct tui_cmd_window): Override
2488         make_visible.
2489         (tui_win_is_source_type): Don't declare.
2490         * tui/tui-data.c (tui_win_is_source_type): Remove.
2491
2492 2019-06-25  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2495         NULL check.
2496
2497 2019-06-25  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2500         Inline constructor.  Add initializers for members.
2501         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2502         constructors; now inline in class.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-regs.c (tui_show_registers): Update.
2507         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2508         bool.
2509         * tui/tui-data.c (tui_data_window::clear_detail)
2510         (tui_data_window): Update.
2511
2512 2019-06-25  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-windata.c (tui_display_all_data)
2515         (tui_display_data_from_line, tui_display_data_from)
2516         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2517         Update.
2518         * tui/tui-regs.c (tui_last_regs_line_no)
2519         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2520         (tui_show_registers, tui_show_register_group)
2521         (tui_display_registers_from, tui_display_reg_element_at_line)
2522         (tui_display_registers_from_line, tui_check_register_values)
2523         (tui_reg_next, tui_reg_prev): Update.
2524         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2525         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2526         tui_data_window.
2527         (struct tui_win_info) <detail>: Remove.  Add new fields from
2528         tui_data_info.
2529         (TUI_DATA_WIN): Add cast.
2530         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2531         (~tui_data_window): Simplify.
2532
2533 2019-06-25  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-layout.c (show_source_disasm_command)
2536         (show_source_or_disasm_and_command): Update.
2537         * tui/tui-io.c (update_cmdwin_start_line)
2538         (tui_redisplay_readline): Update.
2539         * tui/tui-data.h (struct tui_command_info): Remove.
2540         (struct tui_win_info) <detail>: Remove command_info member.
2541         (struct tui_data_window) <start_line>: New member, from
2542         tui_command_info.
2543         (TUI_CMD_WIN): Add casts.
2544
2545 2019-06-25  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-winsource.c (tui_update_source_window)
2548         (tui_refill_source_window)
2549         (tui_source_window_base::do_scroll_horizontal)
2550         (tui_update_breakpoint_info, tui_set_exec_info_content)
2551         (tui_show_exec_info_content, tui_erase_exec_info_content)
2552         (tui_clear_exec_info_content): Update.
2553         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2554         Update.
2555         * tui/tui-win.c (make_invisible_and_set_new_height)
2556         (make_visible_with_new_height): Update.
2557         * tui/tui-source.c (tui_set_source_content)
2558         (tui_show_symtab_source): Update.
2559         * tui/tui-layout.c (extract_display_start_addr)
2560         (show_source_disasm_command, show_data)
2561         (make_source_or_disasm_window)
2562         (show_source_or_disasm_and_command): Update.
2563         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2564         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2565         "gdbarch".
2566         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2567         to tui_source_window_base.
2568         (struct tui_win_info) <detail>: Remove source_info member.
2569         (struct tui_source_window_base) <has_locator>: Inline.
2570         Move contents from tui_source_info; rename has_locator member to
2571         m_has_locator.
2572         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2573         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2574         header file.
2575         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2576         Simplify.
2577         (tui_free_all_source_wins_content): Cast to
2578         tui_source_window_base.
2579
2580 2019-06-25  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-win.c (make_invisible_and_set_new_height)
2583         (make_visible_with_new_height): Call has_locator method.
2584         * tui/tui-layout.c (show_source_disasm_command, show_data)
2585         (show_source_or_disasm_and_command): Update for bool change.
2586         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2587         (tui_win_info) <has_locator>: New method.
2588         (struct tui_source_window_base) <has_locator>: New method.
2589         (tui_win_has_locator): Don't declare.
2590         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2591         from tui_win_has_locator.
2592         (tui_source_window_base): Use false, not FALSE.
2593
2594 2019-06-25  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2597         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2598         clear_detail method directly.
2599         (tui_clear_win_detail): Remove.
2600
2601 2019-06-25  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2604         "this", not TUI_DISASM_WIN.
2605
2606 2019-06-25  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2609         declare.
2610         * tui/tui-winsource.c
2611         (tui_source_window_base::do_scroll_horizontal): Rename from
2612         tui_horizontal_source_scroll.
2613         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2614         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2615         from tui_vertical_data_scroll.
2616         * tui/tui-win.h (tui_scroll): Don't declare.
2617         * tui/tui-win.c (tui_win_info::forward_scroll)
2618         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2619         (tui_win_info::right_scroll): Rename and update.
2620         (tui_scroll_forward_command, tui_scroll_backward_command)
2621         (tui_scroll_left_command, tui_scroll_right_command): Update.
2622         (tui_scroll): Remove.
2623         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2624         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2625         from tui_vertical_source_scroll.
2626         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2627         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2628         from tui_vertical_disassem_scroll.
2629         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2630         do_scroll_horizontal>: New methods.
2631         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2632         Likewise.
2633         (struct tui_source_window_base): Add do_scroll_horizontal.
2634         (struct tui_source_window, struct tui_disasm_window): Add
2635         do_scroll_vertical.
2636         (struct tui_data_window, struct tui_cmd_window): Add
2637         do_scroll_horizontal and do_scroll_vertical.
2638         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2639
2640 2019-06-25  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-data.h (struct tui_source_window_base): New struct.
2643         (struct tui_source_window): Derive from tui_source_window_base.
2644         (struct tui_disasm_window): New struct.
2645         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2646         from tui_source_window::clear_detail.
2647         (tui_source_window_base): Rename from tui_source_window.
2648         (~tui_source_window_base): Rename from ~tui_source_window.
2649         (tui_alloc_win_info): Create a tui_disasm_window.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-data.h (struct tui_source_window)
2654         (struct tui_data_window): Declare destructors.
2655         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2656         destructors.
2657         (tui_win_info): Simplify.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-winsource.c (tui_display_main)
2662         (tui_update_source_windows_with_addr)
2663         (tui_update_all_breakpoint_info): Update.
2664         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2665         (new_height_ok, parse_scrolling_args): Update.
2666         * tui/tui-stack.c (tui_show_frame_info): Update.
2667         * tui/tui-data.h (struct tui_list): Remove.
2668         (tui_source_windows): Return a reference to a std::vector.
2669         * tui/tui-data.c (source_windows): Now a std::vector.
2670         (tui_source_windows): Change return type.
2671         (tui_clear_source_windows): Rewrite.
2672         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2673         (tui_free_all_source_wins_content): Rewrite.
2674
2675 2019-06-25  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2678         (struct tui_data_window, struct tui_cmd_window): Declare
2679         clear_detail method.
2680         * tui/tui-data.c (tui_source_window::clear_detail)
2681         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2682         methods.
2683         (tui_clear_win_detail): Simplify.
2684
2685 2019-06-25  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-layout.c (make_source_window, make_disasm_window)
2688         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2689         Return the new window.
2690         (show_source_disasm_command, show_data)
2691         (show_source_or_disasm_and_command): Update.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2696         parameter.  Return the new window.
2697         (show_source_disasm_command): Update and remove NULL check.
2698         (show_source_or_disasm_and_command): Update.
2699
2700 2019-06-25  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2703
2704 2019-06-25  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-data.h (struct tui_win_info): Make constructor
2707         protected.  Make destructor virtual.  Add initializers.
2708         (tui_source_window, tui_data_window, tui_cmd_window): New
2709         classes.
2710         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2711         constructor.  Add "type" parameter.
2712         (tui_source_window, tui_data_window, tui_cmd_window): New
2713         constructors.
2714         (tui_alloc_win_info): Instantiate the appropriate subclass.
2715
2716 2019-06-25  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-win.c (tui_resize_all): Use delete.
2719         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2720         destructor.
2721         (tui_free_window): Don't declare.
2722         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2723         Update.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-data.h (struct tui_win_info): Add constructor.
2728         * tui/tui-data.c (tui_alloc_win_info): Use new.
2729         (tui_free_window): Use delete.
2730
2731 2019-06-22  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2734         declare.
2735         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2736
2737 2019-06-22  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2740         declare.
2741         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2742
2743 2019-06-22  Tom de Vries  <tdevries@suse.de>
2744
2745         * dwarf2read.c (create_addrmap_from_aranges)
2746         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2747         instead of '%zu'.
2748
2749 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2750
2751         * dwarf2read.h (dwarf2_section_info_def): Remove.
2752         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2753         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2754         std::vector<dwarf2_section_info>.
2755         (struct dwo_file) <~dwo_file>: Remove.
2756         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2757         types field.
2758         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2759         (dwarf2_read_debug_names): Likewise.
2760         (create_debug_types_hash_table): Change parameter type to
2761         array_view, adjust code accordingly.
2762         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2763         (partial_die_info::fixup): Likewise.
2764         (determine_prefix): Likewise.
2765         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2766
2767 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2768
2769         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2770         gdb_bfd_ref_ptr.
2771         <~dwo_file>: Remove call to gdb_bfd_unref.
2772         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2773         gdb_bfd_ref_ptr::get.
2774
2775 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2776
2777         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2778         type to htab_up.
2779         * dwarf2read.c (struct dwo_file): Initialize fields.
2780         <~dwo_file>: New.
2781         (free_dwo_file): Remove, move content to ~dwo_file.
2782         (struct dwo_file_deleter): Remove.
2783         (dwo_file_up>: Remove custom deleter.
2784         (free_dwo_files): Remove.
2785         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2786         dwo_files.
2787         (process_skeletonless_type_units): Call unique_ptr::get.
2788         (allocate_dwo_file_hash_table): Add deleter to created hash
2789         table.  Change return type to htab_up.
2790         (lookup_dwo_file_slot): Don't memset dwo_file, call
2791         unique_ptr::get.
2792         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2793         (create_dwo_unit_in_dwp_v2): Likewise.
2794         (open_and_init_dwo_file): Likewise.
2795         (free_dwo_file_from_slot): Remove.
2796
2797 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2798
2799         * dwarf2read.h (struct dwarf2_section_info) <readin,
2800         is_virtual>: Change type to bool.
2801         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2802         true instead of 1.
2803
2804 2019-06-19  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-data.h (tui_init_content_element): Don't declare.
2807
2808 2019-06-19  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-data.h (tui_init_win_info): Don't declare.
2811
2812 2019-06-19  Tom de Vries  <tdevries@suse.de>
2813
2814         * dwarf2read.h (abstract_to_concrete): Change type to
2815         std::unordered_map<sect_offset, std::vector<sect_offset>,
2816         gdb::hash_enum<sect_offset>>.
2817
2818 2019-06-19  Tom Tromey  <tromey@adacore.com>
2819
2820         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2821         EVAL_AVOID_SIDE_EFFECTS specially.
2822
2823 2019-06-19  Tom Tromey  <tromey@adacore.com>
2824
2825         * source-cache.c (highlighter): New global.
2826         (source_cache::get_source_lines): Create a highlighter on demand.
2827
2828 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * defs.h (deprecated_interactive_hook): Delete declaration.
2831         * interps.c (clear_interpreter_hooks): Remove use of
2832         deprecated_interactive_hook.
2833         * top.c (deprecated_interactive_hook): Delete definition.
2834         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2835
2836 2019-06-18  Tom de Vries  <tdevries@suse.de>
2837
2838         PR gdb/24515
2839         * dwarf2read.h (abstract_to_concrete): Change type from
2840         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2841         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2842         * dwarf2read.c (read_variable): Update.
2843         (dwarf2_fetch_die_loc_sect_off): Update.
2844
2845 2019-06-17  Tom de Vries  <tdevries@suse.de>
2846
2847         PR gdb/24617
2848         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2849         accessing parent[parent_len - 1].
2850
2851 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2852
2853         PR gdb/24364
2854         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2855         call dtrace_process_dof with NULL dof.
2856
2857 2019-06-16  Tom de Vries  <tdevries@suse.de>
2858
2859         PR gdb/24445
2860         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2861
2862 2019-06-16  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2865         (make_all_visible): Use address of member.
2866
2867 2019-06-16  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2870         (tui_free_window, free_content, free_content_elements): Remove
2871         unnecessary cast.
2872         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2873         cast.
2874         * tui/tui-regs.c (tui_show_register_group)
2875         (tui_display_registers_from, tui_display_reg_element_at_line):
2876         Remove unnecessary cast.
2877
2878 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * linux-nat.c (normal_mask): Delete.
2881         (_initialize_linux_nat): Don't initialise normal_mask.
2882
2883 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2884
2885         PR gdb/24445
2886         * dwarf-index-write.h (write_psymtabs_to_index): Add
2887         dwz_basename parameter.
2888         * dwarf-index-write.c (write_gdbindex): Move file writing to
2889         write_gdbindex_1.  Change return type void.
2890         (assert_file_size): Move up, remove filename parameter.
2891         (write_gdbindex_1): New function.
2892         (write_debug_names): Change return type to void, call
2893         assert_file_size.
2894         (struct index_wip_file): New struct.
2895         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2896         file logic to index_wip_file.  Write index for dwz file if
2897         needed.
2898         (save_gdb_index_command): Pass basename of dwz file, if present.
2899         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2900         build-id of dwz file, if present.
2901         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2902         (dwarf2_get_dwz_file): Likewise.
2903         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2904         (dwarf2_get_dwz_file): Likewise.
2905
2906 2019-06-16  Tom Tromey  <tom@tromey.com>
2907
2908         * coffread.c (process_coff_symbol): Use xstrdup.
2909         * value.c (create_internalvar): Use xstrdup.
2910
2911 2019-06-16  Tom Tromey  <tom@tromey.com>
2912
2913         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2914         * breakpoint.c (stopin_command, stopat_command)
2915         (until_break_command, decode_location_default): Remove unnecessary
2916         cast.
2917         * utils.c (subset_compare): Remove unnecessary cast.
2918         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2919         cast.
2920         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2921         cast.
2922         * infcmd.c (path_command): Remove unnecessary cast.
2923         * coffread.c (decode_type): Remove unnecessary cast.
2924         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2925         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2926         * tui/tui-stack.c (tui_show_locator_content)
2927         (tui_show_frame_info): Remove unnecessary cast.
2928         * tui/tui-win.c (tui_scroll_forward_command)
2929         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2930         (parse_scrolling_args): Remove unnecessary cast.
2931         * tui/tui-data.c (init_win_info, tui_del_window)
2932         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2933         (free_content_elements): Remove unnecessary cast.
2934         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2935         unnecessary cast.
2936         * tui/tui-source.c (tui_set_source_content)
2937         (tui_vertical_source_scroll): Remove unnecessary cast.
2938         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2939         cast.
2940         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2941         * tui/tui-regs.c (tui_display_registers_from)
2942         (tui_display_register): Remove unnecessary cast.
2943         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2944         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2945         (make_visible): Remove unnecessary cast.
2946         * tui/tui-winsource.c (tui_erase_source_content)
2947         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2948         unnecessary cast.
2949         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2950         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2951         * stabsread.c (read_type, read_array_type, read_range_type):
2952         Remove unnecessary cast.
2953         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2954         (parse_symbol, parse_type, upgrade_type, parse_external)
2955         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2956         unnecessary cast.
2957         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2958
2959 2019-06-16  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-data.c (tui_alloc_generic_win_info)
2962         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2963         checks.
2964
2965 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2966             Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * f-typeprint.c (f_print_type): Don't return early for not
2969         associated or not allocated types.
2970         (f_type_print_varspec_suffix): Add print_rank parameter and print
2971         ranks of array types in case they dangling.
2972         (f_type_print_base): Add print_rank parameter.
2973
2974 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * NEWS: Mention new MI commands.
2977         * break-catch-throw.c (enum exception_event_kind): Move to
2978         breakpoint.h.
2979         (print_mention_exception_catchpoint): Output text as a single
2980         message.
2981         (catch_exception_command_1): Rename to...
2982         (catch_exception_event): ...this, make non-static, update header
2983         command, and change some parameter types.
2984         (catch_catch_command): Update for changes to
2985         catch_exception_command_1.
2986         (catch_throw_command): Likewise.
2987         (catch_rethrow_command): Likewise.
2988         * breakpoint.c (enum exception_event_kind): Delete.
2989         * breakpoint.h (enum exception_event_kind): Moved here from
2990         break-catch-throw.c.
2991         (catch_exception_event): Declare.
2992         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2993         (mi_cmd_catch_throw): New function.
2994         (mi_cmd_catch_rethrow): New function.
2995         (mi_cmd_catch_catch): New function.
2996         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2997         'catch-catch' entries.
2998         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2999         (mi_cmd_catch_rethrow): Declare.
3000         (mi_cmd_catch_catch): Declare.
3001
3002 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * annotate.c (annotate_source_line): Change return type to void,
3005         update implementation to match.
3006         * annotate.h (annotate_source_line): Change return type to void,
3007         update header comment.
3008         * stack.c (print_frame_info): Don't change what frame information
3009         is printed based on whether annotations are on or not.
3010
3011 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3014         (annotate_source): Make static.
3015         (annotate_source_line): Moved from source.c and renamed from
3016         identify_source_line.  Update the return type.
3017         * annotate.h (annotate_source): Delete declaration.
3018         (annotate_source_line): Declaration moved from source.h, and
3019         renamed from identify_source_line.  Return type updated.
3020         * source.c (identify_source_line): Moved to annotate.c and renamed
3021         to annotate_source_line.
3022         (info_line_command): Remove check of annotation_level.
3023         * source.h (identify_source_line): Move declaration to annotate.h
3024         and rename to annotate_source_line.
3025         * stack.c: Add 'annotate.h' include.
3026         (print_frame_info): Remove check of annotation_level before
3027         calling annotate_source_line.
3028
3029 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * source-cache.c (source_cache::get_plain_source_lines): Use
3032         open_source_file_with_line_charpos instead of just
3033         open_source_file, remove call to find_source_lines.
3034         (source_cache::get_source_lines): Likewise.
3035         * source.c (find_source_lines): Make static.
3036         (get_filename_and_charpos): Renamed into...
3037         (open_source_file_with_line_charpos): ..this along with changes to
3038         return a scoped_fd, and some other minor clean ups.
3039         (identify_source_line): Use open_source_file_with_line_charpos.
3040         (search_command_helper): Use open_source_file_with_line_charpos
3041         instead of just open_source_file, remove call to
3042         find_source_lines.
3043         * source.h (open_source_file_with_line_charpos): Declare new
3044         function.
3045         (find_source_lines): Delete declaration.
3046
3047 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3048
3049         * source.c (get_filename_and_charpos): Remove fullname
3050         parameter.
3051         (identify_source_line): Update call to get_filename_and_charpos.
3052
3053 2019-06-14  Tom Tromey  <tromey@adacore.com>
3054
3055         PR gdb/24502:
3056         * ui-style.h (skip_ansi_escape): Update comment.
3057         * ui-file.h (class no_terminal_escape_file): New class.
3058         * ui-file.c (no_terminal_escape_file::write)
3059         (no_terminal_escape_file::puts): New methods.
3060         * cli/cli-logging.c (handle_redirections): Use
3061         no_terminal_escape_file.
3062
3063 2019-06-14  Tom Tromey  <tromey@adacore.com>
3064
3065         * NEWS: Move convenience variable news above Python news.
3066
3067 2019-06-14  Tom Tromey  <tom@tromey.com>
3068
3069         * gnulib: Move directory to top-level.
3070         * configure.ac: Don't configure gnulib.
3071         * configure: Rebuild.
3072         * common/common-defs.h: Use new path to gnulib.
3073         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3074         (GNULIB_H): Remove.
3075         (INCGNU): Look in new gnulib location.
3076         (HFILES_NO_SRCDIR): Remove gnulib files.
3077         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3078         (generated_files): Remove GNULIB_H.
3079         ($(LIBGNU), all-lib): Remove targets.
3080         (distclean): Don't mention GNULIB_BUILDDIR.
3081         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3082
3083 2019-06-14  Tom Tromey  <tromey@adacore.com>
3084
3085         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3086         Warn if symbol file does not provide any symbols.
3087
3088 2019-06-14  Tom Tromey  <tromey@adacore.com>
3089
3090         * source.c (find_and_open_source): Respect basenames_may_differ.
3091
3092 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * annotate.c (annotate_breakpoints_invalid): Make use of
3095         scoped_restore_terminal_state.
3096         (annotate_frames_invalid): Likewise.
3097
3098 2019-06-14  Tom Tromey  <tromey@adacore.com>
3099
3100         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3101         allow assignment to an internalvar.
3102
3103 2019-06-14  Tom Tromey  <tromey@adacore.com>
3104
3105         * ada-lex.l: Allow "_" in attribute names.
3106
3107 2019-06-14  Tom Tromey  <tromey@adacore.com>
3108
3109         PR gdb/24653:
3110         * regcache.c (registers_changed): Don't call alloca.
3111         * top.c (execute_command): Don't call alloca.
3112
3113 2019-06-13  Pedro Alves  <palves@redhat.com>
3114
3115         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3116         'expression'.  When parsing an expression, error out if there's
3117         junk after "unlimited".
3118         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3119         (do_set_command): Adjust calls to is_unlimited_literal.
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * compile/compile.c (make_compile_options_def_group): Add braces
3124         around array_view initializer.
3125         * thread.c (make_thread_apply_all_options_def_group)
3126         (make_thread_apply_all_options_def_group): Likewise.
3127
3128 2019-06-13  Pedro Alves  <palves@redhat.com>
3129
3130         * NEWS (New commands): Mention "maint test-options
3131         require-delimiter", "maint test-options unknown-is-error", "maint
3132         test-options unknown-is-operand" and "maint show
3133         test-options-completion-result".
3134         (New command options, command completion): New section.
3135         (Completion improvements): New section.
3136         Mention that you can abbreviate "unlimited".
3137
3138 2019-06-13  Pedro Alves  <palves@redhat.com>
3139
3140         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3141         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3142         * unittests/cli-utils-selftests.c (test_parse_flags)
3143         (test_parse_flags_qcs): Delete.
3144         (test_cli_utils): Don't call deleted functions.
3145
3146 2019-06-13  Pedro Alves  <palves@redhat.com>
3147
3148         * thread.c: Include "cli/cli-option.h".
3149         (tp_array_compar_ascending): Global.
3150         (tp_array_compar): Delete function.
3151         (tp_array_compar_ascending, tp_array_compar_descending): New
3152         functions.
3153         (ascending_option_def, qcs_flag_option_def)
3154         (thr_qcs_flags_option_defs)
3155         (make_thread_apply_all_options_def_group)
3156         (make_thread_apply_options_def_group): New.
3157         (thread_apply_all_command): Use gdb::option::process_options.
3158         (thread_apply_command_completer)
3159         (thread_apply_all_command_completer): New.
3160         (thread_apply_command): Use gdb::option::process_options.
3161         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3162         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3163         to generate help text of "thread apply".  Adjust "taas"'s help.
3164         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3165         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3166
3167 2019-06-13  Pedro Alves  <palves@redhat.com>
3168
3169         * thread.c (thread_apply_command): Check for invalid TID with
3170         isdigit instead of !isalpha.
3171
3172 2019-06-13  Pedro Alves  <palves@redhat.com>
3173
3174         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3175         (validate_flags_qcs): New.
3176         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3177         (validate_flags_qcs): Declare.
3178         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3179         (make_frame_apply_options_def_group): New.
3180         (frame_apply_command_count): Process options with
3181         gdb::option::process_options.
3182         (frame_apply_completer): New.
3183         (frame_apply_level_completer, frame_apply_all_completer)
3184         (frame_apply_completer): New.
3185         (_initialize_stack): Update help of "frame apply", "frame apply
3186         level", "frame apply all" and "faas" to mention supported options
3187         and install command completers.
3188         * stack.h (frame_apply_all_completer): Declare.
3189         * thread.c: Include "stack.h".
3190         (tfaas_command): Add "--".
3191         (_initialize_thread): Update help "tfaas" to mention supported
3192         options and install command completer.
3193
3194 2019-06-13  Pedro Alves  <palves@redhat.com>
3195
3196         * completer.c (complete_nested_command_line): New.
3197         (gdb_completion_word_break_characters_throw): Add assertion.
3198         * completer.h (complete_nested_command_line): Declare.
3199
3200 2019-06-13  Pedro Alves  <palves@redhat.com>
3201
3202         * stack.c (parse_backtrace_qualifiers): New.
3203         (backtrace_command): Use it.
3204         (backtrace_command_completer): Complete on qualifiers.
3205
3206 2019-06-13  Pedro Alves  <palves@redhat.com>
3207
3208         * frame.c: Include "cli/cli-option.h.
3209         (user_set_backtrace_options): New.
3210         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3211         Delete.
3212         (get_prev_frame): Adjust.
3213         (boolean_option_def, uinteger_option_def)
3214         (set_backtrace_option_defs): New.
3215         (_initialize_frame): Adjust and use
3216         gdb::option::add_setshow_cmds_for_options to install "set
3217         backtrace past-main" and "set backtrace past-entry".
3218         * frame.h: Include "cli/cli-option.h".
3219         (struct frame_print_options): Forward declare.
3220         (print_frame_arguments_all, print_frame_arguments_scalars)
3221         (print_frame_arguments_none): Declare.
3222         (print_entry_values): Delete declaration.
3223         (struct frame_print_options, user_frame_print_options): New.
3224         (struct set_backtrace_options): New.
3225         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3226         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3227         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3228         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3229         (list_args_or_locals): Add frame_print_options parameter.
3230         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3231         * python/py-framefilter.c (enumerate_args): Pass down
3232         USER_FRAME_PRINT_OPTIONS.
3233         * stack.c: Include "cli/cli-option.h".
3234         (print_frame_arguments_all, print_frame_arguments_scalars)
3235         (print_frame_arguments_none): Declare.
3236         (print_raw_frame_arguments, print_entry_values): Delete.
3237         (user_frame_print_options): New.
3238         (boolean_option_def, enum_option_def, frame_print_option_defs):
3239         New.
3240         (struct backtrace_cmd_options): New.
3241         (bt_flag_option_def): New.
3242         (backtrace_command_option_defs): New.
3243         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3244         (print_frame_arg, read_frame_arg, print_frame_args)
3245         (print_frame_info, print_frame): Add frame_print_options parameter
3246         and use it.
3247         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3248         (backtrace_command_1): Add frame_print_options and
3249         backtrace_cmd_options parameters and use them.
3250         (make_backtrace_options_def_group): New.
3251         (backtrace_command): Process command options with
3252         gdb::option::process_options.
3253         (backtrace_command_completer): New.
3254         (_initialize_stack): Extend "backtrace"'s help to mention
3255         supported options.  Install completer for "backtrace".
3256         Install some settings commands with add_setshow_cmds_for_options.
3257
3258 2019-06-13  Pedro Alves  <palves@redhat.com>
3259
3260         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3261         and that "set/show print raw frame-arguments" are now deprecated.
3262
3263         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3264         command.
3265         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3266         * stack.c (_initialize_stack): Install "set/show print
3267         raw-frame-arguments", and deprecate "set/show print raw
3268         frame-arguments".
3269         * valprint.c (_initialize_valprint): Deprecate "set/show print
3270         raw".
3271
3272 2019-06-13  Pedro Alves  <palves@redhat.com>
3273
3274         * compile/compile.c (struct compile_options): New.
3275         (compile_flag_option_def, compile_command_option_defs)
3276         (make_compile_options_def_group): New.
3277         (compile_file_command): Handle options with
3278         gdb::option::process_options.
3279         (compile_file_command_completer): New function.
3280         (compile_code_command): Handle options with
3281         gdb::option::process_options.
3282         (compile_code_command_completer): New function.
3283         (_initialize_compiler): Install completers for "compile code" and
3284         "compile file".  Mention available options in "compile code" and
3285         "compile code"'s help.
3286         * completer.c (advance_to_completion_word): New, factored out from
3287         ...
3288         (advance_to_expression_complete_word_point): ... this.
3289         (advance_to_filename_complete_word_point): New.
3290         * completer.h (advance_to_filename_complete_word_point): New
3291         declaration.
3292
3293 2019-06-13  Pedro Alves  <palves@redhat.com>
3294
3295         * compile/compile.c: Include "cli/cli-option.h".
3296         (compile_print_value): Scope data pointer is now a
3297         value_print_options pointer; adjust.
3298         (compile_print_command): Process options.  Scope data pointer is
3299         now a value_print_options pointer; adjust.
3300         (_initialize_compile): Update "compile print"'s help to include
3301         supported options.  Install a completer for "compile print".
3302         * cp-valprint.c (show_vtblprint, show_objectprint)
3303         (show_static_field_print): Delete.
3304         (_initialize_cp_valprint): Don't install "set print
3305         static-members", "set print vtbl", "set print object" here.
3306         * printcmd.c: Include "cli/cli-option.h" and
3307         "common/gdb_optional.h".
3308         (print_command_parse_format): Rework to fill in a
3309         value_print_options instead of a format_data.
3310         (print_value): Change parameter type from format_data pointer to
3311         value_print_options reference.  Adjust.
3312         (print_command_1): Process options.  Adjust to pass down a
3313         value_print_options.
3314         (print_command_completer): New.
3315         (_initialize_printcmd): Install print_command_completer as
3316         handle_brkchars completer for the "print" command.  Update
3317         "print"'s help to include supported options.
3318         * valprint.c: Include "cli/cli-option.h".
3319         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3320         here from cp-valprint.c.
3321         (boolean_option_def, uinteger_option_def)
3322         (value_print_option_defs, make_value_print_options_def_group):
3323         New.  Use gdb::option::add_setshow_cmds_for_options to install
3324         "set print elements", "set print null-stop", "set print repeats",
3325         "set print pretty", "set print union", "set print array", "set
3326         print address", "set print symbol", "set print array-indexes".
3327         * valprint.h: Include <string> and "cli/cli-option.h".
3328         (make_value_print_options_def_group): Declare.
3329         (print_value): Change parameter type from format_data pointer to
3330         value_print_options reference.
3331         (print_command_completer): Declare.
3332
3333 2019-06-13  Pedro Alves  <palves@redhat.com>
3334
3335         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3336         (COMMON_SFILES): Add maint-test-settings.c.
3337         * cli/cli-decode.c (boolean_enums): New global, factored out from
3338         ...
3339         (add_setshow_boolean_cmd): ... here.
3340         * cli/cli-decode.h (boolean_enums): Declare.
3341         * cli/cli-option.c: New file.
3342         * cli/cli-option.h: New file.
3343         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3344         factored out from ...
3345         (parse_cli_boolean_value(const char *)): ... this.
3346         (is_unlimited_literal): Change parameter type to pointer to
3347         pointer.  Adjust and advance ARG pointer.
3348         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3349         (parse_cli_var_enum): New, factored out from ...
3350         (do_set_command): ... this.  Adjust.
3351         * cli/cli-setshow.h (parse_cli_boolean_value)
3352         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3353         (parse_cli_var_enum): Declare.
3354         * cli/cli-utils.c: Include "cli/cli-option.h".
3355         (get_ulongest): New.
3356         * cli/cli-utils.h (get_ulongest): Declare.
3357         (check_for_argument): New overloads.
3358         * maint-test-options.c: New file.
3359
3360 2019-06-13  Pedro Alves  <palves@redhat.com>
3361
3362         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3363         parse a range if "-" is at the end of the string.
3364
3365 2019-06-13  Pedro Alves  <palves@redhat.com>
3366
3367         * cli/cli-setshow.c (parse_auto_binary_operation)
3368         (parse_cli_boolean_value): Don't allow "o".
3369
3370 2019-06-13  Pedro Alves  <palves@redhat.com>
3371
3372         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3373         * NEWS: Mention maint test-settings KIND.
3374         * maint-test-settings.c: New file.
3375
3376 2019-06-13  Pedro Alves  <palves@redhat.com>
3377
3378         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3379         completer.
3380         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3381         "set" completers.
3382
3383 2019-06-13  Pedro Alves  <palves@redhat.com>
3384
3385         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3386         after item.
3387
3388 2019-06-13  Pedro Alves  <palves@redhat.com>
3389
3390         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3391
3392 2019-06-13  Pedro Alves <palves@redhat.com>
3393
3394         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3395         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3396         call.
3397         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3398         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3399         calls.
3400         (check_for_argument): Skip spaces after argument.
3401
3402 2019-06-13  Pedro Alves  <palves@redhat.com>
3403
3404         * thread.c (thread_apply_command): Adjust TID parsing.
3405         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3406         detected before end of string.
3407         (tid_is_in_list): Error out if LIST is invalid.
3408
3409 2019-06-13  Pedro Alves  <palves@redhat.com>
3410
3411         * completer.c (complete_line_internal_1): Rewind completion word
3412         point.
3413         (completion_tracker::advance_custom_word_point_by): Change
3414         parameter type to int.
3415         * completer.h (completion_tracker::advance_custom_word_point_by):
3416         Likewise.
3417
3418 2019-06-13  Pedro Alves  <palves@redhat.com>
3419
3420         * completer.c (advance_to_completion_word): Handle delimiters.
3421
3422 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3423
3424         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3425
3426 2019-06-11  Tom Tromey  <tom@tromey.com>
3427
3428         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3429         (xmalloc_failed): Move to alloc.c.
3430         * alloc.c: New file.
3431         * Makefile.in (COMMON_SFILES): Add alloc.c.
3432
3433 2019-06-11  Tom Tromey  <tom@tromey.com>
3434
3435         * nat/linux-waitpid.c: Don't include server.h.
3436         (linux_debug): Remove.
3437         (my_waitpid): Update.
3438
3439 2019-06-11  Tom Tromey  <tromey@adacore.com>
3440
3441         * infcall.c (_initialize_infcall): Remove trailing newline from
3442         help.
3443         * user-regs.c (_initialize_user_regs): Remove trailing newline
3444         from help.
3445         * typeprint.c (_initialize_typeprint): Remove trailing newline
3446         from help.
3447         * reverse.c (_initialize_reverse): Remove trailing newlines from
3448         help.
3449         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3450         from help.
3451         * language.c (add_set_language_command): Remove trailing newline
3452         from help.
3453         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3454         help.
3455         * disasm.c (_initialize_disasm): Remove trailing newline from
3456         help.
3457         * top.c (init_main): Remove trailing newline from help.
3458         * interps.c (_initialize_interpreter): Remove trailing newline
3459         from help.
3460         * btrace.c (_initialize_btrace): Remove trailing newlines from
3461         help.
3462         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3463         from help.
3464         * python/python.c (_initialize_python): Remove trailing newline
3465         from help.
3466         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3467         help.
3468         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3469         from help.  Reformat some text.
3470         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3471         from help.
3472         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3473         newline from help.
3474
3475 2019-06-11  Tom Tromey  <tromey@adacore.com>
3476
3477         * darwin-nat.c (darwin_decode_exception_message)
3478         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3479
3480 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * valops.c (value_slice): Check for not allocated or not
3483         associated values.
3484
3485 2019-06-10  Tom de Vries  <tdevries@suse.de>
3486
3487         PR gdb/24618
3488         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3489         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3490         invalid.
3491
3492 2019-06-10  Tom de Vries  <tdevries@suse.de>
3493
3494         PR gdb/24611
3495         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3496         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3497
3498 2019-06-10  Tom de Vries  <tdevries@suse.de>
3499
3500         PR symtab/24545
3501         * symtab.c (struct demangled_name_entry): Add language field.
3502         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3503         static minimal symbol".  Set and use language field.
3504
3505 2019-06-10  Tom Tromey  <tromey@adacore.com>
3506
3507         * ada-lang.c (_initialize_ada_language): Update help text.
3508
3509 2019-06-10  Tom Tromey  <tromey@adacore.com>
3510
3511         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3512         with a newline.
3513         * guile/guile.c (handle_boot_error): Don't end warning with a
3514         newline.
3515         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3516         warning with a newline.
3517         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3518         newline.
3519         (s12z_frame_cache): Likewise.
3520         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3521         a newline.
3522         * solib-svr4.c (disable_probes_interface): Don't end warning with
3523         a newline.
3524         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3525         newline.
3526         * python/python.c (do_finish_initialization): Don't end warning
3527         with a newline.
3528
3529 2019-06-10  Tom Tromey  <tom@tromey.com>
3530
3531         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3532         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3533         gdbpy_enter.
3534
3535 2019-06-10  Tom Tromey  <tromey@adacore.com>
3536
3537         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3538         data.
3539         (elf_new_init): Don't call stabsread_new_init.
3540         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3541         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3542         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3543
3544 2019-06-10  Tom de Vries  <tdevries@suse.de>
3545
3546         PR symtab/16264
3547         PR symtab/24517
3548         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3549
3550 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3551
3552         * source.c (find_and_open_source): Also rewrite relative file
3553         names.
3554
3555 2019-04-26  Amos Bird  <amosbird@gmail.com>
3556
3557         * annotate.c (annotate_thread_exited): Add "thread-exited"
3558         annotation.
3559
3560 2019-06-06  Tom Tromey  <tromey@adacore.com>
3561
3562         * maint.h (class scoped_command_stats): Use
3563         DISABLE_COPY_AND_ASSIGN.
3564         <print_time>: New method.
3565         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3566         print_time.
3567         (scoped_command_stats::print_time): New method.
3568
3569 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3570
3571         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3572         instructions of lengths 6 or 8 bytes.
3573
3574 2019-06-04  Pedro Alves  <palves@redhat.com>
3575
3576         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3577
3578         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3579         * breakpoint.c (condition_completer): Likewise.
3580         * cli/cli-dump.c (scan_expression): Likewise.
3581         * common/filestuff.c (mkdir_recursive): Likewise.
3582         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3583         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3584         (gdb_abspath): Likewise.
3585         * compile/compile-cplus-types.c
3586         (compile_cplus_instance::decl_name): Likewise.
3587         * completer.c (complete_explicit_location):
3588         (signal_completer, reg_or_group_completer_1): Likewise.
3589         * cp-support.c (cp_remove_params_if_any): Likewise.
3590         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3591         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3592         * infcmd.c (strip_bg_char): Likewise.
3593         * linespec.c (copy_token_string): Likewise.
3594         * mi/mi-main.c (output_cores): Likewise.
3595         * psymtab.c (psymtab_search_name):
3596         * symfile.c (test_set_ext_lang_command): Likewise.
3597         * target.c (target_fileio_read_stralloc): Likewise.
3598         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3599         * value.c (complete_internalvar): Likewise.
3600
3601 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3602
3603         Add objfile property to gdb.Type.
3604         * NEWS: Mention Python API addition.
3605         * python/py-type.c (typy_get_objfile): New method.
3606
3607 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3608
3609         * NEWS: Mention the new set|show style [title|highlight].
3610         Mention changes to "show style", "help" and "apropos".
3611
3612 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3613
3614         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3615         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3616         instead of print_help_for_command.
3617         (print_doc_of_command): New function.
3618         (help_list): Add 'apropos -v word' suggestion.
3619         (print_help_for_command): Style the command name using title style.
3620         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3621         (_initialize_cli_cmds): Describe -v in apropos_command help.
3622
3623 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3624
3625         * cli/cli-style.h (cli_style_option): Add name in constructor,
3626         add m_name class member, add constructor with intensity,
3627         add name class function.
3628         (cli_style_option::add_setshow_commands): Remove name argument.
3629         (highlight_style, title_style): New styles.
3630         * cli/cli-style.c (do_show): New function that shows a style
3631         characteristic styling the style name with itself.
3632         (set_style_name): New function.
3633         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3634         Update all callers according to the changes in cli/cli-style.h.
3635         * utils.h (fputs_highlighted): New function.
3636         * utils.c (fputs_highlighted): Likewise.
3637
3638 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3639
3640         * NEWS: Mention new pipe command and new convenience variables.
3641
3642 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3643
3644         * cli/cli-cmds.c (pipe_command): New function.
3645         (_initialize_cli_cmds): Call add_com for pipe_command.
3646         Define | as an alias for pipe.
3647         (exit_status_set_internal_vars): New function.
3648         (shell_escape): Call exit_status_set_internal_vars.
3649         cli/cli-decode.c (find_command_name_length): Recognize | as
3650         a single character command.
3651
3652 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3653
3654         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3655         top.c (execute_command_to_ui_file): New function, mostly a copy
3656         of execute_command_to_string.
3657         (execute_command_to_string): Implement by calling
3658         execute_command_to_ui_file.
3659
3660 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3661
3662         * top.h (saved_command_line): Remove declaration.
3663         * top.c (previous_saved_command_line, previous_repeat_arguments):
3664         New variables.
3665         (saved_command_line): Make static, define together with other
3666         'repeat variables'.
3667         (dont_repeat): Clear repeat_arguments.
3668         (repeat_previous, get_saved_command_line, save_command_line):
3669         New functions.
3670         (gdb_init): Initialize saved_command_line
3671         and previous_saved_command_line.
3672         * main.c (captured_main_1): Remove saved_command_line initialization.
3673         * event-top.c (handle_line_of_input): Update to use
3674         the new 'repeat' related functions instead of direct access to
3675         saved_command_line.
3676         * command.h (repeat_previous, get_saved_command_line,
3677         save_command_line): New declarations.
3678         (dont_repeat): Add comment.
3679
3680 2019-05-30  Tom Tromey  <tromey@adacore.com>
3681
3682         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3683         Fix comment.
3684         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3685
3686 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3687
3688         PR cli/24587
3689         * completer.c (complete): Initialize variable word.
3690
3691 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3692
3693         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3694         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3695         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3696         'body' is NULL to the outter 'if', protecting the '!is_define'
3697         situation as well.
3698
3699 2019-05-29  Tom Tromey  <tromey@adacore.com>
3700
3701         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3702         (dwarf_unknown): New function.
3703         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3704         (dwarf_type_encoding_name): Use dwarf_unknown.
3705
3706 2019-05-29  Tom Tromey  <tromey@adacore.com>
3707
3708         PR c++/20020:
3709         * cp-valprint.c (cp_print_value_fields): Call
3710         cp_print_static_field inside "try".
3711
3712 2019-05-29  Tom Tromey  <tromey@adacore.com>
3713
3714         * inflow.c (struct terminal_info): Add default operator=.
3715         * configure: Rebuild.
3716         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3717         -Wdeprecated-copy-dtor, -Wredundant-move.
3718
3719 2019-05-29  Tom Tromey  <tromey@adacore.com>
3720
3721         * NEWS: Add entry.
3722         * infcmd.c (print_return_value_1): Handle finish_print
3723         option.
3724         (show_print_finish): New function.
3725         (_initialize_infcmd): Add "set/show print finish" commands.
3726         * valprint.c (user_print_options): Initialize new member.
3727         * valprint.h (struct value_print_options) <finish_print>: New
3728         member.
3729
3730 2019-05-28  Tom Tromey  <tromey@adacore.com>
3731
3732         * ada-lang.c (ada_remove_Xbn_suffix)
3733         (find_old_style_renaming_symbol)
3734         (parse_old_style_renaming): Remove.
3735         (ada_find_renaming_symbol): Don't call
3736         find_old_style_renaming_symbol.
3737         (ada_is_renaming_symbol): Rename from
3738         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3739         bool.  Now static.
3740         (ada_read_var_value): Update and simplify.
3741         * ada-exp.y (write_var_or_type): Remove old code.
3742
3743 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3744
3745         * event-top.c: Remove include comment.
3746         * inflow.c (class scoped_ignore_sigttou): Move from here...
3747         * inflow.h (class scoped_ignore_sigttou): ...to here.
3748         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3749         * top.c:  Remove include comment.
3750
3751 2019-05-27  Tom Tromey  <tom@tromey.com>
3752
3753         * NEWS: Fix typo.
3754
3755 2019-05-22  Tom Tromey  <tromey@adacore.com>
3756
3757         * target.c (target_follow_exec): Constify parameter.
3758         * target-delegates.c: Rebuild.
3759         * remote.c (remote_target::follow_exec): Constify parameter.
3760         * infrun.c (follow_exec): Constify parameter.
3761         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3762         (target_follow_exec): Likewise.
3763
3764 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3765
3766         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3767         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3768
3769 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3770
3771         * NEWS: Add debugredirect and testsuite sections.
3772
3773 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3774
3775         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3776         target descriptions using exclusively floating point register name
3777         aliases.
3778
3779 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         PR gdb/18644:
3782         * f-lang.c (build_fortran_types): Handle the case where
3783         gdbarch_floatformat_for_type returns a nullptr.
3784
3785 2019-05-21  Tom de Vries  <tdevries@suse.de>
3786
3787         PR cli/24587
3788         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3789
3790 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         PR gdb/18644:
3793         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3794         16-byte floats.
3795         * i386-tdep.c (i386_floatformat_for_type): Use
3796         floatformats_ia64_quad for the 16-byte floating point component
3797         within a fortran 32-byte complex number.
3798
3799 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3802         delete default constructor.
3803         (find_partial_die): Update to return const struct.
3804         (partial_die_parent_scope): Move variable declaration into scope
3805         of its use and change its type to auto.
3806         (guess_partial_die_structure_name): Likewise.
3807         (partial_die_info::fixup): Likewise.
3808
3809 2019-05-17  Tom Tromey  <tromey@adacore.com>
3810
3811         * source.c (find_and_open_source): Remove cast.
3812
3813 2019-05-17  Tom Tromey  <tromey@adacore.com>
3814
3815         * annotate.c (annotate_source): Make "filename" const.
3816         * annotate.h (annotate_source): Use const.
3817
3818 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3819
3820         * disasm.c (set_disassembler_options): Send errors to stderr.
3821
3822 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3823
3824         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3825         (cli_interp_base::set_logging): Check debug_redirect.
3826         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3827         * cli/cli-logging.c (debug_redirect): Add static variable.
3828         (pop_output_files): Add default param.
3829         (handle_redirections): Print debug setting.
3830         (show_logging_command): Likewise.
3831         (_initialize_cli_logging): Add debugredirect command.
3832         * interps.c (current_interp_set_logging): Add debug_redirect
3833         parameter.
3834         * interps.h (set_logging): Add debug_redirect parameter.
3835         (current_interp_set_logging): Likewise.
3836         * mi/mi-common.h: Likewise.
3837         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3838
3839 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3840             Tom Tromey  <tromey@adacore.com>
3841
3842         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3843         directly.
3844         * cli/cli-interp.h (make_logging_output): Remove declaration.
3845         * cli/cli-logging.c (make_logging_output): Remove function.
3846         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3847         directly.
3848         * ui-file.c (tee_file::tee_file): Remove bools.
3849         (tee_file::~tee_file): Remove deletes.
3850         * ui-file.h (tee_file): Remove bools.
3851
3852 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3853
3854         * mi/mi-cmds.h (mi_cmd_complete): New function.
3855         * mi/mi-main.c (mi_cmd_complete): Likewise.
3856         * mi/mi-cmds.c: Define new MI command -complete.
3857         * NEWS: Mention new -complete command.
3858
3859 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3860
3861         * completer.h (complete): New function.
3862         * completer.c (complete): Likewise.
3863         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3864         function defined in completer.h.
3865
3866 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3867
3868         * MAINTAINERS (Write After Approval): Add myself.
3869
3870 2019-05-17  Tom de Vries  <tdevries@suse.de>
3871
3872         PR gdb/24094
3873         * dwarf2read.c (struct cu_partial_die_info): New struct.
3874         (find_partial_die): Return cu_partial_die_info.
3875         (partial_die_parent_scope, guess_partial_die_structure_name)
3876         (partial_die_info::fixup): Handle new return type of find_partial_die.
3877
3878 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3879
3880         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3881         "std::string", simplifying the algorithm.
3882
3883 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3884
3885         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3886         (stap_static_probe_ops::get_probes): Likewise.
3887
3888 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3889
3890         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3891         '-')" and "else if".
3892         (stap_parse_single_operand): Join checks for
3893         "gdbarch_stap_parse_special_token_p" and
3894         "gdbarch_stap_parse_special_token" in the same "if" statement.
3895         Invert check when verifying for operation on register
3896         displacement.
3897
3898 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3899
3900         * stap-probe.c (stap_get_opcode): Update comment.
3901         (stap_get_expected_argument_type): Likewise.
3902         (handle_stap_probe): Likewise.
3903
3904 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3905
3906         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3907         return type to 'bool'.  Adjust comment.  Use 'bool' when
3908         appropriate.
3909         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3910         * stap-probe.c (stap_parse_argument_1): Likewise.
3911         (stap_is_operator): Likewise.
3912         (stap_is_generic_prefix): Likewise.
3913         (stap_is_register_prefix): Likewise.
3914         (stap_is_register_indirection_prefix): Likewise.
3915         (stap_is_integer_prefix): Likewise.
3916         (stap_generic_check_suffix): Likewise.
3917         (stap_check_integer_suffix): Likewise.
3918         (stap_check_register_suffix): Likewise.
3919         (stap_check_register_indirection_suffix): Likewise.
3920         (stap_parse_register_operand): Likewise.
3921         (stap_parse_single_operand): Likewise.
3922         (stap_parse_argument_1): Likewise.
3923         (stap_probe::get_argument_count): Likewise.
3924         (stap_is_operator): Likewise.
3925
3926 2019-05-16  Tom Tromey  <tromey@adacore.com>
3927
3928         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3929         keyword to foreach.
3930
3931 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3932
3933         * linux-thread-db.c (try_thread_db_load_1): Change return type
3934         to bool.
3935         (try_thread_db_load): Likewise.
3936         (try_thread_db_load_from_pdir_1): Likewise.
3937         (try_thread_db_load_from_pdir): Likewise.
3938         (try_thread_db_load_from_sdir): Likewise.
3939         (try_thread_db_load_from_dir): Likewise.
3940         (thread_db_load_search): Likewise.
3941         (has_libpthread): Likewise.
3942         (thread_db_load): Likewise.
3943
3944 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3945
3946         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3947         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3948         NULL, and complain/return if that's the case.
3949
3950 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3951
3952         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3953         (advance, posn, abstract_read_memory): New functions.
3954         [struct mem_read_abstraction]: New struct.
3955         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3956
3957 2019-05-14  Tom Tromey  <tromey@adacore.com>
3958
3959         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3960         value is not lval_memory.
3961
3962 2019-05-14  Tom Tromey  <tromey@adacore.com>
3963
3964         * solib.c (info_sharedlibrary_command): Style the file name.
3965
3966 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3967
3968         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3969         (aarch64_vnv_type): Likewise.
3970         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3971         * common/tdesc.c: Likewise.
3972         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3973         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3974         * features/aarch64-fpu.xml: Add ieee half view.
3975         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3976         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3977         * gdbtypes.h (struct builtin_type): Likewise.
3978         (struct objfile_type): Likewise.
3979
3980 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3981
3982         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3983         typo.
3984         * location.h (string_to_event_location): Likewise.
3985
3986 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3987
3988         GDB 8.3 released.
3989
3990 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3991
3992         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3993         New variable declaration.
3994         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3995         New variable.
3996         (print_one_breakpoint): Use ui_out::test_flags and new global
3997         variable to compute use_fixed_output.
3998         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3999         Remove.
4000         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4001         (mi_multi_location_breakpoint_output_fixed): Remove.
4002         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4003         new variable.
4004         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4005         fix_multi_location_breakpoint_output flag if version >= 3.
4006         * ui-out.h (enum ui_out_flag)
4007         <fix_multi_location_breakpoint_output>: New enumerator.
4008
4009 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4010
4011         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4012
4013 2019-05-10  Tom Tromey  <tromey@adacore.com>
4014
4015         * ada-lang.c (catch_ada_completer): New function.
4016         (_initialize_ada_language): Use it.
4017
4018 2019-05-10  Tom Tromey  <tromey@adacore.com>
4019
4020         * thread.c (print_thread_info): Make "requested_threads" const.
4021         * gdbthread.h (print_thread_info): Make "requested_threads"
4022         const.
4023         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4024         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4025
4026 2019-05-08  Tom Tromey  <tom@tromey.com>
4027
4028         * gdbtypes.c (objfile_type_data): Change type.
4029         (objfile_type, _initialize_gdbtypes): Update.
4030
4031 2019-05-08  Tom Tromey  <tom@tromey.com>
4032
4033         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4034         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4035         (_initialize_dwarf2_frame): Update.
4036
4037 2019-05-08  Tom Tromey  <tom@tromey.com>
4038
4039         * objc-lang.c (objc_objfile_data): Change type.
4040         (find_methods): Update.
4041         (_initialize_objc_lang): Remove.
4042
4043 2019-05-08  Tom Tromey  <tom@tromey.com>
4044
4045         * stabsread.c (rs6000_builtin_type_data): Change type.
4046         (rs6000_builtin_type, _initialize_stabsread): Update.
4047
4048 2019-05-08  Tom Tromey  <tom@tromey.com>
4049
4050         * mips-tdep.c (mips_pdr_data): Remove.
4051         (_initialize_mips_tdep): Update.
4052
4053 2019-05-08  Tom Tromey  <tom@tromey.com>
4054
4055         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4056         (hppa_init_objfile_priv_data, read_unwind_info)
4057         (find_unwind_entry, _initialize_hppa_tdep): Update.
4058
4059 2019-05-08  Tom Tromey  <tom@tromey.com>
4060
4061         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4062         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4063         on obstack.
4064         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4065
4066 2019-05-08  Tom Tromey  <tom@tromey.com>
4067
4068         * mdebugread.c (basic_type_data): Change type.
4069         (basic_type, _initialize_mdebugread): Update.
4070
4071 2019-05-08  Tom Tromey  <tom@tromey.com>
4072
4073         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * nto-tdep.c (nto_inferior_data_reg): Change type.
4078         (nto_inferior_data): Update.
4079         (nto_inferior_data_cleanup, nto_new_inferior_data)
4080         (_initialize_nto_tdep): Remove.
4081         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4082
4083 2019-05-08  Tom Tromey  <tom@tromey.com>
4084
4085         * ada-lang.c (struct ada_inferior_data): Add initializers.
4086         (ada_inferior_data): Change type.
4087         (ada_inferior_data_cleanup): Remove.
4088         (get_ada_inferior_data, ada_inferior_exit)
4089         (struct ada_pspace_data): Add initializers, destructor.
4090         (ada_pspace_data_handle): Change type.
4091         (get_ada_pspace_data): Update.
4092         (ada_pspace_data_cleanup): Remove.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * coffread.c (struct coff_symfile_info): Add initializers.
4097         (coff_objfile_data_key): Move lower.  Change type.
4098         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4099         Update.
4100         (coff_free_info): Remove.
4101
4102 2019-05-08  Tom Tromey  <tom@tromey.com>
4103
4104         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4105         (fbsd_pspace_data_handle): Move lower.  Change type.
4106         (get_fbsd_pspace_data): Update.
4107         (fbsd_pspace_data_cleanup): Remove.
4108         (_initialize_fbsd_tdep): Update.
4109
4110 2019-05-08  Tom Tromey  <tom@tromey.com>
4111
4112         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4113         (get_ada_tasks_pspace_data): Update.
4114         (ada_tasks_pspace_data_cleanup): Remove.
4115         (_initialize_tasks): Update.
4116         (ada_tasks_inferior_data_handle): Change type.
4117         (get_ada_tasks_inferior_data): Update.
4118         (ada_tasks_inferior_data_cleanup): Remove.
4119         (struct ada_tasks_pspace_data): Add initializers.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4124         * symfile-debug.c (debug_sym_get_probes): Change type.
4125         * stap-probe.c (handle_stap_probe):
4126         (stap_static_probe_ops::get_probes): Change type.
4127         * probe.h (class static_probe_ops) <get_probes>: Change type.
4128         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4129         (parse_probes_in_pspace): Update.
4130         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4131         Update.
4132         (any_static_probe_ops::get_probes): Change type.
4133         * elfread.c (elfread_data): New typedef.
4134         (probe_key): Change type.
4135         (elf_get_probes): Likewise.  Update.
4136         (probe_key_free): Remove.
4137         (_initialize_elfread): Update.
4138         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4139         Change type.
4140         (dtrace_process_dof_probe, dtrace_process_dof)
4141         (dtrace_static_probe_ops::get_probe): Change type.
4142
4143 2019-05-08  Tom Tromey  <tom@tromey.com>
4144
4145         * xcoffread.c (struct xcoff_symfile_info): Rename from
4146         coff_symfile_info.  Add initializers.
4147         (xcoff_objfile_data_key): Move lower.  Change type.
4148         (XCOFF_DATA): Rewrite.
4149         (xcoff_free_info): Remove.
4150         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4151         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4152         (xcoff_initial_scan): Update.
4153
4154 2019-05-08  Tom Tromey  <tom@tromey.com>
4155
4156         * solib-svr4.c (struct svr4_info): Add initializers and
4157         destructor.
4158         <probes_table>: Now an htab_up.
4159         (solib_svr4_pspace_data): Change type.
4160         (free_probes_table): Simplify.
4161         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4162         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4163         (probes_table_remove_objfile_probes, register_solib_event_probe)
4164         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4165         (_initialize_svr4_solib): Update.
4166
4167 2019-05-08  Tom Tromey  <tom@tromey.com>
4168
4169         * remote.c (remote_pspace_data): Change type.
4170         (remote_pspace_data_cleanup): Remove.
4171         (get_remote_exec_file, set_pspace_remote_exec_file)
4172         (_initialize_remote): Update.
4173
4174 2019-05-08  Tom Tromey  <tom@tromey.com>
4175
4176         * breakpoint.c (breakpoint_objfile_key): Change type.
4177         (get_breakpoint_objfile_data): Update.
4178         (free_breakpoint_objfile_data): Remove.
4179         (_initialize_breakpoint): Update.
4180
4181 2019-05-08  Tom Tromey  <tom@tromey.com>
4182
4183         * linux-tdep.c (struct linux_info): Add initializers.
4184         (linux_inferior_data): Move.  Change type.
4185         (invalidate_linux_cache_inf): Update.
4186         (linux_inferior_data_cleanup): Remove.
4187         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4188
4189 2019-05-08  Tom Tromey  <tom@tromey.com>
4190
4191         * auxv.c (auxv_inferior_data): Move.  Change type.
4192         (auxv_inferior_data_cleanup): Remove.
4193         (invalidate_auxv_cache_inf): Rewrite.
4194         (get_auxv_inferior_data, _initialize_auxv): Update.
4195
4196 2019-05-08  Tom Tromey  <tom@tromey.com>
4197
4198         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4199         (symfile_debug_objfile_data_key): Change type.
4200         (symfile_debug_installed, debug_qf_has_symbols)
4201         (debug_qf_find_last_source_symtab)
4202         (debug_qf_forget_cached_source_info)
4203         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4204         (debug_qf_print_stats, debug_qf_dump)
4205         (debug_qf_expand_symtabs_for_function)
4206         (debug_qf_expand_all_symtabs)
4207         (debug_qf_expand_symtabs_with_fullname)
4208         (debug_qf_map_matching_symbols)
4209         (debug_qf_expand_symtabs_matching)
4210         (debug_qf_find_pc_sect_compunit_symtab)
4211         (debug_qf_map_symbol_filenames)
4212         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4213         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4214         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4215         (debug_sym_read_linetable, debug_sym_relocate): Update.
4216         (symfile_debug_free_objfile): Remove.
4217         (install_symfile_debug_logging, _initialize_symfile_debug):
4218         Update.
4219
4220 2019-05-08  Tom Tromey  <tom@tromey.com>
4221
4222         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4223         allocate_on_obstack.
4224         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4225         (get_dwarf2_per_objfile): Update.
4226         (set_dwarf2_per_objfile): Remove.
4227         (dwarf2_has_info, dwarf2_get_section_info): Update.
4228         (dwarf2_free_objfile): Remove.
4229         (_initialize_dwarf2_read): Update.
4230
4231 2019-05-08  Tom Tromey  <tom@tromey.com>
4232
4233         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4234         initializers.
4235         <unsupported_script_warning_printed,
4236         script_not_found_warning_printed>: Now bool.
4237         (auto_load_pspace_data): Change type.
4238         (~auto_load_pspace_info): Rename from
4239         auto_load_pspace_data_cleanup.
4240         (get_auto_load_pspace_data, init_loaded_scripts_info)
4241         (clear_section_scripts, maybe_print_unsupported_script_warning)
4242         (maybe_print_script_not_found_warning, _initialize_auto_load):
4243         Update.
4244
4245 2019-05-08  Tom Tromey  <tom@tromey.com>
4246
4247         * objfiles.c (objfile_pspace_info): Add destructor and
4248         initializers.
4249         (objfiles_pspace_data): Change type.
4250         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4251         (get_objfile_pspace_data): Update.
4252         (objfiles_bfd_data): Change type.
4253         (get_objfile_bfd_data): Update.
4254         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4255
4256 2019-05-08  Tom Tromey  <tom@tromey.com>
4257
4258         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4259         Change type.
4260         (get_catch_syscall_inferior_data): Update.
4261         (catch_syscall_inferior_data_cleanup): Remove.
4262         (_initialize_break_catch_syscall): Update.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * inflow.c (struct terminal_info): Add destructor and
4267         initializers.
4268         (inflow_inferior_data): Change type.
4269         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4270         (get_inflow_inferior_data, inflow_inferior_exit)
4271         (swap_terminal_info, _initialize_inflow): Update.
4272
4273 2019-05-08  Tom Tromey  <tom@tromey.com>
4274
4275         * target-dcache.c (target_dcache_cleanup): Remove.
4276         (target_dcache_aspace_key): Change type.
4277         (target_dcache_init_p, target_dcache_invalidate)
4278         (target_dcache_get, target_dcache_get_or_init)
4279         (_initialize_target_dcache): Update.
4280         * dcache.h (struct dcache_deleter): New.
4281
4282 2019-05-08  Tom Tromey  <tom@tromey.com>
4283
4284         * symtab.c (struct symbol_cache): Add destructor and
4285         initializers.
4286         (symbol_cache_key): Move.  Change type.
4287         (make_symbol_cache, free_symbol_cache): Remove.
4288         (get_symbol_cache): Update.
4289         (symbol_cache_cleanup): Remove.
4290         (ALL_PSPACES, symbol_cache_flush)
4291         (maintenance_print_symbol_cache)
4292         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4293         Update.
4294
4295 2019-05-08  Tom Tromey  <tom@tromey.com>
4296
4297         * symtab.c (struct main_info): Add destructor and initializers.
4298         (main_progspace_key): Move.  Change type.
4299         (get_main_info): Update.
4300         (main_info_cleanup): Remove.
4301         (_initialize_symtab): Update.
4302
4303 2019-05-08  Tom Tromey  <tom@tromey.com>
4304
4305         * registry.h (DECLARE_REGISTRY): Define the _key class.
4306
4307 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4308
4309         * NEWS: Merge two 'New commands' sections.
4310
4311 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4312
4313         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4314         parameter and use Ada language definition instead.
4315         (ada_val_print_ptr): Remove unused language parameter.
4316         (ada_val_print_num): Remove language parameter and use Ada language
4317         definition instead.
4318         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4319         parameter.
4320         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4321         parameter and use Ada language definition instead.
4322         (ada_val_print_1): Update all ada_val_print_xxx calls.
4323         Remove language parameter.
4324         (ada_val_print): Update ada_val_print_1 call.
4325
4326 2019-05-08  Tom Tromey  <tromey@adacore.com>
4327
4328         * remote.c (remote_hw_watchpoint_limit)
4329         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4330         Now static.
4331
4332 2019-05-08  Tom Tromey  <tromey@adacore.com>
4333
4334         * maint.c (_initialize_maint_cmds): Move initialization code to
4335         remote.c.
4336         (watchdog, show_watchdog): Move to remote.c.
4337         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4338         "watchdog" static.
4339         (_initialize_remote): Move initialization code from maint.c.
4340         * defs.h (watchdog): Don't declare.
4341
4342 2019-05-08  Tom Tromey  <tromey@adacore.com>
4343
4344         * tui/tui-interp.c: Include main.h.
4345         * interps.c: Include main.h.
4346         * main.h (interpreter_p): Declare.
4347         * defs.h (interpreter_p): Don't declare.
4348
4349 2019-05-08  Tom Tromey  <tromey@adacore.com>
4350
4351         * dwarf2loc.c: Include dwarf2read.h.
4352         * defs.h (read_unsigned_leb128): Don't declare.
4353         * dwarf2read.h (read_unsigned_leb128): Declare.
4354
4355 2019-05-08  Tom Tromey  <tromey@adacore.com>
4356
4357         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4358         method.
4359
4360 2019-05-08  Tom Tromey  <tromey@adacore.com>
4361
4362         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4363         when no wrap column is set.
4364
4365 2019-05-08  Tom Tromey  <tromey@adacore.com>
4366
4367         * c-lang.c (c_get_string): Handle non-C-style arrays.
4368
4369 2019-05-08  Tom Tromey  <tromey@adacore.com>
4370
4371         * typeprint.c (print_offset_data::update): Print the bit offset,
4372         not the number of bits remaining.
4373
4374 2019-05-08  Tom Tromey  <tromey@adacore.com>
4375
4376         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4377         padding at end of comment.
4378
4379 2019-05-08  Tom Tromey  <tromey@adacore.com>
4380
4381         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4382         Compare main types.
4383
4384 2019-05-06  Tom Tromey  <tom@tromey.com>
4385
4386         * common/scoped_mmap.c: Include common-defs.h.
4387         * common/scoped_mmap.h: Don't include config.h.
4388
4389 2019-05-04  Tom Tromey  <tom@tromey.com>
4390
4391         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4392         (struct aarch64_call_info): Add initializers.
4393         <si>: Now a std::vector.
4394         (pass_on_stack, aarch64_push_dummy_call): Update.
4395
4396 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4397             Tom Tromey  <tom@tromey.com>
4398
4399         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4400         (ppc_threads): Now a std::vector.  Now static.
4401         (hwdebug_find_thread_points_by_tid)
4402         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4403         Update.
4404
4405 2019-05-04  Tom Tromey  <tom@tromey.com>
4406
4407         * arc-tdep.c (arc_tdesc_init): Return bool.
4408
4409 2019-05-04  Tom Tromey  <tom@tromey.com>
4410
4411         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4412         Use gdb_assert_not_reached.
4413
4414 2019-05-04  Tom Tromey  <tom@tromey.com>
4415
4416         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4417         "false".
4418
4419 2019-05-04  Tom Tromey  <tom@tromey.com>
4420
4421         * arc-tdep.c (arc_tdesc_init): Use bool.
4422
4423 2019-05-04  Tom Tromey  <tom@tromey.com>
4424
4425         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4426
4427 2019-05-04  Tom Tromey  <tom@tromey.com>
4428
4429         * cli/cli-cmds.c (valid_command_p): Return bool.
4430
4431 2019-05-04  Tom Tromey  <tom@tromey.com>
4432
4433         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4434         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4435
4436 2019-05-04  Raul Tambre  <raul@tambre.ee>
4437
4438         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4439         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4440         operator for comparison.
4441
4442 2019-05-04  Tom Tromey  <tom@tromey.com>
4443
4444         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4445         (lookup_partial_symbol, print_partial_symbols)
4446         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4447         (psymbol_compare): Update.
4448         (add_psymbol_to_bcache): Clear the entire psymbol.
4449         (maintenance_check_psymtabs): Update.
4450         * psympriv.h (struct partial_symbol): Don't derive from
4451         general_symbol_info.
4452         <obj_section, unrelocated_address, address,
4453         set_unrelocated_address>: Update.
4454         <ginfo>: New member.
4455         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4456         (debug_names::write_psymbols): Update.
4457
4458 2019-05-04  Tom de Vries  <tdevries@suse.de>
4459
4460         * contrib/cc-with-tweaks.sh: Support -n arg.
4461
4462 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4463
4464         * corelow.c (core_target::detach): Ensure frame cache and
4465         register caches are cleared.
4466         inferior.c (exit_inferior_1): Likewise.
4467
4468 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4469             Tom Tromey  <tom@tromey.com>
4470
4471         * dictionary.c (collate_pending_symbols_by_language): Remove
4472         "struct" from foreach.
4473         * symtab.c (lookup_global_symbol_from_objfile)
4474         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4475         foreach.
4476         * ser-tcp.c (net_open): Remove "struct" from foreach.
4477         * objfiles.c (objfile_relocate, objfile_rebase)
4478         (objfile_has_symbols): Remove "struct" from foreach.
4479         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4480         from foreach.
4481         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4482         foreach.
4483         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4484         "struct" from foreach.
4485         * ada-lang.c (create_excep_cond_exprs)
4486         (ada_exception_catchpoint_cond_string): Remove "struct" from
4487         foreach.
4488
4489 2019-05-03  Tom Tromey  <tromey@adacore.com>
4490
4491         * ada-exp.y (convert_char_literal): Check suffix of each
4492         enumerator.
4493
4494 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4495
4496         PR ada/21406:
4497         * ada-exp.y (yywrap): Don't define.
4498         * ada-lex.l (%option): Add noyywrap
4499         (yywrap): Remove.
4500
4501 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4502
4503         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4504         _WIN32_WINNT to the XP level, unless already defined to a higher
4505         level.
4506
4507         * unittests/parse-connection-spec-selftests.c:
4508         * ser-tcp.c:
4509         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4510         override.
4511
4512         * symfile.c (find_separate_debug_file): Remove colon from the
4513         drive spec of DOS/Windows file names of the target, so that the
4514         file name produced from DEBUGDIR and the target's directory will
4515         be valid on DOS/Windows systems.
4516
4517 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * rust-lang.c (val_print_struct): Handle printing structures
4520         containing strings.
4521
4522 2019-05-02  Tom Tromey  <tromey@adacore.com>
4523
4524         * valarith.c (_initialize_valarith): Remove.
4525
4526 2019-05-01  Tom Tromey  <tromey@adacore.com>
4527
4528         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4529         bitfields.
4530
4531 2019-05-01  Tom Tromey  <tromey@adacore.com>
4532
4533         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4534         for big-endian copies.
4535
4536 2019-04-30  Ali Tamur  <tamur@google.com>
4537         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4538         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4539         (read_3_bytes): New function.
4540
4541 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4542
4543         * windows-nat.c (main_thread_id): Delete.
4544         (handle_output_debug_string): Replace main_thread_id by
4545         current_event.dwThreadId.
4546         (fake_create_process): Likewise.
4547         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4548         Do not set main_thread_id.
4549         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4550         current_event.dwThreadId.
4551         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4552
4553 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4554
4555         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4556         Use current_event.dwThreadId instead of main_thread_id.
4557
4558 2019-04-30  Tom Tromey  <tromey@adacore.com>
4559
4560         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4561         (create_excep_cond_exprs): Iterate over program spaces.
4562         (ada_exception_catchpoint_cond_string): Examine all minimal
4563         symbols for exception types.
4564
4565 2019-04-30  Tom Tromey  <tromey@adacore.com>
4566
4567         PR c++/24470:
4568         * dwarf2read.c (process_structure_scope): Handle case where type
4569         has template parameters but no symbol was created.
4570
4571 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4572             Chris January  <chris.january@arm.com>
4573
4574         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4575         qualifier.
4576         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4577
4578 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * f-typeprint.c (f_print_type): Update rules for printing
4581         whitespace.
4582         (f_type_print_varspec_suffix): Likewise.
4583
4584 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4585             Chris January  <chris.january@arm.com>
4586
4587         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4588         function arguments.
4589
4590 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * f-lang.c (build_fortran_types): Change name of void type to
4593         lower case.
4594         * f-typeprint.c (f_type_print_base): Print the name of the void
4595         type, rather than a fixed string.
4596         * f-valprint.c (f_decorations): Use lower case void string.
4597
4598 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4599             Chris January  <chris.january@arm.com>
4600
4601         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4602         types for Fortran.
4603
4604 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4605             Chris January  <chris.january@arm.com>
4606             David Lecomber  <david.lecomber@arm.com>
4607
4608         * f-exp.y (BINOP_INTRINSIC): New token.
4609         (exp): New parser rule handling BINOP_INTRINSIC.
4610         (f77_keywords): Add new builtin procedures.
4611         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4612         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4613         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4614         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4615         (print_unop_subexp_f): New function.
4616         (print_binop_subexp_f): New function.
4617         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4618         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4619         (dump_subexp_body_f): Likewise.
4620         (operator_check_f): Likewise.
4621         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4622         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4623
4624 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4627         UNOP_KIND.
4628         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4629         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4630         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4631         (operator_length_f): New fuction.
4632         (print_subexp_f): New function.
4633         (op_name_f): New function.
4634         (dump_subexp_body_f): New function.
4635         (operator_check_f): New function.
4636         (exp_descriptor_f): Replace standard expression handling functions
4637         with new functions.
4638         * gdb/fortran-operator.def: New file.
4639         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4640         * gdb/std-operator.def: Remove UNOP_KIND.
4641
4642 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4643
4644         * std-operator.def: Remove unbalanced, stray double quote
4645         character.
4646
4647 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4648             Chris January  <chris.january@arm.com>
4649             Daniel Everett  <daniel.everett@arm.com>
4650             Nick Forrington  <nick.forrington@arm.com>
4651             Richard Bunt  <richard.bunt@arm.com>
4652
4653         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4654         of depth when printing anonymous structs or unions.
4655         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4656         Don't print either the top-level value, or the children if the
4657         max-depth is exceeded.
4658         (ppscm_print_children): When printing the key of a map, allow one
4659         extra level of depth.
4660         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4661         print either the top-level value, or the children if the max-depth
4662         is exceeded.
4663         (print_children): When printing the key of a map, allow one extra
4664         level of depth.
4665         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4666         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4667         (user_print_options): Initialise max_depth field.
4668         (val_print_scalar_or_string_type_p): New function.
4669         (val_print): Check to see if the max depth has been reached.
4670         (val_print_check_max_depth): Define new function.
4671         (show_print_max_depth): New function.
4672         (_initialize_valprint): Add 'print max-depth' option.
4673         * valprint.h (struct value_print_options) <max_depth>: New field.
4674         (val_print_check_max_depth): Declare new function.
4675         * NEWS: Document new feature.
4676
4677 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * ada-lang.c (ada_language_defn): Initialise new field.
4680         * c-lang.c (c_is_string_type_p): New function.
4681         (c_language_defn): Initialise new field.
4682         (cplus_language_defn): Initialise new field.
4683         (asm_language_defn): Initialise new field.
4684         (minimal_language_defn): Initialise new field.
4685         * c-lang.h (c_is_string_type_p): Declare new function.
4686         * d-lang.c (d_language_defn): Initialise new field.
4687         * f-lang.c (f_is_string_type_p): New function.
4688         (f_language_defn): Initialise new field.
4689         * go-lang.c (go_is_string_type_p): New function.
4690         (go_language_defn): Initialise new field.
4691         * language.c (default_is_string_type_p): New function.
4692         (unknown_language_defn): Initialise new field.
4693         (auto_language_defn): Initialise new field.
4694         * language.h (struct language_defn) <la_is_string_type_p>: New
4695         member variable.
4696         (default_is_string_type_p): Declare new function.
4697         * m2-lang.c (m2_language_defn): Initialise new field.
4698         * objc-lang.c (objc_language_defn): Initialise new field.
4699         * opencl-lang.c (opencl_language_defn): Initialise new field.
4700         * p-lang.c (pascal_is_string_type_p): New function.
4701         (pascal_language_defn): Initialise new field.
4702         * rust-lang.c (rust_is_string_type_p): New function.
4703         (rust_language_defn): Initialise new field.
4704
4705 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4708         New field.
4709         * ada-lang.c (ada_language_defn): Initialise new field.
4710         * c-lang.c (c_language_defn): Likewise.
4711         (cplus_language_defn): Likewise.
4712         (asm_language_defn): Likewise.
4713         (minimal_language_defn): Likewise.
4714         * d-lang.c (d_language_defn): Likewise.
4715         * f-lang.c (f_language_defn): Likewise.
4716         * go-lang.c (go_language_defn): Likewise.
4717         * language.c (unknown_language_defn): Likewise.
4718         (auto_language_defn): Likewise.
4719         * m2-lang.c (m2_language_defn): Likewise.
4720         * objc-lang.c (objc_language_defn): Likewise.
4721         * opencl-lang.c (opencl_language_defn): Likewise.
4722         * p-lang.c (pascal_language_defn): Likewise.
4723         * rust-lang.c (rust_language_defn): Likewise.
4724
4725 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * ada-lang.c (ada_is_character_type): Change return type to bool.
4728         (ada_is_string_type): Likewise.
4729         * ada-lang.h (ada_is_character_type): Update declaration
4730         (ada_is_string_type): Likewise.
4731
4732 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4733
4734         Support style in 'frame|thread apply'
4735
4736         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4737         * record.c (record_start, record_stop): Update callers of
4738         execute_command_to_string with false.
4739         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4740         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4741         methods.
4742         (class string_file): New constructor with term_out parameter.
4743         Override methods term_out and can_emit_style_escape.  New member
4744         term_out.
4745         (class stdio_file): Override can_emit_style_escape.
4746         (class tee_file): Override term_out and can_emit_style_escape.
4747         * utils.h (can_emit_style_escape): Remove.
4748         * utils.c (can_emit_style_escape): Likewise.
4749         Update all callers of can_emit_style_escape (SOMESTREAM) to
4750         SOMESTREAM->can_emit_style_escape.
4751         * source-cache.c (source_cache::get_source_lines): Likewise.
4752         * stack.c (frame_apply_command_count): Call execute_command_to_string
4753         passing the term_out characteristic of the current gdb_stdout.
4754         * thread.c (thr_try_catch_cmd): Likewise.
4755         * top.c (execute_command_to_string): pass term_out parameter
4756         to construct the string_file for the command output.
4757         * ui-file.c (term_cli_styling): New function (most code moved
4758         from utils.c can_emit_style_escape).
4759         (string_file::string_file, string_file::can_emit_style_escape,
4760         stdio_file::can_emit_style_escape, tee_file::term_out,
4761         tee_file::can_emit_style_escape): New functions.
4762
4763 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4764
4765         * NEWS: Mention the new set|show may-call-functions.
4766         * infcall.c (may_call_functions_p): New variable.
4767         (show_may_call_functions_p): New function.
4768         (call_function_by_hand_dummy): Throws an error if not
4769         may-call-functions.
4770         (_initialize_infcall): Call add_setshow_boolean_cmd for
4771         may-call-functions.
4772
4773 2019-04-25  Keith Seitz  <keiths@redhat.com>
4774
4775         PR c++/24367
4776         * cp-support.c (inspect_type): Don't attempt substitutions
4777         of symbol with the same name.
4778
4779 2019-04-25  Tom Tromey  <tromey@adacore.com>
4780
4781         PR gdb/24475:
4782         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4783         static.
4784
4785 2019-04-25  Tom Tromey  <tromey@adacore.com>
4786
4787         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4788         rvalue reference.
4789         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4790         (gdb_xml_parser::parse): Use std::move.
4791         * python/python-internal.h (gdbpy_convert_exception): Take a const
4792         reference.
4793         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4794         std::move.
4795         * python/py-utils.c (gdbpy_convert_exception): Take a const
4796         reference.
4797         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4798         Use std::move.
4799         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4800         Use std::move.
4801         * mi/mi-main.c (mi_print_exception): Take a const reference.
4802         * main.c (handle_command_errors): Take a const reference.
4803         * linespec.c (parse_linespec): Use std::move.
4804         * infcall.c (run_inferior_call): Use std::move.
4805         (call_function_by_hand_dummy): Use std::move.
4806         * exec.c (try_open_exec_file): Use std::move.
4807         * exceptions.h (exception_print, exception_fprintf)
4808         (exception_print_same): Update.
4809         * exceptions.c (print_exception, exception_print)
4810         (exception_fprintf, exception_print_same): Change parameters to
4811         const reference.
4812         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4813         * common/new-op.c: Use std::move.
4814         * common/common-exceptions.h (struct gdb_exception): Add move
4815         constructor.
4816         (struct gdb_exception_error, struct gdb_exception_quit, struct
4817         gdb_quit_bad_alloc): Change constructor to move constructor.
4818         (throw_exception): Change parameter to rvalue reference.
4819         * common/common-exceptions.c (throw_exception): Take rvalue
4820         reference.
4821         * cli/cli-interp.c (safe_execute_command): Use std::move.
4822         * breakpoint.c (insert_bp_location, location_to_sals): Use
4823         std::move.
4824
4825 2019-04-25  Tom Tromey  <tromey@adacore.com>
4826
4827         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4828         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4829         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4830         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4831         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4832         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4833         guile/scm-value.c: Use unpack.
4834         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4835         gdbscm_gdb_exception.
4836         (gdbscm_throw_gdb_exception): Likewise.
4837         (struct gdbscm_gdb_exception): New.
4838         (unpack): New function.
4839         (gdbscm_wrap): Use unpack.
4840
4841 2019-04-25  Tom Tromey  <tromey@adacore.com>
4842
4843         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4844         (gdb_rl_callback_handler): Use std::move.
4845         * common/common-exceptions.h (struct gdb_exception): Add move
4846         assignment operator.
4847         (throw_exception_sjlj): Change "exception" to const reference.
4848         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4849         (throw_exception_sjlj): Change "exception" to const reference.
4850
4851 2019-04-25  Tom Tromey  <tromey@adacore.com>
4852
4853         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4854         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4855         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4856         Update.
4857         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4858         Update.
4859         * mi/mi-interp.c (mi_interp::exec): Update.
4860         * linespec.c (parse_linespec): Update.
4861         * infcall.c (run_inferior_call): Update.
4862         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4863         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4864         (gdbscm_lookup_global_symbol): Update.
4865         * guile/scm-param.c (gdbscm_parameter_value): Update.
4866         * guile/scm-frame.c (gdbscm_frame_read_register)
4867         (gdbscm_frame_read_var): Update.
4868         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4869         * exec.c (try_open_exec_file): Update.
4870         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4871         (gdb_rl_callback_handler): Update.
4872         * common/common-exceptions.h (exception_none): Don't declare.
4873         * common/common-exceptions.c (exception_none): Don't define.
4874         (struct catcher) <exception>: Update.
4875         * cli/cli-interp.c (safe_execute_command): Update.
4876         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4877
4878 2019-04-25  Ali Tamur  <tamur@google.com>
4879
4880         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4881         (read_attribute_value): Likewise.
4882         (dwarf2_read_addr_index): Update comment.
4883         (read_str_index): Add DW_FORM_strx.
4884         (dwarf2_string_attr): Likewise.
4885         (dwarf2_const_value_attr): Likewise.
4886         (dump_die_shallow): Likewise.
4887         (dwarf2_fetch_constant_bytes): Likewise.
4888         (skip_form_bytes): Likewise.
4889         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4890
4891 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4892
4893         PR corefiles/11608
4894         PR corefiles/18187
4895         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4896         OFFSET.  Verify if current mapping contains an ELF header.
4897         (linux_find_memory_regions_full): Adjust call to
4898         dump_mapping_p.
4899
4900 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4901             Kang Li <kanglictf@gmail.com>
4902
4903         PR gdb/21600
4904
4905         * dwarf2-frame.c (read_initial_length): Be consistent about using
4906         unsigned representation of length.
4907         (decode_frame_entry_1): Likewise.  Check for wraparound of
4908         end pointer as well as buffer overflow.
4909
4910 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4911
4912         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4913         "vq".
4914
4915 2019-04-24  Tom Tromey  <tromey@adacore.com>
4916
4917         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4918
4919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * s12z-tdep.c (s12z_unwind_pc): Delete.
4922         (s12z_unwind_sp): Delete.
4923         (s12z_gdbarch_init): Don't register deleted functions with
4924         gdbarch.
4925
4926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * rl78-tdep.c (rl78_unwind_sp): Delete.
4929         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4930
4931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4934         (xstormy16_unwind_pc): Delete.
4935         (xstormy16_dummy_id): Delete.
4936         (xstormy16_gdbarch_init): Don't register deleted functions with
4937         gdbarch.
4938
4939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * vax-tdep.c (vax_unwind_pc): Delete.
4942         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4943
4944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * v850-tdep.c (v850_unwind_sp): Delete.
4947         (v850_unwind_pc): Delete.
4948         (v850_dummy_id): Delete.
4949         (v850_gdbarch_init): Don't register deleted functions with
4950         gdbarch.
4951
4952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4955         (tilegx_unwind_pc): Delete.
4956         (tilegx_unwind_dummy_id): Delete.
4957         (tilegx_gdbarch_init): Don't register deleted functions with
4958         gdbarch.
4959
4960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4963         (tic6x_dummy_id): Delete.
4964         (tic6x_gdbarch_init): Don't register deleted functions with
4965         gdbarch.
4966
4967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * sparc-tdep.c (sparc_unwind_pc): Delete.
4970         (sparc32_gdbarch_init): Don't register deleted function with
4971         gdbarch.
4972
4973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * sh-tdep.c (sh_unwind_sp): Delete.
4976         (sh_unwind_pc): Delete.
4977         (sh_dummy_id): Delete.
4978         (sh_gdbarch_init): Don't register deleted functions with
4979         gdbarch.
4980
4981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * score-tdep.c (score_unwind_sp): Delete.
4984         (score_unwind_pc): Delete.
4985         (score_dummy_id): Delete.
4986         (score_gdbarch_init): Don't register deleted functions with
4987         gdbarch.
4988
4989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4990
4991         * rx-tdep.c (rx_unwind_pc): Delete.
4992         (rx_unwind_sp): Delete.
4993         (rx_dummy_id): Delete.
4994         (rx_gdbarch_init): Don't register deleted functions with
4995         gdbarch.  Update comment.
4996
4997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4998
4999         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5000         (rs6000_dummy_id): Delete.
5001         (rs6000_gdbarch_init): Don't register deleted functions with
5002         gdbarch.
5003
5004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * or1k-tdep.c (or1k_dummy_id): Delete.
5007         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5008
5009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5010
5011         * nios2-tdep.c (nios2_dummy_id): Delete.
5012         (nios2_unwind_sp): Delete.
5013         (nios2_gdbarch_init): Don't register deleted functions with
5014         gdbarch.
5015
5016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * nds32-tdep.c (nds32_dummy_id): Delete.
5019         (nds32_unwind_pc): Delete.
5020         (nds32_unwind_sp): Delete.
5021         (nds32_gdbarch_init): Don't register deleted functions with
5022         gdbarch.
5023
5024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * msp430-tdep.c (msp430_unwind_pc): Delete.
5027         (msp430_unwind_sp): Delete.
5028         (msp430_dummy_id): Delete.
5029         (msp430_gdbarch_init): Don't register deleted functions with
5030         gdbarch.
5031
5032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * moxie-tdep.c (moxie_unwind_sp): Delete.
5035         (moxie_unwind_pc): Delete.
5036         (moxie_dummy_id): Delete.
5037         (moxie_gdbarch_init): Don't register deleted functions with
5038         gdbarch.
5039
5040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5043         (mn10300_unwind_pc): Delete.
5044         (mn10300_unwind_sp): Delete.
5045         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5046         mn10300_unwind_sp.
5047         (mn10300_frame_unwind_init): Don't register deleted functions with
5048         gdbarch.
5049
5050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * mep-tdep.c (mep_unwind_pc): Delete.
5053         (mep_unwind_sp): Delete.
5054         (mep_dummy_id): Delete.
5055         (mep_gdbarch_init): Don't register deleted functions with
5056         gdbarch.
5057
5058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5061         (m68hc11_unwind_sp): Delete.
5062         (m68hc11_gdbarch_init): Don't register deleted functions with
5063         gdbarch.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * m32r-tdep.c (m32r_unwind_sp): Delete.
5068         (m32r_unwind_pc): Delete.
5069         (m32r_dummy_id): Delete.
5070         (m32r_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * m32c-tdep.c (m32c_unwind_pc): Delete.
5076         (m32c_unwind_sp): Delete.
5077         (m32c_dummy_id): Delete.
5078         (m32c_gdbarch_init): Don't register deleted functions with
5079         gdbarch.
5080
5081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5084         (lm32_unwind_pc): Delete.
5085         (lm32_dummy_id): Delete.
5086         (lm32_gdbarch_init): Don't register deleted functions with
5087         gdbarch.
5088
5089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5090
5091         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5092         (iq2000_unwind_pc): Delete.
5093         (iq2000_dummy_id): Delete.
5094         (iq2000_gdbarch_init): Don't register deleted functions with
5095         gdbarch.
5096
5097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * nds32-tdep.c (nds32_type_align): Delete.
5100         (nds32_push_dummy_call): Use type_align instead.
5101
5102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * arm-tdep.c (arm_type_align): Only handle vector override case.
5105         (arm_push_dummy_call): Use type_align.
5106         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5107
5108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5111         case.
5112         (pass_on_stack): Use type_align.
5113         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5114         function.
5115
5116 2019-04-23  Tom Tromey  <tromey@adacore.com>
5117
5118         * dwarf2read.c (line_header::file_name_at): Remove unused
5119         overload.
5120
5121 2019-04-23  Tom de Vries  <tdevries@suse.de>
5122
5123         PR gdb/24438
5124         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5125         invocation.
5126
5127
5128 2019-03-27  Ali Tamur  <tamur@google.com>
5129
5130         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5131         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5132         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5133         (dwarf_expr_context::get_addr_index): Likewise
5134         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5135         (symbol_needs_eval_context::get_addr_index): Likewise
5136         (disassemble_dwarf_expression): Add DW_OP_addrx
5137         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5138         (read_cutu_die_from_dwo): Update comment
5139         (skip_one_die): Add DW_FORM_addrx
5140         (read_attribute_value): Likewise
5141         (var_decode_location): Add DW_OP_addrx
5142         (dwarf2_const_value_attr): Add DW_FORM_addrx
5143         (dump_die_shallow): Likewise
5144         (dwarf2_fetch_constant_bytes): Likewise
5145         (decode_locdesc): Add DW_OP_addrx
5146         (skip_form_bytes): Add DW_FORM_addrx
5147
5148 2019-04-22  Ali Tamur  <tamur@google.com>
5149
5150         * MAINTAINERS (Write After Approval): Add self.
5151
5152 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5153
5154         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5155         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5156         (open_symbol_file_object): Likewise.
5157         (svr4_default_sos): Add info parameter.
5158         (svr4_read_so_list): Likewise.
5159         (svr4_current_sos_direct): Adjust functions calls to pass down
5160         info.
5161         (svr4_current_sos_1): Add info parameter.
5162         (svr4_current_sos): Call get_svr4_info, pass info down to
5163         svr4_current_sos_1.
5164         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5165         get_svr4_info.
5166         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5167         get_svr4_info.
5168         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5169         to get_svr4_info.
5170         (probes_table_remove_objfile_probes): Likewise.
5171         (register_solib_event_probe): Add info parameter.
5172         (solist_update_incremental): Pass info parameter down to
5173         svr4_read_so_list.
5174         (disable_probes_interface): Add info parameter.
5175         (svr4_handle_solib_event): Pass current_program_space to
5176         get_svr4_info.  Adjust disable_probes_interface cleanup.
5177         (svr4_create_probe_breakpoints): Add info parameter, pass it
5178         down to register_solib_event_probe.
5179         (svr4_create_solib_event_breakpoints): Add info parameter,
5180         pass it down to svr4_create_probe_breakpoints.
5181         (enable_break): Pass info down to
5182         svr4_create_solib_event_breakpoints.
5183         (svr4_solib_create_inferior_hook): Pass current_program_space to
5184         get_svr4_info.
5185         (svr4_clear_solib): Likewise.
5186
5187 2019-04-22  Pedro Alves  <palves@redhat.com>
5188
5189         * solib-svr4.c (svr4_free_objfile_observer): New.
5190         (probe_and_action::objfile): New field.
5191         (probes_table_htab_remove_objfile_probes)
5192         (probes_table_remove_objfile_probes): New functions.
5193         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5194         in the new probe_and_action.  Don't store the probe in 'lookup'.
5195         (svr4_create_probe_breakpoints): Pass objfile to
5196         register_solib_event_probe.
5197         (_initialize_svr4_solib): Register a free_objfile observer.
5198
5199 2019-04-19  Tom Tromey  <tom@tromey.com>
5200
5201         * common/queue.h: Remove.
5202
5203 2019-04-19  Tom Tromey  <tom@tromey.com>
5204
5205         * event-loop.c: Don't include "common/queue.h".
5206
5207 2019-04-19  Tom Tromey  <tom@tromey.com>
5208
5209         * remote.c (remote_target): Use delete.
5210         * remote-notif.h: Include <list>, not "common/queue.h".
5211         (notif_client_p): Remove typedef.
5212         (remote_notif_state): Add constructor, destructor, initializer.
5213         <notif_queue>: Now a std::list.
5214         (remote_notif_state_xfree): Don't declare.
5215         * remote-notif.c (remote_notif_process, handle_notification)
5216         (remote_notif_state_allocate): Update.
5217         (~remote_notif_state): Rename from remote_notif_state_xfree.
5218
5219 2019-04-19  Tom Tromey  <tom@tromey.com>
5220
5221         * symfile.c (reread_symbols): Update.
5222         * objfiles.c (objfile_register_static_link)
5223         (objfile_lookup_static_link): Update
5224         (~objfile) Don't delete static_links.
5225         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5226
5227 2019-04-19  Tom Tromey  <tom@tromey.com>
5228
5229         * type-stack.h (struct type_stack) <insert>: Constify string.
5230         * type-stack.c (type_stack::insert): Constify string.
5231         * gdbtypes.h (lookup_template_type): Update.
5232         (address_space_name_to_int): Update.
5233         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5234         const.
5235         (lookup_template_type): Make name const.
5236         * c-exp.y: Update rules.
5237         (lex_one_token, classify_name, classify_inner_name)
5238         (c_print_token): Update.
5239         * p-exp.y: Update rules.
5240         (yylex): Update.
5241         * f-exp.y: Update rules.
5242         (yylex): Update.
5243         * d-exp.y: Update rules.
5244         (lex_one_token, classify_name, classify_inner_name): Update.
5245         * parse.c (write_dollar_variable, copy_name): Return std::string.
5246         * parser-defs.h (copy_name): Change return type.
5247         * m2-exp.y: Update rules.
5248         (yylex): Update.
5249         * go-exp.y (lex_one_token): Update.
5250         Update rules.
5251         (classify_unsafe_function, classify_packaged_name)
5252         (classify_name, yylex): Update.
5253
5254 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5255
5256         * configure.ac: add --enable-source-highlight switch.
5257         * configure: Regenerate.
5258         * top.c (print_gdb_version): plumb --enable-source-highlight
5259         status to "show configuration".
5260
5261 2019-04-19  Tom Tromey  <tromey@adacore.com>
5262
5263         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5264         Check ADA_TYPE_P.
5265         (empty_record, ada_template_to_fixed_record_type_1)
5266         (template_to_static_fixed_type)
5267         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5268         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5269         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5270         macros.
5271
5272 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5273
5274         PR symtab/24423:
5275         * source.c (print_source_lines_base): Advance "iter" when a
5276         control character is seen.
5277
5278 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5279
5280         * inferior.h (struct infcall_suspend_state_deleter):
5281         Catch exception in destructor to avoid crash.
5282
5283 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5284
5285         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5286         close to the add_com "shell".
5287
5288 2019-04-18  Tom Tromey  <tromey@adacore.com>
5289
5290         * process-stratum-target.h (class process_stratum_target)
5291         <stratum>: Add "final".
5292
5293 2019-04-17  Tom Tromey  <tromey@adacore.com>
5294
5295         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5296         against nullptr before use.
5297
5298 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5299
5300         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5301
5302 2019-04-17  Jim Wilson  <jimw@sifive.com>
5303             Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5306         code read might fail, assume 4-byte breakpoint in that case.
5307
5308 2019-04-15  Leszek Swirski  <leszeks@google.com>
5309
5310         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5311         rather than a hand-rolled POD check when checking for forced MEMORY
5312         classification.
5313
5314 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5315
5316         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5317         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5318         function.
5319         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5320         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5321         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5322         declaration.
5323
5324 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5325
5326         * aarch64-linux-nat.c
5327         (aarch64_linux_nat_target::thread_architecture): Add override.
5328         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5329         each VQ.
5330
5331 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5332
5333         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5334
5335 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5338         target types of size 96-bits, add some additional comments, and
5339         check that the builtin type we found was the correct size.
5340
5341 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5342
5343         * utils.c (prompt_for_continue): Don't restore the styling at the
5344         end, as applied_style has the wrong value.  This fixes styling in
5345         long lists of file names that are interrupted by the "Continue?"
5346         prompt.
5347
5348 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5349
5350         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5351         * c-lang.c (c_language_defn): Likewise.
5352         (cplus_language_defn): Likewise.
5353         (asm_language_defn): Likewise.
5354         (minimal_language_defn): Likewise.
5355         * d-lang.c (d_language_defn): Likewise.
5356         * f-lang.c (f_language_defn): Likewise.
5357         * go-lang.c (go_language_defn): Likewise.
5358         * language.c (unknown_language_defn): Likewise.
5359         (auto_language_defn): Likewise.
5360         * language.h (struct language_defn): Remove la_magic field.
5361         (LANG_MAGIC): Delete.
5362         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5363         * objc-lang.c (objc_language_defn): Likewise.
5364         * opencl-lang.c (opencl_language_defn): Likewise.
5365         * p-lang.c (pascal_language_defn): Likewise.
5366         * rust-lang.c (rust_language_defn): Likewise.
5367
5368 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * riscv-tdep.c (riscv_type_align): New function.
5371         (riscv_type_alignment): Delete.
5372         (riscv_arg_location): Use 'type_align'.
5373         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5374
5375 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * gdbtypes.c (type_align): A struct with no non-static fields also
5378         has alignment of 1.
5379
5380 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5381
5382         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5383         component to 0.
5384         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5385         member.
5386         (riscv_struct_info::analyse): New implementation using new
5387         analyse_inner member function.
5388         (riscv_struct_info::field_offset): New member function.
5389         (riscv_struct_info::m_offsets): New member variable.
5390         (riscv_struct_info::analyse_inner): New private member function,
5391         takes the old implementation of riscv_struct_info::analyse but
5392         extended to track field offsets.
5393         (riscv_call_arg_struct): Update the struct folding special cases
5394         to handle cases where empty C++ structs, which are non-zero
5395         length, are found.
5396         (riscv_arg_location): Initialise the length of each location, a
5397         non-zero length now indicates the location is in use.
5398         (riscv_push_dummy_call): Allow for the first location having a
5399         non-zero offset when setting up arguments.
5400         (riscv_return_value): Likewise, but for return values.
5401
5402 2019-04-11  Tom Tromey  <tromey@adacore.com>
5403
5404         * utils.c (internal_vproblem): Make "msg" const.
5405
5406 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5407
5408         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5409         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5410         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5411         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5412
5413 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5414
5415         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5416         function.
5417         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5418         of amd64_collect_native_gregset.
5419         (amd64_linux_nat_target::store_registers): Likewise.
5420
5421 2019-04-10  Tom Tromey  <tom@tromey.com>
5422
5423         * symtab.c (lookup_global_symbol_from_objfile)
5424         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5425         * objfiles.h (class separate_debug_iterator): New.
5426         (class separate_debug_range): New.
5427         (struct objfile) <separate_debug_objfiles>: New method.
5428         (objfile_separate_debug_iterate): Don't declare.
5429         * objfiles.c (separate_debug_iterator::operator++): Rename from
5430         objfile_separate_debug_iterate.
5431         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5432         iterator.
5433         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5434         iterator.
5435
5436 2019-04-10  Tom Tromey  <tom@tromey.com>
5437
5438         * symfile.c (reread_symbols): Remove old comment.
5439         * objfiles.c (free_all_objfiles): Fix a typo.
5440
5441 2019-04-10  Tom Tromey  <tom@tromey.com>
5442
5443         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5444         * minsyms.c (lookup_minimal_symbol): Use foreach.
5445         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5446         (lookup_minimal_symbol_solib_trampoline): Likewise.
5447         * symfile.c (reread_symbols): Use foreach.
5448
5449 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5450             Tom Tromey  <tromey@adacore.com>
5451
5452         PR rust/24414:
5453         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5454         (rust_lex_int_test): Change "value" to be LONGEST.
5455         (rust_lex_tests): Add test for long integer literal.
5456
5457 2019-04-09  Tom Tromey  <tromey@adacore.com>
5458
5459         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5460         to bool.
5461         (extended_remote_target::attach): Update.
5462         (remote_target::remote_notice_new_inferior): Update.
5463         (remote_target::add_current_inferior_and_thread): Update.
5464         * inferior.c (exit_inferior_1): Use "false".
5465         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5466
5467 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5468
5469         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5470         the "start" command.
5471
5472 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5473
5474         * python/py-inferior.c (infpy_thread_from_thread_handle):
5475         Adjust comments to reflect renaming of thread_from_thread_handle
5476         to thread_from_handle.  Adjust keywords.  Fix type error message.
5477         (inferior_object_methods): Add thread_from_handle.  Retain
5478         thread_from_thread_handle, but mark it as deprecated.
5479
5480 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5481
5482         * gdbthread.h (find_thread_by_handle): Revise declaration.
5483         * thread.c (find_thread_by_handle): Likewise.  Adjust
5484         implementation too.
5485         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5486         support for buffer objects as handles.
5487
5488 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5489
5490         * python/py-infthread.c (thpy_thread_handle): New function.
5491         (thread_object_methods): Register thpy_thread_handle.
5492
5493 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5494
5495         * gdbthread.h (thread_to_thread_handle): Declare.
5496         * thread.c (gdbtypes.h): Include.
5497         (thread_to_thread_handle): New function.
5498
5499         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5500         (target_thread_info_to_thread_handle): Declare.
5501         * target.c (target_thread_info_to_thread_handle): New function.
5502         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5503         * target-delegates.c: Regenerate.
5504
5505         * linux-thread-db.c (class thread_db_target): Add method
5506         thread_info_to_thread_handle.
5507         (thread_db_target::thread_info_to_thread_handle): Define.
5508         * remote.c (class remote_target): Add new method
5509         thread_info_to_thread_handle.
5510         (remote_target::thread_info_to_thread_handle): Define.
5511
5512 2019-04-08  Pedro Alves  <palves@redhat.com>
5513
5514         * common/common-exceptions.c (throw_exception): Don't create
5515         named object to throw; throw directly.
5516         (throw_it): Likewise.  Don't initialize gdb_exception::message
5517         here, with new; pass FMT and AP to the ctor instead.
5518         * common/common-exceptions.h: Include <string>.
5519         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5520         const char *, va_list)): New ctor.  Use std::make_shared.
5521         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5522         errors)): Delete.
5523         (gdb_exception_error::gdb_exception_error(enum errors, const char
5524         *, va_list)): New.
5525         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5526         Add assertion.
5527         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5528         errors)): Delete.
5529         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5530         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5531         Add assertion.
5532
5533 2019-04-08  Tom Tromey  <tom@tromey.com>
5534
5535         * valops.c (value_rtti_indirect_type): Replace throw_exception
5536         with throw.
5537         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5538         with throw.
5539         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5540         throw.
5541         * target.c (target_translate_tls_address): Replace throw_exception
5542         with throw.
5543         * stack.c (frame_apply_command_count): Replace throw_exception
5544         with throw.
5545         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5546         throw.
5547         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5548         with throw.
5549         * rs6000-tdep.c (rs6000_frame_cache)
5550         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5551         * remote.c: Replace throw_exception with throw.
5552         * record-full.c (record_full_message, record_full_wait_1)
5553         (record_full_restore): Replace throw_exception with throw.
5554         * record-btrace.c:
5555         (get_thread_current_frame_id, record_btrace_start_replaying)
5556         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5557         (cmd_record_btrace_start): Replace throw_exception with throw.
5558         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5559         throw.
5560         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5561         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5562         * linespec.c:
5563         (find_linespec_symbols): Replace throw_exception with throw.
5564         * infrun.c (displaced_step_prepare, resume): Replace
5565         throw_exception with throw.
5566         * infcmd.c (post_create_inferior): Replace throw_exception with
5567         throw.
5568         * inf-loop.c (inferior_event_handler): Replace throw_exception
5569         with throw.
5570         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5571         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5572         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5573         (get_prev_frame_always, get_frame_pc_if_available)
5574         (get_frame_address_in_block_if_available, get_frame_language):
5575         Replace throw_exception with throw.
5576         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5577         throw_exception with throw.
5578         * eval.c (fetch_subexp_value, evaluate_var_value)
5579         (evaluate_funcall, evaluate_subexp_standard): Replace
5580         throw_exception with throw.
5581         * dwarf2loc.c (call_site_find_chain)
5582         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5583         Replace throw_exception with throw.
5584         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5585         with throw.
5586         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5587         throw.
5588         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5589         * completer.c (complete_line_internal): Replace throw_exception
5590         with throw.
5591         * compile/compile-object-run.c (compile_object_run): Replace
5592         throw_exception with throw.
5593         * cli/cli-script.c (process_next_line): Replace throw_exception
5594         with throw.
5595         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5596         (btrace_enable, btrace_maint_update_pt_packets): Replace
5597         throw_exception with throw.
5598         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5599         throw_exception with throw.
5600         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5601         throw_exception with throw.
5602         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5603         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5604         * aarch64-tdep.c (aarch64_make_prologue_cache)
5605         (aarch64_make_stub_cache): Replace throw_exception with throw.
5606
5607 2019-04-08  Tom Tromey  <tom@tromey.com>
5608
5609         * common/common-exceptions.c (throw_exception): Rename from
5610         throw_exception_cxx.  Remove old copy.  Make argument const.
5611         (throw_it): Create and throw exception objects directly.
5612         * common/common-exceptions.h (throw_exception): Make argument
5613         const.
5614         (struct gdb_exception_error): Add constructor.
5615         (struct gdb_exception_quit): Add constructor.
5616
5617 2019-04-08  Tom Tromey  <tom@tromey.com>
5618
5619         * common/common-exceptions.h (exception_rethrow): Don't declare.
5620         (TRY_SJLJ): Update comment.
5621         (TRY, CATCH, END_CATCH): Remove.
5622         * common/common-exceptions.c (exception_rethrow): Remove.
5623
5624 2019-04-08  Tom Tromey  <tom@tromey.com>
5625
5626         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5627         Remove.
5628         (gdb_exception_error): Rename from
5629         gdb_exception_RETURN_MASK_ERROR.
5630         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5631         (gdb_quit_bad_alloc): Update.
5632         * aarch64-tdep.c: Update.
5633         * ada-lang.c: Update.
5634         * ada-typeprint.c: Update.
5635         * ada-valprint.c: Update.
5636         * amd64-tdep.c: Update.
5637         * arch-utils.c: Update.
5638         * break-catch-throw.c: Update.
5639         * breakpoint.c: Update.
5640         * btrace.c: Update.
5641         * c-varobj.c: Update.
5642         * cli/cli-cmds.c: Update.
5643         * cli/cli-interp.c: Update.
5644         * cli/cli-script.c: Update.
5645         * common/common-exceptions.c: Update.
5646         * common/new-op.c: Update.
5647         * common/selftest.c: Update.
5648         * compile/compile-c-symbols.c: Update.
5649         * compile/compile-cplus-symbols.c: Update.
5650         * compile/compile-object-load.c: Update.
5651         * compile/compile-object-run.c: Update.
5652         * completer.c: Update.
5653         * corelow.c: Update.
5654         * cp-abi.c: Update.
5655         * cp-support.c: Update.
5656         * cp-valprint.c: Update.
5657         * darwin-nat.c: Update.
5658         * disasm-selftests.c: Update.
5659         * dtrace-probe.c: Update.
5660         * dwarf-index-cache.c: Update.
5661         * dwarf-index-write.c: Update.
5662         * dwarf2-frame-tailcall.c: Update.
5663         * dwarf2-frame.c: Update.
5664         * dwarf2loc.c: Update.
5665         * dwarf2read.c: Update.
5666         * eval.c: Update.
5667         * event-loop.c: Update.
5668         * event-top.c: Update.
5669         * exec.c: Update.
5670         * f-valprint.c: Update.
5671         * fbsd-tdep.c: Update.
5672         * frame-unwind.c: Update.
5673         * frame.c: Update.
5674         * gdbtypes.c: Update.
5675         * gnu-v3-abi.c: Update.
5676         * guile/guile-internal.h: Update.
5677         * guile/scm-block.c: Update.
5678         * guile/scm-breakpoint.c: Update.
5679         * guile/scm-cmd.c: Update.
5680         * guile/scm-disasm.c: Update.
5681         * guile/scm-frame.c: Update.
5682         * guile/scm-lazy-string.c: Update.
5683         * guile/scm-math.c: Update.
5684         * guile/scm-param.c: Update.
5685         * guile/scm-ports.c: Update.
5686         * guile/scm-pretty-print.c: Update.
5687         * guile/scm-symbol.c: Update.
5688         * guile/scm-symtab.c: Update.
5689         * guile/scm-type.c: Update.
5690         * guile/scm-value.c: Update.
5691         * i386-linux-tdep.c: Update.
5692         * i386-tdep.c: Update.
5693         * inf-loop.c: Update.
5694         * infcall.c: Update.
5695         * infcmd.c: Update.
5696         * infrun.c: Update.
5697         * jit.c: Update.
5698         * language.c: Update.
5699         * linespec.c: Update.
5700         * linux-fork.c: Update.
5701         * linux-nat.c: Update.
5702         * linux-tdep.c: Update.
5703         * linux-thread-db.c: Update.
5704         * main.c: Update.
5705         * mi/mi-cmd-break.c: Update.
5706         * mi/mi-cmd-stack.c: Update.
5707         * mi/mi-interp.c: Update.
5708         * mi/mi-main.c: Update.
5709         * objc-lang.c: Update.
5710         * p-valprint.c: Update.
5711         * parse.c: Update.
5712         * ppc-linux-tdep.c: Update.
5713         * printcmd.c: Update.
5714         * python/py-arch.c: Update.
5715         * python/py-breakpoint.c: Update.
5716         * python/py-cmd.c: Update.
5717         * python/py-finishbreakpoint.c: Update.
5718         * python/py-frame.c: Update.
5719         * python/py-framefilter.c: Update.
5720         * python/py-gdb-readline.c: Update.
5721         * python/py-inferior.c: Update.
5722         * python/py-infthread.c: Update.
5723         * python/py-lazy-string.c: Update.
5724         * python/py-linetable.c: Update.
5725         * python/py-objfile.c: Update.
5726         * python/py-param.c: Update.
5727         * python/py-prettyprint.c: Update.
5728         * python/py-progspace.c: Update.
5729         * python/py-record-btrace.c: Update.
5730         * python/py-record.c: Update.
5731         * python/py-symbol.c: Update.
5732         * python/py-type.c: Update.
5733         * python/py-unwind.c: Update.
5734         * python/py-utils.c: Update.
5735         * python/py-value.c: Update.
5736         * python/python.c: Update.
5737         * record-btrace.c: Update.
5738         * record-full.c: Update.
5739         * remote-fileio.c: Update.
5740         * remote.c: Update.
5741         * riscv-tdep.c: Update.
5742         * rs6000-aix-tdep.c: Update.
5743         * rs6000-tdep.c: Update.
5744         * rust-exp.y: Update.
5745         * rust-lang.c: Update.
5746         * s390-tdep.c: Update.
5747         * selftest-arch.c: Update.
5748         * solib-dsbt.c: Update.
5749         * solib-frv.c: Update.
5750         * solib-spu.c: Update.
5751         * solib-svr4.c: Update.
5752         * solib.c: Update.
5753         * sparc64-linux-tdep.c: Update.
5754         * stack.c: Update.
5755         * symfile-mem.c: Update.
5756         * symmisc.c: Update.
5757         * target.c: Update.
5758         * thread.c: Update.
5759         * top.c: Update.
5760         * tracefile-tfile.c: Update.
5761         * tui/tui.c: Update.
5762         * typeprint.c: Update.
5763         * unittests/cli-utils-selftests.c: Update.
5764         * unittests/parse-connection-spec-selftests.c: Update.
5765         * valops.c: Update.
5766         * valprint.c: Update.
5767         * value.c: Update.
5768         * varobj.c: Update.
5769         * windows-nat.c: Update.
5770         * x86-linux-nat.c: Update.
5771         * xml-support.c: Update.
5772
5773 2019-04-08  Tom Tromey  <tom@tromey.com>
5774
5775         * xml-support.c: Use C++ exception handling.
5776         * x86-linux-nat.c: Use C++ exception handling.
5777         * windows-nat.c: Use C++ exception handling.
5778         * varobj.c: Use C++ exception handling.
5779         * value.c: Use C++ exception handling.
5780         * valprint.c: Use C++ exception handling.
5781         * valops.c: Use C++ exception handling.
5782         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5783         handling.
5784         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5785         * typeprint.c: Use C++ exception handling.
5786         * tui/tui.c: Use C++ exception handling.
5787         * tracefile-tfile.c: Use C++ exception handling.
5788         * top.c: Use C++ exception handling.
5789         * thread.c: Use C++ exception handling.
5790         * target.c: Use C++ exception handling.
5791         * symmisc.c: Use C++ exception handling.
5792         * symfile-mem.c: Use C++ exception handling.
5793         * stack.c: Use C++ exception handling.
5794         * sparc64-linux-tdep.c: Use C++ exception handling.
5795         * solib.c: Use C++ exception handling.
5796         * solib-svr4.c: Use C++ exception handling.
5797         * solib-spu.c: Use C++ exception handling.
5798         * solib-frv.c: Use C++ exception handling.
5799         * solib-dsbt.c: Use C++ exception handling.
5800         * selftest-arch.c: Use C++ exception handling.
5801         * s390-tdep.c: Use C++ exception handling.
5802         * rust-lang.c: Use C++ exception handling.
5803         * rust-exp.y: Use C++ exception handling.
5804         * rs6000-tdep.c: Use C++ exception handling.
5805         * rs6000-aix-tdep.c: Use C++ exception handling.
5806         * riscv-tdep.c: Use C++ exception handling.
5807         * remote.c: Use C++ exception handling.
5808         * remote-fileio.c: Use C++ exception handling.
5809         * record-full.c: Use C++ exception handling.
5810         * record-btrace.c: Use C++ exception handling.
5811         * python/python.c: Use C++ exception handling.
5812         * python/py-value.c: Use C++ exception handling.
5813         * python/py-utils.c: Use C++ exception handling.
5814         * python/py-unwind.c: Use C++ exception handling.
5815         * python/py-type.c: Use C++ exception handling.
5816         * python/py-symbol.c: Use C++ exception handling.
5817         * python/py-record.c: Use C++ exception handling.
5818         * python/py-record-btrace.c: Use C++ exception handling.
5819         * python/py-progspace.c: Use C++ exception handling.
5820         * python/py-prettyprint.c: Use C++ exception handling.
5821         * python/py-param.c: Use C++ exception handling.
5822         * python/py-objfile.c: Use C++ exception handling.
5823         * python/py-linetable.c: Use C++ exception handling.
5824         * python/py-lazy-string.c: Use C++ exception handling.
5825         * python/py-infthread.c: Use C++ exception handling.
5826         * python/py-inferior.c: Use C++ exception handling.
5827         * python/py-gdb-readline.c: Use C++ exception handling.
5828         * python/py-framefilter.c: Use C++ exception handling.
5829         * python/py-frame.c: Use C++ exception handling.
5830         * python/py-finishbreakpoint.c: Use C++ exception handling.
5831         * python/py-cmd.c: Use C++ exception handling.
5832         * python/py-breakpoint.c: Use C++ exception handling.
5833         * python/py-arch.c: Use C++ exception handling.
5834         * printcmd.c: Use C++ exception handling.
5835         * ppc-linux-tdep.c: Use C++ exception handling.
5836         * parse.c: Use C++ exception handling.
5837         * p-valprint.c: Use C++ exception handling.
5838         * objc-lang.c: Use C++ exception handling.
5839         * mi/mi-main.c: Use C++ exception handling.
5840         * mi/mi-interp.c: Use C++ exception handling.
5841         * mi/mi-cmd-stack.c: Use C++ exception handling.
5842         * mi/mi-cmd-break.c: Use C++ exception handling.
5843         * main.c: Use C++ exception handling.
5844         * linux-thread-db.c: Use C++ exception handling.
5845         * linux-tdep.c: Use C++ exception handling.
5846         * linux-nat.c: Use C++ exception handling.
5847         * linux-fork.c: Use C++ exception handling.
5848         * linespec.c: Use C++ exception handling.
5849         * language.c: Use C++ exception handling.
5850         * jit.c: Use C++ exception handling.
5851         * infrun.c: Use C++ exception handling.
5852         * infcmd.c: Use C++ exception handling.
5853         * infcall.c: Use C++ exception handling.
5854         * inf-loop.c: Use C++ exception handling.
5855         * i386-tdep.c: Use C++ exception handling.
5856         * i386-linux-tdep.c: Use C++ exception handling.
5857         * guile/scm-value.c: Use C++ exception handling.
5858         * guile/scm-type.c: Use C++ exception handling.
5859         * guile/scm-symtab.c: Use C++ exception handling.
5860         * guile/scm-symbol.c: Use C++ exception handling.
5861         * guile/scm-pretty-print.c: Use C++ exception handling.
5862         * guile/scm-ports.c: Use C++ exception handling.
5863         * guile/scm-param.c: Use C++ exception handling.
5864         * guile/scm-math.c: Use C++ exception handling.
5865         * guile/scm-lazy-string.c: Use C++ exception handling.
5866         * guile/scm-frame.c: Use C++ exception handling.
5867         * guile/scm-disasm.c: Use C++ exception handling.
5868         * guile/scm-cmd.c: Use C++ exception handling.
5869         * guile/scm-breakpoint.c: Use C++ exception handling.
5870         * guile/scm-block.c: Use C++ exception handling.
5871         * guile/guile-internal.h: Use C++ exception handling.
5872         * gnu-v3-abi.c: Use C++ exception handling.
5873         * gdbtypes.c: Use C++ exception handling.
5874         * frame.c: Use C++ exception handling.
5875         * frame-unwind.c: Use C++ exception handling.
5876         * fbsd-tdep.c: Use C++ exception handling.
5877         * f-valprint.c: Use C++ exception handling.
5878         * exec.c: Use C++ exception handling.
5879         * event-top.c: Use C++ exception handling.
5880         * event-loop.c: Use C++ exception handling.
5881         * eval.c: Use C++ exception handling.
5882         * dwarf2read.c: Use C++ exception handling.
5883         * dwarf2loc.c: Use C++ exception handling.
5884         * dwarf2-frame.c: Use C++ exception handling.
5885         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5886         * dwarf-index-write.c: Use C++ exception handling.
5887         * dwarf-index-cache.c: Use C++ exception handling.
5888         * dtrace-probe.c: Use C++ exception handling.
5889         * disasm-selftests.c: Use C++ exception handling.
5890         * darwin-nat.c: Use C++ exception handling.
5891         * cp-valprint.c: Use C++ exception handling.
5892         * cp-support.c: Use C++ exception handling.
5893         * cp-abi.c: Use C++ exception handling.
5894         * corelow.c: Use C++ exception handling.
5895         * completer.c: Use C++ exception handling.
5896         * compile/compile-object-run.c: Use C++ exception handling.
5897         * compile/compile-object-load.c: Use C++ exception handling.
5898         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5899         * compile/compile-c-symbols.c: Use C++ exception handling.
5900         * common/selftest.c: Use C++ exception handling.
5901         * common/new-op.c: Use C++ exception handling.
5902         * cli/cli-script.c: Use C++ exception handling.
5903         * cli/cli-interp.c: Use C++ exception handling.
5904         * cli/cli-cmds.c: Use C++ exception handling.
5905         * c-varobj.c: Use C++ exception handling.
5906         * btrace.c: Use C++ exception handling.
5907         * breakpoint.c: Use C++ exception handling.
5908         * break-catch-throw.c: Use C++ exception handling.
5909         * arch-utils.c: Use C++ exception handling.
5910         * amd64-tdep.c: Use C++ exception handling.
5911         * ada-valprint.c: Use C++ exception handling.
5912         * ada-typeprint.c: Use C++ exception handling.
5913         * ada-lang.c: Use C++ exception handling.
5914         * aarch64-tdep.c: Use C++ exception handling.
5915
5916 2019-04-08  Tom Tromey  <tom@tromey.com>
5917
5918         * xml-support.c (gdb_xml_parser::parse): Update.
5919         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5920         * value.c (show_convenience): Update.
5921         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5922         (test_parse_flags_qcs): Update.
5923         * thread.c (thr_try_catch_cmd): Update.
5924         * target.c (target_translate_tls_address): Update.
5925         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5926         (info_frame_command_core, frame_apply_command_count): Update.
5927         * rust-exp.y (rust_lex_exception_test): Update.
5928         * riscv-tdep.c (riscv_print_one_register_info): Update.
5929         * remote.c (remote_target::enable_btrace): Update.
5930         * record-btrace.c (record_btrace_enable_warn): Update.
5931         * python/py-utils.c (gdbpy_convert_exception): Update.
5932         * printcmd.c (do_one_display, print_variable_and_value): Update.
5933         * mi/mi-main.c (mi_print_exception): Update.
5934         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5935         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5936         * linux-nat.c (linux_nat_target::attach): Update.
5937         * linux-fork.c (class scoped_switch_fork_info): Update.
5938         * infrun.c (displaced_step_prepare): Update.
5939         * infcall.c (call_function_by_hand_dummy): Update.
5940         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5941         * gnu-v3-abi.c (print_one_vtable): Update.
5942         * frame.c (get_prev_frame_always): Update.
5943         * f-valprint.c (info_common_command_for_block): Update.
5944         * exec.c (try_open_exec_file): Update.
5945         * exceptions.c (print_exception, exception_print)
5946         (exception_fprintf, exception_print_same): Update.
5947         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5948         * dwarf-index-cache.c (index_cache::store)
5949         (index_cache::lookup_gdb_index): Update.
5950         * darwin-nat.c (maybe_cache_shell): Update.
5951         * cp-valprint.c (cp_print_value_fields): Update.
5952         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5953         (gcc_cplus_symbol_address): Update.
5954         * compile/compile-c-symbols.c (gcc_convert_symbol)
5955         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5956         * common/selftest.c: Update.
5957         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5958         a std::string.
5959         (exception_try_scope_entry, exception_try_scope_exit): Don't
5960         declare.
5961         (struct exception_try_scope): Remove.
5962         (TRY): Don't use exception_try_scope.
5963         (struct gdb_exception): Add constructor, operator=.
5964         <what>: New method.
5965         (struct gdb_exception_RETURN_MASK_ALL)
5966         (struct gdb_exception_RETURN_MASK_ERROR)
5967         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5968         (struct gdb_quit_bad_alloc): Update.
5969         * common/common-exceptions.c (exception_none): Change
5970         initializer.
5971         (struct catcher) <state, exception>: Initialize inline.
5972         <prev>: Remove member.
5973         (current_catcher): Remove.
5974         (catchers): New global.
5975         (exceptions_state_mc_init): Simplify.
5976         (catcher_pop): Remove.
5977         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5978         (try_scope_depth, exception_try_scope_entry)
5979         (exception_try_scope_exit): Remove.
5980         (throw_exception_sjlj): Update.
5981         (exception_messages, exception_messages_size): Remove.
5982         (throw_it): Simplify.
5983         (gdb_exception_sliced_copy): Remove.
5984         (throw_exception_cxx): Update.
5985         * cli/cli-script.c (script_from_file): Update.
5986         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5987         Update.
5988         * ada-valprint.c (ada_val_print): Update.
5989         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5990         (create_excep_cond_exprs): Update.
5991
5992 2019-04-08  Tom Tromey  <tom@tromey.com>
5993
5994         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5995         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5996         (TRY, CATCH, END_CATCH): Remove some definitions.
5997         * common/common-exceptions.c: Don't use GDB_XCPT.
5998         (catcher_list_size): Remove.
5999         (throw_exception, throw_it): Simplify.
6000
6001 2019-04-05  Tom Tromey  <tom@tromey.com>
6002
6003         Revert the header-sorting patch.
6004         * ft32-tdep.c: Revert.
6005         * frv-tdep.c: Revert.
6006         * frv-linux-tdep.c: Revert.
6007         * frame.c: Revert.
6008         * frame-unwind.c: Revert.
6009         * frame-base.c: Revert.
6010         * fork-child.c: Revert.
6011         * findvar.c: Revert.
6012         * findcmd.c: Revert.
6013         * filesystem.c: Revert.
6014         * filename-seen-cache.h: Revert.
6015         * filename-seen-cache.c: Revert.
6016         * fbsd-tdep.c: Revert.
6017         * fbsd-nat.h: Revert.
6018         * fbsd-nat.c: Revert.
6019         * f-valprint.c: Revert.
6020         * f-typeprint.c: Revert.
6021         * f-lang.c: Revert.
6022         * extension.h: Revert.
6023         * extension.c: Revert.
6024         * extension-priv.h: Revert.
6025         * expprint.c: Revert.
6026         * exec.h: Revert.
6027         * exec.c: Revert.
6028         * exceptions.c: Revert.
6029         * event-top.c: Revert.
6030         * event-loop.c: Revert.
6031         * eval.c: Revert.
6032         * elfread.c: Revert.
6033         * dwarf2read.h: Revert.
6034         * dwarf2read.c: Revert.
6035         * dwarf2loc.c: Revert.
6036         * dwarf2expr.h: Revert.
6037         * dwarf2expr.c: Revert.
6038         * dwarf2-frame.c: Revert.
6039         * dwarf2-frame-tailcall.c: Revert.
6040         * dwarf-index-write.h: Revert.
6041         * dwarf-index-write.c: Revert.
6042         * dwarf-index-common.c: Revert.
6043         * dwarf-index-cache.h: Revert.
6044         * dwarf-index-cache.c: Revert.
6045         * dummy-frame.c: Revert.
6046         * dtrace-probe.c: Revert.
6047         * disasm.h: Revert.
6048         * disasm.c: Revert.
6049         * disasm-selftests.c: Revert.
6050         * dictionary.c: Revert.
6051         * dicos-tdep.c: Revert.
6052         * demangle.c: Revert.
6053         * dcache.h: Revert.
6054         * dcache.c: Revert.
6055         * darwin-nat.h: Revert.
6056         * darwin-nat.c: Revert.
6057         * darwin-nat-info.c: Revert.
6058         * d-valprint.c: Revert.
6059         * d-namespace.c: Revert.
6060         * d-lang.c: Revert.
6061         * ctf.c: Revert.
6062         * csky-tdep.c: Revert.
6063         * csky-linux-tdep.c: Revert.
6064         * cris-tdep.c: Revert.
6065         * cris-linux-tdep.c: Revert.
6066         * cp-valprint.c: Revert.
6067         * cp-support.c: Revert.
6068         * cp-namespace.c: Revert.
6069         * cp-abi.c: Revert.
6070         * corelow.c: Revert.
6071         * corefile.c: Revert.
6072         * continuations.c: Revert.
6073         * completer.h: Revert.
6074         * completer.c: Revert.
6075         * complaints.c: Revert.
6076         * coffread.c: Revert.
6077         * coff-pe-read.c: Revert.
6078         * cli-out.h: Revert.
6079         * cli-out.c: Revert.
6080         * charset.c: Revert.
6081         * c-varobj.c: Revert.
6082         * c-valprint.c: Revert.
6083         * c-typeprint.c: Revert.
6084         * c-lang.c: Revert.
6085         * buildsym.c: Revert.
6086         * buildsym-legacy.c: Revert.
6087         * build-id.h: Revert.
6088         * build-id.c: Revert.
6089         * btrace.c: Revert.
6090         * bsd-uthread.c: Revert.
6091         * breakpoint.h: Revert.
6092         * breakpoint.c: Revert.
6093         * break-catch-throw.c: Revert.
6094         * break-catch-syscall.c: Revert.
6095         * break-catch-sig.c: Revert.
6096         * blockframe.c: Revert.
6097         * block.c: Revert.
6098         * bfin-tdep.c: Revert.
6099         * bfin-linux-tdep.c: Revert.
6100         * bfd-target.c: Revert.
6101         * bcache.c: Revert.
6102         * ax-general.c: Revert.
6103         * ax-gdb.h: Revert.
6104         * ax-gdb.c: Revert.
6105         * avr-tdep.c: Revert.
6106         * auxv.c: Revert.
6107         * auto-load.c: Revert.
6108         * arm-wince-tdep.c: Revert.
6109         * arm-tdep.c: Revert.
6110         * arm-symbian-tdep.c: Revert.
6111         * arm-pikeos-tdep.c: Revert.
6112         * arm-obsd-tdep.c: Revert.
6113         * arm-nbsd-tdep.c: Revert.
6114         * arm-nbsd-nat.c: Revert.
6115         * arm-linux-tdep.c: Revert.
6116         * arm-linux-nat.c: Revert.
6117         * arm-fbsd-tdep.c: Revert.
6118         * arm-fbsd-nat.c: Revert.
6119         * arm-bsd-tdep.c: Revert.
6120         * arch-utils.c: Revert.
6121         * arc-tdep.c: Revert.
6122         * arc-newlib-tdep.c: Revert.
6123         * annotate.h: Revert.
6124         * annotate.c: Revert.
6125         * amd64-windows-tdep.c: Revert.
6126         * amd64-windows-nat.c: Revert.
6127         * amd64-tdep.c: Revert.
6128         * amd64-sol2-tdep.c: Revert.
6129         * amd64-obsd-tdep.c: Revert.
6130         * amd64-obsd-nat.c: Revert.
6131         * amd64-nbsd-tdep.c: Revert.
6132         * amd64-nbsd-nat.c: Revert.
6133         * amd64-nat.c: Revert.
6134         * amd64-linux-tdep.c: Revert.
6135         * amd64-linux-nat.c: Revert.
6136         * amd64-fbsd-tdep.c: Revert.
6137         * amd64-fbsd-nat.c: Revert.
6138         * amd64-dicos-tdep.c: Revert.
6139         * amd64-darwin-tdep.c: Revert.
6140         * amd64-bsd-nat.c: Revert.
6141         * alpha-tdep.c: Revert.
6142         * alpha-obsd-tdep.c: Revert.
6143         * alpha-nbsd-tdep.c: Revert.
6144         * alpha-mdebug-tdep.c: Revert.
6145         * alpha-linux-tdep.c: Revert.
6146         * alpha-linux-nat.c: Revert.
6147         * alpha-bsd-tdep.c: Revert.
6148         * alpha-bsd-nat.c: Revert.
6149         * aix-thread.c: Revert.
6150         * agent.c: Revert.
6151         * addrmap.c: Revert.
6152         * ada-varobj.c: Revert.
6153         * ada-valprint.c: Revert.
6154         * ada-typeprint.c: Revert.
6155         * ada-tasks.c: Revert.
6156         * ada-lang.c: Revert.
6157         * aarch64-tdep.c: Revert.
6158         * aarch64-ravenscar-thread.c: Revert.
6159         * aarch64-newlib-tdep.c: Revert.
6160         * aarch64-linux-tdep.c: Revert.
6161         * aarch64-linux-nat.c: Revert.
6162         * aarch64-fbsd-tdep.c: Revert.
6163         * aarch64-fbsd-nat.c: Revert.
6164         * aarch32-linux-nat.c: Revert.
6165
6166 2019-04-05  Tom Tromey  <tom@tromey.com>
6167
6168         * ft32-tdep.c: Sort headers.
6169         * frv-tdep.c: Sort headers.
6170         * frv-linux-tdep.c: Sort headers.
6171         * frame.c: Sort headers.
6172         * frame-unwind.c: Sort headers.
6173         * frame-base.c: Sort headers.
6174         * fork-child.c: Sort headers.
6175         * findvar.c: Sort headers.
6176         * findcmd.c: Sort headers.
6177         * filesystem.c: Sort headers.
6178         * filename-seen-cache.h: Sort headers.
6179         * filename-seen-cache.c: Sort headers.
6180         * fbsd-tdep.c: Sort headers.
6181         * fbsd-nat.h: Sort headers.
6182         * fbsd-nat.c: Sort headers.
6183         * f-valprint.c: Sort headers.
6184         * f-typeprint.c: Sort headers.
6185         * f-lang.c: Sort headers.
6186         * extension.h: Sort headers.
6187         * extension.c: Sort headers.
6188         * extension-priv.h: Sort headers.
6189         * expprint.c: Sort headers.
6190         * exec.h: Sort headers.
6191         * exec.c: Sort headers.
6192         * exceptions.c: Sort headers.
6193         * event-top.c: Sort headers.
6194         * event-loop.c: Sort headers.
6195         * eval.c: Sort headers.
6196         * elfread.c: Sort headers.
6197         * dwarf2read.h: Sort headers.
6198         * dwarf2read.c: Sort headers.
6199         * dwarf2loc.c: Sort headers.
6200         * dwarf2expr.h: Sort headers.
6201         * dwarf2expr.c: Sort headers.
6202         * dwarf2-frame.c: Sort headers.
6203         * dwarf2-frame-tailcall.c: Sort headers.
6204         * dwarf-index-write.h: Sort headers.
6205         * dwarf-index-write.c: Sort headers.
6206         * dwarf-index-common.c: Sort headers.
6207         * dwarf-index-cache.h: Sort headers.
6208         * dwarf-index-cache.c: Sort headers.
6209         * dummy-frame.c: Sort headers.
6210         * dtrace-probe.c: Sort headers.
6211         * disasm.h: Sort headers.
6212         * disasm.c: Sort headers.
6213         * disasm-selftests.c: Sort headers.
6214         * dictionary.c: Sort headers.
6215         * dicos-tdep.c: Sort headers.
6216         * demangle.c: Sort headers.
6217         * dcache.h: Sort headers.
6218         * dcache.c: Sort headers.
6219         * darwin-nat.h: Sort headers.
6220         * darwin-nat.c: Sort headers.
6221         * darwin-nat-info.c: Sort headers.
6222         * d-valprint.c: Sort headers.
6223         * d-namespace.c: Sort headers.
6224         * d-lang.c: Sort headers.
6225         * ctf.c: Sort headers.
6226         * csky-tdep.c: Sort headers.
6227         * csky-linux-tdep.c: Sort headers.
6228         * cris-tdep.c: Sort headers.
6229         * cris-linux-tdep.c: Sort headers.
6230         * cp-valprint.c: Sort headers.
6231         * cp-support.c: Sort headers.
6232         * cp-namespace.c: Sort headers.
6233         * cp-abi.c: Sort headers.
6234         * corelow.c: Sort headers.
6235         * corefile.c: Sort headers.
6236         * continuations.c: Sort headers.
6237         * completer.h: Sort headers.
6238         * completer.c: Sort headers.
6239         * complaints.c: Sort headers.
6240         * coffread.c: Sort headers.
6241         * coff-pe-read.c: Sort headers.
6242         * cli-out.h: Sort headers.
6243         * cli-out.c: Sort headers.
6244         * charset.c: Sort headers.
6245         * c-varobj.c: Sort headers.
6246         * c-valprint.c: Sort headers.
6247         * c-typeprint.c: Sort headers.
6248         * c-lang.c: Sort headers.
6249         * buildsym.c: Sort headers.
6250         * buildsym-legacy.c: Sort headers.
6251         * build-id.h: Sort headers.
6252         * build-id.c: Sort headers.
6253         * btrace.c: Sort headers.
6254         * bsd-uthread.c: Sort headers.
6255         * breakpoint.h: Sort headers.
6256         * breakpoint.c: Sort headers.
6257         * break-catch-throw.c: Sort headers.
6258         * break-catch-syscall.c: Sort headers.
6259         * break-catch-sig.c: Sort headers.
6260         * blockframe.c: Sort headers.
6261         * block.c: Sort headers.
6262         * bfin-tdep.c: Sort headers.
6263         * bfin-linux-tdep.c: Sort headers.
6264         * bfd-target.c: Sort headers.
6265         * bcache.c: Sort headers.
6266         * ax-general.c: Sort headers.
6267         * ax-gdb.h: Sort headers.
6268         * ax-gdb.c: Sort headers.
6269         * avr-tdep.c: Sort headers.
6270         * auxv.c: Sort headers.
6271         * auto-load.c: Sort headers.
6272         * arm-wince-tdep.c: Sort headers.
6273         * arm-tdep.c: Sort headers.
6274         * arm-symbian-tdep.c: Sort headers.
6275         * arm-pikeos-tdep.c: Sort headers.
6276         * arm-obsd-tdep.c: Sort headers.
6277         * arm-nbsd-tdep.c: Sort headers.
6278         * arm-nbsd-nat.c: Sort headers.
6279         * arm-linux-tdep.c: Sort headers.
6280         * arm-linux-nat.c: Sort headers.
6281         * arm-fbsd-tdep.c: Sort headers.
6282         * arm-fbsd-nat.c: Sort headers.
6283         * arm-bsd-tdep.c: Sort headers.
6284         * arch-utils.c: Sort headers.
6285         * arc-tdep.c: Sort headers.
6286         * arc-newlib-tdep.c: Sort headers.
6287         * annotate.h: Sort headers.
6288         * annotate.c: Sort headers.
6289         * amd64-windows-tdep.c: Sort headers.
6290         * amd64-windows-nat.c: Sort headers.
6291         * amd64-tdep.c: Sort headers.
6292         * amd64-sol2-tdep.c: Sort headers.
6293         * amd64-obsd-tdep.c: Sort headers.
6294         * amd64-obsd-nat.c: Sort headers.
6295         * amd64-nbsd-tdep.c: Sort headers.
6296         * amd64-nbsd-nat.c: Sort headers.
6297         * amd64-nat.c: Sort headers.
6298         * amd64-linux-tdep.c: Sort headers.
6299         * amd64-linux-nat.c: Sort headers.
6300         * amd64-fbsd-tdep.c: Sort headers.
6301         * amd64-fbsd-nat.c: Sort headers.
6302         * amd64-dicos-tdep.c: Sort headers.
6303         * amd64-darwin-tdep.c: Sort headers.
6304         * amd64-bsd-nat.c: Sort headers.
6305         * alpha-tdep.c: Sort headers.
6306         * alpha-obsd-tdep.c: Sort headers.
6307         * alpha-nbsd-tdep.c: Sort headers.
6308         * alpha-mdebug-tdep.c: Sort headers.
6309         * alpha-linux-tdep.c: Sort headers.
6310         * alpha-linux-nat.c: Sort headers.
6311         * alpha-bsd-tdep.c: Sort headers.
6312         * alpha-bsd-nat.c: Sort headers.
6313         * aix-thread.c: Sort headers.
6314         * agent.c: Sort headers.
6315         * addrmap.c: Sort headers.
6316         * ada-varobj.c: Sort headers.
6317         * ada-valprint.c: Sort headers.
6318         * ada-typeprint.c: Sort headers.
6319         * ada-tasks.c: Sort headers.
6320         * ada-lang.c: Sort headers.
6321         * aarch64-tdep.c: Sort headers.
6322         * aarch64-ravenscar-thread.c: Sort headers.
6323         * aarch64-newlib-tdep.c: Sort headers.
6324         * aarch64-linux-tdep.c: Sort headers.
6325         * aarch64-linux-nat.c: Sort headers.
6326         * aarch64-fbsd-tdep.c: Sort headers.
6327         * aarch64-fbsd-nat.c: Sort headers.
6328         * aarch32-linux-nat.c: Sort headers.
6329
6330 2019-04-04  Tom Tromey  <tom@tromey.com>
6331
6332         * varobj.c (varobj_create): Update.
6333         * rust-exp.y (struct rust_parser) <update_innermost_block,
6334         lookup_symbol>: New methods.
6335         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6336         Rename.
6337         (rust_parser::rust_lookup_type)
6338         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6339         * printcmd.c (display_command, do_one_display): Update.
6340         * parser-defs.h (struct parser_state) <parser_state>: Add
6341         "tracker" parameter.
6342         (block_tracker): New member.
6343         (class innermost_block_tracker) <innermost_block_tracker>: Add
6344         "types" parameter.
6345         <reset>: Remove method.
6346         (innermost_block): Don't declare.
6347         (null_post_parser): Update.
6348         * parse.c (innermost_block): Remove global.
6349         (write_dollar_variable): Update.
6350         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6351         Remove "tracker_types" parameter.
6352         (parse_expression): Add "tracker" parameter.
6353         (parse_expression_for_completion): Update.
6354         (null_post_parser): Add "tracker" parameter.
6355         * p-exp.y: Update rules.
6356         * m2-exp.y: Update rules.
6357         * language.h (struct language_defn) <la_post_parser>: Add
6358         "tracker" parameter.
6359         * go-exp.y: Update rules.
6360         * f-exp.y: Update rules.
6361         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6362         parameter.
6363         * d-exp.y: Update rules.
6364         * c-exp.y: Update rules.
6365         * breakpoint.c (set_breakpoint_condition): Create an
6366         innermost_block_tracker.
6367         (watch_command_1): Likewise.
6368         * ada-lang.c (resolve): Add "tracker" parameter.
6369         (resolve_subexp): Likewise.
6370         * ada-exp.y (write_var_from_sym): Update.
6371
6372 2019-04-04  Tom Tromey  <tom@tromey.com>
6373
6374         * type-stack.h: New file.
6375         * type-stack.c: New file.
6376         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6377         type-stack.h.
6378         (insert_into_type_stack, insert_type, push_type, push_type_int)
6379         (insert_type_address_space, pop_type, pop_type_int)
6380         (pop_typelist, pop_type_stack, append_type_stack)
6381         (push_type_stack, get_type_stack, push_typelist)
6382         (follow_type_instance_flags, follow_types): Don't declare.
6383         * parse.c (type_stack): Remove global.
6384         (parse_exp_in_context): Update.
6385         (insert_into_type_stack, insert_type, push_type, push_type_int)
6386         (insert_type_address_space, pop_type, pop_type_int)
6387         (pop_typelist, pop_type_stack, append_type_stack)
6388         (push_type_stack, get_type_stack, push_typelist)
6389         (follow_type_instance_flags, follow_types): Remove (moved to
6390         type-stack.c).
6391         * f-exp.y (type_stack): New global.
6392         Update rules.
6393         (push_kind_type, f_parse): Update.
6394         * d-exp.y (type_stack): New global.
6395         Update rules.
6396         (d_parse): Update.
6397         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6398         Update rules.
6399         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6400         (HFILES_NO_SRCDIR): Add type-stack.h.
6401
6402 2019-04-04  Tom Tromey  <tom@tromey.com>
6403
6404         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6405         (rust_parser::convert_ast_to_expression, rust_parse)
6406         (rust_lex_test_completion, rust_lex_tests): Update.
6407         * parser-defs.h (struct expr_completion_state): New.
6408         (struct parser_state) <parser_state>: Add completion parameter.
6409         <mark_struct_expression, mark_completion_tag>: New methods.
6410         <parse_completion, m_completion_state>: New members.
6411         (prefixify_expression, null_post_parser): Update.
6412         (mark_struct_expression, mark_completion_tag): Don't declare.
6413         * parse.c (parse_completion, expout_last_struct)
6414         (expout_tag_completion_type, expout_completion_name): Remove
6415         globals.
6416         (parser_state::mark_struct_expression)
6417         (parser_state::mark_completion_tag): Now methods.
6418         (prefixify_expression): Add last_struct parameter.
6419         (prefixify_subexp): Likewise.
6420         (parse_exp_1): Update.
6421         (parse_exp_in_context): Add cstate parameter.  Update.
6422         (parse_expression_for_completion): Create an
6423         expr_completion_state.
6424         (null_post_parser): Add "completion" parameter.
6425         * p-exp.y: Update rules.
6426         (yylex): Update.
6427         * language.h (struct language_defn) <la_post_parser>: Add
6428         "completing" parameter.
6429         * go-exp.y: Update rules.
6430         (lex_one_token): Update.
6431         * expression.h (parse_completion): Don't declare.
6432         * d-exp.y: Update rules.
6433         (lex_one_token): Update rules.
6434         * c-exp.y: Update rules.
6435         (lex_one_token): Update.
6436         * ada-lang.c (resolve): Add "parse_completion" parameter.
6437         (resolve_subexp): Likewise.
6438         (ada_resolve_function): Likewise.
6439
6440 2019-04-04  Tom Tromey  <tom@tromey.com>
6441
6442         * parser-defs.h (struct parser_state) <start_arglist,
6443         end_arglist>: New methods.
6444         <arglist_len, m_funcall_chain>: New members.
6445         (arglist_len, start_arglist, end_arglist): Don't declare.
6446         * parse.c (arglist_len, funcall_chain): Remove global.
6447         (start_arglist, end_arglist): Remove functions.
6448         (parse_exp_in_context): Update.
6449         * p-exp.y: Update rules.
6450         * m2-exp.y: Update rules.
6451         * go-exp.y: Update rules.
6452         * f-exp.y: Update rules.
6453         * d-exp.y: Update rules.
6454         * c-exp.y: Update rules.
6455
6456 2019-04-04  Tom Tromey  <tom@tromey.com>
6457
6458         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6459         lex_operator, push_back>: New methods.
6460         Update all rules.
6461         (rust_parser::lex_hex, lex_escape): Rename and update.
6462         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6463         (rust_parser::lex_operator): Rename and update.
6464         (rust_parser::lex_number, rustyylex, rustyyerror)
6465         (rust_lex_test_init, rust_lex_test_sequence)
6466         (rust_lex_test_push_back, rust_lex_tests): Update.
6467         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6468         parameter.
6469         <lexptr, prev_lexptr>: New members.
6470         (lexptr, prev_lexptr): Don't declare.
6471         * parse.c (lexptr, prev_lexptr): Remove globals.
6472         (parse_exp_in_context): Update.
6473         * p-exp.y (yylex, yyerror): Update.
6474         * m2-exp.y (parse_number, yylex, yyerror): Update.
6475         * go-exp.y (lex_one_token, yyerror): Update.
6476         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6477         * d-exp.y (lex_one_token, yyerror): Update.
6478         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6479         (lex_one_token, yyerror): Update.
6480         * ada-lex.l (YY_INPUT): Update.
6481         (rewind_to_char): Update.
6482         * ada-exp.y (yyerror): Update.
6483
6484 2019-04-04  Tom Tromey  <tom@tromey.com>
6485
6486         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6487         * parser-defs.h (struct parser_state) <parser_state>: Add new
6488         parameter.
6489         <comma_terminates>: New member.
6490         (comma_terminates): Don't declare global.
6491         * parse.c (comma_terminates): Remove global.
6492         (parse_exp_in_context): Update.
6493         * p-exp.y (yylex): Update.
6494         * m2-exp.y (yylex): Update.
6495         * go-exp.y (lex_one_token): Update.
6496         * f-exp.y (yylex): Update.
6497         * d-exp.y (lex_one_token): Update.
6498         * c-exp.y (lex_one_token): Update.
6499         * ada-lex.l: Update.
6500
6501 2019-04-04  Tom Tromey  <tom@tromey.com>
6502
6503         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6504         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6505         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6506         * parser-defs.h (paren_depth): Don't declare.
6507         * parse.c (paren_depth): Remove global.
6508         (parse_exp_in_context): Update.
6509         * p-exp.y (paren_depth): New global.
6510         (pascal_parse): Initialize it.
6511         * m2-exp.y (paren_depth): New global.
6512         (m2_parse): Initialize it.
6513         * go-exp.y (paren_depth): New global.
6514         (go_parse): Initialize it.
6515         * f-exp.y (paren_depth): New global.
6516         (f_parse): Initialize it.
6517         * d-exp.y (paren_depth): New global.
6518         (d_parse): Initialize it.
6519         * c-exp.y (paren_depth): New global.
6520         (c_parse): Initialize it.
6521         * ada-lex.l (paren_depth): New global.
6522         (lexer_init): Initialize it.
6523
6524 2019-04-04  Tom Tromey  <tom@tromey.com>
6525
6526         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6527         (rust_parser::convert_ast_to_type)
6528         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6529         * parser-defs.h (struct parser_state) <parser_state>: Add
6530         parameters.  Initialize new members.
6531         <expression_context_block, expression_context_pc>: New members.
6532         * parse.c (expression_context_block, expression_context_pc):
6533         Remove globals.
6534         (parse_exp_in_context): Update.
6535         * p-exp.y: Update all rules.
6536         (yylex): Update.
6537         * m2-exp.y: Update all rules.
6538         (yylex): Update.
6539         * go-exp.y (yylex): Update.
6540         * f-exp.y (yylex): Update.
6541         * d-exp.y: Update all rules.
6542         (yylex): Update.
6543         * c-exp.y: Update all rules.
6544         (lex_one_token, classify_name, yylex, c_parse): Update.
6545         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6546
6547 2019-04-04  Tom Tromey  <tom@tromey.com>
6548
6549         * gdbarch.h, gdbarch.c: Rebuild.
6550         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6551         * stap-probe.h:
6552         (struct stap_parse_info): Replace "parser_state" with
6553         "expr_builder".
6554         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6555         (parser_state): New class.
6556         * parse.c (expr_builder): Rename.
6557         (expr_builder::release): Rename.
6558         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6559         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6560         (write_exp_elt_longcst, write_exp_elt_floatcst)
6561         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6562         (write_exp_string_vector, write_exp_bitstring)
6563         (write_exp_msymbol, mark_struct_expression)
6564         (write_dollar_variable)
6565         (insert_type_address_space, increase_expout_size): Replace
6566         "parser_state" with "expr_builder".
6567         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6568         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6569         "parser_state" with "expr_builder".
6570
6571 2019-04-04  Tom Tromey  <tom@tromey.com>
6572
6573         * rust-exp.y: Replace "parse_language" with method call.
6574         * p-exp.y:
6575         (yylex): Replace "parse_language" with method call.
6576         * m2-exp.y:
6577         (yylex): Replace "parse_language" with method call.
6578         * go-exp.y (classify_name): Replace "parse_language" with method
6579         call.
6580         * f-exp.y (yylex): Replace "parse_language" with method call.
6581         * d-exp.y (lex_one_token): Replace "parse_language" with method
6582         call.
6583         * c-exp.y:
6584         (lex_one_token, classify_name, yylex): Replace "parse_language"
6585         with method call.
6586         * ada-exp.y (find_primitive_type, type_char)
6587         (type_system_address): Replace "parse_language" with method call.
6588
6589 2019-04-04  Tom Tromey  <tom@tromey.com>
6590
6591         * rust-exp.y: Replace "parse_gdbarch" with method call.
6592         * parse.c (write_dollar_variable, insert_type_address_space):
6593         Replace "parse_gdbarch" with method call.
6594         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6595         call.
6596         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6597         call.
6598         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6599         "parse_gdbarch" with method call.
6600         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6601         with method call.
6602         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6603         "parse_gdbarch" with method call.
6604         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6605         "parse_gdbarch" with method call.
6606         * c-exp.y (parse_type, parse_number, classify_name): Replace
6607         "parse_gdbarch" with method call.
6608         * ada-lex.l: Replace "parse_gdbarch" with method call.
6609         * ada-exp.y (parse_type, find_primitive_type, type_char)
6610         (type_system_address): Replace "parse_gdbarch" with method call.
6611
6612 2019-04-04  Tom Tromey  <tom@tromey.com>
6613
6614         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6615         * stap-probe.c (stap_parse_argument): Update.
6616         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6617         initial_size parameter.
6618         * rust-exp.y (rust_lex_tests): Update.
6619         * parse.c (parser_state): Update.
6620         (parse_exp_in_context): Update.
6621         * parser-defs.h (struct parser_state) <parser_state>: Remove
6622         "initial_size" parameter.
6623
6624 2019-04-04  Tom Tromey  <tom@tromey.com>
6625
6626         * parser-defs.h (increase_expout_size): Don't declare.
6627         * parse.c (increase_expout_size): Now static.
6628
6629 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6630
6631         * gnu-nat.c (gnu_nat_target::wait): Fix
6632         target_waitstatus_to_string call.
6633
6634 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * eval.c (evaluate_subexp_standard): Handle internal functions
6637         during Fortran function call handling.
6638
6639 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6640
6641         * NEWS: Mention new internal functions.
6642         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6643         (read_base_type): Use dwarf2_init_complex_target_type.
6644         * value.c (creal_internal_fn): New function.
6645         (cimag_internal_fn): New function.
6646         (_initialize_values): Register new internal functions.
6647
6648 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6649
6650         * infrun.c (stop_all_threads): If debug_infrun, always
6651         trace the wait status after wait_one, using
6652         target_waitstatus_to_string and target_pid_to_str.
6653         (handle_inferior_event): Replace various trace of
6654         wait status kind by a single trace.
6655         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6656         wait status kind image by target_waitstatus_to_string.
6657         * target/waitstatus.c (target_waitstatus_to_string): Fix
6658         obsolete comment.
6659
6660 2019-04-01  Tom Tromey  <tromey@adacore.com>
6661
6662         PR symtab/23331:
6663         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6664
6665 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6666             Pedro Alves  <palves@redhat.com>
6667
6668         * top.c (quit_force): Call 'finalize_values'.
6669         * value.c (finalize_values): New function.
6670         * value.h (finalize_values): Declare.
6671
6672 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6673
6674         * NEWS: Announce $_gdb_major and $_gdb_minor.
6675
6676         * top.c (init_gdb_version_vars): New function.
6677         (gdb_init): Call init_gdb_version_vars.
6678
6679 2019-03-29  Tom Tromey  <tromey@adacore.com>
6680
6681         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6682         help text.  Remove dead code.
6683
6684 2019-03-29  Keith Seitz  <keiths@redhat.com>
6685
6686         From Siddhesh Poyarekar:
6687         * f-lang.h (f77_get_upperbound): Return LONGEST.
6688         (f77_get_lowerbound): Likewise.
6689         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6690         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6691         print them.
6692         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6693         plongest to format print it.
6694         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6695         (f77_get_upperbound): Likewise.
6696         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6697         LOWER_BOUND to LONGEST.
6698         (f77_create_arrayprint_offset_tbl): Likewise.
6699
6700 2019-03-29  Keith Seitz  <keiths@redhat.com>
6701
6702         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6703         %s/pulongest for TYPE_LENGTH instead of %d in format
6704         strings.
6705         * ada-typerint.c (ada_print_type): Likewise.
6706         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6707         * compile/compile-c-support.c (generate_register_struct): Likewise.
6708         * gdbtypes.c (recursive_dump_type): Likewise.
6709         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6710         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6711         instead of %d in format strings.
6712         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6713         to std::min to ULONGEST.
6714         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6715         instead of %d in format strings.
6716         * tracepoint.c (info_scope_command): Likewise.
6717         * typeprint.c (print_offset_data::update)
6718         (print_offset_data::finish): Likewise.
6719         * xtensa-tdep.c (xtensa_store_return_value)
6720         (xtensa_push_dummy_call): Likewise.
6721
6722 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6723
6724         * windows-nat.c (display_selector): Fixed format specifications
6725         for 64-bit Cygwin.
6726
6727 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6728
6729         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6730
6731 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6732
6733         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6734         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6735         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6736         (nios2_linux_init_abi): Install it.
6737
6738 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6739
6740         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6741
6742 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6743
6744         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6745
6746 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6747             Tom Tromey  <tromey@adacore.com>
6748
6749         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6750
6751 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6752
6753         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6754         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6755         method to compute the bounds of range types. Also print "[evaluated]"
6756         if the bounds' values come from a dynamic evaluation.
6757
6758 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6759
6760         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6761         whitespace when pretty printing is on.
6762
6763 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6764
6765         * ppc-linux-nat.c: Add include.
6766
6767 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6768
6769         * NEWS: Mention AArch64 Pointer Authentication.
6770
6771 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6772
6773         * arm-linux-nat.c: Add include.
6774
6775 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6776
6777         * source-cache.c (source_cache::get_source_lines): Re-read
6778         fullname after calling open_source_file.
6779
6780 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6781
6782         * NEWS: Mention TLS support for FreeBSD.
6783
6784 2019-03-25  Tom Tromey  <tromey@adacore.com>
6785
6786         * minsyms.c (BUNCH_SIZE): Update comment.
6787         (~minimal_symbol_reader): Remove old comment.
6788         (compact_minimal_symbols): Update comment.
6789         (minimal_symbol_reader::install): Remove old comment.  Update
6790         other comments.
6791
6792 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6793
6794         * s390-linux-nat.c: Add include.
6795
6796 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6797
6798         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6799         Call linux_get_hwcap.
6800         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6801         Likewise.
6802         (aarch64_linux_get_hwcap): Remove function.
6803         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6804         declaration.
6805         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6806         linux_get_hwcap.
6807         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6808         * linux-tdep.c (linux_get_hwcap): Add function.
6809         (linux_get_hwcap2): Likewise.
6810         * linux-tdep.h (linux_get_hwcap): Add declaration.
6811         (linux_get_hwcap2): Likewise.
6812         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6813         (ppc_linux_get_hwcap2): Likewise.
6814         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6815         linux_get_hwcap.
6816         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6817         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6818         (ppc_linux_nat_target::read_description): Likewise.
6819         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6820         * s390-linux-nat.c: Likewise.
6821         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6822
6823 2019-03-24  Tom Tromey  <tom@tromey.com>
6824
6825         * ada-lang.c (standard_lookup): Simplify initialization.
6826         (ada_lookup_symbol_nonlocal): Simplify return.
6827         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6828         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6829         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6830         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6831         initialization.
6832         * solib.c (solib_global_lookup): Simplify.
6833         * symtab.c (null_block_symbol): Remove.
6834         (symbol_cache_lookup): Simplify returns.
6835         (lookup_language_this): Simplify returns.
6836         (lookup_symbol_aux): Simplify return.
6837         (lookup_local_symbol): Simplify returns.
6838         (lookup_global_symbol_from_objfile): Simplify return.
6839         (lookup_symbol_in_objfile_symtabs)
6840         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6841         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6842         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6843         * cp-namespace.c (cp_lookup_bare_symbol)
6844         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6845         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6846         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6847         (cp_lookup_symbol_via_imports): Simplify initialization.
6848         (find_symbol_in_baseclass): Likewise.
6849         * symtab.h (null_block_symbol): Remove.
6850         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6851         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6852         (d_lookup_symbol_module): Likewise.
6853         (find_symbol_in_baseclass): Simplify initialization.
6854
6855 2019-03-24  Tom Tromey  <tom@tromey.com>
6856
6857         * expression.h: Don't include symtab.h.
6858         (struct block): Forward declare.
6859
6860 2019-03-24  Tom Tromey  <tom@tromey.com>
6861
6862         * c-exp.y (typebase): Remove casts.
6863         * gdbtypes.c (lookup_unsigned_typename, )
6864         (lookup_signed_typename): Remove cast.
6865         * eval.c (parse_to_comma_and_eval): Remove cast.
6866         * parse.c (write_dollar_variable): Remove cast.
6867         * block.h (struct block) <superblock>: Now const.
6868         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6869         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6870         (map_block): Make "block" const.
6871         * symfile.h (struct quick_symbol_functions)
6872         <map_matching_symbols>: Constify block argument to "callback".
6873         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6874         const.
6875         (find_pc_sect_compunit_symtab): Make "b" const.
6876         (find_symbol_at_address): Likewise.
6877         (search_symbols): Likewise.
6878         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6879         (dw2_debug_names_lookup_symbol): Likewise.
6880         (dw2_map_matching_symbols): Update.
6881         * p-valprint.c (pascal_val_print): Remove "block".
6882         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6883         (aux_add_nonlocal_symbols): Make "block" const.
6884         (resolve_subexp): Remove cast.
6885         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6886         const.
6887         (iterate_over_file_blocks): Likewise.
6888         * f-exp.y (%union) <bval>: Remove.
6889         * coffread.c (patch_opaque_types): Make "b" const.
6890         * spu-tdep.c (spu_catch_start): Make "block" const.
6891         * c-valprint.c (print_unpacked_pointer): Remove "block".
6892         * symmisc.c (dump_symtab_1): Make "b" const.
6893         (block_depth): Make "block" const.
6894         * d-exp.y (%union) <bval>: Remove.
6895         * cp-support.h (cp_lookup_rtti_type): Update.
6896         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6897         * psymtab.c (psym_lookup_symbol): Make "block" const.
6898         (maintenance_check_psymtabs): Make "b" const.
6899         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6900         (enumerate_locals, enumerate_args): Update.
6901         * python/py-symtab.c (stpy_global_block): Make "block" const.
6902         (stpy_static_block): Likewise.
6903         * inline-frame.c (block_starting_point_at): Make "new_block"
6904         const.
6905         * block.c (find_block_in_blockvector): Make return type const.
6906         (blockvector_for_pc_sect): Make "b" const.
6907         (find_block_in_blockvector): Make "b" const.
6908
6909 2019-03-23  Tom Tromey  <tom@tromey.com>
6910
6911         * varobj.c (varobj_create): Update.
6912         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6913         * printcmd.c (display_command, do_one_display): Don't reset
6914         innermost_block.
6915         * parser-defs.h (enum innermost_block_tracker_type): Move to
6916         expression.h.
6917         (innermost_block): Update comment.
6918         * parse.c (parse_exp_1): Add tracker_types parameter.
6919         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6920         tracker_types parameter.  Reset innermost_block.
6921         (parse_exp_in_context): Remove.
6922         (parse_expression_for_completion): Update.
6923         * objfiles.c (~objfile): Don't reset expression_context_block or
6924         innermost_block.
6925         * expression.h (enum innermost_block_tracker_type): Move from
6926         parser-defs.h.
6927         (parse_exp_1): Add tracker_types parameter.
6928         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6929         reset innermost_block.
6930
6931 2019-03-23  Tom Tromey  <tom@tromey.com>
6932
6933         * objfiles.h: Include bcache.h.
6934
6935 2019-03-23  Tom Tromey  <tom@tromey.com>
6936
6937         * linespec.c (get_current_search_block): Use
6938         scoped_restore_current_language.
6939         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6940
6941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6942             Jiong Wang  <jiong.wang@arm.com>
6943
6944         * aarch64-linux-tdep.c
6945         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6946         section.
6947         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6948
6949 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6950             Jiong Wang  <jiong.wang@arm.com>
6951
6952         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6953         instructions.
6954         (aarch64_analyze_prologue_test): Add PACIASP test.
6955         (aarch64_prologue_prev_register): Unmask PC value.
6956
6957 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6958             Jiong Wang  <jiong.wang@arm.com>
6959
6960         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6961         (aarch64_dwarf2_prev_register): Unmask PC value.
6962         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6963         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6964         DW_CFA_AARCH64_negate_ra_state.
6965         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6966
6967 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6968             Jiong Wang  <jiong.wang@arm.com>
6969
6970         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6971         registers.
6972         (aarch64_pseudo_register_name): Likewise.
6973         (aarch64_pseudo_register_type): Likewise.
6974         (aarch64_pseudo_register_reggroup_p): Likewise.
6975         (aarch64_gdbarch_init): Add pauth registers.
6976         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6977         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6978         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6979         (struct gdbarch_tdep): Add regnum for ra_state.
6980
6981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6982             Jiong Wang  <jiong.wang@arm.com>
6983
6984         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6985
6986 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6987             Jiong Wang  <jiong.wang@arm.com>
6988
6989         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6990         function.
6991         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6992         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6993         (aarch64_gdbarch_init): Add puth registers.
6994         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6995         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6996         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6997
6998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6999             Jiong Wang  <jiong.wang@arm.com>
7000
7001         * aarch64-linux-nat.c
7002         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7003         * aarch64-linux-tdep.c
7004         (aarch64_linux_core_read_description): Likewise.
7005         (aarch64_linux_get_hwcap): New function.
7006         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7007         (aarch64_linux_get_hwcap): New declaration.
7008
7009 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7010             Jiong Wang  <jiong.wang@arm.com>
7011
7012         * aarch64-linux-nat.c
7013         (aarch64_linux_nat_target::read_description): Add pauth param.
7014         * aarch64-linux-tdep.c
7015         (aarch64_linux_core_read_description): Likewise.
7016         * aarch64-tdep.c (struct target_desc): Add in pauth.
7017         (aarch64_read_description): Add pauth param.
7018         (aarch64_gdbarch_init): Likewise.
7019         * aarch64-tdep.h (aarch64_read_description): Likewise.
7020         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7021         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7022         * features/Makefile: Add new files.
7023         * features/aarch64-pauth.c: New file.
7024         * features/aarch64-pauth.xml: New file.
7025
7026 2019-03-20  Tom Tromey  <tromey@adacore.com>
7027
7028         * infrun.c (handle_inferior_event): Rename from
7029         handle_inferior_event_1.  Create a scoped_value_mark.
7030         (handle_inferior_event): Remove.
7031
7032 2019-03-19  Tom Tromey  <tromey@adacore.com>
7033
7034         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7035         * infrun.h (print_stop_event): Add "displays" parameter.
7036         * infrun.c (print_stop_event): Add "displays" parameter.
7037
7038 2019-03-19  Pedro Alves  <palves@redhat.com>
7039
7040         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7041         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7042         to -1.  Fix TABs vs spaces.
7043         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7044         * tui/tui-out.h (tui_ui_out) Add intro comments.
7045         <m_line, m_start_of_line>: In-class initialize, and add describing
7046         comment.
7047
7048 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7049
7050         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7051         variable names.
7052         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7053
7054 2019-03-18  Pedro Alves  <palves@redhat.com>
7055             Eli Zaretskii <eliz@gnu.org>
7056
7057         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7058         m_line and m_start_of_line.
7059
7060 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7061
7062         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7063         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7064         it returns a newline.  This fixes a regression in TU mode, whereby
7065         the next line is output on the same screen line as the user input.
7066
7067 2019-03-18  Tom Tromey  <tromey@adacore.com>
7068
7069         * minsyms.c (minimal_symbol_reader::install): Remove call to
7070         obstack_blank.
7071
7072 2019-03-18  Pedro Alves  <palves@redhat.com>
7073
7074         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7075         New globals.
7076         (apply_style): New, factored out from ...
7077         (apply_ansi_escape): ... this.  Handle reverse video mode.
7078         (tui_set_reverse_mode): New function.
7079         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7080         * tui/tui-winsource.c (tui_show_source_line): Use
7081         tui_set_reverse_mode instead of setting A_STANDOUT.
7082         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7083         New setter methods.
7084
7085 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7086
7087         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7088         Handle tabs.
7089
7090 2019-03-18  Tom Tromey  <tromey@adacore.com>
7091
7092         * ada-lang.c (empty_array): Add "high" parameter.
7093         (ada_evaluate_subexp): Update.
7094
7095 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7096
7097         * unittests/string_view-selftests.c: Define
7098         _initialize_string_view_selftests unconditionally.
7099
7100 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7101
7102         PR gdb/24350
7103         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7104
7105 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7106
7107         PR gdb/24351
7108         * windows-nat.c (display_selector): Fix format specifiers.
7109
7110 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7111
7112         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7113         tui_refill_source_window instead of tui_refresh_win, to update the
7114         current execution line.  This fixes redisplay of the current line
7115         when stepping through the code with "next" or "step".
7116
7117 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7118
7119         * source-cache.c (source_cache::get_source_lines): Call
7120         find_source_lines to initialize s->nlines.  This fixes vertical
7121         scrolling of TUI source window when the DOWN arrow is pressed.
7122
7123 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7124
7125         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7126         linux-thread-db.c (_initialize_thread_db): Likewise.
7127
7128 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7129
7130         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7131         wclrtoeol in tui_show_source_line".  This reverts changes made in
7132         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7133
7134 2019-03-15  Tom Tromey  <tom@tromey.com>
7135
7136         * symtab.h (struct minimal_symbol): Derive from
7137         general_symbol_info.
7138         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7139         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7140         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7141         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7142         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7143         (MSYMBOL_SEARCH_NAME): Update.
7144         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7145         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7146         * minsyms.c (minimal_symbol_reader::record_full): Update.
7147
7148 2019-03-15  Tom Tromey  <tom@tromey.com>
7149
7150         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7151
7152 2019-03-15  Tom Tromey  <tom@tromey.com>
7153
7154         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7155         unique_xmalloc_ptr.
7156         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7157         Update.
7158         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7159         (build_minimal_symbol_hash_tables)
7160         (minimal_symbol_reader::install): Update.
7161
7162 2019-03-15  Tom Tromey  <tom@tromey.com>
7163
7164         * symtab.c (create_demangled_names_hash): Update.
7165         (symbol_set_names): Update.
7166         * objfiles.h (struct objfile_per_bfd_storage)
7167         <demangled_names_hash>: Now an htab_up.
7168         * objfiles.c (objfile_per_bfd_storage): Simplify.
7169
7170 2019-03-15  Tom Tromey  <tom@tromey.com>
7171
7172         * objfiles.h (struct objfile_per_bfd_storage): Declare
7173         destructor.
7174         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7175         New.
7176         (get_objfile_bfd_data): Use new.  Don't initialize
7177         language_of_main.
7178         (free_objfile_per_bfd_storage): Remove.
7179         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7180
7181 2019-03-15  Tom Tromey  <tom@tromey.com>
7182
7183         * symfile.c (reread_symbols): Update.
7184         * objfiles.c (objfile::objfile): Update.
7185         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7186         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7187         comment.
7188         (minimal_symbol_reader::install): Update.
7189         (terminate_minimal_symbol_table): Remove.
7190         * jit.c (jit_object_close_impl): Update.
7191
7192 2019-03-15  Tom Tromey  <tom@tromey.com>
7193
7194         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7195         initializations.
7196
7197 2019-03-15  Tom Tromey  <tom@tromey.com>
7198
7199         * objfiles.h (struct objfile_per_bfd_storage)
7200         <demangled_hash_languages>: Now a bitset.
7201         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7202         (lookup_minimal_symbol): Update.
7203
7204 2019-03-15  Tom Tromey  <tom@tromey.com>
7205
7206         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7207         Don't return the symbol.
7208         * coffread.c (record_minimal_symbol): Use record_full.
7209
7210 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7211
7212         The MS-Windows port of ncurses fails to switch to a color pair if
7213         one or both of the colors are the implicit default colors.  This
7214         change records the default colors when TUI is initialized, and
7215         then specifies them explicitly when a color pair uses the default
7216         colors.  This allows color styling in TUI mode on MS-Windows.
7217
7218         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7219         ncurses_norm_attr.
7220         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7221         colors in ncurses_norm_attr.
7222         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7223         "none", replace it with the default color recorded in
7224         ncurses_norm_attr.
7225
7226 2019-03-14  Tom Tromey  <tromey@adacore.com>
7227
7228         * source-cache.h (class source_cache) <get_source_lines>: Return
7229         std::string.
7230         * source-cache.c (source_cache::extract_lines): Handle case where
7231         first_pos==npos.  Return std::string.
7232         (source_cache::get_source_lines): Update.
7233
7234 2019-03-14  Tom Tromey  <tromey@adacore.com>
7235
7236         * NEWS: Add item for "style sources" commands.
7237         * source-cache.c (source_cache::get_source_lines): Check
7238         source_styling.
7239         * cli/cli-style.c (source_styling): New global.
7240         (_initialize_cli_style): Add "style sources" commands.
7241         (show_style_sources): New function.
7242         * cli/cli-style.h (source_styling): Declare.
7243
7244 2019-03-14  Pedro Alves  <palves@redhat.com>
7245             Tom Tromey  <tromey@adacore.com>
7246
7247         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7248         * tui/tui-winsource.c (tui_refill_source_window): New function,
7249         from...
7250         (tui_horizontal_source_scroll): ... here.  Move some logic.
7251         * cli/cli-style.c (set_style_enabled): Notify new observable.
7252         * tui/tui-hooks.c (tui_redisplay_source): New function.
7253         (tui_attach_detach_observers): Attach or detach
7254         tui_redisplay_source.
7255         * observable.h (source_styling_changed): New observable.
7256         * observable.c: Define source_styling_changed observable.
7257
7258 2019-03-13  Tom Tromey  <tromey@adacore.com>
7259
7260         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7261         (i386_gnu_nat_target::store_registers): Update.
7262         * target-debug.h (target_debug_print_std_string): New macro.
7263         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7264         * windows-tdep.c (display_one_tib): Update.
7265         * tui/tui-stack.c (tui_make_status_line): Update.
7266         * top.c (print_inferior_quit_action): Update.
7267         * thread.c (thr_try_catch_cmd): Update.
7268         (add_thread_with_info): Update.
7269         (thread_target_id_str): Update.
7270         (thr_try_catch_cmd): Update.
7271         (thread_command): Update.
7272         (thread_find_command): Update.
7273         * record-btrace.c (record_btrace_target::info_record)
7274         (record_btrace_resume_thread, record_btrace_target::resume)
7275         (record_btrace_cancel_resume, record_btrace_step_thread)
7276         (record_btrace_target::wait, record_btrace_target::wait)
7277         (record_btrace_target::wait, record_btrace_target::stop): Update.
7278         * progspace.c (print_program_space): Update.
7279         * process-stratum-target.c
7280         (process_stratum_target::thread_address_space): Update.
7281         * linux-fork.c (linux_fork_mourn_inferior)
7282         (detach_checkpoint_command, info_checkpoints_command)
7283         (linux_fork_context): Update.
7284         (linux_fork_detach): Update.
7285         (class scoped_switch_fork_info): Update.
7286         (delete_checkpoint_command): Update.
7287         * infrun.c (follow_fork_inferior): Update.
7288         (follow_fork_inferior): Update.
7289         (proceed_after_vfork_done): Update.
7290         (handle_vfork_child_exec_or_exit): Update.
7291         (follow_exec): Update.
7292         (displaced_step_prepare_throw): Update.
7293         (displaced_step_restore): Update.
7294         (start_step_over): Update.
7295         (resume_1): Update.
7296         (clear_proceed_status_thread): Update.
7297         (proceed): Update.
7298         (print_target_wait_results): Update.
7299         (do_target_wait): Update.
7300         (context_switch): Update.
7301         (stop_all_threads): Update.
7302         (restart_threads): Update.
7303         (finish_step_over): Update.
7304         (handle_signal_stop): Update.
7305         (switch_back_to_stepped_thread): Update.
7306         (keep_going_pass_signal): Update.
7307         (print_exited_reason): Update.
7308         (normal_stop): Update.
7309         * inferior.c (inferior_pid_to_str): Change return type.
7310         (print_selected_inferior): Update.
7311         (add_inferior): Update.
7312         (detach_inferior): Update.
7313         * dummy-frame.c (fprint_dummy_frames): Update.
7314         * dcache.c (dcache_info_1): Update.
7315         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7316         (btrace_fetch, btrace_clear): Update.
7317         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7318         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7319         type.
7320         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7321         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7322         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7323         * gdbarch.c, gdbarch.h: Rebuild.
7324         * gdbarch.sh (core_pid_to_str): Change return type.
7325         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7326         return type.
7327         (windows_nat_target::pid_to_str): Change return type.
7328         (windows_delete_thread): Update.
7329         (windows_nat_target::attach): Update.
7330         (windows_nat_target::files_info): Update.
7331         * target-delegates.c: Rebuild.
7332         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7333         return type.
7334         (sol_thread_target::pid_to_str): Change return type.
7335         * remote.c (class remote_target) <pid_to_str>: Change return
7336         type.
7337         (remote_target::pid_to_str): Change return type.
7338         (extended_remote_target::attach, remote_target::remote_stop_ns)
7339         (remote_target::remote_notif_remove_queued_reply)
7340         (remote_target::push_stop_reply, remote_target::disable_btrace):
7341         Update.
7342         (extended_remote_target::attach): Update.
7343         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7344         type.
7345         (gdbsim_target::pid_to_str): Change return type.
7346         * ravenscar-thread.c (struct ravenscar_thread_target)
7347         <pid_to_str>: Change return type.
7348         (ravenscar_thread_target::pid_to_str): Change return type.
7349         * procfs.c (class procfs_target) <pid_to_str>: Change return
7350         type.
7351         (procfs_target::pid_to_str): Change return type.
7352         (procfs_target::attach): Update.
7353         (procfs_target::detach): Update.
7354         (procfs_target::fetch_registers): Update.
7355         (procfs_target::store_registers): Update.
7356         (procfs_target::wait): Update.
7357         (procfs_target::files_info): Update.
7358         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7359         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7360         return type.
7361         (nto_procfs_target::pid_to_str): Change return type.
7362         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7363         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7364         return type.
7365         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7366         (exit_lwp): Update.
7367         (attach_proc_task_lwp_callback, get_detach_signal)
7368         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7369         (linux_nat_target::resume, wait_lwp, stop_callback)
7370         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7371         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7372         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7373         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7374         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7375         type.
7376         (inf_ptrace_target::attach): Update.
7377         (inf_ptrace_target::files_info): Update.
7378         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7379         type.
7380         (go32_nat_target::pid_to_str): Change return type.
7381         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7382         (gnu_nat_target::wait): Update.
7383         (gnu_nat_target::wait): Update.
7384         (gnu_nat_target::resume): Update.
7385         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7386         (fbsd_nat_target::wait): Update.
7387         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7388         type.
7389         (darwin_nat_target::attach): Update.
7390         * corelow.c (class core_target) <pid_to_str>: Change return type.
7391         (core_target::pid_to_str): Change return type.
7392         * target.c (normal_pid_to_str): Change return type.
7393         (default_pid_to_str): Likewise.
7394         (target_pid_to_str): Change return type.
7395         (target_translate_tls_address): Update.
7396         (target_announce_detach): Update.
7397         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7398         return type.
7399         (bsd_uthread_target::pid_to_str): Change return type.
7400         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7401         type.
7402         (bsd_kvm_target::pid_to_str): Change return type.
7403         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7404         return type.
7405         (aix_thread_target::pid_to_str): Change return type.
7406         * target.h (struct target_ops) <pid_to_str>: Change return type.
7407         (target_pid_to_str, normal_pid_to_str): Likewise.
7408         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7409         type.
7410         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7411         type.
7412         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7413         return type.
7414         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7415         type.
7416         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7417         type.
7418         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7419         return type.
7420
7421 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7422
7423         * NEWS: Mention that the new default MI version is 3.  Mention
7424         changes to the output of commands and events that deal with
7425         multi-location breakpoints.
7426         * breakpoint.c: Include "mi/mi-out.h".
7427         (print_one_breakpoint): Change output syntax if using MI version
7428         >= 3.
7429         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7430         New.
7431         (mi_multi_location_breakpoint_output_fixed): New.
7432         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7433         (mi_cmd_fix_multi_location_breakpoint_output): New.
7434         (mi_multi_location_breakpoint_output_fixed): New.
7435         * mi/mi-cmds.c (mi_cmds): Register command
7436         -fix-multi-location-breakpoint-output.
7437         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7438         interpreter "mi".
7439
7440 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7441
7442         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7443         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7444         instantiate mi_ui_out based on interpreter name.
7445         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7446         * mi/mi-main.c (mi_load_progress): Likewise.
7447
7448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7449
7450         * NEWS: Combine separate "New targets" sections for 8.3.
7451
7452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7453
7454         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7455         (ppcfbsd_init_abi): Install gdbarch
7456         "fetch_tls_load_module_address" and "get_thread_local_address"
7457         methods.
7458
7459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7460
7461         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7462         (riscv_fbsd_init_abi): Install gdbarch
7463         "fetch_tls_load_module_address" and "get_thread_local_address"
7464         methods.
7465
7466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7467
7468         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7469         (i386fbsd_init_abi): Install gdbarch
7470         "fetch_tls_load_module_address" and "get_thread_local_address"
7471         methods.
7472
7473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7474
7475         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7476         (amd64fbsd_init_abi): Install gdbarch
7477         "fetch_tls_load_module_address" and "get_thread_local_address"
7478         methods.
7479
7480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7481
7482         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7483         (struct fbsd_pspace_data): New type.
7484         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7485         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7486         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7487         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7488         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7489
7490 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7491
7492         * gdbtypes.c (lookup_struct_elt): New function.
7493         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7494         * gdbtypes.h (struct struct_elt): New type.
7495         (lookup_struct_elt): New prototype.
7496
7497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7498
7499         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7500         remove disabled code block.
7501
7502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7503
7504         * gdbarch.sh (get_thread_local_address): New method.
7505         * gdbarch.h, gdbarch.c: Regenerate.
7506         * target.c (target_translate_tls_address): Use
7507         gdbarch_get_thread_local_address if present instead of
7508         target::get_thread_local_address.
7509
7510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7511
7512         * target.h (target::get_thread_local_address): Update comment.
7513
7514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7515
7516         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7517         objfile->separate_debug_objfile_backlink if not NULL.
7518
7519 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7520
7521         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7522         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7523         (amd64bsd_store_inferior_registers): Likewise.
7524         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7525         Enable segment base registers.
7526         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7527         PT_GETFSBASE and PT_GETGSBASE.
7528         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7529         PT_SETGSBASE.
7530         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7531         segment base registers.
7532         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7533
7534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7535
7536         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7537         Update calls to i386_target_description to add 'segments'
7538         parameter.
7539         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7540         add segment base registers.
7541         * arch/i386.c (i386_create_target_description): Add 'segments'
7542         parameter to enable segment base registers.
7543         * arch/i386.h (i386_create_target_description): Likewise.
7544         * features/i386/32bit-segments.xml: New file.
7545         * features/i386/32bit-segments.c: Generate.
7546         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7547         call to i386_target_description to add 'segments' parameter.
7548         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7549         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7550         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7551         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7552         if feature is present.
7553         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7554         Add 'segments' parameter to call to i386_target_description.
7555         (i386_target_description): Add 'segments' parameter to enable
7556         segment base registers.
7557         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7558         to call to i386_target_description.
7559         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7560         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7561         Define I386_NUM_REGS.
7562         (i386_target_description): Add 'segments' parameter to enable
7563         segment base registers.
7564
7565 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7566
7567         PR/24325
7568         * source-cache.c: #undef open and close, to avoid unresolved
7569         externals during linking.
7570
7571 2019-03-12  Tom Tromey  <tromey@adacore.com>
7572
7573         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7574         const.  Add initializers.
7575         (_initialize_remote): Don't initialize ptid globals.
7576
7577 2019-03-12  Pedro Alves  <palves@redhat.com>
7578
7579         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7580
7581 2019-03-12  Pedro Alves  <palves@redhat.com>
7582
7583         * cp-name-parser.y (main): Remove unused 'len' variable.
7584
7585 2019-03-12  Tom Tromey  <tromey@adacore.com>
7586
7587         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7588         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7589
7590 2019-03-12  Tom Tromey  <tromey@adacore.com>
7591
7592         * linux-nat.c (iterate_over_lwps): Update.
7593         (stop_callback): Remove parameter.
7594         (stop_wait_callback, detach_callback, resume_set_callback)
7595         (select_singlestep_lwp_callback, set_ignore_sigint)
7596         (status_callback, resumed_callback, resume_clear_callback)
7597         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7598         data parameter.
7599         (linux_nat_target::detach, linux_nat_target::resume)
7600         (linux_stop_and_wait_all_lwps, select_event_lwp)
7601         (linux_nat_filter_event, linux_nat_wait_1)
7602         (linux_nat_target::kill, linux_nat_target::stop)
7603         (linux_nat_target::stop): Update.
7604         (linux_nat_resume_callback): Change type.
7605         (resume_stopped_resumed_lwps, count_events_callback)
7606         (select_event_lwp_callback): Likewise.
7607         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7608         * arm-linux-nat.c (struct update_registers_data): Remove.
7609         (update_registers_callback): Change type.
7610         (arm_linux_insert_hw_breakpoint1): Update.
7611         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7612         parameter.
7613         (x86_linux_dr_set_addr): Update.
7614         (x86_linux_dr_set_control): Update.
7615         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7616         (iterate_over_lwps): Use gdb::function_view.
7617         * nat/aarch64-linux-hw-point.c (struct
7618         aarch64_dr_update_callback_param): Remove.
7619         (debug_reg_change_callback): Change type.
7620         (aarch64_notify_debug_reg_change): Update.
7621         * s390-linux-nat.c (s390_refresh_per_info): Update.
7622
7623 2019-03-11  Tom Tromey  <tromey@adacore.com>
7624
7625         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7626         redundant assignment to "this_cu".
7627
7628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7629
7630         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7631
7632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7633
7634         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7635         from...
7636         (rank_one_type): ... this.
7637
7638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7639
7640         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7641         from...
7642         (rank_one_type): ... this.
7643
7644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7645
7646         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7647         from...
7648         (rank_one_type): ... this.
7649
7650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7651
7652         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7653         from...
7654         (rank_one_type): ... this.
7655
7656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7657
7658         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7659         from...
7660         (rank_one_type): ... this.
7661
7662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7663
7664         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7665         from...
7666         (rank_one_type): ... this.
7667
7668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7669
7670         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7671         from...
7672         (rank_one_type): ... this.
7673
7674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7675
7676         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7677         from...
7678         (rank_one_type): ... this.
7679
7680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7681
7682         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7683         from...
7684         (rank_one_type): ... this.
7685
7686 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7687
7688         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7689         from...
7690         (rank_one_type): ... this.
7691
7692 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7693
7694         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7695         from...
7696         (rank_one_type): ... this.
7697
7698 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7699
7700         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7701         from...
7702         (rank_one_type): ... this.
7703
7704 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7705
7706         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7707         inferior-events' shows the example events.
7708
7709 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7710
7711         Support styling on native MS-Windows console
7712
7713         PR/24315
7714         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7715         on MS-Windows if $TERM is not defined.
7716
7717         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7718
7719         * posix-hdep.c (gdb_console_fputs):
7720         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7721         functions.
7722         * ui-file.h (gdb_console_fputs): Add prototype.
7723
7724         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7725         back to fputs only if the former returns zero.
7726
7727 2019-03-07  Tom Tromey  <tom@tromey.com>
7728
7729         * symmisc.c (print_symbol_bcache_statistics): Update.
7730         (print_objfile_statistics): Update.
7731         * symfile.c (allocate_symtab): Update.
7732         * stabsread.c: Don't include bcache.h.
7733         * psymtab.h (struct psymbol_bcache): Don't declare.
7734         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7735         (psymbol_bcache_init, psymbol_bcache_free)
7736         (psymbol_bcache_get_bcache): Don't declare.
7737         * psymtab.c (struct psymbol_bcache): Remove.
7738         (psymtab_storage::psymtab_storage): Update.
7739         (psymtab_storage::~psymtab_storage): Update.
7740         (psymbol_bcache_init, psymbol_bcache_free)
7741         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7742         (add_psymbol_to_bcache): Update.
7743         (allocate_psymtab): Update.
7744         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7745         macro_cache>: No longer pointers.
7746         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7747         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7748         * macrotab.c (macro_bcache): Update.
7749         * macroexp.c: Don't include bcache.h.
7750         * gdbtypes.c (check_types_worklist): Update.
7751         (types_deeply_equal): Remove TRY/CATCH.  Update.
7752         * elfread.c (elf_symtab_read): Update.
7753         * dwarf2read.c: Don't include bcache.h.
7754         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7755         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7756         (print_bcache_statistics, bcache_memory_used): Don't declare.
7757         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7758         methods.  Rename all data members.
7759         * bcache.c (struct bcache): Move to bcache.h.
7760         (bcache::expand_hash_table): Rename from expand_hash_table.
7761         (bcache): Remove.
7762         (bcache::insert): Rename from bcache_full.
7763         (bcache::compare): Rename from bcache_compare.
7764         (bcache_xmalloc): Remove.
7765         (bcache::~bcache): Rename from bcache_xfree.
7766         (bcache::print_statistics): Rename from print_bcache_statistics.
7767         (bcache::memory_used): Rename from bcache_memory_used.
7768
7769 2019-03-07  Pedro Alves  <palves@redhat.com>
7770
7771         * infrun.c (normal_stop): Also check for
7772         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7773
7774 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * f-lang.c (value_from_host_double): Moved to...
7777         * value.c (value_from_host_double): ...here.
7778         * value.h (value_from_host_double): Declare.
7779         * guile/scm-math.c (vlscm_convert_typed_number): Use
7780         value_from_host_double.
7781         (vlscm_convert_number): Likewise.
7782         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7783         * python/py-value.c (convert_value_from_python): Likewise.
7784
7785 2019-03-06  Tom Tromey  <tom@tromey.com>
7786
7787         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7788
7789 2019-03-06  Tom Tromey  <tom@tromey.com>
7790
7791         * utils.h (free_current_contents): Don't declare.
7792         * utils.c (free_current_contents): Remove.
7793
7794 2019-03-06  Tom Tromey  <tom@tromey.com>
7795
7796         * top.c (quit_force): Update.
7797         * main.c (captured_command_loop): Update.
7798         * common/new-op.c (operator new): Update.
7799         * common/common-exceptions.c (struct catcher)
7800         <save_cleanup_chain>: Remove member.
7801         (exceptions_state_mc_init): Update.
7802         (exception_try_scope_entry): Return nullptr.
7803         (exception_try_scope_exit, exception_rethrow)
7804         (throw_exception_sjlj, throw_exception_cxx): Update.
7805         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7806         (all_cleanups, do_cleanups, discard_cleanups)
7807         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7808         (restore_cleanups, restore_final_cleanups): Don't declare.
7809         (do_final_cleanups): Remove parameter.
7810         * common/cleanups.c (cleanup_chain, make_cleanup)
7811         (make_cleanup_dtor, all_cleanups, do_cleanups)
7812         (discard_my_cleanups, discard_cleanups)
7813         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7814         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7815         (null_cleanup): Remove.
7816         (do_final_cleanups): Remove parameter.
7817
7818 2019-03-06  Tom Tromey  <tom@tromey.com>
7819
7820         * remote.c (remote_target::remote_parse_stop_reply): Use
7821         unique_xmalloc_ptr.
7822
7823 2019-03-06  Tom Tromey  <tom@tromey.com>
7824
7825         * stabsread.c (struct stabs_field_info): Rename from field_info.
7826         <list, fnlist>: Add initializers.
7827         <obstack>: New member.
7828         (read_member_functions, read_struct_fields, read_baseclasses):
7829         Allocate on obstack.  Don't use cleanups.
7830         (read_one_struct_field, read_member_functions, read_struct_fields)
7831         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7832         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7833         (read_struct_type): Update.
7834
7835 2019-03-06  Tom Tromey  <tom@tromey.com>
7836
7837         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7838         * common/filestuff.h (make_cleanup_close): Don't declare.
7839         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7840         Remove.
7841
7842 2019-03-06  Tom Tromey  <tom@tromey.com>
7843
7844         * solib-aix.c: Use make_scope_exit.
7845
7846 2019-03-06  Tom Tromey  <tom@tromey.com>
7847
7848         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7849         Use make_scope_exit.
7850
7851 2019-03-06  Tom Tromey  <tom@tromey.com>
7852
7853         * solib-svr4.c (disable_probes_interface): Remove parameter.
7854         (svr4_handle_solib_event): Use make_scope_exit.
7855
7856 2019-03-06  Tom Tromey  <tom@tromey.com>
7857
7858         * remote.c (struct stop_reply_deleter): Remove.
7859         (stop_reply_up): Update.
7860         (struct stop_reply): Derive from notif_event.  Don't typedef.
7861         <regcache>: Now a std::vector.
7862         (stop_reply_xfree): Remove.
7863         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7864         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7865         (remote_target::discard_pending_stop_replies): Use delete.
7866         (remote_target::remote_parse_stop_reply): Update.
7867         (remote_target::process_stop_reply): Update.
7868         * remote-notif.h (struct notif_event): Add virtual destructor.
7869         Remove "dtr" member.
7870         (struct notif_client) <alloc_event>: Return a unique_ptr.
7871         (notif_event_xfree): Don't declare.
7872         (notif_event_up): New typedef.
7873         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7874         (notif_event_xfree, do_notif_event_xfree): Remove.
7875         (remote_notif_state_xfree): Update.
7876
7877 2019-03-06  Tom Tromey  <tom@tromey.com>
7878
7879         * infrun.c (displaced_step_clear_cleanup): Now a
7880         forward_scope_exit type.
7881         (displaced_step_prepare_throw): Update.
7882         (displaced_step_fixup): Update.
7883
7884 2019-03-06  Tom Tromey  <tom@tromey.com>
7885
7886         * inferior.h (class inferior): Update comment.
7887         * gdbthread.h (class thread_info): Update comment.
7888
7889 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7890             Tom Tromey  <tom@tromey.com>
7891
7892         * stabsread.h (struct stab_section_list): Remove.
7893         (coffstab_build_psymtabs): Update.
7894         * dbxread.c (symbuf_sections): Now a std::vector.
7895         (sect_idx): New global.
7896         (fill_symbuf): Update.
7897         (coffstab_build_psymtabs): Change type of stabsects parameter.
7898         Update.
7899         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7900         std::vector.
7901         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7902         (coff_locate_sections): Update.
7903         (coff_symfile_read): Remove cleanups.  Update.
7904         (init_stringtab): Add storage parameter.
7905         (free_stringtab, free_stringtab_cleanup): Remove.
7906         (init_lineno): Add storage parameter.
7907         (free_linetab, free_linetab_cleanup): Remove.
7908
7909 2019-03-06  Pedro Alves  <palves@redhat.com>
7910
7911         * linux-fork.c (fork_info::clobber_regs): Delete.
7912         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7913         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7914         comment.  Adjust.
7915         (scoped_switch_fork_info::scoped_switch_fork_info)
7916         (checkpoint_command, linux_fork_context): Adjust
7917         fork_save_infrun_state calls.
7918
7919 2019-03-06  Pedro Alves  <palves@redhat.com>
7920
7921         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7922         (inf_has_multiple_threads): Return 'bool' and rewrite using
7923         inferior_info::threads().
7924
7925 2019-03-06  Pedro Alves  <palves@redhat.com>
7926
7927         * linux-fork.c: Include <list>.
7928         (fork_list): Now a std::list instance.
7929         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7930         (forks_exist_p, find_last_fork): Adjust.
7931         (new_fork): Delete.
7932         (one_fork_p): New.
7933         (add_fork): Adjust.
7934         (free_fork): Delete, folded into fork_info::~fork_info().
7935         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7936         Adjust.
7937         (init_fork_list): Delete.
7938         (linux_fork_killall, linux_fork_mourn_inferior)
7939         (linux_fork_detach, info_checkpoints_command): Adjust.
7940         (_initialize_linux_fork): No longer call init_fork_list.
7941
7942 2019-03-06  Pedro Alves  <palves@redhat.com>
7943
7944         * linux-fork.c (new_fork): New, split out of ...
7945         (add_fork): ... this.  Return void.  Move "first fork" special
7946         case from here, to ...
7947         (checkpoint_command): ... here.
7948         * linux-linux.h (add_fork): Return void.
7949
7950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7953
7954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7955             Chris January  <chris.january@arm.com>
7956             David Lecomber  <david.lecomber@arm.com>
7957
7958         * f-exp.y: New token, UNOP_INTRINSIC.
7959         (exp): New pattern using UNOP_INTRINSIC token.
7960         (f77_keywords): Add 'abs' keyword.
7961         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7962         (value_from_host_double): New function.
7963         (evaluate_subexp_f): Support UNOP_ABS.
7964
7965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7966
7967         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7968         types.
7969
7970 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7971
7972         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7973         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7974         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7975
7976 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7977
7978         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7979
7980 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7981             Chris January  <chris.january@arm.com>
7982
7983         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7984         * f-exp.y: Define 'KIND' token.
7985         (exp): New pattern for KIND expressions.
7986         (ptype): Handle types with a kind extension.
7987         (direct_abs_decl): Extend to spot kind extensions.
7988         (f77_keywords): Add 'kind' to the list.
7989         (push_kind_type): New function.
7990         (convert_to_kind_type): New function.
7991         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7992         * parse.c (operator_length_standard): Likewise.
7993         * parser-defs.h (enum type_pieces): Add tp_kind.
7994         * std-operator.def: Add UNOP_KIND.
7995
7996 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * f-exp.y (f_parse): Set yydebug.
7999
8000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * f-lang.c (evaluate_subexp_f): New function.
8003         (exp_descriptor_f): New global.
8004         (f_language_defn): Use exp_descriptor_f instead of
8005         exp_descriptor_standard.
8006
8007 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8008
8009         * f-exp.y (struct token): Add comments.
8010         (dot_ops): Remove uppercase versions and the end marker.
8011         (f77_keywords): Likewise.
8012         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8013         entries in the dot_ops array are case insensitive, and use
8014         strncasecmp to compare strings.  Also some whitespace cleanup in
8015         this area.  Similar for the f77_keywords array, except entries in
8016         this list might be case sensitive.
8017
8018 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8019
8020         * f-exp.y (struct f77_boolean_val): Add comments.
8021         (boolean_values): Remove uppercase versions, and end marker.
8022         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8023         and use strncasecmp to achieve case insensitivity.  Additionally,
8024         perform whitespace cleanup around this code.
8025
8026 2019-03-06  Tom Tromey  <tromey@adacore.com>
8027
8028         * remote-sim.c (gdbsim_target_open): Use result of
8029         gdb_argv::release.
8030
8031 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8032         Dirk Schubert  <dirk.schubert@arm.com>
8033         Chris January  <chris.january@arm.com>
8034
8035         * eval.c (evaluate_subexp_standard): Call Fortran argument
8036         wrapping logic.
8037         * f-lang.c (struct value): A value which can be passed into a
8038         Fortran function call.
8039         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8040         where appropriate.
8041         (struct type): Value ready for a Fortran function call.
8042         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8043         is needed.
8044         * f-lang.h (fortran_argument_convert): Declaration.
8045         (fortran_preserve_arg_pointer): Declaration.
8046         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8047
8048 2019-03-05  Tom Tromey  <tromey@adacore.com>
8049
8050         * python/py-prettyprint.c (print_string_repr): Remove #if.
8051         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8052
8053 2019-03-05  Tom Tromey  <tromey@adacore.com>
8054
8055         * target.c (the_dummy_target): Move later.  Change type to
8056         "dummy_target".
8057         (initialize_targets): Don't initialize the_dummy_target.
8058
8059 2019-03-05  Tom Tromey  <tromey@adacore.com>
8060
8061         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8062         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8063
8064 2019-03-05  Tom Tromey  <tromey@adacore.com>
8065
8066         * windows-nat.c (windows_nat_target::attach)
8067         (windows_nat_target::detach): Don't call gdb_flush.
8068         * valprint.c (generic_val_print, val_print, val_print_string):
8069         Don't call gdb_flush.
8070         * utils.c (defaulted_query): Don't call gdb_flush.
8071         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8072         * target.c (target_announce_detach): Don't call gdb_flush.
8073         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8074         * remote.c (extended_remote_target::attach): Don't call
8075         gdb_flush.
8076         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8077         * printcmd.c (do_examine): Don't call gdb_flush.
8078         (info_display_command): Don't call gdb_flush.
8079         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8080         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8081         * memattr.c (info_mem_command): Don't call gdb_flush.
8082         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8083         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8084         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8085         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8086         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8087         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8088         (gnu_nat_target::detach): Don't call gdb_flush.
8089         * f-valprint.c (f_val_print): Don't call gdb_flush.
8090         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8091         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8092         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8093         gdb_flush.
8094         * c-valprint.c (c_val_print): Don't call gdb_flush.
8095         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8096
8097 2019-03-05  Tom Tromey  <tromey@adacore.com>
8098
8099         * varobj.c (update_dynamic_varobj_children): Update.
8100         (install_default_visualizer): Use reset, not release.
8101         * value.c (set_internalvar): Update.
8102         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8103         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8104         ATTRIBUTE_UNUSED_RESULT.
8105
8106 2019-03-05  Tom Tromey  <tromey@adacore.com>
8107
8108         * remote.c (class scoped_remote_fd) <release>: Add
8109         ATTRIBUTE_UNUSED_RESULT.
8110
8111 2019-03-05  Tom Tromey  <tromey@adacore.com>
8112
8113         * macroexp.c (struct macro_buffer) <release>: Add
8114         ATTRIBUTE_UNUSED_RESULT.
8115
8116 2019-03-05  Tom Tromey  <tromey@adacore.com>
8117
8118         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8119         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8120         ATTRIBUTE_UNUSED_RESULT.
8121
8122 2019-03-05  Tom Tromey  <tromey@adacore.com>
8123
8124         * common/scoped_fd.h (class scoped_fd) <release>: Add
8125         ATTRIBUTE_UNUSED_RESULT.
8126
8127 2019-03-05  Tom Tromey  <tromey@adacore.com>
8128
8129         * parser-defs.h (struct parser_state) <release>: Add
8130         ATTRIBUTE_UNUSED_RESULT.
8131
8132 2019-03-05  Tom Tromey  <tromey@adacore.com>
8133
8134         * utils.h (class gdb_argv) <release>: Add
8135         ATTRIBUTE_UNUSED_RESULT.
8136         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8137
8138 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8139
8140         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8141         for-loop range, to avoid compiler warnings.
8142
8143         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8144         avoid compiler warnings about unused variables.
8145
8146         * NEWS: Mention end of support for native debugging on MS-Windows
8147         before XP.
8148
8149         PR gdb/24292
8150         * common/netstuff.c:
8151         * gdbserver/gdbreplay.c
8152         * gdbserver/remote-utils.c:
8153         * ser-tcp.c:
8154         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8155         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8156         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8157         'getaddrinfo' and 'freeaddrinfo' were not available before
8158         Windows XP, and mingw.org's MinGW headers by default define
8159         _WIN32_WINNT to 0x500.
8160
8161 2019-03-01  Gary Benson <gbenson@redhat.com>
8162
8163         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8164
8165 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8166             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8167
8168         PR gdb/8527
8169         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8170         set_sigint_trap, clear_sigint_trap.
8171
8172 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8173
8174         * target.c (target_detach): Clear the regcache and the
8175         frame cache.
8176
8177 2019-02-27  Pedro Alves  <palves@redhat.com>
8178
8179         * utils.c (set_screen_size): When we cap the height/width sizes,
8180         tweak the corresponding command variable to show "unlimited":
8181
8182 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8183             Pedro Alves  <palves@redhat.com>
8184
8185         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8186         before calling rl_set_screen_size.
8187
8188 2019-02-27  Tom Tromey  <tromey@adacore.com>
8189
8190         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8191         define.
8192         * python/py-value.c: Remove Python 2.4 workaround.
8193         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8194         workaround.
8195         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8196         Python 2.4 workaround.
8197         * python/python-internal.h: Remove Python 2.4 comment.
8198         (Py_ssize_t): Don't define.
8199         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8200         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8201         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8202         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8203         * python/python.c (do_start_initialization): Remove Python 2.4
8204         workaround.
8205         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8206         (print_children): Remove Python 2.4 workaround.
8207         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8208         workaround.
8209         (CHARBUFFERPROC_NAME): Remove.
8210         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8211         Python 2.4 workaround.
8212
8213 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8214
8215         * NEWS: Note minimum Python version.
8216
8217 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8218
8219         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8220         code from these functions.  Remove corresponding ifdefs.  Use
8221         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8222         Remove gotos and target of gotos.
8223         (infpy_search_memory): Likewise.
8224
8225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8228         (hppa_gdbarch_init): Don't register deleted functions with
8229         gdbarch.
8230
8231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8232
8233         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8234         (h8300_unwind_sp): Delete.
8235         (h8300_dummy_id): Delete.
8236         (h8300_gdbarch_init): Don't register deleted functions with
8237         gdbarch.
8238
8239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8242         (ft32_unwind_pc): Delete.
8243         (ft32_unwind_sp): Delete.
8244         (ft32_gdbarch_init): Don't register deleted functions with
8245         gdbarch.
8246
8247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8250         (frv_unwind_pc): Delete.
8251         (frv_unwind_sp): Delete.
8252         (frv_gdbarch_init): Don't register deleted functions with
8253         gdbarch.
8254
8255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8258         (riscv_unwind_pc): Delete.
8259         (riscv_unwind_sp): Delete.
8260         (riscv_gdbarch_init): Don't register deleted functions with
8261         gdbarch.
8262
8263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8264
8265         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8266         (csky_unwind_pc): Delete.
8267         (csky_unwind_sp): Delete.
8268         (csky_gdbarch_init): Don't register deleted functions with
8269         gdbarch.
8270
8271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8274         (cris_unwind_pc): Delete.
8275         (cris_unwind_sp): Delete.
8276         (cris_gdbarch_init): Don't register deleted functions with
8277         gdbarch.
8278
8279 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8282         (bfin_unwind_pc): Delete.
8283         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8284
8285 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8286
8287         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8288         (arm_unwind_pc): Delete.
8289         (arm_unwind_sp): Delete.
8290         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8291
8292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8295         (arc_unwind_pc): Delete.
8296         (arc_unwind_sp): Delete.
8297         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8298
8299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8300
8301         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8302         (alpha_unwind_pc): Delete.
8303         (alpha_gdbarch_init): Don't register deleted functions with
8304         gdbarch.
8305
8306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8309         (aarch64_unwind_pc): Delete.
8310         (aarch64_unwind_sp): Delete.
8311         (aarch64_gdbarch_init): Don't register deleted functions with
8312         gdbarch.
8313
8314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8315
8316         * gdbtypes.c (type_align): Don't consider static members when
8317         computing structure alignment.
8318
8319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8320
8321         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8322         return 0 for other types.
8323         * arch-utils.c (default_type_align): Always return 0.
8324         * gdbarch.h: Regenerate.
8325         * gdbarch.sh (type_align): Extend comment.
8326         * gdbtypes.c (type_align): Add additional comments, always call
8327         gdbarch_type_align before applying the default rules.
8328         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8329         generic code will then apply a suitable default.
8330         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8331         types, return 0 for other types.
8332
8333 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8334
8335         * NEWS: Create a new section for the next release branch.
8336         Rename the section of the current branch, now that it has
8337         been cut.
8338
8339 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8340
8341         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8342         * version.in: Bump version to 8.3.50.DATE-git.
8343
8344 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8345
8346         * aix-thread.c (ptid_cmp): Remove unused variable.
8347         (get_signaled_thread): Likewise.
8348         (store_regs_user_thread): Likewise.
8349         (store_regs_kernel_thread): Likewise.
8350         (fetch_regs_kernel_thread): Remove shadowed variable.
8351
8352 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8353
8354         * features/riscv/32bit-cpu.xml: Add register numbers.
8355         * features/riscv/32bit-fpu.c: Regenerate.
8356         * features/riscv/32bit-fpu.xml: Add register numbers.
8357         * features/riscv/64bit-cpu.xml: Add register numbers.
8358         * features/riscv/64bit-fpu.c: Regenerate.
8359         * features/riscv/64bit-fpu.xml: Add register numbers.
8360
8361 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8362
8363         * NEWS: Mention two argument form of gdb.Value constructor.
8364         * python/py-value.c (convert_buffer_and_type_to_value): New
8365         function.
8366         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8367         Add support for handling an optional second argument.  Call
8368         convert_buffer_and_type_to_value as appropriate.
8369         * python/python-internal.h (Py_buffer_deleter): New struct.
8370         (Py_buffer_up): New typedef.
8371
8372 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8373
8374         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8375         instead of releasing ownership.
8376
8377 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8378
8379         * dwarf2read.c (open_and_init_dwp_file): Call
8380         elf_numsections instead of bfd_count_sections to initialize
8381         dwp_file->num_sections.
8382
8383 2019-02-25  Tom Tromey  <tromey@adacore.com>
8384
8385         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8386
8387 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8388
8389         * gcore.in: Add '--readnever' option when invoking GDB.
8390
8391 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8392
8393         * MAINTAINERS: Update my email address.
8394
8395 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8396
8397         * build-id.c (build_id_to_debug_bfd_1): New function.
8398         (build_id_to_debug_bfd): Look for separate debug file in
8399         sysroot.
8400
8401 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * gdbarch.sh: Update the copyright year range that is placed into
8404         generated files.
8405
8406 2019-02-22  Keith Seitz  <keiths@redhat.com>
8407
8408         PR symtab/23853
8409         * linespec.c (create_sals_line_offset): Search for the default
8410         symtab's filename instead of its fullname.
8411
8412 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8413
8414         * NEWS: Update style defaults.
8415
8416 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8417
8418         * main.c (captured_main_1): Disable styling in batch mode.
8419
8420 2019-02-20  Tom Tromey  <tom@tromey.com>
8421
8422         * symtab.c (symtab_symbol_info): Fix typos.
8423
8424 2019-02-20  Tom Tromey  <tromey@adacore.com>
8425
8426         * findcmd.c (_initialize_mem_search): Use upper case for
8427         metasyntactic variables.
8428
8429 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8430
8431         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8432         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8433
8434 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8435
8436         * top.h (source_file_name): Change to std::string.
8437         * top.c (source_file_name): Likewise.
8438         (command_line_input): Adjust.
8439         * cli/cli-script.c (script_from_file): Adjust.
8440
8441 2019-02-19  Tom Tromey  <tromey@adacore.com>
8442
8443         * ravenscar-thread.c
8444         (ravenscar_thread_target::update_thread_list): Don't call
8445         ada_build_task_list.
8446         * ada-lang.h (ada_build_task_list): Don't declare.
8447         * ada-tasks.c (struct ada_tasks_inferior_data)
8448         <task_list_valid_p>: Now bool.
8449         (read_known_tasks, ada_task_list_changed)
8450         (ada_tasks_invalidate_inferior_data): Update.
8451         (read_known_tasks_array): Return bool.
8452         (read_known_tasks_list): Likewise.
8453         (read_known_tasks): Return void.
8454         (ada_build_task_list): Now static.
8455
8456 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8457
8458         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8459         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8460
8461 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8462
8463         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8464         variant for ada_tasks_pspace_data_handle and
8465         ada_tasks_inferior_data_handle.
8466         (ada_tasks_pspace_data_cleanup): New function.
8467         (ada_tasks_inferior_data_cleanup): New function.
8468
8469 2019-02-17  Tom Tromey  <tom@tromey.com>
8470
8471         * macrotab.h (macro_source_fullname): Return a std::string.
8472         * macrotab.c (macro_include, check_for_redefinition)
8473         (macro_undef, macro_lookup_definition, foreach_macro)
8474         (foreach_macro_in_scope): Update.
8475         (macro_source_fullname): Return a std::string.
8476         * macrocmd.c (show_pp_source_pos): Update.
8477
8478 2019-02-17  Tom Tromey  <tom@tromey.com>
8479
8480         * macrocmd.c (show_pp_source_pos): Style the file names.
8481
8482 2019-02-17  Tom Tromey  <tom@tromey.com>
8483
8484         PR tui/24197:
8485         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8486
8487 2019-02-17  Tom Tromey  <tom@tromey.com>
8488
8489         * ada-lang.c (user_select_syms): Use filtered printing.
8490         * utils.c (wrap_style): New global.
8491         (desired_style): Remove.
8492         (emit_style_escape): Add stream parameter.
8493         (set_output_style, reset_terminal_style, prompt_for_continue):
8494         Update.
8495         (flush_wrap_buffer): Only flush gdb_stdout.
8496         (wrap_here): Set wrap_style.
8497         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8498         treat escape sequences as a character.  Change when wrap buffer is
8499         flushed.
8500         (fputs_styled): Do not set the output style when the default is
8501         requested.
8502         * ui-style.h (struct ui_file_style) <is_default>: New method.
8503         * source.c (print_source_lines_base): Emit escape sequences in one
8504         piece.
8505
8506 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8507
8508         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8509         integers and enumeration types.
8510
8511 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8512
8513         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8514         instead of lookup_symbol_in_language
8515         (do_exact_match): New function.
8516         (ada_get_symbol_name_matcher): Return do_exact_match when
8517         doing a verbatim match.
8518
8519 2019-02-15  Tom Tromey  <tromey@adacore.com>
8520
8521         * ravenscar-thread.c (ravenscar_thread_target::resume)
8522         (ravenscar_thread_target::wait): Special case wildcard requests.
8523
8524 2019-02-15  Tom Tromey  <tromey@adacore.com>
8525
8526         * ravenscar-thread.c (base_ptid): Remove.
8527         (struct ravenscar_thread_target) <close>: New method.
8528         <m_base_ptid>: New member.
8529         <update_inferior_ptid, active_task, task_is_currently_active,
8530         runtime_initialized>: Declare methods.
8531         <ravenscar_thread_target>: Add constructor.
8532         (ravenscar_thread_target::task_is_currently_active)
8533         (ravenscar_thread_target::update_inferior_ptid)
8534         (ravenscar_runtime_initialized): Rename.  Now methods.
8535         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8536         (ravenscar_thread_target::update_thread_list): Update.
8537         (ravenscar_thread_target::active_task): Now method.
8538         (ravenscar_thread_target::store_registers)
8539         (ravenscar_thread_target::prepare_to_store)
8540         (ravenscar_thread_target::prepare_to_store)
8541         (ravenscar_thread_target::mourn_inferior): Update.
8542         (ravenscar_inferior_created): Use "new" to create target.
8543         (ravenscar_thread_target::get_ada_task_ptid): Update.
8544         (_initialize_ravenscar): Don't initialize base_ptid.
8545         (ravenscar_ops): Remove global.
8546
8547 2019-02-15  Tom Tromey  <tromey@adacore.com>
8548
8549         * target.h (push_target): Declare new overload.
8550         * target.c (push_target): New overload, taking an rvalue reference.
8551         * remote.c (remote_target::open_1): Use push_target overload.
8552         * corelow.c (core_target_open): Use push_target overload.
8553
8554 2019-02-15  Tom Tromey  <tromey@adacore.com>
8555
8556         * ravenscar-thread.c (is_ravenscar_task)
8557         (ravenscar_task_is_currently_active): Return bool.
8558         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8559         (_initialize_ravenscar): Remove "(void)".
8560         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8561         Return bool.
8562
8563 2019-02-15  Tom Tromey  <tromey@adacore.com>
8564
8565         * ravenscar-thread.c (ravenscar_runtime_initializer)
8566         (has_ravenscar_runtime, get_running_thread_id)
8567         (ravenscar_thread_target::resume): Fix indentation.
8568
8569 2019-02-15  Tom Tromey  <tromey@adacore.com>
8570
8571         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8572         from ravenscar_arch_ops.
8573         (sparc_ravenscar_ops::fetch_registers)
8574         (sparc_ravenscar_ops::store_registers): Now methods.
8575         (sparc_ravenscar_prepare_to_store): Remove.
8576         (sparc_ravenscar_ops): Redefine.
8577         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8578         methods and destructor.  Remove members.
8579         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8580         (ravenscar_thread_target::store_registers)
8581         (ravenscar_thread_target::prepare_to_store): Update.
8582         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8583         Remove.
8584         (struct ppc_ravenscar_powerpc_ops): Derive from
8585         ravenscar_arch_ops.
8586         (ppc_ravenscar_powerpc_ops::fetch_registers)
8587         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8588         (ppc_ravenscar_powerpc_ops): Redefine.
8589         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8590         (ppc_ravenscar_e500_ops::fetch_registers)
8591         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8592         (ppc_ravenscar_e500_ops): Redefine.
8593         * aarch64-ravenscar-thread.c
8594         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8595         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8596         (aarch64_ravenscar_fetch_registers)
8597         (aarch64_ravenscar_store_registers): Now methods.
8598         (aarch64_ravenscar_ops): Redefine.
8599
8600 2019-02-15  Tom Tromey  <tromey@adacore.com>
8601
8602         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8603         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8604         (ravenscar_thread_target::stopped_by_watchpoint)
8605         (ravenscar_thread_target::stopped_data_address)
8606         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8607
8608 2019-02-15  Tom Tromey  <tromey@adacore.com>
8609
8610         * ravenscar-thread.c: Fix some typos.
8611
8612 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8613             Tom Tromey  <tromey@adacore.com>
8614
8615         * ada-lang.c (ada_exception_sal): Change addr_string to a
8616         std::string.
8617         (create_ada_exception_catchpoint): Update.
8618
8619 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8620             Tom Tromey  <tromey@adacore.com>
8621
8622         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8623         (bp_location_ops): Remove.
8624         (base_breakpoint_allocate_location): Update.
8625         (free_bp_location): Update.
8626         * ada-lang.c (class ada_catchpoint_location)
8627         <ada_catchpoint_location>: Remove ops parameter.
8628         (ada_catchpoint_location_dtor): Remove.
8629         (ada_catchpoint_location_ops): Remove.
8630         (allocate_location_exception): Update.
8631         * breakpoint.h (struct bp_location_ops): Remove.
8632         (class bp_location) <bp_location>: Remove bp_location_ops
8633         parameter.
8634         <~bp_location>: Add destructor.
8635         <ops>: Remove.
8636
8637 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8638             Pedro Alves  <palves@redhat.com>
8639
8640         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8641         'PATH_MAX'.
8642
8643 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8644             Samuel Thibault  <samuel.thibault@gnu.org>
8645             Thomas Schwinge  <thomas@codesourcery.com>
8646
8647         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8648         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8649
8650 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8651
8652         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8653         (check_empty): Use "const char *".
8654
8655         * gnu-nat.c (gnu_nat_target::detach): Instead of
8656         'detach_inferior (pid)' call
8657         'detach_inferior (find_inferior_pid (pid))'.
8658
8659         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8660         'nat/fork-inferior.o'.
8661         * gnu-nat.c: #include "nat/fork-inferior.h".
8662
8663         * gnu-nat.c (gnu_nat_target::detach): Instead of
8664         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8665         * gnu-nat.h: #include "inf-child.h".
8666         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8667         'i386_gnu_nat_target::fetch_registers'.
8668         (gnu_store_registers): Rename/move to
8669         'i386_gnu_nat_target::store_registers'.
8670
8671         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8672         * gnu-nat.h (mach_thread_info): New function.
8673         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8674
8675         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8676
8677 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8678
8679         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8680
8681 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8682
8683         * windows-nat.c (windows_add_thread): Add new parameter
8684         "main_thread_p" with default value set to false.  Update
8685         function documentation as well as all callers.
8686         (windows_delete_thread): Likewise.
8687         (fake_create_process): Update call to windows_add_thread.
8688         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8689         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8690         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8691         call to windows_delete_thread.
8692
8693 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8694
8695         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8696
8697 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8698
8699         * symfile.c (find_separate_debug_file): Use canonical path of
8700         sysroot with child_path instead of gdb_sysroot if it is valid.
8701
8702 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8703
8704         * symfile.c (find_separate_debug_file): Use child_path to
8705         determine if an object file is under a sysroot.
8706
8707 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8708
8709         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8710         unittests/child-path-selftests.c.
8711         * common/pathstuff.c (child_path): New function.
8712         * common/pathstuff.h (child_path): New prototype.
8713         * unittests/child-path-selftests.c: New file.
8714
8715 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8716
8717         * symfile.c (find_separate_debug_file): Look for separate debug
8718         files in debug directories under the sysroot.
8719
8720 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8721
8722         * symtab.h (struct minimal_symbol data_p): New const method.
8723         (struct minimal_symbol text_p): Likewise.
8724         * symtab.c (output_source_filename): Use file name style
8725         to print file name.
8726         (print_symbol_info): Likewise.
8727         (print_msymbol_info): Use address style to print addresses.
8728         Use function name style to print executable text symbols.
8729         (expand_symtab_containing_pc): Use data_p.
8730         (find_pc_sect_compunit_symtab): Likewise.
8731
8732 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8733
8734         * breakpoint.c (describe_other_breakpoints): Use address style
8735         to print addresses.
8736         (say_where): Likewise.
8737
8738 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8739
8740         * ada-typeprint.c (print_func_type): Print function name
8741         style to print function name.
8742         * c-typeprint.c (c_print_type_1): Likewise.
8743
8744 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8745
8746         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8747         for execve.
8748
8749 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8750
8751         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8752         type_stack.
8753
8754 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8755
8756         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8757         TYPE_CODE_REF types.
8758
8759 2019-02-08  Jim Wilson  <jimw@sifive.com>
8760
8761         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8762         (riscv_linux_fregset): New.
8763         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8764
8765 2019-02-07  Tom Tromey  <tom@tromey.com>
8766
8767         * thread.c (thread_cancel_execution_command): Update.
8768         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8769         methods.
8770         (struct thread_fsm_ops): Remove.
8771         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8772         (thread_fsm_should_stop, thread_fsm_return_value)
8773         (thread_fsm_set_finished, thread_fsm_finished_p)
8774         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8775         Don't declare.
8776         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8777         * infrun.c (clear_proceed_status_thread)
8778         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8779         (print_stop_event): Update.
8780         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8781         Add constructor.
8782         (step_command_fsm_ops): Remove.
8783         (new_step_command_fsm): Remove.
8784         (step_1): Update.
8785         (step_command_fsm::should_stop): Rename from
8786         step_command_fsm_should_stop.
8787         (step_command_fsm::clean_up): Rename from
8788         step_command_fsm_clean_up.
8789         (step_command_fsm::do_async_reply_reason): Rename from
8790         step_command_fsm_async_reply_reason.
8791         (struct until_next_fsm): Inherit from thread_fsm.  Add
8792         constructor.
8793         (until_next_fsm_ops): Remove.
8794         (new_until_next_fsm): Remove.
8795         (until_next_fsm::should_stop): Rename from
8796         until_next_fsm_should_stop.
8797         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8798         (until_next_fsm::do_async_reply_reason): Rename from
8799         until_next_fsm_async_reply_reason.
8800         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8801         constructor.  Change type of breakpoint.
8802         (finish_command_fsm_ops): Remove.
8803         (new_finish_command_fsm): Remove.
8804         (finish_command_fsm::should_stop): Rename from
8805         finish_command_fsm_should_stop.
8806         (finish_command_fsm::clean_up): Rename from
8807         finish_command_fsm_clean_up.
8808         (finish_command_fsm::return_value): Rename from
8809         finish_command_fsm_return_value.
8810         (finish_command_fsm::do_async_reply_reason): Rename from
8811         finish_command_fsm_async_reply_reason.
8812         (finish_command): Update.
8813         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8814         Add constructor.
8815         (call_thread_fsm_ops): Remove.
8816         (call_thread_fsm::call_thread_fsm): Rename from
8817         new_call_thread_fsm.
8818         (call_thread_fsm::should_stop): Rename from
8819         call_thread_fsm_should_stop.
8820         (call_thread_fsm::should_notify_stop): Rename from
8821         call_thread_fsm_should_notify_stop.
8822         (run_inferior_call, call_function_by_hand_dummy): Update.
8823         * cli/cli-interp.c (should_print_stop_to_console): Update.
8824         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8825         Add constructor.  Change type of location_breakpoint,
8826         caller_breakpoint.
8827         (until_break_fsm_ops): Remove.
8828         (new_until_break_fsm): Remove.
8829         (until_break_fsm::should_stop): Rename from
8830         until_break_fsm_should_stop.
8831         (until_break_fsm::clean_up): Rename from
8832         until_break_fsm_clean_up.
8833         (until_break_fsm::do_async_reply_reason): Rename from
8834         until_break_fsm_async_reply_reason.
8835         (until_break_command): Update.
8836         * thread-fsm.c: Remove.
8837         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8838
8839 2019-02-07  Tom Tromey  <tom@tromey.com>
8840
8841         * yy-remap.h: Add include guard.
8842         * xtensa-tdep.h: Add include guard.
8843         * xcoffread.h: Rename include guard.
8844         * varobj-iter.h: Add include guard.
8845         * tui/tui.h: Rename include guard.
8846         * tui/tui-winsource.h: Rename include guard.
8847         * tui/tui-wingeneral.h: Rename include guard.
8848         * tui/tui-windata.h: Rename include guard.
8849         * tui/tui-win.h: Rename include guard.
8850         * tui/tui-stack.h: Rename include guard.
8851         * tui/tui-source.h: Rename include guard.
8852         * tui/tui-regs.h: Rename include guard.
8853         * tui/tui-out.h: Rename include guard.
8854         * tui/tui-layout.h: Rename include guard.
8855         * tui/tui-io.h: Rename include guard.
8856         * tui/tui-hooks.h: Rename include guard.
8857         * tui/tui-file.h: Rename include guard.
8858         * tui/tui-disasm.h: Rename include guard.
8859         * tui/tui-data.h: Rename include guard.
8860         * tui/tui-command.h: Rename include guard.
8861         * tic6x-tdep.h: Add include guard.
8862         * target/waitstatus.h: Rename include guard.
8863         * target/wait.h: Rename include guard.
8864         * target/target.h: Rename include guard.
8865         * target/resume.h: Rename include guard.
8866         * target-float.h: Rename include guard.
8867         * stabsread.h: Add include guard.
8868         * rs6000-tdep.h: Add include guard.
8869         * riscv-fbsd-tdep.h: Add include guard.
8870         * regformats/regdef.h: Rename include guard.
8871         * record.h: Rename include guard.
8872         * python/python.h: Rename include guard.
8873         * python/python-internal.h: Rename include guard.
8874         * python/py-stopevent.h: Rename include guard.
8875         * python/py-ref.h: Rename include guard.
8876         * python/py-record.h: Rename include guard.
8877         * python/py-record-full.h: Rename include guard.
8878         * python/py-record-btrace.h: Rename include guard.
8879         * python/py-instruction.h: Rename include guard.
8880         * python/py-events.h: Rename include guard.
8881         * python/py-event.h: Rename include guard.
8882         * procfs.h: Add include guard.
8883         * proc-utils.h: Add include guard.
8884         * p-lang.h: Add include guard.
8885         * or1k-tdep.h: Rename include guard.
8886         * observable.h: Rename include guard.
8887         * nto-tdep.h: Rename include guard.
8888         * nat/x86-linux.h: Rename include guard.
8889         * nat/x86-linux-dregs.h: Rename include guard.
8890         * nat/x86-gcc-cpuid.h: Add include guard.
8891         * nat/x86-dregs.h: Rename include guard.
8892         * nat/x86-cpuid.h: Rename include guard.
8893         * nat/ppc-linux.h: Rename include guard.
8894         * nat/mips-linux-watch.h: Rename include guard.
8895         * nat/linux-waitpid.h: Rename include guard.
8896         * nat/linux-ptrace.h: Rename include guard.
8897         * nat/linux-procfs.h: Rename include guard.
8898         * nat/linux-osdata.h: Rename include guard.
8899         * nat/linux-nat.h: Rename include guard.
8900         * nat/linux-namespaces.h: Rename include guard.
8901         * nat/linux-btrace.h: Rename include guard.
8902         * nat/glibc_thread_db.h: Rename include guard.
8903         * nat/gdb_thread_db.h: Rename include guard.
8904         * nat/gdb_ptrace.h: Rename include guard.
8905         * nat/fork-inferior.h: Rename include guard.
8906         * nat/amd64-linux-siginfo.h: Rename include guard.
8907         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8908         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8909         * nat/aarch64-linux.h: Rename include guard.
8910         * nat/aarch64-linux-hw-point.h: Rename include guard.
8911         * mn10300-tdep.h: Add include guard.
8912         * mips-linux-tdep.h: Add include guard.
8913         * mi/mi-parse.h: Rename include guard.
8914         * mi/mi-out.h: Rename include guard.
8915         * mi/mi-main.h: Rename include guard.
8916         * mi/mi-interp.h: Rename include guard.
8917         * mi/mi-getopt.h: Rename include guard.
8918         * mi/mi-console.h: Rename include guard.
8919         * mi/mi-common.h: Rename include guard.
8920         * mi/mi-cmds.h: Rename include guard.
8921         * mi/mi-cmd-break.h: Rename include guard.
8922         * m2-lang.h: Add include guard.
8923         * location.h: Rename include guard.
8924         * linux-record.h: Rename include guard.
8925         * linux-nat.h: Add include guard.
8926         * linux-fork.h: Add include guard.
8927         * i386-darwin-tdep.h: Rename include guard.
8928         * hppa-linux-offsets.h: Add include guard.
8929         * guile/guile.h: Rename include guard.
8930         * guile/guile-internal.h: Rename include guard.
8931         * gnu-nat.h: Rename include guard.
8932         * gdb-stabs.h: Rename include guard.
8933         * frv-tdep.h: Add include guard.
8934         * f-lang.h: Add include guard.
8935         * event-loop.h: Add include guard.
8936         * darwin-nat.h: Rename include guard.
8937         * cp-abi.h: Rename include guard.
8938         * config/sparc/nm-sol2.h: Rename include guard.
8939         * config/nm-nto.h: Rename include guard.
8940         * config/nm-linux.h: Add include guard.
8941         * config/i386/nm-i386gnu.h: Rename include guard.
8942         * config/djgpp/nl_types.h: Rename include guard.
8943         * config/djgpp/langinfo.h: Rename include guard.
8944         * compile/gcc-cp-plugin.h: Add include guard.
8945         * compile/gcc-c-plugin.h: Add include guard.
8946         * compile/compile.h: Rename include guard.
8947         * compile/compile-object-run.h: Rename include guard.
8948         * compile/compile-object-load.h: Rename include guard.
8949         * compile/compile-internal.h: Rename include guard.
8950         * compile/compile-cplus.h: Rename include guard.
8951         * compile/compile-c.h: Rename include guard.
8952         * common/xml-utils.h: Rename include guard.
8953         * common/x86-xstate.h: Rename include guard.
8954         * common/version.h: Rename include guard.
8955         * common/vec.h: Rename include guard.
8956         * common/tdesc.h: Rename include guard.
8957         * common/selftest.h: Rename include guard.
8958         * common/scoped_restore.h: Rename include guard.
8959         * common/scoped_mmap.h: Rename include guard.
8960         * common/scoped_fd.h: Rename include guard.
8961         * common/safe-iterator.h: Rename include guard.
8962         * common/run-time-clock.h: Rename include guard.
8963         * common/refcounted-object.h: Rename include guard.
8964         * common/queue.h: Rename include guard.
8965         * common/ptid.h: Rename include guard.
8966         * common/print-utils.h: Rename include guard.
8967         * common/preprocessor.h: Rename include guard.
8968         * common/pathstuff.h: Rename include guard.
8969         * common/observable.h: Rename include guard.
8970         * common/netstuff.h: Rename include guard.
8971         * common/job-control.h: Rename include guard.
8972         * common/host-defs.h: Rename include guard.
8973         * common/gdb_wait.h: Rename include guard.
8974         * common/gdb_vecs.h: Rename include guard.
8975         * common/gdb_unlinker.h: Rename include guard.
8976         * common/gdb_unique_ptr.h: Rename include guard.
8977         * common/gdb_tilde_expand.h: Rename include guard.
8978         * common/gdb_sys_time.h: Rename include guard.
8979         * common/gdb_string_view.h: Rename include guard.
8980         * common/gdb_splay_tree.h: Rename include guard.
8981         * common/gdb_setjmp.h: Rename include guard.
8982         * common/gdb_ref_ptr.h: Rename include guard.
8983         * common/gdb_optional.h: Rename include guard.
8984         * common/gdb_locale.h: Rename include guard.
8985         * common/gdb_assert.h: Rename include guard.
8986         * common/filtered-iterator.h: Rename include guard.
8987         * common/filestuff.h: Rename include guard.
8988         * common/fileio.h: Rename include guard.
8989         * common/environ.h: Rename include guard.
8990         * common/common-utils.h: Rename include guard.
8991         * common/common-types.h: Rename include guard.
8992         * common/common-regcache.h: Rename include guard.
8993         * common/common-inferior.h: Rename include guard.
8994         * common/common-gdbthread.h: Rename include guard.
8995         * common/common-exceptions.h: Rename include guard.
8996         * common/common-defs.h: Rename include guard.
8997         * common/common-debug.h: Rename include guard.
8998         * common/cleanups.h: Rename include guard.
8999         * common/buffer.h: Rename include guard.
9000         * common/btrace-common.h: Rename include guard.
9001         * common/break-common.h: Rename include guard.
9002         * cli/cli-utils.h: Rename include guard.
9003         * cli/cli-style.h: Rename include guard.
9004         * cli/cli-setshow.h: Rename include guard.
9005         * cli/cli-script.h: Rename include guard.
9006         * cli/cli-interp.h: Rename include guard.
9007         * cli/cli-decode.h: Rename include guard.
9008         * cli/cli-cmds.h: Rename include guard.
9009         * charset-list.h: Add include guard.
9010         * buildsym-legacy.h: Rename include guard.
9011         * bfin-tdep.h: Add include guard.
9012         * ax.h: Rename include guard.
9013         * arm-linux-tdep.h: Add include guard.
9014         * arm-fbsd-tdep.h: Add include guard.
9015         * arch/xtensa.h: Rename include guard.
9016         * arch/tic6x.h: Add include guard.
9017         * arch/i386.h: Add include guard.
9018         * arch/arm.h: Rename include guard.
9019         * arch/arm-linux.h: Rename include guard.
9020         * arch/arm-get-next-pcs.h: Rename include guard.
9021         * arch/amd64.h: Add include guard.
9022         * arch/aarch64-insn.h: Rename include guard.
9023         * arch-utils.h: Rename include guard.
9024         * annotate.h: Add include guard.
9025         * amd64-darwin-tdep.h: Rename include guard.
9026         * aarch64-linux-tdep.h: Add include guard.
9027         * aarch64-fbsd-tdep.h: Add include guard.
9028         * aarch32-linux-nat.h: Add include guard.
9029
9030 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9031
9032         * macrotab.c (macro_define_internal): New function that
9033         factorizes macro_define_object_internal and macro_define_function
9034         code.
9035         (macro_define_object_internal): Use macro_define_internal.
9036         (macro_define_function): Likewise.
9037
9038 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9039
9040         * macrocmd.c (extract_identifier): Return
9041         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9042         callers.
9043
9044 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9045
9046         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9047
9048 2019-02-05  Tom Tromey  <tom@tromey.com>
9049
9050         * target.c (target_stack::unpush): Move assertion earlier.
9051
9052 2019-01-30  Tom Tromey  <tom@tromey.com>
9053
9054         PR python/23615:
9055         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9056         (gdbpy_parse_and_eval): Likewise.
9057         * python/python-internal.h (gdbpy_allow_threads): New class.
9058
9059 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9060
9061         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9062         (aarch64_fbsd_fpregmap): Move earlier.
9063         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9064         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9065         instead of individual calls to trad_frame_set_reg_addr.
9066         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9067         earlier.
9068         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9069         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9070         instead of individual calls to trad_frame_set_reg_addr.
9071
9072 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9073
9074         * CONTRIBUTE: Replace contribution list with wiki link.
9075
9076 2019-01-25  Tom Tromey  <tom@tromey.com>
9077
9078         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9079
9080 2019-01-25  Tom Tromey  <tom@tromey.com>
9081
9082         * xtensa-linux-nat.c: Fix common/ includes.
9083         * xml-support.h: Fix common/ includes.
9084         * xml-support.c: Fix common/ includes.
9085         * x86-linux-nat.c: Fix common/ includes.
9086         * windows-nat.c: Fix common/ includes.
9087         * varobj.h: Fix common/ includes.
9088         * varobj.c: Fix common/ includes.
9089         * value.c: Fix common/ includes.
9090         * valops.c: Fix common/ includes.
9091         * utils.c: Fix common/ includes.
9092         * unittests/xml-utils-selftests.c: Fix common/ includes.
9093         * unittests/utils-selftests.c: Fix common/ includes.
9094         * unittests/unpack-selftests.c: Fix common/ includes.
9095         * unittests/tracepoint-selftests.c: Fix common/ includes.
9096         * unittests/style-selftests.c: Fix common/ includes.
9097         * unittests/string_view-selftests.c: Fix common/ includes.
9098         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9099         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9100         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9101         * unittests/rsp-low-selftests.c: Fix common/ includes.
9102         * unittests/parse-connection-spec-selftests.c: Fix common/
9103         includes.
9104         * unittests/optional-selftests.c: Fix common/ includes.
9105         * unittests/offset-type-selftests.c: Fix common/ includes.
9106         * unittests/observable-selftests.c: Fix common/ includes.
9107         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9108         * unittests/memrange-selftests.c: Fix common/ includes.
9109         * unittests/memory-map-selftests.c: Fix common/ includes.
9110         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9111         * unittests/function-view-selftests.c: Fix common/ includes.
9112         * unittests/environ-selftests.c: Fix common/ includes.
9113         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9114         * unittests/common-utils-selftests.c: Fix common/ includes.
9115         * unittests/cli-utils-selftests.c: Fix common/ includes.
9116         * unittests/array-view-selftests.c: Fix common/ includes.
9117         * ui-file.c: Fix common/ includes.
9118         * tui/tui-io.c: Fix common/ includes.
9119         * tracepoint.h: Fix common/ includes.
9120         * tracepoint.c: Fix common/ includes.
9121         * tracefile-tfile.c: Fix common/ includes.
9122         * top.h: Fix common/ includes.
9123         * top.c: Fix common/ includes.
9124         * thread.c: Fix common/ includes.
9125         * target/waitstatus.h: Fix common/ includes.
9126         * target/waitstatus.c: Fix common/ includes.
9127         * target.h: Fix common/ includes.
9128         * target.c: Fix common/ includes.
9129         * target-memory.c: Fix common/ includes.
9130         * target-descriptions.c: Fix common/ includes.
9131         * symtab.h: Fix common/ includes.
9132         * symfile.c: Fix common/ includes.
9133         * stap-probe.c: Fix common/ includes.
9134         * spu-linux-nat.c: Fix common/ includes.
9135         * sparc-nat.c: Fix common/ includes.
9136         * source.c: Fix common/ includes.
9137         * solib.c: Fix common/ includes.
9138         * solib-target.c: Fix common/ includes.
9139         * ser-unix.c: Fix common/ includes.
9140         * ser-tcp.c: Fix common/ includes.
9141         * ser-pipe.c: Fix common/ includes.
9142         * ser-base.c: Fix common/ includes.
9143         * selftest-arch.c: Fix common/ includes.
9144         * s12z-tdep.c: Fix common/ includes.
9145         * rust-exp.y: Fix common/ includes.
9146         * rs6000-aix-tdep.c: Fix common/ includes.
9147         * riscv-tdep.c: Fix common/ includes.
9148         * remote.c: Fix common/ includes.
9149         * remote-notif.h: Fix common/ includes.
9150         * remote-fileio.h: Fix common/ includes.
9151         * remote-fileio.c: Fix common/ includes.
9152         * regcache.h: Fix common/ includes.
9153         * regcache.c: Fix common/ includes.
9154         * record-btrace.c: Fix common/ includes.
9155         * python/python.c: Fix common/ includes.
9156         * python/py-type.c: Fix common/ includes.
9157         * python/py-inferior.c: Fix common/ includes.
9158         * progspace.h: Fix common/ includes.
9159         * producer.c: Fix common/ includes.
9160         * procfs.c: Fix common/ includes.
9161         * proc-api.c: Fix common/ includes.
9162         * printcmd.c: Fix common/ includes.
9163         * ppc-linux-nat.c: Fix common/ includes.
9164         * parser-defs.h: Fix common/ includes.
9165         * osdata.c: Fix common/ includes.
9166         * obsd-nat.c: Fix common/ includes.
9167         * nat/x86-linux.c: Fix common/ includes.
9168         * nat/x86-linux-dregs.c: Fix common/ includes.
9169         * nat/x86-dregs.h: Fix common/ includes.
9170         * nat/x86-dregs.c: Fix common/ includes.
9171         * nat/ppc-linux.c: Fix common/ includes.
9172         * nat/mips-linux-watch.h: Fix common/ includes.
9173         * nat/mips-linux-watch.c: Fix common/ includes.
9174         * nat/linux-waitpid.c: Fix common/ includes.
9175         * nat/linux-ptrace.h: Fix common/ includes.
9176         * nat/linux-ptrace.c: Fix common/ includes.
9177         * nat/linux-procfs.c: Fix common/ includes.
9178         * nat/linux-personality.c: Fix common/ includes.
9179         * nat/linux-osdata.c: Fix common/ includes.
9180         * nat/linux-namespaces.c: Fix common/ includes.
9181         * nat/linux-btrace.h: Fix common/ includes.
9182         * nat/linux-btrace.c: Fix common/ includes.
9183         * nat/fork-inferior.c: Fix common/ includes.
9184         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9185         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9186         * nat/aarch64-linux.c: Fix common/ includes.
9187         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9188         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9189         * namespace.h: Fix common/ includes.
9190         * mips-linux-tdep.c: Fix common/ includes.
9191         * minsyms.c: Fix common/ includes.
9192         * mi/mi-parse.h: Fix common/ includes.
9193         * mi/mi-main.c: Fix common/ includes.
9194         * mi/mi-cmd-env.c: Fix common/ includes.
9195         * memrange.h: Fix common/ includes.
9196         * memattr.c: Fix common/ includes.
9197         * maint.h: Fix common/ includes.
9198         * maint.c: Fix common/ includes.
9199         * main.c: Fix common/ includes.
9200         * machoread.c: Fix common/ includes.
9201         * location.c: Fix common/ includes.
9202         * linux-thread-db.c: Fix common/ includes.
9203         * linux-nat.c: Fix common/ includes.
9204         * linux-fork.c: Fix common/ includes.
9205         * inline-frame.c: Fix common/ includes.
9206         * infrun.c: Fix common/ includes.
9207         * inflow.c: Fix common/ includes.
9208         * inferior.h: Fix common/ includes.
9209         * inferior.c: Fix common/ includes.
9210         * infcmd.c: Fix common/ includes.
9211         * inf-ptrace.c: Fix common/ includes.
9212         * inf-child.c: Fix common/ includes.
9213         * ia64-linux-nat.c: Fix common/ includes.
9214         * i387-tdep.c: Fix common/ includes.
9215         * i386-tdep.c: Fix common/ includes.
9216         * i386-linux-tdep.c: Fix common/ includes.
9217         * i386-linux-nat.c: Fix common/ includes.
9218         * i386-go32-tdep.c: Fix common/ includes.
9219         * i386-fbsd-tdep.c: Fix common/ includes.
9220         * i386-fbsd-nat.c: Fix common/ includes.
9221         * guile/scm-type.c: Fix common/ includes.
9222         * guile/guile.c: Fix common/ includes.
9223         * go32-nat.c: Fix common/ includes.
9224         * gnu-nat.c: Fix common/ includes.
9225         * gdbthread.h: Fix common/ includes.
9226         * gdbarch-selftests.c: Fix common/ includes.
9227         * gdb_usleep.c: Fix common/ includes.
9228         * gdb_select.h: Fix common/ includes.
9229         * gdb_bfd.c: Fix common/ includes.
9230         * gcore.c: Fix common/ includes.
9231         * fork-child.c: Fix common/ includes.
9232         * findvar.c: Fix common/ includes.
9233         * fbsd-nat.c: Fix common/ includes.
9234         * event-top.c: Fix common/ includes.
9235         * event-loop.c: Fix common/ includes.
9236         * dwarf2read.c: Fix common/ includes.
9237         * dwarf2loc.c: Fix common/ includes.
9238         * dwarf2-frame.c: Fix common/ includes.
9239         * dwarf-index-cache.c: Fix common/ includes.
9240         * dtrace-probe.c: Fix common/ includes.
9241         * disasm-selftests.c: Fix common/ includes.
9242         * defs.h: Fix common/ includes.
9243         * csky-tdep.c: Fix common/ includes.
9244         * cp-valprint.c: Fix common/ includes.
9245         * cp-support.h: Fix common/ includes.
9246         * cp-support.c: Fix common/ includes.
9247         * corelow.c: Fix common/ includes.
9248         * completer.h: Fix common/ includes.
9249         * completer.c: Fix common/ includes.
9250         * compile/compile.c: Fix common/ includes.
9251         * compile/compile-loc2c.c: Fix common/ includes.
9252         * compile/compile-cplus-types.c: Fix common/ includes.
9253         * compile/compile-cplus-symbols.c: Fix common/ includes.
9254         * command.h: Fix common/ includes.
9255         * cli/cli-dump.c: Fix common/ includes.
9256         * cli/cli-cmds.c: Fix common/ includes.
9257         * charset.c: Fix common/ includes.
9258         * build-id.c: Fix common/ includes.
9259         * btrace.h: Fix common/ includes.
9260         * btrace.c: Fix common/ includes.
9261         * breakpoint.h: Fix common/ includes.
9262         * breakpoint.c: Fix common/ includes.
9263         * ax.h:
9264         (enum agent_op): Fix common/ includes.
9265         * ax-general.c (struct aop_map): Fix common/ includes.
9266         * ax-gdb.c: Fix common/ includes.
9267         * auxv.c: Fix common/ includes.
9268         * auto-load.c: Fix common/ includes.
9269         * arm-tdep.c: Fix common/ includes.
9270         * arch/riscv.c: Fix common/ includes.
9271         * arch/ppc-linux-common.c: Fix common/ includes.
9272         * arch/i386.c: Fix common/ includes.
9273         * arch/arm.c: Fix common/ includes.
9274         * arch/arm-linux.c: Fix common/ includes.
9275         * arch/arm-get-next-pcs.c: Fix common/ includes.
9276         * arch/amd64.c: Fix common/ includes.
9277         * arch/aarch64.c: Fix common/ includes.
9278         * arch/aarch64-insn.c: Fix common/ includes.
9279         * arch-utils.c: Fix common/ includes.
9280         * amd64-windows-tdep.c: Fix common/ includes.
9281         * amd64-tdep.c: Fix common/ includes.
9282         * amd64-sol2-tdep.c: Fix common/ includes.
9283         * amd64-obsd-tdep.c: Fix common/ includes.
9284         * amd64-nbsd-tdep.c: Fix common/ includes.
9285         * amd64-linux-tdep.c: Fix common/ includes.
9286         * amd64-linux-nat.c: Fix common/ includes.
9287         * amd64-fbsd-tdep.c: Fix common/ includes.
9288         * amd64-fbsd-nat.c: Fix common/ includes.
9289         * amd64-dicos-tdep.c: Fix common/ includes.
9290         * amd64-darwin-tdep.c: Fix common/ includes.
9291         * agent.c: Fix common/ includes.
9292         * ada-lang.h: Fix common/ includes.
9293         * ada-lang.c: Fix common/ includes.
9294         * aarch64-tdep.c: Fix common/ includes.
9295
9296 2019-01-25  Tom Tromey  <tom@tromey.com>
9297
9298         * common/create-version.sh: Use common/version.h.
9299
9300 2019-01-24  Pedro Alves  <palves@redhat.com>
9301
9302         * infrun.c (signal_stop, signal_print, signal_program)
9303         (signal_catch, signal_pass): Now arrays instead of pointers.
9304         (update_signals_program_target, do_target_resume)
9305         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9306         * linux-nat.c (linux_nat_target::pass_signals)
9307         (linux_nat_target::create_inferior, linux_nat_target::attach):
9308         Adjust.
9309         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9310         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9311         * procfs.c (procfs_target::pass_signals): Adjust.
9312         * record-full.c (record_full_target::resume): Adjust.
9313         * remote.c (remote_target::pass_signals)
9314         (remote_target::program_signals): Adjust.
9315         * target-debug.h (target_debug_print_signals): Now takes a
9316         gdb::array_view as parameter.  Adjust.
9317         * target.h (target_ops) <pass_signals, program_signals>: Replace
9318         pointer and length parameters with gdb::array_view.
9319         (target_pass_signals, target_program_signals): Likewise.
9320         * target-delegates.c: Regenerate.
9321
9322 2019-01-24  Pedro Alves  <palves@redhat.com>
9323
9324         * common/forward-scope-exit.h
9325         (forward_scope_exit::forward_scope_exit): Pass arguments to
9326         m_bind_function directly, instead of creating a std::bind and
9327         copying that.
9328
9329 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9330
9331         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9332         for static members.
9333         (pass_in_v_vfp_candidate): Likewise.
9334
9335 2019-01-23  Tom Tromey  <tom@tromey.com>
9336             Pedro Alves  <palves@redhat.com>
9337
9338         * regcache.c (class regcache_invalidator): Remove.
9339         (regcache::raw_write): Use make_scope_exit.
9340
9341 2019-01-23  Tom Tromey  <tom@tromey.com>
9342
9343         * ui-out.h (class ui_out_emit_type): Update comment.
9344
9345 2019-01-23  Tom Tromey  <tom@tromey.com>
9346
9347         * infrun.c (fetch_inferior_event): Update comment.
9348
9349 2019-01-23  Tom Tromey  <tom@tromey.com>
9350             Pedro Alves  <palves@redhat.com>
9351
9352         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9353         parameter.
9354         (fetch_inferior_event): Use SCOPE_EXIT.
9355
9356
9357 2019-01-23  Tom Tromey  <tom@tromey.com>
9358             Pedro Alves  <palves@redhat.com>
9359
9360         * infrun.c (disable_thread_events): Delete.
9361         (stop_all_threads): Use SCOPE_EXIT.
9362
9363 2019-01-23  Tom Tromey  <tom@tromey.com>
9364             Pedro Alves  <palves@redhat.com>
9365
9366         * symfile.c: Include forward-scope-exit.h.
9367         (clear_symtab_users_cleanup): Replace forward declaration with
9368         a FORWARD_SCOPE_EXIT.
9369         (syms_from_objfile_1): Use the forward_scope_exit and
9370         gdb::optional instead of cleanup_function.
9371         (reread_symbols): Use the forward_scope_exit instead of
9372         cleanup_function.
9373         (clear_symtab_users_cleanup): Remove function.
9374
9375 2019-01-23  Tom Tromey  <tom@tromey.com>
9376             Pedro Alves  <palves@redhat.com>
9377
9378         * linux-nat.c: Include scope-exit.h.
9379         (cleanup_target_stop): Remove.
9380         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9381         SCOPE_EXIT.
9382
9383 2019-01-23  Tom Tromey  <tom@tromey.com>
9384             Pedro Alves  <palves@redhat.com>
9385
9386         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9387         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9388
9389 2019-01-23  Tom Tromey  <tom@tromey.com>
9390             Andrew Burgess  <andrew.burgess@embecosm.com>
9391             Pedro Alves  <palves@redhat.com>
9392
9393         * infrun.c (fetch_inferior_event): Use scope_exit.
9394         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9395         * top.c (execute_command): Use scope_exit.
9396         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9397         * utils.c (do_bpstat_clear_actions_cleanup)
9398         (make_bpstat_clear_actions_cleanup): Remove.
9399
9400 2019-01-23  Tom Tromey  <tom@tromey.com>
9401             Pedro Alves  <palves@redhat.com>
9402
9403         * infrun.c: Include "common/scope-exit.h"
9404         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9405         (wait_for_inferior): Use SCOPE_EXIT.
9406         (fetch_inferior_event): Use scope_exit.
9407
9408 2019-01-23  Tom Tromey  <tom@tromey.com>
9409             Pedro Alves  <palves@redhat.com>
9410
9411         * breakpoint.c (create_breakpoint): Remove cleanup.
9412
9413 2019-01-23  Tom Tromey  <tom@tromey.com>
9414             Andrew Burgess  <andrew.burgess@embecosm.com>
9415             Pedro Alves  <palves@redhat.com>
9416
9417 2019-01-23  Pedro Alves  <palves@redhat.com>
9418
9419         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9420
9421 2019-01-23  Pedro Alves  <palves@redhat.com>
9422             Andrew Burgess  <andrew.burgess@embecosm.com>
9423
9424         * gdbthread.h: Include "common/forward-scope-exit.h".
9425         (scoped_finish_thread_state): Redefine custom class in terms of
9426         forward_scope_exit.
9427
9428 2019-01-23  Pedro Alves  <palves@redhat.com>
9429             Andrew Burgess  <andrew.burgess@embecosm.com>
9430
9431         * common/forward-scope-exit.h: New file.
9432
9433 2019-01-23  Pedro Alves  <palves@redhat.com>
9434             Andrew Burgess  <andrew.burgess@embecosm.com>
9435             Tom Tromey  <tom@tromey.com>
9436
9437         * common/scope-exit.h: New file.
9438
9439 2019-01-23  Pedro Alves  <palves@redhat.com>
9440
9441         * common/preprocessor.h (ESC): Rename to ...
9442         (ESC_PARENS): ... this.
9443         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9444         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9445
9446 2019-01-23  Tom Tromey  <tom@tromey.com>
9447
9448         * language.h (class scoped_switch_to_sym_language_if_auto):
9449         Initialize m_lang in both cases.
9450
9451 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9452
9453         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9454         with XCNEW.
9455
9456 2019-01-22  Tom Tromey  <tom@tromey.com>
9457
9458         * corelow.c: Do not include sys/file.h.
9459
9460 2019-01-22  Tom Tromey  <tom@tromey.com>
9461
9462         * tui/tui-wingeneral.h: Include gdb_curses.h.
9463
9464 2019-01-22  Tom Tromey  <tom@tromey.com>
9465
9466         * source-cache.h (class source_cache) <get_source_lines,
9467         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9468
9469 2019-01-22  Tom Tromey  <tom@tromey.com>
9470
9471         * remote-fileio.h (struct remote_target): Declare.
9472
9473 2019-01-22  Tom Tromey  <tom@tromey.com>
9474
9475         * python/py-arch.c: Do not include py-ref.h.
9476         * python/py-bpevent.c: Do not include py-ref.h.
9477         * python/py-cmd.c: Do not include py-ref.h.
9478         * python/py-continueevent.c: Do not include py-ref.h.
9479         * python/py-event.h: Do not include py-ref.h.
9480         * python/py-evtregistry.c: Do not include py-ref.h.
9481         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9482         * python/py-frame.c: Do not include py-ref.h.
9483         * python/py-framefilter.c: Do not include py-ref.h.
9484         * python/py-function.c: Do not include py-ref.h.
9485         * python/py-infevents.c: Do not include py-ref.h.
9486         * python/py-linetable.c: Do not include py-ref.h.
9487         * python/py-objfile.c: Do not include py-ref.h.
9488         * python/py-param.c: Do not include py-ref.h.
9489         * python/py-prettyprint.c: Do not include py-ref.h.
9490         * python/py-progspace.c: Do not include py-ref.h.
9491         * python/py-symbol.c: Do not include py-ref.h.
9492         * python/py-symtab.c: Do not include py-ref.h.
9493         * python/py-type.c: Do not include py-ref.h.
9494         * python/py-unwind.c: Do not include py-ref.h.
9495         * python/py-utils.c: Do not include py-ref.h.
9496         * python/py-value.c: Do not include py-ref.h.
9497         * python/py-varobj.c: Do not include py-ref.h.
9498         * python/py-xmethods.c: Do not include py-ref.h.
9499         * python/python.c: Do not include py-ref.h.
9500         * varobj.c: Do not include py-ref.h.
9501
9502 2019-01-22  Tom Tromey  <tom@tromey.com>
9503
9504         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9505         keyword for bcache.
9506
9507 2019-01-22  Tom Tromey  <tom@tromey.com>
9508
9509         * compile/compile-cplus-types.c: Remove a comment by #include.
9510
9511 2019-01-22  Tom Tromey  <tom@tromey.com>
9512
9513         * compile/gcc-c-plugin.h: Include compile-internal.h.
9514
9515 2019-01-22  Tom Tromey  <tom@tromey.com>
9516
9517         * stabsread.c (EXTERN): Do not define.
9518         (symnum, next_symbol_text_func, processing_gcc_compilation)
9519         (within_function, global_sym_chain, global_stabs)
9520         (previous_stab_code, this_object_header_files)
9521         (n_this_object_header_files)
9522         (n_allocated_this_object_header_files): Define.
9523         * stabsread.h (EXTERN): Never define.  Use "extern".
9524
9525 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9526
9527         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9528         history_value.
9529
9530 2019-01-21  Tom Tromey  <tom@tromey.com>
9531
9532         * ui-out.c: Fix includes.
9533         * tui/tui-source.c: Fix includes.
9534         * target.c: Fix includes.
9535         * remote.c: Fix includes.
9536         * regcache.c: Fix includes.
9537         * python/py-block.c: Fix includes.
9538         * printcmd.c: Fix includes.
9539         * or1k-tdep.c: Fix includes.
9540         * mi/mi-main.c: Fix includes.
9541         * m32r-tdep.c: Fix includes.
9542         * csky-tdep.c: Fix includes.
9543         * compile/compile-cplus-types.c: Fix includes.
9544         * cli/cli-interp.c: Fix includes.
9545
9546 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9547
9548         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9549         for padding.
9550
9551 2019-01-16  Tom Tromey  <tom@tromey.com>
9552
9553         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9554         earlier.
9555         (struct objfile) <msymbols_range>: Move from top level.
9556         <msymbols>: New method.
9557         (class objfile_msymbols): Remove.
9558         * symtab.c (default_collect_symbol_completion_matches_break_on):
9559         Update.
9560         * symmisc.c (dump_msymbols): Update.
9561         * stabsread.c (scan_file_globals): Update.
9562         * objc-lang.c (info_selectors_command, info_classes_command)
9563         (find_methods): Update.
9564         * minsyms.c (find_solib_trampoline_target): Update.
9565         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9566         * coffread.c (coff_symfile_read): Update.
9567         * ada-lang.c (ada_lookup_simple_minsym)
9568         (ada_collect_symbol_completion_matches): Update.
9569
9570 2019-01-16  Tom Tromey  <tom@tromey.com>
9571
9572         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9573         type.  Remove no-argument constructor.
9574         <iterator::operator++>: Simplify.
9575         <begin>: Update.
9576         <end>: Use minimal_symbol_count.
9577
9578 2019-01-16  Tom Tromey  <tom@tromey.com>
9579
9580         * objfiles.h (struct objfile) <psymtabs>: New method.
9581         (class objfile_psymtabs): Remove.
9582         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9583         typedef.
9584         <range>: New method.
9585         (require_partial_symbols): Change return type.
9586         * psymtab.c (require_partial_symbols)
9587         (psym_expand_symtabs_matching): Update.
9588         * mdebugread.c (parse_partial_symbols): Update.
9589         * dbxread.c (dbx_end_psymtab): Update.
9590
9591 2019-01-15  Tom Tromey  <tom@tromey.com>
9592
9593         * symtab.c (lookup_objfile_from_block)
9594         (lookup_symbol_in_objfile_symtabs)
9595         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9596         (find_line_symtab, info_sources_command)
9597         (default_collect_symbol_completion_matches_break_on)
9598         (make_source_files_completion_list): Update.
9599         * symmisc.c (print_objfile_statistics, dump_objfile)
9600         (maintenance_print_symbols, maintenance_info_symtabs)
9601         (maintenance_check_symtabs, maintenance_info_line_tables):
9602         Update.
9603         * source.c (select_source_symtab)
9604         (forget_cached_source_info_for_objfile): Update.
9605         * objfiles.h (class objfile_compunits): Remove.
9606         (struct objfile) <compunits_range>: New typedef.
9607         (compunits): New method.
9608         * objfiles.c (objfile_relocate1): Update.
9609         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9610         * maint.c (count_symtabs_and_blocks): Update.
9611         * linespec.c (iterate_over_all_matching_symtabs): Update.
9612         * cp-support.c (add_symbol_overload_list_qualified): Update.
9613         * coffread.c (coff_symtab_read): Update.
9614         * ada-lang.c (add_nonlocal_symbols)
9615         (ada_collect_symbol_completion_matches)
9616         (ada_add_global_exceptions): Update.
9617
9618 2019-01-15  Tom Tromey  <tom@tromey.com>
9619
9620         * progspace.h (program_space) <objfiles_safe_range>: New
9621         typedef.
9622         <objfiles_safe>: New method.
9623         * objfiles.h (class all_objfiles_safe): Remove.
9624         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9625         * jit.c (jit_inferior_exit_hook): Update.
9626
9627 2019-01-17  Tom Tromey  <tom@tromey.com>
9628
9629         * progspace.h (program_space) <objfiles_range>: New typedef.
9630         <objfiles>: New method.
9631         <objfiles_head>: Rename from objfiles.
9632         (object_files): Update.
9633         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9634         * guile/scm-pretty-print.c
9635         (ppscm_find_pretty_printer_from_objfiles): Update.
9636         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9637         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9638         Update.
9639         * python/py-progspace.c (pspy_get_objfiles): Update.
9640         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9641         Update.
9642         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9643         (objfpy_lookup_objfile_by_build_id): Update.
9644         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9645         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9646         Update.
9647         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9648         (expand_symtab_containing_pc, lookup_objfile_from_block)
9649         (lookup_static_symbol, basic_lookup_transparent_type)
9650         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9651         (find_line_symtab, info_sources_command)
9652         (default_collect_symbol_completion_matches_break_on)
9653         (make_source_files_completion_list, find_main_name): Update.
9654         * symmisc.c (print_symbol_bcache_statistics)
9655         (print_objfile_statistics, maintenance_print_symbols)
9656         (maintenance_print_msymbols, maintenance_print_objfiles)
9657         (maintenance_info_symtabs, maintenance_check_symtabs)
9658         (maintenance_expand_symtabs, maintenance_info_line_tables):
9659         Update.
9660         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9661         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9662         (map_overlay_command, unmap_overlay_command)
9663         (simple_overlay_update, expand_symtabs_matching)
9664         (map_symbol_filenames): Update.
9665         * symfile-debug.c (set_debug_symfile): Update.
9666         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9667         Update.
9668         * source.c (select_source_symtab, forget_cached_source_info):
9669         Update.
9670         * solib.c (solib_read_symbols): Update.
9671         * solib-spu.c (append_ocl_sos): Update.
9672         * psymtab.c (maintenance_print_psymbols)
9673         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9674         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9675         * printcmd.c (info_symbol_command): Update.
9676         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9677         Update.
9678         * objfiles.h (class all_objfiles): Remove.
9679         * objfiles.c (have_partial_symbols, have_full_symbols)
9680         (have_minimal_symbols, qsort_cmp, update_section_map)
9681         (shared_objfile_contains_address_p)
9682         (default_iterate_over_objfiles_in_search_order): Update.
9683         * objc-lang.c (info_selectors_command, info_classes_command)
9684         (find_methods): Update.
9685         * minsyms.c (find_solib_trampoline_target): Update.
9686         * maint.c (maintenance_info_sections)
9687         (maintenance_translate_address, count_symtabs_and_blocks):
9688         Update.
9689         * main.c (captured_main_1): Update.
9690         * linux-thread-db.c (try_thread_db_load_from_pdir)
9691         (has_libpthread): Update.
9692         * linespec.c (iterate_over_all_matching_symtabs)
9693         (search_minsyms_for_name): Update.
9694         * jit.c (jit_find_objf_with_entry_addr): Update.
9695         * hppa-tdep.c (find_unwind_entry)
9696         (hppa_lookup_stub_minimal_symbol): Update.
9697         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9698         Update.
9699         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9700         (elf_gnu_ifunc_resolve_by_got): Update.
9701         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9702         * dwarf-index-write.c (save_gdb_index_command): Update.
9703         * cp-support.c (add_symbol_overload_list_qualified): Update.
9704         * breakpoint.c (create_overlay_event_breakpoint)
9705         (create_longjmp_master_breakpoint)
9706         (create_std_terminate_master_breakpoint)
9707         (create_exception_master_breakpoint): Update.
9708         * blockframe.c (find_pc_partial_function): Update.
9709         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9710         (ada_collect_symbol_completion_matches)
9711         (ada_add_global_exceptions): Update.
9712
9713 2019-01-17  Tom Tromey  <tom@tromey.com>
9714
9715         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9716         declare VEC.
9717         (solib_target_parse_libraries): Change return type.
9718         (library_list_start_segment, library_list_start_section)
9719         (library_list_end_library, library_list_start_library); Update.
9720         (solib_target_free_library_list): Remove.
9721         (solib_target_parse_libraries): Remove cleanup.  Change return
9722         type.
9723         (solib_target_current_sos): Update.
9724
9725 2019-01-17  Tom Tromey  <tromey@bapiya>
9726
9727         * valprint.c: Replace "the the" with "the".
9728         * symtab.c: Replace "the the" with "the".
9729         * solib.c: Replace "the the" with "the".
9730         * solib-dsbt.c: Replace "the the" with "the".
9731         * linespec.c: Replace "the the" with "the".
9732         * dwarf2loc.h: Replace "the the" with "the".
9733         * amd64-windows-tdep.c: Replace "the the" with "the".
9734         * aarch64-tdep.c: Replace "the the" with "the".
9735
9736 2019-01-16  Keith Seitz  <keiths@redhat.com>
9737
9738         PR gdb/23773
9739         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9740         <builder>: Rename to ..
9741         <m_builder>: ... this and make private.
9742         (dwarf2_cu::get_builder): New method.  Change all users of
9743         `builder' to use this method.
9744         (dwarf2_start_symtab): Move to ...
9745         (dwarf2_cu::start_symtab): ... here.  Update all callers
9746         (setup_type_unit_groups): Move to ...
9747         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9748         callers.
9749         (dwarf2_cu::reset_builder): New method.
9750         (process_full_compunit, process_full_type_unit): Use
9751         dwarf2_cu::reset_builder.
9752         (follow_die_offset): Record the ancestor CU if it is different
9753         from the followed DIE's CU.
9754         (follow_die_sig_1): Likewise.
9755
9756 2019-01-15  Tom Tromey  <tom@tromey.com>
9757
9758         * remote.c (class remote_state) <buf>: Now a char_vector.
9759         <buf_size>: Remove.
9760         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9761         parameter.
9762         (remote_target::getpkt_or_notif_sane_1)
9763         (remote_target::getpkt_sane)
9764         (remote_target::getpkt_or_notif_sane): Likewise.
9765         (class remote_target) <putpkt>: New overload.
9766         (remote_target::read_frame): Change type of "buf_p".  Remove
9767         sizeof_p parameter.
9768         (packet_ok): New overload.
9769         (packet_check_result): New overload.
9770         Update all uses.
9771
9772 2019-01-14  Tom Tromey  <tom@tromey.com>
9773
9774         * remote-notif.c (handle_notification, remote_notif_ack)
9775         (remote_notif_parse): Make "buf" const.
9776         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9777         const.
9778         (remote_notif_parse, remote_notif_ack, handle_notification):
9779         Likewise.
9780         * remote.c (remote_notif_stop_parse): Make "buf" const.
9781         (remote_target::remote_parse_stop_reply): Make "buf" const.
9782         (remote_notif_stop_ack): Make "buf" const.
9783
9784 2019-01-14  Tom Tromey  <tom@tromey.com>
9785
9786         * remote.c (remote_console_output): Make parameter const.
9787
9788 2019-01-14  Tom Tromey  <tom@tromey.com>
9789
9790         * target-debug.h (target_debug_print_signals): Constify.
9791         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9792         * procfs.c (procfs_target::pass_signals): Update.
9793         * linux-nat.c (linux_nat_target::pass_signals): Update.
9794         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9795         * target-delegates.c: Rebuild.
9796         * remote.c (remote_target::program_signals): Update.
9797         (remote_target::pass_signals): Update.
9798         * target.c (target_pass_signals): Constify argument.
9799         (target_program_signals): Likewise.
9800         * target.h (struct target_ops) <pass_signals, program_signals>:
9801         Constify argument.
9802         (target_pass_signals, target_program_signals): Constify argument.
9803
9804 2019-01-14  Tom Tromey  <tom@tromey.com>
9805
9806         PR tui/28819:
9807         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9808
9809 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9810
9811         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9812         field.
9813         * rs6000-tdep.c: Include reggroups.h.
9814         (IS_V_ALIAS_PSEUDOREG): Define.
9815         (rs6000_register_name): Return names for the "vX" aliases.
9816         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9817         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9818         aliases.  Call default_register_reggroup_p for all other
9819         pseudo-registers.
9820         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9821         New functions.
9822         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9823         Handle "vX" aliases.
9824         (v_alias_pseudo_register_collect): New function.
9825         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9826         (rs6000_gdbarch_init): Initialize "vX" aliases as
9827         pseudo-registers.  Restore registration of
9828         rs6000_pseudo_register_reggroup_p with
9829         set_tdesc_pseudo_register_reggroup_p.
9830
9831 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9832
9833         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9834         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9835         set_gdbarch_num_pseudo_regs.
9836
9837 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9838
9839         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9840         Remove arg prefixname, add do_set and do_show.
9841         Add member functions set_list and show_list.
9842         * cli/cli-style.c (class cli_style_option): Update accordingly.
9843         (style_set_list): Move to file scope.
9844         (style_show_list): Likewise.
9845         (set_style): Call help_list.
9846         (show_style): Call cmd_show_list.
9847         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9848         Update to use the new macro.
9849
9850 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9851
9852         * ada-lang.c (_initialize_ada_language): Expand the help text
9853         for the "catch exception" command.
9854
9855 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9856
9857         * symtab.c (matching_obj_sections): Initialize obj,
9858         declare it closer to its usage.
9859
9860 2019-01-10  Tom Tromey  <tom@tromey.com>
9861
9862         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9863         (basic_inf_threads_range): Remove.
9864         (inf_threads_range, inf_non_exited_threads_range)
9865         (safe_inf_threads_range): Use next_adapter.
9866
9867 2019-01-10  Keith Seitz  <keiths@redhat.com>
9868
9869         PR gdb/23712
9870         PR symtab/23010
9871         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9872         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9873
9874 2019-01-10  Keith Seitz  <keiths@redhat.com>
9875
9876         PR gdb/23712
9877         PR symtab/23010
9878         * dictionary.c (pending_to_vector): Remove.
9879         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9880         Remove _1 suffix, replacing functions of the same name.  Update
9881         all callers.
9882         (dict_create_hashed, dict_create_hashed_expandable)
9883         (dict_create_linear, dict_create_linear_expandable, dict_free)
9884         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9885         Make functions static.
9886
9887 2019-01-10  Keith Seitz  <keiths@redhat.com>
9888
9889         PR gdb/23712
9890         PR symtab/23010
9891         * dictionary.h (struct dictionary): Replace declaration with
9892         multidictionary.
9893         (dict_create_hashed, dict_create_hashed_expandable)
9894         (dict_create_linear, dict_create_linear_expandable)
9895         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9896         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9897         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9898         taking multidictionary argument.
9899         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9900         * block.h (struct block) <dict>: Change to multidictionary
9901         and rename `multidict'.
9902         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9903         symmisc.c: Update all dictionary references to multidictionary.
9904
9905 2019-01-10  Keith Seitz  <keiths@redhat.com>
9906
9907         PR gdb/23712
9908         PR symtab/23010
9909         * dictionary.c: Include unordered_map.
9910         (pending_to_vector): New function.
9911         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9912         Rewrite the non-"_1" functions to take vector instead
9913         of linked list.
9914         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9915         "new" _1 versions of the same name.
9916         (multidictionary): Define.
9917         (std::hash<enum language): New definition.
9918         (collate_pending_symbols_by_language, mdict_create_hashed)
9919         (mdict_create_hashed_expandable, mdict_create_linear)
9920         (mdict_create_linear_expandable, mdict_free)
9921         (find_language_dictionary, create_new_language_dictionary)
9922         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9923         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9924         (mdict_size, mdict_empty): New functions.
9925         * dictionary.h (mdict_iterator): Define.
9926
9927 2019-01-10  Pedro Alves  <palves@redhat.com>
9928
9929         * breakpoint.c (read_uploaded_action)
9930         (create_tracepoint_from_upload): Adjust to use
9931         gdb::unique_xmalloc_ptr.
9932         * ctf.c (ctf_write_uploaded_tp):
9933         (SET_ARRAY_FIELD): Use emplace_back.
9934         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9935         * tracefile-tfile.c (tfile_write_uploaded_tp):
9936         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9937         gdb::unique_xmalloc_ptr.
9938         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9939         at_string, cond_string, cmd_strings>: Replace char pointers
9940         with gdb::unique_xmalloc_ptr.
9941
9942 2019-01-10  Pedro Alves  <palves@redhat.com>
9943
9944         * solib-target.c (library_list_start_library): Don't xstrdup name.
9945
9946 2019-01-10  Pedro Alves  <palves@redhat.com>
9947
9948         * mdebugread.c (parse_partial_symbols): Use
9949         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9950
9951 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9952
9953         * linux-fork.c (scoped_switch_fork_info)
9954         <~scoped_switch_fork_info>: Fix incorrect variable name.
9955
9956 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9957
9958         * linux-fork.c (scoped_switch_fork_info)
9959         <scoped_switch_fork_info>: Make explicit.
9960         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9961
9962 2019-01-10  Tom Tromey  <tom@tromey.com>
9963
9964         * objfiles.h (objfile::reset_psymtabs): Update.
9965         * objfiles.c (objfile::objfile): Update.
9966         * psymtab.h (psymtab_storage::obstack): Update.
9967         (psymtab_storage::m_obstack): Use gdb::optional.
9968         (class psymtab_storage): Update comment.  Remove objfile
9969         parameter.
9970         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9971
9972 2019-01-10  Tom Tromey  <tom@tromey.com>
9973
9974         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9975         <free_psymtabs>: Now private.
9976         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9977         (allocate_psymtab): Use new method.
9978
9979 2019-01-10  Tom Tromey  <tom@tromey.com>
9980
9981         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9982         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9983         * mdebugread.c (parse_partial_symbols): Use
9984         allocate_dependencies.
9985         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9986         allocate_dependencies.
9987         (process_psymtab_comp_unit_reader)
9988         (build_type_psymtab_dependencies): Likewise.
9989         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9990
9991 2019-01-10  Tom Tromey  <tom@tromey.com>
9992
9993         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9994         PSYMBOL_SET_LANGUAGE.
9995         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9996
9997 2019-01-10  Tom Tromey  <tom@tromey.com>
9998
9999         * psymtab.h (psymtab_storage::obstack): New method.
10000         <m_obstack>: Rename from obstack; now private.
10001         * psymtab.c (psymtab_storage): Update.
10002         * dwarf2read.c (create_addrmap_from_index)
10003         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10004         Update.
10005
10006 2019-01-10  Tom Tromey  <tom@tromey.com>
10007
10008         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10009         * objfiles.h (objfile::reset_psymtabs): New method.
10010
10011 2019-01-10  Tom Tromey  <tom@tromey.com>
10012
10013         * symmisc.c (print_symbol_bcache_statistics): Update.
10014         (print_objfile_statistics): Update.
10015         * symfile.c (reread_symbols): Update.
10016         * psymtab.h (class psymtab_storage): New.
10017         * psymtab.c (psymtab_storage): New constructor.
10018         (~psymtab_storage): New destructor.
10019         (require_partial_symbols): Update.
10020         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10021         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10022         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10023         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10024         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10025         (start_psymtab_common, end_psymtab_common)
10026         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10027         (allocate_psymtab): Update.
10028         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10029         Update.
10030         (dump_psymtab_addrmap, maintenance_print_psymbols)
10031         (maintenance_check_psymtabs): Update.
10032         (class objfile_psymtabs): Move to objfiles.h.
10033         * psympriv.h (discard_psymtab): Now inline.
10034         (psymtab_discarder::psymtab_discarder): Update.
10035         (psymtab_discarder::~psymtab_discarder): Update.
10036         (ALL_OBJFILE_PSYMTABS): Rewrite.
10037         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10038         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10039         Remove fields.
10040         <partial_symtabs>: New field.
10041         (class objfile_psymtabs): Move from psymtab.h.  Update.
10042         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10043         psymbol_cache.
10044         (objfile::~objfile): Don't destroy psymbol_cache.
10045         * mdebugread.c (parse_partial_symbols): Update.
10046         * dwarf2read.c (create_addrmap_from_index)
10047         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10048         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10049         (add_partial_subprogram, dwarf2_ranges_read): Update.
10050         * dwarf-index-write.c (write_address_map)
10051         (write_one_signatured_type, recursively_write_psymbols)
10052         (class debug_names, class debug_names, write_psymtabs_to_index):
10053         Update.
10054
10055 2019-01-10  Tom Tromey  <tom@tromey.com>
10056
10057         * symtab.h (SYMBOL_SET_NAMES): Update.
10058         (symbol_set_names): Update.
10059         (MSYMBOL_SET_NAMES): Update.
10060         * symtab.c (symbol_set_names): Change argument to be an
10061         objfile_per_bfd_storage.
10062         * psymtab.c (add_psymbol_to_bcache): Update.
10063         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10064
10065 2019-01-10  Tom Tromey  <tom@tromey.com>
10066
10067         * symtab.c (create_demangled_names_hash): Change argument to be an
10068         objfile_per_bfd_storage.
10069         (symbol_set_names): Update.
10070
10071 2019-01-10  Tom Tromey  <tom@tromey.com>
10072
10073         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10074         init_psymbol_list.
10075         * psymtab.c (init_psymbol_list): Do nothing if already called.
10076         * psympriv.h (init_psymbol_list): Add comment.
10077         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10078         init_psymbol_list.
10079         * dbxread.c (dbx_symfile_read): Unconditionally call
10080         init_psymbol_list.
10081
10082 2019-01-10  Tom Tromey  <tom@tromey.com>
10083
10084         * xcoffread.c (scan_xcoff_symtab): Update.
10085         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10086         "where".
10087         * mdebugread.c (parse_partial_symbols)
10088         (handle_psymbol_enumerators): Update.
10089         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10090         * dbxread.c (read_dbx_symtab): Update.
10091         * psympriv.h (psymbol_placement): New enum.
10092         (add_psymbol_to_list): Update.
10093
10094 2019-01-10  Tom Tromey  <tom@tromey.com>
10095
10096         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10097         static_psymbols parameters.
10098         (scan_xcoff_symtab): Update.
10099         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10100         static_psymbols parameters.
10101         * psympriv.h (start_psymtab_common): Update.
10102         * mdebugread.c (parse_partial_symbols): Update.
10103         * dwarf2read.c (create_partial_symtab): Update.
10104         * dbxread.c (read_dbx_symtab): Update.
10105         (start_psymtab): Remove global_psymbols and static_psymbols
10106         parameters.
10107
10108 2019-01-10  Tom Tromey  <tom@tromey.com>
10109
10110         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10111         * psymtab.c (allocate_psymtab): Add comment.
10112         * psympriv.h (allocate_psymtab): Add comment.
10113         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10114         initializations.
10115         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10116
10117 2019-01-10  Tom Tromey  <tom@tromey.com>
10118
10119         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10120         Don't declare.
10121         * mipsread.c: Include mdebugread.h.
10122         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10123         Declare.
10124         * elfread.c: Include mdebugread.h.
10125
10126 2019-01-09  Tom Tromey  <tom@tromey.com>
10127
10128         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10129         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10130         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10131         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10132         (psym_lookup_symbol, psym_find_last_source_symtab)
10133         (psym_forget_cached_source_info, psym_print_stats)
10134         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10135         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10136         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10137         (psym_find_compunit_symtab_by_address)
10138         (maintenance_print_psymbols, maintenance_info_psymtabs)
10139         (maintenance_check_psymtabs): Use ranged for.
10140         * psymtab.h (class objfile_psymtabs): New.
10141         (require_partial_symbols): Return objfile_psymtabs.
10142         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10143
10144 2019-01-09  Tom Tromey  <tom@tromey.com>
10145
10146         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10147         (find_pc_mapped_section, list_overlays_command)
10148         (map_overlay_command, unmap_overlay_command)
10149         (simple_overlay_update): Use all_objfiles.
10150         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10151         * printcmd.c (info_symbol_command): Use all_objfiles.
10152         * objfiles.h (ALL_OBJSECTIONS): Remove.
10153         * maint.c (maintenance_translate_address): Use all_objfiles.
10154         * gcore.c (gcore_create_callback): Use all_objfiles.
10155         (objfile_find_memory_regions): Likewise.
10156
10157 2019-01-09  Tom Tromey  <tom@tromey.com>
10158
10159         * symtab.c (find_line_symtab, info_sources_command)
10160         (make_source_files_completion_list): Use objfile_compunits.
10161         * source.c (select_source_symtab): Use objfile_compunits.
10162         * objfiles.h (struct objfile): Update comment.
10163         (ALL_OBJFILES): Remove.
10164         (ALL_FILETABS): Remove.
10165         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10166         objfile_compunits.
10167
10168 2019-01-09  Tom Tromey  <tom@tromey.com>
10169
10170         * symmisc.c (print_objfile_statistics, dump_objfile)
10171         (maintenance_print_symbols): Use compunit_filetabs.
10172         * source.c (forget_cached_source_info_for_objfile): Use
10173         compunit_filetabs.
10174         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10175         (ALL_FILETABS): Use compunit_filetabs.
10176         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10177         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10178
10179 2019-01-09  Tom Tromey  <tom@tromey.com>
10180
10181         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10182         (compunit_filetabs): New.
10183         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10184         compunit_filetabs.
10185         (info_sources_command, make_source_files_completion_list): Remove
10186         declaration.
10187         * symmisc.c (print_objfile_statistics, dump_objfile)
10188         (maintenance_print_symbols): Remove declaration.
10189         (maintenance_info_symtabs): Use compunit_filetabs.
10190         (maintenance_info_line_tables): Likewise.
10191         * source.c (select_source_symtab): Change local variable name.
10192         (forget_cached_source_info_for_objfile): Remove declaration.
10193         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10194         * objfiles.c (objfile_relocate1): Remove declaration.
10195         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10196         declaration.
10197         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10198         * coffread.c (coff_symtab_read): Remove declaration.
10199         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10200         compunit_filetabs.
10201
10202 2019-01-09  Tom Tromey  <tom@tromey.com>
10203
10204         * symtab.c (lookup_objfile_from_block)
10205         (find_pc_sect_compunit_symtab, search_symbols)
10206         (default_collect_symbol_completion_matches_break_on): Use
10207         objfile_compunits.
10208         * objfiles.h (ALL_COMPUNITS): Remove.
10209         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10210         * cp-support.c (add_symbol_overload_list_qualified): Use
10211         objfile_compunits.
10212         * ada-lang.c (ada_collect_symbol_completion_matches)
10213         (ada_add_global_exceptions): Use objfile_compunits.
10214
10215 2019-01-09  Tom Tromey  <tom@tromey.com>
10216
10217         * source.c (select_source_symtab)
10218         (forget_cached_source_info_for_objfile): Remove declaration.
10219         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10220         declaration.
10221         * maint.c (count_symtabs_and_blocks): Remove declaration.
10222         * cp-support.c (add_symbol_overload_list_qualified): Remove
10223         declaration.
10224         * coffread.c (coff_symtab_read): Remove declaration.
10225         * symtab.c (lookup_symbol_in_objfile_symtabs)
10226         (basic_lookup_transparent_type_1): Use objfile_compunits.
10227         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10228         (info_sources_command, search_symbols)
10229         (default_collect_symbol_completion_matches_break_on)
10230         (make_source_files_completion_list): Remove declaration.
10231         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10232         (ada_collect_symbol_completion_matches)
10233         (ada_add_global_exceptions): Remove declaration.
10234         * linespec.c (iterate_over_all_matching_symtabs): Use
10235         objfile_compunits.
10236         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10237         (class objfile_compunits): New.
10238         (ALL_COMPUNITS): Use objfile_compunits.
10239         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10240         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10241         objfile_compunits.
10242         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10243
10244 2019-01-09  Tom Tromey  <tom@tromey.com>
10245
10246         * symtab.c (search_symbols)
10247         (default_collect_symbol_completion_matches_break_on): Use
10248         objfile_msymbols.
10249         * ada-lang.c (ada_lookup_simple_minsym)
10250         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10251         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10252         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10253         objfile_msymbols.
10254         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10255         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10256         * objc-lang.c (find_methods): Use objfile_msymbols.
10257         (info_selectors_command, info_classes_command): Likewise.
10258         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10259         * objfiles.h (class objfile_msymbols): New.
10260         (ALL_OBJFILE_MSYMBOLS): Remove.
10261         (ALL_MSYMBOLS): Remove.
10262
10263 2019-01-09  Tom Tromey  <tom@tromey.com>
10264
10265         * common/next-iterator.h (next_adapter): Add Iterator template
10266         parameter.
10267         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10268         (class all_objfiles_safe): New.
10269         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10270         * objfiles.c (put_objfile_before): Update comment.
10271         (add_separate_debug_objfile): Likewise.
10272         (free_all_objfiles): Use all_objfiles_safe.
10273         (objfile_purge_solibs): Likewise.
10274
10275 2019-01-09  Tom Tromey  <tom@tromey.com>
10276
10277         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10278         (expand_symtab_containing_pc, lookup_static_symbol)
10279         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10280         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10281         all_objfiles.
10282         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10283         * breakpoint.c (create_overlay_event_breakpoint)
10284         (create_longjmp_master_breakpoint)
10285         (create_std_terminate_master_breakpoint)
10286         (create_exception_master_breakpoint): Use all_objfiles.
10287         * linux-thread-db.c (try_thread_db_load_from_pdir)
10288         (has_libpthread): Use all_objfiles.
10289         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10290         * linespec.c (iterate_over_all_matching_symtabs)
10291         (search_minsyms_for_name): Use all_objfiles.
10292         * maint.c (maintenance_info_sections): Use all_objfiles.
10293         * main.c (captured_main_1): Use all_objfiles.
10294         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10295         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10296         * guile/scm-pretty-print.c
10297         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10298         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10299         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10300         (maintenance_print_msymbols): Use all_objfiles.
10301         * source.c (select_source_symtab): Use all_objfiles.
10302         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10303         * symfile.c (remove_symbol_file_command)
10304         (expand_symtabs_matching, map_symbol_filenames): Use
10305         all_objfiles.
10306         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10307         all_objfiles.
10308         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10309         * objc-lang.c (find_methods): Use all_objfiles.
10310         * objfiles.c (have_partial_symbols, have_full_symbols)
10311         (have_minimal_symbols, qsort_cmp)
10312         (default_iterate_over_objfiles_in_search_order): Use
10313         all_objfiles.
10314         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10315         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10316         (maintenance_check_psymtabs): Use all_objfiles.
10317         (ALL_PSYMTABS): Remove.
10318         * compile/compile-object-run.c (do_module_cleanup): Use
10319         all_objfiles.
10320         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10321         * cp-support.c (add_symbol_overload_list_qualified): Use
10322         all_objfiles.
10323         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10324         Use all_objfiles.
10325         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10326         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10327         all_objfiles.
10328         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10329         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10330         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10331         Uses all_objfiles.
10332         * solib.c (solib_read_symbols): Use all_objfiles
10333
10334 2019-01-09  Tom Tromey  <tom@tromey.com>
10335
10336         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10337         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10338         all_objfiles.
10339         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10340         * symmisc.c (print_symbol_bcache_statistics)
10341         (print_objfile_statistics, maintenance_print_objfiles)
10342         (maintenance_info_symtabs, maintenance_check_symtabs)
10343         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10344         all_objfiles.
10345         * source.c (forget_cached_source_info): Use all_objfiles.
10346         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10347         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10348         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10349         * objfiles.c (update_section_map): Use all_objfiles.
10350         (shared_objfile_contains_address_p): Likewise.
10351         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10352         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10353
10354 2019-01-09  Tom Tromey  <tom@tromey.com>
10355
10356         * common/next-iterator.h: New file.
10357         * objfiles.h (class all_objfiles): New.
10358         (struct objfile_iterator): New.
10359
10360 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10361
10362         * NEWS: Move the description of the changed "frame", "select-frame",
10363          and "info frame" commands to the Changed commands section.
10364
10365 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10366
10367         * gdbtypes.c (check_stub_method_group): Remove handling of old
10368         mangling schemes.
10369         * linespec.c (find_methods): Likewise.
10370         * stabsread.c (read_member_functions): Likewise.
10371         * valops.c (search_struct_method): Likewise.
10372         (value_struct_elt_for_reference): Likewise.
10373         * NEWS: Mention this change.
10374
10375 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10376
10377         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10378         print_source_lines.
10379         * source.c (print_source_lines_base): Update line number check.
10380         (print_source_lines): New function.
10381         (source_lines_range::source_lines_range): New function.
10382         * source.h (class source_lines_range): New class.
10383         (print_source_lines): New declaration.
10384
10385 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10386
10387         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10388
10389 2019-01-08  Tom Tromey  <tom@tromey.com>
10390             Simon Marchi  <simon.marchi@ericsson.com>
10391
10392         PR gdb/24060
10393         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10394         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10395         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10396         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10397         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10398         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10399
10400 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10401
10402         * source.c (select_source_symtab): Move header comment to
10403         declaration in source.h.
10404         (forget_cached_source_info_for_objfile): Likewise.
10405         (forget_cached_source_info): Likewise.
10406         (identify_source_line): Likewise.
10407         * source.h (identify_source_line): Move declaration from symtab.h
10408         and add comment from source.c
10409         (print_source_lines): Likewise.
10410         (forget_cached_source_info_for_objfile): Likewise.
10411         (forget_cached_source_info): Likewise.
10412         (select_source_symtab): Likewise.
10413         (enum print_source_lines_flag): Move definition from symtab.h.
10414         * symtab.h (identify_source_line): Move declaration to source.h.
10415         (print_source_lines): Likewise.
10416         (forget_cached_source_info_for_objfile): Likewise.
10417         (forget_cached_source_info): Likewise.
10418         (select_source_symtab): Likewise.
10419         (enum print_source_lines_flag): Move definition to source.h.
10420         * tui/tui-hooks.c: Add 'source.h' include.
10421
10422 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10423
10424         * source.c (print_source_lines_base): Handle requests to print
10425         reverse line number sequences, and guard against empty lines
10426         string.
10427
10428 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * source.c (print_source_lines_base): Fix skip of '\r' if next
10431         character is '\n'.
10432
10433 2019-01-06  Tom Tromey  <tom@tromey.com>
10434
10435         * c-exp.y (struct c_parse_state) <macro_original_text,
10436         expansion_obstack>: New member.
10437         (macro_original_text, expansion_obstack): Remove globals.
10438         (scan_macro_expansion, scanning_macro_expansion)
10439         (finished_macro_expansion): Update.
10440         (scan_macro_cleanup): Remove.
10441         (yylex, c_parse): Update.
10442
10443 2019-01-06  Tom Tromey  <tom@tromey.com>
10444
10445         * c-exp.y (struct c_parse_state) <strings>: New member.
10446         (operator_stoken): Update.
10447
10448 2019-01-06  Tom Tromey  <tom@tromey.com>
10449
10450         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10451         (union type_stack_elt) <typelist_val>: Now a pointer to
10452         std::vector.
10453         (type_stack_cleanup): Don't declare.
10454         (push_typelist): Update.
10455         * parse.c (pop_typelist): Return a std::vector.
10456         (push_typelist): Take a std::vector.
10457         (follow_types): Update.  Do not free args.
10458         (type_stack_cleanup): Remove.
10459         * c-exp.y (struct c_parse_state): New.
10460         (cpstate): New global.
10461         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10462         (nonempty_typelist): Update.
10463         (func_mod): Create a new vector.
10464         (c_parse): Create a c_parse_state.
10465         (check_parameter_typelist): Do not delete params.
10466         (function_method): Update.  Do not delete type_list.
10467
10468 2019-01-06  Tom Tromey  <tom@tromey.com>
10469
10470         PR gdb/28155:
10471         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10472         check_typedef.
10473         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10474         (print_return_value): Likewise.
10475
10476 2019-01-05  Tom Tromey  <tom@tromey.com>
10477
10478         * contrib/cleanup_check.py: Remove.
10479         * contrib/gcc-with-excheck: Remove.
10480         * contrib/exsummary.py: Remove.
10481         * contrib/excheck.py: Remove.
10482
10483 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10484
10485         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10486         NULL. Initialize tpprev to NULL instead of assigning it
10487         to NULL on the next statement.
10488         * windows-nat.c (windows_delete_thread): Remove check for
10489         main_thread_id before printing thread exit notifications.
10490         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10491         Remove thread ID check against main_thread_id.
10492         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10493         windows_delete_thread.
10494         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10495
10496 2019-01-04  Tom Tromey  <tom@tromey.com>
10497
10498         * compile/compile.c (_initialize_compile): Use upper case for
10499         metasyntactic variables.
10500         * symmisc.c (_initialize_symmisc): Use upper case for
10501         metasyntactic variables.
10502         * psymtab.c (_initialize_psymtab): Use upper case for
10503         metasyntactic variables.
10504         * demangle.c (demangle_command): Use upper case for metasyntactic
10505         variables.
10506         (_initialize_demangler): Likewise.
10507         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10508         variables.
10509
10510 2019-01-03  Tom Tromey  <tom@tromey.com>
10511
10512         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10513
10514 2019-01-03  Tom Tromey  <tom@tromey.com>
10515
10516         * python/py-symtab.c (salpy_str): Update.
10517         (struct salpy_sal_object) <symtab>: Now a PyObject.
10518         (salpy_dealloc): Update.
10519         (del_objfile_sal): Use gdbpy_ref.
10520
10521 2019-01-03  Tom Tromey  <tom@tromey.com>
10522
10523         * python/py-type.c (convert_field): Use new_reference.  Return
10524         gdbpy_ref.
10525         (make_fielditem): Return gdbpy_ref.
10526         (typy_fields): Update.
10527         (typy_getitem): Update.
10528         (field_name): Return gdbpy_ref.  Use new_reference.
10529         (typy_iterator_iternext): Update.
10530
10531 2019-01-03  Tom Tromey  <tom@tromey.com>
10532
10533         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10534
10535 2019-01-03  Tom Tromey  <tom@tromey.com>
10536
10537         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10538         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10539         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10540         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10541         (pspy_set_type_printers): Likewise.
10542         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10543         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10544         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10545         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10546         (objfpy_set_type_printers): Likewise.
10547
10548 2019-01-03  Tom Tromey  <tom@tromey.com>
10549
10550         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10551         (gdbpy_print_stack): Use gdbpy_err_fetch.
10552         * python/python-internal.h (class gdbpy_err_fetch): New class.
10553         (class gdbpy_enter) <m_error_type, m_error_value,
10554         m_error_traceback>: Remove.
10555         <m_error>: New member.
10556         (gdbpy_exception_to_string): Don't declare.
10557         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10558         * python/py-value.c (convert_value_from_python): Use
10559         gdbpy_err_fetch.
10560         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10561         gdbpy_exception_to_string.
10562         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10563         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10564         gdbpy_err_fetch.
10565
10566 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10567
10568         * linux-nat.c (delete_lwp_cleanup): Delete.
10569         (struct lwp_deleter): New struct.
10570         (lwp_info_up): New typedef.
10571         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10572         lwp_info_up.
10573
10574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10575
10576         * linux-fork.c (class scoped_switch_fork_info): New class.
10577         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10578
10579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10580
10581         * valops.c (find_overload_match): Remove use of null_cleanup, and
10582         calls to do_cleanups.
10583
10584 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10585
10586         * compile/compile-cplus-types.c
10587         (compile_cplus_instance::decl_name): Handle changes to
10588         cp_func_name.
10589         * cp-support.c (cp_func_name): Update header comment, update
10590         return type.
10591         * cp-support.h (cp_func_name): Update return type in declaration.
10592         * valops.c (find_overload_match): Move temp_func local to top
10593         level of function and change its type.  Use temp_func to hold and
10594         delete temporary string obtained from cp_func_name.
10595
10596 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10597
10598         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10599         gdb::char_vector, remove cleanup, and update uses of `msg`.
10600
10601 2019-01-03  Jim Wilson  <jimw@sifive.com>
10602
10603         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10604
10605 2019-01-02  Tom Tromey  <tom@tromey.com>
10606
10607         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10608         (tdesc_parse_xml): Remove cleanups.
10609         * target-descriptions.h (make_cleanup_free_target_description):
10610         Don't declare.
10611         (target_desc_deleter): New struct.
10612         (target_desc_up): New typedef.
10613         * target-descriptions.c (target_desc_deleter::operator()): Rename
10614         from free_target_description.
10615         (make_cleanup_free_target_description): Remove.
10616
10617 2019-01-02  Tom Tromey  <tom@tromey.com>
10618
10619         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10620         constructor, destructor.
10621         (linespec_parser): Remove typedef.
10622         (~linespec_parser): Rename from linespec_parser_delete.
10623         (linespec_lex_to_end, linespec_complete_label)
10624         (linespec_complete): Update.
10625         (decode_line_full): Remove cleanups.
10626         (decode_line_1): Update.
10627
10628 2019-01-02  Tom Tromey  <tom@tromey.com>
10629
10630         * python/python-internal.h (inferior_to_inferior_object): Change
10631         return type.
10632         * python/py-exitedevent.c (create_exited_event_object): Update.
10633         * python/py-inferior.c (inferior_to_inferior_object): Return
10634         gdbpy_ref.
10635         (python_new_inferior, python_inferior_deleted)
10636         (thread_to_thread_object, delete_thread_object)
10637         (build_inferior_list, gdbpy_selected_inferior): Update.
10638         * python/py-infthread.c (create_thread_object): Update.  Also fail
10639         if inferior_to_inferior_object fails.
10640
10641 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10642
10643         * inferior.h (class inferior) <displaced_step_state>: New field.
10644         * infrun.h (struct displaced_step_state): Move here from
10645         infrun.c.  Initialize fields, add constructor.
10646         <inf>: Remove field.
10647         <reset>: New method.
10648         * infrun.c (struct displaced_step_inferior_state): Move to
10649         infrun.h.
10650         (displaced_step_inferior_states): Remove.
10651         (get_displaced_stepping_state): Adust.
10652         (displaced_step_in_progress_any_inferior): Adjust.
10653         (displaced_step_in_progress_thread): Adjust.
10654         (displaced_step_in_progress): Adjust.
10655         (add_displaced_stepping_state): Remove.
10656         (get_displaced_step_closure_by_addr): Adjust.
10657         (remove_displaced_stepping_state): Remove.
10658         (infrun_inferior_exit): Call displaced_step_state.reset.
10659         (use_displaced_stepping): Don't check for NULL.
10660         (displaced_step_prepare_throw): Call
10661         get_displaced_stepping_state.
10662         (displaced_step_fixup): Don't check for NULL.
10663         (prepare_for_detach): Don't check for NULL.
10664
10665 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10666
10667         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10668          in case of call that did not complete.
10669
10670 2019-01-02  Andrey Utkin  <autkin@undo.io>
10671
10672         * symfile.c (find_separate_debug_file): Fix search of debug files for
10673         remote debuggee.
10674
10675 2019-01-02  Tom Tromey  <tom@tromey.com>
10676
10677         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10678         indentation.
10679         * python/py-frame.c (frapy_older): Remove cast.
10680         (frapy_newer): Likewise.
10681         * python/py-breakpoint.c (local_setattro): Remove cast.
10682         * python/py-arch.c (archpy_name): Remove local variable.
10683         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10684
10685 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10686
10687         * unittests/basic_string_view/element_access/char/empty.cc:
10688         Fix year range in copyright header.
10689
10690 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10691
10692         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10693         Delete.
10694         <operator==>: Update with for removed field.
10695         <hash>: Likewise.
10696         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10697         <isa_features>: ...this.
10698         <abi_features>: New field.
10699         (riscv_isa_flen): Update comment.
10700         (riscv_abi_xlen): New declaration.
10701         (riscv_abi_flen): New declaration.
10702         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10703         isa_features.
10704         (riscv_abi_xlen): New function.
10705         (riscv_isa_flen): Update to get answer from isa_features.
10706         (riscv_abi_flen): New function.
10707         (riscv_has_fp_abi): Update to get answer from abi_features.
10708         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10709         xlen and flen.
10710         (riscv_call_info) <xlen, flen>: Update comment.
10711         (riscv_call_arg_struct): Remove invalid assertions
10712         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10713         is removed.
10714         (riscv_gdbarch_init): Gather isa features and abi features
10715         separately, ensure both match on the gdbarch when reusing an old
10716         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10717         a target with 64-bit float hardware.
10718
10719 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10720
10721         * source.c (search_command_helper): Stop reverse search
10722         when line 1 has been searched.
10723
10724 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10725
10726         * record-full.c (record_full_base_target::close): Rewrite
10727         record_full_core_buf_list free logic.
10728
10729 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10730
10731         * break-catch-syscall.c (print_one_catch_syscall): xfree
10732         the last text.
10733
10734 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10735
10736         * top.c (print_gdb_version): Update Copyright year in version
10737         message.
10738
10739 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10740
10741         Update copyright year range in all GDB files.
10742
10743 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10744
10745         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10746
10747 For older changes see ChangeLog-2018.
10748 \f
10749 Local Variables:
10750 mode: change-log
10751 left-margin: 8
10752 fill-column: 74
10753 version-control: never
10754 coding: utf-8
10755 End:
10756