gdb/ChangeLog

   1 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * gdbtypes.c (lookup_struct_elt): New function.
   4         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
   5         * gdbtypes.h (struct struct_elt): New type.
   6         (lookup_struct_elt): New prototype.
   7
   8 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   9
  10         * gdbtypes.c (lookup_struct_elt_type): Update comment and
  11         remove disabled code block.
  12
  13 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  14
  15         * gdbarch.sh (get_thread_local_address): New method.
  16         * gdbarch.h, gdbarch.c: Regenerate.
  17         * target.c (target_translate_tls_address): Use
  18         gdbarch_get_thread_local_address if present instead of
  19         target::get_thread_local_address.
  20
  21 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  22
  23         * target.h (target::get_thread_local_address): Update comment.
  24
  25 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  26
  27         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  28         objfile->separate_debug_objfile_backlink if not NULL.
  29
  30 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  31
  32         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
  33         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  34         (amd64bsd_store_inferior_registers): Likewise.
  35         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  36         Enable segment base registers.
  37         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  38         PT_GETFSBASE and PT_GETGSBASE.
  39         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  40         PT_SETGSBASE.
  41         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  42         segment base registers.
  43         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  44
  45 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  46
  47         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  48         Update calls to i386_target_description to add 'segments'
  49         parameter.
  50         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
  51         add segment base registers.
  52         * arch/i386.c (i386_create_target_description): Add 'segments'
  53         parameter to enable segment base registers.
  54         * arch/i386.h (i386_create_target_description): Likewise.
  55         * features/i386/32bit-segments.xml: New file.
  56         * features/i386/32bit-segments.c: Generate.
  57         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
  58         call to i386_target_description to add 'segments' parameter.
  59         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  60         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
  61         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
  62         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
  63         if feature is present.
  64         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
  65         Add 'segments' parameter to call to i386_target_description.
  66         (i386_target_description): Add 'segments' parameter to enable
  67         segment base registers.
  68         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
  69         to call to i386_target_description.
  70         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
  71         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
  72         Define I386_NUM_REGS.
  73         (i386_target_description): Add 'segments' parameter to enable
  74         segment base registers.
  75
  76 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  77
  78         PR/24325
  79         * source-cache.c: #undef open and close, to avoid unresolved
  80         externals during linking.
  81
  82 2019-03-12  Tom Tromey  <tromey@adacore.com>
  83
  84         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
  85         const.  Add initializers.
  86         (_initialize_remote): Don't initialize ptid globals.
  87
  88 2019-03-12  Pedro Alves  <palves@redhat.com>
  89
  90         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
  91
  92 2019-03-12  Pedro Alves  <palves@redhat.com>
  93
  94         * cp-name-parser.y (main): Remove unused 'len' variable.
  95
  96 2019-03-12  Tom Tromey  <tromey@adacore.com>
  97
  98         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
  99         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 100
 101 2019-03-12  Tom Tromey  <tromey@adacore.com>
 102
 103         * linux-nat.c (iterate_over_lwps): Update.
 104         (stop_callback): Remove parameter.
 105         (stop_wait_callback, detach_callback, resume_set_callback)
 106         (select_singlestep_lwp_callback, set_ignore_sigint)
 107         (status_callback, resumed_callback, resume_clear_callback)
 108         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 109         data parameter.
 110         (linux_nat_target::detach, linux_nat_target::resume)
 111         (linux_stop_and_wait_all_lwps, select_event_lwp)
 112         (linux_nat_filter_event, linux_nat_wait_1)
 113         (linux_nat_target::kill, linux_nat_target::stop)
 114         (linux_nat_target::stop): Update.
 115         (linux_nat_resume_callback): Change type.
 116         (resume_stopped_resumed_lwps, count_events_callback)
 117         (select_event_lwp_callback): Likewise.
 118         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 119         * arm-linux-nat.c (struct update_registers_data): Remove.
 120         (update_registers_callback): Change type.
 121         (arm_linux_insert_hw_breakpoint1): Update.
 122         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 123         parameter.
 124         (x86_linux_dr_set_addr): Update.
 125         (x86_linux_dr_set_control): Update.
 126         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 127         (iterate_over_lwps): Use gdb::function_view.
 128         * nat/aarch64-linux-hw-point.c (struct
 129         aarch64_dr_update_callback_param): Remove.
 130         (debug_reg_change_callback): Change type.
 131         (aarch64_notify_debug_reg_change): Update.
 132         * s390-linux-nat.c (s390_refresh_per_info): Update.
 133
 134 2019-03-11  Tom Tromey  <tromey@adacore.com>
 135
 136         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 137         redundant assignment to "this_cu".
 138
 139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 140
 141         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 142
 143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 144
 145         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 146         from...
 147         (rank_one_type): ... this.
 148
 149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 150
 151         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 152         from...
 153         (rank_one_type): ... this.
 154
 155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 156
 157         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 158         from...
 159         (rank_one_type): ... this.
 160
 161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 162
 163         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 164         from...
 165         (rank_one_type): ... this.
 166
 167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 168
 169         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 170         from...
 171         (rank_one_type): ... this.
 172
 173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 174
 175         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 176         from...
 177         (rank_one_type): ... this.
 178
 179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 180
 181         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 182         from...
 183         (rank_one_type): ... this.
 184
 185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 186
 187         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 188         from...
 189         (rank_one_type): ... this.
 190
 191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 192
 193         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 194         from...
 195         (rank_one_type): ... this.
 196
 197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 198
 199         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 200         from...
 201         (rank_one_type): ... this.
 202
 203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 204
 205         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 206         from...
 207         (rank_one_type): ... this.
 208
 209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 210
 211         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 212         from...
 213         (rank_one_type): ... this.
 214
 215 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216
 217         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 218         inferior-events' shows the example events.
 219
 220 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 221
 222         Support styling on native MS-Windows console
 223
 224         PR/24315
 225         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 226         on MS-Windows if $TERM is not defined.
 227
 228         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 229
 230         * posix-hdep.c (gdb_console_fputs):
 231         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 232         functions.
 233         * ui-file.h (gdb_console_fputs): Add prototype.
 234
 235         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 236         back to fputs only if the former returns zero.
 237
 238 2019-03-07  Tom Tromey  <tom@tromey.com>
 239
 240         * symmisc.c (print_symbol_bcache_statistics): Update.
 241         (print_objfile_statistics): Update.
 242         * symfile.c (allocate_symtab): Update.
 243         * stabsread.c: Don't include bcache.h.
 244         * psymtab.h (struct psymbol_bcache): Don't declare.
 245         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 246         (psymbol_bcache_init, psymbol_bcache_free)
 247         (psymbol_bcache_get_bcache): Don't declare.
 248         * psymtab.c (struct psymbol_bcache): Remove.
 249         (psymtab_storage::psymtab_storage): Update.
 250         (psymtab_storage::~psymtab_storage): Update.
 251         (psymbol_bcache_init, psymbol_bcache_free)
 252         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 253         (add_psymbol_to_bcache): Update.
 254         (allocate_psymtab): Update.
 255         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 256         macro_cache>: No longer pointers.
 257         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 258         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 259         * macrotab.c (macro_bcache): Update.
 260         * macroexp.c: Don't include bcache.h.
 261         * gdbtypes.c (check_types_worklist): Update.
 262         (types_deeply_equal): Remove TRY/CATCH.  Update.
 263         * elfread.c (elf_symtab_read): Update.
 264         * dwarf2read.c: Don't include bcache.h.
 265         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 266         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 267         (print_bcache_statistics, bcache_memory_used): Don't declare.
 268         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 269         methods.  Rename all data members.
 270         * bcache.c (struct bcache): Move to bcache.h.
 271         (bcache::expand_hash_table): Rename from expand_hash_table.
 272         (bcache): Remove.
 273         (bcache::insert): Rename from bcache_full.
 274         (bcache::compare): Rename from bcache_compare.
 275         (bcache_xmalloc): Remove.
 276         (bcache::~bcache): Rename from bcache_xfree.
 277         (bcache::print_statistics): Rename from print_bcache_statistics.
 278         (bcache::memory_used): Rename from bcache_memory_used.
 279
 280 2019-03-07  Pedro Alves  <palves@redhat.com>
 281
 282         * infrun.c (normal_stop): Also check for
 283         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 284
 285 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * f-lang.c (value_from_host_double): Moved to...
 288         * value.c (value_from_host_double): ...here.
 289         * value.h (value_from_host_double): Declare.
 290         * guile/scm-math.c (vlscm_convert_typed_number): Use
 291         value_from_host_double.
 292         (vlscm_convert_number): Likewise.
 293         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 294         * python/py-value.c (convert_value_from_python): Likewise.
 295
 296 2019-03-06  Tom Tromey  <tom@tromey.com>
 297
 298         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 299
 300 2019-03-06  Tom Tromey  <tom@tromey.com>
 301
 302         * utils.h (free_current_contents): Don't declare.
 303         * utils.c (free_current_contents): Remove.
 304
 305 2019-03-06  Tom Tromey  <tom@tromey.com>
 306
 307         * top.c (quit_force): Update.
 308         * main.c (captured_command_loop): Update.
 309         * common/new-op.c (operator new): Update.
 310         * common/common-exceptions.c (struct catcher)
 311         <save_cleanup_chain>: Remove member.
 312         (exceptions_state_mc_init): Update.
 313         (exception_try_scope_entry): Return nullptr.
 314         (exception_try_scope_exit, exception_rethrow)
 315         (throw_exception_sjlj, throw_exception_cxx): Update.
 316         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 317         (all_cleanups, do_cleanups, discard_cleanups)
 318         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 319         (restore_cleanups, restore_final_cleanups): Don't declare.
 320         (do_final_cleanups): Remove parameter.
 321         * common/cleanups.c (cleanup_chain, make_cleanup)
 322         (make_cleanup_dtor, all_cleanups, do_cleanups)
 323         (discard_my_cleanups, discard_cleanups)
 324         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 325         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 326         (null_cleanup): Remove.
 327         (do_final_cleanups): Remove parameter.
 328
 329 2019-03-06  Tom Tromey  <tom@tromey.com>
 330
 331         * remote.c (remote_target::remote_parse_stop_reply): Use
 332         unique_xmalloc_ptr.
 333
 334 2019-03-06  Tom Tromey  <tom@tromey.com>
 335
 336         * stabsread.c (struct stabs_field_info): Rename from field_info.
 337         <list, fnlist>: Add initializers.
 338         <obstack>: New member.
 339         (read_member_functions, read_struct_fields, read_baseclasses):
 340         Allocate on obstack.  Don't use cleanups.
 341         (read_one_struct_field, read_member_functions, read_struct_fields)
 342         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 343         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 344         (read_struct_type): Update.
 345
 346 2019-03-06  Tom Tromey  <tom@tromey.com>
 347
 348         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 349         * common/filestuff.h (make_cleanup_close): Don't declare.
 350         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 351         Remove.
 352
 353 2019-03-06  Tom Tromey  <tom@tromey.com>
 354
 355         * solib-aix.c: Use make_scope_exit.
 356
 357 2019-03-06  Tom Tromey  <tom@tromey.com>
 358
 359         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 360         Use make_scope_exit.
 361
 362 2019-03-06  Tom Tromey  <tom@tromey.com>
 363
 364         * solib-svr4.c (disable_probes_interface): Remove parameter.
 365         (svr4_handle_solib_event): Use make_scope_exit.
 366
 367 2019-03-06  Tom Tromey  <tom@tromey.com>
 368
 369         * remote.c (struct stop_reply_deleter): Remove.
 370         (stop_reply_up): Update.
 371         (struct stop_reply): Derive from notif_event.  Don't typedef.
 372         <regcache>: Now a std::vector.
 373         (stop_reply_xfree): Remove.
 374         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 375         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 376         (remote_target::discard_pending_stop_replies): Use delete.
 377         (remote_target::remote_parse_stop_reply): Update.
 378         (remote_target::process_stop_reply): Update.
 379         * remote-notif.h (struct notif_event): Add virtual destructor.
 380         Remove "dtr" member.
 381         (struct notif_client) <alloc_event>: Return a unique_ptr.
 382         (notif_event_xfree): Don't declare.
 383         (notif_event_up): New typedef.
 384         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 385         (notif_event_xfree, do_notif_event_xfree): Remove.
 386         (remote_notif_state_xfree): Update.
 387
 388 2019-03-06  Tom Tromey  <tom@tromey.com>
 389
 390         * infrun.c (displaced_step_clear_cleanup): Now a
 391         forward_scope_exit type.
 392         (displaced_step_prepare_throw): Update.
 393         (displaced_step_fixup): Update.
 394
 395 2019-03-06  Tom Tromey  <tom@tromey.com>
 396
 397         * inferior.h (class inferior): Update comment.
 398         * gdbthread.h (class thread_info): Update comment.
 399
 400 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 401             Tom Tromey  <tom@tromey.com>
 402
 403         * stabsread.h (struct stab_section_list): Remove.
 404         (coffstab_build_psymtabs): Update.
 405         * dbxread.c (symbuf_sections): Now a std::vector.
 406         (sect_idx): New global.
 407         (fill_symbuf): Update.
 408         (coffstab_build_psymtabs): Change type of stabsects parameter.
 409         Update.
 410         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 411         std::vector.
 412         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 413         (coff_locate_sections): Update.
 414         (coff_symfile_read): Remove cleanups.  Update.
 415         (init_stringtab): Add storage parameter.
 416         (free_stringtab, free_stringtab_cleanup): Remove.
 417         (init_lineno): Add storage parameter.
 418         (free_linetab, free_linetab_cleanup): Remove.
 419
 420 2019-03-06  Pedro Alves  <palves@redhat.com>
 421
 422         * linux-fork.c (fork_info::clobber_regs): Delete.
 423         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 424         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 425         comment.  Adjust.
 426         (scoped_switch_fork_info::scoped_switch_fork_info)
 427         (checkpoint_command, linux_fork_context): Adjust
 428         fork_save_infrun_state calls.
 429
 430 2019-03-06  Pedro Alves  <palves@redhat.com>
 431
 432         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 433         (inf_has_multiple_threads): Return 'bool' and rewrite using
 434         inferior_info::threads().
 435
 436 2019-03-06  Pedro Alves  <palves@redhat.com>
 437
 438         * linux-fork.c: Include <list>.
 439         (fork_list): Now a std::list instance.
 440         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 441         (forks_exist_p, find_last_fork): Adjust.
 442         (new_fork): Delete.
 443         (one_fork_p): New.
 444         (add_fork): Adjust.
 445         (free_fork): Delete, folded into fork_info::~fork_info().
 446         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 447         Adjust.
 448         (init_fork_list): Delete.
 449         (linux_fork_killall, linux_fork_mourn_inferior)
 450         (linux_fork_detach, info_checkpoints_command): Adjust.
 451         (_initialize_linux_fork): No longer call init_fork_list.
 452
 453 2019-03-06  Pedro Alves  <palves@redhat.com>
 454
 455         * linux-fork.c (new_fork): New, split out of ...
 456         (add_fork): ... this.  Return void.  Move "first fork" special
 457         case from here, to ...
 458         (checkpoint_command): ... here.
 459         * linux-linux.h (add_fork): Return void.
 460
 461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 462
 463         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 464
 465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 466             Chris January  <chris.january@arm.com>
 467             David Lecomber  <david.lecomber@arm.com>
 468
 469         * f-exp.y: New token, UNOP_INTRINSIC.
 470         (exp): New pattern using UNOP_INTRINSIC token.
 471         (f77_keywords): Add 'abs' keyword.
 472         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 473         (value_from_host_double): New function.
 474         (evaluate_subexp_f): Support UNOP_ABS.
 475
 476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 479         types.
 480
 481 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 484         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 485         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 486
 487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 490
 491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 492             Chris January  <chris.january@arm.com>
 493
 494         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 495         * f-exp.y: Define 'KIND' token.
 496         (exp): New pattern for KIND expressions.
 497         (ptype): Handle types with a kind extension.
 498         (direct_abs_decl): Extend to spot kind extensions.
 499         (f77_keywords): Add 'kind' to the list.
 500         (push_kind_type): New function.
 501         (convert_to_kind_type): New function.
 502         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 503         * parse.c (operator_length_standard): Likewise.
 504         * parser-defs.h (enum type_pieces): Add tp_kind.
 505         * std-operator.def: Add UNOP_KIND.
 506
 507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * f-exp.y (f_parse): Set yydebug.
 510
 511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * f-lang.c (evaluate_subexp_f): New function.
 514         (exp_descriptor_f): New global.
 515         (f_language_defn): Use exp_descriptor_f instead of
 516         exp_descriptor_standard.
 517
 518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * f-exp.y (struct token): Add comments.
 521         (dot_ops): Remove uppercase versions and the end marker.
 522         (f77_keywords): Likewise.
 523         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 524         entries in the dot_ops array are case insensitive, and use
 525         strncasecmp to compare strings.  Also some whitespace cleanup in
 526         this area.  Similar for the f77_keywords array, except entries in
 527         this list might be case sensitive.
 528
 529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * f-exp.y (struct f77_boolean_val): Add comments.
 532         (boolean_values): Remove uppercase versions, and end marker.
 533         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 534         and use strncasecmp to achieve case insensitivity.  Additionally,
 535         perform whitespace cleanup around this code.
 536
 537 2019-03-06  Tom Tromey  <tromey@adacore.com>
 538
 539         * remote-sim.c (gdbsim_target_open): Use result of
 540         gdb_argv::release.
 541
 542 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 543         Dirk Schubert  <dirk.schubert@arm.com>
 544         Chris January  <chris.january@arm.com>
 545
 546         * eval.c (evaluate_subexp_standard): Call Fortran argument
 547         wrapping logic.
 548         * f-lang.c (struct value): A value which can be passed into a
 549         Fortran function call.
 550         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 551         where appropriate.
 552         (struct type): Value ready for a Fortran function call.
 553         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 554         is needed.
 555         * f-lang.h (fortran_argument_convert): Declaration.
 556         (fortran_preserve_arg_pointer): Declaration.
 557         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 558
 559 2019-03-05  Tom Tromey  <tromey@adacore.com>
 560
 561         * python/py-prettyprint.c (print_string_repr): Remove #if.
 562         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 563
 564 2019-03-05  Tom Tromey  <tromey@adacore.com>
 565
 566         * target.c (the_dummy_target): Move later.  Change type to
 567         "dummy_target".
 568         (initialize_targets): Don't initialize the_dummy_target.
 569
 570 2019-03-05  Tom Tromey  <tromey@adacore.com>
 571
 572         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 573         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 574
 575 2019-03-05  Tom Tromey  <tromey@adacore.com>
 576
 577         * windows-nat.c (windows_nat_target::attach)
 578         (windows_nat_target::detach): Don't call gdb_flush.
 579         * valprint.c (generic_val_print, val_print, val_print_string):
 580         Don't call gdb_flush.
 581         * utils.c (defaulted_query): Don't call gdb_flush.
 582         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 583         * target.c (target_announce_detach): Don't call gdb_flush.
 584         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 585         * remote.c (extended_remote_target::attach): Don't call
 586         gdb_flush.
 587         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 588         * printcmd.c (do_examine): Don't call gdb_flush.
 589         (info_display_command): Don't call gdb_flush.
 590         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 591         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 592         * memattr.c (info_mem_command): Don't call gdb_flush.
 593         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 594         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 595         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 596         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 597         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 598         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 599         (gnu_nat_target::detach): Don't call gdb_flush.
 600         * f-valprint.c (f_val_print): Don't call gdb_flush.
 601         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 602         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 603         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 604         gdb_flush.
 605         * c-valprint.c (c_val_print): Don't call gdb_flush.
 606         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 607
 608 2019-03-05  Tom Tromey  <tromey@adacore.com>
 609
 610         * varobj.c (update_dynamic_varobj_children): Update.
 611         (install_default_visualizer): Use reset, not release.
 612         * value.c (set_internalvar): Update.
 613         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 614         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 615         ATTRIBUTE_UNUSED_RESULT.
 616
 617 2019-03-05  Tom Tromey  <tromey@adacore.com>
 618
 619         * remote.c (class scoped_remote_fd) <release>: Add
 620         ATTRIBUTE_UNUSED_RESULT.
 621
 622 2019-03-05  Tom Tromey  <tromey@adacore.com>
 623
 624         * macroexp.c (struct macro_buffer) <release>: Add
 625         ATTRIBUTE_UNUSED_RESULT.
 626
 627 2019-03-05  Tom Tromey  <tromey@adacore.com>
 628
 629         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 630         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 631         ATTRIBUTE_UNUSED_RESULT.
 632
 633 2019-03-05  Tom Tromey  <tromey@adacore.com>
 634
 635         * common/scoped_fd.h (class scoped_fd) <release>: Add
 636         ATTRIBUTE_UNUSED_RESULT.
 637
 638 2019-03-05  Tom Tromey  <tromey@adacore.com>
 639
 640         * parser-defs.h (struct parser_state) <release>: Add
 641         ATTRIBUTE_UNUSED_RESULT.
 642
 643 2019-03-05  Tom Tromey  <tromey@adacore.com>
 644
 645         * utils.h (class gdb_argv) <release>: Add
 646         ATTRIBUTE_UNUSED_RESULT.
 647         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 648
 649 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 650
 651         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 652         for-loop range, to avoid compiler warnings.
 653
 654         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 655         avoid compiler warnings about unused variables.
 656
 657         * NEWS: Mention end of support for native debugging on MS-Windows
 658         before XP.
 659
 660         PR gdb/24292
 661         * common/netstuff.c:
 662         * gdbserver/gdbreplay.c
 663         * gdbserver/remote-utils.c:
 664         * ser-tcp.c:
 665         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 666         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 667         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 668         'getaddrinfo' and 'freeaddrinfo' were not available before
 669         Windows XP, and mingw.org's MinGW headers by default define
 670         _WIN32_WINNT to 0x500.
 671
 672 2019-03-01  Gary Benson <gbenson@redhat.com>
 673
 674         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 675
 676 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 677             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 678
 679         PR gdb/8527
 680         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 681         set_sigint_trap, clear_sigint_trap.
 682
 683 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 684
 685         * target.c (target_detach): Clear the regcache and the
 686         frame cache.
 687
 688 2019-02-27  Pedro Alves  <palves@redhat.com>
 689
 690         * utils.c (set_screen_size): When we cap the height/width sizes,
 691         tweak the corresponding command variable to show "unlimited":
 692
 693 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 694             Pedro Alves  <palves@redhat.com>
 695
 696         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 697         before calling rl_set_screen_size.
 698
 699 2019-02-27  Tom Tromey  <tromey@adacore.com>
 700
 701         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 702         define.
 703         * python/py-value.c: Remove Python 2.4 workaround.
 704         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 705         workaround.
 706         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 707         Python 2.4 workaround.
 708         * python/python-internal.h: Remove Python 2.4 comment.
 709         (Py_ssize_t): Don't define.
 710         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 711         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 712         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 713         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 714         * python/python.c (do_start_initialization): Remove Python 2.4
 715         workaround.
 716         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 717         (print_children): Remove Python 2.4 workaround.
 718         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 719         workaround.
 720         (CHARBUFFERPROC_NAME): Remove.
 721         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 722         Python 2.4 workaround.
 723
 724 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 725
 726         * NEWS: Note minimum Python version.
 727
 728 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 729
 730         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 731         code from these functions.  Remove corresponding ifdefs.  Use
 732         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 733         Remove gotos and target of gotos.
 734         (infpy_search_memory): Likewise.
 735
 736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 739         (hppa_gdbarch_init): Don't register deleted functions with
 740         gdbarch.
 741
 742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 743
 744         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 745         (h8300_unwind_sp): Delete.
 746         (h8300_dummy_id): Delete.
 747         (h8300_gdbarch_init): Don't register deleted functions with
 748         gdbarch.
 749
 750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 753         (ft32_unwind_pc): Delete.
 754         (ft32_unwind_sp): Delete.
 755         (ft32_gdbarch_init): Don't register deleted functions with
 756         gdbarch.
 757
 758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 761         (frv_unwind_pc): Delete.
 762         (frv_unwind_sp): Delete.
 763         (frv_gdbarch_init): Don't register deleted functions with
 764         gdbarch.
 765
 766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 769         (riscv_unwind_pc): Delete.
 770         (riscv_unwind_sp): Delete.
 771         (riscv_gdbarch_init): Don't register deleted functions with
 772         gdbarch.
 773
 774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 777         (csky_unwind_pc): Delete.
 778         (csky_unwind_sp): Delete.
 779         (csky_gdbarch_init): Don't register deleted functions with
 780         gdbarch.
 781
 782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 785         (cris_unwind_pc): Delete.
 786         (cris_unwind_sp): Delete.
 787         (cris_gdbarch_init): Don't register deleted functions with
 788         gdbarch.
 789
 790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 793         (bfin_unwind_pc): Delete.
 794         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 795
 796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 799         (arm_unwind_pc): Delete.
 800         (arm_unwind_sp): Delete.
 801         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 802
 803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 806         (arc_unwind_pc): Delete.
 807         (arc_unwind_sp): Delete.
 808         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 809
 810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 813         (alpha_unwind_pc): Delete.
 814         (alpha_gdbarch_init): Don't register deleted functions with
 815         gdbarch.
 816
 817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 818
 819         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 820         (aarch64_unwind_pc): Delete.
 821         (aarch64_unwind_sp): Delete.
 822         (aarch64_gdbarch_init): Don't register deleted functions with
 823         gdbarch.
 824
 825 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * gdbtypes.c (type_align): Don't consider static members when
 828         computing structure alignment.
 829
 830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 833         return 0 for other types.
 834         * arch-utils.c (default_type_align): Always return 0.
 835         * gdbarch.h: Regenerate.
 836         * gdbarch.sh (type_align): Extend comment.
 837         * gdbtypes.c (type_align): Add additional comments, always call
 838         gdbarch_type_align before applying the default rules.
 839         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 840         generic code will then apply a suitable default.
 841         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 842         types, return 0 for other types.
 843
 844 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 845
 846         * NEWS: Create a new section for the next release branch.
 847         Rename the section of the current branch, now that it has
 848         been cut.
 849
 850 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 851
 852         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 853         * version.in: Bump version to 8.3.50.DATE-git.
 854
 855 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 856
 857         * aix-thread.c (ptid_cmp): Remove unused variable.
 858         (get_signaled_thread): Likewise.
 859         (store_regs_user_thread): Likewise.
 860         (store_regs_kernel_thread): Likewise.
 861         (fetch_regs_kernel_thread): Remove shadowed variable.
 862
 863 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * features/riscv/32bit-cpu.xml: Add register numbers.
 866         * features/riscv/32bit-fpu.c: Regenerate.
 867         * features/riscv/32bit-fpu.xml: Add register numbers.
 868         * features/riscv/64bit-cpu.xml: Add register numbers.
 869         * features/riscv/64bit-fpu.c: Regenerate.
 870         * features/riscv/64bit-fpu.xml: Add register numbers.
 871
 872 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 873
 874         * NEWS: Mention two argument form of gdb.Value constructor.
 875         * python/py-value.c (convert_buffer_and_type_to_value): New
 876         function.
 877         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 878         Add support for handling an optional second argument.  Call
 879         convert_buffer_and_type_to_value as appropriate.
 880         * python/python-internal.h (Py_buffer_deleter): New struct.
 881         (Py_buffer_up): New typedef.
 882
 883 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 884
 885         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 886         instead of releasing ownership.
 887
 888 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 889
 890         * dwarf2read.c (open_and_init_dwp_file): Call
 891         elf_numsections instead of bfd_count_sections to initialize
 892         dwp_file->num_sections.
 893
 894 2019-02-25  Tom Tromey  <tromey@adacore.com>
 895
 896         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 897
 898 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 899
 900         * gcore.in: Add '--readnever' option when invoking GDB.
 901
 902 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 903
 904         * MAINTAINERS: Update my email address.
 905
 906 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 907
 908         * build-id.c (build_id_to_debug_bfd_1): New function.
 909         (build_id_to_debug_bfd): Look for separate debug file in
 910         sysroot.
 911
 912 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * gdbarch.sh: Update the copyright year range that is placed into
 915         generated files.
 916
 917 2019-02-22  Keith Seitz  <keiths@redhat.com>
 918
 919         PR symtab/23853
 920         * linespec.c (create_sals_line_offset): Search for the default
 921         symtab's filename instead of its fullname.
 922
 923 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 924
 925         * NEWS: Update style defaults.
 926
 927 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 928
 929         * main.c (captured_main_1): Disable styling in batch mode.
 930
 931 2019-02-20  Tom Tromey  <tom@tromey.com>
 932
 933         * symtab.c (symtab_symbol_info): Fix typos.
 934
 935 2019-02-20  Tom Tromey  <tromey@adacore.com>
 936
 937         * findcmd.c (_initialize_mem_search): Use upper case for
 938         metasyntactic variables.
 939
 940 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 941
 942         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 943         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 944
 945 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 946
 947         * top.h (source_file_name): Change to std::string.
 948         * top.c (source_file_name): Likewise.
 949         (command_line_input): Adjust.
 950         * cli/cli-script.c (script_from_file): Adjust.
 951
 952 2019-02-19  Tom Tromey  <tromey@adacore.com>
 953
 954         * ravenscar-thread.c
 955         (ravenscar_thread_target::update_thread_list): Don't call
 956         ada_build_task_list.
 957         * ada-lang.h (ada_build_task_list): Don't declare.
 958         * ada-tasks.c (struct ada_tasks_inferior_data)
 959         <task_list_valid_p>: Now bool.
 960         (read_known_tasks, ada_task_list_changed)
 961         (ada_tasks_invalidate_inferior_data): Update.
 962         (read_known_tasks_array): Return bool.
 963         (read_known_tasks_list): Likewise.
 964         (read_known_tasks): Return void.
 965         (ada_build_task_list): Now static.
 966
 967 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 970         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 971
 972 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 973
 974         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 975         variant for ada_tasks_pspace_data_handle and
 976         ada_tasks_inferior_data_handle.
 977         (ada_tasks_pspace_data_cleanup): New function.
 978         (ada_tasks_inferior_data_cleanup): New function.
 979
 980 2019-02-17  Tom Tromey  <tom@tromey.com>
 981
 982         * macrotab.h (macro_source_fullname): Return a std::string.
 983         * macrotab.c (macro_include, check_for_redefinition)
 984         (macro_undef, macro_lookup_definition, foreach_macro)
 985         (foreach_macro_in_scope): Update.
 986         (macro_source_fullname): Return a std::string.
 987         * macrocmd.c (show_pp_source_pos): Update.
 988
 989 2019-02-17  Tom Tromey  <tom@tromey.com>
 990
 991         * macrocmd.c (show_pp_source_pos): Style the file names.
 992
 993 2019-02-17  Tom Tromey  <tom@tromey.com>
 994
 995         PR tui/24197:
 996         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 997
 998 2019-02-17  Tom Tromey  <tom@tromey.com>
 999
1000         * ada-lang.c (user_select_syms): Use filtered printing.
1001         * utils.c (wrap_style): New global.
1002         (desired_style): Remove.
1003         (emit_style_escape): Add stream parameter.
1004         (set_output_style, reset_terminal_style, prompt_for_continue):
1005         Update.
1006         (flush_wrap_buffer): Only flush gdb_stdout.
1007         (wrap_here): Set wrap_style.
1008         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1009         treat escape sequences as a character.  Change when wrap buffer is
1010         flushed.
1011         (fputs_styled): Do not set the output style when the default is
1012         requested.
1013         * ui-style.h (struct ui_file_style) <is_default>: New method.
1014         * source.c (print_source_lines_base): Emit escape sequences in one
1015         piece.
1016
1017 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1018
1019         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1020         integers and enumeration types.
1021
1022 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1023
1024         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1025         instead of lookup_symbol_in_language
1026         (do_exact_match): New function.
1027         (ada_get_symbol_name_matcher): Return do_exact_match when
1028         doing a verbatim match.
1029
1030 2019-02-15  Tom Tromey  <tromey@adacore.com>
1031
1032         * ravenscar-thread.c (ravenscar_thread_target::resume)
1033         (ravenscar_thread_target::wait): Special case wildcard requests.
1034
1035 2019-02-15  Tom Tromey  <tromey@adacore.com>
1036
1037         * ravenscar-thread.c (base_ptid): Remove.
1038         (struct ravenscar_thread_target) <close>: New method.
1039         <m_base_ptid>: New member.
1040         <update_inferior_ptid, active_task, task_is_currently_active,
1041         runtime_initialized>: Declare methods.
1042         <ravenscar_thread_target>: Add constructor.
1043         (ravenscar_thread_target::task_is_currently_active)
1044         (ravenscar_thread_target::update_inferior_ptid)
1045         (ravenscar_runtime_initialized): Rename.  Now methods.
1046         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1047         (ravenscar_thread_target::update_thread_list): Update.
1048         (ravenscar_thread_target::active_task): Now method.
1049         (ravenscar_thread_target::store_registers)
1050         (ravenscar_thread_target::prepare_to_store)
1051         (ravenscar_thread_target::prepare_to_store)
1052         (ravenscar_thread_target::mourn_inferior): Update.
1053         (ravenscar_inferior_created): Use "new" to create target.
1054         (ravenscar_thread_target::get_ada_task_ptid): Update.
1055         (_initialize_ravenscar): Don't initialize base_ptid.
1056         (ravenscar_ops): Remove global.
1057
1058 2019-02-15  Tom Tromey  <tromey@adacore.com>
1059
1060         * target.h (push_target): Declare new overload.
1061         * target.c (push_target): New overload, taking an rvalue reference.
1062         * remote.c (remote_target::open_1): Use push_target overload.
1063         * corelow.c (core_target_open): Use push_target overload.
1064
1065 2019-02-15  Tom Tromey  <tromey@adacore.com>
1066
1067         * ravenscar-thread.c (is_ravenscar_task)
1068         (ravenscar_task_is_currently_active): Return bool.
1069         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1070         (_initialize_ravenscar): Remove "(void)".
1071         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1072         Return bool.
1073
1074 2019-02-15  Tom Tromey  <tromey@adacore.com>
1075
1076         * ravenscar-thread.c (ravenscar_runtime_initializer)
1077         (has_ravenscar_runtime, get_running_thread_id)
1078         (ravenscar_thread_target::resume): Fix indentation.
1079
1080 2019-02-15  Tom Tromey  <tromey@adacore.com>
1081
1082         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1083         from ravenscar_arch_ops.
1084         (sparc_ravenscar_ops::fetch_registers)
1085         (sparc_ravenscar_ops::store_registers): Now methods.
1086         (sparc_ravenscar_prepare_to_store): Remove.
1087         (sparc_ravenscar_ops): Redefine.
1088         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1089         methods and destructor.  Remove members.
1090         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1091         (ravenscar_thread_target::store_registers)
1092         (ravenscar_thread_target::prepare_to_store): Update.
1093         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1094         Remove.
1095         (struct ppc_ravenscar_powerpc_ops): Derive from
1096         ravenscar_arch_ops.
1097         (ppc_ravenscar_powerpc_ops::fetch_registers)
1098         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1099         (ppc_ravenscar_powerpc_ops): Redefine.
1100         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1101         (ppc_ravenscar_e500_ops::fetch_registers)
1102         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1103         (ppc_ravenscar_e500_ops): Redefine.
1104         * aarch64-ravenscar-thread.c
1105         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1106         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1107         (aarch64_ravenscar_fetch_registers)
1108         (aarch64_ravenscar_store_registers): Now methods.
1109         (aarch64_ravenscar_ops): Redefine.
1110
1111 2019-02-15  Tom Tromey  <tromey@adacore.com>
1112
1113         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1114         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1115         (ravenscar_thread_target::stopped_by_watchpoint)
1116         (ravenscar_thread_target::stopped_data_address)
1117         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1118
1119 2019-02-15  Tom Tromey  <tromey@adacore.com>
1120
1121         * ravenscar-thread.c: Fix some typos.
1122
1123 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1124             Tom Tromey  <tromey@adacore.com>
1125
1126         * ada-lang.c (ada_exception_sal): Change addr_string to a
1127         std::string.
1128         (create_ada_exception_catchpoint): Update.
1129
1130 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1131             Tom Tromey  <tromey@adacore.com>
1132
1133         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1134         (bp_location_ops): Remove.
1135         (base_breakpoint_allocate_location): Update.
1136         (free_bp_location): Update.
1137         * ada-lang.c (class ada_catchpoint_location)
1138         <ada_catchpoint_location>: Remove ops parameter.
1139         (ada_catchpoint_location_dtor): Remove.
1140         (ada_catchpoint_location_ops): Remove.
1141         (allocate_location_exception): Update.
1142         * breakpoint.h (struct bp_location_ops): Remove.
1143         (class bp_location) <bp_location>: Remove bp_location_ops
1144         parameter.
1145         <~bp_location>: Add destructor.
1146         <ops>: Remove.
1147
1148 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1149             Pedro Alves  <palves@redhat.com>
1150
1151         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1152         'PATH_MAX'.
1153
1154 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1155             Samuel Thibault  <samuel.thibault@gnu.org>
1156             Thomas Schwinge  <thomas@codesourcery.com>
1157
1158         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1159         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1160
1161 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1162
1163         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1164         (check_empty): Use "const char *".
1165
1166         * gnu-nat.c (gnu_nat_target::detach): Instead of
1167         'detach_inferior (pid)' call
1168         'detach_inferior (find_inferior_pid (pid))'.
1169
1170         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1171         'nat/fork-inferior.o'.
1172         * gnu-nat.c: #include "nat/fork-inferior.h".
1173
1174         * gnu-nat.c (gnu_nat_target::detach): Instead of
1175         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1176         * gnu-nat.h: #include "inf-child.h".
1177         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1178         'i386_gnu_nat_target::fetch_registers'.
1179         (gnu_store_registers): Rename/move to
1180         'i386_gnu_nat_target::store_registers'.
1181
1182         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1183         * gnu-nat.h (mach_thread_info): New function.
1184         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1185
1186         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1187
1188 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1189
1190         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1191
1192 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1193
1194         * windows-nat.c (windows_add_thread): Add new parameter
1195         "main_thread_p" with default value set to false.  Update
1196         function documentation as well as all callers.
1197         (windows_delete_thread): Likewise.
1198         (fake_create_process): Update call to windows_add_thread.
1199         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1200         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1201         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1202         call to windows_delete_thread.
1203
1204 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1205
1206         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1207
1208 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1209
1210         * symfile.c (find_separate_debug_file): Use canonical path of
1211         sysroot with child_path instead of gdb_sysroot if it is valid.
1212
1213 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1214
1215         * symfile.c (find_separate_debug_file): Use child_path to
1216         determine if an object file is under a sysroot.
1217
1218 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1219
1220         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1221         unittests/child-path-selftests.c.
1222         * common/pathstuff.c (child_path): New function.
1223         * common/pathstuff.h (child_path): New prototype.
1224         * unittests/child-path-selftests.c: New file.
1225
1226 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1227
1228         * symfile.c (find_separate_debug_file): Look for separate debug
1229         files in debug directories under the sysroot.
1230
1231 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1232
1233         * symtab.h (struct minimal_symbol data_p): New const method.
1234         (struct minimal_symbol text_p): Likewise.
1235         * symtab.c (output_source_filename): Use file name style
1236         to print file name.
1237         (print_symbol_info): Likewise.
1238         (print_msymbol_info): Use address style to print addresses.
1239         Use function name style to print executable text symbols.
1240         (expand_symtab_containing_pc): Use data_p.
1241         (find_pc_sect_compunit_symtab): Likewise.
1242
1243 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1244
1245         * breakpoint.c (describe_other_breakpoints): Use address style
1246         to print addresses.
1247         (say_where): Likewise.
1248
1249 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1250
1251         * ada-typeprint.c (print_func_type): Print function name
1252         style to print function name.
1253         * c-typeprint.c (c_print_type_1): Likewise.
1254
1255 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1258         for execve.
1259
1260 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1261
1262         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1263         type_stack.
1264
1265 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1266
1267         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1268         TYPE_CODE_REF types.
1269
1270 2019-02-08  Jim Wilson  <jimw@sifive.com>
1271
1272         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1273         (riscv_linux_fregset): New.
1274         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1275
1276 2019-02-07  Tom Tromey  <tom@tromey.com>
1277
1278         * thread.c (thread_cancel_execution_command): Update.
1279         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1280         methods.
1281         (struct thread_fsm_ops): Remove.
1282         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1283         (thread_fsm_should_stop, thread_fsm_return_value)
1284         (thread_fsm_set_finished, thread_fsm_finished_p)
1285         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1286         Don't declare.
1287         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1288         * infrun.c (clear_proceed_status_thread)
1289         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1290         (print_stop_event): Update.
1291         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1292         Add constructor.
1293         (step_command_fsm_ops): Remove.
1294         (new_step_command_fsm): Remove.
1295         (step_1): Update.
1296         (step_command_fsm::should_stop): Rename from
1297         step_command_fsm_should_stop.
1298         (step_command_fsm::clean_up): Rename from
1299         step_command_fsm_clean_up.
1300         (step_command_fsm::do_async_reply_reason): Rename from
1301         step_command_fsm_async_reply_reason.
1302         (struct until_next_fsm): Inherit from thread_fsm.  Add
1303         constructor.
1304         (until_next_fsm_ops): Remove.
1305         (new_until_next_fsm): Remove.
1306         (until_next_fsm::should_stop): Rename from
1307         until_next_fsm_should_stop.
1308         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1309         (until_next_fsm::do_async_reply_reason): Rename from
1310         until_next_fsm_async_reply_reason.
1311         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1312         constructor.  Change type of breakpoint.
1313         (finish_command_fsm_ops): Remove.
1314         (new_finish_command_fsm): Remove.
1315         (finish_command_fsm::should_stop): Rename from
1316         finish_command_fsm_should_stop.
1317         (finish_command_fsm::clean_up): Rename from
1318         finish_command_fsm_clean_up.
1319         (finish_command_fsm::return_value): Rename from
1320         finish_command_fsm_return_value.
1321         (finish_command_fsm::do_async_reply_reason): Rename from
1322         finish_command_fsm_async_reply_reason.
1323         (finish_command): Update.
1324         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1325         Add constructor.
1326         (call_thread_fsm_ops): Remove.
1327         (call_thread_fsm::call_thread_fsm): Rename from
1328         new_call_thread_fsm.
1329         (call_thread_fsm::should_stop): Rename from
1330         call_thread_fsm_should_stop.
1331         (call_thread_fsm::should_notify_stop): Rename from
1332         call_thread_fsm_should_notify_stop.
1333         (run_inferior_call, call_function_by_hand_dummy): Update.
1334         * cli/cli-interp.c (should_print_stop_to_console): Update.
1335         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1336         Add constructor.  Change type of location_breakpoint,
1337         caller_breakpoint.
1338         (until_break_fsm_ops): Remove.
1339         (new_until_break_fsm): Remove.
1340         (until_break_fsm::should_stop): Rename from
1341         until_break_fsm_should_stop.
1342         (until_break_fsm::clean_up): Rename from
1343         until_break_fsm_clean_up.
1344         (until_break_fsm::do_async_reply_reason): Rename from
1345         until_break_fsm_async_reply_reason.
1346         (until_break_command): Update.
1347         * thread-fsm.c: Remove.
1348         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1349
1350 2019-02-07  Tom Tromey  <tom@tromey.com>
1351
1352         * yy-remap.h: Add include guard.
1353         * xtensa-tdep.h: Add include guard.
1354         * xcoffread.h: Rename include guard.
1355         * varobj-iter.h: Add include guard.
1356         * tui/tui.h: Rename include guard.
1357         * tui/tui-winsource.h: Rename include guard.
1358         * tui/tui-wingeneral.h: Rename include guard.
1359         * tui/tui-windata.h: Rename include guard.
1360         * tui/tui-win.h: Rename include guard.
1361         * tui/tui-stack.h: Rename include guard.
1362         * tui/tui-source.h: Rename include guard.
1363         * tui/tui-regs.h: Rename include guard.
1364         * tui/tui-out.h: Rename include guard.
1365         * tui/tui-layout.h: Rename include guard.
1366         * tui/tui-io.h: Rename include guard.
1367         * tui/tui-hooks.h: Rename include guard.
1368         * tui/tui-file.h: Rename include guard.
1369         * tui/tui-disasm.h: Rename include guard.
1370         * tui/tui-data.h: Rename include guard.
1371         * tui/tui-command.h: Rename include guard.
1372         * tic6x-tdep.h: Add include guard.
1373         * target/waitstatus.h: Rename include guard.
1374         * target/wait.h: Rename include guard.
1375         * target/target.h: Rename include guard.
1376         * target/resume.h: Rename include guard.
1377         * target-float.h: Rename include guard.
1378         * stabsread.h: Add include guard.
1379         * rs6000-tdep.h: Add include guard.
1380         * riscv-fbsd-tdep.h: Add include guard.
1381         * regformats/regdef.h: Rename include guard.
1382         * record.h: Rename include guard.
1383         * python/python.h: Rename include guard.
1384         * python/python-internal.h: Rename include guard.
1385         * python/py-stopevent.h: Rename include guard.
1386         * python/py-ref.h: Rename include guard.
1387         * python/py-record.h: Rename include guard.
1388         * python/py-record-full.h: Rename include guard.
1389         * python/py-record-btrace.h: Rename include guard.
1390         * python/py-instruction.h: Rename include guard.
1391         * python/py-events.h: Rename include guard.
1392         * python/py-event.h: Rename include guard.
1393         * procfs.h: Add include guard.
1394         * proc-utils.h: Add include guard.
1395         * p-lang.h: Add include guard.
1396         * or1k-tdep.h: Rename include guard.
1397         * observable.h: Rename include guard.
1398         * nto-tdep.h: Rename include guard.
1399         * nat/x86-linux.h: Rename include guard.
1400         * nat/x86-linux-dregs.h: Rename include guard.
1401         * nat/x86-gcc-cpuid.h: Add include guard.
1402         * nat/x86-dregs.h: Rename include guard.
1403         * nat/x86-cpuid.h: Rename include guard.
1404         * nat/ppc-linux.h: Rename include guard.
1405         * nat/mips-linux-watch.h: Rename include guard.
1406         * nat/linux-waitpid.h: Rename include guard.
1407         * nat/linux-ptrace.h: Rename include guard.
1408         * nat/linux-procfs.h: Rename include guard.
1409         * nat/linux-osdata.h: Rename include guard.
1410         * nat/linux-nat.h: Rename include guard.
1411         * nat/linux-namespaces.h: Rename include guard.
1412         * nat/linux-btrace.h: Rename include guard.
1413         * nat/glibc_thread_db.h: Rename include guard.
1414         * nat/gdb_thread_db.h: Rename include guard.
1415         * nat/gdb_ptrace.h: Rename include guard.
1416         * nat/fork-inferior.h: Rename include guard.
1417         * nat/amd64-linux-siginfo.h: Rename include guard.
1418         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1419         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1420         * nat/aarch64-linux.h: Rename include guard.
1421         * nat/aarch64-linux-hw-point.h: Rename include guard.
1422         * mn10300-tdep.h: Add include guard.
1423         * mips-linux-tdep.h: Add include guard.
1424         * mi/mi-parse.h: Rename include guard.
1425         * mi/mi-out.h: Rename include guard.
1426         * mi/mi-main.h: Rename include guard.
1427         * mi/mi-interp.h: Rename include guard.
1428         * mi/mi-getopt.h: Rename include guard.
1429         * mi/mi-console.h: Rename include guard.
1430         * mi/mi-common.h: Rename include guard.
1431         * mi/mi-cmds.h: Rename include guard.
1432         * mi/mi-cmd-break.h: Rename include guard.
1433         * m2-lang.h: Add include guard.
1434         * location.h: Rename include guard.
1435         * linux-record.h: Rename include guard.
1436         * linux-nat.h: Add include guard.
1437         * linux-fork.h: Add include guard.
1438         * i386-darwin-tdep.h: Rename include guard.
1439         * hppa-linux-offsets.h: Add include guard.
1440         * guile/guile.h: Rename include guard.
1441         * guile/guile-internal.h: Rename include guard.
1442         * gnu-nat.h: Rename include guard.
1443         * gdb-stabs.h: Rename include guard.
1444         * frv-tdep.h: Add include guard.
1445         * f-lang.h: Add include guard.
1446         * event-loop.h: Add include guard.
1447         * darwin-nat.h: Rename include guard.
1448         * cp-abi.h: Rename include guard.
1449         * config/sparc/nm-sol2.h: Rename include guard.
1450         * config/nm-nto.h: Rename include guard.
1451         * config/nm-linux.h: Add include guard.
1452         * config/i386/nm-i386gnu.h: Rename include guard.
1453         * config/djgpp/nl_types.h: Rename include guard.
1454         * config/djgpp/langinfo.h: Rename include guard.
1455         * compile/gcc-cp-plugin.h: Add include guard.
1456         * compile/gcc-c-plugin.h: Add include guard.
1457         * compile/compile.h: Rename include guard.
1458         * compile/compile-object-run.h: Rename include guard.
1459         * compile/compile-object-load.h: Rename include guard.
1460         * compile/compile-internal.h: Rename include guard.
1461         * compile/compile-cplus.h: Rename include guard.
1462         * compile/compile-c.h: Rename include guard.
1463         * common/xml-utils.h: Rename include guard.
1464         * common/x86-xstate.h: Rename include guard.
1465         * common/version.h: Rename include guard.
1466         * common/vec.h: Rename include guard.
1467         * common/tdesc.h: Rename include guard.
1468         * common/selftest.h: Rename include guard.
1469         * common/scoped_restore.h: Rename include guard.
1470         * common/scoped_mmap.h: Rename include guard.
1471         * common/scoped_fd.h: Rename include guard.
1472         * common/safe-iterator.h: Rename include guard.
1473         * common/run-time-clock.h: Rename include guard.
1474         * common/refcounted-object.h: Rename include guard.
1475         * common/queue.h: Rename include guard.
1476         * common/ptid.h: Rename include guard.
1477         * common/print-utils.h: Rename include guard.
1478         * common/preprocessor.h: Rename include guard.
1479         * common/pathstuff.h: Rename include guard.
1480         * common/observable.h: Rename include guard.
1481         * common/netstuff.h: Rename include guard.
1482         * common/job-control.h: Rename include guard.
1483         * common/host-defs.h: Rename include guard.
1484         * common/gdb_wait.h: Rename include guard.
1485         * common/gdb_vecs.h: Rename include guard.
1486         * common/gdb_unlinker.h: Rename include guard.
1487         * common/gdb_unique_ptr.h: Rename include guard.
1488         * common/gdb_tilde_expand.h: Rename include guard.
1489         * common/gdb_sys_time.h: Rename include guard.
1490         * common/gdb_string_view.h: Rename include guard.
1491         * common/gdb_splay_tree.h: Rename include guard.
1492         * common/gdb_setjmp.h: Rename include guard.
1493         * common/gdb_ref_ptr.h: Rename include guard.
1494         * common/gdb_optional.h: Rename include guard.
1495         * common/gdb_locale.h: Rename include guard.
1496         * common/gdb_assert.h: Rename include guard.
1497         * common/filtered-iterator.h: Rename include guard.
1498         * common/filestuff.h: Rename include guard.
1499         * common/fileio.h: Rename include guard.
1500         * common/environ.h: Rename include guard.
1501         * common/common-utils.h: Rename include guard.
1502         * common/common-types.h: Rename include guard.
1503         * common/common-regcache.h: Rename include guard.
1504         * common/common-inferior.h: Rename include guard.
1505         * common/common-gdbthread.h: Rename include guard.
1506         * common/common-exceptions.h: Rename include guard.
1507         * common/common-defs.h: Rename include guard.
1508         * common/common-debug.h: Rename include guard.
1509         * common/cleanups.h: Rename include guard.
1510         * common/buffer.h: Rename include guard.
1511         * common/btrace-common.h: Rename include guard.
1512         * common/break-common.h: Rename include guard.
1513         * cli/cli-utils.h: Rename include guard.
1514         * cli/cli-style.h: Rename include guard.
1515         * cli/cli-setshow.h: Rename include guard.
1516         * cli/cli-script.h: Rename include guard.
1517         * cli/cli-interp.h: Rename include guard.
1518         * cli/cli-decode.h: Rename include guard.
1519         * cli/cli-cmds.h: Rename include guard.
1520         * charset-list.h: Add include guard.
1521         * buildsym-legacy.h: Rename include guard.
1522         * bfin-tdep.h: Add include guard.
1523         * ax.h: Rename include guard.
1524         * arm-linux-tdep.h: Add include guard.
1525         * arm-fbsd-tdep.h: Add include guard.
1526         * arch/xtensa.h: Rename include guard.
1527         * arch/tic6x.h: Add include guard.
1528         * arch/i386.h: Add include guard.
1529         * arch/arm.h: Rename include guard.
1530         * arch/arm-linux.h: Rename include guard.
1531         * arch/arm-get-next-pcs.h: Rename include guard.
1532         * arch/amd64.h: Add include guard.
1533         * arch/aarch64-insn.h: Rename include guard.
1534         * arch-utils.h: Rename include guard.
1535         * annotate.h: Add include guard.
1536         * amd64-darwin-tdep.h: Rename include guard.
1537         * aarch64-linux-tdep.h: Add include guard.
1538         * aarch64-fbsd-tdep.h: Add include guard.
1539         * aarch32-linux-nat.h: Add include guard.
1540
1541 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542
1543         * macrotab.c (macro_define_internal): New function that
1544         factorizes macro_define_object_internal and macro_define_function
1545         code.
1546         (macro_define_object_internal): Use macro_define_internal.
1547         (macro_define_function): Likewise.
1548
1549 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1550
1551         * macrocmd.c (extract_identifier): Return
1552         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1553         callers.
1554
1555 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1556
1557         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1558
1559 2019-02-05  Tom Tromey  <tom@tromey.com>
1560
1561         * target.c (target_stack::unpush): Move assertion earlier.
1562
1563 2019-01-30  Tom Tromey  <tom@tromey.com>
1564
1565         PR python/23615:
1566         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1567         (gdbpy_parse_and_eval): Likewise.
1568         * python/python-internal.h (gdbpy_allow_threads): New class.
1569
1570 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1571
1572         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1573         (aarch64_fbsd_fpregmap): Move earlier.
1574         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1575         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1576         instead of individual calls to trad_frame_set_reg_addr.
1577         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1578         earlier.
1579         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1580         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1581         instead of individual calls to trad_frame_set_reg_addr.
1582
1583 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1584
1585         * CONTRIBUTE: Replace contribution list with wiki link.
1586
1587 2019-01-25  Tom Tromey  <tom@tromey.com>
1588
1589         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1590
1591 2019-01-25  Tom Tromey  <tom@tromey.com>
1592
1593         * xtensa-linux-nat.c: Fix common/ includes.
1594         * xml-support.h: Fix common/ includes.
1595         * xml-support.c: Fix common/ includes.
1596         * x86-linux-nat.c: Fix common/ includes.
1597         * windows-nat.c: Fix common/ includes.
1598         * varobj.h: Fix common/ includes.
1599         * varobj.c: Fix common/ includes.
1600         * value.c: Fix common/ includes.
1601         * valops.c: Fix common/ includes.
1602         * utils.c: Fix common/ includes.
1603         * unittests/xml-utils-selftests.c: Fix common/ includes.
1604         * unittests/utils-selftests.c: Fix common/ includes.
1605         * unittests/unpack-selftests.c: Fix common/ includes.
1606         * unittests/tracepoint-selftests.c: Fix common/ includes.
1607         * unittests/style-selftests.c: Fix common/ includes.
1608         * unittests/string_view-selftests.c: Fix common/ includes.
1609         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1610         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1611         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1612         * unittests/rsp-low-selftests.c: Fix common/ includes.
1613         * unittests/parse-connection-spec-selftests.c: Fix common/
1614         includes.
1615         * unittests/optional-selftests.c: Fix common/ includes.
1616         * unittests/offset-type-selftests.c: Fix common/ includes.
1617         * unittests/observable-selftests.c: Fix common/ includes.
1618         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1619         * unittests/memrange-selftests.c: Fix common/ includes.
1620         * unittests/memory-map-selftests.c: Fix common/ includes.
1621         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1622         * unittests/function-view-selftests.c: Fix common/ includes.
1623         * unittests/environ-selftests.c: Fix common/ includes.
1624         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1625         * unittests/common-utils-selftests.c: Fix common/ includes.
1626         * unittests/cli-utils-selftests.c: Fix common/ includes.
1627         * unittests/array-view-selftests.c: Fix common/ includes.
1628         * ui-file.c: Fix common/ includes.
1629         * tui/tui-io.c: Fix common/ includes.
1630         * tracepoint.h: Fix common/ includes.
1631         * tracepoint.c: Fix common/ includes.
1632         * tracefile-tfile.c: Fix common/ includes.
1633         * top.h: Fix common/ includes.
1634         * top.c: Fix common/ includes.
1635         * thread.c: Fix common/ includes.
1636         * target/waitstatus.h: Fix common/ includes.
1637         * target/waitstatus.c: Fix common/ includes.
1638         * target.h: Fix common/ includes.
1639         * target.c: Fix common/ includes.
1640         * target-memory.c: Fix common/ includes.
1641         * target-descriptions.c: Fix common/ includes.
1642         * symtab.h: Fix common/ includes.
1643         * symfile.c: Fix common/ includes.
1644         * stap-probe.c: Fix common/ includes.
1645         * spu-linux-nat.c: Fix common/ includes.
1646         * sparc-nat.c: Fix common/ includes.
1647         * source.c: Fix common/ includes.
1648         * solib.c: Fix common/ includes.
1649         * solib-target.c: Fix common/ includes.
1650         * ser-unix.c: Fix common/ includes.
1651         * ser-tcp.c: Fix common/ includes.
1652         * ser-pipe.c: Fix common/ includes.
1653         * ser-base.c: Fix common/ includes.
1654         * selftest-arch.c: Fix common/ includes.
1655         * s12z-tdep.c: Fix common/ includes.
1656         * rust-exp.y: Fix common/ includes.
1657         * rs6000-aix-tdep.c: Fix common/ includes.
1658         * riscv-tdep.c: Fix common/ includes.
1659         * remote.c: Fix common/ includes.
1660         * remote-notif.h: Fix common/ includes.
1661         * remote-fileio.h: Fix common/ includes.
1662         * remote-fileio.c: Fix common/ includes.
1663         * regcache.h: Fix common/ includes.
1664         * regcache.c: Fix common/ includes.
1665         * record-btrace.c: Fix common/ includes.
1666         * python/python.c: Fix common/ includes.
1667         * python/py-type.c: Fix common/ includes.
1668         * python/py-inferior.c: Fix common/ includes.
1669         * progspace.h: Fix common/ includes.
1670         * producer.c: Fix common/ includes.
1671         * procfs.c: Fix common/ includes.
1672         * proc-api.c: Fix common/ includes.
1673         * printcmd.c: Fix common/ includes.
1674         * ppc-linux-nat.c: Fix common/ includes.
1675         * parser-defs.h: Fix common/ includes.
1676         * osdata.c: Fix common/ includes.
1677         * obsd-nat.c: Fix common/ includes.
1678         * nat/x86-linux.c: Fix common/ includes.
1679         * nat/x86-linux-dregs.c: Fix common/ includes.
1680         * nat/x86-dregs.h: Fix common/ includes.
1681         * nat/x86-dregs.c: Fix common/ includes.
1682         * nat/ppc-linux.c: Fix common/ includes.
1683         * nat/mips-linux-watch.h: Fix common/ includes.
1684         * nat/mips-linux-watch.c: Fix common/ includes.
1685         * nat/linux-waitpid.c: Fix common/ includes.
1686         * nat/linux-ptrace.h: Fix common/ includes.
1687         * nat/linux-ptrace.c: Fix common/ includes.
1688         * nat/linux-procfs.c: Fix common/ includes.
1689         * nat/linux-personality.c: Fix common/ includes.
1690         * nat/linux-osdata.c: Fix common/ includes.
1691         * nat/linux-namespaces.c: Fix common/ includes.
1692         * nat/linux-btrace.h: Fix common/ includes.
1693         * nat/linux-btrace.c: Fix common/ includes.
1694         * nat/fork-inferior.c: Fix common/ includes.
1695         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1696         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1697         * nat/aarch64-linux.c: Fix common/ includes.
1698         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1699         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1700         * namespace.h: Fix common/ includes.
1701         * mips-linux-tdep.c: Fix common/ includes.
1702         * minsyms.c: Fix common/ includes.
1703         * mi/mi-parse.h: Fix common/ includes.
1704         * mi/mi-main.c: Fix common/ includes.
1705         * mi/mi-cmd-env.c: Fix common/ includes.
1706         * memrange.h: Fix common/ includes.
1707         * memattr.c: Fix common/ includes.
1708         * maint.h: Fix common/ includes.
1709         * maint.c: Fix common/ includes.
1710         * main.c: Fix common/ includes.
1711         * machoread.c: Fix common/ includes.
1712         * location.c: Fix common/ includes.
1713         * linux-thread-db.c: Fix common/ includes.
1714         * linux-nat.c: Fix common/ includes.
1715         * linux-fork.c: Fix common/ includes.
1716         * inline-frame.c: Fix common/ includes.
1717         * infrun.c: Fix common/ includes.
1718         * inflow.c: Fix common/ includes.
1719         * inferior.h: Fix common/ includes.
1720         * inferior.c: Fix common/ includes.
1721         * infcmd.c: Fix common/ includes.
1722         * inf-ptrace.c: Fix common/ includes.
1723         * inf-child.c: Fix common/ includes.
1724         * ia64-linux-nat.c: Fix common/ includes.
1725         * i387-tdep.c: Fix common/ includes.
1726         * i386-tdep.c: Fix common/ includes.
1727         * i386-linux-tdep.c: Fix common/ includes.
1728         * i386-linux-nat.c: Fix common/ includes.
1729         * i386-go32-tdep.c: Fix common/ includes.
1730         * i386-fbsd-tdep.c: Fix common/ includes.
1731         * i386-fbsd-nat.c: Fix common/ includes.
1732         * guile/scm-type.c: Fix common/ includes.
1733         * guile/guile.c: Fix common/ includes.
1734         * go32-nat.c: Fix common/ includes.
1735         * gnu-nat.c: Fix common/ includes.
1736         * gdbthread.h: Fix common/ includes.
1737         * gdbarch-selftests.c: Fix common/ includes.
1738         * gdb_usleep.c: Fix common/ includes.
1739         * gdb_select.h: Fix common/ includes.
1740         * gdb_bfd.c: Fix common/ includes.
1741         * gcore.c: Fix common/ includes.
1742         * fork-child.c: Fix common/ includes.
1743         * findvar.c: Fix common/ includes.
1744         * fbsd-nat.c: Fix common/ includes.
1745         * event-top.c: Fix common/ includes.
1746         * event-loop.c: Fix common/ includes.
1747         * dwarf2read.c: Fix common/ includes.
1748         * dwarf2loc.c: Fix common/ includes.
1749         * dwarf2-frame.c: Fix common/ includes.
1750         * dwarf-index-cache.c: Fix common/ includes.
1751         * dtrace-probe.c: Fix common/ includes.
1752         * disasm-selftests.c: Fix common/ includes.
1753         * defs.h: Fix common/ includes.
1754         * csky-tdep.c: Fix common/ includes.
1755         * cp-valprint.c: Fix common/ includes.
1756         * cp-support.h: Fix common/ includes.
1757         * cp-support.c: Fix common/ includes.
1758         * corelow.c: Fix common/ includes.
1759         * completer.h: Fix common/ includes.
1760         * completer.c: Fix common/ includes.
1761         * compile/compile.c: Fix common/ includes.
1762         * compile/compile-loc2c.c: Fix common/ includes.
1763         * compile/compile-cplus-types.c: Fix common/ includes.
1764         * compile/compile-cplus-symbols.c: Fix common/ includes.
1765         * command.h: Fix common/ includes.
1766         * cli/cli-dump.c: Fix common/ includes.
1767         * cli/cli-cmds.c: Fix common/ includes.
1768         * charset.c: Fix common/ includes.
1769         * build-id.c: Fix common/ includes.
1770         * btrace.h: Fix common/ includes.
1771         * btrace.c: Fix common/ includes.
1772         * breakpoint.h: Fix common/ includes.
1773         * breakpoint.c: Fix common/ includes.
1774         * ax.h:
1775         (enum agent_op): Fix common/ includes.
1776         * ax-general.c (struct aop_map): Fix common/ includes.
1777         * ax-gdb.c: Fix common/ includes.
1778         * auxv.c: Fix common/ includes.
1779         * auto-load.c: Fix common/ includes.
1780         * arm-tdep.c: Fix common/ includes.
1781         * arch/riscv.c: Fix common/ includes.
1782         * arch/ppc-linux-common.c: Fix common/ includes.
1783         * arch/i386.c: Fix common/ includes.
1784         * arch/arm.c: Fix common/ includes.
1785         * arch/arm-linux.c: Fix common/ includes.
1786         * arch/arm-get-next-pcs.c: Fix common/ includes.
1787         * arch/amd64.c: Fix common/ includes.
1788         * arch/aarch64.c: Fix common/ includes.
1789         * arch/aarch64-insn.c: Fix common/ includes.
1790         * arch-utils.c: Fix common/ includes.
1791         * amd64-windows-tdep.c: Fix common/ includes.
1792         * amd64-tdep.c: Fix common/ includes.
1793         * amd64-sol2-tdep.c: Fix common/ includes.
1794         * amd64-obsd-tdep.c: Fix common/ includes.
1795         * amd64-nbsd-tdep.c: Fix common/ includes.
1796         * amd64-linux-tdep.c: Fix common/ includes.
1797         * amd64-linux-nat.c: Fix common/ includes.
1798         * amd64-fbsd-tdep.c: Fix common/ includes.
1799         * amd64-fbsd-nat.c: Fix common/ includes.
1800         * amd64-dicos-tdep.c: Fix common/ includes.
1801         * amd64-darwin-tdep.c: Fix common/ includes.
1802         * agent.c: Fix common/ includes.
1803         * ada-lang.h: Fix common/ includes.
1804         * ada-lang.c: Fix common/ includes.
1805         * aarch64-tdep.c: Fix common/ includes.
1806
1807 2019-01-25  Tom Tromey  <tom@tromey.com>
1808
1809         * common/create-version.sh: Use common/version.h.
1810
1811 2019-01-24  Pedro Alves  <palves@redhat.com>
1812
1813         * infrun.c (signal_stop, signal_print, signal_program)
1814         (signal_catch, signal_pass): Now arrays instead of pointers.
1815         (update_signals_program_target, do_target_resume)
1816         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1817         * linux-nat.c (linux_nat_target::pass_signals)
1818         (linux_nat_target::create_inferior, linux_nat_target::attach):
1819         Adjust.
1820         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1821         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1822         * procfs.c (procfs_target::pass_signals): Adjust.
1823         * record-full.c (record_full_target::resume): Adjust.
1824         * remote.c (remote_target::pass_signals)
1825         (remote_target::program_signals): Adjust.
1826         * target-debug.h (target_debug_print_signals): Now takes a
1827         gdb::array_view as parameter.  Adjust.
1828         * target.h (target_ops) <pass_signals, program_signals>: Replace
1829         pointer and length parameters with gdb::array_view.
1830         (target_pass_signals, target_program_signals): Likewise.
1831         * target-delegates.c: Regenerate.
1832
1833 2019-01-24  Pedro Alves  <palves@redhat.com>
1834
1835         * common/forward-scope-exit.h
1836         (forward_scope_exit::forward_scope_exit): Pass arguments to
1837         m_bind_function directly, instead of creating a std::bind and
1838         copying that.
1839
1840 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1841
1842         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1843         for static members.
1844         (pass_in_v_vfp_candidate): Likewise.
1845
1846 2019-01-23  Tom Tromey  <tom@tromey.com>
1847             Pedro Alves  <palves@redhat.com>
1848
1849         * regcache.c (class regcache_invalidator): Remove.
1850         (regcache::raw_write): Use make_scope_exit.
1851
1852 2019-01-23  Tom Tromey  <tom@tromey.com>
1853
1854         * ui-out.h (class ui_out_emit_type): Update comment.
1855
1856 2019-01-23  Tom Tromey  <tom@tromey.com>
1857
1858         * infrun.c (fetch_inferior_event): Update comment.
1859
1860 2019-01-23  Tom Tromey  <tom@tromey.com>
1861             Pedro Alves  <palves@redhat.com>
1862
1863         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1864         parameter.
1865         (fetch_inferior_event): Use SCOPE_EXIT.
1866
1867
1868 2019-01-23  Tom Tromey  <tom@tromey.com>
1869             Pedro Alves  <palves@redhat.com>
1870
1871         * infrun.c (disable_thread_events): Delete.
1872         (stop_all_threads): Use SCOPE_EXIT.
1873
1874 2019-01-23  Tom Tromey  <tom@tromey.com>
1875             Pedro Alves  <palves@redhat.com>
1876
1877         * symfile.c: Include forward-scope-exit.h.
1878         (clear_symtab_users_cleanup): Replace forward declaration with
1879         a FORWARD_SCOPE_EXIT.
1880         (syms_from_objfile_1): Use the forward_scope_exit and
1881         gdb::optional instead of cleanup_function.
1882         (reread_symbols): Use the forward_scope_exit instead of
1883         cleanup_function.
1884         (clear_symtab_users_cleanup): Remove function.
1885
1886 2019-01-23  Tom Tromey  <tom@tromey.com>
1887             Pedro Alves  <palves@redhat.com>
1888
1889         * linux-nat.c: Include scope-exit.h.
1890         (cleanup_target_stop): Remove.
1891         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1892         SCOPE_EXIT.
1893
1894 2019-01-23  Tom Tromey  <tom@tromey.com>
1895             Pedro Alves  <palves@redhat.com>
1896
1897         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1898         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1899
1900 2019-01-23  Tom Tromey  <tom@tromey.com>
1901             Andrew Burgess  <andrew.burgess@embecosm.com>
1902             Pedro Alves  <palves@redhat.com>
1903
1904         * infrun.c (fetch_inferior_event): Use scope_exit.
1905         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1906         * top.c (execute_command): Use scope_exit.
1907         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1908         * utils.c (do_bpstat_clear_actions_cleanup)
1909         (make_bpstat_clear_actions_cleanup): Remove.
1910
1911 2019-01-23  Tom Tromey  <tom@tromey.com>
1912             Pedro Alves  <palves@redhat.com>
1913
1914         * infrun.c: Include "common/scope-exit.h"
1915         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1916         (wait_for_inferior): Use SCOPE_EXIT.
1917         (fetch_inferior_event): Use scope_exit.
1918
1919 2019-01-23  Tom Tromey  <tom@tromey.com>
1920             Pedro Alves  <palves@redhat.com>
1921
1922         * breakpoint.c (create_breakpoint): Remove cleanup.
1923
1924 2019-01-23  Tom Tromey  <tom@tromey.com>
1925             Andrew Burgess  <andrew.burgess@embecosm.com>
1926             Pedro Alves  <palves@redhat.com>
1927
1928 2019-01-23  Pedro Alves  <palves@redhat.com>
1929
1930         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1931
1932 2019-01-23  Pedro Alves  <palves@redhat.com>
1933             Andrew Burgess  <andrew.burgess@embecosm.com>
1934
1935         * gdbthread.h: Include "common/forward-scope-exit.h".
1936         (scoped_finish_thread_state): Redefine custom class in terms of
1937         forward_scope_exit.
1938
1939 2019-01-23  Pedro Alves  <palves@redhat.com>
1940             Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * common/forward-scope-exit.h: New file.
1943
1944 2019-01-23  Pedro Alves  <palves@redhat.com>
1945             Andrew Burgess  <andrew.burgess@embecosm.com>
1946             Tom Tromey  <tom@tromey.com>
1947
1948         * common/scope-exit.h: New file.
1949
1950 2019-01-23  Pedro Alves  <palves@redhat.com>
1951
1952         * common/preprocessor.h (ESC): Rename to ...
1953         (ESC_PARENS): ... this.
1954         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1955         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1956
1957 2019-01-23  Tom Tromey  <tom@tromey.com>
1958
1959         * language.h (class scoped_switch_to_sym_language_if_auto):
1960         Initialize m_lang in both cases.
1961
1962 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1963
1964         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1965         with XCNEW.
1966
1967 2019-01-22  Tom Tromey  <tom@tromey.com>
1968
1969         * corelow.c: Do not include sys/file.h.
1970
1971 2019-01-22  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-wingeneral.h: Include gdb_curses.h.
1974
1975 2019-01-22  Tom Tromey  <tom@tromey.com>
1976
1977         * source-cache.h (class source_cache) <get_source_lines,
1978         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1979
1980 2019-01-22  Tom Tromey  <tom@tromey.com>
1981
1982         * remote-fileio.h (struct remote_target): Declare.
1983
1984 2019-01-22  Tom Tromey  <tom@tromey.com>
1985
1986         * python/py-arch.c: Do not include py-ref.h.
1987         * python/py-bpevent.c: Do not include py-ref.h.
1988         * python/py-cmd.c: Do not include py-ref.h.
1989         * python/py-continueevent.c: Do not include py-ref.h.
1990         * python/py-event.h: Do not include py-ref.h.
1991         * python/py-evtregistry.c: Do not include py-ref.h.
1992         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1993         * python/py-frame.c: Do not include py-ref.h.
1994         * python/py-framefilter.c: Do not include py-ref.h.
1995         * python/py-function.c: Do not include py-ref.h.
1996         * python/py-infevents.c: Do not include py-ref.h.
1997         * python/py-linetable.c: Do not include py-ref.h.
1998         * python/py-objfile.c: Do not include py-ref.h.
1999         * python/py-param.c: Do not include py-ref.h.
2000         * python/py-prettyprint.c: Do not include py-ref.h.
2001         * python/py-progspace.c: Do not include py-ref.h.
2002         * python/py-symbol.c: Do not include py-ref.h.
2003         * python/py-symtab.c: Do not include py-ref.h.
2004         * python/py-type.c: Do not include py-ref.h.
2005         * python/py-unwind.c: Do not include py-ref.h.
2006         * python/py-utils.c: Do not include py-ref.h.
2007         * python/py-value.c: Do not include py-ref.h.
2008         * python/py-varobj.c: Do not include py-ref.h.
2009         * python/py-xmethods.c: Do not include py-ref.h.
2010         * python/python.c: Do not include py-ref.h.
2011         * varobj.c: Do not include py-ref.h.
2012
2013 2019-01-22  Tom Tromey  <tom@tromey.com>
2014
2015         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2016         keyword for bcache.
2017
2018 2019-01-22  Tom Tromey  <tom@tromey.com>
2019
2020         * compile/compile-cplus-types.c: Remove a comment by #include.
2021
2022 2019-01-22  Tom Tromey  <tom@tromey.com>
2023
2024         * compile/gcc-c-plugin.h: Include compile-internal.h.
2025
2026 2019-01-22  Tom Tromey  <tom@tromey.com>
2027
2028         * stabsread.c (EXTERN): Do not define.
2029         (symnum, next_symbol_text_func, processing_gcc_compilation)
2030         (within_function, global_sym_chain, global_stabs)
2031         (previous_stab_code, this_object_header_files)
2032         (n_this_object_header_files)
2033         (n_allocated_this_object_header_files): Define.
2034         * stabsread.h (EXTERN): Never define.  Use "extern".
2035
2036 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2037
2038         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2039         history_value.
2040
2041 2019-01-21  Tom Tromey  <tom@tromey.com>
2042
2043         * ui-out.c: Fix includes.
2044         * tui/tui-source.c: Fix includes.
2045         * target.c: Fix includes.
2046         * remote.c: Fix includes.
2047         * regcache.c: Fix includes.
2048         * python/py-block.c: Fix includes.
2049         * printcmd.c: Fix includes.
2050         * or1k-tdep.c: Fix includes.
2051         * mi/mi-main.c: Fix includes.
2052         * m32r-tdep.c: Fix includes.
2053         * csky-tdep.c: Fix includes.
2054         * compile/compile-cplus-types.c: Fix includes.
2055         * cli/cli-interp.c: Fix includes.
2056
2057 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2058
2059         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2060         for padding.
2061
2062 2019-01-16  Tom Tromey  <tom@tromey.com>
2063
2064         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2065         earlier.
2066         (struct objfile) <msymbols_range>: Move from top level.
2067         <msymbols>: New method.
2068         (class objfile_msymbols): Remove.
2069         * symtab.c (default_collect_symbol_completion_matches_break_on):
2070         Update.
2071         * symmisc.c (dump_msymbols): Update.
2072         * stabsread.c (scan_file_globals): Update.
2073         * objc-lang.c (info_selectors_command, info_classes_command)
2074         (find_methods): Update.
2075         * minsyms.c (find_solib_trampoline_target): Update.
2076         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2077         * coffread.c (coff_symfile_read): Update.
2078         * ada-lang.c (ada_lookup_simple_minsym)
2079         (ada_collect_symbol_completion_matches): Update.
2080
2081 2019-01-16  Tom Tromey  <tom@tromey.com>
2082
2083         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2084         type.  Remove no-argument constructor.
2085         <iterator::operator++>: Simplify.
2086         <begin>: Update.
2087         <end>: Use minimal_symbol_count.
2088
2089 2019-01-16  Tom Tromey  <tom@tromey.com>
2090
2091         * objfiles.h (struct objfile) <psymtabs>: New method.
2092         (class objfile_psymtabs): Remove.
2093         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2094         typedef.
2095         <range>: New method.
2096         (require_partial_symbols): Change return type.
2097         * psymtab.c (require_partial_symbols)
2098         (psym_expand_symtabs_matching): Update.
2099         * mdebugread.c (parse_partial_symbols): Update.
2100         * dbxread.c (dbx_end_psymtab): Update.
2101
2102 2019-01-15  Tom Tromey  <tom@tromey.com>
2103
2104         * symtab.c (lookup_objfile_from_block)
2105         (lookup_symbol_in_objfile_symtabs)
2106         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2107         (find_line_symtab, info_sources_command)
2108         (default_collect_symbol_completion_matches_break_on)
2109         (make_source_files_completion_list): Update.
2110         * symmisc.c (print_objfile_statistics, dump_objfile)
2111         (maintenance_print_symbols, maintenance_info_symtabs)
2112         (maintenance_check_symtabs, maintenance_info_line_tables):
2113         Update.
2114         * source.c (select_source_symtab)
2115         (forget_cached_source_info_for_objfile): Update.
2116         * objfiles.h (class objfile_compunits): Remove.
2117         (struct objfile) <compunits_range>: New typedef.
2118         (compunits): New method.
2119         * objfiles.c (objfile_relocate1): Update.
2120         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2121         * maint.c (count_symtabs_and_blocks): Update.
2122         * linespec.c (iterate_over_all_matching_symtabs): Update.
2123         * cp-support.c (add_symbol_overload_list_qualified): Update.
2124         * coffread.c (coff_symtab_read): Update.
2125         * ada-lang.c (add_nonlocal_symbols)
2126         (ada_collect_symbol_completion_matches)
2127         (ada_add_global_exceptions): Update.
2128
2129 2019-01-15  Tom Tromey  <tom@tromey.com>
2130
2131         * progspace.h (program_space) <objfiles_safe_range>: New
2132         typedef.
2133         <objfiles_safe>: New method.
2134         * objfiles.h (class all_objfiles_safe): Remove.
2135         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2136         * jit.c (jit_inferior_exit_hook): Update.
2137
2138 2019-01-17  Tom Tromey  <tom@tromey.com>
2139
2140         * progspace.h (program_space) <objfiles_range>: New typedef.
2141         <objfiles>: New method.
2142         <objfiles_head>: Rename from objfiles.
2143         (object_files): Update.
2144         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2145         * guile/scm-pretty-print.c
2146         (ppscm_find_pretty_printer_from_objfiles): Update.
2147         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2148         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2149         Update.
2150         * python/py-progspace.c (pspy_get_objfiles): Update.
2151         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2152         Update.
2153         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2154         (objfpy_lookup_objfile_by_build_id): Update.
2155         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2156         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2157         Update.
2158         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2159         (expand_symtab_containing_pc, lookup_objfile_from_block)
2160         (lookup_static_symbol, basic_lookup_transparent_type)
2161         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2162         (find_line_symtab, info_sources_command)
2163         (default_collect_symbol_completion_matches_break_on)
2164         (make_source_files_completion_list, find_main_name): Update.
2165         * symmisc.c (print_symbol_bcache_statistics)
2166         (print_objfile_statistics, maintenance_print_symbols)
2167         (maintenance_print_msymbols, maintenance_print_objfiles)
2168         (maintenance_info_symtabs, maintenance_check_symtabs)
2169         (maintenance_expand_symtabs, maintenance_info_line_tables):
2170         Update.
2171         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2172         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2173         (map_overlay_command, unmap_overlay_command)
2174         (simple_overlay_update, expand_symtabs_matching)
2175         (map_symbol_filenames): Update.
2176         * symfile-debug.c (set_debug_symfile): Update.
2177         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2178         Update.
2179         * source.c (select_source_symtab, forget_cached_source_info):
2180         Update.
2181         * solib.c (solib_read_symbols): Update.
2182         * solib-spu.c (append_ocl_sos): Update.
2183         * psymtab.c (maintenance_print_psymbols)
2184         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2185         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2186         * printcmd.c (info_symbol_command): Update.
2187         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2188         Update.
2189         * objfiles.h (class all_objfiles): Remove.
2190         * objfiles.c (have_partial_symbols, have_full_symbols)
2191         (have_minimal_symbols, qsort_cmp, update_section_map)
2192         (shared_objfile_contains_address_p)
2193         (default_iterate_over_objfiles_in_search_order): Update.
2194         * objc-lang.c (info_selectors_command, info_classes_command)
2195         (find_methods): Update.
2196         * minsyms.c (find_solib_trampoline_target): Update.
2197         * maint.c (maintenance_info_sections)
2198         (maintenance_translate_address, count_symtabs_and_blocks):
2199         Update.
2200         * main.c (captured_main_1): Update.
2201         * linux-thread-db.c (try_thread_db_load_from_pdir)
2202         (has_libpthread): Update.
2203         * linespec.c (iterate_over_all_matching_symtabs)
2204         (search_minsyms_for_name): Update.
2205         * jit.c (jit_find_objf_with_entry_addr): Update.
2206         * hppa-tdep.c (find_unwind_entry)
2207         (hppa_lookup_stub_minimal_symbol): Update.
2208         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2209         Update.
2210         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2211         (elf_gnu_ifunc_resolve_by_got): Update.
2212         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2213         * dwarf-index-write.c (save_gdb_index_command): Update.
2214         * cp-support.c (add_symbol_overload_list_qualified): Update.
2215         * breakpoint.c (create_overlay_event_breakpoint)
2216         (create_longjmp_master_breakpoint)
2217         (create_std_terminate_master_breakpoint)
2218         (create_exception_master_breakpoint): Update.
2219         * blockframe.c (find_pc_partial_function): Update.
2220         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2221         (ada_collect_symbol_completion_matches)
2222         (ada_add_global_exceptions): Update.
2223
2224 2019-01-17  Tom Tromey  <tom@tromey.com>
2225
2226         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2227         declare VEC.
2228         (solib_target_parse_libraries): Change return type.
2229         (library_list_start_segment, library_list_start_section)
2230         (library_list_end_library, library_list_start_library); Update.
2231         (solib_target_free_library_list): Remove.
2232         (solib_target_parse_libraries): Remove cleanup.  Change return
2233         type.
2234         (solib_target_current_sos): Update.
2235
2236 2019-01-17  Tom Tromey  <tromey@bapiya>
2237
2238         * valprint.c: Replace "the the" with "the".
2239         * symtab.c: Replace "the the" with "the".
2240         * solib.c: Replace "the the" with "the".
2241         * solib-dsbt.c: Replace "the the" with "the".
2242         * linespec.c: Replace "the the" with "the".
2243         * dwarf2loc.h: Replace "the the" with "the".
2244         * amd64-windows-tdep.c: Replace "the the" with "the".
2245         * aarch64-tdep.c: Replace "the the" with "the".
2246
2247 2019-01-16  Keith Seitz  <keiths@redhat.com>
2248
2249         PR gdb/23773
2250         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2251         <builder>: Rename to ..
2252         <m_builder>: ... this and make private.
2253         (dwarf2_cu::get_builder): New method.  Change all users of
2254         `builder' to use this method.
2255         (dwarf2_start_symtab): Move to ...
2256         (dwarf2_cu::start_symtab): ... here.  Update all callers
2257         (setup_type_unit_groups): Move to ...
2258         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2259         callers.
2260         (dwarf2_cu::reset_builder): New method.
2261         (process_full_compunit, process_full_type_unit): Use
2262         dwarf2_cu::reset_builder.
2263         (follow_die_offset): Record the ancestor CU if it is different
2264         from the followed DIE's CU.
2265         (follow_die_sig_1): Likewise.
2266
2267 2019-01-15  Tom Tromey  <tom@tromey.com>
2268
2269         * remote.c (class remote_state) <buf>: Now a char_vector.
2270         <buf_size>: Remove.
2271         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2272         parameter.
2273         (remote_target::getpkt_or_notif_sane_1)
2274         (remote_target::getpkt_sane)
2275         (remote_target::getpkt_or_notif_sane): Likewise.
2276         (class remote_target) <putpkt>: New overload.
2277         (remote_target::read_frame): Change type of "buf_p".  Remove
2278         sizeof_p parameter.
2279         (packet_ok): New overload.
2280         (packet_check_result): New overload.
2281         Update all uses.
2282
2283 2019-01-14  Tom Tromey  <tom@tromey.com>
2284
2285         * remote-notif.c (handle_notification, remote_notif_ack)
2286         (remote_notif_parse): Make "buf" const.
2287         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2288         const.
2289         (remote_notif_parse, remote_notif_ack, handle_notification):
2290         Likewise.
2291         * remote.c (remote_notif_stop_parse): Make "buf" const.
2292         (remote_target::remote_parse_stop_reply): Make "buf" const.
2293         (remote_notif_stop_ack): Make "buf" const.
2294
2295 2019-01-14  Tom Tromey  <tom@tromey.com>
2296
2297         * remote.c (remote_console_output): Make parameter const.
2298
2299 2019-01-14  Tom Tromey  <tom@tromey.com>
2300
2301         * target-debug.h (target_debug_print_signals): Constify.
2302         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2303         * procfs.c (procfs_target::pass_signals): Update.
2304         * linux-nat.c (linux_nat_target::pass_signals): Update.
2305         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2306         * target-delegates.c: Rebuild.
2307         * remote.c (remote_target::program_signals): Update.
2308         (remote_target::pass_signals): Update.
2309         * target.c (target_pass_signals): Constify argument.
2310         (target_program_signals): Likewise.
2311         * target.h (struct target_ops) <pass_signals, program_signals>:
2312         Constify argument.
2313         (target_pass_signals, target_program_signals): Constify argument.
2314
2315 2019-01-14  Tom Tromey  <tom@tromey.com>
2316
2317         PR tui/28819:
2318         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2319
2320 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2321
2322         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2323         field.
2324         * rs6000-tdep.c: Include reggroups.h.
2325         (IS_V_ALIAS_PSEUDOREG): Define.
2326         (rs6000_register_name): Return names for the "vX" aliases.
2327         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2328         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2329         aliases.  Call default_register_reggroup_p for all other
2330         pseudo-registers.
2331         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2332         New functions.
2333         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2334         Handle "vX" aliases.
2335         (v_alias_pseudo_register_collect): New function.
2336         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2337         (rs6000_gdbarch_init): Initialize "vX" aliases as
2338         pseudo-registers.  Restore registration of
2339         rs6000_pseudo_register_reggroup_p with
2340         set_tdesc_pseudo_register_reggroup_p.
2341
2342 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2343
2344         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2345         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2346         set_gdbarch_num_pseudo_regs.
2347
2348 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2349
2350         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2351         Remove arg prefixname, add do_set and do_show.
2352         Add member functions set_list and show_list.
2353         * cli/cli-style.c (class cli_style_option): Update accordingly.
2354         (style_set_list): Move to file scope.
2355         (style_show_list): Likewise.
2356         (set_style): Call help_list.
2357         (show_style): Call cmd_show_list.
2358         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2359         Update to use the new macro.
2360
2361 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2362
2363         * ada-lang.c (_initialize_ada_language): Expand the help text
2364         for the "catch exception" command.
2365
2366 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * symtab.c (matching_obj_sections): Initialize obj,
2369         declare it closer to its usage.
2370
2371 2019-01-10  Tom Tromey  <tom@tromey.com>
2372
2373         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2374         (basic_inf_threads_range): Remove.
2375         (inf_threads_range, inf_non_exited_threads_range)
2376         (safe_inf_threads_range): Use next_adapter.
2377
2378 2019-01-10  Keith Seitz  <keiths@redhat.com>
2379
2380         PR gdb/23712
2381         PR symtab/23010
2382         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2383         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2384
2385 2019-01-10  Keith Seitz  <keiths@redhat.com>
2386
2387         PR gdb/23712
2388         PR symtab/23010
2389         * dictionary.c (pending_to_vector): Remove.
2390         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2391         Remove _1 suffix, replacing functions of the same name.  Update
2392         all callers.
2393         (dict_create_hashed, dict_create_hashed_expandable)
2394         (dict_create_linear, dict_create_linear_expandable, dict_free)
2395         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2396         Make functions static.
2397
2398 2019-01-10  Keith Seitz  <keiths@redhat.com>
2399
2400         PR gdb/23712
2401         PR symtab/23010
2402         * dictionary.h (struct dictionary): Replace declaration with
2403         multidictionary.
2404         (dict_create_hashed, dict_create_hashed_expandable)
2405         (dict_create_linear, dict_create_linear_expandable)
2406         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2407         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2408         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2409         taking multidictionary argument.
2410         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2411         * block.h (struct block) <dict>: Change to multidictionary
2412         and rename `multidict'.
2413         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2414         symmisc.c: Update all dictionary references to multidictionary.
2415
2416 2019-01-10  Keith Seitz  <keiths@redhat.com>
2417
2418         PR gdb/23712
2419         PR symtab/23010
2420         * dictionary.c: Include unordered_map.
2421         (pending_to_vector): New function.
2422         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2423         Rewrite the non-"_1" functions to take vector instead
2424         of linked list.
2425         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2426         "new" _1 versions of the same name.
2427         (multidictionary): Define.
2428         (std::hash<enum language): New definition.
2429         (collate_pending_symbols_by_language, mdict_create_hashed)
2430         (mdict_create_hashed_expandable, mdict_create_linear)
2431         (mdict_create_linear_expandable, mdict_free)
2432         (find_language_dictionary, create_new_language_dictionary)
2433         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2434         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2435         (mdict_size, mdict_empty): New functions.
2436         * dictionary.h (mdict_iterator): Define.
2437
2438 2019-01-10  Pedro Alves  <palves@redhat.com>
2439
2440         * breakpoint.c (read_uploaded_action)
2441         (create_tracepoint_from_upload): Adjust to use
2442         gdb::unique_xmalloc_ptr.
2443         * ctf.c (ctf_write_uploaded_tp):
2444         (SET_ARRAY_FIELD): Use emplace_back.
2445         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2446         * tracefile-tfile.c (tfile_write_uploaded_tp):
2447         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2448         gdb::unique_xmalloc_ptr.
2449         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2450         at_string, cond_string, cmd_strings>: Replace char pointers
2451         with gdb::unique_xmalloc_ptr.
2452
2453 2019-01-10  Pedro Alves  <palves@redhat.com>
2454
2455         * solib-target.c (library_list_start_library): Don't xstrdup name.
2456
2457 2019-01-10  Pedro Alves  <palves@redhat.com>
2458
2459         * mdebugread.c (parse_partial_symbols): Use
2460         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2461
2462 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * linux-fork.c (scoped_switch_fork_info)
2465         <~scoped_switch_fork_info>: Fix incorrect variable name.
2466
2467 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * linux-fork.c (scoped_switch_fork_info)
2470         <scoped_switch_fork_info>: Make explicit.
2471         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2472
2473 2019-01-10  Tom Tromey  <tom@tromey.com>
2474
2475         * objfiles.h (objfile::reset_psymtabs): Update.
2476         * objfiles.c (objfile::objfile): Update.
2477         * psymtab.h (psymtab_storage::obstack): Update.
2478         (psymtab_storage::m_obstack): Use gdb::optional.
2479         (class psymtab_storage): Update comment.  Remove objfile
2480         parameter.
2481         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2482
2483 2019-01-10  Tom Tromey  <tom@tromey.com>
2484
2485         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2486         <free_psymtabs>: Now private.
2487         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2488         (allocate_psymtab): Use new method.
2489
2490 2019-01-10  Tom Tromey  <tom@tromey.com>
2491
2492         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2493         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2494         * mdebugread.c (parse_partial_symbols): Use
2495         allocate_dependencies.
2496         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2497         allocate_dependencies.
2498         (process_psymtab_comp_unit_reader)
2499         (build_type_psymtab_dependencies): Likewise.
2500         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2501
2502 2019-01-10  Tom Tromey  <tom@tromey.com>
2503
2504         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2505         PSYMBOL_SET_LANGUAGE.
2506         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2507
2508 2019-01-10  Tom Tromey  <tom@tromey.com>
2509
2510         * psymtab.h (psymtab_storage::obstack): New method.
2511         <m_obstack>: Rename from obstack; now private.
2512         * psymtab.c (psymtab_storage): Update.
2513         * dwarf2read.c (create_addrmap_from_index)
2514         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2515         Update.
2516
2517 2019-01-10  Tom Tromey  <tom@tromey.com>
2518
2519         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2520         * objfiles.h (objfile::reset_psymtabs): New method.
2521
2522 2019-01-10  Tom Tromey  <tom@tromey.com>
2523
2524         * symmisc.c (print_symbol_bcache_statistics): Update.
2525         (print_objfile_statistics): Update.
2526         * symfile.c (reread_symbols): Update.
2527         * psymtab.h (class psymtab_storage): New.
2528         * psymtab.c (psymtab_storage): New constructor.
2529         (~psymtab_storage): New destructor.
2530         (require_partial_symbols): Update.
2531         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2532         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2533         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2534         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2535         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2536         (start_psymtab_common, end_psymtab_common)
2537         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2538         (allocate_psymtab): Update.
2539         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2540         Update.
2541         (dump_psymtab_addrmap, maintenance_print_psymbols)
2542         (maintenance_check_psymtabs): Update.
2543         (class objfile_psymtabs): Move to objfiles.h.
2544         * psympriv.h (discard_psymtab): Now inline.
2545         (psymtab_discarder::psymtab_discarder): Update.
2546         (psymtab_discarder::~psymtab_discarder): Update.
2547         (ALL_OBJFILE_PSYMTABS): Rewrite.
2548         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2549         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2550         Remove fields.
2551         <partial_symtabs>: New field.
2552         (class objfile_psymtabs): Move from psymtab.h.  Update.
2553         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2554         psymbol_cache.
2555         (objfile::~objfile): Don't destroy psymbol_cache.
2556         * mdebugread.c (parse_partial_symbols): Update.
2557         * dwarf2read.c (create_addrmap_from_index)
2558         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2559         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2560         (add_partial_subprogram, dwarf2_ranges_read): Update.
2561         * dwarf-index-write.c (write_address_map)
2562         (write_one_signatured_type, recursively_write_psymbols)
2563         (class debug_names, class debug_names, write_psymtabs_to_index):
2564         Update.
2565
2566 2019-01-10  Tom Tromey  <tom@tromey.com>
2567
2568         * symtab.h (SYMBOL_SET_NAMES): Update.
2569         (symbol_set_names): Update.
2570         (MSYMBOL_SET_NAMES): Update.
2571         * symtab.c (symbol_set_names): Change argument to be an
2572         objfile_per_bfd_storage.
2573         * psymtab.c (add_psymbol_to_bcache): Update.
2574         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2575
2576 2019-01-10  Tom Tromey  <tom@tromey.com>
2577
2578         * symtab.c (create_demangled_names_hash): Change argument to be an
2579         objfile_per_bfd_storage.
2580         (symbol_set_names): Update.
2581
2582 2019-01-10  Tom Tromey  <tom@tromey.com>
2583
2584         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2585         init_psymbol_list.
2586         * psymtab.c (init_psymbol_list): Do nothing if already called.
2587         * psympriv.h (init_psymbol_list): Add comment.
2588         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2589         init_psymbol_list.
2590         * dbxread.c (dbx_symfile_read): Unconditionally call
2591         init_psymbol_list.
2592
2593 2019-01-10  Tom Tromey  <tom@tromey.com>
2594
2595         * xcoffread.c (scan_xcoff_symtab): Update.
2596         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2597         "where".
2598         * mdebugread.c (parse_partial_symbols)
2599         (handle_psymbol_enumerators): Update.
2600         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2601         * dbxread.c (read_dbx_symtab): Update.
2602         * psympriv.h (psymbol_placement): New enum.
2603         (add_psymbol_to_list): Update.
2604
2605 2019-01-10  Tom Tromey  <tom@tromey.com>
2606
2607         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2608         static_psymbols parameters.
2609         (scan_xcoff_symtab): Update.
2610         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2611         static_psymbols parameters.
2612         * psympriv.h (start_psymtab_common): Update.
2613         * mdebugread.c (parse_partial_symbols): Update.
2614         * dwarf2read.c (create_partial_symtab): Update.
2615         * dbxread.c (read_dbx_symtab): Update.
2616         (start_psymtab): Remove global_psymbols and static_psymbols
2617         parameters.
2618
2619 2019-01-10  Tom Tromey  <tom@tromey.com>
2620
2621         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2622         * psymtab.c (allocate_psymtab): Add comment.
2623         * psympriv.h (allocate_psymtab): Add comment.
2624         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2625         initializations.
2626         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2627
2628 2019-01-10  Tom Tromey  <tom@tromey.com>
2629
2630         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2631         Don't declare.
2632         * mipsread.c: Include mdebugread.h.
2633         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2634         Declare.
2635         * elfread.c: Include mdebugread.h.
2636
2637 2019-01-09  Tom Tromey  <tom@tromey.com>
2638
2639         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2640         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2641         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2642         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2643         (psym_lookup_symbol, psym_find_last_source_symtab)
2644         (psym_forget_cached_source_info, psym_print_stats)
2645         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2646         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2647         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2648         (psym_find_compunit_symtab_by_address)
2649         (maintenance_print_psymbols, maintenance_info_psymtabs)
2650         (maintenance_check_psymtabs): Use ranged for.
2651         * psymtab.h (class objfile_psymtabs): New.
2652         (require_partial_symbols): Return objfile_psymtabs.
2653         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2654
2655 2019-01-09  Tom Tromey  <tom@tromey.com>
2656
2657         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2658         (find_pc_mapped_section, list_overlays_command)
2659         (map_overlay_command, unmap_overlay_command)
2660         (simple_overlay_update): Use all_objfiles.
2661         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2662         * printcmd.c (info_symbol_command): Use all_objfiles.
2663         * objfiles.h (ALL_OBJSECTIONS): Remove.
2664         * maint.c (maintenance_translate_address): Use all_objfiles.
2665         * gcore.c (gcore_create_callback): Use all_objfiles.
2666         (objfile_find_memory_regions): Likewise.
2667
2668 2019-01-09  Tom Tromey  <tom@tromey.com>
2669
2670         * symtab.c (find_line_symtab, info_sources_command)
2671         (make_source_files_completion_list): Use objfile_compunits.
2672         * source.c (select_source_symtab): Use objfile_compunits.
2673         * objfiles.h (struct objfile): Update comment.
2674         (ALL_OBJFILES): Remove.
2675         (ALL_FILETABS): Remove.
2676         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2677         objfile_compunits.
2678
2679 2019-01-09  Tom Tromey  <tom@tromey.com>
2680
2681         * symmisc.c (print_objfile_statistics, dump_objfile)
2682         (maintenance_print_symbols): Use compunit_filetabs.
2683         * source.c (forget_cached_source_info_for_objfile): Use
2684         compunit_filetabs.
2685         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2686         (ALL_FILETABS): Use compunit_filetabs.
2687         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2688         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2689
2690 2019-01-09  Tom Tromey  <tom@tromey.com>
2691
2692         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2693         (compunit_filetabs): New.
2694         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2695         compunit_filetabs.
2696         (info_sources_command, make_source_files_completion_list): Remove
2697         declaration.
2698         * symmisc.c (print_objfile_statistics, dump_objfile)
2699         (maintenance_print_symbols): Remove declaration.
2700         (maintenance_info_symtabs): Use compunit_filetabs.
2701         (maintenance_info_line_tables): Likewise.
2702         * source.c (select_source_symtab): Change local variable name.
2703         (forget_cached_source_info_for_objfile): Remove declaration.
2704         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2705         * objfiles.c (objfile_relocate1): Remove declaration.
2706         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2707         declaration.
2708         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2709         * coffread.c (coff_symtab_read): Remove declaration.
2710         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2711         compunit_filetabs.
2712
2713 2019-01-09  Tom Tromey  <tom@tromey.com>
2714
2715         * symtab.c (lookup_objfile_from_block)
2716         (find_pc_sect_compunit_symtab, search_symbols)
2717         (default_collect_symbol_completion_matches_break_on): Use
2718         objfile_compunits.
2719         * objfiles.h (ALL_COMPUNITS): Remove.
2720         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2721         * cp-support.c (add_symbol_overload_list_qualified): Use
2722         objfile_compunits.
2723         * ada-lang.c (ada_collect_symbol_completion_matches)
2724         (ada_add_global_exceptions): Use objfile_compunits.
2725
2726 2019-01-09  Tom Tromey  <tom@tromey.com>
2727
2728         * source.c (select_source_symtab)
2729         (forget_cached_source_info_for_objfile): Remove declaration.
2730         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2731         declaration.
2732         * maint.c (count_symtabs_and_blocks): Remove declaration.
2733         * cp-support.c (add_symbol_overload_list_qualified): Remove
2734         declaration.
2735         * coffread.c (coff_symtab_read): Remove declaration.
2736         * symtab.c (lookup_symbol_in_objfile_symtabs)
2737         (basic_lookup_transparent_type_1): Use objfile_compunits.
2738         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2739         (info_sources_command, search_symbols)
2740         (default_collect_symbol_completion_matches_break_on)
2741         (make_source_files_completion_list): Remove declaration.
2742         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2743         (ada_collect_symbol_completion_matches)
2744         (ada_add_global_exceptions): Remove declaration.
2745         * linespec.c (iterate_over_all_matching_symtabs): Use
2746         objfile_compunits.
2747         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2748         (class objfile_compunits): New.
2749         (ALL_COMPUNITS): Use objfile_compunits.
2750         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2751         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2752         objfile_compunits.
2753         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2754
2755 2019-01-09  Tom Tromey  <tom@tromey.com>
2756
2757         * symtab.c (search_symbols)
2758         (default_collect_symbol_completion_matches_break_on): Use
2759         objfile_msymbols.
2760         * ada-lang.c (ada_lookup_simple_minsym)
2761         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2762         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2763         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2764         objfile_msymbols.
2765         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2766         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2767         * objc-lang.c (find_methods): Use objfile_msymbols.
2768         (info_selectors_command, info_classes_command): Likewise.
2769         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2770         * objfiles.h (class objfile_msymbols): New.
2771         (ALL_OBJFILE_MSYMBOLS): Remove.
2772         (ALL_MSYMBOLS): Remove.
2773
2774 2019-01-09  Tom Tromey  <tom@tromey.com>
2775
2776         * common/next-iterator.h (next_adapter): Add Iterator template
2777         parameter.
2778         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2779         (class all_objfiles_safe): New.
2780         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2781         * objfiles.c (put_objfile_before): Update comment.
2782         (add_separate_debug_objfile): Likewise.
2783         (free_all_objfiles): Use all_objfiles_safe.
2784         (objfile_purge_solibs): Likewise.
2785
2786 2019-01-09  Tom Tromey  <tom@tromey.com>
2787
2788         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2789         (expand_symtab_containing_pc, lookup_static_symbol)
2790         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2791         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2792         all_objfiles.
2793         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2794         * breakpoint.c (create_overlay_event_breakpoint)
2795         (create_longjmp_master_breakpoint)
2796         (create_std_terminate_master_breakpoint)
2797         (create_exception_master_breakpoint): Use all_objfiles.
2798         * linux-thread-db.c (try_thread_db_load_from_pdir)
2799         (has_libpthread): Use all_objfiles.
2800         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2801         * linespec.c (iterate_over_all_matching_symtabs)
2802         (search_minsyms_for_name): Use all_objfiles.
2803         * maint.c (maintenance_info_sections): Use all_objfiles.
2804         * main.c (captured_main_1): Use all_objfiles.
2805         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2806         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2807         * guile/scm-pretty-print.c
2808         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2809         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2810         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2811         (maintenance_print_msymbols): Use all_objfiles.
2812         * source.c (select_source_symtab): Use all_objfiles.
2813         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2814         * symfile.c (remove_symbol_file_command)
2815         (expand_symtabs_matching, map_symbol_filenames): Use
2816         all_objfiles.
2817         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2818         all_objfiles.
2819         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2820         * objc-lang.c (find_methods): Use all_objfiles.
2821         * objfiles.c (have_partial_symbols, have_full_symbols)
2822         (have_minimal_symbols, qsort_cmp)
2823         (default_iterate_over_objfiles_in_search_order): Use
2824         all_objfiles.
2825         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2826         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2827         (maintenance_check_psymtabs): Use all_objfiles.
2828         (ALL_PSYMTABS): Remove.
2829         * compile/compile-object-run.c (do_module_cleanup): Use
2830         all_objfiles.
2831         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2832         * cp-support.c (add_symbol_overload_list_qualified): Use
2833         all_objfiles.
2834         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2835         Use all_objfiles.
2836         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2837         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2838         all_objfiles.
2839         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2840         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2841         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2842         Uses all_objfiles.
2843         * solib.c (solib_read_symbols): Use all_objfiles
2844
2845 2019-01-09  Tom Tromey  <tom@tromey.com>
2846
2847         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2848         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2849         all_objfiles.
2850         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2851         * symmisc.c (print_symbol_bcache_statistics)
2852         (print_objfile_statistics, maintenance_print_objfiles)
2853         (maintenance_info_symtabs, maintenance_check_symtabs)
2854         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2855         all_objfiles.
2856         * source.c (forget_cached_source_info): Use all_objfiles.
2857         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2858         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2859         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2860         * objfiles.c (update_section_map): Use all_objfiles.
2861         (shared_objfile_contains_address_p): Likewise.
2862         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2863         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2864
2865 2019-01-09  Tom Tromey  <tom@tromey.com>
2866
2867         * common/next-iterator.h: New file.
2868         * objfiles.h (class all_objfiles): New.
2869         (struct objfile_iterator): New.
2870
2871 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2872
2873         * NEWS: Move the description of the changed "frame", "select-frame",
2874          and "info frame" commands to the Changed commands section.
2875
2876 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2877
2878         * gdbtypes.c (check_stub_method_group): Remove handling of old
2879         mangling schemes.
2880         * linespec.c (find_methods): Likewise.
2881         * stabsread.c (read_member_functions): Likewise.
2882         * valops.c (search_struct_method): Likewise.
2883         (value_struct_elt_for_reference): Likewise.
2884         * NEWS: Mention this change.
2885
2886 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2889         print_source_lines.
2890         * source.c (print_source_lines_base): Update line number check.
2891         (print_source_lines): New function.
2892         (source_lines_range::source_lines_range): New function.
2893         * source.h (class source_lines_range): New class.
2894         (print_source_lines): New declaration.
2895
2896 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2897
2898         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2899
2900 2019-01-08  Tom Tromey  <tom@tromey.com>
2901             Simon Marchi  <simon.marchi@ericsson.com>
2902
2903         PR gdb/24060
2904         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2905         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2906         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2907         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2908         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2909         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2910
2911 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * source.c (select_source_symtab): Move header comment to
2914         declaration in source.h.
2915         (forget_cached_source_info_for_objfile): Likewise.
2916         (forget_cached_source_info): Likewise.
2917         (identify_source_line): Likewise.
2918         * source.h (identify_source_line): Move declaration from symtab.h
2919         and add comment from source.c
2920         (print_source_lines): Likewise.
2921         (forget_cached_source_info_for_objfile): Likewise.
2922         (forget_cached_source_info): Likewise.
2923         (select_source_symtab): Likewise.
2924         (enum print_source_lines_flag): Move definition from symtab.h.
2925         * symtab.h (identify_source_line): Move declaration to source.h.
2926         (print_source_lines): Likewise.
2927         (forget_cached_source_info_for_objfile): Likewise.
2928         (forget_cached_source_info): Likewise.
2929         (select_source_symtab): Likewise.
2930         (enum print_source_lines_flag): Move definition to source.h.
2931         * tui/tui-hooks.c: Add 'source.h' include.
2932
2933 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * source.c (print_source_lines_base): Handle requests to print
2936         reverse line number sequences, and guard against empty lines
2937         string.
2938
2939 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * source.c (print_source_lines_base): Fix skip of '\r' if next
2942         character is '\n'.
2943
2944 2019-01-06  Tom Tromey  <tom@tromey.com>
2945
2946         * c-exp.y (struct c_parse_state) <macro_original_text,
2947         expansion_obstack>: New member.
2948         (macro_original_text, expansion_obstack): Remove globals.
2949         (scan_macro_expansion, scanning_macro_expansion)
2950         (finished_macro_expansion): Update.
2951         (scan_macro_cleanup): Remove.
2952         (yylex, c_parse): Update.
2953
2954 2019-01-06  Tom Tromey  <tom@tromey.com>
2955
2956         * c-exp.y (struct c_parse_state) <strings>: New member.
2957         (operator_stoken): Update.
2958
2959 2019-01-06  Tom Tromey  <tom@tromey.com>
2960
2961         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2962         (union type_stack_elt) <typelist_val>: Now a pointer to
2963         std::vector.
2964         (type_stack_cleanup): Don't declare.
2965         (push_typelist): Update.
2966         * parse.c (pop_typelist): Return a std::vector.
2967         (push_typelist): Take a std::vector.
2968         (follow_types): Update.  Do not free args.
2969         (type_stack_cleanup): Remove.
2970         * c-exp.y (struct c_parse_state): New.
2971         (cpstate): New global.
2972         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2973         (nonempty_typelist): Update.
2974         (func_mod): Create a new vector.
2975         (c_parse): Create a c_parse_state.
2976         (check_parameter_typelist): Do not delete params.
2977         (function_method): Update.  Do not delete type_list.
2978
2979 2019-01-06  Tom Tromey  <tom@tromey.com>
2980
2981         PR gdb/28155:
2982         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2983         check_typedef.
2984         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2985         (print_return_value): Likewise.
2986
2987 2019-01-05  Tom Tromey  <tom@tromey.com>
2988
2989         * contrib/cleanup_check.py: Remove.
2990         * contrib/gcc-with-excheck: Remove.
2991         * contrib/exsummary.py: Remove.
2992         * contrib/excheck.py: Remove.
2993
2994 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2995
2996         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2997         NULL. Initialize tpprev to NULL instead of assigning it
2998         to NULL on the next statement.
2999         * windows-nat.c (windows_delete_thread): Remove check for
3000         main_thread_id before printing thread exit notifications.
3001         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3002         Remove thread ID check against main_thread_id.
3003         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3004         windows_delete_thread.
3005         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3006
3007 2019-01-04  Tom Tromey  <tom@tromey.com>
3008
3009         * compile/compile.c (_initialize_compile): Use upper case for
3010         metasyntactic variables.
3011         * symmisc.c (_initialize_symmisc): Use upper case for
3012         metasyntactic variables.
3013         * psymtab.c (_initialize_psymtab): Use upper case for
3014         metasyntactic variables.
3015         * demangle.c (demangle_command): Use upper case for metasyntactic
3016         variables.
3017         (_initialize_demangler): Likewise.
3018         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3019         variables.
3020
3021 2019-01-03  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3024
3025 2019-01-03  Tom Tromey  <tom@tromey.com>
3026
3027         * python/py-symtab.c (salpy_str): Update.
3028         (struct salpy_sal_object) <symtab>: Now a PyObject.
3029         (salpy_dealloc): Update.
3030         (del_objfile_sal): Use gdbpy_ref.
3031
3032 2019-01-03  Tom Tromey  <tom@tromey.com>
3033
3034         * python/py-type.c (convert_field): Use new_reference.  Return
3035         gdbpy_ref.
3036         (make_fielditem): Return gdbpy_ref.
3037         (typy_fields): Update.
3038         (typy_getitem): Update.
3039         (field_name): Return gdbpy_ref.  Use new_reference.
3040         (typy_iterator_iternext): Update.
3041
3042 2019-01-03  Tom Tromey  <tom@tromey.com>
3043
3044         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3045
3046 2019-01-03  Tom Tromey  <tom@tromey.com>
3047
3048         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3049         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3050         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3051         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3052         (pspy_set_type_printers): Likewise.
3053         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3054         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3055         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3056         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3057         (objfpy_set_type_printers): Likewise.
3058
3059 2019-01-03  Tom Tromey  <tom@tromey.com>
3060
3061         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3062         (gdbpy_print_stack): Use gdbpy_err_fetch.
3063         * python/python-internal.h (class gdbpy_err_fetch): New class.
3064         (class gdbpy_enter) <m_error_type, m_error_value,
3065         m_error_traceback>: Remove.
3066         <m_error>: New member.
3067         (gdbpy_exception_to_string): Don't declare.
3068         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3069         * python/py-value.c (convert_value_from_python): Use
3070         gdbpy_err_fetch.
3071         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3072         gdbpy_exception_to_string.
3073         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3074         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3075         gdbpy_err_fetch.
3076
3077 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * linux-nat.c (delete_lwp_cleanup): Delete.
3080         (struct lwp_deleter): New struct.
3081         (lwp_info_up): New typedef.
3082         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3083         lwp_info_up.
3084
3085 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * linux-fork.c (class scoped_switch_fork_info): New class.
3088         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3089
3090 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3091
3092         * valops.c (find_overload_match): Remove use of null_cleanup, and
3093         calls to do_cleanups.
3094
3095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * compile/compile-cplus-types.c
3098         (compile_cplus_instance::decl_name): Handle changes to
3099         cp_func_name.
3100         * cp-support.c (cp_func_name): Update header comment, update
3101         return type.
3102         * cp-support.h (cp_func_name): Update return type in declaration.
3103         * valops.c (find_overload_match): Move temp_func local to top
3104         level of function and change its type.  Use temp_func to hold and
3105         delete temporary string obtained from cp_func_name.
3106
3107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3108
3109         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3110         gdb::char_vector, remove cleanup, and update uses of `msg`.
3111
3112 2019-01-03  Jim Wilson  <jimw@sifive.com>
3113
3114         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3115
3116 2019-01-02  Tom Tromey  <tom@tromey.com>
3117
3118         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3119         (tdesc_parse_xml): Remove cleanups.
3120         * target-descriptions.h (make_cleanup_free_target_description):
3121         Don't declare.
3122         (target_desc_deleter): New struct.
3123         (target_desc_up): New typedef.
3124         * target-descriptions.c (target_desc_deleter::operator()): Rename
3125         from free_target_description.
3126         (make_cleanup_free_target_description): Remove.
3127
3128 2019-01-02  Tom Tromey  <tom@tromey.com>
3129
3130         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3131         constructor, destructor.
3132         (linespec_parser): Remove typedef.
3133         (~linespec_parser): Rename from linespec_parser_delete.
3134         (linespec_lex_to_end, linespec_complete_label)
3135         (linespec_complete): Update.
3136         (decode_line_full): Remove cleanups.
3137         (decode_line_1): Update.
3138
3139 2019-01-02  Tom Tromey  <tom@tromey.com>
3140
3141         * python/python-internal.h (inferior_to_inferior_object): Change
3142         return type.
3143         * python/py-exitedevent.c (create_exited_event_object): Update.
3144         * python/py-inferior.c (inferior_to_inferior_object): Return
3145         gdbpy_ref.
3146         (python_new_inferior, python_inferior_deleted)
3147         (thread_to_thread_object, delete_thread_object)
3148         (build_inferior_list, gdbpy_selected_inferior): Update.
3149         * python/py-infthread.c (create_thread_object): Update.  Also fail
3150         if inferior_to_inferior_object fails.
3151
3152 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3153
3154         * inferior.h (class inferior) <displaced_step_state>: New field.
3155         * infrun.h (struct displaced_step_state): Move here from
3156         infrun.c.  Initialize fields, add constructor.
3157         <inf>: Remove field.
3158         <reset>: New method.
3159         * infrun.c (struct displaced_step_inferior_state): Move to
3160         infrun.h.
3161         (displaced_step_inferior_states): Remove.
3162         (get_displaced_stepping_state): Adust.
3163         (displaced_step_in_progress_any_inferior): Adjust.
3164         (displaced_step_in_progress_thread): Adjust.
3165         (displaced_step_in_progress): Adjust.
3166         (add_displaced_stepping_state): Remove.
3167         (get_displaced_step_closure_by_addr): Adjust.
3168         (remove_displaced_stepping_state): Remove.
3169         (infrun_inferior_exit): Call displaced_step_state.reset.
3170         (use_displaced_stepping): Don't check for NULL.
3171         (displaced_step_prepare_throw): Call
3172         get_displaced_stepping_state.
3173         (displaced_step_fixup): Don't check for NULL.
3174         (prepare_for_detach): Don't check for NULL.
3175
3176 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3177
3178         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3179          in case of call that did not complete.
3180
3181 2019-01-02  Andrey Utkin  <autkin@undo.io>
3182
3183         * symfile.c (find_separate_debug_file): Fix search of debug files for
3184         remote debuggee.
3185
3186 2019-01-02  Tom Tromey  <tom@tromey.com>
3187
3188         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3189         indentation.
3190         * python/py-frame.c (frapy_older): Remove cast.
3191         (frapy_newer): Likewise.
3192         * python/py-breakpoint.c (local_setattro): Remove cast.
3193         * python/py-arch.c (archpy_name): Remove local variable.
3194         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3195
3196 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3197
3198         * unittests/basic_string_view/element_access/char/empty.cc:
3199         Fix year range in copyright header.
3200
3201 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3204         Delete.
3205         <operator==>: Update with for removed field.
3206         <hash>: Likewise.
3207         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3208         <isa_features>: ...this.
3209         <abi_features>: New field.
3210         (riscv_isa_flen): Update comment.
3211         (riscv_abi_xlen): New declaration.
3212         (riscv_abi_flen): New declaration.
3213         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3214         isa_features.
3215         (riscv_abi_xlen): New function.
3216         (riscv_isa_flen): Update to get answer from isa_features.
3217         (riscv_abi_flen): New function.
3218         (riscv_has_fp_abi): Update to get answer from abi_features.
3219         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3220         xlen and flen.
3221         (riscv_call_info) <xlen, flen>: Update comment.
3222         (riscv_call_arg_struct): Remove invalid assertions
3223         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3224         is removed.
3225         (riscv_gdbarch_init): Gather isa features and abi features
3226         separately, ensure both match on the gdbarch when reusing an old
3227         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3228         a target with 64-bit float hardware.
3229
3230 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3231
3232         * source.c (search_command_helper): Stop reverse search
3233         when line 1 has been searched.
3234
3235 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3236
3237         * record-full.c (record_full_base_target::close): Rewrite
3238         record_full_core_buf_list free logic.
3239
3240 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3241
3242         * break-catch-syscall.c (print_one_catch_syscall): xfree
3243         the last text.
3244
3245 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3246
3247         * top.c (print_gdb_version): Update Copyright year in version
3248         message.
3249
3250 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3251
3252         Update copyright year range in all GDB files.
3253
3254 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3255
3256         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3257
3258 For older changes see ChangeLog-2018.
3259 \f
3260 Local Variables:
3261 mode: change-log
3262 left-margin: 8
3263 fill-column: 74
3264 version-control: never
3265 coding: utf-8
3266 End:
3267