Replace throw_exception with throw in some cases
[external/binutils.git] / gdb / ChangeLog
1 2019-04-08  Tom Tromey  <tom@tromey.com>
2
3         * valops.c (value_rtti_indirect_type): Replace throw_exception
4         with throw.
5         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6         with throw.
7         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8         throw.
9         * target.c (target_translate_tls_address): Replace throw_exception
10         with throw.
11         * stack.c (frame_apply_command_count): Replace throw_exception
12         with throw.
13         * solib-spu.c (append_ocl_sos): Replace throw_exception with
14         throw.
15         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
16         with throw.
17         * rs6000-tdep.c (rs6000_frame_cache)
18         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
19         * remote.c: Replace throw_exception with throw.
20         * record-full.c (record_full_message, record_full_wait_1)
21         (record_full_restore): Replace throw_exception with throw.
22         * record-btrace.c:
23         (get_thread_current_frame_id, record_btrace_start_replaying)
24         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
25         (cmd_record_btrace_start): Replace throw_exception with throw.
26         * parse.c (parse_exp_in_context_1): Replace throw_exception with
27         throw.
28         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
29         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
30         * linespec.c:
31         (find_linespec_symbols): Replace throw_exception with throw.
32         * infrun.c (displaced_step_prepare, resume): Replace
33         throw_exception with throw.
34         * infcmd.c (post_create_inferior): Replace throw_exception with
35         throw.
36         * inf-loop.c (inferior_event_handler): Replace throw_exception
37         with throw.
38         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
39         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
40         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
41         (get_prev_frame_always, get_frame_pc_if_available)
42         (get_frame_address_in_block_if_available, get_frame_language):
43         Replace throw_exception with throw.
44         * frame-unwind.c (frame_unwind_try_unwinder): Replace
45         throw_exception with throw.
46         * eval.c (fetch_subexp_value, evaluate_var_value)
47         (evaluate_funcall, evaluate_subexp_standard): Replace
48         throw_exception with throw.
49         * dwarf2loc.c (call_site_find_chain)
50         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
51         Replace throw_exception with throw.
52         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
53         with throw.
54         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
55         throw.
56         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
57         * completer.c (complete_line_internal): Replace throw_exception
58         with throw.
59         * compile/compile-object-run.c (compile_object_run): Replace
60         throw_exception with throw.
61         * cli/cli-script.c (process_next_line): Replace throw_exception
62         with throw.
63         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
64         (btrace_enable, btrace_maint_update_pt_packets): Replace
65         throw_exception with throw.
66         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
67         throw_exception with throw.
68         * break-catch-throw.c (re_set_exception_catchpoint): Replace
69         throw_exception with throw.
70         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
71         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
72         * aarch64-tdep.c (aarch64_make_prologue_cache)
73         (aarch64_make_stub_cache): Replace throw_exception with throw.
74
75 2019-04-08  Tom Tromey  <tom@tromey.com>
76
77         * common/common-exceptions.c (throw_exception): Rename from
78         throw_exception_cxx.  Remove old copy.  Make argument const.
79         (throw_it): Create and throw exception objects directly.
80         * common/common-exceptions.h (throw_exception): Make argument
81         const.
82         (struct gdb_exception_error): Add constructor.
83         (struct gdb_exception_quit): Add constructor.
84
85 2019-04-08  Tom Tromey  <tom@tromey.com>
86
87         * common/common-exceptions.h (exception_rethrow): Don't declare.
88         (TRY_SJLJ): Update comment.
89         (TRY, CATCH, END_CATCH): Remove.
90         * common/common-exceptions.c (exception_rethrow): Remove.
91
92 2019-04-08  Tom Tromey  <tom@tromey.com>
93
94         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
95         Remove.
96         (gdb_exception_error): Rename from
97         gdb_exception_RETURN_MASK_ERROR.
98         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
99         (gdb_quit_bad_alloc): Update.
100         * aarch64-tdep.c: Update.
101         * ada-lang.c: Update.
102         * ada-typeprint.c: Update.
103         * ada-valprint.c: Update.
104         * amd64-tdep.c: Update.
105         * arch-utils.c: Update.
106         * break-catch-throw.c: Update.
107         * breakpoint.c: Update.
108         * btrace.c: Update.
109         * c-varobj.c: Update.
110         * cli/cli-cmds.c: Update.
111         * cli/cli-interp.c: Update.
112         * cli/cli-script.c: Update.
113         * common/common-exceptions.c: Update.
114         * common/new-op.c: Update.
115         * common/selftest.c: Update.
116         * compile/compile-c-symbols.c: Update.
117         * compile/compile-cplus-symbols.c: Update.
118         * compile/compile-object-load.c: Update.
119         * compile/compile-object-run.c: Update.
120         * completer.c: Update.
121         * corelow.c: Update.
122         * cp-abi.c: Update.
123         * cp-support.c: Update.
124         * cp-valprint.c: Update.
125         * darwin-nat.c: Update.
126         * disasm-selftests.c: Update.
127         * dtrace-probe.c: Update.
128         * dwarf-index-cache.c: Update.
129         * dwarf-index-write.c: Update.
130         * dwarf2-frame-tailcall.c: Update.
131         * dwarf2-frame.c: Update.
132         * dwarf2loc.c: Update.
133         * dwarf2read.c: Update.
134         * eval.c: Update.
135         * event-loop.c: Update.
136         * event-top.c: Update.
137         * exec.c: Update.
138         * f-valprint.c: Update.
139         * fbsd-tdep.c: Update.
140         * frame-unwind.c: Update.
141         * frame.c: Update.
142         * gdbtypes.c: Update.
143         * gnu-v3-abi.c: Update.
144         * guile/guile-internal.h: Update.
145         * guile/scm-block.c: Update.
146         * guile/scm-breakpoint.c: Update.
147         * guile/scm-cmd.c: Update.
148         * guile/scm-disasm.c: Update.
149         * guile/scm-frame.c: Update.
150         * guile/scm-lazy-string.c: Update.
151         * guile/scm-math.c: Update.
152         * guile/scm-param.c: Update.
153         * guile/scm-ports.c: Update.
154         * guile/scm-pretty-print.c: Update.
155         * guile/scm-symbol.c: Update.
156         * guile/scm-symtab.c: Update.
157         * guile/scm-type.c: Update.
158         * guile/scm-value.c: Update.
159         * i386-linux-tdep.c: Update.
160         * i386-tdep.c: Update.
161         * inf-loop.c: Update.
162         * infcall.c: Update.
163         * infcmd.c: Update.
164         * infrun.c: Update.
165         * jit.c: Update.
166         * language.c: Update.
167         * linespec.c: Update.
168         * linux-fork.c: Update.
169         * linux-nat.c: Update.
170         * linux-tdep.c: Update.
171         * linux-thread-db.c: Update.
172         * main.c: Update.
173         * mi/mi-cmd-break.c: Update.
174         * mi/mi-cmd-stack.c: Update.
175         * mi/mi-interp.c: Update.
176         * mi/mi-main.c: Update.
177         * objc-lang.c: Update.
178         * p-valprint.c: Update.
179         * parse.c: Update.
180         * ppc-linux-tdep.c: Update.
181         * printcmd.c: Update.
182         * python/py-arch.c: Update.
183         * python/py-breakpoint.c: Update.
184         * python/py-cmd.c: Update.
185         * python/py-finishbreakpoint.c: Update.
186         * python/py-frame.c: Update.
187         * python/py-framefilter.c: Update.
188         * python/py-gdb-readline.c: Update.
189         * python/py-inferior.c: Update.
190         * python/py-infthread.c: Update.
191         * python/py-lazy-string.c: Update.
192         * python/py-linetable.c: Update.
193         * python/py-objfile.c: Update.
194         * python/py-param.c: Update.
195         * python/py-prettyprint.c: Update.
196         * python/py-progspace.c: Update.
197         * python/py-record-btrace.c: Update.
198         * python/py-record.c: Update.
199         * python/py-symbol.c: Update.
200         * python/py-type.c: Update.
201         * python/py-unwind.c: Update.
202         * python/py-utils.c: Update.
203         * python/py-value.c: Update.
204         * python/python.c: Update.
205         * record-btrace.c: Update.
206         * record-full.c: Update.
207         * remote-fileio.c: Update.
208         * remote.c: Update.
209         * riscv-tdep.c: Update.
210         * rs6000-aix-tdep.c: Update.
211         * rs6000-tdep.c: Update.
212         * rust-exp.y: Update.
213         * rust-lang.c: Update.
214         * s390-tdep.c: Update.
215         * selftest-arch.c: Update.
216         * solib-dsbt.c: Update.
217         * solib-frv.c: Update.
218         * solib-spu.c: Update.
219         * solib-svr4.c: Update.
220         * solib.c: Update.
221         * sparc64-linux-tdep.c: Update.
222         * stack.c: Update.
223         * symfile-mem.c: Update.
224         * symmisc.c: Update.
225         * target.c: Update.
226         * thread.c: Update.
227         * top.c: Update.
228         * tracefile-tfile.c: Update.
229         * tui/tui.c: Update.
230         * typeprint.c: Update.
231         * unittests/cli-utils-selftests.c: Update.
232         * unittests/parse-connection-spec-selftests.c: Update.
233         * valops.c: Update.
234         * valprint.c: Update.
235         * value.c: Update.
236         * varobj.c: Update.
237         * windows-nat.c: Update.
238         * x86-linux-nat.c: Update.
239         * xml-support.c: Update.
240
241 2019-04-08  Tom Tromey  <tom@tromey.com>
242
243         * xml-support.c: Use C++ exception handling.
244         * x86-linux-nat.c: Use C++ exception handling.
245         * windows-nat.c: Use C++ exception handling.
246         * varobj.c: Use C++ exception handling.
247         * value.c: Use C++ exception handling.
248         * valprint.c: Use C++ exception handling.
249         * valops.c: Use C++ exception handling.
250         * unittests/parse-connection-spec-selftests.c: Use C++ exception
251         handling.
252         * unittests/cli-utils-selftests.c: Use C++ exception handling.
253         * typeprint.c: Use C++ exception handling.
254         * tui/tui.c: Use C++ exception handling.
255         * tracefile-tfile.c: Use C++ exception handling.
256         * top.c: Use C++ exception handling.
257         * thread.c: Use C++ exception handling.
258         * target.c: Use C++ exception handling.
259         * symmisc.c: Use C++ exception handling.
260         * symfile-mem.c: Use C++ exception handling.
261         * stack.c: Use C++ exception handling.
262         * sparc64-linux-tdep.c: Use C++ exception handling.
263         * solib.c: Use C++ exception handling.
264         * solib-svr4.c: Use C++ exception handling.
265         * solib-spu.c: Use C++ exception handling.
266         * solib-frv.c: Use C++ exception handling.
267         * solib-dsbt.c: Use C++ exception handling.
268         * selftest-arch.c: Use C++ exception handling.
269         * s390-tdep.c: Use C++ exception handling.
270         * rust-lang.c: Use C++ exception handling.
271         * rust-exp.y: Use C++ exception handling.
272         * rs6000-tdep.c: Use C++ exception handling.
273         * rs6000-aix-tdep.c: Use C++ exception handling.
274         * riscv-tdep.c: Use C++ exception handling.
275         * remote.c: Use C++ exception handling.
276         * remote-fileio.c: Use C++ exception handling.
277         * record-full.c: Use C++ exception handling.
278         * record-btrace.c: Use C++ exception handling.
279         * python/python.c: Use C++ exception handling.
280         * python/py-value.c: Use C++ exception handling.
281         * python/py-utils.c: Use C++ exception handling.
282         * python/py-unwind.c: Use C++ exception handling.
283         * python/py-type.c: Use C++ exception handling.
284         * python/py-symbol.c: Use C++ exception handling.
285         * python/py-record.c: Use C++ exception handling.
286         * python/py-record-btrace.c: Use C++ exception handling.
287         * python/py-progspace.c: Use C++ exception handling.
288         * python/py-prettyprint.c: Use C++ exception handling.
289         * python/py-param.c: Use C++ exception handling.
290         * python/py-objfile.c: Use C++ exception handling.
291         * python/py-linetable.c: Use C++ exception handling.
292         * python/py-lazy-string.c: Use C++ exception handling.
293         * python/py-infthread.c: Use C++ exception handling.
294         * python/py-inferior.c: Use C++ exception handling.
295         * python/py-gdb-readline.c: Use C++ exception handling.
296         * python/py-framefilter.c: Use C++ exception handling.
297         * python/py-frame.c: Use C++ exception handling.
298         * python/py-finishbreakpoint.c: Use C++ exception handling.
299         * python/py-cmd.c: Use C++ exception handling.
300         * python/py-breakpoint.c: Use C++ exception handling.
301         * python/py-arch.c: Use C++ exception handling.
302         * printcmd.c: Use C++ exception handling.
303         * ppc-linux-tdep.c: Use C++ exception handling.
304         * parse.c: Use C++ exception handling.
305         * p-valprint.c: Use C++ exception handling.
306         * objc-lang.c: Use C++ exception handling.
307         * mi/mi-main.c: Use C++ exception handling.
308         * mi/mi-interp.c: Use C++ exception handling.
309         * mi/mi-cmd-stack.c: Use C++ exception handling.
310         * mi/mi-cmd-break.c: Use C++ exception handling.
311         * main.c: Use C++ exception handling.
312         * linux-thread-db.c: Use C++ exception handling.
313         * linux-tdep.c: Use C++ exception handling.
314         * linux-nat.c: Use C++ exception handling.
315         * linux-fork.c: Use C++ exception handling.
316         * linespec.c: Use C++ exception handling.
317         * language.c: Use C++ exception handling.
318         * jit.c: Use C++ exception handling.
319         * infrun.c: Use C++ exception handling.
320         * infcmd.c: Use C++ exception handling.
321         * infcall.c: Use C++ exception handling.
322         * inf-loop.c: Use C++ exception handling.
323         * i386-tdep.c: Use C++ exception handling.
324         * i386-linux-tdep.c: Use C++ exception handling.
325         * guile/scm-value.c: Use C++ exception handling.
326         * guile/scm-type.c: Use C++ exception handling.
327         * guile/scm-symtab.c: Use C++ exception handling.
328         * guile/scm-symbol.c: Use C++ exception handling.
329         * guile/scm-pretty-print.c: Use C++ exception handling.
330         * guile/scm-ports.c: Use C++ exception handling.
331         * guile/scm-param.c: Use C++ exception handling.
332         * guile/scm-math.c: Use C++ exception handling.
333         * guile/scm-lazy-string.c: Use C++ exception handling.
334         * guile/scm-frame.c: Use C++ exception handling.
335         * guile/scm-disasm.c: Use C++ exception handling.
336         * guile/scm-cmd.c: Use C++ exception handling.
337         * guile/scm-breakpoint.c: Use C++ exception handling.
338         * guile/scm-block.c: Use C++ exception handling.
339         * guile/guile-internal.h: Use C++ exception handling.
340         * gnu-v3-abi.c: Use C++ exception handling.
341         * gdbtypes.c: Use C++ exception handling.
342         * frame.c: Use C++ exception handling.
343         * frame-unwind.c: Use C++ exception handling.
344         * fbsd-tdep.c: Use C++ exception handling.
345         * f-valprint.c: Use C++ exception handling.
346         * exec.c: Use C++ exception handling.
347         * event-top.c: Use C++ exception handling.
348         * event-loop.c: Use C++ exception handling.
349         * eval.c: Use C++ exception handling.
350         * dwarf2read.c: Use C++ exception handling.
351         * dwarf2loc.c: Use C++ exception handling.
352         * dwarf2-frame.c: Use C++ exception handling.
353         * dwarf2-frame-tailcall.c: Use C++ exception handling.
354         * dwarf-index-write.c: Use C++ exception handling.
355         * dwarf-index-cache.c: Use C++ exception handling.
356         * dtrace-probe.c: Use C++ exception handling.
357         * disasm-selftests.c: Use C++ exception handling.
358         * darwin-nat.c: Use C++ exception handling.
359         * cp-valprint.c: Use C++ exception handling.
360         * cp-support.c: Use C++ exception handling.
361         * cp-abi.c: Use C++ exception handling.
362         * corelow.c: Use C++ exception handling.
363         * completer.c: Use C++ exception handling.
364         * compile/compile-object-run.c: Use C++ exception handling.
365         * compile/compile-object-load.c: Use C++ exception handling.
366         * compile/compile-cplus-symbols.c: Use C++ exception handling.
367         * compile/compile-c-symbols.c: Use C++ exception handling.
368         * common/selftest.c: Use C++ exception handling.
369         * common/new-op.c: Use C++ exception handling.
370         * cli/cli-script.c: Use C++ exception handling.
371         * cli/cli-interp.c: Use C++ exception handling.
372         * cli/cli-cmds.c: Use C++ exception handling.
373         * c-varobj.c: Use C++ exception handling.
374         * btrace.c: Use C++ exception handling.
375         * breakpoint.c: Use C++ exception handling.
376         * break-catch-throw.c: Use C++ exception handling.
377         * arch-utils.c: Use C++ exception handling.
378         * amd64-tdep.c: Use C++ exception handling.
379         * ada-valprint.c: Use C++ exception handling.
380         * ada-typeprint.c: Use C++ exception handling.
381         * ada-lang.c: Use C++ exception handling.
382         * aarch64-tdep.c: Use C++ exception handling.
383
384 2019-04-08  Tom Tromey  <tom@tromey.com>
385
386         * xml-support.c (gdb_xml_parser::parse): Update.
387         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
388         * value.c (show_convenience): Update.
389         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
390         (test_parse_flags_qcs): Update.
391         * thread.c (thr_try_catch_cmd): Update.
392         * target.c (target_translate_tls_address): Update.
393         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
394         (info_frame_command_core, frame_apply_command_count): Update.
395         * rust-exp.y (rust_lex_exception_test): Update.
396         * riscv-tdep.c (riscv_print_one_register_info): Update.
397         * remote.c (remote_target::enable_btrace): Update.
398         * record-btrace.c (record_btrace_enable_warn): Update.
399         * python/py-utils.c (gdbpy_convert_exception): Update.
400         * printcmd.c (do_one_display, print_variable_and_value): Update.
401         * mi/mi-main.c (mi_print_exception): Update.
402         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
403         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
404         * linux-nat.c (linux_nat_target::attach): Update.
405         * linux-fork.c (class scoped_switch_fork_info): Update.
406         * infrun.c (displaced_step_prepare): Update.
407         * infcall.c (call_function_by_hand_dummy): Update.
408         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
409         * gnu-v3-abi.c (print_one_vtable): Update.
410         * frame.c (get_prev_frame_always): Update.
411         * f-valprint.c (info_common_command_for_block): Update.
412         * exec.c (try_open_exec_file): Update.
413         * exceptions.c (print_exception, exception_print)
414         (exception_fprintf, exception_print_same): Update.
415         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
416         * dwarf-index-cache.c (index_cache::store)
417         (index_cache::lookup_gdb_index): Update.
418         * darwin-nat.c (maybe_cache_shell): Update.
419         * cp-valprint.c (cp_print_value_fields): Update.
420         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
421         (gcc_cplus_symbol_address): Update.
422         * compile/compile-c-symbols.c (gcc_convert_symbol)
423         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
424         * common/selftest.c: Update.
425         * common/common-exceptions.h (struct gdb_exception) <message>: Now
426         a std::string.
427         (exception_try_scope_entry, exception_try_scope_exit): Don't
428         declare.
429         (struct exception_try_scope): Remove.
430         (TRY): Don't use exception_try_scope.
431         (struct gdb_exception): Add constructor, operator=.
432         <what>: New method.
433         (struct gdb_exception_RETURN_MASK_ALL)
434         (struct gdb_exception_RETURN_MASK_ERROR)
435         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
436         (struct gdb_quit_bad_alloc): Update.
437         * common/common-exceptions.c (exception_none): Change
438         initializer.
439         (struct catcher) <state, exception>: Initialize inline.
440         <prev>: Remove member.
441         (current_catcher): Remove.
442         (catchers): New global.
443         (exceptions_state_mc_init): Simplify.
444         (catcher_pop): Remove.
445         (exceptions_state_mc, exceptions_state_mc_catch): Update.
446         (try_scope_depth, exception_try_scope_entry)
447         (exception_try_scope_exit): Remove.
448         (throw_exception_sjlj): Update.
449         (exception_messages, exception_messages_size): Remove.
450         (throw_it): Simplify.
451         (gdb_exception_sliced_copy): Remove.
452         (throw_exception_cxx): Update.
453         * cli/cli-script.c (script_from_file): Update.
454         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
455         Update.
456         * ada-valprint.c (ada_val_print): Update.
457         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
458         (create_excep_cond_exprs): Update.
459
460 2019-04-08  Tom Tromey  <tom@tromey.com>
461
462         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
463         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
464         (TRY, CATCH, END_CATCH): Remove some definitions.
465         * common/common-exceptions.c: Don't use GDB_XCPT.
466         (catcher_list_size): Remove.
467         (throw_exception, throw_it): Simplify.
468
469 2019-04-05  Tom Tromey  <tom@tromey.com>
470
471         Revert the header-sorting patch.
472         * ft32-tdep.c: Revert.
473         * frv-tdep.c: Revert.
474         * frv-linux-tdep.c: Revert.
475         * frame.c: Revert.
476         * frame-unwind.c: Revert.
477         * frame-base.c: Revert.
478         * fork-child.c: Revert.
479         * findvar.c: Revert.
480         * findcmd.c: Revert.
481         * filesystem.c: Revert.
482         * filename-seen-cache.h: Revert.
483         * filename-seen-cache.c: Revert.
484         * fbsd-tdep.c: Revert.
485         * fbsd-nat.h: Revert.
486         * fbsd-nat.c: Revert.
487         * f-valprint.c: Revert.
488         * f-typeprint.c: Revert.
489         * f-lang.c: Revert.
490         * extension.h: Revert.
491         * extension.c: Revert.
492         * extension-priv.h: Revert.
493         * expprint.c: Revert.
494         * exec.h: Revert.
495         * exec.c: Revert.
496         * exceptions.c: Revert.
497         * event-top.c: Revert.
498         * event-loop.c: Revert.
499         * eval.c: Revert.
500         * elfread.c: Revert.
501         * dwarf2read.h: Revert.
502         * dwarf2read.c: Revert.
503         * dwarf2loc.c: Revert.
504         * dwarf2expr.h: Revert.
505         * dwarf2expr.c: Revert.
506         * dwarf2-frame.c: Revert.
507         * dwarf2-frame-tailcall.c: Revert.
508         * dwarf-index-write.h: Revert.
509         * dwarf-index-write.c: Revert.
510         * dwarf-index-common.c: Revert.
511         * dwarf-index-cache.h: Revert.
512         * dwarf-index-cache.c: Revert.
513         * dummy-frame.c: Revert.
514         * dtrace-probe.c: Revert.
515         * disasm.h: Revert.
516         * disasm.c: Revert.
517         * disasm-selftests.c: Revert.
518         * dictionary.c: Revert.
519         * dicos-tdep.c: Revert.
520         * demangle.c: Revert.
521         * dcache.h: Revert.
522         * dcache.c: Revert.
523         * darwin-nat.h: Revert.
524         * darwin-nat.c: Revert.
525         * darwin-nat-info.c: Revert.
526         * d-valprint.c: Revert.
527         * d-namespace.c: Revert.
528         * d-lang.c: Revert.
529         * ctf.c: Revert.
530         * csky-tdep.c: Revert.
531         * csky-linux-tdep.c: Revert.
532         * cris-tdep.c: Revert.
533         * cris-linux-tdep.c: Revert.
534         * cp-valprint.c: Revert.
535         * cp-support.c: Revert.
536         * cp-namespace.c: Revert.
537         * cp-abi.c: Revert.
538         * corelow.c: Revert.
539         * corefile.c: Revert.
540         * continuations.c: Revert.
541         * completer.h: Revert.
542         * completer.c: Revert.
543         * complaints.c: Revert.
544         * coffread.c: Revert.
545         * coff-pe-read.c: Revert.
546         * cli-out.h: Revert.
547         * cli-out.c: Revert.
548         * charset.c: Revert.
549         * c-varobj.c: Revert.
550         * c-valprint.c: Revert.
551         * c-typeprint.c: Revert.
552         * c-lang.c: Revert.
553         * buildsym.c: Revert.
554         * buildsym-legacy.c: Revert.
555         * build-id.h: Revert.
556         * build-id.c: Revert.
557         * btrace.c: Revert.
558         * bsd-uthread.c: Revert.
559         * breakpoint.h: Revert.
560         * breakpoint.c: Revert.
561         * break-catch-throw.c: Revert.
562         * break-catch-syscall.c: Revert.
563         * break-catch-sig.c: Revert.
564         * blockframe.c: Revert.
565         * block.c: Revert.
566         * bfin-tdep.c: Revert.
567         * bfin-linux-tdep.c: Revert.
568         * bfd-target.c: Revert.
569         * bcache.c: Revert.
570         * ax-general.c: Revert.
571         * ax-gdb.h: Revert.
572         * ax-gdb.c: Revert.
573         * avr-tdep.c: Revert.
574         * auxv.c: Revert.
575         * auto-load.c: Revert.
576         * arm-wince-tdep.c: Revert.
577         * arm-tdep.c: Revert.
578         * arm-symbian-tdep.c: Revert.
579         * arm-pikeos-tdep.c: Revert.
580         * arm-obsd-tdep.c: Revert.
581         * arm-nbsd-tdep.c: Revert.
582         * arm-nbsd-nat.c: Revert.
583         * arm-linux-tdep.c: Revert.
584         * arm-linux-nat.c: Revert.
585         * arm-fbsd-tdep.c: Revert.
586         * arm-fbsd-nat.c: Revert.
587         * arm-bsd-tdep.c: Revert.
588         * arch-utils.c: Revert.
589         * arc-tdep.c: Revert.
590         * arc-newlib-tdep.c: Revert.
591         * annotate.h: Revert.
592         * annotate.c: Revert.
593         * amd64-windows-tdep.c: Revert.
594         * amd64-windows-nat.c: Revert.
595         * amd64-tdep.c: Revert.
596         * amd64-sol2-tdep.c: Revert.
597         * amd64-obsd-tdep.c: Revert.
598         * amd64-obsd-nat.c: Revert.
599         * amd64-nbsd-tdep.c: Revert.
600         * amd64-nbsd-nat.c: Revert.
601         * amd64-nat.c: Revert.
602         * amd64-linux-tdep.c: Revert.
603         * amd64-linux-nat.c: Revert.
604         * amd64-fbsd-tdep.c: Revert.
605         * amd64-fbsd-nat.c: Revert.
606         * amd64-dicos-tdep.c: Revert.
607         * amd64-darwin-tdep.c: Revert.
608         * amd64-bsd-nat.c: Revert.
609         * alpha-tdep.c: Revert.
610         * alpha-obsd-tdep.c: Revert.
611         * alpha-nbsd-tdep.c: Revert.
612         * alpha-mdebug-tdep.c: Revert.
613         * alpha-linux-tdep.c: Revert.
614         * alpha-linux-nat.c: Revert.
615         * alpha-bsd-tdep.c: Revert.
616         * alpha-bsd-nat.c: Revert.
617         * aix-thread.c: Revert.
618         * agent.c: Revert.
619         * addrmap.c: Revert.
620         * ada-varobj.c: Revert.
621         * ada-valprint.c: Revert.
622         * ada-typeprint.c: Revert.
623         * ada-tasks.c: Revert.
624         * ada-lang.c: Revert.
625         * aarch64-tdep.c: Revert.
626         * aarch64-ravenscar-thread.c: Revert.
627         * aarch64-newlib-tdep.c: Revert.
628         * aarch64-linux-tdep.c: Revert.
629         * aarch64-linux-nat.c: Revert.
630         * aarch64-fbsd-tdep.c: Revert.
631         * aarch64-fbsd-nat.c: Revert.
632         * aarch32-linux-nat.c: Revert.
633
634 2019-04-05  Tom Tromey  <tom@tromey.com>
635
636         * ft32-tdep.c: Sort headers.
637         * frv-tdep.c: Sort headers.
638         * frv-linux-tdep.c: Sort headers.
639         * frame.c: Sort headers.
640         * frame-unwind.c: Sort headers.
641         * frame-base.c: Sort headers.
642         * fork-child.c: Sort headers.
643         * findvar.c: Sort headers.
644         * findcmd.c: Sort headers.
645         * filesystem.c: Sort headers.
646         * filename-seen-cache.h: Sort headers.
647         * filename-seen-cache.c: Sort headers.
648         * fbsd-tdep.c: Sort headers.
649         * fbsd-nat.h: Sort headers.
650         * fbsd-nat.c: Sort headers.
651         * f-valprint.c: Sort headers.
652         * f-typeprint.c: Sort headers.
653         * f-lang.c: Sort headers.
654         * extension.h: Sort headers.
655         * extension.c: Sort headers.
656         * extension-priv.h: Sort headers.
657         * expprint.c: Sort headers.
658         * exec.h: Sort headers.
659         * exec.c: Sort headers.
660         * exceptions.c: Sort headers.
661         * event-top.c: Sort headers.
662         * event-loop.c: Sort headers.
663         * eval.c: Sort headers.
664         * elfread.c: Sort headers.
665         * dwarf2read.h: Sort headers.
666         * dwarf2read.c: Sort headers.
667         * dwarf2loc.c: Sort headers.
668         * dwarf2expr.h: Sort headers.
669         * dwarf2expr.c: Sort headers.
670         * dwarf2-frame.c: Sort headers.
671         * dwarf2-frame-tailcall.c: Sort headers.
672         * dwarf-index-write.h: Sort headers.
673         * dwarf-index-write.c: Sort headers.
674         * dwarf-index-common.c: Sort headers.
675         * dwarf-index-cache.h: Sort headers.
676         * dwarf-index-cache.c: Sort headers.
677         * dummy-frame.c: Sort headers.
678         * dtrace-probe.c: Sort headers.
679         * disasm.h: Sort headers.
680         * disasm.c: Sort headers.
681         * disasm-selftests.c: Sort headers.
682         * dictionary.c: Sort headers.
683         * dicos-tdep.c: Sort headers.
684         * demangle.c: Sort headers.
685         * dcache.h: Sort headers.
686         * dcache.c: Sort headers.
687         * darwin-nat.h: Sort headers.
688         * darwin-nat.c: Sort headers.
689         * darwin-nat-info.c: Sort headers.
690         * d-valprint.c: Sort headers.
691         * d-namespace.c: Sort headers.
692         * d-lang.c: Sort headers.
693         * ctf.c: Sort headers.
694         * csky-tdep.c: Sort headers.
695         * csky-linux-tdep.c: Sort headers.
696         * cris-tdep.c: Sort headers.
697         * cris-linux-tdep.c: Sort headers.
698         * cp-valprint.c: Sort headers.
699         * cp-support.c: Sort headers.
700         * cp-namespace.c: Sort headers.
701         * cp-abi.c: Sort headers.
702         * corelow.c: Sort headers.
703         * corefile.c: Sort headers.
704         * continuations.c: Sort headers.
705         * completer.h: Sort headers.
706         * completer.c: Sort headers.
707         * complaints.c: Sort headers.
708         * coffread.c: Sort headers.
709         * coff-pe-read.c: Sort headers.
710         * cli-out.h: Sort headers.
711         * cli-out.c: Sort headers.
712         * charset.c: Sort headers.
713         * c-varobj.c: Sort headers.
714         * c-valprint.c: Sort headers.
715         * c-typeprint.c: Sort headers.
716         * c-lang.c: Sort headers.
717         * buildsym.c: Sort headers.
718         * buildsym-legacy.c: Sort headers.
719         * build-id.h: Sort headers.
720         * build-id.c: Sort headers.
721         * btrace.c: Sort headers.
722         * bsd-uthread.c: Sort headers.
723         * breakpoint.h: Sort headers.
724         * breakpoint.c: Sort headers.
725         * break-catch-throw.c: Sort headers.
726         * break-catch-syscall.c: Sort headers.
727         * break-catch-sig.c: Sort headers.
728         * blockframe.c: Sort headers.
729         * block.c: Sort headers.
730         * bfin-tdep.c: Sort headers.
731         * bfin-linux-tdep.c: Sort headers.
732         * bfd-target.c: Sort headers.
733         * bcache.c: Sort headers.
734         * ax-general.c: Sort headers.
735         * ax-gdb.h: Sort headers.
736         * ax-gdb.c: Sort headers.
737         * avr-tdep.c: Sort headers.
738         * auxv.c: Sort headers.
739         * auto-load.c: Sort headers.
740         * arm-wince-tdep.c: Sort headers.
741         * arm-tdep.c: Sort headers.
742         * arm-symbian-tdep.c: Sort headers.
743         * arm-pikeos-tdep.c: Sort headers.
744         * arm-obsd-tdep.c: Sort headers.
745         * arm-nbsd-tdep.c: Sort headers.
746         * arm-nbsd-nat.c: Sort headers.
747         * arm-linux-tdep.c: Sort headers.
748         * arm-linux-nat.c: Sort headers.
749         * arm-fbsd-tdep.c: Sort headers.
750         * arm-fbsd-nat.c: Sort headers.
751         * arm-bsd-tdep.c: Sort headers.
752         * arch-utils.c: Sort headers.
753         * arc-tdep.c: Sort headers.
754         * arc-newlib-tdep.c: Sort headers.
755         * annotate.h: Sort headers.
756         * annotate.c: Sort headers.
757         * amd64-windows-tdep.c: Sort headers.
758         * amd64-windows-nat.c: Sort headers.
759         * amd64-tdep.c: Sort headers.
760         * amd64-sol2-tdep.c: Sort headers.
761         * amd64-obsd-tdep.c: Sort headers.
762         * amd64-obsd-nat.c: Sort headers.
763         * amd64-nbsd-tdep.c: Sort headers.
764         * amd64-nbsd-nat.c: Sort headers.
765         * amd64-nat.c: Sort headers.
766         * amd64-linux-tdep.c: Sort headers.
767         * amd64-linux-nat.c: Sort headers.
768         * amd64-fbsd-tdep.c: Sort headers.
769         * amd64-fbsd-nat.c: Sort headers.
770         * amd64-dicos-tdep.c: Sort headers.
771         * amd64-darwin-tdep.c: Sort headers.
772         * amd64-bsd-nat.c: Sort headers.
773         * alpha-tdep.c: Sort headers.
774         * alpha-obsd-tdep.c: Sort headers.
775         * alpha-nbsd-tdep.c: Sort headers.
776         * alpha-mdebug-tdep.c: Sort headers.
777         * alpha-linux-tdep.c: Sort headers.
778         * alpha-linux-nat.c: Sort headers.
779         * alpha-bsd-tdep.c: Sort headers.
780         * alpha-bsd-nat.c: Sort headers.
781         * aix-thread.c: Sort headers.
782         * agent.c: Sort headers.
783         * addrmap.c: Sort headers.
784         * ada-varobj.c: Sort headers.
785         * ada-valprint.c: Sort headers.
786         * ada-typeprint.c: Sort headers.
787         * ada-tasks.c: Sort headers.
788         * ada-lang.c: Sort headers.
789         * aarch64-tdep.c: Sort headers.
790         * aarch64-ravenscar-thread.c: Sort headers.
791         * aarch64-newlib-tdep.c: Sort headers.
792         * aarch64-linux-tdep.c: Sort headers.
793         * aarch64-linux-nat.c: Sort headers.
794         * aarch64-fbsd-tdep.c: Sort headers.
795         * aarch64-fbsd-nat.c: Sort headers.
796         * aarch32-linux-nat.c: Sort headers.
797
798 2019-04-04  Tom Tromey  <tom@tromey.com>
799
800         * varobj.c (varobj_create): Update.
801         * rust-exp.y (struct rust_parser) <update_innermost_block,
802         lookup_symbol>: New methods.
803         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
804         Rename.
805         (rust_parser::rust_lookup_type)
806         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
807         * printcmd.c (display_command, do_one_display): Update.
808         * parser-defs.h (struct parser_state) <parser_state>: Add
809         "tracker" parameter.
810         (block_tracker): New member.
811         (class innermost_block_tracker) <innermost_block_tracker>: Add
812         "types" parameter.
813         <reset>: Remove method.
814         (innermost_block): Don't declare.
815         (null_post_parser): Update.
816         * parse.c (innermost_block): Remove global.
817         (write_dollar_variable): Update.
818         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
819         Remove "tracker_types" parameter.
820         (parse_expression): Add "tracker" parameter.
821         (parse_expression_for_completion): Update.
822         (null_post_parser): Add "tracker" parameter.
823         * p-exp.y: Update rules.
824         * m2-exp.y: Update rules.
825         * language.h (struct language_defn) <la_post_parser>: Add
826         "tracker" parameter.
827         * go-exp.y: Update rules.
828         * f-exp.y: Update rules.
829         * expression.h (parse_expression, parse_exp_1): Add "tracker"
830         parameter.
831         * d-exp.y: Update rules.
832         * c-exp.y: Update rules.
833         * breakpoint.c (set_breakpoint_condition): Create an
834         innermost_block_tracker.
835         (watch_command_1): Likewise.
836         * ada-lang.c (resolve): Add "tracker" parameter.
837         (resolve_subexp): Likewise.
838         * ada-exp.y (write_var_from_sym): Update.
839
840 2019-04-04  Tom Tromey  <tom@tromey.com>
841
842         * type-stack.h: New file.
843         * type-stack.c: New file.
844         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
845         type-stack.h.
846         (insert_into_type_stack, insert_type, push_type, push_type_int)
847         (insert_type_address_space, pop_type, pop_type_int)
848         (pop_typelist, pop_type_stack, append_type_stack)
849         (push_type_stack, get_type_stack, push_typelist)
850         (follow_type_instance_flags, follow_types): Don't declare.
851         * parse.c (type_stack): Remove global.
852         (parse_exp_in_context): Update.
853         (insert_into_type_stack, insert_type, push_type, push_type_int)
854         (insert_type_address_space, pop_type, pop_type_int)
855         (pop_typelist, pop_type_stack, append_type_stack)
856         (push_type_stack, get_type_stack, push_typelist)
857         (follow_type_instance_flags, follow_types): Remove (moved to
858         type-stack.c).
859         * f-exp.y (type_stack): New global.
860         Update rules.
861         (push_kind_type, f_parse): Update.
862         * d-exp.y (type_stack): New global.
863         Update rules.
864         (d_parse): Update.
865         * c-exp.y (struct c_parse_state) <type_stack>: New member.
866         Update rules.
867         * Makefile.in (COMMON_SFILES): Add type-stack.c.
868         (HFILES_NO_SRCDIR): Add type-stack.h.
869
870 2019-04-04  Tom Tromey  <tom@tromey.com>
871
872         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
873         (rust_parser::convert_ast_to_expression, rust_parse)
874         (rust_lex_test_completion, rust_lex_tests): Update.
875         * parser-defs.h (struct expr_completion_state): New.
876         (struct parser_state) <parser_state>: Add completion parameter.
877         <mark_struct_expression, mark_completion_tag>: New methods.
878         <parse_completion, m_completion_state>: New members.
879         (prefixify_expression, null_post_parser): Update.
880         (mark_struct_expression, mark_completion_tag): Don't declare.
881         * parse.c (parse_completion, expout_last_struct)
882         (expout_tag_completion_type, expout_completion_name): Remove
883         globals.
884         (parser_state::mark_struct_expression)
885         (parser_state::mark_completion_tag): Now methods.
886         (prefixify_expression): Add last_struct parameter.
887         (prefixify_subexp): Likewise.
888         (parse_exp_1): Update.
889         (parse_exp_in_context): Add cstate parameter.  Update.
890         (parse_expression_for_completion): Create an
891         expr_completion_state.
892         (null_post_parser): Add "completion" parameter.
893         * p-exp.y: Update rules.
894         (yylex): Update.
895         * language.h (struct language_defn) <la_post_parser>: Add
896         "completing" parameter.
897         * go-exp.y: Update rules.
898         (lex_one_token): Update.
899         * expression.h (parse_completion): Don't declare.
900         * d-exp.y: Update rules.
901         (lex_one_token): Update rules.
902         * c-exp.y: Update rules.
903         (lex_one_token): Update.
904         * ada-lang.c (resolve): Add "parse_completion" parameter.
905         (resolve_subexp): Likewise.
906         (ada_resolve_function): Likewise.
907
908 2019-04-04  Tom Tromey  <tom@tromey.com>
909
910         * parser-defs.h (struct parser_state) <start_arglist,
911         end_arglist>: New methods.
912         <arglist_len, m_funcall_chain>: New members.
913         (arglist_len, start_arglist, end_arglist): Don't declare.
914         * parse.c (arglist_len, funcall_chain): Remove global.
915         (start_arglist, end_arglist): Remove functions.
916         (parse_exp_in_context): Update.
917         * p-exp.y: Update rules.
918         * m2-exp.y: Update rules.
919         * go-exp.y: Update rules.
920         * f-exp.y: Update rules.
921         * d-exp.y: Update rules.
922         * c-exp.y: Update rules.
923
924 2019-04-04  Tom Tromey  <tom@tromey.com>
925
926         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
927         lex_operator, push_back>: New methods.
928         Update all rules.
929         (rust_parser::lex_hex, lex_escape): Rename and update.
930         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
931         (rust_parser::lex_operator): Rename and update.
932         (rust_parser::lex_number, rustyylex, rustyyerror)
933         (rust_lex_test_init, rust_lex_test_sequence)
934         (rust_lex_test_push_back, rust_lex_tests): Update.
935         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
936         parameter.
937         <lexptr, prev_lexptr>: New members.
938         (lexptr, prev_lexptr): Don't declare.
939         * parse.c (lexptr, prev_lexptr): Remove globals.
940         (parse_exp_in_context): Update.
941         * p-exp.y (yylex, yyerror): Update.
942         * m2-exp.y (parse_number, yylex, yyerror): Update.
943         * go-exp.y (lex_one_token, yyerror): Update.
944         * f-exp.y (match_string_literal, yylex, yyerror): Update.
945         * d-exp.y (lex_one_token, yyerror): Update.
946         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
947         (lex_one_token, yyerror): Update.
948         * ada-lex.l (YY_INPUT): Update.
949         (rewind_to_char): Update.
950         * ada-exp.y (yyerror): Update.
951
952 2019-04-04  Tom Tromey  <tom@tromey.com>
953
954         * rust-exp.y (rustyylex, rust_lex_tests): Update.
955         * parser-defs.h (struct parser_state) <parser_state>: Add new
956         parameter.
957         <comma_terminates>: New member.
958         (comma_terminates): Don't declare global.
959         * parse.c (comma_terminates): Remove global.
960         (parse_exp_in_context): Update.
961         * p-exp.y (yylex): Update.
962         * m2-exp.y (yylex): Update.
963         * go-exp.y (lex_one_token): Update.
964         * f-exp.y (yylex): Update.
965         * d-exp.y (lex_one_token): Update.
966         * c-exp.y (lex_one_token): Update.
967         * ada-lex.l: Update.
968
969 2019-04-04  Tom Tromey  <tom@tromey.com>
970
971         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
972         (rustyylex, rust_lex_test_init, rust_lex_test_one)
973         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
974         * parser-defs.h (paren_depth): Don't declare.
975         * parse.c (paren_depth): Remove global.
976         (parse_exp_in_context): Update.
977         * p-exp.y (paren_depth): New global.
978         (pascal_parse): Initialize it.
979         * m2-exp.y (paren_depth): New global.
980         (m2_parse): Initialize it.
981         * go-exp.y (paren_depth): New global.
982         (go_parse): Initialize it.
983         * f-exp.y (paren_depth): New global.
984         (f_parse): Initialize it.
985         * d-exp.y (paren_depth): New global.
986         (d_parse): Initialize it.
987         * c-exp.y (paren_depth): New global.
988         (c_parse): Initialize it.
989         * ada-lex.l (paren_depth): New global.
990         (lexer_init): Initialize it.
991
992 2019-04-04  Tom Tromey  <tom@tromey.com>
993
994         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
995         (rust_parser::convert_ast_to_type)
996         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
997         * parser-defs.h (struct parser_state) <parser_state>: Add
998         parameters.  Initialize new members.
999         <expression_context_block, expression_context_pc>: New members.
1000         * parse.c (expression_context_block, expression_context_pc):
1001         Remove globals.
1002         (parse_exp_in_context): Update.
1003         * p-exp.y: Update all rules.
1004         (yylex): Update.
1005         * m2-exp.y: Update all rules.
1006         (yylex): Update.
1007         * go-exp.y (yylex): Update.
1008         * f-exp.y (yylex): Update.
1009         * d-exp.y: Update all rules.
1010         (yylex): Update.
1011         * c-exp.y: Update all rules.
1012         (lex_one_token, classify_name, yylex, c_parse): Update.
1013         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1014
1015 2019-04-04  Tom Tromey  <tom@tromey.com>
1016
1017         * gdbarch.h, gdbarch.c: Rebuild.
1018         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1019         * stap-probe.h: 
1020         (struct stap_parse_info): Replace "parser_state" with
1021         "expr_builder".
1022         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1023         (parser_state): New class.
1024         * parse.c (expr_builder): Rename.
1025         (expr_builder::release): Rename.
1026         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1027         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1028         (write_exp_elt_longcst, write_exp_elt_floatcst)
1029         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1030         (write_exp_string_vector, write_exp_bitstring)
1031         (write_exp_msymbol, mark_struct_expression)
1032         (write_dollar_variable)
1033         (insert_type_address_space, increase_expout_size): Replace
1034         "parser_state" with "expr_builder".
1035         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1036         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1037         "parser_state" with "expr_builder".
1038
1039 2019-04-04  Tom Tromey  <tom@tromey.com>
1040
1041         * rust-exp.y: Replace "parse_language" with method call.
1042         * p-exp.y: 
1043         (yylex): Replace "parse_language" with method call.
1044         * m2-exp.y: 
1045         (yylex): Replace "parse_language" with method call.
1046         * go-exp.y (classify_name): Replace "parse_language" with method
1047         call.
1048         * f-exp.y (yylex): Replace "parse_language" with method call.
1049         * d-exp.y (lex_one_token): Replace "parse_language" with method
1050         call.
1051         * c-exp.y: 
1052         (lex_one_token, classify_name, yylex): Replace "parse_language"
1053         with method call.
1054         * ada-exp.y (find_primitive_type, type_char)
1055         (type_system_address): Replace "parse_language" with method call.
1056
1057 2019-04-04  Tom Tromey  <tom@tromey.com>
1058
1059         * rust-exp.y: Replace "parse_gdbarch" with method call.
1060         * parse.c (write_dollar_variable, insert_type_address_space):
1061         Replace "parse_gdbarch" with method call.
1062         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1063         call.
1064         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1065         call.
1066         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1067         "parse_gdbarch" with method call.
1068         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1069         with method call.
1070         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1071         "parse_gdbarch" with method call.
1072         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1073         "parse_gdbarch" with method call.
1074         * c-exp.y (parse_type, parse_number, classify_name): Replace
1075         "parse_gdbarch" with method call.
1076         * ada-lex.l: Replace "parse_gdbarch" with method call.
1077         * ada-exp.y (parse_type, find_primitive_type, type_char)
1078         (type_system_address): Replace "parse_gdbarch" with method call.
1079
1080 2019-04-04  Tom Tromey  <tom@tromey.com>
1081
1082         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1083         * stap-probe.c (stap_parse_argument): Update.
1084         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1085         initial_size parameter.
1086         * rust-exp.y (rust_lex_tests): Update.
1087         * parse.c (parser_state): Update.
1088         (parse_exp_in_context): Update.
1089         * parser-defs.h (struct parser_state) <parser_state>: Remove
1090         "initial_size" parameter.
1091
1092 2019-04-04  Tom Tromey  <tom@tromey.com>
1093
1094         * parser-defs.h (increase_expout_size): Don't declare.
1095         * parse.c (increase_expout_size): Now static.
1096
1097 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1098
1099         * gnu-nat.c (gnu_nat_target::wait): Fix
1100         target_waitstatus_to_string call.
1101
1102 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * eval.c (evaluate_subexp_standard): Handle internal functions
1105         during Fortran function call handling.
1106
1107 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * NEWS: Mention new internal functions.
1110         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1111         (read_base_type): Use dwarf2_init_complex_target_type.
1112         * value.c (creal_internal_fn): New function.
1113         (cimag_internal_fn): New function.
1114         (_initialize_values): Register new internal functions.
1115
1116 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * infrun.c (stop_all_threads): If debug_infrun, always
1119         trace the wait status after wait_one, using
1120         target_waitstatus_to_string and target_pid_to_str.
1121         (handle_inferior_event): Replace various trace of
1122         wait status kind by a single trace.
1123         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1124         wait status kind image by target_waitstatus_to_string.
1125         * target/waitstatus.c (target_waitstatus_to_string): Fix
1126         obsolete comment.
1127
1128 2019-04-01  Tom Tromey  <tromey@adacore.com>
1129
1130         PR symtab/23331:
1131         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1132
1133 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1134             Pedro Alves  <palves@redhat.com>
1135
1136         * top.c (quit_force): Call 'finalize_values'.
1137         * value.c (finalize_values): New function.
1138         * value.h (finalize_values): Declare.
1139
1140 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1141
1142         * NEWS: Announce $_gdb_major and $_gdb_minor.
1143
1144         * top.c (init_gdb_version_vars): New function.
1145         (gdb_init): Call init_gdb_version_vars.
1146
1147 2019-03-29  Tom Tromey  <tromey@adacore.com>
1148
1149         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1150         help text.  Remove dead code.
1151
1152 2019-03-29  Keith Seitz  <keiths@redhat.com>
1153
1154         From Siddhesh Poyarekar:
1155         * f-lang.h (f77_get_upperbound): Return LONGEST.
1156         (f77_get_lowerbound): Likewise.
1157         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1158         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1159         print them.
1160         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1161         plongest to format print it.
1162         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1163         (f77_get_upperbound): Likewise.
1164         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1165         LOWER_BOUND to LONGEST.
1166         (f77_create_arrayprint_offset_tbl): Likewise.
1167
1168 2019-03-29  Keith Seitz  <keiths@redhat.com>
1169
1170         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1171         %s/pulongest for TYPE_LENGTH instead of %d in format
1172         strings.
1173         * ada-typerint.c (ada_print_type): Likewise.
1174         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1175         * compile/compile-c-support.c (generate_register_struct): Likewise.
1176         * gdbtypes.c (recursive_dump_type): Likewise.
1177         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1178         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1179         instead of %d in format strings.
1180         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1181         to std::min to ULONGEST.
1182         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1183         instead of %d in format strings.
1184         * tracepoint.c (info_scope_command): Likewise.
1185         * typeprint.c (print_offset_data::update)
1186         (print_offset_data::finish): Likewise.
1187         * xtensa-tdep.c (xtensa_store_return_value)
1188         (xtensa_push_dummy_call): Likewise.
1189
1190 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1191
1192         * windows-nat.c (display_selector): Fixed format specifications
1193         for 64-bit Cygwin.
1194
1195 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1196
1197         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1198
1199 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1200
1201         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1202         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1203         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1204         (nios2_linux_init_abi): Install it.
1205
1206 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1207
1208         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1209
1210 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1211
1212         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1213
1214 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1215             Tom Tromey  <tromey@adacore.com>
1216
1217         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1218
1219 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1220
1221         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1222         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1223         method to compute the bounds of range types. Also print "[evaluated]"
1224         if the bounds' values come from a dynamic evaluation.
1225
1226 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1229         whitespace when pretty printing is on.
1230
1231 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1232
1233         * ppc-linux-nat.c: Add include.
1234
1235 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1236
1237         * NEWS: Mention AArch64 Pointer Authentication.
1238
1239 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1240
1241         * arm-linux-nat.c: Add include.
1242
1243 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1244
1245         * source-cache.c (source_cache::get_source_lines): Re-read
1246         fullname after calling open_source_file.
1247
1248 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1249
1250         * NEWS: Mention TLS support for FreeBSD.
1251
1252 2019-03-25  Tom Tromey  <tromey@adacore.com>
1253
1254         * minsyms.c (BUNCH_SIZE): Update comment.
1255         (~minimal_symbol_reader): Remove old comment.
1256         (compact_minimal_symbols): Update comment.
1257         (minimal_symbol_reader::install): Remove old comment.  Update
1258         other comments.
1259
1260 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1261
1262         * s390-linux-nat.c: Add include.
1263
1264 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1265
1266         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1267         Call linux_get_hwcap.
1268         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1269         Likewise.
1270         (aarch64_linux_get_hwcap): Remove function.
1271         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1272         declaration.
1273         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1274         linux_get_hwcap.
1275         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1276         * linux-tdep.c (linux_get_hwcap): Add function.
1277         (linux_get_hwcap2): Likewise.
1278         * linux-tdep.h (linux_get_hwcap): Add declaration.
1279         (linux_get_hwcap2): Likewise.
1280         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1281         (ppc_linux_get_hwcap2): Likewise.
1282         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1283         linux_get_hwcap.
1284         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1285         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1286         (ppc_linux_nat_target::read_description): Likewise.
1287         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1288         * s390-linux-nat.c: Likewise.
1289         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1290
1291 2019-03-24  Tom Tromey  <tom@tromey.com>
1292
1293         * ada-lang.c (standard_lookup): Simplify initialization.
1294         (ada_lookup_symbol_nonlocal): Simplify return.
1295         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1296         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1297         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1298         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1299         initialization.
1300         * solib.c (solib_global_lookup): Simplify.
1301         * symtab.c (null_block_symbol): Remove.
1302         (symbol_cache_lookup): Simplify returns.
1303         (lookup_language_this): Simplify returns.
1304         (lookup_symbol_aux): Simplify return.
1305         (lookup_local_symbol): Simplify returns.
1306         (lookup_global_symbol_from_objfile): Simplify return.
1307         (lookup_symbol_in_objfile_symtabs)
1308         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1309         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1310         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1311         * cp-namespace.c (cp_lookup_bare_symbol)
1312         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1313         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1314         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1315         (cp_lookup_symbol_via_imports): Simplify initialization.
1316         (find_symbol_in_baseclass): Likewise.
1317         * symtab.h (null_block_symbol): Remove.
1318         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1319         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1320         (d_lookup_symbol_module): Likewise.
1321         (find_symbol_in_baseclass): Simplify initialization.
1322
1323 2019-03-24  Tom Tromey  <tom@tromey.com>
1324
1325         * expression.h: Don't include symtab.h.
1326         (struct block): Forward declare.
1327
1328 2019-03-24  Tom Tromey  <tom@tromey.com>
1329
1330         * c-exp.y (typebase): Remove casts.
1331         * gdbtypes.c (lookup_unsigned_typename, )
1332         (lookup_signed_typename): Remove cast.
1333         * eval.c (parse_to_comma_and_eval): Remove cast.
1334         * parse.c (write_dollar_variable): Remove cast.
1335         * block.h (struct block) <superblock>: Now const.
1336         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1337         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1338         (map_block): Make "block" const.
1339         * symfile.h (struct quick_symbol_functions)
1340         <map_matching_symbols>: Constify block argument to "callback".
1341         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1342         const.
1343         (find_pc_sect_compunit_symtab): Make "b" const.
1344         (find_symbol_at_address): Likewise.
1345         (search_symbols): Likewise.
1346         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1347         (dw2_debug_names_lookup_symbol): Likewise.
1348         (dw2_map_matching_symbols): Update.
1349         * p-valprint.c (pascal_val_print): Remove "block".
1350         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1351         (aux_add_nonlocal_symbols): Make "block" const.
1352         (resolve_subexp): Remove cast.
1353         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1354         const.
1355         (iterate_over_file_blocks): Likewise.
1356         * f-exp.y (%union) <bval>: Remove.
1357         * coffread.c (patch_opaque_types): Make "b" const.
1358         * spu-tdep.c (spu_catch_start): Make "block" const.
1359         * c-valprint.c (print_unpacked_pointer): Remove "block".
1360         * symmisc.c (dump_symtab_1): Make "b" const.
1361         (block_depth): Make "block" const.
1362         * d-exp.y (%union) <bval>: Remove.
1363         * cp-support.h (cp_lookup_rtti_type): Update.
1364         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1365         * psymtab.c (psym_lookup_symbol): Make "block" const.
1366         (maintenance_check_psymtabs): Make "b" const.
1367         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1368         (enumerate_locals, enumerate_args): Update.
1369         * python/py-symtab.c (stpy_global_block): Make "block" const.
1370         (stpy_static_block): Likewise.
1371         * inline-frame.c (block_starting_point_at): Make "new_block"
1372         const.
1373         * block.c (find_block_in_blockvector): Make return type const.
1374         (blockvector_for_pc_sect): Make "b" const.
1375         (find_block_in_blockvector): Make "b" const.
1376
1377 2019-03-23  Tom Tromey  <tom@tromey.com>
1378
1379         * varobj.c (varobj_create): Update.
1380         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1381         * printcmd.c (display_command, do_one_display): Don't reset
1382         innermost_block.
1383         * parser-defs.h (enum innermost_block_tracker_type): Move to
1384         expression.h.
1385         (innermost_block): Update comment.
1386         * parse.c (parse_exp_1): Add tracker_types parameter.
1387         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1388         tracker_types parameter.  Reset innermost_block.
1389         (parse_exp_in_context): Remove.
1390         (parse_expression_for_completion): Update.
1391         * objfiles.c (~objfile): Don't reset expression_context_block or
1392         innermost_block.
1393         * expression.h (enum innermost_block_tracker_type): Move from
1394         parser-defs.h.
1395         (parse_exp_1): Add tracker_types parameter.
1396         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1397         reset innermost_block.
1398
1399 2019-03-23  Tom Tromey  <tom@tromey.com>
1400
1401         * objfiles.h: Include bcache.h.
1402
1403 2019-03-23  Tom Tromey  <tom@tromey.com>
1404
1405         * linespec.c (get_current_search_block): Use
1406         scoped_restore_current_language.
1407         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1408
1409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1410             Jiong Wang  <jiong.wang@arm.com>
1411
1412         * aarch64-linux-tdep.c
1413         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1414         section.
1415         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1416
1417 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1418             Jiong Wang  <jiong.wang@arm.com>
1419
1420         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1421         instructions.
1422         (aarch64_analyze_prologue_test): Add PACIASP test.
1423         (aarch64_prologue_prev_register): Unmask PC value.
1424
1425 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1426             Jiong Wang  <jiong.wang@arm.com>
1427
1428         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1429         (aarch64_dwarf2_prev_register): Unmask PC value.
1430         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1431         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1432         DW_CFA_AARCH64_negate_ra_state.
1433         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1434
1435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1436             Jiong Wang  <jiong.wang@arm.com>
1437
1438         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1439         registers.
1440         (aarch64_pseudo_register_name): Likewise.
1441         (aarch64_pseudo_register_type): Likewise.
1442         (aarch64_pseudo_register_reggroup_p): Likewise.
1443         (aarch64_gdbarch_init): Add pauth registers.
1444         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1445         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1446         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1447         (struct gdbarch_tdep): Add regnum for ra_state.
1448
1449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1450             Jiong Wang  <jiong.wang@arm.com>
1451
1452         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1453
1454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1455             Jiong Wang  <jiong.wang@arm.com>
1456
1457         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1458         function.
1459         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1460         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1461         (aarch64_gdbarch_init): Add puth registers.
1462         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1463         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1464         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1465
1466 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1467             Jiong Wang  <jiong.wang@arm.com>
1468
1469         * aarch64-linux-nat.c
1470         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1471         * aarch64-linux-tdep.c
1472         (aarch64_linux_core_read_description): Likewise.
1473         (aarch64_linux_get_hwcap): New function.
1474         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1475         (aarch64_linux_get_hwcap): New declaration.
1476
1477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1478             Jiong Wang  <jiong.wang@arm.com>
1479
1480         * aarch64-linux-nat.c
1481         (aarch64_linux_nat_target::read_description): Add pauth param.
1482         * aarch64-linux-tdep.c
1483         (aarch64_linux_core_read_description): Likewise.
1484         * aarch64-tdep.c (struct target_desc): Add in pauth.
1485         (aarch64_read_description): Add pauth param.
1486         (aarch64_gdbarch_init): Likewise.
1487         * aarch64-tdep.h (aarch64_read_description): Likewise.
1488         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1489         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1490         * features/Makefile: Add new files.
1491         * features/aarch64-pauth.c: New file.
1492         * features/aarch64-pauth.xml: New file.
1493
1494 2019-03-20  Tom Tromey  <tromey@adacore.com>
1495
1496         * infrun.c (handle_inferior_event): Rename from
1497         handle_inferior_event_1.  Create a scoped_value_mark.
1498         (handle_inferior_event): Remove.
1499
1500 2019-03-19  Tom Tromey  <tromey@adacore.com>
1501
1502         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1503         * infrun.h (print_stop_event): Add "displays" parameter.
1504         * infrun.c (print_stop_event): Add "displays" parameter.
1505
1506 2019-03-19  Pedro Alves  <palves@redhat.com>
1507
1508         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1509         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1510         to -1.  Fix TABs vs spaces.
1511         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1512         * tui/tui-out.h (tui_ui_out) Add intro comments.
1513         <m_line, m_start_of_line>: In-class initialize, and add describing
1514         comment.
1515
1516 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1517
1518         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1519         variable names.
1520         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1521
1522 2019-03-18  Pedro Alves  <palves@redhat.com>
1523             Eli Zaretskii <eliz@gnu.org>
1524
1525         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1526         m_line and m_start_of_line.
1527
1528 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1529
1530         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1531         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1532         it returns a newline.  This fixes a regression in TU mode, whereby
1533         the next line is output on the same screen line as the user input.
1534
1535 2019-03-18  Tom Tromey  <tromey@adacore.com>
1536
1537         * minsyms.c (minimal_symbol_reader::install): Remove call to
1538         obstack_blank.
1539
1540 2019-03-18  Pedro Alves  <palves@redhat.com>
1541
1542         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1543         New globals.
1544         (apply_style): New, factored out from ...
1545         (apply_ansi_escape): ... this.  Handle reverse video mode.
1546         (tui_set_reverse_mode): New function.
1547         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1548         * tui/tui-winsource.c (tui_show_source_line): Use
1549         tui_set_reverse_mode instead of setting A_STANDOUT.
1550         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1551         New setter methods.
1552
1553 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1554
1555         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1556         Handle tabs.
1557
1558 2019-03-18  Tom Tromey  <tromey@adacore.com>
1559
1560         * ada-lang.c (empty_array): Add "high" parameter.
1561         (ada_evaluate_subexp): Update.
1562
1563 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1564
1565         * unittests/string_view-selftests.c: Define
1566         _initialize_string_view_selftests unconditionally.
1567
1568 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1569
1570         PR gdb/24350
1571         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1572
1573 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1574
1575         PR gdb/24351
1576         * windows-nat.c (display_selector): Fix format specifiers.
1577
1578 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1579
1580         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1581         tui_refill_source_window instead of tui_refresh_win, to update the
1582         current execution line.  This fixes redisplay of the current line
1583         when stepping through the code with "next" or "step".
1584
1585 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1586
1587         * source-cache.c (source_cache::get_source_lines): Call
1588         find_source_lines to initialize s->nlines.  This fixes vertical
1589         scrolling of TUI source window when the DOWN arrow is pressed.
1590
1591 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1592
1593         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1594         linux-thread-db.c (_initialize_thread_db): Likewise.
1595
1596 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1597
1598         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1599         wclrtoeol in tui_show_source_line".  This reverts changes made in
1600         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1601
1602 2019-03-15  Tom Tromey  <tom@tromey.com>
1603
1604         * symtab.h (struct minimal_symbol): Derive from
1605         general_symbol_info.
1606         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1607         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1608         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1609         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1610         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1611         (MSYMBOL_SEARCH_NAME): Update.
1612         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1613         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1614         * minsyms.c (minimal_symbol_reader::record_full): Update.
1615
1616 2019-03-15  Tom Tromey  <tom@tromey.com>
1617
1618         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1619
1620 2019-03-15  Tom Tromey  <tom@tromey.com>
1621
1622         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1623         unique_xmalloc_ptr.
1624         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1625         Update.
1626         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1627         (build_minimal_symbol_hash_tables)
1628         (minimal_symbol_reader::install): Update.
1629
1630 2019-03-15  Tom Tromey  <tom@tromey.com>
1631
1632         * symtab.c (create_demangled_names_hash): Update.
1633         (symbol_set_names): Update.
1634         * objfiles.h (struct objfile_per_bfd_storage)
1635         <demangled_names_hash>: Now an htab_up.
1636         * objfiles.c (objfile_per_bfd_storage): Simplify.
1637
1638 2019-03-15  Tom Tromey  <tom@tromey.com>
1639
1640         * objfiles.h (struct objfile_per_bfd_storage): Declare
1641         destructor.
1642         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1643         New.
1644         (get_objfile_bfd_data): Use new.  Don't initialize
1645         language_of_main.
1646         (free_objfile_per_bfd_storage): Remove.
1647         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1648
1649 2019-03-15  Tom Tromey  <tom@tromey.com>
1650
1651         * symfile.c (reread_symbols): Update.
1652         * objfiles.c (objfile::objfile): Update.
1653         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1654         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1655         comment.
1656         (minimal_symbol_reader::install): Update.
1657         (terminate_minimal_symbol_table): Remove.
1658         * jit.c (jit_object_close_impl): Update.
1659
1660 2019-03-15  Tom Tromey  <tom@tromey.com>
1661
1662         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1663         initializations.
1664
1665 2019-03-15  Tom Tromey  <tom@tromey.com>
1666
1667         * objfiles.h (struct objfile_per_bfd_storage)
1668         <demangled_hash_languages>: Now a bitset.
1669         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1670         (lookup_minimal_symbol): Update.
1671
1672 2019-03-15  Tom Tromey  <tom@tromey.com>
1673
1674         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1675         Don't return the symbol.
1676         * coffread.c (record_minimal_symbol): Use record_full.
1677
1678 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1679
1680         The MS-Windows port of ncurses fails to switch to a color pair if
1681         one or both of the colors are the implicit default colors.  This
1682         change records the default colors when TUI is initialized, and
1683         then specifies them explicitly when a color pair uses the default
1684         colors.  This allows color styling in TUI mode on MS-Windows.
1685
1686         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1687         ncurses_norm_attr.
1688         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1689         colors in ncurses_norm_attr.
1690         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1691         "none", replace it with the default color recorded in
1692         ncurses_norm_attr.
1693
1694 2019-03-14  Tom Tromey  <tromey@adacore.com>
1695
1696         * source-cache.h (class source_cache) <get_source_lines>: Return
1697         std::string.
1698         * source-cache.c (source_cache::extract_lines): Handle case where
1699         first_pos==npos.  Return std::string.
1700         (source_cache::get_source_lines): Update.
1701
1702 2019-03-14  Tom Tromey  <tromey@adacore.com>
1703
1704         * NEWS: Add item for "style sources" commands.
1705         * source-cache.c (source_cache::get_source_lines): Check
1706         source_styling.
1707         * cli/cli-style.c (source_styling): New global.
1708         (_initialize_cli_style): Add "style sources" commands.
1709         (show_style_sources): New function.
1710         * cli/cli-style.h (source_styling): Declare.
1711
1712 2019-03-14  Pedro Alves  <palves@redhat.com>
1713             Tom Tromey  <tromey@adacore.com>
1714
1715         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1716         * tui/tui-winsource.c (tui_refill_source_window): New function,
1717         from...
1718         (tui_horizontal_source_scroll): ... here.  Move some logic.
1719         * cli/cli-style.c (set_style_enabled): Notify new observable.
1720         * tui/tui-hooks.c (tui_redisplay_source): New function.
1721         (tui_attach_detach_observers): Attach or detach
1722         tui_redisplay_source.
1723         * observable.h (source_styling_changed): New observable.
1724         * observable.c: Define source_styling_changed observable.
1725
1726 2019-03-13  Tom Tromey  <tromey@adacore.com>
1727
1728         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1729         (i386_gnu_nat_target::store_registers): Update.
1730         * target-debug.h (target_debug_print_std_string): New macro.
1731         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1732         * windows-tdep.c (display_one_tib): Update.
1733         * tui/tui-stack.c (tui_make_status_line): Update.
1734         * top.c (print_inferior_quit_action): Update.
1735         * thread.c (thr_try_catch_cmd): Update.
1736         (add_thread_with_info): Update.
1737         (thread_target_id_str): Update.
1738         (thr_try_catch_cmd): Update.
1739         (thread_command): Update.
1740         (thread_find_command): Update.
1741         * record-btrace.c (record_btrace_target::info_record)
1742         (record_btrace_resume_thread, record_btrace_target::resume)
1743         (record_btrace_cancel_resume, record_btrace_step_thread)
1744         (record_btrace_target::wait, record_btrace_target::wait)
1745         (record_btrace_target::wait, record_btrace_target::stop): Update.
1746         * progspace.c (print_program_space): Update.
1747         * process-stratum-target.c
1748         (process_stratum_target::thread_address_space): Update.
1749         * linux-fork.c (linux_fork_mourn_inferior)
1750         (detach_checkpoint_command, info_checkpoints_command)
1751         (linux_fork_context): Update.
1752         (linux_fork_detach): Update.
1753         (class scoped_switch_fork_info): Update.
1754         (delete_checkpoint_command): Update.
1755         * infrun.c (follow_fork_inferior): Update.
1756         (follow_fork_inferior): Update.
1757         (proceed_after_vfork_done): Update.
1758         (handle_vfork_child_exec_or_exit): Update.
1759         (follow_exec): Update.
1760         (displaced_step_prepare_throw): Update.
1761         (displaced_step_restore): Update.
1762         (start_step_over): Update.
1763         (resume_1): Update.
1764         (clear_proceed_status_thread): Update.
1765         (proceed): Update.
1766         (print_target_wait_results): Update.
1767         (do_target_wait): Update.
1768         (context_switch): Update.
1769         (stop_all_threads): Update.
1770         (restart_threads): Update.
1771         (finish_step_over): Update.
1772         (handle_signal_stop): Update.
1773         (switch_back_to_stepped_thread): Update.
1774         (keep_going_pass_signal): Update.
1775         (print_exited_reason): Update.
1776         (normal_stop): Update.
1777         * inferior.c (inferior_pid_to_str): Change return type.
1778         (print_selected_inferior): Update.
1779         (add_inferior): Update.
1780         (detach_inferior): Update.
1781         * dummy-frame.c (fprint_dummy_frames): Update.
1782         * dcache.c (dcache_info_1): Update.
1783         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1784         (btrace_fetch, btrace_clear): Update.
1785         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1786         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1787         type.
1788         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1789         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1790         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1791         * gdbarch.c, gdbarch.h: Rebuild.
1792         * gdbarch.sh (core_pid_to_str): Change return type.
1793         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1794         return type.
1795         (windows_nat_target::pid_to_str): Change return type.
1796         (windows_delete_thread): Update.
1797         (windows_nat_target::attach): Update.
1798         (windows_nat_target::files_info): Update.
1799         * target-delegates.c: Rebuild.
1800         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1801         return type.
1802         (sol_thread_target::pid_to_str): Change return type.
1803         * remote.c (class remote_target) <pid_to_str>: Change return
1804         type.
1805         (remote_target::pid_to_str): Change return type.
1806         (extended_remote_target::attach, remote_target::remote_stop_ns)
1807         (remote_target::remote_notif_remove_queued_reply)
1808         (remote_target::push_stop_reply, remote_target::disable_btrace):
1809         Update.
1810         (extended_remote_target::attach): Update.
1811         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1812         type.
1813         (gdbsim_target::pid_to_str): Change return type.
1814         * ravenscar-thread.c (struct ravenscar_thread_target)
1815         <pid_to_str>: Change return type.
1816         (ravenscar_thread_target::pid_to_str): Change return type.
1817         * procfs.c (class procfs_target) <pid_to_str>: Change return
1818         type.
1819         (procfs_target::pid_to_str): Change return type.
1820         (procfs_target::attach): Update.
1821         (procfs_target::detach): Update.
1822         (procfs_target::fetch_registers): Update.
1823         (procfs_target::store_registers): Update.
1824         (procfs_target::wait): Update.
1825         (procfs_target::files_info): Update.
1826         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1827         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1828         return type.
1829         (nto_procfs_target::pid_to_str): Change return type.
1830         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1831         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1832         return type.
1833         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1834         (exit_lwp): Update.
1835         (attach_proc_task_lwp_callback, get_detach_signal)
1836         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1837         (linux_nat_target::resume, wait_lwp, stop_callback)
1838         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1839         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1840         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1841         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1842         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1843         type.
1844         (inf_ptrace_target::attach): Update.
1845         (inf_ptrace_target::files_info): Update.
1846         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1847         type.
1848         (go32_nat_target::pid_to_str): Change return type.
1849         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1850         (gnu_nat_target::wait): Update.
1851         (gnu_nat_target::wait): Update.
1852         (gnu_nat_target::resume): Update.
1853         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1854         (fbsd_nat_target::wait): Update.
1855         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1856         type.
1857         (darwin_nat_target::attach): Update.
1858         * corelow.c (class core_target) <pid_to_str>: Change return type.
1859         (core_target::pid_to_str): Change return type.
1860         * target.c (normal_pid_to_str): Change return type.
1861         (default_pid_to_str): Likewise.
1862         (target_pid_to_str): Change return type.
1863         (target_translate_tls_address): Update.
1864         (target_announce_detach): Update.
1865         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1866         return type.
1867         (bsd_uthread_target::pid_to_str): Change return type.
1868         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1869         type.
1870         (bsd_kvm_target::pid_to_str): Change return type.
1871         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1872         return type.
1873         (aix_thread_target::pid_to_str): Change return type.
1874         * target.h (struct target_ops) <pid_to_str>: Change return type.
1875         (target_pid_to_str, normal_pid_to_str): Likewise.
1876         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1877         type.
1878         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1879         type.
1880         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1881         return type.
1882         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1883         type.
1884         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1885         type.
1886         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1887         return type.
1888
1889 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1890
1891         * NEWS: Mention that the new default MI version is 3.  Mention
1892         changes to the output of commands and events that deal with
1893         multi-location breakpoints.
1894         * breakpoint.c: Include "mi/mi-out.h".
1895         (print_one_breakpoint): Change output syntax if using MI version
1896         >= 3.
1897         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1898         New.
1899         (mi_multi_location_breakpoint_output_fixed): New.
1900         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1901         (mi_cmd_fix_multi_location_breakpoint_output): New.
1902         (mi_multi_location_breakpoint_output_fixed): New.
1903         * mi/mi-cmds.c (mi_cmds): Register command
1904         -fix-multi-location-breakpoint-output.
1905         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1906         interpreter "mi".
1907
1908 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1909
1910         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1911         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1912         instantiate mi_ui_out based on interpreter name.
1913         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1914         * mi/mi-main.c (mi_load_progress): Likewise.
1915
1916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1917
1918         * NEWS: Combine separate "New targets" sections for 8.3.
1919
1920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1921
1922         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1923         (ppcfbsd_init_abi): Install gdbarch
1924         "fetch_tls_load_module_address" and "get_thread_local_address"
1925         methods.
1926
1927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1928
1929         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1930         (riscv_fbsd_init_abi): Install gdbarch
1931         "fetch_tls_load_module_address" and "get_thread_local_address"
1932         methods.
1933
1934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1935
1936         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1937         (i386fbsd_init_abi): Install gdbarch
1938         "fetch_tls_load_module_address" and "get_thread_local_address"
1939         methods.
1940
1941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1942
1943         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1944         (amd64fbsd_init_abi): Install gdbarch
1945         "fetch_tls_load_module_address" and "get_thread_local_address"
1946         methods.
1947
1948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1949
1950         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1951         (struct fbsd_pspace_data): New type.
1952         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1953         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1954         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1955         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1956         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1957
1958 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1959
1960         * gdbtypes.c (lookup_struct_elt): New function.
1961         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1962         * gdbtypes.h (struct struct_elt): New type.
1963         (lookup_struct_elt): New prototype.
1964
1965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1966
1967         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1968         remove disabled code block.
1969
1970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1971
1972         * gdbarch.sh (get_thread_local_address): New method.
1973         * gdbarch.h, gdbarch.c: Regenerate.
1974         * target.c (target_translate_tls_address): Use
1975         gdbarch_get_thread_local_address if present instead of
1976         target::get_thread_local_address.
1977
1978 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1979
1980         * target.h (target::get_thread_local_address): Update comment.
1981
1982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1983
1984         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1985         objfile->separate_debug_objfile_backlink if not NULL.
1986
1987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1988
1989         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1990         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1991         (amd64bsd_store_inferior_registers): Likewise.
1992         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1993         Enable segment base registers.
1994         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1995         PT_GETFSBASE and PT_GETGSBASE.
1996         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1997         PT_SETGSBASE.
1998         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1999         segment base registers.
2000         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2001
2002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2003
2004         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2005         Update calls to i386_target_description to add 'segments'
2006         parameter.
2007         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2008         add segment base registers.
2009         * arch/i386.c (i386_create_target_description): Add 'segments'
2010         parameter to enable segment base registers.
2011         * arch/i386.h (i386_create_target_description): Likewise.
2012         * features/i386/32bit-segments.xml: New file.
2013         * features/i386/32bit-segments.c: Generate.
2014         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2015         call to i386_target_description to add 'segments' parameter.
2016         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2017         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2018         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2019         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2020         if feature is present.
2021         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2022         Add 'segments' parameter to call to i386_target_description.
2023         (i386_target_description): Add 'segments' parameter to enable
2024         segment base registers.
2025         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2026         to call to i386_target_description.
2027         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2028         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2029         Define I386_NUM_REGS.
2030         (i386_target_description): Add 'segments' parameter to enable
2031         segment base registers.
2032
2033 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2034
2035         PR/24325
2036         * source-cache.c: #undef open and close, to avoid unresolved
2037         externals during linking.
2038
2039 2019-03-12  Tom Tromey  <tromey@adacore.com>
2040
2041         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2042         const.  Add initializers.
2043         (_initialize_remote): Don't initialize ptid globals.
2044
2045 2019-03-12  Pedro Alves  <palves@redhat.com>
2046
2047         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2048
2049 2019-03-12  Pedro Alves  <palves@redhat.com>
2050
2051         * cp-name-parser.y (main): Remove unused 'len' variable.
2052
2053 2019-03-12  Tom Tromey  <tromey@adacore.com>
2054
2055         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2056         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2057
2058 2019-03-12  Tom Tromey  <tromey@adacore.com>
2059
2060         * linux-nat.c (iterate_over_lwps): Update.
2061         (stop_callback): Remove parameter.
2062         (stop_wait_callback, detach_callback, resume_set_callback)
2063         (select_singlestep_lwp_callback, set_ignore_sigint)
2064         (status_callback, resumed_callback, resume_clear_callback)
2065         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2066         data parameter.
2067         (linux_nat_target::detach, linux_nat_target::resume)
2068         (linux_stop_and_wait_all_lwps, select_event_lwp)
2069         (linux_nat_filter_event, linux_nat_wait_1)
2070         (linux_nat_target::kill, linux_nat_target::stop)
2071         (linux_nat_target::stop): Update.
2072         (linux_nat_resume_callback): Change type.
2073         (resume_stopped_resumed_lwps, count_events_callback)
2074         (select_event_lwp_callback): Likewise.
2075         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2076         * arm-linux-nat.c (struct update_registers_data): Remove.
2077         (update_registers_callback): Change type.
2078         (arm_linux_insert_hw_breakpoint1): Update.
2079         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2080         parameter.
2081         (x86_linux_dr_set_addr): Update.
2082         (x86_linux_dr_set_control): Update.
2083         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2084         (iterate_over_lwps): Use gdb::function_view.
2085         * nat/aarch64-linux-hw-point.c (struct
2086         aarch64_dr_update_callback_param): Remove.
2087         (debug_reg_change_callback): Change type.
2088         (aarch64_notify_debug_reg_change): Update.
2089         * s390-linux-nat.c (s390_refresh_per_info): Update.
2090
2091 2019-03-11  Tom Tromey  <tromey@adacore.com>
2092
2093         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2094         redundant assignment to "this_cu".
2095
2096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2097
2098         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2099
2100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2101
2102         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2103         from...
2104         (rank_one_type): ... this.
2105
2106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2107
2108         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2109         from...
2110         (rank_one_type): ... this.
2111
2112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2113
2114         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2115         from...
2116         (rank_one_type): ... this.
2117
2118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2119
2120         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2121         from...
2122         (rank_one_type): ... this.
2123
2124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2125
2126         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2127         from...
2128         (rank_one_type): ... this.
2129
2130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2131
2132         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2133         from...
2134         (rank_one_type): ... this.
2135
2136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2137
2138         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2139         from...
2140         (rank_one_type): ... this.
2141
2142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2143
2144         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2145         from...
2146         (rank_one_type): ... this.
2147
2148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2149
2150         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2151         from...
2152         (rank_one_type): ... this.
2153
2154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2155
2156         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2157         from...
2158         (rank_one_type): ... this.
2159
2160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2161
2162         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2163         from...
2164         (rank_one_type): ... this.
2165
2166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2167
2168         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2169         from...
2170         (rank_one_type): ... this.
2171
2172 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2173
2174         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2175         inferior-events' shows the example events.
2176
2177 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2178
2179         Support styling on native MS-Windows console
2180
2181         PR/24315
2182         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2183         on MS-Windows if $TERM is not defined.
2184
2185         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2186
2187         * posix-hdep.c (gdb_console_fputs):
2188         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2189         functions.
2190         * ui-file.h (gdb_console_fputs): Add prototype.
2191
2192         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2193         back to fputs only if the former returns zero.
2194
2195 2019-03-07  Tom Tromey  <tom@tromey.com>
2196
2197         * symmisc.c (print_symbol_bcache_statistics): Update.
2198         (print_objfile_statistics): Update.
2199         * symfile.c (allocate_symtab): Update.
2200         * stabsread.c: Don't include bcache.h.
2201         * psymtab.h (struct psymbol_bcache): Don't declare.
2202         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2203         (psymbol_bcache_init, psymbol_bcache_free)
2204         (psymbol_bcache_get_bcache): Don't declare.
2205         * psymtab.c (struct psymbol_bcache): Remove.
2206         (psymtab_storage::psymtab_storage): Update.
2207         (psymtab_storage::~psymtab_storage): Update.
2208         (psymbol_bcache_init, psymbol_bcache_free)
2209         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2210         (add_psymbol_to_bcache): Update.
2211         (allocate_psymtab): Update.
2212         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2213         macro_cache>: No longer pointers.
2214         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2215         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2216         * macrotab.c (macro_bcache): Update.
2217         * macroexp.c: Don't include bcache.h.
2218         * gdbtypes.c (check_types_worklist): Update.
2219         (types_deeply_equal): Remove TRY/CATCH.  Update.
2220         * elfread.c (elf_symtab_read): Update.
2221         * dwarf2read.c: Don't include bcache.h.
2222         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2223         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2224         (print_bcache_statistics, bcache_memory_used): Don't declare.
2225         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2226         methods.  Rename all data members.
2227         * bcache.c (struct bcache): Move to bcache.h.
2228         (bcache::expand_hash_table): Rename from expand_hash_table.
2229         (bcache): Remove.
2230         (bcache::insert): Rename from bcache_full.
2231         (bcache::compare): Rename from bcache_compare.
2232         (bcache_xmalloc): Remove.
2233         (bcache::~bcache): Rename from bcache_xfree.
2234         (bcache::print_statistics): Rename from print_bcache_statistics.
2235         (bcache::memory_used): Rename from bcache_memory_used.
2236
2237 2019-03-07  Pedro Alves  <palves@redhat.com>
2238
2239         * infrun.c (normal_stop): Also check for
2240         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2241
2242 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * f-lang.c (value_from_host_double): Moved to...
2245         * value.c (value_from_host_double): ...here.
2246         * value.h (value_from_host_double): Declare.
2247         * guile/scm-math.c (vlscm_convert_typed_number): Use
2248         value_from_host_double.
2249         (vlscm_convert_number): Likewise.
2250         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2251         * python/py-value.c (convert_value_from_python): Likewise.
2252
2253 2019-03-06  Tom Tromey  <tom@tromey.com>
2254
2255         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2256
2257 2019-03-06  Tom Tromey  <tom@tromey.com>
2258
2259         * utils.h (free_current_contents): Don't declare.
2260         * utils.c (free_current_contents): Remove.
2261
2262 2019-03-06  Tom Tromey  <tom@tromey.com>
2263
2264         * top.c (quit_force): Update.
2265         * main.c (captured_command_loop): Update.
2266         * common/new-op.c (operator new): Update.
2267         * common/common-exceptions.c (struct catcher)
2268         <save_cleanup_chain>: Remove member.
2269         (exceptions_state_mc_init): Update.
2270         (exception_try_scope_entry): Return nullptr.
2271         (exception_try_scope_exit, exception_rethrow)
2272         (throw_exception_sjlj, throw_exception_cxx): Update.
2273         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2274         (all_cleanups, do_cleanups, discard_cleanups)
2275         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2276         (restore_cleanups, restore_final_cleanups): Don't declare.
2277         (do_final_cleanups): Remove parameter.
2278         * common/cleanups.c (cleanup_chain, make_cleanup)
2279         (make_cleanup_dtor, all_cleanups, do_cleanups)
2280         (discard_my_cleanups, discard_cleanups)
2281         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2282         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2283         (null_cleanup): Remove.
2284         (do_final_cleanups): Remove parameter.
2285
2286 2019-03-06  Tom Tromey  <tom@tromey.com>
2287
2288         * remote.c (remote_target::remote_parse_stop_reply): Use
2289         unique_xmalloc_ptr.
2290
2291 2019-03-06  Tom Tromey  <tom@tromey.com>
2292
2293         * stabsread.c (struct stabs_field_info): Rename from field_info.
2294         <list, fnlist>: Add initializers.
2295         <obstack>: New member.
2296         (read_member_functions, read_struct_fields, read_baseclasses):
2297         Allocate on obstack.  Don't use cleanups.
2298         (read_one_struct_field, read_member_functions, read_struct_fields)
2299         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2300         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2301         (read_struct_type): Update.
2302
2303 2019-03-06  Tom Tromey  <tom@tromey.com>
2304
2305         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2306         * common/filestuff.h (make_cleanup_close): Don't declare.
2307         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2308         Remove.
2309
2310 2019-03-06  Tom Tromey  <tom@tromey.com>
2311
2312         * solib-aix.c: Use make_scope_exit.
2313
2314 2019-03-06  Tom Tromey  <tom@tromey.com>
2315
2316         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2317         Use make_scope_exit.
2318
2319 2019-03-06  Tom Tromey  <tom@tromey.com>
2320
2321         * solib-svr4.c (disable_probes_interface): Remove parameter.
2322         (svr4_handle_solib_event): Use make_scope_exit.
2323
2324 2019-03-06  Tom Tromey  <tom@tromey.com>
2325
2326         * remote.c (struct stop_reply_deleter): Remove.
2327         (stop_reply_up): Update.
2328         (struct stop_reply): Derive from notif_event.  Don't typedef.
2329         <regcache>: Now a std::vector.
2330         (stop_reply_xfree): Remove.
2331         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2332         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2333         (remote_target::discard_pending_stop_replies): Use delete.
2334         (remote_target::remote_parse_stop_reply): Update.
2335         (remote_target::process_stop_reply): Update.
2336         * remote-notif.h (struct notif_event): Add virtual destructor.
2337         Remove "dtr" member.
2338         (struct notif_client) <alloc_event>: Return a unique_ptr.
2339         (notif_event_xfree): Don't declare.
2340         (notif_event_up): New typedef.
2341         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2342         (notif_event_xfree, do_notif_event_xfree): Remove.
2343         (remote_notif_state_xfree): Update.
2344
2345 2019-03-06  Tom Tromey  <tom@tromey.com>
2346
2347         * infrun.c (displaced_step_clear_cleanup): Now a
2348         forward_scope_exit type.
2349         (displaced_step_prepare_throw): Update.
2350         (displaced_step_fixup): Update.
2351
2352 2019-03-06  Tom Tromey  <tom@tromey.com>
2353
2354         * inferior.h (class inferior): Update comment.
2355         * gdbthread.h (class thread_info): Update comment.
2356
2357 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2358             Tom Tromey  <tom@tromey.com>
2359
2360         * stabsread.h (struct stab_section_list): Remove.
2361         (coffstab_build_psymtabs): Update.
2362         * dbxread.c (symbuf_sections): Now a std::vector.
2363         (sect_idx): New global.
2364         (fill_symbuf): Update.
2365         (coffstab_build_psymtabs): Change type of stabsects parameter.
2366         Update.
2367         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2368         std::vector.
2369         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2370         (coff_locate_sections): Update.
2371         (coff_symfile_read): Remove cleanups.  Update.
2372         (init_stringtab): Add storage parameter.
2373         (free_stringtab, free_stringtab_cleanup): Remove.
2374         (init_lineno): Add storage parameter.
2375         (free_linetab, free_linetab_cleanup): Remove.
2376
2377 2019-03-06  Pedro Alves  <palves@redhat.com>
2378
2379         * linux-fork.c (fork_info::clobber_regs): Delete.
2380         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2381         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2382         comment.  Adjust.
2383         (scoped_switch_fork_info::scoped_switch_fork_info)
2384         (checkpoint_command, linux_fork_context): Adjust
2385         fork_save_infrun_state calls.
2386
2387 2019-03-06  Pedro Alves  <palves@redhat.com>
2388
2389         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2390         (inf_has_multiple_threads): Return 'bool' and rewrite using
2391         inferior_info::threads().
2392
2393 2019-03-06  Pedro Alves  <palves@redhat.com>
2394
2395         * linux-fork.c: Include <list>.
2396         (fork_list): Now a std::list instance.
2397         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2398         (forks_exist_p, find_last_fork): Adjust.
2399         (new_fork): Delete.
2400         (one_fork_p): New.
2401         (add_fork): Adjust.
2402         (free_fork): Delete, folded into fork_info::~fork_info().
2403         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2404         Adjust.
2405         (init_fork_list): Delete.
2406         (linux_fork_killall, linux_fork_mourn_inferior)
2407         (linux_fork_detach, info_checkpoints_command): Adjust.
2408         (_initialize_linux_fork): No longer call init_fork_list.
2409
2410 2019-03-06  Pedro Alves  <palves@redhat.com>
2411
2412         * linux-fork.c (new_fork): New, split out of ...
2413         (add_fork): ... this.  Return void.  Move "first fork" special
2414         case from here, to ...
2415         (checkpoint_command): ... here.
2416         * linux-linux.h (add_fork): Return void.
2417
2418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2421
2422 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2423             Chris January  <chris.january@arm.com>
2424             David Lecomber  <david.lecomber@arm.com>
2425
2426         * f-exp.y: New token, UNOP_INTRINSIC.
2427         (exp): New pattern using UNOP_INTRINSIC token.
2428         (f77_keywords): Add 'abs' keyword.
2429         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2430         (value_from_host_double): New function.
2431         (evaluate_subexp_f): Support UNOP_ABS.
2432
2433 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2434
2435         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2436         types.
2437
2438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2439
2440         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2441         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2442         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2443
2444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2447
2448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2449             Chris January  <chris.january@arm.com>
2450
2451         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2452         * f-exp.y: Define 'KIND' token.
2453         (exp): New pattern for KIND expressions.
2454         (ptype): Handle types with a kind extension.
2455         (direct_abs_decl): Extend to spot kind extensions.
2456         (f77_keywords): Add 'kind' to the list.
2457         (push_kind_type): New function.
2458         (convert_to_kind_type): New function.
2459         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2460         * parse.c (operator_length_standard): Likewise.
2461         * parser-defs.h (enum type_pieces): Add tp_kind.
2462         * std-operator.def: Add UNOP_KIND.
2463
2464 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2465
2466         * f-exp.y (f_parse): Set yydebug.
2467
2468 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * f-lang.c (evaluate_subexp_f): New function.
2471         (exp_descriptor_f): New global.
2472         (f_language_defn): Use exp_descriptor_f instead of
2473         exp_descriptor_standard.
2474
2475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * f-exp.y (struct token): Add comments.
2478         (dot_ops): Remove uppercase versions and the end marker.
2479         (f77_keywords): Likewise.
2480         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2481         entries in the dot_ops array are case insensitive, and use
2482         strncasecmp to compare strings.  Also some whitespace cleanup in
2483         this area.  Similar for the f77_keywords array, except entries in
2484         this list might be case sensitive.
2485
2486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * f-exp.y (struct f77_boolean_val): Add comments.
2489         (boolean_values): Remove uppercase versions, and end marker.
2490         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2491         and use strncasecmp to achieve case insensitivity.  Additionally,
2492         perform whitespace cleanup around this code.
2493
2494 2019-03-06  Tom Tromey  <tromey@adacore.com>
2495
2496         * remote-sim.c (gdbsim_target_open): Use result of
2497         gdb_argv::release.
2498
2499 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2500         Dirk Schubert  <dirk.schubert@arm.com>
2501         Chris January  <chris.january@arm.com>
2502
2503         * eval.c (evaluate_subexp_standard): Call Fortran argument
2504         wrapping logic.
2505         * f-lang.c (struct value): A value which can be passed into a
2506         Fortran function call.
2507         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2508         where appropriate.
2509         (struct type): Value ready for a Fortran function call.
2510         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2511         is needed.
2512         * f-lang.h (fortran_argument_convert): Declaration.
2513         (fortran_preserve_arg_pointer): Declaration.
2514         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2515
2516 2019-03-05  Tom Tromey  <tromey@adacore.com>
2517
2518         * python/py-prettyprint.c (print_string_repr): Remove #if.
2519         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2520
2521 2019-03-05  Tom Tromey  <tromey@adacore.com>
2522
2523         * target.c (the_dummy_target): Move later.  Change type to
2524         "dummy_target".
2525         (initialize_targets): Don't initialize the_dummy_target.
2526
2527 2019-03-05  Tom Tromey  <tromey@adacore.com>
2528
2529         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2530         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2531
2532 2019-03-05  Tom Tromey  <tromey@adacore.com>
2533
2534         * windows-nat.c (windows_nat_target::attach)
2535         (windows_nat_target::detach): Don't call gdb_flush.
2536         * valprint.c (generic_val_print, val_print, val_print_string):
2537         Don't call gdb_flush.
2538         * utils.c (defaulted_query): Don't call gdb_flush.
2539         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2540         * target.c (target_announce_detach): Don't call gdb_flush.
2541         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2542         * remote.c (extended_remote_target::attach): Don't call
2543         gdb_flush.
2544         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2545         * printcmd.c (do_examine): Don't call gdb_flush.
2546         (info_display_command): Don't call gdb_flush.
2547         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2548         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2549         * memattr.c (info_mem_command): Don't call gdb_flush.
2550         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2551         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2552         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2553         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2554         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2555         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2556         (gnu_nat_target::detach): Don't call gdb_flush.
2557         * f-valprint.c (f_val_print): Don't call gdb_flush.
2558         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2559         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2560         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2561         gdb_flush.
2562         * c-valprint.c (c_val_print): Don't call gdb_flush.
2563         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2564
2565 2019-03-05  Tom Tromey  <tromey@adacore.com>
2566
2567         * varobj.c (update_dynamic_varobj_children): Update.
2568         (install_default_visualizer): Use reset, not release.
2569         * value.c (set_internalvar): Update.
2570         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2571         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2572         ATTRIBUTE_UNUSED_RESULT.
2573
2574 2019-03-05  Tom Tromey  <tromey@adacore.com>
2575
2576         * remote.c (class scoped_remote_fd) <release>: Add
2577         ATTRIBUTE_UNUSED_RESULT.
2578
2579 2019-03-05  Tom Tromey  <tromey@adacore.com>
2580
2581         * macroexp.c (struct macro_buffer) <release>: Add
2582         ATTRIBUTE_UNUSED_RESULT.
2583
2584 2019-03-05  Tom Tromey  <tromey@adacore.com>
2585
2586         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2587         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2588         ATTRIBUTE_UNUSED_RESULT.
2589
2590 2019-03-05  Tom Tromey  <tromey@adacore.com>
2591
2592         * common/scoped_fd.h (class scoped_fd) <release>: Add
2593         ATTRIBUTE_UNUSED_RESULT.
2594
2595 2019-03-05  Tom Tromey  <tromey@adacore.com>
2596
2597         * parser-defs.h (struct parser_state) <release>: Add
2598         ATTRIBUTE_UNUSED_RESULT.
2599
2600 2019-03-05  Tom Tromey  <tromey@adacore.com>
2601
2602         * utils.h (class gdb_argv) <release>: Add
2603         ATTRIBUTE_UNUSED_RESULT.
2604         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2605
2606 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2607
2608         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2609         for-loop range, to avoid compiler warnings.
2610
2611         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2612         avoid compiler warnings about unused variables.
2613
2614         * NEWS: Mention end of support for native debugging on MS-Windows
2615         before XP.
2616
2617         PR gdb/24292
2618         * common/netstuff.c:
2619         * gdbserver/gdbreplay.c
2620         * gdbserver/remote-utils.c:
2621         * ser-tcp.c:
2622         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2623         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2624         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2625         'getaddrinfo' and 'freeaddrinfo' were not available before
2626         Windows XP, and mingw.org's MinGW headers by default define
2627         _WIN32_WINNT to 0x500.
2628
2629 2019-03-01  Gary Benson <gbenson@redhat.com>
2630
2631         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2632
2633 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2634             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2635
2636         PR gdb/8527
2637         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2638         set_sigint_trap, clear_sigint_trap.
2639
2640 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2641
2642         * target.c (target_detach): Clear the regcache and the
2643         frame cache.
2644
2645 2019-02-27  Pedro Alves  <palves@redhat.com>
2646
2647         * utils.c (set_screen_size): When we cap the height/width sizes,
2648         tweak the corresponding command variable to show "unlimited":
2649
2650 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2651             Pedro Alves  <palves@redhat.com>
2652
2653         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2654         before calling rl_set_screen_size.
2655
2656 2019-02-27  Tom Tromey  <tromey@adacore.com>
2657
2658         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2659         define.
2660         * python/py-value.c: Remove Python 2.4 workaround.
2661         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2662         workaround.
2663         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2664         Python 2.4 workaround.
2665         * python/python-internal.h: Remove Python 2.4 comment.
2666         (Py_ssize_t): Don't define.
2667         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2668         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2669         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2670         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2671         * python/python.c (do_start_initialization): Remove Python 2.4
2672         workaround.
2673         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2674         (print_children): Remove Python 2.4 workaround.
2675         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2676         workaround.
2677         (CHARBUFFERPROC_NAME): Remove.
2678         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2679         Python 2.4 workaround.
2680
2681 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2682
2683         * NEWS: Note minimum Python version.
2684
2685 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2686
2687         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2688         code from these functions.  Remove corresponding ifdefs.  Use
2689         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2690         Remove gotos and target of gotos.
2691         (infpy_search_memory): Likewise.
2692
2693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2696         (hppa_gdbarch_init): Don't register deleted functions with
2697         gdbarch.
2698
2699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2702         (h8300_unwind_sp): Delete.
2703         (h8300_dummy_id): Delete.
2704         (h8300_gdbarch_init): Don't register deleted functions with
2705         gdbarch.
2706
2707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2708
2709         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2710         (ft32_unwind_pc): Delete.
2711         (ft32_unwind_sp): Delete.
2712         (ft32_gdbarch_init): Don't register deleted functions with
2713         gdbarch.
2714
2715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2718         (frv_unwind_pc): Delete.
2719         (frv_unwind_sp): Delete.
2720         (frv_gdbarch_init): Don't register deleted functions with
2721         gdbarch.
2722
2723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2726         (riscv_unwind_pc): Delete.
2727         (riscv_unwind_sp): Delete.
2728         (riscv_gdbarch_init): Don't register deleted functions with
2729         gdbarch.
2730
2731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2734         (csky_unwind_pc): Delete.
2735         (csky_unwind_sp): Delete.
2736         (csky_gdbarch_init): Don't register deleted functions with
2737         gdbarch.
2738
2739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2742         (cris_unwind_pc): Delete.
2743         (cris_unwind_sp): Delete.
2744         (cris_gdbarch_init): Don't register deleted functions with
2745         gdbarch.
2746
2747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2750         (bfin_unwind_pc): Delete.
2751         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2752
2753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2754
2755         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2756         (arm_unwind_pc): Delete.
2757         (arm_unwind_sp): Delete.
2758         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2759
2760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2763         (arc_unwind_pc): Delete.
2764         (arc_unwind_sp): Delete.
2765         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2766
2767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2768
2769         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2770         (alpha_unwind_pc): Delete.
2771         (alpha_gdbarch_init): Don't register deleted functions with
2772         gdbarch.
2773
2774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2775
2776         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2777         (aarch64_unwind_pc): Delete.
2778         (aarch64_unwind_sp): Delete.
2779         (aarch64_gdbarch_init): Don't register deleted functions with
2780         gdbarch.
2781
2782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * gdbtypes.c (type_align): Don't consider static members when
2785         computing structure alignment.
2786
2787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2790         return 0 for other types.
2791         * arch-utils.c (default_type_align): Always return 0.
2792         * gdbarch.h: Regenerate.
2793         * gdbarch.sh (type_align): Extend comment.
2794         * gdbtypes.c (type_align): Add additional comments, always call
2795         gdbarch_type_align before applying the default rules.
2796         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2797         generic code will then apply a suitable default.
2798         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2799         types, return 0 for other types.
2800
2801 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2802
2803         * NEWS: Create a new section for the next release branch.
2804         Rename the section of the current branch, now that it has
2805         been cut.
2806
2807 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2808
2809         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2810         * version.in: Bump version to 8.3.50.DATE-git.
2811
2812 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2813
2814         * aix-thread.c (ptid_cmp): Remove unused variable.
2815         (get_signaled_thread): Likewise.
2816         (store_regs_user_thread): Likewise.
2817         (store_regs_kernel_thread): Likewise.
2818         (fetch_regs_kernel_thread): Remove shadowed variable.
2819
2820 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * features/riscv/32bit-cpu.xml: Add register numbers.
2823         * features/riscv/32bit-fpu.c: Regenerate.
2824         * features/riscv/32bit-fpu.xml: Add register numbers.
2825         * features/riscv/64bit-cpu.xml: Add register numbers.
2826         * features/riscv/64bit-fpu.c: Regenerate.
2827         * features/riscv/64bit-fpu.xml: Add register numbers.
2828
2829 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2830
2831         * NEWS: Mention two argument form of gdb.Value constructor.
2832         * python/py-value.c (convert_buffer_and_type_to_value): New
2833         function.
2834         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2835         Add support for handling an optional second argument.  Call
2836         convert_buffer_and_type_to_value as appropriate.
2837         * python/python-internal.h (Py_buffer_deleter): New struct.
2838         (Py_buffer_up): New typedef.
2839
2840 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2841
2842         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2843         instead of releasing ownership.
2844
2845 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2846
2847         * dwarf2read.c (open_and_init_dwp_file): Call
2848         elf_numsections instead of bfd_count_sections to initialize
2849         dwp_file->num_sections.
2850
2851 2019-02-25  Tom Tromey  <tromey@adacore.com>
2852
2853         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2854
2855 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2856
2857         * gcore.in: Add '--readnever' option when invoking GDB.
2858
2859 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2860
2861         * MAINTAINERS: Update my email address.
2862
2863 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2864
2865         * build-id.c (build_id_to_debug_bfd_1): New function.
2866         (build_id_to_debug_bfd): Look for separate debug file in
2867         sysroot.
2868
2869 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * gdbarch.sh: Update the copyright year range that is placed into
2872         generated files.
2873
2874 2019-02-22  Keith Seitz  <keiths@redhat.com>
2875
2876         PR symtab/23853
2877         * linespec.c (create_sals_line_offset): Search for the default
2878         symtab's filename instead of its fullname.
2879
2880 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2881
2882         * NEWS: Update style defaults.
2883
2884 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2885
2886         * main.c (captured_main_1): Disable styling in batch mode.
2887
2888 2019-02-20  Tom Tromey  <tom@tromey.com>
2889
2890         * symtab.c (symtab_symbol_info): Fix typos.
2891
2892 2019-02-20  Tom Tromey  <tromey@adacore.com>
2893
2894         * findcmd.c (_initialize_mem_search): Use upper case for
2895         metasyntactic variables.
2896
2897 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2898
2899         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2900         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2901
2902 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2903
2904         * top.h (source_file_name): Change to std::string.
2905         * top.c (source_file_name): Likewise.
2906         (command_line_input): Adjust.
2907         * cli/cli-script.c (script_from_file): Adjust.
2908
2909 2019-02-19  Tom Tromey  <tromey@adacore.com>
2910
2911         * ravenscar-thread.c
2912         (ravenscar_thread_target::update_thread_list): Don't call
2913         ada_build_task_list.
2914         * ada-lang.h (ada_build_task_list): Don't declare.
2915         * ada-tasks.c (struct ada_tasks_inferior_data)
2916         <task_list_valid_p>: Now bool.
2917         (read_known_tasks, ada_task_list_changed)
2918         (ada_tasks_invalidate_inferior_data): Update.
2919         (read_known_tasks_array): Return bool.
2920         (read_known_tasks_list): Likewise.
2921         (read_known_tasks): Return void.
2922         (ada_build_task_list): Now static.
2923
2924 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2925
2926         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2927         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2928
2929 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2930
2931         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2932         variant for ada_tasks_pspace_data_handle and
2933         ada_tasks_inferior_data_handle.
2934         (ada_tasks_pspace_data_cleanup): New function.
2935         (ada_tasks_inferior_data_cleanup): New function.
2936
2937 2019-02-17  Tom Tromey  <tom@tromey.com>
2938
2939         * macrotab.h (macro_source_fullname): Return a std::string.
2940         * macrotab.c (macro_include, check_for_redefinition)
2941         (macro_undef, macro_lookup_definition, foreach_macro)
2942         (foreach_macro_in_scope): Update.
2943         (macro_source_fullname): Return a std::string.
2944         * macrocmd.c (show_pp_source_pos): Update.
2945
2946 2019-02-17  Tom Tromey  <tom@tromey.com>
2947
2948         * macrocmd.c (show_pp_source_pos): Style the file names.
2949
2950 2019-02-17  Tom Tromey  <tom@tromey.com>
2951
2952         PR tui/24197:
2953         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2954
2955 2019-02-17  Tom Tromey  <tom@tromey.com>
2956
2957         * ada-lang.c (user_select_syms): Use filtered printing.
2958         * utils.c (wrap_style): New global.
2959         (desired_style): Remove.
2960         (emit_style_escape): Add stream parameter.
2961         (set_output_style, reset_terminal_style, prompt_for_continue):
2962         Update.
2963         (flush_wrap_buffer): Only flush gdb_stdout.
2964         (wrap_here): Set wrap_style.
2965         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2966         treat escape sequences as a character.  Change when wrap buffer is
2967         flushed.
2968         (fputs_styled): Do not set the output style when the default is
2969         requested.
2970         * ui-style.h (struct ui_file_style) <is_default>: New method.
2971         * source.c (print_source_lines_base): Emit escape sequences in one
2972         piece.
2973
2974 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2975
2976         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2977         integers and enumeration types.
2978
2979 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2980
2981         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2982         instead of lookup_symbol_in_language
2983         (do_exact_match): New function.
2984         (ada_get_symbol_name_matcher): Return do_exact_match when
2985         doing a verbatim match.
2986
2987 2019-02-15  Tom Tromey  <tromey@adacore.com>
2988
2989         * ravenscar-thread.c (ravenscar_thread_target::resume)
2990         (ravenscar_thread_target::wait): Special case wildcard requests.
2991
2992 2019-02-15  Tom Tromey  <tromey@adacore.com>
2993
2994         * ravenscar-thread.c (base_ptid): Remove.
2995         (struct ravenscar_thread_target) <close>: New method.
2996         <m_base_ptid>: New member.
2997         <update_inferior_ptid, active_task, task_is_currently_active,
2998         runtime_initialized>: Declare methods.
2999         <ravenscar_thread_target>: Add constructor.
3000         (ravenscar_thread_target::task_is_currently_active)
3001         (ravenscar_thread_target::update_inferior_ptid)
3002         (ravenscar_runtime_initialized): Rename.  Now methods.
3003         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3004         (ravenscar_thread_target::update_thread_list): Update.
3005         (ravenscar_thread_target::active_task): Now method.
3006         (ravenscar_thread_target::store_registers)
3007         (ravenscar_thread_target::prepare_to_store)
3008         (ravenscar_thread_target::prepare_to_store)
3009         (ravenscar_thread_target::mourn_inferior): Update.
3010         (ravenscar_inferior_created): Use "new" to create target.
3011         (ravenscar_thread_target::get_ada_task_ptid): Update.
3012         (_initialize_ravenscar): Don't initialize base_ptid.
3013         (ravenscar_ops): Remove global.
3014
3015 2019-02-15  Tom Tromey  <tromey@adacore.com>
3016
3017         * target.h (push_target): Declare new overload.
3018         * target.c (push_target): New overload, taking an rvalue reference.
3019         * remote.c (remote_target::open_1): Use push_target overload.
3020         * corelow.c (core_target_open): Use push_target overload.
3021
3022 2019-02-15  Tom Tromey  <tromey@adacore.com>
3023
3024         * ravenscar-thread.c (is_ravenscar_task)
3025         (ravenscar_task_is_currently_active): Return bool.
3026         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3027         (_initialize_ravenscar): Remove "(void)".
3028         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3029         Return bool.
3030
3031 2019-02-15  Tom Tromey  <tromey@adacore.com>
3032
3033         * ravenscar-thread.c (ravenscar_runtime_initializer)
3034         (has_ravenscar_runtime, get_running_thread_id)
3035         (ravenscar_thread_target::resume): Fix indentation.
3036
3037 2019-02-15  Tom Tromey  <tromey@adacore.com>
3038
3039         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3040         from ravenscar_arch_ops.
3041         (sparc_ravenscar_ops::fetch_registers)
3042         (sparc_ravenscar_ops::store_registers): Now methods.
3043         (sparc_ravenscar_prepare_to_store): Remove.
3044         (sparc_ravenscar_ops): Redefine.
3045         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3046         methods and destructor.  Remove members.
3047         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3048         (ravenscar_thread_target::store_registers)
3049         (ravenscar_thread_target::prepare_to_store): Update.
3050         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3051         Remove.
3052         (struct ppc_ravenscar_powerpc_ops): Derive from
3053         ravenscar_arch_ops.
3054         (ppc_ravenscar_powerpc_ops::fetch_registers)
3055         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3056         (ppc_ravenscar_powerpc_ops): Redefine.
3057         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3058         (ppc_ravenscar_e500_ops::fetch_registers)
3059         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3060         (ppc_ravenscar_e500_ops): Redefine.
3061         * aarch64-ravenscar-thread.c
3062         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3063         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3064         (aarch64_ravenscar_fetch_registers)
3065         (aarch64_ravenscar_store_registers): Now methods.
3066         (aarch64_ravenscar_ops): Redefine.
3067
3068 2019-02-15  Tom Tromey  <tromey@adacore.com>
3069
3070         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3071         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3072         (ravenscar_thread_target::stopped_by_watchpoint)
3073         (ravenscar_thread_target::stopped_data_address)
3074         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3075
3076 2019-02-15  Tom Tromey  <tromey@adacore.com>
3077
3078         * ravenscar-thread.c: Fix some typos.
3079
3080 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3081             Tom Tromey  <tromey@adacore.com>
3082
3083         * ada-lang.c (ada_exception_sal): Change addr_string to a
3084         std::string.
3085         (create_ada_exception_catchpoint): Update.
3086
3087 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3088             Tom Tromey  <tromey@adacore.com>
3089
3090         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3091         (bp_location_ops): Remove.
3092         (base_breakpoint_allocate_location): Update.
3093         (free_bp_location): Update.
3094         * ada-lang.c (class ada_catchpoint_location)
3095         <ada_catchpoint_location>: Remove ops parameter.
3096         (ada_catchpoint_location_dtor): Remove.
3097         (ada_catchpoint_location_ops): Remove.
3098         (allocate_location_exception): Update.
3099         * breakpoint.h (struct bp_location_ops): Remove.
3100         (class bp_location) <bp_location>: Remove bp_location_ops
3101         parameter.
3102         <~bp_location>: Add destructor.
3103         <ops>: Remove.
3104
3105 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3106             Pedro Alves  <palves@redhat.com>
3107
3108         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3109         'PATH_MAX'.
3110
3111 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3112             Samuel Thibault  <samuel.thibault@gnu.org>
3113             Thomas Schwinge  <thomas@codesourcery.com>
3114
3115         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3116         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3117
3118 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3119
3120         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3121         (check_empty): Use "const char *".
3122
3123         * gnu-nat.c (gnu_nat_target::detach): Instead of
3124         'detach_inferior (pid)' call
3125         'detach_inferior (find_inferior_pid (pid))'.
3126
3127         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3128         'nat/fork-inferior.o'.
3129         * gnu-nat.c: #include "nat/fork-inferior.h".
3130
3131         * gnu-nat.c (gnu_nat_target::detach): Instead of
3132         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3133         * gnu-nat.h: #include "inf-child.h".
3134         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3135         'i386_gnu_nat_target::fetch_registers'.
3136         (gnu_store_registers): Rename/move to
3137         'i386_gnu_nat_target::store_registers'.
3138
3139         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3140         * gnu-nat.h (mach_thread_info): New function.
3141         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3142
3143         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3144
3145 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3146
3147         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3148
3149 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3150
3151         * windows-nat.c (windows_add_thread): Add new parameter
3152         "main_thread_p" with default value set to false.  Update
3153         function documentation as well as all callers.
3154         (windows_delete_thread): Likewise.
3155         (fake_create_process): Update call to windows_add_thread.
3156         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3157         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3158         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3159         call to windows_delete_thread.
3160
3161 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3162
3163         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3164
3165 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3166
3167         * symfile.c (find_separate_debug_file): Use canonical path of
3168         sysroot with child_path instead of gdb_sysroot if it is valid.
3169
3170 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3171
3172         * symfile.c (find_separate_debug_file): Use child_path to
3173         determine if an object file is under a sysroot.
3174
3175 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3176
3177         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3178         unittests/child-path-selftests.c.
3179         * common/pathstuff.c (child_path): New function.
3180         * common/pathstuff.h (child_path): New prototype.
3181         * unittests/child-path-selftests.c: New file.
3182
3183 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3184
3185         * symfile.c (find_separate_debug_file): Look for separate debug
3186         files in debug directories under the sysroot.
3187
3188 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3189
3190         * symtab.h (struct minimal_symbol data_p): New const method.
3191         (struct minimal_symbol text_p): Likewise.
3192         * symtab.c (output_source_filename): Use file name style
3193         to print file name.
3194         (print_symbol_info): Likewise.
3195         (print_msymbol_info): Use address style to print addresses.
3196         Use function name style to print executable text symbols.
3197         (expand_symtab_containing_pc): Use data_p.
3198         (find_pc_sect_compunit_symtab): Likewise.
3199
3200 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3201
3202         * breakpoint.c (describe_other_breakpoints): Use address style
3203         to print addresses.
3204         (say_where): Likewise.
3205
3206 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3207
3208         * ada-typeprint.c (print_func_type): Print function name
3209         style to print function name.
3210         * c-typeprint.c (c_print_type_1): Likewise.
3211
3212 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3213
3214         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3215         for execve.
3216
3217 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3218
3219         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3220         type_stack.
3221
3222 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3223
3224         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3225         TYPE_CODE_REF types.
3226
3227 2019-02-08  Jim Wilson  <jimw@sifive.com>
3228
3229         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3230         (riscv_linux_fregset): New.
3231         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3232
3233 2019-02-07  Tom Tromey  <tom@tromey.com>
3234
3235         * thread.c (thread_cancel_execution_command): Update.
3236         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3237         methods.
3238         (struct thread_fsm_ops): Remove.
3239         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3240         (thread_fsm_should_stop, thread_fsm_return_value)
3241         (thread_fsm_set_finished, thread_fsm_finished_p)
3242         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3243         Don't declare.
3244         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3245         * infrun.c (clear_proceed_status_thread)
3246         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3247         (print_stop_event): Update.
3248         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3249         Add constructor.
3250         (step_command_fsm_ops): Remove.
3251         (new_step_command_fsm): Remove.
3252         (step_1): Update.
3253         (step_command_fsm::should_stop): Rename from
3254         step_command_fsm_should_stop.
3255         (step_command_fsm::clean_up): Rename from
3256         step_command_fsm_clean_up.
3257         (step_command_fsm::do_async_reply_reason): Rename from
3258         step_command_fsm_async_reply_reason.
3259         (struct until_next_fsm): Inherit from thread_fsm.  Add
3260         constructor.
3261         (until_next_fsm_ops): Remove.
3262         (new_until_next_fsm): Remove.
3263         (until_next_fsm::should_stop): Rename from
3264         until_next_fsm_should_stop.
3265         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3266         (until_next_fsm::do_async_reply_reason): Rename from
3267         until_next_fsm_async_reply_reason.
3268         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3269         constructor.  Change type of breakpoint.
3270         (finish_command_fsm_ops): Remove.
3271         (new_finish_command_fsm): Remove.
3272         (finish_command_fsm::should_stop): Rename from
3273         finish_command_fsm_should_stop.
3274         (finish_command_fsm::clean_up): Rename from
3275         finish_command_fsm_clean_up.
3276         (finish_command_fsm::return_value): Rename from
3277         finish_command_fsm_return_value.
3278         (finish_command_fsm::do_async_reply_reason): Rename from
3279         finish_command_fsm_async_reply_reason.
3280         (finish_command): Update.
3281         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3282         Add constructor.
3283         (call_thread_fsm_ops): Remove.
3284         (call_thread_fsm::call_thread_fsm): Rename from
3285         new_call_thread_fsm.
3286         (call_thread_fsm::should_stop): Rename from
3287         call_thread_fsm_should_stop.
3288         (call_thread_fsm::should_notify_stop): Rename from
3289         call_thread_fsm_should_notify_stop.
3290         (run_inferior_call, call_function_by_hand_dummy): Update.
3291         * cli/cli-interp.c (should_print_stop_to_console): Update.
3292         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3293         Add constructor.  Change type of location_breakpoint,
3294         caller_breakpoint.
3295         (until_break_fsm_ops): Remove.
3296         (new_until_break_fsm): Remove.
3297         (until_break_fsm::should_stop): Rename from
3298         until_break_fsm_should_stop.
3299         (until_break_fsm::clean_up): Rename from
3300         until_break_fsm_clean_up.
3301         (until_break_fsm::do_async_reply_reason): Rename from
3302         until_break_fsm_async_reply_reason.
3303         (until_break_command): Update.
3304         * thread-fsm.c: Remove.
3305         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3306
3307 2019-02-07  Tom Tromey  <tom@tromey.com>
3308
3309         * yy-remap.h: Add include guard.
3310         * xtensa-tdep.h: Add include guard.
3311         * xcoffread.h: Rename include guard.
3312         * varobj-iter.h: Add include guard.
3313         * tui/tui.h: Rename include guard.
3314         * tui/tui-winsource.h: Rename include guard.
3315         * tui/tui-wingeneral.h: Rename include guard.
3316         * tui/tui-windata.h: Rename include guard.
3317         * tui/tui-win.h: Rename include guard.
3318         * tui/tui-stack.h: Rename include guard.
3319         * tui/tui-source.h: Rename include guard.
3320         * tui/tui-regs.h: Rename include guard.
3321         * tui/tui-out.h: Rename include guard.
3322         * tui/tui-layout.h: Rename include guard.
3323         * tui/tui-io.h: Rename include guard.
3324         * tui/tui-hooks.h: Rename include guard.
3325         * tui/tui-file.h: Rename include guard.
3326         * tui/tui-disasm.h: Rename include guard.
3327         * tui/tui-data.h: Rename include guard.
3328         * tui/tui-command.h: Rename include guard.
3329         * tic6x-tdep.h: Add include guard.
3330         * target/waitstatus.h: Rename include guard.
3331         * target/wait.h: Rename include guard.
3332         * target/target.h: Rename include guard.
3333         * target/resume.h: Rename include guard.
3334         * target-float.h: Rename include guard.
3335         * stabsread.h: Add include guard.
3336         * rs6000-tdep.h: Add include guard.
3337         * riscv-fbsd-tdep.h: Add include guard.
3338         * regformats/regdef.h: Rename include guard.
3339         * record.h: Rename include guard.
3340         * python/python.h: Rename include guard.
3341         * python/python-internal.h: Rename include guard.
3342         * python/py-stopevent.h: Rename include guard.
3343         * python/py-ref.h: Rename include guard.
3344         * python/py-record.h: Rename include guard.
3345         * python/py-record-full.h: Rename include guard.
3346         * python/py-record-btrace.h: Rename include guard.
3347         * python/py-instruction.h: Rename include guard.
3348         * python/py-events.h: Rename include guard.
3349         * python/py-event.h: Rename include guard.
3350         * procfs.h: Add include guard.
3351         * proc-utils.h: Add include guard.
3352         * p-lang.h: Add include guard.
3353         * or1k-tdep.h: Rename include guard.
3354         * observable.h: Rename include guard.
3355         * nto-tdep.h: Rename include guard.
3356         * nat/x86-linux.h: Rename include guard.
3357         * nat/x86-linux-dregs.h: Rename include guard.
3358         * nat/x86-gcc-cpuid.h: Add include guard.
3359         * nat/x86-dregs.h: Rename include guard.
3360         * nat/x86-cpuid.h: Rename include guard.
3361         * nat/ppc-linux.h: Rename include guard.
3362         * nat/mips-linux-watch.h: Rename include guard.
3363         * nat/linux-waitpid.h: Rename include guard.
3364         * nat/linux-ptrace.h: Rename include guard.
3365         * nat/linux-procfs.h: Rename include guard.
3366         * nat/linux-osdata.h: Rename include guard.
3367         * nat/linux-nat.h: Rename include guard.
3368         * nat/linux-namespaces.h: Rename include guard.
3369         * nat/linux-btrace.h: Rename include guard.
3370         * nat/glibc_thread_db.h: Rename include guard.
3371         * nat/gdb_thread_db.h: Rename include guard.
3372         * nat/gdb_ptrace.h: Rename include guard.
3373         * nat/fork-inferior.h: Rename include guard.
3374         * nat/amd64-linux-siginfo.h: Rename include guard.
3375         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3376         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3377         * nat/aarch64-linux.h: Rename include guard.
3378         * nat/aarch64-linux-hw-point.h: Rename include guard.
3379         * mn10300-tdep.h: Add include guard.
3380         * mips-linux-tdep.h: Add include guard.
3381         * mi/mi-parse.h: Rename include guard.
3382         * mi/mi-out.h: Rename include guard.
3383         * mi/mi-main.h: Rename include guard.
3384         * mi/mi-interp.h: Rename include guard.
3385         * mi/mi-getopt.h: Rename include guard.
3386         * mi/mi-console.h: Rename include guard.
3387         * mi/mi-common.h: Rename include guard.
3388         * mi/mi-cmds.h: Rename include guard.
3389         * mi/mi-cmd-break.h: Rename include guard.
3390         * m2-lang.h: Add include guard.
3391         * location.h: Rename include guard.
3392         * linux-record.h: Rename include guard.
3393         * linux-nat.h: Add include guard.
3394         * linux-fork.h: Add include guard.
3395         * i386-darwin-tdep.h: Rename include guard.
3396         * hppa-linux-offsets.h: Add include guard.
3397         * guile/guile.h: Rename include guard.
3398         * guile/guile-internal.h: Rename include guard.
3399         * gnu-nat.h: Rename include guard.
3400         * gdb-stabs.h: Rename include guard.
3401         * frv-tdep.h: Add include guard.
3402         * f-lang.h: Add include guard.
3403         * event-loop.h: Add include guard.
3404         * darwin-nat.h: Rename include guard.
3405         * cp-abi.h: Rename include guard.
3406         * config/sparc/nm-sol2.h: Rename include guard.
3407         * config/nm-nto.h: Rename include guard.
3408         * config/nm-linux.h: Add include guard.
3409         * config/i386/nm-i386gnu.h: Rename include guard.
3410         * config/djgpp/nl_types.h: Rename include guard.
3411         * config/djgpp/langinfo.h: Rename include guard.
3412         * compile/gcc-cp-plugin.h: Add include guard.
3413         * compile/gcc-c-plugin.h: Add include guard.
3414         * compile/compile.h: Rename include guard.
3415         * compile/compile-object-run.h: Rename include guard.
3416         * compile/compile-object-load.h: Rename include guard.
3417         * compile/compile-internal.h: Rename include guard.
3418         * compile/compile-cplus.h: Rename include guard.
3419         * compile/compile-c.h: Rename include guard.
3420         * common/xml-utils.h: Rename include guard.
3421         * common/x86-xstate.h: Rename include guard.
3422         * common/version.h: Rename include guard.
3423         * common/vec.h: Rename include guard.
3424         * common/tdesc.h: Rename include guard.
3425         * common/selftest.h: Rename include guard.
3426         * common/scoped_restore.h: Rename include guard.
3427         * common/scoped_mmap.h: Rename include guard.
3428         * common/scoped_fd.h: Rename include guard.
3429         * common/safe-iterator.h: Rename include guard.
3430         * common/run-time-clock.h: Rename include guard.
3431         * common/refcounted-object.h: Rename include guard.
3432         * common/queue.h: Rename include guard.
3433         * common/ptid.h: Rename include guard.
3434         * common/print-utils.h: Rename include guard.
3435         * common/preprocessor.h: Rename include guard.
3436         * common/pathstuff.h: Rename include guard.
3437         * common/observable.h: Rename include guard.
3438         * common/netstuff.h: Rename include guard.
3439         * common/job-control.h: Rename include guard.
3440         * common/host-defs.h: Rename include guard.
3441         * common/gdb_wait.h: Rename include guard.
3442         * common/gdb_vecs.h: Rename include guard.
3443         * common/gdb_unlinker.h: Rename include guard.
3444         * common/gdb_unique_ptr.h: Rename include guard.
3445         * common/gdb_tilde_expand.h: Rename include guard.
3446         * common/gdb_sys_time.h: Rename include guard.
3447         * common/gdb_string_view.h: Rename include guard.
3448         * common/gdb_splay_tree.h: Rename include guard.
3449         * common/gdb_setjmp.h: Rename include guard.
3450         * common/gdb_ref_ptr.h: Rename include guard.
3451         * common/gdb_optional.h: Rename include guard.
3452         * common/gdb_locale.h: Rename include guard.
3453         * common/gdb_assert.h: Rename include guard.
3454         * common/filtered-iterator.h: Rename include guard.
3455         * common/filestuff.h: Rename include guard.
3456         * common/fileio.h: Rename include guard.
3457         * common/environ.h: Rename include guard.
3458         * common/common-utils.h: Rename include guard.
3459         * common/common-types.h: Rename include guard.
3460         * common/common-regcache.h: Rename include guard.
3461         * common/common-inferior.h: Rename include guard.
3462         * common/common-gdbthread.h: Rename include guard.
3463         * common/common-exceptions.h: Rename include guard.
3464         * common/common-defs.h: Rename include guard.
3465         * common/common-debug.h: Rename include guard.
3466         * common/cleanups.h: Rename include guard.
3467         * common/buffer.h: Rename include guard.
3468         * common/btrace-common.h: Rename include guard.
3469         * common/break-common.h: Rename include guard.
3470         * cli/cli-utils.h: Rename include guard.
3471         * cli/cli-style.h: Rename include guard.
3472         * cli/cli-setshow.h: Rename include guard.
3473         * cli/cli-script.h: Rename include guard.
3474         * cli/cli-interp.h: Rename include guard.
3475         * cli/cli-decode.h: Rename include guard.
3476         * cli/cli-cmds.h: Rename include guard.
3477         * charset-list.h: Add include guard.
3478         * buildsym-legacy.h: Rename include guard.
3479         * bfin-tdep.h: Add include guard.
3480         * ax.h: Rename include guard.
3481         * arm-linux-tdep.h: Add include guard.
3482         * arm-fbsd-tdep.h: Add include guard.
3483         * arch/xtensa.h: Rename include guard.
3484         * arch/tic6x.h: Add include guard.
3485         * arch/i386.h: Add include guard.
3486         * arch/arm.h: Rename include guard.
3487         * arch/arm-linux.h: Rename include guard.
3488         * arch/arm-get-next-pcs.h: Rename include guard.
3489         * arch/amd64.h: Add include guard.
3490         * arch/aarch64-insn.h: Rename include guard.
3491         * arch-utils.h: Rename include guard.
3492         * annotate.h: Add include guard.
3493         * amd64-darwin-tdep.h: Rename include guard.
3494         * aarch64-linux-tdep.h: Add include guard.
3495         * aarch64-fbsd-tdep.h: Add include guard.
3496         * aarch32-linux-nat.h: Add include guard.
3497
3498 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3499
3500         * macrotab.c (macro_define_internal): New function that
3501         factorizes macro_define_object_internal and macro_define_function
3502         code.
3503         (macro_define_object_internal): Use macro_define_internal.
3504         (macro_define_function): Likewise.
3505
3506 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3507
3508         * macrocmd.c (extract_identifier): Return
3509         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3510         callers.
3511
3512 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3513
3514         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3515
3516 2019-02-05  Tom Tromey  <tom@tromey.com>
3517
3518         * target.c (target_stack::unpush): Move assertion earlier.
3519
3520 2019-01-30  Tom Tromey  <tom@tromey.com>
3521
3522         PR python/23615:
3523         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3524         (gdbpy_parse_and_eval): Likewise.
3525         * python/python-internal.h (gdbpy_allow_threads): New class.
3526
3527 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3528
3529         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3530         (aarch64_fbsd_fpregmap): Move earlier.
3531         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3532         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3533         instead of individual calls to trad_frame_set_reg_addr.
3534         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3535         earlier.
3536         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3537         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3538         instead of individual calls to trad_frame_set_reg_addr.
3539
3540 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3541
3542         * CONTRIBUTE: Replace contribution list with wiki link.
3543
3544 2019-01-25  Tom Tromey  <tom@tromey.com>
3545
3546         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3547
3548 2019-01-25  Tom Tromey  <tom@tromey.com>
3549
3550         * xtensa-linux-nat.c: Fix common/ includes.
3551         * xml-support.h: Fix common/ includes.
3552         * xml-support.c: Fix common/ includes.
3553         * x86-linux-nat.c: Fix common/ includes.
3554         * windows-nat.c: Fix common/ includes.
3555         * varobj.h: Fix common/ includes.
3556         * varobj.c: Fix common/ includes.
3557         * value.c: Fix common/ includes.
3558         * valops.c: Fix common/ includes.
3559         * utils.c: Fix common/ includes.
3560         * unittests/xml-utils-selftests.c: Fix common/ includes.
3561         * unittests/utils-selftests.c: Fix common/ includes.
3562         * unittests/unpack-selftests.c: Fix common/ includes.
3563         * unittests/tracepoint-selftests.c: Fix common/ includes.
3564         * unittests/style-selftests.c: Fix common/ includes.
3565         * unittests/string_view-selftests.c: Fix common/ includes.
3566         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3567         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3568         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3569         * unittests/rsp-low-selftests.c: Fix common/ includes.
3570         * unittests/parse-connection-spec-selftests.c: Fix common/
3571         includes.
3572         * unittests/optional-selftests.c: Fix common/ includes.
3573         * unittests/offset-type-selftests.c: Fix common/ includes.
3574         * unittests/observable-selftests.c: Fix common/ includes.
3575         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3576         * unittests/memrange-selftests.c: Fix common/ includes.
3577         * unittests/memory-map-selftests.c: Fix common/ includes.
3578         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3579         * unittests/function-view-selftests.c: Fix common/ includes.
3580         * unittests/environ-selftests.c: Fix common/ includes.
3581         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3582         * unittests/common-utils-selftests.c: Fix common/ includes.
3583         * unittests/cli-utils-selftests.c: Fix common/ includes.
3584         * unittests/array-view-selftests.c: Fix common/ includes.
3585         * ui-file.c: Fix common/ includes.
3586         * tui/tui-io.c: Fix common/ includes.
3587         * tracepoint.h: Fix common/ includes.
3588         * tracepoint.c: Fix common/ includes.
3589         * tracefile-tfile.c: Fix common/ includes.
3590         * top.h: Fix common/ includes.
3591         * top.c: Fix common/ includes.
3592         * thread.c: Fix common/ includes.
3593         * target/waitstatus.h: Fix common/ includes.
3594         * target/waitstatus.c: Fix common/ includes.
3595         * target.h: Fix common/ includes.
3596         * target.c: Fix common/ includes.
3597         * target-memory.c: Fix common/ includes.
3598         * target-descriptions.c: Fix common/ includes.
3599         * symtab.h: Fix common/ includes.
3600         * symfile.c: Fix common/ includes.
3601         * stap-probe.c: Fix common/ includes.
3602         * spu-linux-nat.c: Fix common/ includes.
3603         * sparc-nat.c: Fix common/ includes.
3604         * source.c: Fix common/ includes.
3605         * solib.c: Fix common/ includes.
3606         * solib-target.c: Fix common/ includes.
3607         * ser-unix.c: Fix common/ includes.
3608         * ser-tcp.c: Fix common/ includes.
3609         * ser-pipe.c: Fix common/ includes.
3610         * ser-base.c: Fix common/ includes.
3611         * selftest-arch.c: Fix common/ includes.
3612         * s12z-tdep.c: Fix common/ includes.
3613         * rust-exp.y: Fix common/ includes.
3614         * rs6000-aix-tdep.c: Fix common/ includes.
3615         * riscv-tdep.c: Fix common/ includes.
3616         * remote.c: Fix common/ includes.
3617         * remote-notif.h: Fix common/ includes.
3618         * remote-fileio.h: Fix common/ includes.
3619         * remote-fileio.c: Fix common/ includes.
3620         * regcache.h: Fix common/ includes.
3621         * regcache.c: Fix common/ includes.
3622         * record-btrace.c: Fix common/ includes.
3623         * python/python.c: Fix common/ includes.
3624         * python/py-type.c: Fix common/ includes.
3625         * python/py-inferior.c: Fix common/ includes.
3626         * progspace.h: Fix common/ includes.
3627         * producer.c: Fix common/ includes.
3628         * procfs.c: Fix common/ includes.
3629         * proc-api.c: Fix common/ includes.
3630         * printcmd.c: Fix common/ includes.
3631         * ppc-linux-nat.c: Fix common/ includes.
3632         * parser-defs.h: Fix common/ includes.
3633         * osdata.c: Fix common/ includes.
3634         * obsd-nat.c: Fix common/ includes.
3635         * nat/x86-linux.c: Fix common/ includes.
3636         * nat/x86-linux-dregs.c: Fix common/ includes.
3637         * nat/x86-dregs.h: Fix common/ includes.
3638         * nat/x86-dregs.c: Fix common/ includes.
3639         * nat/ppc-linux.c: Fix common/ includes.
3640         * nat/mips-linux-watch.h: Fix common/ includes.
3641         * nat/mips-linux-watch.c: Fix common/ includes.
3642         * nat/linux-waitpid.c: Fix common/ includes.
3643         * nat/linux-ptrace.h: Fix common/ includes.
3644         * nat/linux-ptrace.c: Fix common/ includes.
3645         * nat/linux-procfs.c: Fix common/ includes.
3646         * nat/linux-personality.c: Fix common/ includes.
3647         * nat/linux-osdata.c: Fix common/ includes.
3648         * nat/linux-namespaces.c: Fix common/ includes.
3649         * nat/linux-btrace.h: Fix common/ includes.
3650         * nat/linux-btrace.c: Fix common/ includes.
3651         * nat/fork-inferior.c: Fix common/ includes.
3652         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3653         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3654         * nat/aarch64-linux.c: Fix common/ includes.
3655         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3656         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3657         * namespace.h: Fix common/ includes.
3658         * mips-linux-tdep.c: Fix common/ includes.
3659         * minsyms.c: Fix common/ includes.
3660         * mi/mi-parse.h: Fix common/ includes.
3661         * mi/mi-main.c: Fix common/ includes.
3662         * mi/mi-cmd-env.c: Fix common/ includes.
3663         * memrange.h: Fix common/ includes.
3664         * memattr.c: Fix common/ includes.
3665         * maint.h: Fix common/ includes.
3666         * maint.c: Fix common/ includes.
3667         * main.c: Fix common/ includes.
3668         * machoread.c: Fix common/ includes.
3669         * location.c: Fix common/ includes.
3670         * linux-thread-db.c: Fix common/ includes.
3671         * linux-nat.c: Fix common/ includes.
3672         * linux-fork.c: Fix common/ includes.
3673         * inline-frame.c: Fix common/ includes.
3674         * infrun.c: Fix common/ includes.
3675         * inflow.c: Fix common/ includes.
3676         * inferior.h: Fix common/ includes.
3677         * inferior.c: Fix common/ includes.
3678         * infcmd.c: Fix common/ includes.
3679         * inf-ptrace.c: Fix common/ includes.
3680         * inf-child.c: Fix common/ includes.
3681         * ia64-linux-nat.c: Fix common/ includes.
3682         * i387-tdep.c: Fix common/ includes.
3683         * i386-tdep.c: Fix common/ includes.
3684         * i386-linux-tdep.c: Fix common/ includes.
3685         * i386-linux-nat.c: Fix common/ includes.
3686         * i386-go32-tdep.c: Fix common/ includes.
3687         * i386-fbsd-tdep.c: Fix common/ includes.
3688         * i386-fbsd-nat.c: Fix common/ includes.
3689         * guile/scm-type.c: Fix common/ includes.
3690         * guile/guile.c: Fix common/ includes.
3691         * go32-nat.c: Fix common/ includes.
3692         * gnu-nat.c: Fix common/ includes.
3693         * gdbthread.h: Fix common/ includes.
3694         * gdbarch-selftests.c: Fix common/ includes.
3695         * gdb_usleep.c: Fix common/ includes.
3696         * gdb_select.h: Fix common/ includes.
3697         * gdb_bfd.c: Fix common/ includes.
3698         * gcore.c: Fix common/ includes.
3699         * fork-child.c: Fix common/ includes.
3700         * findvar.c: Fix common/ includes.
3701         * fbsd-nat.c: Fix common/ includes.
3702         * event-top.c: Fix common/ includes.
3703         * event-loop.c: Fix common/ includes.
3704         * dwarf2read.c: Fix common/ includes.
3705         * dwarf2loc.c: Fix common/ includes.
3706         * dwarf2-frame.c: Fix common/ includes.
3707         * dwarf-index-cache.c: Fix common/ includes.
3708         * dtrace-probe.c: Fix common/ includes.
3709         * disasm-selftests.c: Fix common/ includes.
3710         * defs.h: Fix common/ includes.
3711         * csky-tdep.c: Fix common/ includes.
3712         * cp-valprint.c: Fix common/ includes.
3713         * cp-support.h: Fix common/ includes.
3714         * cp-support.c: Fix common/ includes.
3715         * corelow.c: Fix common/ includes.
3716         * completer.h: Fix common/ includes.
3717         * completer.c: Fix common/ includes.
3718         * compile/compile.c: Fix common/ includes.
3719         * compile/compile-loc2c.c: Fix common/ includes.
3720         * compile/compile-cplus-types.c: Fix common/ includes.
3721         * compile/compile-cplus-symbols.c: Fix common/ includes.
3722         * command.h: Fix common/ includes.
3723         * cli/cli-dump.c: Fix common/ includes.
3724         * cli/cli-cmds.c: Fix common/ includes.
3725         * charset.c: Fix common/ includes.
3726         * build-id.c: Fix common/ includes.
3727         * btrace.h: Fix common/ includes.
3728         * btrace.c: Fix common/ includes.
3729         * breakpoint.h: Fix common/ includes.
3730         * breakpoint.c: Fix common/ includes.
3731         * ax.h: 
3732         (enum agent_op): Fix common/ includes.
3733         * ax-general.c (struct aop_map): Fix common/ includes.
3734         * ax-gdb.c: Fix common/ includes.
3735         * auxv.c: Fix common/ includes.
3736         * auto-load.c: Fix common/ includes.
3737         * arm-tdep.c: Fix common/ includes.
3738         * arch/riscv.c: Fix common/ includes.
3739         * arch/ppc-linux-common.c: Fix common/ includes.
3740         * arch/i386.c: Fix common/ includes.
3741         * arch/arm.c: Fix common/ includes.
3742         * arch/arm-linux.c: Fix common/ includes.
3743         * arch/arm-get-next-pcs.c: Fix common/ includes.
3744         * arch/amd64.c: Fix common/ includes.
3745         * arch/aarch64.c: Fix common/ includes.
3746         * arch/aarch64-insn.c: Fix common/ includes.
3747         * arch-utils.c: Fix common/ includes.
3748         * amd64-windows-tdep.c: Fix common/ includes.
3749         * amd64-tdep.c: Fix common/ includes.
3750         * amd64-sol2-tdep.c: Fix common/ includes.
3751         * amd64-obsd-tdep.c: Fix common/ includes.
3752         * amd64-nbsd-tdep.c: Fix common/ includes.
3753         * amd64-linux-tdep.c: Fix common/ includes.
3754         * amd64-linux-nat.c: Fix common/ includes.
3755         * amd64-fbsd-tdep.c: Fix common/ includes.
3756         * amd64-fbsd-nat.c: Fix common/ includes.
3757         * amd64-dicos-tdep.c: Fix common/ includes.
3758         * amd64-darwin-tdep.c: Fix common/ includes.
3759         * agent.c: Fix common/ includes.
3760         * ada-lang.h: Fix common/ includes.
3761         * ada-lang.c: Fix common/ includes.
3762         * aarch64-tdep.c: Fix common/ includes.
3763
3764 2019-01-25  Tom Tromey  <tom@tromey.com>
3765
3766         * common/create-version.sh: Use common/version.h.
3767
3768 2019-01-24  Pedro Alves  <palves@redhat.com>
3769
3770         * infrun.c (signal_stop, signal_print, signal_program)
3771         (signal_catch, signal_pass): Now arrays instead of pointers.
3772         (update_signals_program_target, do_target_resume)
3773         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3774         * linux-nat.c (linux_nat_target::pass_signals)
3775         (linux_nat_target::create_inferior, linux_nat_target::attach):
3776         Adjust.
3777         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3778         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3779         * procfs.c (procfs_target::pass_signals): Adjust.
3780         * record-full.c (record_full_target::resume): Adjust.
3781         * remote.c (remote_target::pass_signals)
3782         (remote_target::program_signals): Adjust.
3783         * target-debug.h (target_debug_print_signals): Now takes a
3784         gdb::array_view as parameter.  Adjust.
3785         * target.h (target_ops) <pass_signals, program_signals>: Replace
3786         pointer and length parameters with gdb::array_view.
3787         (target_pass_signals, target_program_signals): Likewise.
3788         * target-delegates.c: Regenerate.
3789
3790 2019-01-24  Pedro Alves  <palves@redhat.com>
3791
3792         * common/forward-scope-exit.h
3793         (forward_scope_exit::forward_scope_exit): Pass arguments to
3794         m_bind_function directly, instead of creating a std::bind and
3795         copying that.
3796
3797 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3798
3799         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3800         for static members.
3801         (pass_in_v_vfp_candidate): Likewise.
3802
3803 2019-01-23  Tom Tromey  <tom@tromey.com>
3804             Pedro Alves  <palves@redhat.com>
3805
3806         * regcache.c (class regcache_invalidator): Remove.
3807         (regcache::raw_write): Use make_scope_exit.
3808
3809 2019-01-23  Tom Tromey  <tom@tromey.com>
3810
3811         * ui-out.h (class ui_out_emit_type): Update comment.
3812
3813 2019-01-23  Tom Tromey  <tom@tromey.com>
3814
3815         * infrun.c (fetch_inferior_event): Update comment.
3816
3817 2019-01-23  Tom Tromey  <tom@tromey.com>
3818             Pedro Alves  <palves@redhat.com>
3819
3820         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3821         parameter.
3822         (fetch_inferior_event): Use SCOPE_EXIT.
3823
3824
3825 2019-01-23  Tom Tromey  <tom@tromey.com>
3826             Pedro Alves  <palves@redhat.com>
3827
3828         * infrun.c (disable_thread_events): Delete.
3829         (stop_all_threads): Use SCOPE_EXIT.
3830
3831 2019-01-23  Tom Tromey  <tom@tromey.com>
3832             Pedro Alves  <palves@redhat.com>
3833
3834         * symfile.c: Include forward-scope-exit.h.
3835         (clear_symtab_users_cleanup): Replace forward declaration with
3836         a FORWARD_SCOPE_EXIT.
3837         (syms_from_objfile_1): Use the forward_scope_exit and
3838         gdb::optional instead of cleanup_function.
3839         (reread_symbols): Use the forward_scope_exit instead of
3840         cleanup_function.
3841         (clear_symtab_users_cleanup): Remove function.
3842
3843 2019-01-23  Tom Tromey  <tom@tromey.com>
3844             Pedro Alves  <palves@redhat.com>
3845
3846         * linux-nat.c: Include scope-exit.h.
3847         (cleanup_target_stop): Remove.
3848         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3849         SCOPE_EXIT.
3850
3851 2019-01-23  Tom Tromey  <tom@tromey.com>
3852             Pedro Alves  <palves@redhat.com>
3853
3854         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3855         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3856
3857 2019-01-23  Tom Tromey  <tom@tromey.com>
3858             Andrew Burgess  <andrew.burgess@embecosm.com>
3859             Pedro Alves  <palves@redhat.com>
3860
3861         * infrun.c (fetch_inferior_event): Use scope_exit.
3862         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3863         * top.c (execute_command): Use scope_exit.
3864         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3865         * utils.c (do_bpstat_clear_actions_cleanup)
3866         (make_bpstat_clear_actions_cleanup): Remove.
3867
3868 2019-01-23  Tom Tromey  <tom@tromey.com>
3869             Pedro Alves  <palves@redhat.com>
3870
3871         * infrun.c: Include "common/scope-exit.h"
3872         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3873         (wait_for_inferior): Use SCOPE_EXIT.
3874         (fetch_inferior_event): Use scope_exit.
3875
3876 2019-01-23  Tom Tromey  <tom@tromey.com>
3877             Pedro Alves  <palves@redhat.com>
3878
3879         * breakpoint.c (create_breakpoint): Remove cleanup.
3880
3881 2019-01-23  Tom Tromey  <tom@tromey.com>
3882             Andrew Burgess  <andrew.burgess@embecosm.com>
3883             Pedro Alves  <palves@redhat.com>
3884
3885 2019-01-23  Pedro Alves  <palves@redhat.com>
3886
3887         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3888
3889 2019-01-23  Pedro Alves  <palves@redhat.com>
3890             Andrew Burgess  <andrew.burgess@embecosm.com>
3891
3892         * gdbthread.h: Include "common/forward-scope-exit.h".
3893         (scoped_finish_thread_state): Redefine custom class in terms of
3894         forward_scope_exit.
3895
3896 2019-01-23  Pedro Alves  <palves@redhat.com>
3897             Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * common/forward-scope-exit.h: New file.
3900
3901 2019-01-23  Pedro Alves  <palves@redhat.com>
3902             Andrew Burgess  <andrew.burgess@embecosm.com>
3903             Tom Tromey  <tom@tromey.com>
3904
3905         * common/scope-exit.h: New file.
3906
3907 2019-01-23  Pedro Alves  <palves@redhat.com>
3908
3909         * common/preprocessor.h (ESC): Rename to ...
3910         (ESC_PARENS): ... this.
3911         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3912         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3913
3914 2019-01-23  Tom Tromey  <tom@tromey.com>
3915
3916         * language.h (class scoped_switch_to_sym_language_if_auto):
3917         Initialize m_lang in both cases.
3918
3919 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3920
3921         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3922         with XCNEW.
3923
3924 2019-01-22  Tom Tromey  <tom@tromey.com>
3925
3926         * corelow.c: Do not include sys/file.h.
3927
3928 2019-01-22  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-wingeneral.h: Include gdb_curses.h.
3931
3932 2019-01-22  Tom Tromey  <tom@tromey.com>
3933
3934         * source-cache.h (class source_cache) <get_source_lines,
3935         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3936
3937 2019-01-22  Tom Tromey  <tom@tromey.com>
3938
3939         * remote-fileio.h (struct remote_target): Declare.
3940
3941 2019-01-22  Tom Tromey  <tom@tromey.com>
3942
3943         * python/py-arch.c: Do not include py-ref.h.
3944         * python/py-bpevent.c: Do not include py-ref.h.
3945         * python/py-cmd.c: Do not include py-ref.h.
3946         * python/py-continueevent.c: Do not include py-ref.h.
3947         * python/py-event.h: Do not include py-ref.h.
3948         * python/py-evtregistry.c: Do not include py-ref.h.
3949         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3950         * python/py-frame.c: Do not include py-ref.h.
3951         * python/py-framefilter.c: Do not include py-ref.h.
3952         * python/py-function.c: Do not include py-ref.h.
3953         * python/py-infevents.c: Do not include py-ref.h.
3954         * python/py-linetable.c: Do not include py-ref.h.
3955         * python/py-objfile.c: Do not include py-ref.h.
3956         * python/py-param.c: Do not include py-ref.h.
3957         * python/py-prettyprint.c: Do not include py-ref.h.
3958         * python/py-progspace.c: Do not include py-ref.h.
3959         * python/py-symbol.c: Do not include py-ref.h.
3960         * python/py-symtab.c: Do not include py-ref.h.
3961         * python/py-type.c: Do not include py-ref.h.
3962         * python/py-unwind.c: Do not include py-ref.h.
3963         * python/py-utils.c: Do not include py-ref.h.
3964         * python/py-value.c: Do not include py-ref.h.
3965         * python/py-varobj.c: Do not include py-ref.h.
3966         * python/py-xmethods.c: Do not include py-ref.h.
3967         * python/python.c: Do not include py-ref.h.
3968         * varobj.c: Do not include py-ref.h.
3969
3970 2019-01-22  Tom Tromey  <tom@tromey.com>
3971
3972         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3973         keyword for bcache.
3974
3975 2019-01-22  Tom Tromey  <tom@tromey.com>
3976
3977         * compile/compile-cplus-types.c: Remove a comment by #include.
3978
3979 2019-01-22  Tom Tromey  <tom@tromey.com>
3980
3981         * compile/gcc-c-plugin.h: Include compile-internal.h.
3982
3983 2019-01-22  Tom Tromey  <tom@tromey.com>
3984
3985         * stabsread.c (EXTERN): Do not define.
3986         (symnum, next_symbol_text_func, processing_gcc_compilation)
3987         (within_function, global_sym_chain, global_stabs)
3988         (previous_stab_code, this_object_header_files)
3989         (n_this_object_header_files)
3990         (n_allocated_this_object_header_files): Define.
3991         * stabsread.h (EXTERN): Never define.  Use "extern".
3992
3993 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3994
3995         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3996         history_value.
3997
3998 2019-01-21  Tom Tromey  <tom@tromey.com>
3999
4000         * ui-out.c: Fix includes.
4001         * tui/tui-source.c: Fix includes.
4002         * target.c: Fix includes.
4003         * remote.c: Fix includes.
4004         * regcache.c: Fix includes.
4005         * python/py-block.c: Fix includes.
4006         * printcmd.c: Fix includes.
4007         * or1k-tdep.c: Fix includes.
4008         * mi/mi-main.c: Fix includes.
4009         * m32r-tdep.c: Fix includes.
4010         * csky-tdep.c: Fix includes.
4011         * compile/compile-cplus-types.c: Fix includes.
4012         * cli/cli-interp.c: Fix includes.
4013
4014 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4015
4016         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4017         for padding.
4018
4019 2019-01-16  Tom Tromey  <tom@tromey.com>
4020
4021         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4022         earlier.
4023         (struct objfile) <msymbols_range>: Move from top level.
4024         <msymbols>: New method.
4025         (class objfile_msymbols): Remove.
4026         * symtab.c (default_collect_symbol_completion_matches_break_on):
4027         Update.
4028         * symmisc.c (dump_msymbols): Update.
4029         * stabsread.c (scan_file_globals): Update.
4030         * objc-lang.c (info_selectors_command, info_classes_command)
4031         (find_methods): Update.
4032         * minsyms.c (find_solib_trampoline_target): Update.
4033         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4034         * coffread.c (coff_symfile_read): Update.
4035         * ada-lang.c (ada_lookup_simple_minsym)
4036         (ada_collect_symbol_completion_matches): Update.
4037
4038 2019-01-16  Tom Tromey  <tom@tromey.com>
4039
4040         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4041         type.  Remove no-argument constructor.
4042         <iterator::operator++>: Simplify.
4043         <begin>: Update.
4044         <end>: Use minimal_symbol_count.
4045
4046 2019-01-16  Tom Tromey  <tom@tromey.com>
4047
4048         * objfiles.h (struct objfile) <psymtabs>: New method.
4049         (class objfile_psymtabs): Remove.
4050         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4051         typedef.
4052         <range>: New method.
4053         (require_partial_symbols): Change return type.
4054         * psymtab.c (require_partial_symbols)
4055         (psym_expand_symtabs_matching): Update.
4056         * mdebugread.c (parse_partial_symbols): Update.
4057         * dbxread.c (dbx_end_psymtab): Update.
4058
4059 2019-01-15  Tom Tromey  <tom@tromey.com>
4060
4061         * symtab.c (lookup_objfile_from_block)
4062         (lookup_symbol_in_objfile_symtabs)
4063         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4064         (find_line_symtab, info_sources_command)
4065         (default_collect_symbol_completion_matches_break_on)
4066         (make_source_files_completion_list): Update.
4067         * symmisc.c (print_objfile_statistics, dump_objfile)
4068         (maintenance_print_symbols, maintenance_info_symtabs)
4069         (maintenance_check_symtabs, maintenance_info_line_tables):
4070         Update.
4071         * source.c (select_source_symtab)
4072         (forget_cached_source_info_for_objfile): Update.
4073         * objfiles.h (class objfile_compunits): Remove.
4074         (struct objfile) <compunits_range>: New typedef.
4075         (compunits): New method.
4076         * objfiles.c (objfile_relocate1): Update.
4077         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4078         * maint.c (count_symtabs_and_blocks): Update.
4079         * linespec.c (iterate_over_all_matching_symtabs): Update.
4080         * cp-support.c (add_symbol_overload_list_qualified): Update.
4081         * coffread.c (coff_symtab_read): Update.
4082         * ada-lang.c (add_nonlocal_symbols)
4083         (ada_collect_symbol_completion_matches)
4084         (ada_add_global_exceptions): Update.
4085
4086 2019-01-15  Tom Tromey  <tom@tromey.com>
4087
4088         * progspace.h (program_space) <objfiles_safe_range>: New
4089         typedef.
4090         <objfiles_safe>: New method.
4091         * objfiles.h (class all_objfiles_safe): Remove.
4092         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4093         * jit.c (jit_inferior_exit_hook): Update.
4094
4095 2019-01-17  Tom Tromey  <tom@tromey.com>
4096
4097         * progspace.h (program_space) <objfiles_range>: New typedef.
4098         <objfiles>: New method.
4099         <objfiles_head>: Rename from objfiles.
4100         (object_files): Update.
4101         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4102         * guile/scm-pretty-print.c
4103         (ppscm_find_pretty_printer_from_objfiles): Update.
4104         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4105         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4106         Update.
4107         * python/py-progspace.c (pspy_get_objfiles): Update.
4108         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4109         Update.
4110         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4111         (objfpy_lookup_objfile_by_build_id): Update.
4112         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4113         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4114         Update.
4115         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4116         (expand_symtab_containing_pc, lookup_objfile_from_block)
4117         (lookup_static_symbol, basic_lookup_transparent_type)
4118         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4119         (find_line_symtab, info_sources_command)
4120         (default_collect_symbol_completion_matches_break_on)
4121         (make_source_files_completion_list, find_main_name): Update.
4122         * symmisc.c (print_symbol_bcache_statistics)
4123         (print_objfile_statistics, maintenance_print_symbols)
4124         (maintenance_print_msymbols, maintenance_print_objfiles)
4125         (maintenance_info_symtabs, maintenance_check_symtabs)
4126         (maintenance_expand_symtabs, maintenance_info_line_tables):
4127         Update.
4128         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4129         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4130         (map_overlay_command, unmap_overlay_command)
4131         (simple_overlay_update, expand_symtabs_matching)
4132         (map_symbol_filenames): Update.
4133         * symfile-debug.c (set_debug_symfile): Update.
4134         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4135         Update.
4136         * source.c (select_source_symtab, forget_cached_source_info):
4137         Update.
4138         * solib.c (solib_read_symbols): Update.
4139         * solib-spu.c (append_ocl_sos): Update.
4140         * psymtab.c (maintenance_print_psymbols)
4141         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4142         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4143         * printcmd.c (info_symbol_command): Update.
4144         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4145         Update.
4146         * objfiles.h (class all_objfiles): Remove.
4147         * objfiles.c (have_partial_symbols, have_full_symbols)
4148         (have_minimal_symbols, qsort_cmp, update_section_map)
4149         (shared_objfile_contains_address_p)
4150         (default_iterate_over_objfiles_in_search_order): Update.
4151         * objc-lang.c (info_selectors_command, info_classes_command)
4152         (find_methods): Update.
4153         * minsyms.c (find_solib_trampoline_target): Update.
4154         * maint.c (maintenance_info_sections)
4155         (maintenance_translate_address, count_symtabs_and_blocks):
4156         Update.
4157         * main.c (captured_main_1): Update.
4158         * linux-thread-db.c (try_thread_db_load_from_pdir)
4159         (has_libpthread): Update.
4160         * linespec.c (iterate_over_all_matching_symtabs)
4161         (search_minsyms_for_name): Update.
4162         * jit.c (jit_find_objf_with_entry_addr): Update.
4163         * hppa-tdep.c (find_unwind_entry)
4164         (hppa_lookup_stub_minimal_symbol): Update.
4165         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4166         Update.
4167         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4168         (elf_gnu_ifunc_resolve_by_got): Update.
4169         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4170         * dwarf-index-write.c (save_gdb_index_command): Update.
4171         * cp-support.c (add_symbol_overload_list_qualified): Update.
4172         * breakpoint.c (create_overlay_event_breakpoint)
4173         (create_longjmp_master_breakpoint)
4174         (create_std_terminate_master_breakpoint)
4175         (create_exception_master_breakpoint): Update.
4176         * blockframe.c (find_pc_partial_function): Update.
4177         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4178         (ada_collect_symbol_completion_matches)
4179         (ada_add_global_exceptions): Update.
4180
4181 2019-01-17  Tom Tromey  <tom@tromey.com>
4182
4183         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4184         declare VEC.
4185         (solib_target_parse_libraries): Change return type.
4186         (library_list_start_segment, library_list_start_section)
4187         (library_list_end_library, library_list_start_library); Update.
4188         (solib_target_free_library_list): Remove.
4189         (solib_target_parse_libraries): Remove cleanup.  Change return
4190         type.
4191         (solib_target_current_sos): Update.
4192
4193 2019-01-17  Tom Tromey  <tromey@bapiya>
4194
4195         * valprint.c: Replace "the the" with "the".
4196         * symtab.c: Replace "the the" with "the".
4197         * solib.c: Replace "the the" with "the".
4198         * solib-dsbt.c: Replace "the the" with "the".
4199         * linespec.c: Replace "the the" with "the".
4200         * dwarf2loc.h: Replace "the the" with "the".
4201         * amd64-windows-tdep.c: Replace "the the" with "the".
4202         * aarch64-tdep.c: Replace "the the" with "the".
4203
4204 2019-01-16  Keith Seitz  <keiths@redhat.com>
4205
4206         PR gdb/23773
4207         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4208         <builder>: Rename to ..
4209         <m_builder>: ... this and make private.
4210         (dwarf2_cu::get_builder): New method.  Change all users of
4211         `builder' to use this method.
4212         (dwarf2_start_symtab): Move to ...
4213         (dwarf2_cu::start_symtab): ... here.  Update all callers
4214         (setup_type_unit_groups): Move to ...
4215         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4216         callers.
4217         (dwarf2_cu::reset_builder): New method.
4218         (process_full_compunit, process_full_type_unit): Use
4219         dwarf2_cu::reset_builder.
4220         (follow_die_offset): Record the ancestor CU if it is different
4221         from the followed DIE's CU.
4222         (follow_die_sig_1): Likewise.
4223
4224 2019-01-15  Tom Tromey  <tom@tromey.com>
4225
4226         * remote.c (class remote_state) <buf>: Now a char_vector.
4227         <buf_size>: Remove.
4228         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4229         parameter.
4230         (remote_target::getpkt_or_notif_sane_1)
4231         (remote_target::getpkt_sane)
4232         (remote_target::getpkt_or_notif_sane): Likewise.
4233         (class remote_target) <putpkt>: New overload.
4234         (remote_target::read_frame): Change type of "buf_p".  Remove
4235         sizeof_p parameter.
4236         (packet_ok): New overload.
4237         (packet_check_result): New overload.
4238         Update all uses.
4239
4240 2019-01-14  Tom Tromey  <tom@tromey.com>
4241
4242         * remote-notif.c (handle_notification, remote_notif_ack)
4243         (remote_notif_parse): Make "buf" const.
4244         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4245         const.
4246         (remote_notif_parse, remote_notif_ack, handle_notification):
4247         Likewise.
4248         * remote.c (remote_notif_stop_parse): Make "buf" const.
4249         (remote_target::remote_parse_stop_reply): Make "buf" const.
4250         (remote_notif_stop_ack): Make "buf" const.
4251
4252 2019-01-14  Tom Tromey  <tom@tromey.com>
4253
4254         * remote.c (remote_console_output): Make parameter const.
4255
4256 2019-01-14  Tom Tromey  <tom@tromey.com>
4257
4258         * target-debug.h (target_debug_print_signals): Constify.
4259         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4260         * procfs.c (procfs_target::pass_signals): Update.
4261         * linux-nat.c (linux_nat_target::pass_signals): Update.
4262         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4263         * target-delegates.c: Rebuild.
4264         * remote.c (remote_target::program_signals): Update.
4265         (remote_target::pass_signals): Update.
4266         * target.c (target_pass_signals): Constify argument.
4267         (target_program_signals): Likewise.
4268         * target.h (struct target_ops) <pass_signals, program_signals>:
4269         Constify argument.
4270         (target_pass_signals, target_program_signals): Constify argument.
4271
4272 2019-01-14  Tom Tromey  <tom@tromey.com>
4273
4274         PR tui/28819:
4275         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4276
4277 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4278
4279         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4280         field.
4281         * rs6000-tdep.c: Include reggroups.h.
4282         (IS_V_ALIAS_PSEUDOREG): Define.
4283         (rs6000_register_name): Return names for the "vX" aliases.
4284         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4285         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4286         aliases.  Call default_register_reggroup_p for all other
4287         pseudo-registers.
4288         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4289         New functions.
4290         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4291         Handle "vX" aliases.
4292         (v_alias_pseudo_register_collect): New function.
4293         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4294         (rs6000_gdbarch_init): Initialize "vX" aliases as
4295         pseudo-registers.  Restore registration of
4296         rs6000_pseudo_register_reggroup_p with
4297         set_tdesc_pseudo_register_reggroup_p.
4298
4299 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4300
4301         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4302         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4303         set_gdbarch_num_pseudo_regs.
4304
4305 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4306
4307         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4308         Remove arg prefixname, add do_set and do_show.
4309         Add member functions set_list and show_list.
4310         * cli/cli-style.c (class cli_style_option): Update accordingly.
4311         (style_set_list): Move to file scope.
4312         (style_show_list): Likewise.
4313         (set_style): Call help_list.
4314         (show_style): Call cmd_show_list.
4315         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4316         Update to use the new macro.
4317
4318 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4319
4320         * ada-lang.c (_initialize_ada_language): Expand the help text
4321         for the "catch exception" command.
4322
4323 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4324
4325         * symtab.c (matching_obj_sections): Initialize obj,
4326         declare it closer to its usage.
4327
4328 2019-01-10  Tom Tromey  <tom@tromey.com>
4329
4330         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4331         (basic_inf_threads_range): Remove.
4332         (inf_threads_range, inf_non_exited_threads_range)
4333         (safe_inf_threads_range): Use next_adapter.
4334
4335 2019-01-10  Keith Seitz  <keiths@redhat.com>
4336
4337         PR gdb/23712
4338         PR symtab/23010
4339         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4340         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4341
4342 2019-01-10  Keith Seitz  <keiths@redhat.com>
4343
4344         PR gdb/23712
4345         PR symtab/23010
4346         * dictionary.c (pending_to_vector): Remove.
4347         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4348         Remove _1 suffix, replacing functions of the same name.  Update
4349         all callers.
4350         (dict_create_hashed, dict_create_hashed_expandable)
4351         (dict_create_linear, dict_create_linear_expandable, dict_free)
4352         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4353         Make functions static.
4354
4355 2019-01-10  Keith Seitz  <keiths@redhat.com>
4356
4357         PR gdb/23712
4358         PR symtab/23010
4359         * dictionary.h (struct dictionary): Replace declaration with
4360         multidictionary.
4361         (dict_create_hashed, dict_create_hashed_expandable)
4362         (dict_create_linear, dict_create_linear_expandable)
4363         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4364         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4365         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4366         taking multidictionary argument.
4367         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4368         * block.h (struct block) <dict>: Change to multidictionary
4369         and rename `multidict'.
4370         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4371         symmisc.c: Update all dictionary references to multidictionary.
4372
4373 2019-01-10  Keith Seitz  <keiths@redhat.com>
4374
4375         PR gdb/23712
4376         PR symtab/23010
4377         * dictionary.c: Include unordered_map.
4378         (pending_to_vector): New function.
4379         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4380         Rewrite the non-"_1" functions to take vector instead
4381         of linked list.
4382         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4383         "new" _1 versions of the same name.
4384         (multidictionary): Define.
4385         (std::hash<enum language): New definition.
4386         (collate_pending_symbols_by_language, mdict_create_hashed)
4387         (mdict_create_hashed_expandable, mdict_create_linear)
4388         (mdict_create_linear_expandable, mdict_free)
4389         (find_language_dictionary, create_new_language_dictionary)
4390         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4391         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4392         (mdict_size, mdict_empty): New functions.
4393         * dictionary.h (mdict_iterator): Define.
4394
4395 2019-01-10  Pedro Alves  <palves@redhat.com>
4396
4397         * breakpoint.c (read_uploaded_action)
4398         (create_tracepoint_from_upload): Adjust to use
4399         gdb::unique_xmalloc_ptr.
4400         * ctf.c (ctf_write_uploaded_tp):
4401         (SET_ARRAY_FIELD): Use emplace_back.
4402         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4403         * tracefile-tfile.c (tfile_write_uploaded_tp):
4404         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4405         gdb::unique_xmalloc_ptr.
4406         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4407         at_string, cond_string, cmd_strings>: Replace char pointers
4408         with gdb::unique_xmalloc_ptr.
4409
4410 2019-01-10  Pedro Alves  <palves@redhat.com>
4411
4412         * solib-target.c (library_list_start_library): Don't xstrdup name.
4413
4414 2019-01-10  Pedro Alves  <palves@redhat.com>
4415
4416         * mdebugread.c (parse_partial_symbols): Use
4417         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4418
4419 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * linux-fork.c (scoped_switch_fork_info)
4422         <~scoped_switch_fork_info>: Fix incorrect variable name.
4423
4424 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * linux-fork.c (scoped_switch_fork_info)
4427         <scoped_switch_fork_info>: Make explicit.
4428         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4429
4430 2019-01-10  Tom Tromey  <tom@tromey.com>
4431
4432         * objfiles.h (objfile::reset_psymtabs): Update.
4433         * objfiles.c (objfile::objfile): Update.
4434         * psymtab.h (psymtab_storage::obstack): Update.
4435         (psymtab_storage::m_obstack): Use gdb::optional.
4436         (class psymtab_storage): Update comment.  Remove objfile
4437         parameter.
4438         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4439
4440 2019-01-10  Tom Tromey  <tom@tromey.com>
4441
4442         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4443         <free_psymtabs>: Now private.
4444         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4445         (allocate_psymtab): Use new method.
4446
4447 2019-01-10  Tom Tromey  <tom@tromey.com>
4448
4449         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4450         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4451         * mdebugread.c (parse_partial_symbols): Use
4452         allocate_dependencies.
4453         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4454         allocate_dependencies.
4455         (process_psymtab_comp_unit_reader)
4456         (build_type_psymtab_dependencies): Likewise.
4457         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4458
4459 2019-01-10  Tom Tromey  <tom@tromey.com>
4460
4461         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4462         PSYMBOL_SET_LANGUAGE.
4463         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4464
4465 2019-01-10  Tom Tromey  <tom@tromey.com>
4466
4467         * psymtab.h (psymtab_storage::obstack): New method.
4468         <m_obstack>: Rename from obstack; now private.
4469         * psymtab.c (psymtab_storage): Update.
4470         * dwarf2read.c (create_addrmap_from_index)
4471         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4472         Update.
4473
4474 2019-01-10  Tom Tromey  <tom@tromey.com>
4475
4476         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4477         * objfiles.h (objfile::reset_psymtabs): New method.
4478
4479 2019-01-10  Tom Tromey  <tom@tromey.com>
4480
4481         * symmisc.c (print_symbol_bcache_statistics): Update.
4482         (print_objfile_statistics): Update.
4483         * symfile.c (reread_symbols): Update.
4484         * psymtab.h (class psymtab_storage): New.
4485         * psymtab.c (psymtab_storage): New constructor.
4486         (~psymtab_storage): New destructor.
4487         (require_partial_symbols): Update.
4488         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4489         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4490         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4491         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4492         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4493         (start_psymtab_common, end_psymtab_common)
4494         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4495         (allocate_psymtab): Update.
4496         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4497         Update.
4498         (dump_psymtab_addrmap, maintenance_print_psymbols)
4499         (maintenance_check_psymtabs): Update.
4500         (class objfile_psymtabs): Move to objfiles.h.
4501         * psympriv.h (discard_psymtab): Now inline.
4502         (psymtab_discarder::psymtab_discarder): Update.
4503         (psymtab_discarder::~psymtab_discarder): Update.
4504         (ALL_OBJFILE_PSYMTABS): Rewrite.
4505         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4506         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4507         Remove fields.
4508         <partial_symtabs>: New field.
4509         (class objfile_psymtabs): Move from psymtab.h.  Update.
4510         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4511         psymbol_cache.
4512         (objfile::~objfile): Don't destroy psymbol_cache.
4513         * mdebugread.c (parse_partial_symbols): Update.
4514         * dwarf2read.c (create_addrmap_from_index)
4515         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4516         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4517         (add_partial_subprogram, dwarf2_ranges_read): Update.
4518         * dwarf-index-write.c (write_address_map)
4519         (write_one_signatured_type, recursively_write_psymbols)
4520         (class debug_names, class debug_names, write_psymtabs_to_index):
4521         Update.
4522
4523 2019-01-10  Tom Tromey  <tom@tromey.com>
4524
4525         * symtab.h (SYMBOL_SET_NAMES): Update.
4526         (symbol_set_names): Update.
4527         (MSYMBOL_SET_NAMES): Update.
4528         * symtab.c (symbol_set_names): Change argument to be an
4529         objfile_per_bfd_storage.
4530         * psymtab.c (add_psymbol_to_bcache): Update.
4531         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4532
4533 2019-01-10  Tom Tromey  <tom@tromey.com>
4534
4535         * symtab.c (create_demangled_names_hash): Change argument to be an
4536         objfile_per_bfd_storage.
4537         (symbol_set_names): Update.
4538
4539 2019-01-10  Tom Tromey  <tom@tromey.com>
4540
4541         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4542         init_psymbol_list.
4543         * psymtab.c (init_psymbol_list): Do nothing if already called.
4544         * psympriv.h (init_psymbol_list): Add comment.
4545         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4546         init_psymbol_list.
4547         * dbxread.c (dbx_symfile_read): Unconditionally call
4548         init_psymbol_list.
4549
4550 2019-01-10  Tom Tromey  <tom@tromey.com>
4551
4552         * xcoffread.c (scan_xcoff_symtab): Update.
4553         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4554         "where".
4555         * mdebugread.c (parse_partial_symbols)
4556         (handle_psymbol_enumerators): Update.
4557         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4558         * dbxread.c (read_dbx_symtab): Update.
4559         * psympriv.h (psymbol_placement): New enum.
4560         (add_psymbol_to_list): Update.
4561
4562 2019-01-10  Tom Tromey  <tom@tromey.com>
4563
4564         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4565         static_psymbols parameters.
4566         (scan_xcoff_symtab): Update.
4567         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4568         static_psymbols parameters.
4569         * psympriv.h (start_psymtab_common): Update.
4570         * mdebugread.c (parse_partial_symbols): Update.
4571         * dwarf2read.c (create_partial_symtab): Update.
4572         * dbxread.c (read_dbx_symtab): Update.
4573         (start_psymtab): Remove global_psymbols and static_psymbols
4574         parameters.
4575
4576 2019-01-10  Tom Tromey  <tom@tromey.com>
4577
4578         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4579         * psymtab.c (allocate_psymtab): Add comment.
4580         * psympriv.h (allocate_psymtab): Add comment.
4581         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4582         initializations.
4583         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4584
4585 2019-01-10  Tom Tromey  <tom@tromey.com>
4586
4587         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4588         Don't declare.
4589         * mipsread.c: Include mdebugread.h.
4590         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4591         Declare.
4592         * elfread.c: Include mdebugread.h.
4593
4594 2019-01-09  Tom Tromey  <tom@tromey.com>
4595
4596         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4597         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4598         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4599         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4600         (psym_lookup_symbol, psym_find_last_source_symtab)
4601         (psym_forget_cached_source_info, psym_print_stats)
4602         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4603         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4604         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4605         (psym_find_compunit_symtab_by_address)
4606         (maintenance_print_psymbols, maintenance_info_psymtabs)
4607         (maintenance_check_psymtabs): Use ranged for.
4608         * psymtab.h (class objfile_psymtabs): New.
4609         (require_partial_symbols): Return objfile_psymtabs.
4610         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4611
4612 2019-01-09  Tom Tromey  <tom@tromey.com>
4613
4614         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4615         (find_pc_mapped_section, list_overlays_command)
4616         (map_overlay_command, unmap_overlay_command)
4617         (simple_overlay_update): Use all_objfiles.
4618         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4619         * printcmd.c (info_symbol_command): Use all_objfiles.
4620         * objfiles.h (ALL_OBJSECTIONS): Remove.
4621         * maint.c (maintenance_translate_address): Use all_objfiles.
4622         * gcore.c (gcore_create_callback): Use all_objfiles.
4623         (objfile_find_memory_regions): Likewise.
4624
4625 2019-01-09  Tom Tromey  <tom@tromey.com>
4626
4627         * symtab.c (find_line_symtab, info_sources_command)
4628         (make_source_files_completion_list): Use objfile_compunits.
4629         * source.c (select_source_symtab): Use objfile_compunits.
4630         * objfiles.h (struct objfile): Update comment.
4631         (ALL_OBJFILES): Remove.
4632         (ALL_FILETABS): Remove.
4633         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4634         objfile_compunits.
4635
4636 2019-01-09  Tom Tromey  <tom@tromey.com>
4637
4638         * symmisc.c (print_objfile_statistics, dump_objfile)
4639         (maintenance_print_symbols): Use compunit_filetabs.
4640         * source.c (forget_cached_source_info_for_objfile): Use
4641         compunit_filetabs.
4642         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4643         (ALL_FILETABS): Use compunit_filetabs.
4644         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4645         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4646
4647 2019-01-09  Tom Tromey  <tom@tromey.com>
4648
4649         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4650         (compunit_filetabs): New.
4651         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4652         compunit_filetabs.
4653         (info_sources_command, make_source_files_completion_list): Remove
4654         declaration.
4655         * symmisc.c (print_objfile_statistics, dump_objfile)
4656         (maintenance_print_symbols): Remove declaration.
4657         (maintenance_info_symtabs): Use compunit_filetabs.
4658         (maintenance_info_line_tables): Likewise.
4659         * source.c (select_source_symtab): Change local variable name.
4660         (forget_cached_source_info_for_objfile): Remove declaration.
4661         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4662         * objfiles.c (objfile_relocate1): Remove declaration.
4663         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4664         declaration.
4665         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4666         * coffread.c (coff_symtab_read): Remove declaration.
4667         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4668         compunit_filetabs.
4669
4670 2019-01-09  Tom Tromey  <tom@tromey.com>
4671
4672         * symtab.c (lookup_objfile_from_block)
4673         (find_pc_sect_compunit_symtab, search_symbols)
4674         (default_collect_symbol_completion_matches_break_on): Use
4675         objfile_compunits.
4676         * objfiles.h (ALL_COMPUNITS): Remove.
4677         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4678         * cp-support.c (add_symbol_overload_list_qualified): Use
4679         objfile_compunits.
4680         * ada-lang.c (ada_collect_symbol_completion_matches)
4681         (ada_add_global_exceptions): Use objfile_compunits.
4682
4683 2019-01-09  Tom Tromey  <tom@tromey.com>
4684
4685         * source.c (select_source_symtab)
4686         (forget_cached_source_info_for_objfile): Remove declaration.
4687         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4688         declaration.
4689         * maint.c (count_symtabs_and_blocks): Remove declaration.
4690         * cp-support.c (add_symbol_overload_list_qualified): Remove
4691         declaration.
4692         * coffread.c (coff_symtab_read): Remove declaration.
4693         * symtab.c (lookup_symbol_in_objfile_symtabs)
4694         (basic_lookup_transparent_type_1): Use objfile_compunits.
4695         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4696         (info_sources_command, search_symbols)
4697         (default_collect_symbol_completion_matches_break_on)
4698         (make_source_files_completion_list): Remove declaration.
4699         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4700         (ada_collect_symbol_completion_matches)
4701         (ada_add_global_exceptions): Remove declaration.
4702         * linespec.c (iterate_over_all_matching_symtabs): Use
4703         objfile_compunits.
4704         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4705         (class objfile_compunits): New.
4706         (ALL_COMPUNITS): Use objfile_compunits.
4707         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4708         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4709         objfile_compunits.
4710         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4711
4712 2019-01-09  Tom Tromey  <tom@tromey.com>
4713
4714         * symtab.c (search_symbols)
4715         (default_collect_symbol_completion_matches_break_on): Use
4716         objfile_msymbols.
4717         * ada-lang.c (ada_lookup_simple_minsym)
4718         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4719         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4720         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4721         objfile_msymbols.
4722         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4723         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4724         * objc-lang.c (find_methods): Use objfile_msymbols.
4725         (info_selectors_command, info_classes_command): Likewise.
4726         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4727         * objfiles.h (class objfile_msymbols): New.
4728         (ALL_OBJFILE_MSYMBOLS): Remove.
4729         (ALL_MSYMBOLS): Remove.
4730
4731 2019-01-09  Tom Tromey  <tom@tromey.com>
4732
4733         * common/next-iterator.h (next_adapter): Add Iterator template
4734         parameter.
4735         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4736         (class all_objfiles_safe): New.
4737         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4738         * objfiles.c (put_objfile_before): Update comment.
4739         (add_separate_debug_objfile): Likewise.
4740         (free_all_objfiles): Use all_objfiles_safe.
4741         (objfile_purge_solibs): Likewise.
4742
4743 2019-01-09  Tom Tromey  <tom@tromey.com>
4744
4745         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4746         (expand_symtab_containing_pc, lookup_static_symbol)
4747         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4748         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4749         all_objfiles.
4750         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4751         * breakpoint.c (create_overlay_event_breakpoint)
4752         (create_longjmp_master_breakpoint)
4753         (create_std_terminate_master_breakpoint)
4754         (create_exception_master_breakpoint): Use all_objfiles.
4755         * linux-thread-db.c (try_thread_db_load_from_pdir)
4756         (has_libpthread): Use all_objfiles.
4757         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4758         * linespec.c (iterate_over_all_matching_symtabs)
4759         (search_minsyms_for_name): Use all_objfiles.
4760         * maint.c (maintenance_info_sections): Use all_objfiles.
4761         * main.c (captured_main_1): Use all_objfiles.
4762         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4763         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4764         * guile/scm-pretty-print.c
4765         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4766         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4767         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4768         (maintenance_print_msymbols): Use all_objfiles.
4769         * source.c (select_source_symtab): Use all_objfiles.
4770         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4771         * symfile.c (remove_symbol_file_command)
4772         (expand_symtabs_matching, map_symbol_filenames): Use
4773         all_objfiles.
4774         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4775         all_objfiles.
4776         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4777         * objc-lang.c (find_methods): Use all_objfiles.
4778         * objfiles.c (have_partial_symbols, have_full_symbols)
4779         (have_minimal_symbols, qsort_cmp)
4780         (default_iterate_over_objfiles_in_search_order): Use
4781         all_objfiles.
4782         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4783         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4784         (maintenance_check_psymtabs): Use all_objfiles.
4785         (ALL_PSYMTABS): Remove.
4786         * compile/compile-object-run.c (do_module_cleanup): Use
4787         all_objfiles.
4788         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4789         * cp-support.c (add_symbol_overload_list_qualified): Use
4790         all_objfiles.
4791         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4792         Use all_objfiles.
4793         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4794         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4795         all_objfiles.
4796         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4797         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4798         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4799         Uses all_objfiles.
4800         * solib.c (solib_read_symbols): Use all_objfiles
4801
4802 2019-01-09  Tom Tromey  <tom@tromey.com>
4803
4804         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4805         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4806         all_objfiles.
4807         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4808         * symmisc.c (print_symbol_bcache_statistics)
4809         (print_objfile_statistics, maintenance_print_objfiles)
4810         (maintenance_info_symtabs, maintenance_check_symtabs)
4811         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4812         all_objfiles.
4813         * source.c (forget_cached_source_info): Use all_objfiles.
4814         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4815         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4816         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4817         * objfiles.c (update_section_map): Use all_objfiles.
4818         (shared_objfile_contains_address_p): Likewise.
4819         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4820         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4821
4822 2019-01-09  Tom Tromey  <tom@tromey.com>
4823
4824         * common/next-iterator.h: New file.
4825         * objfiles.h (class all_objfiles): New.
4826         (struct objfile_iterator): New.
4827
4828 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4829
4830         * NEWS: Move the description of the changed "frame", "select-frame",
4831          and "info frame" commands to the Changed commands section.
4832
4833 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4834
4835         * gdbtypes.c (check_stub_method_group): Remove handling of old
4836         mangling schemes.
4837         * linespec.c (find_methods): Likewise.
4838         * stabsread.c (read_member_functions): Likewise.
4839         * valops.c (search_struct_method): Likewise.
4840         (value_struct_elt_for_reference): Likewise.
4841         * NEWS: Mention this change.
4842
4843 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4846         print_source_lines.
4847         * source.c (print_source_lines_base): Update line number check.
4848         (print_source_lines): New function.
4849         (source_lines_range::source_lines_range): New function.
4850         * source.h (class source_lines_range): New class.
4851         (print_source_lines): New declaration.
4852
4853 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4854
4855         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4856
4857 2019-01-08  Tom Tromey  <tom@tromey.com>
4858             Simon Marchi  <simon.marchi@ericsson.com>
4859
4860         PR gdb/24060
4861         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4862         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4863         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4864         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4865         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4866         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4867
4868 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * source.c (select_source_symtab): Move header comment to
4871         declaration in source.h.
4872         (forget_cached_source_info_for_objfile): Likewise.
4873         (forget_cached_source_info): Likewise.
4874         (identify_source_line): Likewise.
4875         * source.h (identify_source_line): Move declaration from symtab.h
4876         and add comment from source.c
4877         (print_source_lines): Likewise.
4878         (forget_cached_source_info_for_objfile): Likewise.
4879         (forget_cached_source_info): Likewise.
4880         (select_source_symtab): Likewise.
4881         (enum print_source_lines_flag): Move definition from symtab.h.
4882         * symtab.h (identify_source_line): Move declaration to source.h.
4883         (print_source_lines): Likewise.
4884         (forget_cached_source_info_for_objfile): Likewise.
4885         (forget_cached_source_info): Likewise.
4886         (select_source_symtab): Likewise.
4887         (enum print_source_lines_flag): Move definition to source.h.
4888         * tui/tui-hooks.c: Add 'source.h' include.
4889
4890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * source.c (print_source_lines_base): Handle requests to print
4893         reverse line number sequences, and guard against empty lines
4894         string.
4895
4896 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * source.c (print_source_lines_base): Fix skip of '\r' if next
4899         character is '\n'.
4900
4901 2019-01-06  Tom Tromey  <tom@tromey.com>
4902
4903         * c-exp.y (struct c_parse_state) <macro_original_text,
4904         expansion_obstack>: New member.
4905         (macro_original_text, expansion_obstack): Remove globals.
4906         (scan_macro_expansion, scanning_macro_expansion)
4907         (finished_macro_expansion): Update.
4908         (scan_macro_cleanup): Remove.
4909         (yylex, c_parse): Update.
4910
4911 2019-01-06  Tom Tromey  <tom@tromey.com>
4912
4913         * c-exp.y (struct c_parse_state) <strings>: New member.
4914         (operator_stoken): Update.
4915
4916 2019-01-06  Tom Tromey  <tom@tromey.com>
4917
4918         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4919         (union type_stack_elt) <typelist_val>: Now a pointer to
4920         std::vector.
4921         (type_stack_cleanup): Don't declare.
4922         (push_typelist): Update.
4923         * parse.c (pop_typelist): Return a std::vector.
4924         (push_typelist): Take a std::vector.
4925         (follow_types): Update.  Do not free args.
4926         (type_stack_cleanup): Remove.
4927         * c-exp.y (struct c_parse_state): New.
4928         (cpstate): New global.
4929         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4930         (nonempty_typelist): Update.
4931         (func_mod): Create a new vector.
4932         (c_parse): Create a c_parse_state.
4933         (check_parameter_typelist): Do not delete params.
4934         (function_method): Update.  Do not delete type_list.
4935
4936 2019-01-06  Tom Tromey  <tom@tromey.com>
4937
4938         PR gdb/28155:
4939         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4940         check_typedef.
4941         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4942         (print_return_value): Likewise.
4943
4944 2019-01-05  Tom Tromey  <tom@tromey.com>
4945
4946         * contrib/cleanup_check.py: Remove.
4947         * contrib/gcc-with-excheck: Remove.
4948         * contrib/exsummary.py: Remove.
4949         * contrib/excheck.py: Remove.
4950
4951 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4952
4953         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4954         NULL. Initialize tpprev to NULL instead of assigning it
4955         to NULL on the next statement.
4956         * windows-nat.c (windows_delete_thread): Remove check for
4957         main_thread_id before printing thread exit notifications.
4958         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4959         Remove thread ID check against main_thread_id.
4960         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4961         windows_delete_thread.
4962         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4963
4964 2019-01-04  Tom Tromey  <tom@tromey.com>
4965
4966         * compile/compile.c (_initialize_compile): Use upper case for
4967         metasyntactic variables.
4968         * symmisc.c (_initialize_symmisc): Use upper case for
4969         metasyntactic variables.
4970         * psymtab.c (_initialize_psymtab): Use upper case for
4971         metasyntactic variables.
4972         * demangle.c (demangle_command): Use upper case for metasyntactic
4973         variables.
4974         (_initialize_demangler): Likewise.
4975         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4976         variables.
4977
4978 2019-01-03  Tom Tromey  <tom@tromey.com>
4979
4980         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4981
4982 2019-01-03  Tom Tromey  <tom@tromey.com>
4983
4984         * python/py-symtab.c (salpy_str): Update.
4985         (struct salpy_sal_object) <symtab>: Now a PyObject.
4986         (salpy_dealloc): Update.
4987         (del_objfile_sal): Use gdbpy_ref.
4988
4989 2019-01-03  Tom Tromey  <tom@tromey.com>
4990
4991         * python/py-type.c (convert_field): Use new_reference.  Return
4992         gdbpy_ref.
4993         (make_fielditem): Return gdbpy_ref.
4994         (typy_fields): Update.
4995         (typy_getitem): Update.
4996         (field_name): Return gdbpy_ref.  Use new_reference.
4997         (typy_iterator_iternext): Update.
4998
4999 2019-01-03  Tom Tromey  <tom@tromey.com>
5000
5001         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5002
5003 2019-01-03  Tom Tromey  <tom@tromey.com>
5004
5005         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5006         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5007         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5008         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5009         (pspy_set_type_printers): Likewise.
5010         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5011         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5012         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5013         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5014         (objfpy_set_type_printers): Likewise.
5015
5016 2019-01-03  Tom Tromey  <tom@tromey.com>
5017
5018         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5019         (gdbpy_print_stack): Use gdbpy_err_fetch.
5020         * python/python-internal.h (class gdbpy_err_fetch): New class.
5021         (class gdbpy_enter) <m_error_type, m_error_value,
5022         m_error_traceback>: Remove.
5023         <m_error>: New member.
5024         (gdbpy_exception_to_string): Don't declare.
5025         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5026         * python/py-value.c (convert_value_from_python): Use
5027         gdbpy_err_fetch.
5028         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5029         gdbpy_exception_to_string.
5030         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5031         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5032         gdbpy_err_fetch.
5033
5034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * linux-nat.c (delete_lwp_cleanup): Delete.
5037         (struct lwp_deleter): New struct.
5038         (lwp_info_up): New typedef.
5039         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5040         lwp_info_up.
5041
5042 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * linux-fork.c (class scoped_switch_fork_info): New class.
5045         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5046
5047 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5048
5049         * valops.c (find_overload_match): Remove use of null_cleanup, and
5050         calls to do_cleanups.
5051
5052 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * compile/compile-cplus-types.c
5055         (compile_cplus_instance::decl_name): Handle changes to
5056         cp_func_name.
5057         * cp-support.c (cp_func_name): Update header comment, update
5058         return type.
5059         * cp-support.h (cp_func_name): Update return type in declaration.
5060         * valops.c (find_overload_match): Move temp_func local to top
5061         level of function and change its type.  Use temp_func to hold and
5062         delete temporary string obtained from cp_func_name.
5063
5064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5065
5066         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5067         gdb::char_vector, remove cleanup, and update uses of `msg`.
5068
5069 2019-01-03  Jim Wilson  <jimw@sifive.com>
5070
5071         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5072
5073 2019-01-02  Tom Tromey  <tom@tromey.com>
5074
5075         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5076         (tdesc_parse_xml): Remove cleanups.
5077         * target-descriptions.h (make_cleanup_free_target_description):
5078         Don't declare.
5079         (target_desc_deleter): New struct.
5080         (target_desc_up): New typedef.
5081         * target-descriptions.c (target_desc_deleter::operator()): Rename
5082         from free_target_description.
5083         (make_cleanup_free_target_description): Remove.
5084
5085 2019-01-02  Tom Tromey  <tom@tromey.com>
5086
5087         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5088         constructor, destructor.
5089         (linespec_parser): Remove typedef.
5090         (~linespec_parser): Rename from linespec_parser_delete.
5091         (linespec_lex_to_end, linespec_complete_label)
5092         (linespec_complete): Update.
5093         (decode_line_full): Remove cleanups.
5094         (decode_line_1): Update.
5095
5096 2019-01-02  Tom Tromey  <tom@tromey.com>
5097
5098         * python/python-internal.h (inferior_to_inferior_object): Change
5099         return type.
5100         * python/py-exitedevent.c (create_exited_event_object): Update.
5101         * python/py-inferior.c (inferior_to_inferior_object): Return
5102         gdbpy_ref.
5103         (python_new_inferior, python_inferior_deleted)
5104         (thread_to_thread_object, delete_thread_object)
5105         (build_inferior_list, gdbpy_selected_inferior): Update.
5106         * python/py-infthread.c (create_thread_object): Update.  Also fail
5107         if inferior_to_inferior_object fails.
5108
5109 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5110
5111         * inferior.h (class inferior) <displaced_step_state>: New field.
5112         * infrun.h (struct displaced_step_state): Move here from
5113         infrun.c.  Initialize fields, add constructor.
5114         <inf>: Remove field.
5115         <reset>: New method.
5116         * infrun.c (struct displaced_step_inferior_state): Move to
5117         infrun.h.
5118         (displaced_step_inferior_states): Remove.
5119         (get_displaced_stepping_state): Adust.
5120         (displaced_step_in_progress_any_inferior): Adjust.
5121         (displaced_step_in_progress_thread): Adjust.
5122         (displaced_step_in_progress): Adjust.
5123         (add_displaced_stepping_state): Remove.
5124         (get_displaced_step_closure_by_addr): Adjust.
5125         (remove_displaced_stepping_state): Remove.
5126         (infrun_inferior_exit): Call displaced_step_state.reset.
5127         (use_displaced_stepping): Don't check for NULL.
5128         (displaced_step_prepare_throw): Call
5129         get_displaced_stepping_state.
5130         (displaced_step_fixup): Don't check for NULL.
5131         (prepare_for_detach): Don't check for NULL.
5132
5133 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5134
5135         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5136          in case of call that did not complete.
5137
5138 2019-01-02  Andrey Utkin  <autkin@undo.io>
5139
5140         * symfile.c (find_separate_debug_file): Fix search of debug files for
5141         remote debuggee.
5142
5143 2019-01-02  Tom Tromey  <tom@tromey.com>
5144
5145         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5146         indentation.
5147         * python/py-frame.c (frapy_older): Remove cast.
5148         (frapy_newer): Likewise.
5149         * python/py-breakpoint.c (local_setattro): Remove cast.
5150         * python/py-arch.c (archpy_name): Remove local variable.
5151         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5152
5153 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5154
5155         * unittests/basic_string_view/element_access/char/empty.cc:
5156         Fix year range in copyright header.
5157
5158 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5159
5160         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5161         Delete.
5162         <operator==>: Update with for removed field.
5163         <hash>: Likewise.
5164         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5165         <isa_features>: ...this.
5166         <abi_features>: New field.
5167         (riscv_isa_flen): Update comment.
5168         (riscv_abi_xlen): New declaration.
5169         (riscv_abi_flen): New declaration.
5170         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5171         isa_features.
5172         (riscv_abi_xlen): New function.
5173         (riscv_isa_flen): Update to get answer from isa_features.
5174         (riscv_abi_flen): New function.
5175         (riscv_has_fp_abi): Update to get answer from abi_features.
5176         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5177         xlen and flen.
5178         (riscv_call_info) <xlen, flen>: Update comment.
5179         (riscv_call_arg_struct): Remove invalid assertions
5180         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5181         is removed.
5182         (riscv_gdbarch_init): Gather isa features and abi features
5183         separately, ensure both match on the gdbarch when reusing an old
5184         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5185         a target with 64-bit float hardware.
5186
5187 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5188
5189         * source.c (search_command_helper): Stop reverse search
5190         when line 1 has been searched.
5191
5192 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5193
5194         * record-full.c (record_full_base_target::close): Rewrite
5195         record_full_core_buf_list free logic.
5196
5197 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5198
5199         * break-catch-syscall.c (print_one_catch_syscall): xfree
5200         the last text.
5201
5202 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5203
5204         * top.c (print_gdb_version): Update Copyright year in version
5205         message.
5206
5207 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5208
5209         Update copyright year range in all GDB files.
5210
5211 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5212
5213         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5214
5215 For older changes see ChangeLog-2018.
5216 \f
5217 Local Variables:
5218 mode: change-log
5219 left-margin: 8
5220 fill-column: 74
5221 version-control: never
5222 coding: utf-8
5223 End:
5224