Fix a couple of comments
[external/binutils.git] / gdb / ChangeLog
1 2019-04-10  Tom Tromey  <tom@tromey.com>
2
3         * symfile.c (reread_symbols): Remove old comment.
4         * objfiles.c (free_all_objfiles): Fix a typo.
5
6 2019-04-10  Tom Tromey  <tom@tromey.com>
7
8         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9         * minsyms.c (lookup_minimal_symbol): Use foreach.
10         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11         (lookup_minimal_symbol_solib_trampoline): Likewise.
12         * symfile.c (reread_symbols): Use foreach.
13
14 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
15             Tom Tromey  <tromey@adacore.com>
16
17         PR rust/24414:
18         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
19         (rust_lex_int_test): Change "value" to be LONGEST.
20         (rust_lex_tests): Add test for long integer literal.
21
22 2019-04-09  Tom Tromey  <tromey@adacore.com>
23
24         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
25         to bool.
26         (extended_remote_target::attach): Update.
27         (remote_target::remote_notice_new_inferior): Update.
28         (remote_target::add_current_inferior_and_thread): Update.
29         * inferior.c (exit_inferior_1): Use "false".
30         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
31
32 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
33
34         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
35         the "start" command.
36
37 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
38
39         * python/py-inferior.c (infpy_thread_from_thread_handle):
40         Adjust comments to reflect renaming of thread_from_thread_handle
41         to thread_from_handle.  Adjust keywords.  Fix type error message.
42         (inferior_object_methods): Add thread_from_handle.  Retain
43         thread_from_thread_handle, but mark it as deprecated.
44
45 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
46
47         * gdbthread.h (find_thread_by_handle): Revise declaration.
48         * thread.c (find_thread_by_handle): Likewise.  Adjust
49         implementation too.
50         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
51         support for buffer objects as handles.
52
53 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
54
55         * python/py-infthread.c (thpy_thread_handle): New function.
56         (thread_object_methods): Register thpy_thread_handle.
57
58 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
59
60         * gdbthread.h (thread_to_thread_handle): Declare.
61         * thread.c (gdbtypes.h): Include.
62         (thread_to_thread_handle): New function.
63
64         * target.h (struct target_ops): Add thread_info_to_thread_handle.
65         (target_thread_info_to_thread_handle): Declare.
66         * target.c (target_thread_info_to_thread_handle): New function.
67         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
68         * target-delegates.c: Regenerate.
69
70         * linux-thread-db.c (class thread_db_target): Add method
71         thread_info_to_thread_handle.
72         (thread_db_target::thread_info_to_thread_handle): Define.
73         * remote.c (class remote_target): Add new method
74         thread_info_to_thread_handle.
75         (remote_target::thread_info_to_thread_handle): Define.
76
77 2019-04-08  Pedro Alves  <palves@redhat.com>
78
79         * common/common-exceptions.c (throw_exception): Don't create
80         named object to throw; throw directly.
81         (throw_it): Likewise.  Don't initialize gdb_exception::message
82         here, with new; pass FMT and AP to the ctor instead.
83         * common/common-exceptions.h: Include <string>.
84         (gdb_exception::gdb_exception(enum return_reason, enum errors,
85         const char *, va_list)): New ctor.  Use std::make_shared.
86         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
87         errors)): Delete.
88         (gdb_exception_error::gdb_exception_error(enum errors, const char
89         *, va_list)): New.
90         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
91         Add assertion.
92         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
93         errors)): Delete.
94         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
95         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
96         Add assertion.
97
98 2019-04-08  Tom Tromey  <tom@tromey.com>
99
100         * valops.c (value_rtti_indirect_type): Replace throw_exception
101         with throw.
102         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
103         with throw.
104         * thread.c (thr_try_catch_cmd): Replace throw_exception with
105         throw.
106         * target.c (target_translate_tls_address): Replace throw_exception
107         with throw.
108         * stack.c (frame_apply_command_count): Replace throw_exception
109         with throw.
110         * solib-spu.c (append_ocl_sos): Replace throw_exception with
111         throw.
112         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
113         with throw.
114         * rs6000-tdep.c (rs6000_frame_cache)
115         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
116         * remote.c: Replace throw_exception with throw.
117         * record-full.c (record_full_message, record_full_wait_1)
118         (record_full_restore): Replace throw_exception with throw.
119         * record-btrace.c:
120         (get_thread_current_frame_id, record_btrace_start_replaying)
121         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
122         (cmd_record_btrace_start): Replace throw_exception with throw.
123         * parse.c (parse_exp_in_context_1): Replace throw_exception with
124         throw.
125         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
126         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
127         * linespec.c:
128         (find_linespec_symbols): Replace throw_exception with throw.
129         * infrun.c (displaced_step_prepare, resume): Replace
130         throw_exception with throw.
131         * infcmd.c (post_create_inferior): Replace throw_exception with
132         throw.
133         * inf-loop.c (inferior_event_handler): Replace throw_exception
134         with throw.
135         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
136         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
137         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
138         (get_prev_frame_always, get_frame_pc_if_available)
139         (get_frame_address_in_block_if_available, get_frame_language):
140         Replace throw_exception with throw.
141         * frame-unwind.c (frame_unwind_try_unwinder): Replace
142         throw_exception with throw.
143         * eval.c (fetch_subexp_value, evaluate_var_value)
144         (evaluate_funcall, evaluate_subexp_standard): Replace
145         throw_exception with throw.
146         * dwarf2loc.c (call_site_find_chain)
147         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
148         Replace throw_exception with throw.
149         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
150         with throw.
151         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
152         throw.
153         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
154         * completer.c (complete_line_internal): Replace throw_exception
155         with throw.
156         * compile/compile-object-run.c (compile_object_run): Replace
157         throw_exception with throw.
158         * cli/cli-script.c (process_next_line): Replace throw_exception
159         with throw.
160         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
161         (btrace_enable, btrace_maint_update_pt_packets): Replace
162         throw_exception with throw.
163         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
164         throw_exception with throw.
165         * break-catch-throw.c (re_set_exception_catchpoint): Replace
166         throw_exception with throw.
167         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
168         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
169         * aarch64-tdep.c (aarch64_make_prologue_cache)
170         (aarch64_make_stub_cache): Replace throw_exception with throw.
171
172 2019-04-08  Tom Tromey  <tom@tromey.com>
173
174         * common/common-exceptions.c (throw_exception): Rename from
175         throw_exception_cxx.  Remove old copy.  Make argument const.
176         (throw_it): Create and throw exception objects directly.
177         * common/common-exceptions.h (throw_exception): Make argument
178         const.
179         (struct gdb_exception_error): Add constructor.
180         (struct gdb_exception_quit): Add constructor.
181
182 2019-04-08  Tom Tromey  <tom@tromey.com>
183
184         * common/common-exceptions.h (exception_rethrow): Don't declare.
185         (TRY_SJLJ): Update comment.
186         (TRY, CATCH, END_CATCH): Remove.
187         * common/common-exceptions.c (exception_rethrow): Remove.
188
189 2019-04-08  Tom Tromey  <tom@tromey.com>
190
191         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
192         Remove.
193         (gdb_exception_error): Rename from
194         gdb_exception_RETURN_MASK_ERROR.
195         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
196         (gdb_quit_bad_alloc): Update.
197         * aarch64-tdep.c: Update.
198         * ada-lang.c: Update.
199         * ada-typeprint.c: Update.
200         * ada-valprint.c: Update.
201         * amd64-tdep.c: Update.
202         * arch-utils.c: Update.
203         * break-catch-throw.c: Update.
204         * breakpoint.c: Update.
205         * btrace.c: Update.
206         * c-varobj.c: Update.
207         * cli/cli-cmds.c: Update.
208         * cli/cli-interp.c: Update.
209         * cli/cli-script.c: Update.
210         * common/common-exceptions.c: Update.
211         * common/new-op.c: Update.
212         * common/selftest.c: Update.
213         * compile/compile-c-symbols.c: Update.
214         * compile/compile-cplus-symbols.c: Update.
215         * compile/compile-object-load.c: Update.
216         * compile/compile-object-run.c: Update.
217         * completer.c: Update.
218         * corelow.c: Update.
219         * cp-abi.c: Update.
220         * cp-support.c: Update.
221         * cp-valprint.c: Update.
222         * darwin-nat.c: Update.
223         * disasm-selftests.c: Update.
224         * dtrace-probe.c: Update.
225         * dwarf-index-cache.c: Update.
226         * dwarf-index-write.c: Update.
227         * dwarf2-frame-tailcall.c: Update.
228         * dwarf2-frame.c: Update.
229         * dwarf2loc.c: Update.
230         * dwarf2read.c: Update.
231         * eval.c: Update.
232         * event-loop.c: Update.
233         * event-top.c: Update.
234         * exec.c: Update.
235         * f-valprint.c: Update.
236         * fbsd-tdep.c: Update.
237         * frame-unwind.c: Update.
238         * frame.c: Update.
239         * gdbtypes.c: Update.
240         * gnu-v3-abi.c: Update.
241         * guile/guile-internal.h: Update.
242         * guile/scm-block.c: Update.
243         * guile/scm-breakpoint.c: Update.
244         * guile/scm-cmd.c: Update.
245         * guile/scm-disasm.c: Update.
246         * guile/scm-frame.c: Update.
247         * guile/scm-lazy-string.c: Update.
248         * guile/scm-math.c: Update.
249         * guile/scm-param.c: Update.
250         * guile/scm-ports.c: Update.
251         * guile/scm-pretty-print.c: Update.
252         * guile/scm-symbol.c: Update.
253         * guile/scm-symtab.c: Update.
254         * guile/scm-type.c: Update.
255         * guile/scm-value.c: Update.
256         * i386-linux-tdep.c: Update.
257         * i386-tdep.c: Update.
258         * inf-loop.c: Update.
259         * infcall.c: Update.
260         * infcmd.c: Update.
261         * infrun.c: Update.
262         * jit.c: Update.
263         * language.c: Update.
264         * linespec.c: Update.
265         * linux-fork.c: Update.
266         * linux-nat.c: Update.
267         * linux-tdep.c: Update.
268         * linux-thread-db.c: Update.
269         * main.c: Update.
270         * mi/mi-cmd-break.c: Update.
271         * mi/mi-cmd-stack.c: Update.
272         * mi/mi-interp.c: Update.
273         * mi/mi-main.c: Update.
274         * objc-lang.c: Update.
275         * p-valprint.c: Update.
276         * parse.c: Update.
277         * ppc-linux-tdep.c: Update.
278         * printcmd.c: Update.
279         * python/py-arch.c: Update.
280         * python/py-breakpoint.c: Update.
281         * python/py-cmd.c: Update.
282         * python/py-finishbreakpoint.c: Update.
283         * python/py-frame.c: Update.
284         * python/py-framefilter.c: Update.
285         * python/py-gdb-readline.c: Update.
286         * python/py-inferior.c: Update.
287         * python/py-infthread.c: Update.
288         * python/py-lazy-string.c: Update.
289         * python/py-linetable.c: Update.
290         * python/py-objfile.c: Update.
291         * python/py-param.c: Update.
292         * python/py-prettyprint.c: Update.
293         * python/py-progspace.c: Update.
294         * python/py-record-btrace.c: Update.
295         * python/py-record.c: Update.
296         * python/py-symbol.c: Update.
297         * python/py-type.c: Update.
298         * python/py-unwind.c: Update.
299         * python/py-utils.c: Update.
300         * python/py-value.c: Update.
301         * python/python.c: Update.
302         * record-btrace.c: Update.
303         * record-full.c: Update.
304         * remote-fileio.c: Update.
305         * remote.c: Update.
306         * riscv-tdep.c: Update.
307         * rs6000-aix-tdep.c: Update.
308         * rs6000-tdep.c: Update.
309         * rust-exp.y: Update.
310         * rust-lang.c: Update.
311         * s390-tdep.c: Update.
312         * selftest-arch.c: Update.
313         * solib-dsbt.c: Update.
314         * solib-frv.c: Update.
315         * solib-spu.c: Update.
316         * solib-svr4.c: Update.
317         * solib.c: Update.
318         * sparc64-linux-tdep.c: Update.
319         * stack.c: Update.
320         * symfile-mem.c: Update.
321         * symmisc.c: Update.
322         * target.c: Update.
323         * thread.c: Update.
324         * top.c: Update.
325         * tracefile-tfile.c: Update.
326         * tui/tui.c: Update.
327         * typeprint.c: Update.
328         * unittests/cli-utils-selftests.c: Update.
329         * unittests/parse-connection-spec-selftests.c: Update.
330         * valops.c: Update.
331         * valprint.c: Update.
332         * value.c: Update.
333         * varobj.c: Update.
334         * windows-nat.c: Update.
335         * x86-linux-nat.c: Update.
336         * xml-support.c: Update.
337
338 2019-04-08  Tom Tromey  <tom@tromey.com>
339
340         * xml-support.c: Use C++ exception handling.
341         * x86-linux-nat.c: Use C++ exception handling.
342         * windows-nat.c: Use C++ exception handling.
343         * varobj.c: Use C++ exception handling.
344         * value.c: Use C++ exception handling.
345         * valprint.c: Use C++ exception handling.
346         * valops.c: Use C++ exception handling.
347         * unittests/parse-connection-spec-selftests.c: Use C++ exception
348         handling.
349         * unittests/cli-utils-selftests.c: Use C++ exception handling.
350         * typeprint.c: Use C++ exception handling.
351         * tui/tui.c: Use C++ exception handling.
352         * tracefile-tfile.c: Use C++ exception handling.
353         * top.c: Use C++ exception handling.
354         * thread.c: Use C++ exception handling.
355         * target.c: Use C++ exception handling.
356         * symmisc.c: Use C++ exception handling.
357         * symfile-mem.c: Use C++ exception handling.
358         * stack.c: Use C++ exception handling.
359         * sparc64-linux-tdep.c: Use C++ exception handling.
360         * solib.c: Use C++ exception handling.
361         * solib-svr4.c: Use C++ exception handling.
362         * solib-spu.c: Use C++ exception handling.
363         * solib-frv.c: Use C++ exception handling.
364         * solib-dsbt.c: Use C++ exception handling.
365         * selftest-arch.c: Use C++ exception handling.
366         * s390-tdep.c: Use C++ exception handling.
367         * rust-lang.c: Use C++ exception handling.
368         * rust-exp.y: Use C++ exception handling.
369         * rs6000-tdep.c: Use C++ exception handling.
370         * rs6000-aix-tdep.c: Use C++ exception handling.
371         * riscv-tdep.c: Use C++ exception handling.
372         * remote.c: Use C++ exception handling.
373         * remote-fileio.c: Use C++ exception handling.
374         * record-full.c: Use C++ exception handling.
375         * record-btrace.c: Use C++ exception handling.
376         * python/python.c: Use C++ exception handling.
377         * python/py-value.c: Use C++ exception handling.
378         * python/py-utils.c: Use C++ exception handling.
379         * python/py-unwind.c: Use C++ exception handling.
380         * python/py-type.c: Use C++ exception handling.
381         * python/py-symbol.c: Use C++ exception handling.
382         * python/py-record.c: Use C++ exception handling.
383         * python/py-record-btrace.c: Use C++ exception handling.
384         * python/py-progspace.c: Use C++ exception handling.
385         * python/py-prettyprint.c: Use C++ exception handling.
386         * python/py-param.c: Use C++ exception handling.
387         * python/py-objfile.c: Use C++ exception handling.
388         * python/py-linetable.c: Use C++ exception handling.
389         * python/py-lazy-string.c: Use C++ exception handling.
390         * python/py-infthread.c: Use C++ exception handling.
391         * python/py-inferior.c: Use C++ exception handling.
392         * python/py-gdb-readline.c: Use C++ exception handling.
393         * python/py-framefilter.c: Use C++ exception handling.
394         * python/py-frame.c: Use C++ exception handling.
395         * python/py-finishbreakpoint.c: Use C++ exception handling.
396         * python/py-cmd.c: Use C++ exception handling.
397         * python/py-breakpoint.c: Use C++ exception handling.
398         * python/py-arch.c: Use C++ exception handling.
399         * printcmd.c: Use C++ exception handling.
400         * ppc-linux-tdep.c: Use C++ exception handling.
401         * parse.c: Use C++ exception handling.
402         * p-valprint.c: Use C++ exception handling.
403         * objc-lang.c: Use C++ exception handling.
404         * mi/mi-main.c: Use C++ exception handling.
405         * mi/mi-interp.c: Use C++ exception handling.
406         * mi/mi-cmd-stack.c: Use C++ exception handling.
407         * mi/mi-cmd-break.c: Use C++ exception handling.
408         * main.c: Use C++ exception handling.
409         * linux-thread-db.c: Use C++ exception handling.
410         * linux-tdep.c: Use C++ exception handling.
411         * linux-nat.c: Use C++ exception handling.
412         * linux-fork.c: Use C++ exception handling.
413         * linespec.c: Use C++ exception handling.
414         * language.c: Use C++ exception handling.
415         * jit.c: Use C++ exception handling.
416         * infrun.c: Use C++ exception handling.
417         * infcmd.c: Use C++ exception handling.
418         * infcall.c: Use C++ exception handling.
419         * inf-loop.c: Use C++ exception handling.
420         * i386-tdep.c: Use C++ exception handling.
421         * i386-linux-tdep.c: Use C++ exception handling.
422         * guile/scm-value.c: Use C++ exception handling.
423         * guile/scm-type.c: Use C++ exception handling.
424         * guile/scm-symtab.c: Use C++ exception handling.
425         * guile/scm-symbol.c: Use C++ exception handling.
426         * guile/scm-pretty-print.c: Use C++ exception handling.
427         * guile/scm-ports.c: Use C++ exception handling.
428         * guile/scm-param.c: Use C++ exception handling.
429         * guile/scm-math.c: Use C++ exception handling.
430         * guile/scm-lazy-string.c: Use C++ exception handling.
431         * guile/scm-frame.c: Use C++ exception handling.
432         * guile/scm-disasm.c: Use C++ exception handling.
433         * guile/scm-cmd.c: Use C++ exception handling.
434         * guile/scm-breakpoint.c: Use C++ exception handling.
435         * guile/scm-block.c: Use C++ exception handling.
436         * guile/guile-internal.h: Use C++ exception handling.
437         * gnu-v3-abi.c: Use C++ exception handling.
438         * gdbtypes.c: Use C++ exception handling.
439         * frame.c: Use C++ exception handling.
440         * frame-unwind.c: Use C++ exception handling.
441         * fbsd-tdep.c: Use C++ exception handling.
442         * f-valprint.c: Use C++ exception handling.
443         * exec.c: Use C++ exception handling.
444         * event-top.c: Use C++ exception handling.
445         * event-loop.c: Use C++ exception handling.
446         * eval.c: Use C++ exception handling.
447         * dwarf2read.c: Use C++ exception handling.
448         * dwarf2loc.c: Use C++ exception handling.
449         * dwarf2-frame.c: Use C++ exception handling.
450         * dwarf2-frame-tailcall.c: Use C++ exception handling.
451         * dwarf-index-write.c: Use C++ exception handling.
452         * dwarf-index-cache.c: Use C++ exception handling.
453         * dtrace-probe.c: Use C++ exception handling.
454         * disasm-selftests.c: Use C++ exception handling.
455         * darwin-nat.c: Use C++ exception handling.
456         * cp-valprint.c: Use C++ exception handling.
457         * cp-support.c: Use C++ exception handling.
458         * cp-abi.c: Use C++ exception handling.
459         * corelow.c: Use C++ exception handling.
460         * completer.c: Use C++ exception handling.
461         * compile/compile-object-run.c: Use C++ exception handling.
462         * compile/compile-object-load.c: Use C++ exception handling.
463         * compile/compile-cplus-symbols.c: Use C++ exception handling.
464         * compile/compile-c-symbols.c: Use C++ exception handling.
465         * common/selftest.c: Use C++ exception handling.
466         * common/new-op.c: Use C++ exception handling.
467         * cli/cli-script.c: Use C++ exception handling.
468         * cli/cli-interp.c: Use C++ exception handling.
469         * cli/cli-cmds.c: Use C++ exception handling.
470         * c-varobj.c: Use C++ exception handling.
471         * btrace.c: Use C++ exception handling.
472         * breakpoint.c: Use C++ exception handling.
473         * break-catch-throw.c: Use C++ exception handling.
474         * arch-utils.c: Use C++ exception handling.
475         * amd64-tdep.c: Use C++ exception handling.
476         * ada-valprint.c: Use C++ exception handling.
477         * ada-typeprint.c: Use C++ exception handling.
478         * ada-lang.c: Use C++ exception handling.
479         * aarch64-tdep.c: Use C++ exception handling.
480
481 2019-04-08  Tom Tromey  <tom@tromey.com>
482
483         * xml-support.c (gdb_xml_parser::parse): Update.
484         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
485         * value.c (show_convenience): Update.
486         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
487         (test_parse_flags_qcs): Update.
488         * thread.c (thr_try_catch_cmd): Update.
489         * target.c (target_translate_tls_address): Update.
490         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
491         (info_frame_command_core, frame_apply_command_count): Update.
492         * rust-exp.y (rust_lex_exception_test): Update.
493         * riscv-tdep.c (riscv_print_one_register_info): Update.
494         * remote.c (remote_target::enable_btrace): Update.
495         * record-btrace.c (record_btrace_enable_warn): Update.
496         * python/py-utils.c (gdbpy_convert_exception): Update.
497         * printcmd.c (do_one_display, print_variable_and_value): Update.
498         * mi/mi-main.c (mi_print_exception): Update.
499         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
500         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
501         * linux-nat.c (linux_nat_target::attach): Update.
502         * linux-fork.c (class scoped_switch_fork_info): Update.
503         * infrun.c (displaced_step_prepare): Update.
504         * infcall.c (call_function_by_hand_dummy): Update.
505         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
506         * gnu-v3-abi.c (print_one_vtable): Update.
507         * frame.c (get_prev_frame_always): Update.
508         * f-valprint.c (info_common_command_for_block): Update.
509         * exec.c (try_open_exec_file): Update.
510         * exceptions.c (print_exception, exception_print)
511         (exception_fprintf, exception_print_same): Update.
512         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
513         * dwarf-index-cache.c (index_cache::store)
514         (index_cache::lookup_gdb_index): Update.
515         * darwin-nat.c (maybe_cache_shell): Update.
516         * cp-valprint.c (cp_print_value_fields): Update.
517         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
518         (gcc_cplus_symbol_address): Update.
519         * compile/compile-c-symbols.c (gcc_convert_symbol)
520         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
521         * common/selftest.c: Update.
522         * common/common-exceptions.h (struct gdb_exception) <message>: Now
523         a std::string.
524         (exception_try_scope_entry, exception_try_scope_exit): Don't
525         declare.
526         (struct exception_try_scope): Remove.
527         (TRY): Don't use exception_try_scope.
528         (struct gdb_exception): Add constructor, operator=.
529         <what>: New method.
530         (struct gdb_exception_RETURN_MASK_ALL)
531         (struct gdb_exception_RETURN_MASK_ERROR)
532         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
533         (struct gdb_quit_bad_alloc): Update.
534         * common/common-exceptions.c (exception_none): Change
535         initializer.
536         (struct catcher) <state, exception>: Initialize inline.
537         <prev>: Remove member.
538         (current_catcher): Remove.
539         (catchers): New global.
540         (exceptions_state_mc_init): Simplify.
541         (catcher_pop): Remove.
542         (exceptions_state_mc, exceptions_state_mc_catch): Update.
543         (try_scope_depth, exception_try_scope_entry)
544         (exception_try_scope_exit): Remove.
545         (throw_exception_sjlj): Update.
546         (exception_messages, exception_messages_size): Remove.
547         (throw_it): Simplify.
548         (gdb_exception_sliced_copy): Remove.
549         (throw_exception_cxx): Update.
550         * cli/cli-script.c (script_from_file): Update.
551         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
552         Update.
553         * ada-valprint.c (ada_val_print): Update.
554         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
555         (create_excep_cond_exprs): Update.
556
557 2019-04-08  Tom Tromey  <tom@tromey.com>
558
559         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
560         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
561         (TRY, CATCH, END_CATCH): Remove some definitions.
562         * common/common-exceptions.c: Don't use GDB_XCPT.
563         (catcher_list_size): Remove.
564         (throw_exception, throw_it): Simplify.
565
566 2019-04-05  Tom Tromey  <tom@tromey.com>
567
568         Revert the header-sorting patch.
569         * ft32-tdep.c: Revert.
570         * frv-tdep.c: Revert.
571         * frv-linux-tdep.c: Revert.
572         * frame.c: Revert.
573         * frame-unwind.c: Revert.
574         * frame-base.c: Revert.
575         * fork-child.c: Revert.
576         * findvar.c: Revert.
577         * findcmd.c: Revert.
578         * filesystem.c: Revert.
579         * filename-seen-cache.h: Revert.
580         * filename-seen-cache.c: Revert.
581         * fbsd-tdep.c: Revert.
582         * fbsd-nat.h: Revert.
583         * fbsd-nat.c: Revert.
584         * f-valprint.c: Revert.
585         * f-typeprint.c: Revert.
586         * f-lang.c: Revert.
587         * extension.h: Revert.
588         * extension.c: Revert.
589         * extension-priv.h: Revert.
590         * expprint.c: Revert.
591         * exec.h: Revert.
592         * exec.c: Revert.
593         * exceptions.c: Revert.
594         * event-top.c: Revert.
595         * event-loop.c: Revert.
596         * eval.c: Revert.
597         * elfread.c: Revert.
598         * dwarf2read.h: Revert.
599         * dwarf2read.c: Revert.
600         * dwarf2loc.c: Revert.
601         * dwarf2expr.h: Revert.
602         * dwarf2expr.c: Revert.
603         * dwarf2-frame.c: Revert.
604         * dwarf2-frame-tailcall.c: Revert.
605         * dwarf-index-write.h: Revert.
606         * dwarf-index-write.c: Revert.
607         * dwarf-index-common.c: Revert.
608         * dwarf-index-cache.h: Revert.
609         * dwarf-index-cache.c: Revert.
610         * dummy-frame.c: Revert.
611         * dtrace-probe.c: Revert.
612         * disasm.h: Revert.
613         * disasm.c: Revert.
614         * disasm-selftests.c: Revert.
615         * dictionary.c: Revert.
616         * dicos-tdep.c: Revert.
617         * demangle.c: Revert.
618         * dcache.h: Revert.
619         * dcache.c: Revert.
620         * darwin-nat.h: Revert.
621         * darwin-nat.c: Revert.
622         * darwin-nat-info.c: Revert.
623         * d-valprint.c: Revert.
624         * d-namespace.c: Revert.
625         * d-lang.c: Revert.
626         * ctf.c: Revert.
627         * csky-tdep.c: Revert.
628         * csky-linux-tdep.c: Revert.
629         * cris-tdep.c: Revert.
630         * cris-linux-tdep.c: Revert.
631         * cp-valprint.c: Revert.
632         * cp-support.c: Revert.
633         * cp-namespace.c: Revert.
634         * cp-abi.c: Revert.
635         * corelow.c: Revert.
636         * corefile.c: Revert.
637         * continuations.c: Revert.
638         * completer.h: Revert.
639         * completer.c: Revert.
640         * complaints.c: Revert.
641         * coffread.c: Revert.
642         * coff-pe-read.c: Revert.
643         * cli-out.h: Revert.
644         * cli-out.c: Revert.
645         * charset.c: Revert.
646         * c-varobj.c: Revert.
647         * c-valprint.c: Revert.
648         * c-typeprint.c: Revert.
649         * c-lang.c: Revert.
650         * buildsym.c: Revert.
651         * buildsym-legacy.c: Revert.
652         * build-id.h: Revert.
653         * build-id.c: Revert.
654         * btrace.c: Revert.
655         * bsd-uthread.c: Revert.
656         * breakpoint.h: Revert.
657         * breakpoint.c: Revert.
658         * break-catch-throw.c: Revert.
659         * break-catch-syscall.c: Revert.
660         * break-catch-sig.c: Revert.
661         * blockframe.c: Revert.
662         * block.c: Revert.
663         * bfin-tdep.c: Revert.
664         * bfin-linux-tdep.c: Revert.
665         * bfd-target.c: Revert.
666         * bcache.c: Revert.
667         * ax-general.c: Revert.
668         * ax-gdb.h: Revert.
669         * ax-gdb.c: Revert.
670         * avr-tdep.c: Revert.
671         * auxv.c: Revert.
672         * auto-load.c: Revert.
673         * arm-wince-tdep.c: Revert.
674         * arm-tdep.c: Revert.
675         * arm-symbian-tdep.c: Revert.
676         * arm-pikeos-tdep.c: Revert.
677         * arm-obsd-tdep.c: Revert.
678         * arm-nbsd-tdep.c: Revert.
679         * arm-nbsd-nat.c: Revert.
680         * arm-linux-tdep.c: Revert.
681         * arm-linux-nat.c: Revert.
682         * arm-fbsd-tdep.c: Revert.
683         * arm-fbsd-nat.c: Revert.
684         * arm-bsd-tdep.c: Revert.
685         * arch-utils.c: Revert.
686         * arc-tdep.c: Revert.
687         * arc-newlib-tdep.c: Revert.
688         * annotate.h: Revert.
689         * annotate.c: Revert.
690         * amd64-windows-tdep.c: Revert.
691         * amd64-windows-nat.c: Revert.
692         * amd64-tdep.c: Revert.
693         * amd64-sol2-tdep.c: Revert.
694         * amd64-obsd-tdep.c: Revert.
695         * amd64-obsd-nat.c: Revert.
696         * amd64-nbsd-tdep.c: Revert.
697         * amd64-nbsd-nat.c: Revert.
698         * amd64-nat.c: Revert.
699         * amd64-linux-tdep.c: Revert.
700         * amd64-linux-nat.c: Revert.
701         * amd64-fbsd-tdep.c: Revert.
702         * amd64-fbsd-nat.c: Revert.
703         * amd64-dicos-tdep.c: Revert.
704         * amd64-darwin-tdep.c: Revert.
705         * amd64-bsd-nat.c: Revert.
706         * alpha-tdep.c: Revert.
707         * alpha-obsd-tdep.c: Revert.
708         * alpha-nbsd-tdep.c: Revert.
709         * alpha-mdebug-tdep.c: Revert.
710         * alpha-linux-tdep.c: Revert.
711         * alpha-linux-nat.c: Revert.
712         * alpha-bsd-tdep.c: Revert.
713         * alpha-bsd-nat.c: Revert.
714         * aix-thread.c: Revert.
715         * agent.c: Revert.
716         * addrmap.c: Revert.
717         * ada-varobj.c: Revert.
718         * ada-valprint.c: Revert.
719         * ada-typeprint.c: Revert.
720         * ada-tasks.c: Revert.
721         * ada-lang.c: Revert.
722         * aarch64-tdep.c: Revert.
723         * aarch64-ravenscar-thread.c: Revert.
724         * aarch64-newlib-tdep.c: Revert.
725         * aarch64-linux-tdep.c: Revert.
726         * aarch64-linux-nat.c: Revert.
727         * aarch64-fbsd-tdep.c: Revert.
728         * aarch64-fbsd-nat.c: Revert.
729         * aarch32-linux-nat.c: Revert.
730
731 2019-04-05  Tom Tromey  <tom@tromey.com>
732
733         * ft32-tdep.c: Sort headers.
734         * frv-tdep.c: Sort headers.
735         * frv-linux-tdep.c: Sort headers.
736         * frame.c: Sort headers.
737         * frame-unwind.c: Sort headers.
738         * frame-base.c: Sort headers.
739         * fork-child.c: Sort headers.
740         * findvar.c: Sort headers.
741         * findcmd.c: Sort headers.
742         * filesystem.c: Sort headers.
743         * filename-seen-cache.h: Sort headers.
744         * filename-seen-cache.c: Sort headers.
745         * fbsd-tdep.c: Sort headers.
746         * fbsd-nat.h: Sort headers.
747         * fbsd-nat.c: Sort headers.
748         * f-valprint.c: Sort headers.
749         * f-typeprint.c: Sort headers.
750         * f-lang.c: Sort headers.
751         * extension.h: Sort headers.
752         * extension.c: Sort headers.
753         * extension-priv.h: Sort headers.
754         * expprint.c: Sort headers.
755         * exec.h: Sort headers.
756         * exec.c: Sort headers.
757         * exceptions.c: Sort headers.
758         * event-top.c: Sort headers.
759         * event-loop.c: Sort headers.
760         * eval.c: Sort headers.
761         * elfread.c: Sort headers.
762         * dwarf2read.h: Sort headers.
763         * dwarf2read.c: Sort headers.
764         * dwarf2loc.c: Sort headers.
765         * dwarf2expr.h: Sort headers.
766         * dwarf2expr.c: Sort headers.
767         * dwarf2-frame.c: Sort headers.
768         * dwarf2-frame-tailcall.c: Sort headers.
769         * dwarf-index-write.h: Sort headers.
770         * dwarf-index-write.c: Sort headers.
771         * dwarf-index-common.c: Sort headers.
772         * dwarf-index-cache.h: Sort headers.
773         * dwarf-index-cache.c: Sort headers.
774         * dummy-frame.c: Sort headers.
775         * dtrace-probe.c: Sort headers.
776         * disasm.h: Sort headers.
777         * disasm.c: Sort headers.
778         * disasm-selftests.c: Sort headers.
779         * dictionary.c: Sort headers.
780         * dicos-tdep.c: Sort headers.
781         * demangle.c: Sort headers.
782         * dcache.h: Sort headers.
783         * dcache.c: Sort headers.
784         * darwin-nat.h: Sort headers.
785         * darwin-nat.c: Sort headers.
786         * darwin-nat-info.c: Sort headers.
787         * d-valprint.c: Sort headers.
788         * d-namespace.c: Sort headers.
789         * d-lang.c: Sort headers.
790         * ctf.c: Sort headers.
791         * csky-tdep.c: Sort headers.
792         * csky-linux-tdep.c: Sort headers.
793         * cris-tdep.c: Sort headers.
794         * cris-linux-tdep.c: Sort headers.
795         * cp-valprint.c: Sort headers.
796         * cp-support.c: Sort headers.
797         * cp-namespace.c: Sort headers.
798         * cp-abi.c: Sort headers.
799         * corelow.c: Sort headers.
800         * corefile.c: Sort headers.
801         * continuations.c: Sort headers.
802         * completer.h: Sort headers.
803         * completer.c: Sort headers.
804         * complaints.c: Sort headers.
805         * coffread.c: Sort headers.
806         * coff-pe-read.c: Sort headers.
807         * cli-out.h: Sort headers.
808         * cli-out.c: Sort headers.
809         * charset.c: Sort headers.
810         * c-varobj.c: Sort headers.
811         * c-valprint.c: Sort headers.
812         * c-typeprint.c: Sort headers.
813         * c-lang.c: Sort headers.
814         * buildsym.c: Sort headers.
815         * buildsym-legacy.c: Sort headers.
816         * build-id.h: Sort headers.
817         * build-id.c: Sort headers.
818         * btrace.c: Sort headers.
819         * bsd-uthread.c: Sort headers.
820         * breakpoint.h: Sort headers.
821         * breakpoint.c: Sort headers.
822         * break-catch-throw.c: Sort headers.
823         * break-catch-syscall.c: Sort headers.
824         * break-catch-sig.c: Sort headers.
825         * blockframe.c: Sort headers.
826         * block.c: Sort headers.
827         * bfin-tdep.c: Sort headers.
828         * bfin-linux-tdep.c: Sort headers.
829         * bfd-target.c: Sort headers.
830         * bcache.c: Sort headers.
831         * ax-general.c: Sort headers.
832         * ax-gdb.h: Sort headers.
833         * ax-gdb.c: Sort headers.
834         * avr-tdep.c: Sort headers.
835         * auxv.c: Sort headers.
836         * auto-load.c: Sort headers.
837         * arm-wince-tdep.c: Sort headers.
838         * arm-tdep.c: Sort headers.
839         * arm-symbian-tdep.c: Sort headers.
840         * arm-pikeos-tdep.c: Sort headers.
841         * arm-obsd-tdep.c: Sort headers.
842         * arm-nbsd-tdep.c: Sort headers.
843         * arm-nbsd-nat.c: Sort headers.
844         * arm-linux-tdep.c: Sort headers.
845         * arm-linux-nat.c: Sort headers.
846         * arm-fbsd-tdep.c: Sort headers.
847         * arm-fbsd-nat.c: Sort headers.
848         * arm-bsd-tdep.c: Sort headers.
849         * arch-utils.c: Sort headers.
850         * arc-tdep.c: Sort headers.
851         * arc-newlib-tdep.c: Sort headers.
852         * annotate.h: Sort headers.
853         * annotate.c: Sort headers.
854         * amd64-windows-tdep.c: Sort headers.
855         * amd64-windows-nat.c: Sort headers.
856         * amd64-tdep.c: Sort headers.
857         * amd64-sol2-tdep.c: Sort headers.
858         * amd64-obsd-tdep.c: Sort headers.
859         * amd64-obsd-nat.c: Sort headers.
860         * amd64-nbsd-tdep.c: Sort headers.
861         * amd64-nbsd-nat.c: Sort headers.
862         * amd64-nat.c: Sort headers.
863         * amd64-linux-tdep.c: Sort headers.
864         * amd64-linux-nat.c: Sort headers.
865         * amd64-fbsd-tdep.c: Sort headers.
866         * amd64-fbsd-nat.c: Sort headers.
867         * amd64-dicos-tdep.c: Sort headers.
868         * amd64-darwin-tdep.c: Sort headers.
869         * amd64-bsd-nat.c: Sort headers.
870         * alpha-tdep.c: Sort headers.
871         * alpha-obsd-tdep.c: Sort headers.
872         * alpha-nbsd-tdep.c: Sort headers.
873         * alpha-mdebug-tdep.c: Sort headers.
874         * alpha-linux-tdep.c: Sort headers.
875         * alpha-linux-nat.c: Sort headers.
876         * alpha-bsd-tdep.c: Sort headers.
877         * alpha-bsd-nat.c: Sort headers.
878         * aix-thread.c: Sort headers.
879         * agent.c: Sort headers.
880         * addrmap.c: Sort headers.
881         * ada-varobj.c: Sort headers.
882         * ada-valprint.c: Sort headers.
883         * ada-typeprint.c: Sort headers.
884         * ada-tasks.c: Sort headers.
885         * ada-lang.c: Sort headers.
886         * aarch64-tdep.c: Sort headers.
887         * aarch64-ravenscar-thread.c: Sort headers.
888         * aarch64-newlib-tdep.c: Sort headers.
889         * aarch64-linux-tdep.c: Sort headers.
890         * aarch64-linux-nat.c: Sort headers.
891         * aarch64-fbsd-tdep.c: Sort headers.
892         * aarch64-fbsd-nat.c: Sort headers.
893         * aarch32-linux-nat.c: Sort headers.
894
895 2019-04-04  Tom Tromey  <tom@tromey.com>
896
897         * varobj.c (varobj_create): Update.
898         * rust-exp.y (struct rust_parser) <update_innermost_block,
899         lookup_symbol>: New methods.
900         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
901         Rename.
902         (rust_parser::rust_lookup_type)
903         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
904         * printcmd.c (display_command, do_one_display): Update.
905         * parser-defs.h (struct parser_state) <parser_state>: Add
906         "tracker" parameter.
907         (block_tracker): New member.
908         (class innermost_block_tracker) <innermost_block_tracker>: Add
909         "types" parameter.
910         <reset>: Remove method.
911         (innermost_block): Don't declare.
912         (null_post_parser): Update.
913         * parse.c (innermost_block): Remove global.
914         (write_dollar_variable): Update.
915         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
916         Remove "tracker_types" parameter.
917         (parse_expression): Add "tracker" parameter.
918         (parse_expression_for_completion): Update.
919         (null_post_parser): Add "tracker" parameter.
920         * p-exp.y: Update rules.
921         * m2-exp.y: Update rules.
922         * language.h (struct language_defn) <la_post_parser>: Add
923         "tracker" parameter.
924         * go-exp.y: Update rules.
925         * f-exp.y: Update rules.
926         * expression.h (parse_expression, parse_exp_1): Add "tracker"
927         parameter.
928         * d-exp.y: Update rules.
929         * c-exp.y: Update rules.
930         * breakpoint.c (set_breakpoint_condition): Create an
931         innermost_block_tracker.
932         (watch_command_1): Likewise.
933         * ada-lang.c (resolve): Add "tracker" parameter.
934         (resolve_subexp): Likewise.
935         * ada-exp.y (write_var_from_sym): Update.
936
937 2019-04-04  Tom Tromey  <tom@tromey.com>
938
939         * type-stack.h: New file.
940         * type-stack.c: New file.
941         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
942         type-stack.h.
943         (insert_into_type_stack, insert_type, push_type, push_type_int)
944         (insert_type_address_space, pop_type, pop_type_int)
945         (pop_typelist, pop_type_stack, append_type_stack)
946         (push_type_stack, get_type_stack, push_typelist)
947         (follow_type_instance_flags, follow_types): Don't declare.
948         * parse.c (type_stack): Remove global.
949         (parse_exp_in_context): Update.
950         (insert_into_type_stack, insert_type, push_type, push_type_int)
951         (insert_type_address_space, pop_type, pop_type_int)
952         (pop_typelist, pop_type_stack, append_type_stack)
953         (push_type_stack, get_type_stack, push_typelist)
954         (follow_type_instance_flags, follow_types): Remove (moved to
955         type-stack.c).
956         * f-exp.y (type_stack): New global.
957         Update rules.
958         (push_kind_type, f_parse): Update.
959         * d-exp.y (type_stack): New global.
960         Update rules.
961         (d_parse): Update.
962         * c-exp.y (struct c_parse_state) <type_stack>: New member.
963         Update rules.
964         * Makefile.in (COMMON_SFILES): Add type-stack.c.
965         (HFILES_NO_SRCDIR): Add type-stack.h.
966
967 2019-04-04  Tom Tromey  <tom@tromey.com>
968
969         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
970         (rust_parser::convert_ast_to_expression, rust_parse)
971         (rust_lex_test_completion, rust_lex_tests): Update.
972         * parser-defs.h (struct expr_completion_state): New.
973         (struct parser_state) <parser_state>: Add completion parameter.
974         <mark_struct_expression, mark_completion_tag>: New methods.
975         <parse_completion, m_completion_state>: New members.
976         (prefixify_expression, null_post_parser): Update.
977         (mark_struct_expression, mark_completion_tag): Don't declare.
978         * parse.c (parse_completion, expout_last_struct)
979         (expout_tag_completion_type, expout_completion_name): Remove
980         globals.
981         (parser_state::mark_struct_expression)
982         (parser_state::mark_completion_tag): Now methods.
983         (prefixify_expression): Add last_struct parameter.
984         (prefixify_subexp): Likewise.
985         (parse_exp_1): Update.
986         (parse_exp_in_context): Add cstate parameter.  Update.
987         (parse_expression_for_completion): Create an
988         expr_completion_state.
989         (null_post_parser): Add "completion" parameter.
990         * p-exp.y: Update rules.
991         (yylex): Update.
992         * language.h (struct language_defn) <la_post_parser>: Add
993         "completing" parameter.
994         * go-exp.y: Update rules.
995         (lex_one_token): Update.
996         * expression.h (parse_completion): Don't declare.
997         * d-exp.y: Update rules.
998         (lex_one_token): Update rules.
999         * c-exp.y: Update rules.
1000         (lex_one_token): Update.
1001         * ada-lang.c (resolve): Add "parse_completion" parameter.
1002         (resolve_subexp): Likewise.
1003         (ada_resolve_function): Likewise.
1004
1005 2019-04-04  Tom Tromey  <tom@tromey.com>
1006
1007         * parser-defs.h (struct parser_state) <start_arglist,
1008         end_arglist>: New methods.
1009         <arglist_len, m_funcall_chain>: New members.
1010         (arglist_len, start_arglist, end_arglist): Don't declare.
1011         * parse.c (arglist_len, funcall_chain): Remove global.
1012         (start_arglist, end_arglist): Remove functions.
1013         (parse_exp_in_context): Update.
1014         * p-exp.y: Update rules.
1015         * m2-exp.y: Update rules.
1016         * go-exp.y: Update rules.
1017         * f-exp.y: Update rules.
1018         * d-exp.y: Update rules.
1019         * c-exp.y: Update rules.
1020
1021 2019-04-04  Tom Tromey  <tom@tromey.com>
1022
1023         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1024         lex_operator, push_back>: New methods.
1025         Update all rules.
1026         (rust_parser::lex_hex, lex_escape): Rename and update.
1027         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1028         (rust_parser::lex_operator): Rename and update.
1029         (rust_parser::lex_number, rustyylex, rustyyerror)
1030         (rust_lex_test_init, rust_lex_test_sequence)
1031         (rust_lex_test_push_back, rust_lex_tests): Update.
1032         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1033         parameter.
1034         <lexptr, prev_lexptr>: New members.
1035         (lexptr, prev_lexptr): Don't declare.
1036         * parse.c (lexptr, prev_lexptr): Remove globals.
1037         (parse_exp_in_context): Update.
1038         * p-exp.y (yylex, yyerror): Update.
1039         * m2-exp.y (parse_number, yylex, yyerror): Update.
1040         * go-exp.y (lex_one_token, yyerror): Update.
1041         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1042         * d-exp.y (lex_one_token, yyerror): Update.
1043         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1044         (lex_one_token, yyerror): Update.
1045         * ada-lex.l (YY_INPUT): Update.
1046         (rewind_to_char): Update.
1047         * ada-exp.y (yyerror): Update.
1048
1049 2019-04-04  Tom Tromey  <tom@tromey.com>
1050
1051         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1052         * parser-defs.h (struct parser_state) <parser_state>: Add new
1053         parameter.
1054         <comma_terminates>: New member.
1055         (comma_terminates): Don't declare global.
1056         * parse.c (comma_terminates): Remove global.
1057         (parse_exp_in_context): Update.
1058         * p-exp.y (yylex): Update.
1059         * m2-exp.y (yylex): Update.
1060         * go-exp.y (lex_one_token): Update.
1061         * f-exp.y (yylex): Update.
1062         * d-exp.y (lex_one_token): Update.
1063         * c-exp.y (lex_one_token): Update.
1064         * ada-lex.l: Update.
1065
1066 2019-04-04  Tom Tromey  <tom@tromey.com>
1067
1068         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1069         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1070         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1071         * parser-defs.h (paren_depth): Don't declare.
1072         * parse.c (paren_depth): Remove global.
1073         (parse_exp_in_context): Update.
1074         * p-exp.y (paren_depth): New global.
1075         (pascal_parse): Initialize it.
1076         * m2-exp.y (paren_depth): New global.
1077         (m2_parse): Initialize it.
1078         * go-exp.y (paren_depth): New global.
1079         (go_parse): Initialize it.
1080         * f-exp.y (paren_depth): New global.
1081         (f_parse): Initialize it.
1082         * d-exp.y (paren_depth): New global.
1083         (d_parse): Initialize it.
1084         * c-exp.y (paren_depth): New global.
1085         (c_parse): Initialize it.
1086         * ada-lex.l (paren_depth): New global.
1087         (lexer_init): Initialize it.
1088
1089 2019-04-04  Tom Tromey  <tom@tromey.com>
1090
1091         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1092         (rust_parser::convert_ast_to_type)
1093         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1094         * parser-defs.h (struct parser_state) <parser_state>: Add
1095         parameters.  Initialize new members.
1096         <expression_context_block, expression_context_pc>: New members.
1097         * parse.c (expression_context_block, expression_context_pc):
1098         Remove globals.
1099         (parse_exp_in_context): Update.
1100         * p-exp.y: Update all rules.
1101         (yylex): Update.
1102         * m2-exp.y: Update all rules.
1103         (yylex): Update.
1104         * go-exp.y (yylex): Update.
1105         * f-exp.y (yylex): Update.
1106         * d-exp.y: Update all rules.
1107         (yylex): Update.
1108         * c-exp.y: Update all rules.
1109         (lex_one_token, classify_name, yylex, c_parse): Update.
1110         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1111
1112 2019-04-04  Tom Tromey  <tom@tromey.com>
1113
1114         * gdbarch.h, gdbarch.c: Rebuild.
1115         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1116         * stap-probe.h: 
1117         (struct stap_parse_info): Replace "parser_state" with
1118         "expr_builder".
1119         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1120         (parser_state): New class.
1121         * parse.c (expr_builder): Rename.
1122         (expr_builder::release): Rename.
1123         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1124         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1125         (write_exp_elt_longcst, write_exp_elt_floatcst)
1126         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1127         (write_exp_string_vector, write_exp_bitstring)
1128         (write_exp_msymbol, mark_struct_expression)
1129         (write_dollar_variable)
1130         (insert_type_address_space, increase_expout_size): Replace
1131         "parser_state" with "expr_builder".
1132         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1133         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1134         "parser_state" with "expr_builder".
1135
1136 2019-04-04  Tom Tromey  <tom@tromey.com>
1137
1138         * rust-exp.y: Replace "parse_language" with method call.
1139         * p-exp.y: 
1140         (yylex): Replace "parse_language" with method call.
1141         * m2-exp.y: 
1142         (yylex): Replace "parse_language" with method call.
1143         * go-exp.y (classify_name): Replace "parse_language" with method
1144         call.
1145         * f-exp.y (yylex): Replace "parse_language" with method call.
1146         * d-exp.y (lex_one_token): Replace "parse_language" with method
1147         call.
1148         * c-exp.y: 
1149         (lex_one_token, classify_name, yylex): Replace "parse_language"
1150         with method call.
1151         * ada-exp.y (find_primitive_type, type_char)
1152         (type_system_address): Replace "parse_language" with method call.
1153
1154 2019-04-04  Tom Tromey  <tom@tromey.com>
1155
1156         * rust-exp.y: Replace "parse_gdbarch" with method call.
1157         * parse.c (write_dollar_variable, insert_type_address_space):
1158         Replace "parse_gdbarch" with method call.
1159         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1160         call.
1161         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1162         call.
1163         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1164         "parse_gdbarch" with method call.
1165         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1166         with method call.
1167         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1168         "parse_gdbarch" with method call.
1169         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1170         "parse_gdbarch" with method call.
1171         * c-exp.y (parse_type, parse_number, classify_name): Replace
1172         "parse_gdbarch" with method call.
1173         * ada-lex.l: Replace "parse_gdbarch" with method call.
1174         * ada-exp.y (parse_type, find_primitive_type, type_char)
1175         (type_system_address): Replace "parse_gdbarch" with method call.
1176
1177 2019-04-04  Tom Tromey  <tom@tromey.com>
1178
1179         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1180         * stap-probe.c (stap_parse_argument): Update.
1181         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1182         initial_size parameter.
1183         * rust-exp.y (rust_lex_tests): Update.
1184         * parse.c (parser_state): Update.
1185         (parse_exp_in_context): Update.
1186         * parser-defs.h (struct parser_state) <parser_state>: Remove
1187         "initial_size" parameter.
1188
1189 2019-04-04  Tom Tromey  <tom@tromey.com>
1190
1191         * parser-defs.h (increase_expout_size): Don't declare.
1192         * parse.c (increase_expout_size): Now static.
1193
1194 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1195
1196         * gnu-nat.c (gnu_nat_target::wait): Fix
1197         target_waitstatus_to_string call.
1198
1199 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * eval.c (evaluate_subexp_standard): Handle internal functions
1202         during Fortran function call handling.
1203
1204 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * NEWS: Mention new internal functions.
1207         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1208         (read_base_type): Use dwarf2_init_complex_target_type.
1209         * value.c (creal_internal_fn): New function.
1210         (cimag_internal_fn): New function.
1211         (_initialize_values): Register new internal functions.
1212
1213 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1214
1215         * infrun.c (stop_all_threads): If debug_infrun, always
1216         trace the wait status after wait_one, using
1217         target_waitstatus_to_string and target_pid_to_str.
1218         (handle_inferior_event): Replace various trace of
1219         wait status kind by a single trace.
1220         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1221         wait status kind image by target_waitstatus_to_string.
1222         * target/waitstatus.c (target_waitstatus_to_string): Fix
1223         obsolete comment.
1224
1225 2019-04-01  Tom Tromey  <tromey@adacore.com>
1226
1227         PR symtab/23331:
1228         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1229
1230 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1231             Pedro Alves  <palves@redhat.com>
1232
1233         * top.c (quit_force): Call 'finalize_values'.
1234         * value.c (finalize_values): New function.
1235         * value.h (finalize_values): Declare.
1236
1237 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1238
1239         * NEWS: Announce $_gdb_major and $_gdb_minor.
1240
1241         * top.c (init_gdb_version_vars): New function.
1242         (gdb_init): Call init_gdb_version_vars.
1243
1244 2019-03-29  Tom Tromey  <tromey@adacore.com>
1245
1246         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1247         help text.  Remove dead code.
1248
1249 2019-03-29  Keith Seitz  <keiths@redhat.com>
1250
1251         From Siddhesh Poyarekar:
1252         * f-lang.h (f77_get_upperbound): Return LONGEST.
1253         (f77_get_lowerbound): Likewise.
1254         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1255         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1256         print them.
1257         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1258         plongest to format print it.
1259         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1260         (f77_get_upperbound): Likewise.
1261         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1262         LOWER_BOUND to LONGEST.
1263         (f77_create_arrayprint_offset_tbl): Likewise.
1264
1265 2019-03-29  Keith Seitz  <keiths@redhat.com>
1266
1267         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1268         %s/pulongest for TYPE_LENGTH instead of %d in format
1269         strings.
1270         * ada-typerint.c (ada_print_type): Likewise.
1271         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1272         * compile/compile-c-support.c (generate_register_struct): Likewise.
1273         * gdbtypes.c (recursive_dump_type): Likewise.
1274         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1275         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1276         instead of %d in format strings.
1277         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1278         to std::min to ULONGEST.
1279         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1280         instead of %d in format strings.
1281         * tracepoint.c (info_scope_command): Likewise.
1282         * typeprint.c (print_offset_data::update)
1283         (print_offset_data::finish): Likewise.
1284         * xtensa-tdep.c (xtensa_store_return_value)
1285         (xtensa_push_dummy_call): Likewise.
1286
1287 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1288
1289         * windows-nat.c (display_selector): Fixed format specifications
1290         for 64-bit Cygwin.
1291
1292 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1293
1294         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1295
1296 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1297
1298         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1299         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1300         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1301         (nios2_linux_init_abi): Install it.
1302
1303 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1304
1305         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1306
1307 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1310
1311 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1312             Tom Tromey  <tromey@adacore.com>
1313
1314         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1315
1316 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1317
1318         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1319         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1320         method to compute the bounds of range types. Also print "[evaluated]"
1321         if the bounds' values come from a dynamic evaluation.
1322
1323 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1326         whitespace when pretty printing is on.
1327
1328 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1329
1330         * ppc-linux-nat.c: Add include.
1331
1332 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1333
1334         * NEWS: Mention AArch64 Pointer Authentication.
1335
1336 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1337
1338         * arm-linux-nat.c: Add include.
1339
1340 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1341
1342         * source-cache.c (source_cache::get_source_lines): Re-read
1343         fullname after calling open_source_file.
1344
1345 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1346
1347         * NEWS: Mention TLS support for FreeBSD.
1348
1349 2019-03-25  Tom Tromey  <tromey@adacore.com>
1350
1351         * minsyms.c (BUNCH_SIZE): Update comment.
1352         (~minimal_symbol_reader): Remove old comment.
1353         (compact_minimal_symbols): Update comment.
1354         (minimal_symbol_reader::install): Remove old comment.  Update
1355         other comments.
1356
1357 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1358
1359         * s390-linux-nat.c: Add include.
1360
1361 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1362
1363         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1364         Call linux_get_hwcap.
1365         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1366         Likewise.
1367         (aarch64_linux_get_hwcap): Remove function.
1368         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1369         declaration.
1370         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1371         linux_get_hwcap.
1372         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1373         * linux-tdep.c (linux_get_hwcap): Add function.
1374         (linux_get_hwcap2): Likewise.
1375         * linux-tdep.h (linux_get_hwcap): Add declaration.
1376         (linux_get_hwcap2): Likewise.
1377         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1378         (ppc_linux_get_hwcap2): Likewise.
1379         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1380         linux_get_hwcap.
1381         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1382         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1383         (ppc_linux_nat_target::read_description): Likewise.
1384         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1385         * s390-linux-nat.c: Likewise.
1386         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1387
1388 2019-03-24  Tom Tromey  <tom@tromey.com>
1389
1390         * ada-lang.c (standard_lookup): Simplify initialization.
1391         (ada_lookup_symbol_nonlocal): Simplify return.
1392         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1393         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1394         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1395         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1396         initialization.
1397         * solib.c (solib_global_lookup): Simplify.
1398         * symtab.c (null_block_symbol): Remove.
1399         (symbol_cache_lookup): Simplify returns.
1400         (lookup_language_this): Simplify returns.
1401         (lookup_symbol_aux): Simplify return.
1402         (lookup_local_symbol): Simplify returns.
1403         (lookup_global_symbol_from_objfile): Simplify return.
1404         (lookup_symbol_in_objfile_symtabs)
1405         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1406         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1407         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1408         * cp-namespace.c (cp_lookup_bare_symbol)
1409         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1410         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1411         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1412         (cp_lookup_symbol_via_imports): Simplify initialization.
1413         (find_symbol_in_baseclass): Likewise.
1414         * symtab.h (null_block_symbol): Remove.
1415         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1416         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1417         (d_lookup_symbol_module): Likewise.
1418         (find_symbol_in_baseclass): Simplify initialization.
1419
1420 2019-03-24  Tom Tromey  <tom@tromey.com>
1421
1422         * expression.h: Don't include symtab.h.
1423         (struct block): Forward declare.
1424
1425 2019-03-24  Tom Tromey  <tom@tromey.com>
1426
1427         * c-exp.y (typebase): Remove casts.
1428         * gdbtypes.c (lookup_unsigned_typename, )
1429         (lookup_signed_typename): Remove cast.
1430         * eval.c (parse_to_comma_and_eval): Remove cast.
1431         * parse.c (write_dollar_variable): Remove cast.
1432         * block.h (struct block) <superblock>: Now const.
1433         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1434         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1435         (map_block): Make "block" const.
1436         * symfile.h (struct quick_symbol_functions)
1437         <map_matching_symbols>: Constify block argument to "callback".
1438         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1439         const.
1440         (find_pc_sect_compunit_symtab): Make "b" const.
1441         (find_symbol_at_address): Likewise.
1442         (search_symbols): Likewise.
1443         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1444         (dw2_debug_names_lookup_symbol): Likewise.
1445         (dw2_map_matching_symbols): Update.
1446         * p-valprint.c (pascal_val_print): Remove "block".
1447         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1448         (aux_add_nonlocal_symbols): Make "block" const.
1449         (resolve_subexp): Remove cast.
1450         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1451         const.
1452         (iterate_over_file_blocks): Likewise.
1453         * f-exp.y (%union) <bval>: Remove.
1454         * coffread.c (patch_opaque_types): Make "b" const.
1455         * spu-tdep.c (spu_catch_start): Make "block" const.
1456         * c-valprint.c (print_unpacked_pointer): Remove "block".
1457         * symmisc.c (dump_symtab_1): Make "b" const.
1458         (block_depth): Make "block" const.
1459         * d-exp.y (%union) <bval>: Remove.
1460         * cp-support.h (cp_lookup_rtti_type): Update.
1461         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1462         * psymtab.c (psym_lookup_symbol): Make "block" const.
1463         (maintenance_check_psymtabs): Make "b" const.
1464         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1465         (enumerate_locals, enumerate_args): Update.
1466         * python/py-symtab.c (stpy_global_block): Make "block" const.
1467         (stpy_static_block): Likewise.
1468         * inline-frame.c (block_starting_point_at): Make "new_block"
1469         const.
1470         * block.c (find_block_in_blockvector): Make return type const.
1471         (blockvector_for_pc_sect): Make "b" const.
1472         (find_block_in_blockvector): Make "b" const.
1473
1474 2019-03-23  Tom Tromey  <tom@tromey.com>
1475
1476         * varobj.c (varobj_create): Update.
1477         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1478         * printcmd.c (display_command, do_one_display): Don't reset
1479         innermost_block.
1480         * parser-defs.h (enum innermost_block_tracker_type): Move to
1481         expression.h.
1482         (innermost_block): Update comment.
1483         * parse.c (parse_exp_1): Add tracker_types parameter.
1484         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1485         tracker_types parameter.  Reset innermost_block.
1486         (parse_exp_in_context): Remove.
1487         (parse_expression_for_completion): Update.
1488         * objfiles.c (~objfile): Don't reset expression_context_block or
1489         innermost_block.
1490         * expression.h (enum innermost_block_tracker_type): Move from
1491         parser-defs.h.
1492         (parse_exp_1): Add tracker_types parameter.
1493         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1494         reset innermost_block.
1495
1496 2019-03-23  Tom Tromey  <tom@tromey.com>
1497
1498         * objfiles.h: Include bcache.h.
1499
1500 2019-03-23  Tom Tromey  <tom@tromey.com>
1501
1502         * linespec.c (get_current_search_block): Use
1503         scoped_restore_current_language.
1504         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1505
1506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1507             Jiong Wang  <jiong.wang@arm.com>
1508
1509         * aarch64-linux-tdep.c
1510         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1511         section.
1512         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1513
1514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1515             Jiong Wang  <jiong.wang@arm.com>
1516
1517         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1518         instructions.
1519         (aarch64_analyze_prologue_test): Add PACIASP test.
1520         (aarch64_prologue_prev_register): Unmask PC value.
1521
1522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1523             Jiong Wang  <jiong.wang@arm.com>
1524
1525         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1526         (aarch64_dwarf2_prev_register): Unmask PC value.
1527         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1528         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1529         DW_CFA_AARCH64_negate_ra_state.
1530         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1531
1532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1533             Jiong Wang  <jiong.wang@arm.com>
1534
1535         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1536         registers.
1537         (aarch64_pseudo_register_name): Likewise.
1538         (aarch64_pseudo_register_type): Likewise.
1539         (aarch64_pseudo_register_reggroup_p): Likewise.
1540         (aarch64_gdbarch_init): Add pauth registers.
1541         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1542         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1543         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1544         (struct gdbarch_tdep): Add regnum for ra_state.
1545
1546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1547             Jiong Wang  <jiong.wang@arm.com>
1548
1549         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1550
1551 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1552             Jiong Wang  <jiong.wang@arm.com>
1553
1554         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1555         function.
1556         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1557         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1558         (aarch64_gdbarch_init): Add puth registers.
1559         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1560         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1561         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1562
1563 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1564             Jiong Wang  <jiong.wang@arm.com>
1565
1566         * aarch64-linux-nat.c
1567         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1568         * aarch64-linux-tdep.c
1569         (aarch64_linux_core_read_description): Likewise.
1570         (aarch64_linux_get_hwcap): New function.
1571         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1572         (aarch64_linux_get_hwcap): New declaration.
1573
1574 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1575             Jiong Wang  <jiong.wang@arm.com>
1576
1577         * aarch64-linux-nat.c
1578         (aarch64_linux_nat_target::read_description): Add pauth param.
1579         * aarch64-linux-tdep.c
1580         (aarch64_linux_core_read_description): Likewise.
1581         * aarch64-tdep.c (struct target_desc): Add in pauth.
1582         (aarch64_read_description): Add pauth param.
1583         (aarch64_gdbarch_init): Likewise.
1584         * aarch64-tdep.h (aarch64_read_description): Likewise.
1585         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1586         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1587         * features/Makefile: Add new files.
1588         * features/aarch64-pauth.c: New file.
1589         * features/aarch64-pauth.xml: New file.
1590
1591 2019-03-20  Tom Tromey  <tromey@adacore.com>
1592
1593         * infrun.c (handle_inferior_event): Rename from
1594         handle_inferior_event_1.  Create a scoped_value_mark.
1595         (handle_inferior_event): Remove.
1596
1597 2019-03-19  Tom Tromey  <tromey@adacore.com>
1598
1599         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1600         * infrun.h (print_stop_event): Add "displays" parameter.
1601         * infrun.c (print_stop_event): Add "displays" parameter.
1602
1603 2019-03-19  Pedro Alves  <palves@redhat.com>
1604
1605         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1606         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1607         to -1.  Fix TABs vs spaces.
1608         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1609         * tui/tui-out.h (tui_ui_out) Add intro comments.
1610         <m_line, m_start_of_line>: In-class initialize, and add describing
1611         comment.
1612
1613 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1616         variable names.
1617         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1618
1619 2019-03-18  Pedro Alves  <palves@redhat.com>
1620             Eli Zaretskii <eliz@gnu.org>
1621
1622         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1623         m_line and m_start_of_line.
1624
1625 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1626
1627         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1628         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1629         it returns a newline.  This fixes a regression in TU mode, whereby
1630         the next line is output on the same screen line as the user input.
1631
1632 2019-03-18  Tom Tromey  <tromey@adacore.com>
1633
1634         * minsyms.c (minimal_symbol_reader::install): Remove call to
1635         obstack_blank.
1636
1637 2019-03-18  Pedro Alves  <palves@redhat.com>
1638
1639         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1640         New globals.
1641         (apply_style): New, factored out from ...
1642         (apply_ansi_escape): ... this.  Handle reverse video mode.
1643         (tui_set_reverse_mode): New function.
1644         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1645         * tui/tui-winsource.c (tui_show_source_line): Use
1646         tui_set_reverse_mode instead of setting A_STANDOUT.
1647         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1648         New setter methods.
1649
1650 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1651
1652         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1653         Handle tabs.
1654
1655 2019-03-18  Tom Tromey  <tromey@adacore.com>
1656
1657         * ada-lang.c (empty_array): Add "high" parameter.
1658         (ada_evaluate_subexp): Update.
1659
1660 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1661
1662         * unittests/string_view-selftests.c: Define
1663         _initialize_string_view_selftests unconditionally.
1664
1665 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1666
1667         PR gdb/24350
1668         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1669
1670 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1671
1672         PR gdb/24351
1673         * windows-nat.c (display_selector): Fix format specifiers.
1674
1675 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1676
1677         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1678         tui_refill_source_window instead of tui_refresh_win, to update the
1679         current execution line.  This fixes redisplay of the current line
1680         when stepping through the code with "next" or "step".
1681
1682 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1683
1684         * source-cache.c (source_cache::get_source_lines): Call
1685         find_source_lines to initialize s->nlines.  This fixes vertical
1686         scrolling of TUI source window when the DOWN arrow is pressed.
1687
1688 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1689
1690         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1691         linux-thread-db.c (_initialize_thread_db): Likewise.
1692
1693 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1694
1695         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1696         wclrtoeol in tui_show_source_line".  This reverts changes made in
1697         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1698
1699 2019-03-15  Tom Tromey  <tom@tromey.com>
1700
1701         * symtab.h (struct minimal_symbol): Derive from
1702         general_symbol_info.
1703         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1704         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1705         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1706         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1707         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1708         (MSYMBOL_SEARCH_NAME): Update.
1709         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1710         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1711         * minsyms.c (minimal_symbol_reader::record_full): Update.
1712
1713 2019-03-15  Tom Tromey  <tom@tromey.com>
1714
1715         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1716
1717 2019-03-15  Tom Tromey  <tom@tromey.com>
1718
1719         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1720         unique_xmalloc_ptr.
1721         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1722         Update.
1723         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1724         (build_minimal_symbol_hash_tables)
1725         (minimal_symbol_reader::install): Update.
1726
1727 2019-03-15  Tom Tromey  <tom@tromey.com>
1728
1729         * symtab.c (create_demangled_names_hash): Update.
1730         (symbol_set_names): Update.
1731         * objfiles.h (struct objfile_per_bfd_storage)
1732         <demangled_names_hash>: Now an htab_up.
1733         * objfiles.c (objfile_per_bfd_storage): Simplify.
1734
1735 2019-03-15  Tom Tromey  <tom@tromey.com>
1736
1737         * objfiles.h (struct objfile_per_bfd_storage): Declare
1738         destructor.
1739         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1740         New.
1741         (get_objfile_bfd_data): Use new.  Don't initialize
1742         language_of_main.
1743         (free_objfile_per_bfd_storage): Remove.
1744         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1745
1746 2019-03-15  Tom Tromey  <tom@tromey.com>
1747
1748         * symfile.c (reread_symbols): Update.
1749         * objfiles.c (objfile::objfile): Update.
1750         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1751         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1752         comment.
1753         (minimal_symbol_reader::install): Update.
1754         (terminate_minimal_symbol_table): Remove.
1755         * jit.c (jit_object_close_impl): Update.
1756
1757 2019-03-15  Tom Tromey  <tom@tromey.com>
1758
1759         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1760         initializations.
1761
1762 2019-03-15  Tom Tromey  <tom@tromey.com>
1763
1764         * objfiles.h (struct objfile_per_bfd_storage)
1765         <demangled_hash_languages>: Now a bitset.
1766         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1767         (lookup_minimal_symbol): Update.
1768
1769 2019-03-15  Tom Tromey  <tom@tromey.com>
1770
1771         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1772         Don't return the symbol.
1773         * coffread.c (record_minimal_symbol): Use record_full.
1774
1775 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1776
1777         The MS-Windows port of ncurses fails to switch to a color pair if
1778         one or both of the colors are the implicit default colors.  This
1779         change records the default colors when TUI is initialized, and
1780         then specifies them explicitly when a color pair uses the default
1781         colors.  This allows color styling in TUI mode on MS-Windows.
1782
1783         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1784         ncurses_norm_attr.
1785         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1786         colors in ncurses_norm_attr.
1787         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1788         "none", replace it with the default color recorded in
1789         ncurses_norm_attr.
1790
1791 2019-03-14  Tom Tromey  <tromey@adacore.com>
1792
1793         * source-cache.h (class source_cache) <get_source_lines>: Return
1794         std::string.
1795         * source-cache.c (source_cache::extract_lines): Handle case where
1796         first_pos==npos.  Return std::string.
1797         (source_cache::get_source_lines): Update.
1798
1799 2019-03-14  Tom Tromey  <tromey@adacore.com>
1800
1801         * NEWS: Add item for "style sources" commands.
1802         * source-cache.c (source_cache::get_source_lines): Check
1803         source_styling.
1804         * cli/cli-style.c (source_styling): New global.
1805         (_initialize_cli_style): Add "style sources" commands.
1806         (show_style_sources): New function.
1807         * cli/cli-style.h (source_styling): Declare.
1808
1809 2019-03-14  Pedro Alves  <palves@redhat.com>
1810             Tom Tromey  <tromey@adacore.com>
1811
1812         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1813         * tui/tui-winsource.c (tui_refill_source_window): New function,
1814         from...
1815         (tui_horizontal_source_scroll): ... here.  Move some logic.
1816         * cli/cli-style.c (set_style_enabled): Notify new observable.
1817         * tui/tui-hooks.c (tui_redisplay_source): New function.
1818         (tui_attach_detach_observers): Attach or detach
1819         tui_redisplay_source.
1820         * observable.h (source_styling_changed): New observable.
1821         * observable.c: Define source_styling_changed observable.
1822
1823 2019-03-13  Tom Tromey  <tromey@adacore.com>
1824
1825         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1826         (i386_gnu_nat_target::store_registers): Update.
1827         * target-debug.h (target_debug_print_std_string): New macro.
1828         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1829         * windows-tdep.c (display_one_tib): Update.
1830         * tui/tui-stack.c (tui_make_status_line): Update.
1831         * top.c (print_inferior_quit_action): Update.
1832         * thread.c (thr_try_catch_cmd): Update.
1833         (add_thread_with_info): Update.
1834         (thread_target_id_str): Update.
1835         (thr_try_catch_cmd): Update.
1836         (thread_command): Update.
1837         (thread_find_command): Update.
1838         * record-btrace.c (record_btrace_target::info_record)
1839         (record_btrace_resume_thread, record_btrace_target::resume)
1840         (record_btrace_cancel_resume, record_btrace_step_thread)
1841         (record_btrace_target::wait, record_btrace_target::wait)
1842         (record_btrace_target::wait, record_btrace_target::stop): Update.
1843         * progspace.c (print_program_space): Update.
1844         * process-stratum-target.c
1845         (process_stratum_target::thread_address_space): Update.
1846         * linux-fork.c (linux_fork_mourn_inferior)
1847         (detach_checkpoint_command, info_checkpoints_command)
1848         (linux_fork_context): Update.
1849         (linux_fork_detach): Update.
1850         (class scoped_switch_fork_info): Update.
1851         (delete_checkpoint_command): Update.
1852         * infrun.c (follow_fork_inferior): Update.
1853         (follow_fork_inferior): Update.
1854         (proceed_after_vfork_done): Update.
1855         (handle_vfork_child_exec_or_exit): Update.
1856         (follow_exec): Update.
1857         (displaced_step_prepare_throw): Update.
1858         (displaced_step_restore): Update.
1859         (start_step_over): Update.
1860         (resume_1): Update.
1861         (clear_proceed_status_thread): Update.
1862         (proceed): Update.
1863         (print_target_wait_results): Update.
1864         (do_target_wait): Update.
1865         (context_switch): Update.
1866         (stop_all_threads): Update.
1867         (restart_threads): Update.
1868         (finish_step_over): Update.
1869         (handle_signal_stop): Update.
1870         (switch_back_to_stepped_thread): Update.
1871         (keep_going_pass_signal): Update.
1872         (print_exited_reason): Update.
1873         (normal_stop): Update.
1874         * inferior.c (inferior_pid_to_str): Change return type.
1875         (print_selected_inferior): Update.
1876         (add_inferior): Update.
1877         (detach_inferior): Update.
1878         * dummy-frame.c (fprint_dummy_frames): Update.
1879         * dcache.c (dcache_info_1): Update.
1880         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1881         (btrace_fetch, btrace_clear): Update.
1882         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1883         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1884         type.
1885         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1886         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1887         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1888         * gdbarch.c, gdbarch.h: Rebuild.
1889         * gdbarch.sh (core_pid_to_str): Change return type.
1890         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1891         return type.
1892         (windows_nat_target::pid_to_str): Change return type.
1893         (windows_delete_thread): Update.
1894         (windows_nat_target::attach): Update.
1895         (windows_nat_target::files_info): Update.
1896         * target-delegates.c: Rebuild.
1897         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1898         return type.
1899         (sol_thread_target::pid_to_str): Change return type.
1900         * remote.c (class remote_target) <pid_to_str>: Change return
1901         type.
1902         (remote_target::pid_to_str): Change return type.
1903         (extended_remote_target::attach, remote_target::remote_stop_ns)
1904         (remote_target::remote_notif_remove_queued_reply)
1905         (remote_target::push_stop_reply, remote_target::disable_btrace):
1906         Update.
1907         (extended_remote_target::attach): Update.
1908         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1909         type.
1910         (gdbsim_target::pid_to_str): Change return type.
1911         * ravenscar-thread.c (struct ravenscar_thread_target)
1912         <pid_to_str>: Change return type.
1913         (ravenscar_thread_target::pid_to_str): Change return type.
1914         * procfs.c (class procfs_target) <pid_to_str>: Change return
1915         type.
1916         (procfs_target::pid_to_str): Change return type.
1917         (procfs_target::attach): Update.
1918         (procfs_target::detach): Update.
1919         (procfs_target::fetch_registers): Update.
1920         (procfs_target::store_registers): Update.
1921         (procfs_target::wait): Update.
1922         (procfs_target::files_info): Update.
1923         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1924         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1925         return type.
1926         (nto_procfs_target::pid_to_str): Change return type.
1927         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1928         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1929         return type.
1930         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1931         (exit_lwp): Update.
1932         (attach_proc_task_lwp_callback, get_detach_signal)
1933         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1934         (linux_nat_target::resume, wait_lwp, stop_callback)
1935         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1936         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1937         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1938         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1939         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1940         type.
1941         (inf_ptrace_target::attach): Update.
1942         (inf_ptrace_target::files_info): Update.
1943         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1944         type.
1945         (go32_nat_target::pid_to_str): Change return type.
1946         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1947         (gnu_nat_target::wait): Update.
1948         (gnu_nat_target::wait): Update.
1949         (gnu_nat_target::resume): Update.
1950         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1951         (fbsd_nat_target::wait): Update.
1952         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1953         type.
1954         (darwin_nat_target::attach): Update.
1955         * corelow.c (class core_target) <pid_to_str>: Change return type.
1956         (core_target::pid_to_str): Change return type.
1957         * target.c (normal_pid_to_str): Change return type.
1958         (default_pid_to_str): Likewise.
1959         (target_pid_to_str): Change return type.
1960         (target_translate_tls_address): Update.
1961         (target_announce_detach): Update.
1962         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1963         return type.
1964         (bsd_uthread_target::pid_to_str): Change return type.
1965         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1966         type.
1967         (bsd_kvm_target::pid_to_str): Change return type.
1968         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1969         return type.
1970         (aix_thread_target::pid_to_str): Change return type.
1971         * target.h (struct target_ops) <pid_to_str>: Change return type.
1972         (target_pid_to_str, normal_pid_to_str): Likewise.
1973         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1974         type.
1975         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1976         type.
1977         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1978         return type.
1979         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1980         type.
1981         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1982         type.
1983         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1984         return type.
1985
1986 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1987
1988         * NEWS: Mention that the new default MI version is 3.  Mention
1989         changes to the output of commands and events that deal with
1990         multi-location breakpoints.
1991         * breakpoint.c: Include "mi/mi-out.h".
1992         (print_one_breakpoint): Change output syntax if using MI version
1993         >= 3.
1994         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1995         New.
1996         (mi_multi_location_breakpoint_output_fixed): New.
1997         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1998         (mi_cmd_fix_multi_location_breakpoint_output): New.
1999         (mi_multi_location_breakpoint_output_fixed): New.
2000         * mi/mi-cmds.c (mi_cmds): Register command
2001         -fix-multi-location-breakpoint-output.
2002         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2003         interpreter "mi".
2004
2005 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2006
2007         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2008         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2009         instantiate mi_ui_out based on interpreter name.
2010         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2011         * mi/mi-main.c (mi_load_progress): Likewise.
2012
2013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2014
2015         * NEWS: Combine separate "New targets" sections for 8.3.
2016
2017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2018
2019         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2020         (ppcfbsd_init_abi): Install gdbarch
2021         "fetch_tls_load_module_address" and "get_thread_local_address"
2022         methods.
2023
2024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2025
2026         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2027         (riscv_fbsd_init_abi): Install gdbarch
2028         "fetch_tls_load_module_address" and "get_thread_local_address"
2029         methods.
2030
2031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2032
2033         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2034         (i386fbsd_init_abi): Install gdbarch
2035         "fetch_tls_load_module_address" and "get_thread_local_address"
2036         methods.
2037
2038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2039
2040         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2041         (amd64fbsd_init_abi): Install gdbarch
2042         "fetch_tls_load_module_address" and "get_thread_local_address"
2043         methods.
2044
2045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2046
2047         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2048         (struct fbsd_pspace_data): New type.
2049         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2050         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2051         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2052         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2053         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2054
2055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2056
2057         * gdbtypes.c (lookup_struct_elt): New function.
2058         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2059         * gdbtypes.h (struct struct_elt): New type.
2060         (lookup_struct_elt): New prototype.
2061
2062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2063
2064         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2065         remove disabled code block.
2066
2067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2068
2069         * gdbarch.sh (get_thread_local_address): New method.
2070         * gdbarch.h, gdbarch.c: Regenerate.
2071         * target.c (target_translate_tls_address): Use
2072         gdbarch_get_thread_local_address if present instead of
2073         target::get_thread_local_address.
2074
2075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2076
2077         * target.h (target::get_thread_local_address): Update comment.
2078
2079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2080
2081         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2082         objfile->separate_debug_objfile_backlink if not NULL.
2083
2084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2085
2086         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2087         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2088         (amd64bsd_store_inferior_registers): Likewise.
2089         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2090         Enable segment base registers.
2091         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2092         PT_GETFSBASE and PT_GETGSBASE.
2093         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2094         PT_SETGSBASE.
2095         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2096         segment base registers.
2097         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2098
2099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2100
2101         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2102         Update calls to i386_target_description to add 'segments'
2103         parameter.
2104         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2105         add segment base registers.
2106         * arch/i386.c (i386_create_target_description): Add 'segments'
2107         parameter to enable segment base registers.
2108         * arch/i386.h (i386_create_target_description): Likewise.
2109         * features/i386/32bit-segments.xml: New file.
2110         * features/i386/32bit-segments.c: Generate.
2111         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2112         call to i386_target_description to add 'segments' parameter.
2113         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2114         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2115         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2116         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2117         if feature is present.
2118         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2119         Add 'segments' parameter to call to i386_target_description.
2120         (i386_target_description): Add 'segments' parameter to enable
2121         segment base registers.
2122         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2123         to call to i386_target_description.
2124         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2125         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2126         Define I386_NUM_REGS.
2127         (i386_target_description): Add 'segments' parameter to enable
2128         segment base registers.
2129
2130 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2131
2132         PR/24325
2133         * source-cache.c: #undef open and close, to avoid unresolved
2134         externals during linking.
2135
2136 2019-03-12  Tom Tromey  <tromey@adacore.com>
2137
2138         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2139         const.  Add initializers.
2140         (_initialize_remote): Don't initialize ptid globals.
2141
2142 2019-03-12  Pedro Alves  <palves@redhat.com>
2143
2144         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2145
2146 2019-03-12  Pedro Alves  <palves@redhat.com>
2147
2148         * cp-name-parser.y (main): Remove unused 'len' variable.
2149
2150 2019-03-12  Tom Tromey  <tromey@adacore.com>
2151
2152         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2153         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2154
2155 2019-03-12  Tom Tromey  <tromey@adacore.com>
2156
2157         * linux-nat.c (iterate_over_lwps): Update.
2158         (stop_callback): Remove parameter.
2159         (stop_wait_callback, detach_callback, resume_set_callback)
2160         (select_singlestep_lwp_callback, set_ignore_sigint)
2161         (status_callback, resumed_callback, resume_clear_callback)
2162         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2163         data parameter.
2164         (linux_nat_target::detach, linux_nat_target::resume)
2165         (linux_stop_and_wait_all_lwps, select_event_lwp)
2166         (linux_nat_filter_event, linux_nat_wait_1)
2167         (linux_nat_target::kill, linux_nat_target::stop)
2168         (linux_nat_target::stop): Update.
2169         (linux_nat_resume_callback): Change type.
2170         (resume_stopped_resumed_lwps, count_events_callback)
2171         (select_event_lwp_callback): Likewise.
2172         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2173         * arm-linux-nat.c (struct update_registers_data): Remove.
2174         (update_registers_callback): Change type.
2175         (arm_linux_insert_hw_breakpoint1): Update.
2176         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2177         parameter.
2178         (x86_linux_dr_set_addr): Update.
2179         (x86_linux_dr_set_control): Update.
2180         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2181         (iterate_over_lwps): Use gdb::function_view.
2182         * nat/aarch64-linux-hw-point.c (struct
2183         aarch64_dr_update_callback_param): Remove.
2184         (debug_reg_change_callback): Change type.
2185         (aarch64_notify_debug_reg_change): Update.
2186         * s390-linux-nat.c (s390_refresh_per_info): Update.
2187
2188 2019-03-11  Tom Tromey  <tromey@adacore.com>
2189
2190         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2191         redundant assignment to "this_cu".
2192
2193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2194
2195         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2196
2197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2198
2199         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2200         from...
2201         (rank_one_type): ... this.
2202
2203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2204
2205         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2206         from...
2207         (rank_one_type): ... this.
2208
2209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2210
2211         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2212         from...
2213         (rank_one_type): ... this.
2214
2215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2216
2217         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2218         from...
2219         (rank_one_type): ... this.
2220
2221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2222
2223         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2224         from...
2225         (rank_one_type): ... this.
2226
2227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2228
2229         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2230         from...
2231         (rank_one_type): ... this.
2232
2233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2234
2235         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2236         from...
2237         (rank_one_type): ... this.
2238
2239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2240
2241         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2242         from...
2243         (rank_one_type): ... this.
2244
2245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2246
2247         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2248         from...
2249         (rank_one_type): ... this.
2250
2251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2252
2253         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2254         from...
2255         (rank_one_type): ... this.
2256
2257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2258
2259         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2260         from...
2261         (rank_one_type): ... this.
2262
2263 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2264
2265         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2266         from...
2267         (rank_one_type): ... this.
2268
2269 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2270
2271         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2272         inferior-events' shows the example events.
2273
2274 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2275
2276         Support styling on native MS-Windows console
2277
2278         PR/24315
2279         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2280         on MS-Windows if $TERM is not defined.
2281
2282         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2283
2284         * posix-hdep.c (gdb_console_fputs):
2285         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2286         functions.
2287         * ui-file.h (gdb_console_fputs): Add prototype.
2288
2289         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2290         back to fputs only if the former returns zero.
2291
2292 2019-03-07  Tom Tromey  <tom@tromey.com>
2293
2294         * symmisc.c (print_symbol_bcache_statistics): Update.
2295         (print_objfile_statistics): Update.
2296         * symfile.c (allocate_symtab): Update.
2297         * stabsread.c: Don't include bcache.h.
2298         * psymtab.h (struct psymbol_bcache): Don't declare.
2299         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2300         (psymbol_bcache_init, psymbol_bcache_free)
2301         (psymbol_bcache_get_bcache): Don't declare.
2302         * psymtab.c (struct psymbol_bcache): Remove.
2303         (psymtab_storage::psymtab_storage): Update.
2304         (psymtab_storage::~psymtab_storage): Update.
2305         (psymbol_bcache_init, psymbol_bcache_free)
2306         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2307         (add_psymbol_to_bcache): Update.
2308         (allocate_psymtab): Update.
2309         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2310         macro_cache>: No longer pointers.
2311         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2312         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2313         * macrotab.c (macro_bcache): Update.
2314         * macroexp.c: Don't include bcache.h.
2315         * gdbtypes.c (check_types_worklist): Update.
2316         (types_deeply_equal): Remove TRY/CATCH.  Update.
2317         * elfread.c (elf_symtab_read): Update.
2318         * dwarf2read.c: Don't include bcache.h.
2319         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2320         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2321         (print_bcache_statistics, bcache_memory_used): Don't declare.
2322         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2323         methods.  Rename all data members.
2324         * bcache.c (struct bcache): Move to bcache.h.
2325         (bcache::expand_hash_table): Rename from expand_hash_table.
2326         (bcache): Remove.
2327         (bcache::insert): Rename from bcache_full.
2328         (bcache::compare): Rename from bcache_compare.
2329         (bcache_xmalloc): Remove.
2330         (bcache::~bcache): Rename from bcache_xfree.
2331         (bcache::print_statistics): Rename from print_bcache_statistics.
2332         (bcache::memory_used): Rename from bcache_memory_used.
2333
2334 2019-03-07  Pedro Alves  <palves@redhat.com>
2335
2336         * infrun.c (normal_stop): Also check for
2337         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2338
2339 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * f-lang.c (value_from_host_double): Moved to...
2342         * value.c (value_from_host_double): ...here.
2343         * value.h (value_from_host_double): Declare.
2344         * guile/scm-math.c (vlscm_convert_typed_number): Use
2345         value_from_host_double.
2346         (vlscm_convert_number): Likewise.
2347         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2348         * python/py-value.c (convert_value_from_python): Likewise.
2349
2350 2019-03-06  Tom Tromey  <tom@tromey.com>
2351
2352         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2353
2354 2019-03-06  Tom Tromey  <tom@tromey.com>
2355
2356         * utils.h (free_current_contents): Don't declare.
2357         * utils.c (free_current_contents): Remove.
2358
2359 2019-03-06  Tom Tromey  <tom@tromey.com>
2360
2361         * top.c (quit_force): Update.
2362         * main.c (captured_command_loop): Update.
2363         * common/new-op.c (operator new): Update.
2364         * common/common-exceptions.c (struct catcher)
2365         <save_cleanup_chain>: Remove member.
2366         (exceptions_state_mc_init): Update.
2367         (exception_try_scope_entry): Return nullptr.
2368         (exception_try_scope_exit, exception_rethrow)
2369         (throw_exception_sjlj, throw_exception_cxx): Update.
2370         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2371         (all_cleanups, do_cleanups, discard_cleanups)
2372         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2373         (restore_cleanups, restore_final_cleanups): Don't declare.
2374         (do_final_cleanups): Remove parameter.
2375         * common/cleanups.c (cleanup_chain, make_cleanup)
2376         (make_cleanup_dtor, all_cleanups, do_cleanups)
2377         (discard_my_cleanups, discard_cleanups)
2378         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2379         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2380         (null_cleanup): Remove.
2381         (do_final_cleanups): Remove parameter.
2382
2383 2019-03-06  Tom Tromey  <tom@tromey.com>
2384
2385         * remote.c (remote_target::remote_parse_stop_reply): Use
2386         unique_xmalloc_ptr.
2387
2388 2019-03-06  Tom Tromey  <tom@tromey.com>
2389
2390         * stabsread.c (struct stabs_field_info): Rename from field_info.
2391         <list, fnlist>: Add initializers.
2392         <obstack>: New member.
2393         (read_member_functions, read_struct_fields, read_baseclasses):
2394         Allocate on obstack.  Don't use cleanups.
2395         (read_one_struct_field, read_member_functions, read_struct_fields)
2396         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2397         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2398         (read_struct_type): Update.
2399
2400 2019-03-06  Tom Tromey  <tom@tromey.com>
2401
2402         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2403         * common/filestuff.h (make_cleanup_close): Don't declare.
2404         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2405         Remove.
2406
2407 2019-03-06  Tom Tromey  <tom@tromey.com>
2408
2409         * solib-aix.c: Use make_scope_exit.
2410
2411 2019-03-06  Tom Tromey  <tom@tromey.com>
2412
2413         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2414         Use make_scope_exit.
2415
2416 2019-03-06  Tom Tromey  <tom@tromey.com>
2417
2418         * solib-svr4.c (disable_probes_interface): Remove parameter.
2419         (svr4_handle_solib_event): Use make_scope_exit.
2420
2421 2019-03-06  Tom Tromey  <tom@tromey.com>
2422
2423         * remote.c (struct stop_reply_deleter): Remove.
2424         (stop_reply_up): Update.
2425         (struct stop_reply): Derive from notif_event.  Don't typedef.
2426         <regcache>: Now a std::vector.
2427         (stop_reply_xfree): Remove.
2428         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2429         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2430         (remote_target::discard_pending_stop_replies): Use delete.
2431         (remote_target::remote_parse_stop_reply): Update.
2432         (remote_target::process_stop_reply): Update.
2433         * remote-notif.h (struct notif_event): Add virtual destructor.
2434         Remove "dtr" member.
2435         (struct notif_client) <alloc_event>: Return a unique_ptr.
2436         (notif_event_xfree): Don't declare.
2437         (notif_event_up): New typedef.
2438         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2439         (notif_event_xfree, do_notif_event_xfree): Remove.
2440         (remote_notif_state_xfree): Update.
2441
2442 2019-03-06  Tom Tromey  <tom@tromey.com>
2443
2444         * infrun.c (displaced_step_clear_cleanup): Now a
2445         forward_scope_exit type.
2446         (displaced_step_prepare_throw): Update.
2447         (displaced_step_fixup): Update.
2448
2449 2019-03-06  Tom Tromey  <tom@tromey.com>
2450
2451         * inferior.h (class inferior): Update comment.
2452         * gdbthread.h (class thread_info): Update comment.
2453
2454 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2455             Tom Tromey  <tom@tromey.com>
2456
2457         * stabsread.h (struct stab_section_list): Remove.
2458         (coffstab_build_psymtabs): Update.
2459         * dbxread.c (symbuf_sections): Now a std::vector.
2460         (sect_idx): New global.
2461         (fill_symbuf): Update.
2462         (coffstab_build_psymtabs): Change type of stabsects parameter.
2463         Update.
2464         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2465         std::vector.
2466         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2467         (coff_locate_sections): Update.
2468         (coff_symfile_read): Remove cleanups.  Update.
2469         (init_stringtab): Add storage parameter.
2470         (free_stringtab, free_stringtab_cleanup): Remove.
2471         (init_lineno): Add storage parameter.
2472         (free_linetab, free_linetab_cleanup): Remove.
2473
2474 2019-03-06  Pedro Alves  <palves@redhat.com>
2475
2476         * linux-fork.c (fork_info::clobber_regs): Delete.
2477         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2478         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2479         comment.  Adjust.
2480         (scoped_switch_fork_info::scoped_switch_fork_info)
2481         (checkpoint_command, linux_fork_context): Adjust
2482         fork_save_infrun_state calls.
2483
2484 2019-03-06  Pedro Alves  <palves@redhat.com>
2485
2486         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2487         (inf_has_multiple_threads): Return 'bool' and rewrite using
2488         inferior_info::threads().
2489
2490 2019-03-06  Pedro Alves  <palves@redhat.com>
2491
2492         * linux-fork.c: Include <list>.
2493         (fork_list): Now a std::list instance.
2494         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2495         (forks_exist_p, find_last_fork): Adjust.
2496         (new_fork): Delete.
2497         (one_fork_p): New.
2498         (add_fork): Adjust.
2499         (free_fork): Delete, folded into fork_info::~fork_info().
2500         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2501         Adjust.
2502         (init_fork_list): Delete.
2503         (linux_fork_killall, linux_fork_mourn_inferior)
2504         (linux_fork_detach, info_checkpoints_command): Adjust.
2505         (_initialize_linux_fork): No longer call init_fork_list.
2506
2507 2019-03-06  Pedro Alves  <palves@redhat.com>
2508
2509         * linux-fork.c (new_fork): New, split out of ...
2510         (add_fork): ... this.  Return void.  Move "first fork" special
2511         case from here, to ...
2512         (checkpoint_command): ... here.
2513         * linux-linux.h (add_fork): Return void.
2514
2515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2518
2519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2520             Chris January  <chris.january@arm.com>
2521             David Lecomber  <david.lecomber@arm.com>
2522
2523         * f-exp.y: New token, UNOP_INTRINSIC.
2524         (exp): New pattern using UNOP_INTRINSIC token.
2525         (f77_keywords): Add 'abs' keyword.
2526         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2527         (value_from_host_double): New function.
2528         (evaluate_subexp_f): Support UNOP_ABS.
2529
2530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2533         types.
2534
2535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2538         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2539         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2540
2541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2544
2545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2546             Chris January  <chris.january@arm.com>
2547
2548         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2549         * f-exp.y: Define 'KIND' token.
2550         (exp): New pattern for KIND expressions.
2551         (ptype): Handle types with a kind extension.
2552         (direct_abs_decl): Extend to spot kind extensions.
2553         (f77_keywords): Add 'kind' to the list.
2554         (push_kind_type): New function.
2555         (convert_to_kind_type): New function.
2556         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2557         * parse.c (operator_length_standard): Likewise.
2558         * parser-defs.h (enum type_pieces): Add tp_kind.
2559         * std-operator.def: Add UNOP_KIND.
2560
2561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * f-exp.y (f_parse): Set yydebug.
2564
2565 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * f-lang.c (evaluate_subexp_f): New function.
2568         (exp_descriptor_f): New global.
2569         (f_language_defn): Use exp_descriptor_f instead of
2570         exp_descriptor_standard.
2571
2572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * f-exp.y (struct token): Add comments.
2575         (dot_ops): Remove uppercase versions and the end marker.
2576         (f77_keywords): Likewise.
2577         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2578         entries in the dot_ops array are case insensitive, and use
2579         strncasecmp to compare strings.  Also some whitespace cleanup in
2580         this area.  Similar for the f77_keywords array, except entries in
2581         this list might be case sensitive.
2582
2583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2584
2585         * f-exp.y (struct f77_boolean_val): Add comments.
2586         (boolean_values): Remove uppercase versions, and end marker.
2587         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2588         and use strncasecmp to achieve case insensitivity.  Additionally,
2589         perform whitespace cleanup around this code.
2590
2591 2019-03-06  Tom Tromey  <tromey@adacore.com>
2592
2593         * remote-sim.c (gdbsim_target_open): Use result of
2594         gdb_argv::release.
2595
2596 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2597         Dirk Schubert  <dirk.schubert@arm.com>
2598         Chris January  <chris.january@arm.com>
2599
2600         * eval.c (evaluate_subexp_standard): Call Fortran argument
2601         wrapping logic.
2602         * f-lang.c (struct value): A value which can be passed into a
2603         Fortran function call.
2604         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2605         where appropriate.
2606         (struct type): Value ready for a Fortran function call.
2607         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2608         is needed.
2609         * f-lang.h (fortran_argument_convert): Declaration.
2610         (fortran_preserve_arg_pointer): Declaration.
2611         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2612
2613 2019-03-05  Tom Tromey  <tromey@adacore.com>
2614
2615         * python/py-prettyprint.c (print_string_repr): Remove #if.
2616         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2617
2618 2019-03-05  Tom Tromey  <tromey@adacore.com>
2619
2620         * target.c (the_dummy_target): Move later.  Change type to
2621         "dummy_target".
2622         (initialize_targets): Don't initialize the_dummy_target.
2623
2624 2019-03-05  Tom Tromey  <tromey@adacore.com>
2625
2626         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2627         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2628
2629 2019-03-05  Tom Tromey  <tromey@adacore.com>
2630
2631         * windows-nat.c (windows_nat_target::attach)
2632         (windows_nat_target::detach): Don't call gdb_flush.
2633         * valprint.c (generic_val_print, val_print, val_print_string):
2634         Don't call gdb_flush.
2635         * utils.c (defaulted_query): Don't call gdb_flush.
2636         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2637         * target.c (target_announce_detach): Don't call gdb_flush.
2638         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2639         * remote.c (extended_remote_target::attach): Don't call
2640         gdb_flush.
2641         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2642         * printcmd.c (do_examine): Don't call gdb_flush.
2643         (info_display_command): Don't call gdb_flush.
2644         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2645         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2646         * memattr.c (info_mem_command): Don't call gdb_flush.
2647         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2648         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2649         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2650         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2651         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2652         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2653         (gnu_nat_target::detach): Don't call gdb_flush.
2654         * f-valprint.c (f_val_print): Don't call gdb_flush.
2655         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2656         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2657         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2658         gdb_flush.
2659         * c-valprint.c (c_val_print): Don't call gdb_flush.
2660         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2661
2662 2019-03-05  Tom Tromey  <tromey@adacore.com>
2663
2664         * varobj.c (update_dynamic_varobj_children): Update.
2665         (install_default_visualizer): Use reset, not release.
2666         * value.c (set_internalvar): Update.
2667         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2668         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2669         ATTRIBUTE_UNUSED_RESULT.
2670
2671 2019-03-05  Tom Tromey  <tromey@adacore.com>
2672
2673         * remote.c (class scoped_remote_fd) <release>: Add
2674         ATTRIBUTE_UNUSED_RESULT.
2675
2676 2019-03-05  Tom Tromey  <tromey@adacore.com>
2677
2678         * macroexp.c (struct macro_buffer) <release>: Add
2679         ATTRIBUTE_UNUSED_RESULT.
2680
2681 2019-03-05  Tom Tromey  <tromey@adacore.com>
2682
2683         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2684         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2685         ATTRIBUTE_UNUSED_RESULT.
2686
2687 2019-03-05  Tom Tromey  <tromey@adacore.com>
2688
2689         * common/scoped_fd.h (class scoped_fd) <release>: Add
2690         ATTRIBUTE_UNUSED_RESULT.
2691
2692 2019-03-05  Tom Tromey  <tromey@adacore.com>
2693
2694         * parser-defs.h (struct parser_state) <release>: Add
2695         ATTRIBUTE_UNUSED_RESULT.
2696
2697 2019-03-05  Tom Tromey  <tromey@adacore.com>
2698
2699         * utils.h (class gdb_argv) <release>: Add
2700         ATTRIBUTE_UNUSED_RESULT.
2701         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2702
2703 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2704
2705         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2706         for-loop range, to avoid compiler warnings.
2707
2708         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2709         avoid compiler warnings about unused variables.
2710
2711         * NEWS: Mention end of support for native debugging on MS-Windows
2712         before XP.
2713
2714         PR gdb/24292
2715         * common/netstuff.c:
2716         * gdbserver/gdbreplay.c
2717         * gdbserver/remote-utils.c:
2718         * ser-tcp.c:
2719         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2720         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2721         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2722         'getaddrinfo' and 'freeaddrinfo' were not available before
2723         Windows XP, and mingw.org's MinGW headers by default define
2724         _WIN32_WINNT to 0x500.
2725
2726 2019-03-01  Gary Benson <gbenson@redhat.com>
2727
2728         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2729
2730 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2731             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2732
2733         PR gdb/8527
2734         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2735         set_sigint_trap, clear_sigint_trap.
2736
2737 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2738
2739         * target.c (target_detach): Clear the regcache and the
2740         frame cache.
2741
2742 2019-02-27  Pedro Alves  <palves@redhat.com>
2743
2744         * utils.c (set_screen_size): When we cap the height/width sizes,
2745         tweak the corresponding command variable to show "unlimited":
2746
2747 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2748             Pedro Alves  <palves@redhat.com>
2749
2750         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2751         before calling rl_set_screen_size.
2752
2753 2019-02-27  Tom Tromey  <tromey@adacore.com>
2754
2755         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2756         define.
2757         * python/py-value.c: Remove Python 2.4 workaround.
2758         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2759         workaround.
2760         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2761         Python 2.4 workaround.
2762         * python/python-internal.h: Remove Python 2.4 comment.
2763         (Py_ssize_t): Don't define.
2764         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2765         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2766         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2767         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2768         * python/python.c (do_start_initialization): Remove Python 2.4
2769         workaround.
2770         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2771         (print_children): Remove Python 2.4 workaround.
2772         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2773         workaround.
2774         (CHARBUFFERPROC_NAME): Remove.
2775         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2776         Python 2.4 workaround.
2777
2778 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2779
2780         * NEWS: Note minimum Python version.
2781
2782 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2783
2784         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2785         code from these functions.  Remove corresponding ifdefs.  Use
2786         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2787         Remove gotos and target of gotos.
2788         (infpy_search_memory): Likewise.
2789
2790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2791
2792         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2793         (hppa_gdbarch_init): Don't register deleted functions with
2794         gdbarch.
2795
2796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2799         (h8300_unwind_sp): Delete.
2800         (h8300_dummy_id): Delete.
2801         (h8300_gdbarch_init): Don't register deleted functions with
2802         gdbarch.
2803
2804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2807         (ft32_unwind_pc): Delete.
2808         (ft32_unwind_sp): Delete.
2809         (ft32_gdbarch_init): Don't register deleted functions with
2810         gdbarch.
2811
2812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2815         (frv_unwind_pc): Delete.
2816         (frv_unwind_sp): Delete.
2817         (frv_gdbarch_init): Don't register deleted functions with
2818         gdbarch.
2819
2820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2823         (riscv_unwind_pc): Delete.
2824         (riscv_unwind_sp): Delete.
2825         (riscv_gdbarch_init): Don't register deleted functions with
2826         gdbarch.
2827
2828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2831         (csky_unwind_pc): Delete.
2832         (csky_unwind_sp): Delete.
2833         (csky_gdbarch_init): Don't register deleted functions with
2834         gdbarch.
2835
2836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2839         (cris_unwind_pc): Delete.
2840         (cris_unwind_sp): Delete.
2841         (cris_gdbarch_init): Don't register deleted functions with
2842         gdbarch.
2843
2844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2847         (bfin_unwind_pc): Delete.
2848         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2849
2850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2853         (arm_unwind_pc): Delete.
2854         (arm_unwind_sp): Delete.
2855         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2856
2857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2860         (arc_unwind_pc): Delete.
2861         (arc_unwind_sp): Delete.
2862         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2863
2864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2865
2866         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2867         (alpha_unwind_pc): Delete.
2868         (alpha_gdbarch_init): Don't register deleted functions with
2869         gdbarch.
2870
2871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2872
2873         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2874         (aarch64_unwind_pc): Delete.
2875         (aarch64_unwind_sp): Delete.
2876         (aarch64_gdbarch_init): Don't register deleted functions with
2877         gdbarch.
2878
2879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * gdbtypes.c (type_align): Don't consider static members when
2882         computing structure alignment.
2883
2884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2887         return 0 for other types.
2888         * arch-utils.c (default_type_align): Always return 0.
2889         * gdbarch.h: Regenerate.
2890         * gdbarch.sh (type_align): Extend comment.
2891         * gdbtypes.c (type_align): Add additional comments, always call
2892         gdbarch_type_align before applying the default rules.
2893         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2894         generic code will then apply a suitable default.
2895         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2896         types, return 0 for other types.
2897
2898 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2899
2900         * NEWS: Create a new section for the next release branch.
2901         Rename the section of the current branch, now that it has
2902         been cut.
2903
2904 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2905
2906         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2907         * version.in: Bump version to 8.3.50.DATE-git.
2908
2909 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2910
2911         * aix-thread.c (ptid_cmp): Remove unused variable.
2912         (get_signaled_thread): Likewise.
2913         (store_regs_user_thread): Likewise.
2914         (store_regs_kernel_thread): Likewise.
2915         (fetch_regs_kernel_thread): Remove shadowed variable.
2916
2917 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * features/riscv/32bit-cpu.xml: Add register numbers.
2920         * features/riscv/32bit-fpu.c: Regenerate.
2921         * features/riscv/32bit-fpu.xml: Add register numbers.
2922         * features/riscv/64bit-cpu.xml: Add register numbers.
2923         * features/riscv/64bit-fpu.c: Regenerate.
2924         * features/riscv/64bit-fpu.xml: Add register numbers.
2925
2926 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2927
2928         * NEWS: Mention two argument form of gdb.Value constructor.
2929         * python/py-value.c (convert_buffer_and_type_to_value): New
2930         function.
2931         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2932         Add support for handling an optional second argument.  Call
2933         convert_buffer_and_type_to_value as appropriate.
2934         * python/python-internal.h (Py_buffer_deleter): New struct.
2935         (Py_buffer_up): New typedef.
2936
2937 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2938
2939         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2940         instead of releasing ownership.
2941
2942 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2943
2944         * dwarf2read.c (open_and_init_dwp_file): Call
2945         elf_numsections instead of bfd_count_sections to initialize
2946         dwp_file->num_sections.
2947
2948 2019-02-25  Tom Tromey  <tromey@adacore.com>
2949
2950         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2951
2952 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2953
2954         * gcore.in: Add '--readnever' option when invoking GDB.
2955
2956 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2957
2958         * MAINTAINERS: Update my email address.
2959
2960 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2961
2962         * build-id.c (build_id_to_debug_bfd_1): New function.
2963         (build_id_to_debug_bfd): Look for separate debug file in
2964         sysroot.
2965
2966 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * gdbarch.sh: Update the copyright year range that is placed into
2969         generated files.
2970
2971 2019-02-22  Keith Seitz  <keiths@redhat.com>
2972
2973         PR symtab/23853
2974         * linespec.c (create_sals_line_offset): Search for the default
2975         symtab's filename instead of its fullname.
2976
2977 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2978
2979         * NEWS: Update style defaults.
2980
2981 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2982
2983         * main.c (captured_main_1): Disable styling in batch mode.
2984
2985 2019-02-20  Tom Tromey  <tom@tromey.com>
2986
2987         * symtab.c (symtab_symbol_info): Fix typos.
2988
2989 2019-02-20  Tom Tromey  <tromey@adacore.com>
2990
2991         * findcmd.c (_initialize_mem_search): Use upper case for
2992         metasyntactic variables.
2993
2994 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2995
2996         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2997         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2998
2999 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3000
3001         * top.h (source_file_name): Change to std::string.
3002         * top.c (source_file_name): Likewise.
3003         (command_line_input): Adjust.
3004         * cli/cli-script.c (script_from_file): Adjust.
3005
3006 2019-02-19  Tom Tromey  <tromey@adacore.com>
3007
3008         * ravenscar-thread.c
3009         (ravenscar_thread_target::update_thread_list): Don't call
3010         ada_build_task_list.
3011         * ada-lang.h (ada_build_task_list): Don't declare.
3012         * ada-tasks.c (struct ada_tasks_inferior_data)
3013         <task_list_valid_p>: Now bool.
3014         (read_known_tasks, ada_task_list_changed)
3015         (ada_tasks_invalidate_inferior_data): Update.
3016         (read_known_tasks_array): Return bool.
3017         (read_known_tasks_list): Likewise.
3018         (read_known_tasks): Return void.
3019         (ada_build_task_list): Now static.
3020
3021 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3022
3023         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3024         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3025
3026 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3027
3028         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3029         variant for ada_tasks_pspace_data_handle and
3030         ada_tasks_inferior_data_handle.
3031         (ada_tasks_pspace_data_cleanup): New function.
3032         (ada_tasks_inferior_data_cleanup): New function.
3033
3034 2019-02-17  Tom Tromey  <tom@tromey.com>
3035
3036         * macrotab.h (macro_source_fullname): Return a std::string.
3037         * macrotab.c (macro_include, check_for_redefinition)
3038         (macro_undef, macro_lookup_definition, foreach_macro)
3039         (foreach_macro_in_scope): Update.
3040         (macro_source_fullname): Return a std::string.
3041         * macrocmd.c (show_pp_source_pos): Update.
3042
3043 2019-02-17  Tom Tromey  <tom@tromey.com>
3044
3045         * macrocmd.c (show_pp_source_pos): Style the file names.
3046
3047 2019-02-17  Tom Tromey  <tom@tromey.com>
3048
3049         PR tui/24197:
3050         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3051
3052 2019-02-17  Tom Tromey  <tom@tromey.com>
3053
3054         * ada-lang.c (user_select_syms): Use filtered printing.
3055         * utils.c (wrap_style): New global.
3056         (desired_style): Remove.
3057         (emit_style_escape): Add stream parameter.
3058         (set_output_style, reset_terminal_style, prompt_for_continue):
3059         Update.
3060         (flush_wrap_buffer): Only flush gdb_stdout.
3061         (wrap_here): Set wrap_style.
3062         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3063         treat escape sequences as a character.  Change when wrap buffer is
3064         flushed.
3065         (fputs_styled): Do not set the output style when the default is
3066         requested.
3067         * ui-style.h (struct ui_file_style) <is_default>: New method.
3068         * source.c (print_source_lines_base): Emit escape sequences in one
3069         piece.
3070
3071 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3072
3073         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3074         integers and enumeration types.
3075
3076 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3077
3078         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3079         instead of lookup_symbol_in_language
3080         (do_exact_match): New function.
3081         (ada_get_symbol_name_matcher): Return do_exact_match when
3082         doing a verbatim match.
3083
3084 2019-02-15  Tom Tromey  <tromey@adacore.com>
3085
3086         * ravenscar-thread.c (ravenscar_thread_target::resume)
3087         (ravenscar_thread_target::wait): Special case wildcard requests.
3088
3089 2019-02-15  Tom Tromey  <tromey@adacore.com>
3090
3091         * ravenscar-thread.c (base_ptid): Remove.
3092         (struct ravenscar_thread_target) <close>: New method.
3093         <m_base_ptid>: New member.
3094         <update_inferior_ptid, active_task, task_is_currently_active,
3095         runtime_initialized>: Declare methods.
3096         <ravenscar_thread_target>: Add constructor.
3097         (ravenscar_thread_target::task_is_currently_active)
3098         (ravenscar_thread_target::update_inferior_ptid)
3099         (ravenscar_runtime_initialized): Rename.  Now methods.
3100         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3101         (ravenscar_thread_target::update_thread_list): Update.
3102         (ravenscar_thread_target::active_task): Now method.
3103         (ravenscar_thread_target::store_registers)
3104         (ravenscar_thread_target::prepare_to_store)
3105         (ravenscar_thread_target::prepare_to_store)
3106         (ravenscar_thread_target::mourn_inferior): Update.
3107         (ravenscar_inferior_created): Use "new" to create target.
3108         (ravenscar_thread_target::get_ada_task_ptid): Update.
3109         (_initialize_ravenscar): Don't initialize base_ptid.
3110         (ravenscar_ops): Remove global.
3111
3112 2019-02-15  Tom Tromey  <tromey@adacore.com>
3113
3114         * target.h (push_target): Declare new overload.
3115         * target.c (push_target): New overload, taking an rvalue reference.
3116         * remote.c (remote_target::open_1): Use push_target overload.
3117         * corelow.c (core_target_open): Use push_target overload.
3118
3119 2019-02-15  Tom Tromey  <tromey@adacore.com>
3120
3121         * ravenscar-thread.c (is_ravenscar_task)
3122         (ravenscar_task_is_currently_active): Return bool.
3123         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3124         (_initialize_ravenscar): Remove "(void)".
3125         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3126         Return bool.
3127
3128 2019-02-15  Tom Tromey  <tromey@adacore.com>
3129
3130         * ravenscar-thread.c (ravenscar_runtime_initializer)
3131         (has_ravenscar_runtime, get_running_thread_id)
3132         (ravenscar_thread_target::resume): Fix indentation.
3133
3134 2019-02-15  Tom Tromey  <tromey@adacore.com>
3135
3136         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3137         from ravenscar_arch_ops.
3138         (sparc_ravenscar_ops::fetch_registers)
3139         (sparc_ravenscar_ops::store_registers): Now methods.
3140         (sparc_ravenscar_prepare_to_store): Remove.
3141         (sparc_ravenscar_ops): Redefine.
3142         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3143         methods and destructor.  Remove members.
3144         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3145         (ravenscar_thread_target::store_registers)
3146         (ravenscar_thread_target::prepare_to_store): Update.
3147         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3148         Remove.
3149         (struct ppc_ravenscar_powerpc_ops): Derive from
3150         ravenscar_arch_ops.
3151         (ppc_ravenscar_powerpc_ops::fetch_registers)
3152         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3153         (ppc_ravenscar_powerpc_ops): Redefine.
3154         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3155         (ppc_ravenscar_e500_ops::fetch_registers)
3156         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3157         (ppc_ravenscar_e500_ops): Redefine.
3158         * aarch64-ravenscar-thread.c
3159         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3160         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3161         (aarch64_ravenscar_fetch_registers)
3162         (aarch64_ravenscar_store_registers): Now methods.
3163         (aarch64_ravenscar_ops): Redefine.
3164
3165 2019-02-15  Tom Tromey  <tromey@adacore.com>
3166
3167         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3168         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3169         (ravenscar_thread_target::stopped_by_watchpoint)
3170         (ravenscar_thread_target::stopped_data_address)
3171         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3172
3173 2019-02-15  Tom Tromey  <tromey@adacore.com>
3174
3175         * ravenscar-thread.c: Fix some typos.
3176
3177 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3178             Tom Tromey  <tromey@adacore.com>
3179
3180         * ada-lang.c (ada_exception_sal): Change addr_string to a
3181         std::string.
3182         (create_ada_exception_catchpoint): Update.
3183
3184 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3185             Tom Tromey  <tromey@adacore.com>
3186
3187         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3188         (bp_location_ops): Remove.
3189         (base_breakpoint_allocate_location): Update.
3190         (free_bp_location): Update.
3191         * ada-lang.c (class ada_catchpoint_location)
3192         <ada_catchpoint_location>: Remove ops parameter.
3193         (ada_catchpoint_location_dtor): Remove.
3194         (ada_catchpoint_location_ops): Remove.
3195         (allocate_location_exception): Update.
3196         * breakpoint.h (struct bp_location_ops): Remove.
3197         (class bp_location) <bp_location>: Remove bp_location_ops
3198         parameter.
3199         <~bp_location>: Add destructor.
3200         <ops>: Remove.
3201
3202 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3203             Pedro Alves  <palves@redhat.com>
3204
3205         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3206         'PATH_MAX'.
3207
3208 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3209             Samuel Thibault  <samuel.thibault@gnu.org>
3210             Thomas Schwinge  <thomas@codesourcery.com>
3211
3212         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3213         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3214
3215 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3216
3217         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3218         (check_empty): Use "const char *".
3219
3220         * gnu-nat.c (gnu_nat_target::detach): Instead of
3221         'detach_inferior (pid)' call
3222         'detach_inferior (find_inferior_pid (pid))'.
3223
3224         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3225         'nat/fork-inferior.o'.
3226         * gnu-nat.c: #include "nat/fork-inferior.h".
3227
3228         * gnu-nat.c (gnu_nat_target::detach): Instead of
3229         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3230         * gnu-nat.h: #include "inf-child.h".
3231         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3232         'i386_gnu_nat_target::fetch_registers'.
3233         (gnu_store_registers): Rename/move to
3234         'i386_gnu_nat_target::store_registers'.
3235
3236         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3237         * gnu-nat.h (mach_thread_info): New function.
3238         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3239
3240         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3241
3242 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3243
3244         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3245
3246 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3247
3248         * windows-nat.c (windows_add_thread): Add new parameter
3249         "main_thread_p" with default value set to false.  Update
3250         function documentation as well as all callers.
3251         (windows_delete_thread): Likewise.
3252         (fake_create_process): Update call to windows_add_thread.
3253         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3254         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3255         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3256         call to windows_delete_thread.
3257
3258 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3259
3260         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3261
3262 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3263
3264         * symfile.c (find_separate_debug_file): Use canonical path of
3265         sysroot with child_path instead of gdb_sysroot if it is valid.
3266
3267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3268
3269         * symfile.c (find_separate_debug_file): Use child_path to
3270         determine if an object file is under a sysroot.
3271
3272 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3273
3274         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3275         unittests/child-path-selftests.c.
3276         * common/pathstuff.c (child_path): New function.
3277         * common/pathstuff.h (child_path): New prototype.
3278         * unittests/child-path-selftests.c: New file.
3279
3280 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3281
3282         * symfile.c (find_separate_debug_file): Look for separate debug
3283         files in debug directories under the sysroot.
3284
3285 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3286
3287         * symtab.h (struct minimal_symbol data_p): New const method.
3288         (struct minimal_symbol text_p): Likewise.
3289         * symtab.c (output_source_filename): Use file name style
3290         to print file name.
3291         (print_symbol_info): Likewise.
3292         (print_msymbol_info): Use address style to print addresses.
3293         Use function name style to print executable text symbols.
3294         (expand_symtab_containing_pc): Use data_p.
3295         (find_pc_sect_compunit_symtab): Likewise.
3296
3297 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3298
3299         * breakpoint.c (describe_other_breakpoints): Use address style
3300         to print addresses.
3301         (say_where): Likewise.
3302
3303 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3304
3305         * ada-typeprint.c (print_func_type): Print function name
3306         style to print function name.
3307         * c-typeprint.c (c_print_type_1): Likewise.
3308
3309 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3310
3311         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3312         for execve.
3313
3314 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3315
3316         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3317         type_stack.
3318
3319 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3320
3321         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3322         TYPE_CODE_REF types.
3323
3324 2019-02-08  Jim Wilson  <jimw@sifive.com>
3325
3326         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3327         (riscv_linux_fregset): New.
3328         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3329
3330 2019-02-07  Tom Tromey  <tom@tromey.com>
3331
3332         * thread.c (thread_cancel_execution_command): Update.
3333         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3334         methods.
3335         (struct thread_fsm_ops): Remove.
3336         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3337         (thread_fsm_should_stop, thread_fsm_return_value)
3338         (thread_fsm_set_finished, thread_fsm_finished_p)
3339         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3340         Don't declare.
3341         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3342         * infrun.c (clear_proceed_status_thread)
3343         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3344         (print_stop_event): Update.
3345         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3346         Add constructor.
3347         (step_command_fsm_ops): Remove.
3348         (new_step_command_fsm): Remove.
3349         (step_1): Update.
3350         (step_command_fsm::should_stop): Rename from
3351         step_command_fsm_should_stop.
3352         (step_command_fsm::clean_up): Rename from
3353         step_command_fsm_clean_up.
3354         (step_command_fsm::do_async_reply_reason): Rename from
3355         step_command_fsm_async_reply_reason.
3356         (struct until_next_fsm): Inherit from thread_fsm.  Add
3357         constructor.
3358         (until_next_fsm_ops): Remove.
3359         (new_until_next_fsm): Remove.
3360         (until_next_fsm::should_stop): Rename from
3361         until_next_fsm_should_stop.
3362         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3363         (until_next_fsm::do_async_reply_reason): Rename from
3364         until_next_fsm_async_reply_reason.
3365         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3366         constructor.  Change type of breakpoint.
3367         (finish_command_fsm_ops): Remove.
3368         (new_finish_command_fsm): Remove.
3369         (finish_command_fsm::should_stop): Rename from
3370         finish_command_fsm_should_stop.
3371         (finish_command_fsm::clean_up): Rename from
3372         finish_command_fsm_clean_up.
3373         (finish_command_fsm::return_value): Rename from
3374         finish_command_fsm_return_value.
3375         (finish_command_fsm::do_async_reply_reason): Rename from
3376         finish_command_fsm_async_reply_reason.
3377         (finish_command): Update.
3378         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3379         Add constructor.
3380         (call_thread_fsm_ops): Remove.
3381         (call_thread_fsm::call_thread_fsm): Rename from
3382         new_call_thread_fsm.
3383         (call_thread_fsm::should_stop): Rename from
3384         call_thread_fsm_should_stop.
3385         (call_thread_fsm::should_notify_stop): Rename from
3386         call_thread_fsm_should_notify_stop.
3387         (run_inferior_call, call_function_by_hand_dummy): Update.
3388         * cli/cli-interp.c (should_print_stop_to_console): Update.
3389         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3390         Add constructor.  Change type of location_breakpoint,
3391         caller_breakpoint.
3392         (until_break_fsm_ops): Remove.
3393         (new_until_break_fsm): Remove.
3394         (until_break_fsm::should_stop): Rename from
3395         until_break_fsm_should_stop.
3396         (until_break_fsm::clean_up): Rename from
3397         until_break_fsm_clean_up.
3398         (until_break_fsm::do_async_reply_reason): Rename from
3399         until_break_fsm_async_reply_reason.
3400         (until_break_command): Update.
3401         * thread-fsm.c: Remove.
3402         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3403
3404 2019-02-07  Tom Tromey  <tom@tromey.com>
3405
3406         * yy-remap.h: Add include guard.
3407         * xtensa-tdep.h: Add include guard.
3408         * xcoffread.h: Rename include guard.
3409         * varobj-iter.h: Add include guard.
3410         * tui/tui.h: Rename include guard.
3411         * tui/tui-winsource.h: Rename include guard.
3412         * tui/tui-wingeneral.h: Rename include guard.
3413         * tui/tui-windata.h: Rename include guard.
3414         * tui/tui-win.h: Rename include guard.
3415         * tui/tui-stack.h: Rename include guard.
3416         * tui/tui-source.h: Rename include guard.
3417         * tui/tui-regs.h: Rename include guard.
3418         * tui/tui-out.h: Rename include guard.
3419         * tui/tui-layout.h: Rename include guard.
3420         * tui/tui-io.h: Rename include guard.
3421         * tui/tui-hooks.h: Rename include guard.
3422         * tui/tui-file.h: Rename include guard.
3423         * tui/tui-disasm.h: Rename include guard.
3424         * tui/tui-data.h: Rename include guard.
3425         * tui/tui-command.h: Rename include guard.
3426         * tic6x-tdep.h: Add include guard.
3427         * target/waitstatus.h: Rename include guard.
3428         * target/wait.h: Rename include guard.
3429         * target/target.h: Rename include guard.
3430         * target/resume.h: Rename include guard.
3431         * target-float.h: Rename include guard.
3432         * stabsread.h: Add include guard.
3433         * rs6000-tdep.h: Add include guard.
3434         * riscv-fbsd-tdep.h: Add include guard.
3435         * regformats/regdef.h: Rename include guard.
3436         * record.h: Rename include guard.
3437         * python/python.h: Rename include guard.
3438         * python/python-internal.h: Rename include guard.
3439         * python/py-stopevent.h: Rename include guard.
3440         * python/py-ref.h: Rename include guard.
3441         * python/py-record.h: Rename include guard.
3442         * python/py-record-full.h: Rename include guard.
3443         * python/py-record-btrace.h: Rename include guard.
3444         * python/py-instruction.h: Rename include guard.
3445         * python/py-events.h: Rename include guard.
3446         * python/py-event.h: Rename include guard.
3447         * procfs.h: Add include guard.
3448         * proc-utils.h: Add include guard.
3449         * p-lang.h: Add include guard.
3450         * or1k-tdep.h: Rename include guard.
3451         * observable.h: Rename include guard.
3452         * nto-tdep.h: Rename include guard.
3453         * nat/x86-linux.h: Rename include guard.
3454         * nat/x86-linux-dregs.h: Rename include guard.
3455         * nat/x86-gcc-cpuid.h: Add include guard.
3456         * nat/x86-dregs.h: Rename include guard.
3457         * nat/x86-cpuid.h: Rename include guard.
3458         * nat/ppc-linux.h: Rename include guard.
3459         * nat/mips-linux-watch.h: Rename include guard.
3460         * nat/linux-waitpid.h: Rename include guard.
3461         * nat/linux-ptrace.h: Rename include guard.
3462         * nat/linux-procfs.h: Rename include guard.
3463         * nat/linux-osdata.h: Rename include guard.
3464         * nat/linux-nat.h: Rename include guard.
3465         * nat/linux-namespaces.h: Rename include guard.
3466         * nat/linux-btrace.h: Rename include guard.
3467         * nat/glibc_thread_db.h: Rename include guard.
3468         * nat/gdb_thread_db.h: Rename include guard.
3469         * nat/gdb_ptrace.h: Rename include guard.
3470         * nat/fork-inferior.h: Rename include guard.
3471         * nat/amd64-linux-siginfo.h: Rename include guard.
3472         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3473         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3474         * nat/aarch64-linux.h: Rename include guard.
3475         * nat/aarch64-linux-hw-point.h: Rename include guard.
3476         * mn10300-tdep.h: Add include guard.
3477         * mips-linux-tdep.h: Add include guard.
3478         * mi/mi-parse.h: Rename include guard.
3479         * mi/mi-out.h: Rename include guard.
3480         * mi/mi-main.h: Rename include guard.
3481         * mi/mi-interp.h: Rename include guard.
3482         * mi/mi-getopt.h: Rename include guard.
3483         * mi/mi-console.h: Rename include guard.
3484         * mi/mi-common.h: Rename include guard.
3485         * mi/mi-cmds.h: Rename include guard.
3486         * mi/mi-cmd-break.h: Rename include guard.
3487         * m2-lang.h: Add include guard.
3488         * location.h: Rename include guard.
3489         * linux-record.h: Rename include guard.
3490         * linux-nat.h: Add include guard.
3491         * linux-fork.h: Add include guard.
3492         * i386-darwin-tdep.h: Rename include guard.
3493         * hppa-linux-offsets.h: Add include guard.
3494         * guile/guile.h: Rename include guard.
3495         * guile/guile-internal.h: Rename include guard.
3496         * gnu-nat.h: Rename include guard.
3497         * gdb-stabs.h: Rename include guard.
3498         * frv-tdep.h: Add include guard.
3499         * f-lang.h: Add include guard.
3500         * event-loop.h: Add include guard.
3501         * darwin-nat.h: Rename include guard.
3502         * cp-abi.h: Rename include guard.
3503         * config/sparc/nm-sol2.h: Rename include guard.
3504         * config/nm-nto.h: Rename include guard.
3505         * config/nm-linux.h: Add include guard.
3506         * config/i386/nm-i386gnu.h: Rename include guard.
3507         * config/djgpp/nl_types.h: Rename include guard.
3508         * config/djgpp/langinfo.h: Rename include guard.
3509         * compile/gcc-cp-plugin.h: Add include guard.
3510         * compile/gcc-c-plugin.h: Add include guard.
3511         * compile/compile.h: Rename include guard.
3512         * compile/compile-object-run.h: Rename include guard.
3513         * compile/compile-object-load.h: Rename include guard.
3514         * compile/compile-internal.h: Rename include guard.
3515         * compile/compile-cplus.h: Rename include guard.
3516         * compile/compile-c.h: Rename include guard.
3517         * common/xml-utils.h: Rename include guard.
3518         * common/x86-xstate.h: Rename include guard.
3519         * common/version.h: Rename include guard.
3520         * common/vec.h: Rename include guard.
3521         * common/tdesc.h: Rename include guard.
3522         * common/selftest.h: Rename include guard.
3523         * common/scoped_restore.h: Rename include guard.
3524         * common/scoped_mmap.h: Rename include guard.
3525         * common/scoped_fd.h: Rename include guard.
3526         * common/safe-iterator.h: Rename include guard.
3527         * common/run-time-clock.h: Rename include guard.
3528         * common/refcounted-object.h: Rename include guard.
3529         * common/queue.h: Rename include guard.
3530         * common/ptid.h: Rename include guard.
3531         * common/print-utils.h: Rename include guard.
3532         * common/preprocessor.h: Rename include guard.
3533         * common/pathstuff.h: Rename include guard.
3534         * common/observable.h: Rename include guard.
3535         * common/netstuff.h: Rename include guard.
3536         * common/job-control.h: Rename include guard.
3537         * common/host-defs.h: Rename include guard.
3538         * common/gdb_wait.h: Rename include guard.
3539         * common/gdb_vecs.h: Rename include guard.
3540         * common/gdb_unlinker.h: Rename include guard.
3541         * common/gdb_unique_ptr.h: Rename include guard.
3542         * common/gdb_tilde_expand.h: Rename include guard.
3543         * common/gdb_sys_time.h: Rename include guard.
3544         * common/gdb_string_view.h: Rename include guard.
3545         * common/gdb_splay_tree.h: Rename include guard.
3546         * common/gdb_setjmp.h: Rename include guard.
3547         * common/gdb_ref_ptr.h: Rename include guard.
3548         * common/gdb_optional.h: Rename include guard.
3549         * common/gdb_locale.h: Rename include guard.
3550         * common/gdb_assert.h: Rename include guard.
3551         * common/filtered-iterator.h: Rename include guard.
3552         * common/filestuff.h: Rename include guard.
3553         * common/fileio.h: Rename include guard.
3554         * common/environ.h: Rename include guard.
3555         * common/common-utils.h: Rename include guard.
3556         * common/common-types.h: Rename include guard.
3557         * common/common-regcache.h: Rename include guard.
3558         * common/common-inferior.h: Rename include guard.
3559         * common/common-gdbthread.h: Rename include guard.
3560         * common/common-exceptions.h: Rename include guard.
3561         * common/common-defs.h: Rename include guard.
3562         * common/common-debug.h: Rename include guard.
3563         * common/cleanups.h: Rename include guard.
3564         * common/buffer.h: Rename include guard.
3565         * common/btrace-common.h: Rename include guard.
3566         * common/break-common.h: Rename include guard.
3567         * cli/cli-utils.h: Rename include guard.
3568         * cli/cli-style.h: Rename include guard.
3569         * cli/cli-setshow.h: Rename include guard.
3570         * cli/cli-script.h: Rename include guard.
3571         * cli/cli-interp.h: Rename include guard.
3572         * cli/cli-decode.h: Rename include guard.
3573         * cli/cli-cmds.h: Rename include guard.
3574         * charset-list.h: Add include guard.
3575         * buildsym-legacy.h: Rename include guard.
3576         * bfin-tdep.h: Add include guard.
3577         * ax.h: Rename include guard.
3578         * arm-linux-tdep.h: Add include guard.
3579         * arm-fbsd-tdep.h: Add include guard.
3580         * arch/xtensa.h: Rename include guard.
3581         * arch/tic6x.h: Add include guard.
3582         * arch/i386.h: Add include guard.
3583         * arch/arm.h: Rename include guard.
3584         * arch/arm-linux.h: Rename include guard.
3585         * arch/arm-get-next-pcs.h: Rename include guard.
3586         * arch/amd64.h: Add include guard.
3587         * arch/aarch64-insn.h: Rename include guard.
3588         * arch-utils.h: Rename include guard.
3589         * annotate.h: Add include guard.
3590         * amd64-darwin-tdep.h: Rename include guard.
3591         * aarch64-linux-tdep.h: Add include guard.
3592         * aarch64-fbsd-tdep.h: Add include guard.
3593         * aarch32-linux-nat.h: Add include guard.
3594
3595 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3596
3597         * macrotab.c (macro_define_internal): New function that
3598         factorizes macro_define_object_internal and macro_define_function
3599         code.
3600         (macro_define_object_internal): Use macro_define_internal.
3601         (macro_define_function): Likewise.
3602
3603 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3604
3605         * macrocmd.c (extract_identifier): Return
3606         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3607         callers.
3608
3609 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3610
3611         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3612
3613 2019-02-05  Tom Tromey  <tom@tromey.com>
3614
3615         * target.c (target_stack::unpush): Move assertion earlier.
3616
3617 2019-01-30  Tom Tromey  <tom@tromey.com>
3618
3619         PR python/23615:
3620         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3621         (gdbpy_parse_and_eval): Likewise.
3622         * python/python-internal.h (gdbpy_allow_threads): New class.
3623
3624 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3625
3626         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3627         (aarch64_fbsd_fpregmap): Move earlier.
3628         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3629         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3630         instead of individual calls to trad_frame_set_reg_addr.
3631         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3632         earlier.
3633         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3634         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3635         instead of individual calls to trad_frame_set_reg_addr.
3636
3637 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3638
3639         * CONTRIBUTE: Replace contribution list with wiki link.
3640
3641 2019-01-25  Tom Tromey  <tom@tromey.com>
3642
3643         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3644
3645 2019-01-25  Tom Tromey  <tom@tromey.com>
3646
3647         * xtensa-linux-nat.c: Fix common/ includes.
3648         * xml-support.h: Fix common/ includes.
3649         * xml-support.c: Fix common/ includes.
3650         * x86-linux-nat.c: Fix common/ includes.
3651         * windows-nat.c: Fix common/ includes.
3652         * varobj.h: Fix common/ includes.
3653         * varobj.c: Fix common/ includes.
3654         * value.c: Fix common/ includes.
3655         * valops.c: Fix common/ includes.
3656         * utils.c: Fix common/ includes.
3657         * unittests/xml-utils-selftests.c: Fix common/ includes.
3658         * unittests/utils-selftests.c: Fix common/ includes.
3659         * unittests/unpack-selftests.c: Fix common/ includes.
3660         * unittests/tracepoint-selftests.c: Fix common/ includes.
3661         * unittests/style-selftests.c: Fix common/ includes.
3662         * unittests/string_view-selftests.c: Fix common/ includes.
3663         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3664         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3665         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3666         * unittests/rsp-low-selftests.c: Fix common/ includes.
3667         * unittests/parse-connection-spec-selftests.c: Fix common/
3668         includes.
3669         * unittests/optional-selftests.c: Fix common/ includes.
3670         * unittests/offset-type-selftests.c: Fix common/ includes.
3671         * unittests/observable-selftests.c: Fix common/ includes.
3672         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3673         * unittests/memrange-selftests.c: Fix common/ includes.
3674         * unittests/memory-map-selftests.c: Fix common/ includes.
3675         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3676         * unittests/function-view-selftests.c: Fix common/ includes.
3677         * unittests/environ-selftests.c: Fix common/ includes.
3678         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3679         * unittests/common-utils-selftests.c: Fix common/ includes.
3680         * unittests/cli-utils-selftests.c: Fix common/ includes.
3681         * unittests/array-view-selftests.c: Fix common/ includes.
3682         * ui-file.c: Fix common/ includes.
3683         * tui/tui-io.c: Fix common/ includes.
3684         * tracepoint.h: Fix common/ includes.
3685         * tracepoint.c: Fix common/ includes.
3686         * tracefile-tfile.c: Fix common/ includes.
3687         * top.h: Fix common/ includes.
3688         * top.c: Fix common/ includes.
3689         * thread.c: Fix common/ includes.
3690         * target/waitstatus.h: Fix common/ includes.
3691         * target/waitstatus.c: Fix common/ includes.
3692         * target.h: Fix common/ includes.
3693         * target.c: Fix common/ includes.
3694         * target-memory.c: Fix common/ includes.
3695         * target-descriptions.c: Fix common/ includes.
3696         * symtab.h: Fix common/ includes.
3697         * symfile.c: Fix common/ includes.
3698         * stap-probe.c: Fix common/ includes.
3699         * spu-linux-nat.c: Fix common/ includes.
3700         * sparc-nat.c: Fix common/ includes.
3701         * source.c: Fix common/ includes.
3702         * solib.c: Fix common/ includes.
3703         * solib-target.c: Fix common/ includes.
3704         * ser-unix.c: Fix common/ includes.
3705         * ser-tcp.c: Fix common/ includes.
3706         * ser-pipe.c: Fix common/ includes.
3707         * ser-base.c: Fix common/ includes.
3708         * selftest-arch.c: Fix common/ includes.
3709         * s12z-tdep.c: Fix common/ includes.
3710         * rust-exp.y: Fix common/ includes.
3711         * rs6000-aix-tdep.c: Fix common/ includes.
3712         * riscv-tdep.c: Fix common/ includes.
3713         * remote.c: Fix common/ includes.
3714         * remote-notif.h: Fix common/ includes.
3715         * remote-fileio.h: Fix common/ includes.
3716         * remote-fileio.c: Fix common/ includes.
3717         * regcache.h: Fix common/ includes.
3718         * regcache.c: Fix common/ includes.
3719         * record-btrace.c: Fix common/ includes.
3720         * python/python.c: Fix common/ includes.
3721         * python/py-type.c: Fix common/ includes.
3722         * python/py-inferior.c: Fix common/ includes.
3723         * progspace.h: Fix common/ includes.
3724         * producer.c: Fix common/ includes.
3725         * procfs.c: Fix common/ includes.
3726         * proc-api.c: Fix common/ includes.
3727         * printcmd.c: Fix common/ includes.
3728         * ppc-linux-nat.c: Fix common/ includes.
3729         * parser-defs.h: Fix common/ includes.
3730         * osdata.c: Fix common/ includes.
3731         * obsd-nat.c: Fix common/ includes.
3732         * nat/x86-linux.c: Fix common/ includes.
3733         * nat/x86-linux-dregs.c: Fix common/ includes.
3734         * nat/x86-dregs.h: Fix common/ includes.
3735         * nat/x86-dregs.c: Fix common/ includes.
3736         * nat/ppc-linux.c: Fix common/ includes.
3737         * nat/mips-linux-watch.h: Fix common/ includes.
3738         * nat/mips-linux-watch.c: Fix common/ includes.
3739         * nat/linux-waitpid.c: Fix common/ includes.
3740         * nat/linux-ptrace.h: Fix common/ includes.
3741         * nat/linux-ptrace.c: Fix common/ includes.
3742         * nat/linux-procfs.c: Fix common/ includes.
3743         * nat/linux-personality.c: Fix common/ includes.
3744         * nat/linux-osdata.c: Fix common/ includes.
3745         * nat/linux-namespaces.c: Fix common/ includes.
3746         * nat/linux-btrace.h: Fix common/ includes.
3747         * nat/linux-btrace.c: Fix common/ includes.
3748         * nat/fork-inferior.c: Fix common/ includes.
3749         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3750         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3751         * nat/aarch64-linux.c: Fix common/ includes.
3752         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3753         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3754         * namespace.h: Fix common/ includes.
3755         * mips-linux-tdep.c: Fix common/ includes.
3756         * minsyms.c: Fix common/ includes.
3757         * mi/mi-parse.h: Fix common/ includes.
3758         * mi/mi-main.c: Fix common/ includes.
3759         * mi/mi-cmd-env.c: Fix common/ includes.
3760         * memrange.h: Fix common/ includes.
3761         * memattr.c: Fix common/ includes.
3762         * maint.h: Fix common/ includes.
3763         * maint.c: Fix common/ includes.
3764         * main.c: Fix common/ includes.
3765         * machoread.c: Fix common/ includes.
3766         * location.c: Fix common/ includes.
3767         * linux-thread-db.c: Fix common/ includes.
3768         * linux-nat.c: Fix common/ includes.
3769         * linux-fork.c: Fix common/ includes.
3770         * inline-frame.c: Fix common/ includes.
3771         * infrun.c: Fix common/ includes.
3772         * inflow.c: Fix common/ includes.
3773         * inferior.h: Fix common/ includes.
3774         * inferior.c: Fix common/ includes.
3775         * infcmd.c: Fix common/ includes.
3776         * inf-ptrace.c: Fix common/ includes.
3777         * inf-child.c: Fix common/ includes.
3778         * ia64-linux-nat.c: Fix common/ includes.
3779         * i387-tdep.c: Fix common/ includes.
3780         * i386-tdep.c: Fix common/ includes.
3781         * i386-linux-tdep.c: Fix common/ includes.
3782         * i386-linux-nat.c: Fix common/ includes.
3783         * i386-go32-tdep.c: Fix common/ includes.
3784         * i386-fbsd-tdep.c: Fix common/ includes.
3785         * i386-fbsd-nat.c: Fix common/ includes.
3786         * guile/scm-type.c: Fix common/ includes.
3787         * guile/guile.c: Fix common/ includes.
3788         * go32-nat.c: Fix common/ includes.
3789         * gnu-nat.c: Fix common/ includes.
3790         * gdbthread.h: Fix common/ includes.
3791         * gdbarch-selftests.c: Fix common/ includes.
3792         * gdb_usleep.c: Fix common/ includes.
3793         * gdb_select.h: Fix common/ includes.
3794         * gdb_bfd.c: Fix common/ includes.
3795         * gcore.c: Fix common/ includes.
3796         * fork-child.c: Fix common/ includes.
3797         * findvar.c: Fix common/ includes.
3798         * fbsd-nat.c: Fix common/ includes.
3799         * event-top.c: Fix common/ includes.
3800         * event-loop.c: Fix common/ includes.
3801         * dwarf2read.c: Fix common/ includes.
3802         * dwarf2loc.c: Fix common/ includes.
3803         * dwarf2-frame.c: Fix common/ includes.
3804         * dwarf-index-cache.c: Fix common/ includes.
3805         * dtrace-probe.c: Fix common/ includes.
3806         * disasm-selftests.c: Fix common/ includes.
3807         * defs.h: Fix common/ includes.
3808         * csky-tdep.c: Fix common/ includes.
3809         * cp-valprint.c: Fix common/ includes.
3810         * cp-support.h: Fix common/ includes.
3811         * cp-support.c: Fix common/ includes.
3812         * corelow.c: Fix common/ includes.
3813         * completer.h: Fix common/ includes.
3814         * completer.c: Fix common/ includes.
3815         * compile/compile.c: Fix common/ includes.
3816         * compile/compile-loc2c.c: Fix common/ includes.
3817         * compile/compile-cplus-types.c: Fix common/ includes.
3818         * compile/compile-cplus-symbols.c: Fix common/ includes.
3819         * command.h: Fix common/ includes.
3820         * cli/cli-dump.c: Fix common/ includes.
3821         * cli/cli-cmds.c: Fix common/ includes.
3822         * charset.c: Fix common/ includes.
3823         * build-id.c: Fix common/ includes.
3824         * btrace.h: Fix common/ includes.
3825         * btrace.c: Fix common/ includes.
3826         * breakpoint.h: Fix common/ includes.
3827         * breakpoint.c: Fix common/ includes.
3828         * ax.h: 
3829         (enum agent_op): Fix common/ includes.
3830         * ax-general.c (struct aop_map): Fix common/ includes.
3831         * ax-gdb.c: Fix common/ includes.
3832         * auxv.c: Fix common/ includes.
3833         * auto-load.c: Fix common/ includes.
3834         * arm-tdep.c: Fix common/ includes.
3835         * arch/riscv.c: Fix common/ includes.
3836         * arch/ppc-linux-common.c: Fix common/ includes.
3837         * arch/i386.c: Fix common/ includes.
3838         * arch/arm.c: Fix common/ includes.
3839         * arch/arm-linux.c: Fix common/ includes.
3840         * arch/arm-get-next-pcs.c: Fix common/ includes.
3841         * arch/amd64.c: Fix common/ includes.
3842         * arch/aarch64.c: Fix common/ includes.
3843         * arch/aarch64-insn.c: Fix common/ includes.
3844         * arch-utils.c: Fix common/ includes.
3845         * amd64-windows-tdep.c: Fix common/ includes.
3846         * amd64-tdep.c: Fix common/ includes.
3847         * amd64-sol2-tdep.c: Fix common/ includes.
3848         * amd64-obsd-tdep.c: Fix common/ includes.
3849         * amd64-nbsd-tdep.c: Fix common/ includes.
3850         * amd64-linux-tdep.c: Fix common/ includes.
3851         * amd64-linux-nat.c: Fix common/ includes.
3852         * amd64-fbsd-tdep.c: Fix common/ includes.
3853         * amd64-fbsd-nat.c: Fix common/ includes.
3854         * amd64-dicos-tdep.c: Fix common/ includes.
3855         * amd64-darwin-tdep.c: Fix common/ includes.
3856         * agent.c: Fix common/ includes.
3857         * ada-lang.h: Fix common/ includes.
3858         * ada-lang.c: Fix common/ includes.
3859         * aarch64-tdep.c: Fix common/ includes.
3860
3861 2019-01-25  Tom Tromey  <tom@tromey.com>
3862
3863         * common/create-version.sh: Use common/version.h.
3864
3865 2019-01-24  Pedro Alves  <palves@redhat.com>
3866
3867         * infrun.c (signal_stop, signal_print, signal_program)
3868         (signal_catch, signal_pass): Now arrays instead of pointers.
3869         (update_signals_program_target, do_target_resume)
3870         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3871         * linux-nat.c (linux_nat_target::pass_signals)
3872         (linux_nat_target::create_inferior, linux_nat_target::attach):
3873         Adjust.
3874         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3875         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3876         * procfs.c (procfs_target::pass_signals): Adjust.
3877         * record-full.c (record_full_target::resume): Adjust.
3878         * remote.c (remote_target::pass_signals)
3879         (remote_target::program_signals): Adjust.
3880         * target-debug.h (target_debug_print_signals): Now takes a
3881         gdb::array_view as parameter.  Adjust.
3882         * target.h (target_ops) <pass_signals, program_signals>: Replace
3883         pointer and length parameters with gdb::array_view.
3884         (target_pass_signals, target_program_signals): Likewise.
3885         * target-delegates.c: Regenerate.
3886
3887 2019-01-24  Pedro Alves  <palves@redhat.com>
3888
3889         * common/forward-scope-exit.h
3890         (forward_scope_exit::forward_scope_exit): Pass arguments to
3891         m_bind_function directly, instead of creating a std::bind and
3892         copying that.
3893
3894 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3895
3896         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3897         for static members.
3898         (pass_in_v_vfp_candidate): Likewise.
3899
3900 2019-01-23  Tom Tromey  <tom@tromey.com>
3901             Pedro Alves  <palves@redhat.com>
3902
3903         * regcache.c (class regcache_invalidator): Remove.
3904         (regcache::raw_write): Use make_scope_exit.
3905
3906 2019-01-23  Tom Tromey  <tom@tromey.com>
3907
3908         * ui-out.h (class ui_out_emit_type): Update comment.
3909
3910 2019-01-23  Tom Tromey  <tom@tromey.com>
3911
3912         * infrun.c (fetch_inferior_event): Update comment.
3913
3914 2019-01-23  Tom Tromey  <tom@tromey.com>
3915             Pedro Alves  <palves@redhat.com>
3916
3917         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3918         parameter.
3919         (fetch_inferior_event): Use SCOPE_EXIT.
3920
3921
3922 2019-01-23  Tom Tromey  <tom@tromey.com>
3923             Pedro Alves  <palves@redhat.com>
3924
3925         * infrun.c (disable_thread_events): Delete.
3926         (stop_all_threads): Use SCOPE_EXIT.
3927
3928 2019-01-23  Tom Tromey  <tom@tromey.com>
3929             Pedro Alves  <palves@redhat.com>
3930
3931         * symfile.c: Include forward-scope-exit.h.
3932         (clear_symtab_users_cleanup): Replace forward declaration with
3933         a FORWARD_SCOPE_EXIT.
3934         (syms_from_objfile_1): Use the forward_scope_exit and
3935         gdb::optional instead of cleanup_function.
3936         (reread_symbols): Use the forward_scope_exit instead of
3937         cleanup_function.
3938         (clear_symtab_users_cleanup): Remove function.
3939
3940 2019-01-23  Tom Tromey  <tom@tromey.com>
3941             Pedro Alves  <palves@redhat.com>
3942
3943         * linux-nat.c: Include scope-exit.h.
3944         (cleanup_target_stop): Remove.
3945         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3946         SCOPE_EXIT.
3947
3948 2019-01-23  Tom Tromey  <tom@tromey.com>
3949             Pedro Alves  <palves@redhat.com>
3950
3951         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3952         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3953
3954 2019-01-23  Tom Tromey  <tom@tromey.com>
3955             Andrew Burgess  <andrew.burgess@embecosm.com>
3956             Pedro Alves  <palves@redhat.com>
3957
3958         * infrun.c (fetch_inferior_event): Use scope_exit.
3959         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3960         * top.c (execute_command): Use scope_exit.
3961         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3962         * utils.c (do_bpstat_clear_actions_cleanup)
3963         (make_bpstat_clear_actions_cleanup): Remove.
3964
3965 2019-01-23  Tom Tromey  <tom@tromey.com>
3966             Pedro Alves  <palves@redhat.com>
3967
3968         * infrun.c: Include "common/scope-exit.h"
3969         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3970         (wait_for_inferior): Use SCOPE_EXIT.
3971         (fetch_inferior_event): Use scope_exit.
3972
3973 2019-01-23  Tom Tromey  <tom@tromey.com>
3974             Pedro Alves  <palves@redhat.com>
3975
3976         * breakpoint.c (create_breakpoint): Remove cleanup.
3977
3978 2019-01-23  Tom Tromey  <tom@tromey.com>
3979             Andrew Burgess  <andrew.burgess@embecosm.com>
3980             Pedro Alves  <palves@redhat.com>
3981
3982 2019-01-23  Pedro Alves  <palves@redhat.com>
3983
3984         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3985
3986 2019-01-23  Pedro Alves  <palves@redhat.com>
3987             Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * gdbthread.h: Include "common/forward-scope-exit.h".
3990         (scoped_finish_thread_state): Redefine custom class in terms of
3991         forward_scope_exit.
3992
3993 2019-01-23  Pedro Alves  <palves@redhat.com>
3994             Andrew Burgess  <andrew.burgess@embecosm.com>
3995
3996         * common/forward-scope-exit.h: New file.
3997
3998 2019-01-23  Pedro Alves  <palves@redhat.com>
3999             Andrew Burgess  <andrew.burgess@embecosm.com>
4000             Tom Tromey  <tom@tromey.com>
4001
4002         * common/scope-exit.h: New file.
4003
4004 2019-01-23  Pedro Alves  <palves@redhat.com>
4005
4006         * common/preprocessor.h (ESC): Rename to ...
4007         (ESC_PARENS): ... this.
4008         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4009         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4010
4011 2019-01-23  Tom Tromey  <tom@tromey.com>
4012
4013         * language.h (class scoped_switch_to_sym_language_if_auto):
4014         Initialize m_lang in both cases.
4015
4016 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4017
4018         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4019         with XCNEW.
4020
4021 2019-01-22  Tom Tromey  <tom@tromey.com>
4022
4023         * corelow.c: Do not include sys/file.h.
4024
4025 2019-01-22  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-wingeneral.h: Include gdb_curses.h.
4028
4029 2019-01-22  Tom Tromey  <tom@tromey.com>
4030
4031         * source-cache.h (class source_cache) <get_source_lines,
4032         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4033
4034 2019-01-22  Tom Tromey  <tom@tromey.com>
4035
4036         * remote-fileio.h (struct remote_target): Declare.
4037
4038 2019-01-22  Tom Tromey  <tom@tromey.com>
4039
4040         * python/py-arch.c: Do not include py-ref.h.
4041         * python/py-bpevent.c: Do not include py-ref.h.
4042         * python/py-cmd.c: Do not include py-ref.h.
4043         * python/py-continueevent.c: Do not include py-ref.h.
4044         * python/py-event.h: Do not include py-ref.h.
4045         * python/py-evtregistry.c: Do not include py-ref.h.
4046         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4047         * python/py-frame.c: Do not include py-ref.h.
4048         * python/py-framefilter.c: Do not include py-ref.h.
4049         * python/py-function.c: Do not include py-ref.h.
4050         * python/py-infevents.c: Do not include py-ref.h.
4051         * python/py-linetable.c: Do not include py-ref.h.
4052         * python/py-objfile.c: Do not include py-ref.h.
4053         * python/py-param.c: Do not include py-ref.h.
4054         * python/py-prettyprint.c: Do not include py-ref.h.
4055         * python/py-progspace.c: Do not include py-ref.h.
4056         * python/py-symbol.c: Do not include py-ref.h.
4057         * python/py-symtab.c: Do not include py-ref.h.
4058         * python/py-type.c: Do not include py-ref.h.
4059         * python/py-unwind.c: Do not include py-ref.h.
4060         * python/py-utils.c: Do not include py-ref.h.
4061         * python/py-value.c: Do not include py-ref.h.
4062         * python/py-varobj.c: Do not include py-ref.h.
4063         * python/py-xmethods.c: Do not include py-ref.h.
4064         * python/python.c: Do not include py-ref.h.
4065         * varobj.c: Do not include py-ref.h.
4066
4067 2019-01-22  Tom Tromey  <tom@tromey.com>
4068
4069         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4070         keyword for bcache.
4071
4072 2019-01-22  Tom Tromey  <tom@tromey.com>
4073
4074         * compile/compile-cplus-types.c: Remove a comment by #include.
4075
4076 2019-01-22  Tom Tromey  <tom@tromey.com>
4077
4078         * compile/gcc-c-plugin.h: Include compile-internal.h.
4079
4080 2019-01-22  Tom Tromey  <tom@tromey.com>
4081
4082         * stabsread.c (EXTERN): Do not define.
4083         (symnum, next_symbol_text_func, processing_gcc_compilation)
4084         (within_function, global_sym_chain, global_stabs)
4085         (previous_stab_code, this_object_header_files)
4086         (n_this_object_header_files)
4087         (n_allocated_this_object_header_files): Define.
4088         * stabsread.h (EXTERN): Never define.  Use "extern".
4089
4090 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4091
4092         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4093         history_value.
4094
4095 2019-01-21  Tom Tromey  <tom@tromey.com>
4096
4097         * ui-out.c: Fix includes.
4098         * tui/tui-source.c: Fix includes.
4099         * target.c: Fix includes.
4100         * remote.c: Fix includes.
4101         * regcache.c: Fix includes.
4102         * python/py-block.c: Fix includes.
4103         * printcmd.c: Fix includes.
4104         * or1k-tdep.c: Fix includes.
4105         * mi/mi-main.c: Fix includes.
4106         * m32r-tdep.c: Fix includes.
4107         * csky-tdep.c: Fix includes.
4108         * compile/compile-cplus-types.c: Fix includes.
4109         * cli/cli-interp.c: Fix includes.
4110
4111 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4114         for padding.
4115
4116 2019-01-16  Tom Tromey  <tom@tromey.com>
4117
4118         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4119         earlier.
4120         (struct objfile) <msymbols_range>: Move from top level.
4121         <msymbols>: New method.
4122         (class objfile_msymbols): Remove.
4123         * symtab.c (default_collect_symbol_completion_matches_break_on):
4124         Update.
4125         * symmisc.c (dump_msymbols): Update.
4126         * stabsread.c (scan_file_globals): Update.
4127         * objc-lang.c (info_selectors_command, info_classes_command)
4128         (find_methods): Update.
4129         * minsyms.c (find_solib_trampoline_target): Update.
4130         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4131         * coffread.c (coff_symfile_read): Update.
4132         * ada-lang.c (ada_lookup_simple_minsym)
4133         (ada_collect_symbol_completion_matches): Update.
4134
4135 2019-01-16  Tom Tromey  <tom@tromey.com>
4136
4137         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4138         type.  Remove no-argument constructor.
4139         <iterator::operator++>: Simplify.
4140         <begin>: Update.
4141         <end>: Use minimal_symbol_count.
4142
4143 2019-01-16  Tom Tromey  <tom@tromey.com>
4144
4145         * objfiles.h (struct objfile) <psymtabs>: New method.
4146         (class objfile_psymtabs): Remove.
4147         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4148         typedef.
4149         <range>: New method.
4150         (require_partial_symbols): Change return type.
4151         * psymtab.c (require_partial_symbols)
4152         (psym_expand_symtabs_matching): Update.
4153         * mdebugread.c (parse_partial_symbols): Update.
4154         * dbxread.c (dbx_end_psymtab): Update.
4155
4156 2019-01-15  Tom Tromey  <tom@tromey.com>
4157
4158         * symtab.c (lookup_objfile_from_block)
4159         (lookup_symbol_in_objfile_symtabs)
4160         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4161         (find_line_symtab, info_sources_command)
4162         (default_collect_symbol_completion_matches_break_on)
4163         (make_source_files_completion_list): Update.
4164         * symmisc.c (print_objfile_statistics, dump_objfile)
4165         (maintenance_print_symbols, maintenance_info_symtabs)
4166         (maintenance_check_symtabs, maintenance_info_line_tables):
4167         Update.
4168         * source.c (select_source_symtab)
4169         (forget_cached_source_info_for_objfile): Update.
4170         * objfiles.h (class objfile_compunits): Remove.
4171         (struct objfile) <compunits_range>: New typedef.
4172         (compunits): New method.
4173         * objfiles.c (objfile_relocate1): Update.
4174         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4175         * maint.c (count_symtabs_and_blocks): Update.
4176         * linespec.c (iterate_over_all_matching_symtabs): Update.
4177         * cp-support.c (add_symbol_overload_list_qualified): Update.
4178         * coffread.c (coff_symtab_read): Update.
4179         * ada-lang.c (add_nonlocal_symbols)
4180         (ada_collect_symbol_completion_matches)
4181         (ada_add_global_exceptions): Update.
4182
4183 2019-01-15  Tom Tromey  <tom@tromey.com>
4184
4185         * progspace.h (program_space) <objfiles_safe_range>: New
4186         typedef.
4187         <objfiles_safe>: New method.
4188         * objfiles.h (class all_objfiles_safe): Remove.
4189         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4190         * jit.c (jit_inferior_exit_hook): Update.
4191
4192 2019-01-17  Tom Tromey  <tom@tromey.com>
4193
4194         * progspace.h (program_space) <objfiles_range>: New typedef.
4195         <objfiles>: New method.
4196         <objfiles_head>: Rename from objfiles.
4197         (object_files): Update.
4198         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4199         * guile/scm-pretty-print.c
4200         (ppscm_find_pretty_printer_from_objfiles): Update.
4201         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4202         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4203         Update.
4204         * python/py-progspace.c (pspy_get_objfiles): Update.
4205         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4206         Update.
4207         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4208         (objfpy_lookup_objfile_by_build_id): Update.
4209         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4210         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4211         Update.
4212         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4213         (expand_symtab_containing_pc, lookup_objfile_from_block)
4214         (lookup_static_symbol, basic_lookup_transparent_type)
4215         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4216         (find_line_symtab, info_sources_command)
4217         (default_collect_symbol_completion_matches_break_on)
4218         (make_source_files_completion_list, find_main_name): Update.
4219         * symmisc.c (print_symbol_bcache_statistics)
4220         (print_objfile_statistics, maintenance_print_symbols)
4221         (maintenance_print_msymbols, maintenance_print_objfiles)
4222         (maintenance_info_symtabs, maintenance_check_symtabs)
4223         (maintenance_expand_symtabs, maintenance_info_line_tables):
4224         Update.
4225         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4226         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4227         (map_overlay_command, unmap_overlay_command)
4228         (simple_overlay_update, expand_symtabs_matching)
4229         (map_symbol_filenames): Update.
4230         * symfile-debug.c (set_debug_symfile): Update.
4231         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4232         Update.
4233         * source.c (select_source_symtab, forget_cached_source_info):
4234         Update.
4235         * solib.c (solib_read_symbols): Update.
4236         * solib-spu.c (append_ocl_sos): Update.
4237         * psymtab.c (maintenance_print_psymbols)
4238         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4239         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4240         * printcmd.c (info_symbol_command): Update.
4241         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4242         Update.
4243         * objfiles.h (class all_objfiles): Remove.
4244         * objfiles.c (have_partial_symbols, have_full_symbols)
4245         (have_minimal_symbols, qsort_cmp, update_section_map)
4246         (shared_objfile_contains_address_p)
4247         (default_iterate_over_objfiles_in_search_order): Update.
4248         * objc-lang.c (info_selectors_command, info_classes_command)
4249         (find_methods): Update.
4250         * minsyms.c (find_solib_trampoline_target): Update.
4251         * maint.c (maintenance_info_sections)
4252         (maintenance_translate_address, count_symtabs_and_blocks):
4253         Update.
4254         * main.c (captured_main_1): Update.
4255         * linux-thread-db.c (try_thread_db_load_from_pdir)
4256         (has_libpthread): Update.
4257         * linespec.c (iterate_over_all_matching_symtabs)
4258         (search_minsyms_for_name): Update.
4259         * jit.c (jit_find_objf_with_entry_addr): Update.
4260         * hppa-tdep.c (find_unwind_entry)
4261         (hppa_lookup_stub_minimal_symbol): Update.
4262         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4263         Update.
4264         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4265         (elf_gnu_ifunc_resolve_by_got): Update.
4266         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4267         * dwarf-index-write.c (save_gdb_index_command): Update.
4268         * cp-support.c (add_symbol_overload_list_qualified): Update.
4269         * breakpoint.c (create_overlay_event_breakpoint)
4270         (create_longjmp_master_breakpoint)
4271         (create_std_terminate_master_breakpoint)
4272         (create_exception_master_breakpoint): Update.
4273         * blockframe.c (find_pc_partial_function): Update.
4274         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4275         (ada_collect_symbol_completion_matches)
4276         (ada_add_global_exceptions): Update.
4277
4278 2019-01-17  Tom Tromey  <tom@tromey.com>
4279
4280         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4281         declare VEC.
4282         (solib_target_parse_libraries): Change return type.
4283         (library_list_start_segment, library_list_start_section)
4284         (library_list_end_library, library_list_start_library); Update.
4285         (solib_target_free_library_list): Remove.
4286         (solib_target_parse_libraries): Remove cleanup.  Change return
4287         type.
4288         (solib_target_current_sos): Update.
4289
4290 2019-01-17  Tom Tromey  <tromey@bapiya>
4291
4292         * valprint.c: Replace "the the" with "the".
4293         * symtab.c: Replace "the the" with "the".
4294         * solib.c: Replace "the the" with "the".
4295         * solib-dsbt.c: Replace "the the" with "the".
4296         * linespec.c: Replace "the the" with "the".
4297         * dwarf2loc.h: Replace "the the" with "the".
4298         * amd64-windows-tdep.c: Replace "the the" with "the".
4299         * aarch64-tdep.c: Replace "the the" with "the".
4300
4301 2019-01-16  Keith Seitz  <keiths@redhat.com>
4302
4303         PR gdb/23773
4304         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4305         <builder>: Rename to ..
4306         <m_builder>: ... this and make private.
4307         (dwarf2_cu::get_builder): New method.  Change all users of
4308         `builder' to use this method.
4309         (dwarf2_start_symtab): Move to ...
4310         (dwarf2_cu::start_symtab): ... here.  Update all callers
4311         (setup_type_unit_groups): Move to ...
4312         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4313         callers.
4314         (dwarf2_cu::reset_builder): New method.
4315         (process_full_compunit, process_full_type_unit): Use
4316         dwarf2_cu::reset_builder.
4317         (follow_die_offset): Record the ancestor CU if it is different
4318         from the followed DIE's CU.
4319         (follow_die_sig_1): Likewise.
4320
4321 2019-01-15  Tom Tromey  <tom@tromey.com>
4322
4323         * remote.c (class remote_state) <buf>: Now a char_vector.
4324         <buf_size>: Remove.
4325         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4326         parameter.
4327         (remote_target::getpkt_or_notif_sane_1)
4328         (remote_target::getpkt_sane)
4329         (remote_target::getpkt_or_notif_sane): Likewise.
4330         (class remote_target) <putpkt>: New overload.
4331         (remote_target::read_frame): Change type of "buf_p".  Remove
4332         sizeof_p parameter.
4333         (packet_ok): New overload.
4334         (packet_check_result): New overload.
4335         Update all uses.
4336
4337 2019-01-14  Tom Tromey  <tom@tromey.com>
4338
4339         * remote-notif.c (handle_notification, remote_notif_ack)
4340         (remote_notif_parse): Make "buf" const.
4341         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4342         const.
4343         (remote_notif_parse, remote_notif_ack, handle_notification):
4344         Likewise.
4345         * remote.c (remote_notif_stop_parse): Make "buf" const.
4346         (remote_target::remote_parse_stop_reply): Make "buf" const.
4347         (remote_notif_stop_ack): Make "buf" const.
4348
4349 2019-01-14  Tom Tromey  <tom@tromey.com>
4350
4351         * remote.c (remote_console_output): Make parameter const.
4352
4353 2019-01-14  Tom Tromey  <tom@tromey.com>
4354
4355         * target-debug.h (target_debug_print_signals): Constify.
4356         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4357         * procfs.c (procfs_target::pass_signals): Update.
4358         * linux-nat.c (linux_nat_target::pass_signals): Update.
4359         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4360         * target-delegates.c: Rebuild.
4361         * remote.c (remote_target::program_signals): Update.
4362         (remote_target::pass_signals): Update.
4363         * target.c (target_pass_signals): Constify argument.
4364         (target_program_signals): Likewise.
4365         * target.h (struct target_ops) <pass_signals, program_signals>:
4366         Constify argument.
4367         (target_pass_signals, target_program_signals): Constify argument.
4368
4369 2019-01-14  Tom Tromey  <tom@tromey.com>
4370
4371         PR tui/28819:
4372         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4373
4374 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4375
4376         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4377         field.
4378         * rs6000-tdep.c: Include reggroups.h.
4379         (IS_V_ALIAS_PSEUDOREG): Define.
4380         (rs6000_register_name): Return names for the "vX" aliases.
4381         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4382         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4383         aliases.  Call default_register_reggroup_p for all other
4384         pseudo-registers.
4385         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4386         New functions.
4387         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4388         Handle "vX" aliases.
4389         (v_alias_pseudo_register_collect): New function.
4390         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4391         (rs6000_gdbarch_init): Initialize "vX" aliases as
4392         pseudo-registers.  Restore registration of
4393         rs6000_pseudo_register_reggroup_p with
4394         set_tdesc_pseudo_register_reggroup_p.
4395
4396 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4397
4398         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4399         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4400         set_gdbarch_num_pseudo_regs.
4401
4402 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4403
4404         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4405         Remove arg prefixname, add do_set and do_show.
4406         Add member functions set_list and show_list.
4407         * cli/cli-style.c (class cli_style_option): Update accordingly.
4408         (style_set_list): Move to file scope.
4409         (style_show_list): Likewise.
4410         (set_style): Call help_list.
4411         (show_style): Call cmd_show_list.
4412         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4413         Update to use the new macro.
4414
4415 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4416
4417         * ada-lang.c (_initialize_ada_language): Expand the help text
4418         for the "catch exception" command.
4419
4420 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4421
4422         * symtab.c (matching_obj_sections): Initialize obj,
4423         declare it closer to its usage.
4424
4425 2019-01-10  Tom Tromey  <tom@tromey.com>
4426
4427         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4428         (basic_inf_threads_range): Remove.
4429         (inf_threads_range, inf_non_exited_threads_range)
4430         (safe_inf_threads_range): Use next_adapter.
4431
4432 2019-01-10  Keith Seitz  <keiths@redhat.com>
4433
4434         PR gdb/23712
4435         PR symtab/23010
4436         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4437         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4438
4439 2019-01-10  Keith Seitz  <keiths@redhat.com>
4440
4441         PR gdb/23712
4442         PR symtab/23010
4443         * dictionary.c (pending_to_vector): Remove.
4444         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4445         Remove _1 suffix, replacing functions of the same name.  Update
4446         all callers.
4447         (dict_create_hashed, dict_create_hashed_expandable)
4448         (dict_create_linear, dict_create_linear_expandable, dict_free)
4449         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4450         Make functions static.
4451
4452 2019-01-10  Keith Seitz  <keiths@redhat.com>
4453
4454         PR gdb/23712
4455         PR symtab/23010
4456         * dictionary.h (struct dictionary): Replace declaration with
4457         multidictionary.
4458         (dict_create_hashed, dict_create_hashed_expandable)
4459         (dict_create_linear, dict_create_linear_expandable)
4460         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4461         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4462         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4463         taking multidictionary argument.
4464         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4465         * block.h (struct block) <dict>: Change to multidictionary
4466         and rename `multidict'.
4467         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4468         symmisc.c: Update all dictionary references to multidictionary.
4469
4470 2019-01-10  Keith Seitz  <keiths@redhat.com>
4471
4472         PR gdb/23712
4473         PR symtab/23010
4474         * dictionary.c: Include unordered_map.
4475         (pending_to_vector): New function.
4476         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4477         Rewrite the non-"_1" functions to take vector instead
4478         of linked list.
4479         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4480         "new" _1 versions of the same name.
4481         (multidictionary): Define.
4482         (std::hash<enum language): New definition.
4483         (collate_pending_symbols_by_language, mdict_create_hashed)
4484         (mdict_create_hashed_expandable, mdict_create_linear)
4485         (mdict_create_linear_expandable, mdict_free)
4486         (find_language_dictionary, create_new_language_dictionary)
4487         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4488         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4489         (mdict_size, mdict_empty): New functions.
4490         * dictionary.h (mdict_iterator): Define.
4491
4492 2019-01-10  Pedro Alves  <palves@redhat.com>
4493
4494         * breakpoint.c (read_uploaded_action)
4495         (create_tracepoint_from_upload): Adjust to use
4496         gdb::unique_xmalloc_ptr.
4497         * ctf.c (ctf_write_uploaded_tp):
4498         (SET_ARRAY_FIELD): Use emplace_back.
4499         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4500         * tracefile-tfile.c (tfile_write_uploaded_tp):
4501         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4502         gdb::unique_xmalloc_ptr.
4503         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4504         at_string, cond_string, cmd_strings>: Replace char pointers
4505         with gdb::unique_xmalloc_ptr.
4506
4507 2019-01-10  Pedro Alves  <palves@redhat.com>
4508
4509         * solib-target.c (library_list_start_library): Don't xstrdup name.
4510
4511 2019-01-10  Pedro Alves  <palves@redhat.com>
4512
4513         * mdebugread.c (parse_partial_symbols): Use
4514         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4515
4516 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * linux-fork.c (scoped_switch_fork_info)
4519         <~scoped_switch_fork_info>: Fix incorrect variable name.
4520
4521 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * linux-fork.c (scoped_switch_fork_info)
4524         <scoped_switch_fork_info>: Make explicit.
4525         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4526
4527 2019-01-10  Tom Tromey  <tom@tromey.com>
4528
4529         * objfiles.h (objfile::reset_psymtabs): Update.
4530         * objfiles.c (objfile::objfile): Update.
4531         * psymtab.h (psymtab_storage::obstack): Update.
4532         (psymtab_storage::m_obstack): Use gdb::optional.
4533         (class psymtab_storage): Update comment.  Remove objfile
4534         parameter.
4535         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4536
4537 2019-01-10  Tom Tromey  <tom@tromey.com>
4538
4539         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4540         <free_psymtabs>: Now private.
4541         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4542         (allocate_psymtab): Use new method.
4543
4544 2019-01-10  Tom Tromey  <tom@tromey.com>
4545
4546         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4547         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4548         * mdebugread.c (parse_partial_symbols): Use
4549         allocate_dependencies.
4550         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4551         allocate_dependencies.
4552         (process_psymtab_comp_unit_reader)
4553         (build_type_psymtab_dependencies): Likewise.
4554         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4555
4556 2019-01-10  Tom Tromey  <tom@tromey.com>
4557
4558         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4559         PSYMBOL_SET_LANGUAGE.
4560         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4561
4562 2019-01-10  Tom Tromey  <tom@tromey.com>
4563
4564         * psymtab.h (psymtab_storage::obstack): New method.
4565         <m_obstack>: Rename from obstack; now private.
4566         * psymtab.c (psymtab_storage): Update.
4567         * dwarf2read.c (create_addrmap_from_index)
4568         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4569         Update.
4570
4571 2019-01-10  Tom Tromey  <tom@tromey.com>
4572
4573         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4574         * objfiles.h (objfile::reset_psymtabs): New method.
4575
4576 2019-01-10  Tom Tromey  <tom@tromey.com>
4577
4578         * symmisc.c (print_symbol_bcache_statistics): Update.
4579         (print_objfile_statistics): Update.
4580         * symfile.c (reread_symbols): Update.
4581         * psymtab.h (class psymtab_storage): New.
4582         * psymtab.c (psymtab_storage): New constructor.
4583         (~psymtab_storage): New destructor.
4584         (require_partial_symbols): Update.
4585         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4586         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4587         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4588         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4589         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4590         (start_psymtab_common, end_psymtab_common)
4591         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4592         (allocate_psymtab): Update.
4593         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4594         Update.
4595         (dump_psymtab_addrmap, maintenance_print_psymbols)
4596         (maintenance_check_psymtabs): Update.
4597         (class objfile_psymtabs): Move to objfiles.h.
4598         * psympriv.h (discard_psymtab): Now inline.
4599         (psymtab_discarder::psymtab_discarder): Update.
4600         (psymtab_discarder::~psymtab_discarder): Update.
4601         (ALL_OBJFILE_PSYMTABS): Rewrite.
4602         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4603         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4604         Remove fields.
4605         <partial_symtabs>: New field.
4606         (class objfile_psymtabs): Move from psymtab.h.  Update.
4607         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4608         psymbol_cache.
4609         (objfile::~objfile): Don't destroy psymbol_cache.
4610         * mdebugread.c (parse_partial_symbols): Update.
4611         * dwarf2read.c (create_addrmap_from_index)
4612         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4613         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4614         (add_partial_subprogram, dwarf2_ranges_read): Update.
4615         * dwarf-index-write.c (write_address_map)
4616         (write_one_signatured_type, recursively_write_psymbols)
4617         (class debug_names, class debug_names, write_psymtabs_to_index):
4618         Update.
4619
4620 2019-01-10  Tom Tromey  <tom@tromey.com>
4621
4622         * symtab.h (SYMBOL_SET_NAMES): Update.
4623         (symbol_set_names): Update.
4624         (MSYMBOL_SET_NAMES): Update.
4625         * symtab.c (symbol_set_names): Change argument to be an
4626         objfile_per_bfd_storage.
4627         * psymtab.c (add_psymbol_to_bcache): Update.
4628         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4629
4630 2019-01-10  Tom Tromey  <tom@tromey.com>
4631
4632         * symtab.c (create_demangled_names_hash): Change argument to be an
4633         objfile_per_bfd_storage.
4634         (symbol_set_names): Update.
4635
4636 2019-01-10  Tom Tromey  <tom@tromey.com>
4637
4638         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4639         init_psymbol_list.
4640         * psymtab.c (init_psymbol_list): Do nothing if already called.
4641         * psympriv.h (init_psymbol_list): Add comment.
4642         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4643         init_psymbol_list.
4644         * dbxread.c (dbx_symfile_read): Unconditionally call
4645         init_psymbol_list.
4646
4647 2019-01-10  Tom Tromey  <tom@tromey.com>
4648
4649         * xcoffread.c (scan_xcoff_symtab): Update.
4650         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4651         "where".
4652         * mdebugread.c (parse_partial_symbols)
4653         (handle_psymbol_enumerators): Update.
4654         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4655         * dbxread.c (read_dbx_symtab): Update.
4656         * psympriv.h (psymbol_placement): New enum.
4657         (add_psymbol_to_list): Update.
4658
4659 2019-01-10  Tom Tromey  <tom@tromey.com>
4660
4661         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4662         static_psymbols parameters.
4663         (scan_xcoff_symtab): Update.
4664         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4665         static_psymbols parameters.
4666         * psympriv.h (start_psymtab_common): Update.
4667         * mdebugread.c (parse_partial_symbols): Update.
4668         * dwarf2read.c (create_partial_symtab): Update.
4669         * dbxread.c (read_dbx_symtab): Update.
4670         (start_psymtab): Remove global_psymbols and static_psymbols
4671         parameters.
4672
4673 2019-01-10  Tom Tromey  <tom@tromey.com>
4674
4675         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4676         * psymtab.c (allocate_psymtab): Add comment.
4677         * psympriv.h (allocate_psymtab): Add comment.
4678         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4679         initializations.
4680         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4681
4682 2019-01-10  Tom Tromey  <tom@tromey.com>
4683
4684         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4685         Don't declare.
4686         * mipsread.c: Include mdebugread.h.
4687         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4688         Declare.
4689         * elfread.c: Include mdebugread.h.
4690
4691 2019-01-09  Tom Tromey  <tom@tromey.com>
4692
4693         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4694         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4695         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4696         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4697         (psym_lookup_symbol, psym_find_last_source_symtab)
4698         (psym_forget_cached_source_info, psym_print_stats)
4699         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4700         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4701         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4702         (psym_find_compunit_symtab_by_address)
4703         (maintenance_print_psymbols, maintenance_info_psymtabs)
4704         (maintenance_check_psymtabs): Use ranged for.
4705         * psymtab.h (class objfile_psymtabs): New.
4706         (require_partial_symbols): Return objfile_psymtabs.
4707         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4708
4709 2019-01-09  Tom Tromey  <tom@tromey.com>
4710
4711         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4712         (find_pc_mapped_section, list_overlays_command)
4713         (map_overlay_command, unmap_overlay_command)
4714         (simple_overlay_update): Use all_objfiles.
4715         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4716         * printcmd.c (info_symbol_command): Use all_objfiles.
4717         * objfiles.h (ALL_OBJSECTIONS): Remove.
4718         * maint.c (maintenance_translate_address): Use all_objfiles.
4719         * gcore.c (gcore_create_callback): Use all_objfiles.
4720         (objfile_find_memory_regions): Likewise.
4721
4722 2019-01-09  Tom Tromey  <tom@tromey.com>
4723
4724         * symtab.c (find_line_symtab, info_sources_command)
4725         (make_source_files_completion_list): Use objfile_compunits.
4726         * source.c (select_source_symtab): Use objfile_compunits.
4727         * objfiles.h (struct objfile): Update comment.
4728         (ALL_OBJFILES): Remove.
4729         (ALL_FILETABS): Remove.
4730         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4731         objfile_compunits.
4732
4733 2019-01-09  Tom Tromey  <tom@tromey.com>
4734
4735         * symmisc.c (print_objfile_statistics, dump_objfile)
4736         (maintenance_print_symbols): Use compunit_filetabs.
4737         * source.c (forget_cached_source_info_for_objfile): Use
4738         compunit_filetabs.
4739         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4740         (ALL_FILETABS): Use compunit_filetabs.
4741         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4742         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4743
4744 2019-01-09  Tom Tromey  <tom@tromey.com>
4745
4746         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4747         (compunit_filetabs): New.
4748         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4749         compunit_filetabs.
4750         (info_sources_command, make_source_files_completion_list): Remove
4751         declaration.
4752         * symmisc.c (print_objfile_statistics, dump_objfile)
4753         (maintenance_print_symbols): Remove declaration.
4754         (maintenance_info_symtabs): Use compunit_filetabs.
4755         (maintenance_info_line_tables): Likewise.
4756         * source.c (select_source_symtab): Change local variable name.
4757         (forget_cached_source_info_for_objfile): Remove declaration.
4758         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4759         * objfiles.c (objfile_relocate1): Remove declaration.
4760         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4761         declaration.
4762         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4763         * coffread.c (coff_symtab_read): Remove declaration.
4764         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4765         compunit_filetabs.
4766
4767 2019-01-09  Tom Tromey  <tom@tromey.com>
4768
4769         * symtab.c (lookup_objfile_from_block)
4770         (find_pc_sect_compunit_symtab, search_symbols)
4771         (default_collect_symbol_completion_matches_break_on): Use
4772         objfile_compunits.
4773         * objfiles.h (ALL_COMPUNITS): Remove.
4774         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4775         * cp-support.c (add_symbol_overload_list_qualified): Use
4776         objfile_compunits.
4777         * ada-lang.c (ada_collect_symbol_completion_matches)
4778         (ada_add_global_exceptions): Use objfile_compunits.
4779
4780 2019-01-09  Tom Tromey  <tom@tromey.com>
4781
4782         * source.c (select_source_symtab)
4783         (forget_cached_source_info_for_objfile): Remove declaration.
4784         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4785         declaration.
4786         * maint.c (count_symtabs_and_blocks): Remove declaration.
4787         * cp-support.c (add_symbol_overload_list_qualified): Remove
4788         declaration.
4789         * coffread.c (coff_symtab_read): Remove declaration.
4790         * symtab.c (lookup_symbol_in_objfile_symtabs)
4791         (basic_lookup_transparent_type_1): Use objfile_compunits.
4792         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4793         (info_sources_command, search_symbols)
4794         (default_collect_symbol_completion_matches_break_on)
4795         (make_source_files_completion_list): Remove declaration.
4796         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4797         (ada_collect_symbol_completion_matches)
4798         (ada_add_global_exceptions): Remove declaration.
4799         * linespec.c (iterate_over_all_matching_symtabs): Use
4800         objfile_compunits.
4801         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4802         (class objfile_compunits): New.
4803         (ALL_COMPUNITS): Use objfile_compunits.
4804         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4805         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4806         objfile_compunits.
4807         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4808
4809 2019-01-09  Tom Tromey  <tom@tromey.com>
4810
4811         * symtab.c (search_symbols)
4812         (default_collect_symbol_completion_matches_break_on): Use
4813         objfile_msymbols.
4814         * ada-lang.c (ada_lookup_simple_minsym)
4815         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4816         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4817         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4818         objfile_msymbols.
4819         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4820         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4821         * objc-lang.c (find_methods): Use objfile_msymbols.
4822         (info_selectors_command, info_classes_command): Likewise.
4823         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4824         * objfiles.h (class objfile_msymbols): New.
4825         (ALL_OBJFILE_MSYMBOLS): Remove.
4826         (ALL_MSYMBOLS): Remove.
4827
4828 2019-01-09  Tom Tromey  <tom@tromey.com>
4829
4830         * common/next-iterator.h (next_adapter): Add Iterator template
4831         parameter.
4832         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4833         (class all_objfiles_safe): New.
4834         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4835         * objfiles.c (put_objfile_before): Update comment.
4836         (add_separate_debug_objfile): Likewise.
4837         (free_all_objfiles): Use all_objfiles_safe.
4838         (objfile_purge_solibs): Likewise.
4839
4840 2019-01-09  Tom Tromey  <tom@tromey.com>
4841
4842         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4843         (expand_symtab_containing_pc, lookup_static_symbol)
4844         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4845         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4846         all_objfiles.
4847         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4848         * breakpoint.c (create_overlay_event_breakpoint)
4849         (create_longjmp_master_breakpoint)
4850         (create_std_terminate_master_breakpoint)
4851         (create_exception_master_breakpoint): Use all_objfiles.
4852         * linux-thread-db.c (try_thread_db_load_from_pdir)
4853         (has_libpthread): Use all_objfiles.
4854         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4855         * linespec.c (iterate_over_all_matching_symtabs)
4856         (search_minsyms_for_name): Use all_objfiles.
4857         * maint.c (maintenance_info_sections): Use all_objfiles.
4858         * main.c (captured_main_1): Use all_objfiles.
4859         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4860         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4861         * guile/scm-pretty-print.c
4862         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4863         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4864         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4865         (maintenance_print_msymbols): Use all_objfiles.
4866         * source.c (select_source_symtab): Use all_objfiles.
4867         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4868         * symfile.c (remove_symbol_file_command)
4869         (expand_symtabs_matching, map_symbol_filenames): Use
4870         all_objfiles.
4871         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4872         all_objfiles.
4873         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4874         * objc-lang.c (find_methods): Use all_objfiles.
4875         * objfiles.c (have_partial_symbols, have_full_symbols)
4876         (have_minimal_symbols, qsort_cmp)
4877         (default_iterate_over_objfiles_in_search_order): Use
4878         all_objfiles.
4879         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4880         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4881         (maintenance_check_psymtabs): Use all_objfiles.
4882         (ALL_PSYMTABS): Remove.
4883         * compile/compile-object-run.c (do_module_cleanup): Use
4884         all_objfiles.
4885         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4886         * cp-support.c (add_symbol_overload_list_qualified): Use
4887         all_objfiles.
4888         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4889         Use all_objfiles.
4890         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4891         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4892         all_objfiles.
4893         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4894         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4895         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4896         Uses all_objfiles.
4897         * solib.c (solib_read_symbols): Use all_objfiles
4898
4899 2019-01-09  Tom Tromey  <tom@tromey.com>
4900
4901         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4902         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4903         all_objfiles.
4904         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4905         * symmisc.c (print_symbol_bcache_statistics)
4906         (print_objfile_statistics, maintenance_print_objfiles)
4907         (maintenance_info_symtabs, maintenance_check_symtabs)
4908         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4909         all_objfiles.
4910         * source.c (forget_cached_source_info): Use all_objfiles.
4911         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4912         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4913         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4914         * objfiles.c (update_section_map): Use all_objfiles.
4915         (shared_objfile_contains_address_p): Likewise.
4916         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4917         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4918
4919 2019-01-09  Tom Tromey  <tom@tromey.com>
4920
4921         * common/next-iterator.h: New file.
4922         * objfiles.h (class all_objfiles): New.
4923         (struct objfile_iterator): New.
4924
4925 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4926
4927         * NEWS: Move the description of the changed "frame", "select-frame",
4928          and "info frame" commands to the Changed commands section.
4929
4930 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4931
4932         * gdbtypes.c (check_stub_method_group): Remove handling of old
4933         mangling schemes.
4934         * linespec.c (find_methods): Likewise.
4935         * stabsread.c (read_member_functions): Likewise.
4936         * valops.c (search_struct_method): Likewise.
4937         (value_struct_elt_for_reference): Likewise.
4938         * NEWS: Mention this change.
4939
4940 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4941
4942         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4943         print_source_lines.
4944         * source.c (print_source_lines_base): Update line number check.
4945         (print_source_lines): New function.
4946         (source_lines_range::source_lines_range): New function.
4947         * source.h (class source_lines_range): New class.
4948         (print_source_lines): New declaration.
4949
4950 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4951
4952         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4953
4954 2019-01-08  Tom Tromey  <tom@tromey.com>
4955             Simon Marchi  <simon.marchi@ericsson.com>
4956
4957         PR gdb/24060
4958         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4959         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4960         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4961         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4962         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4963         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4964
4965 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * source.c (select_source_symtab): Move header comment to
4968         declaration in source.h.
4969         (forget_cached_source_info_for_objfile): Likewise.
4970         (forget_cached_source_info): Likewise.
4971         (identify_source_line): Likewise.
4972         * source.h (identify_source_line): Move declaration from symtab.h
4973         and add comment from source.c
4974         (print_source_lines): Likewise.
4975         (forget_cached_source_info_for_objfile): Likewise.
4976         (forget_cached_source_info): Likewise.
4977         (select_source_symtab): Likewise.
4978         (enum print_source_lines_flag): Move definition from symtab.h.
4979         * symtab.h (identify_source_line): Move declaration to source.h.
4980         (print_source_lines): Likewise.
4981         (forget_cached_source_info_for_objfile): Likewise.
4982         (forget_cached_source_info): Likewise.
4983         (select_source_symtab): Likewise.
4984         (enum print_source_lines_flag): Move definition to source.h.
4985         * tui/tui-hooks.c: Add 'source.h' include.
4986
4987 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * source.c (print_source_lines_base): Handle requests to print
4990         reverse line number sequences, and guard against empty lines
4991         string.
4992
4993 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * source.c (print_source_lines_base): Fix skip of '\r' if next
4996         character is '\n'.
4997
4998 2019-01-06  Tom Tromey  <tom@tromey.com>
4999
5000         * c-exp.y (struct c_parse_state) <macro_original_text,
5001         expansion_obstack>: New member.
5002         (macro_original_text, expansion_obstack): Remove globals.
5003         (scan_macro_expansion, scanning_macro_expansion)
5004         (finished_macro_expansion): Update.
5005         (scan_macro_cleanup): Remove.
5006         (yylex, c_parse): Update.
5007
5008 2019-01-06  Tom Tromey  <tom@tromey.com>
5009
5010         * c-exp.y (struct c_parse_state) <strings>: New member.
5011         (operator_stoken): Update.
5012
5013 2019-01-06  Tom Tromey  <tom@tromey.com>
5014
5015         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5016         (union type_stack_elt) <typelist_val>: Now a pointer to
5017         std::vector.
5018         (type_stack_cleanup): Don't declare.
5019         (push_typelist): Update.
5020         * parse.c (pop_typelist): Return a std::vector.
5021         (push_typelist): Take a std::vector.
5022         (follow_types): Update.  Do not free args.
5023         (type_stack_cleanup): Remove.
5024         * c-exp.y (struct c_parse_state): New.
5025         (cpstate): New global.
5026         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5027         (nonempty_typelist): Update.
5028         (func_mod): Create a new vector.
5029         (c_parse): Create a c_parse_state.
5030         (check_parameter_typelist): Do not delete params.
5031         (function_method): Update.  Do not delete type_list.
5032
5033 2019-01-06  Tom Tromey  <tom@tromey.com>
5034
5035         PR gdb/28155:
5036         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5037         check_typedef.
5038         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5039         (print_return_value): Likewise.
5040
5041 2019-01-05  Tom Tromey  <tom@tromey.com>
5042
5043         * contrib/cleanup_check.py: Remove.
5044         * contrib/gcc-with-excheck: Remove.
5045         * contrib/exsummary.py: Remove.
5046         * contrib/excheck.py: Remove.
5047
5048 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5049
5050         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5051         NULL. Initialize tpprev to NULL instead of assigning it
5052         to NULL on the next statement.
5053         * windows-nat.c (windows_delete_thread): Remove check for
5054         main_thread_id before printing thread exit notifications.
5055         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5056         Remove thread ID check against main_thread_id.
5057         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5058         windows_delete_thread.
5059         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5060
5061 2019-01-04  Tom Tromey  <tom@tromey.com>
5062
5063         * compile/compile.c (_initialize_compile): Use upper case for
5064         metasyntactic variables.
5065         * symmisc.c (_initialize_symmisc): Use upper case for
5066         metasyntactic variables.
5067         * psymtab.c (_initialize_psymtab): Use upper case for
5068         metasyntactic variables.
5069         * demangle.c (demangle_command): Use upper case for metasyntactic
5070         variables.
5071         (_initialize_demangler): Likewise.
5072         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5073         variables.
5074
5075 2019-01-03  Tom Tromey  <tom@tromey.com>
5076
5077         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5078
5079 2019-01-03  Tom Tromey  <tom@tromey.com>
5080
5081         * python/py-symtab.c (salpy_str): Update.
5082         (struct salpy_sal_object) <symtab>: Now a PyObject.
5083         (salpy_dealloc): Update.
5084         (del_objfile_sal): Use gdbpy_ref.
5085
5086 2019-01-03  Tom Tromey  <tom@tromey.com>
5087
5088         * python/py-type.c (convert_field): Use new_reference.  Return
5089         gdbpy_ref.
5090         (make_fielditem): Return gdbpy_ref.
5091         (typy_fields): Update.
5092         (typy_getitem): Update.
5093         (field_name): Return gdbpy_ref.  Use new_reference.
5094         (typy_iterator_iternext): Update.
5095
5096 2019-01-03  Tom Tromey  <tom@tromey.com>
5097
5098         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5099
5100 2019-01-03  Tom Tromey  <tom@tromey.com>
5101
5102         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5103         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5104         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5105         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5106         (pspy_set_type_printers): Likewise.
5107         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5108         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5109         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5110         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5111         (objfpy_set_type_printers): Likewise.
5112
5113 2019-01-03  Tom Tromey  <tom@tromey.com>
5114
5115         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5116         (gdbpy_print_stack): Use gdbpy_err_fetch.
5117         * python/python-internal.h (class gdbpy_err_fetch): New class.
5118         (class gdbpy_enter) <m_error_type, m_error_value,
5119         m_error_traceback>: Remove.
5120         <m_error>: New member.
5121         (gdbpy_exception_to_string): Don't declare.
5122         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5123         * python/py-value.c (convert_value_from_python): Use
5124         gdbpy_err_fetch.
5125         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5126         gdbpy_exception_to_string.
5127         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5128         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5129         gdbpy_err_fetch.
5130
5131 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5132
5133         * linux-nat.c (delete_lwp_cleanup): Delete.
5134         (struct lwp_deleter): New struct.
5135         (lwp_info_up): New typedef.
5136         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5137         lwp_info_up.
5138
5139 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5140
5141         * linux-fork.c (class scoped_switch_fork_info): New class.
5142         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5143
5144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * valops.c (find_overload_match): Remove use of null_cleanup, and
5147         calls to do_cleanups.
5148
5149 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * compile/compile-cplus-types.c
5152         (compile_cplus_instance::decl_name): Handle changes to
5153         cp_func_name.
5154         * cp-support.c (cp_func_name): Update header comment, update
5155         return type.
5156         * cp-support.h (cp_func_name): Update return type in declaration.
5157         * valops.c (find_overload_match): Move temp_func local to top
5158         level of function and change its type.  Use temp_func to hold and
5159         delete temporary string obtained from cp_func_name.
5160
5161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5162
5163         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5164         gdb::char_vector, remove cleanup, and update uses of `msg`.
5165
5166 2019-01-03  Jim Wilson  <jimw@sifive.com>
5167
5168         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5169
5170 2019-01-02  Tom Tromey  <tom@tromey.com>
5171
5172         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5173         (tdesc_parse_xml): Remove cleanups.
5174         * target-descriptions.h (make_cleanup_free_target_description):
5175         Don't declare.
5176         (target_desc_deleter): New struct.
5177         (target_desc_up): New typedef.
5178         * target-descriptions.c (target_desc_deleter::operator()): Rename
5179         from free_target_description.
5180         (make_cleanup_free_target_description): Remove.
5181
5182 2019-01-02  Tom Tromey  <tom@tromey.com>
5183
5184         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5185         constructor, destructor.
5186         (linespec_parser): Remove typedef.
5187         (~linespec_parser): Rename from linespec_parser_delete.
5188         (linespec_lex_to_end, linespec_complete_label)
5189         (linespec_complete): Update.
5190         (decode_line_full): Remove cleanups.
5191         (decode_line_1): Update.
5192
5193 2019-01-02  Tom Tromey  <tom@tromey.com>
5194
5195         * python/python-internal.h (inferior_to_inferior_object): Change
5196         return type.
5197         * python/py-exitedevent.c (create_exited_event_object): Update.
5198         * python/py-inferior.c (inferior_to_inferior_object): Return
5199         gdbpy_ref.
5200         (python_new_inferior, python_inferior_deleted)
5201         (thread_to_thread_object, delete_thread_object)
5202         (build_inferior_list, gdbpy_selected_inferior): Update.
5203         * python/py-infthread.c (create_thread_object): Update.  Also fail
5204         if inferior_to_inferior_object fails.
5205
5206 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5207
5208         * inferior.h (class inferior) <displaced_step_state>: New field.
5209         * infrun.h (struct displaced_step_state): Move here from
5210         infrun.c.  Initialize fields, add constructor.
5211         <inf>: Remove field.
5212         <reset>: New method.
5213         * infrun.c (struct displaced_step_inferior_state): Move to
5214         infrun.h.
5215         (displaced_step_inferior_states): Remove.
5216         (get_displaced_stepping_state): Adust.
5217         (displaced_step_in_progress_any_inferior): Adjust.
5218         (displaced_step_in_progress_thread): Adjust.
5219         (displaced_step_in_progress): Adjust.
5220         (add_displaced_stepping_state): Remove.
5221         (get_displaced_step_closure_by_addr): Adjust.
5222         (remove_displaced_stepping_state): Remove.
5223         (infrun_inferior_exit): Call displaced_step_state.reset.
5224         (use_displaced_stepping): Don't check for NULL.
5225         (displaced_step_prepare_throw): Call
5226         get_displaced_stepping_state.
5227         (displaced_step_fixup): Don't check for NULL.
5228         (prepare_for_detach): Don't check for NULL.
5229
5230 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5231
5232         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5233          in case of call that did not complete.
5234
5235 2019-01-02  Andrey Utkin  <autkin@undo.io>
5236
5237         * symfile.c (find_separate_debug_file): Fix search of debug files for
5238         remote debuggee.
5239
5240 2019-01-02  Tom Tromey  <tom@tromey.com>
5241
5242         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5243         indentation.
5244         * python/py-frame.c (frapy_older): Remove cast.
5245         (frapy_newer): Likewise.
5246         * python/py-breakpoint.c (local_setattro): Remove cast.
5247         * python/py-arch.c (archpy_name): Remove local variable.
5248         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5249
5250 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5251
5252         * unittests/basic_string_view/element_access/char/empty.cc:
5253         Fix year range in copyright header.
5254
5255 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5256
5257         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5258         Delete.
5259         <operator==>: Update with for removed field.
5260         <hash>: Likewise.
5261         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5262         <isa_features>: ...this.
5263         <abi_features>: New field.
5264         (riscv_isa_flen): Update comment.
5265         (riscv_abi_xlen): New declaration.
5266         (riscv_abi_flen): New declaration.
5267         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5268         isa_features.
5269         (riscv_abi_xlen): New function.
5270         (riscv_isa_flen): Update to get answer from isa_features.
5271         (riscv_abi_flen): New function.
5272         (riscv_has_fp_abi): Update to get answer from abi_features.
5273         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5274         xlen and flen.
5275         (riscv_call_info) <xlen, flen>: Update comment.
5276         (riscv_call_arg_struct): Remove invalid assertions
5277         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5278         is removed.
5279         (riscv_gdbarch_init): Gather isa features and abi features
5280         separately, ensure both match on the gdbarch when reusing an old
5281         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5282         a target with 64-bit float hardware.
5283
5284 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5285
5286         * source.c (search_command_helper): Stop reverse search
5287         when line 1 has been searched.
5288
5289 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5290
5291         * record-full.c (record_full_base_target::close): Rewrite
5292         record_full_core_buf_list free logic.
5293
5294 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5295
5296         * break-catch-syscall.c (print_one_catch_syscall): xfree
5297         the last text.
5298
5299 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5300
5301         * top.c (print_gdb_version): Update Copyright year in version
5302         message.
5303
5304 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5305
5306         Update copyright year range in all GDB files.
5307
5308 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5309
5310         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5311
5312 For older changes see ChangeLog-2018.
5313 \f
5314 Local Variables:
5315 mode: change-log
5316 left-margin: 8
5317 fill-column: 74
5318 version-control: never
5319 coding: utf-8
5320 End:
5321