gdb/ChangeLog

   1 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * regformats/aarch64.dat: Remove.
   4         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
   5         * regformats/i386/amd64-avx-linux.dat: Remove.
   6         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
   7         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
   8         * regformats/i386/amd64-linux.dat: Remove.
   9         * regformats/i386/amd64-mpx-linux.dat: Remove.
  10         * regformats/i386/amd64.dat: Remove.
  11         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
  12         * regformats/i386/i386-avx-linux.dat: Remove.
  13         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
  14         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
  15         * regformats/i386/i386-linux.dat: Remove.
  16         * regformats/i386/i386-mmx-linux.dat: Remove.
  17         * regformats/i386/i386-mpx-linux.dat: Remove.
  18         * regformats/i386/i386.dat: Remove.
  19         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
  20         * regformats/i386/x32-avx-linux.dat: Remove.
  21         * regformats/i386/x32-linux.dat: Remove.
  22
  23 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  24
  25         * aarch64-tdep.c: Remove xml self tests.
  26         * amd64-linux-tdep.c: Likewise.
  27         * amd64-tdep.c: Likewise.
  28         * i386-linux-tdep.c: Likewise.
  29         * i386-tdep.c: Likewise.
  30
  31 2019-07-03  Pedro Alves  <palves@redhat.com>
  32
  33         PR cli/24732
  34         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
  35         (pipe_cmd_option_defs): New.
  36         (make_pipe_cmd_options_def_group): New.
  37         (pipe_command): Use gdb::option::process_options.
  38         (pipe_command_completer): New function.
  39         (_initialize_cli_cmds): Install completer for "pipe" command.
  40
  41 2019-07-03  Pedro Alves  <palves@redhat.com>
  42
  43         * cli/cli-option.c (union option_value) <string>: New field.
  44         (struct option_def_and_value): Add ctor, move ctor, dtor and
  45         use DISABLE_COPY_AND_ASSIGN.
  46         (option_def_and_value::clear_value): New.
  47         (parse_option, save_option_value_in_ctx, get_val_type_str)
  48         (add_setshow_cmds_for_options): Handle var_string.
  49         * cli-option.h (union option_def::var_address) <string>: New
  50         field.
  51         (struct string_option_def): New.
  52         * maint-test-options.c (struct test_options_opts): Add default
  53         ctor and use DISABLE_COPY_AND_ASSIGN.
  54         <string_opt>: New field.
  55         (test_options_opts::~test_options_opts): New.
  56         (test_options_opts::dump): Also dump "-string".
  57         (test_options_option_defs): Install "string.
  58
  59 2019-07-03  Pedro Alves  <palves@redhat.com>
  60
  61         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
  62         option_value with a null enumeration.
  63         (complete_options): Save the option values in the context.
  64         (save_option_value_in_ctx): New, factored out from ...
  65         (process_options): ... here.
  66         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
  67         of the function.
  68         * maint-test-options.c (test_options_opts::dump): New, factored
  69         out from ...
  70         (maintenance_test_options_command_mode): ... here.
  71         (maintenance_test_options_command_completion_result): Delete.
  72         (maintenance_test_options_command_completion_text): Update
  73         comment.
  74         (maintenance_show_test_options_completion_result): Change
  75         prototype.  Just print
  76         maintenance_test_options_command_completion_text.
  77         (save_completion_result): New.
  78         (maintenance_test_options_completer_mode): Pass options context to
  79         complete_options, and then save a dump.
  80         (_initialize_maint_test_options): Use add_cmd to install "maint
  81         show test-options-completion-result".
  82
  83 2019-07-03  Pedro Alves  <palves@redhat.com>
  84
  85         * NEWS (New commands): Mention "with" and "maint with".
  86         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
  87         (with_command, with_command_completer): New.
  88         (pipe_command): Adjust to new repeat_previous
  89         interface.
  90         (_initialize_cli_cmds): Install the "with" command and its "w"
  91         alias.
  92         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
  93         declarations.
  94         * cli/cli-setshow.c (parse_cli_var_uinteger)
  95         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
  96         argument strings for all var_types.
  97         (get_setshow_command_value_string): New, factored out from ...
  98         (do_show_command): ... this.
  99         * cli/cli-setshow.h: Include <string>.
 100         (get_setshow_command_value_string): Declare.
 101         * command.h (repeat_previous): Now returns const char *.  Adjust
 102         comment.
 103         * maint.c: Include "cli/cli-cmds.h".
 104         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 105         (_initialize_maint_cmds): Register the "maintenance with" command.
 106         * top.c (repeat_previous): Move bits from pipe_command here:
 107         Return the saved command line, if any; error out if there's no
 108         command to relaunch.
 109
 110 2019-07-03  Pedro Alves  <palves@redhat.com>
 111
 112         * NEWS (New commands): Mention "maint set/show test-settings"
 113         instead of "maint test-settings".
 114         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 115         (maintenance_test_settings_set_list): Rename to ...
 116         (maintenance_set_test_settings_list): ... this.
 117         (maintenance_test_settings_show_list): Rename to  ...
 118         (maintenance_show_test_settings_list): ... this.
 119         (maintenance_test_settings_cmd): Delete.
 120         (maintenance_test_settings_set_cmd): ...
 121         (maintenance_set_test_settings_cmd): ... this.
 122         (maintenance_test_settings_show_cmd): ...
 123         (maintenance_show_test_settings_cmd): ... this.
 124         (maintenance_test_settings_show_value_cmd):
 125         (maintenance_show_test_settings_value_cmd): ... this.
 126         (_initialize_maint_test_settings): No longer install the "maint
 127         test-settings" prefix command.  Rename "maint test-settings set"
 128         to "maint set test-settings", and "maint test-settings show" to
 129         "maint show test-settings".  Adjust all subcommands.
 130
 131 2019-07-03  Pedro Alves  <palves@redhat.com>
 132
 133         * maint-test-settings.c: Fix file's intro comment.  Replace all
 134         references to "test-options" with references to "test-settings",
 135         in comments.
 136
 137 2019-07-03  Pedro Alves  <palves@redhat.com>
 138
 139         * maint-test-settings.c (maintenance_test_settings_xxx)
 140         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 141         New.
 142         (maintenance_test_settings_enums): Use them.
 143         (maintenance_test_settings_enum): Default to
 144         maintenance_test_settings_xxx.
 145         (_initialize_maint_test_settings): Initialize
 146         MAINTENANCE_TEST_SETTINGS_FILENAME.
 147
 148 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 149
 150         * breakpoint.h (remove_breakpoints_inf): Change return type to
 151         void, move function documentation here.
 152         * breakpoint.c (remove_breakpoints_inf): Change return type to
 153         void, move function documentation to header.
 154
 155 2019-07-02  Pedro Alves  <palves@redhat.com>
 156
 157         * NEWS (Completion improvements): Mention "info threads".
 158         * thread.c (struct info_threads_opts, info_threads_option_defs)
 159         (make_info_threads_options_def_group): New.
 160         (info_threads_command): Use gdb::option::process_options.
 161         (info_threads_command_completer): New.
 162         (_initialize_thread): Use gdb::option::build_help to build the
 163         help text for "info threads".
 164
 165 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 166
 167         * defs.h (generic_load): Move from here...
 168         * symfile.h (generic_load): ... to here.  Rename name parameter
 169         to args.
 170         * symfile.c (generic_load): Add comment.
 171
 172 2019-07-01  Tom Tromey  <tromey@adacore.com>
 173
 174         * dwarf2read.c
 175         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 176         declaration of without_params.  Fix formatting.
 177
 178 2019-07-01  Tom Tromey  <tromey@adacore.com>
 179
 180         * ada-exp.y (find_primitive_type): Update.
 181         * ada-lang.h (ada_lookup_symbol): Update.
 182         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 183         parameter.
 184         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 185
 186 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 187
 188         PR breakpoints/24541
 189         * gdbarch.c: Regenerate.
 190         * gdbarch.h: Regenerate.
 191         * gdbarch.sh: Add 'stap_adjust_register'.
 192         * i386-tdep.c: Include '<unordered_set>'.
 193         (i386_stap_adjust_register): New function.
 194         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 195         * stap-probe.c (stap_parse_register_operand): Call
 196         'gdbarch_stap_adjust_register'.
 197
 198 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 199
 200         PR python/24742
 201         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 202         * python/python.c (do_start_initialization): Use 'xmalloc'
 203         instead of 'PyMem_Malloc'.
 204
 205 2019-06-28  Tom Tromey  <tromey@adacore.com>
 206
 207         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 208         for Ada.
 209
 210 2019-06-27  Tom Tromey  <tromey@adacore.com>
 211
 212         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 213         objfile_key.
 214         (arm_find_mapping_symbol, arm_record_special_symbol)
 215         (_initialize_arm_tdep): Update.
 216         (arm_objfile_data_free): Remove.
 217
 218 2019-06-27  Tom Tromey  <tromey@adacore.com>
 219
 220         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 221         to cp_print_static_field.
 222
 223 2019-06-26  Tom Tromey  <tromey@adacore.com>
 224
 225         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 226         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 227         declare.
 228
 229 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 230
 231         * features/aarch64-core.c (create_feature_aarch64_core):
 232         Regenerate.
 233         * features/aarch64-core.xml: Add cpsr flags.
 234
 235 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 236
 237         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 238         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 239
 240 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 241
 242         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 243         field.
 244         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 245         use.
 246         (arm_record_special_symbol): Don't insert new symbol in sorted
 247         position, push it at the end.
 248
 249 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 250
 251         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 252         (arm_mapping_symbol_s): Remove.
 253         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 254         (arm_mapping_symbol_vec): New typedef.
 255         (struct arm_per_objfile): Add constructor.
 256         <section_maps>: Change type to
 257         std::unique_ptr<arm_mapping_symbol_vec[]>.
 258         (arm_compare_mapping_symbols): Remove.
 259         (arm_find_mapping_symbol): Adjust to section_maps type change.
 260         (arm_objfile_data_free): Call delete on arm_per_objfile.
 261         (arm_record_special_symbol): Adjust to section_maps type change.
 262         Allocate arm_per_objfile with new.
 263
 264 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 265
 266         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 267         with the command prefix.
 268
 269 2019-06-25  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 272         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 273
 274 2019-06-25  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 277         type.
 278         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 279         protected.
 280
 281 2019-06-25  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-winsource.c
 284         (tui_source_window_base::set_is_exec_point_at): Add check against
 285         LOA_ADDRESS.
 286
 287 2019-06-25  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-source.c (tui_set_source_content): Don't check before
 290         xfree.
 291         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-winsource.h (tui_update_source_window_as_is)
 296         (tui_alloc_source_buffer, tui_line_is_displayed)
 297         (tui_addr_is_displayed): Change type of win_info.
 298         * tui/tui-winsource.c (tui_update_source_window_as_is)
 299         (tui_clear_source_content, tui_show_source_line)
 300         (tui_show_source_content, tui_source_window_base::refill)
 301         (tui_source_window_base::set_is_exec_point_at)
 302         (tui_source_window_base::set_is_exec_point_at)
 303         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 304         (tui_alloc_source_buffer, tui_line_is_displayed)
 305         (tui_addr_is_displayed): Change type of win_info.  Update.
 306         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 307         (tui_source_window_base::do_make_visible_with_new_height):
 308         Update.
 309         * tui/tui-source.c (tui_set_source_content)
 310         (tui_set_source_content_nil)
 311         (tui_source_window::do_scroll_vertical): Update.
 312         * tui/tui-layout.c (show_layout): Update.
 313         * tui/tui-disasm.c (tui_set_disassem_content)
 314         (tui_disasm_window::do_scroll_vertical): Update.
 315         * tui/tui-data.h (tui_win_content): Remove.
 316         (struct tui_gen_win_info) <content, content_size>: Remove.
 317         (struct tui_source_element): Add initializers and destructor.
 318         (union tui_which_element, struct tui_win_element): Remove.
 319         (struct tui_source_window_base) <content>: New field.
 320         (struct tui_data_window): Remove destructor.
 321         (tui_alloc_content, tui_free_win_content)
 322         (tui_free_all_source_wins_content): Don't declare.
 323         * tui/tui-data.c (tui_initialize_static_data): Update.
 324         (init_content_element, tui_alloc_content): Remove.
 325         (~tui_gen_win_info): Update.
 326         (~tui_data_window, tui_free_all_source_wins_content)
 327         (tui_free_win_content, free_content, free_content_elements):
 328         Remove.
 329
 330 2019-06-25  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-winsource.h (tui_clear_source_content)
 333         (tui_erase_source_content, tui_show_source_content): Change type
 334         of win_info.
 335         * tui/tui-winsource.c (tui_clear_source_content)
 336         (tui_erase_source_content, tui_show_source_content): Change type
 337         of win_info.
 338         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 339         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 340         win_info.
 341         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 342         win_info.
 343         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 344
 345 2019-06-25  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.c (tui_clear_source_content)
 348         (tui_source_window_base::set_is_exec_point_at): Update.
 349         * tui/tui-source.c (tui_set_source_content_nil): Update.
 350         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 351         a bool.
 352         * tui/tui-data.c (init_content_element): Update.
 353
 354 2019-06-25  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 357         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 358         * tui/tui-layout.c (init_and_make_win): Update.
 359         * tui/tui.h (enum tui_win_type): Update.
 360         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 361         tui_win_is_auxillary.
 362         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 363         tui_win_is_auxillary.
 364
 365 2019-06-25  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 368         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 369         (tui_delete_data_content_windows, tui_display_all_data)
 370         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 371         Update.
 372         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 373         * tui/tui-regs.c (tui_last_regs_line_no)
 374         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 375         (tui_show_registers): Update.
 376         (tui_show_register_group): Return void.  Update.
 377         (tui_display_registers_from, tui_display_reg_element_at_line)
 378         (tui_display_registers_from_line, tui_check_register_values):
 379         Update.
 380         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 381         member.
 382         (struct tui_data_window) <regs_content>: Now a std::vector.
 383         <regs_content_count>: Remove.
 384         (tui_add_content_elements, tui_free_data_content): Don't declare.
 385         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 386         (init_content_element): Remove DATA_WIN case.  Add assert.
 387         (tui_add_content_elements): Remove.
 388         (tui_data_window): Update.
 389         (tui_free_data_content): Remove.
 390         (free_content_elements): Remove DATA_WIN case.
 391
 392 2019-06-25  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-data.c (tui_data_item_window): Update.
 395         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 396         * tui/tui-windata.c (tui_display_all_data)
 397         (tui_display_data_from_line): Update.
 398         (tui_check_data_values): Remove.
 399         * tui/tui-regs.c (tui_show_register_group)
 400         (tui_display_reg_element_at_line): Update.
 401         * tui/tui-hooks.c (tui_register_changed)
 402         (tui_refresh_frame_and_register_information): Call
 403         tui_check_register_values.
 404         * tui/tui-data.h (struct tui_data_window) <data_content,
 405         data_content_count, data_type>: Remove.
 406         (enum tui_data_type): Remove.
 407
 408         * tui/tui-data.c (tui_data_window::clear_detail)
 409         (~tui_data_window): Update.
 410
 411 2019-06-25  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 414         declare.
 415         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 416         Rename from tui_first_data_item_displayed.  Update.
 417         (tui_data_window::refresh_all)
 418         (tui_data_window::do_scroll_vertical): Update.
 419         * tui/tui-data.h (struct tui_data_window)
 420         <first_data_item_displayed>: Declare new method.
 421
 422 2019-06-25  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 425         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 426         contents...
 427         (tui_initialize_static_data): ...here.
 428
 429 2019-06-25  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 432         (tui_display_registers_from, tui_check_register_values): Update.
 433         (tui_display_register): Remove win_info parameter; update.
 434         (tui_get_register): Change type of parameters.
 435         * tui/tui-data.h (struct tui_data_element): Remove.
 436         (union tui_which_element) <data>: Remove.
 437         <data_window>: Change type.
 438         (struct tui_data_item_window): New.
 439         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 440         case.  Add assert.
 441         (~tui_data_item_window): New destructor.
 442         (free_content_elements): Remove DATA_ITEM_WIN case.
 443
 444 2019-06-25  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 447         Remove.
 448
 449 2019-06-25  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-data.h (struct tui_command_element): Remove.
 452         (union tui_which_element) <command>: Remove.
 453         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 454         assert.
 455         (free_content_elements): Remove CMD_WIN case.
 456
 457 2019-06-25  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-layout.c (tui_set_layout): Update.
 460         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 461         * tui/tui-data.c (layout_def): Update.
 462
 463 2019-06-25  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 467         (tui_source_window_base::set_new_height): Update.
 468         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 469         Update.
 470         (tui_set_locator_fullname, tui_set_locator_info)
 471         (tui_show_frame_info): Update.
 472         * tui/tui-source.c (tui_set_source_content)
 473         (tui_source_is_displayed): Update.
 474         * tui/tui-layout.c (show_source_disasm_command, show_data)
 475         (show_source_or_disasm_and_command): Update.
 476         * tui/tui-disasm.c (tui_set_disassem_content)
 477         (tui_get_begin_asm_address): Update.
 478         * tui/tui-data.h (struct tui_locator_element): Remove.
 479         (union tui_which_element) <locator>: Remove.
 480         (struct tui_locator_window): New.
 481         (tui_locator_win_info_ptr): Change return type.
 482         * tui/tui-data.c (_locator): Change type.
 483         (tui_locator_win_info_ptr): Change return type.
 484         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 485         (tui_alloc_content): Add assert.
 486
 487 2019-06-25  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.c
 490         (tui_exec_info_window::maybe_allocate_content): New method.
 491         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 492         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 493         (make_source_or_disasm_window): Add cast.
 494         * tui/tui-data.h (union tui_which_element) <simple_string>:
 495         Remove.
 496         (struct tui_source_info): New.
 497         (struct tui_source_window_base) <execution_info>: Change type.
 498         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 499         case, and add assert.
 500         (tui_alloc_content): Add assert.
 501
 502 2019-06-25  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 505         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 506         * tui/tui-data.c (tui_alloc_win_info): Remove.
 507
 508 2019-06-25  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 511         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 512         can_highlight.
 513
 514 2019-06-25  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 517         make_visible_with_new_height method.
 518         (tui_win_info::make_visible_with_new_height): New method.
 519         (tui_source_window_base::do_make_visible_with_new_height)
 520         (tui_data_window::do_make_visible_with_new_height)
 521         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 522         (make_visible_with_new_height): Remove.
 523         (tui_resize_all, tui_adjust_win_heights): Use
 524         make_visible_with_new_height method.
 525         * tui/tui-data.h (struct tui_win_info)
 526         <do_make_visible_with_new_height, make_visible_with_new_height>:
 527         New methods.
 528         (struct tui_source_window_base, struct tui_data_window)
 529         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 530         methods.
 531
 532 2019-06-25  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 535         method.
 536         (update_tab_width): Call update_tab_width method.
 537         * tui/tui-data.h (struct tui_win_info)
 538         (struct tui_source_window_base) <update_tab_width>: New methods.
 539
 540 2019-06-25  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 543         parameter.
 544         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 545         parameter.
 546         (tui_gen_win_info::make_visible): Update.
 547         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 548         parameter.
 549         * tui/tui-data.h (enum tui_box): New enum.
 550         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 551
 552 2019-06-25  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 555         init_and_make_win for EXEC_INFO_WIN.
 556         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 557         longer inline.
 558         (struct tui_win_info) <~tui_win_info>: Inline.
 559         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 560         Don't declare.
 561         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 562         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 563         Remove.
 564         (tui_initialize_static_data): Update.
 565         (~tui_gen_win_info): Handle more cleanup here.
 566         (~tui_source_window_base): Delete "execution_info".
 567         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 568
 569 2019-06-25  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-layout.c (make_command_window): Don't set
 572         can_highlight.
 573         (show_source_disasm_command): Call the reset method.
 574         (show_data): Don't set can_highlight.  Call the reset method.
 575         (tui_gen_win_info::reset): Rename from init_gen_win_info
 576         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 577         (show_source_or_disasm_and_command): Call the reset method.
 578         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 579         (struct tui_cmd_window): Set can_highlight.
 580
 581 2019-06-25  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 584         from make_visible.
 585         (tui_make_visible, tui_make_invisible): Rewrite.
 586         (tui_win_info::make_visible): Remove.
 587         (tui_source_window_base::make_visible): Update.
 588         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 589         method.  Moved from...
 590         (struct tui_win_info) <make_visible>: ...here.
 591
 592 2019-06-25  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.c
 595         (tui_source_window_base::do_scroll_horizontal): Remove direction
 596         parameter.
 597         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 598         direction parameter.
 599         * tui/tui-win.c (tui_win_info::forward_scroll)
 600         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 601         (tui_win_info::right_scroll): Update.
 602         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 603         direction parameter.
 604         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 605         direction parameter.
 606         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 607         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 608         Remove direction parameter.
 609         (struct tui_source_window_base, struct tui_source_window)
 610         (struct tui_disasm_window, struct tui_data_window)
 611         (struct tui_cmd_window): Update.
 612
 613 2019-06-25  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-winsource.h (tui_set_exec_info_content)
 616         (tui_show_exec_info_content, tui_erase_exec_info_content)
 617         (tui_clear_exec_info_content, tui_update_exec_info): Change
 618         argument to tui_source_window_base.
 619         * tui/tui-winsource.c (tui_set_exec_info_content)
 620         (tui_show_exec_info_content, tui_erase_exec_info_content)
 621         (tui_clear_exec_info_content, tui_update_exec_info): Change
 622         argument to tui_source_window_base.
 623
 624 2019-06-25  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 627         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 628
 629 2019-06-25  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 632         check.
 633
 634 2019-06-25  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 637         type to void.
 638         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 639         type to void.
 640         * tui/tui-source.c (tui_set_source_content): Update.
 641         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 642
 643 2019-06-25  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-win.c (window_name_completer, tui_set_focus)
 646         (tui_all_windows_info): Use name method.
 647         * tui/tui-data.h (struct tui_gen_win_info)
 648         (struct tui_source_window, struct tui_disasm_window)
 649         (struct tui_data_window, struct tui_cmd_window) <name>: New
 650         method.
 651         (tui_win_name): Don't declare.
 652         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 653         (tui_win_name): Remove.
 654
 655 2019-06-25  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-winsource.h (tui_update_source_window)
 658         (tui_update_source_window_as_is): Change parameter type.
 659         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 660         to be a tui_source_window_base.
 661         (tui_update_source_window_as_is): Likewise.
 662         * tui/tui-win.c (make_visible_with_new_height): Update.
 663
 664 2019-06-25  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.c (tui_erase_source_content)
 667         (tui_show_source_content, tui_show_exec_info_content)
 668         (tui_erase_exec_info_content): Use refresh_window method.
 669         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 670         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 671         from tui_refresh_win.
 672         (tui_data_window::refresh_window): New method.
 673         (tui_win_info::refresh, tui_source_window_base::refresh)
 674         (tui_refresh_all): Use refresh_window method.
 675         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 676         method.
 677         * tui/tui-regs.c (tui_display_register): Call refresh_window
 678         method.
 679         * tui/tui-layout.c (show_source_disasm_command)
 680         (show_source_or_disasm_and_command): Call refresh_window method.
 681         * tui/tui-data.h (struct tui_gen_win_info)
 682         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 683         New method.
 684
 685 2019-06-25  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui.c (tui_rl_other_window, tui_enable)
 688         (tui_is_window_visible, tui_get_command_dimension): Update.
 689         * tui/tui-winsource.c (tui_update_source_window_as_is)
 690         (tui_clear_source_content, tui_erase_source_content)
 691         (tui_show_source_line, tui_source_window_base::refill)
 692         (tui_source_window_base::do_scroll_horizontal)
 693         (tui_source_window_base::set_is_exec_point_at)
 694         (tui_update_breakpoint_info, tui_set_exec_info_content)
 695         (tui_alloc_source_buffer, tui_line_is_displayed)
 696         (tui_addr_is_displayed): Update.
 697         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 698         (tui_check_and_display_highlight_if_needed)
 699         (tui_win_info::make_visible, tui_win_info::refresh)
 700         (tui_refresh_all): Update.
 701         * tui/tui-windata.c (tui_first_data_item_displayed)
 702         (tui_delete_data_content_windows, tui_erase_data_content)
 703         (tui_display_all_data, tui_data_window::refresh_all)
 704         (tui_check_data_values): Update.
 705         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 706         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 707         (tui_win_info::backward_scroll, tui_refresh_all_win)
 708         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 709         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 710         (tui_source_window_base::set_new_height)
 711         (tui_data_window::set_new_height)
 712         (make_invisible_and_set_new_height)
 713         (make_visible_with_new_height, new_height_ok)
 714         (parse_scrolling_args): Update.
 715         * tui/tui-stack.c (tui_show_frame_info): Update.
 716         * tui/tui-source.c (tui_set_source_content)
 717         (tui_set_source_content_nil, tui_source_is_displayed)
 718         (tui_source_window::do_scroll_vertical): Update.
 719         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 720         (tui_display_registers_from, tui_display_reg_element_at_line)
 721         (tui_check_register_values, tui_reg_command): Update.
 722         * tui/tui-layout.c (tui_default_win_height)
 723         (show_source_disasm_command, show_data, init_and_make_win)
 724         (show_source_or_disasm_and_command): Update.
 725         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 726         (tui_redisplay_readline, tui_mld_flush)
 727         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 728         (tui_getc): Update.
 729         * tui/tui-disasm.c (tui_set_disassem_content)
 730         (tui_disasm_window::do_scroll_vertical): Update.
 731         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 732         Now virtual.
 733         (struct tui_win_info): Derive from tui_gen_win_info.
 734         <~tui_win_info>: Mark as override.
 735         <generic>: Remove member.
 736         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 737         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 738         (~tui_data_window, ~tui_win_info)
 739         (tui_free_all_source_wins_content): Update.
 740         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 741
 742 2019-06-25  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-layout.c (init_and_make_win): Use new.
 745         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 746         destructor, initializers.
 747         (tui_alloc_generic_win_info): Don't declare.
 748         * tui/tui-data.c (_locator): Add argument to constructor.
 749         (source_win, disasm_win): New globals.
 750         (exec_info): Remove.
 751         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 752         Update.
 753         (tui_alloc_generic_win_info): Remove.
 754         (init_content_element): Use new.
 755         (tui_win_info::tui_win_info): Update.
 756         (free_content_elements) <case DATA_WIN>: Use delete.
 757
 758 2019-06-25  Tom Tromey  <tom@tromey.com>
 759
 760         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 761         * tui/tui-windata.c (tui_first_data_item_displayed)
 762         (tui_delete_data_content_windows): Update.
 763         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 764         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 765         (tui_display_registers_from, tui_check_register_values): Update.
 766         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 767         pointer.
 768         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 769         window.
 770         (tui_free_data_content): Update.
 771         (free_content_elements) <case DATA_WIN>: Free the window.
 772
 773 2019-06-25  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 776         Update.
 777         * tui/tui-layout.c (make_command_window)
 778         (show_source_disasm_command, show_data, init_and_make_win)
 779         (show_source_or_disasm_and_command): Update.
 780         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 781         method.
 782         <can_highight, is_highlighted>: Now bool.
 783         (tui_set_win_highlight): Don't declare.
 784         * tui/tui-data.c (tui_set_win_highlight): Remove.
 785
 786 2019-06-25  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-wingeneral.c (make_visible): Remove check of window
 789         type.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-win.c (tui_win_info::max_height)
 794         (tui_cmd_window::max_height): New methods.
 795         (new_height_ok): Call max_height.
 796         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 797         <max_height>: New method.
 798
 799 2019-06-25  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-win.c (tui_source_window_base::set_new_height)
 802         (tui_data_window::set_new_height): New methods.
 803         (make_invisible_and_set_new_height): Call set_new_height method.
 804         * tui/tui-data.h (struct tui_win_info)
 805         (struct tui_source_window_base, struct tui_data_window)
 806         <set_new_height>: New method.
 807
 808 2019-06-25  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 811         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 812         tui_refresh_data_win.
 813         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 814         method.
 815         (tui_refresh_all_win): Call the refresh_all method.
 816         (tui_set_focus): Likewise.
 817         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 818         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 819         Likewise.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-winsource.h (tui_refill_source_window)
 824         (tui_set_is_exec_point_at): Don't declare.
 825         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 826         (tui_source_window_base::refill): Rename from
 827         tui_refill_source_window.
 828         (tui_source_window_base::do_scroll_horizontal): Update.
 829         (tui_source_window_base::set_is_exec_point_at): Rename from
 830         tui_set_is_exec_point_at.
 831         (tui_update_all_breakpoint_info): Update.
 832         * tui/tui-stack.c (tui_show_frame_info): Update.
 833         * tui/tui-layout.c (show_data): Add cast.
 834         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 835         * tui/tui-data.h (struct tui_source_window_base) <refill,
 836         set_is_exec_point_at>: New methods.
 837         (tui_source_windows, tui_add_to_source_windows): Update types.
 838         (tui_add_to_source_windows): Remove redundant declaration.
 839         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 840         (tui_source_windows): Change return type.
 841         (tui_clear_source_windows_detail): Update.
 842         (tui_add_to_source_windows): Change type of parameter.
 843         (tui_free_all_source_wins_content): Update.
 844
 845 2019-06-25  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-wingeneral.c (tui_win_info::refresh)
 848         (tui_source_window_base::refresh): New methods.
 849         (tui_refresh_all): Call the refresh method.
 850         * tui/tui-data.h (struct tui_win_info)
 851         (struct tui_source_window_base) <refresh>: New method.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui.h (tui_is_window_visible): Return bool.
 856         * tui/tui.c (tui_is_window_visible): Return bool.
 857         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 858         (tui_make_visible, tui_make_invisible)
 859         (tui_win_info::make_visible)
 860         (tui_source_window_base::make_visible, make_all_visible)
 861         (tui_make_all_visible, tui_make_all_invisible): Update.
 862         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 863         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 864         bool.
 865         (struct tui_win_info, struct tui_source_window_base)
 866         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 867         * tui/tui-data.c (tui_init_generic_part): Update.
 868
 869 2019-06-25  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 872         (tui_source_window_base::make_visible): New methods.
 873         (make_all_visible): Make method call.
 874         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 875         (struct tui_source_window_base, struct tui_cmd_window): Override
 876         make_visible.
 877         (tui_win_is_source_type): Don't declare.
 878         * tui/tui-data.c (tui_win_is_source_type): Remove.
 879
 880 2019-06-25  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 883         NULL check.
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 888         Inline constructor.  Add initializers for members.
 889         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 890         constructors; now inline in class.
 891
 892 2019-06-25  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-regs.c (tui_show_registers): Update.
 895         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 896         bool.
 897         * tui/tui-data.c (tui_data_window::clear_detail)
 898         (tui_data_window): Update.
 899
 900 2019-06-25  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-windata.c (tui_display_all_data)
 903         (tui_display_data_from_line, tui_display_data_from)
 904         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 905         Update.
 906         * tui/tui-regs.c (tui_last_regs_line_no)
 907         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 908         (tui_show_registers, tui_show_register_group)
 909         (tui_display_registers_from, tui_display_reg_element_at_line)
 910         (tui_display_registers_from_line, tui_check_register_values)
 911         (tui_reg_next, tui_reg_prev): Update.
 912         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 913         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 914         tui_data_window.
 915         (struct tui_win_info) <detail>: Remove.  Add new fields from
 916         tui_data_info.
 917         (TUI_DATA_WIN): Add cast.
 918         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 919         (~tui_data_window): Simplify.
 920
 921 2019-06-25  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui-layout.c (show_source_disasm_command)
 924         (show_source_or_disasm_and_command): Update.
 925         * tui/tui-io.c (update_cmdwin_start_line)
 926         (tui_redisplay_readline): Update.
 927         * tui/tui-data.h (struct tui_command_info): Remove.
 928         (struct tui_win_info) <detail>: Remove command_info member.
 929         (struct tui_data_window) <start_line>: New member, from
 930         tui_command_info.
 931         (TUI_CMD_WIN): Add casts.
 932
 933 2019-06-25  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-winsource.c (tui_update_source_window)
 936         (tui_refill_source_window)
 937         (tui_source_window_base::do_scroll_horizontal)
 938         (tui_update_breakpoint_info, tui_set_exec_info_content)
 939         (tui_show_exec_info_content, tui_erase_exec_info_content)
 940         (tui_clear_exec_info_content): Update.
 941         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 942         Update.
 943         * tui/tui-win.c (make_invisible_and_set_new_height)
 944         (make_visible_with_new_height): Update.
 945         * tui/tui-source.c (tui_set_source_content)
 946         (tui_show_symtab_source): Update.
 947         * tui/tui-layout.c (extract_display_start_addr)
 948         (show_source_disasm_command, show_data)
 949         (make_source_or_disasm_window)
 950         (show_source_or_disasm_and_command): Update.
 951         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 952         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 953         "gdbarch".
 954         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 955         to tui_source_window_base.
 956         (struct tui_win_info) <detail>: Remove source_info member.
 957         (struct tui_source_window_base) <has_locator>: Inline.
 958         Move contents from tui_source_info; rename has_locator member to
 959         m_has_locator.
 960         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 961         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 962         header file.
 963         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 964         Simplify.
 965         (tui_free_all_source_wins_content): Cast to
 966         tui_source_window_base.
 967
 968 2019-06-25  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-win.c (make_invisible_and_set_new_height)
 971         (make_visible_with_new_height): Call has_locator method.
 972         * tui/tui-layout.c (show_source_disasm_command, show_data)
 973         (show_source_or_disasm_and_command): Update for bool change.
 974         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 975         (tui_win_info) <has_locator>: New method.
 976         (struct tui_source_window_base) <has_locator>: New method.
 977         (tui_win_has_locator): Don't declare.
 978         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 979         from tui_win_has_locator.
 980         (tui_source_window_base): Use false, not FALSE.
 981
 982 2019-06-25  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 985         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 986         clear_detail method directly.
 987         (tui_clear_win_detail): Remove.
 988
 989 2019-06-25  Tom Tromey  <tom@tromey.com>
 990
 991         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 992         "this", not TUI_DISASM_WIN.
 993
 994 2019-06-25  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 997         declare.
 998         * tui/tui-winsource.c
 999         (tui_source_window_base::do_scroll_horizontal): Rename from
1000         tui_horizontal_source_scroll.
1001         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1002         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1003         from tui_vertical_data_scroll.
1004         * tui/tui-win.h (tui_scroll): Don't declare.
1005         * tui/tui-win.c (tui_win_info::forward_scroll)
1006         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1007         (tui_win_info::right_scroll): Rename and update.
1008         (tui_scroll_forward_command, tui_scroll_backward_command)
1009         (tui_scroll_left_command, tui_scroll_right_command): Update.
1010         (tui_scroll): Remove.
1011         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1012         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1013         from tui_vertical_source_scroll.
1014         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1015         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1016         from tui_vertical_disassem_scroll.
1017         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1018         do_scroll_horizontal>: New methods.
1019         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1020         Likewise.
1021         (struct tui_source_window_base): Add do_scroll_horizontal.
1022         (struct tui_source_window, struct tui_disasm_window): Add
1023         do_scroll_vertical.
1024         (struct tui_data_window, struct tui_cmd_window): Add
1025         do_scroll_horizontal and do_scroll_vertical.
1026         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-data.h (struct tui_source_window_base): New struct.
1031         (struct tui_source_window): Derive from tui_source_window_base.
1032         (struct tui_disasm_window): New struct.
1033         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1034         from tui_source_window::clear_detail.
1035         (tui_source_window_base): Rename from tui_source_window.
1036         (~tui_source_window_base): Rename from ~tui_source_window.
1037         (tui_alloc_win_info): Create a tui_disasm_window.
1038
1039 2019-06-25  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-data.h (struct tui_source_window)
1042         (struct tui_data_window): Declare destructors.
1043         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1044         destructors.
1045         (tui_win_info): Simplify.
1046
1047 2019-06-25  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-winsource.c (tui_display_main)
1050         (tui_update_source_windows_with_addr)
1051         (tui_update_all_breakpoint_info): Update.
1052         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1053         (new_height_ok, parse_scrolling_args): Update.
1054         * tui/tui-stack.c (tui_show_frame_info): Update.
1055         * tui/tui-data.h (struct tui_list): Remove.
1056         (tui_source_windows): Return a reference to a std::vector.
1057         * tui/tui-data.c (source_windows): Now a std::vector.
1058         (tui_source_windows): Change return type.
1059         (tui_clear_source_windows): Rewrite.
1060         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1061         (tui_free_all_source_wins_content): Rewrite.
1062
1063 2019-06-25  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1066         (struct tui_data_window, struct tui_cmd_window): Declare
1067         clear_detail method.
1068         * tui/tui-data.c (tui_source_window::clear_detail)
1069         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1070         methods.
1071         (tui_clear_win_detail): Simplify.
1072
1073 2019-06-25  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-layout.c (make_source_window, make_disasm_window)
1076         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1077         Return the new window.
1078         (show_source_disasm_command, show_data)
1079         (show_source_or_disasm_and_command): Update.
1080
1081 2019-06-25  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1084         parameter.  Return the new window.
1085         (show_source_disasm_command): Update and remove NULL check.
1086         (show_source_or_disasm_and_command): Update.
1087
1088 2019-06-25  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1091
1092 2019-06-25  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-data.h (struct tui_win_info): Make constructor
1095         protected.  Make destructor virtual.  Add initializers.
1096         (tui_source_window, tui_data_window, tui_cmd_window): New
1097         classes.
1098         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1099         constructor.  Add "type" parameter.
1100         (tui_source_window, tui_data_window, tui_cmd_window): New
1101         constructors.
1102         (tui_alloc_win_info): Instantiate the appropriate subclass.
1103
1104 2019-06-25  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-win.c (tui_resize_all): Use delete.
1107         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1108         destructor.
1109         (tui_free_window): Don't declare.
1110         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1111         Update.
1112
1113 2019-06-25  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-data.h (struct tui_win_info): Add constructor.
1116         * tui/tui-data.c (tui_alloc_win_info): Use new.
1117         (tui_free_window): Use delete.
1118
1119 2019-06-22  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1122         declare.
1123         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1124
1125 2019-06-22  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1128         declare.
1129         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1130
1131 2019-06-22  Tom de Vries  <tdevries@suse.de>
1132
1133         * dwarf2read.c (create_addrmap_from_aranges)
1134         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1135         instead of '%zu'.
1136
1137 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1138
1139         * dwarf2read.h (dwarf2_section_info_def): Remove.
1140         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1141         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1142         std::vector<dwarf2_section_info>.
1143         (struct dwo_file) <~dwo_file>: Remove.
1144         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1145         types field.
1146         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1147         (dwarf2_read_debug_names): Likewise.
1148         (create_debug_types_hash_table): Change parameter type to
1149         array_view, adjust code accordingly.
1150         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1151         (partial_die_info::fixup): Likewise.
1152         (determine_prefix): Likewise.
1153         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1154
1155 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1156
1157         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1158         gdb_bfd_ref_ptr.
1159         <~dwo_file>: Remove call to gdb_bfd_unref.
1160         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1161         gdb_bfd_ref_ptr::get.
1162
1163 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1164
1165         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1166         type to htab_up.
1167         * dwarf2read.c (struct dwo_file): Initialize fields.
1168         <~dwo_file>: New.
1169         (free_dwo_file): Remove, move content to ~dwo_file.
1170         (struct dwo_file_deleter): Remove.
1171         (dwo_file_up>: Remove custom deleter.
1172         (free_dwo_files): Remove.
1173         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1174         dwo_files.
1175         (process_skeletonless_type_units): Call unique_ptr::get.
1176         (allocate_dwo_file_hash_table): Add deleter to created hash
1177         table.  Change return type to htab_up.
1178         (lookup_dwo_file_slot): Don't memset dwo_file, call
1179         unique_ptr::get.
1180         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1181         (create_dwo_unit_in_dwp_v2): Likewise.
1182         (open_and_init_dwo_file): Likewise.
1183         (free_dwo_file_from_slot): Remove.
1184
1185 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1186
1187         * dwarf2read.h (struct dwarf2_section_info) <readin,
1188         is_virtual>: Change type to bool.
1189         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1190         true instead of 1.
1191
1192 2019-06-19  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-data.h (tui_init_content_element): Don't declare.
1195
1196 2019-06-19  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-data.h (tui_init_win_info): Don't declare.
1199
1200 2019-06-19  Tom de Vries  <tdevries@suse.de>
1201
1202         * dwarf2read.h (abstract_to_concrete): Change type to
1203         std::unordered_map<sect_offset, std::vector<sect_offset>,
1204         gdb::hash_enum<sect_offset>>.
1205
1206 2019-06-19  Tom Tromey  <tromey@adacore.com>
1207
1208         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1209         EVAL_AVOID_SIDE_EFFECTS specially.
1210
1211 2019-06-19  Tom Tromey  <tromey@adacore.com>
1212
1213         * source-cache.c (highlighter): New global.
1214         (source_cache::get_source_lines): Create a highlighter on demand.
1215
1216 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1217
1218         * defs.h (deprecated_interactive_hook): Delete declaration.
1219         * interps.c (clear_interpreter_hooks): Remove use of
1220         deprecated_interactive_hook.
1221         * top.c (deprecated_interactive_hook): Delete definition.
1222         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1223
1224 2019-06-18  Tom de Vries  <tdevries@suse.de>
1225
1226         PR gdb/24515
1227         * dwarf2read.h (abstract_to_concrete): Change type from
1228         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1229         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1230         * dwarf2read.c (read_variable): Update.
1231         (dwarf2_fetch_die_loc_sect_off): Update.
1232
1233 2019-06-17  Tom de Vries  <tdevries@suse.de>
1234
1235         PR gdb/24617
1236         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1237         accessing parent[parent_len - 1].
1238
1239 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1240
1241         PR gdb/24364
1242         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1243         call dtrace_process_dof with NULL dof.
1244
1245 2019-06-16  Tom de Vries  <tdevries@suse.de>
1246
1247         PR gdb/24445
1248         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1249
1250 2019-06-16  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1253         (make_all_visible): Use address of member.
1254
1255 2019-06-16  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1258         (tui_free_window, free_content, free_content_elements): Remove
1259         unnecessary cast.
1260         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1261         cast.
1262         * tui/tui-regs.c (tui_show_register_group)
1263         (tui_display_registers_from, tui_display_reg_element_at_line):
1264         Remove unnecessary cast.
1265
1266 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * linux-nat.c (normal_mask): Delete.
1269         (_initialize_linux_nat): Don't initialise normal_mask.
1270
1271 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1272
1273         PR gdb/24445
1274         * dwarf-index-write.h (write_psymtabs_to_index): Add
1275         dwz_basename parameter.
1276         * dwarf-index-write.c (write_gdbindex): Move file writing to
1277         write_gdbindex_1.  Change return type void.
1278         (assert_file_size): Move up, remove filename parameter.
1279         (write_gdbindex_1): New function.
1280         (write_debug_names): Change return type to void, call
1281         assert_file_size.
1282         (struct index_wip_file): New struct.
1283         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1284         file logic to index_wip_file.  Write index for dwz file if
1285         needed.
1286         (save_gdb_index_command): Pass basename of dwz file, if present.
1287         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1288         build-id of dwz file, if present.
1289         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1290         (dwarf2_get_dwz_file): Likewise.
1291         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1292         (dwarf2_get_dwz_file): Likewise.
1293
1294 2019-06-16  Tom Tromey  <tom@tromey.com>
1295
1296         * coffread.c (process_coff_symbol): Use xstrdup.
1297         * value.c (create_internalvar): Use xstrdup.
1298
1299 2019-06-16  Tom Tromey  <tom@tromey.com>
1300
1301         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1302         * breakpoint.c (stopin_command, stopat_command)
1303         (until_break_command, decode_location_default): Remove unnecessary
1304         cast.
1305         * utils.c (subset_compare): Remove unnecessary cast.
1306         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1307         cast.
1308         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1309         cast.
1310         * infcmd.c (path_command): Remove unnecessary cast.
1311         * coffread.c (decode_type): Remove unnecessary cast.
1312         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1313         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1314         * tui/tui-stack.c (tui_show_locator_content)
1315         (tui_show_frame_info): Remove unnecessary cast.
1316         * tui/tui-win.c (tui_scroll_forward_command)
1317         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1318         (parse_scrolling_args): Remove unnecessary cast.
1319         * tui/tui-data.c (init_win_info, tui_del_window)
1320         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1321         (free_content_elements): Remove unnecessary cast.
1322         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1323         unnecessary cast.
1324         * tui/tui-source.c (tui_set_source_content)
1325         (tui_vertical_source_scroll): Remove unnecessary cast.
1326         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1327         cast.
1328         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1329         * tui/tui-regs.c (tui_display_registers_from)
1330         (tui_display_register): Remove unnecessary cast.
1331         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1332         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1333         (make_visible): Remove unnecessary cast.
1334         * tui/tui-winsource.c (tui_erase_source_content)
1335         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1336         unnecessary cast.
1337         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1338         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1339         * stabsread.c (read_type, read_array_type, read_range_type):
1340         Remove unnecessary cast.
1341         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1342         (parse_symbol, parse_type, upgrade_type, parse_external)
1343         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1344         unnecessary cast.
1345         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1346
1347 2019-06-16  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-data.c (tui_alloc_generic_win_info)
1350         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1351         checks.
1352
1353 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1354             Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * f-typeprint.c (f_print_type): Don't return early for not
1357         associated or not allocated types.
1358         (f_type_print_varspec_suffix): Add print_rank parameter and print
1359         ranks of array types in case they dangling.
1360         (f_type_print_base): Add print_rank parameter.
1361
1362 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1363
1364         * NEWS: Mention new MI commands.
1365         * break-catch-throw.c (enum exception_event_kind): Move to
1366         breakpoint.h.
1367         (print_mention_exception_catchpoint): Output text as a single
1368         message.
1369         (catch_exception_command_1): Rename to...
1370         (catch_exception_event): ...this, make non-static, update header
1371         command, and change some parameter types.
1372         (catch_catch_command): Update for changes to
1373         catch_exception_command_1.
1374         (catch_throw_command): Likewise.
1375         (catch_rethrow_command): Likewise.
1376         * breakpoint.c (enum exception_event_kind): Delete.
1377         * breakpoint.h (enum exception_event_kind): Moved here from
1378         break-catch-throw.c.
1379         (catch_exception_event): Declare.
1380         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1381         (mi_cmd_catch_throw): New function.
1382         (mi_cmd_catch_rethrow): New function.
1383         (mi_cmd_catch_catch): New function.
1384         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1385         'catch-catch' entries.
1386         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1387         (mi_cmd_catch_rethrow): Declare.
1388         (mi_cmd_catch_catch): Declare.
1389
1390 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * annotate.c (annotate_source_line): Change return type to void,
1393         update implementation to match.
1394         * annotate.h (annotate_source_line): Change return type to void,
1395         update header comment.
1396         * stack.c (print_frame_info): Don't change what frame information
1397         is printed based on whether annotations are on or not.
1398
1399 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1402         (annotate_source): Make static.
1403         (annotate_source_line): Moved from source.c and renamed from
1404         identify_source_line.  Update the return type.
1405         * annotate.h (annotate_source): Delete declaration.
1406         (annotate_source_line): Declaration moved from source.h, and
1407         renamed from identify_source_line.  Return type updated.
1408         * source.c (identify_source_line): Moved to annotate.c and renamed
1409         to annotate_source_line.
1410         (info_line_command): Remove check of annotation_level.
1411         * source.h (identify_source_line): Move declaration to annotate.h
1412         and rename to annotate_source_line.
1413         * stack.c: Add 'annotate.h' include.
1414         (print_frame_info): Remove check of annotation_level before
1415         calling annotate_source_line.
1416
1417 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1418
1419         * source-cache.c (source_cache::get_plain_source_lines): Use
1420         open_source_file_with_line_charpos instead of just
1421         open_source_file, remove call to find_source_lines.
1422         (source_cache::get_source_lines): Likewise.
1423         * source.c (find_source_lines): Make static.
1424         (get_filename_and_charpos): Renamed into...
1425         (open_source_file_with_line_charpos): ..this along with changes to
1426         return a scoped_fd, and some other minor clean ups.
1427         (identify_source_line): Use open_source_file_with_line_charpos.
1428         (search_command_helper): Use open_source_file_with_line_charpos
1429         instead of just open_source_file, remove call to
1430         find_source_lines.
1431         * source.h (open_source_file_with_line_charpos): Declare new
1432         function.
1433         (find_source_lines): Delete declaration.
1434
1435 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1436
1437         * source.c (get_filename_and_charpos): Remove fullname
1438         parameter.
1439         (identify_source_line): Update call to get_filename_and_charpos.
1440
1441 2019-06-14  Tom Tromey  <tromey@adacore.com>
1442
1443         PR gdb/24502:
1444         * ui-style.h (skip_ansi_escape): Update comment.
1445         * ui-file.h (class no_terminal_escape_file): New class.
1446         * ui-file.c (no_terminal_escape_file::write)
1447         (no_terminal_escape_file::puts): New methods.
1448         * cli/cli-logging.c (handle_redirections): Use
1449         no_terminal_escape_file.
1450
1451 2019-06-14  Tom Tromey  <tromey@adacore.com>
1452
1453         * NEWS: Move convenience variable news above Python news.
1454
1455 2019-06-14  Tom Tromey  <tom@tromey.com>
1456
1457         * gnulib: Move directory to top-level.
1458         * configure.ac: Don't configure gnulib.
1459         * configure: Rebuild.
1460         * common/common-defs.h: Use new path to gnulib.
1461         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1462         (GNULIB_H): Remove.
1463         (INCGNU): Look in new gnulib location.
1464         (HFILES_NO_SRCDIR): Remove gnulib files.
1465         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1466         (generated_files): Remove GNULIB_H.
1467         ($(LIBGNU), all-lib): Remove targets.
1468         (distclean): Don't mention GNULIB_BUILDDIR.
1469         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1470
1471 2019-06-14  Tom Tromey  <tromey@adacore.com>
1472
1473         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1474         Warn if symbol file does not provide any symbols.
1475
1476 2019-06-14  Tom Tromey  <tromey@adacore.com>
1477
1478         * source.c (find_and_open_source): Respect basenames_may_differ.
1479
1480 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * annotate.c (annotate_breakpoints_invalid): Make use of
1483         scoped_restore_terminal_state.
1484         (annotate_frames_invalid): Likewise.
1485
1486 2019-06-14  Tom Tromey  <tromey@adacore.com>
1487
1488         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1489         allow assignment to an internalvar.
1490
1491 2019-06-14  Tom Tromey  <tromey@adacore.com>
1492
1493         * ada-lex.l: Allow "_" in attribute names.
1494
1495 2019-06-14  Tom Tromey  <tromey@adacore.com>
1496
1497         PR gdb/24653:
1498         * regcache.c (registers_changed): Don't call alloca.
1499         * top.c (execute_command): Don't call alloca.
1500
1501 2019-06-13  Pedro Alves  <palves@redhat.com>
1502
1503         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1504         'expression'.  When parsing an expression, error out if there's
1505         junk after "unlimited".
1506         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1507         (do_set_command): Adjust calls to is_unlimited_literal.
1508
1509 2019-06-13  Pedro Alves  <palves@redhat.com>
1510
1511         * compile/compile.c (make_compile_options_def_group): Add braces
1512         around array_view initializer.
1513         * thread.c (make_thread_apply_all_options_def_group)
1514         (make_thread_apply_all_options_def_group): Likewise.
1515
1516 2019-06-13  Pedro Alves  <palves@redhat.com>
1517
1518         * NEWS (New commands): Mention "maint test-options
1519         require-delimiter", "maint test-options unknown-is-error", "maint
1520         test-options unknown-is-operand" and "maint show
1521         test-options-completion-result".
1522         (New command options, command completion): New section.
1523         (Completion improvements): New section.
1524         Mention that you can abbreviate "unlimited".
1525
1526 2019-06-13  Pedro Alves  <palves@redhat.com>
1527
1528         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1529         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1530         * unittests/cli-utils-selftests.c (test_parse_flags)
1531         (test_parse_flags_qcs): Delete.
1532         (test_cli_utils): Don't call deleted functions.
1533
1534 2019-06-13  Pedro Alves  <palves@redhat.com>
1535
1536         * thread.c: Include "cli/cli-option.h".
1537         (tp_array_compar_ascending): Global.
1538         (tp_array_compar): Delete function.
1539         (tp_array_compar_ascending, tp_array_compar_descending): New
1540         functions.
1541         (ascending_option_def, qcs_flag_option_def)
1542         (thr_qcs_flags_option_defs)
1543         (make_thread_apply_all_options_def_group)
1544         (make_thread_apply_options_def_group): New.
1545         (thread_apply_all_command): Use gdb::option::process_options.
1546         (thread_apply_command_completer)
1547         (thread_apply_all_command_completer): New.
1548         (thread_apply_command): Use gdb::option::process_options.
1549         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1550         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1551         to generate help text of "thread apply".  Adjust "taas"'s help.
1552         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1553         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1554
1555 2019-06-13  Pedro Alves  <palves@redhat.com>
1556
1557         * thread.c (thread_apply_command): Check for invalid TID with
1558         isdigit instead of !isalpha.
1559
1560 2019-06-13  Pedro Alves  <palves@redhat.com>
1561
1562         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1563         (validate_flags_qcs): New.
1564         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1565         (validate_flags_qcs): Declare.
1566         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1567         (make_frame_apply_options_def_group): New.
1568         (frame_apply_command_count): Process options with
1569         gdb::option::process_options.
1570         (frame_apply_completer): New.
1571         (frame_apply_level_completer, frame_apply_all_completer)
1572         (frame_apply_completer): New.
1573         (_initialize_stack): Update help of "frame apply", "frame apply
1574         level", "frame apply all" and "faas" to mention supported options
1575         and install command completers.
1576         * stack.h (frame_apply_all_completer): Declare.
1577         * thread.c: Include "stack.h".
1578         (tfaas_command): Add "--".
1579         (_initialize_thread): Update help "tfaas" to mention supported
1580         options and install command completer.
1581
1582 2019-06-13  Pedro Alves  <palves@redhat.com>
1583
1584         * completer.c (complete_nested_command_line): New.
1585         (gdb_completion_word_break_characters_throw): Add assertion.
1586         * completer.h (complete_nested_command_line): Declare.
1587
1588 2019-06-13  Pedro Alves  <palves@redhat.com>
1589
1590         * stack.c (parse_backtrace_qualifiers): New.
1591         (backtrace_command): Use it.
1592         (backtrace_command_completer): Complete on qualifiers.
1593
1594 2019-06-13  Pedro Alves  <palves@redhat.com>
1595
1596         * frame.c: Include "cli/cli-option.h.
1597         (user_set_backtrace_options): New.
1598         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1599         Delete.
1600         (get_prev_frame): Adjust.
1601         (boolean_option_def, uinteger_option_def)
1602         (set_backtrace_option_defs): New.
1603         (_initialize_frame): Adjust and use
1604         gdb::option::add_setshow_cmds_for_options to install "set
1605         backtrace past-main" and "set backtrace past-entry".
1606         * frame.h: Include "cli/cli-option.h".
1607         (struct frame_print_options): Forward declare.
1608         (print_frame_arguments_all, print_frame_arguments_scalars)
1609         (print_frame_arguments_none): Declare.
1610         (print_entry_values): Delete declaration.
1611         (struct frame_print_options, user_frame_print_options): New.
1612         (struct set_backtrace_options): New.
1613         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1614         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1615         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1616         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1617         (list_args_or_locals): Add frame_print_options parameter.
1618         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1619         * python/py-framefilter.c (enumerate_args): Pass down
1620         USER_FRAME_PRINT_OPTIONS.
1621         * stack.c: Include "cli/cli-option.h".
1622         (print_frame_arguments_all, print_frame_arguments_scalars)
1623         (print_frame_arguments_none): Declare.
1624         (print_raw_frame_arguments, print_entry_values): Delete.
1625         (user_frame_print_options): New.
1626         (boolean_option_def, enum_option_def, frame_print_option_defs):
1627         New.
1628         (struct backtrace_cmd_options): New.
1629         (bt_flag_option_def): New.
1630         (backtrace_command_option_defs): New.
1631         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1632         (print_frame_arg, read_frame_arg, print_frame_args)
1633         (print_frame_info, print_frame): Add frame_print_options parameter
1634         and use it.
1635         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1636         (backtrace_command_1): Add frame_print_options and
1637         backtrace_cmd_options parameters and use them.
1638         (make_backtrace_options_def_group): New.
1639         (backtrace_command): Process command options with
1640         gdb::option::process_options.
1641         (backtrace_command_completer): New.
1642         (_initialize_stack): Extend "backtrace"'s help to mention
1643         supported options.  Install completer for "backtrace".
1644         Install some settings commands with add_setshow_cmds_for_options.
1645
1646 2019-06-13  Pedro Alves  <palves@redhat.com>
1647
1648         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1649         and that "set/show print raw frame-arguments" are now deprecated.
1650
1651         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1652         command.
1653         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1654         * stack.c (_initialize_stack): Install "set/show print
1655         raw-frame-arguments", and deprecate "set/show print raw
1656         frame-arguments".
1657         * valprint.c (_initialize_valprint): Deprecate "set/show print
1658         raw".
1659
1660 2019-06-13  Pedro Alves  <palves@redhat.com>
1661
1662         * compile/compile.c (struct compile_options): New.
1663         (compile_flag_option_def, compile_command_option_defs)
1664         (make_compile_options_def_group): New.
1665         (compile_file_command): Handle options with
1666         gdb::option::process_options.
1667         (compile_file_command_completer): New function.
1668         (compile_code_command): Handle options with
1669         gdb::option::process_options.
1670         (compile_code_command_completer): New function.
1671         (_initialize_compiler): Install completers for "compile code" and
1672         "compile file".  Mention available options in "compile code" and
1673         "compile code"'s help.
1674         * completer.c (advance_to_completion_word): New, factored out from
1675         ...
1676         (advance_to_expression_complete_word_point): ... this.
1677         (advance_to_filename_complete_word_point): New.
1678         * completer.h (advance_to_filename_complete_word_point): New
1679         declaration.
1680
1681 2019-06-13  Pedro Alves  <palves@redhat.com>
1682
1683         * compile/compile.c: Include "cli/cli-option.h".
1684         (compile_print_value): Scope data pointer is now a
1685         value_print_options pointer; adjust.
1686         (compile_print_command): Process options.  Scope data pointer is
1687         now a value_print_options pointer; adjust.
1688         (_initialize_compile): Update "compile print"'s help to include
1689         supported options.  Install a completer for "compile print".
1690         * cp-valprint.c (show_vtblprint, show_objectprint)
1691         (show_static_field_print): Delete.
1692         (_initialize_cp_valprint): Don't install "set print
1693         static-members", "set print vtbl", "set print object" here.
1694         * printcmd.c: Include "cli/cli-option.h" and
1695         "common/gdb_optional.h".
1696         (print_command_parse_format): Rework to fill in a
1697         value_print_options instead of a format_data.
1698         (print_value): Change parameter type from format_data pointer to
1699         value_print_options reference.  Adjust.
1700         (print_command_1): Process options.  Adjust to pass down a
1701         value_print_options.
1702         (print_command_completer): New.
1703         (_initialize_printcmd): Install print_command_completer as
1704         handle_brkchars completer for the "print" command.  Update
1705         "print"'s help to include supported options.
1706         * valprint.c: Include "cli/cli-option.h".
1707         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1708         here from cp-valprint.c.
1709         (boolean_option_def, uinteger_option_def)
1710         (value_print_option_defs, make_value_print_options_def_group):
1711         New.  Use gdb::option::add_setshow_cmds_for_options to install
1712         "set print elements", "set print null-stop", "set print repeats",
1713         "set print pretty", "set print union", "set print array", "set
1714         print address", "set print symbol", "set print array-indexes".
1715         * valprint.h: Include <string> and "cli/cli-option.h".
1716         (make_value_print_options_def_group): Declare.
1717         (print_value): Change parameter type from format_data pointer to
1718         value_print_options reference.
1719         (print_command_completer): Declare.
1720
1721 2019-06-13  Pedro Alves  <palves@redhat.com>
1722
1723         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1724         (COMMON_SFILES): Add maint-test-settings.c.
1725         * cli/cli-decode.c (boolean_enums): New global, factored out from
1726         ...
1727         (add_setshow_boolean_cmd): ... here.
1728         * cli/cli-decode.h (boolean_enums): Declare.
1729         * cli/cli-option.c: New file.
1730         * cli/cli-option.h: New file.
1731         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1732         factored out from ...
1733         (parse_cli_boolean_value(const char *)): ... this.
1734         (is_unlimited_literal): Change parameter type to pointer to
1735         pointer.  Adjust and advance ARG pointer.
1736         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1737         (parse_cli_var_enum): New, factored out from ...
1738         (do_set_command): ... this.  Adjust.
1739         * cli/cli-setshow.h (parse_cli_boolean_value)
1740         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1741         (parse_cli_var_enum): Declare.
1742         * cli/cli-utils.c: Include "cli/cli-option.h".
1743         (get_ulongest): New.
1744         * cli/cli-utils.h (get_ulongest): Declare.
1745         (check_for_argument): New overloads.
1746         * maint-test-options.c: New file.
1747
1748 2019-06-13  Pedro Alves  <palves@redhat.com>
1749
1750         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1751         parse a range if "-" is at the end of the string.
1752
1753 2019-06-13  Pedro Alves  <palves@redhat.com>
1754
1755         * cli/cli-setshow.c (parse_auto_binary_operation)
1756         (parse_cli_boolean_value): Don't allow "o".
1757
1758 2019-06-13  Pedro Alves  <palves@redhat.com>
1759
1760         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1761         * NEWS: Mention maint test-settings KIND.
1762         * maint-test-settings.c: New file.
1763
1764 2019-06-13  Pedro Alves  <palves@redhat.com>
1765
1766         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1767         completer.
1768         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1769         "set" completers.
1770
1771 2019-06-13  Pedro Alves  <palves@redhat.com>
1772
1773         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1774         after item.
1775
1776 2019-06-13  Pedro Alves  <palves@redhat.com>
1777
1778         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1779
1780 2019-06-13  Pedro Alves <palves@redhat.com>
1781
1782         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1783         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1784         call.
1785         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1786         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1787         calls.
1788         (check_for_argument): Skip spaces after argument.
1789
1790 2019-06-13  Pedro Alves  <palves@redhat.com>
1791
1792         * thread.c (thread_apply_command): Adjust TID parsing.
1793         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1794         detected before end of string.
1795         (tid_is_in_list): Error out if LIST is invalid.
1796
1797 2019-06-13  Pedro Alves  <palves@redhat.com>
1798
1799         * completer.c (complete_line_internal_1): Rewind completion word
1800         point.
1801         (completion_tracker::advance_custom_word_point_by): Change
1802         parameter type to int.
1803         * completer.h (completion_tracker::advance_custom_word_point_by):
1804         Likewise.
1805
1806 2019-06-13  Pedro Alves  <palves@redhat.com>
1807
1808         * completer.c (advance_to_completion_word): Handle delimiters.
1809
1810 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1811
1812         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1813
1814 2019-06-11  Tom Tromey  <tom@tromey.com>
1815
1816         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1817         (xmalloc_failed): Move to alloc.c.
1818         * alloc.c: New file.
1819         * Makefile.in (COMMON_SFILES): Add alloc.c.
1820
1821 2019-06-11  Tom Tromey  <tom@tromey.com>
1822
1823         * nat/linux-waitpid.c: Don't include server.h.
1824         (linux_debug): Remove.
1825         (my_waitpid): Update.
1826
1827 2019-06-11  Tom Tromey  <tromey@adacore.com>
1828
1829         * infcall.c (_initialize_infcall): Remove trailing newline from
1830         help.
1831         * user-regs.c (_initialize_user_regs): Remove trailing newline
1832         from help.
1833         * typeprint.c (_initialize_typeprint): Remove trailing newline
1834         from help.
1835         * reverse.c (_initialize_reverse): Remove trailing newlines from
1836         help.
1837         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1838         from help.
1839         * language.c (add_set_language_command): Remove trailing newline
1840         from help.
1841         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1842         help.
1843         * disasm.c (_initialize_disasm): Remove trailing newline from
1844         help.
1845         * top.c (init_main): Remove trailing newline from help.
1846         * interps.c (_initialize_interpreter): Remove trailing newline
1847         from help.
1848         * btrace.c (_initialize_btrace): Remove trailing newlines from
1849         help.
1850         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1851         from help.
1852         * python/python.c (_initialize_python): Remove trailing newline
1853         from help.
1854         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1855         help.
1856         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1857         from help.  Reformat some text.
1858         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1859         from help.
1860         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1861         newline from help.
1862
1863 2019-06-11  Tom Tromey  <tromey@adacore.com>
1864
1865         * darwin-nat.c (darwin_decode_exception_message)
1866         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1867
1868 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * valops.c (value_slice): Check for not allocated or not
1871         associated values.
1872
1873 2019-06-10  Tom de Vries  <tdevries@suse.de>
1874
1875         PR gdb/24618
1876         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1877         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1878         invalid.
1879
1880 2019-06-10  Tom de Vries  <tdevries@suse.de>
1881
1882         PR gdb/24611
1883         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1884         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1885
1886 2019-06-10  Tom de Vries  <tdevries@suse.de>
1887
1888         PR symtab/24545
1889         * symtab.c (struct demangled_name_entry): Add language field.
1890         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1891         static minimal symbol".  Set and use language field.
1892
1893 2019-06-10  Tom Tromey  <tromey@adacore.com>
1894
1895         * ada-lang.c (_initialize_ada_language): Update help text.
1896
1897 2019-06-10  Tom Tromey  <tromey@adacore.com>
1898
1899         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1900         with a newline.
1901         * guile/guile.c (handle_boot_error): Don't end warning with a
1902         newline.
1903         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1904         warning with a newline.
1905         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1906         newline.
1907         (s12z_frame_cache): Likewise.
1908         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1909         a newline.
1910         * solib-svr4.c (disable_probes_interface): Don't end warning with
1911         a newline.
1912         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1913         newline.
1914         * python/python.c (do_finish_initialization): Don't end warning
1915         with a newline.
1916
1917 2019-06-10  Tom Tromey  <tom@tromey.com>
1918
1919         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1920         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1921         gdbpy_enter.
1922
1923 2019-06-10  Tom Tromey  <tromey@adacore.com>
1924
1925         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1926         data.
1927         (elf_new_init): Don't call stabsread_new_init.
1928         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1929         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1930         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1931
1932 2019-06-10  Tom de Vries  <tdevries@suse.de>
1933
1934         PR symtab/16264
1935         PR symtab/24517
1936         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1937
1938 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1939
1940         * source.c (find_and_open_source): Also rewrite relative file
1941         names.
1942
1943 2019-04-26  Amos Bird  <amosbird@gmail.com>
1944
1945         * annotate.c (annotate_thread_exited): Add "thread-exited"
1946         annotation.
1947
1948 2019-06-06  Tom Tromey  <tromey@adacore.com>
1949
1950         * maint.h (class scoped_command_stats): Use
1951         DISABLE_COPY_AND_ASSIGN.
1952         <print_time>: New method.
1953         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1954         print_time.
1955         (scoped_command_stats::print_time): New method.
1956
1957 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1960         instructions of lengths 6 or 8 bytes.
1961
1962 2019-06-04  Pedro Alves  <palves@redhat.com>
1963
1964         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1965
1966         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1967         * breakpoint.c (condition_completer): Likewise.
1968         * cli/cli-dump.c (scan_expression): Likewise.
1969         * common/filestuff.c (mkdir_recursive): Likewise.
1970         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1971         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1972         (gdb_abspath): Likewise.
1973         * compile/compile-cplus-types.c
1974         (compile_cplus_instance::decl_name): Likewise.
1975         * completer.c (complete_explicit_location):
1976         (signal_completer, reg_or_group_completer_1): Likewise.
1977         * cp-support.c (cp_remove_params_if_any): Likewise.
1978         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1979         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1980         * infcmd.c (strip_bg_char): Likewise.
1981         * linespec.c (copy_token_string): Likewise.
1982         * mi/mi-main.c (output_cores): Likewise.
1983         * psymtab.c (psymtab_search_name):
1984         * symfile.c (test_set_ext_lang_command): Likewise.
1985         * target.c (target_fileio_read_stralloc): Likewise.
1986         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1987         * value.c (complete_internalvar): Likewise.
1988
1989 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1990
1991         Add objfile property to gdb.Type.
1992         * NEWS: Mention Python API addition.
1993         * python/py-type.c (typy_get_objfile): New method.
1994
1995 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1996
1997         * NEWS: Mention the new set|show style [title|highlight].
1998         Mention changes to "show style", "help" and "apropos".
1999
2000 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2001
2002         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2003         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2004         instead of print_help_for_command.
2005         (print_doc_of_command): New function.
2006         (help_list): Add 'apropos -v word' suggestion.
2007         (print_help_for_command): Style the command name using title style.
2008         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2009         (_initialize_cli_cmds): Describe -v in apropos_command help.
2010
2011 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2012
2013         * cli/cli-style.h (cli_style_option): Add name in constructor,
2014         add m_name class member, add constructor with intensity,
2015         add name class function.
2016         (cli_style_option::add_setshow_commands): Remove name argument.
2017         (highlight_style, title_style): New styles.
2018         * cli/cli-style.c (do_show): New function that shows a style
2019         characteristic styling the style name with itself.
2020         (set_style_name): New function.
2021         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2022         Update all callers according to the changes in cli/cli-style.h.
2023         * utils.h (fputs_highlighted): New function.
2024         * utils.c (fputs_highlighted): Likewise.
2025
2026 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2027
2028         * NEWS: Mention new pipe command and new convenience variables.
2029
2030 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2031
2032         * cli/cli-cmds.c (pipe_command): New function.
2033         (_initialize_cli_cmds): Call add_com for pipe_command.
2034         Define | as an alias for pipe.
2035         (exit_status_set_internal_vars): New function.
2036         (shell_escape): Call exit_status_set_internal_vars.
2037         cli/cli-decode.c (find_command_name_length): Recognize | as
2038         a single character command.
2039
2040 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2041
2042         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2043         top.c (execute_command_to_ui_file): New function, mostly a copy
2044         of execute_command_to_string.
2045         (execute_command_to_string): Implement by calling
2046         execute_command_to_ui_file.
2047
2048 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2049
2050         * top.h (saved_command_line): Remove declaration.
2051         * top.c (previous_saved_command_line, previous_repeat_arguments):
2052         New variables.
2053         (saved_command_line): Make static, define together with other
2054         'repeat variables'.
2055         (dont_repeat): Clear repeat_arguments.
2056         (repeat_previous, get_saved_command_line, save_command_line):
2057         New functions.
2058         (gdb_init): Initialize saved_command_line
2059         and previous_saved_command_line.
2060         * main.c (captured_main_1): Remove saved_command_line initialization.
2061         * event-top.c (handle_line_of_input): Update to use
2062         the new 'repeat' related functions instead of direct access to
2063         saved_command_line.
2064         * command.h (repeat_previous, get_saved_command_line,
2065         save_command_line): New declarations.
2066         (dont_repeat): Add comment.
2067
2068 2019-05-30  Tom Tromey  <tromey@adacore.com>
2069
2070         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2071         Fix comment.
2072         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2073
2074 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2075
2076         PR cli/24587
2077         * completer.c (complete): Initialize variable word.
2078
2079 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2080
2081         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2082         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2083         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2084         'body' is NULL to the outter 'if', protecting the '!is_define'
2085         situation as well.
2086
2087 2019-05-29  Tom Tromey  <tromey@adacore.com>
2088
2089         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2090         (dwarf_unknown): New function.
2091         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2092         (dwarf_type_encoding_name): Use dwarf_unknown.
2093
2094 2019-05-29  Tom Tromey  <tromey@adacore.com>
2095
2096         PR c++/20020:
2097         * cp-valprint.c (cp_print_value_fields): Call
2098         cp_print_static_field inside "try".
2099
2100 2019-05-29  Tom Tromey  <tromey@adacore.com>
2101
2102         * inflow.c (struct terminal_info): Add default operator=.
2103         * configure: Rebuild.
2104         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2105         -Wdeprecated-copy-dtor, -Wredundant-move.
2106
2107 2019-05-29  Tom Tromey  <tromey@adacore.com>
2108
2109         * NEWS: Add entry.
2110         * infcmd.c (print_return_value_1): Handle finish_print
2111         option.
2112         (show_print_finish): New function.
2113         (_initialize_infcmd): Add "set/show print finish" commands.
2114         * valprint.c (user_print_options): Initialize new member.
2115         * valprint.h (struct value_print_options) <finish_print>: New
2116         member.
2117
2118 2019-05-28  Tom Tromey  <tromey@adacore.com>
2119
2120         * ada-lang.c (ada_remove_Xbn_suffix)
2121         (find_old_style_renaming_symbol)
2122         (parse_old_style_renaming): Remove.
2123         (ada_find_renaming_symbol): Don't call
2124         find_old_style_renaming_symbol.
2125         (ada_is_renaming_symbol): Rename from
2126         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2127         bool.  Now static.
2128         (ada_read_var_value): Update and simplify.
2129         * ada-exp.y (write_var_or_type): Remove old code.
2130
2131 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2132
2133         * event-top.c: Remove include comment.
2134         * inflow.c (class scoped_ignore_sigttou): Move from here...
2135         * inflow.h (class scoped_ignore_sigttou): ...to here.
2136         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2137         * top.c:  Remove include comment.
2138
2139 2019-05-27  Tom Tromey  <tom@tromey.com>
2140
2141         * NEWS: Fix typo.
2142
2143 2019-05-22  Tom Tromey  <tromey@adacore.com>
2144
2145         * target.c (target_follow_exec): Constify parameter.
2146         * target-delegates.c: Rebuild.
2147         * remote.c (remote_target::follow_exec): Constify parameter.
2148         * infrun.c (follow_exec): Constify parameter.
2149         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2150         (target_follow_exec): Likewise.
2151
2152 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2153
2154         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2155         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2156
2157 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2158
2159         * NEWS: Add debugredirect and testsuite sections.
2160
2161 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2162
2163         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2164         target descriptions using exclusively floating point register name
2165         aliases.
2166
2167 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2168
2169         PR gdb/18644:
2170         * f-lang.c (build_fortran_types): Handle the case where
2171         gdbarch_floatformat_for_type returns a nullptr.
2172
2173 2019-05-21  Tom de Vries  <tdevries@suse.de>
2174
2175         PR cli/24587
2176         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2177
2178 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         PR gdb/18644:
2181         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2182         16-byte floats.
2183         * i386-tdep.c (i386_floatformat_for_type): Use
2184         floatformats_ia64_quad for the 16-byte floating point component
2185         within a fortran 32-byte complex number.
2186
2187 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2190         delete default constructor.
2191         (find_partial_die): Update to return const struct.
2192         (partial_die_parent_scope): Move variable declaration into scope
2193         of its use and change its type to auto.
2194         (guess_partial_die_structure_name): Likewise.
2195         (partial_die_info::fixup): Likewise.
2196
2197 2019-05-17  Tom Tromey  <tromey@adacore.com>
2198
2199         * source.c (find_and_open_source): Remove cast.
2200
2201 2019-05-17  Tom Tromey  <tromey@adacore.com>
2202
2203         * annotate.c (annotate_source): Make "filename" const.
2204         * annotate.h (annotate_source): Use const.
2205
2206 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2207
2208         * disasm.c (set_disassembler_options): Send errors to stderr.
2209
2210 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2211
2212         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2213         (cli_interp_base::set_logging): Check debug_redirect.
2214         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2215         * cli/cli-logging.c (debug_redirect): Add static variable.
2216         (pop_output_files): Add default param.
2217         (handle_redirections): Print debug setting.
2218         (show_logging_command): Likewise.
2219         (_initialize_cli_logging): Add debugredirect command.
2220         * interps.c (current_interp_set_logging): Add debug_redirect
2221         parameter.
2222         * interps.h (set_logging): Add debug_redirect parameter.
2223         (current_interp_set_logging): Likewise.
2224         * mi/mi-common.h: Likewise.
2225         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2226
2227 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2228             Tom Tromey  <tromey@adacore.com>
2229
2230         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2231         directly.
2232         * cli/cli-interp.h (make_logging_output): Remove declaration.
2233         * cli/cli-logging.c (make_logging_output): Remove function.
2234         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2235         directly.
2236         * ui-file.c (tee_file::tee_file): Remove bools.
2237         (tee_file::~tee_file): Remove deletes.
2238         * ui-file.h (tee_file): Remove bools.
2239
2240 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2241
2242         * mi/mi-cmds.h (mi_cmd_complete): New function.
2243         * mi/mi-main.c (mi_cmd_complete): Likewise.
2244         * mi/mi-cmds.c: Define new MI command -complete.
2245         * NEWS: Mention new -complete command.
2246
2247 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2248
2249         * completer.h (complete): New function.
2250         * completer.c (complete): Likewise.
2251         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2252         function defined in completer.h.
2253
2254 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2255
2256         * MAINTAINERS (Write After Approval): Add myself.
2257
2258 2019-05-17  Tom de Vries  <tdevries@suse.de>
2259
2260         PR gdb/24094
2261         * dwarf2read.c (struct cu_partial_die_info): New struct.
2262         (find_partial_die): Return cu_partial_die_info.
2263         (partial_die_parent_scope, guess_partial_die_structure_name)
2264         (partial_die_info::fixup): Handle new return type of find_partial_die.
2265
2266 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2267
2268         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2269         "std::string", simplifying the algorithm.
2270
2271 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2272
2273         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2274         (stap_static_probe_ops::get_probes): Likewise.
2275
2276 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2277
2278         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2279         '-')" and "else if".
2280         (stap_parse_single_operand): Join checks for
2281         "gdbarch_stap_parse_special_token_p" and
2282         "gdbarch_stap_parse_special_token" in the same "if" statement.
2283         Invert check when verifying for operation on register
2284         displacement.
2285
2286 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2287
2288         * stap-probe.c (stap_get_opcode): Update comment.
2289         (stap_get_expected_argument_type): Likewise.
2290         (handle_stap_probe): Likewise.
2291
2292 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2293
2294         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2295         return type to 'bool'.  Adjust comment.  Use 'bool' when
2296         appropriate.
2297         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2298         * stap-probe.c (stap_parse_argument_1): Likewise.
2299         (stap_is_operator): Likewise.
2300         (stap_is_generic_prefix): Likewise.
2301         (stap_is_register_prefix): Likewise.
2302         (stap_is_register_indirection_prefix): Likewise.
2303         (stap_is_integer_prefix): Likewise.
2304         (stap_generic_check_suffix): Likewise.
2305         (stap_check_integer_suffix): Likewise.
2306         (stap_check_register_suffix): Likewise.
2307         (stap_check_register_indirection_suffix): Likewise.
2308         (stap_parse_register_operand): Likewise.
2309         (stap_parse_single_operand): Likewise.
2310         (stap_parse_argument_1): Likewise.
2311         (stap_probe::get_argument_count): Likewise.
2312         (stap_is_operator): Likewise.
2313
2314 2019-05-16  Tom Tromey  <tromey@adacore.com>
2315
2316         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2317         keyword to foreach.
2318
2319 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2320
2321         * linux-thread-db.c (try_thread_db_load_1): Change return type
2322         to bool.
2323         (try_thread_db_load): Likewise.
2324         (try_thread_db_load_from_pdir_1): Likewise.
2325         (try_thread_db_load_from_pdir): Likewise.
2326         (try_thread_db_load_from_sdir): Likewise.
2327         (try_thread_db_load_from_dir): Likewise.
2328         (thread_db_load_search): Likewise.
2329         (has_libpthread): Likewise.
2330         (thread_db_load): Likewise.
2331
2332 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2333
2334         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2335         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2336         NULL, and complain/return if that's the case.
2337
2338 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2339
2340         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2341         (advance, posn, abstract_read_memory): New functions.
2342         [struct mem_read_abstraction]: New struct.
2343         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2344
2345 2019-05-14  Tom Tromey  <tromey@adacore.com>
2346
2347         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2348         value is not lval_memory.
2349
2350 2019-05-14  Tom Tromey  <tromey@adacore.com>
2351
2352         * solib.c (info_sharedlibrary_command): Style the file name.
2353
2354 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2355
2356         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2357         (aarch64_vnv_type): Likewise.
2358         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2359         * common/tdesc.c: Likewise.
2360         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2361         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2362         * features/aarch64-fpu.xml: Add ieee half view.
2363         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2364         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2365         * gdbtypes.h (struct builtin_type): Likewise.
2366         (struct objfile_type): Likewise.
2367
2368 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2369
2370         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2371         typo.
2372         * location.h (string_to_event_location): Likewise.
2373
2374 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2375
2376         GDB 8.3 released.
2377
2378 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2379
2380         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2381         New variable declaration.
2382         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2383         New variable.
2384         (print_one_breakpoint): Use ui_out::test_flags and new global
2385         variable to compute use_fixed_output.
2386         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2387         Remove.
2388         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2389         (mi_multi_location_breakpoint_output_fixed): Remove.
2390         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2391         new variable.
2392         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2393         fix_multi_location_breakpoint_output flag if version >= 3.
2394         * ui-out.h (enum ui_out_flag)
2395         <fix_multi_location_breakpoint_output>: New enumerator.
2396
2397 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2400
2401 2019-05-10  Tom Tromey  <tromey@adacore.com>
2402
2403         * ada-lang.c (catch_ada_completer): New function.
2404         (_initialize_ada_language): Use it.
2405
2406 2019-05-10  Tom Tromey  <tromey@adacore.com>
2407
2408         * thread.c (print_thread_info): Make "requested_threads" const.
2409         * gdbthread.h (print_thread_info): Make "requested_threads"
2410         const.
2411         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2412         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2413
2414 2019-05-08  Tom Tromey  <tom@tromey.com>
2415
2416         * gdbtypes.c (objfile_type_data): Change type.
2417         (objfile_type, _initialize_gdbtypes): Update.
2418
2419 2019-05-08  Tom Tromey  <tom@tromey.com>
2420
2421         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2422         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2423         (_initialize_dwarf2_frame): Update.
2424
2425 2019-05-08  Tom Tromey  <tom@tromey.com>
2426
2427         * objc-lang.c (objc_objfile_data): Change type.
2428         (find_methods): Update.
2429         (_initialize_objc_lang): Remove.
2430
2431 2019-05-08  Tom Tromey  <tom@tromey.com>
2432
2433         * stabsread.c (rs6000_builtin_type_data): Change type.
2434         (rs6000_builtin_type, _initialize_stabsread): Update.
2435
2436 2019-05-08  Tom Tromey  <tom@tromey.com>
2437
2438         * mips-tdep.c (mips_pdr_data): Remove.
2439         (_initialize_mips_tdep): Update.
2440
2441 2019-05-08  Tom Tromey  <tom@tromey.com>
2442
2443         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2444         (hppa_init_objfile_priv_data, read_unwind_info)
2445         (find_unwind_entry, _initialize_hppa_tdep): Update.
2446
2447 2019-05-08  Tom Tromey  <tom@tromey.com>
2448
2449         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2450         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2451         on obstack.
2452         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2453
2454 2019-05-08  Tom Tromey  <tom@tromey.com>
2455
2456         * mdebugread.c (basic_type_data): Change type.
2457         (basic_type, _initialize_mdebugread): Update.
2458
2459 2019-05-08  Tom Tromey  <tom@tromey.com>
2460
2461         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2462
2463 2019-05-08  Tom Tromey  <tom@tromey.com>
2464
2465         * nto-tdep.c (nto_inferior_data_reg): Change type.
2466         (nto_inferior_data): Update.
2467         (nto_inferior_data_cleanup, nto_new_inferior_data)
2468         (_initialize_nto_tdep): Remove.
2469         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2470
2471 2019-05-08  Tom Tromey  <tom@tromey.com>
2472
2473         * ada-lang.c (struct ada_inferior_data): Add initializers.
2474         (ada_inferior_data): Change type.
2475         (ada_inferior_data_cleanup): Remove.
2476         (get_ada_inferior_data, ada_inferior_exit)
2477         (struct ada_pspace_data): Add initializers, destructor.
2478         (ada_pspace_data_handle): Change type.
2479         (get_ada_pspace_data): Update.
2480         (ada_pspace_data_cleanup): Remove.
2481
2482 2019-05-08  Tom Tromey  <tom@tromey.com>
2483
2484         * coffread.c (struct coff_symfile_info): Add initializers.
2485         (coff_objfile_data_key): Move lower.  Change type.
2486         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2487         Update.
2488         (coff_free_info): Remove.
2489
2490 2019-05-08  Tom Tromey  <tom@tromey.com>
2491
2492         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2493         (fbsd_pspace_data_handle): Move lower.  Change type.
2494         (get_fbsd_pspace_data): Update.
2495         (fbsd_pspace_data_cleanup): Remove.
2496         (_initialize_fbsd_tdep): Update.
2497
2498 2019-05-08  Tom Tromey  <tom@tromey.com>
2499
2500         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2501         (get_ada_tasks_pspace_data): Update.
2502         (ada_tasks_pspace_data_cleanup): Remove.
2503         (_initialize_tasks): Update.
2504         (ada_tasks_inferior_data_handle): Change type.
2505         (get_ada_tasks_inferior_data): Update.
2506         (ada_tasks_inferior_data_cleanup): Remove.
2507         (struct ada_tasks_pspace_data): Add initializers.
2508
2509 2019-05-08  Tom Tromey  <tom@tromey.com>
2510
2511         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2512         * symfile-debug.c (debug_sym_get_probes): Change type.
2513         * stap-probe.c (handle_stap_probe):
2514         (stap_static_probe_ops::get_probes): Change type.
2515         * probe.h (class static_probe_ops) <get_probes>: Change type.
2516         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2517         (parse_probes_in_pspace): Update.
2518         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2519         Update.
2520         (any_static_probe_ops::get_probes): Change type.
2521         * elfread.c (elfread_data): New typedef.
2522         (probe_key): Change type.
2523         (elf_get_probes): Likewise.  Update.
2524         (probe_key_free): Remove.
2525         (_initialize_elfread): Update.
2526         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2527         Change type.
2528         (dtrace_process_dof_probe, dtrace_process_dof)
2529         (dtrace_static_probe_ops::get_probe): Change type.
2530
2531 2019-05-08  Tom Tromey  <tom@tromey.com>
2532
2533         * xcoffread.c (struct xcoff_symfile_info): Rename from
2534         coff_symfile_info.  Add initializers.
2535         (xcoff_objfile_data_key): Move lower.  Change type.
2536         (XCOFF_DATA): Rewrite.
2537         (xcoff_free_info): Remove.
2538         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2539         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2540         (xcoff_initial_scan): Update.
2541
2542 2019-05-08  Tom Tromey  <tom@tromey.com>
2543
2544         * solib-svr4.c (struct svr4_info): Add initializers and
2545         destructor.
2546         <probes_table>: Now an htab_up.
2547         (solib_svr4_pspace_data): Change type.
2548         (free_probes_table): Simplify.
2549         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2550         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2551         (probes_table_remove_objfile_probes, register_solib_event_probe)
2552         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2553         (_initialize_svr4_solib): Update.
2554
2555 2019-05-08  Tom Tromey  <tom@tromey.com>
2556
2557         * remote.c (remote_pspace_data): Change type.
2558         (remote_pspace_data_cleanup): Remove.
2559         (get_remote_exec_file, set_pspace_remote_exec_file)
2560         (_initialize_remote): Update.
2561
2562 2019-05-08  Tom Tromey  <tom@tromey.com>
2563
2564         * breakpoint.c (breakpoint_objfile_key): Change type.
2565         (get_breakpoint_objfile_data): Update.
2566         (free_breakpoint_objfile_data): Remove.
2567         (_initialize_breakpoint): Update.
2568
2569 2019-05-08  Tom Tromey  <tom@tromey.com>
2570
2571         * linux-tdep.c (struct linux_info): Add initializers.
2572         (linux_inferior_data): Move.  Change type.
2573         (invalidate_linux_cache_inf): Update.
2574         (linux_inferior_data_cleanup): Remove.
2575         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2576
2577 2019-05-08  Tom Tromey  <tom@tromey.com>
2578
2579         * auxv.c (auxv_inferior_data): Move.  Change type.
2580         (auxv_inferior_data_cleanup): Remove.
2581         (invalidate_auxv_cache_inf): Rewrite.
2582         (get_auxv_inferior_data, _initialize_auxv): Update.
2583
2584 2019-05-08  Tom Tromey  <tom@tromey.com>
2585
2586         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2587         (symfile_debug_objfile_data_key): Change type.
2588         (symfile_debug_installed, debug_qf_has_symbols)
2589         (debug_qf_find_last_source_symtab)
2590         (debug_qf_forget_cached_source_info)
2591         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2592         (debug_qf_print_stats, debug_qf_dump)
2593         (debug_qf_expand_symtabs_for_function)
2594         (debug_qf_expand_all_symtabs)
2595         (debug_qf_expand_symtabs_with_fullname)
2596         (debug_qf_map_matching_symbols)
2597         (debug_qf_expand_symtabs_matching)
2598         (debug_qf_find_pc_sect_compunit_symtab)
2599         (debug_qf_map_symbol_filenames)
2600         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2601         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2602         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2603         (debug_sym_read_linetable, debug_sym_relocate): Update.
2604         (symfile_debug_free_objfile): Remove.
2605         (install_symfile_debug_logging, _initialize_symfile_debug):
2606         Update.
2607
2608 2019-05-08  Tom Tromey  <tom@tromey.com>
2609
2610         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2611         allocate_on_obstack.
2612         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2613         (get_dwarf2_per_objfile): Update.
2614         (set_dwarf2_per_objfile): Remove.
2615         (dwarf2_has_info, dwarf2_get_section_info): Update.
2616         (dwarf2_free_objfile): Remove.
2617         (_initialize_dwarf2_read): Update.
2618
2619 2019-05-08  Tom Tromey  <tom@tromey.com>
2620
2621         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2622         initializers.
2623         <unsupported_script_warning_printed,
2624         script_not_found_warning_printed>: Now bool.
2625         (auto_load_pspace_data): Change type.
2626         (~auto_load_pspace_info): Rename from
2627         auto_load_pspace_data_cleanup.
2628         (get_auto_load_pspace_data, init_loaded_scripts_info)
2629         (clear_section_scripts, maybe_print_unsupported_script_warning)
2630         (maybe_print_script_not_found_warning, _initialize_auto_load):
2631         Update.
2632
2633 2019-05-08  Tom Tromey  <tom@tromey.com>
2634
2635         * objfiles.c (objfile_pspace_info): Add destructor and
2636         initializers.
2637         (objfiles_pspace_data): Change type.
2638         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2639         (get_objfile_pspace_data): Update.
2640         (objfiles_bfd_data): Change type.
2641         (get_objfile_bfd_data): Update.
2642         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2643
2644 2019-05-08  Tom Tromey  <tom@tromey.com>
2645
2646         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2647         Change type.
2648         (get_catch_syscall_inferior_data): Update.
2649         (catch_syscall_inferior_data_cleanup): Remove.
2650         (_initialize_break_catch_syscall): Update.
2651
2652 2019-05-08  Tom Tromey  <tom@tromey.com>
2653
2654         * inflow.c (struct terminal_info): Add destructor and
2655         initializers.
2656         (inflow_inferior_data): Change type.
2657         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2658         (get_inflow_inferior_data, inflow_inferior_exit)
2659         (swap_terminal_info, _initialize_inflow): Update.
2660
2661 2019-05-08  Tom Tromey  <tom@tromey.com>
2662
2663         * target-dcache.c (target_dcache_cleanup): Remove.
2664         (target_dcache_aspace_key): Change type.
2665         (target_dcache_init_p, target_dcache_invalidate)
2666         (target_dcache_get, target_dcache_get_or_init)
2667         (_initialize_target_dcache): Update.
2668         * dcache.h (struct dcache_deleter): New.
2669
2670 2019-05-08  Tom Tromey  <tom@tromey.com>
2671
2672         * symtab.c (struct symbol_cache): Add destructor and
2673         initializers.
2674         (symbol_cache_key): Move.  Change type.
2675         (make_symbol_cache, free_symbol_cache): Remove.
2676         (get_symbol_cache): Update.
2677         (symbol_cache_cleanup): Remove.
2678         (ALL_PSPACES, symbol_cache_flush)
2679         (maintenance_print_symbol_cache)
2680         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2681         Update.
2682
2683 2019-05-08  Tom Tromey  <tom@tromey.com>
2684
2685         * symtab.c (struct main_info): Add destructor and initializers.
2686         (main_progspace_key): Move.  Change type.
2687         (get_main_info): Update.
2688         (main_info_cleanup): Remove.
2689         (_initialize_symtab): Update.
2690
2691 2019-05-08  Tom Tromey  <tom@tromey.com>
2692
2693         * registry.h (DECLARE_REGISTRY): Define the _key class.
2694
2695 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2696
2697         * NEWS: Merge two 'New commands' sections.
2698
2699 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2700
2701         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2702         parameter and use Ada language definition instead.
2703         (ada_val_print_ptr): Remove unused language parameter.
2704         (ada_val_print_num): Remove language parameter and use Ada language
2705         definition instead.
2706         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2707         parameter.
2708         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2709         parameter and use Ada language definition instead.
2710         (ada_val_print_1): Update all ada_val_print_xxx calls.
2711         Remove language parameter.
2712         (ada_val_print): Update ada_val_print_1 call.
2713
2714 2019-05-08  Tom Tromey  <tromey@adacore.com>
2715
2716         * remote.c (remote_hw_watchpoint_limit)
2717         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2718         Now static.
2719
2720 2019-05-08  Tom Tromey  <tromey@adacore.com>
2721
2722         * maint.c (_initialize_maint_cmds): Move initialization code to
2723         remote.c.
2724         (watchdog, show_watchdog): Move to remote.c.
2725         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2726         "watchdog" static.
2727         (_initialize_remote): Move initialization code from maint.c.
2728         * defs.h (watchdog): Don't declare.
2729
2730 2019-05-08  Tom Tromey  <tromey@adacore.com>
2731
2732         * tui/tui-interp.c: Include main.h.
2733         * interps.c: Include main.h.
2734         * main.h (interpreter_p): Declare.
2735         * defs.h (interpreter_p): Don't declare.
2736
2737 2019-05-08  Tom Tromey  <tromey@adacore.com>
2738
2739         * dwarf2loc.c: Include dwarf2read.h.
2740         * defs.h (read_unsigned_leb128): Don't declare.
2741         * dwarf2read.h (read_unsigned_leb128): Declare.
2742
2743 2019-05-08  Tom Tromey  <tromey@adacore.com>
2744
2745         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2746         method.
2747
2748 2019-05-08  Tom Tromey  <tromey@adacore.com>
2749
2750         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2751         when no wrap column is set.
2752
2753 2019-05-08  Tom Tromey  <tromey@adacore.com>
2754
2755         * c-lang.c (c_get_string): Handle non-C-style arrays.
2756
2757 2019-05-08  Tom Tromey  <tromey@adacore.com>
2758
2759         * typeprint.c (print_offset_data::update): Print the bit offset,
2760         not the number of bits remaining.
2761
2762 2019-05-08  Tom Tromey  <tromey@adacore.com>
2763
2764         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2765         padding at end of comment.
2766
2767 2019-05-08  Tom Tromey  <tromey@adacore.com>
2768
2769         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2770         Compare main types.
2771
2772 2019-05-06  Tom Tromey  <tom@tromey.com>
2773
2774         * common/scoped_mmap.c: Include common-defs.h.
2775         * common/scoped_mmap.h: Don't include config.h.
2776
2777 2019-05-04  Tom Tromey  <tom@tromey.com>
2778
2779         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2780         (struct aarch64_call_info): Add initializers.
2781         <si>: Now a std::vector.
2782         (pass_on_stack, aarch64_push_dummy_call): Update.
2783
2784 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2785             Tom Tromey  <tom@tromey.com>
2786
2787         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2788         (ppc_threads): Now a std::vector.  Now static.
2789         (hwdebug_find_thread_points_by_tid)
2790         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2791         Update.
2792
2793 2019-05-04  Tom Tromey  <tom@tromey.com>
2794
2795         * arc-tdep.c (arc_tdesc_init): Return bool.
2796
2797 2019-05-04  Tom Tromey  <tom@tromey.com>
2798
2799         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2800         Use gdb_assert_not_reached.
2801
2802 2019-05-04  Tom Tromey  <tom@tromey.com>
2803
2804         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2805         "false".
2806
2807 2019-05-04  Tom Tromey  <tom@tromey.com>
2808
2809         * arc-tdep.c (arc_tdesc_init): Use bool.
2810
2811 2019-05-04  Tom Tromey  <tom@tromey.com>
2812
2813         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2814
2815 2019-05-04  Tom Tromey  <tom@tromey.com>
2816
2817         * cli/cli-cmds.c (valid_command_p): Return bool.
2818
2819 2019-05-04  Tom Tromey  <tom@tromey.com>
2820
2821         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2822         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2823
2824 2019-05-04  Raul Tambre  <raul@tambre.ee>
2825
2826         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2827         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2828         operator for comparison.
2829
2830 2019-05-04  Tom Tromey  <tom@tromey.com>
2831
2832         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2833         (lookup_partial_symbol, print_partial_symbols)
2834         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2835         (psymbol_compare): Update.
2836         (add_psymbol_to_bcache): Clear the entire psymbol.
2837         (maintenance_check_psymtabs): Update.
2838         * psympriv.h (struct partial_symbol): Don't derive from
2839         general_symbol_info.
2840         <obj_section, unrelocated_address, address,
2841         set_unrelocated_address>: Update.
2842         <ginfo>: New member.
2843         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2844         (debug_names::write_psymbols): Update.
2845
2846 2019-05-04  Tom de Vries  <tdevries@suse.de>
2847
2848         * contrib/cc-with-tweaks.sh: Support -n arg.
2849
2850 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2851
2852         * corelow.c (core_target::detach): Ensure frame cache and
2853         register caches are cleared.
2854         inferior.c (exit_inferior_1): Likewise.
2855
2856 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2857             Tom Tromey  <tom@tromey.com>
2858
2859         * dictionary.c (collate_pending_symbols_by_language): Remove
2860         "struct" from foreach.
2861         * symtab.c (lookup_global_symbol_from_objfile)
2862         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2863         foreach.
2864         * ser-tcp.c (net_open): Remove "struct" from foreach.
2865         * objfiles.c (objfile_relocate, objfile_rebase)
2866         (objfile_has_symbols): Remove "struct" from foreach.
2867         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2868         from foreach.
2869         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2870         foreach.
2871         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2872         "struct" from foreach.
2873         * ada-lang.c (create_excep_cond_exprs)
2874         (ada_exception_catchpoint_cond_string): Remove "struct" from
2875         foreach.
2876
2877 2019-05-03  Tom Tromey  <tromey@adacore.com>
2878
2879         * ada-exp.y (convert_char_literal): Check suffix of each
2880         enumerator.
2881
2882 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2883
2884         PR ada/21406:
2885         * ada-exp.y (yywrap): Don't define.
2886         * ada-lex.l (%option): Add noyywrap
2887         (yywrap): Remove.
2888
2889 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2890
2891         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2892         _WIN32_WINNT to the XP level, unless already defined to a higher
2893         level.
2894
2895         * unittests/parse-connection-spec-selftests.c:
2896         * ser-tcp.c:
2897         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2898         override.
2899
2900         * symfile.c (find_separate_debug_file): Remove colon from the
2901         drive spec of DOS/Windows file names of the target, so that the
2902         file name produced from DEBUGDIR and the target's directory will
2903         be valid on DOS/Windows systems.
2904
2905 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * rust-lang.c (val_print_struct): Handle printing structures
2908         containing strings.
2909
2910 2019-05-02  Tom Tromey  <tromey@adacore.com>
2911
2912         * valarith.c (_initialize_valarith): Remove.
2913
2914 2019-05-01  Tom Tromey  <tromey@adacore.com>
2915
2916         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2917         bitfields.
2918
2919 2019-05-01  Tom Tromey  <tromey@adacore.com>
2920
2921         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2922         for big-endian copies.
2923
2924 2019-04-30  Ali Tamur  <tamur@google.com>
2925         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2926         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2927         (read_3_bytes): New function.
2928
2929 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2930
2931         * windows-nat.c (main_thread_id): Delete.
2932         (handle_output_debug_string): Replace main_thread_id by
2933         current_event.dwThreadId.
2934         (fake_create_process): Likewise.
2935         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2936         Do not set main_thread_id.
2937         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2938         current_event.dwThreadId.
2939         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2940
2941 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2942
2943         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2944         Use current_event.dwThreadId instead of main_thread_id.
2945
2946 2019-04-30  Tom Tromey  <tromey@adacore.com>
2947
2948         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2949         (create_excep_cond_exprs): Iterate over program spaces.
2950         (ada_exception_catchpoint_cond_string): Examine all minimal
2951         symbols for exception types.
2952
2953 2019-04-30  Tom Tromey  <tromey@adacore.com>
2954
2955         PR c++/24470:
2956         * dwarf2read.c (process_structure_scope): Handle case where type
2957         has template parameters but no symbol was created.
2958
2959 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2960             Chris January  <chris.january@arm.com>
2961
2962         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2963         qualifier.
2964         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2965
2966 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * f-typeprint.c (f_print_type): Update rules for printing
2969         whitespace.
2970         (f_type_print_varspec_suffix): Likewise.
2971
2972 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2973             Chris January  <chris.january@arm.com>
2974
2975         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2976         function arguments.
2977
2978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * f-lang.c (build_fortran_types): Change name of void type to
2981         lower case.
2982         * f-typeprint.c (f_type_print_base): Print the name of the void
2983         type, rather than a fixed string.
2984         * f-valprint.c (f_decorations): Use lower case void string.
2985
2986 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2987             Chris January  <chris.january@arm.com>
2988
2989         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2990         types for Fortran.
2991
2992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2993             Chris January  <chris.january@arm.com>
2994             David Lecomber  <david.lecomber@arm.com>
2995
2996         * f-exp.y (BINOP_INTRINSIC): New token.
2997         (exp): New parser rule handling BINOP_INTRINSIC.
2998         (f77_keywords): Add new builtin procedures.
2999         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3000         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3001         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3002         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3003         (print_unop_subexp_f): New function.
3004         (print_binop_subexp_f): New function.
3005         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3006         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3007         (dump_subexp_body_f): Likewise.
3008         (operator_check_f): Likewise.
3009         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3010         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3011
3012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3015         UNOP_KIND.
3016         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3017         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3018         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3019         (operator_length_f): New fuction.
3020         (print_subexp_f): New function.
3021         (op_name_f): New function.
3022         (dump_subexp_body_f): New function.
3023         (operator_check_f): New function.
3024         (exp_descriptor_f): Replace standard expression handling functions
3025         with new functions.
3026         * gdb/fortran-operator.def: New file.
3027         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3028         * gdb/std-operator.def: Remove UNOP_KIND.
3029
3030 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3031
3032         * std-operator.def: Remove unbalanced, stray double quote
3033         character.
3034
3035 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3036             Chris January  <chris.january@arm.com>
3037             Daniel Everett  <daniel.everett@arm.com>
3038             Nick Forrington  <nick.forrington@arm.com>
3039             Richard Bunt  <richard.bunt@arm.com>
3040
3041         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3042         of depth when printing anonymous structs or unions.
3043         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3044         Don't print either the top-level value, or the children if the
3045         max-depth is exceeded.
3046         (ppscm_print_children): When printing the key of a map, allow one
3047         extra level of depth.
3048         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3049         print either the top-level value, or the children if the max-depth
3050         is exceeded.
3051         (print_children): When printing the key of a map, allow one extra
3052         level of depth.
3053         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3054         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3055         (user_print_options): Initialise max_depth field.
3056         (val_print_scalar_or_string_type_p): New function.
3057         (val_print): Check to see if the max depth has been reached.
3058         (val_print_check_max_depth): Define new function.
3059         (show_print_max_depth): New function.
3060         (_initialize_valprint): Add 'print max-depth' option.
3061         * valprint.h (struct value_print_options) <max_depth>: New field.
3062         (val_print_check_max_depth): Declare new function.
3063         * NEWS: Document new feature.
3064
3065 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * ada-lang.c (ada_language_defn): Initialise new field.
3068         * c-lang.c (c_is_string_type_p): New function.
3069         (c_language_defn): Initialise new field.
3070         (cplus_language_defn): Initialise new field.
3071         (asm_language_defn): Initialise new field.
3072         (minimal_language_defn): Initialise new field.
3073         * c-lang.h (c_is_string_type_p): Declare new function.
3074         * d-lang.c (d_language_defn): Initialise new field.
3075         * f-lang.c (f_is_string_type_p): New function.
3076         (f_language_defn): Initialise new field.
3077         * go-lang.c (go_is_string_type_p): New function.
3078         (go_language_defn): Initialise new field.
3079         * language.c (default_is_string_type_p): New function.
3080         (unknown_language_defn): Initialise new field.
3081         (auto_language_defn): Initialise new field.
3082         * language.h (struct language_defn) <la_is_string_type_p>: New
3083         member variable.
3084         (default_is_string_type_p): Declare new function.
3085         * m2-lang.c (m2_language_defn): Initialise new field.
3086         * objc-lang.c (objc_language_defn): Initialise new field.
3087         * opencl-lang.c (opencl_language_defn): Initialise new field.
3088         * p-lang.c (pascal_is_string_type_p): New function.
3089         (pascal_language_defn): Initialise new field.
3090         * rust-lang.c (rust_is_string_type_p): New function.
3091         (rust_language_defn): Initialise new field.
3092
3093 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3096         New field.
3097         * ada-lang.c (ada_language_defn): Initialise new field.
3098         * c-lang.c (c_language_defn): Likewise.
3099         (cplus_language_defn): Likewise.
3100         (asm_language_defn): Likewise.
3101         (minimal_language_defn): Likewise.
3102         * d-lang.c (d_language_defn): Likewise.
3103         * f-lang.c (f_language_defn): Likewise.
3104         * go-lang.c (go_language_defn): Likewise.
3105         * language.c (unknown_language_defn): Likewise.
3106         (auto_language_defn): Likewise.
3107         * m2-lang.c (m2_language_defn): Likewise.
3108         * objc-lang.c (objc_language_defn): Likewise.
3109         * opencl-lang.c (opencl_language_defn): Likewise.
3110         * p-lang.c (pascal_language_defn): Likewise.
3111         * rust-lang.c (rust_language_defn): Likewise.
3112
3113 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * ada-lang.c (ada_is_character_type): Change return type to bool.
3116         (ada_is_string_type): Likewise.
3117         * ada-lang.h (ada_is_character_type): Update declaration
3118         (ada_is_string_type): Likewise.
3119
3120 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3121
3122         Support style in 'frame|thread apply'
3123
3124         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3125         * record.c (record_start, record_stop): Update callers of
3126         execute_command_to_string with false.
3127         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3128         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3129         methods.
3130         (class string_file): New constructor with term_out parameter.
3131         Override methods term_out and can_emit_style_escape.  New member
3132         term_out.
3133         (class stdio_file): Override can_emit_style_escape.
3134         (class tee_file): Override term_out and can_emit_style_escape.
3135         * utils.h (can_emit_style_escape): Remove.
3136         * utils.c (can_emit_style_escape): Likewise.
3137         Update all callers of can_emit_style_escape (SOMESTREAM) to
3138         SOMESTREAM->can_emit_style_escape.
3139         * source-cache.c (source_cache::get_source_lines): Likewise.
3140         * stack.c (frame_apply_command_count): Call execute_command_to_string
3141         passing the term_out characteristic of the current gdb_stdout.
3142         * thread.c (thr_try_catch_cmd): Likewise.
3143         * top.c (execute_command_to_string): pass term_out parameter
3144         to construct the string_file for the command output.
3145         * ui-file.c (term_cli_styling): New function (most code moved
3146         from utils.c can_emit_style_escape).
3147         (string_file::string_file, string_file::can_emit_style_escape,
3148         stdio_file::can_emit_style_escape, tee_file::term_out,
3149         tee_file::can_emit_style_escape): New functions.
3150
3151 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3152
3153         * NEWS: Mention the new set|show may-call-functions.
3154         * infcall.c (may_call_functions_p): New variable.
3155         (show_may_call_functions_p): New function.
3156         (call_function_by_hand_dummy): Throws an error if not
3157         may-call-functions.
3158         (_initialize_infcall): Call add_setshow_boolean_cmd for
3159         may-call-functions.
3160
3161 2019-04-25  Keith Seitz  <keiths@redhat.com>
3162
3163         PR c++/24367
3164         * cp-support.c (inspect_type): Don't attempt substitutions
3165         of symbol with the same name.
3166
3167 2019-04-25  Tom Tromey  <tromey@adacore.com>
3168
3169         PR gdb/24475:
3170         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3171         static.
3172
3173 2019-04-25  Tom Tromey  <tromey@adacore.com>
3174
3175         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3176         rvalue reference.
3177         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3178         (gdb_xml_parser::parse): Use std::move.
3179         * python/python-internal.h (gdbpy_convert_exception): Take a const
3180         reference.
3181         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3182         std::move.
3183         * python/py-utils.c (gdbpy_convert_exception): Take a const
3184         reference.
3185         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3186         Use std::move.
3187         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3188         Use std::move.
3189         * mi/mi-main.c (mi_print_exception): Take a const reference.
3190         * main.c (handle_command_errors): Take a const reference.
3191         * linespec.c (parse_linespec): Use std::move.
3192         * infcall.c (run_inferior_call): Use std::move.
3193         (call_function_by_hand_dummy): Use std::move.
3194         * exec.c (try_open_exec_file): Use std::move.
3195         * exceptions.h (exception_print, exception_fprintf)
3196         (exception_print_same): Update.
3197         * exceptions.c (print_exception, exception_print)
3198         (exception_fprintf, exception_print_same): Change parameters to
3199         const reference.
3200         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3201         * common/new-op.c: Use std::move.
3202         * common/common-exceptions.h (struct gdb_exception): Add move
3203         constructor.
3204         (struct gdb_exception_error, struct gdb_exception_quit, struct
3205         gdb_quit_bad_alloc): Change constructor to move constructor.
3206         (throw_exception): Change parameter to rvalue reference.
3207         * common/common-exceptions.c (throw_exception): Take rvalue
3208         reference.
3209         * cli/cli-interp.c (safe_execute_command): Use std::move.
3210         * breakpoint.c (insert_bp_location, location_to_sals): Use
3211         std::move.
3212
3213 2019-04-25  Tom Tromey  <tromey@adacore.com>
3214
3215         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3216         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3217         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3218         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3219         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3220         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3221         guile/scm-value.c: Use unpack.
3222         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3223         gdbscm_gdb_exception.
3224         (gdbscm_throw_gdb_exception): Likewise.
3225         (struct gdbscm_gdb_exception): New.
3226         (unpack): New function.
3227         (gdbscm_wrap): Use unpack.
3228
3229 2019-04-25  Tom Tromey  <tromey@adacore.com>
3230
3231         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3232         (gdb_rl_callback_handler): Use std::move.
3233         * common/common-exceptions.h (struct gdb_exception): Add move
3234         assignment operator.
3235         (throw_exception_sjlj): Change "exception" to const reference.
3236         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3237         (throw_exception_sjlj): Change "exception" to const reference.
3238
3239 2019-04-25  Tom Tromey  <tromey@adacore.com>
3240
3241         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3242         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3243         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3244         Update.
3245         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3246         Update.
3247         * mi/mi-interp.c (mi_interp::exec): Update.
3248         * linespec.c (parse_linespec): Update.
3249         * infcall.c (run_inferior_call): Update.
3250         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3251         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3252         (gdbscm_lookup_global_symbol): Update.
3253         * guile/scm-param.c (gdbscm_parameter_value): Update.
3254         * guile/scm-frame.c (gdbscm_frame_read_register)
3255         (gdbscm_frame_read_var): Update.
3256         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3257         * exec.c (try_open_exec_file): Update.
3258         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3259         (gdb_rl_callback_handler): Update.
3260         * common/common-exceptions.h (exception_none): Don't declare.
3261         * common/common-exceptions.c (exception_none): Don't define.
3262         (struct catcher) <exception>: Update.
3263         * cli/cli-interp.c (safe_execute_command): Update.
3264         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3265
3266 2019-04-25  Ali Tamur  <tamur@google.com>
3267
3268         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3269         (read_attribute_value): Likewise.
3270         (dwarf2_read_addr_index): Update comment.
3271         (read_str_index): Add DW_FORM_strx.
3272         (dwarf2_string_attr): Likewise.
3273         (dwarf2_const_value_attr): Likewise.
3274         (dump_die_shallow): Likewise.
3275         (dwarf2_fetch_constant_bytes): Likewise.
3276         (skip_form_bytes): Likewise.
3277         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3278
3279 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3280
3281         PR corefiles/11608
3282         PR corefiles/18187
3283         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3284         OFFSET.  Verify if current mapping contains an ELF header.
3285         (linux_find_memory_regions_full): Adjust call to
3286         dump_mapping_p.
3287
3288 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3289             Kang Li <kanglictf@gmail.com>
3290
3291         PR gdb/21600
3292
3293         * dwarf2-frame.c (read_initial_length): Be consistent about using
3294         unsigned representation of length.
3295         (decode_frame_entry_1): Likewise.  Check for wraparound of
3296         end pointer as well as buffer overflow.
3297
3298 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3299
3300         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3301         "vq".
3302
3303 2019-04-24  Tom Tromey  <tromey@adacore.com>
3304
3305         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3306
3307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * s12z-tdep.c (s12z_unwind_pc): Delete.
3310         (s12z_unwind_sp): Delete.
3311         (s12z_gdbarch_init): Don't register deleted functions with
3312         gdbarch.
3313
3314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3315
3316         * rl78-tdep.c (rl78_unwind_sp): Delete.
3317         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3318
3319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3322         (xstormy16_unwind_pc): Delete.
3323         (xstormy16_dummy_id): Delete.
3324         (xstormy16_gdbarch_init): Don't register deleted functions with
3325         gdbarch.
3326
3327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         * vax-tdep.c (vax_unwind_pc): Delete.
3330         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3331
3332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3333
3334         * v850-tdep.c (v850_unwind_sp): Delete.
3335         (v850_unwind_pc): Delete.
3336         (v850_dummy_id): Delete.
3337         (v850_gdbarch_init): Don't register deleted functions with
3338         gdbarch.
3339
3340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3341
3342         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3343         (tilegx_unwind_pc): Delete.
3344         (tilegx_unwind_dummy_id): Delete.
3345         (tilegx_gdbarch_init): Don't register deleted functions with
3346         gdbarch.
3347
3348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3349
3350         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3351         (tic6x_dummy_id): Delete.
3352         (tic6x_gdbarch_init): Don't register deleted functions with
3353         gdbarch.
3354
3355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3356
3357         * sparc-tdep.c (sparc_unwind_pc): Delete.
3358         (sparc32_gdbarch_init): Don't register deleted function with
3359         gdbarch.
3360
3361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * sh-tdep.c (sh_unwind_sp): Delete.
3364         (sh_unwind_pc): Delete.
3365         (sh_dummy_id): Delete.
3366         (sh_gdbarch_init): Don't register deleted functions with
3367         gdbarch.
3368
3369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * score-tdep.c (score_unwind_sp): Delete.
3372         (score_unwind_pc): Delete.
3373         (score_dummy_id): Delete.
3374         (score_gdbarch_init): Don't register deleted functions with
3375         gdbarch.
3376
3377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3378
3379         * rx-tdep.c (rx_unwind_pc): Delete.
3380         (rx_unwind_sp): Delete.
3381         (rx_dummy_id): Delete.
3382         (rx_gdbarch_init): Don't register deleted functions with
3383         gdbarch.  Update comment.
3384
3385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3386
3387         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3388         (rs6000_dummy_id): Delete.
3389         (rs6000_gdbarch_init): Don't register deleted functions with
3390         gdbarch.
3391
3392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3393
3394         * or1k-tdep.c (or1k_dummy_id): Delete.
3395         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3396
3397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3398
3399         * nios2-tdep.c (nios2_dummy_id): Delete.
3400         (nios2_unwind_sp): Delete.
3401         (nios2_gdbarch_init): Don't register deleted functions with
3402         gdbarch.
3403
3404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3405
3406         * nds32-tdep.c (nds32_dummy_id): Delete.
3407         (nds32_unwind_pc): Delete.
3408         (nds32_unwind_sp): Delete.
3409         (nds32_gdbarch_init): Don't register deleted functions with
3410         gdbarch.
3411
3412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3413
3414         * msp430-tdep.c (msp430_unwind_pc): Delete.
3415         (msp430_unwind_sp): Delete.
3416         (msp430_dummy_id): Delete.
3417         (msp430_gdbarch_init): Don't register deleted functions with
3418         gdbarch.
3419
3420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * moxie-tdep.c (moxie_unwind_sp): Delete.
3423         (moxie_unwind_pc): Delete.
3424         (moxie_dummy_id): Delete.
3425         (moxie_gdbarch_init): Don't register deleted functions with
3426         gdbarch.
3427
3428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3429
3430         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3431         (mn10300_unwind_pc): Delete.
3432         (mn10300_unwind_sp): Delete.
3433         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3434         mn10300_unwind_sp.
3435         (mn10300_frame_unwind_init): Don't register deleted functions with
3436         gdbarch.
3437
3438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * mep-tdep.c (mep_unwind_pc): Delete.
3441         (mep_unwind_sp): Delete.
3442         (mep_dummy_id): Delete.
3443         (mep_gdbarch_init): Don't register deleted functions with
3444         gdbarch.
3445
3446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3449         (m68hc11_unwind_sp): Delete.
3450         (m68hc11_gdbarch_init): Don't register deleted functions with
3451         gdbarch.
3452
3453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3454
3455         * m32r-tdep.c (m32r_unwind_sp): Delete.
3456         (m32r_unwind_pc): Delete.
3457         (m32r_dummy_id): Delete.
3458         (m32r_gdbarch_init): Don't register deleted functions with
3459         gdbarch.
3460
3461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         * m32c-tdep.c (m32c_unwind_pc): Delete.
3464         (m32c_unwind_sp): Delete.
3465         (m32c_dummy_id): Delete.
3466         (m32c_gdbarch_init): Don't register deleted functions with
3467         gdbarch.
3468
3469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3470
3471         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3472         (lm32_unwind_pc): Delete.
3473         (lm32_dummy_id): Delete.
3474         (lm32_gdbarch_init): Don't register deleted functions with
3475         gdbarch.
3476
3477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3480         (iq2000_unwind_pc): Delete.
3481         (iq2000_dummy_id): Delete.
3482         (iq2000_gdbarch_init): Don't register deleted functions with
3483         gdbarch.
3484
3485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3486
3487         * nds32-tdep.c (nds32_type_align): Delete.
3488         (nds32_push_dummy_call): Use type_align instead.
3489
3490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3491
3492         * arm-tdep.c (arm_type_align): Only handle vector override case.
3493         (arm_push_dummy_call): Use type_align.
3494         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3495
3496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3499         case.
3500         (pass_on_stack): Use type_align.
3501         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3502         function.
3503
3504 2019-04-23  Tom Tromey  <tromey@adacore.com>
3505
3506         * dwarf2read.c (line_header::file_name_at): Remove unused
3507         overload.
3508
3509 2019-04-23  Tom de Vries  <tdevries@suse.de>
3510
3511         PR gdb/24438
3512         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3513         invocation.
3514
3515
3516 2019-03-27  Ali Tamur  <tamur@google.com>
3517
3518         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3519         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3520         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3521         (dwarf_expr_context::get_addr_index): Likewise
3522         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3523         (symbol_needs_eval_context::get_addr_index): Likewise
3524         (disassemble_dwarf_expression): Add DW_OP_addrx
3525         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3526         (read_cutu_die_from_dwo): Update comment
3527         (skip_one_die): Add DW_FORM_addrx
3528         (read_attribute_value): Likewise
3529         (var_decode_location): Add DW_OP_addrx
3530         (dwarf2_const_value_attr): Add DW_FORM_addrx
3531         (dump_die_shallow): Likewise
3532         (dwarf2_fetch_constant_bytes): Likewise
3533         (decode_locdesc): Add DW_OP_addrx
3534         (skip_form_bytes): Add DW_FORM_addrx
3535
3536 2019-04-22  Ali Tamur  <tamur@google.com>
3537
3538         * MAINTAINERS (Write After Approval): Add self.
3539
3540 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3541
3542         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3543         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3544         (open_symbol_file_object): Likewise.
3545         (svr4_default_sos): Add info parameter.
3546         (svr4_read_so_list): Likewise.
3547         (svr4_current_sos_direct): Adjust functions calls to pass down
3548         info.
3549         (svr4_current_sos_1): Add info parameter.
3550         (svr4_current_sos): Call get_svr4_info, pass info down to
3551         svr4_current_sos_1.
3552         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3553         get_svr4_info.
3554         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3555         get_svr4_info.
3556         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3557         to get_svr4_info.
3558         (probes_table_remove_objfile_probes): Likewise.
3559         (register_solib_event_probe): Add info parameter.
3560         (solist_update_incremental): Pass info parameter down to
3561         svr4_read_so_list.
3562         (disable_probes_interface): Add info parameter.
3563         (svr4_handle_solib_event): Pass current_program_space to
3564         get_svr4_info.  Adjust disable_probes_interface cleanup.
3565         (svr4_create_probe_breakpoints): Add info parameter, pass it
3566         down to register_solib_event_probe.
3567         (svr4_create_solib_event_breakpoints): Add info parameter,
3568         pass it down to svr4_create_probe_breakpoints.
3569         (enable_break): Pass info down to
3570         svr4_create_solib_event_breakpoints.
3571         (svr4_solib_create_inferior_hook): Pass current_program_space to
3572         get_svr4_info.
3573         (svr4_clear_solib): Likewise.
3574
3575 2019-04-22  Pedro Alves  <palves@redhat.com>
3576
3577         * solib-svr4.c (svr4_free_objfile_observer): New.
3578         (probe_and_action::objfile): New field.
3579         (probes_table_htab_remove_objfile_probes)
3580         (probes_table_remove_objfile_probes): New functions.
3581         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3582         in the new probe_and_action.  Don't store the probe in 'lookup'.
3583         (svr4_create_probe_breakpoints): Pass objfile to
3584         register_solib_event_probe.
3585         (_initialize_svr4_solib): Register a free_objfile observer.
3586
3587 2019-04-19  Tom Tromey  <tom@tromey.com>
3588
3589         * common/queue.h: Remove.
3590
3591 2019-04-19  Tom Tromey  <tom@tromey.com>
3592
3593         * event-loop.c: Don't include "common/queue.h".
3594
3595 2019-04-19  Tom Tromey  <tom@tromey.com>
3596
3597         * remote.c (remote_target): Use delete.
3598         * remote-notif.h: Include <list>, not "common/queue.h".
3599         (notif_client_p): Remove typedef.
3600         (remote_notif_state): Add constructor, destructor, initializer.
3601         <notif_queue>: Now a std::list.
3602         (remote_notif_state_xfree): Don't declare.
3603         * remote-notif.c (remote_notif_process, handle_notification)
3604         (remote_notif_state_allocate): Update.
3605         (~remote_notif_state): Rename from remote_notif_state_xfree.
3606
3607 2019-04-19  Tom Tromey  <tom@tromey.com>
3608
3609         * symfile.c (reread_symbols): Update.
3610         * objfiles.c (objfile_register_static_link)
3611         (objfile_lookup_static_link): Update
3612         (~objfile) Don't delete static_links.
3613         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3614
3615 2019-04-19  Tom Tromey  <tom@tromey.com>
3616
3617         * type-stack.h (struct type_stack) <insert>: Constify string.
3618         * type-stack.c (type_stack::insert): Constify string.
3619         * gdbtypes.h (lookup_template_type): Update.
3620         (address_space_name_to_int): Update.
3621         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3622         const.
3623         (lookup_template_type): Make name const.
3624         * c-exp.y: Update rules.
3625         (lex_one_token, classify_name, classify_inner_name)
3626         (c_print_token): Update.
3627         * p-exp.y: Update rules.
3628         (yylex): Update.
3629         * f-exp.y: Update rules.
3630         (yylex): Update.
3631         * d-exp.y: Update rules.
3632         (lex_one_token, classify_name, classify_inner_name): Update.
3633         * parse.c (write_dollar_variable, copy_name): Return std::string.
3634         * parser-defs.h (copy_name): Change return type.
3635         * m2-exp.y: Update rules.
3636         (yylex): Update.
3637         * go-exp.y (lex_one_token): Update.
3638         Update rules.
3639         (classify_unsafe_function, classify_packaged_name)
3640         (classify_name, yylex): Update.
3641
3642 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3643
3644         * configure.ac: add --enable-source-highlight switch.
3645         * configure: Regenerate.
3646         * top.c (print_gdb_version): plumb --enable-source-highlight
3647         status to "show configuration".
3648
3649 2019-04-19  Tom Tromey  <tromey@adacore.com>
3650
3651         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3652         Check ADA_TYPE_P.
3653         (empty_record, ada_template_to_fixed_record_type_1)
3654         (template_to_static_fixed_type)
3655         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3656         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3657         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3658         macros.
3659
3660 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3661
3662         PR symtab/24423:
3663         * source.c (print_source_lines_base): Advance "iter" when a
3664         control character is seen.
3665
3666 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3667
3668         * inferior.h (struct infcall_suspend_state_deleter):
3669         Catch exception in destructor to avoid crash.
3670
3671 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3672
3673         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3674         close to the add_com "shell".
3675
3676 2019-04-18  Tom Tromey  <tromey@adacore.com>
3677
3678         * process-stratum-target.h (class process_stratum_target)
3679         <stratum>: Add "final".
3680
3681 2019-04-17  Tom Tromey  <tromey@adacore.com>
3682
3683         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3684         against nullptr before use.
3685
3686 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3687
3688         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3689
3690 2019-04-17  Jim Wilson  <jimw@sifive.com>
3691             Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3694         code read might fail, assume 4-byte breakpoint in that case.
3695
3696 2019-04-15  Leszek Swirski  <leszeks@google.com>
3697
3698         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3699         rather than a hand-rolled POD check when checking for forced MEMORY
3700         classification.
3701
3702 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3703
3704         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3705         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3706         function.
3707         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3708         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3709         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3710         declaration.
3711
3712 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3713
3714         * aarch64-linux-nat.c
3715         (aarch64_linux_nat_target::thread_architecture): Add override.
3716         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3717         each VQ.
3718
3719 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3720
3721         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3722
3723 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3726         target types of size 96-bits, add some additional comments, and
3727         check that the builtin type we found was the correct size.
3728
3729 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3730
3731         * utils.c (prompt_for_continue): Don't restore the styling at the
3732         end, as applied_style has the wrong value.  This fixes styling in
3733         long lists of file names that are interrupted by the "Continue?"
3734         prompt.
3735
3736 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3737
3738         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3739         * c-lang.c (c_language_defn): Likewise.
3740         (cplus_language_defn): Likewise.
3741         (asm_language_defn): Likewise.
3742         (minimal_language_defn): Likewise.
3743         * d-lang.c (d_language_defn): Likewise.
3744         * f-lang.c (f_language_defn): Likewise.
3745         * go-lang.c (go_language_defn): Likewise.
3746         * language.c (unknown_language_defn): Likewise.
3747         (auto_language_defn): Likewise.
3748         * language.h (struct language_defn): Remove la_magic field.
3749         (LANG_MAGIC): Delete.
3750         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3751         * objc-lang.c (objc_language_defn): Likewise.
3752         * opencl-lang.c (opencl_language_defn): Likewise.
3753         * p-lang.c (pascal_language_defn): Likewise.
3754         * rust-lang.c (rust_language_defn): Likewise.
3755
3756 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3757
3758         * riscv-tdep.c (riscv_type_align): New function.
3759         (riscv_type_alignment): Delete.
3760         (riscv_arg_location): Use 'type_align'.
3761         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3762
3763 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * gdbtypes.c (type_align): A struct with no non-static fields also
3766         has alignment of 1.
3767
3768 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3771         component to 0.
3772         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3773         member.
3774         (riscv_struct_info::analyse): New implementation using new
3775         analyse_inner member function.
3776         (riscv_struct_info::field_offset): New member function.
3777         (riscv_struct_info::m_offsets): New member variable.
3778         (riscv_struct_info::analyse_inner): New private member function,
3779         takes the old implementation of riscv_struct_info::analyse but
3780         extended to track field offsets.
3781         (riscv_call_arg_struct): Update the struct folding special cases
3782         to handle cases where empty C++ structs, which are non-zero
3783         length, are found.
3784         (riscv_arg_location): Initialise the length of each location, a
3785         non-zero length now indicates the location is in use.
3786         (riscv_push_dummy_call): Allow for the first location having a
3787         non-zero offset when setting up arguments.
3788         (riscv_return_value): Likewise, but for return values.
3789
3790 2019-04-11  Tom Tromey  <tromey@adacore.com>
3791
3792         * utils.c (internal_vproblem): Make "msg" const.
3793
3794 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3795
3796         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3797         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3798         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3799         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3800
3801 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3802
3803         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3804         function.
3805         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3806         of amd64_collect_native_gregset.
3807         (amd64_linux_nat_target::store_registers): Likewise.
3808
3809 2019-04-10  Tom Tromey  <tom@tromey.com>
3810
3811         * symtab.c (lookup_global_symbol_from_objfile)
3812         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3813         * objfiles.h (class separate_debug_iterator): New.
3814         (class separate_debug_range): New.
3815         (struct objfile) <separate_debug_objfiles>: New method.
3816         (objfile_separate_debug_iterate): Don't declare.
3817         * objfiles.c (separate_debug_iterator::operator++): Rename from
3818         objfile_separate_debug_iterate.
3819         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3820         iterator.
3821         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3822         iterator.
3823
3824 2019-04-10  Tom Tromey  <tom@tromey.com>
3825
3826         * symfile.c (reread_symbols): Remove old comment.
3827         * objfiles.c (free_all_objfiles): Fix a typo.
3828
3829 2019-04-10  Tom Tromey  <tom@tromey.com>
3830
3831         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3832         * minsyms.c (lookup_minimal_symbol): Use foreach.
3833         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3834         (lookup_minimal_symbol_solib_trampoline): Likewise.
3835         * symfile.c (reread_symbols): Use foreach.
3836
3837 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3838             Tom Tromey  <tromey@adacore.com>
3839
3840         PR rust/24414:
3841         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3842         (rust_lex_int_test): Change "value" to be LONGEST.
3843         (rust_lex_tests): Add test for long integer literal.
3844
3845 2019-04-09  Tom Tromey  <tromey@adacore.com>
3846
3847         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3848         to bool.
3849         (extended_remote_target::attach): Update.
3850         (remote_target::remote_notice_new_inferior): Update.
3851         (remote_target::add_current_inferior_and_thread): Update.
3852         * inferior.c (exit_inferior_1): Use "false".
3853         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3854
3855 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3856
3857         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3858         the "start" command.
3859
3860 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3861
3862         * python/py-inferior.c (infpy_thread_from_thread_handle):
3863         Adjust comments to reflect renaming of thread_from_thread_handle
3864         to thread_from_handle.  Adjust keywords.  Fix type error message.
3865         (inferior_object_methods): Add thread_from_handle.  Retain
3866         thread_from_thread_handle, but mark it as deprecated.
3867
3868 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3869
3870         * gdbthread.h (find_thread_by_handle): Revise declaration.
3871         * thread.c (find_thread_by_handle): Likewise.  Adjust
3872         implementation too.
3873         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3874         support for buffer objects as handles.
3875
3876 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3877
3878         * python/py-infthread.c (thpy_thread_handle): New function.
3879         (thread_object_methods): Register thpy_thread_handle.
3880
3881 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3882
3883         * gdbthread.h (thread_to_thread_handle): Declare.
3884         * thread.c (gdbtypes.h): Include.
3885         (thread_to_thread_handle): New function.
3886
3887         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3888         (target_thread_info_to_thread_handle): Declare.
3889         * target.c (target_thread_info_to_thread_handle): New function.
3890         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3891         * target-delegates.c: Regenerate.
3892
3893         * linux-thread-db.c (class thread_db_target): Add method
3894         thread_info_to_thread_handle.
3895         (thread_db_target::thread_info_to_thread_handle): Define.
3896         * remote.c (class remote_target): Add new method
3897         thread_info_to_thread_handle.
3898         (remote_target::thread_info_to_thread_handle): Define.
3899
3900 2019-04-08  Pedro Alves  <palves@redhat.com>
3901
3902         * common/common-exceptions.c (throw_exception): Don't create
3903         named object to throw; throw directly.
3904         (throw_it): Likewise.  Don't initialize gdb_exception::message
3905         here, with new; pass FMT and AP to the ctor instead.
3906         * common/common-exceptions.h: Include <string>.
3907         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3908         const char *, va_list)): New ctor.  Use std::make_shared.
3909         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3910         errors)): Delete.
3911         (gdb_exception_error::gdb_exception_error(enum errors, const char
3912         *, va_list)): New.
3913         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3914         Add assertion.
3915         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3916         errors)): Delete.
3917         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3918         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3919         Add assertion.
3920
3921 2019-04-08  Tom Tromey  <tom@tromey.com>
3922
3923         * valops.c (value_rtti_indirect_type): Replace throw_exception
3924         with throw.
3925         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3926         with throw.
3927         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3928         throw.
3929         * target.c (target_translate_tls_address): Replace throw_exception
3930         with throw.
3931         * stack.c (frame_apply_command_count): Replace throw_exception
3932         with throw.
3933         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3934         throw.
3935         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3936         with throw.
3937         * rs6000-tdep.c (rs6000_frame_cache)
3938         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3939         * remote.c: Replace throw_exception with throw.
3940         * record-full.c (record_full_message, record_full_wait_1)
3941         (record_full_restore): Replace throw_exception with throw.
3942         * record-btrace.c:
3943         (get_thread_current_frame_id, record_btrace_start_replaying)
3944         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3945         (cmd_record_btrace_start): Replace throw_exception with throw.
3946         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3947         throw.
3948         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3949         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3950         * linespec.c:
3951         (find_linespec_symbols): Replace throw_exception with throw.
3952         * infrun.c (displaced_step_prepare, resume): Replace
3953         throw_exception with throw.
3954         * infcmd.c (post_create_inferior): Replace throw_exception with
3955         throw.
3956         * inf-loop.c (inferior_event_handler): Replace throw_exception
3957         with throw.
3958         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3959         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3960         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3961         (get_prev_frame_always, get_frame_pc_if_available)
3962         (get_frame_address_in_block_if_available, get_frame_language):
3963         Replace throw_exception with throw.
3964         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3965         throw_exception with throw.
3966         * eval.c (fetch_subexp_value, evaluate_var_value)
3967         (evaluate_funcall, evaluate_subexp_standard): Replace
3968         throw_exception with throw.
3969         * dwarf2loc.c (call_site_find_chain)
3970         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3971         Replace throw_exception with throw.
3972         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3973         with throw.
3974         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3975         throw.
3976         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3977         * completer.c (complete_line_internal): Replace throw_exception
3978         with throw.
3979         * compile/compile-object-run.c (compile_object_run): Replace
3980         throw_exception with throw.
3981         * cli/cli-script.c (process_next_line): Replace throw_exception
3982         with throw.
3983         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3984         (btrace_enable, btrace_maint_update_pt_packets): Replace
3985         throw_exception with throw.
3986         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3987         throw_exception with throw.
3988         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3989         throw_exception with throw.
3990         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3991         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3992         * aarch64-tdep.c (aarch64_make_prologue_cache)
3993         (aarch64_make_stub_cache): Replace throw_exception with throw.
3994
3995 2019-04-08  Tom Tromey  <tom@tromey.com>
3996
3997         * common/common-exceptions.c (throw_exception): Rename from
3998         throw_exception_cxx.  Remove old copy.  Make argument const.
3999         (throw_it): Create and throw exception objects directly.
4000         * common/common-exceptions.h (throw_exception): Make argument
4001         const.
4002         (struct gdb_exception_error): Add constructor.
4003         (struct gdb_exception_quit): Add constructor.
4004
4005 2019-04-08  Tom Tromey  <tom@tromey.com>
4006
4007         * common/common-exceptions.h (exception_rethrow): Don't declare.
4008         (TRY_SJLJ): Update comment.
4009         (TRY, CATCH, END_CATCH): Remove.
4010         * common/common-exceptions.c (exception_rethrow): Remove.
4011
4012 2019-04-08  Tom Tromey  <tom@tromey.com>
4013
4014         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4015         Remove.
4016         (gdb_exception_error): Rename from
4017         gdb_exception_RETURN_MASK_ERROR.
4018         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4019         (gdb_quit_bad_alloc): Update.
4020         * aarch64-tdep.c: Update.
4021         * ada-lang.c: Update.
4022         * ada-typeprint.c: Update.
4023         * ada-valprint.c: Update.
4024         * amd64-tdep.c: Update.
4025         * arch-utils.c: Update.
4026         * break-catch-throw.c: Update.
4027         * breakpoint.c: Update.
4028         * btrace.c: Update.
4029         * c-varobj.c: Update.
4030         * cli/cli-cmds.c: Update.
4031         * cli/cli-interp.c: Update.
4032         * cli/cli-script.c: Update.
4033         * common/common-exceptions.c: Update.
4034         * common/new-op.c: Update.
4035         * common/selftest.c: Update.
4036         * compile/compile-c-symbols.c: Update.
4037         * compile/compile-cplus-symbols.c: Update.
4038         * compile/compile-object-load.c: Update.
4039         * compile/compile-object-run.c: Update.
4040         * completer.c: Update.
4041         * corelow.c: Update.
4042         * cp-abi.c: Update.
4043         * cp-support.c: Update.
4044         * cp-valprint.c: Update.
4045         * darwin-nat.c: Update.
4046         * disasm-selftests.c: Update.
4047         * dtrace-probe.c: Update.
4048         * dwarf-index-cache.c: Update.
4049         * dwarf-index-write.c: Update.
4050         * dwarf2-frame-tailcall.c: Update.
4051         * dwarf2-frame.c: Update.
4052         * dwarf2loc.c: Update.
4053         * dwarf2read.c: Update.
4054         * eval.c: Update.
4055         * event-loop.c: Update.
4056         * event-top.c: Update.
4057         * exec.c: Update.
4058         * f-valprint.c: Update.
4059         * fbsd-tdep.c: Update.
4060         * frame-unwind.c: Update.
4061         * frame.c: Update.
4062         * gdbtypes.c: Update.
4063         * gnu-v3-abi.c: Update.
4064         * guile/guile-internal.h: Update.
4065         * guile/scm-block.c: Update.
4066         * guile/scm-breakpoint.c: Update.
4067         * guile/scm-cmd.c: Update.
4068         * guile/scm-disasm.c: Update.
4069         * guile/scm-frame.c: Update.
4070         * guile/scm-lazy-string.c: Update.
4071         * guile/scm-math.c: Update.
4072         * guile/scm-param.c: Update.
4073         * guile/scm-ports.c: Update.
4074         * guile/scm-pretty-print.c: Update.
4075         * guile/scm-symbol.c: Update.
4076         * guile/scm-symtab.c: Update.
4077         * guile/scm-type.c: Update.
4078         * guile/scm-value.c: Update.
4079         * i386-linux-tdep.c: Update.
4080         * i386-tdep.c: Update.
4081         * inf-loop.c: Update.
4082         * infcall.c: Update.
4083         * infcmd.c: Update.
4084         * infrun.c: Update.
4085         * jit.c: Update.
4086         * language.c: Update.
4087         * linespec.c: Update.
4088         * linux-fork.c: Update.
4089         * linux-nat.c: Update.
4090         * linux-tdep.c: Update.
4091         * linux-thread-db.c: Update.
4092         * main.c: Update.
4093         * mi/mi-cmd-break.c: Update.
4094         * mi/mi-cmd-stack.c: Update.
4095         * mi/mi-interp.c: Update.
4096         * mi/mi-main.c: Update.
4097         * objc-lang.c: Update.
4098         * p-valprint.c: Update.
4099         * parse.c: Update.
4100         * ppc-linux-tdep.c: Update.
4101         * printcmd.c: Update.
4102         * python/py-arch.c: Update.
4103         * python/py-breakpoint.c: Update.
4104         * python/py-cmd.c: Update.
4105         * python/py-finishbreakpoint.c: Update.
4106         * python/py-frame.c: Update.
4107         * python/py-framefilter.c: Update.
4108         * python/py-gdb-readline.c: Update.
4109         * python/py-inferior.c: Update.
4110         * python/py-infthread.c: Update.
4111         * python/py-lazy-string.c: Update.
4112         * python/py-linetable.c: Update.
4113         * python/py-objfile.c: Update.
4114         * python/py-param.c: Update.
4115         * python/py-prettyprint.c: Update.
4116         * python/py-progspace.c: Update.
4117         * python/py-record-btrace.c: Update.
4118         * python/py-record.c: Update.
4119         * python/py-symbol.c: Update.
4120         * python/py-type.c: Update.
4121         * python/py-unwind.c: Update.
4122         * python/py-utils.c: Update.
4123         * python/py-value.c: Update.
4124         * python/python.c: Update.
4125         * record-btrace.c: Update.
4126         * record-full.c: Update.
4127         * remote-fileio.c: Update.
4128         * remote.c: Update.
4129         * riscv-tdep.c: Update.
4130         * rs6000-aix-tdep.c: Update.
4131         * rs6000-tdep.c: Update.
4132         * rust-exp.y: Update.
4133         * rust-lang.c: Update.
4134         * s390-tdep.c: Update.
4135         * selftest-arch.c: Update.
4136         * solib-dsbt.c: Update.
4137         * solib-frv.c: Update.
4138         * solib-spu.c: Update.
4139         * solib-svr4.c: Update.
4140         * solib.c: Update.
4141         * sparc64-linux-tdep.c: Update.
4142         * stack.c: Update.
4143         * symfile-mem.c: Update.
4144         * symmisc.c: Update.
4145         * target.c: Update.
4146         * thread.c: Update.
4147         * top.c: Update.
4148         * tracefile-tfile.c: Update.
4149         * tui/tui.c: Update.
4150         * typeprint.c: Update.
4151         * unittests/cli-utils-selftests.c: Update.
4152         * unittests/parse-connection-spec-selftests.c: Update.
4153         * valops.c: Update.
4154         * valprint.c: Update.
4155         * value.c: Update.
4156         * varobj.c: Update.
4157         * windows-nat.c: Update.
4158         * x86-linux-nat.c: Update.
4159         * xml-support.c: Update.
4160
4161 2019-04-08  Tom Tromey  <tom@tromey.com>
4162
4163         * xml-support.c: Use C++ exception handling.
4164         * x86-linux-nat.c: Use C++ exception handling.
4165         * windows-nat.c: Use C++ exception handling.
4166         * varobj.c: Use C++ exception handling.
4167         * value.c: Use C++ exception handling.
4168         * valprint.c: Use C++ exception handling.
4169         * valops.c: Use C++ exception handling.
4170         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4171         handling.
4172         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4173         * typeprint.c: Use C++ exception handling.
4174         * tui/tui.c: Use C++ exception handling.
4175         * tracefile-tfile.c: Use C++ exception handling.
4176         * top.c: Use C++ exception handling.
4177         * thread.c: Use C++ exception handling.
4178         * target.c: Use C++ exception handling.
4179         * symmisc.c: Use C++ exception handling.
4180         * symfile-mem.c: Use C++ exception handling.
4181         * stack.c: Use C++ exception handling.
4182         * sparc64-linux-tdep.c: Use C++ exception handling.
4183         * solib.c: Use C++ exception handling.
4184         * solib-svr4.c: Use C++ exception handling.
4185         * solib-spu.c: Use C++ exception handling.
4186         * solib-frv.c: Use C++ exception handling.
4187         * solib-dsbt.c: Use C++ exception handling.
4188         * selftest-arch.c: Use C++ exception handling.
4189         * s390-tdep.c: Use C++ exception handling.
4190         * rust-lang.c: Use C++ exception handling.
4191         * rust-exp.y: Use C++ exception handling.
4192         * rs6000-tdep.c: Use C++ exception handling.
4193         * rs6000-aix-tdep.c: Use C++ exception handling.
4194         * riscv-tdep.c: Use C++ exception handling.
4195         * remote.c: Use C++ exception handling.
4196         * remote-fileio.c: Use C++ exception handling.
4197         * record-full.c: Use C++ exception handling.
4198         * record-btrace.c: Use C++ exception handling.
4199         * python/python.c: Use C++ exception handling.
4200         * python/py-value.c: Use C++ exception handling.
4201         * python/py-utils.c: Use C++ exception handling.
4202         * python/py-unwind.c: Use C++ exception handling.
4203         * python/py-type.c: Use C++ exception handling.
4204         * python/py-symbol.c: Use C++ exception handling.
4205         * python/py-record.c: Use C++ exception handling.
4206         * python/py-record-btrace.c: Use C++ exception handling.
4207         * python/py-progspace.c: Use C++ exception handling.
4208         * python/py-prettyprint.c: Use C++ exception handling.
4209         * python/py-param.c: Use C++ exception handling.
4210         * python/py-objfile.c: Use C++ exception handling.
4211         * python/py-linetable.c: Use C++ exception handling.
4212         * python/py-lazy-string.c: Use C++ exception handling.
4213         * python/py-infthread.c: Use C++ exception handling.
4214         * python/py-inferior.c: Use C++ exception handling.
4215         * python/py-gdb-readline.c: Use C++ exception handling.
4216         * python/py-framefilter.c: Use C++ exception handling.
4217         * python/py-frame.c: Use C++ exception handling.
4218         * python/py-finishbreakpoint.c: Use C++ exception handling.
4219         * python/py-cmd.c: Use C++ exception handling.
4220         * python/py-breakpoint.c: Use C++ exception handling.
4221         * python/py-arch.c: Use C++ exception handling.
4222         * printcmd.c: Use C++ exception handling.
4223         * ppc-linux-tdep.c: Use C++ exception handling.
4224         * parse.c: Use C++ exception handling.
4225         * p-valprint.c: Use C++ exception handling.
4226         * objc-lang.c: Use C++ exception handling.
4227         * mi/mi-main.c: Use C++ exception handling.
4228         * mi/mi-interp.c: Use C++ exception handling.
4229         * mi/mi-cmd-stack.c: Use C++ exception handling.
4230         * mi/mi-cmd-break.c: Use C++ exception handling.
4231         * main.c: Use C++ exception handling.
4232         * linux-thread-db.c: Use C++ exception handling.
4233         * linux-tdep.c: Use C++ exception handling.
4234         * linux-nat.c: Use C++ exception handling.
4235         * linux-fork.c: Use C++ exception handling.
4236         * linespec.c: Use C++ exception handling.
4237         * language.c: Use C++ exception handling.
4238         * jit.c: Use C++ exception handling.
4239         * infrun.c: Use C++ exception handling.
4240         * infcmd.c: Use C++ exception handling.
4241         * infcall.c: Use C++ exception handling.
4242         * inf-loop.c: Use C++ exception handling.
4243         * i386-tdep.c: Use C++ exception handling.
4244         * i386-linux-tdep.c: Use C++ exception handling.
4245         * guile/scm-value.c: Use C++ exception handling.
4246         * guile/scm-type.c: Use C++ exception handling.
4247         * guile/scm-symtab.c: Use C++ exception handling.
4248         * guile/scm-symbol.c: Use C++ exception handling.
4249         * guile/scm-pretty-print.c: Use C++ exception handling.
4250         * guile/scm-ports.c: Use C++ exception handling.
4251         * guile/scm-param.c: Use C++ exception handling.
4252         * guile/scm-math.c: Use C++ exception handling.
4253         * guile/scm-lazy-string.c: Use C++ exception handling.
4254         * guile/scm-frame.c: Use C++ exception handling.
4255         * guile/scm-disasm.c: Use C++ exception handling.
4256         * guile/scm-cmd.c: Use C++ exception handling.
4257         * guile/scm-breakpoint.c: Use C++ exception handling.
4258         * guile/scm-block.c: Use C++ exception handling.
4259         * guile/guile-internal.h: Use C++ exception handling.
4260         * gnu-v3-abi.c: Use C++ exception handling.
4261         * gdbtypes.c: Use C++ exception handling.
4262         * frame.c: Use C++ exception handling.
4263         * frame-unwind.c: Use C++ exception handling.
4264         * fbsd-tdep.c: Use C++ exception handling.
4265         * f-valprint.c: Use C++ exception handling.
4266         * exec.c: Use C++ exception handling.
4267         * event-top.c: Use C++ exception handling.
4268         * event-loop.c: Use C++ exception handling.
4269         * eval.c: Use C++ exception handling.
4270         * dwarf2read.c: Use C++ exception handling.
4271         * dwarf2loc.c: Use C++ exception handling.
4272         * dwarf2-frame.c: Use C++ exception handling.
4273         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4274         * dwarf-index-write.c: Use C++ exception handling.
4275         * dwarf-index-cache.c: Use C++ exception handling.
4276         * dtrace-probe.c: Use C++ exception handling.
4277         * disasm-selftests.c: Use C++ exception handling.
4278         * darwin-nat.c: Use C++ exception handling.
4279         * cp-valprint.c: Use C++ exception handling.
4280         * cp-support.c: Use C++ exception handling.
4281         * cp-abi.c: Use C++ exception handling.
4282         * corelow.c: Use C++ exception handling.
4283         * completer.c: Use C++ exception handling.
4284         * compile/compile-object-run.c: Use C++ exception handling.
4285         * compile/compile-object-load.c: Use C++ exception handling.
4286         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4287         * compile/compile-c-symbols.c: Use C++ exception handling.
4288         * common/selftest.c: Use C++ exception handling.
4289         * common/new-op.c: Use C++ exception handling.
4290         * cli/cli-script.c: Use C++ exception handling.
4291         * cli/cli-interp.c: Use C++ exception handling.
4292         * cli/cli-cmds.c: Use C++ exception handling.
4293         * c-varobj.c: Use C++ exception handling.
4294         * btrace.c: Use C++ exception handling.
4295         * breakpoint.c: Use C++ exception handling.
4296         * break-catch-throw.c: Use C++ exception handling.
4297         * arch-utils.c: Use C++ exception handling.
4298         * amd64-tdep.c: Use C++ exception handling.
4299         * ada-valprint.c: Use C++ exception handling.
4300         * ada-typeprint.c: Use C++ exception handling.
4301         * ada-lang.c: Use C++ exception handling.
4302         * aarch64-tdep.c: Use C++ exception handling.
4303
4304 2019-04-08  Tom Tromey  <tom@tromey.com>
4305
4306         * xml-support.c (gdb_xml_parser::parse): Update.
4307         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4308         * value.c (show_convenience): Update.
4309         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4310         (test_parse_flags_qcs): Update.
4311         * thread.c (thr_try_catch_cmd): Update.
4312         * target.c (target_translate_tls_address): Update.
4313         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4314         (info_frame_command_core, frame_apply_command_count): Update.
4315         * rust-exp.y (rust_lex_exception_test): Update.
4316         * riscv-tdep.c (riscv_print_one_register_info): Update.
4317         * remote.c (remote_target::enable_btrace): Update.
4318         * record-btrace.c (record_btrace_enable_warn): Update.
4319         * python/py-utils.c (gdbpy_convert_exception): Update.
4320         * printcmd.c (do_one_display, print_variable_and_value): Update.
4321         * mi/mi-main.c (mi_print_exception): Update.
4322         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4323         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4324         * linux-nat.c (linux_nat_target::attach): Update.
4325         * linux-fork.c (class scoped_switch_fork_info): Update.
4326         * infrun.c (displaced_step_prepare): Update.
4327         * infcall.c (call_function_by_hand_dummy): Update.
4328         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4329         * gnu-v3-abi.c (print_one_vtable): Update.
4330         * frame.c (get_prev_frame_always): Update.
4331         * f-valprint.c (info_common_command_for_block): Update.
4332         * exec.c (try_open_exec_file): Update.
4333         * exceptions.c (print_exception, exception_print)
4334         (exception_fprintf, exception_print_same): Update.
4335         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4336         * dwarf-index-cache.c (index_cache::store)
4337         (index_cache::lookup_gdb_index): Update.
4338         * darwin-nat.c (maybe_cache_shell): Update.
4339         * cp-valprint.c (cp_print_value_fields): Update.
4340         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4341         (gcc_cplus_symbol_address): Update.
4342         * compile/compile-c-symbols.c (gcc_convert_symbol)
4343         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4344         * common/selftest.c: Update.
4345         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4346         a std::string.
4347         (exception_try_scope_entry, exception_try_scope_exit): Don't
4348         declare.
4349         (struct exception_try_scope): Remove.
4350         (TRY): Don't use exception_try_scope.
4351         (struct gdb_exception): Add constructor, operator=.
4352         <what>: New method.
4353         (struct gdb_exception_RETURN_MASK_ALL)
4354         (struct gdb_exception_RETURN_MASK_ERROR)
4355         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4356         (struct gdb_quit_bad_alloc): Update.
4357         * common/common-exceptions.c (exception_none): Change
4358         initializer.
4359         (struct catcher) <state, exception>: Initialize inline.
4360         <prev>: Remove member.
4361         (current_catcher): Remove.
4362         (catchers): New global.
4363         (exceptions_state_mc_init): Simplify.
4364         (catcher_pop): Remove.
4365         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4366         (try_scope_depth, exception_try_scope_entry)
4367         (exception_try_scope_exit): Remove.
4368         (throw_exception_sjlj): Update.
4369         (exception_messages, exception_messages_size): Remove.
4370         (throw_it): Simplify.
4371         (gdb_exception_sliced_copy): Remove.
4372         (throw_exception_cxx): Update.
4373         * cli/cli-script.c (script_from_file): Update.
4374         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4375         Update.
4376         * ada-valprint.c (ada_val_print): Update.
4377         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4378         (create_excep_cond_exprs): Update.
4379
4380 2019-04-08  Tom Tromey  <tom@tromey.com>
4381
4382         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4383         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4384         (TRY, CATCH, END_CATCH): Remove some definitions.
4385         * common/common-exceptions.c: Don't use GDB_XCPT.
4386         (catcher_list_size): Remove.
4387         (throw_exception, throw_it): Simplify.
4388
4389 2019-04-05  Tom Tromey  <tom@tromey.com>
4390
4391         Revert the header-sorting patch.
4392         * ft32-tdep.c: Revert.
4393         * frv-tdep.c: Revert.
4394         * frv-linux-tdep.c: Revert.
4395         * frame.c: Revert.
4396         * frame-unwind.c: Revert.
4397         * frame-base.c: Revert.
4398         * fork-child.c: Revert.
4399         * findvar.c: Revert.
4400         * findcmd.c: Revert.
4401         * filesystem.c: Revert.
4402         * filename-seen-cache.h: Revert.
4403         * filename-seen-cache.c: Revert.
4404         * fbsd-tdep.c: Revert.
4405         * fbsd-nat.h: Revert.
4406         * fbsd-nat.c: Revert.
4407         * f-valprint.c: Revert.
4408         * f-typeprint.c: Revert.
4409         * f-lang.c: Revert.
4410         * extension.h: Revert.
4411         * extension.c: Revert.
4412         * extension-priv.h: Revert.
4413         * expprint.c: Revert.
4414         * exec.h: Revert.
4415         * exec.c: Revert.
4416         * exceptions.c: Revert.
4417         * event-top.c: Revert.
4418         * event-loop.c: Revert.
4419         * eval.c: Revert.
4420         * elfread.c: Revert.
4421         * dwarf2read.h: Revert.
4422         * dwarf2read.c: Revert.
4423         * dwarf2loc.c: Revert.
4424         * dwarf2expr.h: Revert.
4425         * dwarf2expr.c: Revert.
4426         * dwarf2-frame.c: Revert.
4427         * dwarf2-frame-tailcall.c: Revert.
4428         * dwarf-index-write.h: Revert.
4429         * dwarf-index-write.c: Revert.
4430         * dwarf-index-common.c: Revert.
4431         * dwarf-index-cache.h: Revert.
4432         * dwarf-index-cache.c: Revert.
4433         * dummy-frame.c: Revert.
4434         * dtrace-probe.c: Revert.
4435         * disasm.h: Revert.
4436         * disasm.c: Revert.
4437         * disasm-selftests.c: Revert.
4438         * dictionary.c: Revert.
4439         * dicos-tdep.c: Revert.
4440         * demangle.c: Revert.
4441         * dcache.h: Revert.
4442         * dcache.c: Revert.
4443         * darwin-nat.h: Revert.
4444         * darwin-nat.c: Revert.
4445         * darwin-nat-info.c: Revert.
4446         * d-valprint.c: Revert.
4447         * d-namespace.c: Revert.
4448         * d-lang.c: Revert.
4449         * ctf.c: Revert.
4450         * csky-tdep.c: Revert.
4451         * csky-linux-tdep.c: Revert.
4452         * cris-tdep.c: Revert.
4453         * cris-linux-tdep.c: Revert.
4454         * cp-valprint.c: Revert.
4455         * cp-support.c: Revert.
4456         * cp-namespace.c: Revert.
4457         * cp-abi.c: Revert.
4458         * corelow.c: Revert.
4459         * corefile.c: Revert.
4460         * continuations.c: Revert.
4461         * completer.h: Revert.
4462         * completer.c: Revert.
4463         * complaints.c: Revert.
4464         * coffread.c: Revert.
4465         * coff-pe-read.c: Revert.
4466         * cli-out.h: Revert.
4467         * cli-out.c: Revert.
4468         * charset.c: Revert.
4469         * c-varobj.c: Revert.
4470         * c-valprint.c: Revert.
4471         * c-typeprint.c: Revert.
4472         * c-lang.c: Revert.
4473         * buildsym.c: Revert.
4474         * buildsym-legacy.c: Revert.
4475         * build-id.h: Revert.
4476         * build-id.c: Revert.
4477         * btrace.c: Revert.
4478         * bsd-uthread.c: Revert.
4479         * breakpoint.h: Revert.
4480         * breakpoint.c: Revert.
4481         * break-catch-throw.c: Revert.
4482         * break-catch-syscall.c: Revert.
4483         * break-catch-sig.c: Revert.
4484         * blockframe.c: Revert.
4485         * block.c: Revert.
4486         * bfin-tdep.c: Revert.
4487         * bfin-linux-tdep.c: Revert.
4488         * bfd-target.c: Revert.
4489         * bcache.c: Revert.
4490         * ax-general.c: Revert.
4491         * ax-gdb.h: Revert.
4492         * ax-gdb.c: Revert.
4493         * avr-tdep.c: Revert.
4494         * auxv.c: Revert.
4495         * auto-load.c: Revert.
4496         * arm-wince-tdep.c: Revert.
4497         * arm-tdep.c: Revert.
4498         * arm-symbian-tdep.c: Revert.
4499         * arm-pikeos-tdep.c: Revert.
4500         * arm-obsd-tdep.c: Revert.
4501         * arm-nbsd-tdep.c: Revert.
4502         * arm-nbsd-nat.c: Revert.
4503         * arm-linux-tdep.c: Revert.
4504         * arm-linux-nat.c: Revert.
4505         * arm-fbsd-tdep.c: Revert.
4506         * arm-fbsd-nat.c: Revert.
4507         * arm-bsd-tdep.c: Revert.
4508         * arch-utils.c: Revert.
4509         * arc-tdep.c: Revert.
4510         * arc-newlib-tdep.c: Revert.
4511         * annotate.h: Revert.
4512         * annotate.c: Revert.
4513         * amd64-windows-tdep.c: Revert.
4514         * amd64-windows-nat.c: Revert.
4515         * amd64-tdep.c: Revert.
4516         * amd64-sol2-tdep.c: Revert.
4517         * amd64-obsd-tdep.c: Revert.
4518         * amd64-obsd-nat.c: Revert.
4519         * amd64-nbsd-tdep.c: Revert.
4520         * amd64-nbsd-nat.c: Revert.
4521         * amd64-nat.c: Revert.
4522         * amd64-linux-tdep.c: Revert.
4523         * amd64-linux-nat.c: Revert.
4524         * amd64-fbsd-tdep.c: Revert.
4525         * amd64-fbsd-nat.c: Revert.
4526         * amd64-dicos-tdep.c: Revert.
4527         * amd64-darwin-tdep.c: Revert.
4528         * amd64-bsd-nat.c: Revert.
4529         * alpha-tdep.c: Revert.
4530         * alpha-obsd-tdep.c: Revert.
4531         * alpha-nbsd-tdep.c: Revert.
4532         * alpha-mdebug-tdep.c: Revert.
4533         * alpha-linux-tdep.c: Revert.
4534         * alpha-linux-nat.c: Revert.
4535         * alpha-bsd-tdep.c: Revert.
4536         * alpha-bsd-nat.c: Revert.
4537         * aix-thread.c: Revert.
4538         * agent.c: Revert.
4539         * addrmap.c: Revert.
4540         * ada-varobj.c: Revert.
4541         * ada-valprint.c: Revert.
4542         * ada-typeprint.c: Revert.
4543         * ada-tasks.c: Revert.
4544         * ada-lang.c: Revert.
4545         * aarch64-tdep.c: Revert.
4546         * aarch64-ravenscar-thread.c: Revert.
4547         * aarch64-newlib-tdep.c: Revert.
4548         * aarch64-linux-tdep.c: Revert.
4549         * aarch64-linux-nat.c: Revert.
4550         * aarch64-fbsd-tdep.c: Revert.
4551         * aarch64-fbsd-nat.c: Revert.
4552         * aarch32-linux-nat.c: Revert.
4553
4554 2019-04-05  Tom Tromey  <tom@tromey.com>
4555
4556         * ft32-tdep.c: Sort headers.
4557         * frv-tdep.c: Sort headers.
4558         * frv-linux-tdep.c: Sort headers.
4559         * frame.c: Sort headers.
4560         * frame-unwind.c: Sort headers.
4561         * frame-base.c: Sort headers.
4562         * fork-child.c: Sort headers.
4563         * findvar.c: Sort headers.
4564         * findcmd.c: Sort headers.
4565         * filesystem.c: Sort headers.
4566         * filename-seen-cache.h: Sort headers.
4567         * filename-seen-cache.c: Sort headers.
4568         * fbsd-tdep.c: Sort headers.
4569         * fbsd-nat.h: Sort headers.
4570         * fbsd-nat.c: Sort headers.
4571         * f-valprint.c: Sort headers.
4572         * f-typeprint.c: Sort headers.
4573         * f-lang.c: Sort headers.
4574         * extension.h: Sort headers.
4575         * extension.c: Sort headers.
4576         * extension-priv.h: Sort headers.
4577         * expprint.c: Sort headers.
4578         * exec.h: Sort headers.
4579         * exec.c: Sort headers.
4580         * exceptions.c: Sort headers.
4581         * event-top.c: Sort headers.
4582         * event-loop.c: Sort headers.
4583         * eval.c: Sort headers.
4584         * elfread.c: Sort headers.
4585         * dwarf2read.h: Sort headers.
4586         * dwarf2read.c: Sort headers.
4587         * dwarf2loc.c: Sort headers.
4588         * dwarf2expr.h: Sort headers.
4589         * dwarf2expr.c: Sort headers.
4590         * dwarf2-frame.c: Sort headers.
4591         * dwarf2-frame-tailcall.c: Sort headers.
4592         * dwarf-index-write.h: Sort headers.
4593         * dwarf-index-write.c: Sort headers.
4594         * dwarf-index-common.c: Sort headers.
4595         * dwarf-index-cache.h: Sort headers.
4596         * dwarf-index-cache.c: Sort headers.
4597         * dummy-frame.c: Sort headers.
4598         * dtrace-probe.c: Sort headers.
4599         * disasm.h: Sort headers.
4600         * disasm.c: Sort headers.
4601         * disasm-selftests.c: Sort headers.
4602         * dictionary.c: Sort headers.
4603         * dicos-tdep.c: Sort headers.
4604         * demangle.c: Sort headers.
4605         * dcache.h: Sort headers.
4606         * dcache.c: Sort headers.
4607         * darwin-nat.h: Sort headers.
4608         * darwin-nat.c: Sort headers.
4609         * darwin-nat-info.c: Sort headers.
4610         * d-valprint.c: Sort headers.
4611         * d-namespace.c: Sort headers.
4612         * d-lang.c: Sort headers.
4613         * ctf.c: Sort headers.
4614         * csky-tdep.c: Sort headers.
4615         * csky-linux-tdep.c: Sort headers.
4616         * cris-tdep.c: Sort headers.
4617         * cris-linux-tdep.c: Sort headers.
4618         * cp-valprint.c: Sort headers.
4619         * cp-support.c: Sort headers.
4620         * cp-namespace.c: Sort headers.
4621         * cp-abi.c: Sort headers.
4622         * corelow.c: Sort headers.
4623         * corefile.c: Sort headers.
4624         * continuations.c: Sort headers.
4625         * completer.h: Sort headers.
4626         * completer.c: Sort headers.
4627         * complaints.c: Sort headers.
4628         * coffread.c: Sort headers.
4629         * coff-pe-read.c: Sort headers.
4630         * cli-out.h: Sort headers.
4631         * cli-out.c: Sort headers.
4632         * charset.c: Sort headers.
4633         * c-varobj.c: Sort headers.
4634         * c-valprint.c: Sort headers.
4635         * c-typeprint.c: Sort headers.
4636         * c-lang.c: Sort headers.
4637         * buildsym.c: Sort headers.
4638         * buildsym-legacy.c: Sort headers.
4639         * build-id.h: Sort headers.
4640         * build-id.c: Sort headers.
4641         * btrace.c: Sort headers.
4642         * bsd-uthread.c: Sort headers.
4643         * breakpoint.h: Sort headers.
4644         * breakpoint.c: Sort headers.
4645         * break-catch-throw.c: Sort headers.
4646         * break-catch-syscall.c: Sort headers.
4647         * break-catch-sig.c: Sort headers.
4648         * blockframe.c: Sort headers.
4649         * block.c: Sort headers.
4650         * bfin-tdep.c: Sort headers.
4651         * bfin-linux-tdep.c: Sort headers.
4652         * bfd-target.c: Sort headers.
4653         * bcache.c: Sort headers.
4654         * ax-general.c: Sort headers.
4655         * ax-gdb.h: Sort headers.
4656         * ax-gdb.c: Sort headers.
4657         * avr-tdep.c: Sort headers.
4658         * auxv.c: Sort headers.
4659         * auto-load.c: Sort headers.
4660         * arm-wince-tdep.c: Sort headers.
4661         * arm-tdep.c: Sort headers.
4662         * arm-symbian-tdep.c: Sort headers.
4663         * arm-pikeos-tdep.c: Sort headers.
4664         * arm-obsd-tdep.c: Sort headers.
4665         * arm-nbsd-tdep.c: Sort headers.
4666         * arm-nbsd-nat.c: Sort headers.
4667         * arm-linux-tdep.c: Sort headers.
4668         * arm-linux-nat.c: Sort headers.
4669         * arm-fbsd-tdep.c: Sort headers.
4670         * arm-fbsd-nat.c: Sort headers.
4671         * arm-bsd-tdep.c: Sort headers.
4672         * arch-utils.c: Sort headers.
4673         * arc-tdep.c: Sort headers.
4674         * arc-newlib-tdep.c: Sort headers.
4675         * annotate.h: Sort headers.
4676         * annotate.c: Sort headers.
4677         * amd64-windows-tdep.c: Sort headers.
4678         * amd64-windows-nat.c: Sort headers.
4679         * amd64-tdep.c: Sort headers.
4680         * amd64-sol2-tdep.c: Sort headers.
4681         * amd64-obsd-tdep.c: Sort headers.
4682         * amd64-obsd-nat.c: Sort headers.
4683         * amd64-nbsd-tdep.c: Sort headers.
4684         * amd64-nbsd-nat.c: Sort headers.
4685         * amd64-nat.c: Sort headers.
4686         * amd64-linux-tdep.c: Sort headers.
4687         * amd64-linux-nat.c: Sort headers.
4688         * amd64-fbsd-tdep.c: Sort headers.
4689         * amd64-fbsd-nat.c: Sort headers.
4690         * amd64-dicos-tdep.c: Sort headers.
4691         * amd64-darwin-tdep.c: Sort headers.
4692         * amd64-bsd-nat.c: Sort headers.
4693         * alpha-tdep.c: Sort headers.
4694         * alpha-obsd-tdep.c: Sort headers.
4695         * alpha-nbsd-tdep.c: Sort headers.
4696         * alpha-mdebug-tdep.c: Sort headers.
4697         * alpha-linux-tdep.c: Sort headers.
4698         * alpha-linux-nat.c: Sort headers.
4699         * alpha-bsd-tdep.c: Sort headers.
4700         * alpha-bsd-nat.c: Sort headers.
4701         * aix-thread.c: Sort headers.
4702         * agent.c: Sort headers.
4703         * addrmap.c: Sort headers.
4704         * ada-varobj.c: Sort headers.
4705         * ada-valprint.c: Sort headers.
4706         * ada-typeprint.c: Sort headers.
4707         * ada-tasks.c: Sort headers.
4708         * ada-lang.c: Sort headers.
4709         * aarch64-tdep.c: Sort headers.
4710         * aarch64-ravenscar-thread.c: Sort headers.
4711         * aarch64-newlib-tdep.c: Sort headers.
4712         * aarch64-linux-tdep.c: Sort headers.
4713         * aarch64-linux-nat.c: Sort headers.
4714         * aarch64-fbsd-tdep.c: Sort headers.
4715         * aarch64-fbsd-nat.c: Sort headers.
4716         * aarch32-linux-nat.c: Sort headers.
4717
4718 2019-04-04  Tom Tromey  <tom@tromey.com>
4719
4720         * varobj.c (varobj_create): Update.
4721         * rust-exp.y (struct rust_parser) <update_innermost_block,
4722         lookup_symbol>: New methods.
4723         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4724         Rename.
4725         (rust_parser::rust_lookup_type)
4726         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4727         * printcmd.c (display_command, do_one_display): Update.
4728         * parser-defs.h (struct parser_state) <parser_state>: Add
4729         "tracker" parameter.
4730         (block_tracker): New member.
4731         (class innermost_block_tracker) <innermost_block_tracker>: Add
4732         "types" parameter.
4733         <reset>: Remove method.
4734         (innermost_block): Don't declare.
4735         (null_post_parser): Update.
4736         * parse.c (innermost_block): Remove global.
4737         (write_dollar_variable): Update.
4738         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4739         Remove "tracker_types" parameter.
4740         (parse_expression): Add "tracker" parameter.
4741         (parse_expression_for_completion): Update.
4742         (null_post_parser): Add "tracker" parameter.
4743         * p-exp.y: Update rules.
4744         * m2-exp.y: Update rules.
4745         * language.h (struct language_defn) <la_post_parser>: Add
4746         "tracker" parameter.
4747         * go-exp.y: Update rules.
4748         * f-exp.y: Update rules.
4749         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4750         parameter.
4751         * d-exp.y: Update rules.
4752         * c-exp.y: Update rules.
4753         * breakpoint.c (set_breakpoint_condition): Create an
4754         innermost_block_tracker.
4755         (watch_command_1): Likewise.
4756         * ada-lang.c (resolve): Add "tracker" parameter.
4757         (resolve_subexp): Likewise.
4758         * ada-exp.y (write_var_from_sym): Update.
4759
4760 2019-04-04  Tom Tromey  <tom@tromey.com>
4761
4762         * type-stack.h: New file.
4763         * type-stack.c: New file.
4764         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4765         type-stack.h.
4766         (insert_into_type_stack, insert_type, push_type, push_type_int)
4767         (insert_type_address_space, pop_type, pop_type_int)
4768         (pop_typelist, pop_type_stack, append_type_stack)
4769         (push_type_stack, get_type_stack, push_typelist)
4770         (follow_type_instance_flags, follow_types): Don't declare.
4771         * parse.c (type_stack): Remove global.
4772         (parse_exp_in_context): Update.
4773         (insert_into_type_stack, insert_type, push_type, push_type_int)
4774         (insert_type_address_space, pop_type, pop_type_int)
4775         (pop_typelist, pop_type_stack, append_type_stack)
4776         (push_type_stack, get_type_stack, push_typelist)
4777         (follow_type_instance_flags, follow_types): Remove (moved to
4778         type-stack.c).
4779         * f-exp.y (type_stack): New global.
4780         Update rules.
4781         (push_kind_type, f_parse): Update.
4782         * d-exp.y (type_stack): New global.
4783         Update rules.
4784         (d_parse): Update.
4785         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4786         Update rules.
4787         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4788         (HFILES_NO_SRCDIR): Add type-stack.h.
4789
4790 2019-04-04  Tom Tromey  <tom@tromey.com>
4791
4792         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4793         (rust_parser::convert_ast_to_expression, rust_parse)
4794         (rust_lex_test_completion, rust_lex_tests): Update.
4795         * parser-defs.h (struct expr_completion_state): New.
4796         (struct parser_state) <parser_state>: Add completion parameter.
4797         <mark_struct_expression, mark_completion_tag>: New methods.
4798         <parse_completion, m_completion_state>: New members.
4799         (prefixify_expression, null_post_parser): Update.
4800         (mark_struct_expression, mark_completion_tag): Don't declare.
4801         * parse.c (parse_completion, expout_last_struct)
4802         (expout_tag_completion_type, expout_completion_name): Remove
4803         globals.
4804         (parser_state::mark_struct_expression)
4805         (parser_state::mark_completion_tag): Now methods.
4806         (prefixify_expression): Add last_struct parameter.
4807         (prefixify_subexp): Likewise.
4808         (parse_exp_1): Update.
4809         (parse_exp_in_context): Add cstate parameter.  Update.
4810         (parse_expression_for_completion): Create an
4811         expr_completion_state.
4812         (null_post_parser): Add "completion" parameter.
4813         * p-exp.y: Update rules.
4814         (yylex): Update.
4815         * language.h (struct language_defn) <la_post_parser>: Add
4816         "completing" parameter.
4817         * go-exp.y: Update rules.
4818         (lex_one_token): Update.
4819         * expression.h (parse_completion): Don't declare.
4820         * d-exp.y: Update rules.
4821         (lex_one_token): Update rules.
4822         * c-exp.y: Update rules.
4823         (lex_one_token): Update.
4824         * ada-lang.c (resolve): Add "parse_completion" parameter.
4825         (resolve_subexp): Likewise.
4826         (ada_resolve_function): Likewise.
4827
4828 2019-04-04  Tom Tromey  <tom@tromey.com>
4829
4830         * parser-defs.h (struct parser_state) <start_arglist,
4831         end_arglist>: New methods.
4832         <arglist_len, m_funcall_chain>: New members.
4833         (arglist_len, start_arglist, end_arglist): Don't declare.
4834         * parse.c (arglist_len, funcall_chain): Remove global.
4835         (start_arglist, end_arglist): Remove functions.
4836         (parse_exp_in_context): Update.
4837         * p-exp.y: Update rules.
4838         * m2-exp.y: Update rules.
4839         * go-exp.y: Update rules.
4840         * f-exp.y: Update rules.
4841         * d-exp.y: Update rules.
4842         * c-exp.y: Update rules.
4843
4844 2019-04-04  Tom Tromey  <tom@tromey.com>
4845
4846         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4847         lex_operator, push_back>: New methods.
4848         Update all rules.
4849         (rust_parser::lex_hex, lex_escape): Rename and update.
4850         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4851         (rust_parser::lex_operator): Rename and update.
4852         (rust_parser::lex_number, rustyylex, rustyyerror)
4853         (rust_lex_test_init, rust_lex_test_sequence)
4854         (rust_lex_test_push_back, rust_lex_tests): Update.
4855         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4856         parameter.
4857         <lexptr, prev_lexptr>: New members.
4858         (lexptr, prev_lexptr): Don't declare.
4859         * parse.c (lexptr, prev_lexptr): Remove globals.
4860         (parse_exp_in_context): Update.
4861         * p-exp.y (yylex, yyerror): Update.
4862         * m2-exp.y (parse_number, yylex, yyerror): Update.
4863         * go-exp.y (lex_one_token, yyerror): Update.
4864         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4865         * d-exp.y (lex_one_token, yyerror): Update.
4866         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4867         (lex_one_token, yyerror): Update.
4868         * ada-lex.l (YY_INPUT): Update.
4869         (rewind_to_char): Update.
4870         * ada-exp.y (yyerror): Update.
4871
4872 2019-04-04  Tom Tromey  <tom@tromey.com>
4873
4874         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4875         * parser-defs.h (struct parser_state) <parser_state>: Add new
4876         parameter.
4877         <comma_terminates>: New member.
4878         (comma_terminates): Don't declare global.
4879         * parse.c (comma_terminates): Remove global.
4880         (parse_exp_in_context): Update.
4881         * p-exp.y (yylex): Update.
4882         * m2-exp.y (yylex): Update.
4883         * go-exp.y (lex_one_token): Update.
4884         * f-exp.y (yylex): Update.
4885         * d-exp.y (lex_one_token): Update.
4886         * c-exp.y (lex_one_token): Update.
4887         * ada-lex.l: Update.
4888
4889 2019-04-04  Tom Tromey  <tom@tromey.com>
4890
4891         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4892         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4893         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4894         * parser-defs.h (paren_depth): Don't declare.
4895         * parse.c (paren_depth): Remove global.
4896         (parse_exp_in_context): Update.
4897         * p-exp.y (paren_depth): New global.
4898         (pascal_parse): Initialize it.
4899         * m2-exp.y (paren_depth): New global.
4900         (m2_parse): Initialize it.
4901         * go-exp.y (paren_depth): New global.
4902         (go_parse): Initialize it.
4903         * f-exp.y (paren_depth): New global.
4904         (f_parse): Initialize it.
4905         * d-exp.y (paren_depth): New global.
4906         (d_parse): Initialize it.
4907         * c-exp.y (paren_depth): New global.
4908         (c_parse): Initialize it.
4909         * ada-lex.l (paren_depth): New global.
4910         (lexer_init): Initialize it.
4911
4912 2019-04-04  Tom Tromey  <tom@tromey.com>
4913
4914         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4915         (rust_parser::convert_ast_to_type)
4916         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4917         * parser-defs.h (struct parser_state) <parser_state>: Add
4918         parameters.  Initialize new members.
4919         <expression_context_block, expression_context_pc>: New members.
4920         * parse.c (expression_context_block, expression_context_pc):
4921         Remove globals.
4922         (parse_exp_in_context): Update.
4923         * p-exp.y: Update all rules.
4924         (yylex): Update.
4925         * m2-exp.y: Update all rules.
4926         (yylex): Update.
4927         * go-exp.y (yylex): Update.
4928         * f-exp.y (yylex): Update.
4929         * d-exp.y: Update all rules.
4930         (yylex): Update.
4931         * c-exp.y: Update all rules.
4932         (lex_one_token, classify_name, yylex, c_parse): Update.
4933         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4934
4935 2019-04-04  Tom Tromey  <tom@tromey.com>
4936
4937         * gdbarch.h, gdbarch.c: Rebuild.
4938         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4939         * stap-probe.h:
4940         (struct stap_parse_info): Replace "parser_state" with
4941         "expr_builder".
4942         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4943         (parser_state): New class.
4944         * parse.c (expr_builder): Rename.
4945         (expr_builder::release): Rename.
4946         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4947         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4948         (write_exp_elt_longcst, write_exp_elt_floatcst)
4949         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4950         (write_exp_string_vector, write_exp_bitstring)
4951         (write_exp_msymbol, mark_struct_expression)
4952         (write_dollar_variable)
4953         (insert_type_address_space, increase_expout_size): Replace
4954         "parser_state" with "expr_builder".
4955         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4956         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4957         "parser_state" with "expr_builder".
4958
4959 2019-04-04  Tom Tromey  <tom@tromey.com>
4960
4961         * rust-exp.y: Replace "parse_language" with method call.
4962         * p-exp.y:
4963         (yylex): Replace "parse_language" with method call.
4964         * m2-exp.y:
4965         (yylex): Replace "parse_language" with method call.
4966         * go-exp.y (classify_name): Replace "parse_language" with method
4967         call.
4968         * f-exp.y (yylex): Replace "parse_language" with method call.
4969         * d-exp.y (lex_one_token): Replace "parse_language" with method
4970         call.
4971         * c-exp.y:
4972         (lex_one_token, classify_name, yylex): Replace "parse_language"
4973         with method call.
4974         * ada-exp.y (find_primitive_type, type_char)
4975         (type_system_address): Replace "parse_language" with method call.
4976
4977 2019-04-04  Tom Tromey  <tom@tromey.com>
4978
4979         * rust-exp.y: Replace "parse_gdbarch" with method call.
4980         * parse.c (write_dollar_variable, insert_type_address_space):
4981         Replace "parse_gdbarch" with method call.
4982         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4983         call.
4984         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4985         call.
4986         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4987         "parse_gdbarch" with method call.
4988         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4989         with method call.
4990         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4991         "parse_gdbarch" with method call.
4992         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4993         "parse_gdbarch" with method call.
4994         * c-exp.y (parse_type, parse_number, classify_name): Replace
4995         "parse_gdbarch" with method call.
4996         * ada-lex.l: Replace "parse_gdbarch" with method call.
4997         * ada-exp.y (parse_type, find_primitive_type, type_char)
4998         (type_system_address): Replace "parse_gdbarch" with method call.
4999
5000 2019-04-04  Tom Tromey  <tom@tromey.com>
5001
5002         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5003         * stap-probe.c (stap_parse_argument): Update.
5004         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5005         initial_size parameter.
5006         * rust-exp.y (rust_lex_tests): Update.
5007         * parse.c (parser_state): Update.
5008         (parse_exp_in_context): Update.
5009         * parser-defs.h (struct parser_state) <parser_state>: Remove
5010         "initial_size" parameter.
5011
5012 2019-04-04  Tom Tromey  <tom@tromey.com>
5013
5014         * parser-defs.h (increase_expout_size): Don't declare.
5015         * parse.c (increase_expout_size): Now static.
5016
5017 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5018
5019         * gnu-nat.c (gnu_nat_target::wait): Fix
5020         target_waitstatus_to_string call.
5021
5022 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * eval.c (evaluate_subexp_standard): Handle internal functions
5025         during Fortran function call handling.
5026
5027 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * NEWS: Mention new internal functions.
5030         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5031         (read_base_type): Use dwarf2_init_complex_target_type.
5032         * value.c (creal_internal_fn): New function.
5033         (cimag_internal_fn): New function.
5034         (_initialize_values): Register new internal functions.
5035
5036 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5037
5038         * infrun.c (stop_all_threads): If debug_infrun, always
5039         trace the wait status after wait_one, using
5040         target_waitstatus_to_string and target_pid_to_str.
5041         (handle_inferior_event): Replace various trace of
5042         wait status kind by a single trace.
5043         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5044         wait status kind image by target_waitstatus_to_string.
5045         * target/waitstatus.c (target_waitstatus_to_string): Fix
5046         obsolete comment.
5047
5048 2019-04-01  Tom Tromey  <tromey@adacore.com>
5049
5050         PR symtab/23331:
5051         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5052
5053 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5054             Pedro Alves  <palves@redhat.com>
5055
5056         * top.c (quit_force): Call 'finalize_values'.
5057         * value.c (finalize_values): New function.
5058         * value.h (finalize_values): Declare.
5059
5060 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5061
5062         * NEWS: Announce $_gdb_major and $_gdb_minor.
5063
5064         * top.c (init_gdb_version_vars): New function.
5065         (gdb_init): Call init_gdb_version_vars.
5066
5067 2019-03-29  Tom Tromey  <tromey@adacore.com>
5068
5069         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5070         help text.  Remove dead code.
5071
5072 2019-03-29  Keith Seitz  <keiths@redhat.com>
5073
5074         From Siddhesh Poyarekar:
5075         * f-lang.h (f77_get_upperbound): Return LONGEST.
5076         (f77_get_lowerbound): Likewise.
5077         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5078         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5079         print them.
5080         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5081         plongest to format print it.
5082         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5083         (f77_get_upperbound): Likewise.
5084         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5085         LOWER_BOUND to LONGEST.
5086         (f77_create_arrayprint_offset_tbl): Likewise.
5087
5088 2019-03-29  Keith Seitz  <keiths@redhat.com>
5089
5090         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5091         %s/pulongest for TYPE_LENGTH instead of %d in format
5092         strings.
5093         * ada-typerint.c (ada_print_type): Likewise.
5094         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5095         * compile/compile-c-support.c (generate_register_struct): Likewise.
5096         * gdbtypes.c (recursive_dump_type): Likewise.
5097         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5098         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5099         instead of %d in format strings.
5100         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5101         to std::min to ULONGEST.
5102         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5103         instead of %d in format strings.
5104         * tracepoint.c (info_scope_command): Likewise.
5105         * typeprint.c (print_offset_data::update)
5106         (print_offset_data::finish): Likewise.
5107         * xtensa-tdep.c (xtensa_store_return_value)
5108         (xtensa_push_dummy_call): Likewise.
5109
5110 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5111
5112         * windows-nat.c (display_selector): Fixed format specifications
5113         for 64-bit Cygwin.
5114
5115 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5116
5117         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5118
5119 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5120
5121         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5122         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5123         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5124         (nios2_linux_init_abi): Install it.
5125
5126 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5127
5128         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5129
5130 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5131
5132         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5133
5134 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5135             Tom Tromey  <tromey@adacore.com>
5136
5137         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5138
5139 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5140
5141         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5142         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5143         method to compute the bounds of range types. Also print "[evaluated]"
5144         if the bounds' values come from a dynamic evaluation.
5145
5146 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5147
5148         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5149         whitespace when pretty printing is on.
5150
5151 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5152
5153         * ppc-linux-nat.c: Add include.
5154
5155 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5156
5157         * NEWS: Mention AArch64 Pointer Authentication.
5158
5159 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5160
5161         * arm-linux-nat.c: Add include.
5162
5163 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5164
5165         * source-cache.c (source_cache::get_source_lines): Re-read
5166         fullname after calling open_source_file.
5167
5168 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5169
5170         * NEWS: Mention TLS support for FreeBSD.
5171
5172 2019-03-25  Tom Tromey  <tromey@adacore.com>
5173
5174         * minsyms.c (BUNCH_SIZE): Update comment.
5175         (~minimal_symbol_reader): Remove old comment.
5176         (compact_minimal_symbols): Update comment.
5177         (minimal_symbol_reader::install): Remove old comment.  Update
5178         other comments.
5179
5180 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5181
5182         * s390-linux-nat.c: Add include.
5183
5184 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5185
5186         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5187         Call linux_get_hwcap.
5188         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5189         Likewise.
5190         (aarch64_linux_get_hwcap): Remove function.
5191         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5192         declaration.
5193         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5194         linux_get_hwcap.
5195         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5196         * linux-tdep.c (linux_get_hwcap): Add function.
5197         (linux_get_hwcap2): Likewise.
5198         * linux-tdep.h (linux_get_hwcap): Add declaration.
5199         (linux_get_hwcap2): Likewise.
5200         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5201         (ppc_linux_get_hwcap2): Likewise.
5202         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5203         linux_get_hwcap.
5204         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5205         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5206         (ppc_linux_nat_target::read_description): Likewise.
5207         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5208         * s390-linux-nat.c: Likewise.
5209         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5210
5211 2019-03-24  Tom Tromey  <tom@tromey.com>
5212
5213         * ada-lang.c (standard_lookup): Simplify initialization.
5214         (ada_lookup_symbol_nonlocal): Simplify return.
5215         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5216         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5217         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5218         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5219         initialization.
5220         * solib.c (solib_global_lookup): Simplify.
5221         * symtab.c (null_block_symbol): Remove.
5222         (symbol_cache_lookup): Simplify returns.
5223         (lookup_language_this): Simplify returns.
5224         (lookup_symbol_aux): Simplify return.
5225         (lookup_local_symbol): Simplify returns.
5226         (lookup_global_symbol_from_objfile): Simplify return.
5227         (lookup_symbol_in_objfile_symtabs)
5228         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5229         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5230         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5231         * cp-namespace.c (cp_lookup_bare_symbol)
5232         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5233         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5234         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5235         (cp_lookup_symbol_via_imports): Simplify initialization.
5236         (find_symbol_in_baseclass): Likewise.
5237         * symtab.h (null_block_symbol): Remove.
5238         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5239         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5240         (d_lookup_symbol_module): Likewise.
5241         (find_symbol_in_baseclass): Simplify initialization.
5242
5243 2019-03-24  Tom Tromey  <tom@tromey.com>
5244
5245         * expression.h: Don't include symtab.h.
5246         (struct block): Forward declare.
5247
5248 2019-03-24  Tom Tromey  <tom@tromey.com>
5249
5250         * c-exp.y (typebase): Remove casts.
5251         * gdbtypes.c (lookup_unsigned_typename, )
5252         (lookup_signed_typename): Remove cast.
5253         * eval.c (parse_to_comma_and_eval): Remove cast.
5254         * parse.c (write_dollar_variable): Remove cast.
5255         * block.h (struct block) <superblock>: Now const.
5256         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5257         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5258         (map_block): Make "block" const.
5259         * symfile.h (struct quick_symbol_functions)
5260         <map_matching_symbols>: Constify block argument to "callback".
5261         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5262         const.
5263         (find_pc_sect_compunit_symtab): Make "b" const.
5264         (find_symbol_at_address): Likewise.
5265         (search_symbols): Likewise.
5266         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5267         (dw2_debug_names_lookup_symbol): Likewise.
5268         (dw2_map_matching_symbols): Update.
5269         * p-valprint.c (pascal_val_print): Remove "block".
5270         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5271         (aux_add_nonlocal_symbols): Make "block" const.
5272         (resolve_subexp): Remove cast.
5273         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5274         const.
5275         (iterate_over_file_blocks): Likewise.
5276         * f-exp.y (%union) <bval>: Remove.
5277         * coffread.c (patch_opaque_types): Make "b" const.
5278         * spu-tdep.c (spu_catch_start): Make "block" const.
5279         * c-valprint.c (print_unpacked_pointer): Remove "block".
5280         * symmisc.c (dump_symtab_1): Make "b" const.
5281         (block_depth): Make "block" const.
5282         * d-exp.y (%union) <bval>: Remove.
5283         * cp-support.h (cp_lookup_rtti_type): Update.
5284         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5285         * psymtab.c (psym_lookup_symbol): Make "block" const.
5286         (maintenance_check_psymtabs): Make "b" const.
5287         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5288         (enumerate_locals, enumerate_args): Update.
5289         * python/py-symtab.c (stpy_global_block): Make "block" const.
5290         (stpy_static_block): Likewise.
5291         * inline-frame.c (block_starting_point_at): Make "new_block"
5292         const.
5293         * block.c (find_block_in_blockvector): Make return type const.
5294         (blockvector_for_pc_sect): Make "b" const.
5295         (find_block_in_blockvector): Make "b" const.
5296
5297 2019-03-23  Tom Tromey  <tom@tromey.com>
5298
5299         * varobj.c (varobj_create): Update.
5300         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5301         * printcmd.c (display_command, do_one_display): Don't reset
5302         innermost_block.
5303         * parser-defs.h (enum innermost_block_tracker_type): Move to
5304         expression.h.
5305         (innermost_block): Update comment.
5306         * parse.c (parse_exp_1): Add tracker_types parameter.
5307         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5308         tracker_types parameter.  Reset innermost_block.
5309         (parse_exp_in_context): Remove.
5310         (parse_expression_for_completion): Update.
5311         * objfiles.c (~objfile): Don't reset expression_context_block or
5312         innermost_block.
5313         * expression.h (enum innermost_block_tracker_type): Move from
5314         parser-defs.h.
5315         (parse_exp_1): Add tracker_types parameter.
5316         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5317         reset innermost_block.
5318
5319 2019-03-23  Tom Tromey  <tom@tromey.com>
5320
5321         * objfiles.h: Include bcache.h.
5322
5323 2019-03-23  Tom Tromey  <tom@tromey.com>
5324
5325         * linespec.c (get_current_search_block): Use
5326         scoped_restore_current_language.
5327         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5328
5329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5330             Jiong Wang  <jiong.wang@arm.com>
5331
5332         * aarch64-linux-tdep.c
5333         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5334         section.
5335         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5336
5337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5338             Jiong Wang  <jiong.wang@arm.com>
5339
5340         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5341         instructions.
5342         (aarch64_analyze_prologue_test): Add PACIASP test.
5343         (aarch64_prologue_prev_register): Unmask PC value.
5344
5345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5346             Jiong Wang  <jiong.wang@arm.com>
5347
5348         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5349         (aarch64_dwarf2_prev_register): Unmask PC value.
5350         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5351         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5352         DW_CFA_AARCH64_negate_ra_state.
5353         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5354
5355 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5356             Jiong Wang  <jiong.wang@arm.com>
5357
5358         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5359         registers.
5360         (aarch64_pseudo_register_name): Likewise.
5361         (aarch64_pseudo_register_type): Likewise.
5362         (aarch64_pseudo_register_reggroup_p): Likewise.
5363         (aarch64_gdbarch_init): Add pauth registers.
5364         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5365         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5366         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5367         (struct gdbarch_tdep): Add regnum for ra_state.
5368
5369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5370             Jiong Wang  <jiong.wang@arm.com>
5371
5372         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5373
5374 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5375             Jiong Wang  <jiong.wang@arm.com>
5376
5377         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5378         function.
5379         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5380         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5381         (aarch64_gdbarch_init): Add puth registers.
5382         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5383         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5384         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5385
5386 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5387             Jiong Wang  <jiong.wang@arm.com>
5388
5389         * aarch64-linux-nat.c
5390         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5391         * aarch64-linux-tdep.c
5392         (aarch64_linux_core_read_description): Likewise.
5393         (aarch64_linux_get_hwcap): New function.
5394         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5395         (aarch64_linux_get_hwcap): New declaration.
5396
5397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5398             Jiong Wang  <jiong.wang@arm.com>
5399
5400         * aarch64-linux-nat.c
5401         (aarch64_linux_nat_target::read_description): Add pauth param.
5402         * aarch64-linux-tdep.c
5403         (aarch64_linux_core_read_description): Likewise.
5404         * aarch64-tdep.c (struct target_desc): Add in pauth.
5405         (aarch64_read_description): Add pauth param.
5406         (aarch64_gdbarch_init): Likewise.
5407         * aarch64-tdep.h (aarch64_read_description): Likewise.
5408         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5409         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5410         * features/Makefile: Add new files.
5411         * features/aarch64-pauth.c: New file.
5412         * features/aarch64-pauth.xml: New file.
5413
5414 2019-03-20  Tom Tromey  <tromey@adacore.com>
5415
5416         * infrun.c (handle_inferior_event): Rename from
5417         handle_inferior_event_1.  Create a scoped_value_mark.
5418         (handle_inferior_event): Remove.
5419
5420 2019-03-19  Tom Tromey  <tromey@adacore.com>
5421
5422         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5423         * infrun.h (print_stop_event): Add "displays" parameter.
5424         * infrun.c (print_stop_event): Add "displays" parameter.
5425
5426 2019-03-19  Pedro Alves  <palves@redhat.com>
5427
5428         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5429         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5430         to -1.  Fix TABs vs spaces.
5431         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5432         * tui/tui-out.h (tui_ui_out) Add intro comments.
5433         <m_line, m_start_of_line>: In-class initialize, and add describing
5434         comment.
5435
5436 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5437
5438         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5439         variable names.
5440         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5441
5442 2019-03-18  Pedro Alves  <palves@redhat.com>
5443             Eli Zaretskii <eliz@gnu.org>
5444
5445         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5446         m_line and m_start_of_line.
5447
5448 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5449
5450         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5451         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5452         it returns a newline.  This fixes a regression in TU mode, whereby
5453         the next line is output on the same screen line as the user input.
5454
5455 2019-03-18  Tom Tromey  <tromey@adacore.com>
5456
5457         * minsyms.c (minimal_symbol_reader::install): Remove call to
5458         obstack_blank.
5459
5460 2019-03-18  Pedro Alves  <palves@redhat.com>
5461
5462         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5463         New globals.
5464         (apply_style): New, factored out from ...
5465         (apply_ansi_escape): ... this.  Handle reverse video mode.
5466         (tui_set_reverse_mode): New function.
5467         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5468         * tui/tui-winsource.c (tui_show_source_line): Use
5469         tui_set_reverse_mode instead of setting A_STANDOUT.
5470         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5471         New setter methods.
5472
5473 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5474
5475         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5476         Handle tabs.
5477
5478 2019-03-18  Tom Tromey  <tromey@adacore.com>
5479
5480         * ada-lang.c (empty_array): Add "high" parameter.
5481         (ada_evaluate_subexp): Update.
5482
5483 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5484
5485         * unittests/string_view-selftests.c: Define
5486         _initialize_string_view_selftests unconditionally.
5487
5488 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5489
5490         PR gdb/24350
5491         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5492
5493 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5494
5495         PR gdb/24351
5496         * windows-nat.c (display_selector): Fix format specifiers.
5497
5498 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5499
5500         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5501         tui_refill_source_window instead of tui_refresh_win, to update the
5502         current execution line.  This fixes redisplay of the current line
5503         when stepping through the code with "next" or "step".
5504
5505 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5506
5507         * source-cache.c (source_cache::get_source_lines): Call
5508         find_source_lines to initialize s->nlines.  This fixes vertical
5509         scrolling of TUI source window when the DOWN arrow is pressed.
5510
5511 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5512
5513         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5514         linux-thread-db.c (_initialize_thread_db): Likewise.
5515
5516 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5517
5518         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5519         wclrtoeol in tui_show_source_line".  This reverts changes made in
5520         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5521
5522 2019-03-15  Tom Tromey  <tom@tromey.com>
5523
5524         * symtab.h (struct minimal_symbol): Derive from
5525         general_symbol_info.
5526         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5527         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5528         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5529         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5530         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5531         (MSYMBOL_SEARCH_NAME): Update.
5532         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5533         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5534         * minsyms.c (minimal_symbol_reader::record_full): Update.
5535
5536 2019-03-15  Tom Tromey  <tom@tromey.com>
5537
5538         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5539
5540 2019-03-15  Tom Tromey  <tom@tromey.com>
5541
5542         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5543         unique_xmalloc_ptr.
5544         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5545         Update.
5546         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5547         (build_minimal_symbol_hash_tables)
5548         (minimal_symbol_reader::install): Update.
5549
5550 2019-03-15  Tom Tromey  <tom@tromey.com>
5551
5552         * symtab.c (create_demangled_names_hash): Update.
5553         (symbol_set_names): Update.
5554         * objfiles.h (struct objfile_per_bfd_storage)
5555         <demangled_names_hash>: Now an htab_up.
5556         * objfiles.c (objfile_per_bfd_storage): Simplify.
5557
5558 2019-03-15  Tom Tromey  <tom@tromey.com>
5559
5560         * objfiles.h (struct objfile_per_bfd_storage): Declare
5561         destructor.
5562         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5563         New.
5564         (get_objfile_bfd_data): Use new.  Don't initialize
5565         language_of_main.
5566         (free_objfile_per_bfd_storage): Remove.
5567         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5568
5569 2019-03-15  Tom Tromey  <tom@tromey.com>
5570
5571         * symfile.c (reread_symbols): Update.
5572         * objfiles.c (objfile::objfile): Update.
5573         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5574         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5575         comment.
5576         (minimal_symbol_reader::install): Update.
5577         (terminate_minimal_symbol_table): Remove.
5578         * jit.c (jit_object_close_impl): Update.
5579
5580 2019-03-15  Tom Tromey  <tom@tromey.com>
5581
5582         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5583         initializations.
5584
5585 2019-03-15  Tom Tromey  <tom@tromey.com>
5586
5587         * objfiles.h (struct objfile_per_bfd_storage)
5588         <demangled_hash_languages>: Now a bitset.
5589         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5590         (lookup_minimal_symbol): Update.
5591
5592 2019-03-15  Tom Tromey  <tom@tromey.com>
5593
5594         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5595         Don't return the symbol.
5596         * coffread.c (record_minimal_symbol): Use record_full.
5597
5598 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5599
5600         The MS-Windows port of ncurses fails to switch to a color pair if
5601         one or both of the colors are the implicit default colors.  This
5602         change records the default colors when TUI is initialized, and
5603         then specifies them explicitly when a color pair uses the default
5604         colors.  This allows color styling in TUI mode on MS-Windows.
5605
5606         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5607         ncurses_norm_attr.
5608         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5609         colors in ncurses_norm_attr.
5610         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5611         "none", replace it with the default color recorded in
5612         ncurses_norm_attr.
5613
5614 2019-03-14  Tom Tromey  <tromey@adacore.com>
5615
5616         * source-cache.h (class source_cache) <get_source_lines>: Return
5617         std::string.
5618         * source-cache.c (source_cache::extract_lines): Handle case where
5619         first_pos==npos.  Return std::string.
5620         (source_cache::get_source_lines): Update.
5621
5622 2019-03-14  Tom Tromey  <tromey@adacore.com>
5623
5624         * NEWS: Add item for "style sources" commands.
5625         * source-cache.c (source_cache::get_source_lines): Check
5626         source_styling.
5627         * cli/cli-style.c (source_styling): New global.
5628         (_initialize_cli_style): Add "style sources" commands.
5629         (show_style_sources): New function.
5630         * cli/cli-style.h (source_styling): Declare.
5631
5632 2019-03-14  Pedro Alves  <palves@redhat.com>
5633             Tom Tromey  <tromey@adacore.com>
5634
5635         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5636         * tui/tui-winsource.c (tui_refill_source_window): New function,
5637         from...
5638         (tui_horizontal_source_scroll): ... here.  Move some logic.
5639         * cli/cli-style.c (set_style_enabled): Notify new observable.
5640         * tui/tui-hooks.c (tui_redisplay_source): New function.
5641         (tui_attach_detach_observers): Attach or detach
5642         tui_redisplay_source.
5643         * observable.h (source_styling_changed): New observable.
5644         * observable.c: Define source_styling_changed observable.
5645
5646 2019-03-13  Tom Tromey  <tromey@adacore.com>
5647
5648         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5649         (i386_gnu_nat_target::store_registers): Update.
5650         * target-debug.h (target_debug_print_std_string): New macro.
5651         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5652         * windows-tdep.c (display_one_tib): Update.
5653         * tui/tui-stack.c (tui_make_status_line): Update.
5654         * top.c (print_inferior_quit_action): Update.
5655         * thread.c (thr_try_catch_cmd): Update.
5656         (add_thread_with_info): Update.
5657         (thread_target_id_str): Update.
5658         (thr_try_catch_cmd): Update.
5659         (thread_command): Update.
5660         (thread_find_command): Update.
5661         * record-btrace.c (record_btrace_target::info_record)
5662         (record_btrace_resume_thread, record_btrace_target::resume)
5663         (record_btrace_cancel_resume, record_btrace_step_thread)
5664         (record_btrace_target::wait, record_btrace_target::wait)
5665         (record_btrace_target::wait, record_btrace_target::stop): Update.
5666         * progspace.c (print_program_space): Update.
5667         * process-stratum-target.c
5668         (process_stratum_target::thread_address_space): Update.
5669         * linux-fork.c (linux_fork_mourn_inferior)
5670         (detach_checkpoint_command, info_checkpoints_command)
5671         (linux_fork_context): Update.
5672         (linux_fork_detach): Update.
5673         (class scoped_switch_fork_info): Update.
5674         (delete_checkpoint_command): Update.
5675         * infrun.c (follow_fork_inferior): Update.
5676         (follow_fork_inferior): Update.
5677         (proceed_after_vfork_done): Update.
5678         (handle_vfork_child_exec_or_exit): Update.
5679         (follow_exec): Update.
5680         (displaced_step_prepare_throw): Update.
5681         (displaced_step_restore): Update.
5682         (start_step_over): Update.
5683         (resume_1): Update.
5684         (clear_proceed_status_thread): Update.
5685         (proceed): Update.
5686         (print_target_wait_results): Update.
5687         (do_target_wait): Update.
5688         (context_switch): Update.
5689         (stop_all_threads): Update.
5690         (restart_threads): Update.
5691         (finish_step_over): Update.
5692         (handle_signal_stop): Update.
5693         (switch_back_to_stepped_thread): Update.
5694         (keep_going_pass_signal): Update.
5695         (print_exited_reason): Update.
5696         (normal_stop): Update.
5697         * inferior.c (inferior_pid_to_str): Change return type.
5698         (print_selected_inferior): Update.
5699         (add_inferior): Update.
5700         (detach_inferior): Update.
5701         * dummy-frame.c (fprint_dummy_frames): Update.
5702         * dcache.c (dcache_info_1): Update.
5703         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5704         (btrace_fetch, btrace_clear): Update.
5705         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5706         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5707         type.
5708         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5709         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5710         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5711         * gdbarch.c, gdbarch.h: Rebuild.
5712         * gdbarch.sh (core_pid_to_str): Change return type.
5713         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5714         return type.
5715         (windows_nat_target::pid_to_str): Change return type.
5716         (windows_delete_thread): Update.
5717         (windows_nat_target::attach): Update.
5718         (windows_nat_target::files_info): Update.
5719         * target-delegates.c: Rebuild.
5720         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5721         return type.
5722         (sol_thread_target::pid_to_str): Change return type.
5723         * remote.c (class remote_target) <pid_to_str>: Change return
5724         type.
5725         (remote_target::pid_to_str): Change return type.
5726         (extended_remote_target::attach, remote_target::remote_stop_ns)
5727         (remote_target::remote_notif_remove_queued_reply)
5728         (remote_target::push_stop_reply, remote_target::disable_btrace):
5729         Update.
5730         (extended_remote_target::attach): Update.
5731         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5732         type.
5733         (gdbsim_target::pid_to_str): Change return type.
5734         * ravenscar-thread.c (struct ravenscar_thread_target)
5735         <pid_to_str>: Change return type.
5736         (ravenscar_thread_target::pid_to_str): Change return type.
5737         * procfs.c (class procfs_target) <pid_to_str>: Change return
5738         type.
5739         (procfs_target::pid_to_str): Change return type.
5740         (procfs_target::attach): Update.
5741         (procfs_target::detach): Update.
5742         (procfs_target::fetch_registers): Update.
5743         (procfs_target::store_registers): Update.
5744         (procfs_target::wait): Update.
5745         (procfs_target::files_info): Update.
5746         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5747         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5748         return type.
5749         (nto_procfs_target::pid_to_str): Change return type.
5750         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5751         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5752         return type.
5753         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5754         (exit_lwp): Update.
5755         (attach_proc_task_lwp_callback, get_detach_signal)
5756         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5757         (linux_nat_target::resume, wait_lwp, stop_callback)
5758         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5759         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5760         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5761         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5762         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5763         type.
5764         (inf_ptrace_target::attach): Update.
5765         (inf_ptrace_target::files_info): Update.
5766         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5767         type.
5768         (go32_nat_target::pid_to_str): Change return type.
5769         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5770         (gnu_nat_target::wait): Update.
5771         (gnu_nat_target::wait): Update.
5772         (gnu_nat_target::resume): Update.
5773         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5774         (fbsd_nat_target::wait): Update.
5775         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5776         type.
5777         (darwin_nat_target::attach): Update.
5778         * corelow.c (class core_target) <pid_to_str>: Change return type.
5779         (core_target::pid_to_str): Change return type.
5780         * target.c (normal_pid_to_str): Change return type.
5781         (default_pid_to_str): Likewise.
5782         (target_pid_to_str): Change return type.
5783         (target_translate_tls_address): Update.
5784         (target_announce_detach): Update.
5785         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5786         return type.
5787         (bsd_uthread_target::pid_to_str): Change return type.
5788         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5789         type.
5790         (bsd_kvm_target::pid_to_str): Change return type.
5791         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5792         return type.
5793         (aix_thread_target::pid_to_str): Change return type.
5794         * target.h (struct target_ops) <pid_to_str>: Change return type.
5795         (target_pid_to_str, normal_pid_to_str): Likewise.
5796         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5797         type.
5798         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5799         type.
5800         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5801         return type.
5802         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5803         type.
5804         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5805         type.
5806         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5807         return type.
5808
5809 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5810
5811         * NEWS: Mention that the new default MI version is 3.  Mention
5812         changes to the output of commands and events that deal with
5813         multi-location breakpoints.
5814         * breakpoint.c: Include "mi/mi-out.h".
5815         (print_one_breakpoint): Change output syntax if using MI version
5816         >= 3.
5817         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5818         New.
5819         (mi_multi_location_breakpoint_output_fixed): New.
5820         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5821         (mi_cmd_fix_multi_location_breakpoint_output): New.
5822         (mi_multi_location_breakpoint_output_fixed): New.
5823         * mi/mi-cmds.c (mi_cmds): Register command
5824         -fix-multi-location-breakpoint-output.
5825         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5826         interpreter "mi".
5827
5828 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5829
5830         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5831         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5832         instantiate mi_ui_out based on interpreter name.
5833         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5834         * mi/mi-main.c (mi_load_progress): Likewise.
5835
5836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5837
5838         * NEWS: Combine separate "New targets" sections for 8.3.
5839
5840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5841
5842         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5843         (ppcfbsd_init_abi): Install gdbarch
5844         "fetch_tls_load_module_address" and "get_thread_local_address"
5845         methods.
5846
5847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5848
5849         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5850         (riscv_fbsd_init_abi): Install gdbarch
5851         "fetch_tls_load_module_address" and "get_thread_local_address"
5852         methods.
5853
5854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5855
5856         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5857         (i386fbsd_init_abi): Install gdbarch
5858         "fetch_tls_load_module_address" and "get_thread_local_address"
5859         methods.
5860
5861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5862
5863         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5864         (amd64fbsd_init_abi): Install gdbarch
5865         "fetch_tls_load_module_address" and "get_thread_local_address"
5866         methods.
5867
5868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5869
5870         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5871         (struct fbsd_pspace_data): New type.
5872         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5873         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5874         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5875         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5876         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5877
5878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5879
5880         * gdbtypes.c (lookup_struct_elt): New function.
5881         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5882         * gdbtypes.h (struct struct_elt): New type.
5883         (lookup_struct_elt): New prototype.
5884
5885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5886
5887         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5888         remove disabled code block.
5889
5890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5891
5892         * gdbarch.sh (get_thread_local_address): New method.
5893         * gdbarch.h, gdbarch.c: Regenerate.
5894         * target.c (target_translate_tls_address): Use
5895         gdbarch_get_thread_local_address if present instead of
5896         target::get_thread_local_address.
5897
5898 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5899
5900         * target.h (target::get_thread_local_address): Update comment.
5901
5902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5903
5904         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5905         objfile->separate_debug_objfile_backlink if not NULL.
5906
5907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5908
5909         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5910         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5911         (amd64bsd_store_inferior_registers): Likewise.
5912         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5913         Enable segment base registers.
5914         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5915         PT_GETFSBASE and PT_GETGSBASE.
5916         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5917         PT_SETGSBASE.
5918         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5919         segment base registers.
5920         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5921
5922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5923
5924         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5925         Update calls to i386_target_description to add 'segments'
5926         parameter.
5927         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5928         add segment base registers.
5929         * arch/i386.c (i386_create_target_description): Add 'segments'
5930         parameter to enable segment base registers.
5931         * arch/i386.h (i386_create_target_description): Likewise.
5932         * features/i386/32bit-segments.xml: New file.
5933         * features/i386/32bit-segments.c: Generate.
5934         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5935         call to i386_target_description to add 'segments' parameter.
5936         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5937         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5938         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5939         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5940         if feature is present.
5941         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5942         Add 'segments' parameter to call to i386_target_description.
5943         (i386_target_description): Add 'segments' parameter to enable
5944         segment base registers.
5945         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5946         to call to i386_target_description.
5947         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5948         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5949         Define I386_NUM_REGS.
5950         (i386_target_description): Add 'segments' parameter to enable
5951         segment base registers.
5952
5953 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5954
5955         PR/24325
5956         * source-cache.c: #undef open and close, to avoid unresolved
5957         externals during linking.
5958
5959 2019-03-12  Tom Tromey  <tromey@adacore.com>
5960
5961         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5962         const.  Add initializers.
5963         (_initialize_remote): Don't initialize ptid globals.
5964
5965 2019-03-12  Pedro Alves  <palves@redhat.com>
5966
5967         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5968
5969 2019-03-12  Pedro Alves  <palves@redhat.com>
5970
5971         * cp-name-parser.y (main): Remove unused 'len' variable.
5972
5973 2019-03-12  Tom Tromey  <tromey@adacore.com>
5974
5975         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5976         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5977
5978 2019-03-12  Tom Tromey  <tromey@adacore.com>
5979
5980         * linux-nat.c (iterate_over_lwps): Update.
5981         (stop_callback): Remove parameter.
5982         (stop_wait_callback, detach_callback, resume_set_callback)
5983         (select_singlestep_lwp_callback, set_ignore_sigint)
5984         (status_callback, resumed_callback, resume_clear_callback)
5985         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5986         data parameter.
5987         (linux_nat_target::detach, linux_nat_target::resume)
5988         (linux_stop_and_wait_all_lwps, select_event_lwp)
5989         (linux_nat_filter_event, linux_nat_wait_1)
5990         (linux_nat_target::kill, linux_nat_target::stop)
5991         (linux_nat_target::stop): Update.
5992         (linux_nat_resume_callback): Change type.
5993         (resume_stopped_resumed_lwps, count_events_callback)
5994         (select_event_lwp_callback): Likewise.
5995         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5996         * arm-linux-nat.c (struct update_registers_data): Remove.
5997         (update_registers_callback): Change type.
5998         (arm_linux_insert_hw_breakpoint1): Update.
5999         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6000         parameter.
6001         (x86_linux_dr_set_addr): Update.
6002         (x86_linux_dr_set_control): Update.
6003         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6004         (iterate_over_lwps): Use gdb::function_view.
6005         * nat/aarch64-linux-hw-point.c (struct
6006         aarch64_dr_update_callback_param): Remove.
6007         (debug_reg_change_callback): Change type.
6008         (aarch64_notify_debug_reg_change): Update.
6009         * s390-linux-nat.c (s390_refresh_per_info): Update.
6010
6011 2019-03-11  Tom Tromey  <tromey@adacore.com>
6012
6013         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6014         redundant assignment to "this_cu".
6015
6016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6017
6018         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6019
6020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6021
6022         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6023         from...
6024         (rank_one_type): ... this.
6025
6026 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6027
6028         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6029         from...
6030         (rank_one_type): ... this.
6031
6032 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6033
6034         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6035         from...
6036         (rank_one_type): ... this.
6037
6038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6039
6040         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6041         from...
6042         (rank_one_type): ... this.
6043
6044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6045
6046         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6047         from...
6048         (rank_one_type): ... this.
6049
6050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6051
6052         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6053         from...
6054         (rank_one_type): ... this.
6055
6056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6057
6058         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6059         from...
6060         (rank_one_type): ... this.
6061
6062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6063
6064         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6065         from...
6066         (rank_one_type): ... this.
6067
6068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6069
6070         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6071         from...
6072         (rank_one_type): ... this.
6073
6074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6075
6076         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6077         from...
6078         (rank_one_type): ... this.
6079
6080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6081
6082         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6083         from...
6084         (rank_one_type): ... this.
6085
6086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6087
6088         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6089         from...
6090         (rank_one_type): ... this.
6091
6092 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6093
6094         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6095         inferior-events' shows the example events.
6096
6097 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6098
6099         Support styling on native MS-Windows console
6100
6101         PR/24315
6102         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6103         on MS-Windows if $TERM is not defined.
6104
6105         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6106
6107         * posix-hdep.c (gdb_console_fputs):
6108         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6109         functions.
6110         * ui-file.h (gdb_console_fputs): Add prototype.
6111
6112         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6113         back to fputs only if the former returns zero.
6114
6115 2019-03-07  Tom Tromey  <tom@tromey.com>
6116
6117         * symmisc.c (print_symbol_bcache_statistics): Update.
6118         (print_objfile_statistics): Update.
6119         * symfile.c (allocate_symtab): Update.
6120         * stabsread.c: Don't include bcache.h.
6121         * psymtab.h (struct psymbol_bcache): Don't declare.
6122         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6123         (psymbol_bcache_init, psymbol_bcache_free)
6124         (psymbol_bcache_get_bcache): Don't declare.
6125         * psymtab.c (struct psymbol_bcache): Remove.
6126         (psymtab_storage::psymtab_storage): Update.
6127         (psymtab_storage::~psymtab_storage): Update.
6128         (psymbol_bcache_init, psymbol_bcache_free)
6129         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6130         (add_psymbol_to_bcache): Update.
6131         (allocate_psymtab): Update.
6132         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6133         macro_cache>: No longer pointers.
6134         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6135         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6136         * macrotab.c (macro_bcache): Update.
6137         * macroexp.c: Don't include bcache.h.
6138         * gdbtypes.c (check_types_worklist): Update.
6139         (types_deeply_equal): Remove TRY/CATCH.  Update.
6140         * elfread.c (elf_symtab_read): Update.
6141         * dwarf2read.c: Don't include bcache.h.
6142         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6143         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6144         (print_bcache_statistics, bcache_memory_used): Don't declare.
6145         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6146         methods.  Rename all data members.
6147         * bcache.c (struct bcache): Move to bcache.h.
6148         (bcache::expand_hash_table): Rename from expand_hash_table.
6149         (bcache): Remove.
6150         (bcache::insert): Rename from bcache_full.
6151         (bcache::compare): Rename from bcache_compare.
6152         (bcache_xmalloc): Remove.
6153         (bcache::~bcache): Rename from bcache_xfree.
6154         (bcache::print_statistics): Rename from print_bcache_statistics.
6155         (bcache::memory_used): Rename from bcache_memory_used.
6156
6157 2019-03-07  Pedro Alves  <palves@redhat.com>
6158
6159         * infrun.c (normal_stop): Also check for
6160         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6161
6162 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * f-lang.c (value_from_host_double): Moved to...
6165         * value.c (value_from_host_double): ...here.
6166         * value.h (value_from_host_double): Declare.
6167         * guile/scm-math.c (vlscm_convert_typed_number): Use
6168         value_from_host_double.
6169         (vlscm_convert_number): Likewise.
6170         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6171         * python/py-value.c (convert_value_from_python): Likewise.
6172
6173 2019-03-06  Tom Tromey  <tom@tromey.com>
6174
6175         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6176
6177 2019-03-06  Tom Tromey  <tom@tromey.com>
6178
6179         * utils.h (free_current_contents): Don't declare.
6180         * utils.c (free_current_contents): Remove.
6181
6182 2019-03-06  Tom Tromey  <tom@tromey.com>
6183
6184         * top.c (quit_force): Update.
6185         * main.c (captured_command_loop): Update.
6186         * common/new-op.c (operator new): Update.
6187         * common/common-exceptions.c (struct catcher)
6188         <save_cleanup_chain>: Remove member.
6189         (exceptions_state_mc_init): Update.
6190         (exception_try_scope_entry): Return nullptr.
6191         (exception_try_scope_exit, exception_rethrow)
6192         (throw_exception_sjlj, throw_exception_cxx): Update.
6193         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6194         (all_cleanups, do_cleanups, discard_cleanups)
6195         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6196         (restore_cleanups, restore_final_cleanups): Don't declare.
6197         (do_final_cleanups): Remove parameter.
6198         * common/cleanups.c (cleanup_chain, make_cleanup)
6199         (make_cleanup_dtor, all_cleanups, do_cleanups)
6200         (discard_my_cleanups, discard_cleanups)
6201         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6202         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6203         (null_cleanup): Remove.
6204         (do_final_cleanups): Remove parameter.
6205
6206 2019-03-06  Tom Tromey  <tom@tromey.com>
6207
6208         * remote.c (remote_target::remote_parse_stop_reply): Use
6209         unique_xmalloc_ptr.
6210
6211 2019-03-06  Tom Tromey  <tom@tromey.com>
6212
6213         * stabsread.c (struct stabs_field_info): Rename from field_info.
6214         <list, fnlist>: Add initializers.
6215         <obstack>: New member.
6216         (read_member_functions, read_struct_fields, read_baseclasses):
6217         Allocate on obstack.  Don't use cleanups.
6218         (read_one_struct_field, read_member_functions, read_struct_fields)
6219         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6220         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6221         (read_struct_type): Update.
6222
6223 2019-03-06  Tom Tromey  <tom@tromey.com>
6224
6225         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6226         * common/filestuff.h (make_cleanup_close): Don't declare.
6227         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6228         Remove.
6229
6230 2019-03-06  Tom Tromey  <tom@tromey.com>
6231
6232         * solib-aix.c: Use make_scope_exit.
6233
6234 2019-03-06  Tom Tromey  <tom@tromey.com>
6235
6236         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6237         Use make_scope_exit.
6238
6239 2019-03-06  Tom Tromey  <tom@tromey.com>
6240
6241         * solib-svr4.c (disable_probes_interface): Remove parameter.
6242         (svr4_handle_solib_event): Use make_scope_exit.
6243
6244 2019-03-06  Tom Tromey  <tom@tromey.com>
6245
6246         * remote.c (struct stop_reply_deleter): Remove.
6247         (stop_reply_up): Update.
6248         (struct stop_reply): Derive from notif_event.  Don't typedef.
6249         <regcache>: Now a std::vector.
6250         (stop_reply_xfree): Remove.
6251         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6252         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6253         (remote_target::discard_pending_stop_replies): Use delete.
6254         (remote_target::remote_parse_stop_reply): Update.
6255         (remote_target::process_stop_reply): Update.
6256         * remote-notif.h (struct notif_event): Add virtual destructor.
6257         Remove "dtr" member.
6258         (struct notif_client) <alloc_event>: Return a unique_ptr.
6259         (notif_event_xfree): Don't declare.
6260         (notif_event_up): New typedef.
6261         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6262         (notif_event_xfree, do_notif_event_xfree): Remove.
6263         (remote_notif_state_xfree): Update.
6264
6265 2019-03-06  Tom Tromey  <tom@tromey.com>
6266
6267         * infrun.c (displaced_step_clear_cleanup): Now a
6268         forward_scope_exit type.
6269         (displaced_step_prepare_throw): Update.
6270         (displaced_step_fixup): Update.
6271
6272 2019-03-06  Tom Tromey  <tom@tromey.com>
6273
6274         * inferior.h (class inferior): Update comment.
6275         * gdbthread.h (class thread_info): Update comment.
6276
6277 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6278             Tom Tromey  <tom@tromey.com>
6279
6280         * stabsread.h (struct stab_section_list): Remove.
6281         (coffstab_build_psymtabs): Update.
6282         * dbxread.c (symbuf_sections): Now a std::vector.
6283         (sect_idx): New global.
6284         (fill_symbuf): Update.
6285         (coffstab_build_psymtabs): Change type of stabsects parameter.
6286         Update.
6287         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6288         std::vector.
6289         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6290         (coff_locate_sections): Update.
6291         (coff_symfile_read): Remove cleanups.  Update.
6292         (init_stringtab): Add storage parameter.
6293         (free_stringtab, free_stringtab_cleanup): Remove.
6294         (init_lineno): Add storage parameter.
6295         (free_linetab, free_linetab_cleanup): Remove.
6296
6297 2019-03-06  Pedro Alves  <palves@redhat.com>
6298
6299         * linux-fork.c (fork_info::clobber_regs): Delete.
6300         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6301         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6302         comment.  Adjust.
6303         (scoped_switch_fork_info::scoped_switch_fork_info)
6304         (checkpoint_command, linux_fork_context): Adjust
6305         fork_save_infrun_state calls.
6306
6307 2019-03-06  Pedro Alves  <palves@redhat.com>
6308
6309         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6310         (inf_has_multiple_threads): Return 'bool' and rewrite using
6311         inferior_info::threads().
6312
6313 2019-03-06  Pedro Alves  <palves@redhat.com>
6314
6315         * linux-fork.c: Include <list>.
6316         (fork_list): Now a std::list instance.
6317         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6318         (forks_exist_p, find_last_fork): Adjust.
6319         (new_fork): Delete.
6320         (one_fork_p): New.
6321         (add_fork): Adjust.
6322         (free_fork): Delete, folded into fork_info::~fork_info().
6323         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6324         Adjust.
6325         (init_fork_list): Delete.
6326         (linux_fork_killall, linux_fork_mourn_inferior)
6327         (linux_fork_detach, info_checkpoints_command): Adjust.
6328         (_initialize_linux_fork): No longer call init_fork_list.
6329
6330 2019-03-06  Pedro Alves  <palves@redhat.com>
6331
6332         * linux-fork.c (new_fork): New, split out of ...
6333         (add_fork): ... this.  Return void.  Move "first fork" special
6334         case from here, to ...
6335         (checkpoint_command): ... here.
6336         * linux-linux.h (add_fork): Return void.
6337
6338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6339
6340         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6341
6342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6343             Chris January  <chris.january@arm.com>
6344             David Lecomber  <david.lecomber@arm.com>
6345
6346         * f-exp.y: New token, UNOP_INTRINSIC.
6347         (exp): New pattern using UNOP_INTRINSIC token.
6348         (f77_keywords): Add 'abs' keyword.
6349         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6350         (value_from_host_double): New function.
6351         (evaluate_subexp_f): Support UNOP_ABS.
6352
6353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6356         types.
6357
6358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6361         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6362         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6363
6364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6365
6366         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6367
6368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6369             Chris January  <chris.january@arm.com>
6370
6371         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6372         * f-exp.y: Define 'KIND' token.
6373         (exp): New pattern for KIND expressions.
6374         (ptype): Handle types with a kind extension.
6375         (direct_abs_decl): Extend to spot kind extensions.
6376         (f77_keywords): Add 'kind' to the list.
6377         (push_kind_type): New function.
6378         (convert_to_kind_type): New function.
6379         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6380         * parse.c (operator_length_standard): Likewise.
6381         * parser-defs.h (enum type_pieces): Add tp_kind.
6382         * std-operator.def: Add UNOP_KIND.
6383
6384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * f-exp.y (f_parse): Set yydebug.
6387
6388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * f-lang.c (evaluate_subexp_f): New function.
6391         (exp_descriptor_f): New global.
6392         (f_language_defn): Use exp_descriptor_f instead of
6393         exp_descriptor_standard.
6394
6395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * f-exp.y (struct token): Add comments.
6398         (dot_ops): Remove uppercase versions and the end marker.
6399         (f77_keywords): Likewise.
6400         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6401         entries in the dot_ops array are case insensitive, and use
6402         strncasecmp to compare strings.  Also some whitespace cleanup in
6403         this area.  Similar for the f77_keywords array, except entries in
6404         this list might be case sensitive.
6405
6406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * f-exp.y (struct f77_boolean_val): Add comments.
6409         (boolean_values): Remove uppercase versions, and end marker.
6410         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6411         and use strncasecmp to achieve case insensitivity.  Additionally,
6412         perform whitespace cleanup around this code.
6413
6414 2019-03-06  Tom Tromey  <tromey@adacore.com>
6415
6416         * remote-sim.c (gdbsim_target_open): Use result of
6417         gdb_argv::release.
6418
6419 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6420         Dirk Schubert  <dirk.schubert@arm.com>
6421         Chris January  <chris.january@arm.com>
6422
6423         * eval.c (evaluate_subexp_standard): Call Fortran argument
6424         wrapping logic.
6425         * f-lang.c (struct value): A value which can be passed into a
6426         Fortran function call.
6427         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6428         where appropriate.
6429         (struct type): Value ready for a Fortran function call.
6430         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6431         is needed.
6432         * f-lang.h (fortran_argument_convert): Declaration.
6433         (fortran_preserve_arg_pointer): Declaration.
6434         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6435
6436 2019-03-05  Tom Tromey  <tromey@adacore.com>
6437
6438         * python/py-prettyprint.c (print_string_repr): Remove #if.
6439         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6440
6441 2019-03-05  Tom Tromey  <tromey@adacore.com>
6442
6443         * target.c (the_dummy_target): Move later.  Change type to
6444         "dummy_target".
6445         (initialize_targets): Don't initialize the_dummy_target.
6446
6447 2019-03-05  Tom Tromey  <tromey@adacore.com>
6448
6449         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6450         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6451
6452 2019-03-05  Tom Tromey  <tromey@adacore.com>
6453
6454         * windows-nat.c (windows_nat_target::attach)
6455         (windows_nat_target::detach): Don't call gdb_flush.
6456         * valprint.c (generic_val_print, val_print, val_print_string):
6457         Don't call gdb_flush.
6458         * utils.c (defaulted_query): Don't call gdb_flush.
6459         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6460         * target.c (target_announce_detach): Don't call gdb_flush.
6461         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6462         * remote.c (extended_remote_target::attach): Don't call
6463         gdb_flush.
6464         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6465         * printcmd.c (do_examine): Don't call gdb_flush.
6466         (info_display_command): Don't call gdb_flush.
6467         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6468         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6469         * memattr.c (info_mem_command): Don't call gdb_flush.
6470         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6471         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6472         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6473         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6474         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6475         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6476         (gnu_nat_target::detach): Don't call gdb_flush.
6477         * f-valprint.c (f_val_print): Don't call gdb_flush.
6478         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6479         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6480         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6481         gdb_flush.
6482         * c-valprint.c (c_val_print): Don't call gdb_flush.
6483         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6484
6485 2019-03-05  Tom Tromey  <tromey@adacore.com>
6486
6487         * varobj.c (update_dynamic_varobj_children): Update.
6488         (install_default_visualizer): Use reset, not release.
6489         * value.c (set_internalvar): Update.
6490         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6491         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6492         ATTRIBUTE_UNUSED_RESULT.
6493
6494 2019-03-05  Tom Tromey  <tromey@adacore.com>
6495
6496         * remote.c (class scoped_remote_fd) <release>: Add
6497         ATTRIBUTE_UNUSED_RESULT.
6498
6499 2019-03-05  Tom Tromey  <tromey@adacore.com>
6500
6501         * macroexp.c (struct macro_buffer) <release>: Add
6502         ATTRIBUTE_UNUSED_RESULT.
6503
6504 2019-03-05  Tom Tromey  <tromey@adacore.com>
6505
6506         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6507         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6508         ATTRIBUTE_UNUSED_RESULT.
6509
6510 2019-03-05  Tom Tromey  <tromey@adacore.com>
6511
6512         * common/scoped_fd.h (class scoped_fd) <release>: Add
6513         ATTRIBUTE_UNUSED_RESULT.
6514
6515 2019-03-05  Tom Tromey  <tromey@adacore.com>
6516
6517         * parser-defs.h (struct parser_state) <release>: Add
6518         ATTRIBUTE_UNUSED_RESULT.
6519
6520 2019-03-05  Tom Tromey  <tromey@adacore.com>
6521
6522         * utils.h (class gdb_argv) <release>: Add
6523         ATTRIBUTE_UNUSED_RESULT.
6524         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6525
6526 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6527
6528         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6529         for-loop range, to avoid compiler warnings.
6530
6531         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6532         avoid compiler warnings about unused variables.
6533
6534         * NEWS: Mention end of support for native debugging on MS-Windows
6535         before XP.
6536
6537         PR gdb/24292
6538         * common/netstuff.c:
6539         * gdbserver/gdbreplay.c
6540         * gdbserver/remote-utils.c:
6541         * ser-tcp.c:
6542         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6543         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6544         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6545         'getaddrinfo' and 'freeaddrinfo' were not available before
6546         Windows XP, and mingw.org's MinGW headers by default define
6547         _WIN32_WINNT to 0x500.
6548
6549 2019-03-01  Gary Benson <gbenson@redhat.com>
6550
6551         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6552
6553 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6554             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6555
6556         PR gdb/8527
6557         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6558         set_sigint_trap, clear_sigint_trap.
6559
6560 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6561
6562         * target.c (target_detach): Clear the regcache and the
6563         frame cache.
6564
6565 2019-02-27  Pedro Alves  <palves@redhat.com>
6566
6567         * utils.c (set_screen_size): When we cap the height/width sizes,
6568         tweak the corresponding command variable to show "unlimited":
6569
6570 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6571             Pedro Alves  <palves@redhat.com>
6572
6573         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6574         before calling rl_set_screen_size.
6575
6576 2019-02-27  Tom Tromey  <tromey@adacore.com>
6577
6578         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6579         define.
6580         * python/py-value.c: Remove Python 2.4 workaround.
6581         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6582         workaround.
6583         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6584         Python 2.4 workaround.
6585         * python/python-internal.h: Remove Python 2.4 comment.
6586         (Py_ssize_t): Don't define.
6587         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6588         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6589         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6590         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6591         * python/python.c (do_start_initialization): Remove Python 2.4
6592         workaround.
6593         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6594         (print_children): Remove Python 2.4 workaround.
6595         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6596         workaround.
6597         (CHARBUFFERPROC_NAME): Remove.
6598         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6599         Python 2.4 workaround.
6600
6601 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6602
6603         * NEWS: Note minimum Python version.
6604
6605 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6606
6607         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6608         code from these functions.  Remove corresponding ifdefs.  Use
6609         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6610         Remove gotos and target of gotos.
6611         (infpy_search_memory): Likewise.
6612
6613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6616         (hppa_gdbarch_init): Don't register deleted functions with
6617         gdbarch.
6618
6619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6622         (h8300_unwind_sp): Delete.
6623         (h8300_dummy_id): Delete.
6624         (h8300_gdbarch_init): Don't register deleted functions with
6625         gdbarch.
6626
6627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6630         (ft32_unwind_pc): Delete.
6631         (ft32_unwind_sp): Delete.
6632         (ft32_gdbarch_init): Don't register deleted functions with
6633         gdbarch.
6634
6635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6638         (frv_unwind_pc): Delete.
6639         (frv_unwind_sp): Delete.
6640         (frv_gdbarch_init): Don't register deleted functions with
6641         gdbarch.
6642
6643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6644
6645         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6646         (riscv_unwind_pc): Delete.
6647         (riscv_unwind_sp): Delete.
6648         (riscv_gdbarch_init): Don't register deleted functions with
6649         gdbarch.
6650
6651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6652
6653         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6654         (csky_unwind_pc): Delete.
6655         (csky_unwind_sp): Delete.
6656         (csky_gdbarch_init): Don't register deleted functions with
6657         gdbarch.
6658
6659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6660
6661         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6662         (cris_unwind_pc): Delete.
6663         (cris_unwind_sp): Delete.
6664         (cris_gdbarch_init): Don't register deleted functions with
6665         gdbarch.
6666
6667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6670         (bfin_unwind_pc): Delete.
6671         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6672
6673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6674
6675         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6676         (arm_unwind_pc): Delete.
6677         (arm_unwind_sp): Delete.
6678         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6679
6680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6683         (arc_unwind_pc): Delete.
6684         (arc_unwind_sp): Delete.
6685         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6686
6687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6690         (alpha_unwind_pc): Delete.
6691         (alpha_gdbarch_init): Don't register deleted functions with
6692         gdbarch.
6693
6694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6697         (aarch64_unwind_pc): Delete.
6698         (aarch64_unwind_sp): Delete.
6699         (aarch64_gdbarch_init): Don't register deleted functions with
6700         gdbarch.
6701
6702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * gdbtypes.c (type_align): Don't consider static members when
6705         computing structure alignment.
6706
6707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6708
6709         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6710         return 0 for other types.
6711         * arch-utils.c (default_type_align): Always return 0.
6712         * gdbarch.h: Regenerate.
6713         * gdbarch.sh (type_align): Extend comment.
6714         * gdbtypes.c (type_align): Add additional comments, always call
6715         gdbarch_type_align before applying the default rules.
6716         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6717         generic code will then apply a suitable default.
6718         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6719         types, return 0 for other types.
6720
6721 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6722
6723         * NEWS: Create a new section for the next release branch.
6724         Rename the section of the current branch, now that it has
6725         been cut.
6726
6727 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6728
6729         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6730         * version.in: Bump version to 8.3.50.DATE-git.
6731
6732 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6733
6734         * aix-thread.c (ptid_cmp): Remove unused variable.
6735         (get_signaled_thread): Likewise.
6736         (store_regs_user_thread): Likewise.
6737         (store_regs_kernel_thread): Likewise.
6738         (fetch_regs_kernel_thread): Remove shadowed variable.
6739
6740 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6741
6742         * features/riscv/32bit-cpu.xml: Add register numbers.
6743         * features/riscv/32bit-fpu.c: Regenerate.
6744         * features/riscv/32bit-fpu.xml: Add register numbers.
6745         * features/riscv/64bit-cpu.xml: Add register numbers.
6746         * features/riscv/64bit-fpu.c: Regenerate.
6747         * features/riscv/64bit-fpu.xml: Add register numbers.
6748
6749 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6750
6751         * NEWS: Mention two argument form of gdb.Value constructor.
6752         * python/py-value.c (convert_buffer_and_type_to_value): New
6753         function.
6754         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6755         Add support for handling an optional second argument.  Call
6756         convert_buffer_and_type_to_value as appropriate.
6757         * python/python-internal.h (Py_buffer_deleter): New struct.
6758         (Py_buffer_up): New typedef.
6759
6760 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6761
6762         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6763         instead of releasing ownership.
6764
6765 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6766
6767         * dwarf2read.c (open_and_init_dwp_file): Call
6768         elf_numsections instead of bfd_count_sections to initialize
6769         dwp_file->num_sections.
6770
6771 2019-02-25  Tom Tromey  <tromey@adacore.com>
6772
6773         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6774
6775 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6776
6777         * gcore.in: Add '--readnever' option when invoking GDB.
6778
6779 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6780
6781         * MAINTAINERS: Update my email address.
6782
6783 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6784
6785         * build-id.c (build_id_to_debug_bfd_1): New function.
6786         (build_id_to_debug_bfd): Look for separate debug file in
6787         sysroot.
6788
6789 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6790
6791         * gdbarch.sh: Update the copyright year range that is placed into
6792         generated files.
6793
6794 2019-02-22  Keith Seitz  <keiths@redhat.com>
6795
6796         PR symtab/23853
6797         * linespec.c (create_sals_line_offset): Search for the default
6798         symtab's filename instead of its fullname.
6799
6800 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6801
6802         * NEWS: Update style defaults.
6803
6804 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6805
6806         * main.c (captured_main_1): Disable styling in batch mode.
6807
6808 2019-02-20  Tom Tromey  <tom@tromey.com>
6809
6810         * symtab.c (symtab_symbol_info): Fix typos.
6811
6812 2019-02-20  Tom Tromey  <tromey@adacore.com>
6813
6814         * findcmd.c (_initialize_mem_search): Use upper case for
6815         metasyntactic variables.
6816
6817 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6818
6819         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6820         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6821
6822 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6823
6824         * top.h (source_file_name): Change to std::string.
6825         * top.c (source_file_name): Likewise.
6826         (command_line_input): Adjust.
6827         * cli/cli-script.c (script_from_file): Adjust.
6828
6829 2019-02-19  Tom Tromey  <tromey@adacore.com>
6830
6831         * ravenscar-thread.c
6832         (ravenscar_thread_target::update_thread_list): Don't call
6833         ada_build_task_list.
6834         * ada-lang.h (ada_build_task_list): Don't declare.
6835         * ada-tasks.c (struct ada_tasks_inferior_data)
6836         <task_list_valid_p>: Now bool.
6837         (read_known_tasks, ada_task_list_changed)
6838         (ada_tasks_invalidate_inferior_data): Update.
6839         (read_known_tasks_array): Return bool.
6840         (read_known_tasks_list): Likewise.
6841         (read_known_tasks): Return void.
6842         (ada_build_task_list): Now static.
6843
6844 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6845
6846         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6847         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6848
6849 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6850
6851         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6852         variant for ada_tasks_pspace_data_handle and
6853         ada_tasks_inferior_data_handle.
6854         (ada_tasks_pspace_data_cleanup): New function.
6855         (ada_tasks_inferior_data_cleanup): New function.
6856
6857 2019-02-17  Tom Tromey  <tom@tromey.com>
6858
6859         * macrotab.h (macro_source_fullname): Return a std::string.
6860         * macrotab.c (macro_include, check_for_redefinition)
6861         (macro_undef, macro_lookup_definition, foreach_macro)
6862         (foreach_macro_in_scope): Update.
6863         (macro_source_fullname): Return a std::string.
6864         * macrocmd.c (show_pp_source_pos): Update.
6865
6866 2019-02-17  Tom Tromey  <tom@tromey.com>
6867
6868         * macrocmd.c (show_pp_source_pos): Style the file names.
6869
6870 2019-02-17  Tom Tromey  <tom@tromey.com>
6871
6872         PR tui/24197:
6873         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6874
6875 2019-02-17  Tom Tromey  <tom@tromey.com>
6876
6877         * ada-lang.c (user_select_syms): Use filtered printing.
6878         * utils.c (wrap_style): New global.
6879         (desired_style): Remove.
6880         (emit_style_escape): Add stream parameter.
6881         (set_output_style, reset_terminal_style, prompt_for_continue):
6882         Update.
6883         (flush_wrap_buffer): Only flush gdb_stdout.
6884         (wrap_here): Set wrap_style.
6885         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6886         treat escape sequences as a character.  Change when wrap buffer is
6887         flushed.
6888         (fputs_styled): Do not set the output style when the default is
6889         requested.
6890         * ui-style.h (struct ui_file_style) <is_default>: New method.
6891         * source.c (print_source_lines_base): Emit escape sequences in one
6892         piece.
6893
6894 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6895
6896         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6897         integers and enumeration types.
6898
6899 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6900
6901         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6902         instead of lookup_symbol_in_language
6903         (do_exact_match): New function.
6904         (ada_get_symbol_name_matcher): Return do_exact_match when
6905         doing a verbatim match.
6906
6907 2019-02-15  Tom Tromey  <tromey@adacore.com>
6908
6909         * ravenscar-thread.c (ravenscar_thread_target::resume)
6910         (ravenscar_thread_target::wait): Special case wildcard requests.
6911
6912 2019-02-15  Tom Tromey  <tromey@adacore.com>
6913
6914         * ravenscar-thread.c (base_ptid): Remove.
6915         (struct ravenscar_thread_target) <close>: New method.
6916         <m_base_ptid>: New member.
6917         <update_inferior_ptid, active_task, task_is_currently_active,
6918         runtime_initialized>: Declare methods.
6919         <ravenscar_thread_target>: Add constructor.
6920         (ravenscar_thread_target::task_is_currently_active)
6921         (ravenscar_thread_target::update_inferior_ptid)
6922         (ravenscar_runtime_initialized): Rename.  Now methods.
6923         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6924         (ravenscar_thread_target::update_thread_list): Update.
6925         (ravenscar_thread_target::active_task): Now method.
6926         (ravenscar_thread_target::store_registers)
6927         (ravenscar_thread_target::prepare_to_store)
6928         (ravenscar_thread_target::prepare_to_store)
6929         (ravenscar_thread_target::mourn_inferior): Update.
6930         (ravenscar_inferior_created): Use "new" to create target.
6931         (ravenscar_thread_target::get_ada_task_ptid): Update.
6932         (_initialize_ravenscar): Don't initialize base_ptid.
6933         (ravenscar_ops): Remove global.
6934
6935 2019-02-15  Tom Tromey  <tromey@adacore.com>
6936
6937         * target.h (push_target): Declare new overload.
6938         * target.c (push_target): New overload, taking an rvalue reference.
6939         * remote.c (remote_target::open_1): Use push_target overload.
6940         * corelow.c (core_target_open): Use push_target overload.
6941
6942 2019-02-15  Tom Tromey  <tromey@adacore.com>
6943
6944         * ravenscar-thread.c (is_ravenscar_task)
6945         (ravenscar_task_is_currently_active): Return bool.
6946         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6947         (_initialize_ravenscar): Remove "(void)".
6948         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6949         Return bool.
6950
6951 2019-02-15  Tom Tromey  <tromey@adacore.com>
6952
6953         * ravenscar-thread.c (ravenscar_runtime_initializer)
6954         (has_ravenscar_runtime, get_running_thread_id)
6955         (ravenscar_thread_target::resume): Fix indentation.
6956
6957 2019-02-15  Tom Tromey  <tromey@adacore.com>
6958
6959         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6960         from ravenscar_arch_ops.
6961         (sparc_ravenscar_ops::fetch_registers)
6962         (sparc_ravenscar_ops::store_registers): Now methods.
6963         (sparc_ravenscar_prepare_to_store): Remove.
6964         (sparc_ravenscar_ops): Redefine.
6965         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6966         methods and destructor.  Remove members.
6967         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6968         (ravenscar_thread_target::store_registers)
6969         (ravenscar_thread_target::prepare_to_store): Update.
6970         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6971         Remove.
6972         (struct ppc_ravenscar_powerpc_ops): Derive from
6973         ravenscar_arch_ops.
6974         (ppc_ravenscar_powerpc_ops::fetch_registers)
6975         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6976         (ppc_ravenscar_powerpc_ops): Redefine.
6977         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6978         (ppc_ravenscar_e500_ops::fetch_registers)
6979         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6980         (ppc_ravenscar_e500_ops): Redefine.
6981         * aarch64-ravenscar-thread.c
6982         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6983         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6984         (aarch64_ravenscar_fetch_registers)
6985         (aarch64_ravenscar_store_registers): Now methods.
6986         (aarch64_ravenscar_ops): Redefine.
6987
6988 2019-02-15  Tom Tromey  <tromey@adacore.com>
6989
6990         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6991         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6992         (ravenscar_thread_target::stopped_by_watchpoint)
6993         (ravenscar_thread_target::stopped_data_address)
6994         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6995
6996 2019-02-15  Tom Tromey  <tromey@adacore.com>
6997
6998         * ravenscar-thread.c: Fix some typos.
6999
7000 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7001             Tom Tromey  <tromey@adacore.com>
7002
7003         * ada-lang.c (ada_exception_sal): Change addr_string to a
7004         std::string.
7005         (create_ada_exception_catchpoint): Update.
7006
7007 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7008             Tom Tromey  <tromey@adacore.com>
7009
7010         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7011         (bp_location_ops): Remove.
7012         (base_breakpoint_allocate_location): Update.
7013         (free_bp_location): Update.
7014         * ada-lang.c (class ada_catchpoint_location)
7015         <ada_catchpoint_location>: Remove ops parameter.
7016         (ada_catchpoint_location_dtor): Remove.
7017         (ada_catchpoint_location_ops): Remove.
7018         (allocate_location_exception): Update.
7019         * breakpoint.h (struct bp_location_ops): Remove.
7020         (class bp_location) <bp_location>: Remove bp_location_ops
7021         parameter.
7022         <~bp_location>: Add destructor.
7023         <ops>: Remove.
7024
7025 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7026             Pedro Alves  <palves@redhat.com>
7027
7028         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7029         'PATH_MAX'.
7030
7031 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7032             Samuel Thibault  <samuel.thibault@gnu.org>
7033             Thomas Schwinge  <thomas@codesourcery.com>
7034
7035         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7036         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7037
7038 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7039
7040         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7041         (check_empty): Use "const char *".
7042
7043         * gnu-nat.c (gnu_nat_target::detach): Instead of
7044         'detach_inferior (pid)' call
7045         'detach_inferior (find_inferior_pid (pid))'.
7046
7047         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7048         'nat/fork-inferior.o'.
7049         * gnu-nat.c: #include "nat/fork-inferior.h".
7050
7051         * gnu-nat.c (gnu_nat_target::detach): Instead of
7052         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7053         * gnu-nat.h: #include "inf-child.h".
7054         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7055         'i386_gnu_nat_target::fetch_registers'.
7056         (gnu_store_registers): Rename/move to
7057         'i386_gnu_nat_target::store_registers'.
7058
7059         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7060         * gnu-nat.h (mach_thread_info): New function.
7061         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7062
7063         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7064
7065 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7066
7067         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7068
7069 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7070
7071         * windows-nat.c (windows_add_thread): Add new parameter
7072         "main_thread_p" with default value set to false.  Update
7073         function documentation as well as all callers.
7074         (windows_delete_thread): Likewise.
7075         (fake_create_process): Update call to windows_add_thread.
7076         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7077         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7078         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7079         call to windows_delete_thread.
7080
7081 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7082
7083         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7084
7085 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7086
7087         * symfile.c (find_separate_debug_file): Use canonical path of
7088         sysroot with child_path instead of gdb_sysroot if it is valid.
7089
7090 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7091
7092         * symfile.c (find_separate_debug_file): Use child_path to
7093         determine if an object file is under a sysroot.
7094
7095 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7096
7097         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7098         unittests/child-path-selftests.c.
7099         * common/pathstuff.c (child_path): New function.
7100         * common/pathstuff.h (child_path): New prototype.
7101         * unittests/child-path-selftests.c: New file.
7102
7103 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7104
7105         * symfile.c (find_separate_debug_file): Look for separate debug
7106         files in debug directories under the sysroot.
7107
7108 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7109
7110         * symtab.h (struct minimal_symbol data_p): New const method.
7111         (struct minimal_symbol text_p): Likewise.
7112         * symtab.c (output_source_filename): Use file name style
7113         to print file name.
7114         (print_symbol_info): Likewise.
7115         (print_msymbol_info): Use address style to print addresses.
7116         Use function name style to print executable text symbols.
7117         (expand_symtab_containing_pc): Use data_p.
7118         (find_pc_sect_compunit_symtab): Likewise.
7119
7120 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7121
7122         * breakpoint.c (describe_other_breakpoints): Use address style
7123         to print addresses.
7124         (say_where): Likewise.
7125
7126 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7127
7128         * ada-typeprint.c (print_func_type): Print function name
7129         style to print function name.
7130         * c-typeprint.c (c_print_type_1): Likewise.
7131
7132 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7133
7134         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7135         for execve.
7136
7137 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7138
7139         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7140         type_stack.
7141
7142 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7143
7144         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7145         TYPE_CODE_REF types.
7146
7147 2019-02-08  Jim Wilson  <jimw@sifive.com>
7148
7149         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7150         (riscv_linux_fregset): New.
7151         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7152
7153 2019-02-07  Tom Tromey  <tom@tromey.com>
7154
7155         * thread.c (thread_cancel_execution_command): Update.
7156         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7157         methods.
7158         (struct thread_fsm_ops): Remove.
7159         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7160         (thread_fsm_should_stop, thread_fsm_return_value)
7161         (thread_fsm_set_finished, thread_fsm_finished_p)
7162         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7163         Don't declare.
7164         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7165         * infrun.c (clear_proceed_status_thread)
7166         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7167         (print_stop_event): Update.
7168         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7169         Add constructor.
7170         (step_command_fsm_ops): Remove.
7171         (new_step_command_fsm): Remove.
7172         (step_1): Update.
7173         (step_command_fsm::should_stop): Rename from
7174         step_command_fsm_should_stop.
7175         (step_command_fsm::clean_up): Rename from
7176         step_command_fsm_clean_up.
7177         (step_command_fsm::do_async_reply_reason): Rename from
7178         step_command_fsm_async_reply_reason.
7179         (struct until_next_fsm): Inherit from thread_fsm.  Add
7180         constructor.
7181         (until_next_fsm_ops): Remove.
7182         (new_until_next_fsm): Remove.
7183         (until_next_fsm::should_stop): Rename from
7184         until_next_fsm_should_stop.
7185         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7186         (until_next_fsm::do_async_reply_reason): Rename from
7187         until_next_fsm_async_reply_reason.
7188         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7189         constructor.  Change type of breakpoint.
7190         (finish_command_fsm_ops): Remove.
7191         (new_finish_command_fsm): Remove.
7192         (finish_command_fsm::should_stop): Rename from
7193         finish_command_fsm_should_stop.
7194         (finish_command_fsm::clean_up): Rename from
7195         finish_command_fsm_clean_up.
7196         (finish_command_fsm::return_value): Rename from
7197         finish_command_fsm_return_value.
7198         (finish_command_fsm::do_async_reply_reason): Rename from
7199         finish_command_fsm_async_reply_reason.
7200         (finish_command): Update.
7201         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7202         Add constructor.
7203         (call_thread_fsm_ops): Remove.
7204         (call_thread_fsm::call_thread_fsm): Rename from
7205         new_call_thread_fsm.
7206         (call_thread_fsm::should_stop): Rename from
7207         call_thread_fsm_should_stop.
7208         (call_thread_fsm::should_notify_stop): Rename from
7209         call_thread_fsm_should_notify_stop.
7210         (run_inferior_call, call_function_by_hand_dummy): Update.
7211         * cli/cli-interp.c (should_print_stop_to_console): Update.
7212         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7213         Add constructor.  Change type of location_breakpoint,
7214         caller_breakpoint.
7215         (until_break_fsm_ops): Remove.
7216         (new_until_break_fsm): Remove.
7217         (until_break_fsm::should_stop): Rename from
7218         until_break_fsm_should_stop.
7219         (until_break_fsm::clean_up): Rename from
7220         until_break_fsm_clean_up.
7221         (until_break_fsm::do_async_reply_reason): Rename from
7222         until_break_fsm_async_reply_reason.
7223         (until_break_command): Update.
7224         * thread-fsm.c: Remove.
7225         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7226
7227 2019-02-07  Tom Tromey  <tom@tromey.com>
7228
7229         * yy-remap.h: Add include guard.
7230         * xtensa-tdep.h: Add include guard.
7231         * xcoffread.h: Rename include guard.
7232         * varobj-iter.h: Add include guard.
7233         * tui/tui.h: Rename include guard.
7234         * tui/tui-winsource.h: Rename include guard.
7235         * tui/tui-wingeneral.h: Rename include guard.
7236         * tui/tui-windata.h: Rename include guard.
7237         * tui/tui-win.h: Rename include guard.
7238         * tui/tui-stack.h: Rename include guard.
7239         * tui/tui-source.h: Rename include guard.
7240         * tui/tui-regs.h: Rename include guard.
7241         * tui/tui-out.h: Rename include guard.
7242         * tui/tui-layout.h: Rename include guard.
7243         * tui/tui-io.h: Rename include guard.
7244         * tui/tui-hooks.h: Rename include guard.
7245         * tui/tui-file.h: Rename include guard.
7246         * tui/tui-disasm.h: Rename include guard.
7247         * tui/tui-data.h: Rename include guard.
7248         * tui/tui-command.h: Rename include guard.
7249         * tic6x-tdep.h: Add include guard.
7250         * target/waitstatus.h: Rename include guard.
7251         * target/wait.h: Rename include guard.
7252         * target/target.h: Rename include guard.
7253         * target/resume.h: Rename include guard.
7254         * target-float.h: Rename include guard.
7255         * stabsread.h: Add include guard.
7256         * rs6000-tdep.h: Add include guard.
7257         * riscv-fbsd-tdep.h: Add include guard.
7258         * regformats/regdef.h: Rename include guard.
7259         * record.h: Rename include guard.
7260         * python/python.h: Rename include guard.
7261         * python/python-internal.h: Rename include guard.
7262         * python/py-stopevent.h: Rename include guard.
7263         * python/py-ref.h: Rename include guard.
7264         * python/py-record.h: Rename include guard.
7265         * python/py-record-full.h: Rename include guard.
7266         * python/py-record-btrace.h: Rename include guard.
7267         * python/py-instruction.h: Rename include guard.
7268         * python/py-events.h: Rename include guard.
7269         * python/py-event.h: Rename include guard.
7270         * procfs.h: Add include guard.
7271         * proc-utils.h: Add include guard.
7272         * p-lang.h: Add include guard.
7273         * or1k-tdep.h: Rename include guard.
7274         * observable.h: Rename include guard.
7275         * nto-tdep.h: Rename include guard.
7276         * nat/x86-linux.h: Rename include guard.
7277         * nat/x86-linux-dregs.h: Rename include guard.
7278         * nat/x86-gcc-cpuid.h: Add include guard.
7279         * nat/x86-dregs.h: Rename include guard.
7280         * nat/x86-cpuid.h: Rename include guard.
7281         * nat/ppc-linux.h: Rename include guard.
7282         * nat/mips-linux-watch.h: Rename include guard.
7283         * nat/linux-waitpid.h: Rename include guard.
7284         * nat/linux-ptrace.h: Rename include guard.
7285         * nat/linux-procfs.h: Rename include guard.
7286         * nat/linux-osdata.h: Rename include guard.
7287         * nat/linux-nat.h: Rename include guard.
7288         * nat/linux-namespaces.h: Rename include guard.
7289         * nat/linux-btrace.h: Rename include guard.
7290         * nat/glibc_thread_db.h: Rename include guard.
7291         * nat/gdb_thread_db.h: Rename include guard.
7292         * nat/gdb_ptrace.h: Rename include guard.
7293         * nat/fork-inferior.h: Rename include guard.
7294         * nat/amd64-linux-siginfo.h: Rename include guard.
7295         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7296         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7297         * nat/aarch64-linux.h: Rename include guard.
7298         * nat/aarch64-linux-hw-point.h: Rename include guard.
7299         * mn10300-tdep.h: Add include guard.
7300         * mips-linux-tdep.h: Add include guard.
7301         * mi/mi-parse.h: Rename include guard.
7302         * mi/mi-out.h: Rename include guard.
7303         * mi/mi-main.h: Rename include guard.
7304         * mi/mi-interp.h: Rename include guard.
7305         * mi/mi-getopt.h: Rename include guard.
7306         * mi/mi-console.h: Rename include guard.
7307         * mi/mi-common.h: Rename include guard.
7308         * mi/mi-cmds.h: Rename include guard.
7309         * mi/mi-cmd-break.h: Rename include guard.
7310         * m2-lang.h: Add include guard.
7311         * location.h: Rename include guard.
7312         * linux-record.h: Rename include guard.
7313         * linux-nat.h: Add include guard.
7314         * linux-fork.h: Add include guard.
7315         * i386-darwin-tdep.h: Rename include guard.
7316         * hppa-linux-offsets.h: Add include guard.
7317         * guile/guile.h: Rename include guard.
7318         * guile/guile-internal.h: Rename include guard.
7319         * gnu-nat.h: Rename include guard.
7320         * gdb-stabs.h: Rename include guard.
7321         * frv-tdep.h: Add include guard.
7322         * f-lang.h: Add include guard.
7323         * event-loop.h: Add include guard.
7324         * darwin-nat.h: Rename include guard.
7325         * cp-abi.h: Rename include guard.
7326         * config/sparc/nm-sol2.h: Rename include guard.
7327         * config/nm-nto.h: Rename include guard.
7328         * config/nm-linux.h: Add include guard.
7329         * config/i386/nm-i386gnu.h: Rename include guard.
7330         * config/djgpp/nl_types.h: Rename include guard.
7331         * config/djgpp/langinfo.h: Rename include guard.
7332         * compile/gcc-cp-plugin.h: Add include guard.
7333         * compile/gcc-c-plugin.h: Add include guard.
7334         * compile/compile.h: Rename include guard.
7335         * compile/compile-object-run.h: Rename include guard.
7336         * compile/compile-object-load.h: Rename include guard.
7337         * compile/compile-internal.h: Rename include guard.
7338         * compile/compile-cplus.h: Rename include guard.
7339         * compile/compile-c.h: Rename include guard.
7340         * common/xml-utils.h: Rename include guard.
7341         * common/x86-xstate.h: Rename include guard.
7342         * common/version.h: Rename include guard.
7343         * common/vec.h: Rename include guard.
7344         * common/tdesc.h: Rename include guard.
7345         * common/selftest.h: Rename include guard.
7346         * common/scoped_restore.h: Rename include guard.
7347         * common/scoped_mmap.h: Rename include guard.
7348         * common/scoped_fd.h: Rename include guard.
7349         * common/safe-iterator.h: Rename include guard.
7350         * common/run-time-clock.h: Rename include guard.
7351         * common/refcounted-object.h: Rename include guard.
7352         * common/queue.h: Rename include guard.
7353         * common/ptid.h: Rename include guard.
7354         * common/print-utils.h: Rename include guard.
7355         * common/preprocessor.h: Rename include guard.
7356         * common/pathstuff.h: Rename include guard.
7357         * common/observable.h: Rename include guard.
7358         * common/netstuff.h: Rename include guard.
7359         * common/job-control.h: Rename include guard.
7360         * common/host-defs.h: Rename include guard.
7361         * common/gdb_wait.h: Rename include guard.
7362         * common/gdb_vecs.h: Rename include guard.
7363         * common/gdb_unlinker.h: Rename include guard.
7364         * common/gdb_unique_ptr.h: Rename include guard.
7365         * common/gdb_tilde_expand.h: Rename include guard.
7366         * common/gdb_sys_time.h: Rename include guard.
7367         * common/gdb_string_view.h: Rename include guard.
7368         * common/gdb_splay_tree.h: Rename include guard.
7369         * common/gdb_setjmp.h: Rename include guard.
7370         * common/gdb_ref_ptr.h: Rename include guard.
7371         * common/gdb_optional.h: Rename include guard.
7372         * common/gdb_locale.h: Rename include guard.
7373         * common/gdb_assert.h: Rename include guard.
7374         * common/filtered-iterator.h: Rename include guard.
7375         * common/filestuff.h: Rename include guard.
7376         * common/fileio.h: Rename include guard.
7377         * common/environ.h: Rename include guard.
7378         * common/common-utils.h: Rename include guard.
7379         * common/common-types.h: Rename include guard.
7380         * common/common-regcache.h: Rename include guard.
7381         * common/common-inferior.h: Rename include guard.
7382         * common/common-gdbthread.h: Rename include guard.
7383         * common/common-exceptions.h: Rename include guard.
7384         * common/common-defs.h: Rename include guard.
7385         * common/common-debug.h: Rename include guard.
7386         * common/cleanups.h: Rename include guard.
7387         * common/buffer.h: Rename include guard.
7388         * common/btrace-common.h: Rename include guard.
7389         * common/break-common.h: Rename include guard.
7390         * cli/cli-utils.h: Rename include guard.
7391         * cli/cli-style.h: Rename include guard.
7392         * cli/cli-setshow.h: Rename include guard.
7393         * cli/cli-script.h: Rename include guard.
7394         * cli/cli-interp.h: Rename include guard.
7395         * cli/cli-decode.h: Rename include guard.
7396         * cli/cli-cmds.h: Rename include guard.
7397         * charset-list.h: Add include guard.
7398         * buildsym-legacy.h: Rename include guard.
7399         * bfin-tdep.h: Add include guard.
7400         * ax.h: Rename include guard.
7401         * arm-linux-tdep.h: Add include guard.
7402         * arm-fbsd-tdep.h: Add include guard.
7403         * arch/xtensa.h: Rename include guard.
7404         * arch/tic6x.h: Add include guard.
7405         * arch/i386.h: Add include guard.
7406         * arch/arm.h: Rename include guard.
7407         * arch/arm-linux.h: Rename include guard.
7408         * arch/arm-get-next-pcs.h: Rename include guard.
7409         * arch/amd64.h: Add include guard.
7410         * arch/aarch64-insn.h: Rename include guard.
7411         * arch-utils.h: Rename include guard.
7412         * annotate.h: Add include guard.
7413         * amd64-darwin-tdep.h: Rename include guard.
7414         * aarch64-linux-tdep.h: Add include guard.
7415         * aarch64-fbsd-tdep.h: Add include guard.
7416         * aarch32-linux-nat.h: Add include guard.
7417
7418 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419
7420         * macrotab.c (macro_define_internal): New function that
7421         factorizes macro_define_object_internal and macro_define_function
7422         code.
7423         (macro_define_object_internal): Use macro_define_internal.
7424         (macro_define_function): Likewise.
7425
7426 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7427
7428         * macrocmd.c (extract_identifier): Return
7429         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7430         callers.
7431
7432 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7433
7434         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7435
7436 2019-02-05  Tom Tromey  <tom@tromey.com>
7437
7438         * target.c (target_stack::unpush): Move assertion earlier.
7439
7440 2019-01-30  Tom Tromey  <tom@tromey.com>
7441
7442         PR python/23615:
7443         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7444         (gdbpy_parse_and_eval): Likewise.
7445         * python/python-internal.h (gdbpy_allow_threads): New class.
7446
7447 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7448
7449         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7450         (aarch64_fbsd_fpregmap): Move earlier.
7451         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7452         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7453         instead of individual calls to trad_frame_set_reg_addr.
7454         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7455         earlier.
7456         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7457         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7458         instead of individual calls to trad_frame_set_reg_addr.
7459
7460 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7461
7462         * CONTRIBUTE: Replace contribution list with wiki link.
7463
7464 2019-01-25  Tom Tromey  <tom@tromey.com>
7465
7466         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7467
7468 2019-01-25  Tom Tromey  <tom@tromey.com>
7469
7470         * xtensa-linux-nat.c: Fix common/ includes.
7471         * xml-support.h: Fix common/ includes.
7472         * xml-support.c: Fix common/ includes.
7473         * x86-linux-nat.c: Fix common/ includes.
7474         * windows-nat.c: Fix common/ includes.
7475         * varobj.h: Fix common/ includes.
7476         * varobj.c: Fix common/ includes.
7477         * value.c: Fix common/ includes.
7478         * valops.c: Fix common/ includes.
7479         * utils.c: Fix common/ includes.
7480         * unittests/xml-utils-selftests.c: Fix common/ includes.
7481         * unittests/utils-selftests.c: Fix common/ includes.
7482         * unittests/unpack-selftests.c: Fix common/ includes.
7483         * unittests/tracepoint-selftests.c: Fix common/ includes.
7484         * unittests/style-selftests.c: Fix common/ includes.
7485         * unittests/string_view-selftests.c: Fix common/ includes.
7486         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7487         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7488         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7489         * unittests/rsp-low-selftests.c: Fix common/ includes.
7490         * unittests/parse-connection-spec-selftests.c: Fix common/
7491         includes.
7492         * unittests/optional-selftests.c: Fix common/ includes.
7493         * unittests/offset-type-selftests.c: Fix common/ includes.
7494         * unittests/observable-selftests.c: Fix common/ includes.
7495         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7496         * unittests/memrange-selftests.c: Fix common/ includes.
7497         * unittests/memory-map-selftests.c: Fix common/ includes.
7498         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7499         * unittests/function-view-selftests.c: Fix common/ includes.
7500         * unittests/environ-selftests.c: Fix common/ includes.
7501         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7502         * unittests/common-utils-selftests.c: Fix common/ includes.
7503         * unittests/cli-utils-selftests.c: Fix common/ includes.
7504         * unittests/array-view-selftests.c: Fix common/ includes.
7505         * ui-file.c: Fix common/ includes.
7506         * tui/tui-io.c: Fix common/ includes.
7507         * tracepoint.h: Fix common/ includes.
7508         * tracepoint.c: Fix common/ includes.
7509         * tracefile-tfile.c: Fix common/ includes.
7510         * top.h: Fix common/ includes.
7511         * top.c: Fix common/ includes.
7512         * thread.c: Fix common/ includes.
7513         * target/waitstatus.h: Fix common/ includes.
7514         * target/waitstatus.c: Fix common/ includes.
7515         * target.h: Fix common/ includes.
7516         * target.c: Fix common/ includes.
7517         * target-memory.c: Fix common/ includes.
7518         * target-descriptions.c: Fix common/ includes.
7519         * symtab.h: Fix common/ includes.
7520         * symfile.c: Fix common/ includes.
7521         * stap-probe.c: Fix common/ includes.
7522         * spu-linux-nat.c: Fix common/ includes.
7523         * sparc-nat.c: Fix common/ includes.
7524         * source.c: Fix common/ includes.
7525         * solib.c: Fix common/ includes.
7526         * solib-target.c: Fix common/ includes.
7527         * ser-unix.c: Fix common/ includes.
7528         * ser-tcp.c: Fix common/ includes.
7529         * ser-pipe.c: Fix common/ includes.
7530         * ser-base.c: Fix common/ includes.
7531         * selftest-arch.c: Fix common/ includes.
7532         * s12z-tdep.c: Fix common/ includes.
7533         * rust-exp.y: Fix common/ includes.
7534         * rs6000-aix-tdep.c: Fix common/ includes.
7535         * riscv-tdep.c: Fix common/ includes.
7536         * remote.c: Fix common/ includes.
7537         * remote-notif.h: Fix common/ includes.
7538         * remote-fileio.h: Fix common/ includes.
7539         * remote-fileio.c: Fix common/ includes.
7540         * regcache.h: Fix common/ includes.
7541         * regcache.c: Fix common/ includes.
7542         * record-btrace.c: Fix common/ includes.
7543         * python/python.c: Fix common/ includes.
7544         * python/py-type.c: Fix common/ includes.
7545         * python/py-inferior.c: Fix common/ includes.
7546         * progspace.h: Fix common/ includes.
7547         * producer.c: Fix common/ includes.
7548         * procfs.c: Fix common/ includes.
7549         * proc-api.c: Fix common/ includes.
7550         * printcmd.c: Fix common/ includes.
7551         * ppc-linux-nat.c: Fix common/ includes.
7552         * parser-defs.h: Fix common/ includes.
7553         * osdata.c: Fix common/ includes.
7554         * obsd-nat.c: Fix common/ includes.
7555         * nat/x86-linux.c: Fix common/ includes.
7556         * nat/x86-linux-dregs.c: Fix common/ includes.
7557         * nat/x86-dregs.h: Fix common/ includes.
7558         * nat/x86-dregs.c: Fix common/ includes.
7559         * nat/ppc-linux.c: Fix common/ includes.
7560         * nat/mips-linux-watch.h: Fix common/ includes.
7561         * nat/mips-linux-watch.c: Fix common/ includes.
7562         * nat/linux-waitpid.c: Fix common/ includes.
7563         * nat/linux-ptrace.h: Fix common/ includes.
7564         * nat/linux-ptrace.c: Fix common/ includes.
7565         * nat/linux-procfs.c: Fix common/ includes.
7566         * nat/linux-personality.c: Fix common/ includes.
7567         * nat/linux-osdata.c: Fix common/ includes.
7568         * nat/linux-namespaces.c: Fix common/ includes.
7569         * nat/linux-btrace.h: Fix common/ includes.
7570         * nat/linux-btrace.c: Fix common/ includes.
7571         * nat/fork-inferior.c: Fix common/ includes.
7572         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7573         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7574         * nat/aarch64-linux.c: Fix common/ includes.
7575         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7576         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7577         * namespace.h: Fix common/ includes.
7578         * mips-linux-tdep.c: Fix common/ includes.
7579         * minsyms.c: Fix common/ includes.
7580         * mi/mi-parse.h: Fix common/ includes.
7581         * mi/mi-main.c: Fix common/ includes.
7582         * mi/mi-cmd-env.c: Fix common/ includes.
7583         * memrange.h: Fix common/ includes.
7584         * memattr.c: Fix common/ includes.
7585         * maint.h: Fix common/ includes.
7586         * maint.c: Fix common/ includes.
7587         * main.c: Fix common/ includes.
7588         * machoread.c: Fix common/ includes.
7589         * location.c: Fix common/ includes.
7590         * linux-thread-db.c: Fix common/ includes.
7591         * linux-nat.c: Fix common/ includes.
7592         * linux-fork.c: Fix common/ includes.
7593         * inline-frame.c: Fix common/ includes.
7594         * infrun.c: Fix common/ includes.
7595         * inflow.c: Fix common/ includes.
7596         * inferior.h: Fix common/ includes.
7597         * inferior.c: Fix common/ includes.
7598         * infcmd.c: Fix common/ includes.
7599         * inf-ptrace.c: Fix common/ includes.
7600         * inf-child.c: Fix common/ includes.
7601         * ia64-linux-nat.c: Fix common/ includes.
7602         * i387-tdep.c: Fix common/ includes.
7603         * i386-tdep.c: Fix common/ includes.
7604         * i386-linux-tdep.c: Fix common/ includes.
7605         * i386-linux-nat.c: Fix common/ includes.
7606         * i386-go32-tdep.c: Fix common/ includes.
7607         * i386-fbsd-tdep.c: Fix common/ includes.
7608         * i386-fbsd-nat.c: Fix common/ includes.
7609         * guile/scm-type.c: Fix common/ includes.
7610         * guile/guile.c: Fix common/ includes.
7611         * go32-nat.c: Fix common/ includes.
7612         * gnu-nat.c: Fix common/ includes.
7613         * gdbthread.h: Fix common/ includes.
7614         * gdbarch-selftests.c: Fix common/ includes.
7615         * gdb_usleep.c: Fix common/ includes.
7616         * gdb_select.h: Fix common/ includes.
7617         * gdb_bfd.c: Fix common/ includes.
7618         * gcore.c: Fix common/ includes.
7619         * fork-child.c: Fix common/ includes.
7620         * findvar.c: Fix common/ includes.
7621         * fbsd-nat.c: Fix common/ includes.
7622         * event-top.c: Fix common/ includes.
7623         * event-loop.c: Fix common/ includes.
7624         * dwarf2read.c: Fix common/ includes.
7625         * dwarf2loc.c: Fix common/ includes.
7626         * dwarf2-frame.c: Fix common/ includes.
7627         * dwarf-index-cache.c: Fix common/ includes.
7628         * dtrace-probe.c: Fix common/ includes.
7629         * disasm-selftests.c: Fix common/ includes.
7630         * defs.h: Fix common/ includes.
7631         * csky-tdep.c: Fix common/ includes.
7632         * cp-valprint.c: Fix common/ includes.
7633         * cp-support.h: Fix common/ includes.
7634         * cp-support.c: Fix common/ includes.
7635         * corelow.c: Fix common/ includes.
7636         * completer.h: Fix common/ includes.
7637         * completer.c: Fix common/ includes.
7638         * compile/compile.c: Fix common/ includes.
7639         * compile/compile-loc2c.c: Fix common/ includes.
7640         * compile/compile-cplus-types.c: Fix common/ includes.
7641         * compile/compile-cplus-symbols.c: Fix common/ includes.
7642         * command.h: Fix common/ includes.
7643         * cli/cli-dump.c: Fix common/ includes.
7644         * cli/cli-cmds.c: Fix common/ includes.
7645         * charset.c: Fix common/ includes.
7646         * build-id.c: Fix common/ includes.
7647         * btrace.h: Fix common/ includes.
7648         * btrace.c: Fix common/ includes.
7649         * breakpoint.h: Fix common/ includes.
7650         * breakpoint.c: Fix common/ includes.
7651         * ax.h:
7652         (enum agent_op): Fix common/ includes.
7653         * ax-general.c (struct aop_map): Fix common/ includes.
7654         * ax-gdb.c: Fix common/ includes.
7655         * auxv.c: Fix common/ includes.
7656         * auto-load.c: Fix common/ includes.
7657         * arm-tdep.c: Fix common/ includes.
7658         * arch/riscv.c: Fix common/ includes.
7659         * arch/ppc-linux-common.c: Fix common/ includes.
7660         * arch/i386.c: Fix common/ includes.
7661         * arch/arm.c: Fix common/ includes.
7662         * arch/arm-linux.c: Fix common/ includes.
7663         * arch/arm-get-next-pcs.c: Fix common/ includes.
7664         * arch/amd64.c: Fix common/ includes.
7665         * arch/aarch64.c: Fix common/ includes.
7666         * arch/aarch64-insn.c: Fix common/ includes.
7667         * arch-utils.c: Fix common/ includes.
7668         * amd64-windows-tdep.c: Fix common/ includes.
7669         * amd64-tdep.c: Fix common/ includes.
7670         * amd64-sol2-tdep.c: Fix common/ includes.
7671         * amd64-obsd-tdep.c: Fix common/ includes.
7672         * amd64-nbsd-tdep.c: Fix common/ includes.
7673         * amd64-linux-tdep.c: Fix common/ includes.
7674         * amd64-linux-nat.c: Fix common/ includes.
7675         * amd64-fbsd-tdep.c: Fix common/ includes.
7676         * amd64-fbsd-nat.c: Fix common/ includes.
7677         * amd64-dicos-tdep.c: Fix common/ includes.
7678         * amd64-darwin-tdep.c: Fix common/ includes.
7679         * agent.c: Fix common/ includes.
7680         * ada-lang.h: Fix common/ includes.
7681         * ada-lang.c: Fix common/ includes.
7682         * aarch64-tdep.c: Fix common/ includes.
7683
7684 2019-01-25  Tom Tromey  <tom@tromey.com>
7685
7686         * common/create-version.sh: Use common/version.h.
7687
7688 2019-01-24  Pedro Alves  <palves@redhat.com>
7689
7690         * infrun.c (signal_stop, signal_print, signal_program)
7691         (signal_catch, signal_pass): Now arrays instead of pointers.
7692         (update_signals_program_target, do_target_resume)
7693         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7694         * linux-nat.c (linux_nat_target::pass_signals)
7695         (linux_nat_target::create_inferior, linux_nat_target::attach):
7696         Adjust.
7697         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7698         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7699         * procfs.c (procfs_target::pass_signals): Adjust.
7700         * record-full.c (record_full_target::resume): Adjust.
7701         * remote.c (remote_target::pass_signals)
7702         (remote_target::program_signals): Adjust.
7703         * target-debug.h (target_debug_print_signals): Now takes a
7704         gdb::array_view as parameter.  Adjust.
7705         * target.h (target_ops) <pass_signals, program_signals>: Replace
7706         pointer and length parameters with gdb::array_view.
7707         (target_pass_signals, target_program_signals): Likewise.
7708         * target-delegates.c: Regenerate.
7709
7710 2019-01-24  Pedro Alves  <palves@redhat.com>
7711
7712         * common/forward-scope-exit.h
7713         (forward_scope_exit::forward_scope_exit): Pass arguments to
7714         m_bind_function directly, instead of creating a std::bind and
7715         copying that.
7716
7717 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7718
7719         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7720         for static members.
7721         (pass_in_v_vfp_candidate): Likewise.
7722
7723 2019-01-23  Tom Tromey  <tom@tromey.com>
7724             Pedro Alves  <palves@redhat.com>
7725
7726         * regcache.c (class regcache_invalidator): Remove.
7727         (regcache::raw_write): Use make_scope_exit.
7728
7729 2019-01-23  Tom Tromey  <tom@tromey.com>
7730
7731         * ui-out.h (class ui_out_emit_type): Update comment.
7732
7733 2019-01-23  Tom Tromey  <tom@tromey.com>
7734
7735         * infrun.c (fetch_inferior_event): Update comment.
7736
7737 2019-01-23  Tom Tromey  <tom@tromey.com>
7738             Pedro Alves  <palves@redhat.com>
7739
7740         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7741         parameter.
7742         (fetch_inferior_event): Use SCOPE_EXIT.
7743
7744
7745 2019-01-23  Tom Tromey  <tom@tromey.com>
7746             Pedro Alves  <palves@redhat.com>
7747
7748         * infrun.c (disable_thread_events): Delete.
7749         (stop_all_threads): Use SCOPE_EXIT.
7750
7751 2019-01-23  Tom Tromey  <tom@tromey.com>
7752             Pedro Alves  <palves@redhat.com>
7753
7754         * symfile.c: Include forward-scope-exit.h.
7755         (clear_symtab_users_cleanup): Replace forward declaration with
7756         a FORWARD_SCOPE_EXIT.
7757         (syms_from_objfile_1): Use the forward_scope_exit and
7758         gdb::optional instead of cleanup_function.
7759         (reread_symbols): Use the forward_scope_exit instead of
7760         cleanup_function.
7761         (clear_symtab_users_cleanup): Remove function.
7762
7763 2019-01-23  Tom Tromey  <tom@tromey.com>
7764             Pedro Alves  <palves@redhat.com>
7765
7766         * linux-nat.c: Include scope-exit.h.
7767         (cleanup_target_stop): Remove.
7768         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7769         SCOPE_EXIT.
7770
7771 2019-01-23  Tom Tromey  <tom@tromey.com>
7772             Pedro Alves  <palves@redhat.com>
7773
7774         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7775         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7776
7777 2019-01-23  Tom Tromey  <tom@tromey.com>
7778             Andrew Burgess  <andrew.burgess@embecosm.com>
7779             Pedro Alves  <palves@redhat.com>
7780
7781         * infrun.c (fetch_inferior_event): Use scope_exit.
7782         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7783         * top.c (execute_command): Use scope_exit.
7784         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7785         * utils.c (do_bpstat_clear_actions_cleanup)
7786         (make_bpstat_clear_actions_cleanup): Remove.
7787
7788 2019-01-23  Tom Tromey  <tom@tromey.com>
7789             Pedro Alves  <palves@redhat.com>
7790
7791         * infrun.c: Include "common/scope-exit.h"
7792         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7793         (wait_for_inferior): Use SCOPE_EXIT.
7794         (fetch_inferior_event): Use scope_exit.
7795
7796 2019-01-23  Tom Tromey  <tom@tromey.com>
7797             Pedro Alves  <palves@redhat.com>
7798
7799         * breakpoint.c (create_breakpoint): Remove cleanup.
7800
7801 2019-01-23  Tom Tromey  <tom@tromey.com>
7802             Andrew Burgess  <andrew.burgess@embecosm.com>
7803             Pedro Alves  <palves@redhat.com>
7804
7805 2019-01-23  Pedro Alves  <palves@redhat.com>
7806
7807         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7808
7809 2019-01-23  Pedro Alves  <palves@redhat.com>
7810             Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * gdbthread.h: Include "common/forward-scope-exit.h".
7813         (scoped_finish_thread_state): Redefine custom class in terms of
7814         forward_scope_exit.
7815
7816 2019-01-23  Pedro Alves  <palves@redhat.com>
7817             Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * common/forward-scope-exit.h: New file.
7820
7821 2019-01-23  Pedro Alves  <palves@redhat.com>
7822             Andrew Burgess  <andrew.burgess@embecosm.com>
7823             Tom Tromey  <tom@tromey.com>
7824
7825         * common/scope-exit.h: New file.
7826
7827 2019-01-23  Pedro Alves  <palves@redhat.com>
7828
7829         * common/preprocessor.h (ESC): Rename to ...
7830         (ESC_PARENS): ... this.
7831         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7832         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7833
7834 2019-01-23  Tom Tromey  <tom@tromey.com>
7835
7836         * language.h (class scoped_switch_to_sym_language_if_auto):
7837         Initialize m_lang in both cases.
7838
7839 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7840
7841         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7842         with XCNEW.
7843
7844 2019-01-22  Tom Tromey  <tom@tromey.com>
7845
7846         * corelow.c: Do not include sys/file.h.
7847
7848 2019-01-22  Tom Tromey  <tom@tromey.com>
7849
7850         * tui/tui-wingeneral.h: Include gdb_curses.h.
7851
7852 2019-01-22  Tom Tromey  <tom@tromey.com>
7853
7854         * source-cache.h (class source_cache) <get_source_lines,
7855         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7856
7857 2019-01-22  Tom Tromey  <tom@tromey.com>
7858
7859         * remote-fileio.h (struct remote_target): Declare.
7860
7861 2019-01-22  Tom Tromey  <tom@tromey.com>
7862
7863         * python/py-arch.c: Do not include py-ref.h.
7864         * python/py-bpevent.c: Do not include py-ref.h.
7865         * python/py-cmd.c: Do not include py-ref.h.
7866         * python/py-continueevent.c: Do not include py-ref.h.
7867         * python/py-event.h: Do not include py-ref.h.
7868         * python/py-evtregistry.c: Do not include py-ref.h.
7869         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7870         * python/py-frame.c: Do not include py-ref.h.
7871         * python/py-framefilter.c: Do not include py-ref.h.
7872         * python/py-function.c: Do not include py-ref.h.
7873         * python/py-infevents.c: Do not include py-ref.h.
7874         * python/py-linetable.c: Do not include py-ref.h.
7875         * python/py-objfile.c: Do not include py-ref.h.
7876         * python/py-param.c: Do not include py-ref.h.
7877         * python/py-prettyprint.c: Do not include py-ref.h.
7878         * python/py-progspace.c: Do not include py-ref.h.
7879         * python/py-symbol.c: Do not include py-ref.h.
7880         * python/py-symtab.c: Do not include py-ref.h.
7881         * python/py-type.c: Do not include py-ref.h.
7882         * python/py-unwind.c: Do not include py-ref.h.
7883         * python/py-utils.c: Do not include py-ref.h.
7884         * python/py-value.c: Do not include py-ref.h.
7885         * python/py-varobj.c: Do not include py-ref.h.
7886         * python/py-xmethods.c: Do not include py-ref.h.
7887         * python/python.c: Do not include py-ref.h.
7888         * varobj.c: Do not include py-ref.h.
7889
7890 2019-01-22  Tom Tromey  <tom@tromey.com>
7891
7892         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7893         keyword for bcache.
7894
7895 2019-01-22  Tom Tromey  <tom@tromey.com>
7896
7897         * compile/compile-cplus-types.c: Remove a comment by #include.
7898
7899 2019-01-22  Tom Tromey  <tom@tromey.com>
7900
7901         * compile/gcc-c-plugin.h: Include compile-internal.h.
7902
7903 2019-01-22  Tom Tromey  <tom@tromey.com>
7904
7905         * stabsread.c (EXTERN): Do not define.
7906         (symnum, next_symbol_text_func, processing_gcc_compilation)
7907         (within_function, global_sym_chain, global_stabs)
7908         (previous_stab_code, this_object_header_files)
7909         (n_this_object_header_files)
7910         (n_allocated_this_object_header_files): Define.
7911         * stabsread.h (EXTERN): Never define.  Use "extern".
7912
7913 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7914
7915         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7916         history_value.
7917
7918 2019-01-21  Tom Tromey  <tom@tromey.com>
7919
7920         * ui-out.c: Fix includes.
7921         * tui/tui-source.c: Fix includes.
7922         * target.c: Fix includes.
7923         * remote.c: Fix includes.
7924         * regcache.c: Fix includes.
7925         * python/py-block.c: Fix includes.
7926         * printcmd.c: Fix includes.
7927         * or1k-tdep.c: Fix includes.
7928         * mi/mi-main.c: Fix includes.
7929         * m32r-tdep.c: Fix includes.
7930         * csky-tdep.c: Fix includes.
7931         * compile/compile-cplus-types.c: Fix includes.
7932         * cli/cli-interp.c: Fix includes.
7933
7934 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7935
7936         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7937         for padding.
7938
7939 2019-01-16  Tom Tromey  <tom@tromey.com>
7940
7941         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7942         earlier.
7943         (struct objfile) <msymbols_range>: Move from top level.
7944         <msymbols>: New method.
7945         (class objfile_msymbols): Remove.
7946         * symtab.c (default_collect_symbol_completion_matches_break_on):
7947         Update.
7948         * symmisc.c (dump_msymbols): Update.
7949         * stabsread.c (scan_file_globals): Update.
7950         * objc-lang.c (info_selectors_command, info_classes_command)
7951         (find_methods): Update.
7952         * minsyms.c (find_solib_trampoline_target): Update.
7953         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7954         * coffread.c (coff_symfile_read): Update.
7955         * ada-lang.c (ada_lookup_simple_minsym)
7956         (ada_collect_symbol_completion_matches): Update.
7957
7958 2019-01-16  Tom Tromey  <tom@tromey.com>
7959
7960         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7961         type.  Remove no-argument constructor.
7962         <iterator::operator++>: Simplify.
7963         <begin>: Update.
7964         <end>: Use minimal_symbol_count.
7965
7966 2019-01-16  Tom Tromey  <tom@tromey.com>
7967
7968         * objfiles.h (struct objfile) <psymtabs>: New method.
7969         (class objfile_psymtabs): Remove.
7970         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7971         typedef.
7972         <range>: New method.
7973         (require_partial_symbols): Change return type.
7974         * psymtab.c (require_partial_symbols)
7975         (psym_expand_symtabs_matching): Update.
7976         * mdebugread.c (parse_partial_symbols): Update.
7977         * dbxread.c (dbx_end_psymtab): Update.
7978
7979 2019-01-15  Tom Tromey  <tom@tromey.com>
7980
7981         * symtab.c (lookup_objfile_from_block)
7982         (lookup_symbol_in_objfile_symtabs)
7983         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7984         (find_line_symtab, info_sources_command)
7985         (default_collect_symbol_completion_matches_break_on)
7986         (make_source_files_completion_list): Update.
7987         * symmisc.c (print_objfile_statistics, dump_objfile)
7988         (maintenance_print_symbols, maintenance_info_symtabs)
7989         (maintenance_check_symtabs, maintenance_info_line_tables):
7990         Update.
7991         * source.c (select_source_symtab)
7992         (forget_cached_source_info_for_objfile): Update.
7993         * objfiles.h (class objfile_compunits): Remove.
7994         (struct objfile) <compunits_range>: New typedef.
7995         (compunits): New method.
7996         * objfiles.c (objfile_relocate1): Update.
7997         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7998         * maint.c (count_symtabs_and_blocks): Update.
7999         * linespec.c (iterate_over_all_matching_symtabs): Update.
8000         * cp-support.c (add_symbol_overload_list_qualified): Update.
8001         * coffread.c (coff_symtab_read): Update.
8002         * ada-lang.c (add_nonlocal_symbols)
8003         (ada_collect_symbol_completion_matches)
8004         (ada_add_global_exceptions): Update.
8005
8006 2019-01-15  Tom Tromey  <tom@tromey.com>
8007
8008         * progspace.h (program_space) <objfiles_safe_range>: New
8009         typedef.
8010         <objfiles_safe>: New method.
8011         * objfiles.h (class all_objfiles_safe): Remove.
8012         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8013         * jit.c (jit_inferior_exit_hook): Update.
8014
8015 2019-01-17  Tom Tromey  <tom@tromey.com>
8016
8017         * progspace.h (program_space) <objfiles_range>: New typedef.
8018         <objfiles>: New method.
8019         <objfiles_head>: Rename from objfiles.
8020         (object_files): Update.
8021         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8022         * guile/scm-pretty-print.c
8023         (ppscm_find_pretty_printer_from_objfiles): Update.
8024         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8025         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8026         Update.
8027         * python/py-progspace.c (pspy_get_objfiles): Update.
8028         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8029         Update.
8030         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8031         (objfpy_lookup_objfile_by_build_id): Update.
8032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8033         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8034         Update.
8035         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8036         (expand_symtab_containing_pc, lookup_objfile_from_block)
8037         (lookup_static_symbol, basic_lookup_transparent_type)
8038         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8039         (find_line_symtab, info_sources_command)
8040         (default_collect_symbol_completion_matches_break_on)
8041         (make_source_files_completion_list, find_main_name): Update.
8042         * symmisc.c (print_symbol_bcache_statistics)
8043         (print_objfile_statistics, maintenance_print_symbols)
8044         (maintenance_print_msymbols, maintenance_print_objfiles)
8045         (maintenance_info_symtabs, maintenance_check_symtabs)
8046         (maintenance_expand_symtabs, maintenance_info_line_tables):
8047         Update.
8048         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8049         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8050         (map_overlay_command, unmap_overlay_command)
8051         (simple_overlay_update, expand_symtabs_matching)
8052         (map_symbol_filenames): Update.
8053         * symfile-debug.c (set_debug_symfile): Update.
8054         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8055         Update.
8056         * source.c (select_source_symtab, forget_cached_source_info):
8057         Update.
8058         * solib.c (solib_read_symbols): Update.
8059         * solib-spu.c (append_ocl_sos): Update.
8060         * psymtab.c (maintenance_print_psymbols)
8061         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8062         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8063         * printcmd.c (info_symbol_command): Update.
8064         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8065         Update.
8066         * objfiles.h (class all_objfiles): Remove.
8067         * objfiles.c (have_partial_symbols, have_full_symbols)
8068         (have_minimal_symbols, qsort_cmp, update_section_map)
8069         (shared_objfile_contains_address_p)
8070         (default_iterate_over_objfiles_in_search_order): Update.
8071         * objc-lang.c (info_selectors_command, info_classes_command)
8072         (find_methods): Update.
8073         * minsyms.c (find_solib_trampoline_target): Update.
8074         * maint.c (maintenance_info_sections)
8075         (maintenance_translate_address, count_symtabs_and_blocks):
8076         Update.
8077         * main.c (captured_main_1): Update.
8078         * linux-thread-db.c (try_thread_db_load_from_pdir)
8079         (has_libpthread): Update.
8080         * linespec.c (iterate_over_all_matching_symtabs)
8081         (search_minsyms_for_name): Update.
8082         * jit.c (jit_find_objf_with_entry_addr): Update.
8083         * hppa-tdep.c (find_unwind_entry)
8084         (hppa_lookup_stub_minimal_symbol): Update.
8085         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8086         Update.
8087         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8088         (elf_gnu_ifunc_resolve_by_got): Update.
8089         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8090         * dwarf-index-write.c (save_gdb_index_command): Update.
8091         * cp-support.c (add_symbol_overload_list_qualified): Update.
8092         * breakpoint.c (create_overlay_event_breakpoint)
8093         (create_longjmp_master_breakpoint)
8094         (create_std_terminate_master_breakpoint)
8095         (create_exception_master_breakpoint): Update.
8096         * blockframe.c (find_pc_partial_function): Update.
8097         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8098         (ada_collect_symbol_completion_matches)
8099         (ada_add_global_exceptions): Update.
8100
8101 2019-01-17  Tom Tromey  <tom@tromey.com>
8102
8103         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8104         declare VEC.
8105         (solib_target_parse_libraries): Change return type.
8106         (library_list_start_segment, library_list_start_section)
8107         (library_list_end_library, library_list_start_library); Update.
8108         (solib_target_free_library_list): Remove.
8109         (solib_target_parse_libraries): Remove cleanup.  Change return
8110         type.
8111         (solib_target_current_sos): Update.
8112
8113 2019-01-17  Tom Tromey  <tromey@bapiya>
8114
8115         * valprint.c: Replace "the the" with "the".
8116         * symtab.c: Replace "the the" with "the".
8117         * solib.c: Replace "the the" with "the".
8118         * solib-dsbt.c: Replace "the the" with "the".
8119         * linespec.c: Replace "the the" with "the".
8120         * dwarf2loc.h: Replace "the the" with "the".
8121         * amd64-windows-tdep.c: Replace "the the" with "the".
8122         * aarch64-tdep.c: Replace "the the" with "the".
8123
8124 2019-01-16  Keith Seitz  <keiths@redhat.com>
8125
8126         PR gdb/23773
8127         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8128         <builder>: Rename to ..
8129         <m_builder>: ... this and make private.
8130         (dwarf2_cu::get_builder): New method.  Change all users of
8131         `builder' to use this method.
8132         (dwarf2_start_symtab): Move to ...
8133         (dwarf2_cu::start_symtab): ... here.  Update all callers
8134         (setup_type_unit_groups): Move to ...
8135         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8136         callers.
8137         (dwarf2_cu::reset_builder): New method.
8138         (process_full_compunit, process_full_type_unit): Use
8139         dwarf2_cu::reset_builder.
8140         (follow_die_offset): Record the ancestor CU if it is different
8141         from the followed DIE's CU.
8142         (follow_die_sig_1): Likewise.
8143
8144 2019-01-15  Tom Tromey  <tom@tromey.com>
8145
8146         * remote.c (class remote_state) <buf>: Now a char_vector.
8147         <buf_size>: Remove.
8148         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8149         parameter.
8150         (remote_target::getpkt_or_notif_sane_1)
8151         (remote_target::getpkt_sane)
8152         (remote_target::getpkt_or_notif_sane): Likewise.
8153         (class remote_target) <putpkt>: New overload.
8154         (remote_target::read_frame): Change type of "buf_p".  Remove
8155         sizeof_p parameter.
8156         (packet_ok): New overload.
8157         (packet_check_result): New overload.
8158         Update all uses.
8159
8160 2019-01-14  Tom Tromey  <tom@tromey.com>
8161
8162         * remote-notif.c (handle_notification, remote_notif_ack)
8163         (remote_notif_parse): Make "buf" const.
8164         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8165         const.
8166         (remote_notif_parse, remote_notif_ack, handle_notification):
8167         Likewise.
8168         * remote.c (remote_notif_stop_parse): Make "buf" const.
8169         (remote_target::remote_parse_stop_reply): Make "buf" const.
8170         (remote_notif_stop_ack): Make "buf" const.
8171
8172 2019-01-14  Tom Tromey  <tom@tromey.com>
8173
8174         * remote.c (remote_console_output): Make parameter const.
8175
8176 2019-01-14  Tom Tromey  <tom@tromey.com>
8177
8178         * target-debug.h (target_debug_print_signals): Constify.
8179         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8180         * procfs.c (procfs_target::pass_signals): Update.
8181         * linux-nat.c (linux_nat_target::pass_signals): Update.
8182         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8183         * target-delegates.c: Rebuild.
8184         * remote.c (remote_target::program_signals): Update.
8185         (remote_target::pass_signals): Update.
8186         * target.c (target_pass_signals): Constify argument.
8187         (target_program_signals): Likewise.
8188         * target.h (struct target_ops) <pass_signals, program_signals>:
8189         Constify argument.
8190         (target_pass_signals, target_program_signals): Constify argument.
8191
8192 2019-01-14  Tom Tromey  <tom@tromey.com>
8193
8194         PR tui/28819:
8195         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8196
8197 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8198
8199         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8200         field.
8201         * rs6000-tdep.c: Include reggroups.h.
8202         (IS_V_ALIAS_PSEUDOREG): Define.
8203         (rs6000_register_name): Return names for the "vX" aliases.
8204         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8205         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8206         aliases.  Call default_register_reggroup_p for all other
8207         pseudo-registers.
8208         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8209         New functions.
8210         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8211         Handle "vX" aliases.
8212         (v_alias_pseudo_register_collect): New function.
8213         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8214         (rs6000_gdbarch_init): Initialize "vX" aliases as
8215         pseudo-registers.  Restore registration of
8216         rs6000_pseudo_register_reggroup_p with
8217         set_tdesc_pseudo_register_reggroup_p.
8218
8219 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8220
8221         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8222         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8223         set_gdbarch_num_pseudo_regs.
8224
8225 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8226
8227         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8228         Remove arg prefixname, add do_set and do_show.
8229         Add member functions set_list and show_list.
8230         * cli/cli-style.c (class cli_style_option): Update accordingly.
8231         (style_set_list): Move to file scope.
8232         (style_show_list): Likewise.
8233         (set_style): Call help_list.
8234         (show_style): Call cmd_show_list.
8235         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8236         Update to use the new macro.
8237
8238 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8239
8240         * ada-lang.c (_initialize_ada_language): Expand the help text
8241         for the "catch exception" command.
8242
8243 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8244
8245         * symtab.c (matching_obj_sections): Initialize obj,
8246         declare it closer to its usage.
8247
8248 2019-01-10  Tom Tromey  <tom@tromey.com>
8249
8250         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8251         (basic_inf_threads_range): Remove.
8252         (inf_threads_range, inf_non_exited_threads_range)
8253         (safe_inf_threads_range): Use next_adapter.
8254
8255 2019-01-10  Keith Seitz  <keiths@redhat.com>
8256
8257         PR gdb/23712
8258         PR symtab/23010
8259         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8260         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8261
8262 2019-01-10  Keith Seitz  <keiths@redhat.com>
8263
8264         PR gdb/23712
8265         PR symtab/23010
8266         * dictionary.c (pending_to_vector): Remove.
8267         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8268         Remove _1 suffix, replacing functions of the same name.  Update
8269         all callers.
8270         (dict_create_hashed, dict_create_hashed_expandable)
8271         (dict_create_linear, dict_create_linear_expandable, dict_free)
8272         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8273         Make functions static.
8274
8275 2019-01-10  Keith Seitz  <keiths@redhat.com>
8276
8277         PR gdb/23712
8278         PR symtab/23010
8279         * dictionary.h (struct dictionary): Replace declaration with
8280         multidictionary.
8281         (dict_create_hashed, dict_create_hashed_expandable)
8282         (dict_create_linear, dict_create_linear_expandable)
8283         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8284         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8285         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8286         taking multidictionary argument.
8287         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8288         * block.h (struct block) <dict>: Change to multidictionary
8289         and rename `multidict'.
8290         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8291         symmisc.c: Update all dictionary references to multidictionary.
8292
8293 2019-01-10  Keith Seitz  <keiths@redhat.com>
8294
8295         PR gdb/23712
8296         PR symtab/23010
8297         * dictionary.c: Include unordered_map.
8298         (pending_to_vector): New function.
8299         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8300         Rewrite the non-"_1" functions to take vector instead
8301         of linked list.
8302         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8303         "new" _1 versions of the same name.
8304         (multidictionary): Define.
8305         (std::hash<enum language): New definition.
8306         (collate_pending_symbols_by_language, mdict_create_hashed)
8307         (mdict_create_hashed_expandable, mdict_create_linear)
8308         (mdict_create_linear_expandable, mdict_free)
8309         (find_language_dictionary, create_new_language_dictionary)
8310         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8311         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8312         (mdict_size, mdict_empty): New functions.
8313         * dictionary.h (mdict_iterator): Define.
8314
8315 2019-01-10  Pedro Alves  <palves@redhat.com>
8316
8317         * breakpoint.c (read_uploaded_action)
8318         (create_tracepoint_from_upload): Adjust to use
8319         gdb::unique_xmalloc_ptr.
8320         * ctf.c (ctf_write_uploaded_tp):
8321         (SET_ARRAY_FIELD): Use emplace_back.
8322         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8323         * tracefile-tfile.c (tfile_write_uploaded_tp):
8324         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8325         gdb::unique_xmalloc_ptr.
8326         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8327         at_string, cond_string, cmd_strings>: Replace char pointers
8328         with gdb::unique_xmalloc_ptr.
8329
8330 2019-01-10  Pedro Alves  <palves@redhat.com>
8331
8332         * solib-target.c (library_list_start_library): Don't xstrdup name.
8333
8334 2019-01-10  Pedro Alves  <palves@redhat.com>
8335
8336         * mdebugread.c (parse_partial_symbols): Use
8337         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8338
8339 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * linux-fork.c (scoped_switch_fork_info)
8342         <~scoped_switch_fork_info>: Fix incorrect variable name.
8343
8344 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8345
8346         * linux-fork.c (scoped_switch_fork_info)
8347         <scoped_switch_fork_info>: Make explicit.
8348         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8349
8350 2019-01-10  Tom Tromey  <tom@tromey.com>
8351
8352         * objfiles.h (objfile::reset_psymtabs): Update.
8353         * objfiles.c (objfile::objfile): Update.
8354         * psymtab.h (psymtab_storage::obstack): Update.
8355         (psymtab_storage::m_obstack): Use gdb::optional.
8356         (class psymtab_storage): Update comment.  Remove objfile
8357         parameter.
8358         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8359
8360 2019-01-10  Tom Tromey  <tom@tromey.com>
8361
8362         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8363         <free_psymtabs>: Now private.
8364         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8365         (allocate_psymtab): Use new method.
8366
8367 2019-01-10  Tom Tromey  <tom@tromey.com>
8368
8369         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8370         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8371         * mdebugread.c (parse_partial_symbols): Use
8372         allocate_dependencies.
8373         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8374         allocate_dependencies.
8375         (process_psymtab_comp_unit_reader)
8376         (build_type_psymtab_dependencies): Likewise.
8377         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8378
8379 2019-01-10  Tom Tromey  <tom@tromey.com>
8380
8381         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8382         PSYMBOL_SET_LANGUAGE.
8383         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8384
8385 2019-01-10  Tom Tromey  <tom@tromey.com>
8386
8387         * psymtab.h (psymtab_storage::obstack): New method.
8388         <m_obstack>: Rename from obstack; now private.
8389         * psymtab.c (psymtab_storage): Update.
8390         * dwarf2read.c (create_addrmap_from_index)
8391         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8392         Update.
8393
8394 2019-01-10  Tom Tromey  <tom@tromey.com>
8395
8396         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8397         * objfiles.h (objfile::reset_psymtabs): New method.
8398
8399 2019-01-10  Tom Tromey  <tom@tromey.com>
8400
8401         * symmisc.c (print_symbol_bcache_statistics): Update.
8402         (print_objfile_statistics): Update.
8403         * symfile.c (reread_symbols): Update.
8404         * psymtab.h (class psymtab_storage): New.
8405         * psymtab.c (psymtab_storage): New constructor.
8406         (~psymtab_storage): New destructor.
8407         (require_partial_symbols): Update.
8408         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8409         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8410         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8411         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8412         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8413         (start_psymtab_common, end_psymtab_common)
8414         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8415         (allocate_psymtab): Update.
8416         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8417         Update.
8418         (dump_psymtab_addrmap, maintenance_print_psymbols)
8419         (maintenance_check_psymtabs): Update.
8420         (class objfile_psymtabs): Move to objfiles.h.
8421         * psympriv.h (discard_psymtab): Now inline.
8422         (psymtab_discarder::psymtab_discarder): Update.
8423         (psymtab_discarder::~psymtab_discarder): Update.
8424         (ALL_OBJFILE_PSYMTABS): Rewrite.
8425         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8426         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8427         Remove fields.
8428         <partial_symtabs>: New field.
8429         (class objfile_psymtabs): Move from psymtab.h.  Update.
8430         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8431         psymbol_cache.
8432         (objfile::~objfile): Don't destroy psymbol_cache.
8433         * mdebugread.c (parse_partial_symbols): Update.
8434         * dwarf2read.c (create_addrmap_from_index)
8435         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8436         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8437         (add_partial_subprogram, dwarf2_ranges_read): Update.
8438         * dwarf-index-write.c (write_address_map)
8439         (write_one_signatured_type, recursively_write_psymbols)
8440         (class debug_names, class debug_names, write_psymtabs_to_index):
8441         Update.
8442
8443 2019-01-10  Tom Tromey  <tom@tromey.com>
8444
8445         * symtab.h (SYMBOL_SET_NAMES): Update.
8446         (symbol_set_names): Update.
8447         (MSYMBOL_SET_NAMES): Update.
8448         * symtab.c (symbol_set_names): Change argument to be an
8449         objfile_per_bfd_storage.
8450         * psymtab.c (add_psymbol_to_bcache): Update.
8451         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8452
8453 2019-01-10  Tom Tromey  <tom@tromey.com>
8454
8455         * symtab.c (create_demangled_names_hash): Change argument to be an
8456         objfile_per_bfd_storage.
8457         (symbol_set_names): Update.
8458
8459 2019-01-10  Tom Tromey  <tom@tromey.com>
8460
8461         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8462         init_psymbol_list.
8463         * psymtab.c (init_psymbol_list): Do nothing if already called.
8464         * psympriv.h (init_psymbol_list): Add comment.
8465         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8466         init_psymbol_list.
8467         * dbxread.c (dbx_symfile_read): Unconditionally call
8468         init_psymbol_list.
8469
8470 2019-01-10  Tom Tromey  <tom@tromey.com>
8471
8472         * xcoffread.c (scan_xcoff_symtab): Update.
8473         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8474         "where".
8475         * mdebugread.c (parse_partial_symbols)
8476         (handle_psymbol_enumerators): Update.
8477         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8478         * dbxread.c (read_dbx_symtab): Update.
8479         * psympriv.h (psymbol_placement): New enum.
8480         (add_psymbol_to_list): Update.
8481
8482 2019-01-10  Tom Tromey  <tom@tromey.com>
8483
8484         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8485         static_psymbols parameters.
8486         (scan_xcoff_symtab): Update.
8487         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8488         static_psymbols parameters.
8489         * psympriv.h (start_psymtab_common): Update.
8490         * mdebugread.c (parse_partial_symbols): Update.
8491         * dwarf2read.c (create_partial_symtab): Update.
8492         * dbxread.c (read_dbx_symtab): Update.
8493         (start_psymtab): Remove global_psymbols and static_psymbols
8494         parameters.
8495
8496 2019-01-10  Tom Tromey  <tom@tromey.com>
8497
8498         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8499         * psymtab.c (allocate_psymtab): Add comment.
8500         * psympriv.h (allocate_psymtab): Add comment.
8501         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8502         initializations.
8503         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8504
8505 2019-01-10  Tom Tromey  <tom@tromey.com>
8506
8507         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8508         Don't declare.
8509         * mipsread.c: Include mdebugread.h.
8510         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8511         Declare.
8512         * elfread.c: Include mdebugread.h.
8513
8514 2019-01-09  Tom Tromey  <tom@tromey.com>
8515
8516         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8517         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8518         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8519         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8520         (psym_lookup_symbol, psym_find_last_source_symtab)
8521         (psym_forget_cached_source_info, psym_print_stats)
8522         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8523         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8524         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8525         (psym_find_compunit_symtab_by_address)
8526         (maintenance_print_psymbols, maintenance_info_psymtabs)
8527         (maintenance_check_psymtabs): Use ranged for.
8528         * psymtab.h (class objfile_psymtabs): New.
8529         (require_partial_symbols): Return objfile_psymtabs.
8530         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8531
8532 2019-01-09  Tom Tromey  <tom@tromey.com>
8533
8534         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8535         (find_pc_mapped_section, list_overlays_command)
8536         (map_overlay_command, unmap_overlay_command)
8537         (simple_overlay_update): Use all_objfiles.
8538         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8539         * printcmd.c (info_symbol_command): Use all_objfiles.
8540         * objfiles.h (ALL_OBJSECTIONS): Remove.
8541         * maint.c (maintenance_translate_address): Use all_objfiles.
8542         * gcore.c (gcore_create_callback): Use all_objfiles.
8543         (objfile_find_memory_regions): Likewise.
8544
8545 2019-01-09  Tom Tromey  <tom@tromey.com>
8546
8547         * symtab.c (find_line_symtab, info_sources_command)
8548         (make_source_files_completion_list): Use objfile_compunits.
8549         * source.c (select_source_symtab): Use objfile_compunits.
8550         * objfiles.h (struct objfile): Update comment.
8551         (ALL_OBJFILES): Remove.
8552         (ALL_FILETABS): Remove.
8553         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8554         objfile_compunits.
8555
8556 2019-01-09  Tom Tromey  <tom@tromey.com>
8557
8558         * symmisc.c (print_objfile_statistics, dump_objfile)
8559         (maintenance_print_symbols): Use compunit_filetabs.
8560         * source.c (forget_cached_source_info_for_objfile): Use
8561         compunit_filetabs.
8562         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8563         (ALL_FILETABS): Use compunit_filetabs.
8564         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8565         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8566
8567 2019-01-09  Tom Tromey  <tom@tromey.com>
8568
8569         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8570         (compunit_filetabs): New.
8571         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8572         compunit_filetabs.
8573         (info_sources_command, make_source_files_completion_list): Remove
8574         declaration.
8575         * symmisc.c (print_objfile_statistics, dump_objfile)
8576         (maintenance_print_symbols): Remove declaration.
8577         (maintenance_info_symtabs): Use compunit_filetabs.
8578         (maintenance_info_line_tables): Likewise.
8579         * source.c (select_source_symtab): Change local variable name.
8580         (forget_cached_source_info_for_objfile): Remove declaration.
8581         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8582         * objfiles.c (objfile_relocate1): Remove declaration.
8583         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8584         declaration.
8585         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8586         * coffread.c (coff_symtab_read): Remove declaration.
8587         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8588         compunit_filetabs.
8589
8590 2019-01-09  Tom Tromey  <tom@tromey.com>
8591
8592         * symtab.c (lookup_objfile_from_block)
8593         (find_pc_sect_compunit_symtab, search_symbols)
8594         (default_collect_symbol_completion_matches_break_on): Use
8595         objfile_compunits.
8596         * objfiles.h (ALL_COMPUNITS): Remove.
8597         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8598         * cp-support.c (add_symbol_overload_list_qualified): Use
8599         objfile_compunits.
8600         * ada-lang.c (ada_collect_symbol_completion_matches)
8601         (ada_add_global_exceptions): Use objfile_compunits.
8602
8603 2019-01-09  Tom Tromey  <tom@tromey.com>
8604
8605         * source.c (select_source_symtab)
8606         (forget_cached_source_info_for_objfile): Remove declaration.
8607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8608         declaration.
8609         * maint.c (count_symtabs_and_blocks): Remove declaration.
8610         * cp-support.c (add_symbol_overload_list_qualified): Remove
8611         declaration.
8612         * coffread.c (coff_symtab_read): Remove declaration.
8613         * symtab.c (lookup_symbol_in_objfile_symtabs)
8614         (basic_lookup_transparent_type_1): Use objfile_compunits.
8615         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8616         (info_sources_command, search_symbols)
8617         (default_collect_symbol_completion_matches_break_on)
8618         (make_source_files_completion_list): Remove declaration.
8619         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8620         (ada_collect_symbol_completion_matches)
8621         (ada_add_global_exceptions): Remove declaration.
8622         * linespec.c (iterate_over_all_matching_symtabs): Use
8623         objfile_compunits.
8624         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8625         (class objfile_compunits): New.
8626         (ALL_COMPUNITS): Use objfile_compunits.
8627         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8628         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8629         objfile_compunits.
8630         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8631
8632 2019-01-09  Tom Tromey  <tom@tromey.com>
8633
8634         * symtab.c (search_symbols)
8635         (default_collect_symbol_completion_matches_break_on): Use
8636         objfile_msymbols.
8637         * ada-lang.c (ada_lookup_simple_minsym)
8638         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8639         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8640         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8641         objfile_msymbols.
8642         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8643         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8644         * objc-lang.c (find_methods): Use objfile_msymbols.
8645         (info_selectors_command, info_classes_command): Likewise.
8646         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8647         * objfiles.h (class objfile_msymbols): New.
8648         (ALL_OBJFILE_MSYMBOLS): Remove.
8649         (ALL_MSYMBOLS): Remove.
8650
8651 2019-01-09  Tom Tromey  <tom@tromey.com>
8652
8653         * common/next-iterator.h (next_adapter): Add Iterator template
8654         parameter.
8655         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8656         (class all_objfiles_safe): New.
8657         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8658         * objfiles.c (put_objfile_before): Update comment.
8659         (add_separate_debug_objfile): Likewise.
8660         (free_all_objfiles): Use all_objfiles_safe.
8661         (objfile_purge_solibs): Likewise.
8662
8663 2019-01-09  Tom Tromey  <tom@tromey.com>
8664
8665         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8666         (expand_symtab_containing_pc, lookup_static_symbol)
8667         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8668         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8669         all_objfiles.
8670         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8671         * breakpoint.c (create_overlay_event_breakpoint)
8672         (create_longjmp_master_breakpoint)
8673         (create_std_terminate_master_breakpoint)
8674         (create_exception_master_breakpoint): Use all_objfiles.
8675         * linux-thread-db.c (try_thread_db_load_from_pdir)
8676         (has_libpthread): Use all_objfiles.
8677         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8678         * linespec.c (iterate_over_all_matching_symtabs)
8679         (search_minsyms_for_name): Use all_objfiles.
8680         * maint.c (maintenance_info_sections): Use all_objfiles.
8681         * main.c (captured_main_1): Use all_objfiles.
8682         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8683         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8684         * guile/scm-pretty-print.c
8685         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8686         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8687         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8688         (maintenance_print_msymbols): Use all_objfiles.
8689         * source.c (select_source_symtab): Use all_objfiles.
8690         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8691         * symfile.c (remove_symbol_file_command)
8692         (expand_symtabs_matching, map_symbol_filenames): Use
8693         all_objfiles.
8694         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8695         all_objfiles.
8696         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8697         * objc-lang.c (find_methods): Use all_objfiles.
8698         * objfiles.c (have_partial_symbols, have_full_symbols)
8699         (have_minimal_symbols, qsort_cmp)
8700         (default_iterate_over_objfiles_in_search_order): Use
8701         all_objfiles.
8702         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8703         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8704         (maintenance_check_psymtabs): Use all_objfiles.
8705         (ALL_PSYMTABS): Remove.
8706         * compile/compile-object-run.c (do_module_cleanup): Use
8707         all_objfiles.
8708         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8709         * cp-support.c (add_symbol_overload_list_qualified): Use
8710         all_objfiles.
8711         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8712         Use all_objfiles.
8713         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8714         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8715         all_objfiles.
8716         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8717         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8718         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8719         Uses all_objfiles.
8720         * solib.c (solib_read_symbols): Use all_objfiles
8721
8722 2019-01-09  Tom Tromey  <tom@tromey.com>
8723
8724         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8725         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8726         all_objfiles.
8727         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8728         * symmisc.c (print_symbol_bcache_statistics)
8729         (print_objfile_statistics, maintenance_print_objfiles)
8730         (maintenance_info_symtabs, maintenance_check_symtabs)
8731         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8732         all_objfiles.
8733         * source.c (forget_cached_source_info): Use all_objfiles.
8734         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8735         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8736         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8737         * objfiles.c (update_section_map): Use all_objfiles.
8738         (shared_objfile_contains_address_p): Likewise.
8739         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8740         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8741
8742 2019-01-09  Tom Tromey  <tom@tromey.com>
8743
8744         * common/next-iterator.h: New file.
8745         * objfiles.h (class all_objfiles): New.
8746         (struct objfile_iterator): New.
8747
8748 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8749
8750         * NEWS: Move the description of the changed "frame", "select-frame",
8751          and "info frame" commands to the Changed commands section.
8752
8753 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8754
8755         * gdbtypes.c (check_stub_method_group): Remove handling of old
8756         mangling schemes.
8757         * linespec.c (find_methods): Likewise.
8758         * stabsread.c (read_member_functions): Likewise.
8759         * valops.c (search_struct_method): Likewise.
8760         (value_struct_elt_for_reference): Likewise.
8761         * NEWS: Mention this change.
8762
8763 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8764
8765         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8766         print_source_lines.
8767         * source.c (print_source_lines_base): Update line number check.
8768         (print_source_lines): New function.
8769         (source_lines_range::source_lines_range): New function.
8770         * source.h (class source_lines_range): New class.
8771         (print_source_lines): New declaration.
8772
8773 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8774
8775         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8776
8777 2019-01-08  Tom Tromey  <tom@tromey.com>
8778             Simon Marchi  <simon.marchi@ericsson.com>
8779
8780         PR gdb/24060
8781         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8782         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8783         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8784         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8785         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8786         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8787
8788 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * source.c (select_source_symtab): Move header comment to
8791         declaration in source.h.
8792         (forget_cached_source_info_for_objfile): Likewise.
8793         (forget_cached_source_info): Likewise.
8794         (identify_source_line): Likewise.
8795         * source.h (identify_source_line): Move declaration from symtab.h
8796         and add comment from source.c
8797         (print_source_lines): Likewise.
8798         (forget_cached_source_info_for_objfile): Likewise.
8799         (forget_cached_source_info): Likewise.
8800         (select_source_symtab): Likewise.
8801         (enum print_source_lines_flag): Move definition from symtab.h.
8802         * symtab.h (identify_source_line): Move declaration to source.h.
8803         (print_source_lines): Likewise.
8804         (forget_cached_source_info_for_objfile): Likewise.
8805         (forget_cached_source_info): Likewise.
8806         (select_source_symtab): Likewise.
8807         (enum print_source_lines_flag): Move definition to source.h.
8808         * tui/tui-hooks.c: Add 'source.h' include.
8809
8810 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * source.c (print_source_lines_base): Handle requests to print
8813         reverse line number sequences, and guard against empty lines
8814         string.
8815
8816 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8817
8818         * source.c (print_source_lines_base): Fix skip of '\r' if next
8819         character is '\n'.
8820
8821 2019-01-06  Tom Tromey  <tom@tromey.com>
8822
8823         * c-exp.y (struct c_parse_state) <macro_original_text,
8824         expansion_obstack>: New member.
8825         (macro_original_text, expansion_obstack): Remove globals.
8826         (scan_macro_expansion, scanning_macro_expansion)
8827         (finished_macro_expansion): Update.
8828         (scan_macro_cleanup): Remove.
8829         (yylex, c_parse): Update.
8830
8831 2019-01-06  Tom Tromey  <tom@tromey.com>
8832
8833         * c-exp.y (struct c_parse_state) <strings>: New member.
8834         (operator_stoken): Update.
8835
8836 2019-01-06  Tom Tromey  <tom@tromey.com>
8837
8838         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8839         (union type_stack_elt) <typelist_val>: Now a pointer to
8840         std::vector.
8841         (type_stack_cleanup): Don't declare.
8842         (push_typelist): Update.
8843         * parse.c (pop_typelist): Return a std::vector.
8844         (push_typelist): Take a std::vector.
8845         (follow_types): Update.  Do not free args.
8846         (type_stack_cleanup): Remove.
8847         * c-exp.y (struct c_parse_state): New.
8848         (cpstate): New global.
8849         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8850         (nonempty_typelist): Update.
8851         (func_mod): Create a new vector.
8852         (c_parse): Create a c_parse_state.
8853         (check_parameter_typelist): Do not delete params.
8854         (function_method): Update.  Do not delete type_list.
8855
8856 2019-01-06  Tom Tromey  <tom@tromey.com>
8857
8858         PR gdb/28155:
8859         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8860         check_typedef.
8861         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8862         (print_return_value): Likewise.
8863
8864 2019-01-05  Tom Tromey  <tom@tromey.com>
8865
8866         * contrib/cleanup_check.py: Remove.
8867         * contrib/gcc-with-excheck: Remove.
8868         * contrib/exsummary.py: Remove.
8869         * contrib/excheck.py: Remove.
8870
8871 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8872
8873         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8874         NULL. Initialize tpprev to NULL instead of assigning it
8875         to NULL on the next statement.
8876         * windows-nat.c (windows_delete_thread): Remove check for
8877         main_thread_id before printing thread exit notifications.
8878         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8879         Remove thread ID check against main_thread_id.
8880         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8881         windows_delete_thread.
8882         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8883
8884 2019-01-04  Tom Tromey  <tom@tromey.com>
8885
8886         * compile/compile.c (_initialize_compile): Use upper case for
8887         metasyntactic variables.
8888         * symmisc.c (_initialize_symmisc): Use upper case for
8889         metasyntactic variables.
8890         * psymtab.c (_initialize_psymtab): Use upper case for
8891         metasyntactic variables.
8892         * demangle.c (demangle_command): Use upper case for metasyntactic
8893         variables.
8894         (_initialize_demangler): Likewise.
8895         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8896         variables.
8897
8898 2019-01-03  Tom Tromey  <tom@tromey.com>
8899
8900         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8901
8902 2019-01-03  Tom Tromey  <tom@tromey.com>
8903
8904         * python/py-symtab.c (salpy_str): Update.
8905         (struct salpy_sal_object) <symtab>: Now a PyObject.
8906         (salpy_dealloc): Update.
8907         (del_objfile_sal): Use gdbpy_ref.
8908
8909 2019-01-03  Tom Tromey  <tom@tromey.com>
8910
8911         * python/py-type.c (convert_field): Use new_reference.  Return
8912         gdbpy_ref.
8913         (make_fielditem): Return gdbpy_ref.
8914         (typy_fields): Update.
8915         (typy_getitem): Update.
8916         (field_name): Return gdbpy_ref.  Use new_reference.
8917         (typy_iterator_iternext): Update.
8918
8919 2019-01-03  Tom Tromey  <tom@tromey.com>
8920
8921         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8922
8923 2019-01-03  Tom Tromey  <tom@tromey.com>
8924
8925         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8926         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8927         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8928         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8929         (pspy_set_type_printers): Likewise.
8930         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8931         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8932         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8933         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8934         (objfpy_set_type_printers): Likewise.
8935
8936 2019-01-03  Tom Tromey  <tom@tromey.com>
8937
8938         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8939         (gdbpy_print_stack): Use gdbpy_err_fetch.
8940         * python/python-internal.h (class gdbpy_err_fetch): New class.
8941         (class gdbpy_enter) <m_error_type, m_error_value,
8942         m_error_traceback>: Remove.
8943         <m_error>: New member.
8944         (gdbpy_exception_to_string): Don't declare.
8945         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8946         * python/py-value.c (convert_value_from_python): Use
8947         gdbpy_err_fetch.
8948         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8949         gdbpy_exception_to_string.
8950         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8951         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8952         gdbpy_err_fetch.
8953
8954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8955
8956         * linux-nat.c (delete_lwp_cleanup): Delete.
8957         (struct lwp_deleter): New struct.
8958         (lwp_info_up): New typedef.
8959         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8960         lwp_info_up.
8961
8962 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8963
8964         * linux-fork.c (class scoped_switch_fork_info): New class.
8965         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8966
8967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8968
8969         * valops.c (find_overload_match): Remove use of null_cleanup, and
8970         calls to do_cleanups.
8971
8972 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8973
8974         * compile/compile-cplus-types.c
8975         (compile_cplus_instance::decl_name): Handle changes to
8976         cp_func_name.
8977         * cp-support.c (cp_func_name): Update header comment, update
8978         return type.
8979         * cp-support.h (cp_func_name): Update return type in declaration.
8980         * valops.c (find_overload_match): Move temp_func local to top
8981         level of function and change its type.  Use temp_func to hold and
8982         delete temporary string obtained from cp_func_name.
8983
8984 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8985
8986         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8987         gdb::char_vector, remove cleanup, and update uses of `msg`.
8988
8989 2019-01-03  Jim Wilson  <jimw@sifive.com>
8990
8991         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8992
8993 2019-01-02  Tom Tromey  <tom@tromey.com>
8994
8995         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8996         (tdesc_parse_xml): Remove cleanups.
8997         * target-descriptions.h (make_cleanup_free_target_description):
8998         Don't declare.
8999         (target_desc_deleter): New struct.
9000         (target_desc_up): New typedef.
9001         * target-descriptions.c (target_desc_deleter::operator()): Rename
9002         from free_target_description.
9003         (make_cleanup_free_target_description): Remove.
9004
9005 2019-01-02  Tom Tromey  <tom@tromey.com>
9006
9007         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9008         constructor, destructor.
9009         (linespec_parser): Remove typedef.
9010         (~linespec_parser): Rename from linespec_parser_delete.
9011         (linespec_lex_to_end, linespec_complete_label)
9012         (linespec_complete): Update.
9013         (decode_line_full): Remove cleanups.
9014         (decode_line_1): Update.
9015
9016 2019-01-02  Tom Tromey  <tom@tromey.com>
9017
9018         * python/python-internal.h (inferior_to_inferior_object): Change
9019         return type.
9020         * python/py-exitedevent.c (create_exited_event_object): Update.
9021         * python/py-inferior.c (inferior_to_inferior_object): Return
9022         gdbpy_ref.
9023         (python_new_inferior, python_inferior_deleted)
9024         (thread_to_thread_object, delete_thread_object)
9025         (build_inferior_list, gdbpy_selected_inferior): Update.
9026         * python/py-infthread.c (create_thread_object): Update.  Also fail
9027         if inferior_to_inferior_object fails.
9028
9029 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9030
9031         * inferior.h (class inferior) <displaced_step_state>: New field.
9032         * infrun.h (struct displaced_step_state): Move here from
9033         infrun.c.  Initialize fields, add constructor.
9034         <inf>: Remove field.
9035         <reset>: New method.
9036         * infrun.c (struct displaced_step_inferior_state): Move to
9037         infrun.h.
9038         (displaced_step_inferior_states): Remove.
9039         (get_displaced_stepping_state): Adust.
9040         (displaced_step_in_progress_any_inferior): Adjust.
9041         (displaced_step_in_progress_thread): Adjust.
9042         (displaced_step_in_progress): Adjust.
9043         (add_displaced_stepping_state): Remove.
9044         (get_displaced_step_closure_by_addr): Adjust.
9045         (remove_displaced_stepping_state): Remove.
9046         (infrun_inferior_exit): Call displaced_step_state.reset.
9047         (use_displaced_stepping): Don't check for NULL.
9048         (displaced_step_prepare_throw): Call
9049         get_displaced_stepping_state.
9050         (displaced_step_fixup): Don't check for NULL.
9051         (prepare_for_detach): Don't check for NULL.
9052
9053 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9054
9055         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9056          in case of call that did not complete.
9057
9058 2019-01-02  Andrey Utkin  <autkin@undo.io>
9059
9060         * symfile.c (find_separate_debug_file): Fix search of debug files for
9061         remote debuggee.
9062
9063 2019-01-02  Tom Tromey  <tom@tromey.com>
9064
9065         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9066         indentation.
9067         * python/py-frame.c (frapy_older): Remove cast.
9068         (frapy_newer): Likewise.
9069         * python/py-breakpoint.c (local_setattro): Remove cast.
9070         * python/py-arch.c (archpy_name): Remove local variable.
9071         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9072
9073 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9074
9075         * unittests/basic_string_view/element_access/char/empty.cc:
9076         Fix year range in copyright header.
9077
9078 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9079
9080         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9081         Delete.
9082         <operator==>: Update with for removed field.
9083         <hash>: Likewise.
9084         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9085         <isa_features>: ...this.
9086         <abi_features>: New field.
9087         (riscv_isa_flen): Update comment.
9088         (riscv_abi_xlen): New declaration.
9089         (riscv_abi_flen): New declaration.
9090         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9091         isa_features.
9092         (riscv_abi_xlen): New function.
9093         (riscv_isa_flen): Update to get answer from isa_features.
9094         (riscv_abi_flen): New function.
9095         (riscv_has_fp_abi): Update to get answer from abi_features.
9096         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9097         xlen and flen.
9098         (riscv_call_info) <xlen, flen>: Update comment.
9099         (riscv_call_arg_struct): Remove invalid assertions
9100         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9101         is removed.
9102         (riscv_gdbarch_init): Gather isa features and abi features
9103         separately, ensure both match on the gdbarch when reusing an old
9104         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9105         a target with 64-bit float hardware.
9106
9107 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9108
9109         * source.c (search_command_helper): Stop reverse search
9110         when line 1 has been searched.
9111
9112 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9113
9114         * record-full.c (record_full_base_target::close): Rewrite
9115         record_full_core_buf_list free logic.
9116
9117 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9118
9119         * break-catch-syscall.c (print_one_catch_syscall): xfree
9120         the last text.
9121
9122 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9123
9124         * top.c (print_gdb_version): Update Copyright year in version
9125         message.
9126
9127 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9128
9129         Update copyright year range in all GDB files.
9130
9131 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9132
9133         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9134
9135 For older changes see ChangeLog-2018.
9136 \f
9137 Local Variables:
9138 mode: change-log
9139 left-margin: 8
9140 fill-column: 74
9141 version-control: never
9142 coding: utf-8
9143 End:
9144