gdb/ChangeLog

   1 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * source-cache.c (source_cache::get_source_lines): Call
   4         find_source_lines to initialize s->nlines.  This fixes vertical
   5         scrolling of TUI source window when the DOWN arrow is pressed.
   6
   7 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
   8
   9         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  10         wclrtoeol in tui_show_source_line".  This reverts changes made in
  11         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  12
  13 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  14
  15         * NEWS: Combine separate "New targets" sections for 8.3.
  16
  17 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  18
  19         The MS-Windows port of ncurses fails to switch to a color pair if
  20         one or both of the colors are the implicit default colors.  This
  21         change records the default colors when TUI is initialized, and
  22         then specifies them explicitly when a color pair uses the default
  23         colors.  This allows color styling in TUI mode on MS-Windows.
  24
  25         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  26         ncurses_norm_attr.
  27         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  28         colors in ncurses_norm_attr.
  29         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  30         "none", replace it with the default color recorded in
  31         ncurses_norm_attr.
  32
  33 2019-03-14  Tom Tromey  <tromey@adacore.com>
  34
  35         * source-cache.h (class source_cache) <get_source_lines>: Return
  36         std::string.
  37         * source-cache.c (source_cache::extract_lines): Handle case where
  38         first_pos==npos.  Return std::string.
  39         (source_cache::get_source_lines): Update.
  40
  41 2019-03-14  Tom Tromey  <tromey@adacore.com>
  42
  43         * NEWS: Add item for "style sources" commands.
  44         * source-cache.c (source_cache::get_source_lines): Check
  45         source_styling.
  46         * cli/cli-style.c (source_styling): New global.
  47         (_initialize_cli_style): Add "style sources" commands.
  48         (show_style_sources): New function.
  49         * cli/cli-style.h (source_styling): Declare.
  50
  51 2019-03-14  Pedro Alves  <palves@redhat.com>
  52             Tom Tromey  <tromey@adacore.com>
  53
  54         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  55         * tui/tui-winsource.c (tui_refill_source_window): New function,
  56         from...
  57         (tui_horizontal_source_scroll): ... here.  Move some logic.
  58         * cli/cli-style.c (set_style_enabled): Notify new observable.
  59         * tui/tui-hooks.c (tui_redisplay_source): New function.
  60         (tui_attach_detach_observers): Attach or detach
  61         tui_redisplay_source.
  62         * observable.h (source_styling_changed): New observable.
  63         * observable.c: Define source_styling_changed observable.
  64
  65 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  66
  67         PR/24325
  68         * source-cache.c: #undef open and close, to avoid unresolved
  69         externals during linking.
  70
  71 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  72
  73         Support styling on native MS-Windows console
  74
  75         PR/24315
  76         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  77         on MS-Windows if $TERM is not defined.
  78
  79         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  80
  81         * posix-hdep.c (gdb_console_fputs):
  82         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  83         functions.
  84         * ui-file.h (gdb_console_fputs): Add prototype.
  85
  86         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  87         back to fputs only if the former returns zero.
  88
  89 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  90             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  91
  92         PR gdb/8527
  93         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
  94         set_sigint_trap, clear_sigint_trap.
  95
  96 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  97
  98         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  99         for-loop range, to avoid compiler warnings.
 100
 101         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 102         avoid compiler warnings about unused variables.
 103
 104 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 105
 106         * NEWS: Mention end of support for native debugging on MS-Windows
 107         before XP.
 108
 109 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 110
 111         PR gdb/24292
 112         * common/netstuff.c:
 113         * gdbserver/gdbreplay.c
 114         * gdbserver/remote-utils.c:
 115         * ser-tcp.c:
 116         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 117         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 118         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 119         'getaddrinfo' and 'freeaddrinfo' were not available before
 120         Windows XP, and mingw.org's MinGW headers by default define
 121         _WIN32_WINNT to 0x500.
 122
 123 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 124
 125         * NEWS: Note minimum Python version.
 126
 127 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 128
 129         * version.in: Set GDB version number to 8.2.90.DATE-git.
 130
 131 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 132
 133         GDB 8.2.90 released.
 134
 135 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 136
 137         * version.in: Set GDB version number to 8.2.90.
 138
 139 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 140
 141         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 142
 143 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 144
 145         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 146         * version.in: Bump version to 8.2.90.DATE-git.
 147
 148 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 149
 150         * aix-thread.c (ptid_cmp): Remove unused variable.
 151         (get_signaled_thread): Likewise.
 152         (store_regs_user_thread): Likewise.
 153         (store_regs_kernel_thread): Likewise.
 154         (fetch_regs_kernel_thread): Remove shadowed variable.
 155
 156 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 157
 158         * features/riscv/32bit-cpu.xml: Add register numbers.
 159         * features/riscv/32bit-fpu.c: Regenerate.
 160         * features/riscv/32bit-fpu.xml: Add register numbers.
 161         * features/riscv/64bit-cpu.xml: Add register numbers.
 162         * features/riscv/64bit-fpu.c: Regenerate.
 163         * features/riscv/64bit-fpu.xml: Add register numbers.
 164
 165 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 166
 167         * NEWS: Mention two argument form of gdb.Value constructor.
 168         * python/py-value.c (convert_buffer_and_type_to_value): New
 169         function.
 170         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 171         Add support for handling an optional second argument.  Call
 172         convert_buffer_and_type_to_value as appropriate.
 173         * python/python-internal.h (Py_buffer_deleter): New struct.
 174         (Py_buffer_up): New typedef.
 175
 176 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 177
 178         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 179         instead of releasing ownership.
 180
 181 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 182
 183         * dwarf2read.c (open_and_init_dwp_file): Call
 184         elf_numsections instead of bfd_count_sections to initialize
 185         dwp_file->num_sections.
 186
 187 2019-02-25  Tom Tromey  <tromey@adacore.com>
 188
 189         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 190
 191 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 192
 193         * gcore.in: Add '--readnever' option when invoking GDB.
 194
 195 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 196
 197         * MAINTAINERS: Update my email address.
 198
 199 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 200
 201         * build-id.c (build_id_to_debug_bfd_1): New function.
 202         (build_id_to_debug_bfd): Look for separate debug file in
 203         sysroot.
 204
 205 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 206
 207         * gdbarch.sh: Update the copyright year range that is placed into
 208         generated files.
 209
 210 2019-02-22  Keith Seitz  <keiths@redhat.com>
 211
 212         PR symtab/23853
 213         * linespec.c (create_sals_line_offset): Search for the default
 214         symtab's filename instead of its fullname.
 215
 216 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 217
 218         * NEWS: Update style defaults.
 219
 220 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 221
 222         * main.c (captured_main_1): Disable styling in batch mode.
 223
 224 2019-02-20  Tom Tromey  <tom@tromey.com>
 225
 226         * symtab.c (symtab_symbol_info): Fix typos.
 227
 228 2019-02-20  Tom Tromey  <tromey@adacore.com>
 229
 230         * findcmd.c (_initialize_mem_search): Use upper case for
 231         metasyntactic variables.
 232
 233 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 234
 235         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 236         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 237
 238 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 239
 240         * top.h (source_file_name): Change to std::string.
 241         * top.c (source_file_name): Likewise.
 242         (command_line_input): Adjust.
 243         * cli/cli-script.c (script_from_file): Adjust.
 244
 245 2019-02-19  Tom Tromey  <tromey@adacore.com>
 246
 247         * ravenscar-thread.c
 248         (ravenscar_thread_target::update_thread_list): Don't call
 249         ada_build_task_list.
 250         * ada-lang.h (ada_build_task_list): Don't declare.
 251         * ada-tasks.c (struct ada_tasks_inferior_data)
 252         <task_list_valid_p>: Now bool.
 253         (read_known_tasks, ada_task_list_changed)
 254         (ada_tasks_invalidate_inferior_data): Update.
 255         (read_known_tasks_array): Return bool.
 256         (read_known_tasks_list): Likewise.
 257         (read_known_tasks): Return void.
 258         (ada_build_task_list): Now static.
 259
 260 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 263         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 264
 265 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 268         variant for ada_tasks_pspace_data_handle and
 269         ada_tasks_inferior_data_handle.
 270         (ada_tasks_pspace_data_cleanup): New function.
 271         (ada_tasks_inferior_data_cleanup): New function.
 272
 273 2019-02-17  Tom Tromey  <tom@tromey.com>
 274
 275         * macrotab.h (macro_source_fullname): Return a std::string.
 276         * macrotab.c (macro_include, check_for_redefinition)
 277         (macro_undef, macro_lookup_definition, foreach_macro)
 278         (foreach_macro_in_scope): Update.
 279         (macro_source_fullname): Return a std::string.
 280         * macrocmd.c (show_pp_source_pos): Update.
 281
 282 2019-02-17  Tom Tromey  <tom@tromey.com>
 283
 284         * macrocmd.c (show_pp_source_pos): Style the file names.
 285
 286 2019-02-17  Tom Tromey  <tom@tromey.com>
 287
 288         PR tui/24197:
 289         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 290
 291 2019-02-17  Tom Tromey  <tom@tromey.com>
 292
 293         * ada-lang.c (user_select_syms): Use filtered printing.
 294         * utils.c (wrap_style): New global.
 295         (desired_style): Remove.
 296         (emit_style_escape): Add stream parameter.
 297         (set_output_style, reset_terminal_style, prompt_for_continue):
 298         Update.
 299         (flush_wrap_buffer): Only flush gdb_stdout.
 300         (wrap_here): Set wrap_style.
 301         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 302         treat escape sequences as a character.  Change when wrap buffer is
 303         flushed.
 304         (fputs_styled): Do not set the output style when the default is
 305         requested.
 306         * ui-style.h (struct ui_file_style) <is_default>: New method.
 307         * source.c (print_source_lines_base): Emit escape sequences in one
 308         piece.
 309
 310 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 311
 312         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 313         integers and enumeration types.
 314
 315 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 316
 317         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 318         instead of lookup_symbol_in_language
 319         (do_exact_match): New function.
 320         (ada_get_symbol_name_matcher): Return do_exact_match when
 321         doing a verbatim match.
 322
 323 2019-02-15  Tom Tromey  <tromey@adacore.com>
 324
 325         * ravenscar-thread.c (ravenscar_thread_target::resume)
 326         (ravenscar_thread_target::wait): Special case wildcard requests.
 327
 328 2019-02-15  Tom Tromey  <tromey@adacore.com>
 329
 330         * ravenscar-thread.c (base_ptid): Remove.
 331         (struct ravenscar_thread_target) <close>: New method.
 332         <m_base_ptid>: New member.
 333         <update_inferior_ptid, active_task, task_is_currently_active,
 334         runtime_initialized>: Declare methods.
 335         <ravenscar_thread_target>: Add constructor.
 336         (ravenscar_thread_target::task_is_currently_active)
 337         (ravenscar_thread_target::update_inferior_ptid)
 338         (ravenscar_runtime_initialized): Rename.  Now methods.
 339         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 340         (ravenscar_thread_target::update_thread_list): Update.
 341         (ravenscar_thread_target::active_task): Now method.
 342         (ravenscar_thread_target::store_registers)
 343         (ravenscar_thread_target::prepare_to_store)
 344         (ravenscar_thread_target::prepare_to_store)
 345         (ravenscar_thread_target::mourn_inferior): Update.
 346         (ravenscar_inferior_created): Use "new" to create target.
 347         (ravenscar_thread_target::get_ada_task_ptid): Update.
 348         (_initialize_ravenscar): Don't initialize base_ptid.
 349         (ravenscar_ops): Remove global.
 350
 351 2019-02-15  Tom Tromey  <tromey@adacore.com>
 352
 353         * target.h (push_target): Declare new overload.
 354         * target.c (push_target): New overload, taking an rvalue reference.
 355         * remote.c (remote_target::open_1): Use push_target overload.
 356         * corelow.c (core_target_open): Use push_target overload.
 357
 358 2019-02-15  Tom Tromey  <tromey@adacore.com>
 359
 360         * ravenscar-thread.c (is_ravenscar_task)
 361         (ravenscar_task_is_currently_active): Return bool.
 362         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 363         (_initialize_ravenscar): Remove "(void)".
 364         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 365         Return bool.
 366
 367 2019-02-15  Tom Tromey  <tromey@adacore.com>
 368
 369         * ravenscar-thread.c (ravenscar_runtime_initializer)
 370         (has_ravenscar_runtime, get_running_thread_id)
 371         (ravenscar_thread_target::resume): Fix indentation.
 372
 373 2019-02-15  Tom Tromey  <tromey@adacore.com>
 374
 375         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 376         from ravenscar_arch_ops.
 377         (sparc_ravenscar_ops::fetch_registers)
 378         (sparc_ravenscar_ops::store_registers): Now methods.
 379         (sparc_ravenscar_prepare_to_store): Remove.
 380         (sparc_ravenscar_ops): Redefine.
 381         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 382         methods and destructor.  Remove members.
 383         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 384         (ravenscar_thread_target::store_registers)
 385         (ravenscar_thread_target::prepare_to_store): Update.
 386         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 387         Remove.
 388         (struct ppc_ravenscar_powerpc_ops): Derive from
 389         ravenscar_arch_ops.
 390         (ppc_ravenscar_powerpc_ops::fetch_registers)
 391         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 392         (ppc_ravenscar_powerpc_ops): Redefine.
 393         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 394         (ppc_ravenscar_e500_ops::fetch_registers)
 395         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 396         (ppc_ravenscar_e500_ops): Redefine.
 397         * aarch64-ravenscar-thread.c
 398         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 399         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 400         (aarch64_ravenscar_fetch_registers)
 401         (aarch64_ravenscar_store_registers): Now methods.
 402         (aarch64_ravenscar_ops): Redefine.
 403
 404 2019-02-15  Tom Tromey  <tromey@adacore.com>
 405
 406         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 407         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 408         (ravenscar_thread_target::stopped_by_watchpoint)
 409         (ravenscar_thread_target::stopped_data_address)
 410         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 411
 412 2019-02-15  Tom Tromey  <tromey@adacore.com>
 413
 414         * ravenscar-thread.c: Fix some typos.
 415
 416 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 417             Tom Tromey  <tromey@adacore.com>
 418
 419         * ada-lang.c (ada_exception_sal): Change addr_string to a
 420         std::string.
 421         (create_ada_exception_catchpoint): Update.
 422
 423 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 424             Tom Tromey  <tromey@adacore.com>
 425
 426         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 427         (bp_location_ops): Remove.
 428         (base_breakpoint_allocate_location): Update.
 429         (free_bp_location): Update.
 430         * ada-lang.c (class ada_catchpoint_location)
 431         <ada_catchpoint_location>: Remove ops parameter.
 432         (ada_catchpoint_location_dtor): Remove.
 433         (ada_catchpoint_location_ops): Remove.
 434         (allocate_location_exception): Update.
 435         * breakpoint.h (struct bp_location_ops): Remove.
 436         (class bp_location) <bp_location>: Remove bp_location_ops
 437         parameter.
 438         <~bp_location>: Add destructor.
 439         <ops>: Remove.
 440
 441 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 442             Pedro Alves  <palves@redhat.com>
 443
 444         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 445         'PATH_MAX'.
 446
 447 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 448             Samuel Thibault  <samuel.thibault@gnu.org>
 449             Thomas Schwinge  <thomas@codesourcery.com>
 450
 451         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 452         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 453
 454 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 455
 456         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 457         (check_empty): Use "const char *".
 458
 459         * gnu-nat.c (gnu_nat_target::detach): Instead of
 460         'detach_inferior (pid)' call
 461         'detach_inferior (find_inferior_pid (pid))'.
 462
 463         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 464         'nat/fork-inferior.o'.
 465         * gnu-nat.c: #include "nat/fork-inferior.h".
 466
 467         * gnu-nat.c (gnu_nat_target::detach): Instead of
 468         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 469         * gnu-nat.h: #include "inf-child.h".
 470         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 471         'i386_gnu_nat_target::fetch_registers'.
 472         (gnu_store_registers): Rename/move to
 473         'i386_gnu_nat_target::store_registers'.
 474
 475         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 476         * gnu-nat.h (mach_thread_info): New function.
 477         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 478
 479         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 480
 481 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 482
 483         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 484
 485 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 486
 487         * windows-nat.c (windows_add_thread): Add new parameter
 488         "main_thread_p" with default value set to false.  Update
 489         function documentation as well as all callers.
 490         (windows_delete_thread): Likewise.
 491         (fake_create_process): Update call to windows_add_thread.
 492         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 493         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 494         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 495         call to windows_delete_thread.
 496
 497 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 498
 499         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 500
 501 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 502
 503         * symfile.c (find_separate_debug_file): Use canonical path of
 504         sysroot with child_path instead of gdb_sysroot if it is valid.
 505
 506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 507
 508         * symfile.c (find_separate_debug_file): Use child_path to
 509         determine if an object file is under a sysroot.
 510
 511 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 512
 513         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 514         unittests/child-path-selftests.c.
 515         * common/pathstuff.c (child_path): New function.
 516         * common/pathstuff.h (child_path): New prototype.
 517         * unittests/child-path-selftests.c: New file.
 518
 519 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 520
 521         * symfile.c (find_separate_debug_file): Look for separate debug
 522         files in debug directories under the sysroot.
 523
 524 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 525
 526         * symtab.h (struct minimal_symbol data_p): New const method.
 527         (struct minimal_symbol text_p): Likewise.
 528         * symtab.c (output_source_filename): Use file name style
 529         to print file name.
 530         (print_symbol_info): Likewise.
 531         (print_msymbol_info): Use address style to print addresses.
 532         Use function name style to print executable text symbols.
 533         (expand_symtab_containing_pc): Use data_p.
 534         (find_pc_sect_compunit_symtab): Likewise.
 535
 536 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 537
 538         * breakpoint.c (describe_other_breakpoints): Use address style
 539         to print addresses.
 540         (say_where): Likewise.
 541
 542 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 543
 544         * ada-typeprint.c (print_func_type): Print function name
 545         style to print function name.
 546         * c-typeprint.c (c_print_type_1): Likewise.
 547
 548 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 549
 550         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 551         for execve.
 552
 553 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 554
 555         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 556         type_stack.
 557
 558 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 559
 560         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 561         TYPE_CODE_REF types.
 562
 563 2019-02-08  Jim Wilson  <jimw@sifive.com>
 564
 565         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 566         (riscv_linux_fregset): New.
 567         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 568
 569 2019-02-07  Tom Tromey  <tom@tromey.com>
 570
 571         * thread.c (thread_cancel_execution_command): Update.
 572         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 573         methods.
 574         (struct thread_fsm_ops): Remove.
 575         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 576         (thread_fsm_should_stop, thread_fsm_return_value)
 577         (thread_fsm_set_finished, thread_fsm_finished_p)
 578         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 579         Don't declare.
 580         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 581         * infrun.c (clear_proceed_status_thread)
 582         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 583         (print_stop_event): Update.
 584         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 585         Add constructor.
 586         (step_command_fsm_ops): Remove.
 587         (new_step_command_fsm): Remove.
 588         (step_1): Update.
 589         (step_command_fsm::should_stop): Rename from
 590         step_command_fsm_should_stop.
 591         (step_command_fsm::clean_up): Rename from
 592         step_command_fsm_clean_up.
 593         (step_command_fsm::do_async_reply_reason): Rename from
 594         step_command_fsm_async_reply_reason.
 595         (struct until_next_fsm): Inherit from thread_fsm.  Add
 596         constructor.
 597         (until_next_fsm_ops): Remove.
 598         (new_until_next_fsm): Remove.
 599         (until_next_fsm::should_stop): Rename from
 600         until_next_fsm_should_stop.
 601         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 602         (until_next_fsm::do_async_reply_reason): Rename from
 603         until_next_fsm_async_reply_reason.
 604         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 605         constructor.  Change type of breakpoint.
 606         (finish_command_fsm_ops): Remove.
 607         (new_finish_command_fsm): Remove.
 608         (finish_command_fsm::should_stop): Rename from
 609         finish_command_fsm_should_stop.
 610         (finish_command_fsm::clean_up): Rename from
 611         finish_command_fsm_clean_up.
 612         (finish_command_fsm::return_value): Rename from
 613         finish_command_fsm_return_value.
 614         (finish_command_fsm::do_async_reply_reason): Rename from
 615         finish_command_fsm_async_reply_reason.
 616         (finish_command): Update.
 617         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 618         Add constructor.
 619         (call_thread_fsm_ops): Remove.
 620         (call_thread_fsm::call_thread_fsm): Rename from
 621         new_call_thread_fsm.
 622         (call_thread_fsm::should_stop): Rename from
 623         call_thread_fsm_should_stop.
 624         (call_thread_fsm::should_notify_stop): Rename from
 625         call_thread_fsm_should_notify_stop.
 626         (run_inferior_call, call_function_by_hand_dummy): Update.
 627         * cli/cli-interp.c (should_print_stop_to_console): Update.
 628         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 629         Add constructor.  Change type of location_breakpoint,
 630         caller_breakpoint.
 631         (until_break_fsm_ops): Remove.
 632         (new_until_break_fsm): Remove.
 633         (until_break_fsm::should_stop): Rename from
 634         until_break_fsm_should_stop.
 635         (until_break_fsm::clean_up): Rename from
 636         until_break_fsm_clean_up.
 637         (until_break_fsm::do_async_reply_reason): Rename from
 638         until_break_fsm_async_reply_reason.
 639         (until_break_command): Update.
 640         * thread-fsm.c: Remove.
 641         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 642
 643 2019-02-07  Tom Tromey  <tom@tromey.com>
 644
 645         * yy-remap.h: Add include guard.
 646         * xtensa-tdep.h: Add include guard.
 647         * xcoffread.h: Rename include guard.
 648         * varobj-iter.h: Add include guard.
 649         * tui/tui.h: Rename include guard.
 650         * tui/tui-winsource.h: Rename include guard.
 651         * tui/tui-wingeneral.h: Rename include guard.
 652         * tui/tui-windata.h: Rename include guard.
 653         * tui/tui-win.h: Rename include guard.
 654         * tui/tui-stack.h: Rename include guard.
 655         * tui/tui-source.h: Rename include guard.
 656         * tui/tui-regs.h: Rename include guard.
 657         * tui/tui-out.h: Rename include guard.
 658         * tui/tui-layout.h: Rename include guard.
 659         * tui/tui-io.h: Rename include guard.
 660         * tui/tui-hooks.h: Rename include guard.
 661         * tui/tui-file.h: Rename include guard.
 662         * tui/tui-disasm.h: Rename include guard.
 663         * tui/tui-data.h: Rename include guard.
 664         * tui/tui-command.h: Rename include guard.
 665         * tic6x-tdep.h: Add include guard.
 666         * target/waitstatus.h: Rename include guard.
 667         * target/wait.h: Rename include guard.
 668         * target/target.h: Rename include guard.
 669         * target/resume.h: Rename include guard.
 670         * target-float.h: Rename include guard.
 671         * stabsread.h: Add include guard.
 672         * rs6000-tdep.h: Add include guard.
 673         * riscv-fbsd-tdep.h: Add include guard.
 674         * regformats/regdef.h: Rename include guard.
 675         * record.h: Rename include guard.
 676         * python/python.h: Rename include guard.
 677         * python/python-internal.h: Rename include guard.
 678         * python/py-stopevent.h: Rename include guard.
 679         * python/py-ref.h: Rename include guard.
 680         * python/py-record.h: Rename include guard.
 681         * python/py-record-full.h: Rename include guard.
 682         * python/py-record-btrace.h: Rename include guard.
 683         * python/py-instruction.h: Rename include guard.
 684         * python/py-events.h: Rename include guard.
 685         * python/py-event.h: Rename include guard.
 686         * procfs.h: Add include guard.
 687         * proc-utils.h: Add include guard.
 688         * p-lang.h: Add include guard.
 689         * or1k-tdep.h: Rename include guard.
 690         * observable.h: Rename include guard.
 691         * nto-tdep.h: Rename include guard.
 692         * nat/x86-linux.h: Rename include guard.
 693         * nat/x86-linux-dregs.h: Rename include guard.
 694         * nat/x86-gcc-cpuid.h: Add include guard.
 695         * nat/x86-dregs.h: Rename include guard.
 696         * nat/x86-cpuid.h: Rename include guard.
 697         * nat/ppc-linux.h: Rename include guard.
 698         * nat/mips-linux-watch.h: Rename include guard.
 699         * nat/linux-waitpid.h: Rename include guard.
 700         * nat/linux-ptrace.h: Rename include guard.
 701         * nat/linux-procfs.h: Rename include guard.
 702         * nat/linux-osdata.h: Rename include guard.
 703         * nat/linux-nat.h: Rename include guard.
 704         * nat/linux-namespaces.h: Rename include guard.
 705         * nat/linux-btrace.h: Rename include guard.
 706         * nat/glibc_thread_db.h: Rename include guard.
 707         * nat/gdb_thread_db.h: Rename include guard.
 708         * nat/gdb_ptrace.h: Rename include guard.
 709         * nat/fork-inferior.h: Rename include guard.
 710         * nat/amd64-linux-siginfo.h: Rename include guard.
 711         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 712         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 713         * nat/aarch64-linux.h: Rename include guard.
 714         * nat/aarch64-linux-hw-point.h: Rename include guard.
 715         * mn10300-tdep.h: Add include guard.
 716         * mips-linux-tdep.h: Add include guard.
 717         * mi/mi-parse.h: Rename include guard.
 718         * mi/mi-out.h: Rename include guard.
 719         * mi/mi-main.h: Rename include guard.
 720         * mi/mi-interp.h: Rename include guard.
 721         * mi/mi-getopt.h: Rename include guard.
 722         * mi/mi-console.h: Rename include guard.
 723         * mi/mi-common.h: Rename include guard.
 724         * mi/mi-cmds.h: Rename include guard.
 725         * mi/mi-cmd-break.h: Rename include guard.
 726         * m2-lang.h: Add include guard.
 727         * location.h: Rename include guard.
 728         * linux-record.h: Rename include guard.
 729         * linux-nat.h: Add include guard.
 730         * linux-fork.h: Add include guard.
 731         * i386-darwin-tdep.h: Rename include guard.
 732         * hppa-linux-offsets.h: Add include guard.
 733         * guile/guile.h: Rename include guard.
 734         * guile/guile-internal.h: Rename include guard.
 735         * gnu-nat.h: Rename include guard.
 736         * gdb-stabs.h: Rename include guard.
 737         * frv-tdep.h: Add include guard.
 738         * f-lang.h: Add include guard.
 739         * event-loop.h: Add include guard.
 740         * darwin-nat.h: Rename include guard.
 741         * cp-abi.h: Rename include guard.
 742         * config/sparc/nm-sol2.h: Rename include guard.
 743         * config/nm-nto.h: Rename include guard.
 744         * config/nm-linux.h: Add include guard.
 745         * config/i386/nm-i386gnu.h: Rename include guard.
 746         * config/djgpp/nl_types.h: Rename include guard.
 747         * config/djgpp/langinfo.h: Rename include guard.
 748         * compile/gcc-cp-plugin.h: Add include guard.
 749         * compile/gcc-c-plugin.h: Add include guard.
 750         * compile/compile.h: Rename include guard.
 751         * compile/compile-object-run.h: Rename include guard.
 752         * compile/compile-object-load.h: Rename include guard.
 753         * compile/compile-internal.h: Rename include guard.
 754         * compile/compile-cplus.h: Rename include guard.
 755         * compile/compile-c.h: Rename include guard.
 756         * common/xml-utils.h: Rename include guard.
 757         * common/x86-xstate.h: Rename include guard.
 758         * common/version.h: Rename include guard.
 759         * common/vec.h: Rename include guard.
 760         * common/tdesc.h: Rename include guard.
 761         * common/selftest.h: Rename include guard.
 762         * common/scoped_restore.h: Rename include guard.
 763         * common/scoped_mmap.h: Rename include guard.
 764         * common/scoped_fd.h: Rename include guard.
 765         * common/safe-iterator.h: Rename include guard.
 766         * common/run-time-clock.h: Rename include guard.
 767         * common/refcounted-object.h: Rename include guard.
 768         * common/queue.h: Rename include guard.
 769         * common/ptid.h: Rename include guard.
 770         * common/print-utils.h: Rename include guard.
 771         * common/preprocessor.h: Rename include guard.
 772         * common/pathstuff.h: Rename include guard.
 773         * common/observable.h: Rename include guard.
 774         * common/netstuff.h: Rename include guard.
 775         * common/job-control.h: Rename include guard.
 776         * common/host-defs.h: Rename include guard.
 777         * common/gdb_wait.h: Rename include guard.
 778         * common/gdb_vecs.h: Rename include guard.
 779         * common/gdb_unlinker.h: Rename include guard.
 780         * common/gdb_unique_ptr.h: Rename include guard.
 781         * common/gdb_tilde_expand.h: Rename include guard.
 782         * common/gdb_sys_time.h: Rename include guard.
 783         * common/gdb_string_view.h: Rename include guard.
 784         * common/gdb_splay_tree.h: Rename include guard.
 785         * common/gdb_setjmp.h: Rename include guard.
 786         * common/gdb_ref_ptr.h: Rename include guard.
 787         * common/gdb_optional.h: Rename include guard.
 788         * common/gdb_locale.h: Rename include guard.
 789         * common/gdb_assert.h: Rename include guard.
 790         * common/filtered-iterator.h: Rename include guard.
 791         * common/filestuff.h: Rename include guard.
 792         * common/fileio.h: Rename include guard.
 793         * common/environ.h: Rename include guard.
 794         * common/common-utils.h: Rename include guard.
 795         * common/common-types.h: Rename include guard.
 796         * common/common-regcache.h: Rename include guard.
 797         * common/common-inferior.h: Rename include guard.
 798         * common/common-gdbthread.h: Rename include guard.
 799         * common/common-exceptions.h: Rename include guard.
 800         * common/common-defs.h: Rename include guard.
 801         * common/common-debug.h: Rename include guard.
 802         * common/cleanups.h: Rename include guard.
 803         * common/buffer.h: Rename include guard.
 804         * common/btrace-common.h: Rename include guard.
 805         * common/break-common.h: Rename include guard.
 806         * cli/cli-utils.h: Rename include guard.
 807         * cli/cli-style.h: Rename include guard.
 808         * cli/cli-setshow.h: Rename include guard.
 809         * cli/cli-script.h: Rename include guard.
 810         * cli/cli-interp.h: Rename include guard.
 811         * cli/cli-decode.h: Rename include guard.
 812         * cli/cli-cmds.h: Rename include guard.
 813         * charset-list.h: Add include guard.
 814         * buildsym-legacy.h: Rename include guard.
 815         * bfin-tdep.h: Add include guard.
 816         * ax.h: Rename include guard.
 817         * arm-linux-tdep.h: Add include guard.
 818         * arm-fbsd-tdep.h: Add include guard.
 819         * arch/xtensa.h: Rename include guard.
 820         * arch/tic6x.h: Add include guard.
 821         * arch/i386.h: Add include guard.
 822         * arch/arm.h: Rename include guard.
 823         * arch/arm-linux.h: Rename include guard.
 824         * arch/arm-get-next-pcs.h: Rename include guard.
 825         * arch/amd64.h: Add include guard.
 826         * arch/aarch64-insn.h: Rename include guard.
 827         * arch-utils.h: Rename include guard.
 828         * annotate.h: Add include guard.
 829         * amd64-darwin-tdep.h: Rename include guard.
 830         * aarch64-linux-tdep.h: Add include guard.
 831         * aarch64-fbsd-tdep.h: Add include guard.
 832         * aarch32-linux-nat.h: Add include guard.
 833
 834 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 835
 836         * macrotab.c (macro_define_internal): New function that
 837         factorizes macro_define_object_internal and macro_define_function
 838         code.
 839         (macro_define_object_internal): Use macro_define_internal.
 840         (macro_define_function): Likewise.
 841
 842 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 843
 844         * macrocmd.c (extract_identifier): Return
 845         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 846         callers.
 847
 848 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 849
 850         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 851
 852 2019-02-05  Tom Tromey  <tom@tromey.com>
 853
 854         * target.c (target_stack::unpush): Move assertion earlier.
 855
 856 2019-01-30  Tom Tromey  <tom@tromey.com>
 857
 858         PR python/23615:
 859         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 860         (gdbpy_parse_and_eval): Likewise.
 861         * python/python-internal.h (gdbpy_allow_threads): New class.
 862
 863 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 864
 865         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 866         (aarch64_fbsd_fpregmap): Move earlier.
 867         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 868         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 869         instead of individual calls to trad_frame_set_reg_addr.
 870         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 871         earlier.
 872         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 873         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 874         instead of individual calls to trad_frame_set_reg_addr.
 875
 876 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 877
 878         * CONTRIBUTE: Replace contribution list with wiki link.
 879
 880 2019-01-25  Tom Tromey  <tom@tromey.com>
 881
 882         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 883
 884 2019-01-25  Tom Tromey  <tom@tromey.com>
 885
 886         * xtensa-linux-nat.c: Fix common/ includes.
 887         * xml-support.h: Fix common/ includes.
 888         * xml-support.c: Fix common/ includes.
 889         * x86-linux-nat.c: Fix common/ includes.
 890         * windows-nat.c: Fix common/ includes.
 891         * varobj.h: Fix common/ includes.
 892         * varobj.c: Fix common/ includes.
 893         * value.c: Fix common/ includes.
 894         * valops.c: Fix common/ includes.
 895         * utils.c: Fix common/ includes.
 896         * unittests/xml-utils-selftests.c: Fix common/ includes.
 897         * unittests/utils-selftests.c: Fix common/ includes.
 898         * unittests/unpack-selftests.c: Fix common/ includes.
 899         * unittests/tracepoint-selftests.c: Fix common/ includes.
 900         * unittests/style-selftests.c: Fix common/ includes.
 901         * unittests/string_view-selftests.c: Fix common/ includes.
 902         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 903         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 904         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 905         * unittests/rsp-low-selftests.c: Fix common/ includes.
 906         * unittests/parse-connection-spec-selftests.c: Fix common/
 907         includes.
 908         * unittests/optional-selftests.c: Fix common/ includes.
 909         * unittests/offset-type-selftests.c: Fix common/ includes.
 910         * unittests/observable-selftests.c: Fix common/ includes.
 911         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 912         * unittests/memrange-selftests.c: Fix common/ includes.
 913         * unittests/memory-map-selftests.c: Fix common/ includes.
 914         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 915         * unittests/function-view-selftests.c: Fix common/ includes.
 916         * unittests/environ-selftests.c: Fix common/ includes.
 917         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 918         * unittests/common-utils-selftests.c: Fix common/ includes.
 919         * unittests/cli-utils-selftests.c: Fix common/ includes.
 920         * unittests/array-view-selftests.c: Fix common/ includes.
 921         * ui-file.c: Fix common/ includes.
 922         * tui/tui-io.c: Fix common/ includes.
 923         * tracepoint.h: Fix common/ includes.
 924         * tracepoint.c: Fix common/ includes.
 925         * tracefile-tfile.c: Fix common/ includes.
 926         * top.h: Fix common/ includes.
 927         * top.c: Fix common/ includes.
 928         * thread.c: Fix common/ includes.
 929         * target/waitstatus.h: Fix common/ includes.
 930         * target/waitstatus.c: Fix common/ includes.
 931         * target.h: Fix common/ includes.
 932         * target.c: Fix common/ includes.
 933         * target-memory.c: Fix common/ includes.
 934         * target-descriptions.c: Fix common/ includes.
 935         * symtab.h: Fix common/ includes.
 936         * symfile.c: Fix common/ includes.
 937         * stap-probe.c: Fix common/ includes.
 938         * spu-linux-nat.c: Fix common/ includes.
 939         * sparc-nat.c: Fix common/ includes.
 940         * source.c: Fix common/ includes.
 941         * solib.c: Fix common/ includes.
 942         * solib-target.c: Fix common/ includes.
 943         * ser-unix.c: Fix common/ includes.
 944         * ser-tcp.c: Fix common/ includes.
 945         * ser-pipe.c: Fix common/ includes.
 946         * ser-base.c: Fix common/ includes.
 947         * selftest-arch.c: Fix common/ includes.
 948         * s12z-tdep.c: Fix common/ includes.
 949         * rust-exp.y: Fix common/ includes.
 950         * rs6000-aix-tdep.c: Fix common/ includes.
 951         * riscv-tdep.c: Fix common/ includes.
 952         * remote.c: Fix common/ includes.
 953         * remote-notif.h: Fix common/ includes.
 954         * remote-fileio.h: Fix common/ includes.
 955         * remote-fileio.c: Fix common/ includes.
 956         * regcache.h: Fix common/ includes.
 957         * regcache.c: Fix common/ includes.
 958         * record-btrace.c: Fix common/ includes.
 959         * python/python.c: Fix common/ includes.
 960         * python/py-type.c: Fix common/ includes.
 961         * python/py-inferior.c: Fix common/ includes.
 962         * progspace.h: Fix common/ includes.
 963         * producer.c: Fix common/ includes.
 964         * procfs.c: Fix common/ includes.
 965         * proc-api.c: Fix common/ includes.
 966         * printcmd.c: Fix common/ includes.
 967         * ppc-linux-nat.c: Fix common/ includes.
 968         * parser-defs.h: Fix common/ includes.
 969         * osdata.c: Fix common/ includes.
 970         * obsd-nat.c: Fix common/ includes.
 971         * nat/x86-linux.c: Fix common/ includes.
 972         * nat/x86-linux-dregs.c: Fix common/ includes.
 973         * nat/x86-dregs.h: Fix common/ includes.
 974         * nat/x86-dregs.c: Fix common/ includes.
 975         * nat/ppc-linux.c: Fix common/ includes.
 976         * nat/mips-linux-watch.h: Fix common/ includes.
 977         * nat/mips-linux-watch.c: Fix common/ includes.
 978         * nat/linux-waitpid.c: Fix common/ includes.
 979         * nat/linux-ptrace.h: Fix common/ includes.
 980         * nat/linux-ptrace.c: Fix common/ includes.
 981         * nat/linux-procfs.c: Fix common/ includes.
 982         * nat/linux-personality.c: Fix common/ includes.
 983         * nat/linux-osdata.c: Fix common/ includes.
 984         * nat/linux-namespaces.c: Fix common/ includes.
 985         * nat/linux-btrace.h: Fix common/ includes.
 986         * nat/linux-btrace.c: Fix common/ includes.
 987         * nat/fork-inferior.c: Fix common/ includes.
 988         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 989         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 990         * nat/aarch64-linux.c: Fix common/ includes.
 991         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 992         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 993         * namespace.h: Fix common/ includes.
 994         * mips-linux-tdep.c: Fix common/ includes.
 995         * minsyms.c: Fix common/ includes.
 996         * mi/mi-parse.h: Fix common/ includes.
 997         * mi/mi-main.c: Fix common/ includes.
 998         * mi/mi-cmd-env.c: Fix common/ includes.
 999         * memrange.h: Fix common/ includes.
1000         * memattr.c: Fix common/ includes.
1001         * maint.h: Fix common/ includes.
1002         * maint.c: Fix common/ includes.
1003         * main.c: Fix common/ includes.
1004         * machoread.c: Fix common/ includes.
1005         * location.c: Fix common/ includes.
1006         * linux-thread-db.c: Fix common/ includes.
1007         * linux-nat.c: Fix common/ includes.
1008         * linux-fork.c: Fix common/ includes.
1009         * inline-frame.c: Fix common/ includes.
1010         * infrun.c: Fix common/ includes.
1011         * inflow.c: Fix common/ includes.
1012         * inferior.h: Fix common/ includes.
1013         * inferior.c: Fix common/ includes.
1014         * infcmd.c: Fix common/ includes.
1015         * inf-ptrace.c: Fix common/ includes.
1016         * inf-child.c: Fix common/ includes.
1017         * ia64-linux-nat.c: Fix common/ includes.
1018         * i387-tdep.c: Fix common/ includes.
1019         * i386-tdep.c: Fix common/ includes.
1020         * i386-linux-tdep.c: Fix common/ includes.
1021         * i386-linux-nat.c: Fix common/ includes.
1022         * i386-go32-tdep.c: Fix common/ includes.
1023         * i386-fbsd-tdep.c: Fix common/ includes.
1024         * i386-fbsd-nat.c: Fix common/ includes.
1025         * guile/scm-type.c: Fix common/ includes.
1026         * guile/guile.c: Fix common/ includes.
1027         * go32-nat.c: Fix common/ includes.
1028         * gnu-nat.c: Fix common/ includes.
1029         * gdbthread.h: Fix common/ includes.
1030         * gdbarch-selftests.c: Fix common/ includes.
1031         * gdb_usleep.c: Fix common/ includes.
1032         * gdb_select.h: Fix common/ includes.
1033         * gdb_bfd.c: Fix common/ includes.
1034         * gcore.c: Fix common/ includes.
1035         * fork-child.c: Fix common/ includes.
1036         * findvar.c: Fix common/ includes.
1037         * fbsd-nat.c: Fix common/ includes.
1038         * event-top.c: Fix common/ includes.
1039         * event-loop.c: Fix common/ includes.
1040         * dwarf2read.c: Fix common/ includes.
1041         * dwarf2loc.c: Fix common/ includes.
1042         * dwarf2-frame.c: Fix common/ includes.
1043         * dwarf-index-cache.c: Fix common/ includes.
1044         * dtrace-probe.c: Fix common/ includes.
1045         * disasm-selftests.c: Fix common/ includes.
1046         * defs.h: Fix common/ includes.
1047         * csky-tdep.c: Fix common/ includes.
1048         * cp-valprint.c: Fix common/ includes.
1049         * cp-support.h: Fix common/ includes.
1050         * cp-support.c: Fix common/ includes.
1051         * corelow.c: Fix common/ includes.
1052         * completer.h: Fix common/ includes.
1053         * completer.c: Fix common/ includes.
1054         * compile/compile.c: Fix common/ includes.
1055         * compile/compile-loc2c.c: Fix common/ includes.
1056         * compile/compile-cplus-types.c: Fix common/ includes.
1057         * compile/compile-cplus-symbols.c: Fix common/ includes.
1058         * command.h: Fix common/ includes.
1059         * cli/cli-dump.c: Fix common/ includes.
1060         * cli/cli-cmds.c: Fix common/ includes.
1061         * charset.c: Fix common/ includes.
1062         * build-id.c: Fix common/ includes.
1063         * btrace.h: Fix common/ includes.
1064         * btrace.c: Fix common/ includes.
1065         * breakpoint.h: Fix common/ includes.
1066         * breakpoint.c: Fix common/ includes.
1067         * ax.h:
1068         (enum agent_op): Fix common/ includes.
1069         * ax-general.c (struct aop_map): Fix common/ includes.
1070         * ax-gdb.c: Fix common/ includes.
1071         * auxv.c: Fix common/ includes.
1072         * auto-load.c: Fix common/ includes.
1073         * arm-tdep.c: Fix common/ includes.
1074         * arch/riscv.c: Fix common/ includes.
1075         * arch/ppc-linux-common.c: Fix common/ includes.
1076         * arch/i386.c: Fix common/ includes.
1077         * arch/arm.c: Fix common/ includes.
1078         * arch/arm-linux.c: Fix common/ includes.
1079         * arch/arm-get-next-pcs.c: Fix common/ includes.
1080         * arch/amd64.c: Fix common/ includes.
1081         * arch/aarch64.c: Fix common/ includes.
1082         * arch/aarch64-insn.c: Fix common/ includes.
1083         * arch-utils.c: Fix common/ includes.
1084         * amd64-windows-tdep.c: Fix common/ includes.
1085         * amd64-tdep.c: Fix common/ includes.
1086         * amd64-sol2-tdep.c: Fix common/ includes.
1087         * amd64-obsd-tdep.c: Fix common/ includes.
1088         * amd64-nbsd-tdep.c: Fix common/ includes.
1089         * amd64-linux-tdep.c: Fix common/ includes.
1090         * amd64-linux-nat.c: Fix common/ includes.
1091         * amd64-fbsd-tdep.c: Fix common/ includes.
1092         * amd64-fbsd-nat.c: Fix common/ includes.
1093         * amd64-dicos-tdep.c: Fix common/ includes.
1094         * amd64-darwin-tdep.c: Fix common/ includes.
1095         * agent.c: Fix common/ includes.
1096         * ada-lang.h: Fix common/ includes.
1097         * ada-lang.c: Fix common/ includes.
1098         * aarch64-tdep.c: Fix common/ includes.
1099
1100 2019-01-25  Tom Tromey  <tom@tromey.com>
1101
1102         * common/create-version.sh: Use common/version.h.
1103
1104 2019-01-24  Pedro Alves  <palves@redhat.com>
1105
1106         * infrun.c (signal_stop, signal_print, signal_program)
1107         (signal_catch, signal_pass): Now arrays instead of pointers.
1108         (update_signals_program_target, do_target_resume)
1109         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1110         * linux-nat.c (linux_nat_target::pass_signals)
1111         (linux_nat_target::create_inferior, linux_nat_target::attach):
1112         Adjust.
1113         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1114         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1115         * procfs.c (procfs_target::pass_signals): Adjust.
1116         * record-full.c (record_full_target::resume): Adjust.
1117         * remote.c (remote_target::pass_signals)
1118         (remote_target::program_signals): Adjust.
1119         * target-debug.h (target_debug_print_signals): Now takes a
1120         gdb::array_view as parameter.  Adjust.
1121         * target.h (target_ops) <pass_signals, program_signals>: Replace
1122         pointer and length parameters with gdb::array_view.
1123         (target_pass_signals, target_program_signals): Likewise.
1124         * target-delegates.c: Regenerate.
1125
1126 2019-01-24  Pedro Alves  <palves@redhat.com>
1127
1128         * common/forward-scope-exit.h
1129         (forward_scope_exit::forward_scope_exit): Pass arguments to
1130         m_bind_function directly, instead of creating a std::bind and
1131         copying that.
1132
1133 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1134
1135         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1136         for static members.
1137         (pass_in_v_vfp_candidate): Likewise.
1138
1139 2019-01-23  Tom Tromey  <tom@tromey.com>
1140             Pedro Alves  <palves@redhat.com>
1141
1142         * regcache.c (class regcache_invalidator): Remove.
1143         (regcache::raw_write): Use make_scope_exit.
1144
1145 2019-01-23  Tom Tromey  <tom@tromey.com>
1146
1147         * ui-out.h (class ui_out_emit_type): Update comment.
1148
1149 2019-01-23  Tom Tromey  <tom@tromey.com>
1150
1151         * infrun.c (fetch_inferior_event): Update comment.
1152
1153 2019-01-23  Tom Tromey  <tom@tromey.com>
1154             Pedro Alves  <palves@redhat.com>
1155
1156         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1157         parameter.
1158         (fetch_inferior_event): Use SCOPE_EXIT.
1159
1160
1161 2019-01-23  Tom Tromey  <tom@tromey.com>
1162             Pedro Alves  <palves@redhat.com>
1163
1164         * infrun.c (disable_thread_events): Delete.
1165         (stop_all_threads): Use SCOPE_EXIT.
1166
1167 2019-01-23  Tom Tromey  <tom@tromey.com>
1168             Pedro Alves  <palves@redhat.com>
1169
1170         * symfile.c: Include forward-scope-exit.h.
1171         (clear_symtab_users_cleanup): Replace forward declaration with
1172         a FORWARD_SCOPE_EXIT.
1173         (syms_from_objfile_1): Use the forward_scope_exit and
1174         gdb::optional instead of cleanup_function.
1175         (reread_symbols): Use the forward_scope_exit instead of
1176         cleanup_function.
1177         (clear_symtab_users_cleanup): Remove function.
1178
1179 2019-01-23  Tom Tromey  <tom@tromey.com>
1180             Pedro Alves  <palves@redhat.com>
1181
1182         * linux-nat.c: Include scope-exit.h.
1183         (cleanup_target_stop): Remove.
1184         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1185         SCOPE_EXIT.
1186
1187 2019-01-23  Tom Tromey  <tom@tromey.com>
1188             Pedro Alves  <palves@redhat.com>
1189
1190         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1191         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1192
1193 2019-01-23  Tom Tromey  <tom@tromey.com>
1194             Andrew Burgess  <andrew.burgess@embecosm.com>
1195             Pedro Alves  <palves@redhat.com>
1196
1197         * infrun.c (fetch_inferior_event): Use scope_exit.
1198         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1199         * top.c (execute_command): Use scope_exit.
1200         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1201         * utils.c (do_bpstat_clear_actions_cleanup)
1202         (make_bpstat_clear_actions_cleanup): Remove.
1203
1204 2019-01-23  Tom Tromey  <tom@tromey.com>
1205             Pedro Alves  <palves@redhat.com>
1206
1207         * infrun.c: Include "common/scope-exit.h"
1208         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1209         (wait_for_inferior): Use SCOPE_EXIT.
1210         (fetch_inferior_event): Use scope_exit.
1211
1212 2019-01-23  Tom Tromey  <tom@tromey.com>
1213             Pedro Alves  <palves@redhat.com>
1214
1215         * breakpoint.c (create_breakpoint): Remove cleanup.
1216
1217 2019-01-23  Tom Tromey  <tom@tromey.com>
1218             Andrew Burgess  <andrew.burgess@embecosm.com>
1219             Pedro Alves  <palves@redhat.com>
1220
1221 2019-01-23  Pedro Alves  <palves@redhat.com>
1222
1223         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1224
1225 2019-01-23  Pedro Alves  <palves@redhat.com>
1226             Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * gdbthread.h: Include "common/forward-scope-exit.h".
1229         (scoped_finish_thread_state): Redefine custom class in terms of
1230         forward_scope_exit.
1231
1232 2019-01-23  Pedro Alves  <palves@redhat.com>
1233             Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * common/forward-scope-exit.h: New file.
1236
1237 2019-01-23  Pedro Alves  <palves@redhat.com>
1238             Andrew Burgess  <andrew.burgess@embecosm.com>
1239             Tom Tromey  <tom@tromey.com>
1240
1241         * common/scope-exit.h: New file.
1242
1243 2019-01-23  Pedro Alves  <palves@redhat.com>
1244
1245         * common/preprocessor.h (ESC): Rename to ...
1246         (ESC_PARENS): ... this.
1247         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1248         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1249
1250 2019-01-23  Tom Tromey  <tom@tromey.com>
1251
1252         * language.h (class scoped_switch_to_sym_language_if_auto):
1253         Initialize m_lang in both cases.
1254
1255 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1258         with XCNEW.
1259
1260 2019-01-22  Tom Tromey  <tom@tromey.com>
1261
1262         * corelow.c: Do not include sys/file.h.
1263
1264 2019-01-22  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-wingeneral.h: Include gdb_curses.h.
1267
1268 2019-01-22  Tom Tromey  <tom@tromey.com>
1269
1270         * source-cache.h (class source_cache) <get_source_lines,
1271         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1272
1273 2019-01-22  Tom Tromey  <tom@tromey.com>
1274
1275         * remote-fileio.h (struct remote_target): Declare.
1276
1277 2019-01-22  Tom Tromey  <tom@tromey.com>
1278
1279         * python/py-arch.c: Do not include py-ref.h.
1280         * python/py-bpevent.c: Do not include py-ref.h.
1281         * python/py-cmd.c: Do not include py-ref.h.
1282         * python/py-continueevent.c: Do not include py-ref.h.
1283         * python/py-event.h: Do not include py-ref.h.
1284         * python/py-evtregistry.c: Do not include py-ref.h.
1285         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1286         * python/py-frame.c: Do not include py-ref.h.
1287         * python/py-framefilter.c: Do not include py-ref.h.
1288         * python/py-function.c: Do not include py-ref.h.
1289         * python/py-infevents.c: Do not include py-ref.h.
1290         * python/py-linetable.c: Do not include py-ref.h.
1291         * python/py-objfile.c: Do not include py-ref.h.
1292         * python/py-param.c: Do not include py-ref.h.
1293         * python/py-prettyprint.c: Do not include py-ref.h.
1294         * python/py-progspace.c: Do not include py-ref.h.
1295         * python/py-symbol.c: Do not include py-ref.h.
1296         * python/py-symtab.c: Do not include py-ref.h.
1297         * python/py-type.c: Do not include py-ref.h.
1298         * python/py-unwind.c: Do not include py-ref.h.
1299         * python/py-utils.c: Do not include py-ref.h.
1300         * python/py-value.c: Do not include py-ref.h.
1301         * python/py-varobj.c: Do not include py-ref.h.
1302         * python/py-xmethods.c: Do not include py-ref.h.
1303         * python/python.c: Do not include py-ref.h.
1304         * varobj.c: Do not include py-ref.h.
1305
1306 2019-01-22  Tom Tromey  <tom@tromey.com>
1307
1308         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1309         keyword for bcache.
1310
1311 2019-01-22  Tom Tromey  <tom@tromey.com>
1312
1313         * compile/compile-cplus-types.c: Remove a comment by #include.
1314
1315 2019-01-22  Tom Tromey  <tom@tromey.com>
1316
1317         * compile/gcc-c-plugin.h: Include compile-internal.h.
1318
1319 2019-01-22  Tom Tromey  <tom@tromey.com>
1320
1321         * stabsread.c (EXTERN): Do not define.
1322         (symnum, next_symbol_text_func, processing_gcc_compilation)
1323         (within_function, global_sym_chain, global_stabs)
1324         (previous_stab_code, this_object_header_files)
1325         (n_this_object_header_files)
1326         (n_allocated_this_object_header_files): Define.
1327         * stabsread.h (EXTERN): Never define.  Use "extern".
1328
1329 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1330
1331         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1332         history_value.
1333
1334 2019-01-21  Tom Tromey  <tom@tromey.com>
1335
1336         * ui-out.c: Fix includes.
1337         * tui/tui-source.c: Fix includes.
1338         * target.c: Fix includes.
1339         * remote.c: Fix includes.
1340         * regcache.c: Fix includes.
1341         * python/py-block.c: Fix includes.
1342         * printcmd.c: Fix includes.
1343         * or1k-tdep.c: Fix includes.
1344         * mi/mi-main.c: Fix includes.
1345         * m32r-tdep.c: Fix includes.
1346         * csky-tdep.c: Fix includes.
1347         * compile/compile-cplus-types.c: Fix includes.
1348         * cli/cli-interp.c: Fix includes.
1349
1350 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1351
1352         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1353         for padding.
1354
1355 2019-01-16  Tom Tromey  <tom@tromey.com>
1356
1357         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1358         earlier.
1359         (struct objfile) <msymbols_range>: Move from top level.
1360         <msymbols>: New method.
1361         (class objfile_msymbols): Remove.
1362         * symtab.c (default_collect_symbol_completion_matches_break_on):
1363         Update.
1364         * symmisc.c (dump_msymbols): Update.
1365         * stabsread.c (scan_file_globals): Update.
1366         * objc-lang.c (info_selectors_command, info_classes_command)
1367         (find_methods): Update.
1368         * minsyms.c (find_solib_trampoline_target): Update.
1369         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1370         * coffread.c (coff_symfile_read): Update.
1371         * ada-lang.c (ada_lookup_simple_minsym)
1372         (ada_collect_symbol_completion_matches): Update.
1373
1374 2019-01-16  Tom Tromey  <tom@tromey.com>
1375
1376         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1377         type.  Remove no-argument constructor.
1378         <iterator::operator++>: Simplify.
1379         <begin>: Update.
1380         <end>: Use minimal_symbol_count.
1381
1382 2019-01-16  Tom Tromey  <tom@tromey.com>
1383
1384         * objfiles.h (struct objfile) <psymtabs>: New method.
1385         (class objfile_psymtabs): Remove.
1386         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1387         typedef.
1388         <range>: New method.
1389         (require_partial_symbols): Change return type.
1390         * psymtab.c (require_partial_symbols)
1391         (psym_expand_symtabs_matching): Update.
1392         * mdebugread.c (parse_partial_symbols): Update.
1393         * dbxread.c (dbx_end_psymtab): Update.
1394
1395 2019-01-15  Tom Tromey  <tom@tromey.com>
1396
1397         * symtab.c (lookup_objfile_from_block)
1398         (lookup_symbol_in_objfile_symtabs)
1399         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1400         (find_line_symtab, info_sources_command)
1401         (default_collect_symbol_completion_matches_break_on)
1402         (make_source_files_completion_list): Update.
1403         * symmisc.c (print_objfile_statistics, dump_objfile)
1404         (maintenance_print_symbols, maintenance_info_symtabs)
1405         (maintenance_check_symtabs, maintenance_info_line_tables):
1406         Update.
1407         * source.c (select_source_symtab)
1408         (forget_cached_source_info_for_objfile): Update.
1409         * objfiles.h (class objfile_compunits): Remove.
1410         (struct objfile) <compunits_range>: New typedef.
1411         (compunits): New method.
1412         * objfiles.c (objfile_relocate1): Update.
1413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1414         * maint.c (count_symtabs_and_blocks): Update.
1415         * linespec.c (iterate_over_all_matching_symtabs): Update.
1416         * cp-support.c (add_symbol_overload_list_qualified): Update.
1417         * coffread.c (coff_symtab_read): Update.
1418         * ada-lang.c (add_nonlocal_symbols)
1419         (ada_collect_symbol_completion_matches)
1420         (ada_add_global_exceptions): Update.
1421
1422 2019-01-15  Tom Tromey  <tom@tromey.com>
1423
1424         * progspace.h (program_space) <objfiles_safe_range>: New
1425         typedef.
1426         <objfiles_safe>: New method.
1427         * objfiles.h (class all_objfiles_safe): Remove.
1428         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1429         * jit.c (jit_inferior_exit_hook): Update.
1430
1431 2019-01-17  Tom Tromey  <tom@tromey.com>
1432
1433         * progspace.h (program_space) <objfiles_range>: New typedef.
1434         <objfiles>: New method.
1435         <objfiles_head>: Rename from objfiles.
1436         (object_files): Update.
1437         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1438         * guile/scm-pretty-print.c
1439         (ppscm_find_pretty_printer_from_objfiles): Update.
1440         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1441         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1442         Update.
1443         * python/py-progspace.c (pspy_get_objfiles): Update.
1444         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1445         Update.
1446         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1447         (objfpy_lookup_objfile_by_build_id): Update.
1448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1449         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1450         Update.
1451         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1452         (expand_symtab_containing_pc, lookup_objfile_from_block)
1453         (lookup_static_symbol, basic_lookup_transparent_type)
1454         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1455         (find_line_symtab, info_sources_command)
1456         (default_collect_symbol_completion_matches_break_on)
1457         (make_source_files_completion_list, find_main_name): Update.
1458         * symmisc.c (print_symbol_bcache_statistics)
1459         (print_objfile_statistics, maintenance_print_symbols)
1460         (maintenance_print_msymbols, maintenance_print_objfiles)
1461         (maintenance_info_symtabs, maintenance_check_symtabs)
1462         (maintenance_expand_symtabs, maintenance_info_line_tables):
1463         Update.
1464         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1465         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1466         (map_overlay_command, unmap_overlay_command)
1467         (simple_overlay_update, expand_symtabs_matching)
1468         (map_symbol_filenames): Update.
1469         * symfile-debug.c (set_debug_symfile): Update.
1470         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1471         Update.
1472         * source.c (select_source_symtab, forget_cached_source_info):
1473         Update.
1474         * solib.c (solib_read_symbols): Update.
1475         * solib-spu.c (append_ocl_sos): Update.
1476         * psymtab.c (maintenance_print_psymbols)
1477         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1478         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1479         * printcmd.c (info_symbol_command): Update.
1480         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1481         Update.
1482         * objfiles.h (class all_objfiles): Remove.
1483         * objfiles.c (have_partial_symbols, have_full_symbols)
1484         (have_minimal_symbols, qsort_cmp, update_section_map)
1485         (shared_objfile_contains_address_p)
1486         (default_iterate_over_objfiles_in_search_order): Update.
1487         * objc-lang.c (info_selectors_command, info_classes_command)
1488         (find_methods): Update.
1489         * minsyms.c (find_solib_trampoline_target): Update.
1490         * maint.c (maintenance_info_sections)
1491         (maintenance_translate_address, count_symtabs_and_blocks):
1492         Update.
1493         * main.c (captured_main_1): Update.
1494         * linux-thread-db.c (try_thread_db_load_from_pdir)
1495         (has_libpthread): Update.
1496         * linespec.c (iterate_over_all_matching_symtabs)
1497         (search_minsyms_for_name): Update.
1498         * jit.c (jit_find_objf_with_entry_addr): Update.
1499         * hppa-tdep.c (find_unwind_entry)
1500         (hppa_lookup_stub_minimal_symbol): Update.
1501         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1502         Update.
1503         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1504         (elf_gnu_ifunc_resolve_by_got): Update.
1505         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1506         * dwarf-index-write.c (save_gdb_index_command): Update.
1507         * cp-support.c (add_symbol_overload_list_qualified): Update.
1508         * breakpoint.c (create_overlay_event_breakpoint)
1509         (create_longjmp_master_breakpoint)
1510         (create_std_terminate_master_breakpoint)
1511         (create_exception_master_breakpoint): Update.
1512         * blockframe.c (find_pc_partial_function): Update.
1513         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1514         (ada_collect_symbol_completion_matches)
1515         (ada_add_global_exceptions): Update.
1516
1517 2019-01-17  Tom Tromey  <tom@tromey.com>
1518
1519         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1520         declare VEC.
1521         (solib_target_parse_libraries): Change return type.
1522         (library_list_start_segment, library_list_start_section)
1523         (library_list_end_library, library_list_start_library); Update.
1524         (solib_target_free_library_list): Remove.
1525         (solib_target_parse_libraries): Remove cleanup.  Change return
1526         type.
1527         (solib_target_current_sos): Update.
1528
1529 2019-01-17  Tom Tromey  <tromey@bapiya>
1530
1531         * valprint.c: Replace "the the" with "the".
1532         * symtab.c: Replace "the the" with "the".
1533         * solib.c: Replace "the the" with "the".
1534         * solib-dsbt.c: Replace "the the" with "the".
1535         * linespec.c: Replace "the the" with "the".
1536         * dwarf2loc.h: Replace "the the" with "the".
1537         * amd64-windows-tdep.c: Replace "the the" with "the".
1538         * aarch64-tdep.c: Replace "the the" with "the".
1539
1540 2019-01-16  Keith Seitz  <keiths@redhat.com>
1541
1542         PR gdb/23773
1543         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1544         <builder>: Rename to ..
1545         <m_builder>: ... this and make private.
1546         (dwarf2_cu::get_builder): New method.  Change all users of
1547         `builder' to use this method.
1548         (dwarf2_start_symtab): Move to ...
1549         (dwarf2_cu::start_symtab): ... here.  Update all callers
1550         (setup_type_unit_groups): Move to ...
1551         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1552         callers.
1553         (dwarf2_cu::reset_builder): New method.
1554         (process_full_compunit, process_full_type_unit): Use
1555         dwarf2_cu::reset_builder.
1556         (follow_die_offset): Record the ancestor CU if it is different
1557         from the followed DIE's CU.
1558         (follow_die_sig_1): Likewise.
1559
1560 2019-01-15  Tom Tromey  <tom@tromey.com>
1561
1562         * remote.c (class remote_state) <buf>: Now a char_vector.
1563         <buf_size>: Remove.
1564         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1565         parameter.
1566         (remote_target::getpkt_or_notif_sane_1)
1567         (remote_target::getpkt_sane)
1568         (remote_target::getpkt_or_notif_sane): Likewise.
1569         (class remote_target) <putpkt>: New overload.
1570         (remote_target::read_frame): Change type of "buf_p".  Remove
1571         sizeof_p parameter.
1572         (packet_ok): New overload.
1573         (packet_check_result): New overload.
1574         Update all uses.
1575
1576 2019-01-14  Tom Tromey  <tom@tromey.com>
1577
1578         * remote-notif.c (handle_notification, remote_notif_ack)
1579         (remote_notif_parse): Make "buf" const.
1580         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1581         const.
1582         (remote_notif_parse, remote_notif_ack, handle_notification):
1583         Likewise.
1584         * remote.c (remote_notif_stop_parse): Make "buf" const.
1585         (remote_target::remote_parse_stop_reply): Make "buf" const.
1586         (remote_notif_stop_ack): Make "buf" const.
1587
1588 2019-01-14  Tom Tromey  <tom@tromey.com>
1589
1590         * remote.c (remote_console_output): Make parameter const.
1591
1592 2019-01-14  Tom Tromey  <tom@tromey.com>
1593
1594         * target-debug.h (target_debug_print_signals): Constify.
1595         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1596         * procfs.c (procfs_target::pass_signals): Update.
1597         * linux-nat.c (linux_nat_target::pass_signals): Update.
1598         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1599         * target-delegates.c: Rebuild.
1600         * remote.c (remote_target::program_signals): Update.
1601         (remote_target::pass_signals): Update.
1602         * target.c (target_pass_signals): Constify argument.
1603         (target_program_signals): Likewise.
1604         * target.h (struct target_ops) <pass_signals, program_signals>:
1605         Constify argument.
1606         (target_pass_signals, target_program_signals): Constify argument.
1607
1608 2019-01-14  Tom Tromey  <tom@tromey.com>
1609
1610         PR tui/28819:
1611         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1612
1613 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1614
1615         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1616         field.
1617         * rs6000-tdep.c: Include reggroups.h.
1618         (IS_V_ALIAS_PSEUDOREG): Define.
1619         (rs6000_register_name): Return names for the "vX" aliases.
1620         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1621         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1622         aliases.  Call default_register_reggroup_p for all other
1623         pseudo-registers.
1624         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1625         New functions.
1626         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1627         Handle "vX" aliases.
1628         (v_alias_pseudo_register_collect): New function.
1629         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1630         (rs6000_gdbarch_init): Initialize "vX" aliases as
1631         pseudo-registers.  Restore registration of
1632         rs6000_pseudo_register_reggroup_p with
1633         set_tdesc_pseudo_register_reggroup_p.
1634
1635 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1636
1637         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1638         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1639         set_gdbarch_num_pseudo_regs.
1640
1641 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1642
1643         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1644         Remove arg prefixname, add do_set and do_show.
1645         Add member functions set_list and show_list.
1646         * cli/cli-style.c (class cli_style_option): Update accordingly.
1647         (style_set_list): Move to file scope.
1648         (style_show_list): Likewise.
1649         (set_style): Call help_list.
1650         (show_style): Call cmd_show_list.
1651         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1652         Update to use the new macro.
1653
1654 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1655
1656         * ada-lang.c (_initialize_ada_language): Expand the help text
1657         for the "catch exception" command.
1658
1659 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1660
1661         * symtab.c (matching_obj_sections): Initialize obj,
1662         declare it closer to its usage.
1663
1664 2019-01-10  Tom Tromey  <tom@tromey.com>
1665
1666         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1667         (basic_inf_threads_range): Remove.
1668         (inf_threads_range, inf_non_exited_threads_range)
1669         (safe_inf_threads_range): Use next_adapter.
1670
1671 2019-01-10  Keith Seitz  <keiths@redhat.com>
1672
1673         PR gdb/23712
1674         PR symtab/23010
1675         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1676         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1677
1678 2019-01-10  Keith Seitz  <keiths@redhat.com>
1679
1680         PR gdb/23712
1681         PR symtab/23010
1682         * dictionary.c (pending_to_vector): Remove.
1683         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1684         Remove _1 suffix, replacing functions of the same name.  Update
1685         all callers.
1686         (dict_create_hashed, dict_create_hashed_expandable)
1687         (dict_create_linear, dict_create_linear_expandable, dict_free)
1688         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1689         Make functions static.
1690
1691 2019-01-10  Keith Seitz  <keiths@redhat.com>
1692
1693         PR gdb/23712
1694         PR symtab/23010
1695         * dictionary.h (struct dictionary): Replace declaration with
1696         multidictionary.
1697         (dict_create_hashed, dict_create_hashed_expandable)
1698         (dict_create_linear, dict_create_linear_expandable)
1699         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1700         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1701         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1702         taking multidictionary argument.
1703         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1704         * block.h (struct block) <dict>: Change to multidictionary
1705         and rename `multidict'.
1706         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1707         symmisc.c: Update all dictionary references to multidictionary.
1708
1709 2019-01-10  Keith Seitz  <keiths@redhat.com>
1710
1711         PR gdb/23712
1712         PR symtab/23010
1713         * dictionary.c: Include unordered_map.
1714         (pending_to_vector): New function.
1715         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1716         Rewrite the non-"_1" functions to take vector instead
1717         of linked list.
1718         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1719         "new" _1 versions of the same name.
1720         (multidictionary): Define.
1721         (std::hash<enum language): New definition.
1722         (collate_pending_symbols_by_language, mdict_create_hashed)
1723         (mdict_create_hashed_expandable, mdict_create_linear)
1724         (mdict_create_linear_expandable, mdict_free)
1725         (find_language_dictionary, create_new_language_dictionary)
1726         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1727         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1728         (mdict_size, mdict_empty): New functions.
1729         * dictionary.h (mdict_iterator): Define.
1730
1731 2019-01-10  Pedro Alves  <palves@redhat.com>
1732
1733         * breakpoint.c (read_uploaded_action)
1734         (create_tracepoint_from_upload): Adjust to use
1735         gdb::unique_xmalloc_ptr.
1736         * ctf.c (ctf_write_uploaded_tp):
1737         (SET_ARRAY_FIELD): Use emplace_back.
1738         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1739         * tracefile-tfile.c (tfile_write_uploaded_tp):
1740         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1741         gdb::unique_xmalloc_ptr.
1742         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1743         at_string, cond_string, cmd_strings>: Replace char pointers
1744         with gdb::unique_xmalloc_ptr.
1745
1746 2019-01-10  Pedro Alves  <palves@redhat.com>
1747
1748         * solib-target.c (library_list_start_library): Don't xstrdup name.
1749
1750 2019-01-10  Pedro Alves  <palves@redhat.com>
1751
1752         * mdebugread.c (parse_partial_symbols): Use
1753         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1754
1755 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * linux-fork.c (scoped_switch_fork_info)
1758         <~scoped_switch_fork_info>: Fix incorrect variable name.
1759
1760 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1761
1762         * linux-fork.c (scoped_switch_fork_info)
1763         <scoped_switch_fork_info>: Make explicit.
1764         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1765
1766 2019-01-10  Tom Tromey  <tom@tromey.com>
1767
1768         * objfiles.h (objfile::reset_psymtabs): Update.
1769         * objfiles.c (objfile::objfile): Update.
1770         * psymtab.h (psymtab_storage::obstack): Update.
1771         (psymtab_storage::m_obstack): Use gdb::optional.
1772         (class psymtab_storage): Update comment.  Remove objfile
1773         parameter.
1774         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1775
1776 2019-01-10  Tom Tromey  <tom@tromey.com>
1777
1778         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1779         <free_psymtabs>: Now private.
1780         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1781         (allocate_psymtab): Use new method.
1782
1783 2019-01-10  Tom Tromey  <tom@tromey.com>
1784
1785         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1786         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1787         * mdebugread.c (parse_partial_symbols): Use
1788         allocate_dependencies.
1789         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1790         allocate_dependencies.
1791         (process_psymtab_comp_unit_reader)
1792         (build_type_psymtab_dependencies): Likewise.
1793         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1794
1795 2019-01-10  Tom Tromey  <tom@tromey.com>
1796
1797         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1798         PSYMBOL_SET_LANGUAGE.
1799         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1800
1801 2019-01-10  Tom Tromey  <tom@tromey.com>
1802
1803         * psymtab.h (psymtab_storage::obstack): New method.
1804         <m_obstack>: Rename from obstack; now private.
1805         * psymtab.c (psymtab_storage): Update.
1806         * dwarf2read.c (create_addrmap_from_index)
1807         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1808         Update.
1809
1810 2019-01-10  Tom Tromey  <tom@tromey.com>
1811
1812         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1813         * objfiles.h (objfile::reset_psymtabs): New method.
1814
1815 2019-01-10  Tom Tromey  <tom@tromey.com>
1816
1817         * symmisc.c (print_symbol_bcache_statistics): Update.
1818         (print_objfile_statistics): Update.
1819         * symfile.c (reread_symbols): Update.
1820         * psymtab.h (class psymtab_storage): New.
1821         * psymtab.c (psymtab_storage): New constructor.
1822         (~psymtab_storage): New destructor.
1823         (require_partial_symbols): Update.
1824         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1825         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1826         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1827         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1828         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1829         (start_psymtab_common, end_psymtab_common)
1830         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1831         (allocate_psymtab): Update.
1832         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1833         Update.
1834         (dump_psymtab_addrmap, maintenance_print_psymbols)
1835         (maintenance_check_psymtabs): Update.
1836         (class objfile_psymtabs): Move to objfiles.h.
1837         * psympriv.h (discard_psymtab): Now inline.
1838         (psymtab_discarder::psymtab_discarder): Update.
1839         (psymtab_discarder::~psymtab_discarder): Update.
1840         (ALL_OBJFILE_PSYMTABS): Rewrite.
1841         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1842         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1843         Remove fields.
1844         <partial_symtabs>: New field.
1845         (class objfile_psymtabs): Move from psymtab.h.  Update.
1846         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1847         psymbol_cache.
1848         (objfile::~objfile): Don't destroy psymbol_cache.
1849         * mdebugread.c (parse_partial_symbols): Update.
1850         * dwarf2read.c (create_addrmap_from_index)
1851         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1852         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1853         (add_partial_subprogram, dwarf2_ranges_read): Update.
1854         * dwarf-index-write.c (write_address_map)
1855         (write_one_signatured_type, recursively_write_psymbols)
1856         (class debug_names, class debug_names, write_psymtabs_to_index):
1857         Update.
1858
1859 2019-01-10  Tom Tromey  <tom@tromey.com>
1860
1861         * symtab.h (SYMBOL_SET_NAMES): Update.
1862         (symbol_set_names): Update.
1863         (MSYMBOL_SET_NAMES): Update.
1864         * symtab.c (symbol_set_names): Change argument to be an
1865         objfile_per_bfd_storage.
1866         * psymtab.c (add_psymbol_to_bcache): Update.
1867         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1868
1869 2019-01-10  Tom Tromey  <tom@tromey.com>
1870
1871         * symtab.c (create_demangled_names_hash): Change argument to be an
1872         objfile_per_bfd_storage.
1873         (symbol_set_names): Update.
1874
1875 2019-01-10  Tom Tromey  <tom@tromey.com>
1876
1877         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1878         init_psymbol_list.
1879         * psymtab.c (init_psymbol_list): Do nothing if already called.
1880         * psympriv.h (init_psymbol_list): Add comment.
1881         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1882         init_psymbol_list.
1883         * dbxread.c (dbx_symfile_read): Unconditionally call
1884         init_psymbol_list.
1885
1886 2019-01-10  Tom Tromey  <tom@tromey.com>
1887
1888         * xcoffread.c (scan_xcoff_symtab): Update.
1889         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1890         "where".
1891         * mdebugread.c (parse_partial_symbols)
1892         (handle_psymbol_enumerators): Update.
1893         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1894         * dbxread.c (read_dbx_symtab): Update.
1895         * psympriv.h (psymbol_placement): New enum.
1896         (add_psymbol_to_list): Update.
1897
1898 2019-01-10  Tom Tromey  <tom@tromey.com>
1899
1900         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1901         static_psymbols parameters.
1902         (scan_xcoff_symtab): Update.
1903         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1904         static_psymbols parameters.
1905         * psympriv.h (start_psymtab_common): Update.
1906         * mdebugread.c (parse_partial_symbols): Update.
1907         * dwarf2read.c (create_partial_symtab): Update.
1908         * dbxread.c (read_dbx_symtab): Update.
1909         (start_psymtab): Remove global_psymbols and static_psymbols
1910         parameters.
1911
1912 2019-01-10  Tom Tromey  <tom@tromey.com>
1913
1914         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1915         * psymtab.c (allocate_psymtab): Add comment.
1916         * psympriv.h (allocate_psymtab): Add comment.
1917         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1918         initializations.
1919         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1920
1921 2019-01-10  Tom Tromey  <tom@tromey.com>
1922
1923         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1924         Don't declare.
1925         * mipsread.c: Include mdebugread.h.
1926         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1927         Declare.
1928         * elfread.c: Include mdebugread.h.
1929
1930 2019-01-09  Tom Tromey  <tom@tromey.com>
1931
1932         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1933         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1934         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1935         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1936         (psym_lookup_symbol, psym_find_last_source_symtab)
1937         (psym_forget_cached_source_info, psym_print_stats)
1938         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1939         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1940         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1941         (psym_find_compunit_symtab_by_address)
1942         (maintenance_print_psymbols, maintenance_info_psymtabs)
1943         (maintenance_check_psymtabs): Use ranged for.
1944         * psymtab.h (class objfile_psymtabs): New.
1945         (require_partial_symbols): Return objfile_psymtabs.
1946         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1947
1948 2019-01-09  Tom Tromey  <tom@tromey.com>
1949
1950         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1951         (find_pc_mapped_section, list_overlays_command)
1952         (map_overlay_command, unmap_overlay_command)
1953         (simple_overlay_update): Use all_objfiles.
1954         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1955         * printcmd.c (info_symbol_command): Use all_objfiles.
1956         * objfiles.h (ALL_OBJSECTIONS): Remove.
1957         * maint.c (maintenance_translate_address): Use all_objfiles.
1958         * gcore.c (gcore_create_callback): Use all_objfiles.
1959         (objfile_find_memory_regions): Likewise.
1960
1961 2019-01-09  Tom Tromey  <tom@tromey.com>
1962
1963         * symtab.c (find_line_symtab, info_sources_command)
1964         (make_source_files_completion_list): Use objfile_compunits.
1965         * source.c (select_source_symtab): Use objfile_compunits.
1966         * objfiles.h (struct objfile): Update comment.
1967         (ALL_OBJFILES): Remove.
1968         (ALL_FILETABS): Remove.
1969         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1970         objfile_compunits.
1971
1972 2019-01-09  Tom Tromey  <tom@tromey.com>
1973
1974         * symmisc.c (print_objfile_statistics, dump_objfile)
1975         (maintenance_print_symbols): Use compunit_filetabs.
1976         * source.c (forget_cached_source_info_for_objfile): Use
1977         compunit_filetabs.
1978         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1979         (ALL_FILETABS): Use compunit_filetabs.
1980         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1981         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1982
1983 2019-01-09  Tom Tromey  <tom@tromey.com>
1984
1985         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1986         (compunit_filetabs): New.
1987         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1988         compunit_filetabs.
1989         (info_sources_command, make_source_files_completion_list): Remove
1990         declaration.
1991         * symmisc.c (print_objfile_statistics, dump_objfile)
1992         (maintenance_print_symbols): Remove declaration.
1993         (maintenance_info_symtabs): Use compunit_filetabs.
1994         (maintenance_info_line_tables): Likewise.
1995         * source.c (select_source_symtab): Change local variable name.
1996         (forget_cached_source_info_for_objfile): Remove declaration.
1997         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1998         * objfiles.c (objfile_relocate1): Remove declaration.
1999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2000         declaration.
2001         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2002         * coffread.c (coff_symtab_read): Remove declaration.
2003         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2004         compunit_filetabs.
2005
2006 2019-01-09  Tom Tromey  <tom@tromey.com>
2007
2008         * symtab.c (lookup_objfile_from_block)
2009         (find_pc_sect_compunit_symtab, search_symbols)
2010         (default_collect_symbol_completion_matches_break_on): Use
2011         objfile_compunits.
2012         * objfiles.h (ALL_COMPUNITS): Remove.
2013         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2014         * cp-support.c (add_symbol_overload_list_qualified): Use
2015         objfile_compunits.
2016         * ada-lang.c (ada_collect_symbol_completion_matches)
2017         (ada_add_global_exceptions): Use objfile_compunits.
2018
2019 2019-01-09  Tom Tromey  <tom@tromey.com>
2020
2021         * source.c (select_source_symtab)
2022         (forget_cached_source_info_for_objfile): Remove declaration.
2023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2024         declaration.
2025         * maint.c (count_symtabs_and_blocks): Remove declaration.
2026         * cp-support.c (add_symbol_overload_list_qualified): Remove
2027         declaration.
2028         * coffread.c (coff_symtab_read): Remove declaration.
2029         * symtab.c (lookup_symbol_in_objfile_symtabs)
2030         (basic_lookup_transparent_type_1): Use objfile_compunits.
2031         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2032         (info_sources_command, search_symbols)
2033         (default_collect_symbol_completion_matches_break_on)
2034         (make_source_files_completion_list): Remove declaration.
2035         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2036         (ada_collect_symbol_completion_matches)
2037         (ada_add_global_exceptions): Remove declaration.
2038         * linespec.c (iterate_over_all_matching_symtabs): Use
2039         objfile_compunits.
2040         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2041         (class objfile_compunits): New.
2042         (ALL_COMPUNITS): Use objfile_compunits.
2043         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2044         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2045         objfile_compunits.
2046         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2047
2048 2019-01-09  Tom Tromey  <tom@tromey.com>
2049
2050         * symtab.c (search_symbols)
2051         (default_collect_symbol_completion_matches_break_on): Use
2052         objfile_msymbols.
2053         * ada-lang.c (ada_lookup_simple_minsym)
2054         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2055         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2056         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2057         objfile_msymbols.
2058         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2059         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2060         * objc-lang.c (find_methods): Use objfile_msymbols.
2061         (info_selectors_command, info_classes_command): Likewise.
2062         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2063         * objfiles.h (class objfile_msymbols): New.
2064         (ALL_OBJFILE_MSYMBOLS): Remove.
2065         (ALL_MSYMBOLS): Remove.
2066
2067 2019-01-09  Tom Tromey  <tom@tromey.com>
2068
2069         * common/next-iterator.h (next_adapter): Add Iterator template
2070         parameter.
2071         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2072         (class all_objfiles_safe): New.
2073         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2074         * objfiles.c (put_objfile_before): Update comment.
2075         (add_separate_debug_objfile): Likewise.
2076         (free_all_objfiles): Use all_objfiles_safe.
2077         (objfile_purge_solibs): Likewise.
2078
2079 2019-01-09  Tom Tromey  <tom@tromey.com>
2080
2081         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2082         (expand_symtab_containing_pc, lookup_static_symbol)
2083         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2084         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2085         all_objfiles.
2086         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2087         * breakpoint.c (create_overlay_event_breakpoint)
2088         (create_longjmp_master_breakpoint)
2089         (create_std_terminate_master_breakpoint)
2090         (create_exception_master_breakpoint): Use all_objfiles.
2091         * linux-thread-db.c (try_thread_db_load_from_pdir)
2092         (has_libpthread): Use all_objfiles.
2093         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2094         * linespec.c (iterate_over_all_matching_symtabs)
2095         (search_minsyms_for_name): Use all_objfiles.
2096         * maint.c (maintenance_info_sections): Use all_objfiles.
2097         * main.c (captured_main_1): Use all_objfiles.
2098         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2099         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2100         * guile/scm-pretty-print.c
2101         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2102         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2103         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2104         (maintenance_print_msymbols): Use all_objfiles.
2105         * source.c (select_source_symtab): Use all_objfiles.
2106         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2107         * symfile.c (remove_symbol_file_command)
2108         (expand_symtabs_matching, map_symbol_filenames): Use
2109         all_objfiles.
2110         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2111         all_objfiles.
2112         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2113         * objc-lang.c (find_methods): Use all_objfiles.
2114         * objfiles.c (have_partial_symbols, have_full_symbols)
2115         (have_minimal_symbols, qsort_cmp)
2116         (default_iterate_over_objfiles_in_search_order): Use
2117         all_objfiles.
2118         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2119         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2120         (maintenance_check_psymtabs): Use all_objfiles.
2121         (ALL_PSYMTABS): Remove.
2122         * compile/compile-object-run.c (do_module_cleanup): Use
2123         all_objfiles.
2124         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2125         * cp-support.c (add_symbol_overload_list_qualified): Use
2126         all_objfiles.
2127         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2128         Use all_objfiles.
2129         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2130         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2131         all_objfiles.
2132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2133         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2134         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2135         Uses all_objfiles.
2136         * solib.c (solib_read_symbols): Use all_objfiles
2137
2138 2019-01-09  Tom Tromey  <tom@tromey.com>
2139
2140         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2141         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2142         all_objfiles.
2143         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2144         * symmisc.c (print_symbol_bcache_statistics)
2145         (print_objfile_statistics, maintenance_print_objfiles)
2146         (maintenance_info_symtabs, maintenance_check_symtabs)
2147         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2148         all_objfiles.
2149         * source.c (forget_cached_source_info): Use all_objfiles.
2150         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2151         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2152         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2153         * objfiles.c (update_section_map): Use all_objfiles.
2154         (shared_objfile_contains_address_p): Likewise.
2155         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2156         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2157
2158 2019-01-09  Tom Tromey  <tom@tromey.com>
2159
2160         * common/next-iterator.h: New file.
2161         * objfiles.h (class all_objfiles): New.
2162         (struct objfile_iterator): New.
2163
2164 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2165
2166         * NEWS: Move the description of the changed "frame", "select-frame",
2167          and "info frame" commands to the Changed commands section.
2168
2169 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2170
2171         * gdbtypes.c (check_stub_method_group): Remove handling of old
2172         mangling schemes.
2173         * linespec.c (find_methods): Likewise.
2174         * stabsread.c (read_member_functions): Likewise.
2175         * valops.c (search_struct_method): Likewise.
2176         (value_struct_elt_for_reference): Likewise.
2177         * NEWS: Mention this change.
2178
2179 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2180
2181         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2182         print_source_lines.
2183         * source.c (print_source_lines_base): Update line number check.
2184         (print_source_lines): New function.
2185         (source_lines_range::source_lines_range): New function.
2186         * source.h (class source_lines_range): New class.
2187         (print_source_lines): New declaration.
2188
2189 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2190
2191         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2192
2193 2019-01-08  Tom Tromey  <tom@tromey.com>
2194             Simon Marchi  <simon.marchi@ericsson.com>
2195
2196         PR gdb/24060
2197         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2198         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2199         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2200         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2201         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2202         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2203
2204 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * source.c (select_source_symtab): Move header comment to
2207         declaration in source.h.
2208         (forget_cached_source_info_for_objfile): Likewise.
2209         (forget_cached_source_info): Likewise.
2210         (identify_source_line): Likewise.
2211         * source.h (identify_source_line): Move declaration from symtab.h
2212         and add comment from source.c
2213         (print_source_lines): Likewise.
2214         (forget_cached_source_info_for_objfile): Likewise.
2215         (forget_cached_source_info): Likewise.
2216         (select_source_symtab): Likewise.
2217         (enum print_source_lines_flag): Move definition from symtab.h.
2218         * symtab.h (identify_source_line): Move declaration to source.h.
2219         (print_source_lines): Likewise.
2220         (forget_cached_source_info_for_objfile): Likewise.
2221         (forget_cached_source_info): Likewise.
2222         (select_source_symtab): Likewise.
2223         (enum print_source_lines_flag): Move definition to source.h.
2224         * tui/tui-hooks.c: Add 'source.h' include.
2225
2226 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * source.c (print_source_lines_base): Handle requests to print
2229         reverse line number sequences, and guard against empty lines
2230         string.
2231
2232 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * source.c (print_source_lines_base): Fix skip of '\r' if next
2235         character is '\n'.
2236
2237 2019-01-06  Tom Tromey  <tom@tromey.com>
2238
2239         * c-exp.y (struct c_parse_state) <macro_original_text,
2240         expansion_obstack>: New member.
2241         (macro_original_text, expansion_obstack): Remove globals.
2242         (scan_macro_expansion, scanning_macro_expansion)
2243         (finished_macro_expansion): Update.
2244         (scan_macro_cleanup): Remove.
2245         (yylex, c_parse): Update.
2246
2247 2019-01-06  Tom Tromey  <tom@tromey.com>
2248
2249         * c-exp.y (struct c_parse_state) <strings>: New member.
2250         (operator_stoken): Update.
2251
2252 2019-01-06  Tom Tromey  <tom@tromey.com>
2253
2254         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2255         (union type_stack_elt) <typelist_val>: Now a pointer to
2256         std::vector.
2257         (type_stack_cleanup): Don't declare.
2258         (push_typelist): Update.
2259         * parse.c (pop_typelist): Return a std::vector.
2260         (push_typelist): Take a std::vector.
2261         (follow_types): Update.  Do not free args.
2262         (type_stack_cleanup): Remove.
2263         * c-exp.y (struct c_parse_state): New.
2264         (cpstate): New global.
2265         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2266         (nonempty_typelist): Update.
2267         (func_mod): Create a new vector.
2268         (c_parse): Create a c_parse_state.
2269         (check_parameter_typelist): Do not delete params.
2270         (function_method): Update.  Do not delete type_list.
2271
2272 2019-01-06  Tom Tromey  <tom@tromey.com>
2273
2274         PR gdb/28155:
2275         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2276         check_typedef.
2277         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2278         (print_return_value): Likewise.
2279
2280 2019-01-05  Tom Tromey  <tom@tromey.com>
2281
2282         * contrib/cleanup_check.py: Remove.
2283         * contrib/gcc-with-excheck: Remove.
2284         * contrib/exsummary.py: Remove.
2285         * contrib/excheck.py: Remove.
2286
2287 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2288
2289         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2290         NULL. Initialize tpprev to NULL instead of assigning it
2291         to NULL on the next statement.
2292         * windows-nat.c (windows_delete_thread): Remove check for
2293         main_thread_id before printing thread exit notifications.
2294         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2295         Remove thread ID check against main_thread_id.
2296         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2297         windows_delete_thread.
2298         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2299
2300 2019-01-04  Tom Tromey  <tom@tromey.com>
2301
2302         * compile/compile.c (_initialize_compile): Use upper case for
2303         metasyntactic variables.
2304         * symmisc.c (_initialize_symmisc): Use upper case for
2305         metasyntactic variables.
2306         * psymtab.c (_initialize_psymtab): Use upper case for
2307         metasyntactic variables.
2308         * demangle.c (demangle_command): Use upper case for metasyntactic
2309         variables.
2310         (_initialize_demangler): Likewise.
2311         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2312         variables.
2313
2314 2019-01-03  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2317
2318 2019-01-03  Tom Tromey  <tom@tromey.com>
2319
2320         * python/py-symtab.c (salpy_str): Update.
2321         (struct salpy_sal_object) <symtab>: Now a PyObject.
2322         (salpy_dealloc): Update.
2323         (del_objfile_sal): Use gdbpy_ref.
2324
2325 2019-01-03  Tom Tromey  <tom@tromey.com>
2326
2327         * python/py-type.c (convert_field): Use new_reference.  Return
2328         gdbpy_ref.
2329         (make_fielditem): Return gdbpy_ref.
2330         (typy_fields): Update.
2331         (typy_getitem): Update.
2332         (field_name): Return gdbpy_ref.  Use new_reference.
2333         (typy_iterator_iternext): Update.
2334
2335 2019-01-03  Tom Tromey  <tom@tromey.com>
2336
2337         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2338
2339 2019-01-03  Tom Tromey  <tom@tromey.com>
2340
2341         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2342         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2343         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2344         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2345         (pspy_set_type_printers): Likewise.
2346         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2347         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2348         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2349         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2350         (objfpy_set_type_printers): Likewise.
2351
2352 2019-01-03  Tom Tromey  <tom@tromey.com>
2353
2354         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2355         (gdbpy_print_stack): Use gdbpy_err_fetch.
2356         * python/python-internal.h (class gdbpy_err_fetch): New class.
2357         (class gdbpy_enter) <m_error_type, m_error_value,
2358         m_error_traceback>: Remove.
2359         <m_error>: New member.
2360         (gdbpy_exception_to_string): Don't declare.
2361         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2362         * python/py-value.c (convert_value_from_python): Use
2363         gdbpy_err_fetch.
2364         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2365         gdbpy_exception_to_string.
2366         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2367         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2368         gdbpy_err_fetch.
2369
2370 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * linux-nat.c (delete_lwp_cleanup): Delete.
2373         (struct lwp_deleter): New struct.
2374         (lwp_info_up): New typedef.
2375         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2376         lwp_info_up.
2377
2378 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2379
2380         * linux-fork.c (class scoped_switch_fork_info): New class.
2381         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2382
2383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2384
2385         * valops.c (find_overload_match): Remove use of null_cleanup, and
2386         calls to do_cleanups.
2387
2388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2389
2390         * compile/compile-cplus-types.c
2391         (compile_cplus_instance::decl_name): Handle changes to
2392         cp_func_name.
2393         * cp-support.c (cp_func_name): Update header comment, update
2394         return type.
2395         * cp-support.h (cp_func_name): Update return type in declaration.
2396         * valops.c (find_overload_match): Move temp_func local to top
2397         level of function and change its type.  Use temp_func to hold and
2398         delete temporary string obtained from cp_func_name.
2399
2400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2403         gdb::char_vector, remove cleanup, and update uses of `msg`.
2404
2405 2019-01-03  Jim Wilson  <jimw@sifive.com>
2406
2407         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2408
2409 2019-01-02  Tom Tromey  <tom@tromey.com>
2410
2411         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2412         (tdesc_parse_xml): Remove cleanups.
2413         * target-descriptions.h (make_cleanup_free_target_description):
2414         Don't declare.
2415         (target_desc_deleter): New struct.
2416         (target_desc_up): New typedef.
2417         * target-descriptions.c (target_desc_deleter::operator()): Rename
2418         from free_target_description.
2419         (make_cleanup_free_target_description): Remove.
2420
2421 2019-01-02  Tom Tromey  <tom@tromey.com>
2422
2423         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2424         constructor, destructor.
2425         (linespec_parser): Remove typedef.
2426         (~linespec_parser): Rename from linespec_parser_delete.
2427         (linespec_lex_to_end, linespec_complete_label)
2428         (linespec_complete): Update.
2429         (decode_line_full): Remove cleanups.
2430         (decode_line_1): Update.
2431
2432 2019-01-02  Tom Tromey  <tom@tromey.com>
2433
2434         * python/python-internal.h (inferior_to_inferior_object): Change
2435         return type.
2436         * python/py-exitedevent.c (create_exited_event_object): Update.
2437         * python/py-inferior.c (inferior_to_inferior_object): Return
2438         gdbpy_ref.
2439         (python_new_inferior, python_inferior_deleted)
2440         (thread_to_thread_object, delete_thread_object)
2441         (build_inferior_list, gdbpy_selected_inferior): Update.
2442         * python/py-infthread.c (create_thread_object): Update.  Also fail
2443         if inferior_to_inferior_object fails.
2444
2445 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2446
2447         * inferior.h (class inferior) <displaced_step_state>: New field.
2448         * infrun.h (struct displaced_step_state): Move here from
2449         infrun.c.  Initialize fields, add constructor.
2450         <inf>: Remove field.
2451         <reset>: New method.
2452         * infrun.c (struct displaced_step_inferior_state): Move to
2453         infrun.h.
2454         (displaced_step_inferior_states): Remove.
2455         (get_displaced_stepping_state): Adust.
2456         (displaced_step_in_progress_any_inferior): Adjust.
2457         (displaced_step_in_progress_thread): Adjust.
2458         (displaced_step_in_progress): Adjust.
2459         (add_displaced_stepping_state): Remove.
2460         (get_displaced_step_closure_by_addr): Adjust.
2461         (remove_displaced_stepping_state): Remove.
2462         (infrun_inferior_exit): Call displaced_step_state.reset.
2463         (use_displaced_stepping): Don't check for NULL.
2464         (displaced_step_prepare_throw): Call
2465         get_displaced_stepping_state.
2466         (displaced_step_fixup): Don't check for NULL.
2467         (prepare_for_detach): Don't check for NULL.
2468
2469 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2470
2471         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2472          in case of call that did not complete.
2473
2474 2019-01-02  Andrey Utkin  <autkin@undo.io>
2475
2476         * symfile.c (find_separate_debug_file): Fix search of debug files for
2477         remote debuggee.
2478
2479 2019-01-02  Tom Tromey  <tom@tromey.com>
2480
2481         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2482         indentation.
2483         * python/py-frame.c (frapy_older): Remove cast.
2484         (frapy_newer): Likewise.
2485         * python/py-breakpoint.c (local_setattro): Remove cast.
2486         * python/py-arch.c (archpy_name): Remove local variable.
2487         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2488
2489 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2490
2491         * unittests/basic_string_view/element_access/char/empty.cc:
2492         Fix year range in copyright header.
2493
2494 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2497         Delete.
2498         <operator==>: Update with for removed field.
2499         <hash>: Likewise.
2500         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2501         <isa_features>: ...this.
2502         <abi_features>: New field.
2503         (riscv_isa_flen): Update comment.
2504         (riscv_abi_xlen): New declaration.
2505         (riscv_abi_flen): New declaration.
2506         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2507         isa_features.
2508         (riscv_abi_xlen): New function.
2509         (riscv_isa_flen): Update to get answer from isa_features.
2510         (riscv_abi_flen): New function.
2511         (riscv_has_fp_abi): Update to get answer from abi_features.
2512         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2513         xlen and flen.
2514         (riscv_call_info) <xlen, flen>: Update comment.
2515         (riscv_call_arg_struct): Remove invalid assertions
2516         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2517         is removed.
2518         (riscv_gdbarch_init): Gather isa features and abi features
2519         separately, ensure both match on the gdbarch when reusing an old
2520         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2521         a target with 64-bit float hardware.
2522
2523 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2524
2525         * source.c (search_command_helper): Stop reverse search
2526         when line 1 has been searched.
2527
2528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2529
2530         * record-full.c (record_full_base_target::close): Rewrite
2531         record_full_core_buf_list free logic.
2532
2533 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2534
2535         * break-catch-syscall.c (print_one_catch_syscall): xfree
2536         the last text.
2537
2538 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2539
2540         * top.c (print_gdb_version): Update Copyright year in version
2541         message.
2542
2543 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2544
2545         Update copyright year range in all GDB files.
2546
2547 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2548
2549         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2550
2551 For older changes see ChangeLog-2018.
2552 \f
2553 Local Variables:
2554 mode: change-log
2555 left-margin: 8
2556 fill-column: 74
2557 version-control: never
2558 coding: utf-8
2559 End:
2560