gdb/nds32: Use type_align instead of nds32_type_align
[external/binutils.git] / gdb / ChangeLog
1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * nds32-tdep.c (nds32_type_align): Delete.
4         (nds32_push_dummy_call): Use type_align instead.
5
6 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7
8         * arm-tdep.c (arm_type_align): Only handle vector override case.
9         (arm_push_dummy_call): Use type_align.
10         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11
12 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
13
14         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
15         case.
16         (pass_on_stack): Use type_align.
17         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
18         function.
19
20 2019-04-23  Tom Tromey  <tromey@adacore.com>
21
22         * dwarf2read.c (line_header::file_name_at): Remove unused
23         overload.
24
25 2019-04-23  Tom de Vries  <tdevries@suse.de>
26
27         PR gdb/24438
28         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
29         invocation.
30
31
32 2019-03-27  Ali Tamur  <tamur@google.com>
33
34         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
35         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
36         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
37         (dwarf_expr_context::get_addr_index): Likewise
38         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
39         (symbol_needs_eval_context::get_addr_index): Likewise
40         (disassemble_dwarf_expression): Add DW_OP_addrx
41         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
42         (read_cutu_die_from_dwo): Update comment
43         (skip_one_die): Add DW_FORM_addrx
44         (read_attribute_value): Likewise
45         (var_decode_location): Add DW_OP_addrx
46         (dwarf2_const_value_attr): Add DW_FORM_addrx
47         (dump_die_shallow): Likewise
48         (dwarf2_fetch_constant_bytes): Likewise
49         (decode_locdesc): Add DW_OP_addrx
50         (skip_form_bytes): Add DW_FORM_addrx
51
52 2019-04-22  Ali Tamur  <tamur@google.com>
53
54         * MAINTAINERS (Write After Approval): Add self.
55
56 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
57
58         * solib-svr4.c (get_svr4_info): Add pspace parameter.
59         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
60         (open_symbol_file_object): Likewise.
61         (svr4_default_sos): Add info parameter.
62         (svr4_read_so_list): Likewise.
63         (svr4_current_sos_direct): Adjust functions calls to pass down
64         info.
65         (svr4_current_sos_1): Add info parameter.
66         (svr4_current_sos): Call get_svr4_info, pass info down to
67         svr4_current_sos_1.
68         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
69         get_svr4_info.
70         (svr4_in_dynsym_resolve_code): Pass current_program_space to
71         get_svr4_info.
72         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
73         to get_svr4_info.
74         (probes_table_remove_objfile_probes): Likewise.
75         (register_solib_event_probe): Add info parameter.
76         (solist_update_incremental): Pass info parameter down to
77         svr4_read_so_list.
78         (disable_probes_interface): Add info parameter.
79         (svr4_handle_solib_event): Pass current_program_space to
80         get_svr4_info.  Adjust disable_probes_interface cleanup.
81         (svr4_create_probe_breakpoints): Add info parameter, pass it
82         down to register_solib_event_probe.
83         (svr4_create_solib_event_breakpoints): Add info parameter,
84         pass it down to svr4_create_probe_breakpoints.
85         (enable_break): Pass info down to
86         svr4_create_solib_event_breakpoints.
87         (svr4_solib_create_inferior_hook): Pass current_program_space to
88         get_svr4_info.
89         (svr4_clear_solib): Likewise.
90
91 2019-04-22  Pedro Alves  <palves@redhat.com>
92
93         * solib-svr4.c (svr4_free_objfile_observer): New.
94         (probe_and_action::objfile): New field.
95         (probes_table_htab_remove_objfile_probes)
96         (probes_table_remove_objfile_probes): New functions.
97         (register_solib_event_probe): Add 'objfile' parameter.  Store it
98         in the new probe_and_action.  Don't store the probe in 'lookup'.
99         (svr4_create_probe_breakpoints): Pass objfile to
100         register_solib_event_probe.
101         (_initialize_svr4_solib): Register a free_objfile observer.
102
103 2019-04-19  Tom Tromey  <tom@tromey.com>
104
105         * common/queue.h: Remove.
106
107 2019-04-19  Tom Tromey  <tom@tromey.com>
108
109         * event-loop.c: Don't include "common/queue.h".
110
111 2019-04-19  Tom Tromey  <tom@tromey.com>
112
113         * remote.c (remote_target): Use delete.
114         * remote-notif.h: Include <list>, not "common/queue.h".
115         (notif_client_p): Remove typedef.
116         (remote_notif_state): Add constructor, destructor, initializer.
117         <notif_queue>: Now a std::list.
118         (remote_notif_state_xfree): Don't declare.
119         * remote-notif.c (remote_notif_process, handle_notification)
120         (remote_notif_state_allocate): Update.
121         (~remote_notif_state): Rename from remote_notif_state_xfree.
122
123 2019-04-19  Tom Tromey  <tom@tromey.com>
124
125         * symfile.c (reread_symbols): Update.
126         * objfiles.c (objfile_register_static_link)
127         (objfile_lookup_static_link): Update
128         (~objfile) Don't delete static_links.
129         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
130
131 2019-04-19  Tom Tromey  <tom@tromey.com>
132
133         * type-stack.h (struct type_stack) <insert>: Constify string.
134         * type-stack.c (type_stack::insert): Constify string.
135         * gdbtypes.h (lookup_template_type): Update.
136         (address_space_name_to_int): Update.
137         * gdbtypes.c (address_space_name_to_int): Make space_identifier
138         const.
139         (lookup_template_type): Make name const.
140         * c-exp.y: Update rules.
141         (lex_one_token, classify_name, classify_inner_name)
142         (c_print_token): Update.
143         * p-exp.y: Update rules.
144         (yylex): Update.
145         * f-exp.y: Update rules.
146         (yylex): Update.
147         * d-exp.y: Update rules.
148         (lex_one_token, classify_name, classify_inner_name): Update.
149         * parse.c (write_dollar_variable, copy_name): Return std::string.
150         * parser-defs.h (copy_name): Change return type.
151         * m2-exp.y: Update rules.
152         (yylex): Update.
153         * go-exp.y (lex_one_token): Update.
154         Update rules.
155         (classify_unsafe_function, classify_packaged_name)
156         (classify_name, yylex): Update.
157
158 2019-04-19  Sergei Trofimovich <siarheit@google.com>
159
160         * configure.ac: add --enable-source-highlight switch.
161         * configure: Regenerate.
162         * top.c (print_gdb_version): plumb --enable-source-highlight
163         status to "show configuration".
164
165 2019-04-19  Tom Tromey  <tromey@adacore.com>
166
167         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
168         Check ADA_TYPE_P.
169         (empty_record, ada_template_to_fixed_record_type_1)
170         (template_to_static_fixed_type)
171         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
172         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
173         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
174         macros.
175
176 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
177
178         PR symtab/24423:
179         * source.c (print_source_lines_base): Advance "iter" when a
180         control character is seen.
181
182 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
183
184         * inferior.h (struct infcall_suspend_state_deleter):
185         Catch exception in destructor to avoid crash.
186
187 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
188
189         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
190         close to the add_com "shell".
191
192 2019-04-18  Tom Tromey  <tromey@adacore.com>
193
194         * process-stratum-target.h (class process_stratum_target)
195         <stratum>: Add "final".
196
197 2019-04-17  Tom Tromey  <tromey@adacore.com>
198
199         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
200         against nullptr before use.
201
202 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
203
204         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
205
206 2019-04-17  Jim Wilson  <jimw@sifive.com>
207             Andrew Burgess  <andrew.burgess@embecosm.com>
208
209         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
210         code read might fail, assume 4-byte breakpoint in that case.
211
212 2019-04-15  Leszek Swirski  <leszeks@google.com>
213
214         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
215         rather than a hand-rolled POD check when checking for forced MEMORY
216         classification.
217
218 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
219
220         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
221         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
222         function.
223         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
224         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
225         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
226         declaration.
227
228 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
229
230         * aarch64-linux-nat.c
231         (aarch64_linux_nat_target::thread_architecture): Add override.
232         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
233         each VQ.
234
235 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
236
237         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
238
239 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
240
241         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
242         target types of size 96-bits, add some additional comments, and
243         check that the builtin type we found was the correct size.
244
245 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
246
247         * utils.c (prompt_for_continue): Don't restore the styling at the
248         end, as applied_style has the wrong value.  This fixes styling in
249         long lists of file names that are interrupted by the "Continue?"
250         prompt.
251
252 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
253
254         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
255         * c-lang.c (c_language_defn): Likewise.
256         (cplus_language_defn): Likewise.
257         (asm_language_defn): Likewise.
258         (minimal_language_defn): Likewise.
259         * d-lang.c (d_language_defn): Likewise.
260         * f-lang.c (f_language_defn): Likewise.
261         * go-lang.c (go_language_defn): Likewise.
262         * language.c (unknown_language_defn): Likewise.
263         (auto_language_defn): Likewise.
264         * language.h (struct language_defn): Remove la_magic field.
265         (LANG_MAGIC): Delete.
266         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
267         * objc-lang.c (objc_language_defn): Likewise.
268         * opencl-lang.c (opencl_language_defn): Likewise.
269         * p-lang.c (pascal_language_defn): Likewise.
270         * rust-lang.c (rust_language_defn): Likewise.
271
272 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
273
274         * riscv-tdep.c (riscv_type_align): New function.
275         (riscv_type_alignment): Delete.
276         (riscv_arg_location): Use 'type_align'.
277         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
278
279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
280
281         * gdbtypes.c (type_align): A struct with no non-static fields also
282         has alignment of 1.
283
284 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
285
286         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
287         component to 0.
288         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
289         member.
290         (riscv_struct_info::analyse): New implementation using new
291         analyse_inner member function.
292         (riscv_struct_info::field_offset): New member function.
293         (riscv_struct_info::m_offsets): New member variable.
294         (riscv_struct_info::analyse_inner): New private member function,
295         takes the old implementation of riscv_struct_info::analyse but
296         extended to track field offsets.
297         (riscv_call_arg_struct): Update the struct folding special cases
298         to handle cases where empty C++ structs, which are non-zero
299         length, are found.
300         (riscv_arg_location): Initialise the length of each location, a
301         non-zero length now indicates the location is in use.
302         (riscv_push_dummy_call): Allow for the first location having a
303         non-zero offset when setting up arguments.
304         (riscv_return_value): Likewise, but for return values.
305
306 2019-04-11  Tom Tromey  <tromey@adacore.com>
307
308         * utils.c (internal_vproblem): Make "msg" const.
309
310 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
311
312         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
313         * trad-frame.c (trad_frame_reset_saved_regs): New function.
314         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
315         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
316
317 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
318
319         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
320         function.
321         (fill_gregset): Call amd64_linux_collect_native_gregset instead
322         of amd64_collect_native_gregset.
323         (amd64_linux_nat_target::store_registers): Likewise.
324
325 2019-04-10  Tom Tromey  <tom@tromey.com>
326
327         * symtab.c (lookup_global_symbol_from_objfile)
328         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
329         * objfiles.h (class separate_debug_iterator): New.
330         (class separate_debug_range): New.
331         (struct objfile) <separate_debug_objfiles>: New method.
332         (objfile_separate_debug_iterate): Don't declare.
333         * objfiles.c (separate_debug_iterator::operator++): Rename from
334         objfile_separate_debug_iterate.
335         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
336         iterator.
337         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
338         iterator.
339
340 2019-04-10  Tom Tromey  <tom@tromey.com>
341
342         * symfile.c (reread_symbols): Remove old comment.
343         * objfiles.c (free_all_objfiles): Fix a typo.
344
345 2019-04-10  Tom Tromey  <tom@tromey.com>
346
347         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
348         * minsyms.c (lookup_minimal_symbol): Use foreach.
349         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
350         (lookup_minimal_symbol_solib_trampoline): Likewise.
351         * symfile.c (reread_symbols): Use foreach.
352
353 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
354             Tom Tromey  <tromey@adacore.com>
355
356         PR rust/24414:
357         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
358         (rust_lex_int_test): Change "value" to be LONGEST.
359         (rust_lex_tests): Add test for long integer literal.
360
361 2019-04-09  Tom Tromey  <tromey@adacore.com>
362
363         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
364         to bool.
365         (extended_remote_target::attach): Update.
366         (remote_target::remote_notice_new_inferior): Update.
367         (remote_target::add_current_inferior_and_thread): Update.
368         * inferior.c (exit_inferior_1): Use "false".
369         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
370
371 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
372
373         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
374         the "start" command.
375
376 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
377
378         * python/py-inferior.c (infpy_thread_from_thread_handle):
379         Adjust comments to reflect renaming of thread_from_thread_handle
380         to thread_from_handle.  Adjust keywords.  Fix type error message.
381         (inferior_object_methods): Add thread_from_handle.  Retain
382         thread_from_thread_handle, but mark it as deprecated.
383
384 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
385
386         * gdbthread.h (find_thread_by_handle): Revise declaration.
387         * thread.c (find_thread_by_handle): Likewise.  Adjust
388         implementation too.
389         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
390         support for buffer objects as handles.
391
392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
393
394         * python/py-infthread.c (thpy_thread_handle): New function.
395         (thread_object_methods): Register thpy_thread_handle.
396
397 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
398
399         * gdbthread.h (thread_to_thread_handle): Declare.
400         * thread.c (gdbtypes.h): Include.
401         (thread_to_thread_handle): New function.
402
403         * target.h (struct target_ops): Add thread_info_to_thread_handle.
404         (target_thread_info_to_thread_handle): Declare.
405         * target.c (target_thread_info_to_thread_handle): New function.
406         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
407         * target-delegates.c: Regenerate.
408
409         * linux-thread-db.c (class thread_db_target): Add method
410         thread_info_to_thread_handle.
411         (thread_db_target::thread_info_to_thread_handle): Define.
412         * remote.c (class remote_target): Add new method
413         thread_info_to_thread_handle.
414         (remote_target::thread_info_to_thread_handle): Define.
415
416 2019-04-08  Pedro Alves  <palves@redhat.com>
417
418         * common/common-exceptions.c (throw_exception): Don't create
419         named object to throw; throw directly.
420         (throw_it): Likewise.  Don't initialize gdb_exception::message
421         here, with new; pass FMT and AP to the ctor instead.
422         * common/common-exceptions.h: Include <string>.
423         (gdb_exception::gdb_exception(enum return_reason, enum errors,
424         const char *, va_list)): New ctor.  Use std::make_shared.
425         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
426         errors)): Delete.
427         (gdb_exception_error::gdb_exception_error(enum errors, const char
428         *, va_list)): New.
429         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
430         Add assertion.
431         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
432         errors)): Delete.
433         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
434         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
435         Add assertion.
436
437 2019-04-08  Tom Tromey  <tom@tromey.com>
438
439         * valops.c (value_rtti_indirect_type): Replace throw_exception
440         with throw.
441         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
442         with throw.
443         * thread.c (thr_try_catch_cmd): Replace throw_exception with
444         throw.
445         * target.c (target_translate_tls_address): Replace throw_exception
446         with throw.
447         * stack.c (frame_apply_command_count): Replace throw_exception
448         with throw.
449         * solib-spu.c (append_ocl_sos): Replace throw_exception with
450         throw.
451         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
452         with throw.
453         * rs6000-tdep.c (rs6000_frame_cache)
454         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
455         * remote.c: Replace throw_exception with throw.
456         * record-full.c (record_full_message, record_full_wait_1)
457         (record_full_restore): Replace throw_exception with throw.
458         * record-btrace.c:
459         (get_thread_current_frame_id, record_btrace_start_replaying)
460         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
461         (cmd_record_btrace_start): Replace throw_exception with throw.
462         * parse.c (parse_exp_in_context_1): Replace throw_exception with
463         throw.
464         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
465         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
466         * linespec.c:
467         (find_linespec_symbols): Replace throw_exception with throw.
468         * infrun.c (displaced_step_prepare, resume): Replace
469         throw_exception with throw.
470         * infcmd.c (post_create_inferior): Replace throw_exception with
471         throw.
472         * inf-loop.c (inferior_event_handler): Replace throw_exception
473         with throw.
474         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
475         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
476         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
477         (get_prev_frame_always, get_frame_pc_if_available)
478         (get_frame_address_in_block_if_available, get_frame_language):
479         Replace throw_exception with throw.
480         * frame-unwind.c (frame_unwind_try_unwinder): Replace
481         throw_exception with throw.
482         * eval.c (fetch_subexp_value, evaluate_var_value)
483         (evaluate_funcall, evaluate_subexp_standard): Replace
484         throw_exception with throw.
485         * dwarf2loc.c (call_site_find_chain)
486         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
487         Replace throw_exception with throw.
488         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
489         with throw.
490         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
491         throw.
492         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
493         * completer.c (complete_line_internal): Replace throw_exception
494         with throw.
495         * compile/compile-object-run.c (compile_object_run): Replace
496         throw_exception with throw.
497         * cli/cli-script.c (process_next_line): Replace throw_exception
498         with throw.
499         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
500         (btrace_enable, btrace_maint_update_pt_packets): Replace
501         throw_exception with throw.
502         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
503         throw_exception with throw.
504         * break-catch-throw.c (re_set_exception_catchpoint): Replace
505         throw_exception with throw.
506         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
507         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
508         * aarch64-tdep.c (aarch64_make_prologue_cache)
509         (aarch64_make_stub_cache): Replace throw_exception with throw.
510
511 2019-04-08  Tom Tromey  <tom@tromey.com>
512
513         * common/common-exceptions.c (throw_exception): Rename from
514         throw_exception_cxx.  Remove old copy.  Make argument const.
515         (throw_it): Create and throw exception objects directly.
516         * common/common-exceptions.h (throw_exception): Make argument
517         const.
518         (struct gdb_exception_error): Add constructor.
519         (struct gdb_exception_quit): Add constructor.
520
521 2019-04-08  Tom Tromey  <tom@tromey.com>
522
523         * common/common-exceptions.h (exception_rethrow): Don't declare.
524         (TRY_SJLJ): Update comment.
525         (TRY, CATCH, END_CATCH): Remove.
526         * common/common-exceptions.c (exception_rethrow): Remove.
527
528 2019-04-08  Tom Tromey  <tom@tromey.com>
529
530         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
531         Remove.
532         (gdb_exception_error): Rename from
533         gdb_exception_RETURN_MASK_ERROR.
534         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
535         (gdb_quit_bad_alloc): Update.
536         * aarch64-tdep.c: Update.
537         * ada-lang.c: Update.
538         * ada-typeprint.c: Update.
539         * ada-valprint.c: Update.
540         * amd64-tdep.c: Update.
541         * arch-utils.c: Update.
542         * break-catch-throw.c: Update.
543         * breakpoint.c: Update.
544         * btrace.c: Update.
545         * c-varobj.c: Update.
546         * cli/cli-cmds.c: Update.
547         * cli/cli-interp.c: Update.
548         * cli/cli-script.c: Update.
549         * common/common-exceptions.c: Update.
550         * common/new-op.c: Update.
551         * common/selftest.c: Update.
552         * compile/compile-c-symbols.c: Update.
553         * compile/compile-cplus-symbols.c: Update.
554         * compile/compile-object-load.c: Update.
555         * compile/compile-object-run.c: Update.
556         * completer.c: Update.
557         * corelow.c: Update.
558         * cp-abi.c: Update.
559         * cp-support.c: Update.
560         * cp-valprint.c: Update.
561         * darwin-nat.c: Update.
562         * disasm-selftests.c: Update.
563         * dtrace-probe.c: Update.
564         * dwarf-index-cache.c: Update.
565         * dwarf-index-write.c: Update.
566         * dwarf2-frame-tailcall.c: Update.
567         * dwarf2-frame.c: Update.
568         * dwarf2loc.c: Update.
569         * dwarf2read.c: Update.
570         * eval.c: Update.
571         * event-loop.c: Update.
572         * event-top.c: Update.
573         * exec.c: Update.
574         * f-valprint.c: Update.
575         * fbsd-tdep.c: Update.
576         * frame-unwind.c: Update.
577         * frame.c: Update.
578         * gdbtypes.c: Update.
579         * gnu-v3-abi.c: Update.
580         * guile/guile-internal.h: Update.
581         * guile/scm-block.c: Update.
582         * guile/scm-breakpoint.c: Update.
583         * guile/scm-cmd.c: Update.
584         * guile/scm-disasm.c: Update.
585         * guile/scm-frame.c: Update.
586         * guile/scm-lazy-string.c: Update.
587         * guile/scm-math.c: Update.
588         * guile/scm-param.c: Update.
589         * guile/scm-ports.c: Update.
590         * guile/scm-pretty-print.c: Update.
591         * guile/scm-symbol.c: Update.
592         * guile/scm-symtab.c: Update.
593         * guile/scm-type.c: Update.
594         * guile/scm-value.c: Update.
595         * i386-linux-tdep.c: Update.
596         * i386-tdep.c: Update.
597         * inf-loop.c: Update.
598         * infcall.c: Update.
599         * infcmd.c: Update.
600         * infrun.c: Update.
601         * jit.c: Update.
602         * language.c: Update.
603         * linespec.c: Update.
604         * linux-fork.c: Update.
605         * linux-nat.c: Update.
606         * linux-tdep.c: Update.
607         * linux-thread-db.c: Update.
608         * main.c: Update.
609         * mi/mi-cmd-break.c: Update.
610         * mi/mi-cmd-stack.c: Update.
611         * mi/mi-interp.c: Update.
612         * mi/mi-main.c: Update.
613         * objc-lang.c: Update.
614         * p-valprint.c: Update.
615         * parse.c: Update.
616         * ppc-linux-tdep.c: Update.
617         * printcmd.c: Update.
618         * python/py-arch.c: Update.
619         * python/py-breakpoint.c: Update.
620         * python/py-cmd.c: Update.
621         * python/py-finishbreakpoint.c: Update.
622         * python/py-frame.c: Update.
623         * python/py-framefilter.c: Update.
624         * python/py-gdb-readline.c: Update.
625         * python/py-inferior.c: Update.
626         * python/py-infthread.c: Update.
627         * python/py-lazy-string.c: Update.
628         * python/py-linetable.c: Update.
629         * python/py-objfile.c: Update.
630         * python/py-param.c: Update.
631         * python/py-prettyprint.c: Update.
632         * python/py-progspace.c: Update.
633         * python/py-record-btrace.c: Update.
634         * python/py-record.c: Update.
635         * python/py-symbol.c: Update.
636         * python/py-type.c: Update.
637         * python/py-unwind.c: Update.
638         * python/py-utils.c: Update.
639         * python/py-value.c: Update.
640         * python/python.c: Update.
641         * record-btrace.c: Update.
642         * record-full.c: Update.
643         * remote-fileio.c: Update.
644         * remote.c: Update.
645         * riscv-tdep.c: Update.
646         * rs6000-aix-tdep.c: Update.
647         * rs6000-tdep.c: Update.
648         * rust-exp.y: Update.
649         * rust-lang.c: Update.
650         * s390-tdep.c: Update.
651         * selftest-arch.c: Update.
652         * solib-dsbt.c: Update.
653         * solib-frv.c: Update.
654         * solib-spu.c: Update.
655         * solib-svr4.c: Update.
656         * solib.c: Update.
657         * sparc64-linux-tdep.c: Update.
658         * stack.c: Update.
659         * symfile-mem.c: Update.
660         * symmisc.c: Update.
661         * target.c: Update.
662         * thread.c: Update.
663         * top.c: Update.
664         * tracefile-tfile.c: Update.
665         * tui/tui.c: Update.
666         * typeprint.c: Update.
667         * unittests/cli-utils-selftests.c: Update.
668         * unittests/parse-connection-spec-selftests.c: Update.
669         * valops.c: Update.
670         * valprint.c: Update.
671         * value.c: Update.
672         * varobj.c: Update.
673         * windows-nat.c: Update.
674         * x86-linux-nat.c: Update.
675         * xml-support.c: Update.
676
677 2019-04-08  Tom Tromey  <tom@tromey.com>
678
679         * xml-support.c: Use C++ exception handling.
680         * x86-linux-nat.c: Use C++ exception handling.
681         * windows-nat.c: Use C++ exception handling.
682         * varobj.c: Use C++ exception handling.
683         * value.c: Use C++ exception handling.
684         * valprint.c: Use C++ exception handling.
685         * valops.c: Use C++ exception handling.
686         * unittests/parse-connection-spec-selftests.c: Use C++ exception
687         handling.
688         * unittests/cli-utils-selftests.c: Use C++ exception handling.
689         * typeprint.c: Use C++ exception handling.
690         * tui/tui.c: Use C++ exception handling.
691         * tracefile-tfile.c: Use C++ exception handling.
692         * top.c: Use C++ exception handling.
693         * thread.c: Use C++ exception handling.
694         * target.c: Use C++ exception handling.
695         * symmisc.c: Use C++ exception handling.
696         * symfile-mem.c: Use C++ exception handling.
697         * stack.c: Use C++ exception handling.
698         * sparc64-linux-tdep.c: Use C++ exception handling.
699         * solib.c: Use C++ exception handling.
700         * solib-svr4.c: Use C++ exception handling.
701         * solib-spu.c: Use C++ exception handling.
702         * solib-frv.c: Use C++ exception handling.
703         * solib-dsbt.c: Use C++ exception handling.
704         * selftest-arch.c: Use C++ exception handling.
705         * s390-tdep.c: Use C++ exception handling.
706         * rust-lang.c: Use C++ exception handling.
707         * rust-exp.y: Use C++ exception handling.
708         * rs6000-tdep.c: Use C++ exception handling.
709         * rs6000-aix-tdep.c: Use C++ exception handling.
710         * riscv-tdep.c: Use C++ exception handling.
711         * remote.c: Use C++ exception handling.
712         * remote-fileio.c: Use C++ exception handling.
713         * record-full.c: Use C++ exception handling.
714         * record-btrace.c: Use C++ exception handling.
715         * python/python.c: Use C++ exception handling.
716         * python/py-value.c: Use C++ exception handling.
717         * python/py-utils.c: Use C++ exception handling.
718         * python/py-unwind.c: Use C++ exception handling.
719         * python/py-type.c: Use C++ exception handling.
720         * python/py-symbol.c: Use C++ exception handling.
721         * python/py-record.c: Use C++ exception handling.
722         * python/py-record-btrace.c: Use C++ exception handling.
723         * python/py-progspace.c: Use C++ exception handling.
724         * python/py-prettyprint.c: Use C++ exception handling.
725         * python/py-param.c: Use C++ exception handling.
726         * python/py-objfile.c: Use C++ exception handling.
727         * python/py-linetable.c: Use C++ exception handling.
728         * python/py-lazy-string.c: Use C++ exception handling.
729         * python/py-infthread.c: Use C++ exception handling.
730         * python/py-inferior.c: Use C++ exception handling.
731         * python/py-gdb-readline.c: Use C++ exception handling.
732         * python/py-framefilter.c: Use C++ exception handling.
733         * python/py-frame.c: Use C++ exception handling.
734         * python/py-finishbreakpoint.c: Use C++ exception handling.
735         * python/py-cmd.c: Use C++ exception handling.
736         * python/py-breakpoint.c: Use C++ exception handling.
737         * python/py-arch.c: Use C++ exception handling.
738         * printcmd.c: Use C++ exception handling.
739         * ppc-linux-tdep.c: Use C++ exception handling.
740         * parse.c: Use C++ exception handling.
741         * p-valprint.c: Use C++ exception handling.
742         * objc-lang.c: Use C++ exception handling.
743         * mi/mi-main.c: Use C++ exception handling.
744         * mi/mi-interp.c: Use C++ exception handling.
745         * mi/mi-cmd-stack.c: Use C++ exception handling.
746         * mi/mi-cmd-break.c: Use C++ exception handling.
747         * main.c: Use C++ exception handling.
748         * linux-thread-db.c: Use C++ exception handling.
749         * linux-tdep.c: Use C++ exception handling.
750         * linux-nat.c: Use C++ exception handling.
751         * linux-fork.c: Use C++ exception handling.
752         * linespec.c: Use C++ exception handling.
753         * language.c: Use C++ exception handling.
754         * jit.c: Use C++ exception handling.
755         * infrun.c: Use C++ exception handling.
756         * infcmd.c: Use C++ exception handling.
757         * infcall.c: Use C++ exception handling.
758         * inf-loop.c: Use C++ exception handling.
759         * i386-tdep.c: Use C++ exception handling.
760         * i386-linux-tdep.c: Use C++ exception handling.
761         * guile/scm-value.c: Use C++ exception handling.
762         * guile/scm-type.c: Use C++ exception handling.
763         * guile/scm-symtab.c: Use C++ exception handling.
764         * guile/scm-symbol.c: Use C++ exception handling.
765         * guile/scm-pretty-print.c: Use C++ exception handling.
766         * guile/scm-ports.c: Use C++ exception handling.
767         * guile/scm-param.c: Use C++ exception handling.
768         * guile/scm-math.c: Use C++ exception handling.
769         * guile/scm-lazy-string.c: Use C++ exception handling.
770         * guile/scm-frame.c: Use C++ exception handling.
771         * guile/scm-disasm.c: Use C++ exception handling.
772         * guile/scm-cmd.c: Use C++ exception handling.
773         * guile/scm-breakpoint.c: Use C++ exception handling.
774         * guile/scm-block.c: Use C++ exception handling.
775         * guile/guile-internal.h: Use C++ exception handling.
776         * gnu-v3-abi.c: Use C++ exception handling.
777         * gdbtypes.c: Use C++ exception handling.
778         * frame.c: Use C++ exception handling.
779         * frame-unwind.c: Use C++ exception handling.
780         * fbsd-tdep.c: Use C++ exception handling.
781         * f-valprint.c: Use C++ exception handling.
782         * exec.c: Use C++ exception handling.
783         * event-top.c: Use C++ exception handling.
784         * event-loop.c: Use C++ exception handling.
785         * eval.c: Use C++ exception handling.
786         * dwarf2read.c: Use C++ exception handling.
787         * dwarf2loc.c: Use C++ exception handling.
788         * dwarf2-frame.c: Use C++ exception handling.
789         * dwarf2-frame-tailcall.c: Use C++ exception handling.
790         * dwarf-index-write.c: Use C++ exception handling.
791         * dwarf-index-cache.c: Use C++ exception handling.
792         * dtrace-probe.c: Use C++ exception handling.
793         * disasm-selftests.c: Use C++ exception handling.
794         * darwin-nat.c: Use C++ exception handling.
795         * cp-valprint.c: Use C++ exception handling.
796         * cp-support.c: Use C++ exception handling.
797         * cp-abi.c: Use C++ exception handling.
798         * corelow.c: Use C++ exception handling.
799         * completer.c: Use C++ exception handling.
800         * compile/compile-object-run.c: Use C++ exception handling.
801         * compile/compile-object-load.c: Use C++ exception handling.
802         * compile/compile-cplus-symbols.c: Use C++ exception handling.
803         * compile/compile-c-symbols.c: Use C++ exception handling.
804         * common/selftest.c: Use C++ exception handling.
805         * common/new-op.c: Use C++ exception handling.
806         * cli/cli-script.c: Use C++ exception handling.
807         * cli/cli-interp.c: Use C++ exception handling.
808         * cli/cli-cmds.c: Use C++ exception handling.
809         * c-varobj.c: Use C++ exception handling.
810         * btrace.c: Use C++ exception handling.
811         * breakpoint.c: Use C++ exception handling.
812         * break-catch-throw.c: Use C++ exception handling.
813         * arch-utils.c: Use C++ exception handling.
814         * amd64-tdep.c: Use C++ exception handling.
815         * ada-valprint.c: Use C++ exception handling.
816         * ada-typeprint.c: Use C++ exception handling.
817         * ada-lang.c: Use C++ exception handling.
818         * aarch64-tdep.c: Use C++ exception handling.
819
820 2019-04-08  Tom Tromey  <tom@tromey.com>
821
822         * xml-support.c (gdb_xml_parser::parse): Update.
823         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
824         * value.c (show_convenience): Update.
825         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
826         (test_parse_flags_qcs): Update.
827         * thread.c (thr_try_catch_cmd): Update.
828         * target.c (target_translate_tls_address): Update.
829         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
830         (info_frame_command_core, frame_apply_command_count): Update.
831         * rust-exp.y (rust_lex_exception_test): Update.
832         * riscv-tdep.c (riscv_print_one_register_info): Update.
833         * remote.c (remote_target::enable_btrace): Update.
834         * record-btrace.c (record_btrace_enable_warn): Update.
835         * python/py-utils.c (gdbpy_convert_exception): Update.
836         * printcmd.c (do_one_display, print_variable_and_value): Update.
837         * mi/mi-main.c (mi_print_exception): Update.
838         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
839         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
840         * linux-nat.c (linux_nat_target::attach): Update.
841         * linux-fork.c (class scoped_switch_fork_info): Update.
842         * infrun.c (displaced_step_prepare): Update.
843         * infcall.c (call_function_by_hand_dummy): Update.
844         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
845         * gnu-v3-abi.c (print_one_vtable): Update.
846         * frame.c (get_prev_frame_always): Update.
847         * f-valprint.c (info_common_command_for_block): Update.
848         * exec.c (try_open_exec_file): Update.
849         * exceptions.c (print_exception, exception_print)
850         (exception_fprintf, exception_print_same): Update.
851         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
852         * dwarf-index-cache.c (index_cache::store)
853         (index_cache::lookup_gdb_index): Update.
854         * darwin-nat.c (maybe_cache_shell): Update.
855         * cp-valprint.c (cp_print_value_fields): Update.
856         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
857         (gcc_cplus_symbol_address): Update.
858         * compile/compile-c-symbols.c (gcc_convert_symbol)
859         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
860         * common/selftest.c: Update.
861         * common/common-exceptions.h (struct gdb_exception) <message>: Now
862         a std::string.
863         (exception_try_scope_entry, exception_try_scope_exit): Don't
864         declare.
865         (struct exception_try_scope): Remove.
866         (TRY): Don't use exception_try_scope.
867         (struct gdb_exception): Add constructor, operator=.
868         <what>: New method.
869         (struct gdb_exception_RETURN_MASK_ALL)
870         (struct gdb_exception_RETURN_MASK_ERROR)
871         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
872         (struct gdb_quit_bad_alloc): Update.
873         * common/common-exceptions.c (exception_none): Change
874         initializer.
875         (struct catcher) <state, exception>: Initialize inline.
876         <prev>: Remove member.
877         (current_catcher): Remove.
878         (catchers): New global.
879         (exceptions_state_mc_init): Simplify.
880         (catcher_pop): Remove.
881         (exceptions_state_mc, exceptions_state_mc_catch): Update.
882         (try_scope_depth, exception_try_scope_entry)
883         (exception_try_scope_exit): Remove.
884         (throw_exception_sjlj): Update.
885         (exception_messages, exception_messages_size): Remove.
886         (throw_it): Simplify.
887         (gdb_exception_sliced_copy): Remove.
888         (throw_exception_cxx): Update.
889         * cli/cli-script.c (script_from_file): Update.
890         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
891         Update.
892         * ada-valprint.c (ada_val_print): Update.
893         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
894         (create_excep_cond_exprs): Update.
895
896 2019-04-08  Tom Tromey  <tom@tromey.com>
897
898         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
899         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
900         (TRY, CATCH, END_CATCH): Remove some definitions.
901         * common/common-exceptions.c: Don't use GDB_XCPT.
902         (catcher_list_size): Remove.
903         (throw_exception, throw_it): Simplify.
904
905 2019-04-05  Tom Tromey  <tom@tromey.com>
906
907         Revert the header-sorting patch.
908         * ft32-tdep.c: Revert.
909         * frv-tdep.c: Revert.
910         * frv-linux-tdep.c: Revert.
911         * frame.c: Revert.
912         * frame-unwind.c: Revert.
913         * frame-base.c: Revert.
914         * fork-child.c: Revert.
915         * findvar.c: Revert.
916         * findcmd.c: Revert.
917         * filesystem.c: Revert.
918         * filename-seen-cache.h: Revert.
919         * filename-seen-cache.c: Revert.
920         * fbsd-tdep.c: Revert.
921         * fbsd-nat.h: Revert.
922         * fbsd-nat.c: Revert.
923         * f-valprint.c: Revert.
924         * f-typeprint.c: Revert.
925         * f-lang.c: Revert.
926         * extension.h: Revert.
927         * extension.c: Revert.
928         * extension-priv.h: Revert.
929         * expprint.c: Revert.
930         * exec.h: Revert.
931         * exec.c: Revert.
932         * exceptions.c: Revert.
933         * event-top.c: Revert.
934         * event-loop.c: Revert.
935         * eval.c: Revert.
936         * elfread.c: Revert.
937         * dwarf2read.h: Revert.
938         * dwarf2read.c: Revert.
939         * dwarf2loc.c: Revert.
940         * dwarf2expr.h: Revert.
941         * dwarf2expr.c: Revert.
942         * dwarf2-frame.c: Revert.
943         * dwarf2-frame-tailcall.c: Revert.
944         * dwarf-index-write.h: Revert.
945         * dwarf-index-write.c: Revert.
946         * dwarf-index-common.c: Revert.
947         * dwarf-index-cache.h: Revert.
948         * dwarf-index-cache.c: Revert.
949         * dummy-frame.c: Revert.
950         * dtrace-probe.c: Revert.
951         * disasm.h: Revert.
952         * disasm.c: Revert.
953         * disasm-selftests.c: Revert.
954         * dictionary.c: Revert.
955         * dicos-tdep.c: Revert.
956         * demangle.c: Revert.
957         * dcache.h: Revert.
958         * dcache.c: Revert.
959         * darwin-nat.h: Revert.
960         * darwin-nat.c: Revert.
961         * darwin-nat-info.c: Revert.
962         * d-valprint.c: Revert.
963         * d-namespace.c: Revert.
964         * d-lang.c: Revert.
965         * ctf.c: Revert.
966         * csky-tdep.c: Revert.
967         * csky-linux-tdep.c: Revert.
968         * cris-tdep.c: Revert.
969         * cris-linux-tdep.c: Revert.
970         * cp-valprint.c: Revert.
971         * cp-support.c: Revert.
972         * cp-namespace.c: Revert.
973         * cp-abi.c: Revert.
974         * corelow.c: Revert.
975         * corefile.c: Revert.
976         * continuations.c: Revert.
977         * completer.h: Revert.
978         * completer.c: Revert.
979         * complaints.c: Revert.
980         * coffread.c: Revert.
981         * coff-pe-read.c: Revert.
982         * cli-out.h: Revert.
983         * cli-out.c: Revert.
984         * charset.c: Revert.
985         * c-varobj.c: Revert.
986         * c-valprint.c: Revert.
987         * c-typeprint.c: Revert.
988         * c-lang.c: Revert.
989         * buildsym.c: Revert.
990         * buildsym-legacy.c: Revert.
991         * build-id.h: Revert.
992         * build-id.c: Revert.
993         * btrace.c: Revert.
994         * bsd-uthread.c: Revert.
995         * breakpoint.h: Revert.
996         * breakpoint.c: Revert.
997         * break-catch-throw.c: Revert.
998         * break-catch-syscall.c: Revert.
999         * break-catch-sig.c: Revert.
1000         * blockframe.c: Revert.
1001         * block.c: Revert.
1002         * bfin-tdep.c: Revert.
1003         * bfin-linux-tdep.c: Revert.
1004         * bfd-target.c: Revert.
1005         * bcache.c: Revert.
1006         * ax-general.c: Revert.
1007         * ax-gdb.h: Revert.
1008         * ax-gdb.c: Revert.
1009         * avr-tdep.c: Revert.
1010         * auxv.c: Revert.
1011         * auto-load.c: Revert.
1012         * arm-wince-tdep.c: Revert.
1013         * arm-tdep.c: Revert.
1014         * arm-symbian-tdep.c: Revert.
1015         * arm-pikeos-tdep.c: Revert.
1016         * arm-obsd-tdep.c: Revert.
1017         * arm-nbsd-tdep.c: Revert.
1018         * arm-nbsd-nat.c: Revert.
1019         * arm-linux-tdep.c: Revert.
1020         * arm-linux-nat.c: Revert.
1021         * arm-fbsd-tdep.c: Revert.
1022         * arm-fbsd-nat.c: Revert.
1023         * arm-bsd-tdep.c: Revert.
1024         * arch-utils.c: Revert.
1025         * arc-tdep.c: Revert.
1026         * arc-newlib-tdep.c: Revert.
1027         * annotate.h: Revert.
1028         * annotate.c: Revert.
1029         * amd64-windows-tdep.c: Revert.
1030         * amd64-windows-nat.c: Revert.
1031         * amd64-tdep.c: Revert.
1032         * amd64-sol2-tdep.c: Revert.
1033         * amd64-obsd-tdep.c: Revert.
1034         * amd64-obsd-nat.c: Revert.
1035         * amd64-nbsd-tdep.c: Revert.
1036         * amd64-nbsd-nat.c: Revert.
1037         * amd64-nat.c: Revert.
1038         * amd64-linux-tdep.c: Revert.
1039         * amd64-linux-nat.c: Revert.
1040         * amd64-fbsd-tdep.c: Revert.
1041         * amd64-fbsd-nat.c: Revert.
1042         * amd64-dicos-tdep.c: Revert.
1043         * amd64-darwin-tdep.c: Revert.
1044         * amd64-bsd-nat.c: Revert.
1045         * alpha-tdep.c: Revert.
1046         * alpha-obsd-tdep.c: Revert.
1047         * alpha-nbsd-tdep.c: Revert.
1048         * alpha-mdebug-tdep.c: Revert.
1049         * alpha-linux-tdep.c: Revert.
1050         * alpha-linux-nat.c: Revert.
1051         * alpha-bsd-tdep.c: Revert.
1052         * alpha-bsd-nat.c: Revert.
1053         * aix-thread.c: Revert.
1054         * agent.c: Revert.
1055         * addrmap.c: Revert.
1056         * ada-varobj.c: Revert.
1057         * ada-valprint.c: Revert.
1058         * ada-typeprint.c: Revert.
1059         * ada-tasks.c: Revert.
1060         * ada-lang.c: Revert.
1061         * aarch64-tdep.c: Revert.
1062         * aarch64-ravenscar-thread.c: Revert.
1063         * aarch64-newlib-tdep.c: Revert.
1064         * aarch64-linux-tdep.c: Revert.
1065         * aarch64-linux-nat.c: Revert.
1066         * aarch64-fbsd-tdep.c: Revert.
1067         * aarch64-fbsd-nat.c: Revert.
1068         * aarch32-linux-nat.c: Revert.
1069
1070 2019-04-05  Tom Tromey  <tom@tromey.com>
1071
1072         * ft32-tdep.c: Sort headers.
1073         * frv-tdep.c: Sort headers.
1074         * frv-linux-tdep.c: Sort headers.
1075         * frame.c: Sort headers.
1076         * frame-unwind.c: Sort headers.
1077         * frame-base.c: Sort headers.
1078         * fork-child.c: Sort headers.
1079         * findvar.c: Sort headers.
1080         * findcmd.c: Sort headers.
1081         * filesystem.c: Sort headers.
1082         * filename-seen-cache.h: Sort headers.
1083         * filename-seen-cache.c: Sort headers.
1084         * fbsd-tdep.c: Sort headers.
1085         * fbsd-nat.h: Sort headers.
1086         * fbsd-nat.c: Sort headers.
1087         * f-valprint.c: Sort headers.
1088         * f-typeprint.c: Sort headers.
1089         * f-lang.c: Sort headers.
1090         * extension.h: Sort headers.
1091         * extension.c: Sort headers.
1092         * extension-priv.h: Sort headers.
1093         * expprint.c: Sort headers.
1094         * exec.h: Sort headers.
1095         * exec.c: Sort headers.
1096         * exceptions.c: Sort headers.
1097         * event-top.c: Sort headers.
1098         * event-loop.c: Sort headers.
1099         * eval.c: Sort headers.
1100         * elfread.c: Sort headers.
1101         * dwarf2read.h: Sort headers.
1102         * dwarf2read.c: Sort headers.
1103         * dwarf2loc.c: Sort headers.
1104         * dwarf2expr.h: Sort headers.
1105         * dwarf2expr.c: Sort headers.
1106         * dwarf2-frame.c: Sort headers.
1107         * dwarf2-frame-tailcall.c: Sort headers.
1108         * dwarf-index-write.h: Sort headers.
1109         * dwarf-index-write.c: Sort headers.
1110         * dwarf-index-common.c: Sort headers.
1111         * dwarf-index-cache.h: Sort headers.
1112         * dwarf-index-cache.c: Sort headers.
1113         * dummy-frame.c: Sort headers.
1114         * dtrace-probe.c: Sort headers.
1115         * disasm.h: Sort headers.
1116         * disasm.c: Sort headers.
1117         * disasm-selftests.c: Sort headers.
1118         * dictionary.c: Sort headers.
1119         * dicos-tdep.c: Sort headers.
1120         * demangle.c: Sort headers.
1121         * dcache.h: Sort headers.
1122         * dcache.c: Sort headers.
1123         * darwin-nat.h: Sort headers.
1124         * darwin-nat.c: Sort headers.
1125         * darwin-nat-info.c: Sort headers.
1126         * d-valprint.c: Sort headers.
1127         * d-namespace.c: Sort headers.
1128         * d-lang.c: Sort headers.
1129         * ctf.c: Sort headers.
1130         * csky-tdep.c: Sort headers.
1131         * csky-linux-tdep.c: Sort headers.
1132         * cris-tdep.c: Sort headers.
1133         * cris-linux-tdep.c: Sort headers.
1134         * cp-valprint.c: Sort headers.
1135         * cp-support.c: Sort headers.
1136         * cp-namespace.c: Sort headers.
1137         * cp-abi.c: Sort headers.
1138         * corelow.c: Sort headers.
1139         * corefile.c: Sort headers.
1140         * continuations.c: Sort headers.
1141         * completer.h: Sort headers.
1142         * completer.c: Sort headers.
1143         * complaints.c: Sort headers.
1144         * coffread.c: Sort headers.
1145         * coff-pe-read.c: Sort headers.
1146         * cli-out.h: Sort headers.
1147         * cli-out.c: Sort headers.
1148         * charset.c: Sort headers.
1149         * c-varobj.c: Sort headers.
1150         * c-valprint.c: Sort headers.
1151         * c-typeprint.c: Sort headers.
1152         * c-lang.c: Sort headers.
1153         * buildsym.c: Sort headers.
1154         * buildsym-legacy.c: Sort headers.
1155         * build-id.h: Sort headers.
1156         * build-id.c: Sort headers.
1157         * btrace.c: Sort headers.
1158         * bsd-uthread.c: Sort headers.
1159         * breakpoint.h: Sort headers.
1160         * breakpoint.c: Sort headers.
1161         * break-catch-throw.c: Sort headers.
1162         * break-catch-syscall.c: Sort headers.
1163         * break-catch-sig.c: Sort headers.
1164         * blockframe.c: Sort headers.
1165         * block.c: Sort headers.
1166         * bfin-tdep.c: Sort headers.
1167         * bfin-linux-tdep.c: Sort headers.
1168         * bfd-target.c: Sort headers.
1169         * bcache.c: Sort headers.
1170         * ax-general.c: Sort headers.
1171         * ax-gdb.h: Sort headers.
1172         * ax-gdb.c: Sort headers.
1173         * avr-tdep.c: Sort headers.
1174         * auxv.c: Sort headers.
1175         * auto-load.c: Sort headers.
1176         * arm-wince-tdep.c: Sort headers.
1177         * arm-tdep.c: Sort headers.
1178         * arm-symbian-tdep.c: Sort headers.
1179         * arm-pikeos-tdep.c: Sort headers.
1180         * arm-obsd-tdep.c: Sort headers.
1181         * arm-nbsd-tdep.c: Sort headers.
1182         * arm-nbsd-nat.c: Sort headers.
1183         * arm-linux-tdep.c: Sort headers.
1184         * arm-linux-nat.c: Sort headers.
1185         * arm-fbsd-tdep.c: Sort headers.
1186         * arm-fbsd-nat.c: Sort headers.
1187         * arm-bsd-tdep.c: Sort headers.
1188         * arch-utils.c: Sort headers.
1189         * arc-tdep.c: Sort headers.
1190         * arc-newlib-tdep.c: Sort headers.
1191         * annotate.h: Sort headers.
1192         * annotate.c: Sort headers.
1193         * amd64-windows-tdep.c: Sort headers.
1194         * amd64-windows-nat.c: Sort headers.
1195         * amd64-tdep.c: Sort headers.
1196         * amd64-sol2-tdep.c: Sort headers.
1197         * amd64-obsd-tdep.c: Sort headers.
1198         * amd64-obsd-nat.c: Sort headers.
1199         * amd64-nbsd-tdep.c: Sort headers.
1200         * amd64-nbsd-nat.c: Sort headers.
1201         * amd64-nat.c: Sort headers.
1202         * amd64-linux-tdep.c: Sort headers.
1203         * amd64-linux-nat.c: Sort headers.
1204         * amd64-fbsd-tdep.c: Sort headers.
1205         * amd64-fbsd-nat.c: Sort headers.
1206         * amd64-dicos-tdep.c: Sort headers.
1207         * amd64-darwin-tdep.c: Sort headers.
1208         * amd64-bsd-nat.c: Sort headers.
1209         * alpha-tdep.c: Sort headers.
1210         * alpha-obsd-tdep.c: Sort headers.
1211         * alpha-nbsd-tdep.c: Sort headers.
1212         * alpha-mdebug-tdep.c: Sort headers.
1213         * alpha-linux-tdep.c: Sort headers.
1214         * alpha-linux-nat.c: Sort headers.
1215         * alpha-bsd-tdep.c: Sort headers.
1216         * alpha-bsd-nat.c: Sort headers.
1217         * aix-thread.c: Sort headers.
1218         * agent.c: Sort headers.
1219         * addrmap.c: Sort headers.
1220         * ada-varobj.c: Sort headers.
1221         * ada-valprint.c: Sort headers.
1222         * ada-typeprint.c: Sort headers.
1223         * ada-tasks.c: Sort headers.
1224         * ada-lang.c: Sort headers.
1225         * aarch64-tdep.c: Sort headers.
1226         * aarch64-ravenscar-thread.c: Sort headers.
1227         * aarch64-newlib-tdep.c: Sort headers.
1228         * aarch64-linux-tdep.c: Sort headers.
1229         * aarch64-linux-nat.c: Sort headers.
1230         * aarch64-fbsd-tdep.c: Sort headers.
1231         * aarch64-fbsd-nat.c: Sort headers.
1232         * aarch32-linux-nat.c: Sort headers.
1233
1234 2019-04-04  Tom Tromey  <tom@tromey.com>
1235
1236         * varobj.c (varobj_create): Update.
1237         * rust-exp.y (struct rust_parser) <update_innermost_block,
1238         lookup_symbol>: New methods.
1239         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1240         Rename.
1241         (rust_parser::rust_lookup_type)
1242         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1243         * printcmd.c (display_command, do_one_display): Update.
1244         * parser-defs.h (struct parser_state) <parser_state>: Add
1245         "tracker" parameter.
1246         (block_tracker): New member.
1247         (class innermost_block_tracker) <innermost_block_tracker>: Add
1248         "types" parameter.
1249         <reset>: Remove method.
1250         (innermost_block): Don't declare.
1251         (null_post_parser): Update.
1252         * parse.c (innermost_block): Remove global.
1253         (write_dollar_variable): Update.
1254         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1255         Remove "tracker_types" parameter.
1256         (parse_expression): Add "tracker" parameter.
1257         (parse_expression_for_completion): Update.
1258         (null_post_parser): Add "tracker" parameter.
1259         * p-exp.y: Update rules.
1260         * m2-exp.y: Update rules.
1261         * language.h (struct language_defn) <la_post_parser>: Add
1262         "tracker" parameter.
1263         * go-exp.y: Update rules.
1264         * f-exp.y: Update rules.
1265         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1266         parameter.
1267         * d-exp.y: Update rules.
1268         * c-exp.y: Update rules.
1269         * breakpoint.c (set_breakpoint_condition): Create an
1270         innermost_block_tracker.
1271         (watch_command_1): Likewise.
1272         * ada-lang.c (resolve): Add "tracker" parameter.
1273         (resolve_subexp): Likewise.
1274         * ada-exp.y (write_var_from_sym): Update.
1275
1276 2019-04-04  Tom Tromey  <tom@tromey.com>
1277
1278         * type-stack.h: New file.
1279         * type-stack.c: New file.
1280         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1281         type-stack.h.
1282         (insert_into_type_stack, insert_type, push_type, push_type_int)
1283         (insert_type_address_space, pop_type, pop_type_int)
1284         (pop_typelist, pop_type_stack, append_type_stack)
1285         (push_type_stack, get_type_stack, push_typelist)
1286         (follow_type_instance_flags, follow_types): Don't declare.
1287         * parse.c (type_stack): Remove global.
1288         (parse_exp_in_context): Update.
1289         (insert_into_type_stack, insert_type, push_type, push_type_int)
1290         (insert_type_address_space, pop_type, pop_type_int)
1291         (pop_typelist, pop_type_stack, append_type_stack)
1292         (push_type_stack, get_type_stack, push_typelist)
1293         (follow_type_instance_flags, follow_types): Remove (moved to
1294         type-stack.c).
1295         * f-exp.y (type_stack): New global.
1296         Update rules.
1297         (push_kind_type, f_parse): Update.
1298         * d-exp.y (type_stack): New global.
1299         Update rules.
1300         (d_parse): Update.
1301         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1302         Update rules.
1303         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1304         (HFILES_NO_SRCDIR): Add type-stack.h.
1305
1306 2019-04-04  Tom Tromey  <tom@tromey.com>
1307
1308         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1309         (rust_parser::convert_ast_to_expression, rust_parse)
1310         (rust_lex_test_completion, rust_lex_tests): Update.
1311         * parser-defs.h (struct expr_completion_state): New.
1312         (struct parser_state) <parser_state>: Add completion parameter.
1313         <mark_struct_expression, mark_completion_tag>: New methods.
1314         <parse_completion, m_completion_state>: New members.
1315         (prefixify_expression, null_post_parser): Update.
1316         (mark_struct_expression, mark_completion_tag): Don't declare.
1317         * parse.c (parse_completion, expout_last_struct)
1318         (expout_tag_completion_type, expout_completion_name): Remove
1319         globals.
1320         (parser_state::mark_struct_expression)
1321         (parser_state::mark_completion_tag): Now methods.
1322         (prefixify_expression): Add last_struct parameter.
1323         (prefixify_subexp): Likewise.
1324         (parse_exp_1): Update.
1325         (parse_exp_in_context): Add cstate parameter.  Update.
1326         (parse_expression_for_completion): Create an
1327         expr_completion_state.
1328         (null_post_parser): Add "completion" parameter.
1329         * p-exp.y: Update rules.
1330         (yylex): Update.
1331         * language.h (struct language_defn) <la_post_parser>: Add
1332         "completing" parameter.
1333         * go-exp.y: Update rules.
1334         (lex_one_token): Update.
1335         * expression.h (parse_completion): Don't declare.
1336         * d-exp.y: Update rules.
1337         (lex_one_token): Update rules.
1338         * c-exp.y: Update rules.
1339         (lex_one_token): Update.
1340         * ada-lang.c (resolve): Add "parse_completion" parameter.
1341         (resolve_subexp): Likewise.
1342         (ada_resolve_function): Likewise.
1343
1344 2019-04-04  Tom Tromey  <tom@tromey.com>
1345
1346         * parser-defs.h (struct parser_state) <start_arglist,
1347         end_arglist>: New methods.
1348         <arglist_len, m_funcall_chain>: New members.
1349         (arglist_len, start_arglist, end_arglist): Don't declare.
1350         * parse.c (arglist_len, funcall_chain): Remove global.
1351         (start_arglist, end_arglist): Remove functions.
1352         (parse_exp_in_context): Update.
1353         * p-exp.y: Update rules.
1354         * m2-exp.y: Update rules.
1355         * go-exp.y: Update rules.
1356         * f-exp.y: Update rules.
1357         * d-exp.y: Update rules.
1358         * c-exp.y: Update rules.
1359
1360 2019-04-04  Tom Tromey  <tom@tromey.com>
1361
1362         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1363         lex_operator, push_back>: New methods.
1364         Update all rules.
1365         (rust_parser::lex_hex, lex_escape): Rename and update.
1366         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1367         (rust_parser::lex_operator): Rename and update.
1368         (rust_parser::lex_number, rustyylex, rustyyerror)
1369         (rust_lex_test_init, rust_lex_test_sequence)
1370         (rust_lex_test_push_back, rust_lex_tests): Update.
1371         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1372         parameter.
1373         <lexptr, prev_lexptr>: New members.
1374         (lexptr, prev_lexptr): Don't declare.
1375         * parse.c (lexptr, prev_lexptr): Remove globals.
1376         (parse_exp_in_context): Update.
1377         * p-exp.y (yylex, yyerror): Update.
1378         * m2-exp.y (parse_number, yylex, yyerror): Update.
1379         * go-exp.y (lex_one_token, yyerror): Update.
1380         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1381         * d-exp.y (lex_one_token, yyerror): Update.
1382         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1383         (lex_one_token, yyerror): Update.
1384         * ada-lex.l (YY_INPUT): Update.
1385         (rewind_to_char): Update.
1386         * ada-exp.y (yyerror): Update.
1387
1388 2019-04-04  Tom Tromey  <tom@tromey.com>
1389
1390         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1391         * parser-defs.h (struct parser_state) <parser_state>: Add new
1392         parameter.
1393         <comma_terminates>: New member.
1394         (comma_terminates): Don't declare global.
1395         * parse.c (comma_terminates): Remove global.
1396         (parse_exp_in_context): Update.
1397         * p-exp.y (yylex): Update.
1398         * m2-exp.y (yylex): Update.
1399         * go-exp.y (lex_one_token): Update.
1400         * f-exp.y (yylex): Update.
1401         * d-exp.y (lex_one_token): Update.
1402         * c-exp.y (lex_one_token): Update.
1403         * ada-lex.l: Update.
1404
1405 2019-04-04  Tom Tromey  <tom@tromey.com>
1406
1407         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1408         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1409         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1410         * parser-defs.h (paren_depth): Don't declare.
1411         * parse.c (paren_depth): Remove global.
1412         (parse_exp_in_context): Update.
1413         * p-exp.y (paren_depth): New global.
1414         (pascal_parse): Initialize it.
1415         * m2-exp.y (paren_depth): New global.
1416         (m2_parse): Initialize it.
1417         * go-exp.y (paren_depth): New global.
1418         (go_parse): Initialize it.
1419         * f-exp.y (paren_depth): New global.
1420         (f_parse): Initialize it.
1421         * d-exp.y (paren_depth): New global.
1422         (d_parse): Initialize it.
1423         * c-exp.y (paren_depth): New global.
1424         (c_parse): Initialize it.
1425         * ada-lex.l (paren_depth): New global.
1426         (lexer_init): Initialize it.
1427
1428 2019-04-04  Tom Tromey  <tom@tromey.com>
1429
1430         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1431         (rust_parser::convert_ast_to_type)
1432         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1433         * parser-defs.h (struct parser_state) <parser_state>: Add
1434         parameters.  Initialize new members.
1435         <expression_context_block, expression_context_pc>: New members.
1436         * parse.c (expression_context_block, expression_context_pc):
1437         Remove globals.
1438         (parse_exp_in_context): Update.
1439         * p-exp.y: Update all rules.
1440         (yylex): Update.
1441         * m2-exp.y: Update all rules.
1442         (yylex): Update.
1443         * go-exp.y (yylex): Update.
1444         * f-exp.y (yylex): Update.
1445         * d-exp.y: Update all rules.
1446         (yylex): Update.
1447         * c-exp.y: Update all rules.
1448         (lex_one_token, classify_name, yylex, c_parse): Update.
1449         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1450
1451 2019-04-04  Tom Tromey  <tom@tromey.com>
1452
1453         * gdbarch.h, gdbarch.c: Rebuild.
1454         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1455         * stap-probe.h: 
1456         (struct stap_parse_info): Replace "parser_state" with
1457         "expr_builder".
1458         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1459         (parser_state): New class.
1460         * parse.c (expr_builder): Rename.
1461         (expr_builder::release): Rename.
1462         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1463         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1464         (write_exp_elt_longcst, write_exp_elt_floatcst)
1465         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1466         (write_exp_string_vector, write_exp_bitstring)
1467         (write_exp_msymbol, mark_struct_expression)
1468         (write_dollar_variable)
1469         (insert_type_address_space, increase_expout_size): Replace
1470         "parser_state" with "expr_builder".
1471         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1472         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1473         "parser_state" with "expr_builder".
1474
1475 2019-04-04  Tom Tromey  <tom@tromey.com>
1476
1477         * rust-exp.y: Replace "parse_language" with method call.
1478         * p-exp.y: 
1479         (yylex): Replace "parse_language" with method call.
1480         * m2-exp.y: 
1481         (yylex): Replace "parse_language" with method call.
1482         * go-exp.y (classify_name): Replace "parse_language" with method
1483         call.
1484         * f-exp.y (yylex): Replace "parse_language" with method call.
1485         * d-exp.y (lex_one_token): Replace "parse_language" with method
1486         call.
1487         * c-exp.y: 
1488         (lex_one_token, classify_name, yylex): Replace "parse_language"
1489         with method call.
1490         * ada-exp.y (find_primitive_type, type_char)
1491         (type_system_address): Replace "parse_language" with method call.
1492
1493 2019-04-04  Tom Tromey  <tom@tromey.com>
1494
1495         * rust-exp.y: Replace "parse_gdbarch" with method call.
1496         * parse.c (write_dollar_variable, insert_type_address_space):
1497         Replace "parse_gdbarch" with method call.
1498         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1499         call.
1500         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1501         call.
1502         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1503         "parse_gdbarch" with method call.
1504         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1505         with method call.
1506         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1507         "parse_gdbarch" with method call.
1508         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1509         "parse_gdbarch" with method call.
1510         * c-exp.y (parse_type, parse_number, classify_name): Replace
1511         "parse_gdbarch" with method call.
1512         * ada-lex.l: Replace "parse_gdbarch" with method call.
1513         * ada-exp.y (parse_type, find_primitive_type, type_char)
1514         (type_system_address): Replace "parse_gdbarch" with method call.
1515
1516 2019-04-04  Tom Tromey  <tom@tromey.com>
1517
1518         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1519         * stap-probe.c (stap_parse_argument): Update.
1520         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1521         initial_size parameter.
1522         * rust-exp.y (rust_lex_tests): Update.
1523         * parse.c (parser_state): Update.
1524         (parse_exp_in_context): Update.
1525         * parser-defs.h (struct parser_state) <parser_state>: Remove
1526         "initial_size" parameter.
1527
1528 2019-04-04  Tom Tromey  <tom@tromey.com>
1529
1530         * parser-defs.h (increase_expout_size): Don't declare.
1531         * parse.c (increase_expout_size): Now static.
1532
1533 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1534
1535         * gnu-nat.c (gnu_nat_target::wait): Fix
1536         target_waitstatus_to_string call.
1537
1538 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * eval.c (evaluate_subexp_standard): Handle internal functions
1541         during Fortran function call handling.
1542
1543 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1544
1545         * NEWS: Mention new internal functions.
1546         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1547         (read_base_type): Use dwarf2_init_complex_target_type.
1548         * value.c (creal_internal_fn): New function.
1549         (cimag_internal_fn): New function.
1550         (_initialize_values): Register new internal functions.
1551
1552 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1553
1554         * infrun.c (stop_all_threads): If debug_infrun, always
1555         trace the wait status after wait_one, using
1556         target_waitstatus_to_string and target_pid_to_str.
1557         (handle_inferior_event): Replace various trace of
1558         wait status kind by a single trace.
1559         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1560         wait status kind image by target_waitstatus_to_string.
1561         * target/waitstatus.c (target_waitstatus_to_string): Fix
1562         obsolete comment.
1563
1564 2019-04-01  Tom Tromey  <tromey@adacore.com>
1565
1566         PR symtab/23331:
1567         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1568
1569 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1570             Pedro Alves  <palves@redhat.com>
1571
1572         * top.c (quit_force): Call 'finalize_values'.
1573         * value.c (finalize_values): New function.
1574         * value.h (finalize_values): Declare.
1575
1576 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1577
1578         * NEWS: Announce $_gdb_major and $_gdb_minor.
1579
1580         * top.c (init_gdb_version_vars): New function.
1581         (gdb_init): Call init_gdb_version_vars.
1582
1583 2019-03-29  Tom Tromey  <tromey@adacore.com>
1584
1585         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1586         help text.  Remove dead code.
1587
1588 2019-03-29  Keith Seitz  <keiths@redhat.com>
1589
1590         From Siddhesh Poyarekar:
1591         * f-lang.h (f77_get_upperbound): Return LONGEST.
1592         (f77_get_lowerbound): Likewise.
1593         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1594         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1595         print them.
1596         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1597         plongest to format print it.
1598         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1599         (f77_get_upperbound): Likewise.
1600         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1601         LOWER_BOUND to LONGEST.
1602         (f77_create_arrayprint_offset_tbl): Likewise.
1603
1604 2019-03-29  Keith Seitz  <keiths@redhat.com>
1605
1606         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1607         %s/pulongest for TYPE_LENGTH instead of %d in format
1608         strings.
1609         * ada-typerint.c (ada_print_type): Likewise.
1610         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1611         * compile/compile-c-support.c (generate_register_struct): Likewise.
1612         * gdbtypes.c (recursive_dump_type): Likewise.
1613         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1614         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1615         instead of %d in format strings.
1616         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1617         to std::min to ULONGEST.
1618         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1619         instead of %d in format strings.
1620         * tracepoint.c (info_scope_command): Likewise.
1621         * typeprint.c (print_offset_data::update)
1622         (print_offset_data::finish): Likewise.
1623         * xtensa-tdep.c (xtensa_store_return_value)
1624         (xtensa_push_dummy_call): Likewise.
1625
1626 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1627
1628         * windows-nat.c (display_selector): Fixed format specifications
1629         for 64-bit Cygwin.
1630
1631 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1632
1633         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1634
1635 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1636
1637         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1638         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1639         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1640         (nios2_linux_init_abi): Install it.
1641
1642 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1643
1644         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1645
1646 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1649
1650 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1651             Tom Tromey  <tromey@adacore.com>
1652
1653         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1654
1655 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1656
1657         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1658         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1659         method to compute the bounds of range types. Also print "[evaluated]"
1660         if the bounds' values come from a dynamic evaluation.
1661
1662 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1665         whitespace when pretty printing is on.
1666
1667 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1668
1669         * ppc-linux-nat.c: Add include.
1670
1671 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * NEWS: Mention AArch64 Pointer Authentication.
1674
1675 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1676
1677         * arm-linux-nat.c: Add include.
1678
1679 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1680
1681         * source-cache.c (source_cache::get_source_lines): Re-read
1682         fullname after calling open_source_file.
1683
1684 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1685
1686         * NEWS: Mention TLS support for FreeBSD.
1687
1688 2019-03-25  Tom Tromey  <tromey@adacore.com>
1689
1690         * minsyms.c (BUNCH_SIZE): Update comment.
1691         (~minimal_symbol_reader): Remove old comment.
1692         (compact_minimal_symbols): Update comment.
1693         (minimal_symbol_reader::install): Remove old comment.  Update
1694         other comments.
1695
1696 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1697
1698         * s390-linux-nat.c: Add include.
1699
1700 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1701
1702         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1703         Call linux_get_hwcap.
1704         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1705         Likewise.
1706         (aarch64_linux_get_hwcap): Remove function.
1707         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1708         declaration.
1709         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1710         linux_get_hwcap.
1711         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1712         * linux-tdep.c (linux_get_hwcap): Add function.
1713         (linux_get_hwcap2): Likewise.
1714         * linux-tdep.h (linux_get_hwcap): Add declaration.
1715         (linux_get_hwcap2): Likewise.
1716         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1717         (ppc_linux_get_hwcap2): Likewise.
1718         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1719         linux_get_hwcap.
1720         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1721         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1722         (ppc_linux_nat_target::read_description): Likewise.
1723         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1724         * s390-linux-nat.c: Likewise.
1725         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1726
1727 2019-03-24  Tom Tromey  <tom@tromey.com>
1728
1729         * ada-lang.c (standard_lookup): Simplify initialization.
1730         (ada_lookup_symbol_nonlocal): Simplify return.
1731         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1732         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1733         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1734         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1735         initialization.
1736         * solib.c (solib_global_lookup): Simplify.
1737         * symtab.c (null_block_symbol): Remove.
1738         (symbol_cache_lookup): Simplify returns.
1739         (lookup_language_this): Simplify returns.
1740         (lookup_symbol_aux): Simplify return.
1741         (lookup_local_symbol): Simplify returns.
1742         (lookup_global_symbol_from_objfile): Simplify return.
1743         (lookup_symbol_in_objfile_symtabs)
1744         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1745         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1746         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1747         * cp-namespace.c (cp_lookup_bare_symbol)
1748         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1749         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1750         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1751         (cp_lookup_symbol_via_imports): Simplify initialization.
1752         (find_symbol_in_baseclass): Likewise.
1753         * symtab.h (null_block_symbol): Remove.
1754         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1755         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1756         (d_lookup_symbol_module): Likewise.
1757         (find_symbol_in_baseclass): Simplify initialization.
1758
1759 2019-03-24  Tom Tromey  <tom@tromey.com>
1760
1761         * expression.h: Don't include symtab.h.
1762         (struct block): Forward declare.
1763
1764 2019-03-24  Tom Tromey  <tom@tromey.com>
1765
1766         * c-exp.y (typebase): Remove casts.
1767         * gdbtypes.c (lookup_unsigned_typename, )
1768         (lookup_signed_typename): Remove cast.
1769         * eval.c (parse_to_comma_and_eval): Remove cast.
1770         * parse.c (write_dollar_variable): Remove cast.
1771         * block.h (struct block) <superblock>: Now const.
1772         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1773         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1774         (map_block): Make "block" const.
1775         * symfile.h (struct quick_symbol_functions)
1776         <map_matching_symbols>: Constify block argument to "callback".
1777         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1778         const.
1779         (find_pc_sect_compunit_symtab): Make "b" const.
1780         (find_symbol_at_address): Likewise.
1781         (search_symbols): Likewise.
1782         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1783         (dw2_debug_names_lookup_symbol): Likewise.
1784         (dw2_map_matching_symbols): Update.
1785         * p-valprint.c (pascal_val_print): Remove "block".
1786         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1787         (aux_add_nonlocal_symbols): Make "block" const.
1788         (resolve_subexp): Remove cast.
1789         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1790         const.
1791         (iterate_over_file_blocks): Likewise.
1792         * f-exp.y (%union) <bval>: Remove.
1793         * coffread.c (patch_opaque_types): Make "b" const.
1794         * spu-tdep.c (spu_catch_start): Make "block" const.
1795         * c-valprint.c (print_unpacked_pointer): Remove "block".
1796         * symmisc.c (dump_symtab_1): Make "b" const.
1797         (block_depth): Make "block" const.
1798         * d-exp.y (%union) <bval>: Remove.
1799         * cp-support.h (cp_lookup_rtti_type): Update.
1800         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1801         * psymtab.c (psym_lookup_symbol): Make "block" const.
1802         (maintenance_check_psymtabs): Make "b" const.
1803         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1804         (enumerate_locals, enumerate_args): Update.
1805         * python/py-symtab.c (stpy_global_block): Make "block" const.
1806         (stpy_static_block): Likewise.
1807         * inline-frame.c (block_starting_point_at): Make "new_block"
1808         const.
1809         * block.c (find_block_in_blockvector): Make return type const.
1810         (blockvector_for_pc_sect): Make "b" const.
1811         (find_block_in_blockvector): Make "b" const.
1812
1813 2019-03-23  Tom Tromey  <tom@tromey.com>
1814
1815         * varobj.c (varobj_create): Update.
1816         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1817         * printcmd.c (display_command, do_one_display): Don't reset
1818         innermost_block.
1819         * parser-defs.h (enum innermost_block_tracker_type): Move to
1820         expression.h.
1821         (innermost_block): Update comment.
1822         * parse.c (parse_exp_1): Add tracker_types parameter.
1823         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1824         tracker_types parameter.  Reset innermost_block.
1825         (parse_exp_in_context): Remove.
1826         (parse_expression_for_completion): Update.
1827         * objfiles.c (~objfile): Don't reset expression_context_block or
1828         innermost_block.
1829         * expression.h (enum innermost_block_tracker_type): Move from
1830         parser-defs.h.
1831         (parse_exp_1): Add tracker_types parameter.
1832         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1833         reset innermost_block.
1834
1835 2019-03-23  Tom Tromey  <tom@tromey.com>
1836
1837         * objfiles.h: Include bcache.h.
1838
1839 2019-03-23  Tom Tromey  <tom@tromey.com>
1840
1841         * linespec.c (get_current_search_block): Use
1842         scoped_restore_current_language.
1843         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1844
1845 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1846             Jiong Wang  <jiong.wang@arm.com>
1847
1848         * aarch64-linux-tdep.c
1849         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1850         section.
1851         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1852
1853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1854             Jiong Wang  <jiong.wang@arm.com>
1855
1856         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1857         instructions.
1858         (aarch64_analyze_prologue_test): Add PACIASP test.
1859         (aarch64_prologue_prev_register): Unmask PC value.
1860
1861 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1862             Jiong Wang  <jiong.wang@arm.com>
1863
1864         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1865         (aarch64_dwarf2_prev_register): Unmask PC value.
1866         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1867         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1868         DW_CFA_AARCH64_negate_ra_state.
1869         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1870
1871 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1872             Jiong Wang  <jiong.wang@arm.com>
1873
1874         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1875         registers.
1876         (aarch64_pseudo_register_name): Likewise.
1877         (aarch64_pseudo_register_type): Likewise.
1878         (aarch64_pseudo_register_reggroup_p): Likewise.
1879         (aarch64_gdbarch_init): Add pauth registers.
1880         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1881         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1882         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1883         (struct gdbarch_tdep): Add regnum for ra_state.
1884
1885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1886             Jiong Wang  <jiong.wang@arm.com>
1887
1888         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1889
1890 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1891             Jiong Wang  <jiong.wang@arm.com>
1892
1893         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1894         function.
1895         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1896         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1897         (aarch64_gdbarch_init): Add puth registers.
1898         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1899         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1900         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1901
1902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1903             Jiong Wang  <jiong.wang@arm.com>
1904
1905         * aarch64-linux-nat.c
1906         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1907         * aarch64-linux-tdep.c
1908         (aarch64_linux_core_read_description): Likewise.
1909         (aarch64_linux_get_hwcap): New function.
1910         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1911         (aarch64_linux_get_hwcap): New declaration.
1912
1913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1914             Jiong Wang  <jiong.wang@arm.com>
1915
1916         * aarch64-linux-nat.c
1917         (aarch64_linux_nat_target::read_description): Add pauth param.
1918         * aarch64-linux-tdep.c
1919         (aarch64_linux_core_read_description): Likewise.
1920         * aarch64-tdep.c (struct target_desc): Add in pauth.
1921         (aarch64_read_description): Add pauth param.
1922         (aarch64_gdbarch_init): Likewise.
1923         * aarch64-tdep.h (aarch64_read_description): Likewise.
1924         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1925         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1926         * features/Makefile: Add new files.
1927         * features/aarch64-pauth.c: New file.
1928         * features/aarch64-pauth.xml: New file.
1929
1930 2019-03-20  Tom Tromey  <tromey@adacore.com>
1931
1932         * infrun.c (handle_inferior_event): Rename from
1933         handle_inferior_event_1.  Create a scoped_value_mark.
1934         (handle_inferior_event): Remove.
1935
1936 2019-03-19  Tom Tromey  <tromey@adacore.com>
1937
1938         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1939         * infrun.h (print_stop_event): Add "displays" parameter.
1940         * infrun.c (print_stop_event): Add "displays" parameter.
1941
1942 2019-03-19  Pedro Alves  <palves@redhat.com>
1943
1944         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1945         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1946         to -1.  Fix TABs vs spaces.
1947         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1948         * tui/tui-out.h (tui_ui_out) Add intro comments.
1949         <m_line, m_start_of_line>: In-class initialize, and add describing
1950         comment.
1951
1952 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1953
1954         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1955         variable names.
1956         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1957
1958 2019-03-18  Pedro Alves  <palves@redhat.com>
1959             Eli Zaretskii <eliz@gnu.org>
1960
1961         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1962         m_line and m_start_of_line.
1963
1964 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1965
1966         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1967         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1968         it returns a newline.  This fixes a regression in TU mode, whereby
1969         the next line is output on the same screen line as the user input.
1970
1971 2019-03-18  Tom Tromey  <tromey@adacore.com>
1972
1973         * minsyms.c (minimal_symbol_reader::install): Remove call to
1974         obstack_blank.
1975
1976 2019-03-18  Pedro Alves  <palves@redhat.com>
1977
1978         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1979         New globals.
1980         (apply_style): New, factored out from ...
1981         (apply_ansi_escape): ... this.  Handle reverse video mode.
1982         (tui_set_reverse_mode): New function.
1983         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1984         * tui/tui-winsource.c (tui_show_source_line): Use
1985         tui_set_reverse_mode instead of setting A_STANDOUT.
1986         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1987         New setter methods.
1988
1989 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1990
1991         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1992         Handle tabs.
1993
1994 2019-03-18  Tom Tromey  <tromey@adacore.com>
1995
1996         * ada-lang.c (empty_array): Add "high" parameter.
1997         (ada_evaluate_subexp): Update.
1998
1999 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2000
2001         * unittests/string_view-selftests.c: Define
2002         _initialize_string_view_selftests unconditionally.
2003
2004 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2005
2006         PR gdb/24350
2007         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2008
2009 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2010
2011         PR gdb/24351
2012         * windows-nat.c (display_selector): Fix format specifiers.
2013
2014 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2015
2016         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2017         tui_refill_source_window instead of tui_refresh_win, to update the
2018         current execution line.  This fixes redisplay of the current line
2019         when stepping through the code with "next" or "step".
2020
2021 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2022
2023         * source-cache.c (source_cache::get_source_lines): Call
2024         find_source_lines to initialize s->nlines.  This fixes vertical
2025         scrolling of TUI source window when the DOWN arrow is pressed.
2026
2027 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2028
2029         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2030         linux-thread-db.c (_initialize_thread_db): Likewise.
2031
2032 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2033
2034         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2035         wclrtoeol in tui_show_source_line".  This reverts changes made in
2036         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2037
2038 2019-03-15  Tom Tromey  <tom@tromey.com>
2039
2040         * symtab.h (struct minimal_symbol): Derive from
2041         general_symbol_info.
2042         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2043         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2044         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2045         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2046         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2047         (MSYMBOL_SEARCH_NAME): Update.
2048         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2049         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2050         * minsyms.c (minimal_symbol_reader::record_full): Update.
2051
2052 2019-03-15  Tom Tromey  <tom@tromey.com>
2053
2054         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2055
2056 2019-03-15  Tom Tromey  <tom@tromey.com>
2057
2058         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2059         unique_xmalloc_ptr.
2060         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2061         Update.
2062         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2063         (build_minimal_symbol_hash_tables)
2064         (minimal_symbol_reader::install): Update.
2065
2066 2019-03-15  Tom Tromey  <tom@tromey.com>
2067
2068         * symtab.c (create_demangled_names_hash): Update.
2069         (symbol_set_names): Update.
2070         * objfiles.h (struct objfile_per_bfd_storage)
2071         <demangled_names_hash>: Now an htab_up.
2072         * objfiles.c (objfile_per_bfd_storage): Simplify.
2073
2074 2019-03-15  Tom Tromey  <tom@tromey.com>
2075
2076         * objfiles.h (struct objfile_per_bfd_storage): Declare
2077         destructor.
2078         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2079         New.
2080         (get_objfile_bfd_data): Use new.  Don't initialize
2081         language_of_main.
2082         (free_objfile_per_bfd_storage): Remove.
2083         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2084
2085 2019-03-15  Tom Tromey  <tom@tromey.com>
2086
2087         * symfile.c (reread_symbols): Update.
2088         * objfiles.c (objfile::objfile): Update.
2089         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2090         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2091         comment.
2092         (minimal_symbol_reader::install): Update.
2093         (terminate_minimal_symbol_table): Remove.
2094         * jit.c (jit_object_close_impl): Update.
2095
2096 2019-03-15  Tom Tromey  <tom@tromey.com>
2097
2098         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2099         initializations.
2100
2101 2019-03-15  Tom Tromey  <tom@tromey.com>
2102
2103         * objfiles.h (struct objfile_per_bfd_storage)
2104         <demangled_hash_languages>: Now a bitset.
2105         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2106         (lookup_minimal_symbol): Update.
2107
2108 2019-03-15  Tom Tromey  <tom@tromey.com>
2109
2110         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2111         Don't return the symbol.
2112         * coffread.c (record_minimal_symbol): Use record_full.
2113
2114 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2115
2116         The MS-Windows port of ncurses fails to switch to a color pair if
2117         one or both of the colors are the implicit default colors.  This
2118         change records the default colors when TUI is initialized, and
2119         then specifies them explicitly when a color pair uses the default
2120         colors.  This allows color styling in TUI mode on MS-Windows.
2121
2122         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2123         ncurses_norm_attr.
2124         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2125         colors in ncurses_norm_attr.
2126         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2127         "none", replace it with the default color recorded in
2128         ncurses_norm_attr.
2129
2130 2019-03-14  Tom Tromey  <tromey@adacore.com>
2131
2132         * source-cache.h (class source_cache) <get_source_lines>: Return
2133         std::string.
2134         * source-cache.c (source_cache::extract_lines): Handle case where
2135         first_pos==npos.  Return std::string.
2136         (source_cache::get_source_lines): Update.
2137
2138 2019-03-14  Tom Tromey  <tromey@adacore.com>
2139
2140         * NEWS: Add item for "style sources" commands.
2141         * source-cache.c (source_cache::get_source_lines): Check
2142         source_styling.
2143         * cli/cli-style.c (source_styling): New global.
2144         (_initialize_cli_style): Add "style sources" commands.
2145         (show_style_sources): New function.
2146         * cli/cli-style.h (source_styling): Declare.
2147
2148 2019-03-14  Pedro Alves  <palves@redhat.com>
2149             Tom Tromey  <tromey@adacore.com>
2150
2151         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2152         * tui/tui-winsource.c (tui_refill_source_window): New function,
2153         from...
2154         (tui_horizontal_source_scroll): ... here.  Move some logic.
2155         * cli/cli-style.c (set_style_enabled): Notify new observable.
2156         * tui/tui-hooks.c (tui_redisplay_source): New function.
2157         (tui_attach_detach_observers): Attach or detach
2158         tui_redisplay_source.
2159         * observable.h (source_styling_changed): New observable.
2160         * observable.c: Define source_styling_changed observable.
2161
2162 2019-03-13  Tom Tromey  <tromey@adacore.com>
2163
2164         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2165         (i386_gnu_nat_target::store_registers): Update.
2166         * target-debug.h (target_debug_print_std_string): New macro.
2167         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2168         * windows-tdep.c (display_one_tib): Update.
2169         * tui/tui-stack.c (tui_make_status_line): Update.
2170         * top.c (print_inferior_quit_action): Update.
2171         * thread.c (thr_try_catch_cmd): Update.
2172         (add_thread_with_info): Update.
2173         (thread_target_id_str): Update.
2174         (thr_try_catch_cmd): Update.
2175         (thread_command): Update.
2176         (thread_find_command): Update.
2177         * record-btrace.c (record_btrace_target::info_record)
2178         (record_btrace_resume_thread, record_btrace_target::resume)
2179         (record_btrace_cancel_resume, record_btrace_step_thread)
2180         (record_btrace_target::wait, record_btrace_target::wait)
2181         (record_btrace_target::wait, record_btrace_target::stop): Update.
2182         * progspace.c (print_program_space): Update.
2183         * process-stratum-target.c
2184         (process_stratum_target::thread_address_space): Update.
2185         * linux-fork.c (linux_fork_mourn_inferior)
2186         (detach_checkpoint_command, info_checkpoints_command)
2187         (linux_fork_context): Update.
2188         (linux_fork_detach): Update.
2189         (class scoped_switch_fork_info): Update.
2190         (delete_checkpoint_command): Update.
2191         * infrun.c (follow_fork_inferior): Update.
2192         (follow_fork_inferior): Update.
2193         (proceed_after_vfork_done): Update.
2194         (handle_vfork_child_exec_or_exit): Update.
2195         (follow_exec): Update.
2196         (displaced_step_prepare_throw): Update.
2197         (displaced_step_restore): Update.
2198         (start_step_over): Update.
2199         (resume_1): Update.
2200         (clear_proceed_status_thread): Update.
2201         (proceed): Update.
2202         (print_target_wait_results): Update.
2203         (do_target_wait): Update.
2204         (context_switch): Update.
2205         (stop_all_threads): Update.
2206         (restart_threads): Update.
2207         (finish_step_over): Update.
2208         (handle_signal_stop): Update.
2209         (switch_back_to_stepped_thread): Update.
2210         (keep_going_pass_signal): Update.
2211         (print_exited_reason): Update.
2212         (normal_stop): Update.
2213         * inferior.c (inferior_pid_to_str): Change return type.
2214         (print_selected_inferior): Update.
2215         (add_inferior): Update.
2216         (detach_inferior): Update.
2217         * dummy-frame.c (fprint_dummy_frames): Update.
2218         * dcache.c (dcache_info_1): Update.
2219         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2220         (btrace_fetch, btrace_clear): Update.
2221         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2222         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2223         type.
2224         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2225         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2226         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2227         * gdbarch.c, gdbarch.h: Rebuild.
2228         * gdbarch.sh (core_pid_to_str): Change return type.
2229         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2230         return type.
2231         (windows_nat_target::pid_to_str): Change return type.
2232         (windows_delete_thread): Update.
2233         (windows_nat_target::attach): Update.
2234         (windows_nat_target::files_info): Update.
2235         * target-delegates.c: Rebuild.
2236         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2237         return type.
2238         (sol_thread_target::pid_to_str): Change return type.
2239         * remote.c (class remote_target) <pid_to_str>: Change return
2240         type.
2241         (remote_target::pid_to_str): Change return type.
2242         (extended_remote_target::attach, remote_target::remote_stop_ns)
2243         (remote_target::remote_notif_remove_queued_reply)
2244         (remote_target::push_stop_reply, remote_target::disable_btrace):
2245         Update.
2246         (extended_remote_target::attach): Update.
2247         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2248         type.
2249         (gdbsim_target::pid_to_str): Change return type.
2250         * ravenscar-thread.c (struct ravenscar_thread_target)
2251         <pid_to_str>: Change return type.
2252         (ravenscar_thread_target::pid_to_str): Change return type.
2253         * procfs.c (class procfs_target) <pid_to_str>: Change return
2254         type.
2255         (procfs_target::pid_to_str): Change return type.
2256         (procfs_target::attach): Update.
2257         (procfs_target::detach): Update.
2258         (procfs_target::fetch_registers): Update.
2259         (procfs_target::store_registers): Update.
2260         (procfs_target::wait): Update.
2261         (procfs_target::files_info): Update.
2262         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2263         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2264         return type.
2265         (nto_procfs_target::pid_to_str): Change return type.
2266         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2267         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2268         return type.
2269         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2270         (exit_lwp): Update.
2271         (attach_proc_task_lwp_callback, get_detach_signal)
2272         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2273         (linux_nat_target::resume, wait_lwp, stop_callback)
2274         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2275         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2276         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2277         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2278         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2279         type.
2280         (inf_ptrace_target::attach): Update.
2281         (inf_ptrace_target::files_info): Update.
2282         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2283         type.
2284         (go32_nat_target::pid_to_str): Change return type.
2285         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2286         (gnu_nat_target::wait): Update.
2287         (gnu_nat_target::wait): Update.
2288         (gnu_nat_target::resume): Update.
2289         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2290         (fbsd_nat_target::wait): Update.
2291         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2292         type.
2293         (darwin_nat_target::attach): Update.
2294         * corelow.c (class core_target) <pid_to_str>: Change return type.
2295         (core_target::pid_to_str): Change return type.
2296         * target.c (normal_pid_to_str): Change return type.
2297         (default_pid_to_str): Likewise.
2298         (target_pid_to_str): Change return type.
2299         (target_translate_tls_address): Update.
2300         (target_announce_detach): Update.
2301         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2302         return type.
2303         (bsd_uthread_target::pid_to_str): Change return type.
2304         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2305         type.
2306         (bsd_kvm_target::pid_to_str): Change return type.
2307         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2308         return type.
2309         (aix_thread_target::pid_to_str): Change return type.
2310         * target.h (struct target_ops) <pid_to_str>: Change return type.
2311         (target_pid_to_str, normal_pid_to_str): Likewise.
2312         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2313         type.
2314         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2315         type.
2316         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2317         return type.
2318         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2319         type.
2320         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2321         type.
2322         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2323         return type.
2324
2325 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2326
2327         * NEWS: Mention that the new default MI version is 3.  Mention
2328         changes to the output of commands and events that deal with
2329         multi-location breakpoints.
2330         * breakpoint.c: Include "mi/mi-out.h".
2331         (print_one_breakpoint): Change output syntax if using MI version
2332         >= 3.
2333         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2334         New.
2335         (mi_multi_location_breakpoint_output_fixed): New.
2336         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2337         (mi_cmd_fix_multi_location_breakpoint_output): New.
2338         (mi_multi_location_breakpoint_output_fixed): New.
2339         * mi/mi-cmds.c (mi_cmds): Register command
2340         -fix-multi-location-breakpoint-output.
2341         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2342         interpreter "mi".
2343
2344 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2345
2346         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2347         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2348         instantiate mi_ui_out based on interpreter name.
2349         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2350         * mi/mi-main.c (mi_load_progress): Likewise.
2351
2352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2353
2354         * NEWS: Combine separate "New targets" sections for 8.3.
2355
2356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2357
2358         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2359         (ppcfbsd_init_abi): Install gdbarch
2360         "fetch_tls_load_module_address" and "get_thread_local_address"
2361         methods.
2362
2363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2364
2365         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2366         (riscv_fbsd_init_abi): Install gdbarch
2367         "fetch_tls_load_module_address" and "get_thread_local_address"
2368         methods.
2369
2370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2371
2372         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2373         (i386fbsd_init_abi): Install gdbarch
2374         "fetch_tls_load_module_address" and "get_thread_local_address"
2375         methods.
2376
2377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2378
2379         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2380         (amd64fbsd_init_abi): Install gdbarch
2381         "fetch_tls_load_module_address" and "get_thread_local_address"
2382         methods.
2383
2384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2385
2386         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2387         (struct fbsd_pspace_data): New type.
2388         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2389         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2390         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2391         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2392         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2393
2394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2395
2396         * gdbtypes.c (lookup_struct_elt): New function.
2397         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2398         * gdbtypes.h (struct struct_elt): New type.
2399         (lookup_struct_elt): New prototype.
2400
2401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2402
2403         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2404         remove disabled code block.
2405
2406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2407
2408         * gdbarch.sh (get_thread_local_address): New method.
2409         * gdbarch.h, gdbarch.c: Regenerate.
2410         * target.c (target_translate_tls_address): Use
2411         gdbarch_get_thread_local_address if present instead of
2412         target::get_thread_local_address.
2413
2414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2415
2416         * target.h (target::get_thread_local_address): Update comment.
2417
2418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2419
2420         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2421         objfile->separate_debug_objfile_backlink if not NULL.
2422
2423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2424
2425         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2426         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2427         (amd64bsd_store_inferior_registers): Likewise.
2428         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2429         Enable segment base registers.
2430         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2431         PT_GETFSBASE and PT_GETGSBASE.
2432         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2433         PT_SETGSBASE.
2434         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2435         segment base registers.
2436         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2437
2438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2439
2440         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2441         Update calls to i386_target_description to add 'segments'
2442         parameter.
2443         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2444         add segment base registers.
2445         * arch/i386.c (i386_create_target_description): Add 'segments'
2446         parameter to enable segment base registers.
2447         * arch/i386.h (i386_create_target_description): Likewise.
2448         * features/i386/32bit-segments.xml: New file.
2449         * features/i386/32bit-segments.c: Generate.
2450         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2451         call to i386_target_description to add 'segments' parameter.
2452         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2453         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2454         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2455         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2456         if feature is present.
2457         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2458         Add 'segments' parameter to call to i386_target_description.
2459         (i386_target_description): Add 'segments' parameter to enable
2460         segment base registers.
2461         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2462         to call to i386_target_description.
2463         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2464         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2465         Define I386_NUM_REGS.
2466         (i386_target_description): Add 'segments' parameter to enable
2467         segment base registers.
2468
2469 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2470
2471         PR/24325
2472         * source-cache.c: #undef open and close, to avoid unresolved
2473         externals during linking.
2474
2475 2019-03-12  Tom Tromey  <tromey@adacore.com>
2476
2477         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2478         const.  Add initializers.
2479         (_initialize_remote): Don't initialize ptid globals.
2480
2481 2019-03-12  Pedro Alves  <palves@redhat.com>
2482
2483         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2484
2485 2019-03-12  Pedro Alves  <palves@redhat.com>
2486
2487         * cp-name-parser.y (main): Remove unused 'len' variable.
2488
2489 2019-03-12  Tom Tromey  <tromey@adacore.com>
2490
2491         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2492         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2493
2494 2019-03-12  Tom Tromey  <tromey@adacore.com>
2495
2496         * linux-nat.c (iterate_over_lwps): Update.
2497         (stop_callback): Remove parameter.
2498         (stop_wait_callback, detach_callback, resume_set_callback)
2499         (select_singlestep_lwp_callback, set_ignore_sigint)
2500         (status_callback, resumed_callback, resume_clear_callback)
2501         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2502         data parameter.
2503         (linux_nat_target::detach, linux_nat_target::resume)
2504         (linux_stop_and_wait_all_lwps, select_event_lwp)
2505         (linux_nat_filter_event, linux_nat_wait_1)
2506         (linux_nat_target::kill, linux_nat_target::stop)
2507         (linux_nat_target::stop): Update.
2508         (linux_nat_resume_callback): Change type.
2509         (resume_stopped_resumed_lwps, count_events_callback)
2510         (select_event_lwp_callback): Likewise.
2511         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2512         * arm-linux-nat.c (struct update_registers_data): Remove.
2513         (update_registers_callback): Change type.
2514         (arm_linux_insert_hw_breakpoint1): Update.
2515         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2516         parameter.
2517         (x86_linux_dr_set_addr): Update.
2518         (x86_linux_dr_set_control): Update.
2519         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2520         (iterate_over_lwps): Use gdb::function_view.
2521         * nat/aarch64-linux-hw-point.c (struct
2522         aarch64_dr_update_callback_param): Remove.
2523         (debug_reg_change_callback): Change type.
2524         (aarch64_notify_debug_reg_change): Update.
2525         * s390-linux-nat.c (s390_refresh_per_info): Update.
2526
2527 2019-03-11  Tom Tromey  <tromey@adacore.com>
2528
2529         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2530         redundant assignment to "this_cu".
2531
2532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2533
2534         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2535
2536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2537
2538         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2539         from...
2540         (rank_one_type): ... this.
2541
2542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2543
2544         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2545         from...
2546         (rank_one_type): ... this.
2547
2548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2549
2550         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2551         from...
2552         (rank_one_type): ... this.
2553
2554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2555
2556         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2557         from...
2558         (rank_one_type): ... this.
2559
2560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2561
2562         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2563         from...
2564         (rank_one_type): ... this.
2565
2566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2567
2568         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2569         from...
2570         (rank_one_type): ... this.
2571
2572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2573
2574         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2575         from...
2576         (rank_one_type): ... this.
2577
2578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2579
2580         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2581         from...
2582         (rank_one_type): ... this.
2583
2584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2585
2586         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2587         from...
2588         (rank_one_type): ... this.
2589
2590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2591
2592         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2593         from...
2594         (rank_one_type): ... this.
2595
2596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2597
2598         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2599         from...
2600         (rank_one_type): ... this.
2601
2602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2603
2604         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2605         from...
2606         (rank_one_type): ... this.
2607
2608 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2609
2610         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2611         inferior-events' shows the example events.
2612
2613 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2614
2615         Support styling on native MS-Windows console
2616
2617         PR/24315
2618         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2619         on MS-Windows if $TERM is not defined.
2620
2621         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2622
2623         * posix-hdep.c (gdb_console_fputs):
2624         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2625         functions.
2626         * ui-file.h (gdb_console_fputs): Add prototype.
2627
2628         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2629         back to fputs only if the former returns zero.
2630
2631 2019-03-07  Tom Tromey  <tom@tromey.com>
2632
2633         * symmisc.c (print_symbol_bcache_statistics): Update.
2634         (print_objfile_statistics): Update.
2635         * symfile.c (allocate_symtab): Update.
2636         * stabsread.c: Don't include bcache.h.
2637         * psymtab.h (struct psymbol_bcache): Don't declare.
2638         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2639         (psymbol_bcache_init, psymbol_bcache_free)
2640         (psymbol_bcache_get_bcache): Don't declare.
2641         * psymtab.c (struct psymbol_bcache): Remove.
2642         (psymtab_storage::psymtab_storage): Update.
2643         (psymtab_storage::~psymtab_storage): Update.
2644         (psymbol_bcache_init, psymbol_bcache_free)
2645         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2646         (add_psymbol_to_bcache): Update.
2647         (allocate_psymtab): Update.
2648         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2649         macro_cache>: No longer pointers.
2650         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2651         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2652         * macrotab.c (macro_bcache): Update.
2653         * macroexp.c: Don't include bcache.h.
2654         * gdbtypes.c (check_types_worklist): Update.
2655         (types_deeply_equal): Remove TRY/CATCH.  Update.
2656         * elfread.c (elf_symtab_read): Update.
2657         * dwarf2read.c: Don't include bcache.h.
2658         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2659         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2660         (print_bcache_statistics, bcache_memory_used): Don't declare.
2661         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2662         methods.  Rename all data members.
2663         * bcache.c (struct bcache): Move to bcache.h.
2664         (bcache::expand_hash_table): Rename from expand_hash_table.
2665         (bcache): Remove.
2666         (bcache::insert): Rename from bcache_full.
2667         (bcache::compare): Rename from bcache_compare.
2668         (bcache_xmalloc): Remove.
2669         (bcache::~bcache): Rename from bcache_xfree.
2670         (bcache::print_statistics): Rename from print_bcache_statistics.
2671         (bcache::memory_used): Rename from bcache_memory_used.
2672
2673 2019-03-07  Pedro Alves  <palves@redhat.com>
2674
2675         * infrun.c (normal_stop): Also check for
2676         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2677
2678 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * f-lang.c (value_from_host_double): Moved to...
2681         * value.c (value_from_host_double): ...here.
2682         * value.h (value_from_host_double): Declare.
2683         * guile/scm-math.c (vlscm_convert_typed_number): Use
2684         value_from_host_double.
2685         (vlscm_convert_number): Likewise.
2686         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2687         * python/py-value.c (convert_value_from_python): Likewise.
2688
2689 2019-03-06  Tom Tromey  <tom@tromey.com>
2690
2691         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2692
2693 2019-03-06  Tom Tromey  <tom@tromey.com>
2694
2695         * utils.h (free_current_contents): Don't declare.
2696         * utils.c (free_current_contents): Remove.
2697
2698 2019-03-06  Tom Tromey  <tom@tromey.com>
2699
2700         * top.c (quit_force): Update.
2701         * main.c (captured_command_loop): Update.
2702         * common/new-op.c (operator new): Update.
2703         * common/common-exceptions.c (struct catcher)
2704         <save_cleanup_chain>: Remove member.
2705         (exceptions_state_mc_init): Update.
2706         (exception_try_scope_entry): Return nullptr.
2707         (exception_try_scope_exit, exception_rethrow)
2708         (throw_exception_sjlj, throw_exception_cxx): Update.
2709         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2710         (all_cleanups, do_cleanups, discard_cleanups)
2711         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2712         (restore_cleanups, restore_final_cleanups): Don't declare.
2713         (do_final_cleanups): Remove parameter.
2714         * common/cleanups.c (cleanup_chain, make_cleanup)
2715         (make_cleanup_dtor, all_cleanups, do_cleanups)
2716         (discard_my_cleanups, discard_cleanups)
2717         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2718         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2719         (null_cleanup): Remove.
2720         (do_final_cleanups): Remove parameter.
2721
2722 2019-03-06  Tom Tromey  <tom@tromey.com>
2723
2724         * remote.c (remote_target::remote_parse_stop_reply): Use
2725         unique_xmalloc_ptr.
2726
2727 2019-03-06  Tom Tromey  <tom@tromey.com>
2728
2729         * stabsread.c (struct stabs_field_info): Rename from field_info.
2730         <list, fnlist>: Add initializers.
2731         <obstack>: New member.
2732         (read_member_functions, read_struct_fields, read_baseclasses):
2733         Allocate on obstack.  Don't use cleanups.
2734         (read_one_struct_field, read_member_functions, read_struct_fields)
2735         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2736         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2737         (read_struct_type): Update.
2738
2739 2019-03-06  Tom Tromey  <tom@tromey.com>
2740
2741         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2742         * common/filestuff.h (make_cleanup_close): Don't declare.
2743         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2744         Remove.
2745
2746 2019-03-06  Tom Tromey  <tom@tromey.com>
2747
2748         * solib-aix.c: Use make_scope_exit.
2749
2750 2019-03-06  Tom Tromey  <tom@tromey.com>
2751
2752         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2753         Use make_scope_exit.
2754
2755 2019-03-06  Tom Tromey  <tom@tromey.com>
2756
2757         * solib-svr4.c (disable_probes_interface): Remove parameter.
2758         (svr4_handle_solib_event): Use make_scope_exit.
2759
2760 2019-03-06  Tom Tromey  <tom@tromey.com>
2761
2762         * remote.c (struct stop_reply_deleter): Remove.
2763         (stop_reply_up): Update.
2764         (struct stop_reply): Derive from notif_event.  Don't typedef.
2765         <regcache>: Now a std::vector.
2766         (stop_reply_xfree): Remove.
2767         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2768         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2769         (remote_target::discard_pending_stop_replies): Use delete.
2770         (remote_target::remote_parse_stop_reply): Update.
2771         (remote_target::process_stop_reply): Update.
2772         * remote-notif.h (struct notif_event): Add virtual destructor.
2773         Remove "dtr" member.
2774         (struct notif_client) <alloc_event>: Return a unique_ptr.
2775         (notif_event_xfree): Don't declare.
2776         (notif_event_up): New typedef.
2777         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2778         (notif_event_xfree, do_notif_event_xfree): Remove.
2779         (remote_notif_state_xfree): Update.
2780
2781 2019-03-06  Tom Tromey  <tom@tromey.com>
2782
2783         * infrun.c (displaced_step_clear_cleanup): Now a
2784         forward_scope_exit type.
2785         (displaced_step_prepare_throw): Update.
2786         (displaced_step_fixup): Update.
2787
2788 2019-03-06  Tom Tromey  <tom@tromey.com>
2789
2790         * inferior.h (class inferior): Update comment.
2791         * gdbthread.h (class thread_info): Update comment.
2792
2793 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2794             Tom Tromey  <tom@tromey.com>
2795
2796         * stabsread.h (struct stab_section_list): Remove.
2797         (coffstab_build_psymtabs): Update.
2798         * dbxread.c (symbuf_sections): Now a std::vector.
2799         (sect_idx): New global.
2800         (fill_symbuf): Update.
2801         (coffstab_build_psymtabs): Change type of stabsects parameter.
2802         Update.
2803         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2804         std::vector.
2805         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2806         (coff_locate_sections): Update.
2807         (coff_symfile_read): Remove cleanups.  Update.
2808         (init_stringtab): Add storage parameter.
2809         (free_stringtab, free_stringtab_cleanup): Remove.
2810         (init_lineno): Add storage parameter.
2811         (free_linetab, free_linetab_cleanup): Remove.
2812
2813 2019-03-06  Pedro Alves  <palves@redhat.com>
2814
2815         * linux-fork.c (fork_info::clobber_regs): Delete.
2816         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2817         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2818         comment.  Adjust.
2819         (scoped_switch_fork_info::scoped_switch_fork_info)
2820         (checkpoint_command, linux_fork_context): Adjust
2821         fork_save_infrun_state calls.
2822
2823 2019-03-06  Pedro Alves  <palves@redhat.com>
2824
2825         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2826         (inf_has_multiple_threads): Return 'bool' and rewrite using
2827         inferior_info::threads().
2828
2829 2019-03-06  Pedro Alves  <palves@redhat.com>
2830
2831         * linux-fork.c: Include <list>.
2832         (fork_list): Now a std::list instance.
2833         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2834         (forks_exist_p, find_last_fork): Adjust.
2835         (new_fork): Delete.
2836         (one_fork_p): New.
2837         (add_fork): Adjust.
2838         (free_fork): Delete, folded into fork_info::~fork_info().
2839         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2840         Adjust.
2841         (init_fork_list): Delete.
2842         (linux_fork_killall, linux_fork_mourn_inferior)
2843         (linux_fork_detach, info_checkpoints_command): Adjust.
2844         (_initialize_linux_fork): No longer call init_fork_list.
2845
2846 2019-03-06  Pedro Alves  <palves@redhat.com>
2847
2848         * linux-fork.c (new_fork): New, split out of ...
2849         (add_fork): ... this.  Return void.  Move "first fork" special
2850         case from here, to ...
2851         (checkpoint_command): ... here.
2852         * linux-linux.h (add_fork): Return void.
2853
2854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2857
2858 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2859             Chris January  <chris.january@arm.com>
2860             David Lecomber  <david.lecomber@arm.com>
2861
2862         * f-exp.y: New token, UNOP_INTRINSIC.
2863         (exp): New pattern using UNOP_INTRINSIC token.
2864         (f77_keywords): Add 'abs' keyword.
2865         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2866         (value_from_host_double): New function.
2867         (evaluate_subexp_f): Support UNOP_ABS.
2868
2869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2872         types.
2873
2874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2875
2876         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2877         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2878         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2879
2880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2881
2882         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2883
2884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2885             Chris January  <chris.january@arm.com>
2886
2887         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2888         * f-exp.y: Define 'KIND' token.
2889         (exp): New pattern for KIND expressions.
2890         (ptype): Handle types with a kind extension.
2891         (direct_abs_decl): Extend to spot kind extensions.
2892         (f77_keywords): Add 'kind' to the list.
2893         (push_kind_type): New function.
2894         (convert_to_kind_type): New function.
2895         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2896         * parse.c (operator_length_standard): Likewise.
2897         * parser-defs.h (enum type_pieces): Add tp_kind.
2898         * std-operator.def: Add UNOP_KIND.
2899
2900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2901
2902         * f-exp.y (f_parse): Set yydebug.
2903
2904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * f-lang.c (evaluate_subexp_f): New function.
2907         (exp_descriptor_f): New global.
2908         (f_language_defn): Use exp_descriptor_f instead of
2909         exp_descriptor_standard.
2910
2911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * f-exp.y (struct token): Add comments.
2914         (dot_ops): Remove uppercase versions and the end marker.
2915         (f77_keywords): Likewise.
2916         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2917         entries in the dot_ops array are case insensitive, and use
2918         strncasecmp to compare strings.  Also some whitespace cleanup in
2919         this area.  Similar for the f77_keywords array, except entries in
2920         this list might be case sensitive.
2921
2922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2923
2924         * f-exp.y (struct f77_boolean_val): Add comments.
2925         (boolean_values): Remove uppercase versions, and end marker.
2926         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2927         and use strncasecmp to achieve case insensitivity.  Additionally,
2928         perform whitespace cleanup around this code.
2929
2930 2019-03-06  Tom Tromey  <tromey@adacore.com>
2931
2932         * remote-sim.c (gdbsim_target_open): Use result of
2933         gdb_argv::release.
2934
2935 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2936         Dirk Schubert  <dirk.schubert@arm.com>
2937         Chris January  <chris.january@arm.com>
2938
2939         * eval.c (evaluate_subexp_standard): Call Fortran argument
2940         wrapping logic.
2941         * f-lang.c (struct value): A value which can be passed into a
2942         Fortran function call.
2943         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2944         where appropriate.
2945         (struct type): Value ready for a Fortran function call.
2946         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2947         is needed.
2948         * f-lang.h (fortran_argument_convert): Declaration.
2949         (fortran_preserve_arg_pointer): Declaration.
2950         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2951
2952 2019-03-05  Tom Tromey  <tromey@adacore.com>
2953
2954         * python/py-prettyprint.c (print_string_repr): Remove #if.
2955         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2956
2957 2019-03-05  Tom Tromey  <tromey@adacore.com>
2958
2959         * target.c (the_dummy_target): Move later.  Change type to
2960         "dummy_target".
2961         (initialize_targets): Don't initialize the_dummy_target.
2962
2963 2019-03-05  Tom Tromey  <tromey@adacore.com>
2964
2965         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2966         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2967
2968 2019-03-05  Tom Tromey  <tromey@adacore.com>
2969
2970         * windows-nat.c (windows_nat_target::attach)
2971         (windows_nat_target::detach): Don't call gdb_flush.
2972         * valprint.c (generic_val_print, val_print, val_print_string):
2973         Don't call gdb_flush.
2974         * utils.c (defaulted_query): Don't call gdb_flush.
2975         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2976         * target.c (target_announce_detach): Don't call gdb_flush.
2977         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2978         * remote.c (extended_remote_target::attach): Don't call
2979         gdb_flush.
2980         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2981         * printcmd.c (do_examine): Don't call gdb_flush.
2982         (info_display_command): Don't call gdb_flush.
2983         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2984         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2985         * memattr.c (info_mem_command): Don't call gdb_flush.
2986         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2987         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2988         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2989         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2990         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2991         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2992         (gnu_nat_target::detach): Don't call gdb_flush.
2993         * f-valprint.c (f_val_print): Don't call gdb_flush.
2994         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2995         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2996         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2997         gdb_flush.
2998         * c-valprint.c (c_val_print): Don't call gdb_flush.
2999         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3000
3001 2019-03-05  Tom Tromey  <tromey@adacore.com>
3002
3003         * varobj.c (update_dynamic_varobj_children): Update.
3004         (install_default_visualizer): Use reset, not release.
3005         * value.c (set_internalvar): Update.
3006         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3007         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3008         ATTRIBUTE_UNUSED_RESULT.
3009
3010 2019-03-05  Tom Tromey  <tromey@adacore.com>
3011
3012         * remote.c (class scoped_remote_fd) <release>: Add
3013         ATTRIBUTE_UNUSED_RESULT.
3014
3015 2019-03-05  Tom Tromey  <tromey@adacore.com>
3016
3017         * macroexp.c (struct macro_buffer) <release>: Add
3018         ATTRIBUTE_UNUSED_RESULT.
3019
3020 2019-03-05  Tom Tromey  <tromey@adacore.com>
3021
3022         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3023         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3024         ATTRIBUTE_UNUSED_RESULT.
3025
3026 2019-03-05  Tom Tromey  <tromey@adacore.com>
3027
3028         * common/scoped_fd.h (class scoped_fd) <release>: Add
3029         ATTRIBUTE_UNUSED_RESULT.
3030
3031 2019-03-05  Tom Tromey  <tromey@adacore.com>
3032
3033         * parser-defs.h (struct parser_state) <release>: Add
3034         ATTRIBUTE_UNUSED_RESULT.
3035
3036 2019-03-05  Tom Tromey  <tromey@adacore.com>
3037
3038         * utils.h (class gdb_argv) <release>: Add
3039         ATTRIBUTE_UNUSED_RESULT.
3040         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3041
3042 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3043
3044         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3045         for-loop range, to avoid compiler warnings.
3046
3047         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3048         avoid compiler warnings about unused variables.
3049
3050         * NEWS: Mention end of support for native debugging on MS-Windows
3051         before XP.
3052
3053         PR gdb/24292
3054         * common/netstuff.c:
3055         * gdbserver/gdbreplay.c
3056         * gdbserver/remote-utils.c:
3057         * ser-tcp.c:
3058         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3059         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3060         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3061         'getaddrinfo' and 'freeaddrinfo' were not available before
3062         Windows XP, and mingw.org's MinGW headers by default define
3063         _WIN32_WINNT to 0x500.
3064
3065 2019-03-01  Gary Benson <gbenson@redhat.com>
3066
3067         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3068
3069 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3070             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3071
3072         PR gdb/8527
3073         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3074         set_sigint_trap, clear_sigint_trap.
3075
3076 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3077
3078         * target.c (target_detach): Clear the regcache and the
3079         frame cache.
3080
3081 2019-02-27  Pedro Alves  <palves@redhat.com>
3082
3083         * utils.c (set_screen_size): When we cap the height/width sizes,
3084         tweak the corresponding command variable to show "unlimited":
3085
3086 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3087             Pedro Alves  <palves@redhat.com>
3088
3089         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3090         before calling rl_set_screen_size.
3091
3092 2019-02-27  Tom Tromey  <tromey@adacore.com>
3093
3094         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3095         define.
3096         * python/py-value.c: Remove Python 2.4 workaround.
3097         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3098         workaround.
3099         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3100         Python 2.4 workaround.
3101         * python/python-internal.h: Remove Python 2.4 comment.
3102         (Py_ssize_t): Don't define.
3103         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3104         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3105         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3106         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3107         * python/python.c (do_start_initialization): Remove Python 2.4
3108         workaround.
3109         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3110         (print_children): Remove Python 2.4 workaround.
3111         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3112         workaround.
3113         (CHARBUFFERPROC_NAME): Remove.
3114         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3115         Python 2.4 workaround.
3116
3117 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3118
3119         * NEWS: Note minimum Python version.
3120
3121 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3122
3123         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3124         code from these functions.  Remove corresponding ifdefs.  Use
3125         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3126         Remove gotos and target of gotos.
3127         (infpy_search_memory): Likewise.
3128
3129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3132         (hppa_gdbarch_init): Don't register deleted functions with
3133         gdbarch.
3134
3135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3136
3137         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3138         (h8300_unwind_sp): Delete.
3139         (h8300_dummy_id): Delete.
3140         (h8300_gdbarch_init): Don't register deleted functions with
3141         gdbarch.
3142
3143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3146         (ft32_unwind_pc): Delete.
3147         (ft32_unwind_sp): Delete.
3148         (ft32_gdbarch_init): Don't register deleted functions with
3149         gdbarch.
3150
3151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3154         (frv_unwind_pc): Delete.
3155         (frv_unwind_sp): Delete.
3156         (frv_gdbarch_init): Don't register deleted functions with
3157         gdbarch.
3158
3159 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3162         (riscv_unwind_pc): Delete.
3163         (riscv_unwind_sp): Delete.
3164         (riscv_gdbarch_init): Don't register deleted functions with
3165         gdbarch.
3166
3167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3170         (csky_unwind_pc): Delete.
3171         (csky_unwind_sp): Delete.
3172         (csky_gdbarch_init): Don't register deleted functions with
3173         gdbarch.
3174
3175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3176
3177         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3178         (cris_unwind_pc): Delete.
3179         (cris_unwind_sp): Delete.
3180         (cris_gdbarch_init): Don't register deleted functions with
3181         gdbarch.
3182
3183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3186         (bfin_unwind_pc): Delete.
3187         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3188
3189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3192         (arm_unwind_pc): Delete.
3193         (arm_unwind_sp): Delete.
3194         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3195
3196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3197
3198         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3199         (arc_unwind_pc): Delete.
3200         (arc_unwind_sp): Delete.
3201         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3202
3203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3206         (alpha_unwind_pc): Delete.
3207         (alpha_gdbarch_init): Don't register deleted functions with
3208         gdbarch.
3209
3210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3213         (aarch64_unwind_pc): Delete.
3214         (aarch64_unwind_sp): Delete.
3215         (aarch64_gdbarch_init): Don't register deleted functions with
3216         gdbarch.
3217
3218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * gdbtypes.c (type_align): Don't consider static members when
3221         computing structure alignment.
3222
3223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3224
3225         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3226         return 0 for other types.
3227         * arch-utils.c (default_type_align): Always return 0.
3228         * gdbarch.h: Regenerate.
3229         * gdbarch.sh (type_align): Extend comment.
3230         * gdbtypes.c (type_align): Add additional comments, always call
3231         gdbarch_type_align before applying the default rules.
3232         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3233         generic code will then apply a suitable default.
3234         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3235         types, return 0 for other types.
3236
3237 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3238
3239         * NEWS: Create a new section for the next release branch.
3240         Rename the section of the current branch, now that it has
3241         been cut.
3242
3243 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3244
3245         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3246         * version.in: Bump version to 8.3.50.DATE-git.
3247
3248 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3249
3250         * aix-thread.c (ptid_cmp): Remove unused variable.
3251         (get_signaled_thread): Likewise.
3252         (store_regs_user_thread): Likewise.
3253         (store_regs_kernel_thread): Likewise.
3254         (fetch_regs_kernel_thread): Remove shadowed variable.
3255
3256 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3257
3258         * features/riscv/32bit-cpu.xml: Add register numbers.
3259         * features/riscv/32bit-fpu.c: Regenerate.
3260         * features/riscv/32bit-fpu.xml: Add register numbers.
3261         * features/riscv/64bit-cpu.xml: Add register numbers.
3262         * features/riscv/64bit-fpu.c: Regenerate.
3263         * features/riscv/64bit-fpu.xml: Add register numbers.
3264
3265 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3266
3267         * NEWS: Mention two argument form of gdb.Value constructor.
3268         * python/py-value.c (convert_buffer_and_type_to_value): New
3269         function.
3270         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3271         Add support for handling an optional second argument.  Call
3272         convert_buffer_and_type_to_value as appropriate.
3273         * python/python-internal.h (Py_buffer_deleter): New struct.
3274         (Py_buffer_up): New typedef.
3275
3276 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3277
3278         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3279         instead of releasing ownership.
3280
3281 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3282
3283         * dwarf2read.c (open_and_init_dwp_file): Call
3284         elf_numsections instead of bfd_count_sections to initialize
3285         dwp_file->num_sections.
3286
3287 2019-02-25  Tom Tromey  <tromey@adacore.com>
3288
3289         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3290
3291 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3292
3293         * gcore.in: Add '--readnever' option when invoking GDB.
3294
3295 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3296
3297         * MAINTAINERS: Update my email address.
3298
3299 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3300
3301         * build-id.c (build_id_to_debug_bfd_1): New function.
3302         (build_id_to_debug_bfd): Look for separate debug file in
3303         sysroot.
3304
3305 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3306
3307         * gdbarch.sh: Update the copyright year range that is placed into
3308         generated files.
3309
3310 2019-02-22  Keith Seitz  <keiths@redhat.com>
3311
3312         PR symtab/23853
3313         * linespec.c (create_sals_line_offset): Search for the default
3314         symtab's filename instead of its fullname.
3315
3316 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3317
3318         * NEWS: Update style defaults.
3319
3320 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3321
3322         * main.c (captured_main_1): Disable styling in batch mode.
3323
3324 2019-02-20  Tom Tromey  <tom@tromey.com>
3325
3326         * symtab.c (symtab_symbol_info): Fix typos.
3327
3328 2019-02-20  Tom Tromey  <tromey@adacore.com>
3329
3330         * findcmd.c (_initialize_mem_search): Use upper case for
3331         metasyntactic variables.
3332
3333 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3334
3335         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3336         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3337
3338 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3339
3340         * top.h (source_file_name): Change to std::string.
3341         * top.c (source_file_name): Likewise.
3342         (command_line_input): Adjust.
3343         * cli/cli-script.c (script_from_file): Adjust.
3344
3345 2019-02-19  Tom Tromey  <tromey@adacore.com>
3346
3347         * ravenscar-thread.c
3348         (ravenscar_thread_target::update_thread_list): Don't call
3349         ada_build_task_list.
3350         * ada-lang.h (ada_build_task_list): Don't declare.
3351         * ada-tasks.c (struct ada_tasks_inferior_data)
3352         <task_list_valid_p>: Now bool.
3353         (read_known_tasks, ada_task_list_changed)
3354         (ada_tasks_invalidate_inferior_data): Update.
3355         (read_known_tasks_array): Return bool.
3356         (read_known_tasks_list): Likewise.
3357         (read_known_tasks): Return void.
3358         (ada_build_task_list): Now static.
3359
3360 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3361
3362         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3363         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3364
3365 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3366
3367         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3368         variant for ada_tasks_pspace_data_handle and
3369         ada_tasks_inferior_data_handle.
3370         (ada_tasks_pspace_data_cleanup): New function.
3371         (ada_tasks_inferior_data_cleanup): New function.
3372
3373 2019-02-17  Tom Tromey  <tom@tromey.com>
3374
3375         * macrotab.h (macro_source_fullname): Return a std::string.
3376         * macrotab.c (macro_include, check_for_redefinition)
3377         (macro_undef, macro_lookup_definition, foreach_macro)
3378         (foreach_macro_in_scope): Update.
3379         (macro_source_fullname): Return a std::string.
3380         * macrocmd.c (show_pp_source_pos): Update.
3381
3382 2019-02-17  Tom Tromey  <tom@tromey.com>
3383
3384         * macrocmd.c (show_pp_source_pos): Style the file names.
3385
3386 2019-02-17  Tom Tromey  <tom@tromey.com>
3387
3388         PR tui/24197:
3389         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3390
3391 2019-02-17  Tom Tromey  <tom@tromey.com>
3392
3393         * ada-lang.c (user_select_syms): Use filtered printing.
3394         * utils.c (wrap_style): New global.
3395         (desired_style): Remove.
3396         (emit_style_escape): Add stream parameter.
3397         (set_output_style, reset_terminal_style, prompt_for_continue):
3398         Update.
3399         (flush_wrap_buffer): Only flush gdb_stdout.
3400         (wrap_here): Set wrap_style.
3401         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3402         treat escape sequences as a character.  Change when wrap buffer is
3403         flushed.
3404         (fputs_styled): Do not set the output style when the default is
3405         requested.
3406         * ui-style.h (struct ui_file_style) <is_default>: New method.
3407         * source.c (print_source_lines_base): Emit escape sequences in one
3408         piece.
3409
3410 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3411
3412         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3413         integers and enumeration types.
3414
3415 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3416
3417         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3418         instead of lookup_symbol_in_language
3419         (do_exact_match): New function.
3420         (ada_get_symbol_name_matcher): Return do_exact_match when
3421         doing a verbatim match.
3422
3423 2019-02-15  Tom Tromey  <tromey@adacore.com>
3424
3425         * ravenscar-thread.c (ravenscar_thread_target::resume)
3426         (ravenscar_thread_target::wait): Special case wildcard requests.
3427
3428 2019-02-15  Tom Tromey  <tromey@adacore.com>
3429
3430         * ravenscar-thread.c (base_ptid): Remove.
3431         (struct ravenscar_thread_target) <close>: New method.
3432         <m_base_ptid>: New member.
3433         <update_inferior_ptid, active_task, task_is_currently_active,
3434         runtime_initialized>: Declare methods.
3435         <ravenscar_thread_target>: Add constructor.
3436         (ravenscar_thread_target::task_is_currently_active)
3437         (ravenscar_thread_target::update_inferior_ptid)
3438         (ravenscar_runtime_initialized): Rename.  Now methods.
3439         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3440         (ravenscar_thread_target::update_thread_list): Update.
3441         (ravenscar_thread_target::active_task): Now method.
3442         (ravenscar_thread_target::store_registers)
3443         (ravenscar_thread_target::prepare_to_store)
3444         (ravenscar_thread_target::prepare_to_store)
3445         (ravenscar_thread_target::mourn_inferior): Update.
3446         (ravenscar_inferior_created): Use "new" to create target.
3447         (ravenscar_thread_target::get_ada_task_ptid): Update.
3448         (_initialize_ravenscar): Don't initialize base_ptid.
3449         (ravenscar_ops): Remove global.
3450
3451 2019-02-15  Tom Tromey  <tromey@adacore.com>
3452
3453         * target.h (push_target): Declare new overload.
3454         * target.c (push_target): New overload, taking an rvalue reference.
3455         * remote.c (remote_target::open_1): Use push_target overload.
3456         * corelow.c (core_target_open): Use push_target overload.
3457
3458 2019-02-15  Tom Tromey  <tromey@adacore.com>
3459
3460         * ravenscar-thread.c (is_ravenscar_task)
3461         (ravenscar_task_is_currently_active): Return bool.
3462         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3463         (_initialize_ravenscar): Remove "(void)".
3464         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3465         Return bool.
3466
3467 2019-02-15  Tom Tromey  <tromey@adacore.com>
3468
3469         * ravenscar-thread.c (ravenscar_runtime_initializer)
3470         (has_ravenscar_runtime, get_running_thread_id)
3471         (ravenscar_thread_target::resume): Fix indentation.
3472
3473 2019-02-15  Tom Tromey  <tromey@adacore.com>
3474
3475         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3476         from ravenscar_arch_ops.
3477         (sparc_ravenscar_ops::fetch_registers)
3478         (sparc_ravenscar_ops::store_registers): Now methods.
3479         (sparc_ravenscar_prepare_to_store): Remove.
3480         (sparc_ravenscar_ops): Redefine.
3481         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3482         methods and destructor.  Remove members.
3483         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3484         (ravenscar_thread_target::store_registers)
3485         (ravenscar_thread_target::prepare_to_store): Update.
3486         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3487         Remove.
3488         (struct ppc_ravenscar_powerpc_ops): Derive from
3489         ravenscar_arch_ops.
3490         (ppc_ravenscar_powerpc_ops::fetch_registers)
3491         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3492         (ppc_ravenscar_powerpc_ops): Redefine.
3493         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3494         (ppc_ravenscar_e500_ops::fetch_registers)
3495         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3496         (ppc_ravenscar_e500_ops): Redefine.
3497         * aarch64-ravenscar-thread.c
3498         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3499         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3500         (aarch64_ravenscar_fetch_registers)
3501         (aarch64_ravenscar_store_registers): Now methods.
3502         (aarch64_ravenscar_ops): Redefine.
3503
3504 2019-02-15  Tom Tromey  <tromey@adacore.com>
3505
3506         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3507         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3508         (ravenscar_thread_target::stopped_by_watchpoint)
3509         (ravenscar_thread_target::stopped_data_address)
3510         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3511
3512 2019-02-15  Tom Tromey  <tromey@adacore.com>
3513
3514         * ravenscar-thread.c: Fix some typos.
3515
3516 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3517             Tom Tromey  <tromey@adacore.com>
3518
3519         * ada-lang.c (ada_exception_sal): Change addr_string to a
3520         std::string.
3521         (create_ada_exception_catchpoint): Update.
3522
3523 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3524             Tom Tromey  <tromey@adacore.com>
3525
3526         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3527         (bp_location_ops): Remove.
3528         (base_breakpoint_allocate_location): Update.
3529         (free_bp_location): Update.
3530         * ada-lang.c (class ada_catchpoint_location)
3531         <ada_catchpoint_location>: Remove ops parameter.
3532         (ada_catchpoint_location_dtor): Remove.
3533         (ada_catchpoint_location_ops): Remove.
3534         (allocate_location_exception): Update.
3535         * breakpoint.h (struct bp_location_ops): Remove.
3536         (class bp_location) <bp_location>: Remove bp_location_ops
3537         parameter.
3538         <~bp_location>: Add destructor.
3539         <ops>: Remove.
3540
3541 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3542             Pedro Alves  <palves@redhat.com>
3543
3544         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3545         'PATH_MAX'.
3546
3547 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3548             Samuel Thibault  <samuel.thibault@gnu.org>
3549             Thomas Schwinge  <thomas@codesourcery.com>
3550
3551         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3552         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3553
3554 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3555
3556         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3557         (check_empty): Use "const char *".
3558
3559         * gnu-nat.c (gnu_nat_target::detach): Instead of
3560         'detach_inferior (pid)' call
3561         'detach_inferior (find_inferior_pid (pid))'.
3562
3563         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3564         'nat/fork-inferior.o'.
3565         * gnu-nat.c: #include "nat/fork-inferior.h".
3566
3567         * gnu-nat.c (gnu_nat_target::detach): Instead of
3568         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3569         * gnu-nat.h: #include "inf-child.h".
3570         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3571         'i386_gnu_nat_target::fetch_registers'.
3572         (gnu_store_registers): Rename/move to
3573         'i386_gnu_nat_target::store_registers'.
3574
3575         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3576         * gnu-nat.h (mach_thread_info): New function.
3577         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3578
3579         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3580
3581 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3582
3583         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3584
3585 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3586
3587         * windows-nat.c (windows_add_thread): Add new parameter
3588         "main_thread_p" with default value set to false.  Update
3589         function documentation as well as all callers.
3590         (windows_delete_thread): Likewise.
3591         (fake_create_process): Update call to windows_add_thread.
3592         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3593         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3594         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3595         call to windows_delete_thread.
3596
3597 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3598
3599         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3600
3601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3602
3603         * symfile.c (find_separate_debug_file): Use canonical path of
3604         sysroot with child_path instead of gdb_sysroot if it is valid.
3605
3606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3607
3608         * symfile.c (find_separate_debug_file): Use child_path to
3609         determine if an object file is under a sysroot.
3610
3611 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3612
3613         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3614         unittests/child-path-selftests.c.
3615         * common/pathstuff.c (child_path): New function.
3616         * common/pathstuff.h (child_path): New prototype.
3617         * unittests/child-path-selftests.c: New file.
3618
3619 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3620
3621         * symfile.c (find_separate_debug_file): Look for separate debug
3622         files in debug directories under the sysroot.
3623
3624 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3625
3626         * symtab.h (struct minimal_symbol data_p): New const method.
3627         (struct minimal_symbol text_p): Likewise.
3628         * symtab.c (output_source_filename): Use file name style
3629         to print file name.
3630         (print_symbol_info): Likewise.
3631         (print_msymbol_info): Use address style to print addresses.
3632         Use function name style to print executable text symbols.
3633         (expand_symtab_containing_pc): Use data_p.
3634         (find_pc_sect_compunit_symtab): Likewise.
3635
3636 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3637
3638         * breakpoint.c (describe_other_breakpoints): Use address style
3639         to print addresses.
3640         (say_where): Likewise.
3641
3642 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3643
3644         * ada-typeprint.c (print_func_type): Print function name
3645         style to print function name.
3646         * c-typeprint.c (c_print_type_1): Likewise.
3647
3648 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3649
3650         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3651         for execve.
3652
3653 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3654
3655         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3656         type_stack.
3657
3658 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3659
3660         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3661         TYPE_CODE_REF types.
3662
3663 2019-02-08  Jim Wilson  <jimw@sifive.com>
3664
3665         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3666         (riscv_linux_fregset): New.
3667         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3668
3669 2019-02-07  Tom Tromey  <tom@tromey.com>
3670
3671         * thread.c (thread_cancel_execution_command): Update.
3672         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3673         methods.
3674         (struct thread_fsm_ops): Remove.
3675         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3676         (thread_fsm_should_stop, thread_fsm_return_value)
3677         (thread_fsm_set_finished, thread_fsm_finished_p)
3678         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3679         Don't declare.
3680         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3681         * infrun.c (clear_proceed_status_thread)
3682         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3683         (print_stop_event): Update.
3684         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3685         Add constructor.
3686         (step_command_fsm_ops): Remove.
3687         (new_step_command_fsm): Remove.
3688         (step_1): Update.
3689         (step_command_fsm::should_stop): Rename from
3690         step_command_fsm_should_stop.
3691         (step_command_fsm::clean_up): Rename from
3692         step_command_fsm_clean_up.
3693         (step_command_fsm::do_async_reply_reason): Rename from
3694         step_command_fsm_async_reply_reason.
3695         (struct until_next_fsm): Inherit from thread_fsm.  Add
3696         constructor.
3697         (until_next_fsm_ops): Remove.
3698         (new_until_next_fsm): Remove.
3699         (until_next_fsm::should_stop): Rename from
3700         until_next_fsm_should_stop.
3701         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3702         (until_next_fsm::do_async_reply_reason): Rename from
3703         until_next_fsm_async_reply_reason.
3704         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3705         constructor.  Change type of breakpoint.
3706         (finish_command_fsm_ops): Remove.
3707         (new_finish_command_fsm): Remove.
3708         (finish_command_fsm::should_stop): Rename from
3709         finish_command_fsm_should_stop.
3710         (finish_command_fsm::clean_up): Rename from
3711         finish_command_fsm_clean_up.
3712         (finish_command_fsm::return_value): Rename from
3713         finish_command_fsm_return_value.
3714         (finish_command_fsm::do_async_reply_reason): Rename from
3715         finish_command_fsm_async_reply_reason.
3716         (finish_command): Update.
3717         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3718         Add constructor.
3719         (call_thread_fsm_ops): Remove.
3720         (call_thread_fsm::call_thread_fsm): Rename from
3721         new_call_thread_fsm.
3722         (call_thread_fsm::should_stop): Rename from
3723         call_thread_fsm_should_stop.
3724         (call_thread_fsm::should_notify_stop): Rename from
3725         call_thread_fsm_should_notify_stop.
3726         (run_inferior_call, call_function_by_hand_dummy): Update.
3727         * cli/cli-interp.c (should_print_stop_to_console): Update.
3728         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3729         Add constructor.  Change type of location_breakpoint,
3730         caller_breakpoint.
3731         (until_break_fsm_ops): Remove.
3732         (new_until_break_fsm): Remove.
3733         (until_break_fsm::should_stop): Rename from
3734         until_break_fsm_should_stop.
3735         (until_break_fsm::clean_up): Rename from
3736         until_break_fsm_clean_up.
3737         (until_break_fsm::do_async_reply_reason): Rename from
3738         until_break_fsm_async_reply_reason.
3739         (until_break_command): Update.
3740         * thread-fsm.c: Remove.
3741         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3742
3743 2019-02-07  Tom Tromey  <tom@tromey.com>
3744
3745         * yy-remap.h: Add include guard.
3746         * xtensa-tdep.h: Add include guard.
3747         * xcoffread.h: Rename include guard.
3748         * varobj-iter.h: Add include guard.
3749         * tui/tui.h: Rename include guard.
3750         * tui/tui-winsource.h: Rename include guard.
3751         * tui/tui-wingeneral.h: Rename include guard.
3752         * tui/tui-windata.h: Rename include guard.
3753         * tui/tui-win.h: Rename include guard.
3754         * tui/tui-stack.h: Rename include guard.
3755         * tui/tui-source.h: Rename include guard.
3756         * tui/tui-regs.h: Rename include guard.
3757         * tui/tui-out.h: Rename include guard.
3758         * tui/tui-layout.h: Rename include guard.
3759         * tui/tui-io.h: Rename include guard.
3760         * tui/tui-hooks.h: Rename include guard.
3761         * tui/tui-file.h: Rename include guard.
3762         * tui/tui-disasm.h: Rename include guard.
3763         * tui/tui-data.h: Rename include guard.
3764         * tui/tui-command.h: Rename include guard.
3765         * tic6x-tdep.h: Add include guard.
3766         * target/waitstatus.h: Rename include guard.
3767         * target/wait.h: Rename include guard.
3768         * target/target.h: Rename include guard.
3769         * target/resume.h: Rename include guard.
3770         * target-float.h: Rename include guard.
3771         * stabsread.h: Add include guard.
3772         * rs6000-tdep.h: Add include guard.
3773         * riscv-fbsd-tdep.h: Add include guard.
3774         * regformats/regdef.h: Rename include guard.
3775         * record.h: Rename include guard.
3776         * python/python.h: Rename include guard.
3777         * python/python-internal.h: Rename include guard.
3778         * python/py-stopevent.h: Rename include guard.
3779         * python/py-ref.h: Rename include guard.
3780         * python/py-record.h: Rename include guard.
3781         * python/py-record-full.h: Rename include guard.
3782         * python/py-record-btrace.h: Rename include guard.
3783         * python/py-instruction.h: Rename include guard.
3784         * python/py-events.h: Rename include guard.
3785         * python/py-event.h: Rename include guard.
3786         * procfs.h: Add include guard.
3787         * proc-utils.h: Add include guard.
3788         * p-lang.h: Add include guard.
3789         * or1k-tdep.h: Rename include guard.
3790         * observable.h: Rename include guard.
3791         * nto-tdep.h: Rename include guard.
3792         * nat/x86-linux.h: Rename include guard.
3793         * nat/x86-linux-dregs.h: Rename include guard.
3794         * nat/x86-gcc-cpuid.h: Add include guard.
3795         * nat/x86-dregs.h: Rename include guard.
3796         * nat/x86-cpuid.h: Rename include guard.
3797         * nat/ppc-linux.h: Rename include guard.
3798         * nat/mips-linux-watch.h: Rename include guard.
3799         * nat/linux-waitpid.h: Rename include guard.
3800         * nat/linux-ptrace.h: Rename include guard.
3801         * nat/linux-procfs.h: Rename include guard.
3802         * nat/linux-osdata.h: Rename include guard.
3803         * nat/linux-nat.h: Rename include guard.
3804         * nat/linux-namespaces.h: Rename include guard.
3805         * nat/linux-btrace.h: Rename include guard.
3806         * nat/glibc_thread_db.h: Rename include guard.
3807         * nat/gdb_thread_db.h: Rename include guard.
3808         * nat/gdb_ptrace.h: Rename include guard.
3809         * nat/fork-inferior.h: Rename include guard.
3810         * nat/amd64-linux-siginfo.h: Rename include guard.
3811         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3812         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3813         * nat/aarch64-linux.h: Rename include guard.
3814         * nat/aarch64-linux-hw-point.h: Rename include guard.
3815         * mn10300-tdep.h: Add include guard.
3816         * mips-linux-tdep.h: Add include guard.
3817         * mi/mi-parse.h: Rename include guard.
3818         * mi/mi-out.h: Rename include guard.
3819         * mi/mi-main.h: Rename include guard.
3820         * mi/mi-interp.h: Rename include guard.
3821         * mi/mi-getopt.h: Rename include guard.
3822         * mi/mi-console.h: Rename include guard.
3823         * mi/mi-common.h: Rename include guard.
3824         * mi/mi-cmds.h: Rename include guard.
3825         * mi/mi-cmd-break.h: Rename include guard.
3826         * m2-lang.h: Add include guard.
3827         * location.h: Rename include guard.
3828         * linux-record.h: Rename include guard.
3829         * linux-nat.h: Add include guard.
3830         * linux-fork.h: Add include guard.
3831         * i386-darwin-tdep.h: Rename include guard.
3832         * hppa-linux-offsets.h: Add include guard.
3833         * guile/guile.h: Rename include guard.
3834         * guile/guile-internal.h: Rename include guard.
3835         * gnu-nat.h: Rename include guard.
3836         * gdb-stabs.h: Rename include guard.
3837         * frv-tdep.h: Add include guard.
3838         * f-lang.h: Add include guard.
3839         * event-loop.h: Add include guard.
3840         * darwin-nat.h: Rename include guard.
3841         * cp-abi.h: Rename include guard.
3842         * config/sparc/nm-sol2.h: Rename include guard.
3843         * config/nm-nto.h: Rename include guard.
3844         * config/nm-linux.h: Add include guard.
3845         * config/i386/nm-i386gnu.h: Rename include guard.
3846         * config/djgpp/nl_types.h: Rename include guard.
3847         * config/djgpp/langinfo.h: Rename include guard.
3848         * compile/gcc-cp-plugin.h: Add include guard.
3849         * compile/gcc-c-plugin.h: Add include guard.
3850         * compile/compile.h: Rename include guard.
3851         * compile/compile-object-run.h: Rename include guard.
3852         * compile/compile-object-load.h: Rename include guard.
3853         * compile/compile-internal.h: Rename include guard.
3854         * compile/compile-cplus.h: Rename include guard.
3855         * compile/compile-c.h: Rename include guard.
3856         * common/xml-utils.h: Rename include guard.
3857         * common/x86-xstate.h: Rename include guard.
3858         * common/version.h: Rename include guard.
3859         * common/vec.h: Rename include guard.
3860         * common/tdesc.h: Rename include guard.
3861         * common/selftest.h: Rename include guard.
3862         * common/scoped_restore.h: Rename include guard.
3863         * common/scoped_mmap.h: Rename include guard.
3864         * common/scoped_fd.h: Rename include guard.
3865         * common/safe-iterator.h: Rename include guard.
3866         * common/run-time-clock.h: Rename include guard.
3867         * common/refcounted-object.h: Rename include guard.
3868         * common/queue.h: Rename include guard.
3869         * common/ptid.h: Rename include guard.
3870         * common/print-utils.h: Rename include guard.
3871         * common/preprocessor.h: Rename include guard.
3872         * common/pathstuff.h: Rename include guard.
3873         * common/observable.h: Rename include guard.
3874         * common/netstuff.h: Rename include guard.
3875         * common/job-control.h: Rename include guard.
3876         * common/host-defs.h: Rename include guard.
3877         * common/gdb_wait.h: Rename include guard.
3878         * common/gdb_vecs.h: Rename include guard.
3879         * common/gdb_unlinker.h: Rename include guard.
3880         * common/gdb_unique_ptr.h: Rename include guard.
3881         * common/gdb_tilde_expand.h: Rename include guard.
3882         * common/gdb_sys_time.h: Rename include guard.
3883         * common/gdb_string_view.h: Rename include guard.
3884         * common/gdb_splay_tree.h: Rename include guard.
3885         * common/gdb_setjmp.h: Rename include guard.
3886         * common/gdb_ref_ptr.h: Rename include guard.
3887         * common/gdb_optional.h: Rename include guard.
3888         * common/gdb_locale.h: Rename include guard.
3889         * common/gdb_assert.h: Rename include guard.
3890         * common/filtered-iterator.h: Rename include guard.
3891         * common/filestuff.h: Rename include guard.
3892         * common/fileio.h: Rename include guard.
3893         * common/environ.h: Rename include guard.
3894         * common/common-utils.h: Rename include guard.
3895         * common/common-types.h: Rename include guard.
3896         * common/common-regcache.h: Rename include guard.
3897         * common/common-inferior.h: Rename include guard.
3898         * common/common-gdbthread.h: Rename include guard.
3899         * common/common-exceptions.h: Rename include guard.
3900         * common/common-defs.h: Rename include guard.
3901         * common/common-debug.h: Rename include guard.
3902         * common/cleanups.h: Rename include guard.
3903         * common/buffer.h: Rename include guard.
3904         * common/btrace-common.h: Rename include guard.
3905         * common/break-common.h: Rename include guard.
3906         * cli/cli-utils.h: Rename include guard.
3907         * cli/cli-style.h: Rename include guard.
3908         * cli/cli-setshow.h: Rename include guard.
3909         * cli/cli-script.h: Rename include guard.
3910         * cli/cli-interp.h: Rename include guard.
3911         * cli/cli-decode.h: Rename include guard.
3912         * cli/cli-cmds.h: Rename include guard.
3913         * charset-list.h: Add include guard.
3914         * buildsym-legacy.h: Rename include guard.
3915         * bfin-tdep.h: Add include guard.
3916         * ax.h: Rename include guard.
3917         * arm-linux-tdep.h: Add include guard.
3918         * arm-fbsd-tdep.h: Add include guard.
3919         * arch/xtensa.h: Rename include guard.
3920         * arch/tic6x.h: Add include guard.
3921         * arch/i386.h: Add include guard.
3922         * arch/arm.h: Rename include guard.
3923         * arch/arm-linux.h: Rename include guard.
3924         * arch/arm-get-next-pcs.h: Rename include guard.
3925         * arch/amd64.h: Add include guard.
3926         * arch/aarch64-insn.h: Rename include guard.
3927         * arch-utils.h: Rename include guard.
3928         * annotate.h: Add include guard.
3929         * amd64-darwin-tdep.h: Rename include guard.
3930         * aarch64-linux-tdep.h: Add include guard.
3931         * aarch64-fbsd-tdep.h: Add include guard.
3932         * aarch32-linux-nat.h: Add include guard.
3933
3934 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3935
3936         * macrotab.c (macro_define_internal): New function that
3937         factorizes macro_define_object_internal and macro_define_function
3938         code.
3939         (macro_define_object_internal): Use macro_define_internal.
3940         (macro_define_function): Likewise.
3941
3942 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3943
3944         * macrocmd.c (extract_identifier): Return
3945         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3946         callers.
3947
3948 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3949
3950         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3951
3952 2019-02-05  Tom Tromey  <tom@tromey.com>
3953
3954         * target.c (target_stack::unpush): Move assertion earlier.
3955
3956 2019-01-30  Tom Tromey  <tom@tromey.com>
3957
3958         PR python/23615:
3959         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3960         (gdbpy_parse_and_eval): Likewise.
3961         * python/python-internal.h (gdbpy_allow_threads): New class.
3962
3963 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3964
3965         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3966         (aarch64_fbsd_fpregmap): Move earlier.
3967         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3968         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3969         instead of individual calls to trad_frame_set_reg_addr.
3970         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3971         earlier.
3972         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3973         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3974         instead of individual calls to trad_frame_set_reg_addr.
3975
3976 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3977
3978         * CONTRIBUTE: Replace contribution list with wiki link.
3979
3980 2019-01-25  Tom Tromey  <tom@tromey.com>
3981
3982         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3983
3984 2019-01-25  Tom Tromey  <tom@tromey.com>
3985
3986         * xtensa-linux-nat.c: Fix common/ includes.
3987         * xml-support.h: Fix common/ includes.
3988         * xml-support.c: Fix common/ includes.
3989         * x86-linux-nat.c: Fix common/ includes.
3990         * windows-nat.c: Fix common/ includes.
3991         * varobj.h: Fix common/ includes.
3992         * varobj.c: Fix common/ includes.
3993         * value.c: Fix common/ includes.
3994         * valops.c: Fix common/ includes.
3995         * utils.c: Fix common/ includes.
3996         * unittests/xml-utils-selftests.c: Fix common/ includes.
3997         * unittests/utils-selftests.c: Fix common/ includes.
3998         * unittests/unpack-selftests.c: Fix common/ includes.
3999         * unittests/tracepoint-selftests.c: Fix common/ includes.
4000         * unittests/style-selftests.c: Fix common/ includes.
4001         * unittests/string_view-selftests.c: Fix common/ includes.
4002         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4003         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4004         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4005         * unittests/rsp-low-selftests.c: Fix common/ includes.
4006         * unittests/parse-connection-spec-selftests.c: Fix common/
4007         includes.
4008         * unittests/optional-selftests.c: Fix common/ includes.
4009         * unittests/offset-type-selftests.c: Fix common/ includes.
4010         * unittests/observable-selftests.c: Fix common/ includes.
4011         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4012         * unittests/memrange-selftests.c: Fix common/ includes.
4013         * unittests/memory-map-selftests.c: Fix common/ includes.
4014         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4015         * unittests/function-view-selftests.c: Fix common/ includes.
4016         * unittests/environ-selftests.c: Fix common/ includes.
4017         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4018         * unittests/common-utils-selftests.c: Fix common/ includes.
4019         * unittests/cli-utils-selftests.c: Fix common/ includes.
4020         * unittests/array-view-selftests.c: Fix common/ includes.
4021         * ui-file.c: Fix common/ includes.
4022         * tui/tui-io.c: Fix common/ includes.
4023         * tracepoint.h: Fix common/ includes.
4024         * tracepoint.c: Fix common/ includes.
4025         * tracefile-tfile.c: Fix common/ includes.
4026         * top.h: Fix common/ includes.
4027         * top.c: Fix common/ includes.
4028         * thread.c: Fix common/ includes.
4029         * target/waitstatus.h: Fix common/ includes.
4030         * target/waitstatus.c: Fix common/ includes.
4031         * target.h: Fix common/ includes.
4032         * target.c: Fix common/ includes.
4033         * target-memory.c: Fix common/ includes.
4034         * target-descriptions.c: Fix common/ includes.
4035         * symtab.h: Fix common/ includes.
4036         * symfile.c: Fix common/ includes.
4037         * stap-probe.c: Fix common/ includes.
4038         * spu-linux-nat.c: Fix common/ includes.
4039         * sparc-nat.c: Fix common/ includes.
4040         * source.c: Fix common/ includes.
4041         * solib.c: Fix common/ includes.
4042         * solib-target.c: Fix common/ includes.
4043         * ser-unix.c: Fix common/ includes.
4044         * ser-tcp.c: Fix common/ includes.
4045         * ser-pipe.c: Fix common/ includes.
4046         * ser-base.c: Fix common/ includes.
4047         * selftest-arch.c: Fix common/ includes.
4048         * s12z-tdep.c: Fix common/ includes.
4049         * rust-exp.y: Fix common/ includes.
4050         * rs6000-aix-tdep.c: Fix common/ includes.
4051         * riscv-tdep.c: Fix common/ includes.
4052         * remote.c: Fix common/ includes.
4053         * remote-notif.h: Fix common/ includes.
4054         * remote-fileio.h: Fix common/ includes.
4055         * remote-fileio.c: Fix common/ includes.
4056         * regcache.h: Fix common/ includes.
4057         * regcache.c: Fix common/ includes.
4058         * record-btrace.c: Fix common/ includes.
4059         * python/python.c: Fix common/ includes.
4060         * python/py-type.c: Fix common/ includes.
4061         * python/py-inferior.c: Fix common/ includes.
4062         * progspace.h: Fix common/ includes.
4063         * producer.c: Fix common/ includes.
4064         * procfs.c: Fix common/ includes.
4065         * proc-api.c: Fix common/ includes.
4066         * printcmd.c: Fix common/ includes.
4067         * ppc-linux-nat.c: Fix common/ includes.
4068         * parser-defs.h: Fix common/ includes.
4069         * osdata.c: Fix common/ includes.
4070         * obsd-nat.c: Fix common/ includes.
4071         * nat/x86-linux.c: Fix common/ includes.
4072         * nat/x86-linux-dregs.c: Fix common/ includes.
4073         * nat/x86-dregs.h: Fix common/ includes.
4074         * nat/x86-dregs.c: Fix common/ includes.
4075         * nat/ppc-linux.c: Fix common/ includes.
4076         * nat/mips-linux-watch.h: Fix common/ includes.
4077         * nat/mips-linux-watch.c: Fix common/ includes.
4078         * nat/linux-waitpid.c: Fix common/ includes.
4079         * nat/linux-ptrace.h: Fix common/ includes.
4080         * nat/linux-ptrace.c: Fix common/ includes.
4081         * nat/linux-procfs.c: Fix common/ includes.
4082         * nat/linux-personality.c: Fix common/ includes.
4083         * nat/linux-osdata.c: Fix common/ includes.
4084         * nat/linux-namespaces.c: Fix common/ includes.
4085         * nat/linux-btrace.h: Fix common/ includes.
4086         * nat/linux-btrace.c: Fix common/ includes.
4087         * nat/fork-inferior.c: Fix common/ includes.
4088         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4089         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4090         * nat/aarch64-linux.c: Fix common/ includes.
4091         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4092         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4093         * namespace.h: Fix common/ includes.
4094         * mips-linux-tdep.c: Fix common/ includes.
4095         * minsyms.c: Fix common/ includes.
4096         * mi/mi-parse.h: Fix common/ includes.
4097         * mi/mi-main.c: Fix common/ includes.
4098         * mi/mi-cmd-env.c: Fix common/ includes.
4099         * memrange.h: Fix common/ includes.
4100         * memattr.c: Fix common/ includes.
4101         * maint.h: Fix common/ includes.
4102         * maint.c: Fix common/ includes.
4103         * main.c: Fix common/ includes.
4104         * machoread.c: Fix common/ includes.
4105         * location.c: Fix common/ includes.
4106         * linux-thread-db.c: Fix common/ includes.
4107         * linux-nat.c: Fix common/ includes.
4108         * linux-fork.c: Fix common/ includes.
4109         * inline-frame.c: Fix common/ includes.
4110         * infrun.c: Fix common/ includes.
4111         * inflow.c: Fix common/ includes.
4112         * inferior.h: Fix common/ includes.
4113         * inferior.c: Fix common/ includes.
4114         * infcmd.c: Fix common/ includes.
4115         * inf-ptrace.c: Fix common/ includes.
4116         * inf-child.c: Fix common/ includes.
4117         * ia64-linux-nat.c: Fix common/ includes.
4118         * i387-tdep.c: Fix common/ includes.
4119         * i386-tdep.c: Fix common/ includes.
4120         * i386-linux-tdep.c: Fix common/ includes.
4121         * i386-linux-nat.c: Fix common/ includes.
4122         * i386-go32-tdep.c: Fix common/ includes.
4123         * i386-fbsd-tdep.c: Fix common/ includes.
4124         * i386-fbsd-nat.c: Fix common/ includes.
4125         * guile/scm-type.c: Fix common/ includes.
4126         * guile/guile.c: Fix common/ includes.
4127         * go32-nat.c: Fix common/ includes.
4128         * gnu-nat.c: Fix common/ includes.
4129         * gdbthread.h: Fix common/ includes.
4130         * gdbarch-selftests.c: Fix common/ includes.
4131         * gdb_usleep.c: Fix common/ includes.
4132         * gdb_select.h: Fix common/ includes.
4133         * gdb_bfd.c: Fix common/ includes.
4134         * gcore.c: Fix common/ includes.
4135         * fork-child.c: Fix common/ includes.
4136         * findvar.c: Fix common/ includes.
4137         * fbsd-nat.c: Fix common/ includes.
4138         * event-top.c: Fix common/ includes.
4139         * event-loop.c: Fix common/ includes.
4140         * dwarf2read.c: Fix common/ includes.
4141         * dwarf2loc.c: Fix common/ includes.
4142         * dwarf2-frame.c: Fix common/ includes.
4143         * dwarf-index-cache.c: Fix common/ includes.
4144         * dtrace-probe.c: Fix common/ includes.
4145         * disasm-selftests.c: Fix common/ includes.
4146         * defs.h: Fix common/ includes.
4147         * csky-tdep.c: Fix common/ includes.
4148         * cp-valprint.c: Fix common/ includes.
4149         * cp-support.h: Fix common/ includes.
4150         * cp-support.c: Fix common/ includes.
4151         * corelow.c: Fix common/ includes.
4152         * completer.h: Fix common/ includes.
4153         * completer.c: Fix common/ includes.
4154         * compile/compile.c: Fix common/ includes.
4155         * compile/compile-loc2c.c: Fix common/ includes.
4156         * compile/compile-cplus-types.c: Fix common/ includes.
4157         * compile/compile-cplus-symbols.c: Fix common/ includes.
4158         * command.h: Fix common/ includes.
4159         * cli/cli-dump.c: Fix common/ includes.
4160         * cli/cli-cmds.c: Fix common/ includes.
4161         * charset.c: Fix common/ includes.
4162         * build-id.c: Fix common/ includes.
4163         * btrace.h: Fix common/ includes.
4164         * btrace.c: Fix common/ includes.
4165         * breakpoint.h: Fix common/ includes.
4166         * breakpoint.c: Fix common/ includes.
4167         * ax.h: 
4168         (enum agent_op): Fix common/ includes.
4169         * ax-general.c (struct aop_map): Fix common/ includes.
4170         * ax-gdb.c: Fix common/ includes.
4171         * auxv.c: Fix common/ includes.
4172         * auto-load.c: Fix common/ includes.
4173         * arm-tdep.c: Fix common/ includes.
4174         * arch/riscv.c: Fix common/ includes.
4175         * arch/ppc-linux-common.c: Fix common/ includes.
4176         * arch/i386.c: Fix common/ includes.
4177         * arch/arm.c: Fix common/ includes.
4178         * arch/arm-linux.c: Fix common/ includes.
4179         * arch/arm-get-next-pcs.c: Fix common/ includes.
4180         * arch/amd64.c: Fix common/ includes.
4181         * arch/aarch64.c: Fix common/ includes.
4182         * arch/aarch64-insn.c: Fix common/ includes.
4183         * arch-utils.c: Fix common/ includes.
4184         * amd64-windows-tdep.c: Fix common/ includes.
4185         * amd64-tdep.c: Fix common/ includes.
4186         * amd64-sol2-tdep.c: Fix common/ includes.
4187         * amd64-obsd-tdep.c: Fix common/ includes.
4188         * amd64-nbsd-tdep.c: Fix common/ includes.
4189         * amd64-linux-tdep.c: Fix common/ includes.
4190         * amd64-linux-nat.c: Fix common/ includes.
4191         * amd64-fbsd-tdep.c: Fix common/ includes.
4192         * amd64-fbsd-nat.c: Fix common/ includes.
4193         * amd64-dicos-tdep.c: Fix common/ includes.
4194         * amd64-darwin-tdep.c: Fix common/ includes.
4195         * agent.c: Fix common/ includes.
4196         * ada-lang.h: Fix common/ includes.
4197         * ada-lang.c: Fix common/ includes.
4198         * aarch64-tdep.c: Fix common/ includes.
4199
4200 2019-01-25  Tom Tromey  <tom@tromey.com>
4201
4202         * common/create-version.sh: Use common/version.h.
4203
4204 2019-01-24  Pedro Alves  <palves@redhat.com>
4205
4206         * infrun.c (signal_stop, signal_print, signal_program)
4207         (signal_catch, signal_pass): Now arrays instead of pointers.
4208         (update_signals_program_target, do_target_resume)
4209         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4210         * linux-nat.c (linux_nat_target::pass_signals)
4211         (linux_nat_target::create_inferior, linux_nat_target::attach):
4212         Adjust.
4213         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4214         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4215         * procfs.c (procfs_target::pass_signals): Adjust.
4216         * record-full.c (record_full_target::resume): Adjust.
4217         * remote.c (remote_target::pass_signals)
4218         (remote_target::program_signals): Adjust.
4219         * target-debug.h (target_debug_print_signals): Now takes a
4220         gdb::array_view as parameter.  Adjust.
4221         * target.h (target_ops) <pass_signals, program_signals>: Replace
4222         pointer and length parameters with gdb::array_view.
4223         (target_pass_signals, target_program_signals): Likewise.
4224         * target-delegates.c: Regenerate.
4225
4226 2019-01-24  Pedro Alves  <palves@redhat.com>
4227
4228         * common/forward-scope-exit.h
4229         (forward_scope_exit::forward_scope_exit): Pass arguments to
4230         m_bind_function directly, instead of creating a std::bind and
4231         copying that.
4232
4233 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4234
4235         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4236         for static members.
4237         (pass_in_v_vfp_candidate): Likewise.
4238
4239 2019-01-23  Tom Tromey  <tom@tromey.com>
4240             Pedro Alves  <palves@redhat.com>
4241
4242         * regcache.c (class regcache_invalidator): Remove.
4243         (regcache::raw_write): Use make_scope_exit.
4244
4245 2019-01-23  Tom Tromey  <tom@tromey.com>
4246
4247         * ui-out.h (class ui_out_emit_type): Update comment.
4248
4249 2019-01-23  Tom Tromey  <tom@tromey.com>
4250
4251         * infrun.c (fetch_inferior_event): Update comment.
4252
4253 2019-01-23  Tom Tromey  <tom@tromey.com>
4254             Pedro Alves  <palves@redhat.com>
4255
4256         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4257         parameter.
4258         (fetch_inferior_event): Use SCOPE_EXIT.
4259
4260
4261 2019-01-23  Tom Tromey  <tom@tromey.com>
4262             Pedro Alves  <palves@redhat.com>
4263
4264         * infrun.c (disable_thread_events): Delete.
4265         (stop_all_threads): Use SCOPE_EXIT.
4266
4267 2019-01-23  Tom Tromey  <tom@tromey.com>
4268             Pedro Alves  <palves@redhat.com>
4269
4270         * symfile.c: Include forward-scope-exit.h.
4271         (clear_symtab_users_cleanup): Replace forward declaration with
4272         a FORWARD_SCOPE_EXIT.
4273         (syms_from_objfile_1): Use the forward_scope_exit and
4274         gdb::optional instead of cleanup_function.
4275         (reread_symbols): Use the forward_scope_exit instead of
4276         cleanup_function.
4277         (clear_symtab_users_cleanup): Remove function.
4278
4279 2019-01-23  Tom Tromey  <tom@tromey.com>
4280             Pedro Alves  <palves@redhat.com>
4281
4282         * linux-nat.c: Include scope-exit.h.
4283         (cleanup_target_stop): Remove.
4284         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4285         SCOPE_EXIT.
4286
4287 2019-01-23  Tom Tromey  <tom@tromey.com>
4288             Pedro Alves  <palves@redhat.com>
4289
4290         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4291         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4292
4293 2019-01-23  Tom Tromey  <tom@tromey.com>
4294             Andrew Burgess  <andrew.burgess@embecosm.com>
4295             Pedro Alves  <palves@redhat.com>
4296
4297         * infrun.c (fetch_inferior_event): Use scope_exit.
4298         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4299         * top.c (execute_command): Use scope_exit.
4300         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4301         * utils.c (do_bpstat_clear_actions_cleanup)
4302         (make_bpstat_clear_actions_cleanup): Remove.
4303
4304 2019-01-23  Tom Tromey  <tom@tromey.com>
4305             Pedro Alves  <palves@redhat.com>
4306
4307         * infrun.c: Include "common/scope-exit.h"
4308         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4309         (wait_for_inferior): Use SCOPE_EXIT.
4310         (fetch_inferior_event): Use scope_exit.
4311
4312 2019-01-23  Tom Tromey  <tom@tromey.com>
4313             Pedro Alves  <palves@redhat.com>
4314
4315         * breakpoint.c (create_breakpoint): Remove cleanup.
4316
4317 2019-01-23  Tom Tromey  <tom@tromey.com>
4318             Andrew Burgess  <andrew.burgess@embecosm.com>
4319             Pedro Alves  <palves@redhat.com>
4320
4321 2019-01-23  Pedro Alves  <palves@redhat.com>
4322
4323         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4324
4325 2019-01-23  Pedro Alves  <palves@redhat.com>
4326             Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * gdbthread.h: Include "common/forward-scope-exit.h".
4329         (scoped_finish_thread_state): Redefine custom class in terms of
4330         forward_scope_exit.
4331
4332 2019-01-23  Pedro Alves  <palves@redhat.com>
4333             Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * common/forward-scope-exit.h: New file.
4336
4337 2019-01-23  Pedro Alves  <palves@redhat.com>
4338             Andrew Burgess  <andrew.burgess@embecosm.com>
4339             Tom Tromey  <tom@tromey.com>
4340
4341         * common/scope-exit.h: New file.
4342
4343 2019-01-23  Pedro Alves  <palves@redhat.com>
4344
4345         * common/preprocessor.h (ESC): Rename to ...
4346         (ESC_PARENS): ... this.
4347         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4348         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4349
4350 2019-01-23  Tom Tromey  <tom@tromey.com>
4351
4352         * language.h (class scoped_switch_to_sym_language_if_auto):
4353         Initialize m_lang in both cases.
4354
4355 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4358         with XCNEW.
4359
4360 2019-01-22  Tom Tromey  <tom@tromey.com>
4361
4362         * corelow.c: Do not include sys/file.h.
4363
4364 2019-01-22  Tom Tromey  <tom@tromey.com>
4365
4366         * tui/tui-wingeneral.h: Include gdb_curses.h.
4367
4368 2019-01-22  Tom Tromey  <tom@tromey.com>
4369
4370         * source-cache.h (class source_cache) <get_source_lines,
4371         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4372
4373 2019-01-22  Tom Tromey  <tom@tromey.com>
4374
4375         * remote-fileio.h (struct remote_target): Declare.
4376
4377 2019-01-22  Tom Tromey  <tom@tromey.com>
4378
4379         * python/py-arch.c: Do not include py-ref.h.
4380         * python/py-bpevent.c: Do not include py-ref.h.
4381         * python/py-cmd.c: Do not include py-ref.h.
4382         * python/py-continueevent.c: Do not include py-ref.h.
4383         * python/py-event.h: Do not include py-ref.h.
4384         * python/py-evtregistry.c: Do not include py-ref.h.
4385         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4386         * python/py-frame.c: Do not include py-ref.h.
4387         * python/py-framefilter.c: Do not include py-ref.h.
4388         * python/py-function.c: Do not include py-ref.h.
4389         * python/py-infevents.c: Do not include py-ref.h.
4390         * python/py-linetable.c: Do not include py-ref.h.
4391         * python/py-objfile.c: Do not include py-ref.h.
4392         * python/py-param.c: Do not include py-ref.h.
4393         * python/py-prettyprint.c: Do not include py-ref.h.
4394         * python/py-progspace.c: Do not include py-ref.h.
4395         * python/py-symbol.c: Do not include py-ref.h.
4396         * python/py-symtab.c: Do not include py-ref.h.
4397         * python/py-type.c: Do not include py-ref.h.
4398         * python/py-unwind.c: Do not include py-ref.h.
4399         * python/py-utils.c: Do not include py-ref.h.
4400         * python/py-value.c: Do not include py-ref.h.
4401         * python/py-varobj.c: Do not include py-ref.h.
4402         * python/py-xmethods.c: Do not include py-ref.h.
4403         * python/python.c: Do not include py-ref.h.
4404         * varobj.c: Do not include py-ref.h.
4405
4406 2019-01-22  Tom Tromey  <tom@tromey.com>
4407
4408         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4409         keyword for bcache.
4410
4411 2019-01-22  Tom Tromey  <tom@tromey.com>
4412
4413         * compile/compile-cplus-types.c: Remove a comment by #include.
4414
4415 2019-01-22  Tom Tromey  <tom@tromey.com>
4416
4417         * compile/gcc-c-plugin.h: Include compile-internal.h.
4418
4419 2019-01-22  Tom Tromey  <tom@tromey.com>
4420
4421         * stabsread.c (EXTERN): Do not define.
4422         (symnum, next_symbol_text_func, processing_gcc_compilation)
4423         (within_function, global_sym_chain, global_stabs)
4424         (previous_stab_code, this_object_header_files)
4425         (n_this_object_header_files)
4426         (n_allocated_this_object_header_files): Define.
4427         * stabsread.h (EXTERN): Never define.  Use "extern".
4428
4429 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4430
4431         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4432         history_value.
4433
4434 2019-01-21  Tom Tromey  <tom@tromey.com>
4435
4436         * ui-out.c: Fix includes.
4437         * tui/tui-source.c: Fix includes.
4438         * target.c: Fix includes.
4439         * remote.c: Fix includes.
4440         * regcache.c: Fix includes.
4441         * python/py-block.c: Fix includes.
4442         * printcmd.c: Fix includes.
4443         * or1k-tdep.c: Fix includes.
4444         * mi/mi-main.c: Fix includes.
4445         * m32r-tdep.c: Fix includes.
4446         * csky-tdep.c: Fix includes.
4447         * compile/compile-cplus-types.c: Fix includes.
4448         * cli/cli-interp.c: Fix includes.
4449
4450 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4451
4452         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4453         for padding.
4454
4455 2019-01-16  Tom Tromey  <tom@tromey.com>
4456
4457         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4458         earlier.
4459         (struct objfile) <msymbols_range>: Move from top level.
4460         <msymbols>: New method.
4461         (class objfile_msymbols): Remove.
4462         * symtab.c (default_collect_symbol_completion_matches_break_on):
4463         Update.
4464         * symmisc.c (dump_msymbols): Update.
4465         * stabsread.c (scan_file_globals): Update.
4466         * objc-lang.c (info_selectors_command, info_classes_command)
4467         (find_methods): Update.
4468         * minsyms.c (find_solib_trampoline_target): Update.
4469         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4470         * coffread.c (coff_symfile_read): Update.
4471         * ada-lang.c (ada_lookup_simple_minsym)
4472         (ada_collect_symbol_completion_matches): Update.
4473
4474 2019-01-16  Tom Tromey  <tom@tromey.com>
4475
4476         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4477         type.  Remove no-argument constructor.
4478         <iterator::operator++>: Simplify.
4479         <begin>: Update.
4480         <end>: Use minimal_symbol_count.
4481
4482 2019-01-16  Tom Tromey  <tom@tromey.com>
4483
4484         * objfiles.h (struct objfile) <psymtabs>: New method.
4485         (class objfile_psymtabs): Remove.
4486         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4487         typedef.
4488         <range>: New method.
4489         (require_partial_symbols): Change return type.
4490         * psymtab.c (require_partial_symbols)
4491         (psym_expand_symtabs_matching): Update.
4492         * mdebugread.c (parse_partial_symbols): Update.
4493         * dbxread.c (dbx_end_psymtab): Update.
4494
4495 2019-01-15  Tom Tromey  <tom@tromey.com>
4496
4497         * symtab.c (lookup_objfile_from_block)
4498         (lookup_symbol_in_objfile_symtabs)
4499         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4500         (find_line_symtab, info_sources_command)
4501         (default_collect_symbol_completion_matches_break_on)
4502         (make_source_files_completion_list): Update.
4503         * symmisc.c (print_objfile_statistics, dump_objfile)
4504         (maintenance_print_symbols, maintenance_info_symtabs)
4505         (maintenance_check_symtabs, maintenance_info_line_tables):
4506         Update.
4507         * source.c (select_source_symtab)
4508         (forget_cached_source_info_for_objfile): Update.
4509         * objfiles.h (class objfile_compunits): Remove.
4510         (struct objfile) <compunits_range>: New typedef.
4511         (compunits): New method.
4512         * objfiles.c (objfile_relocate1): Update.
4513         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4514         * maint.c (count_symtabs_and_blocks): Update.
4515         * linespec.c (iterate_over_all_matching_symtabs): Update.
4516         * cp-support.c (add_symbol_overload_list_qualified): Update.
4517         * coffread.c (coff_symtab_read): Update.
4518         * ada-lang.c (add_nonlocal_symbols)
4519         (ada_collect_symbol_completion_matches)
4520         (ada_add_global_exceptions): Update.
4521
4522 2019-01-15  Tom Tromey  <tom@tromey.com>
4523
4524         * progspace.h (program_space) <objfiles_safe_range>: New
4525         typedef.
4526         <objfiles_safe>: New method.
4527         * objfiles.h (class all_objfiles_safe): Remove.
4528         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4529         * jit.c (jit_inferior_exit_hook): Update.
4530
4531 2019-01-17  Tom Tromey  <tom@tromey.com>
4532
4533         * progspace.h (program_space) <objfiles_range>: New typedef.
4534         <objfiles>: New method.
4535         <objfiles_head>: Rename from objfiles.
4536         (object_files): Update.
4537         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4538         * guile/scm-pretty-print.c
4539         (ppscm_find_pretty_printer_from_objfiles): Update.
4540         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4541         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4542         Update.
4543         * python/py-progspace.c (pspy_get_objfiles): Update.
4544         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4545         Update.
4546         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4547         (objfpy_lookup_objfile_by_build_id): Update.
4548         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4549         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4550         Update.
4551         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4552         (expand_symtab_containing_pc, lookup_objfile_from_block)
4553         (lookup_static_symbol, basic_lookup_transparent_type)
4554         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4555         (find_line_symtab, info_sources_command)
4556         (default_collect_symbol_completion_matches_break_on)
4557         (make_source_files_completion_list, find_main_name): Update.
4558         * symmisc.c (print_symbol_bcache_statistics)
4559         (print_objfile_statistics, maintenance_print_symbols)
4560         (maintenance_print_msymbols, maintenance_print_objfiles)
4561         (maintenance_info_symtabs, maintenance_check_symtabs)
4562         (maintenance_expand_symtabs, maintenance_info_line_tables):
4563         Update.
4564         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4565         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4566         (map_overlay_command, unmap_overlay_command)
4567         (simple_overlay_update, expand_symtabs_matching)
4568         (map_symbol_filenames): Update.
4569         * symfile-debug.c (set_debug_symfile): Update.
4570         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4571         Update.
4572         * source.c (select_source_symtab, forget_cached_source_info):
4573         Update.
4574         * solib.c (solib_read_symbols): Update.
4575         * solib-spu.c (append_ocl_sos): Update.
4576         * psymtab.c (maintenance_print_psymbols)
4577         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4578         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4579         * printcmd.c (info_symbol_command): Update.
4580         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4581         Update.
4582         * objfiles.h (class all_objfiles): Remove.
4583         * objfiles.c (have_partial_symbols, have_full_symbols)
4584         (have_minimal_symbols, qsort_cmp, update_section_map)
4585         (shared_objfile_contains_address_p)
4586         (default_iterate_over_objfiles_in_search_order): Update.
4587         * objc-lang.c (info_selectors_command, info_classes_command)
4588         (find_methods): Update.
4589         * minsyms.c (find_solib_trampoline_target): Update.
4590         * maint.c (maintenance_info_sections)
4591         (maintenance_translate_address, count_symtabs_and_blocks):
4592         Update.
4593         * main.c (captured_main_1): Update.
4594         * linux-thread-db.c (try_thread_db_load_from_pdir)
4595         (has_libpthread): Update.
4596         * linespec.c (iterate_over_all_matching_symtabs)
4597         (search_minsyms_for_name): Update.
4598         * jit.c (jit_find_objf_with_entry_addr): Update.
4599         * hppa-tdep.c (find_unwind_entry)
4600         (hppa_lookup_stub_minimal_symbol): Update.
4601         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4602         Update.
4603         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4604         (elf_gnu_ifunc_resolve_by_got): Update.
4605         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4606         * dwarf-index-write.c (save_gdb_index_command): Update.
4607         * cp-support.c (add_symbol_overload_list_qualified): Update.
4608         * breakpoint.c (create_overlay_event_breakpoint)
4609         (create_longjmp_master_breakpoint)
4610         (create_std_terminate_master_breakpoint)
4611         (create_exception_master_breakpoint): Update.
4612         * blockframe.c (find_pc_partial_function): Update.
4613         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4614         (ada_collect_symbol_completion_matches)
4615         (ada_add_global_exceptions): Update.
4616
4617 2019-01-17  Tom Tromey  <tom@tromey.com>
4618
4619         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4620         declare VEC.
4621         (solib_target_parse_libraries): Change return type.
4622         (library_list_start_segment, library_list_start_section)
4623         (library_list_end_library, library_list_start_library); Update.
4624         (solib_target_free_library_list): Remove.
4625         (solib_target_parse_libraries): Remove cleanup.  Change return
4626         type.
4627         (solib_target_current_sos): Update.
4628
4629 2019-01-17  Tom Tromey  <tromey@bapiya>
4630
4631         * valprint.c: Replace "the the" with "the".
4632         * symtab.c: Replace "the the" with "the".
4633         * solib.c: Replace "the the" with "the".
4634         * solib-dsbt.c: Replace "the the" with "the".
4635         * linespec.c: Replace "the the" with "the".
4636         * dwarf2loc.h: Replace "the the" with "the".
4637         * amd64-windows-tdep.c: Replace "the the" with "the".
4638         * aarch64-tdep.c: Replace "the the" with "the".
4639
4640 2019-01-16  Keith Seitz  <keiths@redhat.com>
4641
4642         PR gdb/23773
4643         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4644         <builder>: Rename to ..
4645         <m_builder>: ... this and make private.
4646         (dwarf2_cu::get_builder): New method.  Change all users of
4647         `builder' to use this method.
4648         (dwarf2_start_symtab): Move to ...
4649         (dwarf2_cu::start_symtab): ... here.  Update all callers
4650         (setup_type_unit_groups): Move to ...
4651         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4652         callers.
4653         (dwarf2_cu::reset_builder): New method.
4654         (process_full_compunit, process_full_type_unit): Use
4655         dwarf2_cu::reset_builder.
4656         (follow_die_offset): Record the ancestor CU if it is different
4657         from the followed DIE's CU.
4658         (follow_die_sig_1): Likewise.
4659
4660 2019-01-15  Tom Tromey  <tom@tromey.com>
4661
4662         * remote.c (class remote_state) <buf>: Now a char_vector.
4663         <buf_size>: Remove.
4664         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4665         parameter.
4666         (remote_target::getpkt_or_notif_sane_1)
4667         (remote_target::getpkt_sane)
4668         (remote_target::getpkt_or_notif_sane): Likewise.
4669         (class remote_target) <putpkt>: New overload.
4670         (remote_target::read_frame): Change type of "buf_p".  Remove
4671         sizeof_p parameter.
4672         (packet_ok): New overload.
4673         (packet_check_result): New overload.
4674         Update all uses.
4675
4676 2019-01-14  Tom Tromey  <tom@tromey.com>
4677
4678         * remote-notif.c (handle_notification, remote_notif_ack)
4679         (remote_notif_parse): Make "buf" const.
4680         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4681         const.
4682         (remote_notif_parse, remote_notif_ack, handle_notification):
4683         Likewise.
4684         * remote.c (remote_notif_stop_parse): Make "buf" const.
4685         (remote_target::remote_parse_stop_reply): Make "buf" const.
4686         (remote_notif_stop_ack): Make "buf" const.
4687
4688 2019-01-14  Tom Tromey  <tom@tromey.com>
4689
4690         * remote.c (remote_console_output): Make parameter const.
4691
4692 2019-01-14  Tom Tromey  <tom@tromey.com>
4693
4694         * target-debug.h (target_debug_print_signals): Constify.
4695         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4696         * procfs.c (procfs_target::pass_signals): Update.
4697         * linux-nat.c (linux_nat_target::pass_signals): Update.
4698         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4699         * target-delegates.c: Rebuild.
4700         * remote.c (remote_target::program_signals): Update.
4701         (remote_target::pass_signals): Update.
4702         * target.c (target_pass_signals): Constify argument.
4703         (target_program_signals): Likewise.
4704         * target.h (struct target_ops) <pass_signals, program_signals>:
4705         Constify argument.
4706         (target_pass_signals, target_program_signals): Constify argument.
4707
4708 2019-01-14  Tom Tromey  <tom@tromey.com>
4709
4710         PR tui/28819:
4711         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4712
4713 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4714
4715         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4716         field.
4717         * rs6000-tdep.c: Include reggroups.h.
4718         (IS_V_ALIAS_PSEUDOREG): Define.
4719         (rs6000_register_name): Return names for the "vX" aliases.
4720         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4721         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4722         aliases.  Call default_register_reggroup_p for all other
4723         pseudo-registers.
4724         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4725         New functions.
4726         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4727         Handle "vX" aliases.
4728         (v_alias_pseudo_register_collect): New function.
4729         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4730         (rs6000_gdbarch_init): Initialize "vX" aliases as
4731         pseudo-registers.  Restore registration of
4732         rs6000_pseudo_register_reggroup_p with
4733         set_tdesc_pseudo_register_reggroup_p.
4734
4735 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4736
4737         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4738         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4739         set_gdbarch_num_pseudo_regs.
4740
4741 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4742
4743         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4744         Remove arg prefixname, add do_set and do_show.
4745         Add member functions set_list and show_list.
4746         * cli/cli-style.c (class cli_style_option): Update accordingly.
4747         (style_set_list): Move to file scope.
4748         (style_show_list): Likewise.
4749         (set_style): Call help_list.
4750         (show_style): Call cmd_show_list.
4751         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4752         Update to use the new macro.
4753
4754 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4755
4756         * ada-lang.c (_initialize_ada_language): Expand the help text
4757         for the "catch exception" command.
4758
4759 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4760
4761         * symtab.c (matching_obj_sections): Initialize obj,
4762         declare it closer to its usage.
4763
4764 2019-01-10  Tom Tromey  <tom@tromey.com>
4765
4766         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4767         (basic_inf_threads_range): Remove.
4768         (inf_threads_range, inf_non_exited_threads_range)
4769         (safe_inf_threads_range): Use next_adapter.
4770
4771 2019-01-10  Keith Seitz  <keiths@redhat.com>
4772
4773         PR gdb/23712
4774         PR symtab/23010
4775         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4776         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4777
4778 2019-01-10  Keith Seitz  <keiths@redhat.com>
4779
4780         PR gdb/23712
4781         PR symtab/23010
4782         * dictionary.c (pending_to_vector): Remove.
4783         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4784         Remove _1 suffix, replacing functions of the same name.  Update
4785         all callers.
4786         (dict_create_hashed, dict_create_hashed_expandable)
4787         (dict_create_linear, dict_create_linear_expandable, dict_free)
4788         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4789         Make functions static.
4790
4791 2019-01-10  Keith Seitz  <keiths@redhat.com>
4792
4793         PR gdb/23712
4794         PR symtab/23010
4795         * dictionary.h (struct dictionary): Replace declaration with
4796         multidictionary.
4797         (dict_create_hashed, dict_create_hashed_expandable)
4798         (dict_create_linear, dict_create_linear_expandable)
4799         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4800         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4801         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4802         taking multidictionary argument.
4803         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4804         * block.h (struct block) <dict>: Change to multidictionary
4805         and rename `multidict'.
4806         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4807         symmisc.c: Update all dictionary references to multidictionary.
4808
4809 2019-01-10  Keith Seitz  <keiths@redhat.com>
4810
4811         PR gdb/23712
4812         PR symtab/23010
4813         * dictionary.c: Include unordered_map.
4814         (pending_to_vector): New function.
4815         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4816         Rewrite the non-"_1" functions to take vector instead
4817         of linked list.
4818         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4819         "new" _1 versions of the same name.
4820         (multidictionary): Define.
4821         (std::hash<enum language): New definition.
4822         (collate_pending_symbols_by_language, mdict_create_hashed)
4823         (mdict_create_hashed_expandable, mdict_create_linear)
4824         (mdict_create_linear_expandable, mdict_free)
4825         (find_language_dictionary, create_new_language_dictionary)
4826         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4827         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4828         (mdict_size, mdict_empty): New functions.
4829         * dictionary.h (mdict_iterator): Define.
4830
4831 2019-01-10  Pedro Alves  <palves@redhat.com>
4832
4833         * breakpoint.c (read_uploaded_action)
4834         (create_tracepoint_from_upload): Adjust to use
4835         gdb::unique_xmalloc_ptr.
4836         * ctf.c (ctf_write_uploaded_tp):
4837         (SET_ARRAY_FIELD): Use emplace_back.
4838         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4839         * tracefile-tfile.c (tfile_write_uploaded_tp):
4840         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4841         gdb::unique_xmalloc_ptr.
4842         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4843         at_string, cond_string, cmd_strings>: Replace char pointers
4844         with gdb::unique_xmalloc_ptr.
4845
4846 2019-01-10  Pedro Alves  <palves@redhat.com>
4847
4848         * solib-target.c (library_list_start_library): Don't xstrdup name.
4849
4850 2019-01-10  Pedro Alves  <palves@redhat.com>
4851
4852         * mdebugread.c (parse_partial_symbols): Use
4853         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4854
4855 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         * linux-fork.c (scoped_switch_fork_info)
4858         <~scoped_switch_fork_info>: Fix incorrect variable name.
4859
4860 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * linux-fork.c (scoped_switch_fork_info)
4863         <scoped_switch_fork_info>: Make explicit.
4864         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4865
4866 2019-01-10  Tom Tromey  <tom@tromey.com>
4867
4868         * objfiles.h (objfile::reset_psymtabs): Update.
4869         * objfiles.c (objfile::objfile): Update.
4870         * psymtab.h (psymtab_storage::obstack): Update.
4871         (psymtab_storage::m_obstack): Use gdb::optional.
4872         (class psymtab_storage): Update comment.  Remove objfile
4873         parameter.
4874         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4875
4876 2019-01-10  Tom Tromey  <tom@tromey.com>
4877
4878         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4879         <free_psymtabs>: Now private.
4880         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4881         (allocate_psymtab): Use new method.
4882
4883 2019-01-10  Tom Tromey  <tom@tromey.com>
4884
4885         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4886         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4887         * mdebugread.c (parse_partial_symbols): Use
4888         allocate_dependencies.
4889         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4890         allocate_dependencies.
4891         (process_psymtab_comp_unit_reader)
4892         (build_type_psymtab_dependencies): Likewise.
4893         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4894
4895 2019-01-10  Tom Tromey  <tom@tromey.com>
4896
4897         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4898         PSYMBOL_SET_LANGUAGE.
4899         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4900
4901 2019-01-10  Tom Tromey  <tom@tromey.com>
4902
4903         * psymtab.h (psymtab_storage::obstack): New method.
4904         <m_obstack>: Rename from obstack; now private.
4905         * psymtab.c (psymtab_storage): Update.
4906         * dwarf2read.c (create_addrmap_from_index)
4907         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4908         Update.
4909
4910 2019-01-10  Tom Tromey  <tom@tromey.com>
4911
4912         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4913         * objfiles.h (objfile::reset_psymtabs): New method.
4914
4915 2019-01-10  Tom Tromey  <tom@tromey.com>
4916
4917         * symmisc.c (print_symbol_bcache_statistics): Update.
4918         (print_objfile_statistics): Update.
4919         * symfile.c (reread_symbols): Update.
4920         * psymtab.h (class psymtab_storage): New.
4921         * psymtab.c (psymtab_storage): New constructor.
4922         (~psymtab_storage): New destructor.
4923         (require_partial_symbols): Update.
4924         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4925         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4926         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4927         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4928         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4929         (start_psymtab_common, end_psymtab_common)
4930         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4931         (allocate_psymtab): Update.
4932         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4933         Update.
4934         (dump_psymtab_addrmap, maintenance_print_psymbols)
4935         (maintenance_check_psymtabs): Update.
4936         (class objfile_psymtabs): Move to objfiles.h.
4937         * psympriv.h (discard_psymtab): Now inline.
4938         (psymtab_discarder::psymtab_discarder): Update.
4939         (psymtab_discarder::~psymtab_discarder): Update.
4940         (ALL_OBJFILE_PSYMTABS): Rewrite.
4941         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4942         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4943         Remove fields.
4944         <partial_symtabs>: New field.
4945         (class objfile_psymtabs): Move from psymtab.h.  Update.
4946         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4947         psymbol_cache.
4948         (objfile::~objfile): Don't destroy psymbol_cache.
4949         * mdebugread.c (parse_partial_symbols): Update.
4950         * dwarf2read.c (create_addrmap_from_index)
4951         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4952         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4953         (add_partial_subprogram, dwarf2_ranges_read): Update.
4954         * dwarf-index-write.c (write_address_map)
4955         (write_one_signatured_type, recursively_write_psymbols)
4956         (class debug_names, class debug_names, write_psymtabs_to_index):
4957         Update.
4958
4959 2019-01-10  Tom Tromey  <tom@tromey.com>
4960
4961         * symtab.h (SYMBOL_SET_NAMES): Update.
4962         (symbol_set_names): Update.
4963         (MSYMBOL_SET_NAMES): Update.
4964         * symtab.c (symbol_set_names): Change argument to be an
4965         objfile_per_bfd_storage.
4966         * psymtab.c (add_psymbol_to_bcache): Update.
4967         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4968
4969 2019-01-10  Tom Tromey  <tom@tromey.com>
4970
4971         * symtab.c (create_demangled_names_hash): Change argument to be an
4972         objfile_per_bfd_storage.
4973         (symbol_set_names): Update.
4974
4975 2019-01-10  Tom Tromey  <tom@tromey.com>
4976
4977         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4978         init_psymbol_list.
4979         * psymtab.c (init_psymbol_list): Do nothing if already called.
4980         * psympriv.h (init_psymbol_list): Add comment.
4981         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4982         init_psymbol_list.
4983         * dbxread.c (dbx_symfile_read): Unconditionally call
4984         init_psymbol_list.
4985
4986 2019-01-10  Tom Tromey  <tom@tromey.com>
4987
4988         * xcoffread.c (scan_xcoff_symtab): Update.
4989         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4990         "where".
4991         * mdebugread.c (parse_partial_symbols)
4992         (handle_psymbol_enumerators): Update.
4993         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4994         * dbxread.c (read_dbx_symtab): Update.
4995         * psympriv.h (psymbol_placement): New enum.
4996         (add_psymbol_to_list): Update.
4997
4998 2019-01-10  Tom Tromey  <tom@tromey.com>
4999
5000         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5001         static_psymbols parameters.
5002         (scan_xcoff_symtab): Update.
5003         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5004         static_psymbols parameters.
5005         * psympriv.h (start_psymtab_common): Update.
5006         * mdebugread.c (parse_partial_symbols): Update.
5007         * dwarf2read.c (create_partial_symtab): Update.
5008         * dbxread.c (read_dbx_symtab): Update.
5009         (start_psymtab): Remove global_psymbols and static_psymbols
5010         parameters.
5011
5012 2019-01-10  Tom Tromey  <tom@tromey.com>
5013
5014         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5015         * psymtab.c (allocate_psymtab): Add comment.
5016         * psympriv.h (allocate_psymtab): Add comment.
5017         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5018         initializations.
5019         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5020
5021 2019-01-10  Tom Tromey  <tom@tromey.com>
5022
5023         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5024         Don't declare.
5025         * mipsread.c: Include mdebugread.h.
5026         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5027         Declare.
5028         * elfread.c: Include mdebugread.h.
5029
5030 2019-01-09  Tom Tromey  <tom@tromey.com>
5031
5032         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5033         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5034         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5035         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5036         (psym_lookup_symbol, psym_find_last_source_symtab)
5037         (psym_forget_cached_source_info, psym_print_stats)
5038         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5039         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5040         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5041         (psym_find_compunit_symtab_by_address)
5042         (maintenance_print_psymbols, maintenance_info_psymtabs)
5043         (maintenance_check_psymtabs): Use ranged for.
5044         * psymtab.h (class objfile_psymtabs): New.
5045         (require_partial_symbols): Return objfile_psymtabs.
5046         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5047
5048 2019-01-09  Tom Tromey  <tom@tromey.com>
5049
5050         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5051         (find_pc_mapped_section, list_overlays_command)
5052         (map_overlay_command, unmap_overlay_command)
5053         (simple_overlay_update): Use all_objfiles.
5054         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5055         * printcmd.c (info_symbol_command): Use all_objfiles.
5056         * objfiles.h (ALL_OBJSECTIONS): Remove.
5057         * maint.c (maintenance_translate_address): Use all_objfiles.
5058         * gcore.c (gcore_create_callback): Use all_objfiles.
5059         (objfile_find_memory_regions): Likewise.
5060
5061 2019-01-09  Tom Tromey  <tom@tromey.com>
5062
5063         * symtab.c (find_line_symtab, info_sources_command)
5064         (make_source_files_completion_list): Use objfile_compunits.
5065         * source.c (select_source_symtab): Use objfile_compunits.
5066         * objfiles.h (struct objfile): Update comment.
5067         (ALL_OBJFILES): Remove.
5068         (ALL_FILETABS): Remove.
5069         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5070         objfile_compunits.
5071
5072 2019-01-09  Tom Tromey  <tom@tromey.com>
5073
5074         * symmisc.c (print_objfile_statistics, dump_objfile)
5075         (maintenance_print_symbols): Use compunit_filetabs.
5076         * source.c (forget_cached_source_info_for_objfile): Use
5077         compunit_filetabs.
5078         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5079         (ALL_FILETABS): Use compunit_filetabs.
5080         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5081         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5082
5083 2019-01-09  Tom Tromey  <tom@tromey.com>
5084
5085         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5086         (compunit_filetabs): New.
5087         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5088         compunit_filetabs.
5089         (info_sources_command, make_source_files_completion_list): Remove
5090         declaration.
5091         * symmisc.c (print_objfile_statistics, dump_objfile)
5092         (maintenance_print_symbols): Remove declaration.
5093         (maintenance_info_symtabs): Use compunit_filetabs.
5094         (maintenance_info_line_tables): Likewise.
5095         * source.c (select_source_symtab): Change local variable name.
5096         (forget_cached_source_info_for_objfile): Remove declaration.
5097         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5098         * objfiles.c (objfile_relocate1): Remove declaration.
5099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5100         declaration.
5101         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5102         * coffread.c (coff_symtab_read): Remove declaration.
5103         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5104         compunit_filetabs.
5105
5106 2019-01-09  Tom Tromey  <tom@tromey.com>
5107
5108         * symtab.c (lookup_objfile_from_block)
5109         (find_pc_sect_compunit_symtab, search_symbols)
5110         (default_collect_symbol_completion_matches_break_on): Use
5111         objfile_compunits.
5112         * objfiles.h (ALL_COMPUNITS): Remove.
5113         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5114         * cp-support.c (add_symbol_overload_list_qualified): Use
5115         objfile_compunits.
5116         * ada-lang.c (ada_collect_symbol_completion_matches)
5117         (ada_add_global_exceptions): Use objfile_compunits.
5118
5119 2019-01-09  Tom Tromey  <tom@tromey.com>
5120
5121         * source.c (select_source_symtab)
5122         (forget_cached_source_info_for_objfile): Remove declaration.
5123         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5124         declaration.
5125         * maint.c (count_symtabs_and_blocks): Remove declaration.
5126         * cp-support.c (add_symbol_overload_list_qualified): Remove
5127         declaration.
5128         * coffread.c (coff_symtab_read): Remove declaration.
5129         * symtab.c (lookup_symbol_in_objfile_symtabs)
5130         (basic_lookup_transparent_type_1): Use objfile_compunits.
5131         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5132         (info_sources_command, search_symbols)
5133         (default_collect_symbol_completion_matches_break_on)
5134         (make_source_files_completion_list): Remove declaration.
5135         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5136         (ada_collect_symbol_completion_matches)
5137         (ada_add_global_exceptions): Remove declaration.
5138         * linespec.c (iterate_over_all_matching_symtabs): Use
5139         objfile_compunits.
5140         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5141         (class objfile_compunits): New.
5142         (ALL_COMPUNITS): Use objfile_compunits.
5143         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5144         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5145         objfile_compunits.
5146         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5147
5148 2019-01-09  Tom Tromey  <tom@tromey.com>
5149
5150         * symtab.c (search_symbols)
5151         (default_collect_symbol_completion_matches_break_on): Use
5152         objfile_msymbols.
5153         * ada-lang.c (ada_lookup_simple_minsym)
5154         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5155         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5156         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5157         objfile_msymbols.
5158         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5159         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5160         * objc-lang.c (find_methods): Use objfile_msymbols.
5161         (info_selectors_command, info_classes_command): Likewise.
5162         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5163         * objfiles.h (class objfile_msymbols): New.
5164         (ALL_OBJFILE_MSYMBOLS): Remove.
5165         (ALL_MSYMBOLS): Remove.
5166
5167 2019-01-09  Tom Tromey  <tom@tromey.com>
5168
5169         * common/next-iterator.h (next_adapter): Add Iterator template
5170         parameter.
5171         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5172         (class all_objfiles_safe): New.
5173         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5174         * objfiles.c (put_objfile_before): Update comment.
5175         (add_separate_debug_objfile): Likewise.
5176         (free_all_objfiles): Use all_objfiles_safe.
5177         (objfile_purge_solibs): Likewise.
5178
5179 2019-01-09  Tom Tromey  <tom@tromey.com>
5180
5181         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5182         (expand_symtab_containing_pc, lookup_static_symbol)
5183         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5184         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5185         all_objfiles.
5186         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5187         * breakpoint.c (create_overlay_event_breakpoint)
5188         (create_longjmp_master_breakpoint)
5189         (create_std_terminate_master_breakpoint)
5190         (create_exception_master_breakpoint): Use all_objfiles.
5191         * linux-thread-db.c (try_thread_db_load_from_pdir)
5192         (has_libpthread): Use all_objfiles.
5193         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5194         * linespec.c (iterate_over_all_matching_symtabs)
5195         (search_minsyms_for_name): Use all_objfiles.
5196         * maint.c (maintenance_info_sections): Use all_objfiles.
5197         * main.c (captured_main_1): Use all_objfiles.
5198         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5199         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5200         * guile/scm-pretty-print.c
5201         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5202         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5203         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5204         (maintenance_print_msymbols): Use all_objfiles.
5205         * source.c (select_source_symtab): Use all_objfiles.
5206         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5207         * symfile.c (remove_symbol_file_command)
5208         (expand_symtabs_matching, map_symbol_filenames): Use
5209         all_objfiles.
5210         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5211         all_objfiles.
5212         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5213         * objc-lang.c (find_methods): Use all_objfiles.
5214         * objfiles.c (have_partial_symbols, have_full_symbols)
5215         (have_minimal_symbols, qsort_cmp)
5216         (default_iterate_over_objfiles_in_search_order): Use
5217         all_objfiles.
5218         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5219         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5220         (maintenance_check_psymtabs): Use all_objfiles.
5221         (ALL_PSYMTABS): Remove.
5222         * compile/compile-object-run.c (do_module_cleanup): Use
5223         all_objfiles.
5224         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5225         * cp-support.c (add_symbol_overload_list_qualified): Use
5226         all_objfiles.
5227         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5228         Use all_objfiles.
5229         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5230         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5231         all_objfiles.
5232         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5233         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5234         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5235         Uses all_objfiles.
5236         * solib.c (solib_read_symbols): Use all_objfiles
5237
5238 2019-01-09  Tom Tromey  <tom@tromey.com>
5239
5240         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5241         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5242         all_objfiles.
5243         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5244         * symmisc.c (print_symbol_bcache_statistics)
5245         (print_objfile_statistics, maintenance_print_objfiles)
5246         (maintenance_info_symtabs, maintenance_check_symtabs)
5247         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5248         all_objfiles.
5249         * source.c (forget_cached_source_info): Use all_objfiles.
5250         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5251         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5252         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5253         * objfiles.c (update_section_map): Use all_objfiles.
5254         (shared_objfile_contains_address_p): Likewise.
5255         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5256         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5257
5258 2019-01-09  Tom Tromey  <tom@tromey.com>
5259
5260         * common/next-iterator.h: New file.
5261         * objfiles.h (class all_objfiles): New.
5262         (struct objfile_iterator): New.
5263
5264 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5265
5266         * NEWS: Move the description of the changed "frame", "select-frame",
5267          and "info frame" commands to the Changed commands section.
5268
5269 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5270
5271         * gdbtypes.c (check_stub_method_group): Remove handling of old
5272         mangling schemes.
5273         * linespec.c (find_methods): Likewise.
5274         * stabsread.c (read_member_functions): Likewise.
5275         * valops.c (search_struct_method): Likewise.
5276         (value_struct_elt_for_reference): Likewise.
5277         * NEWS: Mention this change.
5278
5279 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5282         print_source_lines.
5283         * source.c (print_source_lines_base): Update line number check.
5284         (print_source_lines): New function.
5285         (source_lines_range::source_lines_range): New function.
5286         * source.h (class source_lines_range): New class.
5287         (print_source_lines): New declaration.
5288
5289 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5290
5291         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5292
5293 2019-01-08  Tom Tromey  <tom@tromey.com>
5294             Simon Marchi  <simon.marchi@ericsson.com>
5295
5296         PR gdb/24060
5297         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5298         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5299         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5300         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5301         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5302         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5303
5304 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * source.c (select_source_symtab): Move header comment to
5307         declaration in source.h.
5308         (forget_cached_source_info_for_objfile): Likewise.
5309         (forget_cached_source_info): Likewise.
5310         (identify_source_line): Likewise.
5311         * source.h (identify_source_line): Move declaration from symtab.h
5312         and add comment from source.c
5313         (print_source_lines): Likewise.
5314         (forget_cached_source_info_for_objfile): Likewise.
5315         (forget_cached_source_info): Likewise.
5316         (select_source_symtab): Likewise.
5317         (enum print_source_lines_flag): Move definition from symtab.h.
5318         * symtab.h (identify_source_line): Move declaration to source.h.
5319         (print_source_lines): Likewise.
5320         (forget_cached_source_info_for_objfile): Likewise.
5321         (forget_cached_source_info): Likewise.
5322         (select_source_symtab): Likewise.
5323         (enum print_source_lines_flag): Move definition to source.h.
5324         * tui/tui-hooks.c: Add 'source.h' include.
5325
5326 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * source.c (print_source_lines_base): Handle requests to print
5329         reverse line number sequences, and guard against empty lines
5330         string.
5331
5332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5333
5334         * source.c (print_source_lines_base): Fix skip of '\r' if next
5335         character is '\n'.
5336
5337 2019-01-06  Tom Tromey  <tom@tromey.com>
5338
5339         * c-exp.y (struct c_parse_state) <macro_original_text,
5340         expansion_obstack>: New member.
5341         (macro_original_text, expansion_obstack): Remove globals.
5342         (scan_macro_expansion, scanning_macro_expansion)
5343         (finished_macro_expansion): Update.
5344         (scan_macro_cleanup): Remove.
5345         (yylex, c_parse): Update.
5346
5347 2019-01-06  Tom Tromey  <tom@tromey.com>
5348
5349         * c-exp.y (struct c_parse_state) <strings>: New member.
5350         (operator_stoken): Update.
5351
5352 2019-01-06  Tom Tromey  <tom@tromey.com>
5353
5354         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5355         (union type_stack_elt) <typelist_val>: Now a pointer to
5356         std::vector.
5357         (type_stack_cleanup): Don't declare.
5358         (push_typelist): Update.
5359         * parse.c (pop_typelist): Return a std::vector.
5360         (push_typelist): Take a std::vector.
5361         (follow_types): Update.  Do not free args.
5362         (type_stack_cleanup): Remove.
5363         * c-exp.y (struct c_parse_state): New.
5364         (cpstate): New global.
5365         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5366         (nonempty_typelist): Update.
5367         (func_mod): Create a new vector.
5368         (c_parse): Create a c_parse_state.
5369         (check_parameter_typelist): Do not delete params.
5370         (function_method): Update.  Do not delete type_list.
5371
5372 2019-01-06  Tom Tromey  <tom@tromey.com>
5373
5374         PR gdb/28155:
5375         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5376         check_typedef.
5377         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5378         (print_return_value): Likewise.
5379
5380 2019-01-05  Tom Tromey  <tom@tromey.com>
5381
5382         * contrib/cleanup_check.py: Remove.
5383         * contrib/gcc-with-excheck: Remove.
5384         * contrib/exsummary.py: Remove.
5385         * contrib/excheck.py: Remove.
5386
5387 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5388
5389         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5390         NULL. Initialize tpprev to NULL instead of assigning it
5391         to NULL on the next statement.
5392         * windows-nat.c (windows_delete_thread): Remove check for
5393         main_thread_id before printing thread exit notifications.
5394         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5395         Remove thread ID check against main_thread_id.
5396         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5397         windows_delete_thread.
5398         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5399
5400 2019-01-04  Tom Tromey  <tom@tromey.com>
5401
5402         * compile/compile.c (_initialize_compile): Use upper case for
5403         metasyntactic variables.
5404         * symmisc.c (_initialize_symmisc): Use upper case for
5405         metasyntactic variables.
5406         * psymtab.c (_initialize_psymtab): Use upper case for
5407         metasyntactic variables.
5408         * demangle.c (demangle_command): Use upper case for metasyntactic
5409         variables.
5410         (_initialize_demangler): Likewise.
5411         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5412         variables.
5413
5414 2019-01-03  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5417
5418 2019-01-03  Tom Tromey  <tom@tromey.com>
5419
5420         * python/py-symtab.c (salpy_str): Update.
5421         (struct salpy_sal_object) <symtab>: Now a PyObject.
5422         (salpy_dealloc): Update.
5423         (del_objfile_sal): Use gdbpy_ref.
5424
5425 2019-01-03  Tom Tromey  <tom@tromey.com>
5426
5427         * python/py-type.c (convert_field): Use new_reference.  Return
5428         gdbpy_ref.
5429         (make_fielditem): Return gdbpy_ref.
5430         (typy_fields): Update.
5431         (typy_getitem): Update.
5432         (field_name): Return gdbpy_ref.  Use new_reference.
5433         (typy_iterator_iternext): Update.
5434
5435 2019-01-03  Tom Tromey  <tom@tromey.com>
5436
5437         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5438
5439 2019-01-03  Tom Tromey  <tom@tromey.com>
5440
5441         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5442         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5443         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5444         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5445         (pspy_set_type_printers): Likewise.
5446         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5447         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5448         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5449         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5450         (objfpy_set_type_printers): Likewise.
5451
5452 2019-01-03  Tom Tromey  <tom@tromey.com>
5453
5454         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5455         (gdbpy_print_stack): Use gdbpy_err_fetch.
5456         * python/python-internal.h (class gdbpy_err_fetch): New class.
5457         (class gdbpy_enter) <m_error_type, m_error_value,
5458         m_error_traceback>: Remove.
5459         <m_error>: New member.
5460         (gdbpy_exception_to_string): Don't declare.
5461         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5462         * python/py-value.c (convert_value_from_python): Use
5463         gdbpy_err_fetch.
5464         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5465         gdbpy_exception_to_string.
5466         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5467         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5468         gdbpy_err_fetch.
5469
5470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5471
5472         * linux-nat.c (delete_lwp_cleanup): Delete.
5473         (struct lwp_deleter): New struct.
5474         (lwp_info_up): New typedef.
5475         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5476         lwp_info_up.
5477
5478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * linux-fork.c (class scoped_switch_fork_info): New class.
5481         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5482
5483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * valops.c (find_overload_match): Remove use of null_cleanup, and
5486         calls to do_cleanups.
5487
5488 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5489
5490         * compile/compile-cplus-types.c
5491         (compile_cplus_instance::decl_name): Handle changes to
5492         cp_func_name.
5493         * cp-support.c (cp_func_name): Update header comment, update
5494         return type.
5495         * cp-support.h (cp_func_name): Update return type in declaration.
5496         * valops.c (find_overload_match): Move temp_func local to top
5497         level of function and change its type.  Use temp_func to hold and
5498         delete temporary string obtained from cp_func_name.
5499
5500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5501
5502         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5503         gdb::char_vector, remove cleanup, and update uses of `msg`.
5504
5505 2019-01-03  Jim Wilson  <jimw@sifive.com>
5506
5507         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5508
5509 2019-01-02  Tom Tromey  <tom@tromey.com>
5510
5511         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5512         (tdesc_parse_xml): Remove cleanups.
5513         * target-descriptions.h (make_cleanup_free_target_description):
5514         Don't declare.
5515         (target_desc_deleter): New struct.
5516         (target_desc_up): New typedef.
5517         * target-descriptions.c (target_desc_deleter::operator()): Rename
5518         from free_target_description.
5519         (make_cleanup_free_target_description): Remove.
5520
5521 2019-01-02  Tom Tromey  <tom@tromey.com>
5522
5523         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5524         constructor, destructor.
5525         (linespec_parser): Remove typedef.
5526         (~linespec_parser): Rename from linespec_parser_delete.
5527         (linespec_lex_to_end, linespec_complete_label)
5528         (linespec_complete): Update.
5529         (decode_line_full): Remove cleanups.
5530         (decode_line_1): Update.
5531
5532 2019-01-02  Tom Tromey  <tom@tromey.com>
5533
5534         * python/python-internal.h (inferior_to_inferior_object): Change
5535         return type.
5536         * python/py-exitedevent.c (create_exited_event_object): Update.
5537         * python/py-inferior.c (inferior_to_inferior_object): Return
5538         gdbpy_ref.
5539         (python_new_inferior, python_inferior_deleted)
5540         (thread_to_thread_object, delete_thread_object)
5541         (build_inferior_list, gdbpy_selected_inferior): Update.
5542         * python/py-infthread.c (create_thread_object): Update.  Also fail
5543         if inferior_to_inferior_object fails.
5544
5545 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5546
5547         * inferior.h (class inferior) <displaced_step_state>: New field.
5548         * infrun.h (struct displaced_step_state): Move here from
5549         infrun.c.  Initialize fields, add constructor.
5550         <inf>: Remove field.
5551         <reset>: New method.
5552         * infrun.c (struct displaced_step_inferior_state): Move to
5553         infrun.h.
5554         (displaced_step_inferior_states): Remove.
5555         (get_displaced_stepping_state): Adust.
5556         (displaced_step_in_progress_any_inferior): Adjust.
5557         (displaced_step_in_progress_thread): Adjust.
5558         (displaced_step_in_progress): Adjust.
5559         (add_displaced_stepping_state): Remove.
5560         (get_displaced_step_closure_by_addr): Adjust.
5561         (remove_displaced_stepping_state): Remove.
5562         (infrun_inferior_exit): Call displaced_step_state.reset.
5563         (use_displaced_stepping): Don't check for NULL.
5564         (displaced_step_prepare_throw): Call
5565         get_displaced_stepping_state.
5566         (displaced_step_fixup): Don't check for NULL.
5567         (prepare_for_detach): Don't check for NULL.
5568
5569 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5570
5571         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5572          in case of call that did not complete.
5573
5574 2019-01-02  Andrey Utkin  <autkin@undo.io>
5575
5576         * symfile.c (find_separate_debug_file): Fix search of debug files for
5577         remote debuggee.
5578
5579 2019-01-02  Tom Tromey  <tom@tromey.com>
5580
5581         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5582         indentation.
5583         * python/py-frame.c (frapy_older): Remove cast.
5584         (frapy_newer): Likewise.
5585         * python/py-breakpoint.c (local_setattro): Remove cast.
5586         * python/py-arch.c (archpy_name): Remove local variable.
5587         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5588
5589 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5590
5591         * unittests/basic_string_view/element_access/char/empty.cc:
5592         Fix year range in copyright header.
5593
5594 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5595
5596         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5597         Delete.
5598         <operator==>: Update with for removed field.
5599         <hash>: Likewise.
5600         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5601         <isa_features>: ...this.
5602         <abi_features>: New field.
5603         (riscv_isa_flen): Update comment.
5604         (riscv_abi_xlen): New declaration.
5605         (riscv_abi_flen): New declaration.
5606         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5607         isa_features.
5608         (riscv_abi_xlen): New function.
5609         (riscv_isa_flen): Update to get answer from isa_features.
5610         (riscv_abi_flen): New function.
5611         (riscv_has_fp_abi): Update to get answer from abi_features.
5612         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5613         xlen and flen.
5614         (riscv_call_info) <xlen, flen>: Update comment.
5615         (riscv_call_arg_struct): Remove invalid assertions
5616         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5617         is removed.
5618         (riscv_gdbarch_init): Gather isa features and abi features
5619         separately, ensure both match on the gdbarch when reusing an old
5620         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5621         a target with 64-bit float hardware.
5622
5623 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5624
5625         * source.c (search_command_helper): Stop reverse search
5626         when line 1 has been searched.
5627
5628 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5629
5630         * record-full.c (record_full_base_target::close): Rewrite
5631         record_full_core_buf_list free logic.
5632
5633 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5634
5635         * break-catch-syscall.c (print_one_catch_syscall): xfree
5636         the last text.
5637
5638 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5639
5640         * top.c (print_gdb_version): Update Copyright year in version
5641         message.
5642
5643 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5644
5645         Update copyright year range in all GDB files.
5646
5647 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5648
5649         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5650
5651 For older changes see ChangeLog-2018.
5652 \f
5653 Local Variables:
5654 mode: change-log
5655 left-margin: 8
5656 fill-column: 74
5657 version-control: never
5658 coding: utf-8
5659 End:
5660