gdb/ChangeLog

   1 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * symtab.c (search_symbols): Adjust msymbol matching type arrays
   4         so that GDB doesn't match any msymbols when searching in the
   5         TYPES_DOMAIN.
   6         (print_symbol_info): Print using typedef_print or type_print based
   7         on the type of the symbol.  Add updated FIXME comment moved from...
   8         (_initialize_symtab): ... move and update FIXME comment to above.
   9
  10 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  11
  12         * NEWS: Mention adding -q option to "info types".
  13         * symtab.c (struct info_types_options): New struct.
  14         (info_types_options_defs): New variable.
  15         (make_info_types_options_def_group): New function.
  16         (info_types_command): Use gdb::option framework to parse options.
  17         (info_types_command_completer): New function.
  18         (_initialize_symtab): Extend the help text on "info types" and
  19         register command completer.
  20
  21 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  22
  23         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  24         (lookup_symbol_in_objfile): Change int to block_enum and add a
  25         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  26
  27 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  28
  29         * MAINTAINERS (Write After Approval): Add self.
  30
  31 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  32
  33         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  34         instruction to the dummy code region.
  35
  36 2019-07-19  Tom Tromey  <tromey@adacore.com>
  37
  38         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  39         (ARGSUSED, PARAMS, __func__): Remove rules.
  40
  41 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  42
  43         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  44         * features/arm/arm-with-iwmmxt.c: Remove.
  45         * features/arm/arm-with-iwmmxt.xml: Remove.
  46         * features/arm/arm-with-m-fpa-layout.c: Remove.
  47         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  48         * features/arm/arm-with-m-vfp-d16.c: Remove.
  49         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  50         * features/arm/arm-with-m.c: Remove.
  51         * features/arm/arm-with-m.xml: Remove.
  52         * features/arm/arm-with-neon.c: Remove.
  53         * features/arm/arm-with-neon.xml: Remove.
  54         * features/arm/arm-with-vfpv2.c: Remove.
  55         * features/arm/arm-with-vfpv2.xml: Remove.
  56         * features/arm/arm-with-vfpv3.c: Remove.
  57         * features/arm/arm-with-vfpv3.xml: Remove.
  58
  59 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  60
  61         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  62
  63 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  64
  65         * arch/aarch32.c (aarch32_create_target_description): Create
  66         target descriptions using features.
  67         * arch/arm.c (arm_create_target_description)
  68         (arm_create_mprofile_target_description): Likewise.
  69         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  70
  71 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  72
  73         * Makefile.in: Add new files.
  74         * aarch32-tdep.c: New file.
  75         * aarch32-tdep.h: New file.
  76         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  77         Call aarch32_read_description.
  78         * arch/aarch32.c: New file.
  79         * arch/aarch32.h: New file.
  80         * arch/arm.c (arm_create_target_description)
  81         (arm_create_mprofile_target_description): New function.
  82         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  83         (arm_create_target_description)
  84         (arm_create_mprofile_target_description): New declaration.
  85         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  86         read_description functions.
  87         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  88         Likewise.
  89         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  90         * arm-tdep.c (tdesc_arm_list): New variable.
  91         (arm_register_g_packet_guesses): Call create description functions.
  92         (arm_read_description) (arm_read_mprofile_description): New
  93         function.
  94         * arm-tdep.h (arm_read_description)
  95         (arm_read_mprofile_description): Add declaration.
  96         * configure.tgt: Add new files.
  97
  98 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  99
 100         * top.c (new_ui_command): Open specified terminal just once.
 101
 102 2019-07-18  Tom Tromey  <tromey@adacore.com>
 103
 104         * symtab.c (main_name): Constify return type.
 105         * symfile.c (set_initial_language): Update.
 106         * symtab.h (main_name): Constify return type.
 107
 108 2019-07-17  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-winsource.c (tui_update_source_window)
 111         (tui_update_source_window_as_is)
 112         (tui_update_source_windows_with_line): Remove return.
 113         * tui/tui-disasm.c (tui_show_disassem)
 114         (tui_show_disassem_and_update_source): Remove return.
 115         * tui/tui.c (tui_reset): Remove return.
 116         * tui/tui-wingeneral.c
 117         (tui_check_and_display_highlight_if_needed): Remove return.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-winsource.h (struct tui_exec_info_window)
 126         (struct tui_source_window_base): Move from tui-data.h.
 127         * tui/tui-winsource.c: Move many method definitions from
 128         elsewhere.  Remove "structuring" comments.
 129         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 130         (tui_source_window_base::refresh_window): Move to
 131         tui-winsource.c.
 132         * tui/tui-win.c (tui_source_window_base::refresh_all)
 133         (tui_source_window_base::update_tab_width)
 134         (tui_source_window_base::set_new_height)
 135         (tui_source_window_base::do_make_visible_with_new_height): Move to
 136         tui-winsource.c.
 137         * tui/tui-source.h: Update.
 138         * tui/tui-source.c (tui_source_window_base::reset): Move to
 139         tui-winsource.c.
 140         * tui/tui-disasm.h: Update.
 141         * tui/tui-data.h (struct tui_exec_info_window): Move to
 142         tui-winsource.h.
 143         (struct tui_source_window_base): Likewise.
 144         * tui/tui-data.c (tui_source_window_base::clear_detail)
 145         (tui_source_window_base, ~tui_source_window_base): Move to
 146         tui-winsource.c.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-win.c (tui_resize_all)
 151         (tui_source_window_base::update_tab_width)
 152         (tui_adjust_win_heights): Update.
 153         (tui_win_info::make_invisible_and_set_new_height): Rename from
 154         make_invisible_and_set_new_height.
 155         * tui/tui-data.h (struct tui_win_info)
 156         <make_invisible_and_set_new_height>: New method.
 157
 158 2019-07-17  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui.c: Update.
 161         * tui/tui-source.h (struct tui_source_window): Move from
 162         tui-data.h.
 163         * tui/tui-layout.c: Update.
 164         * tui/tui-disasm.c: Update.
 165         * tui/tui-data.h (struct tui_source_window): Move to
 166         tui-source.h.
 167
 168 2019-07-17  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 171         tui-data.h.
 172         * tui/tui-data.h (struct tui_disasm_window): Move to
 173         tui-disasm.h.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-regs.h (struct tui_data_item_window): Move from
 178         tui-data.h.
 179         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 180         * tui/tui-data.h (struct tui_data_item_window): Move to
 181         tui-regs.h.
 182         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui.c: Update.
 187         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 188         (tui_cmd_window::max_height): Move to tui-command.c.
 189         * tui/tui-layout.c: Update.
 190         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 191         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 192         tui-command.c.
 193         * tui/tui-command.h (struct tui_cmd_window): Move from
 194         tui-data.h.
 195         * tui/tui-command.c: Remove "structuring" comments.
 196         (tui_cmd_window::clear_detail)
 197         (tui_cmd_window::do_make_visible_with_new_height)
 198         (tui_cmd_window::max_height): Move from elsewhere.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 203         Now static.
 204         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 205         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 206
 207 2019-07-17  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui.c: Update.
 210         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 211         tui-regs.c.
 212         * tui/tui-windata.h: Remove file.
 213         * tui/tui-windata.c: Remove file.
 214         * tui/tui-win.c (tui_data_window::set_new_height)
 215         (tui_data_window::do_make_visible_with_new_height): Move to
 216         tui-regs.c.
 217         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 218         * tui/tui-regs.c: Remove "structuring" comments.
 219         (tui_data_window::first_data_item_displayed)
 220         (tui_data_window::delete_data_content_windows)
 221         (tui_data_window::erase_data_content)
 222         (tui_data_window::display_all_data)
 223         (tui_data_window::refresh_all)
 224         (tui_data_window::do_scroll_vertical)
 225         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 226         (tui_data_window::do_make_visible_with_new_height)
 227         (tui_data_window::refresh_window): Move from elsewhere.
 228         (_initialize_tui_regs): Move to end of file.
 229         * tui/tui-layout.c: Update.
 230         * tui/tui-hooks.c: Update.
 231         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 232         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 233         tui-regs.c.
 234         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 239         seen.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-win.c (tui_source_window_base::set_new_height)
 244         (tui_source_window_base::do_make_visible_with_new_height): Use
 245         m_has_locator field directly.
 246         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 247         method.
 248         (struct tui_source_window_base) <has_locator>: Likewise.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 253         Don't declare.
 254         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 255         Remove.
 256         * tui/tui-win.c (tui_source_window_base::set_new_height)
 257         (tui_source_window_base::set_new_height)
 258         (make_invisible_and_set_new_height)
 259         (tui_source_window_base::do_make_visible_with_new_height)
 260         (tui_source_window_base::do_make_visible_with_new_height):
 261         Update.
 262         * tui/tui-layout.c (show_source_disasm_command, show_data)
 263         (show_source_or_disasm_and_command): Update.
 264         * tui/tui-layout.c (show_layout): Update.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-layout.c (make_data_window): Remove.
 269         (show_data): Unify creation and re-initialization cases.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-layout.c (make_source_window, make_disasm_window):
 274         Remove.
 275         (show_data): Unify creation and re-initialization cases.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-layout.c (make_command_window): Remove.
 280         (show_source_disasm_command, show_source_or_disasm_and_command):
 281         Unify creation and re-initialization cases.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 286         creation and re-initialization cases.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-regs.c (tui_get_register): Return void.
 291
 292 2019-07-17  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 295         Simplify.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 300         resetting.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 305         * tui/tui-regs.c (tui_reg_layout): New function.
 306         (tui_show_registers, tui_reg_command): Use it.
 307         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 308         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 309         parameters.
 310         (tui_layout_command): Remove.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-layout.h (tui/tui-layout): Return void.
 315         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-layout.c (show_source_disasm_command, show_data):
 320         Update.
 321         (reset_locator): Remove.
 322         (show_source_or_disasm_and_command): Update.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-source.c (tui_source_window_base::reset): Remove
 327         win_type parameter.
 328         * tui/tui-layout.c (make_command_window, make_source_window)
 329         (make_disasm_window, make_data_window)
 330         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 331         (reset_locator, show_source_or_disasm_and_command): Update.
 332         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 333         win_type parameter.
 334         (struct tui_source_window_base) <reset>: Likewise.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-layout.c (show_source_disasm_command): Use
 339         reset_locator.
 340         (reset_locator): New function.
 341         (init_and_make_win): Remove.
 342         (show_source_or_disasm_and_command): Use reset_locator.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 347         condition.
 348         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 349         Remove condition.
 350         * tui/tui-source.c (tui_source_window_base::reset): New method.
 351         * tui/tui-layout.c (make_command_window): Don't call
 352         init_and_make_win.
 353         (make_source_window, make_disasm_window): Don't call
 354         make_source_or_disasm_window.
 355         (make_data_window): Don't call init_and_make_win.  Change calling
 356         convention.
 357         (show_source_disasm_command, show_data): Simplify.
 358         (make_source_or_disasm_window): Remove.
 359         (show_source_or_disasm_and_command): Simplify.
 360         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 361         (struct tui_source_window_base) <reset>: Likewise.
 362         <execution_info>: Remove initializer.
 363         * tui/tui-data.c (tui_source_window_base): Initialize
 364         execution_info.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 369         variable.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui.c (tui_rl_other_window): Update.
 374         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 375         superclass method first.  Always iterate over regs_content.
 376         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 377         method.
 378         * tui/tui-win.c (tui_set_focus_command): Update.
 379
 380 2019-07-17  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-win.c (tui_set_focus_command): Rename from
 383         tui_set_focus.  Call tui_enable.
 384         (tui_set_focus_command): Remove.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 389         refresh_window.
 390         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 391         touchwin.
 392         (tui_data_window::refresh_window): Call refresh_window on data
 393         items.  Always call superclass refresh_window.
 394         (tui_win_info::refresh): Remove.
 395         (tui_source_window_base::refresh_window): Update.
 396         (tui_refresh_all): Update.
 397         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 398         refresh_window.
 399         (show_source_or_disasm_and_command): Likewise.
 400         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 401         (struct tui_source_window_base) <refresh>: Likewise.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-winsource.c (tui_clear_source_content)
 406         (tui_show_source_content): Update.
 407         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 408         whether content is empty.
 409         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 410         Remove.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 415         window's contents.
 416         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 417         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 422         (struct tui_data_item_window): Update.
 423
 424 2019-07-17  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 427         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 428         defines.
 429
 430 2019-07-17  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.h (tui_erase_source_content)
 433         (tui_clear_source_content): Remove "display_prompt" parameter.
 434         * tui/tui-winsource.c (tui_update_source_window_as_is)
 435         (tui_update_source_windows_with_addr): Update.
 436         (tui_clear_source_content): Remove "display_prompt" parameter.
 437         (tui_erase_source_content): Likewise.  Simplify.
 438         (tui_show_source_content): Update.
 439         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 440         * tui/tui-stack.c (tui_show_frame_info): Update.
 441         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 442         Remove defines.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 447         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 448         parameter.
 449         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 450         parameter.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-winsource.c (tui_clear_source_content)
 455         (tui_show_source_content, tui_show_exec_info_content)
 456         (tui_clear_exec_info_content): Update.
 457         * tui/tui-stack.c (tui_show_locator_content): Update.
 458         (tui_show_frame_info): Update.
 459         * tui/tui-source.h (tui_source_window): Don't declare.
 460         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 461         from tui_source_is_displayed.
 462         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 463         Remove field.
 464         (struct tui_source_window_base) <content_in_use>: New field.  Now
 465         bool.
 466         (struct tui_source_window) <showing_source_p>: New method.
 467         (TUI_SRC_WIN): Change cast.
 468         * tui/tui-data.c (tui_initialize_static_data): Update.
 469
 470 2019-07-17  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 473         location_matches_p.
 474         * tui/tui-source.c (tui_source_window::location_matches_p): New
 475         method.
 476         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 477         method.
 478         * tui/tui-data.h (struct tui_source_window_base)
 479         <location_matches_p>: New method.
 480         (struct tui_source_window, struct tui_disasm_window)
 481         <location_matches_p>: Likewise.
 482
 483 2019-07-17  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-win.c (tui_set_win_height_command): Rename from
 486         tui_set_win_height.
 487         (tui_set_win_height_command): Remove.
 488
 489 2019-07-17  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-source.c (tui_source_window): New constructor.  Add
 492         observer.
 493         (~tui_source_window): New destructor.
 494         (tui_source_window::style_changed): New method.
 495         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 496         (tui_attach_detach_observers): Update.
 497         * tui/tui-data.h (struct tui_source_window): Make constructor not
 498         inline.  Add destructor.
 499         (struct tui_source_window) <style_changed>: New method.
 500         <m_observable>: New member.
 501
 502 2019-07-17  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 505         * tui/tui-win.c (tui_resize_all): Fix typo.
 506
 507 2019-07-17  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 510         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 511         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 512         * tui/tui-win.c (window_name_completer): Use foreach.
 513         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 514         (update_tab_width): Likewise.
 515         * tui/tui-layout.c (show_layout): Update.
 516         * tui/tui-data.h (class tui_window_iterator): New.
 517         (struct all_tui_windows): New.
 518         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 519
 520 2019-07-17  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 523         parameter.  Don't reference globals.
 524         (tui_reg_command): Update.
 525
 526 2019-07-17  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-regs.c (tui_show_registers): Simplify.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-regs.c (tui_show_registers): Update.
 533         (tui_show_register_group): Add win_info parameter.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 538         Rename from tui_display_reg_element_at_line.
 539         (tui_data_window::display_registers_from_line): Update.
 540         * tui/tui-data.h (struct tui_data_window)
 541         <display_reg_element_at_line>: New method.
 542
 543 2019-07-17  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-regs.h (tui_display_registers_from)
 546         (tui_display_registers_from_line): Don't declare.
 547         * tui/tui-windata.c (tui_data_window::display_all_data)
 548         (tui_data_window::refresh_all)
 549         (tui_data_window::do_scroll_vertical): Update.
 550         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 551         from tui_display_registers_from.
 552         (tui_display_reg_element_at_line): Update.
 553         (tui_data_window::display_registers_from_line): Rename from
 554         tui_display_registers_from_line.
 555         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 556         display_registers_from_line>: New methods.
 557
 558 2019-07-17  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 561         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 562         from tui_erase_data_content.
 563         (tui_data_window::display_all_data)
 564         (tui_data_window::refresh_all)
 565         (tui_data_window::do_scroll_vertical): Update.
 566         * tui/tui-regs.c (tui_show_registers): Update.
 567         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 568         New method.
 569
 570 2019-07-17  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 573         declare.
 574         * tui/tui-windata.c
 575         (tui_data_window::delete_data_content_windows): Rename from
 576         tui_delete_data_content_windows.
 577         (tui_data_window::display_all_data)
 578         (tui_data_window::do_scroll_vertical): Update.
 579         * tui/tui-data.h (struct tui_data_window)
 580         <delete_data_content_windows>: New method.
 581
 582 2019-07-17  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 585         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 586
 587 2019-07-17  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 590         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 591         from tui_display_all_data.
 592         * tui/tui-win.c
 593         (tui_data_window::do_make_visible_with_new_height): Update.
 594         * tui/tui-regs.c (tui_show_registers): Update.
 595         * tui/tui-layout.c (tui_set_layout): Update.
 596         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 597         method.
 598
 599 2019-07-17  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 602         * tui/tui-windata.c (tui_display_data_from): Remove.
 603         (tui_data_window::refresh_all): Update.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 608         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 609         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 610         tui_display_registers_from_line.
 611         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 612         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 613         "force_display" parameter.
 614
 615 2019-07-17  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 618         declare.
 619         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 620         Rename from tui_first_reg_element_no_inline.
 621         (tui_display_reg_element_at_line)
 622         (tui_display_registers_from_line): Update.
 623         * tui/tui-data.h (struct tui_data_window)
 624         <first_reg_element_no_inline>: New method.
 625
 626 2019-07-17  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-windata.c (tui_display_data_from)
 629         (tui_data_window::do_scroll_vertical): Update.
 630         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 631         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 632         Rename from tui_line_from_reg_element_no.
 633         (tui_display_registers_from_line): Update.
 634         * tui/tui-data.h (struct tui_data_window)
 635         <line_from_reg_element_no>: New method.
 636
 637 2019-07-17  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 640         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 641         tui_last_regs_line_no.
 642         (tui_display_reg_element_at_line)
 643         (tui_display_registers_from_line): Update.
 644         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 645         method.
 646
 647 2019-07-17  Tom Tromey  <tom@tromey.com>
 648
 649         PR tui/24722:
 650         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 651         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 652         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 653         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 654         (tui_update_breakpoint_info): Likewise.
 655         * tui/tui-hooks.c (tui_event_create_breakpoint)
 656         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 657         Update.
 658
 659 2019-07-17  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-winsource.c (tui_update_source_window_as_is)
 666         (tui_update_source_windows_with_addr): Update.
 667         * tui/tui-source.h (tui_set_source_content)
 668         (tui_show_symtab_source): Add "win_info" parameter.
 669         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 670         parameter.
 671         (tui_show_symtab_source): Likewise.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-wingeneral.c
 676         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 677
 678 2019-07-17  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 681         (struct tui_cmd_window) <can_scroll>: New method.
 682         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 683         method.
 684
 685 2019-07-17  Tom Tromey  <tromey@adacore.com>
 686
 687         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 688         do_field_signed>: Rename.  Change type of "value".
 689         * ui-out.c (ui_out::field_signed): Rename from field_int.
 690         Change type of "value".
 691         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 692         type of "value".
 693         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 694         do_field_int.  Change type of "value".
 695         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 696         do_field_int.  Change type of "value".
 697         * tracepoint.c (trace_status_mi, tfind_1)
 698         (print_one_static_tracepoint_marker): Update.
 699         * thread.c (print_thread_info_1, print_selected_thread_frame):
 700         Update.
 701         * stack.c (print_frame, print_frame_info): Update.
 702         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 703         Update.
 704         * source.c (print_source_lines_base): Update.
 705         * skip.c (info_skip_command): Update.
 706         * record-btrace.c (btrace_ui_out_decode_error)
 707         (btrace_call_history_src_line): Update.
 708         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 709         Update.
 710         * progspace.c (print_program_space): Update.
 711         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 712         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 713         do_field_int.  Change type of "value".
 714         * mi/mi-out.c (mi_ui_out::do_table_begin)
 715         (mi_ui_out::do_table_header): Update.
 716         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 717         type of "value".
 718         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 719         (mi_cmd_data_list_changed_registers, output_register)
 720         (mi_cmd_data_read_memory, mi_load_progress)
 721         (mi_cmd_trace_frame_collected): Update.
 722         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 723         Update.
 724         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 725         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 726         (mi_cmd_var_list_children, varobj_update_one): Update.
 727         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 728         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 729         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 730         * inferior.c (print_inferior): Update.
 731         * gdb_bfd.c (print_one_bfd): Update.
 732         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 733         Update.
 734         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 735         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 736         do_field_int.  Change type of "value".
 737         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 738         do_field_int.  Change type of "value".
 739         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 740         (print_one_breakpoint_location, print_it_catch_fork)
 741         (print_one_catch_fork, print_it_catch_vfork)
 742         (print_one_catch_vfork, print_it_catch_solib)
 743         (print_it_catch_exec, print_it_ranged_breakpoint)
 744         (print_mention_watchpoint, print_mention_masked_watchpoint)
 745         (bkpt_print_it, update_static_tracepoint): Update.
 746         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 747         * break-catch-syscall.c (print_it_catch_syscall): Update.
 748         * ada-tasks.c (print_ada_task_info): Update.
 749         * ada-lang.c (print_it_exception, print_mention_exception):
 750         Update.
 751
 752 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         PR breakpoints/24541
 755         * gdbarch.c: Regenerate.
 756         * gdbarch.h: Regenerate.
 757         * gdbarch.sh: Adjust return type and parameter types for
 758         'stap_adjust_register'.
 759         (i386_stap_adjust_register): Adjust signature and return new
 760         register name.
 761         * stap-probe.c (stap_parse_register_operand): Adjust use of
 762         'gdbarch_stap_adjust_register'.
 763
 764 2019-07-17  Tom Tromey  <tromey@adacore.com>
 765
 766         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 767         declare VEC.
 768         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 769         std::vector.
 770         (struct s390_process_info): Add initializers.
 771         (s390_add_process): Use new.
 772         (s390_linux_nat_target::low_forget_process): Use delete.
 773         (s390_linux_nat_target::low_new_fork)
 774         (s390_linux_nat_target::stopped_by_watchpoint)
 775         (s390_linux_nat_target::low_prepare_to_resume)
 776         (s390_linux_nat_target::insert_watchpoint)
 777         (s390_linux_nat_target::insert_hw_breakpoint)
 778         (s390_linux_nat_target::remove_watchpoint)
 779         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 780
 781 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 782
 783         * aarch64-fbsd-nat.c: Include regcache.h.
 784         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 785         argument.
 786         (aarch64_fbsd_nat_target::fetch_registers)
 787         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 788         variable.
 789         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 790
 791 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 792
 793         * fbsd-nat.c: Include gdbarch.h.
 794
 795 2019-07-15  Tom Tromey  <tromey@adacore.com>
 796
 797         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 798
 799 2019-07-15  Tom Tromey  <tromey@adacore.com>
 800
 801         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 802         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 803         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 804         * cli-out.c (cli_ui_out::do_field_int): New method.
 805         * ui-out.c (ui_out::field_unsigned): New method.
 806         * symfile.c (generic_load): Use field_unsigned.
 807         (print_transfer_performance): Likewise.
 808         * record-btrace.c (ui_out_field_uint): Remove.
 809         (btrace_call_history_insn_range, btrace_call_history): Use
 810         field_unsigned.
 811         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 812         field_unsigned.
 813         * ui-out.h (class ui_out) <field_unsigned>: New method.
 814         <do_field_unsigned>: Likewise.
 815
 816 2019-07-15  Tom Tromey  <tromey@adacore.com>
 817
 818         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 819         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 820         * target.c (flash_erase_command): Use field_string.
 821         * infrun.c (print_signal_received_reason): Use field_string.
 822         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 823         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 824         field_string.
 825         * ada-tasks.c (print_ada_task_info): Use field_string.
 826
 827 2019-07-15  Tom Tromey  <tromey@adacore.com>
 828
 829         * target.c (flash_erase_command): Use field_core_addr.
 830         * symfile.c (generic_load): Use field_core_addr.
 831         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 832         Use field_core_addr.
 833         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 834         field_core_addr.
 835
 836 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 839         value if its desired type is smaller than a CORE_ADDR and signed.
 840
 841 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 842
 843         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 844         of changes to field names, and use new is_reference field to
 845         decide if a property is a reference or not.
 846         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 847         field.
 848         (struct dwarf2_property_baton): Update header comment, rename
 849         'referenced_type' to 'property_type' and update comments.
 850         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 851         default property type, store in property baton, update to take
 852         accound of renamed field.
 853         (read_func_scope): Update call to attr_to_dynamic_prop.
 854         (read_array_type): Likewise.
 855         (dwarf2_per_cu_addr_sized_int_type): New function.
 856         (read_subrange_index_type): Move type finding code to
 857         dwarf2_per_cu_addr_sized_int_type.
 858         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 859         (dwarf2_per_cu_addr_type): New function.
 860         (set_die_type): Update calls to attr_to_dynamic_prop.
 861
 862 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * dwarf2read.c (read_subrange_index_type): New function.
 865         (read_subrange_type): Move code into new function and call it.
 866         * gdbtypes.c (create_range_type): Add some asserts.
 867
 868 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 871         update return statements.
 872         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 873         declaration, and update comment to match.
 874         * gdbtypes.c (resolve_dynamic_array): Update call to
 875         dwarf2_evaluate_property to match new return type.
 876
 877 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * valarith.c (value_subscripted_rvalue): Change lowerbound
 880         parameter type from int to LONGEST.
 881         * value.h (value_subscripted_rvalue): Likewise in declaration.
 882
 883 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 884
 885         * cli/cli-utils.c (info_print_command_completer): New function.
 886         * cli/cli-utils.h: Add 'completer.h' include, and forward
 887         declaration for 'struct cmd_list_element'.
 888         (info_print_command_completer): Declare.
 889         * stack.c (_initialize_stack): Add completer for 'info locals' and
 890         'info args'.
 891         * symtab.c (_initialize_symtab): Add completer for 'info
 892         variables' and 'info functions'.
 893         * NEWS: Mention completion for additional info commands.
 894
 895 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         * cli/cli-utils.c (extract_info_print_args): Delete.
 898         (extract_arg_maybe_quoted): Delete.
 899         (info_print_options_defs): New variable.
 900         (make_info_print_options_def_group): New function.
 901         (extract_info_print_options): Define new function.
 902         * cli/cli-utils.h (extract_info_print_args): Delete.
 903         (struct info_print_options): New structure.
 904         (extract_info_print_options): Declare new function.
 905         * stack.c (info_locals_command): Update to use new
 906         extract_info_print_options, also add a header comment.
 907         (info_args_command): Likewise.
 908         * symtab.c (info_variables_command): Likewise.
 909         (info_functions_command): Likewise.
 910
 911 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 914         to extract string arguments.
 915         * common/common-utils.c (extract_string_maybe_quoted): New function.
 916         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 917
 918 2019-07-11  Tom Tromey  <tromey@adacore.com>
 919
 920         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 921         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 922         * top.h (gdbinit): Don't declare.
 923         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 924         into...
 925         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 926         * top.c (gdb_init): Don't call init_cli_cmds.
 927         (gdbinit): Remove.
 928         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 929
 930 2019-07-11  Tom Tromey  <tromey@adacore.com>
 931
 932         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 933         after it has been moved.
 934
 935 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 936
 937         * valops.c (value_must_coerce_to_target): Change return type to
 938         bool.
 939         * value.h (value_must_coerce_to_target): Likewise.
 940
 941 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 942
 943         * breakpoint.c (is_hardware_watchpoint): Remove
 944         forward-declaration.
 945         (is_masked_watchpoint): Change return type to bool.
 946         (is_tracepoint): Likewise.
 947         (is_breakpoint): Likewise.
 948         (is_hardware_watchpoint): Likewise.
 949         (is_watchpoint): Likewise.
 950         (is_no_memory_software_watchpoint): Likewise.
 951         (is_catchpoint): Likewise.
 952         (breakpoint_1): Make FILTER parameter's return type bool.
 953         is_masked_watchpoint): Change return type to bool.
 954         (save_breakpoints): Make FILTER parameter's return type bool.
 955         * breakpoint.h (is_breakpoint): Change return type to bool.
 956         (is_watchpoint): Likewise.
 957         (is_catchpoint): Likewise.
 958         (is_tracepoint): Likewise.
 959
 960 2019-07-10  Tom Tromey  <tom@tromey.com>
 961
 962         * defs.h: Don't include gdbarch.h.
 963         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 964         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 965         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 966         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 967         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 968         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 969         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 970         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 971         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 972         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 973         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 974         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 975         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 976         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 977         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 978         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 979         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 980         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 981         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 982         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 983         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 984         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 985         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 986         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 987         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 988         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 989         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 990
 991 2019-07-10  Tom Tromey  <tromey@adacore.com>
 992
 993         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 994         * breakpoint.c (init_ada_exception_breakpoint): Register as
 995         bp_catchpoint.
 996         (print_one_breakpoint_location, print_one_breakpoint): Use
 997         is_ada_exception_catchpoint.
 998         * ada-lang.c (class ada_catchpoint_location): Pass
 999         bp_loc_software_breakpoint to bp_location constructor.
1000         (is_ada_exception_catchpoint): New function.
1001
1002 2019-07-10  Tom Tromey  <tromey@adacore.com>
1003
1004         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1005         VEC.
1006         (struct arm_exidx_entry): New method operator<.
1007         (struct arm_exidx_data) <section_maps>: Change type.
1008         (arm_exidx_data_free): Remove.
1009         (arm_exidx_data_key): Change type.  Move lower.
1010         (arm_exidx_new_objfile): Update.
1011         (arm_compare_exidx_entries): Remove.
1012         (arm_find_exidx_entry, _initialize_arm_tdep)
1013
1014 2019-07-10  Tom Tromey  <tromey@adacore.com>
1015
1016         * solib-spu.c (ocl_program_data_key): Change type.
1017         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1018         Update.
1019
1020 2019-07-10  Tom Tromey  <tromey@adacore.com>
1021
1022         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1023         (struct solib_aix_inferior_data) <library_list>: Change type.
1024         (solib_aix_inferior_data_handle): Change type.
1025         (get_solib_aix_inferior_data): Update.
1026         (solib_aix_free_library_list): Remove.
1027         (library_list_start_library): Update.
1028         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1029         return type.
1030         (solib_aix_get_library_list)
1031         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1032         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1033
1034 2019-07-10  Tom Tromey  <tromey@adacore.com>
1035
1036         * solib-dsbt.c (struct dsbt_info): Add initializers.
1037         (solib_dsbt_pspace_data): Change type.
1038         (dsbt_pspace_data_cleanup): Remove.
1039         (get_dsbt_info, _initialize_dsbt_solib): Update.
1040
1041 2019-07-10  Tom Tromey  <tromey@adacore.com>
1042
1043         * spu-tdep.c (spu_overlay_data): Change type.
1044         (spu_get_overlay_table, spu_overlay_new_objfile)
1045         (_initialize_spu_tdep): Update.
1046
1047 2019-07-10  Tom Tromey  <tromey@adacore.com>
1048
1049         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1050         destructor.
1051         (dbx_objfile_data_key): Change type and declare later.
1052         (DBX_SYMFILE_INFO): Rewrite.
1053         * dbxread.c (dbx_objfile_data_key): Change type.
1054         (dbx_symfile_init): Update.
1055         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1056         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1057         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1058
1059 2019-07-10  Tom Tromey  <tromey@adacore.com>
1060
1061         * jit.c (jit_program_space_key): Change type.  Move lower.
1062         (get_jit_program_space_data): Update.
1063         (jit_program_space_data_cleanup): Remove.
1064         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1065         Update.
1066         (struct jit_program_space_data): Add initializers.
1067
1068 2019-07-10  Tom Tromey  <tromey@adacore.com>
1069
1070         * solib-darwin.c (struct darwin_info): Add initializers.
1071         (solib_darwin_pspace_data): Change type.
1072         (darwin_pspace_data_cleanup): Remove.
1073         (get_darwin_info, _initialize_darwin_solib): Update.
1074
1075 2019-07-10  Tom Tromey  <tromey@adacore.com>
1076
1077         * remote-sim.c (struct sim_inferior_data): Add initializers,
1078         constructor, and destructor.
1079         (sim_inferior_data_key): Change type.  Move lower.
1080         (check_for_duplicate_sim_descriptor): Update.
1081         (get_sim_inferior_data): Use new.  Update.
1082         (~sim_inferior_data_cleanup): Rename from
1083         sim_inferior_data_cleanup.  Simplify.
1084         (gdbsim_close_inferior, simulator_command)
1085         (sim_command_completer, _initialize_remote_sim): Update.
1086         (next_pid, INITIAL_PID): Move earlier.
1087
1088 2019-07-10  Tom Tromey  <tromey@adacore.com>
1089
1090         * python/python-internal.h (create_thread_object): Return
1091         gdbpy_ref.
1092         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1093         * python/py-inferior.c (struct threadlist_entry): Add
1094         constructor.
1095         <thread_obj>: Now a gdbpy_ref.
1096         (thread_to_thread_object): Update.
1097         (add_thread_object): Use new.
1098         (delete_thread_object): Use delete.
1099         (infpy_threads): Update.
1100         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1101         GIL.
1102
1103 2019-07-10  Tom Tromey  <tromey@adacore.com>
1104
1105         * valops.c (value_cast): Specialize error message for Ada.
1106
1107 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1108
1109         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1110
1111 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1112
1113         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1114         bpstat_should_step): Return bool, adjust comments.
1115         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1116         bpstat_should_step): Likewise.
1117
1118 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1119
1120         * features/Makefile: Use feature target descriptions for Arm.
1121         * features/arm/arm-core.c: Generate new file.
1122         * features/arm/arm-fpa.c: Likewise.
1123         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1124         * features/arm/arm-m-profile.c: Likewise.
1125         * features/arm/arm-vfpv2.c: Likewise.
1126         * features/arm/arm-vfpv3.c: Likewise.
1127         * features/arm/xscale-iwmmxt.c: Likewise.
1128         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1129
1130 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1131
1132         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1133         ptrace earlier.
1134
1135 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1136
1137         * features/aarch64-pauth.c: Regenerate.
1138
1139 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1140
1141         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1142         bool.
1143         (bpstat_what): Use false instead of 0.
1144
1145 2019-07-09  Pedro Alves  <palves@redhat.com>
1146
1147         * break-catch-throw.c (is_exception_catchpoint): New.
1148         * breakpoint.c (print_one_breakpoint_location): New parameter
1149         'raw_loc'.  Handle it.  Use
1150         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1151         looking at the breakpoint's type.
1152         (print_one_breakpoint): If handling "maint info breakpoints", also
1153         print locations of exception catchpoints.
1154         * breakpoint.h (is_exception_catchpoint): Declare.
1155
1156 2019-07-09  Pedro Alves  <palves@redhat.com>
1157
1158         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1159         "addr" field.
1160         (allocate_location_exception_catchpoint): New.
1161         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1162         (initialize_throw_catchpoint_ops): Install
1163         allocate_location_exception_catchpoint as allocate_location
1164         method.
1165         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1166         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1167         bp_loc_other.
1168         (breakpoint_address_is_meaningful): Delete.
1169         (bl_address_is_meaningful): New.
1170         (breakpoint_locations_match): Adjust comment.
1171         (bp_location_from_bp_type): New, factored out of...
1172         (bp_location::bp_location(breakpoint *)): ... this.
1173         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1174         factored out of...
1175         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1176         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1177         breakpoint_address_is_meaningful.
1178         (bp_locations_compare): Adjust comment.
1179         (update_global_location_list): Use bl_address_is_meaningful
1180         instead of breakpoint_address_is_meaningful.
1181         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1182         explicit.
1183         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1184         * python/py-breakpoint.c (bppy_get_location): No longer check
1185         whether location is null.
1186
1187 2019-07-09  Pedro Alves  <palves@redhat.com>
1188
1189         PR c++/15468
1190         * breakpoint.c (print_one_breakpoint_location): Remove
1191         single-location assert.
1192
1193 2019-07-09  Tom Tromey  <tom@tromey.com>
1194
1195         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1196         * configure: Rebuild.
1197         * configure.ac: Change common to gdbsupport.
1198         * gdbsupport: Rename from common.
1199         * acinclude.m4: Change common to gdbsupport.
1200         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1201         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1202         gdbsupport.
1203         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1204         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1205         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1206         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1207         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1208         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1209         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1210         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1211         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1212         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1213         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1214         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1215         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1216         coff-pe-read.c, command.h, compile/compile-c-support.c,
1217         compile/compile-c.h, compile/compile-cplus-symbols.c,
1218         compile/compile-cplus-types.c, compile/compile-cplus.h,
1219         compile/compile-loc2c.c, compile/compile.c, completer.c,
1220         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1221         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1222         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1223         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1224         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1225         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1226         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1227         features/aarch64-core.c, features/aarch64-fpu.c,
1228         features/aarch64-pauth.c, features/aarch64-sve.c,
1229         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1230         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1231         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1232         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1233         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1234         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1235         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1236         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1237         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1238         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1239         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1240         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1241         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1242         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1243         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1244         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1245         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1246         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1247         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1248         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1249         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1250         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1251         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1252         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1253         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1254         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1255         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1256         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1257         minsyms.c, mips-linux-tdep.c, namespace.h,
1258         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1259         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1260         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1261         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1262         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1263         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1264         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1265         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1266         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1267         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1268         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1269         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1270         procfs.c, producer.c, progspace.h, psymtab.h,
1271         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1272         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1273         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1274         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1275         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1276         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1277         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1278         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1279         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1280         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1281         target-memory.c, target.c, target.h, target/waitstatus.c,
1282         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1283         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1284         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1285         unittests/array-view-selftests.c,
1286         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1287         unittests/common-utils-selftests.c,
1288         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1289         unittests/format_pieces-selftests.c,
1290         unittests/function-view-selftests.c,
1291         unittests/lookup_name_info-selftests.c,
1292         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1293         unittests/mkdir-recursive-selftests.c,
1294         unittests/observable-selftests.c,
1295         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1296         unittests/parse-connection-spec-selftests.c,
1297         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1298         unittests/scoped_fd-selftests.c,
1299         unittests/scoped_mmap-selftests.c,
1300         unittests/scoped_restore-selftests.c,
1301         unittests/string_view-selftests.c, unittests/style-selftests.c,
1302         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1303         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1304         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1305         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1306         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1307         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1308
1309 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1312         bool value.
1313         (decode_digits_ordinary): Set explicit_line field in sal.
1314         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1315         symtab_and_line that was set on an explicit line number in
1316         assembler code.  Do always update the recorded symtab and line if
1317         we do skip the prologue.
1318
1319 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * breakpoint.c (set_breakpoint_location_function): Remove
1322         explicit_loc parameter.
1323         (momentary_breakpoint_from_master): Update call to
1324         set_breakpoint_location_function.
1325         (add_location_to_breakpoint): Likewise.
1326
1327 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1328
1329         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1330         required features based on default bfd type when no specific bfd
1331         is present.
1332
1333 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1334
1335         * NEWS: Mention that GDB printf and eval commands can now print
1336         C-style and Ada-style convenience var strings without
1337         calling the inferior.
1338         * printcmd.c (printf_c_string): Locally print GDB internal var
1339         instead of transiting via the inferior.
1340         (printf_wide_c_string): Likewise.
1341
1342 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1343
1344         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1345
1346 2019-07-04  Tom Tromey  <tom@tromey.com>
1347
1348         PR tui/24724:
1349         * tui/tui-winsource.c (tui_clear_source_content): Update.
1350         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1351         (tui_update_breakpoint_info): Update.
1352         (tui_set_exec_info_content): Update.
1353         * tui/tui-source.c (tui_set_source_content_nil): Update.
1354         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1355         has_break.
1356         * tui/tui-data.h (enum tui_bp_flag): New.
1357         (tui_bp_flags): New enum flags type.
1358         (struct tui_source_element) <break_mode>: Change type.  Rename
1359         from has_break.
1360         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1361         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1362         constants.
1363         * tui/tui-winsource.h: Fix comment.
1364
1365 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1366
1367         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1368         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1369         (store_fpregs_to_thread)
1370         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1371         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1372         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1373         (IWMMXT_REGS_SIZE): Add define.
1374         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1375         (fetch_vfp_regs, store_vfp_regs)
1376         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1377         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1378
1379 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1380
1381         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1382         defines.
1383         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1384         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1385         (ARM_INT_REGISTER_SIZE): ...to this.
1386         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1387         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1388         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1389         (arm_linux_collect_gregset, supply_nwfpe_register)
1390         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1391         defines.
1392         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1393         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1394         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1395         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1396         (arm_return_in_memory, arm_store_return_value)
1397         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1398         (arm_record_ld_st_multiple): Likewise.
1399         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1400         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1401
1402 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1403
1404         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1405         AARCH64_DISPLACED_MODIFIED_INSNS.
1406         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1407         (aarch64_displaced_step_copy_insn): Likewise.
1408         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1409         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1410         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1411         ARM_DISPLACED_MODIFIED_INSNS.
1412         * arm-tdep.c (arm_gdbarch_init): Likewise.
1413         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1414         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1415         (struct arm_displaced_step_closure): Use
1416         ARM_DISPLACED_MODIFIED_INSNS.
1417
1418 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1419
1420         * features/Makefile: Remove unused xml files.
1421         * features/aarch64.xml: Remove.
1422         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1423         * features/i386/amd64-avx-avx512.xml: Remove.
1424         * features/i386/amd64-avx-linux.xml: Remove.
1425         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1426         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1427         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1428         * features/i386/amd64-avx-mpx.xml: Remove.
1429         * features/i386/amd64-avx.xml: Remove.
1430         * features/i386/amd64-linux.xml: Remove.
1431         * features/i386/amd64-mpx-linux.xml: Remove.
1432         * features/i386/amd64-mpx.xml: Remove.
1433         * features/i386/amd64.xml: Remove.
1434         * features/i386/i386-avx-avx512-linux.xml: Remove.
1435         * features/i386/i386-avx-avx512.xml: Remove.
1436         * features/i386/i386-avx-linux.xml: Remove.
1437         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1438         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1439         * features/i386/i386-avx-mpx-linux.xml: Remove.
1440         * features/i386/i386-avx-mpx.xml: Remove.
1441         * features/i386/i386-avx.xml: Remove.
1442         * features/i386/i386-linux.xml: Remove.
1443         * features/i386/i386-mmx-linux.xml: Remove.
1444         * features/i386/i386-mmx.xml: Remove.
1445         * features/i386/i386-mpx-linux.xml: Remove.
1446         * features/i386/i386-mpx.xml: Remove.
1447         * features/i386/i386.xml: Remove.
1448         * features/i386/x32-avx-avx512-linux.xml: Remove.
1449         * features/i386/x32-avx-linux.xml: Remove.
1450         * features/i386/x32-linux.xml: Remove.
1451
1452 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1453
1454         * regformats/aarch64.dat: Remove.
1455         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1456         * regformats/i386/amd64-avx-linux.dat: Remove.
1457         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1458         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1459         * regformats/i386/amd64-linux.dat: Remove.
1460         * regformats/i386/amd64-mpx-linux.dat: Remove.
1461         * regformats/i386/amd64.dat: Remove.
1462         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1463         * regformats/i386/i386-avx-linux.dat: Remove.
1464         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1465         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1466         * regformats/i386/i386-linux.dat: Remove.
1467         * regformats/i386/i386-mmx-linux.dat: Remove.
1468         * regformats/i386/i386-mpx-linux.dat: Remove.
1469         * regformats/i386/i386.dat: Remove.
1470         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1471         * regformats/i386/x32-avx-linux.dat: Remove.
1472         * regformats/i386/x32-linux.dat: Remove.
1473
1474 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1475
1476         * aarch64-tdep.c: Remove xml self tests.
1477         * amd64-linux-tdep.c: Likewise.
1478         * amd64-tdep.c: Likewise.
1479         * i386-linux-tdep.c: Likewise.
1480         * i386-tdep.c: Likewise.
1481
1482 2019-07-03  Pedro Alves  <palves@redhat.com>
1483
1484         PR cli/24732
1485         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1486         (pipe_cmd_option_defs): New.
1487         (make_pipe_cmd_options_def_group): New.
1488         (pipe_command): Use gdb::option::process_options.
1489         (pipe_command_completer): New function.
1490         (_initialize_cli_cmds): Install completer for "pipe" command.
1491
1492 2019-07-03  Pedro Alves  <palves@redhat.com>
1493
1494         * cli/cli-option.c (union option_value) <string>: New field.
1495         (struct option_def_and_value): Add ctor, move ctor, dtor and
1496         use DISABLE_COPY_AND_ASSIGN.
1497         (option_def_and_value::clear_value): New.
1498         (parse_option, save_option_value_in_ctx, get_val_type_str)
1499         (add_setshow_cmds_for_options): Handle var_string.
1500         * cli-option.h (union option_def::var_address) <string>: New
1501         field.
1502         (struct string_option_def): New.
1503         * maint-test-options.c (struct test_options_opts): Add default
1504         ctor and use DISABLE_COPY_AND_ASSIGN.
1505         <string_opt>: New field.
1506         (test_options_opts::~test_options_opts): New.
1507         (test_options_opts::dump): Also dump "-string".
1508         (test_options_option_defs): Install "string.
1509
1510 2019-07-03  Pedro Alves  <palves@redhat.com>
1511
1512         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1513         option_value with a null enumeration.
1514         (complete_options): Save the option values in the context.
1515         (save_option_value_in_ctx): New, factored out from ...
1516         (process_options): ... here.
1517         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1518         of the function.
1519         * maint-test-options.c (test_options_opts::dump): New, factored
1520         out from ...
1521         (maintenance_test_options_command_mode): ... here.
1522         (maintenance_test_options_command_completion_result): Delete.
1523         (maintenance_test_options_command_completion_text): Update
1524         comment.
1525         (maintenance_show_test_options_completion_result): Change
1526         prototype.  Just print
1527         maintenance_test_options_command_completion_text.
1528         (save_completion_result): New.
1529         (maintenance_test_options_completer_mode): Pass options context to
1530         complete_options, and then save a dump.
1531         (_initialize_maint_test_options): Use add_cmd to install "maint
1532         show test-options-completion-result".
1533
1534 2019-07-03  Pedro Alves  <palves@redhat.com>
1535
1536         * NEWS (New commands): Mention "with" and "maint with".
1537         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1538         (with_command, with_command_completer): New.
1539         (pipe_command): Adjust to new repeat_previous
1540         interface.
1541         (_initialize_cli_cmds): Install the "with" command and its "w"
1542         alias.
1543         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1544         declarations.
1545         * cli/cli-setshow.c (parse_cli_var_uinteger)
1546         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1547         argument strings for all var_types.
1548         (get_setshow_command_value_string): New, factored out from ...
1549         (do_show_command): ... this.
1550         * cli/cli-setshow.h: Include <string>.
1551         (get_setshow_command_value_string): Declare.
1552         * command.h (repeat_previous): Now returns const char *.  Adjust
1553         comment.
1554         * maint.c: Include "cli/cli-cmds.h".
1555         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1556         (_initialize_maint_cmds): Register the "maintenance with" command.
1557         * top.c (repeat_previous): Move bits from pipe_command here:
1558         Return the saved command line, if any; error out if there's no
1559         command to relaunch.
1560
1561 2019-07-03  Pedro Alves  <palves@redhat.com>
1562
1563         * NEWS (New commands): Mention "maint set/show test-settings"
1564         instead of "maint test-settings".
1565         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1566         (maintenance_test_settings_set_list): Rename to ...
1567         (maintenance_set_test_settings_list): ... this.
1568         (maintenance_test_settings_show_list): Rename to  ...
1569         (maintenance_show_test_settings_list): ... this.
1570         (maintenance_test_settings_cmd): Delete.
1571         (maintenance_test_settings_set_cmd): ...
1572         (maintenance_set_test_settings_cmd): ... this.
1573         (maintenance_test_settings_show_cmd): ...
1574         (maintenance_show_test_settings_cmd): ... this.
1575         (maintenance_test_settings_show_value_cmd):
1576         (maintenance_show_test_settings_value_cmd): ... this.
1577         (_initialize_maint_test_settings): No longer install the "maint
1578         test-settings" prefix command.  Rename "maint test-settings set"
1579         to "maint set test-settings", and "maint test-settings show" to
1580         "maint show test-settings".  Adjust all subcommands.
1581
1582 2019-07-03  Pedro Alves  <palves@redhat.com>
1583
1584         * maint-test-settings.c: Fix file's intro comment.  Replace all
1585         references to "test-options" with references to "test-settings",
1586         in comments.
1587
1588 2019-07-03  Pedro Alves  <palves@redhat.com>
1589
1590         * maint-test-settings.c (maintenance_test_settings_xxx)
1591         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1592         New.
1593         (maintenance_test_settings_enums): Use them.
1594         (maintenance_test_settings_enum): Default to
1595         maintenance_test_settings_xxx.
1596         (_initialize_maint_test_settings): Initialize
1597         MAINTENANCE_TEST_SETTINGS_FILENAME.
1598
1599 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1600
1601         * breakpoint.h (remove_breakpoints_inf): Change return type to
1602         void, move function documentation here.
1603         * breakpoint.c (remove_breakpoints_inf): Change return type to
1604         void, move function documentation to header.
1605
1606 2019-07-02  Pedro Alves  <palves@redhat.com>
1607
1608         * NEWS (Completion improvements): Mention "info threads".
1609         * thread.c (struct info_threads_opts, info_threads_option_defs)
1610         (make_info_threads_options_def_group): New.
1611         (info_threads_command): Use gdb::option::process_options.
1612         (info_threads_command_completer): New.
1613         (_initialize_thread): Use gdb::option::build_help to build the
1614         help text for "info threads".
1615
1616 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1617
1618         * defs.h (generic_load): Move from here...
1619         * symfile.h (generic_load): ... to here.  Rename name parameter
1620         to args.
1621         * symfile.c (generic_load): Add comment.
1622
1623 2019-07-01  Tom Tromey  <tromey@adacore.com>
1624
1625         * dwarf2read.c
1626         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1627         declaration of without_params.  Fix formatting.
1628
1629 2019-07-01  Tom Tromey  <tromey@adacore.com>
1630
1631         * ada-exp.y (find_primitive_type): Update.
1632         * ada-lang.h (ada_lookup_symbol): Update.
1633         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1634         parameter.
1635         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1636
1637 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1638
1639         PR breakpoints/24541
1640         * gdbarch.c: Regenerate.
1641         * gdbarch.h: Regenerate.
1642         * gdbarch.sh: Add 'stap_adjust_register'.
1643         * i386-tdep.c: Include '<unordered_set>'.
1644         (i386_stap_adjust_register): New function.
1645         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1646         * stap-probe.c (stap_parse_register_operand): Call
1647         'gdbarch_stap_adjust_register'.
1648
1649 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1650
1651         PR python/24742
1652         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1653         * python/python.c (do_start_initialization): Use 'xmalloc'
1654         instead of 'PyMem_Malloc'.
1655
1656 2019-06-28  Tom Tromey  <tromey@adacore.com>
1657
1658         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1659         for Ada.
1660
1661 2019-06-27  Tom Tromey  <tromey@adacore.com>
1662
1663         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1664         objfile_key.
1665         (arm_find_mapping_symbol, arm_record_special_symbol)
1666         (_initialize_arm_tdep): Update.
1667         (arm_objfile_data_free): Remove.
1668
1669 2019-06-27  Tom Tromey  <tromey@adacore.com>
1670
1671         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1672         to cp_print_static_field.
1673
1674 2019-06-26  Tom Tromey  <tromey@adacore.com>
1675
1676         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1677         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1678         declare.
1679
1680 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1681
1682         * features/aarch64-core.c (create_feature_aarch64_core):
1683         Regenerate.
1684         * features/aarch64-core.xml: Add cpsr flags.
1685
1686 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1687
1688         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1689         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1690
1691 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1692
1693         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1694         field.
1695         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1696         use.
1697         (arm_record_special_symbol): Don't insert new symbol in sorted
1698         position, push it at the end.
1699
1700 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1701
1702         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1703         (arm_mapping_symbol_s): Remove.
1704         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1705         (arm_mapping_symbol_vec): New typedef.
1706         (struct arm_per_objfile): Add constructor.
1707         <section_maps>: Change type to
1708         std::unique_ptr<arm_mapping_symbol_vec[]>.
1709         (arm_compare_mapping_symbols): Remove.
1710         (arm_find_mapping_symbol): Adjust to section_maps type change.
1711         (arm_objfile_data_free): Call delete on arm_per_objfile.
1712         (arm_record_special_symbol): Adjust to section_maps type change.
1713         Allocate arm_per_objfile with new.
1714
1715 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1716
1717         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1718         with the command prefix.
1719
1720 2019-06-25  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1723         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1728         type.
1729         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1730         protected.
1731
1732 2019-06-25  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-winsource.c
1735         (tui_source_window_base::set_is_exec_point_at): Add check against
1736         LOA_ADDRESS.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-source.c (tui_set_source_content): Don't check before
1741         xfree.
1742         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1743
1744 2019-06-25  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-winsource.h (tui_update_source_window_as_is)
1747         (tui_alloc_source_buffer, tui_line_is_displayed)
1748         (tui_addr_is_displayed): Change type of win_info.
1749         * tui/tui-winsource.c (tui_update_source_window_as_is)
1750         (tui_clear_source_content, tui_show_source_line)
1751         (tui_show_source_content, tui_source_window_base::refill)
1752         (tui_source_window_base::set_is_exec_point_at)
1753         (tui_source_window_base::set_is_exec_point_at)
1754         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1755         (tui_alloc_source_buffer, tui_line_is_displayed)
1756         (tui_addr_is_displayed): Change type of win_info.  Update.
1757         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1758         (tui_source_window_base::do_make_visible_with_new_height):
1759         Update.
1760         * tui/tui-source.c (tui_set_source_content)
1761         (tui_set_source_content_nil)
1762         (tui_source_window::do_scroll_vertical): Update.
1763         * tui/tui-layout.c (show_layout): Update.
1764         * tui/tui-disasm.c (tui_set_disassem_content)
1765         (tui_disasm_window::do_scroll_vertical): Update.
1766         * tui/tui-data.h (tui_win_content): Remove.
1767         (struct tui_gen_win_info) <content, content_size>: Remove.
1768         (struct tui_source_element): Add initializers and destructor.
1769         (union tui_which_element, struct tui_win_element): Remove.
1770         (struct tui_source_window_base) <content>: New field.
1771         (struct tui_data_window): Remove destructor.
1772         (tui_alloc_content, tui_free_win_content)
1773         (tui_free_all_source_wins_content): Don't declare.
1774         * tui/tui-data.c (tui_initialize_static_data): Update.
1775         (init_content_element, tui_alloc_content): Remove.
1776         (~tui_gen_win_info): Update.
1777         (~tui_data_window, tui_free_all_source_wins_content)
1778         (tui_free_win_content, free_content, free_content_elements):
1779         Remove.
1780
1781 2019-06-25  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-winsource.h (tui_clear_source_content)
1784         (tui_erase_source_content, tui_show_source_content): Change type
1785         of win_info.
1786         * tui/tui-winsource.c (tui_clear_source_content)
1787         (tui_erase_source_content, tui_show_source_content): Change type
1788         of win_info.
1789         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1790         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1791         win_info.
1792         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1793         win_info.
1794         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-winsource.c (tui_clear_source_content)
1799         (tui_source_window_base::set_is_exec_point_at): Update.
1800         * tui/tui-source.c (tui_set_source_content_nil): Update.
1801         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1802         a bool.
1803         * tui/tui-data.c (init_content_element): Update.
1804
1805 2019-06-25  Tom Tromey  <tom@tromey.com>
1806
1807         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1808         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1809         * tui/tui-layout.c (init_and_make_win): Update.
1810         * tui/tui.h (enum tui_win_type): Update.
1811         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1812         tui_win_is_auxillary.
1813         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1814         tui_win_is_auxillary.
1815
1816 2019-06-25  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1819         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1820         (tui_delete_data_content_windows, tui_display_all_data)
1821         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1822         Update.
1823         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1824         * tui/tui-regs.c (tui_last_regs_line_no)
1825         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1826         (tui_show_registers): Update.
1827         (tui_show_register_group): Return void.  Update.
1828         (tui_display_registers_from, tui_display_reg_element_at_line)
1829         (tui_display_registers_from_line, tui_check_register_values):
1830         Update.
1831         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1832         member.
1833         (struct tui_data_window) <regs_content>: Now a std::vector.
1834         <regs_content_count>: Remove.
1835         (tui_add_content_elements, tui_free_data_content): Don't declare.
1836         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1837         (init_content_element): Remove DATA_WIN case.  Add assert.
1838         (tui_add_content_elements): Remove.
1839         (tui_data_window): Update.
1840         (tui_free_data_content): Remove.
1841         (free_content_elements): Remove DATA_WIN case.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-data.c (tui_data_item_window): Update.
1846         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1847         * tui/tui-windata.c (tui_display_all_data)
1848         (tui_display_data_from_line): Update.
1849         (tui_check_data_values): Remove.
1850         * tui/tui-regs.c (tui_show_register_group)
1851         (tui_display_reg_element_at_line): Update.
1852         * tui/tui-hooks.c (tui_register_changed)
1853         (tui_refresh_frame_and_register_information): Call
1854         tui_check_register_values.
1855         * tui/tui-data.h (struct tui_data_window) <data_content,
1856         data_content_count, data_type>: Remove.
1857         (enum tui_data_type): Remove.
1858
1859         * tui/tui-data.c (tui_data_window::clear_detail)
1860         (~tui_data_window): Update.
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1865         declare.
1866         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1867         Rename from tui_first_data_item_displayed.  Update.
1868         (tui_data_window::refresh_all)
1869         (tui_data_window::do_scroll_vertical): Update.
1870         * tui/tui-data.h (struct tui_data_window)
1871         <first_data_item_displayed>: Declare new method.
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1876         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1877         contents...
1878         (tui_initialize_static_data): ...here.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1883         (tui_display_registers_from, tui_check_register_values): Update.
1884         (tui_display_register): Remove win_info parameter; update.
1885         (tui_get_register): Change type of parameters.
1886         * tui/tui-data.h (struct tui_data_element): Remove.
1887         (union tui_which_element) <data>: Remove.
1888         <data_window>: Change type.
1889         (struct tui_data_item_window): New.
1890         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1891         case.  Add assert.
1892         (~tui_data_item_window): New destructor.
1893         (free_content_elements): Remove DATA_ITEM_WIN case.
1894
1895 2019-06-25  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1898         Remove.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-data.h (struct tui_command_element): Remove.
1903         (union tui_which_element) <command>: Remove.
1904         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1905         assert.
1906         (free_content_elements): Remove CMD_WIN case.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-layout.c (tui_set_layout): Update.
1911         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1912         * tui/tui-data.c (layout_def): Update.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1917         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1918         (tui_source_window_base::set_new_height): Update.
1919         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1920         Update.
1921         (tui_set_locator_fullname, tui_set_locator_info)
1922         (tui_show_frame_info): Update.
1923         * tui/tui-source.c (tui_set_source_content)
1924         (tui_source_is_displayed): Update.
1925         * tui/tui-layout.c (show_source_disasm_command, show_data)
1926         (show_source_or_disasm_and_command): Update.
1927         * tui/tui-disasm.c (tui_set_disassem_content)
1928         (tui_get_begin_asm_address): Update.
1929         * tui/tui-data.h (struct tui_locator_element): Remove.
1930         (union tui_which_element) <locator>: Remove.
1931         (struct tui_locator_window): New.
1932         (tui_locator_win_info_ptr): Change return type.
1933         * tui/tui-data.c (_locator): Change type.
1934         (tui_locator_win_info_ptr): Change return type.
1935         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1936         (tui_alloc_content): Add assert.
1937
1938 2019-06-25  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-winsource.c
1941         (tui_exec_info_window::maybe_allocate_content): New method.
1942         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1943         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1944         (make_source_or_disasm_window): Add cast.
1945         * tui/tui-data.h (union tui_which_element) <simple_string>:
1946         Remove.
1947         (struct tui_source_info): New.
1948         (struct tui_source_window_base) <execution_info>: Change type.
1949         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1950         case, and add assert.
1951         (tui_alloc_content): Add assert.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1956         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1957         * tui/tui-data.c (tui_alloc_win_info): Remove.
1958
1959 2019-06-25  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1962         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1963         can_highlight.
1964
1965 2019-06-25  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1968         make_visible_with_new_height method.
1969         (tui_win_info::make_visible_with_new_height): New method.
1970         (tui_source_window_base::do_make_visible_with_new_height)
1971         (tui_data_window::do_make_visible_with_new_height)
1972         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1973         (make_visible_with_new_height): Remove.
1974         (tui_resize_all, tui_adjust_win_heights): Use
1975         make_visible_with_new_height method.
1976         * tui/tui-data.h (struct tui_win_info)
1977         <do_make_visible_with_new_height, make_visible_with_new_height>:
1978         New methods.
1979         (struct tui_source_window_base, struct tui_data_window)
1980         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1981         methods.
1982
1983 2019-06-25  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1986         method.
1987         (update_tab_width): Call update_tab_width method.
1988         * tui/tui-data.h (struct tui_win_info)
1989         (struct tui_source_window_base) <update_tab_width>: New methods.
1990
1991 2019-06-25  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1994         parameter.
1995         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1996         parameter.
1997         (tui_gen_win_info::make_visible): Update.
1998         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1999         parameter.
2000         * tui/tui-data.h (enum tui_box): New enum.
2001         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2006         init_and_make_win for EXEC_INFO_WIN.
2007         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2008         longer inline.
2009         (struct tui_win_info) <~tui_win_info>: Inline.
2010         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2011         Don't declare.
2012         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2013         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2014         Remove.
2015         (tui_initialize_static_data): Update.
2016         (~tui_gen_win_info): Handle more cleanup here.
2017         (~tui_source_window_base): Delete "execution_info".
2018         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-layout.c (make_command_window): Don't set
2023         can_highlight.
2024         (show_source_disasm_command): Call the reset method.
2025         (show_data): Don't set can_highlight.  Call the reset method.
2026         (tui_gen_win_info::reset): Rename from init_gen_win_info
2027         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2028         (show_source_or_disasm_and_command): Call the reset method.
2029         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2030         (struct tui_cmd_window): Set can_highlight.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2035         from make_visible.
2036         (tui_make_visible, tui_make_invisible): Rewrite.
2037         (tui_win_info::make_visible): Remove.
2038         (tui_source_window_base::make_visible): Update.
2039         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2040         method.  Moved from...
2041         (struct tui_win_info) <make_visible>: ...here.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-winsource.c
2046         (tui_source_window_base::do_scroll_horizontal): Remove direction
2047         parameter.
2048         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2049         direction parameter.
2050         * tui/tui-win.c (tui_win_info::forward_scroll)
2051         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2052         (tui_win_info::right_scroll): Update.
2053         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2054         direction parameter.
2055         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2056         direction parameter.
2057         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2058         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2059         Remove direction parameter.
2060         (struct tui_source_window_base, struct tui_source_window)
2061         (struct tui_disasm_window, struct tui_data_window)
2062         (struct tui_cmd_window): Update.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-winsource.h (tui_set_exec_info_content)
2067         (tui_show_exec_info_content, tui_erase_exec_info_content)
2068         (tui_clear_exec_info_content, tui_update_exec_info): Change
2069         argument to tui_source_window_base.
2070         * tui/tui-winsource.c (tui_set_exec_info_content)
2071         (tui_show_exec_info_content, tui_erase_exec_info_content)
2072         (tui_clear_exec_info_content, tui_update_exec_info): Change
2073         argument to tui_source_window_base.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2078         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2083         check.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2088         type to void.
2089         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2090         type to void.
2091         * tui/tui-source.c (tui_set_source_content): Update.
2092         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2093
2094 2019-06-25  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-win.c (window_name_completer, tui_set_focus)
2097         (tui_all_windows_info): Use name method.
2098         * tui/tui-data.h (struct tui_gen_win_info)
2099         (struct tui_source_window, struct tui_disasm_window)
2100         (struct tui_data_window, struct tui_cmd_window) <name>: New
2101         method.
2102         (tui_win_name): Don't declare.
2103         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2104         (tui_win_name): Remove.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-winsource.h (tui_update_source_window)
2109         (tui_update_source_window_as_is): Change parameter type.
2110         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2111         to be a tui_source_window_base.
2112         (tui_update_source_window_as_is): Likewise.
2113         * tui/tui-win.c (make_visible_with_new_height): Update.
2114
2115 2019-06-25  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-winsource.c (tui_erase_source_content)
2118         (tui_show_source_content, tui_show_exec_info_content)
2119         (tui_erase_exec_info_content): Use refresh_window method.
2120         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2121         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2122         from tui_refresh_win.
2123         (tui_data_window::refresh_window): New method.
2124         (tui_win_info::refresh, tui_source_window_base::refresh)
2125         (tui_refresh_all): Use refresh_window method.
2126         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2127         method.
2128         * tui/tui-regs.c (tui_display_register): Call refresh_window
2129         method.
2130         * tui/tui-layout.c (show_source_disasm_command)
2131         (show_source_or_disasm_and_command): Call refresh_window method.
2132         * tui/tui-data.h (struct tui_gen_win_info)
2133         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2134         New method.
2135
2136 2019-06-25  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui.c (tui_rl_other_window, tui_enable)
2139         (tui_is_window_visible, tui_get_command_dimension): Update.
2140         * tui/tui-winsource.c (tui_update_source_window_as_is)
2141         (tui_clear_source_content, tui_erase_source_content)
2142         (tui_show_source_line, tui_source_window_base::refill)
2143         (tui_source_window_base::do_scroll_horizontal)
2144         (tui_source_window_base::set_is_exec_point_at)
2145         (tui_update_breakpoint_info, tui_set_exec_info_content)
2146         (tui_alloc_source_buffer, tui_line_is_displayed)
2147         (tui_addr_is_displayed): Update.
2148         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2149         (tui_check_and_display_highlight_if_needed)
2150         (tui_win_info::make_visible, tui_win_info::refresh)
2151         (tui_refresh_all): Update.
2152         * tui/tui-windata.c (tui_first_data_item_displayed)
2153         (tui_delete_data_content_windows, tui_erase_data_content)
2154         (tui_display_all_data, tui_data_window::refresh_all)
2155         (tui_check_data_values): Update.
2156         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2157         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2158         (tui_win_info::backward_scroll, tui_refresh_all_win)
2159         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2160         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2161         (tui_source_window_base::set_new_height)
2162         (tui_data_window::set_new_height)
2163         (make_invisible_and_set_new_height)
2164         (make_visible_with_new_height, new_height_ok)
2165         (parse_scrolling_args): Update.
2166         * tui/tui-stack.c (tui_show_frame_info): Update.
2167         * tui/tui-source.c (tui_set_source_content)
2168         (tui_set_source_content_nil, tui_source_is_displayed)
2169         (tui_source_window::do_scroll_vertical): Update.
2170         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2171         (tui_display_registers_from, tui_display_reg_element_at_line)
2172         (tui_check_register_values, tui_reg_command): Update.
2173         * tui/tui-layout.c (tui_default_win_height)
2174         (show_source_disasm_command, show_data, init_and_make_win)
2175         (show_source_or_disasm_and_command): Update.
2176         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2177         (tui_redisplay_readline, tui_mld_flush)
2178         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2179         (tui_getc): Update.
2180         * tui/tui-disasm.c (tui_set_disassem_content)
2181         (tui_disasm_window::do_scroll_vertical): Update.
2182         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2183         Now virtual.
2184         (struct tui_win_info): Derive from tui_gen_win_info.
2185         <~tui_win_info>: Mark as override.
2186         <generic>: Remove member.
2187         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2188         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2189         (~tui_data_window, ~tui_win_info)
2190         (tui_free_all_source_wins_content): Update.
2191         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2192
2193 2019-06-25  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-layout.c (init_and_make_win): Use new.
2196         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2197         destructor, initializers.
2198         (tui_alloc_generic_win_info): Don't declare.
2199         * tui/tui-data.c (_locator): Add argument to constructor.
2200         (source_win, disasm_win): New globals.
2201         (exec_info): Remove.
2202         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2203         Update.
2204         (tui_alloc_generic_win_info): Remove.
2205         (init_content_element): Use new.
2206         (tui_win_info::tui_win_info): Update.
2207         (free_content_elements) <case DATA_WIN>: Use delete.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2212         * tui/tui-windata.c (tui_first_data_item_displayed)
2213         (tui_delete_data_content_windows): Update.
2214         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2215         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2216         (tui_display_registers_from, tui_check_register_values): Update.
2217         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2218         pointer.
2219         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2220         window.
2221         (tui_free_data_content): Update.
2222         (free_content_elements) <case DATA_WIN>: Free the window.
2223
2224 2019-06-25  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2227         Update.
2228         * tui/tui-layout.c (make_command_window)
2229         (show_source_disasm_command, show_data, init_and_make_win)
2230         (show_source_or_disasm_and_command): Update.
2231         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2232         method.
2233         <can_highight, is_highlighted>: Now bool.
2234         (tui_set_win_highlight): Don't declare.
2235         * tui/tui-data.c (tui_set_win_highlight): Remove.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-wingeneral.c (make_visible): Remove check of window
2240         type.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-win.c (tui_win_info::max_height)
2245         (tui_cmd_window::max_height): New methods.
2246         (new_height_ok): Call max_height.
2247         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2248         <max_height>: New method.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-win.c (tui_source_window_base::set_new_height)
2253         (tui_data_window::set_new_height): New methods.
2254         (make_invisible_and_set_new_height): Call set_new_height method.
2255         * tui/tui-data.h (struct tui_win_info)
2256         (struct tui_source_window_base, struct tui_data_window)
2257         <set_new_height>: New method.
2258
2259 2019-06-25  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2262         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2263         tui_refresh_data_win.
2264         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2265         method.
2266         (tui_refresh_all_win): Call the refresh_all method.
2267         (tui_set_focus): Likewise.
2268         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2269         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2270         Likewise.
2271
2272 2019-06-25  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-winsource.h (tui_refill_source_window)
2275         (tui_set_is_exec_point_at): Don't declare.
2276         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2277         (tui_source_window_base::refill): Rename from
2278         tui_refill_source_window.
2279         (tui_source_window_base::do_scroll_horizontal): Update.
2280         (tui_source_window_base::set_is_exec_point_at): Rename from
2281         tui_set_is_exec_point_at.
2282         (tui_update_all_breakpoint_info): Update.
2283         * tui/tui-stack.c (tui_show_frame_info): Update.
2284         * tui/tui-layout.c (show_data): Add cast.
2285         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2286         * tui/tui-data.h (struct tui_source_window_base) <refill,
2287         set_is_exec_point_at>: New methods.
2288         (tui_source_windows, tui_add_to_source_windows): Update types.
2289         (tui_add_to_source_windows): Remove redundant declaration.
2290         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2291         (tui_source_windows): Change return type.
2292         (tui_clear_source_windows_detail): Update.
2293         (tui_add_to_source_windows): Change type of parameter.
2294         (tui_free_all_source_wins_content): Update.
2295
2296 2019-06-25  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-wingeneral.c (tui_win_info::refresh)
2299         (tui_source_window_base::refresh): New methods.
2300         (tui_refresh_all): Call the refresh method.
2301         * tui/tui-data.h (struct tui_win_info)
2302         (struct tui_source_window_base) <refresh>: New method.
2303
2304 2019-06-25  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui.h (tui_is_window_visible): Return bool.
2307         * tui/tui.c (tui_is_window_visible): Return bool.
2308         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2309         (tui_make_visible, tui_make_invisible)
2310         (tui_win_info::make_visible)
2311         (tui_source_window_base::make_visible, make_all_visible)
2312         (tui_make_all_visible, tui_make_all_invisible): Update.
2313         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2314         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2315         bool.
2316         (struct tui_win_info, struct tui_source_window_base)
2317         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2318         * tui/tui-data.c (tui_init_generic_part): Update.
2319
2320 2019-06-25  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2323         (tui_source_window_base::make_visible): New methods.
2324         (make_all_visible): Make method call.
2325         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2326         (struct tui_source_window_base, struct tui_cmd_window): Override
2327         make_visible.
2328         (tui_win_is_source_type): Don't declare.
2329         * tui/tui-data.c (tui_win_is_source_type): Remove.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2334         NULL check.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2339         Inline constructor.  Add initializers for members.
2340         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2341         constructors; now inline in class.
2342
2343 2019-06-25  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-regs.c (tui_show_registers): Update.
2346         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2347         bool.
2348         * tui/tui-data.c (tui_data_window::clear_detail)
2349         (tui_data_window): Update.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-windata.c (tui_display_all_data)
2354         (tui_display_data_from_line, tui_display_data_from)
2355         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2356         Update.
2357         * tui/tui-regs.c (tui_last_regs_line_no)
2358         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2359         (tui_show_registers, tui_show_register_group)
2360         (tui_display_registers_from, tui_display_reg_element_at_line)
2361         (tui_display_registers_from_line, tui_check_register_values)
2362         (tui_reg_next, tui_reg_prev): Update.
2363         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2364         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2365         tui_data_window.
2366         (struct tui_win_info) <detail>: Remove.  Add new fields from
2367         tui_data_info.
2368         (TUI_DATA_WIN): Add cast.
2369         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2370         (~tui_data_window): Simplify.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-layout.c (show_source_disasm_command)
2375         (show_source_or_disasm_and_command): Update.
2376         * tui/tui-io.c (update_cmdwin_start_line)
2377         (tui_redisplay_readline): Update.
2378         * tui/tui-data.h (struct tui_command_info): Remove.
2379         (struct tui_win_info) <detail>: Remove command_info member.
2380         (struct tui_data_window) <start_line>: New member, from
2381         tui_command_info.
2382         (TUI_CMD_WIN): Add casts.
2383
2384 2019-06-25  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-winsource.c (tui_update_source_window)
2387         (tui_refill_source_window)
2388         (tui_source_window_base::do_scroll_horizontal)
2389         (tui_update_breakpoint_info, tui_set_exec_info_content)
2390         (tui_show_exec_info_content, tui_erase_exec_info_content)
2391         (tui_clear_exec_info_content): Update.
2392         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2393         Update.
2394         * tui/tui-win.c (make_invisible_and_set_new_height)
2395         (make_visible_with_new_height): Update.
2396         * tui/tui-source.c (tui_set_source_content)
2397         (tui_show_symtab_source): Update.
2398         * tui/tui-layout.c (extract_display_start_addr)
2399         (show_source_disasm_command, show_data)
2400         (make_source_or_disasm_window)
2401         (show_source_or_disasm_and_command): Update.
2402         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2403         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2404         "gdbarch".
2405         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2406         to tui_source_window_base.
2407         (struct tui_win_info) <detail>: Remove source_info member.
2408         (struct tui_source_window_base) <has_locator>: Inline.
2409         Move contents from tui_source_info; rename has_locator member to
2410         m_has_locator.
2411         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2412         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2413         header file.
2414         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2415         Simplify.
2416         (tui_free_all_source_wins_content): Cast to
2417         tui_source_window_base.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-win.c (make_invisible_and_set_new_height)
2422         (make_visible_with_new_height): Call has_locator method.
2423         * tui/tui-layout.c (show_source_disasm_command, show_data)
2424         (show_source_or_disasm_and_command): Update for bool change.
2425         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2426         (tui_win_info) <has_locator>: New method.
2427         (struct tui_source_window_base) <has_locator>: New method.
2428         (tui_win_has_locator): Don't declare.
2429         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2430         from tui_win_has_locator.
2431         (tui_source_window_base): Use false, not FALSE.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2436         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2437         clear_detail method directly.
2438         (tui_clear_win_detail): Remove.
2439
2440 2019-06-25  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2443         "this", not TUI_DISASM_WIN.
2444
2445 2019-06-25  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2448         declare.
2449         * tui/tui-winsource.c
2450         (tui_source_window_base::do_scroll_horizontal): Rename from
2451         tui_horizontal_source_scroll.
2452         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2453         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2454         from tui_vertical_data_scroll.
2455         * tui/tui-win.h (tui_scroll): Don't declare.
2456         * tui/tui-win.c (tui_win_info::forward_scroll)
2457         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2458         (tui_win_info::right_scroll): Rename and update.
2459         (tui_scroll_forward_command, tui_scroll_backward_command)
2460         (tui_scroll_left_command, tui_scroll_right_command): Update.
2461         (tui_scroll): Remove.
2462         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2463         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2464         from tui_vertical_source_scroll.
2465         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2466         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2467         from tui_vertical_disassem_scroll.
2468         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2469         do_scroll_horizontal>: New methods.
2470         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2471         Likewise.
2472         (struct tui_source_window_base): Add do_scroll_horizontal.
2473         (struct tui_source_window, struct tui_disasm_window): Add
2474         do_scroll_vertical.
2475         (struct tui_data_window, struct tui_cmd_window): Add
2476         do_scroll_horizontal and do_scroll_vertical.
2477         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-data.h (struct tui_source_window_base): New struct.
2482         (struct tui_source_window): Derive from tui_source_window_base.
2483         (struct tui_disasm_window): New struct.
2484         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2485         from tui_source_window::clear_detail.
2486         (tui_source_window_base): Rename from tui_source_window.
2487         (~tui_source_window_base): Rename from ~tui_source_window.
2488         (tui_alloc_win_info): Create a tui_disasm_window.
2489
2490 2019-06-25  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-data.h (struct tui_source_window)
2493         (struct tui_data_window): Declare destructors.
2494         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2495         destructors.
2496         (tui_win_info): Simplify.
2497
2498 2019-06-25  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui-winsource.c (tui_display_main)
2501         (tui_update_source_windows_with_addr)
2502         (tui_update_all_breakpoint_info): Update.
2503         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2504         (new_height_ok, parse_scrolling_args): Update.
2505         * tui/tui-stack.c (tui_show_frame_info): Update.
2506         * tui/tui-data.h (struct tui_list): Remove.
2507         (tui_source_windows): Return a reference to a std::vector.
2508         * tui/tui-data.c (source_windows): Now a std::vector.
2509         (tui_source_windows): Change return type.
2510         (tui_clear_source_windows): Rewrite.
2511         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2512         (tui_free_all_source_wins_content): Rewrite.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2517         (struct tui_data_window, struct tui_cmd_window): Declare
2518         clear_detail method.
2519         * tui/tui-data.c (tui_source_window::clear_detail)
2520         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2521         methods.
2522         (tui_clear_win_detail): Simplify.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-layout.c (make_source_window, make_disasm_window)
2527         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2528         Return the new window.
2529         (show_source_disasm_command, show_data)
2530         (show_source_or_disasm_and_command): Update.
2531
2532 2019-06-25  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2535         parameter.  Return the new window.
2536         (show_source_disasm_command): Update and remove NULL check.
2537         (show_source_or_disasm_and_command): Update.
2538
2539 2019-06-25  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2542
2543 2019-06-25  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-data.h (struct tui_win_info): Make constructor
2546         protected.  Make destructor virtual.  Add initializers.
2547         (tui_source_window, tui_data_window, tui_cmd_window): New
2548         classes.
2549         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2550         constructor.  Add "type" parameter.
2551         (tui_source_window, tui_data_window, tui_cmd_window): New
2552         constructors.
2553         (tui_alloc_win_info): Instantiate the appropriate subclass.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-win.c (tui_resize_all): Use delete.
2558         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2559         destructor.
2560         (tui_free_window): Don't declare.
2561         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2562         Update.
2563
2564 2019-06-25  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-data.h (struct tui_win_info): Add constructor.
2567         * tui/tui-data.c (tui_alloc_win_info): Use new.
2568         (tui_free_window): Use delete.
2569
2570 2019-06-22  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2573         declare.
2574         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2575
2576 2019-06-22  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2579         declare.
2580         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2581
2582 2019-06-22  Tom de Vries  <tdevries@suse.de>
2583
2584         * dwarf2read.c (create_addrmap_from_aranges)
2585         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2586         instead of '%zu'.
2587
2588 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2589
2590         * dwarf2read.h (dwarf2_section_info_def): Remove.
2591         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2592         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2593         std::vector<dwarf2_section_info>.
2594         (struct dwo_file) <~dwo_file>: Remove.
2595         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2596         types field.
2597         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2598         (dwarf2_read_debug_names): Likewise.
2599         (create_debug_types_hash_table): Change parameter type to
2600         array_view, adjust code accordingly.
2601         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2602         (partial_die_info::fixup): Likewise.
2603         (determine_prefix): Likewise.
2604         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2605
2606 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2607
2608         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2609         gdb_bfd_ref_ptr.
2610         <~dwo_file>: Remove call to gdb_bfd_unref.
2611         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2612         gdb_bfd_ref_ptr::get.
2613
2614 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2615
2616         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2617         type to htab_up.
2618         * dwarf2read.c (struct dwo_file): Initialize fields.
2619         <~dwo_file>: New.
2620         (free_dwo_file): Remove, move content to ~dwo_file.
2621         (struct dwo_file_deleter): Remove.
2622         (dwo_file_up>: Remove custom deleter.
2623         (free_dwo_files): Remove.
2624         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2625         dwo_files.
2626         (process_skeletonless_type_units): Call unique_ptr::get.
2627         (allocate_dwo_file_hash_table): Add deleter to created hash
2628         table.  Change return type to htab_up.
2629         (lookup_dwo_file_slot): Don't memset dwo_file, call
2630         unique_ptr::get.
2631         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2632         (create_dwo_unit_in_dwp_v2): Likewise.
2633         (open_and_init_dwo_file): Likewise.
2634         (free_dwo_file_from_slot): Remove.
2635
2636 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2637
2638         * dwarf2read.h (struct dwarf2_section_info) <readin,
2639         is_virtual>: Change type to bool.
2640         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2641         true instead of 1.
2642
2643 2019-06-19  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-data.h (tui_init_content_element): Don't declare.
2646
2647 2019-06-19  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-data.h (tui_init_win_info): Don't declare.
2650
2651 2019-06-19  Tom de Vries  <tdevries@suse.de>
2652
2653         * dwarf2read.h (abstract_to_concrete): Change type to
2654         std::unordered_map<sect_offset, std::vector<sect_offset>,
2655         gdb::hash_enum<sect_offset>>.
2656
2657 2019-06-19  Tom Tromey  <tromey@adacore.com>
2658
2659         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2660         EVAL_AVOID_SIDE_EFFECTS specially.
2661
2662 2019-06-19  Tom Tromey  <tromey@adacore.com>
2663
2664         * source-cache.c (highlighter): New global.
2665         (source_cache::get_source_lines): Create a highlighter on demand.
2666
2667 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * defs.h (deprecated_interactive_hook): Delete declaration.
2670         * interps.c (clear_interpreter_hooks): Remove use of
2671         deprecated_interactive_hook.
2672         * top.c (deprecated_interactive_hook): Delete definition.
2673         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2674
2675 2019-06-18  Tom de Vries  <tdevries@suse.de>
2676
2677         PR gdb/24515
2678         * dwarf2read.h (abstract_to_concrete): Change type from
2679         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2680         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2681         * dwarf2read.c (read_variable): Update.
2682         (dwarf2_fetch_die_loc_sect_off): Update.
2683
2684 2019-06-17  Tom de Vries  <tdevries@suse.de>
2685
2686         PR gdb/24617
2687         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2688         accessing parent[parent_len - 1].
2689
2690 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2691
2692         PR gdb/24364
2693         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2694         call dtrace_process_dof with NULL dof.
2695
2696 2019-06-16  Tom de Vries  <tdevries@suse.de>
2697
2698         PR gdb/24445
2699         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2700
2701 2019-06-16  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2704         (make_all_visible): Use address of member.
2705
2706 2019-06-16  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2709         (tui_free_window, free_content, free_content_elements): Remove
2710         unnecessary cast.
2711         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2712         cast.
2713         * tui/tui-regs.c (tui_show_register_group)
2714         (tui_display_registers_from, tui_display_reg_element_at_line):
2715         Remove unnecessary cast.
2716
2717 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2718
2719         * linux-nat.c (normal_mask): Delete.
2720         (_initialize_linux_nat): Don't initialise normal_mask.
2721
2722 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2723
2724         PR gdb/24445
2725         * dwarf-index-write.h (write_psymtabs_to_index): Add
2726         dwz_basename parameter.
2727         * dwarf-index-write.c (write_gdbindex): Move file writing to
2728         write_gdbindex_1.  Change return type void.
2729         (assert_file_size): Move up, remove filename parameter.
2730         (write_gdbindex_1): New function.
2731         (write_debug_names): Change return type to void, call
2732         assert_file_size.
2733         (struct index_wip_file): New struct.
2734         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2735         file logic to index_wip_file.  Write index for dwz file if
2736         needed.
2737         (save_gdb_index_command): Pass basename of dwz file, if present.
2738         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2739         build-id of dwz file, if present.
2740         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2741         (dwarf2_get_dwz_file): Likewise.
2742         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2743         (dwarf2_get_dwz_file): Likewise.
2744
2745 2019-06-16  Tom Tromey  <tom@tromey.com>
2746
2747         * coffread.c (process_coff_symbol): Use xstrdup.
2748         * value.c (create_internalvar): Use xstrdup.
2749
2750 2019-06-16  Tom Tromey  <tom@tromey.com>
2751
2752         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2753         * breakpoint.c (stopin_command, stopat_command)
2754         (until_break_command, decode_location_default): Remove unnecessary
2755         cast.
2756         * utils.c (subset_compare): Remove unnecessary cast.
2757         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2758         cast.
2759         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2760         cast.
2761         * infcmd.c (path_command): Remove unnecessary cast.
2762         * coffread.c (decode_type): Remove unnecessary cast.
2763         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2764         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2765         * tui/tui-stack.c (tui_show_locator_content)
2766         (tui_show_frame_info): Remove unnecessary cast.
2767         * tui/tui-win.c (tui_scroll_forward_command)
2768         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2769         (parse_scrolling_args): Remove unnecessary cast.
2770         * tui/tui-data.c (init_win_info, tui_del_window)
2771         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2772         (free_content_elements): Remove unnecessary cast.
2773         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2774         unnecessary cast.
2775         * tui/tui-source.c (tui_set_source_content)
2776         (tui_vertical_source_scroll): Remove unnecessary cast.
2777         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2778         cast.
2779         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2780         * tui/tui-regs.c (tui_display_registers_from)
2781         (tui_display_register): Remove unnecessary cast.
2782         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2783         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2784         (make_visible): Remove unnecessary cast.
2785         * tui/tui-winsource.c (tui_erase_source_content)
2786         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2787         unnecessary cast.
2788         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2789         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2790         * stabsread.c (read_type, read_array_type, read_range_type):
2791         Remove unnecessary cast.
2792         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2793         (parse_symbol, parse_type, upgrade_type, parse_external)
2794         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2795         unnecessary cast.
2796         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2797
2798 2019-06-16  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-data.c (tui_alloc_generic_win_info)
2801         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2802         checks.
2803
2804 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2805             Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * f-typeprint.c (f_print_type): Don't return early for not
2808         associated or not allocated types.
2809         (f_type_print_varspec_suffix): Add print_rank parameter and print
2810         ranks of array types in case they dangling.
2811         (f_type_print_base): Add print_rank parameter.
2812
2813 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * NEWS: Mention new MI commands.
2816         * break-catch-throw.c (enum exception_event_kind): Move to
2817         breakpoint.h.
2818         (print_mention_exception_catchpoint): Output text as a single
2819         message.
2820         (catch_exception_command_1): Rename to...
2821         (catch_exception_event): ...this, make non-static, update header
2822         command, and change some parameter types.
2823         (catch_catch_command): Update for changes to
2824         catch_exception_command_1.
2825         (catch_throw_command): Likewise.
2826         (catch_rethrow_command): Likewise.
2827         * breakpoint.c (enum exception_event_kind): Delete.
2828         * breakpoint.h (enum exception_event_kind): Moved here from
2829         break-catch-throw.c.
2830         (catch_exception_event): Declare.
2831         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2832         (mi_cmd_catch_throw): New function.
2833         (mi_cmd_catch_rethrow): New function.
2834         (mi_cmd_catch_catch): New function.
2835         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2836         'catch-catch' entries.
2837         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2838         (mi_cmd_catch_rethrow): Declare.
2839         (mi_cmd_catch_catch): Declare.
2840
2841 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * annotate.c (annotate_source_line): Change return type to void,
2844         update implementation to match.
2845         * annotate.h (annotate_source_line): Change return type to void,
2846         update header comment.
2847         * stack.c (print_frame_info): Don't change what frame information
2848         is printed based on whether annotations are on or not.
2849
2850 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2853         (annotate_source): Make static.
2854         (annotate_source_line): Moved from source.c and renamed from
2855         identify_source_line.  Update the return type.
2856         * annotate.h (annotate_source): Delete declaration.
2857         (annotate_source_line): Declaration moved from source.h, and
2858         renamed from identify_source_line.  Return type updated.
2859         * source.c (identify_source_line): Moved to annotate.c and renamed
2860         to annotate_source_line.
2861         (info_line_command): Remove check of annotation_level.
2862         * source.h (identify_source_line): Move declaration to annotate.h
2863         and rename to annotate_source_line.
2864         * stack.c: Add 'annotate.h' include.
2865         (print_frame_info): Remove check of annotation_level before
2866         calling annotate_source_line.
2867
2868 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2869
2870         * source-cache.c (source_cache::get_plain_source_lines): Use
2871         open_source_file_with_line_charpos instead of just
2872         open_source_file, remove call to find_source_lines.
2873         (source_cache::get_source_lines): Likewise.
2874         * source.c (find_source_lines): Make static.
2875         (get_filename_and_charpos): Renamed into...
2876         (open_source_file_with_line_charpos): ..this along with changes to
2877         return a scoped_fd, and some other minor clean ups.
2878         (identify_source_line): Use open_source_file_with_line_charpos.
2879         (search_command_helper): Use open_source_file_with_line_charpos
2880         instead of just open_source_file, remove call to
2881         find_source_lines.
2882         * source.h (open_source_file_with_line_charpos): Declare new
2883         function.
2884         (find_source_lines): Delete declaration.
2885
2886 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2887
2888         * source.c (get_filename_and_charpos): Remove fullname
2889         parameter.
2890         (identify_source_line): Update call to get_filename_and_charpos.
2891
2892 2019-06-14  Tom Tromey  <tromey@adacore.com>
2893
2894         PR gdb/24502:
2895         * ui-style.h (skip_ansi_escape): Update comment.
2896         * ui-file.h (class no_terminal_escape_file): New class.
2897         * ui-file.c (no_terminal_escape_file::write)
2898         (no_terminal_escape_file::puts): New methods.
2899         * cli/cli-logging.c (handle_redirections): Use
2900         no_terminal_escape_file.
2901
2902 2019-06-14  Tom Tromey  <tromey@adacore.com>
2903
2904         * NEWS: Move convenience variable news above Python news.
2905
2906 2019-06-14  Tom Tromey  <tom@tromey.com>
2907
2908         * gnulib: Move directory to top-level.
2909         * configure.ac: Don't configure gnulib.
2910         * configure: Rebuild.
2911         * common/common-defs.h: Use new path to gnulib.
2912         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2913         (GNULIB_H): Remove.
2914         (INCGNU): Look in new gnulib location.
2915         (HFILES_NO_SRCDIR): Remove gnulib files.
2916         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2917         (generated_files): Remove GNULIB_H.
2918         ($(LIBGNU), all-lib): Remove targets.
2919         (distclean): Don't mention GNULIB_BUILDDIR.
2920         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2921
2922 2019-06-14  Tom Tromey  <tromey@adacore.com>
2923
2924         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2925         Warn if symbol file does not provide any symbols.
2926
2927 2019-06-14  Tom Tromey  <tromey@adacore.com>
2928
2929         * source.c (find_and_open_source): Respect basenames_may_differ.
2930
2931 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2932
2933         * annotate.c (annotate_breakpoints_invalid): Make use of
2934         scoped_restore_terminal_state.
2935         (annotate_frames_invalid): Likewise.
2936
2937 2019-06-14  Tom Tromey  <tromey@adacore.com>
2938
2939         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2940         allow assignment to an internalvar.
2941
2942 2019-06-14  Tom Tromey  <tromey@adacore.com>
2943
2944         * ada-lex.l: Allow "_" in attribute names.
2945
2946 2019-06-14  Tom Tromey  <tromey@adacore.com>
2947
2948         PR gdb/24653:
2949         * regcache.c (registers_changed): Don't call alloca.
2950         * top.c (execute_command): Don't call alloca.
2951
2952 2019-06-13  Pedro Alves  <palves@redhat.com>
2953
2954         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2955         'expression'.  When parsing an expression, error out if there's
2956         junk after "unlimited".
2957         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2958         (do_set_command): Adjust calls to is_unlimited_literal.
2959
2960 2019-06-13  Pedro Alves  <palves@redhat.com>
2961
2962         * compile/compile.c (make_compile_options_def_group): Add braces
2963         around array_view initializer.
2964         * thread.c (make_thread_apply_all_options_def_group)
2965         (make_thread_apply_all_options_def_group): Likewise.
2966
2967 2019-06-13  Pedro Alves  <palves@redhat.com>
2968
2969         * NEWS (New commands): Mention "maint test-options
2970         require-delimiter", "maint test-options unknown-is-error", "maint
2971         test-options unknown-is-operand" and "maint show
2972         test-options-completion-result".
2973         (New command options, command completion): New section.
2974         (Completion improvements): New section.
2975         Mention that you can abbreviate "unlimited".
2976
2977 2019-06-13  Pedro Alves  <palves@redhat.com>
2978
2979         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2980         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2981         * unittests/cli-utils-selftests.c (test_parse_flags)
2982         (test_parse_flags_qcs): Delete.
2983         (test_cli_utils): Don't call deleted functions.
2984
2985 2019-06-13  Pedro Alves  <palves@redhat.com>
2986
2987         * thread.c: Include "cli/cli-option.h".
2988         (tp_array_compar_ascending): Global.
2989         (tp_array_compar): Delete function.
2990         (tp_array_compar_ascending, tp_array_compar_descending): New
2991         functions.
2992         (ascending_option_def, qcs_flag_option_def)
2993         (thr_qcs_flags_option_defs)
2994         (make_thread_apply_all_options_def_group)
2995         (make_thread_apply_options_def_group): New.
2996         (thread_apply_all_command): Use gdb::option::process_options.
2997         (thread_apply_command_completer)
2998         (thread_apply_all_command_completer): New.
2999         (thread_apply_command): Use gdb::option::process_options.
3000         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3001         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3002         to generate help text of "thread apply".  Adjust "taas"'s help.
3003         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3004         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3005
3006 2019-06-13  Pedro Alves  <palves@redhat.com>
3007
3008         * thread.c (thread_apply_command): Check for invalid TID with
3009         isdigit instead of !isalpha.
3010
3011 2019-06-13  Pedro Alves  <palves@redhat.com>
3012
3013         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3014         (validate_flags_qcs): New.
3015         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3016         (validate_flags_qcs): Declare.
3017         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3018         (make_frame_apply_options_def_group): New.
3019         (frame_apply_command_count): Process options with
3020         gdb::option::process_options.
3021         (frame_apply_completer): New.
3022         (frame_apply_level_completer, frame_apply_all_completer)
3023         (frame_apply_completer): New.
3024         (_initialize_stack): Update help of "frame apply", "frame apply
3025         level", "frame apply all" and "faas" to mention supported options
3026         and install command completers.
3027         * stack.h (frame_apply_all_completer): Declare.
3028         * thread.c: Include "stack.h".
3029         (tfaas_command): Add "--".
3030         (_initialize_thread): Update help "tfaas" to mention supported
3031         options and install command completer.
3032
3033 2019-06-13  Pedro Alves  <palves@redhat.com>
3034
3035         * completer.c (complete_nested_command_line): New.
3036         (gdb_completion_word_break_characters_throw): Add assertion.
3037         * completer.h (complete_nested_command_line): Declare.
3038
3039 2019-06-13  Pedro Alves  <palves@redhat.com>
3040
3041         * stack.c (parse_backtrace_qualifiers): New.
3042         (backtrace_command): Use it.
3043         (backtrace_command_completer): Complete on qualifiers.
3044
3045 2019-06-13  Pedro Alves  <palves@redhat.com>
3046
3047         * frame.c: Include "cli/cli-option.h.
3048         (user_set_backtrace_options): New.
3049         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3050         Delete.
3051         (get_prev_frame): Adjust.
3052         (boolean_option_def, uinteger_option_def)
3053         (set_backtrace_option_defs): New.
3054         (_initialize_frame): Adjust and use
3055         gdb::option::add_setshow_cmds_for_options to install "set
3056         backtrace past-main" and "set backtrace past-entry".
3057         * frame.h: Include "cli/cli-option.h".
3058         (struct frame_print_options): Forward declare.
3059         (print_frame_arguments_all, print_frame_arguments_scalars)
3060         (print_frame_arguments_none): Declare.
3061         (print_entry_values): Delete declaration.
3062         (struct frame_print_options, user_frame_print_options): New.
3063         (struct set_backtrace_options): New.
3064         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3065         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3066         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3067         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3068         (list_args_or_locals): Add frame_print_options parameter.
3069         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3070         * python/py-framefilter.c (enumerate_args): Pass down
3071         USER_FRAME_PRINT_OPTIONS.
3072         * stack.c: Include "cli/cli-option.h".
3073         (print_frame_arguments_all, print_frame_arguments_scalars)
3074         (print_frame_arguments_none): Declare.
3075         (print_raw_frame_arguments, print_entry_values): Delete.
3076         (user_frame_print_options): New.
3077         (boolean_option_def, enum_option_def, frame_print_option_defs):
3078         New.
3079         (struct backtrace_cmd_options): New.
3080         (bt_flag_option_def): New.
3081         (backtrace_command_option_defs): New.
3082         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3083         (print_frame_arg, read_frame_arg, print_frame_args)
3084         (print_frame_info, print_frame): Add frame_print_options parameter
3085         and use it.
3086         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3087         (backtrace_command_1): Add frame_print_options and
3088         backtrace_cmd_options parameters and use them.
3089         (make_backtrace_options_def_group): New.
3090         (backtrace_command): Process command options with
3091         gdb::option::process_options.
3092         (backtrace_command_completer): New.
3093         (_initialize_stack): Extend "backtrace"'s help to mention
3094         supported options.  Install completer for "backtrace".
3095         Install some settings commands with add_setshow_cmds_for_options.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3100         and that "set/show print raw frame-arguments" are now deprecated.
3101
3102         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3103         command.
3104         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3105         * stack.c (_initialize_stack): Install "set/show print
3106         raw-frame-arguments", and deprecate "set/show print raw
3107         frame-arguments".
3108         * valprint.c (_initialize_valprint): Deprecate "set/show print
3109         raw".
3110
3111 2019-06-13  Pedro Alves  <palves@redhat.com>
3112
3113         * compile/compile.c (struct compile_options): New.
3114         (compile_flag_option_def, compile_command_option_defs)
3115         (make_compile_options_def_group): New.
3116         (compile_file_command): Handle options with
3117         gdb::option::process_options.
3118         (compile_file_command_completer): New function.
3119         (compile_code_command): Handle options with
3120         gdb::option::process_options.
3121         (compile_code_command_completer): New function.
3122         (_initialize_compiler): Install completers for "compile code" and
3123         "compile file".  Mention available options in "compile code" and
3124         "compile code"'s help.
3125         * completer.c (advance_to_completion_word): New, factored out from
3126         ...
3127         (advance_to_expression_complete_word_point): ... this.
3128         (advance_to_filename_complete_word_point): New.
3129         * completer.h (advance_to_filename_complete_word_point): New
3130         declaration.
3131
3132 2019-06-13  Pedro Alves  <palves@redhat.com>
3133
3134         * compile/compile.c: Include "cli/cli-option.h".
3135         (compile_print_value): Scope data pointer is now a
3136         value_print_options pointer; adjust.
3137         (compile_print_command): Process options.  Scope data pointer is
3138         now a value_print_options pointer; adjust.
3139         (_initialize_compile): Update "compile print"'s help to include
3140         supported options.  Install a completer for "compile print".
3141         * cp-valprint.c (show_vtblprint, show_objectprint)
3142         (show_static_field_print): Delete.
3143         (_initialize_cp_valprint): Don't install "set print
3144         static-members", "set print vtbl", "set print object" here.
3145         * printcmd.c: Include "cli/cli-option.h" and
3146         "common/gdb_optional.h".
3147         (print_command_parse_format): Rework to fill in a
3148         value_print_options instead of a format_data.
3149         (print_value): Change parameter type from format_data pointer to
3150         value_print_options reference.  Adjust.
3151         (print_command_1): Process options.  Adjust to pass down a
3152         value_print_options.
3153         (print_command_completer): New.
3154         (_initialize_printcmd): Install print_command_completer as
3155         handle_brkchars completer for the "print" command.  Update
3156         "print"'s help to include supported options.
3157         * valprint.c: Include "cli/cli-option.h".
3158         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3159         here from cp-valprint.c.
3160         (boolean_option_def, uinteger_option_def)
3161         (value_print_option_defs, make_value_print_options_def_group):
3162         New.  Use gdb::option::add_setshow_cmds_for_options to install
3163         "set print elements", "set print null-stop", "set print repeats",
3164         "set print pretty", "set print union", "set print array", "set
3165         print address", "set print symbol", "set print array-indexes".
3166         * valprint.h: Include <string> and "cli/cli-option.h".
3167         (make_value_print_options_def_group): Declare.
3168         (print_value): Change parameter type from format_data pointer to
3169         value_print_options reference.
3170         (print_command_completer): Declare.
3171
3172 2019-06-13  Pedro Alves  <palves@redhat.com>
3173
3174         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3175         (COMMON_SFILES): Add maint-test-settings.c.
3176         * cli/cli-decode.c (boolean_enums): New global, factored out from
3177         ...
3178         (add_setshow_boolean_cmd): ... here.
3179         * cli/cli-decode.h (boolean_enums): Declare.
3180         * cli/cli-option.c: New file.
3181         * cli/cli-option.h: New file.
3182         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3183         factored out from ...
3184         (parse_cli_boolean_value(const char *)): ... this.
3185         (is_unlimited_literal): Change parameter type to pointer to
3186         pointer.  Adjust and advance ARG pointer.
3187         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3188         (parse_cli_var_enum): New, factored out from ...
3189         (do_set_command): ... this.  Adjust.
3190         * cli/cli-setshow.h (parse_cli_boolean_value)
3191         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3192         (parse_cli_var_enum): Declare.
3193         * cli/cli-utils.c: Include "cli/cli-option.h".
3194         (get_ulongest): New.
3195         * cli/cli-utils.h (get_ulongest): Declare.
3196         (check_for_argument): New overloads.
3197         * maint-test-options.c: New file.
3198
3199 2019-06-13  Pedro Alves  <palves@redhat.com>
3200
3201         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3202         parse a range if "-" is at the end of the string.
3203
3204 2019-06-13  Pedro Alves  <palves@redhat.com>
3205
3206         * cli/cli-setshow.c (parse_auto_binary_operation)
3207         (parse_cli_boolean_value): Don't allow "o".
3208
3209 2019-06-13  Pedro Alves  <palves@redhat.com>
3210
3211         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3212         * NEWS: Mention maint test-settings KIND.
3213         * maint-test-settings.c: New file.
3214
3215 2019-06-13  Pedro Alves  <palves@redhat.com>
3216
3217         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3218         completer.
3219         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3220         "set" completers.
3221
3222 2019-06-13  Pedro Alves  <palves@redhat.com>
3223
3224         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3225         after item.
3226
3227 2019-06-13  Pedro Alves  <palves@redhat.com>
3228
3229         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3230
3231 2019-06-13  Pedro Alves <palves@redhat.com>
3232
3233         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3234         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3235         call.
3236         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3237         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3238         calls.
3239         (check_for_argument): Skip spaces after argument.
3240
3241 2019-06-13  Pedro Alves  <palves@redhat.com>
3242
3243         * thread.c (thread_apply_command): Adjust TID parsing.
3244         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3245         detected before end of string.
3246         (tid_is_in_list): Error out if LIST is invalid.
3247
3248 2019-06-13  Pedro Alves  <palves@redhat.com>
3249
3250         * completer.c (complete_line_internal_1): Rewind completion word
3251         point.
3252         (completion_tracker::advance_custom_word_point_by): Change
3253         parameter type to int.
3254         * completer.h (completion_tracker::advance_custom_word_point_by):
3255         Likewise.
3256
3257 2019-06-13  Pedro Alves  <palves@redhat.com>
3258
3259         * completer.c (advance_to_completion_word): Handle delimiters.
3260
3261 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3262
3263         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3264
3265 2019-06-11  Tom Tromey  <tom@tromey.com>
3266
3267         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3268         (xmalloc_failed): Move to alloc.c.
3269         * alloc.c: New file.
3270         * Makefile.in (COMMON_SFILES): Add alloc.c.
3271
3272 2019-06-11  Tom Tromey  <tom@tromey.com>
3273
3274         * nat/linux-waitpid.c: Don't include server.h.
3275         (linux_debug): Remove.
3276         (my_waitpid): Update.
3277
3278 2019-06-11  Tom Tromey  <tromey@adacore.com>
3279
3280         * infcall.c (_initialize_infcall): Remove trailing newline from
3281         help.
3282         * user-regs.c (_initialize_user_regs): Remove trailing newline
3283         from help.
3284         * typeprint.c (_initialize_typeprint): Remove trailing newline
3285         from help.
3286         * reverse.c (_initialize_reverse): Remove trailing newlines from
3287         help.
3288         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3289         from help.
3290         * language.c (add_set_language_command): Remove trailing newline
3291         from help.
3292         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3293         help.
3294         * disasm.c (_initialize_disasm): Remove trailing newline from
3295         help.
3296         * top.c (init_main): Remove trailing newline from help.
3297         * interps.c (_initialize_interpreter): Remove trailing newline
3298         from help.
3299         * btrace.c (_initialize_btrace): Remove trailing newlines from
3300         help.
3301         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3302         from help.
3303         * python/python.c (_initialize_python): Remove trailing newline
3304         from help.
3305         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3306         help.
3307         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3308         from help.  Reformat some text.
3309         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3310         from help.
3311         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3312         newline from help.
3313
3314 2019-06-11  Tom Tromey  <tromey@adacore.com>
3315
3316         * darwin-nat.c (darwin_decode_exception_message)
3317         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3318
3319 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * valops.c (value_slice): Check for not allocated or not
3322         associated values.
3323
3324 2019-06-10  Tom de Vries  <tdevries@suse.de>
3325
3326         PR gdb/24618
3327         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3328         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3329         invalid.
3330
3331 2019-06-10  Tom de Vries  <tdevries@suse.de>
3332
3333         PR gdb/24611
3334         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3335         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3336
3337 2019-06-10  Tom de Vries  <tdevries@suse.de>
3338
3339         PR symtab/24545
3340         * symtab.c (struct demangled_name_entry): Add language field.
3341         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3342         static minimal symbol".  Set and use language field.
3343
3344 2019-06-10  Tom Tromey  <tromey@adacore.com>
3345
3346         * ada-lang.c (_initialize_ada_language): Update help text.
3347
3348 2019-06-10  Tom Tromey  <tromey@adacore.com>
3349
3350         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3351         with a newline.
3352         * guile/guile.c (handle_boot_error): Don't end warning with a
3353         newline.
3354         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3355         warning with a newline.
3356         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3357         newline.
3358         (s12z_frame_cache): Likewise.
3359         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3360         a newline.
3361         * solib-svr4.c (disable_probes_interface): Don't end warning with
3362         a newline.
3363         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3364         newline.
3365         * python/python.c (do_finish_initialization): Don't end warning
3366         with a newline.
3367
3368 2019-06-10  Tom Tromey  <tom@tromey.com>
3369
3370         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3371         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3372         gdbpy_enter.
3373
3374 2019-06-10  Tom Tromey  <tromey@adacore.com>
3375
3376         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3377         data.
3378         (elf_new_init): Don't call stabsread_new_init.
3379         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3380         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3381         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3382
3383 2019-06-10  Tom de Vries  <tdevries@suse.de>
3384
3385         PR symtab/16264
3386         PR symtab/24517
3387         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3388
3389 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3390
3391         * source.c (find_and_open_source): Also rewrite relative file
3392         names.
3393
3394 2019-04-26  Amos Bird  <amosbird@gmail.com>
3395
3396         * annotate.c (annotate_thread_exited): Add "thread-exited"
3397         annotation.
3398
3399 2019-06-06  Tom Tromey  <tromey@adacore.com>
3400
3401         * maint.h (class scoped_command_stats): Use
3402         DISABLE_COPY_AND_ASSIGN.
3403         <print_time>: New method.
3404         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3405         print_time.
3406         (scoped_command_stats::print_time): New method.
3407
3408 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3409
3410         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3411         instructions of lengths 6 or 8 bytes.
3412
3413 2019-06-04  Pedro Alves  <palves@redhat.com>
3414
3415         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3416
3417         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3418         * breakpoint.c (condition_completer): Likewise.
3419         * cli/cli-dump.c (scan_expression): Likewise.
3420         * common/filestuff.c (mkdir_recursive): Likewise.
3421         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3422         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3423         (gdb_abspath): Likewise.
3424         * compile/compile-cplus-types.c
3425         (compile_cplus_instance::decl_name): Likewise.
3426         * completer.c (complete_explicit_location):
3427         (signal_completer, reg_or_group_completer_1): Likewise.
3428         * cp-support.c (cp_remove_params_if_any): Likewise.
3429         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3430         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3431         * infcmd.c (strip_bg_char): Likewise.
3432         * linespec.c (copy_token_string): Likewise.
3433         * mi/mi-main.c (output_cores): Likewise.
3434         * psymtab.c (psymtab_search_name):
3435         * symfile.c (test_set_ext_lang_command): Likewise.
3436         * target.c (target_fileio_read_stralloc): Likewise.
3437         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3438         * value.c (complete_internalvar): Likewise.
3439
3440 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3441
3442         Add objfile property to gdb.Type.
3443         * NEWS: Mention Python API addition.
3444         * python/py-type.c (typy_get_objfile): New method.
3445
3446 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3447
3448         * NEWS: Mention the new set|show style [title|highlight].
3449         Mention changes to "show style", "help" and "apropos".
3450
3451 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3452
3453         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3454         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3455         instead of print_help_for_command.
3456         (print_doc_of_command): New function.
3457         (help_list): Add 'apropos -v word' suggestion.
3458         (print_help_for_command): Style the command name using title style.
3459         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3460         (_initialize_cli_cmds): Describe -v in apropos_command help.
3461
3462 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * cli/cli-style.h (cli_style_option): Add name in constructor,
3465         add m_name class member, add constructor with intensity,
3466         add name class function.
3467         (cli_style_option::add_setshow_commands): Remove name argument.
3468         (highlight_style, title_style): New styles.
3469         * cli/cli-style.c (do_show): New function that shows a style
3470         characteristic styling the style name with itself.
3471         (set_style_name): New function.
3472         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3473         Update all callers according to the changes in cli/cli-style.h.
3474         * utils.h (fputs_highlighted): New function.
3475         * utils.c (fputs_highlighted): Likewise.
3476
3477 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3478
3479         * NEWS: Mention new pipe command and new convenience variables.
3480
3481 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3482
3483         * cli/cli-cmds.c (pipe_command): New function.
3484         (_initialize_cli_cmds): Call add_com for pipe_command.
3485         Define | as an alias for pipe.
3486         (exit_status_set_internal_vars): New function.
3487         (shell_escape): Call exit_status_set_internal_vars.
3488         cli/cli-decode.c (find_command_name_length): Recognize | as
3489         a single character command.
3490
3491 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3492
3493         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3494         top.c (execute_command_to_ui_file): New function, mostly a copy
3495         of execute_command_to_string.
3496         (execute_command_to_string): Implement by calling
3497         execute_command_to_ui_file.
3498
3499 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3500
3501         * top.h (saved_command_line): Remove declaration.
3502         * top.c (previous_saved_command_line, previous_repeat_arguments):
3503         New variables.
3504         (saved_command_line): Make static, define together with other
3505         'repeat variables'.
3506         (dont_repeat): Clear repeat_arguments.
3507         (repeat_previous, get_saved_command_line, save_command_line):
3508         New functions.
3509         (gdb_init): Initialize saved_command_line
3510         and previous_saved_command_line.
3511         * main.c (captured_main_1): Remove saved_command_line initialization.
3512         * event-top.c (handle_line_of_input): Update to use
3513         the new 'repeat' related functions instead of direct access to
3514         saved_command_line.
3515         * command.h (repeat_previous, get_saved_command_line,
3516         save_command_line): New declarations.
3517         (dont_repeat): Add comment.
3518
3519 2019-05-30  Tom Tromey  <tromey@adacore.com>
3520
3521         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3522         Fix comment.
3523         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3524
3525 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3526
3527         PR cli/24587
3528         * completer.c (complete): Initialize variable word.
3529
3530 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3531
3532         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3533         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3534         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3535         'body' is NULL to the outter 'if', protecting the '!is_define'
3536         situation as well.
3537
3538 2019-05-29  Tom Tromey  <tromey@adacore.com>
3539
3540         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3541         (dwarf_unknown): New function.
3542         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3543         (dwarf_type_encoding_name): Use dwarf_unknown.
3544
3545 2019-05-29  Tom Tromey  <tromey@adacore.com>
3546
3547         PR c++/20020:
3548         * cp-valprint.c (cp_print_value_fields): Call
3549         cp_print_static_field inside "try".
3550
3551 2019-05-29  Tom Tromey  <tromey@adacore.com>
3552
3553         * inflow.c (struct terminal_info): Add default operator=.
3554         * configure: Rebuild.
3555         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3556         -Wdeprecated-copy-dtor, -Wredundant-move.
3557
3558 2019-05-29  Tom Tromey  <tromey@adacore.com>
3559
3560         * NEWS: Add entry.
3561         * infcmd.c (print_return_value_1): Handle finish_print
3562         option.
3563         (show_print_finish): New function.
3564         (_initialize_infcmd): Add "set/show print finish" commands.
3565         * valprint.c (user_print_options): Initialize new member.
3566         * valprint.h (struct value_print_options) <finish_print>: New
3567         member.
3568
3569 2019-05-28  Tom Tromey  <tromey@adacore.com>
3570
3571         * ada-lang.c (ada_remove_Xbn_suffix)
3572         (find_old_style_renaming_symbol)
3573         (parse_old_style_renaming): Remove.
3574         (ada_find_renaming_symbol): Don't call
3575         find_old_style_renaming_symbol.
3576         (ada_is_renaming_symbol): Rename from
3577         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3578         bool.  Now static.
3579         (ada_read_var_value): Update and simplify.
3580         * ada-exp.y (write_var_or_type): Remove old code.
3581
3582 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3583
3584         * event-top.c: Remove include comment.
3585         * inflow.c (class scoped_ignore_sigttou): Move from here...
3586         * inflow.h (class scoped_ignore_sigttou): ...to here.
3587         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3588         * top.c:  Remove include comment.
3589
3590 2019-05-27  Tom Tromey  <tom@tromey.com>
3591
3592         * NEWS: Fix typo.
3593
3594 2019-05-22  Tom Tromey  <tromey@adacore.com>
3595
3596         * target.c (target_follow_exec): Constify parameter.
3597         * target-delegates.c: Rebuild.
3598         * remote.c (remote_target::follow_exec): Constify parameter.
3599         * infrun.c (follow_exec): Constify parameter.
3600         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3601         (target_follow_exec): Likewise.
3602
3603 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3604
3605         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3606         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3607
3608 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3609
3610         * NEWS: Add debugredirect and testsuite sections.
3611
3612 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3613
3614         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3615         target descriptions using exclusively floating point register name
3616         aliases.
3617
3618 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         PR gdb/18644:
3621         * f-lang.c (build_fortran_types): Handle the case where
3622         gdbarch_floatformat_for_type returns a nullptr.
3623
3624 2019-05-21  Tom de Vries  <tdevries@suse.de>
3625
3626         PR cli/24587
3627         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3628
3629 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         PR gdb/18644:
3632         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3633         16-byte floats.
3634         * i386-tdep.c (i386_floatformat_for_type): Use
3635         floatformats_ia64_quad for the 16-byte floating point component
3636         within a fortran 32-byte complex number.
3637
3638 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3641         delete default constructor.
3642         (find_partial_die): Update to return const struct.
3643         (partial_die_parent_scope): Move variable declaration into scope
3644         of its use and change its type to auto.
3645         (guess_partial_die_structure_name): Likewise.
3646         (partial_die_info::fixup): Likewise.
3647
3648 2019-05-17  Tom Tromey  <tromey@adacore.com>
3649
3650         * source.c (find_and_open_source): Remove cast.
3651
3652 2019-05-17  Tom Tromey  <tromey@adacore.com>
3653
3654         * annotate.c (annotate_source): Make "filename" const.
3655         * annotate.h (annotate_source): Use const.
3656
3657 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3658
3659         * disasm.c (set_disassembler_options): Send errors to stderr.
3660
3661 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3662
3663         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3664         (cli_interp_base::set_logging): Check debug_redirect.
3665         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3666         * cli/cli-logging.c (debug_redirect): Add static variable.
3667         (pop_output_files): Add default param.
3668         (handle_redirections): Print debug setting.
3669         (show_logging_command): Likewise.
3670         (_initialize_cli_logging): Add debugredirect command.
3671         * interps.c (current_interp_set_logging): Add debug_redirect
3672         parameter.
3673         * interps.h (set_logging): Add debug_redirect parameter.
3674         (current_interp_set_logging): Likewise.
3675         * mi/mi-common.h: Likewise.
3676         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3677
3678 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3679             Tom Tromey  <tromey@adacore.com>
3680
3681         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3682         directly.
3683         * cli/cli-interp.h (make_logging_output): Remove declaration.
3684         * cli/cli-logging.c (make_logging_output): Remove function.
3685         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3686         directly.
3687         * ui-file.c (tee_file::tee_file): Remove bools.
3688         (tee_file::~tee_file): Remove deletes.
3689         * ui-file.h (tee_file): Remove bools.
3690
3691 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3692
3693         * mi/mi-cmds.h (mi_cmd_complete): New function.
3694         * mi/mi-main.c (mi_cmd_complete): Likewise.
3695         * mi/mi-cmds.c: Define new MI command -complete.
3696         * NEWS: Mention new -complete command.
3697
3698 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3699
3700         * completer.h (complete): New function.
3701         * completer.c (complete): Likewise.
3702         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3703         function defined in completer.h.
3704
3705 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3706
3707         * MAINTAINERS (Write After Approval): Add myself.
3708
3709 2019-05-17  Tom de Vries  <tdevries@suse.de>
3710
3711         PR gdb/24094
3712         * dwarf2read.c (struct cu_partial_die_info): New struct.
3713         (find_partial_die): Return cu_partial_die_info.
3714         (partial_die_parent_scope, guess_partial_die_structure_name)
3715         (partial_die_info::fixup): Handle new return type of find_partial_die.
3716
3717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3718
3719         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3720         "std::string", simplifying the algorithm.
3721
3722 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3723
3724         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3725         (stap_static_probe_ops::get_probes): Likewise.
3726
3727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3728
3729         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3730         '-')" and "else if".
3731         (stap_parse_single_operand): Join checks for
3732         "gdbarch_stap_parse_special_token_p" and
3733         "gdbarch_stap_parse_special_token" in the same "if" statement.
3734         Invert check when verifying for operation on register
3735         displacement.
3736
3737 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3738
3739         * stap-probe.c (stap_get_opcode): Update comment.
3740         (stap_get_expected_argument_type): Likewise.
3741         (handle_stap_probe): Likewise.
3742
3743 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3744
3745         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3746         return type to 'bool'.  Adjust comment.  Use 'bool' when
3747         appropriate.
3748         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3749         * stap-probe.c (stap_parse_argument_1): Likewise.
3750         (stap_is_operator): Likewise.
3751         (stap_is_generic_prefix): Likewise.
3752         (stap_is_register_prefix): Likewise.
3753         (stap_is_register_indirection_prefix): Likewise.
3754         (stap_is_integer_prefix): Likewise.
3755         (stap_generic_check_suffix): Likewise.
3756         (stap_check_integer_suffix): Likewise.
3757         (stap_check_register_suffix): Likewise.
3758         (stap_check_register_indirection_suffix): Likewise.
3759         (stap_parse_register_operand): Likewise.
3760         (stap_parse_single_operand): Likewise.
3761         (stap_parse_argument_1): Likewise.
3762         (stap_probe::get_argument_count): Likewise.
3763         (stap_is_operator): Likewise.
3764
3765 2019-05-16  Tom Tromey  <tromey@adacore.com>
3766
3767         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3768         keyword to foreach.
3769
3770 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3771
3772         * linux-thread-db.c (try_thread_db_load_1): Change return type
3773         to bool.
3774         (try_thread_db_load): Likewise.
3775         (try_thread_db_load_from_pdir_1): Likewise.
3776         (try_thread_db_load_from_pdir): Likewise.
3777         (try_thread_db_load_from_sdir): Likewise.
3778         (try_thread_db_load_from_dir): Likewise.
3779         (thread_db_load_search): Likewise.
3780         (has_libpthread): Likewise.
3781         (thread_db_load): Likewise.
3782
3783 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3784
3785         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3786         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3787         NULL, and complain/return if that's the case.
3788
3789 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3790
3791         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3792         (advance, posn, abstract_read_memory): New functions.
3793         [struct mem_read_abstraction]: New struct.
3794         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3795
3796 2019-05-14  Tom Tromey  <tromey@adacore.com>
3797
3798         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3799         value is not lval_memory.
3800
3801 2019-05-14  Tom Tromey  <tromey@adacore.com>
3802
3803         * solib.c (info_sharedlibrary_command): Style the file name.
3804
3805 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3806
3807         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3808         (aarch64_vnv_type): Likewise.
3809         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3810         * common/tdesc.c: Likewise.
3811         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3812         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3813         * features/aarch64-fpu.xml: Add ieee half view.
3814         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3815         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3816         * gdbtypes.h (struct builtin_type): Likewise.
3817         (struct objfile_type): Likewise.
3818
3819 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3820
3821         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3822         typo.
3823         * location.h (string_to_event_location): Likewise.
3824
3825 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3826
3827         GDB 8.3 released.
3828
3829 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3830
3831         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3832         New variable declaration.
3833         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3834         New variable.
3835         (print_one_breakpoint): Use ui_out::test_flags and new global
3836         variable to compute use_fixed_output.
3837         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3838         Remove.
3839         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3840         (mi_multi_location_breakpoint_output_fixed): Remove.
3841         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3842         new variable.
3843         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3844         fix_multi_location_breakpoint_output flag if version >= 3.
3845         * ui-out.h (enum ui_out_flag)
3846         <fix_multi_location_breakpoint_output>: New enumerator.
3847
3848 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3849
3850         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3851
3852 2019-05-10  Tom Tromey  <tromey@adacore.com>
3853
3854         * ada-lang.c (catch_ada_completer): New function.
3855         (_initialize_ada_language): Use it.
3856
3857 2019-05-10  Tom Tromey  <tromey@adacore.com>
3858
3859         * thread.c (print_thread_info): Make "requested_threads" const.
3860         * gdbthread.h (print_thread_info): Make "requested_threads"
3861         const.
3862         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3863         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3864
3865 2019-05-08  Tom Tromey  <tom@tromey.com>
3866
3867         * gdbtypes.c (objfile_type_data): Change type.
3868         (objfile_type, _initialize_gdbtypes): Update.
3869
3870 2019-05-08  Tom Tromey  <tom@tromey.com>
3871
3872         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3873         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3874         (_initialize_dwarf2_frame): Update.
3875
3876 2019-05-08  Tom Tromey  <tom@tromey.com>
3877
3878         * objc-lang.c (objc_objfile_data): Change type.
3879         (find_methods): Update.
3880         (_initialize_objc_lang): Remove.
3881
3882 2019-05-08  Tom Tromey  <tom@tromey.com>
3883
3884         * stabsread.c (rs6000_builtin_type_data): Change type.
3885         (rs6000_builtin_type, _initialize_stabsread): Update.
3886
3887 2019-05-08  Tom Tromey  <tom@tromey.com>
3888
3889         * mips-tdep.c (mips_pdr_data): Remove.
3890         (_initialize_mips_tdep): Update.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3895         (hppa_init_objfile_priv_data, read_unwind_info)
3896         (find_unwind_entry, _initialize_hppa_tdep): Update.
3897
3898 2019-05-08  Tom Tromey  <tom@tromey.com>
3899
3900         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3901         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3902         on obstack.
3903         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3904
3905 2019-05-08  Tom Tromey  <tom@tromey.com>
3906
3907         * mdebugread.c (basic_type_data): Change type.
3908         (basic_type, _initialize_mdebugread): Update.
3909
3910 2019-05-08  Tom Tromey  <tom@tromey.com>
3911
3912         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3913
3914 2019-05-08  Tom Tromey  <tom@tromey.com>
3915
3916         * nto-tdep.c (nto_inferior_data_reg): Change type.
3917         (nto_inferior_data): Update.
3918         (nto_inferior_data_cleanup, nto_new_inferior_data)
3919         (_initialize_nto_tdep): Remove.
3920         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3921
3922 2019-05-08  Tom Tromey  <tom@tromey.com>
3923
3924         * ada-lang.c (struct ada_inferior_data): Add initializers.
3925         (ada_inferior_data): Change type.
3926         (ada_inferior_data_cleanup): Remove.
3927         (get_ada_inferior_data, ada_inferior_exit)
3928         (struct ada_pspace_data): Add initializers, destructor.
3929         (ada_pspace_data_handle): Change type.
3930         (get_ada_pspace_data): Update.
3931         (ada_pspace_data_cleanup): Remove.
3932
3933 2019-05-08  Tom Tromey  <tom@tromey.com>
3934
3935         * coffread.c (struct coff_symfile_info): Add initializers.
3936         (coff_objfile_data_key): Move lower.  Change type.
3937         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3938         Update.
3939         (coff_free_info): Remove.
3940
3941 2019-05-08  Tom Tromey  <tom@tromey.com>
3942
3943         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3944         (fbsd_pspace_data_handle): Move lower.  Change type.
3945         (get_fbsd_pspace_data): Update.
3946         (fbsd_pspace_data_cleanup): Remove.
3947         (_initialize_fbsd_tdep): Update.
3948
3949 2019-05-08  Tom Tromey  <tom@tromey.com>
3950
3951         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3952         (get_ada_tasks_pspace_data): Update.
3953         (ada_tasks_pspace_data_cleanup): Remove.
3954         (_initialize_tasks): Update.
3955         (ada_tasks_inferior_data_handle): Change type.
3956         (get_ada_tasks_inferior_data): Update.
3957         (ada_tasks_inferior_data_cleanup): Remove.
3958         (struct ada_tasks_pspace_data): Add initializers.
3959
3960 2019-05-08  Tom Tromey  <tom@tromey.com>
3961
3962         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3963         * symfile-debug.c (debug_sym_get_probes): Change type.
3964         * stap-probe.c (handle_stap_probe):
3965         (stap_static_probe_ops::get_probes): Change type.
3966         * probe.h (class static_probe_ops) <get_probes>: Change type.
3967         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3968         (parse_probes_in_pspace): Update.
3969         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3970         Update.
3971         (any_static_probe_ops::get_probes): Change type.
3972         * elfread.c (elfread_data): New typedef.
3973         (probe_key): Change type.
3974         (elf_get_probes): Likewise.  Update.
3975         (probe_key_free): Remove.
3976         (_initialize_elfread): Update.
3977         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3978         Change type.
3979         (dtrace_process_dof_probe, dtrace_process_dof)
3980         (dtrace_static_probe_ops::get_probe): Change type.
3981
3982 2019-05-08  Tom Tromey  <tom@tromey.com>
3983
3984         * xcoffread.c (struct xcoff_symfile_info): Rename from
3985         coff_symfile_info.  Add initializers.
3986         (xcoff_objfile_data_key): Move lower.  Change type.
3987         (XCOFF_DATA): Rewrite.
3988         (xcoff_free_info): Remove.
3989         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3990         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3991         (xcoff_initial_scan): Update.
3992
3993 2019-05-08  Tom Tromey  <tom@tromey.com>
3994
3995         * solib-svr4.c (struct svr4_info): Add initializers and
3996         destructor.
3997         <probes_table>: Now an htab_up.
3998         (solib_svr4_pspace_data): Change type.
3999         (free_probes_table): Simplify.
4000         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4001         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4002         (probes_table_remove_objfile_probes, register_solib_event_probe)
4003         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4004         (_initialize_svr4_solib): Update.
4005
4006 2019-05-08  Tom Tromey  <tom@tromey.com>
4007
4008         * remote.c (remote_pspace_data): Change type.
4009         (remote_pspace_data_cleanup): Remove.
4010         (get_remote_exec_file, set_pspace_remote_exec_file)
4011         (_initialize_remote): Update.
4012
4013 2019-05-08  Tom Tromey  <tom@tromey.com>
4014
4015         * breakpoint.c (breakpoint_objfile_key): Change type.
4016         (get_breakpoint_objfile_data): Update.
4017         (free_breakpoint_objfile_data): Remove.
4018         (_initialize_breakpoint): Update.
4019
4020 2019-05-08  Tom Tromey  <tom@tromey.com>
4021
4022         * linux-tdep.c (struct linux_info): Add initializers.
4023         (linux_inferior_data): Move.  Change type.
4024         (invalidate_linux_cache_inf): Update.
4025         (linux_inferior_data_cleanup): Remove.
4026         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4027
4028 2019-05-08  Tom Tromey  <tom@tromey.com>
4029
4030         * auxv.c (auxv_inferior_data): Move.  Change type.
4031         (auxv_inferior_data_cleanup): Remove.
4032         (invalidate_auxv_cache_inf): Rewrite.
4033         (get_auxv_inferior_data, _initialize_auxv): Update.
4034
4035 2019-05-08  Tom Tromey  <tom@tromey.com>
4036
4037         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4038         (symfile_debug_objfile_data_key): Change type.
4039         (symfile_debug_installed, debug_qf_has_symbols)
4040         (debug_qf_find_last_source_symtab)
4041         (debug_qf_forget_cached_source_info)
4042         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4043         (debug_qf_print_stats, debug_qf_dump)
4044         (debug_qf_expand_symtabs_for_function)
4045         (debug_qf_expand_all_symtabs)
4046         (debug_qf_expand_symtabs_with_fullname)
4047         (debug_qf_map_matching_symbols)
4048         (debug_qf_expand_symtabs_matching)
4049         (debug_qf_find_pc_sect_compunit_symtab)
4050         (debug_qf_map_symbol_filenames)
4051         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4052         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4053         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4054         (debug_sym_read_linetable, debug_sym_relocate): Update.
4055         (symfile_debug_free_objfile): Remove.
4056         (install_symfile_debug_logging, _initialize_symfile_debug):
4057         Update.
4058
4059 2019-05-08  Tom Tromey  <tom@tromey.com>
4060
4061         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4062         allocate_on_obstack.
4063         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4064         (get_dwarf2_per_objfile): Update.
4065         (set_dwarf2_per_objfile): Remove.
4066         (dwarf2_has_info, dwarf2_get_section_info): Update.
4067         (dwarf2_free_objfile): Remove.
4068         (_initialize_dwarf2_read): Update.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4073         initializers.
4074         <unsupported_script_warning_printed,
4075         script_not_found_warning_printed>: Now bool.
4076         (auto_load_pspace_data): Change type.
4077         (~auto_load_pspace_info): Rename from
4078         auto_load_pspace_data_cleanup.
4079         (get_auto_load_pspace_data, init_loaded_scripts_info)
4080         (clear_section_scripts, maybe_print_unsupported_script_warning)
4081         (maybe_print_script_not_found_warning, _initialize_auto_load):
4082         Update.
4083
4084 2019-05-08  Tom Tromey  <tom@tromey.com>
4085
4086         * objfiles.c (objfile_pspace_info): Add destructor and
4087         initializers.
4088         (objfiles_pspace_data): Change type.
4089         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4090         (get_objfile_pspace_data): Update.
4091         (objfiles_bfd_data): Change type.
4092         (get_objfile_bfd_data): Update.
4093         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4094
4095 2019-05-08  Tom Tromey  <tom@tromey.com>
4096
4097         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4098         Change type.
4099         (get_catch_syscall_inferior_data): Update.
4100         (catch_syscall_inferior_data_cleanup): Remove.
4101         (_initialize_break_catch_syscall): Update.
4102
4103 2019-05-08  Tom Tromey  <tom@tromey.com>
4104
4105         * inflow.c (struct terminal_info): Add destructor and
4106         initializers.
4107         (inflow_inferior_data): Change type.
4108         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4109         (get_inflow_inferior_data, inflow_inferior_exit)
4110         (swap_terminal_info, _initialize_inflow): Update.
4111
4112 2019-05-08  Tom Tromey  <tom@tromey.com>
4113
4114         * target-dcache.c (target_dcache_cleanup): Remove.
4115         (target_dcache_aspace_key): Change type.
4116         (target_dcache_init_p, target_dcache_invalidate)
4117         (target_dcache_get, target_dcache_get_or_init)
4118         (_initialize_target_dcache): Update.
4119         * dcache.h (struct dcache_deleter): New.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * symtab.c (struct symbol_cache): Add destructor and
4124         initializers.
4125         (symbol_cache_key): Move.  Change type.
4126         (make_symbol_cache, free_symbol_cache): Remove.
4127         (get_symbol_cache): Update.
4128         (symbol_cache_cleanup): Remove.
4129         (ALL_PSPACES, symbol_cache_flush)
4130         (maintenance_print_symbol_cache)
4131         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4132         Update.
4133
4134 2019-05-08  Tom Tromey  <tom@tromey.com>
4135
4136         * symtab.c (struct main_info): Add destructor and initializers.
4137         (main_progspace_key): Move.  Change type.
4138         (get_main_info): Update.
4139         (main_info_cleanup): Remove.
4140         (_initialize_symtab): Update.
4141
4142 2019-05-08  Tom Tromey  <tom@tromey.com>
4143
4144         * registry.h (DECLARE_REGISTRY): Define the _key class.
4145
4146 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * NEWS: Merge two 'New commands' sections.
4149
4150 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4151
4152         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4153         parameter and use Ada language definition instead.
4154         (ada_val_print_ptr): Remove unused language parameter.
4155         (ada_val_print_num): Remove language parameter and use Ada language
4156         definition instead.
4157         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4158         parameter.
4159         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4160         parameter and use Ada language definition instead.
4161         (ada_val_print_1): Update all ada_val_print_xxx calls.
4162         Remove language parameter.
4163         (ada_val_print): Update ada_val_print_1 call.
4164
4165 2019-05-08  Tom Tromey  <tromey@adacore.com>
4166
4167         * remote.c (remote_hw_watchpoint_limit)
4168         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4169         Now static.
4170
4171 2019-05-08  Tom Tromey  <tromey@adacore.com>
4172
4173         * maint.c (_initialize_maint_cmds): Move initialization code to
4174         remote.c.
4175         (watchdog, show_watchdog): Move to remote.c.
4176         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4177         "watchdog" static.
4178         (_initialize_remote): Move initialization code from maint.c.
4179         * defs.h (watchdog): Don't declare.
4180
4181 2019-05-08  Tom Tromey  <tromey@adacore.com>
4182
4183         * tui/tui-interp.c: Include main.h.
4184         * interps.c: Include main.h.
4185         * main.h (interpreter_p): Declare.
4186         * defs.h (interpreter_p): Don't declare.
4187
4188 2019-05-08  Tom Tromey  <tromey@adacore.com>
4189
4190         * dwarf2loc.c: Include dwarf2read.h.
4191         * defs.h (read_unsigned_leb128): Don't declare.
4192         * dwarf2read.h (read_unsigned_leb128): Declare.
4193
4194 2019-05-08  Tom Tromey  <tromey@adacore.com>
4195
4196         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4197         method.
4198
4199 2019-05-08  Tom Tromey  <tromey@adacore.com>
4200
4201         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4202         when no wrap column is set.
4203
4204 2019-05-08  Tom Tromey  <tromey@adacore.com>
4205
4206         * c-lang.c (c_get_string): Handle non-C-style arrays.
4207
4208 2019-05-08  Tom Tromey  <tromey@adacore.com>
4209
4210         * typeprint.c (print_offset_data::update): Print the bit offset,
4211         not the number of bits remaining.
4212
4213 2019-05-08  Tom Tromey  <tromey@adacore.com>
4214
4215         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4216         padding at end of comment.
4217
4218 2019-05-08  Tom Tromey  <tromey@adacore.com>
4219
4220         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4221         Compare main types.
4222
4223 2019-05-06  Tom Tromey  <tom@tromey.com>
4224
4225         * common/scoped_mmap.c: Include common-defs.h.
4226         * common/scoped_mmap.h: Don't include config.h.
4227
4228 2019-05-04  Tom Tromey  <tom@tromey.com>
4229
4230         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4231         (struct aarch64_call_info): Add initializers.
4232         <si>: Now a std::vector.
4233         (pass_on_stack, aarch64_push_dummy_call): Update.
4234
4235 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4236             Tom Tromey  <tom@tromey.com>
4237
4238         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4239         (ppc_threads): Now a std::vector.  Now static.
4240         (hwdebug_find_thread_points_by_tid)
4241         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4242         Update.
4243
4244 2019-05-04  Tom Tromey  <tom@tromey.com>
4245
4246         * arc-tdep.c (arc_tdesc_init): Return bool.
4247
4248 2019-05-04  Tom Tromey  <tom@tromey.com>
4249
4250         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4251         Use gdb_assert_not_reached.
4252
4253 2019-05-04  Tom Tromey  <tom@tromey.com>
4254
4255         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4256         "false".
4257
4258 2019-05-04  Tom Tromey  <tom@tromey.com>
4259
4260         * arc-tdep.c (arc_tdesc_init): Use bool.
4261
4262 2019-05-04  Tom Tromey  <tom@tromey.com>
4263
4264         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4265
4266 2019-05-04  Tom Tromey  <tom@tromey.com>
4267
4268         * cli/cli-cmds.c (valid_command_p): Return bool.
4269
4270 2019-05-04  Tom Tromey  <tom@tromey.com>
4271
4272         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4273         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4274
4275 2019-05-04  Raul Tambre  <raul@tambre.ee>
4276
4277         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4278         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4279         operator for comparison.
4280
4281 2019-05-04  Tom Tromey  <tom@tromey.com>
4282
4283         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4284         (lookup_partial_symbol, print_partial_symbols)
4285         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4286         (psymbol_compare): Update.
4287         (add_psymbol_to_bcache): Clear the entire psymbol.
4288         (maintenance_check_psymtabs): Update.
4289         * psympriv.h (struct partial_symbol): Don't derive from
4290         general_symbol_info.
4291         <obj_section, unrelocated_address, address,
4292         set_unrelocated_address>: Update.
4293         <ginfo>: New member.
4294         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4295         (debug_names::write_psymbols): Update.
4296
4297 2019-05-04  Tom de Vries  <tdevries@suse.de>
4298
4299         * contrib/cc-with-tweaks.sh: Support -n arg.
4300
4301 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4302
4303         * corelow.c (core_target::detach): Ensure frame cache and
4304         register caches are cleared.
4305         inferior.c (exit_inferior_1): Likewise.
4306
4307 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4308             Tom Tromey  <tom@tromey.com>
4309
4310         * dictionary.c (collate_pending_symbols_by_language): Remove
4311         "struct" from foreach.
4312         * symtab.c (lookup_global_symbol_from_objfile)
4313         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4314         foreach.
4315         * ser-tcp.c (net_open): Remove "struct" from foreach.
4316         * objfiles.c (objfile_relocate, objfile_rebase)
4317         (objfile_has_symbols): Remove "struct" from foreach.
4318         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4319         from foreach.
4320         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4321         foreach.
4322         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4323         "struct" from foreach.
4324         * ada-lang.c (create_excep_cond_exprs)
4325         (ada_exception_catchpoint_cond_string): Remove "struct" from
4326         foreach.
4327
4328 2019-05-03  Tom Tromey  <tromey@adacore.com>
4329
4330         * ada-exp.y (convert_char_literal): Check suffix of each
4331         enumerator.
4332
4333 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4334
4335         PR ada/21406:
4336         * ada-exp.y (yywrap): Don't define.
4337         * ada-lex.l (%option): Add noyywrap
4338         (yywrap): Remove.
4339
4340 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4341
4342         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4343         _WIN32_WINNT to the XP level, unless already defined to a higher
4344         level.
4345
4346         * unittests/parse-connection-spec-selftests.c:
4347         * ser-tcp.c:
4348         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4349         override.
4350
4351         * symfile.c (find_separate_debug_file): Remove colon from the
4352         drive spec of DOS/Windows file names of the target, so that the
4353         file name produced from DEBUGDIR and the target's directory will
4354         be valid on DOS/Windows systems.
4355
4356 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * rust-lang.c (val_print_struct): Handle printing structures
4359         containing strings.
4360
4361 2019-05-02  Tom Tromey  <tromey@adacore.com>
4362
4363         * valarith.c (_initialize_valarith): Remove.
4364
4365 2019-05-01  Tom Tromey  <tromey@adacore.com>
4366
4367         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4368         bitfields.
4369
4370 2019-05-01  Tom Tromey  <tromey@adacore.com>
4371
4372         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4373         for big-endian copies.
4374
4375 2019-04-30  Ali Tamur  <tamur@google.com>
4376         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4377         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4378         (read_3_bytes): New function.
4379
4380 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4381
4382         * windows-nat.c (main_thread_id): Delete.
4383         (handle_output_debug_string): Replace main_thread_id by
4384         current_event.dwThreadId.
4385         (fake_create_process): Likewise.
4386         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4387         Do not set main_thread_id.
4388         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4389         current_event.dwThreadId.
4390         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4391
4392 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4393
4394         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4395         Use current_event.dwThreadId instead of main_thread_id.
4396
4397 2019-04-30  Tom Tromey  <tromey@adacore.com>
4398
4399         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4400         (create_excep_cond_exprs): Iterate over program spaces.
4401         (ada_exception_catchpoint_cond_string): Examine all minimal
4402         symbols for exception types.
4403
4404 2019-04-30  Tom Tromey  <tromey@adacore.com>
4405
4406         PR c++/24470:
4407         * dwarf2read.c (process_structure_scope): Handle case where type
4408         has template parameters but no symbol was created.
4409
4410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4411             Chris January  <chris.january@arm.com>
4412
4413         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4414         qualifier.
4415         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4416
4417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * f-typeprint.c (f_print_type): Update rules for printing
4420         whitespace.
4421         (f_type_print_varspec_suffix): Likewise.
4422
4423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4424             Chris January  <chris.january@arm.com>
4425
4426         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4427         function arguments.
4428
4429 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * f-lang.c (build_fortran_types): Change name of void type to
4432         lower case.
4433         * f-typeprint.c (f_type_print_base): Print the name of the void
4434         type, rather than a fixed string.
4435         * f-valprint.c (f_decorations): Use lower case void string.
4436
4437 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4438             Chris January  <chris.january@arm.com>
4439
4440         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4441         types for Fortran.
4442
4443 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4444             Chris January  <chris.january@arm.com>
4445             David Lecomber  <david.lecomber@arm.com>
4446
4447         * f-exp.y (BINOP_INTRINSIC): New token.
4448         (exp): New parser rule handling BINOP_INTRINSIC.
4449         (f77_keywords): Add new builtin procedures.
4450         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4451         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4452         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4453         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4454         (print_unop_subexp_f): New function.
4455         (print_binop_subexp_f): New function.
4456         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4457         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4458         (dump_subexp_body_f): Likewise.
4459         (operator_check_f): Likewise.
4460         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4461         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4462
4463 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4466         UNOP_KIND.
4467         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4468         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4469         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4470         (operator_length_f): New fuction.
4471         (print_subexp_f): New function.
4472         (op_name_f): New function.
4473         (dump_subexp_body_f): New function.
4474         (operator_check_f): New function.
4475         (exp_descriptor_f): Replace standard expression handling functions
4476         with new functions.
4477         * gdb/fortran-operator.def: New file.
4478         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4479         * gdb/std-operator.def: Remove UNOP_KIND.
4480
4481 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * std-operator.def: Remove unbalanced, stray double quote
4484         character.
4485
4486 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4487             Chris January  <chris.january@arm.com>
4488             Daniel Everett  <daniel.everett@arm.com>
4489             Nick Forrington  <nick.forrington@arm.com>
4490             Richard Bunt  <richard.bunt@arm.com>
4491
4492         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4493         of depth when printing anonymous structs or unions.
4494         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4495         Don't print either the top-level value, or the children if the
4496         max-depth is exceeded.
4497         (ppscm_print_children): When printing the key of a map, allow one
4498         extra level of depth.
4499         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4500         print either the top-level value, or the children if the max-depth
4501         is exceeded.
4502         (print_children): When printing the key of a map, allow one extra
4503         level of depth.
4504         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4505         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4506         (user_print_options): Initialise max_depth field.
4507         (val_print_scalar_or_string_type_p): New function.
4508         (val_print): Check to see if the max depth has been reached.
4509         (val_print_check_max_depth): Define new function.
4510         (show_print_max_depth): New function.
4511         (_initialize_valprint): Add 'print max-depth' option.
4512         * valprint.h (struct value_print_options) <max_depth>: New field.
4513         (val_print_check_max_depth): Declare new function.
4514         * NEWS: Document new feature.
4515
4516 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * ada-lang.c (ada_language_defn): Initialise new field.
4519         * c-lang.c (c_is_string_type_p): New function.
4520         (c_language_defn): Initialise new field.
4521         (cplus_language_defn): Initialise new field.
4522         (asm_language_defn): Initialise new field.
4523         (minimal_language_defn): Initialise new field.
4524         * c-lang.h (c_is_string_type_p): Declare new function.
4525         * d-lang.c (d_language_defn): Initialise new field.
4526         * f-lang.c (f_is_string_type_p): New function.
4527         (f_language_defn): Initialise new field.
4528         * go-lang.c (go_is_string_type_p): New function.
4529         (go_language_defn): Initialise new field.
4530         * language.c (default_is_string_type_p): New function.
4531         (unknown_language_defn): Initialise new field.
4532         (auto_language_defn): Initialise new field.
4533         * language.h (struct language_defn) <la_is_string_type_p>: New
4534         member variable.
4535         (default_is_string_type_p): Declare new function.
4536         * m2-lang.c (m2_language_defn): Initialise new field.
4537         * objc-lang.c (objc_language_defn): Initialise new field.
4538         * opencl-lang.c (opencl_language_defn): Initialise new field.
4539         * p-lang.c (pascal_is_string_type_p): New function.
4540         (pascal_language_defn): Initialise new field.
4541         * rust-lang.c (rust_is_string_type_p): New function.
4542         (rust_language_defn): Initialise new field.
4543
4544 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4547         New field.
4548         * ada-lang.c (ada_language_defn): Initialise new field.
4549         * c-lang.c (c_language_defn): Likewise.
4550         (cplus_language_defn): Likewise.
4551         (asm_language_defn): Likewise.
4552         (minimal_language_defn): Likewise.
4553         * d-lang.c (d_language_defn): Likewise.
4554         * f-lang.c (f_language_defn): Likewise.
4555         * go-lang.c (go_language_defn): Likewise.
4556         * language.c (unknown_language_defn): Likewise.
4557         (auto_language_defn): Likewise.
4558         * m2-lang.c (m2_language_defn): Likewise.
4559         * objc-lang.c (objc_language_defn): Likewise.
4560         * opencl-lang.c (opencl_language_defn): Likewise.
4561         * p-lang.c (pascal_language_defn): Likewise.
4562         * rust-lang.c (rust_language_defn): Likewise.
4563
4564 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * ada-lang.c (ada_is_character_type): Change return type to bool.
4567         (ada_is_string_type): Likewise.
4568         * ada-lang.h (ada_is_character_type): Update declaration
4569         (ada_is_string_type): Likewise.
4570
4571 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4572
4573         Support style in 'frame|thread apply'
4574
4575         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4576         * record.c (record_start, record_stop): Update callers of
4577         execute_command_to_string with false.
4578         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4579         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4580         methods.
4581         (class string_file): New constructor with term_out parameter.
4582         Override methods term_out and can_emit_style_escape.  New member
4583         term_out.
4584         (class stdio_file): Override can_emit_style_escape.
4585         (class tee_file): Override term_out and can_emit_style_escape.
4586         * utils.h (can_emit_style_escape): Remove.
4587         * utils.c (can_emit_style_escape): Likewise.
4588         Update all callers of can_emit_style_escape (SOMESTREAM) to
4589         SOMESTREAM->can_emit_style_escape.
4590         * source-cache.c (source_cache::get_source_lines): Likewise.
4591         * stack.c (frame_apply_command_count): Call execute_command_to_string
4592         passing the term_out characteristic of the current gdb_stdout.
4593         * thread.c (thr_try_catch_cmd): Likewise.
4594         * top.c (execute_command_to_string): pass term_out parameter
4595         to construct the string_file for the command output.
4596         * ui-file.c (term_cli_styling): New function (most code moved
4597         from utils.c can_emit_style_escape).
4598         (string_file::string_file, string_file::can_emit_style_escape,
4599         stdio_file::can_emit_style_escape, tee_file::term_out,
4600         tee_file::can_emit_style_escape): New functions.
4601
4602 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4603
4604         * NEWS: Mention the new set|show may-call-functions.
4605         * infcall.c (may_call_functions_p): New variable.
4606         (show_may_call_functions_p): New function.
4607         (call_function_by_hand_dummy): Throws an error if not
4608         may-call-functions.
4609         (_initialize_infcall): Call add_setshow_boolean_cmd for
4610         may-call-functions.
4611
4612 2019-04-25  Keith Seitz  <keiths@redhat.com>
4613
4614         PR c++/24367
4615         * cp-support.c (inspect_type): Don't attempt substitutions
4616         of symbol with the same name.
4617
4618 2019-04-25  Tom Tromey  <tromey@adacore.com>
4619
4620         PR gdb/24475:
4621         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4622         static.
4623
4624 2019-04-25  Tom Tromey  <tromey@adacore.com>
4625
4626         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4627         rvalue reference.
4628         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4629         (gdb_xml_parser::parse): Use std::move.
4630         * python/python-internal.h (gdbpy_convert_exception): Take a const
4631         reference.
4632         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4633         std::move.
4634         * python/py-utils.c (gdbpy_convert_exception): Take a const
4635         reference.
4636         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4637         Use std::move.
4638         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4639         Use std::move.
4640         * mi/mi-main.c (mi_print_exception): Take a const reference.
4641         * main.c (handle_command_errors): Take a const reference.
4642         * linespec.c (parse_linespec): Use std::move.
4643         * infcall.c (run_inferior_call): Use std::move.
4644         (call_function_by_hand_dummy): Use std::move.
4645         * exec.c (try_open_exec_file): Use std::move.
4646         * exceptions.h (exception_print, exception_fprintf)
4647         (exception_print_same): Update.
4648         * exceptions.c (print_exception, exception_print)
4649         (exception_fprintf, exception_print_same): Change parameters to
4650         const reference.
4651         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4652         * common/new-op.c: Use std::move.
4653         * common/common-exceptions.h (struct gdb_exception): Add move
4654         constructor.
4655         (struct gdb_exception_error, struct gdb_exception_quit, struct
4656         gdb_quit_bad_alloc): Change constructor to move constructor.
4657         (throw_exception): Change parameter to rvalue reference.
4658         * common/common-exceptions.c (throw_exception): Take rvalue
4659         reference.
4660         * cli/cli-interp.c (safe_execute_command): Use std::move.
4661         * breakpoint.c (insert_bp_location, location_to_sals): Use
4662         std::move.
4663
4664 2019-04-25  Tom Tromey  <tromey@adacore.com>
4665
4666         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4667         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4668         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4669         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4670         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4671         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4672         guile/scm-value.c: Use unpack.
4673         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4674         gdbscm_gdb_exception.
4675         (gdbscm_throw_gdb_exception): Likewise.
4676         (struct gdbscm_gdb_exception): New.
4677         (unpack): New function.
4678         (gdbscm_wrap): Use unpack.
4679
4680 2019-04-25  Tom Tromey  <tromey@adacore.com>
4681
4682         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4683         (gdb_rl_callback_handler): Use std::move.
4684         * common/common-exceptions.h (struct gdb_exception): Add move
4685         assignment operator.
4686         (throw_exception_sjlj): Change "exception" to const reference.
4687         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4688         (throw_exception_sjlj): Change "exception" to const reference.
4689
4690 2019-04-25  Tom Tromey  <tromey@adacore.com>
4691
4692         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4693         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4694         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4695         Update.
4696         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4697         Update.
4698         * mi/mi-interp.c (mi_interp::exec): Update.
4699         * linespec.c (parse_linespec): Update.
4700         * infcall.c (run_inferior_call): Update.
4701         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4702         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4703         (gdbscm_lookup_global_symbol): Update.
4704         * guile/scm-param.c (gdbscm_parameter_value): Update.
4705         * guile/scm-frame.c (gdbscm_frame_read_register)
4706         (gdbscm_frame_read_var): Update.
4707         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4708         * exec.c (try_open_exec_file): Update.
4709         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4710         (gdb_rl_callback_handler): Update.
4711         * common/common-exceptions.h (exception_none): Don't declare.
4712         * common/common-exceptions.c (exception_none): Don't define.
4713         (struct catcher) <exception>: Update.
4714         * cli/cli-interp.c (safe_execute_command): Update.
4715         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4716
4717 2019-04-25  Ali Tamur  <tamur@google.com>
4718
4719         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4720         (read_attribute_value): Likewise.
4721         (dwarf2_read_addr_index): Update comment.
4722         (read_str_index): Add DW_FORM_strx.
4723         (dwarf2_string_attr): Likewise.
4724         (dwarf2_const_value_attr): Likewise.
4725         (dump_die_shallow): Likewise.
4726         (dwarf2_fetch_constant_bytes): Likewise.
4727         (skip_form_bytes): Likewise.
4728         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4729
4730 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4731
4732         PR corefiles/11608
4733         PR corefiles/18187
4734         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4735         OFFSET.  Verify if current mapping contains an ELF header.
4736         (linux_find_memory_regions_full): Adjust call to
4737         dump_mapping_p.
4738
4739 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4740             Kang Li <kanglictf@gmail.com>
4741
4742         PR gdb/21600
4743
4744         * dwarf2-frame.c (read_initial_length): Be consistent about using
4745         unsigned representation of length.
4746         (decode_frame_entry_1): Likewise.  Check for wraparound of
4747         end pointer as well as buffer overflow.
4748
4749 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4750
4751         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4752         "vq".
4753
4754 2019-04-24  Tom Tromey  <tromey@adacore.com>
4755
4756         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4757
4758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * s12z-tdep.c (s12z_unwind_pc): Delete.
4761         (s12z_unwind_sp): Delete.
4762         (s12z_gdbarch_init): Don't register deleted functions with
4763         gdbarch.
4764
4765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * rl78-tdep.c (rl78_unwind_sp): Delete.
4768         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4769
4770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4771
4772         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4773         (xstormy16_unwind_pc): Delete.
4774         (xstormy16_dummy_id): Delete.
4775         (xstormy16_gdbarch_init): Don't register deleted functions with
4776         gdbarch.
4777
4778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4779
4780         * vax-tdep.c (vax_unwind_pc): Delete.
4781         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4782
4783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * v850-tdep.c (v850_unwind_sp): Delete.
4786         (v850_unwind_pc): Delete.
4787         (v850_dummy_id): Delete.
4788         (v850_gdbarch_init): Don't register deleted functions with
4789         gdbarch.
4790
4791 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4792
4793         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4794         (tilegx_unwind_pc): Delete.
4795         (tilegx_unwind_dummy_id): Delete.
4796         (tilegx_gdbarch_init): Don't register deleted functions with
4797         gdbarch.
4798
4799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4802         (tic6x_dummy_id): Delete.
4803         (tic6x_gdbarch_init): Don't register deleted functions with
4804         gdbarch.
4805
4806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         * sparc-tdep.c (sparc_unwind_pc): Delete.
4809         (sparc32_gdbarch_init): Don't register deleted function with
4810         gdbarch.
4811
4812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4813
4814         * sh-tdep.c (sh_unwind_sp): Delete.
4815         (sh_unwind_pc): Delete.
4816         (sh_dummy_id): Delete.
4817         (sh_gdbarch_init): Don't register deleted functions with
4818         gdbarch.
4819
4820 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4821
4822         * score-tdep.c (score_unwind_sp): Delete.
4823         (score_unwind_pc): Delete.
4824         (score_dummy_id): Delete.
4825         (score_gdbarch_init): Don't register deleted functions with
4826         gdbarch.
4827
4828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * rx-tdep.c (rx_unwind_pc): Delete.
4831         (rx_unwind_sp): Delete.
4832         (rx_dummy_id): Delete.
4833         (rx_gdbarch_init): Don't register deleted functions with
4834         gdbarch.  Update comment.
4835
4836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4839         (rs6000_dummy_id): Delete.
4840         (rs6000_gdbarch_init): Don't register deleted functions with
4841         gdbarch.
4842
4843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * or1k-tdep.c (or1k_dummy_id): Delete.
4846         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4847
4848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         * nios2-tdep.c (nios2_dummy_id): Delete.
4851         (nios2_unwind_sp): Delete.
4852         (nios2_gdbarch_init): Don't register deleted functions with
4853         gdbarch.
4854
4855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         * nds32-tdep.c (nds32_dummy_id): Delete.
4858         (nds32_unwind_pc): Delete.
4859         (nds32_unwind_sp): Delete.
4860         (nds32_gdbarch_init): Don't register deleted functions with
4861         gdbarch.
4862
4863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * msp430-tdep.c (msp430_unwind_pc): Delete.
4866         (msp430_unwind_sp): Delete.
4867         (msp430_dummy_id): Delete.
4868         (msp430_gdbarch_init): Don't register deleted functions with
4869         gdbarch.
4870
4871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * moxie-tdep.c (moxie_unwind_sp): Delete.
4874         (moxie_unwind_pc): Delete.
4875         (moxie_dummy_id): Delete.
4876         (moxie_gdbarch_init): Don't register deleted functions with
4877         gdbarch.
4878
4879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4880
4881         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4882         (mn10300_unwind_pc): Delete.
4883         (mn10300_unwind_sp): Delete.
4884         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4885         mn10300_unwind_sp.
4886         (mn10300_frame_unwind_init): Don't register deleted functions with
4887         gdbarch.
4888
4889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * mep-tdep.c (mep_unwind_pc): Delete.
4892         (mep_unwind_sp): Delete.
4893         (mep_dummy_id): Delete.
4894         (mep_gdbarch_init): Don't register deleted functions with
4895         gdbarch.
4896
4897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4900         (m68hc11_unwind_sp): Delete.
4901         (m68hc11_gdbarch_init): Don't register deleted functions with
4902         gdbarch.
4903
4904 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * m32r-tdep.c (m32r_unwind_sp): Delete.
4907         (m32r_unwind_pc): Delete.
4908         (m32r_dummy_id): Delete.
4909         (m32r_gdbarch_init): Don't register deleted functions with
4910         gdbarch.
4911
4912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * m32c-tdep.c (m32c_unwind_pc): Delete.
4915         (m32c_unwind_sp): Delete.
4916         (m32c_dummy_id): Delete.
4917         (m32c_gdbarch_init): Don't register deleted functions with
4918         gdbarch.
4919
4920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4923         (lm32_unwind_pc): Delete.
4924         (lm32_dummy_id): Delete.
4925         (lm32_gdbarch_init): Don't register deleted functions with
4926         gdbarch.
4927
4928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4931         (iq2000_unwind_pc): Delete.
4932         (iq2000_dummy_id): Delete.
4933         (iq2000_gdbarch_init): Don't register deleted functions with
4934         gdbarch.
4935
4936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * nds32-tdep.c (nds32_type_align): Delete.
4939         (nds32_push_dummy_call): Use type_align instead.
4940
4941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * arm-tdep.c (arm_type_align): Only handle vector override case.
4944         (arm_push_dummy_call): Use type_align.
4945         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4950         case.
4951         (pass_on_stack): Use type_align.
4952         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4953         function.
4954
4955 2019-04-23  Tom Tromey  <tromey@adacore.com>
4956
4957         * dwarf2read.c (line_header::file_name_at): Remove unused
4958         overload.
4959
4960 2019-04-23  Tom de Vries  <tdevries@suse.de>
4961
4962         PR gdb/24438
4963         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4964         invocation.
4965
4966
4967 2019-03-27  Ali Tamur  <tamur@google.com>
4968
4969         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4970         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4971         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4972         (dwarf_expr_context::get_addr_index): Likewise
4973         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4974         (symbol_needs_eval_context::get_addr_index): Likewise
4975         (disassemble_dwarf_expression): Add DW_OP_addrx
4976         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4977         (read_cutu_die_from_dwo): Update comment
4978         (skip_one_die): Add DW_FORM_addrx
4979         (read_attribute_value): Likewise
4980         (var_decode_location): Add DW_OP_addrx
4981         (dwarf2_const_value_attr): Add DW_FORM_addrx
4982         (dump_die_shallow): Likewise
4983         (dwarf2_fetch_constant_bytes): Likewise
4984         (decode_locdesc): Add DW_OP_addrx
4985         (skip_form_bytes): Add DW_FORM_addrx
4986
4987 2019-04-22  Ali Tamur  <tamur@google.com>
4988
4989         * MAINTAINERS (Write After Approval): Add self.
4990
4991 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4992
4993         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4994         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4995         (open_symbol_file_object): Likewise.
4996         (svr4_default_sos): Add info parameter.
4997         (svr4_read_so_list): Likewise.
4998         (svr4_current_sos_direct): Adjust functions calls to pass down
4999         info.
5000         (svr4_current_sos_1): Add info parameter.
5001         (svr4_current_sos): Call get_svr4_info, pass info down to
5002         svr4_current_sos_1.
5003         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5004         get_svr4_info.
5005         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5006         get_svr4_info.
5007         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5008         to get_svr4_info.
5009         (probes_table_remove_objfile_probes): Likewise.
5010         (register_solib_event_probe): Add info parameter.
5011         (solist_update_incremental): Pass info parameter down to
5012         svr4_read_so_list.
5013         (disable_probes_interface): Add info parameter.
5014         (svr4_handle_solib_event): Pass current_program_space to
5015         get_svr4_info.  Adjust disable_probes_interface cleanup.
5016         (svr4_create_probe_breakpoints): Add info parameter, pass it
5017         down to register_solib_event_probe.
5018         (svr4_create_solib_event_breakpoints): Add info parameter,
5019         pass it down to svr4_create_probe_breakpoints.
5020         (enable_break): Pass info down to
5021         svr4_create_solib_event_breakpoints.
5022         (svr4_solib_create_inferior_hook): Pass current_program_space to
5023         get_svr4_info.
5024         (svr4_clear_solib): Likewise.
5025
5026 2019-04-22  Pedro Alves  <palves@redhat.com>
5027
5028         * solib-svr4.c (svr4_free_objfile_observer): New.
5029         (probe_and_action::objfile): New field.
5030         (probes_table_htab_remove_objfile_probes)
5031         (probes_table_remove_objfile_probes): New functions.
5032         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5033         in the new probe_and_action.  Don't store the probe in 'lookup'.
5034         (svr4_create_probe_breakpoints): Pass objfile to
5035         register_solib_event_probe.
5036         (_initialize_svr4_solib): Register a free_objfile observer.
5037
5038 2019-04-19  Tom Tromey  <tom@tromey.com>
5039
5040         * common/queue.h: Remove.
5041
5042 2019-04-19  Tom Tromey  <tom@tromey.com>
5043
5044         * event-loop.c: Don't include "common/queue.h".
5045
5046 2019-04-19  Tom Tromey  <tom@tromey.com>
5047
5048         * remote.c (remote_target): Use delete.
5049         * remote-notif.h: Include <list>, not "common/queue.h".
5050         (notif_client_p): Remove typedef.
5051         (remote_notif_state): Add constructor, destructor, initializer.
5052         <notif_queue>: Now a std::list.
5053         (remote_notif_state_xfree): Don't declare.
5054         * remote-notif.c (remote_notif_process, handle_notification)
5055         (remote_notif_state_allocate): Update.
5056         (~remote_notif_state): Rename from remote_notif_state_xfree.
5057
5058 2019-04-19  Tom Tromey  <tom@tromey.com>
5059
5060         * symfile.c (reread_symbols): Update.
5061         * objfiles.c (objfile_register_static_link)
5062         (objfile_lookup_static_link): Update
5063         (~objfile) Don't delete static_links.
5064         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5065
5066 2019-04-19  Tom Tromey  <tom@tromey.com>
5067
5068         * type-stack.h (struct type_stack) <insert>: Constify string.
5069         * type-stack.c (type_stack::insert): Constify string.
5070         * gdbtypes.h (lookup_template_type): Update.
5071         (address_space_name_to_int): Update.
5072         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5073         const.
5074         (lookup_template_type): Make name const.
5075         * c-exp.y: Update rules.
5076         (lex_one_token, classify_name, classify_inner_name)
5077         (c_print_token): Update.
5078         * p-exp.y: Update rules.
5079         (yylex): Update.
5080         * f-exp.y: Update rules.
5081         (yylex): Update.
5082         * d-exp.y: Update rules.
5083         (lex_one_token, classify_name, classify_inner_name): Update.
5084         * parse.c (write_dollar_variable, copy_name): Return std::string.
5085         * parser-defs.h (copy_name): Change return type.
5086         * m2-exp.y: Update rules.
5087         (yylex): Update.
5088         * go-exp.y (lex_one_token): Update.
5089         Update rules.
5090         (classify_unsafe_function, classify_packaged_name)
5091         (classify_name, yylex): Update.
5092
5093 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5094
5095         * configure.ac: add --enable-source-highlight switch.
5096         * configure: Regenerate.
5097         * top.c (print_gdb_version): plumb --enable-source-highlight
5098         status to "show configuration".
5099
5100 2019-04-19  Tom Tromey  <tromey@adacore.com>
5101
5102         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5103         Check ADA_TYPE_P.
5104         (empty_record, ada_template_to_fixed_record_type_1)
5105         (template_to_static_fixed_type)
5106         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5107         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5108         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5109         macros.
5110
5111 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5112
5113         PR symtab/24423:
5114         * source.c (print_source_lines_base): Advance "iter" when a
5115         control character is seen.
5116
5117 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5118
5119         * inferior.h (struct infcall_suspend_state_deleter):
5120         Catch exception in destructor to avoid crash.
5121
5122 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5123
5124         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5125         close to the add_com "shell".
5126
5127 2019-04-18  Tom Tromey  <tromey@adacore.com>
5128
5129         * process-stratum-target.h (class process_stratum_target)
5130         <stratum>: Add "final".
5131
5132 2019-04-17  Tom Tromey  <tromey@adacore.com>
5133
5134         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5135         against nullptr before use.
5136
5137 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5138
5139         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5140
5141 2019-04-17  Jim Wilson  <jimw@sifive.com>
5142             Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5145         code read might fail, assume 4-byte breakpoint in that case.
5146
5147 2019-04-15  Leszek Swirski  <leszeks@google.com>
5148
5149         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5150         rather than a hand-rolled POD check when checking for forced MEMORY
5151         classification.
5152
5153 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5154
5155         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5156         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5157         function.
5158         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5159         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5160         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5161         declaration.
5162
5163 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5164
5165         * aarch64-linux-nat.c
5166         (aarch64_linux_nat_target::thread_architecture): Add override.
5167         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5168         each VQ.
5169
5170 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5171
5172         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5173
5174 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5177         target types of size 96-bits, add some additional comments, and
5178         check that the builtin type we found was the correct size.
5179
5180 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5181
5182         * utils.c (prompt_for_continue): Don't restore the styling at the
5183         end, as applied_style has the wrong value.  This fixes styling in
5184         long lists of file names that are interrupted by the "Continue?"
5185         prompt.
5186
5187 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5188
5189         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5190         * c-lang.c (c_language_defn): Likewise.
5191         (cplus_language_defn): Likewise.
5192         (asm_language_defn): Likewise.
5193         (minimal_language_defn): Likewise.
5194         * d-lang.c (d_language_defn): Likewise.
5195         * f-lang.c (f_language_defn): Likewise.
5196         * go-lang.c (go_language_defn): Likewise.
5197         * language.c (unknown_language_defn): Likewise.
5198         (auto_language_defn): Likewise.
5199         * language.h (struct language_defn): Remove la_magic field.
5200         (LANG_MAGIC): Delete.
5201         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5202         * objc-lang.c (objc_language_defn): Likewise.
5203         * opencl-lang.c (opencl_language_defn): Likewise.
5204         * p-lang.c (pascal_language_defn): Likewise.
5205         * rust-lang.c (rust_language_defn): Likewise.
5206
5207 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5208
5209         * riscv-tdep.c (riscv_type_align): New function.
5210         (riscv_type_alignment): Delete.
5211         (riscv_arg_location): Use 'type_align'.
5212         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5213
5214 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5215
5216         * gdbtypes.c (type_align): A struct with no non-static fields also
5217         has alignment of 1.
5218
5219 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5222         component to 0.
5223         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5224         member.
5225         (riscv_struct_info::analyse): New implementation using new
5226         analyse_inner member function.
5227         (riscv_struct_info::field_offset): New member function.
5228         (riscv_struct_info::m_offsets): New member variable.
5229         (riscv_struct_info::analyse_inner): New private member function,
5230         takes the old implementation of riscv_struct_info::analyse but
5231         extended to track field offsets.
5232         (riscv_call_arg_struct): Update the struct folding special cases
5233         to handle cases where empty C++ structs, which are non-zero
5234         length, are found.
5235         (riscv_arg_location): Initialise the length of each location, a
5236         non-zero length now indicates the location is in use.
5237         (riscv_push_dummy_call): Allow for the first location having a
5238         non-zero offset when setting up arguments.
5239         (riscv_return_value): Likewise, but for return values.
5240
5241 2019-04-11  Tom Tromey  <tromey@adacore.com>
5242
5243         * utils.c (internal_vproblem): Make "msg" const.
5244
5245 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5248         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5249         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5250         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5251
5252 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5253
5254         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5255         function.
5256         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5257         of amd64_collect_native_gregset.
5258         (amd64_linux_nat_target::store_registers): Likewise.
5259
5260 2019-04-10  Tom Tromey  <tom@tromey.com>
5261
5262         * symtab.c (lookup_global_symbol_from_objfile)
5263         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5264         * objfiles.h (class separate_debug_iterator): New.
5265         (class separate_debug_range): New.
5266         (struct objfile) <separate_debug_objfiles>: New method.
5267         (objfile_separate_debug_iterate): Don't declare.
5268         * objfiles.c (separate_debug_iterator::operator++): Rename from
5269         objfile_separate_debug_iterate.
5270         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5271         iterator.
5272         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5273         iterator.
5274
5275 2019-04-10  Tom Tromey  <tom@tromey.com>
5276
5277         * symfile.c (reread_symbols): Remove old comment.
5278         * objfiles.c (free_all_objfiles): Fix a typo.
5279
5280 2019-04-10  Tom Tromey  <tom@tromey.com>
5281
5282         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5283         * minsyms.c (lookup_minimal_symbol): Use foreach.
5284         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5285         (lookup_minimal_symbol_solib_trampoline): Likewise.
5286         * symfile.c (reread_symbols): Use foreach.
5287
5288 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5289             Tom Tromey  <tromey@adacore.com>
5290
5291         PR rust/24414:
5292         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5293         (rust_lex_int_test): Change "value" to be LONGEST.
5294         (rust_lex_tests): Add test for long integer literal.
5295
5296 2019-04-09  Tom Tromey  <tromey@adacore.com>
5297
5298         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5299         to bool.
5300         (extended_remote_target::attach): Update.
5301         (remote_target::remote_notice_new_inferior): Update.
5302         (remote_target::add_current_inferior_and_thread): Update.
5303         * inferior.c (exit_inferior_1): Use "false".
5304         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5305
5306 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5307
5308         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5309         the "start" command.
5310
5311 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5312
5313         * python/py-inferior.c (infpy_thread_from_thread_handle):
5314         Adjust comments to reflect renaming of thread_from_thread_handle
5315         to thread_from_handle.  Adjust keywords.  Fix type error message.
5316         (inferior_object_methods): Add thread_from_handle.  Retain
5317         thread_from_thread_handle, but mark it as deprecated.
5318
5319 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5320
5321         * gdbthread.h (find_thread_by_handle): Revise declaration.
5322         * thread.c (find_thread_by_handle): Likewise.  Adjust
5323         implementation too.
5324         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5325         support for buffer objects as handles.
5326
5327 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5328
5329         * python/py-infthread.c (thpy_thread_handle): New function.
5330         (thread_object_methods): Register thpy_thread_handle.
5331
5332 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5333
5334         * gdbthread.h (thread_to_thread_handle): Declare.
5335         * thread.c (gdbtypes.h): Include.
5336         (thread_to_thread_handle): New function.
5337
5338         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5339         (target_thread_info_to_thread_handle): Declare.
5340         * target.c (target_thread_info_to_thread_handle): New function.
5341         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5342         * target-delegates.c: Regenerate.
5343
5344         * linux-thread-db.c (class thread_db_target): Add method
5345         thread_info_to_thread_handle.
5346         (thread_db_target::thread_info_to_thread_handle): Define.
5347         * remote.c (class remote_target): Add new method
5348         thread_info_to_thread_handle.
5349         (remote_target::thread_info_to_thread_handle): Define.
5350
5351 2019-04-08  Pedro Alves  <palves@redhat.com>
5352
5353         * common/common-exceptions.c (throw_exception): Don't create
5354         named object to throw; throw directly.
5355         (throw_it): Likewise.  Don't initialize gdb_exception::message
5356         here, with new; pass FMT and AP to the ctor instead.
5357         * common/common-exceptions.h: Include <string>.
5358         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5359         const char *, va_list)): New ctor.  Use std::make_shared.
5360         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5361         errors)): Delete.
5362         (gdb_exception_error::gdb_exception_error(enum errors, const char
5363         *, va_list)): New.
5364         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5365         Add assertion.
5366         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5367         errors)): Delete.
5368         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5369         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5370         Add assertion.
5371
5372 2019-04-08  Tom Tromey  <tom@tromey.com>
5373
5374         * valops.c (value_rtti_indirect_type): Replace throw_exception
5375         with throw.
5376         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5377         with throw.
5378         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5379         throw.
5380         * target.c (target_translate_tls_address): Replace throw_exception
5381         with throw.
5382         * stack.c (frame_apply_command_count): Replace throw_exception
5383         with throw.
5384         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5385         throw.
5386         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5387         with throw.
5388         * rs6000-tdep.c (rs6000_frame_cache)
5389         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5390         * remote.c: Replace throw_exception with throw.
5391         * record-full.c (record_full_message, record_full_wait_1)
5392         (record_full_restore): Replace throw_exception with throw.
5393         * record-btrace.c:
5394         (get_thread_current_frame_id, record_btrace_start_replaying)
5395         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5396         (cmd_record_btrace_start): Replace throw_exception with throw.
5397         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5398         throw.
5399         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5400         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5401         * linespec.c:
5402         (find_linespec_symbols): Replace throw_exception with throw.
5403         * infrun.c (displaced_step_prepare, resume): Replace
5404         throw_exception with throw.
5405         * infcmd.c (post_create_inferior): Replace throw_exception with
5406         throw.
5407         * inf-loop.c (inferior_event_handler): Replace throw_exception
5408         with throw.
5409         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5410         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5411         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5412         (get_prev_frame_always, get_frame_pc_if_available)
5413         (get_frame_address_in_block_if_available, get_frame_language):
5414         Replace throw_exception with throw.
5415         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5416         throw_exception with throw.
5417         * eval.c (fetch_subexp_value, evaluate_var_value)
5418         (evaluate_funcall, evaluate_subexp_standard): Replace
5419         throw_exception with throw.
5420         * dwarf2loc.c (call_site_find_chain)
5421         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5422         Replace throw_exception with throw.
5423         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5424         with throw.
5425         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5426         throw.
5427         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5428         * completer.c (complete_line_internal): Replace throw_exception
5429         with throw.
5430         * compile/compile-object-run.c (compile_object_run): Replace
5431         throw_exception with throw.
5432         * cli/cli-script.c (process_next_line): Replace throw_exception
5433         with throw.
5434         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5435         (btrace_enable, btrace_maint_update_pt_packets): Replace
5436         throw_exception with throw.
5437         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5438         throw_exception with throw.
5439         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5440         throw_exception with throw.
5441         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5442         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5443         * aarch64-tdep.c (aarch64_make_prologue_cache)
5444         (aarch64_make_stub_cache): Replace throw_exception with throw.
5445
5446 2019-04-08  Tom Tromey  <tom@tromey.com>
5447
5448         * common/common-exceptions.c (throw_exception): Rename from
5449         throw_exception_cxx.  Remove old copy.  Make argument const.
5450         (throw_it): Create and throw exception objects directly.
5451         * common/common-exceptions.h (throw_exception): Make argument
5452         const.
5453         (struct gdb_exception_error): Add constructor.
5454         (struct gdb_exception_quit): Add constructor.
5455
5456 2019-04-08  Tom Tromey  <tom@tromey.com>
5457
5458         * common/common-exceptions.h (exception_rethrow): Don't declare.
5459         (TRY_SJLJ): Update comment.
5460         (TRY, CATCH, END_CATCH): Remove.
5461         * common/common-exceptions.c (exception_rethrow): Remove.
5462
5463 2019-04-08  Tom Tromey  <tom@tromey.com>
5464
5465         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5466         Remove.
5467         (gdb_exception_error): Rename from
5468         gdb_exception_RETURN_MASK_ERROR.
5469         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5470         (gdb_quit_bad_alloc): Update.
5471         * aarch64-tdep.c: Update.
5472         * ada-lang.c: Update.
5473         * ada-typeprint.c: Update.
5474         * ada-valprint.c: Update.
5475         * amd64-tdep.c: Update.
5476         * arch-utils.c: Update.
5477         * break-catch-throw.c: Update.
5478         * breakpoint.c: Update.
5479         * btrace.c: Update.
5480         * c-varobj.c: Update.
5481         * cli/cli-cmds.c: Update.
5482         * cli/cli-interp.c: Update.
5483         * cli/cli-script.c: Update.
5484         * common/common-exceptions.c: Update.
5485         * common/new-op.c: Update.
5486         * common/selftest.c: Update.
5487         * compile/compile-c-symbols.c: Update.
5488         * compile/compile-cplus-symbols.c: Update.
5489         * compile/compile-object-load.c: Update.
5490         * compile/compile-object-run.c: Update.
5491         * completer.c: Update.
5492         * corelow.c: Update.
5493         * cp-abi.c: Update.
5494         * cp-support.c: Update.
5495         * cp-valprint.c: Update.
5496         * darwin-nat.c: Update.
5497         * disasm-selftests.c: Update.
5498         * dtrace-probe.c: Update.
5499         * dwarf-index-cache.c: Update.
5500         * dwarf-index-write.c: Update.
5501         * dwarf2-frame-tailcall.c: Update.
5502         * dwarf2-frame.c: Update.
5503         * dwarf2loc.c: Update.
5504         * dwarf2read.c: Update.
5505         * eval.c: Update.
5506         * event-loop.c: Update.
5507         * event-top.c: Update.
5508         * exec.c: Update.
5509         * f-valprint.c: Update.
5510         * fbsd-tdep.c: Update.
5511         * frame-unwind.c: Update.
5512         * frame.c: Update.
5513         * gdbtypes.c: Update.
5514         * gnu-v3-abi.c: Update.
5515         * guile/guile-internal.h: Update.
5516         * guile/scm-block.c: Update.
5517         * guile/scm-breakpoint.c: Update.
5518         * guile/scm-cmd.c: Update.
5519         * guile/scm-disasm.c: Update.
5520         * guile/scm-frame.c: Update.
5521         * guile/scm-lazy-string.c: Update.
5522         * guile/scm-math.c: Update.
5523         * guile/scm-param.c: Update.
5524         * guile/scm-ports.c: Update.
5525         * guile/scm-pretty-print.c: Update.
5526         * guile/scm-symbol.c: Update.
5527         * guile/scm-symtab.c: Update.
5528         * guile/scm-type.c: Update.
5529         * guile/scm-value.c: Update.
5530         * i386-linux-tdep.c: Update.
5531         * i386-tdep.c: Update.
5532         * inf-loop.c: Update.
5533         * infcall.c: Update.
5534         * infcmd.c: Update.
5535         * infrun.c: Update.
5536         * jit.c: Update.
5537         * language.c: Update.
5538         * linespec.c: Update.
5539         * linux-fork.c: Update.
5540         * linux-nat.c: Update.
5541         * linux-tdep.c: Update.
5542         * linux-thread-db.c: Update.
5543         * main.c: Update.
5544         * mi/mi-cmd-break.c: Update.
5545         * mi/mi-cmd-stack.c: Update.
5546         * mi/mi-interp.c: Update.
5547         * mi/mi-main.c: Update.
5548         * objc-lang.c: Update.
5549         * p-valprint.c: Update.
5550         * parse.c: Update.
5551         * ppc-linux-tdep.c: Update.
5552         * printcmd.c: Update.
5553         * python/py-arch.c: Update.
5554         * python/py-breakpoint.c: Update.
5555         * python/py-cmd.c: Update.
5556         * python/py-finishbreakpoint.c: Update.
5557         * python/py-frame.c: Update.
5558         * python/py-framefilter.c: Update.
5559         * python/py-gdb-readline.c: Update.
5560         * python/py-inferior.c: Update.
5561         * python/py-infthread.c: Update.
5562         * python/py-lazy-string.c: Update.
5563         * python/py-linetable.c: Update.
5564         * python/py-objfile.c: Update.
5565         * python/py-param.c: Update.
5566         * python/py-prettyprint.c: Update.
5567         * python/py-progspace.c: Update.
5568         * python/py-record-btrace.c: Update.
5569         * python/py-record.c: Update.
5570         * python/py-symbol.c: Update.
5571         * python/py-type.c: Update.
5572         * python/py-unwind.c: Update.
5573         * python/py-utils.c: Update.
5574         * python/py-value.c: Update.
5575         * python/python.c: Update.
5576         * record-btrace.c: Update.
5577         * record-full.c: Update.
5578         * remote-fileio.c: Update.
5579         * remote.c: Update.
5580         * riscv-tdep.c: Update.
5581         * rs6000-aix-tdep.c: Update.
5582         * rs6000-tdep.c: Update.
5583         * rust-exp.y: Update.
5584         * rust-lang.c: Update.
5585         * s390-tdep.c: Update.
5586         * selftest-arch.c: Update.
5587         * solib-dsbt.c: Update.
5588         * solib-frv.c: Update.
5589         * solib-spu.c: Update.
5590         * solib-svr4.c: Update.
5591         * solib.c: Update.
5592         * sparc64-linux-tdep.c: Update.
5593         * stack.c: Update.
5594         * symfile-mem.c: Update.
5595         * symmisc.c: Update.
5596         * target.c: Update.
5597         * thread.c: Update.
5598         * top.c: Update.
5599         * tracefile-tfile.c: Update.
5600         * tui/tui.c: Update.
5601         * typeprint.c: Update.
5602         * unittests/cli-utils-selftests.c: Update.
5603         * unittests/parse-connection-spec-selftests.c: Update.
5604         * valops.c: Update.
5605         * valprint.c: Update.
5606         * value.c: Update.
5607         * varobj.c: Update.
5608         * windows-nat.c: Update.
5609         * x86-linux-nat.c: Update.
5610         * xml-support.c: Update.
5611
5612 2019-04-08  Tom Tromey  <tom@tromey.com>
5613
5614         * xml-support.c: Use C++ exception handling.
5615         * x86-linux-nat.c: Use C++ exception handling.
5616         * windows-nat.c: Use C++ exception handling.
5617         * varobj.c: Use C++ exception handling.
5618         * value.c: Use C++ exception handling.
5619         * valprint.c: Use C++ exception handling.
5620         * valops.c: Use C++ exception handling.
5621         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5622         handling.
5623         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5624         * typeprint.c: Use C++ exception handling.
5625         * tui/tui.c: Use C++ exception handling.
5626         * tracefile-tfile.c: Use C++ exception handling.
5627         * top.c: Use C++ exception handling.
5628         * thread.c: Use C++ exception handling.
5629         * target.c: Use C++ exception handling.
5630         * symmisc.c: Use C++ exception handling.
5631         * symfile-mem.c: Use C++ exception handling.
5632         * stack.c: Use C++ exception handling.
5633         * sparc64-linux-tdep.c: Use C++ exception handling.
5634         * solib.c: Use C++ exception handling.
5635         * solib-svr4.c: Use C++ exception handling.
5636         * solib-spu.c: Use C++ exception handling.
5637         * solib-frv.c: Use C++ exception handling.
5638         * solib-dsbt.c: Use C++ exception handling.
5639         * selftest-arch.c: Use C++ exception handling.
5640         * s390-tdep.c: Use C++ exception handling.
5641         * rust-lang.c: Use C++ exception handling.
5642         * rust-exp.y: Use C++ exception handling.
5643         * rs6000-tdep.c: Use C++ exception handling.
5644         * rs6000-aix-tdep.c: Use C++ exception handling.
5645         * riscv-tdep.c: Use C++ exception handling.
5646         * remote.c: Use C++ exception handling.
5647         * remote-fileio.c: Use C++ exception handling.
5648         * record-full.c: Use C++ exception handling.
5649         * record-btrace.c: Use C++ exception handling.
5650         * python/python.c: Use C++ exception handling.
5651         * python/py-value.c: Use C++ exception handling.
5652         * python/py-utils.c: Use C++ exception handling.
5653         * python/py-unwind.c: Use C++ exception handling.
5654         * python/py-type.c: Use C++ exception handling.
5655         * python/py-symbol.c: Use C++ exception handling.
5656         * python/py-record.c: Use C++ exception handling.
5657         * python/py-record-btrace.c: Use C++ exception handling.
5658         * python/py-progspace.c: Use C++ exception handling.
5659         * python/py-prettyprint.c: Use C++ exception handling.
5660         * python/py-param.c: Use C++ exception handling.
5661         * python/py-objfile.c: Use C++ exception handling.
5662         * python/py-linetable.c: Use C++ exception handling.
5663         * python/py-lazy-string.c: Use C++ exception handling.
5664         * python/py-infthread.c: Use C++ exception handling.
5665         * python/py-inferior.c: Use C++ exception handling.
5666         * python/py-gdb-readline.c: Use C++ exception handling.
5667         * python/py-framefilter.c: Use C++ exception handling.
5668         * python/py-frame.c: Use C++ exception handling.
5669         * python/py-finishbreakpoint.c: Use C++ exception handling.
5670         * python/py-cmd.c: Use C++ exception handling.
5671         * python/py-breakpoint.c: Use C++ exception handling.
5672         * python/py-arch.c: Use C++ exception handling.
5673         * printcmd.c: Use C++ exception handling.
5674         * ppc-linux-tdep.c: Use C++ exception handling.
5675         * parse.c: Use C++ exception handling.
5676         * p-valprint.c: Use C++ exception handling.
5677         * objc-lang.c: Use C++ exception handling.
5678         * mi/mi-main.c: Use C++ exception handling.
5679         * mi/mi-interp.c: Use C++ exception handling.
5680         * mi/mi-cmd-stack.c: Use C++ exception handling.
5681         * mi/mi-cmd-break.c: Use C++ exception handling.
5682         * main.c: Use C++ exception handling.
5683         * linux-thread-db.c: Use C++ exception handling.
5684         * linux-tdep.c: Use C++ exception handling.
5685         * linux-nat.c: Use C++ exception handling.
5686         * linux-fork.c: Use C++ exception handling.
5687         * linespec.c: Use C++ exception handling.
5688         * language.c: Use C++ exception handling.
5689         * jit.c: Use C++ exception handling.
5690         * infrun.c: Use C++ exception handling.
5691         * infcmd.c: Use C++ exception handling.
5692         * infcall.c: Use C++ exception handling.
5693         * inf-loop.c: Use C++ exception handling.
5694         * i386-tdep.c: Use C++ exception handling.
5695         * i386-linux-tdep.c: Use C++ exception handling.
5696         * guile/scm-value.c: Use C++ exception handling.
5697         * guile/scm-type.c: Use C++ exception handling.
5698         * guile/scm-symtab.c: Use C++ exception handling.
5699         * guile/scm-symbol.c: Use C++ exception handling.
5700         * guile/scm-pretty-print.c: Use C++ exception handling.
5701         * guile/scm-ports.c: Use C++ exception handling.
5702         * guile/scm-param.c: Use C++ exception handling.
5703         * guile/scm-math.c: Use C++ exception handling.
5704         * guile/scm-lazy-string.c: Use C++ exception handling.
5705         * guile/scm-frame.c: Use C++ exception handling.
5706         * guile/scm-disasm.c: Use C++ exception handling.
5707         * guile/scm-cmd.c: Use C++ exception handling.
5708         * guile/scm-breakpoint.c: Use C++ exception handling.
5709         * guile/scm-block.c: Use C++ exception handling.
5710         * guile/guile-internal.h: Use C++ exception handling.
5711         * gnu-v3-abi.c: Use C++ exception handling.
5712         * gdbtypes.c: Use C++ exception handling.
5713         * frame.c: Use C++ exception handling.
5714         * frame-unwind.c: Use C++ exception handling.
5715         * fbsd-tdep.c: Use C++ exception handling.
5716         * f-valprint.c: Use C++ exception handling.
5717         * exec.c: Use C++ exception handling.
5718         * event-top.c: Use C++ exception handling.
5719         * event-loop.c: Use C++ exception handling.
5720         * eval.c: Use C++ exception handling.
5721         * dwarf2read.c: Use C++ exception handling.
5722         * dwarf2loc.c: Use C++ exception handling.
5723         * dwarf2-frame.c: Use C++ exception handling.
5724         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5725         * dwarf-index-write.c: Use C++ exception handling.
5726         * dwarf-index-cache.c: Use C++ exception handling.
5727         * dtrace-probe.c: Use C++ exception handling.
5728         * disasm-selftests.c: Use C++ exception handling.
5729         * darwin-nat.c: Use C++ exception handling.
5730         * cp-valprint.c: Use C++ exception handling.
5731         * cp-support.c: Use C++ exception handling.
5732         * cp-abi.c: Use C++ exception handling.
5733         * corelow.c: Use C++ exception handling.
5734         * completer.c: Use C++ exception handling.
5735         * compile/compile-object-run.c: Use C++ exception handling.
5736         * compile/compile-object-load.c: Use C++ exception handling.
5737         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5738         * compile/compile-c-symbols.c: Use C++ exception handling.
5739         * common/selftest.c: Use C++ exception handling.
5740         * common/new-op.c: Use C++ exception handling.
5741         * cli/cli-script.c: Use C++ exception handling.
5742         * cli/cli-interp.c: Use C++ exception handling.
5743         * cli/cli-cmds.c: Use C++ exception handling.
5744         * c-varobj.c: Use C++ exception handling.
5745         * btrace.c: Use C++ exception handling.
5746         * breakpoint.c: Use C++ exception handling.
5747         * break-catch-throw.c: Use C++ exception handling.
5748         * arch-utils.c: Use C++ exception handling.
5749         * amd64-tdep.c: Use C++ exception handling.
5750         * ada-valprint.c: Use C++ exception handling.
5751         * ada-typeprint.c: Use C++ exception handling.
5752         * ada-lang.c: Use C++ exception handling.
5753         * aarch64-tdep.c: Use C++ exception handling.
5754
5755 2019-04-08  Tom Tromey  <tom@tromey.com>
5756
5757         * xml-support.c (gdb_xml_parser::parse): Update.
5758         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5759         * value.c (show_convenience): Update.
5760         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5761         (test_parse_flags_qcs): Update.
5762         * thread.c (thr_try_catch_cmd): Update.
5763         * target.c (target_translate_tls_address): Update.
5764         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5765         (info_frame_command_core, frame_apply_command_count): Update.
5766         * rust-exp.y (rust_lex_exception_test): Update.
5767         * riscv-tdep.c (riscv_print_one_register_info): Update.
5768         * remote.c (remote_target::enable_btrace): Update.
5769         * record-btrace.c (record_btrace_enable_warn): Update.
5770         * python/py-utils.c (gdbpy_convert_exception): Update.
5771         * printcmd.c (do_one_display, print_variable_and_value): Update.
5772         * mi/mi-main.c (mi_print_exception): Update.
5773         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5774         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5775         * linux-nat.c (linux_nat_target::attach): Update.
5776         * linux-fork.c (class scoped_switch_fork_info): Update.
5777         * infrun.c (displaced_step_prepare): Update.
5778         * infcall.c (call_function_by_hand_dummy): Update.
5779         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5780         * gnu-v3-abi.c (print_one_vtable): Update.
5781         * frame.c (get_prev_frame_always): Update.
5782         * f-valprint.c (info_common_command_for_block): Update.
5783         * exec.c (try_open_exec_file): Update.
5784         * exceptions.c (print_exception, exception_print)
5785         (exception_fprintf, exception_print_same): Update.
5786         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5787         * dwarf-index-cache.c (index_cache::store)
5788         (index_cache::lookup_gdb_index): Update.
5789         * darwin-nat.c (maybe_cache_shell): Update.
5790         * cp-valprint.c (cp_print_value_fields): Update.
5791         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5792         (gcc_cplus_symbol_address): Update.
5793         * compile/compile-c-symbols.c (gcc_convert_symbol)
5794         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5795         * common/selftest.c: Update.
5796         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5797         a std::string.
5798         (exception_try_scope_entry, exception_try_scope_exit): Don't
5799         declare.
5800         (struct exception_try_scope): Remove.
5801         (TRY): Don't use exception_try_scope.
5802         (struct gdb_exception): Add constructor, operator=.
5803         <what>: New method.
5804         (struct gdb_exception_RETURN_MASK_ALL)
5805         (struct gdb_exception_RETURN_MASK_ERROR)
5806         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5807         (struct gdb_quit_bad_alloc): Update.
5808         * common/common-exceptions.c (exception_none): Change
5809         initializer.
5810         (struct catcher) <state, exception>: Initialize inline.
5811         <prev>: Remove member.
5812         (current_catcher): Remove.
5813         (catchers): New global.
5814         (exceptions_state_mc_init): Simplify.
5815         (catcher_pop): Remove.
5816         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5817         (try_scope_depth, exception_try_scope_entry)
5818         (exception_try_scope_exit): Remove.
5819         (throw_exception_sjlj): Update.
5820         (exception_messages, exception_messages_size): Remove.
5821         (throw_it): Simplify.
5822         (gdb_exception_sliced_copy): Remove.
5823         (throw_exception_cxx): Update.
5824         * cli/cli-script.c (script_from_file): Update.
5825         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5826         Update.
5827         * ada-valprint.c (ada_val_print): Update.
5828         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5829         (create_excep_cond_exprs): Update.
5830
5831 2019-04-08  Tom Tromey  <tom@tromey.com>
5832
5833         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5834         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5835         (TRY, CATCH, END_CATCH): Remove some definitions.
5836         * common/common-exceptions.c: Don't use GDB_XCPT.
5837         (catcher_list_size): Remove.
5838         (throw_exception, throw_it): Simplify.
5839
5840 2019-04-05  Tom Tromey  <tom@tromey.com>
5841
5842         Revert the header-sorting patch.
5843         * ft32-tdep.c: Revert.
5844         * frv-tdep.c: Revert.
5845         * frv-linux-tdep.c: Revert.
5846         * frame.c: Revert.
5847         * frame-unwind.c: Revert.
5848         * frame-base.c: Revert.
5849         * fork-child.c: Revert.
5850         * findvar.c: Revert.
5851         * findcmd.c: Revert.
5852         * filesystem.c: Revert.
5853         * filename-seen-cache.h: Revert.
5854         * filename-seen-cache.c: Revert.
5855         * fbsd-tdep.c: Revert.
5856         * fbsd-nat.h: Revert.
5857         * fbsd-nat.c: Revert.
5858         * f-valprint.c: Revert.
5859         * f-typeprint.c: Revert.
5860         * f-lang.c: Revert.
5861         * extension.h: Revert.
5862         * extension.c: Revert.
5863         * extension-priv.h: Revert.
5864         * expprint.c: Revert.
5865         * exec.h: Revert.
5866         * exec.c: Revert.
5867         * exceptions.c: Revert.
5868         * event-top.c: Revert.
5869         * event-loop.c: Revert.
5870         * eval.c: Revert.
5871         * elfread.c: Revert.
5872         * dwarf2read.h: Revert.
5873         * dwarf2read.c: Revert.
5874         * dwarf2loc.c: Revert.
5875         * dwarf2expr.h: Revert.
5876         * dwarf2expr.c: Revert.
5877         * dwarf2-frame.c: Revert.
5878         * dwarf2-frame-tailcall.c: Revert.
5879         * dwarf-index-write.h: Revert.
5880         * dwarf-index-write.c: Revert.
5881         * dwarf-index-common.c: Revert.
5882         * dwarf-index-cache.h: Revert.
5883         * dwarf-index-cache.c: Revert.
5884         * dummy-frame.c: Revert.
5885         * dtrace-probe.c: Revert.
5886         * disasm.h: Revert.
5887         * disasm.c: Revert.
5888         * disasm-selftests.c: Revert.
5889         * dictionary.c: Revert.
5890         * dicos-tdep.c: Revert.
5891         * demangle.c: Revert.
5892         * dcache.h: Revert.
5893         * dcache.c: Revert.
5894         * darwin-nat.h: Revert.
5895         * darwin-nat.c: Revert.
5896         * darwin-nat-info.c: Revert.
5897         * d-valprint.c: Revert.
5898         * d-namespace.c: Revert.
5899         * d-lang.c: Revert.
5900         * ctf.c: Revert.
5901         * csky-tdep.c: Revert.
5902         * csky-linux-tdep.c: Revert.
5903         * cris-tdep.c: Revert.
5904         * cris-linux-tdep.c: Revert.
5905         * cp-valprint.c: Revert.
5906         * cp-support.c: Revert.
5907         * cp-namespace.c: Revert.
5908         * cp-abi.c: Revert.
5909         * corelow.c: Revert.
5910         * corefile.c: Revert.
5911         * continuations.c: Revert.
5912         * completer.h: Revert.
5913         * completer.c: Revert.
5914         * complaints.c: Revert.
5915         * coffread.c: Revert.
5916         * coff-pe-read.c: Revert.
5917         * cli-out.h: Revert.
5918         * cli-out.c: Revert.
5919         * charset.c: Revert.
5920         * c-varobj.c: Revert.
5921         * c-valprint.c: Revert.
5922         * c-typeprint.c: Revert.
5923         * c-lang.c: Revert.
5924         * buildsym.c: Revert.
5925         * buildsym-legacy.c: Revert.
5926         * build-id.h: Revert.
5927         * build-id.c: Revert.
5928         * btrace.c: Revert.
5929         * bsd-uthread.c: Revert.
5930         * breakpoint.h: Revert.
5931         * breakpoint.c: Revert.
5932         * break-catch-throw.c: Revert.
5933         * break-catch-syscall.c: Revert.
5934         * break-catch-sig.c: Revert.
5935         * blockframe.c: Revert.
5936         * block.c: Revert.
5937         * bfin-tdep.c: Revert.
5938         * bfin-linux-tdep.c: Revert.
5939         * bfd-target.c: Revert.
5940         * bcache.c: Revert.
5941         * ax-general.c: Revert.
5942         * ax-gdb.h: Revert.
5943         * ax-gdb.c: Revert.
5944         * avr-tdep.c: Revert.
5945         * auxv.c: Revert.
5946         * auto-load.c: Revert.
5947         * arm-wince-tdep.c: Revert.
5948         * arm-tdep.c: Revert.
5949         * arm-symbian-tdep.c: Revert.
5950         * arm-pikeos-tdep.c: Revert.
5951         * arm-obsd-tdep.c: Revert.
5952         * arm-nbsd-tdep.c: Revert.
5953         * arm-nbsd-nat.c: Revert.
5954         * arm-linux-tdep.c: Revert.
5955         * arm-linux-nat.c: Revert.
5956         * arm-fbsd-tdep.c: Revert.
5957         * arm-fbsd-nat.c: Revert.
5958         * arm-bsd-tdep.c: Revert.
5959         * arch-utils.c: Revert.
5960         * arc-tdep.c: Revert.
5961         * arc-newlib-tdep.c: Revert.
5962         * annotate.h: Revert.
5963         * annotate.c: Revert.
5964         * amd64-windows-tdep.c: Revert.
5965         * amd64-windows-nat.c: Revert.
5966         * amd64-tdep.c: Revert.
5967         * amd64-sol2-tdep.c: Revert.
5968         * amd64-obsd-tdep.c: Revert.
5969         * amd64-obsd-nat.c: Revert.
5970         * amd64-nbsd-tdep.c: Revert.
5971         * amd64-nbsd-nat.c: Revert.
5972         * amd64-nat.c: Revert.
5973         * amd64-linux-tdep.c: Revert.
5974         * amd64-linux-nat.c: Revert.
5975         * amd64-fbsd-tdep.c: Revert.
5976         * amd64-fbsd-nat.c: Revert.
5977         * amd64-dicos-tdep.c: Revert.
5978         * amd64-darwin-tdep.c: Revert.
5979         * amd64-bsd-nat.c: Revert.
5980         * alpha-tdep.c: Revert.
5981         * alpha-obsd-tdep.c: Revert.
5982         * alpha-nbsd-tdep.c: Revert.
5983         * alpha-mdebug-tdep.c: Revert.
5984         * alpha-linux-tdep.c: Revert.
5985         * alpha-linux-nat.c: Revert.
5986         * alpha-bsd-tdep.c: Revert.
5987         * alpha-bsd-nat.c: Revert.
5988         * aix-thread.c: Revert.
5989         * agent.c: Revert.
5990         * addrmap.c: Revert.
5991         * ada-varobj.c: Revert.
5992         * ada-valprint.c: Revert.
5993         * ada-typeprint.c: Revert.
5994         * ada-tasks.c: Revert.
5995         * ada-lang.c: Revert.
5996         * aarch64-tdep.c: Revert.
5997         * aarch64-ravenscar-thread.c: Revert.
5998         * aarch64-newlib-tdep.c: Revert.
5999         * aarch64-linux-tdep.c: Revert.
6000         * aarch64-linux-nat.c: Revert.
6001         * aarch64-fbsd-tdep.c: Revert.
6002         * aarch64-fbsd-nat.c: Revert.
6003         * aarch32-linux-nat.c: Revert.
6004
6005 2019-04-05  Tom Tromey  <tom@tromey.com>
6006
6007         * ft32-tdep.c: Sort headers.
6008         * frv-tdep.c: Sort headers.
6009         * frv-linux-tdep.c: Sort headers.
6010         * frame.c: Sort headers.
6011         * frame-unwind.c: Sort headers.
6012         * frame-base.c: Sort headers.
6013         * fork-child.c: Sort headers.
6014         * findvar.c: Sort headers.
6015         * findcmd.c: Sort headers.
6016         * filesystem.c: Sort headers.
6017         * filename-seen-cache.h: Sort headers.
6018         * filename-seen-cache.c: Sort headers.
6019         * fbsd-tdep.c: Sort headers.
6020         * fbsd-nat.h: Sort headers.
6021         * fbsd-nat.c: Sort headers.
6022         * f-valprint.c: Sort headers.
6023         * f-typeprint.c: Sort headers.
6024         * f-lang.c: Sort headers.
6025         * extension.h: Sort headers.
6026         * extension.c: Sort headers.
6027         * extension-priv.h: Sort headers.
6028         * expprint.c: Sort headers.
6029         * exec.h: Sort headers.
6030         * exec.c: Sort headers.
6031         * exceptions.c: Sort headers.
6032         * event-top.c: Sort headers.
6033         * event-loop.c: Sort headers.
6034         * eval.c: Sort headers.
6035         * elfread.c: Sort headers.
6036         * dwarf2read.h: Sort headers.
6037         * dwarf2read.c: Sort headers.
6038         * dwarf2loc.c: Sort headers.
6039         * dwarf2expr.h: Sort headers.
6040         * dwarf2expr.c: Sort headers.
6041         * dwarf2-frame.c: Sort headers.
6042         * dwarf2-frame-tailcall.c: Sort headers.
6043         * dwarf-index-write.h: Sort headers.
6044         * dwarf-index-write.c: Sort headers.
6045         * dwarf-index-common.c: Sort headers.
6046         * dwarf-index-cache.h: Sort headers.
6047         * dwarf-index-cache.c: Sort headers.
6048         * dummy-frame.c: Sort headers.
6049         * dtrace-probe.c: Sort headers.
6050         * disasm.h: Sort headers.
6051         * disasm.c: Sort headers.
6052         * disasm-selftests.c: Sort headers.
6053         * dictionary.c: Sort headers.
6054         * dicos-tdep.c: Sort headers.
6055         * demangle.c: Sort headers.
6056         * dcache.h: Sort headers.
6057         * dcache.c: Sort headers.
6058         * darwin-nat.h: Sort headers.
6059         * darwin-nat.c: Sort headers.
6060         * darwin-nat-info.c: Sort headers.
6061         * d-valprint.c: Sort headers.
6062         * d-namespace.c: Sort headers.
6063         * d-lang.c: Sort headers.
6064         * ctf.c: Sort headers.
6065         * csky-tdep.c: Sort headers.
6066         * csky-linux-tdep.c: Sort headers.
6067         * cris-tdep.c: Sort headers.
6068         * cris-linux-tdep.c: Sort headers.
6069         * cp-valprint.c: Sort headers.
6070         * cp-support.c: Sort headers.
6071         * cp-namespace.c: Sort headers.
6072         * cp-abi.c: Sort headers.
6073         * corelow.c: Sort headers.
6074         * corefile.c: Sort headers.
6075         * continuations.c: Sort headers.
6076         * completer.h: Sort headers.
6077         * completer.c: Sort headers.
6078         * complaints.c: Sort headers.
6079         * coffread.c: Sort headers.
6080         * coff-pe-read.c: Sort headers.
6081         * cli-out.h: Sort headers.
6082         * cli-out.c: Sort headers.
6083         * charset.c: Sort headers.
6084         * c-varobj.c: Sort headers.
6085         * c-valprint.c: Sort headers.
6086         * c-typeprint.c: Sort headers.
6087         * c-lang.c: Sort headers.
6088         * buildsym.c: Sort headers.
6089         * buildsym-legacy.c: Sort headers.
6090         * build-id.h: Sort headers.
6091         * build-id.c: Sort headers.
6092         * btrace.c: Sort headers.
6093         * bsd-uthread.c: Sort headers.
6094         * breakpoint.h: Sort headers.
6095         * breakpoint.c: Sort headers.
6096         * break-catch-throw.c: Sort headers.
6097         * break-catch-syscall.c: Sort headers.
6098         * break-catch-sig.c: Sort headers.
6099         * blockframe.c: Sort headers.
6100         * block.c: Sort headers.
6101         * bfin-tdep.c: Sort headers.
6102         * bfin-linux-tdep.c: Sort headers.
6103         * bfd-target.c: Sort headers.
6104         * bcache.c: Sort headers.
6105         * ax-general.c: Sort headers.
6106         * ax-gdb.h: Sort headers.
6107         * ax-gdb.c: Sort headers.
6108         * avr-tdep.c: Sort headers.
6109         * auxv.c: Sort headers.
6110         * auto-load.c: Sort headers.
6111         * arm-wince-tdep.c: Sort headers.
6112         * arm-tdep.c: Sort headers.
6113         * arm-symbian-tdep.c: Sort headers.
6114         * arm-pikeos-tdep.c: Sort headers.
6115         * arm-obsd-tdep.c: Sort headers.
6116         * arm-nbsd-tdep.c: Sort headers.
6117         * arm-nbsd-nat.c: Sort headers.
6118         * arm-linux-tdep.c: Sort headers.
6119         * arm-linux-nat.c: Sort headers.
6120         * arm-fbsd-tdep.c: Sort headers.
6121         * arm-fbsd-nat.c: Sort headers.
6122         * arm-bsd-tdep.c: Sort headers.
6123         * arch-utils.c: Sort headers.
6124         * arc-tdep.c: Sort headers.
6125         * arc-newlib-tdep.c: Sort headers.
6126         * annotate.h: Sort headers.
6127         * annotate.c: Sort headers.
6128         * amd64-windows-tdep.c: Sort headers.
6129         * amd64-windows-nat.c: Sort headers.
6130         * amd64-tdep.c: Sort headers.
6131         * amd64-sol2-tdep.c: Sort headers.
6132         * amd64-obsd-tdep.c: Sort headers.
6133         * amd64-obsd-nat.c: Sort headers.
6134         * amd64-nbsd-tdep.c: Sort headers.
6135         * amd64-nbsd-nat.c: Sort headers.
6136         * amd64-nat.c: Sort headers.
6137         * amd64-linux-tdep.c: Sort headers.
6138         * amd64-linux-nat.c: Sort headers.
6139         * amd64-fbsd-tdep.c: Sort headers.
6140         * amd64-fbsd-nat.c: Sort headers.
6141         * amd64-dicos-tdep.c: Sort headers.
6142         * amd64-darwin-tdep.c: Sort headers.
6143         * amd64-bsd-nat.c: Sort headers.
6144         * alpha-tdep.c: Sort headers.
6145         * alpha-obsd-tdep.c: Sort headers.
6146         * alpha-nbsd-tdep.c: Sort headers.
6147         * alpha-mdebug-tdep.c: Sort headers.
6148         * alpha-linux-tdep.c: Sort headers.
6149         * alpha-linux-nat.c: Sort headers.
6150         * alpha-bsd-tdep.c: Sort headers.
6151         * alpha-bsd-nat.c: Sort headers.
6152         * aix-thread.c: Sort headers.
6153         * agent.c: Sort headers.
6154         * addrmap.c: Sort headers.
6155         * ada-varobj.c: Sort headers.
6156         * ada-valprint.c: Sort headers.
6157         * ada-typeprint.c: Sort headers.
6158         * ada-tasks.c: Sort headers.
6159         * ada-lang.c: Sort headers.
6160         * aarch64-tdep.c: Sort headers.
6161         * aarch64-ravenscar-thread.c: Sort headers.
6162         * aarch64-newlib-tdep.c: Sort headers.
6163         * aarch64-linux-tdep.c: Sort headers.
6164         * aarch64-linux-nat.c: Sort headers.
6165         * aarch64-fbsd-tdep.c: Sort headers.
6166         * aarch64-fbsd-nat.c: Sort headers.
6167         * aarch32-linux-nat.c: Sort headers.
6168
6169 2019-04-04  Tom Tromey  <tom@tromey.com>
6170
6171         * varobj.c (varobj_create): Update.
6172         * rust-exp.y (struct rust_parser) <update_innermost_block,
6173         lookup_symbol>: New methods.
6174         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6175         Rename.
6176         (rust_parser::rust_lookup_type)
6177         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6178         * printcmd.c (display_command, do_one_display): Update.
6179         * parser-defs.h (struct parser_state) <parser_state>: Add
6180         "tracker" parameter.
6181         (block_tracker): New member.
6182         (class innermost_block_tracker) <innermost_block_tracker>: Add
6183         "types" parameter.
6184         <reset>: Remove method.
6185         (innermost_block): Don't declare.
6186         (null_post_parser): Update.
6187         * parse.c (innermost_block): Remove global.
6188         (write_dollar_variable): Update.
6189         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6190         Remove "tracker_types" parameter.
6191         (parse_expression): Add "tracker" parameter.
6192         (parse_expression_for_completion): Update.
6193         (null_post_parser): Add "tracker" parameter.
6194         * p-exp.y: Update rules.
6195         * m2-exp.y: Update rules.
6196         * language.h (struct language_defn) <la_post_parser>: Add
6197         "tracker" parameter.
6198         * go-exp.y: Update rules.
6199         * f-exp.y: Update rules.
6200         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6201         parameter.
6202         * d-exp.y: Update rules.
6203         * c-exp.y: Update rules.
6204         * breakpoint.c (set_breakpoint_condition): Create an
6205         innermost_block_tracker.
6206         (watch_command_1): Likewise.
6207         * ada-lang.c (resolve): Add "tracker" parameter.
6208         (resolve_subexp): Likewise.
6209         * ada-exp.y (write_var_from_sym): Update.
6210
6211 2019-04-04  Tom Tromey  <tom@tromey.com>
6212
6213         * type-stack.h: New file.
6214         * type-stack.c: New file.
6215         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6216         type-stack.h.
6217         (insert_into_type_stack, insert_type, push_type, push_type_int)
6218         (insert_type_address_space, pop_type, pop_type_int)
6219         (pop_typelist, pop_type_stack, append_type_stack)
6220         (push_type_stack, get_type_stack, push_typelist)
6221         (follow_type_instance_flags, follow_types): Don't declare.
6222         * parse.c (type_stack): Remove global.
6223         (parse_exp_in_context): Update.
6224         (insert_into_type_stack, insert_type, push_type, push_type_int)
6225         (insert_type_address_space, pop_type, pop_type_int)
6226         (pop_typelist, pop_type_stack, append_type_stack)
6227         (push_type_stack, get_type_stack, push_typelist)
6228         (follow_type_instance_flags, follow_types): Remove (moved to
6229         type-stack.c).
6230         * f-exp.y (type_stack): New global.
6231         Update rules.
6232         (push_kind_type, f_parse): Update.
6233         * d-exp.y (type_stack): New global.
6234         Update rules.
6235         (d_parse): Update.
6236         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6237         Update rules.
6238         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6239         (HFILES_NO_SRCDIR): Add type-stack.h.
6240
6241 2019-04-04  Tom Tromey  <tom@tromey.com>
6242
6243         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6244         (rust_parser::convert_ast_to_expression, rust_parse)
6245         (rust_lex_test_completion, rust_lex_tests): Update.
6246         * parser-defs.h (struct expr_completion_state): New.
6247         (struct parser_state) <parser_state>: Add completion parameter.
6248         <mark_struct_expression, mark_completion_tag>: New methods.
6249         <parse_completion, m_completion_state>: New members.
6250         (prefixify_expression, null_post_parser): Update.
6251         (mark_struct_expression, mark_completion_tag): Don't declare.
6252         * parse.c (parse_completion, expout_last_struct)
6253         (expout_tag_completion_type, expout_completion_name): Remove
6254         globals.
6255         (parser_state::mark_struct_expression)
6256         (parser_state::mark_completion_tag): Now methods.
6257         (prefixify_expression): Add last_struct parameter.
6258         (prefixify_subexp): Likewise.
6259         (parse_exp_1): Update.
6260         (parse_exp_in_context): Add cstate parameter.  Update.
6261         (parse_expression_for_completion): Create an
6262         expr_completion_state.
6263         (null_post_parser): Add "completion" parameter.
6264         * p-exp.y: Update rules.
6265         (yylex): Update.
6266         * language.h (struct language_defn) <la_post_parser>: Add
6267         "completing" parameter.
6268         * go-exp.y: Update rules.
6269         (lex_one_token): Update.
6270         * expression.h (parse_completion): Don't declare.
6271         * d-exp.y: Update rules.
6272         (lex_one_token): Update rules.
6273         * c-exp.y: Update rules.
6274         (lex_one_token): Update.
6275         * ada-lang.c (resolve): Add "parse_completion" parameter.
6276         (resolve_subexp): Likewise.
6277         (ada_resolve_function): Likewise.
6278
6279 2019-04-04  Tom Tromey  <tom@tromey.com>
6280
6281         * parser-defs.h (struct parser_state) <start_arglist,
6282         end_arglist>: New methods.
6283         <arglist_len, m_funcall_chain>: New members.
6284         (arglist_len, start_arglist, end_arglist): Don't declare.
6285         * parse.c (arglist_len, funcall_chain): Remove global.
6286         (start_arglist, end_arglist): Remove functions.
6287         (parse_exp_in_context): Update.
6288         * p-exp.y: Update rules.
6289         * m2-exp.y: Update rules.
6290         * go-exp.y: Update rules.
6291         * f-exp.y: Update rules.
6292         * d-exp.y: Update rules.
6293         * c-exp.y: Update rules.
6294
6295 2019-04-04  Tom Tromey  <tom@tromey.com>
6296
6297         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6298         lex_operator, push_back>: New methods.
6299         Update all rules.
6300         (rust_parser::lex_hex, lex_escape): Rename and update.
6301         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6302         (rust_parser::lex_operator): Rename and update.
6303         (rust_parser::lex_number, rustyylex, rustyyerror)
6304         (rust_lex_test_init, rust_lex_test_sequence)
6305         (rust_lex_test_push_back, rust_lex_tests): Update.
6306         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6307         parameter.
6308         <lexptr, prev_lexptr>: New members.
6309         (lexptr, prev_lexptr): Don't declare.
6310         * parse.c (lexptr, prev_lexptr): Remove globals.
6311         (parse_exp_in_context): Update.
6312         * p-exp.y (yylex, yyerror): Update.
6313         * m2-exp.y (parse_number, yylex, yyerror): Update.
6314         * go-exp.y (lex_one_token, yyerror): Update.
6315         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6316         * d-exp.y (lex_one_token, yyerror): Update.
6317         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6318         (lex_one_token, yyerror): Update.
6319         * ada-lex.l (YY_INPUT): Update.
6320         (rewind_to_char): Update.
6321         * ada-exp.y (yyerror): Update.
6322
6323 2019-04-04  Tom Tromey  <tom@tromey.com>
6324
6325         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6326         * parser-defs.h (struct parser_state) <parser_state>: Add new
6327         parameter.
6328         <comma_terminates>: New member.
6329         (comma_terminates): Don't declare global.
6330         * parse.c (comma_terminates): Remove global.
6331         (parse_exp_in_context): Update.
6332         * p-exp.y (yylex): Update.
6333         * m2-exp.y (yylex): Update.
6334         * go-exp.y (lex_one_token): Update.
6335         * f-exp.y (yylex): Update.
6336         * d-exp.y (lex_one_token): Update.
6337         * c-exp.y (lex_one_token): Update.
6338         * ada-lex.l: Update.
6339
6340 2019-04-04  Tom Tromey  <tom@tromey.com>
6341
6342         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6343         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6344         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6345         * parser-defs.h (paren_depth): Don't declare.
6346         * parse.c (paren_depth): Remove global.
6347         (parse_exp_in_context): Update.
6348         * p-exp.y (paren_depth): New global.
6349         (pascal_parse): Initialize it.
6350         * m2-exp.y (paren_depth): New global.
6351         (m2_parse): Initialize it.
6352         * go-exp.y (paren_depth): New global.
6353         (go_parse): Initialize it.
6354         * f-exp.y (paren_depth): New global.
6355         (f_parse): Initialize it.
6356         * d-exp.y (paren_depth): New global.
6357         (d_parse): Initialize it.
6358         * c-exp.y (paren_depth): New global.
6359         (c_parse): Initialize it.
6360         * ada-lex.l (paren_depth): New global.
6361         (lexer_init): Initialize it.
6362
6363 2019-04-04  Tom Tromey  <tom@tromey.com>
6364
6365         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6366         (rust_parser::convert_ast_to_type)
6367         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6368         * parser-defs.h (struct parser_state) <parser_state>: Add
6369         parameters.  Initialize new members.
6370         <expression_context_block, expression_context_pc>: New members.
6371         * parse.c (expression_context_block, expression_context_pc):
6372         Remove globals.
6373         (parse_exp_in_context): Update.
6374         * p-exp.y: Update all rules.
6375         (yylex): Update.
6376         * m2-exp.y: Update all rules.
6377         (yylex): Update.
6378         * go-exp.y (yylex): Update.
6379         * f-exp.y (yylex): Update.
6380         * d-exp.y: Update all rules.
6381         (yylex): Update.
6382         * c-exp.y: Update all rules.
6383         (lex_one_token, classify_name, yylex, c_parse): Update.
6384         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6385
6386 2019-04-04  Tom Tromey  <tom@tromey.com>
6387
6388         * gdbarch.h, gdbarch.c: Rebuild.
6389         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6390         * stap-probe.h:
6391         (struct stap_parse_info): Replace "parser_state" with
6392         "expr_builder".
6393         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6394         (parser_state): New class.
6395         * parse.c (expr_builder): Rename.
6396         (expr_builder::release): Rename.
6397         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6398         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6399         (write_exp_elt_longcst, write_exp_elt_floatcst)
6400         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6401         (write_exp_string_vector, write_exp_bitstring)
6402         (write_exp_msymbol, mark_struct_expression)
6403         (write_dollar_variable)
6404         (insert_type_address_space, increase_expout_size): Replace
6405         "parser_state" with "expr_builder".
6406         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6407         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6408         "parser_state" with "expr_builder".
6409
6410 2019-04-04  Tom Tromey  <tom@tromey.com>
6411
6412         * rust-exp.y: Replace "parse_language" with method call.
6413         * p-exp.y:
6414         (yylex): Replace "parse_language" with method call.
6415         * m2-exp.y:
6416         (yylex): Replace "parse_language" with method call.
6417         * go-exp.y (classify_name): Replace "parse_language" with method
6418         call.
6419         * f-exp.y (yylex): Replace "parse_language" with method call.
6420         * d-exp.y (lex_one_token): Replace "parse_language" with method
6421         call.
6422         * c-exp.y:
6423         (lex_one_token, classify_name, yylex): Replace "parse_language"
6424         with method call.
6425         * ada-exp.y (find_primitive_type, type_char)
6426         (type_system_address): Replace "parse_language" with method call.
6427
6428 2019-04-04  Tom Tromey  <tom@tromey.com>
6429
6430         * rust-exp.y: Replace "parse_gdbarch" with method call.
6431         * parse.c (write_dollar_variable, insert_type_address_space):
6432         Replace "parse_gdbarch" with method call.
6433         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6434         call.
6435         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6436         call.
6437         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6438         "parse_gdbarch" with method call.
6439         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6440         with method call.
6441         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6442         "parse_gdbarch" with method call.
6443         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6444         "parse_gdbarch" with method call.
6445         * c-exp.y (parse_type, parse_number, classify_name): Replace
6446         "parse_gdbarch" with method call.
6447         * ada-lex.l: Replace "parse_gdbarch" with method call.
6448         * ada-exp.y (parse_type, find_primitive_type, type_char)
6449         (type_system_address): Replace "parse_gdbarch" with method call.
6450
6451 2019-04-04  Tom Tromey  <tom@tromey.com>
6452
6453         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6454         * stap-probe.c (stap_parse_argument): Update.
6455         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6456         initial_size parameter.
6457         * rust-exp.y (rust_lex_tests): Update.
6458         * parse.c (parser_state): Update.
6459         (parse_exp_in_context): Update.
6460         * parser-defs.h (struct parser_state) <parser_state>: Remove
6461         "initial_size" parameter.
6462
6463 2019-04-04  Tom Tromey  <tom@tromey.com>
6464
6465         * parser-defs.h (increase_expout_size): Don't declare.
6466         * parse.c (increase_expout_size): Now static.
6467
6468 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6469
6470         * gnu-nat.c (gnu_nat_target::wait): Fix
6471         target_waitstatus_to_string call.
6472
6473 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * eval.c (evaluate_subexp_standard): Handle internal functions
6476         during Fortran function call handling.
6477
6478 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6479
6480         * NEWS: Mention new internal functions.
6481         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6482         (read_base_type): Use dwarf2_init_complex_target_type.
6483         * value.c (creal_internal_fn): New function.
6484         (cimag_internal_fn): New function.
6485         (_initialize_values): Register new internal functions.
6486
6487 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6488
6489         * infrun.c (stop_all_threads): If debug_infrun, always
6490         trace the wait status after wait_one, using
6491         target_waitstatus_to_string and target_pid_to_str.
6492         (handle_inferior_event): Replace various trace of
6493         wait status kind by a single trace.
6494         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6495         wait status kind image by target_waitstatus_to_string.
6496         * target/waitstatus.c (target_waitstatus_to_string): Fix
6497         obsolete comment.
6498
6499 2019-04-01  Tom Tromey  <tromey@adacore.com>
6500
6501         PR symtab/23331:
6502         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6503
6504 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6505             Pedro Alves  <palves@redhat.com>
6506
6507         * top.c (quit_force): Call 'finalize_values'.
6508         * value.c (finalize_values): New function.
6509         * value.h (finalize_values): Declare.
6510
6511 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6512
6513         * NEWS: Announce $_gdb_major and $_gdb_minor.
6514
6515         * top.c (init_gdb_version_vars): New function.
6516         (gdb_init): Call init_gdb_version_vars.
6517
6518 2019-03-29  Tom Tromey  <tromey@adacore.com>
6519
6520         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6521         help text.  Remove dead code.
6522
6523 2019-03-29  Keith Seitz  <keiths@redhat.com>
6524
6525         From Siddhesh Poyarekar:
6526         * f-lang.h (f77_get_upperbound): Return LONGEST.
6527         (f77_get_lowerbound): Likewise.
6528         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6529         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6530         print them.
6531         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6532         plongest to format print it.
6533         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6534         (f77_get_upperbound): Likewise.
6535         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6536         LOWER_BOUND to LONGEST.
6537         (f77_create_arrayprint_offset_tbl): Likewise.
6538
6539 2019-03-29  Keith Seitz  <keiths@redhat.com>
6540
6541         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6542         %s/pulongest for TYPE_LENGTH instead of %d in format
6543         strings.
6544         * ada-typerint.c (ada_print_type): Likewise.
6545         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6546         * compile/compile-c-support.c (generate_register_struct): Likewise.
6547         * gdbtypes.c (recursive_dump_type): Likewise.
6548         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6549         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6550         instead of %d in format strings.
6551         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6552         to std::min to ULONGEST.
6553         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6554         instead of %d in format strings.
6555         * tracepoint.c (info_scope_command): Likewise.
6556         * typeprint.c (print_offset_data::update)
6557         (print_offset_data::finish): Likewise.
6558         * xtensa-tdep.c (xtensa_store_return_value)
6559         (xtensa_push_dummy_call): Likewise.
6560
6561 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6562
6563         * windows-nat.c (display_selector): Fixed format specifications
6564         for 64-bit Cygwin.
6565
6566 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6567
6568         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6569
6570 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6571
6572         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6573         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6574         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6575         (nios2_linux_init_abi): Install it.
6576
6577 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6578
6579         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6580
6581 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6582
6583         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6584
6585 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6586             Tom Tromey  <tromey@adacore.com>
6587
6588         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6589
6590 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6591
6592         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6593         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6594         method to compute the bounds of range types. Also print "[evaluated]"
6595         if the bounds' values come from a dynamic evaluation.
6596
6597 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6600         whitespace when pretty printing is on.
6601
6602 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6603
6604         * ppc-linux-nat.c: Add include.
6605
6606 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6607
6608         * NEWS: Mention AArch64 Pointer Authentication.
6609
6610 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6611
6612         * arm-linux-nat.c: Add include.
6613
6614 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6615
6616         * source-cache.c (source_cache::get_source_lines): Re-read
6617         fullname after calling open_source_file.
6618
6619 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6620
6621         * NEWS: Mention TLS support for FreeBSD.
6622
6623 2019-03-25  Tom Tromey  <tromey@adacore.com>
6624
6625         * minsyms.c (BUNCH_SIZE): Update comment.
6626         (~minimal_symbol_reader): Remove old comment.
6627         (compact_minimal_symbols): Update comment.
6628         (minimal_symbol_reader::install): Remove old comment.  Update
6629         other comments.
6630
6631 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6632
6633         * s390-linux-nat.c: Add include.
6634
6635 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6636
6637         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6638         Call linux_get_hwcap.
6639         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6640         Likewise.
6641         (aarch64_linux_get_hwcap): Remove function.
6642         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6643         declaration.
6644         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6645         linux_get_hwcap.
6646         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6647         * linux-tdep.c (linux_get_hwcap): Add function.
6648         (linux_get_hwcap2): Likewise.
6649         * linux-tdep.h (linux_get_hwcap): Add declaration.
6650         (linux_get_hwcap2): Likewise.
6651         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6652         (ppc_linux_get_hwcap2): Likewise.
6653         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6654         linux_get_hwcap.
6655         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6656         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6657         (ppc_linux_nat_target::read_description): Likewise.
6658         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6659         * s390-linux-nat.c: Likewise.
6660         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6661
6662 2019-03-24  Tom Tromey  <tom@tromey.com>
6663
6664         * ada-lang.c (standard_lookup): Simplify initialization.
6665         (ada_lookup_symbol_nonlocal): Simplify return.
6666         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6667         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6668         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6669         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6670         initialization.
6671         * solib.c (solib_global_lookup): Simplify.
6672         * symtab.c (null_block_symbol): Remove.
6673         (symbol_cache_lookup): Simplify returns.
6674         (lookup_language_this): Simplify returns.
6675         (lookup_symbol_aux): Simplify return.
6676         (lookup_local_symbol): Simplify returns.
6677         (lookup_global_symbol_from_objfile): Simplify return.
6678         (lookup_symbol_in_objfile_symtabs)
6679         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6680         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6681         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6682         * cp-namespace.c (cp_lookup_bare_symbol)
6683         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6684         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6685         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6686         (cp_lookup_symbol_via_imports): Simplify initialization.
6687         (find_symbol_in_baseclass): Likewise.
6688         * symtab.h (null_block_symbol): Remove.
6689         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6690         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6691         (d_lookup_symbol_module): Likewise.
6692         (find_symbol_in_baseclass): Simplify initialization.
6693
6694 2019-03-24  Tom Tromey  <tom@tromey.com>
6695
6696         * expression.h: Don't include symtab.h.
6697         (struct block): Forward declare.
6698
6699 2019-03-24  Tom Tromey  <tom@tromey.com>
6700
6701         * c-exp.y (typebase): Remove casts.
6702         * gdbtypes.c (lookup_unsigned_typename, )
6703         (lookup_signed_typename): Remove cast.
6704         * eval.c (parse_to_comma_and_eval): Remove cast.
6705         * parse.c (write_dollar_variable): Remove cast.
6706         * block.h (struct block) <superblock>: Now const.
6707         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6708         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6709         (map_block): Make "block" const.
6710         * symfile.h (struct quick_symbol_functions)
6711         <map_matching_symbols>: Constify block argument to "callback".
6712         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6713         const.
6714         (find_pc_sect_compunit_symtab): Make "b" const.
6715         (find_symbol_at_address): Likewise.
6716         (search_symbols): Likewise.
6717         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6718         (dw2_debug_names_lookup_symbol): Likewise.
6719         (dw2_map_matching_symbols): Update.
6720         * p-valprint.c (pascal_val_print): Remove "block".
6721         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6722         (aux_add_nonlocal_symbols): Make "block" const.
6723         (resolve_subexp): Remove cast.
6724         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6725         const.
6726         (iterate_over_file_blocks): Likewise.
6727         * f-exp.y (%union) <bval>: Remove.
6728         * coffread.c (patch_opaque_types): Make "b" const.
6729         * spu-tdep.c (spu_catch_start): Make "block" const.
6730         * c-valprint.c (print_unpacked_pointer): Remove "block".
6731         * symmisc.c (dump_symtab_1): Make "b" const.
6732         (block_depth): Make "block" const.
6733         * d-exp.y (%union) <bval>: Remove.
6734         * cp-support.h (cp_lookup_rtti_type): Update.
6735         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6736         * psymtab.c (psym_lookup_symbol): Make "block" const.
6737         (maintenance_check_psymtabs): Make "b" const.
6738         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6739         (enumerate_locals, enumerate_args): Update.
6740         * python/py-symtab.c (stpy_global_block): Make "block" const.
6741         (stpy_static_block): Likewise.
6742         * inline-frame.c (block_starting_point_at): Make "new_block"
6743         const.
6744         * block.c (find_block_in_blockvector): Make return type const.
6745         (blockvector_for_pc_sect): Make "b" const.
6746         (find_block_in_blockvector): Make "b" const.
6747
6748 2019-03-23  Tom Tromey  <tom@tromey.com>
6749
6750         * varobj.c (varobj_create): Update.
6751         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6752         * printcmd.c (display_command, do_one_display): Don't reset
6753         innermost_block.
6754         * parser-defs.h (enum innermost_block_tracker_type): Move to
6755         expression.h.
6756         (innermost_block): Update comment.
6757         * parse.c (parse_exp_1): Add tracker_types parameter.
6758         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6759         tracker_types parameter.  Reset innermost_block.
6760         (parse_exp_in_context): Remove.
6761         (parse_expression_for_completion): Update.
6762         * objfiles.c (~objfile): Don't reset expression_context_block or
6763         innermost_block.
6764         * expression.h (enum innermost_block_tracker_type): Move from
6765         parser-defs.h.
6766         (parse_exp_1): Add tracker_types parameter.
6767         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6768         reset innermost_block.
6769
6770 2019-03-23  Tom Tromey  <tom@tromey.com>
6771
6772         * objfiles.h: Include bcache.h.
6773
6774 2019-03-23  Tom Tromey  <tom@tromey.com>
6775
6776         * linespec.c (get_current_search_block): Use
6777         scoped_restore_current_language.
6778         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6779
6780 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6781             Jiong Wang  <jiong.wang@arm.com>
6782
6783         * aarch64-linux-tdep.c
6784         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6785         section.
6786         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6787
6788 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6789             Jiong Wang  <jiong.wang@arm.com>
6790
6791         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6792         instructions.
6793         (aarch64_analyze_prologue_test): Add PACIASP test.
6794         (aarch64_prologue_prev_register): Unmask PC value.
6795
6796 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6797             Jiong Wang  <jiong.wang@arm.com>
6798
6799         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6800         (aarch64_dwarf2_prev_register): Unmask PC value.
6801         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6802         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6803         DW_CFA_AARCH64_negate_ra_state.
6804         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6805
6806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6807             Jiong Wang  <jiong.wang@arm.com>
6808
6809         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6810         registers.
6811         (aarch64_pseudo_register_name): Likewise.
6812         (aarch64_pseudo_register_type): Likewise.
6813         (aarch64_pseudo_register_reggroup_p): Likewise.
6814         (aarch64_gdbarch_init): Add pauth registers.
6815         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6816         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6817         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6818         (struct gdbarch_tdep): Add regnum for ra_state.
6819
6820 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6821             Jiong Wang  <jiong.wang@arm.com>
6822
6823         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6824
6825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6826             Jiong Wang  <jiong.wang@arm.com>
6827
6828         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6829         function.
6830         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6831         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6832         (aarch64_gdbarch_init): Add puth registers.
6833         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6834         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6835         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6836
6837 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6838             Jiong Wang  <jiong.wang@arm.com>
6839
6840         * aarch64-linux-nat.c
6841         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6842         * aarch64-linux-tdep.c
6843         (aarch64_linux_core_read_description): Likewise.
6844         (aarch64_linux_get_hwcap): New function.
6845         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6846         (aarch64_linux_get_hwcap): New declaration.
6847
6848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6849             Jiong Wang  <jiong.wang@arm.com>
6850
6851         * aarch64-linux-nat.c
6852         (aarch64_linux_nat_target::read_description): Add pauth param.
6853         * aarch64-linux-tdep.c
6854         (aarch64_linux_core_read_description): Likewise.
6855         * aarch64-tdep.c (struct target_desc): Add in pauth.
6856         (aarch64_read_description): Add pauth param.
6857         (aarch64_gdbarch_init): Likewise.
6858         * aarch64-tdep.h (aarch64_read_description): Likewise.
6859         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6860         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6861         * features/Makefile: Add new files.
6862         * features/aarch64-pauth.c: New file.
6863         * features/aarch64-pauth.xml: New file.
6864
6865 2019-03-20  Tom Tromey  <tromey@adacore.com>
6866
6867         * infrun.c (handle_inferior_event): Rename from
6868         handle_inferior_event_1.  Create a scoped_value_mark.
6869         (handle_inferior_event): Remove.
6870
6871 2019-03-19  Tom Tromey  <tromey@adacore.com>
6872
6873         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6874         * infrun.h (print_stop_event): Add "displays" parameter.
6875         * infrun.c (print_stop_event): Add "displays" parameter.
6876
6877 2019-03-19  Pedro Alves  <palves@redhat.com>
6878
6879         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6880         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6881         to -1.  Fix TABs vs spaces.
6882         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6883         * tui/tui-out.h (tui_ui_out) Add intro comments.
6884         <m_line, m_start_of_line>: In-class initialize, and add describing
6885         comment.
6886
6887 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6888
6889         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6890         variable names.
6891         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6892
6893 2019-03-18  Pedro Alves  <palves@redhat.com>
6894             Eli Zaretskii <eliz@gnu.org>
6895
6896         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6897         m_line and m_start_of_line.
6898
6899 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6900
6901         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6902         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6903         it returns a newline.  This fixes a regression in TU mode, whereby
6904         the next line is output on the same screen line as the user input.
6905
6906 2019-03-18  Tom Tromey  <tromey@adacore.com>
6907
6908         * minsyms.c (minimal_symbol_reader::install): Remove call to
6909         obstack_blank.
6910
6911 2019-03-18  Pedro Alves  <palves@redhat.com>
6912
6913         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6914         New globals.
6915         (apply_style): New, factored out from ...
6916         (apply_ansi_escape): ... this.  Handle reverse video mode.
6917         (tui_set_reverse_mode): New function.
6918         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6919         * tui/tui-winsource.c (tui_show_source_line): Use
6920         tui_set_reverse_mode instead of setting A_STANDOUT.
6921         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6922         New setter methods.
6923
6924 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6925
6926         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6927         Handle tabs.
6928
6929 2019-03-18  Tom Tromey  <tromey@adacore.com>
6930
6931         * ada-lang.c (empty_array): Add "high" parameter.
6932         (ada_evaluate_subexp): Update.
6933
6934 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6935
6936         * unittests/string_view-selftests.c: Define
6937         _initialize_string_view_selftests unconditionally.
6938
6939 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6940
6941         PR gdb/24350
6942         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6943
6944 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6945
6946         PR gdb/24351
6947         * windows-nat.c (display_selector): Fix format specifiers.
6948
6949 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6950
6951         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6952         tui_refill_source_window instead of tui_refresh_win, to update the
6953         current execution line.  This fixes redisplay of the current line
6954         when stepping through the code with "next" or "step".
6955
6956 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6957
6958         * source-cache.c (source_cache::get_source_lines): Call
6959         find_source_lines to initialize s->nlines.  This fixes vertical
6960         scrolling of TUI source window when the DOWN arrow is pressed.
6961
6962 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6963
6964         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6965         linux-thread-db.c (_initialize_thread_db): Likewise.
6966
6967 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6968
6969         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6970         wclrtoeol in tui_show_source_line".  This reverts changes made in
6971         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6972
6973 2019-03-15  Tom Tromey  <tom@tromey.com>
6974
6975         * symtab.h (struct minimal_symbol): Derive from
6976         general_symbol_info.
6977         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6978         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6979         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6980         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6981         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6982         (MSYMBOL_SEARCH_NAME): Update.
6983         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6984         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6985         * minsyms.c (minimal_symbol_reader::record_full): Update.
6986
6987 2019-03-15  Tom Tromey  <tom@tromey.com>
6988
6989         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6990
6991 2019-03-15  Tom Tromey  <tom@tromey.com>
6992
6993         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6994         unique_xmalloc_ptr.
6995         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6996         Update.
6997         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6998         (build_minimal_symbol_hash_tables)
6999         (minimal_symbol_reader::install): Update.
7000
7001 2019-03-15  Tom Tromey  <tom@tromey.com>
7002
7003         * symtab.c (create_demangled_names_hash): Update.
7004         (symbol_set_names): Update.
7005         * objfiles.h (struct objfile_per_bfd_storage)
7006         <demangled_names_hash>: Now an htab_up.
7007         * objfiles.c (objfile_per_bfd_storage): Simplify.
7008
7009 2019-03-15  Tom Tromey  <tom@tromey.com>
7010
7011         * objfiles.h (struct objfile_per_bfd_storage): Declare
7012         destructor.
7013         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7014         New.
7015         (get_objfile_bfd_data): Use new.  Don't initialize
7016         language_of_main.
7017         (free_objfile_per_bfd_storage): Remove.
7018         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7019
7020 2019-03-15  Tom Tromey  <tom@tromey.com>
7021
7022         * symfile.c (reread_symbols): Update.
7023         * objfiles.c (objfile::objfile): Update.
7024         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7025         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7026         comment.
7027         (minimal_symbol_reader::install): Update.
7028         (terminate_minimal_symbol_table): Remove.
7029         * jit.c (jit_object_close_impl): Update.
7030
7031 2019-03-15  Tom Tromey  <tom@tromey.com>
7032
7033         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7034         initializations.
7035
7036 2019-03-15  Tom Tromey  <tom@tromey.com>
7037
7038         * objfiles.h (struct objfile_per_bfd_storage)
7039         <demangled_hash_languages>: Now a bitset.
7040         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7041         (lookup_minimal_symbol): Update.
7042
7043 2019-03-15  Tom Tromey  <tom@tromey.com>
7044
7045         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7046         Don't return the symbol.
7047         * coffread.c (record_minimal_symbol): Use record_full.
7048
7049 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7050
7051         The MS-Windows port of ncurses fails to switch to a color pair if
7052         one or both of the colors are the implicit default colors.  This
7053         change records the default colors when TUI is initialized, and
7054         then specifies them explicitly when a color pair uses the default
7055         colors.  This allows color styling in TUI mode on MS-Windows.
7056
7057         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7058         ncurses_norm_attr.
7059         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7060         colors in ncurses_norm_attr.
7061         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7062         "none", replace it with the default color recorded in
7063         ncurses_norm_attr.
7064
7065 2019-03-14  Tom Tromey  <tromey@adacore.com>
7066
7067         * source-cache.h (class source_cache) <get_source_lines>: Return
7068         std::string.
7069         * source-cache.c (source_cache::extract_lines): Handle case where
7070         first_pos==npos.  Return std::string.
7071         (source_cache::get_source_lines): Update.
7072
7073 2019-03-14  Tom Tromey  <tromey@adacore.com>
7074
7075         * NEWS: Add item for "style sources" commands.
7076         * source-cache.c (source_cache::get_source_lines): Check
7077         source_styling.
7078         * cli/cli-style.c (source_styling): New global.
7079         (_initialize_cli_style): Add "style sources" commands.
7080         (show_style_sources): New function.
7081         * cli/cli-style.h (source_styling): Declare.
7082
7083 2019-03-14  Pedro Alves  <palves@redhat.com>
7084             Tom Tromey  <tromey@adacore.com>
7085
7086         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7087         * tui/tui-winsource.c (tui_refill_source_window): New function,
7088         from...
7089         (tui_horizontal_source_scroll): ... here.  Move some logic.
7090         * cli/cli-style.c (set_style_enabled): Notify new observable.
7091         * tui/tui-hooks.c (tui_redisplay_source): New function.
7092         (tui_attach_detach_observers): Attach or detach
7093         tui_redisplay_source.
7094         * observable.h (source_styling_changed): New observable.
7095         * observable.c: Define source_styling_changed observable.
7096
7097 2019-03-13  Tom Tromey  <tromey@adacore.com>
7098
7099         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7100         (i386_gnu_nat_target::store_registers): Update.
7101         * target-debug.h (target_debug_print_std_string): New macro.
7102         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7103         * windows-tdep.c (display_one_tib): Update.
7104         * tui/tui-stack.c (tui_make_status_line): Update.
7105         * top.c (print_inferior_quit_action): Update.
7106         * thread.c (thr_try_catch_cmd): Update.
7107         (add_thread_with_info): Update.
7108         (thread_target_id_str): Update.
7109         (thr_try_catch_cmd): Update.
7110         (thread_command): Update.
7111         (thread_find_command): Update.
7112         * record-btrace.c (record_btrace_target::info_record)
7113         (record_btrace_resume_thread, record_btrace_target::resume)
7114         (record_btrace_cancel_resume, record_btrace_step_thread)
7115         (record_btrace_target::wait, record_btrace_target::wait)
7116         (record_btrace_target::wait, record_btrace_target::stop): Update.
7117         * progspace.c (print_program_space): Update.
7118         * process-stratum-target.c
7119         (process_stratum_target::thread_address_space): Update.
7120         * linux-fork.c (linux_fork_mourn_inferior)
7121         (detach_checkpoint_command, info_checkpoints_command)
7122         (linux_fork_context): Update.
7123         (linux_fork_detach): Update.
7124         (class scoped_switch_fork_info): Update.
7125         (delete_checkpoint_command): Update.
7126         * infrun.c (follow_fork_inferior): Update.
7127         (follow_fork_inferior): Update.
7128         (proceed_after_vfork_done): Update.
7129         (handle_vfork_child_exec_or_exit): Update.
7130         (follow_exec): Update.
7131         (displaced_step_prepare_throw): Update.
7132         (displaced_step_restore): Update.
7133         (start_step_over): Update.
7134         (resume_1): Update.
7135         (clear_proceed_status_thread): Update.
7136         (proceed): Update.
7137         (print_target_wait_results): Update.
7138         (do_target_wait): Update.
7139         (context_switch): Update.
7140         (stop_all_threads): Update.
7141         (restart_threads): Update.
7142         (finish_step_over): Update.
7143         (handle_signal_stop): Update.
7144         (switch_back_to_stepped_thread): Update.
7145         (keep_going_pass_signal): Update.
7146         (print_exited_reason): Update.
7147         (normal_stop): Update.
7148         * inferior.c (inferior_pid_to_str): Change return type.
7149         (print_selected_inferior): Update.
7150         (add_inferior): Update.
7151         (detach_inferior): Update.
7152         * dummy-frame.c (fprint_dummy_frames): Update.
7153         * dcache.c (dcache_info_1): Update.
7154         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7155         (btrace_fetch, btrace_clear): Update.
7156         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7157         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7158         type.
7159         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7160         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7161         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7162         * gdbarch.c, gdbarch.h: Rebuild.
7163         * gdbarch.sh (core_pid_to_str): Change return type.
7164         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7165         return type.
7166         (windows_nat_target::pid_to_str): Change return type.
7167         (windows_delete_thread): Update.
7168         (windows_nat_target::attach): Update.
7169         (windows_nat_target::files_info): Update.
7170         * target-delegates.c: Rebuild.
7171         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7172         return type.
7173         (sol_thread_target::pid_to_str): Change return type.
7174         * remote.c (class remote_target) <pid_to_str>: Change return
7175         type.
7176         (remote_target::pid_to_str): Change return type.
7177         (extended_remote_target::attach, remote_target::remote_stop_ns)
7178         (remote_target::remote_notif_remove_queued_reply)
7179         (remote_target::push_stop_reply, remote_target::disable_btrace):
7180         Update.
7181         (extended_remote_target::attach): Update.
7182         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7183         type.
7184         (gdbsim_target::pid_to_str): Change return type.
7185         * ravenscar-thread.c (struct ravenscar_thread_target)
7186         <pid_to_str>: Change return type.
7187         (ravenscar_thread_target::pid_to_str): Change return type.
7188         * procfs.c (class procfs_target) <pid_to_str>: Change return
7189         type.
7190         (procfs_target::pid_to_str): Change return type.
7191         (procfs_target::attach): Update.
7192         (procfs_target::detach): Update.
7193         (procfs_target::fetch_registers): Update.
7194         (procfs_target::store_registers): Update.
7195         (procfs_target::wait): Update.
7196         (procfs_target::files_info): Update.
7197         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7198         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7199         return type.
7200         (nto_procfs_target::pid_to_str): Change return type.
7201         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7202         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7203         return type.
7204         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7205         (exit_lwp): Update.
7206         (attach_proc_task_lwp_callback, get_detach_signal)
7207         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7208         (linux_nat_target::resume, wait_lwp, stop_callback)
7209         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7210         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7211         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7212         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7213         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7214         type.
7215         (inf_ptrace_target::attach): Update.
7216         (inf_ptrace_target::files_info): Update.
7217         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7218         type.
7219         (go32_nat_target::pid_to_str): Change return type.
7220         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7221         (gnu_nat_target::wait): Update.
7222         (gnu_nat_target::wait): Update.
7223         (gnu_nat_target::resume): Update.
7224         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7225         (fbsd_nat_target::wait): Update.
7226         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7227         type.
7228         (darwin_nat_target::attach): Update.
7229         * corelow.c (class core_target) <pid_to_str>: Change return type.
7230         (core_target::pid_to_str): Change return type.
7231         * target.c (normal_pid_to_str): Change return type.
7232         (default_pid_to_str): Likewise.
7233         (target_pid_to_str): Change return type.
7234         (target_translate_tls_address): Update.
7235         (target_announce_detach): Update.
7236         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7237         return type.
7238         (bsd_uthread_target::pid_to_str): Change return type.
7239         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7240         type.
7241         (bsd_kvm_target::pid_to_str): Change return type.
7242         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7243         return type.
7244         (aix_thread_target::pid_to_str): Change return type.
7245         * target.h (struct target_ops) <pid_to_str>: Change return type.
7246         (target_pid_to_str, normal_pid_to_str): Likewise.
7247         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7248         type.
7249         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7250         type.
7251         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7252         return type.
7253         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7254         type.
7255         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7256         type.
7257         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7258         return type.
7259
7260 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7261
7262         * NEWS: Mention that the new default MI version is 3.  Mention
7263         changes to the output of commands and events that deal with
7264         multi-location breakpoints.
7265         * breakpoint.c: Include "mi/mi-out.h".
7266         (print_one_breakpoint): Change output syntax if using MI version
7267         >= 3.
7268         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7269         New.
7270         (mi_multi_location_breakpoint_output_fixed): New.
7271         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7272         (mi_cmd_fix_multi_location_breakpoint_output): New.
7273         (mi_multi_location_breakpoint_output_fixed): New.
7274         * mi/mi-cmds.c (mi_cmds): Register command
7275         -fix-multi-location-breakpoint-output.
7276         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7277         interpreter "mi".
7278
7279 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7280
7281         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7282         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7283         instantiate mi_ui_out based on interpreter name.
7284         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7285         * mi/mi-main.c (mi_load_progress): Likewise.
7286
7287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7288
7289         * NEWS: Combine separate "New targets" sections for 8.3.
7290
7291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7292
7293         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7294         (ppcfbsd_init_abi): Install gdbarch
7295         "fetch_tls_load_module_address" and "get_thread_local_address"
7296         methods.
7297
7298 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7299
7300         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7301         (riscv_fbsd_init_abi): Install gdbarch
7302         "fetch_tls_load_module_address" and "get_thread_local_address"
7303         methods.
7304
7305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7306
7307         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7308         (i386fbsd_init_abi): Install gdbarch
7309         "fetch_tls_load_module_address" and "get_thread_local_address"
7310         methods.
7311
7312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7313
7314         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7315         (amd64fbsd_init_abi): Install gdbarch
7316         "fetch_tls_load_module_address" and "get_thread_local_address"
7317         methods.
7318
7319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7320
7321         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7322         (struct fbsd_pspace_data): New type.
7323         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7324         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7325         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7326         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7327         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7328
7329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7330
7331         * gdbtypes.c (lookup_struct_elt): New function.
7332         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7333         * gdbtypes.h (struct struct_elt): New type.
7334         (lookup_struct_elt): New prototype.
7335
7336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7337
7338         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7339         remove disabled code block.
7340
7341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7342
7343         * gdbarch.sh (get_thread_local_address): New method.
7344         * gdbarch.h, gdbarch.c: Regenerate.
7345         * target.c (target_translate_tls_address): Use
7346         gdbarch_get_thread_local_address if present instead of
7347         target::get_thread_local_address.
7348
7349 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7350
7351         * target.h (target::get_thread_local_address): Update comment.
7352
7353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7354
7355         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7356         objfile->separate_debug_objfile_backlink if not NULL.
7357
7358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7359
7360         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7361         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7362         (amd64bsd_store_inferior_registers): Likewise.
7363         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7364         Enable segment base registers.
7365         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7366         PT_GETFSBASE and PT_GETGSBASE.
7367         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7368         PT_SETGSBASE.
7369         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7370         segment base registers.
7371         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7372
7373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7374
7375         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7376         Update calls to i386_target_description to add 'segments'
7377         parameter.
7378         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7379         add segment base registers.
7380         * arch/i386.c (i386_create_target_description): Add 'segments'
7381         parameter to enable segment base registers.
7382         * arch/i386.h (i386_create_target_description): Likewise.
7383         * features/i386/32bit-segments.xml: New file.
7384         * features/i386/32bit-segments.c: Generate.
7385         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7386         call to i386_target_description to add 'segments' parameter.
7387         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7388         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7389         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7390         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7391         if feature is present.
7392         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7393         Add 'segments' parameter to call to i386_target_description.
7394         (i386_target_description): Add 'segments' parameter to enable
7395         segment base registers.
7396         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7397         to call to i386_target_description.
7398         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7399         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7400         Define I386_NUM_REGS.
7401         (i386_target_description): Add 'segments' parameter to enable
7402         segment base registers.
7403
7404 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7405
7406         PR/24325
7407         * source-cache.c: #undef open and close, to avoid unresolved
7408         externals during linking.
7409
7410 2019-03-12  Tom Tromey  <tromey@adacore.com>
7411
7412         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7413         const.  Add initializers.
7414         (_initialize_remote): Don't initialize ptid globals.
7415
7416 2019-03-12  Pedro Alves  <palves@redhat.com>
7417
7418         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7419
7420 2019-03-12  Pedro Alves  <palves@redhat.com>
7421
7422         * cp-name-parser.y (main): Remove unused 'len' variable.
7423
7424 2019-03-12  Tom Tromey  <tromey@adacore.com>
7425
7426         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7427         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7428
7429 2019-03-12  Tom Tromey  <tromey@adacore.com>
7430
7431         * linux-nat.c (iterate_over_lwps): Update.
7432         (stop_callback): Remove parameter.
7433         (stop_wait_callback, detach_callback, resume_set_callback)
7434         (select_singlestep_lwp_callback, set_ignore_sigint)
7435         (status_callback, resumed_callback, resume_clear_callback)
7436         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7437         data parameter.
7438         (linux_nat_target::detach, linux_nat_target::resume)
7439         (linux_stop_and_wait_all_lwps, select_event_lwp)
7440         (linux_nat_filter_event, linux_nat_wait_1)
7441         (linux_nat_target::kill, linux_nat_target::stop)
7442         (linux_nat_target::stop): Update.
7443         (linux_nat_resume_callback): Change type.
7444         (resume_stopped_resumed_lwps, count_events_callback)
7445         (select_event_lwp_callback): Likewise.
7446         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7447         * arm-linux-nat.c (struct update_registers_data): Remove.
7448         (update_registers_callback): Change type.
7449         (arm_linux_insert_hw_breakpoint1): Update.
7450         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7451         parameter.
7452         (x86_linux_dr_set_addr): Update.
7453         (x86_linux_dr_set_control): Update.
7454         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7455         (iterate_over_lwps): Use gdb::function_view.
7456         * nat/aarch64-linux-hw-point.c (struct
7457         aarch64_dr_update_callback_param): Remove.
7458         (debug_reg_change_callback): Change type.
7459         (aarch64_notify_debug_reg_change): Update.
7460         * s390-linux-nat.c (s390_refresh_per_info): Update.
7461
7462 2019-03-11  Tom Tromey  <tromey@adacore.com>
7463
7464         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7465         redundant assignment to "this_cu".
7466
7467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7468
7469         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7470
7471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7472
7473         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7474         from...
7475         (rank_one_type): ... this.
7476
7477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7478
7479         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7480         from...
7481         (rank_one_type): ... this.
7482
7483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7484
7485         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7486         from...
7487         (rank_one_type): ... this.
7488
7489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7490
7491         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7492         from...
7493         (rank_one_type): ... this.
7494
7495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7496
7497         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7498         from...
7499         (rank_one_type): ... this.
7500
7501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7502
7503         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7504         from...
7505         (rank_one_type): ... this.
7506
7507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7508
7509         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7510         from...
7511         (rank_one_type): ... this.
7512
7513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7514
7515         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7516         from...
7517         (rank_one_type): ... this.
7518
7519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7520
7521         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7522         from...
7523         (rank_one_type): ... this.
7524
7525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7526
7527         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7528         from...
7529         (rank_one_type): ... this.
7530
7531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7532
7533         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7534         from...
7535         (rank_one_type): ... this.
7536
7537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7538
7539         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7540         from...
7541         (rank_one_type): ... this.
7542
7543 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7544
7545         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7546         inferior-events' shows the example events.
7547
7548 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7549
7550         Support styling on native MS-Windows console
7551
7552         PR/24315
7553         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7554         on MS-Windows if $TERM is not defined.
7555
7556         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7557
7558         * posix-hdep.c (gdb_console_fputs):
7559         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7560         functions.
7561         * ui-file.h (gdb_console_fputs): Add prototype.
7562
7563         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7564         back to fputs only if the former returns zero.
7565
7566 2019-03-07  Tom Tromey  <tom@tromey.com>
7567
7568         * symmisc.c (print_symbol_bcache_statistics): Update.
7569         (print_objfile_statistics): Update.
7570         * symfile.c (allocate_symtab): Update.
7571         * stabsread.c: Don't include bcache.h.
7572         * psymtab.h (struct psymbol_bcache): Don't declare.
7573         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7574         (psymbol_bcache_init, psymbol_bcache_free)
7575         (psymbol_bcache_get_bcache): Don't declare.
7576         * psymtab.c (struct psymbol_bcache): Remove.
7577         (psymtab_storage::psymtab_storage): Update.
7578         (psymtab_storage::~psymtab_storage): Update.
7579         (psymbol_bcache_init, psymbol_bcache_free)
7580         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7581         (add_psymbol_to_bcache): Update.
7582         (allocate_psymtab): Update.
7583         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7584         macro_cache>: No longer pointers.
7585         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7586         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7587         * macrotab.c (macro_bcache): Update.
7588         * macroexp.c: Don't include bcache.h.
7589         * gdbtypes.c (check_types_worklist): Update.
7590         (types_deeply_equal): Remove TRY/CATCH.  Update.
7591         * elfread.c (elf_symtab_read): Update.
7592         * dwarf2read.c: Don't include bcache.h.
7593         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7594         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7595         (print_bcache_statistics, bcache_memory_used): Don't declare.
7596         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7597         methods.  Rename all data members.
7598         * bcache.c (struct bcache): Move to bcache.h.
7599         (bcache::expand_hash_table): Rename from expand_hash_table.
7600         (bcache): Remove.
7601         (bcache::insert): Rename from bcache_full.
7602         (bcache::compare): Rename from bcache_compare.
7603         (bcache_xmalloc): Remove.
7604         (bcache::~bcache): Rename from bcache_xfree.
7605         (bcache::print_statistics): Rename from print_bcache_statistics.
7606         (bcache::memory_used): Rename from bcache_memory_used.
7607
7608 2019-03-07  Pedro Alves  <palves@redhat.com>
7609
7610         * infrun.c (normal_stop): Also check for
7611         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7612
7613 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7614
7615         * f-lang.c (value_from_host_double): Moved to...
7616         * value.c (value_from_host_double): ...here.
7617         * value.h (value_from_host_double): Declare.
7618         * guile/scm-math.c (vlscm_convert_typed_number): Use
7619         value_from_host_double.
7620         (vlscm_convert_number): Likewise.
7621         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7622         * python/py-value.c (convert_value_from_python): Likewise.
7623
7624 2019-03-06  Tom Tromey  <tom@tromey.com>
7625
7626         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7627
7628 2019-03-06  Tom Tromey  <tom@tromey.com>
7629
7630         * utils.h (free_current_contents): Don't declare.
7631         * utils.c (free_current_contents): Remove.
7632
7633 2019-03-06  Tom Tromey  <tom@tromey.com>
7634
7635         * top.c (quit_force): Update.
7636         * main.c (captured_command_loop): Update.
7637         * common/new-op.c (operator new): Update.
7638         * common/common-exceptions.c (struct catcher)
7639         <save_cleanup_chain>: Remove member.
7640         (exceptions_state_mc_init): Update.
7641         (exception_try_scope_entry): Return nullptr.
7642         (exception_try_scope_exit, exception_rethrow)
7643         (throw_exception_sjlj, throw_exception_cxx): Update.
7644         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7645         (all_cleanups, do_cleanups, discard_cleanups)
7646         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7647         (restore_cleanups, restore_final_cleanups): Don't declare.
7648         (do_final_cleanups): Remove parameter.
7649         * common/cleanups.c (cleanup_chain, make_cleanup)
7650         (make_cleanup_dtor, all_cleanups, do_cleanups)
7651         (discard_my_cleanups, discard_cleanups)
7652         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7653         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7654         (null_cleanup): Remove.
7655         (do_final_cleanups): Remove parameter.
7656
7657 2019-03-06  Tom Tromey  <tom@tromey.com>
7658
7659         * remote.c (remote_target::remote_parse_stop_reply): Use
7660         unique_xmalloc_ptr.
7661
7662 2019-03-06  Tom Tromey  <tom@tromey.com>
7663
7664         * stabsread.c (struct stabs_field_info): Rename from field_info.
7665         <list, fnlist>: Add initializers.
7666         <obstack>: New member.
7667         (read_member_functions, read_struct_fields, read_baseclasses):
7668         Allocate on obstack.  Don't use cleanups.
7669         (read_one_struct_field, read_member_functions, read_struct_fields)
7670         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7671         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7672         (read_struct_type): Update.
7673
7674 2019-03-06  Tom Tromey  <tom@tromey.com>
7675
7676         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7677         * common/filestuff.h (make_cleanup_close): Don't declare.
7678         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7679         Remove.
7680
7681 2019-03-06  Tom Tromey  <tom@tromey.com>
7682
7683         * solib-aix.c: Use make_scope_exit.
7684
7685 2019-03-06  Tom Tromey  <tom@tromey.com>
7686
7687         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7688         Use make_scope_exit.
7689
7690 2019-03-06  Tom Tromey  <tom@tromey.com>
7691
7692         * solib-svr4.c (disable_probes_interface): Remove parameter.
7693         (svr4_handle_solib_event): Use make_scope_exit.
7694
7695 2019-03-06  Tom Tromey  <tom@tromey.com>
7696
7697         * remote.c (struct stop_reply_deleter): Remove.
7698         (stop_reply_up): Update.
7699         (struct stop_reply): Derive from notif_event.  Don't typedef.
7700         <regcache>: Now a std::vector.
7701         (stop_reply_xfree): Remove.
7702         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7703         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7704         (remote_target::discard_pending_stop_replies): Use delete.
7705         (remote_target::remote_parse_stop_reply): Update.
7706         (remote_target::process_stop_reply): Update.
7707         * remote-notif.h (struct notif_event): Add virtual destructor.
7708         Remove "dtr" member.
7709         (struct notif_client) <alloc_event>: Return a unique_ptr.
7710         (notif_event_xfree): Don't declare.
7711         (notif_event_up): New typedef.
7712         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7713         (notif_event_xfree, do_notif_event_xfree): Remove.
7714         (remote_notif_state_xfree): Update.
7715
7716 2019-03-06  Tom Tromey  <tom@tromey.com>
7717
7718         * infrun.c (displaced_step_clear_cleanup): Now a
7719         forward_scope_exit type.
7720         (displaced_step_prepare_throw): Update.
7721         (displaced_step_fixup): Update.
7722
7723 2019-03-06  Tom Tromey  <tom@tromey.com>
7724
7725         * inferior.h (class inferior): Update comment.
7726         * gdbthread.h (class thread_info): Update comment.
7727
7728 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7729             Tom Tromey  <tom@tromey.com>
7730
7731         * stabsread.h (struct stab_section_list): Remove.
7732         (coffstab_build_psymtabs): Update.
7733         * dbxread.c (symbuf_sections): Now a std::vector.
7734         (sect_idx): New global.
7735         (fill_symbuf): Update.
7736         (coffstab_build_psymtabs): Change type of stabsects parameter.
7737         Update.
7738         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7739         std::vector.
7740         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7741         (coff_locate_sections): Update.
7742         (coff_symfile_read): Remove cleanups.  Update.
7743         (init_stringtab): Add storage parameter.
7744         (free_stringtab, free_stringtab_cleanup): Remove.
7745         (init_lineno): Add storage parameter.
7746         (free_linetab, free_linetab_cleanup): Remove.
7747
7748 2019-03-06  Pedro Alves  <palves@redhat.com>
7749
7750         * linux-fork.c (fork_info::clobber_regs): Delete.
7751         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7752         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7753         comment.  Adjust.
7754         (scoped_switch_fork_info::scoped_switch_fork_info)
7755         (checkpoint_command, linux_fork_context): Adjust
7756         fork_save_infrun_state calls.
7757
7758 2019-03-06  Pedro Alves  <palves@redhat.com>
7759
7760         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7761         (inf_has_multiple_threads): Return 'bool' and rewrite using
7762         inferior_info::threads().
7763
7764 2019-03-06  Pedro Alves  <palves@redhat.com>
7765
7766         * linux-fork.c: Include <list>.
7767         (fork_list): Now a std::list instance.
7768         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7769         (forks_exist_p, find_last_fork): Adjust.
7770         (new_fork): Delete.
7771         (one_fork_p): New.
7772         (add_fork): Adjust.
7773         (free_fork): Delete, folded into fork_info::~fork_info().
7774         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7775         Adjust.
7776         (init_fork_list): Delete.
7777         (linux_fork_killall, linux_fork_mourn_inferior)
7778         (linux_fork_detach, info_checkpoints_command): Adjust.
7779         (_initialize_linux_fork): No longer call init_fork_list.
7780
7781 2019-03-06  Pedro Alves  <palves@redhat.com>
7782
7783         * linux-fork.c (new_fork): New, split out of ...
7784         (add_fork): ... this.  Return void.  Move "first fork" special
7785         case from here, to ...
7786         (checkpoint_command): ... here.
7787         * linux-linux.h (add_fork): Return void.
7788
7789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7792
7793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7794             Chris January  <chris.january@arm.com>
7795             David Lecomber  <david.lecomber@arm.com>
7796
7797         * f-exp.y: New token, UNOP_INTRINSIC.
7798         (exp): New pattern using UNOP_INTRINSIC token.
7799         (f77_keywords): Add 'abs' keyword.
7800         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7801         (value_from_host_double): New function.
7802         (evaluate_subexp_f): Support UNOP_ABS.
7803
7804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7805
7806         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7807         types.
7808
7809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7812         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7813         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7814
7815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7818
7819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7820             Chris January  <chris.january@arm.com>
7821
7822         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7823         * f-exp.y: Define 'KIND' token.
7824         (exp): New pattern for KIND expressions.
7825         (ptype): Handle types with a kind extension.
7826         (direct_abs_decl): Extend to spot kind extensions.
7827         (f77_keywords): Add 'kind' to the list.
7828         (push_kind_type): New function.
7829         (convert_to_kind_type): New function.
7830         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7831         * parse.c (operator_length_standard): Likewise.
7832         * parser-defs.h (enum type_pieces): Add tp_kind.
7833         * std-operator.def: Add UNOP_KIND.
7834
7835 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * f-exp.y (f_parse): Set yydebug.
7838
7839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7840
7841         * f-lang.c (evaluate_subexp_f): New function.
7842         (exp_descriptor_f): New global.
7843         (f_language_defn): Use exp_descriptor_f instead of
7844         exp_descriptor_standard.
7845
7846 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * f-exp.y (struct token): Add comments.
7849         (dot_ops): Remove uppercase versions and the end marker.
7850         (f77_keywords): Likewise.
7851         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7852         entries in the dot_ops array are case insensitive, and use
7853         strncasecmp to compare strings.  Also some whitespace cleanup in
7854         this area.  Similar for the f77_keywords array, except entries in
7855         this list might be case sensitive.
7856
7857 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * f-exp.y (struct f77_boolean_val): Add comments.
7860         (boolean_values): Remove uppercase versions, and end marker.
7861         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7862         and use strncasecmp to achieve case insensitivity.  Additionally,
7863         perform whitespace cleanup around this code.
7864
7865 2019-03-06  Tom Tromey  <tromey@adacore.com>
7866
7867         * remote-sim.c (gdbsim_target_open): Use result of
7868         gdb_argv::release.
7869
7870 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7871         Dirk Schubert  <dirk.schubert@arm.com>
7872         Chris January  <chris.january@arm.com>
7873
7874         * eval.c (evaluate_subexp_standard): Call Fortran argument
7875         wrapping logic.
7876         * f-lang.c (struct value): A value which can be passed into a
7877         Fortran function call.
7878         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7879         where appropriate.
7880         (struct type): Value ready for a Fortran function call.
7881         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7882         is needed.
7883         * f-lang.h (fortran_argument_convert): Declaration.
7884         (fortran_preserve_arg_pointer): Declaration.
7885         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7886
7887 2019-03-05  Tom Tromey  <tromey@adacore.com>
7888
7889         * python/py-prettyprint.c (print_string_repr): Remove #if.
7890         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7891
7892 2019-03-05  Tom Tromey  <tromey@adacore.com>
7893
7894         * target.c (the_dummy_target): Move later.  Change type to
7895         "dummy_target".
7896         (initialize_targets): Don't initialize the_dummy_target.
7897
7898 2019-03-05  Tom Tromey  <tromey@adacore.com>
7899
7900         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7901         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7902
7903 2019-03-05  Tom Tromey  <tromey@adacore.com>
7904
7905         * windows-nat.c (windows_nat_target::attach)
7906         (windows_nat_target::detach): Don't call gdb_flush.
7907         * valprint.c (generic_val_print, val_print, val_print_string):
7908         Don't call gdb_flush.
7909         * utils.c (defaulted_query): Don't call gdb_flush.
7910         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7911         * target.c (target_announce_detach): Don't call gdb_flush.
7912         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7913         * remote.c (extended_remote_target::attach): Don't call
7914         gdb_flush.
7915         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7916         * printcmd.c (do_examine): Don't call gdb_flush.
7917         (info_display_command): Don't call gdb_flush.
7918         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7919         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7920         * memattr.c (info_mem_command): Don't call gdb_flush.
7921         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7922         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7923         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7924         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7925         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7926         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7927         (gnu_nat_target::detach): Don't call gdb_flush.
7928         * f-valprint.c (f_val_print): Don't call gdb_flush.
7929         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7930         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7931         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7932         gdb_flush.
7933         * c-valprint.c (c_val_print): Don't call gdb_flush.
7934         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7935
7936 2019-03-05  Tom Tromey  <tromey@adacore.com>
7937
7938         * varobj.c (update_dynamic_varobj_children): Update.
7939         (install_default_visualizer): Use reset, not release.
7940         * value.c (set_internalvar): Update.
7941         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7942         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7943         ATTRIBUTE_UNUSED_RESULT.
7944
7945 2019-03-05  Tom Tromey  <tromey@adacore.com>
7946
7947         * remote.c (class scoped_remote_fd) <release>: Add
7948         ATTRIBUTE_UNUSED_RESULT.
7949
7950 2019-03-05  Tom Tromey  <tromey@adacore.com>
7951
7952         * macroexp.c (struct macro_buffer) <release>: Add
7953         ATTRIBUTE_UNUSED_RESULT.
7954
7955 2019-03-05  Tom Tromey  <tromey@adacore.com>
7956
7957         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7958         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7959         ATTRIBUTE_UNUSED_RESULT.
7960
7961 2019-03-05  Tom Tromey  <tromey@adacore.com>
7962
7963         * common/scoped_fd.h (class scoped_fd) <release>: Add
7964         ATTRIBUTE_UNUSED_RESULT.
7965
7966 2019-03-05  Tom Tromey  <tromey@adacore.com>
7967
7968         * parser-defs.h (struct parser_state) <release>: Add
7969         ATTRIBUTE_UNUSED_RESULT.
7970
7971 2019-03-05  Tom Tromey  <tromey@adacore.com>
7972
7973         * utils.h (class gdb_argv) <release>: Add
7974         ATTRIBUTE_UNUSED_RESULT.
7975         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7976
7977 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7978
7979         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7980         for-loop range, to avoid compiler warnings.
7981
7982         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7983         avoid compiler warnings about unused variables.
7984
7985         * NEWS: Mention end of support for native debugging on MS-Windows
7986         before XP.
7987
7988         PR gdb/24292
7989         * common/netstuff.c:
7990         * gdbserver/gdbreplay.c
7991         * gdbserver/remote-utils.c:
7992         * ser-tcp.c:
7993         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7994         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7995         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7996         'getaddrinfo' and 'freeaddrinfo' were not available before
7997         Windows XP, and mingw.org's MinGW headers by default define
7998         _WIN32_WINNT to 0x500.
7999
8000 2019-03-01  Gary Benson <gbenson@redhat.com>
8001
8002         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8003
8004 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8005             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8006
8007         PR gdb/8527
8008         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8009         set_sigint_trap, clear_sigint_trap.
8010
8011 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8012
8013         * target.c (target_detach): Clear the regcache and the
8014         frame cache.
8015
8016 2019-02-27  Pedro Alves  <palves@redhat.com>
8017
8018         * utils.c (set_screen_size): When we cap the height/width sizes,
8019         tweak the corresponding command variable to show "unlimited":
8020
8021 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8022             Pedro Alves  <palves@redhat.com>
8023
8024         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8025         before calling rl_set_screen_size.
8026
8027 2019-02-27  Tom Tromey  <tromey@adacore.com>
8028
8029         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8030         define.
8031         * python/py-value.c: Remove Python 2.4 workaround.
8032         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8033         workaround.
8034         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8035         Python 2.4 workaround.
8036         * python/python-internal.h: Remove Python 2.4 comment.
8037         (Py_ssize_t): Don't define.
8038         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8039         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8040         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8041         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8042         * python/python.c (do_start_initialization): Remove Python 2.4
8043         workaround.
8044         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8045         (print_children): Remove Python 2.4 workaround.
8046         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8047         workaround.
8048         (CHARBUFFERPROC_NAME): Remove.
8049         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8050         Python 2.4 workaround.
8051
8052 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8053
8054         * NEWS: Note minimum Python version.
8055
8056 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8057
8058         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8059         code from these functions.  Remove corresponding ifdefs.  Use
8060         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8061         Remove gotos and target of gotos.
8062         (infpy_search_memory): Likewise.
8063
8064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8067         (hppa_gdbarch_init): Don't register deleted functions with
8068         gdbarch.
8069
8070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8071
8072         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8073         (h8300_unwind_sp): Delete.
8074         (h8300_dummy_id): Delete.
8075         (h8300_gdbarch_init): Don't register deleted functions with
8076         gdbarch.
8077
8078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8079
8080         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8081         (ft32_unwind_pc): Delete.
8082         (ft32_unwind_sp): Delete.
8083         (ft32_gdbarch_init): Don't register deleted functions with
8084         gdbarch.
8085
8086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8089         (frv_unwind_pc): Delete.
8090         (frv_unwind_sp): Delete.
8091         (frv_gdbarch_init): Don't register deleted functions with
8092         gdbarch.
8093
8094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8097         (riscv_unwind_pc): Delete.
8098         (riscv_unwind_sp): Delete.
8099         (riscv_gdbarch_init): Don't register deleted functions with
8100         gdbarch.
8101
8102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8105         (csky_unwind_pc): Delete.
8106         (csky_unwind_sp): Delete.
8107         (csky_gdbarch_init): Don't register deleted functions with
8108         gdbarch.
8109
8110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8113         (cris_unwind_pc): Delete.
8114         (cris_unwind_sp): Delete.
8115         (cris_gdbarch_init): Don't register deleted functions with
8116         gdbarch.
8117
8118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8121         (bfin_unwind_pc): Delete.
8122         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8123
8124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8125
8126         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8127         (arm_unwind_pc): Delete.
8128         (arm_unwind_sp): Delete.
8129         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8130
8131 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8132
8133         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8134         (arc_unwind_pc): Delete.
8135         (arc_unwind_sp): Delete.
8136         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8137
8138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8141         (alpha_unwind_pc): Delete.
8142         (alpha_gdbarch_init): Don't register deleted functions with
8143         gdbarch.
8144
8145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8146
8147         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8148         (aarch64_unwind_pc): Delete.
8149         (aarch64_unwind_sp): Delete.
8150         (aarch64_gdbarch_init): Don't register deleted functions with
8151         gdbarch.
8152
8153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8154
8155         * gdbtypes.c (type_align): Don't consider static members when
8156         computing structure alignment.
8157
8158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8161         return 0 for other types.
8162         * arch-utils.c (default_type_align): Always return 0.
8163         * gdbarch.h: Regenerate.
8164         * gdbarch.sh (type_align): Extend comment.
8165         * gdbtypes.c (type_align): Add additional comments, always call
8166         gdbarch_type_align before applying the default rules.
8167         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8168         generic code will then apply a suitable default.
8169         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8170         types, return 0 for other types.
8171
8172 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8173
8174         * NEWS: Create a new section for the next release branch.
8175         Rename the section of the current branch, now that it has
8176         been cut.
8177
8178 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8179
8180         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8181         * version.in: Bump version to 8.3.50.DATE-git.
8182
8183 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8184
8185         * aix-thread.c (ptid_cmp): Remove unused variable.
8186         (get_signaled_thread): Likewise.
8187         (store_regs_user_thread): Likewise.
8188         (store_regs_kernel_thread): Likewise.
8189         (fetch_regs_kernel_thread): Remove shadowed variable.
8190
8191 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8192
8193         * features/riscv/32bit-cpu.xml: Add register numbers.
8194         * features/riscv/32bit-fpu.c: Regenerate.
8195         * features/riscv/32bit-fpu.xml: Add register numbers.
8196         * features/riscv/64bit-cpu.xml: Add register numbers.
8197         * features/riscv/64bit-fpu.c: Regenerate.
8198         * features/riscv/64bit-fpu.xml: Add register numbers.
8199
8200 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8201
8202         * NEWS: Mention two argument form of gdb.Value constructor.
8203         * python/py-value.c (convert_buffer_and_type_to_value): New
8204         function.
8205         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8206         Add support for handling an optional second argument.  Call
8207         convert_buffer_and_type_to_value as appropriate.
8208         * python/python-internal.h (Py_buffer_deleter): New struct.
8209         (Py_buffer_up): New typedef.
8210
8211 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8212
8213         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8214         instead of releasing ownership.
8215
8216 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8217
8218         * dwarf2read.c (open_and_init_dwp_file): Call
8219         elf_numsections instead of bfd_count_sections to initialize
8220         dwp_file->num_sections.
8221
8222 2019-02-25  Tom Tromey  <tromey@adacore.com>
8223
8224         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8225
8226 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8227
8228         * gcore.in: Add '--readnever' option when invoking GDB.
8229
8230 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8231
8232         * MAINTAINERS: Update my email address.
8233
8234 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8235
8236         * build-id.c (build_id_to_debug_bfd_1): New function.
8237         (build_id_to_debug_bfd): Look for separate debug file in
8238         sysroot.
8239
8240 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8241
8242         * gdbarch.sh: Update the copyright year range that is placed into
8243         generated files.
8244
8245 2019-02-22  Keith Seitz  <keiths@redhat.com>
8246
8247         PR symtab/23853
8248         * linespec.c (create_sals_line_offset): Search for the default
8249         symtab's filename instead of its fullname.
8250
8251 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8252
8253         * NEWS: Update style defaults.
8254
8255 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8256
8257         * main.c (captured_main_1): Disable styling in batch mode.
8258
8259 2019-02-20  Tom Tromey  <tom@tromey.com>
8260
8261         * symtab.c (symtab_symbol_info): Fix typos.
8262
8263 2019-02-20  Tom Tromey  <tromey@adacore.com>
8264
8265         * findcmd.c (_initialize_mem_search): Use upper case for
8266         metasyntactic variables.
8267
8268 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8269
8270         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8271         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8272
8273 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8274
8275         * top.h (source_file_name): Change to std::string.
8276         * top.c (source_file_name): Likewise.
8277         (command_line_input): Adjust.
8278         * cli/cli-script.c (script_from_file): Adjust.
8279
8280 2019-02-19  Tom Tromey  <tromey@adacore.com>
8281
8282         * ravenscar-thread.c
8283         (ravenscar_thread_target::update_thread_list): Don't call
8284         ada_build_task_list.
8285         * ada-lang.h (ada_build_task_list): Don't declare.
8286         * ada-tasks.c (struct ada_tasks_inferior_data)
8287         <task_list_valid_p>: Now bool.
8288         (read_known_tasks, ada_task_list_changed)
8289         (ada_tasks_invalidate_inferior_data): Update.
8290         (read_known_tasks_array): Return bool.
8291         (read_known_tasks_list): Likewise.
8292         (read_known_tasks): Return void.
8293         (ada_build_task_list): Now static.
8294
8295 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8296
8297         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8298         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8299
8300 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8301
8302         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8303         variant for ada_tasks_pspace_data_handle and
8304         ada_tasks_inferior_data_handle.
8305         (ada_tasks_pspace_data_cleanup): New function.
8306         (ada_tasks_inferior_data_cleanup): New function.
8307
8308 2019-02-17  Tom Tromey  <tom@tromey.com>
8309
8310         * macrotab.h (macro_source_fullname): Return a std::string.
8311         * macrotab.c (macro_include, check_for_redefinition)
8312         (macro_undef, macro_lookup_definition, foreach_macro)
8313         (foreach_macro_in_scope): Update.
8314         (macro_source_fullname): Return a std::string.
8315         * macrocmd.c (show_pp_source_pos): Update.
8316
8317 2019-02-17  Tom Tromey  <tom@tromey.com>
8318
8319         * macrocmd.c (show_pp_source_pos): Style the file names.
8320
8321 2019-02-17  Tom Tromey  <tom@tromey.com>
8322
8323         PR tui/24197:
8324         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8325
8326 2019-02-17  Tom Tromey  <tom@tromey.com>
8327
8328         * ada-lang.c (user_select_syms): Use filtered printing.
8329         * utils.c (wrap_style): New global.
8330         (desired_style): Remove.
8331         (emit_style_escape): Add stream parameter.
8332         (set_output_style, reset_terminal_style, prompt_for_continue):
8333         Update.
8334         (flush_wrap_buffer): Only flush gdb_stdout.
8335         (wrap_here): Set wrap_style.
8336         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8337         treat escape sequences as a character.  Change when wrap buffer is
8338         flushed.
8339         (fputs_styled): Do not set the output style when the default is
8340         requested.
8341         * ui-style.h (struct ui_file_style) <is_default>: New method.
8342         * source.c (print_source_lines_base): Emit escape sequences in one
8343         piece.
8344
8345 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8346
8347         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8348         integers and enumeration types.
8349
8350 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8351
8352         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8353         instead of lookup_symbol_in_language
8354         (do_exact_match): New function.
8355         (ada_get_symbol_name_matcher): Return do_exact_match when
8356         doing a verbatim match.
8357
8358 2019-02-15  Tom Tromey  <tromey@adacore.com>
8359
8360         * ravenscar-thread.c (ravenscar_thread_target::resume)
8361         (ravenscar_thread_target::wait): Special case wildcard requests.
8362
8363 2019-02-15  Tom Tromey  <tromey@adacore.com>
8364
8365         * ravenscar-thread.c (base_ptid): Remove.
8366         (struct ravenscar_thread_target) <close>: New method.
8367         <m_base_ptid>: New member.
8368         <update_inferior_ptid, active_task, task_is_currently_active,
8369         runtime_initialized>: Declare methods.
8370         <ravenscar_thread_target>: Add constructor.
8371         (ravenscar_thread_target::task_is_currently_active)
8372         (ravenscar_thread_target::update_inferior_ptid)
8373         (ravenscar_runtime_initialized): Rename.  Now methods.
8374         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8375         (ravenscar_thread_target::update_thread_list): Update.
8376         (ravenscar_thread_target::active_task): Now method.
8377         (ravenscar_thread_target::store_registers)
8378         (ravenscar_thread_target::prepare_to_store)
8379         (ravenscar_thread_target::prepare_to_store)
8380         (ravenscar_thread_target::mourn_inferior): Update.
8381         (ravenscar_inferior_created): Use "new" to create target.
8382         (ravenscar_thread_target::get_ada_task_ptid): Update.
8383         (_initialize_ravenscar): Don't initialize base_ptid.
8384         (ravenscar_ops): Remove global.
8385
8386 2019-02-15  Tom Tromey  <tromey@adacore.com>
8387
8388         * target.h (push_target): Declare new overload.
8389         * target.c (push_target): New overload, taking an rvalue reference.
8390         * remote.c (remote_target::open_1): Use push_target overload.
8391         * corelow.c (core_target_open): Use push_target overload.
8392
8393 2019-02-15  Tom Tromey  <tromey@adacore.com>
8394
8395         * ravenscar-thread.c (is_ravenscar_task)
8396         (ravenscar_task_is_currently_active): Return bool.
8397         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8398         (_initialize_ravenscar): Remove "(void)".
8399         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8400         Return bool.
8401
8402 2019-02-15  Tom Tromey  <tromey@adacore.com>
8403
8404         * ravenscar-thread.c (ravenscar_runtime_initializer)
8405         (has_ravenscar_runtime, get_running_thread_id)
8406         (ravenscar_thread_target::resume): Fix indentation.
8407
8408 2019-02-15  Tom Tromey  <tromey@adacore.com>
8409
8410         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8411         from ravenscar_arch_ops.
8412         (sparc_ravenscar_ops::fetch_registers)
8413         (sparc_ravenscar_ops::store_registers): Now methods.
8414         (sparc_ravenscar_prepare_to_store): Remove.
8415         (sparc_ravenscar_ops): Redefine.
8416         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8417         methods and destructor.  Remove members.
8418         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8419         (ravenscar_thread_target::store_registers)
8420         (ravenscar_thread_target::prepare_to_store): Update.
8421         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8422         Remove.
8423         (struct ppc_ravenscar_powerpc_ops): Derive from
8424         ravenscar_arch_ops.
8425         (ppc_ravenscar_powerpc_ops::fetch_registers)
8426         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8427         (ppc_ravenscar_powerpc_ops): Redefine.
8428         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8429         (ppc_ravenscar_e500_ops::fetch_registers)
8430         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8431         (ppc_ravenscar_e500_ops): Redefine.
8432         * aarch64-ravenscar-thread.c
8433         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8434         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8435         (aarch64_ravenscar_fetch_registers)
8436         (aarch64_ravenscar_store_registers): Now methods.
8437         (aarch64_ravenscar_ops): Redefine.
8438
8439 2019-02-15  Tom Tromey  <tromey@adacore.com>
8440
8441         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8442         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8443         (ravenscar_thread_target::stopped_by_watchpoint)
8444         (ravenscar_thread_target::stopped_data_address)
8445         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8446
8447 2019-02-15  Tom Tromey  <tromey@adacore.com>
8448
8449         * ravenscar-thread.c: Fix some typos.
8450
8451 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8452             Tom Tromey  <tromey@adacore.com>
8453
8454         * ada-lang.c (ada_exception_sal): Change addr_string to a
8455         std::string.
8456         (create_ada_exception_catchpoint): Update.
8457
8458 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8459             Tom Tromey  <tromey@adacore.com>
8460
8461         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8462         (bp_location_ops): Remove.
8463         (base_breakpoint_allocate_location): Update.
8464         (free_bp_location): Update.
8465         * ada-lang.c (class ada_catchpoint_location)
8466         <ada_catchpoint_location>: Remove ops parameter.
8467         (ada_catchpoint_location_dtor): Remove.
8468         (ada_catchpoint_location_ops): Remove.
8469         (allocate_location_exception): Update.
8470         * breakpoint.h (struct bp_location_ops): Remove.
8471         (class bp_location) <bp_location>: Remove bp_location_ops
8472         parameter.
8473         <~bp_location>: Add destructor.
8474         <ops>: Remove.
8475
8476 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8477             Pedro Alves  <palves@redhat.com>
8478
8479         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8480         'PATH_MAX'.
8481
8482 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8483             Samuel Thibault  <samuel.thibault@gnu.org>
8484             Thomas Schwinge  <thomas@codesourcery.com>
8485
8486         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8487         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8488
8489 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8490
8491         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8492         (check_empty): Use "const char *".
8493
8494         * gnu-nat.c (gnu_nat_target::detach): Instead of
8495         'detach_inferior (pid)' call
8496         'detach_inferior (find_inferior_pid (pid))'.
8497
8498         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8499         'nat/fork-inferior.o'.
8500         * gnu-nat.c: #include "nat/fork-inferior.h".
8501
8502         * gnu-nat.c (gnu_nat_target::detach): Instead of
8503         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8504         * gnu-nat.h: #include "inf-child.h".
8505         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8506         'i386_gnu_nat_target::fetch_registers'.
8507         (gnu_store_registers): Rename/move to
8508         'i386_gnu_nat_target::store_registers'.
8509
8510         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8511         * gnu-nat.h (mach_thread_info): New function.
8512         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8513
8514         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8515
8516 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8517
8518         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8519
8520 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8521
8522         * windows-nat.c (windows_add_thread): Add new parameter
8523         "main_thread_p" with default value set to false.  Update
8524         function documentation as well as all callers.
8525         (windows_delete_thread): Likewise.
8526         (fake_create_process): Update call to windows_add_thread.
8527         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8528         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8529         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8530         call to windows_delete_thread.
8531
8532 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8533
8534         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8535
8536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8537
8538         * symfile.c (find_separate_debug_file): Use canonical path of
8539         sysroot with child_path instead of gdb_sysroot if it is valid.
8540
8541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8542
8543         * symfile.c (find_separate_debug_file): Use child_path to
8544         determine if an object file is under a sysroot.
8545
8546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8547
8548         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8549         unittests/child-path-selftests.c.
8550         * common/pathstuff.c (child_path): New function.
8551         * common/pathstuff.h (child_path): New prototype.
8552         * unittests/child-path-selftests.c: New file.
8553
8554 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8555
8556         * symfile.c (find_separate_debug_file): Look for separate debug
8557         files in debug directories under the sysroot.
8558
8559 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8560
8561         * symtab.h (struct minimal_symbol data_p): New const method.
8562         (struct minimal_symbol text_p): Likewise.
8563         * symtab.c (output_source_filename): Use file name style
8564         to print file name.
8565         (print_symbol_info): Likewise.
8566         (print_msymbol_info): Use address style to print addresses.
8567         Use function name style to print executable text symbols.
8568         (expand_symtab_containing_pc): Use data_p.
8569         (find_pc_sect_compunit_symtab): Likewise.
8570
8571 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8572
8573         * breakpoint.c (describe_other_breakpoints): Use address style
8574         to print addresses.
8575         (say_where): Likewise.
8576
8577 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8578
8579         * ada-typeprint.c (print_func_type): Print function name
8580         style to print function name.
8581         * c-typeprint.c (c_print_type_1): Likewise.
8582
8583 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8584
8585         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8586         for execve.
8587
8588 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8589
8590         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8591         type_stack.
8592
8593 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8594
8595         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8596         TYPE_CODE_REF types.
8597
8598 2019-02-08  Jim Wilson  <jimw@sifive.com>
8599
8600         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8601         (riscv_linux_fregset): New.
8602         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8603
8604 2019-02-07  Tom Tromey  <tom@tromey.com>
8605
8606         * thread.c (thread_cancel_execution_command): Update.
8607         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8608         methods.
8609         (struct thread_fsm_ops): Remove.
8610         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8611         (thread_fsm_should_stop, thread_fsm_return_value)
8612         (thread_fsm_set_finished, thread_fsm_finished_p)
8613         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8614         Don't declare.
8615         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8616         * infrun.c (clear_proceed_status_thread)
8617         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8618         (print_stop_event): Update.
8619         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8620         Add constructor.
8621         (step_command_fsm_ops): Remove.
8622         (new_step_command_fsm): Remove.
8623         (step_1): Update.
8624         (step_command_fsm::should_stop): Rename from
8625         step_command_fsm_should_stop.
8626         (step_command_fsm::clean_up): Rename from
8627         step_command_fsm_clean_up.
8628         (step_command_fsm::do_async_reply_reason): Rename from
8629         step_command_fsm_async_reply_reason.
8630         (struct until_next_fsm): Inherit from thread_fsm.  Add
8631         constructor.
8632         (until_next_fsm_ops): Remove.
8633         (new_until_next_fsm): Remove.
8634         (until_next_fsm::should_stop): Rename from
8635         until_next_fsm_should_stop.
8636         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8637         (until_next_fsm::do_async_reply_reason): Rename from
8638         until_next_fsm_async_reply_reason.
8639         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8640         constructor.  Change type of breakpoint.
8641         (finish_command_fsm_ops): Remove.
8642         (new_finish_command_fsm): Remove.
8643         (finish_command_fsm::should_stop): Rename from
8644         finish_command_fsm_should_stop.
8645         (finish_command_fsm::clean_up): Rename from
8646         finish_command_fsm_clean_up.
8647         (finish_command_fsm::return_value): Rename from
8648         finish_command_fsm_return_value.
8649         (finish_command_fsm::do_async_reply_reason): Rename from
8650         finish_command_fsm_async_reply_reason.
8651         (finish_command): Update.
8652         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8653         Add constructor.
8654         (call_thread_fsm_ops): Remove.
8655         (call_thread_fsm::call_thread_fsm): Rename from
8656         new_call_thread_fsm.
8657         (call_thread_fsm::should_stop): Rename from
8658         call_thread_fsm_should_stop.
8659         (call_thread_fsm::should_notify_stop): Rename from
8660         call_thread_fsm_should_notify_stop.
8661         (run_inferior_call, call_function_by_hand_dummy): Update.
8662         * cli/cli-interp.c (should_print_stop_to_console): Update.
8663         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8664         Add constructor.  Change type of location_breakpoint,
8665         caller_breakpoint.
8666         (until_break_fsm_ops): Remove.
8667         (new_until_break_fsm): Remove.
8668         (until_break_fsm::should_stop): Rename from
8669         until_break_fsm_should_stop.
8670         (until_break_fsm::clean_up): Rename from
8671         until_break_fsm_clean_up.
8672         (until_break_fsm::do_async_reply_reason): Rename from
8673         until_break_fsm_async_reply_reason.
8674         (until_break_command): Update.
8675         * thread-fsm.c: Remove.
8676         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8677
8678 2019-02-07  Tom Tromey  <tom@tromey.com>
8679
8680         * yy-remap.h: Add include guard.
8681         * xtensa-tdep.h: Add include guard.
8682         * xcoffread.h: Rename include guard.
8683         * varobj-iter.h: Add include guard.
8684         * tui/tui.h: Rename include guard.
8685         * tui/tui-winsource.h: Rename include guard.
8686         * tui/tui-wingeneral.h: Rename include guard.
8687         * tui/tui-windata.h: Rename include guard.
8688         * tui/tui-win.h: Rename include guard.
8689         * tui/tui-stack.h: Rename include guard.
8690         * tui/tui-source.h: Rename include guard.
8691         * tui/tui-regs.h: Rename include guard.
8692         * tui/tui-out.h: Rename include guard.
8693         * tui/tui-layout.h: Rename include guard.
8694         * tui/tui-io.h: Rename include guard.
8695         * tui/tui-hooks.h: Rename include guard.
8696         * tui/tui-file.h: Rename include guard.
8697         * tui/tui-disasm.h: Rename include guard.
8698         * tui/tui-data.h: Rename include guard.
8699         * tui/tui-command.h: Rename include guard.
8700         * tic6x-tdep.h: Add include guard.
8701         * target/waitstatus.h: Rename include guard.
8702         * target/wait.h: Rename include guard.
8703         * target/target.h: Rename include guard.
8704         * target/resume.h: Rename include guard.
8705         * target-float.h: Rename include guard.
8706         * stabsread.h: Add include guard.
8707         * rs6000-tdep.h: Add include guard.
8708         * riscv-fbsd-tdep.h: Add include guard.
8709         * regformats/regdef.h: Rename include guard.
8710         * record.h: Rename include guard.
8711         * python/python.h: Rename include guard.
8712         * python/python-internal.h: Rename include guard.
8713         * python/py-stopevent.h: Rename include guard.
8714         * python/py-ref.h: Rename include guard.
8715         * python/py-record.h: Rename include guard.
8716         * python/py-record-full.h: Rename include guard.
8717         * python/py-record-btrace.h: Rename include guard.
8718         * python/py-instruction.h: Rename include guard.
8719         * python/py-events.h: Rename include guard.
8720         * python/py-event.h: Rename include guard.
8721         * procfs.h: Add include guard.
8722         * proc-utils.h: Add include guard.
8723         * p-lang.h: Add include guard.
8724         * or1k-tdep.h: Rename include guard.
8725         * observable.h: Rename include guard.
8726         * nto-tdep.h: Rename include guard.
8727         * nat/x86-linux.h: Rename include guard.
8728         * nat/x86-linux-dregs.h: Rename include guard.
8729         * nat/x86-gcc-cpuid.h: Add include guard.
8730         * nat/x86-dregs.h: Rename include guard.
8731         * nat/x86-cpuid.h: Rename include guard.
8732         * nat/ppc-linux.h: Rename include guard.
8733         * nat/mips-linux-watch.h: Rename include guard.
8734         * nat/linux-waitpid.h: Rename include guard.
8735         * nat/linux-ptrace.h: Rename include guard.
8736         * nat/linux-procfs.h: Rename include guard.
8737         * nat/linux-osdata.h: Rename include guard.
8738         * nat/linux-nat.h: Rename include guard.
8739         * nat/linux-namespaces.h: Rename include guard.
8740         * nat/linux-btrace.h: Rename include guard.
8741         * nat/glibc_thread_db.h: Rename include guard.
8742         * nat/gdb_thread_db.h: Rename include guard.
8743         * nat/gdb_ptrace.h: Rename include guard.
8744         * nat/fork-inferior.h: Rename include guard.
8745         * nat/amd64-linux-siginfo.h: Rename include guard.
8746         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8747         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8748         * nat/aarch64-linux.h: Rename include guard.
8749         * nat/aarch64-linux-hw-point.h: Rename include guard.
8750         * mn10300-tdep.h: Add include guard.
8751         * mips-linux-tdep.h: Add include guard.
8752         * mi/mi-parse.h: Rename include guard.
8753         * mi/mi-out.h: Rename include guard.
8754         * mi/mi-main.h: Rename include guard.
8755         * mi/mi-interp.h: Rename include guard.
8756         * mi/mi-getopt.h: Rename include guard.
8757         * mi/mi-console.h: Rename include guard.
8758         * mi/mi-common.h: Rename include guard.
8759         * mi/mi-cmds.h: Rename include guard.
8760         * mi/mi-cmd-break.h: Rename include guard.
8761         * m2-lang.h: Add include guard.
8762         * location.h: Rename include guard.
8763         * linux-record.h: Rename include guard.
8764         * linux-nat.h: Add include guard.
8765         * linux-fork.h: Add include guard.
8766         * i386-darwin-tdep.h: Rename include guard.
8767         * hppa-linux-offsets.h: Add include guard.
8768         * guile/guile.h: Rename include guard.
8769         * guile/guile-internal.h: Rename include guard.
8770         * gnu-nat.h: Rename include guard.
8771         * gdb-stabs.h: Rename include guard.
8772         * frv-tdep.h: Add include guard.
8773         * f-lang.h: Add include guard.
8774         * event-loop.h: Add include guard.
8775         * darwin-nat.h: Rename include guard.
8776         * cp-abi.h: Rename include guard.
8777         * config/sparc/nm-sol2.h: Rename include guard.
8778         * config/nm-nto.h: Rename include guard.
8779         * config/nm-linux.h: Add include guard.
8780         * config/i386/nm-i386gnu.h: Rename include guard.
8781         * config/djgpp/nl_types.h: Rename include guard.
8782         * config/djgpp/langinfo.h: Rename include guard.
8783         * compile/gcc-cp-plugin.h: Add include guard.
8784         * compile/gcc-c-plugin.h: Add include guard.
8785         * compile/compile.h: Rename include guard.
8786         * compile/compile-object-run.h: Rename include guard.
8787         * compile/compile-object-load.h: Rename include guard.
8788         * compile/compile-internal.h: Rename include guard.
8789         * compile/compile-cplus.h: Rename include guard.
8790         * compile/compile-c.h: Rename include guard.
8791         * common/xml-utils.h: Rename include guard.
8792         * common/x86-xstate.h: Rename include guard.
8793         * common/version.h: Rename include guard.
8794         * common/vec.h: Rename include guard.
8795         * common/tdesc.h: Rename include guard.
8796         * common/selftest.h: Rename include guard.
8797         * common/scoped_restore.h: Rename include guard.
8798         * common/scoped_mmap.h: Rename include guard.
8799         * common/scoped_fd.h: Rename include guard.
8800         * common/safe-iterator.h: Rename include guard.
8801         * common/run-time-clock.h: Rename include guard.
8802         * common/refcounted-object.h: Rename include guard.
8803         * common/queue.h: Rename include guard.
8804         * common/ptid.h: Rename include guard.
8805         * common/print-utils.h: Rename include guard.
8806         * common/preprocessor.h: Rename include guard.
8807         * common/pathstuff.h: Rename include guard.
8808         * common/observable.h: Rename include guard.
8809         * common/netstuff.h: Rename include guard.
8810         * common/job-control.h: Rename include guard.
8811         * common/host-defs.h: Rename include guard.
8812         * common/gdb_wait.h: Rename include guard.
8813         * common/gdb_vecs.h: Rename include guard.
8814         * common/gdb_unlinker.h: Rename include guard.
8815         * common/gdb_unique_ptr.h: Rename include guard.
8816         * common/gdb_tilde_expand.h: Rename include guard.
8817         * common/gdb_sys_time.h: Rename include guard.
8818         * common/gdb_string_view.h: Rename include guard.
8819         * common/gdb_splay_tree.h: Rename include guard.
8820         * common/gdb_setjmp.h: Rename include guard.
8821         * common/gdb_ref_ptr.h: Rename include guard.
8822         * common/gdb_optional.h: Rename include guard.
8823         * common/gdb_locale.h: Rename include guard.
8824         * common/gdb_assert.h: Rename include guard.
8825         * common/filtered-iterator.h: Rename include guard.
8826         * common/filestuff.h: Rename include guard.
8827         * common/fileio.h: Rename include guard.
8828         * common/environ.h: Rename include guard.
8829         * common/common-utils.h: Rename include guard.
8830         * common/common-types.h: Rename include guard.
8831         * common/common-regcache.h: Rename include guard.
8832         * common/common-inferior.h: Rename include guard.
8833         * common/common-gdbthread.h: Rename include guard.
8834         * common/common-exceptions.h: Rename include guard.
8835         * common/common-defs.h: Rename include guard.
8836         * common/common-debug.h: Rename include guard.
8837         * common/cleanups.h: Rename include guard.
8838         * common/buffer.h: Rename include guard.
8839         * common/btrace-common.h: Rename include guard.
8840         * common/break-common.h: Rename include guard.
8841         * cli/cli-utils.h: Rename include guard.
8842         * cli/cli-style.h: Rename include guard.
8843         * cli/cli-setshow.h: Rename include guard.
8844         * cli/cli-script.h: Rename include guard.
8845         * cli/cli-interp.h: Rename include guard.
8846         * cli/cli-decode.h: Rename include guard.
8847         * cli/cli-cmds.h: Rename include guard.
8848         * charset-list.h: Add include guard.
8849         * buildsym-legacy.h: Rename include guard.
8850         * bfin-tdep.h: Add include guard.
8851         * ax.h: Rename include guard.
8852         * arm-linux-tdep.h: Add include guard.
8853         * arm-fbsd-tdep.h: Add include guard.
8854         * arch/xtensa.h: Rename include guard.
8855         * arch/tic6x.h: Add include guard.
8856         * arch/i386.h: Add include guard.
8857         * arch/arm.h: Rename include guard.
8858         * arch/arm-linux.h: Rename include guard.
8859         * arch/arm-get-next-pcs.h: Rename include guard.
8860         * arch/amd64.h: Add include guard.
8861         * arch/aarch64-insn.h: Rename include guard.
8862         * arch-utils.h: Rename include guard.
8863         * annotate.h: Add include guard.
8864         * amd64-darwin-tdep.h: Rename include guard.
8865         * aarch64-linux-tdep.h: Add include guard.
8866         * aarch64-fbsd-tdep.h: Add include guard.
8867         * aarch32-linux-nat.h: Add include guard.
8868
8869 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8870
8871         * macrotab.c (macro_define_internal): New function that
8872         factorizes macro_define_object_internal and macro_define_function
8873         code.
8874         (macro_define_object_internal): Use macro_define_internal.
8875         (macro_define_function): Likewise.
8876
8877 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8878
8879         * macrocmd.c (extract_identifier): Return
8880         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8881         callers.
8882
8883 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8884
8885         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8886
8887 2019-02-05  Tom Tromey  <tom@tromey.com>
8888
8889         * target.c (target_stack::unpush): Move assertion earlier.
8890
8891 2019-01-30  Tom Tromey  <tom@tromey.com>
8892
8893         PR python/23615:
8894         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8895         (gdbpy_parse_and_eval): Likewise.
8896         * python/python-internal.h (gdbpy_allow_threads): New class.
8897
8898 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8899
8900         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8901         (aarch64_fbsd_fpregmap): Move earlier.
8902         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8903         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8904         instead of individual calls to trad_frame_set_reg_addr.
8905         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8906         earlier.
8907         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8908         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8909         instead of individual calls to trad_frame_set_reg_addr.
8910
8911 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8912
8913         * CONTRIBUTE: Replace contribution list with wiki link.
8914
8915 2019-01-25  Tom Tromey  <tom@tromey.com>
8916
8917         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8918
8919 2019-01-25  Tom Tromey  <tom@tromey.com>
8920
8921         * xtensa-linux-nat.c: Fix common/ includes.
8922         * xml-support.h: Fix common/ includes.
8923         * xml-support.c: Fix common/ includes.
8924         * x86-linux-nat.c: Fix common/ includes.
8925         * windows-nat.c: Fix common/ includes.
8926         * varobj.h: Fix common/ includes.
8927         * varobj.c: Fix common/ includes.
8928         * value.c: Fix common/ includes.
8929         * valops.c: Fix common/ includes.
8930         * utils.c: Fix common/ includes.
8931         * unittests/xml-utils-selftests.c: Fix common/ includes.
8932         * unittests/utils-selftests.c: Fix common/ includes.
8933         * unittests/unpack-selftests.c: Fix common/ includes.
8934         * unittests/tracepoint-selftests.c: Fix common/ includes.
8935         * unittests/style-selftests.c: Fix common/ includes.
8936         * unittests/string_view-selftests.c: Fix common/ includes.
8937         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8938         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8939         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8940         * unittests/rsp-low-selftests.c: Fix common/ includes.
8941         * unittests/parse-connection-spec-selftests.c: Fix common/
8942         includes.
8943         * unittests/optional-selftests.c: Fix common/ includes.
8944         * unittests/offset-type-selftests.c: Fix common/ includes.
8945         * unittests/observable-selftests.c: Fix common/ includes.
8946         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8947         * unittests/memrange-selftests.c: Fix common/ includes.
8948         * unittests/memory-map-selftests.c: Fix common/ includes.
8949         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8950         * unittests/function-view-selftests.c: Fix common/ includes.
8951         * unittests/environ-selftests.c: Fix common/ includes.
8952         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8953         * unittests/common-utils-selftests.c: Fix common/ includes.
8954         * unittests/cli-utils-selftests.c: Fix common/ includes.
8955         * unittests/array-view-selftests.c: Fix common/ includes.
8956         * ui-file.c: Fix common/ includes.
8957         * tui/tui-io.c: Fix common/ includes.
8958         * tracepoint.h: Fix common/ includes.
8959         * tracepoint.c: Fix common/ includes.
8960         * tracefile-tfile.c: Fix common/ includes.
8961         * top.h: Fix common/ includes.
8962         * top.c: Fix common/ includes.
8963         * thread.c: Fix common/ includes.
8964         * target/waitstatus.h: Fix common/ includes.
8965         * target/waitstatus.c: Fix common/ includes.
8966         * target.h: Fix common/ includes.
8967         * target.c: Fix common/ includes.
8968         * target-memory.c: Fix common/ includes.
8969         * target-descriptions.c: Fix common/ includes.
8970         * symtab.h: Fix common/ includes.
8971         * symfile.c: Fix common/ includes.
8972         * stap-probe.c: Fix common/ includes.
8973         * spu-linux-nat.c: Fix common/ includes.
8974         * sparc-nat.c: Fix common/ includes.
8975         * source.c: Fix common/ includes.
8976         * solib.c: Fix common/ includes.
8977         * solib-target.c: Fix common/ includes.
8978         * ser-unix.c: Fix common/ includes.
8979         * ser-tcp.c: Fix common/ includes.
8980         * ser-pipe.c: Fix common/ includes.
8981         * ser-base.c: Fix common/ includes.
8982         * selftest-arch.c: Fix common/ includes.
8983         * s12z-tdep.c: Fix common/ includes.
8984         * rust-exp.y: Fix common/ includes.
8985         * rs6000-aix-tdep.c: Fix common/ includes.
8986         * riscv-tdep.c: Fix common/ includes.
8987         * remote.c: Fix common/ includes.
8988         * remote-notif.h: Fix common/ includes.
8989         * remote-fileio.h: Fix common/ includes.
8990         * remote-fileio.c: Fix common/ includes.
8991         * regcache.h: Fix common/ includes.
8992         * regcache.c: Fix common/ includes.
8993         * record-btrace.c: Fix common/ includes.
8994         * python/python.c: Fix common/ includes.
8995         * python/py-type.c: Fix common/ includes.
8996         * python/py-inferior.c: Fix common/ includes.
8997         * progspace.h: Fix common/ includes.
8998         * producer.c: Fix common/ includes.
8999         * procfs.c: Fix common/ includes.
9000         * proc-api.c: Fix common/ includes.
9001         * printcmd.c: Fix common/ includes.
9002         * ppc-linux-nat.c: Fix common/ includes.
9003         * parser-defs.h: Fix common/ includes.
9004         * osdata.c: Fix common/ includes.
9005         * obsd-nat.c: Fix common/ includes.
9006         * nat/x86-linux.c: Fix common/ includes.
9007         * nat/x86-linux-dregs.c: Fix common/ includes.
9008         * nat/x86-dregs.h: Fix common/ includes.
9009         * nat/x86-dregs.c: Fix common/ includes.
9010         * nat/ppc-linux.c: Fix common/ includes.
9011         * nat/mips-linux-watch.h: Fix common/ includes.
9012         * nat/mips-linux-watch.c: Fix common/ includes.
9013         * nat/linux-waitpid.c: Fix common/ includes.
9014         * nat/linux-ptrace.h: Fix common/ includes.
9015         * nat/linux-ptrace.c: Fix common/ includes.
9016         * nat/linux-procfs.c: Fix common/ includes.
9017         * nat/linux-personality.c: Fix common/ includes.
9018         * nat/linux-osdata.c: Fix common/ includes.
9019         * nat/linux-namespaces.c: Fix common/ includes.
9020         * nat/linux-btrace.h: Fix common/ includes.
9021         * nat/linux-btrace.c: Fix common/ includes.
9022         * nat/fork-inferior.c: Fix common/ includes.
9023         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9024         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9025         * nat/aarch64-linux.c: Fix common/ includes.
9026         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9027         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9028         * namespace.h: Fix common/ includes.
9029         * mips-linux-tdep.c: Fix common/ includes.
9030         * minsyms.c: Fix common/ includes.
9031         * mi/mi-parse.h: Fix common/ includes.
9032         * mi/mi-main.c: Fix common/ includes.
9033         * mi/mi-cmd-env.c: Fix common/ includes.
9034         * memrange.h: Fix common/ includes.
9035         * memattr.c: Fix common/ includes.
9036         * maint.h: Fix common/ includes.
9037         * maint.c: Fix common/ includes.
9038         * main.c: Fix common/ includes.
9039         * machoread.c: Fix common/ includes.
9040         * location.c: Fix common/ includes.
9041         * linux-thread-db.c: Fix common/ includes.
9042         * linux-nat.c: Fix common/ includes.
9043         * linux-fork.c: Fix common/ includes.
9044         * inline-frame.c: Fix common/ includes.
9045         * infrun.c: Fix common/ includes.
9046         * inflow.c: Fix common/ includes.
9047         * inferior.h: Fix common/ includes.
9048         * inferior.c: Fix common/ includes.
9049         * infcmd.c: Fix common/ includes.
9050         * inf-ptrace.c: Fix common/ includes.
9051         * inf-child.c: Fix common/ includes.
9052         * ia64-linux-nat.c: Fix common/ includes.
9053         * i387-tdep.c: Fix common/ includes.
9054         * i386-tdep.c: Fix common/ includes.
9055         * i386-linux-tdep.c: Fix common/ includes.
9056         * i386-linux-nat.c: Fix common/ includes.
9057         * i386-go32-tdep.c: Fix common/ includes.
9058         * i386-fbsd-tdep.c: Fix common/ includes.
9059         * i386-fbsd-nat.c: Fix common/ includes.
9060         * guile/scm-type.c: Fix common/ includes.
9061         * guile/guile.c: Fix common/ includes.
9062         * go32-nat.c: Fix common/ includes.
9063         * gnu-nat.c: Fix common/ includes.
9064         * gdbthread.h: Fix common/ includes.
9065         * gdbarch-selftests.c: Fix common/ includes.
9066         * gdb_usleep.c: Fix common/ includes.
9067         * gdb_select.h: Fix common/ includes.
9068         * gdb_bfd.c: Fix common/ includes.
9069         * gcore.c: Fix common/ includes.
9070         * fork-child.c: Fix common/ includes.
9071         * findvar.c: Fix common/ includes.
9072         * fbsd-nat.c: Fix common/ includes.
9073         * event-top.c: Fix common/ includes.
9074         * event-loop.c: Fix common/ includes.
9075         * dwarf2read.c: Fix common/ includes.
9076         * dwarf2loc.c: Fix common/ includes.
9077         * dwarf2-frame.c: Fix common/ includes.
9078         * dwarf-index-cache.c: Fix common/ includes.
9079         * dtrace-probe.c: Fix common/ includes.
9080         * disasm-selftests.c: Fix common/ includes.
9081         * defs.h: Fix common/ includes.
9082         * csky-tdep.c: Fix common/ includes.
9083         * cp-valprint.c: Fix common/ includes.
9084         * cp-support.h: Fix common/ includes.
9085         * cp-support.c: Fix common/ includes.
9086         * corelow.c: Fix common/ includes.
9087         * completer.h: Fix common/ includes.
9088         * completer.c: Fix common/ includes.
9089         * compile/compile.c: Fix common/ includes.
9090         * compile/compile-loc2c.c: Fix common/ includes.
9091         * compile/compile-cplus-types.c: Fix common/ includes.
9092         * compile/compile-cplus-symbols.c: Fix common/ includes.
9093         * command.h: Fix common/ includes.
9094         * cli/cli-dump.c: Fix common/ includes.
9095         * cli/cli-cmds.c: Fix common/ includes.
9096         * charset.c: Fix common/ includes.
9097         * build-id.c: Fix common/ includes.
9098         * btrace.h: Fix common/ includes.
9099         * btrace.c: Fix common/ includes.
9100         * breakpoint.h: Fix common/ includes.
9101         * breakpoint.c: Fix common/ includes.
9102         * ax.h:
9103         (enum agent_op): Fix common/ includes.
9104         * ax-general.c (struct aop_map): Fix common/ includes.
9105         * ax-gdb.c: Fix common/ includes.
9106         * auxv.c: Fix common/ includes.
9107         * auto-load.c: Fix common/ includes.
9108         * arm-tdep.c: Fix common/ includes.
9109         * arch/riscv.c: Fix common/ includes.
9110         * arch/ppc-linux-common.c: Fix common/ includes.
9111         * arch/i386.c: Fix common/ includes.
9112         * arch/arm.c: Fix common/ includes.
9113         * arch/arm-linux.c: Fix common/ includes.
9114         * arch/arm-get-next-pcs.c: Fix common/ includes.
9115         * arch/amd64.c: Fix common/ includes.
9116         * arch/aarch64.c: Fix common/ includes.
9117         * arch/aarch64-insn.c: Fix common/ includes.
9118         * arch-utils.c: Fix common/ includes.
9119         * amd64-windows-tdep.c: Fix common/ includes.
9120         * amd64-tdep.c: Fix common/ includes.
9121         * amd64-sol2-tdep.c: Fix common/ includes.
9122         * amd64-obsd-tdep.c: Fix common/ includes.
9123         * amd64-nbsd-tdep.c: Fix common/ includes.
9124         * amd64-linux-tdep.c: Fix common/ includes.
9125         * amd64-linux-nat.c: Fix common/ includes.
9126         * amd64-fbsd-tdep.c: Fix common/ includes.
9127         * amd64-fbsd-nat.c: Fix common/ includes.
9128         * amd64-dicos-tdep.c: Fix common/ includes.
9129         * amd64-darwin-tdep.c: Fix common/ includes.
9130         * agent.c: Fix common/ includes.
9131         * ada-lang.h: Fix common/ includes.
9132         * ada-lang.c: Fix common/ includes.
9133         * aarch64-tdep.c: Fix common/ includes.
9134
9135 2019-01-25  Tom Tromey  <tom@tromey.com>
9136
9137         * common/create-version.sh: Use common/version.h.
9138
9139 2019-01-24  Pedro Alves  <palves@redhat.com>
9140
9141         * infrun.c (signal_stop, signal_print, signal_program)
9142         (signal_catch, signal_pass): Now arrays instead of pointers.
9143         (update_signals_program_target, do_target_resume)
9144         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9145         * linux-nat.c (linux_nat_target::pass_signals)
9146         (linux_nat_target::create_inferior, linux_nat_target::attach):
9147         Adjust.
9148         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9149         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9150         * procfs.c (procfs_target::pass_signals): Adjust.
9151         * record-full.c (record_full_target::resume): Adjust.
9152         * remote.c (remote_target::pass_signals)
9153         (remote_target::program_signals): Adjust.
9154         * target-debug.h (target_debug_print_signals): Now takes a
9155         gdb::array_view as parameter.  Adjust.
9156         * target.h (target_ops) <pass_signals, program_signals>: Replace
9157         pointer and length parameters with gdb::array_view.
9158         (target_pass_signals, target_program_signals): Likewise.
9159         * target-delegates.c: Regenerate.
9160
9161 2019-01-24  Pedro Alves  <palves@redhat.com>
9162
9163         * common/forward-scope-exit.h
9164         (forward_scope_exit::forward_scope_exit): Pass arguments to
9165         m_bind_function directly, instead of creating a std::bind and
9166         copying that.
9167
9168 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9169
9170         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9171         for static members.
9172         (pass_in_v_vfp_candidate): Likewise.
9173
9174 2019-01-23  Tom Tromey  <tom@tromey.com>
9175             Pedro Alves  <palves@redhat.com>
9176
9177         * regcache.c (class regcache_invalidator): Remove.
9178         (regcache::raw_write): Use make_scope_exit.
9179
9180 2019-01-23  Tom Tromey  <tom@tromey.com>
9181
9182         * ui-out.h (class ui_out_emit_type): Update comment.
9183
9184 2019-01-23  Tom Tromey  <tom@tromey.com>
9185
9186         * infrun.c (fetch_inferior_event): Update comment.
9187
9188 2019-01-23  Tom Tromey  <tom@tromey.com>
9189             Pedro Alves  <palves@redhat.com>
9190
9191         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9192         parameter.
9193         (fetch_inferior_event): Use SCOPE_EXIT.
9194
9195
9196 2019-01-23  Tom Tromey  <tom@tromey.com>
9197             Pedro Alves  <palves@redhat.com>
9198
9199         * infrun.c (disable_thread_events): Delete.
9200         (stop_all_threads): Use SCOPE_EXIT.
9201
9202 2019-01-23  Tom Tromey  <tom@tromey.com>
9203             Pedro Alves  <palves@redhat.com>
9204
9205         * symfile.c: Include forward-scope-exit.h.
9206         (clear_symtab_users_cleanup): Replace forward declaration with
9207         a FORWARD_SCOPE_EXIT.
9208         (syms_from_objfile_1): Use the forward_scope_exit and
9209         gdb::optional instead of cleanup_function.
9210         (reread_symbols): Use the forward_scope_exit instead of
9211         cleanup_function.
9212         (clear_symtab_users_cleanup): Remove function.
9213
9214 2019-01-23  Tom Tromey  <tom@tromey.com>
9215             Pedro Alves  <palves@redhat.com>
9216
9217         * linux-nat.c: Include scope-exit.h.
9218         (cleanup_target_stop): Remove.
9219         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9220         SCOPE_EXIT.
9221
9222 2019-01-23  Tom Tromey  <tom@tromey.com>
9223             Pedro Alves  <palves@redhat.com>
9224
9225         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9226         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9227
9228 2019-01-23  Tom Tromey  <tom@tromey.com>
9229             Andrew Burgess  <andrew.burgess@embecosm.com>
9230             Pedro Alves  <palves@redhat.com>
9231
9232         * infrun.c (fetch_inferior_event): Use scope_exit.
9233         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9234         * top.c (execute_command): Use scope_exit.
9235         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9236         * utils.c (do_bpstat_clear_actions_cleanup)
9237         (make_bpstat_clear_actions_cleanup): Remove.
9238
9239 2019-01-23  Tom Tromey  <tom@tromey.com>
9240             Pedro Alves  <palves@redhat.com>
9241
9242         * infrun.c: Include "common/scope-exit.h"
9243         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9244         (wait_for_inferior): Use SCOPE_EXIT.
9245         (fetch_inferior_event): Use scope_exit.
9246
9247 2019-01-23  Tom Tromey  <tom@tromey.com>
9248             Pedro Alves  <palves@redhat.com>
9249
9250         * breakpoint.c (create_breakpoint): Remove cleanup.
9251
9252 2019-01-23  Tom Tromey  <tom@tromey.com>
9253             Andrew Burgess  <andrew.burgess@embecosm.com>
9254             Pedro Alves  <palves@redhat.com>
9255
9256 2019-01-23  Pedro Alves  <palves@redhat.com>
9257
9258         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9259
9260 2019-01-23  Pedro Alves  <palves@redhat.com>
9261             Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * gdbthread.h: Include "common/forward-scope-exit.h".
9264         (scoped_finish_thread_state): Redefine custom class in terms of
9265         forward_scope_exit.
9266
9267 2019-01-23  Pedro Alves  <palves@redhat.com>
9268             Andrew Burgess  <andrew.burgess@embecosm.com>
9269
9270         * common/forward-scope-exit.h: New file.
9271
9272 2019-01-23  Pedro Alves  <palves@redhat.com>
9273             Andrew Burgess  <andrew.burgess@embecosm.com>
9274             Tom Tromey  <tom@tromey.com>
9275
9276         * common/scope-exit.h: New file.
9277
9278 2019-01-23  Pedro Alves  <palves@redhat.com>
9279
9280         * common/preprocessor.h (ESC): Rename to ...
9281         (ESC_PARENS): ... this.
9282         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9283         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9284
9285 2019-01-23  Tom Tromey  <tom@tromey.com>
9286
9287         * language.h (class scoped_switch_to_sym_language_if_auto):
9288         Initialize m_lang in both cases.
9289
9290 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9291
9292         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9293         with XCNEW.
9294
9295 2019-01-22  Tom Tromey  <tom@tromey.com>
9296
9297         * corelow.c: Do not include sys/file.h.
9298
9299 2019-01-22  Tom Tromey  <tom@tromey.com>
9300
9301         * tui/tui-wingeneral.h: Include gdb_curses.h.
9302
9303 2019-01-22  Tom Tromey  <tom@tromey.com>
9304
9305         * source-cache.h (class source_cache) <get_source_lines,
9306         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9307
9308 2019-01-22  Tom Tromey  <tom@tromey.com>
9309
9310         * remote-fileio.h (struct remote_target): Declare.
9311
9312 2019-01-22  Tom Tromey  <tom@tromey.com>
9313
9314         * python/py-arch.c: Do not include py-ref.h.
9315         * python/py-bpevent.c: Do not include py-ref.h.
9316         * python/py-cmd.c: Do not include py-ref.h.
9317         * python/py-continueevent.c: Do not include py-ref.h.
9318         * python/py-event.h: Do not include py-ref.h.
9319         * python/py-evtregistry.c: Do not include py-ref.h.
9320         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9321         * python/py-frame.c: Do not include py-ref.h.
9322         * python/py-framefilter.c: Do not include py-ref.h.
9323         * python/py-function.c: Do not include py-ref.h.
9324         * python/py-infevents.c: Do not include py-ref.h.
9325         * python/py-linetable.c: Do not include py-ref.h.
9326         * python/py-objfile.c: Do not include py-ref.h.
9327         * python/py-param.c: Do not include py-ref.h.
9328         * python/py-prettyprint.c: Do not include py-ref.h.
9329         * python/py-progspace.c: Do not include py-ref.h.
9330         * python/py-symbol.c: Do not include py-ref.h.
9331         * python/py-symtab.c: Do not include py-ref.h.
9332         * python/py-type.c: Do not include py-ref.h.
9333         * python/py-unwind.c: Do not include py-ref.h.
9334         * python/py-utils.c: Do not include py-ref.h.
9335         * python/py-value.c: Do not include py-ref.h.
9336         * python/py-varobj.c: Do not include py-ref.h.
9337         * python/py-xmethods.c: Do not include py-ref.h.
9338         * python/python.c: Do not include py-ref.h.
9339         * varobj.c: Do not include py-ref.h.
9340
9341 2019-01-22  Tom Tromey  <tom@tromey.com>
9342
9343         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9344         keyword for bcache.
9345
9346 2019-01-22  Tom Tromey  <tom@tromey.com>
9347
9348         * compile/compile-cplus-types.c: Remove a comment by #include.
9349
9350 2019-01-22  Tom Tromey  <tom@tromey.com>
9351
9352         * compile/gcc-c-plugin.h: Include compile-internal.h.
9353
9354 2019-01-22  Tom Tromey  <tom@tromey.com>
9355
9356         * stabsread.c (EXTERN): Do not define.
9357         (symnum, next_symbol_text_func, processing_gcc_compilation)
9358         (within_function, global_sym_chain, global_stabs)
9359         (previous_stab_code, this_object_header_files)
9360         (n_this_object_header_files)
9361         (n_allocated_this_object_header_files): Define.
9362         * stabsread.h (EXTERN): Never define.  Use "extern".
9363
9364 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9365
9366         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9367         history_value.
9368
9369 2019-01-21  Tom Tromey  <tom@tromey.com>
9370
9371         * ui-out.c: Fix includes.
9372         * tui/tui-source.c: Fix includes.
9373         * target.c: Fix includes.
9374         * remote.c: Fix includes.
9375         * regcache.c: Fix includes.
9376         * python/py-block.c: Fix includes.
9377         * printcmd.c: Fix includes.
9378         * or1k-tdep.c: Fix includes.
9379         * mi/mi-main.c: Fix includes.
9380         * m32r-tdep.c: Fix includes.
9381         * csky-tdep.c: Fix includes.
9382         * compile/compile-cplus-types.c: Fix includes.
9383         * cli/cli-interp.c: Fix includes.
9384
9385 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9386
9387         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9388         for padding.
9389
9390 2019-01-16  Tom Tromey  <tom@tromey.com>
9391
9392         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9393         earlier.
9394         (struct objfile) <msymbols_range>: Move from top level.
9395         <msymbols>: New method.
9396         (class objfile_msymbols): Remove.
9397         * symtab.c (default_collect_symbol_completion_matches_break_on):
9398         Update.
9399         * symmisc.c (dump_msymbols): Update.
9400         * stabsread.c (scan_file_globals): Update.
9401         * objc-lang.c (info_selectors_command, info_classes_command)
9402         (find_methods): Update.
9403         * minsyms.c (find_solib_trampoline_target): Update.
9404         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9405         * coffread.c (coff_symfile_read): Update.
9406         * ada-lang.c (ada_lookup_simple_minsym)
9407         (ada_collect_symbol_completion_matches): Update.
9408
9409 2019-01-16  Tom Tromey  <tom@tromey.com>
9410
9411         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9412         type.  Remove no-argument constructor.
9413         <iterator::operator++>: Simplify.
9414         <begin>: Update.
9415         <end>: Use minimal_symbol_count.
9416
9417 2019-01-16  Tom Tromey  <tom@tromey.com>
9418
9419         * objfiles.h (struct objfile) <psymtabs>: New method.
9420         (class objfile_psymtabs): Remove.
9421         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9422         typedef.
9423         <range>: New method.
9424         (require_partial_symbols): Change return type.
9425         * psymtab.c (require_partial_symbols)
9426         (psym_expand_symtabs_matching): Update.
9427         * mdebugread.c (parse_partial_symbols): Update.
9428         * dbxread.c (dbx_end_psymtab): Update.
9429
9430 2019-01-15  Tom Tromey  <tom@tromey.com>
9431
9432         * symtab.c (lookup_objfile_from_block)
9433         (lookup_symbol_in_objfile_symtabs)
9434         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9435         (find_line_symtab, info_sources_command)
9436         (default_collect_symbol_completion_matches_break_on)
9437         (make_source_files_completion_list): Update.
9438         * symmisc.c (print_objfile_statistics, dump_objfile)
9439         (maintenance_print_symbols, maintenance_info_symtabs)
9440         (maintenance_check_symtabs, maintenance_info_line_tables):
9441         Update.
9442         * source.c (select_source_symtab)
9443         (forget_cached_source_info_for_objfile): Update.
9444         * objfiles.h (class objfile_compunits): Remove.
9445         (struct objfile) <compunits_range>: New typedef.
9446         (compunits): New method.
9447         * objfiles.c (objfile_relocate1): Update.
9448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9449         * maint.c (count_symtabs_and_blocks): Update.
9450         * linespec.c (iterate_over_all_matching_symtabs): Update.
9451         * cp-support.c (add_symbol_overload_list_qualified): Update.
9452         * coffread.c (coff_symtab_read): Update.
9453         * ada-lang.c (add_nonlocal_symbols)
9454         (ada_collect_symbol_completion_matches)
9455         (ada_add_global_exceptions): Update.
9456
9457 2019-01-15  Tom Tromey  <tom@tromey.com>
9458
9459         * progspace.h (program_space) <objfiles_safe_range>: New
9460         typedef.
9461         <objfiles_safe>: New method.
9462         * objfiles.h (class all_objfiles_safe): Remove.
9463         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9464         * jit.c (jit_inferior_exit_hook): Update.
9465
9466 2019-01-17  Tom Tromey  <tom@tromey.com>
9467
9468         * progspace.h (program_space) <objfiles_range>: New typedef.
9469         <objfiles>: New method.
9470         <objfiles_head>: Rename from objfiles.
9471         (object_files): Update.
9472         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9473         * guile/scm-pretty-print.c
9474         (ppscm_find_pretty_printer_from_objfiles): Update.
9475         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9476         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9477         Update.
9478         * python/py-progspace.c (pspy_get_objfiles): Update.
9479         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9480         Update.
9481         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9482         (objfpy_lookup_objfile_by_build_id): Update.
9483         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9484         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9485         Update.
9486         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9487         (expand_symtab_containing_pc, lookup_objfile_from_block)
9488         (lookup_static_symbol, basic_lookup_transparent_type)
9489         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9490         (find_line_symtab, info_sources_command)
9491         (default_collect_symbol_completion_matches_break_on)
9492         (make_source_files_completion_list, find_main_name): Update.
9493         * symmisc.c (print_symbol_bcache_statistics)
9494         (print_objfile_statistics, maintenance_print_symbols)
9495         (maintenance_print_msymbols, maintenance_print_objfiles)
9496         (maintenance_info_symtabs, maintenance_check_symtabs)
9497         (maintenance_expand_symtabs, maintenance_info_line_tables):
9498         Update.
9499         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9500         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9501         (map_overlay_command, unmap_overlay_command)
9502         (simple_overlay_update, expand_symtabs_matching)
9503         (map_symbol_filenames): Update.
9504         * symfile-debug.c (set_debug_symfile): Update.
9505         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9506         Update.
9507         * source.c (select_source_symtab, forget_cached_source_info):
9508         Update.
9509         * solib.c (solib_read_symbols): Update.
9510         * solib-spu.c (append_ocl_sos): Update.
9511         * psymtab.c (maintenance_print_psymbols)
9512         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9513         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9514         * printcmd.c (info_symbol_command): Update.
9515         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9516         Update.
9517         * objfiles.h (class all_objfiles): Remove.
9518         * objfiles.c (have_partial_symbols, have_full_symbols)
9519         (have_minimal_symbols, qsort_cmp, update_section_map)
9520         (shared_objfile_contains_address_p)
9521         (default_iterate_over_objfiles_in_search_order): Update.
9522         * objc-lang.c (info_selectors_command, info_classes_command)
9523         (find_methods): Update.
9524         * minsyms.c (find_solib_trampoline_target): Update.
9525         * maint.c (maintenance_info_sections)
9526         (maintenance_translate_address, count_symtabs_and_blocks):
9527         Update.
9528         * main.c (captured_main_1): Update.
9529         * linux-thread-db.c (try_thread_db_load_from_pdir)
9530         (has_libpthread): Update.
9531         * linespec.c (iterate_over_all_matching_symtabs)
9532         (search_minsyms_for_name): Update.
9533         * jit.c (jit_find_objf_with_entry_addr): Update.
9534         * hppa-tdep.c (find_unwind_entry)
9535         (hppa_lookup_stub_minimal_symbol): Update.
9536         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9537         Update.
9538         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9539         (elf_gnu_ifunc_resolve_by_got): Update.
9540         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9541         * dwarf-index-write.c (save_gdb_index_command): Update.
9542         * cp-support.c (add_symbol_overload_list_qualified): Update.
9543         * breakpoint.c (create_overlay_event_breakpoint)
9544         (create_longjmp_master_breakpoint)
9545         (create_std_terminate_master_breakpoint)
9546         (create_exception_master_breakpoint): Update.
9547         * blockframe.c (find_pc_partial_function): Update.
9548         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9549         (ada_collect_symbol_completion_matches)
9550         (ada_add_global_exceptions): Update.
9551
9552 2019-01-17  Tom Tromey  <tom@tromey.com>
9553
9554         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9555         declare VEC.
9556         (solib_target_parse_libraries): Change return type.
9557         (library_list_start_segment, library_list_start_section)
9558         (library_list_end_library, library_list_start_library); Update.
9559         (solib_target_free_library_list): Remove.
9560         (solib_target_parse_libraries): Remove cleanup.  Change return
9561         type.
9562         (solib_target_current_sos): Update.
9563
9564 2019-01-17  Tom Tromey  <tromey@bapiya>
9565
9566         * valprint.c: Replace "the the" with "the".
9567         * symtab.c: Replace "the the" with "the".
9568         * solib.c: Replace "the the" with "the".
9569         * solib-dsbt.c: Replace "the the" with "the".
9570         * linespec.c: Replace "the the" with "the".
9571         * dwarf2loc.h: Replace "the the" with "the".
9572         * amd64-windows-tdep.c: Replace "the the" with "the".
9573         * aarch64-tdep.c: Replace "the the" with "the".
9574
9575 2019-01-16  Keith Seitz  <keiths@redhat.com>
9576
9577         PR gdb/23773
9578         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9579         <builder>: Rename to ..
9580         <m_builder>: ... this and make private.
9581         (dwarf2_cu::get_builder): New method.  Change all users of
9582         `builder' to use this method.
9583         (dwarf2_start_symtab): Move to ...
9584         (dwarf2_cu::start_symtab): ... here.  Update all callers
9585         (setup_type_unit_groups): Move to ...
9586         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9587         callers.
9588         (dwarf2_cu::reset_builder): New method.
9589         (process_full_compunit, process_full_type_unit): Use
9590         dwarf2_cu::reset_builder.
9591         (follow_die_offset): Record the ancestor CU if it is different
9592         from the followed DIE's CU.
9593         (follow_die_sig_1): Likewise.
9594
9595 2019-01-15  Tom Tromey  <tom@tromey.com>
9596
9597         * remote.c (class remote_state) <buf>: Now a char_vector.
9598         <buf_size>: Remove.
9599         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9600         parameter.
9601         (remote_target::getpkt_or_notif_sane_1)
9602         (remote_target::getpkt_sane)
9603         (remote_target::getpkt_or_notif_sane): Likewise.
9604         (class remote_target) <putpkt>: New overload.
9605         (remote_target::read_frame): Change type of "buf_p".  Remove
9606         sizeof_p parameter.
9607         (packet_ok): New overload.
9608         (packet_check_result): New overload.
9609         Update all uses.
9610
9611 2019-01-14  Tom Tromey  <tom@tromey.com>
9612
9613         * remote-notif.c (handle_notification, remote_notif_ack)
9614         (remote_notif_parse): Make "buf" const.
9615         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9616         const.
9617         (remote_notif_parse, remote_notif_ack, handle_notification):
9618         Likewise.
9619         * remote.c (remote_notif_stop_parse): Make "buf" const.
9620         (remote_target::remote_parse_stop_reply): Make "buf" const.
9621         (remote_notif_stop_ack): Make "buf" const.
9622
9623 2019-01-14  Tom Tromey  <tom@tromey.com>
9624
9625         * remote.c (remote_console_output): Make parameter const.
9626
9627 2019-01-14  Tom Tromey  <tom@tromey.com>
9628
9629         * target-debug.h (target_debug_print_signals): Constify.
9630         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9631         * procfs.c (procfs_target::pass_signals): Update.
9632         * linux-nat.c (linux_nat_target::pass_signals): Update.
9633         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9634         * target-delegates.c: Rebuild.
9635         * remote.c (remote_target::program_signals): Update.
9636         (remote_target::pass_signals): Update.
9637         * target.c (target_pass_signals): Constify argument.
9638         (target_program_signals): Likewise.
9639         * target.h (struct target_ops) <pass_signals, program_signals>:
9640         Constify argument.
9641         (target_pass_signals, target_program_signals): Constify argument.
9642
9643 2019-01-14  Tom Tromey  <tom@tromey.com>
9644
9645         PR tui/28819:
9646         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9647
9648 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9649
9650         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9651         field.
9652         * rs6000-tdep.c: Include reggroups.h.
9653         (IS_V_ALIAS_PSEUDOREG): Define.
9654         (rs6000_register_name): Return names for the "vX" aliases.
9655         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9656         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9657         aliases.  Call default_register_reggroup_p for all other
9658         pseudo-registers.
9659         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9660         New functions.
9661         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9662         Handle "vX" aliases.
9663         (v_alias_pseudo_register_collect): New function.
9664         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9665         (rs6000_gdbarch_init): Initialize "vX" aliases as
9666         pseudo-registers.  Restore registration of
9667         rs6000_pseudo_register_reggroup_p with
9668         set_tdesc_pseudo_register_reggroup_p.
9669
9670 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9671
9672         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9673         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9674         set_gdbarch_num_pseudo_regs.
9675
9676 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9677
9678         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9679         Remove arg prefixname, add do_set and do_show.
9680         Add member functions set_list and show_list.
9681         * cli/cli-style.c (class cli_style_option): Update accordingly.
9682         (style_set_list): Move to file scope.
9683         (style_show_list): Likewise.
9684         (set_style): Call help_list.
9685         (show_style): Call cmd_show_list.
9686         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9687         Update to use the new macro.
9688
9689 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9690
9691         * ada-lang.c (_initialize_ada_language): Expand the help text
9692         for the "catch exception" command.
9693
9694 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9695
9696         * symtab.c (matching_obj_sections): Initialize obj,
9697         declare it closer to its usage.
9698
9699 2019-01-10  Tom Tromey  <tom@tromey.com>
9700
9701         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9702         (basic_inf_threads_range): Remove.
9703         (inf_threads_range, inf_non_exited_threads_range)
9704         (safe_inf_threads_range): Use next_adapter.
9705
9706 2019-01-10  Keith Seitz  <keiths@redhat.com>
9707
9708         PR gdb/23712
9709         PR symtab/23010
9710         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9711         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9712
9713 2019-01-10  Keith Seitz  <keiths@redhat.com>
9714
9715         PR gdb/23712
9716         PR symtab/23010
9717         * dictionary.c (pending_to_vector): Remove.
9718         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9719         Remove _1 suffix, replacing functions of the same name.  Update
9720         all callers.
9721         (dict_create_hashed, dict_create_hashed_expandable)
9722         (dict_create_linear, dict_create_linear_expandable, dict_free)
9723         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9724         Make functions static.
9725
9726 2019-01-10  Keith Seitz  <keiths@redhat.com>
9727
9728         PR gdb/23712
9729         PR symtab/23010
9730         * dictionary.h (struct dictionary): Replace declaration with
9731         multidictionary.
9732         (dict_create_hashed, dict_create_hashed_expandable)
9733         (dict_create_linear, dict_create_linear_expandable)
9734         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9735         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9736         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9737         taking multidictionary argument.
9738         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9739         * block.h (struct block) <dict>: Change to multidictionary
9740         and rename `multidict'.
9741         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9742         symmisc.c: Update all dictionary references to multidictionary.
9743
9744 2019-01-10  Keith Seitz  <keiths@redhat.com>
9745
9746         PR gdb/23712
9747         PR symtab/23010
9748         * dictionary.c: Include unordered_map.
9749         (pending_to_vector): New function.
9750         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9751         Rewrite the non-"_1" functions to take vector instead
9752         of linked list.
9753         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9754         "new" _1 versions of the same name.
9755         (multidictionary): Define.
9756         (std::hash<enum language): New definition.
9757         (collate_pending_symbols_by_language, mdict_create_hashed)
9758         (mdict_create_hashed_expandable, mdict_create_linear)
9759         (mdict_create_linear_expandable, mdict_free)
9760         (find_language_dictionary, create_new_language_dictionary)
9761         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9762         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9763         (mdict_size, mdict_empty): New functions.
9764         * dictionary.h (mdict_iterator): Define.
9765
9766 2019-01-10  Pedro Alves  <palves@redhat.com>
9767
9768         * breakpoint.c (read_uploaded_action)
9769         (create_tracepoint_from_upload): Adjust to use
9770         gdb::unique_xmalloc_ptr.
9771         * ctf.c (ctf_write_uploaded_tp):
9772         (SET_ARRAY_FIELD): Use emplace_back.
9773         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9774         * tracefile-tfile.c (tfile_write_uploaded_tp):
9775         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9776         gdb::unique_xmalloc_ptr.
9777         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9778         at_string, cond_string, cmd_strings>: Replace char pointers
9779         with gdb::unique_xmalloc_ptr.
9780
9781 2019-01-10  Pedro Alves  <palves@redhat.com>
9782
9783         * solib-target.c (library_list_start_library): Don't xstrdup name.
9784
9785 2019-01-10  Pedro Alves  <palves@redhat.com>
9786
9787         * mdebugread.c (parse_partial_symbols): Use
9788         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9789
9790 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9791
9792         * linux-fork.c (scoped_switch_fork_info)
9793         <~scoped_switch_fork_info>: Fix incorrect variable name.
9794
9795 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9796
9797         * linux-fork.c (scoped_switch_fork_info)
9798         <scoped_switch_fork_info>: Make explicit.
9799         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9800
9801 2019-01-10  Tom Tromey  <tom@tromey.com>
9802
9803         * objfiles.h (objfile::reset_psymtabs): Update.
9804         * objfiles.c (objfile::objfile): Update.
9805         * psymtab.h (psymtab_storage::obstack): Update.
9806         (psymtab_storage::m_obstack): Use gdb::optional.
9807         (class psymtab_storage): Update comment.  Remove objfile
9808         parameter.
9809         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9810
9811 2019-01-10  Tom Tromey  <tom@tromey.com>
9812
9813         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9814         <free_psymtabs>: Now private.
9815         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9816         (allocate_psymtab): Use new method.
9817
9818 2019-01-10  Tom Tromey  <tom@tromey.com>
9819
9820         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9821         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9822         * mdebugread.c (parse_partial_symbols): Use
9823         allocate_dependencies.
9824         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9825         allocate_dependencies.
9826         (process_psymtab_comp_unit_reader)
9827         (build_type_psymtab_dependencies): Likewise.
9828         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9829
9830 2019-01-10  Tom Tromey  <tom@tromey.com>
9831
9832         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9833         PSYMBOL_SET_LANGUAGE.
9834         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9835
9836 2019-01-10  Tom Tromey  <tom@tromey.com>
9837
9838         * psymtab.h (psymtab_storage::obstack): New method.
9839         <m_obstack>: Rename from obstack; now private.
9840         * psymtab.c (psymtab_storage): Update.
9841         * dwarf2read.c (create_addrmap_from_index)
9842         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9843         Update.
9844
9845 2019-01-10  Tom Tromey  <tom@tromey.com>
9846
9847         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9848         * objfiles.h (objfile::reset_psymtabs): New method.
9849
9850 2019-01-10  Tom Tromey  <tom@tromey.com>
9851
9852         * symmisc.c (print_symbol_bcache_statistics): Update.
9853         (print_objfile_statistics): Update.
9854         * symfile.c (reread_symbols): Update.
9855         * psymtab.h (class psymtab_storage): New.
9856         * psymtab.c (psymtab_storage): New constructor.
9857         (~psymtab_storage): New destructor.
9858         (require_partial_symbols): Update.
9859         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9860         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9861         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9862         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9863         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9864         (start_psymtab_common, end_psymtab_common)
9865         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9866         (allocate_psymtab): Update.
9867         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9868         Update.
9869         (dump_psymtab_addrmap, maintenance_print_psymbols)
9870         (maintenance_check_psymtabs): Update.
9871         (class objfile_psymtabs): Move to objfiles.h.
9872         * psympriv.h (discard_psymtab): Now inline.
9873         (psymtab_discarder::psymtab_discarder): Update.
9874         (psymtab_discarder::~psymtab_discarder): Update.
9875         (ALL_OBJFILE_PSYMTABS): Rewrite.
9876         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9877         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9878         Remove fields.
9879         <partial_symtabs>: New field.
9880         (class objfile_psymtabs): Move from psymtab.h.  Update.
9881         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9882         psymbol_cache.
9883         (objfile::~objfile): Don't destroy psymbol_cache.
9884         * mdebugread.c (parse_partial_symbols): Update.
9885         * dwarf2read.c (create_addrmap_from_index)
9886         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9887         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9888         (add_partial_subprogram, dwarf2_ranges_read): Update.
9889         * dwarf-index-write.c (write_address_map)
9890         (write_one_signatured_type, recursively_write_psymbols)
9891         (class debug_names, class debug_names, write_psymtabs_to_index):
9892         Update.
9893
9894 2019-01-10  Tom Tromey  <tom@tromey.com>
9895
9896         * symtab.h (SYMBOL_SET_NAMES): Update.
9897         (symbol_set_names): Update.
9898         (MSYMBOL_SET_NAMES): Update.
9899         * symtab.c (symbol_set_names): Change argument to be an
9900         objfile_per_bfd_storage.
9901         * psymtab.c (add_psymbol_to_bcache): Update.
9902         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9903
9904 2019-01-10  Tom Tromey  <tom@tromey.com>
9905
9906         * symtab.c (create_demangled_names_hash): Change argument to be an
9907         objfile_per_bfd_storage.
9908         (symbol_set_names): Update.
9909
9910 2019-01-10  Tom Tromey  <tom@tromey.com>
9911
9912         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9913         init_psymbol_list.
9914         * psymtab.c (init_psymbol_list): Do nothing if already called.
9915         * psympriv.h (init_psymbol_list): Add comment.
9916         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9917         init_psymbol_list.
9918         * dbxread.c (dbx_symfile_read): Unconditionally call
9919         init_psymbol_list.
9920
9921 2019-01-10  Tom Tromey  <tom@tromey.com>
9922
9923         * xcoffread.c (scan_xcoff_symtab): Update.
9924         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9925         "where".
9926         * mdebugread.c (parse_partial_symbols)
9927         (handle_psymbol_enumerators): Update.
9928         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9929         * dbxread.c (read_dbx_symtab): Update.
9930         * psympriv.h (psymbol_placement): New enum.
9931         (add_psymbol_to_list): Update.
9932
9933 2019-01-10  Tom Tromey  <tom@tromey.com>
9934
9935         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9936         static_psymbols parameters.
9937         (scan_xcoff_symtab): Update.
9938         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9939         static_psymbols parameters.
9940         * psympriv.h (start_psymtab_common): Update.
9941         * mdebugread.c (parse_partial_symbols): Update.
9942         * dwarf2read.c (create_partial_symtab): Update.
9943         * dbxread.c (read_dbx_symtab): Update.
9944         (start_psymtab): Remove global_psymbols and static_psymbols
9945         parameters.
9946
9947 2019-01-10  Tom Tromey  <tom@tromey.com>
9948
9949         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9950         * psymtab.c (allocate_psymtab): Add comment.
9951         * psympriv.h (allocate_psymtab): Add comment.
9952         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9953         initializations.
9954         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9955
9956 2019-01-10  Tom Tromey  <tom@tromey.com>
9957
9958         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9959         Don't declare.
9960         * mipsread.c: Include mdebugread.h.
9961         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9962         Declare.
9963         * elfread.c: Include mdebugread.h.
9964
9965 2019-01-09  Tom Tromey  <tom@tromey.com>
9966
9967         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9968         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9969         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9970         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9971         (psym_lookup_symbol, psym_find_last_source_symtab)
9972         (psym_forget_cached_source_info, psym_print_stats)
9973         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9974         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9975         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9976         (psym_find_compunit_symtab_by_address)
9977         (maintenance_print_psymbols, maintenance_info_psymtabs)
9978         (maintenance_check_psymtabs): Use ranged for.
9979         * psymtab.h (class objfile_psymtabs): New.
9980         (require_partial_symbols): Return objfile_psymtabs.
9981         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9982
9983 2019-01-09  Tom Tromey  <tom@tromey.com>
9984
9985         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9986         (find_pc_mapped_section, list_overlays_command)
9987         (map_overlay_command, unmap_overlay_command)
9988         (simple_overlay_update): Use all_objfiles.
9989         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9990         * printcmd.c (info_symbol_command): Use all_objfiles.
9991         * objfiles.h (ALL_OBJSECTIONS): Remove.
9992         * maint.c (maintenance_translate_address): Use all_objfiles.
9993         * gcore.c (gcore_create_callback): Use all_objfiles.
9994         (objfile_find_memory_regions): Likewise.
9995
9996 2019-01-09  Tom Tromey  <tom@tromey.com>
9997
9998         * symtab.c (find_line_symtab, info_sources_command)
9999         (make_source_files_completion_list): Use objfile_compunits.
10000         * source.c (select_source_symtab): Use objfile_compunits.
10001         * objfiles.h (struct objfile): Update comment.
10002         (ALL_OBJFILES): Remove.
10003         (ALL_FILETABS): Remove.
10004         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10005         objfile_compunits.
10006
10007 2019-01-09  Tom Tromey  <tom@tromey.com>
10008
10009         * symmisc.c (print_objfile_statistics, dump_objfile)
10010         (maintenance_print_symbols): Use compunit_filetabs.
10011         * source.c (forget_cached_source_info_for_objfile): Use
10012         compunit_filetabs.
10013         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10014         (ALL_FILETABS): Use compunit_filetabs.
10015         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10016         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10017
10018 2019-01-09  Tom Tromey  <tom@tromey.com>
10019
10020         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10021         (compunit_filetabs): New.
10022         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10023         compunit_filetabs.
10024         (info_sources_command, make_source_files_completion_list): Remove
10025         declaration.
10026         * symmisc.c (print_objfile_statistics, dump_objfile)
10027         (maintenance_print_symbols): Remove declaration.
10028         (maintenance_info_symtabs): Use compunit_filetabs.
10029         (maintenance_info_line_tables): Likewise.
10030         * source.c (select_source_symtab): Change local variable name.
10031         (forget_cached_source_info_for_objfile): Remove declaration.
10032         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10033         * objfiles.c (objfile_relocate1): Remove declaration.
10034         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10035         declaration.
10036         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10037         * coffread.c (coff_symtab_read): Remove declaration.
10038         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10039         compunit_filetabs.
10040
10041 2019-01-09  Tom Tromey  <tom@tromey.com>
10042
10043         * symtab.c (lookup_objfile_from_block)
10044         (find_pc_sect_compunit_symtab, search_symbols)
10045         (default_collect_symbol_completion_matches_break_on): Use
10046         objfile_compunits.
10047         * objfiles.h (ALL_COMPUNITS): Remove.
10048         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10049         * cp-support.c (add_symbol_overload_list_qualified): Use
10050         objfile_compunits.
10051         * ada-lang.c (ada_collect_symbol_completion_matches)
10052         (ada_add_global_exceptions): Use objfile_compunits.
10053
10054 2019-01-09  Tom Tromey  <tom@tromey.com>
10055
10056         * source.c (select_source_symtab)
10057         (forget_cached_source_info_for_objfile): Remove declaration.
10058         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10059         declaration.
10060         * maint.c (count_symtabs_and_blocks): Remove declaration.
10061         * cp-support.c (add_symbol_overload_list_qualified): Remove
10062         declaration.
10063         * coffread.c (coff_symtab_read): Remove declaration.
10064         * symtab.c (lookup_symbol_in_objfile_symtabs)
10065         (basic_lookup_transparent_type_1): Use objfile_compunits.
10066         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10067         (info_sources_command, search_symbols)
10068         (default_collect_symbol_completion_matches_break_on)
10069         (make_source_files_completion_list): Remove declaration.
10070         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10071         (ada_collect_symbol_completion_matches)
10072         (ada_add_global_exceptions): Remove declaration.
10073         * linespec.c (iterate_over_all_matching_symtabs): Use
10074         objfile_compunits.
10075         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10076         (class objfile_compunits): New.
10077         (ALL_COMPUNITS): Use objfile_compunits.
10078         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10079         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10080         objfile_compunits.
10081         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10082
10083 2019-01-09  Tom Tromey  <tom@tromey.com>
10084
10085         * symtab.c (search_symbols)
10086         (default_collect_symbol_completion_matches_break_on): Use
10087         objfile_msymbols.
10088         * ada-lang.c (ada_lookup_simple_minsym)
10089         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10090         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10091         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10092         objfile_msymbols.
10093         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10094         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10095         * objc-lang.c (find_methods): Use objfile_msymbols.
10096         (info_selectors_command, info_classes_command): Likewise.
10097         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10098         * objfiles.h (class objfile_msymbols): New.
10099         (ALL_OBJFILE_MSYMBOLS): Remove.
10100         (ALL_MSYMBOLS): Remove.
10101
10102 2019-01-09  Tom Tromey  <tom@tromey.com>
10103
10104         * common/next-iterator.h (next_adapter): Add Iterator template
10105         parameter.
10106         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10107         (class all_objfiles_safe): New.
10108         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10109         * objfiles.c (put_objfile_before): Update comment.
10110         (add_separate_debug_objfile): Likewise.
10111         (free_all_objfiles): Use all_objfiles_safe.
10112         (objfile_purge_solibs): Likewise.
10113
10114 2019-01-09  Tom Tromey  <tom@tromey.com>
10115
10116         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10117         (expand_symtab_containing_pc, lookup_static_symbol)
10118         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10119         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10120         all_objfiles.
10121         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10122         * breakpoint.c (create_overlay_event_breakpoint)
10123         (create_longjmp_master_breakpoint)
10124         (create_std_terminate_master_breakpoint)
10125         (create_exception_master_breakpoint): Use all_objfiles.
10126         * linux-thread-db.c (try_thread_db_load_from_pdir)
10127         (has_libpthread): Use all_objfiles.
10128         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10129         * linespec.c (iterate_over_all_matching_symtabs)
10130         (search_minsyms_for_name): Use all_objfiles.
10131         * maint.c (maintenance_info_sections): Use all_objfiles.
10132         * main.c (captured_main_1): Use all_objfiles.
10133         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10134         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10135         * guile/scm-pretty-print.c
10136         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10137         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10138         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10139         (maintenance_print_msymbols): Use all_objfiles.
10140         * source.c (select_source_symtab): Use all_objfiles.
10141         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10142         * symfile.c (remove_symbol_file_command)
10143         (expand_symtabs_matching, map_symbol_filenames): Use
10144         all_objfiles.
10145         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10146         all_objfiles.
10147         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10148         * objc-lang.c (find_methods): Use all_objfiles.
10149         * objfiles.c (have_partial_symbols, have_full_symbols)
10150         (have_minimal_symbols, qsort_cmp)
10151         (default_iterate_over_objfiles_in_search_order): Use
10152         all_objfiles.
10153         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10154         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10155         (maintenance_check_psymtabs): Use all_objfiles.
10156         (ALL_PSYMTABS): Remove.
10157         * compile/compile-object-run.c (do_module_cleanup): Use
10158         all_objfiles.
10159         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10160         * cp-support.c (add_symbol_overload_list_qualified): Use
10161         all_objfiles.
10162         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10163         Use all_objfiles.
10164         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10165         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10166         all_objfiles.
10167         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10168         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10169         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10170         Uses all_objfiles.
10171         * solib.c (solib_read_symbols): Use all_objfiles
10172
10173 2019-01-09  Tom Tromey  <tom@tromey.com>
10174
10175         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10176         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10177         all_objfiles.
10178         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10179         * symmisc.c (print_symbol_bcache_statistics)
10180         (print_objfile_statistics, maintenance_print_objfiles)
10181         (maintenance_info_symtabs, maintenance_check_symtabs)
10182         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10183         all_objfiles.
10184         * source.c (forget_cached_source_info): Use all_objfiles.
10185         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10186         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10187         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10188         * objfiles.c (update_section_map): Use all_objfiles.
10189         (shared_objfile_contains_address_p): Likewise.
10190         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10191         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10192
10193 2019-01-09  Tom Tromey  <tom@tromey.com>
10194
10195         * common/next-iterator.h: New file.
10196         * objfiles.h (class all_objfiles): New.
10197         (struct objfile_iterator): New.
10198
10199 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10200
10201         * NEWS: Move the description of the changed "frame", "select-frame",
10202          and "info frame" commands to the Changed commands section.
10203
10204 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10205
10206         * gdbtypes.c (check_stub_method_group): Remove handling of old
10207         mangling schemes.
10208         * linespec.c (find_methods): Likewise.
10209         * stabsread.c (read_member_functions): Likewise.
10210         * valops.c (search_struct_method): Likewise.
10211         (value_struct_elt_for_reference): Likewise.
10212         * NEWS: Mention this change.
10213
10214 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10215
10216         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10217         print_source_lines.
10218         * source.c (print_source_lines_base): Update line number check.
10219         (print_source_lines): New function.
10220         (source_lines_range::source_lines_range): New function.
10221         * source.h (class source_lines_range): New class.
10222         (print_source_lines): New declaration.
10223
10224 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10225
10226         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10227
10228 2019-01-08  Tom Tromey  <tom@tromey.com>
10229             Simon Marchi  <simon.marchi@ericsson.com>
10230
10231         PR gdb/24060
10232         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10233         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10234         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10235         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10236         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10237         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10238
10239 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10240
10241         * source.c (select_source_symtab): Move header comment to
10242         declaration in source.h.
10243         (forget_cached_source_info_for_objfile): Likewise.
10244         (forget_cached_source_info): Likewise.
10245         (identify_source_line): Likewise.
10246         * source.h (identify_source_line): Move declaration from symtab.h
10247         and add comment from source.c
10248         (print_source_lines): Likewise.
10249         (forget_cached_source_info_for_objfile): Likewise.
10250         (forget_cached_source_info): Likewise.
10251         (select_source_symtab): Likewise.
10252         (enum print_source_lines_flag): Move definition from symtab.h.
10253         * symtab.h (identify_source_line): Move declaration to source.h.
10254         (print_source_lines): Likewise.
10255         (forget_cached_source_info_for_objfile): Likewise.
10256         (forget_cached_source_info): Likewise.
10257         (select_source_symtab): Likewise.
10258         (enum print_source_lines_flag): Move definition to source.h.
10259         * tui/tui-hooks.c: Add 'source.h' include.
10260
10261 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10262
10263         * source.c (print_source_lines_base): Handle requests to print
10264         reverse line number sequences, and guard against empty lines
10265         string.
10266
10267 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10268
10269         * source.c (print_source_lines_base): Fix skip of '\r' if next
10270         character is '\n'.
10271
10272 2019-01-06  Tom Tromey  <tom@tromey.com>
10273
10274         * c-exp.y (struct c_parse_state) <macro_original_text,
10275         expansion_obstack>: New member.
10276         (macro_original_text, expansion_obstack): Remove globals.
10277         (scan_macro_expansion, scanning_macro_expansion)
10278         (finished_macro_expansion): Update.
10279         (scan_macro_cleanup): Remove.
10280         (yylex, c_parse): Update.
10281
10282 2019-01-06  Tom Tromey  <tom@tromey.com>
10283
10284         * c-exp.y (struct c_parse_state) <strings>: New member.
10285         (operator_stoken): Update.
10286
10287 2019-01-06  Tom Tromey  <tom@tromey.com>
10288
10289         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10290         (union type_stack_elt) <typelist_val>: Now a pointer to
10291         std::vector.
10292         (type_stack_cleanup): Don't declare.
10293         (push_typelist): Update.
10294         * parse.c (pop_typelist): Return a std::vector.
10295         (push_typelist): Take a std::vector.
10296         (follow_types): Update.  Do not free args.
10297         (type_stack_cleanup): Remove.
10298         * c-exp.y (struct c_parse_state): New.
10299         (cpstate): New global.
10300         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10301         (nonempty_typelist): Update.
10302         (func_mod): Create a new vector.
10303         (c_parse): Create a c_parse_state.
10304         (check_parameter_typelist): Do not delete params.
10305         (function_method): Update.  Do not delete type_list.
10306
10307 2019-01-06  Tom Tromey  <tom@tromey.com>
10308
10309         PR gdb/28155:
10310         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10311         check_typedef.
10312         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10313         (print_return_value): Likewise.
10314
10315 2019-01-05  Tom Tromey  <tom@tromey.com>
10316
10317         * contrib/cleanup_check.py: Remove.
10318         * contrib/gcc-with-excheck: Remove.
10319         * contrib/exsummary.py: Remove.
10320         * contrib/excheck.py: Remove.
10321
10322 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10323
10324         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10325         NULL. Initialize tpprev to NULL instead of assigning it
10326         to NULL on the next statement.
10327         * windows-nat.c (windows_delete_thread): Remove check for
10328         main_thread_id before printing thread exit notifications.
10329         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10330         Remove thread ID check against main_thread_id.
10331         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10332         windows_delete_thread.
10333         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10334
10335 2019-01-04  Tom Tromey  <tom@tromey.com>
10336
10337         * compile/compile.c (_initialize_compile): Use upper case for
10338         metasyntactic variables.
10339         * symmisc.c (_initialize_symmisc): Use upper case for
10340         metasyntactic variables.
10341         * psymtab.c (_initialize_psymtab): Use upper case for
10342         metasyntactic variables.
10343         * demangle.c (demangle_command): Use upper case for metasyntactic
10344         variables.
10345         (_initialize_demangler): Likewise.
10346         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10347         variables.
10348
10349 2019-01-03  Tom Tromey  <tom@tromey.com>
10350
10351         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10352
10353 2019-01-03  Tom Tromey  <tom@tromey.com>
10354
10355         * python/py-symtab.c (salpy_str): Update.
10356         (struct salpy_sal_object) <symtab>: Now a PyObject.
10357         (salpy_dealloc): Update.
10358         (del_objfile_sal): Use gdbpy_ref.
10359
10360 2019-01-03  Tom Tromey  <tom@tromey.com>
10361
10362         * python/py-type.c (convert_field): Use new_reference.  Return
10363         gdbpy_ref.
10364         (make_fielditem): Return gdbpy_ref.
10365         (typy_fields): Update.
10366         (typy_getitem): Update.
10367         (field_name): Return gdbpy_ref.  Use new_reference.
10368         (typy_iterator_iternext): Update.
10369
10370 2019-01-03  Tom Tromey  <tom@tromey.com>
10371
10372         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10373
10374 2019-01-03  Tom Tromey  <tom@tromey.com>
10375
10376         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10377         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10378         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10379         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10380         (pspy_set_type_printers): Likewise.
10381         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10382         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10383         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10384         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10385         (objfpy_set_type_printers): Likewise.
10386
10387 2019-01-03  Tom Tromey  <tom@tromey.com>
10388
10389         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10390         (gdbpy_print_stack): Use gdbpy_err_fetch.
10391         * python/python-internal.h (class gdbpy_err_fetch): New class.
10392         (class gdbpy_enter) <m_error_type, m_error_value,
10393         m_error_traceback>: Remove.
10394         <m_error>: New member.
10395         (gdbpy_exception_to_string): Don't declare.
10396         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10397         * python/py-value.c (convert_value_from_python): Use
10398         gdbpy_err_fetch.
10399         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10400         gdbpy_exception_to_string.
10401         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10402         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10403         gdbpy_err_fetch.
10404
10405 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10406
10407         * linux-nat.c (delete_lwp_cleanup): Delete.
10408         (struct lwp_deleter): New struct.
10409         (lwp_info_up): New typedef.
10410         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10411         lwp_info_up.
10412
10413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10414
10415         * linux-fork.c (class scoped_switch_fork_info): New class.
10416         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10417
10418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10419
10420         * valops.c (find_overload_match): Remove use of null_cleanup, and
10421         calls to do_cleanups.
10422
10423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10424
10425         * compile/compile-cplus-types.c
10426         (compile_cplus_instance::decl_name): Handle changes to
10427         cp_func_name.
10428         * cp-support.c (cp_func_name): Update header comment, update
10429         return type.
10430         * cp-support.h (cp_func_name): Update return type in declaration.
10431         * valops.c (find_overload_match): Move temp_func local to top
10432         level of function and change its type.  Use temp_func to hold and
10433         delete temporary string obtained from cp_func_name.
10434
10435 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10436
10437         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10438         gdb::char_vector, remove cleanup, and update uses of `msg`.
10439
10440 2019-01-03  Jim Wilson  <jimw@sifive.com>
10441
10442         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10443
10444 2019-01-02  Tom Tromey  <tom@tromey.com>
10445
10446         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10447         (tdesc_parse_xml): Remove cleanups.
10448         * target-descriptions.h (make_cleanup_free_target_description):
10449         Don't declare.
10450         (target_desc_deleter): New struct.
10451         (target_desc_up): New typedef.
10452         * target-descriptions.c (target_desc_deleter::operator()): Rename
10453         from free_target_description.
10454         (make_cleanup_free_target_description): Remove.
10455
10456 2019-01-02  Tom Tromey  <tom@tromey.com>
10457
10458         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10459         constructor, destructor.
10460         (linespec_parser): Remove typedef.
10461         (~linespec_parser): Rename from linespec_parser_delete.
10462         (linespec_lex_to_end, linespec_complete_label)
10463         (linespec_complete): Update.
10464         (decode_line_full): Remove cleanups.
10465         (decode_line_1): Update.
10466
10467 2019-01-02  Tom Tromey  <tom@tromey.com>
10468
10469         * python/python-internal.h (inferior_to_inferior_object): Change
10470         return type.
10471         * python/py-exitedevent.c (create_exited_event_object): Update.
10472         * python/py-inferior.c (inferior_to_inferior_object): Return
10473         gdbpy_ref.
10474         (python_new_inferior, python_inferior_deleted)
10475         (thread_to_thread_object, delete_thread_object)
10476         (build_inferior_list, gdbpy_selected_inferior): Update.
10477         * python/py-infthread.c (create_thread_object): Update.  Also fail
10478         if inferior_to_inferior_object fails.
10479
10480 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10481
10482         * inferior.h (class inferior) <displaced_step_state>: New field.
10483         * infrun.h (struct displaced_step_state): Move here from
10484         infrun.c.  Initialize fields, add constructor.
10485         <inf>: Remove field.
10486         <reset>: New method.
10487         * infrun.c (struct displaced_step_inferior_state): Move to
10488         infrun.h.
10489         (displaced_step_inferior_states): Remove.
10490         (get_displaced_stepping_state): Adust.
10491         (displaced_step_in_progress_any_inferior): Adjust.
10492         (displaced_step_in_progress_thread): Adjust.
10493         (displaced_step_in_progress): Adjust.
10494         (add_displaced_stepping_state): Remove.
10495         (get_displaced_step_closure_by_addr): Adjust.
10496         (remove_displaced_stepping_state): Remove.
10497         (infrun_inferior_exit): Call displaced_step_state.reset.
10498         (use_displaced_stepping): Don't check for NULL.
10499         (displaced_step_prepare_throw): Call
10500         get_displaced_stepping_state.
10501         (displaced_step_fixup): Don't check for NULL.
10502         (prepare_for_detach): Don't check for NULL.
10503
10504 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10505
10506         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10507          in case of call that did not complete.
10508
10509 2019-01-02  Andrey Utkin  <autkin@undo.io>
10510
10511         * symfile.c (find_separate_debug_file): Fix search of debug files for
10512         remote debuggee.
10513
10514 2019-01-02  Tom Tromey  <tom@tromey.com>
10515
10516         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10517         indentation.
10518         * python/py-frame.c (frapy_older): Remove cast.
10519         (frapy_newer): Likewise.
10520         * python/py-breakpoint.c (local_setattro): Remove cast.
10521         * python/py-arch.c (archpy_name): Remove local variable.
10522         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10523
10524 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10525
10526         * unittests/basic_string_view/element_access/char/empty.cc:
10527         Fix year range in copyright header.
10528
10529 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10530
10531         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10532         Delete.
10533         <operator==>: Update with for removed field.
10534         <hash>: Likewise.
10535         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10536         <isa_features>: ...this.
10537         <abi_features>: New field.
10538         (riscv_isa_flen): Update comment.
10539         (riscv_abi_xlen): New declaration.
10540         (riscv_abi_flen): New declaration.
10541         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10542         isa_features.
10543         (riscv_abi_xlen): New function.
10544         (riscv_isa_flen): Update to get answer from isa_features.
10545         (riscv_abi_flen): New function.
10546         (riscv_has_fp_abi): Update to get answer from abi_features.
10547         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10548         xlen and flen.
10549         (riscv_call_info) <xlen, flen>: Update comment.
10550         (riscv_call_arg_struct): Remove invalid assertions
10551         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10552         is removed.
10553         (riscv_gdbarch_init): Gather isa features and abi features
10554         separately, ensure both match on the gdbarch when reusing an old
10555         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10556         a target with 64-bit float hardware.
10557
10558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10559
10560         * source.c (search_command_helper): Stop reverse search
10561         when line 1 has been searched.
10562
10563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10564
10565         * record-full.c (record_full_base_target::close): Rewrite
10566         record_full_core_buf_list free logic.
10567
10568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10569
10570         * break-catch-syscall.c (print_one_catch_syscall): xfree
10571         the last text.
10572
10573 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10574
10575         * top.c (print_gdb_version): Update Copyright year in version
10576         message.
10577
10578 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10579
10580         Update copyright year range in all GDB files.
10581
10582 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10583
10584         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10585
10586 For older changes see ChangeLog-2018.
10587 \f
10588 Local Variables:
10589 mode: change-log
10590 left-margin: 8
10591 fill-column: 74
10592 version-control: never
10593 coding: utf-8
10594 End:
10595