Remove some Python 3 #ifs
[external/binutils.git] / gdb / ChangeLog
1 2019-03-05  Tom Tromey  <tromey@adacore.com>
2
3         * python/py-prettyprint.c (print_string_repr): Remove #if.
4         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5
6 2019-03-05  Tom Tromey  <tromey@adacore.com>
7
8         * target.c (the_dummy_target): Move later.  Change type to
9         "dummy_target".
10         (initialize_targets): Don't initialize the_dummy_target.
11
12 2019-03-05  Tom Tromey  <tromey@adacore.com>
13
14         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
15         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
16
17 2019-03-05  Tom Tromey  <tromey@adacore.com>
18
19         * windows-nat.c (windows_nat_target::attach)
20         (windows_nat_target::detach): Don't call gdb_flush.
21         * valprint.c (generic_val_print, val_print, val_print_string):
22         Don't call gdb_flush.
23         * utils.c (defaulted_query): Don't call gdb_flush.
24         * typeprint.c (print_type_scalar): Don't call gdb_flush.
25         * target.c (target_announce_detach): Don't call gdb_flush.
26         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
27         * remote.c (extended_remote_target::attach): Don't call
28         gdb_flush.
29         * procfs.c (procfs_target::detach): Don't call gdb_flush.
30         * printcmd.c (do_examine): Don't call gdb_flush.
31         (info_display_command): Don't call gdb_flush.
32         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
33         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
34         * memattr.c (info_mem_command): Don't call gdb_flush.
35         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
36         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
37         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
38         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
39         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
40         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
41         (gnu_nat_target::detach): Don't call gdb_flush.
42         * f-valprint.c (f_val_print): Don't call gdb_flush.
43         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
44         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
45         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
46         gdb_flush.
47         * c-valprint.c (c_val_print): Don't call gdb_flush.
48         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
49
50 2019-03-05  Tom Tromey  <tromey@adacore.com>
51
52         * varobj.c (update_dynamic_varobj_children): Update.
53         (install_default_visualizer): Use reset, not release.
54         * value.c (set_internalvar): Update.
55         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
56         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
57         ATTRIBUTE_UNUSED_RESULT.
58
59 2019-03-05  Tom Tromey  <tromey@adacore.com>
60
61         * remote.c (class scoped_remote_fd) <release>: Add
62         ATTRIBUTE_UNUSED_RESULT.
63
64 2019-03-05  Tom Tromey  <tromey@adacore.com>
65
66         * macroexp.c (struct macro_buffer) <release>: Add
67         ATTRIBUTE_UNUSED_RESULT.
68
69 2019-03-05  Tom Tromey  <tromey@adacore.com>
70
71         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
72         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
73         ATTRIBUTE_UNUSED_RESULT.
74
75 2019-03-05  Tom Tromey  <tromey@adacore.com>
76
77         * common/scoped_fd.h (class scoped_fd) <release>: Add
78         ATTRIBUTE_UNUSED_RESULT.
79
80 2019-03-05  Tom Tromey  <tromey@adacore.com>
81
82         * parser-defs.h (struct parser_state) <release>: Add
83         ATTRIBUTE_UNUSED_RESULT.
84
85 2019-03-05  Tom Tromey  <tromey@adacore.com>
86
87         * utils.h (class gdb_argv) <release>: Add
88         ATTRIBUTE_UNUSED_RESULT.
89         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
90
91 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
92
93         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
94         for-loop range, to avoid compiler warnings.
95
96         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
97         avoid compiler warnings about unused variables.
98
99         * NEWS: Mention end of support for native debugging on MS-Windows
100         before XP.
101
102         PR gdb/24292
103         * common/netstuff.c:
104         * gdbserver/gdbreplay.c
105         * gdbserver/remote-utils.c:
106         * ser-tcp.c:
107         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
108         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
109         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
110         'getaddrinfo' and 'freeaddrinfo' were not available before
111         Windows XP, and mingw.org's MinGW headers by default define
112         _WIN32_WINNT to 0x500.
113
114 2019-03-01  Gary Benson <gbenson@redhat.com>
115
116         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
117
118 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
119             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
120
121         PR gdb/8527
122         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
123         set_sigint_trap, clear_sigint_trap.
124
125 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
126
127         * target.c (target_detach): Clear the regcache and the
128         frame cache.
129
130 2019-02-27  Pedro Alves  <palves@redhat.com>
131
132         * utils.c (set_screen_size): When we cap the height/width sizes,
133         tweak the corresponding command variable to show "unlimited":
134
135 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
136             Pedro Alves  <palves@redhat.com>
137
138         * utils.c (set_screen_size): Reduce "infinite" rows and columns
139         before calling rl_set_screen_size.
140
141 2019-02-27  Tom Tromey  <tromey@adacore.com>
142
143         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
144         define.
145         * python/py-value.c: Remove Python 2.4 workaround.
146         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
147         workaround.
148         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
149         Python 2.4 workaround.
150         * python/python-internal.h: Remove Python 2.4 comment.
151         (Py_ssize_t): Don't define.
152         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
153         (gdb_Py_DECREF): Remove Python 2.4 workaround.
154         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
155         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
156         * python/python.c (do_start_initialization): Remove Python 2.4
157         workaround.
158         * python/py-prettyprint.c (class dummy_python_frame): Remove.
159         (print_children): Remove Python 2.4 workaround.
160         * python/py-inferior.c (buffer_procs): Remove Python 2.4
161         workaround.
162         (CHARBUFFERPROC_NAME): Remove.
163         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
164         Python 2.4 workaround.
165
166 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
167
168         * NEWS: Note minimum Python version.
169
170 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
171
172         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
173         code from these functions.  Remove corresponding ifdefs.  Use
174         Py_buffer_up instead of explicit calls to PyBuffer_Release.
175         Remove gotos and target of gotos.
176         (infpy_search_memory): Likewise.
177
178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
179
180         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
181         (hppa_gdbarch_init): Don't register deleted functions with
182         gdbarch.
183
184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
185
186         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
187         (h8300_unwind_sp): Delete.
188         (h8300_dummy_id): Delete.
189         (h8300_gdbarch_init): Don't register deleted functions with
190         gdbarch.
191
192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
193
194         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
195         (ft32_unwind_pc): Delete.
196         (ft32_unwind_sp): Delete.
197         (ft32_gdbarch_init): Don't register deleted functions with
198         gdbarch.
199
200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
201
202         * gdb/frv-tdep.c (frv_dummy_id): Delete.
203         (frv_unwind_pc): Delete.
204         (frv_unwind_sp): Delete.
205         (frv_gdbarch_init): Don't register deleted functions with
206         gdbarch.
207
208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
209
210         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
211         (riscv_unwind_pc): Delete.
212         (riscv_unwind_sp): Delete.
213         (riscv_gdbarch_init): Don't register deleted functions with
214         gdbarch.
215
216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
217
218         * gdb/csky-tdep.c (csky_dummy_id): Delete.
219         (csky_unwind_pc): Delete.
220         (csky_unwind_sp): Delete.
221         (csky_gdbarch_init): Don't register deleted functions with
222         gdbarch.
223
224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
225
226         * gdb/cris-tdep.c (cris_dummy_id): Delete.
227         (cris_unwind_pc): Delete.
228         (cris_unwind_sp): Delete.
229         (cris_gdbarch_init): Don't register deleted functions with
230         gdbarch.
231
232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
233
234         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
235         (bfin_unwind_pc): Delete.
236         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
237
238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
239
240         * gdb/arm-tdep.c (arm_dummy_id): Delete.
241         (arm_unwind_pc): Delete.
242         (arm_unwind_sp): Delete.
243         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
244
245 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
246
247         * gdb/arc-tdep.c (arc_dummy_id): Delete.
248         (arc_unwind_pc): Delete.
249         (arc_unwind_sp): Delete.
250         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
251
252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
253
254         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
255         (alpha_unwind_pc): Delete.
256         (alpha_gdbarch_init): Don't register deleted functions with
257         gdbarch.
258
259 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
260
261         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
262         (aarch64_unwind_pc): Delete.
263         (aarch64_unwind_sp): Delete.
264         (aarch64_gdbarch_init): Don't register deleted functions with
265         gdbarch.
266
267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
268
269         * gdbtypes.c (type_align): Don't consider static members when
270         computing structure alignment.
271
272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
273
274         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
275         return 0 for other types.
276         * arch-utils.c (default_type_align): Always return 0.
277         * gdbarch.h: Regenerate.
278         * gdbarch.sh (type_align): Extend comment.
279         * gdbtypes.c (type_align): Add additional comments, always call
280         gdbarch_type_align before applying the default rules.
281         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
282         generic code will then apply a suitable default.
283         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
284         types, return 0 for other types.
285
286 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
287
288         * NEWS: Create a new section for the next release branch.
289         Rename the section of the current branch, now that it has
290         been cut.
291
292 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
293
294         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
295         * version.in: Bump version to 8.3.50.DATE-git.
296
297 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
298
299         * aix-thread.c (ptid_cmp): Remove unused variable.
300         (get_signaled_thread): Likewise.
301         (store_regs_user_thread): Likewise.
302         (store_regs_kernel_thread): Likewise.
303         (fetch_regs_kernel_thread): Remove shadowed variable.
304
305 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
306
307         * features/riscv/32bit-cpu.xml: Add register numbers.
308         * features/riscv/32bit-fpu.c: Regenerate.
309         * features/riscv/32bit-fpu.xml: Add register numbers.
310         * features/riscv/64bit-cpu.xml: Add register numbers.
311         * features/riscv/64bit-fpu.c: Regenerate.
312         * features/riscv/64bit-fpu.xml: Add register numbers.
313
314 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
315
316         * NEWS: Mention two argument form of gdb.Value constructor.
317         * python/py-value.c (convert_buffer_and_type_to_value): New
318         function.
319         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
320         Add support for handling an optional second argument.  Call
321         convert_buffer_and_type_to_value as appropriate.
322         * python/python-internal.h (Py_buffer_deleter): New struct.
323         (Py_buffer_up): New typedef.
324
325 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
326
327         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
328         instead of releasing ownership.
329
330 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
331
332         * dwarf2read.c (open_and_init_dwp_file): Call
333         elf_numsections instead of bfd_count_sections to initialize
334         dwp_file->num_sections.
335
336 2019-02-25  Tom Tromey  <tromey@adacore.com>
337
338         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
339
340 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
341
342         * gcore.in: Add '--readnever' option when invoking GDB.
343
344 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
345
346         * MAINTAINERS: Update my email address.
347
348 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
349
350         * build-id.c (build_id_to_debug_bfd_1): New function.
351         (build_id_to_debug_bfd): Look for separate debug file in
352         sysroot.
353
354 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
355
356         * gdbarch.sh: Update the copyright year range that is placed into
357         generated files.
358
359 2019-02-22  Keith Seitz  <keiths@redhat.com>
360
361         PR symtab/23853
362         * linespec.c (create_sals_line_offset): Search for the default
363         symtab's filename instead of its fullname.
364
365 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
366
367         * NEWS: Update style defaults.
368
369 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
370
371         * main.c (captured_main_1): Disable styling in batch mode.
372
373 2019-02-20  Tom Tromey  <tom@tromey.com>
374
375         * symtab.c (symtab_symbol_info): Fix typos.
376
377 2019-02-20  Tom Tromey  <tromey@adacore.com>
378
379         * findcmd.c (_initialize_mem_search): Use upper case for
380         metasyntactic variables.
381
382 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
383
384         * aarch64-tdep.c (aarch64_add_reggroups): New function.
385         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
386
387 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
388
389         * top.h (source_file_name): Change to std::string.
390         * top.c (source_file_name): Likewise.
391         (command_line_input): Adjust.
392         * cli/cli-script.c (script_from_file): Adjust.
393
394 2019-02-19  Tom Tromey  <tromey@adacore.com>
395
396         * ravenscar-thread.c
397         (ravenscar_thread_target::update_thread_list): Don't call
398         ada_build_task_list.
399         * ada-lang.h (ada_build_task_list): Don't declare.
400         * ada-tasks.c (struct ada_tasks_inferior_data)
401         <task_list_valid_p>: Now bool.
402         (read_known_tasks, ada_task_list_changed)
403         (ada_tasks_invalidate_inferior_data): Update.
404         (read_known_tasks_array): Return bool.
405         (read_known_tasks_list): Likewise.
406         (read_known_tasks): Return void.
407         (ada_build_task_list): Now static.
408
409 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
410
411         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
412         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
413
414 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
415
416         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
417         variant for ada_tasks_pspace_data_handle and
418         ada_tasks_inferior_data_handle.
419         (ada_tasks_pspace_data_cleanup): New function.
420         (ada_tasks_inferior_data_cleanup): New function.
421
422 2019-02-17  Tom Tromey  <tom@tromey.com>
423
424         * macrotab.h (macro_source_fullname): Return a std::string.
425         * macrotab.c (macro_include, check_for_redefinition)
426         (macro_undef, macro_lookup_definition, foreach_macro)
427         (foreach_macro_in_scope): Update.
428         (macro_source_fullname): Return a std::string.
429         * macrocmd.c (show_pp_source_pos): Update.
430
431 2019-02-17  Tom Tromey  <tom@tromey.com>
432
433         * macrocmd.c (show_pp_source_pos): Style the file names.
434
435 2019-02-17  Tom Tromey  <tom@tromey.com>
436
437         PR tui/24197:
438         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
439
440 2019-02-17  Tom Tromey  <tom@tromey.com>
441
442         * ada-lang.c (user_select_syms): Use filtered printing.
443         * utils.c (wrap_style): New global.
444         (desired_style): Remove.
445         (emit_style_escape): Add stream parameter.
446         (set_output_style, reset_terminal_style, prompt_for_continue):
447         Update.
448         (flush_wrap_buffer): Only flush gdb_stdout.
449         (wrap_here): Set wrap_style.
450         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
451         treat escape sequences as a character.  Change when wrap buffer is
452         flushed.
453         (fputs_styled): Do not set the output style when the default is
454         requested.
455         * ui-style.h (struct ui_file_style) <is_default>: New method.
456         * source.c (print_source_lines_base): Emit escape sequences in one
457         piece.
458
459 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
460
461         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
462         integers and enumeration types.
463
464 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
465
466         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
467         instead of lookup_symbol_in_language
468         (do_exact_match): New function.
469         (ada_get_symbol_name_matcher): Return do_exact_match when
470         doing a verbatim match.
471
472 2019-02-15  Tom Tromey  <tromey@adacore.com>
473
474         * ravenscar-thread.c (ravenscar_thread_target::resume)
475         (ravenscar_thread_target::wait): Special case wildcard requests.
476
477 2019-02-15  Tom Tromey  <tromey@adacore.com>
478
479         * ravenscar-thread.c (base_ptid): Remove.
480         (struct ravenscar_thread_target) <close>: New method.
481         <m_base_ptid>: New member.
482         <update_inferior_ptid, active_task, task_is_currently_active,
483         runtime_initialized>: Declare methods.
484         <ravenscar_thread_target>: Add constructor.
485         (ravenscar_thread_target::task_is_currently_active)
486         (ravenscar_thread_target::update_inferior_ptid)
487         (ravenscar_runtime_initialized): Rename.  Now methods.
488         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
489         (ravenscar_thread_target::update_thread_list): Update.
490         (ravenscar_thread_target::active_task): Now method.
491         (ravenscar_thread_target::store_registers)
492         (ravenscar_thread_target::prepare_to_store)
493         (ravenscar_thread_target::prepare_to_store)
494         (ravenscar_thread_target::mourn_inferior): Update.
495         (ravenscar_inferior_created): Use "new" to create target.
496         (ravenscar_thread_target::get_ada_task_ptid): Update.
497         (_initialize_ravenscar): Don't initialize base_ptid.
498         (ravenscar_ops): Remove global.
499
500 2019-02-15  Tom Tromey  <tromey@adacore.com>
501
502         * target.h (push_target): Declare new overload.
503         * target.c (push_target): New overload, taking an rvalue reference.
504         * remote.c (remote_target::open_1): Use push_target overload.
505         * corelow.c (core_target_open): Use push_target overload.
506
507 2019-02-15  Tom Tromey  <tromey@adacore.com>
508
509         * ravenscar-thread.c (is_ravenscar_task)
510         (ravenscar_task_is_currently_active): Return bool.
511         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
512         (_initialize_ravenscar): Remove "(void)".
513         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
514         Return bool.
515
516 2019-02-15  Tom Tromey  <tromey@adacore.com>
517
518         * ravenscar-thread.c (ravenscar_runtime_initializer)
519         (has_ravenscar_runtime, get_running_thread_id)
520         (ravenscar_thread_target::resume): Fix indentation.
521
522 2019-02-15  Tom Tromey  <tromey@adacore.com>
523
524         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
525         from ravenscar_arch_ops.
526         (sparc_ravenscar_ops::fetch_registers)
527         (sparc_ravenscar_ops::store_registers): Now methods.
528         (sparc_ravenscar_prepare_to_store): Remove.
529         (sparc_ravenscar_ops): Redefine.
530         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
531         methods and destructor.  Remove members.
532         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
533         (ravenscar_thread_target::store_registers)
534         (ravenscar_thread_target::prepare_to_store): Update.
535         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
536         Remove.
537         (struct ppc_ravenscar_powerpc_ops): Derive from
538         ravenscar_arch_ops.
539         (ppc_ravenscar_powerpc_ops::fetch_registers)
540         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
541         (ppc_ravenscar_powerpc_ops): Redefine.
542         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
543         (ppc_ravenscar_e500_ops::fetch_registers)
544         (ppc_ravenscar_e500_ops::store_registers): Now methods.
545         (ppc_ravenscar_e500_ops): Redefine.
546         * aarch64-ravenscar-thread.c
547         (aarch64_ravenscar_generic_prepare_to_store): Remove.
548         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
549         (aarch64_ravenscar_fetch_registers)
550         (aarch64_ravenscar_store_registers): Now methods.
551         (aarch64_ravenscar_ops): Redefine.
552
553 2019-02-15  Tom Tromey  <tromey@adacore.com>
554
555         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
556         (ravenscar_thread_target::stopped_by_hw_breakpoint)
557         (ravenscar_thread_target::stopped_by_watchpoint)
558         (ravenscar_thread_target::stopped_data_address)
559         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
560
561 2019-02-15  Tom Tromey  <tromey@adacore.com>
562
563         * ravenscar-thread.c: Fix some typos.
564
565 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
566             Tom Tromey  <tromey@adacore.com>
567
568         * ada-lang.c (ada_exception_sal): Change addr_string to a
569         std::string.
570         (create_ada_exception_catchpoint): Update.
571
572 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
573             Tom Tromey  <tromey@adacore.com>
574
575         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
576         (bp_location_ops): Remove.
577         (base_breakpoint_allocate_location): Update.
578         (free_bp_location): Update.
579         * ada-lang.c (class ada_catchpoint_location)
580         <ada_catchpoint_location>: Remove ops parameter.
581         (ada_catchpoint_location_dtor): Remove.
582         (ada_catchpoint_location_ops): Remove.
583         (allocate_location_exception): Update.
584         * breakpoint.h (struct bp_location_ops): Remove.
585         (class bp_location) <bp_location>: Remove bp_location_ops
586         parameter.
587         <~bp_location>: Add destructor.
588         <ops>: Remove.
589
590 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
591             Pedro Alves  <palves@redhat.com>
592
593         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
594         'PATH_MAX'.
595
596 2019-02-14  David Michael  <fedora.dm0@gmail.com>
597             Samuel Thibault  <samuel.thibault@gnu.org>
598             Thomas Schwinge  <thomas@codesourcery.com>
599
600         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
601         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
602
603 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
604
605         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
606         (check_empty): Use "const char *".
607
608         * gnu-nat.c (gnu_nat_target::detach): Instead of
609         'detach_inferior (pid)' call
610         'detach_inferior (find_inferior_pid (pid))'.
611
612         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
613         'nat/fork-inferior.o'.
614         * gnu-nat.c: #include "nat/fork-inferior.h".
615
616         * gnu-nat.c (gnu_nat_target::detach): Instead of
617         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
618         * gnu-nat.h: #include "inf-child.h".
619         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
620         'i386_gnu_nat_target::fetch_registers'.
621         (gnu_store_registers): Rename/move to
622         'i386_gnu_nat_target::store_registers'.
623
624         * config/i386/nm-i386gnu.h: Don't "#include" any files.
625         * gnu-nat.h (mach_thread_info): New function.
626         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
627
628         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
629
630 2019-02-14  Frederic Konrad  <konrad@adacore.com>
631
632         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
633
634 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
635
636         * windows-nat.c (windows_add_thread): Add new parameter
637         "main_thread_p" with default value set to false.  Update
638         function documentation as well as all callers.
639         (windows_delete_thread): Likewise.
640         (fake_create_process): Update call to windows_add_thread.
641         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
642         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
643         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
644         call to windows_delete_thread.
645
646 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
647
648         * MAINTAINERS: Add Andrew Burgess as global maintainer.
649
650 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
651
652         * symfile.c (find_separate_debug_file): Use canonical path of
653         sysroot with child_path instead of gdb_sysroot if it is valid.
654
655 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
656
657         * symfile.c (find_separate_debug_file): Use child_path to
658         determine if an object file is under a sysroot.
659
660 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
661
662         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
663         unittests/child-path-selftests.c.
664         * common/pathstuff.c (child_path): New function.
665         * common/pathstuff.h (child_path): New prototype.
666         * unittests/child-path-selftests.c: New file.
667
668 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
669
670         * symfile.c (find_separate_debug_file): Look for separate debug
671         files in debug directories under the sysroot.
672
673 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
674
675         * symtab.h (struct minimal_symbol data_p): New const method.
676         (struct minimal_symbol text_p): Likewise.
677         * symtab.c (output_source_filename): Use file name style
678         to print file name.
679         (print_symbol_info): Likewise.
680         (print_msymbol_info): Use address style to print addresses.
681         Use function name style to print executable text symbols.
682         (expand_symtab_containing_pc): Use data_p.
683         (find_pc_sect_compunit_symtab): Likewise.
684
685 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
686
687         * breakpoint.c (describe_other_breakpoints): Use address style
688         to print addresses.
689         (say_where): Likewise.
690
691 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
692
693         * ada-typeprint.c (print_func_type): Print function name
694         style to print function name.
695         * c-typeprint.c (c_print_type_1): Likewise.
696
697 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
698
699         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
700         for execve.
701
702 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
703
704         * c-exp.y (direct_abs_decl): Use emplace_back to record the
705         type_stack.
706
707 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
708
709         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
710         TYPE_CODE_REF types.
711
712 2019-02-08  Jim Wilson  <jimw@sifive.com>
713
714         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
715         (riscv_linux_fregset): New.
716         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
717
718 2019-02-07  Tom Tromey  <tom@tromey.com>
719
720         * thread.c (thread_cancel_execution_command): Update.
721         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
722         methods.
723         (struct thread_fsm_ops): Remove.
724         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
725         (thread_fsm_should_stop, thread_fsm_return_value)
726         (thread_fsm_set_finished, thread_fsm_finished_p)
727         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
728         Don't declare.
729         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
730         * infrun.c (clear_proceed_status_thread)
731         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
732         (print_stop_event): Update.
733         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
734         Add constructor.
735         (step_command_fsm_ops): Remove.
736         (new_step_command_fsm): Remove.
737         (step_1): Update.
738         (step_command_fsm::should_stop): Rename from
739         step_command_fsm_should_stop.
740         (step_command_fsm::clean_up): Rename from
741         step_command_fsm_clean_up.
742         (step_command_fsm::do_async_reply_reason): Rename from
743         step_command_fsm_async_reply_reason.
744         (struct until_next_fsm): Inherit from thread_fsm.  Add
745         constructor.
746         (until_next_fsm_ops): Remove.
747         (new_until_next_fsm): Remove.
748         (until_next_fsm::should_stop): Rename from
749         until_next_fsm_should_stop.
750         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
751         (until_next_fsm::do_async_reply_reason): Rename from
752         until_next_fsm_async_reply_reason.
753         (struct finish_command_fsm): Inherit from thread_fsm.  Add
754         constructor.  Change type of breakpoint.
755         (finish_command_fsm_ops): Remove.
756         (new_finish_command_fsm): Remove.
757         (finish_command_fsm::should_stop): Rename from
758         finish_command_fsm_should_stop.
759         (finish_command_fsm::clean_up): Rename from
760         finish_command_fsm_clean_up.
761         (finish_command_fsm::return_value): Rename from
762         finish_command_fsm_return_value.
763         (finish_command_fsm::do_async_reply_reason): Rename from
764         finish_command_fsm_async_reply_reason.
765         (finish_command): Update.
766         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
767         Add constructor.
768         (call_thread_fsm_ops): Remove.
769         (call_thread_fsm::call_thread_fsm): Rename from
770         new_call_thread_fsm.
771         (call_thread_fsm::should_stop): Rename from
772         call_thread_fsm_should_stop.
773         (call_thread_fsm::should_notify_stop): Rename from
774         call_thread_fsm_should_notify_stop.
775         (run_inferior_call, call_function_by_hand_dummy): Update.
776         * cli/cli-interp.c (should_print_stop_to_console): Update.
777         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
778         Add constructor.  Change type of location_breakpoint,
779         caller_breakpoint.
780         (until_break_fsm_ops): Remove.
781         (new_until_break_fsm): Remove.
782         (until_break_fsm::should_stop): Rename from
783         until_break_fsm_should_stop.
784         (until_break_fsm::clean_up): Rename from
785         until_break_fsm_clean_up.
786         (until_break_fsm::do_async_reply_reason): Rename from
787         until_break_fsm_async_reply_reason.
788         (until_break_command): Update.
789         * thread-fsm.c: Remove.
790         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
791
792 2019-02-07  Tom Tromey  <tom@tromey.com>
793
794         * yy-remap.h: Add include guard.
795         * xtensa-tdep.h: Add include guard.
796         * xcoffread.h: Rename include guard.
797         * varobj-iter.h: Add include guard.
798         * tui/tui.h: Rename include guard.
799         * tui/tui-winsource.h: Rename include guard.
800         * tui/tui-wingeneral.h: Rename include guard.
801         * tui/tui-windata.h: Rename include guard.
802         * tui/tui-win.h: Rename include guard.
803         * tui/tui-stack.h: Rename include guard.
804         * tui/tui-source.h: Rename include guard.
805         * tui/tui-regs.h: Rename include guard.
806         * tui/tui-out.h: Rename include guard.
807         * tui/tui-layout.h: Rename include guard.
808         * tui/tui-io.h: Rename include guard.
809         * tui/tui-hooks.h: Rename include guard.
810         * tui/tui-file.h: Rename include guard.
811         * tui/tui-disasm.h: Rename include guard.
812         * tui/tui-data.h: Rename include guard.
813         * tui/tui-command.h: Rename include guard.
814         * tic6x-tdep.h: Add include guard.
815         * target/waitstatus.h: Rename include guard.
816         * target/wait.h: Rename include guard.
817         * target/target.h: Rename include guard.
818         * target/resume.h: Rename include guard.
819         * target-float.h: Rename include guard.
820         * stabsread.h: Add include guard.
821         * rs6000-tdep.h: Add include guard.
822         * riscv-fbsd-tdep.h: Add include guard.
823         * regformats/regdef.h: Rename include guard.
824         * record.h: Rename include guard.
825         * python/python.h: Rename include guard.
826         * python/python-internal.h: Rename include guard.
827         * python/py-stopevent.h: Rename include guard.
828         * python/py-ref.h: Rename include guard.
829         * python/py-record.h: Rename include guard.
830         * python/py-record-full.h: Rename include guard.
831         * python/py-record-btrace.h: Rename include guard.
832         * python/py-instruction.h: Rename include guard.
833         * python/py-events.h: Rename include guard.
834         * python/py-event.h: Rename include guard.
835         * procfs.h: Add include guard.
836         * proc-utils.h: Add include guard.
837         * p-lang.h: Add include guard.
838         * or1k-tdep.h: Rename include guard.
839         * observable.h: Rename include guard.
840         * nto-tdep.h: Rename include guard.
841         * nat/x86-linux.h: Rename include guard.
842         * nat/x86-linux-dregs.h: Rename include guard.
843         * nat/x86-gcc-cpuid.h: Add include guard.
844         * nat/x86-dregs.h: Rename include guard.
845         * nat/x86-cpuid.h: Rename include guard.
846         * nat/ppc-linux.h: Rename include guard.
847         * nat/mips-linux-watch.h: Rename include guard.
848         * nat/linux-waitpid.h: Rename include guard.
849         * nat/linux-ptrace.h: Rename include guard.
850         * nat/linux-procfs.h: Rename include guard.
851         * nat/linux-osdata.h: Rename include guard.
852         * nat/linux-nat.h: Rename include guard.
853         * nat/linux-namespaces.h: Rename include guard.
854         * nat/linux-btrace.h: Rename include guard.
855         * nat/glibc_thread_db.h: Rename include guard.
856         * nat/gdb_thread_db.h: Rename include guard.
857         * nat/gdb_ptrace.h: Rename include guard.
858         * nat/fork-inferior.h: Rename include guard.
859         * nat/amd64-linux-siginfo.h: Rename include guard.
860         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
861         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
862         * nat/aarch64-linux.h: Rename include guard.
863         * nat/aarch64-linux-hw-point.h: Rename include guard.
864         * mn10300-tdep.h: Add include guard.
865         * mips-linux-tdep.h: Add include guard.
866         * mi/mi-parse.h: Rename include guard.
867         * mi/mi-out.h: Rename include guard.
868         * mi/mi-main.h: Rename include guard.
869         * mi/mi-interp.h: Rename include guard.
870         * mi/mi-getopt.h: Rename include guard.
871         * mi/mi-console.h: Rename include guard.
872         * mi/mi-common.h: Rename include guard.
873         * mi/mi-cmds.h: Rename include guard.
874         * mi/mi-cmd-break.h: Rename include guard.
875         * m2-lang.h: Add include guard.
876         * location.h: Rename include guard.
877         * linux-record.h: Rename include guard.
878         * linux-nat.h: Add include guard.
879         * linux-fork.h: Add include guard.
880         * i386-darwin-tdep.h: Rename include guard.
881         * hppa-linux-offsets.h: Add include guard.
882         * guile/guile.h: Rename include guard.
883         * guile/guile-internal.h: Rename include guard.
884         * gnu-nat.h: Rename include guard.
885         * gdb-stabs.h: Rename include guard.
886         * frv-tdep.h: Add include guard.
887         * f-lang.h: Add include guard.
888         * event-loop.h: Add include guard.
889         * darwin-nat.h: Rename include guard.
890         * cp-abi.h: Rename include guard.
891         * config/sparc/nm-sol2.h: Rename include guard.
892         * config/nm-nto.h: Rename include guard.
893         * config/nm-linux.h: Add include guard.
894         * config/i386/nm-i386gnu.h: Rename include guard.
895         * config/djgpp/nl_types.h: Rename include guard.
896         * config/djgpp/langinfo.h: Rename include guard.
897         * compile/gcc-cp-plugin.h: Add include guard.
898         * compile/gcc-c-plugin.h: Add include guard.
899         * compile/compile.h: Rename include guard.
900         * compile/compile-object-run.h: Rename include guard.
901         * compile/compile-object-load.h: Rename include guard.
902         * compile/compile-internal.h: Rename include guard.
903         * compile/compile-cplus.h: Rename include guard.
904         * compile/compile-c.h: Rename include guard.
905         * common/xml-utils.h: Rename include guard.
906         * common/x86-xstate.h: Rename include guard.
907         * common/version.h: Rename include guard.
908         * common/vec.h: Rename include guard.
909         * common/tdesc.h: Rename include guard.
910         * common/selftest.h: Rename include guard.
911         * common/scoped_restore.h: Rename include guard.
912         * common/scoped_mmap.h: Rename include guard.
913         * common/scoped_fd.h: Rename include guard.
914         * common/safe-iterator.h: Rename include guard.
915         * common/run-time-clock.h: Rename include guard.
916         * common/refcounted-object.h: Rename include guard.
917         * common/queue.h: Rename include guard.
918         * common/ptid.h: Rename include guard.
919         * common/print-utils.h: Rename include guard.
920         * common/preprocessor.h: Rename include guard.
921         * common/pathstuff.h: Rename include guard.
922         * common/observable.h: Rename include guard.
923         * common/netstuff.h: Rename include guard.
924         * common/job-control.h: Rename include guard.
925         * common/host-defs.h: Rename include guard.
926         * common/gdb_wait.h: Rename include guard.
927         * common/gdb_vecs.h: Rename include guard.
928         * common/gdb_unlinker.h: Rename include guard.
929         * common/gdb_unique_ptr.h: Rename include guard.
930         * common/gdb_tilde_expand.h: Rename include guard.
931         * common/gdb_sys_time.h: Rename include guard.
932         * common/gdb_string_view.h: Rename include guard.
933         * common/gdb_splay_tree.h: Rename include guard.
934         * common/gdb_setjmp.h: Rename include guard.
935         * common/gdb_ref_ptr.h: Rename include guard.
936         * common/gdb_optional.h: Rename include guard.
937         * common/gdb_locale.h: Rename include guard.
938         * common/gdb_assert.h: Rename include guard.
939         * common/filtered-iterator.h: Rename include guard.
940         * common/filestuff.h: Rename include guard.
941         * common/fileio.h: Rename include guard.
942         * common/environ.h: Rename include guard.
943         * common/common-utils.h: Rename include guard.
944         * common/common-types.h: Rename include guard.
945         * common/common-regcache.h: Rename include guard.
946         * common/common-inferior.h: Rename include guard.
947         * common/common-gdbthread.h: Rename include guard.
948         * common/common-exceptions.h: Rename include guard.
949         * common/common-defs.h: Rename include guard.
950         * common/common-debug.h: Rename include guard.
951         * common/cleanups.h: Rename include guard.
952         * common/buffer.h: Rename include guard.
953         * common/btrace-common.h: Rename include guard.
954         * common/break-common.h: Rename include guard.
955         * cli/cli-utils.h: Rename include guard.
956         * cli/cli-style.h: Rename include guard.
957         * cli/cli-setshow.h: Rename include guard.
958         * cli/cli-script.h: Rename include guard.
959         * cli/cli-interp.h: Rename include guard.
960         * cli/cli-decode.h: Rename include guard.
961         * cli/cli-cmds.h: Rename include guard.
962         * charset-list.h: Add include guard.
963         * buildsym-legacy.h: Rename include guard.
964         * bfin-tdep.h: Add include guard.
965         * ax.h: Rename include guard.
966         * arm-linux-tdep.h: Add include guard.
967         * arm-fbsd-tdep.h: Add include guard.
968         * arch/xtensa.h: Rename include guard.
969         * arch/tic6x.h: Add include guard.
970         * arch/i386.h: Add include guard.
971         * arch/arm.h: Rename include guard.
972         * arch/arm-linux.h: Rename include guard.
973         * arch/arm-get-next-pcs.h: Rename include guard.
974         * arch/amd64.h: Add include guard.
975         * arch/aarch64-insn.h: Rename include guard.
976         * arch-utils.h: Rename include guard.
977         * annotate.h: Add include guard.
978         * amd64-darwin-tdep.h: Rename include guard.
979         * aarch64-linux-tdep.h: Add include guard.
980         * aarch64-fbsd-tdep.h: Add include guard.
981         * aarch32-linux-nat.h: Add include guard.
982
983 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
984
985         * macrotab.c (macro_define_internal): New function that
986         factorizes macro_define_object_internal and macro_define_function
987         code.
988         (macro_define_object_internal): Use macro_define_internal.
989         (macro_define_function): Likewise.
990
991 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
992
993         * macrocmd.c (extract_identifier): Return
994         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
995         callers.
996
997 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
998
999         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1000
1001 2019-02-05  Tom Tromey  <tom@tromey.com>
1002
1003         * target.c (target_stack::unpush): Move assertion earlier.
1004
1005 2019-01-30  Tom Tromey  <tom@tromey.com>
1006
1007         PR python/23615:
1008         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1009         (gdbpy_parse_and_eval): Likewise.
1010         * python/python-internal.h (gdbpy_allow_threads): New class.
1011
1012 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1013
1014         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1015         (aarch64_fbsd_fpregmap): Move earlier.
1016         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1017         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1018         instead of individual calls to trad_frame_set_reg_addr.
1019         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1020         earlier.
1021         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1022         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1023         instead of individual calls to trad_frame_set_reg_addr.
1024
1025 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1026
1027         * CONTRIBUTE: Replace contribution list with wiki link.
1028
1029 2019-01-25  Tom Tromey  <tom@tromey.com>
1030
1031         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1032
1033 2019-01-25  Tom Tromey  <tom@tromey.com>
1034
1035         * xtensa-linux-nat.c: Fix common/ includes.
1036         * xml-support.h: Fix common/ includes.
1037         * xml-support.c: Fix common/ includes.
1038         * x86-linux-nat.c: Fix common/ includes.
1039         * windows-nat.c: Fix common/ includes.
1040         * varobj.h: Fix common/ includes.
1041         * varobj.c: Fix common/ includes.
1042         * value.c: Fix common/ includes.
1043         * valops.c: Fix common/ includes.
1044         * utils.c: Fix common/ includes.
1045         * unittests/xml-utils-selftests.c: Fix common/ includes.
1046         * unittests/utils-selftests.c: Fix common/ includes.
1047         * unittests/unpack-selftests.c: Fix common/ includes.
1048         * unittests/tracepoint-selftests.c: Fix common/ includes.
1049         * unittests/style-selftests.c: Fix common/ includes.
1050         * unittests/string_view-selftests.c: Fix common/ includes.
1051         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1052         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1053         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1054         * unittests/rsp-low-selftests.c: Fix common/ includes.
1055         * unittests/parse-connection-spec-selftests.c: Fix common/
1056         includes.
1057         * unittests/optional-selftests.c: Fix common/ includes.
1058         * unittests/offset-type-selftests.c: Fix common/ includes.
1059         * unittests/observable-selftests.c: Fix common/ includes.
1060         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1061         * unittests/memrange-selftests.c: Fix common/ includes.
1062         * unittests/memory-map-selftests.c: Fix common/ includes.
1063         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1064         * unittests/function-view-selftests.c: Fix common/ includes.
1065         * unittests/environ-selftests.c: Fix common/ includes.
1066         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1067         * unittests/common-utils-selftests.c: Fix common/ includes.
1068         * unittests/cli-utils-selftests.c: Fix common/ includes.
1069         * unittests/array-view-selftests.c: Fix common/ includes.
1070         * ui-file.c: Fix common/ includes.
1071         * tui/tui-io.c: Fix common/ includes.
1072         * tracepoint.h: Fix common/ includes.
1073         * tracepoint.c: Fix common/ includes.
1074         * tracefile-tfile.c: Fix common/ includes.
1075         * top.h: Fix common/ includes.
1076         * top.c: Fix common/ includes.
1077         * thread.c: Fix common/ includes.
1078         * target/waitstatus.h: Fix common/ includes.
1079         * target/waitstatus.c: Fix common/ includes.
1080         * target.h: Fix common/ includes.
1081         * target.c: Fix common/ includes.
1082         * target-memory.c: Fix common/ includes.
1083         * target-descriptions.c: Fix common/ includes.
1084         * symtab.h: Fix common/ includes.
1085         * symfile.c: Fix common/ includes.
1086         * stap-probe.c: Fix common/ includes.
1087         * spu-linux-nat.c: Fix common/ includes.
1088         * sparc-nat.c: Fix common/ includes.
1089         * source.c: Fix common/ includes.
1090         * solib.c: Fix common/ includes.
1091         * solib-target.c: Fix common/ includes.
1092         * ser-unix.c: Fix common/ includes.
1093         * ser-tcp.c: Fix common/ includes.
1094         * ser-pipe.c: Fix common/ includes.
1095         * ser-base.c: Fix common/ includes.
1096         * selftest-arch.c: Fix common/ includes.
1097         * s12z-tdep.c: Fix common/ includes.
1098         * rust-exp.y: Fix common/ includes.
1099         * rs6000-aix-tdep.c: Fix common/ includes.
1100         * riscv-tdep.c: Fix common/ includes.
1101         * remote.c: Fix common/ includes.
1102         * remote-notif.h: Fix common/ includes.
1103         * remote-fileio.h: Fix common/ includes.
1104         * remote-fileio.c: Fix common/ includes.
1105         * regcache.h: Fix common/ includes.
1106         * regcache.c: Fix common/ includes.
1107         * record-btrace.c: Fix common/ includes.
1108         * python/python.c: Fix common/ includes.
1109         * python/py-type.c: Fix common/ includes.
1110         * python/py-inferior.c: Fix common/ includes.
1111         * progspace.h: Fix common/ includes.
1112         * producer.c: Fix common/ includes.
1113         * procfs.c: Fix common/ includes.
1114         * proc-api.c: Fix common/ includes.
1115         * printcmd.c: Fix common/ includes.
1116         * ppc-linux-nat.c: Fix common/ includes.
1117         * parser-defs.h: Fix common/ includes.
1118         * osdata.c: Fix common/ includes.
1119         * obsd-nat.c: Fix common/ includes.
1120         * nat/x86-linux.c: Fix common/ includes.
1121         * nat/x86-linux-dregs.c: Fix common/ includes.
1122         * nat/x86-dregs.h: Fix common/ includes.
1123         * nat/x86-dregs.c: Fix common/ includes.
1124         * nat/ppc-linux.c: Fix common/ includes.
1125         * nat/mips-linux-watch.h: Fix common/ includes.
1126         * nat/mips-linux-watch.c: Fix common/ includes.
1127         * nat/linux-waitpid.c: Fix common/ includes.
1128         * nat/linux-ptrace.h: Fix common/ includes.
1129         * nat/linux-ptrace.c: Fix common/ includes.
1130         * nat/linux-procfs.c: Fix common/ includes.
1131         * nat/linux-personality.c: Fix common/ includes.
1132         * nat/linux-osdata.c: Fix common/ includes.
1133         * nat/linux-namespaces.c: Fix common/ includes.
1134         * nat/linux-btrace.h: Fix common/ includes.
1135         * nat/linux-btrace.c: Fix common/ includes.
1136         * nat/fork-inferior.c: Fix common/ includes.
1137         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1138         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1139         * nat/aarch64-linux.c: Fix common/ includes.
1140         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1141         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1142         * namespace.h: Fix common/ includes.
1143         * mips-linux-tdep.c: Fix common/ includes.
1144         * minsyms.c: Fix common/ includes.
1145         * mi/mi-parse.h: Fix common/ includes.
1146         * mi/mi-main.c: Fix common/ includes.
1147         * mi/mi-cmd-env.c: Fix common/ includes.
1148         * memrange.h: Fix common/ includes.
1149         * memattr.c: Fix common/ includes.
1150         * maint.h: Fix common/ includes.
1151         * maint.c: Fix common/ includes.
1152         * main.c: Fix common/ includes.
1153         * machoread.c: Fix common/ includes.
1154         * location.c: Fix common/ includes.
1155         * linux-thread-db.c: Fix common/ includes.
1156         * linux-nat.c: Fix common/ includes.
1157         * linux-fork.c: Fix common/ includes.
1158         * inline-frame.c: Fix common/ includes.
1159         * infrun.c: Fix common/ includes.
1160         * inflow.c: Fix common/ includes.
1161         * inferior.h: Fix common/ includes.
1162         * inferior.c: Fix common/ includes.
1163         * infcmd.c: Fix common/ includes.
1164         * inf-ptrace.c: Fix common/ includes.
1165         * inf-child.c: Fix common/ includes.
1166         * ia64-linux-nat.c: Fix common/ includes.
1167         * i387-tdep.c: Fix common/ includes.
1168         * i386-tdep.c: Fix common/ includes.
1169         * i386-linux-tdep.c: Fix common/ includes.
1170         * i386-linux-nat.c: Fix common/ includes.
1171         * i386-go32-tdep.c: Fix common/ includes.
1172         * i386-fbsd-tdep.c: Fix common/ includes.
1173         * i386-fbsd-nat.c: Fix common/ includes.
1174         * guile/scm-type.c: Fix common/ includes.
1175         * guile/guile.c: Fix common/ includes.
1176         * go32-nat.c: Fix common/ includes.
1177         * gnu-nat.c: Fix common/ includes.
1178         * gdbthread.h: Fix common/ includes.
1179         * gdbarch-selftests.c: Fix common/ includes.
1180         * gdb_usleep.c: Fix common/ includes.
1181         * gdb_select.h: Fix common/ includes.
1182         * gdb_bfd.c: Fix common/ includes.
1183         * gcore.c: Fix common/ includes.
1184         * fork-child.c: Fix common/ includes.
1185         * findvar.c: Fix common/ includes.
1186         * fbsd-nat.c: Fix common/ includes.
1187         * event-top.c: Fix common/ includes.
1188         * event-loop.c: Fix common/ includes.
1189         * dwarf2read.c: Fix common/ includes.
1190         * dwarf2loc.c: Fix common/ includes.
1191         * dwarf2-frame.c: Fix common/ includes.
1192         * dwarf-index-cache.c: Fix common/ includes.
1193         * dtrace-probe.c: Fix common/ includes.
1194         * disasm-selftests.c: Fix common/ includes.
1195         * defs.h: Fix common/ includes.
1196         * csky-tdep.c: Fix common/ includes.
1197         * cp-valprint.c: Fix common/ includes.
1198         * cp-support.h: Fix common/ includes.
1199         * cp-support.c: Fix common/ includes.
1200         * corelow.c: Fix common/ includes.
1201         * completer.h: Fix common/ includes.
1202         * completer.c: Fix common/ includes.
1203         * compile/compile.c: Fix common/ includes.
1204         * compile/compile-loc2c.c: Fix common/ includes.
1205         * compile/compile-cplus-types.c: Fix common/ includes.
1206         * compile/compile-cplus-symbols.c: Fix common/ includes.
1207         * command.h: Fix common/ includes.
1208         * cli/cli-dump.c: Fix common/ includes.
1209         * cli/cli-cmds.c: Fix common/ includes.
1210         * charset.c: Fix common/ includes.
1211         * build-id.c: Fix common/ includes.
1212         * btrace.h: Fix common/ includes.
1213         * btrace.c: Fix common/ includes.
1214         * breakpoint.h: Fix common/ includes.
1215         * breakpoint.c: Fix common/ includes.
1216         * ax.h: 
1217         (enum agent_op): Fix common/ includes.
1218         * ax-general.c (struct aop_map): Fix common/ includes.
1219         * ax-gdb.c: Fix common/ includes.
1220         * auxv.c: Fix common/ includes.
1221         * auto-load.c: Fix common/ includes.
1222         * arm-tdep.c: Fix common/ includes.
1223         * arch/riscv.c: Fix common/ includes.
1224         * arch/ppc-linux-common.c: Fix common/ includes.
1225         * arch/i386.c: Fix common/ includes.
1226         * arch/arm.c: Fix common/ includes.
1227         * arch/arm-linux.c: Fix common/ includes.
1228         * arch/arm-get-next-pcs.c: Fix common/ includes.
1229         * arch/amd64.c: Fix common/ includes.
1230         * arch/aarch64.c: Fix common/ includes.
1231         * arch/aarch64-insn.c: Fix common/ includes.
1232         * arch-utils.c: Fix common/ includes.
1233         * amd64-windows-tdep.c: Fix common/ includes.
1234         * amd64-tdep.c: Fix common/ includes.
1235         * amd64-sol2-tdep.c: Fix common/ includes.
1236         * amd64-obsd-tdep.c: Fix common/ includes.
1237         * amd64-nbsd-tdep.c: Fix common/ includes.
1238         * amd64-linux-tdep.c: Fix common/ includes.
1239         * amd64-linux-nat.c: Fix common/ includes.
1240         * amd64-fbsd-tdep.c: Fix common/ includes.
1241         * amd64-fbsd-nat.c: Fix common/ includes.
1242         * amd64-dicos-tdep.c: Fix common/ includes.
1243         * amd64-darwin-tdep.c: Fix common/ includes.
1244         * agent.c: Fix common/ includes.
1245         * ada-lang.h: Fix common/ includes.
1246         * ada-lang.c: Fix common/ includes.
1247         * aarch64-tdep.c: Fix common/ includes.
1248
1249 2019-01-25  Tom Tromey  <tom@tromey.com>
1250
1251         * common/create-version.sh: Use common/version.h.
1252
1253 2019-01-24  Pedro Alves  <palves@redhat.com>
1254
1255         * infrun.c (signal_stop, signal_print, signal_program)
1256         (signal_catch, signal_pass): Now arrays instead of pointers.
1257         (update_signals_program_target, do_target_resume)
1258         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1259         * linux-nat.c (linux_nat_target::pass_signals)
1260         (linux_nat_target::create_inferior, linux_nat_target::attach):
1261         Adjust.
1262         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1263         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1264         * procfs.c (procfs_target::pass_signals): Adjust.
1265         * record-full.c (record_full_target::resume): Adjust.
1266         * remote.c (remote_target::pass_signals)
1267         (remote_target::program_signals): Adjust.
1268         * target-debug.h (target_debug_print_signals): Now takes a
1269         gdb::array_view as parameter.  Adjust.
1270         * target.h (target_ops) <pass_signals, program_signals>: Replace
1271         pointer and length parameters with gdb::array_view.
1272         (target_pass_signals, target_program_signals): Likewise.
1273         * target-delegates.c: Regenerate.
1274
1275 2019-01-24  Pedro Alves  <palves@redhat.com>
1276
1277         * common/forward-scope-exit.h
1278         (forward_scope_exit::forward_scope_exit): Pass arguments to
1279         m_bind_function directly, instead of creating a std::bind and
1280         copying that.
1281
1282 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1285         for static members.
1286         (pass_in_v_vfp_candidate): Likewise.
1287
1288 2019-01-23  Tom Tromey  <tom@tromey.com>
1289             Pedro Alves  <palves@redhat.com>
1290
1291         * regcache.c (class regcache_invalidator): Remove.
1292         (regcache::raw_write): Use make_scope_exit.
1293
1294 2019-01-23  Tom Tromey  <tom@tromey.com>
1295
1296         * ui-out.h (class ui_out_emit_type): Update comment.
1297
1298 2019-01-23  Tom Tromey  <tom@tromey.com>
1299
1300         * infrun.c (fetch_inferior_event): Update comment.
1301
1302 2019-01-23  Tom Tromey  <tom@tromey.com>
1303             Pedro Alves  <palves@redhat.com>
1304
1305         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1306         parameter.
1307         (fetch_inferior_event): Use SCOPE_EXIT.
1308
1309
1310 2019-01-23  Tom Tromey  <tom@tromey.com>
1311             Pedro Alves  <palves@redhat.com>
1312
1313         * infrun.c (disable_thread_events): Delete.
1314         (stop_all_threads): Use SCOPE_EXIT.
1315
1316 2019-01-23  Tom Tromey  <tom@tromey.com>
1317             Pedro Alves  <palves@redhat.com>
1318
1319         * symfile.c: Include forward-scope-exit.h.
1320         (clear_symtab_users_cleanup): Replace forward declaration with
1321         a FORWARD_SCOPE_EXIT.
1322         (syms_from_objfile_1): Use the forward_scope_exit and
1323         gdb::optional instead of cleanup_function.
1324         (reread_symbols): Use the forward_scope_exit instead of
1325         cleanup_function.
1326         (clear_symtab_users_cleanup): Remove function.
1327
1328 2019-01-23  Tom Tromey  <tom@tromey.com>
1329             Pedro Alves  <palves@redhat.com>
1330
1331         * linux-nat.c: Include scope-exit.h.
1332         (cleanup_target_stop): Remove.
1333         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1334         SCOPE_EXIT.
1335
1336 2019-01-23  Tom Tromey  <tom@tromey.com>
1337             Pedro Alves  <palves@redhat.com>
1338
1339         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1340         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1341
1342 2019-01-23  Tom Tromey  <tom@tromey.com>
1343             Andrew Burgess  <andrew.burgess@embecosm.com>
1344             Pedro Alves  <palves@redhat.com>
1345
1346         * infrun.c (fetch_inferior_event): Use scope_exit.
1347         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1348         * top.c (execute_command): Use scope_exit.
1349         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1350         * utils.c (do_bpstat_clear_actions_cleanup)
1351         (make_bpstat_clear_actions_cleanup): Remove.
1352
1353 2019-01-23  Tom Tromey  <tom@tromey.com>
1354             Pedro Alves  <palves@redhat.com>
1355
1356         * infrun.c: Include "common/scope-exit.h"
1357         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1358         (wait_for_inferior): Use SCOPE_EXIT.
1359         (fetch_inferior_event): Use scope_exit.
1360
1361 2019-01-23  Tom Tromey  <tom@tromey.com>
1362             Pedro Alves  <palves@redhat.com>
1363
1364         * breakpoint.c (create_breakpoint): Remove cleanup.
1365
1366 2019-01-23  Tom Tromey  <tom@tromey.com>
1367             Andrew Burgess  <andrew.burgess@embecosm.com>
1368             Pedro Alves  <palves@redhat.com>
1369
1370 2019-01-23  Pedro Alves  <palves@redhat.com>
1371
1372         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1373
1374 2019-01-23  Pedro Alves  <palves@redhat.com>
1375             Andrew Burgess  <andrew.burgess@embecosm.com>
1376
1377         * gdbthread.h: Include "common/forward-scope-exit.h".
1378         (scoped_finish_thread_state): Redefine custom class in terms of
1379         forward_scope_exit.
1380
1381 2019-01-23  Pedro Alves  <palves@redhat.com>
1382             Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * common/forward-scope-exit.h: New file.
1385
1386 2019-01-23  Pedro Alves  <palves@redhat.com>
1387             Andrew Burgess  <andrew.burgess@embecosm.com>
1388             Tom Tromey  <tom@tromey.com>
1389
1390         * common/scope-exit.h: New file.
1391
1392 2019-01-23  Pedro Alves  <palves@redhat.com>
1393
1394         * common/preprocessor.h (ESC): Rename to ...
1395         (ESC_PARENS): ... this.
1396         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1397         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1398
1399 2019-01-23  Tom Tromey  <tom@tromey.com>
1400
1401         * language.h (class scoped_switch_to_sym_language_if_auto):
1402         Initialize m_lang in both cases.
1403
1404 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1405
1406         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1407         with XCNEW.
1408
1409 2019-01-22  Tom Tromey  <tom@tromey.com>
1410
1411         * corelow.c: Do not include sys/file.h.
1412
1413 2019-01-22  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-wingeneral.h: Include gdb_curses.h.
1416
1417 2019-01-22  Tom Tromey  <tom@tromey.com>
1418
1419         * source-cache.h (class source_cache) <get_source_lines,
1420         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1421
1422 2019-01-22  Tom Tromey  <tom@tromey.com>
1423
1424         * remote-fileio.h (struct remote_target): Declare.
1425
1426 2019-01-22  Tom Tromey  <tom@tromey.com>
1427
1428         * python/py-arch.c: Do not include py-ref.h.
1429         * python/py-bpevent.c: Do not include py-ref.h.
1430         * python/py-cmd.c: Do not include py-ref.h.
1431         * python/py-continueevent.c: Do not include py-ref.h.
1432         * python/py-event.h: Do not include py-ref.h.
1433         * python/py-evtregistry.c: Do not include py-ref.h.
1434         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1435         * python/py-frame.c: Do not include py-ref.h.
1436         * python/py-framefilter.c: Do not include py-ref.h.
1437         * python/py-function.c: Do not include py-ref.h.
1438         * python/py-infevents.c: Do not include py-ref.h.
1439         * python/py-linetable.c: Do not include py-ref.h.
1440         * python/py-objfile.c: Do not include py-ref.h.
1441         * python/py-param.c: Do not include py-ref.h.
1442         * python/py-prettyprint.c: Do not include py-ref.h.
1443         * python/py-progspace.c: Do not include py-ref.h.
1444         * python/py-symbol.c: Do not include py-ref.h.
1445         * python/py-symtab.c: Do not include py-ref.h.
1446         * python/py-type.c: Do not include py-ref.h.
1447         * python/py-unwind.c: Do not include py-ref.h.
1448         * python/py-utils.c: Do not include py-ref.h.
1449         * python/py-value.c: Do not include py-ref.h.
1450         * python/py-varobj.c: Do not include py-ref.h.
1451         * python/py-xmethods.c: Do not include py-ref.h.
1452         * python/python.c: Do not include py-ref.h.
1453         * varobj.c: Do not include py-ref.h.
1454
1455 2019-01-22  Tom Tromey  <tom@tromey.com>
1456
1457         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1458         keyword for bcache.
1459
1460 2019-01-22  Tom Tromey  <tom@tromey.com>
1461
1462         * compile/compile-cplus-types.c: Remove a comment by #include.
1463
1464 2019-01-22  Tom Tromey  <tom@tromey.com>
1465
1466         * compile/gcc-c-plugin.h: Include compile-internal.h.
1467
1468 2019-01-22  Tom Tromey  <tom@tromey.com>
1469
1470         * stabsread.c (EXTERN): Do not define.
1471         (symnum, next_symbol_text_func, processing_gcc_compilation)
1472         (within_function, global_sym_chain, global_stabs)
1473         (previous_stab_code, this_object_header_files)
1474         (n_this_object_header_files)
1475         (n_allocated_this_object_header_files): Define.
1476         * stabsread.h (EXTERN): Never define.  Use "extern".
1477
1478 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1479
1480         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1481         history_value.
1482
1483 2019-01-21  Tom Tromey  <tom@tromey.com>
1484
1485         * ui-out.c: Fix includes.
1486         * tui/tui-source.c: Fix includes.
1487         * target.c: Fix includes.
1488         * remote.c: Fix includes.
1489         * regcache.c: Fix includes.
1490         * python/py-block.c: Fix includes.
1491         * printcmd.c: Fix includes.
1492         * or1k-tdep.c: Fix includes.
1493         * mi/mi-main.c: Fix includes.
1494         * m32r-tdep.c: Fix includes.
1495         * csky-tdep.c: Fix includes.
1496         * compile/compile-cplus-types.c: Fix includes.
1497         * cli/cli-interp.c: Fix includes.
1498
1499 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1500
1501         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1502         for padding.
1503
1504 2019-01-16  Tom Tromey  <tom@tromey.com>
1505
1506         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1507         earlier.
1508         (struct objfile) <msymbols_range>: Move from top level.
1509         <msymbols>: New method.
1510         (class objfile_msymbols): Remove.
1511         * symtab.c (default_collect_symbol_completion_matches_break_on):
1512         Update.
1513         * symmisc.c (dump_msymbols): Update.
1514         * stabsread.c (scan_file_globals): Update.
1515         * objc-lang.c (info_selectors_command, info_classes_command)
1516         (find_methods): Update.
1517         * minsyms.c (find_solib_trampoline_target): Update.
1518         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1519         * coffread.c (coff_symfile_read): Update.
1520         * ada-lang.c (ada_lookup_simple_minsym)
1521         (ada_collect_symbol_completion_matches): Update.
1522
1523 2019-01-16  Tom Tromey  <tom@tromey.com>
1524
1525         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1526         type.  Remove no-argument constructor.
1527         <iterator::operator++>: Simplify.
1528         <begin>: Update.
1529         <end>: Use minimal_symbol_count.
1530
1531 2019-01-16  Tom Tromey  <tom@tromey.com>
1532
1533         * objfiles.h (struct objfile) <psymtabs>: New method.
1534         (class objfile_psymtabs): Remove.
1535         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1536         typedef.
1537         <range>: New method.
1538         (require_partial_symbols): Change return type.
1539         * psymtab.c (require_partial_symbols)
1540         (psym_expand_symtabs_matching): Update.
1541         * mdebugread.c (parse_partial_symbols): Update.
1542         * dbxread.c (dbx_end_psymtab): Update.
1543
1544 2019-01-15  Tom Tromey  <tom@tromey.com>
1545
1546         * symtab.c (lookup_objfile_from_block)
1547         (lookup_symbol_in_objfile_symtabs)
1548         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1549         (find_line_symtab, info_sources_command)
1550         (default_collect_symbol_completion_matches_break_on)
1551         (make_source_files_completion_list): Update.
1552         * symmisc.c (print_objfile_statistics, dump_objfile)
1553         (maintenance_print_symbols, maintenance_info_symtabs)
1554         (maintenance_check_symtabs, maintenance_info_line_tables):
1555         Update.
1556         * source.c (select_source_symtab)
1557         (forget_cached_source_info_for_objfile): Update.
1558         * objfiles.h (class objfile_compunits): Remove.
1559         (struct objfile) <compunits_range>: New typedef.
1560         (compunits): New method.
1561         * objfiles.c (objfile_relocate1): Update.
1562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1563         * maint.c (count_symtabs_and_blocks): Update.
1564         * linespec.c (iterate_over_all_matching_symtabs): Update.
1565         * cp-support.c (add_symbol_overload_list_qualified): Update.
1566         * coffread.c (coff_symtab_read): Update.
1567         * ada-lang.c (add_nonlocal_symbols)
1568         (ada_collect_symbol_completion_matches)
1569         (ada_add_global_exceptions): Update.
1570
1571 2019-01-15  Tom Tromey  <tom@tromey.com>
1572
1573         * progspace.h (program_space) <objfiles_safe_range>: New
1574         typedef.
1575         <objfiles_safe>: New method.
1576         * objfiles.h (class all_objfiles_safe): Remove.
1577         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1578         * jit.c (jit_inferior_exit_hook): Update.
1579
1580 2019-01-17  Tom Tromey  <tom@tromey.com>
1581
1582         * progspace.h (program_space) <objfiles_range>: New typedef.
1583         <objfiles>: New method.
1584         <objfiles_head>: Rename from objfiles.
1585         (object_files): Update.
1586         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1587         * guile/scm-pretty-print.c
1588         (ppscm_find_pretty_printer_from_objfiles): Update.
1589         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1590         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1591         Update.
1592         * python/py-progspace.c (pspy_get_objfiles): Update.
1593         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1594         Update.
1595         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1596         (objfpy_lookup_objfile_by_build_id): Update.
1597         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1598         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1599         Update.
1600         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1601         (expand_symtab_containing_pc, lookup_objfile_from_block)
1602         (lookup_static_symbol, basic_lookup_transparent_type)
1603         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1604         (find_line_symtab, info_sources_command)
1605         (default_collect_symbol_completion_matches_break_on)
1606         (make_source_files_completion_list, find_main_name): Update.
1607         * symmisc.c (print_symbol_bcache_statistics)
1608         (print_objfile_statistics, maintenance_print_symbols)
1609         (maintenance_print_msymbols, maintenance_print_objfiles)
1610         (maintenance_info_symtabs, maintenance_check_symtabs)
1611         (maintenance_expand_symtabs, maintenance_info_line_tables):
1612         Update.
1613         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1614         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1615         (map_overlay_command, unmap_overlay_command)
1616         (simple_overlay_update, expand_symtabs_matching)
1617         (map_symbol_filenames): Update.
1618         * symfile-debug.c (set_debug_symfile): Update.
1619         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1620         Update.
1621         * source.c (select_source_symtab, forget_cached_source_info):
1622         Update.
1623         * solib.c (solib_read_symbols): Update.
1624         * solib-spu.c (append_ocl_sos): Update.
1625         * psymtab.c (maintenance_print_psymbols)
1626         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1627         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1628         * printcmd.c (info_symbol_command): Update.
1629         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1630         Update.
1631         * objfiles.h (class all_objfiles): Remove.
1632         * objfiles.c (have_partial_symbols, have_full_symbols)
1633         (have_minimal_symbols, qsort_cmp, update_section_map)
1634         (shared_objfile_contains_address_p)
1635         (default_iterate_over_objfiles_in_search_order): Update.
1636         * objc-lang.c (info_selectors_command, info_classes_command)
1637         (find_methods): Update.
1638         * minsyms.c (find_solib_trampoline_target): Update.
1639         * maint.c (maintenance_info_sections)
1640         (maintenance_translate_address, count_symtabs_and_blocks):
1641         Update.
1642         * main.c (captured_main_1): Update.
1643         * linux-thread-db.c (try_thread_db_load_from_pdir)
1644         (has_libpthread): Update.
1645         * linespec.c (iterate_over_all_matching_symtabs)
1646         (search_minsyms_for_name): Update.
1647         * jit.c (jit_find_objf_with_entry_addr): Update.
1648         * hppa-tdep.c (find_unwind_entry)
1649         (hppa_lookup_stub_minimal_symbol): Update.
1650         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1651         Update.
1652         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1653         (elf_gnu_ifunc_resolve_by_got): Update.
1654         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1655         * dwarf-index-write.c (save_gdb_index_command): Update.
1656         * cp-support.c (add_symbol_overload_list_qualified): Update.
1657         * breakpoint.c (create_overlay_event_breakpoint)
1658         (create_longjmp_master_breakpoint)
1659         (create_std_terminate_master_breakpoint)
1660         (create_exception_master_breakpoint): Update.
1661         * blockframe.c (find_pc_partial_function): Update.
1662         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1663         (ada_collect_symbol_completion_matches)
1664         (ada_add_global_exceptions): Update.
1665
1666 2019-01-17  Tom Tromey  <tom@tromey.com>
1667
1668         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1669         declare VEC.
1670         (solib_target_parse_libraries): Change return type.
1671         (library_list_start_segment, library_list_start_section)
1672         (library_list_end_library, library_list_start_library); Update.
1673         (solib_target_free_library_list): Remove.
1674         (solib_target_parse_libraries): Remove cleanup.  Change return
1675         type.
1676         (solib_target_current_sos): Update.
1677
1678 2019-01-17  Tom Tromey  <tromey@bapiya>
1679
1680         * valprint.c: Replace "the the" with "the".
1681         * symtab.c: Replace "the the" with "the".
1682         * solib.c: Replace "the the" with "the".
1683         * solib-dsbt.c: Replace "the the" with "the".
1684         * linespec.c: Replace "the the" with "the".
1685         * dwarf2loc.h: Replace "the the" with "the".
1686         * amd64-windows-tdep.c: Replace "the the" with "the".
1687         * aarch64-tdep.c: Replace "the the" with "the".
1688
1689 2019-01-16  Keith Seitz  <keiths@redhat.com>
1690
1691         PR gdb/23773
1692         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1693         <builder>: Rename to ..
1694         <m_builder>: ... this and make private.
1695         (dwarf2_cu::get_builder): New method.  Change all users of
1696         `builder' to use this method.
1697         (dwarf2_start_symtab): Move to ...
1698         (dwarf2_cu::start_symtab): ... here.  Update all callers
1699         (setup_type_unit_groups): Move to ...
1700         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1701         callers.
1702         (dwarf2_cu::reset_builder): New method.
1703         (process_full_compunit, process_full_type_unit): Use
1704         dwarf2_cu::reset_builder.
1705         (follow_die_offset): Record the ancestor CU if it is different
1706         from the followed DIE's CU.
1707         (follow_die_sig_1): Likewise.
1708
1709 2019-01-15  Tom Tromey  <tom@tromey.com>
1710
1711         * remote.c (class remote_state) <buf>: Now a char_vector.
1712         <buf_size>: Remove.
1713         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1714         parameter.
1715         (remote_target::getpkt_or_notif_sane_1)
1716         (remote_target::getpkt_sane)
1717         (remote_target::getpkt_or_notif_sane): Likewise.
1718         (class remote_target) <putpkt>: New overload.
1719         (remote_target::read_frame): Change type of "buf_p".  Remove
1720         sizeof_p parameter.
1721         (packet_ok): New overload.
1722         (packet_check_result): New overload.
1723         Update all uses.
1724
1725 2019-01-14  Tom Tromey  <tom@tromey.com>
1726
1727         * remote-notif.c (handle_notification, remote_notif_ack)
1728         (remote_notif_parse): Make "buf" const.
1729         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1730         const.
1731         (remote_notif_parse, remote_notif_ack, handle_notification):
1732         Likewise.
1733         * remote.c (remote_notif_stop_parse): Make "buf" const.
1734         (remote_target::remote_parse_stop_reply): Make "buf" const.
1735         (remote_notif_stop_ack): Make "buf" const.
1736
1737 2019-01-14  Tom Tromey  <tom@tromey.com>
1738
1739         * remote.c (remote_console_output): Make parameter const.
1740
1741 2019-01-14  Tom Tromey  <tom@tromey.com>
1742
1743         * target-debug.h (target_debug_print_signals): Constify.
1744         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1745         * procfs.c (procfs_target::pass_signals): Update.
1746         * linux-nat.c (linux_nat_target::pass_signals): Update.
1747         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1748         * target-delegates.c: Rebuild.
1749         * remote.c (remote_target::program_signals): Update.
1750         (remote_target::pass_signals): Update.
1751         * target.c (target_pass_signals): Constify argument.
1752         (target_program_signals): Likewise.
1753         * target.h (struct target_ops) <pass_signals, program_signals>:
1754         Constify argument.
1755         (target_pass_signals, target_program_signals): Constify argument.
1756
1757 2019-01-14  Tom Tromey  <tom@tromey.com>
1758
1759         PR tui/28819:
1760         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1761
1762 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1763
1764         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1765         field.
1766         * rs6000-tdep.c: Include reggroups.h.
1767         (IS_V_ALIAS_PSEUDOREG): Define.
1768         (rs6000_register_name): Return names for the "vX" aliases.
1769         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1770         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1771         aliases.  Call default_register_reggroup_p for all other
1772         pseudo-registers.
1773         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1774         New functions.
1775         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1776         Handle "vX" aliases.
1777         (v_alias_pseudo_register_collect): New function.
1778         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1779         (rs6000_gdbarch_init): Initialize "vX" aliases as
1780         pseudo-registers.  Restore registration of
1781         rs6000_pseudo_register_reggroup_p with
1782         set_tdesc_pseudo_register_reggroup_p.
1783
1784 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1785
1786         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1787         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1788         set_gdbarch_num_pseudo_regs.
1789
1790 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1791
1792         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1793         Remove arg prefixname, add do_set and do_show.
1794         Add member functions set_list and show_list.
1795         * cli/cli-style.c (class cli_style_option): Update accordingly.
1796         (style_set_list): Move to file scope.
1797         (style_show_list): Likewise.
1798         (set_style): Call help_list.
1799         (show_style): Call cmd_show_list.
1800         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1801         Update to use the new macro.
1802
1803 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1804
1805         * ada-lang.c (_initialize_ada_language): Expand the help text
1806         for the "catch exception" command.
1807
1808 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1809
1810         * symtab.c (matching_obj_sections): Initialize obj,
1811         declare it closer to its usage.
1812
1813 2019-01-10  Tom Tromey  <tom@tromey.com>
1814
1815         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1816         (basic_inf_threads_range): Remove.
1817         (inf_threads_range, inf_non_exited_threads_range)
1818         (safe_inf_threads_range): Use next_adapter.
1819
1820 2019-01-10  Keith Seitz  <keiths@redhat.com>
1821
1822         PR gdb/23712
1823         PR symtab/23010
1824         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1825         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1826
1827 2019-01-10  Keith Seitz  <keiths@redhat.com>
1828
1829         PR gdb/23712
1830         PR symtab/23010
1831         * dictionary.c (pending_to_vector): Remove.
1832         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1833         Remove _1 suffix, replacing functions of the same name.  Update
1834         all callers.
1835         (dict_create_hashed, dict_create_hashed_expandable)
1836         (dict_create_linear, dict_create_linear_expandable, dict_free)
1837         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1838         Make functions static.
1839
1840 2019-01-10  Keith Seitz  <keiths@redhat.com>
1841
1842         PR gdb/23712
1843         PR symtab/23010
1844         * dictionary.h (struct dictionary): Replace declaration with
1845         multidictionary.
1846         (dict_create_hashed, dict_create_hashed_expandable)
1847         (dict_create_linear, dict_create_linear_expandable)
1848         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1849         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1850         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1851         taking multidictionary argument.
1852         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1853         * block.h (struct block) <dict>: Change to multidictionary
1854         and rename `multidict'.
1855         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1856         symmisc.c: Update all dictionary references to multidictionary.
1857
1858 2019-01-10  Keith Seitz  <keiths@redhat.com>
1859
1860         PR gdb/23712
1861         PR symtab/23010
1862         * dictionary.c: Include unordered_map.
1863         (pending_to_vector): New function.
1864         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1865         Rewrite the non-"_1" functions to take vector instead
1866         of linked list.
1867         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1868         "new" _1 versions of the same name.
1869         (multidictionary): Define.
1870         (std::hash<enum language): New definition.
1871         (collate_pending_symbols_by_language, mdict_create_hashed)
1872         (mdict_create_hashed_expandable, mdict_create_linear)
1873         (mdict_create_linear_expandable, mdict_free)
1874         (find_language_dictionary, create_new_language_dictionary)
1875         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1876         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1877         (mdict_size, mdict_empty): New functions.
1878         * dictionary.h (mdict_iterator): Define.
1879
1880 2019-01-10  Pedro Alves  <palves@redhat.com>
1881
1882         * breakpoint.c (read_uploaded_action)
1883         (create_tracepoint_from_upload): Adjust to use
1884         gdb::unique_xmalloc_ptr.
1885         * ctf.c (ctf_write_uploaded_tp):
1886         (SET_ARRAY_FIELD): Use emplace_back.
1887         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1888         * tracefile-tfile.c (tfile_write_uploaded_tp):
1889         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1890         gdb::unique_xmalloc_ptr.
1891         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1892         at_string, cond_string, cmd_strings>: Replace char pointers
1893         with gdb::unique_xmalloc_ptr.
1894
1895 2019-01-10  Pedro Alves  <palves@redhat.com>
1896
1897         * solib-target.c (library_list_start_library): Don't xstrdup name.
1898
1899 2019-01-10  Pedro Alves  <palves@redhat.com>
1900
1901         * mdebugread.c (parse_partial_symbols): Use
1902         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1903
1904 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         * linux-fork.c (scoped_switch_fork_info)
1907         <~scoped_switch_fork_info>: Fix incorrect variable name.
1908
1909 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1910
1911         * linux-fork.c (scoped_switch_fork_info)
1912         <scoped_switch_fork_info>: Make explicit.
1913         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1914
1915 2019-01-10  Tom Tromey  <tom@tromey.com>
1916
1917         * objfiles.h (objfile::reset_psymtabs): Update.
1918         * objfiles.c (objfile::objfile): Update.
1919         * psymtab.h (psymtab_storage::obstack): Update.
1920         (psymtab_storage::m_obstack): Use gdb::optional.
1921         (class psymtab_storage): Update comment.  Remove objfile
1922         parameter.
1923         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1924
1925 2019-01-10  Tom Tromey  <tom@tromey.com>
1926
1927         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1928         <free_psymtabs>: Now private.
1929         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1930         (allocate_psymtab): Use new method.
1931
1932 2019-01-10  Tom Tromey  <tom@tromey.com>
1933
1934         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1935         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1936         * mdebugread.c (parse_partial_symbols): Use
1937         allocate_dependencies.
1938         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1939         allocate_dependencies.
1940         (process_psymtab_comp_unit_reader)
1941         (build_type_psymtab_dependencies): Likewise.
1942         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1943
1944 2019-01-10  Tom Tromey  <tom@tromey.com>
1945
1946         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1947         PSYMBOL_SET_LANGUAGE.
1948         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1949
1950 2019-01-10  Tom Tromey  <tom@tromey.com>
1951
1952         * psymtab.h (psymtab_storage::obstack): New method.
1953         <m_obstack>: Rename from obstack; now private.
1954         * psymtab.c (psymtab_storage): Update.
1955         * dwarf2read.c (create_addrmap_from_index)
1956         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1957         Update.
1958
1959 2019-01-10  Tom Tromey  <tom@tromey.com>
1960
1961         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1962         * objfiles.h (objfile::reset_psymtabs): New method.
1963
1964 2019-01-10  Tom Tromey  <tom@tromey.com>
1965
1966         * symmisc.c (print_symbol_bcache_statistics): Update.
1967         (print_objfile_statistics): Update.
1968         * symfile.c (reread_symbols): Update.
1969         * psymtab.h (class psymtab_storage): New.
1970         * psymtab.c (psymtab_storage): New constructor.
1971         (~psymtab_storage): New destructor.
1972         (require_partial_symbols): Update.
1973         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1974         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1975         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1976         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1977         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1978         (start_psymtab_common, end_psymtab_common)
1979         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1980         (allocate_psymtab): Update.
1981         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1982         Update.
1983         (dump_psymtab_addrmap, maintenance_print_psymbols)
1984         (maintenance_check_psymtabs): Update.
1985         (class objfile_psymtabs): Move to objfiles.h.
1986         * psympriv.h (discard_psymtab): Now inline.
1987         (psymtab_discarder::psymtab_discarder): Update.
1988         (psymtab_discarder::~psymtab_discarder): Update.
1989         (ALL_OBJFILE_PSYMTABS): Rewrite.
1990         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1991         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1992         Remove fields.
1993         <partial_symtabs>: New field.
1994         (class objfile_psymtabs): Move from psymtab.h.  Update.
1995         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1996         psymbol_cache.
1997         (objfile::~objfile): Don't destroy psymbol_cache.
1998         * mdebugread.c (parse_partial_symbols): Update.
1999         * dwarf2read.c (create_addrmap_from_index)
2000         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2001         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2002         (add_partial_subprogram, dwarf2_ranges_read): Update.
2003         * dwarf-index-write.c (write_address_map)
2004         (write_one_signatured_type, recursively_write_psymbols)
2005         (class debug_names, class debug_names, write_psymtabs_to_index):
2006         Update.
2007
2008 2019-01-10  Tom Tromey  <tom@tromey.com>
2009
2010         * symtab.h (SYMBOL_SET_NAMES): Update.
2011         (symbol_set_names): Update.
2012         (MSYMBOL_SET_NAMES): Update.
2013         * symtab.c (symbol_set_names): Change argument to be an
2014         objfile_per_bfd_storage.
2015         * psymtab.c (add_psymbol_to_bcache): Update.
2016         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2017
2018 2019-01-10  Tom Tromey  <tom@tromey.com>
2019
2020         * symtab.c (create_demangled_names_hash): Change argument to be an
2021         objfile_per_bfd_storage.
2022         (symbol_set_names): Update.
2023
2024 2019-01-10  Tom Tromey  <tom@tromey.com>
2025
2026         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2027         init_psymbol_list.
2028         * psymtab.c (init_psymbol_list): Do nothing if already called.
2029         * psympriv.h (init_psymbol_list): Add comment.
2030         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2031         init_psymbol_list.
2032         * dbxread.c (dbx_symfile_read): Unconditionally call
2033         init_psymbol_list.
2034
2035 2019-01-10  Tom Tromey  <tom@tromey.com>
2036
2037         * xcoffread.c (scan_xcoff_symtab): Update.
2038         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2039         "where".
2040         * mdebugread.c (parse_partial_symbols)
2041         (handle_psymbol_enumerators): Update.
2042         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2043         * dbxread.c (read_dbx_symtab): Update.
2044         * psympriv.h (psymbol_placement): New enum.
2045         (add_psymbol_to_list): Update.
2046
2047 2019-01-10  Tom Tromey  <tom@tromey.com>
2048
2049         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2050         static_psymbols parameters.
2051         (scan_xcoff_symtab): Update.
2052         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2053         static_psymbols parameters.
2054         * psympriv.h (start_psymtab_common): Update.
2055         * mdebugread.c (parse_partial_symbols): Update.
2056         * dwarf2read.c (create_partial_symtab): Update.
2057         * dbxread.c (read_dbx_symtab): Update.
2058         (start_psymtab): Remove global_psymbols and static_psymbols
2059         parameters.
2060
2061 2019-01-10  Tom Tromey  <tom@tromey.com>
2062
2063         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2064         * psymtab.c (allocate_psymtab): Add comment.
2065         * psympriv.h (allocate_psymtab): Add comment.
2066         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2067         initializations.
2068         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2069
2070 2019-01-10  Tom Tromey  <tom@tromey.com>
2071
2072         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2073         Don't declare.
2074         * mipsread.c: Include mdebugread.h.
2075         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2076         Declare.
2077         * elfread.c: Include mdebugread.h.
2078
2079 2019-01-09  Tom Tromey  <tom@tromey.com>
2080
2081         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2082         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2083         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2084         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2085         (psym_lookup_symbol, psym_find_last_source_symtab)
2086         (psym_forget_cached_source_info, psym_print_stats)
2087         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2088         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2089         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2090         (psym_find_compunit_symtab_by_address)
2091         (maintenance_print_psymbols, maintenance_info_psymtabs)
2092         (maintenance_check_psymtabs): Use ranged for.
2093         * psymtab.h (class objfile_psymtabs): New.
2094         (require_partial_symbols): Return objfile_psymtabs.
2095         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2096
2097 2019-01-09  Tom Tromey  <tom@tromey.com>
2098
2099         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2100         (find_pc_mapped_section, list_overlays_command)
2101         (map_overlay_command, unmap_overlay_command)
2102         (simple_overlay_update): Use all_objfiles.
2103         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2104         * printcmd.c (info_symbol_command): Use all_objfiles.
2105         * objfiles.h (ALL_OBJSECTIONS): Remove.
2106         * maint.c (maintenance_translate_address): Use all_objfiles.
2107         * gcore.c (gcore_create_callback): Use all_objfiles.
2108         (objfile_find_memory_regions): Likewise.
2109
2110 2019-01-09  Tom Tromey  <tom@tromey.com>
2111
2112         * symtab.c (find_line_symtab, info_sources_command)
2113         (make_source_files_completion_list): Use objfile_compunits.
2114         * source.c (select_source_symtab): Use objfile_compunits.
2115         * objfiles.h (struct objfile): Update comment.
2116         (ALL_OBJFILES): Remove.
2117         (ALL_FILETABS): Remove.
2118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2119         objfile_compunits.
2120
2121 2019-01-09  Tom Tromey  <tom@tromey.com>
2122
2123         * symmisc.c (print_objfile_statistics, dump_objfile)
2124         (maintenance_print_symbols): Use compunit_filetabs.
2125         * source.c (forget_cached_source_info_for_objfile): Use
2126         compunit_filetabs.
2127         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2128         (ALL_FILETABS): Use compunit_filetabs.
2129         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2130         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2131
2132 2019-01-09  Tom Tromey  <tom@tromey.com>
2133
2134         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2135         (compunit_filetabs): New.
2136         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2137         compunit_filetabs.
2138         (info_sources_command, make_source_files_completion_list): Remove
2139         declaration.
2140         * symmisc.c (print_objfile_statistics, dump_objfile)
2141         (maintenance_print_symbols): Remove declaration.
2142         (maintenance_info_symtabs): Use compunit_filetabs.
2143         (maintenance_info_line_tables): Likewise.
2144         * source.c (select_source_symtab): Change local variable name.
2145         (forget_cached_source_info_for_objfile): Remove declaration.
2146         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2147         * objfiles.c (objfile_relocate1): Remove declaration.
2148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2149         declaration.
2150         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2151         * coffread.c (coff_symtab_read): Remove declaration.
2152         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2153         compunit_filetabs.
2154
2155 2019-01-09  Tom Tromey  <tom@tromey.com>
2156
2157         * symtab.c (lookup_objfile_from_block)
2158         (find_pc_sect_compunit_symtab, search_symbols)
2159         (default_collect_symbol_completion_matches_break_on): Use
2160         objfile_compunits.
2161         * objfiles.h (ALL_COMPUNITS): Remove.
2162         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2163         * cp-support.c (add_symbol_overload_list_qualified): Use
2164         objfile_compunits.
2165         * ada-lang.c (ada_collect_symbol_completion_matches)
2166         (ada_add_global_exceptions): Use objfile_compunits.
2167
2168 2019-01-09  Tom Tromey  <tom@tromey.com>
2169
2170         * source.c (select_source_symtab)
2171         (forget_cached_source_info_for_objfile): Remove declaration.
2172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2173         declaration.
2174         * maint.c (count_symtabs_and_blocks): Remove declaration.
2175         * cp-support.c (add_symbol_overload_list_qualified): Remove
2176         declaration.
2177         * coffread.c (coff_symtab_read): Remove declaration.
2178         * symtab.c (lookup_symbol_in_objfile_symtabs)
2179         (basic_lookup_transparent_type_1): Use objfile_compunits.
2180         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2181         (info_sources_command, search_symbols)
2182         (default_collect_symbol_completion_matches_break_on)
2183         (make_source_files_completion_list): Remove declaration.
2184         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2185         (ada_collect_symbol_completion_matches)
2186         (ada_add_global_exceptions): Remove declaration.
2187         * linespec.c (iterate_over_all_matching_symtabs): Use
2188         objfile_compunits.
2189         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2190         (class objfile_compunits): New.
2191         (ALL_COMPUNITS): Use objfile_compunits.
2192         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2193         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2194         objfile_compunits.
2195         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2196
2197 2019-01-09  Tom Tromey  <tom@tromey.com>
2198
2199         * symtab.c (search_symbols)
2200         (default_collect_symbol_completion_matches_break_on): Use
2201         objfile_msymbols.
2202         * ada-lang.c (ada_lookup_simple_minsym)
2203         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2204         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2205         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2206         objfile_msymbols.
2207         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2208         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2209         * objc-lang.c (find_methods): Use objfile_msymbols.
2210         (info_selectors_command, info_classes_command): Likewise.
2211         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2212         * objfiles.h (class objfile_msymbols): New.
2213         (ALL_OBJFILE_MSYMBOLS): Remove.
2214         (ALL_MSYMBOLS): Remove.
2215
2216 2019-01-09  Tom Tromey  <tom@tromey.com>
2217
2218         * common/next-iterator.h (next_adapter): Add Iterator template
2219         parameter.
2220         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2221         (class all_objfiles_safe): New.
2222         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2223         * objfiles.c (put_objfile_before): Update comment.
2224         (add_separate_debug_objfile): Likewise.
2225         (free_all_objfiles): Use all_objfiles_safe.
2226         (objfile_purge_solibs): Likewise.
2227
2228 2019-01-09  Tom Tromey  <tom@tromey.com>
2229
2230         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2231         (expand_symtab_containing_pc, lookup_static_symbol)
2232         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2233         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2234         all_objfiles.
2235         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2236         * breakpoint.c (create_overlay_event_breakpoint)
2237         (create_longjmp_master_breakpoint)
2238         (create_std_terminate_master_breakpoint)
2239         (create_exception_master_breakpoint): Use all_objfiles.
2240         * linux-thread-db.c (try_thread_db_load_from_pdir)
2241         (has_libpthread): Use all_objfiles.
2242         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2243         * linespec.c (iterate_over_all_matching_symtabs)
2244         (search_minsyms_for_name): Use all_objfiles.
2245         * maint.c (maintenance_info_sections): Use all_objfiles.
2246         * main.c (captured_main_1): Use all_objfiles.
2247         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2248         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2249         * guile/scm-pretty-print.c
2250         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2251         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2252         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2253         (maintenance_print_msymbols): Use all_objfiles.
2254         * source.c (select_source_symtab): Use all_objfiles.
2255         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2256         * symfile.c (remove_symbol_file_command)
2257         (expand_symtabs_matching, map_symbol_filenames): Use
2258         all_objfiles.
2259         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2260         all_objfiles.
2261         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2262         * objc-lang.c (find_methods): Use all_objfiles.
2263         * objfiles.c (have_partial_symbols, have_full_symbols)
2264         (have_minimal_symbols, qsort_cmp)
2265         (default_iterate_over_objfiles_in_search_order): Use
2266         all_objfiles.
2267         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2268         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2269         (maintenance_check_psymtabs): Use all_objfiles.
2270         (ALL_PSYMTABS): Remove.
2271         * compile/compile-object-run.c (do_module_cleanup): Use
2272         all_objfiles.
2273         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2274         * cp-support.c (add_symbol_overload_list_qualified): Use
2275         all_objfiles.
2276         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2277         Use all_objfiles.
2278         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2279         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2280         all_objfiles.
2281         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2282         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2283         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2284         Uses all_objfiles.
2285         * solib.c (solib_read_symbols): Use all_objfiles
2286
2287 2019-01-09  Tom Tromey  <tom@tromey.com>
2288
2289         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2290         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2291         all_objfiles.
2292         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2293         * symmisc.c (print_symbol_bcache_statistics)
2294         (print_objfile_statistics, maintenance_print_objfiles)
2295         (maintenance_info_symtabs, maintenance_check_symtabs)
2296         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2297         all_objfiles.
2298         * source.c (forget_cached_source_info): Use all_objfiles.
2299         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2300         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2301         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2302         * objfiles.c (update_section_map): Use all_objfiles.
2303         (shared_objfile_contains_address_p): Likewise.
2304         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2305         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2306
2307 2019-01-09  Tom Tromey  <tom@tromey.com>
2308
2309         * common/next-iterator.h: New file.
2310         * objfiles.h (class all_objfiles): New.
2311         (struct objfile_iterator): New.
2312
2313 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2314
2315         * NEWS: Move the description of the changed "frame", "select-frame",
2316          and "info frame" commands to the Changed commands section.
2317
2318 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2319
2320         * gdbtypes.c (check_stub_method_group): Remove handling of old
2321         mangling schemes.
2322         * linespec.c (find_methods): Likewise.
2323         * stabsread.c (read_member_functions): Likewise.
2324         * valops.c (search_struct_method): Likewise.
2325         (value_struct_elt_for_reference): Likewise.
2326         * NEWS: Mention this change.
2327
2328 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2331         print_source_lines.
2332         * source.c (print_source_lines_base): Update line number check.
2333         (print_source_lines): New function.
2334         (source_lines_range::source_lines_range): New function.
2335         * source.h (class source_lines_range): New class.
2336         (print_source_lines): New declaration.
2337
2338 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2339
2340         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2341
2342 2019-01-08  Tom Tromey  <tom@tromey.com>
2343             Simon Marchi  <simon.marchi@ericsson.com>
2344
2345         PR gdb/24060
2346         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2347         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2348         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2349         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2350         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2351         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2352
2353 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2354
2355         * source.c (select_source_symtab): Move header comment to
2356         declaration in source.h.
2357         (forget_cached_source_info_for_objfile): Likewise.
2358         (forget_cached_source_info): Likewise.
2359         (identify_source_line): Likewise.
2360         * source.h (identify_source_line): Move declaration from symtab.h
2361         and add comment from source.c
2362         (print_source_lines): Likewise.
2363         (forget_cached_source_info_for_objfile): Likewise.
2364         (forget_cached_source_info): Likewise.
2365         (select_source_symtab): Likewise.
2366         (enum print_source_lines_flag): Move definition from symtab.h.
2367         * symtab.h (identify_source_line): Move declaration to source.h.
2368         (print_source_lines): Likewise.
2369         (forget_cached_source_info_for_objfile): Likewise.
2370         (forget_cached_source_info): Likewise.
2371         (select_source_symtab): Likewise.
2372         (enum print_source_lines_flag): Move definition to source.h.
2373         * tui/tui-hooks.c: Add 'source.h' include.
2374
2375 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         * source.c (print_source_lines_base): Handle requests to print
2378         reverse line number sequences, and guard against empty lines
2379         string.
2380
2381 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * source.c (print_source_lines_base): Fix skip of '\r' if next
2384         character is '\n'.
2385
2386 2019-01-06  Tom Tromey  <tom@tromey.com>
2387
2388         * c-exp.y (struct c_parse_state) <macro_original_text,
2389         expansion_obstack>: New member.
2390         (macro_original_text, expansion_obstack): Remove globals.
2391         (scan_macro_expansion, scanning_macro_expansion)
2392         (finished_macro_expansion): Update.
2393         (scan_macro_cleanup): Remove.
2394         (yylex, c_parse): Update.
2395
2396 2019-01-06  Tom Tromey  <tom@tromey.com>
2397
2398         * c-exp.y (struct c_parse_state) <strings>: New member.
2399         (operator_stoken): Update.
2400
2401 2019-01-06  Tom Tromey  <tom@tromey.com>
2402
2403         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2404         (union type_stack_elt) <typelist_val>: Now a pointer to
2405         std::vector.
2406         (type_stack_cleanup): Don't declare.
2407         (push_typelist): Update.
2408         * parse.c (pop_typelist): Return a std::vector.
2409         (push_typelist): Take a std::vector.
2410         (follow_types): Update.  Do not free args.
2411         (type_stack_cleanup): Remove.
2412         * c-exp.y (struct c_parse_state): New.
2413         (cpstate): New global.
2414         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2415         (nonempty_typelist): Update.
2416         (func_mod): Create a new vector.
2417         (c_parse): Create a c_parse_state.
2418         (check_parameter_typelist): Do not delete params.
2419         (function_method): Update.  Do not delete type_list.
2420
2421 2019-01-06  Tom Tromey  <tom@tromey.com>
2422
2423         PR gdb/28155:
2424         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2425         check_typedef.
2426         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2427         (print_return_value): Likewise.
2428
2429 2019-01-05  Tom Tromey  <tom@tromey.com>
2430
2431         * contrib/cleanup_check.py: Remove.
2432         * contrib/gcc-with-excheck: Remove.
2433         * contrib/exsummary.py: Remove.
2434         * contrib/excheck.py: Remove.
2435
2436 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2437
2438         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2439         NULL. Initialize tpprev to NULL instead of assigning it
2440         to NULL on the next statement.
2441         * windows-nat.c (windows_delete_thread): Remove check for
2442         main_thread_id before printing thread exit notifications.
2443         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2444         Remove thread ID check against main_thread_id.
2445         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2446         windows_delete_thread.
2447         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2448
2449 2019-01-04  Tom Tromey  <tom@tromey.com>
2450
2451         * compile/compile.c (_initialize_compile): Use upper case for
2452         metasyntactic variables.
2453         * symmisc.c (_initialize_symmisc): Use upper case for
2454         metasyntactic variables.
2455         * psymtab.c (_initialize_psymtab): Use upper case for
2456         metasyntactic variables.
2457         * demangle.c (demangle_command): Use upper case for metasyntactic
2458         variables.
2459         (_initialize_demangler): Likewise.
2460         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2461         variables.
2462
2463 2019-01-03  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2466
2467 2019-01-03  Tom Tromey  <tom@tromey.com>
2468
2469         * python/py-symtab.c (salpy_str): Update.
2470         (struct salpy_sal_object) <symtab>: Now a PyObject.
2471         (salpy_dealloc): Update.
2472         (del_objfile_sal): Use gdbpy_ref.
2473
2474 2019-01-03  Tom Tromey  <tom@tromey.com>
2475
2476         * python/py-type.c (convert_field): Use new_reference.  Return
2477         gdbpy_ref.
2478         (make_fielditem): Return gdbpy_ref.
2479         (typy_fields): Update.
2480         (typy_getitem): Update.
2481         (field_name): Return gdbpy_ref.  Use new_reference.
2482         (typy_iterator_iternext): Update.
2483
2484 2019-01-03  Tom Tromey  <tom@tromey.com>
2485
2486         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2487
2488 2019-01-03  Tom Tromey  <tom@tromey.com>
2489
2490         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2491         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2492         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2493         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2494         (pspy_set_type_printers): Likewise.
2495         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2496         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2497         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2498         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2499         (objfpy_set_type_printers): Likewise.
2500
2501 2019-01-03  Tom Tromey  <tom@tromey.com>
2502
2503         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2504         (gdbpy_print_stack): Use gdbpy_err_fetch.
2505         * python/python-internal.h (class gdbpy_err_fetch): New class.
2506         (class gdbpy_enter) <m_error_type, m_error_value,
2507         m_error_traceback>: Remove.
2508         <m_error>: New member.
2509         (gdbpy_exception_to_string): Don't declare.
2510         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2511         * python/py-value.c (convert_value_from_python): Use
2512         gdbpy_err_fetch.
2513         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2514         gdbpy_exception_to_string.
2515         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2516         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2517         gdbpy_err_fetch.
2518
2519 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * linux-nat.c (delete_lwp_cleanup): Delete.
2522         (struct lwp_deleter): New struct.
2523         (lwp_info_up): New typedef.
2524         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2525         lwp_info_up.
2526
2527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2528
2529         * linux-fork.c (class scoped_switch_fork_info): New class.
2530         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2531
2532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2533
2534         * valops.c (find_overload_match): Remove use of null_cleanup, and
2535         calls to do_cleanups.
2536
2537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * compile/compile-cplus-types.c
2540         (compile_cplus_instance::decl_name): Handle changes to
2541         cp_func_name.
2542         * cp-support.c (cp_func_name): Update header comment, update
2543         return type.
2544         * cp-support.h (cp_func_name): Update return type in declaration.
2545         * valops.c (find_overload_match): Move temp_func local to top
2546         level of function and change its type.  Use temp_func to hold and
2547         delete temporary string obtained from cp_func_name.
2548
2549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2552         gdb::char_vector, remove cleanup, and update uses of `msg`.
2553
2554 2019-01-03  Jim Wilson  <jimw@sifive.com>
2555
2556         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2557
2558 2019-01-02  Tom Tromey  <tom@tromey.com>
2559
2560         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2561         (tdesc_parse_xml): Remove cleanups.
2562         * target-descriptions.h (make_cleanup_free_target_description):
2563         Don't declare.
2564         (target_desc_deleter): New struct.
2565         (target_desc_up): New typedef.
2566         * target-descriptions.c (target_desc_deleter::operator()): Rename
2567         from free_target_description.
2568         (make_cleanup_free_target_description): Remove.
2569
2570 2019-01-02  Tom Tromey  <tom@tromey.com>
2571
2572         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2573         constructor, destructor.
2574         (linespec_parser): Remove typedef.
2575         (~linespec_parser): Rename from linespec_parser_delete.
2576         (linespec_lex_to_end, linespec_complete_label)
2577         (linespec_complete): Update.
2578         (decode_line_full): Remove cleanups.
2579         (decode_line_1): Update.
2580
2581 2019-01-02  Tom Tromey  <tom@tromey.com>
2582
2583         * python/python-internal.h (inferior_to_inferior_object): Change
2584         return type.
2585         * python/py-exitedevent.c (create_exited_event_object): Update.
2586         * python/py-inferior.c (inferior_to_inferior_object): Return
2587         gdbpy_ref.
2588         (python_new_inferior, python_inferior_deleted)
2589         (thread_to_thread_object, delete_thread_object)
2590         (build_inferior_list, gdbpy_selected_inferior): Update.
2591         * python/py-infthread.c (create_thread_object): Update.  Also fail
2592         if inferior_to_inferior_object fails.
2593
2594 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2595
2596         * inferior.h (class inferior) <displaced_step_state>: New field.
2597         * infrun.h (struct displaced_step_state): Move here from
2598         infrun.c.  Initialize fields, add constructor.
2599         <inf>: Remove field.
2600         <reset>: New method.
2601         * infrun.c (struct displaced_step_inferior_state): Move to
2602         infrun.h.
2603         (displaced_step_inferior_states): Remove.
2604         (get_displaced_stepping_state): Adust.
2605         (displaced_step_in_progress_any_inferior): Adjust.
2606         (displaced_step_in_progress_thread): Adjust.
2607         (displaced_step_in_progress): Adjust.
2608         (add_displaced_stepping_state): Remove.
2609         (get_displaced_step_closure_by_addr): Adjust.
2610         (remove_displaced_stepping_state): Remove.
2611         (infrun_inferior_exit): Call displaced_step_state.reset.
2612         (use_displaced_stepping): Don't check for NULL.
2613         (displaced_step_prepare_throw): Call
2614         get_displaced_stepping_state.
2615         (displaced_step_fixup): Don't check for NULL.
2616         (prepare_for_detach): Don't check for NULL.
2617
2618 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2619
2620         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2621          in case of call that did not complete.
2622
2623 2019-01-02  Andrey Utkin  <autkin@undo.io>
2624
2625         * symfile.c (find_separate_debug_file): Fix search of debug files for
2626         remote debuggee.
2627
2628 2019-01-02  Tom Tromey  <tom@tromey.com>
2629
2630         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2631         indentation.
2632         * python/py-frame.c (frapy_older): Remove cast.
2633         (frapy_newer): Likewise.
2634         * python/py-breakpoint.c (local_setattro): Remove cast.
2635         * python/py-arch.c (archpy_name): Remove local variable.
2636         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2637
2638 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2639
2640         * unittests/basic_string_view/element_access/char/empty.cc:
2641         Fix year range in copyright header.
2642
2643 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2644
2645         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2646         Delete.
2647         <operator==>: Update with for removed field.
2648         <hash>: Likewise.
2649         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2650         <isa_features>: ...this.
2651         <abi_features>: New field.
2652         (riscv_isa_flen): Update comment.
2653         (riscv_abi_xlen): New declaration.
2654         (riscv_abi_flen): New declaration.
2655         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2656         isa_features.
2657         (riscv_abi_xlen): New function.
2658         (riscv_isa_flen): Update to get answer from isa_features.
2659         (riscv_abi_flen): New function.
2660         (riscv_has_fp_abi): Update to get answer from abi_features.
2661         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2662         xlen and flen.
2663         (riscv_call_info) <xlen, flen>: Update comment.
2664         (riscv_call_arg_struct): Remove invalid assertions
2665         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2666         is removed.
2667         (riscv_gdbarch_init): Gather isa features and abi features
2668         separately, ensure both match on the gdbarch when reusing an old
2669         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2670         a target with 64-bit float hardware.
2671
2672 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2673
2674         * source.c (search_command_helper): Stop reverse search
2675         when line 1 has been searched.
2676
2677 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2678
2679         * record-full.c (record_full_base_target::close): Rewrite
2680         record_full_core_buf_list free logic.
2681
2682 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2683
2684         * break-catch-syscall.c (print_one_catch_syscall): xfree
2685         the last text.
2686
2687 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2688
2689         * top.c (print_gdb_version): Update Copyright year in version
2690         message.
2691
2692 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2693
2694         Update copyright year range in all GDB files.
2695
2696 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2697
2698         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2699
2700 For older changes see ChangeLog-2018.
2701 \f
2702 Local Variables:
2703 mode: change-log
2704 left-margin: 8
2705 fill-column: 74
2706 version-control: never
2707 coding: utf-8
2708 End:
2709