gdb/ChangeLog

   1 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
   2
   3         * gnu-nat.c (gnu_nat_target::wait): Fix
   4         target_waitstatus_to_string call.
   5
   6 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * eval.c (evaluate_subexp_standard): Handle internal functions
   9         during Fortran function call handling.
  10
  11 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * NEWS: Mention new internal functions.
  14         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  15         (read_base_type): Use dwarf2_init_complex_target_type.
  16         * value.c (creal_internal_fn): New function.
  17         (cimag_internal_fn): New function.
  18         (_initialize_values): Register new internal functions.
  19
  20 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  21
  22         * infrun.c (stop_all_threads): If debug_infrun, always
  23         trace the wait status after wait_one, using
  24         target_waitstatus_to_string and target_pid_to_str.
  25         (handle_inferior_event): Replace various trace of
  26         wait status kind by a single trace.
  27         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
  28         wait status kind image by target_waitstatus_to_string.
  29         * target/waitstatus.c (target_waitstatus_to_string): Fix
  30         obsolete comment.
  31
  32 2019-04-01  Tom Tromey  <tromey@adacore.com>
  33
  34         PR symtab/23331:
  35         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  36
  37 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  38             Pedro Alves  <palves@redhat.com>
  39
  40         * top.c (quit_force): Call 'finalize_values'.
  41         * value.c (finalize_values): New function.
  42         * value.h (finalize_values): Declare.
  43
  44 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  45
  46         * NEWS: Announce $_gdb_major and $_gdb_minor.
  47
  48         * top.c (init_gdb_version_vars): New function.
  49         (gdb_init): Call init_gdb_version_vars.
  50
  51 2019-03-29  Tom Tromey  <tromey@adacore.com>
  52
  53         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  54         help text.  Remove dead code.
  55
  56 2019-03-29  Keith Seitz  <keiths@redhat.com>
  57
  58         From Siddhesh Poyarekar:
  59         * f-lang.h (f77_get_upperbound): Return LONGEST.
  60         (f77_get_lowerbound): Likewise.
  61         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  62         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  63         print them.
  64         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  65         plongest to format print it.
  66         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  67         (f77_get_upperbound): Likewise.
  68         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  69         LOWER_BOUND to LONGEST.
  70         (f77_create_arrayprint_offset_tbl): Likewise.
  71
  72 2019-03-29  Keith Seitz  <keiths@redhat.com>
  73
  74         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  75         %s/pulongest for TYPE_LENGTH instead of %d in format
  76         strings.
  77         * ada-typerint.c (ada_print_type): Likewise.
  78         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  79         * compile/compile-c-support.c (generate_register_struct): Likewise.
  80         * gdbtypes.c (recursive_dump_type): Likewise.
  81         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  82         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  83         instead of %d in format strings.
  84         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  85         to std::min to ULONGEST.
  86         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  87         instead of %d in format strings.
  88         * tracepoint.c (info_scope_command): Likewise.
  89         * typeprint.c (print_offset_data::update)
  90         (print_offset_data::finish): Likewise.
  91         * xtensa-tdep.c (xtensa_store_return_value)
  92         (xtensa_push_dummy_call): Likewise.
  93
  94 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  95
  96         * windows-nat.c (display_selector): Fixed format specifications
  97         for 64-bit Cygwin.
  98
  99 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 100
 101         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 102
 103 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 104
 105         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 106         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 107         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 108         (nios2_linux_init_abi): Install it.
 109
 110 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 111
 112         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 113
 114 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 115
 116         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 117
 118 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 119             Tom Tromey  <tromey@adacore.com>
 120
 121         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 122
 123 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 124
 125         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 126         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 127         method to compute the bounds of range types. Also print "[evaluated]"
 128         if the bounds' values come from a dynamic evaluation.
 129
 130 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 133         whitespace when pretty printing is on.
 134
 135 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 136
 137         * ppc-linux-nat.c: Add include.
 138
 139 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 140
 141         * NEWS: Mention AArch64 Pointer Authentication.
 142
 143 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 144
 145         * arm-linux-nat.c: Add include.
 146
 147 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 148
 149         * source-cache.c (source_cache::get_source_lines): Re-read
 150         fullname after calling open_source_file.
 151
 152 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 153
 154         * NEWS: Mention TLS support for FreeBSD.
 155
 156 2019-03-25  Tom Tromey  <tromey@adacore.com>
 157
 158         * minsyms.c (BUNCH_SIZE): Update comment.
 159         (~minimal_symbol_reader): Remove old comment.
 160         (compact_minimal_symbols): Update comment.
 161         (minimal_symbol_reader::install): Remove old comment.  Update
 162         other comments.
 163
 164 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 165
 166         * s390-linux-nat.c: Add include.
 167
 168 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 169
 170         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 171         Call linux_get_hwcap.
 172         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 173         Likewise.
 174         (aarch64_linux_get_hwcap): Remove function.
 175         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 176         declaration.
 177         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 178         linux_get_hwcap.
 179         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 180         * linux-tdep.c (linux_get_hwcap): Add function.
 181         (linux_get_hwcap2): Likewise.
 182         * linux-tdep.h (linux_get_hwcap): Add declaration.
 183         (linux_get_hwcap2): Likewise.
 184         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 185         (ppc_linux_get_hwcap2): Likewise.
 186         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 187         linux_get_hwcap.
 188         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 189         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 190         (ppc_linux_nat_target::read_description): Likewise.
 191         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 192         * s390-linux-nat.c: Likewise.
 193         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 194
 195 2019-03-24  Tom Tromey  <tom@tromey.com>
 196
 197         * ada-lang.c (standard_lookup): Simplify initialization.
 198         (ada_lookup_symbol_nonlocal): Simplify return.
 199         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 200         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 201         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 202         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 203         initialization.
 204         * solib.c (solib_global_lookup): Simplify.
 205         * symtab.c (null_block_symbol): Remove.
 206         (symbol_cache_lookup): Simplify returns.
 207         (lookup_language_this): Simplify returns.
 208         (lookup_symbol_aux): Simplify return.
 209         (lookup_local_symbol): Simplify returns.
 210         (lookup_global_symbol_from_objfile): Simplify return.
 211         (lookup_symbol_in_objfile_symtabs)
 212         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 213         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 214         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 215         * cp-namespace.c (cp_lookup_bare_symbol)
 216         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 217         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 218         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 219         (cp_lookup_symbol_via_imports): Simplify initialization.
 220         (find_symbol_in_baseclass): Likewise.
 221         * symtab.h (null_block_symbol): Remove.
 222         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 223         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 224         (d_lookup_symbol_module): Likewise.
 225         (find_symbol_in_baseclass): Simplify initialization.
 226
 227 2019-03-24  Tom Tromey  <tom@tromey.com>
 228
 229         * expression.h: Don't include symtab.h.
 230         (struct block): Forward declare.
 231
 232 2019-03-24  Tom Tromey  <tom@tromey.com>
 233
 234         * c-exp.y (typebase): Remove casts.
 235         * gdbtypes.c (lookup_unsigned_typename, )
 236         (lookup_signed_typename): Remove cast.
 237         * eval.c (parse_to_comma_and_eval): Remove cast.
 238         * parse.c (write_dollar_variable): Remove cast.
 239         * block.h (struct block) <superblock>: Now const.
 240         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 241         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 242         (map_block): Make "block" const.
 243         * symfile.h (struct quick_symbol_functions)
 244         <map_matching_symbols>: Constify block argument to "callback".
 245         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 246         const.
 247         (find_pc_sect_compunit_symtab): Make "b" const.
 248         (find_symbol_at_address): Likewise.
 249         (search_symbols): Likewise.
 250         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 251         (dw2_debug_names_lookup_symbol): Likewise.
 252         (dw2_map_matching_symbols): Update.
 253         * p-valprint.c (pascal_val_print): Remove "block".
 254         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 255         (aux_add_nonlocal_symbols): Make "block" const.
 256         (resolve_subexp): Remove cast.
 257         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 258         const.
 259         (iterate_over_file_blocks): Likewise.
 260         * f-exp.y (%union) <bval>: Remove.
 261         * coffread.c (patch_opaque_types): Make "b" const.
 262         * spu-tdep.c (spu_catch_start): Make "block" const.
 263         * c-valprint.c (print_unpacked_pointer): Remove "block".
 264         * symmisc.c (dump_symtab_1): Make "b" const.
 265         (block_depth): Make "block" const.
 266         * d-exp.y (%union) <bval>: Remove.
 267         * cp-support.h (cp_lookup_rtti_type): Update.
 268         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 269         * psymtab.c (psym_lookup_symbol): Make "block" const.
 270         (maintenance_check_psymtabs): Make "b" const.
 271         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 272         (enumerate_locals, enumerate_args): Update.
 273         * python/py-symtab.c (stpy_global_block): Make "block" const.
 274         (stpy_static_block): Likewise.
 275         * inline-frame.c (block_starting_point_at): Make "new_block"
 276         const.
 277         * block.c (find_block_in_blockvector): Make return type const.
 278         (blockvector_for_pc_sect): Make "b" const.
 279         (find_block_in_blockvector): Make "b" const.
 280
 281 2019-03-23  Tom Tromey  <tom@tromey.com>
 282
 283         * varobj.c (varobj_create): Update.
 284         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 285         * printcmd.c (display_command, do_one_display): Don't reset
 286         innermost_block.
 287         * parser-defs.h (enum innermost_block_tracker_type): Move to
 288         expression.h.
 289         (innermost_block): Update comment.
 290         * parse.c (parse_exp_1): Add tracker_types parameter.
 291         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 292         tracker_types parameter.  Reset innermost_block.
 293         (parse_exp_in_context): Remove.
 294         (parse_expression_for_completion): Update.
 295         * objfiles.c (~objfile): Don't reset expression_context_block or
 296         innermost_block.
 297         * expression.h (enum innermost_block_tracker_type): Move from
 298         parser-defs.h.
 299         (parse_exp_1): Add tracker_types parameter.
 300         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 301         reset innermost_block.
 302
 303 2019-03-23  Tom Tromey  <tom@tromey.com>
 304
 305         * objfiles.h: Include bcache.h.
 306
 307 2019-03-23  Tom Tromey  <tom@tromey.com>
 308
 309         * linespec.c (get_current_search_block): Use
 310         scoped_restore_current_language.
 311         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 312
 313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 314             Jiong Wang  <jiong.wang@arm.com>
 315
 316         * aarch64-linux-tdep.c
 317         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 318         section.
 319         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 320
 321 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 322             Jiong Wang  <jiong.wang@arm.com>
 323
 324         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 325         instructions.
 326         (aarch64_analyze_prologue_test): Add PACIASP test.
 327         (aarch64_prologue_prev_register): Unmask PC value.
 328
 329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 330             Jiong Wang  <jiong.wang@arm.com>
 331
 332         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 333         (aarch64_dwarf2_prev_register): Unmask PC value.
 334         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 335         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 336         DW_CFA_AARCH64_negate_ra_state.
 337         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 338
 339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 340             Jiong Wang  <jiong.wang@arm.com>
 341
 342         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 343         registers.
 344         (aarch64_pseudo_register_name): Likewise.
 345         (aarch64_pseudo_register_type): Likewise.
 346         (aarch64_pseudo_register_reggroup_p): Likewise.
 347         (aarch64_gdbarch_init): Add pauth registers.
 348         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 349         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 350         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 351         (struct gdbarch_tdep): Add regnum for ra_state.
 352
 353 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 354             Jiong Wang  <jiong.wang@arm.com>
 355
 356         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 357
 358 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 359             Jiong Wang  <jiong.wang@arm.com>
 360
 361         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 362         function.
 363         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 364         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 365         (aarch64_gdbarch_init): Add puth registers.
 366         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 367         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 368         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 369
 370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 371             Jiong Wang  <jiong.wang@arm.com>
 372
 373         * aarch64-linux-nat.c
 374         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 375         * aarch64-linux-tdep.c
 376         (aarch64_linux_core_read_description): Likewise.
 377         (aarch64_linux_get_hwcap): New function.
 378         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 379         (aarch64_linux_get_hwcap): New declaration.
 380
 381 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 382             Jiong Wang  <jiong.wang@arm.com>
 383
 384         * aarch64-linux-nat.c
 385         (aarch64_linux_nat_target::read_description): Add pauth param.
 386         * aarch64-linux-tdep.c
 387         (aarch64_linux_core_read_description): Likewise.
 388         * aarch64-tdep.c (struct target_desc): Add in pauth.
 389         (aarch64_read_description): Add pauth param.
 390         (aarch64_gdbarch_init): Likewise.
 391         * aarch64-tdep.h (aarch64_read_description): Likewise.
 392         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 393         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 394         * features/Makefile: Add new files.
 395         * features/aarch64-pauth.c: New file.
 396         * features/aarch64-pauth.xml: New file.
 397
 398 2019-03-20  Tom Tromey  <tromey@adacore.com>
 399
 400         * infrun.c (handle_inferior_event): Rename from
 401         handle_inferior_event_1.  Create a scoped_value_mark.
 402         (handle_inferior_event): Remove.
 403
 404 2019-03-19  Tom Tromey  <tromey@adacore.com>
 405
 406         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 407         * infrun.h (print_stop_event): Add "displays" parameter.
 408         * infrun.c (print_stop_event): Add "displays" parameter.
 409
 410 2019-03-19  Pedro Alves  <palves@redhat.com>
 411
 412         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 413         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 414         to -1.  Fix TABs vs spaces.
 415         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 416         * tui/tui-out.h (tui_ui_out) Add intro comments.
 417         <m_line, m_start_of_line>: In-class initialize, and add describing
 418         comment.
 419
 420 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 421
 422         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 423         variable names.
 424         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 425
 426 2019-03-18  Pedro Alves  <palves@redhat.com>
 427             Eli Zaretskii <eliz@gnu.org>
 428
 429         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 430         m_line and m_start_of_line.
 431
 432 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 433
 434         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 435         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 436         it returns a newline.  This fixes a regression in TU mode, whereby
 437         the next line is output on the same screen line as the user input.
 438
 439 2019-03-18  Tom Tromey  <tromey@adacore.com>
 440
 441         * minsyms.c (minimal_symbol_reader::install): Remove call to
 442         obstack_blank.
 443
 444 2019-03-18  Pedro Alves  <palves@redhat.com>
 445
 446         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 447         New globals.
 448         (apply_style): New, factored out from ...
 449         (apply_ansi_escape): ... this.  Handle reverse video mode.
 450         (tui_set_reverse_mode): New function.
 451         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 452         * tui/tui-winsource.c (tui_show_source_line): Use
 453         tui_set_reverse_mode instead of setting A_STANDOUT.
 454         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 455         New setter methods.
 456
 457 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 458
 459         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 460         Handle tabs.
 461
 462 2019-03-18  Tom Tromey  <tromey@adacore.com>
 463
 464         * ada-lang.c (empty_array): Add "high" parameter.
 465         (ada_evaluate_subexp): Update.
 466
 467 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 468
 469         * unittests/string_view-selftests.c: Define
 470         _initialize_string_view_selftests unconditionally.
 471
 472 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 473
 474         PR gdb/24350
 475         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 476
 477 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 478
 479         PR gdb/24351
 480         * windows-nat.c (display_selector): Fix format specifiers.
 481
 482 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 483
 484         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 485         tui_refill_source_window instead of tui_refresh_win, to update the
 486         current execution line.  This fixes redisplay of the current line
 487         when stepping through the code with "next" or "step".
 488
 489 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 490
 491         * source-cache.c (source_cache::get_source_lines): Call
 492         find_source_lines to initialize s->nlines.  This fixes vertical
 493         scrolling of TUI source window when the DOWN arrow is pressed.
 494
 495 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 496
 497         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 498         linux-thread-db.c (_initialize_thread_db): Likewise.
 499
 500 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 501
 502         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 503         wclrtoeol in tui_show_source_line".  This reverts changes made in
 504         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 505
 506 2019-03-15  Tom Tromey  <tom@tromey.com>
 507
 508         * symtab.h (struct minimal_symbol): Derive from
 509         general_symbol_info.
 510         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 511         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 512         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 513         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 514         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 515         (MSYMBOL_SEARCH_NAME): Update.
 516         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 517         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 518         * minsyms.c (minimal_symbol_reader::record_full): Update.
 519
 520 2019-03-15  Tom Tromey  <tom@tromey.com>
 521
 522         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 523
 524 2019-03-15  Tom Tromey  <tom@tromey.com>
 525
 526         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 527         unique_xmalloc_ptr.
 528         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 529         Update.
 530         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 531         (build_minimal_symbol_hash_tables)
 532         (minimal_symbol_reader::install): Update.
 533
 534 2019-03-15  Tom Tromey  <tom@tromey.com>
 535
 536         * symtab.c (create_demangled_names_hash): Update.
 537         (symbol_set_names): Update.
 538         * objfiles.h (struct objfile_per_bfd_storage)
 539         <demangled_names_hash>: Now an htab_up.
 540         * objfiles.c (objfile_per_bfd_storage): Simplify.
 541
 542 2019-03-15  Tom Tromey  <tom@tromey.com>
 543
 544         * objfiles.h (struct objfile_per_bfd_storage): Declare
 545         destructor.
 546         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 547         New.
 548         (get_objfile_bfd_data): Use new.  Don't initialize
 549         language_of_main.
 550         (free_objfile_per_bfd_storage): Remove.
 551         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 552
 553 2019-03-15  Tom Tromey  <tom@tromey.com>
 554
 555         * symfile.c (reread_symbols): Update.
 556         * objfiles.c (objfile::objfile): Update.
 557         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 558         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 559         comment.
 560         (minimal_symbol_reader::install): Update.
 561         (terminate_minimal_symbol_table): Remove.
 562         * jit.c (jit_object_close_impl): Update.
 563
 564 2019-03-15  Tom Tromey  <tom@tromey.com>
 565
 566         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 567         initializations.
 568
 569 2019-03-15  Tom Tromey  <tom@tromey.com>
 570
 571         * objfiles.h (struct objfile_per_bfd_storage)
 572         <demangled_hash_languages>: Now a bitset.
 573         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 574         (lookup_minimal_symbol): Update.
 575
 576 2019-03-15  Tom Tromey  <tom@tromey.com>
 577
 578         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 579         Don't return the symbol.
 580         * coffread.c (record_minimal_symbol): Use record_full.
 581
 582 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 583
 584         The MS-Windows port of ncurses fails to switch to a color pair if
 585         one or both of the colors are the implicit default colors.  This
 586         change records the default colors when TUI is initialized, and
 587         then specifies them explicitly when a color pair uses the default
 588         colors.  This allows color styling in TUI mode on MS-Windows.
 589
 590         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 591         ncurses_norm_attr.
 592         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 593         colors in ncurses_norm_attr.
 594         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 595         "none", replace it with the default color recorded in
 596         ncurses_norm_attr.
 597
 598 2019-03-14  Tom Tromey  <tromey@adacore.com>
 599
 600         * source-cache.h (class source_cache) <get_source_lines>: Return
 601         std::string.
 602         * source-cache.c (source_cache::extract_lines): Handle case where
 603         first_pos==npos.  Return std::string.
 604         (source_cache::get_source_lines): Update.
 605
 606 2019-03-14  Tom Tromey  <tromey@adacore.com>
 607
 608         * NEWS: Add item for "style sources" commands.
 609         * source-cache.c (source_cache::get_source_lines): Check
 610         source_styling.
 611         * cli/cli-style.c (source_styling): New global.
 612         (_initialize_cli_style): Add "style sources" commands.
 613         (show_style_sources): New function.
 614         * cli/cli-style.h (source_styling): Declare.
 615
 616 2019-03-14  Pedro Alves  <palves@redhat.com>
 617             Tom Tromey  <tromey@adacore.com>
 618
 619         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 620         * tui/tui-winsource.c (tui_refill_source_window): New function,
 621         from...
 622         (tui_horizontal_source_scroll): ... here.  Move some logic.
 623         * cli/cli-style.c (set_style_enabled): Notify new observable.
 624         * tui/tui-hooks.c (tui_redisplay_source): New function.
 625         (tui_attach_detach_observers): Attach or detach
 626         tui_redisplay_source.
 627         * observable.h (source_styling_changed): New observable.
 628         * observable.c: Define source_styling_changed observable.
 629
 630 2019-03-13  Tom Tromey  <tromey@adacore.com>
 631
 632         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 633         (i386_gnu_nat_target::store_registers): Update.
 634         * target-debug.h (target_debug_print_std_string): New macro.
 635         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 636         * windows-tdep.c (display_one_tib): Update.
 637         * tui/tui-stack.c (tui_make_status_line): Update.
 638         * top.c (print_inferior_quit_action): Update.
 639         * thread.c (thr_try_catch_cmd): Update.
 640         (add_thread_with_info): Update.
 641         (thread_target_id_str): Update.
 642         (thr_try_catch_cmd): Update.
 643         (thread_command): Update.
 644         (thread_find_command): Update.
 645         * record-btrace.c (record_btrace_target::info_record)
 646         (record_btrace_resume_thread, record_btrace_target::resume)
 647         (record_btrace_cancel_resume, record_btrace_step_thread)
 648         (record_btrace_target::wait, record_btrace_target::wait)
 649         (record_btrace_target::wait, record_btrace_target::stop): Update.
 650         * progspace.c (print_program_space): Update.
 651         * process-stratum-target.c
 652         (process_stratum_target::thread_address_space): Update.
 653         * linux-fork.c (linux_fork_mourn_inferior)
 654         (detach_checkpoint_command, info_checkpoints_command)
 655         (linux_fork_context): Update.
 656         (linux_fork_detach): Update.
 657         (class scoped_switch_fork_info): Update.
 658         (delete_checkpoint_command): Update.
 659         * infrun.c (follow_fork_inferior): Update.
 660         (follow_fork_inferior): Update.
 661         (proceed_after_vfork_done): Update.
 662         (handle_vfork_child_exec_or_exit): Update.
 663         (follow_exec): Update.
 664         (displaced_step_prepare_throw): Update.
 665         (displaced_step_restore): Update.
 666         (start_step_over): Update.
 667         (resume_1): Update.
 668         (clear_proceed_status_thread): Update.
 669         (proceed): Update.
 670         (print_target_wait_results): Update.
 671         (do_target_wait): Update.
 672         (context_switch): Update.
 673         (stop_all_threads): Update.
 674         (restart_threads): Update.
 675         (finish_step_over): Update.
 676         (handle_signal_stop): Update.
 677         (switch_back_to_stepped_thread): Update.
 678         (keep_going_pass_signal): Update.
 679         (print_exited_reason): Update.
 680         (normal_stop): Update.
 681         * inferior.c (inferior_pid_to_str): Change return type.
 682         (print_selected_inferior): Update.
 683         (add_inferior): Update.
 684         (detach_inferior): Update.
 685         * dummy-frame.c (fprint_dummy_frames): Update.
 686         * dcache.c (dcache_info_1): Update.
 687         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 688         (btrace_fetch, btrace_clear): Update.
 689         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 690         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 691         type.
 692         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 693         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 694         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 695         * gdbarch.c, gdbarch.h: Rebuild.
 696         * gdbarch.sh (core_pid_to_str): Change return type.
 697         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 698         return type.
 699         (windows_nat_target::pid_to_str): Change return type.
 700         (windows_delete_thread): Update.
 701         (windows_nat_target::attach): Update.
 702         (windows_nat_target::files_info): Update.
 703         * target-delegates.c: Rebuild.
 704         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 705         return type.
 706         (sol_thread_target::pid_to_str): Change return type.
 707         * remote.c (class remote_target) <pid_to_str>: Change return
 708         type.
 709         (remote_target::pid_to_str): Change return type.
 710         (extended_remote_target::attach, remote_target::remote_stop_ns)
 711         (remote_target::remote_notif_remove_queued_reply)
 712         (remote_target::push_stop_reply, remote_target::disable_btrace):
 713         Update.
 714         (extended_remote_target::attach): Update.
 715         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 716         type.
 717         (gdbsim_target::pid_to_str): Change return type.
 718         * ravenscar-thread.c (struct ravenscar_thread_target)
 719         <pid_to_str>: Change return type.
 720         (ravenscar_thread_target::pid_to_str): Change return type.
 721         * procfs.c (class procfs_target) <pid_to_str>: Change return
 722         type.
 723         (procfs_target::pid_to_str): Change return type.
 724         (procfs_target::attach): Update.
 725         (procfs_target::detach): Update.
 726         (procfs_target::fetch_registers): Update.
 727         (procfs_target::store_registers): Update.
 728         (procfs_target::wait): Update.
 729         (procfs_target::files_info): Update.
 730         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 731         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 732         return type.
 733         (nto_procfs_target::pid_to_str): Change return type.
 734         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 735         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 736         return type.
 737         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 738         (exit_lwp): Update.
 739         (attach_proc_task_lwp_callback, get_detach_signal)
 740         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 741         (linux_nat_target::resume, wait_lwp, stop_callback)
 742         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 743         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 744         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 745         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 746         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 747         type.
 748         (inf_ptrace_target::attach): Update.
 749         (inf_ptrace_target::files_info): Update.
 750         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 751         type.
 752         (go32_nat_target::pid_to_str): Change return type.
 753         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 754         (gnu_nat_target::wait): Update.
 755         (gnu_nat_target::wait): Update.
 756         (gnu_nat_target::resume): Update.
 757         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 758         (fbsd_nat_target::wait): Update.
 759         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 760         type.
 761         (darwin_nat_target::attach): Update.
 762         * corelow.c (class core_target) <pid_to_str>: Change return type.
 763         (core_target::pid_to_str): Change return type.
 764         * target.c (normal_pid_to_str): Change return type.
 765         (default_pid_to_str): Likewise.
 766         (target_pid_to_str): Change return type.
 767         (target_translate_tls_address): Update.
 768         (target_announce_detach): Update.
 769         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 770         return type.
 771         (bsd_uthread_target::pid_to_str): Change return type.
 772         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 773         type.
 774         (bsd_kvm_target::pid_to_str): Change return type.
 775         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 776         return type.
 777         (aix_thread_target::pid_to_str): Change return type.
 778         * target.h (struct target_ops) <pid_to_str>: Change return type.
 779         (target_pid_to_str, normal_pid_to_str): Likewise.
 780         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 781         type.
 782         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 783         type.
 784         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 785         return type.
 786         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 787         type.
 788         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 789         type.
 790         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 791         return type.
 792
 793 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 794
 795         * NEWS: Mention that the new default MI version is 3.  Mention
 796         changes to the output of commands and events that deal with
 797         multi-location breakpoints.
 798         * breakpoint.c: Include "mi/mi-out.h".
 799         (print_one_breakpoint): Change output syntax if using MI version
 800         >= 3.
 801         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 802         New.
 803         (mi_multi_location_breakpoint_output_fixed): New.
 804         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 805         (mi_cmd_fix_multi_location_breakpoint_output): New.
 806         (mi_multi_location_breakpoint_output_fixed): New.
 807         * mi/mi-cmds.c (mi_cmds): Register command
 808         -fix-multi-location-breakpoint-output.
 809         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 810         interpreter "mi".
 811
 812 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 813
 814         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 815         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 816         instantiate mi_ui_out based on interpreter name.
 817         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 818         * mi/mi-main.c (mi_load_progress): Likewise.
 819
 820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 821
 822         * NEWS: Combine separate "New targets" sections for 8.3.
 823
 824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 825
 826         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 827         (ppcfbsd_init_abi): Install gdbarch
 828         "fetch_tls_load_module_address" and "get_thread_local_address"
 829         methods.
 830
 831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 832
 833         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 834         (riscv_fbsd_init_abi): Install gdbarch
 835         "fetch_tls_load_module_address" and "get_thread_local_address"
 836         methods.
 837
 838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 839
 840         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 841         (i386fbsd_init_abi): Install gdbarch
 842         "fetch_tls_load_module_address" and "get_thread_local_address"
 843         methods.
 844
 845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 846
 847         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 848         (amd64fbsd_init_abi): Install gdbarch
 849         "fetch_tls_load_module_address" and "get_thread_local_address"
 850         methods.
 851
 852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 853
 854         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 855         (struct fbsd_pspace_data): New type.
 856         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 857         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 858         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 859         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 860         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 861
 862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 863
 864         * gdbtypes.c (lookup_struct_elt): New function.
 865         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 866         * gdbtypes.h (struct struct_elt): New type.
 867         (lookup_struct_elt): New prototype.
 868
 869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 870
 871         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 872         remove disabled code block.
 873
 874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 875
 876         * gdbarch.sh (get_thread_local_address): New method.
 877         * gdbarch.h, gdbarch.c: Regenerate.
 878         * target.c (target_translate_tls_address): Use
 879         gdbarch_get_thread_local_address if present instead of
 880         target::get_thread_local_address.
 881
 882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 883
 884         * target.h (target::get_thread_local_address): Update comment.
 885
 886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 887
 888         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 889         objfile->separate_debug_objfile_backlink if not NULL.
 890
 891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 892
 893         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 894         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 895         (amd64bsd_store_inferior_registers): Likewise.
 896         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 897         Enable segment base registers.
 898         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 899         PT_GETFSBASE and PT_GETGSBASE.
 900         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 901         PT_SETGSBASE.
 902         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 903         segment base registers.
 904         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 905
 906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 907
 908         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 909         Update calls to i386_target_description to add 'segments'
 910         parameter.
 911         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 912         add segment base registers.
 913         * arch/i386.c (i386_create_target_description): Add 'segments'
 914         parameter to enable segment base registers.
 915         * arch/i386.h (i386_create_target_description): Likewise.
 916         * features/i386/32bit-segments.xml: New file.
 917         * features/i386/32bit-segments.c: Generate.
 918         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 919         call to i386_target_description to add 'segments' parameter.
 920         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 921         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 922         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 923         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 924         if feature is present.
 925         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 926         Add 'segments' parameter to call to i386_target_description.
 927         (i386_target_description): Add 'segments' parameter to enable
 928         segment base registers.
 929         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 930         to call to i386_target_description.
 931         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 932         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 933         Define I386_NUM_REGS.
 934         (i386_target_description): Add 'segments' parameter to enable
 935         segment base registers.
 936
 937 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 938
 939         PR/24325
 940         * source-cache.c: #undef open and close, to avoid unresolved
 941         externals during linking.
 942
 943 2019-03-12  Tom Tromey  <tromey@adacore.com>
 944
 945         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 946         const.  Add initializers.
 947         (_initialize_remote): Don't initialize ptid globals.
 948
 949 2019-03-12  Pedro Alves  <palves@redhat.com>
 950
 951         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 952
 953 2019-03-12  Pedro Alves  <palves@redhat.com>
 954
 955         * cp-name-parser.y (main): Remove unused 'len' variable.
 956
 957 2019-03-12  Tom Tromey  <tromey@adacore.com>
 958
 959         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 960         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 961
 962 2019-03-12  Tom Tromey  <tromey@adacore.com>
 963
 964         * linux-nat.c (iterate_over_lwps): Update.
 965         (stop_callback): Remove parameter.
 966         (stop_wait_callback, detach_callback, resume_set_callback)
 967         (select_singlestep_lwp_callback, set_ignore_sigint)
 968         (status_callback, resumed_callback, resume_clear_callback)
 969         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 970         data parameter.
 971         (linux_nat_target::detach, linux_nat_target::resume)
 972         (linux_stop_and_wait_all_lwps, select_event_lwp)
 973         (linux_nat_filter_event, linux_nat_wait_1)
 974         (linux_nat_target::kill, linux_nat_target::stop)
 975         (linux_nat_target::stop): Update.
 976         (linux_nat_resume_callback): Change type.
 977         (resume_stopped_resumed_lwps, count_events_callback)
 978         (select_event_lwp_callback): Likewise.
 979         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 980         * arm-linux-nat.c (struct update_registers_data): Remove.
 981         (update_registers_callback): Change type.
 982         (arm_linux_insert_hw_breakpoint1): Update.
 983         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 984         parameter.
 985         (x86_linux_dr_set_addr): Update.
 986         (x86_linux_dr_set_control): Update.
 987         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 988         (iterate_over_lwps): Use gdb::function_view.
 989         * nat/aarch64-linux-hw-point.c (struct
 990         aarch64_dr_update_callback_param): Remove.
 991         (debug_reg_change_callback): Change type.
 992         (aarch64_notify_debug_reg_change): Update.
 993         * s390-linux-nat.c (s390_refresh_per_info): Update.
 994
 995 2019-03-11  Tom Tromey  <tromey@adacore.com>
 996
 997         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 998         redundant assignment to "this_cu".
 999
1000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1001
1002         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1003
1004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1005
1006         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1007         from...
1008         (rank_one_type): ... this.
1009
1010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1011
1012         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1013         from...
1014         (rank_one_type): ... this.
1015
1016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1017
1018         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1019         from...
1020         (rank_one_type): ... this.
1021
1022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1023
1024         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1025         from...
1026         (rank_one_type): ... this.
1027
1028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1029
1030         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1031         from...
1032         (rank_one_type): ... this.
1033
1034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1035
1036         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1037         from...
1038         (rank_one_type): ... this.
1039
1040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1041
1042         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1043         from...
1044         (rank_one_type): ... this.
1045
1046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1047
1048         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1049         from...
1050         (rank_one_type): ... this.
1051
1052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1053
1054         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1055         from...
1056         (rank_one_type): ... this.
1057
1058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1059
1060         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1061         from...
1062         (rank_one_type): ... this.
1063
1064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1065
1066         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1067         from...
1068         (rank_one_type): ... this.
1069
1070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1071
1072         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1073         from...
1074         (rank_one_type): ... this.
1075
1076 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1077
1078         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1079         inferior-events' shows the example events.
1080
1081 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1082
1083         Support styling on native MS-Windows console
1084
1085         PR/24315
1086         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1087         on MS-Windows if $TERM is not defined.
1088
1089         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1090
1091         * posix-hdep.c (gdb_console_fputs):
1092         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1093         functions.
1094         * ui-file.h (gdb_console_fputs): Add prototype.
1095
1096         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1097         back to fputs only if the former returns zero.
1098
1099 2019-03-07  Tom Tromey  <tom@tromey.com>
1100
1101         * symmisc.c (print_symbol_bcache_statistics): Update.
1102         (print_objfile_statistics): Update.
1103         * symfile.c (allocate_symtab): Update.
1104         * stabsread.c: Don't include bcache.h.
1105         * psymtab.h (struct psymbol_bcache): Don't declare.
1106         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1107         (psymbol_bcache_init, psymbol_bcache_free)
1108         (psymbol_bcache_get_bcache): Don't declare.
1109         * psymtab.c (struct psymbol_bcache): Remove.
1110         (psymtab_storage::psymtab_storage): Update.
1111         (psymtab_storage::~psymtab_storage): Update.
1112         (psymbol_bcache_init, psymbol_bcache_free)
1113         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1114         (add_psymbol_to_bcache): Update.
1115         (allocate_psymtab): Update.
1116         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1117         macro_cache>: No longer pointers.
1118         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1119         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1120         * macrotab.c (macro_bcache): Update.
1121         * macroexp.c: Don't include bcache.h.
1122         * gdbtypes.c (check_types_worklist): Update.
1123         (types_deeply_equal): Remove TRY/CATCH.  Update.
1124         * elfread.c (elf_symtab_read): Update.
1125         * dwarf2read.c: Don't include bcache.h.
1126         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1127         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1128         (print_bcache_statistics, bcache_memory_used): Don't declare.
1129         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1130         methods.  Rename all data members.
1131         * bcache.c (struct bcache): Move to bcache.h.
1132         (bcache::expand_hash_table): Rename from expand_hash_table.
1133         (bcache): Remove.
1134         (bcache::insert): Rename from bcache_full.
1135         (bcache::compare): Rename from bcache_compare.
1136         (bcache_xmalloc): Remove.
1137         (bcache::~bcache): Rename from bcache_xfree.
1138         (bcache::print_statistics): Rename from print_bcache_statistics.
1139         (bcache::memory_used): Rename from bcache_memory_used.
1140
1141 2019-03-07  Pedro Alves  <palves@redhat.com>
1142
1143         * infrun.c (normal_stop): Also check for
1144         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1145
1146 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * f-lang.c (value_from_host_double): Moved to...
1149         * value.c (value_from_host_double): ...here.
1150         * value.h (value_from_host_double): Declare.
1151         * guile/scm-math.c (vlscm_convert_typed_number): Use
1152         value_from_host_double.
1153         (vlscm_convert_number): Likewise.
1154         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1155         * python/py-value.c (convert_value_from_python): Likewise.
1156
1157 2019-03-06  Tom Tromey  <tom@tromey.com>
1158
1159         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1160
1161 2019-03-06  Tom Tromey  <tom@tromey.com>
1162
1163         * utils.h (free_current_contents): Don't declare.
1164         * utils.c (free_current_contents): Remove.
1165
1166 2019-03-06  Tom Tromey  <tom@tromey.com>
1167
1168         * top.c (quit_force): Update.
1169         * main.c (captured_command_loop): Update.
1170         * common/new-op.c (operator new): Update.
1171         * common/common-exceptions.c (struct catcher)
1172         <save_cleanup_chain>: Remove member.
1173         (exceptions_state_mc_init): Update.
1174         (exception_try_scope_entry): Return nullptr.
1175         (exception_try_scope_exit, exception_rethrow)
1176         (throw_exception_sjlj, throw_exception_cxx): Update.
1177         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1178         (all_cleanups, do_cleanups, discard_cleanups)
1179         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1180         (restore_cleanups, restore_final_cleanups): Don't declare.
1181         (do_final_cleanups): Remove parameter.
1182         * common/cleanups.c (cleanup_chain, make_cleanup)
1183         (make_cleanup_dtor, all_cleanups, do_cleanups)
1184         (discard_my_cleanups, discard_cleanups)
1185         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1186         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1187         (null_cleanup): Remove.
1188         (do_final_cleanups): Remove parameter.
1189
1190 2019-03-06  Tom Tromey  <tom@tromey.com>
1191
1192         * remote.c (remote_target::remote_parse_stop_reply): Use
1193         unique_xmalloc_ptr.
1194
1195 2019-03-06  Tom Tromey  <tom@tromey.com>
1196
1197         * stabsread.c (struct stabs_field_info): Rename from field_info.
1198         <list, fnlist>: Add initializers.
1199         <obstack>: New member.
1200         (read_member_functions, read_struct_fields, read_baseclasses):
1201         Allocate on obstack.  Don't use cleanups.
1202         (read_one_struct_field, read_member_functions, read_struct_fields)
1203         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1204         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1205         (read_struct_type): Update.
1206
1207 2019-03-06  Tom Tromey  <tom@tromey.com>
1208
1209         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1210         * common/filestuff.h (make_cleanup_close): Don't declare.
1211         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1212         Remove.
1213
1214 2019-03-06  Tom Tromey  <tom@tromey.com>
1215
1216         * solib-aix.c: Use make_scope_exit.
1217
1218 2019-03-06  Tom Tromey  <tom@tromey.com>
1219
1220         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1221         Use make_scope_exit.
1222
1223 2019-03-06  Tom Tromey  <tom@tromey.com>
1224
1225         * solib-svr4.c (disable_probes_interface): Remove parameter.
1226         (svr4_handle_solib_event): Use make_scope_exit.
1227
1228 2019-03-06  Tom Tromey  <tom@tromey.com>
1229
1230         * remote.c (struct stop_reply_deleter): Remove.
1231         (stop_reply_up): Update.
1232         (struct stop_reply): Derive from notif_event.  Don't typedef.
1233         <regcache>: Now a std::vector.
1234         (stop_reply_xfree): Remove.
1235         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1236         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1237         (remote_target::discard_pending_stop_replies): Use delete.
1238         (remote_target::remote_parse_stop_reply): Update.
1239         (remote_target::process_stop_reply): Update.
1240         * remote-notif.h (struct notif_event): Add virtual destructor.
1241         Remove "dtr" member.
1242         (struct notif_client) <alloc_event>: Return a unique_ptr.
1243         (notif_event_xfree): Don't declare.
1244         (notif_event_up): New typedef.
1245         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1246         (notif_event_xfree, do_notif_event_xfree): Remove.
1247         (remote_notif_state_xfree): Update.
1248
1249 2019-03-06  Tom Tromey  <tom@tromey.com>
1250
1251         * infrun.c (displaced_step_clear_cleanup): Now a
1252         forward_scope_exit type.
1253         (displaced_step_prepare_throw): Update.
1254         (displaced_step_fixup): Update.
1255
1256 2019-03-06  Tom Tromey  <tom@tromey.com>
1257
1258         * inferior.h (class inferior): Update comment.
1259         * gdbthread.h (class thread_info): Update comment.
1260
1261 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1262             Tom Tromey  <tom@tromey.com>
1263
1264         * stabsread.h (struct stab_section_list): Remove.
1265         (coffstab_build_psymtabs): Update.
1266         * dbxread.c (symbuf_sections): Now a std::vector.
1267         (sect_idx): New global.
1268         (fill_symbuf): Update.
1269         (coffstab_build_psymtabs): Change type of stabsects parameter.
1270         Update.
1271         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1272         std::vector.
1273         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1274         (coff_locate_sections): Update.
1275         (coff_symfile_read): Remove cleanups.  Update.
1276         (init_stringtab): Add storage parameter.
1277         (free_stringtab, free_stringtab_cleanup): Remove.
1278         (init_lineno): Add storage parameter.
1279         (free_linetab, free_linetab_cleanup): Remove.
1280
1281 2019-03-06  Pedro Alves  <palves@redhat.com>
1282
1283         * linux-fork.c (fork_info::clobber_regs): Delete.
1284         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1285         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1286         comment.  Adjust.
1287         (scoped_switch_fork_info::scoped_switch_fork_info)
1288         (checkpoint_command, linux_fork_context): Adjust
1289         fork_save_infrun_state calls.
1290
1291 2019-03-06  Pedro Alves  <palves@redhat.com>
1292
1293         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1294         (inf_has_multiple_threads): Return 'bool' and rewrite using
1295         inferior_info::threads().
1296
1297 2019-03-06  Pedro Alves  <palves@redhat.com>
1298
1299         * linux-fork.c: Include <list>.
1300         (fork_list): Now a std::list instance.
1301         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1302         (forks_exist_p, find_last_fork): Adjust.
1303         (new_fork): Delete.
1304         (one_fork_p): New.
1305         (add_fork): Adjust.
1306         (free_fork): Delete, folded into fork_info::~fork_info().
1307         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1308         Adjust.
1309         (init_fork_list): Delete.
1310         (linux_fork_killall, linux_fork_mourn_inferior)
1311         (linux_fork_detach, info_checkpoints_command): Adjust.
1312         (_initialize_linux_fork): No longer call init_fork_list.
1313
1314 2019-03-06  Pedro Alves  <palves@redhat.com>
1315
1316         * linux-fork.c (new_fork): New, split out of ...
1317         (add_fork): ... this.  Return void.  Move "first fork" special
1318         case from here, to ...
1319         (checkpoint_command): ... here.
1320         * linux-linux.h (add_fork): Return void.
1321
1322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1325
1326 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1327             Chris January  <chris.january@arm.com>
1328             David Lecomber  <david.lecomber@arm.com>
1329
1330         * f-exp.y: New token, UNOP_INTRINSIC.
1331         (exp): New pattern using UNOP_INTRINSIC token.
1332         (f77_keywords): Add 'abs' keyword.
1333         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1334         (value_from_host_double): New function.
1335         (evaluate_subexp_f): Support UNOP_ABS.
1336
1337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1340         types.
1341
1342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1345         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1346         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1347
1348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1349
1350         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1351
1352 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1353             Chris January  <chris.january@arm.com>
1354
1355         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1356         * f-exp.y: Define 'KIND' token.
1357         (exp): New pattern for KIND expressions.
1358         (ptype): Handle types with a kind extension.
1359         (direct_abs_decl): Extend to spot kind extensions.
1360         (f77_keywords): Add 'kind' to the list.
1361         (push_kind_type): New function.
1362         (convert_to_kind_type): New function.
1363         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1364         * parse.c (operator_length_standard): Likewise.
1365         * parser-defs.h (enum type_pieces): Add tp_kind.
1366         * std-operator.def: Add UNOP_KIND.
1367
1368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1369
1370         * f-exp.y (f_parse): Set yydebug.
1371
1372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1373
1374         * f-lang.c (evaluate_subexp_f): New function.
1375         (exp_descriptor_f): New global.
1376         (f_language_defn): Use exp_descriptor_f instead of
1377         exp_descriptor_standard.
1378
1379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * f-exp.y (struct token): Add comments.
1382         (dot_ops): Remove uppercase versions and the end marker.
1383         (f77_keywords): Likewise.
1384         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1385         entries in the dot_ops array are case insensitive, and use
1386         strncasecmp to compare strings.  Also some whitespace cleanup in
1387         this area.  Similar for the f77_keywords array, except entries in
1388         this list might be case sensitive.
1389
1390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * f-exp.y (struct f77_boolean_val): Add comments.
1393         (boolean_values): Remove uppercase versions, and end marker.
1394         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1395         and use strncasecmp to achieve case insensitivity.  Additionally,
1396         perform whitespace cleanup around this code.
1397
1398 2019-03-06  Tom Tromey  <tromey@adacore.com>
1399
1400         * remote-sim.c (gdbsim_target_open): Use result of
1401         gdb_argv::release.
1402
1403 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1404         Dirk Schubert  <dirk.schubert@arm.com>
1405         Chris January  <chris.january@arm.com>
1406
1407         * eval.c (evaluate_subexp_standard): Call Fortran argument
1408         wrapping logic.
1409         * f-lang.c (struct value): A value which can be passed into a
1410         Fortran function call.
1411         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1412         where appropriate.
1413         (struct type): Value ready for a Fortran function call.
1414         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1415         is needed.
1416         * f-lang.h (fortran_argument_convert): Declaration.
1417         (fortran_preserve_arg_pointer): Declaration.
1418         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1419
1420 2019-03-05  Tom Tromey  <tromey@adacore.com>
1421
1422         * python/py-prettyprint.c (print_string_repr): Remove #if.
1423         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1424
1425 2019-03-05  Tom Tromey  <tromey@adacore.com>
1426
1427         * target.c (the_dummy_target): Move later.  Change type to
1428         "dummy_target".
1429         (initialize_targets): Don't initialize the_dummy_target.
1430
1431 2019-03-05  Tom Tromey  <tromey@adacore.com>
1432
1433         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1434         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1435
1436 2019-03-05  Tom Tromey  <tromey@adacore.com>
1437
1438         * windows-nat.c (windows_nat_target::attach)
1439         (windows_nat_target::detach): Don't call gdb_flush.
1440         * valprint.c (generic_val_print, val_print, val_print_string):
1441         Don't call gdb_flush.
1442         * utils.c (defaulted_query): Don't call gdb_flush.
1443         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1444         * target.c (target_announce_detach): Don't call gdb_flush.
1445         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1446         * remote.c (extended_remote_target::attach): Don't call
1447         gdb_flush.
1448         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1449         * printcmd.c (do_examine): Don't call gdb_flush.
1450         (info_display_command): Don't call gdb_flush.
1451         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1452         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1453         * memattr.c (info_mem_command): Don't call gdb_flush.
1454         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1455         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1456         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1457         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1458         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1459         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1460         (gnu_nat_target::detach): Don't call gdb_flush.
1461         * f-valprint.c (f_val_print): Don't call gdb_flush.
1462         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1463         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1464         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1465         gdb_flush.
1466         * c-valprint.c (c_val_print): Don't call gdb_flush.
1467         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1468
1469 2019-03-05  Tom Tromey  <tromey@adacore.com>
1470
1471         * varobj.c (update_dynamic_varobj_children): Update.
1472         (install_default_visualizer): Use reset, not release.
1473         * value.c (set_internalvar): Update.
1474         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1475         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1476         ATTRIBUTE_UNUSED_RESULT.
1477
1478 2019-03-05  Tom Tromey  <tromey@adacore.com>
1479
1480         * remote.c (class scoped_remote_fd) <release>: Add
1481         ATTRIBUTE_UNUSED_RESULT.
1482
1483 2019-03-05  Tom Tromey  <tromey@adacore.com>
1484
1485         * macroexp.c (struct macro_buffer) <release>: Add
1486         ATTRIBUTE_UNUSED_RESULT.
1487
1488 2019-03-05  Tom Tromey  <tromey@adacore.com>
1489
1490         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1491         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1492         ATTRIBUTE_UNUSED_RESULT.
1493
1494 2019-03-05  Tom Tromey  <tromey@adacore.com>
1495
1496         * common/scoped_fd.h (class scoped_fd) <release>: Add
1497         ATTRIBUTE_UNUSED_RESULT.
1498
1499 2019-03-05  Tom Tromey  <tromey@adacore.com>
1500
1501         * parser-defs.h (struct parser_state) <release>: Add
1502         ATTRIBUTE_UNUSED_RESULT.
1503
1504 2019-03-05  Tom Tromey  <tromey@adacore.com>
1505
1506         * utils.h (class gdb_argv) <release>: Add
1507         ATTRIBUTE_UNUSED_RESULT.
1508         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1509
1510 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1511
1512         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1513         for-loop range, to avoid compiler warnings.
1514
1515         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1516         avoid compiler warnings about unused variables.
1517
1518         * NEWS: Mention end of support for native debugging on MS-Windows
1519         before XP.
1520
1521         PR gdb/24292
1522         * common/netstuff.c:
1523         * gdbserver/gdbreplay.c
1524         * gdbserver/remote-utils.c:
1525         * ser-tcp.c:
1526         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1527         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1528         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1529         'getaddrinfo' and 'freeaddrinfo' were not available before
1530         Windows XP, and mingw.org's MinGW headers by default define
1531         _WIN32_WINNT to 0x500.
1532
1533 2019-03-01  Gary Benson <gbenson@redhat.com>
1534
1535         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1536
1537 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1538             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1539
1540         PR gdb/8527
1541         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1542         set_sigint_trap, clear_sigint_trap.
1543
1544 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1545
1546         * target.c (target_detach): Clear the regcache and the
1547         frame cache.
1548
1549 2019-02-27  Pedro Alves  <palves@redhat.com>
1550
1551         * utils.c (set_screen_size): When we cap the height/width sizes,
1552         tweak the corresponding command variable to show "unlimited":
1553
1554 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1555             Pedro Alves  <palves@redhat.com>
1556
1557         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1558         before calling rl_set_screen_size.
1559
1560 2019-02-27  Tom Tromey  <tromey@adacore.com>
1561
1562         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1563         define.
1564         * python/py-value.c: Remove Python 2.4 workaround.
1565         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1566         workaround.
1567         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1568         Python 2.4 workaround.
1569         * python/python-internal.h: Remove Python 2.4 comment.
1570         (Py_ssize_t): Don't define.
1571         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1572         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1573         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1574         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1575         * python/python.c (do_start_initialization): Remove Python 2.4
1576         workaround.
1577         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1578         (print_children): Remove Python 2.4 workaround.
1579         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1580         workaround.
1581         (CHARBUFFERPROC_NAME): Remove.
1582         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1583         Python 2.4 workaround.
1584
1585 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1586
1587         * NEWS: Note minimum Python version.
1588
1589 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1590
1591         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1592         code from these functions.  Remove corresponding ifdefs.  Use
1593         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1594         Remove gotos and target of gotos.
1595         (infpy_search_memory): Likewise.
1596
1597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1600         (hppa_gdbarch_init): Don't register deleted functions with
1601         gdbarch.
1602
1603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1604
1605         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1606         (h8300_unwind_sp): Delete.
1607         (h8300_dummy_id): Delete.
1608         (h8300_gdbarch_init): Don't register deleted functions with
1609         gdbarch.
1610
1611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1614         (ft32_unwind_pc): Delete.
1615         (ft32_unwind_sp): Delete.
1616         (ft32_gdbarch_init): Don't register deleted functions with
1617         gdbarch.
1618
1619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1622         (frv_unwind_pc): Delete.
1623         (frv_unwind_sp): Delete.
1624         (frv_gdbarch_init): Don't register deleted functions with
1625         gdbarch.
1626
1627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1630         (riscv_unwind_pc): Delete.
1631         (riscv_unwind_sp): Delete.
1632         (riscv_gdbarch_init): Don't register deleted functions with
1633         gdbarch.
1634
1635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1638         (csky_unwind_pc): Delete.
1639         (csky_unwind_sp): Delete.
1640         (csky_gdbarch_init): Don't register deleted functions with
1641         gdbarch.
1642
1643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1646         (cris_unwind_pc): Delete.
1647         (cris_unwind_sp): Delete.
1648         (cris_gdbarch_init): Don't register deleted functions with
1649         gdbarch.
1650
1651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1654         (bfin_unwind_pc): Delete.
1655         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1656
1657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1660         (arm_unwind_pc): Delete.
1661         (arm_unwind_sp): Delete.
1662         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1663
1664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1667         (arc_unwind_pc): Delete.
1668         (arc_unwind_sp): Delete.
1669         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1670
1671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1672
1673         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1674         (alpha_unwind_pc): Delete.
1675         (alpha_gdbarch_init): Don't register deleted functions with
1676         gdbarch.
1677
1678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1681         (aarch64_unwind_pc): Delete.
1682         (aarch64_unwind_sp): Delete.
1683         (aarch64_gdbarch_init): Don't register deleted functions with
1684         gdbarch.
1685
1686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1687
1688         * gdbtypes.c (type_align): Don't consider static members when
1689         computing structure alignment.
1690
1691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1694         return 0 for other types.
1695         * arch-utils.c (default_type_align): Always return 0.
1696         * gdbarch.h: Regenerate.
1697         * gdbarch.sh (type_align): Extend comment.
1698         * gdbtypes.c (type_align): Add additional comments, always call
1699         gdbarch_type_align before applying the default rules.
1700         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1701         generic code will then apply a suitable default.
1702         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1703         types, return 0 for other types.
1704
1705 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1706
1707         * NEWS: Create a new section for the next release branch.
1708         Rename the section of the current branch, now that it has
1709         been cut.
1710
1711 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1712
1713         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1714         * version.in: Bump version to 8.3.50.DATE-git.
1715
1716 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1717
1718         * aix-thread.c (ptid_cmp): Remove unused variable.
1719         (get_signaled_thread): Likewise.
1720         (store_regs_user_thread): Likewise.
1721         (store_regs_kernel_thread): Likewise.
1722         (fetch_regs_kernel_thread): Remove shadowed variable.
1723
1724 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * features/riscv/32bit-cpu.xml: Add register numbers.
1727         * features/riscv/32bit-fpu.c: Regenerate.
1728         * features/riscv/32bit-fpu.xml: Add register numbers.
1729         * features/riscv/64bit-cpu.xml: Add register numbers.
1730         * features/riscv/64bit-fpu.c: Regenerate.
1731         * features/riscv/64bit-fpu.xml: Add register numbers.
1732
1733 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1734
1735         * NEWS: Mention two argument form of gdb.Value constructor.
1736         * python/py-value.c (convert_buffer_and_type_to_value): New
1737         function.
1738         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1739         Add support for handling an optional second argument.  Call
1740         convert_buffer_and_type_to_value as appropriate.
1741         * python/python-internal.h (Py_buffer_deleter): New struct.
1742         (Py_buffer_up): New typedef.
1743
1744 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1745
1746         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1747         instead of releasing ownership.
1748
1749 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1750
1751         * dwarf2read.c (open_and_init_dwp_file): Call
1752         elf_numsections instead of bfd_count_sections to initialize
1753         dwp_file->num_sections.
1754
1755 2019-02-25  Tom Tromey  <tromey@adacore.com>
1756
1757         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1758
1759 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1760
1761         * gcore.in: Add '--readnever' option when invoking GDB.
1762
1763 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1764
1765         * MAINTAINERS: Update my email address.
1766
1767 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1768
1769         * build-id.c (build_id_to_debug_bfd_1): New function.
1770         (build_id_to_debug_bfd): Look for separate debug file in
1771         sysroot.
1772
1773 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * gdbarch.sh: Update the copyright year range that is placed into
1776         generated files.
1777
1778 2019-02-22  Keith Seitz  <keiths@redhat.com>
1779
1780         PR symtab/23853
1781         * linespec.c (create_sals_line_offset): Search for the default
1782         symtab's filename instead of its fullname.
1783
1784 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1785
1786         * NEWS: Update style defaults.
1787
1788 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1789
1790         * main.c (captured_main_1): Disable styling in batch mode.
1791
1792 2019-02-20  Tom Tromey  <tom@tromey.com>
1793
1794         * symtab.c (symtab_symbol_info): Fix typos.
1795
1796 2019-02-20  Tom Tromey  <tromey@adacore.com>
1797
1798         * findcmd.c (_initialize_mem_search): Use upper case for
1799         metasyntactic variables.
1800
1801 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1802
1803         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1804         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1805
1806 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1807
1808         * top.h (source_file_name): Change to std::string.
1809         * top.c (source_file_name): Likewise.
1810         (command_line_input): Adjust.
1811         * cli/cli-script.c (script_from_file): Adjust.
1812
1813 2019-02-19  Tom Tromey  <tromey@adacore.com>
1814
1815         * ravenscar-thread.c
1816         (ravenscar_thread_target::update_thread_list): Don't call
1817         ada_build_task_list.
1818         * ada-lang.h (ada_build_task_list): Don't declare.
1819         * ada-tasks.c (struct ada_tasks_inferior_data)
1820         <task_list_valid_p>: Now bool.
1821         (read_known_tasks, ada_task_list_changed)
1822         (ada_tasks_invalidate_inferior_data): Update.
1823         (read_known_tasks_array): Return bool.
1824         (read_known_tasks_list): Likewise.
1825         (read_known_tasks): Return void.
1826         (ada_build_task_list): Now static.
1827
1828 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1831         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1832
1833 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1834
1835         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1836         variant for ada_tasks_pspace_data_handle and
1837         ada_tasks_inferior_data_handle.
1838         (ada_tasks_pspace_data_cleanup): New function.
1839         (ada_tasks_inferior_data_cleanup): New function.
1840
1841 2019-02-17  Tom Tromey  <tom@tromey.com>
1842
1843         * macrotab.h (macro_source_fullname): Return a std::string.
1844         * macrotab.c (macro_include, check_for_redefinition)
1845         (macro_undef, macro_lookup_definition, foreach_macro)
1846         (foreach_macro_in_scope): Update.
1847         (macro_source_fullname): Return a std::string.
1848         * macrocmd.c (show_pp_source_pos): Update.
1849
1850 2019-02-17  Tom Tromey  <tom@tromey.com>
1851
1852         * macrocmd.c (show_pp_source_pos): Style the file names.
1853
1854 2019-02-17  Tom Tromey  <tom@tromey.com>
1855
1856         PR tui/24197:
1857         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1858
1859 2019-02-17  Tom Tromey  <tom@tromey.com>
1860
1861         * ada-lang.c (user_select_syms): Use filtered printing.
1862         * utils.c (wrap_style): New global.
1863         (desired_style): Remove.
1864         (emit_style_escape): Add stream parameter.
1865         (set_output_style, reset_terminal_style, prompt_for_continue):
1866         Update.
1867         (flush_wrap_buffer): Only flush gdb_stdout.
1868         (wrap_here): Set wrap_style.
1869         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1870         treat escape sequences as a character.  Change when wrap buffer is
1871         flushed.
1872         (fputs_styled): Do not set the output style when the default is
1873         requested.
1874         * ui-style.h (struct ui_file_style) <is_default>: New method.
1875         * source.c (print_source_lines_base): Emit escape sequences in one
1876         piece.
1877
1878 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1879
1880         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1881         integers and enumeration types.
1882
1883 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1884
1885         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1886         instead of lookup_symbol_in_language
1887         (do_exact_match): New function.
1888         (ada_get_symbol_name_matcher): Return do_exact_match when
1889         doing a verbatim match.
1890
1891 2019-02-15  Tom Tromey  <tromey@adacore.com>
1892
1893         * ravenscar-thread.c (ravenscar_thread_target::resume)
1894         (ravenscar_thread_target::wait): Special case wildcard requests.
1895
1896 2019-02-15  Tom Tromey  <tromey@adacore.com>
1897
1898         * ravenscar-thread.c (base_ptid): Remove.
1899         (struct ravenscar_thread_target) <close>: New method.
1900         <m_base_ptid>: New member.
1901         <update_inferior_ptid, active_task, task_is_currently_active,
1902         runtime_initialized>: Declare methods.
1903         <ravenscar_thread_target>: Add constructor.
1904         (ravenscar_thread_target::task_is_currently_active)
1905         (ravenscar_thread_target::update_inferior_ptid)
1906         (ravenscar_runtime_initialized): Rename.  Now methods.
1907         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1908         (ravenscar_thread_target::update_thread_list): Update.
1909         (ravenscar_thread_target::active_task): Now method.
1910         (ravenscar_thread_target::store_registers)
1911         (ravenscar_thread_target::prepare_to_store)
1912         (ravenscar_thread_target::prepare_to_store)
1913         (ravenscar_thread_target::mourn_inferior): Update.
1914         (ravenscar_inferior_created): Use "new" to create target.
1915         (ravenscar_thread_target::get_ada_task_ptid): Update.
1916         (_initialize_ravenscar): Don't initialize base_ptid.
1917         (ravenscar_ops): Remove global.
1918
1919 2019-02-15  Tom Tromey  <tromey@adacore.com>
1920
1921         * target.h (push_target): Declare new overload.
1922         * target.c (push_target): New overload, taking an rvalue reference.
1923         * remote.c (remote_target::open_1): Use push_target overload.
1924         * corelow.c (core_target_open): Use push_target overload.
1925
1926 2019-02-15  Tom Tromey  <tromey@adacore.com>
1927
1928         * ravenscar-thread.c (is_ravenscar_task)
1929         (ravenscar_task_is_currently_active): Return bool.
1930         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1931         (_initialize_ravenscar): Remove "(void)".
1932         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1933         Return bool.
1934
1935 2019-02-15  Tom Tromey  <tromey@adacore.com>
1936
1937         * ravenscar-thread.c (ravenscar_runtime_initializer)
1938         (has_ravenscar_runtime, get_running_thread_id)
1939         (ravenscar_thread_target::resume): Fix indentation.
1940
1941 2019-02-15  Tom Tromey  <tromey@adacore.com>
1942
1943         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1944         from ravenscar_arch_ops.
1945         (sparc_ravenscar_ops::fetch_registers)
1946         (sparc_ravenscar_ops::store_registers): Now methods.
1947         (sparc_ravenscar_prepare_to_store): Remove.
1948         (sparc_ravenscar_ops): Redefine.
1949         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1950         methods and destructor.  Remove members.
1951         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1952         (ravenscar_thread_target::store_registers)
1953         (ravenscar_thread_target::prepare_to_store): Update.
1954         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1955         Remove.
1956         (struct ppc_ravenscar_powerpc_ops): Derive from
1957         ravenscar_arch_ops.
1958         (ppc_ravenscar_powerpc_ops::fetch_registers)
1959         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1960         (ppc_ravenscar_powerpc_ops): Redefine.
1961         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1962         (ppc_ravenscar_e500_ops::fetch_registers)
1963         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1964         (ppc_ravenscar_e500_ops): Redefine.
1965         * aarch64-ravenscar-thread.c
1966         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1967         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1968         (aarch64_ravenscar_fetch_registers)
1969         (aarch64_ravenscar_store_registers): Now methods.
1970         (aarch64_ravenscar_ops): Redefine.
1971
1972 2019-02-15  Tom Tromey  <tromey@adacore.com>
1973
1974         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1975         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1976         (ravenscar_thread_target::stopped_by_watchpoint)
1977         (ravenscar_thread_target::stopped_data_address)
1978         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1979
1980 2019-02-15  Tom Tromey  <tromey@adacore.com>
1981
1982         * ravenscar-thread.c: Fix some typos.
1983
1984 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985             Tom Tromey  <tromey@adacore.com>
1986
1987         * ada-lang.c (ada_exception_sal): Change addr_string to a
1988         std::string.
1989         (create_ada_exception_catchpoint): Update.
1990
1991 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1992             Tom Tromey  <tromey@adacore.com>
1993
1994         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1995         (bp_location_ops): Remove.
1996         (base_breakpoint_allocate_location): Update.
1997         (free_bp_location): Update.
1998         * ada-lang.c (class ada_catchpoint_location)
1999         <ada_catchpoint_location>: Remove ops parameter.
2000         (ada_catchpoint_location_dtor): Remove.
2001         (ada_catchpoint_location_ops): Remove.
2002         (allocate_location_exception): Update.
2003         * breakpoint.h (struct bp_location_ops): Remove.
2004         (class bp_location) <bp_location>: Remove bp_location_ops
2005         parameter.
2006         <~bp_location>: Add destructor.
2007         <ops>: Remove.
2008
2009 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2010             Pedro Alves  <palves@redhat.com>
2011
2012         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2013         'PATH_MAX'.
2014
2015 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2016             Samuel Thibault  <samuel.thibault@gnu.org>
2017             Thomas Schwinge  <thomas@codesourcery.com>
2018
2019         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2020         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2021
2022 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2023
2024         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2025         (check_empty): Use "const char *".
2026
2027         * gnu-nat.c (gnu_nat_target::detach): Instead of
2028         'detach_inferior (pid)' call
2029         'detach_inferior (find_inferior_pid (pid))'.
2030
2031         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2032         'nat/fork-inferior.o'.
2033         * gnu-nat.c: #include "nat/fork-inferior.h".
2034
2035         * gnu-nat.c (gnu_nat_target::detach): Instead of
2036         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2037         * gnu-nat.h: #include "inf-child.h".
2038         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2039         'i386_gnu_nat_target::fetch_registers'.
2040         (gnu_store_registers): Rename/move to
2041         'i386_gnu_nat_target::store_registers'.
2042
2043         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2044         * gnu-nat.h (mach_thread_info): New function.
2045         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2046
2047         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2048
2049 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2050
2051         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2052
2053 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2054
2055         * windows-nat.c (windows_add_thread): Add new parameter
2056         "main_thread_p" with default value set to false.  Update
2057         function documentation as well as all callers.
2058         (windows_delete_thread): Likewise.
2059         (fake_create_process): Update call to windows_add_thread.
2060         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2061         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2062         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2063         call to windows_delete_thread.
2064
2065 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2066
2067         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2068
2069 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2070
2071         * symfile.c (find_separate_debug_file): Use canonical path of
2072         sysroot with child_path instead of gdb_sysroot if it is valid.
2073
2074 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2075
2076         * symfile.c (find_separate_debug_file): Use child_path to
2077         determine if an object file is under a sysroot.
2078
2079 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2080
2081         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2082         unittests/child-path-selftests.c.
2083         * common/pathstuff.c (child_path): New function.
2084         * common/pathstuff.h (child_path): New prototype.
2085         * unittests/child-path-selftests.c: New file.
2086
2087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2088
2089         * symfile.c (find_separate_debug_file): Look for separate debug
2090         files in debug directories under the sysroot.
2091
2092 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2093
2094         * symtab.h (struct minimal_symbol data_p): New const method.
2095         (struct minimal_symbol text_p): Likewise.
2096         * symtab.c (output_source_filename): Use file name style
2097         to print file name.
2098         (print_symbol_info): Likewise.
2099         (print_msymbol_info): Use address style to print addresses.
2100         Use function name style to print executable text symbols.
2101         (expand_symtab_containing_pc): Use data_p.
2102         (find_pc_sect_compunit_symtab): Likewise.
2103
2104 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2105
2106         * breakpoint.c (describe_other_breakpoints): Use address style
2107         to print addresses.
2108         (say_where): Likewise.
2109
2110 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2111
2112         * ada-typeprint.c (print_func_type): Print function name
2113         style to print function name.
2114         * c-typeprint.c (c_print_type_1): Likewise.
2115
2116 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2117
2118         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2119         for execve.
2120
2121 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2122
2123         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2124         type_stack.
2125
2126 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2127
2128         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2129         TYPE_CODE_REF types.
2130
2131 2019-02-08  Jim Wilson  <jimw@sifive.com>
2132
2133         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2134         (riscv_linux_fregset): New.
2135         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2136
2137 2019-02-07  Tom Tromey  <tom@tromey.com>
2138
2139         * thread.c (thread_cancel_execution_command): Update.
2140         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2141         methods.
2142         (struct thread_fsm_ops): Remove.
2143         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2144         (thread_fsm_should_stop, thread_fsm_return_value)
2145         (thread_fsm_set_finished, thread_fsm_finished_p)
2146         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2147         Don't declare.
2148         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2149         * infrun.c (clear_proceed_status_thread)
2150         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2151         (print_stop_event): Update.
2152         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2153         Add constructor.
2154         (step_command_fsm_ops): Remove.
2155         (new_step_command_fsm): Remove.
2156         (step_1): Update.
2157         (step_command_fsm::should_stop): Rename from
2158         step_command_fsm_should_stop.
2159         (step_command_fsm::clean_up): Rename from
2160         step_command_fsm_clean_up.
2161         (step_command_fsm::do_async_reply_reason): Rename from
2162         step_command_fsm_async_reply_reason.
2163         (struct until_next_fsm): Inherit from thread_fsm.  Add
2164         constructor.
2165         (until_next_fsm_ops): Remove.
2166         (new_until_next_fsm): Remove.
2167         (until_next_fsm::should_stop): Rename from
2168         until_next_fsm_should_stop.
2169         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2170         (until_next_fsm::do_async_reply_reason): Rename from
2171         until_next_fsm_async_reply_reason.
2172         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2173         constructor.  Change type of breakpoint.
2174         (finish_command_fsm_ops): Remove.
2175         (new_finish_command_fsm): Remove.
2176         (finish_command_fsm::should_stop): Rename from
2177         finish_command_fsm_should_stop.
2178         (finish_command_fsm::clean_up): Rename from
2179         finish_command_fsm_clean_up.
2180         (finish_command_fsm::return_value): Rename from
2181         finish_command_fsm_return_value.
2182         (finish_command_fsm::do_async_reply_reason): Rename from
2183         finish_command_fsm_async_reply_reason.
2184         (finish_command): Update.
2185         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2186         Add constructor.
2187         (call_thread_fsm_ops): Remove.
2188         (call_thread_fsm::call_thread_fsm): Rename from
2189         new_call_thread_fsm.
2190         (call_thread_fsm::should_stop): Rename from
2191         call_thread_fsm_should_stop.
2192         (call_thread_fsm::should_notify_stop): Rename from
2193         call_thread_fsm_should_notify_stop.
2194         (run_inferior_call, call_function_by_hand_dummy): Update.
2195         * cli/cli-interp.c (should_print_stop_to_console): Update.
2196         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2197         Add constructor.  Change type of location_breakpoint,
2198         caller_breakpoint.
2199         (until_break_fsm_ops): Remove.
2200         (new_until_break_fsm): Remove.
2201         (until_break_fsm::should_stop): Rename from
2202         until_break_fsm_should_stop.
2203         (until_break_fsm::clean_up): Rename from
2204         until_break_fsm_clean_up.
2205         (until_break_fsm::do_async_reply_reason): Rename from
2206         until_break_fsm_async_reply_reason.
2207         (until_break_command): Update.
2208         * thread-fsm.c: Remove.
2209         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2210
2211 2019-02-07  Tom Tromey  <tom@tromey.com>
2212
2213         * yy-remap.h: Add include guard.
2214         * xtensa-tdep.h: Add include guard.
2215         * xcoffread.h: Rename include guard.
2216         * varobj-iter.h: Add include guard.
2217         * tui/tui.h: Rename include guard.
2218         * tui/tui-winsource.h: Rename include guard.
2219         * tui/tui-wingeneral.h: Rename include guard.
2220         * tui/tui-windata.h: Rename include guard.
2221         * tui/tui-win.h: Rename include guard.
2222         * tui/tui-stack.h: Rename include guard.
2223         * tui/tui-source.h: Rename include guard.
2224         * tui/tui-regs.h: Rename include guard.
2225         * tui/tui-out.h: Rename include guard.
2226         * tui/tui-layout.h: Rename include guard.
2227         * tui/tui-io.h: Rename include guard.
2228         * tui/tui-hooks.h: Rename include guard.
2229         * tui/tui-file.h: Rename include guard.
2230         * tui/tui-disasm.h: Rename include guard.
2231         * tui/tui-data.h: Rename include guard.
2232         * tui/tui-command.h: Rename include guard.
2233         * tic6x-tdep.h: Add include guard.
2234         * target/waitstatus.h: Rename include guard.
2235         * target/wait.h: Rename include guard.
2236         * target/target.h: Rename include guard.
2237         * target/resume.h: Rename include guard.
2238         * target-float.h: Rename include guard.
2239         * stabsread.h: Add include guard.
2240         * rs6000-tdep.h: Add include guard.
2241         * riscv-fbsd-tdep.h: Add include guard.
2242         * regformats/regdef.h: Rename include guard.
2243         * record.h: Rename include guard.
2244         * python/python.h: Rename include guard.
2245         * python/python-internal.h: Rename include guard.
2246         * python/py-stopevent.h: Rename include guard.
2247         * python/py-ref.h: Rename include guard.
2248         * python/py-record.h: Rename include guard.
2249         * python/py-record-full.h: Rename include guard.
2250         * python/py-record-btrace.h: Rename include guard.
2251         * python/py-instruction.h: Rename include guard.
2252         * python/py-events.h: Rename include guard.
2253         * python/py-event.h: Rename include guard.
2254         * procfs.h: Add include guard.
2255         * proc-utils.h: Add include guard.
2256         * p-lang.h: Add include guard.
2257         * or1k-tdep.h: Rename include guard.
2258         * observable.h: Rename include guard.
2259         * nto-tdep.h: Rename include guard.
2260         * nat/x86-linux.h: Rename include guard.
2261         * nat/x86-linux-dregs.h: Rename include guard.
2262         * nat/x86-gcc-cpuid.h: Add include guard.
2263         * nat/x86-dregs.h: Rename include guard.
2264         * nat/x86-cpuid.h: Rename include guard.
2265         * nat/ppc-linux.h: Rename include guard.
2266         * nat/mips-linux-watch.h: Rename include guard.
2267         * nat/linux-waitpid.h: Rename include guard.
2268         * nat/linux-ptrace.h: Rename include guard.
2269         * nat/linux-procfs.h: Rename include guard.
2270         * nat/linux-osdata.h: Rename include guard.
2271         * nat/linux-nat.h: Rename include guard.
2272         * nat/linux-namespaces.h: Rename include guard.
2273         * nat/linux-btrace.h: Rename include guard.
2274         * nat/glibc_thread_db.h: Rename include guard.
2275         * nat/gdb_thread_db.h: Rename include guard.
2276         * nat/gdb_ptrace.h: Rename include guard.
2277         * nat/fork-inferior.h: Rename include guard.
2278         * nat/amd64-linux-siginfo.h: Rename include guard.
2279         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2280         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2281         * nat/aarch64-linux.h: Rename include guard.
2282         * nat/aarch64-linux-hw-point.h: Rename include guard.
2283         * mn10300-tdep.h: Add include guard.
2284         * mips-linux-tdep.h: Add include guard.
2285         * mi/mi-parse.h: Rename include guard.
2286         * mi/mi-out.h: Rename include guard.
2287         * mi/mi-main.h: Rename include guard.
2288         * mi/mi-interp.h: Rename include guard.
2289         * mi/mi-getopt.h: Rename include guard.
2290         * mi/mi-console.h: Rename include guard.
2291         * mi/mi-common.h: Rename include guard.
2292         * mi/mi-cmds.h: Rename include guard.
2293         * mi/mi-cmd-break.h: Rename include guard.
2294         * m2-lang.h: Add include guard.
2295         * location.h: Rename include guard.
2296         * linux-record.h: Rename include guard.
2297         * linux-nat.h: Add include guard.
2298         * linux-fork.h: Add include guard.
2299         * i386-darwin-tdep.h: Rename include guard.
2300         * hppa-linux-offsets.h: Add include guard.
2301         * guile/guile.h: Rename include guard.
2302         * guile/guile-internal.h: Rename include guard.
2303         * gnu-nat.h: Rename include guard.
2304         * gdb-stabs.h: Rename include guard.
2305         * frv-tdep.h: Add include guard.
2306         * f-lang.h: Add include guard.
2307         * event-loop.h: Add include guard.
2308         * darwin-nat.h: Rename include guard.
2309         * cp-abi.h: Rename include guard.
2310         * config/sparc/nm-sol2.h: Rename include guard.
2311         * config/nm-nto.h: Rename include guard.
2312         * config/nm-linux.h: Add include guard.
2313         * config/i386/nm-i386gnu.h: Rename include guard.
2314         * config/djgpp/nl_types.h: Rename include guard.
2315         * config/djgpp/langinfo.h: Rename include guard.
2316         * compile/gcc-cp-plugin.h: Add include guard.
2317         * compile/gcc-c-plugin.h: Add include guard.
2318         * compile/compile.h: Rename include guard.
2319         * compile/compile-object-run.h: Rename include guard.
2320         * compile/compile-object-load.h: Rename include guard.
2321         * compile/compile-internal.h: Rename include guard.
2322         * compile/compile-cplus.h: Rename include guard.
2323         * compile/compile-c.h: Rename include guard.
2324         * common/xml-utils.h: Rename include guard.
2325         * common/x86-xstate.h: Rename include guard.
2326         * common/version.h: Rename include guard.
2327         * common/vec.h: Rename include guard.
2328         * common/tdesc.h: Rename include guard.
2329         * common/selftest.h: Rename include guard.
2330         * common/scoped_restore.h: Rename include guard.
2331         * common/scoped_mmap.h: Rename include guard.
2332         * common/scoped_fd.h: Rename include guard.
2333         * common/safe-iterator.h: Rename include guard.
2334         * common/run-time-clock.h: Rename include guard.
2335         * common/refcounted-object.h: Rename include guard.
2336         * common/queue.h: Rename include guard.
2337         * common/ptid.h: Rename include guard.
2338         * common/print-utils.h: Rename include guard.
2339         * common/preprocessor.h: Rename include guard.
2340         * common/pathstuff.h: Rename include guard.
2341         * common/observable.h: Rename include guard.
2342         * common/netstuff.h: Rename include guard.
2343         * common/job-control.h: Rename include guard.
2344         * common/host-defs.h: Rename include guard.
2345         * common/gdb_wait.h: Rename include guard.
2346         * common/gdb_vecs.h: Rename include guard.
2347         * common/gdb_unlinker.h: Rename include guard.
2348         * common/gdb_unique_ptr.h: Rename include guard.
2349         * common/gdb_tilde_expand.h: Rename include guard.
2350         * common/gdb_sys_time.h: Rename include guard.
2351         * common/gdb_string_view.h: Rename include guard.
2352         * common/gdb_splay_tree.h: Rename include guard.
2353         * common/gdb_setjmp.h: Rename include guard.
2354         * common/gdb_ref_ptr.h: Rename include guard.
2355         * common/gdb_optional.h: Rename include guard.
2356         * common/gdb_locale.h: Rename include guard.
2357         * common/gdb_assert.h: Rename include guard.
2358         * common/filtered-iterator.h: Rename include guard.
2359         * common/filestuff.h: Rename include guard.
2360         * common/fileio.h: Rename include guard.
2361         * common/environ.h: Rename include guard.
2362         * common/common-utils.h: Rename include guard.
2363         * common/common-types.h: Rename include guard.
2364         * common/common-regcache.h: Rename include guard.
2365         * common/common-inferior.h: Rename include guard.
2366         * common/common-gdbthread.h: Rename include guard.
2367         * common/common-exceptions.h: Rename include guard.
2368         * common/common-defs.h: Rename include guard.
2369         * common/common-debug.h: Rename include guard.
2370         * common/cleanups.h: Rename include guard.
2371         * common/buffer.h: Rename include guard.
2372         * common/btrace-common.h: Rename include guard.
2373         * common/break-common.h: Rename include guard.
2374         * cli/cli-utils.h: Rename include guard.
2375         * cli/cli-style.h: Rename include guard.
2376         * cli/cli-setshow.h: Rename include guard.
2377         * cli/cli-script.h: Rename include guard.
2378         * cli/cli-interp.h: Rename include guard.
2379         * cli/cli-decode.h: Rename include guard.
2380         * cli/cli-cmds.h: Rename include guard.
2381         * charset-list.h: Add include guard.
2382         * buildsym-legacy.h: Rename include guard.
2383         * bfin-tdep.h: Add include guard.
2384         * ax.h: Rename include guard.
2385         * arm-linux-tdep.h: Add include guard.
2386         * arm-fbsd-tdep.h: Add include guard.
2387         * arch/xtensa.h: Rename include guard.
2388         * arch/tic6x.h: Add include guard.
2389         * arch/i386.h: Add include guard.
2390         * arch/arm.h: Rename include guard.
2391         * arch/arm-linux.h: Rename include guard.
2392         * arch/arm-get-next-pcs.h: Rename include guard.
2393         * arch/amd64.h: Add include guard.
2394         * arch/aarch64-insn.h: Rename include guard.
2395         * arch-utils.h: Rename include guard.
2396         * annotate.h: Add include guard.
2397         * amd64-darwin-tdep.h: Rename include guard.
2398         * aarch64-linux-tdep.h: Add include guard.
2399         * aarch64-fbsd-tdep.h: Add include guard.
2400         * aarch32-linux-nat.h: Add include guard.
2401
2402 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2403
2404         * macrotab.c (macro_define_internal): New function that
2405         factorizes macro_define_object_internal and macro_define_function
2406         code.
2407         (macro_define_object_internal): Use macro_define_internal.
2408         (macro_define_function): Likewise.
2409
2410 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2411
2412         * macrocmd.c (extract_identifier): Return
2413         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2414         callers.
2415
2416 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2417
2418         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2419
2420 2019-02-05  Tom Tromey  <tom@tromey.com>
2421
2422         * target.c (target_stack::unpush): Move assertion earlier.
2423
2424 2019-01-30  Tom Tromey  <tom@tromey.com>
2425
2426         PR python/23615:
2427         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2428         (gdbpy_parse_and_eval): Likewise.
2429         * python/python-internal.h (gdbpy_allow_threads): New class.
2430
2431 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2432
2433         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2434         (aarch64_fbsd_fpregmap): Move earlier.
2435         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2436         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2437         instead of individual calls to trad_frame_set_reg_addr.
2438         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2439         earlier.
2440         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2441         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2442         instead of individual calls to trad_frame_set_reg_addr.
2443
2444 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2445
2446         * CONTRIBUTE: Replace contribution list with wiki link.
2447
2448 2019-01-25  Tom Tromey  <tom@tromey.com>
2449
2450         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2451
2452 2019-01-25  Tom Tromey  <tom@tromey.com>
2453
2454         * xtensa-linux-nat.c: Fix common/ includes.
2455         * xml-support.h: Fix common/ includes.
2456         * xml-support.c: Fix common/ includes.
2457         * x86-linux-nat.c: Fix common/ includes.
2458         * windows-nat.c: Fix common/ includes.
2459         * varobj.h: Fix common/ includes.
2460         * varobj.c: Fix common/ includes.
2461         * value.c: Fix common/ includes.
2462         * valops.c: Fix common/ includes.
2463         * utils.c: Fix common/ includes.
2464         * unittests/xml-utils-selftests.c: Fix common/ includes.
2465         * unittests/utils-selftests.c: Fix common/ includes.
2466         * unittests/unpack-selftests.c: Fix common/ includes.
2467         * unittests/tracepoint-selftests.c: Fix common/ includes.
2468         * unittests/style-selftests.c: Fix common/ includes.
2469         * unittests/string_view-selftests.c: Fix common/ includes.
2470         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2471         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2472         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2473         * unittests/rsp-low-selftests.c: Fix common/ includes.
2474         * unittests/parse-connection-spec-selftests.c: Fix common/
2475         includes.
2476         * unittests/optional-selftests.c: Fix common/ includes.
2477         * unittests/offset-type-selftests.c: Fix common/ includes.
2478         * unittests/observable-selftests.c: Fix common/ includes.
2479         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2480         * unittests/memrange-selftests.c: Fix common/ includes.
2481         * unittests/memory-map-selftests.c: Fix common/ includes.
2482         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2483         * unittests/function-view-selftests.c: Fix common/ includes.
2484         * unittests/environ-selftests.c: Fix common/ includes.
2485         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2486         * unittests/common-utils-selftests.c: Fix common/ includes.
2487         * unittests/cli-utils-selftests.c: Fix common/ includes.
2488         * unittests/array-view-selftests.c: Fix common/ includes.
2489         * ui-file.c: Fix common/ includes.
2490         * tui/tui-io.c: Fix common/ includes.
2491         * tracepoint.h: Fix common/ includes.
2492         * tracepoint.c: Fix common/ includes.
2493         * tracefile-tfile.c: Fix common/ includes.
2494         * top.h: Fix common/ includes.
2495         * top.c: Fix common/ includes.
2496         * thread.c: Fix common/ includes.
2497         * target/waitstatus.h: Fix common/ includes.
2498         * target/waitstatus.c: Fix common/ includes.
2499         * target.h: Fix common/ includes.
2500         * target.c: Fix common/ includes.
2501         * target-memory.c: Fix common/ includes.
2502         * target-descriptions.c: Fix common/ includes.
2503         * symtab.h: Fix common/ includes.
2504         * symfile.c: Fix common/ includes.
2505         * stap-probe.c: Fix common/ includes.
2506         * spu-linux-nat.c: Fix common/ includes.
2507         * sparc-nat.c: Fix common/ includes.
2508         * source.c: Fix common/ includes.
2509         * solib.c: Fix common/ includes.
2510         * solib-target.c: Fix common/ includes.
2511         * ser-unix.c: Fix common/ includes.
2512         * ser-tcp.c: Fix common/ includes.
2513         * ser-pipe.c: Fix common/ includes.
2514         * ser-base.c: Fix common/ includes.
2515         * selftest-arch.c: Fix common/ includes.
2516         * s12z-tdep.c: Fix common/ includes.
2517         * rust-exp.y: Fix common/ includes.
2518         * rs6000-aix-tdep.c: Fix common/ includes.
2519         * riscv-tdep.c: Fix common/ includes.
2520         * remote.c: Fix common/ includes.
2521         * remote-notif.h: Fix common/ includes.
2522         * remote-fileio.h: Fix common/ includes.
2523         * remote-fileio.c: Fix common/ includes.
2524         * regcache.h: Fix common/ includes.
2525         * regcache.c: Fix common/ includes.
2526         * record-btrace.c: Fix common/ includes.
2527         * python/python.c: Fix common/ includes.
2528         * python/py-type.c: Fix common/ includes.
2529         * python/py-inferior.c: Fix common/ includes.
2530         * progspace.h: Fix common/ includes.
2531         * producer.c: Fix common/ includes.
2532         * procfs.c: Fix common/ includes.
2533         * proc-api.c: Fix common/ includes.
2534         * printcmd.c: Fix common/ includes.
2535         * ppc-linux-nat.c: Fix common/ includes.
2536         * parser-defs.h: Fix common/ includes.
2537         * osdata.c: Fix common/ includes.
2538         * obsd-nat.c: Fix common/ includes.
2539         * nat/x86-linux.c: Fix common/ includes.
2540         * nat/x86-linux-dregs.c: Fix common/ includes.
2541         * nat/x86-dregs.h: Fix common/ includes.
2542         * nat/x86-dregs.c: Fix common/ includes.
2543         * nat/ppc-linux.c: Fix common/ includes.
2544         * nat/mips-linux-watch.h: Fix common/ includes.
2545         * nat/mips-linux-watch.c: Fix common/ includes.
2546         * nat/linux-waitpid.c: Fix common/ includes.
2547         * nat/linux-ptrace.h: Fix common/ includes.
2548         * nat/linux-ptrace.c: Fix common/ includes.
2549         * nat/linux-procfs.c: Fix common/ includes.
2550         * nat/linux-personality.c: Fix common/ includes.
2551         * nat/linux-osdata.c: Fix common/ includes.
2552         * nat/linux-namespaces.c: Fix common/ includes.
2553         * nat/linux-btrace.h: Fix common/ includes.
2554         * nat/linux-btrace.c: Fix common/ includes.
2555         * nat/fork-inferior.c: Fix common/ includes.
2556         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2557         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2558         * nat/aarch64-linux.c: Fix common/ includes.
2559         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2560         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2561         * namespace.h: Fix common/ includes.
2562         * mips-linux-tdep.c: Fix common/ includes.
2563         * minsyms.c: Fix common/ includes.
2564         * mi/mi-parse.h: Fix common/ includes.
2565         * mi/mi-main.c: Fix common/ includes.
2566         * mi/mi-cmd-env.c: Fix common/ includes.
2567         * memrange.h: Fix common/ includes.
2568         * memattr.c: Fix common/ includes.
2569         * maint.h: Fix common/ includes.
2570         * maint.c: Fix common/ includes.
2571         * main.c: Fix common/ includes.
2572         * machoread.c: Fix common/ includes.
2573         * location.c: Fix common/ includes.
2574         * linux-thread-db.c: Fix common/ includes.
2575         * linux-nat.c: Fix common/ includes.
2576         * linux-fork.c: Fix common/ includes.
2577         * inline-frame.c: Fix common/ includes.
2578         * infrun.c: Fix common/ includes.
2579         * inflow.c: Fix common/ includes.
2580         * inferior.h: Fix common/ includes.
2581         * inferior.c: Fix common/ includes.
2582         * infcmd.c: Fix common/ includes.
2583         * inf-ptrace.c: Fix common/ includes.
2584         * inf-child.c: Fix common/ includes.
2585         * ia64-linux-nat.c: Fix common/ includes.
2586         * i387-tdep.c: Fix common/ includes.
2587         * i386-tdep.c: Fix common/ includes.
2588         * i386-linux-tdep.c: Fix common/ includes.
2589         * i386-linux-nat.c: Fix common/ includes.
2590         * i386-go32-tdep.c: Fix common/ includes.
2591         * i386-fbsd-tdep.c: Fix common/ includes.
2592         * i386-fbsd-nat.c: Fix common/ includes.
2593         * guile/scm-type.c: Fix common/ includes.
2594         * guile/guile.c: Fix common/ includes.
2595         * go32-nat.c: Fix common/ includes.
2596         * gnu-nat.c: Fix common/ includes.
2597         * gdbthread.h: Fix common/ includes.
2598         * gdbarch-selftests.c: Fix common/ includes.
2599         * gdb_usleep.c: Fix common/ includes.
2600         * gdb_select.h: Fix common/ includes.
2601         * gdb_bfd.c: Fix common/ includes.
2602         * gcore.c: Fix common/ includes.
2603         * fork-child.c: Fix common/ includes.
2604         * findvar.c: Fix common/ includes.
2605         * fbsd-nat.c: Fix common/ includes.
2606         * event-top.c: Fix common/ includes.
2607         * event-loop.c: Fix common/ includes.
2608         * dwarf2read.c: Fix common/ includes.
2609         * dwarf2loc.c: Fix common/ includes.
2610         * dwarf2-frame.c: Fix common/ includes.
2611         * dwarf-index-cache.c: Fix common/ includes.
2612         * dtrace-probe.c: Fix common/ includes.
2613         * disasm-selftests.c: Fix common/ includes.
2614         * defs.h: Fix common/ includes.
2615         * csky-tdep.c: Fix common/ includes.
2616         * cp-valprint.c: Fix common/ includes.
2617         * cp-support.h: Fix common/ includes.
2618         * cp-support.c: Fix common/ includes.
2619         * corelow.c: Fix common/ includes.
2620         * completer.h: Fix common/ includes.
2621         * completer.c: Fix common/ includes.
2622         * compile/compile.c: Fix common/ includes.
2623         * compile/compile-loc2c.c: Fix common/ includes.
2624         * compile/compile-cplus-types.c: Fix common/ includes.
2625         * compile/compile-cplus-symbols.c: Fix common/ includes.
2626         * command.h: Fix common/ includes.
2627         * cli/cli-dump.c: Fix common/ includes.
2628         * cli/cli-cmds.c: Fix common/ includes.
2629         * charset.c: Fix common/ includes.
2630         * build-id.c: Fix common/ includes.
2631         * btrace.h: Fix common/ includes.
2632         * btrace.c: Fix common/ includes.
2633         * breakpoint.h: Fix common/ includes.
2634         * breakpoint.c: Fix common/ includes.
2635         * ax.h:
2636         (enum agent_op): Fix common/ includes.
2637         * ax-general.c (struct aop_map): Fix common/ includes.
2638         * ax-gdb.c: Fix common/ includes.
2639         * auxv.c: Fix common/ includes.
2640         * auto-load.c: Fix common/ includes.
2641         * arm-tdep.c: Fix common/ includes.
2642         * arch/riscv.c: Fix common/ includes.
2643         * arch/ppc-linux-common.c: Fix common/ includes.
2644         * arch/i386.c: Fix common/ includes.
2645         * arch/arm.c: Fix common/ includes.
2646         * arch/arm-linux.c: Fix common/ includes.
2647         * arch/arm-get-next-pcs.c: Fix common/ includes.
2648         * arch/amd64.c: Fix common/ includes.
2649         * arch/aarch64.c: Fix common/ includes.
2650         * arch/aarch64-insn.c: Fix common/ includes.
2651         * arch-utils.c: Fix common/ includes.
2652         * amd64-windows-tdep.c: Fix common/ includes.
2653         * amd64-tdep.c: Fix common/ includes.
2654         * amd64-sol2-tdep.c: Fix common/ includes.
2655         * amd64-obsd-tdep.c: Fix common/ includes.
2656         * amd64-nbsd-tdep.c: Fix common/ includes.
2657         * amd64-linux-tdep.c: Fix common/ includes.
2658         * amd64-linux-nat.c: Fix common/ includes.
2659         * amd64-fbsd-tdep.c: Fix common/ includes.
2660         * amd64-fbsd-nat.c: Fix common/ includes.
2661         * amd64-dicos-tdep.c: Fix common/ includes.
2662         * amd64-darwin-tdep.c: Fix common/ includes.
2663         * agent.c: Fix common/ includes.
2664         * ada-lang.h: Fix common/ includes.
2665         * ada-lang.c: Fix common/ includes.
2666         * aarch64-tdep.c: Fix common/ includes.
2667
2668 2019-01-25  Tom Tromey  <tom@tromey.com>
2669
2670         * common/create-version.sh: Use common/version.h.
2671
2672 2019-01-24  Pedro Alves  <palves@redhat.com>
2673
2674         * infrun.c (signal_stop, signal_print, signal_program)
2675         (signal_catch, signal_pass): Now arrays instead of pointers.
2676         (update_signals_program_target, do_target_resume)
2677         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2678         * linux-nat.c (linux_nat_target::pass_signals)
2679         (linux_nat_target::create_inferior, linux_nat_target::attach):
2680         Adjust.
2681         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2682         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2683         * procfs.c (procfs_target::pass_signals): Adjust.
2684         * record-full.c (record_full_target::resume): Adjust.
2685         * remote.c (remote_target::pass_signals)
2686         (remote_target::program_signals): Adjust.
2687         * target-debug.h (target_debug_print_signals): Now takes a
2688         gdb::array_view as parameter.  Adjust.
2689         * target.h (target_ops) <pass_signals, program_signals>: Replace
2690         pointer and length parameters with gdb::array_view.
2691         (target_pass_signals, target_program_signals): Likewise.
2692         * target-delegates.c: Regenerate.
2693
2694 2019-01-24  Pedro Alves  <palves@redhat.com>
2695
2696         * common/forward-scope-exit.h
2697         (forward_scope_exit::forward_scope_exit): Pass arguments to
2698         m_bind_function directly, instead of creating a std::bind and
2699         copying that.
2700
2701 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2702
2703         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2704         for static members.
2705         (pass_in_v_vfp_candidate): Likewise.
2706
2707 2019-01-23  Tom Tromey  <tom@tromey.com>
2708             Pedro Alves  <palves@redhat.com>
2709
2710         * regcache.c (class regcache_invalidator): Remove.
2711         (regcache::raw_write): Use make_scope_exit.
2712
2713 2019-01-23  Tom Tromey  <tom@tromey.com>
2714
2715         * ui-out.h (class ui_out_emit_type): Update comment.
2716
2717 2019-01-23  Tom Tromey  <tom@tromey.com>
2718
2719         * infrun.c (fetch_inferior_event): Update comment.
2720
2721 2019-01-23  Tom Tromey  <tom@tromey.com>
2722             Pedro Alves  <palves@redhat.com>
2723
2724         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2725         parameter.
2726         (fetch_inferior_event): Use SCOPE_EXIT.
2727
2728
2729 2019-01-23  Tom Tromey  <tom@tromey.com>
2730             Pedro Alves  <palves@redhat.com>
2731
2732         * infrun.c (disable_thread_events): Delete.
2733         (stop_all_threads): Use SCOPE_EXIT.
2734
2735 2019-01-23  Tom Tromey  <tom@tromey.com>
2736             Pedro Alves  <palves@redhat.com>
2737
2738         * symfile.c: Include forward-scope-exit.h.
2739         (clear_symtab_users_cleanup): Replace forward declaration with
2740         a FORWARD_SCOPE_EXIT.
2741         (syms_from_objfile_1): Use the forward_scope_exit and
2742         gdb::optional instead of cleanup_function.
2743         (reread_symbols): Use the forward_scope_exit instead of
2744         cleanup_function.
2745         (clear_symtab_users_cleanup): Remove function.
2746
2747 2019-01-23  Tom Tromey  <tom@tromey.com>
2748             Pedro Alves  <palves@redhat.com>
2749
2750         * linux-nat.c: Include scope-exit.h.
2751         (cleanup_target_stop): Remove.
2752         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2753         SCOPE_EXIT.
2754
2755 2019-01-23  Tom Tromey  <tom@tromey.com>
2756             Pedro Alves  <palves@redhat.com>
2757
2758         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2759         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2760
2761 2019-01-23  Tom Tromey  <tom@tromey.com>
2762             Andrew Burgess  <andrew.burgess@embecosm.com>
2763             Pedro Alves  <palves@redhat.com>
2764
2765         * infrun.c (fetch_inferior_event): Use scope_exit.
2766         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2767         * top.c (execute_command): Use scope_exit.
2768         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2769         * utils.c (do_bpstat_clear_actions_cleanup)
2770         (make_bpstat_clear_actions_cleanup): Remove.
2771
2772 2019-01-23  Tom Tromey  <tom@tromey.com>
2773             Pedro Alves  <palves@redhat.com>
2774
2775         * infrun.c: Include "common/scope-exit.h"
2776         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2777         (wait_for_inferior): Use SCOPE_EXIT.
2778         (fetch_inferior_event): Use scope_exit.
2779
2780 2019-01-23  Tom Tromey  <tom@tromey.com>
2781             Pedro Alves  <palves@redhat.com>
2782
2783         * breakpoint.c (create_breakpoint): Remove cleanup.
2784
2785 2019-01-23  Tom Tromey  <tom@tromey.com>
2786             Andrew Burgess  <andrew.burgess@embecosm.com>
2787             Pedro Alves  <palves@redhat.com>
2788
2789 2019-01-23  Pedro Alves  <palves@redhat.com>
2790
2791         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2792
2793 2019-01-23  Pedro Alves  <palves@redhat.com>
2794             Andrew Burgess  <andrew.burgess@embecosm.com>
2795
2796         * gdbthread.h: Include "common/forward-scope-exit.h".
2797         (scoped_finish_thread_state): Redefine custom class in terms of
2798         forward_scope_exit.
2799
2800 2019-01-23  Pedro Alves  <palves@redhat.com>
2801             Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * common/forward-scope-exit.h: New file.
2804
2805 2019-01-23  Pedro Alves  <palves@redhat.com>
2806             Andrew Burgess  <andrew.burgess@embecosm.com>
2807             Tom Tromey  <tom@tromey.com>
2808
2809         * common/scope-exit.h: New file.
2810
2811 2019-01-23  Pedro Alves  <palves@redhat.com>
2812
2813         * common/preprocessor.h (ESC): Rename to ...
2814         (ESC_PARENS): ... this.
2815         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2816         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2817
2818 2019-01-23  Tom Tromey  <tom@tromey.com>
2819
2820         * language.h (class scoped_switch_to_sym_language_if_auto):
2821         Initialize m_lang in both cases.
2822
2823 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2824
2825         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2826         with XCNEW.
2827
2828 2019-01-22  Tom Tromey  <tom@tromey.com>
2829
2830         * corelow.c: Do not include sys/file.h.
2831
2832 2019-01-22  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-wingeneral.h: Include gdb_curses.h.
2835
2836 2019-01-22  Tom Tromey  <tom@tromey.com>
2837
2838         * source-cache.h (class source_cache) <get_source_lines,
2839         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2840
2841 2019-01-22  Tom Tromey  <tom@tromey.com>
2842
2843         * remote-fileio.h (struct remote_target): Declare.
2844
2845 2019-01-22  Tom Tromey  <tom@tromey.com>
2846
2847         * python/py-arch.c: Do not include py-ref.h.
2848         * python/py-bpevent.c: Do not include py-ref.h.
2849         * python/py-cmd.c: Do not include py-ref.h.
2850         * python/py-continueevent.c: Do not include py-ref.h.
2851         * python/py-event.h: Do not include py-ref.h.
2852         * python/py-evtregistry.c: Do not include py-ref.h.
2853         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2854         * python/py-frame.c: Do not include py-ref.h.
2855         * python/py-framefilter.c: Do not include py-ref.h.
2856         * python/py-function.c: Do not include py-ref.h.
2857         * python/py-infevents.c: Do not include py-ref.h.
2858         * python/py-linetable.c: Do not include py-ref.h.
2859         * python/py-objfile.c: Do not include py-ref.h.
2860         * python/py-param.c: Do not include py-ref.h.
2861         * python/py-prettyprint.c: Do not include py-ref.h.
2862         * python/py-progspace.c: Do not include py-ref.h.
2863         * python/py-symbol.c: Do not include py-ref.h.
2864         * python/py-symtab.c: Do not include py-ref.h.
2865         * python/py-type.c: Do not include py-ref.h.
2866         * python/py-unwind.c: Do not include py-ref.h.
2867         * python/py-utils.c: Do not include py-ref.h.
2868         * python/py-value.c: Do not include py-ref.h.
2869         * python/py-varobj.c: Do not include py-ref.h.
2870         * python/py-xmethods.c: Do not include py-ref.h.
2871         * python/python.c: Do not include py-ref.h.
2872         * varobj.c: Do not include py-ref.h.
2873
2874 2019-01-22  Tom Tromey  <tom@tromey.com>
2875
2876         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2877         keyword for bcache.
2878
2879 2019-01-22  Tom Tromey  <tom@tromey.com>
2880
2881         * compile/compile-cplus-types.c: Remove a comment by #include.
2882
2883 2019-01-22  Tom Tromey  <tom@tromey.com>
2884
2885         * compile/gcc-c-plugin.h: Include compile-internal.h.
2886
2887 2019-01-22  Tom Tromey  <tom@tromey.com>
2888
2889         * stabsread.c (EXTERN): Do not define.
2890         (symnum, next_symbol_text_func, processing_gcc_compilation)
2891         (within_function, global_sym_chain, global_stabs)
2892         (previous_stab_code, this_object_header_files)
2893         (n_this_object_header_files)
2894         (n_allocated_this_object_header_files): Define.
2895         * stabsread.h (EXTERN): Never define.  Use "extern".
2896
2897 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2898
2899         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2900         history_value.
2901
2902 2019-01-21  Tom Tromey  <tom@tromey.com>
2903
2904         * ui-out.c: Fix includes.
2905         * tui/tui-source.c: Fix includes.
2906         * target.c: Fix includes.
2907         * remote.c: Fix includes.
2908         * regcache.c: Fix includes.
2909         * python/py-block.c: Fix includes.
2910         * printcmd.c: Fix includes.
2911         * or1k-tdep.c: Fix includes.
2912         * mi/mi-main.c: Fix includes.
2913         * m32r-tdep.c: Fix includes.
2914         * csky-tdep.c: Fix includes.
2915         * compile/compile-cplus-types.c: Fix includes.
2916         * cli/cli-interp.c: Fix includes.
2917
2918 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2919
2920         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2921         for padding.
2922
2923 2019-01-16  Tom Tromey  <tom@tromey.com>
2924
2925         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2926         earlier.
2927         (struct objfile) <msymbols_range>: Move from top level.
2928         <msymbols>: New method.
2929         (class objfile_msymbols): Remove.
2930         * symtab.c (default_collect_symbol_completion_matches_break_on):
2931         Update.
2932         * symmisc.c (dump_msymbols): Update.
2933         * stabsread.c (scan_file_globals): Update.
2934         * objc-lang.c (info_selectors_command, info_classes_command)
2935         (find_methods): Update.
2936         * minsyms.c (find_solib_trampoline_target): Update.
2937         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2938         * coffread.c (coff_symfile_read): Update.
2939         * ada-lang.c (ada_lookup_simple_minsym)
2940         (ada_collect_symbol_completion_matches): Update.
2941
2942 2019-01-16  Tom Tromey  <tom@tromey.com>
2943
2944         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2945         type.  Remove no-argument constructor.
2946         <iterator::operator++>: Simplify.
2947         <begin>: Update.
2948         <end>: Use minimal_symbol_count.
2949
2950 2019-01-16  Tom Tromey  <tom@tromey.com>
2951
2952         * objfiles.h (struct objfile) <psymtabs>: New method.
2953         (class objfile_psymtabs): Remove.
2954         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2955         typedef.
2956         <range>: New method.
2957         (require_partial_symbols): Change return type.
2958         * psymtab.c (require_partial_symbols)
2959         (psym_expand_symtabs_matching): Update.
2960         * mdebugread.c (parse_partial_symbols): Update.
2961         * dbxread.c (dbx_end_psymtab): Update.
2962
2963 2019-01-15  Tom Tromey  <tom@tromey.com>
2964
2965         * symtab.c (lookup_objfile_from_block)
2966         (lookup_symbol_in_objfile_symtabs)
2967         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2968         (find_line_symtab, info_sources_command)
2969         (default_collect_symbol_completion_matches_break_on)
2970         (make_source_files_completion_list): Update.
2971         * symmisc.c (print_objfile_statistics, dump_objfile)
2972         (maintenance_print_symbols, maintenance_info_symtabs)
2973         (maintenance_check_symtabs, maintenance_info_line_tables):
2974         Update.
2975         * source.c (select_source_symtab)
2976         (forget_cached_source_info_for_objfile): Update.
2977         * objfiles.h (class objfile_compunits): Remove.
2978         (struct objfile) <compunits_range>: New typedef.
2979         (compunits): New method.
2980         * objfiles.c (objfile_relocate1): Update.
2981         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2982         * maint.c (count_symtabs_and_blocks): Update.
2983         * linespec.c (iterate_over_all_matching_symtabs): Update.
2984         * cp-support.c (add_symbol_overload_list_qualified): Update.
2985         * coffread.c (coff_symtab_read): Update.
2986         * ada-lang.c (add_nonlocal_symbols)
2987         (ada_collect_symbol_completion_matches)
2988         (ada_add_global_exceptions): Update.
2989
2990 2019-01-15  Tom Tromey  <tom@tromey.com>
2991
2992         * progspace.h (program_space) <objfiles_safe_range>: New
2993         typedef.
2994         <objfiles_safe>: New method.
2995         * objfiles.h (class all_objfiles_safe): Remove.
2996         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2997         * jit.c (jit_inferior_exit_hook): Update.
2998
2999 2019-01-17  Tom Tromey  <tom@tromey.com>
3000
3001         * progspace.h (program_space) <objfiles_range>: New typedef.
3002         <objfiles>: New method.
3003         <objfiles_head>: Rename from objfiles.
3004         (object_files): Update.
3005         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3006         * guile/scm-pretty-print.c
3007         (ppscm_find_pretty_printer_from_objfiles): Update.
3008         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3009         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3010         Update.
3011         * python/py-progspace.c (pspy_get_objfiles): Update.
3012         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3013         Update.
3014         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3015         (objfpy_lookup_objfile_by_build_id): Update.
3016         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3017         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3018         Update.
3019         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3020         (expand_symtab_containing_pc, lookup_objfile_from_block)
3021         (lookup_static_symbol, basic_lookup_transparent_type)
3022         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3023         (find_line_symtab, info_sources_command)
3024         (default_collect_symbol_completion_matches_break_on)
3025         (make_source_files_completion_list, find_main_name): Update.
3026         * symmisc.c (print_symbol_bcache_statistics)
3027         (print_objfile_statistics, maintenance_print_symbols)
3028         (maintenance_print_msymbols, maintenance_print_objfiles)
3029         (maintenance_info_symtabs, maintenance_check_symtabs)
3030         (maintenance_expand_symtabs, maintenance_info_line_tables):
3031         Update.
3032         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3033         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3034         (map_overlay_command, unmap_overlay_command)
3035         (simple_overlay_update, expand_symtabs_matching)
3036         (map_symbol_filenames): Update.
3037         * symfile-debug.c (set_debug_symfile): Update.
3038         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3039         Update.
3040         * source.c (select_source_symtab, forget_cached_source_info):
3041         Update.
3042         * solib.c (solib_read_symbols): Update.
3043         * solib-spu.c (append_ocl_sos): Update.
3044         * psymtab.c (maintenance_print_psymbols)
3045         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3046         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3047         * printcmd.c (info_symbol_command): Update.
3048         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3049         Update.
3050         * objfiles.h (class all_objfiles): Remove.
3051         * objfiles.c (have_partial_symbols, have_full_symbols)
3052         (have_minimal_symbols, qsort_cmp, update_section_map)
3053         (shared_objfile_contains_address_p)
3054         (default_iterate_over_objfiles_in_search_order): Update.
3055         * objc-lang.c (info_selectors_command, info_classes_command)
3056         (find_methods): Update.
3057         * minsyms.c (find_solib_trampoline_target): Update.
3058         * maint.c (maintenance_info_sections)
3059         (maintenance_translate_address, count_symtabs_and_blocks):
3060         Update.
3061         * main.c (captured_main_1): Update.
3062         * linux-thread-db.c (try_thread_db_load_from_pdir)
3063         (has_libpthread): Update.
3064         * linespec.c (iterate_over_all_matching_symtabs)
3065         (search_minsyms_for_name): Update.
3066         * jit.c (jit_find_objf_with_entry_addr): Update.
3067         * hppa-tdep.c (find_unwind_entry)
3068         (hppa_lookup_stub_minimal_symbol): Update.
3069         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3070         Update.
3071         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3072         (elf_gnu_ifunc_resolve_by_got): Update.
3073         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3074         * dwarf-index-write.c (save_gdb_index_command): Update.
3075         * cp-support.c (add_symbol_overload_list_qualified): Update.
3076         * breakpoint.c (create_overlay_event_breakpoint)
3077         (create_longjmp_master_breakpoint)
3078         (create_std_terminate_master_breakpoint)
3079         (create_exception_master_breakpoint): Update.
3080         * blockframe.c (find_pc_partial_function): Update.
3081         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3082         (ada_collect_symbol_completion_matches)
3083         (ada_add_global_exceptions): Update.
3084
3085 2019-01-17  Tom Tromey  <tom@tromey.com>
3086
3087         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3088         declare VEC.
3089         (solib_target_parse_libraries): Change return type.
3090         (library_list_start_segment, library_list_start_section)
3091         (library_list_end_library, library_list_start_library); Update.
3092         (solib_target_free_library_list): Remove.
3093         (solib_target_parse_libraries): Remove cleanup.  Change return
3094         type.
3095         (solib_target_current_sos): Update.
3096
3097 2019-01-17  Tom Tromey  <tromey@bapiya>
3098
3099         * valprint.c: Replace "the the" with "the".
3100         * symtab.c: Replace "the the" with "the".
3101         * solib.c: Replace "the the" with "the".
3102         * solib-dsbt.c: Replace "the the" with "the".
3103         * linespec.c: Replace "the the" with "the".
3104         * dwarf2loc.h: Replace "the the" with "the".
3105         * amd64-windows-tdep.c: Replace "the the" with "the".
3106         * aarch64-tdep.c: Replace "the the" with "the".
3107
3108 2019-01-16  Keith Seitz  <keiths@redhat.com>
3109
3110         PR gdb/23773
3111         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3112         <builder>: Rename to ..
3113         <m_builder>: ... this and make private.
3114         (dwarf2_cu::get_builder): New method.  Change all users of
3115         `builder' to use this method.
3116         (dwarf2_start_symtab): Move to ...
3117         (dwarf2_cu::start_symtab): ... here.  Update all callers
3118         (setup_type_unit_groups): Move to ...
3119         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3120         callers.
3121         (dwarf2_cu::reset_builder): New method.
3122         (process_full_compunit, process_full_type_unit): Use
3123         dwarf2_cu::reset_builder.
3124         (follow_die_offset): Record the ancestor CU if it is different
3125         from the followed DIE's CU.
3126         (follow_die_sig_1): Likewise.
3127
3128 2019-01-15  Tom Tromey  <tom@tromey.com>
3129
3130         * remote.c (class remote_state) <buf>: Now a char_vector.
3131         <buf_size>: Remove.
3132         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3133         parameter.
3134         (remote_target::getpkt_or_notif_sane_1)
3135         (remote_target::getpkt_sane)
3136         (remote_target::getpkt_or_notif_sane): Likewise.
3137         (class remote_target) <putpkt>: New overload.
3138         (remote_target::read_frame): Change type of "buf_p".  Remove
3139         sizeof_p parameter.
3140         (packet_ok): New overload.
3141         (packet_check_result): New overload.
3142         Update all uses.
3143
3144 2019-01-14  Tom Tromey  <tom@tromey.com>
3145
3146         * remote-notif.c (handle_notification, remote_notif_ack)
3147         (remote_notif_parse): Make "buf" const.
3148         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3149         const.
3150         (remote_notif_parse, remote_notif_ack, handle_notification):
3151         Likewise.
3152         * remote.c (remote_notif_stop_parse): Make "buf" const.
3153         (remote_target::remote_parse_stop_reply): Make "buf" const.
3154         (remote_notif_stop_ack): Make "buf" const.
3155
3156 2019-01-14  Tom Tromey  <tom@tromey.com>
3157
3158         * remote.c (remote_console_output): Make parameter const.
3159
3160 2019-01-14  Tom Tromey  <tom@tromey.com>
3161
3162         * target-debug.h (target_debug_print_signals): Constify.
3163         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3164         * procfs.c (procfs_target::pass_signals): Update.
3165         * linux-nat.c (linux_nat_target::pass_signals): Update.
3166         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3167         * target-delegates.c: Rebuild.
3168         * remote.c (remote_target::program_signals): Update.
3169         (remote_target::pass_signals): Update.
3170         * target.c (target_pass_signals): Constify argument.
3171         (target_program_signals): Likewise.
3172         * target.h (struct target_ops) <pass_signals, program_signals>:
3173         Constify argument.
3174         (target_pass_signals, target_program_signals): Constify argument.
3175
3176 2019-01-14  Tom Tromey  <tom@tromey.com>
3177
3178         PR tui/28819:
3179         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3180
3181 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3182
3183         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3184         field.
3185         * rs6000-tdep.c: Include reggroups.h.
3186         (IS_V_ALIAS_PSEUDOREG): Define.
3187         (rs6000_register_name): Return names for the "vX" aliases.
3188         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3189         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3190         aliases.  Call default_register_reggroup_p for all other
3191         pseudo-registers.
3192         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3193         New functions.
3194         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3195         Handle "vX" aliases.
3196         (v_alias_pseudo_register_collect): New function.
3197         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3198         (rs6000_gdbarch_init): Initialize "vX" aliases as
3199         pseudo-registers.  Restore registration of
3200         rs6000_pseudo_register_reggroup_p with
3201         set_tdesc_pseudo_register_reggroup_p.
3202
3203 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3204
3205         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3206         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3207         set_gdbarch_num_pseudo_regs.
3208
3209 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3210
3211         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3212         Remove arg prefixname, add do_set and do_show.
3213         Add member functions set_list and show_list.
3214         * cli/cli-style.c (class cli_style_option): Update accordingly.
3215         (style_set_list): Move to file scope.
3216         (style_show_list): Likewise.
3217         (set_style): Call help_list.
3218         (show_style): Call cmd_show_list.
3219         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3220         Update to use the new macro.
3221
3222 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3223
3224         * ada-lang.c (_initialize_ada_language): Expand the help text
3225         for the "catch exception" command.
3226
3227 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3228
3229         * symtab.c (matching_obj_sections): Initialize obj,
3230         declare it closer to its usage.
3231
3232 2019-01-10  Tom Tromey  <tom@tromey.com>
3233
3234         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3235         (basic_inf_threads_range): Remove.
3236         (inf_threads_range, inf_non_exited_threads_range)
3237         (safe_inf_threads_range): Use next_adapter.
3238
3239 2019-01-10  Keith Seitz  <keiths@redhat.com>
3240
3241         PR gdb/23712
3242         PR symtab/23010
3243         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3244         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3245
3246 2019-01-10  Keith Seitz  <keiths@redhat.com>
3247
3248         PR gdb/23712
3249         PR symtab/23010
3250         * dictionary.c (pending_to_vector): Remove.
3251         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3252         Remove _1 suffix, replacing functions of the same name.  Update
3253         all callers.
3254         (dict_create_hashed, dict_create_hashed_expandable)
3255         (dict_create_linear, dict_create_linear_expandable, dict_free)
3256         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3257         Make functions static.
3258
3259 2019-01-10  Keith Seitz  <keiths@redhat.com>
3260
3261         PR gdb/23712
3262         PR symtab/23010
3263         * dictionary.h (struct dictionary): Replace declaration with
3264         multidictionary.
3265         (dict_create_hashed, dict_create_hashed_expandable)
3266         (dict_create_linear, dict_create_linear_expandable)
3267         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3268         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3269         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3270         taking multidictionary argument.
3271         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3272         * block.h (struct block) <dict>: Change to multidictionary
3273         and rename `multidict'.
3274         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3275         symmisc.c: Update all dictionary references to multidictionary.
3276
3277 2019-01-10  Keith Seitz  <keiths@redhat.com>
3278
3279         PR gdb/23712
3280         PR symtab/23010
3281         * dictionary.c: Include unordered_map.
3282         (pending_to_vector): New function.
3283         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3284         Rewrite the non-"_1" functions to take vector instead
3285         of linked list.
3286         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3287         "new" _1 versions of the same name.
3288         (multidictionary): Define.
3289         (std::hash<enum language): New definition.
3290         (collate_pending_symbols_by_language, mdict_create_hashed)
3291         (mdict_create_hashed_expandable, mdict_create_linear)
3292         (mdict_create_linear_expandable, mdict_free)
3293         (find_language_dictionary, create_new_language_dictionary)
3294         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3295         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3296         (mdict_size, mdict_empty): New functions.
3297         * dictionary.h (mdict_iterator): Define.
3298
3299 2019-01-10  Pedro Alves  <palves@redhat.com>
3300
3301         * breakpoint.c (read_uploaded_action)
3302         (create_tracepoint_from_upload): Adjust to use
3303         gdb::unique_xmalloc_ptr.
3304         * ctf.c (ctf_write_uploaded_tp):
3305         (SET_ARRAY_FIELD): Use emplace_back.
3306         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3307         * tracefile-tfile.c (tfile_write_uploaded_tp):
3308         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3309         gdb::unique_xmalloc_ptr.
3310         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3311         at_string, cond_string, cmd_strings>: Replace char pointers
3312         with gdb::unique_xmalloc_ptr.
3313
3314 2019-01-10  Pedro Alves  <palves@redhat.com>
3315
3316         * solib-target.c (library_list_start_library): Don't xstrdup name.
3317
3318 2019-01-10  Pedro Alves  <palves@redhat.com>
3319
3320         * mdebugread.c (parse_partial_symbols): Use
3321         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3322
3323 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * linux-fork.c (scoped_switch_fork_info)
3326         <~scoped_switch_fork_info>: Fix incorrect variable name.
3327
3328 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * linux-fork.c (scoped_switch_fork_info)
3331         <scoped_switch_fork_info>: Make explicit.
3332         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3333
3334 2019-01-10  Tom Tromey  <tom@tromey.com>
3335
3336         * objfiles.h (objfile::reset_psymtabs): Update.
3337         * objfiles.c (objfile::objfile): Update.
3338         * psymtab.h (psymtab_storage::obstack): Update.
3339         (psymtab_storage::m_obstack): Use gdb::optional.
3340         (class psymtab_storage): Update comment.  Remove objfile
3341         parameter.
3342         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3343
3344 2019-01-10  Tom Tromey  <tom@tromey.com>
3345
3346         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3347         <free_psymtabs>: Now private.
3348         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3349         (allocate_psymtab): Use new method.
3350
3351 2019-01-10  Tom Tromey  <tom@tromey.com>
3352
3353         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3354         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3355         * mdebugread.c (parse_partial_symbols): Use
3356         allocate_dependencies.
3357         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3358         allocate_dependencies.
3359         (process_psymtab_comp_unit_reader)
3360         (build_type_psymtab_dependencies): Likewise.
3361         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3362
3363 2019-01-10  Tom Tromey  <tom@tromey.com>
3364
3365         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3366         PSYMBOL_SET_LANGUAGE.
3367         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3368
3369 2019-01-10  Tom Tromey  <tom@tromey.com>
3370
3371         * psymtab.h (psymtab_storage::obstack): New method.
3372         <m_obstack>: Rename from obstack; now private.
3373         * psymtab.c (psymtab_storage): Update.
3374         * dwarf2read.c (create_addrmap_from_index)
3375         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3376         Update.
3377
3378 2019-01-10  Tom Tromey  <tom@tromey.com>
3379
3380         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3381         * objfiles.h (objfile::reset_psymtabs): New method.
3382
3383 2019-01-10  Tom Tromey  <tom@tromey.com>
3384
3385         * symmisc.c (print_symbol_bcache_statistics): Update.
3386         (print_objfile_statistics): Update.
3387         * symfile.c (reread_symbols): Update.
3388         * psymtab.h (class psymtab_storage): New.
3389         * psymtab.c (psymtab_storage): New constructor.
3390         (~psymtab_storage): New destructor.
3391         (require_partial_symbols): Update.
3392         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3393         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3394         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3395         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3396         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3397         (start_psymtab_common, end_psymtab_common)
3398         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3399         (allocate_psymtab): Update.
3400         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3401         Update.
3402         (dump_psymtab_addrmap, maintenance_print_psymbols)
3403         (maintenance_check_psymtabs): Update.
3404         (class objfile_psymtabs): Move to objfiles.h.
3405         * psympriv.h (discard_psymtab): Now inline.
3406         (psymtab_discarder::psymtab_discarder): Update.
3407         (psymtab_discarder::~psymtab_discarder): Update.
3408         (ALL_OBJFILE_PSYMTABS): Rewrite.
3409         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3410         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3411         Remove fields.
3412         <partial_symtabs>: New field.
3413         (class objfile_psymtabs): Move from psymtab.h.  Update.
3414         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3415         psymbol_cache.
3416         (objfile::~objfile): Don't destroy psymbol_cache.
3417         * mdebugread.c (parse_partial_symbols): Update.
3418         * dwarf2read.c (create_addrmap_from_index)
3419         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3420         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3421         (add_partial_subprogram, dwarf2_ranges_read): Update.
3422         * dwarf-index-write.c (write_address_map)
3423         (write_one_signatured_type, recursively_write_psymbols)
3424         (class debug_names, class debug_names, write_psymtabs_to_index):
3425         Update.
3426
3427 2019-01-10  Tom Tromey  <tom@tromey.com>
3428
3429         * symtab.h (SYMBOL_SET_NAMES): Update.
3430         (symbol_set_names): Update.
3431         (MSYMBOL_SET_NAMES): Update.
3432         * symtab.c (symbol_set_names): Change argument to be an
3433         objfile_per_bfd_storage.
3434         * psymtab.c (add_psymbol_to_bcache): Update.
3435         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3436
3437 2019-01-10  Tom Tromey  <tom@tromey.com>
3438
3439         * symtab.c (create_demangled_names_hash): Change argument to be an
3440         objfile_per_bfd_storage.
3441         (symbol_set_names): Update.
3442
3443 2019-01-10  Tom Tromey  <tom@tromey.com>
3444
3445         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3446         init_psymbol_list.
3447         * psymtab.c (init_psymbol_list): Do nothing if already called.
3448         * psympriv.h (init_psymbol_list): Add comment.
3449         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3450         init_psymbol_list.
3451         * dbxread.c (dbx_symfile_read): Unconditionally call
3452         init_psymbol_list.
3453
3454 2019-01-10  Tom Tromey  <tom@tromey.com>
3455
3456         * xcoffread.c (scan_xcoff_symtab): Update.
3457         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3458         "where".
3459         * mdebugread.c (parse_partial_symbols)
3460         (handle_psymbol_enumerators): Update.
3461         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3462         * dbxread.c (read_dbx_symtab): Update.
3463         * psympriv.h (psymbol_placement): New enum.
3464         (add_psymbol_to_list): Update.
3465
3466 2019-01-10  Tom Tromey  <tom@tromey.com>
3467
3468         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3469         static_psymbols parameters.
3470         (scan_xcoff_symtab): Update.
3471         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3472         static_psymbols parameters.
3473         * psympriv.h (start_psymtab_common): Update.
3474         * mdebugread.c (parse_partial_symbols): Update.
3475         * dwarf2read.c (create_partial_symtab): Update.
3476         * dbxread.c (read_dbx_symtab): Update.
3477         (start_psymtab): Remove global_psymbols and static_psymbols
3478         parameters.
3479
3480 2019-01-10  Tom Tromey  <tom@tromey.com>
3481
3482         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3483         * psymtab.c (allocate_psymtab): Add comment.
3484         * psympriv.h (allocate_psymtab): Add comment.
3485         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3486         initializations.
3487         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3488
3489 2019-01-10  Tom Tromey  <tom@tromey.com>
3490
3491         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3492         Don't declare.
3493         * mipsread.c: Include mdebugread.h.
3494         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3495         Declare.
3496         * elfread.c: Include mdebugread.h.
3497
3498 2019-01-09  Tom Tromey  <tom@tromey.com>
3499
3500         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3501         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3502         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3503         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3504         (psym_lookup_symbol, psym_find_last_source_symtab)
3505         (psym_forget_cached_source_info, psym_print_stats)
3506         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3507         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3508         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3509         (psym_find_compunit_symtab_by_address)
3510         (maintenance_print_psymbols, maintenance_info_psymtabs)
3511         (maintenance_check_psymtabs): Use ranged for.
3512         * psymtab.h (class objfile_psymtabs): New.
3513         (require_partial_symbols): Return objfile_psymtabs.
3514         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3515
3516 2019-01-09  Tom Tromey  <tom@tromey.com>
3517
3518         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3519         (find_pc_mapped_section, list_overlays_command)
3520         (map_overlay_command, unmap_overlay_command)
3521         (simple_overlay_update): Use all_objfiles.
3522         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3523         * printcmd.c (info_symbol_command): Use all_objfiles.
3524         * objfiles.h (ALL_OBJSECTIONS): Remove.
3525         * maint.c (maintenance_translate_address): Use all_objfiles.
3526         * gcore.c (gcore_create_callback): Use all_objfiles.
3527         (objfile_find_memory_regions): Likewise.
3528
3529 2019-01-09  Tom Tromey  <tom@tromey.com>
3530
3531         * symtab.c (find_line_symtab, info_sources_command)
3532         (make_source_files_completion_list): Use objfile_compunits.
3533         * source.c (select_source_symtab): Use objfile_compunits.
3534         * objfiles.h (struct objfile): Update comment.
3535         (ALL_OBJFILES): Remove.
3536         (ALL_FILETABS): Remove.
3537         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3538         objfile_compunits.
3539
3540 2019-01-09  Tom Tromey  <tom@tromey.com>
3541
3542         * symmisc.c (print_objfile_statistics, dump_objfile)
3543         (maintenance_print_symbols): Use compunit_filetabs.
3544         * source.c (forget_cached_source_info_for_objfile): Use
3545         compunit_filetabs.
3546         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3547         (ALL_FILETABS): Use compunit_filetabs.
3548         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3549         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3550
3551 2019-01-09  Tom Tromey  <tom@tromey.com>
3552
3553         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3554         (compunit_filetabs): New.
3555         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3556         compunit_filetabs.
3557         (info_sources_command, make_source_files_completion_list): Remove
3558         declaration.
3559         * symmisc.c (print_objfile_statistics, dump_objfile)
3560         (maintenance_print_symbols): Remove declaration.
3561         (maintenance_info_symtabs): Use compunit_filetabs.
3562         (maintenance_info_line_tables): Likewise.
3563         * source.c (select_source_symtab): Change local variable name.
3564         (forget_cached_source_info_for_objfile): Remove declaration.
3565         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3566         * objfiles.c (objfile_relocate1): Remove declaration.
3567         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3568         declaration.
3569         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3570         * coffread.c (coff_symtab_read): Remove declaration.
3571         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3572         compunit_filetabs.
3573
3574 2019-01-09  Tom Tromey  <tom@tromey.com>
3575
3576         * symtab.c (lookup_objfile_from_block)
3577         (find_pc_sect_compunit_symtab, search_symbols)
3578         (default_collect_symbol_completion_matches_break_on): Use
3579         objfile_compunits.
3580         * objfiles.h (ALL_COMPUNITS): Remove.
3581         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3582         * cp-support.c (add_symbol_overload_list_qualified): Use
3583         objfile_compunits.
3584         * ada-lang.c (ada_collect_symbol_completion_matches)
3585         (ada_add_global_exceptions): Use objfile_compunits.
3586
3587 2019-01-09  Tom Tromey  <tom@tromey.com>
3588
3589         * source.c (select_source_symtab)
3590         (forget_cached_source_info_for_objfile): Remove declaration.
3591         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3592         declaration.
3593         * maint.c (count_symtabs_and_blocks): Remove declaration.
3594         * cp-support.c (add_symbol_overload_list_qualified): Remove
3595         declaration.
3596         * coffread.c (coff_symtab_read): Remove declaration.
3597         * symtab.c (lookup_symbol_in_objfile_symtabs)
3598         (basic_lookup_transparent_type_1): Use objfile_compunits.
3599         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3600         (info_sources_command, search_symbols)
3601         (default_collect_symbol_completion_matches_break_on)
3602         (make_source_files_completion_list): Remove declaration.
3603         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3604         (ada_collect_symbol_completion_matches)
3605         (ada_add_global_exceptions): Remove declaration.
3606         * linespec.c (iterate_over_all_matching_symtabs): Use
3607         objfile_compunits.
3608         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3609         (class objfile_compunits): New.
3610         (ALL_COMPUNITS): Use objfile_compunits.
3611         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3612         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3613         objfile_compunits.
3614         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3615
3616 2019-01-09  Tom Tromey  <tom@tromey.com>
3617
3618         * symtab.c (search_symbols)
3619         (default_collect_symbol_completion_matches_break_on): Use
3620         objfile_msymbols.
3621         * ada-lang.c (ada_lookup_simple_minsym)
3622         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3623         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3624         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3625         objfile_msymbols.
3626         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3627         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3628         * objc-lang.c (find_methods): Use objfile_msymbols.
3629         (info_selectors_command, info_classes_command): Likewise.
3630         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3631         * objfiles.h (class objfile_msymbols): New.
3632         (ALL_OBJFILE_MSYMBOLS): Remove.
3633         (ALL_MSYMBOLS): Remove.
3634
3635 2019-01-09  Tom Tromey  <tom@tromey.com>
3636
3637         * common/next-iterator.h (next_adapter): Add Iterator template
3638         parameter.
3639         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3640         (class all_objfiles_safe): New.
3641         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3642         * objfiles.c (put_objfile_before): Update comment.
3643         (add_separate_debug_objfile): Likewise.
3644         (free_all_objfiles): Use all_objfiles_safe.
3645         (objfile_purge_solibs): Likewise.
3646
3647 2019-01-09  Tom Tromey  <tom@tromey.com>
3648
3649         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3650         (expand_symtab_containing_pc, lookup_static_symbol)
3651         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3652         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3653         all_objfiles.
3654         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3655         * breakpoint.c (create_overlay_event_breakpoint)
3656         (create_longjmp_master_breakpoint)
3657         (create_std_terminate_master_breakpoint)
3658         (create_exception_master_breakpoint): Use all_objfiles.
3659         * linux-thread-db.c (try_thread_db_load_from_pdir)
3660         (has_libpthread): Use all_objfiles.
3661         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3662         * linespec.c (iterate_over_all_matching_symtabs)
3663         (search_minsyms_for_name): Use all_objfiles.
3664         * maint.c (maintenance_info_sections): Use all_objfiles.
3665         * main.c (captured_main_1): Use all_objfiles.
3666         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3667         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3668         * guile/scm-pretty-print.c
3669         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3670         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3671         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3672         (maintenance_print_msymbols): Use all_objfiles.
3673         * source.c (select_source_symtab): Use all_objfiles.
3674         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3675         * symfile.c (remove_symbol_file_command)
3676         (expand_symtabs_matching, map_symbol_filenames): Use
3677         all_objfiles.
3678         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3679         all_objfiles.
3680         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3681         * objc-lang.c (find_methods): Use all_objfiles.
3682         * objfiles.c (have_partial_symbols, have_full_symbols)
3683         (have_minimal_symbols, qsort_cmp)
3684         (default_iterate_over_objfiles_in_search_order): Use
3685         all_objfiles.
3686         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3687         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3688         (maintenance_check_psymtabs): Use all_objfiles.
3689         (ALL_PSYMTABS): Remove.
3690         * compile/compile-object-run.c (do_module_cleanup): Use
3691         all_objfiles.
3692         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3693         * cp-support.c (add_symbol_overload_list_qualified): Use
3694         all_objfiles.
3695         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3696         Use all_objfiles.
3697         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3698         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3699         all_objfiles.
3700         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3701         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3702         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3703         Uses all_objfiles.
3704         * solib.c (solib_read_symbols): Use all_objfiles
3705
3706 2019-01-09  Tom Tromey  <tom@tromey.com>
3707
3708         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3709         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3710         all_objfiles.
3711         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3712         * symmisc.c (print_symbol_bcache_statistics)
3713         (print_objfile_statistics, maintenance_print_objfiles)
3714         (maintenance_info_symtabs, maintenance_check_symtabs)
3715         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3716         all_objfiles.
3717         * source.c (forget_cached_source_info): Use all_objfiles.
3718         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3719         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3720         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3721         * objfiles.c (update_section_map): Use all_objfiles.
3722         (shared_objfile_contains_address_p): Likewise.
3723         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3724         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3725
3726 2019-01-09  Tom Tromey  <tom@tromey.com>
3727
3728         * common/next-iterator.h: New file.
3729         * objfiles.h (class all_objfiles): New.
3730         (struct objfile_iterator): New.
3731
3732 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3733
3734         * NEWS: Move the description of the changed "frame", "select-frame",
3735          and "info frame" commands to the Changed commands section.
3736
3737 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3738
3739         * gdbtypes.c (check_stub_method_group): Remove handling of old
3740         mangling schemes.
3741         * linespec.c (find_methods): Likewise.
3742         * stabsread.c (read_member_functions): Likewise.
3743         * valops.c (search_struct_method): Likewise.
3744         (value_struct_elt_for_reference): Likewise.
3745         * NEWS: Mention this change.
3746
3747 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3748
3749         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3750         print_source_lines.
3751         * source.c (print_source_lines_base): Update line number check.
3752         (print_source_lines): New function.
3753         (source_lines_range::source_lines_range): New function.
3754         * source.h (class source_lines_range): New class.
3755         (print_source_lines): New declaration.
3756
3757 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3758
3759         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3760
3761 2019-01-08  Tom Tromey  <tom@tromey.com>
3762             Simon Marchi  <simon.marchi@ericsson.com>
3763
3764         PR gdb/24060
3765         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3766         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3767         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3768         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3769         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3770         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3771
3772 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3773
3774         * source.c (select_source_symtab): Move header comment to
3775         declaration in source.h.
3776         (forget_cached_source_info_for_objfile): Likewise.
3777         (forget_cached_source_info): Likewise.
3778         (identify_source_line): Likewise.
3779         * source.h (identify_source_line): Move declaration from symtab.h
3780         and add comment from source.c
3781         (print_source_lines): Likewise.
3782         (forget_cached_source_info_for_objfile): Likewise.
3783         (forget_cached_source_info): Likewise.
3784         (select_source_symtab): Likewise.
3785         (enum print_source_lines_flag): Move definition from symtab.h.
3786         * symtab.h (identify_source_line): Move declaration to source.h.
3787         (print_source_lines): Likewise.
3788         (forget_cached_source_info_for_objfile): Likewise.
3789         (forget_cached_source_info): Likewise.
3790         (select_source_symtab): Likewise.
3791         (enum print_source_lines_flag): Move definition to source.h.
3792         * tui/tui-hooks.c: Add 'source.h' include.
3793
3794 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * source.c (print_source_lines_base): Handle requests to print
3797         reverse line number sequences, and guard against empty lines
3798         string.
3799
3800 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * source.c (print_source_lines_base): Fix skip of '\r' if next
3803         character is '\n'.
3804
3805 2019-01-06  Tom Tromey  <tom@tromey.com>
3806
3807         * c-exp.y (struct c_parse_state) <macro_original_text,
3808         expansion_obstack>: New member.
3809         (macro_original_text, expansion_obstack): Remove globals.
3810         (scan_macro_expansion, scanning_macro_expansion)
3811         (finished_macro_expansion): Update.
3812         (scan_macro_cleanup): Remove.
3813         (yylex, c_parse): Update.
3814
3815 2019-01-06  Tom Tromey  <tom@tromey.com>
3816
3817         * c-exp.y (struct c_parse_state) <strings>: New member.
3818         (operator_stoken): Update.
3819
3820 2019-01-06  Tom Tromey  <tom@tromey.com>
3821
3822         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3823         (union type_stack_elt) <typelist_val>: Now a pointer to
3824         std::vector.
3825         (type_stack_cleanup): Don't declare.
3826         (push_typelist): Update.
3827         * parse.c (pop_typelist): Return a std::vector.
3828         (push_typelist): Take a std::vector.
3829         (follow_types): Update.  Do not free args.
3830         (type_stack_cleanup): Remove.
3831         * c-exp.y (struct c_parse_state): New.
3832         (cpstate): New global.
3833         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3834         (nonempty_typelist): Update.
3835         (func_mod): Create a new vector.
3836         (c_parse): Create a c_parse_state.
3837         (check_parameter_typelist): Do not delete params.
3838         (function_method): Update.  Do not delete type_list.
3839
3840 2019-01-06  Tom Tromey  <tom@tromey.com>
3841
3842         PR gdb/28155:
3843         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3844         check_typedef.
3845         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3846         (print_return_value): Likewise.
3847
3848 2019-01-05  Tom Tromey  <tom@tromey.com>
3849
3850         * contrib/cleanup_check.py: Remove.
3851         * contrib/gcc-with-excheck: Remove.
3852         * contrib/exsummary.py: Remove.
3853         * contrib/excheck.py: Remove.
3854
3855 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3856
3857         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3858         NULL. Initialize tpprev to NULL instead of assigning it
3859         to NULL on the next statement.
3860         * windows-nat.c (windows_delete_thread): Remove check for
3861         main_thread_id before printing thread exit notifications.
3862         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3863         Remove thread ID check against main_thread_id.
3864         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3865         windows_delete_thread.
3866         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3867
3868 2019-01-04  Tom Tromey  <tom@tromey.com>
3869
3870         * compile/compile.c (_initialize_compile): Use upper case for
3871         metasyntactic variables.
3872         * symmisc.c (_initialize_symmisc): Use upper case for
3873         metasyntactic variables.
3874         * psymtab.c (_initialize_psymtab): Use upper case for
3875         metasyntactic variables.
3876         * demangle.c (demangle_command): Use upper case for metasyntactic
3877         variables.
3878         (_initialize_demangler): Likewise.
3879         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3880         variables.
3881
3882 2019-01-03  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3885
3886 2019-01-03  Tom Tromey  <tom@tromey.com>
3887
3888         * python/py-symtab.c (salpy_str): Update.
3889         (struct salpy_sal_object) <symtab>: Now a PyObject.
3890         (salpy_dealloc): Update.
3891         (del_objfile_sal): Use gdbpy_ref.
3892
3893 2019-01-03  Tom Tromey  <tom@tromey.com>
3894
3895         * python/py-type.c (convert_field): Use new_reference.  Return
3896         gdbpy_ref.
3897         (make_fielditem): Return gdbpy_ref.
3898         (typy_fields): Update.
3899         (typy_getitem): Update.
3900         (field_name): Return gdbpy_ref.  Use new_reference.
3901         (typy_iterator_iternext): Update.
3902
3903 2019-01-03  Tom Tromey  <tom@tromey.com>
3904
3905         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3906
3907 2019-01-03  Tom Tromey  <tom@tromey.com>
3908
3909         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3910         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3911         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3912         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3913         (pspy_set_type_printers): Likewise.
3914         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3915         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3916         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3917         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3918         (objfpy_set_type_printers): Likewise.
3919
3920 2019-01-03  Tom Tromey  <tom@tromey.com>
3921
3922         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3923         (gdbpy_print_stack): Use gdbpy_err_fetch.
3924         * python/python-internal.h (class gdbpy_err_fetch): New class.
3925         (class gdbpy_enter) <m_error_type, m_error_value,
3926         m_error_traceback>: Remove.
3927         <m_error>: New member.
3928         (gdbpy_exception_to_string): Don't declare.
3929         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3930         * python/py-value.c (convert_value_from_python): Use
3931         gdbpy_err_fetch.
3932         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3933         gdbpy_exception_to_string.
3934         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3935         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3936         gdbpy_err_fetch.
3937
3938 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * linux-nat.c (delete_lwp_cleanup): Delete.
3941         (struct lwp_deleter): New struct.
3942         (lwp_info_up): New typedef.
3943         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3944         lwp_info_up.
3945
3946 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * linux-fork.c (class scoped_switch_fork_info): New class.
3949         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3950
3951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * valops.c (find_overload_match): Remove use of null_cleanup, and
3954         calls to do_cleanups.
3955
3956 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3957
3958         * compile/compile-cplus-types.c
3959         (compile_cplus_instance::decl_name): Handle changes to
3960         cp_func_name.
3961         * cp-support.c (cp_func_name): Update header comment, update
3962         return type.
3963         * cp-support.h (cp_func_name): Update return type in declaration.
3964         * valops.c (find_overload_match): Move temp_func local to top
3965         level of function and change its type.  Use temp_func to hold and
3966         delete temporary string obtained from cp_func_name.
3967
3968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3971         gdb::char_vector, remove cleanup, and update uses of `msg`.
3972
3973 2019-01-03  Jim Wilson  <jimw@sifive.com>
3974
3975         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3976
3977 2019-01-02  Tom Tromey  <tom@tromey.com>
3978
3979         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3980         (tdesc_parse_xml): Remove cleanups.
3981         * target-descriptions.h (make_cleanup_free_target_description):
3982         Don't declare.
3983         (target_desc_deleter): New struct.
3984         (target_desc_up): New typedef.
3985         * target-descriptions.c (target_desc_deleter::operator()): Rename
3986         from free_target_description.
3987         (make_cleanup_free_target_description): Remove.
3988
3989 2019-01-02  Tom Tromey  <tom@tromey.com>
3990
3991         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3992         constructor, destructor.
3993         (linespec_parser): Remove typedef.
3994         (~linespec_parser): Rename from linespec_parser_delete.
3995         (linespec_lex_to_end, linespec_complete_label)
3996         (linespec_complete): Update.
3997         (decode_line_full): Remove cleanups.
3998         (decode_line_1): Update.
3999
4000 2019-01-02  Tom Tromey  <tom@tromey.com>
4001
4002         * python/python-internal.h (inferior_to_inferior_object): Change
4003         return type.
4004         * python/py-exitedevent.c (create_exited_event_object): Update.
4005         * python/py-inferior.c (inferior_to_inferior_object): Return
4006         gdbpy_ref.
4007         (python_new_inferior, python_inferior_deleted)
4008         (thread_to_thread_object, delete_thread_object)
4009         (build_inferior_list, gdbpy_selected_inferior): Update.
4010         * python/py-infthread.c (create_thread_object): Update.  Also fail
4011         if inferior_to_inferior_object fails.
4012
4013 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4014
4015         * inferior.h (class inferior) <displaced_step_state>: New field.
4016         * infrun.h (struct displaced_step_state): Move here from
4017         infrun.c.  Initialize fields, add constructor.
4018         <inf>: Remove field.
4019         <reset>: New method.
4020         * infrun.c (struct displaced_step_inferior_state): Move to
4021         infrun.h.
4022         (displaced_step_inferior_states): Remove.
4023         (get_displaced_stepping_state): Adust.
4024         (displaced_step_in_progress_any_inferior): Adjust.
4025         (displaced_step_in_progress_thread): Adjust.
4026         (displaced_step_in_progress): Adjust.
4027         (add_displaced_stepping_state): Remove.
4028         (get_displaced_step_closure_by_addr): Adjust.
4029         (remove_displaced_stepping_state): Remove.
4030         (infrun_inferior_exit): Call displaced_step_state.reset.
4031         (use_displaced_stepping): Don't check for NULL.
4032         (displaced_step_prepare_throw): Call
4033         get_displaced_stepping_state.
4034         (displaced_step_fixup): Don't check for NULL.
4035         (prepare_for_detach): Don't check for NULL.
4036
4037 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4038
4039         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4040          in case of call that did not complete.
4041
4042 2019-01-02  Andrey Utkin  <autkin@undo.io>
4043
4044         * symfile.c (find_separate_debug_file): Fix search of debug files for
4045         remote debuggee.
4046
4047 2019-01-02  Tom Tromey  <tom@tromey.com>
4048
4049         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4050         indentation.
4051         * python/py-frame.c (frapy_older): Remove cast.
4052         (frapy_newer): Likewise.
4053         * python/py-breakpoint.c (local_setattro): Remove cast.
4054         * python/py-arch.c (archpy_name): Remove local variable.
4055         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4056
4057 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4058
4059         * unittests/basic_string_view/element_access/char/empty.cc:
4060         Fix year range in copyright header.
4061
4062 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4063
4064         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4065         Delete.
4066         <operator==>: Update with for removed field.
4067         <hash>: Likewise.
4068         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4069         <isa_features>: ...this.
4070         <abi_features>: New field.
4071         (riscv_isa_flen): Update comment.
4072         (riscv_abi_xlen): New declaration.
4073         (riscv_abi_flen): New declaration.
4074         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4075         isa_features.
4076         (riscv_abi_xlen): New function.
4077         (riscv_isa_flen): Update to get answer from isa_features.
4078         (riscv_abi_flen): New function.
4079         (riscv_has_fp_abi): Update to get answer from abi_features.
4080         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4081         xlen and flen.
4082         (riscv_call_info) <xlen, flen>: Update comment.
4083         (riscv_call_arg_struct): Remove invalid assertions
4084         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4085         is removed.
4086         (riscv_gdbarch_init): Gather isa features and abi features
4087         separately, ensure both match on the gdbarch when reusing an old
4088         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4089         a target with 64-bit float hardware.
4090
4091 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4092
4093         * source.c (search_command_helper): Stop reverse search
4094         when line 1 has been searched.
4095
4096 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097
4098         * record-full.c (record_full_base_target::close): Rewrite
4099         record_full_core_buf_list free logic.
4100
4101 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4102
4103         * break-catch-syscall.c (print_one_catch_syscall): xfree
4104         the last text.
4105
4106 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4107
4108         * top.c (print_gdb_version): Update Copyright year in version
4109         message.
4110
4111 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4112
4113         Update copyright year range in all GDB files.
4114
4115 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4116
4117         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4118
4119 For older changes see ChangeLog-2018.
4120 \f
4121 Local Variables:
4122 mode: change-log
4123 left-margin: 8
4124 fill-column: 74
4125 version-control: never
4126 coding: utf-8
4127 End:
4128