Arm/AArch64: Split DISPLACED_MODIFIED_INSNS name clash
[external/binutils.git] / gdb / ChangeLog
1 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2
3         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4         AARCH64_DISPLACED_MODIFIED_INSNS.
5         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6         (aarch64_displaced_step_copy_insn): Likewise.
7         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
9         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
10         ARM_DISPLACED_MODIFIED_INSNS.
11         * arm-tdep.c (arm_gdbarch_init): Likewise.
12         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
13         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
14         (struct arm_displaced_step_closure): Use
15         ARM_DISPLACED_MODIFIED_INSNS.
16
17 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
18
19         * features/Makefile: Remove unused xml files.
20         * features/aarch64.xml: Remove.
21         * features/i386/amd64-avx-avx512-linux.xml: Remove.
22         * features/i386/amd64-avx-avx512.xml: Remove.
23         * features/i386/amd64-avx-linux.xml: Remove.
24         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
25         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
26         * features/i386/amd64-avx-mpx-linux.xml: Remove.
27         * features/i386/amd64-avx-mpx.xml: Remove.
28         * features/i386/amd64-avx.xml: Remove.
29         * features/i386/amd64-linux.xml: Remove.
30         * features/i386/amd64-mpx-linux.xml: Remove.
31         * features/i386/amd64-mpx.xml: Remove.
32         * features/i386/amd64.xml: Remove.
33         * features/i386/i386-avx-avx512-linux.xml: Remove.
34         * features/i386/i386-avx-avx512.xml: Remove.
35         * features/i386/i386-avx-linux.xml: Remove.
36         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
37         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
38         * features/i386/i386-avx-mpx-linux.xml: Remove.
39         * features/i386/i386-avx-mpx.xml: Remove.
40         * features/i386/i386-avx.xml: Remove.
41         * features/i386/i386-linux.xml: Remove.
42         * features/i386/i386-mmx-linux.xml: Remove.
43         * features/i386/i386-mmx.xml: Remove.
44         * features/i386/i386-mpx-linux.xml: Remove.
45         * features/i386/i386-mpx.xml: Remove.
46         * features/i386/i386.xml: Remove.
47         * features/i386/x32-avx-avx512-linux.xml: Remove.
48         * features/i386/x32-avx-linux.xml: Remove.
49         * features/i386/x32-linux.xml: Remove.
50
51 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
52
53         * regformats/aarch64.dat: Remove.
54         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
55         * regformats/i386/amd64-avx-linux.dat: Remove.
56         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
57         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
58         * regformats/i386/amd64-linux.dat: Remove.
59         * regformats/i386/amd64-mpx-linux.dat: Remove.
60         * regformats/i386/amd64.dat: Remove.
61         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
62         * regformats/i386/i386-avx-linux.dat: Remove.
63         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
64         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
65         * regformats/i386/i386-linux.dat: Remove.
66         * regformats/i386/i386-mmx-linux.dat: Remove.
67         * regformats/i386/i386-mpx-linux.dat: Remove.
68         * regformats/i386/i386.dat: Remove.
69         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
70         * regformats/i386/x32-avx-linux.dat: Remove.
71         * regformats/i386/x32-linux.dat: Remove.
72
73 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
74
75         * aarch64-tdep.c: Remove xml self tests.
76         * amd64-linux-tdep.c: Likewise.
77         * amd64-tdep.c: Likewise.
78         * i386-linux-tdep.c: Likewise.
79         * i386-tdep.c: Likewise.
80
81 2019-07-03  Pedro Alves  <palves@redhat.com>
82
83         PR cli/24732
84         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
85         (pipe_cmd_option_defs): New.
86         (make_pipe_cmd_options_def_group): New.
87         (pipe_command): Use gdb::option::process_options.
88         (pipe_command_completer): New function.
89         (_initialize_cli_cmds): Install completer for "pipe" command.
90
91 2019-07-03  Pedro Alves  <palves@redhat.com>
92
93         * cli/cli-option.c (union option_value) <string>: New field.
94         (struct option_def_and_value): Add ctor, move ctor, dtor and
95         use DISABLE_COPY_AND_ASSIGN.
96         (option_def_and_value::clear_value): New.
97         (parse_option, save_option_value_in_ctx, get_val_type_str)
98         (add_setshow_cmds_for_options): Handle var_string.
99         * cli-option.h (union option_def::var_address) <string>: New
100         field.
101         (struct string_option_def): New.
102         * maint-test-options.c (struct test_options_opts): Add default
103         ctor and use DISABLE_COPY_AND_ASSIGN.
104         <string_opt>: New field.
105         (test_options_opts::~test_options_opts): New.
106         (test_options_opts::dump): Also dump "-string".
107         (test_options_option_defs): Install "string.
108
109 2019-07-03  Pedro Alves  <palves@redhat.com>
110
111         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
112         option_value with a null enumeration.
113         (complete_options): Save the option values in the context.
114         (save_option_value_in_ctx): New, factored out from ...
115         (process_options): ... here.
116         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
117         of the function.
118         * maint-test-options.c (test_options_opts::dump): New, factored
119         out from ...
120         (maintenance_test_options_command_mode): ... here.
121         (maintenance_test_options_command_completion_result): Delete.
122         (maintenance_test_options_command_completion_text): Update
123         comment.
124         (maintenance_show_test_options_completion_result): Change
125         prototype.  Just print
126         maintenance_test_options_command_completion_text.
127         (save_completion_result): New.
128         (maintenance_test_options_completer_mode): Pass options context to
129         complete_options, and then save a dump.
130         (_initialize_maint_test_options): Use add_cmd to install "maint
131         show test-options-completion-result".
132
133 2019-07-03  Pedro Alves  <palves@redhat.com>
134
135         * NEWS (New commands): Mention "with" and "maint with".
136         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
137         (with_command, with_command_completer): New.
138         (pipe_command): Adjust to new repeat_previous
139         interface.
140         (_initialize_cli_cmds): Install the "with" command and its "w"
141         alias.
142         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
143         declarations.
144         * cli/cli-setshow.c (parse_cli_var_uinteger)
145         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
146         argument strings for all var_types.
147         (get_setshow_command_value_string): New, factored out from ...
148         (do_show_command): ... this.
149         * cli/cli-setshow.h: Include <string>.
150         (get_setshow_command_value_string): Declare.
151         * command.h (repeat_previous): Now returns const char *.  Adjust
152         comment.
153         * maint.c: Include "cli/cli-cmds.h".
154         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
155         (_initialize_maint_cmds): Register the "maintenance with" command.
156         * top.c (repeat_previous): Move bits from pipe_command here:
157         Return the saved command line, if any; error out if there's no
158         command to relaunch.
159
160 2019-07-03  Pedro Alves  <palves@redhat.com>
161
162         * NEWS (New commands): Mention "maint set/show test-settings"
163         instead of "maint test-settings".
164         * maint-test-settings.c (maintenance_test_settings_list): Delete.
165         (maintenance_test_settings_set_list): Rename to ...
166         (maintenance_set_test_settings_list): ... this.
167         (maintenance_test_settings_show_list): Rename to  ...
168         (maintenance_show_test_settings_list): ... this.
169         (maintenance_test_settings_cmd): Delete.
170         (maintenance_test_settings_set_cmd): ...
171         (maintenance_set_test_settings_cmd): ... this.
172         (maintenance_test_settings_show_cmd): ...
173         (maintenance_show_test_settings_cmd): ... this.
174         (maintenance_test_settings_show_value_cmd):
175         (maintenance_show_test_settings_value_cmd): ... this.
176         (_initialize_maint_test_settings): No longer install the "maint
177         test-settings" prefix command.  Rename "maint test-settings set"
178         to "maint set test-settings", and "maint test-settings show" to
179         "maint show test-settings".  Adjust all subcommands.
180
181 2019-07-03  Pedro Alves  <palves@redhat.com>
182
183         * maint-test-settings.c: Fix file's intro comment.  Replace all
184         references to "test-options" with references to "test-settings",
185         in comments.
186
187 2019-07-03  Pedro Alves  <palves@redhat.com>
188
189         * maint-test-settings.c (maintenance_test_settings_xxx)
190         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
191         New.
192         (maintenance_test_settings_enums): Use them.
193         (maintenance_test_settings_enum): Default to
194         maintenance_test_settings_xxx.
195         (_initialize_maint_test_settings): Initialize
196         MAINTENANCE_TEST_SETTINGS_FILENAME.
197
198 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
199
200         * breakpoint.h (remove_breakpoints_inf): Change return type to
201         void, move function documentation here.
202         * breakpoint.c (remove_breakpoints_inf): Change return type to
203         void, move function documentation to header.
204
205 2019-07-02  Pedro Alves  <palves@redhat.com>
206
207         * NEWS (Completion improvements): Mention "info threads".
208         * thread.c (struct info_threads_opts, info_threads_option_defs)
209         (make_info_threads_options_def_group): New.
210         (info_threads_command): Use gdb::option::process_options.
211         (info_threads_command_completer): New.
212         (_initialize_thread): Use gdb::option::build_help to build the
213         help text for "info threads".
214
215 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
216
217         * defs.h (generic_load): Move from here...
218         * symfile.h (generic_load): ... to here.  Rename name parameter
219         to args.
220         * symfile.c (generic_load): Add comment.
221
222 2019-07-01  Tom Tromey  <tromey@adacore.com>
223
224         * dwarf2read.c
225         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
226         declaration of without_params.  Fix formatting.
227
228 2019-07-01  Tom Tromey  <tromey@adacore.com>
229
230         * ada-exp.y (find_primitive_type): Update.
231         * ada-lang.h (ada_lookup_symbol): Update.
232         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
233         parameter.
234         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
235
236 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
237
238         PR breakpoints/24541
239         * gdbarch.c: Regenerate.
240         * gdbarch.h: Regenerate.
241         * gdbarch.sh: Add 'stap_adjust_register'.
242         * i386-tdep.c: Include '<unordered_set>'.
243         (i386_stap_adjust_register): New function.
244         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
245         * stap-probe.c (stap_parse_register_operand): Call
246         'gdbarch_stap_adjust_register'.
247
248 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
249
250         PR python/24742
251         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
252         * python/python.c (do_start_initialization): Use 'xmalloc'
253         instead of 'PyMem_Malloc'.
254
255 2019-06-28  Tom Tromey  <tromey@adacore.com>
256
257         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
258         for Ada.
259
260 2019-06-27  Tom Tromey  <tromey@adacore.com>
261
262         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
263         objfile_key.
264         (arm_find_mapping_symbol, arm_record_special_symbol)
265         (_initialize_arm_tdep): Update.
266         (arm_objfile_data_free): Remove.
267
268 2019-06-27  Tom Tromey  <tromey@adacore.com>
269
270         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
271         to cp_print_static_field.
272
273 2019-06-26  Tom Tromey  <tromey@adacore.com>
274
275         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
276         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
277         declare.
278
279 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
280
281         * features/aarch64-core.c (create_feature_aarch64_core):
282         Regenerate.
283         * features/aarch64-core.xml: Add cpsr flags.
284
285 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
286
287         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
288         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
289
290 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
291
292         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
293         field.
294         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
295         use.
296         (arm_record_special_symbol): Don't insert new symbol in sorted
297         position, push it at the end.
298
299 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
300
301         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
302         (arm_mapping_symbol_s): Remove.
303         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
304         (arm_mapping_symbol_vec): New typedef.
305         (struct arm_per_objfile): Add constructor.
306         <section_maps>: Change type to
307         std::unique_ptr<arm_mapping_symbol_vec[]>.
308         (arm_compare_mapping_symbols): Remove.
309         (arm_find_mapping_symbol): Adjust to section_maps type change.
310         (arm_objfile_data_free): Call delete on arm_per_objfile.
311         (arm_record_special_symbol): Adjust to section_maps type change.
312         Allocate arm_per_objfile with new.
313
314 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
315
316         * cli/cli-cmds.c (alias_command): Compare the alias prefix
317         with the command prefix.
318
319 2019-06-25  Tom Tromey  <tom@tromey.com>
320
321         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
322         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
323
324 2019-06-25  Tom Tromey  <tom@tromey.com>
325
326         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
327         type.
328         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
329         protected.
330
331 2019-06-25  Tom Tromey  <tom@tromey.com>
332
333         * tui/tui-winsource.c
334         (tui_source_window_base::set_is_exec_point_at): Add check against
335         LOA_ADDRESS.
336
337 2019-06-25  Tom Tromey  <tom@tromey.com>
338
339         * tui/tui-source.c (tui_set_source_content): Don't check before
340         xfree.
341         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
342
343 2019-06-25  Tom Tromey  <tom@tromey.com>
344
345         * tui/tui-winsource.h (tui_update_source_window_as_is)
346         (tui_alloc_source_buffer, tui_line_is_displayed)
347         (tui_addr_is_displayed): Change type of win_info.
348         * tui/tui-winsource.c (tui_update_source_window_as_is)
349         (tui_clear_source_content, tui_show_source_line)
350         (tui_show_source_content, tui_source_window_base::refill)
351         (tui_source_window_base::set_is_exec_point_at)
352         (tui_source_window_base::set_is_exec_point_at)
353         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
354         (tui_alloc_source_buffer, tui_line_is_displayed)
355         (tui_addr_is_displayed): Change type of win_info.  Update.
356         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
357         (tui_source_window_base::do_make_visible_with_new_height):
358         Update.
359         * tui/tui-source.c (tui_set_source_content)
360         (tui_set_source_content_nil)
361         (tui_source_window::do_scroll_vertical): Update.
362         * tui/tui-layout.c (show_layout): Update.
363         * tui/tui-disasm.c (tui_set_disassem_content)
364         (tui_disasm_window::do_scroll_vertical): Update.
365         * tui/tui-data.h (tui_win_content): Remove.
366         (struct tui_gen_win_info) <content, content_size>: Remove.
367         (struct tui_source_element): Add initializers and destructor.
368         (union tui_which_element, struct tui_win_element): Remove.
369         (struct tui_source_window_base) <content>: New field.
370         (struct tui_data_window): Remove destructor.
371         (tui_alloc_content, tui_free_win_content)
372         (tui_free_all_source_wins_content): Don't declare.
373         * tui/tui-data.c (tui_initialize_static_data): Update.
374         (init_content_element, tui_alloc_content): Remove.
375         (~tui_gen_win_info): Update.
376         (~tui_data_window, tui_free_all_source_wins_content)
377         (tui_free_win_content, free_content, free_content_elements):
378         Remove.
379
380 2019-06-25  Tom Tromey  <tom@tromey.com>
381
382         * tui/tui-winsource.h (tui_clear_source_content)
383         (tui_erase_source_content, tui_show_source_content): Change type
384         of win_info.
385         * tui/tui-winsource.c (tui_clear_source_content)
386         (tui_erase_source_content, tui_show_source_content): Change type
387         of win_info.
388         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
389         * tui/tui-source.h (tui_set_source_content_nil): Change type of
390         win_info.
391         * tui/tui-source.c (tui_set_source_content_nil): Change type of
392         win_info.
393         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
394
395 2019-06-25  Tom Tromey  <tom@tromey.com>
396
397         * tui/tui-winsource.c (tui_clear_source_content)
398         (tui_source_window_base::set_is_exec_point_at): Update.
399         * tui/tui-source.c (tui_set_source_content_nil): Update.
400         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
401         a bool.
402         * tui/tui-data.c (init_content_element): Update.
403
404 2019-06-25  Tom Tromey  <tom@tromey.com>
405
406         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
407         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
408         * tui/tui-layout.c (init_and_make_win): Update.
409         * tui/tui.h (enum tui_win_type): Update.
410         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
411         tui_win_is_auxillary.
412         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
413         tui_win_is_auxillary.
414
415 2019-06-25  Tom Tromey  <tom@tromey.com>
416
417         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
418         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
419         (tui_delete_data_content_windows, tui_display_all_data)
420         (tui_data_window::do_scroll_vertical, tui_display_data_from):
421         Update.
422         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
423         * tui/tui-regs.c (tui_last_regs_line_no)
424         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
425         (tui_show_registers): Update.
426         (tui_show_register_group): Return void.  Update.
427         (tui_display_registers_from, tui_display_reg_element_at_line)
428         (tui_display_registers_from_line, tui_check_register_values):
429         Update.
430         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
431         member.
432         (struct tui_data_window) <regs_content>: Now a std::vector.
433         <regs_content_count>: Remove.
434         (tui_add_content_elements, tui_free_data_content): Don't declare.
435         * tui/tui-data.c (tui_data_window::clear_detail): Update.
436         (init_content_element): Remove DATA_WIN case.  Add assert.
437         (tui_add_content_elements): Remove.
438         (tui_data_window): Update.
439         (tui_free_data_content): Remove.
440         (free_content_elements): Remove DATA_WIN case.
441
442 2019-06-25  Tom Tromey  <tom@tromey.com>
443
444         * tui/tui-data.c (tui_data_item_window): Update.
445         * tui/tui-windata.h (tui_check_data_values): Don't declare.
446         * tui/tui-windata.c (tui_display_all_data)
447         (tui_display_data_from_line): Update.
448         (tui_check_data_values): Remove.
449         * tui/tui-regs.c (tui_show_register_group)
450         (tui_display_reg_element_at_line): Update.
451         * tui/tui-hooks.c (tui_register_changed)
452         (tui_refresh_frame_and_register_information): Call
453         tui_check_register_values.
454         * tui/tui-data.h (struct tui_data_window) <data_content,
455         data_content_count, data_type>: Remove.
456         (enum tui_data_type): Remove.
457
458         * tui/tui-data.c (tui_data_window::clear_detail)
459         (~tui_data_window): Update.
460
461 2019-06-25  Tom Tromey  <tom@tromey.com>
462
463         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
464         declare.
465         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
466         Rename from tui_first_data_item_displayed.  Update.
467         (tui_data_window::refresh_all)
468         (tui_data_window::do_scroll_vertical): Update.
469         * tui/tui-data.h (struct tui_data_window)
470         <first_data_item_displayed>: Declare new method.
471
472 2019-06-25  Tom Tromey  <tom@tromey.com>
473
474         * tui/tui-data.h (tui_init_generic_part): Don't declare.
475         * tui/tui-data.c (tui_init_generic_part): Remove, moving
476         contents...
477         (tui_initialize_static_data): ...here.
478
479 2019-06-25  Tom Tromey  <tom@tromey.com>
480
481         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
482         (tui_display_registers_from, tui_check_register_values): Update.
483         (tui_display_register): Remove win_info parameter; update.
484         (tui_get_register): Change type of parameters.
485         * tui/tui-data.h (struct tui_data_element): Remove.
486         (union tui_which_element) <data>: Remove.
487         <data_window>: Change type.
488         (struct tui_data_item_window): New.
489         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
490         case.  Add assert.
491         (~tui_data_item_window): New destructor.
492         (free_content_elements): Remove DATA_ITEM_WIN case.
493
494 2019-06-25  Tom Tromey  <tom@tromey.com>
495
496         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
497         Remove.
498
499 2019-06-25  Tom Tromey  <tom@tromey.com>
500
501         * tui/tui-data.h (struct tui_command_element): Remove.
502         (union tui_which_element) <command>: Remove.
503         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
504         assert.
505         (free_content_elements): Remove CMD_WIN case.
506
507 2019-06-25  Tom Tromey  <tom@tromey.com>
508
509         * tui/tui-layout.c (tui_set_layout): Update.
510         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
511         * tui/tui-data.c (layout_def): Update.
512
513 2019-06-25  Tom Tromey  <tom@tromey.com>
514
515         * tui/tui-wingeneral.c (tui_refresh_all): Update.
516         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
517         (tui_source_window_base::set_new_height): Update.
518         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
519         Update.
520         (tui_set_locator_fullname, tui_set_locator_info)
521         (tui_show_frame_info): Update.
522         * tui/tui-source.c (tui_set_source_content)
523         (tui_source_is_displayed): Update.
524         * tui/tui-layout.c (show_source_disasm_command, show_data)
525         (show_source_or_disasm_and_command): Update.
526         * tui/tui-disasm.c (tui_set_disassem_content)
527         (tui_get_begin_asm_address): Update.
528         * tui/tui-data.h (struct tui_locator_element): Remove.
529         (union tui_which_element) <locator>: Remove.
530         (struct tui_locator_window): New.
531         (tui_locator_win_info_ptr): Change return type.
532         * tui/tui-data.c (_locator): Change type.
533         (tui_locator_win_info_ptr): Change return type.
534         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
535         (tui_alloc_content): Add assert.
536
537 2019-06-25  Tom Tromey  <tom@tromey.com>
538
539         * tui/tui-winsource.c
540         (tui_exec_info_window::maybe_allocate_content): New method.
541         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
542         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
543         (make_source_or_disasm_window): Add cast.
544         * tui/tui-data.h (union tui_which_element) <simple_string>:
545         Remove.
546         (struct tui_source_info): New.
547         (struct tui_source_window_base) <execution_info>: Change type.
548         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
549         case, and add assert.
550         (tui_alloc_content): Add assert.
551
552 2019-06-25  Tom Tromey  <tom@tromey.com>
553
554         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
555         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
556         * tui/tui-data.c (tui_alloc_win_info): Remove.
557
558 2019-06-25  Tom Tromey  <tom@tromey.com>
559
560         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
561         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
562         can_highlight.
563
564 2019-06-25  Tom Tromey  <tom@tromey.com>
565
566         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
567         make_visible_with_new_height method.
568         (tui_win_info::make_visible_with_new_height): New method.
569         (tui_source_window_base::do_make_visible_with_new_height)
570         (tui_data_window::do_make_visible_with_new_height)
571         (tui_cmd_window::do_make_visible_with_new_height): New methods.
572         (make_visible_with_new_height): Remove.
573         (tui_resize_all, tui_adjust_win_heights): Use
574         make_visible_with_new_height method.
575         * tui/tui-data.h (struct tui_win_info)
576         <do_make_visible_with_new_height, make_visible_with_new_height>:
577         New methods.
578         (struct tui_source_window_base, struct tui_data_window)
579         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
580         methods.
581
582 2019-06-25  Tom Tromey  <tom@tromey.com>
583
584         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
585         method.
586         (update_tab_width): Call update_tab_width method.
587         * tui/tui-data.h (struct tui_win_info)
588         (struct tui_source_window_base) <update_tab_width>: New methods.
589
590 2019-06-25  Tom Tromey  <tom@tromey.com>
591
592         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
593         parameter.
594         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
595         parameter.
596         (tui_gen_win_info::make_visible): Update.
597         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
598         parameter.
599         * tui/tui-data.h (enum tui_box): New enum.
600         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
601
602 2019-06-25  Tom Tromey  <tom@tromey.com>
603
604         * tui/tui-layout.c (make_source_or_disasm_window): Always use
605         init_and_make_win for EXEC_INFO_WIN.
606         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
607         longer inline.
608         (struct tui_win_info) <~tui_win_info>: Inline.
609         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
610         Don't declare.
611         * tui/tui-data.c (source_win, disasm_win): Remove globals.
612         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
613         Remove.
614         (tui_initialize_static_data): Update.
615         (~tui_gen_win_info): Handle more cleanup here.
616         (~tui_source_window_base): Delete "execution_info".
617         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
618
619 2019-06-25  Tom Tromey  <tom@tromey.com>
620
621         * tui/tui-layout.c (make_command_window): Don't set
622         can_highlight.
623         (show_source_disasm_command): Call the reset method.
624         (show_data): Don't set can_highlight.  Call the reset method.
625         (tui_gen_win_info::reset): Rename from init_gen_win_info
626         (init_and_make_win): Simplify.  Return tui_gen_win_info.
627         (show_source_or_disasm_and_command): Call the reset method.
628         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
629         (struct tui_cmd_window): Set can_highlight.
630
631 2019-06-25  Tom Tromey  <tom@tromey.com>
632
633         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
634         from make_visible.
635         (tui_make_visible, tui_make_invisible): Rewrite.
636         (tui_win_info::make_visible): Remove.
637         (tui_source_window_base::make_visible): Update.
638         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
639         method.  Moved from...
640         (struct tui_win_info) <make_visible>: ...here.
641
642 2019-06-25  Tom Tromey  <tom@tromey.com>
643
644         * tui/tui-winsource.c
645         (tui_source_window_base::do_scroll_horizontal): Remove direction
646         parameter.
647         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
648         direction parameter.
649         * tui/tui-win.c (tui_win_info::forward_scroll)
650         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
651         (tui_win_info::right_scroll): Update.
652         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
653         direction parameter.
654         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
655         direction parameter.
656         * tui/tui-data.h (enum tui_scroll_direction): Remove.
657         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
658         Remove direction parameter.
659         (struct tui_source_window_base, struct tui_source_window)
660         (struct tui_disasm_window, struct tui_data_window)
661         (struct tui_cmd_window): Update.
662
663 2019-06-25  Tom Tromey  <tom@tromey.com>
664
665         * tui/tui-winsource.h (tui_set_exec_info_content)
666         (tui_show_exec_info_content, tui_erase_exec_info_content)
667         (tui_clear_exec_info_content, tui_update_exec_info): Change
668         argument to tui_source_window_base.
669         * tui/tui-winsource.c (tui_set_exec_info_content)
670         (tui_show_exec_info_content, tui_erase_exec_info_content)
671         (tui_clear_exec_info_content, tui_update_exec_info): Change
672         argument to tui_source_window_base.
673
674 2019-06-25  Tom Tromey  <tom@tromey.com>
675
676         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
677         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
678
679 2019-06-25  Tom Tromey  <tom@tromey.com>
680
681         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
682         check.
683
684 2019-06-25  Tom Tromey  <tom@tromey.com>
685
686         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
687         type to void.
688         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
689         type to void.
690         * tui/tui-source.c (tui_set_source_content): Update.
691         * tui/tui-disasm.c (tui_set_disassem_content): Update.
692
693 2019-06-25  Tom Tromey  <tom@tromey.com>
694
695         * tui/tui-win.c (window_name_completer, tui_set_focus)
696         (tui_all_windows_info): Use name method.
697         * tui/tui-data.h (struct tui_gen_win_info)
698         (struct tui_source_window, struct tui_disasm_window)
699         (struct tui_data_window, struct tui_cmd_window) <name>: New
700         method.
701         (tui_win_name): Don't declare.
702         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
703         (tui_win_name): Remove.
704
705 2019-06-25  Tom Tromey  <tom@tromey.com>
706
707         * tui/tui-winsource.h (tui_update_source_window)
708         (tui_update_source_window_as_is): Change parameter type.
709         * tui/tui-winsource.c (tui_update_source_window): Change win_info
710         to be a tui_source_window_base.
711         (tui_update_source_window_as_is): Likewise.
712         * tui/tui-win.c (make_visible_with_new_height): Update.
713
714 2019-06-25  Tom Tromey  <tom@tromey.com>
715
716         * tui/tui-winsource.c (tui_erase_source_content)
717         (tui_show_source_content, tui_show_exec_info_content)
718         (tui_erase_exec_info_content): Use refresh_window method.
719         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
720         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
721         from tui_refresh_win.
722         (tui_data_window::refresh_window): New method.
723         (tui_win_info::refresh, tui_source_window_base::refresh)
724         (tui_refresh_all): Use refresh_window method.
725         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
726         method.
727         * tui/tui-regs.c (tui_display_register): Call refresh_window
728         method.
729         * tui/tui-layout.c (show_source_disasm_command)
730         (show_source_or_disasm_and_command): Call refresh_window method.
731         * tui/tui-data.h (struct tui_gen_win_info)
732         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
733         New method.
734
735 2019-06-25  Tom Tromey  <tom@tromey.com>
736
737         * tui/tui.c (tui_rl_other_window, tui_enable)
738         (tui_is_window_visible, tui_get_command_dimension): Update.
739         * tui/tui-winsource.c (tui_update_source_window_as_is)
740         (tui_clear_source_content, tui_erase_source_content)
741         (tui_show_source_line, tui_source_window_base::refill)
742         (tui_source_window_base::do_scroll_horizontal)
743         (tui_source_window_base::set_is_exec_point_at)
744         (tui_update_breakpoint_info, tui_set_exec_info_content)
745         (tui_alloc_source_buffer, tui_line_is_displayed)
746         (tui_addr_is_displayed): Update.
747         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
748         (tui_check_and_display_highlight_if_needed)
749         (tui_win_info::make_visible, tui_win_info::refresh)
750         (tui_refresh_all): Update.
751         * tui/tui-windata.c (tui_first_data_item_displayed)
752         (tui_delete_data_content_windows, tui_erase_data_content)
753         (tui_display_all_data, tui_data_window::refresh_all)
754         (tui_check_data_values): Update.
755         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
756         (tui_set_win_focus_to, tui_win_info::forward_scroll)
757         (tui_win_info::backward_scroll, tui_refresh_all_win)
758         (tui_resize_all, tui_set_focus, tui_all_windows_info)
759         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
760         (tui_source_window_base::set_new_height)
761         (tui_data_window::set_new_height)
762         (make_invisible_and_set_new_height)
763         (make_visible_with_new_height, new_height_ok)
764         (parse_scrolling_args): Update.
765         * tui/tui-stack.c (tui_show_frame_info): Update.
766         * tui/tui-source.c (tui_set_source_content)
767         (tui_set_source_content_nil, tui_source_is_displayed)
768         (tui_source_window::do_scroll_vertical): Update.
769         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
770         (tui_display_registers_from, tui_display_reg_element_at_line)
771         (tui_check_register_values, tui_reg_command): Update.
772         * tui/tui-layout.c (tui_default_win_height)
773         (show_source_disasm_command, show_data, init_and_make_win)
774         (show_source_or_disasm_and_command): Update.
775         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
776         (tui_redisplay_readline, tui_mld_flush)
777         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
778         (tui_getc): Update.
779         * tui/tui-disasm.c (tui_set_disassem_content)
780         (tui_disasm_window::do_scroll_vertical): Update.
781         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
782         Now virtual.
783         (struct tui_win_info): Derive from tui_gen_win_info.
784         <~tui_win_info>: Mark as override.
785         <generic>: Remove member.
786         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
787         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
788         (~tui_data_window, ~tui_win_info)
789         (tui_free_all_source_wins_content): Update.
790         * tui/tui-command.c (tui_refresh_cmd_win): Update.
791
792 2019-06-25  Tom Tromey  <tom@tromey.com>
793
794         * tui/tui-layout.c (init_and_make_win): Use new.
795         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
796         destructor, initializers.
797         (tui_alloc_generic_win_info): Don't declare.
798         * tui/tui-data.c (_locator): Add argument to constructor.
799         (source_win, disasm_win): New globals.
800         (exec_info): Remove.
801         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
802         Update.
803         (tui_alloc_generic_win_info): Remove.
804         (init_content_element): Use new.
805         (tui_win_info::tui_win_info): Update.
806         (free_content_elements) <case DATA_WIN>: Use delete.
807
808 2019-06-25  Tom Tromey  <tom@tromey.com>
809
810         * tui/tui-wingeneral.c (tui_refresh_win): Update.
811         * tui/tui-windata.c (tui_first_data_item_displayed)
812         (tui_delete_data_content_windows): Update.
813         * tui/tui-win.c (tui_data_window::set_new_height): Update.
814         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
815         (tui_display_registers_from, tui_check_register_values): Update.
816         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
817         pointer.
818         * tui/tui-data.c (init_content_element): Update.  Allocate the new
819         window.
820         (tui_free_data_content): Update.
821         (free_content_elements) <case DATA_WIN>: Free the window.
822
823 2019-06-25  Tom Tromey  <tom@tromey.com>
824
825         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
826         Update.
827         * tui/tui-layout.c (make_command_window)
828         (show_source_disasm_command, show_data, init_and_make_win)
829         (show_source_or_disasm_and_command): Update.
830         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
831         method.
832         <can_highight, is_highlighted>: Now bool.
833         (tui_set_win_highlight): Don't declare.
834         * tui/tui-data.c (tui_set_win_highlight): Remove.
835
836 2019-06-25  Tom Tromey  <tom@tromey.com>
837
838         * tui/tui-wingeneral.c (make_visible): Remove check of window
839         type.
840
841 2019-06-25  Tom Tromey  <tom@tromey.com>
842
843         * tui/tui-win.c (tui_win_info::max_height)
844         (tui_cmd_window::max_height): New methods.
845         (new_height_ok): Call max_height.
846         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
847         <max_height>: New method.
848
849 2019-06-25  Tom Tromey  <tom@tromey.com>
850
851         * tui/tui-win.c (tui_source_window_base::set_new_height)
852         (tui_data_window::set_new_height): New methods.
853         (make_invisible_and_set_new_height): Call set_new_height method.
854         * tui/tui-data.h (struct tui_win_info)
855         (struct tui_source_window_base, struct tui_data_window)
856         <set_new_height>: New method.
857
858 2019-06-25  Tom Tromey  <tom@tromey.com>
859
860         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
861         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
862         tui_refresh_data_win.
863         * tui/tui-win.c (tui_source_window_base::refresh_all): New
864         method.
865         (tui_refresh_all_win): Call the refresh_all method.
866         (tui_set_focus): Likewise.
867         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
868         (struct tui_source_window_base, struct tui_data_window) <refresh>:
869         Likewise.
870
871 2019-06-25  Tom Tromey  <tom@tromey.com>
872
873         * tui/tui-winsource.h (tui_refill_source_window)
874         (tui_set_is_exec_point_at): Don't declare.
875         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
876         (tui_source_window_base::refill): Rename from
877         tui_refill_source_window.
878         (tui_source_window_base::do_scroll_horizontal): Update.
879         (tui_source_window_base::set_is_exec_point_at): Rename from
880         tui_set_is_exec_point_at.
881         (tui_update_all_breakpoint_info): Update.
882         * tui/tui-stack.c (tui_show_frame_info): Update.
883         * tui/tui-layout.c (show_data): Add cast.
884         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
885         * tui/tui-data.h (struct tui_source_window_base) <refill,
886         set_is_exec_point_at>: New methods.
887         (tui_source_windows, tui_add_to_source_windows): Update types.
888         (tui_add_to_source_windows): Remove redundant declaration.
889         * tui/tui-data.c (source_windows): Store tui_source_window_base.
890         (tui_source_windows): Change return type.
891         (tui_clear_source_windows_detail): Update.
892         (tui_add_to_source_windows): Change type of parameter.
893         (tui_free_all_source_wins_content): Update.
894
895 2019-06-25  Tom Tromey  <tom@tromey.com>
896
897         * tui/tui-wingeneral.c (tui_win_info::refresh)
898         (tui_source_window_base::refresh): New methods.
899         (tui_refresh_all): Call the refresh method.
900         * tui/tui-data.h (struct tui_win_info)
901         (struct tui_source_window_base) <refresh>: New method.
902
903 2019-06-25  Tom Tromey  <tom@tromey.com>
904
905         * tui/tui.h (tui_is_window_visible): Return bool.
906         * tui/tui.c (tui_is_window_visible): Return bool.
907         * tui/tui-wingeneral.c (tui_make_window, make_visible)
908         (tui_make_visible, tui_make_invisible)
909         (tui_win_info::make_visible)
910         (tui_source_window_base::make_visible, make_all_visible)
911         (tui_make_all_visible, tui_make_all_invisible): Update.
912         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
913         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
914         bool.
915         (struct tui_win_info, struct tui_source_window_base)
916         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
917         * tui/tui-data.c (tui_init_generic_part): Update.
918
919 2019-06-25  Tom Tromey  <tom@tromey.com>
920
921         * tui/tui-wingeneral.c (tui_win_info::make_visible)
922         (tui_source_window_base::make_visible): New methods.
923         (make_all_visible): Make method call.
924         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
925         (struct tui_source_window_base, struct tui_cmd_window): Override
926         make_visible.
927         (tui_win_is_source_type): Don't declare.
928         * tui/tui-data.c (tui_win_is_source_type): Remove.
929
930 2019-06-25  Tom Tromey  <tom@tromey.com>
931
932         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
933         NULL check.
934
935 2019-06-25  Tom Tromey  <tom@tromey.com>
936
937         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
938         Inline constructor.  Add initializers for members.
939         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
940         constructors; now inline in class.
941
942 2019-06-25  Tom Tromey  <tom@tromey.com>
943
944         * tui/tui-regs.c (tui_show_registers): Update.
945         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
946         bool.
947         * tui/tui-data.c (tui_data_window::clear_detail)
948         (tui_data_window): Update.
949
950 2019-06-25  Tom Tromey  <tom@tromey.com>
951
952         * tui/tui-windata.c (tui_display_all_data)
953         (tui_display_data_from_line, tui_display_data_from)
954         (tui_check_data_values, tui_data_window::do_scroll_vertical):
955         Update.
956         * tui/tui-regs.c (tui_last_regs_line_no)
957         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
958         (tui_show_registers, tui_show_register_group)
959         (tui_display_registers_from, tui_display_reg_element_at_line)
960         (tui_display_registers_from_line, tui_check_register_values)
961         (tui_reg_next, tui_reg_prev): Update.
962         * tui/tui-layout.c (tui_set_layout, show_data): Update.
963         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
964         tui_data_window.
965         (struct tui_win_info) <detail>: Remove.  Add new fields from
966         tui_data_info.
967         (TUI_DATA_WIN): Add cast.
968         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
969         (~tui_data_window): Simplify.
970
971 2019-06-25  Tom Tromey  <tom@tromey.com>
972
973         * tui/tui-layout.c (show_source_disasm_command)
974         (show_source_or_disasm_and_command): Update.
975         * tui/tui-io.c (update_cmdwin_start_line)
976         (tui_redisplay_readline): Update.
977         * tui/tui-data.h (struct tui_command_info): Remove.
978         (struct tui_win_info) <detail>: Remove command_info member.
979         (struct tui_data_window) <start_line>: New member, from
980         tui_command_info.
981         (TUI_CMD_WIN): Add casts.
982
983 2019-06-25  Tom Tromey  <tom@tromey.com>
984
985         * tui/tui-winsource.c (tui_update_source_window)
986         (tui_refill_source_window)
987         (tui_source_window_base::do_scroll_horizontal)
988         (tui_update_breakpoint_info, tui_set_exec_info_content)
989         (tui_show_exec_info_content, tui_erase_exec_info_content)
990         (tui_clear_exec_info_content): Update.
991         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
992         Update.
993         * tui/tui-win.c (make_invisible_and_set_new_height)
994         (make_visible_with_new_height): Update.
995         * tui/tui-source.c (tui_set_source_content)
996         (tui_show_symtab_source): Update.
997         * tui/tui-layout.c (extract_display_start_addr)
998         (show_source_disasm_command, show_data)
999         (make_source_or_disasm_window)
1000         (show_source_or_disasm_and_command): Update.
1001         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1002         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1003         "gdbarch".
1004         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1005         to tui_source_window_base.
1006         (struct tui_win_info) <detail>: Remove source_info member.
1007         (struct tui_source_window_base) <has_locator>: Inline.
1008         Move contents from tui_source_info; rename has_locator member to
1009         m_has_locator.
1010         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1011         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1012         header file.
1013         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1014         Simplify.
1015         (tui_free_all_source_wins_content): Cast to
1016         tui_source_window_base.
1017
1018 2019-06-25  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-win.c (make_invisible_and_set_new_height)
1021         (make_visible_with_new_height): Call has_locator method.
1022         * tui/tui-layout.c (show_source_disasm_command, show_data)
1023         (show_source_or_disasm_and_command): Update for bool change.
1024         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1025         (tui_win_info) <has_locator>: New method.
1026         (struct tui_source_window_base) <has_locator>: New method.
1027         (tui_win_has_locator): Don't declare.
1028         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1029         from tui_win_has_locator.
1030         (tui_source_window_base): Use false, not FALSE.
1031
1032 2019-06-25  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1035         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1036         clear_detail method directly.
1037         (tui_clear_win_detail): Remove.
1038
1039 2019-06-25  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1042         "this", not TUI_DISASM_WIN.
1043
1044 2019-06-25  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1047         declare.
1048         * tui/tui-winsource.c
1049         (tui_source_window_base::do_scroll_horizontal): Rename from
1050         tui_horizontal_source_scroll.
1051         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1052         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1053         from tui_vertical_data_scroll.
1054         * tui/tui-win.h (tui_scroll): Don't declare.
1055         * tui/tui-win.c (tui_win_info::forward_scroll)
1056         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1057         (tui_win_info::right_scroll): Rename and update.
1058         (tui_scroll_forward_command, tui_scroll_backward_command)
1059         (tui_scroll_left_command, tui_scroll_right_command): Update.
1060         (tui_scroll): Remove.
1061         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1062         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1063         from tui_vertical_source_scroll.
1064         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1065         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1066         from tui_vertical_disassem_scroll.
1067         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1068         do_scroll_horizontal>: New methods.
1069         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1070         Likewise.
1071         (struct tui_source_window_base): Add do_scroll_horizontal.
1072         (struct tui_source_window, struct tui_disasm_window): Add
1073         do_scroll_vertical.
1074         (struct tui_data_window, struct tui_cmd_window): Add
1075         do_scroll_horizontal and do_scroll_vertical.
1076         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1077
1078 2019-06-25  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-data.h (struct tui_source_window_base): New struct.
1081         (struct tui_source_window): Derive from tui_source_window_base.
1082         (struct tui_disasm_window): New struct.
1083         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1084         from tui_source_window::clear_detail.
1085         (tui_source_window_base): Rename from tui_source_window.
1086         (~tui_source_window_base): Rename from ~tui_source_window.
1087         (tui_alloc_win_info): Create a tui_disasm_window.
1088
1089 2019-06-25  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-data.h (struct tui_source_window)
1092         (struct tui_data_window): Declare destructors.
1093         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1094         destructors.
1095         (tui_win_info): Simplify.
1096
1097 2019-06-25  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-winsource.c (tui_display_main)
1100         (tui_update_source_windows_with_addr)
1101         (tui_update_all_breakpoint_info): Update.
1102         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1103         (new_height_ok, parse_scrolling_args): Update.
1104         * tui/tui-stack.c (tui_show_frame_info): Update.
1105         * tui/tui-data.h (struct tui_list): Remove.
1106         (tui_source_windows): Return a reference to a std::vector.
1107         * tui/tui-data.c (source_windows): Now a std::vector.
1108         (tui_source_windows): Change return type.
1109         (tui_clear_source_windows): Rewrite.
1110         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1111         (tui_free_all_source_wins_content): Rewrite.
1112
1113 2019-06-25  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1116         (struct tui_data_window, struct tui_cmd_window): Declare
1117         clear_detail method.
1118         * tui/tui-data.c (tui_source_window::clear_detail)
1119         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1120         methods.
1121         (tui_clear_win_detail): Simplify.
1122
1123 2019-06-25  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-layout.c (make_source_window, make_disasm_window)
1126         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1127         Return the new window.
1128         (show_source_disasm_command, show_data)
1129         (show_source_or_disasm_and_command): Update.
1130
1131 2019-06-25  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1134         parameter.  Return the new window.
1135         (show_source_disasm_command): Update and remove NULL check.
1136         (show_source_or_disasm_and_command): Update.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1141
1142 2019-06-25  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-data.h (struct tui_win_info): Make constructor
1145         protected.  Make destructor virtual.  Add initializers.
1146         (tui_source_window, tui_data_window, tui_cmd_window): New
1147         classes.
1148         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1149         constructor.  Add "type" parameter.
1150         (tui_source_window, tui_data_window, tui_cmd_window): New
1151         constructors.
1152         (tui_alloc_win_info): Instantiate the appropriate subclass.
1153
1154 2019-06-25  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-win.c (tui_resize_all): Use delete.
1157         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1158         destructor.
1159         (tui_free_window): Don't declare.
1160         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1161         Update.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-data.h (struct tui_win_info): Add constructor.
1166         * tui/tui-data.c (tui_alloc_win_info): Use new.
1167         (tui_free_window): Use delete.
1168
1169 2019-06-22  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1172         declare.
1173         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1174
1175 2019-06-22  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1178         declare.
1179         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1180
1181 2019-06-22  Tom de Vries  <tdevries@suse.de>
1182
1183         * dwarf2read.c (create_addrmap_from_aranges)
1184         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1185         instead of '%zu'.
1186
1187 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1188
1189         * dwarf2read.h (dwarf2_section_info_def): Remove.
1190         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1191         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1192         std::vector<dwarf2_section_info>.
1193         (struct dwo_file) <~dwo_file>: Remove.
1194         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1195         types field.
1196         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1197         (dwarf2_read_debug_names): Likewise.
1198         (create_debug_types_hash_table): Change parameter type to
1199         array_view, adjust code accordingly.
1200         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1201         (partial_die_info::fixup): Likewise.
1202         (determine_prefix): Likewise.
1203         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1204
1205 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1206
1207         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1208         gdb_bfd_ref_ptr.
1209         <~dwo_file>: Remove call to gdb_bfd_unref.
1210         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1211         gdb_bfd_ref_ptr::get.
1212
1213 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1214
1215         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1216         type to htab_up.
1217         * dwarf2read.c (struct dwo_file): Initialize fields.
1218         <~dwo_file>: New.
1219         (free_dwo_file): Remove, move content to ~dwo_file.
1220         (struct dwo_file_deleter): Remove.
1221         (dwo_file_up>: Remove custom deleter.
1222         (free_dwo_files): Remove.
1223         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1224         dwo_files.
1225         (process_skeletonless_type_units): Call unique_ptr::get.
1226         (allocate_dwo_file_hash_table): Add deleter to created hash
1227         table.  Change return type to htab_up.
1228         (lookup_dwo_file_slot): Don't memset dwo_file, call
1229         unique_ptr::get.
1230         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1231         (create_dwo_unit_in_dwp_v2): Likewise.
1232         (open_and_init_dwo_file): Likewise.
1233         (free_dwo_file_from_slot): Remove.
1234
1235 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1236
1237         * dwarf2read.h (struct dwarf2_section_info) <readin,
1238         is_virtual>: Change type to bool.
1239         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1240         true instead of 1.
1241
1242 2019-06-19  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-data.h (tui_init_content_element): Don't declare.
1245
1246 2019-06-19  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-data.h (tui_init_win_info): Don't declare.
1249
1250 2019-06-19  Tom de Vries  <tdevries@suse.de>
1251
1252         * dwarf2read.h (abstract_to_concrete): Change type to
1253         std::unordered_map<sect_offset, std::vector<sect_offset>,
1254         gdb::hash_enum<sect_offset>>.
1255
1256 2019-06-19  Tom Tromey  <tromey@adacore.com>
1257
1258         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1259         EVAL_AVOID_SIDE_EFFECTS specially.
1260
1261 2019-06-19  Tom Tromey  <tromey@adacore.com>
1262
1263         * source-cache.c (highlighter): New global.
1264         (source_cache::get_source_lines): Create a highlighter on demand.
1265
1266 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * defs.h (deprecated_interactive_hook): Delete declaration.
1269         * interps.c (clear_interpreter_hooks): Remove use of
1270         deprecated_interactive_hook.
1271         * top.c (deprecated_interactive_hook): Delete definition.
1272         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1273
1274 2019-06-18  Tom de Vries  <tdevries@suse.de>
1275
1276         PR gdb/24515
1277         * dwarf2read.h (abstract_to_concrete): Change type from
1278         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1279         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1280         * dwarf2read.c (read_variable): Update.
1281         (dwarf2_fetch_die_loc_sect_off): Update.
1282
1283 2019-06-17  Tom de Vries  <tdevries@suse.de>
1284
1285         PR gdb/24617
1286         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1287         accessing parent[parent_len - 1].
1288
1289 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1290
1291         PR gdb/24364
1292         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1293         call dtrace_process_dof with NULL dof.
1294
1295 2019-06-16  Tom de Vries  <tdevries@suse.de>
1296
1297         PR gdb/24445
1298         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1299
1300 2019-06-16  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1303         (make_all_visible): Use address of member.
1304
1305 2019-06-16  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1308         (tui_free_window, free_content, free_content_elements): Remove
1309         unnecessary cast.
1310         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1311         cast.
1312         * tui/tui-regs.c (tui_show_register_group)
1313         (tui_display_registers_from, tui_display_reg_element_at_line):
1314         Remove unnecessary cast.
1315
1316 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * linux-nat.c (normal_mask): Delete.
1319         (_initialize_linux_nat): Don't initialise normal_mask.
1320
1321 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1322
1323         PR gdb/24445
1324         * dwarf-index-write.h (write_psymtabs_to_index): Add
1325         dwz_basename parameter.
1326         * dwarf-index-write.c (write_gdbindex): Move file writing to
1327         write_gdbindex_1.  Change return type void.
1328         (assert_file_size): Move up, remove filename parameter.
1329         (write_gdbindex_1): New function.
1330         (write_debug_names): Change return type to void, call
1331         assert_file_size.
1332         (struct index_wip_file): New struct.
1333         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1334         file logic to index_wip_file.  Write index for dwz file if
1335         needed.
1336         (save_gdb_index_command): Pass basename of dwz file, if present.
1337         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1338         build-id of dwz file, if present.
1339         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1340         (dwarf2_get_dwz_file): Likewise.
1341         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1342         (dwarf2_get_dwz_file): Likewise.
1343
1344 2019-06-16  Tom Tromey  <tom@tromey.com>
1345
1346         * coffread.c (process_coff_symbol): Use xstrdup.
1347         * value.c (create_internalvar): Use xstrdup.
1348
1349 2019-06-16  Tom Tromey  <tom@tromey.com>
1350
1351         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1352         * breakpoint.c (stopin_command, stopat_command)
1353         (until_break_command, decode_location_default): Remove unnecessary
1354         cast.
1355         * utils.c (subset_compare): Remove unnecessary cast.
1356         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1357         cast.
1358         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1359         cast.
1360         * infcmd.c (path_command): Remove unnecessary cast.
1361         * coffread.c (decode_type): Remove unnecessary cast.
1362         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1363         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1364         * tui/tui-stack.c (tui_show_locator_content)
1365         (tui_show_frame_info): Remove unnecessary cast.
1366         * tui/tui-win.c (tui_scroll_forward_command)
1367         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1368         (parse_scrolling_args): Remove unnecessary cast.
1369         * tui/tui-data.c (init_win_info, tui_del_window)
1370         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1371         (free_content_elements): Remove unnecessary cast.
1372         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1373         unnecessary cast.
1374         * tui/tui-source.c (tui_set_source_content)
1375         (tui_vertical_source_scroll): Remove unnecessary cast.
1376         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1377         cast.
1378         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1379         * tui/tui-regs.c (tui_display_registers_from)
1380         (tui_display_register): Remove unnecessary cast.
1381         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1382         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1383         (make_visible): Remove unnecessary cast.
1384         * tui/tui-winsource.c (tui_erase_source_content)
1385         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1386         unnecessary cast.
1387         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1388         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1389         * stabsread.c (read_type, read_array_type, read_range_type):
1390         Remove unnecessary cast.
1391         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1392         (parse_symbol, parse_type, upgrade_type, parse_external)
1393         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1394         unnecessary cast.
1395         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1396
1397 2019-06-16  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-data.c (tui_alloc_generic_win_info)
1400         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1401         checks.
1402
1403 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1404             Andrew Burgess  <andrew.burgess@embecosm.com>
1405
1406         * f-typeprint.c (f_print_type): Don't return early for not
1407         associated or not allocated types.
1408         (f_type_print_varspec_suffix): Add print_rank parameter and print
1409         ranks of array types in case they dangling.
1410         (f_type_print_base): Add print_rank parameter.
1411
1412 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * NEWS: Mention new MI commands.
1415         * break-catch-throw.c (enum exception_event_kind): Move to
1416         breakpoint.h.
1417         (print_mention_exception_catchpoint): Output text as a single
1418         message.
1419         (catch_exception_command_1): Rename to...
1420         (catch_exception_event): ...this, make non-static, update header
1421         command, and change some parameter types.
1422         (catch_catch_command): Update for changes to
1423         catch_exception_command_1.
1424         (catch_throw_command): Likewise.
1425         (catch_rethrow_command): Likewise.
1426         * breakpoint.c (enum exception_event_kind): Delete.
1427         * breakpoint.h (enum exception_event_kind): Moved here from
1428         break-catch-throw.c.
1429         (catch_exception_event): Declare.
1430         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1431         (mi_cmd_catch_throw): New function.
1432         (mi_cmd_catch_rethrow): New function.
1433         (mi_cmd_catch_catch): New function.
1434         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1435         'catch-catch' entries.
1436         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1437         (mi_cmd_catch_rethrow): Declare.
1438         (mi_cmd_catch_catch): Declare.
1439
1440 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * annotate.c (annotate_source_line): Change return type to void,
1443         update implementation to match.
1444         * annotate.h (annotate_source_line): Change return type to void,
1445         update header comment.
1446         * stack.c (print_frame_info): Don't change what frame information
1447         is printed based on whether annotations are on or not.
1448
1449 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1450
1451         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1452         (annotate_source): Make static.
1453         (annotate_source_line): Moved from source.c and renamed from
1454         identify_source_line.  Update the return type.
1455         * annotate.h (annotate_source): Delete declaration.
1456         (annotate_source_line): Declaration moved from source.h, and
1457         renamed from identify_source_line.  Return type updated.
1458         * source.c (identify_source_line): Moved to annotate.c and renamed
1459         to annotate_source_line.
1460         (info_line_command): Remove check of annotation_level.
1461         * source.h (identify_source_line): Move declaration to annotate.h
1462         and rename to annotate_source_line.
1463         * stack.c: Add 'annotate.h' include.
1464         (print_frame_info): Remove check of annotation_level before
1465         calling annotate_source_line.
1466
1467 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * source-cache.c (source_cache::get_plain_source_lines): Use
1470         open_source_file_with_line_charpos instead of just
1471         open_source_file, remove call to find_source_lines.
1472         (source_cache::get_source_lines): Likewise.
1473         * source.c (find_source_lines): Make static.
1474         (get_filename_and_charpos): Renamed into...
1475         (open_source_file_with_line_charpos): ..this along with changes to
1476         return a scoped_fd, and some other minor clean ups.
1477         (identify_source_line): Use open_source_file_with_line_charpos.
1478         (search_command_helper): Use open_source_file_with_line_charpos
1479         instead of just open_source_file, remove call to
1480         find_source_lines.
1481         * source.h (open_source_file_with_line_charpos): Declare new
1482         function.
1483         (find_source_lines): Delete declaration.
1484
1485 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1486
1487         * source.c (get_filename_and_charpos): Remove fullname
1488         parameter.
1489         (identify_source_line): Update call to get_filename_and_charpos.
1490
1491 2019-06-14  Tom Tromey  <tromey@adacore.com>
1492
1493         PR gdb/24502:
1494         * ui-style.h (skip_ansi_escape): Update comment.
1495         * ui-file.h (class no_terminal_escape_file): New class.
1496         * ui-file.c (no_terminal_escape_file::write)
1497         (no_terminal_escape_file::puts): New methods.
1498         * cli/cli-logging.c (handle_redirections): Use
1499         no_terminal_escape_file.
1500
1501 2019-06-14  Tom Tromey  <tromey@adacore.com>
1502
1503         * NEWS: Move convenience variable news above Python news.
1504
1505 2019-06-14  Tom Tromey  <tom@tromey.com>
1506
1507         * gnulib: Move directory to top-level.
1508         * configure.ac: Don't configure gnulib.
1509         * configure: Rebuild.
1510         * common/common-defs.h: Use new path to gnulib.
1511         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1512         (GNULIB_H): Remove.
1513         (INCGNU): Look in new gnulib location.
1514         (HFILES_NO_SRCDIR): Remove gnulib files.
1515         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1516         (generated_files): Remove GNULIB_H.
1517         ($(LIBGNU), all-lib): Remove targets.
1518         (distclean): Don't mention GNULIB_BUILDDIR.
1519         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1520
1521 2019-06-14  Tom Tromey  <tromey@adacore.com>
1522
1523         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1524         Warn if symbol file does not provide any symbols.
1525
1526 2019-06-14  Tom Tromey  <tromey@adacore.com>
1527
1528         * source.c (find_and_open_source): Respect basenames_may_differ.
1529
1530 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * annotate.c (annotate_breakpoints_invalid): Make use of
1533         scoped_restore_terminal_state.
1534         (annotate_frames_invalid): Likewise.
1535
1536 2019-06-14  Tom Tromey  <tromey@adacore.com>
1537
1538         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1539         allow assignment to an internalvar.
1540
1541 2019-06-14  Tom Tromey  <tromey@adacore.com>
1542
1543         * ada-lex.l: Allow "_" in attribute names.
1544
1545 2019-06-14  Tom Tromey  <tromey@adacore.com>
1546
1547         PR gdb/24653:
1548         * regcache.c (registers_changed): Don't call alloca.
1549         * top.c (execute_command): Don't call alloca.
1550
1551 2019-06-13  Pedro Alves  <palves@redhat.com>
1552
1553         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1554         'expression'.  When parsing an expression, error out if there's
1555         junk after "unlimited".
1556         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1557         (do_set_command): Adjust calls to is_unlimited_literal.
1558
1559 2019-06-13  Pedro Alves  <palves@redhat.com>
1560
1561         * compile/compile.c (make_compile_options_def_group): Add braces
1562         around array_view initializer.
1563         * thread.c (make_thread_apply_all_options_def_group)
1564         (make_thread_apply_all_options_def_group): Likewise.
1565
1566 2019-06-13  Pedro Alves  <palves@redhat.com>
1567
1568         * NEWS (New commands): Mention "maint test-options
1569         require-delimiter", "maint test-options unknown-is-error", "maint
1570         test-options unknown-is-operand" and "maint show
1571         test-options-completion-result".
1572         (New command options, command completion): New section.
1573         (Completion improvements): New section.
1574         Mention that you can abbreviate "unlimited".
1575
1576 2019-06-13  Pedro Alves  <palves@redhat.com>
1577
1578         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1579         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1580         * unittests/cli-utils-selftests.c (test_parse_flags)
1581         (test_parse_flags_qcs): Delete.
1582         (test_cli_utils): Don't call deleted functions.
1583
1584 2019-06-13  Pedro Alves  <palves@redhat.com>
1585
1586         * thread.c: Include "cli/cli-option.h".
1587         (tp_array_compar_ascending): Global.
1588         (tp_array_compar): Delete function.
1589         (tp_array_compar_ascending, tp_array_compar_descending): New
1590         functions.
1591         (ascending_option_def, qcs_flag_option_def)
1592         (thr_qcs_flags_option_defs)
1593         (make_thread_apply_all_options_def_group)
1594         (make_thread_apply_options_def_group): New.
1595         (thread_apply_all_command): Use gdb::option::process_options.
1596         (thread_apply_command_completer)
1597         (thread_apply_all_command_completer): New.
1598         (thread_apply_command): Use gdb::option::process_options.
1599         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1600         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1601         to generate help text of "thread apply".  Adjust "taas"'s help.
1602         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1603         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1604
1605 2019-06-13  Pedro Alves  <palves@redhat.com>
1606
1607         * thread.c (thread_apply_command): Check for invalid TID with
1608         isdigit instead of !isalpha.
1609
1610 2019-06-13  Pedro Alves  <palves@redhat.com>
1611
1612         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1613         (validate_flags_qcs): New.
1614         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1615         (validate_flags_qcs): Declare.
1616         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1617         (make_frame_apply_options_def_group): New.
1618         (frame_apply_command_count): Process options with
1619         gdb::option::process_options.
1620         (frame_apply_completer): New.
1621         (frame_apply_level_completer, frame_apply_all_completer)
1622         (frame_apply_completer): New.
1623         (_initialize_stack): Update help of "frame apply", "frame apply
1624         level", "frame apply all" and "faas" to mention supported options
1625         and install command completers.
1626         * stack.h (frame_apply_all_completer): Declare.
1627         * thread.c: Include "stack.h".
1628         (tfaas_command): Add "--".
1629         (_initialize_thread): Update help "tfaas" to mention supported
1630         options and install command completer.
1631
1632 2019-06-13  Pedro Alves  <palves@redhat.com>
1633
1634         * completer.c (complete_nested_command_line): New.
1635         (gdb_completion_word_break_characters_throw): Add assertion.
1636         * completer.h (complete_nested_command_line): Declare.
1637
1638 2019-06-13  Pedro Alves  <palves@redhat.com>
1639
1640         * stack.c (parse_backtrace_qualifiers): New.
1641         (backtrace_command): Use it.
1642         (backtrace_command_completer): Complete on qualifiers.
1643
1644 2019-06-13  Pedro Alves  <palves@redhat.com>
1645
1646         * frame.c: Include "cli/cli-option.h.
1647         (user_set_backtrace_options): New.
1648         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1649         Delete.
1650         (get_prev_frame): Adjust.
1651         (boolean_option_def, uinteger_option_def)
1652         (set_backtrace_option_defs): New.
1653         (_initialize_frame): Adjust and use
1654         gdb::option::add_setshow_cmds_for_options to install "set
1655         backtrace past-main" and "set backtrace past-entry".
1656         * frame.h: Include "cli/cli-option.h".
1657         (struct frame_print_options): Forward declare.
1658         (print_frame_arguments_all, print_frame_arguments_scalars)
1659         (print_frame_arguments_none): Declare.
1660         (print_entry_values): Delete declaration.
1661         (struct frame_print_options, user_frame_print_options): New.
1662         (struct set_backtrace_options): New.
1663         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1664         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1665         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1666         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1667         (list_args_or_locals): Add frame_print_options parameter.
1668         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1669         * python/py-framefilter.c (enumerate_args): Pass down
1670         USER_FRAME_PRINT_OPTIONS.
1671         * stack.c: Include "cli/cli-option.h".
1672         (print_frame_arguments_all, print_frame_arguments_scalars)
1673         (print_frame_arguments_none): Declare.
1674         (print_raw_frame_arguments, print_entry_values): Delete.
1675         (user_frame_print_options): New.
1676         (boolean_option_def, enum_option_def, frame_print_option_defs):
1677         New.
1678         (struct backtrace_cmd_options): New.
1679         (bt_flag_option_def): New.
1680         (backtrace_command_option_defs): New.
1681         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1682         (print_frame_arg, read_frame_arg, print_frame_args)
1683         (print_frame_info, print_frame): Add frame_print_options parameter
1684         and use it.
1685         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1686         (backtrace_command_1): Add frame_print_options and
1687         backtrace_cmd_options parameters and use them.
1688         (make_backtrace_options_def_group): New.
1689         (backtrace_command): Process command options with
1690         gdb::option::process_options.
1691         (backtrace_command_completer): New.
1692         (_initialize_stack): Extend "backtrace"'s help to mention
1693         supported options.  Install completer for "backtrace".
1694         Install some settings commands with add_setshow_cmds_for_options.
1695
1696 2019-06-13  Pedro Alves  <palves@redhat.com>
1697
1698         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1699         and that "set/show print raw frame-arguments" are now deprecated.
1700
1701         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1702         command.
1703         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1704         * stack.c (_initialize_stack): Install "set/show print
1705         raw-frame-arguments", and deprecate "set/show print raw
1706         frame-arguments".
1707         * valprint.c (_initialize_valprint): Deprecate "set/show print
1708         raw".
1709
1710 2019-06-13  Pedro Alves  <palves@redhat.com>
1711
1712         * compile/compile.c (struct compile_options): New.
1713         (compile_flag_option_def, compile_command_option_defs)
1714         (make_compile_options_def_group): New.
1715         (compile_file_command): Handle options with
1716         gdb::option::process_options.
1717         (compile_file_command_completer): New function.
1718         (compile_code_command): Handle options with
1719         gdb::option::process_options.
1720         (compile_code_command_completer): New function.
1721         (_initialize_compiler): Install completers for "compile code" and
1722         "compile file".  Mention available options in "compile code" and
1723         "compile code"'s help.
1724         * completer.c (advance_to_completion_word): New, factored out from
1725         ...
1726         (advance_to_expression_complete_word_point): ... this.
1727         (advance_to_filename_complete_word_point): New.
1728         * completer.h (advance_to_filename_complete_word_point): New
1729         declaration.
1730
1731 2019-06-13  Pedro Alves  <palves@redhat.com>
1732
1733         * compile/compile.c: Include "cli/cli-option.h".
1734         (compile_print_value): Scope data pointer is now a
1735         value_print_options pointer; adjust.
1736         (compile_print_command): Process options.  Scope data pointer is
1737         now a value_print_options pointer; adjust.
1738         (_initialize_compile): Update "compile print"'s help to include
1739         supported options.  Install a completer for "compile print".
1740         * cp-valprint.c (show_vtblprint, show_objectprint)
1741         (show_static_field_print): Delete.
1742         (_initialize_cp_valprint): Don't install "set print
1743         static-members", "set print vtbl", "set print object" here.
1744         * printcmd.c: Include "cli/cli-option.h" and
1745         "common/gdb_optional.h".
1746         (print_command_parse_format): Rework to fill in a
1747         value_print_options instead of a format_data.
1748         (print_value): Change parameter type from format_data pointer to
1749         value_print_options reference.  Adjust.
1750         (print_command_1): Process options.  Adjust to pass down a
1751         value_print_options.
1752         (print_command_completer): New.
1753         (_initialize_printcmd): Install print_command_completer as
1754         handle_brkchars completer for the "print" command.  Update
1755         "print"'s help to include supported options.
1756         * valprint.c: Include "cli/cli-option.h".
1757         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1758         here from cp-valprint.c.
1759         (boolean_option_def, uinteger_option_def)
1760         (value_print_option_defs, make_value_print_options_def_group):
1761         New.  Use gdb::option::add_setshow_cmds_for_options to install
1762         "set print elements", "set print null-stop", "set print repeats",
1763         "set print pretty", "set print union", "set print array", "set
1764         print address", "set print symbol", "set print array-indexes".
1765         * valprint.h: Include <string> and "cli/cli-option.h".
1766         (make_value_print_options_def_group): Declare.
1767         (print_value): Change parameter type from format_data pointer to
1768         value_print_options reference.
1769         (print_command_completer): Declare.
1770
1771 2019-06-13  Pedro Alves  <palves@redhat.com>
1772
1773         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1774         (COMMON_SFILES): Add maint-test-settings.c.
1775         * cli/cli-decode.c (boolean_enums): New global, factored out from
1776         ...
1777         (add_setshow_boolean_cmd): ... here.
1778         * cli/cli-decode.h (boolean_enums): Declare.
1779         * cli/cli-option.c: New file.
1780         * cli/cli-option.h: New file.
1781         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1782         factored out from ...
1783         (parse_cli_boolean_value(const char *)): ... this.
1784         (is_unlimited_literal): Change parameter type to pointer to
1785         pointer.  Adjust and advance ARG pointer.
1786         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1787         (parse_cli_var_enum): New, factored out from ...
1788         (do_set_command): ... this.  Adjust.
1789         * cli/cli-setshow.h (parse_cli_boolean_value)
1790         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1791         (parse_cli_var_enum): Declare.
1792         * cli/cli-utils.c: Include "cli/cli-option.h".
1793         (get_ulongest): New.
1794         * cli/cli-utils.h (get_ulongest): Declare.
1795         (check_for_argument): New overloads.
1796         * maint-test-options.c: New file.
1797
1798 2019-06-13  Pedro Alves  <palves@redhat.com>
1799
1800         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1801         parse a range if "-" is at the end of the string.
1802
1803 2019-06-13  Pedro Alves  <palves@redhat.com>
1804
1805         * cli/cli-setshow.c (parse_auto_binary_operation)
1806         (parse_cli_boolean_value): Don't allow "o".
1807
1808 2019-06-13  Pedro Alves  <palves@redhat.com>
1809
1810         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1811         * NEWS: Mention maint test-settings KIND.
1812         * maint-test-settings.c: New file.
1813
1814 2019-06-13  Pedro Alves  <palves@redhat.com>
1815
1816         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1817         completer.
1818         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1819         "set" completers.
1820
1821 2019-06-13  Pedro Alves  <palves@redhat.com>
1822
1823         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1824         after item.
1825
1826 2019-06-13  Pedro Alves  <palves@redhat.com>
1827
1828         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1829
1830 2019-06-13  Pedro Alves <palves@redhat.com>
1831
1832         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1833         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1834         call.
1835         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1836         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1837         calls.
1838         (check_for_argument): Skip spaces after argument.
1839
1840 2019-06-13  Pedro Alves  <palves@redhat.com>
1841
1842         * thread.c (thread_apply_command): Adjust TID parsing.
1843         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1844         detected before end of string.
1845         (tid_is_in_list): Error out if LIST is invalid.
1846
1847 2019-06-13  Pedro Alves  <palves@redhat.com>
1848
1849         * completer.c (complete_line_internal_1): Rewind completion word
1850         point.
1851         (completion_tracker::advance_custom_word_point_by): Change
1852         parameter type to int.
1853         * completer.h (completion_tracker::advance_custom_word_point_by):
1854         Likewise.
1855
1856 2019-06-13  Pedro Alves  <palves@redhat.com>
1857
1858         * completer.c (advance_to_completion_word): Handle delimiters.
1859
1860 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1861
1862         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1863
1864 2019-06-11  Tom Tromey  <tom@tromey.com>
1865
1866         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1867         (xmalloc_failed): Move to alloc.c.
1868         * alloc.c: New file.
1869         * Makefile.in (COMMON_SFILES): Add alloc.c.
1870
1871 2019-06-11  Tom Tromey  <tom@tromey.com>
1872
1873         * nat/linux-waitpid.c: Don't include server.h.
1874         (linux_debug): Remove.
1875         (my_waitpid): Update.
1876
1877 2019-06-11  Tom Tromey  <tromey@adacore.com>
1878
1879         * infcall.c (_initialize_infcall): Remove trailing newline from
1880         help.
1881         * user-regs.c (_initialize_user_regs): Remove trailing newline
1882         from help.
1883         * typeprint.c (_initialize_typeprint): Remove trailing newline
1884         from help.
1885         * reverse.c (_initialize_reverse): Remove trailing newlines from
1886         help.
1887         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1888         from help.
1889         * language.c (add_set_language_command): Remove trailing newline
1890         from help.
1891         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1892         help.
1893         * disasm.c (_initialize_disasm): Remove trailing newline from
1894         help.
1895         * top.c (init_main): Remove trailing newline from help.
1896         * interps.c (_initialize_interpreter): Remove trailing newline
1897         from help.
1898         * btrace.c (_initialize_btrace): Remove trailing newlines from
1899         help.
1900         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1901         from help.
1902         * python/python.c (_initialize_python): Remove trailing newline
1903         from help.
1904         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1905         help.
1906         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1907         from help.  Reformat some text.
1908         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1909         from help.
1910         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1911         newline from help.
1912
1913 2019-06-11  Tom Tromey  <tromey@adacore.com>
1914
1915         * darwin-nat.c (darwin_decode_exception_message)
1916         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1917
1918 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * valops.c (value_slice): Check for not allocated or not
1921         associated values.
1922
1923 2019-06-10  Tom de Vries  <tdevries@suse.de>
1924
1925         PR gdb/24618
1926         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1927         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1928         invalid.
1929
1930 2019-06-10  Tom de Vries  <tdevries@suse.de>
1931
1932         PR gdb/24611
1933         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1934         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1935
1936 2019-06-10  Tom de Vries  <tdevries@suse.de>
1937
1938         PR symtab/24545
1939         * symtab.c (struct demangled_name_entry): Add language field.
1940         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1941         static minimal symbol".  Set and use language field.
1942
1943 2019-06-10  Tom Tromey  <tromey@adacore.com>
1944
1945         * ada-lang.c (_initialize_ada_language): Update help text.
1946
1947 2019-06-10  Tom Tromey  <tromey@adacore.com>
1948
1949         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1950         with a newline.
1951         * guile/guile.c (handle_boot_error): Don't end warning with a
1952         newline.
1953         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1954         warning with a newline.
1955         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1956         newline.
1957         (s12z_frame_cache): Likewise.
1958         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1959         a newline.
1960         * solib-svr4.c (disable_probes_interface): Don't end warning with
1961         a newline.
1962         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1963         newline.
1964         * python/python.c (do_finish_initialization): Don't end warning
1965         with a newline.
1966
1967 2019-06-10  Tom Tromey  <tom@tromey.com>
1968
1969         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1970         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1971         gdbpy_enter.
1972
1973 2019-06-10  Tom Tromey  <tromey@adacore.com>
1974
1975         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1976         data.
1977         (elf_new_init): Don't call stabsread_new_init.
1978         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1979         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1980         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1981
1982 2019-06-10  Tom de Vries  <tdevries@suse.de>
1983
1984         PR symtab/16264
1985         PR symtab/24517
1986         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1987
1988 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1989
1990         * source.c (find_and_open_source): Also rewrite relative file
1991         names.
1992
1993 2019-04-26  Amos Bird  <amosbird@gmail.com>
1994
1995         * annotate.c (annotate_thread_exited): Add "thread-exited"
1996         annotation.
1997
1998 2019-06-06  Tom Tromey  <tromey@adacore.com>
1999
2000         * maint.h (class scoped_command_stats): Use
2001         DISABLE_COPY_AND_ASSIGN.
2002         <print_time>: New method.
2003         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2004         print_time.
2005         (scoped_command_stats::print_time): New method.
2006
2007 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2008
2009         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2010         instructions of lengths 6 or 8 bytes.
2011
2012 2019-06-04  Pedro Alves  <palves@redhat.com>
2013
2014         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2015
2016         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2017         * breakpoint.c (condition_completer): Likewise.
2018         * cli/cli-dump.c (scan_expression): Likewise.
2019         * common/filestuff.c (mkdir_recursive): Likewise.
2020         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2021         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2022         (gdb_abspath): Likewise.
2023         * compile/compile-cplus-types.c
2024         (compile_cplus_instance::decl_name): Likewise.
2025         * completer.c (complete_explicit_location):
2026         (signal_completer, reg_or_group_completer_1): Likewise.
2027         * cp-support.c (cp_remove_params_if_any): Likewise.
2028         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2029         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2030         * infcmd.c (strip_bg_char): Likewise.
2031         * linespec.c (copy_token_string): Likewise.
2032         * mi/mi-main.c (output_cores): Likewise.
2033         * psymtab.c (psymtab_search_name):
2034         * symfile.c (test_set_ext_lang_command): Likewise.
2035         * target.c (target_fileio_read_stralloc): Likewise.
2036         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2037         * value.c (complete_internalvar): Likewise.
2038
2039 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2040
2041         Add objfile property to gdb.Type.
2042         * NEWS: Mention Python API addition.
2043         * python/py-type.c (typy_get_objfile): New method.
2044
2045 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2046
2047         * NEWS: Mention the new set|show style [title|highlight].
2048         Mention changes to "show style", "help" and "apropos".
2049
2050 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2051
2052         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2053         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2054         instead of print_help_for_command.
2055         (print_doc_of_command): New function.
2056         (help_list): Add 'apropos -v word' suggestion.
2057         (print_help_for_command): Style the command name using title style.
2058         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2059         (_initialize_cli_cmds): Describe -v in apropos_command help.
2060
2061 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2062
2063         * cli/cli-style.h (cli_style_option): Add name in constructor,
2064         add m_name class member, add constructor with intensity,
2065         add name class function.
2066         (cli_style_option::add_setshow_commands): Remove name argument.
2067         (highlight_style, title_style): New styles.
2068         * cli/cli-style.c (do_show): New function that shows a style
2069         characteristic styling the style name with itself.
2070         (set_style_name): New function.
2071         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2072         Update all callers according to the changes in cli/cli-style.h.
2073         * utils.h (fputs_highlighted): New function.
2074         * utils.c (fputs_highlighted): Likewise.
2075
2076 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2077
2078         * NEWS: Mention new pipe command and new convenience variables.
2079
2080 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2081
2082         * cli/cli-cmds.c (pipe_command): New function.
2083         (_initialize_cli_cmds): Call add_com for pipe_command.
2084         Define | as an alias for pipe.
2085         (exit_status_set_internal_vars): New function.
2086         (shell_escape): Call exit_status_set_internal_vars.
2087         cli/cli-decode.c (find_command_name_length): Recognize | as
2088         a single character command.
2089
2090 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2091
2092         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2093         top.c (execute_command_to_ui_file): New function, mostly a copy
2094         of execute_command_to_string.
2095         (execute_command_to_string): Implement by calling
2096         execute_command_to_ui_file.
2097
2098 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2099
2100         * top.h (saved_command_line): Remove declaration.
2101         * top.c (previous_saved_command_line, previous_repeat_arguments):
2102         New variables.
2103         (saved_command_line): Make static, define together with other
2104         'repeat variables'.
2105         (dont_repeat): Clear repeat_arguments.
2106         (repeat_previous, get_saved_command_line, save_command_line):
2107         New functions.
2108         (gdb_init): Initialize saved_command_line
2109         and previous_saved_command_line.
2110         * main.c (captured_main_1): Remove saved_command_line initialization.
2111         * event-top.c (handle_line_of_input): Update to use
2112         the new 'repeat' related functions instead of direct access to
2113         saved_command_line.
2114         * command.h (repeat_previous, get_saved_command_line,
2115         save_command_line): New declarations.
2116         (dont_repeat): Add comment.
2117
2118 2019-05-30  Tom Tromey  <tromey@adacore.com>
2119
2120         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2121         Fix comment.
2122         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2123
2124 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2125
2126         PR cli/24587
2127         * completer.c (complete): Initialize variable word.
2128
2129 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2130
2131         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2132         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2133         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2134         'body' is NULL to the outter 'if', protecting the '!is_define'
2135         situation as well.
2136
2137 2019-05-29  Tom Tromey  <tromey@adacore.com>
2138
2139         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2140         (dwarf_unknown): New function.
2141         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2142         (dwarf_type_encoding_name): Use dwarf_unknown.
2143
2144 2019-05-29  Tom Tromey  <tromey@adacore.com>
2145
2146         PR c++/20020:
2147         * cp-valprint.c (cp_print_value_fields): Call
2148         cp_print_static_field inside "try".
2149
2150 2019-05-29  Tom Tromey  <tromey@adacore.com>
2151
2152         * inflow.c (struct terminal_info): Add default operator=.
2153         * configure: Rebuild.
2154         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2155         -Wdeprecated-copy-dtor, -Wredundant-move.
2156
2157 2019-05-29  Tom Tromey  <tromey@adacore.com>
2158
2159         * NEWS: Add entry.
2160         * infcmd.c (print_return_value_1): Handle finish_print
2161         option.
2162         (show_print_finish): New function.
2163         (_initialize_infcmd): Add "set/show print finish" commands.
2164         * valprint.c (user_print_options): Initialize new member.
2165         * valprint.h (struct value_print_options) <finish_print>: New
2166         member.
2167
2168 2019-05-28  Tom Tromey  <tromey@adacore.com>
2169
2170         * ada-lang.c (ada_remove_Xbn_suffix)
2171         (find_old_style_renaming_symbol)
2172         (parse_old_style_renaming): Remove.
2173         (ada_find_renaming_symbol): Don't call
2174         find_old_style_renaming_symbol.
2175         (ada_is_renaming_symbol): Rename from
2176         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2177         bool.  Now static.
2178         (ada_read_var_value): Update and simplify.
2179         * ada-exp.y (write_var_or_type): Remove old code.
2180
2181 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2182
2183         * event-top.c: Remove include comment.
2184         * inflow.c (class scoped_ignore_sigttou): Move from here...
2185         * inflow.h (class scoped_ignore_sigttou): ...to here.
2186         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2187         * top.c:  Remove include comment.
2188
2189 2019-05-27  Tom Tromey  <tom@tromey.com>
2190
2191         * NEWS: Fix typo.
2192
2193 2019-05-22  Tom Tromey  <tromey@adacore.com>
2194
2195         * target.c (target_follow_exec): Constify parameter.
2196         * target-delegates.c: Rebuild.
2197         * remote.c (remote_target::follow_exec): Constify parameter.
2198         * infrun.c (follow_exec): Constify parameter.
2199         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2200         (target_follow_exec): Likewise.
2201
2202 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2203
2204         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2205         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2206
2207 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * NEWS: Add debugredirect and testsuite sections.
2210
2211 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2212
2213         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2214         target descriptions using exclusively floating point register name
2215         aliases.
2216
2217 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         PR gdb/18644:
2220         * f-lang.c (build_fortran_types): Handle the case where
2221         gdbarch_floatformat_for_type returns a nullptr.
2222
2223 2019-05-21  Tom de Vries  <tdevries@suse.de>
2224
2225         PR cli/24587
2226         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2227
2228 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         PR gdb/18644:
2231         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2232         16-byte floats.
2233         * i386-tdep.c (i386_floatformat_for_type): Use
2234         floatformats_ia64_quad for the 16-byte floating point component
2235         within a fortran 32-byte complex number.
2236
2237 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2240         delete default constructor.
2241         (find_partial_die): Update to return const struct.
2242         (partial_die_parent_scope): Move variable declaration into scope
2243         of its use and change its type to auto.
2244         (guess_partial_die_structure_name): Likewise.
2245         (partial_die_info::fixup): Likewise.
2246
2247 2019-05-17  Tom Tromey  <tromey@adacore.com>
2248
2249         * source.c (find_and_open_source): Remove cast.
2250
2251 2019-05-17  Tom Tromey  <tromey@adacore.com>
2252
2253         * annotate.c (annotate_source): Make "filename" const.
2254         * annotate.h (annotate_source): Use const.
2255
2256 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2257
2258         * disasm.c (set_disassembler_options): Send errors to stderr.
2259
2260 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2261
2262         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2263         (cli_interp_base::set_logging): Check debug_redirect.
2264         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2265         * cli/cli-logging.c (debug_redirect): Add static variable.
2266         (pop_output_files): Add default param.
2267         (handle_redirections): Print debug setting.
2268         (show_logging_command): Likewise.
2269         (_initialize_cli_logging): Add debugredirect command.
2270         * interps.c (current_interp_set_logging): Add debug_redirect
2271         parameter.
2272         * interps.h (set_logging): Add debug_redirect parameter.
2273         (current_interp_set_logging): Likewise.
2274         * mi/mi-common.h: Likewise.
2275         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2276
2277 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2278             Tom Tromey  <tromey@adacore.com>
2279
2280         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2281         directly.
2282         * cli/cli-interp.h (make_logging_output): Remove declaration.
2283         * cli/cli-logging.c (make_logging_output): Remove function.
2284         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2285         directly.
2286         * ui-file.c (tee_file::tee_file): Remove bools.
2287         (tee_file::~tee_file): Remove deletes.
2288         * ui-file.h (tee_file): Remove bools.
2289
2290 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2291
2292         * mi/mi-cmds.h (mi_cmd_complete): New function.
2293         * mi/mi-main.c (mi_cmd_complete): Likewise.
2294         * mi/mi-cmds.c: Define new MI command -complete.
2295         * NEWS: Mention new -complete command.
2296
2297 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2298
2299         * completer.h (complete): New function.
2300         * completer.c (complete): Likewise.
2301         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2302         function defined in completer.h.
2303
2304 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2305
2306         * MAINTAINERS (Write After Approval): Add myself.
2307
2308 2019-05-17  Tom de Vries  <tdevries@suse.de>
2309
2310         PR gdb/24094
2311         * dwarf2read.c (struct cu_partial_die_info): New struct.
2312         (find_partial_die): Return cu_partial_die_info.
2313         (partial_die_parent_scope, guess_partial_die_structure_name)
2314         (partial_die_info::fixup): Handle new return type of find_partial_die.
2315
2316 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2317
2318         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2319         "std::string", simplifying the algorithm.
2320
2321 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2322
2323         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2324         (stap_static_probe_ops::get_probes): Likewise.
2325
2326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2327
2328         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2329         '-')" and "else if".
2330         (stap_parse_single_operand): Join checks for
2331         "gdbarch_stap_parse_special_token_p" and
2332         "gdbarch_stap_parse_special_token" in the same "if" statement.
2333         Invert check when verifying for operation on register
2334         displacement.
2335
2336 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2337
2338         * stap-probe.c (stap_get_opcode): Update comment.
2339         (stap_get_expected_argument_type): Likewise.
2340         (handle_stap_probe): Likewise.
2341
2342 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2343
2344         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2345         return type to 'bool'.  Adjust comment.  Use 'bool' when
2346         appropriate.
2347         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2348         * stap-probe.c (stap_parse_argument_1): Likewise.
2349         (stap_is_operator): Likewise.
2350         (stap_is_generic_prefix): Likewise.
2351         (stap_is_register_prefix): Likewise.
2352         (stap_is_register_indirection_prefix): Likewise.
2353         (stap_is_integer_prefix): Likewise.
2354         (stap_generic_check_suffix): Likewise.
2355         (stap_check_integer_suffix): Likewise.
2356         (stap_check_register_suffix): Likewise.
2357         (stap_check_register_indirection_suffix): Likewise.
2358         (stap_parse_register_operand): Likewise.
2359         (stap_parse_single_operand): Likewise.
2360         (stap_parse_argument_1): Likewise.
2361         (stap_probe::get_argument_count): Likewise.
2362         (stap_is_operator): Likewise.
2363
2364 2019-05-16  Tom Tromey  <tromey@adacore.com>
2365
2366         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2367         keyword to foreach.
2368
2369 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2370
2371         * linux-thread-db.c (try_thread_db_load_1): Change return type
2372         to bool.
2373         (try_thread_db_load): Likewise.
2374         (try_thread_db_load_from_pdir_1): Likewise.
2375         (try_thread_db_load_from_pdir): Likewise.
2376         (try_thread_db_load_from_sdir): Likewise.
2377         (try_thread_db_load_from_dir): Likewise.
2378         (thread_db_load_search): Likewise.
2379         (has_libpthread): Likewise.
2380         (thread_db_load): Likewise.
2381
2382 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2383
2384         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2385         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2386         NULL, and complain/return if that's the case.
2387
2388 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2389
2390         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2391         (advance, posn, abstract_read_memory): New functions.
2392         [struct mem_read_abstraction]: New struct.
2393         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2394
2395 2019-05-14  Tom Tromey  <tromey@adacore.com>
2396
2397         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2398         value is not lval_memory.
2399
2400 2019-05-14  Tom Tromey  <tromey@adacore.com>
2401
2402         * solib.c (info_sharedlibrary_command): Style the file name.
2403
2404 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2405
2406         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2407         (aarch64_vnv_type): Likewise.
2408         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2409         * common/tdesc.c: Likewise.
2410         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2411         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2412         * features/aarch64-fpu.xml: Add ieee half view.
2413         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2414         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2415         * gdbtypes.h (struct builtin_type): Likewise.
2416         (struct objfile_type): Likewise.
2417
2418 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2419
2420         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2421         typo.
2422         * location.h (string_to_event_location): Likewise.
2423
2424 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2425
2426         GDB 8.3 released.
2427
2428 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2429
2430         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2431         New variable declaration.
2432         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2433         New variable.
2434         (print_one_breakpoint): Use ui_out::test_flags and new global
2435         variable to compute use_fixed_output.
2436         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2437         Remove.
2438         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2439         (mi_multi_location_breakpoint_output_fixed): Remove.
2440         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2441         new variable.
2442         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2443         fix_multi_location_breakpoint_output flag if version >= 3.
2444         * ui-out.h (enum ui_out_flag)
2445         <fix_multi_location_breakpoint_output>: New enumerator.
2446
2447 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2448
2449         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2450
2451 2019-05-10  Tom Tromey  <tromey@adacore.com>
2452
2453         * ada-lang.c (catch_ada_completer): New function.
2454         (_initialize_ada_language): Use it.
2455
2456 2019-05-10  Tom Tromey  <tromey@adacore.com>
2457
2458         * thread.c (print_thread_info): Make "requested_threads" const.
2459         * gdbthread.h (print_thread_info): Make "requested_threads"
2460         const.
2461         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2462         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2463
2464 2019-05-08  Tom Tromey  <tom@tromey.com>
2465
2466         * gdbtypes.c (objfile_type_data): Change type.
2467         (objfile_type, _initialize_gdbtypes): Update.
2468
2469 2019-05-08  Tom Tromey  <tom@tromey.com>
2470
2471         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2472         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2473         (_initialize_dwarf2_frame): Update.
2474
2475 2019-05-08  Tom Tromey  <tom@tromey.com>
2476
2477         * objc-lang.c (objc_objfile_data): Change type.
2478         (find_methods): Update.
2479         (_initialize_objc_lang): Remove.
2480
2481 2019-05-08  Tom Tromey  <tom@tromey.com>
2482
2483         * stabsread.c (rs6000_builtin_type_data): Change type.
2484         (rs6000_builtin_type, _initialize_stabsread): Update.
2485
2486 2019-05-08  Tom Tromey  <tom@tromey.com>
2487
2488         * mips-tdep.c (mips_pdr_data): Remove.
2489         (_initialize_mips_tdep): Update.
2490
2491 2019-05-08  Tom Tromey  <tom@tromey.com>
2492
2493         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2494         (hppa_init_objfile_priv_data, read_unwind_info)
2495         (find_unwind_entry, _initialize_hppa_tdep): Update.
2496
2497 2019-05-08  Tom Tromey  <tom@tromey.com>
2498
2499         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2500         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2501         on obstack.
2502         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2503
2504 2019-05-08  Tom Tromey  <tom@tromey.com>
2505
2506         * mdebugread.c (basic_type_data): Change type.
2507         (basic_type, _initialize_mdebugread): Update.
2508
2509 2019-05-08  Tom Tromey  <tom@tromey.com>
2510
2511         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2512
2513 2019-05-08  Tom Tromey  <tom@tromey.com>
2514
2515         * nto-tdep.c (nto_inferior_data_reg): Change type.
2516         (nto_inferior_data): Update.
2517         (nto_inferior_data_cleanup, nto_new_inferior_data)
2518         (_initialize_nto_tdep): Remove.
2519         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2520
2521 2019-05-08  Tom Tromey  <tom@tromey.com>
2522
2523         * ada-lang.c (struct ada_inferior_data): Add initializers.
2524         (ada_inferior_data): Change type.
2525         (ada_inferior_data_cleanup): Remove.
2526         (get_ada_inferior_data, ada_inferior_exit)
2527         (struct ada_pspace_data): Add initializers, destructor.
2528         (ada_pspace_data_handle): Change type.
2529         (get_ada_pspace_data): Update.
2530         (ada_pspace_data_cleanup): Remove.
2531
2532 2019-05-08  Tom Tromey  <tom@tromey.com>
2533
2534         * coffread.c (struct coff_symfile_info): Add initializers.
2535         (coff_objfile_data_key): Move lower.  Change type.
2536         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2537         Update.
2538         (coff_free_info): Remove.
2539
2540 2019-05-08  Tom Tromey  <tom@tromey.com>
2541
2542         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2543         (fbsd_pspace_data_handle): Move lower.  Change type.
2544         (get_fbsd_pspace_data): Update.
2545         (fbsd_pspace_data_cleanup): Remove.
2546         (_initialize_fbsd_tdep): Update.
2547
2548 2019-05-08  Tom Tromey  <tom@tromey.com>
2549
2550         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2551         (get_ada_tasks_pspace_data): Update.
2552         (ada_tasks_pspace_data_cleanup): Remove.
2553         (_initialize_tasks): Update.
2554         (ada_tasks_inferior_data_handle): Change type.
2555         (get_ada_tasks_inferior_data): Update.
2556         (ada_tasks_inferior_data_cleanup): Remove.
2557         (struct ada_tasks_pspace_data): Add initializers.
2558
2559 2019-05-08  Tom Tromey  <tom@tromey.com>
2560
2561         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2562         * symfile-debug.c (debug_sym_get_probes): Change type.
2563         * stap-probe.c (handle_stap_probe):
2564         (stap_static_probe_ops::get_probes): Change type.
2565         * probe.h (class static_probe_ops) <get_probes>: Change type.
2566         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2567         (parse_probes_in_pspace): Update.
2568         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2569         Update.
2570         (any_static_probe_ops::get_probes): Change type.
2571         * elfread.c (elfread_data): New typedef.
2572         (probe_key): Change type.
2573         (elf_get_probes): Likewise.  Update.
2574         (probe_key_free): Remove.
2575         (_initialize_elfread): Update.
2576         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2577         Change type.
2578         (dtrace_process_dof_probe, dtrace_process_dof)
2579         (dtrace_static_probe_ops::get_probe): Change type.
2580
2581 2019-05-08  Tom Tromey  <tom@tromey.com>
2582
2583         * xcoffread.c (struct xcoff_symfile_info): Rename from
2584         coff_symfile_info.  Add initializers.
2585         (xcoff_objfile_data_key): Move lower.  Change type.
2586         (XCOFF_DATA): Rewrite.
2587         (xcoff_free_info): Remove.
2588         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2589         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2590         (xcoff_initial_scan): Update.
2591
2592 2019-05-08  Tom Tromey  <tom@tromey.com>
2593
2594         * solib-svr4.c (struct svr4_info): Add initializers and
2595         destructor.
2596         <probes_table>: Now an htab_up.
2597         (solib_svr4_pspace_data): Change type.
2598         (free_probes_table): Simplify.
2599         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2600         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2601         (probes_table_remove_objfile_probes, register_solib_event_probe)
2602         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2603         (_initialize_svr4_solib): Update.
2604
2605 2019-05-08  Tom Tromey  <tom@tromey.com>
2606
2607         * remote.c (remote_pspace_data): Change type.
2608         (remote_pspace_data_cleanup): Remove.
2609         (get_remote_exec_file, set_pspace_remote_exec_file)
2610         (_initialize_remote): Update.
2611
2612 2019-05-08  Tom Tromey  <tom@tromey.com>
2613
2614         * breakpoint.c (breakpoint_objfile_key): Change type.
2615         (get_breakpoint_objfile_data): Update.
2616         (free_breakpoint_objfile_data): Remove.
2617         (_initialize_breakpoint): Update.
2618
2619 2019-05-08  Tom Tromey  <tom@tromey.com>
2620
2621         * linux-tdep.c (struct linux_info): Add initializers.
2622         (linux_inferior_data): Move.  Change type.
2623         (invalidate_linux_cache_inf): Update.
2624         (linux_inferior_data_cleanup): Remove.
2625         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2626
2627 2019-05-08  Tom Tromey  <tom@tromey.com>
2628
2629         * auxv.c (auxv_inferior_data): Move.  Change type.
2630         (auxv_inferior_data_cleanup): Remove.
2631         (invalidate_auxv_cache_inf): Rewrite.
2632         (get_auxv_inferior_data, _initialize_auxv): Update.
2633
2634 2019-05-08  Tom Tromey  <tom@tromey.com>
2635
2636         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2637         (symfile_debug_objfile_data_key): Change type.
2638         (symfile_debug_installed, debug_qf_has_symbols)
2639         (debug_qf_find_last_source_symtab)
2640         (debug_qf_forget_cached_source_info)
2641         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2642         (debug_qf_print_stats, debug_qf_dump)
2643         (debug_qf_expand_symtabs_for_function)
2644         (debug_qf_expand_all_symtabs)
2645         (debug_qf_expand_symtabs_with_fullname)
2646         (debug_qf_map_matching_symbols)
2647         (debug_qf_expand_symtabs_matching)
2648         (debug_qf_find_pc_sect_compunit_symtab)
2649         (debug_qf_map_symbol_filenames)
2650         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2651         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2652         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2653         (debug_sym_read_linetable, debug_sym_relocate): Update.
2654         (symfile_debug_free_objfile): Remove.
2655         (install_symfile_debug_logging, _initialize_symfile_debug):
2656         Update.
2657
2658 2019-05-08  Tom Tromey  <tom@tromey.com>
2659
2660         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2661         allocate_on_obstack.
2662         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2663         (get_dwarf2_per_objfile): Update.
2664         (set_dwarf2_per_objfile): Remove.
2665         (dwarf2_has_info, dwarf2_get_section_info): Update.
2666         (dwarf2_free_objfile): Remove.
2667         (_initialize_dwarf2_read): Update.
2668
2669 2019-05-08  Tom Tromey  <tom@tromey.com>
2670
2671         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2672         initializers.
2673         <unsupported_script_warning_printed,
2674         script_not_found_warning_printed>: Now bool.
2675         (auto_load_pspace_data): Change type.
2676         (~auto_load_pspace_info): Rename from
2677         auto_load_pspace_data_cleanup.
2678         (get_auto_load_pspace_data, init_loaded_scripts_info)
2679         (clear_section_scripts, maybe_print_unsupported_script_warning)
2680         (maybe_print_script_not_found_warning, _initialize_auto_load):
2681         Update.
2682
2683 2019-05-08  Tom Tromey  <tom@tromey.com>
2684
2685         * objfiles.c (objfile_pspace_info): Add destructor and
2686         initializers.
2687         (objfiles_pspace_data): Change type.
2688         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2689         (get_objfile_pspace_data): Update.
2690         (objfiles_bfd_data): Change type.
2691         (get_objfile_bfd_data): Update.
2692         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2693
2694 2019-05-08  Tom Tromey  <tom@tromey.com>
2695
2696         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2697         Change type.
2698         (get_catch_syscall_inferior_data): Update.
2699         (catch_syscall_inferior_data_cleanup): Remove.
2700         (_initialize_break_catch_syscall): Update.
2701
2702 2019-05-08  Tom Tromey  <tom@tromey.com>
2703
2704         * inflow.c (struct terminal_info): Add destructor and
2705         initializers.
2706         (inflow_inferior_data): Change type.
2707         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2708         (get_inflow_inferior_data, inflow_inferior_exit)
2709         (swap_terminal_info, _initialize_inflow): Update.
2710
2711 2019-05-08  Tom Tromey  <tom@tromey.com>
2712
2713         * target-dcache.c (target_dcache_cleanup): Remove.
2714         (target_dcache_aspace_key): Change type.
2715         (target_dcache_init_p, target_dcache_invalidate)
2716         (target_dcache_get, target_dcache_get_or_init)
2717         (_initialize_target_dcache): Update.
2718         * dcache.h (struct dcache_deleter): New.
2719
2720 2019-05-08  Tom Tromey  <tom@tromey.com>
2721
2722         * symtab.c (struct symbol_cache): Add destructor and
2723         initializers.
2724         (symbol_cache_key): Move.  Change type.
2725         (make_symbol_cache, free_symbol_cache): Remove.
2726         (get_symbol_cache): Update.
2727         (symbol_cache_cleanup): Remove.
2728         (ALL_PSPACES, symbol_cache_flush)
2729         (maintenance_print_symbol_cache)
2730         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2731         Update.
2732
2733 2019-05-08  Tom Tromey  <tom@tromey.com>
2734
2735         * symtab.c (struct main_info): Add destructor and initializers.
2736         (main_progspace_key): Move.  Change type.
2737         (get_main_info): Update.
2738         (main_info_cleanup): Remove.
2739         (_initialize_symtab): Update.
2740
2741 2019-05-08  Tom Tromey  <tom@tromey.com>
2742
2743         * registry.h (DECLARE_REGISTRY): Define the _key class.
2744
2745 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2746
2747         * NEWS: Merge two 'New commands' sections.
2748
2749 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2750
2751         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2752         parameter and use Ada language definition instead.
2753         (ada_val_print_ptr): Remove unused language parameter.
2754         (ada_val_print_num): Remove language parameter and use Ada language
2755         definition instead.
2756         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2757         parameter.
2758         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2759         parameter and use Ada language definition instead.
2760         (ada_val_print_1): Update all ada_val_print_xxx calls.
2761         Remove language parameter.
2762         (ada_val_print): Update ada_val_print_1 call.
2763
2764 2019-05-08  Tom Tromey  <tromey@adacore.com>
2765
2766         * remote.c (remote_hw_watchpoint_limit)
2767         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2768         Now static.
2769
2770 2019-05-08  Tom Tromey  <tromey@adacore.com>
2771
2772         * maint.c (_initialize_maint_cmds): Move initialization code to
2773         remote.c.
2774         (watchdog, show_watchdog): Move to remote.c.
2775         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2776         "watchdog" static.
2777         (_initialize_remote): Move initialization code from maint.c.
2778         * defs.h (watchdog): Don't declare.
2779
2780 2019-05-08  Tom Tromey  <tromey@adacore.com>
2781
2782         * tui/tui-interp.c: Include main.h.
2783         * interps.c: Include main.h.
2784         * main.h (interpreter_p): Declare.
2785         * defs.h (interpreter_p): Don't declare.
2786
2787 2019-05-08  Tom Tromey  <tromey@adacore.com>
2788
2789         * dwarf2loc.c: Include dwarf2read.h.
2790         * defs.h (read_unsigned_leb128): Don't declare.
2791         * dwarf2read.h (read_unsigned_leb128): Declare.
2792
2793 2019-05-08  Tom Tromey  <tromey@adacore.com>
2794
2795         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2796         method.
2797
2798 2019-05-08  Tom Tromey  <tromey@adacore.com>
2799
2800         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2801         when no wrap column is set.
2802
2803 2019-05-08  Tom Tromey  <tromey@adacore.com>
2804
2805         * c-lang.c (c_get_string): Handle non-C-style arrays.
2806
2807 2019-05-08  Tom Tromey  <tromey@adacore.com>
2808
2809         * typeprint.c (print_offset_data::update): Print the bit offset,
2810         not the number of bits remaining.
2811
2812 2019-05-08  Tom Tromey  <tromey@adacore.com>
2813
2814         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2815         padding at end of comment.
2816
2817 2019-05-08  Tom Tromey  <tromey@adacore.com>
2818
2819         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2820         Compare main types.
2821
2822 2019-05-06  Tom Tromey  <tom@tromey.com>
2823
2824         * common/scoped_mmap.c: Include common-defs.h.
2825         * common/scoped_mmap.h: Don't include config.h.
2826
2827 2019-05-04  Tom Tromey  <tom@tromey.com>
2828
2829         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2830         (struct aarch64_call_info): Add initializers.
2831         <si>: Now a std::vector.
2832         (pass_on_stack, aarch64_push_dummy_call): Update.
2833
2834 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2835             Tom Tromey  <tom@tromey.com>
2836
2837         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2838         (ppc_threads): Now a std::vector.  Now static.
2839         (hwdebug_find_thread_points_by_tid)
2840         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2841         Update.
2842
2843 2019-05-04  Tom Tromey  <tom@tromey.com>
2844
2845         * arc-tdep.c (arc_tdesc_init): Return bool.
2846
2847 2019-05-04  Tom Tromey  <tom@tromey.com>
2848
2849         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2850         Use gdb_assert_not_reached.
2851
2852 2019-05-04  Tom Tromey  <tom@tromey.com>
2853
2854         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2855         "false".
2856
2857 2019-05-04  Tom Tromey  <tom@tromey.com>
2858
2859         * arc-tdep.c (arc_tdesc_init): Use bool.
2860
2861 2019-05-04  Tom Tromey  <tom@tromey.com>
2862
2863         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2864
2865 2019-05-04  Tom Tromey  <tom@tromey.com>
2866
2867         * cli/cli-cmds.c (valid_command_p): Return bool.
2868
2869 2019-05-04  Tom Tromey  <tom@tromey.com>
2870
2871         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2872         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2873
2874 2019-05-04  Raul Tambre  <raul@tambre.ee>
2875
2876         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2877         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2878         operator for comparison.
2879
2880 2019-05-04  Tom Tromey  <tom@tromey.com>
2881
2882         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2883         (lookup_partial_symbol, print_partial_symbols)
2884         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2885         (psymbol_compare): Update.
2886         (add_psymbol_to_bcache): Clear the entire psymbol.
2887         (maintenance_check_psymtabs): Update.
2888         * psympriv.h (struct partial_symbol): Don't derive from
2889         general_symbol_info.
2890         <obj_section, unrelocated_address, address,
2891         set_unrelocated_address>: Update.
2892         <ginfo>: New member.
2893         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2894         (debug_names::write_psymbols): Update.
2895
2896 2019-05-04  Tom de Vries  <tdevries@suse.de>
2897
2898         * contrib/cc-with-tweaks.sh: Support -n arg.
2899
2900 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2901
2902         * corelow.c (core_target::detach): Ensure frame cache and
2903         register caches are cleared.
2904         inferior.c (exit_inferior_1): Likewise.
2905
2906 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2907             Tom Tromey  <tom@tromey.com>
2908
2909         * dictionary.c (collate_pending_symbols_by_language): Remove
2910         "struct" from foreach.
2911         * symtab.c (lookup_global_symbol_from_objfile)
2912         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2913         foreach.
2914         * ser-tcp.c (net_open): Remove "struct" from foreach.
2915         * objfiles.c (objfile_relocate, objfile_rebase)
2916         (objfile_has_symbols): Remove "struct" from foreach.
2917         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2918         from foreach.
2919         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2920         foreach.
2921         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2922         "struct" from foreach.
2923         * ada-lang.c (create_excep_cond_exprs)
2924         (ada_exception_catchpoint_cond_string): Remove "struct" from
2925         foreach.
2926
2927 2019-05-03  Tom Tromey  <tromey@adacore.com>
2928
2929         * ada-exp.y (convert_char_literal): Check suffix of each
2930         enumerator.
2931
2932 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2933
2934         PR ada/21406:
2935         * ada-exp.y (yywrap): Don't define.
2936         * ada-lex.l (%option): Add noyywrap
2937         (yywrap): Remove.
2938
2939 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2940
2941         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2942         _WIN32_WINNT to the XP level, unless already defined to a higher
2943         level.
2944
2945         * unittests/parse-connection-spec-selftests.c:
2946         * ser-tcp.c:
2947         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2948         override.
2949
2950         * symfile.c (find_separate_debug_file): Remove colon from the
2951         drive spec of DOS/Windows file names of the target, so that the
2952         file name produced from DEBUGDIR and the target's directory will
2953         be valid on DOS/Windows systems.
2954
2955 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * rust-lang.c (val_print_struct): Handle printing structures
2958         containing strings.
2959
2960 2019-05-02  Tom Tromey  <tromey@adacore.com>
2961
2962         * valarith.c (_initialize_valarith): Remove.
2963
2964 2019-05-01  Tom Tromey  <tromey@adacore.com>
2965
2966         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2967         bitfields.
2968
2969 2019-05-01  Tom Tromey  <tromey@adacore.com>
2970
2971         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2972         for big-endian copies.
2973
2974 2019-04-30  Ali Tamur  <tamur@google.com>
2975         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2976         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2977         (read_3_bytes): New function.
2978
2979 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2980
2981         * windows-nat.c (main_thread_id): Delete.
2982         (handle_output_debug_string): Replace main_thread_id by
2983         current_event.dwThreadId.
2984         (fake_create_process): Likewise.
2985         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2986         Do not set main_thread_id.
2987         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2988         current_event.dwThreadId.
2989         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2990
2991 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2992
2993         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2994         Use current_event.dwThreadId instead of main_thread_id.
2995
2996 2019-04-30  Tom Tromey  <tromey@adacore.com>
2997
2998         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2999         (create_excep_cond_exprs): Iterate over program spaces.
3000         (ada_exception_catchpoint_cond_string): Examine all minimal
3001         symbols for exception types.
3002
3003 2019-04-30  Tom Tromey  <tromey@adacore.com>
3004
3005         PR c++/24470:
3006         * dwarf2read.c (process_structure_scope): Handle case where type
3007         has template parameters but no symbol was created.
3008
3009 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3010             Chris January  <chris.january@arm.com>
3011
3012         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3013         qualifier.
3014         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3015
3016 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * f-typeprint.c (f_print_type): Update rules for printing
3019         whitespace.
3020         (f_type_print_varspec_suffix): Likewise.
3021
3022 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3023             Chris January  <chris.january@arm.com>
3024
3025         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3026         function arguments.
3027
3028 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * f-lang.c (build_fortran_types): Change name of void type to
3031         lower case.
3032         * f-typeprint.c (f_type_print_base): Print the name of the void
3033         type, rather than a fixed string.
3034         * f-valprint.c (f_decorations): Use lower case void string.
3035
3036 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3037             Chris January  <chris.january@arm.com>
3038
3039         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3040         types for Fortran.
3041
3042 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3043             Chris January  <chris.january@arm.com>
3044             David Lecomber  <david.lecomber@arm.com>
3045
3046         * f-exp.y (BINOP_INTRINSIC): New token.
3047         (exp): New parser rule handling BINOP_INTRINSIC.
3048         (f77_keywords): Add new builtin procedures.
3049         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3050         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3051         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3052         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3053         (print_unop_subexp_f): New function.
3054         (print_binop_subexp_f): New function.
3055         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3056         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3057         (dump_subexp_body_f): Likewise.
3058         (operator_check_f): Likewise.
3059         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3060         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3061
3062 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3063
3064         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3065         UNOP_KIND.
3066         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3067         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3068         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3069         (operator_length_f): New fuction.
3070         (print_subexp_f): New function.
3071         (op_name_f): New function.
3072         (dump_subexp_body_f): New function.
3073         (operator_check_f): New function.
3074         (exp_descriptor_f): Replace standard expression handling functions
3075         with new functions.
3076         * gdb/fortran-operator.def: New file.
3077         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3078         * gdb/std-operator.def: Remove UNOP_KIND.
3079
3080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * std-operator.def: Remove unbalanced, stray double quote
3083         character.
3084
3085 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3086             Chris January  <chris.january@arm.com>
3087             Daniel Everett  <daniel.everett@arm.com>
3088             Nick Forrington  <nick.forrington@arm.com>
3089             Richard Bunt  <richard.bunt@arm.com>
3090
3091         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3092         of depth when printing anonymous structs or unions.
3093         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3094         Don't print either the top-level value, or the children if the
3095         max-depth is exceeded.
3096         (ppscm_print_children): When printing the key of a map, allow one
3097         extra level of depth.
3098         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3099         print either the top-level value, or the children if the max-depth
3100         is exceeded.
3101         (print_children): When printing the key of a map, allow one extra
3102         level of depth.
3103         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3104         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3105         (user_print_options): Initialise max_depth field.
3106         (val_print_scalar_or_string_type_p): New function.
3107         (val_print): Check to see if the max depth has been reached.
3108         (val_print_check_max_depth): Define new function.
3109         (show_print_max_depth): New function.
3110         (_initialize_valprint): Add 'print max-depth' option.
3111         * valprint.h (struct value_print_options) <max_depth>: New field.
3112         (val_print_check_max_depth): Declare new function.
3113         * NEWS: Document new feature.
3114
3115 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3116
3117         * ada-lang.c (ada_language_defn): Initialise new field.
3118         * c-lang.c (c_is_string_type_p): New function.
3119         (c_language_defn): Initialise new field.
3120         (cplus_language_defn): Initialise new field.
3121         (asm_language_defn): Initialise new field.
3122         (minimal_language_defn): Initialise new field.
3123         * c-lang.h (c_is_string_type_p): Declare new function.
3124         * d-lang.c (d_language_defn): Initialise new field.
3125         * f-lang.c (f_is_string_type_p): New function.
3126         (f_language_defn): Initialise new field.
3127         * go-lang.c (go_is_string_type_p): New function.
3128         (go_language_defn): Initialise new field.
3129         * language.c (default_is_string_type_p): New function.
3130         (unknown_language_defn): Initialise new field.
3131         (auto_language_defn): Initialise new field.
3132         * language.h (struct language_defn) <la_is_string_type_p>: New
3133         member variable.
3134         (default_is_string_type_p): Declare new function.
3135         * m2-lang.c (m2_language_defn): Initialise new field.
3136         * objc-lang.c (objc_language_defn): Initialise new field.
3137         * opencl-lang.c (opencl_language_defn): Initialise new field.
3138         * p-lang.c (pascal_is_string_type_p): New function.
3139         (pascal_language_defn): Initialise new field.
3140         * rust-lang.c (rust_is_string_type_p): New function.
3141         (rust_language_defn): Initialise new field.
3142
3143 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3146         New field.
3147         * ada-lang.c (ada_language_defn): Initialise new field.
3148         * c-lang.c (c_language_defn): Likewise.
3149         (cplus_language_defn): Likewise.
3150         (asm_language_defn): Likewise.
3151         (minimal_language_defn): Likewise.
3152         * d-lang.c (d_language_defn): Likewise.
3153         * f-lang.c (f_language_defn): Likewise.
3154         * go-lang.c (go_language_defn): Likewise.
3155         * language.c (unknown_language_defn): Likewise.
3156         (auto_language_defn): Likewise.
3157         * m2-lang.c (m2_language_defn): Likewise.
3158         * objc-lang.c (objc_language_defn): Likewise.
3159         * opencl-lang.c (opencl_language_defn): Likewise.
3160         * p-lang.c (pascal_language_defn): Likewise.
3161         * rust-lang.c (rust_language_defn): Likewise.
3162
3163 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3164
3165         * ada-lang.c (ada_is_character_type): Change return type to bool.
3166         (ada_is_string_type): Likewise.
3167         * ada-lang.h (ada_is_character_type): Update declaration
3168         (ada_is_string_type): Likewise.
3169
3170 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3171
3172         Support style in 'frame|thread apply'
3173
3174         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3175         * record.c (record_start, record_stop): Update callers of
3176         execute_command_to_string with false.
3177         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3178         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3179         methods.
3180         (class string_file): New constructor with term_out parameter.
3181         Override methods term_out and can_emit_style_escape.  New member
3182         term_out.
3183         (class stdio_file): Override can_emit_style_escape.
3184         (class tee_file): Override term_out and can_emit_style_escape.
3185         * utils.h (can_emit_style_escape): Remove.
3186         * utils.c (can_emit_style_escape): Likewise.
3187         Update all callers of can_emit_style_escape (SOMESTREAM) to
3188         SOMESTREAM->can_emit_style_escape.
3189         * source-cache.c (source_cache::get_source_lines): Likewise.
3190         * stack.c (frame_apply_command_count): Call execute_command_to_string
3191         passing the term_out characteristic of the current gdb_stdout.
3192         * thread.c (thr_try_catch_cmd): Likewise.
3193         * top.c (execute_command_to_string): pass term_out parameter
3194         to construct the string_file for the command output.
3195         * ui-file.c (term_cli_styling): New function (most code moved
3196         from utils.c can_emit_style_escape).
3197         (string_file::string_file, string_file::can_emit_style_escape,
3198         stdio_file::can_emit_style_escape, tee_file::term_out,
3199         tee_file::can_emit_style_escape): New functions.
3200
3201 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3202
3203         * NEWS: Mention the new set|show may-call-functions.
3204         * infcall.c (may_call_functions_p): New variable.
3205         (show_may_call_functions_p): New function.
3206         (call_function_by_hand_dummy): Throws an error if not
3207         may-call-functions.
3208         (_initialize_infcall): Call add_setshow_boolean_cmd for
3209         may-call-functions.
3210
3211 2019-04-25  Keith Seitz  <keiths@redhat.com>
3212
3213         PR c++/24367
3214         * cp-support.c (inspect_type): Don't attempt substitutions
3215         of symbol with the same name.
3216
3217 2019-04-25  Tom Tromey  <tromey@adacore.com>
3218
3219         PR gdb/24475:
3220         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3221         static.
3222
3223 2019-04-25  Tom Tromey  <tromey@adacore.com>
3224
3225         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3226         rvalue reference.
3227         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3228         (gdb_xml_parser::parse): Use std::move.
3229         * python/python-internal.h (gdbpy_convert_exception): Take a const
3230         reference.
3231         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3232         std::move.
3233         * python/py-utils.c (gdbpy_convert_exception): Take a const
3234         reference.
3235         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3236         Use std::move.
3237         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3238         Use std::move.
3239         * mi/mi-main.c (mi_print_exception): Take a const reference.
3240         * main.c (handle_command_errors): Take a const reference.
3241         * linespec.c (parse_linespec): Use std::move.
3242         * infcall.c (run_inferior_call): Use std::move.
3243         (call_function_by_hand_dummy): Use std::move.
3244         * exec.c (try_open_exec_file): Use std::move.
3245         * exceptions.h (exception_print, exception_fprintf)
3246         (exception_print_same): Update.
3247         * exceptions.c (print_exception, exception_print)
3248         (exception_fprintf, exception_print_same): Change parameters to
3249         const reference.
3250         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3251         * common/new-op.c: Use std::move.
3252         * common/common-exceptions.h (struct gdb_exception): Add move
3253         constructor.
3254         (struct gdb_exception_error, struct gdb_exception_quit, struct
3255         gdb_quit_bad_alloc): Change constructor to move constructor.
3256         (throw_exception): Change parameter to rvalue reference.
3257         * common/common-exceptions.c (throw_exception): Take rvalue
3258         reference.
3259         * cli/cli-interp.c (safe_execute_command): Use std::move.
3260         * breakpoint.c (insert_bp_location, location_to_sals): Use
3261         std::move.
3262
3263 2019-04-25  Tom Tromey  <tromey@adacore.com>
3264
3265         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3266         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3267         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3268         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3269         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3270         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3271         guile/scm-value.c: Use unpack.
3272         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3273         gdbscm_gdb_exception.
3274         (gdbscm_throw_gdb_exception): Likewise.
3275         (struct gdbscm_gdb_exception): New.
3276         (unpack): New function.
3277         (gdbscm_wrap): Use unpack.
3278
3279 2019-04-25  Tom Tromey  <tromey@adacore.com>
3280
3281         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3282         (gdb_rl_callback_handler): Use std::move.
3283         * common/common-exceptions.h (struct gdb_exception): Add move
3284         assignment operator.
3285         (throw_exception_sjlj): Change "exception" to const reference.
3286         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3287         (throw_exception_sjlj): Change "exception" to const reference.
3288
3289 2019-04-25  Tom Tromey  <tromey@adacore.com>
3290
3291         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3292         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3293         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3294         Update.
3295         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3296         Update.
3297         * mi/mi-interp.c (mi_interp::exec): Update.
3298         * linespec.c (parse_linespec): Update.
3299         * infcall.c (run_inferior_call): Update.
3300         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3301         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3302         (gdbscm_lookup_global_symbol): Update.
3303         * guile/scm-param.c (gdbscm_parameter_value): Update.
3304         * guile/scm-frame.c (gdbscm_frame_read_register)
3305         (gdbscm_frame_read_var): Update.
3306         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3307         * exec.c (try_open_exec_file): Update.
3308         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3309         (gdb_rl_callback_handler): Update.
3310         * common/common-exceptions.h (exception_none): Don't declare.
3311         * common/common-exceptions.c (exception_none): Don't define.
3312         (struct catcher) <exception>: Update.
3313         * cli/cli-interp.c (safe_execute_command): Update.
3314         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3315
3316 2019-04-25  Ali Tamur  <tamur@google.com>
3317
3318         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3319         (read_attribute_value): Likewise.
3320         (dwarf2_read_addr_index): Update comment.
3321         (read_str_index): Add DW_FORM_strx.
3322         (dwarf2_string_attr): Likewise.
3323         (dwarf2_const_value_attr): Likewise.
3324         (dump_die_shallow): Likewise.
3325         (dwarf2_fetch_constant_bytes): Likewise.
3326         (skip_form_bytes): Likewise.
3327         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3328
3329 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3330
3331         PR corefiles/11608
3332         PR corefiles/18187
3333         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3334         OFFSET.  Verify if current mapping contains an ELF header.
3335         (linux_find_memory_regions_full): Adjust call to
3336         dump_mapping_p.
3337
3338 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3339             Kang Li <kanglictf@gmail.com>
3340
3341         PR gdb/21600
3342
3343         * dwarf2-frame.c (read_initial_length): Be consistent about using
3344         unsigned representation of length.
3345         (decode_frame_entry_1): Likewise.  Check for wraparound of
3346         end pointer as well as buffer overflow.
3347
3348 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3349
3350         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3351         "vq".
3352
3353 2019-04-24  Tom Tromey  <tromey@adacore.com>
3354
3355         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3356
3357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * s12z-tdep.c (s12z_unwind_pc): Delete.
3360         (s12z_unwind_sp): Delete.
3361         (s12z_gdbarch_init): Don't register deleted functions with
3362         gdbarch.
3363
3364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3365
3366         * rl78-tdep.c (rl78_unwind_sp): Delete.
3367         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3368
3369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3372         (xstormy16_unwind_pc): Delete.
3373         (xstormy16_dummy_id): Delete.
3374         (xstormy16_gdbarch_init): Don't register deleted functions with
3375         gdbarch.
3376
3377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3378
3379         * vax-tdep.c (vax_unwind_pc): Delete.
3380         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3381
3382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3383
3384         * v850-tdep.c (v850_unwind_sp): Delete.
3385         (v850_unwind_pc): Delete.
3386         (v850_dummy_id): Delete.
3387         (v850_gdbarch_init): Don't register deleted functions with
3388         gdbarch.
3389
3390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3391
3392         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3393         (tilegx_unwind_pc): Delete.
3394         (tilegx_unwind_dummy_id): Delete.
3395         (tilegx_gdbarch_init): Don't register deleted functions with
3396         gdbarch.
3397
3398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3401         (tic6x_dummy_id): Delete.
3402         (tic6x_gdbarch_init): Don't register deleted functions with
3403         gdbarch.
3404
3405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * sparc-tdep.c (sparc_unwind_pc): Delete.
3408         (sparc32_gdbarch_init): Don't register deleted function with
3409         gdbarch.
3410
3411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * sh-tdep.c (sh_unwind_sp): Delete.
3414         (sh_unwind_pc): Delete.
3415         (sh_dummy_id): Delete.
3416         (sh_gdbarch_init): Don't register deleted functions with
3417         gdbarch.
3418
3419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * score-tdep.c (score_unwind_sp): Delete.
3422         (score_unwind_pc): Delete.
3423         (score_dummy_id): Delete.
3424         (score_gdbarch_init): Don't register deleted functions with
3425         gdbarch.
3426
3427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * rx-tdep.c (rx_unwind_pc): Delete.
3430         (rx_unwind_sp): Delete.
3431         (rx_dummy_id): Delete.
3432         (rx_gdbarch_init): Don't register deleted functions with
3433         gdbarch.  Update comment.
3434
3435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3438         (rs6000_dummy_id): Delete.
3439         (rs6000_gdbarch_init): Don't register deleted functions with
3440         gdbarch.
3441
3442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * or1k-tdep.c (or1k_dummy_id): Delete.
3445         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3446
3447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * nios2-tdep.c (nios2_dummy_id): Delete.
3450         (nios2_unwind_sp): Delete.
3451         (nios2_gdbarch_init): Don't register deleted functions with
3452         gdbarch.
3453
3454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * nds32-tdep.c (nds32_dummy_id): Delete.
3457         (nds32_unwind_pc): Delete.
3458         (nds32_unwind_sp): Delete.
3459         (nds32_gdbarch_init): Don't register deleted functions with
3460         gdbarch.
3461
3462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * msp430-tdep.c (msp430_unwind_pc): Delete.
3465         (msp430_unwind_sp): Delete.
3466         (msp430_dummy_id): Delete.
3467         (msp430_gdbarch_init): Don't register deleted functions with
3468         gdbarch.
3469
3470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * moxie-tdep.c (moxie_unwind_sp): Delete.
3473         (moxie_unwind_pc): Delete.
3474         (moxie_dummy_id): Delete.
3475         (moxie_gdbarch_init): Don't register deleted functions with
3476         gdbarch.
3477
3478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3479
3480         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3481         (mn10300_unwind_pc): Delete.
3482         (mn10300_unwind_sp): Delete.
3483         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3484         mn10300_unwind_sp.
3485         (mn10300_frame_unwind_init): Don't register deleted functions with
3486         gdbarch.
3487
3488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * mep-tdep.c (mep_unwind_pc): Delete.
3491         (mep_unwind_sp): Delete.
3492         (mep_dummy_id): Delete.
3493         (mep_gdbarch_init): Don't register deleted functions with
3494         gdbarch.
3495
3496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3499         (m68hc11_unwind_sp): Delete.
3500         (m68hc11_gdbarch_init): Don't register deleted functions with
3501         gdbarch.
3502
3503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * m32r-tdep.c (m32r_unwind_sp): Delete.
3506         (m32r_unwind_pc): Delete.
3507         (m32r_dummy_id): Delete.
3508         (m32r_gdbarch_init): Don't register deleted functions with
3509         gdbarch.
3510
3511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * m32c-tdep.c (m32c_unwind_pc): Delete.
3514         (m32c_unwind_sp): Delete.
3515         (m32c_dummy_id): Delete.
3516         (m32c_gdbarch_init): Don't register deleted functions with
3517         gdbarch.
3518
3519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3522         (lm32_unwind_pc): Delete.
3523         (lm32_dummy_id): Delete.
3524         (lm32_gdbarch_init): Don't register deleted functions with
3525         gdbarch.
3526
3527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3528
3529         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3530         (iq2000_unwind_pc): Delete.
3531         (iq2000_dummy_id): Delete.
3532         (iq2000_gdbarch_init): Don't register deleted functions with
3533         gdbarch.
3534
3535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3536
3537         * nds32-tdep.c (nds32_type_align): Delete.
3538         (nds32_push_dummy_call): Use type_align instead.
3539
3540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * arm-tdep.c (arm_type_align): Only handle vector override case.
3543         (arm_push_dummy_call): Use type_align.
3544         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3545
3546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3549         case.
3550         (pass_on_stack): Use type_align.
3551         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3552         function.
3553
3554 2019-04-23  Tom Tromey  <tromey@adacore.com>
3555
3556         * dwarf2read.c (line_header::file_name_at): Remove unused
3557         overload.
3558
3559 2019-04-23  Tom de Vries  <tdevries@suse.de>
3560
3561         PR gdb/24438
3562         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3563         invocation.
3564
3565
3566 2019-03-27  Ali Tamur  <tamur@google.com>
3567
3568         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3569         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3570         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3571         (dwarf_expr_context::get_addr_index): Likewise
3572         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3573         (symbol_needs_eval_context::get_addr_index): Likewise
3574         (disassemble_dwarf_expression): Add DW_OP_addrx
3575         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3576         (read_cutu_die_from_dwo): Update comment
3577         (skip_one_die): Add DW_FORM_addrx
3578         (read_attribute_value): Likewise
3579         (var_decode_location): Add DW_OP_addrx
3580         (dwarf2_const_value_attr): Add DW_FORM_addrx
3581         (dump_die_shallow): Likewise
3582         (dwarf2_fetch_constant_bytes): Likewise
3583         (decode_locdesc): Add DW_OP_addrx
3584         (skip_form_bytes): Add DW_FORM_addrx
3585
3586 2019-04-22  Ali Tamur  <tamur@google.com>
3587
3588         * MAINTAINERS (Write After Approval): Add self.
3589
3590 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3591
3592         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3593         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3594         (open_symbol_file_object): Likewise.
3595         (svr4_default_sos): Add info parameter.
3596         (svr4_read_so_list): Likewise.
3597         (svr4_current_sos_direct): Adjust functions calls to pass down
3598         info.
3599         (svr4_current_sos_1): Add info parameter.
3600         (svr4_current_sos): Call get_svr4_info, pass info down to
3601         svr4_current_sos_1.
3602         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3603         get_svr4_info.
3604         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3605         get_svr4_info.
3606         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3607         to get_svr4_info.
3608         (probes_table_remove_objfile_probes): Likewise.
3609         (register_solib_event_probe): Add info parameter.
3610         (solist_update_incremental): Pass info parameter down to
3611         svr4_read_so_list.
3612         (disable_probes_interface): Add info parameter.
3613         (svr4_handle_solib_event): Pass current_program_space to
3614         get_svr4_info.  Adjust disable_probes_interface cleanup.
3615         (svr4_create_probe_breakpoints): Add info parameter, pass it
3616         down to register_solib_event_probe.
3617         (svr4_create_solib_event_breakpoints): Add info parameter,
3618         pass it down to svr4_create_probe_breakpoints.
3619         (enable_break): Pass info down to
3620         svr4_create_solib_event_breakpoints.
3621         (svr4_solib_create_inferior_hook): Pass current_program_space to
3622         get_svr4_info.
3623         (svr4_clear_solib): Likewise.
3624
3625 2019-04-22  Pedro Alves  <palves@redhat.com>
3626
3627         * solib-svr4.c (svr4_free_objfile_observer): New.
3628         (probe_and_action::objfile): New field.
3629         (probes_table_htab_remove_objfile_probes)
3630         (probes_table_remove_objfile_probes): New functions.
3631         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3632         in the new probe_and_action.  Don't store the probe in 'lookup'.
3633         (svr4_create_probe_breakpoints): Pass objfile to
3634         register_solib_event_probe.
3635         (_initialize_svr4_solib): Register a free_objfile observer.
3636
3637 2019-04-19  Tom Tromey  <tom@tromey.com>
3638
3639         * common/queue.h: Remove.
3640
3641 2019-04-19  Tom Tromey  <tom@tromey.com>
3642
3643         * event-loop.c: Don't include "common/queue.h".
3644
3645 2019-04-19  Tom Tromey  <tom@tromey.com>
3646
3647         * remote.c (remote_target): Use delete.
3648         * remote-notif.h: Include <list>, not "common/queue.h".
3649         (notif_client_p): Remove typedef.
3650         (remote_notif_state): Add constructor, destructor, initializer.
3651         <notif_queue>: Now a std::list.
3652         (remote_notif_state_xfree): Don't declare.
3653         * remote-notif.c (remote_notif_process, handle_notification)
3654         (remote_notif_state_allocate): Update.
3655         (~remote_notif_state): Rename from remote_notif_state_xfree.
3656
3657 2019-04-19  Tom Tromey  <tom@tromey.com>
3658
3659         * symfile.c (reread_symbols): Update.
3660         * objfiles.c (objfile_register_static_link)
3661         (objfile_lookup_static_link): Update
3662         (~objfile) Don't delete static_links.
3663         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3664
3665 2019-04-19  Tom Tromey  <tom@tromey.com>
3666
3667         * type-stack.h (struct type_stack) <insert>: Constify string.
3668         * type-stack.c (type_stack::insert): Constify string.
3669         * gdbtypes.h (lookup_template_type): Update.
3670         (address_space_name_to_int): Update.
3671         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3672         const.
3673         (lookup_template_type): Make name const.
3674         * c-exp.y: Update rules.
3675         (lex_one_token, classify_name, classify_inner_name)
3676         (c_print_token): Update.
3677         * p-exp.y: Update rules.
3678         (yylex): Update.
3679         * f-exp.y: Update rules.
3680         (yylex): Update.
3681         * d-exp.y: Update rules.
3682         (lex_one_token, classify_name, classify_inner_name): Update.
3683         * parse.c (write_dollar_variable, copy_name): Return std::string.
3684         * parser-defs.h (copy_name): Change return type.
3685         * m2-exp.y: Update rules.
3686         (yylex): Update.
3687         * go-exp.y (lex_one_token): Update.
3688         Update rules.
3689         (classify_unsafe_function, classify_packaged_name)
3690         (classify_name, yylex): Update.
3691
3692 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3693
3694         * configure.ac: add --enable-source-highlight switch.
3695         * configure: Regenerate.
3696         * top.c (print_gdb_version): plumb --enable-source-highlight
3697         status to "show configuration".
3698
3699 2019-04-19  Tom Tromey  <tromey@adacore.com>
3700
3701         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3702         Check ADA_TYPE_P.
3703         (empty_record, ada_template_to_fixed_record_type_1)
3704         (template_to_static_fixed_type)
3705         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3706         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3707         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3708         macros.
3709
3710 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3711
3712         PR symtab/24423:
3713         * source.c (print_source_lines_base): Advance "iter" when a
3714         control character is seen.
3715
3716 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3717
3718         * inferior.h (struct infcall_suspend_state_deleter):
3719         Catch exception in destructor to avoid crash.
3720
3721 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3722
3723         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3724         close to the add_com "shell".
3725
3726 2019-04-18  Tom Tromey  <tromey@adacore.com>
3727
3728         * process-stratum-target.h (class process_stratum_target)
3729         <stratum>: Add "final".
3730
3731 2019-04-17  Tom Tromey  <tromey@adacore.com>
3732
3733         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3734         against nullptr before use.
3735
3736 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3737
3738         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3739
3740 2019-04-17  Jim Wilson  <jimw@sifive.com>
3741             Andrew Burgess  <andrew.burgess@embecosm.com>
3742
3743         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3744         code read might fail, assume 4-byte breakpoint in that case.
3745
3746 2019-04-15  Leszek Swirski  <leszeks@google.com>
3747
3748         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3749         rather than a hand-rolled POD check when checking for forced MEMORY
3750         classification.
3751
3752 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3753
3754         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3755         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3756         function.
3757         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3758         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3759         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3760         declaration.
3761
3762 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3763
3764         * aarch64-linux-nat.c
3765         (aarch64_linux_nat_target::thread_architecture): Add override.
3766         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3767         each VQ.
3768
3769 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3770
3771         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3772
3773 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3774
3775         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3776         target types of size 96-bits, add some additional comments, and
3777         check that the builtin type we found was the correct size.
3778
3779 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3780
3781         * utils.c (prompt_for_continue): Don't restore the styling at the
3782         end, as applied_style has the wrong value.  This fixes styling in
3783         long lists of file names that are interrupted by the "Continue?"
3784         prompt.
3785
3786 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3789         * c-lang.c (c_language_defn): Likewise.
3790         (cplus_language_defn): Likewise.
3791         (asm_language_defn): Likewise.
3792         (minimal_language_defn): Likewise.
3793         * d-lang.c (d_language_defn): Likewise.
3794         * f-lang.c (f_language_defn): Likewise.
3795         * go-lang.c (go_language_defn): Likewise.
3796         * language.c (unknown_language_defn): Likewise.
3797         (auto_language_defn): Likewise.
3798         * language.h (struct language_defn): Remove la_magic field.
3799         (LANG_MAGIC): Delete.
3800         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3801         * objc-lang.c (objc_language_defn): Likewise.
3802         * opencl-lang.c (opencl_language_defn): Likewise.
3803         * p-lang.c (pascal_language_defn): Likewise.
3804         * rust-lang.c (rust_language_defn): Likewise.
3805
3806 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * riscv-tdep.c (riscv_type_align): New function.
3809         (riscv_type_alignment): Delete.
3810         (riscv_arg_location): Use 'type_align'.
3811         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3812
3813 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * gdbtypes.c (type_align): A struct with no non-static fields also
3816         has alignment of 1.
3817
3818 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3821         component to 0.
3822         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3823         member.
3824         (riscv_struct_info::analyse): New implementation using new
3825         analyse_inner member function.
3826         (riscv_struct_info::field_offset): New member function.
3827         (riscv_struct_info::m_offsets): New member variable.
3828         (riscv_struct_info::analyse_inner): New private member function,
3829         takes the old implementation of riscv_struct_info::analyse but
3830         extended to track field offsets.
3831         (riscv_call_arg_struct): Update the struct folding special cases
3832         to handle cases where empty C++ structs, which are non-zero
3833         length, are found.
3834         (riscv_arg_location): Initialise the length of each location, a
3835         non-zero length now indicates the location is in use.
3836         (riscv_push_dummy_call): Allow for the first location having a
3837         non-zero offset when setting up arguments.
3838         (riscv_return_value): Likewise, but for return values.
3839
3840 2019-04-11  Tom Tromey  <tromey@adacore.com>
3841
3842         * utils.c (internal_vproblem): Make "msg" const.
3843
3844 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3845
3846         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3847         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3848         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3849         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3850
3851 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3852
3853         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3854         function.
3855         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3856         of amd64_collect_native_gregset.
3857         (amd64_linux_nat_target::store_registers): Likewise.
3858
3859 2019-04-10  Tom Tromey  <tom@tromey.com>
3860
3861         * symtab.c (lookup_global_symbol_from_objfile)
3862         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3863         * objfiles.h (class separate_debug_iterator): New.
3864         (class separate_debug_range): New.
3865         (struct objfile) <separate_debug_objfiles>: New method.
3866         (objfile_separate_debug_iterate): Don't declare.
3867         * objfiles.c (separate_debug_iterator::operator++): Rename from
3868         objfile_separate_debug_iterate.
3869         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3870         iterator.
3871         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3872         iterator.
3873
3874 2019-04-10  Tom Tromey  <tom@tromey.com>
3875
3876         * symfile.c (reread_symbols): Remove old comment.
3877         * objfiles.c (free_all_objfiles): Fix a typo.
3878
3879 2019-04-10  Tom Tromey  <tom@tromey.com>
3880
3881         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3882         * minsyms.c (lookup_minimal_symbol): Use foreach.
3883         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3884         (lookup_minimal_symbol_solib_trampoline): Likewise.
3885         * symfile.c (reread_symbols): Use foreach.
3886
3887 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3888             Tom Tromey  <tromey@adacore.com>
3889
3890         PR rust/24414:
3891         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3892         (rust_lex_int_test): Change "value" to be LONGEST.
3893         (rust_lex_tests): Add test for long integer literal.
3894
3895 2019-04-09  Tom Tromey  <tromey@adacore.com>
3896
3897         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3898         to bool.
3899         (extended_remote_target::attach): Update.
3900         (remote_target::remote_notice_new_inferior): Update.
3901         (remote_target::add_current_inferior_and_thread): Update.
3902         * inferior.c (exit_inferior_1): Use "false".
3903         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3904
3905 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3906
3907         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3908         the "start" command.
3909
3910 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3911
3912         * python/py-inferior.c (infpy_thread_from_thread_handle):
3913         Adjust comments to reflect renaming of thread_from_thread_handle
3914         to thread_from_handle.  Adjust keywords.  Fix type error message.
3915         (inferior_object_methods): Add thread_from_handle.  Retain
3916         thread_from_thread_handle, but mark it as deprecated.
3917
3918 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3919
3920         * gdbthread.h (find_thread_by_handle): Revise declaration.
3921         * thread.c (find_thread_by_handle): Likewise.  Adjust
3922         implementation too.
3923         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3924         support for buffer objects as handles.
3925
3926 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3927
3928         * python/py-infthread.c (thpy_thread_handle): New function.
3929         (thread_object_methods): Register thpy_thread_handle.
3930
3931 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3932
3933         * gdbthread.h (thread_to_thread_handle): Declare.
3934         * thread.c (gdbtypes.h): Include.
3935         (thread_to_thread_handle): New function.
3936
3937         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3938         (target_thread_info_to_thread_handle): Declare.
3939         * target.c (target_thread_info_to_thread_handle): New function.
3940         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3941         * target-delegates.c: Regenerate.
3942
3943         * linux-thread-db.c (class thread_db_target): Add method
3944         thread_info_to_thread_handle.
3945         (thread_db_target::thread_info_to_thread_handle): Define.
3946         * remote.c (class remote_target): Add new method
3947         thread_info_to_thread_handle.
3948         (remote_target::thread_info_to_thread_handle): Define.
3949
3950 2019-04-08  Pedro Alves  <palves@redhat.com>
3951
3952         * common/common-exceptions.c (throw_exception): Don't create
3953         named object to throw; throw directly.
3954         (throw_it): Likewise.  Don't initialize gdb_exception::message
3955         here, with new; pass FMT and AP to the ctor instead.
3956         * common/common-exceptions.h: Include <string>.
3957         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3958         const char *, va_list)): New ctor.  Use std::make_shared.
3959         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3960         errors)): Delete.
3961         (gdb_exception_error::gdb_exception_error(enum errors, const char
3962         *, va_list)): New.
3963         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3964         Add assertion.
3965         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3966         errors)): Delete.
3967         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3968         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3969         Add assertion.
3970
3971 2019-04-08  Tom Tromey  <tom@tromey.com>
3972
3973         * valops.c (value_rtti_indirect_type): Replace throw_exception
3974         with throw.
3975         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3976         with throw.
3977         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3978         throw.
3979         * target.c (target_translate_tls_address): Replace throw_exception
3980         with throw.
3981         * stack.c (frame_apply_command_count): Replace throw_exception
3982         with throw.
3983         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3984         throw.
3985         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3986         with throw.
3987         * rs6000-tdep.c (rs6000_frame_cache)
3988         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3989         * remote.c: Replace throw_exception with throw.
3990         * record-full.c (record_full_message, record_full_wait_1)
3991         (record_full_restore): Replace throw_exception with throw.
3992         * record-btrace.c:
3993         (get_thread_current_frame_id, record_btrace_start_replaying)
3994         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3995         (cmd_record_btrace_start): Replace throw_exception with throw.
3996         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3997         throw.
3998         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3999         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4000         * linespec.c:
4001         (find_linespec_symbols): Replace throw_exception with throw.
4002         * infrun.c (displaced_step_prepare, resume): Replace
4003         throw_exception with throw.
4004         * infcmd.c (post_create_inferior): Replace throw_exception with
4005         throw.
4006         * inf-loop.c (inferior_event_handler): Replace throw_exception
4007         with throw.
4008         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4009         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4010         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4011         (get_prev_frame_always, get_frame_pc_if_available)
4012         (get_frame_address_in_block_if_available, get_frame_language):
4013         Replace throw_exception with throw.
4014         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4015         throw_exception with throw.
4016         * eval.c (fetch_subexp_value, evaluate_var_value)
4017         (evaluate_funcall, evaluate_subexp_standard): Replace
4018         throw_exception with throw.
4019         * dwarf2loc.c (call_site_find_chain)
4020         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4021         Replace throw_exception with throw.
4022         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4023         with throw.
4024         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4025         throw.
4026         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4027         * completer.c (complete_line_internal): Replace throw_exception
4028         with throw.
4029         * compile/compile-object-run.c (compile_object_run): Replace
4030         throw_exception with throw.
4031         * cli/cli-script.c (process_next_line): Replace throw_exception
4032         with throw.
4033         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4034         (btrace_enable, btrace_maint_update_pt_packets): Replace
4035         throw_exception with throw.
4036         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4037         throw_exception with throw.
4038         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4039         throw_exception with throw.
4040         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4041         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4042         * aarch64-tdep.c (aarch64_make_prologue_cache)
4043         (aarch64_make_stub_cache): Replace throw_exception with throw.
4044
4045 2019-04-08  Tom Tromey  <tom@tromey.com>
4046
4047         * common/common-exceptions.c (throw_exception): Rename from
4048         throw_exception_cxx.  Remove old copy.  Make argument const.
4049         (throw_it): Create and throw exception objects directly.
4050         * common/common-exceptions.h (throw_exception): Make argument
4051         const.
4052         (struct gdb_exception_error): Add constructor.
4053         (struct gdb_exception_quit): Add constructor.
4054
4055 2019-04-08  Tom Tromey  <tom@tromey.com>
4056
4057         * common/common-exceptions.h (exception_rethrow): Don't declare.
4058         (TRY_SJLJ): Update comment.
4059         (TRY, CATCH, END_CATCH): Remove.
4060         * common/common-exceptions.c (exception_rethrow): Remove.
4061
4062 2019-04-08  Tom Tromey  <tom@tromey.com>
4063
4064         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4065         Remove.
4066         (gdb_exception_error): Rename from
4067         gdb_exception_RETURN_MASK_ERROR.
4068         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4069         (gdb_quit_bad_alloc): Update.
4070         * aarch64-tdep.c: Update.
4071         * ada-lang.c: Update.
4072         * ada-typeprint.c: Update.
4073         * ada-valprint.c: Update.
4074         * amd64-tdep.c: Update.
4075         * arch-utils.c: Update.
4076         * break-catch-throw.c: Update.
4077         * breakpoint.c: Update.
4078         * btrace.c: Update.
4079         * c-varobj.c: Update.
4080         * cli/cli-cmds.c: Update.
4081         * cli/cli-interp.c: Update.
4082         * cli/cli-script.c: Update.
4083         * common/common-exceptions.c: Update.
4084         * common/new-op.c: Update.
4085         * common/selftest.c: Update.
4086         * compile/compile-c-symbols.c: Update.
4087         * compile/compile-cplus-symbols.c: Update.
4088         * compile/compile-object-load.c: Update.
4089         * compile/compile-object-run.c: Update.
4090         * completer.c: Update.
4091         * corelow.c: Update.
4092         * cp-abi.c: Update.
4093         * cp-support.c: Update.
4094         * cp-valprint.c: Update.
4095         * darwin-nat.c: Update.
4096         * disasm-selftests.c: Update.
4097         * dtrace-probe.c: Update.
4098         * dwarf-index-cache.c: Update.
4099         * dwarf-index-write.c: Update.
4100         * dwarf2-frame-tailcall.c: Update.
4101         * dwarf2-frame.c: Update.
4102         * dwarf2loc.c: Update.
4103         * dwarf2read.c: Update.
4104         * eval.c: Update.
4105         * event-loop.c: Update.
4106         * event-top.c: Update.
4107         * exec.c: Update.
4108         * f-valprint.c: Update.
4109         * fbsd-tdep.c: Update.
4110         * frame-unwind.c: Update.
4111         * frame.c: Update.
4112         * gdbtypes.c: Update.
4113         * gnu-v3-abi.c: Update.
4114         * guile/guile-internal.h: Update.
4115         * guile/scm-block.c: Update.
4116         * guile/scm-breakpoint.c: Update.
4117         * guile/scm-cmd.c: Update.
4118         * guile/scm-disasm.c: Update.
4119         * guile/scm-frame.c: Update.
4120         * guile/scm-lazy-string.c: Update.
4121         * guile/scm-math.c: Update.
4122         * guile/scm-param.c: Update.
4123         * guile/scm-ports.c: Update.
4124         * guile/scm-pretty-print.c: Update.
4125         * guile/scm-symbol.c: Update.
4126         * guile/scm-symtab.c: Update.
4127         * guile/scm-type.c: Update.
4128         * guile/scm-value.c: Update.
4129         * i386-linux-tdep.c: Update.
4130         * i386-tdep.c: Update.
4131         * inf-loop.c: Update.
4132         * infcall.c: Update.
4133         * infcmd.c: Update.
4134         * infrun.c: Update.
4135         * jit.c: Update.
4136         * language.c: Update.
4137         * linespec.c: Update.
4138         * linux-fork.c: Update.
4139         * linux-nat.c: Update.
4140         * linux-tdep.c: Update.
4141         * linux-thread-db.c: Update.
4142         * main.c: Update.
4143         * mi/mi-cmd-break.c: Update.
4144         * mi/mi-cmd-stack.c: Update.
4145         * mi/mi-interp.c: Update.
4146         * mi/mi-main.c: Update.
4147         * objc-lang.c: Update.
4148         * p-valprint.c: Update.
4149         * parse.c: Update.
4150         * ppc-linux-tdep.c: Update.
4151         * printcmd.c: Update.
4152         * python/py-arch.c: Update.
4153         * python/py-breakpoint.c: Update.
4154         * python/py-cmd.c: Update.
4155         * python/py-finishbreakpoint.c: Update.
4156         * python/py-frame.c: Update.
4157         * python/py-framefilter.c: Update.
4158         * python/py-gdb-readline.c: Update.
4159         * python/py-inferior.c: Update.
4160         * python/py-infthread.c: Update.
4161         * python/py-lazy-string.c: Update.
4162         * python/py-linetable.c: Update.
4163         * python/py-objfile.c: Update.
4164         * python/py-param.c: Update.
4165         * python/py-prettyprint.c: Update.
4166         * python/py-progspace.c: Update.
4167         * python/py-record-btrace.c: Update.
4168         * python/py-record.c: Update.
4169         * python/py-symbol.c: Update.
4170         * python/py-type.c: Update.
4171         * python/py-unwind.c: Update.
4172         * python/py-utils.c: Update.
4173         * python/py-value.c: Update.
4174         * python/python.c: Update.
4175         * record-btrace.c: Update.
4176         * record-full.c: Update.
4177         * remote-fileio.c: Update.
4178         * remote.c: Update.
4179         * riscv-tdep.c: Update.
4180         * rs6000-aix-tdep.c: Update.
4181         * rs6000-tdep.c: Update.
4182         * rust-exp.y: Update.
4183         * rust-lang.c: Update.
4184         * s390-tdep.c: Update.
4185         * selftest-arch.c: Update.
4186         * solib-dsbt.c: Update.
4187         * solib-frv.c: Update.
4188         * solib-spu.c: Update.
4189         * solib-svr4.c: Update.
4190         * solib.c: Update.
4191         * sparc64-linux-tdep.c: Update.
4192         * stack.c: Update.
4193         * symfile-mem.c: Update.
4194         * symmisc.c: Update.
4195         * target.c: Update.
4196         * thread.c: Update.
4197         * top.c: Update.
4198         * tracefile-tfile.c: Update.
4199         * tui/tui.c: Update.
4200         * typeprint.c: Update.
4201         * unittests/cli-utils-selftests.c: Update.
4202         * unittests/parse-connection-spec-selftests.c: Update.
4203         * valops.c: Update.
4204         * valprint.c: Update.
4205         * value.c: Update.
4206         * varobj.c: Update.
4207         * windows-nat.c: Update.
4208         * x86-linux-nat.c: Update.
4209         * xml-support.c: Update.
4210
4211 2019-04-08  Tom Tromey  <tom@tromey.com>
4212
4213         * xml-support.c: Use C++ exception handling.
4214         * x86-linux-nat.c: Use C++ exception handling.
4215         * windows-nat.c: Use C++ exception handling.
4216         * varobj.c: Use C++ exception handling.
4217         * value.c: Use C++ exception handling.
4218         * valprint.c: Use C++ exception handling.
4219         * valops.c: Use C++ exception handling.
4220         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4221         handling.
4222         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4223         * typeprint.c: Use C++ exception handling.
4224         * tui/tui.c: Use C++ exception handling.
4225         * tracefile-tfile.c: Use C++ exception handling.
4226         * top.c: Use C++ exception handling.
4227         * thread.c: Use C++ exception handling.
4228         * target.c: Use C++ exception handling.
4229         * symmisc.c: Use C++ exception handling.
4230         * symfile-mem.c: Use C++ exception handling.
4231         * stack.c: Use C++ exception handling.
4232         * sparc64-linux-tdep.c: Use C++ exception handling.
4233         * solib.c: Use C++ exception handling.
4234         * solib-svr4.c: Use C++ exception handling.
4235         * solib-spu.c: Use C++ exception handling.
4236         * solib-frv.c: Use C++ exception handling.
4237         * solib-dsbt.c: Use C++ exception handling.
4238         * selftest-arch.c: Use C++ exception handling.
4239         * s390-tdep.c: Use C++ exception handling.
4240         * rust-lang.c: Use C++ exception handling.
4241         * rust-exp.y: Use C++ exception handling.
4242         * rs6000-tdep.c: Use C++ exception handling.
4243         * rs6000-aix-tdep.c: Use C++ exception handling.
4244         * riscv-tdep.c: Use C++ exception handling.
4245         * remote.c: Use C++ exception handling.
4246         * remote-fileio.c: Use C++ exception handling.
4247         * record-full.c: Use C++ exception handling.
4248         * record-btrace.c: Use C++ exception handling.
4249         * python/python.c: Use C++ exception handling.
4250         * python/py-value.c: Use C++ exception handling.
4251         * python/py-utils.c: Use C++ exception handling.
4252         * python/py-unwind.c: Use C++ exception handling.
4253         * python/py-type.c: Use C++ exception handling.
4254         * python/py-symbol.c: Use C++ exception handling.
4255         * python/py-record.c: Use C++ exception handling.
4256         * python/py-record-btrace.c: Use C++ exception handling.
4257         * python/py-progspace.c: Use C++ exception handling.
4258         * python/py-prettyprint.c: Use C++ exception handling.
4259         * python/py-param.c: Use C++ exception handling.
4260         * python/py-objfile.c: Use C++ exception handling.
4261         * python/py-linetable.c: Use C++ exception handling.
4262         * python/py-lazy-string.c: Use C++ exception handling.
4263         * python/py-infthread.c: Use C++ exception handling.
4264         * python/py-inferior.c: Use C++ exception handling.
4265         * python/py-gdb-readline.c: Use C++ exception handling.
4266         * python/py-framefilter.c: Use C++ exception handling.
4267         * python/py-frame.c: Use C++ exception handling.
4268         * python/py-finishbreakpoint.c: Use C++ exception handling.
4269         * python/py-cmd.c: Use C++ exception handling.
4270         * python/py-breakpoint.c: Use C++ exception handling.
4271         * python/py-arch.c: Use C++ exception handling.
4272         * printcmd.c: Use C++ exception handling.
4273         * ppc-linux-tdep.c: Use C++ exception handling.
4274         * parse.c: Use C++ exception handling.
4275         * p-valprint.c: Use C++ exception handling.
4276         * objc-lang.c: Use C++ exception handling.
4277         * mi/mi-main.c: Use C++ exception handling.
4278         * mi/mi-interp.c: Use C++ exception handling.
4279         * mi/mi-cmd-stack.c: Use C++ exception handling.
4280         * mi/mi-cmd-break.c: Use C++ exception handling.
4281         * main.c: Use C++ exception handling.
4282         * linux-thread-db.c: Use C++ exception handling.
4283         * linux-tdep.c: Use C++ exception handling.
4284         * linux-nat.c: Use C++ exception handling.
4285         * linux-fork.c: Use C++ exception handling.
4286         * linespec.c: Use C++ exception handling.
4287         * language.c: Use C++ exception handling.
4288         * jit.c: Use C++ exception handling.
4289         * infrun.c: Use C++ exception handling.
4290         * infcmd.c: Use C++ exception handling.
4291         * infcall.c: Use C++ exception handling.
4292         * inf-loop.c: Use C++ exception handling.
4293         * i386-tdep.c: Use C++ exception handling.
4294         * i386-linux-tdep.c: Use C++ exception handling.
4295         * guile/scm-value.c: Use C++ exception handling.
4296         * guile/scm-type.c: Use C++ exception handling.
4297         * guile/scm-symtab.c: Use C++ exception handling.
4298         * guile/scm-symbol.c: Use C++ exception handling.
4299         * guile/scm-pretty-print.c: Use C++ exception handling.
4300         * guile/scm-ports.c: Use C++ exception handling.
4301         * guile/scm-param.c: Use C++ exception handling.
4302         * guile/scm-math.c: Use C++ exception handling.
4303         * guile/scm-lazy-string.c: Use C++ exception handling.
4304         * guile/scm-frame.c: Use C++ exception handling.
4305         * guile/scm-disasm.c: Use C++ exception handling.
4306         * guile/scm-cmd.c: Use C++ exception handling.
4307         * guile/scm-breakpoint.c: Use C++ exception handling.
4308         * guile/scm-block.c: Use C++ exception handling.
4309         * guile/guile-internal.h: Use C++ exception handling.
4310         * gnu-v3-abi.c: Use C++ exception handling.
4311         * gdbtypes.c: Use C++ exception handling.
4312         * frame.c: Use C++ exception handling.
4313         * frame-unwind.c: Use C++ exception handling.
4314         * fbsd-tdep.c: Use C++ exception handling.
4315         * f-valprint.c: Use C++ exception handling.
4316         * exec.c: Use C++ exception handling.
4317         * event-top.c: Use C++ exception handling.
4318         * event-loop.c: Use C++ exception handling.
4319         * eval.c: Use C++ exception handling.
4320         * dwarf2read.c: Use C++ exception handling.
4321         * dwarf2loc.c: Use C++ exception handling.
4322         * dwarf2-frame.c: Use C++ exception handling.
4323         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4324         * dwarf-index-write.c: Use C++ exception handling.
4325         * dwarf-index-cache.c: Use C++ exception handling.
4326         * dtrace-probe.c: Use C++ exception handling.
4327         * disasm-selftests.c: Use C++ exception handling.
4328         * darwin-nat.c: Use C++ exception handling.
4329         * cp-valprint.c: Use C++ exception handling.
4330         * cp-support.c: Use C++ exception handling.
4331         * cp-abi.c: Use C++ exception handling.
4332         * corelow.c: Use C++ exception handling.
4333         * completer.c: Use C++ exception handling.
4334         * compile/compile-object-run.c: Use C++ exception handling.
4335         * compile/compile-object-load.c: Use C++ exception handling.
4336         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4337         * compile/compile-c-symbols.c: Use C++ exception handling.
4338         * common/selftest.c: Use C++ exception handling.
4339         * common/new-op.c: Use C++ exception handling.
4340         * cli/cli-script.c: Use C++ exception handling.
4341         * cli/cli-interp.c: Use C++ exception handling.
4342         * cli/cli-cmds.c: Use C++ exception handling.
4343         * c-varobj.c: Use C++ exception handling.
4344         * btrace.c: Use C++ exception handling.
4345         * breakpoint.c: Use C++ exception handling.
4346         * break-catch-throw.c: Use C++ exception handling.
4347         * arch-utils.c: Use C++ exception handling.
4348         * amd64-tdep.c: Use C++ exception handling.
4349         * ada-valprint.c: Use C++ exception handling.
4350         * ada-typeprint.c: Use C++ exception handling.
4351         * ada-lang.c: Use C++ exception handling.
4352         * aarch64-tdep.c: Use C++ exception handling.
4353
4354 2019-04-08  Tom Tromey  <tom@tromey.com>
4355
4356         * xml-support.c (gdb_xml_parser::parse): Update.
4357         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4358         * value.c (show_convenience): Update.
4359         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4360         (test_parse_flags_qcs): Update.
4361         * thread.c (thr_try_catch_cmd): Update.
4362         * target.c (target_translate_tls_address): Update.
4363         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4364         (info_frame_command_core, frame_apply_command_count): Update.
4365         * rust-exp.y (rust_lex_exception_test): Update.
4366         * riscv-tdep.c (riscv_print_one_register_info): Update.
4367         * remote.c (remote_target::enable_btrace): Update.
4368         * record-btrace.c (record_btrace_enable_warn): Update.
4369         * python/py-utils.c (gdbpy_convert_exception): Update.
4370         * printcmd.c (do_one_display, print_variable_and_value): Update.
4371         * mi/mi-main.c (mi_print_exception): Update.
4372         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4373         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4374         * linux-nat.c (linux_nat_target::attach): Update.
4375         * linux-fork.c (class scoped_switch_fork_info): Update.
4376         * infrun.c (displaced_step_prepare): Update.
4377         * infcall.c (call_function_by_hand_dummy): Update.
4378         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4379         * gnu-v3-abi.c (print_one_vtable): Update.
4380         * frame.c (get_prev_frame_always): Update.
4381         * f-valprint.c (info_common_command_for_block): Update.
4382         * exec.c (try_open_exec_file): Update.
4383         * exceptions.c (print_exception, exception_print)
4384         (exception_fprintf, exception_print_same): Update.
4385         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4386         * dwarf-index-cache.c (index_cache::store)
4387         (index_cache::lookup_gdb_index): Update.
4388         * darwin-nat.c (maybe_cache_shell): Update.
4389         * cp-valprint.c (cp_print_value_fields): Update.
4390         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4391         (gcc_cplus_symbol_address): Update.
4392         * compile/compile-c-symbols.c (gcc_convert_symbol)
4393         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4394         * common/selftest.c: Update.
4395         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4396         a std::string.
4397         (exception_try_scope_entry, exception_try_scope_exit): Don't
4398         declare.
4399         (struct exception_try_scope): Remove.
4400         (TRY): Don't use exception_try_scope.
4401         (struct gdb_exception): Add constructor, operator=.
4402         <what>: New method.
4403         (struct gdb_exception_RETURN_MASK_ALL)
4404         (struct gdb_exception_RETURN_MASK_ERROR)
4405         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4406         (struct gdb_quit_bad_alloc): Update.
4407         * common/common-exceptions.c (exception_none): Change
4408         initializer.
4409         (struct catcher) <state, exception>: Initialize inline.
4410         <prev>: Remove member.
4411         (current_catcher): Remove.
4412         (catchers): New global.
4413         (exceptions_state_mc_init): Simplify.
4414         (catcher_pop): Remove.
4415         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4416         (try_scope_depth, exception_try_scope_entry)
4417         (exception_try_scope_exit): Remove.
4418         (throw_exception_sjlj): Update.
4419         (exception_messages, exception_messages_size): Remove.
4420         (throw_it): Simplify.
4421         (gdb_exception_sliced_copy): Remove.
4422         (throw_exception_cxx): Update.
4423         * cli/cli-script.c (script_from_file): Update.
4424         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4425         Update.
4426         * ada-valprint.c (ada_val_print): Update.
4427         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4428         (create_excep_cond_exprs): Update.
4429
4430 2019-04-08  Tom Tromey  <tom@tromey.com>
4431
4432         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4433         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4434         (TRY, CATCH, END_CATCH): Remove some definitions.
4435         * common/common-exceptions.c: Don't use GDB_XCPT.
4436         (catcher_list_size): Remove.
4437         (throw_exception, throw_it): Simplify.
4438
4439 2019-04-05  Tom Tromey  <tom@tromey.com>
4440
4441         Revert the header-sorting patch.
4442         * ft32-tdep.c: Revert.
4443         * frv-tdep.c: Revert.
4444         * frv-linux-tdep.c: Revert.
4445         * frame.c: Revert.
4446         * frame-unwind.c: Revert.
4447         * frame-base.c: Revert.
4448         * fork-child.c: Revert.
4449         * findvar.c: Revert.
4450         * findcmd.c: Revert.
4451         * filesystem.c: Revert.
4452         * filename-seen-cache.h: Revert.
4453         * filename-seen-cache.c: Revert.
4454         * fbsd-tdep.c: Revert.
4455         * fbsd-nat.h: Revert.
4456         * fbsd-nat.c: Revert.
4457         * f-valprint.c: Revert.
4458         * f-typeprint.c: Revert.
4459         * f-lang.c: Revert.
4460         * extension.h: Revert.
4461         * extension.c: Revert.
4462         * extension-priv.h: Revert.
4463         * expprint.c: Revert.
4464         * exec.h: Revert.
4465         * exec.c: Revert.
4466         * exceptions.c: Revert.
4467         * event-top.c: Revert.
4468         * event-loop.c: Revert.
4469         * eval.c: Revert.
4470         * elfread.c: Revert.
4471         * dwarf2read.h: Revert.
4472         * dwarf2read.c: Revert.
4473         * dwarf2loc.c: Revert.
4474         * dwarf2expr.h: Revert.
4475         * dwarf2expr.c: Revert.
4476         * dwarf2-frame.c: Revert.
4477         * dwarf2-frame-tailcall.c: Revert.
4478         * dwarf-index-write.h: Revert.
4479         * dwarf-index-write.c: Revert.
4480         * dwarf-index-common.c: Revert.
4481         * dwarf-index-cache.h: Revert.
4482         * dwarf-index-cache.c: Revert.
4483         * dummy-frame.c: Revert.
4484         * dtrace-probe.c: Revert.
4485         * disasm.h: Revert.
4486         * disasm.c: Revert.
4487         * disasm-selftests.c: Revert.
4488         * dictionary.c: Revert.
4489         * dicos-tdep.c: Revert.
4490         * demangle.c: Revert.
4491         * dcache.h: Revert.
4492         * dcache.c: Revert.
4493         * darwin-nat.h: Revert.
4494         * darwin-nat.c: Revert.
4495         * darwin-nat-info.c: Revert.
4496         * d-valprint.c: Revert.
4497         * d-namespace.c: Revert.
4498         * d-lang.c: Revert.
4499         * ctf.c: Revert.
4500         * csky-tdep.c: Revert.
4501         * csky-linux-tdep.c: Revert.
4502         * cris-tdep.c: Revert.
4503         * cris-linux-tdep.c: Revert.
4504         * cp-valprint.c: Revert.
4505         * cp-support.c: Revert.
4506         * cp-namespace.c: Revert.
4507         * cp-abi.c: Revert.
4508         * corelow.c: Revert.
4509         * corefile.c: Revert.
4510         * continuations.c: Revert.
4511         * completer.h: Revert.
4512         * completer.c: Revert.
4513         * complaints.c: Revert.
4514         * coffread.c: Revert.
4515         * coff-pe-read.c: Revert.
4516         * cli-out.h: Revert.
4517         * cli-out.c: Revert.
4518         * charset.c: Revert.
4519         * c-varobj.c: Revert.
4520         * c-valprint.c: Revert.
4521         * c-typeprint.c: Revert.
4522         * c-lang.c: Revert.
4523         * buildsym.c: Revert.
4524         * buildsym-legacy.c: Revert.
4525         * build-id.h: Revert.
4526         * build-id.c: Revert.
4527         * btrace.c: Revert.
4528         * bsd-uthread.c: Revert.
4529         * breakpoint.h: Revert.
4530         * breakpoint.c: Revert.
4531         * break-catch-throw.c: Revert.
4532         * break-catch-syscall.c: Revert.
4533         * break-catch-sig.c: Revert.
4534         * blockframe.c: Revert.
4535         * block.c: Revert.
4536         * bfin-tdep.c: Revert.
4537         * bfin-linux-tdep.c: Revert.
4538         * bfd-target.c: Revert.
4539         * bcache.c: Revert.
4540         * ax-general.c: Revert.
4541         * ax-gdb.h: Revert.
4542         * ax-gdb.c: Revert.
4543         * avr-tdep.c: Revert.
4544         * auxv.c: Revert.
4545         * auto-load.c: Revert.
4546         * arm-wince-tdep.c: Revert.
4547         * arm-tdep.c: Revert.
4548         * arm-symbian-tdep.c: Revert.
4549         * arm-pikeos-tdep.c: Revert.
4550         * arm-obsd-tdep.c: Revert.
4551         * arm-nbsd-tdep.c: Revert.
4552         * arm-nbsd-nat.c: Revert.
4553         * arm-linux-tdep.c: Revert.
4554         * arm-linux-nat.c: Revert.
4555         * arm-fbsd-tdep.c: Revert.
4556         * arm-fbsd-nat.c: Revert.
4557         * arm-bsd-tdep.c: Revert.
4558         * arch-utils.c: Revert.
4559         * arc-tdep.c: Revert.
4560         * arc-newlib-tdep.c: Revert.
4561         * annotate.h: Revert.
4562         * annotate.c: Revert.
4563         * amd64-windows-tdep.c: Revert.
4564         * amd64-windows-nat.c: Revert.
4565         * amd64-tdep.c: Revert.
4566         * amd64-sol2-tdep.c: Revert.
4567         * amd64-obsd-tdep.c: Revert.
4568         * amd64-obsd-nat.c: Revert.
4569         * amd64-nbsd-tdep.c: Revert.
4570         * amd64-nbsd-nat.c: Revert.
4571         * amd64-nat.c: Revert.
4572         * amd64-linux-tdep.c: Revert.
4573         * amd64-linux-nat.c: Revert.
4574         * amd64-fbsd-tdep.c: Revert.
4575         * amd64-fbsd-nat.c: Revert.
4576         * amd64-dicos-tdep.c: Revert.
4577         * amd64-darwin-tdep.c: Revert.
4578         * amd64-bsd-nat.c: Revert.
4579         * alpha-tdep.c: Revert.
4580         * alpha-obsd-tdep.c: Revert.
4581         * alpha-nbsd-tdep.c: Revert.
4582         * alpha-mdebug-tdep.c: Revert.
4583         * alpha-linux-tdep.c: Revert.
4584         * alpha-linux-nat.c: Revert.
4585         * alpha-bsd-tdep.c: Revert.
4586         * alpha-bsd-nat.c: Revert.
4587         * aix-thread.c: Revert.
4588         * agent.c: Revert.
4589         * addrmap.c: Revert.
4590         * ada-varobj.c: Revert.
4591         * ada-valprint.c: Revert.
4592         * ada-typeprint.c: Revert.
4593         * ada-tasks.c: Revert.
4594         * ada-lang.c: Revert.
4595         * aarch64-tdep.c: Revert.
4596         * aarch64-ravenscar-thread.c: Revert.
4597         * aarch64-newlib-tdep.c: Revert.
4598         * aarch64-linux-tdep.c: Revert.
4599         * aarch64-linux-nat.c: Revert.
4600         * aarch64-fbsd-tdep.c: Revert.
4601         * aarch64-fbsd-nat.c: Revert.
4602         * aarch32-linux-nat.c: Revert.
4603
4604 2019-04-05  Tom Tromey  <tom@tromey.com>
4605
4606         * ft32-tdep.c: Sort headers.
4607         * frv-tdep.c: Sort headers.
4608         * frv-linux-tdep.c: Sort headers.
4609         * frame.c: Sort headers.
4610         * frame-unwind.c: Sort headers.
4611         * frame-base.c: Sort headers.
4612         * fork-child.c: Sort headers.
4613         * findvar.c: Sort headers.
4614         * findcmd.c: Sort headers.
4615         * filesystem.c: Sort headers.
4616         * filename-seen-cache.h: Sort headers.
4617         * filename-seen-cache.c: Sort headers.
4618         * fbsd-tdep.c: Sort headers.
4619         * fbsd-nat.h: Sort headers.
4620         * fbsd-nat.c: Sort headers.
4621         * f-valprint.c: Sort headers.
4622         * f-typeprint.c: Sort headers.
4623         * f-lang.c: Sort headers.
4624         * extension.h: Sort headers.
4625         * extension.c: Sort headers.
4626         * extension-priv.h: Sort headers.
4627         * expprint.c: Sort headers.
4628         * exec.h: Sort headers.
4629         * exec.c: Sort headers.
4630         * exceptions.c: Sort headers.
4631         * event-top.c: Sort headers.
4632         * event-loop.c: Sort headers.
4633         * eval.c: Sort headers.
4634         * elfread.c: Sort headers.
4635         * dwarf2read.h: Sort headers.
4636         * dwarf2read.c: Sort headers.
4637         * dwarf2loc.c: Sort headers.
4638         * dwarf2expr.h: Sort headers.
4639         * dwarf2expr.c: Sort headers.
4640         * dwarf2-frame.c: Sort headers.
4641         * dwarf2-frame-tailcall.c: Sort headers.
4642         * dwarf-index-write.h: Sort headers.
4643         * dwarf-index-write.c: Sort headers.
4644         * dwarf-index-common.c: Sort headers.
4645         * dwarf-index-cache.h: Sort headers.
4646         * dwarf-index-cache.c: Sort headers.
4647         * dummy-frame.c: Sort headers.
4648         * dtrace-probe.c: Sort headers.
4649         * disasm.h: Sort headers.
4650         * disasm.c: Sort headers.
4651         * disasm-selftests.c: Sort headers.
4652         * dictionary.c: Sort headers.
4653         * dicos-tdep.c: Sort headers.
4654         * demangle.c: Sort headers.
4655         * dcache.h: Sort headers.
4656         * dcache.c: Sort headers.
4657         * darwin-nat.h: Sort headers.
4658         * darwin-nat.c: Sort headers.
4659         * darwin-nat-info.c: Sort headers.
4660         * d-valprint.c: Sort headers.
4661         * d-namespace.c: Sort headers.
4662         * d-lang.c: Sort headers.
4663         * ctf.c: Sort headers.
4664         * csky-tdep.c: Sort headers.
4665         * csky-linux-tdep.c: Sort headers.
4666         * cris-tdep.c: Sort headers.
4667         * cris-linux-tdep.c: Sort headers.
4668         * cp-valprint.c: Sort headers.
4669         * cp-support.c: Sort headers.
4670         * cp-namespace.c: Sort headers.
4671         * cp-abi.c: Sort headers.
4672         * corelow.c: Sort headers.
4673         * corefile.c: Sort headers.
4674         * continuations.c: Sort headers.
4675         * completer.h: Sort headers.
4676         * completer.c: Sort headers.
4677         * complaints.c: Sort headers.
4678         * coffread.c: Sort headers.
4679         * coff-pe-read.c: Sort headers.
4680         * cli-out.h: Sort headers.
4681         * cli-out.c: Sort headers.
4682         * charset.c: Sort headers.
4683         * c-varobj.c: Sort headers.
4684         * c-valprint.c: Sort headers.
4685         * c-typeprint.c: Sort headers.
4686         * c-lang.c: Sort headers.
4687         * buildsym.c: Sort headers.
4688         * buildsym-legacy.c: Sort headers.
4689         * build-id.h: Sort headers.
4690         * build-id.c: Sort headers.
4691         * btrace.c: Sort headers.
4692         * bsd-uthread.c: Sort headers.
4693         * breakpoint.h: Sort headers.
4694         * breakpoint.c: Sort headers.
4695         * break-catch-throw.c: Sort headers.
4696         * break-catch-syscall.c: Sort headers.
4697         * break-catch-sig.c: Sort headers.
4698         * blockframe.c: Sort headers.
4699         * block.c: Sort headers.
4700         * bfin-tdep.c: Sort headers.
4701         * bfin-linux-tdep.c: Sort headers.
4702         * bfd-target.c: Sort headers.
4703         * bcache.c: Sort headers.
4704         * ax-general.c: Sort headers.
4705         * ax-gdb.h: Sort headers.
4706         * ax-gdb.c: Sort headers.
4707         * avr-tdep.c: Sort headers.
4708         * auxv.c: Sort headers.
4709         * auto-load.c: Sort headers.
4710         * arm-wince-tdep.c: Sort headers.
4711         * arm-tdep.c: Sort headers.
4712         * arm-symbian-tdep.c: Sort headers.
4713         * arm-pikeos-tdep.c: Sort headers.
4714         * arm-obsd-tdep.c: Sort headers.
4715         * arm-nbsd-tdep.c: Sort headers.
4716         * arm-nbsd-nat.c: Sort headers.
4717         * arm-linux-tdep.c: Sort headers.
4718         * arm-linux-nat.c: Sort headers.
4719         * arm-fbsd-tdep.c: Sort headers.
4720         * arm-fbsd-nat.c: Sort headers.
4721         * arm-bsd-tdep.c: Sort headers.
4722         * arch-utils.c: Sort headers.
4723         * arc-tdep.c: Sort headers.
4724         * arc-newlib-tdep.c: Sort headers.
4725         * annotate.h: Sort headers.
4726         * annotate.c: Sort headers.
4727         * amd64-windows-tdep.c: Sort headers.
4728         * amd64-windows-nat.c: Sort headers.
4729         * amd64-tdep.c: Sort headers.
4730         * amd64-sol2-tdep.c: Sort headers.
4731         * amd64-obsd-tdep.c: Sort headers.
4732         * amd64-obsd-nat.c: Sort headers.
4733         * amd64-nbsd-tdep.c: Sort headers.
4734         * amd64-nbsd-nat.c: Sort headers.
4735         * amd64-nat.c: Sort headers.
4736         * amd64-linux-tdep.c: Sort headers.
4737         * amd64-linux-nat.c: Sort headers.
4738         * amd64-fbsd-tdep.c: Sort headers.
4739         * amd64-fbsd-nat.c: Sort headers.
4740         * amd64-dicos-tdep.c: Sort headers.
4741         * amd64-darwin-tdep.c: Sort headers.
4742         * amd64-bsd-nat.c: Sort headers.
4743         * alpha-tdep.c: Sort headers.
4744         * alpha-obsd-tdep.c: Sort headers.
4745         * alpha-nbsd-tdep.c: Sort headers.
4746         * alpha-mdebug-tdep.c: Sort headers.
4747         * alpha-linux-tdep.c: Sort headers.
4748         * alpha-linux-nat.c: Sort headers.
4749         * alpha-bsd-tdep.c: Sort headers.
4750         * alpha-bsd-nat.c: Sort headers.
4751         * aix-thread.c: Sort headers.
4752         * agent.c: Sort headers.
4753         * addrmap.c: Sort headers.
4754         * ada-varobj.c: Sort headers.
4755         * ada-valprint.c: Sort headers.
4756         * ada-typeprint.c: Sort headers.
4757         * ada-tasks.c: Sort headers.
4758         * ada-lang.c: Sort headers.
4759         * aarch64-tdep.c: Sort headers.
4760         * aarch64-ravenscar-thread.c: Sort headers.
4761         * aarch64-newlib-tdep.c: Sort headers.
4762         * aarch64-linux-tdep.c: Sort headers.
4763         * aarch64-linux-nat.c: Sort headers.
4764         * aarch64-fbsd-tdep.c: Sort headers.
4765         * aarch64-fbsd-nat.c: Sort headers.
4766         * aarch32-linux-nat.c: Sort headers.
4767
4768 2019-04-04  Tom Tromey  <tom@tromey.com>
4769
4770         * varobj.c (varobj_create): Update.
4771         * rust-exp.y (struct rust_parser) <update_innermost_block,
4772         lookup_symbol>: New methods.
4773         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4774         Rename.
4775         (rust_parser::rust_lookup_type)
4776         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4777         * printcmd.c (display_command, do_one_display): Update.
4778         * parser-defs.h (struct parser_state) <parser_state>: Add
4779         "tracker" parameter.
4780         (block_tracker): New member.
4781         (class innermost_block_tracker) <innermost_block_tracker>: Add
4782         "types" parameter.
4783         <reset>: Remove method.
4784         (innermost_block): Don't declare.
4785         (null_post_parser): Update.
4786         * parse.c (innermost_block): Remove global.
4787         (write_dollar_variable): Update.
4788         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4789         Remove "tracker_types" parameter.
4790         (parse_expression): Add "tracker" parameter.
4791         (parse_expression_for_completion): Update.
4792         (null_post_parser): Add "tracker" parameter.
4793         * p-exp.y: Update rules.
4794         * m2-exp.y: Update rules.
4795         * language.h (struct language_defn) <la_post_parser>: Add
4796         "tracker" parameter.
4797         * go-exp.y: Update rules.
4798         * f-exp.y: Update rules.
4799         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4800         parameter.
4801         * d-exp.y: Update rules.
4802         * c-exp.y: Update rules.
4803         * breakpoint.c (set_breakpoint_condition): Create an
4804         innermost_block_tracker.
4805         (watch_command_1): Likewise.
4806         * ada-lang.c (resolve): Add "tracker" parameter.
4807         (resolve_subexp): Likewise.
4808         * ada-exp.y (write_var_from_sym): Update.
4809
4810 2019-04-04  Tom Tromey  <tom@tromey.com>
4811
4812         * type-stack.h: New file.
4813         * type-stack.c: New file.
4814         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4815         type-stack.h.
4816         (insert_into_type_stack, insert_type, push_type, push_type_int)
4817         (insert_type_address_space, pop_type, pop_type_int)
4818         (pop_typelist, pop_type_stack, append_type_stack)
4819         (push_type_stack, get_type_stack, push_typelist)
4820         (follow_type_instance_flags, follow_types): Don't declare.
4821         * parse.c (type_stack): Remove global.
4822         (parse_exp_in_context): Update.
4823         (insert_into_type_stack, insert_type, push_type, push_type_int)
4824         (insert_type_address_space, pop_type, pop_type_int)
4825         (pop_typelist, pop_type_stack, append_type_stack)
4826         (push_type_stack, get_type_stack, push_typelist)
4827         (follow_type_instance_flags, follow_types): Remove (moved to
4828         type-stack.c).
4829         * f-exp.y (type_stack): New global.
4830         Update rules.
4831         (push_kind_type, f_parse): Update.
4832         * d-exp.y (type_stack): New global.
4833         Update rules.
4834         (d_parse): Update.
4835         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4836         Update rules.
4837         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4838         (HFILES_NO_SRCDIR): Add type-stack.h.
4839
4840 2019-04-04  Tom Tromey  <tom@tromey.com>
4841
4842         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4843         (rust_parser::convert_ast_to_expression, rust_parse)
4844         (rust_lex_test_completion, rust_lex_tests): Update.
4845         * parser-defs.h (struct expr_completion_state): New.
4846         (struct parser_state) <parser_state>: Add completion parameter.
4847         <mark_struct_expression, mark_completion_tag>: New methods.
4848         <parse_completion, m_completion_state>: New members.
4849         (prefixify_expression, null_post_parser): Update.
4850         (mark_struct_expression, mark_completion_tag): Don't declare.
4851         * parse.c (parse_completion, expout_last_struct)
4852         (expout_tag_completion_type, expout_completion_name): Remove
4853         globals.
4854         (parser_state::mark_struct_expression)
4855         (parser_state::mark_completion_tag): Now methods.
4856         (prefixify_expression): Add last_struct parameter.
4857         (prefixify_subexp): Likewise.
4858         (parse_exp_1): Update.
4859         (parse_exp_in_context): Add cstate parameter.  Update.
4860         (parse_expression_for_completion): Create an
4861         expr_completion_state.
4862         (null_post_parser): Add "completion" parameter.
4863         * p-exp.y: Update rules.
4864         (yylex): Update.
4865         * language.h (struct language_defn) <la_post_parser>: Add
4866         "completing" parameter.
4867         * go-exp.y: Update rules.
4868         (lex_one_token): Update.
4869         * expression.h (parse_completion): Don't declare.
4870         * d-exp.y: Update rules.
4871         (lex_one_token): Update rules.
4872         * c-exp.y: Update rules.
4873         (lex_one_token): Update.
4874         * ada-lang.c (resolve): Add "parse_completion" parameter.
4875         (resolve_subexp): Likewise.
4876         (ada_resolve_function): Likewise.
4877
4878 2019-04-04  Tom Tromey  <tom@tromey.com>
4879
4880         * parser-defs.h (struct parser_state) <start_arglist,
4881         end_arglist>: New methods.
4882         <arglist_len, m_funcall_chain>: New members.
4883         (arglist_len, start_arglist, end_arglist): Don't declare.
4884         * parse.c (arglist_len, funcall_chain): Remove global.
4885         (start_arglist, end_arglist): Remove functions.
4886         (parse_exp_in_context): Update.
4887         * p-exp.y: Update rules.
4888         * m2-exp.y: Update rules.
4889         * go-exp.y: Update rules.
4890         * f-exp.y: Update rules.
4891         * d-exp.y: Update rules.
4892         * c-exp.y: Update rules.
4893
4894 2019-04-04  Tom Tromey  <tom@tromey.com>
4895
4896         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4897         lex_operator, push_back>: New methods.
4898         Update all rules.
4899         (rust_parser::lex_hex, lex_escape): Rename and update.
4900         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4901         (rust_parser::lex_operator): Rename and update.
4902         (rust_parser::lex_number, rustyylex, rustyyerror)
4903         (rust_lex_test_init, rust_lex_test_sequence)
4904         (rust_lex_test_push_back, rust_lex_tests): Update.
4905         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4906         parameter.
4907         <lexptr, prev_lexptr>: New members.
4908         (lexptr, prev_lexptr): Don't declare.
4909         * parse.c (lexptr, prev_lexptr): Remove globals.
4910         (parse_exp_in_context): Update.
4911         * p-exp.y (yylex, yyerror): Update.
4912         * m2-exp.y (parse_number, yylex, yyerror): Update.
4913         * go-exp.y (lex_one_token, yyerror): Update.
4914         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4915         * d-exp.y (lex_one_token, yyerror): Update.
4916         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4917         (lex_one_token, yyerror): Update.
4918         * ada-lex.l (YY_INPUT): Update.
4919         (rewind_to_char): Update.
4920         * ada-exp.y (yyerror): Update.
4921
4922 2019-04-04  Tom Tromey  <tom@tromey.com>
4923
4924         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4925         * parser-defs.h (struct parser_state) <parser_state>: Add new
4926         parameter.
4927         <comma_terminates>: New member.
4928         (comma_terminates): Don't declare global.
4929         * parse.c (comma_terminates): Remove global.
4930         (parse_exp_in_context): Update.
4931         * p-exp.y (yylex): Update.
4932         * m2-exp.y (yylex): Update.
4933         * go-exp.y (lex_one_token): Update.
4934         * f-exp.y (yylex): Update.
4935         * d-exp.y (lex_one_token): Update.
4936         * c-exp.y (lex_one_token): Update.
4937         * ada-lex.l: Update.
4938
4939 2019-04-04  Tom Tromey  <tom@tromey.com>
4940
4941         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4942         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4943         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4944         * parser-defs.h (paren_depth): Don't declare.
4945         * parse.c (paren_depth): Remove global.
4946         (parse_exp_in_context): Update.
4947         * p-exp.y (paren_depth): New global.
4948         (pascal_parse): Initialize it.
4949         * m2-exp.y (paren_depth): New global.
4950         (m2_parse): Initialize it.
4951         * go-exp.y (paren_depth): New global.
4952         (go_parse): Initialize it.
4953         * f-exp.y (paren_depth): New global.
4954         (f_parse): Initialize it.
4955         * d-exp.y (paren_depth): New global.
4956         (d_parse): Initialize it.
4957         * c-exp.y (paren_depth): New global.
4958         (c_parse): Initialize it.
4959         * ada-lex.l (paren_depth): New global.
4960         (lexer_init): Initialize it.
4961
4962 2019-04-04  Tom Tromey  <tom@tromey.com>
4963
4964         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4965         (rust_parser::convert_ast_to_type)
4966         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4967         * parser-defs.h (struct parser_state) <parser_state>: Add
4968         parameters.  Initialize new members.
4969         <expression_context_block, expression_context_pc>: New members.
4970         * parse.c (expression_context_block, expression_context_pc):
4971         Remove globals.
4972         (parse_exp_in_context): Update.
4973         * p-exp.y: Update all rules.
4974         (yylex): Update.
4975         * m2-exp.y: Update all rules.
4976         (yylex): Update.
4977         * go-exp.y (yylex): Update.
4978         * f-exp.y (yylex): Update.
4979         * d-exp.y: Update all rules.
4980         (yylex): Update.
4981         * c-exp.y: Update all rules.
4982         (lex_one_token, classify_name, yylex, c_parse): Update.
4983         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4984
4985 2019-04-04  Tom Tromey  <tom@tromey.com>
4986
4987         * gdbarch.h, gdbarch.c: Rebuild.
4988         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4989         * stap-probe.h: 
4990         (struct stap_parse_info): Replace "parser_state" with
4991         "expr_builder".
4992         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4993         (parser_state): New class.
4994         * parse.c (expr_builder): Rename.
4995         (expr_builder::release): Rename.
4996         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4997         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4998         (write_exp_elt_longcst, write_exp_elt_floatcst)
4999         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5000         (write_exp_string_vector, write_exp_bitstring)
5001         (write_exp_msymbol, mark_struct_expression)
5002         (write_dollar_variable)
5003         (insert_type_address_space, increase_expout_size): Replace
5004         "parser_state" with "expr_builder".
5005         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5006         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5007         "parser_state" with "expr_builder".
5008
5009 2019-04-04  Tom Tromey  <tom@tromey.com>
5010
5011         * rust-exp.y: Replace "parse_language" with method call.
5012         * p-exp.y: 
5013         (yylex): Replace "parse_language" with method call.
5014         * m2-exp.y: 
5015         (yylex): Replace "parse_language" with method call.
5016         * go-exp.y (classify_name): Replace "parse_language" with method
5017         call.
5018         * f-exp.y (yylex): Replace "parse_language" with method call.
5019         * d-exp.y (lex_one_token): Replace "parse_language" with method
5020         call.
5021         * c-exp.y: 
5022         (lex_one_token, classify_name, yylex): Replace "parse_language"
5023         with method call.
5024         * ada-exp.y (find_primitive_type, type_char)
5025         (type_system_address): Replace "parse_language" with method call.
5026
5027 2019-04-04  Tom Tromey  <tom@tromey.com>
5028
5029         * rust-exp.y: Replace "parse_gdbarch" with method call.
5030         * parse.c (write_dollar_variable, insert_type_address_space):
5031         Replace "parse_gdbarch" with method call.
5032         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5033         call.
5034         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5035         call.
5036         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5037         "parse_gdbarch" with method call.
5038         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5039         with method call.
5040         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5041         "parse_gdbarch" with method call.
5042         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5043         "parse_gdbarch" with method call.
5044         * c-exp.y (parse_type, parse_number, classify_name): Replace
5045         "parse_gdbarch" with method call.
5046         * ada-lex.l: Replace "parse_gdbarch" with method call.
5047         * ada-exp.y (parse_type, find_primitive_type, type_char)
5048         (type_system_address): Replace "parse_gdbarch" with method call.
5049
5050 2019-04-04  Tom Tromey  <tom@tromey.com>
5051
5052         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5053         * stap-probe.c (stap_parse_argument): Update.
5054         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5055         initial_size parameter.
5056         * rust-exp.y (rust_lex_tests): Update.
5057         * parse.c (parser_state): Update.
5058         (parse_exp_in_context): Update.
5059         * parser-defs.h (struct parser_state) <parser_state>: Remove
5060         "initial_size" parameter.
5061
5062 2019-04-04  Tom Tromey  <tom@tromey.com>
5063
5064         * parser-defs.h (increase_expout_size): Don't declare.
5065         * parse.c (increase_expout_size): Now static.
5066
5067 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5068
5069         * gnu-nat.c (gnu_nat_target::wait): Fix
5070         target_waitstatus_to_string call.
5071
5072 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * eval.c (evaluate_subexp_standard): Handle internal functions
5075         during Fortran function call handling.
5076
5077 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5078
5079         * NEWS: Mention new internal functions.
5080         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5081         (read_base_type): Use dwarf2_init_complex_target_type.
5082         * value.c (creal_internal_fn): New function.
5083         (cimag_internal_fn): New function.
5084         (_initialize_values): Register new internal functions.
5085
5086 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5087
5088         * infrun.c (stop_all_threads): If debug_infrun, always
5089         trace the wait status after wait_one, using
5090         target_waitstatus_to_string and target_pid_to_str.
5091         (handle_inferior_event): Replace various trace of
5092         wait status kind by a single trace.
5093         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5094         wait status kind image by target_waitstatus_to_string.
5095         * target/waitstatus.c (target_waitstatus_to_string): Fix
5096         obsolete comment.
5097
5098 2019-04-01  Tom Tromey  <tromey@adacore.com>
5099
5100         PR symtab/23331:
5101         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5102
5103 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5104             Pedro Alves  <palves@redhat.com>
5105
5106         * top.c (quit_force): Call 'finalize_values'.
5107         * value.c (finalize_values): New function.
5108         * value.h (finalize_values): Declare.
5109
5110 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5111
5112         * NEWS: Announce $_gdb_major and $_gdb_minor.
5113
5114         * top.c (init_gdb_version_vars): New function.
5115         (gdb_init): Call init_gdb_version_vars.
5116
5117 2019-03-29  Tom Tromey  <tromey@adacore.com>
5118
5119         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5120         help text.  Remove dead code.
5121
5122 2019-03-29  Keith Seitz  <keiths@redhat.com>
5123
5124         From Siddhesh Poyarekar:
5125         * f-lang.h (f77_get_upperbound): Return LONGEST.
5126         (f77_get_lowerbound): Likewise.
5127         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5128         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5129         print them.
5130         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5131         plongest to format print it.
5132         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5133         (f77_get_upperbound): Likewise.
5134         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5135         LOWER_BOUND to LONGEST.
5136         (f77_create_arrayprint_offset_tbl): Likewise.
5137
5138 2019-03-29  Keith Seitz  <keiths@redhat.com>
5139
5140         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5141         %s/pulongest for TYPE_LENGTH instead of %d in format
5142         strings.
5143         * ada-typerint.c (ada_print_type): Likewise.
5144         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5145         * compile/compile-c-support.c (generate_register_struct): Likewise.
5146         * gdbtypes.c (recursive_dump_type): Likewise.
5147         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5148         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5149         instead of %d in format strings.
5150         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5151         to std::min to ULONGEST.
5152         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5153         instead of %d in format strings.
5154         * tracepoint.c (info_scope_command): Likewise.
5155         * typeprint.c (print_offset_data::update)
5156         (print_offset_data::finish): Likewise.
5157         * xtensa-tdep.c (xtensa_store_return_value)
5158         (xtensa_push_dummy_call): Likewise.
5159
5160 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5161
5162         * windows-nat.c (display_selector): Fixed format specifications
5163         for 64-bit Cygwin.
5164
5165 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5166
5167         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5168
5169 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5170
5171         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5172         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5173         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5174         (nios2_linux_init_abi): Install it.
5175
5176 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5177
5178         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5179
5180 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5181
5182         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5183
5184 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5185             Tom Tromey  <tromey@adacore.com>
5186
5187         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5188
5189 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5190
5191         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5192         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5193         method to compute the bounds of range types. Also print "[evaluated]"
5194         if the bounds' values come from a dynamic evaluation.
5195
5196 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5199         whitespace when pretty printing is on.
5200
5201 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5202
5203         * ppc-linux-nat.c: Add include.
5204
5205 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5206
5207         * NEWS: Mention AArch64 Pointer Authentication.
5208
5209 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5210
5211         * arm-linux-nat.c: Add include.
5212
5213 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5214
5215         * source-cache.c (source_cache::get_source_lines): Re-read
5216         fullname after calling open_source_file.
5217
5218 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5219
5220         * NEWS: Mention TLS support for FreeBSD.
5221
5222 2019-03-25  Tom Tromey  <tromey@adacore.com>
5223
5224         * minsyms.c (BUNCH_SIZE): Update comment.
5225         (~minimal_symbol_reader): Remove old comment.
5226         (compact_minimal_symbols): Update comment.
5227         (minimal_symbol_reader::install): Remove old comment.  Update
5228         other comments.
5229
5230 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5231
5232         * s390-linux-nat.c: Add include.
5233
5234 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5235
5236         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5237         Call linux_get_hwcap.
5238         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5239         Likewise.
5240         (aarch64_linux_get_hwcap): Remove function.
5241         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5242         declaration.
5243         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5244         linux_get_hwcap.
5245         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5246         * linux-tdep.c (linux_get_hwcap): Add function.
5247         (linux_get_hwcap2): Likewise.
5248         * linux-tdep.h (linux_get_hwcap): Add declaration.
5249         (linux_get_hwcap2): Likewise.
5250         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5251         (ppc_linux_get_hwcap2): Likewise.
5252         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5253         linux_get_hwcap.
5254         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5255         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5256         (ppc_linux_nat_target::read_description): Likewise.
5257         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5258         * s390-linux-nat.c: Likewise.
5259         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5260
5261 2019-03-24  Tom Tromey  <tom@tromey.com>
5262
5263         * ada-lang.c (standard_lookup): Simplify initialization.
5264         (ada_lookup_symbol_nonlocal): Simplify return.
5265         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5266         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5267         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5268         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5269         initialization.
5270         * solib.c (solib_global_lookup): Simplify.
5271         * symtab.c (null_block_symbol): Remove.
5272         (symbol_cache_lookup): Simplify returns.
5273         (lookup_language_this): Simplify returns.
5274         (lookup_symbol_aux): Simplify return.
5275         (lookup_local_symbol): Simplify returns.
5276         (lookup_global_symbol_from_objfile): Simplify return.
5277         (lookup_symbol_in_objfile_symtabs)
5278         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5279         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5280         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5281         * cp-namespace.c (cp_lookup_bare_symbol)
5282         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5283         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5284         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5285         (cp_lookup_symbol_via_imports): Simplify initialization.
5286         (find_symbol_in_baseclass): Likewise.
5287         * symtab.h (null_block_symbol): Remove.
5288         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5289         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5290         (d_lookup_symbol_module): Likewise.
5291         (find_symbol_in_baseclass): Simplify initialization.
5292
5293 2019-03-24  Tom Tromey  <tom@tromey.com>
5294
5295         * expression.h: Don't include symtab.h.
5296         (struct block): Forward declare.
5297
5298 2019-03-24  Tom Tromey  <tom@tromey.com>
5299
5300         * c-exp.y (typebase): Remove casts.
5301         * gdbtypes.c (lookup_unsigned_typename, )
5302         (lookup_signed_typename): Remove cast.
5303         * eval.c (parse_to_comma_and_eval): Remove cast.
5304         * parse.c (write_dollar_variable): Remove cast.
5305         * block.h (struct block) <superblock>: Now const.
5306         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5307         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5308         (map_block): Make "block" const.
5309         * symfile.h (struct quick_symbol_functions)
5310         <map_matching_symbols>: Constify block argument to "callback".
5311         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5312         const.
5313         (find_pc_sect_compunit_symtab): Make "b" const.
5314         (find_symbol_at_address): Likewise.
5315         (search_symbols): Likewise.
5316         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5317         (dw2_debug_names_lookup_symbol): Likewise.
5318         (dw2_map_matching_symbols): Update.
5319         * p-valprint.c (pascal_val_print): Remove "block".
5320         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5321         (aux_add_nonlocal_symbols): Make "block" const.
5322         (resolve_subexp): Remove cast.
5323         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5324         const.
5325         (iterate_over_file_blocks): Likewise.
5326         * f-exp.y (%union) <bval>: Remove.
5327         * coffread.c (patch_opaque_types): Make "b" const.
5328         * spu-tdep.c (spu_catch_start): Make "block" const.
5329         * c-valprint.c (print_unpacked_pointer): Remove "block".
5330         * symmisc.c (dump_symtab_1): Make "b" const.
5331         (block_depth): Make "block" const.
5332         * d-exp.y (%union) <bval>: Remove.
5333         * cp-support.h (cp_lookup_rtti_type): Update.
5334         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5335         * psymtab.c (psym_lookup_symbol): Make "block" const.
5336         (maintenance_check_psymtabs): Make "b" const.
5337         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5338         (enumerate_locals, enumerate_args): Update.
5339         * python/py-symtab.c (stpy_global_block): Make "block" const.
5340         (stpy_static_block): Likewise.
5341         * inline-frame.c (block_starting_point_at): Make "new_block"
5342         const.
5343         * block.c (find_block_in_blockvector): Make return type const.
5344         (blockvector_for_pc_sect): Make "b" const.
5345         (find_block_in_blockvector): Make "b" const.
5346
5347 2019-03-23  Tom Tromey  <tom@tromey.com>
5348
5349         * varobj.c (varobj_create): Update.
5350         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5351         * printcmd.c (display_command, do_one_display): Don't reset
5352         innermost_block.
5353         * parser-defs.h (enum innermost_block_tracker_type): Move to
5354         expression.h.
5355         (innermost_block): Update comment.
5356         * parse.c (parse_exp_1): Add tracker_types parameter.
5357         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5358         tracker_types parameter.  Reset innermost_block.
5359         (parse_exp_in_context): Remove.
5360         (parse_expression_for_completion): Update.
5361         * objfiles.c (~objfile): Don't reset expression_context_block or
5362         innermost_block.
5363         * expression.h (enum innermost_block_tracker_type): Move from
5364         parser-defs.h.
5365         (parse_exp_1): Add tracker_types parameter.
5366         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5367         reset innermost_block.
5368
5369 2019-03-23  Tom Tromey  <tom@tromey.com>
5370
5371         * objfiles.h: Include bcache.h.
5372
5373 2019-03-23  Tom Tromey  <tom@tromey.com>
5374
5375         * linespec.c (get_current_search_block): Use
5376         scoped_restore_current_language.
5377         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5378
5379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5380             Jiong Wang  <jiong.wang@arm.com>
5381
5382         * aarch64-linux-tdep.c
5383         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5384         section.
5385         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5386
5387 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5388             Jiong Wang  <jiong.wang@arm.com>
5389
5390         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5391         instructions.
5392         (aarch64_analyze_prologue_test): Add PACIASP test.
5393         (aarch64_prologue_prev_register): Unmask PC value.
5394
5395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5396             Jiong Wang  <jiong.wang@arm.com>
5397
5398         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5399         (aarch64_dwarf2_prev_register): Unmask PC value.
5400         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5401         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5402         DW_CFA_AARCH64_negate_ra_state.
5403         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5404
5405 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5406             Jiong Wang  <jiong.wang@arm.com>
5407
5408         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5409         registers.
5410         (aarch64_pseudo_register_name): Likewise.
5411         (aarch64_pseudo_register_type): Likewise.
5412         (aarch64_pseudo_register_reggroup_p): Likewise.
5413         (aarch64_gdbarch_init): Add pauth registers.
5414         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5415         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5416         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5417         (struct gdbarch_tdep): Add regnum for ra_state.
5418
5419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5420             Jiong Wang  <jiong.wang@arm.com>
5421
5422         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5423
5424 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5425             Jiong Wang  <jiong.wang@arm.com>
5426
5427         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5428         function.
5429         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5430         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5431         (aarch64_gdbarch_init): Add puth registers.
5432         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5433         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5434         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5435
5436 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5437             Jiong Wang  <jiong.wang@arm.com>
5438
5439         * aarch64-linux-nat.c
5440         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5441         * aarch64-linux-tdep.c
5442         (aarch64_linux_core_read_description): Likewise.
5443         (aarch64_linux_get_hwcap): New function.
5444         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5445         (aarch64_linux_get_hwcap): New declaration.
5446
5447 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5448             Jiong Wang  <jiong.wang@arm.com>
5449
5450         * aarch64-linux-nat.c
5451         (aarch64_linux_nat_target::read_description): Add pauth param.
5452         * aarch64-linux-tdep.c
5453         (aarch64_linux_core_read_description): Likewise.
5454         * aarch64-tdep.c (struct target_desc): Add in pauth.
5455         (aarch64_read_description): Add pauth param.
5456         (aarch64_gdbarch_init): Likewise.
5457         * aarch64-tdep.h (aarch64_read_description): Likewise.
5458         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5459         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5460         * features/Makefile: Add new files.
5461         * features/aarch64-pauth.c: New file.
5462         * features/aarch64-pauth.xml: New file.
5463
5464 2019-03-20  Tom Tromey  <tromey@adacore.com>
5465
5466         * infrun.c (handle_inferior_event): Rename from
5467         handle_inferior_event_1.  Create a scoped_value_mark.
5468         (handle_inferior_event): Remove.
5469
5470 2019-03-19  Tom Tromey  <tromey@adacore.com>
5471
5472         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5473         * infrun.h (print_stop_event): Add "displays" parameter.
5474         * infrun.c (print_stop_event): Add "displays" parameter.
5475
5476 2019-03-19  Pedro Alves  <palves@redhat.com>
5477
5478         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5479         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5480         to -1.  Fix TABs vs spaces.
5481         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5482         * tui/tui-out.h (tui_ui_out) Add intro comments.
5483         <m_line, m_start_of_line>: In-class initialize, and add describing
5484         comment.
5485
5486 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5487
5488         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5489         variable names.
5490         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5491
5492 2019-03-18  Pedro Alves  <palves@redhat.com>
5493             Eli Zaretskii <eliz@gnu.org>
5494
5495         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5496         m_line and m_start_of_line.
5497
5498 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5499
5500         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5501         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5502         it returns a newline.  This fixes a regression in TU mode, whereby
5503         the next line is output on the same screen line as the user input.
5504
5505 2019-03-18  Tom Tromey  <tromey@adacore.com>
5506
5507         * minsyms.c (minimal_symbol_reader::install): Remove call to
5508         obstack_blank.
5509
5510 2019-03-18  Pedro Alves  <palves@redhat.com>
5511
5512         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5513         New globals.
5514         (apply_style): New, factored out from ...
5515         (apply_ansi_escape): ... this.  Handle reverse video mode.
5516         (tui_set_reverse_mode): New function.
5517         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5518         * tui/tui-winsource.c (tui_show_source_line): Use
5519         tui_set_reverse_mode instead of setting A_STANDOUT.
5520         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5521         New setter methods.
5522
5523 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5524
5525         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5526         Handle tabs.
5527
5528 2019-03-18  Tom Tromey  <tromey@adacore.com>
5529
5530         * ada-lang.c (empty_array): Add "high" parameter.
5531         (ada_evaluate_subexp): Update.
5532
5533 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5534
5535         * unittests/string_view-selftests.c: Define
5536         _initialize_string_view_selftests unconditionally.
5537
5538 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5539
5540         PR gdb/24350
5541         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5542
5543 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5544
5545         PR gdb/24351
5546         * windows-nat.c (display_selector): Fix format specifiers.
5547
5548 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5549
5550         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5551         tui_refill_source_window instead of tui_refresh_win, to update the
5552         current execution line.  This fixes redisplay of the current line
5553         when stepping through the code with "next" or "step".
5554
5555 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5556
5557         * source-cache.c (source_cache::get_source_lines): Call
5558         find_source_lines to initialize s->nlines.  This fixes vertical
5559         scrolling of TUI source window when the DOWN arrow is pressed.
5560
5561 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5562
5563         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5564         linux-thread-db.c (_initialize_thread_db): Likewise.
5565
5566 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5567
5568         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5569         wclrtoeol in tui_show_source_line".  This reverts changes made in
5570         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5571
5572 2019-03-15  Tom Tromey  <tom@tromey.com>
5573
5574         * symtab.h (struct minimal_symbol): Derive from
5575         general_symbol_info.
5576         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5577         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5578         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5579         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5580         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5581         (MSYMBOL_SEARCH_NAME): Update.
5582         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5583         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5584         * minsyms.c (minimal_symbol_reader::record_full): Update.
5585
5586 2019-03-15  Tom Tromey  <tom@tromey.com>
5587
5588         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5589
5590 2019-03-15  Tom Tromey  <tom@tromey.com>
5591
5592         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5593         unique_xmalloc_ptr.
5594         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5595         Update.
5596         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5597         (build_minimal_symbol_hash_tables)
5598         (minimal_symbol_reader::install): Update.
5599
5600 2019-03-15  Tom Tromey  <tom@tromey.com>
5601
5602         * symtab.c (create_demangled_names_hash): Update.
5603         (symbol_set_names): Update.
5604         * objfiles.h (struct objfile_per_bfd_storage)
5605         <demangled_names_hash>: Now an htab_up.
5606         * objfiles.c (objfile_per_bfd_storage): Simplify.
5607
5608 2019-03-15  Tom Tromey  <tom@tromey.com>
5609
5610         * objfiles.h (struct objfile_per_bfd_storage): Declare
5611         destructor.
5612         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5613         New.
5614         (get_objfile_bfd_data): Use new.  Don't initialize
5615         language_of_main.
5616         (free_objfile_per_bfd_storage): Remove.
5617         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5618
5619 2019-03-15  Tom Tromey  <tom@tromey.com>
5620
5621         * symfile.c (reread_symbols): Update.
5622         * objfiles.c (objfile::objfile): Update.
5623         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5624         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5625         comment.
5626         (minimal_symbol_reader::install): Update.
5627         (terminate_minimal_symbol_table): Remove.
5628         * jit.c (jit_object_close_impl): Update.
5629
5630 2019-03-15  Tom Tromey  <tom@tromey.com>
5631
5632         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5633         initializations.
5634
5635 2019-03-15  Tom Tromey  <tom@tromey.com>
5636
5637         * objfiles.h (struct objfile_per_bfd_storage)
5638         <demangled_hash_languages>: Now a bitset.
5639         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5640         (lookup_minimal_symbol): Update.
5641
5642 2019-03-15  Tom Tromey  <tom@tromey.com>
5643
5644         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5645         Don't return the symbol.
5646         * coffread.c (record_minimal_symbol): Use record_full.
5647
5648 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5649
5650         The MS-Windows port of ncurses fails to switch to a color pair if
5651         one or both of the colors are the implicit default colors.  This
5652         change records the default colors when TUI is initialized, and
5653         then specifies them explicitly when a color pair uses the default
5654         colors.  This allows color styling in TUI mode on MS-Windows.
5655
5656         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5657         ncurses_norm_attr.
5658         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5659         colors in ncurses_norm_attr.
5660         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5661         "none", replace it with the default color recorded in
5662         ncurses_norm_attr.
5663
5664 2019-03-14  Tom Tromey  <tromey@adacore.com>
5665
5666         * source-cache.h (class source_cache) <get_source_lines>: Return
5667         std::string.
5668         * source-cache.c (source_cache::extract_lines): Handle case where
5669         first_pos==npos.  Return std::string.
5670         (source_cache::get_source_lines): Update.
5671
5672 2019-03-14  Tom Tromey  <tromey@adacore.com>
5673
5674         * NEWS: Add item for "style sources" commands.
5675         * source-cache.c (source_cache::get_source_lines): Check
5676         source_styling.
5677         * cli/cli-style.c (source_styling): New global.
5678         (_initialize_cli_style): Add "style sources" commands.
5679         (show_style_sources): New function.
5680         * cli/cli-style.h (source_styling): Declare.
5681
5682 2019-03-14  Pedro Alves  <palves@redhat.com>
5683             Tom Tromey  <tromey@adacore.com>
5684
5685         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5686         * tui/tui-winsource.c (tui_refill_source_window): New function,
5687         from...
5688         (tui_horizontal_source_scroll): ... here.  Move some logic.
5689         * cli/cli-style.c (set_style_enabled): Notify new observable.
5690         * tui/tui-hooks.c (tui_redisplay_source): New function.
5691         (tui_attach_detach_observers): Attach or detach
5692         tui_redisplay_source.
5693         * observable.h (source_styling_changed): New observable.
5694         * observable.c: Define source_styling_changed observable.
5695
5696 2019-03-13  Tom Tromey  <tromey@adacore.com>
5697
5698         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5699         (i386_gnu_nat_target::store_registers): Update.
5700         * target-debug.h (target_debug_print_std_string): New macro.
5701         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5702         * windows-tdep.c (display_one_tib): Update.
5703         * tui/tui-stack.c (tui_make_status_line): Update.
5704         * top.c (print_inferior_quit_action): Update.
5705         * thread.c (thr_try_catch_cmd): Update.
5706         (add_thread_with_info): Update.
5707         (thread_target_id_str): Update.
5708         (thr_try_catch_cmd): Update.
5709         (thread_command): Update.
5710         (thread_find_command): Update.
5711         * record-btrace.c (record_btrace_target::info_record)
5712         (record_btrace_resume_thread, record_btrace_target::resume)
5713         (record_btrace_cancel_resume, record_btrace_step_thread)
5714         (record_btrace_target::wait, record_btrace_target::wait)
5715         (record_btrace_target::wait, record_btrace_target::stop): Update.
5716         * progspace.c (print_program_space): Update.
5717         * process-stratum-target.c
5718         (process_stratum_target::thread_address_space): Update.
5719         * linux-fork.c (linux_fork_mourn_inferior)
5720         (detach_checkpoint_command, info_checkpoints_command)
5721         (linux_fork_context): Update.
5722         (linux_fork_detach): Update.
5723         (class scoped_switch_fork_info): Update.
5724         (delete_checkpoint_command): Update.
5725         * infrun.c (follow_fork_inferior): Update.
5726         (follow_fork_inferior): Update.
5727         (proceed_after_vfork_done): Update.
5728         (handle_vfork_child_exec_or_exit): Update.
5729         (follow_exec): Update.
5730         (displaced_step_prepare_throw): Update.
5731         (displaced_step_restore): Update.
5732         (start_step_over): Update.
5733         (resume_1): Update.
5734         (clear_proceed_status_thread): Update.
5735         (proceed): Update.
5736         (print_target_wait_results): Update.
5737         (do_target_wait): Update.
5738         (context_switch): Update.
5739         (stop_all_threads): Update.
5740         (restart_threads): Update.
5741         (finish_step_over): Update.
5742         (handle_signal_stop): Update.
5743         (switch_back_to_stepped_thread): Update.
5744         (keep_going_pass_signal): Update.
5745         (print_exited_reason): Update.
5746         (normal_stop): Update.
5747         * inferior.c (inferior_pid_to_str): Change return type.
5748         (print_selected_inferior): Update.
5749         (add_inferior): Update.
5750         (detach_inferior): Update.
5751         * dummy-frame.c (fprint_dummy_frames): Update.
5752         * dcache.c (dcache_info_1): Update.
5753         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5754         (btrace_fetch, btrace_clear): Update.
5755         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5756         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5757         type.
5758         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5759         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5760         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5761         * gdbarch.c, gdbarch.h: Rebuild.
5762         * gdbarch.sh (core_pid_to_str): Change return type.
5763         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5764         return type.
5765         (windows_nat_target::pid_to_str): Change return type.
5766         (windows_delete_thread): Update.
5767         (windows_nat_target::attach): Update.
5768         (windows_nat_target::files_info): Update.
5769         * target-delegates.c: Rebuild.
5770         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5771         return type.
5772         (sol_thread_target::pid_to_str): Change return type.
5773         * remote.c (class remote_target) <pid_to_str>: Change return
5774         type.
5775         (remote_target::pid_to_str): Change return type.
5776         (extended_remote_target::attach, remote_target::remote_stop_ns)
5777         (remote_target::remote_notif_remove_queued_reply)
5778         (remote_target::push_stop_reply, remote_target::disable_btrace):
5779         Update.
5780         (extended_remote_target::attach): Update.
5781         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5782         type.
5783         (gdbsim_target::pid_to_str): Change return type.
5784         * ravenscar-thread.c (struct ravenscar_thread_target)
5785         <pid_to_str>: Change return type.
5786         (ravenscar_thread_target::pid_to_str): Change return type.
5787         * procfs.c (class procfs_target) <pid_to_str>: Change return
5788         type.
5789         (procfs_target::pid_to_str): Change return type.
5790         (procfs_target::attach): Update.
5791         (procfs_target::detach): Update.
5792         (procfs_target::fetch_registers): Update.
5793         (procfs_target::store_registers): Update.
5794         (procfs_target::wait): Update.
5795         (procfs_target::files_info): Update.
5796         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5797         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5798         return type.
5799         (nto_procfs_target::pid_to_str): Change return type.
5800         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5801         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5802         return type.
5803         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5804         (exit_lwp): Update.
5805         (attach_proc_task_lwp_callback, get_detach_signal)
5806         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5807         (linux_nat_target::resume, wait_lwp, stop_callback)
5808         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5809         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5810         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5811         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5812         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5813         type.
5814         (inf_ptrace_target::attach): Update.
5815         (inf_ptrace_target::files_info): Update.
5816         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5817         type.
5818         (go32_nat_target::pid_to_str): Change return type.
5819         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5820         (gnu_nat_target::wait): Update.
5821         (gnu_nat_target::wait): Update.
5822         (gnu_nat_target::resume): Update.
5823         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5824         (fbsd_nat_target::wait): Update.
5825         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5826         type.
5827         (darwin_nat_target::attach): Update.
5828         * corelow.c (class core_target) <pid_to_str>: Change return type.
5829         (core_target::pid_to_str): Change return type.
5830         * target.c (normal_pid_to_str): Change return type.
5831         (default_pid_to_str): Likewise.
5832         (target_pid_to_str): Change return type.
5833         (target_translate_tls_address): Update.
5834         (target_announce_detach): Update.
5835         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5836         return type.
5837         (bsd_uthread_target::pid_to_str): Change return type.
5838         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5839         type.
5840         (bsd_kvm_target::pid_to_str): Change return type.
5841         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5842         return type.
5843         (aix_thread_target::pid_to_str): Change return type.
5844         * target.h (struct target_ops) <pid_to_str>: Change return type.
5845         (target_pid_to_str, normal_pid_to_str): Likewise.
5846         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5847         type.
5848         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5849         type.
5850         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5851         return type.
5852         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5853         type.
5854         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5855         type.
5856         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5857         return type.
5858
5859 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5860
5861         * NEWS: Mention that the new default MI version is 3.  Mention
5862         changes to the output of commands and events that deal with
5863         multi-location breakpoints.
5864         * breakpoint.c: Include "mi/mi-out.h".
5865         (print_one_breakpoint): Change output syntax if using MI version
5866         >= 3.
5867         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5868         New.
5869         (mi_multi_location_breakpoint_output_fixed): New.
5870         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5871         (mi_cmd_fix_multi_location_breakpoint_output): New.
5872         (mi_multi_location_breakpoint_output_fixed): New.
5873         * mi/mi-cmds.c (mi_cmds): Register command
5874         -fix-multi-location-breakpoint-output.
5875         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5876         interpreter "mi".
5877
5878 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5879
5880         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5881         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5882         instantiate mi_ui_out based on interpreter name.
5883         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5884         * mi/mi-main.c (mi_load_progress): Likewise.
5885
5886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5887
5888         * NEWS: Combine separate "New targets" sections for 8.3.
5889
5890 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5891
5892         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5893         (ppcfbsd_init_abi): Install gdbarch
5894         "fetch_tls_load_module_address" and "get_thread_local_address"
5895         methods.
5896
5897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5898
5899         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5900         (riscv_fbsd_init_abi): Install gdbarch
5901         "fetch_tls_load_module_address" and "get_thread_local_address"
5902         methods.
5903
5904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5905
5906         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5907         (i386fbsd_init_abi): Install gdbarch
5908         "fetch_tls_load_module_address" and "get_thread_local_address"
5909         methods.
5910
5911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5912
5913         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5914         (amd64fbsd_init_abi): Install gdbarch
5915         "fetch_tls_load_module_address" and "get_thread_local_address"
5916         methods.
5917
5918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5919
5920         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5921         (struct fbsd_pspace_data): New type.
5922         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5923         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5924         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5925         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5926         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5927
5928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5929
5930         * gdbtypes.c (lookup_struct_elt): New function.
5931         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5932         * gdbtypes.h (struct struct_elt): New type.
5933         (lookup_struct_elt): New prototype.
5934
5935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5936
5937         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5938         remove disabled code block.
5939
5940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5941
5942         * gdbarch.sh (get_thread_local_address): New method.
5943         * gdbarch.h, gdbarch.c: Regenerate.
5944         * target.c (target_translate_tls_address): Use
5945         gdbarch_get_thread_local_address if present instead of
5946         target::get_thread_local_address.
5947
5948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5949
5950         * target.h (target::get_thread_local_address): Update comment.
5951
5952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5953
5954         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5955         objfile->separate_debug_objfile_backlink if not NULL.
5956
5957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5958
5959         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5960         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5961         (amd64bsd_store_inferior_registers): Likewise.
5962         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5963         Enable segment base registers.
5964         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5965         PT_GETFSBASE and PT_GETGSBASE.
5966         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5967         PT_SETGSBASE.
5968         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5969         segment base registers.
5970         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5971
5972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5973
5974         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5975         Update calls to i386_target_description to add 'segments'
5976         parameter.
5977         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5978         add segment base registers.
5979         * arch/i386.c (i386_create_target_description): Add 'segments'
5980         parameter to enable segment base registers.
5981         * arch/i386.h (i386_create_target_description): Likewise.
5982         * features/i386/32bit-segments.xml: New file.
5983         * features/i386/32bit-segments.c: Generate.
5984         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5985         call to i386_target_description to add 'segments' parameter.
5986         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5987         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5988         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5989         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5990         if feature is present.
5991         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5992         Add 'segments' parameter to call to i386_target_description.
5993         (i386_target_description): Add 'segments' parameter to enable
5994         segment base registers.
5995         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5996         to call to i386_target_description.
5997         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5998         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5999         Define I386_NUM_REGS.
6000         (i386_target_description): Add 'segments' parameter to enable
6001         segment base registers.
6002
6003 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6004
6005         PR/24325
6006         * source-cache.c: #undef open and close, to avoid unresolved
6007         externals during linking.
6008
6009 2019-03-12  Tom Tromey  <tromey@adacore.com>
6010
6011         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6012         const.  Add initializers.
6013         (_initialize_remote): Don't initialize ptid globals.
6014
6015 2019-03-12  Pedro Alves  <palves@redhat.com>
6016
6017         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6018
6019 2019-03-12  Pedro Alves  <palves@redhat.com>
6020
6021         * cp-name-parser.y (main): Remove unused 'len' variable.
6022
6023 2019-03-12  Tom Tromey  <tromey@adacore.com>
6024
6025         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6026         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6027
6028 2019-03-12  Tom Tromey  <tromey@adacore.com>
6029
6030         * linux-nat.c (iterate_over_lwps): Update.
6031         (stop_callback): Remove parameter.
6032         (stop_wait_callback, detach_callback, resume_set_callback)
6033         (select_singlestep_lwp_callback, set_ignore_sigint)
6034         (status_callback, resumed_callback, resume_clear_callback)
6035         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6036         data parameter.
6037         (linux_nat_target::detach, linux_nat_target::resume)
6038         (linux_stop_and_wait_all_lwps, select_event_lwp)
6039         (linux_nat_filter_event, linux_nat_wait_1)
6040         (linux_nat_target::kill, linux_nat_target::stop)
6041         (linux_nat_target::stop): Update.
6042         (linux_nat_resume_callback): Change type.
6043         (resume_stopped_resumed_lwps, count_events_callback)
6044         (select_event_lwp_callback): Likewise.
6045         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6046         * arm-linux-nat.c (struct update_registers_data): Remove.
6047         (update_registers_callback): Change type.
6048         (arm_linux_insert_hw_breakpoint1): Update.
6049         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6050         parameter.
6051         (x86_linux_dr_set_addr): Update.
6052         (x86_linux_dr_set_control): Update.
6053         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6054         (iterate_over_lwps): Use gdb::function_view.
6055         * nat/aarch64-linux-hw-point.c (struct
6056         aarch64_dr_update_callback_param): Remove.
6057         (debug_reg_change_callback): Change type.
6058         (aarch64_notify_debug_reg_change): Update.
6059         * s390-linux-nat.c (s390_refresh_per_info): Update.
6060
6061 2019-03-11  Tom Tromey  <tromey@adacore.com>
6062
6063         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6064         redundant assignment to "this_cu".
6065
6066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6067
6068         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6069
6070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6071
6072         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6073         from...
6074         (rank_one_type): ... this.
6075
6076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6077
6078         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6079         from...
6080         (rank_one_type): ... this.
6081
6082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6083
6084         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6085         from...
6086         (rank_one_type): ... this.
6087
6088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6089
6090         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6091         from...
6092         (rank_one_type): ... this.
6093
6094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6095
6096         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6097         from...
6098         (rank_one_type): ... this.
6099
6100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6101
6102         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6103         from...
6104         (rank_one_type): ... this.
6105
6106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6107
6108         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6109         from...
6110         (rank_one_type): ... this.
6111
6112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6113
6114         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6115         from...
6116         (rank_one_type): ... this.
6117
6118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6119
6120         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6121         from...
6122         (rank_one_type): ... this.
6123
6124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6125
6126         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6127         from...
6128         (rank_one_type): ... this.
6129
6130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6131
6132         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6133         from...
6134         (rank_one_type): ... this.
6135
6136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6137
6138         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6139         from...
6140         (rank_one_type): ... this.
6141
6142 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6143
6144         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6145         inferior-events' shows the example events.
6146
6147 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6148
6149         Support styling on native MS-Windows console
6150
6151         PR/24315
6152         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6153         on MS-Windows if $TERM is not defined.
6154
6155         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6156
6157         * posix-hdep.c (gdb_console_fputs):
6158         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6159         functions.
6160         * ui-file.h (gdb_console_fputs): Add prototype.
6161
6162         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6163         back to fputs only if the former returns zero.
6164
6165 2019-03-07  Tom Tromey  <tom@tromey.com>
6166
6167         * symmisc.c (print_symbol_bcache_statistics): Update.
6168         (print_objfile_statistics): Update.
6169         * symfile.c (allocate_symtab): Update.
6170         * stabsread.c: Don't include bcache.h.
6171         * psymtab.h (struct psymbol_bcache): Don't declare.
6172         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6173         (psymbol_bcache_init, psymbol_bcache_free)
6174         (psymbol_bcache_get_bcache): Don't declare.
6175         * psymtab.c (struct psymbol_bcache): Remove.
6176         (psymtab_storage::psymtab_storage): Update.
6177         (psymtab_storage::~psymtab_storage): Update.
6178         (psymbol_bcache_init, psymbol_bcache_free)
6179         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6180         (add_psymbol_to_bcache): Update.
6181         (allocate_psymtab): Update.
6182         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6183         macro_cache>: No longer pointers.
6184         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6185         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6186         * macrotab.c (macro_bcache): Update.
6187         * macroexp.c: Don't include bcache.h.
6188         * gdbtypes.c (check_types_worklist): Update.
6189         (types_deeply_equal): Remove TRY/CATCH.  Update.
6190         * elfread.c (elf_symtab_read): Update.
6191         * dwarf2read.c: Don't include bcache.h.
6192         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6193         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6194         (print_bcache_statistics, bcache_memory_used): Don't declare.
6195         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6196         methods.  Rename all data members.
6197         * bcache.c (struct bcache): Move to bcache.h.
6198         (bcache::expand_hash_table): Rename from expand_hash_table.
6199         (bcache): Remove.
6200         (bcache::insert): Rename from bcache_full.
6201         (bcache::compare): Rename from bcache_compare.
6202         (bcache_xmalloc): Remove.
6203         (bcache::~bcache): Rename from bcache_xfree.
6204         (bcache::print_statistics): Rename from print_bcache_statistics.
6205         (bcache::memory_used): Rename from bcache_memory_used.
6206
6207 2019-03-07  Pedro Alves  <palves@redhat.com>
6208
6209         * infrun.c (normal_stop): Also check for
6210         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6211
6212 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * f-lang.c (value_from_host_double): Moved to...
6215         * value.c (value_from_host_double): ...here.
6216         * value.h (value_from_host_double): Declare.
6217         * guile/scm-math.c (vlscm_convert_typed_number): Use
6218         value_from_host_double.
6219         (vlscm_convert_number): Likewise.
6220         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6221         * python/py-value.c (convert_value_from_python): Likewise.
6222
6223 2019-03-06  Tom Tromey  <tom@tromey.com>
6224
6225         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6226
6227 2019-03-06  Tom Tromey  <tom@tromey.com>
6228
6229         * utils.h (free_current_contents): Don't declare.
6230         * utils.c (free_current_contents): Remove.
6231
6232 2019-03-06  Tom Tromey  <tom@tromey.com>
6233
6234         * top.c (quit_force): Update.
6235         * main.c (captured_command_loop): Update.
6236         * common/new-op.c (operator new): Update.
6237         * common/common-exceptions.c (struct catcher)
6238         <save_cleanup_chain>: Remove member.
6239         (exceptions_state_mc_init): Update.
6240         (exception_try_scope_entry): Return nullptr.
6241         (exception_try_scope_exit, exception_rethrow)
6242         (throw_exception_sjlj, throw_exception_cxx): Update.
6243         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6244         (all_cleanups, do_cleanups, discard_cleanups)
6245         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6246         (restore_cleanups, restore_final_cleanups): Don't declare.
6247         (do_final_cleanups): Remove parameter.
6248         * common/cleanups.c (cleanup_chain, make_cleanup)
6249         (make_cleanup_dtor, all_cleanups, do_cleanups)
6250         (discard_my_cleanups, discard_cleanups)
6251         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6252         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6253         (null_cleanup): Remove.
6254         (do_final_cleanups): Remove parameter.
6255
6256 2019-03-06  Tom Tromey  <tom@tromey.com>
6257
6258         * remote.c (remote_target::remote_parse_stop_reply): Use
6259         unique_xmalloc_ptr.
6260
6261 2019-03-06  Tom Tromey  <tom@tromey.com>
6262
6263         * stabsread.c (struct stabs_field_info): Rename from field_info.
6264         <list, fnlist>: Add initializers.
6265         <obstack>: New member.
6266         (read_member_functions, read_struct_fields, read_baseclasses):
6267         Allocate on obstack.  Don't use cleanups.
6268         (read_one_struct_field, read_member_functions, read_struct_fields)
6269         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6270         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6271         (read_struct_type): Update.
6272
6273 2019-03-06  Tom Tromey  <tom@tromey.com>
6274
6275         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6276         * common/filestuff.h (make_cleanup_close): Don't declare.
6277         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6278         Remove.
6279
6280 2019-03-06  Tom Tromey  <tom@tromey.com>
6281
6282         * solib-aix.c: Use make_scope_exit.
6283
6284 2019-03-06  Tom Tromey  <tom@tromey.com>
6285
6286         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6287         Use make_scope_exit.
6288
6289 2019-03-06  Tom Tromey  <tom@tromey.com>
6290
6291         * solib-svr4.c (disable_probes_interface): Remove parameter.
6292         (svr4_handle_solib_event): Use make_scope_exit.
6293
6294 2019-03-06  Tom Tromey  <tom@tromey.com>
6295
6296         * remote.c (struct stop_reply_deleter): Remove.
6297         (stop_reply_up): Update.
6298         (struct stop_reply): Derive from notif_event.  Don't typedef.
6299         <regcache>: Now a std::vector.
6300         (stop_reply_xfree): Remove.
6301         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6302         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6303         (remote_target::discard_pending_stop_replies): Use delete.
6304         (remote_target::remote_parse_stop_reply): Update.
6305         (remote_target::process_stop_reply): Update.
6306         * remote-notif.h (struct notif_event): Add virtual destructor.
6307         Remove "dtr" member.
6308         (struct notif_client) <alloc_event>: Return a unique_ptr.
6309         (notif_event_xfree): Don't declare.
6310         (notif_event_up): New typedef.
6311         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6312         (notif_event_xfree, do_notif_event_xfree): Remove.
6313         (remote_notif_state_xfree): Update.
6314
6315 2019-03-06  Tom Tromey  <tom@tromey.com>
6316
6317         * infrun.c (displaced_step_clear_cleanup): Now a
6318         forward_scope_exit type.
6319         (displaced_step_prepare_throw): Update.
6320         (displaced_step_fixup): Update.
6321
6322 2019-03-06  Tom Tromey  <tom@tromey.com>
6323
6324         * inferior.h (class inferior): Update comment.
6325         * gdbthread.h (class thread_info): Update comment.
6326
6327 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6328             Tom Tromey  <tom@tromey.com>
6329
6330         * stabsread.h (struct stab_section_list): Remove.
6331         (coffstab_build_psymtabs): Update.
6332         * dbxread.c (symbuf_sections): Now a std::vector.
6333         (sect_idx): New global.
6334         (fill_symbuf): Update.
6335         (coffstab_build_psymtabs): Change type of stabsects parameter.
6336         Update.
6337         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6338         std::vector.
6339         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6340         (coff_locate_sections): Update.
6341         (coff_symfile_read): Remove cleanups.  Update.
6342         (init_stringtab): Add storage parameter.
6343         (free_stringtab, free_stringtab_cleanup): Remove.
6344         (init_lineno): Add storage parameter.
6345         (free_linetab, free_linetab_cleanup): Remove.
6346
6347 2019-03-06  Pedro Alves  <palves@redhat.com>
6348
6349         * linux-fork.c (fork_info::clobber_regs): Delete.
6350         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6351         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6352         comment.  Adjust.
6353         (scoped_switch_fork_info::scoped_switch_fork_info)
6354         (checkpoint_command, linux_fork_context): Adjust
6355         fork_save_infrun_state calls.
6356
6357 2019-03-06  Pedro Alves  <palves@redhat.com>
6358
6359         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6360         (inf_has_multiple_threads): Return 'bool' and rewrite using
6361         inferior_info::threads().
6362
6363 2019-03-06  Pedro Alves  <palves@redhat.com>
6364
6365         * linux-fork.c: Include <list>.
6366         (fork_list): Now a std::list instance.
6367         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6368         (forks_exist_p, find_last_fork): Adjust.
6369         (new_fork): Delete.
6370         (one_fork_p): New.
6371         (add_fork): Adjust.
6372         (free_fork): Delete, folded into fork_info::~fork_info().
6373         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6374         Adjust.
6375         (init_fork_list): Delete.
6376         (linux_fork_killall, linux_fork_mourn_inferior)
6377         (linux_fork_detach, info_checkpoints_command): Adjust.
6378         (_initialize_linux_fork): No longer call init_fork_list.
6379
6380 2019-03-06  Pedro Alves  <palves@redhat.com>
6381
6382         * linux-fork.c (new_fork): New, split out of ...
6383         (add_fork): ... this.  Return void.  Move "first fork" special
6384         case from here, to ...
6385         (checkpoint_command): ... here.
6386         * linux-linux.h (add_fork): Return void.
6387
6388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6391
6392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6393             Chris January  <chris.january@arm.com>
6394             David Lecomber  <david.lecomber@arm.com>
6395
6396         * f-exp.y: New token, UNOP_INTRINSIC.
6397         (exp): New pattern using UNOP_INTRINSIC token.
6398         (f77_keywords): Add 'abs' keyword.
6399         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6400         (value_from_host_double): New function.
6401         (evaluate_subexp_f): Support UNOP_ABS.
6402
6403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6406         types.
6407
6408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6411         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6412         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6413
6414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6417
6418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6419             Chris January  <chris.january@arm.com>
6420
6421         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6422         * f-exp.y: Define 'KIND' token.
6423         (exp): New pattern for KIND expressions.
6424         (ptype): Handle types with a kind extension.
6425         (direct_abs_decl): Extend to spot kind extensions.
6426         (f77_keywords): Add 'kind' to the list.
6427         (push_kind_type): New function.
6428         (convert_to_kind_type): New function.
6429         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6430         * parse.c (operator_length_standard): Likewise.
6431         * parser-defs.h (enum type_pieces): Add tp_kind.
6432         * std-operator.def: Add UNOP_KIND.
6433
6434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * f-exp.y (f_parse): Set yydebug.
6437
6438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * f-lang.c (evaluate_subexp_f): New function.
6441         (exp_descriptor_f): New global.
6442         (f_language_defn): Use exp_descriptor_f instead of
6443         exp_descriptor_standard.
6444
6445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6446
6447         * f-exp.y (struct token): Add comments.
6448         (dot_ops): Remove uppercase versions and the end marker.
6449         (f77_keywords): Likewise.
6450         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6451         entries in the dot_ops array are case insensitive, and use
6452         strncasecmp to compare strings.  Also some whitespace cleanup in
6453         this area.  Similar for the f77_keywords array, except entries in
6454         this list might be case sensitive.
6455
6456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * f-exp.y (struct f77_boolean_val): Add comments.
6459         (boolean_values): Remove uppercase versions, and end marker.
6460         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6461         and use strncasecmp to achieve case insensitivity.  Additionally,
6462         perform whitespace cleanup around this code.
6463
6464 2019-03-06  Tom Tromey  <tromey@adacore.com>
6465
6466         * remote-sim.c (gdbsim_target_open): Use result of
6467         gdb_argv::release.
6468
6469 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6470         Dirk Schubert  <dirk.schubert@arm.com>
6471         Chris January  <chris.january@arm.com>
6472
6473         * eval.c (evaluate_subexp_standard): Call Fortran argument
6474         wrapping logic.
6475         * f-lang.c (struct value): A value which can be passed into a
6476         Fortran function call.
6477         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6478         where appropriate.
6479         (struct type): Value ready for a Fortran function call.
6480         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6481         is needed.
6482         * f-lang.h (fortran_argument_convert): Declaration.
6483         (fortran_preserve_arg_pointer): Declaration.
6484         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6485
6486 2019-03-05  Tom Tromey  <tromey@adacore.com>
6487
6488         * python/py-prettyprint.c (print_string_repr): Remove #if.
6489         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6490
6491 2019-03-05  Tom Tromey  <tromey@adacore.com>
6492
6493         * target.c (the_dummy_target): Move later.  Change type to
6494         "dummy_target".
6495         (initialize_targets): Don't initialize the_dummy_target.
6496
6497 2019-03-05  Tom Tromey  <tromey@adacore.com>
6498
6499         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6500         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6501
6502 2019-03-05  Tom Tromey  <tromey@adacore.com>
6503
6504         * windows-nat.c (windows_nat_target::attach)
6505         (windows_nat_target::detach): Don't call gdb_flush.
6506         * valprint.c (generic_val_print, val_print, val_print_string):
6507         Don't call gdb_flush.
6508         * utils.c (defaulted_query): Don't call gdb_flush.
6509         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6510         * target.c (target_announce_detach): Don't call gdb_flush.
6511         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6512         * remote.c (extended_remote_target::attach): Don't call
6513         gdb_flush.
6514         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6515         * printcmd.c (do_examine): Don't call gdb_flush.
6516         (info_display_command): Don't call gdb_flush.
6517         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6518         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6519         * memattr.c (info_mem_command): Don't call gdb_flush.
6520         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6521         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6522         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6523         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6524         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6525         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6526         (gnu_nat_target::detach): Don't call gdb_flush.
6527         * f-valprint.c (f_val_print): Don't call gdb_flush.
6528         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6529         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6530         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6531         gdb_flush.
6532         * c-valprint.c (c_val_print): Don't call gdb_flush.
6533         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6534
6535 2019-03-05  Tom Tromey  <tromey@adacore.com>
6536
6537         * varobj.c (update_dynamic_varobj_children): Update.
6538         (install_default_visualizer): Use reset, not release.
6539         * value.c (set_internalvar): Update.
6540         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6541         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6542         ATTRIBUTE_UNUSED_RESULT.
6543
6544 2019-03-05  Tom Tromey  <tromey@adacore.com>
6545
6546         * remote.c (class scoped_remote_fd) <release>: Add
6547         ATTRIBUTE_UNUSED_RESULT.
6548
6549 2019-03-05  Tom Tromey  <tromey@adacore.com>
6550
6551         * macroexp.c (struct macro_buffer) <release>: Add
6552         ATTRIBUTE_UNUSED_RESULT.
6553
6554 2019-03-05  Tom Tromey  <tromey@adacore.com>
6555
6556         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6557         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6558         ATTRIBUTE_UNUSED_RESULT.
6559
6560 2019-03-05  Tom Tromey  <tromey@adacore.com>
6561
6562         * common/scoped_fd.h (class scoped_fd) <release>: Add
6563         ATTRIBUTE_UNUSED_RESULT.
6564
6565 2019-03-05  Tom Tromey  <tromey@adacore.com>
6566
6567         * parser-defs.h (struct parser_state) <release>: Add
6568         ATTRIBUTE_UNUSED_RESULT.
6569
6570 2019-03-05  Tom Tromey  <tromey@adacore.com>
6571
6572         * utils.h (class gdb_argv) <release>: Add
6573         ATTRIBUTE_UNUSED_RESULT.
6574         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6575
6576 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6577
6578         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6579         for-loop range, to avoid compiler warnings.
6580
6581         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6582         avoid compiler warnings about unused variables.
6583
6584         * NEWS: Mention end of support for native debugging on MS-Windows
6585         before XP.
6586
6587         PR gdb/24292
6588         * common/netstuff.c:
6589         * gdbserver/gdbreplay.c
6590         * gdbserver/remote-utils.c:
6591         * ser-tcp.c:
6592         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6593         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6594         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6595         'getaddrinfo' and 'freeaddrinfo' were not available before
6596         Windows XP, and mingw.org's MinGW headers by default define
6597         _WIN32_WINNT to 0x500.
6598
6599 2019-03-01  Gary Benson <gbenson@redhat.com>
6600
6601         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6602
6603 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6604             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6605
6606         PR gdb/8527
6607         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6608         set_sigint_trap, clear_sigint_trap.
6609
6610 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6611
6612         * target.c (target_detach): Clear the regcache and the
6613         frame cache.
6614
6615 2019-02-27  Pedro Alves  <palves@redhat.com>
6616
6617         * utils.c (set_screen_size): When we cap the height/width sizes,
6618         tweak the corresponding command variable to show "unlimited":
6619
6620 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6621             Pedro Alves  <palves@redhat.com>
6622
6623         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6624         before calling rl_set_screen_size.
6625
6626 2019-02-27  Tom Tromey  <tromey@adacore.com>
6627
6628         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6629         define.
6630         * python/py-value.c: Remove Python 2.4 workaround.
6631         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6632         workaround.
6633         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6634         Python 2.4 workaround.
6635         * python/python-internal.h: Remove Python 2.4 comment.
6636         (Py_ssize_t): Don't define.
6637         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6638         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6639         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6640         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6641         * python/python.c (do_start_initialization): Remove Python 2.4
6642         workaround.
6643         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6644         (print_children): Remove Python 2.4 workaround.
6645         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6646         workaround.
6647         (CHARBUFFERPROC_NAME): Remove.
6648         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6649         Python 2.4 workaround.
6650
6651 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6652
6653         * NEWS: Note minimum Python version.
6654
6655 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6656
6657         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6658         code from these functions.  Remove corresponding ifdefs.  Use
6659         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6660         Remove gotos and target of gotos.
6661         (infpy_search_memory): Likewise.
6662
6663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6664
6665         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6666         (hppa_gdbarch_init): Don't register deleted functions with
6667         gdbarch.
6668
6669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6670
6671         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6672         (h8300_unwind_sp): Delete.
6673         (h8300_dummy_id): Delete.
6674         (h8300_gdbarch_init): Don't register deleted functions with
6675         gdbarch.
6676
6677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6678
6679         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6680         (ft32_unwind_pc): Delete.
6681         (ft32_unwind_sp): Delete.
6682         (ft32_gdbarch_init): Don't register deleted functions with
6683         gdbarch.
6684
6685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6686
6687         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6688         (frv_unwind_pc): Delete.
6689         (frv_unwind_sp): Delete.
6690         (frv_gdbarch_init): Don't register deleted functions with
6691         gdbarch.
6692
6693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6694
6695         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6696         (riscv_unwind_pc): Delete.
6697         (riscv_unwind_sp): Delete.
6698         (riscv_gdbarch_init): Don't register deleted functions with
6699         gdbarch.
6700
6701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6702
6703         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6704         (csky_unwind_pc): Delete.
6705         (csky_unwind_sp): Delete.
6706         (csky_gdbarch_init): Don't register deleted functions with
6707         gdbarch.
6708
6709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6710
6711         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6712         (cris_unwind_pc): Delete.
6713         (cris_unwind_sp): Delete.
6714         (cris_gdbarch_init): Don't register deleted functions with
6715         gdbarch.
6716
6717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6720         (bfin_unwind_pc): Delete.
6721         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6722
6723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6724
6725         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6726         (arm_unwind_pc): Delete.
6727         (arm_unwind_sp): Delete.
6728         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6729
6730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6733         (arc_unwind_pc): Delete.
6734         (arc_unwind_sp): Delete.
6735         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6736
6737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6738
6739         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6740         (alpha_unwind_pc): Delete.
6741         (alpha_gdbarch_init): Don't register deleted functions with
6742         gdbarch.
6743
6744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6745
6746         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6747         (aarch64_unwind_pc): Delete.
6748         (aarch64_unwind_sp): Delete.
6749         (aarch64_gdbarch_init): Don't register deleted functions with
6750         gdbarch.
6751
6752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * gdbtypes.c (type_align): Don't consider static members when
6755         computing structure alignment.
6756
6757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6760         return 0 for other types.
6761         * arch-utils.c (default_type_align): Always return 0.
6762         * gdbarch.h: Regenerate.
6763         * gdbarch.sh (type_align): Extend comment.
6764         * gdbtypes.c (type_align): Add additional comments, always call
6765         gdbarch_type_align before applying the default rules.
6766         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6767         generic code will then apply a suitable default.
6768         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6769         types, return 0 for other types.
6770
6771 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6772
6773         * NEWS: Create a new section for the next release branch.
6774         Rename the section of the current branch, now that it has
6775         been cut.
6776
6777 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6778
6779         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6780         * version.in: Bump version to 8.3.50.DATE-git.
6781
6782 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6783
6784         * aix-thread.c (ptid_cmp): Remove unused variable.
6785         (get_signaled_thread): Likewise.
6786         (store_regs_user_thread): Likewise.
6787         (store_regs_kernel_thread): Likewise.
6788         (fetch_regs_kernel_thread): Remove shadowed variable.
6789
6790 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * features/riscv/32bit-cpu.xml: Add register numbers.
6793         * features/riscv/32bit-fpu.c: Regenerate.
6794         * features/riscv/32bit-fpu.xml: Add register numbers.
6795         * features/riscv/64bit-cpu.xml: Add register numbers.
6796         * features/riscv/64bit-fpu.c: Regenerate.
6797         * features/riscv/64bit-fpu.xml: Add register numbers.
6798
6799 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6800
6801         * NEWS: Mention two argument form of gdb.Value constructor.
6802         * python/py-value.c (convert_buffer_and_type_to_value): New
6803         function.
6804         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6805         Add support for handling an optional second argument.  Call
6806         convert_buffer_and_type_to_value as appropriate.
6807         * python/python-internal.h (Py_buffer_deleter): New struct.
6808         (Py_buffer_up): New typedef.
6809
6810 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6811
6812         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6813         instead of releasing ownership.
6814
6815 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6816
6817         * dwarf2read.c (open_and_init_dwp_file): Call
6818         elf_numsections instead of bfd_count_sections to initialize
6819         dwp_file->num_sections.
6820
6821 2019-02-25  Tom Tromey  <tromey@adacore.com>
6822
6823         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6824
6825 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6826
6827         * gcore.in: Add '--readnever' option when invoking GDB.
6828
6829 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6830
6831         * MAINTAINERS: Update my email address.
6832
6833 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6834
6835         * build-id.c (build_id_to_debug_bfd_1): New function.
6836         (build_id_to_debug_bfd): Look for separate debug file in
6837         sysroot.
6838
6839 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6840
6841         * gdbarch.sh: Update the copyright year range that is placed into
6842         generated files.
6843
6844 2019-02-22  Keith Seitz  <keiths@redhat.com>
6845
6846         PR symtab/23853
6847         * linespec.c (create_sals_line_offset): Search for the default
6848         symtab's filename instead of its fullname.
6849
6850 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6851
6852         * NEWS: Update style defaults.
6853
6854 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6855
6856         * main.c (captured_main_1): Disable styling in batch mode.
6857
6858 2019-02-20  Tom Tromey  <tom@tromey.com>
6859
6860         * symtab.c (symtab_symbol_info): Fix typos.
6861
6862 2019-02-20  Tom Tromey  <tromey@adacore.com>
6863
6864         * findcmd.c (_initialize_mem_search): Use upper case for
6865         metasyntactic variables.
6866
6867 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6868
6869         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6870         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6871
6872 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6873
6874         * top.h (source_file_name): Change to std::string.
6875         * top.c (source_file_name): Likewise.
6876         (command_line_input): Adjust.
6877         * cli/cli-script.c (script_from_file): Adjust.
6878
6879 2019-02-19  Tom Tromey  <tromey@adacore.com>
6880
6881         * ravenscar-thread.c
6882         (ravenscar_thread_target::update_thread_list): Don't call
6883         ada_build_task_list.
6884         * ada-lang.h (ada_build_task_list): Don't declare.
6885         * ada-tasks.c (struct ada_tasks_inferior_data)
6886         <task_list_valid_p>: Now bool.
6887         (read_known_tasks, ada_task_list_changed)
6888         (ada_tasks_invalidate_inferior_data): Update.
6889         (read_known_tasks_array): Return bool.
6890         (read_known_tasks_list): Likewise.
6891         (read_known_tasks): Return void.
6892         (ada_build_task_list): Now static.
6893
6894 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6897         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6898
6899 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6900
6901         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6902         variant for ada_tasks_pspace_data_handle and
6903         ada_tasks_inferior_data_handle.
6904         (ada_tasks_pspace_data_cleanup): New function.
6905         (ada_tasks_inferior_data_cleanup): New function.
6906
6907 2019-02-17  Tom Tromey  <tom@tromey.com>
6908
6909         * macrotab.h (macro_source_fullname): Return a std::string.
6910         * macrotab.c (macro_include, check_for_redefinition)
6911         (macro_undef, macro_lookup_definition, foreach_macro)
6912         (foreach_macro_in_scope): Update.
6913         (macro_source_fullname): Return a std::string.
6914         * macrocmd.c (show_pp_source_pos): Update.
6915
6916 2019-02-17  Tom Tromey  <tom@tromey.com>
6917
6918         * macrocmd.c (show_pp_source_pos): Style the file names.
6919
6920 2019-02-17  Tom Tromey  <tom@tromey.com>
6921
6922         PR tui/24197:
6923         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6924
6925 2019-02-17  Tom Tromey  <tom@tromey.com>
6926
6927         * ada-lang.c (user_select_syms): Use filtered printing.
6928         * utils.c (wrap_style): New global.
6929         (desired_style): Remove.
6930         (emit_style_escape): Add stream parameter.
6931         (set_output_style, reset_terminal_style, prompt_for_continue):
6932         Update.
6933         (flush_wrap_buffer): Only flush gdb_stdout.
6934         (wrap_here): Set wrap_style.
6935         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6936         treat escape sequences as a character.  Change when wrap buffer is
6937         flushed.
6938         (fputs_styled): Do not set the output style when the default is
6939         requested.
6940         * ui-style.h (struct ui_file_style) <is_default>: New method.
6941         * source.c (print_source_lines_base): Emit escape sequences in one
6942         piece.
6943
6944 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6945
6946         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6947         integers and enumeration types.
6948
6949 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6950
6951         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6952         instead of lookup_symbol_in_language
6953         (do_exact_match): New function.
6954         (ada_get_symbol_name_matcher): Return do_exact_match when
6955         doing a verbatim match.
6956
6957 2019-02-15  Tom Tromey  <tromey@adacore.com>
6958
6959         * ravenscar-thread.c (ravenscar_thread_target::resume)
6960         (ravenscar_thread_target::wait): Special case wildcard requests.
6961
6962 2019-02-15  Tom Tromey  <tromey@adacore.com>
6963
6964         * ravenscar-thread.c (base_ptid): Remove.
6965         (struct ravenscar_thread_target) <close>: New method.
6966         <m_base_ptid>: New member.
6967         <update_inferior_ptid, active_task, task_is_currently_active,
6968         runtime_initialized>: Declare methods.
6969         <ravenscar_thread_target>: Add constructor.
6970         (ravenscar_thread_target::task_is_currently_active)
6971         (ravenscar_thread_target::update_inferior_ptid)
6972         (ravenscar_runtime_initialized): Rename.  Now methods.
6973         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6974         (ravenscar_thread_target::update_thread_list): Update.
6975         (ravenscar_thread_target::active_task): Now method.
6976         (ravenscar_thread_target::store_registers)
6977         (ravenscar_thread_target::prepare_to_store)
6978         (ravenscar_thread_target::prepare_to_store)
6979         (ravenscar_thread_target::mourn_inferior): Update.
6980         (ravenscar_inferior_created): Use "new" to create target.
6981         (ravenscar_thread_target::get_ada_task_ptid): Update.
6982         (_initialize_ravenscar): Don't initialize base_ptid.
6983         (ravenscar_ops): Remove global.
6984
6985 2019-02-15  Tom Tromey  <tromey@adacore.com>
6986
6987         * target.h (push_target): Declare new overload.
6988         * target.c (push_target): New overload, taking an rvalue reference.
6989         * remote.c (remote_target::open_1): Use push_target overload.
6990         * corelow.c (core_target_open): Use push_target overload.
6991
6992 2019-02-15  Tom Tromey  <tromey@adacore.com>
6993
6994         * ravenscar-thread.c (is_ravenscar_task)
6995         (ravenscar_task_is_currently_active): Return bool.
6996         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6997         (_initialize_ravenscar): Remove "(void)".
6998         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6999         Return bool.
7000
7001 2019-02-15  Tom Tromey  <tromey@adacore.com>
7002
7003         * ravenscar-thread.c (ravenscar_runtime_initializer)
7004         (has_ravenscar_runtime, get_running_thread_id)
7005         (ravenscar_thread_target::resume): Fix indentation.
7006
7007 2019-02-15  Tom Tromey  <tromey@adacore.com>
7008
7009         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7010         from ravenscar_arch_ops.
7011         (sparc_ravenscar_ops::fetch_registers)
7012         (sparc_ravenscar_ops::store_registers): Now methods.
7013         (sparc_ravenscar_prepare_to_store): Remove.
7014         (sparc_ravenscar_ops): Redefine.
7015         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7016         methods and destructor.  Remove members.
7017         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7018         (ravenscar_thread_target::store_registers)
7019         (ravenscar_thread_target::prepare_to_store): Update.
7020         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7021         Remove.
7022         (struct ppc_ravenscar_powerpc_ops): Derive from
7023         ravenscar_arch_ops.
7024         (ppc_ravenscar_powerpc_ops::fetch_registers)
7025         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7026         (ppc_ravenscar_powerpc_ops): Redefine.
7027         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7028         (ppc_ravenscar_e500_ops::fetch_registers)
7029         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7030         (ppc_ravenscar_e500_ops): Redefine.
7031         * aarch64-ravenscar-thread.c
7032         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7033         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7034         (aarch64_ravenscar_fetch_registers)
7035         (aarch64_ravenscar_store_registers): Now methods.
7036         (aarch64_ravenscar_ops): Redefine.
7037
7038 2019-02-15  Tom Tromey  <tromey@adacore.com>
7039
7040         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7041         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7042         (ravenscar_thread_target::stopped_by_watchpoint)
7043         (ravenscar_thread_target::stopped_data_address)
7044         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7045
7046 2019-02-15  Tom Tromey  <tromey@adacore.com>
7047
7048         * ravenscar-thread.c: Fix some typos.
7049
7050 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7051             Tom Tromey  <tromey@adacore.com>
7052
7053         * ada-lang.c (ada_exception_sal): Change addr_string to a
7054         std::string.
7055         (create_ada_exception_catchpoint): Update.
7056
7057 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7058             Tom Tromey  <tromey@adacore.com>
7059
7060         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7061         (bp_location_ops): Remove.
7062         (base_breakpoint_allocate_location): Update.
7063         (free_bp_location): Update.
7064         * ada-lang.c (class ada_catchpoint_location)
7065         <ada_catchpoint_location>: Remove ops parameter.
7066         (ada_catchpoint_location_dtor): Remove.
7067         (ada_catchpoint_location_ops): Remove.
7068         (allocate_location_exception): Update.
7069         * breakpoint.h (struct bp_location_ops): Remove.
7070         (class bp_location) <bp_location>: Remove bp_location_ops
7071         parameter.
7072         <~bp_location>: Add destructor.
7073         <ops>: Remove.
7074
7075 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7076             Pedro Alves  <palves@redhat.com>
7077
7078         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7079         'PATH_MAX'.
7080
7081 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7082             Samuel Thibault  <samuel.thibault@gnu.org>
7083             Thomas Schwinge  <thomas@codesourcery.com>
7084
7085         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7086         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7087
7088 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7089
7090         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7091         (check_empty): Use "const char *".
7092
7093         * gnu-nat.c (gnu_nat_target::detach): Instead of
7094         'detach_inferior (pid)' call
7095         'detach_inferior (find_inferior_pid (pid))'.
7096
7097         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7098         'nat/fork-inferior.o'.
7099         * gnu-nat.c: #include "nat/fork-inferior.h".
7100
7101         * gnu-nat.c (gnu_nat_target::detach): Instead of
7102         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7103         * gnu-nat.h: #include "inf-child.h".
7104         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7105         'i386_gnu_nat_target::fetch_registers'.
7106         (gnu_store_registers): Rename/move to
7107         'i386_gnu_nat_target::store_registers'.
7108
7109         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7110         * gnu-nat.h (mach_thread_info): New function.
7111         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7112
7113         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7114
7115 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7116
7117         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7118
7119 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7120
7121         * windows-nat.c (windows_add_thread): Add new parameter
7122         "main_thread_p" with default value set to false.  Update
7123         function documentation as well as all callers.
7124         (windows_delete_thread): Likewise.
7125         (fake_create_process): Update call to windows_add_thread.
7126         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7127         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7128         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7129         call to windows_delete_thread.
7130
7131 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7132
7133         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7134
7135 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7136
7137         * symfile.c (find_separate_debug_file): Use canonical path of
7138         sysroot with child_path instead of gdb_sysroot if it is valid.
7139
7140 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7141
7142         * symfile.c (find_separate_debug_file): Use child_path to
7143         determine if an object file is under a sysroot.
7144
7145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7146
7147         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7148         unittests/child-path-selftests.c.
7149         * common/pathstuff.c (child_path): New function.
7150         * common/pathstuff.h (child_path): New prototype.
7151         * unittests/child-path-selftests.c: New file.
7152
7153 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7154
7155         * symfile.c (find_separate_debug_file): Look for separate debug
7156         files in debug directories under the sysroot.
7157
7158 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7159
7160         * symtab.h (struct minimal_symbol data_p): New const method.
7161         (struct minimal_symbol text_p): Likewise.
7162         * symtab.c (output_source_filename): Use file name style
7163         to print file name.
7164         (print_symbol_info): Likewise.
7165         (print_msymbol_info): Use address style to print addresses.
7166         Use function name style to print executable text symbols.
7167         (expand_symtab_containing_pc): Use data_p.
7168         (find_pc_sect_compunit_symtab): Likewise.
7169
7170 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7171
7172         * breakpoint.c (describe_other_breakpoints): Use address style
7173         to print addresses.
7174         (say_where): Likewise.
7175
7176 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7177
7178         * ada-typeprint.c (print_func_type): Print function name
7179         style to print function name.
7180         * c-typeprint.c (c_print_type_1): Likewise.
7181
7182 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7183
7184         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7185         for execve.
7186
7187 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7188
7189         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7190         type_stack.
7191
7192 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7193
7194         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7195         TYPE_CODE_REF types.
7196
7197 2019-02-08  Jim Wilson  <jimw@sifive.com>
7198
7199         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7200         (riscv_linux_fregset): New.
7201         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7202
7203 2019-02-07  Tom Tromey  <tom@tromey.com>
7204
7205         * thread.c (thread_cancel_execution_command): Update.
7206         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7207         methods.
7208         (struct thread_fsm_ops): Remove.
7209         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7210         (thread_fsm_should_stop, thread_fsm_return_value)
7211         (thread_fsm_set_finished, thread_fsm_finished_p)
7212         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7213         Don't declare.
7214         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7215         * infrun.c (clear_proceed_status_thread)
7216         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7217         (print_stop_event): Update.
7218         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7219         Add constructor.
7220         (step_command_fsm_ops): Remove.
7221         (new_step_command_fsm): Remove.
7222         (step_1): Update.
7223         (step_command_fsm::should_stop): Rename from
7224         step_command_fsm_should_stop.
7225         (step_command_fsm::clean_up): Rename from
7226         step_command_fsm_clean_up.
7227         (step_command_fsm::do_async_reply_reason): Rename from
7228         step_command_fsm_async_reply_reason.
7229         (struct until_next_fsm): Inherit from thread_fsm.  Add
7230         constructor.
7231         (until_next_fsm_ops): Remove.
7232         (new_until_next_fsm): Remove.
7233         (until_next_fsm::should_stop): Rename from
7234         until_next_fsm_should_stop.
7235         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7236         (until_next_fsm::do_async_reply_reason): Rename from
7237         until_next_fsm_async_reply_reason.
7238         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7239         constructor.  Change type of breakpoint.
7240         (finish_command_fsm_ops): Remove.
7241         (new_finish_command_fsm): Remove.
7242         (finish_command_fsm::should_stop): Rename from
7243         finish_command_fsm_should_stop.
7244         (finish_command_fsm::clean_up): Rename from
7245         finish_command_fsm_clean_up.
7246         (finish_command_fsm::return_value): Rename from
7247         finish_command_fsm_return_value.
7248         (finish_command_fsm::do_async_reply_reason): Rename from
7249         finish_command_fsm_async_reply_reason.
7250         (finish_command): Update.
7251         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7252         Add constructor.
7253         (call_thread_fsm_ops): Remove.
7254         (call_thread_fsm::call_thread_fsm): Rename from
7255         new_call_thread_fsm.
7256         (call_thread_fsm::should_stop): Rename from
7257         call_thread_fsm_should_stop.
7258         (call_thread_fsm::should_notify_stop): Rename from
7259         call_thread_fsm_should_notify_stop.
7260         (run_inferior_call, call_function_by_hand_dummy): Update.
7261         * cli/cli-interp.c (should_print_stop_to_console): Update.
7262         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7263         Add constructor.  Change type of location_breakpoint,
7264         caller_breakpoint.
7265         (until_break_fsm_ops): Remove.
7266         (new_until_break_fsm): Remove.
7267         (until_break_fsm::should_stop): Rename from
7268         until_break_fsm_should_stop.
7269         (until_break_fsm::clean_up): Rename from
7270         until_break_fsm_clean_up.
7271         (until_break_fsm::do_async_reply_reason): Rename from
7272         until_break_fsm_async_reply_reason.
7273         (until_break_command): Update.
7274         * thread-fsm.c: Remove.
7275         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7276
7277 2019-02-07  Tom Tromey  <tom@tromey.com>
7278
7279         * yy-remap.h: Add include guard.
7280         * xtensa-tdep.h: Add include guard.
7281         * xcoffread.h: Rename include guard.
7282         * varobj-iter.h: Add include guard.
7283         * tui/tui.h: Rename include guard.
7284         * tui/tui-winsource.h: Rename include guard.
7285         * tui/tui-wingeneral.h: Rename include guard.
7286         * tui/tui-windata.h: Rename include guard.
7287         * tui/tui-win.h: Rename include guard.
7288         * tui/tui-stack.h: Rename include guard.
7289         * tui/tui-source.h: Rename include guard.
7290         * tui/tui-regs.h: Rename include guard.
7291         * tui/tui-out.h: Rename include guard.
7292         * tui/tui-layout.h: Rename include guard.
7293         * tui/tui-io.h: Rename include guard.
7294         * tui/tui-hooks.h: Rename include guard.
7295         * tui/tui-file.h: Rename include guard.
7296         * tui/tui-disasm.h: Rename include guard.
7297         * tui/tui-data.h: Rename include guard.
7298         * tui/tui-command.h: Rename include guard.
7299         * tic6x-tdep.h: Add include guard.
7300         * target/waitstatus.h: Rename include guard.
7301         * target/wait.h: Rename include guard.
7302         * target/target.h: Rename include guard.
7303         * target/resume.h: Rename include guard.
7304         * target-float.h: Rename include guard.
7305         * stabsread.h: Add include guard.
7306         * rs6000-tdep.h: Add include guard.
7307         * riscv-fbsd-tdep.h: Add include guard.
7308         * regformats/regdef.h: Rename include guard.
7309         * record.h: Rename include guard.
7310         * python/python.h: Rename include guard.
7311         * python/python-internal.h: Rename include guard.
7312         * python/py-stopevent.h: Rename include guard.
7313         * python/py-ref.h: Rename include guard.
7314         * python/py-record.h: Rename include guard.
7315         * python/py-record-full.h: Rename include guard.
7316         * python/py-record-btrace.h: Rename include guard.
7317         * python/py-instruction.h: Rename include guard.
7318         * python/py-events.h: Rename include guard.
7319         * python/py-event.h: Rename include guard.
7320         * procfs.h: Add include guard.
7321         * proc-utils.h: Add include guard.
7322         * p-lang.h: Add include guard.
7323         * or1k-tdep.h: Rename include guard.
7324         * observable.h: Rename include guard.
7325         * nto-tdep.h: Rename include guard.
7326         * nat/x86-linux.h: Rename include guard.
7327         * nat/x86-linux-dregs.h: Rename include guard.
7328         * nat/x86-gcc-cpuid.h: Add include guard.
7329         * nat/x86-dregs.h: Rename include guard.
7330         * nat/x86-cpuid.h: Rename include guard.
7331         * nat/ppc-linux.h: Rename include guard.
7332         * nat/mips-linux-watch.h: Rename include guard.
7333         * nat/linux-waitpid.h: Rename include guard.
7334         * nat/linux-ptrace.h: Rename include guard.
7335         * nat/linux-procfs.h: Rename include guard.
7336         * nat/linux-osdata.h: Rename include guard.
7337         * nat/linux-nat.h: Rename include guard.
7338         * nat/linux-namespaces.h: Rename include guard.
7339         * nat/linux-btrace.h: Rename include guard.
7340         * nat/glibc_thread_db.h: Rename include guard.
7341         * nat/gdb_thread_db.h: Rename include guard.
7342         * nat/gdb_ptrace.h: Rename include guard.
7343         * nat/fork-inferior.h: Rename include guard.
7344         * nat/amd64-linux-siginfo.h: Rename include guard.
7345         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7346         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7347         * nat/aarch64-linux.h: Rename include guard.
7348         * nat/aarch64-linux-hw-point.h: Rename include guard.
7349         * mn10300-tdep.h: Add include guard.
7350         * mips-linux-tdep.h: Add include guard.
7351         * mi/mi-parse.h: Rename include guard.
7352         * mi/mi-out.h: Rename include guard.
7353         * mi/mi-main.h: Rename include guard.
7354         * mi/mi-interp.h: Rename include guard.
7355         * mi/mi-getopt.h: Rename include guard.
7356         * mi/mi-console.h: Rename include guard.
7357         * mi/mi-common.h: Rename include guard.
7358         * mi/mi-cmds.h: Rename include guard.
7359         * mi/mi-cmd-break.h: Rename include guard.
7360         * m2-lang.h: Add include guard.
7361         * location.h: Rename include guard.
7362         * linux-record.h: Rename include guard.
7363         * linux-nat.h: Add include guard.
7364         * linux-fork.h: Add include guard.
7365         * i386-darwin-tdep.h: Rename include guard.
7366         * hppa-linux-offsets.h: Add include guard.
7367         * guile/guile.h: Rename include guard.
7368         * guile/guile-internal.h: Rename include guard.
7369         * gnu-nat.h: Rename include guard.
7370         * gdb-stabs.h: Rename include guard.
7371         * frv-tdep.h: Add include guard.
7372         * f-lang.h: Add include guard.
7373         * event-loop.h: Add include guard.
7374         * darwin-nat.h: Rename include guard.
7375         * cp-abi.h: Rename include guard.
7376         * config/sparc/nm-sol2.h: Rename include guard.
7377         * config/nm-nto.h: Rename include guard.
7378         * config/nm-linux.h: Add include guard.
7379         * config/i386/nm-i386gnu.h: Rename include guard.
7380         * config/djgpp/nl_types.h: Rename include guard.
7381         * config/djgpp/langinfo.h: Rename include guard.
7382         * compile/gcc-cp-plugin.h: Add include guard.
7383         * compile/gcc-c-plugin.h: Add include guard.
7384         * compile/compile.h: Rename include guard.
7385         * compile/compile-object-run.h: Rename include guard.
7386         * compile/compile-object-load.h: Rename include guard.
7387         * compile/compile-internal.h: Rename include guard.
7388         * compile/compile-cplus.h: Rename include guard.
7389         * compile/compile-c.h: Rename include guard.
7390         * common/xml-utils.h: Rename include guard.
7391         * common/x86-xstate.h: Rename include guard.
7392         * common/version.h: Rename include guard.
7393         * common/vec.h: Rename include guard.
7394         * common/tdesc.h: Rename include guard.
7395         * common/selftest.h: Rename include guard.
7396         * common/scoped_restore.h: Rename include guard.
7397         * common/scoped_mmap.h: Rename include guard.
7398         * common/scoped_fd.h: Rename include guard.
7399         * common/safe-iterator.h: Rename include guard.
7400         * common/run-time-clock.h: Rename include guard.
7401         * common/refcounted-object.h: Rename include guard.
7402         * common/queue.h: Rename include guard.
7403         * common/ptid.h: Rename include guard.
7404         * common/print-utils.h: Rename include guard.
7405         * common/preprocessor.h: Rename include guard.
7406         * common/pathstuff.h: Rename include guard.
7407         * common/observable.h: Rename include guard.
7408         * common/netstuff.h: Rename include guard.
7409         * common/job-control.h: Rename include guard.
7410         * common/host-defs.h: Rename include guard.
7411         * common/gdb_wait.h: Rename include guard.
7412         * common/gdb_vecs.h: Rename include guard.
7413         * common/gdb_unlinker.h: Rename include guard.
7414         * common/gdb_unique_ptr.h: Rename include guard.
7415         * common/gdb_tilde_expand.h: Rename include guard.
7416         * common/gdb_sys_time.h: Rename include guard.
7417         * common/gdb_string_view.h: Rename include guard.
7418         * common/gdb_splay_tree.h: Rename include guard.
7419         * common/gdb_setjmp.h: Rename include guard.
7420         * common/gdb_ref_ptr.h: Rename include guard.
7421         * common/gdb_optional.h: Rename include guard.
7422         * common/gdb_locale.h: Rename include guard.
7423         * common/gdb_assert.h: Rename include guard.
7424         * common/filtered-iterator.h: Rename include guard.
7425         * common/filestuff.h: Rename include guard.
7426         * common/fileio.h: Rename include guard.
7427         * common/environ.h: Rename include guard.
7428         * common/common-utils.h: Rename include guard.
7429         * common/common-types.h: Rename include guard.
7430         * common/common-regcache.h: Rename include guard.
7431         * common/common-inferior.h: Rename include guard.
7432         * common/common-gdbthread.h: Rename include guard.
7433         * common/common-exceptions.h: Rename include guard.
7434         * common/common-defs.h: Rename include guard.
7435         * common/common-debug.h: Rename include guard.
7436         * common/cleanups.h: Rename include guard.
7437         * common/buffer.h: Rename include guard.
7438         * common/btrace-common.h: Rename include guard.
7439         * common/break-common.h: Rename include guard.
7440         * cli/cli-utils.h: Rename include guard.
7441         * cli/cli-style.h: Rename include guard.
7442         * cli/cli-setshow.h: Rename include guard.
7443         * cli/cli-script.h: Rename include guard.
7444         * cli/cli-interp.h: Rename include guard.
7445         * cli/cli-decode.h: Rename include guard.
7446         * cli/cli-cmds.h: Rename include guard.
7447         * charset-list.h: Add include guard.
7448         * buildsym-legacy.h: Rename include guard.
7449         * bfin-tdep.h: Add include guard.
7450         * ax.h: Rename include guard.
7451         * arm-linux-tdep.h: Add include guard.
7452         * arm-fbsd-tdep.h: Add include guard.
7453         * arch/xtensa.h: Rename include guard.
7454         * arch/tic6x.h: Add include guard.
7455         * arch/i386.h: Add include guard.
7456         * arch/arm.h: Rename include guard.
7457         * arch/arm-linux.h: Rename include guard.
7458         * arch/arm-get-next-pcs.h: Rename include guard.
7459         * arch/amd64.h: Add include guard.
7460         * arch/aarch64-insn.h: Rename include guard.
7461         * arch-utils.h: Rename include guard.
7462         * annotate.h: Add include guard.
7463         * amd64-darwin-tdep.h: Rename include guard.
7464         * aarch64-linux-tdep.h: Add include guard.
7465         * aarch64-fbsd-tdep.h: Add include guard.
7466         * aarch32-linux-nat.h: Add include guard.
7467
7468 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7469
7470         * macrotab.c (macro_define_internal): New function that
7471         factorizes macro_define_object_internal and macro_define_function
7472         code.
7473         (macro_define_object_internal): Use macro_define_internal.
7474         (macro_define_function): Likewise.
7475
7476 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7477
7478         * macrocmd.c (extract_identifier): Return
7479         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7480         callers.
7481
7482 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7483
7484         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7485
7486 2019-02-05  Tom Tromey  <tom@tromey.com>
7487
7488         * target.c (target_stack::unpush): Move assertion earlier.
7489
7490 2019-01-30  Tom Tromey  <tom@tromey.com>
7491
7492         PR python/23615:
7493         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7494         (gdbpy_parse_and_eval): Likewise.
7495         * python/python-internal.h (gdbpy_allow_threads): New class.
7496
7497 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7498
7499         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7500         (aarch64_fbsd_fpregmap): Move earlier.
7501         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7502         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7503         instead of individual calls to trad_frame_set_reg_addr.
7504         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7505         earlier.
7506         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7507         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7508         instead of individual calls to trad_frame_set_reg_addr.
7509
7510 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7511
7512         * CONTRIBUTE: Replace contribution list with wiki link.
7513
7514 2019-01-25  Tom Tromey  <tom@tromey.com>
7515
7516         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7517
7518 2019-01-25  Tom Tromey  <tom@tromey.com>
7519
7520         * xtensa-linux-nat.c: Fix common/ includes.
7521         * xml-support.h: Fix common/ includes.
7522         * xml-support.c: Fix common/ includes.
7523         * x86-linux-nat.c: Fix common/ includes.
7524         * windows-nat.c: Fix common/ includes.
7525         * varobj.h: Fix common/ includes.
7526         * varobj.c: Fix common/ includes.
7527         * value.c: Fix common/ includes.
7528         * valops.c: Fix common/ includes.
7529         * utils.c: Fix common/ includes.
7530         * unittests/xml-utils-selftests.c: Fix common/ includes.
7531         * unittests/utils-selftests.c: Fix common/ includes.
7532         * unittests/unpack-selftests.c: Fix common/ includes.
7533         * unittests/tracepoint-selftests.c: Fix common/ includes.
7534         * unittests/style-selftests.c: Fix common/ includes.
7535         * unittests/string_view-selftests.c: Fix common/ includes.
7536         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7537         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7538         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7539         * unittests/rsp-low-selftests.c: Fix common/ includes.
7540         * unittests/parse-connection-spec-selftests.c: Fix common/
7541         includes.
7542         * unittests/optional-selftests.c: Fix common/ includes.
7543         * unittests/offset-type-selftests.c: Fix common/ includes.
7544         * unittests/observable-selftests.c: Fix common/ includes.
7545         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7546         * unittests/memrange-selftests.c: Fix common/ includes.
7547         * unittests/memory-map-selftests.c: Fix common/ includes.
7548         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7549         * unittests/function-view-selftests.c: Fix common/ includes.
7550         * unittests/environ-selftests.c: Fix common/ includes.
7551         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7552         * unittests/common-utils-selftests.c: Fix common/ includes.
7553         * unittests/cli-utils-selftests.c: Fix common/ includes.
7554         * unittests/array-view-selftests.c: Fix common/ includes.
7555         * ui-file.c: Fix common/ includes.
7556         * tui/tui-io.c: Fix common/ includes.
7557         * tracepoint.h: Fix common/ includes.
7558         * tracepoint.c: Fix common/ includes.
7559         * tracefile-tfile.c: Fix common/ includes.
7560         * top.h: Fix common/ includes.
7561         * top.c: Fix common/ includes.
7562         * thread.c: Fix common/ includes.
7563         * target/waitstatus.h: Fix common/ includes.
7564         * target/waitstatus.c: Fix common/ includes.
7565         * target.h: Fix common/ includes.
7566         * target.c: Fix common/ includes.
7567         * target-memory.c: Fix common/ includes.
7568         * target-descriptions.c: Fix common/ includes.
7569         * symtab.h: Fix common/ includes.
7570         * symfile.c: Fix common/ includes.
7571         * stap-probe.c: Fix common/ includes.
7572         * spu-linux-nat.c: Fix common/ includes.
7573         * sparc-nat.c: Fix common/ includes.
7574         * source.c: Fix common/ includes.
7575         * solib.c: Fix common/ includes.
7576         * solib-target.c: Fix common/ includes.
7577         * ser-unix.c: Fix common/ includes.
7578         * ser-tcp.c: Fix common/ includes.
7579         * ser-pipe.c: Fix common/ includes.
7580         * ser-base.c: Fix common/ includes.
7581         * selftest-arch.c: Fix common/ includes.
7582         * s12z-tdep.c: Fix common/ includes.
7583         * rust-exp.y: Fix common/ includes.
7584         * rs6000-aix-tdep.c: Fix common/ includes.
7585         * riscv-tdep.c: Fix common/ includes.
7586         * remote.c: Fix common/ includes.
7587         * remote-notif.h: Fix common/ includes.
7588         * remote-fileio.h: Fix common/ includes.
7589         * remote-fileio.c: Fix common/ includes.
7590         * regcache.h: Fix common/ includes.
7591         * regcache.c: Fix common/ includes.
7592         * record-btrace.c: Fix common/ includes.
7593         * python/python.c: Fix common/ includes.
7594         * python/py-type.c: Fix common/ includes.
7595         * python/py-inferior.c: Fix common/ includes.
7596         * progspace.h: Fix common/ includes.
7597         * producer.c: Fix common/ includes.
7598         * procfs.c: Fix common/ includes.
7599         * proc-api.c: Fix common/ includes.
7600         * printcmd.c: Fix common/ includes.
7601         * ppc-linux-nat.c: Fix common/ includes.
7602         * parser-defs.h: Fix common/ includes.
7603         * osdata.c: Fix common/ includes.
7604         * obsd-nat.c: Fix common/ includes.
7605         * nat/x86-linux.c: Fix common/ includes.
7606         * nat/x86-linux-dregs.c: Fix common/ includes.
7607         * nat/x86-dregs.h: Fix common/ includes.
7608         * nat/x86-dregs.c: Fix common/ includes.
7609         * nat/ppc-linux.c: Fix common/ includes.
7610         * nat/mips-linux-watch.h: Fix common/ includes.
7611         * nat/mips-linux-watch.c: Fix common/ includes.
7612         * nat/linux-waitpid.c: Fix common/ includes.
7613         * nat/linux-ptrace.h: Fix common/ includes.
7614         * nat/linux-ptrace.c: Fix common/ includes.
7615         * nat/linux-procfs.c: Fix common/ includes.
7616         * nat/linux-personality.c: Fix common/ includes.
7617         * nat/linux-osdata.c: Fix common/ includes.
7618         * nat/linux-namespaces.c: Fix common/ includes.
7619         * nat/linux-btrace.h: Fix common/ includes.
7620         * nat/linux-btrace.c: Fix common/ includes.
7621         * nat/fork-inferior.c: Fix common/ includes.
7622         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7623         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7624         * nat/aarch64-linux.c: Fix common/ includes.
7625         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7626         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7627         * namespace.h: Fix common/ includes.
7628         * mips-linux-tdep.c: Fix common/ includes.
7629         * minsyms.c: Fix common/ includes.
7630         * mi/mi-parse.h: Fix common/ includes.
7631         * mi/mi-main.c: Fix common/ includes.
7632         * mi/mi-cmd-env.c: Fix common/ includes.
7633         * memrange.h: Fix common/ includes.
7634         * memattr.c: Fix common/ includes.
7635         * maint.h: Fix common/ includes.
7636         * maint.c: Fix common/ includes.
7637         * main.c: Fix common/ includes.
7638         * machoread.c: Fix common/ includes.
7639         * location.c: Fix common/ includes.
7640         * linux-thread-db.c: Fix common/ includes.
7641         * linux-nat.c: Fix common/ includes.
7642         * linux-fork.c: Fix common/ includes.
7643         * inline-frame.c: Fix common/ includes.
7644         * infrun.c: Fix common/ includes.
7645         * inflow.c: Fix common/ includes.
7646         * inferior.h: Fix common/ includes.
7647         * inferior.c: Fix common/ includes.
7648         * infcmd.c: Fix common/ includes.
7649         * inf-ptrace.c: Fix common/ includes.
7650         * inf-child.c: Fix common/ includes.
7651         * ia64-linux-nat.c: Fix common/ includes.
7652         * i387-tdep.c: Fix common/ includes.
7653         * i386-tdep.c: Fix common/ includes.
7654         * i386-linux-tdep.c: Fix common/ includes.
7655         * i386-linux-nat.c: Fix common/ includes.
7656         * i386-go32-tdep.c: Fix common/ includes.
7657         * i386-fbsd-tdep.c: Fix common/ includes.
7658         * i386-fbsd-nat.c: Fix common/ includes.
7659         * guile/scm-type.c: Fix common/ includes.
7660         * guile/guile.c: Fix common/ includes.
7661         * go32-nat.c: Fix common/ includes.
7662         * gnu-nat.c: Fix common/ includes.
7663         * gdbthread.h: Fix common/ includes.
7664         * gdbarch-selftests.c: Fix common/ includes.
7665         * gdb_usleep.c: Fix common/ includes.
7666         * gdb_select.h: Fix common/ includes.
7667         * gdb_bfd.c: Fix common/ includes.
7668         * gcore.c: Fix common/ includes.
7669         * fork-child.c: Fix common/ includes.
7670         * findvar.c: Fix common/ includes.
7671         * fbsd-nat.c: Fix common/ includes.
7672         * event-top.c: Fix common/ includes.
7673         * event-loop.c: Fix common/ includes.
7674         * dwarf2read.c: Fix common/ includes.
7675         * dwarf2loc.c: Fix common/ includes.
7676         * dwarf2-frame.c: Fix common/ includes.
7677         * dwarf-index-cache.c: Fix common/ includes.
7678         * dtrace-probe.c: Fix common/ includes.
7679         * disasm-selftests.c: Fix common/ includes.
7680         * defs.h: Fix common/ includes.
7681         * csky-tdep.c: Fix common/ includes.
7682         * cp-valprint.c: Fix common/ includes.
7683         * cp-support.h: Fix common/ includes.
7684         * cp-support.c: Fix common/ includes.
7685         * corelow.c: Fix common/ includes.
7686         * completer.h: Fix common/ includes.
7687         * completer.c: Fix common/ includes.
7688         * compile/compile.c: Fix common/ includes.
7689         * compile/compile-loc2c.c: Fix common/ includes.
7690         * compile/compile-cplus-types.c: Fix common/ includes.
7691         * compile/compile-cplus-symbols.c: Fix common/ includes.
7692         * command.h: Fix common/ includes.
7693         * cli/cli-dump.c: Fix common/ includes.
7694         * cli/cli-cmds.c: Fix common/ includes.
7695         * charset.c: Fix common/ includes.
7696         * build-id.c: Fix common/ includes.
7697         * btrace.h: Fix common/ includes.
7698         * btrace.c: Fix common/ includes.
7699         * breakpoint.h: Fix common/ includes.
7700         * breakpoint.c: Fix common/ includes.
7701         * ax.h: 
7702         (enum agent_op): Fix common/ includes.
7703         * ax-general.c (struct aop_map): Fix common/ includes.
7704         * ax-gdb.c: Fix common/ includes.
7705         * auxv.c: Fix common/ includes.
7706         * auto-load.c: Fix common/ includes.
7707         * arm-tdep.c: Fix common/ includes.
7708         * arch/riscv.c: Fix common/ includes.
7709         * arch/ppc-linux-common.c: Fix common/ includes.
7710         * arch/i386.c: Fix common/ includes.
7711         * arch/arm.c: Fix common/ includes.
7712         * arch/arm-linux.c: Fix common/ includes.
7713         * arch/arm-get-next-pcs.c: Fix common/ includes.
7714         * arch/amd64.c: Fix common/ includes.
7715         * arch/aarch64.c: Fix common/ includes.
7716         * arch/aarch64-insn.c: Fix common/ includes.
7717         * arch-utils.c: Fix common/ includes.
7718         * amd64-windows-tdep.c: Fix common/ includes.
7719         * amd64-tdep.c: Fix common/ includes.
7720         * amd64-sol2-tdep.c: Fix common/ includes.
7721         * amd64-obsd-tdep.c: Fix common/ includes.
7722         * amd64-nbsd-tdep.c: Fix common/ includes.
7723         * amd64-linux-tdep.c: Fix common/ includes.
7724         * amd64-linux-nat.c: Fix common/ includes.
7725         * amd64-fbsd-tdep.c: Fix common/ includes.
7726         * amd64-fbsd-nat.c: Fix common/ includes.
7727         * amd64-dicos-tdep.c: Fix common/ includes.
7728         * amd64-darwin-tdep.c: Fix common/ includes.
7729         * agent.c: Fix common/ includes.
7730         * ada-lang.h: Fix common/ includes.
7731         * ada-lang.c: Fix common/ includes.
7732         * aarch64-tdep.c: Fix common/ includes.
7733
7734 2019-01-25  Tom Tromey  <tom@tromey.com>
7735
7736         * common/create-version.sh: Use common/version.h.
7737
7738 2019-01-24  Pedro Alves  <palves@redhat.com>
7739
7740         * infrun.c (signal_stop, signal_print, signal_program)
7741         (signal_catch, signal_pass): Now arrays instead of pointers.
7742         (update_signals_program_target, do_target_resume)
7743         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7744         * linux-nat.c (linux_nat_target::pass_signals)
7745         (linux_nat_target::create_inferior, linux_nat_target::attach):
7746         Adjust.
7747         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7748         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7749         * procfs.c (procfs_target::pass_signals): Adjust.
7750         * record-full.c (record_full_target::resume): Adjust.
7751         * remote.c (remote_target::pass_signals)
7752         (remote_target::program_signals): Adjust.
7753         * target-debug.h (target_debug_print_signals): Now takes a
7754         gdb::array_view as parameter.  Adjust.
7755         * target.h (target_ops) <pass_signals, program_signals>: Replace
7756         pointer and length parameters with gdb::array_view.
7757         (target_pass_signals, target_program_signals): Likewise.
7758         * target-delegates.c: Regenerate.
7759
7760 2019-01-24  Pedro Alves  <palves@redhat.com>
7761
7762         * common/forward-scope-exit.h
7763         (forward_scope_exit::forward_scope_exit): Pass arguments to
7764         m_bind_function directly, instead of creating a std::bind and
7765         copying that.
7766
7767 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7768
7769         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7770         for static members.
7771         (pass_in_v_vfp_candidate): Likewise.
7772
7773 2019-01-23  Tom Tromey  <tom@tromey.com>
7774             Pedro Alves  <palves@redhat.com>
7775
7776         * regcache.c (class regcache_invalidator): Remove.
7777         (regcache::raw_write): Use make_scope_exit.
7778
7779 2019-01-23  Tom Tromey  <tom@tromey.com>
7780
7781         * ui-out.h (class ui_out_emit_type): Update comment.
7782
7783 2019-01-23  Tom Tromey  <tom@tromey.com>
7784
7785         * infrun.c (fetch_inferior_event): Update comment.
7786
7787 2019-01-23  Tom Tromey  <tom@tromey.com>
7788             Pedro Alves  <palves@redhat.com>
7789
7790         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7791         parameter.
7792         (fetch_inferior_event): Use SCOPE_EXIT.
7793
7794
7795 2019-01-23  Tom Tromey  <tom@tromey.com>
7796             Pedro Alves  <palves@redhat.com>
7797
7798         * infrun.c (disable_thread_events): Delete.
7799         (stop_all_threads): Use SCOPE_EXIT.
7800
7801 2019-01-23  Tom Tromey  <tom@tromey.com>
7802             Pedro Alves  <palves@redhat.com>
7803
7804         * symfile.c: Include forward-scope-exit.h.
7805         (clear_symtab_users_cleanup): Replace forward declaration with
7806         a FORWARD_SCOPE_EXIT.
7807         (syms_from_objfile_1): Use the forward_scope_exit and
7808         gdb::optional instead of cleanup_function.
7809         (reread_symbols): Use the forward_scope_exit instead of
7810         cleanup_function.
7811         (clear_symtab_users_cleanup): Remove function.
7812
7813 2019-01-23  Tom Tromey  <tom@tromey.com>
7814             Pedro Alves  <palves@redhat.com>
7815
7816         * linux-nat.c: Include scope-exit.h.
7817         (cleanup_target_stop): Remove.
7818         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7819         SCOPE_EXIT.
7820
7821 2019-01-23  Tom Tromey  <tom@tromey.com>
7822             Pedro Alves  <palves@redhat.com>
7823
7824         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7825         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7826
7827 2019-01-23  Tom Tromey  <tom@tromey.com>
7828             Andrew Burgess  <andrew.burgess@embecosm.com>
7829             Pedro Alves  <palves@redhat.com>
7830
7831         * infrun.c (fetch_inferior_event): Use scope_exit.
7832         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7833         * top.c (execute_command): Use scope_exit.
7834         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7835         * utils.c (do_bpstat_clear_actions_cleanup)
7836         (make_bpstat_clear_actions_cleanup): Remove.
7837
7838 2019-01-23  Tom Tromey  <tom@tromey.com>
7839             Pedro Alves  <palves@redhat.com>
7840
7841         * infrun.c: Include "common/scope-exit.h"
7842         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7843         (wait_for_inferior): Use SCOPE_EXIT.
7844         (fetch_inferior_event): Use scope_exit.
7845
7846 2019-01-23  Tom Tromey  <tom@tromey.com>
7847             Pedro Alves  <palves@redhat.com>
7848
7849         * breakpoint.c (create_breakpoint): Remove cleanup.
7850
7851 2019-01-23  Tom Tromey  <tom@tromey.com>
7852             Andrew Burgess  <andrew.burgess@embecosm.com>
7853             Pedro Alves  <palves@redhat.com>
7854
7855 2019-01-23  Pedro Alves  <palves@redhat.com>
7856
7857         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7858
7859 2019-01-23  Pedro Alves  <palves@redhat.com>
7860             Andrew Burgess  <andrew.burgess@embecosm.com>
7861
7862         * gdbthread.h: Include "common/forward-scope-exit.h".
7863         (scoped_finish_thread_state): Redefine custom class in terms of
7864         forward_scope_exit.
7865
7866 2019-01-23  Pedro Alves  <palves@redhat.com>
7867             Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * common/forward-scope-exit.h: New file.
7870
7871 2019-01-23  Pedro Alves  <palves@redhat.com>
7872             Andrew Burgess  <andrew.burgess@embecosm.com>
7873             Tom Tromey  <tom@tromey.com>
7874
7875         * common/scope-exit.h: New file.
7876
7877 2019-01-23  Pedro Alves  <palves@redhat.com>
7878
7879         * common/preprocessor.h (ESC): Rename to ...
7880         (ESC_PARENS): ... this.
7881         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7882         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7883
7884 2019-01-23  Tom Tromey  <tom@tromey.com>
7885
7886         * language.h (class scoped_switch_to_sym_language_if_auto):
7887         Initialize m_lang in both cases.
7888
7889 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7890
7891         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7892         with XCNEW.
7893
7894 2019-01-22  Tom Tromey  <tom@tromey.com>
7895
7896         * corelow.c: Do not include sys/file.h.
7897
7898 2019-01-22  Tom Tromey  <tom@tromey.com>
7899
7900         * tui/tui-wingeneral.h: Include gdb_curses.h.
7901
7902 2019-01-22  Tom Tromey  <tom@tromey.com>
7903
7904         * source-cache.h (class source_cache) <get_source_lines,
7905         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7906
7907 2019-01-22  Tom Tromey  <tom@tromey.com>
7908
7909         * remote-fileio.h (struct remote_target): Declare.
7910
7911 2019-01-22  Tom Tromey  <tom@tromey.com>
7912
7913         * python/py-arch.c: Do not include py-ref.h.
7914         * python/py-bpevent.c: Do not include py-ref.h.
7915         * python/py-cmd.c: Do not include py-ref.h.
7916         * python/py-continueevent.c: Do not include py-ref.h.
7917         * python/py-event.h: Do not include py-ref.h.
7918         * python/py-evtregistry.c: Do not include py-ref.h.
7919         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7920         * python/py-frame.c: Do not include py-ref.h.
7921         * python/py-framefilter.c: Do not include py-ref.h.
7922         * python/py-function.c: Do not include py-ref.h.
7923         * python/py-infevents.c: Do not include py-ref.h.
7924         * python/py-linetable.c: Do not include py-ref.h.
7925         * python/py-objfile.c: Do not include py-ref.h.
7926         * python/py-param.c: Do not include py-ref.h.
7927         * python/py-prettyprint.c: Do not include py-ref.h.
7928         * python/py-progspace.c: Do not include py-ref.h.
7929         * python/py-symbol.c: Do not include py-ref.h.
7930         * python/py-symtab.c: Do not include py-ref.h.
7931         * python/py-type.c: Do not include py-ref.h.
7932         * python/py-unwind.c: Do not include py-ref.h.
7933         * python/py-utils.c: Do not include py-ref.h.
7934         * python/py-value.c: Do not include py-ref.h.
7935         * python/py-varobj.c: Do not include py-ref.h.
7936         * python/py-xmethods.c: Do not include py-ref.h.
7937         * python/python.c: Do not include py-ref.h.
7938         * varobj.c: Do not include py-ref.h.
7939
7940 2019-01-22  Tom Tromey  <tom@tromey.com>
7941
7942         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7943         keyword for bcache.
7944
7945 2019-01-22  Tom Tromey  <tom@tromey.com>
7946
7947         * compile/compile-cplus-types.c: Remove a comment by #include.
7948
7949 2019-01-22  Tom Tromey  <tom@tromey.com>
7950
7951         * compile/gcc-c-plugin.h: Include compile-internal.h.
7952
7953 2019-01-22  Tom Tromey  <tom@tromey.com>
7954
7955         * stabsread.c (EXTERN): Do not define.
7956         (symnum, next_symbol_text_func, processing_gcc_compilation)
7957         (within_function, global_sym_chain, global_stabs)
7958         (previous_stab_code, this_object_header_files)
7959         (n_this_object_header_files)
7960         (n_allocated_this_object_header_files): Define.
7961         * stabsread.h (EXTERN): Never define.  Use "extern".
7962
7963 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964
7965         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7966         history_value.
7967
7968 2019-01-21  Tom Tromey  <tom@tromey.com>
7969
7970         * ui-out.c: Fix includes.
7971         * tui/tui-source.c: Fix includes.
7972         * target.c: Fix includes.
7973         * remote.c: Fix includes.
7974         * regcache.c: Fix includes.
7975         * python/py-block.c: Fix includes.
7976         * printcmd.c: Fix includes.
7977         * or1k-tdep.c: Fix includes.
7978         * mi/mi-main.c: Fix includes.
7979         * m32r-tdep.c: Fix includes.
7980         * csky-tdep.c: Fix includes.
7981         * compile/compile-cplus-types.c: Fix includes.
7982         * cli/cli-interp.c: Fix includes.
7983
7984 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7985
7986         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7987         for padding.
7988
7989 2019-01-16  Tom Tromey  <tom@tromey.com>
7990
7991         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7992         earlier.
7993         (struct objfile) <msymbols_range>: Move from top level.
7994         <msymbols>: New method.
7995         (class objfile_msymbols): Remove.
7996         * symtab.c (default_collect_symbol_completion_matches_break_on):
7997         Update.
7998         * symmisc.c (dump_msymbols): Update.
7999         * stabsread.c (scan_file_globals): Update.
8000         * objc-lang.c (info_selectors_command, info_classes_command)
8001         (find_methods): Update.
8002         * minsyms.c (find_solib_trampoline_target): Update.
8003         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8004         * coffread.c (coff_symfile_read): Update.
8005         * ada-lang.c (ada_lookup_simple_minsym)
8006         (ada_collect_symbol_completion_matches): Update.
8007
8008 2019-01-16  Tom Tromey  <tom@tromey.com>
8009
8010         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8011         type.  Remove no-argument constructor.
8012         <iterator::operator++>: Simplify.
8013         <begin>: Update.
8014         <end>: Use minimal_symbol_count.
8015
8016 2019-01-16  Tom Tromey  <tom@tromey.com>
8017
8018         * objfiles.h (struct objfile) <psymtabs>: New method.
8019         (class objfile_psymtabs): Remove.
8020         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8021         typedef.
8022         <range>: New method.
8023         (require_partial_symbols): Change return type.
8024         * psymtab.c (require_partial_symbols)
8025         (psym_expand_symtabs_matching): Update.
8026         * mdebugread.c (parse_partial_symbols): Update.
8027         * dbxread.c (dbx_end_psymtab): Update.
8028
8029 2019-01-15  Tom Tromey  <tom@tromey.com>
8030
8031         * symtab.c (lookup_objfile_from_block)
8032         (lookup_symbol_in_objfile_symtabs)
8033         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8034         (find_line_symtab, info_sources_command)
8035         (default_collect_symbol_completion_matches_break_on)
8036         (make_source_files_completion_list): Update.
8037         * symmisc.c (print_objfile_statistics, dump_objfile)
8038         (maintenance_print_symbols, maintenance_info_symtabs)
8039         (maintenance_check_symtabs, maintenance_info_line_tables):
8040         Update.
8041         * source.c (select_source_symtab)
8042         (forget_cached_source_info_for_objfile): Update.
8043         * objfiles.h (class objfile_compunits): Remove.
8044         (struct objfile) <compunits_range>: New typedef.
8045         (compunits): New method.
8046         * objfiles.c (objfile_relocate1): Update.
8047         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8048         * maint.c (count_symtabs_and_blocks): Update.
8049         * linespec.c (iterate_over_all_matching_symtabs): Update.
8050         * cp-support.c (add_symbol_overload_list_qualified): Update.
8051         * coffread.c (coff_symtab_read): Update.
8052         * ada-lang.c (add_nonlocal_symbols)
8053         (ada_collect_symbol_completion_matches)
8054         (ada_add_global_exceptions): Update.
8055
8056 2019-01-15  Tom Tromey  <tom@tromey.com>
8057
8058         * progspace.h (program_space) <objfiles_safe_range>: New
8059         typedef.
8060         <objfiles_safe>: New method.
8061         * objfiles.h (class all_objfiles_safe): Remove.
8062         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8063         * jit.c (jit_inferior_exit_hook): Update.
8064
8065 2019-01-17  Tom Tromey  <tom@tromey.com>
8066
8067         * progspace.h (program_space) <objfiles_range>: New typedef.
8068         <objfiles>: New method.
8069         <objfiles_head>: Rename from objfiles.
8070         (object_files): Update.
8071         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8072         * guile/scm-pretty-print.c
8073         (ppscm_find_pretty_printer_from_objfiles): Update.
8074         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8075         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8076         Update.
8077         * python/py-progspace.c (pspy_get_objfiles): Update.
8078         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8079         Update.
8080         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8081         (objfpy_lookup_objfile_by_build_id): Update.
8082         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8083         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8084         Update.
8085         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8086         (expand_symtab_containing_pc, lookup_objfile_from_block)
8087         (lookup_static_symbol, basic_lookup_transparent_type)
8088         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8089         (find_line_symtab, info_sources_command)
8090         (default_collect_symbol_completion_matches_break_on)
8091         (make_source_files_completion_list, find_main_name): Update.
8092         * symmisc.c (print_symbol_bcache_statistics)
8093         (print_objfile_statistics, maintenance_print_symbols)
8094         (maintenance_print_msymbols, maintenance_print_objfiles)
8095         (maintenance_info_symtabs, maintenance_check_symtabs)
8096         (maintenance_expand_symtabs, maintenance_info_line_tables):
8097         Update.
8098         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8099         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8100         (map_overlay_command, unmap_overlay_command)
8101         (simple_overlay_update, expand_symtabs_matching)
8102         (map_symbol_filenames): Update.
8103         * symfile-debug.c (set_debug_symfile): Update.
8104         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8105         Update.
8106         * source.c (select_source_symtab, forget_cached_source_info):
8107         Update.
8108         * solib.c (solib_read_symbols): Update.
8109         * solib-spu.c (append_ocl_sos): Update.
8110         * psymtab.c (maintenance_print_psymbols)
8111         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8112         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8113         * printcmd.c (info_symbol_command): Update.
8114         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8115         Update.
8116         * objfiles.h (class all_objfiles): Remove.
8117         * objfiles.c (have_partial_symbols, have_full_symbols)
8118         (have_minimal_symbols, qsort_cmp, update_section_map)
8119         (shared_objfile_contains_address_p)
8120         (default_iterate_over_objfiles_in_search_order): Update.
8121         * objc-lang.c (info_selectors_command, info_classes_command)
8122         (find_methods): Update.
8123         * minsyms.c (find_solib_trampoline_target): Update.
8124         * maint.c (maintenance_info_sections)
8125         (maintenance_translate_address, count_symtabs_and_blocks):
8126         Update.
8127         * main.c (captured_main_1): Update.
8128         * linux-thread-db.c (try_thread_db_load_from_pdir)
8129         (has_libpthread): Update.
8130         * linespec.c (iterate_over_all_matching_symtabs)
8131         (search_minsyms_for_name): Update.
8132         * jit.c (jit_find_objf_with_entry_addr): Update.
8133         * hppa-tdep.c (find_unwind_entry)
8134         (hppa_lookup_stub_minimal_symbol): Update.
8135         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8136         Update.
8137         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8138         (elf_gnu_ifunc_resolve_by_got): Update.
8139         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8140         * dwarf-index-write.c (save_gdb_index_command): Update.
8141         * cp-support.c (add_symbol_overload_list_qualified): Update.
8142         * breakpoint.c (create_overlay_event_breakpoint)
8143         (create_longjmp_master_breakpoint)
8144         (create_std_terminate_master_breakpoint)
8145         (create_exception_master_breakpoint): Update.
8146         * blockframe.c (find_pc_partial_function): Update.
8147         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8148         (ada_collect_symbol_completion_matches)
8149         (ada_add_global_exceptions): Update.
8150
8151 2019-01-17  Tom Tromey  <tom@tromey.com>
8152
8153         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8154         declare VEC.
8155         (solib_target_parse_libraries): Change return type.
8156         (library_list_start_segment, library_list_start_section)
8157         (library_list_end_library, library_list_start_library); Update.
8158         (solib_target_free_library_list): Remove.
8159         (solib_target_parse_libraries): Remove cleanup.  Change return
8160         type.
8161         (solib_target_current_sos): Update.
8162
8163 2019-01-17  Tom Tromey  <tromey@bapiya>
8164
8165         * valprint.c: Replace "the the" with "the".
8166         * symtab.c: Replace "the the" with "the".
8167         * solib.c: Replace "the the" with "the".
8168         * solib-dsbt.c: Replace "the the" with "the".
8169         * linespec.c: Replace "the the" with "the".
8170         * dwarf2loc.h: Replace "the the" with "the".
8171         * amd64-windows-tdep.c: Replace "the the" with "the".
8172         * aarch64-tdep.c: Replace "the the" with "the".
8173
8174 2019-01-16  Keith Seitz  <keiths@redhat.com>
8175
8176         PR gdb/23773
8177         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8178         <builder>: Rename to ..
8179         <m_builder>: ... this and make private.
8180         (dwarf2_cu::get_builder): New method.  Change all users of
8181         `builder' to use this method.
8182         (dwarf2_start_symtab): Move to ...
8183         (dwarf2_cu::start_symtab): ... here.  Update all callers
8184         (setup_type_unit_groups): Move to ...
8185         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8186         callers.
8187         (dwarf2_cu::reset_builder): New method.
8188         (process_full_compunit, process_full_type_unit): Use
8189         dwarf2_cu::reset_builder.
8190         (follow_die_offset): Record the ancestor CU if it is different
8191         from the followed DIE's CU.
8192         (follow_die_sig_1): Likewise.
8193
8194 2019-01-15  Tom Tromey  <tom@tromey.com>
8195
8196         * remote.c (class remote_state) <buf>: Now a char_vector.
8197         <buf_size>: Remove.
8198         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8199         parameter.
8200         (remote_target::getpkt_or_notif_sane_1)
8201         (remote_target::getpkt_sane)
8202         (remote_target::getpkt_or_notif_sane): Likewise.
8203         (class remote_target) <putpkt>: New overload.
8204         (remote_target::read_frame): Change type of "buf_p".  Remove
8205         sizeof_p parameter.
8206         (packet_ok): New overload.
8207         (packet_check_result): New overload.
8208         Update all uses.
8209
8210 2019-01-14  Tom Tromey  <tom@tromey.com>
8211
8212         * remote-notif.c (handle_notification, remote_notif_ack)
8213         (remote_notif_parse): Make "buf" const.
8214         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8215         const.
8216         (remote_notif_parse, remote_notif_ack, handle_notification):
8217         Likewise.
8218         * remote.c (remote_notif_stop_parse): Make "buf" const.
8219         (remote_target::remote_parse_stop_reply): Make "buf" const.
8220         (remote_notif_stop_ack): Make "buf" const.
8221
8222 2019-01-14  Tom Tromey  <tom@tromey.com>
8223
8224         * remote.c (remote_console_output): Make parameter const.
8225
8226 2019-01-14  Tom Tromey  <tom@tromey.com>
8227
8228         * target-debug.h (target_debug_print_signals): Constify.
8229         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8230         * procfs.c (procfs_target::pass_signals): Update.
8231         * linux-nat.c (linux_nat_target::pass_signals): Update.
8232         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8233         * target-delegates.c: Rebuild.
8234         * remote.c (remote_target::program_signals): Update.
8235         (remote_target::pass_signals): Update.
8236         * target.c (target_pass_signals): Constify argument.
8237         (target_program_signals): Likewise.
8238         * target.h (struct target_ops) <pass_signals, program_signals>:
8239         Constify argument.
8240         (target_pass_signals, target_program_signals): Constify argument.
8241
8242 2019-01-14  Tom Tromey  <tom@tromey.com>
8243
8244         PR tui/28819:
8245         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8246
8247 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8248
8249         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8250         field.
8251         * rs6000-tdep.c: Include reggroups.h.
8252         (IS_V_ALIAS_PSEUDOREG): Define.
8253         (rs6000_register_name): Return names for the "vX" aliases.
8254         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8255         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8256         aliases.  Call default_register_reggroup_p for all other
8257         pseudo-registers.
8258         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8259         New functions.
8260         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8261         Handle "vX" aliases.
8262         (v_alias_pseudo_register_collect): New function.
8263         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8264         (rs6000_gdbarch_init): Initialize "vX" aliases as
8265         pseudo-registers.  Restore registration of
8266         rs6000_pseudo_register_reggroup_p with
8267         set_tdesc_pseudo_register_reggroup_p.
8268
8269 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8270
8271         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8272         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8273         set_gdbarch_num_pseudo_regs.
8274
8275 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8276
8277         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8278         Remove arg prefixname, add do_set and do_show.
8279         Add member functions set_list and show_list.
8280         * cli/cli-style.c (class cli_style_option): Update accordingly.
8281         (style_set_list): Move to file scope.
8282         (style_show_list): Likewise.
8283         (set_style): Call help_list.
8284         (show_style): Call cmd_show_list.
8285         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8286         Update to use the new macro.
8287
8288 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8289
8290         * ada-lang.c (_initialize_ada_language): Expand the help text
8291         for the "catch exception" command.
8292
8293 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8294
8295         * symtab.c (matching_obj_sections): Initialize obj,
8296         declare it closer to its usage.
8297
8298 2019-01-10  Tom Tromey  <tom@tromey.com>
8299
8300         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8301         (basic_inf_threads_range): Remove.
8302         (inf_threads_range, inf_non_exited_threads_range)
8303         (safe_inf_threads_range): Use next_adapter.
8304
8305 2019-01-10  Keith Seitz  <keiths@redhat.com>
8306
8307         PR gdb/23712
8308         PR symtab/23010
8309         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8310         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8311
8312 2019-01-10  Keith Seitz  <keiths@redhat.com>
8313
8314         PR gdb/23712
8315         PR symtab/23010
8316         * dictionary.c (pending_to_vector): Remove.
8317         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8318         Remove _1 suffix, replacing functions of the same name.  Update
8319         all callers.
8320         (dict_create_hashed, dict_create_hashed_expandable)
8321         (dict_create_linear, dict_create_linear_expandable, dict_free)
8322         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8323         Make functions static.
8324
8325 2019-01-10  Keith Seitz  <keiths@redhat.com>
8326
8327         PR gdb/23712
8328         PR symtab/23010
8329         * dictionary.h (struct dictionary): Replace declaration with
8330         multidictionary.
8331         (dict_create_hashed, dict_create_hashed_expandable)
8332         (dict_create_linear, dict_create_linear_expandable)
8333         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8334         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8335         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8336         taking multidictionary argument.
8337         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8338         * block.h (struct block) <dict>: Change to multidictionary
8339         and rename `multidict'.
8340         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8341         symmisc.c: Update all dictionary references to multidictionary.
8342
8343 2019-01-10  Keith Seitz  <keiths@redhat.com>
8344
8345         PR gdb/23712
8346         PR symtab/23010
8347         * dictionary.c: Include unordered_map.
8348         (pending_to_vector): New function.
8349         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8350         Rewrite the non-"_1" functions to take vector instead
8351         of linked list.
8352         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8353         "new" _1 versions of the same name.
8354         (multidictionary): Define.
8355         (std::hash<enum language): New definition.
8356         (collate_pending_symbols_by_language, mdict_create_hashed)
8357         (mdict_create_hashed_expandable, mdict_create_linear)
8358         (mdict_create_linear_expandable, mdict_free)
8359         (find_language_dictionary, create_new_language_dictionary)
8360         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8361         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8362         (mdict_size, mdict_empty): New functions.
8363         * dictionary.h (mdict_iterator): Define.
8364
8365 2019-01-10  Pedro Alves  <palves@redhat.com>
8366
8367         * breakpoint.c (read_uploaded_action)
8368         (create_tracepoint_from_upload): Adjust to use
8369         gdb::unique_xmalloc_ptr.
8370         * ctf.c (ctf_write_uploaded_tp):
8371         (SET_ARRAY_FIELD): Use emplace_back.
8372         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8373         * tracefile-tfile.c (tfile_write_uploaded_tp):
8374         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8375         gdb::unique_xmalloc_ptr.
8376         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8377         at_string, cond_string, cmd_strings>: Replace char pointers
8378         with gdb::unique_xmalloc_ptr.
8379
8380 2019-01-10  Pedro Alves  <palves@redhat.com>
8381
8382         * solib-target.c (library_list_start_library): Don't xstrdup name.
8383
8384 2019-01-10  Pedro Alves  <palves@redhat.com>
8385
8386         * mdebugread.c (parse_partial_symbols): Use
8387         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8388
8389 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8390
8391         * linux-fork.c (scoped_switch_fork_info)
8392         <~scoped_switch_fork_info>: Fix incorrect variable name.
8393
8394 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * linux-fork.c (scoped_switch_fork_info)
8397         <scoped_switch_fork_info>: Make explicit.
8398         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8399
8400 2019-01-10  Tom Tromey  <tom@tromey.com>
8401
8402         * objfiles.h (objfile::reset_psymtabs): Update.
8403         * objfiles.c (objfile::objfile): Update.
8404         * psymtab.h (psymtab_storage::obstack): Update.
8405         (psymtab_storage::m_obstack): Use gdb::optional.
8406         (class psymtab_storage): Update comment.  Remove objfile
8407         parameter.
8408         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8409
8410 2019-01-10  Tom Tromey  <tom@tromey.com>
8411
8412         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8413         <free_psymtabs>: Now private.
8414         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8415         (allocate_psymtab): Use new method.
8416
8417 2019-01-10  Tom Tromey  <tom@tromey.com>
8418
8419         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8420         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8421         * mdebugread.c (parse_partial_symbols): Use
8422         allocate_dependencies.
8423         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8424         allocate_dependencies.
8425         (process_psymtab_comp_unit_reader)
8426         (build_type_psymtab_dependencies): Likewise.
8427         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8428
8429 2019-01-10  Tom Tromey  <tom@tromey.com>
8430
8431         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8432         PSYMBOL_SET_LANGUAGE.
8433         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8434
8435 2019-01-10  Tom Tromey  <tom@tromey.com>
8436
8437         * psymtab.h (psymtab_storage::obstack): New method.
8438         <m_obstack>: Rename from obstack; now private.
8439         * psymtab.c (psymtab_storage): Update.
8440         * dwarf2read.c (create_addrmap_from_index)
8441         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8442         Update.
8443
8444 2019-01-10  Tom Tromey  <tom@tromey.com>
8445
8446         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8447         * objfiles.h (objfile::reset_psymtabs): New method.
8448
8449 2019-01-10  Tom Tromey  <tom@tromey.com>
8450
8451         * symmisc.c (print_symbol_bcache_statistics): Update.
8452         (print_objfile_statistics): Update.
8453         * symfile.c (reread_symbols): Update.
8454         * psymtab.h (class psymtab_storage): New.
8455         * psymtab.c (psymtab_storage): New constructor.
8456         (~psymtab_storage): New destructor.
8457         (require_partial_symbols): Update.
8458         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8459         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8460         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8461         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8462         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8463         (start_psymtab_common, end_psymtab_common)
8464         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8465         (allocate_psymtab): Update.
8466         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8467         Update.
8468         (dump_psymtab_addrmap, maintenance_print_psymbols)
8469         (maintenance_check_psymtabs): Update.
8470         (class objfile_psymtabs): Move to objfiles.h.
8471         * psympriv.h (discard_psymtab): Now inline.
8472         (psymtab_discarder::psymtab_discarder): Update.
8473         (psymtab_discarder::~psymtab_discarder): Update.
8474         (ALL_OBJFILE_PSYMTABS): Rewrite.
8475         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8476         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8477         Remove fields.
8478         <partial_symtabs>: New field.
8479         (class objfile_psymtabs): Move from psymtab.h.  Update.
8480         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8481         psymbol_cache.
8482         (objfile::~objfile): Don't destroy psymbol_cache.
8483         * mdebugread.c (parse_partial_symbols): Update.
8484         * dwarf2read.c (create_addrmap_from_index)
8485         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8486         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8487         (add_partial_subprogram, dwarf2_ranges_read): Update.
8488         * dwarf-index-write.c (write_address_map)
8489         (write_one_signatured_type, recursively_write_psymbols)
8490         (class debug_names, class debug_names, write_psymtabs_to_index):
8491         Update.
8492
8493 2019-01-10  Tom Tromey  <tom@tromey.com>
8494
8495         * symtab.h (SYMBOL_SET_NAMES): Update.
8496         (symbol_set_names): Update.
8497         (MSYMBOL_SET_NAMES): Update.
8498         * symtab.c (symbol_set_names): Change argument to be an
8499         objfile_per_bfd_storage.
8500         * psymtab.c (add_psymbol_to_bcache): Update.
8501         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8502
8503 2019-01-10  Tom Tromey  <tom@tromey.com>
8504
8505         * symtab.c (create_demangled_names_hash): Change argument to be an
8506         objfile_per_bfd_storage.
8507         (symbol_set_names): Update.
8508
8509 2019-01-10  Tom Tromey  <tom@tromey.com>
8510
8511         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8512         init_psymbol_list.
8513         * psymtab.c (init_psymbol_list): Do nothing if already called.
8514         * psympriv.h (init_psymbol_list): Add comment.
8515         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8516         init_psymbol_list.
8517         * dbxread.c (dbx_symfile_read): Unconditionally call
8518         init_psymbol_list.
8519
8520 2019-01-10  Tom Tromey  <tom@tromey.com>
8521
8522         * xcoffread.c (scan_xcoff_symtab): Update.
8523         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8524         "where".
8525         * mdebugread.c (parse_partial_symbols)
8526         (handle_psymbol_enumerators): Update.
8527         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8528         * dbxread.c (read_dbx_symtab): Update.
8529         * psympriv.h (psymbol_placement): New enum.
8530         (add_psymbol_to_list): Update.
8531
8532 2019-01-10  Tom Tromey  <tom@tromey.com>
8533
8534         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8535         static_psymbols parameters.
8536         (scan_xcoff_symtab): Update.
8537         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8538         static_psymbols parameters.
8539         * psympriv.h (start_psymtab_common): Update.
8540         * mdebugread.c (parse_partial_symbols): Update.
8541         * dwarf2read.c (create_partial_symtab): Update.
8542         * dbxread.c (read_dbx_symtab): Update.
8543         (start_psymtab): Remove global_psymbols and static_psymbols
8544         parameters.
8545
8546 2019-01-10  Tom Tromey  <tom@tromey.com>
8547
8548         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8549         * psymtab.c (allocate_psymtab): Add comment.
8550         * psympriv.h (allocate_psymtab): Add comment.
8551         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8552         initializations.
8553         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8554
8555 2019-01-10  Tom Tromey  <tom@tromey.com>
8556
8557         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8558         Don't declare.
8559         * mipsread.c: Include mdebugread.h.
8560         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8561         Declare.
8562         * elfread.c: Include mdebugread.h.
8563
8564 2019-01-09  Tom Tromey  <tom@tromey.com>
8565
8566         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8567         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8568         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8569         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8570         (psym_lookup_symbol, psym_find_last_source_symtab)
8571         (psym_forget_cached_source_info, psym_print_stats)
8572         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8573         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8574         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8575         (psym_find_compunit_symtab_by_address)
8576         (maintenance_print_psymbols, maintenance_info_psymtabs)
8577         (maintenance_check_psymtabs): Use ranged for.
8578         * psymtab.h (class objfile_psymtabs): New.
8579         (require_partial_symbols): Return objfile_psymtabs.
8580         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8581
8582 2019-01-09  Tom Tromey  <tom@tromey.com>
8583
8584         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8585         (find_pc_mapped_section, list_overlays_command)
8586         (map_overlay_command, unmap_overlay_command)
8587         (simple_overlay_update): Use all_objfiles.
8588         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8589         * printcmd.c (info_symbol_command): Use all_objfiles.
8590         * objfiles.h (ALL_OBJSECTIONS): Remove.
8591         * maint.c (maintenance_translate_address): Use all_objfiles.
8592         * gcore.c (gcore_create_callback): Use all_objfiles.
8593         (objfile_find_memory_regions): Likewise.
8594
8595 2019-01-09  Tom Tromey  <tom@tromey.com>
8596
8597         * symtab.c (find_line_symtab, info_sources_command)
8598         (make_source_files_completion_list): Use objfile_compunits.
8599         * source.c (select_source_symtab): Use objfile_compunits.
8600         * objfiles.h (struct objfile): Update comment.
8601         (ALL_OBJFILES): Remove.
8602         (ALL_FILETABS): Remove.
8603         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8604         objfile_compunits.
8605
8606 2019-01-09  Tom Tromey  <tom@tromey.com>
8607
8608         * symmisc.c (print_objfile_statistics, dump_objfile)
8609         (maintenance_print_symbols): Use compunit_filetabs.
8610         * source.c (forget_cached_source_info_for_objfile): Use
8611         compunit_filetabs.
8612         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8613         (ALL_FILETABS): Use compunit_filetabs.
8614         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8615         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8616
8617 2019-01-09  Tom Tromey  <tom@tromey.com>
8618
8619         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8620         (compunit_filetabs): New.
8621         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8622         compunit_filetabs.
8623         (info_sources_command, make_source_files_completion_list): Remove
8624         declaration.
8625         * symmisc.c (print_objfile_statistics, dump_objfile)
8626         (maintenance_print_symbols): Remove declaration.
8627         (maintenance_info_symtabs): Use compunit_filetabs.
8628         (maintenance_info_line_tables): Likewise.
8629         * source.c (select_source_symtab): Change local variable name.
8630         (forget_cached_source_info_for_objfile): Remove declaration.
8631         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8632         * objfiles.c (objfile_relocate1): Remove declaration.
8633         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8634         declaration.
8635         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8636         * coffread.c (coff_symtab_read): Remove declaration.
8637         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8638         compunit_filetabs.
8639
8640 2019-01-09  Tom Tromey  <tom@tromey.com>
8641
8642         * symtab.c (lookup_objfile_from_block)
8643         (find_pc_sect_compunit_symtab, search_symbols)
8644         (default_collect_symbol_completion_matches_break_on): Use
8645         objfile_compunits.
8646         * objfiles.h (ALL_COMPUNITS): Remove.
8647         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8648         * cp-support.c (add_symbol_overload_list_qualified): Use
8649         objfile_compunits.
8650         * ada-lang.c (ada_collect_symbol_completion_matches)
8651         (ada_add_global_exceptions): Use objfile_compunits.
8652
8653 2019-01-09  Tom Tromey  <tom@tromey.com>
8654
8655         * source.c (select_source_symtab)
8656         (forget_cached_source_info_for_objfile): Remove declaration.
8657         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8658         declaration.
8659         * maint.c (count_symtabs_and_blocks): Remove declaration.
8660         * cp-support.c (add_symbol_overload_list_qualified): Remove
8661         declaration.
8662         * coffread.c (coff_symtab_read): Remove declaration.
8663         * symtab.c (lookup_symbol_in_objfile_symtabs)
8664         (basic_lookup_transparent_type_1): Use objfile_compunits.
8665         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8666         (info_sources_command, search_symbols)
8667         (default_collect_symbol_completion_matches_break_on)
8668         (make_source_files_completion_list): Remove declaration.
8669         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8670         (ada_collect_symbol_completion_matches)
8671         (ada_add_global_exceptions): Remove declaration.
8672         * linespec.c (iterate_over_all_matching_symtabs): Use
8673         objfile_compunits.
8674         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8675         (class objfile_compunits): New.
8676         (ALL_COMPUNITS): Use objfile_compunits.
8677         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8678         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8679         objfile_compunits.
8680         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8681
8682 2019-01-09  Tom Tromey  <tom@tromey.com>
8683
8684         * symtab.c (search_symbols)
8685         (default_collect_symbol_completion_matches_break_on): Use
8686         objfile_msymbols.
8687         * ada-lang.c (ada_lookup_simple_minsym)
8688         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8689         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8690         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8691         objfile_msymbols.
8692         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8693         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8694         * objc-lang.c (find_methods): Use objfile_msymbols.
8695         (info_selectors_command, info_classes_command): Likewise.
8696         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8697         * objfiles.h (class objfile_msymbols): New.
8698         (ALL_OBJFILE_MSYMBOLS): Remove.
8699         (ALL_MSYMBOLS): Remove.
8700
8701 2019-01-09  Tom Tromey  <tom@tromey.com>
8702
8703         * common/next-iterator.h (next_adapter): Add Iterator template
8704         parameter.
8705         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8706         (class all_objfiles_safe): New.
8707         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8708         * objfiles.c (put_objfile_before): Update comment.
8709         (add_separate_debug_objfile): Likewise.
8710         (free_all_objfiles): Use all_objfiles_safe.
8711         (objfile_purge_solibs): Likewise.
8712
8713 2019-01-09  Tom Tromey  <tom@tromey.com>
8714
8715         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8716         (expand_symtab_containing_pc, lookup_static_symbol)
8717         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8718         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8719         all_objfiles.
8720         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8721         * breakpoint.c (create_overlay_event_breakpoint)
8722         (create_longjmp_master_breakpoint)
8723         (create_std_terminate_master_breakpoint)
8724         (create_exception_master_breakpoint): Use all_objfiles.
8725         * linux-thread-db.c (try_thread_db_load_from_pdir)
8726         (has_libpthread): Use all_objfiles.
8727         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8728         * linespec.c (iterate_over_all_matching_symtabs)
8729         (search_minsyms_for_name): Use all_objfiles.
8730         * maint.c (maintenance_info_sections): Use all_objfiles.
8731         * main.c (captured_main_1): Use all_objfiles.
8732         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8733         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8734         * guile/scm-pretty-print.c
8735         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8736         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8737         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8738         (maintenance_print_msymbols): Use all_objfiles.
8739         * source.c (select_source_symtab): Use all_objfiles.
8740         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8741         * symfile.c (remove_symbol_file_command)
8742         (expand_symtabs_matching, map_symbol_filenames): Use
8743         all_objfiles.
8744         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8745         all_objfiles.
8746         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8747         * objc-lang.c (find_methods): Use all_objfiles.
8748         * objfiles.c (have_partial_symbols, have_full_symbols)
8749         (have_minimal_symbols, qsort_cmp)
8750         (default_iterate_over_objfiles_in_search_order): Use
8751         all_objfiles.
8752         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8753         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8754         (maintenance_check_psymtabs): Use all_objfiles.
8755         (ALL_PSYMTABS): Remove.
8756         * compile/compile-object-run.c (do_module_cleanup): Use
8757         all_objfiles.
8758         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8759         * cp-support.c (add_symbol_overload_list_qualified): Use
8760         all_objfiles.
8761         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8762         Use all_objfiles.
8763         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8764         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8765         all_objfiles.
8766         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8767         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8768         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8769         Uses all_objfiles.
8770         * solib.c (solib_read_symbols): Use all_objfiles
8771
8772 2019-01-09  Tom Tromey  <tom@tromey.com>
8773
8774         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8775         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8776         all_objfiles.
8777         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8778         * symmisc.c (print_symbol_bcache_statistics)
8779         (print_objfile_statistics, maintenance_print_objfiles)
8780         (maintenance_info_symtabs, maintenance_check_symtabs)
8781         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8782         all_objfiles.
8783         * source.c (forget_cached_source_info): Use all_objfiles.
8784         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8785         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8786         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8787         * objfiles.c (update_section_map): Use all_objfiles.
8788         (shared_objfile_contains_address_p): Likewise.
8789         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8790         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8791
8792 2019-01-09  Tom Tromey  <tom@tromey.com>
8793
8794         * common/next-iterator.h: New file.
8795         * objfiles.h (class all_objfiles): New.
8796         (struct objfile_iterator): New.
8797
8798 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8799
8800         * NEWS: Move the description of the changed "frame", "select-frame",
8801          and "info frame" commands to the Changed commands section.
8802
8803 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8804
8805         * gdbtypes.c (check_stub_method_group): Remove handling of old
8806         mangling schemes.
8807         * linespec.c (find_methods): Likewise.
8808         * stabsread.c (read_member_functions): Likewise.
8809         * valops.c (search_struct_method): Likewise.
8810         (value_struct_elt_for_reference): Likewise.
8811         * NEWS: Mention this change.
8812
8813 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8814
8815         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8816         print_source_lines.
8817         * source.c (print_source_lines_base): Update line number check.
8818         (print_source_lines): New function.
8819         (source_lines_range::source_lines_range): New function.
8820         * source.h (class source_lines_range): New class.
8821         (print_source_lines): New declaration.
8822
8823 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8824
8825         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8826
8827 2019-01-08  Tom Tromey  <tom@tromey.com>
8828             Simon Marchi  <simon.marchi@ericsson.com>
8829
8830         PR gdb/24060
8831         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8832         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8833         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8834         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8835         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8836         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8837
8838 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * source.c (select_source_symtab): Move header comment to
8841         declaration in source.h.
8842         (forget_cached_source_info_for_objfile): Likewise.
8843         (forget_cached_source_info): Likewise.
8844         (identify_source_line): Likewise.
8845         * source.h (identify_source_line): Move declaration from symtab.h
8846         and add comment from source.c
8847         (print_source_lines): Likewise.
8848         (forget_cached_source_info_for_objfile): Likewise.
8849         (forget_cached_source_info): Likewise.
8850         (select_source_symtab): Likewise.
8851         (enum print_source_lines_flag): Move definition from symtab.h.
8852         * symtab.h (identify_source_line): Move declaration to source.h.
8853         (print_source_lines): Likewise.
8854         (forget_cached_source_info_for_objfile): Likewise.
8855         (forget_cached_source_info): Likewise.
8856         (select_source_symtab): Likewise.
8857         (enum print_source_lines_flag): Move definition to source.h.
8858         * tui/tui-hooks.c: Add 'source.h' include.
8859
8860 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8861
8862         * source.c (print_source_lines_base): Handle requests to print
8863         reverse line number sequences, and guard against empty lines
8864         string.
8865
8866 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * source.c (print_source_lines_base): Fix skip of '\r' if next
8869         character is '\n'.
8870
8871 2019-01-06  Tom Tromey  <tom@tromey.com>
8872
8873         * c-exp.y (struct c_parse_state) <macro_original_text,
8874         expansion_obstack>: New member.
8875         (macro_original_text, expansion_obstack): Remove globals.
8876         (scan_macro_expansion, scanning_macro_expansion)
8877         (finished_macro_expansion): Update.
8878         (scan_macro_cleanup): Remove.
8879         (yylex, c_parse): Update.
8880
8881 2019-01-06  Tom Tromey  <tom@tromey.com>
8882
8883         * c-exp.y (struct c_parse_state) <strings>: New member.
8884         (operator_stoken): Update.
8885
8886 2019-01-06  Tom Tromey  <tom@tromey.com>
8887
8888         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8889         (union type_stack_elt) <typelist_val>: Now a pointer to
8890         std::vector.
8891         (type_stack_cleanup): Don't declare.
8892         (push_typelist): Update.
8893         * parse.c (pop_typelist): Return a std::vector.
8894         (push_typelist): Take a std::vector.
8895         (follow_types): Update.  Do not free args.
8896         (type_stack_cleanup): Remove.
8897         * c-exp.y (struct c_parse_state): New.
8898         (cpstate): New global.
8899         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8900         (nonempty_typelist): Update.
8901         (func_mod): Create a new vector.
8902         (c_parse): Create a c_parse_state.
8903         (check_parameter_typelist): Do not delete params.
8904         (function_method): Update.  Do not delete type_list.
8905
8906 2019-01-06  Tom Tromey  <tom@tromey.com>
8907
8908         PR gdb/28155:
8909         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8910         check_typedef.
8911         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8912         (print_return_value): Likewise.
8913
8914 2019-01-05  Tom Tromey  <tom@tromey.com>
8915
8916         * contrib/cleanup_check.py: Remove.
8917         * contrib/gcc-with-excheck: Remove.
8918         * contrib/exsummary.py: Remove.
8919         * contrib/excheck.py: Remove.
8920
8921 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8922
8923         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8924         NULL. Initialize tpprev to NULL instead of assigning it
8925         to NULL on the next statement.
8926         * windows-nat.c (windows_delete_thread): Remove check for
8927         main_thread_id before printing thread exit notifications.
8928         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8929         Remove thread ID check against main_thread_id.
8930         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8931         windows_delete_thread.
8932         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8933
8934 2019-01-04  Tom Tromey  <tom@tromey.com>
8935
8936         * compile/compile.c (_initialize_compile): Use upper case for
8937         metasyntactic variables.
8938         * symmisc.c (_initialize_symmisc): Use upper case for
8939         metasyntactic variables.
8940         * psymtab.c (_initialize_psymtab): Use upper case for
8941         metasyntactic variables.
8942         * demangle.c (demangle_command): Use upper case for metasyntactic
8943         variables.
8944         (_initialize_demangler): Likewise.
8945         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8946         variables.
8947
8948 2019-01-03  Tom Tromey  <tom@tromey.com>
8949
8950         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8951
8952 2019-01-03  Tom Tromey  <tom@tromey.com>
8953
8954         * python/py-symtab.c (salpy_str): Update.
8955         (struct salpy_sal_object) <symtab>: Now a PyObject.
8956         (salpy_dealloc): Update.
8957         (del_objfile_sal): Use gdbpy_ref.
8958
8959 2019-01-03  Tom Tromey  <tom@tromey.com>
8960
8961         * python/py-type.c (convert_field): Use new_reference.  Return
8962         gdbpy_ref.
8963         (make_fielditem): Return gdbpy_ref.
8964         (typy_fields): Update.
8965         (typy_getitem): Update.
8966         (field_name): Return gdbpy_ref.  Use new_reference.
8967         (typy_iterator_iternext): Update.
8968
8969 2019-01-03  Tom Tromey  <tom@tromey.com>
8970
8971         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8972
8973 2019-01-03  Tom Tromey  <tom@tromey.com>
8974
8975         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8976         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8977         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8978         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8979         (pspy_set_type_printers): Likewise.
8980         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8981         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8982         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8983         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8984         (objfpy_set_type_printers): Likewise.
8985
8986 2019-01-03  Tom Tromey  <tom@tromey.com>
8987
8988         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8989         (gdbpy_print_stack): Use gdbpy_err_fetch.
8990         * python/python-internal.h (class gdbpy_err_fetch): New class.
8991         (class gdbpy_enter) <m_error_type, m_error_value,
8992         m_error_traceback>: Remove.
8993         <m_error>: New member.
8994         (gdbpy_exception_to_string): Don't declare.
8995         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8996         * python/py-value.c (convert_value_from_python): Use
8997         gdbpy_err_fetch.
8998         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8999         gdbpy_exception_to_string.
9000         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9001         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9002         gdbpy_err_fetch.
9003
9004 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9005
9006         * linux-nat.c (delete_lwp_cleanup): Delete.
9007         (struct lwp_deleter): New struct.
9008         (lwp_info_up): New typedef.
9009         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9010         lwp_info_up.
9011
9012 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9013
9014         * linux-fork.c (class scoped_switch_fork_info): New class.
9015         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9016
9017 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9018
9019         * valops.c (find_overload_match): Remove use of null_cleanup, and
9020         calls to do_cleanups.
9021
9022 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9023
9024         * compile/compile-cplus-types.c
9025         (compile_cplus_instance::decl_name): Handle changes to
9026         cp_func_name.
9027         * cp-support.c (cp_func_name): Update header comment, update
9028         return type.
9029         * cp-support.h (cp_func_name): Update return type in declaration.
9030         * valops.c (find_overload_match): Move temp_func local to top
9031         level of function and change its type.  Use temp_func to hold and
9032         delete temporary string obtained from cp_func_name.
9033
9034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9035
9036         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9037         gdb::char_vector, remove cleanup, and update uses of `msg`.
9038
9039 2019-01-03  Jim Wilson  <jimw@sifive.com>
9040
9041         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9042
9043 2019-01-02  Tom Tromey  <tom@tromey.com>
9044
9045         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9046         (tdesc_parse_xml): Remove cleanups.
9047         * target-descriptions.h (make_cleanup_free_target_description):
9048         Don't declare.
9049         (target_desc_deleter): New struct.
9050         (target_desc_up): New typedef.
9051         * target-descriptions.c (target_desc_deleter::operator()): Rename
9052         from free_target_description.
9053         (make_cleanup_free_target_description): Remove.
9054
9055 2019-01-02  Tom Tromey  <tom@tromey.com>
9056
9057         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9058         constructor, destructor.
9059         (linespec_parser): Remove typedef.
9060         (~linespec_parser): Rename from linespec_parser_delete.
9061         (linespec_lex_to_end, linespec_complete_label)
9062         (linespec_complete): Update.
9063         (decode_line_full): Remove cleanups.
9064         (decode_line_1): Update.
9065
9066 2019-01-02  Tom Tromey  <tom@tromey.com>
9067
9068         * python/python-internal.h (inferior_to_inferior_object): Change
9069         return type.
9070         * python/py-exitedevent.c (create_exited_event_object): Update.
9071         * python/py-inferior.c (inferior_to_inferior_object): Return
9072         gdbpy_ref.
9073         (python_new_inferior, python_inferior_deleted)
9074         (thread_to_thread_object, delete_thread_object)
9075         (build_inferior_list, gdbpy_selected_inferior): Update.
9076         * python/py-infthread.c (create_thread_object): Update.  Also fail
9077         if inferior_to_inferior_object fails.
9078
9079 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9080
9081         * inferior.h (class inferior) <displaced_step_state>: New field.
9082         * infrun.h (struct displaced_step_state): Move here from
9083         infrun.c.  Initialize fields, add constructor.
9084         <inf>: Remove field.
9085         <reset>: New method.
9086         * infrun.c (struct displaced_step_inferior_state): Move to
9087         infrun.h.
9088         (displaced_step_inferior_states): Remove.
9089         (get_displaced_stepping_state): Adust.
9090         (displaced_step_in_progress_any_inferior): Adjust.
9091         (displaced_step_in_progress_thread): Adjust.
9092         (displaced_step_in_progress): Adjust.
9093         (add_displaced_stepping_state): Remove.
9094         (get_displaced_step_closure_by_addr): Adjust.
9095         (remove_displaced_stepping_state): Remove.
9096         (infrun_inferior_exit): Call displaced_step_state.reset.
9097         (use_displaced_stepping): Don't check for NULL.
9098         (displaced_step_prepare_throw): Call
9099         get_displaced_stepping_state.
9100         (displaced_step_fixup): Don't check for NULL.
9101         (prepare_for_detach): Don't check for NULL.
9102
9103 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9104
9105         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9106          in case of call that did not complete.
9107
9108 2019-01-02  Andrey Utkin  <autkin@undo.io>
9109
9110         * symfile.c (find_separate_debug_file): Fix search of debug files for
9111         remote debuggee.
9112
9113 2019-01-02  Tom Tromey  <tom@tromey.com>
9114
9115         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9116         indentation.
9117         * python/py-frame.c (frapy_older): Remove cast.
9118         (frapy_newer): Likewise.
9119         * python/py-breakpoint.c (local_setattro): Remove cast.
9120         * python/py-arch.c (archpy_name): Remove local variable.
9121         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9122
9123 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9124
9125         * unittests/basic_string_view/element_access/char/empty.cc:
9126         Fix year range in copyright header.
9127
9128 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9129
9130         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9131         Delete.
9132         <operator==>: Update with for removed field.
9133         <hash>: Likewise.
9134         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9135         <isa_features>: ...this.
9136         <abi_features>: New field.
9137         (riscv_isa_flen): Update comment.
9138         (riscv_abi_xlen): New declaration.
9139         (riscv_abi_flen): New declaration.
9140         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9141         isa_features.
9142         (riscv_abi_xlen): New function.
9143         (riscv_isa_flen): Update to get answer from isa_features.
9144         (riscv_abi_flen): New function.
9145         (riscv_has_fp_abi): Update to get answer from abi_features.
9146         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9147         xlen and flen.
9148         (riscv_call_info) <xlen, flen>: Update comment.
9149         (riscv_call_arg_struct): Remove invalid assertions
9150         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9151         is removed.
9152         (riscv_gdbarch_init): Gather isa features and abi features
9153         separately, ensure both match on the gdbarch when reusing an old
9154         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9155         a target with 64-bit float hardware.
9156
9157 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9158
9159         * source.c (search_command_helper): Stop reverse search
9160         when line 1 has been searched.
9161
9162 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9163
9164         * record-full.c (record_full_base_target::close): Rewrite
9165         record_full_core_buf_list free logic.
9166
9167 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9168
9169         * break-catch-syscall.c (print_one_catch_syscall): xfree
9170         the last text.
9171
9172 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9173
9174         * top.c (print_gdb_version): Update Copyright year in version
9175         message.
9176
9177 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9178
9179         Update copyright year range in all GDB files.
9180
9181 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9182
9183         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9184
9185 For older changes see ChangeLog-2018.
9186 \f
9187 Local Variables:
9188 mode: change-log
9189 left-margin: 8
9190 fill-column: 74
9191 version-control: never
9192 coding: utf-8
9193 End:
9194