Merge handle_inferior_event and handle_inferior_event_1
[external/binutils.git] / gdb / ChangeLog
1 2019-03-20  Tom Tromey  <tromey@adacore.com>
2
3         PR gdb/24391
4         * infrun.c (handle_inferior_event): Rename from
5         handle_inferior_event_1.  Create a scoped_value_mark.
6         (handle_inferior_event): Remove.
7
8 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9
10         * source-cache.c (source_cache::get_source_lines): Re-read
11         fullname after calling open_source_file.
12
13 2019-03-18  Pedro Alves  <palves@redhat.com>
14             Eli Zaretskii <eliz@gnu.org>
15
16         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
17         m_line and m_start_of_line.
18
19 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
20
21         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
22         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
23         it returns a newline.  This fixes a regression in TU mode, whereby
24         the next line is output on the same screen line as the user input.
25
26 2019-03-18  Pedro Alves  <palves@redhat.com>
27
28         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
29         New globals.
30         (apply_style): New, factored out from ...
31         (apply_ansi_escape): ... this.  Handle reverse video mode.
32         (tui_set_reverse_mode): New function.
33         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
34         * tui/tui-winsource.c (tui_show_source_line): Use
35         tui_set_reverse_mode instead of setting A_STANDOUT.
36         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
37         New setter methods.
38
39 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
40
41         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
42         Handle tabs.
43
44 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
45
46         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
47         tui_refill_source_window instead of tui_refresh_win, to update the
48         current execution line.  This fixes redisplay of the current line
49         when stepping through the code with "next" or "step".
50
51 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
52
53         * source-cache.c (source_cache::get_source_lines): Call
54         find_source_lines to initialize s->nlines.  This fixes vertical
55         scrolling of TUI source window when the DOWN arrow is pressed.
56
57 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
58
59         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
60         wclrtoeol in tui_show_source_line".  This reverts changes made in
61         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
62
63 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
64
65         * NEWS: Combine separate "New targets" sections for 8.3.
66
67 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
68
69         The MS-Windows port of ncurses fails to switch to a color pair if
70         one or both of the colors are the implicit default colors.  This
71         change records the default colors when TUI is initialized, and
72         then specifies them explicitly when a color pair uses the default
73         colors.  This allows color styling in TUI mode on MS-Windows.
74
75         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
76         ncurses_norm_attr.
77         (tui_initialize_io) [__MINGW32__]: Record the default terminal
78         colors in ncurses_norm_attr.
79         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
80         "none", replace it with the default color recorded in
81         ncurses_norm_attr.
82
83 2019-03-14  Tom Tromey  <tromey@adacore.com>
84
85         * source-cache.h (class source_cache) <get_source_lines>: Return
86         std::string.
87         * source-cache.c (source_cache::extract_lines): Handle case where
88         first_pos==npos.  Return std::string.
89         (source_cache::get_source_lines): Update.
90
91 2019-03-14  Tom Tromey  <tromey@adacore.com>
92
93         * NEWS: Add item for "style sources" commands.
94         * source-cache.c (source_cache::get_source_lines): Check
95         source_styling.
96         * cli/cli-style.c (source_styling): New global.
97         (_initialize_cli_style): Add "style sources" commands.
98         (show_style_sources): New function.
99         * cli/cli-style.h (source_styling): Declare.
100
101 2019-03-14  Pedro Alves  <palves@redhat.com>
102             Tom Tromey  <tromey@adacore.com>
103
104         * tui/tui-winsource.h (tui_refill_source_window): Declare.
105         * tui/tui-winsource.c (tui_refill_source_window): New function,
106         from...
107         (tui_horizontal_source_scroll): ... here.  Move some logic.
108         * cli/cli-style.c (set_style_enabled): Notify new observable.
109         * tui/tui-hooks.c (tui_redisplay_source): New function.
110         (tui_attach_detach_observers): Attach or detach
111         tui_redisplay_source.
112         * observable.h (source_styling_changed): New observable.
113         * observable.c: Define source_styling_changed observable.
114
115 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
116
117         PR/24325
118         * source-cache.c: #undef open and close, to avoid unresolved
119         externals during linking.
120
121 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
122
123         Support styling on native MS-Windows console
124
125         PR/24315
126         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
127         on MS-Windows if $TERM is not defined.
128
129         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
130
131         * posix-hdep.c (gdb_console_fputs):
132         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
133         functions.
134         * ui-file.h (gdb_console_fputs): Add prototype.
135
136         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
137         back to fputs only if the former returns zero.
138
139 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
140             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
141
142         PR gdb/8527
143         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
144         set_sigint_trap, clear_sigint_trap.
145
146 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
147
148         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
149         for-loop range, to avoid compiler warnings.
150
151         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
152         avoid compiler warnings about unused variables.
153
154 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
155
156         * NEWS: Mention end of support for native debugging on MS-Windows
157         before XP.
158
159 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
160
161         PR gdb/24292
162         * common/netstuff.c:
163         * gdbserver/gdbreplay.c
164         * gdbserver/remote-utils.c:
165         * ser-tcp.c:
166         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
167         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
168         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
169         'getaddrinfo' and 'freeaddrinfo' were not available before
170         Windows XP, and mingw.org's MinGW headers by default define
171         _WIN32_WINNT to 0x500.
172
173 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
174     
175         * NEWS: Note minimum Python version.
176
177 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
178
179         * version.in: Set GDB version number to 8.2.90.DATE-git.
180
181 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
182
183         GDB 8.2.90 released.
184
185 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
186
187         * version.in: Set GDB version number to 8.2.90.
188
189 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
190
191         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
192
193 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
194
195         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
196         * version.in: Bump version to 8.2.90.DATE-git.
197
198 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
199
200         * aix-thread.c (ptid_cmp): Remove unused variable.
201         (get_signaled_thread): Likewise.
202         (store_regs_user_thread): Likewise.
203         (store_regs_kernel_thread): Likewise.
204         (fetch_regs_kernel_thread): Remove shadowed variable.
205
206 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
207
208         * features/riscv/32bit-cpu.xml: Add register numbers.
209         * features/riscv/32bit-fpu.c: Regenerate.
210         * features/riscv/32bit-fpu.xml: Add register numbers.
211         * features/riscv/64bit-cpu.xml: Add register numbers.
212         * features/riscv/64bit-fpu.c: Regenerate.
213         * features/riscv/64bit-fpu.xml: Add register numbers.
214
215 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
216
217         * NEWS: Mention two argument form of gdb.Value constructor.
218         * python/py-value.c (convert_buffer_and_type_to_value): New
219         function.
220         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
221         Add support for handling an optional second argument.  Call
222         convert_buffer_and_type_to_value as appropriate.
223         * python/python-internal.h (Py_buffer_deleter): New struct.
224         (Py_buffer_up): New typedef.
225
226 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
227
228         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
229         instead of releasing ownership.
230
231 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
232
233         * dwarf2read.c (open_and_init_dwp_file): Call
234         elf_numsections instead of bfd_count_sections to initialize
235         dwp_file->num_sections.
236
237 2019-02-25  Tom Tromey  <tromey@adacore.com>
238
239         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
240
241 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
242
243         * gcore.in: Add '--readnever' option when invoking GDB.
244
245 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
246
247         * MAINTAINERS: Update my email address.
248
249 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
250
251         * build-id.c (build_id_to_debug_bfd_1): New function.
252         (build_id_to_debug_bfd): Look for separate debug file in
253         sysroot.
254
255 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
256
257         * gdbarch.sh: Update the copyright year range that is placed into
258         generated files.
259
260 2019-02-22  Keith Seitz  <keiths@redhat.com>
261
262         PR symtab/23853
263         * linespec.c (create_sals_line_offset): Search for the default
264         symtab's filename instead of its fullname.
265
266 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
267
268         * NEWS: Update style defaults.
269
270 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
271
272         * main.c (captured_main_1): Disable styling in batch mode.
273
274 2019-02-20  Tom Tromey  <tom@tromey.com>
275
276         * symtab.c (symtab_symbol_info): Fix typos.
277
278 2019-02-20  Tom Tromey  <tromey@adacore.com>
279
280         * findcmd.c (_initialize_mem_search): Use upper case for
281         metasyntactic variables.
282
283 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
284
285         * aarch64-tdep.c (aarch64_add_reggroups): New function.
286         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
287
288 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
289
290         * top.h (source_file_name): Change to std::string.
291         * top.c (source_file_name): Likewise.
292         (command_line_input): Adjust.
293         * cli/cli-script.c (script_from_file): Adjust.
294
295 2019-02-19  Tom Tromey  <tromey@adacore.com>
296
297         * ravenscar-thread.c
298         (ravenscar_thread_target::update_thread_list): Don't call
299         ada_build_task_list.
300         * ada-lang.h (ada_build_task_list): Don't declare.
301         * ada-tasks.c (struct ada_tasks_inferior_data)
302         <task_list_valid_p>: Now bool.
303         (read_known_tasks, ada_task_list_changed)
304         (ada_tasks_invalidate_inferior_data): Update.
305         (read_known_tasks_array): Return bool.
306         (read_known_tasks_list): Likewise.
307         (read_known_tasks): Return void.
308         (ada_build_task_list): Now static.
309
310 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
311
312         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
313         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
314
315 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
316
317         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
318         variant for ada_tasks_pspace_data_handle and
319         ada_tasks_inferior_data_handle.
320         (ada_tasks_pspace_data_cleanup): New function.
321         (ada_tasks_inferior_data_cleanup): New function.
322
323 2019-02-17  Tom Tromey  <tom@tromey.com>
324
325         * macrotab.h (macro_source_fullname): Return a std::string.
326         * macrotab.c (macro_include, check_for_redefinition)
327         (macro_undef, macro_lookup_definition, foreach_macro)
328         (foreach_macro_in_scope): Update.
329         (macro_source_fullname): Return a std::string.
330         * macrocmd.c (show_pp_source_pos): Update.
331
332 2019-02-17  Tom Tromey  <tom@tromey.com>
333
334         * macrocmd.c (show_pp_source_pos): Style the file names.
335
336 2019-02-17  Tom Tromey  <tom@tromey.com>
337
338         PR tui/24197:
339         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
340
341 2019-02-17  Tom Tromey  <tom@tromey.com>
342
343         * ada-lang.c (user_select_syms): Use filtered printing.
344         * utils.c (wrap_style): New global.
345         (desired_style): Remove.
346         (emit_style_escape): Add stream parameter.
347         (set_output_style, reset_terminal_style, prompt_for_continue):
348         Update.
349         (flush_wrap_buffer): Only flush gdb_stdout.
350         (wrap_here): Set wrap_style.
351         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
352         treat escape sequences as a character.  Change when wrap buffer is
353         flushed.
354         (fputs_styled): Do not set the output style when the default is
355         requested.
356         * ui-style.h (struct ui_file_style) <is_default>: New method.
357         * source.c (print_source_lines_base): Emit escape sequences in one
358         piece.
359
360 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
361
362         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
363         integers and enumeration types.
364
365 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
366
367         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
368         instead of lookup_symbol_in_language
369         (do_exact_match): New function.
370         (ada_get_symbol_name_matcher): Return do_exact_match when
371         doing a verbatim match.
372
373 2019-02-15  Tom Tromey  <tromey@adacore.com>
374
375         * ravenscar-thread.c (ravenscar_thread_target::resume)
376         (ravenscar_thread_target::wait): Special case wildcard requests.
377
378 2019-02-15  Tom Tromey  <tromey@adacore.com>
379
380         * ravenscar-thread.c (base_ptid): Remove.
381         (struct ravenscar_thread_target) <close>: New method.
382         <m_base_ptid>: New member.
383         <update_inferior_ptid, active_task, task_is_currently_active,
384         runtime_initialized>: Declare methods.
385         <ravenscar_thread_target>: Add constructor.
386         (ravenscar_thread_target::task_is_currently_active)
387         (ravenscar_thread_target::update_inferior_ptid)
388         (ravenscar_runtime_initialized): Rename.  Now methods.
389         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
390         (ravenscar_thread_target::update_thread_list): Update.
391         (ravenscar_thread_target::active_task): Now method.
392         (ravenscar_thread_target::store_registers)
393         (ravenscar_thread_target::prepare_to_store)
394         (ravenscar_thread_target::prepare_to_store)
395         (ravenscar_thread_target::mourn_inferior): Update.
396         (ravenscar_inferior_created): Use "new" to create target.
397         (ravenscar_thread_target::get_ada_task_ptid): Update.
398         (_initialize_ravenscar): Don't initialize base_ptid.
399         (ravenscar_ops): Remove global.
400
401 2019-02-15  Tom Tromey  <tromey@adacore.com>
402
403         * target.h (push_target): Declare new overload.
404         * target.c (push_target): New overload, taking an rvalue reference.
405         * remote.c (remote_target::open_1): Use push_target overload.
406         * corelow.c (core_target_open): Use push_target overload.
407
408 2019-02-15  Tom Tromey  <tromey@adacore.com>
409
410         * ravenscar-thread.c (is_ravenscar_task)
411         (ravenscar_task_is_currently_active): Return bool.
412         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
413         (_initialize_ravenscar): Remove "(void)".
414         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
415         Return bool.
416
417 2019-02-15  Tom Tromey  <tromey@adacore.com>
418
419         * ravenscar-thread.c (ravenscar_runtime_initializer)
420         (has_ravenscar_runtime, get_running_thread_id)
421         (ravenscar_thread_target::resume): Fix indentation.
422
423 2019-02-15  Tom Tromey  <tromey@adacore.com>
424
425         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
426         from ravenscar_arch_ops.
427         (sparc_ravenscar_ops::fetch_registers)
428         (sparc_ravenscar_ops::store_registers): Now methods.
429         (sparc_ravenscar_prepare_to_store): Remove.
430         (sparc_ravenscar_ops): Redefine.
431         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
432         methods and destructor.  Remove members.
433         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
434         (ravenscar_thread_target::store_registers)
435         (ravenscar_thread_target::prepare_to_store): Update.
436         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
437         Remove.
438         (struct ppc_ravenscar_powerpc_ops): Derive from
439         ravenscar_arch_ops.
440         (ppc_ravenscar_powerpc_ops::fetch_registers)
441         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
442         (ppc_ravenscar_powerpc_ops): Redefine.
443         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
444         (ppc_ravenscar_e500_ops::fetch_registers)
445         (ppc_ravenscar_e500_ops::store_registers): Now methods.
446         (ppc_ravenscar_e500_ops): Redefine.
447         * aarch64-ravenscar-thread.c
448         (aarch64_ravenscar_generic_prepare_to_store): Remove.
449         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
450         (aarch64_ravenscar_fetch_registers)
451         (aarch64_ravenscar_store_registers): Now methods.
452         (aarch64_ravenscar_ops): Redefine.
453
454 2019-02-15  Tom Tromey  <tromey@adacore.com>
455
456         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
457         (ravenscar_thread_target::stopped_by_hw_breakpoint)
458         (ravenscar_thread_target::stopped_by_watchpoint)
459         (ravenscar_thread_target::stopped_data_address)
460         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
461
462 2019-02-15  Tom Tromey  <tromey@adacore.com>
463
464         * ravenscar-thread.c: Fix some typos.
465
466 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
467             Tom Tromey  <tromey@adacore.com>
468
469         * ada-lang.c (ada_exception_sal): Change addr_string to a
470         std::string.
471         (create_ada_exception_catchpoint): Update.
472
473 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
474             Tom Tromey  <tromey@adacore.com>
475
476         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
477         (bp_location_ops): Remove.
478         (base_breakpoint_allocate_location): Update.
479         (free_bp_location): Update.
480         * ada-lang.c (class ada_catchpoint_location)
481         <ada_catchpoint_location>: Remove ops parameter.
482         (ada_catchpoint_location_dtor): Remove.
483         (ada_catchpoint_location_ops): Remove.
484         (allocate_location_exception): Update.
485         * breakpoint.h (struct bp_location_ops): Remove.
486         (class bp_location) <bp_location>: Remove bp_location_ops
487         parameter.
488         <~bp_location>: Add destructor.
489         <ops>: Remove.
490
491 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
492             Pedro Alves  <palves@redhat.com>
493
494         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
495         'PATH_MAX'.
496
497 2019-02-14  David Michael  <fedora.dm0@gmail.com>
498             Samuel Thibault  <samuel.thibault@gnu.org>
499             Thomas Schwinge  <thomas@codesourcery.com>
500
501         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
502         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
503
504 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
505
506         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
507         (check_empty): Use "const char *".
508
509         * gnu-nat.c (gnu_nat_target::detach): Instead of
510         'detach_inferior (pid)' call
511         'detach_inferior (find_inferior_pid (pid))'.
512
513         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
514         'nat/fork-inferior.o'.
515         * gnu-nat.c: #include "nat/fork-inferior.h".
516
517         * gnu-nat.c (gnu_nat_target::detach): Instead of
518         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
519         * gnu-nat.h: #include "inf-child.h".
520         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
521         'i386_gnu_nat_target::fetch_registers'.
522         (gnu_store_registers): Rename/move to
523         'i386_gnu_nat_target::store_registers'.
524
525         * config/i386/nm-i386gnu.h: Don't "#include" any files.
526         * gnu-nat.h (mach_thread_info): New function.
527         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
528
529         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
530
531 2019-02-14  Frederic Konrad  <konrad@adacore.com>
532
533         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
534
535 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
536
537         * windows-nat.c (windows_add_thread): Add new parameter
538         "main_thread_p" with default value set to false.  Update
539         function documentation as well as all callers.
540         (windows_delete_thread): Likewise.
541         (fake_create_process): Update call to windows_add_thread.
542         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
543         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
544         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
545         call to windows_delete_thread.
546
547 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
548
549         * MAINTAINERS: Add Andrew Burgess as global maintainer.
550
551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
552
553         * symfile.c (find_separate_debug_file): Use canonical path of
554         sysroot with child_path instead of gdb_sysroot if it is valid.
555
556 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
557
558         * symfile.c (find_separate_debug_file): Use child_path to
559         determine if an object file is under a sysroot.
560
561 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
562
563         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
564         unittests/child-path-selftests.c.
565         * common/pathstuff.c (child_path): New function.
566         * common/pathstuff.h (child_path): New prototype.
567         * unittests/child-path-selftests.c: New file.
568
569 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
570
571         * symfile.c (find_separate_debug_file): Look for separate debug
572         files in debug directories under the sysroot.
573
574 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
575
576         * symtab.h (struct minimal_symbol data_p): New const method.
577         (struct minimal_symbol text_p): Likewise.
578         * symtab.c (output_source_filename): Use file name style
579         to print file name.
580         (print_symbol_info): Likewise.
581         (print_msymbol_info): Use address style to print addresses.
582         Use function name style to print executable text symbols.
583         (expand_symtab_containing_pc): Use data_p.
584         (find_pc_sect_compunit_symtab): Likewise.
585
586 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
587
588         * breakpoint.c (describe_other_breakpoints): Use address style
589         to print addresses.
590         (say_where): Likewise.
591
592 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
593
594         * ada-typeprint.c (print_func_type): Print function name
595         style to print function name.
596         * c-typeprint.c (c_print_type_1): Likewise.
597
598 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
599
600         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
601         for execve.
602
603 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
604
605         * c-exp.y (direct_abs_decl): Use emplace_back to record the
606         type_stack.
607
608 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
609
610         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
611         TYPE_CODE_REF types.
612
613 2019-02-08  Jim Wilson  <jimw@sifive.com>
614
615         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
616         (riscv_linux_fregset): New.
617         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
618
619 2019-02-07  Tom Tromey  <tom@tromey.com>
620
621         * thread.c (thread_cancel_execution_command): Update.
622         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
623         methods.
624         (struct thread_fsm_ops): Remove.
625         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
626         (thread_fsm_should_stop, thread_fsm_return_value)
627         (thread_fsm_set_finished, thread_fsm_finished_p)
628         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
629         Don't declare.
630         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
631         * infrun.c (clear_proceed_status_thread)
632         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
633         (print_stop_event): Update.
634         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
635         Add constructor.
636         (step_command_fsm_ops): Remove.
637         (new_step_command_fsm): Remove.
638         (step_1): Update.
639         (step_command_fsm::should_stop): Rename from
640         step_command_fsm_should_stop.
641         (step_command_fsm::clean_up): Rename from
642         step_command_fsm_clean_up.
643         (step_command_fsm::do_async_reply_reason): Rename from
644         step_command_fsm_async_reply_reason.
645         (struct until_next_fsm): Inherit from thread_fsm.  Add
646         constructor.
647         (until_next_fsm_ops): Remove.
648         (new_until_next_fsm): Remove.
649         (until_next_fsm::should_stop): Rename from
650         until_next_fsm_should_stop.
651         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
652         (until_next_fsm::do_async_reply_reason): Rename from
653         until_next_fsm_async_reply_reason.
654         (struct finish_command_fsm): Inherit from thread_fsm.  Add
655         constructor.  Change type of breakpoint.
656         (finish_command_fsm_ops): Remove.
657         (new_finish_command_fsm): Remove.
658         (finish_command_fsm::should_stop): Rename from
659         finish_command_fsm_should_stop.
660         (finish_command_fsm::clean_up): Rename from
661         finish_command_fsm_clean_up.
662         (finish_command_fsm::return_value): Rename from
663         finish_command_fsm_return_value.
664         (finish_command_fsm::do_async_reply_reason): Rename from
665         finish_command_fsm_async_reply_reason.
666         (finish_command): Update.
667         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
668         Add constructor.
669         (call_thread_fsm_ops): Remove.
670         (call_thread_fsm::call_thread_fsm): Rename from
671         new_call_thread_fsm.
672         (call_thread_fsm::should_stop): Rename from
673         call_thread_fsm_should_stop.
674         (call_thread_fsm::should_notify_stop): Rename from
675         call_thread_fsm_should_notify_stop.
676         (run_inferior_call, call_function_by_hand_dummy): Update.
677         * cli/cli-interp.c (should_print_stop_to_console): Update.
678         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
679         Add constructor.  Change type of location_breakpoint,
680         caller_breakpoint.
681         (until_break_fsm_ops): Remove.
682         (new_until_break_fsm): Remove.
683         (until_break_fsm::should_stop): Rename from
684         until_break_fsm_should_stop.
685         (until_break_fsm::clean_up): Rename from
686         until_break_fsm_clean_up.
687         (until_break_fsm::do_async_reply_reason): Rename from
688         until_break_fsm_async_reply_reason.
689         (until_break_command): Update.
690         * thread-fsm.c: Remove.
691         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
692
693 2019-02-07  Tom Tromey  <tom@tromey.com>
694
695         * yy-remap.h: Add include guard.
696         * xtensa-tdep.h: Add include guard.
697         * xcoffread.h: Rename include guard.
698         * varobj-iter.h: Add include guard.
699         * tui/tui.h: Rename include guard.
700         * tui/tui-winsource.h: Rename include guard.
701         * tui/tui-wingeneral.h: Rename include guard.
702         * tui/tui-windata.h: Rename include guard.
703         * tui/tui-win.h: Rename include guard.
704         * tui/tui-stack.h: Rename include guard.
705         * tui/tui-source.h: Rename include guard.
706         * tui/tui-regs.h: Rename include guard.
707         * tui/tui-out.h: Rename include guard.
708         * tui/tui-layout.h: Rename include guard.
709         * tui/tui-io.h: Rename include guard.
710         * tui/tui-hooks.h: Rename include guard.
711         * tui/tui-file.h: Rename include guard.
712         * tui/tui-disasm.h: Rename include guard.
713         * tui/tui-data.h: Rename include guard.
714         * tui/tui-command.h: Rename include guard.
715         * tic6x-tdep.h: Add include guard.
716         * target/waitstatus.h: Rename include guard.
717         * target/wait.h: Rename include guard.
718         * target/target.h: Rename include guard.
719         * target/resume.h: Rename include guard.
720         * target-float.h: Rename include guard.
721         * stabsread.h: Add include guard.
722         * rs6000-tdep.h: Add include guard.
723         * riscv-fbsd-tdep.h: Add include guard.
724         * regformats/regdef.h: Rename include guard.
725         * record.h: Rename include guard.
726         * python/python.h: Rename include guard.
727         * python/python-internal.h: Rename include guard.
728         * python/py-stopevent.h: Rename include guard.
729         * python/py-ref.h: Rename include guard.
730         * python/py-record.h: Rename include guard.
731         * python/py-record-full.h: Rename include guard.
732         * python/py-record-btrace.h: Rename include guard.
733         * python/py-instruction.h: Rename include guard.
734         * python/py-events.h: Rename include guard.
735         * python/py-event.h: Rename include guard.
736         * procfs.h: Add include guard.
737         * proc-utils.h: Add include guard.
738         * p-lang.h: Add include guard.
739         * or1k-tdep.h: Rename include guard.
740         * observable.h: Rename include guard.
741         * nto-tdep.h: Rename include guard.
742         * nat/x86-linux.h: Rename include guard.
743         * nat/x86-linux-dregs.h: Rename include guard.
744         * nat/x86-gcc-cpuid.h: Add include guard.
745         * nat/x86-dregs.h: Rename include guard.
746         * nat/x86-cpuid.h: Rename include guard.
747         * nat/ppc-linux.h: Rename include guard.
748         * nat/mips-linux-watch.h: Rename include guard.
749         * nat/linux-waitpid.h: Rename include guard.
750         * nat/linux-ptrace.h: Rename include guard.
751         * nat/linux-procfs.h: Rename include guard.
752         * nat/linux-osdata.h: Rename include guard.
753         * nat/linux-nat.h: Rename include guard.
754         * nat/linux-namespaces.h: Rename include guard.
755         * nat/linux-btrace.h: Rename include guard.
756         * nat/glibc_thread_db.h: Rename include guard.
757         * nat/gdb_thread_db.h: Rename include guard.
758         * nat/gdb_ptrace.h: Rename include guard.
759         * nat/fork-inferior.h: Rename include guard.
760         * nat/amd64-linux-siginfo.h: Rename include guard.
761         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
762         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
763         * nat/aarch64-linux.h: Rename include guard.
764         * nat/aarch64-linux-hw-point.h: Rename include guard.
765         * mn10300-tdep.h: Add include guard.
766         * mips-linux-tdep.h: Add include guard.
767         * mi/mi-parse.h: Rename include guard.
768         * mi/mi-out.h: Rename include guard.
769         * mi/mi-main.h: Rename include guard.
770         * mi/mi-interp.h: Rename include guard.
771         * mi/mi-getopt.h: Rename include guard.
772         * mi/mi-console.h: Rename include guard.
773         * mi/mi-common.h: Rename include guard.
774         * mi/mi-cmds.h: Rename include guard.
775         * mi/mi-cmd-break.h: Rename include guard.
776         * m2-lang.h: Add include guard.
777         * location.h: Rename include guard.
778         * linux-record.h: Rename include guard.
779         * linux-nat.h: Add include guard.
780         * linux-fork.h: Add include guard.
781         * i386-darwin-tdep.h: Rename include guard.
782         * hppa-linux-offsets.h: Add include guard.
783         * guile/guile.h: Rename include guard.
784         * guile/guile-internal.h: Rename include guard.
785         * gnu-nat.h: Rename include guard.
786         * gdb-stabs.h: Rename include guard.
787         * frv-tdep.h: Add include guard.
788         * f-lang.h: Add include guard.
789         * event-loop.h: Add include guard.
790         * darwin-nat.h: Rename include guard.
791         * cp-abi.h: Rename include guard.
792         * config/sparc/nm-sol2.h: Rename include guard.
793         * config/nm-nto.h: Rename include guard.
794         * config/nm-linux.h: Add include guard.
795         * config/i386/nm-i386gnu.h: Rename include guard.
796         * config/djgpp/nl_types.h: Rename include guard.
797         * config/djgpp/langinfo.h: Rename include guard.
798         * compile/gcc-cp-plugin.h: Add include guard.
799         * compile/gcc-c-plugin.h: Add include guard.
800         * compile/compile.h: Rename include guard.
801         * compile/compile-object-run.h: Rename include guard.
802         * compile/compile-object-load.h: Rename include guard.
803         * compile/compile-internal.h: Rename include guard.
804         * compile/compile-cplus.h: Rename include guard.
805         * compile/compile-c.h: Rename include guard.
806         * common/xml-utils.h: Rename include guard.
807         * common/x86-xstate.h: Rename include guard.
808         * common/version.h: Rename include guard.
809         * common/vec.h: Rename include guard.
810         * common/tdesc.h: Rename include guard.
811         * common/selftest.h: Rename include guard.
812         * common/scoped_restore.h: Rename include guard.
813         * common/scoped_mmap.h: Rename include guard.
814         * common/scoped_fd.h: Rename include guard.
815         * common/safe-iterator.h: Rename include guard.
816         * common/run-time-clock.h: Rename include guard.
817         * common/refcounted-object.h: Rename include guard.
818         * common/queue.h: Rename include guard.
819         * common/ptid.h: Rename include guard.
820         * common/print-utils.h: Rename include guard.
821         * common/preprocessor.h: Rename include guard.
822         * common/pathstuff.h: Rename include guard.
823         * common/observable.h: Rename include guard.
824         * common/netstuff.h: Rename include guard.
825         * common/job-control.h: Rename include guard.
826         * common/host-defs.h: Rename include guard.
827         * common/gdb_wait.h: Rename include guard.
828         * common/gdb_vecs.h: Rename include guard.
829         * common/gdb_unlinker.h: Rename include guard.
830         * common/gdb_unique_ptr.h: Rename include guard.
831         * common/gdb_tilde_expand.h: Rename include guard.
832         * common/gdb_sys_time.h: Rename include guard.
833         * common/gdb_string_view.h: Rename include guard.
834         * common/gdb_splay_tree.h: Rename include guard.
835         * common/gdb_setjmp.h: Rename include guard.
836         * common/gdb_ref_ptr.h: Rename include guard.
837         * common/gdb_optional.h: Rename include guard.
838         * common/gdb_locale.h: Rename include guard.
839         * common/gdb_assert.h: Rename include guard.
840         * common/filtered-iterator.h: Rename include guard.
841         * common/filestuff.h: Rename include guard.
842         * common/fileio.h: Rename include guard.
843         * common/environ.h: Rename include guard.
844         * common/common-utils.h: Rename include guard.
845         * common/common-types.h: Rename include guard.
846         * common/common-regcache.h: Rename include guard.
847         * common/common-inferior.h: Rename include guard.
848         * common/common-gdbthread.h: Rename include guard.
849         * common/common-exceptions.h: Rename include guard.
850         * common/common-defs.h: Rename include guard.
851         * common/common-debug.h: Rename include guard.
852         * common/cleanups.h: Rename include guard.
853         * common/buffer.h: Rename include guard.
854         * common/btrace-common.h: Rename include guard.
855         * common/break-common.h: Rename include guard.
856         * cli/cli-utils.h: Rename include guard.
857         * cli/cli-style.h: Rename include guard.
858         * cli/cli-setshow.h: Rename include guard.
859         * cli/cli-script.h: Rename include guard.
860         * cli/cli-interp.h: Rename include guard.
861         * cli/cli-decode.h: Rename include guard.
862         * cli/cli-cmds.h: Rename include guard.
863         * charset-list.h: Add include guard.
864         * buildsym-legacy.h: Rename include guard.
865         * bfin-tdep.h: Add include guard.
866         * ax.h: Rename include guard.
867         * arm-linux-tdep.h: Add include guard.
868         * arm-fbsd-tdep.h: Add include guard.
869         * arch/xtensa.h: Rename include guard.
870         * arch/tic6x.h: Add include guard.
871         * arch/i386.h: Add include guard.
872         * arch/arm.h: Rename include guard.
873         * arch/arm-linux.h: Rename include guard.
874         * arch/arm-get-next-pcs.h: Rename include guard.
875         * arch/amd64.h: Add include guard.
876         * arch/aarch64-insn.h: Rename include guard.
877         * arch-utils.h: Rename include guard.
878         * annotate.h: Add include guard.
879         * amd64-darwin-tdep.h: Rename include guard.
880         * aarch64-linux-tdep.h: Add include guard.
881         * aarch64-fbsd-tdep.h: Add include guard.
882         * aarch32-linux-nat.h: Add include guard.
883
884 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
885
886         * macrotab.c (macro_define_internal): New function that
887         factorizes macro_define_object_internal and macro_define_function
888         code.
889         (macro_define_object_internal): Use macro_define_internal.
890         (macro_define_function): Likewise.
891
892 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
893
894         * macrocmd.c (extract_identifier): Return
895         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
896         callers.
897
898 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
899
900         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
901
902 2019-02-05  Tom Tromey  <tom@tromey.com>
903
904         * target.c (target_stack::unpush): Move assertion earlier.
905
906 2019-01-30  Tom Tromey  <tom@tromey.com>
907
908         PR python/23615:
909         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
910         (gdbpy_parse_and_eval): Likewise.
911         * python/python-internal.h (gdbpy_allow_threads): New class.
912
913 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
914
915         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
916         (aarch64_fbsd_fpregmap): Move earlier.
917         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
918         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
919         instead of individual calls to trad_frame_set_reg_addr.
920         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
921         earlier.
922         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
923         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
924         instead of individual calls to trad_frame_set_reg_addr.
925
926 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
927
928         * CONTRIBUTE: Replace contribution list with wiki link.
929
930 2019-01-25  Tom Tromey  <tom@tromey.com>
931
932         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
933
934 2019-01-25  Tom Tromey  <tom@tromey.com>
935
936         * xtensa-linux-nat.c: Fix common/ includes.
937         * xml-support.h: Fix common/ includes.
938         * xml-support.c: Fix common/ includes.
939         * x86-linux-nat.c: Fix common/ includes.
940         * windows-nat.c: Fix common/ includes.
941         * varobj.h: Fix common/ includes.
942         * varobj.c: Fix common/ includes.
943         * value.c: Fix common/ includes.
944         * valops.c: Fix common/ includes.
945         * utils.c: Fix common/ includes.
946         * unittests/xml-utils-selftests.c: Fix common/ includes.
947         * unittests/utils-selftests.c: Fix common/ includes.
948         * unittests/unpack-selftests.c: Fix common/ includes.
949         * unittests/tracepoint-selftests.c: Fix common/ includes.
950         * unittests/style-selftests.c: Fix common/ includes.
951         * unittests/string_view-selftests.c: Fix common/ includes.
952         * unittests/scoped_restore-selftests.c: Fix common/ includes.
953         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
954         * unittests/scoped_fd-selftests.c: Fix common/ includes.
955         * unittests/rsp-low-selftests.c: Fix common/ includes.
956         * unittests/parse-connection-spec-selftests.c: Fix common/
957         includes.
958         * unittests/optional-selftests.c: Fix common/ includes.
959         * unittests/offset-type-selftests.c: Fix common/ includes.
960         * unittests/observable-selftests.c: Fix common/ includes.
961         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
962         * unittests/memrange-selftests.c: Fix common/ includes.
963         * unittests/memory-map-selftests.c: Fix common/ includes.
964         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
965         * unittests/function-view-selftests.c: Fix common/ includes.
966         * unittests/environ-selftests.c: Fix common/ includes.
967         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
968         * unittests/common-utils-selftests.c: Fix common/ includes.
969         * unittests/cli-utils-selftests.c: Fix common/ includes.
970         * unittests/array-view-selftests.c: Fix common/ includes.
971         * ui-file.c: Fix common/ includes.
972         * tui/tui-io.c: Fix common/ includes.
973         * tracepoint.h: Fix common/ includes.
974         * tracepoint.c: Fix common/ includes.
975         * tracefile-tfile.c: Fix common/ includes.
976         * top.h: Fix common/ includes.
977         * top.c: Fix common/ includes.
978         * thread.c: Fix common/ includes.
979         * target/waitstatus.h: Fix common/ includes.
980         * target/waitstatus.c: Fix common/ includes.
981         * target.h: Fix common/ includes.
982         * target.c: Fix common/ includes.
983         * target-memory.c: Fix common/ includes.
984         * target-descriptions.c: Fix common/ includes.
985         * symtab.h: Fix common/ includes.
986         * symfile.c: Fix common/ includes.
987         * stap-probe.c: Fix common/ includes.
988         * spu-linux-nat.c: Fix common/ includes.
989         * sparc-nat.c: Fix common/ includes.
990         * source.c: Fix common/ includes.
991         * solib.c: Fix common/ includes.
992         * solib-target.c: Fix common/ includes.
993         * ser-unix.c: Fix common/ includes.
994         * ser-tcp.c: Fix common/ includes.
995         * ser-pipe.c: Fix common/ includes.
996         * ser-base.c: Fix common/ includes.
997         * selftest-arch.c: Fix common/ includes.
998         * s12z-tdep.c: Fix common/ includes.
999         * rust-exp.y: Fix common/ includes.
1000         * rs6000-aix-tdep.c: Fix common/ includes.
1001         * riscv-tdep.c: Fix common/ includes.
1002         * remote.c: Fix common/ includes.
1003         * remote-notif.h: Fix common/ includes.
1004         * remote-fileio.h: Fix common/ includes.
1005         * remote-fileio.c: Fix common/ includes.
1006         * regcache.h: Fix common/ includes.
1007         * regcache.c: Fix common/ includes.
1008         * record-btrace.c: Fix common/ includes.
1009         * python/python.c: Fix common/ includes.
1010         * python/py-type.c: Fix common/ includes.
1011         * python/py-inferior.c: Fix common/ includes.
1012         * progspace.h: Fix common/ includes.
1013         * producer.c: Fix common/ includes.
1014         * procfs.c: Fix common/ includes.
1015         * proc-api.c: Fix common/ includes.
1016         * printcmd.c: Fix common/ includes.
1017         * ppc-linux-nat.c: Fix common/ includes.
1018         * parser-defs.h: Fix common/ includes.
1019         * osdata.c: Fix common/ includes.
1020         * obsd-nat.c: Fix common/ includes.
1021         * nat/x86-linux.c: Fix common/ includes.
1022         * nat/x86-linux-dregs.c: Fix common/ includes.
1023         * nat/x86-dregs.h: Fix common/ includes.
1024         * nat/x86-dregs.c: Fix common/ includes.
1025         * nat/ppc-linux.c: Fix common/ includes.
1026         * nat/mips-linux-watch.h: Fix common/ includes.
1027         * nat/mips-linux-watch.c: Fix common/ includes.
1028         * nat/linux-waitpid.c: Fix common/ includes.
1029         * nat/linux-ptrace.h: Fix common/ includes.
1030         * nat/linux-ptrace.c: Fix common/ includes.
1031         * nat/linux-procfs.c: Fix common/ includes.
1032         * nat/linux-personality.c: Fix common/ includes.
1033         * nat/linux-osdata.c: Fix common/ includes.
1034         * nat/linux-namespaces.c: Fix common/ includes.
1035         * nat/linux-btrace.h: Fix common/ includes.
1036         * nat/linux-btrace.c: Fix common/ includes.
1037         * nat/fork-inferior.c: Fix common/ includes.
1038         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1039         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1040         * nat/aarch64-linux.c: Fix common/ includes.
1041         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1042         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1043         * namespace.h: Fix common/ includes.
1044         * mips-linux-tdep.c: Fix common/ includes.
1045         * minsyms.c: Fix common/ includes.
1046         * mi/mi-parse.h: Fix common/ includes.
1047         * mi/mi-main.c: Fix common/ includes.
1048         * mi/mi-cmd-env.c: Fix common/ includes.
1049         * memrange.h: Fix common/ includes.
1050         * memattr.c: Fix common/ includes.
1051         * maint.h: Fix common/ includes.
1052         * maint.c: Fix common/ includes.
1053         * main.c: Fix common/ includes.
1054         * machoread.c: Fix common/ includes.
1055         * location.c: Fix common/ includes.
1056         * linux-thread-db.c: Fix common/ includes.
1057         * linux-nat.c: Fix common/ includes.
1058         * linux-fork.c: Fix common/ includes.
1059         * inline-frame.c: Fix common/ includes.
1060         * infrun.c: Fix common/ includes.
1061         * inflow.c: Fix common/ includes.
1062         * inferior.h: Fix common/ includes.
1063         * inferior.c: Fix common/ includes.
1064         * infcmd.c: Fix common/ includes.
1065         * inf-ptrace.c: Fix common/ includes.
1066         * inf-child.c: Fix common/ includes.
1067         * ia64-linux-nat.c: Fix common/ includes.
1068         * i387-tdep.c: Fix common/ includes.
1069         * i386-tdep.c: Fix common/ includes.
1070         * i386-linux-tdep.c: Fix common/ includes.
1071         * i386-linux-nat.c: Fix common/ includes.
1072         * i386-go32-tdep.c: Fix common/ includes.
1073         * i386-fbsd-tdep.c: Fix common/ includes.
1074         * i386-fbsd-nat.c: Fix common/ includes.
1075         * guile/scm-type.c: Fix common/ includes.
1076         * guile/guile.c: Fix common/ includes.
1077         * go32-nat.c: Fix common/ includes.
1078         * gnu-nat.c: Fix common/ includes.
1079         * gdbthread.h: Fix common/ includes.
1080         * gdbarch-selftests.c: Fix common/ includes.
1081         * gdb_usleep.c: Fix common/ includes.
1082         * gdb_select.h: Fix common/ includes.
1083         * gdb_bfd.c: Fix common/ includes.
1084         * gcore.c: Fix common/ includes.
1085         * fork-child.c: Fix common/ includes.
1086         * findvar.c: Fix common/ includes.
1087         * fbsd-nat.c: Fix common/ includes.
1088         * event-top.c: Fix common/ includes.
1089         * event-loop.c: Fix common/ includes.
1090         * dwarf2read.c: Fix common/ includes.
1091         * dwarf2loc.c: Fix common/ includes.
1092         * dwarf2-frame.c: Fix common/ includes.
1093         * dwarf-index-cache.c: Fix common/ includes.
1094         * dtrace-probe.c: Fix common/ includes.
1095         * disasm-selftests.c: Fix common/ includes.
1096         * defs.h: Fix common/ includes.
1097         * csky-tdep.c: Fix common/ includes.
1098         * cp-valprint.c: Fix common/ includes.
1099         * cp-support.h: Fix common/ includes.
1100         * cp-support.c: Fix common/ includes.
1101         * corelow.c: Fix common/ includes.
1102         * completer.h: Fix common/ includes.
1103         * completer.c: Fix common/ includes.
1104         * compile/compile.c: Fix common/ includes.
1105         * compile/compile-loc2c.c: Fix common/ includes.
1106         * compile/compile-cplus-types.c: Fix common/ includes.
1107         * compile/compile-cplus-symbols.c: Fix common/ includes.
1108         * command.h: Fix common/ includes.
1109         * cli/cli-dump.c: Fix common/ includes.
1110         * cli/cli-cmds.c: Fix common/ includes.
1111         * charset.c: Fix common/ includes.
1112         * build-id.c: Fix common/ includes.
1113         * btrace.h: Fix common/ includes.
1114         * btrace.c: Fix common/ includes.
1115         * breakpoint.h: Fix common/ includes.
1116         * breakpoint.c: Fix common/ includes.
1117         * ax.h: 
1118         (enum agent_op): Fix common/ includes.
1119         * ax-general.c (struct aop_map): Fix common/ includes.
1120         * ax-gdb.c: Fix common/ includes.
1121         * auxv.c: Fix common/ includes.
1122         * auto-load.c: Fix common/ includes.
1123         * arm-tdep.c: Fix common/ includes.
1124         * arch/riscv.c: Fix common/ includes.
1125         * arch/ppc-linux-common.c: Fix common/ includes.
1126         * arch/i386.c: Fix common/ includes.
1127         * arch/arm.c: Fix common/ includes.
1128         * arch/arm-linux.c: Fix common/ includes.
1129         * arch/arm-get-next-pcs.c: Fix common/ includes.
1130         * arch/amd64.c: Fix common/ includes.
1131         * arch/aarch64.c: Fix common/ includes.
1132         * arch/aarch64-insn.c: Fix common/ includes.
1133         * arch-utils.c: Fix common/ includes.
1134         * amd64-windows-tdep.c: Fix common/ includes.
1135         * amd64-tdep.c: Fix common/ includes.
1136         * amd64-sol2-tdep.c: Fix common/ includes.
1137         * amd64-obsd-tdep.c: Fix common/ includes.
1138         * amd64-nbsd-tdep.c: Fix common/ includes.
1139         * amd64-linux-tdep.c: Fix common/ includes.
1140         * amd64-linux-nat.c: Fix common/ includes.
1141         * amd64-fbsd-tdep.c: Fix common/ includes.
1142         * amd64-fbsd-nat.c: Fix common/ includes.
1143         * amd64-dicos-tdep.c: Fix common/ includes.
1144         * amd64-darwin-tdep.c: Fix common/ includes.
1145         * agent.c: Fix common/ includes.
1146         * ada-lang.h: Fix common/ includes.
1147         * ada-lang.c: Fix common/ includes.
1148         * aarch64-tdep.c: Fix common/ includes.
1149
1150 2019-01-25  Tom Tromey  <tom@tromey.com>
1151
1152         * common/create-version.sh: Use common/version.h.
1153
1154 2019-01-24  Pedro Alves  <palves@redhat.com>
1155
1156         * infrun.c (signal_stop, signal_print, signal_program)
1157         (signal_catch, signal_pass): Now arrays instead of pointers.
1158         (update_signals_program_target, do_target_resume)
1159         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1160         * linux-nat.c (linux_nat_target::pass_signals)
1161         (linux_nat_target::create_inferior, linux_nat_target::attach):
1162         Adjust.
1163         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1164         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1165         * procfs.c (procfs_target::pass_signals): Adjust.
1166         * record-full.c (record_full_target::resume): Adjust.
1167         * remote.c (remote_target::pass_signals)
1168         (remote_target::program_signals): Adjust.
1169         * target-debug.h (target_debug_print_signals): Now takes a
1170         gdb::array_view as parameter.  Adjust.
1171         * target.h (target_ops) <pass_signals, program_signals>: Replace
1172         pointer and length parameters with gdb::array_view.
1173         (target_pass_signals, target_program_signals): Likewise.
1174         * target-delegates.c: Regenerate.
1175
1176 2019-01-24  Pedro Alves  <palves@redhat.com>
1177
1178         * common/forward-scope-exit.h
1179         (forward_scope_exit::forward_scope_exit): Pass arguments to
1180         m_bind_function directly, instead of creating a std::bind and
1181         copying that.
1182
1183 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1184
1185         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1186         for static members.
1187         (pass_in_v_vfp_candidate): Likewise.
1188
1189 2019-01-23  Tom Tromey  <tom@tromey.com>
1190             Pedro Alves  <palves@redhat.com>
1191
1192         * regcache.c (class regcache_invalidator): Remove.
1193         (regcache::raw_write): Use make_scope_exit.
1194
1195 2019-01-23  Tom Tromey  <tom@tromey.com>
1196
1197         * ui-out.h (class ui_out_emit_type): Update comment.
1198
1199 2019-01-23  Tom Tromey  <tom@tromey.com>
1200
1201         * infrun.c (fetch_inferior_event): Update comment.
1202
1203 2019-01-23  Tom Tromey  <tom@tromey.com>
1204             Pedro Alves  <palves@redhat.com>
1205
1206         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1207         parameter.
1208         (fetch_inferior_event): Use SCOPE_EXIT.
1209
1210
1211 2019-01-23  Tom Tromey  <tom@tromey.com>
1212             Pedro Alves  <palves@redhat.com>
1213
1214         * infrun.c (disable_thread_events): Delete.
1215         (stop_all_threads): Use SCOPE_EXIT.
1216
1217 2019-01-23  Tom Tromey  <tom@tromey.com>
1218             Pedro Alves  <palves@redhat.com>
1219
1220         * symfile.c: Include forward-scope-exit.h.
1221         (clear_symtab_users_cleanup): Replace forward declaration with
1222         a FORWARD_SCOPE_EXIT.
1223         (syms_from_objfile_1): Use the forward_scope_exit and
1224         gdb::optional instead of cleanup_function.
1225         (reread_symbols): Use the forward_scope_exit instead of
1226         cleanup_function.
1227         (clear_symtab_users_cleanup): Remove function.
1228
1229 2019-01-23  Tom Tromey  <tom@tromey.com>
1230             Pedro Alves  <palves@redhat.com>
1231
1232         * linux-nat.c: Include scope-exit.h.
1233         (cleanup_target_stop): Remove.
1234         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1235         SCOPE_EXIT.
1236
1237 2019-01-23  Tom Tromey  <tom@tromey.com>
1238             Pedro Alves  <palves@redhat.com>
1239
1240         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1241         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1242
1243 2019-01-23  Tom Tromey  <tom@tromey.com>
1244             Andrew Burgess  <andrew.burgess@embecosm.com>
1245             Pedro Alves  <palves@redhat.com>
1246
1247         * infrun.c (fetch_inferior_event): Use scope_exit.
1248         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1249         * top.c (execute_command): Use scope_exit.
1250         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1251         * utils.c (do_bpstat_clear_actions_cleanup)
1252         (make_bpstat_clear_actions_cleanup): Remove.
1253
1254 2019-01-23  Tom Tromey  <tom@tromey.com>
1255             Pedro Alves  <palves@redhat.com>
1256
1257         * infrun.c: Include "common/scope-exit.h"
1258         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1259         (wait_for_inferior): Use SCOPE_EXIT.
1260         (fetch_inferior_event): Use scope_exit.
1261
1262 2019-01-23  Tom Tromey  <tom@tromey.com>
1263             Pedro Alves  <palves@redhat.com>
1264
1265         * breakpoint.c (create_breakpoint): Remove cleanup.
1266
1267 2019-01-23  Tom Tromey  <tom@tromey.com>
1268             Andrew Burgess  <andrew.burgess@embecosm.com>
1269             Pedro Alves  <palves@redhat.com>
1270
1271 2019-01-23  Pedro Alves  <palves@redhat.com>
1272
1273         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1274
1275 2019-01-23  Pedro Alves  <palves@redhat.com>
1276             Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         * gdbthread.h: Include "common/forward-scope-exit.h".
1279         (scoped_finish_thread_state): Redefine custom class in terms of
1280         forward_scope_exit.
1281
1282 2019-01-23  Pedro Alves  <palves@redhat.com>
1283             Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * common/forward-scope-exit.h: New file.
1286
1287 2019-01-23  Pedro Alves  <palves@redhat.com>
1288             Andrew Burgess  <andrew.burgess@embecosm.com>
1289             Tom Tromey  <tom@tromey.com>
1290
1291         * common/scope-exit.h: New file.
1292
1293 2019-01-23  Pedro Alves  <palves@redhat.com>
1294
1295         * common/preprocessor.h (ESC): Rename to ...
1296         (ESC_PARENS): ... this.
1297         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1298         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1299
1300 2019-01-23  Tom Tromey  <tom@tromey.com>
1301
1302         * language.h (class scoped_switch_to_sym_language_if_auto):
1303         Initialize m_lang in both cases.
1304
1305 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1308         with XCNEW.
1309
1310 2019-01-22  Tom Tromey  <tom@tromey.com>
1311
1312         * corelow.c: Do not include sys/file.h.
1313
1314 2019-01-22  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-wingeneral.h: Include gdb_curses.h.
1317
1318 2019-01-22  Tom Tromey  <tom@tromey.com>
1319
1320         * source-cache.h (class source_cache) <get_source_lines,
1321         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1322
1323 2019-01-22  Tom Tromey  <tom@tromey.com>
1324
1325         * remote-fileio.h (struct remote_target): Declare.
1326
1327 2019-01-22  Tom Tromey  <tom@tromey.com>
1328
1329         * python/py-arch.c: Do not include py-ref.h.
1330         * python/py-bpevent.c: Do not include py-ref.h.
1331         * python/py-cmd.c: Do not include py-ref.h.
1332         * python/py-continueevent.c: Do not include py-ref.h.
1333         * python/py-event.h: Do not include py-ref.h.
1334         * python/py-evtregistry.c: Do not include py-ref.h.
1335         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1336         * python/py-frame.c: Do not include py-ref.h.
1337         * python/py-framefilter.c: Do not include py-ref.h.
1338         * python/py-function.c: Do not include py-ref.h.
1339         * python/py-infevents.c: Do not include py-ref.h.
1340         * python/py-linetable.c: Do not include py-ref.h.
1341         * python/py-objfile.c: Do not include py-ref.h.
1342         * python/py-param.c: Do not include py-ref.h.
1343         * python/py-prettyprint.c: Do not include py-ref.h.
1344         * python/py-progspace.c: Do not include py-ref.h.
1345         * python/py-symbol.c: Do not include py-ref.h.
1346         * python/py-symtab.c: Do not include py-ref.h.
1347         * python/py-type.c: Do not include py-ref.h.
1348         * python/py-unwind.c: Do not include py-ref.h.
1349         * python/py-utils.c: Do not include py-ref.h.
1350         * python/py-value.c: Do not include py-ref.h.
1351         * python/py-varobj.c: Do not include py-ref.h.
1352         * python/py-xmethods.c: Do not include py-ref.h.
1353         * python/python.c: Do not include py-ref.h.
1354         * varobj.c: Do not include py-ref.h.
1355
1356 2019-01-22  Tom Tromey  <tom@tromey.com>
1357
1358         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1359         keyword for bcache.
1360
1361 2019-01-22  Tom Tromey  <tom@tromey.com>
1362
1363         * compile/compile-cplus-types.c: Remove a comment by #include.
1364
1365 2019-01-22  Tom Tromey  <tom@tromey.com>
1366
1367         * compile/gcc-c-plugin.h: Include compile-internal.h.
1368
1369 2019-01-22  Tom Tromey  <tom@tromey.com>
1370
1371         * stabsread.c (EXTERN): Do not define.
1372         (symnum, next_symbol_text_func, processing_gcc_compilation)
1373         (within_function, global_sym_chain, global_stabs)
1374         (previous_stab_code, this_object_header_files)
1375         (n_this_object_header_files)
1376         (n_allocated_this_object_header_files): Define.
1377         * stabsread.h (EXTERN): Never define.  Use "extern".
1378
1379 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1380
1381         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1382         history_value.
1383
1384 2019-01-21  Tom Tromey  <tom@tromey.com>
1385
1386         * ui-out.c: Fix includes.
1387         * tui/tui-source.c: Fix includes.
1388         * target.c: Fix includes.
1389         * remote.c: Fix includes.
1390         * regcache.c: Fix includes.
1391         * python/py-block.c: Fix includes.
1392         * printcmd.c: Fix includes.
1393         * or1k-tdep.c: Fix includes.
1394         * mi/mi-main.c: Fix includes.
1395         * m32r-tdep.c: Fix includes.
1396         * csky-tdep.c: Fix includes.
1397         * compile/compile-cplus-types.c: Fix includes.
1398         * cli/cli-interp.c: Fix includes.
1399
1400 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1401
1402         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1403         for padding.
1404
1405 2019-01-16  Tom Tromey  <tom@tromey.com>
1406
1407         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1408         earlier.
1409         (struct objfile) <msymbols_range>: Move from top level.
1410         <msymbols>: New method.
1411         (class objfile_msymbols): Remove.
1412         * symtab.c (default_collect_symbol_completion_matches_break_on):
1413         Update.
1414         * symmisc.c (dump_msymbols): Update.
1415         * stabsread.c (scan_file_globals): Update.
1416         * objc-lang.c (info_selectors_command, info_classes_command)
1417         (find_methods): Update.
1418         * minsyms.c (find_solib_trampoline_target): Update.
1419         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1420         * coffread.c (coff_symfile_read): Update.
1421         * ada-lang.c (ada_lookup_simple_minsym)
1422         (ada_collect_symbol_completion_matches): Update.
1423
1424 2019-01-16  Tom Tromey  <tom@tromey.com>
1425
1426         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1427         type.  Remove no-argument constructor.
1428         <iterator::operator++>: Simplify.
1429         <begin>: Update.
1430         <end>: Use minimal_symbol_count.
1431
1432 2019-01-16  Tom Tromey  <tom@tromey.com>
1433
1434         * objfiles.h (struct objfile) <psymtabs>: New method.
1435         (class objfile_psymtabs): Remove.
1436         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1437         typedef.
1438         <range>: New method.
1439         (require_partial_symbols): Change return type.
1440         * psymtab.c (require_partial_symbols)
1441         (psym_expand_symtabs_matching): Update.
1442         * mdebugread.c (parse_partial_symbols): Update.
1443         * dbxread.c (dbx_end_psymtab): Update.
1444
1445 2019-01-15  Tom Tromey  <tom@tromey.com>
1446
1447         * symtab.c (lookup_objfile_from_block)
1448         (lookup_symbol_in_objfile_symtabs)
1449         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1450         (find_line_symtab, info_sources_command)
1451         (default_collect_symbol_completion_matches_break_on)
1452         (make_source_files_completion_list): Update.
1453         * symmisc.c (print_objfile_statistics, dump_objfile)
1454         (maintenance_print_symbols, maintenance_info_symtabs)
1455         (maintenance_check_symtabs, maintenance_info_line_tables):
1456         Update.
1457         * source.c (select_source_symtab)
1458         (forget_cached_source_info_for_objfile): Update.
1459         * objfiles.h (class objfile_compunits): Remove.
1460         (struct objfile) <compunits_range>: New typedef.
1461         (compunits): New method.
1462         * objfiles.c (objfile_relocate1): Update.
1463         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1464         * maint.c (count_symtabs_and_blocks): Update.
1465         * linespec.c (iterate_over_all_matching_symtabs): Update.
1466         * cp-support.c (add_symbol_overload_list_qualified): Update.
1467         * coffread.c (coff_symtab_read): Update.
1468         * ada-lang.c (add_nonlocal_symbols)
1469         (ada_collect_symbol_completion_matches)
1470         (ada_add_global_exceptions): Update.
1471
1472 2019-01-15  Tom Tromey  <tom@tromey.com>
1473
1474         * progspace.h (program_space) <objfiles_safe_range>: New
1475         typedef.
1476         <objfiles_safe>: New method.
1477         * objfiles.h (class all_objfiles_safe): Remove.
1478         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1479         * jit.c (jit_inferior_exit_hook): Update.
1480
1481 2019-01-17  Tom Tromey  <tom@tromey.com>
1482
1483         * progspace.h (program_space) <objfiles_range>: New typedef.
1484         <objfiles>: New method.
1485         <objfiles_head>: Rename from objfiles.
1486         (object_files): Update.
1487         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1488         * guile/scm-pretty-print.c
1489         (ppscm_find_pretty_printer_from_objfiles): Update.
1490         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1491         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1492         Update.
1493         * python/py-progspace.c (pspy_get_objfiles): Update.
1494         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1495         Update.
1496         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1497         (objfpy_lookup_objfile_by_build_id): Update.
1498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1499         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1500         Update.
1501         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1502         (expand_symtab_containing_pc, lookup_objfile_from_block)
1503         (lookup_static_symbol, basic_lookup_transparent_type)
1504         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1505         (find_line_symtab, info_sources_command)
1506         (default_collect_symbol_completion_matches_break_on)
1507         (make_source_files_completion_list, find_main_name): Update.
1508         * symmisc.c (print_symbol_bcache_statistics)
1509         (print_objfile_statistics, maintenance_print_symbols)
1510         (maintenance_print_msymbols, maintenance_print_objfiles)
1511         (maintenance_info_symtabs, maintenance_check_symtabs)
1512         (maintenance_expand_symtabs, maintenance_info_line_tables):
1513         Update.
1514         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1515         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1516         (map_overlay_command, unmap_overlay_command)
1517         (simple_overlay_update, expand_symtabs_matching)
1518         (map_symbol_filenames): Update.
1519         * symfile-debug.c (set_debug_symfile): Update.
1520         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1521         Update.
1522         * source.c (select_source_symtab, forget_cached_source_info):
1523         Update.
1524         * solib.c (solib_read_symbols): Update.
1525         * solib-spu.c (append_ocl_sos): Update.
1526         * psymtab.c (maintenance_print_psymbols)
1527         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1528         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1529         * printcmd.c (info_symbol_command): Update.
1530         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1531         Update.
1532         * objfiles.h (class all_objfiles): Remove.
1533         * objfiles.c (have_partial_symbols, have_full_symbols)
1534         (have_minimal_symbols, qsort_cmp, update_section_map)
1535         (shared_objfile_contains_address_p)
1536         (default_iterate_over_objfiles_in_search_order): Update.
1537         * objc-lang.c (info_selectors_command, info_classes_command)
1538         (find_methods): Update.
1539         * minsyms.c (find_solib_trampoline_target): Update.
1540         * maint.c (maintenance_info_sections)
1541         (maintenance_translate_address, count_symtabs_and_blocks):
1542         Update.
1543         * main.c (captured_main_1): Update.
1544         * linux-thread-db.c (try_thread_db_load_from_pdir)
1545         (has_libpthread): Update.
1546         * linespec.c (iterate_over_all_matching_symtabs)
1547         (search_minsyms_for_name): Update.
1548         * jit.c (jit_find_objf_with_entry_addr): Update.
1549         * hppa-tdep.c (find_unwind_entry)
1550         (hppa_lookup_stub_minimal_symbol): Update.
1551         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1552         Update.
1553         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1554         (elf_gnu_ifunc_resolve_by_got): Update.
1555         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1556         * dwarf-index-write.c (save_gdb_index_command): Update.
1557         * cp-support.c (add_symbol_overload_list_qualified): Update.
1558         * breakpoint.c (create_overlay_event_breakpoint)
1559         (create_longjmp_master_breakpoint)
1560         (create_std_terminate_master_breakpoint)
1561         (create_exception_master_breakpoint): Update.
1562         * blockframe.c (find_pc_partial_function): Update.
1563         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1564         (ada_collect_symbol_completion_matches)
1565         (ada_add_global_exceptions): Update.
1566
1567 2019-01-17  Tom Tromey  <tom@tromey.com>
1568
1569         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1570         declare VEC.
1571         (solib_target_parse_libraries): Change return type.
1572         (library_list_start_segment, library_list_start_section)
1573         (library_list_end_library, library_list_start_library); Update.
1574         (solib_target_free_library_list): Remove.
1575         (solib_target_parse_libraries): Remove cleanup.  Change return
1576         type.
1577         (solib_target_current_sos): Update.
1578
1579 2019-01-17  Tom Tromey  <tromey@bapiya>
1580
1581         * valprint.c: Replace "the the" with "the".
1582         * symtab.c: Replace "the the" with "the".
1583         * solib.c: Replace "the the" with "the".
1584         * solib-dsbt.c: Replace "the the" with "the".
1585         * linespec.c: Replace "the the" with "the".
1586         * dwarf2loc.h: Replace "the the" with "the".
1587         * amd64-windows-tdep.c: Replace "the the" with "the".
1588         * aarch64-tdep.c: Replace "the the" with "the".
1589
1590 2019-01-16  Keith Seitz  <keiths@redhat.com>
1591
1592         PR gdb/23773
1593         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1594         <builder>: Rename to ..
1595         <m_builder>: ... this and make private.
1596         (dwarf2_cu::get_builder): New method.  Change all users of
1597         `builder' to use this method.
1598         (dwarf2_start_symtab): Move to ...
1599         (dwarf2_cu::start_symtab): ... here.  Update all callers
1600         (setup_type_unit_groups): Move to ...
1601         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1602         callers.
1603         (dwarf2_cu::reset_builder): New method.
1604         (process_full_compunit, process_full_type_unit): Use
1605         dwarf2_cu::reset_builder.
1606         (follow_die_offset): Record the ancestor CU if it is different
1607         from the followed DIE's CU.
1608         (follow_die_sig_1): Likewise.
1609
1610 2019-01-15  Tom Tromey  <tom@tromey.com>
1611
1612         * remote.c (class remote_state) <buf>: Now a char_vector.
1613         <buf_size>: Remove.
1614         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1615         parameter.
1616         (remote_target::getpkt_or_notif_sane_1)
1617         (remote_target::getpkt_sane)
1618         (remote_target::getpkt_or_notif_sane): Likewise.
1619         (class remote_target) <putpkt>: New overload.
1620         (remote_target::read_frame): Change type of "buf_p".  Remove
1621         sizeof_p parameter.
1622         (packet_ok): New overload.
1623         (packet_check_result): New overload.
1624         Update all uses.
1625
1626 2019-01-14  Tom Tromey  <tom@tromey.com>
1627
1628         * remote-notif.c (handle_notification, remote_notif_ack)
1629         (remote_notif_parse): Make "buf" const.
1630         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1631         const.
1632         (remote_notif_parse, remote_notif_ack, handle_notification):
1633         Likewise.
1634         * remote.c (remote_notif_stop_parse): Make "buf" const.
1635         (remote_target::remote_parse_stop_reply): Make "buf" const.
1636         (remote_notif_stop_ack): Make "buf" const.
1637
1638 2019-01-14  Tom Tromey  <tom@tromey.com>
1639
1640         * remote.c (remote_console_output): Make parameter const.
1641
1642 2019-01-14  Tom Tromey  <tom@tromey.com>
1643
1644         * target-debug.h (target_debug_print_signals): Constify.
1645         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1646         * procfs.c (procfs_target::pass_signals): Update.
1647         * linux-nat.c (linux_nat_target::pass_signals): Update.
1648         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1649         * target-delegates.c: Rebuild.
1650         * remote.c (remote_target::program_signals): Update.
1651         (remote_target::pass_signals): Update.
1652         * target.c (target_pass_signals): Constify argument.
1653         (target_program_signals): Likewise.
1654         * target.h (struct target_ops) <pass_signals, program_signals>:
1655         Constify argument.
1656         (target_pass_signals, target_program_signals): Constify argument.
1657
1658 2019-01-14  Tom Tromey  <tom@tromey.com>
1659
1660         PR tui/28819:
1661         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1662
1663 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1664
1665         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1666         field.
1667         * rs6000-tdep.c: Include reggroups.h.
1668         (IS_V_ALIAS_PSEUDOREG): Define.
1669         (rs6000_register_name): Return names for the "vX" aliases.
1670         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1671         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1672         aliases.  Call default_register_reggroup_p for all other
1673         pseudo-registers.
1674         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1675         New functions.
1676         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1677         Handle "vX" aliases.
1678         (v_alias_pseudo_register_collect): New function.
1679         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1680         (rs6000_gdbarch_init): Initialize "vX" aliases as
1681         pseudo-registers.  Restore registration of
1682         rs6000_pseudo_register_reggroup_p with
1683         set_tdesc_pseudo_register_reggroup_p.
1684
1685 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1686
1687         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1688         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1689         set_gdbarch_num_pseudo_regs.
1690
1691 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1692
1693         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1694         Remove arg prefixname, add do_set and do_show.
1695         Add member functions set_list and show_list.
1696         * cli/cli-style.c (class cli_style_option): Update accordingly.
1697         (style_set_list): Move to file scope.
1698         (style_show_list): Likewise.
1699         (set_style): Call help_list.
1700         (show_style): Call cmd_show_list.
1701         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1702         Update to use the new macro.
1703
1704 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1705
1706         * ada-lang.c (_initialize_ada_language): Expand the help text
1707         for the "catch exception" command.
1708
1709 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1710
1711         * symtab.c (matching_obj_sections): Initialize obj,
1712         declare it closer to its usage.
1713
1714 2019-01-10  Tom Tromey  <tom@tromey.com>
1715
1716         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1717         (basic_inf_threads_range): Remove.
1718         (inf_threads_range, inf_non_exited_threads_range)
1719         (safe_inf_threads_range): Use next_adapter.
1720
1721 2019-01-10  Keith Seitz  <keiths@redhat.com>
1722
1723         PR gdb/23712
1724         PR symtab/23010
1725         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1726         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1727
1728 2019-01-10  Keith Seitz  <keiths@redhat.com>
1729
1730         PR gdb/23712
1731         PR symtab/23010
1732         * dictionary.c (pending_to_vector): Remove.
1733         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1734         Remove _1 suffix, replacing functions of the same name.  Update
1735         all callers.
1736         (dict_create_hashed, dict_create_hashed_expandable)
1737         (dict_create_linear, dict_create_linear_expandable, dict_free)
1738         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1739         Make functions static.
1740
1741 2019-01-10  Keith Seitz  <keiths@redhat.com>
1742
1743         PR gdb/23712
1744         PR symtab/23010
1745         * dictionary.h (struct dictionary): Replace declaration with
1746         multidictionary.
1747         (dict_create_hashed, dict_create_hashed_expandable)
1748         (dict_create_linear, dict_create_linear_expandable)
1749         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1750         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1751         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1752         taking multidictionary argument.
1753         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1754         * block.h (struct block) <dict>: Change to multidictionary
1755         and rename `multidict'.
1756         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1757         symmisc.c: Update all dictionary references to multidictionary.
1758
1759 2019-01-10  Keith Seitz  <keiths@redhat.com>
1760
1761         PR gdb/23712
1762         PR symtab/23010
1763         * dictionary.c: Include unordered_map.
1764         (pending_to_vector): New function.
1765         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1766         Rewrite the non-"_1" functions to take vector instead
1767         of linked list.
1768         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1769         "new" _1 versions of the same name.
1770         (multidictionary): Define.
1771         (std::hash<enum language): New definition.
1772         (collate_pending_symbols_by_language, mdict_create_hashed)
1773         (mdict_create_hashed_expandable, mdict_create_linear)
1774         (mdict_create_linear_expandable, mdict_free)
1775         (find_language_dictionary, create_new_language_dictionary)
1776         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1777         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1778         (mdict_size, mdict_empty): New functions.
1779         * dictionary.h (mdict_iterator): Define.
1780
1781 2019-01-10  Pedro Alves  <palves@redhat.com>
1782
1783         * breakpoint.c (read_uploaded_action)
1784         (create_tracepoint_from_upload): Adjust to use
1785         gdb::unique_xmalloc_ptr.
1786         * ctf.c (ctf_write_uploaded_tp):
1787         (SET_ARRAY_FIELD): Use emplace_back.
1788         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1789         * tracefile-tfile.c (tfile_write_uploaded_tp):
1790         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1791         gdb::unique_xmalloc_ptr.
1792         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1793         at_string, cond_string, cmd_strings>: Replace char pointers
1794         with gdb::unique_xmalloc_ptr.
1795
1796 2019-01-10  Pedro Alves  <palves@redhat.com>
1797
1798         * solib-target.c (library_list_start_library): Don't xstrdup name.
1799
1800 2019-01-10  Pedro Alves  <palves@redhat.com>
1801
1802         * mdebugread.c (parse_partial_symbols): Use
1803         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1804
1805 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1806
1807         * linux-fork.c (scoped_switch_fork_info)
1808         <~scoped_switch_fork_info>: Fix incorrect variable name.
1809
1810 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * linux-fork.c (scoped_switch_fork_info)
1813         <scoped_switch_fork_info>: Make explicit.
1814         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1815
1816 2019-01-10  Tom Tromey  <tom@tromey.com>
1817
1818         * objfiles.h (objfile::reset_psymtabs): Update.
1819         * objfiles.c (objfile::objfile): Update.
1820         * psymtab.h (psymtab_storage::obstack): Update.
1821         (psymtab_storage::m_obstack): Use gdb::optional.
1822         (class psymtab_storage): Update comment.  Remove objfile
1823         parameter.
1824         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1825
1826 2019-01-10  Tom Tromey  <tom@tromey.com>
1827
1828         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1829         <free_psymtabs>: Now private.
1830         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1831         (allocate_psymtab): Use new method.
1832
1833 2019-01-10  Tom Tromey  <tom@tromey.com>
1834
1835         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1836         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1837         * mdebugread.c (parse_partial_symbols): Use
1838         allocate_dependencies.
1839         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1840         allocate_dependencies.
1841         (process_psymtab_comp_unit_reader)
1842         (build_type_psymtab_dependencies): Likewise.
1843         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1844
1845 2019-01-10  Tom Tromey  <tom@tromey.com>
1846
1847         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1848         PSYMBOL_SET_LANGUAGE.
1849         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1850
1851 2019-01-10  Tom Tromey  <tom@tromey.com>
1852
1853         * psymtab.h (psymtab_storage::obstack): New method.
1854         <m_obstack>: Rename from obstack; now private.
1855         * psymtab.c (psymtab_storage): Update.
1856         * dwarf2read.c (create_addrmap_from_index)
1857         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1858         Update.
1859
1860 2019-01-10  Tom Tromey  <tom@tromey.com>
1861
1862         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1863         * objfiles.h (objfile::reset_psymtabs): New method.
1864
1865 2019-01-10  Tom Tromey  <tom@tromey.com>
1866
1867         * symmisc.c (print_symbol_bcache_statistics): Update.
1868         (print_objfile_statistics): Update.
1869         * symfile.c (reread_symbols): Update.
1870         * psymtab.h (class psymtab_storage): New.
1871         * psymtab.c (psymtab_storage): New constructor.
1872         (~psymtab_storage): New destructor.
1873         (require_partial_symbols): Update.
1874         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1875         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1876         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1877         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1878         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1879         (start_psymtab_common, end_psymtab_common)
1880         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1881         (allocate_psymtab): Update.
1882         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1883         Update.
1884         (dump_psymtab_addrmap, maintenance_print_psymbols)
1885         (maintenance_check_psymtabs): Update.
1886         (class objfile_psymtabs): Move to objfiles.h.
1887         * psympriv.h (discard_psymtab): Now inline.
1888         (psymtab_discarder::psymtab_discarder): Update.
1889         (psymtab_discarder::~psymtab_discarder): Update.
1890         (ALL_OBJFILE_PSYMTABS): Rewrite.
1891         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1892         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1893         Remove fields.
1894         <partial_symtabs>: New field.
1895         (class objfile_psymtabs): Move from psymtab.h.  Update.
1896         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1897         psymbol_cache.
1898         (objfile::~objfile): Don't destroy psymbol_cache.
1899         * mdebugread.c (parse_partial_symbols): Update.
1900         * dwarf2read.c (create_addrmap_from_index)
1901         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1902         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1903         (add_partial_subprogram, dwarf2_ranges_read): Update.
1904         * dwarf-index-write.c (write_address_map)
1905         (write_one_signatured_type, recursively_write_psymbols)
1906         (class debug_names, class debug_names, write_psymtabs_to_index):
1907         Update.
1908
1909 2019-01-10  Tom Tromey  <tom@tromey.com>
1910
1911         * symtab.h (SYMBOL_SET_NAMES): Update.
1912         (symbol_set_names): Update.
1913         (MSYMBOL_SET_NAMES): Update.
1914         * symtab.c (symbol_set_names): Change argument to be an
1915         objfile_per_bfd_storage.
1916         * psymtab.c (add_psymbol_to_bcache): Update.
1917         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1918
1919 2019-01-10  Tom Tromey  <tom@tromey.com>
1920
1921         * symtab.c (create_demangled_names_hash): Change argument to be an
1922         objfile_per_bfd_storage.
1923         (symbol_set_names): Update.
1924
1925 2019-01-10  Tom Tromey  <tom@tromey.com>
1926
1927         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1928         init_psymbol_list.
1929         * psymtab.c (init_psymbol_list): Do nothing if already called.
1930         * psympriv.h (init_psymbol_list): Add comment.
1931         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1932         init_psymbol_list.
1933         * dbxread.c (dbx_symfile_read): Unconditionally call
1934         init_psymbol_list.
1935
1936 2019-01-10  Tom Tromey  <tom@tromey.com>
1937
1938         * xcoffread.c (scan_xcoff_symtab): Update.
1939         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1940         "where".
1941         * mdebugread.c (parse_partial_symbols)
1942         (handle_psymbol_enumerators): Update.
1943         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1944         * dbxread.c (read_dbx_symtab): Update.
1945         * psympriv.h (psymbol_placement): New enum.
1946         (add_psymbol_to_list): Update.
1947
1948 2019-01-10  Tom Tromey  <tom@tromey.com>
1949
1950         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1951         static_psymbols parameters.
1952         (scan_xcoff_symtab): Update.
1953         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1954         static_psymbols parameters.
1955         * psympriv.h (start_psymtab_common): Update.
1956         * mdebugread.c (parse_partial_symbols): Update.
1957         * dwarf2read.c (create_partial_symtab): Update.
1958         * dbxread.c (read_dbx_symtab): Update.
1959         (start_psymtab): Remove global_psymbols and static_psymbols
1960         parameters.
1961
1962 2019-01-10  Tom Tromey  <tom@tromey.com>
1963
1964         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1965         * psymtab.c (allocate_psymtab): Add comment.
1966         * psympriv.h (allocate_psymtab): Add comment.
1967         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1968         initializations.
1969         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1970
1971 2019-01-10  Tom Tromey  <tom@tromey.com>
1972
1973         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1974         Don't declare.
1975         * mipsread.c: Include mdebugread.h.
1976         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1977         Declare.
1978         * elfread.c: Include mdebugread.h.
1979
1980 2019-01-09  Tom Tromey  <tom@tromey.com>
1981
1982         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1983         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1984         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1985         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1986         (psym_lookup_symbol, psym_find_last_source_symtab)
1987         (psym_forget_cached_source_info, psym_print_stats)
1988         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1989         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1990         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1991         (psym_find_compunit_symtab_by_address)
1992         (maintenance_print_psymbols, maintenance_info_psymtabs)
1993         (maintenance_check_psymtabs): Use ranged for.
1994         * psymtab.h (class objfile_psymtabs): New.
1995         (require_partial_symbols): Return objfile_psymtabs.
1996         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1997
1998 2019-01-09  Tom Tromey  <tom@tromey.com>
1999
2000         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2001         (find_pc_mapped_section, list_overlays_command)
2002         (map_overlay_command, unmap_overlay_command)
2003         (simple_overlay_update): Use all_objfiles.
2004         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2005         * printcmd.c (info_symbol_command): Use all_objfiles.
2006         * objfiles.h (ALL_OBJSECTIONS): Remove.
2007         * maint.c (maintenance_translate_address): Use all_objfiles.
2008         * gcore.c (gcore_create_callback): Use all_objfiles.
2009         (objfile_find_memory_regions): Likewise.
2010
2011 2019-01-09  Tom Tromey  <tom@tromey.com>
2012
2013         * symtab.c (find_line_symtab, info_sources_command)
2014         (make_source_files_completion_list): Use objfile_compunits.
2015         * source.c (select_source_symtab): Use objfile_compunits.
2016         * objfiles.h (struct objfile): Update comment.
2017         (ALL_OBJFILES): Remove.
2018         (ALL_FILETABS): Remove.
2019         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2020         objfile_compunits.
2021
2022 2019-01-09  Tom Tromey  <tom@tromey.com>
2023
2024         * symmisc.c (print_objfile_statistics, dump_objfile)
2025         (maintenance_print_symbols): Use compunit_filetabs.
2026         * source.c (forget_cached_source_info_for_objfile): Use
2027         compunit_filetabs.
2028         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2029         (ALL_FILETABS): Use compunit_filetabs.
2030         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2031         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2032
2033 2019-01-09  Tom Tromey  <tom@tromey.com>
2034
2035         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2036         (compunit_filetabs): New.
2037         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2038         compunit_filetabs.
2039         (info_sources_command, make_source_files_completion_list): Remove
2040         declaration.
2041         * symmisc.c (print_objfile_statistics, dump_objfile)
2042         (maintenance_print_symbols): Remove declaration.
2043         (maintenance_info_symtabs): Use compunit_filetabs.
2044         (maintenance_info_line_tables): Likewise.
2045         * source.c (select_source_symtab): Change local variable name.
2046         (forget_cached_source_info_for_objfile): Remove declaration.
2047         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2048         * objfiles.c (objfile_relocate1): Remove declaration.
2049         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2050         declaration.
2051         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2052         * coffread.c (coff_symtab_read): Remove declaration.
2053         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2054         compunit_filetabs.
2055
2056 2019-01-09  Tom Tromey  <tom@tromey.com>
2057
2058         * symtab.c (lookup_objfile_from_block)
2059         (find_pc_sect_compunit_symtab, search_symbols)
2060         (default_collect_symbol_completion_matches_break_on): Use
2061         objfile_compunits.
2062         * objfiles.h (ALL_COMPUNITS): Remove.
2063         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2064         * cp-support.c (add_symbol_overload_list_qualified): Use
2065         objfile_compunits.
2066         * ada-lang.c (ada_collect_symbol_completion_matches)
2067         (ada_add_global_exceptions): Use objfile_compunits.
2068
2069 2019-01-09  Tom Tromey  <tom@tromey.com>
2070
2071         * source.c (select_source_symtab)
2072         (forget_cached_source_info_for_objfile): Remove declaration.
2073         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2074         declaration.
2075         * maint.c (count_symtabs_and_blocks): Remove declaration.
2076         * cp-support.c (add_symbol_overload_list_qualified): Remove
2077         declaration.
2078         * coffread.c (coff_symtab_read): Remove declaration.
2079         * symtab.c (lookup_symbol_in_objfile_symtabs)
2080         (basic_lookup_transparent_type_1): Use objfile_compunits.
2081         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2082         (info_sources_command, search_symbols)
2083         (default_collect_symbol_completion_matches_break_on)
2084         (make_source_files_completion_list): Remove declaration.
2085         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2086         (ada_collect_symbol_completion_matches)
2087         (ada_add_global_exceptions): Remove declaration.
2088         * linespec.c (iterate_over_all_matching_symtabs): Use
2089         objfile_compunits.
2090         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2091         (class objfile_compunits): New.
2092         (ALL_COMPUNITS): Use objfile_compunits.
2093         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2094         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2095         objfile_compunits.
2096         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2097
2098 2019-01-09  Tom Tromey  <tom@tromey.com>
2099
2100         * symtab.c (search_symbols)
2101         (default_collect_symbol_completion_matches_break_on): Use
2102         objfile_msymbols.
2103         * ada-lang.c (ada_lookup_simple_minsym)
2104         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2105         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2106         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2107         objfile_msymbols.
2108         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2109         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2110         * objc-lang.c (find_methods): Use objfile_msymbols.
2111         (info_selectors_command, info_classes_command): Likewise.
2112         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2113         * objfiles.h (class objfile_msymbols): New.
2114         (ALL_OBJFILE_MSYMBOLS): Remove.
2115         (ALL_MSYMBOLS): Remove.
2116
2117 2019-01-09  Tom Tromey  <tom@tromey.com>
2118
2119         * common/next-iterator.h (next_adapter): Add Iterator template
2120         parameter.
2121         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2122         (class all_objfiles_safe): New.
2123         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2124         * objfiles.c (put_objfile_before): Update comment.
2125         (add_separate_debug_objfile): Likewise.
2126         (free_all_objfiles): Use all_objfiles_safe.
2127         (objfile_purge_solibs): Likewise.
2128
2129 2019-01-09  Tom Tromey  <tom@tromey.com>
2130
2131         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2132         (expand_symtab_containing_pc, lookup_static_symbol)
2133         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2134         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2135         all_objfiles.
2136         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2137         * breakpoint.c (create_overlay_event_breakpoint)
2138         (create_longjmp_master_breakpoint)
2139         (create_std_terminate_master_breakpoint)
2140         (create_exception_master_breakpoint): Use all_objfiles.
2141         * linux-thread-db.c (try_thread_db_load_from_pdir)
2142         (has_libpthread): Use all_objfiles.
2143         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2144         * linespec.c (iterate_over_all_matching_symtabs)
2145         (search_minsyms_for_name): Use all_objfiles.
2146         * maint.c (maintenance_info_sections): Use all_objfiles.
2147         * main.c (captured_main_1): Use all_objfiles.
2148         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2149         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2150         * guile/scm-pretty-print.c
2151         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2152         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2153         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2154         (maintenance_print_msymbols): Use all_objfiles.
2155         * source.c (select_source_symtab): Use all_objfiles.
2156         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2157         * symfile.c (remove_symbol_file_command)
2158         (expand_symtabs_matching, map_symbol_filenames): Use
2159         all_objfiles.
2160         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2161         all_objfiles.
2162         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2163         * objc-lang.c (find_methods): Use all_objfiles.
2164         * objfiles.c (have_partial_symbols, have_full_symbols)
2165         (have_minimal_symbols, qsort_cmp)
2166         (default_iterate_over_objfiles_in_search_order): Use
2167         all_objfiles.
2168         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2169         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2170         (maintenance_check_psymtabs): Use all_objfiles.
2171         (ALL_PSYMTABS): Remove.
2172         * compile/compile-object-run.c (do_module_cleanup): Use
2173         all_objfiles.
2174         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2175         * cp-support.c (add_symbol_overload_list_qualified): Use
2176         all_objfiles.
2177         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2178         Use all_objfiles.
2179         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2180         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2181         all_objfiles.
2182         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2183         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2184         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2185         Uses all_objfiles.
2186         * solib.c (solib_read_symbols): Use all_objfiles
2187
2188 2019-01-09  Tom Tromey  <tom@tromey.com>
2189
2190         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2191         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2192         all_objfiles.
2193         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2194         * symmisc.c (print_symbol_bcache_statistics)
2195         (print_objfile_statistics, maintenance_print_objfiles)
2196         (maintenance_info_symtabs, maintenance_check_symtabs)
2197         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2198         all_objfiles.
2199         * source.c (forget_cached_source_info): Use all_objfiles.
2200         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2201         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2202         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2203         * objfiles.c (update_section_map): Use all_objfiles.
2204         (shared_objfile_contains_address_p): Likewise.
2205         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2206         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2207
2208 2019-01-09  Tom Tromey  <tom@tromey.com>
2209
2210         * common/next-iterator.h: New file.
2211         * objfiles.h (class all_objfiles): New.
2212         (struct objfile_iterator): New.
2213
2214 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2215
2216         * NEWS: Move the description of the changed "frame", "select-frame",
2217          and "info frame" commands to the Changed commands section.
2218
2219 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2220
2221         * gdbtypes.c (check_stub_method_group): Remove handling of old
2222         mangling schemes.
2223         * linespec.c (find_methods): Likewise.
2224         * stabsread.c (read_member_functions): Likewise.
2225         * valops.c (search_struct_method): Likewise.
2226         (value_struct_elt_for_reference): Likewise.
2227         * NEWS: Mention this change.
2228
2229 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2232         print_source_lines.
2233         * source.c (print_source_lines_base): Update line number check.
2234         (print_source_lines): New function.
2235         (source_lines_range::source_lines_range): New function.
2236         * source.h (class source_lines_range): New class.
2237         (print_source_lines): New declaration.
2238
2239 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2240
2241         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2242
2243 2019-01-08  Tom Tromey  <tom@tromey.com>
2244             Simon Marchi  <simon.marchi@ericsson.com>
2245
2246         PR gdb/24060
2247         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2248         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2249         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2250         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2251         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2252         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2253
2254 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         * source.c (select_source_symtab): Move header comment to
2257         declaration in source.h.
2258         (forget_cached_source_info_for_objfile): Likewise.
2259         (forget_cached_source_info): Likewise.
2260         (identify_source_line): Likewise.
2261         * source.h (identify_source_line): Move declaration from symtab.h
2262         and add comment from source.c
2263         (print_source_lines): Likewise.
2264         (forget_cached_source_info_for_objfile): Likewise.
2265         (forget_cached_source_info): Likewise.
2266         (select_source_symtab): Likewise.
2267         (enum print_source_lines_flag): Move definition from symtab.h.
2268         * symtab.h (identify_source_line): Move declaration to source.h.
2269         (print_source_lines): Likewise.
2270         (forget_cached_source_info_for_objfile): Likewise.
2271         (forget_cached_source_info): Likewise.
2272         (select_source_symtab): Likewise.
2273         (enum print_source_lines_flag): Move definition to source.h.
2274         * tui/tui-hooks.c: Add 'source.h' include.
2275
2276 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * source.c (print_source_lines_base): Handle requests to print
2279         reverse line number sequences, and guard against empty lines
2280         string.
2281
2282 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * source.c (print_source_lines_base): Fix skip of '\r' if next
2285         character is '\n'.
2286
2287 2019-01-06  Tom Tromey  <tom@tromey.com>
2288
2289         * c-exp.y (struct c_parse_state) <macro_original_text,
2290         expansion_obstack>: New member.
2291         (macro_original_text, expansion_obstack): Remove globals.
2292         (scan_macro_expansion, scanning_macro_expansion)
2293         (finished_macro_expansion): Update.
2294         (scan_macro_cleanup): Remove.
2295         (yylex, c_parse): Update.
2296
2297 2019-01-06  Tom Tromey  <tom@tromey.com>
2298
2299         * c-exp.y (struct c_parse_state) <strings>: New member.
2300         (operator_stoken): Update.
2301
2302 2019-01-06  Tom Tromey  <tom@tromey.com>
2303
2304         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2305         (union type_stack_elt) <typelist_val>: Now a pointer to
2306         std::vector.
2307         (type_stack_cleanup): Don't declare.
2308         (push_typelist): Update.
2309         * parse.c (pop_typelist): Return a std::vector.
2310         (push_typelist): Take a std::vector.
2311         (follow_types): Update.  Do not free args.
2312         (type_stack_cleanup): Remove.
2313         * c-exp.y (struct c_parse_state): New.
2314         (cpstate): New global.
2315         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2316         (nonempty_typelist): Update.
2317         (func_mod): Create a new vector.
2318         (c_parse): Create a c_parse_state.
2319         (check_parameter_typelist): Do not delete params.
2320         (function_method): Update.  Do not delete type_list.
2321
2322 2019-01-06  Tom Tromey  <tom@tromey.com>
2323
2324         PR gdb/28155:
2325         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2326         check_typedef.
2327         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2328         (print_return_value): Likewise.
2329
2330 2019-01-05  Tom Tromey  <tom@tromey.com>
2331
2332         * contrib/cleanup_check.py: Remove.
2333         * contrib/gcc-with-excheck: Remove.
2334         * contrib/exsummary.py: Remove.
2335         * contrib/excheck.py: Remove.
2336
2337 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2338
2339         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2340         NULL. Initialize tpprev to NULL instead of assigning it
2341         to NULL on the next statement.
2342         * windows-nat.c (windows_delete_thread): Remove check for
2343         main_thread_id before printing thread exit notifications.
2344         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2345         Remove thread ID check against main_thread_id.
2346         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2347         windows_delete_thread.
2348         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2349
2350 2019-01-04  Tom Tromey  <tom@tromey.com>
2351
2352         * compile/compile.c (_initialize_compile): Use upper case for
2353         metasyntactic variables.
2354         * symmisc.c (_initialize_symmisc): Use upper case for
2355         metasyntactic variables.
2356         * psymtab.c (_initialize_psymtab): Use upper case for
2357         metasyntactic variables.
2358         * demangle.c (demangle_command): Use upper case for metasyntactic
2359         variables.
2360         (_initialize_demangler): Likewise.
2361         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2362         variables.
2363
2364 2019-01-03  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2367
2368 2019-01-03  Tom Tromey  <tom@tromey.com>
2369
2370         * python/py-symtab.c (salpy_str): Update.
2371         (struct salpy_sal_object) <symtab>: Now a PyObject.
2372         (salpy_dealloc): Update.
2373         (del_objfile_sal): Use gdbpy_ref.
2374
2375 2019-01-03  Tom Tromey  <tom@tromey.com>
2376
2377         * python/py-type.c (convert_field): Use new_reference.  Return
2378         gdbpy_ref.
2379         (make_fielditem): Return gdbpy_ref.
2380         (typy_fields): Update.
2381         (typy_getitem): Update.
2382         (field_name): Return gdbpy_ref.  Use new_reference.
2383         (typy_iterator_iternext): Update.
2384
2385 2019-01-03  Tom Tromey  <tom@tromey.com>
2386
2387         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2388
2389 2019-01-03  Tom Tromey  <tom@tromey.com>
2390
2391         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2392         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2393         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2394         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2395         (pspy_set_type_printers): Likewise.
2396         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2397         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2398         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2399         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2400         (objfpy_set_type_printers): Likewise.
2401
2402 2019-01-03  Tom Tromey  <tom@tromey.com>
2403
2404         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2405         (gdbpy_print_stack): Use gdbpy_err_fetch.
2406         * python/python-internal.h (class gdbpy_err_fetch): New class.
2407         (class gdbpy_enter) <m_error_type, m_error_value,
2408         m_error_traceback>: Remove.
2409         <m_error>: New member.
2410         (gdbpy_exception_to_string): Don't declare.
2411         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2412         * python/py-value.c (convert_value_from_python): Use
2413         gdbpy_err_fetch.
2414         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2415         gdbpy_exception_to_string.
2416         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2417         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2418         gdbpy_err_fetch.
2419
2420 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * linux-nat.c (delete_lwp_cleanup): Delete.
2423         (struct lwp_deleter): New struct.
2424         (lwp_info_up): New typedef.
2425         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2426         lwp_info_up.
2427
2428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * linux-fork.c (class scoped_switch_fork_info): New class.
2431         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2432
2433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2434
2435         * valops.c (find_overload_match): Remove use of null_cleanup, and
2436         calls to do_cleanups.
2437
2438 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2439
2440         * compile/compile-cplus-types.c
2441         (compile_cplus_instance::decl_name): Handle changes to
2442         cp_func_name.
2443         * cp-support.c (cp_func_name): Update header comment, update
2444         return type.
2445         * cp-support.h (cp_func_name): Update return type in declaration.
2446         * valops.c (find_overload_match): Move temp_func local to top
2447         level of function and change its type.  Use temp_func to hold and
2448         delete temporary string obtained from cp_func_name.
2449
2450 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2453         gdb::char_vector, remove cleanup, and update uses of `msg`.
2454
2455 2019-01-03  Jim Wilson  <jimw@sifive.com>
2456
2457         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2458
2459 2019-01-02  Tom Tromey  <tom@tromey.com>
2460
2461         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2462         (tdesc_parse_xml): Remove cleanups.
2463         * target-descriptions.h (make_cleanup_free_target_description):
2464         Don't declare.
2465         (target_desc_deleter): New struct.
2466         (target_desc_up): New typedef.
2467         * target-descriptions.c (target_desc_deleter::operator()): Rename
2468         from free_target_description.
2469         (make_cleanup_free_target_description): Remove.
2470
2471 2019-01-02  Tom Tromey  <tom@tromey.com>
2472
2473         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2474         constructor, destructor.
2475         (linespec_parser): Remove typedef.
2476         (~linespec_parser): Rename from linespec_parser_delete.
2477         (linespec_lex_to_end, linespec_complete_label)
2478         (linespec_complete): Update.
2479         (decode_line_full): Remove cleanups.
2480         (decode_line_1): Update.
2481
2482 2019-01-02  Tom Tromey  <tom@tromey.com>
2483
2484         * python/python-internal.h (inferior_to_inferior_object): Change
2485         return type.
2486         * python/py-exitedevent.c (create_exited_event_object): Update.
2487         * python/py-inferior.c (inferior_to_inferior_object): Return
2488         gdbpy_ref.
2489         (python_new_inferior, python_inferior_deleted)
2490         (thread_to_thread_object, delete_thread_object)
2491         (build_inferior_list, gdbpy_selected_inferior): Update.
2492         * python/py-infthread.c (create_thread_object): Update.  Also fail
2493         if inferior_to_inferior_object fails.
2494
2495 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2496
2497         * inferior.h (class inferior) <displaced_step_state>: New field.
2498         * infrun.h (struct displaced_step_state): Move here from
2499         infrun.c.  Initialize fields, add constructor.
2500         <inf>: Remove field.
2501         <reset>: New method.
2502         * infrun.c (struct displaced_step_inferior_state): Move to
2503         infrun.h.
2504         (displaced_step_inferior_states): Remove.
2505         (get_displaced_stepping_state): Adust.
2506         (displaced_step_in_progress_any_inferior): Adjust.
2507         (displaced_step_in_progress_thread): Adjust.
2508         (displaced_step_in_progress): Adjust.
2509         (add_displaced_stepping_state): Remove.
2510         (get_displaced_step_closure_by_addr): Adjust.
2511         (remove_displaced_stepping_state): Remove.
2512         (infrun_inferior_exit): Call displaced_step_state.reset.
2513         (use_displaced_stepping): Don't check for NULL.
2514         (displaced_step_prepare_throw): Call
2515         get_displaced_stepping_state.
2516         (displaced_step_fixup): Don't check for NULL.
2517         (prepare_for_detach): Don't check for NULL.
2518
2519 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2520
2521         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2522          in case of call that did not complete.
2523
2524 2019-01-02  Andrey Utkin  <autkin@undo.io>
2525
2526         * symfile.c (find_separate_debug_file): Fix search of debug files for
2527         remote debuggee.
2528
2529 2019-01-02  Tom Tromey  <tom@tromey.com>
2530
2531         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2532         indentation.
2533         * python/py-frame.c (frapy_older): Remove cast.
2534         (frapy_newer): Likewise.
2535         * python/py-breakpoint.c (local_setattro): Remove cast.
2536         * python/py-arch.c (archpy_name): Remove local variable.
2537         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2538
2539 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2540
2541         * unittests/basic_string_view/element_access/char/empty.cc:
2542         Fix year range in copyright header.
2543
2544 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2547         Delete.
2548         <operator==>: Update with for removed field.
2549         <hash>: Likewise.
2550         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2551         <isa_features>: ...this.
2552         <abi_features>: New field.
2553         (riscv_isa_flen): Update comment.
2554         (riscv_abi_xlen): New declaration.
2555         (riscv_abi_flen): New declaration.
2556         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2557         isa_features.
2558         (riscv_abi_xlen): New function.
2559         (riscv_isa_flen): Update to get answer from isa_features.
2560         (riscv_abi_flen): New function.
2561         (riscv_has_fp_abi): Update to get answer from abi_features.
2562         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2563         xlen and flen.
2564         (riscv_call_info) <xlen, flen>: Update comment.
2565         (riscv_call_arg_struct): Remove invalid assertions
2566         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2567         is removed.
2568         (riscv_gdbarch_init): Gather isa features and abi features
2569         separately, ensure both match on the gdbarch when reusing an old
2570         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2571         a target with 64-bit float hardware.
2572
2573 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2574
2575         * source.c (search_command_helper): Stop reverse search
2576         when line 1 has been searched.
2577
2578 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2579
2580         * record-full.c (record_full_base_target::close): Rewrite
2581         record_full_core_buf_list free logic.
2582
2583 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2584
2585         * break-catch-syscall.c (print_one_catch_syscall): xfree
2586         the last text.
2587
2588 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2589
2590         * top.c (print_gdb_version): Update Copyright year in version
2591         message.
2592
2593 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2594
2595         Update copyright year range in all GDB files.
2596
2597 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2598
2599         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2600
2601 For older changes see ChangeLog-2018.
2602 \f
2603 Local Variables:
2604 mode: change-log
2605 left-margin: 8
2606 fill-column: 74
2607 version-control: never
2608 coding: utf-8
2609 End:
2610