gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_update_source_window)
   4         (tui_refill_source_window)
   5         (tui_source_window_base::do_scroll_horizontal)
   6         (tui_update_breakpoint_info, tui_set_exec_info_content)
   7         (tui_show_exec_info_content, tui_erase_exec_info_content)
   8         (tui_clear_exec_info_content): Update.
   9         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
  10         Update.
  11         * tui/tui-win.c (make_invisible_and_set_new_height)
  12         (make_visible_with_new_height): Update.
  13         * tui/tui-source.c (tui_set_source_content)
  14         (tui_show_symtab_source): Update.
  15         * tui/tui-layout.c (extract_display_start_addr)
  16         (show_source_disasm_command, show_data)
  17         (make_source_or_disasm_window)
  18         (show_source_or_disasm_and_command): Update.
  19         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
  20         (tui_disasm_window::do_scroll_vertical): Remove shadowing
  21         "gdbarch".
  22         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
  23         to tui_source_window_base.
  24         (struct tui_win_info) <detail>: Remove source_info member.
  25         (struct tui_source_window_base) <has_locator>: Inline.
  26         Move contents from tui_source_info; rename has_locator member to
  27         m_has_locator.
  28         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
  29         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
  30         header file.
  31         (tui_source_window_base::clear_detail, ~tui_source_window_base):
  32         Simplify.
  33         (tui_free_all_source_wins_content): Cast to
  34         tui_source_window_base.
  35
  36 2019-06-25  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-win.c (make_invisible_and_set_new_height)
  39         (make_visible_with_new_height): Call has_locator method.
  40         * tui/tui-layout.c (show_source_disasm_command, show_data)
  41         (show_source_or_disasm_and_command): Update for bool change.
  42         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
  43         (tui_win_info) <has_locator>: New method.
  44         (struct tui_source_window_base) <has_locator>: New method.
  45         (tui_win_has_locator): Don't declare.
  46         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
  47         from tui_win_has_locator.
  48         (tui_source_window_base): Use false, not FALSE.
  49
  50 2019-06-25  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
  53         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
  54         clear_detail method directly.
  55         (tui_clear_win_detail): Remove.
  56
  57 2019-06-25  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  60         "this", not TUI_DISASM_WIN.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
  65         declare.
  66         * tui/tui-winsource.c
  67         (tui_source_window_base::do_scroll_horizontal): Rename from
  68         tui_horizontal_source_scroll.
  69         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
  70         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
  71         from tui_vertical_data_scroll.
  72         * tui/tui-win.h (tui_scroll): Don't declare.
  73         * tui/tui-win.c (tui_win_info::forward_scroll)
  74         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  75         (tui_win_info::right_scroll): Rename and update.
  76         (tui_scroll_forward_command, tui_scroll_backward_command)
  77         (tui_scroll_left_command, tui_scroll_right_command): Update.
  78         (tui_scroll): Remove.
  79         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
  80         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
  81         from tui_vertical_source_scroll.
  82         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
  83         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
  84         from tui_vertical_disassem_scroll.
  85         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
  86         do_scroll_horizontal>: New methods.
  87         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
  88         Likewise.
  89         (struct tui_source_window_base): Add do_scroll_horizontal.
  90         (struct tui_source_window, struct tui_disasm_window): Add
  91         do_scroll_vertical.
  92         (struct tui_data_window, struct tui_cmd_window): Add
  93         do_scroll_horizontal and do_scroll_vertical.
  94         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-data.h (struct tui_source_window_base): New struct.
  99         (struct tui_source_window): Derive from tui_source_window_base.
 100         (struct tui_disasm_window): New struct.
 101         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 102         from tui_source_window::clear_detail.
 103         (tui_source_window_base): Rename from tui_source_window.
 104         (~tui_source_window_base): Rename from ~tui_source_window.
 105         (tui_alloc_win_info): Create a tui_disasm_window.
 106
 107 2019-06-25  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-data.h (struct tui_source_window)
 110         (struct tui_data_window): Declare destructors.
 111         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 112         destructors.
 113         (tui_win_info): Simplify.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-winsource.c (tui_display_main)
 118         (tui_update_source_windows_with_addr)
 119         (tui_update_all_breakpoint_info): Update.
 120         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 121         (new_height_ok, parse_scrolling_args): Update.
 122         * tui/tui-stack.c (tui_show_frame_info): Update.
 123         * tui/tui-data.h (struct tui_list): Remove.
 124         (tui_source_windows): Return a reference to a std::vector.
 125         * tui/tui-data.c (source_windows): Now a std::vector.
 126         (tui_source_windows): Change return type.
 127         (tui_clear_source_windows): Rewrite.
 128         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 129         (tui_free_all_source_wins_content): Rewrite.
 130
 131 2019-06-25  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 134         (struct tui_data_window, struct tui_cmd_window): Declare
 135         clear_detail method.
 136         * tui/tui-data.c (tui_source_window::clear_detail)
 137         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 138         methods.
 139         (tui_clear_win_detail): Simplify.
 140
 141 2019-06-25  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-layout.c (make_source_window, make_disasm_window)
 144         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 145         Return the new window.
 146         (show_source_disasm_command, show_data)
 147         (show_source_or_disasm_and_command): Update.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 152         parameter.  Return the new window.
 153         (show_source_disasm_command): Update and remove NULL check.
 154         (show_source_or_disasm_and_command): Update.
 155
 156 2019-06-25  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 159
 160 2019-06-25  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-data.h (struct tui_win_info): Make constructor
 163         protected.  Make destructor virtual.  Add initializers.
 164         (tui_source_window, tui_data_window, tui_cmd_window): New
 165         classes.
 166         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 167         constructor.  Add "type" parameter.
 168         (tui_source_window, tui_data_window, tui_cmd_window): New
 169         constructors.
 170         (tui_alloc_win_info): Instantiate the appropriate subclass.
 171
 172 2019-06-25  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-win.c (tui_resize_all): Use delete.
 175         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 176         destructor.
 177         (tui_free_window): Don't declare.
 178         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 179         Update.
 180
 181 2019-06-25  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-data.h (struct tui_win_info): Add constructor.
 184         * tui/tui-data.c (tui_alloc_win_info): Use new.
 185         (tui_free_window): Use delete.
 186
 187 2019-06-22  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 190         declare.
 191         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 192
 193 2019-06-22  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 196         declare.
 197         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 198
 199 2019-06-22  Tom de Vries  <tdevries@suse.de>
 200
 201         * dwarf2read.c (create_addrmap_from_aranges)
 202         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 203         instead of '%zu'.
 204
 205 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 206
 207         * dwarf2read.h (dwarf2_section_info_def): Remove.
 208         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 209         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 210         std::vector<dwarf2_section_info>.
 211         (struct dwo_file) <~dwo_file>: Remove.
 212         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 213         types field.
 214         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 215         (dwarf2_read_debug_names): Likewise.
 216         (create_debug_types_hash_table): Change parameter type to
 217         array_view, adjust code accordingly.
 218         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 219         (partial_die_info::fixup): Likewise.
 220         (determine_prefix): Likewise.
 221         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 222
 223 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 224
 225         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 226         gdb_bfd_ref_ptr.
 227         <~dwo_file>: Remove call to gdb_bfd_unref.
 228         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 229         gdb_bfd_ref_ptr::get.
 230
 231 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 232
 233         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 234         type to htab_up.
 235         * dwarf2read.c (struct dwo_file): Initialize fields.
 236         <~dwo_file>: New.
 237         (free_dwo_file): Remove, move content to ~dwo_file.
 238         (struct dwo_file_deleter): Remove.
 239         (dwo_file_up>: Remove custom deleter.
 240         (free_dwo_files): Remove.
 241         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 242         dwo_files.
 243         (process_skeletonless_type_units): Call unique_ptr::get.
 244         (allocate_dwo_file_hash_table): Add deleter to created hash
 245         table.  Change return type to htab_up.
 246         (lookup_dwo_file_slot): Don't memset dwo_file, call
 247         unique_ptr::get.
 248         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 249         (create_dwo_unit_in_dwp_v2): Likewise.
 250         (open_and_init_dwo_file): Likewise.
 251         (free_dwo_file_from_slot): Remove.
 252
 253 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 254
 255         * dwarf2read.h (struct dwarf2_section_info) <readin,
 256         is_virtual>: Change type to bool.
 257         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 258         true instead of 1.
 259
 260 2019-06-19  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-data.h (tui_init_content_element): Don't declare.
 263
 264 2019-06-19  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-data.h (tui_init_win_info): Don't declare.
 267
 268 2019-06-19  Tom de Vries  <tdevries@suse.de>
 269
 270         * dwarf2read.h (abstract_to_concrete): Change type to
 271         std::unordered_map<sect_offset, std::vector<sect_offset>,
 272         gdb::hash_enum<sect_offset>>.
 273
 274 2019-06-19  Tom Tromey  <tromey@adacore.com>
 275
 276         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 277         EVAL_AVOID_SIDE_EFFECTS specially.
 278
 279 2019-06-19  Tom Tromey  <tromey@adacore.com>
 280
 281         * source-cache.c (highlighter): New global.
 282         (source_cache::get_source_lines): Create a highlighter on demand.
 283
 284 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 285
 286         * defs.h (deprecated_interactive_hook): Delete declaration.
 287         * interps.c (clear_interpreter_hooks): Remove use of
 288         deprecated_interactive_hook.
 289         * top.c (deprecated_interactive_hook): Delete definition.
 290         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 291
 292 2019-06-18  Tom de Vries  <tdevries@suse.de>
 293
 294         PR gdb/24515
 295         * dwarf2read.h (abstract_to_concrete): Change type from
 296         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 297         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 298         * dwarf2read.c (read_variable): Update.
 299         (dwarf2_fetch_die_loc_sect_off): Update.
 300
 301 2019-06-17  Tom de Vries  <tdevries@suse.de>
 302
 303         PR gdb/24617
 304         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 305         accessing parent[parent_len - 1].
 306
 307 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 308
 309         PR gdb/24364
 310         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 311         call dtrace_process_dof with NULL dof.
 312
 313 2019-06-16  Tom de Vries  <tdevries@suse.de>
 314
 315         PR gdb/24445
 316         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 317
 318 2019-06-16  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 321         (make_all_visible): Use address of member.
 322
 323 2019-06-16  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 326         (tui_free_window, free_content, free_content_elements): Remove
 327         unnecessary cast.
 328         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 329         cast.
 330         * tui/tui-regs.c (tui_show_register_group)
 331         (tui_display_registers_from, tui_display_reg_element_at_line):
 332         Remove unnecessary cast.
 333
 334 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * linux-nat.c (normal_mask): Delete.
 337         (_initialize_linux_nat): Don't initialise normal_mask.
 338
 339 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 340
 341         PR gdb/24445
 342         * dwarf-index-write.h (write_psymtabs_to_index): Add
 343         dwz_basename parameter.
 344         * dwarf-index-write.c (write_gdbindex): Move file writing to
 345         write_gdbindex_1.  Change return type void.
 346         (assert_file_size): Move up, remove filename parameter.
 347         (write_gdbindex_1): New function.
 348         (write_debug_names): Change return type to void, call
 349         assert_file_size.
 350         (struct index_wip_file): New struct.
 351         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 352         file logic to index_wip_file.  Write index for dwz file if
 353         needed.
 354         (save_gdb_index_command): Pass basename of dwz file, if present.
 355         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 356         build-id of dwz file, if present.
 357         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 358         (dwarf2_get_dwz_file): Likewise.
 359         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 360         (dwarf2_get_dwz_file): Likewise.
 361
 362 2019-06-16  Tom Tromey  <tom@tromey.com>
 363
 364         * coffread.c (process_coff_symbol): Use xstrdup.
 365         * value.c (create_internalvar): Use xstrdup.
 366
 367 2019-06-16  Tom Tromey  <tom@tromey.com>
 368
 369         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 370         * breakpoint.c (stopin_command, stopat_command)
 371         (until_break_command, decode_location_default): Remove unnecessary
 372         cast.
 373         * utils.c (subset_compare): Remove unnecessary cast.
 374         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 375         cast.
 376         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 377         cast.
 378         * infcmd.c (path_command): Remove unnecessary cast.
 379         * coffread.c (decode_type): Remove unnecessary cast.
 380         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 381         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 382         * tui/tui-stack.c (tui_show_locator_content)
 383         (tui_show_frame_info): Remove unnecessary cast.
 384         * tui/tui-win.c (tui_scroll_forward_command)
 385         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 386         (parse_scrolling_args): Remove unnecessary cast.
 387         * tui/tui-data.c (init_win_info, tui_del_window)
 388         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 389         (free_content_elements): Remove unnecessary cast.
 390         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 391         unnecessary cast.
 392         * tui/tui-source.c (tui_set_source_content)
 393         (tui_vertical_source_scroll): Remove unnecessary cast.
 394         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 395         cast.
 396         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 397         * tui/tui-regs.c (tui_display_registers_from)
 398         (tui_display_register): Remove unnecessary cast.
 399         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 400         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 401         (make_visible): Remove unnecessary cast.
 402         * tui/tui-winsource.c (tui_erase_source_content)
 403         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 404         unnecessary cast.
 405         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 406         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 407         * stabsread.c (read_type, read_array_type, read_range_type):
 408         Remove unnecessary cast.
 409         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 410         (parse_symbol, parse_type, upgrade_type, parse_external)
 411         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 412         unnecessary cast.
 413         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 414
 415 2019-06-16  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-data.c (tui_alloc_generic_win_info)
 418         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 419         checks.
 420
 421 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 422             Andrew Burgess  <andrew.burgess@embecosm.com>
 423
 424         * f-typeprint.c (f_print_type): Don't return early for not
 425         associated or not allocated types.
 426         (f_type_print_varspec_suffix): Add print_rank parameter and print
 427         ranks of array types in case they dangling.
 428         (f_type_print_base): Add print_rank parameter.
 429
 430 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 431
 432         * NEWS: Mention new MI commands.
 433         * break-catch-throw.c (enum exception_event_kind): Move to
 434         breakpoint.h.
 435         (print_mention_exception_catchpoint): Output text as a single
 436         message.
 437         (catch_exception_command_1): Rename to...
 438         (catch_exception_event): ...this, make non-static, update header
 439         command, and change some parameter types.
 440         (catch_catch_command): Update for changes to
 441         catch_exception_command_1.
 442         (catch_throw_command): Likewise.
 443         (catch_rethrow_command): Likewise.
 444         * breakpoint.c (enum exception_event_kind): Delete.
 445         * breakpoint.h (enum exception_event_kind): Moved here from
 446         break-catch-throw.c.
 447         (catch_exception_event): Declare.
 448         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 449         (mi_cmd_catch_throw): New function.
 450         (mi_cmd_catch_rethrow): New function.
 451         (mi_cmd_catch_catch): New function.
 452         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 453         'catch-catch' entries.
 454         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 455         (mi_cmd_catch_rethrow): Declare.
 456         (mi_cmd_catch_catch): Declare.
 457
 458 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * annotate.c (annotate_source_line): Change return type to void,
 461         update implementation to match.
 462         * annotate.h (annotate_source_line): Change return type to void,
 463         update header comment.
 464         * stack.c (print_frame_info): Don't change what frame information
 465         is printed based on whether annotations are on or not.
 466
 467 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 468
 469         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 470         (annotate_source): Make static.
 471         (annotate_source_line): Moved from source.c and renamed from
 472         identify_source_line.  Update the return type.
 473         * annotate.h (annotate_source): Delete declaration.
 474         (annotate_source_line): Declaration moved from source.h, and
 475         renamed from identify_source_line.  Return type updated.
 476         * source.c (identify_source_line): Moved to annotate.c and renamed
 477         to annotate_source_line.
 478         (info_line_command): Remove check of annotation_level.
 479         * source.h (identify_source_line): Move declaration to annotate.h
 480         and rename to annotate_source_line.
 481         * stack.c: Add 'annotate.h' include.
 482         (print_frame_info): Remove check of annotation_level before
 483         calling annotate_source_line.
 484
 485 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * source-cache.c (source_cache::get_plain_source_lines): Use
 488         open_source_file_with_line_charpos instead of just
 489         open_source_file, remove call to find_source_lines.
 490         (source_cache::get_source_lines): Likewise.
 491         * source.c (find_source_lines): Make static.
 492         (get_filename_and_charpos): Renamed into...
 493         (open_source_file_with_line_charpos): ..this along with changes to
 494         return a scoped_fd, and some other minor clean ups.
 495         (identify_source_line): Use open_source_file_with_line_charpos.
 496         (search_command_helper): Use open_source_file_with_line_charpos
 497         instead of just open_source_file, remove call to
 498         find_source_lines.
 499         * source.h (open_source_file_with_line_charpos): Declare new
 500         function.
 501         (find_source_lines): Delete declaration.
 502
 503 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * source.c (get_filename_and_charpos): Remove fullname
 506         parameter.
 507         (identify_source_line): Update call to get_filename_and_charpos.
 508
 509 2019-06-14  Tom Tromey  <tromey@adacore.com>
 510
 511         PR gdb/24502:
 512         * ui-style.h (skip_ansi_escape): Update comment.
 513         * ui-file.h (class no_terminal_escape_file): New class.
 514         * ui-file.c (no_terminal_escape_file::write)
 515         (no_terminal_escape_file::puts): New methods.
 516         * cli/cli-logging.c (handle_redirections): Use
 517         no_terminal_escape_file.
 518
 519 2019-06-14  Tom Tromey  <tromey@adacore.com>
 520
 521         * NEWS: Move convenience variable news above Python news.
 522
 523 2019-06-14  Tom Tromey  <tom@tromey.com>
 524
 525         * gnulib: Move directory to top-level.
 526         * configure.ac: Don't configure gnulib.
 527         * configure: Rebuild.
 528         * common/common-defs.h: Use new path to gnulib.
 529         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 530         (GNULIB_H): Remove.
 531         (INCGNU): Look in new gnulib location.
 532         (HFILES_NO_SRCDIR): Remove gnulib files.
 533         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 534         (generated_files): Remove GNULIB_H.
 535         ($(LIBGNU), all-lib): Remove targets.
 536         (distclean): Don't mention GNULIB_BUILDDIR.
 537         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 538
 539 2019-06-14  Tom Tromey  <tromey@adacore.com>
 540
 541         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 542         Warn if symbol file does not provide any symbols.
 543
 544 2019-06-14  Tom Tromey  <tromey@adacore.com>
 545
 546         * source.c (find_and_open_source): Respect basenames_may_differ.
 547
 548 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * annotate.c (annotate_breakpoints_invalid): Make use of
 551         scoped_restore_terminal_state.
 552         (annotate_frames_invalid): Likewise.
 553
 554 2019-06-14  Tom Tromey  <tromey@adacore.com>
 555
 556         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 557         allow assignment to an internalvar.
 558
 559 2019-06-14  Tom Tromey  <tromey@adacore.com>
 560
 561         * ada-lex.l: Allow "_" in attribute names.
 562
 563 2019-06-14  Tom Tromey  <tromey@adacore.com>
 564
 565         PR gdb/24653:
 566         * regcache.c (registers_changed): Don't call alloca.
 567         * top.c (execute_command): Don't call alloca.
 568
 569 2019-06-13  Pedro Alves  <palves@redhat.com>
 570
 571         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 572         'expression'.  When parsing an expression, error out if there's
 573         junk after "unlimited".
 574         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 575         (do_set_command): Adjust calls to is_unlimited_literal.
 576
 577 2019-06-13  Pedro Alves  <palves@redhat.com>
 578
 579         * compile/compile.c (make_compile_options_def_group): Add braces
 580         around array_view initializer.
 581         * thread.c (make_thread_apply_all_options_def_group)
 582         (make_thread_apply_all_options_def_group): Likewise.
 583
 584 2019-06-13  Pedro Alves  <palves@redhat.com>
 585
 586         * NEWS (New commands): Mention "maint test-options
 587         require-delimiter", "maint test-options unknown-is-error", "maint
 588         test-options unknown-is-operand" and "maint show
 589         test-options-completion-result".
 590         (New command options, command completion): New section.
 591         (Completion improvements): New section.
 592         Mention that you can abbreviate "unlimited".
 593
 594 2019-06-13  Pedro Alves  <palves@redhat.com>
 595
 596         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 597         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 598         * unittests/cli-utils-selftests.c (test_parse_flags)
 599         (test_parse_flags_qcs): Delete.
 600         (test_cli_utils): Don't call deleted functions.
 601
 602 2019-06-13  Pedro Alves  <palves@redhat.com>
 603
 604         * thread.c: Include "cli/cli-option.h".
 605         (tp_array_compar_ascending): Global.
 606         (tp_array_compar): Delete function.
 607         (tp_array_compar_ascending, tp_array_compar_descending): New
 608         functions.
 609         (ascending_option_def, qcs_flag_option_def)
 610         (thr_qcs_flags_option_defs)
 611         (make_thread_apply_all_options_def_group)
 612         (make_thread_apply_options_def_group): New.
 613         (thread_apply_all_command): Use gdb::option::process_options.
 614         (thread_apply_command_completer)
 615         (thread_apply_all_command_completer): New.
 616         (thread_apply_command): Use gdb::option::process_options.
 617         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 618         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 619         to generate help text of "thread apply".  Adjust "taas"'s help.
 620         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 621         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 622
 623 2019-06-13  Pedro Alves  <palves@redhat.com>
 624
 625         * thread.c (thread_apply_command): Check for invalid TID with
 626         isdigit instead of !isalpha.
 627
 628 2019-06-13  Pedro Alves  <palves@redhat.com>
 629
 630         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 631         (validate_flags_qcs): New.
 632         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 633         (validate_flags_qcs): Declare.
 634         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 635         (make_frame_apply_options_def_group): New.
 636         (frame_apply_command_count): Process options with
 637         gdb::option::process_options.
 638         (frame_apply_completer): New.
 639         (frame_apply_level_completer, frame_apply_all_completer)
 640         (frame_apply_completer): New.
 641         (_initialize_stack): Update help of "frame apply", "frame apply
 642         level", "frame apply all" and "faas" to mention supported options
 643         and install command completers.
 644         * stack.h (frame_apply_all_completer): Declare.
 645         * thread.c: Include "stack.h".
 646         (tfaas_command): Add "--".
 647         (_initialize_thread): Update help "tfaas" to mention supported
 648         options and install command completer.
 649
 650 2019-06-13  Pedro Alves  <palves@redhat.com>
 651
 652         * completer.c (complete_nested_command_line): New.
 653         (gdb_completion_word_break_characters_throw): Add assertion.
 654         * completer.h (complete_nested_command_line): Declare.
 655
 656 2019-06-13  Pedro Alves  <palves@redhat.com>
 657
 658         * stack.c (parse_backtrace_qualifiers): New.
 659         (backtrace_command): Use it.
 660         (backtrace_command_completer): Complete on qualifiers.
 661
 662 2019-06-13  Pedro Alves  <palves@redhat.com>
 663
 664         * frame.c: Include "cli/cli-option.h.
 665         (user_set_backtrace_options): New.
 666         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 667         Delete.
 668         (get_prev_frame): Adjust.
 669         (boolean_option_def, uinteger_option_def)
 670         (set_backtrace_option_defs): New.
 671         (_initialize_frame): Adjust and use
 672         gdb::option::add_setshow_cmds_for_options to install "set
 673         backtrace past-main" and "set backtrace past-entry".
 674         * frame.h: Include "cli/cli-option.h".
 675         (struct frame_print_options): Forward declare.
 676         (print_frame_arguments_all, print_frame_arguments_scalars)
 677         (print_frame_arguments_none): Declare.
 678         (print_entry_values): Delete declaration.
 679         (struct frame_print_options, user_frame_print_options): New.
 680         (struct set_backtrace_options): New.
 681         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 682         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 683         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 684         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 685         (list_args_or_locals): Add frame_print_options parameter.
 686         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 687         * python/py-framefilter.c (enumerate_args): Pass down
 688         USER_FRAME_PRINT_OPTIONS.
 689         * stack.c: Include "cli/cli-option.h".
 690         (print_frame_arguments_all, print_frame_arguments_scalars)
 691         (print_frame_arguments_none): Declare.
 692         (print_raw_frame_arguments, print_entry_values): Delete.
 693         (user_frame_print_options): New.
 694         (boolean_option_def, enum_option_def, frame_print_option_defs):
 695         New.
 696         (struct backtrace_cmd_options): New.
 697         (bt_flag_option_def): New.
 698         (backtrace_command_option_defs): New.
 699         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 700         (print_frame_arg, read_frame_arg, print_frame_args)
 701         (print_frame_info, print_frame): Add frame_print_options parameter
 702         and use it.
 703         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 704         (backtrace_command_1): Add frame_print_options and
 705         backtrace_cmd_options parameters and use them.
 706         (make_backtrace_options_def_group): New.
 707         (backtrace_command): Process command options with
 708         gdb::option::process_options.
 709         (backtrace_command_completer): New.
 710         (_initialize_stack): Extend "backtrace"'s help to mention
 711         supported options.  Install completer for "backtrace".
 712         Install some settings commands with add_setshow_cmds_for_options.
 713
 714 2019-06-13  Pedro Alves  <palves@redhat.com>
 715
 716         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 717         and that "set/show print raw frame-arguments" are now deprecated.
 718
 719         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 720         command.
 721         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 722         * stack.c (_initialize_stack): Install "set/show print
 723         raw-frame-arguments", and deprecate "set/show print raw
 724         frame-arguments".
 725         * valprint.c (_initialize_valprint): Deprecate "set/show print
 726         raw".
 727
 728 2019-06-13  Pedro Alves  <palves@redhat.com>
 729
 730         * compile/compile.c (struct compile_options): New.
 731         (compile_flag_option_def, compile_command_option_defs)
 732         (make_compile_options_def_group): New.
 733         (compile_file_command): Handle options with
 734         gdb::option::process_options.
 735         (compile_file_command_completer): New function.
 736         (compile_code_command): Handle options with
 737         gdb::option::process_options.
 738         (compile_code_command_completer): New function.
 739         (_initialize_compiler): Install completers for "compile code" and
 740         "compile file".  Mention available options in "compile code" and
 741         "compile code"'s help.
 742         * completer.c (advance_to_completion_word): New, factored out from
 743         ...
 744         (advance_to_expression_complete_word_point): ... this.
 745         (advance_to_filename_complete_word_point): New.
 746         * completer.h (advance_to_filename_complete_word_point): New
 747         declaration.
 748
 749 2019-06-13  Pedro Alves  <palves@redhat.com>
 750
 751         * compile/compile.c: Include "cli/cli-option.h".
 752         (compile_print_value): Scope data pointer is now a
 753         value_print_options pointer; adjust.
 754         (compile_print_command): Process options.  Scope data pointer is
 755         now a value_print_options pointer; adjust.
 756         (_initialize_compile): Update "compile print"'s help to include
 757         supported options.  Install a completer for "compile print".
 758         * cp-valprint.c (show_vtblprint, show_objectprint)
 759         (show_static_field_print): Delete.
 760         (_initialize_cp_valprint): Don't install "set print
 761         static-members", "set print vtbl", "set print object" here.
 762         * printcmd.c: Include "cli/cli-option.h" and
 763         "common/gdb_optional.h".
 764         (print_command_parse_format): Rework to fill in a
 765         value_print_options instead of a format_data.
 766         (print_value): Change parameter type from format_data pointer to
 767         value_print_options reference.  Adjust.
 768         (print_command_1): Process options.  Adjust to pass down a
 769         value_print_options.
 770         (print_command_completer): New.
 771         (_initialize_printcmd): Install print_command_completer as
 772         handle_brkchars completer for the "print" command.  Update
 773         "print"'s help to include supported options.
 774         * valprint.c: Include "cli/cli-option.h".
 775         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 776         here from cp-valprint.c.
 777         (boolean_option_def, uinteger_option_def)
 778         (value_print_option_defs, make_value_print_options_def_group):
 779         New.  Use gdb::option::add_setshow_cmds_for_options to install
 780         "set print elements", "set print null-stop", "set print repeats",
 781         "set print pretty", "set print union", "set print array", "set
 782         print address", "set print symbol", "set print array-indexes".
 783         * valprint.h: Include <string> and "cli/cli-option.h".
 784         (make_value_print_options_def_group): Declare.
 785         (print_value): Change parameter type from format_data pointer to
 786         value_print_options reference.
 787         (print_command_completer): Declare.
 788
 789 2019-06-13  Pedro Alves  <palves@redhat.com>
 790
 791         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 792         (COMMON_SFILES): Add maint-test-settings.c.
 793         * cli/cli-decode.c (boolean_enums): New global, factored out from
 794         ...
 795         (add_setshow_boolean_cmd): ... here.
 796         * cli/cli-decode.h (boolean_enums): Declare.
 797         * cli/cli-option.c: New file.
 798         * cli/cli-option.h: New file.
 799         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 800         factored out from ...
 801         (parse_cli_boolean_value(const char *)): ... this.
 802         (is_unlimited_literal): Change parameter type to pointer to
 803         pointer.  Adjust and advance ARG pointer.
 804         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 805         (parse_cli_var_enum): New, factored out from ...
 806         (do_set_command): ... this.  Adjust.
 807         * cli/cli-setshow.h (parse_cli_boolean_value)
 808         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 809         (parse_cli_var_enum): Declare.
 810         * cli/cli-utils.c: Include "cli/cli-option.h".
 811         (get_ulongest): New.
 812         * cli/cli-utils.h (get_ulongest): Declare.
 813         (check_for_argument): New overloads.
 814         * maint-test-options.c: New file.
 815
 816 2019-06-13  Pedro Alves  <palves@redhat.com>
 817
 818         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 819         parse a range if "-" is at the end of the string.
 820
 821 2019-06-13  Pedro Alves  <palves@redhat.com>
 822
 823         * cli/cli-setshow.c (parse_auto_binary_operation)
 824         (parse_cli_boolean_value): Don't allow "o".
 825
 826 2019-06-13  Pedro Alves  <palves@redhat.com>
 827
 828         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 829         * NEWS: Mention maint test-settings KIND.
 830         * maint-test-settings.c: New file.
 831
 832 2019-06-13  Pedro Alves  <palves@redhat.com>
 833
 834         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 835         completer.
 836         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 837         "set" completers.
 838
 839 2019-06-13  Pedro Alves  <palves@redhat.com>
 840
 841         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 842         after item.
 843
 844 2019-06-13  Pedro Alves  <palves@redhat.com>
 845
 846         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 847
 848 2019-06-13  Pedro Alves <palves@redhat.com>
 849
 850         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 851         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 852         call.
 853         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 854         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 855         calls.
 856         (check_for_argument): Skip spaces after argument.
 857
 858 2019-06-13  Pedro Alves  <palves@redhat.com>
 859
 860         * thread.c (thread_apply_command): Adjust TID parsing.
 861         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 862         detected before end of string.
 863         (tid_is_in_list): Error out if LIST is invalid.
 864
 865 2019-06-13  Pedro Alves  <palves@redhat.com>
 866
 867         * completer.c (complete_line_internal_1): Rewind completion word
 868         point.
 869         (completion_tracker::advance_custom_word_point_by): Change
 870         parameter type to int.
 871         * completer.h (completion_tracker::advance_custom_word_point_by):
 872         Likewise.
 873
 874 2019-06-13  Pedro Alves  <palves@redhat.com>
 875
 876         * completer.c (advance_to_completion_word): Handle delimiters.
 877
 878 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 879
 880         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 881
 882 2019-06-11  Tom Tromey  <tom@tromey.com>
 883
 884         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 885         (xmalloc_failed): Move to alloc.c.
 886         * alloc.c: New file.
 887         * Makefile.in (COMMON_SFILES): Add alloc.c.
 888
 889 2019-06-11  Tom Tromey  <tom@tromey.com>
 890
 891         * nat/linux-waitpid.c: Don't include server.h.
 892         (linux_debug): Remove.
 893         (my_waitpid): Update.
 894
 895 2019-06-11  Tom Tromey  <tromey@adacore.com>
 896
 897         * infcall.c (_initialize_infcall): Remove trailing newline from
 898         help.
 899         * user-regs.c (_initialize_user_regs): Remove trailing newline
 900         from help.
 901         * typeprint.c (_initialize_typeprint): Remove trailing newline
 902         from help.
 903         * reverse.c (_initialize_reverse): Remove trailing newlines from
 904         help.
 905         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 906         from help.
 907         * language.c (add_set_language_command): Remove trailing newline
 908         from help.
 909         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 910         help.
 911         * disasm.c (_initialize_disasm): Remove trailing newline from
 912         help.
 913         * top.c (init_main): Remove trailing newline from help.
 914         * interps.c (_initialize_interpreter): Remove trailing newline
 915         from help.
 916         * btrace.c (_initialize_btrace): Remove trailing newlines from
 917         help.
 918         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 919         from help.
 920         * python/python.c (_initialize_python): Remove trailing newline
 921         from help.
 922         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 923         help.
 924         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 925         from help.  Reformat some text.
 926         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 927         from help.
 928         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 929         newline from help.
 930
 931 2019-06-11  Tom Tromey  <tromey@adacore.com>
 932
 933         * darwin-nat.c (darwin_decode_exception_message)
 934         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 935
 936 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * valops.c (value_slice): Check for not allocated or not
 939         associated values.
 940
 941 2019-06-10  Tom de Vries  <tdevries@suse.de>
 942
 943         PR gdb/24618
 944         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 945         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 946         invalid.
 947
 948 2019-06-10  Tom de Vries  <tdevries@suse.de>
 949
 950         PR gdb/24611
 951         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 952         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 953
 954 2019-06-10  Tom de Vries  <tdevries@suse.de>
 955
 956         PR symtab/24545
 957         * symtab.c (struct demangled_name_entry): Add language field.
 958         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 959         static minimal symbol".  Set and use language field.
 960
 961 2019-06-10  Tom Tromey  <tromey@adacore.com>
 962
 963         * ada-lang.c (_initialize_ada_language): Update help text.
 964
 965 2019-06-10  Tom Tromey  <tromey@adacore.com>
 966
 967         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 968         with a newline.
 969         * guile/guile.c (handle_boot_error): Don't end warning with a
 970         newline.
 971         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 972         warning with a newline.
 973         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 974         newline.
 975         (s12z_frame_cache): Likewise.
 976         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 977         a newline.
 978         * solib-svr4.c (disable_probes_interface): Don't end warning with
 979         a newline.
 980         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 981         newline.
 982         * python/python.c (do_finish_initialization): Don't end warning
 983         with a newline.
 984
 985 2019-06-10  Tom Tromey  <tom@tromey.com>
 986
 987         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 988         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 989         gdbpy_enter.
 990
 991 2019-06-10  Tom Tromey  <tromey@adacore.com>
 992
 993         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 994         data.
 995         (elf_new_init): Don't call stabsread_new_init.
 996         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 997         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 998         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 999
1000 2019-06-10  Tom de Vries  <tdevries@suse.de>
1001
1002         PR symtab/16264
1003         PR symtab/24517
1004         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1005
1006 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1007
1008         * source.c (find_and_open_source): Also rewrite relative file
1009         names.
1010
1011 2019-04-26  Amos Bird  <amosbird@gmail.com>
1012
1013         * annotate.c (annotate_thread_exited): Add "thread-exited"
1014         annotation.
1015
1016 2019-06-06  Tom Tromey  <tromey@adacore.com>
1017
1018         * maint.h (class scoped_command_stats): Use
1019         DISABLE_COPY_AND_ASSIGN.
1020         <print_time>: New method.
1021         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1022         print_time.
1023         (scoped_command_stats::print_time): New method.
1024
1025 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1028         instructions of lengths 6 or 8 bytes.
1029
1030 2019-06-04  Pedro Alves  <palves@redhat.com>
1031
1032         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1033
1034         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1035         * breakpoint.c (condition_completer): Likewise.
1036         * cli/cli-dump.c (scan_expression): Likewise.
1037         * common/filestuff.c (mkdir_recursive): Likewise.
1038         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1039         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1040         (gdb_abspath): Likewise.
1041         * compile/compile-cplus-types.c
1042         (compile_cplus_instance::decl_name): Likewise.
1043         * completer.c (complete_explicit_location):
1044         (signal_completer, reg_or_group_completer_1): Likewise.
1045         * cp-support.c (cp_remove_params_if_any): Likewise.
1046         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1047         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1048         * infcmd.c (strip_bg_char): Likewise.
1049         * linespec.c (copy_token_string): Likewise.
1050         * mi/mi-main.c (output_cores): Likewise.
1051         * psymtab.c (psymtab_search_name):
1052         * symfile.c (test_set_ext_lang_command): Likewise.
1053         * target.c (target_fileio_read_stralloc): Likewise.
1054         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1055         * value.c (complete_internalvar): Likewise.
1056
1057 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1058
1059         Add objfile property to gdb.Type.
1060         * NEWS: Mention Python API addition.
1061         * python/py-type.c (typy_get_objfile): New method.
1062
1063 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1064
1065         * NEWS: Mention the new set|show style [title|highlight].
1066         Mention changes to "show style", "help" and "apropos".
1067
1068 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1069
1070         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1071         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1072         instead of print_help_for_command.
1073         (print_doc_of_command): New function.
1074         (help_list): Add 'apropos -v word' suggestion.
1075         (print_help_for_command): Style the command name using title style.
1076         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1077         (_initialize_cli_cmds): Describe -v in apropos_command help.
1078
1079 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1080
1081         * cli/cli-style.h (cli_style_option): Add name in constructor,
1082         add m_name class member, add constructor with intensity,
1083         add name class function.
1084         (cli_style_option::add_setshow_commands): Remove name argument.
1085         (highlight_style, title_style): New styles.
1086         * cli/cli-style.c (do_show): New function that shows a style
1087         characteristic styling the style name with itself.
1088         (set_style_name): New function.
1089         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1090         Update all callers according to the changes in cli/cli-style.h.
1091         * utils.h (fputs_highlighted): New function.
1092         * utils.c (fputs_highlighted): Likewise.
1093
1094 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1095
1096         * NEWS: Mention new pipe command and new convenience variables.
1097
1098 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1099
1100         * cli/cli-cmds.c (pipe_command): New function.
1101         (_initialize_cli_cmds): Call add_com for pipe_command.
1102         Define | as an alias for pipe.
1103         (exit_status_set_internal_vars): New function.
1104         (shell_escape): Call exit_status_set_internal_vars.
1105         cli/cli-decode.c (find_command_name_length): Recognize | as
1106         a single character command.
1107
1108 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1109
1110         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1111         top.c (execute_command_to_ui_file): New function, mostly a copy
1112         of execute_command_to_string.
1113         (execute_command_to_string): Implement by calling
1114         execute_command_to_ui_file.
1115
1116 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * top.h (saved_command_line): Remove declaration.
1119         * top.c (previous_saved_command_line, previous_repeat_arguments):
1120         New variables.
1121         (saved_command_line): Make static, define together with other
1122         'repeat variables'.
1123         (dont_repeat): Clear repeat_arguments.
1124         (repeat_previous, get_saved_command_line, save_command_line):
1125         New functions.
1126         (gdb_init): Initialize saved_command_line
1127         and previous_saved_command_line.
1128         * main.c (captured_main_1): Remove saved_command_line initialization.
1129         * event-top.c (handle_line_of_input): Update to use
1130         the new 'repeat' related functions instead of direct access to
1131         saved_command_line.
1132         * command.h (repeat_previous, get_saved_command_line,
1133         save_command_line): New declarations.
1134         (dont_repeat): Add comment.
1135
1136 2019-05-30  Tom Tromey  <tromey@adacore.com>
1137
1138         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1139         Fix comment.
1140         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1141
1142 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1143
1144         PR cli/24587
1145         * completer.c (complete): Initialize variable word.
1146
1147 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1148
1149         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1150         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1151         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1152         'body' is NULL to the outter 'if', protecting the '!is_define'
1153         situation as well.
1154
1155 2019-05-29  Tom Tromey  <tromey@adacore.com>
1156
1157         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1158         (dwarf_unknown): New function.
1159         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1160         (dwarf_type_encoding_name): Use dwarf_unknown.
1161
1162 2019-05-29  Tom Tromey  <tromey@adacore.com>
1163
1164         PR c++/20020:
1165         * cp-valprint.c (cp_print_value_fields): Call
1166         cp_print_static_field inside "try".
1167
1168 2019-05-29  Tom Tromey  <tromey@adacore.com>
1169
1170         * inflow.c (struct terminal_info): Add default operator=.
1171         * configure: Rebuild.
1172         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1173         -Wdeprecated-copy-dtor, -Wredundant-move.
1174
1175 2019-05-29  Tom Tromey  <tromey@adacore.com>
1176
1177         * NEWS: Add entry.
1178         * infcmd.c (print_return_value_1): Handle finish_print
1179         option.
1180         (show_print_finish): New function.
1181         (_initialize_infcmd): Add "set/show print finish" commands.
1182         * valprint.c (user_print_options): Initialize new member.
1183         * valprint.h (struct value_print_options) <finish_print>: New
1184         member.
1185
1186 2019-05-28  Tom Tromey  <tromey@adacore.com>
1187
1188         * ada-lang.c (ada_remove_Xbn_suffix)
1189         (find_old_style_renaming_symbol)
1190         (parse_old_style_renaming): Remove.
1191         (ada_find_renaming_symbol): Don't call
1192         find_old_style_renaming_symbol.
1193         (ada_is_renaming_symbol): Rename from
1194         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1195         bool.  Now static.
1196         (ada_read_var_value): Update and simplify.
1197         * ada-exp.y (write_var_or_type): Remove old code.
1198
1199 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1200
1201         * event-top.c: Remove include comment.
1202         * inflow.c (class scoped_ignore_sigttou): Move from here...
1203         * inflow.h (class scoped_ignore_sigttou): ...to here.
1204         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1205         * top.c:  Remove include comment.
1206
1207 2019-05-27  Tom Tromey  <tom@tromey.com>
1208
1209         * NEWS: Fix typo.
1210
1211 2019-05-22  Tom Tromey  <tromey@adacore.com>
1212
1213         * target.c (target_follow_exec): Constify parameter.
1214         * target-delegates.c: Rebuild.
1215         * remote.c (remote_target::follow_exec): Constify parameter.
1216         * infrun.c (follow_exec): Constify parameter.
1217         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1218         (target_follow_exec): Likewise.
1219
1220 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1221
1222         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1223         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1224
1225 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1226
1227         * NEWS: Add debugredirect and testsuite sections.
1228
1229 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1230
1231         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1232         target descriptions using exclusively floating point register name
1233         aliases.
1234
1235 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         PR gdb/18644:
1238         * f-lang.c (build_fortran_types): Handle the case where
1239         gdbarch_floatformat_for_type returns a nullptr.
1240
1241 2019-05-21  Tom de Vries  <tdevries@suse.de>
1242
1243         PR cli/24587
1244         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1245
1246 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         PR gdb/18644:
1249         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1250         16-byte floats.
1251         * i386-tdep.c (i386_floatformat_for_type): Use
1252         floatformats_ia64_quad for the 16-byte floating point component
1253         within a fortran 32-byte complex number.
1254
1255 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1258         delete default constructor.
1259         (find_partial_die): Update to return const struct.
1260         (partial_die_parent_scope): Move variable declaration into scope
1261         of its use and change its type to auto.
1262         (guess_partial_die_structure_name): Likewise.
1263         (partial_die_info::fixup): Likewise.
1264
1265 2019-05-17  Tom Tromey  <tromey@adacore.com>
1266
1267         * source.c (find_and_open_source): Remove cast.
1268
1269 2019-05-17  Tom Tromey  <tromey@adacore.com>
1270
1271         * annotate.c (annotate_source): Make "filename" const.
1272         * annotate.h (annotate_source): Use const.
1273
1274 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1275
1276         * disasm.c (set_disassembler_options): Send errors to stderr.
1277
1278 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1281         (cli_interp_base::set_logging): Check debug_redirect.
1282         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1283         * cli/cli-logging.c (debug_redirect): Add static variable.
1284         (pop_output_files): Add default param.
1285         (handle_redirections): Print debug setting.
1286         (show_logging_command): Likewise.
1287         (_initialize_cli_logging): Add debugredirect command.
1288         * interps.c (current_interp_set_logging): Add debug_redirect
1289         parameter.
1290         * interps.h (set_logging): Add debug_redirect parameter.
1291         (current_interp_set_logging): Likewise.
1292         * mi/mi-common.h: Likewise.
1293         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1294
1295 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1296             Tom Tromey  <tromey@adacore.com>
1297
1298         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1299         directly.
1300         * cli/cli-interp.h (make_logging_output): Remove declaration.
1301         * cli/cli-logging.c (make_logging_output): Remove function.
1302         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1303         directly.
1304         * ui-file.c (tee_file::tee_file): Remove bools.
1305         (tee_file::~tee_file): Remove deletes.
1306         * ui-file.h (tee_file): Remove bools.
1307
1308 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1309
1310         * mi/mi-cmds.h (mi_cmd_complete): New function.
1311         * mi/mi-main.c (mi_cmd_complete): Likewise.
1312         * mi/mi-cmds.c: Define new MI command -complete.
1313         * NEWS: Mention new -complete command.
1314
1315 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1316
1317         * completer.h (complete): New function.
1318         * completer.c (complete): Likewise.
1319         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1320         function defined in completer.h.
1321
1322 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1323
1324         * MAINTAINERS (Write After Approval): Add myself.
1325
1326 2019-05-17  Tom de Vries  <tdevries@suse.de>
1327
1328         PR gdb/24094
1329         * dwarf2read.c (struct cu_partial_die_info): New struct.
1330         (find_partial_die): Return cu_partial_die_info.
1331         (partial_die_parent_scope, guess_partial_die_structure_name)
1332         (partial_die_info::fixup): Handle new return type of find_partial_die.
1333
1334 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1335
1336         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1337         "std::string", simplifying the algorithm.
1338
1339 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1340
1341         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1342         (stap_static_probe_ops::get_probes): Likewise.
1343
1344 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1345
1346         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1347         '-')" and "else if".
1348         (stap_parse_single_operand): Join checks for
1349         "gdbarch_stap_parse_special_token_p" and
1350         "gdbarch_stap_parse_special_token" in the same "if" statement.
1351         Invert check when verifying for operation on register
1352         displacement.
1353
1354 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1355
1356         * stap-probe.c (stap_get_opcode): Update comment.
1357         (stap_get_expected_argument_type): Likewise.
1358         (handle_stap_probe): Likewise.
1359
1360 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1361
1362         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1363         return type to 'bool'.  Adjust comment.  Use 'bool' when
1364         appropriate.
1365         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1366         * stap-probe.c (stap_parse_argument_1): Likewise.
1367         (stap_is_operator): Likewise.
1368         (stap_is_generic_prefix): Likewise.
1369         (stap_is_register_prefix): Likewise.
1370         (stap_is_register_indirection_prefix): Likewise.
1371         (stap_is_integer_prefix): Likewise.
1372         (stap_generic_check_suffix): Likewise.
1373         (stap_check_integer_suffix): Likewise.
1374         (stap_check_register_suffix): Likewise.
1375         (stap_check_register_indirection_suffix): Likewise.
1376         (stap_parse_register_operand): Likewise.
1377         (stap_parse_single_operand): Likewise.
1378         (stap_parse_argument_1): Likewise.
1379         (stap_probe::get_argument_count): Likewise.
1380         (stap_is_operator): Likewise.
1381
1382 2019-05-16  Tom Tromey  <tromey@adacore.com>
1383
1384         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1385         keyword to foreach.
1386
1387 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1388
1389         * linux-thread-db.c (try_thread_db_load_1): Change return type
1390         to bool.
1391         (try_thread_db_load): Likewise.
1392         (try_thread_db_load_from_pdir_1): Likewise.
1393         (try_thread_db_load_from_pdir): Likewise.
1394         (try_thread_db_load_from_sdir): Likewise.
1395         (try_thread_db_load_from_dir): Likewise.
1396         (thread_db_load_search): Likewise.
1397         (has_libpthread): Likewise.
1398         (thread_db_load): Likewise.
1399
1400 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1401
1402         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1403         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1404         NULL, and complain/return if that's the case.
1405
1406 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1407
1408         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1409         (advance, posn, abstract_read_memory): New functions.
1410         [struct mem_read_abstraction]: New struct.
1411         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1412
1413 2019-05-14  Tom Tromey  <tromey@adacore.com>
1414
1415         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1416         value is not lval_memory.
1417
1418 2019-05-14  Tom Tromey  <tromey@adacore.com>
1419
1420         * solib.c (info_sharedlibrary_command): Style the file name.
1421
1422 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1423
1424         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1425         (aarch64_vnv_type): Likewise.
1426         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1427         * common/tdesc.c: Likewise.
1428         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1429         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1430         * features/aarch64-fpu.xml: Add ieee half view.
1431         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1432         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1433         * gdbtypes.h (struct builtin_type): Likewise.
1434         (struct objfile_type): Likewise.
1435
1436 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1437
1438         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1439         typo.
1440         * location.h (string_to_event_location): Likewise.
1441
1442 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1443
1444         GDB 8.3 released.
1445
1446 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1447
1448         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1449         New variable declaration.
1450         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1451         New variable.
1452         (print_one_breakpoint): Use ui_out::test_flags and new global
1453         variable to compute use_fixed_output.
1454         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1455         Remove.
1456         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1457         (mi_multi_location_breakpoint_output_fixed): Remove.
1458         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1459         new variable.
1460         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1461         fix_multi_location_breakpoint_output flag if version >= 3.
1462         * ui-out.h (enum ui_out_flag)
1463         <fix_multi_location_breakpoint_output>: New enumerator.
1464
1465 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1466
1467         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1468
1469 2019-05-10  Tom Tromey  <tromey@adacore.com>
1470
1471         * ada-lang.c (catch_ada_completer): New function.
1472         (_initialize_ada_language): Use it.
1473
1474 2019-05-10  Tom Tromey  <tromey@adacore.com>
1475
1476         * thread.c (print_thread_info): Make "requested_threads" const.
1477         * gdbthread.h (print_thread_info): Make "requested_threads"
1478         const.
1479         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1480         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1481
1482 2019-05-08  Tom Tromey  <tom@tromey.com>
1483
1484         * gdbtypes.c (objfile_type_data): Change type.
1485         (objfile_type, _initialize_gdbtypes): Update.
1486
1487 2019-05-08  Tom Tromey  <tom@tromey.com>
1488
1489         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1490         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1491         (_initialize_dwarf2_frame): Update.
1492
1493 2019-05-08  Tom Tromey  <tom@tromey.com>
1494
1495         * objc-lang.c (objc_objfile_data): Change type.
1496         (find_methods): Update.
1497         (_initialize_objc_lang): Remove.
1498
1499 2019-05-08  Tom Tromey  <tom@tromey.com>
1500
1501         * stabsread.c (rs6000_builtin_type_data): Change type.
1502         (rs6000_builtin_type, _initialize_stabsread): Update.
1503
1504 2019-05-08  Tom Tromey  <tom@tromey.com>
1505
1506         * mips-tdep.c (mips_pdr_data): Remove.
1507         (_initialize_mips_tdep): Update.
1508
1509 2019-05-08  Tom Tromey  <tom@tromey.com>
1510
1511         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1512         (hppa_init_objfile_priv_data, read_unwind_info)
1513         (find_unwind_entry, _initialize_hppa_tdep): Update.
1514
1515 2019-05-08  Tom Tromey  <tom@tromey.com>
1516
1517         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1518         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1519         on obstack.
1520         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1521
1522 2019-05-08  Tom Tromey  <tom@tromey.com>
1523
1524         * mdebugread.c (basic_type_data): Change type.
1525         (basic_type, _initialize_mdebugread): Update.
1526
1527 2019-05-08  Tom Tromey  <tom@tromey.com>
1528
1529         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1530
1531 2019-05-08  Tom Tromey  <tom@tromey.com>
1532
1533         * nto-tdep.c (nto_inferior_data_reg): Change type.
1534         (nto_inferior_data): Update.
1535         (nto_inferior_data_cleanup, nto_new_inferior_data)
1536         (_initialize_nto_tdep): Remove.
1537         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1538
1539 2019-05-08  Tom Tromey  <tom@tromey.com>
1540
1541         * ada-lang.c (struct ada_inferior_data): Add initializers.
1542         (ada_inferior_data): Change type.
1543         (ada_inferior_data_cleanup): Remove.
1544         (get_ada_inferior_data, ada_inferior_exit)
1545         (struct ada_pspace_data): Add initializers, destructor.
1546         (ada_pspace_data_handle): Change type.
1547         (get_ada_pspace_data): Update.
1548         (ada_pspace_data_cleanup): Remove.
1549
1550 2019-05-08  Tom Tromey  <tom@tromey.com>
1551
1552         * coffread.c (struct coff_symfile_info): Add initializers.
1553         (coff_objfile_data_key): Move lower.  Change type.
1554         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1555         Update.
1556         (coff_free_info): Remove.
1557
1558 2019-05-08  Tom Tromey  <tom@tromey.com>
1559
1560         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1561         (fbsd_pspace_data_handle): Move lower.  Change type.
1562         (get_fbsd_pspace_data): Update.
1563         (fbsd_pspace_data_cleanup): Remove.
1564         (_initialize_fbsd_tdep): Update.
1565
1566 2019-05-08  Tom Tromey  <tom@tromey.com>
1567
1568         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1569         (get_ada_tasks_pspace_data): Update.
1570         (ada_tasks_pspace_data_cleanup): Remove.
1571         (_initialize_tasks): Update.
1572         (ada_tasks_inferior_data_handle): Change type.
1573         (get_ada_tasks_inferior_data): Update.
1574         (ada_tasks_inferior_data_cleanup): Remove.
1575         (struct ada_tasks_pspace_data): Add initializers.
1576
1577 2019-05-08  Tom Tromey  <tom@tromey.com>
1578
1579         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1580         * symfile-debug.c (debug_sym_get_probes): Change type.
1581         * stap-probe.c (handle_stap_probe):
1582         (stap_static_probe_ops::get_probes): Change type.
1583         * probe.h (class static_probe_ops) <get_probes>: Change type.
1584         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1585         (parse_probes_in_pspace): Update.
1586         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1587         Update.
1588         (any_static_probe_ops::get_probes): Change type.
1589         * elfread.c (elfread_data): New typedef.
1590         (probe_key): Change type.
1591         (elf_get_probes): Likewise.  Update.
1592         (probe_key_free): Remove.
1593         (_initialize_elfread): Update.
1594         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1595         Change type.
1596         (dtrace_process_dof_probe, dtrace_process_dof)
1597         (dtrace_static_probe_ops::get_probe): Change type.
1598
1599 2019-05-08  Tom Tromey  <tom@tromey.com>
1600
1601         * xcoffread.c (struct xcoff_symfile_info): Rename from
1602         coff_symfile_info.  Add initializers.
1603         (xcoff_objfile_data_key): Move lower.  Change type.
1604         (XCOFF_DATA): Rewrite.
1605         (xcoff_free_info): Remove.
1606         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1607         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1608         (xcoff_initial_scan): Update.
1609
1610 2019-05-08  Tom Tromey  <tom@tromey.com>
1611
1612         * solib-svr4.c (struct svr4_info): Add initializers and
1613         destructor.
1614         <probes_table>: Now an htab_up.
1615         (solib_svr4_pspace_data): Change type.
1616         (free_probes_table): Simplify.
1617         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1618         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1619         (probes_table_remove_objfile_probes, register_solib_event_probe)
1620         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1621         (_initialize_svr4_solib): Update.
1622
1623 2019-05-08  Tom Tromey  <tom@tromey.com>
1624
1625         * remote.c (remote_pspace_data): Change type.
1626         (remote_pspace_data_cleanup): Remove.
1627         (get_remote_exec_file, set_pspace_remote_exec_file)
1628         (_initialize_remote): Update.
1629
1630 2019-05-08  Tom Tromey  <tom@tromey.com>
1631
1632         * breakpoint.c (breakpoint_objfile_key): Change type.
1633         (get_breakpoint_objfile_data): Update.
1634         (free_breakpoint_objfile_data): Remove.
1635         (_initialize_breakpoint): Update.
1636
1637 2019-05-08  Tom Tromey  <tom@tromey.com>
1638
1639         * linux-tdep.c (struct linux_info): Add initializers.
1640         (linux_inferior_data): Move.  Change type.
1641         (invalidate_linux_cache_inf): Update.
1642         (linux_inferior_data_cleanup): Remove.
1643         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1644
1645 2019-05-08  Tom Tromey  <tom@tromey.com>
1646
1647         * auxv.c (auxv_inferior_data): Move.  Change type.
1648         (auxv_inferior_data_cleanup): Remove.
1649         (invalidate_auxv_cache_inf): Rewrite.
1650         (get_auxv_inferior_data, _initialize_auxv): Update.
1651
1652 2019-05-08  Tom Tromey  <tom@tromey.com>
1653
1654         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1655         (symfile_debug_objfile_data_key): Change type.
1656         (symfile_debug_installed, debug_qf_has_symbols)
1657         (debug_qf_find_last_source_symtab)
1658         (debug_qf_forget_cached_source_info)
1659         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1660         (debug_qf_print_stats, debug_qf_dump)
1661         (debug_qf_expand_symtabs_for_function)
1662         (debug_qf_expand_all_symtabs)
1663         (debug_qf_expand_symtabs_with_fullname)
1664         (debug_qf_map_matching_symbols)
1665         (debug_qf_expand_symtabs_matching)
1666         (debug_qf_find_pc_sect_compunit_symtab)
1667         (debug_qf_map_symbol_filenames)
1668         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1669         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1670         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1671         (debug_sym_read_linetable, debug_sym_relocate): Update.
1672         (symfile_debug_free_objfile): Remove.
1673         (install_symfile_debug_logging, _initialize_symfile_debug):
1674         Update.
1675
1676 2019-05-08  Tom Tromey  <tom@tromey.com>
1677
1678         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1679         allocate_on_obstack.
1680         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1681         (get_dwarf2_per_objfile): Update.
1682         (set_dwarf2_per_objfile): Remove.
1683         (dwarf2_has_info, dwarf2_get_section_info): Update.
1684         (dwarf2_free_objfile): Remove.
1685         (_initialize_dwarf2_read): Update.
1686
1687 2019-05-08  Tom Tromey  <tom@tromey.com>
1688
1689         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1690         initializers.
1691         <unsupported_script_warning_printed,
1692         script_not_found_warning_printed>: Now bool.
1693         (auto_load_pspace_data): Change type.
1694         (~auto_load_pspace_info): Rename from
1695         auto_load_pspace_data_cleanup.
1696         (get_auto_load_pspace_data, init_loaded_scripts_info)
1697         (clear_section_scripts, maybe_print_unsupported_script_warning)
1698         (maybe_print_script_not_found_warning, _initialize_auto_load):
1699         Update.
1700
1701 2019-05-08  Tom Tromey  <tom@tromey.com>
1702
1703         * objfiles.c (objfile_pspace_info): Add destructor and
1704         initializers.
1705         (objfiles_pspace_data): Change type.
1706         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1707         (get_objfile_pspace_data): Update.
1708         (objfiles_bfd_data): Change type.
1709         (get_objfile_bfd_data): Update.
1710         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1711
1712 2019-05-08  Tom Tromey  <tom@tromey.com>
1713
1714         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1715         Change type.
1716         (get_catch_syscall_inferior_data): Update.
1717         (catch_syscall_inferior_data_cleanup): Remove.
1718         (_initialize_break_catch_syscall): Update.
1719
1720 2019-05-08  Tom Tromey  <tom@tromey.com>
1721
1722         * inflow.c (struct terminal_info): Add destructor and
1723         initializers.
1724         (inflow_inferior_data): Change type.
1725         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1726         (get_inflow_inferior_data, inflow_inferior_exit)
1727         (swap_terminal_info, _initialize_inflow): Update.
1728
1729 2019-05-08  Tom Tromey  <tom@tromey.com>
1730
1731         * target-dcache.c (target_dcache_cleanup): Remove.
1732         (target_dcache_aspace_key): Change type.
1733         (target_dcache_init_p, target_dcache_invalidate)
1734         (target_dcache_get, target_dcache_get_or_init)
1735         (_initialize_target_dcache): Update.
1736         * dcache.h (struct dcache_deleter): New.
1737
1738 2019-05-08  Tom Tromey  <tom@tromey.com>
1739
1740         * symtab.c (struct symbol_cache): Add destructor and
1741         initializers.
1742         (symbol_cache_key): Move.  Change type.
1743         (make_symbol_cache, free_symbol_cache): Remove.
1744         (get_symbol_cache): Update.
1745         (symbol_cache_cleanup): Remove.
1746         (ALL_PSPACES, symbol_cache_flush)
1747         (maintenance_print_symbol_cache)
1748         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1749         Update.
1750
1751 2019-05-08  Tom Tromey  <tom@tromey.com>
1752
1753         * symtab.c (struct main_info): Add destructor and initializers.
1754         (main_progspace_key): Move.  Change type.
1755         (get_main_info): Update.
1756         (main_info_cleanup): Remove.
1757         (_initialize_symtab): Update.
1758
1759 2019-05-08  Tom Tromey  <tom@tromey.com>
1760
1761         * registry.h (DECLARE_REGISTRY): Define the _key class.
1762
1763 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1764
1765         * NEWS: Merge two 'New commands' sections.
1766
1767 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1768
1769         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1770         parameter and use Ada language definition instead.
1771         (ada_val_print_ptr): Remove unused language parameter.
1772         (ada_val_print_num): Remove language parameter and use Ada language
1773         definition instead.
1774         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1775         parameter.
1776         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1777         parameter and use Ada language definition instead.
1778         (ada_val_print_1): Update all ada_val_print_xxx calls.
1779         Remove language parameter.
1780         (ada_val_print): Update ada_val_print_1 call.
1781
1782 2019-05-08  Tom Tromey  <tromey@adacore.com>
1783
1784         * remote.c (remote_hw_watchpoint_limit)
1785         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1786         Now static.
1787
1788 2019-05-08  Tom Tromey  <tromey@adacore.com>
1789
1790         * maint.c (_initialize_maint_cmds): Move initialization code to
1791         remote.c.
1792         (watchdog, show_watchdog): Move to remote.c.
1793         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1794         "watchdog" static.
1795         (_initialize_remote): Move initialization code from maint.c.
1796         * defs.h (watchdog): Don't declare.
1797
1798 2019-05-08  Tom Tromey  <tromey@adacore.com>
1799
1800         * tui/tui-interp.c: Include main.h.
1801         * interps.c: Include main.h.
1802         * main.h (interpreter_p): Declare.
1803         * defs.h (interpreter_p): Don't declare.
1804
1805 2019-05-08  Tom Tromey  <tromey@adacore.com>
1806
1807         * dwarf2loc.c: Include dwarf2read.h.
1808         * defs.h (read_unsigned_leb128): Don't declare.
1809         * dwarf2read.h (read_unsigned_leb128): Declare.
1810
1811 2019-05-08  Tom Tromey  <tromey@adacore.com>
1812
1813         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1814         method.
1815
1816 2019-05-08  Tom Tromey  <tromey@adacore.com>
1817
1818         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1819         when no wrap column is set.
1820
1821 2019-05-08  Tom Tromey  <tromey@adacore.com>
1822
1823         * c-lang.c (c_get_string): Handle non-C-style arrays.
1824
1825 2019-05-08  Tom Tromey  <tromey@adacore.com>
1826
1827         * typeprint.c (print_offset_data::update): Print the bit offset,
1828         not the number of bits remaining.
1829
1830 2019-05-08  Tom Tromey  <tromey@adacore.com>
1831
1832         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1833         padding at end of comment.
1834
1835 2019-05-08  Tom Tromey  <tromey@adacore.com>
1836
1837         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1838         Compare main types.
1839
1840 2019-05-06  Tom Tromey  <tom@tromey.com>
1841
1842         * common/scoped_mmap.c: Include common-defs.h.
1843         * common/scoped_mmap.h: Don't include config.h.
1844
1845 2019-05-04  Tom Tromey  <tom@tromey.com>
1846
1847         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1848         (struct aarch64_call_info): Add initializers.
1849         <si>: Now a std::vector.
1850         (pass_on_stack, aarch64_push_dummy_call): Update.
1851
1852 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1853             Tom Tromey  <tom@tromey.com>
1854
1855         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1856         (ppc_threads): Now a std::vector.  Now static.
1857         (hwdebug_find_thread_points_by_tid)
1858         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1859         Update.
1860
1861 2019-05-04  Tom Tromey  <tom@tromey.com>
1862
1863         * arc-tdep.c (arc_tdesc_init): Return bool.
1864
1865 2019-05-04  Tom Tromey  <tom@tromey.com>
1866
1867         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1868         Use gdb_assert_not_reached.
1869
1870 2019-05-04  Tom Tromey  <tom@tromey.com>
1871
1872         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1873         "false".
1874
1875 2019-05-04  Tom Tromey  <tom@tromey.com>
1876
1877         * arc-tdep.c (arc_tdesc_init): Use bool.
1878
1879 2019-05-04  Tom Tromey  <tom@tromey.com>
1880
1881         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1882
1883 2019-05-04  Tom Tromey  <tom@tromey.com>
1884
1885         * cli/cli-cmds.c (valid_command_p): Return bool.
1886
1887 2019-05-04  Tom Tromey  <tom@tromey.com>
1888
1889         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1890         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1891
1892 2019-05-04  Raul Tambre  <raul@tambre.ee>
1893
1894         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1895         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1896         operator for comparison.
1897
1898 2019-05-04  Tom Tromey  <tom@tromey.com>
1899
1900         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1901         (lookup_partial_symbol, print_partial_symbols)
1902         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1903         (psymbol_compare): Update.
1904         (add_psymbol_to_bcache): Clear the entire psymbol.
1905         (maintenance_check_psymtabs): Update.
1906         * psympriv.h (struct partial_symbol): Don't derive from
1907         general_symbol_info.
1908         <obj_section, unrelocated_address, address,
1909         set_unrelocated_address>: Update.
1910         <ginfo>: New member.
1911         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1912         (debug_names::write_psymbols): Update.
1913
1914 2019-05-04  Tom de Vries  <tdevries@suse.de>
1915
1916         * contrib/cc-with-tweaks.sh: Support -n arg.
1917
1918 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1919
1920         * corelow.c (core_target::detach): Ensure frame cache and
1921         register caches are cleared.
1922         inferior.c (exit_inferior_1): Likewise.
1923
1924 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1925             Tom Tromey  <tom@tromey.com>
1926
1927         * dictionary.c (collate_pending_symbols_by_language): Remove
1928         "struct" from foreach.
1929         * symtab.c (lookup_global_symbol_from_objfile)
1930         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1931         foreach.
1932         * ser-tcp.c (net_open): Remove "struct" from foreach.
1933         * objfiles.c (objfile_relocate, objfile_rebase)
1934         (objfile_has_symbols): Remove "struct" from foreach.
1935         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1936         from foreach.
1937         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1938         foreach.
1939         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1940         "struct" from foreach.
1941         * ada-lang.c (create_excep_cond_exprs)
1942         (ada_exception_catchpoint_cond_string): Remove "struct" from
1943         foreach.
1944
1945 2019-05-03  Tom Tromey  <tromey@adacore.com>
1946
1947         * ada-exp.y (convert_char_literal): Check suffix of each
1948         enumerator.
1949
1950 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1951
1952         PR ada/21406:
1953         * ada-exp.y (yywrap): Don't define.
1954         * ada-lex.l (%option): Add noyywrap
1955         (yywrap): Remove.
1956
1957 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1958
1959         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1960         _WIN32_WINNT to the XP level, unless already defined to a higher
1961         level.
1962
1963         * unittests/parse-connection-spec-selftests.c:
1964         * ser-tcp.c:
1965         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1966         override.
1967
1968         * symfile.c (find_separate_debug_file): Remove colon from the
1969         drive spec of DOS/Windows file names of the target, so that the
1970         file name produced from DEBUGDIR and the target's directory will
1971         be valid on DOS/Windows systems.
1972
1973 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1974
1975         * rust-lang.c (val_print_struct): Handle printing structures
1976         containing strings.
1977
1978 2019-05-02  Tom Tromey  <tromey@adacore.com>
1979
1980         * valarith.c (_initialize_valarith): Remove.
1981
1982 2019-05-01  Tom Tromey  <tromey@adacore.com>
1983
1984         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1985         bitfields.
1986
1987 2019-05-01  Tom Tromey  <tromey@adacore.com>
1988
1989         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1990         for big-endian copies.
1991
1992 2019-04-30  Ali Tamur  <tamur@google.com>
1993         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1994         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1995         (read_3_bytes): New function.
1996
1997 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1998
1999         * windows-nat.c (main_thread_id): Delete.
2000         (handle_output_debug_string): Replace main_thread_id by
2001         current_event.dwThreadId.
2002         (fake_create_process): Likewise.
2003         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2004         Do not set main_thread_id.
2005         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2006         current_event.dwThreadId.
2007         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2008
2009 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2010
2011         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2012         Use current_event.dwThreadId instead of main_thread_id.
2013
2014 2019-04-30  Tom Tromey  <tromey@adacore.com>
2015
2016         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2017         (create_excep_cond_exprs): Iterate over program spaces.
2018         (ada_exception_catchpoint_cond_string): Examine all minimal
2019         symbols for exception types.
2020
2021 2019-04-30  Tom Tromey  <tromey@adacore.com>
2022
2023         PR c++/24470:
2024         * dwarf2read.c (process_structure_scope): Handle case where type
2025         has template parameters but no symbol was created.
2026
2027 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2028             Chris January  <chris.january@arm.com>
2029
2030         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2031         qualifier.
2032         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2033
2034 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * f-typeprint.c (f_print_type): Update rules for printing
2037         whitespace.
2038         (f_type_print_varspec_suffix): Likewise.
2039
2040 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2041             Chris January  <chris.january@arm.com>
2042
2043         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2044         function arguments.
2045
2046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * f-lang.c (build_fortran_types): Change name of void type to
2049         lower case.
2050         * f-typeprint.c (f_type_print_base): Print the name of the void
2051         type, rather than a fixed string.
2052         * f-valprint.c (f_decorations): Use lower case void string.
2053
2054 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2055             Chris January  <chris.january@arm.com>
2056
2057         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2058         types for Fortran.
2059
2060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2061             Chris January  <chris.january@arm.com>
2062             David Lecomber  <david.lecomber@arm.com>
2063
2064         * f-exp.y (BINOP_INTRINSIC): New token.
2065         (exp): New parser rule handling BINOP_INTRINSIC.
2066         (f77_keywords): Add new builtin procedures.
2067         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2068         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2069         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2070         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2071         (print_unop_subexp_f): New function.
2072         (print_binop_subexp_f): New function.
2073         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2074         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2075         (dump_subexp_body_f): Likewise.
2076         (operator_check_f): Likewise.
2077         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2078         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2079
2080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2081
2082         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2083         UNOP_KIND.
2084         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2085         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2086         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2087         (operator_length_f): New fuction.
2088         (print_subexp_f): New function.
2089         (op_name_f): New function.
2090         (dump_subexp_body_f): New function.
2091         (operator_check_f): New function.
2092         (exp_descriptor_f): Replace standard expression handling functions
2093         with new functions.
2094         * gdb/fortran-operator.def: New file.
2095         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2096         * gdb/std-operator.def: Remove UNOP_KIND.
2097
2098 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2099
2100         * std-operator.def: Remove unbalanced, stray double quote
2101         character.
2102
2103 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2104             Chris January  <chris.january@arm.com>
2105             Daniel Everett  <daniel.everett@arm.com>
2106             Nick Forrington  <nick.forrington@arm.com>
2107             Richard Bunt  <richard.bunt@arm.com>
2108
2109         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2110         of depth when printing anonymous structs or unions.
2111         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2112         Don't print either the top-level value, or the children if the
2113         max-depth is exceeded.
2114         (ppscm_print_children): When printing the key of a map, allow one
2115         extra level of depth.
2116         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2117         print either the top-level value, or the children if the max-depth
2118         is exceeded.
2119         (print_children): When printing the key of a map, allow one extra
2120         level of depth.
2121         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2122         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2123         (user_print_options): Initialise max_depth field.
2124         (val_print_scalar_or_string_type_p): New function.
2125         (val_print): Check to see if the max depth has been reached.
2126         (val_print_check_max_depth): Define new function.
2127         (show_print_max_depth): New function.
2128         (_initialize_valprint): Add 'print max-depth' option.
2129         * valprint.h (struct value_print_options) <max_depth>: New field.
2130         (val_print_check_max_depth): Declare new function.
2131         * NEWS: Document new feature.
2132
2133 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * ada-lang.c (ada_language_defn): Initialise new field.
2136         * c-lang.c (c_is_string_type_p): New function.
2137         (c_language_defn): Initialise new field.
2138         (cplus_language_defn): Initialise new field.
2139         (asm_language_defn): Initialise new field.
2140         (minimal_language_defn): Initialise new field.
2141         * c-lang.h (c_is_string_type_p): Declare new function.
2142         * d-lang.c (d_language_defn): Initialise new field.
2143         * f-lang.c (f_is_string_type_p): New function.
2144         (f_language_defn): Initialise new field.
2145         * go-lang.c (go_is_string_type_p): New function.
2146         (go_language_defn): Initialise new field.
2147         * language.c (default_is_string_type_p): New function.
2148         (unknown_language_defn): Initialise new field.
2149         (auto_language_defn): Initialise new field.
2150         * language.h (struct language_defn) <la_is_string_type_p>: New
2151         member variable.
2152         (default_is_string_type_p): Declare new function.
2153         * m2-lang.c (m2_language_defn): Initialise new field.
2154         * objc-lang.c (objc_language_defn): Initialise new field.
2155         * opencl-lang.c (opencl_language_defn): Initialise new field.
2156         * p-lang.c (pascal_is_string_type_p): New function.
2157         (pascal_language_defn): Initialise new field.
2158         * rust-lang.c (rust_is_string_type_p): New function.
2159         (rust_language_defn): Initialise new field.
2160
2161 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2164         New field.
2165         * ada-lang.c (ada_language_defn): Initialise new field.
2166         * c-lang.c (c_language_defn): Likewise.
2167         (cplus_language_defn): Likewise.
2168         (asm_language_defn): Likewise.
2169         (minimal_language_defn): Likewise.
2170         * d-lang.c (d_language_defn): Likewise.
2171         * f-lang.c (f_language_defn): Likewise.
2172         * go-lang.c (go_language_defn): Likewise.
2173         * language.c (unknown_language_defn): Likewise.
2174         (auto_language_defn): Likewise.
2175         * m2-lang.c (m2_language_defn): Likewise.
2176         * objc-lang.c (objc_language_defn): Likewise.
2177         * opencl-lang.c (opencl_language_defn): Likewise.
2178         * p-lang.c (pascal_language_defn): Likewise.
2179         * rust-lang.c (rust_language_defn): Likewise.
2180
2181 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * ada-lang.c (ada_is_character_type): Change return type to bool.
2184         (ada_is_string_type): Likewise.
2185         * ada-lang.h (ada_is_character_type): Update declaration
2186         (ada_is_string_type): Likewise.
2187
2188 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2189
2190         Support style in 'frame|thread apply'
2191
2192         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2193         * record.c (record_start, record_stop): Update callers of
2194         execute_command_to_string with false.
2195         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2196         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2197         methods.
2198         (class string_file): New constructor with term_out parameter.
2199         Override methods term_out and can_emit_style_escape.  New member
2200         term_out.
2201         (class stdio_file): Override can_emit_style_escape.
2202         (class tee_file): Override term_out and can_emit_style_escape.
2203         * utils.h (can_emit_style_escape): Remove.
2204         * utils.c (can_emit_style_escape): Likewise.
2205         Update all callers of can_emit_style_escape (SOMESTREAM) to
2206         SOMESTREAM->can_emit_style_escape.
2207         * source-cache.c (source_cache::get_source_lines): Likewise.
2208         * stack.c (frame_apply_command_count): Call execute_command_to_string
2209         passing the term_out characteristic of the current gdb_stdout.
2210         * thread.c (thr_try_catch_cmd): Likewise.
2211         * top.c (execute_command_to_string): pass term_out parameter
2212         to construct the string_file for the command output.
2213         * ui-file.c (term_cli_styling): New function (most code moved
2214         from utils.c can_emit_style_escape).
2215         (string_file::string_file, string_file::can_emit_style_escape,
2216         stdio_file::can_emit_style_escape, tee_file::term_out,
2217         tee_file::can_emit_style_escape): New functions.
2218
2219 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2220
2221         * NEWS: Mention the new set|show may-call-functions.
2222         * infcall.c (may_call_functions_p): New variable.
2223         (show_may_call_functions_p): New function.
2224         (call_function_by_hand_dummy): Throws an error if not
2225         may-call-functions.
2226         (_initialize_infcall): Call add_setshow_boolean_cmd for
2227         may-call-functions.
2228
2229 2019-04-25  Keith Seitz  <keiths@redhat.com>
2230
2231         PR c++/24367
2232         * cp-support.c (inspect_type): Don't attempt substitutions
2233         of symbol with the same name.
2234
2235 2019-04-25  Tom Tromey  <tromey@adacore.com>
2236
2237         PR gdb/24475:
2238         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2239         static.
2240
2241 2019-04-25  Tom Tromey  <tromey@adacore.com>
2242
2243         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2244         rvalue reference.
2245         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2246         (gdb_xml_parser::parse): Use std::move.
2247         * python/python-internal.h (gdbpy_convert_exception): Take a const
2248         reference.
2249         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2250         std::move.
2251         * python/py-utils.c (gdbpy_convert_exception): Take a const
2252         reference.
2253         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2254         Use std::move.
2255         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2256         Use std::move.
2257         * mi/mi-main.c (mi_print_exception): Take a const reference.
2258         * main.c (handle_command_errors): Take a const reference.
2259         * linespec.c (parse_linespec): Use std::move.
2260         * infcall.c (run_inferior_call): Use std::move.
2261         (call_function_by_hand_dummy): Use std::move.
2262         * exec.c (try_open_exec_file): Use std::move.
2263         * exceptions.h (exception_print, exception_fprintf)
2264         (exception_print_same): Update.
2265         * exceptions.c (print_exception, exception_print)
2266         (exception_fprintf, exception_print_same): Change parameters to
2267         const reference.
2268         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2269         * common/new-op.c: Use std::move.
2270         * common/common-exceptions.h (struct gdb_exception): Add move
2271         constructor.
2272         (struct gdb_exception_error, struct gdb_exception_quit, struct
2273         gdb_quit_bad_alloc): Change constructor to move constructor.
2274         (throw_exception): Change parameter to rvalue reference.
2275         * common/common-exceptions.c (throw_exception): Take rvalue
2276         reference.
2277         * cli/cli-interp.c (safe_execute_command): Use std::move.
2278         * breakpoint.c (insert_bp_location, location_to_sals): Use
2279         std::move.
2280
2281 2019-04-25  Tom Tromey  <tromey@adacore.com>
2282
2283         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2284         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2285         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2286         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2287         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2288         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2289         guile/scm-value.c: Use unpack.
2290         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2291         gdbscm_gdb_exception.
2292         (gdbscm_throw_gdb_exception): Likewise.
2293         (struct gdbscm_gdb_exception): New.
2294         (unpack): New function.
2295         (gdbscm_wrap): Use unpack.
2296
2297 2019-04-25  Tom Tromey  <tromey@adacore.com>
2298
2299         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2300         (gdb_rl_callback_handler): Use std::move.
2301         * common/common-exceptions.h (struct gdb_exception): Add move
2302         assignment operator.
2303         (throw_exception_sjlj): Change "exception" to const reference.
2304         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2305         (throw_exception_sjlj): Change "exception" to const reference.
2306
2307 2019-04-25  Tom Tromey  <tromey@adacore.com>
2308
2309         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2310         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2311         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2312         Update.
2313         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2314         Update.
2315         * mi/mi-interp.c (mi_interp::exec): Update.
2316         * linespec.c (parse_linespec): Update.
2317         * infcall.c (run_inferior_call): Update.
2318         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2319         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2320         (gdbscm_lookup_global_symbol): Update.
2321         * guile/scm-param.c (gdbscm_parameter_value): Update.
2322         * guile/scm-frame.c (gdbscm_frame_read_register)
2323         (gdbscm_frame_read_var): Update.
2324         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2325         * exec.c (try_open_exec_file): Update.
2326         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2327         (gdb_rl_callback_handler): Update.
2328         * common/common-exceptions.h (exception_none): Don't declare.
2329         * common/common-exceptions.c (exception_none): Don't define.
2330         (struct catcher) <exception>: Update.
2331         * cli/cli-interp.c (safe_execute_command): Update.
2332         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2333
2334 2019-04-25  Ali Tamur  <tamur@google.com>
2335
2336         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2337         (read_attribute_value): Likewise.
2338         (dwarf2_read_addr_index): Update comment.
2339         (read_str_index): Add DW_FORM_strx.
2340         (dwarf2_string_attr): Likewise.
2341         (dwarf2_const_value_attr): Likewise.
2342         (dump_die_shallow): Likewise.
2343         (dwarf2_fetch_constant_bytes): Likewise.
2344         (skip_form_bytes): Likewise.
2345         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2346
2347 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2348
2349         PR corefiles/11608
2350         PR corefiles/18187
2351         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2352         OFFSET.  Verify if current mapping contains an ELF header.
2353         (linux_find_memory_regions_full): Adjust call to
2354         dump_mapping_p.
2355
2356 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2357             Kang Li <kanglictf@gmail.com>
2358
2359         PR gdb/21600
2360
2361         * dwarf2-frame.c (read_initial_length): Be consistent about using
2362         unsigned representation of length.
2363         (decode_frame_entry_1): Likewise.  Check for wraparound of
2364         end pointer as well as buffer overflow.
2365
2366 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2367
2368         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2369         "vq".
2370
2371 2019-04-24  Tom Tromey  <tromey@adacore.com>
2372
2373         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2374
2375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         * s12z-tdep.c (s12z_unwind_pc): Delete.
2378         (s12z_unwind_sp): Delete.
2379         (s12z_gdbarch_init): Don't register deleted functions with
2380         gdbarch.
2381
2382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * rl78-tdep.c (rl78_unwind_sp): Delete.
2385         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2386
2387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2390         (xstormy16_unwind_pc): Delete.
2391         (xstormy16_dummy_id): Delete.
2392         (xstormy16_gdbarch_init): Don't register deleted functions with
2393         gdbarch.
2394
2395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * vax-tdep.c (vax_unwind_pc): Delete.
2398         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2399
2400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * v850-tdep.c (v850_unwind_sp): Delete.
2403         (v850_unwind_pc): Delete.
2404         (v850_dummy_id): Delete.
2405         (v850_gdbarch_init): Don't register deleted functions with
2406         gdbarch.
2407
2408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2411         (tilegx_unwind_pc): Delete.
2412         (tilegx_unwind_dummy_id): Delete.
2413         (tilegx_gdbarch_init): Don't register deleted functions with
2414         gdbarch.
2415
2416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2419         (tic6x_dummy_id): Delete.
2420         (tic6x_gdbarch_init): Don't register deleted functions with
2421         gdbarch.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * sparc-tdep.c (sparc_unwind_pc): Delete.
2426         (sparc32_gdbarch_init): Don't register deleted function with
2427         gdbarch.
2428
2429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * sh-tdep.c (sh_unwind_sp): Delete.
2432         (sh_unwind_pc): Delete.
2433         (sh_dummy_id): Delete.
2434         (sh_gdbarch_init): Don't register deleted functions with
2435         gdbarch.
2436
2437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * score-tdep.c (score_unwind_sp): Delete.
2440         (score_unwind_pc): Delete.
2441         (score_dummy_id): Delete.
2442         (score_gdbarch_init): Don't register deleted functions with
2443         gdbarch.
2444
2445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2446
2447         * rx-tdep.c (rx_unwind_pc): Delete.
2448         (rx_unwind_sp): Delete.
2449         (rx_dummy_id): Delete.
2450         (rx_gdbarch_init): Don't register deleted functions with
2451         gdbarch.  Update comment.
2452
2453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2456         (rs6000_dummy_id): Delete.
2457         (rs6000_gdbarch_init): Don't register deleted functions with
2458         gdbarch.
2459
2460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2461
2462         * or1k-tdep.c (or1k_dummy_id): Delete.
2463         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2464
2465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * nios2-tdep.c (nios2_dummy_id): Delete.
2468         (nios2_unwind_sp): Delete.
2469         (nios2_gdbarch_init): Don't register deleted functions with
2470         gdbarch.
2471
2472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2473
2474         * nds32-tdep.c (nds32_dummy_id): Delete.
2475         (nds32_unwind_pc): Delete.
2476         (nds32_unwind_sp): Delete.
2477         (nds32_gdbarch_init): Don't register deleted functions with
2478         gdbarch.
2479
2480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * msp430-tdep.c (msp430_unwind_pc): Delete.
2483         (msp430_unwind_sp): Delete.
2484         (msp430_dummy_id): Delete.
2485         (msp430_gdbarch_init): Don't register deleted functions with
2486         gdbarch.
2487
2488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2489
2490         * moxie-tdep.c (moxie_unwind_sp): Delete.
2491         (moxie_unwind_pc): Delete.
2492         (moxie_dummy_id): Delete.
2493         (moxie_gdbarch_init): Don't register deleted functions with
2494         gdbarch.
2495
2496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2497
2498         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2499         (mn10300_unwind_pc): Delete.
2500         (mn10300_unwind_sp): Delete.
2501         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2502         mn10300_unwind_sp.
2503         (mn10300_frame_unwind_init): Don't register deleted functions with
2504         gdbarch.
2505
2506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * mep-tdep.c (mep_unwind_pc): Delete.
2509         (mep_unwind_sp): Delete.
2510         (mep_dummy_id): Delete.
2511         (mep_gdbarch_init): Don't register deleted functions with
2512         gdbarch.
2513
2514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2517         (m68hc11_unwind_sp): Delete.
2518         (m68hc11_gdbarch_init): Don't register deleted functions with
2519         gdbarch.
2520
2521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * m32r-tdep.c (m32r_unwind_sp): Delete.
2524         (m32r_unwind_pc): Delete.
2525         (m32r_dummy_id): Delete.
2526         (m32r_gdbarch_init): Don't register deleted functions with
2527         gdbarch.
2528
2529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * m32c-tdep.c (m32c_unwind_pc): Delete.
2532         (m32c_unwind_sp): Delete.
2533         (m32c_dummy_id): Delete.
2534         (m32c_gdbarch_init): Don't register deleted functions with
2535         gdbarch.
2536
2537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2540         (lm32_unwind_pc): Delete.
2541         (lm32_dummy_id): Delete.
2542         (lm32_gdbarch_init): Don't register deleted functions with
2543         gdbarch.
2544
2545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2548         (iq2000_unwind_pc): Delete.
2549         (iq2000_dummy_id): Delete.
2550         (iq2000_gdbarch_init): Don't register deleted functions with
2551         gdbarch.
2552
2553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2554
2555         * nds32-tdep.c (nds32_type_align): Delete.
2556         (nds32_push_dummy_call): Use type_align instead.
2557
2558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2559
2560         * arm-tdep.c (arm_type_align): Only handle vector override case.
2561         (arm_push_dummy_call): Use type_align.
2562         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2563
2564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2567         case.
2568         (pass_on_stack): Use type_align.
2569         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2570         function.
2571
2572 2019-04-23  Tom Tromey  <tromey@adacore.com>
2573
2574         * dwarf2read.c (line_header::file_name_at): Remove unused
2575         overload.
2576
2577 2019-04-23  Tom de Vries  <tdevries@suse.de>
2578
2579         PR gdb/24438
2580         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2581         invocation.
2582
2583
2584 2019-03-27  Ali Tamur  <tamur@google.com>
2585
2586         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2587         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2588         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2589         (dwarf_expr_context::get_addr_index): Likewise
2590         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2591         (symbol_needs_eval_context::get_addr_index): Likewise
2592         (disassemble_dwarf_expression): Add DW_OP_addrx
2593         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2594         (read_cutu_die_from_dwo): Update comment
2595         (skip_one_die): Add DW_FORM_addrx
2596         (read_attribute_value): Likewise
2597         (var_decode_location): Add DW_OP_addrx
2598         (dwarf2_const_value_attr): Add DW_FORM_addrx
2599         (dump_die_shallow): Likewise
2600         (dwarf2_fetch_constant_bytes): Likewise
2601         (decode_locdesc): Add DW_OP_addrx
2602         (skip_form_bytes): Add DW_FORM_addrx
2603
2604 2019-04-22  Ali Tamur  <tamur@google.com>
2605
2606         * MAINTAINERS (Write After Approval): Add self.
2607
2608 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2609
2610         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2611         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2612         (open_symbol_file_object): Likewise.
2613         (svr4_default_sos): Add info parameter.
2614         (svr4_read_so_list): Likewise.
2615         (svr4_current_sos_direct): Adjust functions calls to pass down
2616         info.
2617         (svr4_current_sos_1): Add info parameter.
2618         (svr4_current_sos): Call get_svr4_info, pass info down to
2619         svr4_current_sos_1.
2620         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2621         get_svr4_info.
2622         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2623         get_svr4_info.
2624         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2625         to get_svr4_info.
2626         (probes_table_remove_objfile_probes): Likewise.
2627         (register_solib_event_probe): Add info parameter.
2628         (solist_update_incremental): Pass info parameter down to
2629         svr4_read_so_list.
2630         (disable_probes_interface): Add info parameter.
2631         (svr4_handle_solib_event): Pass current_program_space to
2632         get_svr4_info.  Adjust disable_probes_interface cleanup.
2633         (svr4_create_probe_breakpoints): Add info parameter, pass it
2634         down to register_solib_event_probe.
2635         (svr4_create_solib_event_breakpoints): Add info parameter,
2636         pass it down to svr4_create_probe_breakpoints.
2637         (enable_break): Pass info down to
2638         svr4_create_solib_event_breakpoints.
2639         (svr4_solib_create_inferior_hook): Pass current_program_space to
2640         get_svr4_info.
2641         (svr4_clear_solib): Likewise.
2642
2643 2019-04-22  Pedro Alves  <palves@redhat.com>
2644
2645         * solib-svr4.c (svr4_free_objfile_observer): New.
2646         (probe_and_action::objfile): New field.
2647         (probes_table_htab_remove_objfile_probes)
2648         (probes_table_remove_objfile_probes): New functions.
2649         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2650         in the new probe_and_action.  Don't store the probe in 'lookup'.
2651         (svr4_create_probe_breakpoints): Pass objfile to
2652         register_solib_event_probe.
2653         (_initialize_svr4_solib): Register a free_objfile observer.
2654
2655 2019-04-19  Tom Tromey  <tom@tromey.com>
2656
2657         * common/queue.h: Remove.
2658
2659 2019-04-19  Tom Tromey  <tom@tromey.com>
2660
2661         * event-loop.c: Don't include "common/queue.h".
2662
2663 2019-04-19  Tom Tromey  <tom@tromey.com>
2664
2665         * remote.c (remote_target): Use delete.
2666         * remote-notif.h: Include <list>, not "common/queue.h".
2667         (notif_client_p): Remove typedef.
2668         (remote_notif_state): Add constructor, destructor, initializer.
2669         <notif_queue>: Now a std::list.
2670         (remote_notif_state_xfree): Don't declare.
2671         * remote-notif.c (remote_notif_process, handle_notification)
2672         (remote_notif_state_allocate): Update.
2673         (~remote_notif_state): Rename from remote_notif_state_xfree.
2674
2675 2019-04-19  Tom Tromey  <tom@tromey.com>
2676
2677         * symfile.c (reread_symbols): Update.
2678         * objfiles.c (objfile_register_static_link)
2679         (objfile_lookup_static_link): Update
2680         (~objfile) Don't delete static_links.
2681         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2682
2683 2019-04-19  Tom Tromey  <tom@tromey.com>
2684
2685         * type-stack.h (struct type_stack) <insert>: Constify string.
2686         * type-stack.c (type_stack::insert): Constify string.
2687         * gdbtypes.h (lookup_template_type): Update.
2688         (address_space_name_to_int): Update.
2689         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2690         const.
2691         (lookup_template_type): Make name const.
2692         * c-exp.y: Update rules.
2693         (lex_one_token, classify_name, classify_inner_name)
2694         (c_print_token): Update.
2695         * p-exp.y: Update rules.
2696         (yylex): Update.
2697         * f-exp.y: Update rules.
2698         (yylex): Update.
2699         * d-exp.y: Update rules.
2700         (lex_one_token, classify_name, classify_inner_name): Update.
2701         * parse.c (write_dollar_variable, copy_name): Return std::string.
2702         * parser-defs.h (copy_name): Change return type.
2703         * m2-exp.y: Update rules.
2704         (yylex): Update.
2705         * go-exp.y (lex_one_token): Update.
2706         Update rules.
2707         (classify_unsafe_function, classify_packaged_name)
2708         (classify_name, yylex): Update.
2709
2710 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2711
2712         * configure.ac: add --enable-source-highlight switch.
2713         * configure: Regenerate.
2714         * top.c (print_gdb_version): plumb --enable-source-highlight
2715         status to "show configuration".
2716
2717 2019-04-19  Tom Tromey  <tromey@adacore.com>
2718
2719         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2720         Check ADA_TYPE_P.
2721         (empty_record, ada_template_to_fixed_record_type_1)
2722         (template_to_static_fixed_type)
2723         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2724         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2725         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2726         macros.
2727
2728 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2729
2730         PR symtab/24423:
2731         * source.c (print_source_lines_base): Advance "iter" when a
2732         control character is seen.
2733
2734 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2735
2736         * inferior.h (struct infcall_suspend_state_deleter):
2737         Catch exception in destructor to avoid crash.
2738
2739 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2740
2741         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2742         close to the add_com "shell".
2743
2744 2019-04-18  Tom Tromey  <tromey@adacore.com>
2745
2746         * process-stratum-target.h (class process_stratum_target)
2747         <stratum>: Add "final".
2748
2749 2019-04-17  Tom Tromey  <tromey@adacore.com>
2750
2751         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2752         against nullptr before use.
2753
2754 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2755
2756         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2757
2758 2019-04-17  Jim Wilson  <jimw@sifive.com>
2759             Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2762         code read might fail, assume 4-byte breakpoint in that case.
2763
2764 2019-04-15  Leszek Swirski  <leszeks@google.com>
2765
2766         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2767         rather than a hand-rolled POD check when checking for forced MEMORY
2768         classification.
2769
2770 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2771
2772         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2773         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2774         function.
2775         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2776         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2777         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2778         declaration.
2779
2780 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2781
2782         * aarch64-linux-nat.c
2783         (aarch64_linux_nat_target::thread_architecture): Add override.
2784         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2785         each VQ.
2786
2787 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2788
2789         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2790
2791 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2794         target types of size 96-bits, add some additional comments, and
2795         check that the builtin type we found was the correct size.
2796
2797 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2798
2799         * utils.c (prompt_for_continue): Don't restore the styling at the
2800         end, as applied_style has the wrong value.  This fixes styling in
2801         long lists of file names that are interrupted by the "Continue?"
2802         prompt.
2803
2804 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2807         * c-lang.c (c_language_defn): Likewise.
2808         (cplus_language_defn): Likewise.
2809         (asm_language_defn): Likewise.
2810         (minimal_language_defn): Likewise.
2811         * d-lang.c (d_language_defn): Likewise.
2812         * f-lang.c (f_language_defn): Likewise.
2813         * go-lang.c (go_language_defn): Likewise.
2814         * language.c (unknown_language_defn): Likewise.
2815         (auto_language_defn): Likewise.
2816         * language.h (struct language_defn): Remove la_magic field.
2817         (LANG_MAGIC): Delete.
2818         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2819         * objc-lang.c (objc_language_defn): Likewise.
2820         * opencl-lang.c (opencl_language_defn): Likewise.
2821         * p-lang.c (pascal_language_defn): Likewise.
2822         * rust-lang.c (rust_language_defn): Likewise.
2823
2824 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * riscv-tdep.c (riscv_type_align): New function.
2827         (riscv_type_alignment): Delete.
2828         (riscv_arg_location): Use 'type_align'.
2829         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2830
2831 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * gdbtypes.c (type_align): A struct with no non-static fields also
2834         has alignment of 1.
2835
2836 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2839         component to 0.
2840         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2841         member.
2842         (riscv_struct_info::analyse): New implementation using new
2843         analyse_inner member function.
2844         (riscv_struct_info::field_offset): New member function.
2845         (riscv_struct_info::m_offsets): New member variable.
2846         (riscv_struct_info::analyse_inner): New private member function,
2847         takes the old implementation of riscv_struct_info::analyse but
2848         extended to track field offsets.
2849         (riscv_call_arg_struct): Update the struct folding special cases
2850         to handle cases where empty C++ structs, which are non-zero
2851         length, are found.
2852         (riscv_arg_location): Initialise the length of each location, a
2853         non-zero length now indicates the location is in use.
2854         (riscv_push_dummy_call): Allow for the first location having a
2855         non-zero offset when setting up arguments.
2856         (riscv_return_value): Likewise, but for return values.
2857
2858 2019-04-11  Tom Tromey  <tromey@adacore.com>
2859
2860         * utils.c (internal_vproblem): Make "msg" const.
2861
2862 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2863
2864         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2865         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2866         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2867         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2868
2869 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2870
2871         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2872         function.
2873         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2874         of amd64_collect_native_gregset.
2875         (amd64_linux_nat_target::store_registers): Likewise.
2876
2877 2019-04-10  Tom Tromey  <tom@tromey.com>
2878
2879         * symtab.c (lookup_global_symbol_from_objfile)
2880         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2881         * objfiles.h (class separate_debug_iterator): New.
2882         (class separate_debug_range): New.
2883         (struct objfile) <separate_debug_objfiles>: New method.
2884         (objfile_separate_debug_iterate): Don't declare.
2885         * objfiles.c (separate_debug_iterator::operator++): Rename from
2886         objfile_separate_debug_iterate.
2887         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2888         iterator.
2889         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2890         iterator.
2891
2892 2019-04-10  Tom Tromey  <tom@tromey.com>
2893
2894         * symfile.c (reread_symbols): Remove old comment.
2895         * objfiles.c (free_all_objfiles): Fix a typo.
2896
2897 2019-04-10  Tom Tromey  <tom@tromey.com>
2898
2899         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2900         * minsyms.c (lookup_minimal_symbol): Use foreach.
2901         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2902         (lookup_minimal_symbol_solib_trampoline): Likewise.
2903         * symfile.c (reread_symbols): Use foreach.
2904
2905 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2906             Tom Tromey  <tromey@adacore.com>
2907
2908         PR rust/24414:
2909         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2910         (rust_lex_int_test): Change "value" to be LONGEST.
2911         (rust_lex_tests): Add test for long integer literal.
2912
2913 2019-04-09  Tom Tromey  <tromey@adacore.com>
2914
2915         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2916         to bool.
2917         (extended_remote_target::attach): Update.
2918         (remote_target::remote_notice_new_inferior): Update.
2919         (remote_target::add_current_inferior_and_thread): Update.
2920         * inferior.c (exit_inferior_1): Use "false".
2921         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2922
2923 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2924
2925         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2926         the "start" command.
2927
2928 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2929
2930         * python/py-inferior.c (infpy_thread_from_thread_handle):
2931         Adjust comments to reflect renaming of thread_from_thread_handle
2932         to thread_from_handle.  Adjust keywords.  Fix type error message.
2933         (inferior_object_methods): Add thread_from_handle.  Retain
2934         thread_from_thread_handle, but mark it as deprecated.
2935
2936 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2937
2938         * gdbthread.h (find_thread_by_handle): Revise declaration.
2939         * thread.c (find_thread_by_handle): Likewise.  Adjust
2940         implementation too.
2941         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2942         support for buffer objects as handles.
2943
2944 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2945
2946         * python/py-infthread.c (thpy_thread_handle): New function.
2947         (thread_object_methods): Register thpy_thread_handle.
2948
2949 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2950
2951         * gdbthread.h (thread_to_thread_handle): Declare.
2952         * thread.c (gdbtypes.h): Include.
2953         (thread_to_thread_handle): New function.
2954
2955         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2956         (target_thread_info_to_thread_handle): Declare.
2957         * target.c (target_thread_info_to_thread_handle): New function.
2958         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2959         * target-delegates.c: Regenerate.
2960
2961         * linux-thread-db.c (class thread_db_target): Add method
2962         thread_info_to_thread_handle.
2963         (thread_db_target::thread_info_to_thread_handle): Define.
2964         * remote.c (class remote_target): Add new method
2965         thread_info_to_thread_handle.
2966         (remote_target::thread_info_to_thread_handle): Define.
2967
2968 2019-04-08  Pedro Alves  <palves@redhat.com>
2969
2970         * common/common-exceptions.c (throw_exception): Don't create
2971         named object to throw; throw directly.
2972         (throw_it): Likewise.  Don't initialize gdb_exception::message
2973         here, with new; pass FMT and AP to the ctor instead.
2974         * common/common-exceptions.h: Include <string>.
2975         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2976         const char *, va_list)): New ctor.  Use std::make_shared.
2977         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2978         errors)): Delete.
2979         (gdb_exception_error::gdb_exception_error(enum errors, const char
2980         *, va_list)): New.
2981         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2982         Add assertion.
2983         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2984         errors)): Delete.
2985         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2986         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2987         Add assertion.
2988
2989 2019-04-08  Tom Tromey  <tom@tromey.com>
2990
2991         * valops.c (value_rtti_indirect_type): Replace throw_exception
2992         with throw.
2993         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2994         with throw.
2995         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2996         throw.
2997         * target.c (target_translate_tls_address): Replace throw_exception
2998         with throw.
2999         * stack.c (frame_apply_command_count): Replace throw_exception
3000         with throw.
3001         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3002         throw.
3003         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3004         with throw.
3005         * rs6000-tdep.c (rs6000_frame_cache)
3006         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3007         * remote.c: Replace throw_exception with throw.
3008         * record-full.c (record_full_message, record_full_wait_1)
3009         (record_full_restore): Replace throw_exception with throw.
3010         * record-btrace.c:
3011         (get_thread_current_frame_id, record_btrace_start_replaying)
3012         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3013         (cmd_record_btrace_start): Replace throw_exception with throw.
3014         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3015         throw.
3016         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3017         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3018         * linespec.c:
3019         (find_linespec_symbols): Replace throw_exception with throw.
3020         * infrun.c (displaced_step_prepare, resume): Replace
3021         throw_exception with throw.
3022         * infcmd.c (post_create_inferior): Replace throw_exception with
3023         throw.
3024         * inf-loop.c (inferior_event_handler): Replace throw_exception
3025         with throw.
3026         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3027         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3028         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3029         (get_prev_frame_always, get_frame_pc_if_available)
3030         (get_frame_address_in_block_if_available, get_frame_language):
3031         Replace throw_exception with throw.
3032         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3033         throw_exception with throw.
3034         * eval.c (fetch_subexp_value, evaluate_var_value)
3035         (evaluate_funcall, evaluate_subexp_standard): Replace
3036         throw_exception with throw.
3037         * dwarf2loc.c (call_site_find_chain)
3038         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3039         Replace throw_exception with throw.
3040         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3041         with throw.
3042         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3043         throw.
3044         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3045         * completer.c (complete_line_internal): Replace throw_exception
3046         with throw.
3047         * compile/compile-object-run.c (compile_object_run): Replace
3048         throw_exception with throw.
3049         * cli/cli-script.c (process_next_line): Replace throw_exception
3050         with throw.
3051         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3052         (btrace_enable, btrace_maint_update_pt_packets): Replace
3053         throw_exception with throw.
3054         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3055         throw_exception with throw.
3056         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3057         throw_exception with throw.
3058         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3059         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3060         * aarch64-tdep.c (aarch64_make_prologue_cache)
3061         (aarch64_make_stub_cache): Replace throw_exception with throw.
3062
3063 2019-04-08  Tom Tromey  <tom@tromey.com>
3064
3065         * common/common-exceptions.c (throw_exception): Rename from
3066         throw_exception_cxx.  Remove old copy.  Make argument const.
3067         (throw_it): Create and throw exception objects directly.
3068         * common/common-exceptions.h (throw_exception): Make argument
3069         const.
3070         (struct gdb_exception_error): Add constructor.
3071         (struct gdb_exception_quit): Add constructor.
3072
3073 2019-04-08  Tom Tromey  <tom@tromey.com>
3074
3075         * common/common-exceptions.h (exception_rethrow): Don't declare.
3076         (TRY_SJLJ): Update comment.
3077         (TRY, CATCH, END_CATCH): Remove.
3078         * common/common-exceptions.c (exception_rethrow): Remove.
3079
3080 2019-04-08  Tom Tromey  <tom@tromey.com>
3081
3082         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3083         Remove.
3084         (gdb_exception_error): Rename from
3085         gdb_exception_RETURN_MASK_ERROR.
3086         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3087         (gdb_quit_bad_alloc): Update.
3088         * aarch64-tdep.c: Update.
3089         * ada-lang.c: Update.
3090         * ada-typeprint.c: Update.
3091         * ada-valprint.c: Update.
3092         * amd64-tdep.c: Update.
3093         * arch-utils.c: Update.
3094         * break-catch-throw.c: Update.
3095         * breakpoint.c: Update.
3096         * btrace.c: Update.
3097         * c-varobj.c: Update.
3098         * cli/cli-cmds.c: Update.
3099         * cli/cli-interp.c: Update.
3100         * cli/cli-script.c: Update.
3101         * common/common-exceptions.c: Update.
3102         * common/new-op.c: Update.
3103         * common/selftest.c: Update.
3104         * compile/compile-c-symbols.c: Update.
3105         * compile/compile-cplus-symbols.c: Update.
3106         * compile/compile-object-load.c: Update.
3107         * compile/compile-object-run.c: Update.
3108         * completer.c: Update.
3109         * corelow.c: Update.
3110         * cp-abi.c: Update.
3111         * cp-support.c: Update.
3112         * cp-valprint.c: Update.
3113         * darwin-nat.c: Update.
3114         * disasm-selftests.c: Update.
3115         * dtrace-probe.c: Update.
3116         * dwarf-index-cache.c: Update.
3117         * dwarf-index-write.c: Update.
3118         * dwarf2-frame-tailcall.c: Update.
3119         * dwarf2-frame.c: Update.
3120         * dwarf2loc.c: Update.
3121         * dwarf2read.c: Update.
3122         * eval.c: Update.
3123         * event-loop.c: Update.
3124         * event-top.c: Update.
3125         * exec.c: Update.
3126         * f-valprint.c: Update.
3127         * fbsd-tdep.c: Update.
3128         * frame-unwind.c: Update.
3129         * frame.c: Update.
3130         * gdbtypes.c: Update.
3131         * gnu-v3-abi.c: Update.
3132         * guile/guile-internal.h: Update.
3133         * guile/scm-block.c: Update.
3134         * guile/scm-breakpoint.c: Update.
3135         * guile/scm-cmd.c: Update.
3136         * guile/scm-disasm.c: Update.
3137         * guile/scm-frame.c: Update.
3138         * guile/scm-lazy-string.c: Update.
3139         * guile/scm-math.c: Update.
3140         * guile/scm-param.c: Update.
3141         * guile/scm-ports.c: Update.
3142         * guile/scm-pretty-print.c: Update.
3143         * guile/scm-symbol.c: Update.
3144         * guile/scm-symtab.c: Update.
3145         * guile/scm-type.c: Update.
3146         * guile/scm-value.c: Update.
3147         * i386-linux-tdep.c: Update.
3148         * i386-tdep.c: Update.
3149         * inf-loop.c: Update.
3150         * infcall.c: Update.
3151         * infcmd.c: Update.
3152         * infrun.c: Update.
3153         * jit.c: Update.
3154         * language.c: Update.
3155         * linespec.c: Update.
3156         * linux-fork.c: Update.
3157         * linux-nat.c: Update.
3158         * linux-tdep.c: Update.
3159         * linux-thread-db.c: Update.
3160         * main.c: Update.
3161         * mi/mi-cmd-break.c: Update.
3162         * mi/mi-cmd-stack.c: Update.
3163         * mi/mi-interp.c: Update.
3164         * mi/mi-main.c: Update.
3165         * objc-lang.c: Update.
3166         * p-valprint.c: Update.
3167         * parse.c: Update.
3168         * ppc-linux-tdep.c: Update.
3169         * printcmd.c: Update.
3170         * python/py-arch.c: Update.
3171         * python/py-breakpoint.c: Update.
3172         * python/py-cmd.c: Update.
3173         * python/py-finishbreakpoint.c: Update.
3174         * python/py-frame.c: Update.
3175         * python/py-framefilter.c: Update.
3176         * python/py-gdb-readline.c: Update.
3177         * python/py-inferior.c: Update.
3178         * python/py-infthread.c: Update.
3179         * python/py-lazy-string.c: Update.
3180         * python/py-linetable.c: Update.
3181         * python/py-objfile.c: Update.
3182         * python/py-param.c: Update.
3183         * python/py-prettyprint.c: Update.
3184         * python/py-progspace.c: Update.
3185         * python/py-record-btrace.c: Update.
3186         * python/py-record.c: Update.
3187         * python/py-symbol.c: Update.
3188         * python/py-type.c: Update.
3189         * python/py-unwind.c: Update.
3190         * python/py-utils.c: Update.
3191         * python/py-value.c: Update.
3192         * python/python.c: Update.
3193         * record-btrace.c: Update.
3194         * record-full.c: Update.
3195         * remote-fileio.c: Update.
3196         * remote.c: Update.
3197         * riscv-tdep.c: Update.
3198         * rs6000-aix-tdep.c: Update.
3199         * rs6000-tdep.c: Update.
3200         * rust-exp.y: Update.
3201         * rust-lang.c: Update.
3202         * s390-tdep.c: Update.
3203         * selftest-arch.c: Update.
3204         * solib-dsbt.c: Update.
3205         * solib-frv.c: Update.
3206         * solib-spu.c: Update.
3207         * solib-svr4.c: Update.
3208         * solib.c: Update.
3209         * sparc64-linux-tdep.c: Update.
3210         * stack.c: Update.
3211         * symfile-mem.c: Update.
3212         * symmisc.c: Update.
3213         * target.c: Update.
3214         * thread.c: Update.
3215         * top.c: Update.
3216         * tracefile-tfile.c: Update.
3217         * tui/tui.c: Update.
3218         * typeprint.c: Update.
3219         * unittests/cli-utils-selftests.c: Update.
3220         * unittests/parse-connection-spec-selftests.c: Update.
3221         * valops.c: Update.
3222         * valprint.c: Update.
3223         * value.c: Update.
3224         * varobj.c: Update.
3225         * windows-nat.c: Update.
3226         * x86-linux-nat.c: Update.
3227         * xml-support.c: Update.
3228
3229 2019-04-08  Tom Tromey  <tom@tromey.com>
3230
3231         * xml-support.c: Use C++ exception handling.
3232         * x86-linux-nat.c: Use C++ exception handling.
3233         * windows-nat.c: Use C++ exception handling.
3234         * varobj.c: Use C++ exception handling.
3235         * value.c: Use C++ exception handling.
3236         * valprint.c: Use C++ exception handling.
3237         * valops.c: Use C++ exception handling.
3238         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3239         handling.
3240         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3241         * typeprint.c: Use C++ exception handling.
3242         * tui/tui.c: Use C++ exception handling.
3243         * tracefile-tfile.c: Use C++ exception handling.
3244         * top.c: Use C++ exception handling.
3245         * thread.c: Use C++ exception handling.
3246         * target.c: Use C++ exception handling.
3247         * symmisc.c: Use C++ exception handling.
3248         * symfile-mem.c: Use C++ exception handling.
3249         * stack.c: Use C++ exception handling.
3250         * sparc64-linux-tdep.c: Use C++ exception handling.
3251         * solib.c: Use C++ exception handling.
3252         * solib-svr4.c: Use C++ exception handling.
3253         * solib-spu.c: Use C++ exception handling.
3254         * solib-frv.c: Use C++ exception handling.
3255         * solib-dsbt.c: Use C++ exception handling.
3256         * selftest-arch.c: Use C++ exception handling.
3257         * s390-tdep.c: Use C++ exception handling.
3258         * rust-lang.c: Use C++ exception handling.
3259         * rust-exp.y: Use C++ exception handling.
3260         * rs6000-tdep.c: Use C++ exception handling.
3261         * rs6000-aix-tdep.c: Use C++ exception handling.
3262         * riscv-tdep.c: Use C++ exception handling.
3263         * remote.c: Use C++ exception handling.
3264         * remote-fileio.c: Use C++ exception handling.
3265         * record-full.c: Use C++ exception handling.
3266         * record-btrace.c: Use C++ exception handling.
3267         * python/python.c: Use C++ exception handling.
3268         * python/py-value.c: Use C++ exception handling.
3269         * python/py-utils.c: Use C++ exception handling.
3270         * python/py-unwind.c: Use C++ exception handling.
3271         * python/py-type.c: Use C++ exception handling.
3272         * python/py-symbol.c: Use C++ exception handling.
3273         * python/py-record.c: Use C++ exception handling.
3274         * python/py-record-btrace.c: Use C++ exception handling.
3275         * python/py-progspace.c: Use C++ exception handling.
3276         * python/py-prettyprint.c: Use C++ exception handling.
3277         * python/py-param.c: Use C++ exception handling.
3278         * python/py-objfile.c: Use C++ exception handling.
3279         * python/py-linetable.c: Use C++ exception handling.
3280         * python/py-lazy-string.c: Use C++ exception handling.
3281         * python/py-infthread.c: Use C++ exception handling.
3282         * python/py-inferior.c: Use C++ exception handling.
3283         * python/py-gdb-readline.c: Use C++ exception handling.
3284         * python/py-framefilter.c: Use C++ exception handling.
3285         * python/py-frame.c: Use C++ exception handling.
3286         * python/py-finishbreakpoint.c: Use C++ exception handling.
3287         * python/py-cmd.c: Use C++ exception handling.
3288         * python/py-breakpoint.c: Use C++ exception handling.
3289         * python/py-arch.c: Use C++ exception handling.
3290         * printcmd.c: Use C++ exception handling.
3291         * ppc-linux-tdep.c: Use C++ exception handling.
3292         * parse.c: Use C++ exception handling.
3293         * p-valprint.c: Use C++ exception handling.
3294         * objc-lang.c: Use C++ exception handling.
3295         * mi/mi-main.c: Use C++ exception handling.
3296         * mi/mi-interp.c: Use C++ exception handling.
3297         * mi/mi-cmd-stack.c: Use C++ exception handling.
3298         * mi/mi-cmd-break.c: Use C++ exception handling.
3299         * main.c: Use C++ exception handling.
3300         * linux-thread-db.c: Use C++ exception handling.
3301         * linux-tdep.c: Use C++ exception handling.
3302         * linux-nat.c: Use C++ exception handling.
3303         * linux-fork.c: Use C++ exception handling.
3304         * linespec.c: Use C++ exception handling.
3305         * language.c: Use C++ exception handling.
3306         * jit.c: Use C++ exception handling.
3307         * infrun.c: Use C++ exception handling.
3308         * infcmd.c: Use C++ exception handling.
3309         * infcall.c: Use C++ exception handling.
3310         * inf-loop.c: Use C++ exception handling.
3311         * i386-tdep.c: Use C++ exception handling.
3312         * i386-linux-tdep.c: Use C++ exception handling.
3313         * guile/scm-value.c: Use C++ exception handling.
3314         * guile/scm-type.c: Use C++ exception handling.
3315         * guile/scm-symtab.c: Use C++ exception handling.
3316         * guile/scm-symbol.c: Use C++ exception handling.
3317         * guile/scm-pretty-print.c: Use C++ exception handling.
3318         * guile/scm-ports.c: Use C++ exception handling.
3319         * guile/scm-param.c: Use C++ exception handling.
3320         * guile/scm-math.c: Use C++ exception handling.
3321         * guile/scm-lazy-string.c: Use C++ exception handling.
3322         * guile/scm-frame.c: Use C++ exception handling.
3323         * guile/scm-disasm.c: Use C++ exception handling.
3324         * guile/scm-cmd.c: Use C++ exception handling.
3325         * guile/scm-breakpoint.c: Use C++ exception handling.
3326         * guile/scm-block.c: Use C++ exception handling.
3327         * guile/guile-internal.h: Use C++ exception handling.
3328         * gnu-v3-abi.c: Use C++ exception handling.
3329         * gdbtypes.c: Use C++ exception handling.
3330         * frame.c: Use C++ exception handling.
3331         * frame-unwind.c: Use C++ exception handling.
3332         * fbsd-tdep.c: Use C++ exception handling.
3333         * f-valprint.c: Use C++ exception handling.
3334         * exec.c: Use C++ exception handling.
3335         * event-top.c: Use C++ exception handling.
3336         * event-loop.c: Use C++ exception handling.
3337         * eval.c: Use C++ exception handling.
3338         * dwarf2read.c: Use C++ exception handling.
3339         * dwarf2loc.c: Use C++ exception handling.
3340         * dwarf2-frame.c: Use C++ exception handling.
3341         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3342         * dwarf-index-write.c: Use C++ exception handling.
3343         * dwarf-index-cache.c: Use C++ exception handling.
3344         * dtrace-probe.c: Use C++ exception handling.
3345         * disasm-selftests.c: Use C++ exception handling.
3346         * darwin-nat.c: Use C++ exception handling.
3347         * cp-valprint.c: Use C++ exception handling.
3348         * cp-support.c: Use C++ exception handling.
3349         * cp-abi.c: Use C++ exception handling.
3350         * corelow.c: Use C++ exception handling.
3351         * completer.c: Use C++ exception handling.
3352         * compile/compile-object-run.c: Use C++ exception handling.
3353         * compile/compile-object-load.c: Use C++ exception handling.
3354         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3355         * compile/compile-c-symbols.c: Use C++ exception handling.
3356         * common/selftest.c: Use C++ exception handling.
3357         * common/new-op.c: Use C++ exception handling.
3358         * cli/cli-script.c: Use C++ exception handling.
3359         * cli/cli-interp.c: Use C++ exception handling.
3360         * cli/cli-cmds.c: Use C++ exception handling.
3361         * c-varobj.c: Use C++ exception handling.
3362         * btrace.c: Use C++ exception handling.
3363         * breakpoint.c: Use C++ exception handling.
3364         * break-catch-throw.c: Use C++ exception handling.
3365         * arch-utils.c: Use C++ exception handling.
3366         * amd64-tdep.c: Use C++ exception handling.
3367         * ada-valprint.c: Use C++ exception handling.
3368         * ada-typeprint.c: Use C++ exception handling.
3369         * ada-lang.c: Use C++ exception handling.
3370         * aarch64-tdep.c: Use C++ exception handling.
3371
3372 2019-04-08  Tom Tromey  <tom@tromey.com>
3373
3374         * xml-support.c (gdb_xml_parser::parse): Update.
3375         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3376         * value.c (show_convenience): Update.
3377         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3378         (test_parse_flags_qcs): Update.
3379         * thread.c (thr_try_catch_cmd): Update.
3380         * target.c (target_translate_tls_address): Update.
3381         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3382         (info_frame_command_core, frame_apply_command_count): Update.
3383         * rust-exp.y (rust_lex_exception_test): Update.
3384         * riscv-tdep.c (riscv_print_one_register_info): Update.
3385         * remote.c (remote_target::enable_btrace): Update.
3386         * record-btrace.c (record_btrace_enable_warn): Update.
3387         * python/py-utils.c (gdbpy_convert_exception): Update.
3388         * printcmd.c (do_one_display, print_variable_and_value): Update.
3389         * mi/mi-main.c (mi_print_exception): Update.
3390         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3391         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3392         * linux-nat.c (linux_nat_target::attach): Update.
3393         * linux-fork.c (class scoped_switch_fork_info): Update.
3394         * infrun.c (displaced_step_prepare): Update.
3395         * infcall.c (call_function_by_hand_dummy): Update.
3396         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3397         * gnu-v3-abi.c (print_one_vtable): Update.
3398         * frame.c (get_prev_frame_always): Update.
3399         * f-valprint.c (info_common_command_for_block): Update.
3400         * exec.c (try_open_exec_file): Update.
3401         * exceptions.c (print_exception, exception_print)
3402         (exception_fprintf, exception_print_same): Update.
3403         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3404         * dwarf-index-cache.c (index_cache::store)
3405         (index_cache::lookup_gdb_index): Update.
3406         * darwin-nat.c (maybe_cache_shell): Update.
3407         * cp-valprint.c (cp_print_value_fields): Update.
3408         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3409         (gcc_cplus_symbol_address): Update.
3410         * compile/compile-c-symbols.c (gcc_convert_symbol)
3411         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3412         * common/selftest.c: Update.
3413         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3414         a std::string.
3415         (exception_try_scope_entry, exception_try_scope_exit): Don't
3416         declare.
3417         (struct exception_try_scope): Remove.
3418         (TRY): Don't use exception_try_scope.
3419         (struct gdb_exception): Add constructor, operator=.
3420         <what>: New method.
3421         (struct gdb_exception_RETURN_MASK_ALL)
3422         (struct gdb_exception_RETURN_MASK_ERROR)
3423         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3424         (struct gdb_quit_bad_alloc): Update.
3425         * common/common-exceptions.c (exception_none): Change
3426         initializer.
3427         (struct catcher) <state, exception>: Initialize inline.
3428         <prev>: Remove member.
3429         (current_catcher): Remove.
3430         (catchers): New global.
3431         (exceptions_state_mc_init): Simplify.
3432         (catcher_pop): Remove.
3433         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3434         (try_scope_depth, exception_try_scope_entry)
3435         (exception_try_scope_exit): Remove.
3436         (throw_exception_sjlj): Update.
3437         (exception_messages, exception_messages_size): Remove.
3438         (throw_it): Simplify.
3439         (gdb_exception_sliced_copy): Remove.
3440         (throw_exception_cxx): Update.
3441         * cli/cli-script.c (script_from_file): Update.
3442         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3443         Update.
3444         * ada-valprint.c (ada_val_print): Update.
3445         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3446         (create_excep_cond_exprs): Update.
3447
3448 2019-04-08  Tom Tromey  <tom@tromey.com>
3449
3450         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3451         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3452         (TRY, CATCH, END_CATCH): Remove some definitions.
3453         * common/common-exceptions.c: Don't use GDB_XCPT.
3454         (catcher_list_size): Remove.
3455         (throw_exception, throw_it): Simplify.
3456
3457 2019-04-05  Tom Tromey  <tom@tromey.com>
3458
3459         Revert the header-sorting patch.
3460         * ft32-tdep.c: Revert.
3461         * frv-tdep.c: Revert.
3462         * frv-linux-tdep.c: Revert.
3463         * frame.c: Revert.
3464         * frame-unwind.c: Revert.
3465         * frame-base.c: Revert.
3466         * fork-child.c: Revert.
3467         * findvar.c: Revert.
3468         * findcmd.c: Revert.
3469         * filesystem.c: Revert.
3470         * filename-seen-cache.h: Revert.
3471         * filename-seen-cache.c: Revert.
3472         * fbsd-tdep.c: Revert.
3473         * fbsd-nat.h: Revert.
3474         * fbsd-nat.c: Revert.
3475         * f-valprint.c: Revert.
3476         * f-typeprint.c: Revert.
3477         * f-lang.c: Revert.
3478         * extension.h: Revert.
3479         * extension.c: Revert.
3480         * extension-priv.h: Revert.
3481         * expprint.c: Revert.
3482         * exec.h: Revert.
3483         * exec.c: Revert.
3484         * exceptions.c: Revert.
3485         * event-top.c: Revert.
3486         * event-loop.c: Revert.
3487         * eval.c: Revert.
3488         * elfread.c: Revert.
3489         * dwarf2read.h: Revert.
3490         * dwarf2read.c: Revert.
3491         * dwarf2loc.c: Revert.
3492         * dwarf2expr.h: Revert.
3493         * dwarf2expr.c: Revert.
3494         * dwarf2-frame.c: Revert.
3495         * dwarf2-frame-tailcall.c: Revert.
3496         * dwarf-index-write.h: Revert.
3497         * dwarf-index-write.c: Revert.
3498         * dwarf-index-common.c: Revert.
3499         * dwarf-index-cache.h: Revert.
3500         * dwarf-index-cache.c: Revert.
3501         * dummy-frame.c: Revert.
3502         * dtrace-probe.c: Revert.
3503         * disasm.h: Revert.
3504         * disasm.c: Revert.
3505         * disasm-selftests.c: Revert.
3506         * dictionary.c: Revert.
3507         * dicos-tdep.c: Revert.
3508         * demangle.c: Revert.
3509         * dcache.h: Revert.
3510         * dcache.c: Revert.
3511         * darwin-nat.h: Revert.
3512         * darwin-nat.c: Revert.
3513         * darwin-nat-info.c: Revert.
3514         * d-valprint.c: Revert.
3515         * d-namespace.c: Revert.
3516         * d-lang.c: Revert.
3517         * ctf.c: Revert.
3518         * csky-tdep.c: Revert.
3519         * csky-linux-tdep.c: Revert.
3520         * cris-tdep.c: Revert.
3521         * cris-linux-tdep.c: Revert.
3522         * cp-valprint.c: Revert.
3523         * cp-support.c: Revert.
3524         * cp-namespace.c: Revert.
3525         * cp-abi.c: Revert.
3526         * corelow.c: Revert.
3527         * corefile.c: Revert.
3528         * continuations.c: Revert.
3529         * completer.h: Revert.
3530         * completer.c: Revert.
3531         * complaints.c: Revert.
3532         * coffread.c: Revert.
3533         * coff-pe-read.c: Revert.
3534         * cli-out.h: Revert.
3535         * cli-out.c: Revert.
3536         * charset.c: Revert.
3537         * c-varobj.c: Revert.
3538         * c-valprint.c: Revert.
3539         * c-typeprint.c: Revert.
3540         * c-lang.c: Revert.
3541         * buildsym.c: Revert.
3542         * buildsym-legacy.c: Revert.
3543         * build-id.h: Revert.
3544         * build-id.c: Revert.
3545         * btrace.c: Revert.
3546         * bsd-uthread.c: Revert.
3547         * breakpoint.h: Revert.
3548         * breakpoint.c: Revert.
3549         * break-catch-throw.c: Revert.
3550         * break-catch-syscall.c: Revert.
3551         * break-catch-sig.c: Revert.
3552         * blockframe.c: Revert.
3553         * block.c: Revert.
3554         * bfin-tdep.c: Revert.
3555         * bfin-linux-tdep.c: Revert.
3556         * bfd-target.c: Revert.
3557         * bcache.c: Revert.
3558         * ax-general.c: Revert.
3559         * ax-gdb.h: Revert.
3560         * ax-gdb.c: Revert.
3561         * avr-tdep.c: Revert.
3562         * auxv.c: Revert.
3563         * auto-load.c: Revert.
3564         * arm-wince-tdep.c: Revert.
3565         * arm-tdep.c: Revert.
3566         * arm-symbian-tdep.c: Revert.
3567         * arm-pikeos-tdep.c: Revert.
3568         * arm-obsd-tdep.c: Revert.
3569         * arm-nbsd-tdep.c: Revert.
3570         * arm-nbsd-nat.c: Revert.
3571         * arm-linux-tdep.c: Revert.
3572         * arm-linux-nat.c: Revert.
3573         * arm-fbsd-tdep.c: Revert.
3574         * arm-fbsd-nat.c: Revert.
3575         * arm-bsd-tdep.c: Revert.
3576         * arch-utils.c: Revert.
3577         * arc-tdep.c: Revert.
3578         * arc-newlib-tdep.c: Revert.
3579         * annotate.h: Revert.
3580         * annotate.c: Revert.
3581         * amd64-windows-tdep.c: Revert.
3582         * amd64-windows-nat.c: Revert.
3583         * amd64-tdep.c: Revert.
3584         * amd64-sol2-tdep.c: Revert.
3585         * amd64-obsd-tdep.c: Revert.
3586         * amd64-obsd-nat.c: Revert.
3587         * amd64-nbsd-tdep.c: Revert.
3588         * amd64-nbsd-nat.c: Revert.
3589         * amd64-nat.c: Revert.
3590         * amd64-linux-tdep.c: Revert.
3591         * amd64-linux-nat.c: Revert.
3592         * amd64-fbsd-tdep.c: Revert.
3593         * amd64-fbsd-nat.c: Revert.
3594         * amd64-dicos-tdep.c: Revert.
3595         * amd64-darwin-tdep.c: Revert.
3596         * amd64-bsd-nat.c: Revert.
3597         * alpha-tdep.c: Revert.
3598         * alpha-obsd-tdep.c: Revert.
3599         * alpha-nbsd-tdep.c: Revert.
3600         * alpha-mdebug-tdep.c: Revert.
3601         * alpha-linux-tdep.c: Revert.
3602         * alpha-linux-nat.c: Revert.
3603         * alpha-bsd-tdep.c: Revert.
3604         * alpha-bsd-nat.c: Revert.
3605         * aix-thread.c: Revert.
3606         * agent.c: Revert.
3607         * addrmap.c: Revert.
3608         * ada-varobj.c: Revert.
3609         * ada-valprint.c: Revert.
3610         * ada-typeprint.c: Revert.
3611         * ada-tasks.c: Revert.
3612         * ada-lang.c: Revert.
3613         * aarch64-tdep.c: Revert.
3614         * aarch64-ravenscar-thread.c: Revert.
3615         * aarch64-newlib-tdep.c: Revert.
3616         * aarch64-linux-tdep.c: Revert.
3617         * aarch64-linux-nat.c: Revert.
3618         * aarch64-fbsd-tdep.c: Revert.
3619         * aarch64-fbsd-nat.c: Revert.
3620         * aarch32-linux-nat.c: Revert.
3621
3622 2019-04-05  Tom Tromey  <tom@tromey.com>
3623
3624         * ft32-tdep.c: Sort headers.
3625         * frv-tdep.c: Sort headers.
3626         * frv-linux-tdep.c: Sort headers.
3627         * frame.c: Sort headers.
3628         * frame-unwind.c: Sort headers.
3629         * frame-base.c: Sort headers.
3630         * fork-child.c: Sort headers.
3631         * findvar.c: Sort headers.
3632         * findcmd.c: Sort headers.
3633         * filesystem.c: Sort headers.
3634         * filename-seen-cache.h: Sort headers.
3635         * filename-seen-cache.c: Sort headers.
3636         * fbsd-tdep.c: Sort headers.
3637         * fbsd-nat.h: Sort headers.
3638         * fbsd-nat.c: Sort headers.
3639         * f-valprint.c: Sort headers.
3640         * f-typeprint.c: Sort headers.
3641         * f-lang.c: Sort headers.
3642         * extension.h: Sort headers.
3643         * extension.c: Sort headers.
3644         * extension-priv.h: Sort headers.
3645         * expprint.c: Sort headers.
3646         * exec.h: Sort headers.
3647         * exec.c: Sort headers.
3648         * exceptions.c: Sort headers.
3649         * event-top.c: Sort headers.
3650         * event-loop.c: Sort headers.
3651         * eval.c: Sort headers.
3652         * elfread.c: Sort headers.
3653         * dwarf2read.h: Sort headers.
3654         * dwarf2read.c: Sort headers.
3655         * dwarf2loc.c: Sort headers.
3656         * dwarf2expr.h: Sort headers.
3657         * dwarf2expr.c: Sort headers.
3658         * dwarf2-frame.c: Sort headers.
3659         * dwarf2-frame-tailcall.c: Sort headers.
3660         * dwarf-index-write.h: Sort headers.
3661         * dwarf-index-write.c: Sort headers.
3662         * dwarf-index-common.c: Sort headers.
3663         * dwarf-index-cache.h: Sort headers.
3664         * dwarf-index-cache.c: Sort headers.
3665         * dummy-frame.c: Sort headers.
3666         * dtrace-probe.c: Sort headers.
3667         * disasm.h: Sort headers.
3668         * disasm.c: Sort headers.
3669         * disasm-selftests.c: Sort headers.
3670         * dictionary.c: Sort headers.
3671         * dicos-tdep.c: Sort headers.
3672         * demangle.c: Sort headers.
3673         * dcache.h: Sort headers.
3674         * dcache.c: Sort headers.
3675         * darwin-nat.h: Sort headers.
3676         * darwin-nat.c: Sort headers.
3677         * darwin-nat-info.c: Sort headers.
3678         * d-valprint.c: Sort headers.
3679         * d-namespace.c: Sort headers.
3680         * d-lang.c: Sort headers.
3681         * ctf.c: Sort headers.
3682         * csky-tdep.c: Sort headers.
3683         * csky-linux-tdep.c: Sort headers.
3684         * cris-tdep.c: Sort headers.
3685         * cris-linux-tdep.c: Sort headers.
3686         * cp-valprint.c: Sort headers.
3687         * cp-support.c: Sort headers.
3688         * cp-namespace.c: Sort headers.
3689         * cp-abi.c: Sort headers.
3690         * corelow.c: Sort headers.
3691         * corefile.c: Sort headers.
3692         * continuations.c: Sort headers.
3693         * completer.h: Sort headers.
3694         * completer.c: Sort headers.
3695         * complaints.c: Sort headers.
3696         * coffread.c: Sort headers.
3697         * coff-pe-read.c: Sort headers.
3698         * cli-out.h: Sort headers.
3699         * cli-out.c: Sort headers.
3700         * charset.c: Sort headers.
3701         * c-varobj.c: Sort headers.
3702         * c-valprint.c: Sort headers.
3703         * c-typeprint.c: Sort headers.
3704         * c-lang.c: Sort headers.
3705         * buildsym.c: Sort headers.
3706         * buildsym-legacy.c: Sort headers.
3707         * build-id.h: Sort headers.
3708         * build-id.c: Sort headers.
3709         * btrace.c: Sort headers.
3710         * bsd-uthread.c: Sort headers.
3711         * breakpoint.h: Sort headers.
3712         * breakpoint.c: Sort headers.
3713         * break-catch-throw.c: Sort headers.
3714         * break-catch-syscall.c: Sort headers.
3715         * break-catch-sig.c: Sort headers.
3716         * blockframe.c: Sort headers.
3717         * block.c: Sort headers.
3718         * bfin-tdep.c: Sort headers.
3719         * bfin-linux-tdep.c: Sort headers.
3720         * bfd-target.c: Sort headers.
3721         * bcache.c: Sort headers.
3722         * ax-general.c: Sort headers.
3723         * ax-gdb.h: Sort headers.
3724         * ax-gdb.c: Sort headers.
3725         * avr-tdep.c: Sort headers.
3726         * auxv.c: Sort headers.
3727         * auto-load.c: Sort headers.
3728         * arm-wince-tdep.c: Sort headers.
3729         * arm-tdep.c: Sort headers.
3730         * arm-symbian-tdep.c: Sort headers.
3731         * arm-pikeos-tdep.c: Sort headers.
3732         * arm-obsd-tdep.c: Sort headers.
3733         * arm-nbsd-tdep.c: Sort headers.
3734         * arm-nbsd-nat.c: Sort headers.
3735         * arm-linux-tdep.c: Sort headers.
3736         * arm-linux-nat.c: Sort headers.
3737         * arm-fbsd-tdep.c: Sort headers.
3738         * arm-fbsd-nat.c: Sort headers.
3739         * arm-bsd-tdep.c: Sort headers.
3740         * arch-utils.c: Sort headers.
3741         * arc-tdep.c: Sort headers.
3742         * arc-newlib-tdep.c: Sort headers.
3743         * annotate.h: Sort headers.
3744         * annotate.c: Sort headers.
3745         * amd64-windows-tdep.c: Sort headers.
3746         * amd64-windows-nat.c: Sort headers.
3747         * amd64-tdep.c: Sort headers.
3748         * amd64-sol2-tdep.c: Sort headers.
3749         * amd64-obsd-tdep.c: Sort headers.
3750         * amd64-obsd-nat.c: Sort headers.
3751         * amd64-nbsd-tdep.c: Sort headers.
3752         * amd64-nbsd-nat.c: Sort headers.
3753         * amd64-nat.c: Sort headers.
3754         * amd64-linux-tdep.c: Sort headers.
3755         * amd64-linux-nat.c: Sort headers.
3756         * amd64-fbsd-tdep.c: Sort headers.
3757         * amd64-fbsd-nat.c: Sort headers.
3758         * amd64-dicos-tdep.c: Sort headers.
3759         * amd64-darwin-tdep.c: Sort headers.
3760         * amd64-bsd-nat.c: Sort headers.
3761         * alpha-tdep.c: Sort headers.
3762         * alpha-obsd-tdep.c: Sort headers.
3763         * alpha-nbsd-tdep.c: Sort headers.
3764         * alpha-mdebug-tdep.c: Sort headers.
3765         * alpha-linux-tdep.c: Sort headers.
3766         * alpha-linux-nat.c: Sort headers.
3767         * alpha-bsd-tdep.c: Sort headers.
3768         * alpha-bsd-nat.c: Sort headers.
3769         * aix-thread.c: Sort headers.
3770         * agent.c: Sort headers.
3771         * addrmap.c: Sort headers.
3772         * ada-varobj.c: Sort headers.
3773         * ada-valprint.c: Sort headers.
3774         * ada-typeprint.c: Sort headers.
3775         * ada-tasks.c: Sort headers.
3776         * ada-lang.c: Sort headers.
3777         * aarch64-tdep.c: Sort headers.
3778         * aarch64-ravenscar-thread.c: Sort headers.
3779         * aarch64-newlib-tdep.c: Sort headers.
3780         * aarch64-linux-tdep.c: Sort headers.
3781         * aarch64-linux-nat.c: Sort headers.
3782         * aarch64-fbsd-tdep.c: Sort headers.
3783         * aarch64-fbsd-nat.c: Sort headers.
3784         * aarch32-linux-nat.c: Sort headers.
3785
3786 2019-04-04  Tom Tromey  <tom@tromey.com>
3787
3788         * varobj.c (varobj_create): Update.
3789         * rust-exp.y (struct rust_parser) <update_innermost_block,
3790         lookup_symbol>: New methods.
3791         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3792         Rename.
3793         (rust_parser::rust_lookup_type)
3794         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3795         * printcmd.c (display_command, do_one_display): Update.
3796         * parser-defs.h (struct parser_state) <parser_state>: Add
3797         "tracker" parameter.
3798         (block_tracker): New member.
3799         (class innermost_block_tracker) <innermost_block_tracker>: Add
3800         "types" parameter.
3801         <reset>: Remove method.
3802         (innermost_block): Don't declare.
3803         (null_post_parser): Update.
3804         * parse.c (innermost_block): Remove global.
3805         (write_dollar_variable): Update.
3806         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3807         Remove "tracker_types" parameter.
3808         (parse_expression): Add "tracker" parameter.
3809         (parse_expression_for_completion): Update.
3810         (null_post_parser): Add "tracker" parameter.
3811         * p-exp.y: Update rules.
3812         * m2-exp.y: Update rules.
3813         * language.h (struct language_defn) <la_post_parser>: Add
3814         "tracker" parameter.
3815         * go-exp.y: Update rules.
3816         * f-exp.y: Update rules.
3817         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3818         parameter.
3819         * d-exp.y: Update rules.
3820         * c-exp.y: Update rules.
3821         * breakpoint.c (set_breakpoint_condition): Create an
3822         innermost_block_tracker.
3823         (watch_command_1): Likewise.
3824         * ada-lang.c (resolve): Add "tracker" parameter.
3825         (resolve_subexp): Likewise.
3826         * ada-exp.y (write_var_from_sym): Update.
3827
3828 2019-04-04  Tom Tromey  <tom@tromey.com>
3829
3830         * type-stack.h: New file.
3831         * type-stack.c: New file.
3832         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3833         type-stack.h.
3834         (insert_into_type_stack, insert_type, push_type, push_type_int)
3835         (insert_type_address_space, pop_type, pop_type_int)
3836         (pop_typelist, pop_type_stack, append_type_stack)
3837         (push_type_stack, get_type_stack, push_typelist)
3838         (follow_type_instance_flags, follow_types): Don't declare.
3839         * parse.c (type_stack): Remove global.
3840         (parse_exp_in_context): Update.
3841         (insert_into_type_stack, insert_type, push_type, push_type_int)
3842         (insert_type_address_space, pop_type, pop_type_int)
3843         (pop_typelist, pop_type_stack, append_type_stack)
3844         (push_type_stack, get_type_stack, push_typelist)
3845         (follow_type_instance_flags, follow_types): Remove (moved to
3846         type-stack.c).
3847         * f-exp.y (type_stack): New global.
3848         Update rules.
3849         (push_kind_type, f_parse): Update.
3850         * d-exp.y (type_stack): New global.
3851         Update rules.
3852         (d_parse): Update.
3853         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3854         Update rules.
3855         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3856         (HFILES_NO_SRCDIR): Add type-stack.h.
3857
3858 2019-04-04  Tom Tromey  <tom@tromey.com>
3859
3860         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3861         (rust_parser::convert_ast_to_expression, rust_parse)
3862         (rust_lex_test_completion, rust_lex_tests): Update.
3863         * parser-defs.h (struct expr_completion_state): New.
3864         (struct parser_state) <parser_state>: Add completion parameter.
3865         <mark_struct_expression, mark_completion_tag>: New methods.
3866         <parse_completion, m_completion_state>: New members.
3867         (prefixify_expression, null_post_parser): Update.
3868         (mark_struct_expression, mark_completion_tag): Don't declare.
3869         * parse.c (parse_completion, expout_last_struct)
3870         (expout_tag_completion_type, expout_completion_name): Remove
3871         globals.
3872         (parser_state::mark_struct_expression)
3873         (parser_state::mark_completion_tag): Now methods.
3874         (prefixify_expression): Add last_struct parameter.
3875         (prefixify_subexp): Likewise.
3876         (parse_exp_1): Update.
3877         (parse_exp_in_context): Add cstate parameter.  Update.
3878         (parse_expression_for_completion): Create an
3879         expr_completion_state.
3880         (null_post_parser): Add "completion" parameter.
3881         * p-exp.y: Update rules.
3882         (yylex): Update.
3883         * language.h (struct language_defn) <la_post_parser>: Add
3884         "completing" parameter.
3885         * go-exp.y: Update rules.
3886         (lex_one_token): Update.
3887         * expression.h (parse_completion): Don't declare.
3888         * d-exp.y: Update rules.
3889         (lex_one_token): Update rules.
3890         * c-exp.y: Update rules.
3891         (lex_one_token): Update.
3892         * ada-lang.c (resolve): Add "parse_completion" parameter.
3893         (resolve_subexp): Likewise.
3894         (ada_resolve_function): Likewise.
3895
3896 2019-04-04  Tom Tromey  <tom@tromey.com>
3897
3898         * parser-defs.h (struct parser_state) <start_arglist,
3899         end_arglist>: New methods.
3900         <arglist_len, m_funcall_chain>: New members.
3901         (arglist_len, start_arglist, end_arglist): Don't declare.
3902         * parse.c (arglist_len, funcall_chain): Remove global.
3903         (start_arglist, end_arglist): Remove functions.
3904         (parse_exp_in_context): Update.
3905         * p-exp.y: Update rules.
3906         * m2-exp.y: Update rules.
3907         * go-exp.y: Update rules.
3908         * f-exp.y: Update rules.
3909         * d-exp.y: Update rules.
3910         * c-exp.y: Update rules.
3911
3912 2019-04-04  Tom Tromey  <tom@tromey.com>
3913
3914         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3915         lex_operator, push_back>: New methods.
3916         Update all rules.
3917         (rust_parser::lex_hex, lex_escape): Rename and update.
3918         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3919         (rust_parser::lex_operator): Rename and update.
3920         (rust_parser::lex_number, rustyylex, rustyyerror)
3921         (rust_lex_test_init, rust_lex_test_sequence)
3922         (rust_lex_test_push_back, rust_lex_tests): Update.
3923         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3924         parameter.
3925         <lexptr, prev_lexptr>: New members.
3926         (lexptr, prev_lexptr): Don't declare.
3927         * parse.c (lexptr, prev_lexptr): Remove globals.
3928         (parse_exp_in_context): Update.
3929         * p-exp.y (yylex, yyerror): Update.
3930         * m2-exp.y (parse_number, yylex, yyerror): Update.
3931         * go-exp.y (lex_one_token, yyerror): Update.
3932         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3933         * d-exp.y (lex_one_token, yyerror): Update.
3934         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3935         (lex_one_token, yyerror): Update.
3936         * ada-lex.l (YY_INPUT): Update.
3937         (rewind_to_char): Update.
3938         * ada-exp.y (yyerror): Update.
3939
3940 2019-04-04  Tom Tromey  <tom@tromey.com>
3941
3942         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3943         * parser-defs.h (struct parser_state) <parser_state>: Add new
3944         parameter.
3945         <comma_terminates>: New member.
3946         (comma_terminates): Don't declare global.
3947         * parse.c (comma_terminates): Remove global.
3948         (parse_exp_in_context): Update.
3949         * p-exp.y (yylex): Update.
3950         * m2-exp.y (yylex): Update.
3951         * go-exp.y (lex_one_token): Update.
3952         * f-exp.y (yylex): Update.
3953         * d-exp.y (lex_one_token): Update.
3954         * c-exp.y (lex_one_token): Update.
3955         * ada-lex.l: Update.
3956
3957 2019-04-04  Tom Tromey  <tom@tromey.com>
3958
3959         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3960         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3961         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3962         * parser-defs.h (paren_depth): Don't declare.
3963         * parse.c (paren_depth): Remove global.
3964         (parse_exp_in_context): Update.
3965         * p-exp.y (paren_depth): New global.
3966         (pascal_parse): Initialize it.
3967         * m2-exp.y (paren_depth): New global.
3968         (m2_parse): Initialize it.
3969         * go-exp.y (paren_depth): New global.
3970         (go_parse): Initialize it.
3971         * f-exp.y (paren_depth): New global.
3972         (f_parse): Initialize it.
3973         * d-exp.y (paren_depth): New global.
3974         (d_parse): Initialize it.
3975         * c-exp.y (paren_depth): New global.
3976         (c_parse): Initialize it.
3977         * ada-lex.l (paren_depth): New global.
3978         (lexer_init): Initialize it.
3979
3980 2019-04-04  Tom Tromey  <tom@tromey.com>
3981
3982         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3983         (rust_parser::convert_ast_to_type)
3984         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3985         * parser-defs.h (struct parser_state) <parser_state>: Add
3986         parameters.  Initialize new members.
3987         <expression_context_block, expression_context_pc>: New members.
3988         * parse.c (expression_context_block, expression_context_pc):
3989         Remove globals.
3990         (parse_exp_in_context): Update.
3991         * p-exp.y: Update all rules.
3992         (yylex): Update.
3993         * m2-exp.y: Update all rules.
3994         (yylex): Update.
3995         * go-exp.y (yylex): Update.
3996         * f-exp.y (yylex): Update.
3997         * d-exp.y: Update all rules.
3998         (yylex): Update.
3999         * c-exp.y: Update all rules.
4000         (lex_one_token, classify_name, yylex, c_parse): Update.
4001         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4002
4003 2019-04-04  Tom Tromey  <tom@tromey.com>
4004
4005         * gdbarch.h, gdbarch.c: Rebuild.
4006         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4007         * stap-probe.h:
4008         (struct stap_parse_info): Replace "parser_state" with
4009         "expr_builder".
4010         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4011         (parser_state): New class.
4012         * parse.c (expr_builder): Rename.
4013         (expr_builder::release): Rename.
4014         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4015         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4016         (write_exp_elt_longcst, write_exp_elt_floatcst)
4017         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4018         (write_exp_string_vector, write_exp_bitstring)
4019         (write_exp_msymbol, mark_struct_expression)
4020         (write_dollar_variable)
4021         (insert_type_address_space, increase_expout_size): Replace
4022         "parser_state" with "expr_builder".
4023         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4024         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4025         "parser_state" with "expr_builder".
4026
4027 2019-04-04  Tom Tromey  <tom@tromey.com>
4028
4029         * rust-exp.y: Replace "parse_language" with method call.
4030         * p-exp.y:
4031         (yylex): Replace "parse_language" with method call.
4032         * m2-exp.y:
4033         (yylex): Replace "parse_language" with method call.
4034         * go-exp.y (classify_name): Replace "parse_language" with method
4035         call.
4036         * f-exp.y (yylex): Replace "parse_language" with method call.
4037         * d-exp.y (lex_one_token): Replace "parse_language" with method
4038         call.
4039         * c-exp.y:
4040         (lex_one_token, classify_name, yylex): Replace "parse_language"
4041         with method call.
4042         * ada-exp.y (find_primitive_type, type_char)
4043         (type_system_address): Replace "parse_language" with method call.
4044
4045 2019-04-04  Tom Tromey  <tom@tromey.com>
4046
4047         * rust-exp.y: Replace "parse_gdbarch" with method call.
4048         * parse.c (write_dollar_variable, insert_type_address_space):
4049         Replace "parse_gdbarch" with method call.
4050         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4051         call.
4052         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4053         call.
4054         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4055         "parse_gdbarch" with method call.
4056         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4057         with method call.
4058         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4059         "parse_gdbarch" with method call.
4060         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4061         "parse_gdbarch" with method call.
4062         * c-exp.y (parse_type, parse_number, classify_name): Replace
4063         "parse_gdbarch" with method call.
4064         * ada-lex.l: Replace "parse_gdbarch" with method call.
4065         * ada-exp.y (parse_type, find_primitive_type, type_char)
4066         (type_system_address): Replace "parse_gdbarch" with method call.
4067
4068 2019-04-04  Tom Tromey  <tom@tromey.com>
4069
4070         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4071         * stap-probe.c (stap_parse_argument): Update.
4072         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4073         initial_size parameter.
4074         * rust-exp.y (rust_lex_tests): Update.
4075         * parse.c (parser_state): Update.
4076         (parse_exp_in_context): Update.
4077         * parser-defs.h (struct parser_state) <parser_state>: Remove
4078         "initial_size" parameter.
4079
4080 2019-04-04  Tom Tromey  <tom@tromey.com>
4081
4082         * parser-defs.h (increase_expout_size): Don't declare.
4083         * parse.c (increase_expout_size): Now static.
4084
4085 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4086
4087         * gnu-nat.c (gnu_nat_target::wait): Fix
4088         target_waitstatus_to_string call.
4089
4090 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * eval.c (evaluate_subexp_standard): Handle internal functions
4093         during Fortran function call handling.
4094
4095 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * NEWS: Mention new internal functions.
4098         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4099         (read_base_type): Use dwarf2_init_complex_target_type.
4100         * value.c (creal_internal_fn): New function.
4101         (cimag_internal_fn): New function.
4102         (_initialize_values): Register new internal functions.
4103
4104 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4105
4106         * infrun.c (stop_all_threads): If debug_infrun, always
4107         trace the wait status after wait_one, using
4108         target_waitstatus_to_string and target_pid_to_str.
4109         (handle_inferior_event): Replace various trace of
4110         wait status kind by a single trace.
4111         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4112         wait status kind image by target_waitstatus_to_string.
4113         * target/waitstatus.c (target_waitstatus_to_string): Fix
4114         obsolete comment.
4115
4116 2019-04-01  Tom Tromey  <tromey@adacore.com>
4117
4118         PR symtab/23331:
4119         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4120
4121 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4122             Pedro Alves  <palves@redhat.com>
4123
4124         * top.c (quit_force): Call 'finalize_values'.
4125         * value.c (finalize_values): New function.
4126         * value.h (finalize_values): Declare.
4127
4128 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4129
4130         * NEWS: Announce $_gdb_major and $_gdb_minor.
4131
4132         * top.c (init_gdb_version_vars): New function.
4133         (gdb_init): Call init_gdb_version_vars.
4134
4135 2019-03-29  Tom Tromey  <tromey@adacore.com>
4136
4137         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4138         help text.  Remove dead code.
4139
4140 2019-03-29  Keith Seitz  <keiths@redhat.com>
4141
4142         From Siddhesh Poyarekar:
4143         * f-lang.h (f77_get_upperbound): Return LONGEST.
4144         (f77_get_lowerbound): Likewise.
4145         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4146         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4147         print them.
4148         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4149         plongest to format print it.
4150         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4151         (f77_get_upperbound): Likewise.
4152         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4153         LOWER_BOUND to LONGEST.
4154         (f77_create_arrayprint_offset_tbl): Likewise.
4155
4156 2019-03-29  Keith Seitz  <keiths@redhat.com>
4157
4158         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4159         %s/pulongest for TYPE_LENGTH instead of %d in format
4160         strings.
4161         * ada-typerint.c (ada_print_type): Likewise.
4162         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4163         * compile/compile-c-support.c (generate_register_struct): Likewise.
4164         * gdbtypes.c (recursive_dump_type): Likewise.
4165         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4166         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4167         instead of %d in format strings.
4168         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4169         to std::min to ULONGEST.
4170         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4171         instead of %d in format strings.
4172         * tracepoint.c (info_scope_command): Likewise.
4173         * typeprint.c (print_offset_data::update)
4174         (print_offset_data::finish): Likewise.
4175         * xtensa-tdep.c (xtensa_store_return_value)
4176         (xtensa_push_dummy_call): Likewise.
4177
4178 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4179
4180         * windows-nat.c (display_selector): Fixed format specifications
4181         for 64-bit Cygwin.
4182
4183 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4184
4185         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4186
4187 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4188
4189         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4190         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4191         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4192         (nios2_linux_init_abi): Install it.
4193
4194 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4195
4196         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4197
4198 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4199
4200         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4201
4202 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4203             Tom Tromey  <tromey@adacore.com>
4204
4205         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4206
4207 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4208
4209         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4210         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4211         method to compute the bounds of range types. Also print "[evaluated]"
4212         if the bounds' values come from a dynamic evaluation.
4213
4214 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4217         whitespace when pretty printing is on.
4218
4219 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4220
4221         * ppc-linux-nat.c: Add include.
4222
4223 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4224
4225         * NEWS: Mention AArch64 Pointer Authentication.
4226
4227 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4228
4229         * arm-linux-nat.c: Add include.
4230
4231 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4232
4233         * source-cache.c (source_cache::get_source_lines): Re-read
4234         fullname after calling open_source_file.
4235
4236 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4237
4238         * NEWS: Mention TLS support for FreeBSD.
4239
4240 2019-03-25  Tom Tromey  <tromey@adacore.com>
4241
4242         * minsyms.c (BUNCH_SIZE): Update comment.
4243         (~minimal_symbol_reader): Remove old comment.
4244         (compact_minimal_symbols): Update comment.
4245         (minimal_symbol_reader::install): Remove old comment.  Update
4246         other comments.
4247
4248 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4249
4250         * s390-linux-nat.c: Add include.
4251
4252 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4253
4254         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4255         Call linux_get_hwcap.
4256         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4257         Likewise.
4258         (aarch64_linux_get_hwcap): Remove function.
4259         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4260         declaration.
4261         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4262         linux_get_hwcap.
4263         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4264         * linux-tdep.c (linux_get_hwcap): Add function.
4265         (linux_get_hwcap2): Likewise.
4266         * linux-tdep.h (linux_get_hwcap): Add declaration.
4267         (linux_get_hwcap2): Likewise.
4268         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4269         (ppc_linux_get_hwcap2): Likewise.
4270         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4271         linux_get_hwcap.
4272         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4273         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4274         (ppc_linux_nat_target::read_description): Likewise.
4275         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4276         * s390-linux-nat.c: Likewise.
4277         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4278
4279 2019-03-24  Tom Tromey  <tom@tromey.com>
4280
4281         * ada-lang.c (standard_lookup): Simplify initialization.
4282         (ada_lookup_symbol_nonlocal): Simplify return.
4283         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4284         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4285         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4286         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4287         initialization.
4288         * solib.c (solib_global_lookup): Simplify.
4289         * symtab.c (null_block_symbol): Remove.
4290         (symbol_cache_lookup): Simplify returns.
4291         (lookup_language_this): Simplify returns.
4292         (lookup_symbol_aux): Simplify return.
4293         (lookup_local_symbol): Simplify returns.
4294         (lookup_global_symbol_from_objfile): Simplify return.
4295         (lookup_symbol_in_objfile_symtabs)
4296         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4297         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4298         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4299         * cp-namespace.c (cp_lookup_bare_symbol)
4300         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4301         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4302         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4303         (cp_lookup_symbol_via_imports): Simplify initialization.
4304         (find_symbol_in_baseclass): Likewise.
4305         * symtab.h (null_block_symbol): Remove.
4306         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4307         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4308         (d_lookup_symbol_module): Likewise.
4309         (find_symbol_in_baseclass): Simplify initialization.
4310
4311 2019-03-24  Tom Tromey  <tom@tromey.com>
4312
4313         * expression.h: Don't include symtab.h.
4314         (struct block): Forward declare.
4315
4316 2019-03-24  Tom Tromey  <tom@tromey.com>
4317
4318         * c-exp.y (typebase): Remove casts.
4319         * gdbtypes.c (lookup_unsigned_typename, )
4320         (lookup_signed_typename): Remove cast.
4321         * eval.c (parse_to_comma_and_eval): Remove cast.
4322         * parse.c (write_dollar_variable): Remove cast.
4323         * block.h (struct block) <superblock>: Now const.
4324         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4325         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4326         (map_block): Make "block" const.
4327         * symfile.h (struct quick_symbol_functions)
4328         <map_matching_symbols>: Constify block argument to "callback".
4329         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4330         const.
4331         (find_pc_sect_compunit_symtab): Make "b" const.
4332         (find_symbol_at_address): Likewise.
4333         (search_symbols): Likewise.
4334         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4335         (dw2_debug_names_lookup_symbol): Likewise.
4336         (dw2_map_matching_symbols): Update.
4337         * p-valprint.c (pascal_val_print): Remove "block".
4338         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4339         (aux_add_nonlocal_symbols): Make "block" const.
4340         (resolve_subexp): Remove cast.
4341         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4342         const.
4343         (iterate_over_file_blocks): Likewise.
4344         * f-exp.y (%union) <bval>: Remove.
4345         * coffread.c (patch_opaque_types): Make "b" const.
4346         * spu-tdep.c (spu_catch_start): Make "block" const.
4347         * c-valprint.c (print_unpacked_pointer): Remove "block".
4348         * symmisc.c (dump_symtab_1): Make "b" const.
4349         (block_depth): Make "block" const.
4350         * d-exp.y (%union) <bval>: Remove.
4351         * cp-support.h (cp_lookup_rtti_type): Update.
4352         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4353         * psymtab.c (psym_lookup_symbol): Make "block" const.
4354         (maintenance_check_psymtabs): Make "b" const.
4355         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4356         (enumerate_locals, enumerate_args): Update.
4357         * python/py-symtab.c (stpy_global_block): Make "block" const.
4358         (stpy_static_block): Likewise.
4359         * inline-frame.c (block_starting_point_at): Make "new_block"
4360         const.
4361         * block.c (find_block_in_blockvector): Make return type const.
4362         (blockvector_for_pc_sect): Make "b" const.
4363         (find_block_in_blockvector): Make "b" const.
4364
4365 2019-03-23  Tom Tromey  <tom@tromey.com>
4366
4367         * varobj.c (varobj_create): Update.
4368         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4369         * printcmd.c (display_command, do_one_display): Don't reset
4370         innermost_block.
4371         * parser-defs.h (enum innermost_block_tracker_type): Move to
4372         expression.h.
4373         (innermost_block): Update comment.
4374         * parse.c (parse_exp_1): Add tracker_types parameter.
4375         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4376         tracker_types parameter.  Reset innermost_block.
4377         (parse_exp_in_context): Remove.
4378         (parse_expression_for_completion): Update.
4379         * objfiles.c (~objfile): Don't reset expression_context_block or
4380         innermost_block.
4381         * expression.h (enum innermost_block_tracker_type): Move from
4382         parser-defs.h.
4383         (parse_exp_1): Add tracker_types parameter.
4384         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4385         reset innermost_block.
4386
4387 2019-03-23  Tom Tromey  <tom@tromey.com>
4388
4389         * objfiles.h: Include bcache.h.
4390
4391 2019-03-23  Tom Tromey  <tom@tromey.com>
4392
4393         * linespec.c (get_current_search_block): Use
4394         scoped_restore_current_language.
4395         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4396
4397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4398             Jiong Wang  <jiong.wang@arm.com>
4399
4400         * aarch64-linux-tdep.c
4401         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4402         section.
4403         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4404
4405 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4406             Jiong Wang  <jiong.wang@arm.com>
4407
4408         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4409         instructions.
4410         (aarch64_analyze_prologue_test): Add PACIASP test.
4411         (aarch64_prologue_prev_register): Unmask PC value.
4412
4413 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4414             Jiong Wang  <jiong.wang@arm.com>
4415
4416         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4417         (aarch64_dwarf2_prev_register): Unmask PC value.
4418         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4419         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4420         DW_CFA_AARCH64_negate_ra_state.
4421         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4422
4423 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4424             Jiong Wang  <jiong.wang@arm.com>
4425
4426         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4427         registers.
4428         (aarch64_pseudo_register_name): Likewise.
4429         (aarch64_pseudo_register_type): Likewise.
4430         (aarch64_pseudo_register_reggroup_p): Likewise.
4431         (aarch64_gdbarch_init): Add pauth registers.
4432         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4433         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4434         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4435         (struct gdbarch_tdep): Add regnum for ra_state.
4436
4437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4438             Jiong Wang  <jiong.wang@arm.com>
4439
4440         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4441
4442 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4443             Jiong Wang  <jiong.wang@arm.com>
4444
4445         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4446         function.
4447         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4448         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4449         (aarch64_gdbarch_init): Add puth registers.
4450         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4451         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4452         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4453
4454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4455             Jiong Wang  <jiong.wang@arm.com>
4456
4457         * aarch64-linux-nat.c
4458         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4459         * aarch64-linux-tdep.c
4460         (aarch64_linux_core_read_description): Likewise.
4461         (aarch64_linux_get_hwcap): New function.
4462         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4463         (aarch64_linux_get_hwcap): New declaration.
4464
4465 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4466             Jiong Wang  <jiong.wang@arm.com>
4467
4468         * aarch64-linux-nat.c
4469         (aarch64_linux_nat_target::read_description): Add pauth param.
4470         * aarch64-linux-tdep.c
4471         (aarch64_linux_core_read_description): Likewise.
4472         * aarch64-tdep.c (struct target_desc): Add in pauth.
4473         (aarch64_read_description): Add pauth param.
4474         (aarch64_gdbarch_init): Likewise.
4475         * aarch64-tdep.h (aarch64_read_description): Likewise.
4476         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4477         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4478         * features/Makefile: Add new files.
4479         * features/aarch64-pauth.c: New file.
4480         * features/aarch64-pauth.xml: New file.
4481
4482 2019-03-20  Tom Tromey  <tromey@adacore.com>
4483
4484         * infrun.c (handle_inferior_event): Rename from
4485         handle_inferior_event_1.  Create a scoped_value_mark.
4486         (handle_inferior_event): Remove.
4487
4488 2019-03-19  Tom Tromey  <tromey@adacore.com>
4489
4490         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4491         * infrun.h (print_stop_event): Add "displays" parameter.
4492         * infrun.c (print_stop_event): Add "displays" parameter.
4493
4494 2019-03-19  Pedro Alves  <palves@redhat.com>
4495
4496         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4497         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4498         to -1.  Fix TABs vs spaces.
4499         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4500         * tui/tui-out.h (tui_ui_out) Add intro comments.
4501         <m_line, m_start_of_line>: In-class initialize, and add describing
4502         comment.
4503
4504 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4505
4506         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4507         variable names.
4508         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4509
4510 2019-03-18  Pedro Alves  <palves@redhat.com>
4511             Eli Zaretskii <eliz@gnu.org>
4512
4513         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4514         m_line and m_start_of_line.
4515
4516 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4517
4518         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4519         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4520         it returns a newline.  This fixes a regression in TU mode, whereby
4521         the next line is output on the same screen line as the user input.
4522
4523 2019-03-18  Tom Tromey  <tromey@adacore.com>
4524
4525         * minsyms.c (minimal_symbol_reader::install): Remove call to
4526         obstack_blank.
4527
4528 2019-03-18  Pedro Alves  <palves@redhat.com>
4529
4530         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4531         New globals.
4532         (apply_style): New, factored out from ...
4533         (apply_ansi_escape): ... this.  Handle reverse video mode.
4534         (tui_set_reverse_mode): New function.
4535         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4536         * tui/tui-winsource.c (tui_show_source_line): Use
4537         tui_set_reverse_mode instead of setting A_STANDOUT.
4538         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4539         New setter methods.
4540
4541 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4542
4543         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4544         Handle tabs.
4545
4546 2019-03-18  Tom Tromey  <tromey@adacore.com>
4547
4548         * ada-lang.c (empty_array): Add "high" parameter.
4549         (ada_evaluate_subexp): Update.
4550
4551 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4552
4553         * unittests/string_view-selftests.c: Define
4554         _initialize_string_view_selftests unconditionally.
4555
4556 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4557
4558         PR gdb/24350
4559         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4560
4561 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4562
4563         PR gdb/24351
4564         * windows-nat.c (display_selector): Fix format specifiers.
4565
4566 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4567
4568         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4569         tui_refill_source_window instead of tui_refresh_win, to update the
4570         current execution line.  This fixes redisplay of the current line
4571         when stepping through the code with "next" or "step".
4572
4573 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4574
4575         * source-cache.c (source_cache::get_source_lines): Call
4576         find_source_lines to initialize s->nlines.  This fixes vertical
4577         scrolling of TUI source window when the DOWN arrow is pressed.
4578
4579 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4580
4581         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4582         linux-thread-db.c (_initialize_thread_db): Likewise.
4583
4584 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4585
4586         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4587         wclrtoeol in tui_show_source_line".  This reverts changes made in
4588         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4589
4590 2019-03-15  Tom Tromey  <tom@tromey.com>
4591
4592         * symtab.h (struct minimal_symbol): Derive from
4593         general_symbol_info.
4594         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4595         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4596         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4597         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4598         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4599         (MSYMBOL_SEARCH_NAME): Update.
4600         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4601         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4602         * minsyms.c (minimal_symbol_reader::record_full): Update.
4603
4604 2019-03-15  Tom Tromey  <tom@tromey.com>
4605
4606         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4607
4608 2019-03-15  Tom Tromey  <tom@tromey.com>
4609
4610         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4611         unique_xmalloc_ptr.
4612         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4613         Update.
4614         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4615         (build_minimal_symbol_hash_tables)
4616         (minimal_symbol_reader::install): Update.
4617
4618 2019-03-15  Tom Tromey  <tom@tromey.com>
4619
4620         * symtab.c (create_demangled_names_hash): Update.
4621         (symbol_set_names): Update.
4622         * objfiles.h (struct objfile_per_bfd_storage)
4623         <demangled_names_hash>: Now an htab_up.
4624         * objfiles.c (objfile_per_bfd_storage): Simplify.
4625
4626 2019-03-15  Tom Tromey  <tom@tromey.com>
4627
4628         * objfiles.h (struct objfile_per_bfd_storage): Declare
4629         destructor.
4630         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4631         New.
4632         (get_objfile_bfd_data): Use new.  Don't initialize
4633         language_of_main.
4634         (free_objfile_per_bfd_storage): Remove.
4635         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4636
4637 2019-03-15  Tom Tromey  <tom@tromey.com>
4638
4639         * symfile.c (reread_symbols): Update.
4640         * objfiles.c (objfile::objfile): Update.
4641         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4642         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4643         comment.
4644         (minimal_symbol_reader::install): Update.
4645         (terminate_minimal_symbol_table): Remove.
4646         * jit.c (jit_object_close_impl): Update.
4647
4648 2019-03-15  Tom Tromey  <tom@tromey.com>
4649
4650         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4651         initializations.
4652
4653 2019-03-15  Tom Tromey  <tom@tromey.com>
4654
4655         * objfiles.h (struct objfile_per_bfd_storage)
4656         <demangled_hash_languages>: Now a bitset.
4657         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4658         (lookup_minimal_symbol): Update.
4659
4660 2019-03-15  Tom Tromey  <tom@tromey.com>
4661
4662         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4663         Don't return the symbol.
4664         * coffread.c (record_minimal_symbol): Use record_full.
4665
4666 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4667
4668         The MS-Windows port of ncurses fails to switch to a color pair if
4669         one or both of the colors are the implicit default colors.  This
4670         change records the default colors when TUI is initialized, and
4671         then specifies them explicitly when a color pair uses the default
4672         colors.  This allows color styling in TUI mode on MS-Windows.
4673
4674         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4675         ncurses_norm_attr.
4676         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4677         colors in ncurses_norm_attr.
4678         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4679         "none", replace it with the default color recorded in
4680         ncurses_norm_attr.
4681
4682 2019-03-14  Tom Tromey  <tromey@adacore.com>
4683
4684         * source-cache.h (class source_cache) <get_source_lines>: Return
4685         std::string.
4686         * source-cache.c (source_cache::extract_lines): Handle case where
4687         first_pos==npos.  Return std::string.
4688         (source_cache::get_source_lines): Update.
4689
4690 2019-03-14  Tom Tromey  <tromey@adacore.com>
4691
4692         * NEWS: Add item for "style sources" commands.
4693         * source-cache.c (source_cache::get_source_lines): Check
4694         source_styling.
4695         * cli/cli-style.c (source_styling): New global.
4696         (_initialize_cli_style): Add "style sources" commands.
4697         (show_style_sources): New function.
4698         * cli/cli-style.h (source_styling): Declare.
4699
4700 2019-03-14  Pedro Alves  <palves@redhat.com>
4701             Tom Tromey  <tromey@adacore.com>
4702
4703         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4704         * tui/tui-winsource.c (tui_refill_source_window): New function,
4705         from...
4706         (tui_horizontal_source_scroll): ... here.  Move some logic.
4707         * cli/cli-style.c (set_style_enabled): Notify new observable.
4708         * tui/tui-hooks.c (tui_redisplay_source): New function.
4709         (tui_attach_detach_observers): Attach or detach
4710         tui_redisplay_source.
4711         * observable.h (source_styling_changed): New observable.
4712         * observable.c: Define source_styling_changed observable.
4713
4714 2019-03-13  Tom Tromey  <tromey@adacore.com>
4715
4716         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4717         (i386_gnu_nat_target::store_registers): Update.
4718         * target-debug.h (target_debug_print_std_string): New macro.
4719         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4720         * windows-tdep.c (display_one_tib): Update.
4721         * tui/tui-stack.c (tui_make_status_line): Update.
4722         * top.c (print_inferior_quit_action): Update.
4723         * thread.c (thr_try_catch_cmd): Update.
4724         (add_thread_with_info): Update.
4725         (thread_target_id_str): Update.
4726         (thr_try_catch_cmd): Update.
4727         (thread_command): Update.
4728         (thread_find_command): Update.
4729         * record-btrace.c (record_btrace_target::info_record)
4730         (record_btrace_resume_thread, record_btrace_target::resume)
4731         (record_btrace_cancel_resume, record_btrace_step_thread)
4732         (record_btrace_target::wait, record_btrace_target::wait)
4733         (record_btrace_target::wait, record_btrace_target::stop): Update.
4734         * progspace.c (print_program_space): Update.
4735         * process-stratum-target.c
4736         (process_stratum_target::thread_address_space): Update.
4737         * linux-fork.c (linux_fork_mourn_inferior)
4738         (detach_checkpoint_command, info_checkpoints_command)
4739         (linux_fork_context): Update.
4740         (linux_fork_detach): Update.
4741         (class scoped_switch_fork_info): Update.
4742         (delete_checkpoint_command): Update.
4743         * infrun.c (follow_fork_inferior): Update.
4744         (follow_fork_inferior): Update.
4745         (proceed_after_vfork_done): Update.
4746         (handle_vfork_child_exec_or_exit): Update.
4747         (follow_exec): Update.
4748         (displaced_step_prepare_throw): Update.
4749         (displaced_step_restore): Update.
4750         (start_step_over): Update.
4751         (resume_1): Update.
4752         (clear_proceed_status_thread): Update.
4753         (proceed): Update.
4754         (print_target_wait_results): Update.
4755         (do_target_wait): Update.
4756         (context_switch): Update.
4757         (stop_all_threads): Update.
4758         (restart_threads): Update.
4759         (finish_step_over): Update.
4760         (handle_signal_stop): Update.
4761         (switch_back_to_stepped_thread): Update.
4762         (keep_going_pass_signal): Update.
4763         (print_exited_reason): Update.
4764         (normal_stop): Update.
4765         * inferior.c (inferior_pid_to_str): Change return type.
4766         (print_selected_inferior): Update.
4767         (add_inferior): Update.
4768         (detach_inferior): Update.
4769         * dummy-frame.c (fprint_dummy_frames): Update.
4770         * dcache.c (dcache_info_1): Update.
4771         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4772         (btrace_fetch, btrace_clear): Update.
4773         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4774         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4775         type.
4776         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4777         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4778         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4779         * gdbarch.c, gdbarch.h: Rebuild.
4780         * gdbarch.sh (core_pid_to_str): Change return type.
4781         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4782         return type.
4783         (windows_nat_target::pid_to_str): Change return type.
4784         (windows_delete_thread): Update.
4785         (windows_nat_target::attach): Update.
4786         (windows_nat_target::files_info): Update.
4787         * target-delegates.c: Rebuild.
4788         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4789         return type.
4790         (sol_thread_target::pid_to_str): Change return type.
4791         * remote.c (class remote_target) <pid_to_str>: Change return
4792         type.
4793         (remote_target::pid_to_str): Change return type.
4794         (extended_remote_target::attach, remote_target::remote_stop_ns)
4795         (remote_target::remote_notif_remove_queued_reply)
4796         (remote_target::push_stop_reply, remote_target::disable_btrace):
4797         Update.
4798         (extended_remote_target::attach): Update.
4799         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4800         type.
4801         (gdbsim_target::pid_to_str): Change return type.
4802         * ravenscar-thread.c (struct ravenscar_thread_target)
4803         <pid_to_str>: Change return type.
4804         (ravenscar_thread_target::pid_to_str): Change return type.
4805         * procfs.c (class procfs_target) <pid_to_str>: Change return
4806         type.
4807         (procfs_target::pid_to_str): Change return type.
4808         (procfs_target::attach): Update.
4809         (procfs_target::detach): Update.
4810         (procfs_target::fetch_registers): Update.
4811         (procfs_target::store_registers): Update.
4812         (procfs_target::wait): Update.
4813         (procfs_target::files_info): Update.
4814         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4815         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4816         return type.
4817         (nto_procfs_target::pid_to_str): Change return type.
4818         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4819         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4820         return type.
4821         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4822         (exit_lwp): Update.
4823         (attach_proc_task_lwp_callback, get_detach_signal)
4824         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4825         (linux_nat_target::resume, wait_lwp, stop_callback)
4826         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4827         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4828         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4829         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4830         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4831         type.
4832         (inf_ptrace_target::attach): Update.
4833         (inf_ptrace_target::files_info): Update.
4834         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4835         type.
4836         (go32_nat_target::pid_to_str): Change return type.
4837         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4838         (gnu_nat_target::wait): Update.
4839         (gnu_nat_target::wait): Update.
4840         (gnu_nat_target::resume): Update.
4841         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4842         (fbsd_nat_target::wait): Update.
4843         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4844         type.
4845         (darwin_nat_target::attach): Update.
4846         * corelow.c (class core_target) <pid_to_str>: Change return type.
4847         (core_target::pid_to_str): Change return type.
4848         * target.c (normal_pid_to_str): Change return type.
4849         (default_pid_to_str): Likewise.
4850         (target_pid_to_str): Change return type.
4851         (target_translate_tls_address): Update.
4852         (target_announce_detach): Update.
4853         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4854         return type.
4855         (bsd_uthread_target::pid_to_str): Change return type.
4856         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4857         type.
4858         (bsd_kvm_target::pid_to_str): Change return type.
4859         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4860         return type.
4861         (aix_thread_target::pid_to_str): Change return type.
4862         * target.h (struct target_ops) <pid_to_str>: Change return type.
4863         (target_pid_to_str, normal_pid_to_str): Likewise.
4864         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4865         type.
4866         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4867         type.
4868         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4869         return type.
4870         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4871         type.
4872         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4873         type.
4874         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4875         return type.
4876
4877 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4878
4879         * NEWS: Mention that the new default MI version is 3.  Mention
4880         changes to the output of commands and events that deal with
4881         multi-location breakpoints.
4882         * breakpoint.c: Include "mi/mi-out.h".
4883         (print_one_breakpoint): Change output syntax if using MI version
4884         >= 3.
4885         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4886         New.
4887         (mi_multi_location_breakpoint_output_fixed): New.
4888         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4889         (mi_cmd_fix_multi_location_breakpoint_output): New.
4890         (mi_multi_location_breakpoint_output_fixed): New.
4891         * mi/mi-cmds.c (mi_cmds): Register command
4892         -fix-multi-location-breakpoint-output.
4893         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4894         interpreter "mi".
4895
4896 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4897
4898         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4899         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4900         instantiate mi_ui_out based on interpreter name.
4901         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4902         * mi/mi-main.c (mi_load_progress): Likewise.
4903
4904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4905
4906         * NEWS: Combine separate "New targets" sections for 8.3.
4907
4908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4909
4910         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4911         (ppcfbsd_init_abi): Install gdbarch
4912         "fetch_tls_load_module_address" and "get_thread_local_address"
4913         methods.
4914
4915 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4916
4917         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4918         (riscv_fbsd_init_abi): Install gdbarch
4919         "fetch_tls_load_module_address" and "get_thread_local_address"
4920         methods.
4921
4922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4923
4924         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4925         (i386fbsd_init_abi): Install gdbarch
4926         "fetch_tls_load_module_address" and "get_thread_local_address"
4927         methods.
4928
4929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4930
4931         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4932         (amd64fbsd_init_abi): Install gdbarch
4933         "fetch_tls_load_module_address" and "get_thread_local_address"
4934         methods.
4935
4936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4937
4938         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4939         (struct fbsd_pspace_data): New type.
4940         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4941         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4942         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4943         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4944         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4945
4946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4947
4948         * gdbtypes.c (lookup_struct_elt): New function.
4949         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4950         * gdbtypes.h (struct struct_elt): New type.
4951         (lookup_struct_elt): New prototype.
4952
4953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4954
4955         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4956         remove disabled code block.
4957
4958 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4959
4960         * gdbarch.sh (get_thread_local_address): New method.
4961         * gdbarch.h, gdbarch.c: Regenerate.
4962         * target.c (target_translate_tls_address): Use
4963         gdbarch_get_thread_local_address if present instead of
4964         target::get_thread_local_address.
4965
4966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4967
4968         * target.h (target::get_thread_local_address): Update comment.
4969
4970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4971
4972         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4973         objfile->separate_debug_objfile_backlink if not NULL.
4974
4975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4976
4977         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4978         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4979         (amd64bsd_store_inferior_registers): Likewise.
4980         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4981         Enable segment base registers.
4982         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4983         PT_GETFSBASE and PT_GETGSBASE.
4984         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4985         PT_SETGSBASE.
4986         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4987         segment base registers.
4988         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4989
4990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4991
4992         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4993         Update calls to i386_target_description to add 'segments'
4994         parameter.
4995         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4996         add segment base registers.
4997         * arch/i386.c (i386_create_target_description): Add 'segments'
4998         parameter to enable segment base registers.
4999         * arch/i386.h (i386_create_target_description): Likewise.
5000         * features/i386/32bit-segments.xml: New file.
5001         * features/i386/32bit-segments.c: Generate.
5002         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5003         call to i386_target_description to add 'segments' parameter.
5004         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5005         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5006         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5007         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5008         if feature is present.
5009         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5010         Add 'segments' parameter to call to i386_target_description.
5011         (i386_target_description): Add 'segments' parameter to enable
5012         segment base registers.
5013         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5014         to call to i386_target_description.
5015         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5016         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5017         Define I386_NUM_REGS.
5018         (i386_target_description): Add 'segments' parameter to enable
5019         segment base registers.
5020
5021 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5022
5023         PR/24325
5024         * source-cache.c: #undef open and close, to avoid unresolved
5025         externals during linking.
5026
5027 2019-03-12  Tom Tromey  <tromey@adacore.com>
5028
5029         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5030         const.  Add initializers.
5031         (_initialize_remote): Don't initialize ptid globals.
5032
5033 2019-03-12  Pedro Alves  <palves@redhat.com>
5034
5035         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5036
5037 2019-03-12  Pedro Alves  <palves@redhat.com>
5038
5039         * cp-name-parser.y (main): Remove unused 'len' variable.
5040
5041 2019-03-12  Tom Tromey  <tromey@adacore.com>
5042
5043         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5044         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5045
5046 2019-03-12  Tom Tromey  <tromey@adacore.com>
5047
5048         * linux-nat.c (iterate_over_lwps): Update.
5049         (stop_callback): Remove parameter.
5050         (stop_wait_callback, detach_callback, resume_set_callback)
5051         (select_singlestep_lwp_callback, set_ignore_sigint)
5052         (status_callback, resumed_callback, resume_clear_callback)
5053         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5054         data parameter.
5055         (linux_nat_target::detach, linux_nat_target::resume)
5056         (linux_stop_and_wait_all_lwps, select_event_lwp)
5057         (linux_nat_filter_event, linux_nat_wait_1)
5058         (linux_nat_target::kill, linux_nat_target::stop)
5059         (linux_nat_target::stop): Update.
5060         (linux_nat_resume_callback): Change type.
5061         (resume_stopped_resumed_lwps, count_events_callback)
5062         (select_event_lwp_callback): Likewise.
5063         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5064         * arm-linux-nat.c (struct update_registers_data): Remove.
5065         (update_registers_callback): Change type.
5066         (arm_linux_insert_hw_breakpoint1): Update.
5067         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5068         parameter.
5069         (x86_linux_dr_set_addr): Update.
5070         (x86_linux_dr_set_control): Update.
5071         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5072         (iterate_over_lwps): Use gdb::function_view.
5073         * nat/aarch64-linux-hw-point.c (struct
5074         aarch64_dr_update_callback_param): Remove.
5075         (debug_reg_change_callback): Change type.
5076         (aarch64_notify_debug_reg_change): Update.
5077         * s390-linux-nat.c (s390_refresh_per_info): Update.
5078
5079 2019-03-11  Tom Tromey  <tromey@adacore.com>
5080
5081         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5082         redundant assignment to "this_cu".
5083
5084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5085
5086         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5087
5088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5089
5090         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5091         from...
5092         (rank_one_type): ... this.
5093
5094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5095
5096         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5097         from...
5098         (rank_one_type): ... this.
5099
5100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5101
5102         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5103         from...
5104         (rank_one_type): ... this.
5105
5106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5107
5108         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5109         from...
5110         (rank_one_type): ... this.
5111
5112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5113
5114         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5115         from...
5116         (rank_one_type): ... this.
5117
5118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5119
5120         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5121         from...
5122         (rank_one_type): ... this.
5123
5124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5125
5126         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5127         from...
5128         (rank_one_type): ... this.
5129
5130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5131
5132         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5133         from...
5134         (rank_one_type): ... this.
5135
5136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5137
5138         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5139         from...
5140         (rank_one_type): ... this.
5141
5142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5143
5144         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5145         from...
5146         (rank_one_type): ... this.
5147
5148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5149
5150         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5151         from...
5152         (rank_one_type): ... this.
5153
5154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5155
5156         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5157         from...
5158         (rank_one_type): ... this.
5159
5160 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5161
5162         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5163         inferior-events' shows the example events.
5164
5165 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5166
5167         Support styling on native MS-Windows console
5168
5169         PR/24315
5170         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5171         on MS-Windows if $TERM is not defined.
5172
5173         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5174
5175         * posix-hdep.c (gdb_console_fputs):
5176         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5177         functions.
5178         * ui-file.h (gdb_console_fputs): Add prototype.
5179
5180         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5181         back to fputs only if the former returns zero.
5182
5183 2019-03-07  Tom Tromey  <tom@tromey.com>
5184
5185         * symmisc.c (print_symbol_bcache_statistics): Update.
5186         (print_objfile_statistics): Update.
5187         * symfile.c (allocate_symtab): Update.
5188         * stabsread.c: Don't include bcache.h.
5189         * psymtab.h (struct psymbol_bcache): Don't declare.
5190         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5191         (psymbol_bcache_init, psymbol_bcache_free)
5192         (psymbol_bcache_get_bcache): Don't declare.
5193         * psymtab.c (struct psymbol_bcache): Remove.
5194         (psymtab_storage::psymtab_storage): Update.
5195         (psymtab_storage::~psymtab_storage): Update.
5196         (psymbol_bcache_init, psymbol_bcache_free)
5197         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5198         (add_psymbol_to_bcache): Update.
5199         (allocate_psymtab): Update.
5200         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5201         macro_cache>: No longer pointers.
5202         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5203         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5204         * macrotab.c (macro_bcache): Update.
5205         * macroexp.c: Don't include bcache.h.
5206         * gdbtypes.c (check_types_worklist): Update.
5207         (types_deeply_equal): Remove TRY/CATCH.  Update.
5208         * elfread.c (elf_symtab_read): Update.
5209         * dwarf2read.c: Don't include bcache.h.
5210         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5211         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5212         (print_bcache_statistics, bcache_memory_used): Don't declare.
5213         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5214         methods.  Rename all data members.
5215         * bcache.c (struct bcache): Move to bcache.h.
5216         (bcache::expand_hash_table): Rename from expand_hash_table.
5217         (bcache): Remove.
5218         (bcache::insert): Rename from bcache_full.
5219         (bcache::compare): Rename from bcache_compare.
5220         (bcache_xmalloc): Remove.
5221         (bcache::~bcache): Rename from bcache_xfree.
5222         (bcache::print_statistics): Rename from print_bcache_statistics.
5223         (bcache::memory_used): Rename from bcache_memory_used.
5224
5225 2019-03-07  Pedro Alves  <palves@redhat.com>
5226
5227         * infrun.c (normal_stop): Also check for
5228         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5229
5230 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * f-lang.c (value_from_host_double): Moved to...
5233         * value.c (value_from_host_double): ...here.
5234         * value.h (value_from_host_double): Declare.
5235         * guile/scm-math.c (vlscm_convert_typed_number): Use
5236         value_from_host_double.
5237         (vlscm_convert_number): Likewise.
5238         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5239         * python/py-value.c (convert_value_from_python): Likewise.
5240
5241 2019-03-06  Tom Tromey  <tom@tromey.com>
5242
5243         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5244
5245 2019-03-06  Tom Tromey  <tom@tromey.com>
5246
5247         * utils.h (free_current_contents): Don't declare.
5248         * utils.c (free_current_contents): Remove.
5249
5250 2019-03-06  Tom Tromey  <tom@tromey.com>
5251
5252         * top.c (quit_force): Update.
5253         * main.c (captured_command_loop): Update.
5254         * common/new-op.c (operator new): Update.
5255         * common/common-exceptions.c (struct catcher)
5256         <save_cleanup_chain>: Remove member.
5257         (exceptions_state_mc_init): Update.
5258         (exception_try_scope_entry): Return nullptr.
5259         (exception_try_scope_exit, exception_rethrow)
5260         (throw_exception_sjlj, throw_exception_cxx): Update.
5261         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5262         (all_cleanups, do_cleanups, discard_cleanups)
5263         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5264         (restore_cleanups, restore_final_cleanups): Don't declare.
5265         (do_final_cleanups): Remove parameter.
5266         * common/cleanups.c (cleanup_chain, make_cleanup)
5267         (make_cleanup_dtor, all_cleanups, do_cleanups)
5268         (discard_my_cleanups, discard_cleanups)
5269         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5270         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5271         (null_cleanup): Remove.
5272         (do_final_cleanups): Remove parameter.
5273
5274 2019-03-06  Tom Tromey  <tom@tromey.com>
5275
5276         * remote.c (remote_target::remote_parse_stop_reply): Use
5277         unique_xmalloc_ptr.
5278
5279 2019-03-06  Tom Tromey  <tom@tromey.com>
5280
5281         * stabsread.c (struct stabs_field_info): Rename from field_info.
5282         <list, fnlist>: Add initializers.
5283         <obstack>: New member.
5284         (read_member_functions, read_struct_fields, read_baseclasses):
5285         Allocate on obstack.  Don't use cleanups.
5286         (read_one_struct_field, read_member_functions, read_struct_fields)
5287         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5288         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5289         (read_struct_type): Update.
5290
5291 2019-03-06  Tom Tromey  <tom@tromey.com>
5292
5293         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5294         * common/filestuff.h (make_cleanup_close): Don't declare.
5295         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5296         Remove.
5297
5298 2019-03-06  Tom Tromey  <tom@tromey.com>
5299
5300         * solib-aix.c: Use make_scope_exit.
5301
5302 2019-03-06  Tom Tromey  <tom@tromey.com>
5303
5304         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5305         Use make_scope_exit.
5306
5307 2019-03-06  Tom Tromey  <tom@tromey.com>
5308
5309         * solib-svr4.c (disable_probes_interface): Remove parameter.
5310         (svr4_handle_solib_event): Use make_scope_exit.
5311
5312 2019-03-06  Tom Tromey  <tom@tromey.com>
5313
5314         * remote.c (struct stop_reply_deleter): Remove.
5315         (stop_reply_up): Update.
5316         (struct stop_reply): Derive from notif_event.  Don't typedef.
5317         <regcache>: Now a std::vector.
5318         (stop_reply_xfree): Remove.
5319         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5320         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5321         (remote_target::discard_pending_stop_replies): Use delete.
5322         (remote_target::remote_parse_stop_reply): Update.
5323         (remote_target::process_stop_reply): Update.
5324         * remote-notif.h (struct notif_event): Add virtual destructor.
5325         Remove "dtr" member.
5326         (struct notif_client) <alloc_event>: Return a unique_ptr.
5327         (notif_event_xfree): Don't declare.
5328         (notif_event_up): New typedef.
5329         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5330         (notif_event_xfree, do_notif_event_xfree): Remove.
5331         (remote_notif_state_xfree): Update.
5332
5333 2019-03-06  Tom Tromey  <tom@tromey.com>
5334
5335         * infrun.c (displaced_step_clear_cleanup): Now a
5336         forward_scope_exit type.
5337         (displaced_step_prepare_throw): Update.
5338         (displaced_step_fixup): Update.
5339
5340 2019-03-06  Tom Tromey  <tom@tromey.com>
5341
5342         * inferior.h (class inferior): Update comment.
5343         * gdbthread.h (class thread_info): Update comment.
5344
5345 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5346             Tom Tromey  <tom@tromey.com>
5347
5348         * stabsread.h (struct stab_section_list): Remove.
5349         (coffstab_build_psymtabs): Update.
5350         * dbxread.c (symbuf_sections): Now a std::vector.
5351         (sect_idx): New global.
5352         (fill_symbuf): Update.
5353         (coffstab_build_psymtabs): Change type of stabsects parameter.
5354         Update.
5355         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5356         std::vector.
5357         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5358         (coff_locate_sections): Update.
5359         (coff_symfile_read): Remove cleanups.  Update.
5360         (init_stringtab): Add storage parameter.
5361         (free_stringtab, free_stringtab_cleanup): Remove.
5362         (init_lineno): Add storage parameter.
5363         (free_linetab, free_linetab_cleanup): Remove.
5364
5365 2019-03-06  Pedro Alves  <palves@redhat.com>
5366
5367         * linux-fork.c (fork_info::clobber_regs): Delete.
5368         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5369         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5370         comment.  Adjust.
5371         (scoped_switch_fork_info::scoped_switch_fork_info)
5372         (checkpoint_command, linux_fork_context): Adjust
5373         fork_save_infrun_state calls.
5374
5375 2019-03-06  Pedro Alves  <palves@redhat.com>
5376
5377         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5378         (inf_has_multiple_threads): Return 'bool' and rewrite using
5379         inferior_info::threads().
5380
5381 2019-03-06  Pedro Alves  <palves@redhat.com>
5382
5383         * linux-fork.c: Include <list>.
5384         (fork_list): Now a std::list instance.
5385         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5386         (forks_exist_p, find_last_fork): Adjust.
5387         (new_fork): Delete.
5388         (one_fork_p): New.
5389         (add_fork): Adjust.
5390         (free_fork): Delete, folded into fork_info::~fork_info().
5391         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5392         Adjust.
5393         (init_fork_list): Delete.
5394         (linux_fork_killall, linux_fork_mourn_inferior)
5395         (linux_fork_detach, info_checkpoints_command): Adjust.
5396         (_initialize_linux_fork): No longer call init_fork_list.
5397
5398 2019-03-06  Pedro Alves  <palves@redhat.com>
5399
5400         * linux-fork.c (new_fork): New, split out of ...
5401         (add_fork): ... this.  Return void.  Move "first fork" special
5402         case from here, to ...
5403         (checkpoint_command): ... here.
5404         * linux-linux.h (add_fork): Return void.
5405
5406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5407
5408         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5409
5410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5411             Chris January  <chris.january@arm.com>
5412             David Lecomber  <david.lecomber@arm.com>
5413
5414         * f-exp.y: New token, UNOP_INTRINSIC.
5415         (exp): New pattern using UNOP_INTRINSIC token.
5416         (f77_keywords): Add 'abs' keyword.
5417         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5418         (value_from_host_double): New function.
5419         (evaluate_subexp_f): Support UNOP_ABS.
5420
5421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5424         types.
5425
5426 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5427
5428         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5429         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5430         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5431
5432 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5435
5436 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5437             Chris January  <chris.january@arm.com>
5438
5439         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5440         * f-exp.y: Define 'KIND' token.
5441         (exp): New pattern for KIND expressions.
5442         (ptype): Handle types with a kind extension.
5443         (direct_abs_decl): Extend to spot kind extensions.
5444         (f77_keywords): Add 'kind' to the list.
5445         (push_kind_type): New function.
5446         (convert_to_kind_type): New function.
5447         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5448         * parse.c (operator_length_standard): Likewise.
5449         * parser-defs.h (enum type_pieces): Add tp_kind.
5450         * std-operator.def: Add UNOP_KIND.
5451
5452 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5453
5454         * f-exp.y (f_parse): Set yydebug.
5455
5456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5457
5458         * f-lang.c (evaluate_subexp_f): New function.
5459         (exp_descriptor_f): New global.
5460         (f_language_defn): Use exp_descriptor_f instead of
5461         exp_descriptor_standard.
5462
5463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5464
5465         * f-exp.y (struct token): Add comments.
5466         (dot_ops): Remove uppercase versions and the end marker.
5467         (f77_keywords): Likewise.
5468         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5469         entries in the dot_ops array are case insensitive, and use
5470         strncasecmp to compare strings.  Also some whitespace cleanup in
5471         this area.  Similar for the f77_keywords array, except entries in
5472         this list might be case sensitive.
5473
5474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * f-exp.y (struct f77_boolean_val): Add comments.
5477         (boolean_values): Remove uppercase versions, and end marker.
5478         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5479         and use strncasecmp to achieve case insensitivity.  Additionally,
5480         perform whitespace cleanup around this code.
5481
5482 2019-03-06  Tom Tromey  <tromey@adacore.com>
5483
5484         * remote-sim.c (gdbsim_target_open): Use result of
5485         gdb_argv::release.
5486
5487 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5488         Dirk Schubert  <dirk.schubert@arm.com>
5489         Chris January  <chris.january@arm.com>
5490
5491         * eval.c (evaluate_subexp_standard): Call Fortran argument
5492         wrapping logic.
5493         * f-lang.c (struct value): A value which can be passed into a
5494         Fortran function call.
5495         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5496         where appropriate.
5497         (struct type): Value ready for a Fortran function call.
5498         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5499         is needed.
5500         * f-lang.h (fortran_argument_convert): Declaration.
5501         (fortran_preserve_arg_pointer): Declaration.
5502         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5503
5504 2019-03-05  Tom Tromey  <tromey@adacore.com>
5505
5506         * python/py-prettyprint.c (print_string_repr): Remove #if.
5507         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5508
5509 2019-03-05  Tom Tromey  <tromey@adacore.com>
5510
5511         * target.c (the_dummy_target): Move later.  Change type to
5512         "dummy_target".
5513         (initialize_targets): Don't initialize the_dummy_target.
5514
5515 2019-03-05  Tom Tromey  <tromey@adacore.com>
5516
5517         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5518         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5519
5520 2019-03-05  Tom Tromey  <tromey@adacore.com>
5521
5522         * windows-nat.c (windows_nat_target::attach)
5523         (windows_nat_target::detach): Don't call gdb_flush.
5524         * valprint.c (generic_val_print, val_print, val_print_string):
5525         Don't call gdb_flush.
5526         * utils.c (defaulted_query): Don't call gdb_flush.
5527         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5528         * target.c (target_announce_detach): Don't call gdb_flush.
5529         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5530         * remote.c (extended_remote_target::attach): Don't call
5531         gdb_flush.
5532         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5533         * printcmd.c (do_examine): Don't call gdb_flush.
5534         (info_display_command): Don't call gdb_flush.
5535         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5536         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5537         * memattr.c (info_mem_command): Don't call gdb_flush.
5538         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5539         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5540         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5541         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5542         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5543         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5544         (gnu_nat_target::detach): Don't call gdb_flush.
5545         * f-valprint.c (f_val_print): Don't call gdb_flush.
5546         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5547         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5548         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5549         gdb_flush.
5550         * c-valprint.c (c_val_print): Don't call gdb_flush.
5551         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5552
5553 2019-03-05  Tom Tromey  <tromey@adacore.com>
5554
5555         * varobj.c (update_dynamic_varobj_children): Update.
5556         (install_default_visualizer): Use reset, not release.
5557         * value.c (set_internalvar): Update.
5558         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5559         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5560         ATTRIBUTE_UNUSED_RESULT.
5561
5562 2019-03-05  Tom Tromey  <tromey@adacore.com>
5563
5564         * remote.c (class scoped_remote_fd) <release>: Add
5565         ATTRIBUTE_UNUSED_RESULT.
5566
5567 2019-03-05  Tom Tromey  <tromey@adacore.com>
5568
5569         * macroexp.c (struct macro_buffer) <release>: Add
5570         ATTRIBUTE_UNUSED_RESULT.
5571
5572 2019-03-05  Tom Tromey  <tromey@adacore.com>
5573
5574         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5575         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5576         ATTRIBUTE_UNUSED_RESULT.
5577
5578 2019-03-05  Tom Tromey  <tromey@adacore.com>
5579
5580         * common/scoped_fd.h (class scoped_fd) <release>: Add
5581         ATTRIBUTE_UNUSED_RESULT.
5582
5583 2019-03-05  Tom Tromey  <tromey@adacore.com>
5584
5585         * parser-defs.h (struct parser_state) <release>: Add
5586         ATTRIBUTE_UNUSED_RESULT.
5587
5588 2019-03-05  Tom Tromey  <tromey@adacore.com>
5589
5590         * utils.h (class gdb_argv) <release>: Add
5591         ATTRIBUTE_UNUSED_RESULT.
5592         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5593
5594 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5595
5596         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5597         for-loop range, to avoid compiler warnings.
5598
5599         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5600         avoid compiler warnings about unused variables.
5601
5602         * NEWS: Mention end of support for native debugging on MS-Windows
5603         before XP.
5604
5605         PR gdb/24292
5606         * common/netstuff.c:
5607         * gdbserver/gdbreplay.c
5608         * gdbserver/remote-utils.c:
5609         * ser-tcp.c:
5610         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5611         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5612         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5613         'getaddrinfo' and 'freeaddrinfo' were not available before
5614         Windows XP, and mingw.org's MinGW headers by default define
5615         _WIN32_WINNT to 0x500.
5616
5617 2019-03-01  Gary Benson <gbenson@redhat.com>
5618
5619         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5620
5621 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5622             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5623
5624         PR gdb/8527
5625         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5626         set_sigint_trap, clear_sigint_trap.
5627
5628 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5629
5630         * target.c (target_detach): Clear the regcache and the
5631         frame cache.
5632
5633 2019-02-27  Pedro Alves  <palves@redhat.com>
5634
5635         * utils.c (set_screen_size): When we cap the height/width sizes,
5636         tweak the corresponding command variable to show "unlimited":
5637
5638 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5639             Pedro Alves  <palves@redhat.com>
5640
5641         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5642         before calling rl_set_screen_size.
5643
5644 2019-02-27  Tom Tromey  <tromey@adacore.com>
5645
5646         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5647         define.
5648         * python/py-value.c: Remove Python 2.4 workaround.
5649         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5650         workaround.
5651         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5652         Python 2.4 workaround.
5653         * python/python-internal.h: Remove Python 2.4 comment.
5654         (Py_ssize_t): Don't define.
5655         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5656         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5657         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5658         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5659         * python/python.c (do_start_initialization): Remove Python 2.4
5660         workaround.
5661         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5662         (print_children): Remove Python 2.4 workaround.
5663         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5664         workaround.
5665         (CHARBUFFERPROC_NAME): Remove.
5666         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5667         Python 2.4 workaround.
5668
5669 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5670
5671         * NEWS: Note minimum Python version.
5672
5673 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5674
5675         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5676         code from these functions.  Remove corresponding ifdefs.  Use
5677         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5678         Remove gotos and target of gotos.
5679         (infpy_search_memory): Likewise.
5680
5681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5682
5683         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5684         (hppa_gdbarch_init): Don't register deleted functions with
5685         gdbarch.
5686
5687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5688
5689         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5690         (h8300_unwind_sp): Delete.
5691         (h8300_dummy_id): Delete.
5692         (h8300_gdbarch_init): Don't register deleted functions with
5693         gdbarch.
5694
5695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5698         (ft32_unwind_pc): Delete.
5699         (ft32_unwind_sp): Delete.
5700         (ft32_gdbarch_init): Don't register deleted functions with
5701         gdbarch.
5702
5703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5704
5705         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5706         (frv_unwind_pc): Delete.
5707         (frv_unwind_sp): Delete.
5708         (frv_gdbarch_init): Don't register deleted functions with
5709         gdbarch.
5710
5711 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5714         (riscv_unwind_pc): Delete.
5715         (riscv_unwind_sp): Delete.
5716         (riscv_gdbarch_init): Don't register deleted functions with
5717         gdbarch.
5718
5719 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5720
5721         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5722         (csky_unwind_pc): Delete.
5723         (csky_unwind_sp): Delete.
5724         (csky_gdbarch_init): Don't register deleted functions with
5725         gdbarch.
5726
5727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5730         (cris_unwind_pc): Delete.
5731         (cris_unwind_sp): Delete.
5732         (cris_gdbarch_init): Don't register deleted functions with
5733         gdbarch.
5734
5735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5738         (bfin_unwind_pc): Delete.
5739         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5740
5741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5744         (arm_unwind_pc): Delete.
5745         (arm_unwind_sp): Delete.
5746         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5747
5748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5749
5750         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5751         (arc_unwind_pc): Delete.
5752         (arc_unwind_sp): Delete.
5753         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5754
5755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5756
5757         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5758         (alpha_unwind_pc): Delete.
5759         (alpha_gdbarch_init): Don't register deleted functions with
5760         gdbarch.
5761
5762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5763
5764         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5765         (aarch64_unwind_pc): Delete.
5766         (aarch64_unwind_sp): Delete.
5767         (aarch64_gdbarch_init): Don't register deleted functions with
5768         gdbarch.
5769
5770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5771
5772         * gdbtypes.c (type_align): Don't consider static members when
5773         computing structure alignment.
5774
5775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5776
5777         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5778         return 0 for other types.
5779         * arch-utils.c (default_type_align): Always return 0.
5780         * gdbarch.h: Regenerate.
5781         * gdbarch.sh (type_align): Extend comment.
5782         * gdbtypes.c (type_align): Add additional comments, always call
5783         gdbarch_type_align before applying the default rules.
5784         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5785         generic code will then apply a suitable default.
5786         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5787         types, return 0 for other types.
5788
5789 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5790
5791         * NEWS: Create a new section for the next release branch.
5792         Rename the section of the current branch, now that it has
5793         been cut.
5794
5795 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5796
5797         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5798         * version.in: Bump version to 8.3.50.DATE-git.
5799
5800 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5801
5802         * aix-thread.c (ptid_cmp): Remove unused variable.
5803         (get_signaled_thread): Likewise.
5804         (store_regs_user_thread): Likewise.
5805         (store_regs_kernel_thread): Likewise.
5806         (fetch_regs_kernel_thread): Remove shadowed variable.
5807
5808 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5809
5810         * features/riscv/32bit-cpu.xml: Add register numbers.
5811         * features/riscv/32bit-fpu.c: Regenerate.
5812         * features/riscv/32bit-fpu.xml: Add register numbers.
5813         * features/riscv/64bit-cpu.xml: Add register numbers.
5814         * features/riscv/64bit-fpu.c: Regenerate.
5815         * features/riscv/64bit-fpu.xml: Add register numbers.
5816
5817 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5818
5819         * NEWS: Mention two argument form of gdb.Value constructor.
5820         * python/py-value.c (convert_buffer_and_type_to_value): New
5821         function.
5822         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5823         Add support for handling an optional second argument.  Call
5824         convert_buffer_and_type_to_value as appropriate.
5825         * python/python-internal.h (Py_buffer_deleter): New struct.
5826         (Py_buffer_up): New typedef.
5827
5828 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5829
5830         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5831         instead of releasing ownership.
5832
5833 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5834
5835         * dwarf2read.c (open_and_init_dwp_file): Call
5836         elf_numsections instead of bfd_count_sections to initialize
5837         dwp_file->num_sections.
5838
5839 2019-02-25  Tom Tromey  <tromey@adacore.com>
5840
5841         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5842
5843 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5844
5845         * gcore.in: Add '--readnever' option when invoking GDB.
5846
5847 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5848
5849         * MAINTAINERS: Update my email address.
5850
5851 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5852
5853         * build-id.c (build_id_to_debug_bfd_1): New function.
5854         (build_id_to_debug_bfd): Look for separate debug file in
5855         sysroot.
5856
5857 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * gdbarch.sh: Update the copyright year range that is placed into
5860         generated files.
5861
5862 2019-02-22  Keith Seitz  <keiths@redhat.com>
5863
5864         PR symtab/23853
5865         * linespec.c (create_sals_line_offset): Search for the default
5866         symtab's filename instead of its fullname.
5867
5868 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5869
5870         * NEWS: Update style defaults.
5871
5872 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5873
5874         * main.c (captured_main_1): Disable styling in batch mode.
5875
5876 2019-02-20  Tom Tromey  <tom@tromey.com>
5877
5878         * symtab.c (symtab_symbol_info): Fix typos.
5879
5880 2019-02-20  Tom Tromey  <tromey@adacore.com>
5881
5882         * findcmd.c (_initialize_mem_search): Use upper case for
5883         metasyntactic variables.
5884
5885 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5886
5887         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5888         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5889
5890 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5891
5892         * top.h (source_file_name): Change to std::string.
5893         * top.c (source_file_name): Likewise.
5894         (command_line_input): Adjust.
5895         * cli/cli-script.c (script_from_file): Adjust.
5896
5897 2019-02-19  Tom Tromey  <tromey@adacore.com>
5898
5899         * ravenscar-thread.c
5900         (ravenscar_thread_target::update_thread_list): Don't call
5901         ada_build_task_list.
5902         * ada-lang.h (ada_build_task_list): Don't declare.
5903         * ada-tasks.c (struct ada_tasks_inferior_data)
5904         <task_list_valid_p>: Now bool.
5905         (read_known_tasks, ada_task_list_changed)
5906         (ada_tasks_invalidate_inferior_data): Update.
5907         (read_known_tasks_array): Return bool.
5908         (read_known_tasks_list): Likewise.
5909         (read_known_tasks): Return void.
5910         (ada_build_task_list): Now static.
5911
5912 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5913
5914         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5915         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5916
5917 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5918
5919         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5920         variant for ada_tasks_pspace_data_handle and
5921         ada_tasks_inferior_data_handle.
5922         (ada_tasks_pspace_data_cleanup): New function.
5923         (ada_tasks_inferior_data_cleanup): New function.
5924
5925 2019-02-17  Tom Tromey  <tom@tromey.com>
5926
5927         * macrotab.h (macro_source_fullname): Return a std::string.
5928         * macrotab.c (macro_include, check_for_redefinition)
5929         (macro_undef, macro_lookup_definition, foreach_macro)
5930         (foreach_macro_in_scope): Update.
5931         (macro_source_fullname): Return a std::string.
5932         * macrocmd.c (show_pp_source_pos): Update.
5933
5934 2019-02-17  Tom Tromey  <tom@tromey.com>
5935
5936         * macrocmd.c (show_pp_source_pos): Style the file names.
5937
5938 2019-02-17  Tom Tromey  <tom@tromey.com>
5939
5940         PR tui/24197:
5941         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5942
5943 2019-02-17  Tom Tromey  <tom@tromey.com>
5944
5945         * ada-lang.c (user_select_syms): Use filtered printing.
5946         * utils.c (wrap_style): New global.
5947         (desired_style): Remove.
5948         (emit_style_escape): Add stream parameter.
5949         (set_output_style, reset_terminal_style, prompt_for_continue):
5950         Update.
5951         (flush_wrap_buffer): Only flush gdb_stdout.
5952         (wrap_here): Set wrap_style.
5953         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5954         treat escape sequences as a character.  Change when wrap buffer is
5955         flushed.
5956         (fputs_styled): Do not set the output style when the default is
5957         requested.
5958         * ui-style.h (struct ui_file_style) <is_default>: New method.
5959         * source.c (print_source_lines_base): Emit escape sequences in one
5960         piece.
5961
5962 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5963
5964         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5965         integers and enumeration types.
5966
5967 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5968
5969         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5970         instead of lookup_symbol_in_language
5971         (do_exact_match): New function.
5972         (ada_get_symbol_name_matcher): Return do_exact_match when
5973         doing a verbatim match.
5974
5975 2019-02-15  Tom Tromey  <tromey@adacore.com>
5976
5977         * ravenscar-thread.c (ravenscar_thread_target::resume)
5978         (ravenscar_thread_target::wait): Special case wildcard requests.
5979
5980 2019-02-15  Tom Tromey  <tromey@adacore.com>
5981
5982         * ravenscar-thread.c (base_ptid): Remove.
5983         (struct ravenscar_thread_target) <close>: New method.
5984         <m_base_ptid>: New member.
5985         <update_inferior_ptid, active_task, task_is_currently_active,
5986         runtime_initialized>: Declare methods.
5987         <ravenscar_thread_target>: Add constructor.
5988         (ravenscar_thread_target::task_is_currently_active)
5989         (ravenscar_thread_target::update_inferior_ptid)
5990         (ravenscar_runtime_initialized): Rename.  Now methods.
5991         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5992         (ravenscar_thread_target::update_thread_list): Update.
5993         (ravenscar_thread_target::active_task): Now method.
5994         (ravenscar_thread_target::store_registers)
5995         (ravenscar_thread_target::prepare_to_store)
5996         (ravenscar_thread_target::prepare_to_store)
5997         (ravenscar_thread_target::mourn_inferior): Update.
5998         (ravenscar_inferior_created): Use "new" to create target.
5999         (ravenscar_thread_target::get_ada_task_ptid): Update.
6000         (_initialize_ravenscar): Don't initialize base_ptid.
6001         (ravenscar_ops): Remove global.
6002
6003 2019-02-15  Tom Tromey  <tromey@adacore.com>
6004
6005         * target.h (push_target): Declare new overload.
6006         * target.c (push_target): New overload, taking an rvalue reference.
6007         * remote.c (remote_target::open_1): Use push_target overload.
6008         * corelow.c (core_target_open): Use push_target overload.
6009
6010 2019-02-15  Tom Tromey  <tromey@adacore.com>
6011
6012         * ravenscar-thread.c (is_ravenscar_task)
6013         (ravenscar_task_is_currently_active): Return bool.
6014         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6015         (_initialize_ravenscar): Remove "(void)".
6016         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6017         Return bool.
6018
6019 2019-02-15  Tom Tromey  <tromey@adacore.com>
6020
6021         * ravenscar-thread.c (ravenscar_runtime_initializer)
6022         (has_ravenscar_runtime, get_running_thread_id)
6023         (ravenscar_thread_target::resume): Fix indentation.
6024
6025 2019-02-15  Tom Tromey  <tromey@adacore.com>
6026
6027         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6028         from ravenscar_arch_ops.
6029         (sparc_ravenscar_ops::fetch_registers)
6030         (sparc_ravenscar_ops::store_registers): Now methods.
6031         (sparc_ravenscar_prepare_to_store): Remove.
6032         (sparc_ravenscar_ops): Redefine.
6033         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6034         methods and destructor.  Remove members.
6035         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6036         (ravenscar_thread_target::store_registers)
6037         (ravenscar_thread_target::prepare_to_store): Update.
6038         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6039         Remove.
6040         (struct ppc_ravenscar_powerpc_ops): Derive from
6041         ravenscar_arch_ops.
6042         (ppc_ravenscar_powerpc_ops::fetch_registers)
6043         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6044         (ppc_ravenscar_powerpc_ops): Redefine.
6045         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6046         (ppc_ravenscar_e500_ops::fetch_registers)
6047         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6048         (ppc_ravenscar_e500_ops): Redefine.
6049         * aarch64-ravenscar-thread.c
6050         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6051         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6052         (aarch64_ravenscar_fetch_registers)
6053         (aarch64_ravenscar_store_registers): Now methods.
6054         (aarch64_ravenscar_ops): Redefine.
6055
6056 2019-02-15  Tom Tromey  <tromey@adacore.com>
6057
6058         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6059         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6060         (ravenscar_thread_target::stopped_by_watchpoint)
6061         (ravenscar_thread_target::stopped_data_address)
6062         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6063
6064 2019-02-15  Tom Tromey  <tromey@adacore.com>
6065
6066         * ravenscar-thread.c: Fix some typos.
6067
6068 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6069             Tom Tromey  <tromey@adacore.com>
6070
6071         * ada-lang.c (ada_exception_sal): Change addr_string to a
6072         std::string.
6073         (create_ada_exception_catchpoint): Update.
6074
6075 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6076             Tom Tromey  <tromey@adacore.com>
6077
6078         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6079         (bp_location_ops): Remove.
6080         (base_breakpoint_allocate_location): Update.
6081         (free_bp_location): Update.
6082         * ada-lang.c (class ada_catchpoint_location)
6083         <ada_catchpoint_location>: Remove ops parameter.
6084         (ada_catchpoint_location_dtor): Remove.
6085         (ada_catchpoint_location_ops): Remove.
6086         (allocate_location_exception): Update.
6087         * breakpoint.h (struct bp_location_ops): Remove.
6088         (class bp_location) <bp_location>: Remove bp_location_ops
6089         parameter.
6090         <~bp_location>: Add destructor.
6091         <ops>: Remove.
6092
6093 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6094             Pedro Alves  <palves@redhat.com>
6095
6096         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6097         'PATH_MAX'.
6098
6099 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6100             Samuel Thibault  <samuel.thibault@gnu.org>
6101             Thomas Schwinge  <thomas@codesourcery.com>
6102
6103         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6104         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6105
6106 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6107
6108         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6109         (check_empty): Use "const char *".
6110
6111         * gnu-nat.c (gnu_nat_target::detach): Instead of
6112         'detach_inferior (pid)' call
6113         'detach_inferior (find_inferior_pid (pid))'.
6114
6115         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6116         'nat/fork-inferior.o'.
6117         * gnu-nat.c: #include "nat/fork-inferior.h".
6118
6119         * gnu-nat.c (gnu_nat_target::detach): Instead of
6120         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6121         * gnu-nat.h: #include "inf-child.h".
6122         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6123         'i386_gnu_nat_target::fetch_registers'.
6124         (gnu_store_registers): Rename/move to
6125         'i386_gnu_nat_target::store_registers'.
6126
6127         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6128         * gnu-nat.h (mach_thread_info): New function.
6129         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6130
6131         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6132
6133 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6134
6135         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6136
6137 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6138
6139         * windows-nat.c (windows_add_thread): Add new parameter
6140         "main_thread_p" with default value set to false.  Update
6141         function documentation as well as all callers.
6142         (windows_delete_thread): Likewise.
6143         (fake_create_process): Update call to windows_add_thread.
6144         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6145         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6146         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6147         call to windows_delete_thread.
6148
6149 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6150
6151         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6152
6153 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6154
6155         * symfile.c (find_separate_debug_file): Use canonical path of
6156         sysroot with child_path instead of gdb_sysroot if it is valid.
6157
6158 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6159
6160         * symfile.c (find_separate_debug_file): Use child_path to
6161         determine if an object file is under a sysroot.
6162
6163 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6164
6165         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6166         unittests/child-path-selftests.c.
6167         * common/pathstuff.c (child_path): New function.
6168         * common/pathstuff.h (child_path): New prototype.
6169         * unittests/child-path-selftests.c: New file.
6170
6171 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6172
6173         * symfile.c (find_separate_debug_file): Look for separate debug
6174         files in debug directories under the sysroot.
6175
6176 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6177
6178         * symtab.h (struct minimal_symbol data_p): New const method.
6179         (struct minimal_symbol text_p): Likewise.
6180         * symtab.c (output_source_filename): Use file name style
6181         to print file name.
6182         (print_symbol_info): Likewise.
6183         (print_msymbol_info): Use address style to print addresses.
6184         Use function name style to print executable text symbols.
6185         (expand_symtab_containing_pc): Use data_p.
6186         (find_pc_sect_compunit_symtab): Likewise.
6187
6188 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6189
6190         * breakpoint.c (describe_other_breakpoints): Use address style
6191         to print addresses.
6192         (say_where): Likewise.
6193
6194 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         * ada-typeprint.c (print_func_type): Print function name
6197         style to print function name.
6198         * c-typeprint.c (c_print_type_1): Likewise.
6199
6200 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6201
6202         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6203         for execve.
6204
6205 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6206
6207         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6208         type_stack.
6209
6210 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6211
6212         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6213         TYPE_CODE_REF types.
6214
6215 2019-02-08  Jim Wilson  <jimw@sifive.com>
6216
6217         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6218         (riscv_linux_fregset): New.
6219         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6220
6221 2019-02-07  Tom Tromey  <tom@tromey.com>
6222
6223         * thread.c (thread_cancel_execution_command): Update.
6224         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6225         methods.
6226         (struct thread_fsm_ops): Remove.
6227         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6228         (thread_fsm_should_stop, thread_fsm_return_value)
6229         (thread_fsm_set_finished, thread_fsm_finished_p)
6230         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6231         Don't declare.
6232         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6233         * infrun.c (clear_proceed_status_thread)
6234         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6235         (print_stop_event): Update.
6236         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6237         Add constructor.
6238         (step_command_fsm_ops): Remove.
6239         (new_step_command_fsm): Remove.
6240         (step_1): Update.
6241         (step_command_fsm::should_stop): Rename from
6242         step_command_fsm_should_stop.
6243         (step_command_fsm::clean_up): Rename from
6244         step_command_fsm_clean_up.
6245         (step_command_fsm::do_async_reply_reason): Rename from
6246         step_command_fsm_async_reply_reason.
6247         (struct until_next_fsm): Inherit from thread_fsm.  Add
6248         constructor.
6249         (until_next_fsm_ops): Remove.
6250         (new_until_next_fsm): Remove.
6251         (until_next_fsm::should_stop): Rename from
6252         until_next_fsm_should_stop.
6253         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6254         (until_next_fsm::do_async_reply_reason): Rename from
6255         until_next_fsm_async_reply_reason.
6256         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6257         constructor.  Change type of breakpoint.
6258         (finish_command_fsm_ops): Remove.
6259         (new_finish_command_fsm): Remove.
6260         (finish_command_fsm::should_stop): Rename from
6261         finish_command_fsm_should_stop.
6262         (finish_command_fsm::clean_up): Rename from
6263         finish_command_fsm_clean_up.
6264         (finish_command_fsm::return_value): Rename from
6265         finish_command_fsm_return_value.
6266         (finish_command_fsm::do_async_reply_reason): Rename from
6267         finish_command_fsm_async_reply_reason.
6268         (finish_command): Update.
6269         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6270         Add constructor.
6271         (call_thread_fsm_ops): Remove.
6272         (call_thread_fsm::call_thread_fsm): Rename from
6273         new_call_thread_fsm.
6274         (call_thread_fsm::should_stop): Rename from
6275         call_thread_fsm_should_stop.
6276         (call_thread_fsm::should_notify_stop): Rename from
6277         call_thread_fsm_should_notify_stop.
6278         (run_inferior_call, call_function_by_hand_dummy): Update.
6279         * cli/cli-interp.c (should_print_stop_to_console): Update.
6280         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6281         Add constructor.  Change type of location_breakpoint,
6282         caller_breakpoint.
6283         (until_break_fsm_ops): Remove.
6284         (new_until_break_fsm): Remove.
6285         (until_break_fsm::should_stop): Rename from
6286         until_break_fsm_should_stop.
6287         (until_break_fsm::clean_up): Rename from
6288         until_break_fsm_clean_up.
6289         (until_break_fsm::do_async_reply_reason): Rename from
6290         until_break_fsm_async_reply_reason.
6291         (until_break_command): Update.
6292         * thread-fsm.c: Remove.
6293         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6294
6295 2019-02-07  Tom Tromey  <tom@tromey.com>
6296
6297         * yy-remap.h: Add include guard.
6298         * xtensa-tdep.h: Add include guard.
6299         * xcoffread.h: Rename include guard.
6300         * varobj-iter.h: Add include guard.
6301         * tui/tui.h: Rename include guard.
6302         * tui/tui-winsource.h: Rename include guard.
6303         * tui/tui-wingeneral.h: Rename include guard.
6304         * tui/tui-windata.h: Rename include guard.
6305         * tui/tui-win.h: Rename include guard.
6306         * tui/tui-stack.h: Rename include guard.
6307         * tui/tui-source.h: Rename include guard.
6308         * tui/tui-regs.h: Rename include guard.
6309         * tui/tui-out.h: Rename include guard.
6310         * tui/tui-layout.h: Rename include guard.
6311         * tui/tui-io.h: Rename include guard.
6312         * tui/tui-hooks.h: Rename include guard.
6313         * tui/tui-file.h: Rename include guard.
6314         * tui/tui-disasm.h: Rename include guard.
6315         * tui/tui-data.h: Rename include guard.
6316         * tui/tui-command.h: Rename include guard.
6317         * tic6x-tdep.h: Add include guard.
6318         * target/waitstatus.h: Rename include guard.
6319         * target/wait.h: Rename include guard.
6320         * target/target.h: Rename include guard.
6321         * target/resume.h: Rename include guard.
6322         * target-float.h: Rename include guard.
6323         * stabsread.h: Add include guard.
6324         * rs6000-tdep.h: Add include guard.
6325         * riscv-fbsd-tdep.h: Add include guard.
6326         * regformats/regdef.h: Rename include guard.
6327         * record.h: Rename include guard.
6328         * python/python.h: Rename include guard.
6329         * python/python-internal.h: Rename include guard.
6330         * python/py-stopevent.h: Rename include guard.
6331         * python/py-ref.h: Rename include guard.
6332         * python/py-record.h: Rename include guard.
6333         * python/py-record-full.h: Rename include guard.
6334         * python/py-record-btrace.h: Rename include guard.
6335         * python/py-instruction.h: Rename include guard.
6336         * python/py-events.h: Rename include guard.
6337         * python/py-event.h: Rename include guard.
6338         * procfs.h: Add include guard.
6339         * proc-utils.h: Add include guard.
6340         * p-lang.h: Add include guard.
6341         * or1k-tdep.h: Rename include guard.
6342         * observable.h: Rename include guard.
6343         * nto-tdep.h: Rename include guard.
6344         * nat/x86-linux.h: Rename include guard.
6345         * nat/x86-linux-dregs.h: Rename include guard.
6346         * nat/x86-gcc-cpuid.h: Add include guard.
6347         * nat/x86-dregs.h: Rename include guard.
6348         * nat/x86-cpuid.h: Rename include guard.
6349         * nat/ppc-linux.h: Rename include guard.
6350         * nat/mips-linux-watch.h: Rename include guard.
6351         * nat/linux-waitpid.h: Rename include guard.
6352         * nat/linux-ptrace.h: Rename include guard.
6353         * nat/linux-procfs.h: Rename include guard.
6354         * nat/linux-osdata.h: Rename include guard.
6355         * nat/linux-nat.h: Rename include guard.
6356         * nat/linux-namespaces.h: Rename include guard.
6357         * nat/linux-btrace.h: Rename include guard.
6358         * nat/glibc_thread_db.h: Rename include guard.
6359         * nat/gdb_thread_db.h: Rename include guard.
6360         * nat/gdb_ptrace.h: Rename include guard.
6361         * nat/fork-inferior.h: Rename include guard.
6362         * nat/amd64-linux-siginfo.h: Rename include guard.
6363         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6364         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6365         * nat/aarch64-linux.h: Rename include guard.
6366         * nat/aarch64-linux-hw-point.h: Rename include guard.
6367         * mn10300-tdep.h: Add include guard.
6368         * mips-linux-tdep.h: Add include guard.
6369         * mi/mi-parse.h: Rename include guard.
6370         * mi/mi-out.h: Rename include guard.
6371         * mi/mi-main.h: Rename include guard.
6372         * mi/mi-interp.h: Rename include guard.
6373         * mi/mi-getopt.h: Rename include guard.
6374         * mi/mi-console.h: Rename include guard.
6375         * mi/mi-common.h: Rename include guard.
6376         * mi/mi-cmds.h: Rename include guard.
6377         * mi/mi-cmd-break.h: Rename include guard.
6378         * m2-lang.h: Add include guard.
6379         * location.h: Rename include guard.
6380         * linux-record.h: Rename include guard.
6381         * linux-nat.h: Add include guard.
6382         * linux-fork.h: Add include guard.
6383         * i386-darwin-tdep.h: Rename include guard.
6384         * hppa-linux-offsets.h: Add include guard.
6385         * guile/guile.h: Rename include guard.
6386         * guile/guile-internal.h: Rename include guard.
6387         * gnu-nat.h: Rename include guard.
6388         * gdb-stabs.h: Rename include guard.
6389         * frv-tdep.h: Add include guard.
6390         * f-lang.h: Add include guard.
6391         * event-loop.h: Add include guard.
6392         * darwin-nat.h: Rename include guard.
6393         * cp-abi.h: Rename include guard.
6394         * config/sparc/nm-sol2.h: Rename include guard.
6395         * config/nm-nto.h: Rename include guard.
6396         * config/nm-linux.h: Add include guard.
6397         * config/i386/nm-i386gnu.h: Rename include guard.
6398         * config/djgpp/nl_types.h: Rename include guard.
6399         * config/djgpp/langinfo.h: Rename include guard.
6400         * compile/gcc-cp-plugin.h: Add include guard.
6401         * compile/gcc-c-plugin.h: Add include guard.
6402         * compile/compile.h: Rename include guard.
6403         * compile/compile-object-run.h: Rename include guard.
6404         * compile/compile-object-load.h: Rename include guard.
6405         * compile/compile-internal.h: Rename include guard.
6406         * compile/compile-cplus.h: Rename include guard.
6407         * compile/compile-c.h: Rename include guard.
6408         * common/xml-utils.h: Rename include guard.
6409         * common/x86-xstate.h: Rename include guard.
6410         * common/version.h: Rename include guard.
6411         * common/vec.h: Rename include guard.
6412         * common/tdesc.h: Rename include guard.
6413         * common/selftest.h: Rename include guard.
6414         * common/scoped_restore.h: Rename include guard.
6415         * common/scoped_mmap.h: Rename include guard.
6416         * common/scoped_fd.h: Rename include guard.
6417         * common/safe-iterator.h: Rename include guard.
6418         * common/run-time-clock.h: Rename include guard.
6419         * common/refcounted-object.h: Rename include guard.
6420         * common/queue.h: Rename include guard.
6421         * common/ptid.h: Rename include guard.
6422         * common/print-utils.h: Rename include guard.
6423         * common/preprocessor.h: Rename include guard.
6424         * common/pathstuff.h: Rename include guard.
6425         * common/observable.h: Rename include guard.
6426         * common/netstuff.h: Rename include guard.
6427         * common/job-control.h: Rename include guard.
6428         * common/host-defs.h: Rename include guard.
6429         * common/gdb_wait.h: Rename include guard.
6430         * common/gdb_vecs.h: Rename include guard.
6431         * common/gdb_unlinker.h: Rename include guard.
6432         * common/gdb_unique_ptr.h: Rename include guard.
6433         * common/gdb_tilde_expand.h: Rename include guard.
6434         * common/gdb_sys_time.h: Rename include guard.
6435         * common/gdb_string_view.h: Rename include guard.
6436         * common/gdb_splay_tree.h: Rename include guard.
6437         * common/gdb_setjmp.h: Rename include guard.
6438         * common/gdb_ref_ptr.h: Rename include guard.
6439         * common/gdb_optional.h: Rename include guard.
6440         * common/gdb_locale.h: Rename include guard.
6441         * common/gdb_assert.h: Rename include guard.
6442         * common/filtered-iterator.h: Rename include guard.
6443         * common/filestuff.h: Rename include guard.
6444         * common/fileio.h: Rename include guard.
6445         * common/environ.h: Rename include guard.
6446         * common/common-utils.h: Rename include guard.
6447         * common/common-types.h: Rename include guard.
6448         * common/common-regcache.h: Rename include guard.
6449         * common/common-inferior.h: Rename include guard.
6450         * common/common-gdbthread.h: Rename include guard.
6451         * common/common-exceptions.h: Rename include guard.
6452         * common/common-defs.h: Rename include guard.
6453         * common/common-debug.h: Rename include guard.
6454         * common/cleanups.h: Rename include guard.
6455         * common/buffer.h: Rename include guard.
6456         * common/btrace-common.h: Rename include guard.
6457         * common/break-common.h: Rename include guard.
6458         * cli/cli-utils.h: Rename include guard.
6459         * cli/cli-style.h: Rename include guard.
6460         * cli/cli-setshow.h: Rename include guard.
6461         * cli/cli-script.h: Rename include guard.
6462         * cli/cli-interp.h: Rename include guard.
6463         * cli/cli-decode.h: Rename include guard.
6464         * cli/cli-cmds.h: Rename include guard.
6465         * charset-list.h: Add include guard.
6466         * buildsym-legacy.h: Rename include guard.
6467         * bfin-tdep.h: Add include guard.
6468         * ax.h: Rename include guard.
6469         * arm-linux-tdep.h: Add include guard.
6470         * arm-fbsd-tdep.h: Add include guard.
6471         * arch/xtensa.h: Rename include guard.
6472         * arch/tic6x.h: Add include guard.
6473         * arch/i386.h: Add include guard.
6474         * arch/arm.h: Rename include guard.
6475         * arch/arm-linux.h: Rename include guard.
6476         * arch/arm-get-next-pcs.h: Rename include guard.
6477         * arch/amd64.h: Add include guard.
6478         * arch/aarch64-insn.h: Rename include guard.
6479         * arch-utils.h: Rename include guard.
6480         * annotate.h: Add include guard.
6481         * amd64-darwin-tdep.h: Rename include guard.
6482         * aarch64-linux-tdep.h: Add include guard.
6483         * aarch64-fbsd-tdep.h: Add include guard.
6484         * aarch32-linux-nat.h: Add include guard.
6485
6486 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6487
6488         * macrotab.c (macro_define_internal): New function that
6489         factorizes macro_define_object_internal and macro_define_function
6490         code.
6491         (macro_define_object_internal): Use macro_define_internal.
6492         (macro_define_function): Likewise.
6493
6494 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6495
6496         * macrocmd.c (extract_identifier): Return
6497         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6498         callers.
6499
6500 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6501
6502         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6503
6504 2019-02-05  Tom Tromey  <tom@tromey.com>
6505
6506         * target.c (target_stack::unpush): Move assertion earlier.
6507
6508 2019-01-30  Tom Tromey  <tom@tromey.com>
6509
6510         PR python/23615:
6511         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6512         (gdbpy_parse_and_eval): Likewise.
6513         * python/python-internal.h (gdbpy_allow_threads): New class.
6514
6515 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6516
6517         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6518         (aarch64_fbsd_fpregmap): Move earlier.
6519         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6520         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6521         instead of individual calls to trad_frame_set_reg_addr.
6522         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6523         earlier.
6524         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6525         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6526         instead of individual calls to trad_frame_set_reg_addr.
6527
6528 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6529
6530         * CONTRIBUTE: Replace contribution list with wiki link.
6531
6532 2019-01-25  Tom Tromey  <tom@tromey.com>
6533
6534         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6535
6536 2019-01-25  Tom Tromey  <tom@tromey.com>
6537
6538         * xtensa-linux-nat.c: Fix common/ includes.
6539         * xml-support.h: Fix common/ includes.
6540         * xml-support.c: Fix common/ includes.
6541         * x86-linux-nat.c: Fix common/ includes.
6542         * windows-nat.c: Fix common/ includes.
6543         * varobj.h: Fix common/ includes.
6544         * varobj.c: Fix common/ includes.
6545         * value.c: Fix common/ includes.
6546         * valops.c: Fix common/ includes.
6547         * utils.c: Fix common/ includes.
6548         * unittests/xml-utils-selftests.c: Fix common/ includes.
6549         * unittests/utils-selftests.c: Fix common/ includes.
6550         * unittests/unpack-selftests.c: Fix common/ includes.
6551         * unittests/tracepoint-selftests.c: Fix common/ includes.
6552         * unittests/style-selftests.c: Fix common/ includes.
6553         * unittests/string_view-selftests.c: Fix common/ includes.
6554         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6555         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6556         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6557         * unittests/rsp-low-selftests.c: Fix common/ includes.
6558         * unittests/parse-connection-spec-selftests.c: Fix common/
6559         includes.
6560         * unittests/optional-selftests.c: Fix common/ includes.
6561         * unittests/offset-type-selftests.c: Fix common/ includes.
6562         * unittests/observable-selftests.c: Fix common/ includes.
6563         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6564         * unittests/memrange-selftests.c: Fix common/ includes.
6565         * unittests/memory-map-selftests.c: Fix common/ includes.
6566         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6567         * unittests/function-view-selftests.c: Fix common/ includes.
6568         * unittests/environ-selftests.c: Fix common/ includes.
6569         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6570         * unittests/common-utils-selftests.c: Fix common/ includes.
6571         * unittests/cli-utils-selftests.c: Fix common/ includes.
6572         * unittests/array-view-selftests.c: Fix common/ includes.
6573         * ui-file.c: Fix common/ includes.
6574         * tui/tui-io.c: Fix common/ includes.
6575         * tracepoint.h: Fix common/ includes.
6576         * tracepoint.c: Fix common/ includes.
6577         * tracefile-tfile.c: Fix common/ includes.
6578         * top.h: Fix common/ includes.
6579         * top.c: Fix common/ includes.
6580         * thread.c: Fix common/ includes.
6581         * target/waitstatus.h: Fix common/ includes.
6582         * target/waitstatus.c: Fix common/ includes.
6583         * target.h: Fix common/ includes.
6584         * target.c: Fix common/ includes.
6585         * target-memory.c: Fix common/ includes.
6586         * target-descriptions.c: Fix common/ includes.
6587         * symtab.h: Fix common/ includes.
6588         * symfile.c: Fix common/ includes.
6589         * stap-probe.c: Fix common/ includes.
6590         * spu-linux-nat.c: Fix common/ includes.
6591         * sparc-nat.c: Fix common/ includes.
6592         * source.c: Fix common/ includes.
6593         * solib.c: Fix common/ includes.
6594         * solib-target.c: Fix common/ includes.
6595         * ser-unix.c: Fix common/ includes.
6596         * ser-tcp.c: Fix common/ includes.
6597         * ser-pipe.c: Fix common/ includes.
6598         * ser-base.c: Fix common/ includes.
6599         * selftest-arch.c: Fix common/ includes.
6600         * s12z-tdep.c: Fix common/ includes.
6601         * rust-exp.y: Fix common/ includes.
6602         * rs6000-aix-tdep.c: Fix common/ includes.
6603         * riscv-tdep.c: Fix common/ includes.
6604         * remote.c: Fix common/ includes.
6605         * remote-notif.h: Fix common/ includes.
6606         * remote-fileio.h: Fix common/ includes.
6607         * remote-fileio.c: Fix common/ includes.
6608         * regcache.h: Fix common/ includes.
6609         * regcache.c: Fix common/ includes.
6610         * record-btrace.c: Fix common/ includes.
6611         * python/python.c: Fix common/ includes.
6612         * python/py-type.c: Fix common/ includes.
6613         * python/py-inferior.c: Fix common/ includes.
6614         * progspace.h: Fix common/ includes.
6615         * producer.c: Fix common/ includes.
6616         * procfs.c: Fix common/ includes.
6617         * proc-api.c: Fix common/ includes.
6618         * printcmd.c: Fix common/ includes.
6619         * ppc-linux-nat.c: Fix common/ includes.
6620         * parser-defs.h: Fix common/ includes.
6621         * osdata.c: Fix common/ includes.
6622         * obsd-nat.c: Fix common/ includes.
6623         * nat/x86-linux.c: Fix common/ includes.
6624         * nat/x86-linux-dregs.c: Fix common/ includes.
6625         * nat/x86-dregs.h: Fix common/ includes.
6626         * nat/x86-dregs.c: Fix common/ includes.
6627         * nat/ppc-linux.c: Fix common/ includes.
6628         * nat/mips-linux-watch.h: Fix common/ includes.
6629         * nat/mips-linux-watch.c: Fix common/ includes.
6630         * nat/linux-waitpid.c: Fix common/ includes.
6631         * nat/linux-ptrace.h: Fix common/ includes.
6632         * nat/linux-ptrace.c: Fix common/ includes.
6633         * nat/linux-procfs.c: Fix common/ includes.
6634         * nat/linux-personality.c: Fix common/ includes.
6635         * nat/linux-osdata.c: Fix common/ includes.
6636         * nat/linux-namespaces.c: Fix common/ includes.
6637         * nat/linux-btrace.h: Fix common/ includes.
6638         * nat/linux-btrace.c: Fix common/ includes.
6639         * nat/fork-inferior.c: Fix common/ includes.
6640         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6641         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6642         * nat/aarch64-linux.c: Fix common/ includes.
6643         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6644         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6645         * namespace.h: Fix common/ includes.
6646         * mips-linux-tdep.c: Fix common/ includes.
6647         * minsyms.c: Fix common/ includes.
6648         * mi/mi-parse.h: Fix common/ includes.
6649         * mi/mi-main.c: Fix common/ includes.
6650         * mi/mi-cmd-env.c: Fix common/ includes.
6651         * memrange.h: Fix common/ includes.
6652         * memattr.c: Fix common/ includes.
6653         * maint.h: Fix common/ includes.
6654         * maint.c: Fix common/ includes.
6655         * main.c: Fix common/ includes.
6656         * machoread.c: Fix common/ includes.
6657         * location.c: Fix common/ includes.
6658         * linux-thread-db.c: Fix common/ includes.
6659         * linux-nat.c: Fix common/ includes.
6660         * linux-fork.c: Fix common/ includes.
6661         * inline-frame.c: Fix common/ includes.
6662         * infrun.c: Fix common/ includes.
6663         * inflow.c: Fix common/ includes.
6664         * inferior.h: Fix common/ includes.
6665         * inferior.c: Fix common/ includes.
6666         * infcmd.c: Fix common/ includes.
6667         * inf-ptrace.c: Fix common/ includes.
6668         * inf-child.c: Fix common/ includes.
6669         * ia64-linux-nat.c: Fix common/ includes.
6670         * i387-tdep.c: Fix common/ includes.
6671         * i386-tdep.c: Fix common/ includes.
6672         * i386-linux-tdep.c: Fix common/ includes.
6673         * i386-linux-nat.c: Fix common/ includes.
6674         * i386-go32-tdep.c: Fix common/ includes.
6675         * i386-fbsd-tdep.c: Fix common/ includes.
6676         * i386-fbsd-nat.c: Fix common/ includes.
6677         * guile/scm-type.c: Fix common/ includes.
6678         * guile/guile.c: Fix common/ includes.
6679         * go32-nat.c: Fix common/ includes.
6680         * gnu-nat.c: Fix common/ includes.
6681         * gdbthread.h: Fix common/ includes.
6682         * gdbarch-selftests.c: Fix common/ includes.
6683         * gdb_usleep.c: Fix common/ includes.
6684         * gdb_select.h: Fix common/ includes.
6685         * gdb_bfd.c: Fix common/ includes.
6686         * gcore.c: Fix common/ includes.
6687         * fork-child.c: Fix common/ includes.
6688         * findvar.c: Fix common/ includes.
6689         * fbsd-nat.c: Fix common/ includes.
6690         * event-top.c: Fix common/ includes.
6691         * event-loop.c: Fix common/ includes.
6692         * dwarf2read.c: Fix common/ includes.
6693         * dwarf2loc.c: Fix common/ includes.
6694         * dwarf2-frame.c: Fix common/ includes.
6695         * dwarf-index-cache.c: Fix common/ includes.
6696         * dtrace-probe.c: Fix common/ includes.
6697         * disasm-selftests.c: Fix common/ includes.
6698         * defs.h: Fix common/ includes.
6699         * csky-tdep.c: Fix common/ includes.
6700         * cp-valprint.c: Fix common/ includes.
6701         * cp-support.h: Fix common/ includes.
6702         * cp-support.c: Fix common/ includes.
6703         * corelow.c: Fix common/ includes.
6704         * completer.h: Fix common/ includes.
6705         * completer.c: Fix common/ includes.
6706         * compile/compile.c: Fix common/ includes.
6707         * compile/compile-loc2c.c: Fix common/ includes.
6708         * compile/compile-cplus-types.c: Fix common/ includes.
6709         * compile/compile-cplus-symbols.c: Fix common/ includes.
6710         * command.h: Fix common/ includes.
6711         * cli/cli-dump.c: Fix common/ includes.
6712         * cli/cli-cmds.c: Fix common/ includes.
6713         * charset.c: Fix common/ includes.
6714         * build-id.c: Fix common/ includes.
6715         * btrace.h: Fix common/ includes.
6716         * btrace.c: Fix common/ includes.
6717         * breakpoint.h: Fix common/ includes.
6718         * breakpoint.c: Fix common/ includes.
6719         * ax.h:
6720         (enum agent_op): Fix common/ includes.
6721         * ax-general.c (struct aop_map): Fix common/ includes.
6722         * ax-gdb.c: Fix common/ includes.
6723         * auxv.c: Fix common/ includes.
6724         * auto-load.c: Fix common/ includes.
6725         * arm-tdep.c: Fix common/ includes.
6726         * arch/riscv.c: Fix common/ includes.
6727         * arch/ppc-linux-common.c: Fix common/ includes.
6728         * arch/i386.c: Fix common/ includes.
6729         * arch/arm.c: Fix common/ includes.
6730         * arch/arm-linux.c: Fix common/ includes.
6731         * arch/arm-get-next-pcs.c: Fix common/ includes.
6732         * arch/amd64.c: Fix common/ includes.
6733         * arch/aarch64.c: Fix common/ includes.
6734         * arch/aarch64-insn.c: Fix common/ includes.
6735         * arch-utils.c: Fix common/ includes.
6736         * amd64-windows-tdep.c: Fix common/ includes.
6737         * amd64-tdep.c: Fix common/ includes.
6738         * amd64-sol2-tdep.c: Fix common/ includes.
6739         * amd64-obsd-tdep.c: Fix common/ includes.
6740         * amd64-nbsd-tdep.c: Fix common/ includes.
6741         * amd64-linux-tdep.c: Fix common/ includes.
6742         * amd64-linux-nat.c: Fix common/ includes.
6743         * amd64-fbsd-tdep.c: Fix common/ includes.
6744         * amd64-fbsd-nat.c: Fix common/ includes.
6745         * amd64-dicos-tdep.c: Fix common/ includes.
6746         * amd64-darwin-tdep.c: Fix common/ includes.
6747         * agent.c: Fix common/ includes.
6748         * ada-lang.h: Fix common/ includes.
6749         * ada-lang.c: Fix common/ includes.
6750         * aarch64-tdep.c: Fix common/ includes.
6751
6752 2019-01-25  Tom Tromey  <tom@tromey.com>
6753
6754         * common/create-version.sh: Use common/version.h.
6755
6756 2019-01-24  Pedro Alves  <palves@redhat.com>
6757
6758         * infrun.c (signal_stop, signal_print, signal_program)
6759         (signal_catch, signal_pass): Now arrays instead of pointers.
6760         (update_signals_program_target, do_target_resume)
6761         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6762         * linux-nat.c (linux_nat_target::pass_signals)
6763         (linux_nat_target::create_inferior, linux_nat_target::attach):
6764         Adjust.
6765         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6766         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6767         * procfs.c (procfs_target::pass_signals): Adjust.
6768         * record-full.c (record_full_target::resume): Adjust.
6769         * remote.c (remote_target::pass_signals)
6770         (remote_target::program_signals): Adjust.
6771         * target-debug.h (target_debug_print_signals): Now takes a
6772         gdb::array_view as parameter.  Adjust.
6773         * target.h (target_ops) <pass_signals, program_signals>: Replace
6774         pointer and length parameters with gdb::array_view.
6775         (target_pass_signals, target_program_signals): Likewise.
6776         * target-delegates.c: Regenerate.
6777
6778 2019-01-24  Pedro Alves  <palves@redhat.com>
6779
6780         * common/forward-scope-exit.h
6781         (forward_scope_exit::forward_scope_exit): Pass arguments to
6782         m_bind_function directly, instead of creating a std::bind and
6783         copying that.
6784
6785 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6786
6787         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6788         for static members.
6789         (pass_in_v_vfp_candidate): Likewise.
6790
6791 2019-01-23  Tom Tromey  <tom@tromey.com>
6792             Pedro Alves  <palves@redhat.com>
6793
6794         * regcache.c (class regcache_invalidator): Remove.
6795         (regcache::raw_write): Use make_scope_exit.
6796
6797 2019-01-23  Tom Tromey  <tom@tromey.com>
6798
6799         * ui-out.h (class ui_out_emit_type): Update comment.
6800
6801 2019-01-23  Tom Tromey  <tom@tromey.com>
6802
6803         * infrun.c (fetch_inferior_event): Update comment.
6804
6805 2019-01-23  Tom Tromey  <tom@tromey.com>
6806             Pedro Alves  <palves@redhat.com>
6807
6808         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6809         parameter.
6810         (fetch_inferior_event): Use SCOPE_EXIT.
6811
6812
6813 2019-01-23  Tom Tromey  <tom@tromey.com>
6814             Pedro Alves  <palves@redhat.com>
6815
6816         * infrun.c (disable_thread_events): Delete.
6817         (stop_all_threads): Use SCOPE_EXIT.
6818
6819 2019-01-23  Tom Tromey  <tom@tromey.com>
6820             Pedro Alves  <palves@redhat.com>
6821
6822         * symfile.c: Include forward-scope-exit.h.
6823         (clear_symtab_users_cleanup): Replace forward declaration with
6824         a FORWARD_SCOPE_EXIT.
6825         (syms_from_objfile_1): Use the forward_scope_exit and
6826         gdb::optional instead of cleanup_function.
6827         (reread_symbols): Use the forward_scope_exit instead of
6828         cleanup_function.
6829         (clear_symtab_users_cleanup): Remove function.
6830
6831 2019-01-23  Tom Tromey  <tom@tromey.com>
6832             Pedro Alves  <palves@redhat.com>
6833
6834         * linux-nat.c: Include scope-exit.h.
6835         (cleanup_target_stop): Remove.
6836         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6837         SCOPE_EXIT.
6838
6839 2019-01-23  Tom Tromey  <tom@tromey.com>
6840             Pedro Alves  <palves@redhat.com>
6841
6842         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6843         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6844
6845 2019-01-23  Tom Tromey  <tom@tromey.com>
6846             Andrew Burgess  <andrew.burgess@embecosm.com>
6847             Pedro Alves  <palves@redhat.com>
6848
6849         * infrun.c (fetch_inferior_event): Use scope_exit.
6850         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6851         * top.c (execute_command): Use scope_exit.
6852         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6853         * utils.c (do_bpstat_clear_actions_cleanup)
6854         (make_bpstat_clear_actions_cleanup): Remove.
6855
6856 2019-01-23  Tom Tromey  <tom@tromey.com>
6857             Pedro Alves  <palves@redhat.com>
6858
6859         * infrun.c: Include "common/scope-exit.h"
6860         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6861         (wait_for_inferior): Use SCOPE_EXIT.
6862         (fetch_inferior_event): Use scope_exit.
6863
6864 2019-01-23  Tom Tromey  <tom@tromey.com>
6865             Pedro Alves  <palves@redhat.com>
6866
6867         * breakpoint.c (create_breakpoint): Remove cleanup.
6868
6869 2019-01-23  Tom Tromey  <tom@tromey.com>
6870             Andrew Burgess  <andrew.burgess@embecosm.com>
6871             Pedro Alves  <palves@redhat.com>
6872
6873 2019-01-23  Pedro Alves  <palves@redhat.com>
6874
6875         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6876
6877 2019-01-23  Pedro Alves  <palves@redhat.com>
6878             Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * gdbthread.h: Include "common/forward-scope-exit.h".
6881         (scoped_finish_thread_state): Redefine custom class in terms of
6882         forward_scope_exit.
6883
6884 2019-01-23  Pedro Alves  <palves@redhat.com>
6885             Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * common/forward-scope-exit.h: New file.
6888
6889 2019-01-23  Pedro Alves  <palves@redhat.com>
6890             Andrew Burgess  <andrew.burgess@embecosm.com>
6891             Tom Tromey  <tom@tromey.com>
6892
6893         * common/scope-exit.h: New file.
6894
6895 2019-01-23  Pedro Alves  <palves@redhat.com>
6896
6897         * common/preprocessor.h (ESC): Rename to ...
6898         (ESC_PARENS): ... this.
6899         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6900         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6901
6902 2019-01-23  Tom Tromey  <tom@tromey.com>
6903
6904         * language.h (class scoped_switch_to_sym_language_if_auto):
6905         Initialize m_lang in both cases.
6906
6907 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6908
6909         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6910         with XCNEW.
6911
6912 2019-01-22  Tom Tromey  <tom@tromey.com>
6913
6914         * corelow.c: Do not include sys/file.h.
6915
6916 2019-01-22  Tom Tromey  <tom@tromey.com>
6917
6918         * tui/tui-wingeneral.h: Include gdb_curses.h.
6919
6920 2019-01-22  Tom Tromey  <tom@tromey.com>
6921
6922         * source-cache.h (class source_cache) <get_source_lines,
6923         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6924
6925 2019-01-22  Tom Tromey  <tom@tromey.com>
6926
6927         * remote-fileio.h (struct remote_target): Declare.
6928
6929 2019-01-22  Tom Tromey  <tom@tromey.com>
6930
6931         * python/py-arch.c: Do not include py-ref.h.
6932         * python/py-bpevent.c: Do not include py-ref.h.
6933         * python/py-cmd.c: Do not include py-ref.h.
6934         * python/py-continueevent.c: Do not include py-ref.h.
6935         * python/py-event.h: Do not include py-ref.h.
6936         * python/py-evtregistry.c: Do not include py-ref.h.
6937         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6938         * python/py-frame.c: Do not include py-ref.h.
6939         * python/py-framefilter.c: Do not include py-ref.h.
6940         * python/py-function.c: Do not include py-ref.h.
6941         * python/py-infevents.c: Do not include py-ref.h.
6942         * python/py-linetable.c: Do not include py-ref.h.
6943         * python/py-objfile.c: Do not include py-ref.h.
6944         * python/py-param.c: Do not include py-ref.h.
6945         * python/py-prettyprint.c: Do not include py-ref.h.
6946         * python/py-progspace.c: Do not include py-ref.h.
6947         * python/py-symbol.c: Do not include py-ref.h.
6948         * python/py-symtab.c: Do not include py-ref.h.
6949         * python/py-type.c: Do not include py-ref.h.
6950         * python/py-unwind.c: Do not include py-ref.h.
6951         * python/py-utils.c: Do not include py-ref.h.
6952         * python/py-value.c: Do not include py-ref.h.
6953         * python/py-varobj.c: Do not include py-ref.h.
6954         * python/py-xmethods.c: Do not include py-ref.h.
6955         * python/python.c: Do not include py-ref.h.
6956         * varobj.c: Do not include py-ref.h.
6957
6958 2019-01-22  Tom Tromey  <tom@tromey.com>
6959
6960         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6961         keyword for bcache.
6962
6963 2019-01-22  Tom Tromey  <tom@tromey.com>
6964
6965         * compile/compile-cplus-types.c: Remove a comment by #include.
6966
6967 2019-01-22  Tom Tromey  <tom@tromey.com>
6968
6969         * compile/gcc-c-plugin.h: Include compile-internal.h.
6970
6971 2019-01-22  Tom Tromey  <tom@tromey.com>
6972
6973         * stabsread.c (EXTERN): Do not define.
6974         (symnum, next_symbol_text_func, processing_gcc_compilation)
6975         (within_function, global_sym_chain, global_stabs)
6976         (previous_stab_code, this_object_header_files)
6977         (n_this_object_header_files)
6978         (n_allocated_this_object_header_files): Define.
6979         * stabsread.h (EXTERN): Never define.  Use "extern".
6980
6981 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6982
6983         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6984         history_value.
6985
6986 2019-01-21  Tom Tromey  <tom@tromey.com>
6987
6988         * ui-out.c: Fix includes.
6989         * tui/tui-source.c: Fix includes.
6990         * target.c: Fix includes.
6991         * remote.c: Fix includes.
6992         * regcache.c: Fix includes.
6993         * python/py-block.c: Fix includes.
6994         * printcmd.c: Fix includes.
6995         * or1k-tdep.c: Fix includes.
6996         * mi/mi-main.c: Fix includes.
6997         * m32r-tdep.c: Fix includes.
6998         * csky-tdep.c: Fix includes.
6999         * compile/compile-cplus-types.c: Fix includes.
7000         * cli/cli-interp.c: Fix includes.
7001
7002 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7003
7004         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7005         for padding.
7006
7007 2019-01-16  Tom Tromey  <tom@tromey.com>
7008
7009         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7010         earlier.
7011         (struct objfile) <msymbols_range>: Move from top level.
7012         <msymbols>: New method.
7013         (class objfile_msymbols): Remove.
7014         * symtab.c (default_collect_symbol_completion_matches_break_on):
7015         Update.
7016         * symmisc.c (dump_msymbols): Update.
7017         * stabsread.c (scan_file_globals): Update.
7018         * objc-lang.c (info_selectors_command, info_classes_command)
7019         (find_methods): Update.
7020         * minsyms.c (find_solib_trampoline_target): Update.
7021         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7022         * coffread.c (coff_symfile_read): Update.
7023         * ada-lang.c (ada_lookup_simple_minsym)
7024         (ada_collect_symbol_completion_matches): Update.
7025
7026 2019-01-16  Tom Tromey  <tom@tromey.com>
7027
7028         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7029         type.  Remove no-argument constructor.
7030         <iterator::operator++>: Simplify.
7031         <begin>: Update.
7032         <end>: Use minimal_symbol_count.
7033
7034 2019-01-16  Tom Tromey  <tom@tromey.com>
7035
7036         * objfiles.h (struct objfile) <psymtabs>: New method.
7037         (class objfile_psymtabs): Remove.
7038         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7039         typedef.
7040         <range>: New method.
7041         (require_partial_symbols): Change return type.
7042         * psymtab.c (require_partial_symbols)
7043         (psym_expand_symtabs_matching): Update.
7044         * mdebugread.c (parse_partial_symbols): Update.
7045         * dbxread.c (dbx_end_psymtab): Update.
7046
7047 2019-01-15  Tom Tromey  <tom@tromey.com>
7048
7049         * symtab.c (lookup_objfile_from_block)
7050         (lookup_symbol_in_objfile_symtabs)
7051         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7052         (find_line_symtab, info_sources_command)
7053         (default_collect_symbol_completion_matches_break_on)
7054         (make_source_files_completion_list): Update.
7055         * symmisc.c (print_objfile_statistics, dump_objfile)
7056         (maintenance_print_symbols, maintenance_info_symtabs)
7057         (maintenance_check_symtabs, maintenance_info_line_tables):
7058         Update.
7059         * source.c (select_source_symtab)
7060         (forget_cached_source_info_for_objfile): Update.
7061         * objfiles.h (class objfile_compunits): Remove.
7062         (struct objfile) <compunits_range>: New typedef.
7063         (compunits): New method.
7064         * objfiles.c (objfile_relocate1): Update.
7065         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7066         * maint.c (count_symtabs_and_blocks): Update.
7067         * linespec.c (iterate_over_all_matching_symtabs): Update.
7068         * cp-support.c (add_symbol_overload_list_qualified): Update.
7069         * coffread.c (coff_symtab_read): Update.
7070         * ada-lang.c (add_nonlocal_symbols)
7071         (ada_collect_symbol_completion_matches)
7072         (ada_add_global_exceptions): Update.
7073
7074 2019-01-15  Tom Tromey  <tom@tromey.com>
7075
7076         * progspace.h (program_space) <objfiles_safe_range>: New
7077         typedef.
7078         <objfiles_safe>: New method.
7079         * objfiles.h (class all_objfiles_safe): Remove.
7080         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7081         * jit.c (jit_inferior_exit_hook): Update.
7082
7083 2019-01-17  Tom Tromey  <tom@tromey.com>
7084
7085         * progspace.h (program_space) <objfiles_range>: New typedef.
7086         <objfiles>: New method.
7087         <objfiles_head>: Rename from objfiles.
7088         (object_files): Update.
7089         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7090         * guile/scm-pretty-print.c
7091         (ppscm_find_pretty_printer_from_objfiles): Update.
7092         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7093         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7094         Update.
7095         * python/py-progspace.c (pspy_get_objfiles): Update.
7096         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7097         Update.
7098         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7099         (objfpy_lookup_objfile_by_build_id): Update.
7100         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7101         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7102         Update.
7103         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7104         (expand_symtab_containing_pc, lookup_objfile_from_block)
7105         (lookup_static_symbol, basic_lookup_transparent_type)
7106         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7107         (find_line_symtab, info_sources_command)
7108         (default_collect_symbol_completion_matches_break_on)
7109         (make_source_files_completion_list, find_main_name): Update.
7110         * symmisc.c (print_symbol_bcache_statistics)
7111         (print_objfile_statistics, maintenance_print_symbols)
7112         (maintenance_print_msymbols, maintenance_print_objfiles)
7113         (maintenance_info_symtabs, maintenance_check_symtabs)
7114         (maintenance_expand_symtabs, maintenance_info_line_tables):
7115         Update.
7116         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7117         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7118         (map_overlay_command, unmap_overlay_command)
7119         (simple_overlay_update, expand_symtabs_matching)
7120         (map_symbol_filenames): Update.
7121         * symfile-debug.c (set_debug_symfile): Update.
7122         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7123         Update.
7124         * source.c (select_source_symtab, forget_cached_source_info):
7125         Update.
7126         * solib.c (solib_read_symbols): Update.
7127         * solib-spu.c (append_ocl_sos): Update.
7128         * psymtab.c (maintenance_print_psymbols)
7129         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7130         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7131         * printcmd.c (info_symbol_command): Update.
7132         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7133         Update.
7134         * objfiles.h (class all_objfiles): Remove.
7135         * objfiles.c (have_partial_symbols, have_full_symbols)
7136         (have_minimal_symbols, qsort_cmp, update_section_map)
7137         (shared_objfile_contains_address_p)
7138         (default_iterate_over_objfiles_in_search_order): Update.
7139         * objc-lang.c (info_selectors_command, info_classes_command)
7140         (find_methods): Update.
7141         * minsyms.c (find_solib_trampoline_target): Update.
7142         * maint.c (maintenance_info_sections)
7143         (maintenance_translate_address, count_symtabs_and_blocks):
7144         Update.
7145         * main.c (captured_main_1): Update.
7146         * linux-thread-db.c (try_thread_db_load_from_pdir)
7147         (has_libpthread): Update.
7148         * linespec.c (iterate_over_all_matching_symtabs)
7149         (search_minsyms_for_name): Update.
7150         * jit.c (jit_find_objf_with_entry_addr): Update.
7151         * hppa-tdep.c (find_unwind_entry)
7152         (hppa_lookup_stub_minimal_symbol): Update.
7153         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7154         Update.
7155         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7156         (elf_gnu_ifunc_resolve_by_got): Update.
7157         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7158         * dwarf-index-write.c (save_gdb_index_command): Update.
7159         * cp-support.c (add_symbol_overload_list_qualified): Update.
7160         * breakpoint.c (create_overlay_event_breakpoint)
7161         (create_longjmp_master_breakpoint)
7162         (create_std_terminate_master_breakpoint)
7163         (create_exception_master_breakpoint): Update.
7164         * blockframe.c (find_pc_partial_function): Update.
7165         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7166         (ada_collect_symbol_completion_matches)
7167         (ada_add_global_exceptions): Update.
7168
7169 2019-01-17  Tom Tromey  <tom@tromey.com>
7170
7171         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7172         declare VEC.
7173         (solib_target_parse_libraries): Change return type.
7174         (library_list_start_segment, library_list_start_section)
7175         (library_list_end_library, library_list_start_library); Update.
7176         (solib_target_free_library_list): Remove.
7177         (solib_target_parse_libraries): Remove cleanup.  Change return
7178         type.
7179         (solib_target_current_sos): Update.
7180
7181 2019-01-17  Tom Tromey  <tromey@bapiya>
7182
7183         * valprint.c: Replace "the the" with "the".
7184         * symtab.c: Replace "the the" with "the".
7185         * solib.c: Replace "the the" with "the".
7186         * solib-dsbt.c: Replace "the the" with "the".
7187         * linespec.c: Replace "the the" with "the".
7188         * dwarf2loc.h: Replace "the the" with "the".
7189         * amd64-windows-tdep.c: Replace "the the" with "the".
7190         * aarch64-tdep.c: Replace "the the" with "the".
7191
7192 2019-01-16  Keith Seitz  <keiths@redhat.com>
7193
7194         PR gdb/23773
7195         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7196         <builder>: Rename to ..
7197         <m_builder>: ... this and make private.
7198         (dwarf2_cu::get_builder): New method.  Change all users of
7199         `builder' to use this method.
7200         (dwarf2_start_symtab): Move to ...
7201         (dwarf2_cu::start_symtab): ... here.  Update all callers
7202         (setup_type_unit_groups): Move to ...
7203         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7204         callers.
7205         (dwarf2_cu::reset_builder): New method.
7206         (process_full_compunit, process_full_type_unit): Use
7207         dwarf2_cu::reset_builder.
7208         (follow_die_offset): Record the ancestor CU if it is different
7209         from the followed DIE's CU.
7210         (follow_die_sig_1): Likewise.
7211
7212 2019-01-15  Tom Tromey  <tom@tromey.com>
7213
7214         * remote.c (class remote_state) <buf>: Now a char_vector.
7215         <buf_size>: Remove.
7216         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7217         parameter.
7218         (remote_target::getpkt_or_notif_sane_1)
7219         (remote_target::getpkt_sane)
7220         (remote_target::getpkt_or_notif_sane): Likewise.
7221         (class remote_target) <putpkt>: New overload.
7222         (remote_target::read_frame): Change type of "buf_p".  Remove
7223         sizeof_p parameter.
7224         (packet_ok): New overload.
7225         (packet_check_result): New overload.
7226         Update all uses.
7227
7228 2019-01-14  Tom Tromey  <tom@tromey.com>
7229
7230         * remote-notif.c (handle_notification, remote_notif_ack)
7231         (remote_notif_parse): Make "buf" const.
7232         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7233         const.
7234         (remote_notif_parse, remote_notif_ack, handle_notification):
7235         Likewise.
7236         * remote.c (remote_notif_stop_parse): Make "buf" const.
7237         (remote_target::remote_parse_stop_reply): Make "buf" const.
7238         (remote_notif_stop_ack): Make "buf" const.
7239
7240 2019-01-14  Tom Tromey  <tom@tromey.com>
7241
7242         * remote.c (remote_console_output): Make parameter const.
7243
7244 2019-01-14  Tom Tromey  <tom@tromey.com>
7245
7246         * target-debug.h (target_debug_print_signals): Constify.
7247         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7248         * procfs.c (procfs_target::pass_signals): Update.
7249         * linux-nat.c (linux_nat_target::pass_signals): Update.
7250         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7251         * target-delegates.c: Rebuild.
7252         * remote.c (remote_target::program_signals): Update.
7253         (remote_target::pass_signals): Update.
7254         * target.c (target_pass_signals): Constify argument.
7255         (target_program_signals): Likewise.
7256         * target.h (struct target_ops) <pass_signals, program_signals>:
7257         Constify argument.
7258         (target_pass_signals, target_program_signals): Constify argument.
7259
7260 2019-01-14  Tom Tromey  <tom@tromey.com>
7261
7262         PR tui/28819:
7263         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7264
7265 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7266
7267         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7268         field.
7269         * rs6000-tdep.c: Include reggroups.h.
7270         (IS_V_ALIAS_PSEUDOREG): Define.
7271         (rs6000_register_name): Return names for the "vX" aliases.
7272         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7273         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7274         aliases.  Call default_register_reggroup_p for all other
7275         pseudo-registers.
7276         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7277         New functions.
7278         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7279         Handle "vX" aliases.
7280         (v_alias_pseudo_register_collect): New function.
7281         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7282         (rs6000_gdbarch_init): Initialize "vX" aliases as
7283         pseudo-registers.  Restore registration of
7284         rs6000_pseudo_register_reggroup_p with
7285         set_tdesc_pseudo_register_reggroup_p.
7286
7287 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7288
7289         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7290         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7291         set_gdbarch_num_pseudo_regs.
7292
7293 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7294
7295         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7296         Remove arg prefixname, add do_set and do_show.
7297         Add member functions set_list and show_list.
7298         * cli/cli-style.c (class cli_style_option): Update accordingly.
7299         (style_set_list): Move to file scope.
7300         (style_show_list): Likewise.
7301         (set_style): Call help_list.
7302         (show_style): Call cmd_show_list.
7303         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7304         Update to use the new macro.
7305
7306 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7307
7308         * ada-lang.c (_initialize_ada_language): Expand the help text
7309         for the "catch exception" command.
7310
7311 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7312
7313         * symtab.c (matching_obj_sections): Initialize obj,
7314         declare it closer to its usage.
7315
7316 2019-01-10  Tom Tromey  <tom@tromey.com>
7317
7318         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7319         (basic_inf_threads_range): Remove.
7320         (inf_threads_range, inf_non_exited_threads_range)
7321         (safe_inf_threads_range): Use next_adapter.
7322
7323 2019-01-10  Keith Seitz  <keiths@redhat.com>
7324
7325         PR gdb/23712
7326         PR symtab/23010
7327         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7328         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7329
7330 2019-01-10  Keith Seitz  <keiths@redhat.com>
7331
7332         PR gdb/23712
7333         PR symtab/23010
7334         * dictionary.c (pending_to_vector): Remove.
7335         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7336         Remove _1 suffix, replacing functions of the same name.  Update
7337         all callers.
7338         (dict_create_hashed, dict_create_hashed_expandable)
7339         (dict_create_linear, dict_create_linear_expandable, dict_free)
7340         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7341         Make functions static.
7342
7343 2019-01-10  Keith Seitz  <keiths@redhat.com>
7344
7345         PR gdb/23712
7346         PR symtab/23010
7347         * dictionary.h (struct dictionary): Replace declaration with
7348         multidictionary.
7349         (dict_create_hashed, dict_create_hashed_expandable)
7350         (dict_create_linear, dict_create_linear_expandable)
7351         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7352         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7353         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7354         taking multidictionary argument.
7355         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7356         * block.h (struct block) <dict>: Change to multidictionary
7357         and rename `multidict'.
7358         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7359         symmisc.c: Update all dictionary references to multidictionary.
7360
7361 2019-01-10  Keith Seitz  <keiths@redhat.com>
7362
7363         PR gdb/23712
7364         PR symtab/23010
7365         * dictionary.c: Include unordered_map.
7366         (pending_to_vector): New function.
7367         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7368         Rewrite the non-"_1" functions to take vector instead
7369         of linked list.
7370         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7371         "new" _1 versions of the same name.
7372         (multidictionary): Define.
7373         (std::hash<enum language): New definition.
7374         (collate_pending_symbols_by_language, mdict_create_hashed)
7375         (mdict_create_hashed_expandable, mdict_create_linear)
7376         (mdict_create_linear_expandable, mdict_free)
7377         (find_language_dictionary, create_new_language_dictionary)
7378         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7379         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7380         (mdict_size, mdict_empty): New functions.
7381         * dictionary.h (mdict_iterator): Define.
7382
7383 2019-01-10  Pedro Alves  <palves@redhat.com>
7384
7385         * breakpoint.c (read_uploaded_action)
7386         (create_tracepoint_from_upload): Adjust to use
7387         gdb::unique_xmalloc_ptr.
7388         * ctf.c (ctf_write_uploaded_tp):
7389         (SET_ARRAY_FIELD): Use emplace_back.
7390         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7391         * tracefile-tfile.c (tfile_write_uploaded_tp):
7392         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7393         gdb::unique_xmalloc_ptr.
7394         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7395         at_string, cond_string, cmd_strings>: Replace char pointers
7396         with gdb::unique_xmalloc_ptr.
7397
7398 2019-01-10  Pedro Alves  <palves@redhat.com>
7399
7400         * solib-target.c (library_list_start_library): Don't xstrdup name.
7401
7402 2019-01-10  Pedro Alves  <palves@redhat.com>
7403
7404         * mdebugread.c (parse_partial_symbols): Use
7405         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7406
7407 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7408
7409         * linux-fork.c (scoped_switch_fork_info)
7410         <~scoped_switch_fork_info>: Fix incorrect variable name.
7411
7412 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7413
7414         * linux-fork.c (scoped_switch_fork_info)
7415         <scoped_switch_fork_info>: Make explicit.
7416         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7417
7418 2019-01-10  Tom Tromey  <tom@tromey.com>
7419
7420         * objfiles.h (objfile::reset_psymtabs): Update.
7421         * objfiles.c (objfile::objfile): Update.
7422         * psymtab.h (psymtab_storage::obstack): Update.
7423         (psymtab_storage::m_obstack): Use gdb::optional.
7424         (class psymtab_storage): Update comment.  Remove objfile
7425         parameter.
7426         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7427
7428 2019-01-10  Tom Tromey  <tom@tromey.com>
7429
7430         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7431         <free_psymtabs>: Now private.
7432         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7433         (allocate_psymtab): Use new method.
7434
7435 2019-01-10  Tom Tromey  <tom@tromey.com>
7436
7437         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7438         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7439         * mdebugread.c (parse_partial_symbols): Use
7440         allocate_dependencies.
7441         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7442         allocate_dependencies.
7443         (process_psymtab_comp_unit_reader)
7444         (build_type_psymtab_dependencies): Likewise.
7445         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7446
7447 2019-01-10  Tom Tromey  <tom@tromey.com>
7448
7449         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7450         PSYMBOL_SET_LANGUAGE.
7451         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7452
7453 2019-01-10  Tom Tromey  <tom@tromey.com>
7454
7455         * psymtab.h (psymtab_storage::obstack): New method.
7456         <m_obstack>: Rename from obstack; now private.
7457         * psymtab.c (psymtab_storage): Update.
7458         * dwarf2read.c (create_addrmap_from_index)
7459         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7460         Update.
7461
7462 2019-01-10  Tom Tromey  <tom@tromey.com>
7463
7464         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7465         * objfiles.h (objfile::reset_psymtabs): New method.
7466
7467 2019-01-10  Tom Tromey  <tom@tromey.com>
7468
7469         * symmisc.c (print_symbol_bcache_statistics): Update.
7470         (print_objfile_statistics): Update.
7471         * symfile.c (reread_symbols): Update.
7472         * psymtab.h (class psymtab_storage): New.
7473         * psymtab.c (psymtab_storage): New constructor.
7474         (~psymtab_storage): New destructor.
7475         (require_partial_symbols): Update.
7476         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7477         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7478         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7479         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7480         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7481         (start_psymtab_common, end_psymtab_common)
7482         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7483         (allocate_psymtab): Update.
7484         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7485         Update.
7486         (dump_psymtab_addrmap, maintenance_print_psymbols)
7487         (maintenance_check_psymtabs): Update.
7488         (class objfile_psymtabs): Move to objfiles.h.
7489         * psympriv.h (discard_psymtab): Now inline.
7490         (psymtab_discarder::psymtab_discarder): Update.
7491         (psymtab_discarder::~psymtab_discarder): Update.
7492         (ALL_OBJFILE_PSYMTABS): Rewrite.
7493         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7494         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7495         Remove fields.
7496         <partial_symtabs>: New field.
7497         (class objfile_psymtabs): Move from psymtab.h.  Update.
7498         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7499         psymbol_cache.
7500         (objfile::~objfile): Don't destroy psymbol_cache.
7501         * mdebugread.c (parse_partial_symbols): Update.
7502         * dwarf2read.c (create_addrmap_from_index)
7503         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7504         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7505         (add_partial_subprogram, dwarf2_ranges_read): Update.
7506         * dwarf-index-write.c (write_address_map)
7507         (write_one_signatured_type, recursively_write_psymbols)
7508         (class debug_names, class debug_names, write_psymtabs_to_index):
7509         Update.
7510
7511 2019-01-10  Tom Tromey  <tom@tromey.com>
7512
7513         * symtab.h (SYMBOL_SET_NAMES): Update.
7514         (symbol_set_names): Update.
7515         (MSYMBOL_SET_NAMES): Update.
7516         * symtab.c (symbol_set_names): Change argument to be an
7517         objfile_per_bfd_storage.
7518         * psymtab.c (add_psymbol_to_bcache): Update.
7519         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7520
7521 2019-01-10  Tom Tromey  <tom@tromey.com>
7522
7523         * symtab.c (create_demangled_names_hash): Change argument to be an
7524         objfile_per_bfd_storage.
7525         (symbol_set_names): Update.
7526
7527 2019-01-10  Tom Tromey  <tom@tromey.com>
7528
7529         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7530         init_psymbol_list.
7531         * psymtab.c (init_psymbol_list): Do nothing if already called.
7532         * psympriv.h (init_psymbol_list): Add comment.
7533         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7534         init_psymbol_list.
7535         * dbxread.c (dbx_symfile_read): Unconditionally call
7536         init_psymbol_list.
7537
7538 2019-01-10  Tom Tromey  <tom@tromey.com>
7539
7540         * xcoffread.c (scan_xcoff_symtab): Update.
7541         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7542         "where".
7543         * mdebugread.c (parse_partial_symbols)
7544         (handle_psymbol_enumerators): Update.
7545         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7546         * dbxread.c (read_dbx_symtab): Update.
7547         * psympriv.h (psymbol_placement): New enum.
7548         (add_psymbol_to_list): Update.
7549
7550 2019-01-10  Tom Tromey  <tom@tromey.com>
7551
7552         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7553         static_psymbols parameters.
7554         (scan_xcoff_symtab): Update.
7555         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7556         static_psymbols parameters.
7557         * psympriv.h (start_psymtab_common): Update.
7558         * mdebugread.c (parse_partial_symbols): Update.
7559         * dwarf2read.c (create_partial_symtab): Update.
7560         * dbxread.c (read_dbx_symtab): Update.
7561         (start_psymtab): Remove global_psymbols and static_psymbols
7562         parameters.
7563
7564 2019-01-10  Tom Tromey  <tom@tromey.com>
7565
7566         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7567         * psymtab.c (allocate_psymtab): Add comment.
7568         * psympriv.h (allocate_psymtab): Add comment.
7569         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7570         initializations.
7571         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7572
7573 2019-01-10  Tom Tromey  <tom@tromey.com>
7574
7575         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7576         Don't declare.
7577         * mipsread.c: Include mdebugread.h.
7578         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7579         Declare.
7580         * elfread.c: Include mdebugread.h.
7581
7582 2019-01-09  Tom Tromey  <tom@tromey.com>
7583
7584         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7585         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7586         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7587         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7588         (psym_lookup_symbol, psym_find_last_source_symtab)
7589         (psym_forget_cached_source_info, psym_print_stats)
7590         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7591         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7592         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7593         (psym_find_compunit_symtab_by_address)
7594         (maintenance_print_psymbols, maintenance_info_psymtabs)
7595         (maintenance_check_psymtabs): Use ranged for.
7596         * psymtab.h (class objfile_psymtabs): New.
7597         (require_partial_symbols): Return objfile_psymtabs.
7598         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7599
7600 2019-01-09  Tom Tromey  <tom@tromey.com>
7601
7602         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7603         (find_pc_mapped_section, list_overlays_command)
7604         (map_overlay_command, unmap_overlay_command)
7605         (simple_overlay_update): Use all_objfiles.
7606         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7607         * printcmd.c (info_symbol_command): Use all_objfiles.
7608         * objfiles.h (ALL_OBJSECTIONS): Remove.
7609         * maint.c (maintenance_translate_address): Use all_objfiles.
7610         * gcore.c (gcore_create_callback): Use all_objfiles.
7611         (objfile_find_memory_regions): Likewise.
7612
7613 2019-01-09  Tom Tromey  <tom@tromey.com>
7614
7615         * symtab.c (find_line_symtab, info_sources_command)
7616         (make_source_files_completion_list): Use objfile_compunits.
7617         * source.c (select_source_symtab): Use objfile_compunits.
7618         * objfiles.h (struct objfile): Update comment.
7619         (ALL_OBJFILES): Remove.
7620         (ALL_FILETABS): Remove.
7621         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7622         objfile_compunits.
7623
7624 2019-01-09  Tom Tromey  <tom@tromey.com>
7625
7626         * symmisc.c (print_objfile_statistics, dump_objfile)
7627         (maintenance_print_symbols): Use compunit_filetabs.
7628         * source.c (forget_cached_source_info_for_objfile): Use
7629         compunit_filetabs.
7630         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7631         (ALL_FILETABS): Use compunit_filetabs.
7632         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7633         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7634
7635 2019-01-09  Tom Tromey  <tom@tromey.com>
7636
7637         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7638         (compunit_filetabs): New.
7639         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7640         compunit_filetabs.
7641         (info_sources_command, make_source_files_completion_list): Remove
7642         declaration.
7643         * symmisc.c (print_objfile_statistics, dump_objfile)
7644         (maintenance_print_symbols): Remove declaration.
7645         (maintenance_info_symtabs): Use compunit_filetabs.
7646         (maintenance_info_line_tables): Likewise.
7647         * source.c (select_source_symtab): Change local variable name.
7648         (forget_cached_source_info_for_objfile): Remove declaration.
7649         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7650         * objfiles.c (objfile_relocate1): Remove declaration.
7651         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7652         declaration.
7653         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7654         * coffread.c (coff_symtab_read): Remove declaration.
7655         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7656         compunit_filetabs.
7657
7658 2019-01-09  Tom Tromey  <tom@tromey.com>
7659
7660         * symtab.c (lookup_objfile_from_block)
7661         (find_pc_sect_compunit_symtab, search_symbols)
7662         (default_collect_symbol_completion_matches_break_on): Use
7663         objfile_compunits.
7664         * objfiles.h (ALL_COMPUNITS): Remove.
7665         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7666         * cp-support.c (add_symbol_overload_list_qualified): Use
7667         objfile_compunits.
7668         * ada-lang.c (ada_collect_symbol_completion_matches)
7669         (ada_add_global_exceptions): Use objfile_compunits.
7670
7671 2019-01-09  Tom Tromey  <tom@tromey.com>
7672
7673         * source.c (select_source_symtab)
7674         (forget_cached_source_info_for_objfile): Remove declaration.
7675         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7676         declaration.
7677         * maint.c (count_symtabs_and_blocks): Remove declaration.
7678         * cp-support.c (add_symbol_overload_list_qualified): Remove
7679         declaration.
7680         * coffread.c (coff_symtab_read): Remove declaration.
7681         * symtab.c (lookup_symbol_in_objfile_symtabs)
7682         (basic_lookup_transparent_type_1): Use objfile_compunits.
7683         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7684         (info_sources_command, search_symbols)
7685         (default_collect_symbol_completion_matches_break_on)
7686         (make_source_files_completion_list): Remove declaration.
7687         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7688         (ada_collect_symbol_completion_matches)
7689         (ada_add_global_exceptions): Remove declaration.
7690         * linespec.c (iterate_over_all_matching_symtabs): Use
7691         objfile_compunits.
7692         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7693         (class objfile_compunits): New.
7694         (ALL_COMPUNITS): Use objfile_compunits.
7695         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7696         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7697         objfile_compunits.
7698         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7699
7700 2019-01-09  Tom Tromey  <tom@tromey.com>
7701
7702         * symtab.c (search_symbols)
7703         (default_collect_symbol_completion_matches_break_on): Use
7704         objfile_msymbols.
7705         * ada-lang.c (ada_lookup_simple_minsym)
7706         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7707         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7708         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7709         objfile_msymbols.
7710         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7711         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7712         * objc-lang.c (find_methods): Use objfile_msymbols.
7713         (info_selectors_command, info_classes_command): Likewise.
7714         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7715         * objfiles.h (class objfile_msymbols): New.
7716         (ALL_OBJFILE_MSYMBOLS): Remove.
7717         (ALL_MSYMBOLS): Remove.
7718
7719 2019-01-09  Tom Tromey  <tom@tromey.com>
7720
7721         * common/next-iterator.h (next_adapter): Add Iterator template
7722         parameter.
7723         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7724         (class all_objfiles_safe): New.
7725         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7726         * objfiles.c (put_objfile_before): Update comment.
7727         (add_separate_debug_objfile): Likewise.
7728         (free_all_objfiles): Use all_objfiles_safe.
7729         (objfile_purge_solibs): Likewise.
7730
7731 2019-01-09  Tom Tromey  <tom@tromey.com>
7732
7733         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7734         (expand_symtab_containing_pc, lookup_static_symbol)
7735         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7736         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7737         all_objfiles.
7738         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7739         * breakpoint.c (create_overlay_event_breakpoint)
7740         (create_longjmp_master_breakpoint)
7741         (create_std_terminate_master_breakpoint)
7742         (create_exception_master_breakpoint): Use all_objfiles.
7743         * linux-thread-db.c (try_thread_db_load_from_pdir)
7744         (has_libpthread): Use all_objfiles.
7745         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7746         * linespec.c (iterate_over_all_matching_symtabs)
7747         (search_minsyms_for_name): Use all_objfiles.
7748         * maint.c (maintenance_info_sections): Use all_objfiles.
7749         * main.c (captured_main_1): Use all_objfiles.
7750         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7751         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7752         * guile/scm-pretty-print.c
7753         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7754         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7755         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7756         (maintenance_print_msymbols): Use all_objfiles.
7757         * source.c (select_source_symtab): Use all_objfiles.
7758         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7759         * symfile.c (remove_symbol_file_command)
7760         (expand_symtabs_matching, map_symbol_filenames): Use
7761         all_objfiles.
7762         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7763         all_objfiles.
7764         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7765         * objc-lang.c (find_methods): Use all_objfiles.
7766         * objfiles.c (have_partial_symbols, have_full_symbols)
7767         (have_minimal_symbols, qsort_cmp)
7768         (default_iterate_over_objfiles_in_search_order): Use
7769         all_objfiles.
7770         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7771         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7772         (maintenance_check_psymtabs): Use all_objfiles.
7773         (ALL_PSYMTABS): Remove.
7774         * compile/compile-object-run.c (do_module_cleanup): Use
7775         all_objfiles.
7776         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7777         * cp-support.c (add_symbol_overload_list_qualified): Use
7778         all_objfiles.
7779         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7780         Use all_objfiles.
7781         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7782         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7783         all_objfiles.
7784         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7785         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7786         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7787         Uses all_objfiles.
7788         * solib.c (solib_read_symbols): Use all_objfiles
7789
7790 2019-01-09  Tom Tromey  <tom@tromey.com>
7791
7792         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7793         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7794         all_objfiles.
7795         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7796         * symmisc.c (print_symbol_bcache_statistics)
7797         (print_objfile_statistics, maintenance_print_objfiles)
7798         (maintenance_info_symtabs, maintenance_check_symtabs)
7799         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7800         all_objfiles.
7801         * source.c (forget_cached_source_info): Use all_objfiles.
7802         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7803         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7804         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7805         * objfiles.c (update_section_map): Use all_objfiles.
7806         (shared_objfile_contains_address_p): Likewise.
7807         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7808         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7809
7810 2019-01-09  Tom Tromey  <tom@tromey.com>
7811
7812         * common/next-iterator.h: New file.
7813         * objfiles.h (class all_objfiles): New.
7814         (struct objfile_iterator): New.
7815
7816 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7817
7818         * NEWS: Move the description of the changed "frame", "select-frame",
7819          and "info frame" commands to the Changed commands section.
7820
7821 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7822
7823         * gdbtypes.c (check_stub_method_group): Remove handling of old
7824         mangling schemes.
7825         * linespec.c (find_methods): Likewise.
7826         * stabsread.c (read_member_functions): Likewise.
7827         * valops.c (search_struct_method): Likewise.
7828         (value_struct_elt_for_reference): Likewise.
7829         * NEWS: Mention this change.
7830
7831 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7834         print_source_lines.
7835         * source.c (print_source_lines_base): Update line number check.
7836         (print_source_lines): New function.
7837         (source_lines_range::source_lines_range): New function.
7838         * source.h (class source_lines_range): New class.
7839         (print_source_lines): New declaration.
7840
7841 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7842
7843         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7844
7845 2019-01-08  Tom Tromey  <tom@tromey.com>
7846             Simon Marchi  <simon.marchi@ericsson.com>
7847
7848         PR gdb/24060
7849         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7850         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7851         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7852         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7853         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7854         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7855
7856 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * source.c (select_source_symtab): Move header comment to
7859         declaration in source.h.
7860         (forget_cached_source_info_for_objfile): Likewise.
7861         (forget_cached_source_info): Likewise.
7862         (identify_source_line): Likewise.
7863         * source.h (identify_source_line): Move declaration from symtab.h
7864         and add comment from source.c
7865         (print_source_lines): Likewise.
7866         (forget_cached_source_info_for_objfile): Likewise.
7867         (forget_cached_source_info): Likewise.
7868         (select_source_symtab): Likewise.
7869         (enum print_source_lines_flag): Move definition from symtab.h.
7870         * symtab.h (identify_source_line): Move declaration to source.h.
7871         (print_source_lines): Likewise.
7872         (forget_cached_source_info_for_objfile): Likewise.
7873         (forget_cached_source_info): Likewise.
7874         (select_source_symtab): Likewise.
7875         (enum print_source_lines_flag): Move definition to source.h.
7876         * tui/tui-hooks.c: Add 'source.h' include.
7877
7878 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7879
7880         * source.c (print_source_lines_base): Handle requests to print
7881         reverse line number sequences, and guard against empty lines
7882         string.
7883
7884 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7885
7886         * source.c (print_source_lines_base): Fix skip of '\r' if next
7887         character is '\n'.
7888
7889 2019-01-06  Tom Tromey  <tom@tromey.com>
7890
7891         * c-exp.y (struct c_parse_state) <macro_original_text,
7892         expansion_obstack>: New member.
7893         (macro_original_text, expansion_obstack): Remove globals.
7894         (scan_macro_expansion, scanning_macro_expansion)
7895         (finished_macro_expansion): Update.
7896         (scan_macro_cleanup): Remove.
7897         (yylex, c_parse): Update.
7898
7899 2019-01-06  Tom Tromey  <tom@tromey.com>
7900
7901         * c-exp.y (struct c_parse_state) <strings>: New member.
7902         (operator_stoken): Update.
7903
7904 2019-01-06  Tom Tromey  <tom@tromey.com>
7905
7906         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7907         (union type_stack_elt) <typelist_val>: Now a pointer to
7908         std::vector.
7909         (type_stack_cleanup): Don't declare.
7910         (push_typelist): Update.
7911         * parse.c (pop_typelist): Return a std::vector.
7912         (push_typelist): Take a std::vector.
7913         (follow_types): Update.  Do not free args.
7914         (type_stack_cleanup): Remove.
7915         * c-exp.y (struct c_parse_state): New.
7916         (cpstate): New global.
7917         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7918         (nonempty_typelist): Update.
7919         (func_mod): Create a new vector.
7920         (c_parse): Create a c_parse_state.
7921         (check_parameter_typelist): Do not delete params.
7922         (function_method): Update.  Do not delete type_list.
7923
7924 2019-01-06  Tom Tromey  <tom@tromey.com>
7925
7926         PR gdb/28155:
7927         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7928         check_typedef.
7929         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7930         (print_return_value): Likewise.
7931
7932 2019-01-05  Tom Tromey  <tom@tromey.com>
7933
7934         * contrib/cleanup_check.py: Remove.
7935         * contrib/gcc-with-excheck: Remove.
7936         * contrib/exsummary.py: Remove.
7937         * contrib/excheck.py: Remove.
7938
7939 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7940
7941         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7942         NULL. Initialize tpprev to NULL instead of assigning it
7943         to NULL on the next statement.
7944         * windows-nat.c (windows_delete_thread): Remove check for
7945         main_thread_id before printing thread exit notifications.
7946         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7947         Remove thread ID check against main_thread_id.
7948         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7949         windows_delete_thread.
7950         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7951
7952 2019-01-04  Tom Tromey  <tom@tromey.com>
7953
7954         * compile/compile.c (_initialize_compile): Use upper case for
7955         metasyntactic variables.
7956         * symmisc.c (_initialize_symmisc): Use upper case for
7957         metasyntactic variables.
7958         * psymtab.c (_initialize_psymtab): Use upper case for
7959         metasyntactic variables.
7960         * demangle.c (demangle_command): Use upper case for metasyntactic
7961         variables.
7962         (_initialize_demangler): Likewise.
7963         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7964         variables.
7965
7966 2019-01-03  Tom Tromey  <tom@tromey.com>
7967
7968         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7969
7970 2019-01-03  Tom Tromey  <tom@tromey.com>
7971
7972         * python/py-symtab.c (salpy_str): Update.
7973         (struct salpy_sal_object) <symtab>: Now a PyObject.
7974         (salpy_dealloc): Update.
7975         (del_objfile_sal): Use gdbpy_ref.
7976
7977 2019-01-03  Tom Tromey  <tom@tromey.com>
7978
7979         * python/py-type.c (convert_field): Use new_reference.  Return
7980         gdbpy_ref.
7981         (make_fielditem): Return gdbpy_ref.
7982         (typy_fields): Update.
7983         (typy_getitem): Update.
7984         (field_name): Return gdbpy_ref.  Use new_reference.
7985         (typy_iterator_iternext): Update.
7986
7987 2019-01-03  Tom Tromey  <tom@tromey.com>
7988
7989         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7990
7991 2019-01-03  Tom Tromey  <tom@tromey.com>
7992
7993         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7994         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7995         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7996         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7997         (pspy_set_type_printers): Likewise.
7998         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7999         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8000         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8001         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8002         (objfpy_set_type_printers): Likewise.
8003
8004 2019-01-03  Tom Tromey  <tom@tromey.com>
8005
8006         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8007         (gdbpy_print_stack): Use gdbpy_err_fetch.
8008         * python/python-internal.h (class gdbpy_err_fetch): New class.
8009         (class gdbpy_enter) <m_error_type, m_error_value,
8010         m_error_traceback>: Remove.
8011         <m_error>: New member.
8012         (gdbpy_exception_to_string): Don't declare.
8013         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8014         * python/py-value.c (convert_value_from_python): Use
8015         gdbpy_err_fetch.
8016         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8017         gdbpy_exception_to_string.
8018         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8019         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8020         gdbpy_err_fetch.
8021
8022 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8023
8024         * linux-nat.c (delete_lwp_cleanup): Delete.
8025         (struct lwp_deleter): New struct.
8026         (lwp_info_up): New typedef.
8027         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8028         lwp_info_up.
8029
8030 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8031
8032         * linux-fork.c (class scoped_switch_fork_info): New class.
8033         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8034
8035 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8036
8037         * valops.c (find_overload_match): Remove use of null_cleanup, and
8038         calls to do_cleanups.
8039
8040 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * compile/compile-cplus-types.c
8043         (compile_cplus_instance::decl_name): Handle changes to
8044         cp_func_name.
8045         * cp-support.c (cp_func_name): Update header comment, update
8046         return type.
8047         * cp-support.h (cp_func_name): Update return type in declaration.
8048         * valops.c (find_overload_match): Move temp_func local to top
8049         level of function and change its type.  Use temp_func to hold and
8050         delete temporary string obtained from cp_func_name.
8051
8052 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8055         gdb::char_vector, remove cleanup, and update uses of `msg`.
8056
8057 2019-01-03  Jim Wilson  <jimw@sifive.com>
8058
8059         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8060
8061 2019-01-02  Tom Tromey  <tom@tromey.com>
8062
8063         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8064         (tdesc_parse_xml): Remove cleanups.
8065         * target-descriptions.h (make_cleanup_free_target_description):
8066         Don't declare.
8067         (target_desc_deleter): New struct.
8068         (target_desc_up): New typedef.
8069         * target-descriptions.c (target_desc_deleter::operator()): Rename
8070         from free_target_description.
8071         (make_cleanup_free_target_description): Remove.
8072
8073 2019-01-02  Tom Tromey  <tom@tromey.com>
8074
8075         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8076         constructor, destructor.
8077         (linespec_parser): Remove typedef.
8078         (~linespec_parser): Rename from linespec_parser_delete.
8079         (linespec_lex_to_end, linespec_complete_label)
8080         (linespec_complete): Update.
8081         (decode_line_full): Remove cleanups.
8082         (decode_line_1): Update.
8083
8084 2019-01-02  Tom Tromey  <tom@tromey.com>
8085
8086         * python/python-internal.h (inferior_to_inferior_object): Change
8087         return type.
8088         * python/py-exitedevent.c (create_exited_event_object): Update.
8089         * python/py-inferior.c (inferior_to_inferior_object): Return
8090         gdbpy_ref.
8091         (python_new_inferior, python_inferior_deleted)
8092         (thread_to_thread_object, delete_thread_object)
8093         (build_inferior_list, gdbpy_selected_inferior): Update.
8094         * python/py-infthread.c (create_thread_object): Update.  Also fail
8095         if inferior_to_inferior_object fails.
8096
8097 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8098
8099         * inferior.h (class inferior) <displaced_step_state>: New field.
8100         * infrun.h (struct displaced_step_state): Move here from
8101         infrun.c.  Initialize fields, add constructor.
8102         <inf>: Remove field.
8103         <reset>: New method.
8104         * infrun.c (struct displaced_step_inferior_state): Move to
8105         infrun.h.
8106         (displaced_step_inferior_states): Remove.
8107         (get_displaced_stepping_state): Adust.
8108         (displaced_step_in_progress_any_inferior): Adjust.
8109         (displaced_step_in_progress_thread): Adjust.
8110         (displaced_step_in_progress): Adjust.
8111         (add_displaced_stepping_state): Remove.
8112         (get_displaced_step_closure_by_addr): Adjust.
8113         (remove_displaced_stepping_state): Remove.
8114         (infrun_inferior_exit): Call displaced_step_state.reset.
8115         (use_displaced_stepping): Don't check for NULL.
8116         (displaced_step_prepare_throw): Call
8117         get_displaced_stepping_state.
8118         (displaced_step_fixup): Don't check for NULL.
8119         (prepare_for_detach): Don't check for NULL.
8120
8121 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8122
8123         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8124          in case of call that did not complete.
8125
8126 2019-01-02  Andrey Utkin  <autkin@undo.io>
8127
8128         * symfile.c (find_separate_debug_file): Fix search of debug files for
8129         remote debuggee.
8130
8131 2019-01-02  Tom Tromey  <tom@tromey.com>
8132
8133         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8134         indentation.
8135         * python/py-frame.c (frapy_older): Remove cast.
8136         (frapy_newer): Likewise.
8137         * python/py-breakpoint.c (local_setattro): Remove cast.
8138         * python/py-arch.c (archpy_name): Remove local variable.
8139         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8140
8141 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8142
8143         * unittests/basic_string_view/element_access/char/empty.cc:
8144         Fix year range in copyright header.
8145
8146 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8149         Delete.
8150         <operator==>: Update with for removed field.
8151         <hash>: Likewise.
8152         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8153         <isa_features>: ...this.
8154         <abi_features>: New field.
8155         (riscv_isa_flen): Update comment.
8156         (riscv_abi_xlen): New declaration.
8157         (riscv_abi_flen): New declaration.
8158         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8159         isa_features.
8160         (riscv_abi_xlen): New function.
8161         (riscv_isa_flen): Update to get answer from isa_features.
8162         (riscv_abi_flen): New function.
8163         (riscv_has_fp_abi): Update to get answer from abi_features.
8164         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8165         xlen and flen.
8166         (riscv_call_info) <xlen, flen>: Update comment.
8167         (riscv_call_arg_struct): Remove invalid assertions
8168         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8169         is removed.
8170         (riscv_gdbarch_init): Gather isa features and abi features
8171         separately, ensure both match on the gdbarch when reusing an old
8172         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8173         a target with 64-bit float hardware.
8174
8175 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8176
8177         * source.c (search_command_helper): Stop reverse search
8178         when line 1 has been searched.
8179
8180 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8181
8182         * record-full.c (record_full_base_target::close): Rewrite
8183         record_full_core_buf_list free logic.
8184
8185 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8186
8187         * break-catch-syscall.c (print_one_catch_syscall): xfree
8188         the last text.
8189
8190 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8191
8192         * top.c (print_gdb_version): Update Copyright year in version
8193         message.
8194
8195 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8196
8197         Update copyright year range in all GDB files.
8198
8199 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8200
8201         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8202
8203 For older changes see ChangeLog-2018.
8204 \f
8205 Local Variables:
8206 mode: change-log
8207 left-margin: 8
8208 fill-column: 74
8209 version-control: never
8210 coding: utf-8
8211 End:
8212