gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-hooks.c (tui_remove_hooks): Don't set
   4         deprecated_query_hook.
   5
   6 2019-08-16  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
   9         (tui_update_source_windows_with_line): Update.
  10         * tui/tui-source.h (struct tui_source_window)
  11         <show_symtab_source>: Declare.
  12         (tui_show_symtab_source): Don't declare.
  13         * tui/tui-source.c (tui_show_symtab_source): Rename from
  14         tui_show_symtab_source.
  15
  16 2019-08-16  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-winsource.h (struct tui_source_window_base)
  19         <set_contents>: Declare.
  20         * tui/tui-winsource.c
  21         (tui_source_window_base::update_source_window_as_is): Update.
  22         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  23         Declare.
  24         (tui_set_source_content): Don't declare.
  25         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  26         tui_set_source_content.
  27         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  28         Declare.
  29         (tui_set_disassem_content): Don't declare.
  30         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  31         tui_set_disassem_content.
  32
  33 2019-08-16  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.h (struct tui_source_window_base)
  36         <update_breakpoint_info>: Declare.
  37         (tui_update_breakpoint_info): Don't declare.
  38         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  39         (tui_update_all_breakpoint_info): Update.
  40         (tui_source_window_base::update_breakpoint_info): Rename from
  41         tui_update_breakpoint_info.
  42         (tui_source_window_base::update_exec_info): Update.
  43
  44 2019-08-16  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-winsource.h (struct tui_source_window_base)
  47         <update_source_window>: Declare.
  48         (tui_update_source_window): Don't declare.
  49         * tui/tui-winsource.c
  50         (tui_source_window_base::update_source_window): Rename from
  51         tui_update_source_window.
  52         (tui_source_window_base::rerender): Update.
  53         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  54         * tui/tui-disasm.c (tui_show_disassem)
  55         (tui_show_disassem_and_update_source)
  56         (tui_disasm_window::maybe_update): Update.
  57
  58 2019-08-16  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-winsource.h (struct tui_source_window_base)
  61         <update_source_window_as_is>: Declare.
  62         (tui_update_source_window_as_is): Don't declare.
  63         * tui/tui-winsource.c (tui_update_source_window): Update
  64         (tui_source_window_base::update_source_window_as_is): Rename from
  65         tui_update_source_window_as_is.
  66         (tui_source_window_base::refill): Update.
  67         * tui/tui-source.c (tui_show_symtab_source): Update.
  68         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  69         Update.
  70
  71 2019-08-16  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-winsource.h (tui_update_source_window)
  74         (tui_update_source_window_as_is): Remove "noerror" parameter.
  75         * tui/tui-winsource.c (tui_update_source_window)
  76         (tui_update_source_window_as_is): Remove "noerror" parameter.
  77         (tui_update_source_windows_with_addr)
  78         (tui_update_source_windows_with_line)
  79         (tui_source_window_base::rerender)
  80         (tui_source_window_base::refill): Update.
  81         * tui/tui-source.h (tui_set_source_content)
  82         (tui_show_symtab_source): Remove "noerror" parameter.
  83         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
  84         parameter.
  85         (tui_show_symtab_source): Likewise.
  86         (tui_source_window::maybe_update): Update.
  87         * tui/tui-disasm.c (tui_show_disassem)
  88         (tui_show_disassem_and_update_source)
  89         (tui_disasm_window::do_scroll_vertical)
  90         (tui_disasm_window::maybe_update): Update.
  91
  92 2019-08-16  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui.c (tui_is_window_visible): Update.
  95         * tui/tui-wingeneral.c (tui_make_window)
  96         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
  97         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
  98         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
  99         (tui_set_win_height_command, parse_scrolling_args): Update.
 100         * tui/tui-source.c (tui_source_window::style_changed): Update.
 101         * tui/tui-regs.c (tui_show_registers)
 102         (tui_data_window::first_data_item_displayed)
 103         (tui_data_window::delete_data_content_windows)
 104         (tui_check_register_values, tui_reg_command): Update.
 105         * tui/tui-disasm.c (tui_show_disassem): Update.
 106         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 107         method.
 108         <is_visible>: Remove field.
 109         * tui/tui-data.c (tui_next_win, tui_prev_win)
 110         (tui_delete_invisible_windows): Update.
 111
 112 2019-08-16  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-winsource.h (struct tui_source_window_base)
 115         <m_has_locator>: Remove.
 116         * tui/tui-layout.c (show_source_disasm_command, show_data)
 117         (show_source_or_disasm_and_command): Update.
 118
 119 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 120
 121         * NEWS (Other MI changes): New subsection.
 122         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 123         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 124         * arch-utils.c (default_get_pc_address_flags): New function.
 125         * arch-utils.h (default_get_pc_address_flags): New declaration.
 126         * gdbarch.sh: Add get_pc_address_flags.
 127         * gdbarch.c: Regenerate.
 128         * gdbarch.h: Likewise.
 129         * stack.c (print_pc): New function.
 130         (print_frame_info) (print_frame): Call print_pc.
 131
 132 2019-08-16  Tom de Vries  <tdevries@suse.de>
 133
 134         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 135         print_objfile_section_info.
 136
 137 2019-08-15  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 140         calling update_cmdwin_start_line.
 141         * tui/tui-winsource.h (struct tui_source_window_base)
 142         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 143         <rerender>: Declare.
 144         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 145         Call rerender.
 146         (tui_source_window_base::set_new_height): Remove.
 147         (tui_source_window_base::rerender): Rename from
 148         do_make_visible_with_new_height.
 149         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 150         resize method.
 151         (tui_win_info::make_invisible_and_set_new_height)
 152         (tui_win_info::make_visible_with_new_height): Remove.
 153         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 154         Declare.
 155         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 156         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 157         do_make_visible_with_new_height>: Don't declare.
 158         <rerender>: Declare.
 159         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 160         set_new_height.
 161         (tui_data_window::do_make_visible_with_new_height): Remove.
 162         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 163         call tui_show_locator_content.
 164         (tui_gen_win_info::resize): Call rerender.
 165         (show_source_or_disasm_and_command): Don't call
 166         tui_show_locator_content.
 167         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 168         method.
 169         (struct tui_win_info) <rerender>: Declare.
 170         <set_new_height, make_invisible_and_set_new_height,
 171         make_visible_with_new_height>: Don't declare.
 172         * tui/tui-data.c (tui_win_list::rerender): New method.
 173         * tui/tui-command.h (struct tui_cmd_window)
 174         <do_make_visible_with_new_height>: Don't declare.
 175         * tui/tui-command.c
 176         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 177
 178 2019-08-15  Tom Tromey  <tromey@adacore.com>
 179
 180         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 181         * ada-lang.c (ada_enum_name): Likewise.
 182
 183 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 184
 185         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 186         leading underscore.
 187         (GdbOutputErrorFile): Likewise.
 188         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 189         accordingly.
 190         (execute_unwinders): Rename to have a leading underscore.
 191         (auto_load_packages): Likewise.
 192         (global scope): Adjust call to auto_load_packages accordingly.
 193         (GdbSetPythonDirectory): Likewise.
 194         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 195         instead of execute_unwinders.
 196
 197 2019-08-15  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 200         (show_data): Don't change window visibility.
 201         (tui_gen_win_info::resize): Remove special case for command
 202         window.  Use wresize, when available.
 203         (show_source_or_disasm_and_command): Don't change window
 204         visibility.
 205         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 206         <make_visible>: New method.
 207         * tui/tui-command.c (tui_cmd_window::resize): New method.
 208
 209 2019-08-15  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 212         (struct tui_source_windows): New.
 213         * tui/tui-winsource.c (tui_display_main): Update.
 214         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 215         (new_height_ok, parse_scrolling_args): Update.
 216         * tui/tui-layout.c (show_layout, show_data): Update.
 217         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 218         (tui_add_to_source_windows): Don't declare.
 219         * tui/tui-data.c (source_windows, tui_source_windows)
 220         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 221
 222 2019-08-15  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 225         Rename from reset.
 226         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 227         * tui/tui-layout.c (show_source_disasm_command, show_data):
 228         Update.
 229         (tui_gen_win_info::resize): Rename.
 230         (show_source_or_disasm_and_command): Update.
 231         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 232         reset.
 233
 234 2019-08-15  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 237         * tui/tui-interp.c (tui_interp::init): Don't call
 238         tui_initialize_static_data.
 239         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 240
 241 2019-08-15  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 244         examine tui_win_list.
 245
 246 2019-08-15  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 249         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 250         tui_clear_source_content.
 251         (tui_clear_source_content): Remove.
 252         (tui_source_window_base::do_erase_source_content): Hoist call to
 253         content.clear().
 254         * tui/tui-stack.c (tui_show_frame_info): Don't call
 255         tui_clear_source_content.
 256
 257 2019-08-15  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-winsource.h (struct tui_source_window_base)
 260         <do_erase_source_content>: New method.
 261         <erase_source_content>: New method.
 262         (tui_erase_source_content): Don't declare.
 263         * tui/tui-winsource.c (tui_clear_source_content): Update.
 264         (tui_source_window_base::do_erase_source_content): Rename from
 265         tui_erase_source_content.
 266         (tui_source_window_base::show_source_content): Update.
 267         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 268         * tui/tui-source.h (struct tui_source_window)
 269         <erase_source_content>: New method.
 270         * tui/tui-disasm.h (struct tui_disasm_window)
 271         <erase_source_content>: New method.
 272
 273 2019-08-15  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 276         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 277         constructor.
 278         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 279         * tui/tui-source.c (tui_set_source_content): Update.
 280         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 281
 282 2019-08-15  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 285         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 286         tui-source.c.
 287         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 288         Declare.
 289         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 290         method.
 291         (tui_source_window::maybe_update): Update.
 292
 293 2019-08-15  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 296         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 297         tui-disasm.c.
 298         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 299         Declare.
 300         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 301         method.
 302         (tui_disasm_window::maybe_update): Update.
 303
 304 2019-08-15  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-winsource.h (struct tui_source_window_base)
 307         <maybe_update>: Declare.
 308         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 309         method.
 310         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 311         Declare.
 312         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 313         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 314         Declare.
 315         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 316
 317 2019-08-15  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 320
 321 2019-08-15  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-wingeneral.c: Include tui-stack.h.
 324         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 325         (struct tui_locator_window): Move from tui-data.h.
 326         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 327         (tui_initialize_static_data): Move from tui-data.c.
 328         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 329         (struct tui_locator_window): Move to tui-stack.c.
 330         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 331         (tui_initialize_static_data): Move to tui-stack.c.
 332
 333 2019-08-15  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-layout.c (show_source_disasm_command)
 336         (show_source_or_disasm_and_command): Use make_visible method, not
 337         tui_make_window.
 338         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 339         Remove.
 340
 341 2019-08-15  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-wingeneral.h (tui_make_window): Update.
 344         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 345         parameter.
 346         (tui_gen_win_info::make_visible): Update.
 347         * tui/tui-regs.c (tui_data_window::display_registers_from):
 348         Update.
 349         * tui/tui-layout.c (show_source_disasm_command)
 350         (show_source_or_disasm_and_command): Update.
 351         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 352         (enum tui_box): Remove.
 353         (struct tui_win_info) <can_box>: New method.
 354         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 355         method.
 356
 357 2019-08-15  Tom de Vries  <tdevries@suse.de>
 358
 359         * linux-nat-trad.c: Include gdbarch.h.
 360
 361 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 362
 363         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 364         register sizes.
 365
 366 2019-08-14  Tom Tromey  <tromey@adacore.com>
 367
 368         * darwin-nat.c: Include gdbarch.h.
 369         * darwin-nat-info.c: Include gdbarch.h.
 370
 371 2019-08-13  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 374         Remove.
 375         * tui/tui-data.c (tui_initialize_static_data): Update.
 376
 377 2019-08-13  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-winsource.h (struct tui_exec_info_window)
 380         <~tui_exec_info_window, maybe_allocate_content, get_content,
 381         m_content>: Remove.
 382         (struct tui_source_window_base) <set_exec_info_content,
 383         show_exec_info_content>: Don't declare.
 384         * tui/tui-winsource.c
 385         (tui_exec_info_window::maybe_allocate_content): Remove.
 386         (tui_source_window_base::update_exec_info): Rename from
 387         set_exec_info_content.
 388         (tui_source_window_base::show_exec_info_content)
 389         (tui_source_window_base::update_exec_info): Remove.
 390
 391 2019-08-13  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 394         declare.
 395         * tui/tui-winsource.c (tui_update_source_window_as_is)
 396         (tui_update_source_windows_with_addr, tui_erase_source_content):
 397         Update.
 398         (tui_clear_exec_info_content): Remove.
 399
 400 2019-08-13  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 403         declare.
 404         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 405         call tui_erase_exec_info_content.
 406         (tui_clear_exec_info_content): Rename from
 407         tui_erase_exec_info_content.
 408         (tui_clear_exec_info_content): Delete.
 409
 410 2019-08-13  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.h (struct tui_source_window_base)
 413         <show_exec_info_content>: Declare.
 414         (tui_show_exec_info_content): Don't declare.
 415         * tui/tui-winsource.c
 416         (tui_source_window_base::show_exec_info_content): Rename from
 417         tui_show_exec_info_content.
 418         (tui_source_window_base::update_exec_info): Update.
 419
 420 2019-08-13  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 423         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 424         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 425         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 426         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 427         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 428         ... here.
 429
 430 2019-08-13  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.h (struct tui_source_window_base)
 433         <update_exec_info>: Declare.
 434         (tui_update_exec_info): Don't declare.
 435         * tui/tui-winsource.c (tui_update_source_window_as_is)
 436         (tui_source_window_base::refresh_all)
 437         (tui_update_all_breakpoint_info): Update.
 438         (tui_source_window_base::update_exec_info): Rename from
 439         tui_update_exec_info.
 440         * tui/tui-stack.c (tui_show_frame_info): Update.
 441
 442 2019-08-13  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-winsource.h (struct tui_source_window_base)
 445         <set_exec_info_content>: Declare.
 446         (tui_set_exec_info_content): Don't declare.
 447         * tui/tui-winsource.c
 448         (tui_source_window_base::set_exec_info_content): Rename from
 449         tui_set_exec_info_content.
 450         (tui_update_exec_info): Update.
 451
 452 2019-08-13  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-winsource.h (struct tui_source_window_base)
 455         <show_source_content>: Declare.
 456         (tui_show_source_content): Don't declare.
 457         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 458         (tui_source_window_base::show_source_content): Rename from
 459         tui_show_source_content.
 460         (tui_source_window_base::refresh_all): Update.
 461         * tui/tui-layout.c (show_source_disasm_command)
 462         (show_source_or_disasm_and_command): Update.
 463
 464 2019-08-13  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-winsource.c (tui_erase_source_content)
 467         (tui_show_source_content, tui_source_window_base::refresh_all):
 468         Update.
 469         * tui/tui-wingeneral.h
 470         (tui_check_and_display_highlight_if_needed): Don't declare.
 471         * tui/tui-wingeneral.c
 472         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 473         check_and_display_highlight_if_needed.
 474         * tui/tui-win.c (tui_rehighlight_all)
 475         (tui_win_info::make_visible_with_new_height): Update.
 476         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 477         (tui_data_window::erase_data_content)
 478         (tui_data_window::display_all_data): Update.
 479         * tui/tui-data.h (struct tui_win_info)
 480         <check_and_display_highlight_if_needed>: Declare.
 481
 482 2019-08-13  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-win.c (tui_resize_all): Call
 485         tui_delete_invisible_windows.
 486         * tui/tui-layout.c (show_layout): Call
 487         tui_delete_invisible_windows.
 488         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 489         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 490
 491 2019-08-13  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 494         tui_add_win_to_layout.
 495
 496 2019-08-13  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 499         * tui/tui-layout.c (tui_default_win_height): Now static.
 500
 501 2019-08-13  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 504         single switch.
 505         (show_source_disasm_command, show_source_or_disasm_and_command):
 506         Don't check current layout.
 507
 508 2019-08-13  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-wingeneral.c (make_all_visible): Remove.
 511         (tui_make_all_invisible): Simplify.
 512         * tui/tui-layout.c (tui_make_all_invisible): Move from
 513         tui-wingeneral.c; simplify.
 514         (show_layout): Hoist call to tui_make_all_invisible.
 515         (show_data): Don't call tui_make_all_invisible.
 516
 517 2019-08-13  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 520         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 521
 522 2019-08-13  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 525         tui-data.c.
 526         (show_source_disasm_command, show_data)
 527         (show_source_or_disasm_and_command): Don't use
 528         tui_set_current_layout_to.
 529         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 530         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 531         tui-layout.c.
 532         (tui_set_current_layout_to): Remove.
 533
 534 2019-08-13  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-layout.c (tui_set_layout): Update.
 537         * tui/tui-data.h (struct tui_layout_def): Remove.
 538         (tui_layout_def): Don't declare.
 539         * tui/tui-data.c (layout_def): Remove.
 540         (tui_layout_def): Remove.
 541
 542 2019-08-13  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-winsource.h (struct tui_source_window_base)
 545         <clear_detail>: No longer "override".
 546         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 547         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 548         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 549         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 550         Remove.
 551         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 552
 553 2019-08-13  Tom Tromey  <tromey@adacore.com>
 554
 555         * tracepoint.c: Don't include readline.h or history.h.
 556
 557 2019-08-12  Tom Tromey  <tom@tromey.com>
 558
 559         * configure: Rebuild.
 560         * configure.ac: Check for readline 7.
 561         * NEWS: Mention readline 7 requirement.
 562         * README: Update.
 563
 564 2019-08-12  Tom Tromey  <tom@tromey.com>
 565
 566         * mingw-hdep.c (gdb_select): Remove readline hack.
 567
 568 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 569
 570         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 571         when the function fails.
 572
 573 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 574
 575         * s390-tdep.c (s390_type_align): New function.
 576         (s390_gdbarch_init): Set it as type_align gdbarch method.
 577
 578 2019-08-09  Tom de Vries  <tdevries@suse.de>
 579
 580         PR gdb/24591
 581         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 582         pc_low with relocation offset.
 583
 584 2019-08-07  Tom Tromey  <tromey@adacore.com>
 585
 586         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 587         (print_frame_args): Update.
 588         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 589         Update.
 590         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 591         * frame.h (struct frame_arg): Add initializers.
 592         <error>: Now a unique_xmalloc_ptr.
 593
 594 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 595
 596         * NEWS: Expand the Pointer Authentication entry.
 597         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 598         (aarch64_frame_unmask_lr): ... to this.
 599         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 600         Call aarch64_frame_unmask_lr.
 601         * frame.c (struct frame_info): Add "masked" variable.
 602         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 603         (fprint_frame): Check for masked pc.
 604         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 605         declarations.
 606         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 607         * stack.c (print_frame): Check for masked pc.
 608
 609 2019-08-06  Tom Tromey  <tom@tromey.com>
 610
 611         * stabsread.c (patch_block_stabs, read_one_struct_field)
 612         (read_enum_type): Use obstack_strndup.
 613         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 614         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 615         * dwarf2read.c (guess_full_die_structure_name)
 616         (anonymous_struct_prefix): Use obstack_strndup.
 617         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 618         * c-exp.y (yylex): Use obstack_strndup.
 619         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 620         (write_var_or_type): Use obstack_strndup.
 621
 622 2019-08-06  Tom Tromey  <tom@tromey.com>
 623
 624         * symfile.c (reread_symbols): Use obstack_strdup.
 625         * stabsread.c (read_type): Use obstack_strdup.
 626         * gdb_obstack.h (obstack_strdup): New overload.
 627         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 628         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 629         (dwarf2_canonicalize_name): Use obstack_strdup.
 630         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 631         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 632         Use obstack_strdup.
 633
 634 2019-08-06  Tom Tromey  <tom@tromey.com>
 635
 636         * gdb_obstack.h (obstack_strdup): Define.
 637         * gdb_obstack.c (obstack_strdup): Don't define.
 638
 639 2019-08-06  Tom Tromey  <tom@tromey.com>
 640
 641         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 642         obstack_strdup.
 643         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 644         obstack_strdup.
 645         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 646         * stabsread.c (common_block_start): Use obstack_strdup.
 647         * objfiles.c (set_objfile_main_name, objfile): Use
 648         obstack_strdup.
 649         * namespace.c (add_using_directive): Use obstack_strdup.
 650         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 651         * jit.c (finalize_symtab): Use obstack_strdup.
 652         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 653         (guess_partial_die_structure_name, partial_die_info::fixup)
 654         (dwarf2_name): Use obstack_strdup.
 655         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 656         obstack_strdup.
 657         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 658         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 659         obstack_strdup.
 660         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 661
 662 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         * unittests/help-doc-selftests.c: New file.
 665         * Makefile.in: Add the new file.
 666
 667 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 668
 669         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 670         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 671         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 672         the trailing '.' is not output, and the first character is uppercased.
 673         (print_help_for_command): Update call to print_doc_line.
 674         (print_doc_of_command): Likewise.
 675         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 676         * cli/cli-option.c (append_indented_doc): Do not append newline.
 677         (build_help_option): Append newline after first appended_indented_doc
 678         only if a second call is done.
 679         (build_help): Append 2 new lines before each option, except the first
 680         one.
 681         * compile/compile.c (_initialize_compile): Add new lines after
 682         %OPTIONS%, when not at the end of the help.
 683         Change help doc or code
 684         producing the help doc to respect the invariants.
 685         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 686         Also removed the new line after 'Options:', as all other commands
 687         do not put an empty line between 'Options:' and the first option.
 688         * printcmd.c (_initialize_printcmd): Likewise.
 689         * stack.c (_initialize_stack): Likewise.
 690         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 691         incorrectly telling COMMAND is optional.
 692         * ada-lang.c (_initialize_ada_language): Change help doc or code
 693         producing the help doc to respect the invariants.
 694         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 695         * breakpoint.c (_initialize_breakpoint): Likewise.
 696         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 697         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 698         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 699         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 700         _initialize_cli_style): Likewise.
 701         * corelow.c (core_target_info): Likewise.
 702         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 703         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 704         * filesystem.c (_initialize_filesystem): Likewise.
 705         * frame.c (_initialize_frame): Likewise.
 706         * gnu-nat.c (add_task_commands): Likewise.
 707         * infcall.c (_initialize_infcall): Likewise.
 708         * infcmd.c (_initialize_infcmd): Likewise.
 709         * interps.c (_initialize_interpreter): Likewise.
 710         * language.c (_initialize_language): Likewise.
 711         * linux-fork.c (_initialize_linux_fork): Likewise.
 712         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 713         * maint.c (_initialize_maint_cmds): Likewise.
 714         * memattr.c (_initialize_mem): Likewise.
 715         * printcmd.c (_initialize_printcmd): Likewise.
 716         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 717         _RegEx): Likewise.
 718         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 719         * record-btrace.c (_initialize_record_btrace): Likewise.
 720         * record-full.c (_initialize_record_full): Likewise.
 721         * record.c (_initialize_record): Likewise.
 722         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 723         * regcache.c (_initialize_regcache): Likewise.
 724         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 725         _initialize_remote): Likewise.
 726         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 727         * serial.c (_initialize_serial): Likewise.
 728         * skip.c (_initialize_step_skip): Likewise.
 729         * source.c (_initialize_source): Likewise.
 730         * stack.c (_initialize_stack): Likewise.
 731         * symfile.c (_initialize_symfile): Likewise.
 732         * symtab.c (_initialize_symtab): Likewise.
 733         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 734         * top.c (init_main): Likewise.
 735         * tracefile-tfile.c (tfile_target_info): Likewise.
 736         * tracepoint.c (_initialize_tracepoint): Likewise.
 737         * tui/tui-win.c (_initialize_tui_win): Likewise.
 738         * utils.c (add_internal_problem_command): Likewise.
 739         * valprint.c (value_print_option_defs): Likewise.
 740
 741 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 742
 743         PR build/24886
 744         * configure.ac: Drop enable-libmcheck support.
 745         * configure, config.in: Rebuild.
 746         * libmcheck.m4: Remove.
 747         * acinclude.m4: Don't include it.
 748         * Makefile.in: Don't distribute it.
 749         * top.c (print_gdb_configuration): Don't mention it.
 750
 751 2019-08-06  Tom Tromey  <tom@tromey.com>
 752
 753         * utils.c (set_output_style): Sometimes pass stream to
 754         emit_style_escape.
 755         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 756         * record-btrace.c (btrace_insn_history): Update.
 757         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 758         method.
 759         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 760         Update initializers.
 761         <m_uiout>: New field.
 762         <m_di>: Move lower.
 763         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 764         Remove "uiout" parameter.
 765         (dump_insns): Update.
 766         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 767         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 768
 769 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 770
 771         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 772         (error_in_psymtab_expansion): Likewise.
 773         (lookup_symbol_via_quick_fns): Likewise.
 774         (basic_lookup_transparent_type_quick): Likewise.
 775         (basic_lookup_transparent_type_1): Likewise.
 776
 777 2019-08-06  Tom Tromey  <tromey@adacore.com>
 778
 779         * source.c (last_source_error): Now bool.
 780         (print_source_lines_base): Make "noprint" bool.  Only open
 781         source file when last_source_visited changes.
 782
 783 2019-08-06  Tom Tromey  <tromey@adacore.com>
 784
 785         * annotate.c (annotate_source_line): Use g_source_cache.
 786         * source-cache.c (source_cache::get_plain_source_lines): Change
 787         parameters.  Populate m_offset_cache.
 788         (source_cache::ensure): New method.
 789         (source_cache::get_line_charpos): New method.
 790         (extract_lines): Move lower.  Change parameters.
 791         (source_cache::get_source_lines): Move lower.
 792         * source-cache.h (class source_cache): Update comment.
 793         <get_line_charpos>: New method.
 794         <get_source_lines>: Update comment.
 795         <clear>: Clear m_offset_cache.
 796         <get_plain_source_lines>: Change parameters.
 797         <ensure>: New method
 798         <m_offset_cache>: New member.
 799         * source.c (forget_cached_source_info_for_objfile): Update.
 800         (info_source_command): Use g_source_cache.
 801         (find_source_lines, open_source_file_with_line_charpos): Remove.
 802         (print_source_lines_base, search_command_helper): Use g_source_cache.
 803         * source.h (open_source_file_with_line_charpos): Don't declare.
 804         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 805         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 806         Use g_source_cache.
 807
 808 2019-08-06  Tom Tromey  <tromey@adacore.com>
 809
 810         * source-cache.c (source_cache::get_plain_source_lines):
 811         Remove "first_line" and "last_line" parameters.
 812         (source_cache::get_source_lines): Cache plain text.
 813         * source-cache.h (class source_cache)
 814         <get_plain_source_lines>: Update.
 815
 816 2019-08-06  Tom Tromey  <tromey@adacore.com>
 817
 818         * source-cache.c (extract_lines): No longer a method.
 819         Changed type of parameter.  Include final newline.
 820         (selftests::extract_lines_test): New function.
 821         (_initialize_source_cache): Likewise.
 822         * source-cache.h (class source_cache)
 823         <extract_lines>: Don't declare.
 824
 825 2019-08-06  Tom Tromey  <tromey@adacore.com>
 826
 827         * breakpoint.c (init_breakpoint_sal): Update.
 828         (breakpoint): Update.
 829         * breakpoint.h (struct breakpoint) <filter>: Now a
 830         unique_xmalloc_ptr.
 831
 832 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 833
 834         * NEWS: Mention dictionary access on blocks.
 835         * python/py-block.c (blpy_getitem): New function.
 836         (block_object_as_mapping): New struct.
 837         (block_object_type): Use new struct for tp_as_mapping field.
 838
 839 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 840
 841         * objfiles.h (objfile): Add a comment describing partial symbols.
 842
 843 2019-08-05  Tom Tromey  <tromey@adacore.com>
 844
 845         * compile/compile.c (_initialize_compile): Use _(), not N_().
 846         * thread.c (_initialize_thread): Use _(), not N_().
 847         * stack.c (_initialize_stack): Use _(), not N_().
 848         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 849
 850 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 851
 852         * dwarf2read.c (struct dw2_symtab_iterator):
 853         <want_specific_block>: Remove.
 854         <block_index>: Change type to gdb::optional.
 855         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 856         change type of BLOCK_INDEX parameter to gdb::optional.
 857         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 858         (dw2_lookup_symbol): Don't pass argument for
 859         WANT_SPECIFIC_BLOCK.
 860         (dw2_expand_symtabs_for_function): Don't pass argument for
 861         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 862         (class dw2_debug_names_iterator)
 863         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 864         parameter, change BLOCK_INDEX type to gdb::optional.
 865         <m_want_specific_block>: Remove.
 866         <m_block_index>: Change type to gdb::optional.
 867         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 868         gdb::optional.  Re-write in function of gdb::optional.
 869         (dw2_debug_names_lookup_symbol): Don't pass argument for
 870         WANT_SPECIFIC_BLOCK.
 871         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 872         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 873         BLOCK_INDEX.
 874
 875 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876
 877         * NEWS: Mention changes to "info sources" command.
 878
 879 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 880
 881         * symtab.c (filename_partial_match_opts): New struct type.
 882         (struct output_source_filename_data): New members
 883         regexp, c_regexp, partial_match.
 884         (output_source_filename): Use new members to decide to print file.
 885         (info_sources_option_defs): New variable.
 886         (make_info_sources_options_def_group, print_info_sources_header,
 887         info_sources_command_completer):
 888         New functions.
 889         (info_sources_command): Read new optional arguments.
 890         (_initialize_symtab): Update info sources help.
 891
 892 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 893
 894         * ada-lang.c (exception_support_info_v0): Renamed from...
 895         (default_exception_support_info): ... this.  Create new
 896         definition for v1.
 897         (ada_has_this_exception_support): Look up catch_handlers_sym.
 898         (ada_exception_support_info_sniffer): Try v0 after default.
 899
 900 2019-08-01  Tom Tromey  <tromey@adacore.com>
 901
 902         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 903         gdbarch.h.
 904
 905 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 906
 907         * s12z-tdep.c: Fix include path for s12z-opc.h.
 908
 909 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 910
 911         * NEWS: Require GNU make 3.82.
 912
 913 2019-07-16  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 916         declare.
 917
 918 2019-07-30  Tom Tromey  <tromey@adacore.com>
 919
 920         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 921
 922 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 923
 924         * printcmd.c (print_address_symbolic): Print negative offsets.
 925         (build_address_symbolic): Force signed arithmetic when computing
 926         offset.
 927
 928 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 929
 930         PR/24474: Add a function to lookup static variables.
 931         * NEWS: Mention this new function.
 932         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 933         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 934         * python/python.c (python_GdbMethods): Add new function.
 935
 936 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 937
 938         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 939         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 940         (objfpy_lookup_static_symbol): New function.
 941         (objfile_object_methods): Add new functions.
 942
 943 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 944
 945         * NEWS: Mention 'set|show print frame-info'.  Mention new
 946         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 947         backtrace argument.  Mention that python frame filtering code
 948         is now consistent with what 'backtrace' command prints.
 949
 950 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 951
 952         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 953         comments.
 954         (print_frame_info_auto, print_frame_info_source_line,
 955         print_frame_info_location, print_frame_info_source_and_location,
 956         print_frame_info_location_and_address, print_frame_info_short_location):
 957         New declarations.
 958         (struct frame_print_options): New member print_frame_info.
 959         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 960         * stack.h (get_user_print_what_frame_info): New declaration.
 961         (frame_show_address): New declaration.
 962         * stack.c (print_frame_arguments_choices): New value 'presence'.
 963         (print_frame_info_auto, print_frame_info_source_line,
 964         print_frame_info_location, print_frame_info_source_and_location,
 965         print_frame_info_location_and_address, print_frame_info_short_location,
 966         print_frame_info_choices, print_frame_info_print_what): New definitions.
 967         (print_frame_args): Only print dots for args if print frame-arguments
 968         is 'presence'.
 969         (frame_print_option_defs): New element for "frame-info".
 970         (get_user_print_what_frame_info): New function.
 971         (frame_show_address): Make non static.  Move comment to stack.h.
 972         (print_frame_info_to_print_what): New function.
 973         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 974         to decide what to print.
 975         (backtrace_command_1): Handle the new print_frame_arguments_presence
 976         value.
 977         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 978         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 979         (py_print_frame): In non-mi mode, use LOCATION as default for
 980         print_what, similarly to frame information printed directly by
 981         backtrace command. Handle frame-info user option in non MI mode.
 982
 983 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 984
 985         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 986         Add case for debugging 32-bit target on 64-bit host.  Revise
 987         comment.
 988
 989 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 990
 991         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 992         instead of find_function_entry_range_from_pc.
 993
 994 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 995
 996         * stack.c (find_frame_funname): Remove code which preferred
 997         minsym over symtab sym in "certain pathological cases".
 998
 999         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1000         parameter.  Change type of "do_demangle" to bool.
1001         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1002         Pass suitable "prefer_sym_over_minsym" flag to
1003         build_address_symbolic().  Don't output "+" for negative offsets.
1004         * printcmd.c (print_address_symbolic): Update invocation of
1005         build_address_symbolic to include a "prefer_sym_over_minsym"
1006         flag.
1007         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1008         Restrict cases in which use of minimal symbol is preferred to that
1009         of a found symbol.  Update comments.
1010
1011         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1012         for entry pc when entry pc is out of range for that FDE.
1013
1014 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1015
1016         PR gdb/24839:
1017         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1018         type.
1019
1020 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1021
1022         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1023         this function's Python signature.
1024
1025
1026 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1027
1028         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1029         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1030         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1031         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1032         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1033
1034
1035 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1036
1037         * h8300-tdep.c (h8300_register_name_common): New.
1038         h8300_register_name): Use h8300_register_name_common.
1039         (h8300s_register_name): Likewise.
1040         (h8300sx_register_name): Likewise.
1041         (h8300h_register_nam): New.
1042         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1043
1044
1045 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1046
1047         * arm-tdep.c (arm_skip_cmse_entry): New function.
1048         (arm_is_sgstubs_section): New function.
1049         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1050
1051 2019-07-22  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1054         Don't self-assign.
1055
1056 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1059         type_print.
1060
1061 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1064         so that GDB doesn't match any msymbols when searching in the
1065         TYPES_DOMAIN.
1066         (print_symbol_info): Print using typedef_print or type_print based
1067         on the type of the symbol.  Add updated FIXME comment moved from...
1068         (_initialize_symtab): ... move and update FIXME comment to above.
1069
1070 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * NEWS: Mention adding -q option to "info types".
1073         * symtab.c (struct info_types_options): New struct.
1074         (info_types_options_defs): New variable.
1075         (make_info_types_options_def_group): New function.
1076         (info_types_command): Use gdb::option framework to parse options.
1077         (info_types_command_completer): New function.
1078         (_initialize_symtab): Extend the help text on "info types" and
1079         register command completer.
1080
1081 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1082
1083         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1084         (lookup_symbol_in_objfile): Change int to block_enum and add a
1085         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1086
1087 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1088
1089         * MAINTAINERS (Write After Approval): Add self.
1090
1091 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1094         instruction to the dummy code region.
1095
1096 2019-07-19  Tom Tromey  <tromey@adacore.com>
1097
1098         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1099         (ARGSUSED, PARAMS, __func__): Remove rules.
1100
1101 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1102
1103         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1104         * features/arm/arm-with-iwmmxt.c: Remove.
1105         * features/arm/arm-with-iwmmxt.xml: Remove.
1106         * features/arm/arm-with-m-fpa-layout.c: Remove.
1107         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1108         * features/arm/arm-with-m-vfp-d16.c: Remove.
1109         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1110         * features/arm/arm-with-m.c: Remove.
1111         * features/arm/arm-with-m.xml: Remove.
1112         * features/arm/arm-with-neon.c: Remove.
1113         * features/arm/arm-with-neon.xml: Remove.
1114         * features/arm/arm-with-vfpv2.c: Remove.
1115         * features/arm/arm-with-vfpv2.xml: Remove.
1116         * features/arm/arm-with-vfpv3.c: Remove.
1117         * features/arm/arm-with-vfpv3.xml: Remove.
1118
1119 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1120
1121         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1122
1123 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1124
1125         * arch/aarch32.c (aarch32_create_target_description): Create
1126         target descriptions using features.
1127         * arch/arm.c (arm_create_target_description)
1128         (arm_create_mprofile_target_description): Likewise.
1129         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1130
1131 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * Makefile.in: Add new files.
1134         * aarch32-tdep.c: New file.
1135         * aarch32-tdep.h: New file.
1136         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1137         Call aarch32_read_description.
1138         * arch/aarch32.c: New file.
1139         * arch/aarch32.h: New file.
1140         * arch/arm.c (arm_create_target_description)
1141         (arm_create_mprofile_target_description): New function.
1142         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1143         (arm_create_target_description)
1144         (arm_create_mprofile_target_description): New declaration.
1145         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1146         read_description functions.
1147         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1148         Likewise.
1149         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1150         * arm-tdep.c (tdesc_arm_list): New variable.
1151         (arm_register_g_packet_guesses): Call create description functions.
1152         (arm_read_description) (arm_read_mprofile_description): New
1153         function.
1154         * arm-tdep.h (arm_read_description)
1155         (arm_read_mprofile_description): Add declaration.
1156         * configure.tgt: Add new files.
1157
1158 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1159
1160         * top.c (new_ui_command): Open specified terminal just once.
1161
1162 2019-07-18  Tom Tromey  <tromey@adacore.com>
1163
1164         * symtab.c (main_name): Constify return type.
1165         * symfile.c (set_initial_language): Update.
1166         * symtab.h (main_name): Constify return type.
1167
1168 2019-07-17  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-winsource.c (tui_update_source_window)
1171         (tui_update_source_window_as_is)
1172         (tui_update_source_windows_with_line): Remove return.
1173         * tui/tui-disasm.c (tui_show_disassem)
1174         (tui_show_disassem_and_update_source): Remove return.
1175         * tui/tui.c (tui_reset): Remove return.
1176         * tui/tui-wingeneral.c
1177         (tui_check_and_display_highlight_if_needed): Remove return.
1178
1179 2019-07-17  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1182
1183 2019-07-17  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-winsource.h (struct tui_exec_info_window)
1186         (struct tui_source_window_base): Move from tui-data.h.
1187         * tui/tui-winsource.c: Move many method definitions from
1188         elsewhere.  Remove "structuring" comments.
1189         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1190         (tui_source_window_base::refresh_window): Move to
1191         tui-winsource.c.
1192         * tui/tui-win.c (tui_source_window_base::refresh_all)
1193         (tui_source_window_base::update_tab_width)
1194         (tui_source_window_base::set_new_height)
1195         (tui_source_window_base::do_make_visible_with_new_height): Move to
1196         tui-winsource.c.
1197         * tui/tui-source.h: Update.
1198         * tui/tui-source.c (tui_source_window_base::reset): Move to
1199         tui-winsource.c.
1200         * tui/tui-disasm.h: Update.
1201         * tui/tui-data.h (struct tui_exec_info_window): Move to
1202         tui-winsource.h.
1203         (struct tui_source_window_base): Likewise.
1204         * tui/tui-data.c (tui_source_window_base::clear_detail)
1205         (tui_source_window_base, ~tui_source_window_base): Move to
1206         tui-winsource.c.
1207
1208 2019-07-17  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-win.c (tui_resize_all)
1211         (tui_source_window_base::update_tab_width)
1212         (tui_adjust_win_heights): Update.
1213         (tui_win_info::make_invisible_and_set_new_height): Rename from
1214         make_invisible_and_set_new_height.
1215         * tui/tui-data.h (struct tui_win_info)
1216         <make_invisible_and_set_new_height>: New method.
1217
1218 2019-07-17  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui.c: Update.
1221         * tui/tui-source.h (struct tui_source_window): Move from
1222         tui-data.h.
1223         * tui/tui-layout.c: Update.
1224         * tui/tui-disasm.c: Update.
1225         * tui/tui-data.h (struct tui_source_window): Move to
1226         tui-source.h.
1227
1228 2019-07-17  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1231         tui-data.h.
1232         * tui/tui-data.h (struct tui_disasm_window): Move to
1233         tui-disasm.h.
1234
1235 2019-07-17  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-regs.h (struct tui_data_item_window): Move from
1238         tui-data.h.
1239         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1240         * tui/tui-data.h (struct tui_data_item_window): Move to
1241         tui-regs.h.
1242         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1243
1244 2019-07-17  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui.c: Update.
1247         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1248         (tui_cmd_window::max_height): Move to tui-command.c.
1249         * tui/tui-layout.c: Update.
1250         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1251         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1252         tui-command.c.
1253         * tui/tui-command.h (struct tui_cmd_window): Move from
1254         tui-data.h.
1255         * tui/tui-command.c: Remove "structuring" comments.
1256         (tui_cmd_window::clear_detail)
1257         (tui_cmd_window::do_make_visible_with_new_height)
1258         (tui_cmd_window::max_height): Move from elsewhere.
1259
1260 2019-07-17  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1263         Now static.
1264         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1265         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1266
1267 2019-07-17  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui.c: Update.
1270         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1271         tui-regs.c.
1272         * tui/tui-windata.h: Remove file.
1273         * tui/tui-windata.c: Remove file.
1274         * tui/tui-win.c (tui_data_window::set_new_height)
1275         (tui_data_window::do_make_visible_with_new_height): Move to
1276         tui-regs.c.
1277         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1278         * tui/tui-regs.c: Remove "structuring" comments.
1279         (tui_data_window::first_data_item_displayed)
1280         (tui_data_window::delete_data_content_windows)
1281         (tui_data_window::erase_data_content)
1282         (tui_data_window::display_all_data)
1283         (tui_data_window::refresh_all)
1284         (tui_data_window::do_scroll_vertical)
1285         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1286         (tui_data_window::do_make_visible_with_new_height)
1287         (tui_data_window::refresh_window): Move from elsewhere.
1288         (_initialize_tui_regs): Move to end of file.
1289         * tui/tui-layout.c: Update.
1290         * tui/tui-hooks.c: Update.
1291         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1292         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1293         tui-regs.c.
1294         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1295
1296 2019-07-17  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1299         seen.
1300
1301 2019-07-17  Tom Tromey  <tom@tromey.com>
1302
1303         * tui/tui-win.c (tui_source_window_base::set_new_height)
1304         (tui_source_window_base::do_make_visible_with_new_height): Use
1305         m_has_locator field directly.
1306         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1307         method.
1308         (struct tui_source_window_base) <has_locator>: Likewise.
1309
1310 2019-07-17  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1313         Don't declare.
1314         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1315         Remove.
1316         * tui/tui-win.c (tui_source_window_base::set_new_height)
1317         (tui_source_window_base::set_new_height)
1318         (make_invisible_and_set_new_height)
1319         (tui_source_window_base::do_make_visible_with_new_height)
1320         (tui_source_window_base::do_make_visible_with_new_height):
1321         Update.
1322         * tui/tui-layout.c (show_source_disasm_command, show_data)
1323         (show_source_or_disasm_and_command): Update.
1324         * tui/tui-layout.c (show_layout): Update.
1325
1326 2019-07-17  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-layout.c (make_data_window): Remove.
1329         (show_data): Unify creation and re-initialization cases.
1330
1331 2019-07-17  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-layout.c (make_source_window, make_disasm_window):
1334         Remove.
1335         (show_data): Unify creation and re-initialization cases.
1336
1337 2019-07-17  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-layout.c (make_command_window): Remove.
1340         (show_source_disasm_command, show_source_or_disasm_and_command):
1341         Unify creation and re-initialization cases.
1342
1343 2019-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1346         creation and re-initialization cases.
1347
1348 2019-07-17  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-regs.c (tui_get_register): Return void.
1351
1352 2019-07-17  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1355         Simplify.
1356
1357 2019-07-17  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1360         resetting.
1361
1362 2019-07-17  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1365         * tui/tui-regs.c (tui_reg_layout): New function.
1366         (tui_show_registers, tui_reg_command): Use it.
1367         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1368         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1369         parameters.
1370         (tui_layout_command): Remove.
1371
1372 2019-07-17  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-layout.h (tui/tui-layout): Return void.
1375         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1376
1377 2019-07-17  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-layout.c (show_source_disasm_command, show_data):
1380         Update.
1381         (reset_locator): Remove.
1382         (show_source_or_disasm_and_command): Update.
1383
1384 2019-07-17  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-source.c (tui_source_window_base::reset): Remove
1387         win_type parameter.
1388         * tui/tui-layout.c (make_command_window, make_source_window)
1389         (make_disasm_window, make_data_window)
1390         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1391         (reset_locator, show_source_or_disasm_and_command): Update.
1392         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1393         win_type parameter.
1394         (struct tui_source_window_base) <reset>: Likewise.
1395
1396 2019-07-17  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-layout.c (show_source_disasm_command): Use
1399         reset_locator.
1400         (reset_locator): New function.
1401         (init_and_make_win): Remove.
1402         (show_source_or_disasm_and_command): Use reset_locator.
1403
1404 2019-07-17  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1407         condition.
1408         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1409         Remove condition.
1410         * tui/tui-source.c (tui_source_window_base::reset): New method.
1411         * tui/tui-layout.c (make_command_window): Don't call
1412         init_and_make_win.
1413         (make_source_window, make_disasm_window): Don't call
1414         make_source_or_disasm_window.
1415         (make_data_window): Don't call init_and_make_win.  Change calling
1416         convention.
1417         (show_source_disasm_command, show_data): Simplify.
1418         (make_source_or_disasm_window): Remove.
1419         (show_source_or_disasm_and_command): Simplify.
1420         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1421         (struct tui_source_window_base) <reset>: Likewise.
1422         <execution_info>: Remove initializer.
1423         * tui/tui-data.c (tui_source_window_base): Initialize
1424         execution_info.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1429         variable.
1430
1431 2019-07-17  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui.c (tui_rl_other_window): Update.
1434         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1435         superclass method first.  Always iterate over regs_content.
1436         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1437         method.
1438         * tui/tui-win.c (tui_set_focus_command): Update.
1439
1440 2019-07-17  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-win.c (tui_set_focus_command): Rename from
1443         tui_set_focus.  Call tui_enable.
1444         (tui_set_focus_command): Remove.
1445
1446 2019-07-17  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1449         refresh_window.
1450         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1451         touchwin.
1452         (tui_data_window::refresh_window): Call refresh_window on data
1453         items.  Always call superclass refresh_window.
1454         (tui_win_info::refresh): Remove.
1455         (tui_source_window_base::refresh_window): Update.
1456         (tui_refresh_all): Update.
1457         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1458         refresh_window.
1459         (show_source_or_disasm_and_command): Likewise.
1460         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1461         (struct tui_source_window_base) <refresh>: Likewise.
1462
1463 2019-07-17  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-winsource.c (tui_clear_source_content)
1466         (tui_show_source_content): Update.
1467         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1468         whether content is empty.
1469         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1470         Remove.
1471
1472 2019-07-17  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1475         window's contents.
1476         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1477         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1482         (struct tui_data_item_window): Update.
1483
1484 2019-07-17  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1487         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1488         defines.
1489
1490 2019-07-17  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-winsource.h (tui_erase_source_content)
1493         (tui_clear_source_content): Remove "display_prompt" parameter.
1494         * tui/tui-winsource.c (tui_update_source_window_as_is)
1495         (tui_update_source_windows_with_addr): Update.
1496         (tui_clear_source_content): Remove "display_prompt" parameter.
1497         (tui_erase_source_content): Likewise.  Simplify.
1498         (tui_show_source_content): Update.
1499         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1500         * tui/tui-stack.c (tui_show_frame_info): Update.
1501         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1502         Remove defines.
1503
1504 2019-07-17  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1507         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1508         parameter.
1509         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1510         parameter.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-winsource.c (tui_clear_source_content)
1515         (tui_show_source_content, tui_show_exec_info_content)
1516         (tui_clear_exec_info_content): Update.
1517         * tui/tui-stack.c (tui_show_locator_content): Update.
1518         (tui_show_frame_info): Update.
1519         * tui/tui-source.h (tui_source_window): Don't declare.
1520         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1521         from tui_source_is_displayed.
1522         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1523         Remove field.
1524         (struct tui_source_window_base) <content_in_use>: New field.  Now
1525         bool.
1526         (struct tui_source_window) <showing_source_p>: New method.
1527         (TUI_SRC_WIN): Change cast.
1528         * tui/tui-data.c (tui_initialize_static_data): Update.
1529
1530 2019-07-17  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1533         location_matches_p.
1534         * tui/tui-source.c (tui_source_window::location_matches_p): New
1535         method.
1536         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1537         method.
1538         * tui/tui-data.h (struct tui_source_window_base)
1539         <location_matches_p>: New method.
1540         (struct tui_source_window, struct tui_disasm_window)
1541         <location_matches_p>: Likewise.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-win.c (tui_set_win_height_command): Rename from
1546         tui_set_win_height.
1547         (tui_set_win_height_command): Remove.
1548
1549 2019-07-17  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-source.c (tui_source_window): New constructor.  Add
1552         observer.
1553         (~tui_source_window): New destructor.
1554         (tui_source_window::style_changed): New method.
1555         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1556         (tui_attach_detach_observers): Update.
1557         * tui/tui-data.h (struct tui_source_window): Make constructor not
1558         inline.  Add destructor.
1559         (struct tui_source_window) <style_changed>: New method.
1560         <m_observable>: New member.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1565         * tui/tui-win.c (tui_resize_all): Fix typo.
1566
1567 2019-07-17  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1570         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1571         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1572         * tui/tui-win.c (window_name_completer): Use foreach.
1573         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1574         (update_tab_width): Likewise.
1575         * tui/tui-layout.c (show_layout): Update.
1576         * tui/tui-data.h (class tui_window_iterator): New.
1577         (struct all_tui_windows): New.
1578         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1579
1580 2019-07-17  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1583         parameter.  Don't reference globals.
1584         (tui_reg_command): Update.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-regs.c (tui_show_registers): Simplify.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-regs.c (tui_show_registers): Update.
1593         (tui_show_register_group): Add win_info parameter.
1594
1595 2019-07-17  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1598         Rename from tui_display_reg_element_at_line.
1599         (tui_data_window::display_registers_from_line): Update.
1600         * tui/tui-data.h (struct tui_data_window)
1601         <display_reg_element_at_line>: New method.
1602
1603 2019-07-17  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-regs.h (tui_display_registers_from)
1606         (tui_display_registers_from_line): Don't declare.
1607         * tui/tui-windata.c (tui_data_window::display_all_data)
1608         (tui_data_window::refresh_all)
1609         (tui_data_window::do_scroll_vertical): Update.
1610         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1611         from tui_display_registers_from.
1612         (tui_display_reg_element_at_line): Update.
1613         (tui_data_window::display_registers_from_line): Rename from
1614         tui_display_registers_from_line.
1615         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1616         display_registers_from_line>: New methods.
1617
1618 2019-07-17  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1621         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1622         from tui_erase_data_content.
1623         (tui_data_window::display_all_data)
1624         (tui_data_window::refresh_all)
1625         (tui_data_window::do_scroll_vertical): Update.
1626         * tui/tui-regs.c (tui_show_registers): Update.
1627         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1628         New method.
1629
1630 2019-07-17  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1633         declare.
1634         * tui/tui-windata.c
1635         (tui_data_window::delete_data_content_windows): Rename from
1636         tui_delete_data_content_windows.
1637         (tui_data_window::display_all_data)
1638         (tui_data_window::do_scroll_vertical): Update.
1639         * tui/tui-data.h (struct tui_data_window)
1640         <delete_data_content_windows>: New method.
1641
1642 2019-07-17  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1645         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1646
1647 2019-07-17  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1650         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1651         from tui_display_all_data.
1652         * tui/tui-win.c
1653         (tui_data_window::do_make_visible_with_new_height): Update.
1654         * tui/tui-regs.c (tui_show_registers): Update.
1655         * tui/tui-layout.c (tui_set_layout): Update.
1656         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1657         method.
1658
1659 2019-07-17  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1662         * tui/tui-windata.c (tui_display_data_from): Remove.
1663         (tui_data_window::refresh_all): Update.
1664
1665 2019-07-17  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1668         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1669         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1670         tui_display_registers_from_line.
1671         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1672         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1673         "force_display" parameter.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1678         declare.
1679         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1680         Rename from tui_first_reg_element_no_inline.
1681         (tui_display_reg_element_at_line)
1682         (tui_display_registers_from_line): Update.
1683         * tui/tui-data.h (struct tui_data_window)
1684         <first_reg_element_no_inline>: New method.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-windata.c (tui_display_data_from)
1689         (tui_data_window::do_scroll_vertical): Update.
1690         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1691         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1692         Rename from tui_line_from_reg_element_no.
1693         (tui_display_registers_from_line): Update.
1694         * tui/tui-data.h (struct tui_data_window)
1695         <line_from_reg_element_no>: New method.
1696
1697 2019-07-17  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1700         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1701         tui_last_regs_line_no.
1702         (tui_display_reg_element_at_line)
1703         (tui_display_registers_from_line): Update.
1704         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1705         method.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         PR tui/24722:
1710         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1711         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1712         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1713         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1714         (tui_update_breakpoint_info): Likewise.
1715         * tui/tui-hooks.c (tui_event_create_breakpoint)
1716         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1717         Update.
1718
1719 2019-07-17  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1722
1723 2019-07-17  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-winsource.c (tui_update_source_window_as_is)
1726         (tui_update_source_windows_with_addr): Update.
1727         * tui/tui-source.h (tui_set_source_content)
1728         (tui_show_symtab_source): Add "win_info" parameter.
1729         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1730         parameter.
1731         (tui_show_symtab_source): Likewise.
1732
1733 2019-07-17  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-wingeneral.c
1736         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1737
1738 2019-07-17  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1741         (struct tui_cmd_window) <can_scroll>: New method.
1742         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1743         method.
1744
1745 2019-07-17  Tom Tromey  <tromey@adacore.com>
1746
1747         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1748         do_field_signed>: Rename.  Change type of "value".
1749         * ui-out.c (ui_out::field_signed): Rename from field_int.
1750         Change type of "value".
1751         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1752         type of "value".
1753         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1754         do_field_int.  Change type of "value".
1755         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1756         do_field_int.  Change type of "value".
1757         * tracepoint.c (trace_status_mi, tfind_1)
1758         (print_one_static_tracepoint_marker): Update.
1759         * thread.c (print_thread_info_1, print_selected_thread_frame):
1760         Update.
1761         * stack.c (print_frame, print_frame_info): Update.
1762         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1763         Update.
1764         * source.c (print_source_lines_base): Update.
1765         * skip.c (info_skip_command): Update.
1766         * record-btrace.c (btrace_ui_out_decode_error)
1767         (btrace_call_history_src_line): Update.
1768         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1769         Update.
1770         * progspace.c (print_program_space): Update.
1771         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1772         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1773         do_field_int.  Change type of "value".
1774         * mi/mi-out.c (mi_ui_out::do_table_begin)
1775         (mi_ui_out::do_table_header): Update.
1776         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1777         type of "value".
1778         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1779         (mi_cmd_data_list_changed_registers, output_register)
1780         (mi_cmd_data_read_memory, mi_load_progress)
1781         (mi_cmd_trace_frame_collected): Update.
1782         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1783         Update.
1784         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1785         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1786         (mi_cmd_var_list_children, varobj_update_one): Update.
1787         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1788         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1789         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1790         * inferior.c (print_inferior): Update.
1791         * gdb_bfd.c (print_one_bfd): Update.
1792         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1793         Update.
1794         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1795         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1796         do_field_int.  Change type of "value".
1797         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1798         do_field_int.  Change type of "value".
1799         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1800         (print_one_breakpoint_location, print_it_catch_fork)
1801         (print_one_catch_fork, print_it_catch_vfork)
1802         (print_one_catch_vfork, print_it_catch_solib)
1803         (print_it_catch_exec, print_it_ranged_breakpoint)
1804         (print_mention_watchpoint, print_mention_masked_watchpoint)
1805         (bkpt_print_it, update_static_tracepoint): Update.
1806         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1807         * break-catch-syscall.c (print_it_catch_syscall): Update.
1808         * ada-tasks.c (print_ada_task_info): Update.
1809         * ada-lang.c (print_it_exception, print_mention_exception):
1810         Update.
1811
1812 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         PR breakpoints/24541
1815         * gdbarch.c: Regenerate.
1816         * gdbarch.h: Regenerate.
1817         * gdbarch.sh: Adjust return type and parameter types for
1818         'stap_adjust_register'.
1819         (i386_stap_adjust_register): Adjust signature and return new
1820         register name.
1821         * stap-probe.c (stap_parse_register_operand): Adjust use of
1822         'gdbarch_stap_adjust_register'.
1823
1824 2019-07-17  Tom Tromey  <tromey@adacore.com>
1825
1826         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1827         declare VEC.
1828         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1829         std::vector.
1830         (struct s390_process_info): Add initializers.
1831         (s390_add_process): Use new.
1832         (s390_linux_nat_target::low_forget_process): Use delete.
1833         (s390_linux_nat_target::low_new_fork)
1834         (s390_linux_nat_target::stopped_by_watchpoint)
1835         (s390_linux_nat_target::low_prepare_to_resume)
1836         (s390_linux_nat_target::insert_watchpoint)
1837         (s390_linux_nat_target::insert_hw_breakpoint)
1838         (s390_linux_nat_target::remove_watchpoint)
1839         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1840
1841 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1842
1843         * aarch64-fbsd-nat.c: Include regcache.h.
1844         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1845         argument.
1846         (aarch64_fbsd_nat_target::fetch_registers)
1847         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1848         variable.
1849         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1850
1851 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1852
1853         * fbsd-nat.c: Include gdbarch.h.
1854
1855 2019-07-15  Tom Tromey  <tromey@adacore.com>
1856
1857         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1858
1859 2019-07-15  Tom Tromey  <tromey@adacore.com>
1860
1861         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1862         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1863         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1864         * cli-out.c (cli_ui_out::do_field_int): New method.
1865         * ui-out.c (ui_out::field_unsigned): New method.
1866         * symfile.c (generic_load): Use field_unsigned.
1867         (print_transfer_performance): Likewise.
1868         * record-btrace.c (ui_out_field_uint): Remove.
1869         (btrace_call_history_insn_range, btrace_call_history): Use
1870         field_unsigned.
1871         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1872         field_unsigned.
1873         * ui-out.h (class ui_out) <field_unsigned>: New method.
1874         <do_field_unsigned>: Likewise.
1875
1876 2019-07-15  Tom Tromey  <tromey@adacore.com>
1877
1878         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1879         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1880         * target.c (flash_erase_command): Use field_string.
1881         * infrun.c (print_signal_received_reason): Use field_string.
1882         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1883         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1884         field_string.
1885         * ada-tasks.c (print_ada_task_info): Use field_string.
1886
1887 2019-07-15  Tom Tromey  <tromey@adacore.com>
1888
1889         * target.c (flash_erase_command): Use field_core_addr.
1890         * symfile.c (generic_load): Use field_core_addr.
1891         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1892         Use field_core_addr.
1893         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1894         field_core_addr.
1895
1896 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1899         value if its desired type is smaller than a CORE_ADDR and signed.
1900
1901 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1902
1903         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1904         of changes to field names, and use new is_reference field to
1905         decide if a property is a reference or not.
1906         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1907         field.
1908         (struct dwarf2_property_baton): Update header comment, rename
1909         'referenced_type' to 'property_type' and update comments.
1910         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1911         default property type, store in property baton, update to take
1912         accound of renamed field.
1913         (read_func_scope): Update call to attr_to_dynamic_prop.
1914         (read_array_type): Likewise.
1915         (dwarf2_per_cu_addr_sized_int_type): New function.
1916         (read_subrange_index_type): Move type finding code to
1917         dwarf2_per_cu_addr_sized_int_type.
1918         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1919         (dwarf2_per_cu_addr_type): New function.
1920         (set_die_type): Update calls to attr_to_dynamic_prop.
1921
1922 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * dwarf2read.c (read_subrange_index_type): New function.
1925         (read_subrange_type): Move code into new function and call it.
1926         * gdbtypes.c (create_range_type): Add some asserts.
1927
1928 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1931         update return statements.
1932         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1933         declaration, and update comment to match.
1934         * gdbtypes.c (resolve_dynamic_array): Update call to
1935         dwarf2_evaluate_property to match new return type.
1936
1937 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * valarith.c (value_subscripted_rvalue): Change lowerbound
1940         parameter type from int to LONGEST.
1941         * value.h (value_subscripted_rvalue): Likewise in declaration.
1942
1943 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * cli/cli-utils.c (info_print_command_completer): New function.
1946         * cli/cli-utils.h: Add 'completer.h' include, and forward
1947         declaration for 'struct cmd_list_element'.
1948         (info_print_command_completer): Declare.
1949         * stack.c (_initialize_stack): Add completer for 'info locals' and
1950         'info args'.
1951         * symtab.c (_initialize_symtab): Add completer for 'info
1952         variables' and 'info functions'.
1953         * NEWS: Mention completion for additional info commands.
1954
1955 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * cli/cli-utils.c (extract_info_print_args): Delete.
1958         (extract_arg_maybe_quoted): Delete.
1959         (info_print_options_defs): New variable.
1960         (make_info_print_options_def_group): New function.
1961         (extract_info_print_options): Define new function.
1962         * cli/cli-utils.h (extract_info_print_args): Delete.
1963         (struct info_print_options): New structure.
1964         (extract_info_print_options): Declare new function.
1965         * stack.c (info_locals_command): Update to use new
1966         extract_info_print_options, also add a header comment.
1967         (info_args_command): Likewise.
1968         * symtab.c (info_variables_command): Likewise.
1969         (info_functions_command): Likewise.
1970
1971 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1972
1973         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1974         to extract string arguments.
1975         * common/common-utils.c (extract_string_maybe_quoted): New function.
1976         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1977
1978 2019-07-11  Tom Tromey  <tromey@adacore.com>
1979
1980         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1981         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1982         * top.h (gdbinit): Don't declare.
1983         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1984         into...
1985         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1986         * top.c (gdb_init): Don't call init_cli_cmds.
1987         (gdbinit): Remove.
1988         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1989
1990 2019-07-11  Tom Tromey  <tromey@adacore.com>
1991
1992         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1993         after it has been moved.
1994
1995 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1996
1997         * valops.c (value_must_coerce_to_target): Change return type to
1998         bool.
1999         * value.h (value_must_coerce_to_target): Likewise.
2000
2001 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2002
2003         * breakpoint.c (is_hardware_watchpoint): Remove
2004         forward-declaration.
2005         (is_masked_watchpoint): Change return type to bool.
2006         (is_tracepoint): Likewise.
2007         (is_breakpoint): Likewise.
2008         (is_hardware_watchpoint): Likewise.
2009         (is_watchpoint): Likewise.
2010         (is_no_memory_software_watchpoint): Likewise.
2011         (is_catchpoint): Likewise.
2012         (breakpoint_1): Make FILTER parameter's return type bool.
2013         is_masked_watchpoint): Change return type to bool.
2014         (save_breakpoints): Make FILTER parameter's return type bool.
2015         * breakpoint.h (is_breakpoint): Change return type to bool.
2016         (is_watchpoint): Likewise.
2017         (is_catchpoint): Likewise.
2018         (is_tracepoint): Likewise.
2019
2020 2019-07-10  Tom Tromey  <tom@tromey.com>
2021
2022         * defs.h: Don't include gdbarch.h.
2023         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2024         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2025         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2026         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2027         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2028         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2029         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2030         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2031         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2032         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2033         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2034         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2035         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2036         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2037         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2038         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2039         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2040         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2041         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2042         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2043         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2044         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2045         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2046         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2047         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2048         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2049         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2050
2051 2019-07-10  Tom Tromey  <tromey@adacore.com>
2052
2053         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2054         * breakpoint.c (init_ada_exception_breakpoint): Register as
2055         bp_catchpoint.
2056         (print_one_breakpoint_location, print_one_breakpoint): Use
2057         is_ada_exception_catchpoint.
2058         * ada-lang.c (class ada_catchpoint_location): Pass
2059         bp_loc_software_breakpoint to bp_location constructor.
2060         (is_ada_exception_catchpoint): New function.
2061
2062 2019-07-10  Tom Tromey  <tromey@adacore.com>
2063
2064         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2065         VEC.
2066         (struct arm_exidx_entry): New method operator<.
2067         (struct arm_exidx_data) <section_maps>: Change type.
2068         (arm_exidx_data_free): Remove.
2069         (arm_exidx_data_key): Change type.  Move lower.
2070         (arm_exidx_new_objfile): Update.
2071         (arm_compare_exidx_entries): Remove.
2072         (arm_find_exidx_entry, _initialize_arm_tdep)
2073
2074 2019-07-10  Tom Tromey  <tromey@adacore.com>
2075
2076         * solib-spu.c (ocl_program_data_key): Change type.
2077         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2078         Update.
2079
2080 2019-07-10  Tom Tromey  <tromey@adacore.com>
2081
2082         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2083         (struct solib_aix_inferior_data) <library_list>: Change type.
2084         (solib_aix_inferior_data_handle): Change type.
2085         (get_solib_aix_inferior_data): Update.
2086         (solib_aix_free_library_list): Remove.
2087         (library_list_start_library): Update.
2088         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2089         return type.
2090         (solib_aix_get_library_list)
2091         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2092         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2093
2094 2019-07-10  Tom Tromey  <tromey@adacore.com>
2095
2096         * solib-dsbt.c (struct dsbt_info): Add initializers.
2097         (solib_dsbt_pspace_data): Change type.
2098         (dsbt_pspace_data_cleanup): Remove.
2099         (get_dsbt_info, _initialize_dsbt_solib): Update.
2100
2101 2019-07-10  Tom Tromey  <tromey@adacore.com>
2102
2103         * spu-tdep.c (spu_overlay_data): Change type.
2104         (spu_get_overlay_table, spu_overlay_new_objfile)
2105         (_initialize_spu_tdep): Update.
2106
2107 2019-07-10  Tom Tromey  <tromey@adacore.com>
2108
2109         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2110         destructor.
2111         (dbx_objfile_data_key): Change type and declare later.
2112         (DBX_SYMFILE_INFO): Rewrite.
2113         * dbxread.c (dbx_objfile_data_key): Change type.
2114         (dbx_symfile_init): Update.
2115         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2116         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2117         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2118
2119 2019-07-10  Tom Tromey  <tromey@adacore.com>
2120
2121         * jit.c (jit_program_space_key): Change type.  Move lower.
2122         (get_jit_program_space_data): Update.
2123         (jit_program_space_data_cleanup): Remove.
2124         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2125         Update.
2126         (struct jit_program_space_data): Add initializers.
2127
2128 2019-07-10  Tom Tromey  <tromey@adacore.com>
2129
2130         * solib-darwin.c (struct darwin_info): Add initializers.
2131         (solib_darwin_pspace_data): Change type.
2132         (darwin_pspace_data_cleanup): Remove.
2133         (get_darwin_info, _initialize_darwin_solib): Update.
2134
2135 2019-07-10  Tom Tromey  <tromey@adacore.com>
2136
2137         * remote-sim.c (struct sim_inferior_data): Add initializers,
2138         constructor, and destructor.
2139         (sim_inferior_data_key): Change type.  Move lower.
2140         (check_for_duplicate_sim_descriptor): Update.
2141         (get_sim_inferior_data): Use new.  Update.
2142         (~sim_inferior_data_cleanup): Rename from
2143         sim_inferior_data_cleanup.  Simplify.
2144         (gdbsim_close_inferior, simulator_command)
2145         (sim_command_completer, _initialize_remote_sim): Update.
2146         (next_pid, INITIAL_PID): Move earlier.
2147
2148 2019-07-10  Tom Tromey  <tromey@adacore.com>
2149
2150         * python/python-internal.h (create_thread_object): Return
2151         gdbpy_ref.
2152         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2153         * python/py-inferior.c (struct threadlist_entry): Add
2154         constructor.
2155         <thread_obj>: Now a gdbpy_ref.
2156         (thread_to_thread_object): Update.
2157         (add_thread_object): Use new.
2158         (delete_thread_object): Use delete.
2159         (infpy_threads): Update.
2160         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2161         GIL.
2162
2163 2019-07-10  Tom Tromey  <tromey@adacore.com>
2164
2165         * valops.c (value_cast): Specialize error message for Ada.
2166
2167 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2168
2169         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2170
2171 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2172
2173         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2174         bpstat_should_step): Return bool, adjust comments.
2175         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2176         bpstat_should_step): Likewise.
2177
2178 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2179
2180         * features/Makefile: Use feature target descriptions for Arm.
2181         * features/arm/arm-core.c: Generate new file.
2182         * features/arm/arm-fpa.c: Likewise.
2183         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2184         * features/arm/arm-m-profile.c: Likewise.
2185         * features/arm/arm-vfpv2.c: Likewise.
2186         * features/arm/arm-vfpv3.c: Likewise.
2187         * features/arm/xscale-iwmmxt.c: Likewise.
2188         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2189
2190 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2191
2192         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2193         ptrace earlier.
2194
2195 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2196
2197         * features/aarch64-pauth.c: Regenerate.
2198
2199 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2200
2201         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2202         bool.
2203         (bpstat_what): Use false instead of 0.
2204
2205 2019-07-09  Pedro Alves  <palves@redhat.com>
2206
2207         * break-catch-throw.c (is_exception_catchpoint): New.
2208         * breakpoint.c (print_one_breakpoint_location): New parameter
2209         'raw_loc'.  Handle it.  Use
2210         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2211         looking at the breakpoint's type.
2212         (print_one_breakpoint): If handling "maint info breakpoints", also
2213         print locations of exception catchpoints.
2214         * breakpoint.h (is_exception_catchpoint): Declare.
2215
2216 2019-07-09  Pedro Alves  <palves@redhat.com>
2217
2218         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2219         "addr" field.
2220         (allocate_location_exception_catchpoint): New.
2221         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2222         (initialize_throw_catchpoint_ops): Install
2223         allocate_location_exception_catchpoint as allocate_location
2224         method.
2225         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2226         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2227         bp_loc_other.
2228         (breakpoint_address_is_meaningful): Delete.
2229         (bl_address_is_meaningful): New.
2230         (breakpoint_locations_match): Adjust comment.
2231         (bp_location_from_bp_type): New, factored out of...
2232         (bp_location::bp_location(breakpoint *)): ... this.
2233         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2234         factored out of...
2235         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2236         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2237         breakpoint_address_is_meaningful.
2238         (bp_locations_compare): Adjust comment.
2239         (update_global_location_list): Use bl_address_is_meaningful
2240         instead of breakpoint_address_is_meaningful.
2241         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2242         explicit.
2243         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2244         * python/py-breakpoint.c (bppy_get_location): No longer check
2245         whether location is null.
2246
2247 2019-07-09  Pedro Alves  <palves@redhat.com>
2248
2249         PR c++/15468
2250         * breakpoint.c (print_one_breakpoint_location): Remove
2251         single-location assert.
2252
2253 2019-07-09  Tom Tromey  <tom@tromey.com>
2254
2255         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2256         * configure: Rebuild.
2257         * configure.ac: Change common to gdbsupport.
2258         * gdbsupport: Rename from common.
2259         * acinclude.m4: Change common to gdbsupport.
2260         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2261         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2262         gdbsupport.
2263         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2264         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2265         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2266         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2267         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2268         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2269         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2270         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2271         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2272         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2273         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2274         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2275         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2276         coff-pe-read.c, command.h, compile/compile-c-support.c,
2277         compile/compile-c.h, compile/compile-cplus-symbols.c,
2278         compile/compile-cplus-types.c, compile/compile-cplus.h,
2279         compile/compile-loc2c.c, compile/compile.c, completer.c,
2280         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2281         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2282         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2283         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2284         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2285         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2286         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2287         features/aarch64-core.c, features/aarch64-fpu.c,
2288         features/aarch64-pauth.c, features/aarch64-sve.c,
2289         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2290         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2291         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2292         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2293         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2294         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2295         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2296         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2297         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2298         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2299         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2300         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2301         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2302         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2303         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2304         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2305         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2306         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2307         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2308         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2309         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2310         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2311         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2312         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2313         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2314         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2315         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2316         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2317         minsyms.c, mips-linux-tdep.c, namespace.h,
2318         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2319         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2320         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2321         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2322         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2323         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2324         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2325         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2326         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2327         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2328         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2329         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2330         procfs.c, producer.c, progspace.h, psymtab.h,
2331         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2332         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2333         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2334         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2335         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2336         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2337         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2338         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2339         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2340         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2341         target-memory.c, target.c, target.h, target/waitstatus.c,
2342         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2343         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2344         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2345         unittests/array-view-selftests.c,
2346         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2347         unittests/common-utils-selftests.c,
2348         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2349         unittests/format_pieces-selftests.c,
2350         unittests/function-view-selftests.c,
2351         unittests/lookup_name_info-selftests.c,
2352         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2353         unittests/mkdir-recursive-selftests.c,
2354         unittests/observable-selftests.c,
2355         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2356         unittests/parse-connection-spec-selftests.c,
2357         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2358         unittests/scoped_fd-selftests.c,
2359         unittests/scoped_mmap-selftests.c,
2360         unittests/scoped_restore-selftests.c,
2361         unittests/string_view-selftests.c, unittests/style-selftests.c,
2362         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2363         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2364         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2365         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2366         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2367         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2368
2369 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2372         bool value.
2373         (decode_digits_ordinary): Set explicit_line field in sal.
2374         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2375         symtab_and_line that was set on an explicit line number in
2376         assembler code.  Do always update the recorded symtab and line if
2377         we do skip the prologue.
2378
2379 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2380
2381         * breakpoint.c (set_breakpoint_location_function): Remove
2382         explicit_loc parameter.
2383         (momentary_breakpoint_from_master): Update call to
2384         set_breakpoint_location_function.
2385         (add_location_to_breakpoint): Likewise.
2386
2387 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2390         required features based on default bfd type when no specific bfd
2391         is present.
2392
2393 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2394
2395         * NEWS: Mention that GDB printf and eval commands can now print
2396         C-style and Ada-style convenience var strings without
2397         calling the inferior.
2398         * printcmd.c (printf_c_string): Locally print GDB internal var
2399         instead of transiting via the inferior.
2400         (printf_wide_c_string): Likewise.
2401
2402 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2403
2404         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2405
2406 2019-07-04  Tom Tromey  <tom@tromey.com>
2407
2408         PR tui/24724:
2409         * tui/tui-winsource.c (tui_clear_source_content): Update.
2410         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2411         (tui_update_breakpoint_info): Update.
2412         (tui_set_exec_info_content): Update.
2413         * tui/tui-source.c (tui_set_source_content_nil): Update.
2414         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2415         has_break.
2416         * tui/tui-data.h (enum tui_bp_flag): New.
2417         (tui_bp_flags): New enum flags type.
2418         (struct tui_source_element) <break_mode>: Change type.  Rename
2419         from has_break.
2420         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2421         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2422         constants.
2423         * tui/tui-winsource.h: Fix comment.
2424
2425 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2426
2427         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2428         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2429         (store_fpregs_to_thread)
2430         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2431         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2432         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2433         (IWMMXT_REGS_SIZE): Add define.
2434         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2435         (fetch_vfp_regs, store_vfp_regs)
2436         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2437         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2438
2439 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2440
2441         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2442         defines.
2443         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2444         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2445         (ARM_INT_REGISTER_SIZE): ...to this.
2446         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2447         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2448         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2449         (arm_linux_collect_gregset, supply_nwfpe_register)
2450         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2451         defines.
2452         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2453         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2454         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2455         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2456         (arm_return_in_memory, arm_store_return_value)
2457         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2458         (arm_record_ld_st_multiple): Likewise.
2459         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2460         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2461
2462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2463
2464         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2465         AARCH64_DISPLACED_MODIFIED_INSNS.
2466         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2467         (aarch64_displaced_step_copy_insn): Likewise.
2468         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2469         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2470         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2471         ARM_DISPLACED_MODIFIED_INSNS.
2472         * arm-tdep.c (arm_gdbarch_init): Likewise.
2473         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2474         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2475         (struct arm_displaced_step_closure): Use
2476         ARM_DISPLACED_MODIFIED_INSNS.
2477
2478 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2479
2480         * features/Makefile: Remove unused xml files.
2481         * features/aarch64.xml: Remove.
2482         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2483         * features/i386/amd64-avx-avx512.xml: Remove.
2484         * features/i386/amd64-avx-linux.xml: Remove.
2485         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2486         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2487         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2488         * features/i386/amd64-avx-mpx.xml: Remove.
2489         * features/i386/amd64-avx.xml: Remove.
2490         * features/i386/amd64-linux.xml: Remove.
2491         * features/i386/amd64-mpx-linux.xml: Remove.
2492         * features/i386/amd64-mpx.xml: Remove.
2493         * features/i386/amd64.xml: Remove.
2494         * features/i386/i386-avx-avx512-linux.xml: Remove.
2495         * features/i386/i386-avx-avx512.xml: Remove.
2496         * features/i386/i386-avx-linux.xml: Remove.
2497         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2498         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2499         * features/i386/i386-avx-mpx-linux.xml: Remove.
2500         * features/i386/i386-avx-mpx.xml: Remove.
2501         * features/i386/i386-avx.xml: Remove.
2502         * features/i386/i386-linux.xml: Remove.
2503         * features/i386/i386-mmx-linux.xml: Remove.
2504         * features/i386/i386-mmx.xml: Remove.
2505         * features/i386/i386-mpx-linux.xml: Remove.
2506         * features/i386/i386-mpx.xml: Remove.
2507         * features/i386/i386.xml: Remove.
2508         * features/i386/x32-avx-avx512-linux.xml: Remove.
2509         * features/i386/x32-avx-linux.xml: Remove.
2510         * features/i386/x32-linux.xml: Remove.
2511
2512 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2513
2514         * regformats/aarch64.dat: Remove.
2515         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2516         * regformats/i386/amd64-avx-linux.dat: Remove.
2517         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2518         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2519         * regformats/i386/amd64-linux.dat: Remove.
2520         * regformats/i386/amd64-mpx-linux.dat: Remove.
2521         * regformats/i386/amd64.dat: Remove.
2522         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2523         * regformats/i386/i386-avx-linux.dat: Remove.
2524         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2525         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2526         * regformats/i386/i386-linux.dat: Remove.
2527         * regformats/i386/i386-mmx-linux.dat: Remove.
2528         * regformats/i386/i386-mpx-linux.dat: Remove.
2529         * regformats/i386/i386.dat: Remove.
2530         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2531         * regformats/i386/x32-avx-linux.dat: Remove.
2532         * regformats/i386/x32-linux.dat: Remove.
2533
2534 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2535
2536         * aarch64-tdep.c: Remove xml self tests.
2537         * amd64-linux-tdep.c: Likewise.
2538         * amd64-tdep.c: Likewise.
2539         * i386-linux-tdep.c: Likewise.
2540         * i386-tdep.c: Likewise.
2541
2542 2019-07-03  Pedro Alves  <palves@redhat.com>
2543
2544         PR cli/24732
2545         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2546         (pipe_cmd_option_defs): New.
2547         (make_pipe_cmd_options_def_group): New.
2548         (pipe_command): Use gdb::option::process_options.
2549         (pipe_command_completer): New function.
2550         (_initialize_cli_cmds): Install completer for "pipe" command.
2551
2552 2019-07-03  Pedro Alves  <palves@redhat.com>
2553
2554         * cli/cli-option.c (union option_value) <string>: New field.
2555         (struct option_def_and_value): Add ctor, move ctor, dtor and
2556         use DISABLE_COPY_AND_ASSIGN.
2557         (option_def_and_value::clear_value): New.
2558         (parse_option, save_option_value_in_ctx, get_val_type_str)
2559         (add_setshow_cmds_for_options): Handle var_string.
2560         * cli-option.h (union option_def::var_address) <string>: New
2561         field.
2562         (struct string_option_def): New.
2563         * maint-test-options.c (struct test_options_opts): Add default
2564         ctor and use DISABLE_COPY_AND_ASSIGN.
2565         <string_opt>: New field.
2566         (test_options_opts::~test_options_opts): New.
2567         (test_options_opts::dump): Also dump "-string".
2568         (test_options_option_defs): Install "string.
2569
2570 2019-07-03  Pedro Alves  <palves@redhat.com>
2571
2572         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2573         option_value with a null enumeration.
2574         (complete_options): Save the option values in the context.
2575         (save_option_value_in_ctx): New, factored out from ...
2576         (process_options): ... here.
2577         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2578         of the function.
2579         * maint-test-options.c (test_options_opts::dump): New, factored
2580         out from ...
2581         (maintenance_test_options_command_mode): ... here.
2582         (maintenance_test_options_command_completion_result): Delete.
2583         (maintenance_test_options_command_completion_text): Update
2584         comment.
2585         (maintenance_show_test_options_completion_result): Change
2586         prototype.  Just print
2587         maintenance_test_options_command_completion_text.
2588         (save_completion_result): New.
2589         (maintenance_test_options_completer_mode): Pass options context to
2590         complete_options, and then save a dump.
2591         (_initialize_maint_test_options): Use add_cmd to install "maint
2592         show test-options-completion-result".
2593
2594 2019-07-03  Pedro Alves  <palves@redhat.com>
2595
2596         * NEWS (New commands): Mention "with" and "maint with".
2597         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2598         (with_command, with_command_completer): New.
2599         (pipe_command): Adjust to new repeat_previous
2600         interface.
2601         (_initialize_cli_cmds): Install the "with" command and its "w"
2602         alias.
2603         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2604         declarations.
2605         * cli/cli-setshow.c (parse_cli_var_uinteger)
2606         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2607         argument strings for all var_types.
2608         (get_setshow_command_value_string): New, factored out from ...
2609         (do_show_command): ... this.
2610         * cli/cli-setshow.h: Include <string>.
2611         (get_setshow_command_value_string): Declare.
2612         * command.h (repeat_previous): Now returns const char *.  Adjust
2613         comment.
2614         * maint.c: Include "cli/cli-cmds.h".
2615         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2616         (_initialize_maint_cmds): Register the "maintenance with" command.
2617         * top.c (repeat_previous): Move bits from pipe_command here:
2618         Return the saved command line, if any; error out if there's no
2619         command to relaunch.
2620
2621 2019-07-03  Pedro Alves  <palves@redhat.com>
2622
2623         * NEWS (New commands): Mention "maint set/show test-settings"
2624         instead of "maint test-settings".
2625         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2626         (maintenance_test_settings_set_list): Rename to ...
2627         (maintenance_set_test_settings_list): ... this.
2628         (maintenance_test_settings_show_list): Rename to  ...
2629         (maintenance_show_test_settings_list): ... this.
2630         (maintenance_test_settings_cmd): Delete.
2631         (maintenance_test_settings_set_cmd): ...
2632         (maintenance_set_test_settings_cmd): ... this.
2633         (maintenance_test_settings_show_cmd): ...
2634         (maintenance_show_test_settings_cmd): ... this.
2635         (maintenance_test_settings_show_value_cmd):
2636         (maintenance_show_test_settings_value_cmd): ... this.
2637         (_initialize_maint_test_settings): No longer install the "maint
2638         test-settings" prefix command.  Rename "maint test-settings set"
2639         to "maint set test-settings", and "maint test-settings show" to
2640         "maint show test-settings".  Adjust all subcommands.
2641
2642 2019-07-03  Pedro Alves  <palves@redhat.com>
2643
2644         * maint-test-settings.c: Fix file's intro comment.  Replace all
2645         references to "test-options" with references to "test-settings",
2646         in comments.
2647
2648 2019-07-03  Pedro Alves  <palves@redhat.com>
2649
2650         * maint-test-settings.c (maintenance_test_settings_xxx)
2651         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2652         New.
2653         (maintenance_test_settings_enums): Use them.
2654         (maintenance_test_settings_enum): Default to
2655         maintenance_test_settings_xxx.
2656         (_initialize_maint_test_settings): Initialize
2657         MAINTENANCE_TEST_SETTINGS_FILENAME.
2658
2659 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2660
2661         * breakpoint.h (remove_breakpoints_inf): Change return type to
2662         void, move function documentation here.
2663         * breakpoint.c (remove_breakpoints_inf): Change return type to
2664         void, move function documentation to header.
2665
2666 2019-07-02  Pedro Alves  <palves@redhat.com>
2667
2668         * NEWS (Completion improvements): Mention "info threads".
2669         * thread.c (struct info_threads_opts, info_threads_option_defs)
2670         (make_info_threads_options_def_group): New.
2671         (info_threads_command): Use gdb::option::process_options.
2672         (info_threads_command_completer): New.
2673         (_initialize_thread): Use gdb::option::build_help to build the
2674         help text for "info threads".
2675
2676 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2677
2678         * defs.h (generic_load): Move from here...
2679         * symfile.h (generic_load): ... to here.  Rename name parameter
2680         to args.
2681         * symfile.c (generic_load): Add comment.
2682
2683 2019-07-01  Tom Tromey  <tromey@adacore.com>
2684
2685         * dwarf2read.c
2686         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2687         declaration of without_params.  Fix formatting.
2688
2689 2019-07-01  Tom Tromey  <tromey@adacore.com>
2690
2691         * ada-exp.y (find_primitive_type): Update.
2692         * ada-lang.h (ada_lookup_symbol): Update.
2693         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2694         parameter.
2695         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2696
2697 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2698
2699         PR breakpoints/24541
2700         * gdbarch.c: Regenerate.
2701         * gdbarch.h: Regenerate.
2702         * gdbarch.sh: Add 'stap_adjust_register'.
2703         * i386-tdep.c: Include '<unordered_set>'.
2704         (i386_stap_adjust_register): New function.
2705         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2706         * stap-probe.c (stap_parse_register_operand): Call
2707         'gdbarch_stap_adjust_register'.
2708
2709 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2710
2711         PR python/24742
2712         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2713         * python/python.c (do_start_initialization): Use 'xmalloc'
2714         instead of 'PyMem_Malloc'.
2715
2716 2019-06-28  Tom Tromey  <tromey@adacore.com>
2717
2718         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2719         for Ada.
2720
2721 2019-06-27  Tom Tromey  <tromey@adacore.com>
2722
2723         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2724         objfile_key.
2725         (arm_find_mapping_symbol, arm_record_special_symbol)
2726         (_initialize_arm_tdep): Update.
2727         (arm_objfile_data_free): Remove.
2728
2729 2019-06-27  Tom Tromey  <tromey@adacore.com>
2730
2731         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2732         to cp_print_static_field.
2733
2734 2019-06-26  Tom Tromey  <tromey@adacore.com>
2735
2736         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2737         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2738         declare.
2739
2740 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2741
2742         * features/aarch64-core.c (create_feature_aarch64_core):
2743         Regenerate.
2744         * features/aarch64-core.xml: Add cpsr flags.
2745
2746 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2747
2748         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2749         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2750
2751 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2752
2753         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2754         field.
2755         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2756         use.
2757         (arm_record_special_symbol): Don't insert new symbol in sorted
2758         position, push it at the end.
2759
2760 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2761
2762         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2763         (arm_mapping_symbol_s): Remove.
2764         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2765         (arm_mapping_symbol_vec): New typedef.
2766         (struct arm_per_objfile): Add constructor.
2767         <section_maps>: Change type to
2768         std::unique_ptr<arm_mapping_symbol_vec[]>.
2769         (arm_compare_mapping_symbols): Remove.
2770         (arm_find_mapping_symbol): Adjust to section_maps type change.
2771         (arm_objfile_data_free): Call delete on arm_per_objfile.
2772         (arm_record_special_symbol): Adjust to section_maps type change.
2773         Allocate arm_per_objfile with new.
2774
2775 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2776
2777         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2778         with the command prefix.
2779
2780 2019-06-25  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2783         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2784
2785 2019-06-25  Tom Tromey  <tom@tromey.com>
2786
2787         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2788         type.
2789         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2790         protected.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-winsource.c
2795         (tui_source_window_base::set_is_exec_point_at): Add check against
2796         LOA_ADDRESS.
2797
2798 2019-06-25  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-source.c (tui_set_source_content): Don't check before
2801         xfree.
2802         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2803
2804 2019-06-25  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-winsource.h (tui_update_source_window_as_is)
2807         (tui_alloc_source_buffer, tui_line_is_displayed)
2808         (tui_addr_is_displayed): Change type of win_info.
2809         * tui/tui-winsource.c (tui_update_source_window_as_is)
2810         (tui_clear_source_content, tui_show_source_line)
2811         (tui_show_source_content, tui_source_window_base::refill)
2812         (tui_source_window_base::set_is_exec_point_at)
2813         (tui_source_window_base::set_is_exec_point_at)
2814         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2815         (tui_alloc_source_buffer, tui_line_is_displayed)
2816         (tui_addr_is_displayed): Change type of win_info.  Update.
2817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2818         (tui_source_window_base::do_make_visible_with_new_height):
2819         Update.
2820         * tui/tui-source.c (tui_set_source_content)
2821         (tui_set_source_content_nil)
2822         (tui_source_window::do_scroll_vertical): Update.
2823         * tui/tui-layout.c (show_layout): Update.
2824         * tui/tui-disasm.c (tui_set_disassem_content)
2825         (tui_disasm_window::do_scroll_vertical): Update.
2826         * tui/tui-data.h (tui_win_content): Remove.
2827         (struct tui_gen_win_info) <content, content_size>: Remove.
2828         (struct tui_source_element): Add initializers and destructor.
2829         (union tui_which_element, struct tui_win_element): Remove.
2830         (struct tui_source_window_base) <content>: New field.
2831         (struct tui_data_window): Remove destructor.
2832         (tui_alloc_content, tui_free_win_content)
2833         (tui_free_all_source_wins_content): Don't declare.
2834         * tui/tui-data.c (tui_initialize_static_data): Update.
2835         (init_content_element, tui_alloc_content): Remove.
2836         (~tui_gen_win_info): Update.
2837         (~tui_data_window, tui_free_all_source_wins_content)
2838         (tui_free_win_content, free_content, free_content_elements):
2839         Remove.
2840
2841 2019-06-25  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-winsource.h (tui_clear_source_content)
2844         (tui_erase_source_content, tui_show_source_content): Change type
2845         of win_info.
2846         * tui/tui-winsource.c (tui_clear_source_content)
2847         (tui_erase_source_content, tui_show_source_content): Change type
2848         of win_info.
2849         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2850         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2851         win_info.
2852         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2853         win_info.
2854         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2855
2856 2019-06-25  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui-winsource.c (tui_clear_source_content)
2859         (tui_source_window_base::set_is_exec_point_at): Update.
2860         * tui/tui-source.c (tui_set_source_content_nil): Update.
2861         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2862         a bool.
2863         * tui/tui-data.c (init_content_element): Update.
2864
2865 2019-06-25  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2868         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2869         * tui/tui-layout.c (init_and_make_win): Update.
2870         * tui/tui.h (enum tui_win_type): Update.
2871         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2872         tui_win_is_auxillary.
2873         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2874         tui_win_is_auxillary.
2875
2876 2019-06-25  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2879         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2880         (tui_delete_data_content_windows, tui_display_all_data)
2881         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2882         Update.
2883         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2884         * tui/tui-regs.c (tui_last_regs_line_no)
2885         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2886         (tui_show_registers): Update.
2887         (tui_show_register_group): Return void.  Update.
2888         (tui_display_registers_from, tui_display_reg_element_at_line)
2889         (tui_display_registers_from_line, tui_check_register_values):
2890         Update.
2891         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2892         member.
2893         (struct tui_data_window) <regs_content>: Now a std::vector.
2894         <regs_content_count>: Remove.
2895         (tui_add_content_elements, tui_free_data_content): Don't declare.
2896         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2897         (init_content_element): Remove DATA_WIN case.  Add assert.
2898         (tui_add_content_elements): Remove.
2899         (tui_data_window): Update.
2900         (tui_free_data_content): Remove.
2901         (free_content_elements): Remove DATA_WIN case.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-data.c (tui_data_item_window): Update.
2906         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2907         * tui/tui-windata.c (tui_display_all_data)
2908         (tui_display_data_from_line): Update.
2909         (tui_check_data_values): Remove.
2910         * tui/tui-regs.c (tui_show_register_group)
2911         (tui_display_reg_element_at_line): Update.
2912         * tui/tui-hooks.c (tui_register_changed)
2913         (tui_refresh_frame_and_register_information): Call
2914         tui_check_register_values.
2915         * tui/tui-data.h (struct tui_data_window) <data_content,
2916         data_content_count, data_type>: Remove.
2917         (enum tui_data_type): Remove.
2918
2919         * tui/tui-data.c (tui_data_window::clear_detail)
2920         (~tui_data_window): Update.
2921
2922 2019-06-25  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2925         declare.
2926         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2927         Rename from tui_first_data_item_displayed.  Update.
2928         (tui_data_window::refresh_all)
2929         (tui_data_window::do_scroll_vertical): Update.
2930         * tui/tui-data.h (struct tui_data_window)
2931         <first_data_item_displayed>: Declare new method.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2936         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2937         contents...
2938         (tui_initialize_static_data): ...here.
2939
2940 2019-06-25  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2943         (tui_display_registers_from, tui_check_register_values): Update.
2944         (tui_display_register): Remove win_info parameter; update.
2945         (tui_get_register): Change type of parameters.
2946         * tui/tui-data.h (struct tui_data_element): Remove.
2947         (union tui_which_element) <data>: Remove.
2948         <data_window>: Change type.
2949         (struct tui_data_item_window): New.
2950         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2951         case.  Add assert.
2952         (~tui_data_item_window): New destructor.
2953         (free_content_elements): Remove DATA_ITEM_WIN case.
2954
2955 2019-06-25  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2958         Remove.
2959
2960 2019-06-25  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-data.h (struct tui_command_element): Remove.
2963         (union tui_which_element) <command>: Remove.
2964         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2965         assert.
2966         (free_content_elements): Remove CMD_WIN case.
2967
2968 2019-06-25  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-layout.c (tui_set_layout): Update.
2971         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2972         * tui/tui-data.c (layout_def): Update.
2973
2974 2019-06-25  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2978         (tui_source_window_base::set_new_height): Update.
2979         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2980         Update.
2981         (tui_set_locator_fullname, tui_set_locator_info)
2982         (tui_show_frame_info): Update.
2983         * tui/tui-source.c (tui_set_source_content)
2984         (tui_source_is_displayed): Update.
2985         * tui/tui-layout.c (show_source_disasm_command, show_data)
2986         (show_source_or_disasm_and_command): Update.
2987         * tui/tui-disasm.c (tui_set_disassem_content)
2988         (tui_get_begin_asm_address): Update.
2989         * tui/tui-data.h (struct tui_locator_element): Remove.
2990         (union tui_which_element) <locator>: Remove.
2991         (struct tui_locator_window): New.
2992         (tui_locator_win_info_ptr): Change return type.
2993         * tui/tui-data.c (_locator): Change type.
2994         (tui_locator_win_info_ptr): Change return type.
2995         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2996         (tui_alloc_content): Add assert.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-winsource.c
3001         (tui_exec_info_window::maybe_allocate_content): New method.
3002         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3003         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3004         (make_source_or_disasm_window): Add cast.
3005         * tui/tui-data.h (union tui_which_element) <simple_string>:
3006         Remove.
3007         (struct tui_source_info): New.
3008         (struct tui_source_window_base) <execution_info>: Change type.
3009         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3010         case, and add assert.
3011         (tui_alloc_content): Add assert.
3012
3013 2019-06-25  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3016         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3017         * tui/tui-data.c (tui_alloc_win_info): Remove.
3018
3019 2019-06-25  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3022         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3023         can_highlight.
3024
3025 2019-06-25  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3028         make_visible_with_new_height method.
3029         (tui_win_info::make_visible_with_new_height): New method.
3030         (tui_source_window_base::do_make_visible_with_new_height)
3031         (tui_data_window::do_make_visible_with_new_height)
3032         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3033         (make_visible_with_new_height): Remove.
3034         (tui_resize_all, tui_adjust_win_heights): Use
3035         make_visible_with_new_height method.
3036         * tui/tui-data.h (struct tui_win_info)
3037         <do_make_visible_with_new_height, make_visible_with_new_height>:
3038         New methods.
3039         (struct tui_source_window_base, struct tui_data_window)
3040         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3041         methods.
3042
3043 2019-06-25  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3046         method.
3047         (update_tab_width): Call update_tab_width method.
3048         * tui/tui-data.h (struct tui_win_info)
3049         (struct tui_source_window_base) <update_tab_width>: New methods.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3054         parameter.
3055         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3056         parameter.
3057         (tui_gen_win_info::make_visible): Update.
3058         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3059         parameter.
3060         * tui/tui-data.h (enum tui_box): New enum.
3061         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3062
3063 2019-06-25  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3066         init_and_make_win for EXEC_INFO_WIN.
3067         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3068         longer inline.
3069         (struct tui_win_info) <~tui_win_info>: Inline.
3070         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3071         Don't declare.
3072         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3073         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3074         Remove.
3075         (tui_initialize_static_data): Update.
3076         (~tui_gen_win_info): Handle more cleanup here.
3077         (~tui_source_window_base): Delete "execution_info".
3078         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3079
3080 2019-06-25  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-layout.c (make_command_window): Don't set
3083         can_highlight.
3084         (show_source_disasm_command): Call the reset method.
3085         (show_data): Don't set can_highlight.  Call the reset method.
3086         (tui_gen_win_info::reset): Rename from init_gen_win_info
3087         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3088         (show_source_or_disasm_and_command): Call the reset method.
3089         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3090         (struct tui_cmd_window): Set can_highlight.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3095         from make_visible.
3096         (tui_make_visible, tui_make_invisible): Rewrite.
3097         (tui_win_info::make_visible): Remove.
3098         (tui_source_window_base::make_visible): Update.
3099         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3100         method.  Moved from...
3101         (struct tui_win_info) <make_visible>: ...here.
3102
3103 2019-06-25  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-winsource.c
3106         (tui_source_window_base::do_scroll_horizontal): Remove direction
3107         parameter.
3108         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3109         direction parameter.
3110         * tui/tui-win.c (tui_win_info::forward_scroll)
3111         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3112         (tui_win_info::right_scroll): Update.
3113         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3114         direction parameter.
3115         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3116         direction parameter.
3117         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3118         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3119         Remove direction parameter.
3120         (struct tui_source_window_base, struct tui_source_window)
3121         (struct tui_disasm_window, struct tui_data_window)
3122         (struct tui_cmd_window): Update.
3123
3124 2019-06-25  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-winsource.h (tui_set_exec_info_content)
3127         (tui_show_exec_info_content, tui_erase_exec_info_content)
3128         (tui_clear_exec_info_content, tui_update_exec_info): Change
3129         argument to tui_source_window_base.
3130         * tui/tui-winsource.c (tui_set_exec_info_content)
3131         (tui_show_exec_info_content, tui_erase_exec_info_content)
3132         (tui_clear_exec_info_content, tui_update_exec_info): Change
3133         argument to tui_source_window_base.
3134
3135 2019-06-25  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3138         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3143         check.
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3148         type to void.
3149         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3150         type to void.
3151         * tui/tui-source.c (tui_set_source_content): Update.
3152         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3153
3154 2019-06-25  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-win.c (window_name_completer, tui_set_focus)
3157         (tui_all_windows_info): Use name method.
3158         * tui/tui-data.h (struct tui_gen_win_info)
3159         (struct tui_source_window, struct tui_disasm_window)
3160         (struct tui_data_window, struct tui_cmd_window) <name>: New
3161         method.
3162         (tui_win_name): Don't declare.
3163         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3164         (tui_win_name): Remove.
3165
3166 2019-06-25  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-winsource.h (tui_update_source_window)
3169         (tui_update_source_window_as_is): Change parameter type.
3170         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3171         to be a tui_source_window_base.
3172         (tui_update_source_window_as_is): Likewise.
3173         * tui/tui-win.c (make_visible_with_new_height): Update.
3174
3175 2019-06-25  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui-winsource.c (tui_erase_source_content)
3178         (tui_show_source_content, tui_show_exec_info_content)
3179         (tui_erase_exec_info_content): Use refresh_window method.
3180         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3181         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3182         from tui_refresh_win.
3183         (tui_data_window::refresh_window): New method.
3184         (tui_win_info::refresh, tui_source_window_base::refresh)
3185         (tui_refresh_all): Use refresh_window method.
3186         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3187         method.
3188         * tui/tui-regs.c (tui_display_register): Call refresh_window
3189         method.
3190         * tui/tui-layout.c (show_source_disasm_command)
3191         (show_source_or_disasm_and_command): Call refresh_window method.
3192         * tui/tui-data.h (struct tui_gen_win_info)
3193         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3194         New method.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui.c (tui_rl_other_window, tui_enable)
3199         (tui_is_window_visible, tui_get_command_dimension): Update.
3200         * tui/tui-winsource.c (tui_update_source_window_as_is)
3201         (tui_clear_source_content, tui_erase_source_content)
3202         (tui_show_source_line, tui_source_window_base::refill)
3203         (tui_source_window_base::do_scroll_horizontal)
3204         (tui_source_window_base::set_is_exec_point_at)
3205         (tui_update_breakpoint_info, tui_set_exec_info_content)
3206         (tui_alloc_source_buffer, tui_line_is_displayed)
3207         (tui_addr_is_displayed): Update.
3208         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3209         (tui_check_and_display_highlight_if_needed)
3210         (tui_win_info::make_visible, tui_win_info::refresh)
3211         (tui_refresh_all): Update.
3212         * tui/tui-windata.c (tui_first_data_item_displayed)
3213         (tui_delete_data_content_windows, tui_erase_data_content)
3214         (tui_display_all_data, tui_data_window::refresh_all)
3215         (tui_check_data_values): Update.
3216         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3217         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3218         (tui_win_info::backward_scroll, tui_refresh_all_win)
3219         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3220         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3221         (tui_source_window_base::set_new_height)
3222         (tui_data_window::set_new_height)
3223         (make_invisible_and_set_new_height)
3224         (make_visible_with_new_height, new_height_ok)
3225         (parse_scrolling_args): Update.
3226         * tui/tui-stack.c (tui_show_frame_info): Update.
3227         * tui/tui-source.c (tui_set_source_content)
3228         (tui_set_source_content_nil, tui_source_is_displayed)
3229         (tui_source_window::do_scroll_vertical): Update.
3230         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3231         (tui_display_registers_from, tui_display_reg_element_at_line)
3232         (tui_check_register_values, tui_reg_command): Update.
3233         * tui/tui-layout.c (tui_default_win_height)
3234         (show_source_disasm_command, show_data, init_and_make_win)
3235         (show_source_or_disasm_and_command): Update.
3236         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3237         (tui_redisplay_readline, tui_mld_flush)
3238         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3239         (tui_getc): Update.
3240         * tui/tui-disasm.c (tui_set_disassem_content)
3241         (tui_disasm_window::do_scroll_vertical): Update.
3242         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3243         Now virtual.
3244         (struct tui_win_info): Derive from tui_gen_win_info.
3245         <~tui_win_info>: Mark as override.
3246         <generic>: Remove member.
3247         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3248         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3249         (~tui_data_window, ~tui_win_info)
3250         (tui_free_all_source_wins_content): Update.
3251         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3252
3253 2019-06-25  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-layout.c (init_and_make_win): Use new.
3256         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3257         destructor, initializers.
3258         (tui_alloc_generic_win_info): Don't declare.
3259         * tui/tui-data.c (_locator): Add argument to constructor.
3260         (source_win, disasm_win): New globals.
3261         (exec_info): Remove.
3262         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3263         Update.
3264         (tui_alloc_generic_win_info): Remove.
3265         (init_content_element): Use new.
3266         (tui_win_info::tui_win_info): Update.
3267         (free_content_elements) <case DATA_WIN>: Use delete.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3272         * tui/tui-windata.c (tui_first_data_item_displayed)
3273         (tui_delete_data_content_windows): Update.
3274         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3275         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3276         (tui_display_registers_from, tui_check_register_values): Update.
3277         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3278         pointer.
3279         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3280         window.
3281         (tui_free_data_content): Update.
3282         (free_content_elements) <case DATA_WIN>: Free the window.
3283
3284 2019-06-25  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3287         Update.
3288         * tui/tui-layout.c (make_command_window)
3289         (show_source_disasm_command, show_data, init_and_make_win)
3290         (show_source_or_disasm_and_command): Update.
3291         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3292         method.
3293         <can_highight, is_highlighted>: Now bool.
3294         (tui_set_win_highlight): Don't declare.
3295         * tui/tui-data.c (tui_set_win_highlight): Remove.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-wingeneral.c (make_visible): Remove check of window
3300         type.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-win.c (tui_win_info::max_height)
3305         (tui_cmd_window::max_height): New methods.
3306         (new_height_ok): Call max_height.
3307         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3308         <max_height>: New method.
3309
3310 2019-06-25  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-win.c (tui_source_window_base::set_new_height)
3313         (tui_data_window::set_new_height): New methods.
3314         (make_invisible_and_set_new_height): Call set_new_height method.
3315         * tui/tui-data.h (struct tui_win_info)
3316         (struct tui_source_window_base, struct tui_data_window)
3317         <set_new_height>: New method.
3318
3319 2019-06-25  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3322         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3323         tui_refresh_data_win.
3324         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3325         method.
3326         (tui_refresh_all_win): Call the refresh_all method.
3327         (tui_set_focus): Likewise.
3328         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3329         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3330         Likewise.
3331
3332 2019-06-25  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-winsource.h (tui_refill_source_window)
3335         (tui_set_is_exec_point_at): Don't declare.
3336         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3337         (tui_source_window_base::refill): Rename from
3338         tui_refill_source_window.
3339         (tui_source_window_base::do_scroll_horizontal): Update.
3340         (tui_source_window_base::set_is_exec_point_at): Rename from
3341         tui_set_is_exec_point_at.
3342         (tui_update_all_breakpoint_info): Update.
3343         * tui/tui-stack.c (tui_show_frame_info): Update.
3344         * tui/tui-layout.c (show_data): Add cast.
3345         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3346         * tui/tui-data.h (struct tui_source_window_base) <refill,
3347         set_is_exec_point_at>: New methods.
3348         (tui_source_windows, tui_add_to_source_windows): Update types.
3349         (tui_add_to_source_windows): Remove redundant declaration.
3350         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3351         (tui_source_windows): Change return type.
3352         (tui_clear_source_windows_detail): Update.
3353         (tui_add_to_source_windows): Change type of parameter.
3354         (tui_free_all_source_wins_content): Update.
3355
3356 2019-06-25  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-wingeneral.c (tui_win_info::refresh)
3359         (tui_source_window_base::refresh): New methods.
3360         (tui_refresh_all): Call the refresh method.
3361         * tui/tui-data.h (struct tui_win_info)
3362         (struct tui_source_window_base) <refresh>: New method.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui.h (tui_is_window_visible): Return bool.
3367         * tui/tui.c (tui_is_window_visible): Return bool.
3368         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3369         (tui_make_visible, tui_make_invisible)
3370         (tui_win_info::make_visible)
3371         (tui_source_window_base::make_visible, make_all_visible)
3372         (tui_make_all_visible, tui_make_all_invisible): Update.
3373         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3374         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3375         bool.
3376         (struct tui_win_info, struct tui_source_window_base)
3377         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3378         * tui/tui-data.c (tui_init_generic_part): Update.
3379
3380 2019-06-25  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3383         (tui_source_window_base::make_visible): New methods.
3384         (make_all_visible): Make method call.
3385         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3386         (struct tui_source_window_base, struct tui_cmd_window): Override
3387         make_visible.
3388         (tui_win_is_source_type): Don't declare.
3389         * tui/tui-data.c (tui_win_is_source_type): Remove.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3394         NULL check.
3395
3396 2019-06-25  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3399         Inline constructor.  Add initializers for members.
3400         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3401         constructors; now inline in class.
3402
3403 2019-06-25  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-regs.c (tui_show_registers): Update.
3406         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3407         bool.
3408         * tui/tui-data.c (tui_data_window::clear_detail)
3409         (tui_data_window): Update.
3410
3411 2019-06-25  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-windata.c (tui_display_all_data)
3414         (tui_display_data_from_line, tui_display_data_from)
3415         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3416         Update.
3417         * tui/tui-regs.c (tui_last_regs_line_no)
3418         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3419         (tui_show_registers, tui_show_register_group)
3420         (tui_display_registers_from, tui_display_reg_element_at_line)
3421         (tui_display_registers_from_line, tui_check_register_values)
3422         (tui_reg_next, tui_reg_prev): Update.
3423         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3424         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3425         tui_data_window.
3426         (struct tui_win_info) <detail>: Remove.  Add new fields from
3427         tui_data_info.
3428         (TUI_DATA_WIN): Add cast.
3429         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3430         (~tui_data_window): Simplify.
3431
3432 2019-06-25  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-layout.c (show_source_disasm_command)
3435         (show_source_or_disasm_and_command): Update.
3436         * tui/tui-io.c (update_cmdwin_start_line)
3437         (tui_redisplay_readline): Update.
3438         * tui/tui-data.h (struct tui_command_info): Remove.
3439         (struct tui_win_info) <detail>: Remove command_info member.
3440         (struct tui_data_window) <start_line>: New member, from
3441         tui_command_info.
3442         (TUI_CMD_WIN): Add casts.
3443
3444 2019-06-25  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-winsource.c (tui_update_source_window)
3447         (tui_refill_source_window)
3448         (tui_source_window_base::do_scroll_horizontal)
3449         (tui_update_breakpoint_info, tui_set_exec_info_content)
3450         (tui_show_exec_info_content, tui_erase_exec_info_content)
3451         (tui_clear_exec_info_content): Update.
3452         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3453         Update.
3454         * tui/tui-win.c (make_invisible_and_set_new_height)
3455         (make_visible_with_new_height): Update.
3456         * tui/tui-source.c (tui_set_source_content)
3457         (tui_show_symtab_source): Update.
3458         * tui/tui-layout.c (extract_display_start_addr)
3459         (show_source_disasm_command, show_data)
3460         (make_source_or_disasm_window)
3461         (show_source_or_disasm_and_command): Update.
3462         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3463         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3464         "gdbarch".
3465         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3466         to tui_source_window_base.
3467         (struct tui_win_info) <detail>: Remove source_info member.
3468         (struct tui_source_window_base) <has_locator>: Inline.
3469         Move contents from tui_source_info; rename has_locator member to
3470         m_has_locator.
3471         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3472         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3473         header file.
3474         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3475         Simplify.
3476         (tui_free_all_source_wins_content): Cast to
3477         tui_source_window_base.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-win.c (make_invisible_and_set_new_height)
3482         (make_visible_with_new_height): Call has_locator method.
3483         * tui/tui-layout.c (show_source_disasm_command, show_data)
3484         (show_source_or_disasm_and_command): Update for bool change.
3485         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3486         (tui_win_info) <has_locator>: New method.
3487         (struct tui_source_window_base) <has_locator>: New method.
3488         (tui_win_has_locator): Don't declare.
3489         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3490         from tui_win_has_locator.
3491         (tui_source_window_base): Use false, not FALSE.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3496         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3497         clear_detail method directly.
3498         (tui_clear_win_detail): Remove.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3503         "this", not TUI_DISASM_WIN.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3508         declare.
3509         * tui/tui-winsource.c
3510         (tui_source_window_base::do_scroll_horizontal): Rename from
3511         tui_horizontal_source_scroll.
3512         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3513         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3514         from tui_vertical_data_scroll.
3515         * tui/tui-win.h (tui_scroll): Don't declare.
3516         * tui/tui-win.c (tui_win_info::forward_scroll)
3517         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3518         (tui_win_info::right_scroll): Rename and update.
3519         (tui_scroll_forward_command, tui_scroll_backward_command)
3520         (tui_scroll_left_command, tui_scroll_right_command): Update.
3521         (tui_scroll): Remove.
3522         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3523         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3524         from tui_vertical_source_scroll.
3525         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3526         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3527         from tui_vertical_disassem_scroll.
3528         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3529         do_scroll_horizontal>: New methods.
3530         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3531         Likewise.
3532         (struct tui_source_window_base): Add do_scroll_horizontal.
3533         (struct tui_source_window, struct tui_disasm_window): Add
3534         do_scroll_vertical.
3535         (struct tui_data_window, struct tui_cmd_window): Add
3536         do_scroll_horizontal and do_scroll_vertical.
3537         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-data.h (struct tui_source_window_base): New struct.
3542         (struct tui_source_window): Derive from tui_source_window_base.
3543         (struct tui_disasm_window): New struct.
3544         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3545         from tui_source_window::clear_detail.
3546         (tui_source_window_base): Rename from tui_source_window.
3547         (~tui_source_window_base): Rename from ~tui_source_window.
3548         (tui_alloc_win_info): Create a tui_disasm_window.
3549
3550 2019-06-25  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui-data.h (struct tui_source_window)
3553         (struct tui_data_window): Declare destructors.
3554         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3555         destructors.
3556         (tui_win_info): Simplify.
3557
3558 2019-06-25  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-winsource.c (tui_display_main)
3561         (tui_update_source_windows_with_addr)
3562         (tui_update_all_breakpoint_info): Update.
3563         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3564         (new_height_ok, parse_scrolling_args): Update.
3565         * tui/tui-stack.c (tui_show_frame_info): Update.
3566         * tui/tui-data.h (struct tui_list): Remove.
3567         (tui_source_windows): Return a reference to a std::vector.
3568         * tui/tui-data.c (source_windows): Now a std::vector.
3569         (tui_source_windows): Change return type.
3570         (tui_clear_source_windows): Rewrite.
3571         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3572         (tui_free_all_source_wins_content): Rewrite.
3573
3574 2019-06-25  Tom Tromey  <tom@tromey.com>
3575
3576         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3577         (struct tui_data_window, struct tui_cmd_window): Declare
3578         clear_detail method.
3579         * tui/tui-data.c (tui_source_window::clear_detail)
3580         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3581         methods.
3582         (tui_clear_win_detail): Simplify.
3583
3584 2019-06-25  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-layout.c (make_source_window, make_disasm_window)
3587         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3588         Return the new window.
3589         (show_source_disasm_command, show_data)
3590         (show_source_or_disasm_and_command): Update.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3595         parameter.  Return the new window.
3596         (show_source_disasm_command): Update and remove NULL check.
3597         (show_source_or_disasm_and_command): Update.
3598
3599 2019-06-25  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3602
3603 2019-06-25  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-data.h (struct tui_win_info): Make constructor
3606         protected.  Make destructor virtual.  Add initializers.
3607         (tui_source_window, tui_data_window, tui_cmd_window): New
3608         classes.
3609         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3610         constructor.  Add "type" parameter.
3611         (tui_source_window, tui_data_window, tui_cmd_window): New
3612         constructors.
3613         (tui_alloc_win_info): Instantiate the appropriate subclass.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-win.c (tui_resize_all): Use delete.
3618         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3619         destructor.
3620         (tui_free_window): Don't declare.
3621         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3622         Update.
3623
3624 2019-06-25  Tom Tromey  <tom@tromey.com>
3625
3626         * tui/tui-data.h (struct tui_win_info): Add constructor.
3627         * tui/tui-data.c (tui_alloc_win_info): Use new.
3628         (tui_free_window): Use delete.
3629
3630 2019-06-22  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3633         declare.
3634         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3635
3636 2019-06-22  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3639         declare.
3640         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3641
3642 2019-06-22  Tom de Vries  <tdevries@suse.de>
3643
3644         * dwarf2read.c (create_addrmap_from_aranges)
3645         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3646         instead of '%zu'.
3647
3648 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3649
3650         * dwarf2read.h (dwarf2_section_info_def): Remove.
3651         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3652         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3653         std::vector<dwarf2_section_info>.
3654         (struct dwo_file) <~dwo_file>: Remove.
3655         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3656         types field.
3657         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3658         (dwarf2_read_debug_names): Likewise.
3659         (create_debug_types_hash_table): Change parameter type to
3660         array_view, adjust code accordingly.
3661         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3662         (partial_die_info::fixup): Likewise.
3663         (determine_prefix): Likewise.
3664         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3665
3666 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3667
3668         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3669         gdb_bfd_ref_ptr.
3670         <~dwo_file>: Remove call to gdb_bfd_unref.
3671         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3672         gdb_bfd_ref_ptr::get.
3673
3674 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3675
3676         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3677         type to htab_up.
3678         * dwarf2read.c (struct dwo_file): Initialize fields.
3679         <~dwo_file>: New.
3680         (free_dwo_file): Remove, move content to ~dwo_file.
3681         (struct dwo_file_deleter): Remove.
3682         (dwo_file_up>: Remove custom deleter.
3683         (free_dwo_files): Remove.
3684         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3685         dwo_files.
3686         (process_skeletonless_type_units): Call unique_ptr::get.
3687         (allocate_dwo_file_hash_table): Add deleter to created hash
3688         table.  Change return type to htab_up.
3689         (lookup_dwo_file_slot): Don't memset dwo_file, call
3690         unique_ptr::get.
3691         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3692         (create_dwo_unit_in_dwp_v2): Likewise.
3693         (open_and_init_dwo_file): Likewise.
3694         (free_dwo_file_from_slot): Remove.
3695
3696 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3697
3698         * dwarf2read.h (struct dwarf2_section_info) <readin,
3699         is_virtual>: Change type to bool.
3700         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3701         true instead of 1.
3702
3703 2019-06-19  Tom Tromey  <tom@tromey.com>
3704
3705         * tui/tui-data.h (tui_init_content_element): Don't declare.
3706
3707 2019-06-19  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-data.h (tui_init_win_info): Don't declare.
3710
3711 2019-06-19  Tom de Vries  <tdevries@suse.de>
3712
3713         * dwarf2read.h (abstract_to_concrete): Change type to
3714         std::unordered_map<sect_offset, std::vector<sect_offset>,
3715         gdb::hash_enum<sect_offset>>.
3716
3717 2019-06-19  Tom Tromey  <tromey@adacore.com>
3718
3719         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3720         EVAL_AVOID_SIDE_EFFECTS specially.
3721
3722 2019-06-19  Tom Tromey  <tromey@adacore.com>
3723
3724         * source-cache.c (highlighter): New global.
3725         (source_cache::get_source_lines): Create a highlighter on demand.
3726
3727 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3728
3729         * defs.h (deprecated_interactive_hook): Delete declaration.
3730         * interps.c (clear_interpreter_hooks): Remove use of
3731         deprecated_interactive_hook.
3732         * top.c (deprecated_interactive_hook): Delete definition.
3733         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3734
3735 2019-06-18  Tom de Vries  <tdevries@suse.de>
3736
3737         PR gdb/24515
3738         * dwarf2read.h (abstract_to_concrete): Change type from
3739         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3740         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3741         * dwarf2read.c (read_variable): Update.
3742         (dwarf2_fetch_die_loc_sect_off): Update.
3743
3744 2019-06-17  Tom de Vries  <tdevries@suse.de>
3745
3746         PR gdb/24617
3747         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3748         accessing parent[parent_len - 1].
3749
3750 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3751
3752         PR gdb/24364
3753         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3754         call dtrace_process_dof with NULL dof.
3755
3756 2019-06-16  Tom de Vries  <tdevries@suse.de>
3757
3758         PR gdb/24445
3759         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3760
3761 2019-06-16  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3764         (make_all_visible): Use address of member.
3765
3766 2019-06-16  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3769         (tui_free_window, free_content, free_content_elements): Remove
3770         unnecessary cast.
3771         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3772         cast.
3773         * tui/tui-regs.c (tui_show_register_group)
3774         (tui_display_registers_from, tui_display_reg_element_at_line):
3775         Remove unnecessary cast.
3776
3777 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * linux-nat.c (normal_mask): Delete.
3780         (_initialize_linux_nat): Don't initialise normal_mask.
3781
3782 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3783
3784         PR gdb/24445
3785         * dwarf-index-write.h (write_psymtabs_to_index): Add
3786         dwz_basename parameter.
3787         * dwarf-index-write.c (write_gdbindex): Move file writing to
3788         write_gdbindex_1.  Change return type void.
3789         (assert_file_size): Move up, remove filename parameter.
3790         (write_gdbindex_1): New function.
3791         (write_debug_names): Change return type to void, call
3792         assert_file_size.
3793         (struct index_wip_file): New struct.
3794         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3795         file logic to index_wip_file.  Write index for dwz file if
3796         needed.
3797         (save_gdb_index_command): Pass basename of dwz file, if present.
3798         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3799         build-id of dwz file, if present.
3800         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3801         (dwarf2_get_dwz_file): Likewise.
3802         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3803         (dwarf2_get_dwz_file): Likewise.
3804
3805 2019-06-16  Tom Tromey  <tom@tromey.com>
3806
3807         * coffread.c (process_coff_symbol): Use xstrdup.
3808         * value.c (create_internalvar): Use xstrdup.
3809
3810 2019-06-16  Tom Tromey  <tom@tromey.com>
3811
3812         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3813         * breakpoint.c (stopin_command, stopat_command)
3814         (until_break_command, decode_location_default): Remove unnecessary
3815         cast.
3816         * utils.c (subset_compare): Remove unnecessary cast.
3817         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3818         cast.
3819         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3820         cast.
3821         * infcmd.c (path_command): Remove unnecessary cast.
3822         * coffread.c (decode_type): Remove unnecessary cast.
3823         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3824         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3825         * tui/tui-stack.c (tui_show_locator_content)
3826         (tui_show_frame_info): Remove unnecessary cast.
3827         * tui/tui-win.c (tui_scroll_forward_command)
3828         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3829         (parse_scrolling_args): Remove unnecessary cast.
3830         * tui/tui-data.c (init_win_info, tui_del_window)
3831         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3832         (free_content_elements): Remove unnecessary cast.
3833         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3834         unnecessary cast.
3835         * tui/tui-source.c (tui_set_source_content)
3836         (tui_vertical_source_scroll): Remove unnecessary cast.
3837         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3838         cast.
3839         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3840         * tui/tui-regs.c (tui_display_registers_from)
3841         (tui_display_register): Remove unnecessary cast.
3842         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3843         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3844         (make_visible): Remove unnecessary cast.
3845         * tui/tui-winsource.c (tui_erase_source_content)
3846         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3847         unnecessary cast.
3848         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3849         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3850         * stabsread.c (read_type, read_array_type, read_range_type):
3851         Remove unnecessary cast.
3852         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3853         (parse_symbol, parse_type, upgrade_type, parse_external)
3854         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3855         unnecessary cast.
3856         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3857
3858 2019-06-16  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-data.c (tui_alloc_generic_win_info)
3861         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3862         checks.
3863
3864 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3865             Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * f-typeprint.c (f_print_type): Don't return early for not
3868         associated or not allocated types.
3869         (f_type_print_varspec_suffix): Add print_rank parameter and print
3870         ranks of array types in case they dangling.
3871         (f_type_print_base): Add print_rank parameter.
3872
3873 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * NEWS: Mention new MI commands.
3876         * break-catch-throw.c (enum exception_event_kind): Move to
3877         breakpoint.h.
3878         (print_mention_exception_catchpoint): Output text as a single
3879         message.
3880         (catch_exception_command_1): Rename to...
3881         (catch_exception_event): ...this, make non-static, update header
3882         command, and change some parameter types.
3883         (catch_catch_command): Update for changes to
3884         catch_exception_command_1.
3885         (catch_throw_command): Likewise.
3886         (catch_rethrow_command): Likewise.
3887         * breakpoint.c (enum exception_event_kind): Delete.
3888         * breakpoint.h (enum exception_event_kind): Moved here from
3889         break-catch-throw.c.
3890         (catch_exception_event): Declare.
3891         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3892         (mi_cmd_catch_throw): New function.
3893         (mi_cmd_catch_rethrow): New function.
3894         (mi_cmd_catch_catch): New function.
3895         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3896         'catch-catch' entries.
3897         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3898         (mi_cmd_catch_rethrow): Declare.
3899         (mi_cmd_catch_catch): Declare.
3900
3901 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * annotate.c (annotate_source_line): Change return type to void,
3904         update implementation to match.
3905         * annotate.h (annotate_source_line): Change return type to void,
3906         update header comment.
3907         * stack.c (print_frame_info): Don't change what frame information
3908         is printed based on whether annotations are on or not.
3909
3910 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3913         (annotate_source): Make static.
3914         (annotate_source_line): Moved from source.c and renamed from
3915         identify_source_line.  Update the return type.
3916         * annotate.h (annotate_source): Delete declaration.
3917         (annotate_source_line): Declaration moved from source.h, and
3918         renamed from identify_source_line.  Return type updated.
3919         * source.c (identify_source_line): Moved to annotate.c and renamed
3920         to annotate_source_line.
3921         (info_line_command): Remove check of annotation_level.
3922         * source.h (identify_source_line): Move declaration to annotate.h
3923         and rename to annotate_source_line.
3924         * stack.c: Add 'annotate.h' include.
3925         (print_frame_info): Remove check of annotation_level before
3926         calling annotate_source_line.
3927
3928 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * source-cache.c (source_cache::get_plain_source_lines): Use
3931         open_source_file_with_line_charpos instead of just
3932         open_source_file, remove call to find_source_lines.
3933         (source_cache::get_source_lines): Likewise.
3934         * source.c (find_source_lines): Make static.
3935         (get_filename_and_charpos): Renamed into...
3936         (open_source_file_with_line_charpos): ..this along with changes to
3937         return a scoped_fd, and some other minor clean ups.
3938         (identify_source_line): Use open_source_file_with_line_charpos.
3939         (search_command_helper): Use open_source_file_with_line_charpos
3940         instead of just open_source_file, remove call to
3941         find_source_lines.
3942         * source.h (open_source_file_with_line_charpos): Declare new
3943         function.
3944         (find_source_lines): Delete declaration.
3945
3946 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * source.c (get_filename_and_charpos): Remove fullname
3949         parameter.
3950         (identify_source_line): Update call to get_filename_and_charpos.
3951
3952 2019-06-14  Tom Tromey  <tromey@adacore.com>
3953
3954         PR gdb/24502:
3955         * ui-style.h (skip_ansi_escape): Update comment.
3956         * ui-file.h (class no_terminal_escape_file): New class.
3957         * ui-file.c (no_terminal_escape_file::write)
3958         (no_terminal_escape_file::puts): New methods.
3959         * cli/cli-logging.c (handle_redirections): Use
3960         no_terminal_escape_file.
3961
3962 2019-06-14  Tom Tromey  <tromey@adacore.com>
3963
3964         * NEWS: Move convenience variable news above Python news.
3965
3966 2019-06-14  Tom Tromey  <tom@tromey.com>
3967
3968         * gnulib: Move directory to top-level.
3969         * configure.ac: Don't configure gnulib.
3970         * configure: Rebuild.
3971         * common/common-defs.h: Use new path to gnulib.
3972         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3973         (GNULIB_H): Remove.
3974         (INCGNU): Look in new gnulib location.
3975         (HFILES_NO_SRCDIR): Remove gnulib files.
3976         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3977         (generated_files): Remove GNULIB_H.
3978         ($(LIBGNU), all-lib): Remove targets.
3979         (distclean): Don't mention GNULIB_BUILDDIR.
3980         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3981
3982 2019-06-14  Tom Tromey  <tromey@adacore.com>
3983
3984         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3985         Warn if symbol file does not provide any symbols.
3986
3987 2019-06-14  Tom Tromey  <tromey@adacore.com>
3988
3989         * source.c (find_and_open_source): Respect basenames_may_differ.
3990
3991 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * annotate.c (annotate_breakpoints_invalid): Make use of
3994         scoped_restore_terminal_state.
3995         (annotate_frames_invalid): Likewise.
3996
3997 2019-06-14  Tom Tromey  <tromey@adacore.com>
3998
3999         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4000         allow assignment to an internalvar.
4001
4002 2019-06-14  Tom Tromey  <tromey@adacore.com>
4003
4004         * ada-lex.l: Allow "_" in attribute names.
4005
4006 2019-06-14  Tom Tromey  <tromey@adacore.com>
4007
4008         PR gdb/24653:
4009         * regcache.c (registers_changed): Don't call alloca.
4010         * top.c (execute_command): Don't call alloca.
4011
4012 2019-06-13  Pedro Alves  <palves@redhat.com>
4013
4014         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4015         'expression'.  When parsing an expression, error out if there's
4016         junk after "unlimited".
4017         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4018         (do_set_command): Adjust calls to is_unlimited_literal.
4019
4020 2019-06-13  Pedro Alves  <palves@redhat.com>
4021
4022         * compile/compile.c (make_compile_options_def_group): Add braces
4023         around array_view initializer.
4024         * thread.c (make_thread_apply_all_options_def_group)
4025         (make_thread_apply_all_options_def_group): Likewise.
4026
4027 2019-06-13  Pedro Alves  <palves@redhat.com>
4028
4029         * NEWS (New commands): Mention "maint test-options
4030         require-delimiter", "maint test-options unknown-is-error", "maint
4031         test-options unknown-is-operand" and "maint show
4032         test-options-completion-result".
4033         (New command options, command completion): New section.
4034         (Completion improvements): New section.
4035         Mention that you can abbreviate "unlimited".
4036
4037 2019-06-13  Pedro Alves  <palves@redhat.com>
4038
4039         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4040         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4041         * unittests/cli-utils-selftests.c (test_parse_flags)
4042         (test_parse_flags_qcs): Delete.
4043         (test_cli_utils): Don't call deleted functions.
4044
4045 2019-06-13  Pedro Alves  <palves@redhat.com>
4046
4047         * thread.c: Include "cli/cli-option.h".
4048         (tp_array_compar_ascending): Global.
4049         (tp_array_compar): Delete function.
4050         (tp_array_compar_ascending, tp_array_compar_descending): New
4051         functions.
4052         (ascending_option_def, qcs_flag_option_def)
4053         (thr_qcs_flags_option_defs)
4054         (make_thread_apply_all_options_def_group)
4055         (make_thread_apply_options_def_group): New.
4056         (thread_apply_all_command): Use gdb::option::process_options.
4057         (thread_apply_command_completer)
4058         (thread_apply_all_command_completer): New.
4059         (thread_apply_command): Use gdb::option::process_options.
4060         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4061         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4062         to generate help text of "thread apply".  Adjust "taas"'s help.
4063         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4064         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4065
4066 2019-06-13  Pedro Alves  <palves@redhat.com>
4067
4068         * thread.c (thread_apply_command): Check for invalid TID with
4069         isdigit instead of !isalpha.
4070
4071 2019-06-13  Pedro Alves  <palves@redhat.com>
4072
4073         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4074         (validate_flags_qcs): New.
4075         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4076         (validate_flags_qcs): Declare.
4077         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4078         (make_frame_apply_options_def_group): New.
4079         (frame_apply_command_count): Process options with
4080         gdb::option::process_options.
4081         (frame_apply_completer): New.
4082         (frame_apply_level_completer, frame_apply_all_completer)
4083         (frame_apply_completer): New.
4084         (_initialize_stack): Update help of "frame apply", "frame apply
4085         level", "frame apply all" and "faas" to mention supported options
4086         and install command completers.
4087         * stack.h (frame_apply_all_completer): Declare.
4088         * thread.c: Include "stack.h".
4089         (tfaas_command): Add "--".
4090         (_initialize_thread): Update help "tfaas" to mention supported
4091         options and install command completer.
4092
4093 2019-06-13  Pedro Alves  <palves@redhat.com>
4094
4095         * completer.c (complete_nested_command_line): New.
4096         (gdb_completion_word_break_characters_throw): Add assertion.
4097         * completer.h (complete_nested_command_line): Declare.
4098
4099 2019-06-13  Pedro Alves  <palves@redhat.com>
4100
4101         * stack.c (parse_backtrace_qualifiers): New.
4102         (backtrace_command): Use it.
4103         (backtrace_command_completer): Complete on qualifiers.
4104
4105 2019-06-13  Pedro Alves  <palves@redhat.com>
4106
4107         * frame.c: Include "cli/cli-option.h.
4108         (user_set_backtrace_options): New.
4109         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4110         Delete.
4111         (get_prev_frame): Adjust.
4112         (boolean_option_def, uinteger_option_def)
4113         (set_backtrace_option_defs): New.
4114         (_initialize_frame): Adjust and use
4115         gdb::option::add_setshow_cmds_for_options to install "set
4116         backtrace past-main" and "set backtrace past-entry".
4117         * frame.h: Include "cli/cli-option.h".
4118         (struct frame_print_options): Forward declare.
4119         (print_frame_arguments_all, print_frame_arguments_scalars)
4120         (print_frame_arguments_none): Declare.
4121         (print_entry_values): Delete declaration.
4122         (struct frame_print_options, user_frame_print_options): New.
4123         (struct set_backtrace_options): New.
4124         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4125         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4126         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4127         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4128         (list_args_or_locals): Add frame_print_options parameter.
4129         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4130         * python/py-framefilter.c (enumerate_args): Pass down
4131         USER_FRAME_PRINT_OPTIONS.
4132         * stack.c: Include "cli/cli-option.h".
4133         (print_frame_arguments_all, print_frame_arguments_scalars)
4134         (print_frame_arguments_none): Declare.
4135         (print_raw_frame_arguments, print_entry_values): Delete.
4136         (user_frame_print_options): New.
4137         (boolean_option_def, enum_option_def, frame_print_option_defs):
4138         New.
4139         (struct backtrace_cmd_options): New.
4140         (bt_flag_option_def): New.
4141         (backtrace_command_option_defs): New.
4142         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4143         (print_frame_arg, read_frame_arg, print_frame_args)
4144         (print_frame_info, print_frame): Add frame_print_options parameter
4145         and use it.
4146         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4147         (backtrace_command_1): Add frame_print_options and
4148         backtrace_cmd_options parameters and use them.
4149         (make_backtrace_options_def_group): New.
4150         (backtrace_command): Process command options with
4151         gdb::option::process_options.
4152         (backtrace_command_completer): New.
4153         (_initialize_stack): Extend "backtrace"'s help to mention
4154         supported options.  Install completer for "backtrace".
4155         Install some settings commands with add_setshow_cmds_for_options.
4156
4157 2019-06-13  Pedro Alves  <palves@redhat.com>
4158
4159         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4160         and that "set/show print raw frame-arguments" are now deprecated.
4161
4162         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4163         command.
4164         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4165         * stack.c (_initialize_stack): Install "set/show print
4166         raw-frame-arguments", and deprecate "set/show print raw
4167         frame-arguments".
4168         * valprint.c (_initialize_valprint): Deprecate "set/show print
4169         raw".
4170
4171 2019-06-13  Pedro Alves  <palves@redhat.com>
4172
4173         * compile/compile.c (struct compile_options): New.
4174         (compile_flag_option_def, compile_command_option_defs)
4175         (make_compile_options_def_group): New.
4176         (compile_file_command): Handle options with
4177         gdb::option::process_options.
4178         (compile_file_command_completer): New function.
4179         (compile_code_command): Handle options with
4180         gdb::option::process_options.
4181         (compile_code_command_completer): New function.
4182         (_initialize_compiler): Install completers for "compile code" and
4183         "compile file".  Mention available options in "compile code" and
4184         "compile code"'s help.
4185         * completer.c (advance_to_completion_word): New, factored out from
4186         ...
4187         (advance_to_expression_complete_word_point): ... this.
4188         (advance_to_filename_complete_word_point): New.
4189         * completer.h (advance_to_filename_complete_word_point): New
4190         declaration.
4191
4192 2019-06-13  Pedro Alves  <palves@redhat.com>
4193
4194         * compile/compile.c: Include "cli/cli-option.h".
4195         (compile_print_value): Scope data pointer is now a
4196         value_print_options pointer; adjust.
4197         (compile_print_command): Process options.  Scope data pointer is
4198         now a value_print_options pointer; adjust.
4199         (_initialize_compile): Update "compile print"'s help to include
4200         supported options.  Install a completer for "compile print".
4201         * cp-valprint.c (show_vtblprint, show_objectprint)
4202         (show_static_field_print): Delete.
4203         (_initialize_cp_valprint): Don't install "set print
4204         static-members", "set print vtbl", "set print object" here.
4205         * printcmd.c: Include "cli/cli-option.h" and
4206         "common/gdb_optional.h".
4207         (print_command_parse_format): Rework to fill in a
4208         value_print_options instead of a format_data.
4209         (print_value): Change parameter type from format_data pointer to
4210         value_print_options reference.  Adjust.
4211         (print_command_1): Process options.  Adjust to pass down a
4212         value_print_options.
4213         (print_command_completer): New.
4214         (_initialize_printcmd): Install print_command_completer as
4215         handle_brkchars completer for the "print" command.  Update
4216         "print"'s help to include supported options.
4217         * valprint.c: Include "cli/cli-option.h".
4218         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4219         here from cp-valprint.c.
4220         (boolean_option_def, uinteger_option_def)
4221         (value_print_option_defs, make_value_print_options_def_group):
4222         New.  Use gdb::option::add_setshow_cmds_for_options to install
4223         "set print elements", "set print null-stop", "set print repeats",
4224         "set print pretty", "set print union", "set print array", "set
4225         print address", "set print symbol", "set print array-indexes".
4226         * valprint.h: Include <string> and "cli/cli-option.h".
4227         (make_value_print_options_def_group): Declare.
4228         (print_value): Change parameter type from format_data pointer to
4229         value_print_options reference.
4230         (print_command_completer): Declare.
4231
4232 2019-06-13  Pedro Alves  <palves@redhat.com>
4233
4234         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4235         (COMMON_SFILES): Add maint-test-settings.c.
4236         * cli/cli-decode.c (boolean_enums): New global, factored out from
4237         ...
4238         (add_setshow_boolean_cmd): ... here.
4239         * cli/cli-decode.h (boolean_enums): Declare.
4240         * cli/cli-option.c: New file.
4241         * cli/cli-option.h: New file.
4242         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4243         factored out from ...
4244         (parse_cli_boolean_value(const char *)): ... this.
4245         (is_unlimited_literal): Change parameter type to pointer to
4246         pointer.  Adjust and advance ARG pointer.
4247         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4248         (parse_cli_var_enum): New, factored out from ...
4249         (do_set_command): ... this.  Adjust.
4250         * cli/cli-setshow.h (parse_cli_boolean_value)
4251         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4252         (parse_cli_var_enum): Declare.
4253         * cli/cli-utils.c: Include "cli/cli-option.h".
4254         (get_ulongest): New.
4255         * cli/cli-utils.h (get_ulongest): Declare.
4256         (check_for_argument): New overloads.
4257         * maint-test-options.c: New file.
4258
4259 2019-06-13  Pedro Alves  <palves@redhat.com>
4260
4261         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4262         parse a range if "-" is at the end of the string.
4263
4264 2019-06-13  Pedro Alves  <palves@redhat.com>
4265
4266         * cli/cli-setshow.c (parse_auto_binary_operation)
4267         (parse_cli_boolean_value): Don't allow "o".
4268
4269 2019-06-13  Pedro Alves  <palves@redhat.com>
4270
4271         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4272         * NEWS: Mention maint test-settings KIND.
4273         * maint-test-settings.c: New file.
4274
4275 2019-06-13  Pedro Alves  <palves@redhat.com>
4276
4277         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4278         completer.
4279         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4280         "set" completers.
4281
4282 2019-06-13  Pedro Alves  <palves@redhat.com>
4283
4284         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4285         after item.
4286
4287 2019-06-13  Pedro Alves  <palves@redhat.com>
4288
4289         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4290
4291 2019-06-13  Pedro Alves <palves@redhat.com>
4292
4293         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4294         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4295         call.
4296         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4297         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4298         calls.
4299         (check_for_argument): Skip spaces after argument.
4300
4301 2019-06-13  Pedro Alves  <palves@redhat.com>
4302
4303         * thread.c (thread_apply_command): Adjust TID parsing.
4304         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4305         detected before end of string.
4306         (tid_is_in_list): Error out if LIST is invalid.
4307
4308 2019-06-13  Pedro Alves  <palves@redhat.com>
4309
4310         * completer.c (complete_line_internal_1): Rewind completion word
4311         point.
4312         (completion_tracker::advance_custom_word_point_by): Change
4313         parameter type to int.
4314         * completer.h (completion_tracker::advance_custom_word_point_by):
4315         Likewise.
4316
4317 2019-06-13  Pedro Alves  <palves@redhat.com>
4318
4319         * completer.c (advance_to_completion_word): Handle delimiters.
4320
4321 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4322
4323         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4324
4325 2019-06-11  Tom Tromey  <tom@tromey.com>
4326
4327         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4328         (xmalloc_failed): Move to alloc.c.
4329         * alloc.c: New file.
4330         * Makefile.in (COMMON_SFILES): Add alloc.c.
4331
4332 2019-06-11  Tom Tromey  <tom@tromey.com>
4333
4334         * nat/linux-waitpid.c: Don't include server.h.
4335         (linux_debug): Remove.
4336         (my_waitpid): Update.
4337
4338 2019-06-11  Tom Tromey  <tromey@adacore.com>
4339
4340         * infcall.c (_initialize_infcall): Remove trailing newline from
4341         help.
4342         * user-regs.c (_initialize_user_regs): Remove trailing newline
4343         from help.
4344         * typeprint.c (_initialize_typeprint): Remove trailing newline
4345         from help.
4346         * reverse.c (_initialize_reverse): Remove trailing newlines from
4347         help.
4348         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4349         from help.
4350         * language.c (add_set_language_command): Remove trailing newline
4351         from help.
4352         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4353         help.
4354         * disasm.c (_initialize_disasm): Remove trailing newline from
4355         help.
4356         * top.c (init_main): Remove trailing newline from help.
4357         * interps.c (_initialize_interpreter): Remove trailing newline
4358         from help.
4359         * btrace.c (_initialize_btrace): Remove trailing newlines from
4360         help.
4361         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4362         from help.
4363         * python/python.c (_initialize_python): Remove trailing newline
4364         from help.
4365         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4366         help.
4367         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4368         from help.  Reformat some text.
4369         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4370         from help.
4371         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4372         newline from help.
4373
4374 2019-06-11  Tom Tromey  <tromey@adacore.com>
4375
4376         * darwin-nat.c (darwin_decode_exception_message)
4377         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4378
4379 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * valops.c (value_slice): Check for not allocated or not
4382         associated values.
4383
4384 2019-06-10  Tom de Vries  <tdevries@suse.de>
4385
4386         PR gdb/24618
4387         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4388         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4389         invalid.
4390
4391 2019-06-10  Tom de Vries  <tdevries@suse.de>
4392
4393         PR gdb/24611
4394         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4395         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4396
4397 2019-06-10  Tom de Vries  <tdevries@suse.de>
4398
4399         PR symtab/24545
4400         * symtab.c (struct demangled_name_entry): Add language field.
4401         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4402         static minimal symbol".  Set and use language field.
4403
4404 2019-06-10  Tom Tromey  <tromey@adacore.com>
4405
4406         * ada-lang.c (_initialize_ada_language): Update help text.
4407
4408 2019-06-10  Tom Tromey  <tromey@adacore.com>
4409
4410         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4411         with a newline.
4412         * guile/guile.c (handle_boot_error): Don't end warning with a
4413         newline.
4414         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4415         warning with a newline.
4416         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4417         newline.
4418         (s12z_frame_cache): Likewise.
4419         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4420         a newline.
4421         * solib-svr4.c (disable_probes_interface): Don't end warning with
4422         a newline.
4423         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4424         newline.
4425         * python/python.c (do_finish_initialization): Don't end warning
4426         with a newline.
4427
4428 2019-06-10  Tom Tromey  <tom@tromey.com>
4429
4430         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4431         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4432         gdbpy_enter.
4433
4434 2019-06-10  Tom Tromey  <tromey@adacore.com>
4435
4436         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4437         data.
4438         (elf_new_init): Don't call stabsread_new_init.
4439         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4440         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4441         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4442
4443 2019-06-10  Tom de Vries  <tdevries@suse.de>
4444
4445         PR symtab/16264
4446         PR symtab/24517
4447         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4448
4449 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4450
4451         * source.c (find_and_open_source): Also rewrite relative file
4452         names.
4453
4454 2019-04-26  Amos Bird  <amosbird@gmail.com>
4455
4456         * annotate.c (annotate_thread_exited): Add "thread-exited"
4457         annotation.
4458
4459 2019-06-06  Tom Tromey  <tromey@adacore.com>
4460
4461         * maint.h (class scoped_command_stats): Use
4462         DISABLE_COPY_AND_ASSIGN.
4463         <print_time>: New method.
4464         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4465         print_time.
4466         (scoped_command_stats::print_time): New method.
4467
4468 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4471         instructions of lengths 6 or 8 bytes.
4472
4473 2019-06-04  Pedro Alves  <palves@redhat.com>
4474
4475         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4476
4477         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4478         * breakpoint.c (condition_completer): Likewise.
4479         * cli/cli-dump.c (scan_expression): Likewise.
4480         * common/filestuff.c (mkdir_recursive): Likewise.
4481         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4482         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4483         (gdb_abspath): Likewise.
4484         * compile/compile-cplus-types.c
4485         (compile_cplus_instance::decl_name): Likewise.
4486         * completer.c (complete_explicit_location):
4487         (signal_completer, reg_or_group_completer_1): Likewise.
4488         * cp-support.c (cp_remove_params_if_any): Likewise.
4489         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4490         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4491         * infcmd.c (strip_bg_char): Likewise.
4492         * linespec.c (copy_token_string): Likewise.
4493         * mi/mi-main.c (output_cores): Likewise.
4494         * psymtab.c (psymtab_search_name):
4495         * symfile.c (test_set_ext_lang_command): Likewise.
4496         * target.c (target_fileio_read_stralloc): Likewise.
4497         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4498         * value.c (complete_internalvar): Likewise.
4499
4500 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4501
4502         Add objfile property to gdb.Type.
4503         * NEWS: Mention Python API addition.
4504         * python/py-type.c (typy_get_objfile): New method.
4505
4506 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4507
4508         * NEWS: Mention the new set|show style [title|highlight].
4509         Mention changes to "show style", "help" and "apropos".
4510
4511 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4512
4513         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4514         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4515         instead of print_help_for_command.
4516         (print_doc_of_command): New function.
4517         (help_list): Add 'apropos -v word' suggestion.
4518         (print_help_for_command): Style the command name using title style.
4519         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4520         (_initialize_cli_cmds): Describe -v in apropos_command help.
4521
4522 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4523
4524         * cli/cli-style.h (cli_style_option): Add name in constructor,
4525         add m_name class member, add constructor with intensity,
4526         add name class function.
4527         (cli_style_option::add_setshow_commands): Remove name argument.
4528         (highlight_style, title_style): New styles.
4529         * cli/cli-style.c (do_show): New function that shows a style
4530         characteristic styling the style name with itself.
4531         (set_style_name): New function.
4532         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4533         Update all callers according to the changes in cli/cli-style.h.
4534         * utils.h (fputs_highlighted): New function.
4535         * utils.c (fputs_highlighted): Likewise.
4536
4537 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4538
4539         * NEWS: Mention new pipe command and new convenience variables.
4540
4541 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4542
4543         * cli/cli-cmds.c (pipe_command): New function.
4544         (_initialize_cli_cmds): Call add_com for pipe_command.
4545         Define | as an alias for pipe.
4546         (exit_status_set_internal_vars): New function.
4547         (shell_escape): Call exit_status_set_internal_vars.
4548         cli/cli-decode.c (find_command_name_length): Recognize | as
4549         a single character command.
4550
4551 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4552
4553         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4554         top.c (execute_command_to_ui_file): New function, mostly a copy
4555         of execute_command_to_string.
4556         (execute_command_to_string): Implement by calling
4557         execute_command_to_ui_file.
4558
4559 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4560
4561         * top.h (saved_command_line): Remove declaration.
4562         * top.c (previous_saved_command_line, previous_repeat_arguments):
4563         New variables.
4564         (saved_command_line): Make static, define together with other
4565         'repeat variables'.
4566         (dont_repeat): Clear repeat_arguments.
4567         (repeat_previous, get_saved_command_line, save_command_line):
4568         New functions.
4569         (gdb_init): Initialize saved_command_line
4570         and previous_saved_command_line.
4571         * main.c (captured_main_1): Remove saved_command_line initialization.
4572         * event-top.c (handle_line_of_input): Update to use
4573         the new 'repeat' related functions instead of direct access to
4574         saved_command_line.
4575         * command.h (repeat_previous, get_saved_command_line,
4576         save_command_line): New declarations.
4577         (dont_repeat): Add comment.
4578
4579 2019-05-30  Tom Tromey  <tromey@adacore.com>
4580
4581         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4582         Fix comment.
4583         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4584
4585 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4586
4587         PR cli/24587
4588         * completer.c (complete): Initialize variable word.
4589
4590 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4591
4592         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4593         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4594         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4595         'body' is NULL to the outter 'if', protecting the '!is_define'
4596         situation as well.
4597
4598 2019-05-29  Tom Tromey  <tromey@adacore.com>
4599
4600         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4601         (dwarf_unknown): New function.
4602         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4603         (dwarf_type_encoding_name): Use dwarf_unknown.
4604
4605 2019-05-29  Tom Tromey  <tromey@adacore.com>
4606
4607         PR c++/20020:
4608         * cp-valprint.c (cp_print_value_fields): Call
4609         cp_print_static_field inside "try".
4610
4611 2019-05-29  Tom Tromey  <tromey@adacore.com>
4612
4613         * inflow.c (struct terminal_info): Add default operator=.
4614         * configure: Rebuild.
4615         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4616         -Wdeprecated-copy-dtor, -Wredundant-move.
4617
4618 2019-05-29  Tom Tromey  <tromey@adacore.com>
4619
4620         * NEWS: Add entry.
4621         * infcmd.c (print_return_value_1): Handle finish_print
4622         option.
4623         (show_print_finish): New function.
4624         (_initialize_infcmd): Add "set/show print finish" commands.
4625         * valprint.c (user_print_options): Initialize new member.
4626         * valprint.h (struct value_print_options) <finish_print>: New
4627         member.
4628
4629 2019-05-28  Tom Tromey  <tromey@adacore.com>
4630
4631         * ada-lang.c (ada_remove_Xbn_suffix)
4632         (find_old_style_renaming_symbol)
4633         (parse_old_style_renaming): Remove.
4634         (ada_find_renaming_symbol): Don't call
4635         find_old_style_renaming_symbol.
4636         (ada_is_renaming_symbol): Rename from
4637         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4638         bool.  Now static.
4639         (ada_read_var_value): Update and simplify.
4640         * ada-exp.y (write_var_or_type): Remove old code.
4641
4642 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4643
4644         * event-top.c: Remove include comment.
4645         * inflow.c (class scoped_ignore_sigttou): Move from here...
4646         * inflow.h (class scoped_ignore_sigttou): ...to here.
4647         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4648         * top.c:  Remove include comment.
4649
4650 2019-05-27  Tom Tromey  <tom@tromey.com>
4651
4652         * NEWS: Fix typo.
4653
4654 2019-05-22  Tom Tromey  <tromey@adacore.com>
4655
4656         * target.c (target_follow_exec): Constify parameter.
4657         * target-delegates.c: Rebuild.
4658         * remote.c (remote_target::follow_exec): Constify parameter.
4659         * infrun.c (follow_exec): Constify parameter.
4660         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4661         (target_follow_exec): Likewise.
4662
4663 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4664
4665         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4666         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4667
4668 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4669
4670         * NEWS: Add debugredirect and testsuite sections.
4671
4672 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4673
4674         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4675         target descriptions using exclusively floating point register name
4676         aliases.
4677
4678 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4679
4680         PR gdb/18644:
4681         * f-lang.c (build_fortran_types): Handle the case where
4682         gdbarch_floatformat_for_type returns a nullptr.
4683
4684 2019-05-21  Tom de Vries  <tdevries@suse.de>
4685
4686         PR cli/24587
4687         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4688
4689 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4690
4691         PR gdb/18644:
4692         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4693         16-byte floats.
4694         * i386-tdep.c (i386_floatformat_for_type): Use
4695         floatformats_ia64_quad for the 16-byte floating point component
4696         within a fortran 32-byte complex number.
4697
4698 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4701         delete default constructor.
4702         (find_partial_die): Update to return const struct.
4703         (partial_die_parent_scope): Move variable declaration into scope
4704         of its use and change its type to auto.
4705         (guess_partial_die_structure_name): Likewise.
4706         (partial_die_info::fixup): Likewise.
4707
4708 2019-05-17  Tom Tromey  <tromey@adacore.com>
4709
4710         * source.c (find_and_open_source): Remove cast.
4711
4712 2019-05-17  Tom Tromey  <tromey@adacore.com>
4713
4714         * annotate.c (annotate_source): Make "filename" const.
4715         * annotate.h (annotate_source): Use const.
4716
4717 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4718
4719         * disasm.c (set_disassembler_options): Send errors to stderr.
4720
4721 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4722
4723         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4724         (cli_interp_base::set_logging): Check debug_redirect.
4725         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4726         * cli/cli-logging.c (debug_redirect): Add static variable.
4727         (pop_output_files): Add default param.
4728         (handle_redirections): Print debug setting.
4729         (show_logging_command): Likewise.
4730         (_initialize_cli_logging): Add debugredirect command.
4731         * interps.c (current_interp_set_logging): Add debug_redirect
4732         parameter.
4733         * interps.h (set_logging): Add debug_redirect parameter.
4734         (current_interp_set_logging): Likewise.
4735         * mi/mi-common.h: Likewise.
4736         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4737
4738 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4739             Tom Tromey  <tromey@adacore.com>
4740
4741         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4742         directly.
4743         * cli/cli-interp.h (make_logging_output): Remove declaration.
4744         * cli/cli-logging.c (make_logging_output): Remove function.
4745         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4746         directly.
4747         * ui-file.c (tee_file::tee_file): Remove bools.
4748         (tee_file::~tee_file): Remove deletes.
4749         * ui-file.h (tee_file): Remove bools.
4750
4751 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4752
4753         * mi/mi-cmds.h (mi_cmd_complete): New function.
4754         * mi/mi-main.c (mi_cmd_complete): Likewise.
4755         * mi/mi-cmds.c: Define new MI command -complete.
4756         * NEWS: Mention new -complete command.
4757
4758 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4759
4760         * completer.h (complete): New function.
4761         * completer.c (complete): Likewise.
4762         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4763         function defined in completer.h.
4764
4765 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4766
4767         * MAINTAINERS (Write After Approval): Add myself.
4768
4769 2019-05-17  Tom de Vries  <tdevries@suse.de>
4770
4771         PR gdb/24094
4772         * dwarf2read.c (struct cu_partial_die_info): New struct.
4773         (find_partial_die): Return cu_partial_die_info.
4774         (partial_die_parent_scope, guess_partial_die_structure_name)
4775         (partial_die_info::fixup): Handle new return type of find_partial_die.
4776
4777 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4778
4779         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4780         "std::string", simplifying the algorithm.
4781
4782 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4783
4784         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4785         (stap_static_probe_ops::get_probes): Likewise.
4786
4787 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4788
4789         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4790         '-')" and "else if".
4791         (stap_parse_single_operand): Join checks for
4792         "gdbarch_stap_parse_special_token_p" and
4793         "gdbarch_stap_parse_special_token" in the same "if" statement.
4794         Invert check when verifying for operation on register
4795         displacement.
4796
4797 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4798
4799         * stap-probe.c (stap_get_opcode): Update comment.
4800         (stap_get_expected_argument_type): Likewise.
4801         (handle_stap_probe): Likewise.
4802
4803 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4804
4805         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4806         return type to 'bool'.  Adjust comment.  Use 'bool' when
4807         appropriate.
4808         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4809         * stap-probe.c (stap_parse_argument_1): Likewise.
4810         (stap_is_operator): Likewise.
4811         (stap_is_generic_prefix): Likewise.
4812         (stap_is_register_prefix): Likewise.
4813         (stap_is_register_indirection_prefix): Likewise.
4814         (stap_is_integer_prefix): Likewise.
4815         (stap_generic_check_suffix): Likewise.
4816         (stap_check_integer_suffix): Likewise.
4817         (stap_check_register_suffix): Likewise.
4818         (stap_check_register_indirection_suffix): Likewise.
4819         (stap_parse_register_operand): Likewise.
4820         (stap_parse_single_operand): Likewise.
4821         (stap_parse_argument_1): Likewise.
4822         (stap_probe::get_argument_count): Likewise.
4823         (stap_is_operator): Likewise.
4824
4825 2019-05-16  Tom Tromey  <tromey@adacore.com>
4826
4827         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4828         keyword to foreach.
4829
4830 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4831
4832         * linux-thread-db.c (try_thread_db_load_1): Change return type
4833         to bool.
4834         (try_thread_db_load): Likewise.
4835         (try_thread_db_load_from_pdir_1): Likewise.
4836         (try_thread_db_load_from_pdir): Likewise.
4837         (try_thread_db_load_from_sdir): Likewise.
4838         (try_thread_db_load_from_dir): Likewise.
4839         (thread_db_load_search): Likewise.
4840         (has_libpthread): Likewise.
4841         (thread_db_load): Likewise.
4842
4843 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4844
4845         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4846         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4847         NULL, and complain/return if that's the case.
4848
4849 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4850
4851         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4852         (advance, posn, abstract_read_memory): New functions.
4853         [struct mem_read_abstraction]: New struct.
4854         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4855
4856 2019-05-14  Tom Tromey  <tromey@adacore.com>
4857
4858         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4859         value is not lval_memory.
4860
4861 2019-05-14  Tom Tromey  <tromey@adacore.com>
4862
4863         * solib.c (info_sharedlibrary_command): Style the file name.
4864
4865 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4866
4867         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4868         (aarch64_vnv_type): Likewise.
4869         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4870         * common/tdesc.c: Likewise.
4871         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4872         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4873         * features/aarch64-fpu.xml: Add ieee half view.
4874         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4875         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4876         * gdbtypes.h (struct builtin_type): Likewise.
4877         (struct objfile_type): Likewise.
4878
4879 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4880
4881         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4882         typo.
4883         * location.h (string_to_event_location): Likewise.
4884
4885 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4886
4887         GDB 8.3 released.
4888
4889 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4890
4891         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4892         New variable declaration.
4893         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4894         New variable.
4895         (print_one_breakpoint): Use ui_out::test_flags and new global
4896         variable to compute use_fixed_output.
4897         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4898         Remove.
4899         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4900         (mi_multi_location_breakpoint_output_fixed): Remove.
4901         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4902         new variable.
4903         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4904         fix_multi_location_breakpoint_output flag if version >= 3.
4905         * ui-out.h (enum ui_out_flag)
4906         <fix_multi_location_breakpoint_output>: New enumerator.
4907
4908 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4911
4912 2019-05-10  Tom Tromey  <tromey@adacore.com>
4913
4914         * ada-lang.c (catch_ada_completer): New function.
4915         (_initialize_ada_language): Use it.
4916
4917 2019-05-10  Tom Tromey  <tromey@adacore.com>
4918
4919         * thread.c (print_thread_info): Make "requested_threads" const.
4920         * gdbthread.h (print_thread_info): Make "requested_threads"
4921         const.
4922         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4923         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4924
4925 2019-05-08  Tom Tromey  <tom@tromey.com>
4926
4927         * gdbtypes.c (objfile_type_data): Change type.
4928         (objfile_type, _initialize_gdbtypes): Update.
4929
4930 2019-05-08  Tom Tromey  <tom@tromey.com>
4931
4932         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4933         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4934         (_initialize_dwarf2_frame): Update.
4935
4936 2019-05-08  Tom Tromey  <tom@tromey.com>
4937
4938         * objc-lang.c (objc_objfile_data): Change type.
4939         (find_methods): Update.
4940         (_initialize_objc_lang): Remove.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * stabsread.c (rs6000_builtin_type_data): Change type.
4945         (rs6000_builtin_type, _initialize_stabsread): Update.
4946
4947 2019-05-08  Tom Tromey  <tom@tromey.com>
4948
4949         * mips-tdep.c (mips_pdr_data): Remove.
4950         (_initialize_mips_tdep): Update.
4951
4952 2019-05-08  Tom Tromey  <tom@tromey.com>
4953
4954         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4955         (hppa_init_objfile_priv_data, read_unwind_info)
4956         (find_unwind_entry, _initialize_hppa_tdep): Update.
4957
4958 2019-05-08  Tom Tromey  <tom@tromey.com>
4959
4960         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4961         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4962         on obstack.
4963         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4964
4965 2019-05-08  Tom Tromey  <tom@tromey.com>
4966
4967         * mdebugread.c (basic_type_data): Change type.
4968         (basic_type, _initialize_mdebugread): Update.
4969
4970 2019-05-08  Tom Tromey  <tom@tromey.com>
4971
4972         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4973
4974 2019-05-08  Tom Tromey  <tom@tromey.com>
4975
4976         * nto-tdep.c (nto_inferior_data_reg): Change type.
4977         (nto_inferior_data): Update.
4978         (nto_inferior_data_cleanup, nto_new_inferior_data)
4979         (_initialize_nto_tdep): Remove.
4980         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4981
4982 2019-05-08  Tom Tromey  <tom@tromey.com>
4983
4984         * ada-lang.c (struct ada_inferior_data): Add initializers.
4985         (ada_inferior_data): Change type.
4986         (ada_inferior_data_cleanup): Remove.
4987         (get_ada_inferior_data, ada_inferior_exit)
4988         (struct ada_pspace_data): Add initializers, destructor.
4989         (ada_pspace_data_handle): Change type.
4990         (get_ada_pspace_data): Update.
4991         (ada_pspace_data_cleanup): Remove.
4992
4993 2019-05-08  Tom Tromey  <tom@tromey.com>
4994
4995         * coffread.c (struct coff_symfile_info): Add initializers.
4996         (coff_objfile_data_key): Move lower.  Change type.
4997         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4998         Update.
4999         (coff_free_info): Remove.
5000
5001 2019-05-08  Tom Tromey  <tom@tromey.com>
5002
5003         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5004         (fbsd_pspace_data_handle): Move lower.  Change type.
5005         (get_fbsd_pspace_data): Update.
5006         (fbsd_pspace_data_cleanup): Remove.
5007         (_initialize_fbsd_tdep): Update.
5008
5009 2019-05-08  Tom Tromey  <tom@tromey.com>
5010
5011         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5012         (get_ada_tasks_pspace_data): Update.
5013         (ada_tasks_pspace_data_cleanup): Remove.
5014         (_initialize_tasks): Update.
5015         (ada_tasks_inferior_data_handle): Change type.
5016         (get_ada_tasks_inferior_data): Update.
5017         (ada_tasks_inferior_data_cleanup): Remove.
5018         (struct ada_tasks_pspace_data): Add initializers.
5019
5020 2019-05-08  Tom Tromey  <tom@tromey.com>
5021
5022         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5023         * symfile-debug.c (debug_sym_get_probes): Change type.
5024         * stap-probe.c (handle_stap_probe):
5025         (stap_static_probe_ops::get_probes): Change type.
5026         * probe.h (class static_probe_ops) <get_probes>: Change type.
5027         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5028         (parse_probes_in_pspace): Update.
5029         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5030         Update.
5031         (any_static_probe_ops::get_probes): Change type.
5032         * elfread.c (elfread_data): New typedef.
5033         (probe_key): Change type.
5034         (elf_get_probes): Likewise.  Update.
5035         (probe_key_free): Remove.
5036         (_initialize_elfread): Update.
5037         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5038         Change type.
5039         (dtrace_process_dof_probe, dtrace_process_dof)
5040         (dtrace_static_probe_ops::get_probe): Change type.
5041
5042 2019-05-08  Tom Tromey  <tom@tromey.com>
5043
5044         * xcoffread.c (struct xcoff_symfile_info): Rename from
5045         coff_symfile_info.  Add initializers.
5046         (xcoff_objfile_data_key): Move lower.  Change type.
5047         (XCOFF_DATA): Rewrite.
5048         (xcoff_free_info): Remove.
5049         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5050         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5051         (xcoff_initial_scan): Update.
5052
5053 2019-05-08  Tom Tromey  <tom@tromey.com>
5054
5055         * solib-svr4.c (struct svr4_info): Add initializers and
5056         destructor.
5057         <probes_table>: Now an htab_up.
5058         (solib_svr4_pspace_data): Change type.
5059         (free_probes_table): Simplify.
5060         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5061         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5062         (probes_table_remove_objfile_probes, register_solib_event_probe)
5063         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5064         (_initialize_svr4_solib): Update.
5065
5066 2019-05-08  Tom Tromey  <tom@tromey.com>
5067
5068         * remote.c (remote_pspace_data): Change type.
5069         (remote_pspace_data_cleanup): Remove.
5070         (get_remote_exec_file, set_pspace_remote_exec_file)
5071         (_initialize_remote): Update.
5072
5073 2019-05-08  Tom Tromey  <tom@tromey.com>
5074
5075         * breakpoint.c (breakpoint_objfile_key): Change type.
5076         (get_breakpoint_objfile_data): Update.
5077         (free_breakpoint_objfile_data): Remove.
5078         (_initialize_breakpoint): Update.
5079
5080 2019-05-08  Tom Tromey  <tom@tromey.com>
5081
5082         * linux-tdep.c (struct linux_info): Add initializers.
5083         (linux_inferior_data): Move.  Change type.
5084         (invalidate_linux_cache_inf): Update.
5085         (linux_inferior_data_cleanup): Remove.
5086         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5087
5088 2019-05-08  Tom Tromey  <tom@tromey.com>
5089
5090         * auxv.c (auxv_inferior_data): Move.  Change type.
5091         (auxv_inferior_data_cleanup): Remove.
5092         (invalidate_auxv_cache_inf): Rewrite.
5093         (get_auxv_inferior_data, _initialize_auxv): Update.
5094
5095 2019-05-08  Tom Tromey  <tom@tromey.com>
5096
5097         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5098         (symfile_debug_objfile_data_key): Change type.
5099         (symfile_debug_installed, debug_qf_has_symbols)
5100         (debug_qf_find_last_source_symtab)
5101         (debug_qf_forget_cached_source_info)
5102         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5103         (debug_qf_print_stats, debug_qf_dump)
5104         (debug_qf_expand_symtabs_for_function)
5105         (debug_qf_expand_all_symtabs)
5106         (debug_qf_expand_symtabs_with_fullname)
5107         (debug_qf_map_matching_symbols)
5108         (debug_qf_expand_symtabs_matching)
5109         (debug_qf_find_pc_sect_compunit_symtab)
5110         (debug_qf_map_symbol_filenames)
5111         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5112         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5113         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5114         (debug_sym_read_linetable, debug_sym_relocate): Update.
5115         (symfile_debug_free_objfile): Remove.
5116         (install_symfile_debug_logging, _initialize_symfile_debug):
5117         Update.
5118
5119 2019-05-08  Tom Tromey  <tom@tromey.com>
5120
5121         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5122         allocate_on_obstack.
5123         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5124         (get_dwarf2_per_objfile): Update.
5125         (set_dwarf2_per_objfile): Remove.
5126         (dwarf2_has_info, dwarf2_get_section_info): Update.
5127         (dwarf2_free_objfile): Remove.
5128         (_initialize_dwarf2_read): Update.
5129
5130 2019-05-08  Tom Tromey  <tom@tromey.com>
5131
5132         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5133         initializers.
5134         <unsupported_script_warning_printed,
5135         script_not_found_warning_printed>: Now bool.
5136         (auto_load_pspace_data): Change type.
5137         (~auto_load_pspace_info): Rename from
5138         auto_load_pspace_data_cleanup.
5139         (get_auto_load_pspace_data, init_loaded_scripts_info)
5140         (clear_section_scripts, maybe_print_unsupported_script_warning)
5141         (maybe_print_script_not_found_warning, _initialize_auto_load):
5142         Update.
5143
5144 2019-05-08  Tom Tromey  <tom@tromey.com>
5145
5146         * objfiles.c (objfile_pspace_info): Add destructor and
5147         initializers.
5148         (objfiles_pspace_data): Change type.
5149         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5150         (get_objfile_pspace_data): Update.
5151         (objfiles_bfd_data): Change type.
5152         (get_objfile_bfd_data): Update.
5153         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5154
5155 2019-05-08  Tom Tromey  <tom@tromey.com>
5156
5157         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5158         Change type.
5159         (get_catch_syscall_inferior_data): Update.
5160         (catch_syscall_inferior_data_cleanup): Remove.
5161         (_initialize_break_catch_syscall): Update.
5162
5163 2019-05-08  Tom Tromey  <tom@tromey.com>
5164
5165         * inflow.c (struct terminal_info): Add destructor and
5166         initializers.
5167         (inflow_inferior_data): Change type.
5168         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5169         (get_inflow_inferior_data, inflow_inferior_exit)
5170         (swap_terminal_info, _initialize_inflow): Update.
5171
5172 2019-05-08  Tom Tromey  <tom@tromey.com>
5173
5174         * target-dcache.c (target_dcache_cleanup): Remove.
5175         (target_dcache_aspace_key): Change type.
5176         (target_dcache_init_p, target_dcache_invalidate)
5177         (target_dcache_get, target_dcache_get_or_init)
5178         (_initialize_target_dcache): Update.
5179         * dcache.h (struct dcache_deleter): New.
5180
5181 2019-05-08  Tom Tromey  <tom@tromey.com>
5182
5183         * symtab.c (struct symbol_cache): Add destructor and
5184         initializers.
5185         (symbol_cache_key): Move.  Change type.
5186         (make_symbol_cache, free_symbol_cache): Remove.
5187         (get_symbol_cache): Update.
5188         (symbol_cache_cleanup): Remove.
5189         (ALL_PSPACES, symbol_cache_flush)
5190         (maintenance_print_symbol_cache)
5191         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5192         Update.
5193
5194 2019-05-08  Tom Tromey  <tom@tromey.com>
5195
5196         * symtab.c (struct main_info): Add destructor and initializers.
5197         (main_progspace_key): Move.  Change type.
5198         (get_main_info): Update.
5199         (main_info_cleanup): Remove.
5200         (_initialize_symtab): Update.
5201
5202 2019-05-08  Tom Tromey  <tom@tromey.com>
5203
5204         * registry.h (DECLARE_REGISTRY): Define the _key class.
5205
5206 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5207
5208         * NEWS: Merge two 'New commands' sections.
5209
5210 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5211
5212         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5213         parameter and use Ada language definition instead.
5214         (ada_val_print_ptr): Remove unused language parameter.
5215         (ada_val_print_num): Remove language parameter and use Ada language
5216         definition instead.
5217         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5218         parameter.
5219         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5220         parameter and use Ada language definition instead.
5221         (ada_val_print_1): Update all ada_val_print_xxx calls.
5222         Remove language parameter.
5223         (ada_val_print): Update ada_val_print_1 call.
5224
5225 2019-05-08  Tom Tromey  <tromey@adacore.com>
5226
5227         * remote.c (remote_hw_watchpoint_limit)
5228         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5229         Now static.
5230
5231 2019-05-08  Tom Tromey  <tromey@adacore.com>
5232
5233         * maint.c (_initialize_maint_cmds): Move initialization code to
5234         remote.c.
5235         (watchdog, show_watchdog): Move to remote.c.
5236         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5237         "watchdog" static.
5238         (_initialize_remote): Move initialization code from maint.c.
5239         * defs.h (watchdog): Don't declare.
5240
5241 2019-05-08  Tom Tromey  <tromey@adacore.com>
5242
5243         * tui/tui-interp.c: Include main.h.
5244         * interps.c: Include main.h.
5245         * main.h (interpreter_p): Declare.
5246         * defs.h (interpreter_p): Don't declare.
5247
5248 2019-05-08  Tom Tromey  <tromey@adacore.com>
5249
5250         * dwarf2loc.c: Include dwarf2read.h.
5251         * defs.h (read_unsigned_leb128): Don't declare.
5252         * dwarf2read.h (read_unsigned_leb128): Declare.
5253
5254 2019-05-08  Tom Tromey  <tromey@adacore.com>
5255
5256         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5257         method.
5258
5259 2019-05-08  Tom Tromey  <tromey@adacore.com>
5260
5261         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5262         when no wrap column is set.
5263
5264 2019-05-08  Tom Tromey  <tromey@adacore.com>
5265
5266         * c-lang.c (c_get_string): Handle non-C-style arrays.
5267
5268 2019-05-08  Tom Tromey  <tromey@adacore.com>
5269
5270         * typeprint.c (print_offset_data::update): Print the bit offset,
5271         not the number of bits remaining.
5272
5273 2019-05-08  Tom Tromey  <tromey@adacore.com>
5274
5275         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5276         padding at end of comment.
5277
5278 2019-05-08  Tom Tromey  <tromey@adacore.com>
5279
5280         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5281         Compare main types.
5282
5283 2019-05-06  Tom Tromey  <tom@tromey.com>
5284
5285         * common/scoped_mmap.c: Include common-defs.h.
5286         * common/scoped_mmap.h: Don't include config.h.
5287
5288 2019-05-04  Tom Tromey  <tom@tromey.com>
5289
5290         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5291         (struct aarch64_call_info): Add initializers.
5292         <si>: Now a std::vector.
5293         (pass_on_stack, aarch64_push_dummy_call): Update.
5294
5295 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5296             Tom Tromey  <tom@tromey.com>
5297
5298         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5299         (ppc_threads): Now a std::vector.  Now static.
5300         (hwdebug_find_thread_points_by_tid)
5301         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5302         Update.
5303
5304 2019-05-04  Tom Tromey  <tom@tromey.com>
5305
5306         * arc-tdep.c (arc_tdesc_init): Return bool.
5307
5308 2019-05-04  Tom Tromey  <tom@tromey.com>
5309
5310         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5311         Use gdb_assert_not_reached.
5312
5313 2019-05-04  Tom Tromey  <tom@tromey.com>
5314
5315         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5316         "false".
5317
5318 2019-05-04  Tom Tromey  <tom@tromey.com>
5319
5320         * arc-tdep.c (arc_tdesc_init): Use bool.
5321
5322 2019-05-04  Tom Tromey  <tom@tromey.com>
5323
5324         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5325
5326 2019-05-04  Tom Tromey  <tom@tromey.com>
5327
5328         * cli/cli-cmds.c (valid_command_p): Return bool.
5329
5330 2019-05-04  Tom Tromey  <tom@tromey.com>
5331
5332         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5333         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5334
5335 2019-05-04  Raul Tambre  <raul@tambre.ee>
5336
5337         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5338         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5339         operator for comparison.
5340
5341 2019-05-04  Tom Tromey  <tom@tromey.com>
5342
5343         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5344         (lookup_partial_symbol, print_partial_symbols)
5345         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5346         (psymbol_compare): Update.
5347         (add_psymbol_to_bcache): Clear the entire psymbol.
5348         (maintenance_check_psymtabs): Update.
5349         * psympriv.h (struct partial_symbol): Don't derive from
5350         general_symbol_info.
5351         <obj_section, unrelocated_address, address,
5352         set_unrelocated_address>: Update.
5353         <ginfo>: New member.
5354         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5355         (debug_names::write_psymbols): Update.
5356
5357 2019-05-04  Tom de Vries  <tdevries@suse.de>
5358
5359         * contrib/cc-with-tweaks.sh: Support -n arg.
5360
5361 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5362
5363         * corelow.c (core_target::detach): Ensure frame cache and
5364         register caches are cleared.
5365         inferior.c (exit_inferior_1): Likewise.
5366
5367 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5368             Tom Tromey  <tom@tromey.com>
5369
5370         * dictionary.c (collate_pending_symbols_by_language): Remove
5371         "struct" from foreach.
5372         * symtab.c (lookup_global_symbol_from_objfile)
5373         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5374         foreach.
5375         * ser-tcp.c (net_open): Remove "struct" from foreach.
5376         * objfiles.c (objfile_relocate, objfile_rebase)
5377         (objfile_has_symbols): Remove "struct" from foreach.
5378         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5379         from foreach.
5380         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5381         foreach.
5382         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5383         "struct" from foreach.
5384         * ada-lang.c (create_excep_cond_exprs)
5385         (ada_exception_catchpoint_cond_string): Remove "struct" from
5386         foreach.
5387
5388 2019-05-03  Tom Tromey  <tromey@adacore.com>
5389
5390         * ada-exp.y (convert_char_literal): Check suffix of each
5391         enumerator.
5392
5393 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5394
5395         PR ada/21406:
5396         * ada-exp.y (yywrap): Don't define.
5397         * ada-lex.l (%option): Add noyywrap
5398         (yywrap): Remove.
5399
5400 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5401
5402         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5403         _WIN32_WINNT to the XP level, unless already defined to a higher
5404         level.
5405
5406         * unittests/parse-connection-spec-selftests.c:
5407         * ser-tcp.c:
5408         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5409         override.
5410
5411         * symfile.c (find_separate_debug_file): Remove colon from the
5412         drive spec of DOS/Windows file names of the target, so that the
5413         file name produced from DEBUGDIR and the target's directory will
5414         be valid on DOS/Windows systems.
5415
5416 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * rust-lang.c (val_print_struct): Handle printing structures
5419         containing strings.
5420
5421 2019-05-02  Tom Tromey  <tromey@adacore.com>
5422
5423         * valarith.c (_initialize_valarith): Remove.
5424
5425 2019-05-01  Tom Tromey  <tromey@adacore.com>
5426
5427         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5428         bitfields.
5429
5430 2019-05-01  Tom Tromey  <tromey@adacore.com>
5431
5432         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5433         for big-endian copies.
5434
5435 2019-04-30  Ali Tamur  <tamur@google.com>
5436         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5437         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5438         (read_3_bytes): New function.
5439
5440 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5441
5442         * windows-nat.c (main_thread_id): Delete.
5443         (handle_output_debug_string): Replace main_thread_id by
5444         current_event.dwThreadId.
5445         (fake_create_process): Likewise.
5446         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5447         Do not set main_thread_id.
5448         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5449         current_event.dwThreadId.
5450         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5451
5452 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5453
5454         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5455         Use current_event.dwThreadId instead of main_thread_id.
5456
5457 2019-04-30  Tom Tromey  <tromey@adacore.com>
5458
5459         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5460         (create_excep_cond_exprs): Iterate over program spaces.
5461         (ada_exception_catchpoint_cond_string): Examine all minimal
5462         symbols for exception types.
5463
5464 2019-04-30  Tom Tromey  <tromey@adacore.com>
5465
5466         PR c++/24470:
5467         * dwarf2read.c (process_structure_scope): Handle case where type
5468         has template parameters but no symbol was created.
5469
5470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5471             Chris January  <chris.january@arm.com>
5472
5473         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5474         qualifier.
5475         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5476
5477 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5478
5479         * f-typeprint.c (f_print_type): Update rules for printing
5480         whitespace.
5481         (f_type_print_varspec_suffix): Likewise.
5482
5483 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5484             Chris January  <chris.january@arm.com>
5485
5486         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5487         function arguments.
5488
5489 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * f-lang.c (build_fortran_types): Change name of void type to
5492         lower case.
5493         * f-typeprint.c (f_type_print_base): Print the name of the void
5494         type, rather than a fixed string.
5495         * f-valprint.c (f_decorations): Use lower case void string.
5496
5497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5498             Chris January  <chris.january@arm.com>
5499
5500         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5501         types for Fortran.
5502
5503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5504             Chris January  <chris.january@arm.com>
5505             David Lecomber  <david.lecomber@arm.com>
5506
5507         * f-exp.y (BINOP_INTRINSIC): New token.
5508         (exp): New parser rule handling BINOP_INTRINSIC.
5509         (f77_keywords): Add new builtin procedures.
5510         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5511         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5512         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5513         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5514         (print_unop_subexp_f): New function.
5515         (print_binop_subexp_f): New function.
5516         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5517         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5518         (dump_subexp_body_f): Likewise.
5519         (operator_check_f): Likewise.
5520         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5521         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5522
5523 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5526         UNOP_KIND.
5527         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5528         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5529         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5530         (operator_length_f): New fuction.
5531         (print_subexp_f): New function.
5532         (op_name_f): New function.
5533         (dump_subexp_body_f): New function.
5534         (operator_check_f): New function.
5535         (exp_descriptor_f): Replace standard expression handling functions
5536         with new functions.
5537         * gdb/fortran-operator.def: New file.
5538         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5539         * gdb/std-operator.def: Remove UNOP_KIND.
5540
5541 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5542
5543         * std-operator.def: Remove unbalanced, stray double quote
5544         character.
5545
5546 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5547             Chris January  <chris.january@arm.com>
5548             Daniel Everett  <daniel.everett@arm.com>
5549             Nick Forrington  <nick.forrington@arm.com>
5550             Richard Bunt  <richard.bunt@arm.com>
5551
5552         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5553         of depth when printing anonymous structs or unions.
5554         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5555         Don't print either the top-level value, or the children if the
5556         max-depth is exceeded.
5557         (ppscm_print_children): When printing the key of a map, allow one
5558         extra level of depth.
5559         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5560         print either the top-level value, or the children if the max-depth
5561         is exceeded.
5562         (print_children): When printing the key of a map, allow one extra
5563         level of depth.
5564         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5565         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5566         (user_print_options): Initialise max_depth field.
5567         (val_print_scalar_or_string_type_p): New function.
5568         (val_print): Check to see if the max depth has been reached.
5569         (val_print_check_max_depth): Define new function.
5570         (show_print_max_depth): New function.
5571         (_initialize_valprint): Add 'print max-depth' option.
5572         * valprint.h (struct value_print_options) <max_depth>: New field.
5573         (val_print_check_max_depth): Declare new function.
5574         * NEWS: Document new feature.
5575
5576 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5577
5578         * ada-lang.c (ada_language_defn): Initialise new field.
5579         * c-lang.c (c_is_string_type_p): New function.
5580         (c_language_defn): Initialise new field.
5581         (cplus_language_defn): Initialise new field.
5582         (asm_language_defn): Initialise new field.
5583         (minimal_language_defn): Initialise new field.
5584         * c-lang.h (c_is_string_type_p): Declare new function.
5585         * d-lang.c (d_language_defn): Initialise new field.
5586         * f-lang.c (f_is_string_type_p): New function.
5587         (f_language_defn): Initialise new field.
5588         * go-lang.c (go_is_string_type_p): New function.
5589         (go_language_defn): Initialise new field.
5590         * language.c (default_is_string_type_p): New function.
5591         (unknown_language_defn): Initialise new field.
5592         (auto_language_defn): Initialise new field.
5593         * language.h (struct language_defn) <la_is_string_type_p>: New
5594         member variable.
5595         (default_is_string_type_p): Declare new function.
5596         * m2-lang.c (m2_language_defn): Initialise new field.
5597         * objc-lang.c (objc_language_defn): Initialise new field.
5598         * opencl-lang.c (opencl_language_defn): Initialise new field.
5599         * p-lang.c (pascal_is_string_type_p): New function.
5600         (pascal_language_defn): Initialise new field.
5601         * rust-lang.c (rust_is_string_type_p): New function.
5602         (rust_language_defn): Initialise new field.
5603
5604 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5605
5606         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5607         New field.
5608         * ada-lang.c (ada_language_defn): Initialise new field.
5609         * c-lang.c (c_language_defn): Likewise.
5610         (cplus_language_defn): Likewise.
5611         (asm_language_defn): Likewise.
5612         (minimal_language_defn): Likewise.
5613         * d-lang.c (d_language_defn): Likewise.
5614         * f-lang.c (f_language_defn): Likewise.
5615         * go-lang.c (go_language_defn): Likewise.
5616         * language.c (unknown_language_defn): Likewise.
5617         (auto_language_defn): Likewise.
5618         * m2-lang.c (m2_language_defn): Likewise.
5619         * objc-lang.c (objc_language_defn): Likewise.
5620         * opencl-lang.c (opencl_language_defn): Likewise.
5621         * p-lang.c (pascal_language_defn): Likewise.
5622         * rust-lang.c (rust_language_defn): Likewise.
5623
5624 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5625
5626         * ada-lang.c (ada_is_character_type): Change return type to bool.
5627         (ada_is_string_type): Likewise.
5628         * ada-lang.h (ada_is_character_type): Update declaration
5629         (ada_is_string_type): Likewise.
5630
5631 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5632
5633         Support style in 'frame|thread apply'
5634
5635         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5636         * record.c (record_start, record_stop): Update callers of
5637         execute_command_to_string with false.
5638         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5639         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5640         methods.
5641         (class string_file): New constructor with term_out parameter.
5642         Override methods term_out and can_emit_style_escape.  New member
5643         term_out.
5644         (class stdio_file): Override can_emit_style_escape.
5645         (class tee_file): Override term_out and can_emit_style_escape.
5646         * utils.h (can_emit_style_escape): Remove.
5647         * utils.c (can_emit_style_escape): Likewise.
5648         Update all callers of can_emit_style_escape (SOMESTREAM) to
5649         SOMESTREAM->can_emit_style_escape.
5650         * source-cache.c (source_cache::get_source_lines): Likewise.
5651         * stack.c (frame_apply_command_count): Call execute_command_to_string
5652         passing the term_out characteristic of the current gdb_stdout.
5653         * thread.c (thr_try_catch_cmd): Likewise.
5654         * top.c (execute_command_to_string): pass term_out parameter
5655         to construct the string_file for the command output.
5656         * ui-file.c (term_cli_styling): New function (most code moved
5657         from utils.c can_emit_style_escape).
5658         (string_file::string_file, string_file::can_emit_style_escape,
5659         stdio_file::can_emit_style_escape, tee_file::term_out,
5660         tee_file::can_emit_style_escape): New functions.
5661
5662 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5663
5664         * NEWS: Mention the new set|show may-call-functions.
5665         * infcall.c (may_call_functions_p): New variable.
5666         (show_may_call_functions_p): New function.
5667         (call_function_by_hand_dummy): Throws an error if not
5668         may-call-functions.
5669         (_initialize_infcall): Call add_setshow_boolean_cmd for
5670         may-call-functions.
5671
5672 2019-04-25  Keith Seitz  <keiths@redhat.com>
5673
5674         PR c++/24367
5675         * cp-support.c (inspect_type): Don't attempt substitutions
5676         of symbol with the same name.
5677
5678 2019-04-25  Tom Tromey  <tromey@adacore.com>
5679
5680         PR gdb/24475:
5681         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5682         static.
5683
5684 2019-04-25  Tom Tromey  <tromey@adacore.com>
5685
5686         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5687         rvalue reference.
5688         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5689         (gdb_xml_parser::parse): Use std::move.
5690         * python/python-internal.h (gdbpy_convert_exception): Take a const
5691         reference.
5692         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5693         std::move.
5694         * python/py-utils.c (gdbpy_convert_exception): Take a const
5695         reference.
5696         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5697         Use std::move.
5698         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5699         Use std::move.
5700         * mi/mi-main.c (mi_print_exception): Take a const reference.
5701         * main.c (handle_command_errors): Take a const reference.
5702         * linespec.c (parse_linespec): Use std::move.
5703         * infcall.c (run_inferior_call): Use std::move.
5704         (call_function_by_hand_dummy): Use std::move.
5705         * exec.c (try_open_exec_file): Use std::move.
5706         * exceptions.h (exception_print, exception_fprintf)
5707         (exception_print_same): Update.
5708         * exceptions.c (print_exception, exception_print)
5709         (exception_fprintf, exception_print_same): Change parameters to
5710         const reference.
5711         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5712         * common/new-op.c: Use std::move.
5713         * common/common-exceptions.h (struct gdb_exception): Add move
5714         constructor.
5715         (struct gdb_exception_error, struct gdb_exception_quit, struct
5716         gdb_quit_bad_alloc): Change constructor to move constructor.
5717         (throw_exception): Change parameter to rvalue reference.
5718         * common/common-exceptions.c (throw_exception): Take rvalue
5719         reference.
5720         * cli/cli-interp.c (safe_execute_command): Use std::move.
5721         * breakpoint.c (insert_bp_location, location_to_sals): Use
5722         std::move.
5723
5724 2019-04-25  Tom Tromey  <tromey@adacore.com>
5725
5726         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5727         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5728         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5729         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5730         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5731         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5732         guile/scm-value.c: Use unpack.
5733         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5734         gdbscm_gdb_exception.
5735         (gdbscm_throw_gdb_exception): Likewise.
5736         (struct gdbscm_gdb_exception): New.
5737         (unpack): New function.
5738         (gdbscm_wrap): Use unpack.
5739
5740 2019-04-25  Tom Tromey  <tromey@adacore.com>
5741
5742         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5743         (gdb_rl_callback_handler): Use std::move.
5744         * common/common-exceptions.h (struct gdb_exception): Add move
5745         assignment operator.
5746         (throw_exception_sjlj): Change "exception" to const reference.
5747         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5748         (throw_exception_sjlj): Change "exception" to const reference.
5749
5750 2019-04-25  Tom Tromey  <tromey@adacore.com>
5751
5752         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5753         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5754         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5755         Update.
5756         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5757         Update.
5758         * mi/mi-interp.c (mi_interp::exec): Update.
5759         * linespec.c (parse_linespec): Update.
5760         * infcall.c (run_inferior_call): Update.
5761         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5762         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5763         (gdbscm_lookup_global_symbol): Update.
5764         * guile/scm-param.c (gdbscm_parameter_value): Update.
5765         * guile/scm-frame.c (gdbscm_frame_read_register)
5766         (gdbscm_frame_read_var): Update.
5767         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5768         * exec.c (try_open_exec_file): Update.
5769         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5770         (gdb_rl_callback_handler): Update.
5771         * common/common-exceptions.h (exception_none): Don't declare.
5772         * common/common-exceptions.c (exception_none): Don't define.
5773         (struct catcher) <exception>: Update.
5774         * cli/cli-interp.c (safe_execute_command): Update.
5775         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5776
5777 2019-04-25  Ali Tamur  <tamur@google.com>
5778
5779         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5780         (read_attribute_value): Likewise.
5781         (dwarf2_read_addr_index): Update comment.
5782         (read_str_index): Add DW_FORM_strx.
5783         (dwarf2_string_attr): Likewise.
5784         (dwarf2_const_value_attr): Likewise.
5785         (dump_die_shallow): Likewise.
5786         (dwarf2_fetch_constant_bytes): Likewise.
5787         (skip_form_bytes): Likewise.
5788         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5789
5790 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5791
5792         PR corefiles/11608
5793         PR corefiles/18187
5794         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5795         OFFSET.  Verify if current mapping contains an ELF header.
5796         (linux_find_memory_regions_full): Adjust call to
5797         dump_mapping_p.
5798
5799 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5800             Kang Li <kanglictf@gmail.com>
5801
5802         PR gdb/21600
5803
5804         * dwarf2-frame.c (read_initial_length): Be consistent about using
5805         unsigned representation of length.
5806         (decode_frame_entry_1): Likewise.  Check for wraparound of
5807         end pointer as well as buffer overflow.
5808
5809 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5810
5811         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5812         "vq".
5813
5814 2019-04-24  Tom Tromey  <tromey@adacore.com>
5815
5816         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5817
5818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * s12z-tdep.c (s12z_unwind_pc): Delete.
5821         (s12z_unwind_sp): Delete.
5822         (s12z_gdbarch_init): Don't register deleted functions with
5823         gdbarch.
5824
5825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5826
5827         * rl78-tdep.c (rl78_unwind_sp): Delete.
5828         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5829
5830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5831
5832         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5833         (xstormy16_unwind_pc): Delete.
5834         (xstormy16_dummy_id): Delete.
5835         (xstormy16_gdbarch_init): Don't register deleted functions with
5836         gdbarch.
5837
5838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * vax-tdep.c (vax_unwind_pc): Delete.
5841         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5842
5843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5844
5845         * v850-tdep.c (v850_unwind_sp): Delete.
5846         (v850_unwind_pc): Delete.
5847         (v850_dummy_id): Delete.
5848         (v850_gdbarch_init): Don't register deleted functions with
5849         gdbarch.
5850
5851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5852
5853         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5854         (tilegx_unwind_pc): Delete.
5855         (tilegx_unwind_dummy_id): Delete.
5856         (tilegx_gdbarch_init): Don't register deleted functions with
5857         gdbarch.
5858
5859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5860
5861         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5862         (tic6x_dummy_id): Delete.
5863         (tic6x_gdbarch_init): Don't register deleted functions with
5864         gdbarch.
5865
5866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * sparc-tdep.c (sparc_unwind_pc): Delete.
5869         (sparc32_gdbarch_init): Don't register deleted function with
5870         gdbarch.
5871
5872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * sh-tdep.c (sh_unwind_sp): Delete.
5875         (sh_unwind_pc): Delete.
5876         (sh_dummy_id): Delete.
5877         (sh_gdbarch_init): Don't register deleted functions with
5878         gdbarch.
5879
5880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * score-tdep.c (score_unwind_sp): Delete.
5883         (score_unwind_pc): Delete.
5884         (score_dummy_id): Delete.
5885         (score_gdbarch_init): Don't register deleted functions with
5886         gdbarch.
5887
5888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * rx-tdep.c (rx_unwind_pc): Delete.
5891         (rx_unwind_sp): Delete.
5892         (rx_dummy_id): Delete.
5893         (rx_gdbarch_init): Don't register deleted functions with
5894         gdbarch.  Update comment.
5895
5896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5897
5898         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5899         (rs6000_dummy_id): Delete.
5900         (rs6000_gdbarch_init): Don't register deleted functions with
5901         gdbarch.
5902
5903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * or1k-tdep.c (or1k_dummy_id): Delete.
5906         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5907
5908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * nios2-tdep.c (nios2_dummy_id): Delete.
5911         (nios2_unwind_sp): Delete.
5912         (nios2_gdbarch_init): Don't register deleted functions with
5913         gdbarch.
5914
5915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5916
5917         * nds32-tdep.c (nds32_dummy_id): Delete.
5918         (nds32_unwind_pc): Delete.
5919         (nds32_unwind_sp): Delete.
5920         (nds32_gdbarch_init): Don't register deleted functions with
5921         gdbarch.
5922
5923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5924
5925         * msp430-tdep.c (msp430_unwind_pc): Delete.
5926         (msp430_unwind_sp): Delete.
5927         (msp430_dummy_id): Delete.
5928         (msp430_gdbarch_init): Don't register deleted functions with
5929         gdbarch.
5930
5931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * moxie-tdep.c (moxie_unwind_sp): Delete.
5934         (moxie_unwind_pc): Delete.
5935         (moxie_dummy_id): Delete.
5936         (moxie_gdbarch_init): Don't register deleted functions with
5937         gdbarch.
5938
5939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5942         (mn10300_unwind_pc): Delete.
5943         (mn10300_unwind_sp): Delete.
5944         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5945         mn10300_unwind_sp.
5946         (mn10300_frame_unwind_init): Don't register deleted functions with
5947         gdbarch.
5948
5949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5950
5951         * mep-tdep.c (mep_unwind_pc): Delete.
5952         (mep_unwind_sp): Delete.
5953         (mep_dummy_id): Delete.
5954         (mep_gdbarch_init): Don't register deleted functions with
5955         gdbarch.
5956
5957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5958
5959         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5960         (m68hc11_unwind_sp): Delete.
5961         (m68hc11_gdbarch_init): Don't register deleted functions with
5962         gdbarch.
5963
5964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * m32r-tdep.c (m32r_unwind_sp): Delete.
5967         (m32r_unwind_pc): Delete.
5968         (m32r_dummy_id): Delete.
5969         (m32r_gdbarch_init): Don't register deleted functions with
5970         gdbarch.
5971
5972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * m32c-tdep.c (m32c_unwind_pc): Delete.
5975         (m32c_unwind_sp): Delete.
5976         (m32c_dummy_id): Delete.
5977         (m32c_gdbarch_init): Don't register deleted functions with
5978         gdbarch.
5979
5980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5981
5982         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5983         (lm32_unwind_pc): Delete.
5984         (lm32_dummy_id): Delete.
5985         (lm32_gdbarch_init): Don't register deleted functions with
5986         gdbarch.
5987
5988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5989
5990         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5991         (iq2000_unwind_pc): Delete.
5992         (iq2000_dummy_id): Delete.
5993         (iq2000_gdbarch_init): Don't register deleted functions with
5994         gdbarch.
5995
5996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * nds32-tdep.c (nds32_type_align): Delete.
5999         (nds32_push_dummy_call): Use type_align instead.
6000
6001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6002
6003         * arm-tdep.c (arm_type_align): Only handle vector override case.
6004         (arm_push_dummy_call): Use type_align.
6005         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6006
6007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6010         case.
6011         (pass_on_stack): Use type_align.
6012         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6013         function.
6014
6015 2019-04-23  Tom Tromey  <tromey@adacore.com>
6016
6017         * dwarf2read.c (line_header::file_name_at): Remove unused
6018         overload.
6019
6020 2019-04-23  Tom de Vries  <tdevries@suse.de>
6021
6022         PR gdb/24438
6023         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6024         invocation.
6025
6026
6027 2019-03-27  Ali Tamur  <tamur@google.com>
6028
6029         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6030         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6031         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6032         (dwarf_expr_context::get_addr_index): Likewise
6033         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6034         (symbol_needs_eval_context::get_addr_index): Likewise
6035         (disassemble_dwarf_expression): Add DW_OP_addrx
6036         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6037         (read_cutu_die_from_dwo): Update comment
6038         (skip_one_die): Add DW_FORM_addrx
6039         (read_attribute_value): Likewise
6040         (var_decode_location): Add DW_OP_addrx
6041         (dwarf2_const_value_attr): Add DW_FORM_addrx
6042         (dump_die_shallow): Likewise
6043         (dwarf2_fetch_constant_bytes): Likewise
6044         (decode_locdesc): Add DW_OP_addrx
6045         (skip_form_bytes): Add DW_FORM_addrx
6046
6047 2019-04-22  Ali Tamur  <tamur@google.com>
6048
6049         * MAINTAINERS (Write After Approval): Add self.
6050
6051 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6052
6053         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6054         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6055         (open_symbol_file_object): Likewise.
6056         (svr4_default_sos): Add info parameter.
6057         (svr4_read_so_list): Likewise.
6058         (svr4_current_sos_direct): Adjust functions calls to pass down
6059         info.
6060         (svr4_current_sos_1): Add info parameter.
6061         (svr4_current_sos): Call get_svr4_info, pass info down to
6062         svr4_current_sos_1.
6063         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6064         get_svr4_info.
6065         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6066         get_svr4_info.
6067         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6068         to get_svr4_info.
6069         (probes_table_remove_objfile_probes): Likewise.
6070         (register_solib_event_probe): Add info parameter.
6071         (solist_update_incremental): Pass info parameter down to
6072         svr4_read_so_list.
6073         (disable_probes_interface): Add info parameter.
6074         (svr4_handle_solib_event): Pass current_program_space to
6075         get_svr4_info.  Adjust disable_probes_interface cleanup.
6076         (svr4_create_probe_breakpoints): Add info parameter, pass it
6077         down to register_solib_event_probe.
6078         (svr4_create_solib_event_breakpoints): Add info parameter,
6079         pass it down to svr4_create_probe_breakpoints.
6080         (enable_break): Pass info down to
6081         svr4_create_solib_event_breakpoints.
6082         (svr4_solib_create_inferior_hook): Pass current_program_space to
6083         get_svr4_info.
6084         (svr4_clear_solib): Likewise.
6085
6086 2019-04-22  Pedro Alves  <palves@redhat.com>
6087
6088         * solib-svr4.c (svr4_free_objfile_observer): New.
6089         (probe_and_action::objfile): New field.
6090         (probes_table_htab_remove_objfile_probes)
6091         (probes_table_remove_objfile_probes): New functions.
6092         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6093         in the new probe_and_action.  Don't store the probe in 'lookup'.
6094         (svr4_create_probe_breakpoints): Pass objfile to
6095         register_solib_event_probe.
6096         (_initialize_svr4_solib): Register a free_objfile observer.
6097
6098 2019-04-19  Tom Tromey  <tom@tromey.com>
6099
6100         * common/queue.h: Remove.
6101
6102 2019-04-19  Tom Tromey  <tom@tromey.com>
6103
6104         * event-loop.c: Don't include "common/queue.h".
6105
6106 2019-04-19  Tom Tromey  <tom@tromey.com>
6107
6108         * remote.c (remote_target): Use delete.
6109         * remote-notif.h: Include <list>, not "common/queue.h".
6110         (notif_client_p): Remove typedef.
6111         (remote_notif_state): Add constructor, destructor, initializer.
6112         <notif_queue>: Now a std::list.
6113         (remote_notif_state_xfree): Don't declare.
6114         * remote-notif.c (remote_notif_process, handle_notification)
6115         (remote_notif_state_allocate): Update.
6116         (~remote_notif_state): Rename from remote_notif_state_xfree.
6117
6118 2019-04-19  Tom Tromey  <tom@tromey.com>
6119
6120         * symfile.c (reread_symbols): Update.
6121         * objfiles.c (objfile_register_static_link)
6122         (objfile_lookup_static_link): Update
6123         (~objfile) Don't delete static_links.
6124         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6125
6126 2019-04-19  Tom Tromey  <tom@tromey.com>
6127
6128         * type-stack.h (struct type_stack) <insert>: Constify string.
6129         * type-stack.c (type_stack::insert): Constify string.
6130         * gdbtypes.h (lookup_template_type): Update.
6131         (address_space_name_to_int): Update.
6132         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6133         const.
6134         (lookup_template_type): Make name const.
6135         * c-exp.y: Update rules.
6136         (lex_one_token, classify_name, classify_inner_name)
6137         (c_print_token): Update.
6138         * p-exp.y: Update rules.
6139         (yylex): Update.
6140         * f-exp.y: Update rules.
6141         (yylex): Update.
6142         * d-exp.y: Update rules.
6143         (lex_one_token, classify_name, classify_inner_name): Update.
6144         * parse.c (write_dollar_variable, copy_name): Return std::string.
6145         * parser-defs.h (copy_name): Change return type.
6146         * m2-exp.y: Update rules.
6147         (yylex): Update.
6148         * go-exp.y (lex_one_token): Update.
6149         Update rules.
6150         (classify_unsafe_function, classify_packaged_name)
6151         (classify_name, yylex): Update.
6152
6153 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6154
6155         * configure.ac: add --enable-source-highlight switch.
6156         * configure: Regenerate.
6157         * top.c (print_gdb_version): plumb --enable-source-highlight
6158         status to "show configuration".
6159
6160 2019-04-19  Tom Tromey  <tromey@adacore.com>
6161
6162         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6163         Check ADA_TYPE_P.
6164         (empty_record, ada_template_to_fixed_record_type_1)
6165         (template_to_static_fixed_type)
6166         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6167         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6168         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6169         macros.
6170
6171 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6172
6173         PR symtab/24423:
6174         * source.c (print_source_lines_base): Advance "iter" when a
6175         control character is seen.
6176
6177 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6178
6179         * inferior.h (struct infcall_suspend_state_deleter):
6180         Catch exception in destructor to avoid crash.
6181
6182 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6183
6184         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6185         close to the add_com "shell".
6186
6187 2019-04-18  Tom Tromey  <tromey@adacore.com>
6188
6189         * process-stratum-target.h (class process_stratum_target)
6190         <stratum>: Add "final".
6191
6192 2019-04-17  Tom Tromey  <tromey@adacore.com>
6193
6194         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6195         against nullptr before use.
6196
6197 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6198
6199         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6200
6201 2019-04-17  Jim Wilson  <jimw@sifive.com>
6202             Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6205         code read might fail, assume 4-byte breakpoint in that case.
6206
6207 2019-04-15  Leszek Swirski  <leszeks@google.com>
6208
6209         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6210         rather than a hand-rolled POD check when checking for forced MEMORY
6211         classification.
6212
6213 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6214
6215         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6216         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6217         function.
6218         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6219         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6220         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6221         declaration.
6222
6223 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6224
6225         * aarch64-linux-nat.c
6226         (aarch64_linux_nat_target::thread_architecture): Add override.
6227         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6228         each VQ.
6229
6230 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6231
6232         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6233
6234 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6235
6236         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6237         target types of size 96-bits, add some additional comments, and
6238         check that the builtin type we found was the correct size.
6239
6240 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6241
6242         * utils.c (prompt_for_continue): Don't restore the styling at the
6243         end, as applied_style has the wrong value.  This fixes styling in
6244         long lists of file names that are interrupted by the "Continue?"
6245         prompt.
6246
6247 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6250         * c-lang.c (c_language_defn): Likewise.
6251         (cplus_language_defn): Likewise.
6252         (asm_language_defn): Likewise.
6253         (minimal_language_defn): Likewise.
6254         * d-lang.c (d_language_defn): Likewise.
6255         * f-lang.c (f_language_defn): Likewise.
6256         * go-lang.c (go_language_defn): Likewise.
6257         * language.c (unknown_language_defn): Likewise.
6258         (auto_language_defn): Likewise.
6259         * language.h (struct language_defn): Remove la_magic field.
6260         (LANG_MAGIC): Delete.
6261         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6262         * objc-lang.c (objc_language_defn): Likewise.
6263         * opencl-lang.c (opencl_language_defn): Likewise.
6264         * p-lang.c (pascal_language_defn): Likewise.
6265         * rust-lang.c (rust_language_defn): Likewise.
6266
6267 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * riscv-tdep.c (riscv_type_align): New function.
6270         (riscv_type_alignment): Delete.
6271         (riscv_arg_location): Use 'type_align'.
6272         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6273
6274 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * gdbtypes.c (type_align): A struct with no non-static fields also
6277         has alignment of 1.
6278
6279 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6282         component to 0.
6283         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6284         member.
6285         (riscv_struct_info::analyse): New implementation using new
6286         analyse_inner member function.
6287         (riscv_struct_info::field_offset): New member function.
6288         (riscv_struct_info::m_offsets): New member variable.
6289         (riscv_struct_info::analyse_inner): New private member function,
6290         takes the old implementation of riscv_struct_info::analyse but
6291         extended to track field offsets.
6292         (riscv_call_arg_struct): Update the struct folding special cases
6293         to handle cases where empty C++ structs, which are non-zero
6294         length, are found.
6295         (riscv_arg_location): Initialise the length of each location, a
6296         non-zero length now indicates the location is in use.
6297         (riscv_push_dummy_call): Allow for the first location having a
6298         non-zero offset when setting up arguments.
6299         (riscv_return_value): Likewise, but for return values.
6300
6301 2019-04-11  Tom Tromey  <tromey@adacore.com>
6302
6303         * utils.c (internal_vproblem): Make "msg" const.
6304
6305 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6306
6307         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6308         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6309         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6310         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6311
6312 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6313
6314         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6315         function.
6316         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6317         of amd64_collect_native_gregset.
6318         (amd64_linux_nat_target::store_registers): Likewise.
6319
6320 2019-04-10  Tom Tromey  <tom@tromey.com>
6321
6322         * symtab.c (lookup_global_symbol_from_objfile)
6323         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6324         * objfiles.h (class separate_debug_iterator): New.
6325         (class separate_debug_range): New.
6326         (struct objfile) <separate_debug_objfiles>: New method.
6327         (objfile_separate_debug_iterate): Don't declare.
6328         * objfiles.c (separate_debug_iterator::operator++): Rename from
6329         objfile_separate_debug_iterate.
6330         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6331         iterator.
6332         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6333         iterator.
6334
6335 2019-04-10  Tom Tromey  <tom@tromey.com>
6336
6337         * symfile.c (reread_symbols): Remove old comment.
6338         * objfiles.c (free_all_objfiles): Fix a typo.
6339
6340 2019-04-10  Tom Tromey  <tom@tromey.com>
6341
6342         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6343         * minsyms.c (lookup_minimal_symbol): Use foreach.
6344         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6345         (lookup_minimal_symbol_solib_trampoline): Likewise.
6346         * symfile.c (reread_symbols): Use foreach.
6347
6348 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6349             Tom Tromey  <tromey@adacore.com>
6350
6351         PR rust/24414:
6352         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6353         (rust_lex_int_test): Change "value" to be LONGEST.
6354         (rust_lex_tests): Add test for long integer literal.
6355
6356 2019-04-09  Tom Tromey  <tromey@adacore.com>
6357
6358         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6359         to bool.
6360         (extended_remote_target::attach): Update.
6361         (remote_target::remote_notice_new_inferior): Update.
6362         (remote_target::add_current_inferior_and_thread): Update.
6363         * inferior.c (exit_inferior_1): Use "false".
6364         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6365
6366 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6367
6368         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6369         the "start" command.
6370
6371 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6372
6373         * python/py-inferior.c (infpy_thread_from_thread_handle):
6374         Adjust comments to reflect renaming of thread_from_thread_handle
6375         to thread_from_handle.  Adjust keywords.  Fix type error message.
6376         (inferior_object_methods): Add thread_from_handle.  Retain
6377         thread_from_thread_handle, but mark it as deprecated.
6378
6379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6380
6381         * gdbthread.h (find_thread_by_handle): Revise declaration.
6382         * thread.c (find_thread_by_handle): Likewise.  Adjust
6383         implementation too.
6384         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6385         support for buffer objects as handles.
6386
6387 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6388
6389         * python/py-infthread.c (thpy_thread_handle): New function.
6390         (thread_object_methods): Register thpy_thread_handle.
6391
6392 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6393
6394         * gdbthread.h (thread_to_thread_handle): Declare.
6395         * thread.c (gdbtypes.h): Include.
6396         (thread_to_thread_handle): New function.
6397
6398         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6399         (target_thread_info_to_thread_handle): Declare.
6400         * target.c (target_thread_info_to_thread_handle): New function.
6401         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6402         * target-delegates.c: Regenerate.
6403
6404         * linux-thread-db.c (class thread_db_target): Add method
6405         thread_info_to_thread_handle.
6406         (thread_db_target::thread_info_to_thread_handle): Define.
6407         * remote.c (class remote_target): Add new method
6408         thread_info_to_thread_handle.
6409         (remote_target::thread_info_to_thread_handle): Define.
6410
6411 2019-04-08  Pedro Alves  <palves@redhat.com>
6412
6413         * common/common-exceptions.c (throw_exception): Don't create
6414         named object to throw; throw directly.
6415         (throw_it): Likewise.  Don't initialize gdb_exception::message
6416         here, with new; pass FMT and AP to the ctor instead.
6417         * common/common-exceptions.h: Include <string>.
6418         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6419         const char *, va_list)): New ctor.  Use std::make_shared.
6420         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6421         errors)): Delete.
6422         (gdb_exception_error::gdb_exception_error(enum errors, const char
6423         *, va_list)): New.
6424         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6425         Add assertion.
6426         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6427         errors)): Delete.
6428         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6429         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6430         Add assertion.
6431
6432 2019-04-08  Tom Tromey  <tom@tromey.com>
6433
6434         * valops.c (value_rtti_indirect_type): Replace throw_exception
6435         with throw.
6436         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6437         with throw.
6438         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6439         throw.
6440         * target.c (target_translate_tls_address): Replace throw_exception
6441         with throw.
6442         * stack.c (frame_apply_command_count): Replace throw_exception
6443         with throw.
6444         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6445         throw.
6446         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6447         with throw.
6448         * rs6000-tdep.c (rs6000_frame_cache)
6449         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6450         * remote.c: Replace throw_exception with throw.
6451         * record-full.c (record_full_message, record_full_wait_1)
6452         (record_full_restore): Replace throw_exception with throw.
6453         * record-btrace.c:
6454         (get_thread_current_frame_id, record_btrace_start_replaying)
6455         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6456         (cmd_record_btrace_start): Replace throw_exception with throw.
6457         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6458         throw.
6459         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6460         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6461         * linespec.c:
6462         (find_linespec_symbols): Replace throw_exception with throw.
6463         * infrun.c (displaced_step_prepare, resume): Replace
6464         throw_exception with throw.
6465         * infcmd.c (post_create_inferior): Replace throw_exception with
6466         throw.
6467         * inf-loop.c (inferior_event_handler): Replace throw_exception
6468         with throw.
6469         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6470         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6471         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6472         (get_prev_frame_always, get_frame_pc_if_available)
6473         (get_frame_address_in_block_if_available, get_frame_language):
6474         Replace throw_exception with throw.
6475         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6476         throw_exception with throw.
6477         * eval.c (fetch_subexp_value, evaluate_var_value)
6478         (evaluate_funcall, evaluate_subexp_standard): Replace
6479         throw_exception with throw.
6480         * dwarf2loc.c (call_site_find_chain)
6481         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6482         Replace throw_exception with throw.
6483         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6484         with throw.
6485         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6486         throw.
6487         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6488         * completer.c (complete_line_internal): Replace throw_exception
6489         with throw.
6490         * compile/compile-object-run.c (compile_object_run): Replace
6491         throw_exception with throw.
6492         * cli/cli-script.c (process_next_line): Replace throw_exception
6493         with throw.
6494         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6495         (btrace_enable, btrace_maint_update_pt_packets): Replace
6496         throw_exception with throw.
6497         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6498         throw_exception with throw.
6499         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6500         throw_exception with throw.
6501         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6502         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6503         * aarch64-tdep.c (aarch64_make_prologue_cache)
6504         (aarch64_make_stub_cache): Replace throw_exception with throw.
6505
6506 2019-04-08  Tom Tromey  <tom@tromey.com>
6507
6508         * common/common-exceptions.c (throw_exception): Rename from
6509         throw_exception_cxx.  Remove old copy.  Make argument const.
6510         (throw_it): Create and throw exception objects directly.
6511         * common/common-exceptions.h (throw_exception): Make argument
6512         const.
6513         (struct gdb_exception_error): Add constructor.
6514         (struct gdb_exception_quit): Add constructor.
6515
6516 2019-04-08  Tom Tromey  <tom@tromey.com>
6517
6518         * common/common-exceptions.h (exception_rethrow): Don't declare.
6519         (TRY_SJLJ): Update comment.
6520         (TRY, CATCH, END_CATCH): Remove.
6521         * common/common-exceptions.c (exception_rethrow): Remove.
6522
6523 2019-04-08  Tom Tromey  <tom@tromey.com>
6524
6525         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6526         Remove.
6527         (gdb_exception_error): Rename from
6528         gdb_exception_RETURN_MASK_ERROR.
6529         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6530         (gdb_quit_bad_alloc): Update.
6531         * aarch64-tdep.c: Update.
6532         * ada-lang.c: Update.
6533         * ada-typeprint.c: Update.
6534         * ada-valprint.c: Update.
6535         * amd64-tdep.c: Update.
6536         * arch-utils.c: Update.
6537         * break-catch-throw.c: Update.
6538         * breakpoint.c: Update.
6539         * btrace.c: Update.
6540         * c-varobj.c: Update.
6541         * cli/cli-cmds.c: Update.
6542         * cli/cli-interp.c: Update.
6543         * cli/cli-script.c: Update.
6544         * common/common-exceptions.c: Update.
6545         * common/new-op.c: Update.
6546         * common/selftest.c: Update.
6547         * compile/compile-c-symbols.c: Update.
6548         * compile/compile-cplus-symbols.c: Update.
6549         * compile/compile-object-load.c: Update.
6550         * compile/compile-object-run.c: Update.
6551         * completer.c: Update.
6552         * corelow.c: Update.
6553         * cp-abi.c: Update.
6554         * cp-support.c: Update.
6555         * cp-valprint.c: Update.
6556         * darwin-nat.c: Update.
6557         * disasm-selftests.c: Update.
6558         * dtrace-probe.c: Update.
6559         * dwarf-index-cache.c: Update.
6560         * dwarf-index-write.c: Update.
6561         * dwarf2-frame-tailcall.c: Update.
6562         * dwarf2-frame.c: Update.
6563         * dwarf2loc.c: Update.
6564         * dwarf2read.c: Update.
6565         * eval.c: Update.
6566         * event-loop.c: Update.
6567         * event-top.c: Update.
6568         * exec.c: Update.
6569         * f-valprint.c: Update.
6570         * fbsd-tdep.c: Update.
6571         * frame-unwind.c: Update.
6572         * frame.c: Update.
6573         * gdbtypes.c: Update.
6574         * gnu-v3-abi.c: Update.
6575         * guile/guile-internal.h: Update.
6576         * guile/scm-block.c: Update.
6577         * guile/scm-breakpoint.c: Update.
6578         * guile/scm-cmd.c: Update.
6579         * guile/scm-disasm.c: Update.
6580         * guile/scm-frame.c: Update.
6581         * guile/scm-lazy-string.c: Update.
6582         * guile/scm-math.c: Update.
6583         * guile/scm-param.c: Update.
6584         * guile/scm-ports.c: Update.
6585         * guile/scm-pretty-print.c: Update.
6586         * guile/scm-symbol.c: Update.
6587         * guile/scm-symtab.c: Update.
6588         * guile/scm-type.c: Update.
6589         * guile/scm-value.c: Update.
6590         * i386-linux-tdep.c: Update.
6591         * i386-tdep.c: Update.
6592         * inf-loop.c: Update.
6593         * infcall.c: Update.
6594         * infcmd.c: Update.
6595         * infrun.c: Update.
6596         * jit.c: Update.
6597         * language.c: Update.
6598         * linespec.c: Update.
6599         * linux-fork.c: Update.
6600         * linux-nat.c: Update.
6601         * linux-tdep.c: Update.
6602         * linux-thread-db.c: Update.
6603         * main.c: Update.
6604         * mi/mi-cmd-break.c: Update.
6605         * mi/mi-cmd-stack.c: Update.
6606         * mi/mi-interp.c: Update.
6607         * mi/mi-main.c: Update.
6608         * objc-lang.c: Update.
6609         * p-valprint.c: Update.
6610         * parse.c: Update.
6611         * ppc-linux-tdep.c: Update.
6612         * printcmd.c: Update.
6613         * python/py-arch.c: Update.
6614         * python/py-breakpoint.c: Update.
6615         * python/py-cmd.c: Update.
6616         * python/py-finishbreakpoint.c: Update.
6617         * python/py-frame.c: Update.
6618         * python/py-framefilter.c: Update.
6619         * python/py-gdb-readline.c: Update.
6620         * python/py-inferior.c: Update.
6621         * python/py-infthread.c: Update.
6622         * python/py-lazy-string.c: Update.
6623         * python/py-linetable.c: Update.
6624         * python/py-objfile.c: Update.
6625         * python/py-param.c: Update.
6626         * python/py-prettyprint.c: Update.
6627         * python/py-progspace.c: Update.
6628         * python/py-record-btrace.c: Update.
6629         * python/py-record.c: Update.
6630         * python/py-symbol.c: Update.
6631         * python/py-type.c: Update.
6632         * python/py-unwind.c: Update.
6633         * python/py-utils.c: Update.
6634         * python/py-value.c: Update.
6635         * python/python.c: Update.
6636         * record-btrace.c: Update.
6637         * record-full.c: Update.
6638         * remote-fileio.c: Update.
6639         * remote.c: Update.
6640         * riscv-tdep.c: Update.
6641         * rs6000-aix-tdep.c: Update.
6642         * rs6000-tdep.c: Update.
6643         * rust-exp.y: Update.
6644         * rust-lang.c: Update.
6645         * s390-tdep.c: Update.
6646         * selftest-arch.c: Update.
6647         * solib-dsbt.c: Update.
6648         * solib-frv.c: Update.
6649         * solib-spu.c: Update.
6650         * solib-svr4.c: Update.
6651         * solib.c: Update.
6652         * sparc64-linux-tdep.c: Update.
6653         * stack.c: Update.
6654         * symfile-mem.c: Update.
6655         * symmisc.c: Update.
6656         * target.c: Update.
6657         * thread.c: Update.
6658         * top.c: Update.
6659         * tracefile-tfile.c: Update.
6660         * tui/tui.c: Update.
6661         * typeprint.c: Update.
6662         * unittests/cli-utils-selftests.c: Update.
6663         * unittests/parse-connection-spec-selftests.c: Update.
6664         * valops.c: Update.
6665         * valprint.c: Update.
6666         * value.c: Update.
6667         * varobj.c: Update.
6668         * windows-nat.c: Update.
6669         * x86-linux-nat.c: Update.
6670         * xml-support.c: Update.
6671
6672 2019-04-08  Tom Tromey  <tom@tromey.com>
6673
6674         * xml-support.c: Use C++ exception handling.
6675         * x86-linux-nat.c: Use C++ exception handling.
6676         * windows-nat.c: Use C++ exception handling.
6677         * varobj.c: Use C++ exception handling.
6678         * value.c: Use C++ exception handling.
6679         * valprint.c: Use C++ exception handling.
6680         * valops.c: Use C++ exception handling.
6681         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6682         handling.
6683         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6684         * typeprint.c: Use C++ exception handling.
6685         * tui/tui.c: Use C++ exception handling.
6686         * tracefile-tfile.c: Use C++ exception handling.
6687         * top.c: Use C++ exception handling.
6688         * thread.c: Use C++ exception handling.
6689         * target.c: Use C++ exception handling.
6690         * symmisc.c: Use C++ exception handling.
6691         * symfile-mem.c: Use C++ exception handling.
6692         * stack.c: Use C++ exception handling.
6693         * sparc64-linux-tdep.c: Use C++ exception handling.
6694         * solib.c: Use C++ exception handling.
6695         * solib-svr4.c: Use C++ exception handling.
6696         * solib-spu.c: Use C++ exception handling.
6697         * solib-frv.c: Use C++ exception handling.
6698         * solib-dsbt.c: Use C++ exception handling.
6699         * selftest-arch.c: Use C++ exception handling.
6700         * s390-tdep.c: Use C++ exception handling.
6701         * rust-lang.c: Use C++ exception handling.
6702         * rust-exp.y: Use C++ exception handling.
6703         * rs6000-tdep.c: Use C++ exception handling.
6704         * rs6000-aix-tdep.c: Use C++ exception handling.
6705         * riscv-tdep.c: Use C++ exception handling.
6706         * remote.c: Use C++ exception handling.
6707         * remote-fileio.c: Use C++ exception handling.
6708         * record-full.c: Use C++ exception handling.
6709         * record-btrace.c: Use C++ exception handling.
6710         * python/python.c: Use C++ exception handling.
6711         * python/py-value.c: Use C++ exception handling.
6712         * python/py-utils.c: Use C++ exception handling.
6713         * python/py-unwind.c: Use C++ exception handling.
6714         * python/py-type.c: Use C++ exception handling.
6715         * python/py-symbol.c: Use C++ exception handling.
6716         * python/py-record.c: Use C++ exception handling.
6717         * python/py-record-btrace.c: Use C++ exception handling.
6718         * python/py-progspace.c: Use C++ exception handling.
6719         * python/py-prettyprint.c: Use C++ exception handling.
6720         * python/py-param.c: Use C++ exception handling.
6721         * python/py-objfile.c: Use C++ exception handling.
6722         * python/py-linetable.c: Use C++ exception handling.
6723         * python/py-lazy-string.c: Use C++ exception handling.
6724         * python/py-infthread.c: Use C++ exception handling.
6725         * python/py-inferior.c: Use C++ exception handling.
6726         * python/py-gdb-readline.c: Use C++ exception handling.
6727         * python/py-framefilter.c: Use C++ exception handling.
6728         * python/py-frame.c: Use C++ exception handling.
6729         * python/py-finishbreakpoint.c: Use C++ exception handling.
6730         * python/py-cmd.c: Use C++ exception handling.
6731         * python/py-breakpoint.c: Use C++ exception handling.
6732         * python/py-arch.c: Use C++ exception handling.
6733         * printcmd.c: Use C++ exception handling.
6734         * ppc-linux-tdep.c: Use C++ exception handling.
6735         * parse.c: Use C++ exception handling.
6736         * p-valprint.c: Use C++ exception handling.
6737         * objc-lang.c: Use C++ exception handling.
6738         * mi/mi-main.c: Use C++ exception handling.
6739         * mi/mi-interp.c: Use C++ exception handling.
6740         * mi/mi-cmd-stack.c: Use C++ exception handling.
6741         * mi/mi-cmd-break.c: Use C++ exception handling.
6742         * main.c: Use C++ exception handling.
6743         * linux-thread-db.c: Use C++ exception handling.
6744         * linux-tdep.c: Use C++ exception handling.
6745         * linux-nat.c: Use C++ exception handling.
6746         * linux-fork.c: Use C++ exception handling.
6747         * linespec.c: Use C++ exception handling.
6748         * language.c: Use C++ exception handling.
6749         * jit.c: Use C++ exception handling.
6750         * infrun.c: Use C++ exception handling.
6751         * infcmd.c: Use C++ exception handling.
6752         * infcall.c: Use C++ exception handling.
6753         * inf-loop.c: Use C++ exception handling.
6754         * i386-tdep.c: Use C++ exception handling.
6755         * i386-linux-tdep.c: Use C++ exception handling.
6756         * guile/scm-value.c: Use C++ exception handling.
6757         * guile/scm-type.c: Use C++ exception handling.
6758         * guile/scm-symtab.c: Use C++ exception handling.
6759         * guile/scm-symbol.c: Use C++ exception handling.
6760         * guile/scm-pretty-print.c: Use C++ exception handling.
6761         * guile/scm-ports.c: Use C++ exception handling.
6762         * guile/scm-param.c: Use C++ exception handling.
6763         * guile/scm-math.c: Use C++ exception handling.
6764         * guile/scm-lazy-string.c: Use C++ exception handling.
6765         * guile/scm-frame.c: Use C++ exception handling.
6766         * guile/scm-disasm.c: Use C++ exception handling.
6767         * guile/scm-cmd.c: Use C++ exception handling.
6768         * guile/scm-breakpoint.c: Use C++ exception handling.
6769         * guile/scm-block.c: Use C++ exception handling.
6770         * guile/guile-internal.h: Use C++ exception handling.
6771         * gnu-v3-abi.c: Use C++ exception handling.
6772         * gdbtypes.c: Use C++ exception handling.
6773         * frame.c: Use C++ exception handling.
6774         * frame-unwind.c: Use C++ exception handling.
6775         * fbsd-tdep.c: Use C++ exception handling.
6776         * f-valprint.c: Use C++ exception handling.
6777         * exec.c: Use C++ exception handling.
6778         * event-top.c: Use C++ exception handling.
6779         * event-loop.c: Use C++ exception handling.
6780         * eval.c: Use C++ exception handling.
6781         * dwarf2read.c: Use C++ exception handling.
6782         * dwarf2loc.c: Use C++ exception handling.
6783         * dwarf2-frame.c: Use C++ exception handling.
6784         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6785         * dwarf-index-write.c: Use C++ exception handling.
6786         * dwarf-index-cache.c: Use C++ exception handling.
6787         * dtrace-probe.c: Use C++ exception handling.
6788         * disasm-selftests.c: Use C++ exception handling.
6789         * darwin-nat.c: Use C++ exception handling.
6790         * cp-valprint.c: Use C++ exception handling.
6791         * cp-support.c: Use C++ exception handling.
6792         * cp-abi.c: Use C++ exception handling.
6793         * corelow.c: Use C++ exception handling.
6794         * completer.c: Use C++ exception handling.
6795         * compile/compile-object-run.c: Use C++ exception handling.
6796         * compile/compile-object-load.c: Use C++ exception handling.
6797         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6798         * compile/compile-c-symbols.c: Use C++ exception handling.
6799         * common/selftest.c: Use C++ exception handling.
6800         * common/new-op.c: Use C++ exception handling.
6801         * cli/cli-script.c: Use C++ exception handling.
6802         * cli/cli-interp.c: Use C++ exception handling.
6803         * cli/cli-cmds.c: Use C++ exception handling.
6804         * c-varobj.c: Use C++ exception handling.
6805         * btrace.c: Use C++ exception handling.
6806         * breakpoint.c: Use C++ exception handling.
6807         * break-catch-throw.c: Use C++ exception handling.
6808         * arch-utils.c: Use C++ exception handling.
6809         * amd64-tdep.c: Use C++ exception handling.
6810         * ada-valprint.c: Use C++ exception handling.
6811         * ada-typeprint.c: Use C++ exception handling.
6812         * ada-lang.c: Use C++ exception handling.
6813         * aarch64-tdep.c: Use C++ exception handling.
6814
6815 2019-04-08  Tom Tromey  <tom@tromey.com>
6816
6817         * xml-support.c (gdb_xml_parser::parse): Update.
6818         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6819         * value.c (show_convenience): Update.
6820         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6821         (test_parse_flags_qcs): Update.
6822         * thread.c (thr_try_catch_cmd): Update.
6823         * target.c (target_translate_tls_address): Update.
6824         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6825         (info_frame_command_core, frame_apply_command_count): Update.
6826         * rust-exp.y (rust_lex_exception_test): Update.
6827         * riscv-tdep.c (riscv_print_one_register_info): Update.
6828         * remote.c (remote_target::enable_btrace): Update.
6829         * record-btrace.c (record_btrace_enable_warn): Update.
6830         * python/py-utils.c (gdbpy_convert_exception): Update.
6831         * printcmd.c (do_one_display, print_variable_and_value): Update.
6832         * mi/mi-main.c (mi_print_exception): Update.
6833         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6834         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6835         * linux-nat.c (linux_nat_target::attach): Update.
6836         * linux-fork.c (class scoped_switch_fork_info): Update.
6837         * infrun.c (displaced_step_prepare): Update.
6838         * infcall.c (call_function_by_hand_dummy): Update.
6839         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6840         * gnu-v3-abi.c (print_one_vtable): Update.
6841         * frame.c (get_prev_frame_always): Update.
6842         * f-valprint.c (info_common_command_for_block): Update.
6843         * exec.c (try_open_exec_file): Update.
6844         * exceptions.c (print_exception, exception_print)
6845         (exception_fprintf, exception_print_same): Update.
6846         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6847         * dwarf-index-cache.c (index_cache::store)
6848         (index_cache::lookup_gdb_index): Update.
6849         * darwin-nat.c (maybe_cache_shell): Update.
6850         * cp-valprint.c (cp_print_value_fields): Update.
6851         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6852         (gcc_cplus_symbol_address): Update.
6853         * compile/compile-c-symbols.c (gcc_convert_symbol)
6854         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6855         * common/selftest.c: Update.
6856         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6857         a std::string.
6858         (exception_try_scope_entry, exception_try_scope_exit): Don't
6859         declare.
6860         (struct exception_try_scope): Remove.
6861         (TRY): Don't use exception_try_scope.
6862         (struct gdb_exception): Add constructor, operator=.
6863         <what>: New method.
6864         (struct gdb_exception_RETURN_MASK_ALL)
6865         (struct gdb_exception_RETURN_MASK_ERROR)
6866         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6867         (struct gdb_quit_bad_alloc): Update.
6868         * common/common-exceptions.c (exception_none): Change
6869         initializer.
6870         (struct catcher) <state, exception>: Initialize inline.
6871         <prev>: Remove member.
6872         (current_catcher): Remove.
6873         (catchers): New global.
6874         (exceptions_state_mc_init): Simplify.
6875         (catcher_pop): Remove.
6876         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6877         (try_scope_depth, exception_try_scope_entry)
6878         (exception_try_scope_exit): Remove.
6879         (throw_exception_sjlj): Update.
6880         (exception_messages, exception_messages_size): Remove.
6881         (throw_it): Simplify.
6882         (gdb_exception_sliced_copy): Remove.
6883         (throw_exception_cxx): Update.
6884         * cli/cli-script.c (script_from_file): Update.
6885         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6886         Update.
6887         * ada-valprint.c (ada_val_print): Update.
6888         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6889         (create_excep_cond_exprs): Update.
6890
6891 2019-04-08  Tom Tromey  <tom@tromey.com>
6892
6893         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6894         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6895         (TRY, CATCH, END_CATCH): Remove some definitions.
6896         * common/common-exceptions.c: Don't use GDB_XCPT.
6897         (catcher_list_size): Remove.
6898         (throw_exception, throw_it): Simplify.
6899
6900 2019-04-05  Tom Tromey  <tom@tromey.com>
6901
6902         Revert the header-sorting patch.
6903         * ft32-tdep.c: Revert.
6904         * frv-tdep.c: Revert.
6905         * frv-linux-tdep.c: Revert.
6906         * frame.c: Revert.
6907         * frame-unwind.c: Revert.
6908         * frame-base.c: Revert.
6909         * fork-child.c: Revert.
6910         * findvar.c: Revert.
6911         * findcmd.c: Revert.
6912         * filesystem.c: Revert.
6913         * filename-seen-cache.h: Revert.
6914         * filename-seen-cache.c: Revert.
6915         * fbsd-tdep.c: Revert.
6916         * fbsd-nat.h: Revert.
6917         * fbsd-nat.c: Revert.
6918         * f-valprint.c: Revert.
6919         * f-typeprint.c: Revert.
6920         * f-lang.c: Revert.
6921         * extension.h: Revert.
6922         * extension.c: Revert.
6923         * extension-priv.h: Revert.
6924         * expprint.c: Revert.
6925         * exec.h: Revert.
6926         * exec.c: Revert.
6927         * exceptions.c: Revert.
6928         * event-top.c: Revert.
6929         * event-loop.c: Revert.
6930         * eval.c: Revert.
6931         * elfread.c: Revert.
6932         * dwarf2read.h: Revert.
6933         * dwarf2read.c: Revert.
6934         * dwarf2loc.c: Revert.
6935         * dwarf2expr.h: Revert.
6936         * dwarf2expr.c: Revert.
6937         * dwarf2-frame.c: Revert.
6938         * dwarf2-frame-tailcall.c: Revert.
6939         * dwarf-index-write.h: Revert.
6940         * dwarf-index-write.c: Revert.
6941         * dwarf-index-common.c: Revert.
6942         * dwarf-index-cache.h: Revert.
6943         * dwarf-index-cache.c: Revert.
6944         * dummy-frame.c: Revert.
6945         * dtrace-probe.c: Revert.
6946         * disasm.h: Revert.
6947         * disasm.c: Revert.
6948         * disasm-selftests.c: Revert.
6949         * dictionary.c: Revert.
6950         * dicos-tdep.c: Revert.
6951         * demangle.c: Revert.
6952         * dcache.h: Revert.
6953         * dcache.c: Revert.
6954         * darwin-nat.h: Revert.
6955         * darwin-nat.c: Revert.
6956         * darwin-nat-info.c: Revert.
6957         * d-valprint.c: Revert.
6958         * d-namespace.c: Revert.
6959         * d-lang.c: Revert.
6960         * ctf.c: Revert.
6961         * csky-tdep.c: Revert.
6962         * csky-linux-tdep.c: Revert.
6963         * cris-tdep.c: Revert.
6964         * cris-linux-tdep.c: Revert.
6965         * cp-valprint.c: Revert.
6966         * cp-support.c: Revert.
6967         * cp-namespace.c: Revert.
6968         * cp-abi.c: Revert.
6969         * corelow.c: Revert.
6970         * corefile.c: Revert.
6971         * continuations.c: Revert.
6972         * completer.h: Revert.
6973         * completer.c: Revert.
6974         * complaints.c: Revert.
6975         * coffread.c: Revert.
6976         * coff-pe-read.c: Revert.
6977         * cli-out.h: Revert.
6978         * cli-out.c: Revert.
6979         * charset.c: Revert.
6980         * c-varobj.c: Revert.
6981         * c-valprint.c: Revert.
6982         * c-typeprint.c: Revert.
6983         * c-lang.c: Revert.
6984         * buildsym.c: Revert.
6985         * buildsym-legacy.c: Revert.
6986         * build-id.h: Revert.
6987         * build-id.c: Revert.
6988         * btrace.c: Revert.
6989         * bsd-uthread.c: Revert.
6990         * breakpoint.h: Revert.
6991         * breakpoint.c: Revert.
6992         * break-catch-throw.c: Revert.
6993         * break-catch-syscall.c: Revert.
6994         * break-catch-sig.c: Revert.
6995         * blockframe.c: Revert.
6996         * block.c: Revert.
6997         * bfin-tdep.c: Revert.
6998         * bfin-linux-tdep.c: Revert.
6999         * bfd-target.c: Revert.
7000         * bcache.c: Revert.
7001         * ax-general.c: Revert.
7002         * ax-gdb.h: Revert.
7003         * ax-gdb.c: Revert.
7004         * avr-tdep.c: Revert.
7005         * auxv.c: Revert.
7006         * auto-load.c: Revert.
7007         * arm-wince-tdep.c: Revert.
7008         * arm-tdep.c: Revert.
7009         * arm-symbian-tdep.c: Revert.
7010         * arm-pikeos-tdep.c: Revert.
7011         * arm-obsd-tdep.c: Revert.
7012         * arm-nbsd-tdep.c: Revert.
7013         * arm-nbsd-nat.c: Revert.
7014         * arm-linux-tdep.c: Revert.
7015         * arm-linux-nat.c: Revert.
7016         * arm-fbsd-tdep.c: Revert.
7017         * arm-fbsd-nat.c: Revert.
7018         * arm-bsd-tdep.c: Revert.
7019         * arch-utils.c: Revert.
7020         * arc-tdep.c: Revert.
7021         * arc-newlib-tdep.c: Revert.
7022         * annotate.h: Revert.
7023         * annotate.c: Revert.
7024         * amd64-windows-tdep.c: Revert.
7025         * amd64-windows-nat.c: Revert.
7026         * amd64-tdep.c: Revert.
7027         * amd64-sol2-tdep.c: Revert.
7028         * amd64-obsd-tdep.c: Revert.
7029         * amd64-obsd-nat.c: Revert.
7030         * amd64-nbsd-tdep.c: Revert.
7031         * amd64-nbsd-nat.c: Revert.
7032         * amd64-nat.c: Revert.
7033         * amd64-linux-tdep.c: Revert.
7034         * amd64-linux-nat.c: Revert.
7035         * amd64-fbsd-tdep.c: Revert.
7036         * amd64-fbsd-nat.c: Revert.
7037         * amd64-dicos-tdep.c: Revert.
7038         * amd64-darwin-tdep.c: Revert.
7039         * amd64-bsd-nat.c: Revert.
7040         * alpha-tdep.c: Revert.
7041         * alpha-obsd-tdep.c: Revert.
7042         * alpha-nbsd-tdep.c: Revert.
7043         * alpha-mdebug-tdep.c: Revert.
7044         * alpha-linux-tdep.c: Revert.
7045         * alpha-linux-nat.c: Revert.
7046         * alpha-bsd-tdep.c: Revert.
7047         * alpha-bsd-nat.c: Revert.
7048         * aix-thread.c: Revert.
7049         * agent.c: Revert.
7050         * addrmap.c: Revert.
7051         * ada-varobj.c: Revert.
7052         * ada-valprint.c: Revert.
7053         * ada-typeprint.c: Revert.
7054         * ada-tasks.c: Revert.
7055         * ada-lang.c: Revert.
7056         * aarch64-tdep.c: Revert.
7057         * aarch64-ravenscar-thread.c: Revert.
7058         * aarch64-newlib-tdep.c: Revert.
7059         * aarch64-linux-tdep.c: Revert.
7060         * aarch64-linux-nat.c: Revert.
7061         * aarch64-fbsd-tdep.c: Revert.
7062         * aarch64-fbsd-nat.c: Revert.
7063         * aarch32-linux-nat.c: Revert.
7064
7065 2019-04-05  Tom Tromey  <tom@tromey.com>
7066
7067         * ft32-tdep.c: Sort headers.
7068         * frv-tdep.c: Sort headers.
7069         * frv-linux-tdep.c: Sort headers.
7070         * frame.c: Sort headers.
7071         * frame-unwind.c: Sort headers.
7072         * frame-base.c: Sort headers.
7073         * fork-child.c: Sort headers.
7074         * findvar.c: Sort headers.
7075         * findcmd.c: Sort headers.
7076         * filesystem.c: Sort headers.
7077         * filename-seen-cache.h: Sort headers.
7078         * filename-seen-cache.c: Sort headers.
7079         * fbsd-tdep.c: Sort headers.
7080         * fbsd-nat.h: Sort headers.
7081         * fbsd-nat.c: Sort headers.
7082         * f-valprint.c: Sort headers.
7083         * f-typeprint.c: Sort headers.
7084         * f-lang.c: Sort headers.
7085         * extension.h: Sort headers.
7086         * extension.c: Sort headers.
7087         * extension-priv.h: Sort headers.
7088         * expprint.c: Sort headers.
7089         * exec.h: Sort headers.
7090         * exec.c: Sort headers.
7091         * exceptions.c: Sort headers.
7092         * event-top.c: Sort headers.
7093         * event-loop.c: Sort headers.
7094         * eval.c: Sort headers.
7095         * elfread.c: Sort headers.
7096         * dwarf2read.h: Sort headers.
7097         * dwarf2read.c: Sort headers.
7098         * dwarf2loc.c: Sort headers.
7099         * dwarf2expr.h: Sort headers.
7100         * dwarf2expr.c: Sort headers.
7101         * dwarf2-frame.c: Sort headers.
7102         * dwarf2-frame-tailcall.c: Sort headers.
7103         * dwarf-index-write.h: Sort headers.
7104         * dwarf-index-write.c: Sort headers.
7105         * dwarf-index-common.c: Sort headers.
7106         * dwarf-index-cache.h: Sort headers.
7107         * dwarf-index-cache.c: Sort headers.
7108         * dummy-frame.c: Sort headers.
7109         * dtrace-probe.c: Sort headers.
7110         * disasm.h: Sort headers.
7111         * disasm.c: Sort headers.
7112         * disasm-selftests.c: Sort headers.
7113         * dictionary.c: Sort headers.
7114         * dicos-tdep.c: Sort headers.
7115         * demangle.c: Sort headers.
7116         * dcache.h: Sort headers.
7117         * dcache.c: Sort headers.
7118         * darwin-nat.h: Sort headers.
7119         * darwin-nat.c: Sort headers.
7120         * darwin-nat-info.c: Sort headers.
7121         * d-valprint.c: Sort headers.
7122         * d-namespace.c: Sort headers.
7123         * d-lang.c: Sort headers.
7124         * ctf.c: Sort headers.
7125         * csky-tdep.c: Sort headers.
7126         * csky-linux-tdep.c: Sort headers.
7127         * cris-tdep.c: Sort headers.
7128         * cris-linux-tdep.c: Sort headers.
7129         * cp-valprint.c: Sort headers.
7130         * cp-support.c: Sort headers.
7131         * cp-namespace.c: Sort headers.
7132         * cp-abi.c: Sort headers.
7133         * corelow.c: Sort headers.
7134         * corefile.c: Sort headers.
7135         * continuations.c: Sort headers.
7136         * completer.h: Sort headers.
7137         * completer.c: Sort headers.
7138         * complaints.c: Sort headers.
7139         * coffread.c: Sort headers.
7140         * coff-pe-read.c: Sort headers.
7141         * cli-out.h: Sort headers.
7142         * cli-out.c: Sort headers.
7143         * charset.c: Sort headers.
7144         * c-varobj.c: Sort headers.
7145         * c-valprint.c: Sort headers.
7146         * c-typeprint.c: Sort headers.
7147         * c-lang.c: Sort headers.
7148         * buildsym.c: Sort headers.
7149         * buildsym-legacy.c: Sort headers.
7150         * build-id.h: Sort headers.
7151         * build-id.c: Sort headers.
7152         * btrace.c: Sort headers.
7153         * bsd-uthread.c: Sort headers.
7154         * breakpoint.h: Sort headers.
7155         * breakpoint.c: Sort headers.
7156         * break-catch-throw.c: Sort headers.
7157         * break-catch-syscall.c: Sort headers.
7158         * break-catch-sig.c: Sort headers.
7159         * blockframe.c: Sort headers.
7160         * block.c: Sort headers.
7161         * bfin-tdep.c: Sort headers.
7162         * bfin-linux-tdep.c: Sort headers.
7163         * bfd-target.c: Sort headers.
7164         * bcache.c: Sort headers.
7165         * ax-general.c: Sort headers.
7166         * ax-gdb.h: Sort headers.
7167         * ax-gdb.c: Sort headers.
7168         * avr-tdep.c: Sort headers.
7169         * auxv.c: Sort headers.
7170         * auto-load.c: Sort headers.
7171         * arm-wince-tdep.c: Sort headers.
7172         * arm-tdep.c: Sort headers.
7173         * arm-symbian-tdep.c: Sort headers.
7174         * arm-pikeos-tdep.c: Sort headers.
7175         * arm-obsd-tdep.c: Sort headers.
7176         * arm-nbsd-tdep.c: Sort headers.
7177         * arm-nbsd-nat.c: Sort headers.
7178         * arm-linux-tdep.c: Sort headers.
7179         * arm-linux-nat.c: Sort headers.
7180         * arm-fbsd-tdep.c: Sort headers.
7181         * arm-fbsd-nat.c: Sort headers.
7182         * arm-bsd-tdep.c: Sort headers.
7183         * arch-utils.c: Sort headers.
7184         * arc-tdep.c: Sort headers.
7185         * arc-newlib-tdep.c: Sort headers.
7186         * annotate.h: Sort headers.
7187         * annotate.c: Sort headers.
7188         * amd64-windows-tdep.c: Sort headers.
7189         * amd64-windows-nat.c: Sort headers.
7190         * amd64-tdep.c: Sort headers.
7191         * amd64-sol2-tdep.c: Sort headers.
7192         * amd64-obsd-tdep.c: Sort headers.
7193         * amd64-obsd-nat.c: Sort headers.
7194         * amd64-nbsd-tdep.c: Sort headers.
7195         * amd64-nbsd-nat.c: Sort headers.
7196         * amd64-nat.c: Sort headers.
7197         * amd64-linux-tdep.c: Sort headers.
7198         * amd64-linux-nat.c: Sort headers.
7199         * amd64-fbsd-tdep.c: Sort headers.
7200         * amd64-fbsd-nat.c: Sort headers.
7201         * amd64-dicos-tdep.c: Sort headers.
7202         * amd64-darwin-tdep.c: Sort headers.
7203         * amd64-bsd-nat.c: Sort headers.
7204         * alpha-tdep.c: Sort headers.
7205         * alpha-obsd-tdep.c: Sort headers.
7206         * alpha-nbsd-tdep.c: Sort headers.
7207         * alpha-mdebug-tdep.c: Sort headers.
7208         * alpha-linux-tdep.c: Sort headers.
7209         * alpha-linux-nat.c: Sort headers.
7210         * alpha-bsd-tdep.c: Sort headers.
7211         * alpha-bsd-nat.c: Sort headers.
7212         * aix-thread.c: Sort headers.
7213         * agent.c: Sort headers.
7214         * addrmap.c: Sort headers.
7215         * ada-varobj.c: Sort headers.
7216         * ada-valprint.c: Sort headers.
7217         * ada-typeprint.c: Sort headers.
7218         * ada-tasks.c: Sort headers.
7219         * ada-lang.c: Sort headers.
7220         * aarch64-tdep.c: Sort headers.
7221         * aarch64-ravenscar-thread.c: Sort headers.
7222         * aarch64-newlib-tdep.c: Sort headers.
7223         * aarch64-linux-tdep.c: Sort headers.
7224         * aarch64-linux-nat.c: Sort headers.
7225         * aarch64-fbsd-tdep.c: Sort headers.
7226         * aarch64-fbsd-nat.c: Sort headers.
7227         * aarch32-linux-nat.c: Sort headers.
7228
7229 2019-04-04  Tom Tromey  <tom@tromey.com>
7230
7231         * varobj.c (varobj_create): Update.
7232         * rust-exp.y (struct rust_parser) <update_innermost_block,
7233         lookup_symbol>: New methods.
7234         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7235         Rename.
7236         (rust_parser::rust_lookup_type)
7237         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7238         * printcmd.c (display_command, do_one_display): Update.
7239         * parser-defs.h (struct parser_state) <parser_state>: Add
7240         "tracker" parameter.
7241         (block_tracker): New member.
7242         (class innermost_block_tracker) <innermost_block_tracker>: Add
7243         "types" parameter.
7244         <reset>: Remove method.
7245         (innermost_block): Don't declare.
7246         (null_post_parser): Update.
7247         * parse.c (innermost_block): Remove global.
7248         (write_dollar_variable): Update.
7249         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7250         Remove "tracker_types" parameter.
7251         (parse_expression): Add "tracker" parameter.
7252         (parse_expression_for_completion): Update.
7253         (null_post_parser): Add "tracker" parameter.
7254         * p-exp.y: Update rules.
7255         * m2-exp.y: Update rules.
7256         * language.h (struct language_defn) <la_post_parser>: Add
7257         "tracker" parameter.
7258         * go-exp.y: Update rules.
7259         * f-exp.y: Update rules.
7260         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7261         parameter.
7262         * d-exp.y: Update rules.
7263         * c-exp.y: Update rules.
7264         * breakpoint.c (set_breakpoint_condition): Create an
7265         innermost_block_tracker.
7266         (watch_command_1): Likewise.
7267         * ada-lang.c (resolve): Add "tracker" parameter.
7268         (resolve_subexp): Likewise.
7269         * ada-exp.y (write_var_from_sym): Update.
7270
7271 2019-04-04  Tom Tromey  <tom@tromey.com>
7272
7273         * type-stack.h: New file.
7274         * type-stack.c: New file.
7275         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7276         type-stack.h.
7277         (insert_into_type_stack, insert_type, push_type, push_type_int)
7278         (insert_type_address_space, pop_type, pop_type_int)
7279         (pop_typelist, pop_type_stack, append_type_stack)
7280         (push_type_stack, get_type_stack, push_typelist)
7281         (follow_type_instance_flags, follow_types): Don't declare.
7282         * parse.c (type_stack): Remove global.
7283         (parse_exp_in_context): Update.
7284         (insert_into_type_stack, insert_type, push_type, push_type_int)
7285         (insert_type_address_space, pop_type, pop_type_int)
7286         (pop_typelist, pop_type_stack, append_type_stack)
7287         (push_type_stack, get_type_stack, push_typelist)
7288         (follow_type_instance_flags, follow_types): Remove (moved to
7289         type-stack.c).
7290         * f-exp.y (type_stack): New global.
7291         Update rules.
7292         (push_kind_type, f_parse): Update.
7293         * d-exp.y (type_stack): New global.
7294         Update rules.
7295         (d_parse): Update.
7296         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7297         Update rules.
7298         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7299         (HFILES_NO_SRCDIR): Add type-stack.h.
7300
7301 2019-04-04  Tom Tromey  <tom@tromey.com>
7302
7303         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7304         (rust_parser::convert_ast_to_expression, rust_parse)
7305         (rust_lex_test_completion, rust_lex_tests): Update.
7306         * parser-defs.h (struct expr_completion_state): New.
7307         (struct parser_state) <parser_state>: Add completion parameter.
7308         <mark_struct_expression, mark_completion_tag>: New methods.
7309         <parse_completion, m_completion_state>: New members.
7310         (prefixify_expression, null_post_parser): Update.
7311         (mark_struct_expression, mark_completion_tag): Don't declare.
7312         * parse.c (parse_completion, expout_last_struct)
7313         (expout_tag_completion_type, expout_completion_name): Remove
7314         globals.
7315         (parser_state::mark_struct_expression)
7316         (parser_state::mark_completion_tag): Now methods.
7317         (prefixify_expression): Add last_struct parameter.
7318         (prefixify_subexp): Likewise.
7319         (parse_exp_1): Update.
7320         (parse_exp_in_context): Add cstate parameter.  Update.
7321         (parse_expression_for_completion): Create an
7322         expr_completion_state.
7323         (null_post_parser): Add "completion" parameter.
7324         * p-exp.y: Update rules.
7325         (yylex): Update.
7326         * language.h (struct language_defn) <la_post_parser>: Add
7327         "completing" parameter.
7328         * go-exp.y: Update rules.
7329         (lex_one_token): Update.
7330         * expression.h (parse_completion): Don't declare.
7331         * d-exp.y: Update rules.
7332         (lex_one_token): Update rules.
7333         * c-exp.y: Update rules.
7334         (lex_one_token): Update.
7335         * ada-lang.c (resolve): Add "parse_completion" parameter.
7336         (resolve_subexp): Likewise.
7337         (ada_resolve_function): Likewise.
7338
7339 2019-04-04  Tom Tromey  <tom@tromey.com>
7340
7341         * parser-defs.h (struct parser_state) <start_arglist,
7342         end_arglist>: New methods.
7343         <arglist_len, m_funcall_chain>: New members.
7344         (arglist_len, start_arglist, end_arglist): Don't declare.
7345         * parse.c (arglist_len, funcall_chain): Remove global.
7346         (start_arglist, end_arglist): Remove functions.
7347         (parse_exp_in_context): Update.
7348         * p-exp.y: Update rules.
7349         * m2-exp.y: Update rules.
7350         * go-exp.y: Update rules.
7351         * f-exp.y: Update rules.
7352         * d-exp.y: Update rules.
7353         * c-exp.y: Update rules.
7354
7355 2019-04-04  Tom Tromey  <tom@tromey.com>
7356
7357         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7358         lex_operator, push_back>: New methods.
7359         Update all rules.
7360         (rust_parser::lex_hex, lex_escape): Rename and update.
7361         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7362         (rust_parser::lex_operator): Rename and update.
7363         (rust_parser::lex_number, rustyylex, rustyyerror)
7364         (rust_lex_test_init, rust_lex_test_sequence)
7365         (rust_lex_test_push_back, rust_lex_tests): Update.
7366         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7367         parameter.
7368         <lexptr, prev_lexptr>: New members.
7369         (lexptr, prev_lexptr): Don't declare.
7370         * parse.c (lexptr, prev_lexptr): Remove globals.
7371         (parse_exp_in_context): Update.
7372         * p-exp.y (yylex, yyerror): Update.
7373         * m2-exp.y (parse_number, yylex, yyerror): Update.
7374         * go-exp.y (lex_one_token, yyerror): Update.
7375         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7376         * d-exp.y (lex_one_token, yyerror): Update.
7377         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7378         (lex_one_token, yyerror): Update.
7379         * ada-lex.l (YY_INPUT): Update.
7380         (rewind_to_char): Update.
7381         * ada-exp.y (yyerror): Update.
7382
7383 2019-04-04  Tom Tromey  <tom@tromey.com>
7384
7385         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7386         * parser-defs.h (struct parser_state) <parser_state>: Add new
7387         parameter.
7388         <comma_terminates>: New member.
7389         (comma_terminates): Don't declare global.
7390         * parse.c (comma_terminates): Remove global.
7391         (parse_exp_in_context): Update.
7392         * p-exp.y (yylex): Update.
7393         * m2-exp.y (yylex): Update.
7394         * go-exp.y (lex_one_token): Update.
7395         * f-exp.y (yylex): Update.
7396         * d-exp.y (lex_one_token): Update.
7397         * c-exp.y (lex_one_token): Update.
7398         * ada-lex.l: Update.
7399
7400 2019-04-04  Tom Tromey  <tom@tromey.com>
7401
7402         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7403         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7404         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7405         * parser-defs.h (paren_depth): Don't declare.
7406         * parse.c (paren_depth): Remove global.
7407         (parse_exp_in_context): Update.
7408         * p-exp.y (paren_depth): New global.
7409         (pascal_parse): Initialize it.
7410         * m2-exp.y (paren_depth): New global.
7411         (m2_parse): Initialize it.
7412         * go-exp.y (paren_depth): New global.
7413         (go_parse): Initialize it.
7414         * f-exp.y (paren_depth): New global.
7415         (f_parse): Initialize it.
7416         * d-exp.y (paren_depth): New global.
7417         (d_parse): Initialize it.
7418         * c-exp.y (paren_depth): New global.
7419         (c_parse): Initialize it.
7420         * ada-lex.l (paren_depth): New global.
7421         (lexer_init): Initialize it.
7422
7423 2019-04-04  Tom Tromey  <tom@tromey.com>
7424
7425         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7426         (rust_parser::convert_ast_to_type)
7427         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7428         * parser-defs.h (struct parser_state) <parser_state>: Add
7429         parameters.  Initialize new members.
7430         <expression_context_block, expression_context_pc>: New members.
7431         * parse.c (expression_context_block, expression_context_pc):
7432         Remove globals.
7433         (parse_exp_in_context): Update.
7434         * p-exp.y: Update all rules.
7435         (yylex): Update.
7436         * m2-exp.y: Update all rules.
7437         (yylex): Update.
7438         * go-exp.y (yylex): Update.
7439         * f-exp.y (yylex): Update.
7440         * d-exp.y: Update all rules.
7441         (yylex): Update.
7442         * c-exp.y: Update all rules.
7443         (lex_one_token, classify_name, yylex, c_parse): Update.
7444         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7445
7446 2019-04-04  Tom Tromey  <tom@tromey.com>
7447
7448         * gdbarch.h, gdbarch.c: Rebuild.
7449         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7450         * stap-probe.h:
7451         (struct stap_parse_info): Replace "parser_state" with
7452         "expr_builder".
7453         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7454         (parser_state): New class.
7455         * parse.c (expr_builder): Rename.
7456         (expr_builder::release): Rename.
7457         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7458         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7459         (write_exp_elt_longcst, write_exp_elt_floatcst)
7460         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7461         (write_exp_string_vector, write_exp_bitstring)
7462         (write_exp_msymbol, mark_struct_expression)
7463         (write_dollar_variable)
7464         (insert_type_address_space, increase_expout_size): Replace
7465         "parser_state" with "expr_builder".
7466         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7467         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7468         "parser_state" with "expr_builder".
7469
7470 2019-04-04  Tom Tromey  <tom@tromey.com>
7471
7472         * rust-exp.y: Replace "parse_language" with method call.
7473         * p-exp.y:
7474         (yylex): Replace "parse_language" with method call.
7475         * m2-exp.y:
7476         (yylex): Replace "parse_language" with method call.
7477         * go-exp.y (classify_name): Replace "parse_language" with method
7478         call.
7479         * f-exp.y (yylex): Replace "parse_language" with method call.
7480         * d-exp.y (lex_one_token): Replace "parse_language" with method
7481         call.
7482         * c-exp.y:
7483         (lex_one_token, classify_name, yylex): Replace "parse_language"
7484         with method call.
7485         * ada-exp.y (find_primitive_type, type_char)
7486         (type_system_address): Replace "parse_language" with method call.
7487
7488 2019-04-04  Tom Tromey  <tom@tromey.com>
7489
7490         * rust-exp.y: Replace "parse_gdbarch" with method call.
7491         * parse.c (write_dollar_variable, insert_type_address_space):
7492         Replace "parse_gdbarch" with method call.
7493         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7494         call.
7495         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7496         call.
7497         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7498         "parse_gdbarch" with method call.
7499         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7500         with method call.
7501         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7502         "parse_gdbarch" with method call.
7503         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7504         "parse_gdbarch" with method call.
7505         * c-exp.y (parse_type, parse_number, classify_name): Replace
7506         "parse_gdbarch" with method call.
7507         * ada-lex.l: Replace "parse_gdbarch" with method call.
7508         * ada-exp.y (parse_type, find_primitive_type, type_char)
7509         (type_system_address): Replace "parse_gdbarch" with method call.
7510
7511 2019-04-04  Tom Tromey  <tom@tromey.com>
7512
7513         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7514         * stap-probe.c (stap_parse_argument): Update.
7515         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7516         initial_size parameter.
7517         * rust-exp.y (rust_lex_tests): Update.
7518         * parse.c (parser_state): Update.
7519         (parse_exp_in_context): Update.
7520         * parser-defs.h (struct parser_state) <parser_state>: Remove
7521         "initial_size" parameter.
7522
7523 2019-04-04  Tom Tromey  <tom@tromey.com>
7524
7525         * parser-defs.h (increase_expout_size): Don't declare.
7526         * parse.c (increase_expout_size): Now static.
7527
7528 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7529
7530         * gnu-nat.c (gnu_nat_target::wait): Fix
7531         target_waitstatus_to_string call.
7532
7533 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * eval.c (evaluate_subexp_standard): Handle internal functions
7536         during Fortran function call handling.
7537
7538 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * NEWS: Mention new internal functions.
7541         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7542         (read_base_type): Use dwarf2_init_complex_target_type.
7543         * value.c (creal_internal_fn): New function.
7544         (cimag_internal_fn): New function.
7545         (_initialize_values): Register new internal functions.
7546
7547 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7548
7549         * infrun.c (stop_all_threads): If debug_infrun, always
7550         trace the wait status after wait_one, using
7551         target_waitstatus_to_string and target_pid_to_str.
7552         (handle_inferior_event): Replace various trace of
7553         wait status kind by a single trace.
7554         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7555         wait status kind image by target_waitstatus_to_string.
7556         * target/waitstatus.c (target_waitstatus_to_string): Fix
7557         obsolete comment.
7558
7559 2019-04-01  Tom Tromey  <tromey@adacore.com>
7560
7561         PR symtab/23331:
7562         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7563
7564 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7565             Pedro Alves  <palves@redhat.com>
7566
7567         * top.c (quit_force): Call 'finalize_values'.
7568         * value.c (finalize_values): New function.
7569         * value.h (finalize_values): Declare.
7570
7571 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7572
7573         * NEWS: Announce $_gdb_major and $_gdb_minor.
7574
7575         * top.c (init_gdb_version_vars): New function.
7576         (gdb_init): Call init_gdb_version_vars.
7577
7578 2019-03-29  Tom Tromey  <tromey@adacore.com>
7579
7580         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7581         help text.  Remove dead code.
7582
7583 2019-03-29  Keith Seitz  <keiths@redhat.com>
7584
7585         From Siddhesh Poyarekar:
7586         * f-lang.h (f77_get_upperbound): Return LONGEST.
7587         (f77_get_lowerbound): Likewise.
7588         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7589         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7590         print them.
7591         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7592         plongest to format print it.
7593         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7594         (f77_get_upperbound): Likewise.
7595         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7596         LOWER_BOUND to LONGEST.
7597         (f77_create_arrayprint_offset_tbl): Likewise.
7598
7599 2019-03-29  Keith Seitz  <keiths@redhat.com>
7600
7601         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7602         %s/pulongest for TYPE_LENGTH instead of %d in format
7603         strings.
7604         * ada-typerint.c (ada_print_type): Likewise.
7605         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7606         * compile/compile-c-support.c (generate_register_struct): Likewise.
7607         * gdbtypes.c (recursive_dump_type): Likewise.
7608         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7609         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7610         instead of %d in format strings.
7611         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7612         to std::min to ULONGEST.
7613         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7614         instead of %d in format strings.
7615         * tracepoint.c (info_scope_command): Likewise.
7616         * typeprint.c (print_offset_data::update)
7617         (print_offset_data::finish): Likewise.
7618         * xtensa-tdep.c (xtensa_store_return_value)
7619         (xtensa_push_dummy_call): Likewise.
7620
7621 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7622
7623         * windows-nat.c (display_selector): Fixed format specifications
7624         for 64-bit Cygwin.
7625
7626 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7627
7628         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7629
7630 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7631
7632         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7633         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7634         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7635         (nios2_linux_init_abi): Install it.
7636
7637 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7638
7639         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7640
7641 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7642
7643         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7644
7645 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7646             Tom Tromey  <tromey@adacore.com>
7647
7648         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7649
7650 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7651
7652         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7653         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7654         method to compute the bounds of range types. Also print "[evaluated]"
7655         if the bounds' values come from a dynamic evaluation.
7656
7657 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7660         whitespace when pretty printing is on.
7661
7662 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7663
7664         * ppc-linux-nat.c: Add include.
7665
7666 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * NEWS: Mention AArch64 Pointer Authentication.
7669
7670 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7671
7672         * arm-linux-nat.c: Add include.
7673
7674 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7675
7676         * source-cache.c (source_cache::get_source_lines): Re-read
7677         fullname after calling open_source_file.
7678
7679 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7680
7681         * NEWS: Mention TLS support for FreeBSD.
7682
7683 2019-03-25  Tom Tromey  <tromey@adacore.com>
7684
7685         * minsyms.c (BUNCH_SIZE): Update comment.
7686         (~minimal_symbol_reader): Remove old comment.
7687         (compact_minimal_symbols): Update comment.
7688         (minimal_symbol_reader::install): Remove old comment.  Update
7689         other comments.
7690
7691 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7692
7693         * s390-linux-nat.c: Add include.
7694
7695 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7696
7697         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7698         Call linux_get_hwcap.
7699         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7700         Likewise.
7701         (aarch64_linux_get_hwcap): Remove function.
7702         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7703         declaration.
7704         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7705         linux_get_hwcap.
7706         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7707         * linux-tdep.c (linux_get_hwcap): Add function.
7708         (linux_get_hwcap2): Likewise.
7709         * linux-tdep.h (linux_get_hwcap): Add declaration.
7710         (linux_get_hwcap2): Likewise.
7711         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7712         (ppc_linux_get_hwcap2): Likewise.
7713         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7714         linux_get_hwcap.
7715         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7716         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7717         (ppc_linux_nat_target::read_description): Likewise.
7718         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7719         * s390-linux-nat.c: Likewise.
7720         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7721
7722 2019-03-24  Tom Tromey  <tom@tromey.com>
7723
7724         * ada-lang.c (standard_lookup): Simplify initialization.
7725         (ada_lookup_symbol_nonlocal): Simplify return.
7726         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7727         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7728         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7729         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7730         initialization.
7731         * solib.c (solib_global_lookup): Simplify.
7732         * symtab.c (null_block_symbol): Remove.
7733         (symbol_cache_lookup): Simplify returns.
7734         (lookup_language_this): Simplify returns.
7735         (lookup_symbol_aux): Simplify return.
7736         (lookup_local_symbol): Simplify returns.
7737         (lookup_global_symbol_from_objfile): Simplify return.
7738         (lookup_symbol_in_objfile_symtabs)
7739         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7740         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7741         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7742         * cp-namespace.c (cp_lookup_bare_symbol)
7743         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7744         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7745         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7746         (cp_lookup_symbol_via_imports): Simplify initialization.
7747         (find_symbol_in_baseclass): Likewise.
7748         * symtab.h (null_block_symbol): Remove.
7749         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7750         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7751         (d_lookup_symbol_module): Likewise.
7752         (find_symbol_in_baseclass): Simplify initialization.
7753
7754 2019-03-24  Tom Tromey  <tom@tromey.com>
7755
7756         * expression.h: Don't include symtab.h.
7757         (struct block): Forward declare.
7758
7759 2019-03-24  Tom Tromey  <tom@tromey.com>
7760
7761         * c-exp.y (typebase): Remove casts.
7762         * gdbtypes.c (lookup_unsigned_typename, )
7763         (lookup_signed_typename): Remove cast.
7764         * eval.c (parse_to_comma_and_eval): Remove cast.
7765         * parse.c (write_dollar_variable): Remove cast.
7766         * block.h (struct block) <superblock>: Now const.
7767         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7768         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7769         (map_block): Make "block" const.
7770         * symfile.h (struct quick_symbol_functions)
7771         <map_matching_symbols>: Constify block argument to "callback".
7772         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7773         const.
7774         (find_pc_sect_compunit_symtab): Make "b" const.
7775         (find_symbol_at_address): Likewise.
7776         (search_symbols): Likewise.
7777         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7778         (dw2_debug_names_lookup_symbol): Likewise.
7779         (dw2_map_matching_symbols): Update.
7780         * p-valprint.c (pascal_val_print): Remove "block".
7781         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7782         (aux_add_nonlocal_symbols): Make "block" const.
7783         (resolve_subexp): Remove cast.
7784         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7785         const.
7786         (iterate_over_file_blocks): Likewise.
7787         * f-exp.y (%union) <bval>: Remove.
7788         * coffread.c (patch_opaque_types): Make "b" const.
7789         * spu-tdep.c (spu_catch_start): Make "block" const.
7790         * c-valprint.c (print_unpacked_pointer): Remove "block".
7791         * symmisc.c (dump_symtab_1): Make "b" const.
7792         (block_depth): Make "block" const.
7793         * d-exp.y (%union) <bval>: Remove.
7794         * cp-support.h (cp_lookup_rtti_type): Update.
7795         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7796         * psymtab.c (psym_lookup_symbol): Make "block" const.
7797         (maintenance_check_psymtabs): Make "b" const.
7798         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7799         (enumerate_locals, enumerate_args): Update.
7800         * python/py-symtab.c (stpy_global_block): Make "block" const.
7801         (stpy_static_block): Likewise.
7802         * inline-frame.c (block_starting_point_at): Make "new_block"
7803         const.
7804         * block.c (find_block_in_blockvector): Make return type const.
7805         (blockvector_for_pc_sect): Make "b" const.
7806         (find_block_in_blockvector): Make "b" const.
7807
7808 2019-03-23  Tom Tromey  <tom@tromey.com>
7809
7810         * varobj.c (varobj_create): Update.
7811         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7812         * printcmd.c (display_command, do_one_display): Don't reset
7813         innermost_block.
7814         * parser-defs.h (enum innermost_block_tracker_type): Move to
7815         expression.h.
7816         (innermost_block): Update comment.
7817         * parse.c (parse_exp_1): Add tracker_types parameter.
7818         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7819         tracker_types parameter.  Reset innermost_block.
7820         (parse_exp_in_context): Remove.
7821         (parse_expression_for_completion): Update.
7822         * objfiles.c (~objfile): Don't reset expression_context_block or
7823         innermost_block.
7824         * expression.h (enum innermost_block_tracker_type): Move from
7825         parser-defs.h.
7826         (parse_exp_1): Add tracker_types parameter.
7827         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7828         reset innermost_block.
7829
7830 2019-03-23  Tom Tromey  <tom@tromey.com>
7831
7832         * objfiles.h: Include bcache.h.
7833
7834 2019-03-23  Tom Tromey  <tom@tromey.com>
7835
7836         * linespec.c (get_current_search_block): Use
7837         scoped_restore_current_language.
7838         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7839
7840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7841             Jiong Wang  <jiong.wang@arm.com>
7842
7843         * aarch64-linux-tdep.c
7844         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7845         section.
7846         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7847
7848 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7849             Jiong Wang  <jiong.wang@arm.com>
7850
7851         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7852         instructions.
7853         (aarch64_analyze_prologue_test): Add PACIASP test.
7854         (aarch64_prologue_prev_register): Unmask PC value.
7855
7856 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7857             Jiong Wang  <jiong.wang@arm.com>
7858
7859         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7860         (aarch64_dwarf2_prev_register): Unmask PC value.
7861         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7862         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7863         DW_CFA_AARCH64_negate_ra_state.
7864         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7865
7866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7867             Jiong Wang  <jiong.wang@arm.com>
7868
7869         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7870         registers.
7871         (aarch64_pseudo_register_name): Likewise.
7872         (aarch64_pseudo_register_type): Likewise.
7873         (aarch64_pseudo_register_reggroup_p): Likewise.
7874         (aarch64_gdbarch_init): Add pauth registers.
7875         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7876         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7877         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7878         (struct gdbarch_tdep): Add regnum for ra_state.
7879
7880 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7881             Jiong Wang  <jiong.wang@arm.com>
7882
7883         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7884
7885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7886             Jiong Wang  <jiong.wang@arm.com>
7887
7888         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7889         function.
7890         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7891         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7892         (aarch64_gdbarch_init): Add puth registers.
7893         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7894         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7895         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7896
7897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7898             Jiong Wang  <jiong.wang@arm.com>
7899
7900         * aarch64-linux-nat.c
7901         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7902         * aarch64-linux-tdep.c
7903         (aarch64_linux_core_read_description): Likewise.
7904         (aarch64_linux_get_hwcap): New function.
7905         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7906         (aarch64_linux_get_hwcap): New declaration.
7907
7908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7909             Jiong Wang  <jiong.wang@arm.com>
7910
7911         * aarch64-linux-nat.c
7912         (aarch64_linux_nat_target::read_description): Add pauth param.
7913         * aarch64-linux-tdep.c
7914         (aarch64_linux_core_read_description): Likewise.
7915         * aarch64-tdep.c (struct target_desc): Add in pauth.
7916         (aarch64_read_description): Add pauth param.
7917         (aarch64_gdbarch_init): Likewise.
7918         * aarch64-tdep.h (aarch64_read_description): Likewise.
7919         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7920         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7921         * features/Makefile: Add new files.
7922         * features/aarch64-pauth.c: New file.
7923         * features/aarch64-pauth.xml: New file.
7924
7925 2019-03-20  Tom Tromey  <tromey@adacore.com>
7926
7927         * infrun.c (handle_inferior_event): Rename from
7928         handle_inferior_event_1.  Create a scoped_value_mark.
7929         (handle_inferior_event): Remove.
7930
7931 2019-03-19  Tom Tromey  <tromey@adacore.com>
7932
7933         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7934         * infrun.h (print_stop_event): Add "displays" parameter.
7935         * infrun.c (print_stop_event): Add "displays" parameter.
7936
7937 2019-03-19  Pedro Alves  <palves@redhat.com>
7938
7939         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7940         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7941         to -1.  Fix TABs vs spaces.
7942         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7943         * tui/tui-out.h (tui_ui_out) Add intro comments.
7944         <m_line, m_start_of_line>: In-class initialize, and add describing
7945         comment.
7946
7947 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7948
7949         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7950         variable names.
7951         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7952
7953 2019-03-18  Pedro Alves  <palves@redhat.com>
7954             Eli Zaretskii <eliz@gnu.org>
7955
7956         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7957         m_line and m_start_of_line.
7958
7959 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7960
7961         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7962         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7963         it returns a newline.  This fixes a regression in TU mode, whereby
7964         the next line is output on the same screen line as the user input.
7965
7966 2019-03-18  Tom Tromey  <tromey@adacore.com>
7967
7968         * minsyms.c (minimal_symbol_reader::install): Remove call to
7969         obstack_blank.
7970
7971 2019-03-18  Pedro Alves  <palves@redhat.com>
7972
7973         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7974         New globals.
7975         (apply_style): New, factored out from ...
7976         (apply_ansi_escape): ... this.  Handle reverse video mode.
7977         (tui_set_reverse_mode): New function.
7978         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7979         * tui/tui-winsource.c (tui_show_source_line): Use
7980         tui_set_reverse_mode instead of setting A_STANDOUT.
7981         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7982         New setter methods.
7983
7984 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7985
7986         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7987         Handle tabs.
7988
7989 2019-03-18  Tom Tromey  <tromey@adacore.com>
7990
7991         * ada-lang.c (empty_array): Add "high" parameter.
7992         (ada_evaluate_subexp): Update.
7993
7994 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7995
7996         * unittests/string_view-selftests.c: Define
7997         _initialize_string_view_selftests unconditionally.
7998
7999 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8000
8001         PR gdb/24350
8002         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8003
8004 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8005
8006         PR gdb/24351
8007         * windows-nat.c (display_selector): Fix format specifiers.
8008
8009 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8010
8011         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8012         tui_refill_source_window instead of tui_refresh_win, to update the
8013         current execution line.  This fixes redisplay of the current line
8014         when stepping through the code with "next" or "step".
8015
8016 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8017
8018         * source-cache.c (source_cache::get_source_lines): Call
8019         find_source_lines to initialize s->nlines.  This fixes vertical
8020         scrolling of TUI source window when the DOWN arrow is pressed.
8021
8022 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8023
8024         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8025         linux-thread-db.c (_initialize_thread_db): Likewise.
8026
8027 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8028
8029         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8030         wclrtoeol in tui_show_source_line".  This reverts changes made in
8031         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8032
8033 2019-03-15  Tom Tromey  <tom@tromey.com>
8034
8035         * symtab.h (struct minimal_symbol): Derive from
8036         general_symbol_info.
8037         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8038         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8039         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8040         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8041         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8042         (MSYMBOL_SEARCH_NAME): Update.
8043         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8044         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8045         * minsyms.c (minimal_symbol_reader::record_full): Update.
8046
8047 2019-03-15  Tom Tromey  <tom@tromey.com>
8048
8049         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8050
8051 2019-03-15  Tom Tromey  <tom@tromey.com>
8052
8053         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8054         unique_xmalloc_ptr.
8055         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8056         Update.
8057         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8058         (build_minimal_symbol_hash_tables)
8059         (minimal_symbol_reader::install): Update.
8060
8061 2019-03-15  Tom Tromey  <tom@tromey.com>
8062
8063         * symtab.c (create_demangled_names_hash): Update.
8064         (symbol_set_names): Update.
8065         * objfiles.h (struct objfile_per_bfd_storage)
8066         <demangled_names_hash>: Now an htab_up.
8067         * objfiles.c (objfile_per_bfd_storage): Simplify.
8068
8069 2019-03-15  Tom Tromey  <tom@tromey.com>
8070
8071         * objfiles.h (struct objfile_per_bfd_storage): Declare
8072         destructor.
8073         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8074         New.
8075         (get_objfile_bfd_data): Use new.  Don't initialize
8076         language_of_main.
8077         (free_objfile_per_bfd_storage): Remove.
8078         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8079
8080 2019-03-15  Tom Tromey  <tom@tromey.com>
8081
8082         * symfile.c (reread_symbols): Update.
8083         * objfiles.c (objfile::objfile): Update.
8084         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8085         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8086         comment.
8087         (minimal_symbol_reader::install): Update.
8088         (terminate_minimal_symbol_table): Remove.
8089         * jit.c (jit_object_close_impl): Update.
8090
8091 2019-03-15  Tom Tromey  <tom@tromey.com>
8092
8093         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8094         initializations.
8095
8096 2019-03-15  Tom Tromey  <tom@tromey.com>
8097
8098         * objfiles.h (struct objfile_per_bfd_storage)
8099         <demangled_hash_languages>: Now a bitset.
8100         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8101         (lookup_minimal_symbol): Update.
8102
8103 2019-03-15  Tom Tromey  <tom@tromey.com>
8104
8105         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8106         Don't return the symbol.
8107         * coffread.c (record_minimal_symbol): Use record_full.
8108
8109 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8110
8111         The MS-Windows port of ncurses fails to switch to a color pair if
8112         one or both of the colors are the implicit default colors.  This
8113         change records the default colors when TUI is initialized, and
8114         then specifies them explicitly when a color pair uses the default
8115         colors.  This allows color styling in TUI mode on MS-Windows.
8116
8117         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8118         ncurses_norm_attr.
8119         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8120         colors in ncurses_norm_attr.
8121         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8122         "none", replace it with the default color recorded in
8123         ncurses_norm_attr.
8124
8125 2019-03-14  Tom Tromey  <tromey@adacore.com>
8126
8127         * source-cache.h (class source_cache) <get_source_lines>: Return
8128         std::string.
8129         * source-cache.c (source_cache::extract_lines): Handle case where
8130         first_pos==npos.  Return std::string.
8131         (source_cache::get_source_lines): Update.
8132
8133 2019-03-14  Tom Tromey  <tromey@adacore.com>
8134
8135         * NEWS: Add item for "style sources" commands.
8136         * source-cache.c (source_cache::get_source_lines): Check
8137         source_styling.
8138         * cli/cli-style.c (source_styling): New global.
8139         (_initialize_cli_style): Add "style sources" commands.
8140         (show_style_sources): New function.
8141         * cli/cli-style.h (source_styling): Declare.
8142
8143 2019-03-14  Pedro Alves  <palves@redhat.com>
8144             Tom Tromey  <tromey@adacore.com>
8145
8146         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8147         * tui/tui-winsource.c (tui_refill_source_window): New function,
8148         from...
8149         (tui_horizontal_source_scroll): ... here.  Move some logic.
8150         * cli/cli-style.c (set_style_enabled): Notify new observable.
8151         * tui/tui-hooks.c (tui_redisplay_source): New function.
8152         (tui_attach_detach_observers): Attach or detach
8153         tui_redisplay_source.
8154         * observable.h (source_styling_changed): New observable.
8155         * observable.c: Define source_styling_changed observable.
8156
8157 2019-03-13  Tom Tromey  <tromey@adacore.com>
8158
8159         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8160         (i386_gnu_nat_target::store_registers): Update.
8161         * target-debug.h (target_debug_print_std_string): New macro.
8162         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8163         * windows-tdep.c (display_one_tib): Update.
8164         * tui/tui-stack.c (tui_make_status_line): Update.
8165         * top.c (print_inferior_quit_action): Update.
8166         * thread.c (thr_try_catch_cmd): Update.
8167         (add_thread_with_info): Update.
8168         (thread_target_id_str): Update.
8169         (thr_try_catch_cmd): Update.
8170         (thread_command): Update.
8171         (thread_find_command): Update.
8172         * record-btrace.c (record_btrace_target::info_record)
8173         (record_btrace_resume_thread, record_btrace_target::resume)
8174         (record_btrace_cancel_resume, record_btrace_step_thread)
8175         (record_btrace_target::wait, record_btrace_target::wait)
8176         (record_btrace_target::wait, record_btrace_target::stop): Update.
8177         * progspace.c (print_program_space): Update.
8178         * process-stratum-target.c
8179         (process_stratum_target::thread_address_space): Update.
8180         * linux-fork.c (linux_fork_mourn_inferior)
8181         (detach_checkpoint_command, info_checkpoints_command)
8182         (linux_fork_context): Update.
8183         (linux_fork_detach): Update.
8184         (class scoped_switch_fork_info): Update.
8185         (delete_checkpoint_command): Update.
8186         * infrun.c (follow_fork_inferior): Update.
8187         (follow_fork_inferior): Update.
8188         (proceed_after_vfork_done): Update.
8189         (handle_vfork_child_exec_or_exit): Update.
8190         (follow_exec): Update.
8191         (displaced_step_prepare_throw): Update.
8192         (displaced_step_restore): Update.
8193         (start_step_over): Update.
8194         (resume_1): Update.
8195         (clear_proceed_status_thread): Update.
8196         (proceed): Update.
8197         (print_target_wait_results): Update.
8198         (do_target_wait): Update.
8199         (context_switch): Update.
8200         (stop_all_threads): Update.
8201         (restart_threads): Update.
8202         (finish_step_over): Update.
8203         (handle_signal_stop): Update.
8204         (switch_back_to_stepped_thread): Update.
8205         (keep_going_pass_signal): Update.
8206         (print_exited_reason): Update.
8207         (normal_stop): Update.
8208         * inferior.c (inferior_pid_to_str): Change return type.
8209         (print_selected_inferior): Update.
8210         (add_inferior): Update.
8211         (detach_inferior): Update.
8212         * dummy-frame.c (fprint_dummy_frames): Update.
8213         * dcache.c (dcache_info_1): Update.
8214         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8215         (btrace_fetch, btrace_clear): Update.
8216         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8217         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8218         type.
8219         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8220         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8221         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8222         * gdbarch.c, gdbarch.h: Rebuild.
8223         * gdbarch.sh (core_pid_to_str): Change return type.
8224         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8225         return type.
8226         (windows_nat_target::pid_to_str): Change return type.
8227         (windows_delete_thread): Update.
8228         (windows_nat_target::attach): Update.
8229         (windows_nat_target::files_info): Update.
8230         * target-delegates.c: Rebuild.
8231         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8232         return type.
8233         (sol_thread_target::pid_to_str): Change return type.
8234         * remote.c (class remote_target) <pid_to_str>: Change return
8235         type.
8236         (remote_target::pid_to_str): Change return type.
8237         (extended_remote_target::attach, remote_target::remote_stop_ns)
8238         (remote_target::remote_notif_remove_queued_reply)
8239         (remote_target::push_stop_reply, remote_target::disable_btrace):
8240         Update.
8241         (extended_remote_target::attach): Update.
8242         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8243         type.
8244         (gdbsim_target::pid_to_str): Change return type.
8245         * ravenscar-thread.c (struct ravenscar_thread_target)
8246         <pid_to_str>: Change return type.
8247         (ravenscar_thread_target::pid_to_str): Change return type.
8248         * procfs.c (class procfs_target) <pid_to_str>: Change return
8249         type.
8250         (procfs_target::pid_to_str): Change return type.
8251         (procfs_target::attach): Update.
8252         (procfs_target::detach): Update.
8253         (procfs_target::fetch_registers): Update.
8254         (procfs_target::store_registers): Update.
8255         (procfs_target::wait): Update.
8256         (procfs_target::files_info): Update.
8257         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8258         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8259         return type.
8260         (nto_procfs_target::pid_to_str): Change return type.
8261         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8262         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8263         return type.
8264         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8265         (exit_lwp): Update.
8266         (attach_proc_task_lwp_callback, get_detach_signal)
8267         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8268         (linux_nat_target::resume, wait_lwp, stop_callback)
8269         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8270         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8271         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8272         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8273         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8274         type.
8275         (inf_ptrace_target::attach): Update.
8276         (inf_ptrace_target::files_info): Update.
8277         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8278         type.
8279         (go32_nat_target::pid_to_str): Change return type.
8280         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8281         (gnu_nat_target::wait): Update.
8282         (gnu_nat_target::wait): Update.
8283         (gnu_nat_target::resume): Update.
8284         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8285         (fbsd_nat_target::wait): Update.
8286         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8287         type.
8288         (darwin_nat_target::attach): Update.
8289         * corelow.c (class core_target) <pid_to_str>: Change return type.
8290         (core_target::pid_to_str): Change return type.
8291         * target.c (normal_pid_to_str): Change return type.
8292         (default_pid_to_str): Likewise.
8293         (target_pid_to_str): Change return type.
8294         (target_translate_tls_address): Update.
8295         (target_announce_detach): Update.
8296         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8297         return type.
8298         (bsd_uthread_target::pid_to_str): Change return type.
8299         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8300         type.
8301         (bsd_kvm_target::pid_to_str): Change return type.
8302         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8303         return type.
8304         (aix_thread_target::pid_to_str): Change return type.
8305         * target.h (struct target_ops) <pid_to_str>: Change return type.
8306         (target_pid_to_str, normal_pid_to_str): Likewise.
8307         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8308         type.
8309         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8310         type.
8311         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8312         return type.
8313         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8314         type.
8315         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8316         type.
8317         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8318         return type.
8319
8320 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8321
8322         * NEWS: Mention that the new default MI version is 3.  Mention
8323         changes to the output of commands and events that deal with
8324         multi-location breakpoints.
8325         * breakpoint.c: Include "mi/mi-out.h".
8326         (print_one_breakpoint): Change output syntax if using MI version
8327         >= 3.
8328         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8329         New.
8330         (mi_multi_location_breakpoint_output_fixed): New.
8331         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8332         (mi_cmd_fix_multi_location_breakpoint_output): New.
8333         (mi_multi_location_breakpoint_output_fixed): New.
8334         * mi/mi-cmds.c (mi_cmds): Register command
8335         -fix-multi-location-breakpoint-output.
8336         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8337         interpreter "mi".
8338
8339 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8340
8341         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8342         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8343         instantiate mi_ui_out based on interpreter name.
8344         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8345         * mi/mi-main.c (mi_load_progress): Likewise.
8346
8347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8348
8349         * NEWS: Combine separate "New targets" sections for 8.3.
8350
8351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8352
8353         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8354         (ppcfbsd_init_abi): Install gdbarch
8355         "fetch_tls_load_module_address" and "get_thread_local_address"
8356         methods.
8357
8358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8359
8360         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8361         (riscv_fbsd_init_abi): Install gdbarch
8362         "fetch_tls_load_module_address" and "get_thread_local_address"
8363         methods.
8364
8365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8366
8367         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8368         (i386fbsd_init_abi): Install gdbarch
8369         "fetch_tls_load_module_address" and "get_thread_local_address"
8370         methods.
8371
8372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8373
8374         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8375         (amd64fbsd_init_abi): Install gdbarch
8376         "fetch_tls_load_module_address" and "get_thread_local_address"
8377         methods.
8378
8379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8380
8381         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8382         (struct fbsd_pspace_data): New type.
8383         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8384         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8385         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8386         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8387         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8388
8389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8390
8391         * gdbtypes.c (lookup_struct_elt): New function.
8392         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8393         * gdbtypes.h (struct struct_elt): New type.
8394         (lookup_struct_elt): New prototype.
8395
8396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8397
8398         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8399         remove disabled code block.
8400
8401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8402
8403         * gdbarch.sh (get_thread_local_address): New method.
8404         * gdbarch.h, gdbarch.c: Regenerate.
8405         * target.c (target_translate_tls_address): Use
8406         gdbarch_get_thread_local_address if present instead of
8407         target::get_thread_local_address.
8408
8409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8410
8411         * target.h (target::get_thread_local_address): Update comment.
8412
8413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8414
8415         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8416         objfile->separate_debug_objfile_backlink if not NULL.
8417
8418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8419
8420         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8421         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8422         (amd64bsd_store_inferior_registers): Likewise.
8423         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8424         Enable segment base registers.
8425         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8426         PT_GETFSBASE and PT_GETGSBASE.
8427         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8428         PT_SETGSBASE.
8429         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8430         segment base registers.
8431         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8432
8433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8434
8435         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8436         Update calls to i386_target_description to add 'segments'
8437         parameter.
8438         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8439         add segment base registers.
8440         * arch/i386.c (i386_create_target_description): Add 'segments'
8441         parameter to enable segment base registers.
8442         * arch/i386.h (i386_create_target_description): Likewise.
8443         * features/i386/32bit-segments.xml: New file.
8444         * features/i386/32bit-segments.c: Generate.
8445         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8446         call to i386_target_description to add 'segments' parameter.
8447         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8448         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8449         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8450         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8451         if feature is present.
8452         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8453         Add 'segments' parameter to call to i386_target_description.
8454         (i386_target_description): Add 'segments' parameter to enable
8455         segment base registers.
8456         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8457         to call to i386_target_description.
8458         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8459         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8460         Define I386_NUM_REGS.
8461         (i386_target_description): Add 'segments' parameter to enable
8462         segment base registers.
8463
8464 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8465
8466         PR/24325
8467         * source-cache.c: #undef open and close, to avoid unresolved
8468         externals during linking.
8469
8470 2019-03-12  Tom Tromey  <tromey@adacore.com>
8471
8472         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8473         const.  Add initializers.
8474         (_initialize_remote): Don't initialize ptid globals.
8475
8476 2019-03-12  Pedro Alves  <palves@redhat.com>
8477
8478         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8479
8480 2019-03-12  Pedro Alves  <palves@redhat.com>
8481
8482         * cp-name-parser.y (main): Remove unused 'len' variable.
8483
8484 2019-03-12  Tom Tromey  <tromey@adacore.com>
8485
8486         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8487         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8488
8489 2019-03-12  Tom Tromey  <tromey@adacore.com>
8490
8491         * linux-nat.c (iterate_over_lwps): Update.
8492         (stop_callback): Remove parameter.
8493         (stop_wait_callback, detach_callback, resume_set_callback)
8494         (select_singlestep_lwp_callback, set_ignore_sigint)
8495         (status_callback, resumed_callback, resume_clear_callback)
8496         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8497         data parameter.
8498         (linux_nat_target::detach, linux_nat_target::resume)
8499         (linux_stop_and_wait_all_lwps, select_event_lwp)
8500         (linux_nat_filter_event, linux_nat_wait_1)
8501         (linux_nat_target::kill, linux_nat_target::stop)
8502         (linux_nat_target::stop): Update.
8503         (linux_nat_resume_callback): Change type.
8504         (resume_stopped_resumed_lwps, count_events_callback)
8505         (select_event_lwp_callback): Likewise.
8506         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8507         * arm-linux-nat.c (struct update_registers_data): Remove.
8508         (update_registers_callback): Change type.
8509         (arm_linux_insert_hw_breakpoint1): Update.
8510         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8511         parameter.
8512         (x86_linux_dr_set_addr): Update.
8513         (x86_linux_dr_set_control): Update.
8514         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8515         (iterate_over_lwps): Use gdb::function_view.
8516         * nat/aarch64-linux-hw-point.c (struct
8517         aarch64_dr_update_callback_param): Remove.
8518         (debug_reg_change_callback): Change type.
8519         (aarch64_notify_debug_reg_change): Update.
8520         * s390-linux-nat.c (s390_refresh_per_info): Update.
8521
8522 2019-03-11  Tom Tromey  <tromey@adacore.com>
8523
8524         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8525         redundant assignment to "this_cu".
8526
8527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8528
8529         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8530
8531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8532
8533         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8534         from...
8535         (rank_one_type): ... this.
8536
8537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8538
8539         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8540         from...
8541         (rank_one_type): ... this.
8542
8543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8544
8545         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8546         from...
8547         (rank_one_type): ... this.
8548
8549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8550
8551         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8552         from...
8553         (rank_one_type): ... this.
8554
8555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8556
8557         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8558         from...
8559         (rank_one_type): ... this.
8560
8561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8562
8563         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8564         from...
8565         (rank_one_type): ... this.
8566
8567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8568
8569         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8570         from...
8571         (rank_one_type): ... this.
8572
8573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8574
8575         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8576         from...
8577         (rank_one_type): ... this.
8578
8579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8580
8581         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8582         from...
8583         (rank_one_type): ... this.
8584
8585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8586
8587         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8588         from...
8589         (rank_one_type): ... this.
8590
8591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8592
8593         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8594         from...
8595         (rank_one_type): ... this.
8596
8597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8598
8599         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8600         from...
8601         (rank_one_type): ... this.
8602
8603 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8604
8605         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8606         inferior-events' shows the example events.
8607
8608 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8609
8610         Support styling on native MS-Windows console
8611
8612         PR/24315
8613         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8614         on MS-Windows if $TERM is not defined.
8615
8616         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8617
8618         * posix-hdep.c (gdb_console_fputs):
8619         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8620         functions.
8621         * ui-file.h (gdb_console_fputs): Add prototype.
8622
8623         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8624         back to fputs only if the former returns zero.
8625
8626 2019-03-07  Tom Tromey  <tom@tromey.com>
8627
8628         * symmisc.c (print_symbol_bcache_statistics): Update.
8629         (print_objfile_statistics): Update.
8630         * symfile.c (allocate_symtab): Update.
8631         * stabsread.c: Don't include bcache.h.
8632         * psymtab.h (struct psymbol_bcache): Don't declare.
8633         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8634         (psymbol_bcache_init, psymbol_bcache_free)
8635         (psymbol_bcache_get_bcache): Don't declare.
8636         * psymtab.c (struct psymbol_bcache): Remove.
8637         (psymtab_storage::psymtab_storage): Update.
8638         (psymtab_storage::~psymtab_storage): Update.
8639         (psymbol_bcache_init, psymbol_bcache_free)
8640         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8641         (add_psymbol_to_bcache): Update.
8642         (allocate_psymtab): Update.
8643         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8644         macro_cache>: No longer pointers.
8645         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8646         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8647         * macrotab.c (macro_bcache): Update.
8648         * macroexp.c: Don't include bcache.h.
8649         * gdbtypes.c (check_types_worklist): Update.
8650         (types_deeply_equal): Remove TRY/CATCH.  Update.
8651         * elfread.c (elf_symtab_read): Update.
8652         * dwarf2read.c: Don't include bcache.h.
8653         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8654         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8655         (print_bcache_statistics, bcache_memory_used): Don't declare.
8656         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8657         methods.  Rename all data members.
8658         * bcache.c (struct bcache): Move to bcache.h.
8659         (bcache::expand_hash_table): Rename from expand_hash_table.
8660         (bcache): Remove.
8661         (bcache::insert): Rename from bcache_full.
8662         (bcache::compare): Rename from bcache_compare.
8663         (bcache_xmalloc): Remove.
8664         (bcache::~bcache): Rename from bcache_xfree.
8665         (bcache::print_statistics): Rename from print_bcache_statistics.
8666         (bcache::memory_used): Rename from bcache_memory_used.
8667
8668 2019-03-07  Pedro Alves  <palves@redhat.com>
8669
8670         * infrun.c (normal_stop): Also check for
8671         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8672
8673 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8674
8675         * f-lang.c (value_from_host_double): Moved to...
8676         * value.c (value_from_host_double): ...here.
8677         * value.h (value_from_host_double): Declare.
8678         * guile/scm-math.c (vlscm_convert_typed_number): Use
8679         value_from_host_double.
8680         (vlscm_convert_number): Likewise.
8681         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8682         * python/py-value.c (convert_value_from_python): Likewise.
8683
8684 2019-03-06  Tom Tromey  <tom@tromey.com>
8685
8686         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8687
8688 2019-03-06  Tom Tromey  <tom@tromey.com>
8689
8690         * utils.h (free_current_contents): Don't declare.
8691         * utils.c (free_current_contents): Remove.
8692
8693 2019-03-06  Tom Tromey  <tom@tromey.com>
8694
8695         * top.c (quit_force): Update.
8696         * main.c (captured_command_loop): Update.
8697         * common/new-op.c (operator new): Update.
8698         * common/common-exceptions.c (struct catcher)
8699         <save_cleanup_chain>: Remove member.
8700         (exceptions_state_mc_init): Update.
8701         (exception_try_scope_entry): Return nullptr.
8702         (exception_try_scope_exit, exception_rethrow)
8703         (throw_exception_sjlj, throw_exception_cxx): Update.
8704         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8705         (all_cleanups, do_cleanups, discard_cleanups)
8706         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8707         (restore_cleanups, restore_final_cleanups): Don't declare.
8708         (do_final_cleanups): Remove parameter.
8709         * common/cleanups.c (cleanup_chain, make_cleanup)
8710         (make_cleanup_dtor, all_cleanups, do_cleanups)
8711         (discard_my_cleanups, discard_cleanups)
8712         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8713         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8714         (null_cleanup): Remove.
8715         (do_final_cleanups): Remove parameter.
8716
8717 2019-03-06  Tom Tromey  <tom@tromey.com>
8718
8719         * remote.c (remote_target::remote_parse_stop_reply): Use
8720         unique_xmalloc_ptr.
8721
8722 2019-03-06  Tom Tromey  <tom@tromey.com>
8723
8724         * stabsread.c (struct stabs_field_info): Rename from field_info.
8725         <list, fnlist>: Add initializers.
8726         <obstack>: New member.
8727         (read_member_functions, read_struct_fields, read_baseclasses):
8728         Allocate on obstack.  Don't use cleanups.
8729         (read_one_struct_field, read_member_functions, read_struct_fields)
8730         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8731         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8732         (read_struct_type): Update.
8733
8734 2019-03-06  Tom Tromey  <tom@tromey.com>
8735
8736         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8737         * common/filestuff.h (make_cleanup_close): Don't declare.
8738         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8739         Remove.
8740
8741 2019-03-06  Tom Tromey  <tom@tromey.com>
8742
8743         * solib-aix.c: Use make_scope_exit.
8744
8745 2019-03-06  Tom Tromey  <tom@tromey.com>
8746
8747         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8748         Use make_scope_exit.
8749
8750 2019-03-06  Tom Tromey  <tom@tromey.com>
8751
8752         * solib-svr4.c (disable_probes_interface): Remove parameter.
8753         (svr4_handle_solib_event): Use make_scope_exit.
8754
8755 2019-03-06  Tom Tromey  <tom@tromey.com>
8756
8757         * remote.c (struct stop_reply_deleter): Remove.
8758         (stop_reply_up): Update.
8759         (struct stop_reply): Derive from notif_event.  Don't typedef.
8760         <regcache>: Now a std::vector.
8761         (stop_reply_xfree): Remove.
8762         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8763         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8764         (remote_target::discard_pending_stop_replies): Use delete.
8765         (remote_target::remote_parse_stop_reply): Update.
8766         (remote_target::process_stop_reply): Update.
8767         * remote-notif.h (struct notif_event): Add virtual destructor.
8768         Remove "dtr" member.
8769         (struct notif_client) <alloc_event>: Return a unique_ptr.
8770         (notif_event_xfree): Don't declare.
8771         (notif_event_up): New typedef.
8772         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8773         (notif_event_xfree, do_notif_event_xfree): Remove.
8774         (remote_notif_state_xfree): Update.
8775
8776 2019-03-06  Tom Tromey  <tom@tromey.com>
8777
8778         * infrun.c (displaced_step_clear_cleanup): Now a
8779         forward_scope_exit type.
8780         (displaced_step_prepare_throw): Update.
8781         (displaced_step_fixup): Update.
8782
8783 2019-03-06  Tom Tromey  <tom@tromey.com>
8784
8785         * inferior.h (class inferior): Update comment.
8786         * gdbthread.h (class thread_info): Update comment.
8787
8788 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8789             Tom Tromey  <tom@tromey.com>
8790
8791         * stabsread.h (struct stab_section_list): Remove.
8792         (coffstab_build_psymtabs): Update.
8793         * dbxread.c (symbuf_sections): Now a std::vector.
8794         (sect_idx): New global.
8795         (fill_symbuf): Update.
8796         (coffstab_build_psymtabs): Change type of stabsects parameter.
8797         Update.
8798         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8799         std::vector.
8800         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8801         (coff_locate_sections): Update.
8802         (coff_symfile_read): Remove cleanups.  Update.
8803         (init_stringtab): Add storage parameter.
8804         (free_stringtab, free_stringtab_cleanup): Remove.
8805         (init_lineno): Add storage parameter.
8806         (free_linetab, free_linetab_cleanup): Remove.
8807
8808 2019-03-06  Pedro Alves  <palves@redhat.com>
8809
8810         * linux-fork.c (fork_info::clobber_regs): Delete.
8811         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8812         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8813         comment.  Adjust.
8814         (scoped_switch_fork_info::scoped_switch_fork_info)
8815         (checkpoint_command, linux_fork_context): Adjust
8816         fork_save_infrun_state calls.
8817
8818 2019-03-06  Pedro Alves  <palves@redhat.com>
8819
8820         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8821         (inf_has_multiple_threads): Return 'bool' and rewrite using
8822         inferior_info::threads().
8823
8824 2019-03-06  Pedro Alves  <palves@redhat.com>
8825
8826         * linux-fork.c: Include <list>.
8827         (fork_list): Now a std::list instance.
8828         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8829         (forks_exist_p, find_last_fork): Adjust.
8830         (new_fork): Delete.
8831         (one_fork_p): New.
8832         (add_fork): Adjust.
8833         (free_fork): Delete, folded into fork_info::~fork_info().
8834         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8835         Adjust.
8836         (init_fork_list): Delete.
8837         (linux_fork_killall, linux_fork_mourn_inferior)
8838         (linux_fork_detach, info_checkpoints_command): Adjust.
8839         (_initialize_linux_fork): No longer call init_fork_list.
8840
8841 2019-03-06  Pedro Alves  <palves@redhat.com>
8842
8843         * linux-fork.c (new_fork): New, split out of ...
8844         (add_fork): ... this.  Return void.  Move "first fork" special
8845         case from here, to ...
8846         (checkpoint_command): ... here.
8847         * linux-linux.h (add_fork): Return void.
8848
8849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8852
8853 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8854             Chris January  <chris.january@arm.com>
8855             David Lecomber  <david.lecomber@arm.com>
8856
8857         * f-exp.y: New token, UNOP_INTRINSIC.
8858         (exp): New pattern using UNOP_INTRINSIC token.
8859         (f77_keywords): Add 'abs' keyword.
8860         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8861         (value_from_host_double): New function.
8862         (evaluate_subexp_f): Support UNOP_ABS.
8863
8864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8865
8866         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8867         types.
8868
8869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8870
8871         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8872         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8873         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8874
8875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8878
8879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8880             Chris January  <chris.january@arm.com>
8881
8882         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8883         * f-exp.y: Define 'KIND' token.
8884         (exp): New pattern for KIND expressions.
8885         (ptype): Handle types with a kind extension.
8886         (direct_abs_decl): Extend to spot kind extensions.
8887         (f77_keywords): Add 'kind' to the list.
8888         (push_kind_type): New function.
8889         (convert_to_kind_type): New function.
8890         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8891         * parse.c (operator_length_standard): Likewise.
8892         * parser-defs.h (enum type_pieces): Add tp_kind.
8893         * std-operator.def: Add UNOP_KIND.
8894
8895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * f-exp.y (f_parse): Set yydebug.
8898
8899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8900
8901         * f-lang.c (evaluate_subexp_f): New function.
8902         (exp_descriptor_f): New global.
8903         (f_language_defn): Use exp_descriptor_f instead of
8904         exp_descriptor_standard.
8905
8906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * f-exp.y (struct token): Add comments.
8909         (dot_ops): Remove uppercase versions and the end marker.
8910         (f77_keywords): Likewise.
8911         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8912         entries in the dot_ops array are case insensitive, and use
8913         strncasecmp to compare strings.  Also some whitespace cleanup in
8914         this area.  Similar for the f77_keywords array, except entries in
8915         this list might be case sensitive.
8916
8917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8918
8919         * f-exp.y (struct f77_boolean_val): Add comments.
8920         (boolean_values): Remove uppercase versions, and end marker.
8921         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8922         and use strncasecmp to achieve case insensitivity.  Additionally,
8923         perform whitespace cleanup around this code.
8924
8925 2019-03-06  Tom Tromey  <tromey@adacore.com>
8926
8927         * remote-sim.c (gdbsim_target_open): Use result of
8928         gdb_argv::release.
8929
8930 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8931         Dirk Schubert  <dirk.schubert@arm.com>
8932         Chris January  <chris.january@arm.com>
8933
8934         * eval.c (evaluate_subexp_standard): Call Fortran argument
8935         wrapping logic.
8936         * f-lang.c (struct value): A value which can be passed into a
8937         Fortran function call.
8938         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8939         where appropriate.
8940         (struct type): Value ready for a Fortran function call.
8941         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8942         is needed.
8943         * f-lang.h (fortran_argument_convert): Declaration.
8944         (fortran_preserve_arg_pointer): Declaration.
8945         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8946
8947 2019-03-05  Tom Tromey  <tromey@adacore.com>
8948
8949         * python/py-prettyprint.c (print_string_repr): Remove #if.
8950         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8951
8952 2019-03-05  Tom Tromey  <tromey@adacore.com>
8953
8954         * target.c (the_dummy_target): Move later.  Change type to
8955         "dummy_target".
8956         (initialize_targets): Don't initialize the_dummy_target.
8957
8958 2019-03-05  Tom Tromey  <tromey@adacore.com>
8959
8960         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8961         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8962
8963 2019-03-05  Tom Tromey  <tromey@adacore.com>
8964
8965         * windows-nat.c (windows_nat_target::attach)
8966         (windows_nat_target::detach): Don't call gdb_flush.
8967         * valprint.c (generic_val_print, val_print, val_print_string):
8968         Don't call gdb_flush.
8969         * utils.c (defaulted_query): Don't call gdb_flush.
8970         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8971         * target.c (target_announce_detach): Don't call gdb_flush.
8972         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8973         * remote.c (extended_remote_target::attach): Don't call
8974         gdb_flush.
8975         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8976         * printcmd.c (do_examine): Don't call gdb_flush.
8977         (info_display_command): Don't call gdb_flush.
8978         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8979         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8980         * memattr.c (info_mem_command): Don't call gdb_flush.
8981         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8982         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8983         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8984         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8985         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8986         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8987         (gnu_nat_target::detach): Don't call gdb_flush.
8988         * f-valprint.c (f_val_print): Don't call gdb_flush.
8989         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8990         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8991         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8992         gdb_flush.
8993         * c-valprint.c (c_val_print): Don't call gdb_flush.
8994         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8995
8996 2019-03-05  Tom Tromey  <tromey@adacore.com>
8997
8998         * varobj.c (update_dynamic_varobj_children): Update.
8999         (install_default_visualizer): Use reset, not release.
9000         * value.c (set_internalvar): Update.
9001         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9002         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9003         ATTRIBUTE_UNUSED_RESULT.
9004
9005 2019-03-05  Tom Tromey  <tromey@adacore.com>
9006
9007         * remote.c (class scoped_remote_fd) <release>: Add
9008         ATTRIBUTE_UNUSED_RESULT.
9009
9010 2019-03-05  Tom Tromey  <tromey@adacore.com>
9011
9012         * macroexp.c (struct macro_buffer) <release>: Add
9013         ATTRIBUTE_UNUSED_RESULT.
9014
9015 2019-03-05  Tom Tromey  <tromey@adacore.com>
9016
9017         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9018         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9019         ATTRIBUTE_UNUSED_RESULT.
9020
9021 2019-03-05  Tom Tromey  <tromey@adacore.com>
9022
9023         * common/scoped_fd.h (class scoped_fd) <release>: Add
9024         ATTRIBUTE_UNUSED_RESULT.
9025
9026 2019-03-05  Tom Tromey  <tromey@adacore.com>
9027
9028         * parser-defs.h (struct parser_state) <release>: Add
9029         ATTRIBUTE_UNUSED_RESULT.
9030
9031 2019-03-05  Tom Tromey  <tromey@adacore.com>
9032
9033         * utils.h (class gdb_argv) <release>: Add
9034         ATTRIBUTE_UNUSED_RESULT.
9035         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9036
9037 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9038
9039         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9040         for-loop range, to avoid compiler warnings.
9041
9042         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9043         avoid compiler warnings about unused variables.
9044
9045         * NEWS: Mention end of support for native debugging on MS-Windows
9046         before XP.
9047
9048         PR gdb/24292
9049         * common/netstuff.c:
9050         * gdbserver/gdbreplay.c
9051         * gdbserver/remote-utils.c:
9052         * ser-tcp.c:
9053         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9054         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9055         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9056         'getaddrinfo' and 'freeaddrinfo' were not available before
9057         Windows XP, and mingw.org's MinGW headers by default define
9058         _WIN32_WINNT to 0x500.
9059
9060 2019-03-01  Gary Benson <gbenson@redhat.com>
9061
9062         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9063
9064 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9065             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9066
9067         PR gdb/8527
9068         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9069         set_sigint_trap, clear_sigint_trap.
9070
9071 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9072
9073         * target.c (target_detach): Clear the regcache and the
9074         frame cache.
9075
9076 2019-02-27  Pedro Alves  <palves@redhat.com>
9077
9078         * utils.c (set_screen_size): When we cap the height/width sizes,
9079         tweak the corresponding command variable to show "unlimited":
9080
9081 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9082             Pedro Alves  <palves@redhat.com>
9083
9084         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9085         before calling rl_set_screen_size.
9086
9087 2019-02-27  Tom Tromey  <tromey@adacore.com>
9088
9089         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9090         define.
9091         * python/py-value.c: Remove Python 2.4 workaround.
9092         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9093         workaround.
9094         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9095         Python 2.4 workaround.
9096         * python/python-internal.h: Remove Python 2.4 comment.
9097         (Py_ssize_t): Don't define.
9098         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9099         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9100         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9101         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9102         * python/python.c (do_start_initialization): Remove Python 2.4
9103         workaround.
9104         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9105         (print_children): Remove Python 2.4 workaround.
9106         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9107         workaround.
9108         (CHARBUFFERPROC_NAME): Remove.
9109         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9110         Python 2.4 workaround.
9111
9112 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9113
9114         * NEWS: Note minimum Python version.
9115
9116 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9117
9118         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9119         code from these functions.  Remove corresponding ifdefs.  Use
9120         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9121         Remove gotos and target of gotos.
9122         (infpy_search_memory): Likewise.
9123
9124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9125
9126         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9127         (hppa_gdbarch_init): Don't register deleted functions with
9128         gdbarch.
9129
9130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9131
9132         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9133         (h8300_unwind_sp): Delete.
9134         (h8300_dummy_id): Delete.
9135         (h8300_gdbarch_init): Don't register deleted functions with
9136         gdbarch.
9137
9138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9139
9140         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9141         (ft32_unwind_pc): Delete.
9142         (ft32_unwind_sp): Delete.
9143         (ft32_gdbarch_init): Don't register deleted functions with
9144         gdbarch.
9145
9146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9147
9148         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9149         (frv_unwind_pc): Delete.
9150         (frv_unwind_sp): Delete.
9151         (frv_gdbarch_init): Don't register deleted functions with
9152         gdbarch.
9153
9154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9155
9156         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9157         (riscv_unwind_pc): Delete.
9158         (riscv_unwind_sp): Delete.
9159         (riscv_gdbarch_init): Don't register deleted functions with
9160         gdbarch.
9161
9162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9163
9164         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9165         (csky_unwind_pc): Delete.
9166         (csky_unwind_sp): Delete.
9167         (csky_gdbarch_init): Don't register deleted functions with
9168         gdbarch.
9169
9170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9171
9172         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9173         (cris_unwind_pc): Delete.
9174         (cris_unwind_sp): Delete.
9175         (cris_gdbarch_init): Don't register deleted functions with
9176         gdbarch.
9177
9178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9179
9180         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9181         (bfin_unwind_pc): Delete.
9182         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9183
9184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9187         (arm_unwind_pc): Delete.
9188         (arm_unwind_sp): Delete.
9189         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9190
9191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9194         (arc_unwind_pc): Delete.
9195         (arc_unwind_sp): Delete.
9196         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9197
9198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9201         (alpha_unwind_pc): Delete.
9202         (alpha_gdbarch_init): Don't register deleted functions with
9203         gdbarch.
9204
9205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9206
9207         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9208         (aarch64_unwind_pc): Delete.
9209         (aarch64_unwind_sp): Delete.
9210         (aarch64_gdbarch_init): Don't register deleted functions with
9211         gdbarch.
9212
9213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * gdbtypes.c (type_align): Don't consider static members when
9216         computing structure alignment.
9217
9218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9219
9220         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9221         return 0 for other types.
9222         * arch-utils.c (default_type_align): Always return 0.
9223         * gdbarch.h: Regenerate.
9224         * gdbarch.sh (type_align): Extend comment.
9225         * gdbtypes.c (type_align): Add additional comments, always call
9226         gdbarch_type_align before applying the default rules.
9227         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9228         generic code will then apply a suitable default.
9229         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9230         types, return 0 for other types.
9231
9232 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9233
9234         * NEWS: Create a new section for the next release branch.
9235         Rename the section of the current branch, now that it has
9236         been cut.
9237
9238 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9239
9240         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9241         * version.in: Bump version to 8.3.50.DATE-git.
9242
9243 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9244
9245         * aix-thread.c (ptid_cmp): Remove unused variable.
9246         (get_signaled_thread): Likewise.
9247         (store_regs_user_thread): Likewise.
9248         (store_regs_kernel_thread): Likewise.
9249         (fetch_regs_kernel_thread): Remove shadowed variable.
9250
9251 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * features/riscv/32bit-cpu.xml: Add register numbers.
9254         * features/riscv/32bit-fpu.c: Regenerate.
9255         * features/riscv/32bit-fpu.xml: Add register numbers.
9256         * features/riscv/64bit-cpu.xml: Add register numbers.
9257         * features/riscv/64bit-fpu.c: Regenerate.
9258         * features/riscv/64bit-fpu.xml: Add register numbers.
9259
9260 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9261
9262         * NEWS: Mention two argument form of gdb.Value constructor.
9263         * python/py-value.c (convert_buffer_and_type_to_value): New
9264         function.
9265         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9266         Add support for handling an optional second argument.  Call
9267         convert_buffer_and_type_to_value as appropriate.
9268         * python/python-internal.h (Py_buffer_deleter): New struct.
9269         (Py_buffer_up): New typedef.
9270
9271 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9272
9273         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9274         instead of releasing ownership.
9275
9276 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9277
9278         * dwarf2read.c (open_and_init_dwp_file): Call
9279         elf_numsections instead of bfd_count_sections to initialize
9280         dwp_file->num_sections.
9281
9282 2019-02-25  Tom Tromey  <tromey@adacore.com>
9283
9284         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9285
9286 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9287
9288         * gcore.in: Add '--readnever' option when invoking GDB.
9289
9290 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9291
9292         * MAINTAINERS: Update my email address.
9293
9294 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9295
9296         * build-id.c (build_id_to_debug_bfd_1): New function.
9297         (build_id_to_debug_bfd): Look for separate debug file in
9298         sysroot.
9299
9300 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * gdbarch.sh: Update the copyright year range that is placed into
9303         generated files.
9304
9305 2019-02-22  Keith Seitz  <keiths@redhat.com>
9306
9307         PR symtab/23853
9308         * linespec.c (create_sals_line_offset): Search for the default
9309         symtab's filename instead of its fullname.
9310
9311 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9312
9313         * NEWS: Update style defaults.
9314
9315 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9316
9317         * main.c (captured_main_1): Disable styling in batch mode.
9318
9319 2019-02-20  Tom Tromey  <tom@tromey.com>
9320
9321         * symtab.c (symtab_symbol_info): Fix typos.
9322
9323 2019-02-20  Tom Tromey  <tromey@adacore.com>
9324
9325         * findcmd.c (_initialize_mem_search): Use upper case for
9326         metasyntactic variables.
9327
9328 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9329
9330         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9331         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9332
9333 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9334
9335         * top.h (source_file_name): Change to std::string.
9336         * top.c (source_file_name): Likewise.
9337         (command_line_input): Adjust.
9338         * cli/cli-script.c (script_from_file): Adjust.
9339
9340 2019-02-19  Tom Tromey  <tromey@adacore.com>
9341
9342         * ravenscar-thread.c
9343         (ravenscar_thread_target::update_thread_list): Don't call
9344         ada_build_task_list.
9345         * ada-lang.h (ada_build_task_list): Don't declare.
9346         * ada-tasks.c (struct ada_tasks_inferior_data)
9347         <task_list_valid_p>: Now bool.
9348         (read_known_tasks, ada_task_list_changed)
9349         (ada_tasks_invalidate_inferior_data): Update.
9350         (read_known_tasks_array): Return bool.
9351         (read_known_tasks_list): Likewise.
9352         (read_known_tasks): Return void.
9353         (ada_build_task_list): Now static.
9354
9355 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9358         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9359
9360 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9361
9362         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9363         variant for ada_tasks_pspace_data_handle and
9364         ada_tasks_inferior_data_handle.
9365         (ada_tasks_pspace_data_cleanup): New function.
9366         (ada_tasks_inferior_data_cleanup): New function.
9367
9368 2019-02-17  Tom Tromey  <tom@tromey.com>
9369
9370         * macrotab.h (macro_source_fullname): Return a std::string.
9371         * macrotab.c (macro_include, check_for_redefinition)
9372         (macro_undef, macro_lookup_definition, foreach_macro)
9373         (foreach_macro_in_scope): Update.
9374         (macro_source_fullname): Return a std::string.
9375         * macrocmd.c (show_pp_source_pos): Update.
9376
9377 2019-02-17  Tom Tromey  <tom@tromey.com>
9378
9379         * macrocmd.c (show_pp_source_pos): Style the file names.
9380
9381 2019-02-17  Tom Tromey  <tom@tromey.com>
9382
9383         PR tui/24197:
9384         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9385
9386 2019-02-17  Tom Tromey  <tom@tromey.com>
9387
9388         * ada-lang.c (user_select_syms): Use filtered printing.
9389         * utils.c (wrap_style): New global.
9390         (desired_style): Remove.
9391         (emit_style_escape): Add stream parameter.
9392         (set_output_style, reset_terminal_style, prompt_for_continue):
9393         Update.
9394         (flush_wrap_buffer): Only flush gdb_stdout.
9395         (wrap_here): Set wrap_style.
9396         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9397         treat escape sequences as a character.  Change when wrap buffer is
9398         flushed.
9399         (fputs_styled): Do not set the output style when the default is
9400         requested.
9401         * ui-style.h (struct ui_file_style) <is_default>: New method.
9402         * source.c (print_source_lines_base): Emit escape sequences in one
9403         piece.
9404
9405 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9406
9407         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9408         integers and enumeration types.
9409
9410 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9411
9412         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9413         instead of lookup_symbol_in_language
9414         (do_exact_match): New function.
9415         (ada_get_symbol_name_matcher): Return do_exact_match when
9416         doing a verbatim match.
9417
9418 2019-02-15  Tom Tromey  <tromey@adacore.com>
9419
9420         * ravenscar-thread.c (ravenscar_thread_target::resume)
9421         (ravenscar_thread_target::wait): Special case wildcard requests.
9422
9423 2019-02-15  Tom Tromey  <tromey@adacore.com>
9424
9425         * ravenscar-thread.c (base_ptid): Remove.
9426         (struct ravenscar_thread_target) <close>: New method.
9427         <m_base_ptid>: New member.
9428         <update_inferior_ptid, active_task, task_is_currently_active,
9429         runtime_initialized>: Declare methods.
9430         <ravenscar_thread_target>: Add constructor.
9431         (ravenscar_thread_target::task_is_currently_active)
9432         (ravenscar_thread_target::update_inferior_ptid)
9433         (ravenscar_runtime_initialized): Rename.  Now methods.
9434         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9435         (ravenscar_thread_target::update_thread_list): Update.
9436         (ravenscar_thread_target::active_task): Now method.
9437         (ravenscar_thread_target::store_registers)
9438         (ravenscar_thread_target::prepare_to_store)
9439         (ravenscar_thread_target::prepare_to_store)
9440         (ravenscar_thread_target::mourn_inferior): Update.
9441         (ravenscar_inferior_created): Use "new" to create target.
9442         (ravenscar_thread_target::get_ada_task_ptid): Update.
9443         (_initialize_ravenscar): Don't initialize base_ptid.
9444         (ravenscar_ops): Remove global.
9445
9446 2019-02-15  Tom Tromey  <tromey@adacore.com>
9447
9448         * target.h (push_target): Declare new overload.
9449         * target.c (push_target): New overload, taking an rvalue reference.
9450         * remote.c (remote_target::open_1): Use push_target overload.
9451         * corelow.c (core_target_open): Use push_target overload.
9452
9453 2019-02-15  Tom Tromey  <tromey@adacore.com>
9454
9455         * ravenscar-thread.c (is_ravenscar_task)
9456         (ravenscar_task_is_currently_active): Return bool.
9457         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9458         (_initialize_ravenscar): Remove "(void)".
9459         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9460         Return bool.
9461
9462 2019-02-15  Tom Tromey  <tromey@adacore.com>
9463
9464         * ravenscar-thread.c (ravenscar_runtime_initializer)
9465         (has_ravenscar_runtime, get_running_thread_id)
9466         (ravenscar_thread_target::resume): Fix indentation.
9467
9468 2019-02-15  Tom Tromey  <tromey@adacore.com>
9469
9470         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9471         from ravenscar_arch_ops.
9472         (sparc_ravenscar_ops::fetch_registers)
9473         (sparc_ravenscar_ops::store_registers): Now methods.
9474         (sparc_ravenscar_prepare_to_store): Remove.
9475         (sparc_ravenscar_ops): Redefine.
9476         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9477         methods and destructor.  Remove members.
9478         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9479         (ravenscar_thread_target::store_registers)
9480         (ravenscar_thread_target::prepare_to_store): Update.
9481         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9482         Remove.
9483         (struct ppc_ravenscar_powerpc_ops): Derive from
9484         ravenscar_arch_ops.
9485         (ppc_ravenscar_powerpc_ops::fetch_registers)
9486         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9487         (ppc_ravenscar_powerpc_ops): Redefine.
9488         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9489         (ppc_ravenscar_e500_ops::fetch_registers)
9490         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9491         (ppc_ravenscar_e500_ops): Redefine.
9492         * aarch64-ravenscar-thread.c
9493         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9494         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9495         (aarch64_ravenscar_fetch_registers)
9496         (aarch64_ravenscar_store_registers): Now methods.
9497         (aarch64_ravenscar_ops): Redefine.
9498
9499 2019-02-15  Tom Tromey  <tromey@adacore.com>
9500
9501         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9502         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9503         (ravenscar_thread_target::stopped_by_watchpoint)
9504         (ravenscar_thread_target::stopped_data_address)
9505         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9506
9507 2019-02-15  Tom Tromey  <tromey@adacore.com>
9508
9509         * ravenscar-thread.c: Fix some typos.
9510
9511 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9512             Tom Tromey  <tromey@adacore.com>
9513
9514         * ada-lang.c (ada_exception_sal): Change addr_string to a
9515         std::string.
9516         (create_ada_exception_catchpoint): Update.
9517
9518 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9519             Tom Tromey  <tromey@adacore.com>
9520
9521         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9522         (bp_location_ops): Remove.
9523         (base_breakpoint_allocate_location): Update.
9524         (free_bp_location): Update.
9525         * ada-lang.c (class ada_catchpoint_location)
9526         <ada_catchpoint_location>: Remove ops parameter.
9527         (ada_catchpoint_location_dtor): Remove.
9528         (ada_catchpoint_location_ops): Remove.
9529         (allocate_location_exception): Update.
9530         * breakpoint.h (struct bp_location_ops): Remove.
9531         (class bp_location) <bp_location>: Remove bp_location_ops
9532         parameter.
9533         <~bp_location>: Add destructor.
9534         <ops>: Remove.
9535
9536 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9537             Pedro Alves  <palves@redhat.com>
9538
9539         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9540         'PATH_MAX'.
9541
9542 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9543             Samuel Thibault  <samuel.thibault@gnu.org>
9544             Thomas Schwinge  <thomas@codesourcery.com>
9545
9546         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9547         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9548
9549 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9550
9551         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9552         (check_empty): Use "const char *".
9553
9554         * gnu-nat.c (gnu_nat_target::detach): Instead of
9555         'detach_inferior (pid)' call
9556         'detach_inferior (find_inferior_pid (pid))'.
9557
9558         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9559         'nat/fork-inferior.o'.
9560         * gnu-nat.c: #include "nat/fork-inferior.h".
9561
9562         * gnu-nat.c (gnu_nat_target::detach): Instead of
9563         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9564         * gnu-nat.h: #include "inf-child.h".
9565         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9566         'i386_gnu_nat_target::fetch_registers'.
9567         (gnu_store_registers): Rename/move to
9568         'i386_gnu_nat_target::store_registers'.
9569
9570         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9571         * gnu-nat.h (mach_thread_info): New function.
9572         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9573
9574         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9575
9576 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9577
9578         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9579
9580 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9581
9582         * windows-nat.c (windows_add_thread): Add new parameter
9583         "main_thread_p" with default value set to false.  Update
9584         function documentation as well as all callers.
9585         (windows_delete_thread): Likewise.
9586         (fake_create_process): Update call to windows_add_thread.
9587         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9588         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9589         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9590         call to windows_delete_thread.
9591
9592 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9593
9594         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9595
9596 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9597
9598         * symfile.c (find_separate_debug_file): Use canonical path of
9599         sysroot with child_path instead of gdb_sysroot if it is valid.
9600
9601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9602
9603         * symfile.c (find_separate_debug_file): Use child_path to
9604         determine if an object file is under a sysroot.
9605
9606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9607
9608         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9609         unittests/child-path-selftests.c.
9610         * common/pathstuff.c (child_path): New function.
9611         * common/pathstuff.h (child_path): New prototype.
9612         * unittests/child-path-selftests.c: New file.
9613
9614 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9615
9616         * symfile.c (find_separate_debug_file): Look for separate debug
9617         files in debug directories under the sysroot.
9618
9619 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9620
9621         * symtab.h (struct minimal_symbol data_p): New const method.
9622         (struct minimal_symbol text_p): Likewise.
9623         * symtab.c (output_source_filename): Use file name style
9624         to print file name.
9625         (print_symbol_info): Likewise.
9626         (print_msymbol_info): Use address style to print addresses.
9627         Use function name style to print executable text symbols.
9628         (expand_symtab_containing_pc): Use data_p.
9629         (find_pc_sect_compunit_symtab): Likewise.
9630
9631 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9632
9633         * breakpoint.c (describe_other_breakpoints): Use address style
9634         to print addresses.
9635         (say_where): Likewise.
9636
9637 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9638
9639         * ada-typeprint.c (print_func_type): Print function name
9640         style to print function name.
9641         * c-typeprint.c (c_print_type_1): Likewise.
9642
9643 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9644
9645         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9646         for execve.
9647
9648 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9649
9650         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9651         type_stack.
9652
9653 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9654
9655         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9656         TYPE_CODE_REF types.
9657
9658 2019-02-08  Jim Wilson  <jimw@sifive.com>
9659
9660         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9661         (riscv_linux_fregset): New.
9662         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9663
9664 2019-02-07  Tom Tromey  <tom@tromey.com>
9665
9666         * thread.c (thread_cancel_execution_command): Update.
9667         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9668         methods.
9669         (struct thread_fsm_ops): Remove.
9670         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9671         (thread_fsm_should_stop, thread_fsm_return_value)
9672         (thread_fsm_set_finished, thread_fsm_finished_p)
9673         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9674         Don't declare.
9675         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9676         * infrun.c (clear_proceed_status_thread)
9677         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9678         (print_stop_event): Update.
9679         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9680         Add constructor.
9681         (step_command_fsm_ops): Remove.
9682         (new_step_command_fsm): Remove.
9683         (step_1): Update.
9684         (step_command_fsm::should_stop): Rename from
9685         step_command_fsm_should_stop.
9686         (step_command_fsm::clean_up): Rename from
9687         step_command_fsm_clean_up.
9688         (step_command_fsm::do_async_reply_reason): Rename from
9689         step_command_fsm_async_reply_reason.
9690         (struct until_next_fsm): Inherit from thread_fsm.  Add
9691         constructor.
9692         (until_next_fsm_ops): Remove.
9693         (new_until_next_fsm): Remove.
9694         (until_next_fsm::should_stop): Rename from
9695         until_next_fsm_should_stop.
9696         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9697         (until_next_fsm::do_async_reply_reason): Rename from
9698         until_next_fsm_async_reply_reason.
9699         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9700         constructor.  Change type of breakpoint.
9701         (finish_command_fsm_ops): Remove.
9702         (new_finish_command_fsm): Remove.
9703         (finish_command_fsm::should_stop): Rename from
9704         finish_command_fsm_should_stop.
9705         (finish_command_fsm::clean_up): Rename from
9706         finish_command_fsm_clean_up.
9707         (finish_command_fsm::return_value): Rename from
9708         finish_command_fsm_return_value.
9709         (finish_command_fsm::do_async_reply_reason): Rename from
9710         finish_command_fsm_async_reply_reason.
9711         (finish_command): Update.
9712         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9713         Add constructor.
9714         (call_thread_fsm_ops): Remove.
9715         (call_thread_fsm::call_thread_fsm): Rename from
9716         new_call_thread_fsm.
9717         (call_thread_fsm::should_stop): Rename from
9718         call_thread_fsm_should_stop.
9719         (call_thread_fsm::should_notify_stop): Rename from
9720         call_thread_fsm_should_notify_stop.
9721         (run_inferior_call, call_function_by_hand_dummy): Update.
9722         * cli/cli-interp.c (should_print_stop_to_console): Update.
9723         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9724         Add constructor.  Change type of location_breakpoint,
9725         caller_breakpoint.
9726         (until_break_fsm_ops): Remove.
9727         (new_until_break_fsm): Remove.
9728         (until_break_fsm::should_stop): Rename from
9729         until_break_fsm_should_stop.
9730         (until_break_fsm::clean_up): Rename from
9731         until_break_fsm_clean_up.
9732         (until_break_fsm::do_async_reply_reason): Rename from
9733         until_break_fsm_async_reply_reason.
9734         (until_break_command): Update.
9735         * thread-fsm.c: Remove.
9736         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9737
9738 2019-02-07  Tom Tromey  <tom@tromey.com>
9739
9740         * yy-remap.h: Add include guard.
9741         * xtensa-tdep.h: Add include guard.
9742         * xcoffread.h: Rename include guard.
9743         * varobj-iter.h: Add include guard.
9744         * tui/tui.h: Rename include guard.
9745         * tui/tui-winsource.h: Rename include guard.
9746         * tui/tui-wingeneral.h: Rename include guard.
9747         * tui/tui-windata.h: Rename include guard.
9748         * tui/tui-win.h: Rename include guard.
9749         * tui/tui-stack.h: Rename include guard.
9750         * tui/tui-source.h: Rename include guard.
9751         * tui/tui-regs.h: Rename include guard.
9752         * tui/tui-out.h: Rename include guard.
9753         * tui/tui-layout.h: Rename include guard.
9754         * tui/tui-io.h: Rename include guard.
9755         * tui/tui-hooks.h: Rename include guard.
9756         * tui/tui-file.h: Rename include guard.
9757         * tui/tui-disasm.h: Rename include guard.
9758         * tui/tui-data.h: Rename include guard.
9759         * tui/tui-command.h: Rename include guard.
9760         * tic6x-tdep.h: Add include guard.
9761         * target/waitstatus.h: Rename include guard.
9762         * target/wait.h: Rename include guard.
9763         * target/target.h: Rename include guard.
9764         * target/resume.h: Rename include guard.
9765         * target-float.h: Rename include guard.
9766         * stabsread.h: Add include guard.
9767         * rs6000-tdep.h: Add include guard.
9768         * riscv-fbsd-tdep.h: Add include guard.
9769         * regformats/regdef.h: Rename include guard.
9770         * record.h: Rename include guard.
9771         * python/python.h: Rename include guard.
9772         * python/python-internal.h: Rename include guard.
9773         * python/py-stopevent.h: Rename include guard.
9774         * python/py-ref.h: Rename include guard.
9775         * python/py-record.h: Rename include guard.
9776         * python/py-record-full.h: Rename include guard.
9777         * python/py-record-btrace.h: Rename include guard.
9778         * python/py-instruction.h: Rename include guard.
9779         * python/py-events.h: Rename include guard.
9780         * python/py-event.h: Rename include guard.
9781         * procfs.h: Add include guard.
9782         * proc-utils.h: Add include guard.
9783         * p-lang.h: Add include guard.
9784         * or1k-tdep.h: Rename include guard.
9785         * observable.h: Rename include guard.
9786         * nto-tdep.h: Rename include guard.
9787         * nat/x86-linux.h: Rename include guard.
9788         * nat/x86-linux-dregs.h: Rename include guard.
9789         * nat/x86-gcc-cpuid.h: Add include guard.
9790         * nat/x86-dregs.h: Rename include guard.
9791         * nat/x86-cpuid.h: Rename include guard.
9792         * nat/ppc-linux.h: Rename include guard.
9793         * nat/mips-linux-watch.h: Rename include guard.
9794         * nat/linux-waitpid.h: Rename include guard.
9795         * nat/linux-ptrace.h: Rename include guard.
9796         * nat/linux-procfs.h: Rename include guard.
9797         * nat/linux-osdata.h: Rename include guard.
9798         * nat/linux-nat.h: Rename include guard.
9799         * nat/linux-namespaces.h: Rename include guard.
9800         * nat/linux-btrace.h: Rename include guard.
9801         * nat/glibc_thread_db.h: Rename include guard.
9802         * nat/gdb_thread_db.h: Rename include guard.
9803         * nat/gdb_ptrace.h: Rename include guard.
9804         * nat/fork-inferior.h: Rename include guard.
9805         * nat/amd64-linux-siginfo.h: Rename include guard.
9806         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9807         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9808         * nat/aarch64-linux.h: Rename include guard.
9809         * nat/aarch64-linux-hw-point.h: Rename include guard.
9810         * mn10300-tdep.h: Add include guard.
9811         * mips-linux-tdep.h: Add include guard.
9812         * mi/mi-parse.h: Rename include guard.
9813         * mi/mi-out.h: Rename include guard.
9814         * mi/mi-main.h: Rename include guard.
9815         * mi/mi-interp.h: Rename include guard.
9816         * mi/mi-getopt.h: Rename include guard.
9817         * mi/mi-console.h: Rename include guard.
9818         * mi/mi-common.h: Rename include guard.
9819         * mi/mi-cmds.h: Rename include guard.
9820         * mi/mi-cmd-break.h: Rename include guard.
9821         * m2-lang.h: Add include guard.
9822         * location.h: Rename include guard.
9823         * linux-record.h: Rename include guard.
9824         * linux-nat.h: Add include guard.
9825         * linux-fork.h: Add include guard.
9826         * i386-darwin-tdep.h: Rename include guard.
9827         * hppa-linux-offsets.h: Add include guard.
9828         * guile/guile.h: Rename include guard.
9829         * guile/guile-internal.h: Rename include guard.
9830         * gnu-nat.h: Rename include guard.
9831         * gdb-stabs.h: Rename include guard.
9832         * frv-tdep.h: Add include guard.
9833         * f-lang.h: Add include guard.
9834         * event-loop.h: Add include guard.
9835         * darwin-nat.h: Rename include guard.
9836         * cp-abi.h: Rename include guard.
9837         * config/sparc/nm-sol2.h: Rename include guard.
9838         * config/nm-nto.h: Rename include guard.
9839         * config/nm-linux.h: Add include guard.
9840         * config/i386/nm-i386gnu.h: Rename include guard.
9841         * config/djgpp/nl_types.h: Rename include guard.
9842         * config/djgpp/langinfo.h: Rename include guard.
9843         * compile/gcc-cp-plugin.h: Add include guard.
9844         * compile/gcc-c-plugin.h: Add include guard.
9845         * compile/compile.h: Rename include guard.
9846         * compile/compile-object-run.h: Rename include guard.
9847         * compile/compile-object-load.h: Rename include guard.
9848         * compile/compile-internal.h: Rename include guard.
9849         * compile/compile-cplus.h: Rename include guard.
9850         * compile/compile-c.h: Rename include guard.
9851         * common/xml-utils.h: Rename include guard.
9852         * common/x86-xstate.h: Rename include guard.
9853         * common/version.h: Rename include guard.
9854         * common/vec.h: Rename include guard.
9855         * common/tdesc.h: Rename include guard.
9856         * common/selftest.h: Rename include guard.
9857         * common/scoped_restore.h: Rename include guard.
9858         * common/scoped_mmap.h: Rename include guard.
9859         * common/scoped_fd.h: Rename include guard.
9860         * common/safe-iterator.h: Rename include guard.
9861         * common/run-time-clock.h: Rename include guard.
9862         * common/refcounted-object.h: Rename include guard.
9863         * common/queue.h: Rename include guard.
9864         * common/ptid.h: Rename include guard.
9865         * common/print-utils.h: Rename include guard.
9866         * common/preprocessor.h: Rename include guard.
9867         * common/pathstuff.h: Rename include guard.
9868         * common/observable.h: Rename include guard.
9869         * common/netstuff.h: Rename include guard.
9870         * common/job-control.h: Rename include guard.
9871         * common/host-defs.h: Rename include guard.
9872         * common/gdb_wait.h: Rename include guard.
9873         * common/gdb_vecs.h: Rename include guard.
9874         * common/gdb_unlinker.h: Rename include guard.
9875         * common/gdb_unique_ptr.h: Rename include guard.
9876         * common/gdb_tilde_expand.h: Rename include guard.
9877         * common/gdb_sys_time.h: Rename include guard.
9878         * common/gdb_string_view.h: Rename include guard.
9879         * common/gdb_splay_tree.h: Rename include guard.
9880         * common/gdb_setjmp.h: Rename include guard.
9881         * common/gdb_ref_ptr.h: Rename include guard.
9882         * common/gdb_optional.h: Rename include guard.
9883         * common/gdb_locale.h: Rename include guard.
9884         * common/gdb_assert.h: Rename include guard.
9885         * common/filtered-iterator.h: Rename include guard.
9886         * common/filestuff.h: Rename include guard.
9887         * common/fileio.h: Rename include guard.
9888         * common/environ.h: Rename include guard.
9889         * common/common-utils.h: Rename include guard.
9890         * common/common-types.h: Rename include guard.
9891         * common/common-regcache.h: Rename include guard.
9892         * common/common-inferior.h: Rename include guard.
9893         * common/common-gdbthread.h: Rename include guard.
9894         * common/common-exceptions.h: Rename include guard.
9895         * common/common-defs.h: Rename include guard.
9896         * common/common-debug.h: Rename include guard.
9897         * common/cleanups.h: Rename include guard.
9898         * common/buffer.h: Rename include guard.
9899         * common/btrace-common.h: Rename include guard.
9900         * common/break-common.h: Rename include guard.
9901         * cli/cli-utils.h: Rename include guard.
9902         * cli/cli-style.h: Rename include guard.
9903         * cli/cli-setshow.h: Rename include guard.
9904         * cli/cli-script.h: Rename include guard.
9905         * cli/cli-interp.h: Rename include guard.
9906         * cli/cli-decode.h: Rename include guard.
9907         * cli/cli-cmds.h: Rename include guard.
9908         * charset-list.h: Add include guard.
9909         * buildsym-legacy.h: Rename include guard.
9910         * bfin-tdep.h: Add include guard.
9911         * ax.h: Rename include guard.
9912         * arm-linux-tdep.h: Add include guard.
9913         * arm-fbsd-tdep.h: Add include guard.
9914         * arch/xtensa.h: Rename include guard.
9915         * arch/tic6x.h: Add include guard.
9916         * arch/i386.h: Add include guard.
9917         * arch/arm.h: Rename include guard.
9918         * arch/arm-linux.h: Rename include guard.
9919         * arch/arm-get-next-pcs.h: Rename include guard.
9920         * arch/amd64.h: Add include guard.
9921         * arch/aarch64-insn.h: Rename include guard.
9922         * arch-utils.h: Rename include guard.
9923         * annotate.h: Add include guard.
9924         * amd64-darwin-tdep.h: Rename include guard.
9925         * aarch64-linux-tdep.h: Add include guard.
9926         * aarch64-fbsd-tdep.h: Add include guard.
9927         * aarch32-linux-nat.h: Add include guard.
9928
9929 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9930
9931         * macrotab.c (macro_define_internal): New function that
9932         factorizes macro_define_object_internal and macro_define_function
9933         code.
9934         (macro_define_object_internal): Use macro_define_internal.
9935         (macro_define_function): Likewise.
9936
9937 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9938
9939         * macrocmd.c (extract_identifier): Return
9940         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9941         callers.
9942
9943 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9944
9945         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9946
9947 2019-02-05  Tom Tromey  <tom@tromey.com>
9948
9949         * target.c (target_stack::unpush): Move assertion earlier.
9950
9951 2019-01-30  Tom Tromey  <tom@tromey.com>
9952
9953         PR python/23615:
9954         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9955         (gdbpy_parse_and_eval): Likewise.
9956         * python/python-internal.h (gdbpy_allow_threads): New class.
9957
9958 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9959
9960         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9961         (aarch64_fbsd_fpregmap): Move earlier.
9962         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9963         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9964         instead of individual calls to trad_frame_set_reg_addr.
9965         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9966         earlier.
9967         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9968         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9969         instead of individual calls to trad_frame_set_reg_addr.
9970
9971 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9972
9973         * CONTRIBUTE: Replace contribution list with wiki link.
9974
9975 2019-01-25  Tom Tromey  <tom@tromey.com>
9976
9977         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9978
9979 2019-01-25  Tom Tromey  <tom@tromey.com>
9980
9981         * xtensa-linux-nat.c: Fix common/ includes.
9982         * xml-support.h: Fix common/ includes.
9983         * xml-support.c: Fix common/ includes.
9984         * x86-linux-nat.c: Fix common/ includes.
9985         * windows-nat.c: Fix common/ includes.
9986         * varobj.h: Fix common/ includes.
9987         * varobj.c: Fix common/ includes.
9988         * value.c: Fix common/ includes.
9989         * valops.c: Fix common/ includes.
9990         * utils.c: Fix common/ includes.
9991         * unittests/xml-utils-selftests.c: Fix common/ includes.
9992         * unittests/utils-selftests.c: Fix common/ includes.
9993         * unittests/unpack-selftests.c: Fix common/ includes.
9994         * unittests/tracepoint-selftests.c: Fix common/ includes.
9995         * unittests/style-selftests.c: Fix common/ includes.
9996         * unittests/string_view-selftests.c: Fix common/ includes.
9997         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9998         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9999         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10000         * unittests/rsp-low-selftests.c: Fix common/ includes.
10001         * unittests/parse-connection-spec-selftests.c: Fix common/
10002         includes.
10003         * unittests/optional-selftests.c: Fix common/ includes.
10004         * unittests/offset-type-selftests.c: Fix common/ includes.
10005         * unittests/observable-selftests.c: Fix common/ includes.
10006         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10007         * unittests/memrange-selftests.c: Fix common/ includes.
10008         * unittests/memory-map-selftests.c: Fix common/ includes.
10009         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10010         * unittests/function-view-selftests.c: Fix common/ includes.
10011         * unittests/environ-selftests.c: Fix common/ includes.
10012         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10013         * unittests/common-utils-selftests.c: Fix common/ includes.
10014         * unittests/cli-utils-selftests.c: Fix common/ includes.
10015         * unittests/array-view-selftests.c: Fix common/ includes.
10016         * ui-file.c: Fix common/ includes.
10017         * tui/tui-io.c: Fix common/ includes.
10018         * tracepoint.h: Fix common/ includes.
10019         * tracepoint.c: Fix common/ includes.
10020         * tracefile-tfile.c: Fix common/ includes.
10021         * top.h: Fix common/ includes.
10022         * top.c: Fix common/ includes.
10023         * thread.c: Fix common/ includes.
10024         * target/waitstatus.h: Fix common/ includes.
10025         * target/waitstatus.c: Fix common/ includes.
10026         * target.h: Fix common/ includes.
10027         * target.c: Fix common/ includes.
10028         * target-memory.c: Fix common/ includes.
10029         * target-descriptions.c: Fix common/ includes.
10030         * symtab.h: Fix common/ includes.
10031         * symfile.c: Fix common/ includes.
10032         * stap-probe.c: Fix common/ includes.
10033         * spu-linux-nat.c: Fix common/ includes.
10034         * sparc-nat.c: Fix common/ includes.
10035         * source.c: Fix common/ includes.
10036         * solib.c: Fix common/ includes.
10037         * solib-target.c: Fix common/ includes.
10038         * ser-unix.c: Fix common/ includes.
10039         * ser-tcp.c: Fix common/ includes.
10040         * ser-pipe.c: Fix common/ includes.
10041         * ser-base.c: Fix common/ includes.
10042         * selftest-arch.c: Fix common/ includes.
10043         * s12z-tdep.c: Fix common/ includes.
10044         * rust-exp.y: Fix common/ includes.
10045         * rs6000-aix-tdep.c: Fix common/ includes.
10046         * riscv-tdep.c: Fix common/ includes.
10047         * remote.c: Fix common/ includes.
10048         * remote-notif.h: Fix common/ includes.
10049         * remote-fileio.h: Fix common/ includes.
10050         * remote-fileio.c: Fix common/ includes.
10051         * regcache.h: Fix common/ includes.
10052         * regcache.c: Fix common/ includes.
10053         * record-btrace.c: Fix common/ includes.
10054         * python/python.c: Fix common/ includes.
10055         * python/py-type.c: Fix common/ includes.
10056         * python/py-inferior.c: Fix common/ includes.
10057         * progspace.h: Fix common/ includes.
10058         * producer.c: Fix common/ includes.
10059         * procfs.c: Fix common/ includes.
10060         * proc-api.c: Fix common/ includes.
10061         * printcmd.c: Fix common/ includes.
10062         * ppc-linux-nat.c: Fix common/ includes.
10063         * parser-defs.h: Fix common/ includes.
10064         * osdata.c: Fix common/ includes.
10065         * obsd-nat.c: Fix common/ includes.
10066         * nat/x86-linux.c: Fix common/ includes.
10067         * nat/x86-linux-dregs.c: Fix common/ includes.
10068         * nat/x86-dregs.h: Fix common/ includes.
10069         * nat/x86-dregs.c: Fix common/ includes.
10070         * nat/ppc-linux.c: Fix common/ includes.
10071         * nat/mips-linux-watch.h: Fix common/ includes.
10072         * nat/mips-linux-watch.c: Fix common/ includes.
10073         * nat/linux-waitpid.c: Fix common/ includes.
10074         * nat/linux-ptrace.h: Fix common/ includes.
10075         * nat/linux-ptrace.c: Fix common/ includes.
10076         * nat/linux-procfs.c: Fix common/ includes.
10077         * nat/linux-personality.c: Fix common/ includes.
10078         * nat/linux-osdata.c: Fix common/ includes.
10079         * nat/linux-namespaces.c: Fix common/ includes.
10080         * nat/linux-btrace.h: Fix common/ includes.
10081         * nat/linux-btrace.c: Fix common/ includes.
10082         * nat/fork-inferior.c: Fix common/ includes.
10083         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10084         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10085         * nat/aarch64-linux.c: Fix common/ includes.
10086         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10087         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10088         * namespace.h: Fix common/ includes.
10089         * mips-linux-tdep.c: Fix common/ includes.
10090         * minsyms.c: Fix common/ includes.
10091         * mi/mi-parse.h: Fix common/ includes.
10092         * mi/mi-main.c: Fix common/ includes.
10093         * mi/mi-cmd-env.c: Fix common/ includes.
10094         * memrange.h: Fix common/ includes.
10095         * memattr.c: Fix common/ includes.
10096         * maint.h: Fix common/ includes.
10097         * maint.c: Fix common/ includes.
10098         * main.c: Fix common/ includes.
10099         * machoread.c: Fix common/ includes.
10100         * location.c: Fix common/ includes.
10101         * linux-thread-db.c: Fix common/ includes.
10102         * linux-nat.c: Fix common/ includes.
10103         * linux-fork.c: Fix common/ includes.
10104         * inline-frame.c: Fix common/ includes.
10105         * infrun.c: Fix common/ includes.
10106         * inflow.c: Fix common/ includes.
10107         * inferior.h: Fix common/ includes.
10108         * inferior.c: Fix common/ includes.
10109         * infcmd.c: Fix common/ includes.
10110         * inf-ptrace.c: Fix common/ includes.
10111         * inf-child.c: Fix common/ includes.
10112         * ia64-linux-nat.c: Fix common/ includes.
10113         * i387-tdep.c: Fix common/ includes.
10114         * i386-tdep.c: Fix common/ includes.
10115         * i386-linux-tdep.c: Fix common/ includes.
10116         * i386-linux-nat.c: Fix common/ includes.
10117         * i386-go32-tdep.c: Fix common/ includes.
10118         * i386-fbsd-tdep.c: Fix common/ includes.
10119         * i386-fbsd-nat.c: Fix common/ includes.
10120         * guile/scm-type.c: Fix common/ includes.
10121         * guile/guile.c: Fix common/ includes.
10122         * go32-nat.c: Fix common/ includes.
10123         * gnu-nat.c: Fix common/ includes.
10124         * gdbthread.h: Fix common/ includes.
10125         * gdbarch-selftests.c: Fix common/ includes.
10126         * gdb_usleep.c: Fix common/ includes.
10127         * gdb_select.h: Fix common/ includes.
10128         * gdb_bfd.c: Fix common/ includes.
10129         * gcore.c: Fix common/ includes.
10130         * fork-child.c: Fix common/ includes.
10131         * findvar.c: Fix common/ includes.
10132         * fbsd-nat.c: Fix common/ includes.
10133         * event-top.c: Fix common/ includes.
10134         * event-loop.c: Fix common/ includes.
10135         * dwarf2read.c: Fix common/ includes.
10136         * dwarf2loc.c: Fix common/ includes.
10137         * dwarf2-frame.c: Fix common/ includes.
10138         * dwarf-index-cache.c: Fix common/ includes.
10139         * dtrace-probe.c: Fix common/ includes.
10140         * disasm-selftests.c: Fix common/ includes.
10141         * defs.h: Fix common/ includes.
10142         * csky-tdep.c: Fix common/ includes.
10143         * cp-valprint.c: Fix common/ includes.
10144         * cp-support.h: Fix common/ includes.
10145         * cp-support.c: Fix common/ includes.
10146         * corelow.c: Fix common/ includes.
10147         * completer.h: Fix common/ includes.
10148         * completer.c: Fix common/ includes.
10149         * compile/compile.c: Fix common/ includes.
10150         * compile/compile-loc2c.c: Fix common/ includes.
10151         * compile/compile-cplus-types.c: Fix common/ includes.
10152         * compile/compile-cplus-symbols.c: Fix common/ includes.
10153         * command.h: Fix common/ includes.
10154         * cli/cli-dump.c: Fix common/ includes.
10155         * cli/cli-cmds.c: Fix common/ includes.
10156         * charset.c: Fix common/ includes.
10157         * build-id.c: Fix common/ includes.
10158         * btrace.h: Fix common/ includes.
10159         * btrace.c: Fix common/ includes.
10160         * breakpoint.h: Fix common/ includes.
10161         * breakpoint.c: Fix common/ includes.
10162         * ax.h:
10163         (enum agent_op): Fix common/ includes.
10164         * ax-general.c (struct aop_map): Fix common/ includes.
10165         * ax-gdb.c: Fix common/ includes.
10166         * auxv.c: Fix common/ includes.
10167         * auto-load.c: Fix common/ includes.
10168         * arm-tdep.c: Fix common/ includes.
10169         * arch/riscv.c: Fix common/ includes.
10170         * arch/ppc-linux-common.c: Fix common/ includes.
10171         * arch/i386.c: Fix common/ includes.
10172         * arch/arm.c: Fix common/ includes.
10173         * arch/arm-linux.c: Fix common/ includes.
10174         * arch/arm-get-next-pcs.c: Fix common/ includes.
10175         * arch/amd64.c: Fix common/ includes.
10176         * arch/aarch64.c: Fix common/ includes.
10177         * arch/aarch64-insn.c: Fix common/ includes.
10178         * arch-utils.c: Fix common/ includes.
10179         * amd64-windows-tdep.c: Fix common/ includes.
10180         * amd64-tdep.c: Fix common/ includes.
10181         * amd64-sol2-tdep.c: Fix common/ includes.
10182         * amd64-obsd-tdep.c: Fix common/ includes.
10183         * amd64-nbsd-tdep.c: Fix common/ includes.
10184         * amd64-linux-tdep.c: Fix common/ includes.
10185         * amd64-linux-nat.c: Fix common/ includes.
10186         * amd64-fbsd-tdep.c: Fix common/ includes.
10187         * amd64-fbsd-nat.c: Fix common/ includes.
10188         * amd64-dicos-tdep.c: Fix common/ includes.
10189         * amd64-darwin-tdep.c: Fix common/ includes.
10190         * agent.c: Fix common/ includes.
10191         * ada-lang.h: Fix common/ includes.
10192         * ada-lang.c: Fix common/ includes.
10193         * aarch64-tdep.c: Fix common/ includes.
10194
10195 2019-01-25  Tom Tromey  <tom@tromey.com>
10196
10197         * common/create-version.sh: Use common/version.h.
10198
10199 2019-01-24  Pedro Alves  <palves@redhat.com>
10200
10201         * infrun.c (signal_stop, signal_print, signal_program)
10202         (signal_catch, signal_pass): Now arrays instead of pointers.
10203         (update_signals_program_target, do_target_resume)
10204         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10205         * linux-nat.c (linux_nat_target::pass_signals)
10206         (linux_nat_target::create_inferior, linux_nat_target::attach):
10207         Adjust.
10208         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10209         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10210         * procfs.c (procfs_target::pass_signals): Adjust.
10211         * record-full.c (record_full_target::resume): Adjust.
10212         * remote.c (remote_target::pass_signals)
10213         (remote_target::program_signals): Adjust.
10214         * target-debug.h (target_debug_print_signals): Now takes a
10215         gdb::array_view as parameter.  Adjust.
10216         * target.h (target_ops) <pass_signals, program_signals>: Replace
10217         pointer and length parameters with gdb::array_view.
10218         (target_pass_signals, target_program_signals): Likewise.
10219         * target-delegates.c: Regenerate.
10220
10221 2019-01-24  Pedro Alves  <palves@redhat.com>
10222
10223         * common/forward-scope-exit.h
10224         (forward_scope_exit::forward_scope_exit): Pass arguments to
10225         m_bind_function directly, instead of creating a std::bind and
10226         copying that.
10227
10228 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10229
10230         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10231         for static members.
10232         (pass_in_v_vfp_candidate): Likewise.
10233
10234 2019-01-23  Tom Tromey  <tom@tromey.com>
10235             Pedro Alves  <palves@redhat.com>
10236
10237         * regcache.c (class regcache_invalidator): Remove.
10238         (regcache::raw_write): Use make_scope_exit.
10239
10240 2019-01-23  Tom Tromey  <tom@tromey.com>
10241
10242         * ui-out.h (class ui_out_emit_type): Update comment.
10243
10244 2019-01-23  Tom Tromey  <tom@tromey.com>
10245
10246         * infrun.c (fetch_inferior_event): Update comment.
10247
10248 2019-01-23  Tom Tromey  <tom@tromey.com>
10249             Pedro Alves  <palves@redhat.com>
10250
10251         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10252         parameter.
10253         (fetch_inferior_event): Use SCOPE_EXIT.
10254
10255
10256 2019-01-23  Tom Tromey  <tom@tromey.com>
10257             Pedro Alves  <palves@redhat.com>
10258
10259         * infrun.c (disable_thread_events): Delete.
10260         (stop_all_threads): Use SCOPE_EXIT.
10261
10262 2019-01-23  Tom Tromey  <tom@tromey.com>
10263             Pedro Alves  <palves@redhat.com>
10264
10265         * symfile.c: Include forward-scope-exit.h.
10266         (clear_symtab_users_cleanup): Replace forward declaration with
10267         a FORWARD_SCOPE_EXIT.
10268         (syms_from_objfile_1): Use the forward_scope_exit and
10269         gdb::optional instead of cleanup_function.
10270         (reread_symbols): Use the forward_scope_exit instead of
10271         cleanup_function.
10272         (clear_symtab_users_cleanup): Remove function.
10273
10274 2019-01-23  Tom Tromey  <tom@tromey.com>
10275             Pedro Alves  <palves@redhat.com>
10276
10277         * linux-nat.c: Include scope-exit.h.
10278         (cleanup_target_stop): Remove.
10279         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10280         SCOPE_EXIT.
10281
10282 2019-01-23  Tom Tromey  <tom@tromey.com>
10283             Pedro Alves  <palves@redhat.com>
10284
10285         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10286         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10287
10288 2019-01-23  Tom Tromey  <tom@tromey.com>
10289             Andrew Burgess  <andrew.burgess@embecosm.com>
10290             Pedro Alves  <palves@redhat.com>
10291
10292         * infrun.c (fetch_inferior_event): Use scope_exit.
10293         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10294         * top.c (execute_command): Use scope_exit.
10295         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10296         * utils.c (do_bpstat_clear_actions_cleanup)
10297         (make_bpstat_clear_actions_cleanup): Remove.
10298
10299 2019-01-23  Tom Tromey  <tom@tromey.com>
10300             Pedro Alves  <palves@redhat.com>
10301
10302         * infrun.c: Include "common/scope-exit.h"
10303         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10304         (wait_for_inferior): Use SCOPE_EXIT.
10305         (fetch_inferior_event): Use scope_exit.
10306
10307 2019-01-23  Tom Tromey  <tom@tromey.com>
10308             Pedro Alves  <palves@redhat.com>
10309
10310         * breakpoint.c (create_breakpoint): Remove cleanup.
10311
10312 2019-01-23  Tom Tromey  <tom@tromey.com>
10313             Andrew Burgess  <andrew.burgess@embecosm.com>
10314             Pedro Alves  <palves@redhat.com>
10315
10316 2019-01-23  Pedro Alves  <palves@redhat.com>
10317
10318         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10319
10320 2019-01-23  Pedro Alves  <palves@redhat.com>
10321             Andrew Burgess  <andrew.burgess@embecosm.com>
10322
10323         * gdbthread.h: Include "common/forward-scope-exit.h".
10324         (scoped_finish_thread_state): Redefine custom class in terms of
10325         forward_scope_exit.
10326
10327 2019-01-23  Pedro Alves  <palves@redhat.com>
10328             Andrew Burgess  <andrew.burgess@embecosm.com>
10329
10330         * common/forward-scope-exit.h: New file.
10331
10332 2019-01-23  Pedro Alves  <palves@redhat.com>
10333             Andrew Burgess  <andrew.burgess@embecosm.com>
10334             Tom Tromey  <tom@tromey.com>
10335
10336         * common/scope-exit.h: New file.
10337
10338 2019-01-23  Pedro Alves  <palves@redhat.com>
10339
10340         * common/preprocessor.h (ESC): Rename to ...
10341         (ESC_PARENS): ... this.
10342         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10343         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10344
10345 2019-01-23  Tom Tromey  <tom@tromey.com>
10346
10347         * language.h (class scoped_switch_to_sym_language_if_auto):
10348         Initialize m_lang in both cases.
10349
10350 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10351
10352         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10353         with XCNEW.
10354
10355 2019-01-22  Tom Tromey  <tom@tromey.com>
10356
10357         * corelow.c: Do not include sys/file.h.
10358
10359 2019-01-22  Tom Tromey  <tom@tromey.com>
10360
10361         * tui/tui-wingeneral.h: Include gdb_curses.h.
10362
10363 2019-01-22  Tom Tromey  <tom@tromey.com>
10364
10365         * source-cache.h (class source_cache) <get_source_lines,
10366         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10367
10368 2019-01-22  Tom Tromey  <tom@tromey.com>
10369
10370         * remote-fileio.h (struct remote_target): Declare.
10371
10372 2019-01-22  Tom Tromey  <tom@tromey.com>
10373
10374         * python/py-arch.c: Do not include py-ref.h.
10375         * python/py-bpevent.c: Do not include py-ref.h.
10376         * python/py-cmd.c: Do not include py-ref.h.
10377         * python/py-continueevent.c: Do not include py-ref.h.
10378         * python/py-event.h: Do not include py-ref.h.
10379         * python/py-evtregistry.c: Do not include py-ref.h.
10380         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10381         * python/py-frame.c: Do not include py-ref.h.
10382         * python/py-framefilter.c: Do not include py-ref.h.
10383         * python/py-function.c: Do not include py-ref.h.
10384         * python/py-infevents.c: Do not include py-ref.h.
10385         * python/py-linetable.c: Do not include py-ref.h.
10386         * python/py-objfile.c: Do not include py-ref.h.
10387         * python/py-param.c: Do not include py-ref.h.
10388         * python/py-prettyprint.c: Do not include py-ref.h.
10389         * python/py-progspace.c: Do not include py-ref.h.
10390         * python/py-symbol.c: Do not include py-ref.h.
10391         * python/py-symtab.c: Do not include py-ref.h.
10392         * python/py-type.c: Do not include py-ref.h.
10393         * python/py-unwind.c: Do not include py-ref.h.
10394         * python/py-utils.c: Do not include py-ref.h.
10395         * python/py-value.c: Do not include py-ref.h.
10396         * python/py-varobj.c: Do not include py-ref.h.
10397         * python/py-xmethods.c: Do not include py-ref.h.
10398         * python/python.c: Do not include py-ref.h.
10399         * varobj.c: Do not include py-ref.h.
10400
10401 2019-01-22  Tom Tromey  <tom@tromey.com>
10402
10403         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10404         keyword for bcache.
10405
10406 2019-01-22  Tom Tromey  <tom@tromey.com>
10407
10408         * compile/compile-cplus-types.c: Remove a comment by #include.
10409
10410 2019-01-22  Tom Tromey  <tom@tromey.com>
10411
10412         * compile/gcc-c-plugin.h: Include compile-internal.h.
10413
10414 2019-01-22  Tom Tromey  <tom@tromey.com>
10415
10416         * stabsread.c (EXTERN): Do not define.
10417         (symnum, next_symbol_text_func, processing_gcc_compilation)
10418         (within_function, global_sym_chain, global_stabs)
10419         (previous_stab_code, this_object_header_files)
10420         (n_this_object_header_files)
10421         (n_allocated_this_object_header_files): Define.
10422         * stabsread.h (EXTERN): Never define.  Use "extern".
10423
10424 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10425
10426         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10427         history_value.
10428
10429 2019-01-21  Tom Tromey  <tom@tromey.com>
10430
10431         * ui-out.c: Fix includes.
10432         * tui/tui-source.c: Fix includes.
10433         * target.c: Fix includes.
10434         * remote.c: Fix includes.
10435         * regcache.c: Fix includes.
10436         * python/py-block.c: Fix includes.
10437         * printcmd.c: Fix includes.
10438         * or1k-tdep.c: Fix includes.
10439         * mi/mi-main.c: Fix includes.
10440         * m32r-tdep.c: Fix includes.
10441         * csky-tdep.c: Fix includes.
10442         * compile/compile-cplus-types.c: Fix includes.
10443         * cli/cli-interp.c: Fix includes.
10444
10445 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10446
10447         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10448         for padding.
10449
10450 2019-01-16  Tom Tromey  <tom@tromey.com>
10451
10452         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10453         earlier.
10454         (struct objfile) <msymbols_range>: Move from top level.
10455         <msymbols>: New method.
10456         (class objfile_msymbols): Remove.
10457         * symtab.c (default_collect_symbol_completion_matches_break_on):
10458         Update.
10459         * symmisc.c (dump_msymbols): Update.
10460         * stabsread.c (scan_file_globals): Update.
10461         * objc-lang.c (info_selectors_command, info_classes_command)
10462         (find_methods): Update.
10463         * minsyms.c (find_solib_trampoline_target): Update.
10464         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10465         * coffread.c (coff_symfile_read): Update.
10466         * ada-lang.c (ada_lookup_simple_minsym)
10467         (ada_collect_symbol_completion_matches): Update.
10468
10469 2019-01-16  Tom Tromey  <tom@tromey.com>
10470
10471         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10472         type.  Remove no-argument constructor.
10473         <iterator::operator++>: Simplify.
10474         <begin>: Update.
10475         <end>: Use minimal_symbol_count.
10476
10477 2019-01-16  Tom Tromey  <tom@tromey.com>
10478
10479         * objfiles.h (struct objfile) <psymtabs>: New method.
10480         (class objfile_psymtabs): Remove.
10481         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10482         typedef.
10483         <range>: New method.
10484         (require_partial_symbols): Change return type.
10485         * psymtab.c (require_partial_symbols)
10486         (psym_expand_symtabs_matching): Update.
10487         * mdebugread.c (parse_partial_symbols): Update.
10488         * dbxread.c (dbx_end_psymtab): Update.
10489
10490 2019-01-15  Tom Tromey  <tom@tromey.com>
10491
10492         * symtab.c (lookup_objfile_from_block)
10493         (lookup_symbol_in_objfile_symtabs)
10494         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10495         (find_line_symtab, info_sources_command)
10496         (default_collect_symbol_completion_matches_break_on)
10497         (make_source_files_completion_list): Update.
10498         * symmisc.c (print_objfile_statistics, dump_objfile)
10499         (maintenance_print_symbols, maintenance_info_symtabs)
10500         (maintenance_check_symtabs, maintenance_info_line_tables):
10501         Update.
10502         * source.c (select_source_symtab)
10503         (forget_cached_source_info_for_objfile): Update.
10504         * objfiles.h (class objfile_compunits): Remove.
10505         (struct objfile) <compunits_range>: New typedef.
10506         (compunits): New method.
10507         * objfiles.c (objfile_relocate1): Update.
10508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10509         * maint.c (count_symtabs_and_blocks): Update.
10510         * linespec.c (iterate_over_all_matching_symtabs): Update.
10511         * cp-support.c (add_symbol_overload_list_qualified): Update.
10512         * coffread.c (coff_symtab_read): Update.
10513         * ada-lang.c (add_nonlocal_symbols)
10514         (ada_collect_symbol_completion_matches)
10515         (ada_add_global_exceptions): Update.
10516
10517 2019-01-15  Tom Tromey  <tom@tromey.com>
10518
10519         * progspace.h (program_space) <objfiles_safe_range>: New
10520         typedef.
10521         <objfiles_safe>: New method.
10522         * objfiles.h (class all_objfiles_safe): Remove.
10523         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10524         * jit.c (jit_inferior_exit_hook): Update.
10525
10526 2019-01-17  Tom Tromey  <tom@tromey.com>
10527
10528         * progspace.h (program_space) <objfiles_range>: New typedef.
10529         <objfiles>: New method.
10530         <objfiles_head>: Rename from objfiles.
10531         (object_files): Update.
10532         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10533         * guile/scm-pretty-print.c
10534         (ppscm_find_pretty_printer_from_objfiles): Update.
10535         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10536         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10537         Update.
10538         * python/py-progspace.c (pspy_get_objfiles): Update.
10539         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10540         Update.
10541         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10542         (objfpy_lookup_objfile_by_build_id): Update.
10543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10544         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10545         Update.
10546         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10547         (expand_symtab_containing_pc, lookup_objfile_from_block)
10548         (lookup_static_symbol, basic_lookup_transparent_type)
10549         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10550         (find_line_symtab, info_sources_command)
10551         (default_collect_symbol_completion_matches_break_on)
10552         (make_source_files_completion_list, find_main_name): Update.
10553         * symmisc.c (print_symbol_bcache_statistics)
10554         (print_objfile_statistics, maintenance_print_symbols)
10555         (maintenance_print_msymbols, maintenance_print_objfiles)
10556         (maintenance_info_symtabs, maintenance_check_symtabs)
10557         (maintenance_expand_symtabs, maintenance_info_line_tables):
10558         Update.
10559         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10560         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10561         (map_overlay_command, unmap_overlay_command)
10562         (simple_overlay_update, expand_symtabs_matching)
10563         (map_symbol_filenames): Update.
10564         * symfile-debug.c (set_debug_symfile): Update.
10565         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10566         Update.
10567         * source.c (select_source_symtab, forget_cached_source_info):
10568         Update.
10569         * solib.c (solib_read_symbols): Update.
10570         * solib-spu.c (append_ocl_sos): Update.
10571         * psymtab.c (maintenance_print_psymbols)
10572         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10573         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10574         * printcmd.c (info_symbol_command): Update.
10575         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10576         Update.
10577         * objfiles.h (class all_objfiles): Remove.
10578         * objfiles.c (have_partial_symbols, have_full_symbols)
10579         (have_minimal_symbols, qsort_cmp, update_section_map)
10580         (shared_objfile_contains_address_p)
10581         (default_iterate_over_objfiles_in_search_order): Update.
10582         * objc-lang.c (info_selectors_command, info_classes_command)
10583         (find_methods): Update.
10584         * minsyms.c (find_solib_trampoline_target): Update.
10585         * maint.c (maintenance_info_sections)
10586         (maintenance_translate_address, count_symtabs_and_blocks):
10587         Update.
10588         * main.c (captured_main_1): Update.
10589         * linux-thread-db.c (try_thread_db_load_from_pdir)
10590         (has_libpthread): Update.
10591         * linespec.c (iterate_over_all_matching_symtabs)
10592         (search_minsyms_for_name): Update.
10593         * jit.c (jit_find_objf_with_entry_addr): Update.
10594         * hppa-tdep.c (find_unwind_entry)
10595         (hppa_lookup_stub_minimal_symbol): Update.
10596         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10597         Update.
10598         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10599         (elf_gnu_ifunc_resolve_by_got): Update.
10600         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10601         * dwarf-index-write.c (save_gdb_index_command): Update.
10602         * cp-support.c (add_symbol_overload_list_qualified): Update.
10603         * breakpoint.c (create_overlay_event_breakpoint)
10604         (create_longjmp_master_breakpoint)
10605         (create_std_terminate_master_breakpoint)
10606         (create_exception_master_breakpoint): Update.
10607         * blockframe.c (find_pc_partial_function): Update.
10608         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10609         (ada_collect_symbol_completion_matches)
10610         (ada_add_global_exceptions): Update.
10611
10612 2019-01-17  Tom Tromey  <tom@tromey.com>
10613
10614         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10615         declare VEC.
10616         (solib_target_parse_libraries): Change return type.
10617         (library_list_start_segment, library_list_start_section)
10618         (library_list_end_library, library_list_start_library); Update.
10619         (solib_target_free_library_list): Remove.
10620         (solib_target_parse_libraries): Remove cleanup.  Change return
10621         type.
10622         (solib_target_current_sos): Update.
10623
10624 2019-01-17  Tom Tromey  <tromey@bapiya>
10625
10626         * valprint.c: Replace "the the" with "the".
10627         * symtab.c: Replace "the the" with "the".
10628         * solib.c: Replace "the the" with "the".
10629         * solib-dsbt.c: Replace "the the" with "the".
10630         * linespec.c: Replace "the the" with "the".
10631         * dwarf2loc.h: Replace "the the" with "the".
10632         * amd64-windows-tdep.c: Replace "the the" with "the".
10633         * aarch64-tdep.c: Replace "the the" with "the".
10634
10635 2019-01-16  Keith Seitz  <keiths@redhat.com>
10636
10637         PR gdb/23773
10638         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10639         <builder>: Rename to ..
10640         <m_builder>: ... this and make private.
10641         (dwarf2_cu::get_builder): New method.  Change all users of
10642         `builder' to use this method.
10643         (dwarf2_start_symtab): Move to ...
10644         (dwarf2_cu::start_symtab): ... here.  Update all callers
10645         (setup_type_unit_groups): Move to ...
10646         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10647         callers.
10648         (dwarf2_cu::reset_builder): New method.
10649         (process_full_compunit, process_full_type_unit): Use
10650         dwarf2_cu::reset_builder.
10651         (follow_die_offset): Record the ancestor CU if it is different
10652         from the followed DIE's CU.
10653         (follow_die_sig_1): Likewise.
10654
10655 2019-01-15  Tom Tromey  <tom@tromey.com>
10656
10657         * remote.c (class remote_state) <buf>: Now a char_vector.
10658         <buf_size>: Remove.
10659         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10660         parameter.
10661         (remote_target::getpkt_or_notif_sane_1)
10662         (remote_target::getpkt_sane)
10663         (remote_target::getpkt_or_notif_sane): Likewise.
10664         (class remote_target) <putpkt>: New overload.
10665         (remote_target::read_frame): Change type of "buf_p".  Remove
10666         sizeof_p parameter.
10667         (packet_ok): New overload.
10668         (packet_check_result): New overload.
10669         Update all uses.
10670
10671 2019-01-14  Tom Tromey  <tom@tromey.com>
10672
10673         * remote-notif.c (handle_notification, remote_notif_ack)
10674         (remote_notif_parse): Make "buf" const.
10675         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10676         const.
10677         (remote_notif_parse, remote_notif_ack, handle_notification):
10678         Likewise.
10679         * remote.c (remote_notif_stop_parse): Make "buf" const.
10680         (remote_target::remote_parse_stop_reply): Make "buf" const.
10681         (remote_notif_stop_ack): Make "buf" const.
10682
10683 2019-01-14  Tom Tromey  <tom@tromey.com>
10684
10685         * remote.c (remote_console_output): Make parameter const.
10686
10687 2019-01-14  Tom Tromey  <tom@tromey.com>
10688
10689         * target-debug.h (target_debug_print_signals): Constify.
10690         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10691         * procfs.c (procfs_target::pass_signals): Update.
10692         * linux-nat.c (linux_nat_target::pass_signals): Update.
10693         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10694         * target-delegates.c: Rebuild.
10695         * remote.c (remote_target::program_signals): Update.
10696         (remote_target::pass_signals): Update.
10697         * target.c (target_pass_signals): Constify argument.
10698         (target_program_signals): Likewise.
10699         * target.h (struct target_ops) <pass_signals, program_signals>:
10700         Constify argument.
10701         (target_pass_signals, target_program_signals): Constify argument.
10702
10703 2019-01-14  Tom Tromey  <tom@tromey.com>
10704
10705         PR tui/28819:
10706         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10707
10708 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10709
10710         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10711         field.
10712         * rs6000-tdep.c: Include reggroups.h.
10713         (IS_V_ALIAS_PSEUDOREG): Define.
10714         (rs6000_register_name): Return names for the "vX" aliases.
10715         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10716         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10717         aliases.  Call default_register_reggroup_p for all other
10718         pseudo-registers.
10719         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10720         New functions.
10721         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10722         Handle "vX" aliases.
10723         (v_alias_pseudo_register_collect): New function.
10724         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10725         (rs6000_gdbarch_init): Initialize "vX" aliases as
10726         pseudo-registers.  Restore registration of
10727         rs6000_pseudo_register_reggroup_p with
10728         set_tdesc_pseudo_register_reggroup_p.
10729
10730 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10731
10732         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10733         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10734         set_gdbarch_num_pseudo_regs.
10735
10736 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10737
10738         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10739         Remove arg prefixname, add do_set and do_show.
10740         Add member functions set_list and show_list.
10741         * cli/cli-style.c (class cli_style_option): Update accordingly.
10742         (style_set_list): Move to file scope.
10743         (style_show_list): Likewise.
10744         (set_style): Call help_list.
10745         (show_style): Call cmd_show_list.
10746         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10747         Update to use the new macro.
10748
10749 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10750
10751         * ada-lang.c (_initialize_ada_language): Expand the help text
10752         for the "catch exception" command.
10753
10754 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10755
10756         * symtab.c (matching_obj_sections): Initialize obj,
10757         declare it closer to its usage.
10758
10759 2019-01-10  Tom Tromey  <tom@tromey.com>
10760
10761         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10762         (basic_inf_threads_range): Remove.
10763         (inf_threads_range, inf_non_exited_threads_range)
10764         (safe_inf_threads_range): Use next_adapter.
10765
10766 2019-01-10  Keith Seitz  <keiths@redhat.com>
10767
10768         PR gdb/23712
10769         PR symtab/23010
10770         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10771         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10772
10773 2019-01-10  Keith Seitz  <keiths@redhat.com>
10774
10775         PR gdb/23712
10776         PR symtab/23010
10777         * dictionary.c (pending_to_vector): Remove.
10778         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10779         Remove _1 suffix, replacing functions of the same name.  Update
10780         all callers.
10781         (dict_create_hashed, dict_create_hashed_expandable)
10782         (dict_create_linear, dict_create_linear_expandable, dict_free)
10783         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10784         Make functions static.
10785
10786 2019-01-10  Keith Seitz  <keiths@redhat.com>
10787
10788         PR gdb/23712
10789         PR symtab/23010
10790         * dictionary.h (struct dictionary): Replace declaration with
10791         multidictionary.
10792         (dict_create_hashed, dict_create_hashed_expandable)
10793         (dict_create_linear, dict_create_linear_expandable)
10794         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10795         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10796         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10797         taking multidictionary argument.
10798         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10799         * block.h (struct block) <dict>: Change to multidictionary
10800         and rename `multidict'.
10801         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10802         symmisc.c: Update all dictionary references to multidictionary.
10803
10804 2019-01-10  Keith Seitz  <keiths@redhat.com>
10805
10806         PR gdb/23712
10807         PR symtab/23010
10808         * dictionary.c: Include unordered_map.
10809         (pending_to_vector): New function.
10810         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10811         Rewrite the non-"_1" functions to take vector instead
10812         of linked list.
10813         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10814         "new" _1 versions of the same name.
10815         (multidictionary): Define.
10816         (std::hash<enum language): New definition.
10817         (collate_pending_symbols_by_language, mdict_create_hashed)
10818         (mdict_create_hashed_expandable, mdict_create_linear)
10819         (mdict_create_linear_expandable, mdict_free)
10820         (find_language_dictionary, create_new_language_dictionary)
10821         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10822         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10823         (mdict_size, mdict_empty): New functions.
10824         * dictionary.h (mdict_iterator): Define.
10825
10826 2019-01-10  Pedro Alves  <palves@redhat.com>
10827
10828         * breakpoint.c (read_uploaded_action)
10829         (create_tracepoint_from_upload): Adjust to use
10830         gdb::unique_xmalloc_ptr.
10831         * ctf.c (ctf_write_uploaded_tp):
10832         (SET_ARRAY_FIELD): Use emplace_back.
10833         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10834         * tracefile-tfile.c (tfile_write_uploaded_tp):
10835         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10836         gdb::unique_xmalloc_ptr.
10837         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10838         at_string, cond_string, cmd_strings>: Replace char pointers
10839         with gdb::unique_xmalloc_ptr.
10840
10841 2019-01-10  Pedro Alves  <palves@redhat.com>
10842
10843         * solib-target.c (library_list_start_library): Don't xstrdup name.
10844
10845 2019-01-10  Pedro Alves  <palves@redhat.com>
10846
10847         * mdebugread.c (parse_partial_symbols): Use
10848         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10849
10850 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10851
10852         * linux-fork.c (scoped_switch_fork_info)
10853         <~scoped_switch_fork_info>: Fix incorrect variable name.
10854
10855 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10856
10857         * linux-fork.c (scoped_switch_fork_info)
10858         <scoped_switch_fork_info>: Make explicit.
10859         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10860
10861 2019-01-10  Tom Tromey  <tom@tromey.com>
10862
10863         * objfiles.h (objfile::reset_psymtabs): Update.
10864         * objfiles.c (objfile::objfile): Update.
10865         * psymtab.h (psymtab_storage::obstack): Update.
10866         (psymtab_storage::m_obstack): Use gdb::optional.
10867         (class psymtab_storage): Update comment.  Remove objfile
10868         parameter.
10869         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10870
10871 2019-01-10  Tom Tromey  <tom@tromey.com>
10872
10873         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10874         <free_psymtabs>: Now private.
10875         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10876         (allocate_psymtab): Use new method.
10877
10878 2019-01-10  Tom Tromey  <tom@tromey.com>
10879
10880         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10881         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10882         * mdebugread.c (parse_partial_symbols): Use
10883         allocate_dependencies.
10884         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10885         allocate_dependencies.
10886         (process_psymtab_comp_unit_reader)
10887         (build_type_psymtab_dependencies): Likewise.
10888         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10889
10890 2019-01-10  Tom Tromey  <tom@tromey.com>
10891
10892         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10893         PSYMBOL_SET_LANGUAGE.
10894         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10895
10896 2019-01-10  Tom Tromey  <tom@tromey.com>
10897
10898         * psymtab.h (psymtab_storage::obstack): New method.
10899         <m_obstack>: Rename from obstack; now private.
10900         * psymtab.c (psymtab_storage): Update.
10901         * dwarf2read.c (create_addrmap_from_index)
10902         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10903         Update.
10904
10905 2019-01-10  Tom Tromey  <tom@tromey.com>
10906
10907         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10908         * objfiles.h (objfile::reset_psymtabs): New method.
10909
10910 2019-01-10  Tom Tromey  <tom@tromey.com>
10911
10912         * symmisc.c (print_symbol_bcache_statistics): Update.
10913         (print_objfile_statistics): Update.
10914         * symfile.c (reread_symbols): Update.
10915         * psymtab.h (class psymtab_storage): New.
10916         * psymtab.c (psymtab_storage): New constructor.
10917         (~psymtab_storage): New destructor.
10918         (require_partial_symbols): Update.
10919         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10920         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10921         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10922         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10923         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10924         (start_psymtab_common, end_psymtab_common)
10925         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10926         (allocate_psymtab): Update.
10927         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10928         Update.
10929         (dump_psymtab_addrmap, maintenance_print_psymbols)
10930         (maintenance_check_psymtabs): Update.
10931         (class objfile_psymtabs): Move to objfiles.h.
10932         * psympriv.h (discard_psymtab): Now inline.
10933         (psymtab_discarder::psymtab_discarder): Update.
10934         (psymtab_discarder::~psymtab_discarder): Update.
10935         (ALL_OBJFILE_PSYMTABS): Rewrite.
10936         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10937         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10938         Remove fields.
10939         <partial_symtabs>: New field.
10940         (class objfile_psymtabs): Move from psymtab.h.  Update.
10941         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10942         psymbol_cache.
10943         (objfile::~objfile): Don't destroy psymbol_cache.
10944         * mdebugread.c (parse_partial_symbols): Update.
10945         * dwarf2read.c (create_addrmap_from_index)
10946         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10947         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10948         (add_partial_subprogram, dwarf2_ranges_read): Update.
10949         * dwarf-index-write.c (write_address_map)
10950         (write_one_signatured_type, recursively_write_psymbols)
10951         (class debug_names, class debug_names, write_psymtabs_to_index):
10952         Update.
10953
10954 2019-01-10  Tom Tromey  <tom@tromey.com>
10955
10956         * symtab.h (SYMBOL_SET_NAMES): Update.
10957         (symbol_set_names): Update.
10958         (MSYMBOL_SET_NAMES): Update.
10959         * symtab.c (symbol_set_names): Change argument to be an
10960         objfile_per_bfd_storage.
10961         * psymtab.c (add_psymbol_to_bcache): Update.
10962         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10963
10964 2019-01-10  Tom Tromey  <tom@tromey.com>
10965
10966         * symtab.c (create_demangled_names_hash): Change argument to be an
10967         objfile_per_bfd_storage.
10968         (symbol_set_names): Update.
10969
10970 2019-01-10  Tom Tromey  <tom@tromey.com>
10971
10972         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10973         init_psymbol_list.
10974         * psymtab.c (init_psymbol_list): Do nothing if already called.
10975         * psympriv.h (init_psymbol_list): Add comment.
10976         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10977         init_psymbol_list.
10978         * dbxread.c (dbx_symfile_read): Unconditionally call
10979         init_psymbol_list.
10980
10981 2019-01-10  Tom Tromey  <tom@tromey.com>
10982
10983         * xcoffread.c (scan_xcoff_symtab): Update.
10984         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10985         "where".
10986         * mdebugread.c (parse_partial_symbols)
10987         (handle_psymbol_enumerators): Update.
10988         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10989         * dbxread.c (read_dbx_symtab): Update.
10990         * psympriv.h (psymbol_placement): New enum.
10991         (add_psymbol_to_list): Update.
10992
10993 2019-01-10  Tom Tromey  <tom@tromey.com>
10994
10995         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10996         static_psymbols parameters.
10997         (scan_xcoff_symtab): Update.
10998         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10999         static_psymbols parameters.
11000         * psympriv.h (start_psymtab_common): Update.
11001         * mdebugread.c (parse_partial_symbols): Update.
11002         * dwarf2read.c (create_partial_symtab): Update.
11003         * dbxread.c (read_dbx_symtab): Update.
11004         (start_psymtab): Remove global_psymbols and static_psymbols
11005         parameters.
11006
11007 2019-01-10  Tom Tromey  <tom@tromey.com>
11008
11009         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11010         * psymtab.c (allocate_psymtab): Add comment.
11011         * psympriv.h (allocate_psymtab): Add comment.
11012         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11013         initializations.
11014         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11015
11016 2019-01-10  Tom Tromey  <tom@tromey.com>
11017
11018         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11019         Don't declare.
11020         * mipsread.c: Include mdebugread.h.
11021         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11022         Declare.
11023         * elfread.c: Include mdebugread.h.
11024
11025 2019-01-09  Tom Tromey  <tom@tromey.com>
11026
11027         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11028         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11029         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11030         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11031         (psym_lookup_symbol, psym_find_last_source_symtab)
11032         (psym_forget_cached_source_info, psym_print_stats)
11033         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11034         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11035         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11036         (psym_find_compunit_symtab_by_address)
11037         (maintenance_print_psymbols, maintenance_info_psymtabs)
11038         (maintenance_check_psymtabs): Use ranged for.
11039         * psymtab.h (class objfile_psymtabs): New.
11040         (require_partial_symbols): Return objfile_psymtabs.
11041         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11042
11043 2019-01-09  Tom Tromey  <tom@tromey.com>
11044
11045         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11046         (find_pc_mapped_section, list_overlays_command)
11047         (map_overlay_command, unmap_overlay_command)
11048         (simple_overlay_update): Use all_objfiles.
11049         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11050         * printcmd.c (info_symbol_command): Use all_objfiles.
11051         * objfiles.h (ALL_OBJSECTIONS): Remove.
11052         * maint.c (maintenance_translate_address): Use all_objfiles.
11053         * gcore.c (gcore_create_callback): Use all_objfiles.
11054         (objfile_find_memory_regions): Likewise.
11055
11056 2019-01-09  Tom Tromey  <tom@tromey.com>
11057
11058         * symtab.c (find_line_symtab, info_sources_command)
11059         (make_source_files_completion_list): Use objfile_compunits.
11060         * source.c (select_source_symtab): Use objfile_compunits.
11061         * objfiles.h (struct objfile): Update comment.
11062         (ALL_OBJFILES): Remove.
11063         (ALL_FILETABS): Remove.
11064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11065         objfile_compunits.
11066
11067 2019-01-09  Tom Tromey  <tom@tromey.com>
11068
11069         * symmisc.c (print_objfile_statistics, dump_objfile)
11070         (maintenance_print_symbols): Use compunit_filetabs.
11071         * source.c (forget_cached_source_info_for_objfile): Use
11072         compunit_filetabs.
11073         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11074         (ALL_FILETABS): Use compunit_filetabs.
11075         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11076         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11077
11078 2019-01-09  Tom Tromey  <tom@tromey.com>
11079
11080         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11081         (compunit_filetabs): New.
11082         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11083         compunit_filetabs.
11084         (info_sources_command, make_source_files_completion_list): Remove
11085         declaration.
11086         * symmisc.c (print_objfile_statistics, dump_objfile)
11087         (maintenance_print_symbols): Remove declaration.
11088         (maintenance_info_symtabs): Use compunit_filetabs.
11089         (maintenance_info_line_tables): Likewise.
11090         * source.c (select_source_symtab): Change local variable name.
11091         (forget_cached_source_info_for_objfile): Remove declaration.
11092         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11093         * objfiles.c (objfile_relocate1): Remove declaration.
11094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11095         declaration.
11096         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11097         * coffread.c (coff_symtab_read): Remove declaration.
11098         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11099         compunit_filetabs.
11100
11101 2019-01-09  Tom Tromey  <tom@tromey.com>
11102
11103         * symtab.c (lookup_objfile_from_block)
11104         (find_pc_sect_compunit_symtab, search_symbols)
11105         (default_collect_symbol_completion_matches_break_on): Use
11106         objfile_compunits.
11107         * objfiles.h (ALL_COMPUNITS): Remove.
11108         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11109         * cp-support.c (add_symbol_overload_list_qualified): Use
11110         objfile_compunits.
11111         * ada-lang.c (ada_collect_symbol_completion_matches)
11112         (ada_add_global_exceptions): Use objfile_compunits.
11113
11114 2019-01-09  Tom Tromey  <tom@tromey.com>
11115
11116         * source.c (select_source_symtab)
11117         (forget_cached_source_info_for_objfile): Remove declaration.
11118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11119         declaration.
11120         * maint.c (count_symtabs_and_blocks): Remove declaration.
11121         * cp-support.c (add_symbol_overload_list_qualified): Remove
11122         declaration.
11123         * coffread.c (coff_symtab_read): Remove declaration.
11124         * symtab.c (lookup_symbol_in_objfile_symtabs)
11125         (basic_lookup_transparent_type_1): Use objfile_compunits.
11126         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11127         (info_sources_command, search_symbols)
11128         (default_collect_symbol_completion_matches_break_on)
11129         (make_source_files_completion_list): Remove declaration.
11130         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11131         (ada_collect_symbol_completion_matches)
11132         (ada_add_global_exceptions): Remove declaration.
11133         * linespec.c (iterate_over_all_matching_symtabs): Use
11134         objfile_compunits.
11135         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11136         (class objfile_compunits): New.
11137         (ALL_COMPUNITS): Use objfile_compunits.
11138         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11139         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11140         objfile_compunits.
11141         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11142
11143 2019-01-09  Tom Tromey  <tom@tromey.com>
11144
11145         * symtab.c (search_symbols)
11146         (default_collect_symbol_completion_matches_break_on): Use
11147         objfile_msymbols.
11148         * ada-lang.c (ada_lookup_simple_minsym)
11149         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11150         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11151         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11152         objfile_msymbols.
11153         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11154         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11155         * objc-lang.c (find_methods): Use objfile_msymbols.
11156         (info_selectors_command, info_classes_command): Likewise.
11157         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11158         * objfiles.h (class objfile_msymbols): New.
11159         (ALL_OBJFILE_MSYMBOLS): Remove.
11160         (ALL_MSYMBOLS): Remove.
11161
11162 2019-01-09  Tom Tromey  <tom@tromey.com>
11163
11164         * common/next-iterator.h (next_adapter): Add Iterator template
11165         parameter.
11166         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11167         (class all_objfiles_safe): New.
11168         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11169         * objfiles.c (put_objfile_before): Update comment.
11170         (add_separate_debug_objfile): Likewise.
11171         (free_all_objfiles): Use all_objfiles_safe.
11172         (objfile_purge_solibs): Likewise.
11173
11174 2019-01-09  Tom Tromey  <tom@tromey.com>
11175
11176         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11177         (expand_symtab_containing_pc, lookup_static_symbol)
11178         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11179         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11180         all_objfiles.
11181         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11182         * breakpoint.c (create_overlay_event_breakpoint)
11183         (create_longjmp_master_breakpoint)
11184         (create_std_terminate_master_breakpoint)
11185         (create_exception_master_breakpoint): Use all_objfiles.
11186         * linux-thread-db.c (try_thread_db_load_from_pdir)
11187         (has_libpthread): Use all_objfiles.
11188         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11189         * linespec.c (iterate_over_all_matching_symtabs)
11190         (search_minsyms_for_name): Use all_objfiles.
11191         * maint.c (maintenance_info_sections): Use all_objfiles.
11192         * main.c (captured_main_1): Use all_objfiles.
11193         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11194         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11195         * guile/scm-pretty-print.c
11196         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11197         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11198         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11199         (maintenance_print_msymbols): Use all_objfiles.
11200         * source.c (select_source_symtab): Use all_objfiles.
11201         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11202         * symfile.c (remove_symbol_file_command)
11203         (expand_symtabs_matching, map_symbol_filenames): Use
11204         all_objfiles.
11205         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11206         all_objfiles.
11207         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11208         * objc-lang.c (find_methods): Use all_objfiles.
11209         * objfiles.c (have_partial_symbols, have_full_symbols)
11210         (have_minimal_symbols, qsort_cmp)
11211         (default_iterate_over_objfiles_in_search_order): Use
11212         all_objfiles.
11213         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11214         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11215         (maintenance_check_psymtabs): Use all_objfiles.
11216         (ALL_PSYMTABS): Remove.
11217         * compile/compile-object-run.c (do_module_cleanup): Use
11218         all_objfiles.
11219         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11220         * cp-support.c (add_symbol_overload_list_qualified): Use
11221         all_objfiles.
11222         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11223         Use all_objfiles.
11224         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11225         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11226         all_objfiles.
11227         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11228         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11229         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11230         Uses all_objfiles.
11231         * solib.c (solib_read_symbols): Use all_objfiles
11232
11233 2019-01-09  Tom Tromey  <tom@tromey.com>
11234
11235         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11236         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11237         all_objfiles.
11238         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11239         * symmisc.c (print_symbol_bcache_statistics)
11240         (print_objfile_statistics, maintenance_print_objfiles)
11241         (maintenance_info_symtabs, maintenance_check_symtabs)
11242         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11243         all_objfiles.
11244         * source.c (forget_cached_source_info): Use all_objfiles.
11245         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11246         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11247         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11248         * objfiles.c (update_section_map): Use all_objfiles.
11249         (shared_objfile_contains_address_p): Likewise.
11250         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11251         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11252
11253 2019-01-09  Tom Tromey  <tom@tromey.com>
11254
11255         * common/next-iterator.h: New file.
11256         * objfiles.h (class all_objfiles): New.
11257         (struct objfile_iterator): New.
11258
11259 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11260
11261         * NEWS: Move the description of the changed "frame", "select-frame",
11262          and "info frame" commands to the Changed commands section.
11263
11264 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11265
11266         * gdbtypes.c (check_stub_method_group): Remove handling of old
11267         mangling schemes.
11268         * linespec.c (find_methods): Likewise.
11269         * stabsread.c (read_member_functions): Likewise.
11270         * valops.c (search_struct_method): Likewise.
11271         (value_struct_elt_for_reference): Likewise.
11272         * NEWS: Mention this change.
11273
11274 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11275
11276         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11277         print_source_lines.
11278         * source.c (print_source_lines_base): Update line number check.
11279         (print_source_lines): New function.
11280         (source_lines_range::source_lines_range): New function.
11281         * source.h (class source_lines_range): New class.
11282         (print_source_lines): New declaration.
11283
11284 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11285
11286         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11287
11288 2019-01-08  Tom Tromey  <tom@tromey.com>
11289             Simon Marchi  <simon.marchi@ericsson.com>
11290
11291         PR gdb/24060
11292         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11293         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11294         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11295         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11296         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11297         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11298
11299 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11300
11301         * source.c (select_source_symtab): Move header comment to
11302         declaration in source.h.
11303         (forget_cached_source_info_for_objfile): Likewise.
11304         (forget_cached_source_info): Likewise.
11305         (identify_source_line): Likewise.
11306         * source.h (identify_source_line): Move declaration from symtab.h
11307         and add comment from source.c
11308         (print_source_lines): Likewise.
11309         (forget_cached_source_info_for_objfile): Likewise.
11310         (forget_cached_source_info): Likewise.
11311         (select_source_symtab): Likewise.
11312         (enum print_source_lines_flag): Move definition from symtab.h.
11313         * symtab.h (identify_source_line): Move declaration to source.h.
11314         (print_source_lines): Likewise.
11315         (forget_cached_source_info_for_objfile): Likewise.
11316         (forget_cached_source_info): Likewise.
11317         (select_source_symtab): Likewise.
11318         (enum print_source_lines_flag): Move definition to source.h.
11319         * tui/tui-hooks.c: Add 'source.h' include.
11320
11321 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11322
11323         * source.c (print_source_lines_base): Handle requests to print
11324         reverse line number sequences, and guard against empty lines
11325         string.
11326
11327 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11328
11329         * source.c (print_source_lines_base): Fix skip of '\r' if next
11330         character is '\n'.
11331
11332 2019-01-06  Tom Tromey  <tom@tromey.com>
11333
11334         * c-exp.y (struct c_parse_state) <macro_original_text,
11335         expansion_obstack>: New member.
11336         (macro_original_text, expansion_obstack): Remove globals.
11337         (scan_macro_expansion, scanning_macro_expansion)
11338         (finished_macro_expansion): Update.
11339         (scan_macro_cleanup): Remove.
11340         (yylex, c_parse): Update.
11341
11342 2019-01-06  Tom Tromey  <tom@tromey.com>
11343
11344         * c-exp.y (struct c_parse_state) <strings>: New member.
11345         (operator_stoken): Update.
11346
11347 2019-01-06  Tom Tromey  <tom@tromey.com>
11348
11349         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11350         (union type_stack_elt) <typelist_val>: Now a pointer to
11351         std::vector.
11352         (type_stack_cleanup): Don't declare.
11353         (push_typelist): Update.
11354         * parse.c (pop_typelist): Return a std::vector.
11355         (push_typelist): Take a std::vector.
11356         (follow_types): Update.  Do not free args.
11357         (type_stack_cleanup): Remove.
11358         * c-exp.y (struct c_parse_state): New.
11359         (cpstate): New global.
11360         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11361         (nonempty_typelist): Update.
11362         (func_mod): Create a new vector.
11363         (c_parse): Create a c_parse_state.
11364         (check_parameter_typelist): Do not delete params.
11365         (function_method): Update.  Do not delete type_list.
11366
11367 2019-01-06  Tom Tromey  <tom@tromey.com>
11368
11369         PR gdb/28155:
11370         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11371         check_typedef.
11372         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11373         (print_return_value): Likewise.
11374
11375 2019-01-05  Tom Tromey  <tom@tromey.com>
11376
11377         * contrib/cleanup_check.py: Remove.
11378         * contrib/gcc-with-excheck: Remove.
11379         * contrib/exsummary.py: Remove.
11380         * contrib/excheck.py: Remove.
11381
11382 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11383
11384         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11385         NULL. Initialize tpprev to NULL instead of assigning it
11386         to NULL on the next statement.
11387         * windows-nat.c (windows_delete_thread): Remove check for
11388         main_thread_id before printing thread exit notifications.
11389         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11390         Remove thread ID check against main_thread_id.
11391         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11392         windows_delete_thread.
11393         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11394
11395 2019-01-04  Tom Tromey  <tom@tromey.com>
11396
11397         * compile/compile.c (_initialize_compile): Use upper case for
11398         metasyntactic variables.
11399         * symmisc.c (_initialize_symmisc): Use upper case for
11400         metasyntactic variables.
11401         * psymtab.c (_initialize_psymtab): Use upper case for
11402         metasyntactic variables.
11403         * demangle.c (demangle_command): Use upper case for metasyntactic
11404         variables.
11405         (_initialize_demangler): Likewise.
11406         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11407         variables.
11408
11409 2019-01-03  Tom Tromey  <tom@tromey.com>
11410
11411         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11412
11413 2019-01-03  Tom Tromey  <tom@tromey.com>
11414
11415         * python/py-symtab.c (salpy_str): Update.
11416         (struct salpy_sal_object) <symtab>: Now a PyObject.
11417         (salpy_dealloc): Update.
11418         (del_objfile_sal): Use gdbpy_ref.
11419
11420 2019-01-03  Tom Tromey  <tom@tromey.com>
11421
11422         * python/py-type.c (convert_field): Use new_reference.  Return
11423         gdbpy_ref.
11424         (make_fielditem): Return gdbpy_ref.
11425         (typy_fields): Update.
11426         (typy_getitem): Update.
11427         (field_name): Return gdbpy_ref.  Use new_reference.
11428         (typy_iterator_iternext): Update.
11429
11430 2019-01-03  Tom Tromey  <tom@tromey.com>
11431
11432         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11433
11434 2019-01-03  Tom Tromey  <tom@tromey.com>
11435
11436         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11437         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11438         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11439         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11440         (pspy_set_type_printers): Likewise.
11441         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11442         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11443         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11444         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11445         (objfpy_set_type_printers): Likewise.
11446
11447 2019-01-03  Tom Tromey  <tom@tromey.com>
11448
11449         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11450         (gdbpy_print_stack): Use gdbpy_err_fetch.
11451         * python/python-internal.h (class gdbpy_err_fetch): New class.
11452         (class gdbpy_enter) <m_error_type, m_error_value,
11453         m_error_traceback>: Remove.
11454         <m_error>: New member.
11455         (gdbpy_exception_to_string): Don't declare.
11456         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11457         * python/py-value.c (convert_value_from_python): Use
11458         gdbpy_err_fetch.
11459         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11460         gdbpy_exception_to_string.
11461         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11462         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11463         gdbpy_err_fetch.
11464
11465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11466
11467         * linux-nat.c (delete_lwp_cleanup): Delete.
11468         (struct lwp_deleter): New struct.
11469         (lwp_info_up): New typedef.
11470         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11471         lwp_info_up.
11472
11473 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11474
11475         * linux-fork.c (class scoped_switch_fork_info): New class.
11476         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11477
11478 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11479
11480         * valops.c (find_overload_match): Remove use of null_cleanup, and
11481         calls to do_cleanups.
11482
11483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11484
11485         * compile/compile-cplus-types.c
11486         (compile_cplus_instance::decl_name): Handle changes to
11487         cp_func_name.
11488         * cp-support.c (cp_func_name): Update header comment, update
11489         return type.
11490         * cp-support.h (cp_func_name): Update return type in declaration.
11491         * valops.c (find_overload_match): Move temp_func local to top
11492         level of function and change its type.  Use temp_func to hold and
11493         delete temporary string obtained from cp_func_name.
11494
11495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11496
11497         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11498         gdb::char_vector, remove cleanup, and update uses of `msg`.
11499
11500 2019-01-03  Jim Wilson  <jimw@sifive.com>
11501
11502         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11503
11504 2019-01-02  Tom Tromey  <tom@tromey.com>
11505
11506         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11507         (tdesc_parse_xml): Remove cleanups.
11508         * target-descriptions.h (make_cleanup_free_target_description):
11509         Don't declare.
11510         (target_desc_deleter): New struct.
11511         (target_desc_up): New typedef.
11512         * target-descriptions.c (target_desc_deleter::operator()): Rename
11513         from free_target_description.
11514         (make_cleanup_free_target_description): Remove.
11515
11516 2019-01-02  Tom Tromey  <tom@tromey.com>
11517
11518         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11519         constructor, destructor.
11520         (linespec_parser): Remove typedef.
11521         (~linespec_parser): Rename from linespec_parser_delete.
11522         (linespec_lex_to_end, linespec_complete_label)
11523         (linespec_complete): Update.
11524         (decode_line_full): Remove cleanups.
11525         (decode_line_1): Update.
11526
11527 2019-01-02  Tom Tromey  <tom@tromey.com>
11528
11529         * python/python-internal.h (inferior_to_inferior_object): Change
11530         return type.
11531         * python/py-exitedevent.c (create_exited_event_object): Update.
11532         * python/py-inferior.c (inferior_to_inferior_object): Return
11533         gdbpy_ref.
11534         (python_new_inferior, python_inferior_deleted)
11535         (thread_to_thread_object, delete_thread_object)
11536         (build_inferior_list, gdbpy_selected_inferior): Update.
11537         * python/py-infthread.c (create_thread_object): Update.  Also fail
11538         if inferior_to_inferior_object fails.
11539
11540 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11541
11542         * inferior.h (class inferior) <displaced_step_state>: New field.
11543         * infrun.h (struct displaced_step_state): Move here from
11544         infrun.c.  Initialize fields, add constructor.
11545         <inf>: Remove field.
11546         <reset>: New method.
11547         * infrun.c (struct displaced_step_inferior_state): Move to
11548         infrun.h.
11549         (displaced_step_inferior_states): Remove.
11550         (get_displaced_stepping_state): Adust.
11551         (displaced_step_in_progress_any_inferior): Adjust.
11552         (displaced_step_in_progress_thread): Adjust.
11553         (displaced_step_in_progress): Adjust.
11554         (add_displaced_stepping_state): Remove.
11555         (get_displaced_step_closure_by_addr): Adjust.
11556         (remove_displaced_stepping_state): Remove.
11557         (infrun_inferior_exit): Call displaced_step_state.reset.
11558         (use_displaced_stepping): Don't check for NULL.
11559         (displaced_step_prepare_throw): Call
11560         get_displaced_stepping_state.
11561         (displaced_step_fixup): Don't check for NULL.
11562         (prepare_for_detach): Don't check for NULL.
11563
11564 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11565
11566         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11567          in case of call that did not complete.
11568
11569 2019-01-02  Andrey Utkin  <autkin@undo.io>
11570
11571         * symfile.c (find_separate_debug_file): Fix search of debug files for
11572         remote debuggee.
11573
11574 2019-01-02  Tom Tromey  <tom@tromey.com>
11575
11576         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11577         indentation.
11578         * python/py-frame.c (frapy_older): Remove cast.
11579         (frapy_newer): Likewise.
11580         * python/py-breakpoint.c (local_setattro): Remove cast.
11581         * python/py-arch.c (archpy_name): Remove local variable.
11582         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11583
11584 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11585
11586         * unittests/basic_string_view/element_access/char/empty.cc:
11587         Fix year range in copyright header.
11588
11589 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11590
11591         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11592         Delete.
11593         <operator==>: Update with for removed field.
11594         <hash>: Likewise.
11595         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11596         <isa_features>: ...this.
11597         <abi_features>: New field.
11598         (riscv_isa_flen): Update comment.
11599         (riscv_abi_xlen): New declaration.
11600         (riscv_abi_flen): New declaration.
11601         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11602         isa_features.
11603         (riscv_abi_xlen): New function.
11604         (riscv_isa_flen): Update to get answer from isa_features.
11605         (riscv_abi_flen): New function.
11606         (riscv_has_fp_abi): Update to get answer from abi_features.
11607         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11608         xlen and flen.
11609         (riscv_call_info) <xlen, flen>: Update comment.
11610         (riscv_call_arg_struct): Remove invalid assertions
11611         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11612         is removed.
11613         (riscv_gdbarch_init): Gather isa features and abi features
11614         separately, ensure both match on the gdbarch when reusing an old
11615         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11616         a target with 64-bit float hardware.
11617
11618 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11619
11620         * source.c (search_command_helper): Stop reverse search
11621         when line 1 has been searched.
11622
11623 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11624
11625         * record-full.c (record_full_base_target::close): Rewrite
11626         record_full_core_buf_list free logic.
11627
11628 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11629
11630         * break-catch-syscall.c (print_one_catch_syscall): xfree
11631         the last text.
11632
11633 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11634
11635         * top.c (print_gdb_version): Update Copyright year in version
11636         message.
11637
11638 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11639
11640         Update copyright year range in all GDB files.
11641
11642 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11643
11644         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11645
11646 For older changes see ChangeLog-2018.
11647 \f
11648 Local Variables:
11649 mode: change-log
11650 left-margin: 8
11651 fill-column: 74
11652 version-control: never
11653 coding: utf-8
11654 End:
11655