gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * parser-defs.h (increase_expout_size): Don't declare.
   4         * parse.c (increase_expout_size): Now static.
   5
   6 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
   7
   8         * gnu-nat.c (gnu_nat_target::wait): Fix
   9         target_waitstatus_to_string call.
  10
  11 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * eval.c (evaluate_subexp_standard): Handle internal functions
  14         during Fortran function call handling.
  15
  16 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         * NEWS: Mention new internal functions.
  19         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  20         (read_base_type): Use dwarf2_init_complex_target_type.
  21         * value.c (creal_internal_fn): New function.
  22         (cimag_internal_fn): New function.
  23         (_initialize_values): Register new internal functions.
  24
  25 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  26
  27         * infrun.c (stop_all_threads): If debug_infrun, always
  28         trace the wait status after wait_one, using
  29         target_waitstatus_to_string and target_pid_to_str.
  30         (handle_inferior_event): Replace various trace of
  31         wait status kind by a single trace.
  32         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
  33         wait status kind image by target_waitstatus_to_string.
  34         * target/waitstatus.c (target_waitstatus_to_string): Fix
  35         obsolete comment.
  36
  37 2019-04-01  Tom Tromey  <tromey@adacore.com>
  38
  39         PR symtab/23331:
  40         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  41
  42 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  43             Pedro Alves  <palves@redhat.com>
  44
  45         * top.c (quit_force): Call 'finalize_values'.
  46         * value.c (finalize_values): New function.
  47         * value.h (finalize_values): Declare.
  48
  49 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  50
  51         * NEWS: Announce $_gdb_major and $_gdb_minor.
  52
  53         * top.c (init_gdb_version_vars): New function.
  54         (gdb_init): Call init_gdb_version_vars.
  55
  56 2019-03-29  Tom Tromey  <tromey@adacore.com>
  57
  58         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  59         help text.  Remove dead code.
  60
  61 2019-03-29  Keith Seitz  <keiths@redhat.com>
  62
  63         From Siddhesh Poyarekar:
  64         * f-lang.h (f77_get_upperbound): Return LONGEST.
  65         (f77_get_lowerbound): Likewise.
  66         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  67         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  68         print them.
  69         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  70         plongest to format print it.
  71         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  72         (f77_get_upperbound): Likewise.
  73         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  74         LOWER_BOUND to LONGEST.
  75         (f77_create_arrayprint_offset_tbl): Likewise.
  76
  77 2019-03-29  Keith Seitz  <keiths@redhat.com>
  78
  79         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  80         %s/pulongest for TYPE_LENGTH instead of %d in format
  81         strings.
  82         * ada-typerint.c (ada_print_type): Likewise.
  83         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  84         * compile/compile-c-support.c (generate_register_struct): Likewise.
  85         * gdbtypes.c (recursive_dump_type): Likewise.
  86         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  87         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  88         instead of %d in format strings.
  89         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  90         to std::min to ULONGEST.
  91         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  92         instead of %d in format strings.
  93         * tracepoint.c (info_scope_command): Likewise.
  94         * typeprint.c (print_offset_data::update)
  95         (print_offset_data::finish): Likewise.
  96         * xtensa-tdep.c (xtensa_store_return_value)
  97         (xtensa_push_dummy_call): Likewise.
  98
  99 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 100
 101         * windows-nat.c (display_selector): Fixed format specifications
 102         for 64-bit Cygwin.
 103
 104 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 105
 106         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 107
 108 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 109
 110         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 111         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 112         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 113         (nios2_linux_init_abi): Install it.
 114
 115 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 116
 117         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 118
 119 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 120
 121         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 122
 123 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 124             Tom Tromey  <tromey@adacore.com>
 125
 126         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 127
 128 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 129
 130         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 131         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 132         method to compute the bounds of range types. Also print "[evaluated]"
 133         if the bounds' values come from a dynamic evaluation.
 134
 135 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 136
 137         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 138         whitespace when pretty printing is on.
 139
 140 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 141
 142         * ppc-linux-nat.c: Add include.
 143
 144 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 145
 146         * NEWS: Mention AArch64 Pointer Authentication.
 147
 148 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 149
 150         * arm-linux-nat.c: Add include.
 151
 152 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 153
 154         * source-cache.c (source_cache::get_source_lines): Re-read
 155         fullname after calling open_source_file.
 156
 157 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 158
 159         * NEWS: Mention TLS support for FreeBSD.
 160
 161 2019-03-25  Tom Tromey  <tromey@adacore.com>
 162
 163         * minsyms.c (BUNCH_SIZE): Update comment.
 164         (~minimal_symbol_reader): Remove old comment.
 165         (compact_minimal_symbols): Update comment.
 166         (minimal_symbol_reader::install): Remove old comment.  Update
 167         other comments.
 168
 169 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 170
 171         * s390-linux-nat.c: Add include.
 172
 173 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 174
 175         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 176         Call linux_get_hwcap.
 177         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 178         Likewise.
 179         (aarch64_linux_get_hwcap): Remove function.
 180         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 181         declaration.
 182         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 183         linux_get_hwcap.
 184         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 185         * linux-tdep.c (linux_get_hwcap): Add function.
 186         (linux_get_hwcap2): Likewise.
 187         * linux-tdep.h (linux_get_hwcap): Add declaration.
 188         (linux_get_hwcap2): Likewise.
 189         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 190         (ppc_linux_get_hwcap2): Likewise.
 191         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 192         linux_get_hwcap.
 193         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 194         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 195         (ppc_linux_nat_target::read_description): Likewise.
 196         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 197         * s390-linux-nat.c: Likewise.
 198         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 199
 200 2019-03-24  Tom Tromey  <tom@tromey.com>
 201
 202         * ada-lang.c (standard_lookup): Simplify initialization.
 203         (ada_lookup_symbol_nonlocal): Simplify return.
 204         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 205         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 206         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 207         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 208         initialization.
 209         * solib.c (solib_global_lookup): Simplify.
 210         * symtab.c (null_block_symbol): Remove.
 211         (symbol_cache_lookup): Simplify returns.
 212         (lookup_language_this): Simplify returns.
 213         (lookup_symbol_aux): Simplify return.
 214         (lookup_local_symbol): Simplify returns.
 215         (lookup_global_symbol_from_objfile): Simplify return.
 216         (lookup_symbol_in_objfile_symtabs)
 217         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 218         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 219         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 220         * cp-namespace.c (cp_lookup_bare_symbol)
 221         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 222         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 223         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 224         (cp_lookup_symbol_via_imports): Simplify initialization.
 225         (find_symbol_in_baseclass): Likewise.
 226         * symtab.h (null_block_symbol): Remove.
 227         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 228         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 229         (d_lookup_symbol_module): Likewise.
 230         (find_symbol_in_baseclass): Simplify initialization.
 231
 232 2019-03-24  Tom Tromey  <tom@tromey.com>
 233
 234         * expression.h: Don't include symtab.h.
 235         (struct block): Forward declare.
 236
 237 2019-03-24  Tom Tromey  <tom@tromey.com>
 238
 239         * c-exp.y (typebase): Remove casts.
 240         * gdbtypes.c (lookup_unsigned_typename, )
 241         (lookup_signed_typename): Remove cast.
 242         * eval.c (parse_to_comma_and_eval): Remove cast.
 243         * parse.c (write_dollar_variable): Remove cast.
 244         * block.h (struct block) <superblock>: Now const.
 245         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 246         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 247         (map_block): Make "block" const.
 248         * symfile.h (struct quick_symbol_functions)
 249         <map_matching_symbols>: Constify block argument to "callback".
 250         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 251         const.
 252         (find_pc_sect_compunit_symtab): Make "b" const.
 253         (find_symbol_at_address): Likewise.
 254         (search_symbols): Likewise.
 255         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 256         (dw2_debug_names_lookup_symbol): Likewise.
 257         (dw2_map_matching_symbols): Update.
 258         * p-valprint.c (pascal_val_print): Remove "block".
 259         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 260         (aux_add_nonlocal_symbols): Make "block" const.
 261         (resolve_subexp): Remove cast.
 262         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 263         const.
 264         (iterate_over_file_blocks): Likewise.
 265         * f-exp.y (%union) <bval>: Remove.
 266         * coffread.c (patch_opaque_types): Make "b" const.
 267         * spu-tdep.c (spu_catch_start): Make "block" const.
 268         * c-valprint.c (print_unpacked_pointer): Remove "block".
 269         * symmisc.c (dump_symtab_1): Make "b" const.
 270         (block_depth): Make "block" const.
 271         * d-exp.y (%union) <bval>: Remove.
 272         * cp-support.h (cp_lookup_rtti_type): Update.
 273         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 274         * psymtab.c (psym_lookup_symbol): Make "block" const.
 275         (maintenance_check_psymtabs): Make "b" const.
 276         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 277         (enumerate_locals, enumerate_args): Update.
 278         * python/py-symtab.c (stpy_global_block): Make "block" const.
 279         (stpy_static_block): Likewise.
 280         * inline-frame.c (block_starting_point_at): Make "new_block"
 281         const.
 282         * block.c (find_block_in_blockvector): Make return type const.
 283         (blockvector_for_pc_sect): Make "b" const.
 284         (find_block_in_blockvector): Make "b" const.
 285
 286 2019-03-23  Tom Tromey  <tom@tromey.com>
 287
 288         * varobj.c (varobj_create): Update.
 289         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 290         * printcmd.c (display_command, do_one_display): Don't reset
 291         innermost_block.
 292         * parser-defs.h (enum innermost_block_tracker_type): Move to
 293         expression.h.
 294         (innermost_block): Update comment.
 295         * parse.c (parse_exp_1): Add tracker_types parameter.
 296         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 297         tracker_types parameter.  Reset innermost_block.
 298         (parse_exp_in_context): Remove.
 299         (parse_expression_for_completion): Update.
 300         * objfiles.c (~objfile): Don't reset expression_context_block or
 301         innermost_block.
 302         * expression.h (enum innermost_block_tracker_type): Move from
 303         parser-defs.h.
 304         (parse_exp_1): Add tracker_types parameter.
 305         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 306         reset innermost_block.
 307
 308 2019-03-23  Tom Tromey  <tom@tromey.com>
 309
 310         * objfiles.h: Include bcache.h.
 311
 312 2019-03-23  Tom Tromey  <tom@tromey.com>
 313
 314         * linespec.c (get_current_search_block): Use
 315         scoped_restore_current_language.
 316         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 317
 318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 319             Jiong Wang  <jiong.wang@arm.com>
 320
 321         * aarch64-linux-tdep.c
 322         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 323         section.
 324         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 325
 326 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 327             Jiong Wang  <jiong.wang@arm.com>
 328
 329         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 330         instructions.
 331         (aarch64_analyze_prologue_test): Add PACIASP test.
 332         (aarch64_prologue_prev_register): Unmask PC value.
 333
 334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 335             Jiong Wang  <jiong.wang@arm.com>
 336
 337         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 338         (aarch64_dwarf2_prev_register): Unmask PC value.
 339         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 340         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 341         DW_CFA_AARCH64_negate_ra_state.
 342         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 343
 344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 345             Jiong Wang  <jiong.wang@arm.com>
 346
 347         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 348         registers.
 349         (aarch64_pseudo_register_name): Likewise.
 350         (aarch64_pseudo_register_type): Likewise.
 351         (aarch64_pseudo_register_reggroup_p): Likewise.
 352         (aarch64_gdbarch_init): Add pauth registers.
 353         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 354         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 355         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 356         (struct gdbarch_tdep): Add regnum for ra_state.
 357
 358 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 359             Jiong Wang  <jiong.wang@arm.com>
 360
 361         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 362
 363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 364             Jiong Wang  <jiong.wang@arm.com>
 365
 366         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 367         function.
 368         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 369         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 370         (aarch64_gdbarch_init): Add puth registers.
 371         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 372         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 373         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 374
 375 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 376             Jiong Wang  <jiong.wang@arm.com>
 377
 378         * aarch64-linux-nat.c
 379         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 380         * aarch64-linux-tdep.c
 381         (aarch64_linux_core_read_description): Likewise.
 382         (aarch64_linux_get_hwcap): New function.
 383         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 384         (aarch64_linux_get_hwcap): New declaration.
 385
 386 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 387             Jiong Wang  <jiong.wang@arm.com>
 388
 389         * aarch64-linux-nat.c
 390         (aarch64_linux_nat_target::read_description): Add pauth param.
 391         * aarch64-linux-tdep.c
 392         (aarch64_linux_core_read_description): Likewise.
 393         * aarch64-tdep.c (struct target_desc): Add in pauth.
 394         (aarch64_read_description): Add pauth param.
 395         (aarch64_gdbarch_init): Likewise.
 396         * aarch64-tdep.h (aarch64_read_description): Likewise.
 397         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 398         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 399         * features/Makefile: Add new files.
 400         * features/aarch64-pauth.c: New file.
 401         * features/aarch64-pauth.xml: New file.
 402
 403 2019-03-20  Tom Tromey  <tromey@adacore.com>
 404
 405         * infrun.c (handle_inferior_event): Rename from
 406         handle_inferior_event_1.  Create a scoped_value_mark.
 407         (handle_inferior_event): Remove.
 408
 409 2019-03-19  Tom Tromey  <tromey@adacore.com>
 410
 411         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 412         * infrun.h (print_stop_event): Add "displays" parameter.
 413         * infrun.c (print_stop_event): Add "displays" parameter.
 414
 415 2019-03-19  Pedro Alves  <palves@redhat.com>
 416
 417         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 418         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 419         to -1.  Fix TABs vs spaces.
 420         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 421         * tui/tui-out.h (tui_ui_out) Add intro comments.
 422         <m_line, m_start_of_line>: In-class initialize, and add describing
 423         comment.
 424
 425 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 426
 427         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 428         variable names.
 429         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 430
 431 2019-03-18  Pedro Alves  <palves@redhat.com>
 432             Eli Zaretskii <eliz@gnu.org>
 433
 434         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 435         m_line and m_start_of_line.
 436
 437 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 438
 439         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 440         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 441         it returns a newline.  This fixes a regression in TU mode, whereby
 442         the next line is output on the same screen line as the user input.
 443
 444 2019-03-18  Tom Tromey  <tromey@adacore.com>
 445
 446         * minsyms.c (minimal_symbol_reader::install): Remove call to
 447         obstack_blank.
 448
 449 2019-03-18  Pedro Alves  <palves@redhat.com>
 450
 451         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 452         New globals.
 453         (apply_style): New, factored out from ...
 454         (apply_ansi_escape): ... this.  Handle reverse video mode.
 455         (tui_set_reverse_mode): New function.
 456         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 457         * tui/tui-winsource.c (tui_show_source_line): Use
 458         tui_set_reverse_mode instead of setting A_STANDOUT.
 459         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 460         New setter methods.
 461
 462 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 463
 464         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 465         Handle tabs.
 466
 467 2019-03-18  Tom Tromey  <tromey@adacore.com>
 468
 469         * ada-lang.c (empty_array): Add "high" parameter.
 470         (ada_evaluate_subexp): Update.
 471
 472 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 473
 474         * unittests/string_view-selftests.c: Define
 475         _initialize_string_view_selftests unconditionally.
 476
 477 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 478
 479         PR gdb/24350
 480         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 481
 482 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 483
 484         PR gdb/24351
 485         * windows-nat.c (display_selector): Fix format specifiers.
 486
 487 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 488
 489         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 490         tui_refill_source_window instead of tui_refresh_win, to update the
 491         current execution line.  This fixes redisplay of the current line
 492         when stepping through the code with "next" or "step".
 493
 494 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 495
 496         * source-cache.c (source_cache::get_source_lines): Call
 497         find_source_lines to initialize s->nlines.  This fixes vertical
 498         scrolling of TUI source window when the DOWN arrow is pressed.
 499
 500 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 501
 502         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 503         linux-thread-db.c (_initialize_thread_db): Likewise.
 504
 505 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 506
 507         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 508         wclrtoeol in tui_show_source_line".  This reverts changes made in
 509         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 510
 511 2019-03-15  Tom Tromey  <tom@tromey.com>
 512
 513         * symtab.h (struct minimal_symbol): Derive from
 514         general_symbol_info.
 515         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 516         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 517         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 518         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 519         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 520         (MSYMBOL_SEARCH_NAME): Update.
 521         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 522         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 523         * minsyms.c (minimal_symbol_reader::record_full): Update.
 524
 525 2019-03-15  Tom Tromey  <tom@tromey.com>
 526
 527         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 528
 529 2019-03-15  Tom Tromey  <tom@tromey.com>
 530
 531         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 532         unique_xmalloc_ptr.
 533         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 534         Update.
 535         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 536         (build_minimal_symbol_hash_tables)
 537         (minimal_symbol_reader::install): Update.
 538
 539 2019-03-15  Tom Tromey  <tom@tromey.com>
 540
 541         * symtab.c (create_demangled_names_hash): Update.
 542         (symbol_set_names): Update.
 543         * objfiles.h (struct objfile_per_bfd_storage)
 544         <demangled_names_hash>: Now an htab_up.
 545         * objfiles.c (objfile_per_bfd_storage): Simplify.
 546
 547 2019-03-15  Tom Tromey  <tom@tromey.com>
 548
 549         * objfiles.h (struct objfile_per_bfd_storage): Declare
 550         destructor.
 551         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 552         New.
 553         (get_objfile_bfd_data): Use new.  Don't initialize
 554         language_of_main.
 555         (free_objfile_per_bfd_storage): Remove.
 556         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 557
 558 2019-03-15  Tom Tromey  <tom@tromey.com>
 559
 560         * symfile.c (reread_symbols): Update.
 561         * objfiles.c (objfile::objfile): Update.
 562         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 563         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 564         comment.
 565         (minimal_symbol_reader::install): Update.
 566         (terminate_minimal_symbol_table): Remove.
 567         * jit.c (jit_object_close_impl): Update.
 568
 569 2019-03-15  Tom Tromey  <tom@tromey.com>
 570
 571         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 572         initializations.
 573
 574 2019-03-15  Tom Tromey  <tom@tromey.com>
 575
 576         * objfiles.h (struct objfile_per_bfd_storage)
 577         <demangled_hash_languages>: Now a bitset.
 578         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 579         (lookup_minimal_symbol): Update.
 580
 581 2019-03-15  Tom Tromey  <tom@tromey.com>
 582
 583         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 584         Don't return the symbol.
 585         * coffread.c (record_minimal_symbol): Use record_full.
 586
 587 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 588
 589         The MS-Windows port of ncurses fails to switch to a color pair if
 590         one or both of the colors are the implicit default colors.  This
 591         change records the default colors when TUI is initialized, and
 592         then specifies them explicitly when a color pair uses the default
 593         colors.  This allows color styling in TUI mode on MS-Windows.
 594
 595         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 596         ncurses_norm_attr.
 597         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 598         colors in ncurses_norm_attr.
 599         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 600         "none", replace it with the default color recorded in
 601         ncurses_norm_attr.
 602
 603 2019-03-14  Tom Tromey  <tromey@adacore.com>
 604
 605         * source-cache.h (class source_cache) <get_source_lines>: Return
 606         std::string.
 607         * source-cache.c (source_cache::extract_lines): Handle case where
 608         first_pos==npos.  Return std::string.
 609         (source_cache::get_source_lines): Update.
 610
 611 2019-03-14  Tom Tromey  <tromey@adacore.com>
 612
 613         * NEWS: Add item for "style sources" commands.
 614         * source-cache.c (source_cache::get_source_lines): Check
 615         source_styling.
 616         * cli/cli-style.c (source_styling): New global.
 617         (_initialize_cli_style): Add "style sources" commands.
 618         (show_style_sources): New function.
 619         * cli/cli-style.h (source_styling): Declare.
 620
 621 2019-03-14  Pedro Alves  <palves@redhat.com>
 622             Tom Tromey  <tromey@adacore.com>
 623
 624         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 625         * tui/tui-winsource.c (tui_refill_source_window): New function,
 626         from...
 627         (tui_horizontal_source_scroll): ... here.  Move some logic.
 628         * cli/cli-style.c (set_style_enabled): Notify new observable.
 629         * tui/tui-hooks.c (tui_redisplay_source): New function.
 630         (tui_attach_detach_observers): Attach or detach
 631         tui_redisplay_source.
 632         * observable.h (source_styling_changed): New observable.
 633         * observable.c: Define source_styling_changed observable.
 634
 635 2019-03-13  Tom Tromey  <tromey@adacore.com>
 636
 637         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 638         (i386_gnu_nat_target::store_registers): Update.
 639         * target-debug.h (target_debug_print_std_string): New macro.
 640         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 641         * windows-tdep.c (display_one_tib): Update.
 642         * tui/tui-stack.c (tui_make_status_line): Update.
 643         * top.c (print_inferior_quit_action): Update.
 644         * thread.c (thr_try_catch_cmd): Update.
 645         (add_thread_with_info): Update.
 646         (thread_target_id_str): Update.
 647         (thr_try_catch_cmd): Update.
 648         (thread_command): Update.
 649         (thread_find_command): Update.
 650         * record-btrace.c (record_btrace_target::info_record)
 651         (record_btrace_resume_thread, record_btrace_target::resume)
 652         (record_btrace_cancel_resume, record_btrace_step_thread)
 653         (record_btrace_target::wait, record_btrace_target::wait)
 654         (record_btrace_target::wait, record_btrace_target::stop): Update.
 655         * progspace.c (print_program_space): Update.
 656         * process-stratum-target.c
 657         (process_stratum_target::thread_address_space): Update.
 658         * linux-fork.c (linux_fork_mourn_inferior)
 659         (detach_checkpoint_command, info_checkpoints_command)
 660         (linux_fork_context): Update.
 661         (linux_fork_detach): Update.
 662         (class scoped_switch_fork_info): Update.
 663         (delete_checkpoint_command): Update.
 664         * infrun.c (follow_fork_inferior): Update.
 665         (follow_fork_inferior): Update.
 666         (proceed_after_vfork_done): Update.
 667         (handle_vfork_child_exec_or_exit): Update.
 668         (follow_exec): Update.
 669         (displaced_step_prepare_throw): Update.
 670         (displaced_step_restore): Update.
 671         (start_step_over): Update.
 672         (resume_1): Update.
 673         (clear_proceed_status_thread): Update.
 674         (proceed): Update.
 675         (print_target_wait_results): Update.
 676         (do_target_wait): Update.
 677         (context_switch): Update.
 678         (stop_all_threads): Update.
 679         (restart_threads): Update.
 680         (finish_step_over): Update.
 681         (handle_signal_stop): Update.
 682         (switch_back_to_stepped_thread): Update.
 683         (keep_going_pass_signal): Update.
 684         (print_exited_reason): Update.
 685         (normal_stop): Update.
 686         * inferior.c (inferior_pid_to_str): Change return type.
 687         (print_selected_inferior): Update.
 688         (add_inferior): Update.
 689         (detach_inferior): Update.
 690         * dummy-frame.c (fprint_dummy_frames): Update.
 691         * dcache.c (dcache_info_1): Update.
 692         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 693         (btrace_fetch, btrace_clear): Update.
 694         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 695         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 696         type.
 697         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 698         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 699         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 700         * gdbarch.c, gdbarch.h: Rebuild.
 701         * gdbarch.sh (core_pid_to_str): Change return type.
 702         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 703         return type.
 704         (windows_nat_target::pid_to_str): Change return type.
 705         (windows_delete_thread): Update.
 706         (windows_nat_target::attach): Update.
 707         (windows_nat_target::files_info): Update.
 708         * target-delegates.c: Rebuild.
 709         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 710         return type.
 711         (sol_thread_target::pid_to_str): Change return type.
 712         * remote.c (class remote_target) <pid_to_str>: Change return
 713         type.
 714         (remote_target::pid_to_str): Change return type.
 715         (extended_remote_target::attach, remote_target::remote_stop_ns)
 716         (remote_target::remote_notif_remove_queued_reply)
 717         (remote_target::push_stop_reply, remote_target::disable_btrace):
 718         Update.
 719         (extended_remote_target::attach): Update.
 720         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 721         type.
 722         (gdbsim_target::pid_to_str): Change return type.
 723         * ravenscar-thread.c (struct ravenscar_thread_target)
 724         <pid_to_str>: Change return type.
 725         (ravenscar_thread_target::pid_to_str): Change return type.
 726         * procfs.c (class procfs_target) <pid_to_str>: Change return
 727         type.
 728         (procfs_target::pid_to_str): Change return type.
 729         (procfs_target::attach): Update.
 730         (procfs_target::detach): Update.
 731         (procfs_target::fetch_registers): Update.
 732         (procfs_target::store_registers): Update.
 733         (procfs_target::wait): Update.
 734         (procfs_target::files_info): Update.
 735         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 736         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 737         return type.
 738         (nto_procfs_target::pid_to_str): Change return type.
 739         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 740         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 741         return type.
 742         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 743         (exit_lwp): Update.
 744         (attach_proc_task_lwp_callback, get_detach_signal)
 745         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 746         (linux_nat_target::resume, wait_lwp, stop_callback)
 747         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 748         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 749         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 750         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 751         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 752         type.
 753         (inf_ptrace_target::attach): Update.
 754         (inf_ptrace_target::files_info): Update.
 755         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 756         type.
 757         (go32_nat_target::pid_to_str): Change return type.
 758         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 759         (gnu_nat_target::wait): Update.
 760         (gnu_nat_target::wait): Update.
 761         (gnu_nat_target::resume): Update.
 762         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 763         (fbsd_nat_target::wait): Update.
 764         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 765         type.
 766         (darwin_nat_target::attach): Update.
 767         * corelow.c (class core_target) <pid_to_str>: Change return type.
 768         (core_target::pid_to_str): Change return type.
 769         * target.c (normal_pid_to_str): Change return type.
 770         (default_pid_to_str): Likewise.
 771         (target_pid_to_str): Change return type.
 772         (target_translate_tls_address): Update.
 773         (target_announce_detach): Update.
 774         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 775         return type.
 776         (bsd_uthread_target::pid_to_str): Change return type.
 777         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 778         type.
 779         (bsd_kvm_target::pid_to_str): Change return type.
 780         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 781         return type.
 782         (aix_thread_target::pid_to_str): Change return type.
 783         * target.h (struct target_ops) <pid_to_str>: Change return type.
 784         (target_pid_to_str, normal_pid_to_str): Likewise.
 785         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 786         type.
 787         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 788         type.
 789         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 790         return type.
 791         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 792         type.
 793         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 794         type.
 795         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 796         return type.
 797
 798 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 799
 800         * NEWS: Mention that the new default MI version is 3.  Mention
 801         changes to the output of commands and events that deal with
 802         multi-location breakpoints.
 803         * breakpoint.c: Include "mi/mi-out.h".
 804         (print_one_breakpoint): Change output syntax if using MI version
 805         >= 3.
 806         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 807         New.
 808         (mi_multi_location_breakpoint_output_fixed): New.
 809         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 810         (mi_cmd_fix_multi_location_breakpoint_output): New.
 811         (mi_multi_location_breakpoint_output_fixed): New.
 812         * mi/mi-cmds.c (mi_cmds): Register command
 813         -fix-multi-location-breakpoint-output.
 814         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 815         interpreter "mi".
 816
 817 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 818
 819         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 820         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 821         instantiate mi_ui_out based on interpreter name.
 822         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 823         * mi/mi-main.c (mi_load_progress): Likewise.
 824
 825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 826
 827         * NEWS: Combine separate "New targets" sections for 8.3.
 828
 829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 830
 831         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 832         (ppcfbsd_init_abi): Install gdbarch
 833         "fetch_tls_load_module_address" and "get_thread_local_address"
 834         methods.
 835
 836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 837
 838         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 839         (riscv_fbsd_init_abi): Install gdbarch
 840         "fetch_tls_load_module_address" and "get_thread_local_address"
 841         methods.
 842
 843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 844
 845         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 846         (i386fbsd_init_abi): Install gdbarch
 847         "fetch_tls_load_module_address" and "get_thread_local_address"
 848         methods.
 849
 850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 851
 852         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 853         (amd64fbsd_init_abi): Install gdbarch
 854         "fetch_tls_load_module_address" and "get_thread_local_address"
 855         methods.
 856
 857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 858
 859         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 860         (struct fbsd_pspace_data): New type.
 861         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 862         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 863         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 864         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 865         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 866
 867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 868
 869         * gdbtypes.c (lookup_struct_elt): New function.
 870         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 871         * gdbtypes.h (struct struct_elt): New type.
 872         (lookup_struct_elt): New prototype.
 873
 874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 875
 876         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 877         remove disabled code block.
 878
 879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 880
 881         * gdbarch.sh (get_thread_local_address): New method.
 882         * gdbarch.h, gdbarch.c: Regenerate.
 883         * target.c (target_translate_tls_address): Use
 884         gdbarch_get_thread_local_address if present instead of
 885         target::get_thread_local_address.
 886
 887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 888
 889         * target.h (target::get_thread_local_address): Update comment.
 890
 891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 892
 893         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 894         objfile->separate_debug_objfile_backlink if not NULL.
 895
 896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 897
 898         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 899         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 900         (amd64bsd_store_inferior_registers): Likewise.
 901         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 902         Enable segment base registers.
 903         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 904         PT_GETFSBASE and PT_GETGSBASE.
 905         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 906         PT_SETGSBASE.
 907         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 908         segment base registers.
 909         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 910
 911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 912
 913         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 914         Update calls to i386_target_description to add 'segments'
 915         parameter.
 916         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 917         add segment base registers.
 918         * arch/i386.c (i386_create_target_description): Add 'segments'
 919         parameter to enable segment base registers.
 920         * arch/i386.h (i386_create_target_description): Likewise.
 921         * features/i386/32bit-segments.xml: New file.
 922         * features/i386/32bit-segments.c: Generate.
 923         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 924         call to i386_target_description to add 'segments' parameter.
 925         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 926         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 927         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 928         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 929         if feature is present.
 930         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 931         Add 'segments' parameter to call to i386_target_description.
 932         (i386_target_description): Add 'segments' parameter to enable
 933         segment base registers.
 934         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 935         to call to i386_target_description.
 936         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 937         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 938         Define I386_NUM_REGS.
 939         (i386_target_description): Add 'segments' parameter to enable
 940         segment base registers.
 941
 942 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 943
 944         PR/24325
 945         * source-cache.c: #undef open and close, to avoid unresolved
 946         externals during linking.
 947
 948 2019-03-12  Tom Tromey  <tromey@adacore.com>
 949
 950         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 951         const.  Add initializers.
 952         (_initialize_remote): Don't initialize ptid globals.
 953
 954 2019-03-12  Pedro Alves  <palves@redhat.com>
 955
 956         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 957
 958 2019-03-12  Pedro Alves  <palves@redhat.com>
 959
 960         * cp-name-parser.y (main): Remove unused 'len' variable.
 961
 962 2019-03-12  Tom Tromey  <tromey@adacore.com>
 963
 964         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 965         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 966
 967 2019-03-12  Tom Tromey  <tromey@adacore.com>
 968
 969         * linux-nat.c (iterate_over_lwps): Update.
 970         (stop_callback): Remove parameter.
 971         (stop_wait_callback, detach_callback, resume_set_callback)
 972         (select_singlestep_lwp_callback, set_ignore_sigint)
 973         (status_callback, resumed_callback, resume_clear_callback)
 974         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 975         data parameter.
 976         (linux_nat_target::detach, linux_nat_target::resume)
 977         (linux_stop_and_wait_all_lwps, select_event_lwp)
 978         (linux_nat_filter_event, linux_nat_wait_1)
 979         (linux_nat_target::kill, linux_nat_target::stop)
 980         (linux_nat_target::stop): Update.
 981         (linux_nat_resume_callback): Change type.
 982         (resume_stopped_resumed_lwps, count_events_callback)
 983         (select_event_lwp_callback): Likewise.
 984         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 985         * arm-linux-nat.c (struct update_registers_data): Remove.
 986         (update_registers_callback): Change type.
 987         (arm_linux_insert_hw_breakpoint1): Update.
 988         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 989         parameter.
 990         (x86_linux_dr_set_addr): Update.
 991         (x86_linux_dr_set_control): Update.
 992         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 993         (iterate_over_lwps): Use gdb::function_view.
 994         * nat/aarch64-linux-hw-point.c (struct
 995         aarch64_dr_update_callback_param): Remove.
 996         (debug_reg_change_callback): Change type.
 997         (aarch64_notify_debug_reg_change): Update.
 998         * s390-linux-nat.c (s390_refresh_per_info): Update.
 999
1000 2019-03-11  Tom Tromey  <tromey@adacore.com>
1001
1002         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1003         redundant assignment to "this_cu".
1004
1005 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1006
1007         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1008
1009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1012         from...
1013         (rank_one_type): ... this.
1014
1015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1018         from...
1019         (rank_one_type): ... this.
1020
1021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1022
1023         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1024         from...
1025         (rank_one_type): ... this.
1026
1027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1028
1029         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1030         from...
1031         (rank_one_type): ... this.
1032
1033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1034
1035         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1036         from...
1037         (rank_one_type): ... this.
1038
1039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1040
1041         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1042         from...
1043         (rank_one_type): ... this.
1044
1045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1046
1047         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1048         from...
1049         (rank_one_type): ... this.
1050
1051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1052
1053         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1054         from...
1055         (rank_one_type): ... this.
1056
1057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1058
1059         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1060         from...
1061         (rank_one_type): ... this.
1062
1063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1064
1065         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1066         from...
1067         (rank_one_type): ... this.
1068
1069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1070
1071         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1072         from...
1073         (rank_one_type): ... this.
1074
1075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1076
1077         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1078         from...
1079         (rank_one_type): ... this.
1080
1081 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1082
1083         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1084         inferior-events' shows the example events.
1085
1086 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1087
1088         Support styling on native MS-Windows console
1089
1090         PR/24315
1091         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1092         on MS-Windows if $TERM is not defined.
1093
1094         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1095
1096         * posix-hdep.c (gdb_console_fputs):
1097         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1098         functions.
1099         * ui-file.h (gdb_console_fputs): Add prototype.
1100
1101         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1102         back to fputs only if the former returns zero.
1103
1104 2019-03-07  Tom Tromey  <tom@tromey.com>
1105
1106         * symmisc.c (print_symbol_bcache_statistics): Update.
1107         (print_objfile_statistics): Update.
1108         * symfile.c (allocate_symtab): Update.
1109         * stabsread.c: Don't include bcache.h.
1110         * psymtab.h (struct psymbol_bcache): Don't declare.
1111         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1112         (psymbol_bcache_init, psymbol_bcache_free)
1113         (psymbol_bcache_get_bcache): Don't declare.
1114         * psymtab.c (struct psymbol_bcache): Remove.
1115         (psymtab_storage::psymtab_storage): Update.
1116         (psymtab_storage::~psymtab_storage): Update.
1117         (psymbol_bcache_init, psymbol_bcache_free)
1118         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1119         (add_psymbol_to_bcache): Update.
1120         (allocate_psymtab): Update.
1121         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1122         macro_cache>: No longer pointers.
1123         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1124         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1125         * macrotab.c (macro_bcache): Update.
1126         * macroexp.c: Don't include bcache.h.
1127         * gdbtypes.c (check_types_worklist): Update.
1128         (types_deeply_equal): Remove TRY/CATCH.  Update.
1129         * elfread.c (elf_symtab_read): Update.
1130         * dwarf2read.c: Don't include bcache.h.
1131         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1132         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1133         (print_bcache_statistics, bcache_memory_used): Don't declare.
1134         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1135         methods.  Rename all data members.
1136         * bcache.c (struct bcache): Move to bcache.h.
1137         (bcache::expand_hash_table): Rename from expand_hash_table.
1138         (bcache): Remove.
1139         (bcache::insert): Rename from bcache_full.
1140         (bcache::compare): Rename from bcache_compare.
1141         (bcache_xmalloc): Remove.
1142         (bcache::~bcache): Rename from bcache_xfree.
1143         (bcache::print_statistics): Rename from print_bcache_statistics.
1144         (bcache::memory_used): Rename from bcache_memory_used.
1145
1146 2019-03-07  Pedro Alves  <palves@redhat.com>
1147
1148         * infrun.c (normal_stop): Also check for
1149         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1150
1151 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * f-lang.c (value_from_host_double): Moved to...
1154         * value.c (value_from_host_double): ...here.
1155         * value.h (value_from_host_double): Declare.
1156         * guile/scm-math.c (vlscm_convert_typed_number): Use
1157         value_from_host_double.
1158         (vlscm_convert_number): Likewise.
1159         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1160         * python/py-value.c (convert_value_from_python): Likewise.
1161
1162 2019-03-06  Tom Tromey  <tom@tromey.com>
1163
1164         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1165
1166 2019-03-06  Tom Tromey  <tom@tromey.com>
1167
1168         * utils.h (free_current_contents): Don't declare.
1169         * utils.c (free_current_contents): Remove.
1170
1171 2019-03-06  Tom Tromey  <tom@tromey.com>
1172
1173         * top.c (quit_force): Update.
1174         * main.c (captured_command_loop): Update.
1175         * common/new-op.c (operator new): Update.
1176         * common/common-exceptions.c (struct catcher)
1177         <save_cleanup_chain>: Remove member.
1178         (exceptions_state_mc_init): Update.
1179         (exception_try_scope_entry): Return nullptr.
1180         (exception_try_scope_exit, exception_rethrow)
1181         (throw_exception_sjlj, throw_exception_cxx): Update.
1182         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1183         (all_cleanups, do_cleanups, discard_cleanups)
1184         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1185         (restore_cleanups, restore_final_cleanups): Don't declare.
1186         (do_final_cleanups): Remove parameter.
1187         * common/cleanups.c (cleanup_chain, make_cleanup)
1188         (make_cleanup_dtor, all_cleanups, do_cleanups)
1189         (discard_my_cleanups, discard_cleanups)
1190         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1191         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1192         (null_cleanup): Remove.
1193         (do_final_cleanups): Remove parameter.
1194
1195 2019-03-06  Tom Tromey  <tom@tromey.com>
1196
1197         * remote.c (remote_target::remote_parse_stop_reply): Use
1198         unique_xmalloc_ptr.
1199
1200 2019-03-06  Tom Tromey  <tom@tromey.com>
1201
1202         * stabsread.c (struct stabs_field_info): Rename from field_info.
1203         <list, fnlist>: Add initializers.
1204         <obstack>: New member.
1205         (read_member_functions, read_struct_fields, read_baseclasses):
1206         Allocate on obstack.  Don't use cleanups.
1207         (read_one_struct_field, read_member_functions, read_struct_fields)
1208         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1209         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1210         (read_struct_type): Update.
1211
1212 2019-03-06  Tom Tromey  <tom@tromey.com>
1213
1214         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1215         * common/filestuff.h (make_cleanup_close): Don't declare.
1216         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1217         Remove.
1218
1219 2019-03-06  Tom Tromey  <tom@tromey.com>
1220
1221         * solib-aix.c: Use make_scope_exit.
1222
1223 2019-03-06  Tom Tromey  <tom@tromey.com>
1224
1225         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1226         Use make_scope_exit.
1227
1228 2019-03-06  Tom Tromey  <tom@tromey.com>
1229
1230         * solib-svr4.c (disable_probes_interface): Remove parameter.
1231         (svr4_handle_solib_event): Use make_scope_exit.
1232
1233 2019-03-06  Tom Tromey  <tom@tromey.com>
1234
1235         * remote.c (struct stop_reply_deleter): Remove.
1236         (stop_reply_up): Update.
1237         (struct stop_reply): Derive from notif_event.  Don't typedef.
1238         <regcache>: Now a std::vector.
1239         (stop_reply_xfree): Remove.
1240         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1241         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1242         (remote_target::discard_pending_stop_replies): Use delete.
1243         (remote_target::remote_parse_stop_reply): Update.
1244         (remote_target::process_stop_reply): Update.
1245         * remote-notif.h (struct notif_event): Add virtual destructor.
1246         Remove "dtr" member.
1247         (struct notif_client) <alloc_event>: Return a unique_ptr.
1248         (notif_event_xfree): Don't declare.
1249         (notif_event_up): New typedef.
1250         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1251         (notif_event_xfree, do_notif_event_xfree): Remove.
1252         (remote_notif_state_xfree): Update.
1253
1254 2019-03-06  Tom Tromey  <tom@tromey.com>
1255
1256         * infrun.c (displaced_step_clear_cleanup): Now a
1257         forward_scope_exit type.
1258         (displaced_step_prepare_throw): Update.
1259         (displaced_step_fixup): Update.
1260
1261 2019-03-06  Tom Tromey  <tom@tromey.com>
1262
1263         * inferior.h (class inferior): Update comment.
1264         * gdbthread.h (class thread_info): Update comment.
1265
1266 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1267             Tom Tromey  <tom@tromey.com>
1268
1269         * stabsread.h (struct stab_section_list): Remove.
1270         (coffstab_build_psymtabs): Update.
1271         * dbxread.c (symbuf_sections): Now a std::vector.
1272         (sect_idx): New global.
1273         (fill_symbuf): Update.
1274         (coffstab_build_psymtabs): Change type of stabsects parameter.
1275         Update.
1276         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1277         std::vector.
1278         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1279         (coff_locate_sections): Update.
1280         (coff_symfile_read): Remove cleanups.  Update.
1281         (init_stringtab): Add storage parameter.
1282         (free_stringtab, free_stringtab_cleanup): Remove.
1283         (init_lineno): Add storage parameter.
1284         (free_linetab, free_linetab_cleanup): Remove.
1285
1286 2019-03-06  Pedro Alves  <palves@redhat.com>
1287
1288         * linux-fork.c (fork_info::clobber_regs): Delete.
1289         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1290         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1291         comment.  Adjust.
1292         (scoped_switch_fork_info::scoped_switch_fork_info)
1293         (checkpoint_command, linux_fork_context): Adjust
1294         fork_save_infrun_state calls.
1295
1296 2019-03-06  Pedro Alves  <palves@redhat.com>
1297
1298         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1299         (inf_has_multiple_threads): Return 'bool' and rewrite using
1300         inferior_info::threads().
1301
1302 2019-03-06  Pedro Alves  <palves@redhat.com>
1303
1304         * linux-fork.c: Include <list>.
1305         (fork_list): Now a std::list instance.
1306         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1307         (forks_exist_p, find_last_fork): Adjust.
1308         (new_fork): Delete.
1309         (one_fork_p): New.
1310         (add_fork): Adjust.
1311         (free_fork): Delete, folded into fork_info::~fork_info().
1312         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1313         Adjust.
1314         (init_fork_list): Delete.
1315         (linux_fork_killall, linux_fork_mourn_inferior)
1316         (linux_fork_detach, info_checkpoints_command): Adjust.
1317         (_initialize_linux_fork): No longer call init_fork_list.
1318
1319 2019-03-06  Pedro Alves  <palves@redhat.com>
1320
1321         * linux-fork.c (new_fork): New, split out of ...
1322         (add_fork): ... this.  Return void.  Move "first fork" special
1323         case from here, to ...
1324         (checkpoint_command): ... here.
1325         * linux-linux.h (add_fork): Return void.
1326
1327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1328
1329         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1330
1331 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1332             Chris January  <chris.january@arm.com>
1333             David Lecomber  <david.lecomber@arm.com>
1334
1335         * f-exp.y: New token, UNOP_INTRINSIC.
1336         (exp): New pattern using UNOP_INTRINSIC token.
1337         (f77_keywords): Add 'abs' keyword.
1338         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1339         (value_from_host_double): New function.
1340         (evaluate_subexp_f): Support UNOP_ABS.
1341
1342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1345         types.
1346
1347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1350         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1351         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1352
1353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1356
1357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1358             Chris January  <chris.january@arm.com>
1359
1360         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1361         * f-exp.y: Define 'KIND' token.
1362         (exp): New pattern for KIND expressions.
1363         (ptype): Handle types with a kind extension.
1364         (direct_abs_decl): Extend to spot kind extensions.
1365         (f77_keywords): Add 'kind' to the list.
1366         (push_kind_type): New function.
1367         (convert_to_kind_type): New function.
1368         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1369         * parse.c (operator_length_standard): Likewise.
1370         * parser-defs.h (enum type_pieces): Add tp_kind.
1371         * std-operator.def: Add UNOP_KIND.
1372
1373 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * f-exp.y (f_parse): Set yydebug.
1376
1377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * f-lang.c (evaluate_subexp_f): New function.
1380         (exp_descriptor_f): New global.
1381         (f_language_defn): Use exp_descriptor_f instead of
1382         exp_descriptor_standard.
1383
1384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1385
1386         * f-exp.y (struct token): Add comments.
1387         (dot_ops): Remove uppercase versions and the end marker.
1388         (f77_keywords): Likewise.
1389         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1390         entries in the dot_ops array are case insensitive, and use
1391         strncasecmp to compare strings.  Also some whitespace cleanup in
1392         this area.  Similar for the f77_keywords array, except entries in
1393         this list might be case sensitive.
1394
1395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * f-exp.y (struct f77_boolean_val): Add comments.
1398         (boolean_values): Remove uppercase versions, and end marker.
1399         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1400         and use strncasecmp to achieve case insensitivity.  Additionally,
1401         perform whitespace cleanup around this code.
1402
1403 2019-03-06  Tom Tromey  <tromey@adacore.com>
1404
1405         * remote-sim.c (gdbsim_target_open): Use result of
1406         gdb_argv::release.
1407
1408 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1409         Dirk Schubert  <dirk.schubert@arm.com>
1410         Chris January  <chris.january@arm.com>
1411
1412         * eval.c (evaluate_subexp_standard): Call Fortran argument
1413         wrapping logic.
1414         * f-lang.c (struct value): A value which can be passed into a
1415         Fortran function call.
1416         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1417         where appropriate.
1418         (struct type): Value ready for a Fortran function call.
1419         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1420         is needed.
1421         * f-lang.h (fortran_argument_convert): Declaration.
1422         (fortran_preserve_arg_pointer): Declaration.
1423         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1424
1425 2019-03-05  Tom Tromey  <tromey@adacore.com>
1426
1427         * python/py-prettyprint.c (print_string_repr): Remove #if.
1428         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1429
1430 2019-03-05  Tom Tromey  <tromey@adacore.com>
1431
1432         * target.c (the_dummy_target): Move later.  Change type to
1433         "dummy_target".
1434         (initialize_targets): Don't initialize the_dummy_target.
1435
1436 2019-03-05  Tom Tromey  <tromey@adacore.com>
1437
1438         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1439         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1440
1441 2019-03-05  Tom Tromey  <tromey@adacore.com>
1442
1443         * windows-nat.c (windows_nat_target::attach)
1444         (windows_nat_target::detach): Don't call gdb_flush.
1445         * valprint.c (generic_val_print, val_print, val_print_string):
1446         Don't call gdb_flush.
1447         * utils.c (defaulted_query): Don't call gdb_flush.
1448         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1449         * target.c (target_announce_detach): Don't call gdb_flush.
1450         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1451         * remote.c (extended_remote_target::attach): Don't call
1452         gdb_flush.
1453         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1454         * printcmd.c (do_examine): Don't call gdb_flush.
1455         (info_display_command): Don't call gdb_flush.
1456         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1457         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1458         * memattr.c (info_mem_command): Don't call gdb_flush.
1459         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1460         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1461         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1462         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1463         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1464         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1465         (gnu_nat_target::detach): Don't call gdb_flush.
1466         * f-valprint.c (f_val_print): Don't call gdb_flush.
1467         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1468         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1469         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1470         gdb_flush.
1471         * c-valprint.c (c_val_print): Don't call gdb_flush.
1472         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1473
1474 2019-03-05  Tom Tromey  <tromey@adacore.com>
1475
1476         * varobj.c (update_dynamic_varobj_children): Update.
1477         (install_default_visualizer): Use reset, not release.
1478         * value.c (set_internalvar): Update.
1479         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1480         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1481         ATTRIBUTE_UNUSED_RESULT.
1482
1483 2019-03-05  Tom Tromey  <tromey@adacore.com>
1484
1485         * remote.c (class scoped_remote_fd) <release>: Add
1486         ATTRIBUTE_UNUSED_RESULT.
1487
1488 2019-03-05  Tom Tromey  <tromey@adacore.com>
1489
1490         * macroexp.c (struct macro_buffer) <release>: Add
1491         ATTRIBUTE_UNUSED_RESULT.
1492
1493 2019-03-05  Tom Tromey  <tromey@adacore.com>
1494
1495         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1496         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1497         ATTRIBUTE_UNUSED_RESULT.
1498
1499 2019-03-05  Tom Tromey  <tromey@adacore.com>
1500
1501         * common/scoped_fd.h (class scoped_fd) <release>: Add
1502         ATTRIBUTE_UNUSED_RESULT.
1503
1504 2019-03-05  Tom Tromey  <tromey@adacore.com>
1505
1506         * parser-defs.h (struct parser_state) <release>: Add
1507         ATTRIBUTE_UNUSED_RESULT.
1508
1509 2019-03-05  Tom Tromey  <tromey@adacore.com>
1510
1511         * utils.h (class gdb_argv) <release>: Add
1512         ATTRIBUTE_UNUSED_RESULT.
1513         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1514
1515 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1516
1517         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1518         for-loop range, to avoid compiler warnings.
1519
1520         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1521         avoid compiler warnings about unused variables.
1522
1523         * NEWS: Mention end of support for native debugging on MS-Windows
1524         before XP.
1525
1526         PR gdb/24292
1527         * common/netstuff.c:
1528         * gdbserver/gdbreplay.c
1529         * gdbserver/remote-utils.c:
1530         * ser-tcp.c:
1531         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1532         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1533         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1534         'getaddrinfo' and 'freeaddrinfo' were not available before
1535         Windows XP, and mingw.org's MinGW headers by default define
1536         _WIN32_WINNT to 0x500.
1537
1538 2019-03-01  Gary Benson <gbenson@redhat.com>
1539
1540         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1541
1542 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1543             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1544
1545         PR gdb/8527
1546         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1547         set_sigint_trap, clear_sigint_trap.
1548
1549 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1550
1551         * target.c (target_detach): Clear the regcache and the
1552         frame cache.
1553
1554 2019-02-27  Pedro Alves  <palves@redhat.com>
1555
1556         * utils.c (set_screen_size): When we cap the height/width sizes,
1557         tweak the corresponding command variable to show "unlimited":
1558
1559 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1560             Pedro Alves  <palves@redhat.com>
1561
1562         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1563         before calling rl_set_screen_size.
1564
1565 2019-02-27  Tom Tromey  <tromey@adacore.com>
1566
1567         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1568         define.
1569         * python/py-value.c: Remove Python 2.4 workaround.
1570         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1571         workaround.
1572         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1573         Python 2.4 workaround.
1574         * python/python-internal.h: Remove Python 2.4 comment.
1575         (Py_ssize_t): Don't define.
1576         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1577         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1578         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1579         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1580         * python/python.c (do_start_initialization): Remove Python 2.4
1581         workaround.
1582         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1583         (print_children): Remove Python 2.4 workaround.
1584         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1585         workaround.
1586         (CHARBUFFERPROC_NAME): Remove.
1587         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1588         Python 2.4 workaround.
1589
1590 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1591
1592         * NEWS: Note minimum Python version.
1593
1594 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1595
1596         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1597         code from these functions.  Remove corresponding ifdefs.  Use
1598         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1599         Remove gotos and target of gotos.
1600         (infpy_search_memory): Likewise.
1601
1602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1605         (hppa_gdbarch_init): Don't register deleted functions with
1606         gdbarch.
1607
1608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1611         (h8300_unwind_sp): Delete.
1612         (h8300_dummy_id): Delete.
1613         (h8300_gdbarch_init): Don't register deleted functions with
1614         gdbarch.
1615
1616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1617
1618         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1619         (ft32_unwind_pc): Delete.
1620         (ft32_unwind_sp): Delete.
1621         (ft32_gdbarch_init): Don't register deleted functions with
1622         gdbarch.
1623
1624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1627         (frv_unwind_pc): Delete.
1628         (frv_unwind_sp): Delete.
1629         (frv_gdbarch_init): Don't register deleted functions with
1630         gdbarch.
1631
1632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1633
1634         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1635         (riscv_unwind_pc): Delete.
1636         (riscv_unwind_sp): Delete.
1637         (riscv_gdbarch_init): Don't register deleted functions with
1638         gdbarch.
1639
1640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1641
1642         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1643         (csky_unwind_pc): Delete.
1644         (csky_unwind_sp): Delete.
1645         (csky_gdbarch_init): Don't register deleted functions with
1646         gdbarch.
1647
1648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1651         (cris_unwind_pc): Delete.
1652         (cris_unwind_sp): Delete.
1653         (cris_gdbarch_init): Don't register deleted functions with
1654         gdbarch.
1655
1656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1659         (bfin_unwind_pc): Delete.
1660         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1661
1662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1665         (arm_unwind_pc): Delete.
1666         (arm_unwind_sp): Delete.
1667         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1668
1669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1672         (arc_unwind_pc): Delete.
1673         (arc_unwind_sp): Delete.
1674         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1675
1676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1677
1678         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1679         (alpha_unwind_pc): Delete.
1680         (alpha_gdbarch_init): Don't register deleted functions with
1681         gdbarch.
1682
1683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1686         (aarch64_unwind_pc): Delete.
1687         (aarch64_unwind_sp): Delete.
1688         (aarch64_gdbarch_init): Don't register deleted functions with
1689         gdbarch.
1690
1691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * gdbtypes.c (type_align): Don't consider static members when
1694         computing structure alignment.
1695
1696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1697
1698         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1699         return 0 for other types.
1700         * arch-utils.c (default_type_align): Always return 0.
1701         * gdbarch.h: Regenerate.
1702         * gdbarch.sh (type_align): Extend comment.
1703         * gdbtypes.c (type_align): Add additional comments, always call
1704         gdbarch_type_align before applying the default rules.
1705         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1706         generic code will then apply a suitable default.
1707         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1708         types, return 0 for other types.
1709
1710 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1711
1712         * NEWS: Create a new section for the next release branch.
1713         Rename the section of the current branch, now that it has
1714         been cut.
1715
1716 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1717
1718         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1719         * version.in: Bump version to 8.3.50.DATE-git.
1720
1721 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1722
1723         * aix-thread.c (ptid_cmp): Remove unused variable.
1724         (get_signaled_thread): Likewise.
1725         (store_regs_user_thread): Likewise.
1726         (store_regs_kernel_thread): Likewise.
1727         (fetch_regs_kernel_thread): Remove shadowed variable.
1728
1729 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1730
1731         * features/riscv/32bit-cpu.xml: Add register numbers.
1732         * features/riscv/32bit-fpu.c: Regenerate.
1733         * features/riscv/32bit-fpu.xml: Add register numbers.
1734         * features/riscv/64bit-cpu.xml: Add register numbers.
1735         * features/riscv/64bit-fpu.c: Regenerate.
1736         * features/riscv/64bit-fpu.xml: Add register numbers.
1737
1738 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1739
1740         * NEWS: Mention two argument form of gdb.Value constructor.
1741         * python/py-value.c (convert_buffer_and_type_to_value): New
1742         function.
1743         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1744         Add support for handling an optional second argument.  Call
1745         convert_buffer_and_type_to_value as appropriate.
1746         * python/python-internal.h (Py_buffer_deleter): New struct.
1747         (Py_buffer_up): New typedef.
1748
1749 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1750
1751         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1752         instead of releasing ownership.
1753
1754 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1755
1756         * dwarf2read.c (open_and_init_dwp_file): Call
1757         elf_numsections instead of bfd_count_sections to initialize
1758         dwp_file->num_sections.
1759
1760 2019-02-25  Tom Tromey  <tromey@adacore.com>
1761
1762         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1763
1764 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1765
1766         * gcore.in: Add '--readnever' option when invoking GDB.
1767
1768 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1769
1770         * MAINTAINERS: Update my email address.
1771
1772 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1773
1774         * build-id.c (build_id_to_debug_bfd_1): New function.
1775         (build_id_to_debug_bfd): Look for separate debug file in
1776         sysroot.
1777
1778 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1779
1780         * gdbarch.sh: Update the copyright year range that is placed into
1781         generated files.
1782
1783 2019-02-22  Keith Seitz  <keiths@redhat.com>
1784
1785         PR symtab/23853
1786         * linespec.c (create_sals_line_offset): Search for the default
1787         symtab's filename instead of its fullname.
1788
1789 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1790
1791         * NEWS: Update style defaults.
1792
1793 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1794
1795         * main.c (captured_main_1): Disable styling in batch mode.
1796
1797 2019-02-20  Tom Tromey  <tom@tromey.com>
1798
1799         * symtab.c (symtab_symbol_info): Fix typos.
1800
1801 2019-02-20  Tom Tromey  <tromey@adacore.com>
1802
1803         * findcmd.c (_initialize_mem_search): Use upper case for
1804         metasyntactic variables.
1805
1806 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1807
1808         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1809         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1810
1811 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1812
1813         * top.h (source_file_name): Change to std::string.
1814         * top.c (source_file_name): Likewise.
1815         (command_line_input): Adjust.
1816         * cli/cli-script.c (script_from_file): Adjust.
1817
1818 2019-02-19  Tom Tromey  <tromey@adacore.com>
1819
1820         * ravenscar-thread.c
1821         (ravenscar_thread_target::update_thread_list): Don't call
1822         ada_build_task_list.
1823         * ada-lang.h (ada_build_task_list): Don't declare.
1824         * ada-tasks.c (struct ada_tasks_inferior_data)
1825         <task_list_valid_p>: Now bool.
1826         (read_known_tasks, ada_task_list_changed)
1827         (ada_tasks_invalidate_inferior_data): Update.
1828         (read_known_tasks_array): Return bool.
1829         (read_known_tasks_list): Likewise.
1830         (read_known_tasks): Return void.
1831         (ada_build_task_list): Now static.
1832
1833 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1834
1835         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1836         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1837
1838 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1839
1840         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1841         variant for ada_tasks_pspace_data_handle and
1842         ada_tasks_inferior_data_handle.
1843         (ada_tasks_pspace_data_cleanup): New function.
1844         (ada_tasks_inferior_data_cleanup): New function.
1845
1846 2019-02-17  Tom Tromey  <tom@tromey.com>
1847
1848         * macrotab.h (macro_source_fullname): Return a std::string.
1849         * macrotab.c (macro_include, check_for_redefinition)
1850         (macro_undef, macro_lookup_definition, foreach_macro)
1851         (foreach_macro_in_scope): Update.
1852         (macro_source_fullname): Return a std::string.
1853         * macrocmd.c (show_pp_source_pos): Update.
1854
1855 2019-02-17  Tom Tromey  <tom@tromey.com>
1856
1857         * macrocmd.c (show_pp_source_pos): Style the file names.
1858
1859 2019-02-17  Tom Tromey  <tom@tromey.com>
1860
1861         PR tui/24197:
1862         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1863
1864 2019-02-17  Tom Tromey  <tom@tromey.com>
1865
1866         * ada-lang.c (user_select_syms): Use filtered printing.
1867         * utils.c (wrap_style): New global.
1868         (desired_style): Remove.
1869         (emit_style_escape): Add stream parameter.
1870         (set_output_style, reset_terminal_style, prompt_for_continue):
1871         Update.
1872         (flush_wrap_buffer): Only flush gdb_stdout.
1873         (wrap_here): Set wrap_style.
1874         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1875         treat escape sequences as a character.  Change when wrap buffer is
1876         flushed.
1877         (fputs_styled): Do not set the output style when the default is
1878         requested.
1879         * ui-style.h (struct ui_file_style) <is_default>: New method.
1880         * source.c (print_source_lines_base): Emit escape sequences in one
1881         piece.
1882
1883 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1884
1885         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1886         integers and enumeration types.
1887
1888 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1889
1890         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1891         instead of lookup_symbol_in_language
1892         (do_exact_match): New function.
1893         (ada_get_symbol_name_matcher): Return do_exact_match when
1894         doing a verbatim match.
1895
1896 2019-02-15  Tom Tromey  <tromey@adacore.com>
1897
1898         * ravenscar-thread.c (ravenscar_thread_target::resume)
1899         (ravenscar_thread_target::wait): Special case wildcard requests.
1900
1901 2019-02-15  Tom Tromey  <tromey@adacore.com>
1902
1903         * ravenscar-thread.c (base_ptid): Remove.
1904         (struct ravenscar_thread_target) <close>: New method.
1905         <m_base_ptid>: New member.
1906         <update_inferior_ptid, active_task, task_is_currently_active,
1907         runtime_initialized>: Declare methods.
1908         <ravenscar_thread_target>: Add constructor.
1909         (ravenscar_thread_target::task_is_currently_active)
1910         (ravenscar_thread_target::update_inferior_ptid)
1911         (ravenscar_runtime_initialized): Rename.  Now methods.
1912         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1913         (ravenscar_thread_target::update_thread_list): Update.
1914         (ravenscar_thread_target::active_task): Now method.
1915         (ravenscar_thread_target::store_registers)
1916         (ravenscar_thread_target::prepare_to_store)
1917         (ravenscar_thread_target::prepare_to_store)
1918         (ravenscar_thread_target::mourn_inferior): Update.
1919         (ravenscar_inferior_created): Use "new" to create target.
1920         (ravenscar_thread_target::get_ada_task_ptid): Update.
1921         (_initialize_ravenscar): Don't initialize base_ptid.
1922         (ravenscar_ops): Remove global.
1923
1924 2019-02-15  Tom Tromey  <tromey@adacore.com>
1925
1926         * target.h (push_target): Declare new overload.
1927         * target.c (push_target): New overload, taking an rvalue reference.
1928         * remote.c (remote_target::open_1): Use push_target overload.
1929         * corelow.c (core_target_open): Use push_target overload.
1930
1931 2019-02-15  Tom Tromey  <tromey@adacore.com>
1932
1933         * ravenscar-thread.c (is_ravenscar_task)
1934         (ravenscar_task_is_currently_active): Return bool.
1935         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1936         (_initialize_ravenscar): Remove "(void)".
1937         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1938         Return bool.
1939
1940 2019-02-15  Tom Tromey  <tromey@adacore.com>
1941
1942         * ravenscar-thread.c (ravenscar_runtime_initializer)
1943         (has_ravenscar_runtime, get_running_thread_id)
1944         (ravenscar_thread_target::resume): Fix indentation.
1945
1946 2019-02-15  Tom Tromey  <tromey@adacore.com>
1947
1948         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1949         from ravenscar_arch_ops.
1950         (sparc_ravenscar_ops::fetch_registers)
1951         (sparc_ravenscar_ops::store_registers): Now methods.
1952         (sparc_ravenscar_prepare_to_store): Remove.
1953         (sparc_ravenscar_ops): Redefine.
1954         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1955         methods and destructor.  Remove members.
1956         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1957         (ravenscar_thread_target::store_registers)
1958         (ravenscar_thread_target::prepare_to_store): Update.
1959         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1960         Remove.
1961         (struct ppc_ravenscar_powerpc_ops): Derive from
1962         ravenscar_arch_ops.
1963         (ppc_ravenscar_powerpc_ops::fetch_registers)
1964         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1965         (ppc_ravenscar_powerpc_ops): Redefine.
1966         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1967         (ppc_ravenscar_e500_ops::fetch_registers)
1968         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1969         (ppc_ravenscar_e500_ops): Redefine.
1970         * aarch64-ravenscar-thread.c
1971         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1972         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1973         (aarch64_ravenscar_fetch_registers)
1974         (aarch64_ravenscar_store_registers): Now methods.
1975         (aarch64_ravenscar_ops): Redefine.
1976
1977 2019-02-15  Tom Tromey  <tromey@adacore.com>
1978
1979         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1980         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1981         (ravenscar_thread_target::stopped_by_watchpoint)
1982         (ravenscar_thread_target::stopped_data_address)
1983         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1984
1985 2019-02-15  Tom Tromey  <tromey@adacore.com>
1986
1987         * ravenscar-thread.c: Fix some typos.
1988
1989 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1990             Tom Tromey  <tromey@adacore.com>
1991
1992         * ada-lang.c (ada_exception_sal): Change addr_string to a
1993         std::string.
1994         (create_ada_exception_catchpoint): Update.
1995
1996 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1997             Tom Tromey  <tromey@adacore.com>
1998
1999         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2000         (bp_location_ops): Remove.
2001         (base_breakpoint_allocate_location): Update.
2002         (free_bp_location): Update.
2003         * ada-lang.c (class ada_catchpoint_location)
2004         <ada_catchpoint_location>: Remove ops parameter.
2005         (ada_catchpoint_location_dtor): Remove.
2006         (ada_catchpoint_location_ops): Remove.
2007         (allocate_location_exception): Update.
2008         * breakpoint.h (struct bp_location_ops): Remove.
2009         (class bp_location) <bp_location>: Remove bp_location_ops
2010         parameter.
2011         <~bp_location>: Add destructor.
2012         <ops>: Remove.
2013
2014 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2015             Pedro Alves  <palves@redhat.com>
2016
2017         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2018         'PATH_MAX'.
2019
2020 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2021             Samuel Thibault  <samuel.thibault@gnu.org>
2022             Thomas Schwinge  <thomas@codesourcery.com>
2023
2024         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2025         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2026
2027 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2028
2029         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2030         (check_empty): Use "const char *".
2031
2032         * gnu-nat.c (gnu_nat_target::detach): Instead of
2033         'detach_inferior (pid)' call
2034         'detach_inferior (find_inferior_pid (pid))'.
2035
2036         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2037         'nat/fork-inferior.o'.
2038         * gnu-nat.c: #include "nat/fork-inferior.h".
2039
2040         * gnu-nat.c (gnu_nat_target::detach): Instead of
2041         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2042         * gnu-nat.h: #include "inf-child.h".
2043         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2044         'i386_gnu_nat_target::fetch_registers'.
2045         (gnu_store_registers): Rename/move to
2046         'i386_gnu_nat_target::store_registers'.
2047
2048         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2049         * gnu-nat.h (mach_thread_info): New function.
2050         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2051
2052         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2053
2054 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2055
2056         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2057
2058 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2059
2060         * windows-nat.c (windows_add_thread): Add new parameter
2061         "main_thread_p" with default value set to false.  Update
2062         function documentation as well as all callers.
2063         (windows_delete_thread): Likewise.
2064         (fake_create_process): Update call to windows_add_thread.
2065         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2066         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2067         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2068         call to windows_delete_thread.
2069
2070 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2071
2072         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2073
2074 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2075
2076         * symfile.c (find_separate_debug_file): Use canonical path of
2077         sysroot with child_path instead of gdb_sysroot if it is valid.
2078
2079 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2080
2081         * symfile.c (find_separate_debug_file): Use child_path to
2082         determine if an object file is under a sysroot.
2083
2084 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2085
2086         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2087         unittests/child-path-selftests.c.
2088         * common/pathstuff.c (child_path): New function.
2089         * common/pathstuff.h (child_path): New prototype.
2090         * unittests/child-path-selftests.c: New file.
2091
2092 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2093
2094         * symfile.c (find_separate_debug_file): Look for separate debug
2095         files in debug directories under the sysroot.
2096
2097 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2098
2099         * symtab.h (struct minimal_symbol data_p): New const method.
2100         (struct minimal_symbol text_p): Likewise.
2101         * symtab.c (output_source_filename): Use file name style
2102         to print file name.
2103         (print_symbol_info): Likewise.
2104         (print_msymbol_info): Use address style to print addresses.
2105         Use function name style to print executable text symbols.
2106         (expand_symtab_containing_pc): Use data_p.
2107         (find_pc_sect_compunit_symtab): Likewise.
2108
2109 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2110
2111         * breakpoint.c (describe_other_breakpoints): Use address style
2112         to print addresses.
2113         (say_where): Likewise.
2114
2115 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2116
2117         * ada-typeprint.c (print_func_type): Print function name
2118         style to print function name.
2119         * c-typeprint.c (c_print_type_1): Likewise.
2120
2121 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2122
2123         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2124         for execve.
2125
2126 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2127
2128         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2129         type_stack.
2130
2131 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2132
2133         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2134         TYPE_CODE_REF types.
2135
2136 2019-02-08  Jim Wilson  <jimw@sifive.com>
2137
2138         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2139         (riscv_linux_fregset): New.
2140         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2141
2142 2019-02-07  Tom Tromey  <tom@tromey.com>
2143
2144         * thread.c (thread_cancel_execution_command): Update.
2145         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2146         methods.
2147         (struct thread_fsm_ops): Remove.
2148         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2149         (thread_fsm_should_stop, thread_fsm_return_value)
2150         (thread_fsm_set_finished, thread_fsm_finished_p)
2151         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2152         Don't declare.
2153         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2154         * infrun.c (clear_proceed_status_thread)
2155         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2156         (print_stop_event): Update.
2157         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2158         Add constructor.
2159         (step_command_fsm_ops): Remove.
2160         (new_step_command_fsm): Remove.
2161         (step_1): Update.
2162         (step_command_fsm::should_stop): Rename from
2163         step_command_fsm_should_stop.
2164         (step_command_fsm::clean_up): Rename from
2165         step_command_fsm_clean_up.
2166         (step_command_fsm::do_async_reply_reason): Rename from
2167         step_command_fsm_async_reply_reason.
2168         (struct until_next_fsm): Inherit from thread_fsm.  Add
2169         constructor.
2170         (until_next_fsm_ops): Remove.
2171         (new_until_next_fsm): Remove.
2172         (until_next_fsm::should_stop): Rename from
2173         until_next_fsm_should_stop.
2174         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2175         (until_next_fsm::do_async_reply_reason): Rename from
2176         until_next_fsm_async_reply_reason.
2177         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2178         constructor.  Change type of breakpoint.
2179         (finish_command_fsm_ops): Remove.
2180         (new_finish_command_fsm): Remove.
2181         (finish_command_fsm::should_stop): Rename from
2182         finish_command_fsm_should_stop.
2183         (finish_command_fsm::clean_up): Rename from
2184         finish_command_fsm_clean_up.
2185         (finish_command_fsm::return_value): Rename from
2186         finish_command_fsm_return_value.
2187         (finish_command_fsm::do_async_reply_reason): Rename from
2188         finish_command_fsm_async_reply_reason.
2189         (finish_command): Update.
2190         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2191         Add constructor.
2192         (call_thread_fsm_ops): Remove.
2193         (call_thread_fsm::call_thread_fsm): Rename from
2194         new_call_thread_fsm.
2195         (call_thread_fsm::should_stop): Rename from
2196         call_thread_fsm_should_stop.
2197         (call_thread_fsm::should_notify_stop): Rename from
2198         call_thread_fsm_should_notify_stop.
2199         (run_inferior_call, call_function_by_hand_dummy): Update.
2200         * cli/cli-interp.c (should_print_stop_to_console): Update.
2201         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2202         Add constructor.  Change type of location_breakpoint,
2203         caller_breakpoint.
2204         (until_break_fsm_ops): Remove.
2205         (new_until_break_fsm): Remove.
2206         (until_break_fsm::should_stop): Rename from
2207         until_break_fsm_should_stop.
2208         (until_break_fsm::clean_up): Rename from
2209         until_break_fsm_clean_up.
2210         (until_break_fsm::do_async_reply_reason): Rename from
2211         until_break_fsm_async_reply_reason.
2212         (until_break_command): Update.
2213         * thread-fsm.c: Remove.
2214         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2215
2216 2019-02-07  Tom Tromey  <tom@tromey.com>
2217
2218         * yy-remap.h: Add include guard.
2219         * xtensa-tdep.h: Add include guard.
2220         * xcoffread.h: Rename include guard.
2221         * varobj-iter.h: Add include guard.
2222         * tui/tui.h: Rename include guard.
2223         * tui/tui-winsource.h: Rename include guard.
2224         * tui/tui-wingeneral.h: Rename include guard.
2225         * tui/tui-windata.h: Rename include guard.
2226         * tui/tui-win.h: Rename include guard.
2227         * tui/tui-stack.h: Rename include guard.
2228         * tui/tui-source.h: Rename include guard.
2229         * tui/tui-regs.h: Rename include guard.
2230         * tui/tui-out.h: Rename include guard.
2231         * tui/tui-layout.h: Rename include guard.
2232         * tui/tui-io.h: Rename include guard.
2233         * tui/tui-hooks.h: Rename include guard.
2234         * tui/tui-file.h: Rename include guard.
2235         * tui/tui-disasm.h: Rename include guard.
2236         * tui/tui-data.h: Rename include guard.
2237         * tui/tui-command.h: Rename include guard.
2238         * tic6x-tdep.h: Add include guard.
2239         * target/waitstatus.h: Rename include guard.
2240         * target/wait.h: Rename include guard.
2241         * target/target.h: Rename include guard.
2242         * target/resume.h: Rename include guard.
2243         * target-float.h: Rename include guard.
2244         * stabsread.h: Add include guard.
2245         * rs6000-tdep.h: Add include guard.
2246         * riscv-fbsd-tdep.h: Add include guard.
2247         * regformats/regdef.h: Rename include guard.
2248         * record.h: Rename include guard.
2249         * python/python.h: Rename include guard.
2250         * python/python-internal.h: Rename include guard.
2251         * python/py-stopevent.h: Rename include guard.
2252         * python/py-ref.h: Rename include guard.
2253         * python/py-record.h: Rename include guard.
2254         * python/py-record-full.h: Rename include guard.
2255         * python/py-record-btrace.h: Rename include guard.
2256         * python/py-instruction.h: Rename include guard.
2257         * python/py-events.h: Rename include guard.
2258         * python/py-event.h: Rename include guard.
2259         * procfs.h: Add include guard.
2260         * proc-utils.h: Add include guard.
2261         * p-lang.h: Add include guard.
2262         * or1k-tdep.h: Rename include guard.
2263         * observable.h: Rename include guard.
2264         * nto-tdep.h: Rename include guard.
2265         * nat/x86-linux.h: Rename include guard.
2266         * nat/x86-linux-dregs.h: Rename include guard.
2267         * nat/x86-gcc-cpuid.h: Add include guard.
2268         * nat/x86-dregs.h: Rename include guard.
2269         * nat/x86-cpuid.h: Rename include guard.
2270         * nat/ppc-linux.h: Rename include guard.
2271         * nat/mips-linux-watch.h: Rename include guard.
2272         * nat/linux-waitpid.h: Rename include guard.
2273         * nat/linux-ptrace.h: Rename include guard.
2274         * nat/linux-procfs.h: Rename include guard.
2275         * nat/linux-osdata.h: Rename include guard.
2276         * nat/linux-nat.h: Rename include guard.
2277         * nat/linux-namespaces.h: Rename include guard.
2278         * nat/linux-btrace.h: Rename include guard.
2279         * nat/glibc_thread_db.h: Rename include guard.
2280         * nat/gdb_thread_db.h: Rename include guard.
2281         * nat/gdb_ptrace.h: Rename include guard.
2282         * nat/fork-inferior.h: Rename include guard.
2283         * nat/amd64-linux-siginfo.h: Rename include guard.
2284         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2285         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2286         * nat/aarch64-linux.h: Rename include guard.
2287         * nat/aarch64-linux-hw-point.h: Rename include guard.
2288         * mn10300-tdep.h: Add include guard.
2289         * mips-linux-tdep.h: Add include guard.
2290         * mi/mi-parse.h: Rename include guard.
2291         * mi/mi-out.h: Rename include guard.
2292         * mi/mi-main.h: Rename include guard.
2293         * mi/mi-interp.h: Rename include guard.
2294         * mi/mi-getopt.h: Rename include guard.
2295         * mi/mi-console.h: Rename include guard.
2296         * mi/mi-common.h: Rename include guard.
2297         * mi/mi-cmds.h: Rename include guard.
2298         * mi/mi-cmd-break.h: Rename include guard.
2299         * m2-lang.h: Add include guard.
2300         * location.h: Rename include guard.
2301         * linux-record.h: Rename include guard.
2302         * linux-nat.h: Add include guard.
2303         * linux-fork.h: Add include guard.
2304         * i386-darwin-tdep.h: Rename include guard.
2305         * hppa-linux-offsets.h: Add include guard.
2306         * guile/guile.h: Rename include guard.
2307         * guile/guile-internal.h: Rename include guard.
2308         * gnu-nat.h: Rename include guard.
2309         * gdb-stabs.h: Rename include guard.
2310         * frv-tdep.h: Add include guard.
2311         * f-lang.h: Add include guard.
2312         * event-loop.h: Add include guard.
2313         * darwin-nat.h: Rename include guard.
2314         * cp-abi.h: Rename include guard.
2315         * config/sparc/nm-sol2.h: Rename include guard.
2316         * config/nm-nto.h: Rename include guard.
2317         * config/nm-linux.h: Add include guard.
2318         * config/i386/nm-i386gnu.h: Rename include guard.
2319         * config/djgpp/nl_types.h: Rename include guard.
2320         * config/djgpp/langinfo.h: Rename include guard.
2321         * compile/gcc-cp-plugin.h: Add include guard.
2322         * compile/gcc-c-plugin.h: Add include guard.
2323         * compile/compile.h: Rename include guard.
2324         * compile/compile-object-run.h: Rename include guard.
2325         * compile/compile-object-load.h: Rename include guard.
2326         * compile/compile-internal.h: Rename include guard.
2327         * compile/compile-cplus.h: Rename include guard.
2328         * compile/compile-c.h: Rename include guard.
2329         * common/xml-utils.h: Rename include guard.
2330         * common/x86-xstate.h: Rename include guard.
2331         * common/version.h: Rename include guard.
2332         * common/vec.h: Rename include guard.
2333         * common/tdesc.h: Rename include guard.
2334         * common/selftest.h: Rename include guard.
2335         * common/scoped_restore.h: Rename include guard.
2336         * common/scoped_mmap.h: Rename include guard.
2337         * common/scoped_fd.h: Rename include guard.
2338         * common/safe-iterator.h: Rename include guard.
2339         * common/run-time-clock.h: Rename include guard.
2340         * common/refcounted-object.h: Rename include guard.
2341         * common/queue.h: Rename include guard.
2342         * common/ptid.h: Rename include guard.
2343         * common/print-utils.h: Rename include guard.
2344         * common/preprocessor.h: Rename include guard.
2345         * common/pathstuff.h: Rename include guard.
2346         * common/observable.h: Rename include guard.
2347         * common/netstuff.h: Rename include guard.
2348         * common/job-control.h: Rename include guard.
2349         * common/host-defs.h: Rename include guard.
2350         * common/gdb_wait.h: Rename include guard.
2351         * common/gdb_vecs.h: Rename include guard.
2352         * common/gdb_unlinker.h: Rename include guard.
2353         * common/gdb_unique_ptr.h: Rename include guard.
2354         * common/gdb_tilde_expand.h: Rename include guard.
2355         * common/gdb_sys_time.h: Rename include guard.
2356         * common/gdb_string_view.h: Rename include guard.
2357         * common/gdb_splay_tree.h: Rename include guard.
2358         * common/gdb_setjmp.h: Rename include guard.
2359         * common/gdb_ref_ptr.h: Rename include guard.
2360         * common/gdb_optional.h: Rename include guard.
2361         * common/gdb_locale.h: Rename include guard.
2362         * common/gdb_assert.h: Rename include guard.
2363         * common/filtered-iterator.h: Rename include guard.
2364         * common/filestuff.h: Rename include guard.
2365         * common/fileio.h: Rename include guard.
2366         * common/environ.h: Rename include guard.
2367         * common/common-utils.h: Rename include guard.
2368         * common/common-types.h: Rename include guard.
2369         * common/common-regcache.h: Rename include guard.
2370         * common/common-inferior.h: Rename include guard.
2371         * common/common-gdbthread.h: Rename include guard.
2372         * common/common-exceptions.h: Rename include guard.
2373         * common/common-defs.h: Rename include guard.
2374         * common/common-debug.h: Rename include guard.
2375         * common/cleanups.h: Rename include guard.
2376         * common/buffer.h: Rename include guard.
2377         * common/btrace-common.h: Rename include guard.
2378         * common/break-common.h: Rename include guard.
2379         * cli/cli-utils.h: Rename include guard.
2380         * cli/cli-style.h: Rename include guard.
2381         * cli/cli-setshow.h: Rename include guard.
2382         * cli/cli-script.h: Rename include guard.
2383         * cli/cli-interp.h: Rename include guard.
2384         * cli/cli-decode.h: Rename include guard.
2385         * cli/cli-cmds.h: Rename include guard.
2386         * charset-list.h: Add include guard.
2387         * buildsym-legacy.h: Rename include guard.
2388         * bfin-tdep.h: Add include guard.
2389         * ax.h: Rename include guard.
2390         * arm-linux-tdep.h: Add include guard.
2391         * arm-fbsd-tdep.h: Add include guard.
2392         * arch/xtensa.h: Rename include guard.
2393         * arch/tic6x.h: Add include guard.
2394         * arch/i386.h: Add include guard.
2395         * arch/arm.h: Rename include guard.
2396         * arch/arm-linux.h: Rename include guard.
2397         * arch/arm-get-next-pcs.h: Rename include guard.
2398         * arch/amd64.h: Add include guard.
2399         * arch/aarch64-insn.h: Rename include guard.
2400         * arch-utils.h: Rename include guard.
2401         * annotate.h: Add include guard.
2402         * amd64-darwin-tdep.h: Rename include guard.
2403         * aarch64-linux-tdep.h: Add include guard.
2404         * aarch64-fbsd-tdep.h: Add include guard.
2405         * aarch32-linux-nat.h: Add include guard.
2406
2407 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2408
2409         * macrotab.c (macro_define_internal): New function that
2410         factorizes macro_define_object_internal and macro_define_function
2411         code.
2412         (macro_define_object_internal): Use macro_define_internal.
2413         (macro_define_function): Likewise.
2414
2415 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2416
2417         * macrocmd.c (extract_identifier): Return
2418         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2419         callers.
2420
2421 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2422
2423         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2424
2425 2019-02-05  Tom Tromey  <tom@tromey.com>
2426
2427         * target.c (target_stack::unpush): Move assertion earlier.
2428
2429 2019-01-30  Tom Tromey  <tom@tromey.com>
2430
2431         PR python/23615:
2432         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2433         (gdbpy_parse_and_eval): Likewise.
2434         * python/python-internal.h (gdbpy_allow_threads): New class.
2435
2436 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2437
2438         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2439         (aarch64_fbsd_fpregmap): Move earlier.
2440         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2441         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2442         instead of individual calls to trad_frame_set_reg_addr.
2443         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2444         earlier.
2445         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2446         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2447         instead of individual calls to trad_frame_set_reg_addr.
2448
2449 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2450
2451         * CONTRIBUTE: Replace contribution list with wiki link.
2452
2453 2019-01-25  Tom Tromey  <tom@tromey.com>
2454
2455         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2456
2457 2019-01-25  Tom Tromey  <tom@tromey.com>
2458
2459         * xtensa-linux-nat.c: Fix common/ includes.
2460         * xml-support.h: Fix common/ includes.
2461         * xml-support.c: Fix common/ includes.
2462         * x86-linux-nat.c: Fix common/ includes.
2463         * windows-nat.c: Fix common/ includes.
2464         * varobj.h: Fix common/ includes.
2465         * varobj.c: Fix common/ includes.
2466         * value.c: Fix common/ includes.
2467         * valops.c: Fix common/ includes.
2468         * utils.c: Fix common/ includes.
2469         * unittests/xml-utils-selftests.c: Fix common/ includes.
2470         * unittests/utils-selftests.c: Fix common/ includes.
2471         * unittests/unpack-selftests.c: Fix common/ includes.
2472         * unittests/tracepoint-selftests.c: Fix common/ includes.
2473         * unittests/style-selftests.c: Fix common/ includes.
2474         * unittests/string_view-selftests.c: Fix common/ includes.
2475         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2476         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2477         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2478         * unittests/rsp-low-selftests.c: Fix common/ includes.
2479         * unittests/parse-connection-spec-selftests.c: Fix common/
2480         includes.
2481         * unittests/optional-selftests.c: Fix common/ includes.
2482         * unittests/offset-type-selftests.c: Fix common/ includes.
2483         * unittests/observable-selftests.c: Fix common/ includes.
2484         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2485         * unittests/memrange-selftests.c: Fix common/ includes.
2486         * unittests/memory-map-selftests.c: Fix common/ includes.
2487         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2488         * unittests/function-view-selftests.c: Fix common/ includes.
2489         * unittests/environ-selftests.c: Fix common/ includes.
2490         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2491         * unittests/common-utils-selftests.c: Fix common/ includes.
2492         * unittests/cli-utils-selftests.c: Fix common/ includes.
2493         * unittests/array-view-selftests.c: Fix common/ includes.
2494         * ui-file.c: Fix common/ includes.
2495         * tui/tui-io.c: Fix common/ includes.
2496         * tracepoint.h: Fix common/ includes.
2497         * tracepoint.c: Fix common/ includes.
2498         * tracefile-tfile.c: Fix common/ includes.
2499         * top.h: Fix common/ includes.
2500         * top.c: Fix common/ includes.
2501         * thread.c: Fix common/ includes.
2502         * target/waitstatus.h: Fix common/ includes.
2503         * target/waitstatus.c: Fix common/ includes.
2504         * target.h: Fix common/ includes.
2505         * target.c: Fix common/ includes.
2506         * target-memory.c: Fix common/ includes.
2507         * target-descriptions.c: Fix common/ includes.
2508         * symtab.h: Fix common/ includes.
2509         * symfile.c: Fix common/ includes.
2510         * stap-probe.c: Fix common/ includes.
2511         * spu-linux-nat.c: Fix common/ includes.
2512         * sparc-nat.c: Fix common/ includes.
2513         * source.c: Fix common/ includes.
2514         * solib.c: Fix common/ includes.
2515         * solib-target.c: Fix common/ includes.
2516         * ser-unix.c: Fix common/ includes.
2517         * ser-tcp.c: Fix common/ includes.
2518         * ser-pipe.c: Fix common/ includes.
2519         * ser-base.c: Fix common/ includes.
2520         * selftest-arch.c: Fix common/ includes.
2521         * s12z-tdep.c: Fix common/ includes.
2522         * rust-exp.y: Fix common/ includes.
2523         * rs6000-aix-tdep.c: Fix common/ includes.
2524         * riscv-tdep.c: Fix common/ includes.
2525         * remote.c: Fix common/ includes.
2526         * remote-notif.h: Fix common/ includes.
2527         * remote-fileio.h: Fix common/ includes.
2528         * remote-fileio.c: Fix common/ includes.
2529         * regcache.h: Fix common/ includes.
2530         * regcache.c: Fix common/ includes.
2531         * record-btrace.c: Fix common/ includes.
2532         * python/python.c: Fix common/ includes.
2533         * python/py-type.c: Fix common/ includes.
2534         * python/py-inferior.c: Fix common/ includes.
2535         * progspace.h: Fix common/ includes.
2536         * producer.c: Fix common/ includes.
2537         * procfs.c: Fix common/ includes.
2538         * proc-api.c: Fix common/ includes.
2539         * printcmd.c: Fix common/ includes.
2540         * ppc-linux-nat.c: Fix common/ includes.
2541         * parser-defs.h: Fix common/ includes.
2542         * osdata.c: Fix common/ includes.
2543         * obsd-nat.c: Fix common/ includes.
2544         * nat/x86-linux.c: Fix common/ includes.
2545         * nat/x86-linux-dregs.c: Fix common/ includes.
2546         * nat/x86-dregs.h: Fix common/ includes.
2547         * nat/x86-dregs.c: Fix common/ includes.
2548         * nat/ppc-linux.c: Fix common/ includes.
2549         * nat/mips-linux-watch.h: Fix common/ includes.
2550         * nat/mips-linux-watch.c: Fix common/ includes.
2551         * nat/linux-waitpid.c: Fix common/ includes.
2552         * nat/linux-ptrace.h: Fix common/ includes.
2553         * nat/linux-ptrace.c: Fix common/ includes.
2554         * nat/linux-procfs.c: Fix common/ includes.
2555         * nat/linux-personality.c: Fix common/ includes.
2556         * nat/linux-osdata.c: Fix common/ includes.
2557         * nat/linux-namespaces.c: Fix common/ includes.
2558         * nat/linux-btrace.h: Fix common/ includes.
2559         * nat/linux-btrace.c: Fix common/ includes.
2560         * nat/fork-inferior.c: Fix common/ includes.
2561         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2562         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2563         * nat/aarch64-linux.c: Fix common/ includes.
2564         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2565         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2566         * namespace.h: Fix common/ includes.
2567         * mips-linux-tdep.c: Fix common/ includes.
2568         * minsyms.c: Fix common/ includes.
2569         * mi/mi-parse.h: Fix common/ includes.
2570         * mi/mi-main.c: Fix common/ includes.
2571         * mi/mi-cmd-env.c: Fix common/ includes.
2572         * memrange.h: Fix common/ includes.
2573         * memattr.c: Fix common/ includes.
2574         * maint.h: Fix common/ includes.
2575         * maint.c: Fix common/ includes.
2576         * main.c: Fix common/ includes.
2577         * machoread.c: Fix common/ includes.
2578         * location.c: Fix common/ includes.
2579         * linux-thread-db.c: Fix common/ includes.
2580         * linux-nat.c: Fix common/ includes.
2581         * linux-fork.c: Fix common/ includes.
2582         * inline-frame.c: Fix common/ includes.
2583         * infrun.c: Fix common/ includes.
2584         * inflow.c: Fix common/ includes.
2585         * inferior.h: Fix common/ includes.
2586         * inferior.c: Fix common/ includes.
2587         * infcmd.c: Fix common/ includes.
2588         * inf-ptrace.c: Fix common/ includes.
2589         * inf-child.c: Fix common/ includes.
2590         * ia64-linux-nat.c: Fix common/ includes.
2591         * i387-tdep.c: Fix common/ includes.
2592         * i386-tdep.c: Fix common/ includes.
2593         * i386-linux-tdep.c: Fix common/ includes.
2594         * i386-linux-nat.c: Fix common/ includes.
2595         * i386-go32-tdep.c: Fix common/ includes.
2596         * i386-fbsd-tdep.c: Fix common/ includes.
2597         * i386-fbsd-nat.c: Fix common/ includes.
2598         * guile/scm-type.c: Fix common/ includes.
2599         * guile/guile.c: Fix common/ includes.
2600         * go32-nat.c: Fix common/ includes.
2601         * gnu-nat.c: Fix common/ includes.
2602         * gdbthread.h: Fix common/ includes.
2603         * gdbarch-selftests.c: Fix common/ includes.
2604         * gdb_usleep.c: Fix common/ includes.
2605         * gdb_select.h: Fix common/ includes.
2606         * gdb_bfd.c: Fix common/ includes.
2607         * gcore.c: Fix common/ includes.
2608         * fork-child.c: Fix common/ includes.
2609         * findvar.c: Fix common/ includes.
2610         * fbsd-nat.c: Fix common/ includes.
2611         * event-top.c: Fix common/ includes.
2612         * event-loop.c: Fix common/ includes.
2613         * dwarf2read.c: Fix common/ includes.
2614         * dwarf2loc.c: Fix common/ includes.
2615         * dwarf2-frame.c: Fix common/ includes.
2616         * dwarf-index-cache.c: Fix common/ includes.
2617         * dtrace-probe.c: Fix common/ includes.
2618         * disasm-selftests.c: Fix common/ includes.
2619         * defs.h: Fix common/ includes.
2620         * csky-tdep.c: Fix common/ includes.
2621         * cp-valprint.c: Fix common/ includes.
2622         * cp-support.h: Fix common/ includes.
2623         * cp-support.c: Fix common/ includes.
2624         * corelow.c: Fix common/ includes.
2625         * completer.h: Fix common/ includes.
2626         * completer.c: Fix common/ includes.
2627         * compile/compile.c: Fix common/ includes.
2628         * compile/compile-loc2c.c: Fix common/ includes.
2629         * compile/compile-cplus-types.c: Fix common/ includes.
2630         * compile/compile-cplus-symbols.c: Fix common/ includes.
2631         * command.h: Fix common/ includes.
2632         * cli/cli-dump.c: Fix common/ includes.
2633         * cli/cli-cmds.c: Fix common/ includes.
2634         * charset.c: Fix common/ includes.
2635         * build-id.c: Fix common/ includes.
2636         * btrace.h: Fix common/ includes.
2637         * btrace.c: Fix common/ includes.
2638         * breakpoint.h: Fix common/ includes.
2639         * breakpoint.c: Fix common/ includes.
2640         * ax.h:
2641         (enum agent_op): Fix common/ includes.
2642         * ax-general.c (struct aop_map): Fix common/ includes.
2643         * ax-gdb.c: Fix common/ includes.
2644         * auxv.c: Fix common/ includes.
2645         * auto-load.c: Fix common/ includes.
2646         * arm-tdep.c: Fix common/ includes.
2647         * arch/riscv.c: Fix common/ includes.
2648         * arch/ppc-linux-common.c: Fix common/ includes.
2649         * arch/i386.c: Fix common/ includes.
2650         * arch/arm.c: Fix common/ includes.
2651         * arch/arm-linux.c: Fix common/ includes.
2652         * arch/arm-get-next-pcs.c: Fix common/ includes.
2653         * arch/amd64.c: Fix common/ includes.
2654         * arch/aarch64.c: Fix common/ includes.
2655         * arch/aarch64-insn.c: Fix common/ includes.
2656         * arch-utils.c: Fix common/ includes.
2657         * amd64-windows-tdep.c: Fix common/ includes.
2658         * amd64-tdep.c: Fix common/ includes.
2659         * amd64-sol2-tdep.c: Fix common/ includes.
2660         * amd64-obsd-tdep.c: Fix common/ includes.
2661         * amd64-nbsd-tdep.c: Fix common/ includes.
2662         * amd64-linux-tdep.c: Fix common/ includes.
2663         * amd64-linux-nat.c: Fix common/ includes.
2664         * amd64-fbsd-tdep.c: Fix common/ includes.
2665         * amd64-fbsd-nat.c: Fix common/ includes.
2666         * amd64-dicos-tdep.c: Fix common/ includes.
2667         * amd64-darwin-tdep.c: Fix common/ includes.
2668         * agent.c: Fix common/ includes.
2669         * ada-lang.h: Fix common/ includes.
2670         * ada-lang.c: Fix common/ includes.
2671         * aarch64-tdep.c: Fix common/ includes.
2672
2673 2019-01-25  Tom Tromey  <tom@tromey.com>
2674
2675         * common/create-version.sh: Use common/version.h.
2676
2677 2019-01-24  Pedro Alves  <palves@redhat.com>
2678
2679         * infrun.c (signal_stop, signal_print, signal_program)
2680         (signal_catch, signal_pass): Now arrays instead of pointers.
2681         (update_signals_program_target, do_target_resume)
2682         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2683         * linux-nat.c (linux_nat_target::pass_signals)
2684         (linux_nat_target::create_inferior, linux_nat_target::attach):
2685         Adjust.
2686         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2687         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2688         * procfs.c (procfs_target::pass_signals): Adjust.
2689         * record-full.c (record_full_target::resume): Adjust.
2690         * remote.c (remote_target::pass_signals)
2691         (remote_target::program_signals): Adjust.
2692         * target-debug.h (target_debug_print_signals): Now takes a
2693         gdb::array_view as parameter.  Adjust.
2694         * target.h (target_ops) <pass_signals, program_signals>: Replace
2695         pointer and length parameters with gdb::array_view.
2696         (target_pass_signals, target_program_signals): Likewise.
2697         * target-delegates.c: Regenerate.
2698
2699 2019-01-24  Pedro Alves  <palves@redhat.com>
2700
2701         * common/forward-scope-exit.h
2702         (forward_scope_exit::forward_scope_exit): Pass arguments to
2703         m_bind_function directly, instead of creating a std::bind and
2704         copying that.
2705
2706 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2707
2708         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2709         for static members.
2710         (pass_in_v_vfp_candidate): Likewise.
2711
2712 2019-01-23  Tom Tromey  <tom@tromey.com>
2713             Pedro Alves  <palves@redhat.com>
2714
2715         * regcache.c (class regcache_invalidator): Remove.
2716         (regcache::raw_write): Use make_scope_exit.
2717
2718 2019-01-23  Tom Tromey  <tom@tromey.com>
2719
2720         * ui-out.h (class ui_out_emit_type): Update comment.
2721
2722 2019-01-23  Tom Tromey  <tom@tromey.com>
2723
2724         * infrun.c (fetch_inferior_event): Update comment.
2725
2726 2019-01-23  Tom Tromey  <tom@tromey.com>
2727             Pedro Alves  <palves@redhat.com>
2728
2729         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2730         parameter.
2731         (fetch_inferior_event): Use SCOPE_EXIT.
2732
2733
2734 2019-01-23  Tom Tromey  <tom@tromey.com>
2735             Pedro Alves  <palves@redhat.com>
2736
2737         * infrun.c (disable_thread_events): Delete.
2738         (stop_all_threads): Use SCOPE_EXIT.
2739
2740 2019-01-23  Tom Tromey  <tom@tromey.com>
2741             Pedro Alves  <palves@redhat.com>
2742
2743         * symfile.c: Include forward-scope-exit.h.
2744         (clear_symtab_users_cleanup): Replace forward declaration with
2745         a FORWARD_SCOPE_EXIT.
2746         (syms_from_objfile_1): Use the forward_scope_exit and
2747         gdb::optional instead of cleanup_function.
2748         (reread_symbols): Use the forward_scope_exit instead of
2749         cleanup_function.
2750         (clear_symtab_users_cleanup): Remove function.
2751
2752 2019-01-23  Tom Tromey  <tom@tromey.com>
2753             Pedro Alves  <palves@redhat.com>
2754
2755         * linux-nat.c: Include scope-exit.h.
2756         (cleanup_target_stop): Remove.
2757         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2758         SCOPE_EXIT.
2759
2760 2019-01-23  Tom Tromey  <tom@tromey.com>
2761             Pedro Alves  <palves@redhat.com>
2762
2763         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2764         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2765
2766 2019-01-23  Tom Tromey  <tom@tromey.com>
2767             Andrew Burgess  <andrew.burgess@embecosm.com>
2768             Pedro Alves  <palves@redhat.com>
2769
2770         * infrun.c (fetch_inferior_event): Use scope_exit.
2771         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2772         * top.c (execute_command): Use scope_exit.
2773         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2774         * utils.c (do_bpstat_clear_actions_cleanup)
2775         (make_bpstat_clear_actions_cleanup): Remove.
2776
2777 2019-01-23  Tom Tromey  <tom@tromey.com>
2778             Pedro Alves  <palves@redhat.com>
2779
2780         * infrun.c: Include "common/scope-exit.h"
2781         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2782         (wait_for_inferior): Use SCOPE_EXIT.
2783         (fetch_inferior_event): Use scope_exit.
2784
2785 2019-01-23  Tom Tromey  <tom@tromey.com>
2786             Pedro Alves  <palves@redhat.com>
2787
2788         * breakpoint.c (create_breakpoint): Remove cleanup.
2789
2790 2019-01-23  Tom Tromey  <tom@tromey.com>
2791             Andrew Burgess  <andrew.burgess@embecosm.com>
2792             Pedro Alves  <palves@redhat.com>
2793
2794 2019-01-23  Pedro Alves  <palves@redhat.com>
2795
2796         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2797
2798 2019-01-23  Pedro Alves  <palves@redhat.com>
2799             Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * gdbthread.h: Include "common/forward-scope-exit.h".
2802         (scoped_finish_thread_state): Redefine custom class in terms of
2803         forward_scope_exit.
2804
2805 2019-01-23  Pedro Alves  <palves@redhat.com>
2806             Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * common/forward-scope-exit.h: New file.
2809
2810 2019-01-23  Pedro Alves  <palves@redhat.com>
2811             Andrew Burgess  <andrew.burgess@embecosm.com>
2812             Tom Tromey  <tom@tromey.com>
2813
2814         * common/scope-exit.h: New file.
2815
2816 2019-01-23  Pedro Alves  <palves@redhat.com>
2817
2818         * common/preprocessor.h (ESC): Rename to ...
2819         (ESC_PARENS): ... this.
2820         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2821         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2822
2823 2019-01-23  Tom Tromey  <tom@tromey.com>
2824
2825         * language.h (class scoped_switch_to_sym_language_if_auto):
2826         Initialize m_lang in both cases.
2827
2828 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2831         with XCNEW.
2832
2833 2019-01-22  Tom Tromey  <tom@tromey.com>
2834
2835         * corelow.c: Do not include sys/file.h.
2836
2837 2019-01-22  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-wingeneral.h: Include gdb_curses.h.
2840
2841 2019-01-22  Tom Tromey  <tom@tromey.com>
2842
2843         * source-cache.h (class source_cache) <get_source_lines,
2844         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2845
2846 2019-01-22  Tom Tromey  <tom@tromey.com>
2847
2848         * remote-fileio.h (struct remote_target): Declare.
2849
2850 2019-01-22  Tom Tromey  <tom@tromey.com>
2851
2852         * python/py-arch.c: Do not include py-ref.h.
2853         * python/py-bpevent.c: Do not include py-ref.h.
2854         * python/py-cmd.c: Do not include py-ref.h.
2855         * python/py-continueevent.c: Do not include py-ref.h.
2856         * python/py-event.h: Do not include py-ref.h.
2857         * python/py-evtregistry.c: Do not include py-ref.h.
2858         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2859         * python/py-frame.c: Do not include py-ref.h.
2860         * python/py-framefilter.c: Do not include py-ref.h.
2861         * python/py-function.c: Do not include py-ref.h.
2862         * python/py-infevents.c: Do not include py-ref.h.
2863         * python/py-linetable.c: Do not include py-ref.h.
2864         * python/py-objfile.c: Do not include py-ref.h.
2865         * python/py-param.c: Do not include py-ref.h.
2866         * python/py-prettyprint.c: Do not include py-ref.h.
2867         * python/py-progspace.c: Do not include py-ref.h.
2868         * python/py-symbol.c: Do not include py-ref.h.
2869         * python/py-symtab.c: Do not include py-ref.h.
2870         * python/py-type.c: Do not include py-ref.h.
2871         * python/py-unwind.c: Do not include py-ref.h.
2872         * python/py-utils.c: Do not include py-ref.h.
2873         * python/py-value.c: Do not include py-ref.h.
2874         * python/py-varobj.c: Do not include py-ref.h.
2875         * python/py-xmethods.c: Do not include py-ref.h.
2876         * python/python.c: Do not include py-ref.h.
2877         * varobj.c: Do not include py-ref.h.
2878
2879 2019-01-22  Tom Tromey  <tom@tromey.com>
2880
2881         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2882         keyword for bcache.
2883
2884 2019-01-22  Tom Tromey  <tom@tromey.com>
2885
2886         * compile/compile-cplus-types.c: Remove a comment by #include.
2887
2888 2019-01-22  Tom Tromey  <tom@tromey.com>
2889
2890         * compile/gcc-c-plugin.h: Include compile-internal.h.
2891
2892 2019-01-22  Tom Tromey  <tom@tromey.com>
2893
2894         * stabsread.c (EXTERN): Do not define.
2895         (symnum, next_symbol_text_func, processing_gcc_compilation)
2896         (within_function, global_sym_chain, global_stabs)
2897         (previous_stab_code, this_object_header_files)
2898         (n_this_object_header_files)
2899         (n_allocated_this_object_header_files): Define.
2900         * stabsread.h (EXTERN): Never define.  Use "extern".
2901
2902 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2903
2904         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2905         history_value.
2906
2907 2019-01-21  Tom Tromey  <tom@tromey.com>
2908
2909         * ui-out.c: Fix includes.
2910         * tui/tui-source.c: Fix includes.
2911         * target.c: Fix includes.
2912         * remote.c: Fix includes.
2913         * regcache.c: Fix includes.
2914         * python/py-block.c: Fix includes.
2915         * printcmd.c: Fix includes.
2916         * or1k-tdep.c: Fix includes.
2917         * mi/mi-main.c: Fix includes.
2918         * m32r-tdep.c: Fix includes.
2919         * csky-tdep.c: Fix includes.
2920         * compile/compile-cplus-types.c: Fix includes.
2921         * cli/cli-interp.c: Fix includes.
2922
2923 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2924
2925         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2926         for padding.
2927
2928 2019-01-16  Tom Tromey  <tom@tromey.com>
2929
2930         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2931         earlier.
2932         (struct objfile) <msymbols_range>: Move from top level.
2933         <msymbols>: New method.
2934         (class objfile_msymbols): Remove.
2935         * symtab.c (default_collect_symbol_completion_matches_break_on):
2936         Update.
2937         * symmisc.c (dump_msymbols): Update.
2938         * stabsread.c (scan_file_globals): Update.
2939         * objc-lang.c (info_selectors_command, info_classes_command)
2940         (find_methods): Update.
2941         * minsyms.c (find_solib_trampoline_target): Update.
2942         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2943         * coffread.c (coff_symfile_read): Update.
2944         * ada-lang.c (ada_lookup_simple_minsym)
2945         (ada_collect_symbol_completion_matches): Update.
2946
2947 2019-01-16  Tom Tromey  <tom@tromey.com>
2948
2949         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2950         type.  Remove no-argument constructor.
2951         <iterator::operator++>: Simplify.
2952         <begin>: Update.
2953         <end>: Use minimal_symbol_count.
2954
2955 2019-01-16  Tom Tromey  <tom@tromey.com>
2956
2957         * objfiles.h (struct objfile) <psymtabs>: New method.
2958         (class objfile_psymtabs): Remove.
2959         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2960         typedef.
2961         <range>: New method.
2962         (require_partial_symbols): Change return type.
2963         * psymtab.c (require_partial_symbols)
2964         (psym_expand_symtabs_matching): Update.
2965         * mdebugread.c (parse_partial_symbols): Update.
2966         * dbxread.c (dbx_end_psymtab): Update.
2967
2968 2019-01-15  Tom Tromey  <tom@tromey.com>
2969
2970         * symtab.c (lookup_objfile_from_block)
2971         (lookup_symbol_in_objfile_symtabs)
2972         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2973         (find_line_symtab, info_sources_command)
2974         (default_collect_symbol_completion_matches_break_on)
2975         (make_source_files_completion_list): Update.
2976         * symmisc.c (print_objfile_statistics, dump_objfile)
2977         (maintenance_print_symbols, maintenance_info_symtabs)
2978         (maintenance_check_symtabs, maintenance_info_line_tables):
2979         Update.
2980         * source.c (select_source_symtab)
2981         (forget_cached_source_info_for_objfile): Update.
2982         * objfiles.h (class objfile_compunits): Remove.
2983         (struct objfile) <compunits_range>: New typedef.
2984         (compunits): New method.
2985         * objfiles.c (objfile_relocate1): Update.
2986         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2987         * maint.c (count_symtabs_and_blocks): Update.
2988         * linespec.c (iterate_over_all_matching_symtabs): Update.
2989         * cp-support.c (add_symbol_overload_list_qualified): Update.
2990         * coffread.c (coff_symtab_read): Update.
2991         * ada-lang.c (add_nonlocal_symbols)
2992         (ada_collect_symbol_completion_matches)
2993         (ada_add_global_exceptions): Update.
2994
2995 2019-01-15  Tom Tromey  <tom@tromey.com>
2996
2997         * progspace.h (program_space) <objfiles_safe_range>: New
2998         typedef.
2999         <objfiles_safe>: New method.
3000         * objfiles.h (class all_objfiles_safe): Remove.
3001         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3002         * jit.c (jit_inferior_exit_hook): Update.
3003
3004 2019-01-17  Tom Tromey  <tom@tromey.com>
3005
3006         * progspace.h (program_space) <objfiles_range>: New typedef.
3007         <objfiles>: New method.
3008         <objfiles_head>: Rename from objfiles.
3009         (object_files): Update.
3010         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3011         * guile/scm-pretty-print.c
3012         (ppscm_find_pretty_printer_from_objfiles): Update.
3013         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3014         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3015         Update.
3016         * python/py-progspace.c (pspy_get_objfiles): Update.
3017         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3018         Update.
3019         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3020         (objfpy_lookup_objfile_by_build_id): Update.
3021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3022         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3023         Update.
3024         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3025         (expand_symtab_containing_pc, lookup_objfile_from_block)
3026         (lookup_static_symbol, basic_lookup_transparent_type)
3027         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3028         (find_line_symtab, info_sources_command)
3029         (default_collect_symbol_completion_matches_break_on)
3030         (make_source_files_completion_list, find_main_name): Update.
3031         * symmisc.c (print_symbol_bcache_statistics)
3032         (print_objfile_statistics, maintenance_print_symbols)
3033         (maintenance_print_msymbols, maintenance_print_objfiles)
3034         (maintenance_info_symtabs, maintenance_check_symtabs)
3035         (maintenance_expand_symtabs, maintenance_info_line_tables):
3036         Update.
3037         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3038         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3039         (map_overlay_command, unmap_overlay_command)
3040         (simple_overlay_update, expand_symtabs_matching)
3041         (map_symbol_filenames): Update.
3042         * symfile-debug.c (set_debug_symfile): Update.
3043         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3044         Update.
3045         * source.c (select_source_symtab, forget_cached_source_info):
3046         Update.
3047         * solib.c (solib_read_symbols): Update.
3048         * solib-spu.c (append_ocl_sos): Update.
3049         * psymtab.c (maintenance_print_psymbols)
3050         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3051         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3052         * printcmd.c (info_symbol_command): Update.
3053         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3054         Update.
3055         * objfiles.h (class all_objfiles): Remove.
3056         * objfiles.c (have_partial_symbols, have_full_symbols)
3057         (have_minimal_symbols, qsort_cmp, update_section_map)
3058         (shared_objfile_contains_address_p)
3059         (default_iterate_over_objfiles_in_search_order): Update.
3060         * objc-lang.c (info_selectors_command, info_classes_command)
3061         (find_methods): Update.
3062         * minsyms.c (find_solib_trampoline_target): Update.
3063         * maint.c (maintenance_info_sections)
3064         (maintenance_translate_address, count_symtabs_and_blocks):
3065         Update.
3066         * main.c (captured_main_1): Update.
3067         * linux-thread-db.c (try_thread_db_load_from_pdir)
3068         (has_libpthread): Update.
3069         * linespec.c (iterate_over_all_matching_symtabs)
3070         (search_minsyms_for_name): Update.
3071         * jit.c (jit_find_objf_with_entry_addr): Update.
3072         * hppa-tdep.c (find_unwind_entry)
3073         (hppa_lookup_stub_minimal_symbol): Update.
3074         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3075         Update.
3076         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3077         (elf_gnu_ifunc_resolve_by_got): Update.
3078         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3079         * dwarf-index-write.c (save_gdb_index_command): Update.
3080         * cp-support.c (add_symbol_overload_list_qualified): Update.
3081         * breakpoint.c (create_overlay_event_breakpoint)
3082         (create_longjmp_master_breakpoint)
3083         (create_std_terminate_master_breakpoint)
3084         (create_exception_master_breakpoint): Update.
3085         * blockframe.c (find_pc_partial_function): Update.
3086         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3087         (ada_collect_symbol_completion_matches)
3088         (ada_add_global_exceptions): Update.
3089
3090 2019-01-17  Tom Tromey  <tom@tromey.com>
3091
3092         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3093         declare VEC.
3094         (solib_target_parse_libraries): Change return type.
3095         (library_list_start_segment, library_list_start_section)
3096         (library_list_end_library, library_list_start_library); Update.
3097         (solib_target_free_library_list): Remove.
3098         (solib_target_parse_libraries): Remove cleanup.  Change return
3099         type.
3100         (solib_target_current_sos): Update.
3101
3102 2019-01-17  Tom Tromey  <tromey@bapiya>
3103
3104         * valprint.c: Replace "the the" with "the".
3105         * symtab.c: Replace "the the" with "the".
3106         * solib.c: Replace "the the" with "the".
3107         * solib-dsbt.c: Replace "the the" with "the".
3108         * linespec.c: Replace "the the" with "the".
3109         * dwarf2loc.h: Replace "the the" with "the".
3110         * amd64-windows-tdep.c: Replace "the the" with "the".
3111         * aarch64-tdep.c: Replace "the the" with "the".
3112
3113 2019-01-16  Keith Seitz  <keiths@redhat.com>
3114
3115         PR gdb/23773
3116         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3117         <builder>: Rename to ..
3118         <m_builder>: ... this and make private.
3119         (dwarf2_cu::get_builder): New method.  Change all users of
3120         `builder' to use this method.
3121         (dwarf2_start_symtab): Move to ...
3122         (dwarf2_cu::start_symtab): ... here.  Update all callers
3123         (setup_type_unit_groups): Move to ...
3124         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3125         callers.
3126         (dwarf2_cu::reset_builder): New method.
3127         (process_full_compunit, process_full_type_unit): Use
3128         dwarf2_cu::reset_builder.
3129         (follow_die_offset): Record the ancestor CU if it is different
3130         from the followed DIE's CU.
3131         (follow_die_sig_1): Likewise.
3132
3133 2019-01-15  Tom Tromey  <tom@tromey.com>
3134
3135         * remote.c (class remote_state) <buf>: Now a char_vector.
3136         <buf_size>: Remove.
3137         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3138         parameter.
3139         (remote_target::getpkt_or_notif_sane_1)
3140         (remote_target::getpkt_sane)
3141         (remote_target::getpkt_or_notif_sane): Likewise.
3142         (class remote_target) <putpkt>: New overload.
3143         (remote_target::read_frame): Change type of "buf_p".  Remove
3144         sizeof_p parameter.
3145         (packet_ok): New overload.
3146         (packet_check_result): New overload.
3147         Update all uses.
3148
3149 2019-01-14  Tom Tromey  <tom@tromey.com>
3150
3151         * remote-notif.c (handle_notification, remote_notif_ack)
3152         (remote_notif_parse): Make "buf" const.
3153         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3154         const.
3155         (remote_notif_parse, remote_notif_ack, handle_notification):
3156         Likewise.
3157         * remote.c (remote_notif_stop_parse): Make "buf" const.
3158         (remote_target::remote_parse_stop_reply): Make "buf" const.
3159         (remote_notif_stop_ack): Make "buf" const.
3160
3161 2019-01-14  Tom Tromey  <tom@tromey.com>
3162
3163         * remote.c (remote_console_output): Make parameter const.
3164
3165 2019-01-14  Tom Tromey  <tom@tromey.com>
3166
3167         * target-debug.h (target_debug_print_signals): Constify.
3168         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3169         * procfs.c (procfs_target::pass_signals): Update.
3170         * linux-nat.c (linux_nat_target::pass_signals): Update.
3171         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3172         * target-delegates.c: Rebuild.
3173         * remote.c (remote_target::program_signals): Update.
3174         (remote_target::pass_signals): Update.
3175         * target.c (target_pass_signals): Constify argument.
3176         (target_program_signals): Likewise.
3177         * target.h (struct target_ops) <pass_signals, program_signals>:
3178         Constify argument.
3179         (target_pass_signals, target_program_signals): Constify argument.
3180
3181 2019-01-14  Tom Tromey  <tom@tromey.com>
3182
3183         PR tui/28819:
3184         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3185
3186 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3187
3188         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3189         field.
3190         * rs6000-tdep.c: Include reggroups.h.
3191         (IS_V_ALIAS_PSEUDOREG): Define.
3192         (rs6000_register_name): Return names for the "vX" aliases.
3193         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3194         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3195         aliases.  Call default_register_reggroup_p for all other
3196         pseudo-registers.
3197         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3198         New functions.
3199         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3200         Handle "vX" aliases.
3201         (v_alias_pseudo_register_collect): New function.
3202         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3203         (rs6000_gdbarch_init): Initialize "vX" aliases as
3204         pseudo-registers.  Restore registration of
3205         rs6000_pseudo_register_reggroup_p with
3206         set_tdesc_pseudo_register_reggroup_p.
3207
3208 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3209
3210         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3211         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3212         set_gdbarch_num_pseudo_regs.
3213
3214 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3215
3216         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3217         Remove arg prefixname, add do_set and do_show.
3218         Add member functions set_list and show_list.
3219         * cli/cli-style.c (class cli_style_option): Update accordingly.
3220         (style_set_list): Move to file scope.
3221         (style_show_list): Likewise.
3222         (set_style): Call help_list.
3223         (show_style): Call cmd_show_list.
3224         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3225         Update to use the new macro.
3226
3227 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3228
3229         * ada-lang.c (_initialize_ada_language): Expand the help text
3230         for the "catch exception" command.
3231
3232 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3233
3234         * symtab.c (matching_obj_sections): Initialize obj,
3235         declare it closer to its usage.
3236
3237 2019-01-10  Tom Tromey  <tom@tromey.com>
3238
3239         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3240         (basic_inf_threads_range): Remove.
3241         (inf_threads_range, inf_non_exited_threads_range)
3242         (safe_inf_threads_range): Use next_adapter.
3243
3244 2019-01-10  Keith Seitz  <keiths@redhat.com>
3245
3246         PR gdb/23712
3247         PR symtab/23010
3248         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3249         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3250
3251 2019-01-10  Keith Seitz  <keiths@redhat.com>
3252
3253         PR gdb/23712
3254         PR symtab/23010
3255         * dictionary.c (pending_to_vector): Remove.
3256         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3257         Remove _1 suffix, replacing functions of the same name.  Update
3258         all callers.
3259         (dict_create_hashed, dict_create_hashed_expandable)
3260         (dict_create_linear, dict_create_linear_expandable, dict_free)
3261         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3262         Make functions static.
3263
3264 2019-01-10  Keith Seitz  <keiths@redhat.com>
3265
3266         PR gdb/23712
3267         PR symtab/23010
3268         * dictionary.h (struct dictionary): Replace declaration with
3269         multidictionary.
3270         (dict_create_hashed, dict_create_hashed_expandable)
3271         (dict_create_linear, dict_create_linear_expandable)
3272         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3273         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3274         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3275         taking multidictionary argument.
3276         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3277         * block.h (struct block) <dict>: Change to multidictionary
3278         and rename `multidict'.
3279         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3280         symmisc.c: Update all dictionary references to multidictionary.
3281
3282 2019-01-10  Keith Seitz  <keiths@redhat.com>
3283
3284         PR gdb/23712
3285         PR symtab/23010
3286         * dictionary.c: Include unordered_map.
3287         (pending_to_vector): New function.
3288         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3289         Rewrite the non-"_1" functions to take vector instead
3290         of linked list.
3291         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3292         "new" _1 versions of the same name.
3293         (multidictionary): Define.
3294         (std::hash<enum language): New definition.
3295         (collate_pending_symbols_by_language, mdict_create_hashed)
3296         (mdict_create_hashed_expandable, mdict_create_linear)
3297         (mdict_create_linear_expandable, mdict_free)
3298         (find_language_dictionary, create_new_language_dictionary)
3299         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3300         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3301         (mdict_size, mdict_empty): New functions.
3302         * dictionary.h (mdict_iterator): Define.
3303
3304 2019-01-10  Pedro Alves  <palves@redhat.com>
3305
3306         * breakpoint.c (read_uploaded_action)
3307         (create_tracepoint_from_upload): Adjust to use
3308         gdb::unique_xmalloc_ptr.
3309         * ctf.c (ctf_write_uploaded_tp):
3310         (SET_ARRAY_FIELD): Use emplace_back.
3311         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3312         * tracefile-tfile.c (tfile_write_uploaded_tp):
3313         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3314         gdb::unique_xmalloc_ptr.
3315         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3316         at_string, cond_string, cmd_strings>: Replace char pointers
3317         with gdb::unique_xmalloc_ptr.
3318
3319 2019-01-10  Pedro Alves  <palves@redhat.com>
3320
3321         * solib-target.c (library_list_start_library): Don't xstrdup name.
3322
3323 2019-01-10  Pedro Alves  <palves@redhat.com>
3324
3325         * mdebugread.c (parse_partial_symbols): Use
3326         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3327
3328 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * linux-fork.c (scoped_switch_fork_info)
3331         <~scoped_switch_fork_info>: Fix incorrect variable name.
3332
3333 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * linux-fork.c (scoped_switch_fork_info)
3336         <scoped_switch_fork_info>: Make explicit.
3337         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3338
3339 2019-01-10  Tom Tromey  <tom@tromey.com>
3340
3341         * objfiles.h (objfile::reset_psymtabs): Update.
3342         * objfiles.c (objfile::objfile): Update.
3343         * psymtab.h (psymtab_storage::obstack): Update.
3344         (psymtab_storage::m_obstack): Use gdb::optional.
3345         (class psymtab_storage): Update comment.  Remove objfile
3346         parameter.
3347         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3348
3349 2019-01-10  Tom Tromey  <tom@tromey.com>
3350
3351         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3352         <free_psymtabs>: Now private.
3353         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3354         (allocate_psymtab): Use new method.
3355
3356 2019-01-10  Tom Tromey  <tom@tromey.com>
3357
3358         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3359         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3360         * mdebugread.c (parse_partial_symbols): Use
3361         allocate_dependencies.
3362         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3363         allocate_dependencies.
3364         (process_psymtab_comp_unit_reader)
3365         (build_type_psymtab_dependencies): Likewise.
3366         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3367
3368 2019-01-10  Tom Tromey  <tom@tromey.com>
3369
3370         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3371         PSYMBOL_SET_LANGUAGE.
3372         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3373
3374 2019-01-10  Tom Tromey  <tom@tromey.com>
3375
3376         * psymtab.h (psymtab_storage::obstack): New method.
3377         <m_obstack>: Rename from obstack; now private.
3378         * psymtab.c (psymtab_storage): Update.
3379         * dwarf2read.c (create_addrmap_from_index)
3380         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3381         Update.
3382
3383 2019-01-10  Tom Tromey  <tom@tromey.com>
3384
3385         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3386         * objfiles.h (objfile::reset_psymtabs): New method.
3387
3388 2019-01-10  Tom Tromey  <tom@tromey.com>
3389
3390         * symmisc.c (print_symbol_bcache_statistics): Update.
3391         (print_objfile_statistics): Update.
3392         * symfile.c (reread_symbols): Update.
3393         * psymtab.h (class psymtab_storage): New.
3394         * psymtab.c (psymtab_storage): New constructor.
3395         (~psymtab_storage): New destructor.
3396         (require_partial_symbols): Update.
3397         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3398         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3399         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3400         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3401         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3402         (start_psymtab_common, end_psymtab_common)
3403         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3404         (allocate_psymtab): Update.
3405         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3406         Update.
3407         (dump_psymtab_addrmap, maintenance_print_psymbols)
3408         (maintenance_check_psymtabs): Update.
3409         (class objfile_psymtabs): Move to objfiles.h.
3410         * psympriv.h (discard_psymtab): Now inline.
3411         (psymtab_discarder::psymtab_discarder): Update.
3412         (psymtab_discarder::~psymtab_discarder): Update.
3413         (ALL_OBJFILE_PSYMTABS): Rewrite.
3414         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3415         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3416         Remove fields.
3417         <partial_symtabs>: New field.
3418         (class objfile_psymtabs): Move from psymtab.h.  Update.
3419         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3420         psymbol_cache.
3421         (objfile::~objfile): Don't destroy psymbol_cache.
3422         * mdebugread.c (parse_partial_symbols): Update.
3423         * dwarf2read.c (create_addrmap_from_index)
3424         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3425         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3426         (add_partial_subprogram, dwarf2_ranges_read): Update.
3427         * dwarf-index-write.c (write_address_map)
3428         (write_one_signatured_type, recursively_write_psymbols)
3429         (class debug_names, class debug_names, write_psymtabs_to_index):
3430         Update.
3431
3432 2019-01-10  Tom Tromey  <tom@tromey.com>
3433
3434         * symtab.h (SYMBOL_SET_NAMES): Update.
3435         (symbol_set_names): Update.
3436         (MSYMBOL_SET_NAMES): Update.
3437         * symtab.c (symbol_set_names): Change argument to be an
3438         objfile_per_bfd_storage.
3439         * psymtab.c (add_psymbol_to_bcache): Update.
3440         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3441
3442 2019-01-10  Tom Tromey  <tom@tromey.com>
3443
3444         * symtab.c (create_demangled_names_hash): Change argument to be an
3445         objfile_per_bfd_storage.
3446         (symbol_set_names): Update.
3447
3448 2019-01-10  Tom Tromey  <tom@tromey.com>
3449
3450         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3451         init_psymbol_list.
3452         * psymtab.c (init_psymbol_list): Do nothing if already called.
3453         * psympriv.h (init_psymbol_list): Add comment.
3454         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3455         init_psymbol_list.
3456         * dbxread.c (dbx_symfile_read): Unconditionally call
3457         init_psymbol_list.
3458
3459 2019-01-10  Tom Tromey  <tom@tromey.com>
3460
3461         * xcoffread.c (scan_xcoff_symtab): Update.
3462         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3463         "where".
3464         * mdebugread.c (parse_partial_symbols)
3465         (handle_psymbol_enumerators): Update.
3466         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3467         * dbxread.c (read_dbx_symtab): Update.
3468         * psympriv.h (psymbol_placement): New enum.
3469         (add_psymbol_to_list): Update.
3470
3471 2019-01-10  Tom Tromey  <tom@tromey.com>
3472
3473         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3474         static_psymbols parameters.
3475         (scan_xcoff_symtab): Update.
3476         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3477         static_psymbols parameters.
3478         * psympriv.h (start_psymtab_common): Update.
3479         * mdebugread.c (parse_partial_symbols): Update.
3480         * dwarf2read.c (create_partial_symtab): Update.
3481         * dbxread.c (read_dbx_symtab): Update.
3482         (start_psymtab): Remove global_psymbols and static_psymbols
3483         parameters.
3484
3485 2019-01-10  Tom Tromey  <tom@tromey.com>
3486
3487         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3488         * psymtab.c (allocate_psymtab): Add comment.
3489         * psympriv.h (allocate_psymtab): Add comment.
3490         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3491         initializations.
3492         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3493
3494 2019-01-10  Tom Tromey  <tom@tromey.com>
3495
3496         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3497         Don't declare.
3498         * mipsread.c: Include mdebugread.h.
3499         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3500         Declare.
3501         * elfread.c: Include mdebugread.h.
3502
3503 2019-01-09  Tom Tromey  <tom@tromey.com>
3504
3505         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3506         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3507         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3508         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3509         (psym_lookup_symbol, psym_find_last_source_symtab)
3510         (psym_forget_cached_source_info, psym_print_stats)
3511         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3512         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3513         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3514         (psym_find_compunit_symtab_by_address)
3515         (maintenance_print_psymbols, maintenance_info_psymtabs)
3516         (maintenance_check_psymtabs): Use ranged for.
3517         * psymtab.h (class objfile_psymtabs): New.
3518         (require_partial_symbols): Return objfile_psymtabs.
3519         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3520
3521 2019-01-09  Tom Tromey  <tom@tromey.com>
3522
3523         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3524         (find_pc_mapped_section, list_overlays_command)
3525         (map_overlay_command, unmap_overlay_command)
3526         (simple_overlay_update): Use all_objfiles.
3527         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3528         * printcmd.c (info_symbol_command): Use all_objfiles.
3529         * objfiles.h (ALL_OBJSECTIONS): Remove.
3530         * maint.c (maintenance_translate_address): Use all_objfiles.
3531         * gcore.c (gcore_create_callback): Use all_objfiles.
3532         (objfile_find_memory_regions): Likewise.
3533
3534 2019-01-09  Tom Tromey  <tom@tromey.com>
3535
3536         * symtab.c (find_line_symtab, info_sources_command)
3537         (make_source_files_completion_list): Use objfile_compunits.
3538         * source.c (select_source_symtab): Use objfile_compunits.
3539         * objfiles.h (struct objfile): Update comment.
3540         (ALL_OBJFILES): Remove.
3541         (ALL_FILETABS): Remove.
3542         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3543         objfile_compunits.
3544
3545 2019-01-09  Tom Tromey  <tom@tromey.com>
3546
3547         * symmisc.c (print_objfile_statistics, dump_objfile)
3548         (maintenance_print_symbols): Use compunit_filetabs.
3549         * source.c (forget_cached_source_info_for_objfile): Use
3550         compunit_filetabs.
3551         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3552         (ALL_FILETABS): Use compunit_filetabs.
3553         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3554         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3555
3556 2019-01-09  Tom Tromey  <tom@tromey.com>
3557
3558         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3559         (compunit_filetabs): New.
3560         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3561         compunit_filetabs.
3562         (info_sources_command, make_source_files_completion_list): Remove
3563         declaration.
3564         * symmisc.c (print_objfile_statistics, dump_objfile)
3565         (maintenance_print_symbols): Remove declaration.
3566         (maintenance_info_symtabs): Use compunit_filetabs.
3567         (maintenance_info_line_tables): Likewise.
3568         * source.c (select_source_symtab): Change local variable name.
3569         (forget_cached_source_info_for_objfile): Remove declaration.
3570         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3571         * objfiles.c (objfile_relocate1): Remove declaration.
3572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3573         declaration.
3574         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3575         * coffread.c (coff_symtab_read): Remove declaration.
3576         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3577         compunit_filetabs.
3578
3579 2019-01-09  Tom Tromey  <tom@tromey.com>
3580
3581         * symtab.c (lookup_objfile_from_block)
3582         (find_pc_sect_compunit_symtab, search_symbols)
3583         (default_collect_symbol_completion_matches_break_on): Use
3584         objfile_compunits.
3585         * objfiles.h (ALL_COMPUNITS): Remove.
3586         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3587         * cp-support.c (add_symbol_overload_list_qualified): Use
3588         objfile_compunits.
3589         * ada-lang.c (ada_collect_symbol_completion_matches)
3590         (ada_add_global_exceptions): Use objfile_compunits.
3591
3592 2019-01-09  Tom Tromey  <tom@tromey.com>
3593
3594         * source.c (select_source_symtab)
3595         (forget_cached_source_info_for_objfile): Remove declaration.
3596         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3597         declaration.
3598         * maint.c (count_symtabs_and_blocks): Remove declaration.
3599         * cp-support.c (add_symbol_overload_list_qualified): Remove
3600         declaration.
3601         * coffread.c (coff_symtab_read): Remove declaration.
3602         * symtab.c (lookup_symbol_in_objfile_symtabs)
3603         (basic_lookup_transparent_type_1): Use objfile_compunits.
3604         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3605         (info_sources_command, search_symbols)
3606         (default_collect_symbol_completion_matches_break_on)
3607         (make_source_files_completion_list): Remove declaration.
3608         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3609         (ada_collect_symbol_completion_matches)
3610         (ada_add_global_exceptions): Remove declaration.
3611         * linespec.c (iterate_over_all_matching_symtabs): Use
3612         objfile_compunits.
3613         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3614         (class objfile_compunits): New.
3615         (ALL_COMPUNITS): Use objfile_compunits.
3616         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3617         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3618         objfile_compunits.
3619         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3620
3621 2019-01-09  Tom Tromey  <tom@tromey.com>
3622
3623         * symtab.c (search_symbols)
3624         (default_collect_symbol_completion_matches_break_on): Use
3625         objfile_msymbols.
3626         * ada-lang.c (ada_lookup_simple_minsym)
3627         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3628         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3629         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3630         objfile_msymbols.
3631         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3632         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3633         * objc-lang.c (find_methods): Use objfile_msymbols.
3634         (info_selectors_command, info_classes_command): Likewise.
3635         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3636         * objfiles.h (class objfile_msymbols): New.
3637         (ALL_OBJFILE_MSYMBOLS): Remove.
3638         (ALL_MSYMBOLS): Remove.
3639
3640 2019-01-09  Tom Tromey  <tom@tromey.com>
3641
3642         * common/next-iterator.h (next_adapter): Add Iterator template
3643         parameter.
3644         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3645         (class all_objfiles_safe): New.
3646         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3647         * objfiles.c (put_objfile_before): Update comment.
3648         (add_separate_debug_objfile): Likewise.
3649         (free_all_objfiles): Use all_objfiles_safe.
3650         (objfile_purge_solibs): Likewise.
3651
3652 2019-01-09  Tom Tromey  <tom@tromey.com>
3653
3654         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3655         (expand_symtab_containing_pc, lookup_static_symbol)
3656         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3657         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3658         all_objfiles.
3659         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3660         * breakpoint.c (create_overlay_event_breakpoint)
3661         (create_longjmp_master_breakpoint)
3662         (create_std_terminate_master_breakpoint)
3663         (create_exception_master_breakpoint): Use all_objfiles.
3664         * linux-thread-db.c (try_thread_db_load_from_pdir)
3665         (has_libpthread): Use all_objfiles.
3666         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3667         * linespec.c (iterate_over_all_matching_symtabs)
3668         (search_minsyms_for_name): Use all_objfiles.
3669         * maint.c (maintenance_info_sections): Use all_objfiles.
3670         * main.c (captured_main_1): Use all_objfiles.
3671         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3672         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3673         * guile/scm-pretty-print.c
3674         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3675         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3676         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3677         (maintenance_print_msymbols): Use all_objfiles.
3678         * source.c (select_source_symtab): Use all_objfiles.
3679         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3680         * symfile.c (remove_symbol_file_command)
3681         (expand_symtabs_matching, map_symbol_filenames): Use
3682         all_objfiles.
3683         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3684         all_objfiles.
3685         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3686         * objc-lang.c (find_methods): Use all_objfiles.
3687         * objfiles.c (have_partial_symbols, have_full_symbols)
3688         (have_minimal_symbols, qsort_cmp)
3689         (default_iterate_over_objfiles_in_search_order): Use
3690         all_objfiles.
3691         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3692         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3693         (maintenance_check_psymtabs): Use all_objfiles.
3694         (ALL_PSYMTABS): Remove.
3695         * compile/compile-object-run.c (do_module_cleanup): Use
3696         all_objfiles.
3697         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3698         * cp-support.c (add_symbol_overload_list_qualified): Use
3699         all_objfiles.
3700         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3701         Use all_objfiles.
3702         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3703         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3704         all_objfiles.
3705         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3706         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3707         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3708         Uses all_objfiles.
3709         * solib.c (solib_read_symbols): Use all_objfiles
3710
3711 2019-01-09  Tom Tromey  <tom@tromey.com>
3712
3713         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3714         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3715         all_objfiles.
3716         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3717         * symmisc.c (print_symbol_bcache_statistics)
3718         (print_objfile_statistics, maintenance_print_objfiles)
3719         (maintenance_info_symtabs, maintenance_check_symtabs)
3720         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3721         all_objfiles.
3722         * source.c (forget_cached_source_info): Use all_objfiles.
3723         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3724         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3725         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3726         * objfiles.c (update_section_map): Use all_objfiles.
3727         (shared_objfile_contains_address_p): Likewise.
3728         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3729         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3730
3731 2019-01-09  Tom Tromey  <tom@tromey.com>
3732
3733         * common/next-iterator.h: New file.
3734         * objfiles.h (class all_objfiles): New.
3735         (struct objfile_iterator): New.
3736
3737 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3738
3739         * NEWS: Move the description of the changed "frame", "select-frame",
3740          and "info frame" commands to the Changed commands section.
3741
3742 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3743
3744         * gdbtypes.c (check_stub_method_group): Remove handling of old
3745         mangling schemes.
3746         * linespec.c (find_methods): Likewise.
3747         * stabsread.c (read_member_functions): Likewise.
3748         * valops.c (search_struct_method): Likewise.
3749         (value_struct_elt_for_reference): Likewise.
3750         * NEWS: Mention this change.
3751
3752 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3755         print_source_lines.
3756         * source.c (print_source_lines_base): Update line number check.
3757         (print_source_lines): New function.
3758         (source_lines_range::source_lines_range): New function.
3759         * source.h (class source_lines_range): New class.
3760         (print_source_lines): New declaration.
3761
3762 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3763
3764         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3765
3766 2019-01-08  Tom Tromey  <tom@tromey.com>
3767             Simon Marchi  <simon.marchi@ericsson.com>
3768
3769         PR gdb/24060
3770         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3771         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3772         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3773         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3774         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3775         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3776
3777 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * source.c (select_source_symtab): Move header comment to
3780         declaration in source.h.
3781         (forget_cached_source_info_for_objfile): Likewise.
3782         (forget_cached_source_info): Likewise.
3783         (identify_source_line): Likewise.
3784         * source.h (identify_source_line): Move declaration from symtab.h
3785         and add comment from source.c
3786         (print_source_lines): Likewise.
3787         (forget_cached_source_info_for_objfile): Likewise.
3788         (forget_cached_source_info): Likewise.
3789         (select_source_symtab): Likewise.
3790         (enum print_source_lines_flag): Move definition from symtab.h.
3791         * symtab.h (identify_source_line): Move declaration to source.h.
3792         (print_source_lines): Likewise.
3793         (forget_cached_source_info_for_objfile): Likewise.
3794         (forget_cached_source_info): Likewise.
3795         (select_source_symtab): Likewise.
3796         (enum print_source_lines_flag): Move definition to source.h.
3797         * tui/tui-hooks.c: Add 'source.h' include.
3798
3799 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * source.c (print_source_lines_base): Handle requests to print
3802         reverse line number sequences, and guard against empty lines
3803         string.
3804
3805 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * source.c (print_source_lines_base): Fix skip of '\r' if next
3808         character is '\n'.
3809
3810 2019-01-06  Tom Tromey  <tom@tromey.com>
3811
3812         * c-exp.y (struct c_parse_state) <macro_original_text,
3813         expansion_obstack>: New member.
3814         (macro_original_text, expansion_obstack): Remove globals.
3815         (scan_macro_expansion, scanning_macro_expansion)
3816         (finished_macro_expansion): Update.
3817         (scan_macro_cleanup): Remove.
3818         (yylex, c_parse): Update.
3819
3820 2019-01-06  Tom Tromey  <tom@tromey.com>
3821
3822         * c-exp.y (struct c_parse_state) <strings>: New member.
3823         (operator_stoken): Update.
3824
3825 2019-01-06  Tom Tromey  <tom@tromey.com>
3826
3827         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3828         (union type_stack_elt) <typelist_val>: Now a pointer to
3829         std::vector.
3830         (type_stack_cleanup): Don't declare.
3831         (push_typelist): Update.
3832         * parse.c (pop_typelist): Return a std::vector.
3833         (push_typelist): Take a std::vector.
3834         (follow_types): Update.  Do not free args.
3835         (type_stack_cleanup): Remove.
3836         * c-exp.y (struct c_parse_state): New.
3837         (cpstate): New global.
3838         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3839         (nonempty_typelist): Update.
3840         (func_mod): Create a new vector.
3841         (c_parse): Create a c_parse_state.
3842         (check_parameter_typelist): Do not delete params.
3843         (function_method): Update.  Do not delete type_list.
3844
3845 2019-01-06  Tom Tromey  <tom@tromey.com>
3846
3847         PR gdb/28155:
3848         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3849         check_typedef.
3850         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3851         (print_return_value): Likewise.
3852
3853 2019-01-05  Tom Tromey  <tom@tromey.com>
3854
3855         * contrib/cleanup_check.py: Remove.
3856         * contrib/gcc-with-excheck: Remove.
3857         * contrib/exsummary.py: Remove.
3858         * contrib/excheck.py: Remove.
3859
3860 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3861
3862         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3863         NULL. Initialize tpprev to NULL instead of assigning it
3864         to NULL on the next statement.
3865         * windows-nat.c (windows_delete_thread): Remove check for
3866         main_thread_id before printing thread exit notifications.
3867         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3868         Remove thread ID check against main_thread_id.
3869         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3870         windows_delete_thread.
3871         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3872
3873 2019-01-04  Tom Tromey  <tom@tromey.com>
3874
3875         * compile/compile.c (_initialize_compile): Use upper case for
3876         metasyntactic variables.
3877         * symmisc.c (_initialize_symmisc): Use upper case for
3878         metasyntactic variables.
3879         * psymtab.c (_initialize_psymtab): Use upper case for
3880         metasyntactic variables.
3881         * demangle.c (demangle_command): Use upper case for metasyntactic
3882         variables.
3883         (_initialize_demangler): Likewise.
3884         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3885         variables.
3886
3887 2019-01-03  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3890
3891 2019-01-03  Tom Tromey  <tom@tromey.com>
3892
3893         * python/py-symtab.c (salpy_str): Update.
3894         (struct salpy_sal_object) <symtab>: Now a PyObject.
3895         (salpy_dealloc): Update.
3896         (del_objfile_sal): Use gdbpy_ref.
3897
3898 2019-01-03  Tom Tromey  <tom@tromey.com>
3899
3900         * python/py-type.c (convert_field): Use new_reference.  Return
3901         gdbpy_ref.
3902         (make_fielditem): Return gdbpy_ref.
3903         (typy_fields): Update.
3904         (typy_getitem): Update.
3905         (field_name): Return gdbpy_ref.  Use new_reference.
3906         (typy_iterator_iternext): Update.
3907
3908 2019-01-03  Tom Tromey  <tom@tromey.com>
3909
3910         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3911
3912 2019-01-03  Tom Tromey  <tom@tromey.com>
3913
3914         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3915         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3916         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3917         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3918         (pspy_set_type_printers): Likewise.
3919         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3920         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3921         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3922         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3923         (objfpy_set_type_printers): Likewise.
3924
3925 2019-01-03  Tom Tromey  <tom@tromey.com>
3926
3927         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3928         (gdbpy_print_stack): Use gdbpy_err_fetch.
3929         * python/python-internal.h (class gdbpy_err_fetch): New class.
3930         (class gdbpy_enter) <m_error_type, m_error_value,
3931         m_error_traceback>: Remove.
3932         <m_error>: New member.
3933         (gdbpy_exception_to_string): Don't declare.
3934         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3935         * python/py-value.c (convert_value_from_python): Use
3936         gdbpy_err_fetch.
3937         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3938         gdbpy_exception_to_string.
3939         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3940         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3941         gdbpy_err_fetch.
3942
3943 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3944
3945         * linux-nat.c (delete_lwp_cleanup): Delete.
3946         (struct lwp_deleter): New struct.
3947         (lwp_info_up): New typedef.
3948         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3949         lwp_info_up.
3950
3951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * linux-fork.c (class scoped_switch_fork_info): New class.
3954         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3955
3956 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3957
3958         * valops.c (find_overload_match): Remove use of null_cleanup, and
3959         calls to do_cleanups.
3960
3961 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * compile/compile-cplus-types.c
3964         (compile_cplus_instance::decl_name): Handle changes to
3965         cp_func_name.
3966         * cp-support.c (cp_func_name): Update header comment, update
3967         return type.
3968         * cp-support.h (cp_func_name): Update return type in declaration.
3969         * valops.c (find_overload_match): Move temp_func local to top
3970         level of function and change its type.  Use temp_func to hold and
3971         delete temporary string obtained from cp_func_name.
3972
3973 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3974
3975         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3976         gdb::char_vector, remove cleanup, and update uses of `msg`.
3977
3978 2019-01-03  Jim Wilson  <jimw@sifive.com>
3979
3980         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3981
3982 2019-01-02  Tom Tromey  <tom@tromey.com>
3983
3984         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3985         (tdesc_parse_xml): Remove cleanups.
3986         * target-descriptions.h (make_cleanup_free_target_description):
3987         Don't declare.
3988         (target_desc_deleter): New struct.
3989         (target_desc_up): New typedef.
3990         * target-descriptions.c (target_desc_deleter::operator()): Rename
3991         from free_target_description.
3992         (make_cleanup_free_target_description): Remove.
3993
3994 2019-01-02  Tom Tromey  <tom@tromey.com>
3995
3996         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3997         constructor, destructor.
3998         (linespec_parser): Remove typedef.
3999         (~linespec_parser): Rename from linespec_parser_delete.
4000         (linespec_lex_to_end, linespec_complete_label)
4001         (linespec_complete): Update.
4002         (decode_line_full): Remove cleanups.
4003         (decode_line_1): Update.
4004
4005 2019-01-02  Tom Tromey  <tom@tromey.com>
4006
4007         * python/python-internal.h (inferior_to_inferior_object): Change
4008         return type.
4009         * python/py-exitedevent.c (create_exited_event_object): Update.
4010         * python/py-inferior.c (inferior_to_inferior_object): Return
4011         gdbpy_ref.
4012         (python_new_inferior, python_inferior_deleted)
4013         (thread_to_thread_object, delete_thread_object)
4014         (build_inferior_list, gdbpy_selected_inferior): Update.
4015         * python/py-infthread.c (create_thread_object): Update.  Also fail
4016         if inferior_to_inferior_object fails.
4017
4018 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4019
4020         * inferior.h (class inferior) <displaced_step_state>: New field.
4021         * infrun.h (struct displaced_step_state): Move here from
4022         infrun.c.  Initialize fields, add constructor.
4023         <inf>: Remove field.
4024         <reset>: New method.
4025         * infrun.c (struct displaced_step_inferior_state): Move to
4026         infrun.h.
4027         (displaced_step_inferior_states): Remove.
4028         (get_displaced_stepping_state): Adust.
4029         (displaced_step_in_progress_any_inferior): Adjust.
4030         (displaced_step_in_progress_thread): Adjust.
4031         (displaced_step_in_progress): Adjust.
4032         (add_displaced_stepping_state): Remove.
4033         (get_displaced_step_closure_by_addr): Adjust.
4034         (remove_displaced_stepping_state): Remove.
4035         (infrun_inferior_exit): Call displaced_step_state.reset.
4036         (use_displaced_stepping): Don't check for NULL.
4037         (displaced_step_prepare_throw): Call
4038         get_displaced_stepping_state.
4039         (displaced_step_fixup): Don't check for NULL.
4040         (prepare_for_detach): Don't check for NULL.
4041
4042 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4043
4044         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4045          in case of call that did not complete.
4046
4047 2019-01-02  Andrey Utkin  <autkin@undo.io>
4048
4049         * symfile.c (find_separate_debug_file): Fix search of debug files for
4050         remote debuggee.
4051
4052 2019-01-02  Tom Tromey  <tom@tromey.com>
4053
4054         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4055         indentation.
4056         * python/py-frame.c (frapy_older): Remove cast.
4057         (frapy_newer): Likewise.
4058         * python/py-breakpoint.c (local_setattro): Remove cast.
4059         * python/py-arch.c (archpy_name): Remove local variable.
4060         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4061
4062 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4063
4064         * unittests/basic_string_view/element_access/char/empty.cc:
4065         Fix year range in copyright header.
4066
4067 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4068
4069         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4070         Delete.
4071         <operator==>: Update with for removed field.
4072         <hash>: Likewise.
4073         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4074         <isa_features>: ...this.
4075         <abi_features>: New field.
4076         (riscv_isa_flen): Update comment.
4077         (riscv_abi_xlen): New declaration.
4078         (riscv_abi_flen): New declaration.
4079         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4080         isa_features.
4081         (riscv_abi_xlen): New function.
4082         (riscv_isa_flen): Update to get answer from isa_features.
4083         (riscv_abi_flen): New function.
4084         (riscv_has_fp_abi): Update to get answer from abi_features.
4085         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4086         xlen and flen.
4087         (riscv_call_info) <xlen, flen>: Update comment.
4088         (riscv_call_arg_struct): Remove invalid assertions
4089         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4090         is removed.
4091         (riscv_gdbarch_init): Gather isa features and abi features
4092         separately, ensure both match on the gdbarch when reusing an old
4093         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4094         a target with 64-bit float hardware.
4095
4096 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097
4098         * source.c (search_command_helper): Stop reverse search
4099         when line 1 has been searched.
4100
4101 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4102
4103         * record-full.c (record_full_base_target::close): Rewrite
4104         record_full_core_buf_list free logic.
4105
4106 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4107
4108         * break-catch-syscall.c (print_one_catch_syscall): xfree
4109         the last text.
4110
4111 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4112
4113         * top.c (print_gdb_version): Update Copyright year in version
4114         message.
4115
4116 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4117
4118         Update copyright year range in all GDB files.
4119
4120 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4121
4122         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4123
4124 For older changes see ChangeLog-2018.
4125 \f
4126 Local Variables:
4127 mode: change-log
4128 left-margin: 8
4129 fill-column: 74
4130 version-control: never
4131 coding: utf-8
4132 End:
4133