gdb/ChangeLog

   1 2019-02-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * ravenscar-thread.c: Fix some typos.
   4
   5 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   6             Tom Tromey  <tromey@adacore.com>
   7
   8         * ada-lang.c (ada_exception_sal): Change addr_string to a
   9         std::string.
  10         (create_ada_exception_catchpoint): Update.
  11
  12 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  13             Tom Tromey  <tromey@adacore.com>
  14
  15         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
  16         (bp_location_ops): Remove.
  17         (base_breakpoint_allocate_location): Update.
  18         (free_bp_location): Update.
  19         * ada-lang.c (class ada_catchpoint_location)
  20         <ada_catchpoint_location>: Remove ops parameter.
  21         (ada_catchpoint_location_dtor): Remove.
  22         (ada_catchpoint_location_ops): Remove.
  23         (allocate_location_exception): Update.
  24         * breakpoint.h (struct bp_location_ops): Remove.
  25         (class bp_location) <bp_location>: Remove bp_location_ops
  26         parameter.
  27         <~bp_location>: Add destructor.
  28         <ops>: Remove.
  29
  30 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  31             Pedro Alves  <palves@redhat.com>
  32
  33         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
  34         'PATH_MAX'.
  35
  36 2019-02-14  David Michael  <fedora.dm0@gmail.com>
  37             Samuel Thibault  <samuel.thibault@gnu.org>
  38             Thomas Schwinge  <thomas@codesourcery.com>
  39
  40         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
  41         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
  42
  43 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
  44
  45         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
  46         (check_empty): Use "const char *".
  47
  48         * gnu-nat.c (gnu_nat_target::detach): Instead of
  49         'detach_inferior (pid)' call
  50         'detach_inferior (find_inferior_pid (pid))'.
  51
  52         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  53         'nat/fork-inferior.o'.
  54         * gnu-nat.c: #include "nat/fork-inferior.h".
  55
  56         * gnu-nat.c (gnu_nat_target::detach): Instead of
  57         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  58         * gnu-nat.h: #include "inf-child.h".
  59         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  60         'i386_gnu_nat_target::fetch_registers'.
  61         (gnu_store_registers): Rename/move to
  62         'i386_gnu_nat_target::store_registers'.
  63
  64         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  65         * gnu-nat.h (mach_thread_info): New function.
  66         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  67
  68         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  69
  70 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  71
  72         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  73
  74 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  75
  76         * windows-nat.c (windows_add_thread): Add new parameter
  77         "main_thread_p" with default value set to false.  Update
  78         function documentation as well as all callers.
  79         (windows_delete_thread): Likewise.
  80         (fake_create_process): Update call to windows_add_thread.
  81         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  82         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  83         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  84         call to windows_delete_thread.
  85
  86 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  87
  88         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  89
  90 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  91
  92         * symfile.c (find_separate_debug_file): Use canonical path of
  93         sysroot with child_path instead of gdb_sysroot if it is valid.
  94
  95 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  96
  97         * symfile.c (find_separate_debug_file): Use child_path to
  98         determine if an object file is under a sysroot.
  99
 100 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 101
 102         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 103         unittests/child-path-selftests.c.
 104         * common/pathstuff.c (child_path): New function.
 105         * common/pathstuff.h (child_path): New prototype.
 106         * unittests/child-path-selftests.c: New file.
 107
 108 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 109
 110         * symfile.c (find_separate_debug_file): Look for separate debug
 111         files in debug directories under the sysroot.
 112
 113 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 114
 115         * symtab.h (struct minimal_symbol data_p): New const method.
 116         (struct minimal_symbol text_p): Likewise.
 117         * symtab.c (output_source_filename): Use file name style
 118         to print file name.
 119         (print_symbol_info): Likewise.
 120         (print_msymbol_info): Use address style to print addresses.
 121         Use function name style to print executable text symbols.
 122         (expand_symtab_containing_pc): Use data_p.
 123         (find_pc_sect_compunit_symtab): Likewise.
 124
 125 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 126
 127         * breakpoint.c (describe_other_breakpoints): Use address style
 128         to print addresses.
 129         (say_where): Likewise.
 130
 131 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 132
 133         * ada-typeprint.c (print_func_type): Print function name
 134         style to print function name.
 135         * c-typeprint.c (c_print_type_1): Likewise.
 136
 137 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 138
 139         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 140         for execve.
 141
 142 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 143
 144         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 145         type_stack.
 146
 147 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 148
 149         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 150         TYPE_CODE_REF types.
 151
 152 2019-02-08  Jim Wilson  <jimw@sifive.com>
 153
 154         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 155         (riscv_linux_fregset): New.
 156         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 157
 158 2019-02-07  Tom Tromey  <tom@tromey.com>
 159
 160         * thread.c (thread_cancel_execution_command): Update.
 161         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 162         methods.
 163         (struct thread_fsm_ops): Remove.
 164         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 165         (thread_fsm_should_stop, thread_fsm_return_value)
 166         (thread_fsm_set_finished, thread_fsm_finished_p)
 167         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 168         Don't declare.
 169         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 170         * infrun.c (clear_proceed_status_thread)
 171         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 172         (print_stop_event): Update.
 173         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 174         Add constructor.
 175         (step_command_fsm_ops): Remove.
 176         (new_step_command_fsm): Remove.
 177         (step_1): Update.
 178         (step_command_fsm::should_stop): Rename from
 179         step_command_fsm_should_stop.
 180         (step_command_fsm::clean_up): Rename from
 181         step_command_fsm_clean_up.
 182         (step_command_fsm::do_async_reply_reason): Rename from
 183         step_command_fsm_async_reply_reason.
 184         (struct until_next_fsm): Inherit from thread_fsm.  Add
 185         constructor.
 186         (until_next_fsm_ops): Remove.
 187         (new_until_next_fsm): Remove.
 188         (until_next_fsm::should_stop): Rename from
 189         until_next_fsm_should_stop.
 190         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 191         (until_next_fsm::do_async_reply_reason): Rename from
 192         until_next_fsm_async_reply_reason.
 193         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 194         constructor.  Change type of breakpoint.
 195         (finish_command_fsm_ops): Remove.
 196         (new_finish_command_fsm): Remove.
 197         (finish_command_fsm::should_stop): Rename from
 198         finish_command_fsm_should_stop.
 199         (finish_command_fsm::clean_up): Rename from
 200         finish_command_fsm_clean_up.
 201         (finish_command_fsm::return_value): Rename from
 202         finish_command_fsm_return_value.
 203         (finish_command_fsm::do_async_reply_reason): Rename from
 204         finish_command_fsm_async_reply_reason.
 205         (finish_command): Update.
 206         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 207         Add constructor.
 208         (call_thread_fsm_ops): Remove.
 209         (call_thread_fsm::call_thread_fsm): Rename from
 210         new_call_thread_fsm.
 211         (call_thread_fsm::should_stop): Rename from
 212         call_thread_fsm_should_stop.
 213         (call_thread_fsm::should_notify_stop): Rename from
 214         call_thread_fsm_should_notify_stop.
 215         (run_inferior_call, call_function_by_hand_dummy): Update.
 216         * cli/cli-interp.c (should_print_stop_to_console): Update.
 217         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 218         Add constructor.  Change type of location_breakpoint,
 219         caller_breakpoint.
 220         (until_break_fsm_ops): Remove.
 221         (new_until_break_fsm): Remove.
 222         (until_break_fsm::should_stop): Rename from
 223         until_break_fsm_should_stop.
 224         (until_break_fsm::clean_up): Rename from
 225         until_break_fsm_clean_up.
 226         (until_break_fsm::do_async_reply_reason): Rename from
 227         until_break_fsm_async_reply_reason.
 228         (until_break_command): Update.
 229         * thread-fsm.c: Remove.
 230         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 231
 232 2019-02-07  Tom Tromey  <tom@tromey.com>
 233
 234         * yy-remap.h: Add include guard.
 235         * xtensa-tdep.h: Add include guard.
 236         * xcoffread.h: Rename include guard.
 237         * varobj-iter.h: Add include guard.
 238         * tui/tui.h: Rename include guard.
 239         * tui/tui-winsource.h: Rename include guard.
 240         * tui/tui-wingeneral.h: Rename include guard.
 241         * tui/tui-windata.h: Rename include guard.
 242         * tui/tui-win.h: Rename include guard.
 243         * tui/tui-stack.h: Rename include guard.
 244         * tui/tui-source.h: Rename include guard.
 245         * tui/tui-regs.h: Rename include guard.
 246         * tui/tui-out.h: Rename include guard.
 247         * tui/tui-layout.h: Rename include guard.
 248         * tui/tui-io.h: Rename include guard.
 249         * tui/tui-hooks.h: Rename include guard.
 250         * tui/tui-file.h: Rename include guard.
 251         * tui/tui-disasm.h: Rename include guard.
 252         * tui/tui-data.h: Rename include guard.
 253         * tui/tui-command.h: Rename include guard.
 254         * tic6x-tdep.h: Add include guard.
 255         * target/waitstatus.h: Rename include guard.
 256         * target/wait.h: Rename include guard.
 257         * target/target.h: Rename include guard.
 258         * target/resume.h: Rename include guard.
 259         * target-float.h: Rename include guard.
 260         * stabsread.h: Add include guard.
 261         * rs6000-tdep.h: Add include guard.
 262         * riscv-fbsd-tdep.h: Add include guard.
 263         * regformats/regdef.h: Rename include guard.
 264         * record.h: Rename include guard.
 265         * python/python.h: Rename include guard.
 266         * python/python-internal.h: Rename include guard.
 267         * python/py-stopevent.h: Rename include guard.
 268         * python/py-ref.h: Rename include guard.
 269         * python/py-record.h: Rename include guard.
 270         * python/py-record-full.h: Rename include guard.
 271         * python/py-record-btrace.h: Rename include guard.
 272         * python/py-instruction.h: Rename include guard.
 273         * python/py-events.h: Rename include guard.
 274         * python/py-event.h: Rename include guard.
 275         * procfs.h: Add include guard.
 276         * proc-utils.h: Add include guard.
 277         * p-lang.h: Add include guard.
 278         * or1k-tdep.h: Rename include guard.
 279         * observable.h: Rename include guard.
 280         * nto-tdep.h: Rename include guard.
 281         * nat/x86-linux.h: Rename include guard.
 282         * nat/x86-linux-dregs.h: Rename include guard.
 283         * nat/x86-gcc-cpuid.h: Add include guard.
 284         * nat/x86-dregs.h: Rename include guard.
 285         * nat/x86-cpuid.h: Rename include guard.
 286         * nat/ppc-linux.h: Rename include guard.
 287         * nat/mips-linux-watch.h: Rename include guard.
 288         * nat/linux-waitpid.h: Rename include guard.
 289         * nat/linux-ptrace.h: Rename include guard.
 290         * nat/linux-procfs.h: Rename include guard.
 291         * nat/linux-osdata.h: Rename include guard.
 292         * nat/linux-nat.h: Rename include guard.
 293         * nat/linux-namespaces.h: Rename include guard.
 294         * nat/linux-btrace.h: Rename include guard.
 295         * nat/glibc_thread_db.h: Rename include guard.
 296         * nat/gdb_thread_db.h: Rename include guard.
 297         * nat/gdb_ptrace.h: Rename include guard.
 298         * nat/fork-inferior.h: Rename include guard.
 299         * nat/amd64-linux-siginfo.h: Rename include guard.
 300         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 301         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 302         * nat/aarch64-linux.h: Rename include guard.
 303         * nat/aarch64-linux-hw-point.h: Rename include guard.
 304         * mn10300-tdep.h: Add include guard.
 305         * mips-linux-tdep.h: Add include guard.
 306         * mi/mi-parse.h: Rename include guard.
 307         * mi/mi-out.h: Rename include guard.
 308         * mi/mi-main.h: Rename include guard.
 309         * mi/mi-interp.h: Rename include guard.
 310         * mi/mi-getopt.h: Rename include guard.
 311         * mi/mi-console.h: Rename include guard.
 312         * mi/mi-common.h: Rename include guard.
 313         * mi/mi-cmds.h: Rename include guard.
 314         * mi/mi-cmd-break.h: Rename include guard.
 315         * m2-lang.h: Add include guard.
 316         * location.h: Rename include guard.
 317         * linux-record.h: Rename include guard.
 318         * linux-nat.h: Add include guard.
 319         * linux-fork.h: Add include guard.
 320         * i386-darwin-tdep.h: Rename include guard.
 321         * hppa-linux-offsets.h: Add include guard.
 322         * guile/guile.h: Rename include guard.
 323         * guile/guile-internal.h: Rename include guard.
 324         * gnu-nat.h: Rename include guard.
 325         * gdb-stabs.h: Rename include guard.
 326         * frv-tdep.h: Add include guard.
 327         * f-lang.h: Add include guard.
 328         * event-loop.h: Add include guard.
 329         * darwin-nat.h: Rename include guard.
 330         * cp-abi.h: Rename include guard.
 331         * config/sparc/nm-sol2.h: Rename include guard.
 332         * config/nm-nto.h: Rename include guard.
 333         * config/nm-linux.h: Add include guard.
 334         * config/i386/nm-i386gnu.h: Rename include guard.
 335         * config/djgpp/nl_types.h: Rename include guard.
 336         * config/djgpp/langinfo.h: Rename include guard.
 337         * compile/gcc-cp-plugin.h: Add include guard.
 338         * compile/gcc-c-plugin.h: Add include guard.
 339         * compile/compile.h: Rename include guard.
 340         * compile/compile-object-run.h: Rename include guard.
 341         * compile/compile-object-load.h: Rename include guard.
 342         * compile/compile-internal.h: Rename include guard.
 343         * compile/compile-cplus.h: Rename include guard.
 344         * compile/compile-c.h: Rename include guard.
 345         * common/xml-utils.h: Rename include guard.
 346         * common/x86-xstate.h: Rename include guard.
 347         * common/version.h: Rename include guard.
 348         * common/vec.h: Rename include guard.
 349         * common/tdesc.h: Rename include guard.
 350         * common/selftest.h: Rename include guard.
 351         * common/scoped_restore.h: Rename include guard.
 352         * common/scoped_mmap.h: Rename include guard.
 353         * common/scoped_fd.h: Rename include guard.
 354         * common/safe-iterator.h: Rename include guard.
 355         * common/run-time-clock.h: Rename include guard.
 356         * common/refcounted-object.h: Rename include guard.
 357         * common/queue.h: Rename include guard.
 358         * common/ptid.h: Rename include guard.
 359         * common/print-utils.h: Rename include guard.
 360         * common/preprocessor.h: Rename include guard.
 361         * common/pathstuff.h: Rename include guard.
 362         * common/observable.h: Rename include guard.
 363         * common/netstuff.h: Rename include guard.
 364         * common/job-control.h: Rename include guard.
 365         * common/host-defs.h: Rename include guard.
 366         * common/gdb_wait.h: Rename include guard.
 367         * common/gdb_vecs.h: Rename include guard.
 368         * common/gdb_unlinker.h: Rename include guard.
 369         * common/gdb_unique_ptr.h: Rename include guard.
 370         * common/gdb_tilde_expand.h: Rename include guard.
 371         * common/gdb_sys_time.h: Rename include guard.
 372         * common/gdb_string_view.h: Rename include guard.
 373         * common/gdb_splay_tree.h: Rename include guard.
 374         * common/gdb_setjmp.h: Rename include guard.
 375         * common/gdb_ref_ptr.h: Rename include guard.
 376         * common/gdb_optional.h: Rename include guard.
 377         * common/gdb_locale.h: Rename include guard.
 378         * common/gdb_assert.h: Rename include guard.
 379         * common/filtered-iterator.h: Rename include guard.
 380         * common/filestuff.h: Rename include guard.
 381         * common/fileio.h: Rename include guard.
 382         * common/environ.h: Rename include guard.
 383         * common/common-utils.h: Rename include guard.
 384         * common/common-types.h: Rename include guard.
 385         * common/common-regcache.h: Rename include guard.
 386         * common/common-inferior.h: Rename include guard.
 387         * common/common-gdbthread.h: Rename include guard.
 388         * common/common-exceptions.h: Rename include guard.
 389         * common/common-defs.h: Rename include guard.
 390         * common/common-debug.h: Rename include guard.
 391         * common/cleanups.h: Rename include guard.
 392         * common/buffer.h: Rename include guard.
 393         * common/btrace-common.h: Rename include guard.
 394         * common/break-common.h: Rename include guard.
 395         * cli/cli-utils.h: Rename include guard.
 396         * cli/cli-style.h: Rename include guard.
 397         * cli/cli-setshow.h: Rename include guard.
 398         * cli/cli-script.h: Rename include guard.
 399         * cli/cli-interp.h: Rename include guard.
 400         * cli/cli-decode.h: Rename include guard.
 401         * cli/cli-cmds.h: Rename include guard.
 402         * charset-list.h: Add include guard.
 403         * buildsym-legacy.h: Rename include guard.
 404         * bfin-tdep.h: Add include guard.
 405         * ax.h: Rename include guard.
 406         * arm-linux-tdep.h: Add include guard.
 407         * arm-fbsd-tdep.h: Add include guard.
 408         * arch/xtensa.h: Rename include guard.
 409         * arch/tic6x.h: Add include guard.
 410         * arch/i386.h: Add include guard.
 411         * arch/arm.h: Rename include guard.
 412         * arch/arm-linux.h: Rename include guard.
 413         * arch/arm-get-next-pcs.h: Rename include guard.
 414         * arch/amd64.h: Add include guard.
 415         * arch/aarch64-insn.h: Rename include guard.
 416         * arch-utils.h: Rename include guard.
 417         * annotate.h: Add include guard.
 418         * amd64-darwin-tdep.h: Rename include guard.
 419         * aarch64-linux-tdep.h: Add include guard.
 420         * aarch64-fbsd-tdep.h: Add include guard.
 421         * aarch32-linux-nat.h: Add include guard.
 422
 423 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 424
 425         * macrotab.c (macro_define_internal): New function that
 426         factorizes macro_define_object_internal and macro_define_function
 427         code.
 428         (macro_define_object_internal): Use macro_define_internal.
 429         (macro_define_function): Likewise.
 430
 431 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 432
 433         * macrocmd.c (extract_identifier): Return
 434         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 435         callers.
 436
 437 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 438
 439         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 440
 441 2019-02-05  Tom Tromey  <tom@tromey.com>
 442
 443         * target.c (target_stack::unpush): Move assertion earlier.
 444
 445 2019-01-30  Tom Tromey  <tom@tromey.com>
 446
 447         PR python/23615:
 448         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 449         (gdbpy_parse_and_eval): Likewise.
 450         * python/python-internal.h (gdbpy_allow_threads): New class.
 451
 452 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 453
 454         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 455         (aarch64_fbsd_fpregmap): Move earlier.
 456         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 457         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 458         instead of individual calls to trad_frame_set_reg_addr.
 459         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 460         earlier.
 461         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 462         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 463         instead of individual calls to trad_frame_set_reg_addr.
 464
 465 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 466
 467         * CONTRIBUTE: Replace contribution list with wiki link.
 468
 469 2019-01-25  Tom Tromey  <tom@tromey.com>
 470
 471         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 472
 473 2019-01-25  Tom Tromey  <tom@tromey.com>
 474
 475         * xtensa-linux-nat.c: Fix common/ includes.
 476         * xml-support.h: Fix common/ includes.
 477         * xml-support.c: Fix common/ includes.
 478         * x86-linux-nat.c: Fix common/ includes.
 479         * windows-nat.c: Fix common/ includes.
 480         * varobj.h: Fix common/ includes.
 481         * varobj.c: Fix common/ includes.
 482         * value.c: Fix common/ includes.
 483         * valops.c: Fix common/ includes.
 484         * utils.c: Fix common/ includes.
 485         * unittests/xml-utils-selftests.c: Fix common/ includes.
 486         * unittests/utils-selftests.c: Fix common/ includes.
 487         * unittests/unpack-selftests.c: Fix common/ includes.
 488         * unittests/tracepoint-selftests.c: Fix common/ includes.
 489         * unittests/style-selftests.c: Fix common/ includes.
 490         * unittests/string_view-selftests.c: Fix common/ includes.
 491         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 492         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 493         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 494         * unittests/rsp-low-selftests.c: Fix common/ includes.
 495         * unittests/parse-connection-spec-selftests.c: Fix common/
 496         includes.
 497         * unittests/optional-selftests.c: Fix common/ includes.
 498         * unittests/offset-type-selftests.c: Fix common/ includes.
 499         * unittests/observable-selftests.c: Fix common/ includes.
 500         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 501         * unittests/memrange-selftests.c: Fix common/ includes.
 502         * unittests/memory-map-selftests.c: Fix common/ includes.
 503         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 504         * unittests/function-view-selftests.c: Fix common/ includes.
 505         * unittests/environ-selftests.c: Fix common/ includes.
 506         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 507         * unittests/common-utils-selftests.c: Fix common/ includes.
 508         * unittests/cli-utils-selftests.c: Fix common/ includes.
 509         * unittests/array-view-selftests.c: Fix common/ includes.
 510         * ui-file.c: Fix common/ includes.
 511         * tui/tui-io.c: Fix common/ includes.
 512         * tracepoint.h: Fix common/ includes.
 513         * tracepoint.c: Fix common/ includes.
 514         * tracefile-tfile.c: Fix common/ includes.
 515         * top.h: Fix common/ includes.
 516         * top.c: Fix common/ includes.
 517         * thread.c: Fix common/ includes.
 518         * target/waitstatus.h: Fix common/ includes.
 519         * target/waitstatus.c: Fix common/ includes.
 520         * target.h: Fix common/ includes.
 521         * target.c: Fix common/ includes.
 522         * target-memory.c: Fix common/ includes.
 523         * target-descriptions.c: Fix common/ includes.
 524         * symtab.h: Fix common/ includes.
 525         * symfile.c: Fix common/ includes.
 526         * stap-probe.c: Fix common/ includes.
 527         * spu-linux-nat.c: Fix common/ includes.
 528         * sparc-nat.c: Fix common/ includes.
 529         * source.c: Fix common/ includes.
 530         * solib.c: Fix common/ includes.
 531         * solib-target.c: Fix common/ includes.
 532         * ser-unix.c: Fix common/ includes.
 533         * ser-tcp.c: Fix common/ includes.
 534         * ser-pipe.c: Fix common/ includes.
 535         * ser-base.c: Fix common/ includes.
 536         * selftest-arch.c: Fix common/ includes.
 537         * s12z-tdep.c: Fix common/ includes.
 538         * rust-exp.y: Fix common/ includes.
 539         * rs6000-aix-tdep.c: Fix common/ includes.
 540         * riscv-tdep.c: Fix common/ includes.
 541         * remote.c: Fix common/ includes.
 542         * remote-notif.h: Fix common/ includes.
 543         * remote-fileio.h: Fix common/ includes.
 544         * remote-fileio.c: Fix common/ includes.
 545         * regcache.h: Fix common/ includes.
 546         * regcache.c: Fix common/ includes.
 547         * record-btrace.c: Fix common/ includes.
 548         * python/python.c: Fix common/ includes.
 549         * python/py-type.c: Fix common/ includes.
 550         * python/py-inferior.c: Fix common/ includes.
 551         * progspace.h: Fix common/ includes.
 552         * producer.c: Fix common/ includes.
 553         * procfs.c: Fix common/ includes.
 554         * proc-api.c: Fix common/ includes.
 555         * printcmd.c: Fix common/ includes.
 556         * ppc-linux-nat.c: Fix common/ includes.
 557         * parser-defs.h: Fix common/ includes.
 558         * osdata.c: Fix common/ includes.
 559         * obsd-nat.c: Fix common/ includes.
 560         * nat/x86-linux.c: Fix common/ includes.
 561         * nat/x86-linux-dregs.c: Fix common/ includes.
 562         * nat/x86-dregs.h: Fix common/ includes.
 563         * nat/x86-dregs.c: Fix common/ includes.
 564         * nat/ppc-linux.c: Fix common/ includes.
 565         * nat/mips-linux-watch.h: Fix common/ includes.
 566         * nat/mips-linux-watch.c: Fix common/ includes.
 567         * nat/linux-waitpid.c: Fix common/ includes.
 568         * nat/linux-ptrace.h: Fix common/ includes.
 569         * nat/linux-ptrace.c: Fix common/ includes.
 570         * nat/linux-procfs.c: Fix common/ includes.
 571         * nat/linux-personality.c: Fix common/ includes.
 572         * nat/linux-osdata.c: Fix common/ includes.
 573         * nat/linux-namespaces.c: Fix common/ includes.
 574         * nat/linux-btrace.h: Fix common/ includes.
 575         * nat/linux-btrace.c: Fix common/ includes.
 576         * nat/fork-inferior.c: Fix common/ includes.
 577         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 578         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 579         * nat/aarch64-linux.c: Fix common/ includes.
 580         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 581         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 582         * namespace.h: Fix common/ includes.
 583         * mips-linux-tdep.c: Fix common/ includes.
 584         * minsyms.c: Fix common/ includes.
 585         * mi/mi-parse.h: Fix common/ includes.
 586         * mi/mi-main.c: Fix common/ includes.
 587         * mi/mi-cmd-env.c: Fix common/ includes.
 588         * memrange.h: Fix common/ includes.
 589         * memattr.c: Fix common/ includes.
 590         * maint.h: Fix common/ includes.
 591         * maint.c: Fix common/ includes.
 592         * main.c: Fix common/ includes.
 593         * machoread.c: Fix common/ includes.
 594         * location.c: Fix common/ includes.
 595         * linux-thread-db.c: Fix common/ includes.
 596         * linux-nat.c: Fix common/ includes.
 597         * linux-fork.c: Fix common/ includes.
 598         * inline-frame.c: Fix common/ includes.
 599         * infrun.c: Fix common/ includes.
 600         * inflow.c: Fix common/ includes.
 601         * inferior.h: Fix common/ includes.
 602         * inferior.c: Fix common/ includes.
 603         * infcmd.c: Fix common/ includes.
 604         * inf-ptrace.c: Fix common/ includes.
 605         * inf-child.c: Fix common/ includes.
 606         * ia64-linux-nat.c: Fix common/ includes.
 607         * i387-tdep.c: Fix common/ includes.
 608         * i386-tdep.c: Fix common/ includes.
 609         * i386-linux-tdep.c: Fix common/ includes.
 610         * i386-linux-nat.c: Fix common/ includes.
 611         * i386-go32-tdep.c: Fix common/ includes.
 612         * i386-fbsd-tdep.c: Fix common/ includes.
 613         * i386-fbsd-nat.c: Fix common/ includes.
 614         * guile/scm-type.c: Fix common/ includes.
 615         * guile/guile.c: Fix common/ includes.
 616         * go32-nat.c: Fix common/ includes.
 617         * gnu-nat.c: Fix common/ includes.
 618         * gdbthread.h: Fix common/ includes.
 619         * gdbarch-selftests.c: Fix common/ includes.
 620         * gdb_usleep.c: Fix common/ includes.
 621         * gdb_select.h: Fix common/ includes.
 622         * gdb_bfd.c: Fix common/ includes.
 623         * gcore.c: Fix common/ includes.
 624         * fork-child.c: Fix common/ includes.
 625         * findvar.c: Fix common/ includes.
 626         * fbsd-nat.c: Fix common/ includes.
 627         * event-top.c: Fix common/ includes.
 628         * event-loop.c: Fix common/ includes.
 629         * dwarf2read.c: Fix common/ includes.
 630         * dwarf2loc.c: Fix common/ includes.
 631         * dwarf2-frame.c: Fix common/ includes.
 632         * dwarf-index-cache.c: Fix common/ includes.
 633         * dtrace-probe.c: Fix common/ includes.
 634         * disasm-selftests.c: Fix common/ includes.
 635         * defs.h: Fix common/ includes.
 636         * csky-tdep.c: Fix common/ includes.
 637         * cp-valprint.c: Fix common/ includes.
 638         * cp-support.h: Fix common/ includes.
 639         * cp-support.c: Fix common/ includes.
 640         * corelow.c: Fix common/ includes.
 641         * completer.h: Fix common/ includes.
 642         * completer.c: Fix common/ includes.
 643         * compile/compile.c: Fix common/ includes.
 644         * compile/compile-loc2c.c: Fix common/ includes.
 645         * compile/compile-cplus-types.c: Fix common/ includes.
 646         * compile/compile-cplus-symbols.c: Fix common/ includes.
 647         * command.h: Fix common/ includes.
 648         * cli/cli-dump.c: Fix common/ includes.
 649         * cli/cli-cmds.c: Fix common/ includes.
 650         * charset.c: Fix common/ includes.
 651         * build-id.c: Fix common/ includes.
 652         * btrace.h: Fix common/ includes.
 653         * btrace.c: Fix common/ includes.
 654         * breakpoint.h: Fix common/ includes.
 655         * breakpoint.c: Fix common/ includes.
 656         * ax.h:
 657         (enum agent_op): Fix common/ includes.
 658         * ax-general.c (struct aop_map): Fix common/ includes.
 659         * ax-gdb.c: Fix common/ includes.
 660         * auxv.c: Fix common/ includes.
 661         * auto-load.c: Fix common/ includes.
 662         * arm-tdep.c: Fix common/ includes.
 663         * arch/riscv.c: Fix common/ includes.
 664         * arch/ppc-linux-common.c: Fix common/ includes.
 665         * arch/i386.c: Fix common/ includes.
 666         * arch/arm.c: Fix common/ includes.
 667         * arch/arm-linux.c: Fix common/ includes.
 668         * arch/arm-get-next-pcs.c: Fix common/ includes.
 669         * arch/amd64.c: Fix common/ includes.
 670         * arch/aarch64.c: Fix common/ includes.
 671         * arch/aarch64-insn.c: Fix common/ includes.
 672         * arch-utils.c: Fix common/ includes.
 673         * amd64-windows-tdep.c: Fix common/ includes.
 674         * amd64-tdep.c: Fix common/ includes.
 675         * amd64-sol2-tdep.c: Fix common/ includes.
 676         * amd64-obsd-tdep.c: Fix common/ includes.
 677         * amd64-nbsd-tdep.c: Fix common/ includes.
 678         * amd64-linux-tdep.c: Fix common/ includes.
 679         * amd64-linux-nat.c: Fix common/ includes.
 680         * amd64-fbsd-tdep.c: Fix common/ includes.
 681         * amd64-fbsd-nat.c: Fix common/ includes.
 682         * amd64-dicos-tdep.c: Fix common/ includes.
 683         * amd64-darwin-tdep.c: Fix common/ includes.
 684         * agent.c: Fix common/ includes.
 685         * ada-lang.h: Fix common/ includes.
 686         * ada-lang.c: Fix common/ includes.
 687         * aarch64-tdep.c: Fix common/ includes.
 688
 689 2019-01-25  Tom Tromey  <tom@tromey.com>
 690
 691         * common/create-version.sh: Use common/version.h.
 692
 693 2019-01-24  Pedro Alves  <palves@redhat.com>
 694
 695         * infrun.c (signal_stop, signal_print, signal_program)
 696         (signal_catch, signal_pass): Now arrays instead of pointers.
 697         (update_signals_program_target, do_target_resume)
 698         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 699         * linux-nat.c (linux_nat_target::pass_signals)
 700         (linux_nat_target::create_inferior, linux_nat_target::attach):
 701         Adjust.
 702         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 703         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 704         * procfs.c (procfs_target::pass_signals): Adjust.
 705         * record-full.c (record_full_target::resume): Adjust.
 706         * remote.c (remote_target::pass_signals)
 707         (remote_target::program_signals): Adjust.
 708         * target-debug.h (target_debug_print_signals): Now takes a
 709         gdb::array_view as parameter.  Adjust.
 710         * target.h (target_ops) <pass_signals, program_signals>: Replace
 711         pointer and length parameters with gdb::array_view.
 712         (target_pass_signals, target_program_signals): Likewise.
 713         * target-delegates.c: Regenerate.
 714
 715 2019-01-24  Pedro Alves  <palves@redhat.com>
 716
 717         * common/forward-scope-exit.h
 718         (forward_scope_exit::forward_scope_exit): Pass arguments to
 719         m_bind_function directly, instead of creating a std::bind and
 720         copying that.
 721
 722 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 723
 724         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 725         for static members.
 726         (pass_in_v_vfp_candidate): Likewise.
 727
 728 2019-01-23  Tom Tromey  <tom@tromey.com>
 729             Pedro Alves  <palves@redhat.com>
 730
 731         * regcache.c (class regcache_invalidator): Remove.
 732         (regcache::raw_write): Use make_scope_exit.
 733
 734 2019-01-23  Tom Tromey  <tom@tromey.com>
 735
 736         * ui-out.h (class ui_out_emit_type): Update comment.
 737
 738 2019-01-23  Tom Tromey  <tom@tromey.com>
 739
 740         * infrun.c (fetch_inferior_event): Update comment.
 741
 742 2019-01-23  Tom Tromey  <tom@tromey.com>
 743             Pedro Alves  <palves@redhat.com>
 744
 745         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 746         parameter.
 747         (fetch_inferior_event): Use SCOPE_EXIT.
 748
 749
 750 2019-01-23  Tom Tromey  <tom@tromey.com>
 751             Pedro Alves  <palves@redhat.com>
 752
 753         * infrun.c (disable_thread_events): Delete.
 754         (stop_all_threads): Use SCOPE_EXIT.
 755
 756 2019-01-23  Tom Tromey  <tom@tromey.com>
 757             Pedro Alves  <palves@redhat.com>
 758
 759         * symfile.c: Include forward-scope-exit.h.
 760         (clear_symtab_users_cleanup): Replace forward declaration with
 761         a FORWARD_SCOPE_EXIT.
 762         (syms_from_objfile_1): Use the forward_scope_exit and
 763         gdb::optional instead of cleanup_function.
 764         (reread_symbols): Use the forward_scope_exit instead of
 765         cleanup_function.
 766         (clear_symtab_users_cleanup): Remove function.
 767
 768 2019-01-23  Tom Tromey  <tom@tromey.com>
 769             Pedro Alves  <palves@redhat.com>
 770
 771         * linux-nat.c: Include scope-exit.h.
 772         (cleanup_target_stop): Remove.
 773         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 774         SCOPE_EXIT.
 775
 776 2019-01-23  Tom Tromey  <tom@tromey.com>
 777             Pedro Alves  <palves@redhat.com>
 778
 779         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 780         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 781
 782 2019-01-23  Tom Tromey  <tom@tromey.com>
 783             Andrew Burgess  <andrew.burgess@embecosm.com>
 784             Pedro Alves  <palves@redhat.com>
 785
 786         * infrun.c (fetch_inferior_event): Use scope_exit.
 787         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 788         * top.c (execute_command): Use scope_exit.
 789         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 790         * utils.c (do_bpstat_clear_actions_cleanup)
 791         (make_bpstat_clear_actions_cleanup): Remove.
 792
 793 2019-01-23  Tom Tromey  <tom@tromey.com>
 794             Pedro Alves  <palves@redhat.com>
 795
 796         * infrun.c: Include "common/scope-exit.h"
 797         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 798         (wait_for_inferior): Use SCOPE_EXIT.
 799         (fetch_inferior_event): Use scope_exit.
 800
 801 2019-01-23  Tom Tromey  <tom@tromey.com>
 802             Pedro Alves  <palves@redhat.com>
 803
 804         * breakpoint.c (create_breakpoint): Remove cleanup.
 805
 806 2019-01-23  Tom Tromey  <tom@tromey.com>
 807             Andrew Burgess  <andrew.burgess@embecosm.com>
 808             Pedro Alves  <palves@redhat.com>
 809
 810 2019-01-23  Pedro Alves  <palves@redhat.com>
 811
 812         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 813
 814 2019-01-23  Pedro Alves  <palves@redhat.com>
 815             Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * gdbthread.h: Include "common/forward-scope-exit.h".
 818         (scoped_finish_thread_state): Redefine custom class in terms of
 819         forward_scope_exit.
 820
 821 2019-01-23  Pedro Alves  <palves@redhat.com>
 822             Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * common/forward-scope-exit.h: New file.
 825
 826 2019-01-23  Pedro Alves  <palves@redhat.com>
 827             Andrew Burgess  <andrew.burgess@embecosm.com>
 828             Tom Tromey  <tom@tromey.com>
 829
 830         * common/scope-exit.h: New file.
 831
 832 2019-01-23  Pedro Alves  <palves@redhat.com>
 833
 834         * common/preprocessor.h (ESC): Rename to ...
 835         (ESC_PARENS): ... this.
 836         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 837         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 838
 839 2019-01-23  Tom Tromey  <tom@tromey.com>
 840
 841         * language.h (class scoped_switch_to_sym_language_if_auto):
 842         Initialize m_lang in both cases.
 843
 844 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 845
 846         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 847         with XCNEW.
 848
 849 2019-01-22  Tom Tromey  <tom@tromey.com>
 850
 851         * corelow.c: Do not include sys/file.h.
 852
 853 2019-01-22  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-wingeneral.h: Include gdb_curses.h.
 856
 857 2019-01-22  Tom Tromey  <tom@tromey.com>
 858
 859         * source-cache.h (class source_cache) <get_source_lines,
 860         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 861
 862 2019-01-22  Tom Tromey  <tom@tromey.com>
 863
 864         * remote-fileio.h (struct remote_target): Declare.
 865
 866 2019-01-22  Tom Tromey  <tom@tromey.com>
 867
 868         * python/py-arch.c: Do not include py-ref.h.
 869         * python/py-bpevent.c: Do not include py-ref.h.
 870         * python/py-cmd.c: Do not include py-ref.h.
 871         * python/py-continueevent.c: Do not include py-ref.h.
 872         * python/py-event.h: Do not include py-ref.h.
 873         * python/py-evtregistry.c: Do not include py-ref.h.
 874         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 875         * python/py-frame.c: Do not include py-ref.h.
 876         * python/py-framefilter.c: Do not include py-ref.h.
 877         * python/py-function.c: Do not include py-ref.h.
 878         * python/py-infevents.c: Do not include py-ref.h.
 879         * python/py-linetable.c: Do not include py-ref.h.
 880         * python/py-objfile.c: Do not include py-ref.h.
 881         * python/py-param.c: Do not include py-ref.h.
 882         * python/py-prettyprint.c: Do not include py-ref.h.
 883         * python/py-progspace.c: Do not include py-ref.h.
 884         * python/py-symbol.c: Do not include py-ref.h.
 885         * python/py-symtab.c: Do not include py-ref.h.
 886         * python/py-type.c: Do not include py-ref.h.
 887         * python/py-unwind.c: Do not include py-ref.h.
 888         * python/py-utils.c: Do not include py-ref.h.
 889         * python/py-value.c: Do not include py-ref.h.
 890         * python/py-varobj.c: Do not include py-ref.h.
 891         * python/py-xmethods.c: Do not include py-ref.h.
 892         * python/python.c: Do not include py-ref.h.
 893         * varobj.c: Do not include py-ref.h.
 894
 895 2019-01-22  Tom Tromey  <tom@tromey.com>
 896
 897         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 898         keyword for bcache.
 899
 900 2019-01-22  Tom Tromey  <tom@tromey.com>
 901
 902         * compile/compile-cplus-types.c: Remove a comment by #include.
 903
 904 2019-01-22  Tom Tromey  <tom@tromey.com>
 905
 906         * compile/gcc-c-plugin.h: Include compile-internal.h.
 907
 908 2019-01-22  Tom Tromey  <tom@tromey.com>
 909
 910         * stabsread.c (EXTERN): Do not define.
 911         (symnum, next_symbol_text_func, processing_gcc_compilation)
 912         (within_function, global_sym_chain, global_stabs)
 913         (previous_stab_code, this_object_header_files)
 914         (n_this_object_header_files)
 915         (n_allocated_this_object_header_files): Define.
 916         * stabsread.h (EXTERN): Never define.  Use "extern".
 917
 918 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 919
 920         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 921         history_value.
 922
 923 2019-01-21  Tom Tromey  <tom@tromey.com>
 924
 925         * ui-out.c: Fix includes.
 926         * tui/tui-source.c: Fix includes.
 927         * target.c: Fix includes.
 928         * remote.c: Fix includes.
 929         * regcache.c: Fix includes.
 930         * python/py-block.c: Fix includes.
 931         * printcmd.c: Fix includes.
 932         * or1k-tdep.c: Fix includes.
 933         * mi/mi-main.c: Fix includes.
 934         * m32r-tdep.c: Fix includes.
 935         * csky-tdep.c: Fix includes.
 936         * compile/compile-cplus-types.c: Fix includes.
 937         * cli/cli-interp.c: Fix includes.
 938
 939 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 940
 941         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 942         for padding.
 943
 944 2019-01-16  Tom Tromey  <tom@tromey.com>
 945
 946         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 947         earlier.
 948         (struct objfile) <msymbols_range>: Move from top level.
 949         <msymbols>: New method.
 950         (class objfile_msymbols): Remove.
 951         * symtab.c (default_collect_symbol_completion_matches_break_on):
 952         Update.
 953         * symmisc.c (dump_msymbols): Update.
 954         * stabsread.c (scan_file_globals): Update.
 955         * objc-lang.c (info_selectors_command, info_classes_command)
 956         (find_methods): Update.
 957         * minsyms.c (find_solib_trampoline_target): Update.
 958         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 959         * coffread.c (coff_symfile_read): Update.
 960         * ada-lang.c (ada_lookup_simple_minsym)
 961         (ada_collect_symbol_completion_matches): Update.
 962
 963 2019-01-16  Tom Tromey  <tom@tromey.com>
 964
 965         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 966         type.  Remove no-argument constructor.
 967         <iterator::operator++>: Simplify.
 968         <begin>: Update.
 969         <end>: Use minimal_symbol_count.
 970
 971 2019-01-16  Tom Tromey  <tom@tromey.com>
 972
 973         * objfiles.h (struct objfile) <psymtabs>: New method.
 974         (class objfile_psymtabs): Remove.
 975         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 976         typedef.
 977         <range>: New method.
 978         (require_partial_symbols): Change return type.
 979         * psymtab.c (require_partial_symbols)
 980         (psym_expand_symtabs_matching): Update.
 981         * mdebugread.c (parse_partial_symbols): Update.
 982         * dbxread.c (dbx_end_psymtab): Update.
 983
 984 2019-01-15  Tom Tromey  <tom@tromey.com>
 985
 986         * symtab.c (lookup_objfile_from_block)
 987         (lookup_symbol_in_objfile_symtabs)
 988         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 989         (find_line_symtab, info_sources_command)
 990         (default_collect_symbol_completion_matches_break_on)
 991         (make_source_files_completion_list): Update.
 992         * symmisc.c (print_objfile_statistics, dump_objfile)
 993         (maintenance_print_symbols, maintenance_info_symtabs)
 994         (maintenance_check_symtabs, maintenance_info_line_tables):
 995         Update.
 996         * source.c (select_source_symtab)
 997         (forget_cached_source_info_for_objfile): Update.
 998         * objfiles.h (class objfile_compunits): Remove.
 999         (struct objfile) <compunits_range>: New typedef.
1000         (compunits): New method.
1001         * objfiles.c (objfile_relocate1): Update.
1002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1003         * maint.c (count_symtabs_and_blocks): Update.
1004         * linespec.c (iterate_over_all_matching_symtabs): Update.
1005         * cp-support.c (add_symbol_overload_list_qualified): Update.
1006         * coffread.c (coff_symtab_read): Update.
1007         * ada-lang.c (add_nonlocal_symbols)
1008         (ada_collect_symbol_completion_matches)
1009         (ada_add_global_exceptions): Update.
1010
1011 2019-01-15  Tom Tromey  <tom@tromey.com>
1012
1013         * progspace.h (program_space) <objfiles_safe_range>: New
1014         typedef.
1015         <objfiles_safe>: New method.
1016         * objfiles.h (class all_objfiles_safe): Remove.
1017         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1018         * jit.c (jit_inferior_exit_hook): Update.
1019
1020 2019-01-17  Tom Tromey  <tom@tromey.com>
1021
1022         * progspace.h (program_space) <objfiles_range>: New typedef.
1023         <objfiles>: New method.
1024         <objfiles_head>: Rename from objfiles.
1025         (object_files): Update.
1026         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1027         * guile/scm-pretty-print.c
1028         (ppscm_find_pretty_printer_from_objfiles): Update.
1029         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1030         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1031         Update.
1032         * python/py-progspace.c (pspy_get_objfiles): Update.
1033         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1034         Update.
1035         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1036         (objfpy_lookup_objfile_by_build_id): Update.
1037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1038         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1039         Update.
1040         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1041         (expand_symtab_containing_pc, lookup_objfile_from_block)
1042         (lookup_static_symbol, basic_lookup_transparent_type)
1043         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1044         (find_line_symtab, info_sources_command)
1045         (default_collect_symbol_completion_matches_break_on)
1046         (make_source_files_completion_list, find_main_name): Update.
1047         * symmisc.c (print_symbol_bcache_statistics)
1048         (print_objfile_statistics, maintenance_print_symbols)
1049         (maintenance_print_msymbols, maintenance_print_objfiles)
1050         (maintenance_info_symtabs, maintenance_check_symtabs)
1051         (maintenance_expand_symtabs, maintenance_info_line_tables):
1052         Update.
1053         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1054         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1055         (map_overlay_command, unmap_overlay_command)
1056         (simple_overlay_update, expand_symtabs_matching)
1057         (map_symbol_filenames): Update.
1058         * symfile-debug.c (set_debug_symfile): Update.
1059         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1060         Update.
1061         * source.c (select_source_symtab, forget_cached_source_info):
1062         Update.
1063         * solib.c (solib_read_symbols): Update.
1064         * solib-spu.c (append_ocl_sos): Update.
1065         * psymtab.c (maintenance_print_psymbols)
1066         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1067         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1068         * printcmd.c (info_symbol_command): Update.
1069         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1070         Update.
1071         * objfiles.h (class all_objfiles): Remove.
1072         * objfiles.c (have_partial_symbols, have_full_symbols)
1073         (have_minimal_symbols, qsort_cmp, update_section_map)
1074         (shared_objfile_contains_address_p)
1075         (default_iterate_over_objfiles_in_search_order): Update.
1076         * objc-lang.c (info_selectors_command, info_classes_command)
1077         (find_methods): Update.
1078         * minsyms.c (find_solib_trampoline_target): Update.
1079         * maint.c (maintenance_info_sections)
1080         (maintenance_translate_address, count_symtabs_and_blocks):
1081         Update.
1082         * main.c (captured_main_1): Update.
1083         * linux-thread-db.c (try_thread_db_load_from_pdir)
1084         (has_libpthread): Update.
1085         * linespec.c (iterate_over_all_matching_symtabs)
1086         (search_minsyms_for_name): Update.
1087         * jit.c (jit_find_objf_with_entry_addr): Update.
1088         * hppa-tdep.c (find_unwind_entry)
1089         (hppa_lookup_stub_minimal_symbol): Update.
1090         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1091         Update.
1092         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1093         (elf_gnu_ifunc_resolve_by_got): Update.
1094         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1095         * dwarf-index-write.c (save_gdb_index_command): Update.
1096         * cp-support.c (add_symbol_overload_list_qualified): Update.
1097         * breakpoint.c (create_overlay_event_breakpoint)
1098         (create_longjmp_master_breakpoint)
1099         (create_std_terminate_master_breakpoint)
1100         (create_exception_master_breakpoint): Update.
1101         * blockframe.c (find_pc_partial_function): Update.
1102         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1103         (ada_collect_symbol_completion_matches)
1104         (ada_add_global_exceptions): Update.
1105
1106 2019-01-17  Tom Tromey  <tom@tromey.com>
1107
1108         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1109         declare VEC.
1110         (solib_target_parse_libraries): Change return type.
1111         (library_list_start_segment, library_list_start_section)
1112         (library_list_end_library, library_list_start_library); Update.
1113         (solib_target_free_library_list): Remove.
1114         (solib_target_parse_libraries): Remove cleanup.  Change return
1115         type.
1116         (solib_target_current_sos): Update.
1117
1118 2019-01-17  Tom Tromey  <tromey@bapiya>
1119
1120         * valprint.c: Replace "the the" with "the".
1121         * symtab.c: Replace "the the" with "the".
1122         * solib.c: Replace "the the" with "the".
1123         * solib-dsbt.c: Replace "the the" with "the".
1124         * linespec.c: Replace "the the" with "the".
1125         * dwarf2loc.h: Replace "the the" with "the".
1126         * amd64-windows-tdep.c: Replace "the the" with "the".
1127         * aarch64-tdep.c: Replace "the the" with "the".
1128
1129 2019-01-16  Keith Seitz  <keiths@redhat.com>
1130
1131         PR gdb/23773
1132         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1133         <builder>: Rename to ..
1134         <m_builder>: ... this and make private.
1135         (dwarf2_cu::get_builder): New method.  Change all users of
1136         `builder' to use this method.
1137         (dwarf2_start_symtab): Move to ...
1138         (dwarf2_cu::start_symtab): ... here.  Update all callers
1139         (setup_type_unit_groups): Move to ...
1140         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1141         callers.
1142         (dwarf2_cu::reset_builder): New method.
1143         (process_full_compunit, process_full_type_unit): Use
1144         dwarf2_cu::reset_builder.
1145         (follow_die_offset): Record the ancestor CU if it is different
1146         from the followed DIE's CU.
1147         (follow_die_sig_1): Likewise.
1148
1149 2019-01-15  Tom Tromey  <tom@tromey.com>
1150
1151         * remote.c (class remote_state) <buf>: Now a char_vector.
1152         <buf_size>: Remove.
1153         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1154         parameter.
1155         (remote_target::getpkt_or_notif_sane_1)
1156         (remote_target::getpkt_sane)
1157         (remote_target::getpkt_or_notif_sane): Likewise.
1158         (class remote_target) <putpkt>: New overload.
1159         (remote_target::read_frame): Change type of "buf_p".  Remove
1160         sizeof_p parameter.
1161         (packet_ok): New overload.
1162         (packet_check_result): New overload.
1163         Update all uses.
1164
1165 2019-01-14  Tom Tromey  <tom@tromey.com>
1166
1167         * remote-notif.c (handle_notification, remote_notif_ack)
1168         (remote_notif_parse): Make "buf" const.
1169         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1170         const.
1171         (remote_notif_parse, remote_notif_ack, handle_notification):
1172         Likewise.
1173         * remote.c (remote_notif_stop_parse): Make "buf" const.
1174         (remote_target::remote_parse_stop_reply): Make "buf" const.
1175         (remote_notif_stop_ack): Make "buf" const.
1176
1177 2019-01-14  Tom Tromey  <tom@tromey.com>
1178
1179         * remote.c (remote_console_output): Make parameter const.
1180
1181 2019-01-14  Tom Tromey  <tom@tromey.com>
1182
1183         * target-debug.h (target_debug_print_signals): Constify.
1184         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1185         * procfs.c (procfs_target::pass_signals): Update.
1186         * linux-nat.c (linux_nat_target::pass_signals): Update.
1187         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1188         * target-delegates.c: Rebuild.
1189         * remote.c (remote_target::program_signals): Update.
1190         (remote_target::pass_signals): Update.
1191         * target.c (target_pass_signals): Constify argument.
1192         (target_program_signals): Likewise.
1193         * target.h (struct target_ops) <pass_signals, program_signals>:
1194         Constify argument.
1195         (target_pass_signals, target_program_signals): Constify argument.
1196
1197 2019-01-14  Tom Tromey  <tom@tromey.com>
1198
1199         PR tui/28819:
1200         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1201
1202 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1203
1204         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1205         field.
1206         * rs6000-tdep.c: Include reggroups.h.
1207         (IS_V_ALIAS_PSEUDOREG): Define.
1208         (rs6000_register_name): Return names for the "vX" aliases.
1209         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1210         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1211         aliases.  Call default_register_reggroup_p for all other
1212         pseudo-registers.
1213         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1214         New functions.
1215         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1216         Handle "vX" aliases.
1217         (v_alias_pseudo_register_collect): New function.
1218         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1219         (rs6000_gdbarch_init): Initialize "vX" aliases as
1220         pseudo-registers.  Restore registration of
1221         rs6000_pseudo_register_reggroup_p with
1222         set_tdesc_pseudo_register_reggroup_p.
1223
1224 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1225
1226         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1227         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1228         set_gdbarch_num_pseudo_regs.
1229
1230 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1231
1232         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1233         Remove arg prefixname, add do_set and do_show.
1234         Add member functions set_list and show_list.
1235         * cli/cli-style.c (class cli_style_option): Update accordingly.
1236         (style_set_list): Move to file scope.
1237         (style_show_list): Likewise.
1238         (set_style): Call help_list.
1239         (show_style): Call cmd_show_list.
1240         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1241         Update to use the new macro.
1242
1243 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1244
1245         * ada-lang.c (_initialize_ada_language): Expand the help text
1246         for the "catch exception" command.
1247
1248 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1249
1250         * symtab.c (matching_obj_sections): Initialize obj,
1251         declare it closer to its usage.
1252
1253 2019-01-10  Tom Tromey  <tom@tromey.com>
1254
1255         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1256         (basic_inf_threads_range): Remove.
1257         (inf_threads_range, inf_non_exited_threads_range)
1258         (safe_inf_threads_range): Use next_adapter.
1259
1260 2019-01-10  Keith Seitz  <keiths@redhat.com>
1261
1262         PR gdb/23712
1263         PR symtab/23010
1264         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1265         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1266
1267 2019-01-10  Keith Seitz  <keiths@redhat.com>
1268
1269         PR gdb/23712
1270         PR symtab/23010
1271         * dictionary.c (pending_to_vector): Remove.
1272         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1273         Remove _1 suffix, replacing functions of the same name.  Update
1274         all callers.
1275         (dict_create_hashed, dict_create_hashed_expandable)
1276         (dict_create_linear, dict_create_linear_expandable, dict_free)
1277         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1278         Make functions static.
1279
1280 2019-01-10  Keith Seitz  <keiths@redhat.com>
1281
1282         PR gdb/23712
1283         PR symtab/23010
1284         * dictionary.h (struct dictionary): Replace declaration with
1285         multidictionary.
1286         (dict_create_hashed, dict_create_hashed_expandable)
1287         (dict_create_linear, dict_create_linear_expandable)
1288         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1289         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1290         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1291         taking multidictionary argument.
1292         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1293         * block.h (struct block) <dict>: Change to multidictionary
1294         and rename `multidict'.
1295         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1296         symmisc.c: Update all dictionary references to multidictionary.
1297
1298 2019-01-10  Keith Seitz  <keiths@redhat.com>
1299
1300         PR gdb/23712
1301         PR symtab/23010
1302         * dictionary.c: Include unordered_map.
1303         (pending_to_vector): New function.
1304         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1305         Rewrite the non-"_1" functions to take vector instead
1306         of linked list.
1307         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1308         "new" _1 versions of the same name.
1309         (multidictionary): Define.
1310         (std::hash<enum language): New definition.
1311         (collate_pending_symbols_by_language, mdict_create_hashed)
1312         (mdict_create_hashed_expandable, mdict_create_linear)
1313         (mdict_create_linear_expandable, mdict_free)
1314         (find_language_dictionary, create_new_language_dictionary)
1315         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1316         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1317         (mdict_size, mdict_empty): New functions.
1318         * dictionary.h (mdict_iterator): Define.
1319
1320 2019-01-10  Pedro Alves  <palves@redhat.com>
1321
1322         * breakpoint.c (read_uploaded_action)
1323         (create_tracepoint_from_upload): Adjust to use
1324         gdb::unique_xmalloc_ptr.
1325         * ctf.c (ctf_write_uploaded_tp):
1326         (SET_ARRAY_FIELD): Use emplace_back.
1327         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1328         * tracefile-tfile.c (tfile_write_uploaded_tp):
1329         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1330         gdb::unique_xmalloc_ptr.
1331         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1332         at_string, cond_string, cmd_strings>: Replace char pointers
1333         with gdb::unique_xmalloc_ptr.
1334
1335 2019-01-10  Pedro Alves  <palves@redhat.com>
1336
1337         * solib-target.c (library_list_start_library): Don't xstrdup name.
1338
1339 2019-01-10  Pedro Alves  <palves@redhat.com>
1340
1341         * mdebugread.c (parse_partial_symbols): Use
1342         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1343
1344 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * linux-fork.c (scoped_switch_fork_info)
1347         <~scoped_switch_fork_info>: Fix incorrect variable name.
1348
1349 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * linux-fork.c (scoped_switch_fork_info)
1352         <scoped_switch_fork_info>: Make explicit.
1353         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1354
1355 2019-01-10  Tom Tromey  <tom@tromey.com>
1356
1357         * objfiles.h (objfile::reset_psymtabs): Update.
1358         * objfiles.c (objfile::objfile): Update.
1359         * psymtab.h (psymtab_storage::obstack): Update.
1360         (psymtab_storage::m_obstack): Use gdb::optional.
1361         (class psymtab_storage): Update comment.  Remove objfile
1362         parameter.
1363         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1364
1365 2019-01-10  Tom Tromey  <tom@tromey.com>
1366
1367         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1368         <free_psymtabs>: Now private.
1369         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1370         (allocate_psymtab): Use new method.
1371
1372 2019-01-10  Tom Tromey  <tom@tromey.com>
1373
1374         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1375         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1376         * mdebugread.c (parse_partial_symbols): Use
1377         allocate_dependencies.
1378         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1379         allocate_dependencies.
1380         (process_psymtab_comp_unit_reader)
1381         (build_type_psymtab_dependencies): Likewise.
1382         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1383
1384 2019-01-10  Tom Tromey  <tom@tromey.com>
1385
1386         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1387         PSYMBOL_SET_LANGUAGE.
1388         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1389
1390 2019-01-10  Tom Tromey  <tom@tromey.com>
1391
1392         * psymtab.h (psymtab_storage::obstack): New method.
1393         <m_obstack>: Rename from obstack; now private.
1394         * psymtab.c (psymtab_storage): Update.
1395         * dwarf2read.c (create_addrmap_from_index)
1396         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1397         Update.
1398
1399 2019-01-10  Tom Tromey  <tom@tromey.com>
1400
1401         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1402         * objfiles.h (objfile::reset_psymtabs): New method.
1403
1404 2019-01-10  Tom Tromey  <tom@tromey.com>
1405
1406         * symmisc.c (print_symbol_bcache_statistics): Update.
1407         (print_objfile_statistics): Update.
1408         * symfile.c (reread_symbols): Update.
1409         * psymtab.h (class psymtab_storage): New.
1410         * psymtab.c (psymtab_storage): New constructor.
1411         (~psymtab_storage): New destructor.
1412         (require_partial_symbols): Update.
1413         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1414         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1415         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1416         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1417         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1418         (start_psymtab_common, end_psymtab_common)
1419         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1420         (allocate_psymtab): Update.
1421         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1422         Update.
1423         (dump_psymtab_addrmap, maintenance_print_psymbols)
1424         (maintenance_check_psymtabs): Update.
1425         (class objfile_psymtabs): Move to objfiles.h.
1426         * psympriv.h (discard_psymtab): Now inline.
1427         (psymtab_discarder::psymtab_discarder): Update.
1428         (psymtab_discarder::~psymtab_discarder): Update.
1429         (ALL_OBJFILE_PSYMTABS): Rewrite.
1430         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1431         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1432         Remove fields.
1433         <partial_symtabs>: New field.
1434         (class objfile_psymtabs): Move from psymtab.h.  Update.
1435         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1436         psymbol_cache.
1437         (objfile::~objfile): Don't destroy psymbol_cache.
1438         * mdebugread.c (parse_partial_symbols): Update.
1439         * dwarf2read.c (create_addrmap_from_index)
1440         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1441         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1442         (add_partial_subprogram, dwarf2_ranges_read): Update.
1443         * dwarf-index-write.c (write_address_map)
1444         (write_one_signatured_type, recursively_write_psymbols)
1445         (class debug_names, class debug_names, write_psymtabs_to_index):
1446         Update.
1447
1448 2019-01-10  Tom Tromey  <tom@tromey.com>
1449
1450         * symtab.h (SYMBOL_SET_NAMES): Update.
1451         (symbol_set_names): Update.
1452         (MSYMBOL_SET_NAMES): Update.
1453         * symtab.c (symbol_set_names): Change argument to be an
1454         objfile_per_bfd_storage.
1455         * psymtab.c (add_psymbol_to_bcache): Update.
1456         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1457
1458 2019-01-10  Tom Tromey  <tom@tromey.com>
1459
1460         * symtab.c (create_demangled_names_hash): Change argument to be an
1461         objfile_per_bfd_storage.
1462         (symbol_set_names): Update.
1463
1464 2019-01-10  Tom Tromey  <tom@tromey.com>
1465
1466         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1467         init_psymbol_list.
1468         * psymtab.c (init_psymbol_list): Do nothing if already called.
1469         * psympriv.h (init_psymbol_list): Add comment.
1470         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1471         init_psymbol_list.
1472         * dbxread.c (dbx_symfile_read): Unconditionally call
1473         init_psymbol_list.
1474
1475 2019-01-10  Tom Tromey  <tom@tromey.com>
1476
1477         * xcoffread.c (scan_xcoff_symtab): Update.
1478         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1479         "where".
1480         * mdebugread.c (parse_partial_symbols)
1481         (handle_psymbol_enumerators): Update.
1482         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1483         * dbxread.c (read_dbx_symtab): Update.
1484         * psympriv.h (psymbol_placement): New enum.
1485         (add_psymbol_to_list): Update.
1486
1487 2019-01-10  Tom Tromey  <tom@tromey.com>
1488
1489         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1490         static_psymbols parameters.
1491         (scan_xcoff_symtab): Update.
1492         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1493         static_psymbols parameters.
1494         * psympriv.h (start_psymtab_common): Update.
1495         * mdebugread.c (parse_partial_symbols): Update.
1496         * dwarf2read.c (create_partial_symtab): Update.
1497         * dbxread.c (read_dbx_symtab): Update.
1498         (start_psymtab): Remove global_psymbols and static_psymbols
1499         parameters.
1500
1501 2019-01-10  Tom Tromey  <tom@tromey.com>
1502
1503         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1504         * psymtab.c (allocate_psymtab): Add comment.
1505         * psympriv.h (allocate_psymtab): Add comment.
1506         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1507         initializations.
1508         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1509
1510 2019-01-10  Tom Tromey  <tom@tromey.com>
1511
1512         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1513         Don't declare.
1514         * mipsread.c: Include mdebugread.h.
1515         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1516         Declare.
1517         * elfread.c: Include mdebugread.h.
1518
1519 2019-01-09  Tom Tromey  <tom@tromey.com>
1520
1521         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1522         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1523         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1524         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1525         (psym_lookup_symbol, psym_find_last_source_symtab)
1526         (psym_forget_cached_source_info, psym_print_stats)
1527         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1528         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1529         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1530         (psym_find_compunit_symtab_by_address)
1531         (maintenance_print_psymbols, maintenance_info_psymtabs)
1532         (maintenance_check_psymtabs): Use ranged for.
1533         * psymtab.h (class objfile_psymtabs): New.
1534         (require_partial_symbols): Return objfile_psymtabs.
1535         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1536
1537 2019-01-09  Tom Tromey  <tom@tromey.com>
1538
1539         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1540         (find_pc_mapped_section, list_overlays_command)
1541         (map_overlay_command, unmap_overlay_command)
1542         (simple_overlay_update): Use all_objfiles.
1543         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1544         * printcmd.c (info_symbol_command): Use all_objfiles.
1545         * objfiles.h (ALL_OBJSECTIONS): Remove.
1546         * maint.c (maintenance_translate_address): Use all_objfiles.
1547         * gcore.c (gcore_create_callback): Use all_objfiles.
1548         (objfile_find_memory_regions): Likewise.
1549
1550 2019-01-09  Tom Tromey  <tom@tromey.com>
1551
1552         * symtab.c (find_line_symtab, info_sources_command)
1553         (make_source_files_completion_list): Use objfile_compunits.
1554         * source.c (select_source_symtab): Use objfile_compunits.
1555         * objfiles.h (struct objfile): Update comment.
1556         (ALL_OBJFILES): Remove.
1557         (ALL_FILETABS): Remove.
1558         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1559         objfile_compunits.
1560
1561 2019-01-09  Tom Tromey  <tom@tromey.com>
1562
1563         * symmisc.c (print_objfile_statistics, dump_objfile)
1564         (maintenance_print_symbols): Use compunit_filetabs.
1565         * source.c (forget_cached_source_info_for_objfile): Use
1566         compunit_filetabs.
1567         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1568         (ALL_FILETABS): Use compunit_filetabs.
1569         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1570         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1571
1572 2019-01-09  Tom Tromey  <tom@tromey.com>
1573
1574         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1575         (compunit_filetabs): New.
1576         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1577         compunit_filetabs.
1578         (info_sources_command, make_source_files_completion_list): Remove
1579         declaration.
1580         * symmisc.c (print_objfile_statistics, dump_objfile)
1581         (maintenance_print_symbols): Remove declaration.
1582         (maintenance_info_symtabs): Use compunit_filetabs.
1583         (maintenance_info_line_tables): Likewise.
1584         * source.c (select_source_symtab): Change local variable name.
1585         (forget_cached_source_info_for_objfile): Remove declaration.
1586         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1587         * objfiles.c (objfile_relocate1): Remove declaration.
1588         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1589         declaration.
1590         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1591         * coffread.c (coff_symtab_read): Remove declaration.
1592         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1593         compunit_filetabs.
1594
1595 2019-01-09  Tom Tromey  <tom@tromey.com>
1596
1597         * symtab.c (lookup_objfile_from_block)
1598         (find_pc_sect_compunit_symtab, search_symbols)
1599         (default_collect_symbol_completion_matches_break_on): Use
1600         objfile_compunits.
1601         * objfiles.h (ALL_COMPUNITS): Remove.
1602         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1603         * cp-support.c (add_symbol_overload_list_qualified): Use
1604         objfile_compunits.
1605         * ada-lang.c (ada_collect_symbol_completion_matches)
1606         (ada_add_global_exceptions): Use objfile_compunits.
1607
1608 2019-01-09  Tom Tromey  <tom@tromey.com>
1609
1610         * source.c (select_source_symtab)
1611         (forget_cached_source_info_for_objfile): Remove declaration.
1612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1613         declaration.
1614         * maint.c (count_symtabs_and_blocks): Remove declaration.
1615         * cp-support.c (add_symbol_overload_list_qualified): Remove
1616         declaration.
1617         * coffread.c (coff_symtab_read): Remove declaration.
1618         * symtab.c (lookup_symbol_in_objfile_symtabs)
1619         (basic_lookup_transparent_type_1): Use objfile_compunits.
1620         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1621         (info_sources_command, search_symbols)
1622         (default_collect_symbol_completion_matches_break_on)
1623         (make_source_files_completion_list): Remove declaration.
1624         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1625         (ada_collect_symbol_completion_matches)
1626         (ada_add_global_exceptions): Remove declaration.
1627         * linespec.c (iterate_over_all_matching_symtabs): Use
1628         objfile_compunits.
1629         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1630         (class objfile_compunits): New.
1631         (ALL_COMPUNITS): Use objfile_compunits.
1632         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1633         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1634         objfile_compunits.
1635         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1636
1637 2019-01-09  Tom Tromey  <tom@tromey.com>
1638
1639         * symtab.c (search_symbols)
1640         (default_collect_symbol_completion_matches_break_on): Use
1641         objfile_msymbols.
1642         * ada-lang.c (ada_lookup_simple_minsym)
1643         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1644         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1645         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1646         objfile_msymbols.
1647         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1648         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1649         * objc-lang.c (find_methods): Use objfile_msymbols.
1650         (info_selectors_command, info_classes_command): Likewise.
1651         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1652         * objfiles.h (class objfile_msymbols): New.
1653         (ALL_OBJFILE_MSYMBOLS): Remove.
1654         (ALL_MSYMBOLS): Remove.
1655
1656 2019-01-09  Tom Tromey  <tom@tromey.com>
1657
1658         * common/next-iterator.h (next_adapter): Add Iterator template
1659         parameter.
1660         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1661         (class all_objfiles_safe): New.
1662         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1663         * objfiles.c (put_objfile_before): Update comment.
1664         (add_separate_debug_objfile): Likewise.
1665         (free_all_objfiles): Use all_objfiles_safe.
1666         (objfile_purge_solibs): Likewise.
1667
1668 2019-01-09  Tom Tromey  <tom@tromey.com>
1669
1670         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1671         (expand_symtab_containing_pc, lookup_static_symbol)
1672         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1673         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1674         all_objfiles.
1675         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1676         * breakpoint.c (create_overlay_event_breakpoint)
1677         (create_longjmp_master_breakpoint)
1678         (create_std_terminate_master_breakpoint)
1679         (create_exception_master_breakpoint): Use all_objfiles.
1680         * linux-thread-db.c (try_thread_db_load_from_pdir)
1681         (has_libpthread): Use all_objfiles.
1682         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1683         * linespec.c (iterate_over_all_matching_symtabs)
1684         (search_minsyms_for_name): Use all_objfiles.
1685         * maint.c (maintenance_info_sections): Use all_objfiles.
1686         * main.c (captured_main_1): Use all_objfiles.
1687         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1688         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1689         * guile/scm-pretty-print.c
1690         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1691         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1692         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1693         (maintenance_print_msymbols): Use all_objfiles.
1694         * source.c (select_source_symtab): Use all_objfiles.
1695         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1696         * symfile.c (remove_symbol_file_command)
1697         (expand_symtabs_matching, map_symbol_filenames): Use
1698         all_objfiles.
1699         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1700         all_objfiles.
1701         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1702         * objc-lang.c (find_methods): Use all_objfiles.
1703         * objfiles.c (have_partial_symbols, have_full_symbols)
1704         (have_minimal_symbols, qsort_cmp)
1705         (default_iterate_over_objfiles_in_search_order): Use
1706         all_objfiles.
1707         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1708         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1709         (maintenance_check_psymtabs): Use all_objfiles.
1710         (ALL_PSYMTABS): Remove.
1711         * compile/compile-object-run.c (do_module_cleanup): Use
1712         all_objfiles.
1713         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1714         * cp-support.c (add_symbol_overload_list_qualified): Use
1715         all_objfiles.
1716         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1717         Use all_objfiles.
1718         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1719         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1720         all_objfiles.
1721         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1722         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1723         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1724         Uses all_objfiles.
1725         * solib.c (solib_read_symbols): Use all_objfiles
1726
1727 2019-01-09  Tom Tromey  <tom@tromey.com>
1728
1729         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1730         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1731         all_objfiles.
1732         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1733         * symmisc.c (print_symbol_bcache_statistics)
1734         (print_objfile_statistics, maintenance_print_objfiles)
1735         (maintenance_info_symtabs, maintenance_check_symtabs)
1736         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1737         all_objfiles.
1738         * source.c (forget_cached_source_info): Use all_objfiles.
1739         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1740         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1741         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1742         * objfiles.c (update_section_map): Use all_objfiles.
1743         (shared_objfile_contains_address_p): Likewise.
1744         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1745         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1746
1747 2019-01-09  Tom Tromey  <tom@tromey.com>
1748
1749         * common/next-iterator.h: New file.
1750         * objfiles.h (class all_objfiles): New.
1751         (struct objfile_iterator): New.
1752
1753 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1754
1755         * NEWS: Move the description of the changed "frame", "select-frame",
1756          and "info frame" commands to the Changed commands section.
1757
1758 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1759
1760         * gdbtypes.c (check_stub_method_group): Remove handling of old
1761         mangling schemes.
1762         * linespec.c (find_methods): Likewise.
1763         * stabsread.c (read_member_functions): Likewise.
1764         * valops.c (search_struct_method): Likewise.
1765         (value_struct_elt_for_reference): Likewise.
1766         * NEWS: Mention this change.
1767
1768 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1771         print_source_lines.
1772         * source.c (print_source_lines_base): Update line number check.
1773         (print_source_lines): New function.
1774         (source_lines_range::source_lines_range): New function.
1775         * source.h (class source_lines_range): New class.
1776         (print_source_lines): New declaration.
1777
1778 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1779
1780         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1781
1782 2019-01-08  Tom Tromey  <tom@tromey.com>
1783             Simon Marchi  <simon.marchi@ericsson.com>
1784
1785         PR gdb/24060
1786         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1787         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1788         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1789         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1790         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1791         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1792
1793 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * source.c (select_source_symtab): Move header comment to
1796         declaration in source.h.
1797         (forget_cached_source_info_for_objfile): Likewise.
1798         (forget_cached_source_info): Likewise.
1799         (identify_source_line): Likewise.
1800         * source.h (identify_source_line): Move declaration from symtab.h
1801         and add comment from source.c
1802         (print_source_lines): Likewise.
1803         (forget_cached_source_info_for_objfile): Likewise.
1804         (forget_cached_source_info): Likewise.
1805         (select_source_symtab): Likewise.
1806         (enum print_source_lines_flag): Move definition from symtab.h.
1807         * symtab.h (identify_source_line): Move declaration to source.h.
1808         (print_source_lines): Likewise.
1809         (forget_cached_source_info_for_objfile): Likewise.
1810         (forget_cached_source_info): Likewise.
1811         (select_source_symtab): Likewise.
1812         (enum print_source_lines_flag): Move definition to source.h.
1813         * tui/tui-hooks.c: Add 'source.h' include.
1814
1815 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1816
1817         * source.c (print_source_lines_base): Handle requests to print
1818         reverse line number sequences, and guard against empty lines
1819         string.
1820
1821 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1822
1823         * source.c (print_source_lines_base): Fix skip of '\r' if next
1824         character is '\n'.
1825
1826 2019-01-06  Tom Tromey  <tom@tromey.com>
1827
1828         * c-exp.y (struct c_parse_state) <macro_original_text,
1829         expansion_obstack>: New member.
1830         (macro_original_text, expansion_obstack): Remove globals.
1831         (scan_macro_expansion, scanning_macro_expansion)
1832         (finished_macro_expansion): Update.
1833         (scan_macro_cleanup): Remove.
1834         (yylex, c_parse): Update.
1835
1836 2019-01-06  Tom Tromey  <tom@tromey.com>
1837
1838         * c-exp.y (struct c_parse_state) <strings>: New member.
1839         (operator_stoken): Update.
1840
1841 2019-01-06  Tom Tromey  <tom@tromey.com>
1842
1843         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1844         (union type_stack_elt) <typelist_val>: Now a pointer to
1845         std::vector.
1846         (type_stack_cleanup): Don't declare.
1847         (push_typelist): Update.
1848         * parse.c (pop_typelist): Return a std::vector.
1849         (push_typelist): Take a std::vector.
1850         (follow_types): Update.  Do not free args.
1851         (type_stack_cleanup): Remove.
1852         * c-exp.y (struct c_parse_state): New.
1853         (cpstate): New global.
1854         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1855         (nonempty_typelist): Update.
1856         (func_mod): Create a new vector.
1857         (c_parse): Create a c_parse_state.
1858         (check_parameter_typelist): Do not delete params.
1859         (function_method): Update.  Do not delete type_list.
1860
1861 2019-01-06  Tom Tromey  <tom@tromey.com>
1862
1863         PR gdb/28155:
1864         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1865         check_typedef.
1866         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1867         (print_return_value): Likewise.
1868
1869 2019-01-05  Tom Tromey  <tom@tromey.com>
1870
1871         * contrib/cleanup_check.py: Remove.
1872         * contrib/gcc-with-excheck: Remove.
1873         * contrib/exsummary.py: Remove.
1874         * contrib/excheck.py: Remove.
1875
1876 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1877
1878         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1879         NULL. Initialize tpprev to NULL instead of assigning it
1880         to NULL on the next statement.
1881         * windows-nat.c (windows_delete_thread): Remove check for
1882         main_thread_id before printing thread exit notifications.
1883         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1884         Remove thread ID check against main_thread_id.
1885         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1886         windows_delete_thread.
1887         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1888
1889 2019-01-04  Tom Tromey  <tom@tromey.com>
1890
1891         * compile/compile.c (_initialize_compile): Use upper case for
1892         metasyntactic variables.
1893         * symmisc.c (_initialize_symmisc): Use upper case for
1894         metasyntactic variables.
1895         * psymtab.c (_initialize_psymtab): Use upper case for
1896         metasyntactic variables.
1897         * demangle.c (demangle_command): Use upper case for metasyntactic
1898         variables.
1899         (_initialize_demangler): Likewise.
1900         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1901         variables.
1902
1903 2019-01-03  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1906
1907 2019-01-03  Tom Tromey  <tom@tromey.com>
1908
1909         * python/py-symtab.c (salpy_str): Update.
1910         (struct salpy_sal_object) <symtab>: Now a PyObject.
1911         (salpy_dealloc): Update.
1912         (del_objfile_sal): Use gdbpy_ref.
1913
1914 2019-01-03  Tom Tromey  <tom@tromey.com>
1915
1916         * python/py-type.c (convert_field): Use new_reference.  Return
1917         gdbpy_ref.
1918         (make_fielditem): Return gdbpy_ref.
1919         (typy_fields): Update.
1920         (typy_getitem): Update.
1921         (field_name): Return gdbpy_ref.  Use new_reference.
1922         (typy_iterator_iternext): Update.
1923
1924 2019-01-03  Tom Tromey  <tom@tromey.com>
1925
1926         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1927
1928 2019-01-03  Tom Tromey  <tom@tromey.com>
1929
1930         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1931         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1932         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1933         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1934         (pspy_set_type_printers): Likewise.
1935         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1936         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1937         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1938         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1939         (objfpy_set_type_printers): Likewise.
1940
1941 2019-01-03  Tom Tromey  <tom@tromey.com>
1942
1943         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1944         (gdbpy_print_stack): Use gdbpy_err_fetch.
1945         * python/python-internal.h (class gdbpy_err_fetch): New class.
1946         (class gdbpy_enter) <m_error_type, m_error_value,
1947         m_error_traceback>: Remove.
1948         <m_error>: New member.
1949         (gdbpy_exception_to_string): Don't declare.
1950         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1951         * python/py-value.c (convert_value_from_python): Use
1952         gdbpy_err_fetch.
1953         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1954         gdbpy_exception_to_string.
1955         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1956         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1957         gdbpy_err_fetch.
1958
1959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * linux-nat.c (delete_lwp_cleanup): Delete.
1962         (struct lwp_deleter): New struct.
1963         (lwp_info_up): New typedef.
1964         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1965         lwp_info_up.
1966
1967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1968
1969         * linux-fork.c (class scoped_switch_fork_info): New class.
1970         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1971
1972 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1973
1974         * valops.c (find_overload_match): Remove use of null_cleanup, and
1975         calls to do_cleanups.
1976
1977 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1978
1979         * compile/compile-cplus-types.c
1980         (compile_cplus_instance::decl_name): Handle changes to
1981         cp_func_name.
1982         * cp-support.c (cp_func_name): Update header comment, update
1983         return type.
1984         * cp-support.h (cp_func_name): Update return type in declaration.
1985         * valops.c (find_overload_match): Move temp_func local to top
1986         level of function and change its type.  Use temp_func to hold and
1987         delete temporary string obtained from cp_func_name.
1988
1989 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1992         gdb::char_vector, remove cleanup, and update uses of `msg`.
1993
1994 2019-01-03  Jim Wilson  <jimw@sifive.com>
1995
1996         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1997
1998 2019-01-02  Tom Tromey  <tom@tromey.com>
1999
2000         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2001         (tdesc_parse_xml): Remove cleanups.
2002         * target-descriptions.h (make_cleanup_free_target_description):
2003         Don't declare.
2004         (target_desc_deleter): New struct.
2005         (target_desc_up): New typedef.
2006         * target-descriptions.c (target_desc_deleter::operator()): Rename
2007         from free_target_description.
2008         (make_cleanup_free_target_description): Remove.
2009
2010 2019-01-02  Tom Tromey  <tom@tromey.com>
2011
2012         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2013         constructor, destructor.
2014         (linespec_parser): Remove typedef.
2015         (~linespec_parser): Rename from linespec_parser_delete.
2016         (linespec_lex_to_end, linespec_complete_label)
2017         (linespec_complete): Update.
2018         (decode_line_full): Remove cleanups.
2019         (decode_line_1): Update.
2020
2021 2019-01-02  Tom Tromey  <tom@tromey.com>
2022
2023         * python/python-internal.h (inferior_to_inferior_object): Change
2024         return type.
2025         * python/py-exitedevent.c (create_exited_event_object): Update.
2026         * python/py-inferior.c (inferior_to_inferior_object): Return
2027         gdbpy_ref.
2028         (python_new_inferior, python_inferior_deleted)
2029         (thread_to_thread_object, delete_thread_object)
2030         (build_inferior_list, gdbpy_selected_inferior): Update.
2031         * python/py-infthread.c (create_thread_object): Update.  Also fail
2032         if inferior_to_inferior_object fails.
2033
2034 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2035
2036         * inferior.h (class inferior) <displaced_step_state>: New field.
2037         * infrun.h (struct displaced_step_state): Move here from
2038         infrun.c.  Initialize fields, add constructor.
2039         <inf>: Remove field.
2040         <reset>: New method.
2041         * infrun.c (struct displaced_step_inferior_state): Move to
2042         infrun.h.
2043         (displaced_step_inferior_states): Remove.
2044         (get_displaced_stepping_state): Adust.
2045         (displaced_step_in_progress_any_inferior): Adjust.
2046         (displaced_step_in_progress_thread): Adjust.
2047         (displaced_step_in_progress): Adjust.
2048         (add_displaced_stepping_state): Remove.
2049         (get_displaced_step_closure_by_addr): Adjust.
2050         (remove_displaced_stepping_state): Remove.
2051         (infrun_inferior_exit): Call displaced_step_state.reset.
2052         (use_displaced_stepping): Don't check for NULL.
2053         (displaced_step_prepare_throw): Call
2054         get_displaced_stepping_state.
2055         (displaced_step_fixup): Don't check for NULL.
2056         (prepare_for_detach): Don't check for NULL.
2057
2058 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2059
2060         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2061          in case of call that did not complete.
2062
2063 2019-01-02  Andrey Utkin  <autkin@undo.io>
2064
2065         * symfile.c (find_separate_debug_file): Fix search of debug files for
2066         remote debuggee.
2067
2068 2019-01-02  Tom Tromey  <tom@tromey.com>
2069
2070         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2071         indentation.
2072         * python/py-frame.c (frapy_older): Remove cast.
2073         (frapy_newer): Likewise.
2074         * python/py-breakpoint.c (local_setattro): Remove cast.
2075         * python/py-arch.c (archpy_name): Remove local variable.
2076         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2077
2078 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2079
2080         * unittests/basic_string_view/element_access/char/empty.cc:
2081         Fix year range in copyright header.
2082
2083 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2086         Delete.
2087         <operator==>: Update with for removed field.
2088         <hash>: Likewise.
2089         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2090         <isa_features>: ...this.
2091         <abi_features>: New field.
2092         (riscv_isa_flen): Update comment.
2093         (riscv_abi_xlen): New declaration.
2094         (riscv_abi_flen): New declaration.
2095         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2096         isa_features.
2097         (riscv_abi_xlen): New function.
2098         (riscv_isa_flen): Update to get answer from isa_features.
2099         (riscv_abi_flen): New function.
2100         (riscv_has_fp_abi): Update to get answer from abi_features.
2101         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2102         xlen and flen.
2103         (riscv_call_info) <xlen, flen>: Update comment.
2104         (riscv_call_arg_struct): Remove invalid assertions
2105         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2106         is removed.
2107         (riscv_gdbarch_init): Gather isa features and abi features
2108         separately, ensure both match on the gdbarch when reusing an old
2109         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2110         a target with 64-bit float hardware.
2111
2112 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2113
2114         * source.c (search_command_helper): Stop reverse search
2115         when line 1 has been searched.
2116
2117 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2118
2119         * record-full.c (record_full_base_target::close): Rewrite
2120         record_full_core_buf_list free logic.
2121
2122 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2123
2124         * break-catch-syscall.c (print_one_catch_syscall): xfree
2125         the last text.
2126
2127 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2128
2129         * top.c (print_gdb_version): Update Copyright year in version
2130         message.
2131
2132 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2133
2134         Update copyright year range in all GDB files.
2135
2136 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2137
2138         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139
2140 For older changes see ChangeLog-2018.
2141 \f
2142 Local Variables:
2143 mode: change-log
2144 left-margin: 8
2145 fill-column: 74
2146 version-control: never
2147 coding: utf-8
2148 End:
2149