gdb/ChangeLog

   1 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
   4         bool.
   5         (bpstat_what): Use false instead of 0.
   6
   7 2019-07-09  Pedro Alves  <palves@redhat.com>
   8
   9         * break-catch-throw.c (is_exception_catchpoint): New.
  10         * breakpoint.c (print_one_breakpoint_location): New parameter
  11         'raw_loc'.  Handle it.  Use
  12         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  13         looking at the breakpoint's type.
  14         (print_one_breakpoint): If handling "maint info breakpoints", also
  15         print locations of exception catchpoints.
  16         * breakpoint.h (is_exception_catchpoint): Declare.
  17
  18 2019-07-09  Pedro Alves  <palves@redhat.com>
  19
  20         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  21         "addr" field.
  22         (allocate_location_exception_catchpoint): New.
  23         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  24         (initialize_throw_catchpoint_ops): Install
  25         allocate_location_exception_catchpoint as allocate_location
  26         method.
  27         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  28         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  29         bp_loc_other.
  30         (breakpoint_address_is_meaningful): Delete.
  31         (bl_address_is_meaningful): New.
  32         (breakpoint_locations_match): Adjust comment.
  33         (bp_location_from_bp_type): New, factored out of...
  34         (bp_location::bp_location(breakpoint *)): ... this.
  35         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  36         factored out of...
  37         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  38         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  39         breakpoint_address_is_meaningful.
  40         (bp_locations_compare): Adjust comment.
  41         (update_global_location_list): Use bl_address_is_meaningful
  42         instead of breakpoint_address_is_meaningful.
  43         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  44         explicit.
  45         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  46         * python/py-breakpoint.c (bppy_get_location): No longer check
  47         whether location is null.
  48
  49 2019-07-09  Pedro Alves  <palves@redhat.com>
  50
  51         PR c++/15468
  52         * breakpoint.c (print_one_breakpoint_location): Remove
  53         single-location assert.
  54
  55 2019-07-09  Tom Tromey  <tom@tromey.com>
  56
  57         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  58         * configure: Rebuild.
  59         * configure.ac: Change common to gdbsupport.
  60         * gdbsupport: Rename from common.
  61         * acinclude.m4: Change common to gdbsupport.
  62         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  63         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  64         gdbsupport.
  65         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  66         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  67         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  68         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  69         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  70         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  71         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
  72         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
  73         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
  74         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
  75         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
  76         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
  77         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
  78         coff-pe-read.c, command.h, compile/compile-c-support.c,
  79         compile/compile-c.h, compile/compile-cplus-symbols.c,
  80         compile/compile-cplus-types.c, compile/compile-cplus.h,
  81         compile/compile-loc2c.c, compile/compile.c, completer.c,
  82         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
  83         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
  84         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
  85         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
  86         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
  87         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
  88         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
  89         features/aarch64-core.c, features/aarch64-fpu.c,
  90         features/aarch64-pauth.c, features/aarch64-sve.c,
  91         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
  92         features/i386/32bit-core.c, features/i386/32bit-linux.c,
  93         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
  94         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
  95         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
  96         features/i386/64bit-core.c, features/i386/64bit-linux.c,
  97         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
  98         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
  99         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 100         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 101         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 102         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 103         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 104         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 105         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 106         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 107         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 108         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 109         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 110         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 111         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 112         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 113         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 114         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 115         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 116         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 117         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 118         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 119         minsyms.c, mips-linux-tdep.c, namespace.h,
 120         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 121         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 122         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 123         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 124         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 125         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 126         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 127         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 128         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 129         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 130         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 131         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 132         procfs.c, producer.c, progspace.h, psymtab.h,
 133         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 134         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 135         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 136         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 137         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 138         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 139         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 140         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 141         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 142         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 143         target-memory.c, target.c, target.h, target/waitstatus.c,
 144         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 145         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 146         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 147         unittests/array-view-selftests.c,
 148         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 149         unittests/common-utils-selftests.c,
 150         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 151         unittests/format_pieces-selftests.c,
 152         unittests/function-view-selftests.c,
 153         unittests/lookup_name_info-selftests.c,
 154         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 155         unittests/mkdir-recursive-selftests.c,
 156         unittests/observable-selftests.c,
 157         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 158         unittests/parse-connection-spec-selftests.c,
 159         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 160         unittests/scoped_fd-selftests.c,
 161         unittests/scoped_mmap-selftests.c,
 162         unittests/scoped_restore-selftests.c,
 163         unittests/string_view-selftests.c, unittests/style-selftests.c,
 164         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 165         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 166         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 167         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 168         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 169         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 170
 171 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 172
 173         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 174         bool value.
 175         (decode_digits_ordinary): Set explicit_line field in sal.
 176         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 177         symtab_and_line that was set on an explicit line number in
 178         assembler code.  Do always update the recorded symtab and line if
 179         we do skip the prologue.
 180
 181 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 182
 183         * breakpoint.c (set_breakpoint_location_function): Remove
 184         explicit_loc parameter.
 185         (momentary_breakpoint_from_master): Update call to
 186         set_breakpoint_location_function.
 187         (add_location_to_breakpoint): Likewise.
 188
 189 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 192         required features based on default bfd type when no specific bfd
 193         is present.
 194
 195 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 196
 197         * NEWS: Mention that GDB printf and eval commands can now print
 198         C-style and Ada-style convenience var strings without
 199         calling the inferior.
 200         * printcmd.c (printf_c_string): Locally print GDB internal var
 201         instead of transiting via the inferior.
 202         (printf_wide_c_string): Likewise.
 203
 204 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 205
 206         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 207
 208 2019-07-04  Tom Tromey  <tom@tromey.com>
 209
 210         PR tui/24724:
 211         * tui/tui-winsource.c (tui_clear_source_content): Update.
 212         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 213         (tui_update_breakpoint_info): Update.
 214         (tui_set_exec_info_content): Update.
 215         * tui/tui-source.c (tui_set_source_content_nil): Update.
 216         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 217         has_break.
 218         * tui/tui-data.h (enum tui_bp_flag): New.
 219         (tui_bp_flags): New enum flags type.
 220         (struct tui_source_element) <break_mode>: Change type.  Rename
 221         from has_break.
 222         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 223         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 224         constants.
 225         * tui/tui-winsource.h: Fix comment.
 226
 227 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 228
 229         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 230         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 231         (store_fpregs_to_thread)
 232         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 233         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 234         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 235         (IWMMXT_REGS_SIZE): Add define.
 236         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 237         (fetch_vfp_regs, store_vfp_regs)
 238         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 239         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 240
 241 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 242
 243         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 244         defines.
 245         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 246         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 247         (ARM_INT_REGISTER_SIZE): ...to this.
 248         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 249         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 250         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 251         (arm_linux_collect_gregset, supply_nwfpe_register)
 252         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 253         defines.
 254         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 255         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 256         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 257         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 258         (arm_return_in_memory, arm_store_return_value)
 259         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 260         (arm_record_ld_st_multiple): Likewise.
 261         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 262         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 263
 264 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 265
 266         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 267         AARCH64_DISPLACED_MODIFIED_INSNS.
 268         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 269         (aarch64_displaced_step_copy_insn): Likewise.
 270         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 271         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 272         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 273         ARM_DISPLACED_MODIFIED_INSNS.
 274         * arm-tdep.c (arm_gdbarch_init): Likewise.
 275         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 276         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 277         (struct arm_displaced_step_closure): Use
 278         ARM_DISPLACED_MODIFIED_INSNS.
 279
 280 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 281
 282         * features/Makefile: Remove unused xml files.
 283         * features/aarch64.xml: Remove.
 284         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 285         * features/i386/amd64-avx-avx512.xml: Remove.
 286         * features/i386/amd64-avx-linux.xml: Remove.
 287         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 288         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 289         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 290         * features/i386/amd64-avx-mpx.xml: Remove.
 291         * features/i386/amd64-avx.xml: Remove.
 292         * features/i386/amd64-linux.xml: Remove.
 293         * features/i386/amd64-mpx-linux.xml: Remove.
 294         * features/i386/amd64-mpx.xml: Remove.
 295         * features/i386/amd64.xml: Remove.
 296         * features/i386/i386-avx-avx512-linux.xml: Remove.
 297         * features/i386/i386-avx-avx512.xml: Remove.
 298         * features/i386/i386-avx-linux.xml: Remove.
 299         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 300         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 301         * features/i386/i386-avx-mpx-linux.xml: Remove.
 302         * features/i386/i386-avx-mpx.xml: Remove.
 303         * features/i386/i386-avx.xml: Remove.
 304         * features/i386/i386-linux.xml: Remove.
 305         * features/i386/i386-mmx-linux.xml: Remove.
 306         * features/i386/i386-mmx.xml: Remove.
 307         * features/i386/i386-mpx-linux.xml: Remove.
 308         * features/i386/i386-mpx.xml: Remove.
 309         * features/i386/i386.xml: Remove.
 310         * features/i386/x32-avx-avx512-linux.xml: Remove.
 311         * features/i386/x32-avx-linux.xml: Remove.
 312         * features/i386/x32-linux.xml: Remove.
 313
 314 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 315
 316         * regformats/aarch64.dat: Remove.
 317         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 318         * regformats/i386/amd64-avx-linux.dat: Remove.
 319         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 320         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 321         * regformats/i386/amd64-linux.dat: Remove.
 322         * regformats/i386/amd64-mpx-linux.dat: Remove.
 323         * regformats/i386/amd64.dat: Remove.
 324         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 325         * regformats/i386/i386-avx-linux.dat: Remove.
 326         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 327         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 328         * regformats/i386/i386-linux.dat: Remove.
 329         * regformats/i386/i386-mmx-linux.dat: Remove.
 330         * regformats/i386/i386-mpx-linux.dat: Remove.
 331         * regformats/i386/i386.dat: Remove.
 332         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 333         * regformats/i386/x32-avx-linux.dat: Remove.
 334         * regformats/i386/x32-linux.dat: Remove.
 335
 336 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 337
 338         * aarch64-tdep.c: Remove xml self tests.
 339         * amd64-linux-tdep.c: Likewise.
 340         * amd64-tdep.c: Likewise.
 341         * i386-linux-tdep.c: Likewise.
 342         * i386-tdep.c: Likewise.
 343
 344 2019-07-03  Pedro Alves  <palves@redhat.com>
 345
 346         PR cli/24732
 347         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 348         (pipe_cmd_option_defs): New.
 349         (make_pipe_cmd_options_def_group): New.
 350         (pipe_command): Use gdb::option::process_options.
 351         (pipe_command_completer): New function.
 352         (_initialize_cli_cmds): Install completer for "pipe" command.
 353
 354 2019-07-03  Pedro Alves  <palves@redhat.com>
 355
 356         * cli/cli-option.c (union option_value) <string>: New field.
 357         (struct option_def_and_value): Add ctor, move ctor, dtor and
 358         use DISABLE_COPY_AND_ASSIGN.
 359         (option_def_and_value::clear_value): New.
 360         (parse_option, save_option_value_in_ctx, get_val_type_str)
 361         (add_setshow_cmds_for_options): Handle var_string.
 362         * cli-option.h (union option_def::var_address) <string>: New
 363         field.
 364         (struct string_option_def): New.
 365         * maint-test-options.c (struct test_options_opts): Add default
 366         ctor and use DISABLE_COPY_AND_ASSIGN.
 367         <string_opt>: New field.
 368         (test_options_opts::~test_options_opts): New.
 369         (test_options_opts::dump): Also dump "-string".
 370         (test_options_option_defs): Install "string.
 371
 372 2019-07-03  Pedro Alves  <palves@redhat.com>
 373
 374         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 375         option_value with a null enumeration.
 376         (complete_options): Save the option values in the context.
 377         (save_option_value_in_ctx): New, factored out from ...
 378         (process_options): ... here.
 379         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 380         of the function.
 381         * maint-test-options.c (test_options_opts::dump): New, factored
 382         out from ...
 383         (maintenance_test_options_command_mode): ... here.
 384         (maintenance_test_options_command_completion_result): Delete.
 385         (maintenance_test_options_command_completion_text): Update
 386         comment.
 387         (maintenance_show_test_options_completion_result): Change
 388         prototype.  Just print
 389         maintenance_test_options_command_completion_text.
 390         (save_completion_result): New.
 391         (maintenance_test_options_completer_mode): Pass options context to
 392         complete_options, and then save a dump.
 393         (_initialize_maint_test_options): Use add_cmd to install "maint
 394         show test-options-completion-result".
 395
 396 2019-07-03  Pedro Alves  <palves@redhat.com>
 397
 398         * NEWS (New commands): Mention "with" and "maint with".
 399         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 400         (with_command, with_command_completer): New.
 401         (pipe_command): Adjust to new repeat_previous
 402         interface.
 403         (_initialize_cli_cmds): Install the "with" command and its "w"
 404         alias.
 405         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 406         declarations.
 407         * cli/cli-setshow.c (parse_cli_var_uinteger)
 408         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 409         argument strings for all var_types.
 410         (get_setshow_command_value_string): New, factored out from ...
 411         (do_show_command): ... this.
 412         * cli/cli-setshow.h: Include <string>.
 413         (get_setshow_command_value_string): Declare.
 414         * command.h (repeat_previous): Now returns const char *.  Adjust
 415         comment.
 416         * maint.c: Include "cli/cli-cmds.h".
 417         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 418         (_initialize_maint_cmds): Register the "maintenance with" command.
 419         * top.c (repeat_previous): Move bits from pipe_command here:
 420         Return the saved command line, if any; error out if there's no
 421         command to relaunch.
 422
 423 2019-07-03  Pedro Alves  <palves@redhat.com>
 424
 425         * NEWS (New commands): Mention "maint set/show test-settings"
 426         instead of "maint test-settings".
 427         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 428         (maintenance_test_settings_set_list): Rename to ...
 429         (maintenance_set_test_settings_list): ... this.
 430         (maintenance_test_settings_show_list): Rename to  ...
 431         (maintenance_show_test_settings_list): ... this.
 432         (maintenance_test_settings_cmd): Delete.
 433         (maintenance_test_settings_set_cmd): ...
 434         (maintenance_set_test_settings_cmd): ... this.
 435         (maintenance_test_settings_show_cmd): ...
 436         (maintenance_show_test_settings_cmd): ... this.
 437         (maintenance_test_settings_show_value_cmd):
 438         (maintenance_show_test_settings_value_cmd): ... this.
 439         (_initialize_maint_test_settings): No longer install the "maint
 440         test-settings" prefix command.  Rename "maint test-settings set"
 441         to "maint set test-settings", and "maint test-settings show" to
 442         "maint show test-settings".  Adjust all subcommands.
 443
 444 2019-07-03  Pedro Alves  <palves@redhat.com>
 445
 446         * maint-test-settings.c: Fix file's intro comment.  Replace all
 447         references to "test-options" with references to "test-settings",
 448         in comments.
 449
 450 2019-07-03  Pedro Alves  <palves@redhat.com>
 451
 452         * maint-test-settings.c (maintenance_test_settings_xxx)
 453         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 454         New.
 455         (maintenance_test_settings_enums): Use them.
 456         (maintenance_test_settings_enum): Default to
 457         maintenance_test_settings_xxx.
 458         (_initialize_maint_test_settings): Initialize
 459         MAINTENANCE_TEST_SETTINGS_FILENAME.
 460
 461 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 462
 463         * breakpoint.h (remove_breakpoints_inf): Change return type to
 464         void, move function documentation here.
 465         * breakpoint.c (remove_breakpoints_inf): Change return type to
 466         void, move function documentation to header.
 467
 468 2019-07-02  Pedro Alves  <palves@redhat.com>
 469
 470         * NEWS (Completion improvements): Mention "info threads".
 471         * thread.c (struct info_threads_opts, info_threads_option_defs)
 472         (make_info_threads_options_def_group): New.
 473         (info_threads_command): Use gdb::option::process_options.
 474         (info_threads_command_completer): New.
 475         (_initialize_thread): Use gdb::option::build_help to build the
 476         help text for "info threads".
 477
 478 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 479
 480         * defs.h (generic_load): Move from here...
 481         * symfile.h (generic_load): ... to here.  Rename name parameter
 482         to args.
 483         * symfile.c (generic_load): Add comment.
 484
 485 2019-07-01  Tom Tromey  <tromey@adacore.com>
 486
 487         * dwarf2read.c
 488         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 489         declaration of without_params.  Fix formatting.
 490
 491 2019-07-01  Tom Tromey  <tromey@adacore.com>
 492
 493         * ada-exp.y (find_primitive_type): Update.
 494         * ada-lang.h (ada_lookup_symbol): Update.
 495         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 496         parameter.
 497         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 498
 499 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 500
 501         PR breakpoints/24541
 502         * gdbarch.c: Regenerate.
 503         * gdbarch.h: Regenerate.
 504         * gdbarch.sh: Add 'stap_adjust_register'.
 505         * i386-tdep.c: Include '<unordered_set>'.
 506         (i386_stap_adjust_register): New function.
 507         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 508         * stap-probe.c (stap_parse_register_operand): Call
 509         'gdbarch_stap_adjust_register'.
 510
 511 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 512
 513         PR python/24742
 514         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 515         * python/python.c (do_start_initialization): Use 'xmalloc'
 516         instead of 'PyMem_Malloc'.
 517
 518 2019-06-28  Tom Tromey  <tromey@adacore.com>
 519
 520         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 521         for Ada.
 522
 523 2019-06-27  Tom Tromey  <tromey@adacore.com>
 524
 525         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 526         objfile_key.
 527         (arm_find_mapping_symbol, arm_record_special_symbol)
 528         (_initialize_arm_tdep): Update.
 529         (arm_objfile_data_free): Remove.
 530
 531 2019-06-27  Tom Tromey  <tromey@adacore.com>
 532
 533         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 534         to cp_print_static_field.
 535
 536 2019-06-26  Tom Tromey  <tromey@adacore.com>
 537
 538         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 539         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 540         declare.
 541
 542 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 543
 544         * features/aarch64-core.c (create_feature_aarch64_core):
 545         Regenerate.
 546         * features/aarch64-core.xml: Add cpsr flags.
 547
 548 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 549
 550         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 551         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 552
 553 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 554
 555         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 556         field.
 557         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 558         use.
 559         (arm_record_special_symbol): Don't insert new symbol in sorted
 560         position, push it at the end.
 561
 562 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 563
 564         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 565         (arm_mapping_symbol_s): Remove.
 566         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 567         (arm_mapping_symbol_vec): New typedef.
 568         (struct arm_per_objfile): Add constructor.
 569         <section_maps>: Change type to
 570         std::unique_ptr<arm_mapping_symbol_vec[]>.
 571         (arm_compare_mapping_symbols): Remove.
 572         (arm_find_mapping_symbol): Adjust to section_maps type change.
 573         (arm_objfile_data_free): Call delete on arm_per_objfile.
 574         (arm_record_special_symbol): Adjust to section_maps type change.
 575         Allocate arm_per_objfile with new.
 576
 577 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 578
 579         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 580         with the command prefix.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 585         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 586
 587 2019-06-25  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 590         type.
 591         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 592         protected.
 593
 594 2019-06-25  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.c
 597         (tui_source_window_base::set_is_exec_point_at): Add check against
 598         LOA_ADDRESS.
 599
 600 2019-06-25  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-source.c (tui_set_source_content): Don't check before
 603         xfree.
 604         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 605
 606 2019-06-25  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-winsource.h (tui_update_source_window_as_is)
 609         (tui_alloc_source_buffer, tui_line_is_displayed)
 610         (tui_addr_is_displayed): Change type of win_info.
 611         * tui/tui-winsource.c (tui_update_source_window_as_is)
 612         (tui_clear_source_content, tui_show_source_line)
 613         (tui_show_source_content, tui_source_window_base::refill)
 614         (tui_source_window_base::set_is_exec_point_at)
 615         (tui_source_window_base::set_is_exec_point_at)
 616         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 617         (tui_alloc_source_buffer, tui_line_is_displayed)
 618         (tui_addr_is_displayed): Change type of win_info.  Update.
 619         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 620         (tui_source_window_base::do_make_visible_with_new_height):
 621         Update.
 622         * tui/tui-source.c (tui_set_source_content)
 623         (tui_set_source_content_nil)
 624         (tui_source_window::do_scroll_vertical): Update.
 625         * tui/tui-layout.c (show_layout): Update.
 626         * tui/tui-disasm.c (tui_set_disassem_content)
 627         (tui_disasm_window::do_scroll_vertical): Update.
 628         * tui/tui-data.h (tui_win_content): Remove.
 629         (struct tui_gen_win_info) <content, content_size>: Remove.
 630         (struct tui_source_element): Add initializers and destructor.
 631         (union tui_which_element, struct tui_win_element): Remove.
 632         (struct tui_source_window_base) <content>: New field.
 633         (struct tui_data_window): Remove destructor.
 634         (tui_alloc_content, tui_free_win_content)
 635         (tui_free_all_source_wins_content): Don't declare.
 636         * tui/tui-data.c (tui_initialize_static_data): Update.
 637         (init_content_element, tui_alloc_content): Remove.
 638         (~tui_gen_win_info): Update.
 639         (~tui_data_window, tui_free_all_source_wins_content)
 640         (tui_free_win_content, free_content, free_content_elements):
 641         Remove.
 642
 643 2019-06-25  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-winsource.h (tui_clear_source_content)
 646         (tui_erase_source_content, tui_show_source_content): Change type
 647         of win_info.
 648         * tui/tui-winsource.c (tui_clear_source_content)
 649         (tui_erase_source_content, tui_show_source_content): Change type
 650         of win_info.
 651         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 652         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 653         win_info.
 654         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 655         win_info.
 656         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 657
 658 2019-06-25  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-winsource.c (tui_clear_source_content)
 661         (tui_source_window_base::set_is_exec_point_at): Update.
 662         * tui/tui-source.c (tui_set_source_content_nil): Update.
 663         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 664         a bool.
 665         * tui/tui-data.c (init_content_element): Update.
 666
 667 2019-06-25  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 670         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 671         * tui/tui-layout.c (init_and_make_win): Update.
 672         * tui/tui.h (enum tui_win_type): Update.
 673         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 674         tui_win_is_auxillary.
 675         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 676         tui_win_is_auxillary.
 677
 678 2019-06-25  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 681         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 682         (tui_delete_data_content_windows, tui_display_all_data)
 683         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 684         Update.
 685         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 686         * tui/tui-regs.c (tui_last_regs_line_no)
 687         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 688         (tui_show_registers): Update.
 689         (tui_show_register_group): Return void.  Update.
 690         (tui_display_registers_from, tui_display_reg_element_at_line)
 691         (tui_display_registers_from_line, tui_check_register_values):
 692         Update.
 693         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 694         member.
 695         (struct tui_data_window) <regs_content>: Now a std::vector.
 696         <regs_content_count>: Remove.
 697         (tui_add_content_elements, tui_free_data_content): Don't declare.
 698         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 699         (init_content_element): Remove DATA_WIN case.  Add assert.
 700         (tui_add_content_elements): Remove.
 701         (tui_data_window): Update.
 702         (tui_free_data_content): Remove.
 703         (free_content_elements): Remove DATA_WIN case.
 704
 705 2019-06-25  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-data.c (tui_data_item_window): Update.
 708         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 709         * tui/tui-windata.c (tui_display_all_data)
 710         (tui_display_data_from_line): Update.
 711         (tui_check_data_values): Remove.
 712         * tui/tui-regs.c (tui_show_register_group)
 713         (tui_display_reg_element_at_line): Update.
 714         * tui/tui-hooks.c (tui_register_changed)
 715         (tui_refresh_frame_and_register_information): Call
 716         tui_check_register_values.
 717         * tui/tui-data.h (struct tui_data_window) <data_content,
 718         data_content_count, data_type>: Remove.
 719         (enum tui_data_type): Remove.
 720
 721         * tui/tui-data.c (tui_data_window::clear_detail)
 722         (~tui_data_window): Update.
 723
 724 2019-06-25  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 727         declare.
 728         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 729         Rename from tui_first_data_item_displayed.  Update.
 730         (tui_data_window::refresh_all)
 731         (tui_data_window::do_scroll_vertical): Update.
 732         * tui/tui-data.h (struct tui_data_window)
 733         <first_data_item_displayed>: Declare new method.
 734
 735 2019-06-25  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 738         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 739         contents...
 740         (tui_initialize_static_data): ...here.
 741
 742 2019-06-25  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 745         (tui_display_registers_from, tui_check_register_values): Update.
 746         (tui_display_register): Remove win_info parameter; update.
 747         (tui_get_register): Change type of parameters.
 748         * tui/tui-data.h (struct tui_data_element): Remove.
 749         (union tui_which_element) <data>: Remove.
 750         <data_window>: Change type.
 751         (struct tui_data_item_window): New.
 752         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 753         case.  Add assert.
 754         (~tui_data_item_window): New destructor.
 755         (free_content_elements): Remove DATA_ITEM_WIN case.
 756
 757 2019-06-25  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 760         Remove.
 761
 762 2019-06-25  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-data.h (struct tui_command_element): Remove.
 765         (union tui_which_element) <command>: Remove.
 766         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 767         assert.
 768         (free_content_elements): Remove CMD_WIN case.
 769
 770 2019-06-25  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-layout.c (tui_set_layout): Update.
 773         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 774         * tui/tui-data.c (layout_def): Update.
 775
 776 2019-06-25  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 779         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 780         (tui_source_window_base::set_new_height): Update.
 781         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 782         Update.
 783         (tui_set_locator_fullname, tui_set_locator_info)
 784         (tui_show_frame_info): Update.
 785         * tui/tui-source.c (tui_set_source_content)
 786         (tui_source_is_displayed): Update.
 787         * tui/tui-layout.c (show_source_disasm_command, show_data)
 788         (show_source_or_disasm_and_command): Update.
 789         * tui/tui-disasm.c (tui_set_disassem_content)
 790         (tui_get_begin_asm_address): Update.
 791         * tui/tui-data.h (struct tui_locator_element): Remove.
 792         (union tui_which_element) <locator>: Remove.
 793         (struct tui_locator_window): New.
 794         (tui_locator_win_info_ptr): Change return type.
 795         * tui/tui-data.c (_locator): Change type.
 796         (tui_locator_win_info_ptr): Change return type.
 797         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 798         (tui_alloc_content): Add assert.
 799
 800 2019-06-25  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-winsource.c
 803         (tui_exec_info_window::maybe_allocate_content): New method.
 804         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 805         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 806         (make_source_or_disasm_window): Add cast.
 807         * tui/tui-data.h (union tui_which_element) <simple_string>:
 808         Remove.
 809         (struct tui_source_info): New.
 810         (struct tui_source_window_base) <execution_info>: Change type.
 811         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 812         case, and add assert.
 813         (tui_alloc_content): Add assert.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 818         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 819         * tui/tui-data.c (tui_alloc_win_info): Remove.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 824         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 825         can_highlight.
 826
 827 2019-06-25  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 830         make_visible_with_new_height method.
 831         (tui_win_info::make_visible_with_new_height): New method.
 832         (tui_source_window_base::do_make_visible_with_new_height)
 833         (tui_data_window::do_make_visible_with_new_height)
 834         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 835         (make_visible_with_new_height): Remove.
 836         (tui_resize_all, tui_adjust_win_heights): Use
 837         make_visible_with_new_height method.
 838         * tui/tui-data.h (struct tui_win_info)
 839         <do_make_visible_with_new_height, make_visible_with_new_height>:
 840         New methods.
 841         (struct tui_source_window_base, struct tui_data_window)
 842         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 843         methods.
 844
 845 2019-06-25  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 848         method.
 849         (update_tab_width): Call update_tab_width method.
 850         * tui/tui-data.h (struct tui_win_info)
 851         (struct tui_source_window_base) <update_tab_width>: New methods.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 856         parameter.
 857         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 858         parameter.
 859         (tui_gen_win_info::make_visible): Update.
 860         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 861         parameter.
 862         * tui/tui-data.h (enum tui_box): New enum.
 863         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 864
 865 2019-06-25  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 868         init_and_make_win for EXEC_INFO_WIN.
 869         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 870         longer inline.
 871         (struct tui_win_info) <~tui_win_info>: Inline.
 872         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 873         Don't declare.
 874         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 875         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 876         Remove.
 877         (tui_initialize_static_data): Update.
 878         (~tui_gen_win_info): Handle more cleanup here.
 879         (~tui_source_window_base): Delete "execution_info".
 880         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 881
 882 2019-06-25  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-layout.c (make_command_window): Don't set
 885         can_highlight.
 886         (show_source_disasm_command): Call the reset method.
 887         (show_data): Don't set can_highlight.  Call the reset method.
 888         (tui_gen_win_info::reset): Rename from init_gen_win_info
 889         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 890         (show_source_or_disasm_and_command): Call the reset method.
 891         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 892         (struct tui_cmd_window): Set can_highlight.
 893
 894 2019-06-25  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 897         from make_visible.
 898         (tui_make_visible, tui_make_invisible): Rewrite.
 899         (tui_win_info::make_visible): Remove.
 900         (tui_source_window_base::make_visible): Update.
 901         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 902         method.  Moved from...
 903         (struct tui_win_info) <make_visible>: ...here.
 904
 905 2019-06-25  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-winsource.c
 908         (tui_source_window_base::do_scroll_horizontal): Remove direction
 909         parameter.
 910         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 911         direction parameter.
 912         * tui/tui-win.c (tui_win_info::forward_scroll)
 913         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 914         (tui_win_info::right_scroll): Update.
 915         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 916         direction parameter.
 917         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 918         direction parameter.
 919         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 920         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 921         Remove direction parameter.
 922         (struct tui_source_window_base, struct tui_source_window)
 923         (struct tui_disasm_window, struct tui_data_window)
 924         (struct tui_cmd_window): Update.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-winsource.h (tui_set_exec_info_content)
 929         (tui_show_exec_info_content, tui_erase_exec_info_content)
 930         (tui_clear_exec_info_content, tui_update_exec_info): Change
 931         argument to tui_source_window_base.
 932         * tui/tui-winsource.c (tui_set_exec_info_content)
 933         (tui_show_exec_info_content, tui_erase_exec_info_content)
 934         (tui_clear_exec_info_content, tui_update_exec_info): Change
 935         argument to tui_source_window_base.
 936
 937 2019-06-25  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 940         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 941
 942 2019-06-25  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 945         check.
 946
 947 2019-06-25  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 950         type to void.
 951         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 952         type to void.
 953         * tui/tui-source.c (tui_set_source_content): Update.
 954         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 955
 956 2019-06-25  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-win.c (window_name_completer, tui_set_focus)
 959         (tui_all_windows_info): Use name method.
 960         * tui/tui-data.h (struct tui_gen_win_info)
 961         (struct tui_source_window, struct tui_disasm_window)
 962         (struct tui_data_window, struct tui_cmd_window) <name>: New
 963         method.
 964         (tui_win_name): Don't declare.
 965         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 966         (tui_win_name): Remove.
 967
 968 2019-06-25  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-winsource.h (tui_update_source_window)
 971         (tui_update_source_window_as_is): Change parameter type.
 972         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 973         to be a tui_source_window_base.
 974         (tui_update_source_window_as_is): Likewise.
 975         * tui/tui-win.c (make_visible_with_new_height): Update.
 976
 977 2019-06-25  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-winsource.c (tui_erase_source_content)
 980         (tui_show_source_content, tui_show_exec_info_content)
 981         (tui_erase_exec_info_content): Use refresh_window method.
 982         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 983         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 984         from tui_refresh_win.
 985         (tui_data_window::refresh_window): New method.
 986         (tui_win_info::refresh, tui_source_window_base::refresh)
 987         (tui_refresh_all): Use refresh_window method.
 988         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 989         method.
 990         * tui/tui-regs.c (tui_display_register): Call refresh_window
 991         method.
 992         * tui/tui-layout.c (show_source_disasm_command)
 993         (show_source_or_disasm_and_command): Call refresh_window method.
 994         * tui/tui-data.h (struct tui_gen_win_info)
 995         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 996         New method.
 997
 998 2019-06-25  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui.c (tui_rl_other_window, tui_enable)
1001         (tui_is_window_visible, tui_get_command_dimension): Update.
1002         * tui/tui-winsource.c (tui_update_source_window_as_is)
1003         (tui_clear_source_content, tui_erase_source_content)
1004         (tui_show_source_line, tui_source_window_base::refill)
1005         (tui_source_window_base::do_scroll_horizontal)
1006         (tui_source_window_base::set_is_exec_point_at)
1007         (tui_update_breakpoint_info, tui_set_exec_info_content)
1008         (tui_alloc_source_buffer, tui_line_is_displayed)
1009         (tui_addr_is_displayed): Update.
1010         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1011         (tui_check_and_display_highlight_if_needed)
1012         (tui_win_info::make_visible, tui_win_info::refresh)
1013         (tui_refresh_all): Update.
1014         * tui/tui-windata.c (tui_first_data_item_displayed)
1015         (tui_delete_data_content_windows, tui_erase_data_content)
1016         (tui_display_all_data, tui_data_window::refresh_all)
1017         (tui_check_data_values): Update.
1018         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1019         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1020         (tui_win_info::backward_scroll, tui_refresh_all_win)
1021         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1022         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1023         (tui_source_window_base::set_new_height)
1024         (tui_data_window::set_new_height)
1025         (make_invisible_and_set_new_height)
1026         (make_visible_with_new_height, new_height_ok)
1027         (parse_scrolling_args): Update.
1028         * tui/tui-stack.c (tui_show_frame_info): Update.
1029         * tui/tui-source.c (tui_set_source_content)
1030         (tui_set_source_content_nil, tui_source_is_displayed)
1031         (tui_source_window::do_scroll_vertical): Update.
1032         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1033         (tui_display_registers_from, tui_display_reg_element_at_line)
1034         (tui_check_register_values, tui_reg_command): Update.
1035         * tui/tui-layout.c (tui_default_win_height)
1036         (show_source_disasm_command, show_data, init_and_make_win)
1037         (show_source_or_disasm_and_command): Update.
1038         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1039         (tui_redisplay_readline, tui_mld_flush)
1040         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1041         (tui_getc): Update.
1042         * tui/tui-disasm.c (tui_set_disassem_content)
1043         (tui_disasm_window::do_scroll_vertical): Update.
1044         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1045         Now virtual.
1046         (struct tui_win_info): Derive from tui_gen_win_info.
1047         <~tui_win_info>: Mark as override.
1048         <generic>: Remove member.
1049         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1050         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1051         (~tui_data_window, ~tui_win_info)
1052         (tui_free_all_source_wins_content): Update.
1053         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1054
1055 2019-06-25  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-layout.c (init_and_make_win): Use new.
1058         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1059         destructor, initializers.
1060         (tui_alloc_generic_win_info): Don't declare.
1061         * tui/tui-data.c (_locator): Add argument to constructor.
1062         (source_win, disasm_win): New globals.
1063         (exec_info): Remove.
1064         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1065         Update.
1066         (tui_alloc_generic_win_info): Remove.
1067         (init_content_element): Use new.
1068         (tui_win_info::tui_win_info): Update.
1069         (free_content_elements) <case DATA_WIN>: Use delete.
1070
1071 2019-06-25  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1074         * tui/tui-windata.c (tui_first_data_item_displayed)
1075         (tui_delete_data_content_windows): Update.
1076         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1077         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1078         (tui_display_registers_from, tui_check_register_values): Update.
1079         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1080         pointer.
1081         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1082         window.
1083         (tui_free_data_content): Update.
1084         (free_content_elements) <case DATA_WIN>: Free the window.
1085
1086 2019-06-25  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1089         Update.
1090         * tui/tui-layout.c (make_command_window)
1091         (show_source_disasm_command, show_data, init_and_make_win)
1092         (show_source_or_disasm_and_command): Update.
1093         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1094         method.
1095         <can_highight, is_highlighted>: Now bool.
1096         (tui_set_win_highlight): Don't declare.
1097         * tui/tui-data.c (tui_set_win_highlight): Remove.
1098
1099 2019-06-25  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-wingeneral.c (make_visible): Remove check of window
1102         type.
1103
1104 2019-06-25  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-win.c (tui_win_info::max_height)
1107         (tui_cmd_window::max_height): New methods.
1108         (new_height_ok): Call max_height.
1109         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1110         <max_height>: New method.
1111
1112 2019-06-25  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-win.c (tui_source_window_base::set_new_height)
1115         (tui_data_window::set_new_height): New methods.
1116         (make_invisible_and_set_new_height): Call set_new_height method.
1117         * tui/tui-data.h (struct tui_win_info)
1118         (struct tui_source_window_base, struct tui_data_window)
1119         <set_new_height>: New method.
1120
1121 2019-06-25  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1124         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1125         tui_refresh_data_win.
1126         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1127         method.
1128         (tui_refresh_all_win): Call the refresh_all method.
1129         (tui_set_focus): Likewise.
1130         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1131         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1132         Likewise.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-winsource.h (tui_refill_source_window)
1137         (tui_set_is_exec_point_at): Don't declare.
1138         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1139         (tui_source_window_base::refill): Rename from
1140         tui_refill_source_window.
1141         (tui_source_window_base::do_scroll_horizontal): Update.
1142         (tui_source_window_base::set_is_exec_point_at): Rename from
1143         tui_set_is_exec_point_at.
1144         (tui_update_all_breakpoint_info): Update.
1145         * tui/tui-stack.c (tui_show_frame_info): Update.
1146         * tui/tui-layout.c (show_data): Add cast.
1147         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1148         * tui/tui-data.h (struct tui_source_window_base) <refill,
1149         set_is_exec_point_at>: New methods.
1150         (tui_source_windows, tui_add_to_source_windows): Update types.
1151         (tui_add_to_source_windows): Remove redundant declaration.
1152         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1153         (tui_source_windows): Change return type.
1154         (tui_clear_source_windows_detail): Update.
1155         (tui_add_to_source_windows): Change type of parameter.
1156         (tui_free_all_source_wins_content): Update.
1157
1158 2019-06-25  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-wingeneral.c (tui_win_info::refresh)
1161         (tui_source_window_base::refresh): New methods.
1162         (tui_refresh_all): Call the refresh method.
1163         * tui/tui-data.h (struct tui_win_info)
1164         (struct tui_source_window_base) <refresh>: New method.
1165
1166 2019-06-25  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui.h (tui_is_window_visible): Return bool.
1169         * tui/tui.c (tui_is_window_visible): Return bool.
1170         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1171         (tui_make_visible, tui_make_invisible)
1172         (tui_win_info::make_visible)
1173         (tui_source_window_base::make_visible, make_all_visible)
1174         (tui_make_all_visible, tui_make_all_invisible): Update.
1175         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1176         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1177         bool.
1178         (struct tui_win_info, struct tui_source_window_base)
1179         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1180         * tui/tui-data.c (tui_init_generic_part): Update.
1181
1182 2019-06-25  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1185         (tui_source_window_base::make_visible): New methods.
1186         (make_all_visible): Make method call.
1187         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1188         (struct tui_source_window_base, struct tui_cmd_window): Override
1189         make_visible.
1190         (tui_win_is_source_type): Don't declare.
1191         * tui/tui-data.c (tui_win_is_source_type): Remove.
1192
1193 2019-06-25  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1196         NULL check.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1201         Inline constructor.  Add initializers for members.
1202         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1203         constructors; now inline in class.
1204
1205 2019-06-25  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-regs.c (tui_show_registers): Update.
1208         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1209         bool.
1210         * tui/tui-data.c (tui_data_window::clear_detail)
1211         (tui_data_window): Update.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-windata.c (tui_display_all_data)
1216         (tui_display_data_from_line, tui_display_data_from)
1217         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1218         Update.
1219         * tui/tui-regs.c (tui_last_regs_line_no)
1220         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1221         (tui_show_registers, tui_show_register_group)
1222         (tui_display_registers_from, tui_display_reg_element_at_line)
1223         (tui_display_registers_from_line, tui_check_register_values)
1224         (tui_reg_next, tui_reg_prev): Update.
1225         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1226         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1227         tui_data_window.
1228         (struct tui_win_info) <detail>: Remove.  Add new fields from
1229         tui_data_info.
1230         (TUI_DATA_WIN): Add cast.
1231         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1232         (~tui_data_window): Simplify.
1233
1234 2019-06-25  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-layout.c (show_source_disasm_command)
1237         (show_source_or_disasm_and_command): Update.
1238         * tui/tui-io.c (update_cmdwin_start_line)
1239         (tui_redisplay_readline): Update.
1240         * tui/tui-data.h (struct tui_command_info): Remove.
1241         (struct tui_win_info) <detail>: Remove command_info member.
1242         (struct tui_data_window) <start_line>: New member, from
1243         tui_command_info.
1244         (TUI_CMD_WIN): Add casts.
1245
1246 2019-06-25  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-winsource.c (tui_update_source_window)
1249         (tui_refill_source_window)
1250         (tui_source_window_base::do_scroll_horizontal)
1251         (tui_update_breakpoint_info, tui_set_exec_info_content)
1252         (tui_show_exec_info_content, tui_erase_exec_info_content)
1253         (tui_clear_exec_info_content): Update.
1254         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1255         Update.
1256         * tui/tui-win.c (make_invisible_and_set_new_height)
1257         (make_visible_with_new_height): Update.
1258         * tui/tui-source.c (tui_set_source_content)
1259         (tui_show_symtab_source): Update.
1260         * tui/tui-layout.c (extract_display_start_addr)
1261         (show_source_disasm_command, show_data)
1262         (make_source_or_disasm_window)
1263         (show_source_or_disasm_and_command): Update.
1264         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1265         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1266         "gdbarch".
1267         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1268         to tui_source_window_base.
1269         (struct tui_win_info) <detail>: Remove source_info member.
1270         (struct tui_source_window_base) <has_locator>: Inline.
1271         Move contents from tui_source_info; rename has_locator member to
1272         m_has_locator.
1273         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1274         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1275         header file.
1276         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1277         Simplify.
1278         (tui_free_all_source_wins_content): Cast to
1279         tui_source_window_base.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-win.c (make_invisible_and_set_new_height)
1284         (make_visible_with_new_height): Call has_locator method.
1285         * tui/tui-layout.c (show_source_disasm_command, show_data)
1286         (show_source_or_disasm_and_command): Update for bool change.
1287         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1288         (tui_win_info) <has_locator>: New method.
1289         (struct tui_source_window_base) <has_locator>: New method.
1290         (tui_win_has_locator): Don't declare.
1291         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1292         from tui_win_has_locator.
1293         (tui_source_window_base): Use false, not FALSE.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1298         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1299         clear_detail method directly.
1300         (tui_clear_win_detail): Remove.
1301
1302 2019-06-25  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1305         "this", not TUI_DISASM_WIN.
1306
1307 2019-06-25  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1310         declare.
1311         * tui/tui-winsource.c
1312         (tui_source_window_base::do_scroll_horizontal): Rename from
1313         tui_horizontal_source_scroll.
1314         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1315         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1316         from tui_vertical_data_scroll.
1317         * tui/tui-win.h (tui_scroll): Don't declare.
1318         * tui/tui-win.c (tui_win_info::forward_scroll)
1319         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1320         (tui_win_info::right_scroll): Rename and update.
1321         (tui_scroll_forward_command, tui_scroll_backward_command)
1322         (tui_scroll_left_command, tui_scroll_right_command): Update.
1323         (tui_scroll): Remove.
1324         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1325         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1326         from tui_vertical_source_scroll.
1327         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1328         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1329         from tui_vertical_disassem_scroll.
1330         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1331         do_scroll_horizontal>: New methods.
1332         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1333         Likewise.
1334         (struct tui_source_window_base): Add do_scroll_horizontal.
1335         (struct tui_source_window, struct tui_disasm_window): Add
1336         do_scroll_vertical.
1337         (struct tui_data_window, struct tui_cmd_window): Add
1338         do_scroll_horizontal and do_scroll_vertical.
1339         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1340
1341 2019-06-25  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-data.h (struct tui_source_window_base): New struct.
1344         (struct tui_source_window): Derive from tui_source_window_base.
1345         (struct tui_disasm_window): New struct.
1346         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1347         from tui_source_window::clear_detail.
1348         (tui_source_window_base): Rename from tui_source_window.
1349         (~tui_source_window_base): Rename from ~tui_source_window.
1350         (tui_alloc_win_info): Create a tui_disasm_window.
1351
1352 2019-06-25  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-data.h (struct tui_source_window)
1355         (struct tui_data_window): Declare destructors.
1356         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1357         destructors.
1358         (tui_win_info): Simplify.
1359
1360 2019-06-25  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-winsource.c (tui_display_main)
1363         (tui_update_source_windows_with_addr)
1364         (tui_update_all_breakpoint_info): Update.
1365         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1366         (new_height_ok, parse_scrolling_args): Update.
1367         * tui/tui-stack.c (tui_show_frame_info): Update.
1368         * tui/tui-data.h (struct tui_list): Remove.
1369         (tui_source_windows): Return a reference to a std::vector.
1370         * tui/tui-data.c (source_windows): Now a std::vector.
1371         (tui_source_windows): Change return type.
1372         (tui_clear_source_windows): Rewrite.
1373         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1374         (tui_free_all_source_wins_content): Rewrite.
1375
1376 2019-06-25  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1379         (struct tui_data_window, struct tui_cmd_window): Declare
1380         clear_detail method.
1381         * tui/tui-data.c (tui_source_window::clear_detail)
1382         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1383         methods.
1384         (tui_clear_win_detail): Simplify.
1385
1386 2019-06-25  Tom Tromey  <tom@tromey.com>
1387
1388         * tui/tui-layout.c (make_source_window, make_disasm_window)
1389         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1390         Return the new window.
1391         (show_source_disasm_command, show_data)
1392         (show_source_or_disasm_and_command): Update.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1397         parameter.  Return the new window.
1398         (show_source_disasm_command): Update and remove NULL check.
1399         (show_source_or_disasm_and_command): Update.
1400
1401 2019-06-25  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-data.h (struct tui_win_info): Make constructor
1408         protected.  Make destructor virtual.  Add initializers.
1409         (tui_source_window, tui_data_window, tui_cmd_window): New
1410         classes.
1411         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1412         constructor.  Add "type" parameter.
1413         (tui_source_window, tui_data_window, tui_cmd_window): New
1414         constructors.
1415         (tui_alloc_win_info): Instantiate the appropriate subclass.
1416
1417 2019-06-25  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-win.c (tui_resize_all): Use delete.
1420         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1421         destructor.
1422         (tui_free_window): Don't declare.
1423         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1424         Update.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-data.h (struct tui_win_info): Add constructor.
1429         * tui/tui-data.c (tui_alloc_win_info): Use new.
1430         (tui_free_window): Use delete.
1431
1432 2019-06-22  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1435         declare.
1436         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1437
1438 2019-06-22  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1441         declare.
1442         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1443
1444 2019-06-22  Tom de Vries  <tdevries@suse.de>
1445
1446         * dwarf2read.c (create_addrmap_from_aranges)
1447         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1448         instead of '%zu'.
1449
1450 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1451
1452         * dwarf2read.h (dwarf2_section_info_def): Remove.
1453         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1454         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1455         std::vector<dwarf2_section_info>.
1456         (struct dwo_file) <~dwo_file>: Remove.
1457         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1458         types field.
1459         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1460         (dwarf2_read_debug_names): Likewise.
1461         (create_debug_types_hash_table): Change parameter type to
1462         array_view, adjust code accordingly.
1463         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1464         (partial_die_info::fixup): Likewise.
1465         (determine_prefix): Likewise.
1466         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1467
1468 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1469
1470         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1471         gdb_bfd_ref_ptr.
1472         <~dwo_file>: Remove call to gdb_bfd_unref.
1473         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1474         gdb_bfd_ref_ptr::get.
1475
1476 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1477
1478         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1479         type to htab_up.
1480         * dwarf2read.c (struct dwo_file): Initialize fields.
1481         <~dwo_file>: New.
1482         (free_dwo_file): Remove, move content to ~dwo_file.
1483         (struct dwo_file_deleter): Remove.
1484         (dwo_file_up>: Remove custom deleter.
1485         (free_dwo_files): Remove.
1486         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1487         dwo_files.
1488         (process_skeletonless_type_units): Call unique_ptr::get.
1489         (allocate_dwo_file_hash_table): Add deleter to created hash
1490         table.  Change return type to htab_up.
1491         (lookup_dwo_file_slot): Don't memset dwo_file, call
1492         unique_ptr::get.
1493         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1494         (create_dwo_unit_in_dwp_v2): Likewise.
1495         (open_and_init_dwo_file): Likewise.
1496         (free_dwo_file_from_slot): Remove.
1497
1498 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1499
1500         * dwarf2read.h (struct dwarf2_section_info) <readin,
1501         is_virtual>: Change type to bool.
1502         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1503         true instead of 1.
1504
1505 2019-06-19  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-data.h (tui_init_content_element): Don't declare.
1508
1509 2019-06-19  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-data.h (tui_init_win_info): Don't declare.
1512
1513 2019-06-19  Tom de Vries  <tdevries@suse.de>
1514
1515         * dwarf2read.h (abstract_to_concrete): Change type to
1516         std::unordered_map<sect_offset, std::vector<sect_offset>,
1517         gdb::hash_enum<sect_offset>>.
1518
1519 2019-06-19  Tom Tromey  <tromey@adacore.com>
1520
1521         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1522         EVAL_AVOID_SIDE_EFFECTS specially.
1523
1524 2019-06-19  Tom Tromey  <tromey@adacore.com>
1525
1526         * source-cache.c (highlighter): New global.
1527         (source_cache::get_source_lines): Create a highlighter on demand.
1528
1529 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * defs.h (deprecated_interactive_hook): Delete declaration.
1532         * interps.c (clear_interpreter_hooks): Remove use of
1533         deprecated_interactive_hook.
1534         * top.c (deprecated_interactive_hook): Delete definition.
1535         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1536
1537 2019-06-18  Tom de Vries  <tdevries@suse.de>
1538
1539         PR gdb/24515
1540         * dwarf2read.h (abstract_to_concrete): Change type from
1541         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1542         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1543         * dwarf2read.c (read_variable): Update.
1544         (dwarf2_fetch_die_loc_sect_off): Update.
1545
1546 2019-06-17  Tom de Vries  <tdevries@suse.de>
1547
1548         PR gdb/24617
1549         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1550         accessing parent[parent_len - 1].
1551
1552 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1553
1554         PR gdb/24364
1555         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1556         call dtrace_process_dof with NULL dof.
1557
1558 2019-06-16  Tom de Vries  <tdevries@suse.de>
1559
1560         PR gdb/24445
1561         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1562
1563 2019-06-16  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1566         (make_all_visible): Use address of member.
1567
1568 2019-06-16  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1571         (tui_free_window, free_content, free_content_elements): Remove
1572         unnecessary cast.
1573         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1574         cast.
1575         * tui/tui-regs.c (tui_show_register_group)
1576         (tui_display_registers_from, tui_display_reg_element_at_line):
1577         Remove unnecessary cast.
1578
1579 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * linux-nat.c (normal_mask): Delete.
1582         (_initialize_linux_nat): Don't initialise normal_mask.
1583
1584 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1585
1586         PR gdb/24445
1587         * dwarf-index-write.h (write_psymtabs_to_index): Add
1588         dwz_basename parameter.
1589         * dwarf-index-write.c (write_gdbindex): Move file writing to
1590         write_gdbindex_1.  Change return type void.
1591         (assert_file_size): Move up, remove filename parameter.
1592         (write_gdbindex_1): New function.
1593         (write_debug_names): Change return type to void, call
1594         assert_file_size.
1595         (struct index_wip_file): New struct.
1596         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1597         file logic to index_wip_file.  Write index for dwz file if
1598         needed.
1599         (save_gdb_index_command): Pass basename of dwz file, if present.
1600         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1601         build-id of dwz file, if present.
1602         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1603         (dwarf2_get_dwz_file): Likewise.
1604         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1605         (dwarf2_get_dwz_file): Likewise.
1606
1607 2019-06-16  Tom Tromey  <tom@tromey.com>
1608
1609         * coffread.c (process_coff_symbol): Use xstrdup.
1610         * value.c (create_internalvar): Use xstrdup.
1611
1612 2019-06-16  Tom Tromey  <tom@tromey.com>
1613
1614         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1615         * breakpoint.c (stopin_command, stopat_command)
1616         (until_break_command, decode_location_default): Remove unnecessary
1617         cast.
1618         * utils.c (subset_compare): Remove unnecessary cast.
1619         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1620         cast.
1621         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1622         cast.
1623         * infcmd.c (path_command): Remove unnecessary cast.
1624         * coffread.c (decode_type): Remove unnecessary cast.
1625         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1626         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1627         * tui/tui-stack.c (tui_show_locator_content)
1628         (tui_show_frame_info): Remove unnecessary cast.
1629         * tui/tui-win.c (tui_scroll_forward_command)
1630         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1631         (parse_scrolling_args): Remove unnecessary cast.
1632         * tui/tui-data.c (init_win_info, tui_del_window)
1633         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1634         (free_content_elements): Remove unnecessary cast.
1635         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1636         unnecessary cast.
1637         * tui/tui-source.c (tui_set_source_content)
1638         (tui_vertical_source_scroll): Remove unnecessary cast.
1639         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1640         cast.
1641         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1642         * tui/tui-regs.c (tui_display_registers_from)
1643         (tui_display_register): Remove unnecessary cast.
1644         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1645         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1646         (make_visible): Remove unnecessary cast.
1647         * tui/tui-winsource.c (tui_erase_source_content)
1648         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1649         unnecessary cast.
1650         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1651         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1652         * stabsread.c (read_type, read_array_type, read_range_type):
1653         Remove unnecessary cast.
1654         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1655         (parse_symbol, parse_type, upgrade_type, parse_external)
1656         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1657         unnecessary cast.
1658         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1659
1660 2019-06-16  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-data.c (tui_alloc_generic_win_info)
1663         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1664         checks.
1665
1666 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1667             Andrew Burgess  <andrew.burgess@embecosm.com>
1668
1669         * f-typeprint.c (f_print_type): Don't return early for not
1670         associated or not allocated types.
1671         (f_type_print_varspec_suffix): Add print_rank parameter and print
1672         ranks of array types in case they dangling.
1673         (f_type_print_base): Add print_rank parameter.
1674
1675 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1676
1677         * NEWS: Mention new MI commands.
1678         * break-catch-throw.c (enum exception_event_kind): Move to
1679         breakpoint.h.
1680         (print_mention_exception_catchpoint): Output text as a single
1681         message.
1682         (catch_exception_command_1): Rename to...
1683         (catch_exception_event): ...this, make non-static, update header
1684         command, and change some parameter types.
1685         (catch_catch_command): Update for changes to
1686         catch_exception_command_1.
1687         (catch_throw_command): Likewise.
1688         (catch_rethrow_command): Likewise.
1689         * breakpoint.c (enum exception_event_kind): Delete.
1690         * breakpoint.h (enum exception_event_kind): Moved here from
1691         break-catch-throw.c.
1692         (catch_exception_event): Declare.
1693         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1694         (mi_cmd_catch_throw): New function.
1695         (mi_cmd_catch_rethrow): New function.
1696         (mi_cmd_catch_catch): New function.
1697         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1698         'catch-catch' entries.
1699         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1700         (mi_cmd_catch_rethrow): Declare.
1701         (mi_cmd_catch_catch): Declare.
1702
1703 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * annotate.c (annotate_source_line): Change return type to void,
1706         update implementation to match.
1707         * annotate.h (annotate_source_line): Change return type to void,
1708         update header comment.
1709         * stack.c (print_frame_info): Don't change what frame information
1710         is printed based on whether annotations are on or not.
1711
1712 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1713
1714         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1715         (annotate_source): Make static.
1716         (annotate_source_line): Moved from source.c and renamed from
1717         identify_source_line.  Update the return type.
1718         * annotate.h (annotate_source): Delete declaration.
1719         (annotate_source_line): Declaration moved from source.h, and
1720         renamed from identify_source_line.  Return type updated.
1721         * source.c (identify_source_line): Moved to annotate.c and renamed
1722         to annotate_source_line.
1723         (info_line_command): Remove check of annotation_level.
1724         * source.h (identify_source_line): Move declaration to annotate.h
1725         and rename to annotate_source_line.
1726         * stack.c: Add 'annotate.h' include.
1727         (print_frame_info): Remove check of annotation_level before
1728         calling annotate_source_line.
1729
1730 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1731
1732         * source-cache.c (source_cache::get_plain_source_lines): Use
1733         open_source_file_with_line_charpos instead of just
1734         open_source_file, remove call to find_source_lines.
1735         (source_cache::get_source_lines): Likewise.
1736         * source.c (find_source_lines): Make static.
1737         (get_filename_and_charpos): Renamed into...
1738         (open_source_file_with_line_charpos): ..this along with changes to
1739         return a scoped_fd, and some other minor clean ups.
1740         (identify_source_line): Use open_source_file_with_line_charpos.
1741         (search_command_helper): Use open_source_file_with_line_charpos
1742         instead of just open_source_file, remove call to
1743         find_source_lines.
1744         * source.h (open_source_file_with_line_charpos): Declare new
1745         function.
1746         (find_source_lines): Delete declaration.
1747
1748 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * source.c (get_filename_and_charpos): Remove fullname
1751         parameter.
1752         (identify_source_line): Update call to get_filename_and_charpos.
1753
1754 2019-06-14  Tom Tromey  <tromey@adacore.com>
1755
1756         PR gdb/24502:
1757         * ui-style.h (skip_ansi_escape): Update comment.
1758         * ui-file.h (class no_terminal_escape_file): New class.
1759         * ui-file.c (no_terminal_escape_file::write)
1760         (no_terminal_escape_file::puts): New methods.
1761         * cli/cli-logging.c (handle_redirections): Use
1762         no_terminal_escape_file.
1763
1764 2019-06-14  Tom Tromey  <tromey@adacore.com>
1765
1766         * NEWS: Move convenience variable news above Python news.
1767
1768 2019-06-14  Tom Tromey  <tom@tromey.com>
1769
1770         * gnulib: Move directory to top-level.
1771         * configure.ac: Don't configure gnulib.
1772         * configure: Rebuild.
1773         * common/common-defs.h: Use new path to gnulib.
1774         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1775         (GNULIB_H): Remove.
1776         (INCGNU): Look in new gnulib location.
1777         (HFILES_NO_SRCDIR): Remove gnulib files.
1778         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1779         (generated_files): Remove GNULIB_H.
1780         ($(LIBGNU), all-lib): Remove targets.
1781         (distclean): Don't mention GNULIB_BUILDDIR.
1782         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1783
1784 2019-06-14  Tom Tromey  <tromey@adacore.com>
1785
1786         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1787         Warn if symbol file does not provide any symbols.
1788
1789 2019-06-14  Tom Tromey  <tromey@adacore.com>
1790
1791         * source.c (find_and_open_source): Respect basenames_may_differ.
1792
1793 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * annotate.c (annotate_breakpoints_invalid): Make use of
1796         scoped_restore_terminal_state.
1797         (annotate_frames_invalid): Likewise.
1798
1799 2019-06-14  Tom Tromey  <tromey@adacore.com>
1800
1801         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1802         allow assignment to an internalvar.
1803
1804 2019-06-14  Tom Tromey  <tromey@adacore.com>
1805
1806         * ada-lex.l: Allow "_" in attribute names.
1807
1808 2019-06-14  Tom Tromey  <tromey@adacore.com>
1809
1810         PR gdb/24653:
1811         * regcache.c (registers_changed): Don't call alloca.
1812         * top.c (execute_command): Don't call alloca.
1813
1814 2019-06-13  Pedro Alves  <palves@redhat.com>
1815
1816         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1817         'expression'.  When parsing an expression, error out if there's
1818         junk after "unlimited".
1819         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1820         (do_set_command): Adjust calls to is_unlimited_literal.
1821
1822 2019-06-13  Pedro Alves  <palves@redhat.com>
1823
1824         * compile/compile.c (make_compile_options_def_group): Add braces
1825         around array_view initializer.
1826         * thread.c (make_thread_apply_all_options_def_group)
1827         (make_thread_apply_all_options_def_group): Likewise.
1828
1829 2019-06-13  Pedro Alves  <palves@redhat.com>
1830
1831         * NEWS (New commands): Mention "maint test-options
1832         require-delimiter", "maint test-options unknown-is-error", "maint
1833         test-options unknown-is-operand" and "maint show
1834         test-options-completion-result".
1835         (New command options, command completion): New section.
1836         (Completion improvements): New section.
1837         Mention that you can abbreviate "unlimited".
1838
1839 2019-06-13  Pedro Alves  <palves@redhat.com>
1840
1841         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1842         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1843         * unittests/cli-utils-selftests.c (test_parse_flags)
1844         (test_parse_flags_qcs): Delete.
1845         (test_cli_utils): Don't call deleted functions.
1846
1847 2019-06-13  Pedro Alves  <palves@redhat.com>
1848
1849         * thread.c: Include "cli/cli-option.h".
1850         (tp_array_compar_ascending): Global.
1851         (tp_array_compar): Delete function.
1852         (tp_array_compar_ascending, tp_array_compar_descending): New
1853         functions.
1854         (ascending_option_def, qcs_flag_option_def)
1855         (thr_qcs_flags_option_defs)
1856         (make_thread_apply_all_options_def_group)
1857         (make_thread_apply_options_def_group): New.
1858         (thread_apply_all_command): Use gdb::option::process_options.
1859         (thread_apply_command_completer)
1860         (thread_apply_all_command_completer): New.
1861         (thread_apply_command): Use gdb::option::process_options.
1862         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1863         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1864         to generate help text of "thread apply".  Adjust "taas"'s help.
1865         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1866         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1867
1868 2019-06-13  Pedro Alves  <palves@redhat.com>
1869
1870         * thread.c (thread_apply_command): Check for invalid TID with
1871         isdigit instead of !isalpha.
1872
1873 2019-06-13  Pedro Alves  <palves@redhat.com>
1874
1875         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1876         (validate_flags_qcs): New.
1877         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1878         (validate_flags_qcs): Declare.
1879         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1880         (make_frame_apply_options_def_group): New.
1881         (frame_apply_command_count): Process options with
1882         gdb::option::process_options.
1883         (frame_apply_completer): New.
1884         (frame_apply_level_completer, frame_apply_all_completer)
1885         (frame_apply_completer): New.
1886         (_initialize_stack): Update help of "frame apply", "frame apply
1887         level", "frame apply all" and "faas" to mention supported options
1888         and install command completers.
1889         * stack.h (frame_apply_all_completer): Declare.
1890         * thread.c: Include "stack.h".
1891         (tfaas_command): Add "--".
1892         (_initialize_thread): Update help "tfaas" to mention supported
1893         options and install command completer.
1894
1895 2019-06-13  Pedro Alves  <palves@redhat.com>
1896
1897         * completer.c (complete_nested_command_line): New.
1898         (gdb_completion_word_break_characters_throw): Add assertion.
1899         * completer.h (complete_nested_command_line): Declare.
1900
1901 2019-06-13  Pedro Alves  <palves@redhat.com>
1902
1903         * stack.c (parse_backtrace_qualifiers): New.
1904         (backtrace_command): Use it.
1905         (backtrace_command_completer): Complete on qualifiers.
1906
1907 2019-06-13  Pedro Alves  <palves@redhat.com>
1908
1909         * frame.c: Include "cli/cli-option.h.
1910         (user_set_backtrace_options): New.
1911         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1912         Delete.
1913         (get_prev_frame): Adjust.
1914         (boolean_option_def, uinteger_option_def)
1915         (set_backtrace_option_defs): New.
1916         (_initialize_frame): Adjust and use
1917         gdb::option::add_setshow_cmds_for_options to install "set
1918         backtrace past-main" and "set backtrace past-entry".
1919         * frame.h: Include "cli/cli-option.h".
1920         (struct frame_print_options): Forward declare.
1921         (print_frame_arguments_all, print_frame_arguments_scalars)
1922         (print_frame_arguments_none): Declare.
1923         (print_entry_values): Delete declaration.
1924         (struct frame_print_options, user_frame_print_options): New.
1925         (struct set_backtrace_options): New.
1926         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1927         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1928         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1929         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1930         (list_args_or_locals): Add frame_print_options parameter.
1931         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1932         * python/py-framefilter.c (enumerate_args): Pass down
1933         USER_FRAME_PRINT_OPTIONS.
1934         * stack.c: Include "cli/cli-option.h".
1935         (print_frame_arguments_all, print_frame_arguments_scalars)
1936         (print_frame_arguments_none): Declare.
1937         (print_raw_frame_arguments, print_entry_values): Delete.
1938         (user_frame_print_options): New.
1939         (boolean_option_def, enum_option_def, frame_print_option_defs):
1940         New.
1941         (struct backtrace_cmd_options): New.
1942         (bt_flag_option_def): New.
1943         (backtrace_command_option_defs): New.
1944         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1945         (print_frame_arg, read_frame_arg, print_frame_args)
1946         (print_frame_info, print_frame): Add frame_print_options parameter
1947         and use it.
1948         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1949         (backtrace_command_1): Add frame_print_options and
1950         backtrace_cmd_options parameters and use them.
1951         (make_backtrace_options_def_group): New.
1952         (backtrace_command): Process command options with
1953         gdb::option::process_options.
1954         (backtrace_command_completer): New.
1955         (_initialize_stack): Extend "backtrace"'s help to mention
1956         supported options.  Install completer for "backtrace".
1957         Install some settings commands with add_setshow_cmds_for_options.
1958
1959 2019-06-13  Pedro Alves  <palves@redhat.com>
1960
1961         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1962         and that "set/show print raw frame-arguments" are now deprecated.
1963
1964         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1965         command.
1966         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1967         * stack.c (_initialize_stack): Install "set/show print
1968         raw-frame-arguments", and deprecate "set/show print raw
1969         frame-arguments".
1970         * valprint.c (_initialize_valprint): Deprecate "set/show print
1971         raw".
1972
1973 2019-06-13  Pedro Alves  <palves@redhat.com>
1974
1975         * compile/compile.c (struct compile_options): New.
1976         (compile_flag_option_def, compile_command_option_defs)
1977         (make_compile_options_def_group): New.
1978         (compile_file_command): Handle options with
1979         gdb::option::process_options.
1980         (compile_file_command_completer): New function.
1981         (compile_code_command): Handle options with
1982         gdb::option::process_options.
1983         (compile_code_command_completer): New function.
1984         (_initialize_compiler): Install completers for "compile code" and
1985         "compile file".  Mention available options in "compile code" and
1986         "compile code"'s help.
1987         * completer.c (advance_to_completion_word): New, factored out from
1988         ...
1989         (advance_to_expression_complete_word_point): ... this.
1990         (advance_to_filename_complete_word_point): New.
1991         * completer.h (advance_to_filename_complete_word_point): New
1992         declaration.
1993
1994 2019-06-13  Pedro Alves  <palves@redhat.com>
1995
1996         * compile/compile.c: Include "cli/cli-option.h".
1997         (compile_print_value): Scope data pointer is now a
1998         value_print_options pointer; adjust.
1999         (compile_print_command): Process options.  Scope data pointer is
2000         now a value_print_options pointer; adjust.
2001         (_initialize_compile): Update "compile print"'s help to include
2002         supported options.  Install a completer for "compile print".
2003         * cp-valprint.c (show_vtblprint, show_objectprint)
2004         (show_static_field_print): Delete.
2005         (_initialize_cp_valprint): Don't install "set print
2006         static-members", "set print vtbl", "set print object" here.
2007         * printcmd.c: Include "cli/cli-option.h" and
2008         "common/gdb_optional.h".
2009         (print_command_parse_format): Rework to fill in a
2010         value_print_options instead of a format_data.
2011         (print_value): Change parameter type from format_data pointer to
2012         value_print_options reference.  Adjust.
2013         (print_command_1): Process options.  Adjust to pass down a
2014         value_print_options.
2015         (print_command_completer): New.
2016         (_initialize_printcmd): Install print_command_completer as
2017         handle_brkchars completer for the "print" command.  Update
2018         "print"'s help to include supported options.
2019         * valprint.c: Include "cli/cli-option.h".
2020         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2021         here from cp-valprint.c.
2022         (boolean_option_def, uinteger_option_def)
2023         (value_print_option_defs, make_value_print_options_def_group):
2024         New.  Use gdb::option::add_setshow_cmds_for_options to install
2025         "set print elements", "set print null-stop", "set print repeats",
2026         "set print pretty", "set print union", "set print array", "set
2027         print address", "set print symbol", "set print array-indexes".
2028         * valprint.h: Include <string> and "cli/cli-option.h".
2029         (make_value_print_options_def_group): Declare.
2030         (print_value): Change parameter type from format_data pointer to
2031         value_print_options reference.
2032         (print_command_completer): Declare.
2033
2034 2019-06-13  Pedro Alves  <palves@redhat.com>
2035
2036         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2037         (COMMON_SFILES): Add maint-test-settings.c.
2038         * cli/cli-decode.c (boolean_enums): New global, factored out from
2039         ...
2040         (add_setshow_boolean_cmd): ... here.
2041         * cli/cli-decode.h (boolean_enums): Declare.
2042         * cli/cli-option.c: New file.
2043         * cli/cli-option.h: New file.
2044         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2045         factored out from ...
2046         (parse_cli_boolean_value(const char *)): ... this.
2047         (is_unlimited_literal): Change parameter type to pointer to
2048         pointer.  Adjust and advance ARG pointer.
2049         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2050         (parse_cli_var_enum): New, factored out from ...
2051         (do_set_command): ... this.  Adjust.
2052         * cli/cli-setshow.h (parse_cli_boolean_value)
2053         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2054         (parse_cli_var_enum): Declare.
2055         * cli/cli-utils.c: Include "cli/cli-option.h".
2056         (get_ulongest): New.
2057         * cli/cli-utils.h (get_ulongest): Declare.
2058         (check_for_argument): New overloads.
2059         * maint-test-options.c: New file.
2060
2061 2019-06-13  Pedro Alves  <palves@redhat.com>
2062
2063         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2064         parse a range if "-" is at the end of the string.
2065
2066 2019-06-13  Pedro Alves  <palves@redhat.com>
2067
2068         * cli/cli-setshow.c (parse_auto_binary_operation)
2069         (parse_cli_boolean_value): Don't allow "o".
2070
2071 2019-06-13  Pedro Alves  <palves@redhat.com>
2072
2073         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2074         * NEWS: Mention maint test-settings KIND.
2075         * maint-test-settings.c: New file.
2076
2077 2019-06-13  Pedro Alves  <palves@redhat.com>
2078
2079         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2080         completer.
2081         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2082         "set" completers.
2083
2084 2019-06-13  Pedro Alves  <palves@redhat.com>
2085
2086         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2087         after item.
2088
2089 2019-06-13  Pedro Alves  <palves@redhat.com>
2090
2091         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2092
2093 2019-06-13  Pedro Alves <palves@redhat.com>
2094
2095         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2096         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2097         call.
2098         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2099         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2100         calls.
2101         (check_for_argument): Skip spaces after argument.
2102
2103 2019-06-13  Pedro Alves  <palves@redhat.com>
2104
2105         * thread.c (thread_apply_command): Adjust TID parsing.
2106         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2107         detected before end of string.
2108         (tid_is_in_list): Error out if LIST is invalid.
2109
2110 2019-06-13  Pedro Alves  <palves@redhat.com>
2111
2112         * completer.c (complete_line_internal_1): Rewind completion word
2113         point.
2114         (completion_tracker::advance_custom_word_point_by): Change
2115         parameter type to int.
2116         * completer.h (completion_tracker::advance_custom_word_point_by):
2117         Likewise.
2118
2119 2019-06-13  Pedro Alves  <palves@redhat.com>
2120
2121         * completer.c (advance_to_completion_word): Handle delimiters.
2122
2123 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2124
2125         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2126
2127 2019-06-11  Tom Tromey  <tom@tromey.com>
2128
2129         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2130         (xmalloc_failed): Move to alloc.c.
2131         * alloc.c: New file.
2132         * Makefile.in (COMMON_SFILES): Add alloc.c.
2133
2134 2019-06-11  Tom Tromey  <tom@tromey.com>
2135
2136         * nat/linux-waitpid.c: Don't include server.h.
2137         (linux_debug): Remove.
2138         (my_waitpid): Update.
2139
2140 2019-06-11  Tom Tromey  <tromey@adacore.com>
2141
2142         * infcall.c (_initialize_infcall): Remove trailing newline from
2143         help.
2144         * user-regs.c (_initialize_user_regs): Remove trailing newline
2145         from help.
2146         * typeprint.c (_initialize_typeprint): Remove trailing newline
2147         from help.
2148         * reverse.c (_initialize_reverse): Remove trailing newlines from
2149         help.
2150         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2151         from help.
2152         * language.c (add_set_language_command): Remove trailing newline
2153         from help.
2154         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2155         help.
2156         * disasm.c (_initialize_disasm): Remove trailing newline from
2157         help.
2158         * top.c (init_main): Remove trailing newline from help.
2159         * interps.c (_initialize_interpreter): Remove trailing newline
2160         from help.
2161         * btrace.c (_initialize_btrace): Remove trailing newlines from
2162         help.
2163         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2164         from help.
2165         * python/python.c (_initialize_python): Remove trailing newline
2166         from help.
2167         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2168         help.
2169         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2170         from help.  Reformat some text.
2171         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2172         from help.
2173         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2174         newline from help.
2175
2176 2019-06-11  Tom Tromey  <tromey@adacore.com>
2177
2178         * darwin-nat.c (darwin_decode_exception_message)
2179         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2180
2181 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * valops.c (value_slice): Check for not allocated or not
2184         associated values.
2185
2186 2019-06-10  Tom de Vries  <tdevries@suse.de>
2187
2188         PR gdb/24618
2189         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2190         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2191         invalid.
2192
2193 2019-06-10  Tom de Vries  <tdevries@suse.de>
2194
2195         PR gdb/24611
2196         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2197         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2198
2199 2019-06-10  Tom de Vries  <tdevries@suse.de>
2200
2201         PR symtab/24545
2202         * symtab.c (struct demangled_name_entry): Add language field.
2203         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2204         static minimal symbol".  Set and use language field.
2205
2206 2019-06-10  Tom Tromey  <tromey@adacore.com>
2207
2208         * ada-lang.c (_initialize_ada_language): Update help text.
2209
2210 2019-06-10  Tom Tromey  <tromey@adacore.com>
2211
2212         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2213         with a newline.
2214         * guile/guile.c (handle_boot_error): Don't end warning with a
2215         newline.
2216         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2217         warning with a newline.
2218         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2219         newline.
2220         (s12z_frame_cache): Likewise.
2221         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2222         a newline.
2223         * solib-svr4.c (disable_probes_interface): Don't end warning with
2224         a newline.
2225         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2226         newline.
2227         * python/python.c (do_finish_initialization): Don't end warning
2228         with a newline.
2229
2230 2019-06-10  Tom Tromey  <tom@tromey.com>
2231
2232         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2233         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2234         gdbpy_enter.
2235
2236 2019-06-10  Tom Tromey  <tromey@adacore.com>
2237
2238         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2239         data.
2240         (elf_new_init): Don't call stabsread_new_init.
2241         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2242         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2243         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2244
2245 2019-06-10  Tom de Vries  <tdevries@suse.de>
2246
2247         PR symtab/16264
2248         PR symtab/24517
2249         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2250
2251 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2252
2253         * source.c (find_and_open_source): Also rewrite relative file
2254         names.
2255
2256 2019-04-26  Amos Bird  <amosbird@gmail.com>
2257
2258         * annotate.c (annotate_thread_exited): Add "thread-exited"
2259         annotation.
2260
2261 2019-06-06  Tom Tromey  <tromey@adacore.com>
2262
2263         * maint.h (class scoped_command_stats): Use
2264         DISABLE_COPY_AND_ASSIGN.
2265         <print_time>: New method.
2266         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2267         print_time.
2268         (scoped_command_stats::print_time): New method.
2269
2270 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2273         instructions of lengths 6 or 8 bytes.
2274
2275 2019-06-04  Pedro Alves  <palves@redhat.com>
2276
2277         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2278
2279         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2280         * breakpoint.c (condition_completer): Likewise.
2281         * cli/cli-dump.c (scan_expression): Likewise.
2282         * common/filestuff.c (mkdir_recursive): Likewise.
2283         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2284         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2285         (gdb_abspath): Likewise.
2286         * compile/compile-cplus-types.c
2287         (compile_cplus_instance::decl_name): Likewise.
2288         * completer.c (complete_explicit_location):
2289         (signal_completer, reg_or_group_completer_1): Likewise.
2290         * cp-support.c (cp_remove_params_if_any): Likewise.
2291         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2292         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2293         * infcmd.c (strip_bg_char): Likewise.
2294         * linespec.c (copy_token_string): Likewise.
2295         * mi/mi-main.c (output_cores): Likewise.
2296         * psymtab.c (psymtab_search_name):
2297         * symfile.c (test_set_ext_lang_command): Likewise.
2298         * target.c (target_fileio_read_stralloc): Likewise.
2299         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2300         * value.c (complete_internalvar): Likewise.
2301
2302 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2303
2304         Add objfile property to gdb.Type.
2305         * NEWS: Mention Python API addition.
2306         * python/py-type.c (typy_get_objfile): New method.
2307
2308 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2309
2310         * NEWS: Mention the new set|show style [title|highlight].
2311         Mention changes to "show style", "help" and "apropos".
2312
2313 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2314
2315         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2316         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2317         instead of print_help_for_command.
2318         (print_doc_of_command): New function.
2319         (help_list): Add 'apropos -v word' suggestion.
2320         (print_help_for_command): Style the command name using title style.
2321         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2322         (_initialize_cli_cmds): Describe -v in apropos_command help.
2323
2324 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2325
2326         * cli/cli-style.h (cli_style_option): Add name in constructor,
2327         add m_name class member, add constructor with intensity,
2328         add name class function.
2329         (cli_style_option::add_setshow_commands): Remove name argument.
2330         (highlight_style, title_style): New styles.
2331         * cli/cli-style.c (do_show): New function that shows a style
2332         characteristic styling the style name with itself.
2333         (set_style_name): New function.
2334         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2335         Update all callers according to the changes in cli/cli-style.h.
2336         * utils.h (fputs_highlighted): New function.
2337         * utils.c (fputs_highlighted): Likewise.
2338
2339 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2340
2341         * NEWS: Mention new pipe command and new convenience variables.
2342
2343 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2344
2345         * cli/cli-cmds.c (pipe_command): New function.
2346         (_initialize_cli_cmds): Call add_com for pipe_command.
2347         Define | as an alias for pipe.
2348         (exit_status_set_internal_vars): New function.
2349         (shell_escape): Call exit_status_set_internal_vars.
2350         cli/cli-decode.c (find_command_name_length): Recognize | as
2351         a single character command.
2352
2353 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2354
2355         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2356         top.c (execute_command_to_ui_file): New function, mostly a copy
2357         of execute_command_to_string.
2358         (execute_command_to_string): Implement by calling
2359         execute_command_to_ui_file.
2360
2361 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * top.h (saved_command_line): Remove declaration.
2364         * top.c (previous_saved_command_line, previous_repeat_arguments):
2365         New variables.
2366         (saved_command_line): Make static, define together with other
2367         'repeat variables'.
2368         (dont_repeat): Clear repeat_arguments.
2369         (repeat_previous, get_saved_command_line, save_command_line):
2370         New functions.
2371         (gdb_init): Initialize saved_command_line
2372         and previous_saved_command_line.
2373         * main.c (captured_main_1): Remove saved_command_line initialization.
2374         * event-top.c (handle_line_of_input): Update to use
2375         the new 'repeat' related functions instead of direct access to
2376         saved_command_line.
2377         * command.h (repeat_previous, get_saved_command_line,
2378         save_command_line): New declarations.
2379         (dont_repeat): Add comment.
2380
2381 2019-05-30  Tom Tromey  <tromey@adacore.com>
2382
2383         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2384         Fix comment.
2385         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2386
2387 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2388
2389         PR cli/24587
2390         * completer.c (complete): Initialize variable word.
2391
2392 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2393
2394         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2395         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2396         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2397         'body' is NULL to the outter 'if', protecting the '!is_define'
2398         situation as well.
2399
2400 2019-05-29  Tom Tromey  <tromey@adacore.com>
2401
2402         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2403         (dwarf_unknown): New function.
2404         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2405         (dwarf_type_encoding_name): Use dwarf_unknown.
2406
2407 2019-05-29  Tom Tromey  <tromey@adacore.com>
2408
2409         PR c++/20020:
2410         * cp-valprint.c (cp_print_value_fields): Call
2411         cp_print_static_field inside "try".
2412
2413 2019-05-29  Tom Tromey  <tromey@adacore.com>
2414
2415         * inflow.c (struct terminal_info): Add default operator=.
2416         * configure: Rebuild.
2417         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2418         -Wdeprecated-copy-dtor, -Wredundant-move.
2419
2420 2019-05-29  Tom Tromey  <tromey@adacore.com>
2421
2422         * NEWS: Add entry.
2423         * infcmd.c (print_return_value_1): Handle finish_print
2424         option.
2425         (show_print_finish): New function.
2426         (_initialize_infcmd): Add "set/show print finish" commands.
2427         * valprint.c (user_print_options): Initialize new member.
2428         * valprint.h (struct value_print_options) <finish_print>: New
2429         member.
2430
2431 2019-05-28  Tom Tromey  <tromey@adacore.com>
2432
2433         * ada-lang.c (ada_remove_Xbn_suffix)
2434         (find_old_style_renaming_symbol)
2435         (parse_old_style_renaming): Remove.
2436         (ada_find_renaming_symbol): Don't call
2437         find_old_style_renaming_symbol.
2438         (ada_is_renaming_symbol): Rename from
2439         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2440         bool.  Now static.
2441         (ada_read_var_value): Update and simplify.
2442         * ada-exp.y (write_var_or_type): Remove old code.
2443
2444 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2445
2446         * event-top.c: Remove include comment.
2447         * inflow.c (class scoped_ignore_sigttou): Move from here...
2448         * inflow.h (class scoped_ignore_sigttou): ...to here.
2449         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2450         * top.c:  Remove include comment.
2451
2452 2019-05-27  Tom Tromey  <tom@tromey.com>
2453
2454         * NEWS: Fix typo.
2455
2456 2019-05-22  Tom Tromey  <tromey@adacore.com>
2457
2458         * target.c (target_follow_exec): Constify parameter.
2459         * target-delegates.c: Rebuild.
2460         * remote.c (remote_target::follow_exec): Constify parameter.
2461         * infrun.c (follow_exec): Constify parameter.
2462         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2463         (target_follow_exec): Likewise.
2464
2465 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2466
2467         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2468         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2469
2470 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2471
2472         * NEWS: Add debugredirect and testsuite sections.
2473
2474 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2475
2476         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2477         target descriptions using exclusively floating point register name
2478         aliases.
2479
2480 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         PR gdb/18644:
2483         * f-lang.c (build_fortran_types): Handle the case where
2484         gdbarch_floatformat_for_type returns a nullptr.
2485
2486 2019-05-21  Tom de Vries  <tdevries@suse.de>
2487
2488         PR cli/24587
2489         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2490
2491 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         PR gdb/18644:
2494         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2495         16-byte floats.
2496         * i386-tdep.c (i386_floatformat_for_type): Use
2497         floatformats_ia64_quad for the 16-byte floating point component
2498         within a fortran 32-byte complex number.
2499
2500 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2503         delete default constructor.
2504         (find_partial_die): Update to return const struct.
2505         (partial_die_parent_scope): Move variable declaration into scope
2506         of its use and change its type to auto.
2507         (guess_partial_die_structure_name): Likewise.
2508         (partial_die_info::fixup): Likewise.
2509
2510 2019-05-17  Tom Tromey  <tromey@adacore.com>
2511
2512         * source.c (find_and_open_source): Remove cast.
2513
2514 2019-05-17  Tom Tromey  <tromey@adacore.com>
2515
2516         * annotate.c (annotate_source): Make "filename" const.
2517         * annotate.h (annotate_source): Use const.
2518
2519 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * disasm.c (set_disassembler_options): Send errors to stderr.
2522
2523 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2524
2525         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2526         (cli_interp_base::set_logging): Check debug_redirect.
2527         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2528         * cli/cli-logging.c (debug_redirect): Add static variable.
2529         (pop_output_files): Add default param.
2530         (handle_redirections): Print debug setting.
2531         (show_logging_command): Likewise.
2532         (_initialize_cli_logging): Add debugredirect command.
2533         * interps.c (current_interp_set_logging): Add debug_redirect
2534         parameter.
2535         * interps.h (set_logging): Add debug_redirect parameter.
2536         (current_interp_set_logging): Likewise.
2537         * mi/mi-common.h: Likewise.
2538         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2539
2540 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2541             Tom Tromey  <tromey@adacore.com>
2542
2543         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2544         directly.
2545         * cli/cli-interp.h (make_logging_output): Remove declaration.
2546         * cli/cli-logging.c (make_logging_output): Remove function.
2547         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2548         directly.
2549         * ui-file.c (tee_file::tee_file): Remove bools.
2550         (tee_file::~tee_file): Remove deletes.
2551         * ui-file.h (tee_file): Remove bools.
2552
2553 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2554
2555         * mi/mi-cmds.h (mi_cmd_complete): New function.
2556         * mi/mi-main.c (mi_cmd_complete): Likewise.
2557         * mi/mi-cmds.c: Define new MI command -complete.
2558         * NEWS: Mention new -complete command.
2559
2560 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2561
2562         * completer.h (complete): New function.
2563         * completer.c (complete): Likewise.
2564         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2565         function defined in completer.h.
2566
2567 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2568
2569         * MAINTAINERS (Write After Approval): Add myself.
2570
2571 2019-05-17  Tom de Vries  <tdevries@suse.de>
2572
2573         PR gdb/24094
2574         * dwarf2read.c (struct cu_partial_die_info): New struct.
2575         (find_partial_die): Return cu_partial_die_info.
2576         (partial_die_parent_scope, guess_partial_die_structure_name)
2577         (partial_die_info::fixup): Handle new return type of find_partial_die.
2578
2579 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2580
2581         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2582         "std::string", simplifying the algorithm.
2583
2584 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2585
2586         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2587         (stap_static_probe_ops::get_probes): Likewise.
2588
2589 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2590
2591         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2592         '-')" and "else if".
2593         (stap_parse_single_operand): Join checks for
2594         "gdbarch_stap_parse_special_token_p" and
2595         "gdbarch_stap_parse_special_token" in the same "if" statement.
2596         Invert check when verifying for operation on register
2597         displacement.
2598
2599 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2600
2601         * stap-probe.c (stap_get_opcode): Update comment.
2602         (stap_get_expected_argument_type): Likewise.
2603         (handle_stap_probe): Likewise.
2604
2605 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2606
2607         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2608         return type to 'bool'.  Adjust comment.  Use 'bool' when
2609         appropriate.
2610         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2611         * stap-probe.c (stap_parse_argument_1): Likewise.
2612         (stap_is_operator): Likewise.
2613         (stap_is_generic_prefix): Likewise.
2614         (stap_is_register_prefix): Likewise.
2615         (stap_is_register_indirection_prefix): Likewise.
2616         (stap_is_integer_prefix): Likewise.
2617         (stap_generic_check_suffix): Likewise.
2618         (stap_check_integer_suffix): Likewise.
2619         (stap_check_register_suffix): Likewise.
2620         (stap_check_register_indirection_suffix): Likewise.
2621         (stap_parse_register_operand): Likewise.
2622         (stap_parse_single_operand): Likewise.
2623         (stap_parse_argument_1): Likewise.
2624         (stap_probe::get_argument_count): Likewise.
2625         (stap_is_operator): Likewise.
2626
2627 2019-05-16  Tom Tromey  <tromey@adacore.com>
2628
2629         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2630         keyword to foreach.
2631
2632 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2633
2634         * linux-thread-db.c (try_thread_db_load_1): Change return type
2635         to bool.
2636         (try_thread_db_load): Likewise.
2637         (try_thread_db_load_from_pdir_1): Likewise.
2638         (try_thread_db_load_from_pdir): Likewise.
2639         (try_thread_db_load_from_sdir): Likewise.
2640         (try_thread_db_load_from_dir): Likewise.
2641         (thread_db_load_search): Likewise.
2642         (has_libpthread): Likewise.
2643         (thread_db_load): Likewise.
2644
2645 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2646
2647         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2648         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2649         NULL, and complain/return if that's the case.
2650
2651 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2652
2653         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2654         (advance, posn, abstract_read_memory): New functions.
2655         [struct mem_read_abstraction]: New struct.
2656         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2657
2658 2019-05-14  Tom Tromey  <tromey@adacore.com>
2659
2660         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2661         value is not lval_memory.
2662
2663 2019-05-14  Tom Tromey  <tromey@adacore.com>
2664
2665         * solib.c (info_sharedlibrary_command): Style the file name.
2666
2667 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2668
2669         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2670         (aarch64_vnv_type): Likewise.
2671         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2672         * common/tdesc.c: Likewise.
2673         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2674         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2675         * features/aarch64-fpu.xml: Add ieee half view.
2676         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2677         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2678         * gdbtypes.h (struct builtin_type): Likewise.
2679         (struct objfile_type): Likewise.
2680
2681 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2682
2683         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2684         typo.
2685         * location.h (string_to_event_location): Likewise.
2686
2687 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2688
2689         GDB 8.3 released.
2690
2691 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2692
2693         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2694         New variable declaration.
2695         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2696         New variable.
2697         (print_one_breakpoint): Use ui_out::test_flags and new global
2698         variable to compute use_fixed_output.
2699         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2700         Remove.
2701         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2702         (mi_multi_location_breakpoint_output_fixed): Remove.
2703         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2704         new variable.
2705         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2706         fix_multi_location_breakpoint_output flag if version >= 3.
2707         * ui-out.h (enum ui_out_flag)
2708         <fix_multi_location_breakpoint_output>: New enumerator.
2709
2710 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2711
2712         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2713
2714 2019-05-10  Tom Tromey  <tromey@adacore.com>
2715
2716         * ada-lang.c (catch_ada_completer): New function.
2717         (_initialize_ada_language): Use it.
2718
2719 2019-05-10  Tom Tromey  <tromey@adacore.com>
2720
2721         * thread.c (print_thread_info): Make "requested_threads" const.
2722         * gdbthread.h (print_thread_info): Make "requested_threads"
2723         const.
2724         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2725         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2726
2727 2019-05-08  Tom Tromey  <tom@tromey.com>
2728
2729         * gdbtypes.c (objfile_type_data): Change type.
2730         (objfile_type, _initialize_gdbtypes): Update.
2731
2732 2019-05-08  Tom Tromey  <tom@tromey.com>
2733
2734         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2735         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2736         (_initialize_dwarf2_frame): Update.
2737
2738 2019-05-08  Tom Tromey  <tom@tromey.com>
2739
2740         * objc-lang.c (objc_objfile_data): Change type.
2741         (find_methods): Update.
2742         (_initialize_objc_lang): Remove.
2743
2744 2019-05-08  Tom Tromey  <tom@tromey.com>
2745
2746         * stabsread.c (rs6000_builtin_type_data): Change type.
2747         (rs6000_builtin_type, _initialize_stabsread): Update.
2748
2749 2019-05-08  Tom Tromey  <tom@tromey.com>
2750
2751         * mips-tdep.c (mips_pdr_data): Remove.
2752         (_initialize_mips_tdep): Update.
2753
2754 2019-05-08  Tom Tromey  <tom@tromey.com>
2755
2756         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2757         (hppa_init_objfile_priv_data, read_unwind_info)
2758         (find_unwind_entry, _initialize_hppa_tdep): Update.
2759
2760 2019-05-08  Tom Tromey  <tom@tromey.com>
2761
2762         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2763         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2764         on obstack.
2765         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2766
2767 2019-05-08  Tom Tromey  <tom@tromey.com>
2768
2769         * mdebugread.c (basic_type_data): Change type.
2770         (basic_type, _initialize_mdebugread): Update.
2771
2772 2019-05-08  Tom Tromey  <tom@tromey.com>
2773
2774         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2775
2776 2019-05-08  Tom Tromey  <tom@tromey.com>
2777
2778         * nto-tdep.c (nto_inferior_data_reg): Change type.
2779         (nto_inferior_data): Update.
2780         (nto_inferior_data_cleanup, nto_new_inferior_data)
2781         (_initialize_nto_tdep): Remove.
2782         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2783
2784 2019-05-08  Tom Tromey  <tom@tromey.com>
2785
2786         * ada-lang.c (struct ada_inferior_data): Add initializers.
2787         (ada_inferior_data): Change type.
2788         (ada_inferior_data_cleanup): Remove.
2789         (get_ada_inferior_data, ada_inferior_exit)
2790         (struct ada_pspace_data): Add initializers, destructor.
2791         (ada_pspace_data_handle): Change type.
2792         (get_ada_pspace_data): Update.
2793         (ada_pspace_data_cleanup): Remove.
2794
2795 2019-05-08  Tom Tromey  <tom@tromey.com>
2796
2797         * coffread.c (struct coff_symfile_info): Add initializers.
2798         (coff_objfile_data_key): Move lower.  Change type.
2799         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2800         Update.
2801         (coff_free_info): Remove.
2802
2803 2019-05-08  Tom Tromey  <tom@tromey.com>
2804
2805         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2806         (fbsd_pspace_data_handle): Move lower.  Change type.
2807         (get_fbsd_pspace_data): Update.
2808         (fbsd_pspace_data_cleanup): Remove.
2809         (_initialize_fbsd_tdep): Update.
2810
2811 2019-05-08  Tom Tromey  <tom@tromey.com>
2812
2813         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2814         (get_ada_tasks_pspace_data): Update.
2815         (ada_tasks_pspace_data_cleanup): Remove.
2816         (_initialize_tasks): Update.
2817         (ada_tasks_inferior_data_handle): Change type.
2818         (get_ada_tasks_inferior_data): Update.
2819         (ada_tasks_inferior_data_cleanup): Remove.
2820         (struct ada_tasks_pspace_data): Add initializers.
2821
2822 2019-05-08  Tom Tromey  <tom@tromey.com>
2823
2824         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2825         * symfile-debug.c (debug_sym_get_probes): Change type.
2826         * stap-probe.c (handle_stap_probe):
2827         (stap_static_probe_ops::get_probes): Change type.
2828         * probe.h (class static_probe_ops) <get_probes>: Change type.
2829         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2830         (parse_probes_in_pspace): Update.
2831         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2832         Update.
2833         (any_static_probe_ops::get_probes): Change type.
2834         * elfread.c (elfread_data): New typedef.
2835         (probe_key): Change type.
2836         (elf_get_probes): Likewise.  Update.
2837         (probe_key_free): Remove.
2838         (_initialize_elfread): Update.
2839         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2840         Change type.
2841         (dtrace_process_dof_probe, dtrace_process_dof)
2842         (dtrace_static_probe_ops::get_probe): Change type.
2843
2844 2019-05-08  Tom Tromey  <tom@tromey.com>
2845
2846         * xcoffread.c (struct xcoff_symfile_info): Rename from
2847         coff_symfile_info.  Add initializers.
2848         (xcoff_objfile_data_key): Move lower.  Change type.
2849         (XCOFF_DATA): Rewrite.
2850         (xcoff_free_info): Remove.
2851         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2852         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2853         (xcoff_initial_scan): Update.
2854
2855 2019-05-08  Tom Tromey  <tom@tromey.com>
2856
2857         * solib-svr4.c (struct svr4_info): Add initializers and
2858         destructor.
2859         <probes_table>: Now an htab_up.
2860         (solib_svr4_pspace_data): Change type.
2861         (free_probes_table): Simplify.
2862         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2863         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2864         (probes_table_remove_objfile_probes, register_solib_event_probe)
2865         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2866         (_initialize_svr4_solib): Update.
2867
2868 2019-05-08  Tom Tromey  <tom@tromey.com>
2869
2870         * remote.c (remote_pspace_data): Change type.
2871         (remote_pspace_data_cleanup): Remove.
2872         (get_remote_exec_file, set_pspace_remote_exec_file)
2873         (_initialize_remote): Update.
2874
2875 2019-05-08  Tom Tromey  <tom@tromey.com>
2876
2877         * breakpoint.c (breakpoint_objfile_key): Change type.
2878         (get_breakpoint_objfile_data): Update.
2879         (free_breakpoint_objfile_data): Remove.
2880         (_initialize_breakpoint): Update.
2881
2882 2019-05-08  Tom Tromey  <tom@tromey.com>
2883
2884         * linux-tdep.c (struct linux_info): Add initializers.
2885         (linux_inferior_data): Move.  Change type.
2886         (invalidate_linux_cache_inf): Update.
2887         (linux_inferior_data_cleanup): Remove.
2888         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2889
2890 2019-05-08  Tom Tromey  <tom@tromey.com>
2891
2892         * auxv.c (auxv_inferior_data): Move.  Change type.
2893         (auxv_inferior_data_cleanup): Remove.
2894         (invalidate_auxv_cache_inf): Rewrite.
2895         (get_auxv_inferior_data, _initialize_auxv): Update.
2896
2897 2019-05-08  Tom Tromey  <tom@tromey.com>
2898
2899         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2900         (symfile_debug_objfile_data_key): Change type.
2901         (symfile_debug_installed, debug_qf_has_symbols)
2902         (debug_qf_find_last_source_symtab)
2903         (debug_qf_forget_cached_source_info)
2904         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2905         (debug_qf_print_stats, debug_qf_dump)
2906         (debug_qf_expand_symtabs_for_function)
2907         (debug_qf_expand_all_symtabs)
2908         (debug_qf_expand_symtabs_with_fullname)
2909         (debug_qf_map_matching_symbols)
2910         (debug_qf_expand_symtabs_matching)
2911         (debug_qf_find_pc_sect_compunit_symtab)
2912         (debug_qf_map_symbol_filenames)
2913         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2914         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2915         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2916         (debug_sym_read_linetable, debug_sym_relocate): Update.
2917         (symfile_debug_free_objfile): Remove.
2918         (install_symfile_debug_logging, _initialize_symfile_debug):
2919         Update.
2920
2921 2019-05-08  Tom Tromey  <tom@tromey.com>
2922
2923         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2924         allocate_on_obstack.
2925         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2926         (get_dwarf2_per_objfile): Update.
2927         (set_dwarf2_per_objfile): Remove.
2928         (dwarf2_has_info, dwarf2_get_section_info): Update.
2929         (dwarf2_free_objfile): Remove.
2930         (_initialize_dwarf2_read): Update.
2931
2932 2019-05-08  Tom Tromey  <tom@tromey.com>
2933
2934         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2935         initializers.
2936         <unsupported_script_warning_printed,
2937         script_not_found_warning_printed>: Now bool.
2938         (auto_load_pspace_data): Change type.
2939         (~auto_load_pspace_info): Rename from
2940         auto_load_pspace_data_cleanup.
2941         (get_auto_load_pspace_data, init_loaded_scripts_info)
2942         (clear_section_scripts, maybe_print_unsupported_script_warning)
2943         (maybe_print_script_not_found_warning, _initialize_auto_load):
2944         Update.
2945
2946 2019-05-08  Tom Tromey  <tom@tromey.com>
2947
2948         * objfiles.c (objfile_pspace_info): Add destructor and
2949         initializers.
2950         (objfiles_pspace_data): Change type.
2951         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2952         (get_objfile_pspace_data): Update.
2953         (objfiles_bfd_data): Change type.
2954         (get_objfile_bfd_data): Update.
2955         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2956
2957 2019-05-08  Tom Tromey  <tom@tromey.com>
2958
2959         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2960         Change type.
2961         (get_catch_syscall_inferior_data): Update.
2962         (catch_syscall_inferior_data_cleanup): Remove.
2963         (_initialize_break_catch_syscall): Update.
2964
2965 2019-05-08  Tom Tromey  <tom@tromey.com>
2966
2967         * inflow.c (struct terminal_info): Add destructor and
2968         initializers.
2969         (inflow_inferior_data): Change type.
2970         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2971         (get_inflow_inferior_data, inflow_inferior_exit)
2972         (swap_terminal_info, _initialize_inflow): Update.
2973
2974 2019-05-08  Tom Tromey  <tom@tromey.com>
2975
2976         * target-dcache.c (target_dcache_cleanup): Remove.
2977         (target_dcache_aspace_key): Change type.
2978         (target_dcache_init_p, target_dcache_invalidate)
2979         (target_dcache_get, target_dcache_get_or_init)
2980         (_initialize_target_dcache): Update.
2981         * dcache.h (struct dcache_deleter): New.
2982
2983 2019-05-08  Tom Tromey  <tom@tromey.com>
2984
2985         * symtab.c (struct symbol_cache): Add destructor and
2986         initializers.
2987         (symbol_cache_key): Move.  Change type.
2988         (make_symbol_cache, free_symbol_cache): Remove.
2989         (get_symbol_cache): Update.
2990         (symbol_cache_cleanup): Remove.
2991         (ALL_PSPACES, symbol_cache_flush)
2992         (maintenance_print_symbol_cache)
2993         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2994         Update.
2995
2996 2019-05-08  Tom Tromey  <tom@tromey.com>
2997
2998         * symtab.c (struct main_info): Add destructor and initializers.
2999         (main_progspace_key): Move.  Change type.
3000         (get_main_info): Update.
3001         (main_info_cleanup): Remove.
3002         (_initialize_symtab): Update.
3003
3004 2019-05-08  Tom Tromey  <tom@tromey.com>
3005
3006         * registry.h (DECLARE_REGISTRY): Define the _key class.
3007
3008 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * NEWS: Merge two 'New commands' sections.
3011
3012 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3013
3014         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3015         parameter and use Ada language definition instead.
3016         (ada_val_print_ptr): Remove unused language parameter.
3017         (ada_val_print_num): Remove language parameter and use Ada language
3018         definition instead.
3019         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3020         parameter.
3021         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3022         parameter and use Ada language definition instead.
3023         (ada_val_print_1): Update all ada_val_print_xxx calls.
3024         Remove language parameter.
3025         (ada_val_print): Update ada_val_print_1 call.
3026
3027 2019-05-08  Tom Tromey  <tromey@adacore.com>
3028
3029         * remote.c (remote_hw_watchpoint_limit)
3030         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3031         Now static.
3032
3033 2019-05-08  Tom Tromey  <tromey@adacore.com>
3034
3035         * maint.c (_initialize_maint_cmds): Move initialization code to
3036         remote.c.
3037         (watchdog, show_watchdog): Move to remote.c.
3038         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3039         "watchdog" static.
3040         (_initialize_remote): Move initialization code from maint.c.
3041         * defs.h (watchdog): Don't declare.
3042
3043 2019-05-08  Tom Tromey  <tromey@adacore.com>
3044
3045         * tui/tui-interp.c: Include main.h.
3046         * interps.c: Include main.h.
3047         * main.h (interpreter_p): Declare.
3048         * defs.h (interpreter_p): Don't declare.
3049
3050 2019-05-08  Tom Tromey  <tromey@adacore.com>
3051
3052         * dwarf2loc.c: Include dwarf2read.h.
3053         * defs.h (read_unsigned_leb128): Don't declare.
3054         * dwarf2read.h (read_unsigned_leb128): Declare.
3055
3056 2019-05-08  Tom Tromey  <tromey@adacore.com>
3057
3058         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3059         method.
3060
3061 2019-05-08  Tom Tromey  <tromey@adacore.com>
3062
3063         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3064         when no wrap column is set.
3065
3066 2019-05-08  Tom Tromey  <tromey@adacore.com>
3067
3068         * c-lang.c (c_get_string): Handle non-C-style arrays.
3069
3070 2019-05-08  Tom Tromey  <tromey@adacore.com>
3071
3072         * typeprint.c (print_offset_data::update): Print the bit offset,
3073         not the number of bits remaining.
3074
3075 2019-05-08  Tom Tromey  <tromey@adacore.com>
3076
3077         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3078         padding at end of comment.
3079
3080 2019-05-08  Tom Tromey  <tromey@adacore.com>
3081
3082         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3083         Compare main types.
3084
3085 2019-05-06  Tom Tromey  <tom@tromey.com>
3086
3087         * common/scoped_mmap.c: Include common-defs.h.
3088         * common/scoped_mmap.h: Don't include config.h.
3089
3090 2019-05-04  Tom Tromey  <tom@tromey.com>
3091
3092         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3093         (struct aarch64_call_info): Add initializers.
3094         <si>: Now a std::vector.
3095         (pass_on_stack, aarch64_push_dummy_call): Update.
3096
3097 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3098             Tom Tromey  <tom@tromey.com>
3099
3100         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3101         (ppc_threads): Now a std::vector.  Now static.
3102         (hwdebug_find_thread_points_by_tid)
3103         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3104         Update.
3105
3106 2019-05-04  Tom Tromey  <tom@tromey.com>
3107
3108         * arc-tdep.c (arc_tdesc_init): Return bool.
3109
3110 2019-05-04  Tom Tromey  <tom@tromey.com>
3111
3112         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3113         Use gdb_assert_not_reached.
3114
3115 2019-05-04  Tom Tromey  <tom@tromey.com>
3116
3117         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3118         "false".
3119
3120 2019-05-04  Tom Tromey  <tom@tromey.com>
3121
3122         * arc-tdep.c (arc_tdesc_init): Use bool.
3123
3124 2019-05-04  Tom Tromey  <tom@tromey.com>
3125
3126         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3127
3128 2019-05-04  Tom Tromey  <tom@tromey.com>
3129
3130         * cli/cli-cmds.c (valid_command_p): Return bool.
3131
3132 2019-05-04  Tom Tromey  <tom@tromey.com>
3133
3134         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3135         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3136
3137 2019-05-04  Raul Tambre  <raul@tambre.ee>
3138
3139         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3140         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3141         operator for comparison.
3142
3143 2019-05-04  Tom Tromey  <tom@tromey.com>
3144
3145         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3146         (lookup_partial_symbol, print_partial_symbols)
3147         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3148         (psymbol_compare): Update.
3149         (add_psymbol_to_bcache): Clear the entire psymbol.
3150         (maintenance_check_psymtabs): Update.
3151         * psympriv.h (struct partial_symbol): Don't derive from
3152         general_symbol_info.
3153         <obj_section, unrelocated_address, address,
3154         set_unrelocated_address>: Update.
3155         <ginfo>: New member.
3156         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3157         (debug_names::write_psymbols): Update.
3158
3159 2019-05-04  Tom de Vries  <tdevries@suse.de>
3160
3161         * contrib/cc-with-tweaks.sh: Support -n arg.
3162
3163 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3164
3165         * corelow.c (core_target::detach): Ensure frame cache and
3166         register caches are cleared.
3167         inferior.c (exit_inferior_1): Likewise.
3168
3169 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3170             Tom Tromey  <tom@tromey.com>
3171
3172         * dictionary.c (collate_pending_symbols_by_language): Remove
3173         "struct" from foreach.
3174         * symtab.c (lookup_global_symbol_from_objfile)
3175         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3176         foreach.
3177         * ser-tcp.c (net_open): Remove "struct" from foreach.
3178         * objfiles.c (objfile_relocate, objfile_rebase)
3179         (objfile_has_symbols): Remove "struct" from foreach.
3180         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3181         from foreach.
3182         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3183         foreach.
3184         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3185         "struct" from foreach.
3186         * ada-lang.c (create_excep_cond_exprs)
3187         (ada_exception_catchpoint_cond_string): Remove "struct" from
3188         foreach.
3189
3190 2019-05-03  Tom Tromey  <tromey@adacore.com>
3191
3192         * ada-exp.y (convert_char_literal): Check suffix of each
3193         enumerator.
3194
3195 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3196
3197         PR ada/21406:
3198         * ada-exp.y (yywrap): Don't define.
3199         * ada-lex.l (%option): Add noyywrap
3200         (yywrap): Remove.
3201
3202 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3203
3204         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3205         _WIN32_WINNT to the XP level, unless already defined to a higher
3206         level.
3207
3208         * unittests/parse-connection-spec-selftests.c:
3209         * ser-tcp.c:
3210         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3211         override.
3212
3213         * symfile.c (find_separate_debug_file): Remove colon from the
3214         drive spec of DOS/Windows file names of the target, so that the
3215         file name produced from DEBUGDIR and the target's directory will
3216         be valid on DOS/Windows systems.
3217
3218 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * rust-lang.c (val_print_struct): Handle printing structures
3221         containing strings.
3222
3223 2019-05-02  Tom Tromey  <tromey@adacore.com>
3224
3225         * valarith.c (_initialize_valarith): Remove.
3226
3227 2019-05-01  Tom Tromey  <tromey@adacore.com>
3228
3229         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3230         bitfields.
3231
3232 2019-05-01  Tom Tromey  <tromey@adacore.com>
3233
3234         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3235         for big-endian copies.
3236
3237 2019-04-30  Ali Tamur  <tamur@google.com>
3238         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3239         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3240         (read_3_bytes): New function.
3241
3242 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3243
3244         * windows-nat.c (main_thread_id): Delete.
3245         (handle_output_debug_string): Replace main_thread_id by
3246         current_event.dwThreadId.
3247         (fake_create_process): Likewise.
3248         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3249         Do not set main_thread_id.
3250         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3251         current_event.dwThreadId.
3252         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3253
3254 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3255
3256         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3257         Use current_event.dwThreadId instead of main_thread_id.
3258
3259 2019-04-30  Tom Tromey  <tromey@adacore.com>
3260
3261         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3262         (create_excep_cond_exprs): Iterate over program spaces.
3263         (ada_exception_catchpoint_cond_string): Examine all minimal
3264         symbols for exception types.
3265
3266 2019-04-30  Tom Tromey  <tromey@adacore.com>
3267
3268         PR c++/24470:
3269         * dwarf2read.c (process_structure_scope): Handle case where type
3270         has template parameters but no symbol was created.
3271
3272 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3273             Chris January  <chris.january@arm.com>
3274
3275         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3276         qualifier.
3277         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3278
3279 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * f-typeprint.c (f_print_type): Update rules for printing
3282         whitespace.
3283         (f_type_print_varspec_suffix): Likewise.
3284
3285 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3286             Chris January  <chris.january@arm.com>
3287
3288         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3289         function arguments.
3290
3291 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3292
3293         * f-lang.c (build_fortran_types): Change name of void type to
3294         lower case.
3295         * f-typeprint.c (f_type_print_base): Print the name of the void
3296         type, rather than a fixed string.
3297         * f-valprint.c (f_decorations): Use lower case void string.
3298
3299 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3300             Chris January  <chris.january@arm.com>
3301
3302         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3303         types for Fortran.
3304
3305 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3306             Chris January  <chris.january@arm.com>
3307             David Lecomber  <david.lecomber@arm.com>
3308
3309         * f-exp.y (BINOP_INTRINSIC): New token.
3310         (exp): New parser rule handling BINOP_INTRINSIC.
3311         (f77_keywords): Add new builtin procedures.
3312         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3313         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3314         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3315         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3316         (print_unop_subexp_f): New function.
3317         (print_binop_subexp_f): New function.
3318         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3319         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3320         (dump_subexp_body_f): Likewise.
3321         (operator_check_f): Likewise.
3322         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3323         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3324
3325 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3326
3327         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3328         UNOP_KIND.
3329         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3330         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3331         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3332         (operator_length_f): New fuction.
3333         (print_subexp_f): New function.
3334         (op_name_f): New function.
3335         (dump_subexp_body_f): New function.
3336         (operator_check_f): New function.
3337         (exp_descriptor_f): Replace standard expression handling functions
3338         with new functions.
3339         * gdb/fortran-operator.def: New file.
3340         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3341         * gdb/std-operator.def: Remove UNOP_KIND.
3342
3343 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * std-operator.def: Remove unbalanced, stray double quote
3346         character.
3347
3348 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3349             Chris January  <chris.january@arm.com>
3350             Daniel Everett  <daniel.everett@arm.com>
3351             Nick Forrington  <nick.forrington@arm.com>
3352             Richard Bunt  <richard.bunt@arm.com>
3353
3354         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3355         of depth when printing anonymous structs or unions.
3356         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3357         Don't print either the top-level value, or the children if the
3358         max-depth is exceeded.
3359         (ppscm_print_children): When printing the key of a map, allow one
3360         extra level of depth.
3361         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3362         print either the top-level value, or the children if the max-depth
3363         is exceeded.
3364         (print_children): When printing the key of a map, allow one extra
3365         level of depth.
3366         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3367         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3368         (user_print_options): Initialise max_depth field.
3369         (val_print_scalar_or_string_type_p): New function.
3370         (val_print): Check to see if the max depth has been reached.
3371         (val_print_check_max_depth): Define new function.
3372         (show_print_max_depth): New function.
3373         (_initialize_valprint): Add 'print max-depth' option.
3374         * valprint.h (struct value_print_options) <max_depth>: New field.
3375         (val_print_check_max_depth): Declare new function.
3376         * NEWS: Document new feature.
3377
3378 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         * ada-lang.c (ada_language_defn): Initialise new field.
3381         * c-lang.c (c_is_string_type_p): New function.
3382         (c_language_defn): Initialise new field.
3383         (cplus_language_defn): Initialise new field.
3384         (asm_language_defn): Initialise new field.
3385         (minimal_language_defn): Initialise new field.
3386         * c-lang.h (c_is_string_type_p): Declare new function.
3387         * d-lang.c (d_language_defn): Initialise new field.
3388         * f-lang.c (f_is_string_type_p): New function.
3389         (f_language_defn): Initialise new field.
3390         * go-lang.c (go_is_string_type_p): New function.
3391         (go_language_defn): Initialise new field.
3392         * language.c (default_is_string_type_p): New function.
3393         (unknown_language_defn): Initialise new field.
3394         (auto_language_defn): Initialise new field.
3395         * language.h (struct language_defn) <la_is_string_type_p>: New
3396         member variable.
3397         (default_is_string_type_p): Declare new function.
3398         * m2-lang.c (m2_language_defn): Initialise new field.
3399         * objc-lang.c (objc_language_defn): Initialise new field.
3400         * opencl-lang.c (opencl_language_defn): Initialise new field.
3401         * p-lang.c (pascal_is_string_type_p): New function.
3402         (pascal_language_defn): Initialise new field.
3403         * rust-lang.c (rust_is_string_type_p): New function.
3404         (rust_language_defn): Initialise new field.
3405
3406 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3409         New field.
3410         * ada-lang.c (ada_language_defn): Initialise new field.
3411         * c-lang.c (c_language_defn): Likewise.
3412         (cplus_language_defn): Likewise.
3413         (asm_language_defn): Likewise.
3414         (minimal_language_defn): Likewise.
3415         * d-lang.c (d_language_defn): Likewise.
3416         * f-lang.c (f_language_defn): Likewise.
3417         * go-lang.c (go_language_defn): Likewise.
3418         * language.c (unknown_language_defn): Likewise.
3419         (auto_language_defn): Likewise.
3420         * m2-lang.c (m2_language_defn): Likewise.
3421         * objc-lang.c (objc_language_defn): Likewise.
3422         * opencl-lang.c (opencl_language_defn): Likewise.
3423         * p-lang.c (pascal_language_defn): Likewise.
3424         * rust-lang.c (rust_language_defn): Likewise.
3425
3426 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3427
3428         * ada-lang.c (ada_is_character_type): Change return type to bool.
3429         (ada_is_string_type): Likewise.
3430         * ada-lang.h (ada_is_character_type): Update declaration
3431         (ada_is_string_type): Likewise.
3432
3433 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3434
3435         Support style in 'frame|thread apply'
3436
3437         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3438         * record.c (record_start, record_stop): Update callers of
3439         execute_command_to_string with false.
3440         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3441         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3442         methods.
3443         (class string_file): New constructor with term_out parameter.
3444         Override methods term_out and can_emit_style_escape.  New member
3445         term_out.
3446         (class stdio_file): Override can_emit_style_escape.
3447         (class tee_file): Override term_out and can_emit_style_escape.
3448         * utils.h (can_emit_style_escape): Remove.
3449         * utils.c (can_emit_style_escape): Likewise.
3450         Update all callers of can_emit_style_escape (SOMESTREAM) to
3451         SOMESTREAM->can_emit_style_escape.
3452         * source-cache.c (source_cache::get_source_lines): Likewise.
3453         * stack.c (frame_apply_command_count): Call execute_command_to_string
3454         passing the term_out characteristic of the current gdb_stdout.
3455         * thread.c (thr_try_catch_cmd): Likewise.
3456         * top.c (execute_command_to_string): pass term_out parameter
3457         to construct the string_file for the command output.
3458         * ui-file.c (term_cli_styling): New function (most code moved
3459         from utils.c can_emit_style_escape).
3460         (string_file::string_file, string_file::can_emit_style_escape,
3461         stdio_file::can_emit_style_escape, tee_file::term_out,
3462         tee_file::can_emit_style_escape): New functions.
3463
3464 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3465
3466         * NEWS: Mention the new set|show may-call-functions.
3467         * infcall.c (may_call_functions_p): New variable.
3468         (show_may_call_functions_p): New function.
3469         (call_function_by_hand_dummy): Throws an error if not
3470         may-call-functions.
3471         (_initialize_infcall): Call add_setshow_boolean_cmd for
3472         may-call-functions.
3473
3474 2019-04-25  Keith Seitz  <keiths@redhat.com>
3475
3476         PR c++/24367
3477         * cp-support.c (inspect_type): Don't attempt substitutions
3478         of symbol with the same name.
3479
3480 2019-04-25  Tom Tromey  <tromey@adacore.com>
3481
3482         PR gdb/24475:
3483         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3484         static.
3485
3486 2019-04-25  Tom Tromey  <tromey@adacore.com>
3487
3488         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3489         rvalue reference.
3490         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3491         (gdb_xml_parser::parse): Use std::move.
3492         * python/python-internal.h (gdbpy_convert_exception): Take a const
3493         reference.
3494         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3495         std::move.
3496         * python/py-utils.c (gdbpy_convert_exception): Take a const
3497         reference.
3498         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3499         Use std::move.
3500         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3501         Use std::move.
3502         * mi/mi-main.c (mi_print_exception): Take a const reference.
3503         * main.c (handle_command_errors): Take a const reference.
3504         * linespec.c (parse_linespec): Use std::move.
3505         * infcall.c (run_inferior_call): Use std::move.
3506         (call_function_by_hand_dummy): Use std::move.
3507         * exec.c (try_open_exec_file): Use std::move.
3508         * exceptions.h (exception_print, exception_fprintf)
3509         (exception_print_same): Update.
3510         * exceptions.c (print_exception, exception_print)
3511         (exception_fprintf, exception_print_same): Change parameters to
3512         const reference.
3513         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3514         * common/new-op.c: Use std::move.
3515         * common/common-exceptions.h (struct gdb_exception): Add move
3516         constructor.
3517         (struct gdb_exception_error, struct gdb_exception_quit, struct
3518         gdb_quit_bad_alloc): Change constructor to move constructor.
3519         (throw_exception): Change parameter to rvalue reference.
3520         * common/common-exceptions.c (throw_exception): Take rvalue
3521         reference.
3522         * cli/cli-interp.c (safe_execute_command): Use std::move.
3523         * breakpoint.c (insert_bp_location, location_to_sals): Use
3524         std::move.
3525
3526 2019-04-25  Tom Tromey  <tromey@adacore.com>
3527
3528         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3529         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3530         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3531         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3532         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3533         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3534         guile/scm-value.c: Use unpack.
3535         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3536         gdbscm_gdb_exception.
3537         (gdbscm_throw_gdb_exception): Likewise.
3538         (struct gdbscm_gdb_exception): New.
3539         (unpack): New function.
3540         (gdbscm_wrap): Use unpack.
3541
3542 2019-04-25  Tom Tromey  <tromey@adacore.com>
3543
3544         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3545         (gdb_rl_callback_handler): Use std::move.
3546         * common/common-exceptions.h (struct gdb_exception): Add move
3547         assignment operator.
3548         (throw_exception_sjlj): Change "exception" to const reference.
3549         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3550         (throw_exception_sjlj): Change "exception" to const reference.
3551
3552 2019-04-25  Tom Tromey  <tromey@adacore.com>
3553
3554         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3555         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3556         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3557         Update.
3558         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3559         Update.
3560         * mi/mi-interp.c (mi_interp::exec): Update.
3561         * linespec.c (parse_linespec): Update.
3562         * infcall.c (run_inferior_call): Update.
3563         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3564         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3565         (gdbscm_lookup_global_symbol): Update.
3566         * guile/scm-param.c (gdbscm_parameter_value): Update.
3567         * guile/scm-frame.c (gdbscm_frame_read_register)
3568         (gdbscm_frame_read_var): Update.
3569         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3570         * exec.c (try_open_exec_file): Update.
3571         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3572         (gdb_rl_callback_handler): Update.
3573         * common/common-exceptions.h (exception_none): Don't declare.
3574         * common/common-exceptions.c (exception_none): Don't define.
3575         (struct catcher) <exception>: Update.
3576         * cli/cli-interp.c (safe_execute_command): Update.
3577         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3578
3579 2019-04-25  Ali Tamur  <tamur@google.com>
3580
3581         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3582         (read_attribute_value): Likewise.
3583         (dwarf2_read_addr_index): Update comment.
3584         (read_str_index): Add DW_FORM_strx.
3585         (dwarf2_string_attr): Likewise.
3586         (dwarf2_const_value_attr): Likewise.
3587         (dump_die_shallow): Likewise.
3588         (dwarf2_fetch_constant_bytes): Likewise.
3589         (skip_form_bytes): Likewise.
3590         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3591
3592 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3593
3594         PR corefiles/11608
3595         PR corefiles/18187
3596         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3597         OFFSET.  Verify if current mapping contains an ELF header.
3598         (linux_find_memory_regions_full): Adjust call to
3599         dump_mapping_p.
3600
3601 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3602             Kang Li <kanglictf@gmail.com>
3603
3604         PR gdb/21600
3605
3606         * dwarf2-frame.c (read_initial_length): Be consistent about using
3607         unsigned representation of length.
3608         (decode_frame_entry_1): Likewise.  Check for wraparound of
3609         end pointer as well as buffer overflow.
3610
3611 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3612
3613         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3614         "vq".
3615
3616 2019-04-24  Tom Tromey  <tromey@adacore.com>
3617
3618         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3619
3620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         * s12z-tdep.c (s12z_unwind_pc): Delete.
3623         (s12z_unwind_sp): Delete.
3624         (s12z_gdbarch_init): Don't register deleted functions with
3625         gdbarch.
3626
3627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * rl78-tdep.c (rl78_unwind_sp): Delete.
3630         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3631
3632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3635         (xstormy16_unwind_pc): Delete.
3636         (xstormy16_dummy_id): Delete.
3637         (xstormy16_gdbarch_init): Don't register deleted functions with
3638         gdbarch.
3639
3640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * vax-tdep.c (vax_unwind_pc): Delete.
3643         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3644
3645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * v850-tdep.c (v850_unwind_sp): Delete.
3648         (v850_unwind_pc): Delete.
3649         (v850_dummy_id): Delete.
3650         (v850_gdbarch_init): Don't register deleted functions with
3651         gdbarch.
3652
3653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3656         (tilegx_unwind_pc): Delete.
3657         (tilegx_unwind_dummy_id): Delete.
3658         (tilegx_gdbarch_init): Don't register deleted functions with
3659         gdbarch.
3660
3661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3664         (tic6x_dummy_id): Delete.
3665         (tic6x_gdbarch_init): Don't register deleted functions with
3666         gdbarch.
3667
3668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * sparc-tdep.c (sparc_unwind_pc): Delete.
3671         (sparc32_gdbarch_init): Don't register deleted function with
3672         gdbarch.
3673
3674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * sh-tdep.c (sh_unwind_sp): Delete.
3677         (sh_unwind_pc): Delete.
3678         (sh_dummy_id): Delete.
3679         (sh_gdbarch_init): Don't register deleted functions with
3680         gdbarch.
3681
3682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         * score-tdep.c (score_unwind_sp): Delete.
3685         (score_unwind_pc): Delete.
3686         (score_dummy_id): Delete.
3687         (score_gdbarch_init): Don't register deleted functions with
3688         gdbarch.
3689
3690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * rx-tdep.c (rx_unwind_pc): Delete.
3693         (rx_unwind_sp): Delete.
3694         (rx_dummy_id): Delete.
3695         (rx_gdbarch_init): Don't register deleted functions with
3696         gdbarch.  Update comment.
3697
3698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3701         (rs6000_dummy_id): Delete.
3702         (rs6000_gdbarch_init): Don't register deleted functions with
3703         gdbarch.
3704
3705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         * or1k-tdep.c (or1k_dummy_id): Delete.
3708         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3709
3710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * nios2-tdep.c (nios2_dummy_id): Delete.
3713         (nios2_unwind_sp): Delete.
3714         (nios2_gdbarch_init): Don't register deleted functions with
3715         gdbarch.
3716
3717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * nds32-tdep.c (nds32_dummy_id): Delete.
3720         (nds32_unwind_pc): Delete.
3721         (nds32_unwind_sp): Delete.
3722         (nds32_gdbarch_init): Don't register deleted functions with
3723         gdbarch.
3724
3725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * msp430-tdep.c (msp430_unwind_pc): Delete.
3728         (msp430_unwind_sp): Delete.
3729         (msp430_dummy_id): Delete.
3730         (msp430_gdbarch_init): Don't register deleted functions with
3731         gdbarch.
3732
3733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * moxie-tdep.c (moxie_unwind_sp): Delete.
3736         (moxie_unwind_pc): Delete.
3737         (moxie_dummy_id): Delete.
3738         (moxie_gdbarch_init): Don't register deleted functions with
3739         gdbarch.
3740
3741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3742
3743         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3744         (mn10300_unwind_pc): Delete.
3745         (mn10300_unwind_sp): Delete.
3746         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3747         mn10300_unwind_sp.
3748         (mn10300_frame_unwind_init): Don't register deleted functions with
3749         gdbarch.
3750
3751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * mep-tdep.c (mep_unwind_pc): Delete.
3754         (mep_unwind_sp): Delete.
3755         (mep_dummy_id): Delete.
3756         (mep_gdbarch_init): Don't register deleted functions with
3757         gdbarch.
3758
3759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3762         (m68hc11_unwind_sp): Delete.
3763         (m68hc11_gdbarch_init): Don't register deleted functions with
3764         gdbarch.
3765
3766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * m32r-tdep.c (m32r_unwind_sp): Delete.
3769         (m32r_unwind_pc): Delete.
3770         (m32r_dummy_id): Delete.
3771         (m32r_gdbarch_init): Don't register deleted functions with
3772         gdbarch.
3773
3774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * m32c-tdep.c (m32c_unwind_pc): Delete.
3777         (m32c_unwind_sp): Delete.
3778         (m32c_dummy_id): Delete.
3779         (m32c_gdbarch_init): Don't register deleted functions with
3780         gdbarch.
3781
3782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3785         (lm32_unwind_pc): Delete.
3786         (lm32_dummy_id): Delete.
3787         (lm32_gdbarch_init): Don't register deleted functions with
3788         gdbarch.
3789
3790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3793         (iq2000_unwind_pc): Delete.
3794         (iq2000_dummy_id): Delete.
3795         (iq2000_gdbarch_init): Don't register deleted functions with
3796         gdbarch.
3797
3798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         * nds32-tdep.c (nds32_type_align): Delete.
3801         (nds32_push_dummy_call): Use type_align instead.
3802
3803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * arm-tdep.c (arm_type_align): Only handle vector override case.
3806         (arm_push_dummy_call): Use type_align.
3807         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3808
3809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3812         case.
3813         (pass_on_stack): Use type_align.
3814         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3815         function.
3816
3817 2019-04-23  Tom Tromey  <tromey@adacore.com>
3818
3819         * dwarf2read.c (line_header::file_name_at): Remove unused
3820         overload.
3821
3822 2019-04-23  Tom de Vries  <tdevries@suse.de>
3823
3824         PR gdb/24438
3825         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3826         invocation.
3827
3828
3829 2019-03-27  Ali Tamur  <tamur@google.com>
3830
3831         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3832         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3833         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3834         (dwarf_expr_context::get_addr_index): Likewise
3835         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3836         (symbol_needs_eval_context::get_addr_index): Likewise
3837         (disassemble_dwarf_expression): Add DW_OP_addrx
3838         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3839         (read_cutu_die_from_dwo): Update comment
3840         (skip_one_die): Add DW_FORM_addrx
3841         (read_attribute_value): Likewise
3842         (var_decode_location): Add DW_OP_addrx
3843         (dwarf2_const_value_attr): Add DW_FORM_addrx
3844         (dump_die_shallow): Likewise
3845         (dwarf2_fetch_constant_bytes): Likewise
3846         (decode_locdesc): Add DW_OP_addrx
3847         (skip_form_bytes): Add DW_FORM_addrx
3848
3849 2019-04-22  Ali Tamur  <tamur@google.com>
3850
3851         * MAINTAINERS (Write After Approval): Add self.
3852
3853 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3854
3855         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3856         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3857         (open_symbol_file_object): Likewise.
3858         (svr4_default_sos): Add info parameter.
3859         (svr4_read_so_list): Likewise.
3860         (svr4_current_sos_direct): Adjust functions calls to pass down
3861         info.
3862         (svr4_current_sos_1): Add info parameter.
3863         (svr4_current_sos): Call get_svr4_info, pass info down to
3864         svr4_current_sos_1.
3865         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3866         get_svr4_info.
3867         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3868         get_svr4_info.
3869         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3870         to get_svr4_info.
3871         (probes_table_remove_objfile_probes): Likewise.
3872         (register_solib_event_probe): Add info parameter.
3873         (solist_update_incremental): Pass info parameter down to
3874         svr4_read_so_list.
3875         (disable_probes_interface): Add info parameter.
3876         (svr4_handle_solib_event): Pass current_program_space to
3877         get_svr4_info.  Adjust disable_probes_interface cleanup.
3878         (svr4_create_probe_breakpoints): Add info parameter, pass it
3879         down to register_solib_event_probe.
3880         (svr4_create_solib_event_breakpoints): Add info parameter,
3881         pass it down to svr4_create_probe_breakpoints.
3882         (enable_break): Pass info down to
3883         svr4_create_solib_event_breakpoints.
3884         (svr4_solib_create_inferior_hook): Pass current_program_space to
3885         get_svr4_info.
3886         (svr4_clear_solib): Likewise.
3887
3888 2019-04-22  Pedro Alves  <palves@redhat.com>
3889
3890         * solib-svr4.c (svr4_free_objfile_observer): New.
3891         (probe_and_action::objfile): New field.
3892         (probes_table_htab_remove_objfile_probes)
3893         (probes_table_remove_objfile_probes): New functions.
3894         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3895         in the new probe_and_action.  Don't store the probe in 'lookup'.
3896         (svr4_create_probe_breakpoints): Pass objfile to
3897         register_solib_event_probe.
3898         (_initialize_svr4_solib): Register a free_objfile observer.
3899
3900 2019-04-19  Tom Tromey  <tom@tromey.com>
3901
3902         * common/queue.h: Remove.
3903
3904 2019-04-19  Tom Tromey  <tom@tromey.com>
3905
3906         * event-loop.c: Don't include "common/queue.h".
3907
3908 2019-04-19  Tom Tromey  <tom@tromey.com>
3909
3910         * remote.c (remote_target): Use delete.
3911         * remote-notif.h: Include <list>, not "common/queue.h".
3912         (notif_client_p): Remove typedef.
3913         (remote_notif_state): Add constructor, destructor, initializer.
3914         <notif_queue>: Now a std::list.
3915         (remote_notif_state_xfree): Don't declare.
3916         * remote-notif.c (remote_notif_process, handle_notification)
3917         (remote_notif_state_allocate): Update.
3918         (~remote_notif_state): Rename from remote_notif_state_xfree.
3919
3920 2019-04-19  Tom Tromey  <tom@tromey.com>
3921
3922         * symfile.c (reread_symbols): Update.
3923         * objfiles.c (objfile_register_static_link)
3924         (objfile_lookup_static_link): Update
3925         (~objfile) Don't delete static_links.
3926         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3927
3928 2019-04-19  Tom Tromey  <tom@tromey.com>
3929
3930         * type-stack.h (struct type_stack) <insert>: Constify string.
3931         * type-stack.c (type_stack::insert): Constify string.
3932         * gdbtypes.h (lookup_template_type): Update.
3933         (address_space_name_to_int): Update.
3934         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3935         const.
3936         (lookup_template_type): Make name const.
3937         * c-exp.y: Update rules.
3938         (lex_one_token, classify_name, classify_inner_name)
3939         (c_print_token): Update.
3940         * p-exp.y: Update rules.
3941         (yylex): Update.
3942         * f-exp.y: Update rules.
3943         (yylex): Update.
3944         * d-exp.y: Update rules.
3945         (lex_one_token, classify_name, classify_inner_name): Update.
3946         * parse.c (write_dollar_variable, copy_name): Return std::string.
3947         * parser-defs.h (copy_name): Change return type.
3948         * m2-exp.y: Update rules.
3949         (yylex): Update.
3950         * go-exp.y (lex_one_token): Update.
3951         Update rules.
3952         (classify_unsafe_function, classify_packaged_name)
3953         (classify_name, yylex): Update.
3954
3955 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3956
3957         * configure.ac: add --enable-source-highlight switch.
3958         * configure: Regenerate.
3959         * top.c (print_gdb_version): plumb --enable-source-highlight
3960         status to "show configuration".
3961
3962 2019-04-19  Tom Tromey  <tromey@adacore.com>
3963
3964         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3965         Check ADA_TYPE_P.
3966         (empty_record, ada_template_to_fixed_record_type_1)
3967         (template_to_static_fixed_type)
3968         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3969         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3970         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3971         macros.
3972
3973 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3974
3975         PR symtab/24423:
3976         * source.c (print_source_lines_base): Advance "iter" when a
3977         control character is seen.
3978
3979 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * inferior.h (struct infcall_suspend_state_deleter):
3982         Catch exception in destructor to avoid crash.
3983
3984 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3987         close to the add_com "shell".
3988
3989 2019-04-18  Tom Tromey  <tromey@adacore.com>
3990
3991         * process-stratum-target.h (class process_stratum_target)
3992         <stratum>: Add "final".
3993
3994 2019-04-17  Tom Tromey  <tromey@adacore.com>
3995
3996         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3997         against nullptr before use.
3998
3999 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4000
4001         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4002
4003 2019-04-17  Jim Wilson  <jimw@sifive.com>
4004             Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4007         code read might fail, assume 4-byte breakpoint in that case.
4008
4009 2019-04-15  Leszek Swirski  <leszeks@google.com>
4010
4011         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4012         rather than a hand-rolled POD check when checking for forced MEMORY
4013         classification.
4014
4015 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4016
4017         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4018         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4019         function.
4020         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4021         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4022         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4023         declaration.
4024
4025 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4026
4027         * aarch64-linux-nat.c
4028         (aarch64_linux_nat_target::thread_architecture): Add override.
4029         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4030         each VQ.
4031
4032 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4033
4034         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4035
4036 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4037
4038         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4039         target types of size 96-bits, add some additional comments, and
4040         check that the builtin type we found was the correct size.
4041
4042 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4043
4044         * utils.c (prompt_for_continue): Don't restore the styling at the
4045         end, as applied_style has the wrong value.  This fixes styling in
4046         long lists of file names that are interrupted by the "Continue?"
4047         prompt.
4048
4049 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4050
4051         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4052         * c-lang.c (c_language_defn): Likewise.
4053         (cplus_language_defn): Likewise.
4054         (asm_language_defn): Likewise.
4055         (minimal_language_defn): Likewise.
4056         * d-lang.c (d_language_defn): Likewise.
4057         * f-lang.c (f_language_defn): Likewise.
4058         * go-lang.c (go_language_defn): Likewise.
4059         * language.c (unknown_language_defn): Likewise.
4060         (auto_language_defn): Likewise.
4061         * language.h (struct language_defn): Remove la_magic field.
4062         (LANG_MAGIC): Delete.
4063         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4064         * objc-lang.c (objc_language_defn): Likewise.
4065         * opencl-lang.c (opencl_language_defn): Likewise.
4066         * p-lang.c (pascal_language_defn): Likewise.
4067         * rust-lang.c (rust_language_defn): Likewise.
4068
4069 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * riscv-tdep.c (riscv_type_align): New function.
4072         (riscv_type_alignment): Delete.
4073         (riscv_arg_location): Use 'type_align'.
4074         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4075
4076 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4077
4078         * gdbtypes.c (type_align): A struct with no non-static fields also
4079         has alignment of 1.
4080
4081 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4084         component to 0.
4085         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4086         member.
4087         (riscv_struct_info::analyse): New implementation using new
4088         analyse_inner member function.
4089         (riscv_struct_info::field_offset): New member function.
4090         (riscv_struct_info::m_offsets): New member variable.
4091         (riscv_struct_info::analyse_inner): New private member function,
4092         takes the old implementation of riscv_struct_info::analyse but
4093         extended to track field offsets.
4094         (riscv_call_arg_struct): Update the struct folding special cases
4095         to handle cases where empty C++ structs, which are non-zero
4096         length, are found.
4097         (riscv_arg_location): Initialise the length of each location, a
4098         non-zero length now indicates the location is in use.
4099         (riscv_push_dummy_call): Allow for the first location having a
4100         non-zero offset when setting up arguments.
4101         (riscv_return_value): Likewise, but for return values.
4102
4103 2019-04-11  Tom Tromey  <tromey@adacore.com>
4104
4105         * utils.c (internal_vproblem): Make "msg" const.
4106
4107 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4108
4109         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4110         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4111         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4112         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4113
4114 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4115
4116         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4117         function.
4118         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4119         of amd64_collect_native_gregset.
4120         (amd64_linux_nat_target::store_registers): Likewise.
4121
4122 2019-04-10  Tom Tromey  <tom@tromey.com>
4123
4124         * symtab.c (lookup_global_symbol_from_objfile)
4125         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4126         * objfiles.h (class separate_debug_iterator): New.
4127         (class separate_debug_range): New.
4128         (struct objfile) <separate_debug_objfiles>: New method.
4129         (objfile_separate_debug_iterate): Don't declare.
4130         * objfiles.c (separate_debug_iterator::operator++): Rename from
4131         objfile_separate_debug_iterate.
4132         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4133         iterator.
4134         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4135         iterator.
4136
4137 2019-04-10  Tom Tromey  <tom@tromey.com>
4138
4139         * symfile.c (reread_symbols): Remove old comment.
4140         * objfiles.c (free_all_objfiles): Fix a typo.
4141
4142 2019-04-10  Tom Tromey  <tom@tromey.com>
4143
4144         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4145         * minsyms.c (lookup_minimal_symbol): Use foreach.
4146         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4147         (lookup_minimal_symbol_solib_trampoline): Likewise.
4148         * symfile.c (reread_symbols): Use foreach.
4149
4150 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4151             Tom Tromey  <tromey@adacore.com>
4152
4153         PR rust/24414:
4154         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4155         (rust_lex_int_test): Change "value" to be LONGEST.
4156         (rust_lex_tests): Add test for long integer literal.
4157
4158 2019-04-09  Tom Tromey  <tromey@adacore.com>
4159
4160         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4161         to bool.
4162         (extended_remote_target::attach): Update.
4163         (remote_target::remote_notice_new_inferior): Update.
4164         (remote_target::add_current_inferior_and_thread): Update.
4165         * inferior.c (exit_inferior_1): Use "false".
4166         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4167
4168 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4169
4170         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4171         the "start" command.
4172
4173 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4174
4175         * python/py-inferior.c (infpy_thread_from_thread_handle):
4176         Adjust comments to reflect renaming of thread_from_thread_handle
4177         to thread_from_handle.  Adjust keywords.  Fix type error message.
4178         (inferior_object_methods): Add thread_from_handle.  Retain
4179         thread_from_thread_handle, but mark it as deprecated.
4180
4181 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4182
4183         * gdbthread.h (find_thread_by_handle): Revise declaration.
4184         * thread.c (find_thread_by_handle): Likewise.  Adjust
4185         implementation too.
4186         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4187         support for buffer objects as handles.
4188
4189 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4190
4191         * python/py-infthread.c (thpy_thread_handle): New function.
4192         (thread_object_methods): Register thpy_thread_handle.
4193
4194 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4195
4196         * gdbthread.h (thread_to_thread_handle): Declare.
4197         * thread.c (gdbtypes.h): Include.
4198         (thread_to_thread_handle): New function.
4199
4200         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4201         (target_thread_info_to_thread_handle): Declare.
4202         * target.c (target_thread_info_to_thread_handle): New function.
4203         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4204         * target-delegates.c: Regenerate.
4205
4206         * linux-thread-db.c (class thread_db_target): Add method
4207         thread_info_to_thread_handle.
4208         (thread_db_target::thread_info_to_thread_handle): Define.
4209         * remote.c (class remote_target): Add new method
4210         thread_info_to_thread_handle.
4211         (remote_target::thread_info_to_thread_handle): Define.
4212
4213 2019-04-08  Pedro Alves  <palves@redhat.com>
4214
4215         * common/common-exceptions.c (throw_exception): Don't create
4216         named object to throw; throw directly.
4217         (throw_it): Likewise.  Don't initialize gdb_exception::message
4218         here, with new; pass FMT and AP to the ctor instead.
4219         * common/common-exceptions.h: Include <string>.
4220         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4221         const char *, va_list)): New ctor.  Use std::make_shared.
4222         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4223         errors)): Delete.
4224         (gdb_exception_error::gdb_exception_error(enum errors, const char
4225         *, va_list)): New.
4226         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4227         Add assertion.
4228         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4229         errors)): Delete.
4230         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4231         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4232         Add assertion.
4233
4234 2019-04-08  Tom Tromey  <tom@tromey.com>
4235
4236         * valops.c (value_rtti_indirect_type): Replace throw_exception
4237         with throw.
4238         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4239         with throw.
4240         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4241         throw.
4242         * target.c (target_translate_tls_address): Replace throw_exception
4243         with throw.
4244         * stack.c (frame_apply_command_count): Replace throw_exception
4245         with throw.
4246         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4247         throw.
4248         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4249         with throw.
4250         * rs6000-tdep.c (rs6000_frame_cache)
4251         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4252         * remote.c: Replace throw_exception with throw.
4253         * record-full.c (record_full_message, record_full_wait_1)
4254         (record_full_restore): Replace throw_exception with throw.
4255         * record-btrace.c:
4256         (get_thread_current_frame_id, record_btrace_start_replaying)
4257         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4258         (cmd_record_btrace_start): Replace throw_exception with throw.
4259         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4260         throw.
4261         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4262         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4263         * linespec.c:
4264         (find_linespec_symbols): Replace throw_exception with throw.
4265         * infrun.c (displaced_step_prepare, resume): Replace
4266         throw_exception with throw.
4267         * infcmd.c (post_create_inferior): Replace throw_exception with
4268         throw.
4269         * inf-loop.c (inferior_event_handler): Replace throw_exception
4270         with throw.
4271         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4272         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4273         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4274         (get_prev_frame_always, get_frame_pc_if_available)
4275         (get_frame_address_in_block_if_available, get_frame_language):
4276         Replace throw_exception with throw.
4277         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4278         throw_exception with throw.
4279         * eval.c (fetch_subexp_value, evaluate_var_value)
4280         (evaluate_funcall, evaluate_subexp_standard): Replace
4281         throw_exception with throw.
4282         * dwarf2loc.c (call_site_find_chain)
4283         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4284         Replace throw_exception with throw.
4285         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4286         with throw.
4287         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4288         throw.
4289         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4290         * completer.c (complete_line_internal): Replace throw_exception
4291         with throw.
4292         * compile/compile-object-run.c (compile_object_run): Replace
4293         throw_exception with throw.
4294         * cli/cli-script.c (process_next_line): Replace throw_exception
4295         with throw.
4296         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4297         (btrace_enable, btrace_maint_update_pt_packets): Replace
4298         throw_exception with throw.
4299         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4300         throw_exception with throw.
4301         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4302         throw_exception with throw.
4303         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4304         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4305         * aarch64-tdep.c (aarch64_make_prologue_cache)
4306         (aarch64_make_stub_cache): Replace throw_exception with throw.
4307
4308 2019-04-08  Tom Tromey  <tom@tromey.com>
4309
4310         * common/common-exceptions.c (throw_exception): Rename from
4311         throw_exception_cxx.  Remove old copy.  Make argument const.
4312         (throw_it): Create and throw exception objects directly.
4313         * common/common-exceptions.h (throw_exception): Make argument
4314         const.
4315         (struct gdb_exception_error): Add constructor.
4316         (struct gdb_exception_quit): Add constructor.
4317
4318 2019-04-08  Tom Tromey  <tom@tromey.com>
4319
4320         * common/common-exceptions.h (exception_rethrow): Don't declare.
4321         (TRY_SJLJ): Update comment.
4322         (TRY, CATCH, END_CATCH): Remove.
4323         * common/common-exceptions.c (exception_rethrow): Remove.
4324
4325 2019-04-08  Tom Tromey  <tom@tromey.com>
4326
4327         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4328         Remove.
4329         (gdb_exception_error): Rename from
4330         gdb_exception_RETURN_MASK_ERROR.
4331         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4332         (gdb_quit_bad_alloc): Update.
4333         * aarch64-tdep.c: Update.
4334         * ada-lang.c: Update.
4335         * ada-typeprint.c: Update.
4336         * ada-valprint.c: Update.
4337         * amd64-tdep.c: Update.
4338         * arch-utils.c: Update.
4339         * break-catch-throw.c: Update.
4340         * breakpoint.c: Update.
4341         * btrace.c: Update.
4342         * c-varobj.c: Update.
4343         * cli/cli-cmds.c: Update.
4344         * cli/cli-interp.c: Update.
4345         * cli/cli-script.c: Update.
4346         * common/common-exceptions.c: Update.
4347         * common/new-op.c: Update.
4348         * common/selftest.c: Update.
4349         * compile/compile-c-symbols.c: Update.
4350         * compile/compile-cplus-symbols.c: Update.
4351         * compile/compile-object-load.c: Update.
4352         * compile/compile-object-run.c: Update.
4353         * completer.c: Update.
4354         * corelow.c: Update.
4355         * cp-abi.c: Update.
4356         * cp-support.c: Update.
4357         * cp-valprint.c: Update.
4358         * darwin-nat.c: Update.
4359         * disasm-selftests.c: Update.
4360         * dtrace-probe.c: Update.
4361         * dwarf-index-cache.c: Update.
4362         * dwarf-index-write.c: Update.
4363         * dwarf2-frame-tailcall.c: Update.
4364         * dwarf2-frame.c: Update.
4365         * dwarf2loc.c: Update.
4366         * dwarf2read.c: Update.
4367         * eval.c: Update.
4368         * event-loop.c: Update.
4369         * event-top.c: Update.
4370         * exec.c: Update.
4371         * f-valprint.c: Update.
4372         * fbsd-tdep.c: Update.
4373         * frame-unwind.c: Update.
4374         * frame.c: Update.
4375         * gdbtypes.c: Update.
4376         * gnu-v3-abi.c: Update.
4377         * guile/guile-internal.h: Update.
4378         * guile/scm-block.c: Update.
4379         * guile/scm-breakpoint.c: Update.
4380         * guile/scm-cmd.c: Update.
4381         * guile/scm-disasm.c: Update.
4382         * guile/scm-frame.c: Update.
4383         * guile/scm-lazy-string.c: Update.
4384         * guile/scm-math.c: Update.
4385         * guile/scm-param.c: Update.
4386         * guile/scm-ports.c: Update.
4387         * guile/scm-pretty-print.c: Update.
4388         * guile/scm-symbol.c: Update.
4389         * guile/scm-symtab.c: Update.
4390         * guile/scm-type.c: Update.
4391         * guile/scm-value.c: Update.
4392         * i386-linux-tdep.c: Update.
4393         * i386-tdep.c: Update.
4394         * inf-loop.c: Update.
4395         * infcall.c: Update.
4396         * infcmd.c: Update.
4397         * infrun.c: Update.
4398         * jit.c: Update.
4399         * language.c: Update.
4400         * linespec.c: Update.
4401         * linux-fork.c: Update.
4402         * linux-nat.c: Update.
4403         * linux-tdep.c: Update.
4404         * linux-thread-db.c: Update.
4405         * main.c: Update.
4406         * mi/mi-cmd-break.c: Update.
4407         * mi/mi-cmd-stack.c: Update.
4408         * mi/mi-interp.c: Update.
4409         * mi/mi-main.c: Update.
4410         * objc-lang.c: Update.
4411         * p-valprint.c: Update.
4412         * parse.c: Update.
4413         * ppc-linux-tdep.c: Update.
4414         * printcmd.c: Update.
4415         * python/py-arch.c: Update.
4416         * python/py-breakpoint.c: Update.
4417         * python/py-cmd.c: Update.
4418         * python/py-finishbreakpoint.c: Update.
4419         * python/py-frame.c: Update.
4420         * python/py-framefilter.c: Update.
4421         * python/py-gdb-readline.c: Update.
4422         * python/py-inferior.c: Update.
4423         * python/py-infthread.c: Update.
4424         * python/py-lazy-string.c: Update.
4425         * python/py-linetable.c: Update.
4426         * python/py-objfile.c: Update.
4427         * python/py-param.c: Update.
4428         * python/py-prettyprint.c: Update.
4429         * python/py-progspace.c: Update.
4430         * python/py-record-btrace.c: Update.
4431         * python/py-record.c: Update.
4432         * python/py-symbol.c: Update.
4433         * python/py-type.c: Update.
4434         * python/py-unwind.c: Update.
4435         * python/py-utils.c: Update.
4436         * python/py-value.c: Update.
4437         * python/python.c: Update.
4438         * record-btrace.c: Update.
4439         * record-full.c: Update.
4440         * remote-fileio.c: Update.
4441         * remote.c: Update.
4442         * riscv-tdep.c: Update.
4443         * rs6000-aix-tdep.c: Update.
4444         * rs6000-tdep.c: Update.
4445         * rust-exp.y: Update.
4446         * rust-lang.c: Update.
4447         * s390-tdep.c: Update.
4448         * selftest-arch.c: Update.
4449         * solib-dsbt.c: Update.
4450         * solib-frv.c: Update.
4451         * solib-spu.c: Update.
4452         * solib-svr4.c: Update.
4453         * solib.c: Update.
4454         * sparc64-linux-tdep.c: Update.
4455         * stack.c: Update.
4456         * symfile-mem.c: Update.
4457         * symmisc.c: Update.
4458         * target.c: Update.
4459         * thread.c: Update.
4460         * top.c: Update.
4461         * tracefile-tfile.c: Update.
4462         * tui/tui.c: Update.
4463         * typeprint.c: Update.
4464         * unittests/cli-utils-selftests.c: Update.
4465         * unittests/parse-connection-spec-selftests.c: Update.
4466         * valops.c: Update.
4467         * valprint.c: Update.
4468         * value.c: Update.
4469         * varobj.c: Update.
4470         * windows-nat.c: Update.
4471         * x86-linux-nat.c: Update.
4472         * xml-support.c: Update.
4473
4474 2019-04-08  Tom Tromey  <tom@tromey.com>
4475
4476         * xml-support.c: Use C++ exception handling.
4477         * x86-linux-nat.c: Use C++ exception handling.
4478         * windows-nat.c: Use C++ exception handling.
4479         * varobj.c: Use C++ exception handling.
4480         * value.c: Use C++ exception handling.
4481         * valprint.c: Use C++ exception handling.
4482         * valops.c: Use C++ exception handling.
4483         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4484         handling.
4485         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4486         * typeprint.c: Use C++ exception handling.
4487         * tui/tui.c: Use C++ exception handling.
4488         * tracefile-tfile.c: Use C++ exception handling.
4489         * top.c: Use C++ exception handling.
4490         * thread.c: Use C++ exception handling.
4491         * target.c: Use C++ exception handling.
4492         * symmisc.c: Use C++ exception handling.
4493         * symfile-mem.c: Use C++ exception handling.
4494         * stack.c: Use C++ exception handling.
4495         * sparc64-linux-tdep.c: Use C++ exception handling.
4496         * solib.c: Use C++ exception handling.
4497         * solib-svr4.c: Use C++ exception handling.
4498         * solib-spu.c: Use C++ exception handling.
4499         * solib-frv.c: Use C++ exception handling.
4500         * solib-dsbt.c: Use C++ exception handling.
4501         * selftest-arch.c: Use C++ exception handling.
4502         * s390-tdep.c: Use C++ exception handling.
4503         * rust-lang.c: Use C++ exception handling.
4504         * rust-exp.y: Use C++ exception handling.
4505         * rs6000-tdep.c: Use C++ exception handling.
4506         * rs6000-aix-tdep.c: Use C++ exception handling.
4507         * riscv-tdep.c: Use C++ exception handling.
4508         * remote.c: Use C++ exception handling.
4509         * remote-fileio.c: Use C++ exception handling.
4510         * record-full.c: Use C++ exception handling.
4511         * record-btrace.c: Use C++ exception handling.
4512         * python/python.c: Use C++ exception handling.
4513         * python/py-value.c: Use C++ exception handling.
4514         * python/py-utils.c: Use C++ exception handling.
4515         * python/py-unwind.c: Use C++ exception handling.
4516         * python/py-type.c: Use C++ exception handling.
4517         * python/py-symbol.c: Use C++ exception handling.
4518         * python/py-record.c: Use C++ exception handling.
4519         * python/py-record-btrace.c: Use C++ exception handling.
4520         * python/py-progspace.c: Use C++ exception handling.
4521         * python/py-prettyprint.c: Use C++ exception handling.
4522         * python/py-param.c: Use C++ exception handling.
4523         * python/py-objfile.c: Use C++ exception handling.
4524         * python/py-linetable.c: Use C++ exception handling.
4525         * python/py-lazy-string.c: Use C++ exception handling.
4526         * python/py-infthread.c: Use C++ exception handling.
4527         * python/py-inferior.c: Use C++ exception handling.
4528         * python/py-gdb-readline.c: Use C++ exception handling.
4529         * python/py-framefilter.c: Use C++ exception handling.
4530         * python/py-frame.c: Use C++ exception handling.
4531         * python/py-finishbreakpoint.c: Use C++ exception handling.
4532         * python/py-cmd.c: Use C++ exception handling.
4533         * python/py-breakpoint.c: Use C++ exception handling.
4534         * python/py-arch.c: Use C++ exception handling.
4535         * printcmd.c: Use C++ exception handling.
4536         * ppc-linux-tdep.c: Use C++ exception handling.
4537         * parse.c: Use C++ exception handling.
4538         * p-valprint.c: Use C++ exception handling.
4539         * objc-lang.c: Use C++ exception handling.
4540         * mi/mi-main.c: Use C++ exception handling.
4541         * mi/mi-interp.c: Use C++ exception handling.
4542         * mi/mi-cmd-stack.c: Use C++ exception handling.
4543         * mi/mi-cmd-break.c: Use C++ exception handling.
4544         * main.c: Use C++ exception handling.
4545         * linux-thread-db.c: Use C++ exception handling.
4546         * linux-tdep.c: Use C++ exception handling.
4547         * linux-nat.c: Use C++ exception handling.
4548         * linux-fork.c: Use C++ exception handling.
4549         * linespec.c: Use C++ exception handling.
4550         * language.c: Use C++ exception handling.
4551         * jit.c: Use C++ exception handling.
4552         * infrun.c: Use C++ exception handling.
4553         * infcmd.c: Use C++ exception handling.
4554         * infcall.c: Use C++ exception handling.
4555         * inf-loop.c: Use C++ exception handling.
4556         * i386-tdep.c: Use C++ exception handling.
4557         * i386-linux-tdep.c: Use C++ exception handling.
4558         * guile/scm-value.c: Use C++ exception handling.
4559         * guile/scm-type.c: Use C++ exception handling.
4560         * guile/scm-symtab.c: Use C++ exception handling.
4561         * guile/scm-symbol.c: Use C++ exception handling.
4562         * guile/scm-pretty-print.c: Use C++ exception handling.
4563         * guile/scm-ports.c: Use C++ exception handling.
4564         * guile/scm-param.c: Use C++ exception handling.
4565         * guile/scm-math.c: Use C++ exception handling.
4566         * guile/scm-lazy-string.c: Use C++ exception handling.
4567         * guile/scm-frame.c: Use C++ exception handling.
4568         * guile/scm-disasm.c: Use C++ exception handling.
4569         * guile/scm-cmd.c: Use C++ exception handling.
4570         * guile/scm-breakpoint.c: Use C++ exception handling.
4571         * guile/scm-block.c: Use C++ exception handling.
4572         * guile/guile-internal.h: Use C++ exception handling.
4573         * gnu-v3-abi.c: Use C++ exception handling.
4574         * gdbtypes.c: Use C++ exception handling.
4575         * frame.c: Use C++ exception handling.
4576         * frame-unwind.c: Use C++ exception handling.
4577         * fbsd-tdep.c: Use C++ exception handling.
4578         * f-valprint.c: Use C++ exception handling.
4579         * exec.c: Use C++ exception handling.
4580         * event-top.c: Use C++ exception handling.
4581         * event-loop.c: Use C++ exception handling.
4582         * eval.c: Use C++ exception handling.
4583         * dwarf2read.c: Use C++ exception handling.
4584         * dwarf2loc.c: Use C++ exception handling.
4585         * dwarf2-frame.c: Use C++ exception handling.
4586         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4587         * dwarf-index-write.c: Use C++ exception handling.
4588         * dwarf-index-cache.c: Use C++ exception handling.
4589         * dtrace-probe.c: Use C++ exception handling.
4590         * disasm-selftests.c: Use C++ exception handling.
4591         * darwin-nat.c: Use C++ exception handling.
4592         * cp-valprint.c: Use C++ exception handling.
4593         * cp-support.c: Use C++ exception handling.
4594         * cp-abi.c: Use C++ exception handling.
4595         * corelow.c: Use C++ exception handling.
4596         * completer.c: Use C++ exception handling.
4597         * compile/compile-object-run.c: Use C++ exception handling.
4598         * compile/compile-object-load.c: Use C++ exception handling.
4599         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4600         * compile/compile-c-symbols.c: Use C++ exception handling.
4601         * common/selftest.c: Use C++ exception handling.
4602         * common/new-op.c: Use C++ exception handling.
4603         * cli/cli-script.c: Use C++ exception handling.
4604         * cli/cli-interp.c: Use C++ exception handling.
4605         * cli/cli-cmds.c: Use C++ exception handling.
4606         * c-varobj.c: Use C++ exception handling.
4607         * btrace.c: Use C++ exception handling.
4608         * breakpoint.c: Use C++ exception handling.
4609         * break-catch-throw.c: Use C++ exception handling.
4610         * arch-utils.c: Use C++ exception handling.
4611         * amd64-tdep.c: Use C++ exception handling.
4612         * ada-valprint.c: Use C++ exception handling.
4613         * ada-typeprint.c: Use C++ exception handling.
4614         * ada-lang.c: Use C++ exception handling.
4615         * aarch64-tdep.c: Use C++ exception handling.
4616
4617 2019-04-08  Tom Tromey  <tom@tromey.com>
4618
4619         * xml-support.c (gdb_xml_parser::parse): Update.
4620         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4621         * value.c (show_convenience): Update.
4622         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4623         (test_parse_flags_qcs): Update.
4624         * thread.c (thr_try_catch_cmd): Update.
4625         * target.c (target_translate_tls_address): Update.
4626         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4627         (info_frame_command_core, frame_apply_command_count): Update.
4628         * rust-exp.y (rust_lex_exception_test): Update.
4629         * riscv-tdep.c (riscv_print_one_register_info): Update.
4630         * remote.c (remote_target::enable_btrace): Update.
4631         * record-btrace.c (record_btrace_enable_warn): Update.
4632         * python/py-utils.c (gdbpy_convert_exception): Update.
4633         * printcmd.c (do_one_display, print_variable_and_value): Update.
4634         * mi/mi-main.c (mi_print_exception): Update.
4635         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4636         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4637         * linux-nat.c (linux_nat_target::attach): Update.
4638         * linux-fork.c (class scoped_switch_fork_info): Update.
4639         * infrun.c (displaced_step_prepare): Update.
4640         * infcall.c (call_function_by_hand_dummy): Update.
4641         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4642         * gnu-v3-abi.c (print_one_vtable): Update.
4643         * frame.c (get_prev_frame_always): Update.
4644         * f-valprint.c (info_common_command_for_block): Update.
4645         * exec.c (try_open_exec_file): Update.
4646         * exceptions.c (print_exception, exception_print)
4647         (exception_fprintf, exception_print_same): Update.
4648         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4649         * dwarf-index-cache.c (index_cache::store)
4650         (index_cache::lookup_gdb_index): Update.
4651         * darwin-nat.c (maybe_cache_shell): Update.
4652         * cp-valprint.c (cp_print_value_fields): Update.
4653         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4654         (gcc_cplus_symbol_address): Update.
4655         * compile/compile-c-symbols.c (gcc_convert_symbol)
4656         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4657         * common/selftest.c: Update.
4658         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4659         a std::string.
4660         (exception_try_scope_entry, exception_try_scope_exit): Don't
4661         declare.
4662         (struct exception_try_scope): Remove.
4663         (TRY): Don't use exception_try_scope.
4664         (struct gdb_exception): Add constructor, operator=.
4665         <what>: New method.
4666         (struct gdb_exception_RETURN_MASK_ALL)
4667         (struct gdb_exception_RETURN_MASK_ERROR)
4668         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4669         (struct gdb_quit_bad_alloc): Update.
4670         * common/common-exceptions.c (exception_none): Change
4671         initializer.
4672         (struct catcher) <state, exception>: Initialize inline.
4673         <prev>: Remove member.
4674         (current_catcher): Remove.
4675         (catchers): New global.
4676         (exceptions_state_mc_init): Simplify.
4677         (catcher_pop): Remove.
4678         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4679         (try_scope_depth, exception_try_scope_entry)
4680         (exception_try_scope_exit): Remove.
4681         (throw_exception_sjlj): Update.
4682         (exception_messages, exception_messages_size): Remove.
4683         (throw_it): Simplify.
4684         (gdb_exception_sliced_copy): Remove.
4685         (throw_exception_cxx): Update.
4686         * cli/cli-script.c (script_from_file): Update.
4687         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4688         Update.
4689         * ada-valprint.c (ada_val_print): Update.
4690         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4691         (create_excep_cond_exprs): Update.
4692
4693 2019-04-08  Tom Tromey  <tom@tromey.com>
4694
4695         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4696         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4697         (TRY, CATCH, END_CATCH): Remove some definitions.
4698         * common/common-exceptions.c: Don't use GDB_XCPT.
4699         (catcher_list_size): Remove.
4700         (throw_exception, throw_it): Simplify.
4701
4702 2019-04-05  Tom Tromey  <tom@tromey.com>
4703
4704         Revert the header-sorting patch.
4705         * ft32-tdep.c: Revert.
4706         * frv-tdep.c: Revert.
4707         * frv-linux-tdep.c: Revert.
4708         * frame.c: Revert.
4709         * frame-unwind.c: Revert.
4710         * frame-base.c: Revert.
4711         * fork-child.c: Revert.
4712         * findvar.c: Revert.
4713         * findcmd.c: Revert.
4714         * filesystem.c: Revert.
4715         * filename-seen-cache.h: Revert.
4716         * filename-seen-cache.c: Revert.
4717         * fbsd-tdep.c: Revert.
4718         * fbsd-nat.h: Revert.
4719         * fbsd-nat.c: Revert.
4720         * f-valprint.c: Revert.
4721         * f-typeprint.c: Revert.
4722         * f-lang.c: Revert.
4723         * extension.h: Revert.
4724         * extension.c: Revert.
4725         * extension-priv.h: Revert.
4726         * expprint.c: Revert.
4727         * exec.h: Revert.
4728         * exec.c: Revert.
4729         * exceptions.c: Revert.
4730         * event-top.c: Revert.
4731         * event-loop.c: Revert.
4732         * eval.c: Revert.
4733         * elfread.c: Revert.
4734         * dwarf2read.h: Revert.
4735         * dwarf2read.c: Revert.
4736         * dwarf2loc.c: Revert.
4737         * dwarf2expr.h: Revert.
4738         * dwarf2expr.c: Revert.
4739         * dwarf2-frame.c: Revert.
4740         * dwarf2-frame-tailcall.c: Revert.
4741         * dwarf-index-write.h: Revert.
4742         * dwarf-index-write.c: Revert.
4743         * dwarf-index-common.c: Revert.
4744         * dwarf-index-cache.h: Revert.
4745         * dwarf-index-cache.c: Revert.
4746         * dummy-frame.c: Revert.
4747         * dtrace-probe.c: Revert.
4748         * disasm.h: Revert.
4749         * disasm.c: Revert.
4750         * disasm-selftests.c: Revert.
4751         * dictionary.c: Revert.
4752         * dicos-tdep.c: Revert.
4753         * demangle.c: Revert.
4754         * dcache.h: Revert.
4755         * dcache.c: Revert.
4756         * darwin-nat.h: Revert.
4757         * darwin-nat.c: Revert.
4758         * darwin-nat-info.c: Revert.
4759         * d-valprint.c: Revert.
4760         * d-namespace.c: Revert.
4761         * d-lang.c: Revert.
4762         * ctf.c: Revert.
4763         * csky-tdep.c: Revert.
4764         * csky-linux-tdep.c: Revert.
4765         * cris-tdep.c: Revert.
4766         * cris-linux-tdep.c: Revert.
4767         * cp-valprint.c: Revert.
4768         * cp-support.c: Revert.
4769         * cp-namespace.c: Revert.
4770         * cp-abi.c: Revert.
4771         * corelow.c: Revert.
4772         * corefile.c: Revert.
4773         * continuations.c: Revert.
4774         * completer.h: Revert.
4775         * completer.c: Revert.
4776         * complaints.c: Revert.
4777         * coffread.c: Revert.
4778         * coff-pe-read.c: Revert.
4779         * cli-out.h: Revert.
4780         * cli-out.c: Revert.
4781         * charset.c: Revert.
4782         * c-varobj.c: Revert.
4783         * c-valprint.c: Revert.
4784         * c-typeprint.c: Revert.
4785         * c-lang.c: Revert.
4786         * buildsym.c: Revert.
4787         * buildsym-legacy.c: Revert.
4788         * build-id.h: Revert.
4789         * build-id.c: Revert.
4790         * btrace.c: Revert.
4791         * bsd-uthread.c: Revert.
4792         * breakpoint.h: Revert.
4793         * breakpoint.c: Revert.
4794         * break-catch-throw.c: Revert.
4795         * break-catch-syscall.c: Revert.
4796         * break-catch-sig.c: Revert.
4797         * blockframe.c: Revert.
4798         * block.c: Revert.
4799         * bfin-tdep.c: Revert.
4800         * bfin-linux-tdep.c: Revert.
4801         * bfd-target.c: Revert.
4802         * bcache.c: Revert.
4803         * ax-general.c: Revert.
4804         * ax-gdb.h: Revert.
4805         * ax-gdb.c: Revert.
4806         * avr-tdep.c: Revert.
4807         * auxv.c: Revert.
4808         * auto-load.c: Revert.
4809         * arm-wince-tdep.c: Revert.
4810         * arm-tdep.c: Revert.
4811         * arm-symbian-tdep.c: Revert.
4812         * arm-pikeos-tdep.c: Revert.
4813         * arm-obsd-tdep.c: Revert.
4814         * arm-nbsd-tdep.c: Revert.
4815         * arm-nbsd-nat.c: Revert.
4816         * arm-linux-tdep.c: Revert.
4817         * arm-linux-nat.c: Revert.
4818         * arm-fbsd-tdep.c: Revert.
4819         * arm-fbsd-nat.c: Revert.
4820         * arm-bsd-tdep.c: Revert.
4821         * arch-utils.c: Revert.
4822         * arc-tdep.c: Revert.
4823         * arc-newlib-tdep.c: Revert.
4824         * annotate.h: Revert.
4825         * annotate.c: Revert.
4826         * amd64-windows-tdep.c: Revert.
4827         * amd64-windows-nat.c: Revert.
4828         * amd64-tdep.c: Revert.
4829         * amd64-sol2-tdep.c: Revert.
4830         * amd64-obsd-tdep.c: Revert.
4831         * amd64-obsd-nat.c: Revert.
4832         * amd64-nbsd-tdep.c: Revert.
4833         * amd64-nbsd-nat.c: Revert.
4834         * amd64-nat.c: Revert.
4835         * amd64-linux-tdep.c: Revert.
4836         * amd64-linux-nat.c: Revert.
4837         * amd64-fbsd-tdep.c: Revert.
4838         * amd64-fbsd-nat.c: Revert.
4839         * amd64-dicos-tdep.c: Revert.
4840         * amd64-darwin-tdep.c: Revert.
4841         * amd64-bsd-nat.c: Revert.
4842         * alpha-tdep.c: Revert.
4843         * alpha-obsd-tdep.c: Revert.
4844         * alpha-nbsd-tdep.c: Revert.
4845         * alpha-mdebug-tdep.c: Revert.
4846         * alpha-linux-tdep.c: Revert.
4847         * alpha-linux-nat.c: Revert.
4848         * alpha-bsd-tdep.c: Revert.
4849         * alpha-bsd-nat.c: Revert.
4850         * aix-thread.c: Revert.
4851         * agent.c: Revert.
4852         * addrmap.c: Revert.
4853         * ada-varobj.c: Revert.
4854         * ada-valprint.c: Revert.
4855         * ada-typeprint.c: Revert.
4856         * ada-tasks.c: Revert.
4857         * ada-lang.c: Revert.
4858         * aarch64-tdep.c: Revert.
4859         * aarch64-ravenscar-thread.c: Revert.
4860         * aarch64-newlib-tdep.c: Revert.
4861         * aarch64-linux-tdep.c: Revert.
4862         * aarch64-linux-nat.c: Revert.
4863         * aarch64-fbsd-tdep.c: Revert.
4864         * aarch64-fbsd-nat.c: Revert.
4865         * aarch32-linux-nat.c: Revert.
4866
4867 2019-04-05  Tom Tromey  <tom@tromey.com>
4868
4869         * ft32-tdep.c: Sort headers.
4870         * frv-tdep.c: Sort headers.
4871         * frv-linux-tdep.c: Sort headers.
4872         * frame.c: Sort headers.
4873         * frame-unwind.c: Sort headers.
4874         * frame-base.c: Sort headers.
4875         * fork-child.c: Sort headers.
4876         * findvar.c: Sort headers.
4877         * findcmd.c: Sort headers.
4878         * filesystem.c: Sort headers.
4879         * filename-seen-cache.h: Sort headers.
4880         * filename-seen-cache.c: Sort headers.
4881         * fbsd-tdep.c: Sort headers.
4882         * fbsd-nat.h: Sort headers.
4883         * fbsd-nat.c: Sort headers.
4884         * f-valprint.c: Sort headers.
4885         * f-typeprint.c: Sort headers.
4886         * f-lang.c: Sort headers.
4887         * extension.h: Sort headers.
4888         * extension.c: Sort headers.
4889         * extension-priv.h: Sort headers.
4890         * expprint.c: Sort headers.
4891         * exec.h: Sort headers.
4892         * exec.c: Sort headers.
4893         * exceptions.c: Sort headers.
4894         * event-top.c: Sort headers.
4895         * event-loop.c: Sort headers.
4896         * eval.c: Sort headers.
4897         * elfread.c: Sort headers.
4898         * dwarf2read.h: Sort headers.
4899         * dwarf2read.c: Sort headers.
4900         * dwarf2loc.c: Sort headers.
4901         * dwarf2expr.h: Sort headers.
4902         * dwarf2expr.c: Sort headers.
4903         * dwarf2-frame.c: Sort headers.
4904         * dwarf2-frame-tailcall.c: Sort headers.
4905         * dwarf-index-write.h: Sort headers.
4906         * dwarf-index-write.c: Sort headers.
4907         * dwarf-index-common.c: Sort headers.
4908         * dwarf-index-cache.h: Sort headers.
4909         * dwarf-index-cache.c: Sort headers.
4910         * dummy-frame.c: Sort headers.
4911         * dtrace-probe.c: Sort headers.
4912         * disasm.h: Sort headers.
4913         * disasm.c: Sort headers.
4914         * disasm-selftests.c: Sort headers.
4915         * dictionary.c: Sort headers.
4916         * dicos-tdep.c: Sort headers.
4917         * demangle.c: Sort headers.
4918         * dcache.h: Sort headers.
4919         * dcache.c: Sort headers.
4920         * darwin-nat.h: Sort headers.
4921         * darwin-nat.c: Sort headers.
4922         * darwin-nat-info.c: Sort headers.
4923         * d-valprint.c: Sort headers.
4924         * d-namespace.c: Sort headers.
4925         * d-lang.c: Sort headers.
4926         * ctf.c: Sort headers.
4927         * csky-tdep.c: Sort headers.
4928         * csky-linux-tdep.c: Sort headers.
4929         * cris-tdep.c: Sort headers.
4930         * cris-linux-tdep.c: Sort headers.
4931         * cp-valprint.c: Sort headers.
4932         * cp-support.c: Sort headers.
4933         * cp-namespace.c: Sort headers.
4934         * cp-abi.c: Sort headers.
4935         * corelow.c: Sort headers.
4936         * corefile.c: Sort headers.
4937         * continuations.c: Sort headers.
4938         * completer.h: Sort headers.
4939         * completer.c: Sort headers.
4940         * complaints.c: Sort headers.
4941         * coffread.c: Sort headers.
4942         * coff-pe-read.c: Sort headers.
4943         * cli-out.h: Sort headers.
4944         * cli-out.c: Sort headers.
4945         * charset.c: Sort headers.
4946         * c-varobj.c: Sort headers.
4947         * c-valprint.c: Sort headers.
4948         * c-typeprint.c: Sort headers.
4949         * c-lang.c: Sort headers.
4950         * buildsym.c: Sort headers.
4951         * buildsym-legacy.c: Sort headers.
4952         * build-id.h: Sort headers.
4953         * build-id.c: Sort headers.
4954         * btrace.c: Sort headers.
4955         * bsd-uthread.c: Sort headers.
4956         * breakpoint.h: Sort headers.
4957         * breakpoint.c: Sort headers.
4958         * break-catch-throw.c: Sort headers.
4959         * break-catch-syscall.c: Sort headers.
4960         * break-catch-sig.c: Sort headers.
4961         * blockframe.c: Sort headers.
4962         * block.c: Sort headers.
4963         * bfin-tdep.c: Sort headers.
4964         * bfin-linux-tdep.c: Sort headers.
4965         * bfd-target.c: Sort headers.
4966         * bcache.c: Sort headers.
4967         * ax-general.c: Sort headers.
4968         * ax-gdb.h: Sort headers.
4969         * ax-gdb.c: Sort headers.
4970         * avr-tdep.c: Sort headers.
4971         * auxv.c: Sort headers.
4972         * auto-load.c: Sort headers.
4973         * arm-wince-tdep.c: Sort headers.
4974         * arm-tdep.c: Sort headers.
4975         * arm-symbian-tdep.c: Sort headers.
4976         * arm-pikeos-tdep.c: Sort headers.
4977         * arm-obsd-tdep.c: Sort headers.
4978         * arm-nbsd-tdep.c: Sort headers.
4979         * arm-nbsd-nat.c: Sort headers.
4980         * arm-linux-tdep.c: Sort headers.
4981         * arm-linux-nat.c: Sort headers.
4982         * arm-fbsd-tdep.c: Sort headers.
4983         * arm-fbsd-nat.c: Sort headers.
4984         * arm-bsd-tdep.c: Sort headers.
4985         * arch-utils.c: Sort headers.
4986         * arc-tdep.c: Sort headers.
4987         * arc-newlib-tdep.c: Sort headers.
4988         * annotate.h: Sort headers.
4989         * annotate.c: Sort headers.
4990         * amd64-windows-tdep.c: Sort headers.
4991         * amd64-windows-nat.c: Sort headers.
4992         * amd64-tdep.c: Sort headers.
4993         * amd64-sol2-tdep.c: Sort headers.
4994         * amd64-obsd-tdep.c: Sort headers.
4995         * amd64-obsd-nat.c: Sort headers.
4996         * amd64-nbsd-tdep.c: Sort headers.
4997         * amd64-nbsd-nat.c: Sort headers.
4998         * amd64-nat.c: Sort headers.
4999         * amd64-linux-tdep.c: Sort headers.
5000         * amd64-linux-nat.c: Sort headers.
5001         * amd64-fbsd-tdep.c: Sort headers.
5002         * amd64-fbsd-nat.c: Sort headers.
5003         * amd64-dicos-tdep.c: Sort headers.
5004         * amd64-darwin-tdep.c: Sort headers.
5005         * amd64-bsd-nat.c: Sort headers.
5006         * alpha-tdep.c: Sort headers.
5007         * alpha-obsd-tdep.c: Sort headers.
5008         * alpha-nbsd-tdep.c: Sort headers.
5009         * alpha-mdebug-tdep.c: Sort headers.
5010         * alpha-linux-tdep.c: Sort headers.
5011         * alpha-linux-nat.c: Sort headers.
5012         * alpha-bsd-tdep.c: Sort headers.
5013         * alpha-bsd-nat.c: Sort headers.
5014         * aix-thread.c: Sort headers.
5015         * agent.c: Sort headers.
5016         * addrmap.c: Sort headers.
5017         * ada-varobj.c: Sort headers.
5018         * ada-valprint.c: Sort headers.
5019         * ada-typeprint.c: Sort headers.
5020         * ada-tasks.c: Sort headers.
5021         * ada-lang.c: Sort headers.
5022         * aarch64-tdep.c: Sort headers.
5023         * aarch64-ravenscar-thread.c: Sort headers.
5024         * aarch64-newlib-tdep.c: Sort headers.
5025         * aarch64-linux-tdep.c: Sort headers.
5026         * aarch64-linux-nat.c: Sort headers.
5027         * aarch64-fbsd-tdep.c: Sort headers.
5028         * aarch64-fbsd-nat.c: Sort headers.
5029         * aarch32-linux-nat.c: Sort headers.
5030
5031 2019-04-04  Tom Tromey  <tom@tromey.com>
5032
5033         * varobj.c (varobj_create): Update.
5034         * rust-exp.y (struct rust_parser) <update_innermost_block,
5035         lookup_symbol>: New methods.
5036         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5037         Rename.
5038         (rust_parser::rust_lookup_type)
5039         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5040         * printcmd.c (display_command, do_one_display): Update.
5041         * parser-defs.h (struct parser_state) <parser_state>: Add
5042         "tracker" parameter.
5043         (block_tracker): New member.
5044         (class innermost_block_tracker) <innermost_block_tracker>: Add
5045         "types" parameter.
5046         <reset>: Remove method.
5047         (innermost_block): Don't declare.
5048         (null_post_parser): Update.
5049         * parse.c (innermost_block): Remove global.
5050         (write_dollar_variable): Update.
5051         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5052         Remove "tracker_types" parameter.
5053         (parse_expression): Add "tracker" parameter.
5054         (parse_expression_for_completion): Update.
5055         (null_post_parser): Add "tracker" parameter.
5056         * p-exp.y: Update rules.
5057         * m2-exp.y: Update rules.
5058         * language.h (struct language_defn) <la_post_parser>: Add
5059         "tracker" parameter.
5060         * go-exp.y: Update rules.
5061         * f-exp.y: Update rules.
5062         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5063         parameter.
5064         * d-exp.y: Update rules.
5065         * c-exp.y: Update rules.
5066         * breakpoint.c (set_breakpoint_condition): Create an
5067         innermost_block_tracker.
5068         (watch_command_1): Likewise.
5069         * ada-lang.c (resolve): Add "tracker" parameter.
5070         (resolve_subexp): Likewise.
5071         * ada-exp.y (write_var_from_sym): Update.
5072
5073 2019-04-04  Tom Tromey  <tom@tromey.com>
5074
5075         * type-stack.h: New file.
5076         * type-stack.c: New file.
5077         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5078         type-stack.h.
5079         (insert_into_type_stack, insert_type, push_type, push_type_int)
5080         (insert_type_address_space, pop_type, pop_type_int)
5081         (pop_typelist, pop_type_stack, append_type_stack)
5082         (push_type_stack, get_type_stack, push_typelist)
5083         (follow_type_instance_flags, follow_types): Don't declare.
5084         * parse.c (type_stack): Remove global.
5085         (parse_exp_in_context): Update.
5086         (insert_into_type_stack, insert_type, push_type, push_type_int)
5087         (insert_type_address_space, pop_type, pop_type_int)
5088         (pop_typelist, pop_type_stack, append_type_stack)
5089         (push_type_stack, get_type_stack, push_typelist)
5090         (follow_type_instance_flags, follow_types): Remove (moved to
5091         type-stack.c).
5092         * f-exp.y (type_stack): New global.
5093         Update rules.
5094         (push_kind_type, f_parse): Update.
5095         * d-exp.y (type_stack): New global.
5096         Update rules.
5097         (d_parse): Update.
5098         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5099         Update rules.
5100         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5101         (HFILES_NO_SRCDIR): Add type-stack.h.
5102
5103 2019-04-04  Tom Tromey  <tom@tromey.com>
5104
5105         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5106         (rust_parser::convert_ast_to_expression, rust_parse)
5107         (rust_lex_test_completion, rust_lex_tests): Update.
5108         * parser-defs.h (struct expr_completion_state): New.
5109         (struct parser_state) <parser_state>: Add completion parameter.
5110         <mark_struct_expression, mark_completion_tag>: New methods.
5111         <parse_completion, m_completion_state>: New members.
5112         (prefixify_expression, null_post_parser): Update.
5113         (mark_struct_expression, mark_completion_tag): Don't declare.
5114         * parse.c (parse_completion, expout_last_struct)
5115         (expout_tag_completion_type, expout_completion_name): Remove
5116         globals.
5117         (parser_state::mark_struct_expression)
5118         (parser_state::mark_completion_tag): Now methods.
5119         (prefixify_expression): Add last_struct parameter.
5120         (prefixify_subexp): Likewise.
5121         (parse_exp_1): Update.
5122         (parse_exp_in_context): Add cstate parameter.  Update.
5123         (parse_expression_for_completion): Create an
5124         expr_completion_state.
5125         (null_post_parser): Add "completion" parameter.
5126         * p-exp.y: Update rules.
5127         (yylex): Update.
5128         * language.h (struct language_defn) <la_post_parser>: Add
5129         "completing" parameter.
5130         * go-exp.y: Update rules.
5131         (lex_one_token): Update.
5132         * expression.h (parse_completion): Don't declare.
5133         * d-exp.y: Update rules.
5134         (lex_one_token): Update rules.
5135         * c-exp.y: Update rules.
5136         (lex_one_token): Update.
5137         * ada-lang.c (resolve): Add "parse_completion" parameter.
5138         (resolve_subexp): Likewise.
5139         (ada_resolve_function): Likewise.
5140
5141 2019-04-04  Tom Tromey  <tom@tromey.com>
5142
5143         * parser-defs.h (struct parser_state) <start_arglist,
5144         end_arglist>: New methods.
5145         <arglist_len, m_funcall_chain>: New members.
5146         (arglist_len, start_arglist, end_arglist): Don't declare.
5147         * parse.c (arglist_len, funcall_chain): Remove global.
5148         (start_arglist, end_arglist): Remove functions.
5149         (parse_exp_in_context): Update.
5150         * p-exp.y: Update rules.
5151         * m2-exp.y: Update rules.
5152         * go-exp.y: Update rules.
5153         * f-exp.y: Update rules.
5154         * d-exp.y: Update rules.
5155         * c-exp.y: Update rules.
5156
5157 2019-04-04  Tom Tromey  <tom@tromey.com>
5158
5159         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5160         lex_operator, push_back>: New methods.
5161         Update all rules.
5162         (rust_parser::lex_hex, lex_escape): Rename and update.
5163         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5164         (rust_parser::lex_operator): Rename and update.
5165         (rust_parser::lex_number, rustyylex, rustyyerror)
5166         (rust_lex_test_init, rust_lex_test_sequence)
5167         (rust_lex_test_push_back, rust_lex_tests): Update.
5168         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5169         parameter.
5170         <lexptr, prev_lexptr>: New members.
5171         (lexptr, prev_lexptr): Don't declare.
5172         * parse.c (lexptr, prev_lexptr): Remove globals.
5173         (parse_exp_in_context): Update.
5174         * p-exp.y (yylex, yyerror): Update.
5175         * m2-exp.y (parse_number, yylex, yyerror): Update.
5176         * go-exp.y (lex_one_token, yyerror): Update.
5177         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5178         * d-exp.y (lex_one_token, yyerror): Update.
5179         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5180         (lex_one_token, yyerror): Update.
5181         * ada-lex.l (YY_INPUT): Update.
5182         (rewind_to_char): Update.
5183         * ada-exp.y (yyerror): Update.
5184
5185 2019-04-04  Tom Tromey  <tom@tromey.com>
5186
5187         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5188         * parser-defs.h (struct parser_state) <parser_state>: Add new
5189         parameter.
5190         <comma_terminates>: New member.
5191         (comma_terminates): Don't declare global.
5192         * parse.c (comma_terminates): Remove global.
5193         (parse_exp_in_context): Update.
5194         * p-exp.y (yylex): Update.
5195         * m2-exp.y (yylex): Update.
5196         * go-exp.y (lex_one_token): Update.
5197         * f-exp.y (yylex): Update.
5198         * d-exp.y (lex_one_token): Update.
5199         * c-exp.y (lex_one_token): Update.
5200         * ada-lex.l: Update.
5201
5202 2019-04-04  Tom Tromey  <tom@tromey.com>
5203
5204         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5205         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5206         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5207         * parser-defs.h (paren_depth): Don't declare.
5208         * parse.c (paren_depth): Remove global.
5209         (parse_exp_in_context): Update.
5210         * p-exp.y (paren_depth): New global.
5211         (pascal_parse): Initialize it.
5212         * m2-exp.y (paren_depth): New global.
5213         (m2_parse): Initialize it.
5214         * go-exp.y (paren_depth): New global.
5215         (go_parse): Initialize it.
5216         * f-exp.y (paren_depth): New global.
5217         (f_parse): Initialize it.
5218         * d-exp.y (paren_depth): New global.
5219         (d_parse): Initialize it.
5220         * c-exp.y (paren_depth): New global.
5221         (c_parse): Initialize it.
5222         * ada-lex.l (paren_depth): New global.
5223         (lexer_init): Initialize it.
5224
5225 2019-04-04  Tom Tromey  <tom@tromey.com>
5226
5227         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5228         (rust_parser::convert_ast_to_type)
5229         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5230         * parser-defs.h (struct parser_state) <parser_state>: Add
5231         parameters.  Initialize new members.
5232         <expression_context_block, expression_context_pc>: New members.
5233         * parse.c (expression_context_block, expression_context_pc):
5234         Remove globals.
5235         (parse_exp_in_context): Update.
5236         * p-exp.y: Update all rules.
5237         (yylex): Update.
5238         * m2-exp.y: Update all rules.
5239         (yylex): Update.
5240         * go-exp.y (yylex): Update.
5241         * f-exp.y (yylex): Update.
5242         * d-exp.y: Update all rules.
5243         (yylex): Update.
5244         * c-exp.y: Update all rules.
5245         (lex_one_token, classify_name, yylex, c_parse): Update.
5246         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5247
5248 2019-04-04  Tom Tromey  <tom@tromey.com>
5249
5250         * gdbarch.h, gdbarch.c: Rebuild.
5251         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5252         * stap-probe.h:
5253         (struct stap_parse_info): Replace "parser_state" with
5254         "expr_builder".
5255         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5256         (parser_state): New class.
5257         * parse.c (expr_builder): Rename.
5258         (expr_builder::release): Rename.
5259         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5260         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5261         (write_exp_elt_longcst, write_exp_elt_floatcst)
5262         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5263         (write_exp_string_vector, write_exp_bitstring)
5264         (write_exp_msymbol, mark_struct_expression)
5265         (write_dollar_variable)
5266         (insert_type_address_space, increase_expout_size): Replace
5267         "parser_state" with "expr_builder".
5268         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5269         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5270         "parser_state" with "expr_builder".
5271
5272 2019-04-04  Tom Tromey  <tom@tromey.com>
5273
5274         * rust-exp.y: Replace "parse_language" with method call.
5275         * p-exp.y:
5276         (yylex): Replace "parse_language" with method call.
5277         * m2-exp.y:
5278         (yylex): Replace "parse_language" with method call.
5279         * go-exp.y (classify_name): Replace "parse_language" with method
5280         call.
5281         * f-exp.y (yylex): Replace "parse_language" with method call.
5282         * d-exp.y (lex_one_token): Replace "parse_language" with method
5283         call.
5284         * c-exp.y:
5285         (lex_one_token, classify_name, yylex): Replace "parse_language"
5286         with method call.
5287         * ada-exp.y (find_primitive_type, type_char)
5288         (type_system_address): Replace "parse_language" with method call.
5289
5290 2019-04-04  Tom Tromey  <tom@tromey.com>
5291
5292         * rust-exp.y: Replace "parse_gdbarch" with method call.
5293         * parse.c (write_dollar_variable, insert_type_address_space):
5294         Replace "parse_gdbarch" with method call.
5295         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5296         call.
5297         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5298         call.
5299         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5300         "parse_gdbarch" with method call.
5301         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5302         with method call.
5303         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5304         "parse_gdbarch" with method call.
5305         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5306         "parse_gdbarch" with method call.
5307         * c-exp.y (parse_type, parse_number, classify_name): Replace
5308         "parse_gdbarch" with method call.
5309         * ada-lex.l: Replace "parse_gdbarch" with method call.
5310         * ada-exp.y (parse_type, find_primitive_type, type_char)
5311         (type_system_address): Replace "parse_gdbarch" with method call.
5312
5313 2019-04-04  Tom Tromey  <tom@tromey.com>
5314
5315         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5316         * stap-probe.c (stap_parse_argument): Update.
5317         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5318         initial_size parameter.
5319         * rust-exp.y (rust_lex_tests): Update.
5320         * parse.c (parser_state): Update.
5321         (parse_exp_in_context): Update.
5322         * parser-defs.h (struct parser_state) <parser_state>: Remove
5323         "initial_size" parameter.
5324
5325 2019-04-04  Tom Tromey  <tom@tromey.com>
5326
5327         * parser-defs.h (increase_expout_size): Don't declare.
5328         * parse.c (increase_expout_size): Now static.
5329
5330 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5331
5332         * gnu-nat.c (gnu_nat_target::wait): Fix
5333         target_waitstatus_to_string call.
5334
5335 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * eval.c (evaluate_subexp_standard): Handle internal functions
5338         during Fortran function call handling.
5339
5340 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * NEWS: Mention new internal functions.
5343         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5344         (read_base_type): Use dwarf2_init_complex_target_type.
5345         * value.c (creal_internal_fn): New function.
5346         (cimag_internal_fn): New function.
5347         (_initialize_values): Register new internal functions.
5348
5349 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5350
5351         * infrun.c (stop_all_threads): If debug_infrun, always
5352         trace the wait status after wait_one, using
5353         target_waitstatus_to_string and target_pid_to_str.
5354         (handle_inferior_event): Replace various trace of
5355         wait status kind by a single trace.
5356         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5357         wait status kind image by target_waitstatus_to_string.
5358         * target/waitstatus.c (target_waitstatus_to_string): Fix
5359         obsolete comment.
5360
5361 2019-04-01  Tom Tromey  <tromey@adacore.com>
5362
5363         PR symtab/23331:
5364         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5365
5366 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5367             Pedro Alves  <palves@redhat.com>
5368
5369         * top.c (quit_force): Call 'finalize_values'.
5370         * value.c (finalize_values): New function.
5371         * value.h (finalize_values): Declare.
5372
5373 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5374
5375         * NEWS: Announce $_gdb_major and $_gdb_minor.
5376
5377         * top.c (init_gdb_version_vars): New function.
5378         (gdb_init): Call init_gdb_version_vars.
5379
5380 2019-03-29  Tom Tromey  <tromey@adacore.com>
5381
5382         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5383         help text.  Remove dead code.
5384
5385 2019-03-29  Keith Seitz  <keiths@redhat.com>
5386
5387         From Siddhesh Poyarekar:
5388         * f-lang.h (f77_get_upperbound): Return LONGEST.
5389         (f77_get_lowerbound): Likewise.
5390         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5391         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5392         print them.
5393         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5394         plongest to format print it.
5395         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5396         (f77_get_upperbound): Likewise.
5397         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5398         LOWER_BOUND to LONGEST.
5399         (f77_create_arrayprint_offset_tbl): Likewise.
5400
5401 2019-03-29  Keith Seitz  <keiths@redhat.com>
5402
5403         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5404         %s/pulongest for TYPE_LENGTH instead of %d in format
5405         strings.
5406         * ada-typerint.c (ada_print_type): Likewise.
5407         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5408         * compile/compile-c-support.c (generate_register_struct): Likewise.
5409         * gdbtypes.c (recursive_dump_type): Likewise.
5410         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5411         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5412         instead of %d in format strings.
5413         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5414         to std::min to ULONGEST.
5415         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5416         instead of %d in format strings.
5417         * tracepoint.c (info_scope_command): Likewise.
5418         * typeprint.c (print_offset_data::update)
5419         (print_offset_data::finish): Likewise.
5420         * xtensa-tdep.c (xtensa_store_return_value)
5421         (xtensa_push_dummy_call): Likewise.
5422
5423 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5424
5425         * windows-nat.c (display_selector): Fixed format specifications
5426         for 64-bit Cygwin.
5427
5428 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5429
5430         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5431
5432 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5433
5434         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5435         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5436         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5437         (nios2_linux_init_abi): Install it.
5438
5439 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5440
5441         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5442
5443 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5444
5445         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5446
5447 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5448             Tom Tromey  <tromey@adacore.com>
5449
5450         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5451
5452 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5453
5454         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5455         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5456         method to compute the bounds of range types. Also print "[evaluated]"
5457         if the bounds' values come from a dynamic evaluation.
5458
5459 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5462         whitespace when pretty printing is on.
5463
5464 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5465
5466         * ppc-linux-nat.c: Add include.
5467
5468 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5469
5470         * NEWS: Mention AArch64 Pointer Authentication.
5471
5472 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5473
5474         * arm-linux-nat.c: Add include.
5475
5476 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5477
5478         * source-cache.c (source_cache::get_source_lines): Re-read
5479         fullname after calling open_source_file.
5480
5481 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5482
5483         * NEWS: Mention TLS support for FreeBSD.
5484
5485 2019-03-25  Tom Tromey  <tromey@adacore.com>
5486
5487         * minsyms.c (BUNCH_SIZE): Update comment.
5488         (~minimal_symbol_reader): Remove old comment.
5489         (compact_minimal_symbols): Update comment.
5490         (minimal_symbol_reader::install): Remove old comment.  Update
5491         other comments.
5492
5493 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5494
5495         * s390-linux-nat.c: Add include.
5496
5497 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5498
5499         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5500         Call linux_get_hwcap.
5501         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5502         Likewise.
5503         (aarch64_linux_get_hwcap): Remove function.
5504         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5505         declaration.
5506         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5507         linux_get_hwcap.
5508         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5509         * linux-tdep.c (linux_get_hwcap): Add function.
5510         (linux_get_hwcap2): Likewise.
5511         * linux-tdep.h (linux_get_hwcap): Add declaration.
5512         (linux_get_hwcap2): Likewise.
5513         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5514         (ppc_linux_get_hwcap2): Likewise.
5515         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5516         linux_get_hwcap.
5517         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5518         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5519         (ppc_linux_nat_target::read_description): Likewise.
5520         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5521         * s390-linux-nat.c: Likewise.
5522         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5523
5524 2019-03-24  Tom Tromey  <tom@tromey.com>
5525
5526         * ada-lang.c (standard_lookup): Simplify initialization.
5527         (ada_lookup_symbol_nonlocal): Simplify return.
5528         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5529         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5530         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5531         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5532         initialization.
5533         * solib.c (solib_global_lookup): Simplify.
5534         * symtab.c (null_block_symbol): Remove.
5535         (symbol_cache_lookup): Simplify returns.
5536         (lookup_language_this): Simplify returns.
5537         (lookup_symbol_aux): Simplify return.
5538         (lookup_local_symbol): Simplify returns.
5539         (lookup_global_symbol_from_objfile): Simplify return.
5540         (lookup_symbol_in_objfile_symtabs)
5541         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5542         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5543         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5544         * cp-namespace.c (cp_lookup_bare_symbol)
5545         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5546         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5547         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5548         (cp_lookup_symbol_via_imports): Simplify initialization.
5549         (find_symbol_in_baseclass): Likewise.
5550         * symtab.h (null_block_symbol): Remove.
5551         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5552         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5553         (d_lookup_symbol_module): Likewise.
5554         (find_symbol_in_baseclass): Simplify initialization.
5555
5556 2019-03-24  Tom Tromey  <tom@tromey.com>
5557
5558         * expression.h: Don't include symtab.h.
5559         (struct block): Forward declare.
5560
5561 2019-03-24  Tom Tromey  <tom@tromey.com>
5562
5563         * c-exp.y (typebase): Remove casts.
5564         * gdbtypes.c (lookup_unsigned_typename, )
5565         (lookup_signed_typename): Remove cast.
5566         * eval.c (parse_to_comma_and_eval): Remove cast.
5567         * parse.c (write_dollar_variable): Remove cast.
5568         * block.h (struct block) <superblock>: Now const.
5569         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5570         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5571         (map_block): Make "block" const.
5572         * symfile.h (struct quick_symbol_functions)
5573         <map_matching_symbols>: Constify block argument to "callback".
5574         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5575         const.
5576         (find_pc_sect_compunit_symtab): Make "b" const.
5577         (find_symbol_at_address): Likewise.
5578         (search_symbols): Likewise.
5579         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5580         (dw2_debug_names_lookup_symbol): Likewise.
5581         (dw2_map_matching_symbols): Update.
5582         * p-valprint.c (pascal_val_print): Remove "block".
5583         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5584         (aux_add_nonlocal_symbols): Make "block" const.
5585         (resolve_subexp): Remove cast.
5586         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5587         const.
5588         (iterate_over_file_blocks): Likewise.
5589         * f-exp.y (%union) <bval>: Remove.
5590         * coffread.c (patch_opaque_types): Make "b" const.
5591         * spu-tdep.c (spu_catch_start): Make "block" const.
5592         * c-valprint.c (print_unpacked_pointer): Remove "block".
5593         * symmisc.c (dump_symtab_1): Make "b" const.
5594         (block_depth): Make "block" const.
5595         * d-exp.y (%union) <bval>: Remove.
5596         * cp-support.h (cp_lookup_rtti_type): Update.
5597         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5598         * psymtab.c (psym_lookup_symbol): Make "block" const.
5599         (maintenance_check_psymtabs): Make "b" const.
5600         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5601         (enumerate_locals, enumerate_args): Update.
5602         * python/py-symtab.c (stpy_global_block): Make "block" const.
5603         (stpy_static_block): Likewise.
5604         * inline-frame.c (block_starting_point_at): Make "new_block"
5605         const.
5606         * block.c (find_block_in_blockvector): Make return type const.
5607         (blockvector_for_pc_sect): Make "b" const.
5608         (find_block_in_blockvector): Make "b" const.
5609
5610 2019-03-23  Tom Tromey  <tom@tromey.com>
5611
5612         * varobj.c (varobj_create): Update.
5613         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5614         * printcmd.c (display_command, do_one_display): Don't reset
5615         innermost_block.
5616         * parser-defs.h (enum innermost_block_tracker_type): Move to
5617         expression.h.
5618         (innermost_block): Update comment.
5619         * parse.c (parse_exp_1): Add tracker_types parameter.
5620         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5621         tracker_types parameter.  Reset innermost_block.
5622         (parse_exp_in_context): Remove.
5623         (parse_expression_for_completion): Update.
5624         * objfiles.c (~objfile): Don't reset expression_context_block or
5625         innermost_block.
5626         * expression.h (enum innermost_block_tracker_type): Move from
5627         parser-defs.h.
5628         (parse_exp_1): Add tracker_types parameter.
5629         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5630         reset innermost_block.
5631
5632 2019-03-23  Tom Tromey  <tom@tromey.com>
5633
5634         * objfiles.h: Include bcache.h.
5635
5636 2019-03-23  Tom Tromey  <tom@tromey.com>
5637
5638         * linespec.c (get_current_search_block): Use
5639         scoped_restore_current_language.
5640         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5641
5642 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5643             Jiong Wang  <jiong.wang@arm.com>
5644
5645         * aarch64-linux-tdep.c
5646         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5647         section.
5648         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5649
5650 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5651             Jiong Wang  <jiong.wang@arm.com>
5652
5653         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5654         instructions.
5655         (aarch64_analyze_prologue_test): Add PACIASP test.
5656         (aarch64_prologue_prev_register): Unmask PC value.
5657
5658 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5659             Jiong Wang  <jiong.wang@arm.com>
5660
5661         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5662         (aarch64_dwarf2_prev_register): Unmask PC value.
5663         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5664         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5665         DW_CFA_AARCH64_negate_ra_state.
5666         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5667
5668 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5669             Jiong Wang  <jiong.wang@arm.com>
5670
5671         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5672         registers.
5673         (aarch64_pseudo_register_name): Likewise.
5674         (aarch64_pseudo_register_type): Likewise.
5675         (aarch64_pseudo_register_reggroup_p): Likewise.
5676         (aarch64_gdbarch_init): Add pauth registers.
5677         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5678         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5679         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5680         (struct gdbarch_tdep): Add regnum for ra_state.
5681
5682 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5683             Jiong Wang  <jiong.wang@arm.com>
5684
5685         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5686
5687 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5688             Jiong Wang  <jiong.wang@arm.com>
5689
5690         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5691         function.
5692         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5693         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5694         (aarch64_gdbarch_init): Add puth registers.
5695         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5696         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5697         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5698
5699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5700             Jiong Wang  <jiong.wang@arm.com>
5701
5702         * aarch64-linux-nat.c
5703         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5704         * aarch64-linux-tdep.c
5705         (aarch64_linux_core_read_description): Likewise.
5706         (aarch64_linux_get_hwcap): New function.
5707         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5708         (aarch64_linux_get_hwcap): New declaration.
5709
5710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5711             Jiong Wang  <jiong.wang@arm.com>
5712
5713         * aarch64-linux-nat.c
5714         (aarch64_linux_nat_target::read_description): Add pauth param.
5715         * aarch64-linux-tdep.c
5716         (aarch64_linux_core_read_description): Likewise.
5717         * aarch64-tdep.c (struct target_desc): Add in pauth.
5718         (aarch64_read_description): Add pauth param.
5719         (aarch64_gdbarch_init): Likewise.
5720         * aarch64-tdep.h (aarch64_read_description): Likewise.
5721         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5722         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5723         * features/Makefile: Add new files.
5724         * features/aarch64-pauth.c: New file.
5725         * features/aarch64-pauth.xml: New file.
5726
5727 2019-03-20  Tom Tromey  <tromey@adacore.com>
5728
5729         * infrun.c (handle_inferior_event): Rename from
5730         handle_inferior_event_1.  Create a scoped_value_mark.
5731         (handle_inferior_event): Remove.
5732
5733 2019-03-19  Tom Tromey  <tromey@adacore.com>
5734
5735         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5736         * infrun.h (print_stop_event): Add "displays" parameter.
5737         * infrun.c (print_stop_event): Add "displays" parameter.
5738
5739 2019-03-19  Pedro Alves  <palves@redhat.com>
5740
5741         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5742         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5743         to -1.  Fix TABs vs spaces.
5744         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5745         * tui/tui-out.h (tui_ui_out) Add intro comments.
5746         <m_line, m_start_of_line>: In-class initialize, and add describing
5747         comment.
5748
5749 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5750
5751         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5752         variable names.
5753         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5754
5755 2019-03-18  Pedro Alves  <palves@redhat.com>
5756             Eli Zaretskii <eliz@gnu.org>
5757
5758         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5759         m_line and m_start_of_line.
5760
5761 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5762
5763         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5764         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5765         it returns a newline.  This fixes a regression in TU mode, whereby
5766         the next line is output on the same screen line as the user input.
5767
5768 2019-03-18  Tom Tromey  <tromey@adacore.com>
5769
5770         * minsyms.c (minimal_symbol_reader::install): Remove call to
5771         obstack_blank.
5772
5773 2019-03-18  Pedro Alves  <palves@redhat.com>
5774
5775         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5776         New globals.
5777         (apply_style): New, factored out from ...
5778         (apply_ansi_escape): ... this.  Handle reverse video mode.
5779         (tui_set_reverse_mode): New function.
5780         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5781         * tui/tui-winsource.c (tui_show_source_line): Use
5782         tui_set_reverse_mode instead of setting A_STANDOUT.
5783         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5784         New setter methods.
5785
5786 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5787
5788         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5789         Handle tabs.
5790
5791 2019-03-18  Tom Tromey  <tromey@adacore.com>
5792
5793         * ada-lang.c (empty_array): Add "high" parameter.
5794         (ada_evaluate_subexp): Update.
5795
5796 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5797
5798         * unittests/string_view-selftests.c: Define
5799         _initialize_string_view_selftests unconditionally.
5800
5801 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5802
5803         PR gdb/24350
5804         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5805
5806 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5807
5808         PR gdb/24351
5809         * windows-nat.c (display_selector): Fix format specifiers.
5810
5811 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5812
5813         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5814         tui_refill_source_window instead of tui_refresh_win, to update the
5815         current execution line.  This fixes redisplay of the current line
5816         when stepping through the code with "next" or "step".
5817
5818 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5819
5820         * source-cache.c (source_cache::get_source_lines): Call
5821         find_source_lines to initialize s->nlines.  This fixes vertical
5822         scrolling of TUI source window when the DOWN arrow is pressed.
5823
5824 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5825
5826         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5827         linux-thread-db.c (_initialize_thread_db): Likewise.
5828
5829 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5830
5831         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5832         wclrtoeol in tui_show_source_line".  This reverts changes made in
5833         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5834
5835 2019-03-15  Tom Tromey  <tom@tromey.com>
5836
5837         * symtab.h (struct minimal_symbol): Derive from
5838         general_symbol_info.
5839         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5840         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5841         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5842         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5843         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5844         (MSYMBOL_SEARCH_NAME): Update.
5845         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5846         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5847         * minsyms.c (minimal_symbol_reader::record_full): Update.
5848
5849 2019-03-15  Tom Tromey  <tom@tromey.com>
5850
5851         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5852
5853 2019-03-15  Tom Tromey  <tom@tromey.com>
5854
5855         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5856         unique_xmalloc_ptr.
5857         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5858         Update.
5859         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5860         (build_minimal_symbol_hash_tables)
5861         (minimal_symbol_reader::install): Update.
5862
5863 2019-03-15  Tom Tromey  <tom@tromey.com>
5864
5865         * symtab.c (create_demangled_names_hash): Update.
5866         (symbol_set_names): Update.
5867         * objfiles.h (struct objfile_per_bfd_storage)
5868         <demangled_names_hash>: Now an htab_up.
5869         * objfiles.c (objfile_per_bfd_storage): Simplify.
5870
5871 2019-03-15  Tom Tromey  <tom@tromey.com>
5872
5873         * objfiles.h (struct objfile_per_bfd_storage): Declare
5874         destructor.
5875         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5876         New.
5877         (get_objfile_bfd_data): Use new.  Don't initialize
5878         language_of_main.
5879         (free_objfile_per_bfd_storage): Remove.
5880         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5881
5882 2019-03-15  Tom Tromey  <tom@tromey.com>
5883
5884         * symfile.c (reread_symbols): Update.
5885         * objfiles.c (objfile::objfile): Update.
5886         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5887         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5888         comment.
5889         (minimal_symbol_reader::install): Update.
5890         (terminate_minimal_symbol_table): Remove.
5891         * jit.c (jit_object_close_impl): Update.
5892
5893 2019-03-15  Tom Tromey  <tom@tromey.com>
5894
5895         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5896         initializations.
5897
5898 2019-03-15  Tom Tromey  <tom@tromey.com>
5899
5900         * objfiles.h (struct objfile_per_bfd_storage)
5901         <demangled_hash_languages>: Now a bitset.
5902         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5903         (lookup_minimal_symbol): Update.
5904
5905 2019-03-15  Tom Tromey  <tom@tromey.com>
5906
5907         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5908         Don't return the symbol.
5909         * coffread.c (record_minimal_symbol): Use record_full.
5910
5911 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5912
5913         The MS-Windows port of ncurses fails to switch to a color pair if
5914         one or both of the colors are the implicit default colors.  This
5915         change records the default colors when TUI is initialized, and
5916         then specifies them explicitly when a color pair uses the default
5917         colors.  This allows color styling in TUI mode on MS-Windows.
5918
5919         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5920         ncurses_norm_attr.
5921         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5922         colors in ncurses_norm_attr.
5923         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5924         "none", replace it with the default color recorded in
5925         ncurses_norm_attr.
5926
5927 2019-03-14  Tom Tromey  <tromey@adacore.com>
5928
5929         * source-cache.h (class source_cache) <get_source_lines>: Return
5930         std::string.
5931         * source-cache.c (source_cache::extract_lines): Handle case where
5932         first_pos==npos.  Return std::string.
5933         (source_cache::get_source_lines): Update.
5934
5935 2019-03-14  Tom Tromey  <tromey@adacore.com>
5936
5937         * NEWS: Add item for "style sources" commands.
5938         * source-cache.c (source_cache::get_source_lines): Check
5939         source_styling.
5940         * cli/cli-style.c (source_styling): New global.
5941         (_initialize_cli_style): Add "style sources" commands.
5942         (show_style_sources): New function.
5943         * cli/cli-style.h (source_styling): Declare.
5944
5945 2019-03-14  Pedro Alves  <palves@redhat.com>
5946             Tom Tromey  <tromey@adacore.com>
5947
5948         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5949         * tui/tui-winsource.c (tui_refill_source_window): New function,
5950         from...
5951         (tui_horizontal_source_scroll): ... here.  Move some logic.
5952         * cli/cli-style.c (set_style_enabled): Notify new observable.
5953         * tui/tui-hooks.c (tui_redisplay_source): New function.
5954         (tui_attach_detach_observers): Attach or detach
5955         tui_redisplay_source.
5956         * observable.h (source_styling_changed): New observable.
5957         * observable.c: Define source_styling_changed observable.
5958
5959 2019-03-13  Tom Tromey  <tromey@adacore.com>
5960
5961         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5962         (i386_gnu_nat_target::store_registers): Update.
5963         * target-debug.h (target_debug_print_std_string): New macro.
5964         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5965         * windows-tdep.c (display_one_tib): Update.
5966         * tui/tui-stack.c (tui_make_status_line): Update.
5967         * top.c (print_inferior_quit_action): Update.
5968         * thread.c (thr_try_catch_cmd): Update.
5969         (add_thread_with_info): Update.
5970         (thread_target_id_str): Update.
5971         (thr_try_catch_cmd): Update.
5972         (thread_command): Update.
5973         (thread_find_command): Update.
5974         * record-btrace.c (record_btrace_target::info_record)
5975         (record_btrace_resume_thread, record_btrace_target::resume)
5976         (record_btrace_cancel_resume, record_btrace_step_thread)
5977         (record_btrace_target::wait, record_btrace_target::wait)
5978         (record_btrace_target::wait, record_btrace_target::stop): Update.
5979         * progspace.c (print_program_space): Update.
5980         * process-stratum-target.c
5981         (process_stratum_target::thread_address_space): Update.
5982         * linux-fork.c (linux_fork_mourn_inferior)
5983         (detach_checkpoint_command, info_checkpoints_command)
5984         (linux_fork_context): Update.
5985         (linux_fork_detach): Update.
5986         (class scoped_switch_fork_info): Update.
5987         (delete_checkpoint_command): Update.
5988         * infrun.c (follow_fork_inferior): Update.
5989         (follow_fork_inferior): Update.
5990         (proceed_after_vfork_done): Update.
5991         (handle_vfork_child_exec_or_exit): Update.
5992         (follow_exec): Update.
5993         (displaced_step_prepare_throw): Update.
5994         (displaced_step_restore): Update.
5995         (start_step_over): Update.
5996         (resume_1): Update.
5997         (clear_proceed_status_thread): Update.
5998         (proceed): Update.
5999         (print_target_wait_results): Update.
6000         (do_target_wait): Update.
6001         (context_switch): Update.
6002         (stop_all_threads): Update.
6003         (restart_threads): Update.
6004         (finish_step_over): Update.
6005         (handle_signal_stop): Update.
6006         (switch_back_to_stepped_thread): Update.
6007         (keep_going_pass_signal): Update.
6008         (print_exited_reason): Update.
6009         (normal_stop): Update.
6010         * inferior.c (inferior_pid_to_str): Change return type.
6011         (print_selected_inferior): Update.
6012         (add_inferior): Update.
6013         (detach_inferior): Update.
6014         * dummy-frame.c (fprint_dummy_frames): Update.
6015         * dcache.c (dcache_info_1): Update.
6016         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6017         (btrace_fetch, btrace_clear): Update.
6018         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6019         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6020         type.
6021         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6022         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6023         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6024         * gdbarch.c, gdbarch.h: Rebuild.
6025         * gdbarch.sh (core_pid_to_str): Change return type.
6026         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6027         return type.
6028         (windows_nat_target::pid_to_str): Change return type.
6029         (windows_delete_thread): Update.
6030         (windows_nat_target::attach): Update.
6031         (windows_nat_target::files_info): Update.
6032         * target-delegates.c: Rebuild.
6033         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6034         return type.
6035         (sol_thread_target::pid_to_str): Change return type.
6036         * remote.c (class remote_target) <pid_to_str>: Change return
6037         type.
6038         (remote_target::pid_to_str): Change return type.
6039         (extended_remote_target::attach, remote_target::remote_stop_ns)
6040         (remote_target::remote_notif_remove_queued_reply)
6041         (remote_target::push_stop_reply, remote_target::disable_btrace):
6042         Update.
6043         (extended_remote_target::attach): Update.
6044         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6045         type.
6046         (gdbsim_target::pid_to_str): Change return type.
6047         * ravenscar-thread.c (struct ravenscar_thread_target)
6048         <pid_to_str>: Change return type.
6049         (ravenscar_thread_target::pid_to_str): Change return type.
6050         * procfs.c (class procfs_target) <pid_to_str>: Change return
6051         type.
6052         (procfs_target::pid_to_str): Change return type.
6053         (procfs_target::attach): Update.
6054         (procfs_target::detach): Update.
6055         (procfs_target::fetch_registers): Update.
6056         (procfs_target::store_registers): Update.
6057         (procfs_target::wait): Update.
6058         (procfs_target::files_info): Update.
6059         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6060         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6061         return type.
6062         (nto_procfs_target::pid_to_str): Change return type.
6063         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6064         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6065         return type.
6066         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6067         (exit_lwp): Update.
6068         (attach_proc_task_lwp_callback, get_detach_signal)
6069         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6070         (linux_nat_target::resume, wait_lwp, stop_callback)
6071         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6072         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6073         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6074         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6075         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6076         type.
6077         (inf_ptrace_target::attach): Update.
6078         (inf_ptrace_target::files_info): Update.
6079         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6080         type.
6081         (go32_nat_target::pid_to_str): Change return type.
6082         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6083         (gnu_nat_target::wait): Update.
6084         (gnu_nat_target::wait): Update.
6085         (gnu_nat_target::resume): Update.
6086         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6087         (fbsd_nat_target::wait): Update.
6088         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6089         type.
6090         (darwin_nat_target::attach): Update.
6091         * corelow.c (class core_target) <pid_to_str>: Change return type.
6092         (core_target::pid_to_str): Change return type.
6093         * target.c (normal_pid_to_str): Change return type.
6094         (default_pid_to_str): Likewise.
6095         (target_pid_to_str): Change return type.
6096         (target_translate_tls_address): Update.
6097         (target_announce_detach): Update.
6098         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6099         return type.
6100         (bsd_uthread_target::pid_to_str): Change return type.
6101         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6102         type.
6103         (bsd_kvm_target::pid_to_str): Change return type.
6104         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6105         return type.
6106         (aix_thread_target::pid_to_str): Change return type.
6107         * target.h (struct target_ops) <pid_to_str>: Change return type.
6108         (target_pid_to_str, normal_pid_to_str): Likewise.
6109         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6110         type.
6111         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6112         type.
6113         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6114         return type.
6115         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6116         type.
6117         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6118         type.
6119         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6120         return type.
6121
6122 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6123
6124         * NEWS: Mention that the new default MI version is 3.  Mention
6125         changes to the output of commands and events that deal with
6126         multi-location breakpoints.
6127         * breakpoint.c: Include "mi/mi-out.h".
6128         (print_one_breakpoint): Change output syntax if using MI version
6129         >= 3.
6130         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6131         New.
6132         (mi_multi_location_breakpoint_output_fixed): New.
6133         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6134         (mi_cmd_fix_multi_location_breakpoint_output): New.
6135         (mi_multi_location_breakpoint_output_fixed): New.
6136         * mi/mi-cmds.c (mi_cmds): Register command
6137         -fix-multi-location-breakpoint-output.
6138         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6139         interpreter "mi".
6140
6141 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6142
6143         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6144         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6145         instantiate mi_ui_out based on interpreter name.
6146         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6147         * mi/mi-main.c (mi_load_progress): Likewise.
6148
6149 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6150
6151         * NEWS: Combine separate "New targets" sections for 8.3.
6152
6153 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6154
6155         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6156         (ppcfbsd_init_abi): Install gdbarch
6157         "fetch_tls_load_module_address" and "get_thread_local_address"
6158         methods.
6159
6160 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6161
6162         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6163         (riscv_fbsd_init_abi): Install gdbarch
6164         "fetch_tls_load_module_address" and "get_thread_local_address"
6165         methods.
6166
6167 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6168
6169         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6170         (i386fbsd_init_abi): Install gdbarch
6171         "fetch_tls_load_module_address" and "get_thread_local_address"
6172         methods.
6173
6174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6175
6176         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6177         (amd64fbsd_init_abi): Install gdbarch
6178         "fetch_tls_load_module_address" and "get_thread_local_address"
6179         methods.
6180
6181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6182
6183         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6184         (struct fbsd_pspace_data): New type.
6185         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6186         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6187         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6188         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6189         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6190
6191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6192
6193         * gdbtypes.c (lookup_struct_elt): New function.
6194         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6195         * gdbtypes.h (struct struct_elt): New type.
6196         (lookup_struct_elt): New prototype.
6197
6198 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6199
6200         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6201         remove disabled code block.
6202
6203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6204
6205         * gdbarch.sh (get_thread_local_address): New method.
6206         * gdbarch.h, gdbarch.c: Regenerate.
6207         * target.c (target_translate_tls_address): Use
6208         gdbarch_get_thread_local_address if present instead of
6209         target::get_thread_local_address.
6210
6211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6212
6213         * target.h (target::get_thread_local_address): Update comment.
6214
6215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6216
6217         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6218         objfile->separate_debug_objfile_backlink if not NULL.
6219
6220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6221
6222         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6223         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6224         (amd64bsd_store_inferior_registers): Likewise.
6225         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6226         Enable segment base registers.
6227         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6228         PT_GETFSBASE and PT_GETGSBASE.
6229         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6230         PT_SETGSBASE.
6231         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6232         segment base registers.
6233         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6234
6235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6236
6237         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6238         Update calls to i386_target_description to add 'segments'
6239         parameter.
6240         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6241         add segment base registers.
6242         * arch/i386.c (i386_create_target_description): Add 'segments'
6243         parameter to enable segment base registers.
6244         * arch/i386.h (i386_create_target_description): Likewise.
6245         * features/i386/32bit-segments.xml: New file.
6246         * features/i386/32bit-segments.c: Generate.
6247         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6248         call to i386_target_description to add 'segments' parameter.
6249         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6250         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6251         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6252         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6253         if feature is present.
6254         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6255         Add 'segments' parameter to call to i386_target_description.
6256         (i386_target_description): Add 'segments' parameter to enable
6257         segment base registers.
6258         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6259         to call to i386_target_description.
6260         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6261         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6262         Define I386_NUM_REGS.
6263         (i386_target_description): Add 'segments' parameter to enable
6264         segment base registers.
6265
6266 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6267
6268         PR/24325
6269         * source-cache.c: #undef open and close, to avoid unresolved
6270         externals during linking.
6271
6272 2019-03-12  Tom Tromey  <tromey@adacore.com>
6273
6274         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6275         const.  Add initializers.
6276         (_initialize_remote): Don't initialize ptid globals.
6277
6278 2019-03-12  Pedro Alves  <palves@redhat.com>
6279
6280         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6281
6282 2019-03-12  Pedro Alves  <palves@redhat.com>
6283
6284         * cp-name-parser.y (main): Remove unused 'len' variable.
6285
6286 2019-03-12  Tom Tromey  <tromey@adacore.com>
6287
6288         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6289         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6290
6291 2019-03-12  Tom Tromey  <tromey@adacore.com>
6292
6293         * linux-nat.c (iterate_over_lwps): Update.
6294         (stop_callback): Remove parameter.
6295         (stop_wait_callback, detach_callback, resume_set_callback)
6296         (select_singlestep_lwp_callback, set_ignore_sigint)
6297         (status_callback, resumed_callback, resume_clear_callback)
6298         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6299         data parameter.
6300         (linux_nat_target::detach, linux_nat_target::resume)
6301         (linux_stop_and_wait_all_lwps, select_event_lwp)
6302         (linux_nat_filter_event, linux_nat_wait_1)
6303         (linux_nat_target::kill, linux_nat_target::stop)
6304         (linux_nat_target::stop): Update.
6305         (linux_nat_resume_callback): Change type.
6306         (resume_stopped_resumed_lwps, count_events_callback)
6307         (select_event_lwp_callback): Likewise.
6308         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6309         * arm-linux-nat.c (struct update_registers_data): Remove.
6310         (update_registers_callback): Change type.
6311         (arm_linux_insert_hw_breakpoint1): Update.
6312         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6313         parameter.
6314         (x86_linux_dr_set_addr): Update.
6315         (x86_linux_dr_set_control): Update.
6316         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6317         (iterate_over_lwps): Use gdb::function_view.
6318         * nat/aarch64-linux-hw-point.c (struct
6319         aarch64_dr_update_callback_param): Remove.
6320         (debug_reg_change_callback): Change type.
6321         (aarch64_notify_debug_reg_change): Update.
6322         * s390-linux-nat.c (s390_refresh_per_info): Update.
6323
6324 2019-03-11  Tom Tromey  <tromey@adacore.com>
6325
6326         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6327         redundant assignment to "this_cu".
6328
6329 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6330
6331         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6332
6333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6334
6335         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6336         from...
6337         (rank_one_type): ... this.
6338
6339 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6340
6341         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6342         from...
6343         (rank_one_type): ... this.
6344
6345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6346
6347         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6348         from...
6349         (rank_one_type): ... this.
6350
6351 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6352
6353         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6354         from...
6355         (rank_one_type): ... this.
6356
6357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6358
6359         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6360         from...
6361         (rank_one_type): ... this.
6362
6363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6364
6365         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6366         from...
6367         (rank_one_type): ... this.
6368
6369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6370
6371         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6372         from...
6373         (rank_one_type): ... this.
6374
6375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6376
6377         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6378         from...
6379         (rank_one_type): ... this.
6380
6381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6382
6383         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6384         from...
6385         (rank_one_type): ... this.
6386
6387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6388
6389         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6390         from...
6391         (rank_one_type): ... this.
6392
6393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6394
6395         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6396         from...
6397         (rank_one_type): ... this.
6398
6399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6400
6401         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6402         from...
6403         (rank_one_type): ... this.
6404
6405 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6406
6407         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6408         inferior-events' shows the example events.
6409
6410 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6411
6412         Support styling on native MS-Windows console
6413
6414         PR/24315
6415         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6416         on MS-Windows if $TERM is not defined.
6417
6418         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6419
6420         * posix-hdep.c (gdb_console_fputs):
6421         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6422         functions.
6423         * ui-file.h (gdb_console_fputs): Add prototype.
6424
6425         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6426         back to fputs only if the former returns zero.
6427
6428 2019-03-07  Tom Tromey  <tom@tromey.com>
6429
6430         * symmisc.c (print_symbol_bcache_statistics): Update.
6431         (print_objfile_statistics): Update.
6432         * symfile.c (allocate_symtab): Update.
6433         * stabsread.c: Don't include bcache.h.
6434         * psymtab.h (struct psymbol_bcache): Don't declare.
6435         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6436         (psymbol_bcache_init, psymbol_bcache_free)
6437         (psymbol_bcache_get_bcache): Don't declare.
6438         * psymtab.c (struct psymbol_bcache): Remove.
6439         (psymtab_storage::psymtab_storage): Update.
6440         (psymtab_storage::~psymtab_storage): Update.
6441         (psymbol_bcache_init, psymbol_bcache_free)
6442         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6443         (add_psymbol_to_bcache): Update.
6444         (allocate_psymtab): Update.
6445         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6446         macro_cache>: No longer pointers.
6447         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6448         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6449         * macrotab.c (macro_bcache): Update.
6450         * macroexp.c: Don't include bcache.h.
6451         * gdbtypes.c (check_types_worklist): Update.
6452         (types_deeply_equal): Remove TRY/CATCH.  Update.
6453         * elfread.c (elf_symtab_read): Update.
6454         * dwarf2read.c: Don't include bcache.h.
6455         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6456         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6457         (print_bcache_statistics, bcache_memory_used): Don't declare.
6458         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6459         methods.  Rename all data members.
6460         * bcache.c (struct bcache): Move to bcache.h.
6461         (bcache::expand_hash_table): Rename from expand_hash_table.
6462         (bcache): Remove.
6463         (bcache::insert): Rename from bcache_full.
6464         (bcache::compare): Rename from bcache_compare.
6465         (bcache_xmalloc): Remove.
6466         (bcache::~bcache): Rename from bcache_xfree.
6467         (bcache::print_statistics): Rename from print_bcache_statistics.
6468         (bcache::memory_used): Rename from bcache_memory_used.
6469
6470 2019-03-07  Pedro Alves  <palves@redhat.com>
6471
6472         * infrun.c (normal_stop): Also check for
6473         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6474
6475 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6476
6477         * f-lang.c (value_from_host_double): Moved to...
6478         * value.c (value_from_host_double): ...here.
6479         * value.h (value_from_host_double): Declare.
6480         * guile/scm-math.c (vlscm_convert_typed_number): Use
6481         value_from_host_double.
6482         (vlscm_convert_number): Likewise.
6483         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6484         * python/py-value.c (convert_value_from_python): Likewise.
6485
6486 2019-03-06  Tom Tromey  <tom@tromey.com>
6487
6488         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6489
6490 2019-03-06  Tom Tromey  <tom@tromey.com>
6491
6492         * utils.h (free_current_contents): Don't declare.
6493         * utils.c (free_current_contents): Remove.
6494
6495 2019-03-06  Tom Tromey  <tom@tromey.com>
6496
6497         * top.c (quit_force): Update.
6498         * main.c (captured_command_loop): Update.
6499         * common/new-op.c (operator new): Update.
6500         * common/common-exceptions.c (struct catcher)
6501         <save_cleanup_chain>: Remove member.
6502         (exceptions_state_mc_init): Update.
6503         (exception_try_scope_entry): Return nullptr.
6504         (exception_try_scope_exit, exception_rethrow)
6505         (throw_exception_sjlj, throw_exception_cxx): Update.
6506         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6507         (all_cleanups, do_cleanups, discard_cleanups)
6508         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6509         (restore_cleanups, restore_final_cleanups): Don't declare.
6510         (do_final_cleanups): Remove parameter.
6511         * common/cleanups.c (cleanup_chain, make_cleanup)
6512         (make_cleanup_dtor, all_cleanups, do_cleanups)
6513         (discard_my_cleanups, discard_cleanups)
6514         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6515         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6516         (null_cleanup): Remove.
6517         (do_final_cleanups): Remove parameter.
6518
6519 2019-03-06  Tom Tromey  <tom@tromey.com>
6520
6521         * remote.c (remote_target::remote_parse_stop_reply): Use
6522         unique_xmalloc_ptr.
6523
6524 2019-03-06  Tom Tromey  <tom@tromey.com>
6525
6526         * stabsread.c (struct stabs_field_info): Rename from field_info.
6527         <list, fnlist>: Add initializers.
6528         <obstack>: New member.
6529         (read_member_functions, read_struct_fields, read_baseclasses):
6530         Allocate on obstack.  Don't use cleanups.
6531         (read_one_struct_field, read_member_functions, read_struct_fields)
6532         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6533         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6534         (read_struct_type): Update.
6535
6536 2019-03-06  Tom Tromey  <tom@tromey.com>
6537
6538         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6539         * common/filestuff.h (make_cleanup_close): Don't declare.
6540         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6541         Remove.
6542
6543 2019-03-06  Tom Tromey  <tom@tromey.com>
6544
6545         * solib-aix.c: Use make_scope_exit.
6546
6547 2019-03-06  Tom Tromey  <tom@tromey.com>
6548
6549         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6550         Use make_scope_exit.
6551
6552 2019-03-06  Tom Tromey  <tom@tromey.com>
6553
6554         * solib-svr4.c (disable_probes_interface): Remove parameter.
6555         (svr4_handle_solib_event): Use make_scope_exit.
6556
6557 2019-03-06  Tom Tromey  <tom@tromey.com>
6558
6559         * remote.c (struct stop_reply_deleter): Remove.
6560         (stop_reply_up): Update.
6561         (struct stop_reply): Derive from notif_event.  Don't typedef.
6562         <regcache>: Now a std::vector.
6563         (stop_reply_xfree): Remove.
6564         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6565         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6566         (remote_target::discard_pending_stop_replies): Use delete.
6567         (remote_target::remote_parse_stop_reply): Update.
6568         (remote_target::process_stop_reply): Update.
6569         * remote-notif.h (struct notif_event): Add virtual destructor.
6570         Remove "dtr" member.
6571         (struct notif_client) <alloc_event>: Return a unique_ptr.
6572         (notif_event_xfree): Don't declare.
6573         (notif_event_up): New typedef.
6574         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6575         (notif_event_xfree, do_notif_event_xfree): Remove.
6576         (remote_notif_state_xfree): Update.
6577
6578 2019-03-06  Tom Tromey  <tom@tromey.com>
6579
6580         * infrun.c (displaced_step_clear_cleanup): Now a
6581         forward_scope_exit type.
6582         (displaced_step_prepare_throw): Update.
6583         (displaced_step_fixup): Update.
6584
6585 2019-03-06  Tom Tromey  <tom@tromey.com>
6586
6587         * inferior.h (class inferior): Update comment.
6588         * gdbthread.h (class thread_info): Update comment.
6589
6590 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6591             Tom Tromey  <tom@tromey.com>
6592
6593         * stabsread.h (struct stab_section_list): Remove.
6594         (coffstab_build_psymtabs): Update.
6595         * dbxread.c (symbuf_sections): Now a std::vector.
6596         (sect_idx): New global.
6597         (fill_symbuf): Update.
6598         (coffstab_build_psymtabs): Change type of stabsects parameter.
6599         Update.
6600         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6601         std::vector.
6602         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6603         (coff_locate_sections): Update.
6604         (coff_symfile_read): Remove cleanups.  Update.
6605         (init_stringtab): Add storage parameter.
6606         (free_stringtab, free_stringtab_cleanup): Remove.
6607         (init_lineno): Add storage parameter.
6608         (free_linetab, free_linetab_cleanup): Remove.
6609
6610 2019-03-06  Pedro Alves  <palves@redhat.com>
6611
6612         * linux-fork.c (fork_info::clobber_regs): Delete.
6613         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6614         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6615         comment.  Adjust.
6616         (scoped_switch_fork_info::scoped_switch_fork_info)
6617         (checkpoint_command, linux_fork_context): Adjust
6618         fork_save_infrun_state calls.
6619
6620 2019-03-06  Pedro Alves  <palves@redhat.com>
6621
6622         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6623         (inf_has_multiple_threads): Return 'bool' and rewrite using
6624         inferior_info::threads().
6625
6626 2019-03-06  Pedro Alves  <palves@redhat.com>
6627
6628         * linux-fork.c: Include <list>.
6629         (fork_list): Now a std::list instance.
6630         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6631         (forks_exist_p, find_last_fork): Adjust.
6632         (new_fork): Delete.
6633         (one_fork_p): New.
6634         (add_fork): Adjust.
6635         (free_fork): Delete, folded into fork_info::~fork_info().
6636         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6637         Adjust.
6638         (init_fork_list): Delete.
6639         (linux_fork_killall, linux_fork_mourn_inferior)
6640         (linux_fork_detach, info_checkpoints_command): Adjust.
6641         (_initialize_linux_fork): No longer call init_fork_list.
6642
6643 2019-03-06  Pedro Alves  <palves@redhat.com>
6644
6645         * linux-fork.c (new_fork): New, split out of ...
6646         (add_fork): ... this.  Return void.  Move "first fork" special
6647         case from here, to ...
6648         (checkpoint_command): ... here.
6649         * linux-linux.h (add_fork): Return void.
6650
6651 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6652
6653         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6654
6655 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6656             Chris January  <chris.january@arm.com>
6657             David Lecomber  <david.lecomber@arm.com>
6658
6659         * f-exp.y: New token, UNOP_INTRINSIC.
6660         (exp): New pattern using UNOP_INTRINSIC token.
6661         (f77_keywords): Add 'abs' keyword.
6662         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6663         (value_from_host_double): New function.
6664         (evaluate_subexp_f): Support UNOP_ABS.
6665
6666 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6667
6668         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6669         types.
6670
6671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6672
6673         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6674         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6675         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6676
6677 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6678
6679         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6680
6681 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6682             Chris January  <chris.january@arm.com>
6683
6684         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6685         * f-exp.y: Define 'KIND' token.
6686         (exp): New pattern for KIND expressions.
6687         (ptype): Handle types with a kind extension.
6688         (direct_abs_decl): Extend to spot kind extensions.
6689         (f77_keywords): Add 'kind' to the list.
6690         (push_kind_type): New function.
6691         (convert_to_kind_type): New function.
6692         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6693         * parse.c (operator_length_standard): Likewise.
6694         * parser-defs.h (enum type_pieces): Add tp_kind.
6695         * std-operator.def: Add UNOP_KIND.
6696
6697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6698
6699         * f-exp.y (f_parse): Set yydebug.
6700
6701 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6702
6703         * f-lang.c (evaluate_subexp_f): New function.
6704         (exp_descriptor_f): New global.
6705         (f_language_defn): Use exp_descriptor_f instead of
6706         exp_descriptor_standard.
6707
6708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6709
6710         * f-exp.y (struct token): Add comments.
6711         (dot_ops): Remove uppercase versions and the end marker.
6712         (f77_keywords): Likewise.
6713         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6714         entries in the dot_ops array are case insensitive, and use
6715         strncasecmp to compare strings.  Also some whitespace cleanup in
6716         this area.  Similar for the f77_keywords array, except entries in
6717         this list might be case sensitive.
6718
6719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * f-exp.y (struct f77_boolean_val): Add comments.
6722         (boolean_values): Remove uppercase versions, and end marker.
6723         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6724         and use strncasecmp to achieve case insensitivity.  Additionally,
6725         perform whitespace cleanup around this code.
6726
6727 2019-03-06  Tom Tromey  <tromey@adacore.com>
6728
6729         * remote-sim.c (gdbsim_target_open): Use result of
6730         gdb_argv::release.
6731
6732 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6733         Dirk Schubert  <dirk.schubert@arm.com>
6734         Chris January  <chris.january@arm.com>
6735
6736         * eval.c (evaluate_subexp_standard): Call Fortran argument
6737         wrapping logic.
6738         * f-lang.c (struct value): A value which can be passed into a
6739         Fortran function call.
6740         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6741         where appropriate.
6742         (struct type): Value ready for a Fortran function call.
6743         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6744         is needed.
6745         * f-lang.h (fortran_argument_convert): Declaration.
6746         (fortran_preserve_arg_pointer): Declaration.
6747         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6748
6749 2019-03-05  Tom Tromey  <tromey@adacore.com>
6750
6751         * python/py-prettyprint.c (print_string_repr): Remove #if.
6752         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6753
6754 2019-03-05  Tom Tromey  <tromey@adacore.com>
6755
6756         * target.c (the_dummy_target): Move later.  Change type to
6757         "dummy_target".
6758         (initialize_targets): Don't initialize the_dummy_target.
6759
6760 2019-03-05  Tom Tromey  <tromey@adacore.com>
6761
6762         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6763         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6764
6765 2019-03-05  Tom Tromey  <tromey@adacore.com>
6766
6767         * windows-nat.c (windows_nat_target::attach)
6768         (windows_nat_target::detach): Don't call gdb_flush.
6769         * valprint.c (generic_val_print, val_print, val_print_string):
6770         Don't call gdb_flush.
6771         * utils.c (defaulted_query): Don't call gdb_flush.
6772         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6773         * target.c (target_announce_detach): Don't call gdb_flush.
6774         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6775         * remote.c (extended_remote_target::attach): Don't call
6776         gdb_flush.
6777         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6778         * printcmd.c (do_examine): Don't call gdb_flush.
6779         (info_display_command): Don't call gdb_flush.
6780         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6781         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6782         * memattr.c (info_mem_command): Don't call gdb_flush.
6783         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6784         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6785         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6786         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6787         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6788         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6789         (gnu_nat_target::detach): Don't call gdb_flush.
6790         * f-valprint.c (f_val_print): Don't call gdb_flush.
6791         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6792         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6793         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6794         gdb_flush.
6795         * c-valprint.c (c_val_print): Don't call gdb_flush.
6796         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6797
6798 2019-03-05  Tom Tromey  <tromey@adacore.com>
6799
6800         * varobj.c (update_dynamic_varobj_children): Update.
6801         (install_default_visualizer): Use reset, not release.
6802         * value.c (set_internalvar): Update.
6803         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6804         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6805         ATTRIBUTE_UNUSED_RESULT.
6806
6807 2019-03-05  Tom Tromey  <tromey@adacore.com>
6808
6809         * remote.c (class scoped_remote_fd) <release>: Add
6810         ATTRIBUTE_UNUSED_RESULT.
6811
6812 2019-03-05  Tom Tromey  <tromey@adacore.com>
6813
6814         * macroexp.c (struct macro_buffer) <release>: Add
6815         ATTRIBUTE_UNUSED_RESULT.
6816
6817 2019-03-05  Tom Tromey  <tromey@adacore.com>
6818
6819         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6820         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6821         ATTRIBUTE_UNUSED_RESULT.
6822
6823 2019-03-05  Tom Tromey  <tromey@adacore.com>
6824
6825         * common/scoped_fd.h (class scoped_fd) <release>: Add
6826         ATTRIBUTE_UNUSED_RESULT.
6827
6828 2019-03-05  Tom Tromey  <tromey@adacore.com>
6829
6830         * parser-defs.h (struct parser_state) <release>: Add
6831         ATTRIBUTE_UNUSED_RESULT.
6832
6833 2019-03-05  Tom Tromey  <tromey@adacore.com>
6834
6835         * utils.h (class gdb_argv) <release>: Add
6836         ATTRIBUTE_UNUSED_RESULT.
6837         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6838
6839 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6840
6841         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6842         for-loop range, to avoid compiler warnings.
6843
6844         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6845         avoid compiler warnings about unused variables.
6846
6847         * NEWS: Mention end of support for native debugging on MS-Windows
6848         before XP.
6849
6850         PR gdb/24292
6851         * common/netstuff.c:
6852         * gdbserver/gdbreplay.c
6853         * gdbserver/remote-utils.c:
6854         * ser-tcp.c:
6855         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6856         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6857         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6858         'getaddrinfo' and 'freeaddrinfo' were not available before
6859         Windows XP, and mingw.org's MinGW headers by default define
6860         _WIN32_WINNT to 0x500.
6861
6862 2019-03-01  Gary Benson <gbenson@redhat.com>
6863
6864         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6865
6866 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6867             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6868
6869         PR gdb/8527
6870         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6871         set_sigint_trap, clear_sigint_trap.
6872
6873 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6874
6875         * target.c (target_detach): Clear the regcache and the
6876         frame cache.
6877
6878 2019-02-27  Pedro Alves  <palves@redhat.com>
6879
6880         * utils.c (set_screen_size): When we cap the height/width sizes,
6881         tweak the corresponding command variable to show "unlimited":
6882
6883 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6884             Pedro Alves  <palves@redhat.com>
6885
6886         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6887         before calling rl_set_screen_size.
6888
6889 2019-02-27  Tom Tromey  <tromey@adacore.com>
6890
6891         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6892         define.
6893         * python/py-value.c: Remove Python 2.4 workaround.
6894         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6895         workaround.
6896         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6897         Python 2.4 workaround.
6898         * python/python-internal.h: Remove Python 2.4 comment.
6899         (Py_ssize_t): Don't define.
6900         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6901         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6902         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6903         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6904         * python/python.c (do_start_initialization): Remove Python 2.4
6905         workaround.
6906         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6907         (print_children): Remove Python 2.4 workaround.
6908         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6909         workaround.
6910         (CHARBUFFERPROC_NAME): Remove.
6911         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6912         Python 2.4 workaround.
6913
6914 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6915
6916         * NEWS: Note minimum Python version.
6917
6918 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6919
6920         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6921         code from these functions.  Remove corresponding ifdefs.  Use
6922         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6923         Remove gotos and target of gotos.
6924         (infpy_search_memory): Likewise.
6925
6926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6929         (hppa_gdbarch_init): Don't register deleted functions with
6930         gdbarch.
6931
6932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6933
6934         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6935         (h8300_unwind_sp): Delete.
6936         (h8300_dummy_id): Delete.
6937         (h8300_gdbarch_init): Don't register deleted functions with
6938         gdbarch.
6939
6940 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6943         (ft32_unwind_pc): Delete.
6944         (ft32_unwind_sp): Delete.
6945         (ft32_gdbarch_init): Don't register deleted functions with
6946         gdbarch.
6947
6948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6949
6950         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6951         (frv_unwind_pc): Delete.
6952         (frv_unwind_sp): Delete.
6953         (frv_gdbarch_init): Don't register deleted functions with
6954         gdbarch.
6955
6956 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6957
6958         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6959         (riscv_unwind_pc): Delete.
6960         (riscv_unwind_sp): Delete.
6961         (riscv_gdbarch_init): Don't register deleted functions with
6962         gdbarch.
6963
6964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6967         (csky_unwind_pc): Delete.
6968         (csky_unwind_sp): Delete.
6969         (csky_gdbarch_init): Don't register deleted functions with
6970         gdbarch.
6971
6972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6975         (cris_unwind_pc): Delete.
6976         (cris_unwind_sp): Delete.
6977         (cris_gdbarch_init): Don't register deleted functions with
6978         gdbarch.
6979
6980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6983         (bfin_unwind_pc): Delete.
6984         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6985
6986 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6987
6988         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6989         (arm_unwind_pc): Delete.
6990         (arm_unwind_sp): Delete.
6991         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6992
6993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6994
6995         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6996         (arc_unwind_pc): Delete.
6997         (arc_unwind_sp): Delete.
6998         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6999
7000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7003         (alpha_unwind_pc): Delete.
7004         (alpha_gdbarch_init): Don't register deleted functions with
7005         gdbarch.
7006
7007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7010         (aarch64_unwind_pc): Delete.
7011         (aarch64_unwind_sp): Delete.
7012         (aarch64_gdbarch_init): Don't register deleted functions with
7013         gdbarch.
7014
7015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * gdbtypes.c (type_align): Don't consider static members when
7018         computing structure alignment.
7019
7020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7023         return 0 for other types.
7024         * arch-utils.c (default_type_align): Always return 0.
7025         * gdbarch.h: Regenerate.
7026         * gdbarch.sh (type_align): Extend comment.
7027         * gdbtypes.c (type_align): Add additional comments, always call
7028         gdbarch_type_align before applying the default rules.
7029         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7030         generic code will then apply a suitable default.
7031         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7032         types, return 0 for other types.
7033
7034 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7035
7036         * NEWS: Create a new section for the next release branch.
7037         Rename the section of the current branch, now that it has
7038         been cut.
7039
7040 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7041
7042         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7043         * version.in: Bump version to 8.3.50.DATE-git.
7044
7045 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7046
7047         * aix-thread.c (ptid_cmp): Remove unused variable.
7048         (get_signaled_thread): Likewise.
7049         (store_regs_user_thread): Likewise.
7050         (store_regs_kernel_thread): Likewise.
7051         (fetch_regs_kernel_thread): Remove shadowed variable.
7052
7053 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7054
7055         * features/riscv/32bit-cpu.xml: Add register numbers.
7056         * features/riscv/32bit-fpu.c: Regenerate.
7057         * features/riscv/32bit-fpu.xml: Add register numbers.
7058         * features/riscv/64bit-cpu.xml: Add register numbers.
7059         * features/riscv/64bit-fpu.c: Regenerate.
7060         * features/riscv/64bit-fpu.xml: Add register numbers.
7061
7062 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7063
7064         * NEWS: Mention two argument form of gdb.Value constructor.
7065         * python/py-value.c (convert_buffer_and_type_to_value): New
7066         function.
7067         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7068         Add support for handling an optional second argument.  Call
7069         convert_buffer_and_type_to_value as appropriate.
7070         * python/python-internal.h (Py_buffer_deleter): New struct.
7071         (Py_buffer_up): New typedef.
7072
7073 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7074
7075         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7076         instead of releasing ownership.
7077
7078 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7079
7080         * dwarf2read.c (open_and_init_dwp_file): Call
7081         elf_numsections instead of bfd_count_sections to initialize
7082         dwp_file->num_sections.
7083
7084 2019-02-25  Tom Tromey  <tromey@adacore.com>
7085
7086         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7087
7088 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7089
7090         * gcore.in: Add '--readnever' option when invoking GDB.
7091
7092 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7093
7094         * MAINTAINERS: Update my email address.
7095
7096 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7097
7098         * build-id.c (build_id_to_debug_bfd_1): New function.
7099         (build_id_to_debug_bfd): Look for separate debug file in
7100         sysroot.
7101
7102 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7103
7104         * gdbarch.sh: Update the copyright year range that is placed into
7105         generated files.
7106
7107 2019-02-22  Keith Seitz  <keiths@redhat.com>
7108
7109         PR symtab/23853
7110         * linespec.c (create_sals_line_offset): Search for the default
7111         symtab's filename instead of its fullname.
7112
7113 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7114
7115         * NEWS: Update style defaults.
7116
7117 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7118
7119         * main.c (captured_main_1): Disable styling in batch mode.
7120
7121 2019-02-20  Tom Tromey  <tom@tromey.com>
7122
7123         * symtab.c (symtab_symbol_info): Fix typos.
7124
7125 2019-02-20  Tom Tromey  <tromey@adacore.com>
7126
7127         * findcmd.c (_initialize_mem_search): Use upper case for
7128         metasyntactic variables.
7129
7130 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7131
7132         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7133         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7134
7135 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7136
7137         * top.h (source_file_name): Change to std::string.
7138         * top.c (source_file_name): Likewise.
7139         (command_line_input): Adjust.
7140         * cli/cli-script.c (script_from_file): Adjust.
7141
7142 2019-02-19  Tom Tromey  <tromey@adacore.com>
7143
7144         * ravenscar-thread.c
7145         (ravenscar_thread_target::update_thread_list): Don't call
7146         ada_build_task_list.
7147         * ada-lang.h (ada_build_task_list): Don't declare.
7148         * ada-tasks.c (struct ada_tasks_inferior_data)
7149         <task_list_valid_p>: Now bool.
7150         (read_known_tasks, ada_task_list_changed)
7151         (ada_tasks_invalidate_inferior_data): Update.
7152         (read_known_tasks_array): Return bool.
7153         (read_known_tasks_list): Likewise.
7154         (read_known_tasks): Return void.
7155         (ada_build_task_list): Now static.
7156
7157 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7160         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7161
7162 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7163
7164         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7165         variant for ada_tasks_pspace_data_handle and
7166         ada_tasks_inferior_data_handle.
7167         (ada_tasks_pspace_data_cleanup): New function.
7168         (ada_tasks_inferior_data_cleanup): New function.
7169
7170 2019-02-17  Tom Tromey  <tom@tromey.com>
7171
7172         * macrotab.h (macro_source_fullname): Return a std::string.
7173         * macrotab.c (macro_include, check_for_redefinition)
7174         (macro_undef, macro_lookup_definition, foreach_macro)
7175         (foreach_macro_in_scope): Update.
7176         (macro_source_fullname): Return a std::string.
7177         * macrocmd.c (show_pp_source_pos): Update.
7178
7179 2019-02-17  Tom Tromey  <tom@tromey.com>
7180
7181         * macrocmd.c (show_pp_source_pos): Style the file names.
7182
7183 2019-02-17  Tom Tromey  <tom@tromey.com>
7184
7185         PR tui/24197:
7186         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7187
7188 2019-02-17  Tom Tromey  <tom@tromey.com>
7189
7190         * ada-lang.c (user_select_syms): Use filtered printing.
7191         * utils.c (wrap_style): New global.
7192         (desired_style): Remove.
7193         (emit_style_escape): Add stream parameter.
7194         (set_output_style, reset_terminal_style, prompt_for_continue):
7195         Update.
7196         (flush_wrap_buffer): Only flush gdb_stdout.
7197         (wrap_here): Set wrap_style.
7198         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7199         treat escape sequences as a character.  Change when wrap buffer is
7200         flushed.
7201         (fputs_styled): Do not set the output style when the default is
7202         requested.
7203         * ui-style.h (struct ui_file_style) <is_default>: New method.
7204         * source.c (print_source_lines_base): Emit escape sequences in one
7205         piece.
7206
7207 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7208
7209         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7210         integers and enumeration types.
7211
7212 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7213
7214         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7215         instead of lookup_symbol_in_language
7216         (do_exact_match): New function.
7217         (ada_get_symbol_name_matcher): Return do_exact_match when
7218         doing a verbatim match.
7219
7220 2019-02-15  Tom Tromey  <tromey@adacore.com>
7221
7222         * ravenscar-thread.c (ravenscar_thread_target::resume)
7223         (ravenscar_thread_target::wait): Special case wildcard requests.
7224
7225 2019-02-15  Tom Tromey  <tromey@adacore.com>
7226
7227         * ravenscar-thread.c (base_ptid): Remove.
7228         (struct ravenscar_thread_target) <close>: New method.
7229         <m_base_ptid>: New member.
7230         <update_inferior_ptid, active_task, task_is_currently_active,
7231         runtime_initialized>: Declare methods.
7232         <ravenscar_thread_target>: Add constructor.
7233         (ravenscar_thread_target::task_is_currently_active)
7234         (ravenscar_thread_target::update_inferior_ptid)
7235         (ravenscar_runtime_initialized): Rename.  Now methods.
7236         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7237         (ravenscar_thread_target::update_thread_list): Update.
7238         (ravenscar_thread_target::active_task): Now method.
7239         (ravenscar_thread_target::store_registers)
7240         (ravenscar_thread_target::prepare_to_store)
7241         (ravenscar_thread_target::prepare_to_store)
7242         (ravenscar_thread_target::mourn_inferior): Update.
7243         (ravenscar_inferior_created): Use "new" to create target.
7244         (ravenscar_thread_target::get_ada_task_ptid): Update.
7245         (_initialize_ravenscar): Don't initialize base_ptid.
7246         (ravenscar_ops): Remove global.
7247
7248 2019-02-15  Tom Tromey  <tromey@adacore.com>
7249
7250         * target.h (push_target): Declare new overload.
7251         * target.c (push_target): New overload, taking an rvalue reference.
7252         * remote.c (remote_target::open_1): Use push_target overload.
7253         * corelow.c (core_target_open): Use push_target overload.
7254
7255 2019-02-15  Tom Tromey  <tromey@adacore.com>
7256
7257         * ravenscar-thread.c (is_ravenscar_task)
7258         (ravenscar_task_is_currently_active): Return bool.
7259         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7260         (_initialize_ravenscar): Remove "(void)".
7261         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7262         Return bool.
7263
7264 2019-02-15  Tom Tromey  <tromey@adacore.com>
7265
7266         * ravenscar-thread.c (ravenscar_runtime_initializer)
7267         (has_ravenscar_runtime, get_running_thread_id)
7268         (ravenscar_thread_target::resume): Fix indentation.
7269
7270 2019-02-15  Tom Tromey  <tromey@adacore.com>
7271
7272         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7273         from ravenscar_arch_ops.
7274         (sparc_ravenscar_ops::fetch_registers)
7275         (sparc_ravenscar_ops::store_registers): Now methods.
7276         (sparc_ravenscar_prepare_to_store): Remove.
7277         (sparc_ravenscar_ops): Redefine.
7278         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7279         methods and destructor.  Remove members.
7280         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7281         (ravenscar_thread_target::store_registers)
7282         (ravenscar_thread_target::prepare_to_store): Update.
7283         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7284         Remove.
7285         (struct ppc_ravenscar_powerpc_ops): Derive from
7286         ravenscar_arch_ops.
7287         (ppc_ravenscar_powerpc_ops::fetch_registers)
7288         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7289         (ppc_ravenscar_powerpc_ops): Redefine.
7290         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7291         (ppc_ravenscar_e500_ops::fetch_registers)
7292         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7293         (ppc_ravenscar_e500_ops): Redefine.
7294         * aarch64-ravenscar-thread.c
7295         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7296         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7297         (aarch64_ravenscar_fetch_registers)
7298         (aarch64_ravenscar_store_registers): Now methods.
7299         (aarch64_ravenscar_ops): Redefine.
7300
7301 2019-02-15  Tom Tromey  <tromey@adacore.com>
7302
7303         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7304         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7305         (ravenscar_thread_target::stopped_by_watchpoint)
7306         (ravenscar_thread_target::stopped_data_address)
7307         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7308
7309 2019-02-15  Tom Tromey  <tromey@adacore.com>
7310
7311         * ravenscar-thread.c: Fix some typos.
7312
7313 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7314             Tom Tromey  <tromey@adacore.com>
7315
7316         * ada-lang.c (ada_exception_sal): Change addr_string to a
7317         std::string.
7318         (create_ada_exception_catchpoint): Update.
7319
7320 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7321             Tom Tromey  <tromey@adacore.com>
7322
7323         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7324         (bp_location_ops): Remove.
7325         (base_breakpoint_allocate_location): Update.
7326         (free_bp_location): Update.
7327         * ada-lang.c (class ada_catchpoint_location)
7328         <ada_catchpoint_location>: Remove ops parameter.
7329         (ada_catchpoint_location_dtor): Remove.
7330         (ada_catchpoint_location_ops): Remove.
7331         (allocate_location_exception): Update.
7332         * breakpoint.h (struct bp_location_ops): Remove.
7333         (class bp_location) <bp_location>: Remove bp_location_ops
7334         parameter.
7335         <~bp_location>: Add destructor.
7336         <ops>: Remove.
7337
7338 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7339             Pedro Alves  <palves@redhat.com>
7340
7341         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7342         'PATH_MAX'.
7343
7344 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7345             Samuel Thibault  <samuel.thibault@gnu.org>
7346             Thomas Schwinge  <thomas@codesourcery.com>
7347
7348         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7349         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7350
7351 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7352
7353         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7354         (check_empty): Use "const char *".
7355
7356         * gnu-nat.c (gnu_nat_target::detach): Instead of
7357         'detach_inferior (pid)' call
7358         'detach_inferior (find_inferior_pid (pid))'.
7359
7360         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7361         'nat/fork-inferior.o'.
7362         * gnu-nat.c: #include "nat/fork-inferior.h".
7363
7364         * gnu-nat.c (gnu_nat_target::detach): Instead of
7365         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7366         * gnu-nat.h: #include "inf-child.h".
7367         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7368         'i386_gnu_nat_target::fetch_registers'.
7369         (gnu_store_registers): Rename/move to
7370         'i386_gnu_nat_target::store_registers'.
7371
7372         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7373         * gnu-nat.h (mach_thread_info): New function.
7374         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7375
7376         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7377
7378 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7379
7380         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7381
7382 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7383
7384         * windows-nat.c (windows_add_thread): Add new parameter
7385         "main_thread_p" with default value set to false.  Update
7386         function documentation as well as all callers.
7387         (windows_delete_thread): Likewise.
7388         (fake_create_process): Update call to windows_add_thread.
7389         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7390         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7391         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7392         call to windows_delete_thread.
7393
7394 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7395
7396         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7397
7398 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7399
7400         * symfile.c (find_separate_debug_file): Use canonical path of
7401         sysroot with child_path instead of gdb_sysroot if it is valid.
7402
7403 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7404
7405         * symfile.c (find_separate_debug_file): Use child_path to
7406         determine if an object file is under a sysroot.
7407
7408 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7409
7410         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7411         unittests/child-path-selftests.c.
7412         * common/pathstuff.c (child_path): New function.
7413         * common/pathstuff.h (child_path): New prototype.
7414         * unittests/child-path-selftests.c: New file.
7415
7416 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7417
7418         * symfile.c (find_separate_debug_file): Look for separate debug
7419         files in debug directories under the sysroot.
7420
7421 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7422
7423         * symtab.h (struct minimal_symbol data_p): New const method.
7424         (struct minimal_symbol text_p): Likewise.
7425         * symtab.c (output_source_filename): Use file name style
7426         to print file name.
7427         (print_symbol_info): Likewise.
7428         (print_msymbol_info): Use address style to print addresses.
7429         Use function name style to print executable text symbols.
7430         (expand_symtab_containing_pc): Use data_p.
7431         (find_pc_sect_compunit_symtab): Likewise.
7432
7433 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7434
7435         * breakpoint.c (describe_other_breakpoints): Use address style
7436         to print addresses.
7437         (say_where): Likewise.
7438
7439 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7440
7441         * ada-typeprint.c (print_func_type): Print function name
7442         style to print function name.
7443         * c-typeprint.c (c_print_type_1): Likewise.
7444
7445 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7446
7447         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7448         for execve.
7449
7450 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7451
7452         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7453         type_stack.
7454
7455 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7456
7457         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7458         TYPE_CODE_REF types.
7459
7460 2019-02-08  Jim Wilson  <jimw@sifive.com>
7461
7462         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7463         (riscv_linux_fregset): New.
7464         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7465
7466 2019-02-07  Tom Tromey  <tom@tromey.com>
7467
7468         * thread.c (thread_cancel_execution_command): Update.
7469         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7470         methods.
7471         (struct thread_fsm_ops): Remove.
7472         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7473         (thread_fsm_should_stop, thread_fsm_return_value)
7474         (thread_fsm_set_finished, thread_fsm_finished_p)
7475         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7476         Don't declare.
7477         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7478         * infrun.c (clear_proceed_status_thread)
7479         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7480         (print_stop_event): Update.
7481         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7482         Add constructor.
7483         (step_command_fsm_ops): Remove.
7484         (new_step_command_fsm): Remove.
7485         (step_1): Update.
7486         (step_command_fsm::should_stop): Rename from
7487         step_command_fsm_should_stop.
7488         (step_command_fsm::clean_up): Rename from
7489         step_command_fsm_clean_up.
7490         (step_command_fsm::do_async_reply_reason): Rename from
7491         step_command_fsm_async_reply_reason.
7492         (struct until_next_fsm): Inherit from thread_fsm.  Add
7493         constructor.
7494         (until_next_fsm_ops): Remove.
7495         (new_until_next_fsm): Remove.
7496         (until_next_fsm::should_stop): Rename from
7497         until_next_fsm_should_stop.
7498         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7499         (until_next_fsm::do_async_reply_reason): Rename from
7500         until_next_fsm_async_reply_reason.
7501         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7502         constructor.  Change type of breakpoint.
7503         (finish_command_fsm_ops): Remove.
7504         (new_finish_command_fsm): Remove.
7505         (finish_command_fsm::should_stop): Rename from
7506         finish_command_fsm_should_stop.
7507         (finish_command_fsm::clean_up): Rename from
7508         finish_command_fsm_clean_up.
7509         (finish_command_fsm::return_value): Rename from
7510         finish_command_fsm_return_value.
7511         (finish_command_fsm::do_async_reply_reason): Rename from
7512         finish_command_fsm_async_reply_reason.
7513         (finish_command): Update.
7514         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7515         Add constructor.
7516         (call_thread_fsm_ops): Remove.
7517         (call_thread_fsm::call_thread_fsm): Rename from
7518         new_call_thread_fsm.
7519         (call_thread_fsm::should_stop): Rename from
7520         call_thread_fsm_should_stop.
7521         (call_thread_fsm::should_notify_stop): Rename from
7522         call_thread_fsm_should_notify_stop.
7523         (run_inferior_call, call_function_by_hand_dummy): Update.
7524         * cli/cli-interp.c (should_print_stop_to_console): Update.
7525         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7526         Add constructor.  Change type of location_breakpoint,
7527         caller_breakpoint.
7528         (until_break_fsm_ops): Remove.
7529         (new_until_break_fsm): Remove.
7530         (until_break_fsm::should_stop): Rename from
7531         until_break_fsm_should_stop.
7532         (until_break_fsm::clean_up): Rename from
7533         until_break_fsm_clean_up.
7534         (until_break_fsm::do_async_reply_reason): Rename from
7535         until_break_fsm_async_reply_reason.
7536         (until_break_command): Update.
7537         * thread-fsm.c: Remove.
7538         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7539
7540 2019-02-07  Tom Tromey  <tom@tromey.com>
7541
7542         * yy-remap.h: Add include guard.
7543         * xtensa-tdep.h: Add include guard.
7544         * xcoffread.h: Rename include guard.
7545         * varobj-iter.h: Add include guard.
7546         * tui/tui.h: Rename include guard.
7547         * tui/tui-winsource.h: Rename include guard.
7548         * tui/tui-wingeneral.h: Rename include guard.
7549         * tui/tui-windata.h: Rename include guard.
7550         * tui/tui-win.h: Rename include guard.
7551         * tui/tui-stack.h: Rename include guard.
7552         * tui/tui-source.h: Rename include guard.
7553         * tui/tui-regs.h: Rename include guard.
7554         * tui/tui-out.h: Rename include guard.
7555         * tui/tui-layout.h: Rename include guard.
7556         * tui/tui-io.h: Rename include guard.
7557         * tui/tui-hooks.h: Rename include guard.
7558         * tui/tui-file.h: Rename include guard.
7559         * tui/tui-disasm.h: Rename include guard.
7560         * tui/tui-data.h: Rename include guard.
7561         * tui/tui-command.h: Rename include guard.
7562         * tic6x-tdep.h: Add include guard.
7563         * target/waitstatus.h: Rename include guard.
7564         * target/wait.h: Rename include guard.
7565         * target/target.h: Rename include guard.
7566         * target/resume.h: Rename include guard.
7567         * target-float.h: Rename include guard.
7568         * stabsread.h: Add include guard.
7569         * rs6000-tdep.h: Add include guard.
7570         * riscv-fbsd-tdep.h: Add include guard.
7571         * regformats/regdef.h: Rename include guard.
7572         * record.h: Rename include guard.
7573         * python/python.h: Rename include guard.
7574         * python/python-internal.h: Rename include guard.
7575         * python/py-stopevent.h: Rename include guard.
7576         * python/py-ref.h: Rename include guard.
7577         * python/py-record.h: Rename include guard.
7578         * python/py-record-full.h: Rename include guard.
7579         * python/py-record-btrace.h: Rename include guard.
7580         * python/py-instruction.h: Rename include guard.
7581         * python/py-events.h: Rename include guard.
7582         * python/py-event.h: Rename include guard.
7583         * procfs.h: Add include guard.
7584         * proc-utils.h: Add include guard.
7585         * p-lang.h: Add include guard.
7586         * or1k-tdep.h: Rename include guard.
7587         * observable.h: Rename include guard.
7588         * nto-tdep.h: Rename include guard.
7589         * nat/x86-linux.h: Rename include guard.
7590         * nat/x86-linux-dregs.h: Rename include guard.
7591         * nat/x86-gcc-cpuid.h: Add include guard.
7592         * nat/x86-dregs.h: Rename include guard.
7593         * nat/x86-cpuid.h: Rename include guard.
7594         * nat/ppc-linux.h: Rename include guard.
7595         * nat/mips-linux-watch.h: Rename include guard.
7596         * nat/linux-waitpid.h: Rename include guard.
7597         * nat/linux-ptrace.h: Rename include guard.
7598         * nat/linux-procfs.h: Rename include guard.
7599         * nat/linux-osdata.h: Rename include guard.
7600         * nat/linux-nat.h: Rename include guard.
7601         * nat/linux-namespaces.h: Rename include guard.
7602         * nat/linux-btrace.h: Rename include guard.
7603         * nat/glibc_thread_db.h: Rename include guard.
7604         * nat/gdb_thread_db.h: Rename include guard.
7605         * nat/gdb_ptrace.h: Rename include guard.
7606         * nat/fork-inferior.h: Rename include guard.
7607         * nat/amd64-linux-siginfo.h: Rename include guard.
7608         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7609         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7610         * nat/aarch64-linux.h: Rename include guard.
7611         * nat/aarch64-linux-hw-point.h: Rename include guard.
7612         * mn10300-tdep.h: Add include guard.
7613         * mips-linux-tdep.h: Add include guard.
7614         * mi/mi-parse.h: Rename include guard.
7615         * mi/mi-out.h: Rename include guard.
7616         * mi/mi-main.h: Rename include guard.
7617         * mi/mi-interp.h: Rename include guard.
7618         * mi/mi-getopt.h: Rename include guard.
7619         * mi/mi-console.h: Rename include guard.
7620         * mi/mi-common.h: Rename include guard.
7621         * mi/mi-cmds.h: Rename include guard.
7622         * mi/mi-cmd-break.h: Rename include guard.
7623         * m2-lang.h: Add include guard.
7624         * location.h: Rename include guard.
7625         * linux-record.h: Rename include guard.
7626         * linux-nat.h: Add include guard.
7627         * linux-fork.h: Add include guard.
7628         * i386-darwin-tdep.h: Rename include guard.
7629         * hppa-linux-offsets.h: Add include guard.
7630         * guile/guile.h: Rename include guard.
7631         * guile/guile-internal.h: Rename include guard.
7632         * gnu-nat.h: Rename include guard.
7633         * gdb-stabs.h: Rename include guard.
7634         * frv-tdep.h: Add include guard.
7635         * f-lang.h: Add include guard.
7636         * event-loop.h: Add include guard.
7637         * darwin-nat.h: Rename include guard.
7638         * cp-abi.h: Rename include guard.
7639         * config/sparc/nm-sol2.h: Rename include guard.
7640         * config/nm-nto.h: Rename include guard.
7641         * config/nm-linux.h: Add include guard.
7642         * config/i386/nm-i386gnu.h: Rename include guard.
7643         * config/djgpp/nl_types.h: Rename include guard.
7644         * config/djgpp/langinfo.h: Rename include guard.
7645         * compile/gcc-cp-plugin.h: Add include guard.
7646         * compile/gcc-c-plugin.h: Add include guard.
7647         * compile/compile.h: Rename include guard.
7648         * compile/compile-object-run.h: Rename include guard.
7649         * compile/compile-object-load.h: Rename include guard.
7650         * compile/compile-internal.h: Rename include guard.
7651         * compile/compile-cplus.h: Rename include guard.
7652         * compile/compile-c.h: Rename include guard.
7653         * common/xml-utils.h: Rename include guard.
7654         * common/x86-xstate.h: Rename include guard.
7655         * common/version.h: Rename include guard.
7656         * common/vec.h: Rename include guard.
7657         * common/tdesc.h: Rename include guard.
7658         * common/selftest.h: Rename include guard.
7659         * common/scoped_restore.h: Rename include guard.
7660         * common/scoped_mmap.h: Rename include guard.
7661         * common/scoped_fd.h: Rename include guard.
7662         * common/safe-iterator.h: Rename include guard.
7663         * common/run-time-clock.h: Rename include guard.
7664         * common/refcounted-object.h: Rename include guard.
7665         * common/queue.h: Rename include guard.
7666         * common/ptid.h: Rename include guard.
7667         * common/print-utils.h: Rename include guard.
7668         * common/preprocessor.h: Rename include guard.
7669         * common/pathstuff.h: Rename include guard.
7670         * common/observable.h: Rename include guard.
7671         * common/netstuff.h: Rename include guard.
7672         * common/job-control.h: Rename include guard.
7673         * common/host-defs.h: Rename include guard.
7674         * common/gdb_wait.h: Rename include guard.
7675         * common/gdb_vecs.h: Rename include guard.
7676         * common/gdb_unlinker.h: Rename include guard.
7677         * common/gdb_unique_ptr.h: Rename include guard.
7678         * common/gdb_tilde_expand.h: Rename include guard.
7679         * common/gdb_sys_time.h: Rename include guard.
7680         * common/gdb_string_view.h: Rename include guard.
7681         * common/gdb_splay_tree.h: Rename include guard.
7682         * common/gdb_setjmp.h: Rename include guard.
7683         * common/gdb_ref_ptr.h: Rename include guard.
7684         * common/gdb_optional.h: Rename include guard.
7685         * common/gdb_locale.h: Rename include guard.
7686         * common/gdb_assert.h: Rename include guard.
7687         * common/filtered-iterator.h: Rename include guard.
7688         * common/filestuff.h: Rename include guard.
7689         * common/fileio.h: Rename include guard.
7690         * common/environ.h: Rename include guard.
7691         * common/common-utils.h: Rename include guard.
7692         * common/common-types.h: Rename include guard.
7693         * common/common-regcache.h: Rename include guard.
7694         * common/common-inferior.h: Rename include guard.
7695         * common/common-gdbthread.h: Rename include guard.
7696         * common/common-exceptions.h: Rename include guard.
7697         * common/common-defs.h: Rename include guard.
7698         * common/common-debug.h: Rename include guard.
7699         * common/cleanups.h: Rename include guard.
7700         * common/buffer.h: Rename include guard.
7701         * common/btrace-common.h: Rename include guard.
7702         * common/break-common.h: Rename include guard.
7703         * cli/cli-utils.h: Rename include guard.
7704         * cli/cli-style.h: Rename include guard.
7705         * cli/cli-setshow.h: Rename include guard.
7706         * cli/cli-script.h: Rename include guard.
7707         * cli/cli-interp.h: Rename include guard.
7708         * cli/cli-decode.h: Rename include guard.
7709         * cli/cli-cmds.h: Rename include guard.
7710         * charset-list.h: Add include guard.
7711         * buildsym-legacy.h: Rename include guard.
7712         * bfin-tdep.h: Add include guard.
7713         * ax.h: Rename include guard.
7714         * arm-linux-tdep.h: Add include guard.
7715         * arm-fbsd-tdep.h: Add include guard.
7716         * arch/xtensa.h: Rename include guard.
7717         * arch/tic6x.h: Add include guard.
7718         * arch/i386.h: Add include guard.
7719         * arch/arm.h: Rename include guard.
7720         * arch/arm-linux.h: Rename include guard.
7721         * arch/arm-get-next-pcs.h: Rename include guard.
7722         * arch/amd64.h: Add include guard.
7723         * arch/aarch64-insn.h: Rename include guard.
7724         * arch-utils.h: Rename include guard.
7725         * annotate.h: Add include guard.
7726         * amd64-darwin-tdep.h: Rename include guard.
7727         * aarch64-linux-tdep.h: Add include guard.
7728         * aarch64-fbsd-tdep.h: Add include guard.
7729         * aarch32-linux-nat.h: Add include guard.
7730
7731 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7732
7733         * macrotab.c (macro_define_internal): New function that
7734         factorizes macro_define_object_internal and macro_define_function
7735         code.
7736         (macro_define_object_internal): Use macro_define_internal.
7737         (macro_define_function): Likewise.
7738
7739 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7740
7741         * macrocmd.c (extract_identifier): Return
7742         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7743         callers.
7744
7745 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7746
7747         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7748
7749 2019-02-05  Tom Tromey  <tom@tromey.com>
7750
7751         * target.c (target_stack::unpush): Move assertion earlier.
7752
7753 2019-01-30  Tom Tromey  <tom@tromey.com>
7754
7755         PR python/23615:
7756         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7757         (gdbpy_parse_and_eval): Likewise.
7758         * python/python-internal.h (gdbpy_allow_threads): New class.
7759
7760 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7761
7762         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7763         (aarch64_fbsd_fpregmap): Move earlier.
7764         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7765         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7766         instead of individual calls to trad_frame_set_reg_addr.
7767         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7768         earlier.
7769         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7770         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7771         instead of individual calls to trad_frame_set_reg_addr.
7772
7773 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7774
7775         * CONTRIBUTE: Replace contribution list with wiki link.
7776
7777 2019-01-25  Tom Tromey  <tom@tromey.com>
7778
7779         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7780
7781 2019-01-25  Tom Tromey  <tom@tromey.com>
7782
7783         * xtensa-linux-nat.c: Fix common/ includes.
7784         * xml-support.h: Fix common/ includes.
7785         * xml-support.c: Fix common/ includes.
7786         * x86-linux-nat.c: Fix common/ includes.
7787         * windows-nat.c: Fix common/ includes.
7788         * varobj.h: Fix common/ includes.
7789         * varobj.c: Fix common/ includes.
7790         * value.c: Fix common/ includes.
7791         * valops.c: Fix common/ includes.
7792         * utils.c: Fix common/ includes.
7793         * unittests/xml-utils-selftests.c: Fix common/ includes.
7794         * unittests/utils-selftests.c: Fix common/ includes.
7795         * unittests/unpack-selftests.c: Fix common/ includes.
7796         * unittests/tracepoint-selftests.c: Fix common/ includes.
7797         * unittests/style-selftests.c: Fix common/ includes.
7798         * unittests/string_view-selftests.c: Fix common/ includes.
7799         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7800         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7801         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7802         * unittests/rsp-low-selftests.c: Fix common/ includes.
7803         * unittests/parse-connection-spec-selftests.c: Fix common/
7804         includes.
7805         * unittests/optional-selftests.c: Fix common/ includes.
7806         * unittests/offset-type-selftests.c: Fix common/ includes.
7807         * unittests/observable-selftests.c: Fix common/ includes.
7808         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7809         * unittests/memrange-selftests.c: Fix common/ includes.
7810         * unittests/memory-map-selftests.c: Fix common/ includes.
7811         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7812         * unittests/function-view-selftests.c: Fix common/ includes.
7813         * unittests/environ-selftests.c: Fix common/ includes.
7814         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7815         * unittests/common-utils-selftests.c: Fix common/ includes.
7816         * unittests/cli-utils-selftests.c: Fix common/ includes.
7817         * unittests/array-view-selftests.c: Fix common/ includes.
7818         * ui-file.c: Fix common/ includes.
7819         * tui/tui-io.c: Fix common/ includes.
7820         * tracepoint.h: Fix common/ includes.
7821         * tracepoint.c: Fix common/ includes.
7822         * tracefile-tfile.c: Fix common/ includes.
7823         * top.h: Fix common/ includes.
7824         * top.c: Fix common/ includes.
7825         * thread.c: Fix common/ includes.
7826         * target/waitstatus.h: Fix common/ includes.
7827         * target/waitstatus.c: Fix common/ includes.
7828         * target.h: Fix common/ includes.
7829         * target.c: Fix common/ includes.
7830         * target-memory.c: Fix common/ includes.
7831         * target-descriptions.c: Fix common/ includes.
7832         * symtab.h: Fix common/ includes.
7833         * symfile.c: Fix common/ includes.
7834         * stap-probe.c: Fix common/ includes.
7835         * spu-linux-nat.c: Fix common/ includes.
7836         * sparc-nat.c: Fix common/ includes.
7837         * source.c: Fix common/ includes.
7838         * solib.c: Fix common/ includes.
7839         * solib-target.c: Fix common/ includes.
7840         * ser-unix.c: Fix common/ includes.
7841         * ser-tcp.c: Fix common/ includes.
7842         * ser-pipe.c: Fix common/ includes.
7843         * ser-base.c: Fix common/ includes.
7844         * selftest-arch.c: Fix common/ includes.
7845         * s12z-tdep.c: Fix common/ includes.
7846         * rust-exp.y: Fix common/ includes.
7847         * rs6000-aix-tdep.c: Fix common/ includes.
7848         * riscv-tdep.c: Fix common/ includes.
7849         * remote.c: Fix common/ includes.
7850         * remote-notif.h: Fix common/ includes.
7851         * remote-fileio.h: Fix common/ includes.
7852         * remote-fileio.c: Fix common/ includes.
7853         * regcache.h: Fix common/ includes.
7854         * regcache.c: Fix common/ includes.
7855         * record-btrace.c: Fix common/ includes.
7856         * python/python.c: Fix common/ includes.
7857         * python/py-type.c: Fix common/ includes.
7858         * python/py-inferior.c: Fix common/ includes.
7859         * progspace.h: Fix common/ includes.
7860         * producer.c: Fix common/ includes.
7861         * procfs.c: Fix common/ includes.
7862         * proc-api.c: Fix common/ includes.
7863         * printcmd.c: Fix common/ includes.
7864         * ppc-linux-nat.c: Fix common/ includes.
7865         * parser-defs.h: Fix common/ includes.
7866         * osdata.c: Fix common/ includes.
7867         * obsd-nat.c: Fix common/ includes.
7868         * nat/x86-linux.c: Fix common/ includes.
7869         * nat/x86-linux-dregs.c: Fix common/ includes.
7870         * nat/x86-dregs.h: Fix common/ includes.
7871         * nat/x86-dregs.c: Fix common/ includes.
7872         * nat/ppc-linux.c: Fix common/ includes.
7873         * nat/mips-linux-watch.h: Fix common/ includes.
7874         * nat/mips-linux-watch.c: Fix common/ includes.
7875         * nat/linux-waitpid.c: Fix common/ includes.
7876         * nat/linux-ptrace.h: Fix common/ includes.
7877         * nat/linux-ptrace.c: Fix common/ includes.
7878         * nat/linux-procfs.c: Fix common/ includes.
7879         * nat/linux-personality.c: Fix common/ includes.
7880         * nat/linux-osdata.c: Fix common/ includes.
7881         * nat/linux-namespaces.c: Fix common/ includes.
7882         * nat/linux-btrace.h: Fix common/ includes.
7883         * nat/linux-btrace.c: Fix common/ includes.
7884         * nat/fork-inferior.c: Fix common/ includes.
7885         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7886         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7887         * nat/aarch64-linux.c: Fix common/ includes.
7888         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7889         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7890         * namespace.h: Fix common/ includes.
7891         * mips-linux-tdep.c: Fix common/ includes.
7892         * minsyms.c: Fix common/ includes.
7893         * mi/mi-parse.h: Fix common/ includes.
7894         * mi/mi-main.c: Fix common/ includes.
7895         * mi/mi-cmd-env.c: Fix common/ includes.
7896         * memrange.h: Fix common/ includes.
7897         * memattr.c: Fix common/ includes.
7898         * maint.h: Fix common/ includes.
7899         * maint.c: Fix common/ includes.
7900         * main.c: Fix common/ includes.
7901         * machoread.c: Fix common/ includes.
7902         * location.c: Fix common/ includes.
7903         * linux-thread-db.c: Fix common/ includes.
7904         * linux-nat.c: Fix common/ includes.
7905         * linux-fork.c: Fix common/ includes.
7906         * inline-frame.c: Fix common/ includes.
7907         * infrun.c: Fix common/ includes.
7908         * inflow.c: Fix common/ includes.
7909         * inferior.h: Fix common/ includes.
7910         * inferior.c: Fix common/ includes.
7911         * infcmd.c: Fix common/ includes.
7912         * inf-ptrace.c: Fix common/ includes.
7913         * inf-child.c: Fix common/ includes.
7914         * ia64-linux-nat.c: Fix common/ includes.
7915         * i387-tdep.c: Fix common/ includes.
7916         * i386-tdep.c: Fix common/ includes.
7917         * i386-linux-tdep.c: Fix common/ includes.
7918         * i386-linux-nat.c: Fix common/ includes.
7919         * i386-go32-tdep.c: Fix common/ includes.
7920         * i386-fbsd-tdep.c: Fix common/ includes.
7921         * i386-fbsd-nat.c: Fix common/ includes.
7922         * guile/scm-type.c: Fix common/ includes.
7923         * guile/guile.c: Fix common/ includes.
7924         * go32-nat.c: Fix common/ includes.
7925         * gnu-nat.c: Fix common/ includes.
7926         * gdbthread.h: Fix common/ includes.
7927         * gdbarch-selftests.c: Fix common/ includes.
7928         * gdb_usleep.c: Fix common/ includes.
7929         * gdb_select.h: Fix common/ includes.
7930         * gdb_bfd.c: Fix common/ includes.
7931         * gcore.c: Fix common/ includes.
7932         * fork-child.c: Fix common/ includes.
7933         * findvar.c: Fix common/ includes.
7934         * fbsd-nat.c: Fix common/ includes.
7935         * event-top.c: Fix common/ includes.
7936         * event-loop.c: Fix common/ includes.
7937         * dwarf2read.c: Fix common/ includes.
7938         * dwarf2loc.c: Fix common/ includes.
7939         * dwarf2-frame.c: Fix common/ includes.
7940         * dwarf-index-cache.c: Fix common/ includes.
7941         * dtrace-probe.c: Fix common/ includes.
7942         * disasm-selftests.c: Fix common/ includes.
7943         * defs.h: Fix common/ includes.
7944         * csky-tdep.c: Fix common/ includes.
7945         * cp-valprint.c: Fix common/ includes.
7946         * cp-support.h: Fix common/ includes.
7947         * cp-support.c: Fix common/ includes.
7948         * corelow.c: Fix common/ includes.
7949         * completer.h: Fix common/ includes.
7950         * completer.c: Fix common/ includes.
7951         * compile/compile.c: Fix common/ includes.
7952         * compile/compile-loc2c.c: Fix common/ includes.
7953         * compile/compile-cplus-types.c: Fix common/ includes.
7954         * compile/compile-cplus-symbols.c: Fix common/ includes.
7955         * command.h: Fix common/ includes.
7956         * cli/cli-dump.c: Fix common/ includes.
7957         * cli/cli-cmds.c: Fix common/ includes.
7958         * charset.c: Fix common/ includes.
7959         * build-id.c: Fix common/ includes.
7960         * btrace.h: Fix common/ includes.
7961         * btrace.c: Fix common/ includes.
7962         * breakpoint.h: Fix common/ includes.
7963         * breakpoint.c: Fix common/ includes.
7964         * ax.h:
7965         (enum agent_op): Fix common/ includes.
7966         * ax-general.c (struct aop_map): Fix common/ includes.
7967         * ax-gdb.c: Fix common/ includes.
7968         * auxv.c: Fix common/ includes.
7969         * auto-load.c: Fix common/ includes.
7970         * arm-tdep.c: Fix common/ includes.
7971         * arch/riscv.c: Fix common/ includes.
7972         * arch/ppc-linux-common.c: Fix common/ includes.
7973         * arch/i386.c: Fix common/ includes.
7974         * arch/arm.c: Fix common/ includes.
7975         * arch/arm-linux.c: Fix common/ includes.
7976         * arch/arm-get-next-pcs.c: Fix common/ includes.
7977         * arch/amd64.c: Fix common/ includes.
7978         * arch/aarch64.c: Fix common/ includes.
7979         * arch/aarch64-insn.c: Fix common/ includes.
7980         * arch-utils.c: Fix common/ includes.
7981         * amd64-windows-tdep.c: Fix common/ includes.
7982         * amd64-tdep.c: Fix common/ includes.
7983         * amd64-sol2-tdep.c: Fix common/ includes.
7984         * amd64-obsd-tdep.c: Fix common/ includes.
7985         * amd64-nbsd-tdep.c: Fix common/ includes.
7986         * amd64-linux-tdep.c: Fix common/ includes.
7987         * amd64-linux-nat.c: Fix common/ includes.
7988         * amd64-fbsd-tdep.c: Fix common/ includes.
7989         * amd64-fbsd-nat.c: Fix common/ includes.
7990         * amd64-dicos-tdep.c: Fix common/ includes.
7991         * amd64-darwin-tdep.c: Fix common/ includes.
7992         * agent.c: Fix common/ includes.
7993         * ada-lang.h: Fix common/ includes.
7994         * ada-lang.c: Fix common/ includes.
7995         * aarch64-tdep.c: Fix common/ includes.
7996
7997 2019-01-25  Tom Tromey  <tom@tromey.com>
7998
7999         * common/create-version.sh: Use common/version.h.
8000
8001 2019-01-24  Pedro Alves  <palves@redhat.com>
8002
8003         * infrun.c (signal_stop, signal_print, signal_program)
8004         (signal_catch, signal_pass): Now arrays instead of pointers.
8005         (update_signals_program_target, do_target_resume)
8006         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8007         * linux-nat.c (linux_nat_target::pass_signals)
8008         (linux_nat_target::create_inferior, linux_nat_target::attach):
8009         Adjust.
8010         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8011         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8012         * procfs.c (procfs_target::pass_signals): Adjust.
8013         * record-full.c (record_full_target::resume): Adjust.
8014         * remote.c (remote_target::pass_signals)
8015         (remote_target::program_signals): Adjust.
8016         * target-debug.h (target_debug_print_signals): Now takes a
8017         gdb::array_view as parameter.  Adjust.
8018         * target.h (target_ops) <pass_signals, program_signals>: Replace
8019         pointer and length parameters with gdb::array_view.
8020         (target_pass_signals, target_program_signals): Likewise.
8021         * target-delegates.c: Regenerate.
8022
8023 2019-01-24  Pedro Alves  <palves@redhat.com>
8024
8025         * common/forward-scope-exit.h
8026         (forward_scope_exit::forward_scope_exit): Pass arguments to
8027         m_bind_function directly, instead of creating a std::bind and
8028         copying that.
8029
8030 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8031
8032         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8033         for static members.
8034         (pass_in_v_vfp_candidate): Likewise.
8035
8036 2019-01-23  Tom Tromey  <tom@tromey.com>
8037             Pedro Alves  <palves@redhat.com>
8038
8039         * regcache.c (class regcache_invalidator): Remove.
8040         (regcache::raw_write): Use make_scope_exit.
8041
8042 2019-01-23  Tom Tromey  <tom@tromey.com>
8043
8044         * ui-out.h (class ui_out_emit_type): Update comment.
8045
8046 2019-01-23  Tom Tromey  <tom@tromey.com>
8047
8048         * infrun.c (fetch_inferior_event): Update comment.
8049
8050 2019-01-23  Tom Tromey  <tom@tromey.com>
8051             Pedro Alves  <palves@redhat.com>
8052
8053         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8054         parameter.
8055         (fetch_inferior_event): Use SCOPE_EXIT.
8056
8057
8058 2019-01-23  Tom Tromey  <tom@tromey.com>
8059             Pedro Alves  <palves@redhat.com>
8060
8061         * infrun.c (disable_thread_events): Delete.
8062         (stop_all_threads): Use SCOPE_EXIT.
8063
8064 2019-01-23  Tom Tromey  <tom@tromey.com>
8065             Pedro Alves  <palves@redhat.com>
8066
8067         * symfile.c: Include forward-scope-exit.h.
8068         (clear_symtab_users_cleanup): Replace forward declaration with
8069         a FORWARD_SCOPE_EXIT.
8070         (syms_from_objfile_1): Use the forward_scope_exit and
8071         gdb::optional instead of cleanup_function.
8072         (reread_symbols): Use the forward_scope_exit instead of
8073         cleanup_function.
8074         (clear_symtab_users_cleanup): Remove function.
8075
8076 2019-01-23  Tom Tromey  <tom@tromey.com>
8077             Pedro Alves  <palves@redhat.com>
8078
8079         * linux-nat.c: Include scope-exit.h.
8080         (cleanup_target_stop): Remove.
8081         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8082         SCOPE_EXIT.
8083
8084 2019-01-23  Tom Tromey  <tom@tromey.com>
8085             Pedro Alves  <palves@redhat.com>
8086
8087         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8088         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8089
8090 2019-01-23  Tom Tromey  <tom@tromey.com>
8091             Andrew Burgess  <andrew.burgess@embecosm.com>
8092             Pedro Alves  <palves@redhat.com>
8093
8094         * infrun.c (fetch_inferior_event): Use scope_exit.
8095         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8096         * top.c (execute_command): Use scope_exit.
8097         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8098         * utils.c (do_bpstat_clear_actions_cleanup)
8099         (make_bpstat_clear_actions_cleanup): Remove.
8100
8101 2019-01-23  Tom Tromey  <tom@tromey.com>
8102             Pedro Alves  <palves@redhat.com>
8103
8104         * infrun.c: Include "common/scope-exit.h"
8105         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8106         (wait_for_inferior): Use SCOPE_EXIT.
8107         (fetch_inferior_event): Use scope_exit.
8108
8109 2019-01-23  Tom Tromey  <tom@tromey.com>
8110             Pedro Alves  <palves@redhat.com>
8111
8112         * breakpoint.c (create_breakpoint): Remove cleanup.
8113
8114 2019-01-23  Tom Tromey  <tom@tromey.com>
8115             Andrew Burgess  <andrew.burgess@embecosm.com>
8116             Pedro Alves  <palves@redhat.com>
8117
8118 2019-01-23  Pedro Alves  <palves@redhat.com>
8119
8120         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8121
8122 2019-01-23  Pedro Alves  <palves@redhat.com>
8123             Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * gdbthread.h: Include "common/forward-scope-exit.h".
8126         (scoped_finish_thread_state): Redefine custom class in terms of
8127         forward_scope_exit.
8128
8129 2019-01-23  Pedro Alves  <palves@redhat.com>
8130             Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * common/forward-scope-exit.h: New file.
8133
8134 2019-01-23  Pedro Alves  <palves@redhat.com>
8135             Andrew Burgess  <andrew.burgess@embecosm.com>
8136             Tom Tromey  <tom@tromey.com>
8137
8138         * common/scope-exit.h: New file.
8139
8140 2019-01-23  Pedro Alves  <palves@redhat.com>
8141
8142         * common/preprocessor.h (ESC): Rename to ...
8143         (ESC_PARENS): ... this.
8144         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8145         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8146
8147 2019-01-23  Tom Tromey  <tom@tromey.com>
8148
8149         * language.h (class scoped_switch_to_sym_language_if_auto):
8150         Initialize m_lang in both cases.
8151
8152 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8153
8154         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8155         with XCNEW.
8156
8157 2019-01-22  Tom Tromey  <tom@tromey.com>
8158
8159         * corelow.c: Do not include sys/file.h.
8160
8161 2019-01-22  Tom Tromey  <tom@tromey.com>
8162
8163         * tui/tui-wingeneral.h: Include gdb_curses.h.
8164
8165 2019-01-22  Tom Tromey  <tom@tromey.com>
8166
8167         * source-cache.h (class source_cache) <get_source_lines,
8168         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8169
8170 2019-01-22  Tom Tromey  <tom@tromey.com>
8171
8172         * remote-fileio.h (struct remote_target): Declare.
8173
8174 2019-01-22  Tom Tromey  <tom@tromey.com>
8175
8176         * python/py-arch.c: Do not include py-ref.h.
8177         * python/py-bpevent.c: Do not include py-ref.h.
8178         * python/py-cmd.c: Do not include py-ref.h.
8179         * python/py-continueevent.c: Do not include py-ref.h.
8180         * python/py-event.h: Do not include py-ref.h.
8181         * python/py-evtregistry.c: Do not include py-ref.h.
8182         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8183         * python/py-frame.c: Do not include py-ref.h.
8184         * python/py-framefilter.c: Do not include py-ref.h.
8185         * python/py-function.c: Do not include py-ref.h.
8186         * python/py-infevents.c: Do not include py-ref.h.
8187         * python/py-linetable.c: Do not include py-ref.h.
8188         * python/py-objfile.c: Do not include py-ref.h.
8189         * python/py-param.c: Do not include py-ref.h.
8190         * python/py-prettyprint.c: Do not include py-ref.h.
8191         * python/py-progspace.c: Do not include py-ref.h.
8192         * python/py-symbol.c: Do not include py-ref.h.
8193         * python/py-symtab.c: Do not include py-ref.h.
8194         * python/py-type.c: Do not include py-ref.h.
8195         * python/py-unwind.c: Do not include py-ref.h.
8196         * python/py-utils.c: Do not include py-ref.h.
8197         * python/py-value.c: Do not include py-ref.h.
8198         * python/py-varobj.c: Do not include py-ref.h.
8199         * python/py-xmethods.c: Do not include py-ref.h.
8200         * python/python.c: Do not include py-ref.h.
8201         * varobj.c: Do not include py-ref.h.
8202
8203 2019-01-22  Tom Tromey  <tom@tromey.com>
8204
8205         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8206         keyword for bcache.
8207
8208 2019-01-22  Tom Tromey  <tom@tromey.com>
8209
8210         * compile/compile-cplus-types.c: Remove a comment by #include.
8211
8212 2019-01-22  Tom Tromey  <tom@tromey.com>
8213
8214         * compile/gcc-c-plugin.h: Include compile-internal.h.
8215
8216 2019-01-22  Tom Tromey  <tom@tromey.com>
8217
8218         * stabsread.c (EXTERN): Do not define.
8219         (symnum, next_symbol_text_func, processing_gcc_compilation)
8220         (within_function, global_sym_chain, global_stabs)
8221         (previous_stab_code, this_object_header_files)
8222         (n_this_object_header_files)
8223         (n_allocated_this_object_header_files): Define.
8224         * stabsread.h (EXTERN): Never define.  Use "extern".
8225
8226 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8227
8228         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8229         history_value.
8230
8231 2019-01-21  Tom Tromey  <tom@tromey.com>
8232
8233         * ui-out.c: Fix includes.
8234         * tui/tui-source.c: Fix includes.
8235         * target.c: Fix includes.
8236         * remote.c: Fix includes.
8237         * regcache.c: Fix includes.
8238         * python/py-block.c: Fix includes.
8239         * printcmd.c: Fix includes.
8240         * or1k-tdep.c: Fix includes.
8241         * mi/mi-main.c: Fix includes.
8242         * m32r-tdep.c: Fix includes.
8243         * csky-tdep.c: Fix includes.
8244         * compile/compile-cplus-types.c: Fix includes.
8245         * cli/cli-interp.c: Fix includes.
8246
8247 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8248
8249         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8250         for padding.
8251
8252 2019-01-16  Tom Tromey  <tom@tromey.com>
8253
8254         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8255         earlier.
8256         (struct objfile) <msymbols_range>: Move from top level.
8257         <msymbols>: New method.
8258         (class objfile_msymbols): Remove.
8259         * symtab.c (default_collect_symbol_completion_matches_break_on):
8260         Update.
8261         * symmisc.c (dump_msymbols): Update.
8262         * stabsread.c (scan_file_globals): Update.
8263         * objc-lang.c (info_selectors_command, info_classes_command)
8264         (find_methods): Update.
8265         * minsyms.c (find_solib_trampoline_target): Update.
8266         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8267         * coffread.c (coff_symfile_read): Update.
8268         * ada-lang.c (ada_lookup_simple_minsym)
8269         (ada_collect_symbol_completion_matches): Update.
8270
8271 2019-01-16  Tom Tromey  <tom@tromey.com>
8272
8273         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8274         type.  Remove no-argument constructor.
8275         <iterator::operator++>: Simplify.
8276         <begin>: Update.
8277         <end>: Use minimal_symbol_count.
8278
8279 2019-01-16  Tom Tromey  <tom@tromey.com>
8280
8281         * objfiles.h (struct objfile) <psymtabs>: New method.
8282         (class objfile_psymtabs): Remove.
8283         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8284         typedef.
8285         <range>: New method.
8286         (require_partial_symbols): Change return type.
8287         * psymtab.c (require_partial_symbols)
8288         (psym_expand_symtabs_matching): Update.
8289         * mdebugread.c (parse_partial_symbols): Update.
8290         * dbxread.c (dbx_end_psymtab): Update.
8291
8292 2019-01-15  Tom Tromey  <tom@tromey.com>
8293
8294         * symtab.c (lookup_objfile_from_block)
8295         (lookup_symbol_in_objfile_symtabs)
8296         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8297         (find_line_symtab, info_sources_command)
8298         (default_collect_symbol_completion_matches_break_on)
8299         (make_source_files_completion_list): Update.
8300         * symmisc.c (print_objfile_statistics, dump_objfile)
8301         (maintenance_print_symbols, maintenance_info_symtabs)
8302         (maintenance_check_symtabs, maintenance_info_line_tables):
8303         Update.
8304         * source.c (select_source_symtab)
8305         (forget_cached_source_info_for_objfile): Update.
8306         * objfiles.h (class objfile_compunits): Remove.
8307         (struct objfile) <compunits_range>: New typedef.
8308         (compunits): New method.
8309         * objfiles.c (objfile_relocate1): Update.
8310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8311         * maint.c (count_symtabs_and_blocks): Update.
8312         * linespec.c (iterate_over_all_matching_symtabs): Update.
8313         * cp-support.c (add_symbol_overload_list_qualified): Update.
8314         * coffread.c (coff_symtab_read): Update.
8315         * ada-lang.c (add_nonlocal_symbols)
8316         (ada_collect_symbol_completion_matches)
8317         (ada_add_global_exceptions): Update.
8318
8319 2019-01-15  Tom Tromey  <tom@tromey.com>
8320
8321         * progspace.h (program_space) <objfiles_safe_range>: New
8322         typedef.
8323         <objfiles_safe>: New method.
8324         * objfiles.h (class all_objfiles_safe): Remove.
8325         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8326         * jit.c (jit_inferior_exit_hook): Update.
8327
8328 2019-01-17  Tom Tromey  <tom@tromey.com>
8329
8330         * progspace.h (program_space) <objfiles_range>: New typedef.
8331         <objfiles>: New method.
8332         <objfiles_head>: Rename from objfiles.
8333         (object_files): Update.
8334         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8335         * guile/scm-pretty-print.c
8336         (ppscm_find_pretty_printer_from_objfiles): Update.
8337         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8338         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8339         Update.
8340         * python/py-progspace.c (pspy_get_objfiles): Update.
8341         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8342         Update.
8343         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8344         (objfpy_lookup_objfile_by_build_id): Update.
8345         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8346         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8347         Update.
8348         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8349         (expand_symtab_containing_pc, lookup_objfile_from_block)
8350         (lookup_static_symbol, basic_lookup_transparent_type)
8351         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8352         (find_line_symtab, info_sources_command)
8353         (default_collect_symbol_completion_matches_break_on)
8354         (make_source_files_completion_list, find_main_name): Update.
8355         * symmisc.c (print_symbol_bcache_statistics)
8356         (print_objfile_statistics, maintenance_print_symbols)
8357         (maintenance_print_msymbols, maintenance_print_objfiles)
8358         (maintenance_info_symtabs, maintenance_check_symtabs)
8359         (maintenance_expand_symtabs, maintenance_info_line_tables):
8360         Update.
8361         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8362         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8363         (map_overlay_command, unmap_overlay_command)
8364         (simple_overlay_update, expand_symtabs_matching)
8365         (map_symbol_filenames): Update.
8366         * symfile-debug.c (set_debug_symfile): Update.
8367         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8368         Update.
8369         * source.c (select_source_symtab, forget_cached_source_info):
8370         Update.
8371         * solib.c (solib_read_symbols): Update.
8372         * solib-spu.c (append_ocl_sos): Update.
8373         * psymtab.c (maintenance_print_psymbols)
8374         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8375         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8376         * printcmd.c (info_symbol_command): Update.
8377         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8378         Update.
8379         * objfiles.h (class all_objfiles): Remove.
8380         * objfiles.c (have_partial_symbols, have_full_symbols)
8381         (have_minimal_symbols, qsort_cmp, update_section_map)
8382         (shared_objfile_contains_address_p)
8383         (default_iterate_over_objfiles_in_search_order): Update.
8384         * objc-lang.c (info_selectors_command, info_classes_command)
8385         (find_methods): Update.
8386         * minsyms.c (find_solib_trampoline_target): Update.
8387         * maint.c (maintenance_info_sections)
8388         (maintenance_translate_address, count_symtabs_and_blocks):
8389         Update.
8390         * main.c (captured_main_1): Update.
8391         * linux-thread-db.c (try_thread_db_load_from_pdir)
8392         (has_libpthread): Update.
8393         * linespec.c (iterate_over_all_matching_symtabs)
8394         (search_minsyms_for_name): Update.
8395         * jit.c (jit_find_objf_with_entry_addr): Update.
8396         * hppa-tdep.c (find_unwind_entry)
8397         (hppa_lookup_stub_minimal_symbol): Update.
8398         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8399         Update.
8400         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8401         (elf_gnu_ifunc_resolve_by_got): Update.
8402         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8403         * dwarf-index-write.c (save_gdb_index_command): Update.
8404         * cp-support.c (add_symbol_overload_list_qualified): Update.
8405         * breakpoint.c (create_overlay_event_breakpoint)
8406         (create_longjmp_master_breakpoint)
8407         (create_std_terminate_master_breakpoint)
8408         (create_exception_master_breakpoint): Update.
8409         * blockframe.c (find_pc_partial_function): Update.
8410         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8411         (ada_collect_symbol_completion_matches)
8412         (ada_add_global_exceptions): Update.
8413
8414 2019-01-17  Tom Tromey  <tom@tromey.com>
8415
8416         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8417         declare VEC.
8418         (solib_target_parse_libraries): Change return type.
8419         (library_list_start_segment, library_list_start_section)
8420         (library_list_end_library, library_list_start_library); Update.
8421         (solib_target_free_library_list): Remove.
8422         (solib_target_parse_libraries): Remove cleanup.  Change return
8423         type.
8424         (solib_target_current_sos): Update.
8425
8426 2019-01-17  Tom Tromey  <tromey@bapiya>
8427
8428         * valprint.c: Replace "the the" with "the".
8429         * symtab.c: Replace "the the" with "the".
8430         * solib.c: Replace "the the" with "the".
8431         * solib-dsbt.c: Replace "the the" with "the".
8432         * linespec.c: Replace "the the" with "the".
8433         * dwarf2loc.h: Replace "the the" with "the".
8434         * amd64-windows-tdep.c: Replace "the the" with "the".
8435         * aarch64-tdep.c: Replace "the the" with "the".
8436
8437 2019-01-16  Keith Seitz  <keiths@redhat.com>
8438
8439         PR gdb/23773
8440         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8441         <builder>: Rename to ..
8442         <m_builder>: ... this and make private.
8443         (dwarf2_cu::get_builder): New method.  Change all users of
8444         `builder' to use this method.
8445         (dwarf2_start_symtab): Move to ...
8446         (dwarf2_cu::start_symtab): ... here.  Update all callers
8447         (setup_type_unit_groups): Move to ...
8448         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8449         callers.
8450         (dwarf2_cu::reset_builder): New method.
8451         (process_full_compunit, process_full_type_unit): Use
8452         dwarf2_cu::reset_builder.
8453         (follow_die_offset): Record the ancestor CU if it is different
8454         from the followed DIE's CU.
8455         (follow_die_sig_1): Likewise.
8456
8457 2019-01-15  Tom Tromey  <tom@tromey.com>
8458
8459         * remote.c (class remote_state) <buf>: Now a char_vector.
8460         <buf_size>: Remove.
8461         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8462         parameter.
8463         (remote_target::getpkt_or_notif_sane_1)
8464         (remote_target::getpkt_sane)
8465         (remote_target::getpkt_or_notif_sane): Likewise.
8466         (class remote_target) <putpkt>: New overload.
8467         (remote_target::read_frame): Change type of "buf_p".  Remove
8468         sizeof_p parameter.
8469         (packet_ok): New overload.
8470         (packet_check_result): New overload.
8471         Update all uses.
8472
8473 2019-01-14  Tom Tromey  <tom@tromey.com>
8474
8475         * remote-notif.c (handle_notification, remote_notif_ack)
8476         (remote_notif_parse): Make "buf" const.
8477         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8478         const.
8479         (remote_notif_parse, remote_notif_ack, handle_notification):
8480         Likewise.
8481         * remote.c (remote_notif_stop_parse): Make "buf" const.
8482         (remote_target::remote_parse_stop_reply): Make "buf" const.
8483         (remote_notif_stop_ack): Make "buf" const.
8484
8485 2019-01-14  Tom Tromey  <tom@tromey.com>
8486
8487         * remote.c (remote_console_output): Make parameter const.
8488
8489 2019-01-14  Tom Tromey  <tom@tromey.com>
8490
8491         * target-debug.h (target_debug_print_signals): Constify.
8492         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8493         * procfs.c (procfs_target::pass_signals): Update.
8494         * linux-nat.c (linux_nat_target::pass_signals): Update.
8495         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8496         * target-delegates.c: Rebuild.
8497         * remote.c (remote_target::program_signals): Update.
8498         (remote_target::pass_signals): Update.
8499         * target.c (target_pass_signals): Constify argument.
8500         (target_program_signals): Likewise.
8501         * target.h (struct target_ops) <pass_signals, program_signals>:
8502         Constify argument.
8503         (target_pass_signals, target_program_signals): Constify argument.
8504
8505 2019-01-14  Tom Tromey  <tom@tromey.com>
8506
8507         PR tui/28819:
8508         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8509
8510 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8511
8512         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8513         field.
8514         * rs6000-tdep.c: Include reggroups.h.
8515         (IS_V_ALIAS_PSEUDOREG): Define.
8516         (rs6000_register_name): Return names for the "vX" aliases.
8517         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8518         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8519         aliases.  Call default_register_reggroup_p for all other
8520         pseudo-registers.
8521         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8522         New functions.
8523         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8524         Handle "vX" aliases.
8525         (v_alias_pseudo_register_collect): New function.
8526         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8527         (rs6000_gdbarch_init): Initialize "vX" aliases as
8528         pseudo-registers.  Restore registration of
8529         rs6000_pseudo_register_reggroup_p with
8530         set_tdesc_pseudo_register_reggroup_p.
8531
8532 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8533
8534         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8535         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8536         set_gdbarch_num_pseudo_regs.
8537
8538 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8539
8540         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8541         Remove arg prefixname, add do_set and do_show.
8542         Add member functions set_list and show_list.
8543         * cli/cli-style.c (class cli_style_option): Update accordingly.
8544         (style_set_list): Move to file scope.
8545         (style_show_list): Likewise.
8546         (set_style): Call help_list.
8547         (show_style): Call cmd_show_list.
8548         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8549         Update to use the new macro.
8550
8551 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8552
8553         * ada-lang.c (_initialize_ada_language): Expand the help text
8554         for the "catch exception" command.
8555
8556 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8557
8558         * symtab.c (matching_obj_sections): Initialize obj,
8559         declare it closer to its usage.
8560
8561 2019-01-10  Tom Tromey  <tom@tromey.com>
8562
8563         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8564         (basic_inf_threads_range): Remove.
8565         (inf_threads_range, inf_non_exited_threads_range)
8566         (safe_inf_threads_range): Use next_adapter.
8567
8568 2019-01-10  Keith Seitz  <keiths@redhat.com>
8569
8570         PR gdb/23712
8571         PR symtab/23010
8572         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8573         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8574
8575 2019-01-10  Keith Seitz  <keiths@redhat.com>
8576
8577         PR gdb/23712
8578         PR symtab/23010
8579         * dictionary.c (pending_to_vector): Remove.
8580         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8581         Remove _1 suffix, replacing functions of the same name.  Update
8582         all callers.
8583         (dict_create_hashed, dict_create_hashed_expandable)
8584         (dict_create_linear, dict_create_linear_expandable, dict_free)
8585         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8586         Make functions static.
8587
8588 2019-01-10  Keith Seitz  <keiths@redhat.com>
8589
8590         PR gdb/23712
8591         PR symtab/23010
8592         * dictionary.h (struct dictionary): Replace declaration with
8593         multidictionary.
8594         (dict_create_hashed, dict_create_hashed_expandable)
8595         (dict_create_linear, dict_create_linear_expandable)
8596         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8597         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8598         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8599         taking multidictionary argument.
8600         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8601         * block.h (struct block) <dict>: Change to multidictionary
8602         and rename `multidict'.
8603         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8604         symmisc.c: Update all dictionary references to multidictionary.
8605
8606 2019-01-10  Keith Seitz  <keiths@redhat.com>
8607
8608         PR gdb/23712
8609         PR symtab/23010
8610         * dictionary.c: Include unordered_map.
8611         (pending_to_vector): New function.
8612         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8613         Rewrite the non-"_1" functions to take vector instead
8614         of linked list.
8615         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8616         "new" _1 versions of the same name.
8617         (multidictionary): Define.
8618         (std::hash<enum language): New definition.
8619         (collate_pending_symbols_by_language, mdict_create_hashed)
8620         (mdict_create_hashed_expandable, mdict_create_linear)
8621         (mdict_create_linear_expandable, mdict_free)
8622         (find_language_dictionary, create_new_language_dictionary)
8623         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8624         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8625         (mdict_size, mdict_empty): New functions.
8626         * dictionary.h (mdict_iterator): Define.
8627
8628 2019-01-10  Pedro Alves  <palves@redhat.com>
8629
8630         * breakpoint.c (read_uploaded_action)
8631         (create_tracepoint_from_upload): Adjust to use
8632         gdb::unique_xmalloc_ptr.
8633         * ctf.c (ctf_write_uploaded_tp):
8634         (SET_ARRAY_FIELD): Use emplace_back.
8635         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8636         * tracefile-tfile.c (tfile_write_uploaded_tp):
8637         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8638         gdb::unique_xmalloc_ptr.
8639         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8640         at_string, cond_string, cmd_strings>: Replace char pointers
8641         with gdb::unique_xmalloc_ptr.
8642
8643 2019-01-10  Pedro Alves  <palves@redhat.com>
8644
8645         * solib-target.c (library_list_start_library): Don't xstrdup name.
8646
8647 2019-01-10  Pedro Alves  <palves@redhat.com>
8648
8649         * mdebugread.c (parse_partial_symbols): Use
8650         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8651
8652 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8653
8654         * linux-fork.c (scoped_switch_fork_info)
8655         <~scoped_switch_fork_info>: Fix incorrect variable name.
8656
8657 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8658
8659         * linux-fork.c (scoped_switch_fork_info)
8660         <scoped_switch_fork_info>: Make explicit.
8661         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8662
8663 2019-01-10  Tom Tromey  <tom@tromey.com>
8664
8665         * objfiles.h (objfile::reset_psymtabs): Update.
8666         * objfiles.c (objfile::objfile): Update.
8667         * psymtab.h (psymtab_storage::obstack): Update.
8668         (psymtab_storage::m_obstack): Use gdb::optional.
8669         (class psymtab_storage): Update comment.  Remove objfile
8670         parameter.
8671         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8672
8673 2019-01-10  Tom Tromey  <tom@tromey.com>
8674
8675         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8676         <free_psymtabs>: Now private.
8677         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8678         (allocate_psymtab): Use new method.
8679
8680 2019-01-10  Tom Tromey  <tom@tromey.com>
8681
8682         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8683         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8684         * mdebugread.c (parse_partial_symbols): Use
8685         allocate_dependencies.
8686         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8687         allocate_dependencies.
8688         (process_psymtab_comp_unit_reader)
8689         (build_type_psymtab_dependencies): Likewise.
8690         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8691
8692 2019-01-10  Tom Tromey  <tom@tromey.com>
8693
8694         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8695         PSYMBOL_SET_LANGUAGE.
8696         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8697
8698 2019-01-10  Tom Tromey  <tom@tromey.com>
8699
8700         * psymtab.h (psymtab_storage::obstack): New method.
8701         <m_obstack>: Rename from obstack; now private.
8702         * psymtab.c (psymtab_storage): Update.
8703         * dwarf2read.c (create_addrmap_from_index)
8704         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8705         Update.
8706
8707 2019-01-10  Tom Tromey  <tom@tromey.com>
8708
8709         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8710         * objfiles.h (objfile::reset_psymtabs): New method.
8711
8712 2019-01-10  Tom Tromey  <tom@tromey.com>
8713
8714         * symmisc.c (print_symbol_bcache_statistics): Update.
8715         (print_objfile_statistics): Update.
8716         * symfile.c (reread_symbols): Update.
8717         * psymtab.h (class psymtab_storage): New.
8718         * psymtab.c (psymtab_storage): New constructor.
8719         (~psymtab_storage): New destructor.
8720         (require_partial_symbols): Update.
8721         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8722         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8723         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8724         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8725         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8726         (start_psymtab_common, end_psymtab_common)
8727         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8728         (allocate_psymtab): Update.
8729         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8730         Update.
8731         (dump_psymtab_addrmap, maintenance_print_psymbols)
8732         (maintenance_check_psymtabs): Update.
8733         (class objfile_psymtabs): Move to objfiles.h.
8734         * psympriv.h (discard_psymtab): Now inline.
8735         (psymtab_discarder::psymtab_discarder): Update.
8736         (psymtab_discarder::~psymtab_discarder): Update.
8737         (ALL_OBJFILE_PSYMTABS): Rewrite.
8738         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8739         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8740         Remove fields.
8741         <partial_symtabs>: New field.
8742         (class objfile_psymtabs): Move from psymtab.h.  Update.
8743         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8744         psymbol_cache.
8745         (objfile::~objfile): Don't destroy psymbol_cache.
8746         * mdebugread.c (parse_partial_symbols): Update.
8747         * dwarf2read.c (create_addrmap_from_index)
8748         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8749         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8750         (add_partial_subprogram, dwarf2_ranges_read): Update.
8751         * dwarf-index-write.c (write_address_map)
8752         (write_one_signatured_type, recursively_write_psymbols)
8753         (class debug_names, class debug_names, write_psymtabs_to_index):
8754         Update.
8755
8756 2019-01-10  Tom Tromey  <tom@tromey.com>
8757
8758         * symtab.h (SYMBOL_SET_NAMES): Update.
8759         (symbol_set_names): Update.
8760         (MSYMBOL_SET_NAMES): Update.
8761         * symtab.c (symbol_set_names): Change argument to be an
8762         objfile_per_bfd_storage.
8763         * psymtab.c (add_psymbol_to_bcache): Update.
8764         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8765
8766 2019-01-10  Tom Tromey  <tom@tromey.com>
8767
8768         * symtab.c (create_demangled_names_hash): Change argument to be an
8769         objfile_per_bfd_storage.
8770         (symbol_set_names): Update.
8771
8772 2019-01-10  Tom Tromey  <tom@tromey.com>
8773
8774         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8775         init_psymbol_list.
8776         * psymtab.c (init_psymbol_list): Do nothing if already called.
8777         * psympriv.h (init_psymbol_list): Add comment.
8778         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8779         init_psymbol_list.
8780         * dbxread.c (dbx_symfile_read): Unconditionally call
8781         init_psymbol_list.
8782
8783 2019-01-10  Tom Tromey  <tom@tromey.com>
8784
8785         * xcoffread.c (scan_xcoff_symtab): Update.
8786         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8787         "where".
8788         * mdebugread.c (parse_partial_symbols)
8789         (handle_psymbol_enumerators): Update.
8790         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8791         * dbxread.c (read_dbx_symtab): Update.
8792         * psympriv.h (psymbol_placement): New enum.
8793         (add_psymbol_to_list): Update.
8794
8795 2019-01-10  Tom Tromey  <tom@tromey.com>
8796
8797         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8798         static_psymbols parameters.
8799         (scan_xcoff_symtab): Update.
8800         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8801         static_psymbols parameters.
8802         * psympriv.h (start_psymtab_common): Update.
8803         * mdebugread.c (parse_partial_symbols): Update.
8804         * dwarf2read.c (create_partial_symtab): Update.
8805         * dbxread.c (read_dbx_symtab): Update.
8806         (start_psymtab): Remove global_psymbols and static_psymbols
8807         parameters.
8808
8809 2019-01-10  Tom Tromey  <tom@tromey.com>
8810
8811         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8812         * psymtab.c (allocate_psymtab): Add comment.
8813         * psympriv.h (allocate_psymtab): Add comment.
8814         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8815         initializations.
8816         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8817
8818 2019-01-10  Tom Tromey  <tom@tromey.com>
8819
8820         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8821         Don't declare.
8822         * mipsread.c: Include mdebugread.h.
8823         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8824         Declare.
8825         * elfread.c: Include mdebugread.h.
8826
8827 2019-01-09  Tom Tromey  <tom@tromey.com>
8828
8829         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8830         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8831         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8832         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8833         (psym_lookup_symbol, psym_find_last_source_symtab)
8834         (psym_forget_cached_source_info, psym_print_stats)
8835         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8836         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8837         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8838         (psym_find_compunit_symtab_by_address)
8839         (maintenance_print_psymbols, maintenance_info_psymtabs)
8840         (maintenance_check_psymtabs): Use ranged for.
8841         * psymtab.h (class objfile_psymtabs): New.
8842         (require_partial_symbols): Return objfile_psymtabs.
8843         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8844
8845 2019-01-09  Tom Tromey  <tom@tromey.com>
8846
8847         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8848         (find_pc_mapped_section, list_overlays_command)
8849         (map_overlay_command, unmap_overlay_command)
8850         (simple_overlay_update): Use all_objfiles.
8851         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8852         * printcmd.c (info_symbol_command): Use all_objfiles.
8853         * objfiles.h (ALL_OBJSECTIONS): Remove.
8854         * maint.c (maintenance_translate_address): Use all_objfiles.
8855         * gcore.c (gcore_create_callback): Use all_objfiles.
8856         (objfile_find_memory_regions): Likewise.
8857
8858 2019-01-09  Tom Tromey  <tom@tromey.com>
8859
8860         * symtab.c (find_line_symtab, info_sources_command)
8861         (make_source_files_completion_list): Use objfile_compunits.
8862         * source.c (select_source_symtab): Use objfile_compunits.
8863         * objfiles.h (struct objfile): Update comment.
8864         (ALL_OBJFILES): Remove.
8865         (ALL_FILETABS): Remove.
8866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8867         objfile_compunits.
8868
8869 2019-01-09  Tom Tromey  <tom@tromey.com>
8870
8871         * symmisc.c (print_objfile_statistics, dump_objfile)
8872         (maintenance_print_symbols): Use compunit_filetabs.
8873         * source.c (forget_cached_source_info_for_objfile): Use
8874         compunit_filetabs.
8875         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8876         (ALL_FILETABS): Use compunit_filetabs.
8877         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8878         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8879
8880 2019-01-09  Tom Tromey  <tom@tromey.com>
8881
8882         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8883         (compunit_filetabs): New.
8884         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8885         compunit_filetabs.
8886         (info_sources_command, make_source_files_completion_list): Remove
8887         declaration.
8888         * symmisc.c (print_objfile_statistics, dump_objfile)
8889         (maintenance_print_symbols): Remove declaration.
8890         (maintenance_info_symtabs): Use compunit_filetabs.
8891         (maintenance_info_line_tables): Likewise.
8892         * source.c (select_source_symtab): Change local variable name.
8893         (forget_cached_source_info_for_objfile): Remove declaration.
8894         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8895         * objfiles.c (objfile_relocate1): Remove declaration.
8896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8897         declaration.
8898         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8899         * coffread.c (coff_symtab_read): Remove declaration.
8900         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8901         compunit_filetabs.
8902
8903 2019-01-09  Tom Tromey  <tom@tromey.com>
8904
8905         * symtab.c (lookup_objfile_from_block)
8906         (find_pc_sect_compunit_symtab, search_symbols)
8907         (default_collect_symbol_completion_matches_break_on): Use
8908         objfile_compunits.
8909         * objfiles.h (ALL_COMPUNITS): Remove.
8910         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8911         * cp-support.c (add_symbol_overload_list_qualified): Use
8912         objfile_compunits.
8913         * ada-lang.c (ada_collect_symbol_completion_matches)
8914         (ada_add_global_exceptions): Use objfile_compunits.
8915
8916 2019-01-09  Tom Tromey  <tom@tromey.com>
8917
8918         * source.c (select_source_symtab)
8919         (forget_cached_source_info_for_objfile): Remove declaration.
8920         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8921         declaration.
8922         * maint.c (count_symtabs_and_blocks): Remove declaration.
8923         * cp-support.c (add_symbol_overload_list_qualified): Remove
8924         declaration.
8925         * coffread.c (coff_symtab_read): Remove declaration.
8926         * symtab.c (lookup_symbol_in_objfile_symtabs)
8927         (basic_lookup_transparent_type_1): Use objfile_compunits.
8928         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8929         (info_sources_command, search_symbols)
8930         (default_collect_symbol_completion_matches_break_on)
8931         (make_source_files_completion_list): Remove declaration.
8932         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8933         (ada_collect_symbol_completion_matches)
8934         (ada_add_global_exceptions): Remove declaration.
8935         * linespec.c (iterate_over_all_matching_symtabs): Use
8936         objfile_compunits.
8937         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8938         (class objfile_compunits): New.
8939         (ALL_COMPUNITS): Use objfile_compunits.
8940         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8941         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8942         objfile_compunits.
8943         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8944
8945 2019-01-09  Tom Tromey  <tom@tromey.com>
8946
8947         * symtab.c (search_symbols)
8948         (default_collect_symbol_completion_matches_break_on): Use
8949         objfile_msymbols.
8950         * ada-lang.c (ada_lookup_simple_minsym)
8951         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8952         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8953         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8954         objfile_msymbols.
8955         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8956         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8957         * objc-lang.c (find_methods): Use objfile_msymbols.
8958         (info_selectors_command, info_classes_command): Likewise.
8959         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8960         * objfiles.h (class objfile_msymbols): New.
8961         (ALL_OBJFILE_MSYMBOLS): Remove.
8962         (ALL_MSYMBOLS): Remove.
8963
8964 2019-01-09  Tom Tromey  <tom@tromey.com>
8965
8966         * common/next-iterator.h (next_adapter): Add Iterator template
8967         parameter.
8968         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8969         (class all_objfiles_safe): New.
8970         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8971         * objfiles.c (put_objfile_before): Update comment.
8972         (add_separate_debug_objfile): Likewise.
8973         (free_all_objfiles): Use all_objfiles_safe.
8974         (objfile_purge_solibs): Likewise.
8975
8976 2019-01-09  Tom Tromey  <tom@tromey.com>
8977
8978         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8979         (expand_symtab_containing_pc, lookup_static_symbol)
8980         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8981         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8982         all_objfiles.
8983         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8984         * breakpoint.c (create_overlay_event_breakpoint)
8985         (create_longjmp_master_breakpoint)
8986         (create_std_terminate_master_breakpoint)
8987         (create_exception_master_breakpoint): Use all_objfiles.
8988         * linux-thread-db.c (try_thread_db_load_from_pdir)
8989         (has_libpthread): Use all_objfiles.
8990         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8991         * linespec.c (iterate_over_all_matching_symtabs)
8992         (search_minsyms_for_name): Use all_objfiles.
8993         * maint.c (maintenance_info_sections): Use all_objfiles.
8994         * main.c (captured_main_1): Use all_objfiles.
8995         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8996         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8997         * guile/scm-pretty-print.c
8998         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8999         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9000         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9001         (maintenance_print_msymbols): Use all_objfiles.
9002         * source.c (select_source_symtab): Use all_objfiles.
9003         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9004         * symfile.c (remove_symbol_file_command)
9005         (expand_symtabs_matching, map_symbol_filenames): Use
9006         all_objfiles.
9007         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9008         all_objfiles.
9009         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9010         * objc-lang.c (find_methods): Use all_objfiles.
9011         * objfiles.c (have_partial_symbols, have_full_symbols)
9012         (have_minimal_symbols, qsort_cmp)
9013         (default_iterate_over_objfiles_in_search_order): Use
9014         all_objfiles.
9015         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9016         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9017         (maintenance_check_psymtabs): Use all_objfiles.
9018         (ALL_PSYMTABS): Remove.
9019         * compile/compile-object-run.c (do_module_cleanup): Use
9020         all_objfiles.
9021         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9022         * cp-support.c (add_symbol_overload_list_qualified): Use
9023         all_objfiles.
9024         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9025         Use all_objfiles.
9026         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9027         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9028         all_objfiles.
9029         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9030         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9031         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9032         Uses all_objfiles.
9033         * solib.c (solib_read_symbols): Use all_objfiles
9034
9035 2019-01-09  Tom Tromey  <tom@tromey.com>
9036
9037         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9038         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9039         all_objfiles.
9040         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9041         * symmisc.c (print_symbol_bcache_statistics)
9042         (print_objfile_statistics, maintenance_print_objfiles)
9043         (maintenance_info_symtabs, maintenance_check_symtabs)
9044         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9045         all_objfiles.
9046         * source.c (forget_cached_source_info): Use all_objfiles.
9047         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9048         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9049         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9050         * objfiles.c (update_section_map): Use all_objfiles.
9051         (shared_objfile_contains_address_p): Likewise.
9052         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9053         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9054
9055 2019-01-09  Tom Tromey  <tom@tromey.com>
9056
9057         * common/next-iterator.h: New file.
9058         * objfiles.h (class all_objfiles): New.
9059         (struct objfile_iterator): New.
9060
9061 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9062
9063         * NEWS: Move the description of the changed "frame", "select-frame",
9064          and "info frame" commands to the Changed commands section.
9065
9066 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9067
9068         * gdbtypes.c (check_stub_method_group): Remove handling of old
9069         mangling schemes.
9070         * linespec.c (find_methods): Likewise.
9071         * stabsread.c (read_member_functions): Likewise.
9072         * valops.c (search_struct_method): Likewise.
9073         (value_struct_elt_for_reference): Likewise.
9074         * NEWS: Mention this change.
9075
9076 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9077
9078         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9079         print_source_lines.
9080         * source.c (print_source_lines_base): Update line number check.
9081         (print_source_lines): New function.
9082         (source_lines_range::source_lines_range): New function.
9083         * source.h (class source_lines_range): New class.
9084         (print_source_lines): New declaration.
9085
9086 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9087
9088         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9089
9090 2019-01-08  Tom Tromey  <tom@tromey.com>
9091             Simon Marchi  <simon.marchi@ericsson.com>
9092
9093         PR gdb/24060
9094         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9095         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9096         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9097         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9098         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9099         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9100
9101 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9102
9103         * source.c (select_source_symtab): Move header comment to
9104         declaration in source.h.
9105         (forget_cached_source_info_for_objfile): Likewise.
9106         (forget_cached_source_info): Likewise.
9107         (identify_source_line): Likewise.
9108         * source.h (identify_source_line): Move declaration from symtab.h
9109         and add comment from source.c
9110         (print_source_lines): Likewise.
9111         (forget_cached_source_info_for_objfile): Likewise.
9112         (forget_cached_source_info): Likewise.
9113         (select_source_symtab): Likewise.
9114         (enum print_source_lines_flag): Move definition from symtab.h.
9115         * symtab.h (identify_source_line): Move declaration to source.h.
9116         (print_source_lines): Likewise.
9117         (forget_cached_source_info_for_objfile): Likewise.
9118         (forget_cached_source_info): Likewise.
9119         (select_source_symtab): Likewise.
9120         (enum print_source_lines_flag): Move definition to source.h.
9121         * tui/tui-hooks.c: Add 'source.h' include.
9122
9123 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * source.c (print_source_lines_base): Handle requests to print
9126         reverse line number sequences, and guard against empty lines
9127         string.
9128
9129 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9130
9131         * source.c (print_source_lines_base): Fix skip of '\r' if next
9132         character is '\n'.
9133
9134 2019-01-06  Tom Tromey  <tom@tromey.com>
9135
9136         * c-exp.y (struct c_parse_state) <macro_original_text,
9137         expansion_obstack>: New member.
9138         (macro_original_text, expansion_obstack): Remove globals.
9139         (scan_macro_expansion, scanning_macro_expansion)
9140         (finished_macro_expansion): Update.
9141         (scan_macro_cleanup): Remove.
9142         (yylex, c_parse): Update.
9143
9144 2019-01-06  Tom Tromey  <tom@tromey.com>
9145
9146         * c-exp.y (struct c_parse_state) <strings>: New member.
9147         (operator_stoken): Update.
9148
9149 2019-01-06  Tom Tromey  <tom@tromey.com>
9150
9151         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9152         (union type_stack_elt) <typelist_val>: Now a pointer to
9153         std::vector.
9154         (type_stack_cleanup): Don't declare.
9155         (push_typelist): Update.
9156         * parse.c (pop_typelist): Return a std::vector.
9157         (push_typelist): Take a std::vector.
9158         (follow_types): Update.  Do not free args.
9159         (type_stack_cleanup): Remove.
9160         * c-exp.y (struct c_parse_state): New.
9161         (cpstate): New global.
9162         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9163         (nonempty_typelist): Update.
9164         (func_mod): Create a new vector.
9165         (c_parse): Create a c_parse_state.
9166         (check_parameter_typelist): Do not delete params.
9167         (function_method): Update.  Do not delete type_list.
9168
9169 2019-01-06  Tom Tromey  <tom@tromey.com>
9170
9171         PR gdb/28155:
9172         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9173         check_typedef.
9174         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9175         (print_return_value): Likewise.
9176
9177 2019-01-05  Tom Tromey  <tom@tromey.com>
9178
9179         * contrib/cleanup_check.py: Remove.
9180         * contrib/gcc-with-excheck: Remove.
9181         * contrib/exsummary.py: Remove.
9182         * contrib/excheck.py: Remove.
9183
9184 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9185
9186         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9187         NULL. Initialize tpprev to NULL instead of assigning it
9188         to NULL on the next statement.
9189         * windows-nat.c (windows_delete_thread): Remove check for
9190         main_thread_id before printing thread exit notifications.
9191         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9192         Remove thread ID check against main_thread_id.
9193         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9194         windows_delete_thread.
9195         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9196
9197 2019-01-04  Tom Tromey  <tom@tromey.com>
9198
9199         * compile/compile.c (_initialize_compile): Use upper case for
9200         metasyntactic variables.
9201         * symmisc.c (_initialize_symmisc): Use upper case for
9202         metasyntactic variables.
9203         * psymtab.c (_initialize_psymtab): Use upper case for
9204         metasyntactic variables.
9205         * demangle.c (demangle_command): Use upper case for metasyntactic
9206         variables.
9207         (_initialize_demangler): Likewise.
9208         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9209         variables.
9210
9211 2019-01-03  Tom Tromey  <tom@tromey.com>
9212
9213         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9214
9215 2019-01-03  Tom Tromey  <tom@tromey.com>
9216
9217         * python/py-symtab.c (salpy_str): Update.
9218         (struct salpy_sal_object) <symtab>: Now a PyObject.
9219         (salpy_dealloc): Update.
9220         (del_objfile_sal): Use gdbpy_ref.
9221
9222 2019-01-03  Tom Tromey  <tom@tromey.com>
9223
9224         * python/py-type.c (convert_field): Use new_reference.  Return
9225         gdbpy_ref.
9226         (make_fielditem): Return gdbpy_ref.
9227         (typy_fields): Update.
9228         (typy_getitem): Update.
9229         (field_name): Return gdbpy_ref.  Use new_reference.
9230         (typy_iterator_iternext): Update.
9231
9232 2019-01-03  Tom Tromey  <tom@tromey.com>
9233
9234         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9235
9236 2019-01-03  Tom Tromey  <tom@tromey.com>
9237
9238         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9239         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9240         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9241         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9242         (pspy_set_type_printers): Likewise.
9243         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9244         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9245         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9246         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9247         (objfpy_set_type_printers): Likewise.
9248
9249 2019-01-03  Tom Tromey  <tom@tromey.com>
9250
9251         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9252         (gdbpy_print_stack): Use gdbpy_err_fetch.
9253         * python/python-internal.h (class gdbpy_err_fetch): New class.
9254         (class gdbpy_enter) <m_error_type, m_error_value,
9255         m_error_traceback>: Remove.
9256         <m_error>: New member.
9257         (gdbpy_exception_to_string): Don't declare.
9258         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9259         * python/py-value.c (convert_value_from_python): Use
9260         gdbpy_err_fetch.
9261         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9262         gdbpy_exception_to_string.
9263         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9264         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9265         gdbpy_err_fetch.
9266
9267 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * linux-nat.c (delete_lwp_cleanup): Delete.
9270         (struct lwp_deleter): New struct.
9271         (lwp_info_up): New typedef.
9272         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9273         lwp_info_up.
9274
9275 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9276
9277         * linux-fork.c (class scoped_switch_fork_info): New class.
9278         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9279
9280 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * valops.c (find_overload_match): Remove use of null_cleanup, and
9283         calls to do_cleanups.
9284
9285 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * compile/compile-cplus-types.c
9288         (compile_cplus_instance::decl_name): Handle changes to
9289         cp_func_name.
9290         * cp-support.c (cp_func_name): Update header comment, update
9291         return type.
9292         * cp-support.h (cp_func_name): Update return type in declaration.
9293         * valops.c (find_overload_match): Move temp_func local to top
9294         level of function and change its type.  Use temp_func to hold and
9295         delete temporary string obtained from cp_func_name.
9296
9297 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9300         gdb::char_vector, remove cleanup, and update uses of `msg`.
9301
9302 2019-01-03  Jim Wilson  <jimw@sifive.com>
9303
9304         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9305
9306 2019-01-02  Tom Tromey  <tom@tromey.com>
9307
9308         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9309         (tdesc_parse_xml): Remove cleanups.
9310         * target-descriptions.h (make_cleanup_free_target_description):
9311         Don't declare.
9312         (target_desc_deleter): New struct.
9313         (target_desc_up): New typedef.
9314         * target-descriptions.c (target_desc_deleter::operator()): Rename
9315         from free_target_description.
9316         (make_cleanup_free_target_description): Remove.
9317
9318 2019-01-02  Tom Tromey  <tom@tromey.com>
9319
9320         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9321         constructor, destructor.
9322         (linespec_parser): Remove typedef.
9323         (~linespec_parser): Rename from linespec_parser_delete.
9324         (linespec_lex_to_end, linespec_complete_label)
9325         (linespec_complete): Update.
9326         (decode_line_full): Remove cleanups.
9327         (decode_line_1): Update.
9328
9329 2019-01-02  Tom Tromey  <tom@tromey.com>
9330
9331         * python/python-internal.h (inferior_to_inferior_object): Change
9332         return type.
9333         * python/py-exitedevent.c (create_exited_event_object): Update.
9334         * python/py-inferior.c (inferior_to_inferior_object): Return
9335         gdbpy_ref.
9336         (python_new_inferior, python_inferior_deleted)
9337         (thread_to_thread_object, delete_thread_object)
9338         (build_inferior_list, gdbpy_selected_inferior): Update.
9339         * python/py-infthread.c (create_thread_object): Update.  Also fail
9340         if inferior_to_inferior_object fails.
9341
9342 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9343
9344         * inferior.h (class inferior) <displaced_step_state>: New field.
9345         * infrun.h (struct displaced_step_state): Move here from
9346         infrun.c.  Initialize fields, add constructor.
9347         <inf>: Remove field.
9348         <reset>: New method.
9349         * infrun.c (struct displaced_step_inferior_state): Move to
9350         infrun.h.
9351         (displaced_step_inferior_states): Remove.
9352         (get_displaced_stepping_state): Adust.
9353         (displaced_step_in_progress_any_inferior): Adjust.
9354         (displaced_step_in_progress_thread): Adjust.
9355         (displaced_step_in_progress): Adjust.
9356         (add_displaced_stepping_state): Remove.
9357         (get_displaced_step_closure_by_addr): Adjust.
9358         (remove_displaced_stepping_state): Remove.
9359         (infrun_inferior_exit): Call displaced_step_state.reset.
9360         (use_displaced_stepping): Don't check for NULL.
9361         (displaced_step_prepare_throw): Call
9362         get_displaced_stepping_state.
9363         (displaced_step_fixup): Don't check for NULL.
9364         (prepare_for_detach): Don't check for NULL.
9365
9366 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9367
9368         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9369          in case of call that did not complete.
9370
9371 2019-01-02  Andrey Utkin  <autkin@undo.io>
9372
9373         * symfile.c (find_separate_debug_file): Fix search of debug files for
9374         remote debuggee.
9375
9376 2019-01-02  Tom Tromey  <tom@tromey.com>
9377
9378         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9379         indentation.
9380         * python/py-frame.c (frapy_older): Remove cast.
9381         (frapy_newer): Likewise.
9382         * python/py-breakpoint.c (local_setattro): Remove cast.
9383         * python/py-arch.c (archpy_name): Remove local variable.
9384         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9385
9386 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9387
9388         * unittests/basic_string_view/element_access/char/empty.cc:
9389         Fix year range in copyright header.
9390
9391 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9392
9393         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9394         Delete.
9395         <operator==>: Update with for removed field.
9396         <hash>: Likewise.
9397         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9398         <isa_features>: ...this.
9399         <abi_features>: New field.
9400         (riscv_isa_flen): Update comment.
9401         (riscv_abi_xlen): New declaration.
9402         (riscv_abi_flen): New declaration.
9403         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9404         isa_features.
9405         (riscv_abi_xlen): New function.
9406         (riscv_isa_flen): Update to get answer from isa_features.
9407         (riscv_abi_flen): New function.
9408         (riscv_has_fp_abi): Update to get answer from abi_features.
9409         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9410         xlen and flen.
9411         (riscv_call_info) <xlen, flen>: Update comment.
9412         (riscv_call_arg_struct): Remove invalid assertions
9413         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9414         is removed.
9415         (riscv_gdbarch_init): Gather isa features and abi features
9416         separately, ensure both match on the gdbarch when reusing an old
9417         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9418         a target with 64-bit float hardware.
9419
9420 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9421
9422         * source.c (search_command_helper): Stop reverse search
9423         when line 1 has been searched.
9424
9425 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9426
9427         * record-full.c (record_full_base_target::close): Rewrite
9428         record_full_core_buf_list free logic.
9429
9430 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9431
9432         * break-catch-syscall.c (print_one_catch_syscall): xfree
9433         the last text.
9434
9435 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9436
9437         * top.c (print_gdb_version): Update Copyright year in version
9438         message.
9439
9440 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9441
9442         Update copyright year range in all GDB files.
9443
9444 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9445
9446         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9447
9448 For older changes see ChangeLog-2018.
9449 \f
9450 Local Variables:
9451 mode: change-log
9452 left-margin: 8
9453 fill-column: 74
9454 version-control: never
9455 coding: utf-8
9456 End:
9457