gdb/ChangeLog

   1 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
   4         objfile->separate_debug_objfile_backlink if not NULL.
   5
   6 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   7
   8         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
   9         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  10         (amd64bsd_store_inferior_registers): Likewise.
  11         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  12         Enable segment base registers.
  13         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  14         PT_GETFSBASE and PT_GETGSBASE.
  15         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  16         PT_SETGSBASE.
  17         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  18         segment base registers.
  19         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  20
  21 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  22
  23         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  24         Update calls to i386_target_description to add 'segments'
  25         parameter.
  26         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
  27         add segment base registers.
  28         * arch/i386.c (i386_create_target_description): Add 'segments'
  29         parameter to enable segment base registers.
  30         * arch/i386.h (i386_create_target_description): Likewise.
  31         * features/i386/32bit-segments.xml: New file.
  32         * features/i386/32bit-segments.c: Generate.
  33         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
  34         call to i386_target_description to add 'segments' parameter.
  35         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  36         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
  37         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
  38         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
  39         if feature is present.
  40         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
  41         Add 'segments' parameter to call to i386_target_description.
  42         (i386_target_description): Add 'segments' parameter to enable
  43         segment base registers.
  44         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
  45         to call to i386_target_description.
  46         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
  47         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
  48         Define I386_NUM_REGS.
  49         (i386_target_description): Add 'segments' parameter to enable
  50         segment base registers.
  51
  52 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  53
  54         PR/24325
  55         * source-cache.c: #undef open and close, to avoid unresolved
  56         externals during linking.
  57
  58 2019-03-12  Tom Tromey  <tromey@adacore.com>
  59
  60         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
  61         const.  Add initializers.
  62         (_initialize_remote): Don't initialize ptid globals.
  63
  64 2019-03-12  Pedro Alves  <palves@redhat.com>
  65
  66         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
  67
  68 2019-03-12  Pedro Alves  <palves@redhat.com>
  69
  70         * cp-name-parser.y (main): Remove unused 'len' variable.
  71
  72 2019-03-12  Tom Tromey  <tromey@adacore.com>
  73
  74         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
  75         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
  76
  77 2019-03-12  Tom Tromey  <tromey@adacore.com>
  78
  79         * linux-nat.c (iterate_over_lwps): Update.
  80         (stop_callback): Remove parameter.
  81         (stop_wait_callback, detach_callback, resume_set_callback)
  82         (select_singlestep_lwp_callback, set_ignore_sigint)
  83         (status_callback, resumed_callback, resume_clear_callback)
  84         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
  85         data parameter.
  86         (linux_nat_target::detach, linux_nat_target::resume)
  87         (linux_stop_and_wait_all_lwps, select_event_lwp)
  88         (linux_nat_filter_event, linux_nat_wait_1)
  89         (linux_nat_target::kill, linux_nat_target::stop)
  90         (linux_nat_target::stop): Update.
  91         (linux_nat_resume_callback): Change type.
  92         (resume_stopped_resumed_lwps, count_events_callback)
  93         (select_event_lwp_callback): Likewise.
  94         (linux_stop_lwp, linux_nat_stop_lwp): Update.
  95         * arm-linux-nat.c (struct update_registers_data): Remove.
  96         (update_registers_callback): Change type.
  97         (arm_linux_insert_hw_breakpoint1): Update.
  98         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
  99         parameter.
 100         (x86_linux_dr_set_addr): Update.
 101         (x86_linux_dr_set_control): Update.
 102         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 103         (iterate_over_lwps): Use gdb::function_view.
 104         * nat/aarch64-linux-hw-point.c (struct
 105         aarch64_dr_update_callback_param): Remove.
 106         (debug_reg_change_callback): Change type.
 107         (aarch64_notify_debug_reg_change): Update.
 108         * s390-linux-nat.c (s390_refresh_per_info): Update.
 109
 110 2019-03-11  Tom Tromey  <tromey@adacore.com>
 111
 112         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 113         redundant assignment to "this_cu".
 114
 115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 116
 117         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 118
 119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 120
 121         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 122         from...
 123         (rank_one_type): ... this.
 124
 125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 126
 127         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 128         from...
 129         (rank_one_type): ... this.
 130
 131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 132
 133         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 134         from...
 135         (rank_one_type): ... this.
 136
 137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 138
 139         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 140         from...
 141         (rank_one_type): ... this.
 142
 143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 144
 145         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 146         from...
 147         (rank_one_type): ... this.
 148
 149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 150
 151         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 152         from...
 153         (rank_one_type): ... this.
 154
 155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 156
 157         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 158         from...
 159         (rank_one_type): ... this.
 160
 161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 162
 163         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 164         from...
 165         (rank_one_type): ... this.
 166
 167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 168
 169         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 170         from...
 171         (rank_one_type): ... this.
 172
 173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 174
 175         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 176         from...
 177         (rank_one_type): ... this.
 178
 179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 180
 181         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 182         from...
 183         (rank_one_type): ... this.
 184
 185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 186
 187         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 188         from...
 189         (rank_one_type): ... this.
 190
 191 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 192
 193         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 194         inferior-events' shows the example events.
 195
 196 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 197
 198         Support styling on native MS-Windows console
 199
 200         PR/24315
 201         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 202         on MS-Windows if $TERM is not defined.
 203
 204         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 205
 206         * posix-hdep.c (gdb_console_fputs):
 207         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 208         functions.
 209         * ui-file.h (gdb_console_fputs): Add prototype.
 210
 211         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 212         back to fputs only if the former returns zero.
 213
 214 2019-03-07  Tom Tromey  <tom@tromey.com>
 215
 216         * symmisc.c (print_symbol_bcache_statistics): Update.
 217         (print_objfile_statistics): Update.
 218         * symfile.c (allocate_symtab): Update.
 219         * stabsread.c: Don't include bcache.h.
 220         * psymtab.h (struct psymbol_bcache): Don't declare.
 221         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 222         (psymbol_bcache_init, psymbol_bcache_free)
 223         (psymbol_bcache_get_bcache): Don't declare.
 224         * psymtab.c (struct psymbol_bcache): Remove.
 225         (psymtab_storage::psymtab_storage): Update.
 226         (psymtab_storage::~psymtab_storage): Update.
 227         (psymbol_bcache_init, psymbol_bcache_free)
 228         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 229         (add_psymbol_to_bcache): Update.
 230         (allocate_psymtab): Update.
 231         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 232         macro_cache>: No longer pointers.
 233         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 234         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 235         * macrotab.c (macro_bcache): Update.
 236         * macroexp.c: Don't include bcache.h.
 237         * gdbtypes.c (check_types_worklist): Update.
 238         (types_deeply_equal): Remove TRY/CATCH.  Update.
 239         * elfread.c (elf_symtab_read): Update.
 240         * dwarf2read.c: Don't include bcache.h.
 241         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 242         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 243         (print_bcache_statistics, bcache_memory_used): Don't declare.
 244         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 245         methods.  Rename all data members.
 246         * bcache.c (struct bcache): Move to bcache.h.
 247         (bcache::expand_hash_table): Rename from expand_hash_table.
 248         (bcache): Remove.
 249         (bcache::insert): Rename from bcache_full.
 250         (bcache::compare): Rename from bcache_compare.
 251         (bcache_xmalloc): Remove.
 252         (bcache::~bcache): Rename from bcache_xfree.
 253         (bcache::print_statistics): Rename from print_bcache_statistics.
 254         (bcache::memory_used): Rename from bcache_memory_used.
 255
 256 2019-03-07  Pedro Alves  <palves@redhat.com>
 257
 258         * infrun.c (normal_stop): Also check for
 259         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 260
 261 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 262
 263         * f-lang.c (value_from_host_double): Moved to...
 264         * value.c (value_from_host_double): ...here.
 265         * value.h (value_from_host_double): Declare.
 266         * guile/scm-math.c (vlscm_convert_typed_number): Use
 267         value_from_host_double.
 268         (vlscm_convert_number): Likewise.
 269         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 270         * python/py-value.c (convert_value_from_python): Likewise.
 271
 272 2019-03-06  Tom Tromey  <tom@tromey.com>
 273
 274         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 275
 276 2019-03-06  Tom Tromey  <tom@tromey.com>
 277
 278         * utils.h (free_current_contents): Don't declare.
 279         * utils.c (free_current_contents): Remove.
 280
 281 2019-03-06  Tom Tromey  <tom@tromey.com>
 282
 283         * top.c (quit_force): Update.
 284         * main.c (captured_command_loop): Update.
 285         * common/new-op.c (operator new): Update.
 286         * common/common-exceptions.c (struct catcher)
 287         <save_cleanup_chain>: Remove member.
 288         (exceptions_state_mc_init): Update.
 289         (exception_try_scope_entry): Return nullptr.
 290         (exception_try_scope_exit, exception_rethrow)
 291         (throw_exception_sjlj, throw_exception_cxx): Update.
 292         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 293         (all_cleanups, do_cleanups, discard_cleanups)
 294         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 295         (restore_cleanups, restore_final_cleanups): Don't declare.
 296         (do_final_cleanups): Remove parameter.
 297         * common/cleanups.c (cleanup_chain, make_cleanup)
 298         (make_cleanup_dtor, all_cleanups, do_cleanups)
 299         (discard_my_cleanups, discard_cleanups)
 300         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 301         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 302         (null_cleanup): Remove.
 303         (do_final_cleanups): Remove parameter.
 304
 305 2019-03-06  Tom Tromey  <tom@tromey.com>
 306
 307         * remote.c (remote_target::remote_parse_stop_reply): Use
 308         unique_xmalloc_ptr.
 309
 310 2019-03-06  Tom Tromey  <tom@tromey.com>
 311
 312         * stabsread.c (struct stabs_field_info): Rename from field_info.
 313         <list, fnlist>: Add initializers.
 314         <obstack>: New member.
 315         (read_member_functions, read_struct_fields, read_baseclasses):
 316         Allocate on obstack.  Don't use cleanups.
 317         (read_one_struct_field, read_member_functions, read_struct_fields)
 318         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 319         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 320         (read_struct_type): Update.
 321
 322 2019-03-06  Tom Tromey  <tom@tromey.com>
 323
 324         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 325         * common/filestuff.h (make_cleanup_close): Don't declare.
 326         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 327         Remove.
 328
 329 2019-03-06  Tom Tromey  <tom@tromey.com>
 330
 331         * solib-aix.c: Use make_scope_exit.
 332
 333 2019-03-06  Tom Tromey  <tom@tromey.com>
 334
 335         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 336         Use make_scope_exit.
 337
 338 2019-03-06  Tom Tromey  <tom@tromey.com>
 339
 340         * solib-svr4.c (disable_probes_interface): Remove parameter.
 341         (svr4_handle_solib_event): Use make_scope_exit.
 342
 343 2019-03-06  Tom Tromey  <tom@tromey.com>
 344
 345         * remote.c (struct stop_reply_deleter): Remove.
 346         (stop_reply_up): Update.
 347         (struct stop_reply): Derive from notif_event.  Don't typedef.
 348         <regcache>: Now a std::vector.
 349         (stop_reply_xfree): Remove.
 350         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 351         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 352         (remote_target::discard_pending_stop_replies): Use delete.
 353         (remote_target::remote_parse_stop_reply): Update.
 354         (remote_target::process_stop_reply): Update.
 355         * remote-notif.h (struct notif_event): Add virtual destructor.
 356         Remove "dtr" member.
 357         (struct notif_client) <alloc_event>: Return a unique_ptr.
 358         (notif_event_xfree): Don't declare.
 359         (notif_event_up): New typedef.
 360         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 361         (notif_event_xfree, do_notif_event_xfree): Remove.
 362         (remote_notif_state_xfree): Update.
 363
 364 2019-03-06  Tom Tromey  <tom@tromey.com>
 365
 366         * infrun.c (displaced_step_clear_cleanup): Now a
 367         forward_scope_exit type.
 368         (displaced_step_prepare_throw): Update.
 369         (displaced_step_fixup): Update.
 370
 371 2019-03-06  Tom Tromey  <tom@tromey.com>
 372
 373         * inferior.h (class inferior): Update comment.
 374         * gdbthread.h (class thread_info): Update comment.
 375
 376 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 377             Tom Tromey  <tom@tromey.com>
 378
 379         * stabsread.h (struct stab_section_list): Remove.
 380         (coffstab_build_psymtabs): Update.
 381         * dbxread.c (symbuf_sections): Now a std::vector.
 382         (sect_idx): New global.
 383         (fill_symbuf): Update.
 384         (coffstab_build_psymtabs): Change type of stabsects parameter.
 385         Update.
 386         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 387         std::vector.
 388         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 389         (coff_locate_sections): Update.
 390         (coff_symfile_read): Remove cleanups.  Update.
 391         (init_stringtab): Add storage parameter.
 392         (free_stringtab, free_stringtab_cleanup): Remove.
 393         (init_lineno): Add storage parameter.
 394         (free_linetab, free_linetab_cleanup): Remove.
 395
 396 2019-03-06  Pedro Alves  <palves@redhat.com>
 397
 398         * linux-fork.c (fork_info::clobber_regs): Delete.
 399         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 400         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 401         comment.  Adjust.
 402         (scoped_switch_fork_info::scoped_switch_fork_info)
 403         (checkpoint_command, linux_fork_context): Adjust
 404         fork_save_infrun_state calls.
 405
 406 2019-03-06  Pedro Alves  <palves@redhat.com>
 407
 408         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 409         (inf_has_multiple_threads): Return 'bool' and rewrite using
 410         inferior_info::threads().
 411
 412 2019-03-06  Pedro Alves  <palves@redhat.com>
 413
 414         * linux-fork.c: Include <list>.
 415         (fork_list): Now a std::list instance.
 416         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 417         (forks_exist_p, find_last_fork): Adjust.
 418         (new_fork): Delete.
 419         (one_fork_p): New.
 420         (add_fork): Adjust.
 421         (free_fork): Delete, folded into fork_info::~fork_info().
 422         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 423         Adjust.
 424         (init_fork_list): Delete.
 425         (linux_fork_killall, linux_fork_mourn_inferior)
 426         (linux_fork_detach, info_checkpoints_command): Adjust.
 427         (_initialize_linux_fork): No longer call init_fork_list.
 428
 429 2019-03-06  Pedro Alves  <palves@redhat.com>
 430
 431         * linux-fork.c (new_fork): New, split out of ...
 432         (add_fork): ... this.  Return void.  Move "first fork" special
 433         case from here, to ...
 434         (checkpoint_command): ... here.
 435         * linux-linux.h (add_fork): Return void.
 436
 437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 438
 439         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 440
 441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 442             Chris January  <chris.january@arm.com>
 443             David Lecomber  <david.lecomber@arm.com>
 444
 445         * f-exp.y: New token, UNOP_INTRINSIC.
 446         (exp): New pattern using UNOP_INTRINSIC token.
 447         (f77_keywords): Add 'abs' keyword.
 448         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 449         (value_from_host_double): New function.
 450         (evaluate_subexp_f): Support UNOP_ABS.
 451
 452 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 455         types.
 456
 457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 460         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 461         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 462
 463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 464
 465         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 466
 467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 468             Chris January  <chris.january@arm.com>
 469
 470         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 471         * f-exp.y: Define 'KIND' token.
 472         (exp): New pattern for KIND expressions.
 473         (ptype): Handle types with a kind extension.
 474         (direct_abs_decl): Extend to spot kind extensions.
 475         (f77_keywords): Add 'kind' to the list.
 476         (push_kind_type): New function.
 477         (convert_to_kind_type): New function.
 478         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 479         * parse.c (operator_length_standard): Likewise.
 480         * parser-defs.h (enum type_pieces): Add tp_kind.
 481         * std-operator.def: Add UNOP_KIND.
 482
 483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * f-exp.y (f_parse): Set yydebug.
 486
 487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         * f-lang.c (evaluate_subexp_f): New function.
 490         (exp_descriptor_f): New global.
 491         (f_language_defn): Use exp_descriptor_f instead of
 492         exp_descriptor_standard.
 493
 494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 495
 496         * f-exp.y (struct token): Add comments.
 497         (dot_ops): Remove uppercase versions and the end marker.
 498         (f77_keywords): Likewise.
 499         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 500         entries in the dot_ops array are case insensitive, and use
 501         strncasecmp to compare strings.  Also some whitespace cleanup in
 502         this area.  Similar for the f77_keywords array, except entries in
 503         this list might be case sensitive.
 504
 505 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 506
 507         * f-exp.y (struct f77_boolean_val): Add comments.
 508         (boolean_values): Remove uppercase versions, and end marker.
 509         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 510         and use strncasecmp to achieve case insensitivity.  Additionally,
 511         perform whitespace cleanup around this code.
 512
 513 2019-03-06  Tom Tromey  <tromey@adacore.com>
 514
 515         * remote-sim.c (gdbsim_target_open): Use result of
 516         gdb_argv::release.
 517
 518 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 519         Dirk Schubert  <dirk.schubert@arm.com>
 520         Chris January  <chris.january@arm.com>
 521
 522         * eval.c (evaluate_subexp_standard): Call Fortran argument
 523         wrapping logic.
 524         * f-lang.c (struct value): A value which can be passed into a
 525         Fortran function call.
 526         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 527         where appropriate.
 528         (struct type): Value ready for a Fortran function call.
 529         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 530         is needed.
 531         * f-lang.h (fortran_argument_convert): Declaration.
 532         (fortran_preserve_arg_pointer): Declaration.
 533         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 534
 535 2019-03-05  Tom Tromey  <tromey@adacore.com>
 536
 537         * python/py-prettyprint.c (print_string_repr): Remove #if.
 538         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 539
 540 2019-03-05  Tom Tromey  <tromey@adacore.com>
 541
 542         * target.c (the_dummy_target): Move later.  Change type to
 543         "dummy_target".
 544         (initialize_targets): Don't initialize the_dummy_target.
 545
 546 2019-03-05  Tom Tromey  <tromey@adacore.com>
 547
 548         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 549         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 550
 551 2019-03-05  Tom Tromey  <tromey@adacore.com>
 552
 553         * windows-nat.c (windows_nat_target::attach)
 554         (windows_nat_target::detach): Don't call gdb_flush.
 555         * valprint.c (generic_val_print, val_print, val_print_string):
 556         Don't call gdb_flush.
 557         * utils.c (defaulted_query): Don't call gdb_flush.
 558         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 559         * target.c (target_announce_detach): Don't call gdb_flush.
 560         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 561         * remote.c (extended_remote_target::attach): Don't call
 562         gdb_flush.
 563         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 564         * printcmd.c (do_examine): Don't call gdb_flush.
 565         (info_display_command): Don't call gdb_flush.
 566         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 567         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 568         * memattr.c (info_mem_command): Don't call gdb_flush.
 569         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 570         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 571         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 572         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 573         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 574         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 575         (gnu_nat_target::detach): Don't call gdb_flush.
 576         * f-valprint.c (f_val_print): Don't call gdb_flush.
 577         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 578         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 579         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 580         gdb_flush.
 581         * c-valprint.c (c_val_print): Don't call gdb_flush.
 582         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 583
 584 2019-03-05  Tom Tromey  <tromey@adacore.com>
 585
 586         * varobj.c (update_dynamic_varobj_children): Update.
 587         (install_default_visualizer): Use reset, not release.
 588         * value.c (set_internalvar): Update.
 589         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 590         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 591         ATTRIBUTE_UNUSED_RESULT.
 592
 593 2019-03-05  Tom Tromey  <tromey@adacore.com>
 594
 595         * remote.c (class scoped_remote_fd) <release>: Add
 596         ATTRIBUTE_UNUSED_RESULT.
 597
 598 2019-03-05  Tom Tromey  <tromey@adacore.com>
 599
 600         * macroexp.c (struct macro_buffer) <release>: Add
 601         ATTRIBUTE_UNUSED_RESULT.
 602
 603 2019-03-05  Tom Tromey  <tromey@adacore.com>
 604
 605         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 606         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 607         ATTRIBUTE_UNUSED_RESULT.
 608
 609 2019-03-05  Tom Tromey  <tromey@adacore.com>
 610
 611         * common/scoped_fd.h (class scoped_fd) <release>: Add
 612         ATTRIBUTE_UNUSED_RESULT.
 613
 614 2019-03-05  Tom Tromey  <tromey@adacore.com>
 615
 616         * parser-defs.h (struct parser_state) <release>: Add
 617         ATTRIBUTE_UNUSED_RESULT.
 618
 619 2019-03-05  Tom Tromey  <tromey@adacore.com>
 620
 621         * utils.h (class gdb_argv) <release>: Add
 622         ATTRIBUTE_UNUSED_RESULT.
 623         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 624
 625 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 626
 627         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 628         for-loop range, to avoid compiler warnings.
 629
 630         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 631         avoid compiler warnings about unused variables.
 632
 633         * NEWS: Mention end of support for native debugging on MS-Windows
 634         before XP.
 635
 636         PR gdb/24292
 637         * common/netstuff.c:
 638         * gdbserver/gdbreplay.c
 639         * gdbserver/remote-utils.c:
 640         * ser-tcp.c:
 641         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 642         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 643         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 644         'getaddrinfo' and 'freeaddrinfo' were not available before
 645         Windows XP, and mingw.org's MinGW headers by default define
 646         _WIN32_WINNT to 0x500.
 647
 648 2019-03-01  Gary Benson <gbenson@redhat.com>
 649
 650         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 651
 652 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 653             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 654
 655         PR gdb/8527
 656         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 657         set_sigint_trap, clear_sigint_trap.
 658
 659 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 660
 661         * target.c (target_detach): Clear the regcache and the
 662         frame cache.
 663
 664 2019-02-27  Pedro Alves  <palves@redhat.com>
 665
 666         * utils.c (set_screen_size): When we cap the height/width sizes,
 667         tweak the corresponding command variable to show "unlimited":
 668
 669 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 670             Pedro Alves  <palves@redhat.com>
 671
 672         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 673         before calling rl_set_screen_size.
 674
 675 2019-02-27  Tom Tromey  <tromey@adacore.com>
 676
 677         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 678         define.
 679         * python/py-value.c: Remove Python 2.4 workaround.
 680         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 681         workaround.
 682         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 683         Python 2.4 workaround.
 684         * python/python-internal.h: Remove Python 2.4 comment.
 685         (Py_ssize_t): Don't define.
 686         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 687         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 688         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 689         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 690         * python/python.c (do_start_initialization): Remove Python 2.4
 691         workaround.
 692         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 693         (print_children): Remove Python 2.4 workaround.
 694         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 695         workaround.
 696         (CHARBUFFERPROC_NAME): Remove.
 697         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 698         Python 2.4 workaround.
 699
 700 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 701
 702         * NEWS: Note minimum Python version.
 703
 704 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 705
 706         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 707         code from these functions.  Remove corresponding ifdefs.  Use
 708         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 709         Remove gotos and target of gotos.
 710         (infpy_search_memory): Likewise.
 711
 712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 715         (hppa_gdbarch_init): Don't register deleted functions with
 716         gdbarch.
 717
 718 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 719
 720         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 721         (h8300_unwind_sp): Delete.
 722         (h8300_dummy_id): Delete.
 723         (h8300_gdbarch_init): Don't register deleted functions with
 724         gdbarch.
 725
 726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 729         (ft32_unwind_pc): Delete.
 730         (ft32_unwind_sp): Delete.
 731         (ft32_gdbarch_init): Don't register deleted functions with
 732         gdbarch.
 733
 734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 737         (frv_unwind_pc): Delete.
 738         (frv_unwind_sp): Delete.
 739         (frv_gdbarch_init): Don't register deleted functions with
 740         gdbarch.
 741
 742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 743
 744         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 745         (riscv_unwind_pc): Delete.
 746         (riscv_unwind_sp): Delete.
 747         (riscv_gdbarch_init): Don't register deleted functions with
 748         gdbarch.
 749
 750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 753         (csky_unwind_pc): Delete.
 754         (csky_unwind_sp): Delete.
 755         (csky_gdbarch_init): Don't register deleted functions with
 756         gdbarch.
 757
 758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 761         (cris_unwind_pc): Delete.
 762         (cris_unwind_sp): Delete.
 763         (cris_gdbarch_init): Don't register deleted functions with
 764         gdbarch.
 765
 766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 769         (bfin_unwind_pc): Delete.
 770         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 771
 772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 773
 774         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 775         (arm_unwind_pc): Delete.
 776         (arm_unwind_sp): Delete.
 777         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 778
 779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 782         (arc_unwind_pc): Delete.
 783         (arc_unwind_sp): Delete.
 784         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 785
 786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 789         (alpha_unwind_pc): Delete.
 790         (alpha_gdbarch_init): Don't register deleted functions with
 791         gdbarch.
 792
 793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 796         (aarch64_unwind_pc): Delete.
 797         (aarch64_unwind_sp): Delete.
 798         (aarch64_gdbarch_init): Don't register deleted functions with
 799         gdbarch.
 800
 801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * gdbtypes.c (type_align): Don't consider static members when
 804         computing structure alignment.
 805
 806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 809         return 0 for other types.
 810         * arch-utils.c (default_type_align): Always return 0.
 811         * gdbarch.h: Regenerate.
 812         * gdbarch.sh (type_align): Extend comment.
 813         * gdbtypes.c (type_align): Add additional comments, always call
 814         gdbarch_type_align before applying the default rules.
 815         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 816         generic code will then apply a suitable default.
 817         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 818         types, return 0 for other types.
 819
 820 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 821
 822         * NEWS: Create a new section for the next release branch.
 823         Rename the section of the current branch, now that it has
 824         been cut.
 825
 826 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 827
 828         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 829         * version.in: Bump version to 8.3.50.DATE-git.
 830
 831 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 832
 833         * aix-thread.c (ptid_cmp): Remove unused variable.
 834         (get_signaled_thread): Likewise.
 835         (store_regs_user_thread): Likewise.
 836         (store_regs_kernel_thread): Likewise.
 837         (fetch_regs_kernel_thread): Remove shadowed variable.
 838
 839 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * features/riscv/32bit-cpu.xml: Add register numbers.
 842         * features/riscv/32bit-fpu.c: Regenerate.
 843         * features/riscv/32bit-fpu.xml: Add register numbers.
 844         * features/riscv/64bit-cpu.xml: Add register numbers.
 845         * features/riscv/64bit-fpu.c: Regenerate.
 846         * features/riscv/64bit-fpu.xml: Add register numbers.
 847
 848 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 849
 850         * NEWS: Mention two argument form of gdb.Value constructor.
 851         * python/py-value.c (convert_buffer_and_type_to_value): New
 852         function.
 853         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 854         Add support for handling an optional second argument.  Call
 855         convert_buffer_and_type_to_value as appropriate.
 856         * python/python-internal.h (Py_buffer_deleter): New struct.
 857         (Py_buffer_up): New typedef.
 858
 859 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 860
 861         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 862         instead of releasing ownership.
 863
 864 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 865
 866         * dwarf2read.c (open_and_init_dwp_file): Call
 867         elf_numsections instead of bfd_count_sections to initialize
 868         dwp_file->num_sections.
 869
 870 2019-02-25  Tom Tromey  <tromey@adacore.com>
 871
 872         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 873
 874 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 875
 876         * gcore.in: Add '--readnever' option when invoking GDB.
 877
 878 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 879
 880         * MAINTAINERS: Update my email address.
 881
 882 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 883
 884         * build-id.c (build_id_to_debug_bfd_1): New function.
 885         (build_id_to_debug_bfd): Look for separate debug file in
 886         sysroot.
 887
 888 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * gdbarch.sh: Update the copyright year range that is placed into
 891         generated files.
 892
 893 2019-02-22  Keith Seitz  <keiths@redhat.com>
 894
 895         PR symtab/23853
 896         * linespec.c (create_sals_line_offset): Search for the default
 897         symtab's filename instead of its fullname.
 898
 899 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 900
 901         * NEWS: Update style defaults.
 902
 903 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 904
 905         * main.c (captured_main_1): Disable styling in batch mode.
 906
 907 2019-02-20  Tom Tromey  <tom@tromey.com>
 908
 909         * symtab.c (symtab_symbol_info): Fix typos.
 910
 911 2019-02-20  Tom Tromey  <tromey@adacore.com>
 912
 913         * findcmd.c (_initialize_mem_search): Use upper case for
 914         metasyntactic variables.
 915
 916 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 917
 918         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 919         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 920
 921 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 922
 923         * top.h (source_file_name): Change to std::string.
 924         * top.c (source_file_name): Likewise.
 925         (command_line_input): Adjust.
 926         * cli/cli-script.c (script_from_file): Adjust.
 927
 928 2019-02-19  Tom Tromey  <tromey@adacore.com>
 929
 930         * ravenscar-thread.c
 931         (ravenscar_thread_target::update_thread_list): Don't call
 932         ada_build_task_list.
 933         * ada-lang.h (ada_build_task_list): Don't declare.
 934         * ada-tasks.c (struct ada_tasks_inferior_data)
 935         <task_list_valid_p>: Now bool.
 936         (read_known_tasks, ada_task_list_changed)
 937         (ada_tasks_invalidate_inferior_data): Update.
 938         (read_known_tasks_array): Return bool.
 939         (read_known_tasks_list): Likewise.
 940         (read_known_tasks): Return void.
 941         (ada_build_task_list): Now static.
 942
 943 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 944
 945         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 946         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 947
 948 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 949
 950         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 951         variant for ada_tasks_pspace_data_handle and
 952         ada_tasks_inferior_data_handle.
 953         (ada_tasks_pspace_data_cleanup): New function.
 954         (ada_tasks_inferior_data_cleanup): New function.
 955
 956 2019-02-17  Tom Tromey  <tom@tromey.com>
 957
 958         * macrotab.h (macro_source_fullname): Return a std::string.
 959         * macrotab.c (macro_include, check_for_redefinition)
 960         (macro_undef, macro_lookup_definition, foreach_macro)
 961         (foreach_macro_in_scope): Update.
 962         (macro_source_fullname): Return a std::string.
 963         * macrocmd.c (show_pp_source_pos): Update.
 964
 965 2019-02-17  Tom Tromey  <tom@tromey.com>
 966
 967         * macrocmd.c (show_pp_source_pos): Style the file names.
 968
 969 2019-02-17  Tom Tromey  <tom@tromey.com>
 970
 971         PR tui/24197:
 972         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 973
 974 2019-02-17  Tom Tromey  <tom@tromey.com>
 975
 976         * ada-lang.c (user_select_syms): Use filtered printing.
 977         * utils.c (wrap_style): New global.
 978         (desired_style): Remove.
 979         (emit_style_escape): Add stream parameter.
 980         (set_output_style, reset_terminal_style, prompt_for_continue):
 981         Update.
 982         (flush_wrap_buffer): Only flush gdb_stdout.
 983         (wrap_here): Set wrap_style.
 984         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 985         treat escape sequences as a character.  Change when wrap buffer is
 986         flushed.
 987         (fputs_styled): Do not set the output style when the default is
 988         requested.
 989         * ui-style.h (struct ui_file_style) <is_default>: New method.
 990         * source.c (print_source_lines_base): Emit escape sequences in one
 991         piece.
 992
 993 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 994
 995         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 996         integers and enumeration types.
 997
 998 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 999
1000         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1001         instead of lookup_symbol_in_language
1002         (do_exact_match): New function.
1003         (ada_get_symbol_name_matcher): Return do_exact_match when
1004         doing a verbatim match.
1005
1006 2019-02-15  Tom Tromey  <tromey@adacore.com>
1007
1008         * ravenscar-thread.c (ravenscar_thread_target::resume)
1009         (ravenscar_thread_target::wait): Special case wildcard requests.
1010
1011 2019-02-15  Tom Tromey  <tromey@adacore.com>
1012
1013         * ravenscar-thread.c (base_ptid): Remove.
1014         (struct ravenscar_thread_target) <close>: New method.
1015         <m_base_ptid>: New member.
1016         <update_inferior_ptid, active_task, task_is_currently_active,
1017         runtime_initialized>: Declare methods.
1018         <ravenscar_thread_target>: Add constructor.
1019         (ravenscar_thread_target::task_is_currently_active)
1020         (ravenscar_thread_target::update_inferior_ptid)
1021         (ravenscar_runtime_initialized): Rename.  Now methods.
1022         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1023         (ravenscar_thread_target::update_thread_list): Update.
1024         (ravenscar_thread_target::active_task): Now method.
1025         (ravenscar_thread_target::store_registers)
1026         (ravenscar_thread_target::prepare_to_store)
1027         (ravenscar_thread_target::prepare_to_store)
1028         (ravenscar_thread_target::mourn_inferior): Update.
1029         (ravenscar_inferior_created): Use "new" to create target.
1030         (ravenscar_thread_target::get_ada_task_ptid): Update.
1031         (_initialize_ravenscar): Don't initialize base_ptid.
1032         (ravenscar_ops): Remove global.
1033
1034 2019-02-15  Tom Tromey  <tromey@adacore.com>
1035
1036         * target.h (push_target): Declare new overload.
1037         * target.c (push_target): New overload, taking an rvalue reference.
1038         * remote.c (remote_target::open_1): Use push_target overload.
1039         * corelow.c (core_target_open): Use push_target overload.
1040
1041 2019-02-15  Tom Tromey  <tromey@adacore.com>
1042
1043         * ravenscar-thread.c (is_ravenscar_task)
1044         (ravenscar_task_is_currently_active): Return bool.
1045         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1046         (_initialize_ravenscar): Remove "(void)".
1047         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1048         Return bool.
1049
1050 2019-02-15  Tom Tromey  <tromey@adacore.com>
1051
1052         * ravenscar-thread.c (ravenscar_runtime_initializer)
1053         (has_ravenscar_runtime, get_running_thread_id)
1054         (ravenscar_thread_target::resume): Fix indentation.
1055
1056 2019-02-15  Tom Tromey  <tromey@adacore.com>
1057
1058         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1059         from ravenscar_arch_ops.
1060         (sparc_ravenscar_ops::fetch_registers)
1061         (sparc_ravenscar_ops::store_registers): Now methods.
1062         (sparc_ravenscar_prepare_to_store): Remove.
1063         (sparc_ravenscar_ops): Redefine.
1064         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1065         methods and destructor.  Remove members.
1066         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1067         (ravenscar_thread_target::store_registers)
1068         (ravenscar_thread_target::prepare_to_store): Update.
1069         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1070         Remove.
1071         (struct ppc_ravenscar_powerpc_ops): Derive from
1072         ravenscar_arch_ops.
1073         (ppc_ravenscar_powerpc_ops::fetch_registers)
1074         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1075         (ppc_ravenscar_powerpc_ops): Redefine.
1076         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1077         (ppc_ravenscar_e500_ops::fetch_registers)
1078         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1079         (ppc_ravenscar_e500_ops): Redefine.
1080         * aarch64-ravenscar-thread.c
1081         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1082         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1083         (aarch64_ravenscar_fetch_registers)
1084         (aarch64_ravenscar_store_registers): Now methods.
1085         (aarch64_ravenscar_ops): Redefine.
1086
1087 2019-02-15  Tom Tromey  <tromey@adacore.com>
1088
1089         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1090         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1091         (ravenscar_thread_target::stopped_by_watchpoint)
1092         (ravenscar_thread_target::stopped_data_address)
1093         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1094
1095 2019-02-15  Tom Tromey  <tromey@adacore.com>
1096
1097         * ravenscar-thread.c: Fix some typos.
1098
1099 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1100             Tom Tromey  <tromey@adacore.com>
1101
1102         * ada-lang.c (ada_exception_sal): Change addr_string to a
1103         std::string.
1104         (create_ada_exception_catchpoint): Update.
1105
1106 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1107             Tom Tromey  <tromey@adacore.com>
1108
1109         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1110         (bp_location_ops): Remove.
1111         (base_breakpoint_allocate_location): Update.
1112         (free_bp_location): Update.
1113         * ada-lang.c (class ada_catchpoint_location)
1114         <ada_catchpoint_location>: Remove ops parameter.
1115         (ada_catchpoint_location_dtor): Remove.
1116         (ada_catchpoint_location_ops): Remove.
1117         (allocate_location_exception): Update.
1118         * breakpoint.h (struct bp_location_ops): Remove.
1119         (class bp_location) <bp_location>: Remove bp_location_ops
1120         parameter.
1121         <~bp_location>: Add destructor.
1122         <ops>: Remove.
1123
1124 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1125             Pedro Alves  <palves@redhat.com>
1126
1127         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1128         'PATH_MAX'.
1129
1130 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1131             Samuel Thibault  <samuel.thibault@gnu.org>
1132             Thomas Schwinge  <thomas@codesourcery.com>
1133
1134         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1135         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1136
1137 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1138
1139         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1140         (check_empty): Use "const char *".
1141
1142         * gnu-nat.c (gnu_nat_target::detach): Instead of
1143         'detach_inferior (pid)' call
1144         'detach_inferior (find_inferior_pid (pid))'.
1145
1146         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1147         'nat/fork-inferior.o'.
1148         * gnu-nat.c: #include "nat/fork-inferior.h".
1149
1150         * gnu-nat.c (gnu_nat_target::detach): Instead of
1151         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1152         * gnu-nat.h: #include "inf-child.h".
1153         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1154         'i386_gnu_nat_target::fetch_registers'.
1155         (gnu_store_registers): Rename/move to
1156         'i386_gnu_nat_target::store_registers'.
1157
1158         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1159         * gnu-nat.h (mach_thread_info): New function.
1160         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1161
1162         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1163
1164 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1165
1166         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1167
1168 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1169
1170         * windows-nat.c (windows_add_thread): Add new parameter
1171         "main_thread_p" with default value set to false.  Update
1172         function documentation as well as all callers.
1173         (windows_delete_thread): Likewise.
1174         (fake_create_process): Update call to windows_add_thread.
1175         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1176         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1177         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1178         call to windows_delete_thread.
1179
1180 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1181
1182         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1183
1184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1185
1186         * symfile.c (find_separate_debug_file): Use canonical path of
1187         sysroot with child_path instead of gdb_sysroot if it is valid.
1188
1189 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1190
1191         * symfile.c (find_separate_debug_file): Use child_path to
1192         determine if an object file is under a sysroot.
1193
1194 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1195
1196         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1197         unittests/child-path-selftests.c.
1198         * common/pathstuff.c (child_path): New function.
1199         * common/pathstuff.h (child_path): New prototype.
1200         * unittests/child-path-selftests.c: New file.
1201
1202 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1203
1204         * symfile.c (find_separate_debug_file): Look for separate debug
1205         files in debug directories under the sysroot.
1206
1207 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1208
1209         * symtab.h (struct minimal_symbol data_p): New const method.
1210         (struct minimal_symbol text_p): Likewise.
1211         * symtab.c (output_source_filename): Use file name style
1212         to print file name.
1213         (print_symbol_info): Likewise.
1214         (print_msymbol_info): Use address style to print addresses.
1215         Use function name style to print executable text symbols.
1216         (expand_symtab_containing_pc): Use data_p.
1217         (find_pc_sect_compunit_symtab): Likewise.
1218
1219 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * breakpoint.c (describe_other_breakpoints): Use address style
1222         to print addresses.
1223         (say_where): Likewise.
1224
1225 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1226
1227         * ada-typeprint.c (print_func_type): Print function name
1228         style to print function name.
1229         * c-typeprint.c (c_print_type_1): Likewise.
1230
1231 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1232
1233         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1234         for execve.
1235
1236 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1237
1238         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1239         type_stack.
1240
1241 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1242
1243         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1244         TYPE_CODE_REF types.
1245
1246 2019-02-08  Jim Wilson  <jimw@sifive.com>
1247
1248         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1249         (riscv_linux_fregset): New.
1250         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1251
1252 2019-02-07  Tom Tromey  <tom@tromey.com>
1253
1254         * thread.c (thread_cancel_execution_command): Update.
1255         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1256         methods.
1257         (struct thread_fsm_ops): Remove.
1258         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1259         (thread_fsm_should_stop, thread_fsm_return_value)
1260         (thread_fsm_set_finished, thread_fsm_finished_p)
1261         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1262         Don't declare.
1263         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1264         * infrun.c (clear_proceed_status_thread)
1265         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1266         (print_stop_event): Update.
1267         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1268         Add constructor.
1269         (step_command_fsm_ops): Remove.
1270         (new_step_command_fsm): Remove.
1271         (step_1): Update.
1272         (step_command_fsm::should_stop): Rename from
1273         step_command_fsm_should_stop.
1274         (step_command_fsm::clean_up): Rename from
1275         step_command_fsm_clean_up.
1276         (step_command_fsm::do_async_reply_reason): Rename from
1277         step_command_fsm_async_reply_reason.
1278         (struct until_next_fsm): Inherit from thread_fsm.  Add
1279         constructor.
1280         (until_next_fsm_ops): Remove.
1281         (new_until_next_fsm): Remove.
1282         (until_next_fsm::should_stop): Rename from
1283         until_next_fsm_should_stop.
1284         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1285         (until_next_fsm::do_async_reply_reason): Rename from
1286         until_next_fsm_async_reply_reason.
1287         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1288         constructor.  Change type of breakpoint.
1289         (finish_command_fsm_ops): Remove.
1290         (new_finish_command_fsm): Remove.
1291         (finish_command_fsm::should_stop): Rename from
1292         finish_command_fsm_should_stop.
1293         (finish_command_fsm::clean_up): Rename from
1294         finish_command_fsm_clean_up.
1295         (finish_command_fsm::return_value): Rename from
1296         finish_command_fsm_return_value.
1297         (finish_command_fsm::do_async_reply_reason): Rename from
1298         finish_command_fsm_async_reply_reason.
1299         (finish_command): Update.
1300         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1301         Add constructor.
1302         (call_thread_fsm_ops): Remove.
1303         (call_thread_fsm::call_thread_fsm): Rename from
1304         new_call_thread_fsm.
1305         (call_thread_fsm::should_stop): Rename from
1306         call_thread_fsm_should_stop.
1307         (call_thread_fsm::should_notify_stop): Rename from
1308         call_thread_fsm_should_notify_stop.
1309         (run_inferior_call, call_function_by_hand_dummy): Update.
1310         * cli/cli-interp.c (should_print_stop_to_console): Update.
1311         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1312         Add constructor.  Change type of location_breakpoint,
1313         caller_breakpoint.
1314         (until_break_fsm_ops): Remove.
1315         (new_until_break_fsm): Remove.
1316         (until_break_fsm::should_stop): Rename from
1317         until_break_fsm_should_stop.
1318         (until_break_fsm::clean_up): Rename from
1319         until_break_fsm_clean_up.
1320         (until_break_fsm::do_async_reply_reason): Rename from
1321         until_break_fsm_async_reply_reason.
1322         (until_break_command): Update.
1323         * thread-fsm.c: Remove.
1324         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1325
1326 2019-02-07  Tom Tromey  <tom@tromey.com>
1327
1328         * yy-remap.h: Add include guard.
1329         * xtensa-tdep.h: Add include guard.
1330         * xcoffread.h: Rename include guard.
1331         * varobj-iter.h: Add include guard.
1332         * tui/tui.h: Rename include guard.
1333         * tui/tui-winsource.h: Rename include guard.
1334         * tui/tui-wingeneral.h: Rename include guard.
1335         * tui/tui-windata.h: Rename include guard.
1336         * tui/tui-win.h: Rename include guard.
1337         * tui/tui-stack.h: Rename include guard.
1338         * tui/tui-source.h: Rename include guard.
1339         * tui/tui-regs.h: Rename include guard.
1340         * tui/tui-out.h: Rename include guard.
1341         * tui/tui-layout.h: Rename include guard.
1342         * tui/tui-io.h: Rename include guard.
1343         * tui/tui-hooks.h: Rename include guard.
1344         * tui/tui-file.h: Rename include guard.
1345         * tui/tui-disasm.h: Rename include guard.
1346         * tui/tui-data.h: Rename include guard.
1347         * tui/tui-command.h: Rename include guard.
1348         * tic6x-tdep.h: Add include guard.
1349         * target/waitstatus.h: Rename include guard.
1350         * target/wait.h: Rename include guard.
1351         * target/target.h: Rename include guard.
1352         * target/resume.h: Rename include guard.
1353         * target-float.h: Rename include guard.
1354         * stabsread.h: Add include guard.
1355         * rs6000-tdep.h: Add include guard.
1356         * riscv-fbsd-tdep.h: Add include guard.
1357         * regformats/regdef.h: Rename include guard.
1358         * record.h: Rename include guard.
1359         * python/python.h: Rename include guard.
1360         * python/python-internal.h: Rename include guard.
1361         * python/py-stopevent.h: Rename include guard.
1362         * python/py-ref.h: Rename include guard.
1363         * python/py-record.h: Rename include guard.
1364         * python/py-record-full.h: Rename include guard.
1365         * python/py-record-btrace.h: Rename include guard.
1366         * python/py-instruction.h: Rename include guard.
1367         * python/py-events.h: Rename include guard.
1368         * python/py-event.h: Rename include guard.
1369         * procfs.h: Add include guard.
1370         * proc-utils.h: Add include guard.
1371         * p-lang.h: Add include guard.
1372         * or1k-tdep.h: Rename include guard.
1373         * observable.h: Rename include guard.
1374         * nto-tdep.h: Rename include guard.
1375         * nat/x86-linux.h: Rename include guard.
1376         * nat/x86-linux-dregs.h: Rename include guard.
1377         * nat/x86-gcc-cpuid.h: Add include guard.
1378         * nat/x86-dregs.h: Rename include guard.
1379         * nat/x86-cpuid.h: Rename include guard.
1380         * nat/ppc-linux.h: Rename include guard.
1381         * nat/mips-linux-watch.h: Rename include guard.
1382         * nat/linux-waitpid.h: Rename include guard.
1383         * nat/linux-ptrace.h: Rename include guard.
1384         * nat/linux-procfs.h: Rename include guard.
1385         * nat/linux-osdata.h: Rename include guard.
1386         * nat/linux-nat.h: Rename include guard.
1387         * nat/linux-namespaces.h: Rename include guard.
1388         * nat/linux-btrace.h: Rename include guard.
1389         * nat/glibc_thread_db.h: Rename include guard.
1390         * nat/gdb_thread_db.h: Rename include guard.
1391         * nat/gdb_ptrace.h: Rename include guard.
1392         * nat/fork-inferior.h: Rename include guard.
1393         * nat/amd64-linux-siginfo.h: Rename include guard.
1394         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1395         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1396         * nat/aarch64-linux.h: Rename include guard.
1397         * nat/aarch64-linux-hw-point.h: Rename include guard.
1398         * mn10300-tdep.h: Add include guard.
1399         * mips-linux-tdep.h: Add include guard.
1400         * mi/mi-parse.h: Rename include guard.
1401         * mi/mi-out.h: Rename include guard.
1402         * mi/mi-main.h: Rename include guard.
1403         * mi/mi-interp.h: Rename include guard.
1404         * mi/mi-getopt.h: Rename include guard.
1405         * mi/mi-console.h: Rename include guard.
1406         * mi/mi-common.h: Rename include guard.
1407         * mi/mi-cmds.h: Rename include guard.
1408         * mi/mi-cmd-break.h: Rename include guard.
1409         * m2-lang.h: Add include guard.
1410         * location.h: Rename include guard.
1411         * linux-record.h: Rename include guard.
1412         * linux-nat.h: Add include guard.
1413         * linux-fork.h: Add include guard.
1414         * i386-darwin-tdep.h: Rename include guard.
1415         * hppa-linux-offsets.h: Add include guard.
1416         * guile/guile.h: Rename include guard.
1417         * guile/guile-internal.h: Rename include guard.
1418         * gnu-nat.h: Rename include guard.
1419         * gdb-stabs.h: Rename include guard.
1420         * frv-tdep.h: Add include guard.
1421         * f-lang.h: Add include guard.
1422         * event-loop.h: Add include guard.
1423         * darwin-nat.h: Rename include guard.
1424         * cp-abi.h: Rename include guard.
1425         * config/sparc/nm-sol2.h: Rename include guard.
1426         * config/nm-nto.h: Rename include guard.
1427         * config/nm-linux.h: Add include guard.
1428         * config/i386/nm-i386gnu.h: Rename include guard.
1429         * config/djgpp/nl_types.h: Rename include guard.
1430         * config/djgpp/langinfo.h: Rename include guard.
1431         * compile/gcc-cp-plugin.h: Add include guard.
1432         * compile/gcc-c-plugin.h: Add include guard.
1433         * compile/compile.h: Rename include guard.
1434         * compile/compile-object-run.h: Rename include guard.
1435         * compile/compile-object-load.h: Rename include guard.
1436         * compile/compile-internal.h: Rename include guard.
1437         * compile/compile-cplus.h: Rename include guard.
1438         * compile/compile-c.h: Rename include guard.
1439         * common/xml-utils.h: Rename include guard.
1440         * common/x86-xstate.h: Rename include guard.
1441         * common/version.h: Rename include guard.
1442         * common/vec.h: Rename include guard.
1443         * common/tdesc.h: Rename include guard.
1444         * common/selftest.h: Rename include guard.
1445         * common/scoped_restore.h: Rename include guard.
1446         * common/scoped_mmap.h: Rename include guard.
1447         * common/scoped_fd.h: Rename include guard.
1448         * common/safe-iterator.h: Rename include guard.
1449         * common/run-time-clock.h: Rename include guard.
1450         * common/refcounted-object.h: Rename include guard.
1451         * common/queue.h: Rename include guard.
1452         * common/ptid.h: Rename include guard.
1453         * common/print-utils.h: Rename include guard.
1454         * common/preprocessor.h: Rename include guard.
1455         * common/pathstuff.h: Rename include guard.
1456         * common/observable.h: Rename include guard.
1457         * common/netstuff.h: Rename include guard.
1458         * common/job-control.h: Rename include guard.
1459         * common/host-defs.h: Rename include guard.
1460         * common/gdb_wait.h: Rename include guard.
1461         * common/gdb_vecs.h: Rename include guard.
1462         * common/gdb_unlinker.h: Rename include guard.
1463         * common/gdb_unique_ptr.h: Rename include guard.
1464         * common/gdb_tilde_expand.h: Rename include guard.
1465         * common/gdb_sys_time.h: Rename include guard.
1466         * common/gdb_string_view.h: Rename include guard.
1467         * common/gdb_splay_tree.h: Rename include guard.
1468         * common/gdb_setjmp.h: Rename include guard.
1469         * common/gdb_ref_ptr.h: Rename include guard.
1470         * common/gdb_optional.h: Rename include guard.
1471         * common/gdb_locale.h: Rename include guard.
1472         * common/gdb_assert.h: Rename include guard.
1473         * common/filtered-iterator.h: Rename include guard.
1474         * common/filestuff.h: Rename include guard.
1475         * common/fileio.h: Rename include guard.
1476         * common/environ.h: Rename include guard.
1477         * common/common-utils.h: Rename include guard.
1478         * common/common-types.h: Rename include guard.
1479         * common/common-regcache.h: Rename include guard.
1480         * common/common-inferior.h: Rename include guard.
1481         * common/common-gdbthread.h: Rename include guard.
1482         * common/common-exceptions.h: Rename include guard.
1483         * common/common-defs.h: Rename include guard.
1484         * common/common-debug.h: Rename include guard.
1485         * common/cleanups.h: Rename include guard.
1486         * common/buffer.h: Rename include guard.
1487         * common/btrace-common.h: Rename include guard.
1488         * common/break-common.h: Rename include guard.
1489         * cli/cli-utils.h: Rename include guard.
1490         * cli/cli-style.h: Rename include guard.
1491         * cli/cli-setshow.h: Rename include guard.
1492         * cli/cli-script.h: Rename include guard.
1493         * cli/cli-interp.h: Rename include guard.
1494         * cli/cli-decode.h: Rename include guard.
1495         * cli/cli-cmds.h: Rename include guard.
1496         * charset-list.h: Add include guard.
1497         * buildsym-legacy.h: Rename include guard.
1498         * bfin-tdep.h: Add include guard.
1499         * ax.h: Rename include guard.
1500         * arm-linux-tdep.h: Add include guard.
1501         * arm-fbsd-tdep.h: Add include guard.
1502         * arch/xtensa.h: Rename include guard.
1503         * arch/tic6x.h: Add include guard.
1504         * arch/i386.h: Add include guard.
1505         * arch/arm.h: Rename include guard.
1506         * arch/arm-linux.h: Rename include guard.
1507         * arch/arm-get-next-pcs.h: Rename include guard.
1508         * arch/amd64.h: Add include guard.
1509         * arch/aarch64-insn.h: Rename include guard.
1510         * arch-utils.h: Rename include guard.
1511         * annotate.h: Add include guard.
1512         * amd64-darwin-tdep.h: Rename include guard.
1513         * aarch64-linux-tdep.h: Add include guard.
1514         * aarch64-fbsd-tdep.h: Add include guard.
1515         * aarch32-linux-nat.h: Add include guard.
1516
1517 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1518
1519         * macrotab.c (macro_define_internal): New function that
1520         factorizes macro_define_object_internal and macro_define_function
1521         code.
1522         (macro_define_object_internal): Use macro_define_internal.
1523         (macro_define_function): Likewise.
1524
1525 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1526
1527         * macrocmd.c (extract_identifier): Return
1528         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1529         callers.
1530
1531 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1532
1533         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1534
1535 2019-02-05  Tom Tromey  <tom@tromey.com>
1536
1537         * target.c (target_stack::unpush): Move assertion earlier.
1538
1539 2019-01-30  Tom Tromey  <tom@tromey.com>
1540
1541         PR python/23615:
1542         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1543         (gdbpy_parse_and_eval): Likewise.
1544         * python/python-internal.h (gdbpy_allow_threads): New class.
1545
1546 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1547
1548         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1549         (aarch64_fbsd_fpregmap): Move earlier.
1550         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1551         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1552         instead of individual calls to trad_frame_set_reg_addr.
1553         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1554         earlier.
1555         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1556         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1557         instead of individual calls to trad_frame_set_reg_addr.
1558
1559 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1560
1561         * CONTRIBUTE: Replace contribution list with wiki link.
1562
1563 2019-01-25  Tom Tromey  <tom@tromey.com>
1564
1565         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1566
1567 2019-01-25  Tom Tromey  <tom@tromey.com>
1568
1569         * xtensa-linux-nat.c: Fix common/ includes.
1570         * xml-support.h: Fix common/ includes.
1571         * xml-support.c: Fix common/ includes.
1572         * x86-linux-nat.c: Fix common/ includes.
1573         * windows-nat.c: Fix common/ includes.
1574         * varobj.h: Fix common/ includes.
1575         * varobj.c: Fix common/ includes.
1576         * value.c: Fix common/ includes.
1577         * valops.c: Fix common/ includes.
1578         * utils.c: Fix common/ includes.
1579         * unittests/xml-utils-selftests.c: Fix common/ includes.
1580         * unittests/utils-selftests.c: Fix common/ includes.
1581         * unittests/unpack-selftests.c: Fix common/ includes.
1582         * unittests/tracepoint-selftests.c: Fix common/ includes.
1583         * unittests/style-selftests.c: Fix common/ includes.
1584         * unittests/string_view-selftests.c: Fix common/ includes.
1585         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1586         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1587         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1588         * unittests/rsp-low-selftests.c: Fix common/ includes.
1589         * unittests/parse-connection-spec-selftests.c: Fix common/
1590         includes.
1591         * unittests/optional-selftests.c: Fix common/ includes.
1592         * unittests/offset-type-selftests.c: Fix common/ includes.
1593         * unittests/observable-selftests.c: Fix common/ includes.
1594         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1595         * unittests/memrange-selftests.c: Fix common/ includes.
1596         * unittests/memory-map-selftests.c: Fix common/ includes.
1597         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1598         * unittests/function-view-selftests.c: Fix common/ includes.
1599         * unittests/environ-selftests.c: Fix common/ includes.
1600         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1601         * unittests/common-utils-selftests.c: Fix common/ includes.
1602         * unittests/cli-utils-selftests.c: Fix common/ includes.
1603         * unittests/array-view-selftests.c: Fix common/ includes.
1604         * ui-file.c: Fix common/ includes.
1605         * tui/tui-io.c: Fix common/ includes.
1606         * tracepoint.h: Fix common/ includes.
1607         * tracepoint.c: Fix common/ includes.
1608         * tracefile-tfile.c: Fix common/ includes.
1609         * top.h: Fix common/ includes.
1610         * top.c: Fix common/ includes.
1611         * thread.c: Fix common/ includes.
1612         * target/waitstatus.h: Fix common/ includes.
1613         * target/waitstatus.c: Fix common/ includes.
1614         * target.h: Fix common/ includes.
1615         * target.c: Fix common/ includes.
1616         * target-memory.c: Fix common/ includes.
1617         * target-descriptions.c: Fix common/ includes.
1618         * symtab.h: Fix common/ includes.
1619         * symfile.c: Fix common/ includes.
1620         * stap-probe.c: Fix common/ includes.
1621         * spu-linux-nat.c: Fix common/ includes.
1622         * sparc-nat.c: Fix common/ includes.
1623         * source.c: Fix common/ includes.
1624         * solib.c: Fix common/ includes.
1625         * solib-target.c: Fix common/ includes.
1626         * ser-unix.c: Fix common/ includes.
1627         * ser-tcp.c: Fix common/ includes.
1628         * ser-pipe.c: Fix common/ includes.
1629         * ser-base.c: Fix common/ includes.
1630         * selftest-arch.c: Fix common/ includes.
1631         * s12z-tdep.c: Fix common/ includes.
1632         * rust-exp.y: Fix common/ includes.
1633         * rs6000-aix-tdep.c: Fix common/ includes.
1634         * riscv-tdep.c: Fix common/ includes.
1635         * remote.c: Fix common/ includes.
1636         * remote-notif.h: Fix common/ includes.
1637         * remote-fileio.h: Fix common/ includes.
1638         * remote-fileio.c: Fix common/ includes.
1639         * regcache.h: Fix common/ includes.
1640         * regcache.c: Fix common/ includes.
1641         * record-btrace.c: Fix common/ includes.
1642         * python/python.c: Fix common/ includes.
1643         * python/py-type.c: Fix common/ includes.
1644         * python/py-inferior.c: Fix common/ includes.
1645         * progspace.h: Fix common/ includes.
1646         * producer.c: Fix common/ includes.
1647         * procfs.c: Fix common/ includes.
1648         * proc-api.c: Fix common/ includes.
1649         * printcmd.c: Fix common/ includes.
1650         * ppc-linux-nat.c: Fix common/ includes.
1651         * parser-defs.h: Fix common/ includes.
1652         * osdata.c: Fix common/ includes.
1653         * obsd-nat.c: Fix common/ includes.
1654         * nat/x86-linux.c: Fix common/ includes.
1655         * nat/x86-linux-dregs.c: Fix common/ includes.
1656         * nat/x86-dregs.h: Fix common/ includes.
1657         * nat/x86-dregs.c: Fix common/ includes.
1658         * nat/ppc-linux.c: Fix common/ includes.
1659         * nat/mips-linux-watch.h: Fix common/ includes.
1660         * nat/mips-linux-watch.c: Fix common/ includes.
1661         * nat/linux-waitpid.c: Fix common/ includes.
1662         * nat/linux-ptrace.h: Fix common/ includes.
1663         * nat/linux-ptrace.c: Fix common/ includes.
1664         * nat/linux-procfs.c: Fix common/ includes.
1665         * nat/linux-personality.c: Fix common/ includes.
1666         * nat/linux-osdata.c: Fix common/ includes.
1667         * nat/linux-namespaces.c: Fix common/ includes.
1668         * nat/linux-btrace.h: Fix common/ includes.
1669         * nat/linux-btrace.c: Fix common/ includes.
1670         * nat/fork-inferior.c: Fix common/ includes.
1671         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1672         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1673         * nat/aarch64-linux.c: Fix common/ includes.
1674         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1675         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1676         * namespace.h: Fix common/ includes.
1677         * mips-linux-tdep.c: Fix common/ includes.
1678         * minsyms.c: Fix common/ includes.
1679         * mi/mi-parse.h: Fix common/ includes.
1680         * mi/mi-main.c: Fix common/ includes.
1681         * mi/mi-cmd-env.c: Fix common/ includes.
1682         * memrange.h: Fix common/ includes.
1683         * memattr.c: Fix common/ includes.
1684         * maint.h: Fix common/ includes.
1685         * maint.c: Fix common/ includes.
1686         * main.c: Fix common/ includes.
1687         * machoread.c: Fix common/ includes.
1688         * location.c: Fix common/ includes.
1689         * linux-thread-db.c: Fix common/ includes.
1690         * linux-nat.c: Fix common/ includes.
1691         * linux-fork.c: Fix common/ includes.
1692         * inline-frame.c: Fix common/ includes.
1693         * infrun.c: Fix common/ includes.
1694         * inflow.c: Fix common/ includes.
1695         * inferior.h: Fix common/ includes.
1696         * inferior.c: Fix common/ includes.
1697         * infcmd.c: Fix common/ includes.
1698         * inf-ptrace.c: Fix common/ includes.
1699         * inf-child.c: Fix common/ includes.
1700         * ia64-linux-nat.c: Fix common/ includes.
1701         * i387-tdep.c: Fix common/ includes.
1702         * i386-tdep.c: Fix common/ includes.
1703         * i386-linux-tdep.c: Fix common/ includes.
1704         * i386-linux-nat.c: Fix common/ includes.
1705         * i386-go32-tdep.c: Fix common/ includes.
1706         * i386-fbsd-tdep.c: Fix common/ includes.
1707         * i386-fbsd-nat.c: Fix common/ includes.
1708         * guile/scm-type.c: Fix common/ includes.
1709         * guile/guile.c: Fix common/ includes.
1710         * go32-nat.c: Fix common/ includes.
1711         * gnu-nat.c: Fix common/ includes.
1712         * gdbthread.h: Fix common/ includes.
1713         * gdbarch-selftests.c: Fix common/ includes.
1714         * gdb_usleep.c: Fix common/ includes.
1715         * gdb_select.h: Fix common/ includes.
1716         * gdb_bfd.c: Fix common/ includes.
1717         * gcore.c: Fix common/ includes.
1718         * fork-child.c: Fix common/ includes.
1719         * findvar.c: Fix common/ includes.
1720         * fbsd-nat.c: Fix common/ includes.
1721         * event-top.c: Fix common/ includes.
1722         * event-loop.c: Fix common/ includes.
1723         * dwarf2read.c: Fix common/ includes.
1724         * dwarf2loc.c: Fix common/ includes.
1725         * dwarf2-frame.c: Fix common/ includes.
1726         * dwarf-index-cache.c: Fix common/ includes.
1727         * dtrace-probe.c: Fix common/ includes.
1728         * disasm-selftests.c: Fix common/ includes.
1729         * defs.h: Fix common/ includes.
1730         * csky-tdep.c: Fix common/ includes.
1731         * cp-valprint.c: Fix common/ includes.
1732         * cp-support.h: Fix common/ includes.
1733         * cp-support.c: Fix common/ includes.
1734         * corelow.c: Fix common/ includes.
1735         * completer.h: Fix common/ includes.
1736         * completer.c: Fix common/ includes.
1737         * compile/compile.c: Fix common/ includes.
1738         * compile/compile-loc2c.c: Fix common/ includes.
1739         * compile/compile-cplus-types.c: Fix common/ includes.
1740         * compile/compile-cplus-symbols.c: Fix common/ includes.
1741         * command.h: Fix common/ includes.
1742         * cli/cli-dump.c: Fix common/ includes.
1743         * cli/cli-cmds.c: Fix common/ includes.
1744         * charset.c: Fix common/ includes.
1745         * build-id.c: Fix common/ includes.
1746         * btrace.h: Fix common/ includes.
1747         * btrace.c: Fix common/ includes.
1748         * breakpoint.h: Fix common/ includes.
1749         * breakpoint.c: Fix common/ includes.
1750         * ax.h:
1751         (enum agent_op): Fix common/ includes.
1752         * ax-general.c (struct aop_map): Fix common/ includes.
1753         * ax-gdb.c: Fix common/ includes.
1754         * auxv.c: Fix common/ includes.
1755         * auto-load.c: Fix common/ includes.
1756         * arm-tdep.c: Fix common/ includes.
1757         * arch/riscv.c: Fix common/ includes.
1758         * arch/ppc-linux-common.c: Fix common/ includes.
1759         * arch/i386.c: Fix common/ includes.
1760         * arch/arm.c: Fix common/ includes.
1761         * arch/arm-linux.c: Fix common/ includes.
1762         * arch/arm-get-next-pcs.c: Fix common/ includes.
1763         * arch/amd64.c: Fix common/ includes.
1764         * arch/aarch64.c: Fix common/ includes.
1765         * arch/aarch64-insn.c: Fix common/ includes.
1766         * arch-utils.c: Fix common/ includes.
1767         * amd64-windows-tdep.c: Fix common/ includes.
1768         * amd64-tdep.c: Fix common/ includes.
1769         * amd64-sol2-tdep.c: Fix common/ includes.
1770         * amd64-obsd-tdep.c: Fix common/ includes.
1771         * amd64-nbsd-tdep.c: Fix common/ includes.
1772         * amd64-linux-tdep.c: Fix common/ includes.
1773         * amd64-linux-nat.c: Fix common/ includes.
1774         * amd64-fbsd-tdep.c: Fix common/ includes.
1775         * amd64-fbsd-nat.c: Fix common/ includes.
1776         * amd64-dicos-tdep.c: Fix common/ includes.
1777         * amd64-darwin-tdep.c: Fix common/ includes.
1778         * agent.c: Fix common/ includes.
1779         * ada-lang.h: Fix common/ includes.
1780         * ada-lang.c: Fix common/ includes.
1781         * aarch64-tdep.c: Fix common/ includes.
1782
1783 2019-01-25  Tom Tromey  <tom@tromey.com>
1784
1785         * common/create-version.sh: Use common/version.h.
1786
1787 2019-01-24  Pedro Alves  <palves@redhat.com>
1788
1789         * infrun.c (signal_stop, signal_print, signal_program)
1790         (signal_catch, signal_pass): Now arrays instead of pointers.
1791         (update_signals_program_target, do_target_resume)
1792         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1793         * linux-nat.c (linux_nat_target::pass_signals)
1794         (linux_nat_target::create_inferior, linux_nat_target::attach):
1795         Adjust.
1796         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1797         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1798         * procfs.c (procfs_target::pass_signals): Adjust.
1799         * record-full.c (record_full_target::resume): Adjust.
1800         * remote.c (remote_target::pass_signals)
1801         (remote_target::program_signals): Adjust.
1802         * target-debug.h (target_debug_print_signals): Now takes a
1803         gdb::array_view as parameter.  Adjust.
1804         * target.h (target_ops) <pass_signals, program_signals>: Replace
1805         pointer and length parameters with gdb::array_view.
1806         (target_pass_signals, target_program_signals): Likewise.
1807         * target-delegates.c: Regenerate.
1808
1809 2019-01-24  Pedro Alves  <palves@redhat.com>
1810
1811         * common/forward-scope-exit.h
1812         (forward_scope_exit::forward_scope_exit): Pass arguments to
1813         m_bind_function directly, instead of creating a std::bind and
1814         copying that.
1815
1816 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1817
1818         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1819         for static members.
1820         (pass_in_v_vfp_candidate): Likewise.
1821
1822 2019-01-23  Tom Tromey  <tom@tromey.com>
1823             Pedro Alves  <palves@redhat.com>
1824
1825         * regcache.c (class regcache_invalidator): Remove.
1826         (regcache::raw_write): Use make_scope_exit.
1827
1828 2019-01-23  Tom Tromey  <tom@tromey.com>
1829
1830         * ui-out.h (class ui_out_emit_type): Update comment.
1831
1832 2019-01-23  Tom Tromey  <tom@tromey.com>
1833
1834         * infrun.c (fetch_inferior_event): Update comment.
1835
1836 2019-01-23  Tom Tromey  <tom@tromey.com>
1837             Pedro Alves  <palves@redhat.com>
1838
1839         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1840         parameter.
1841         (fetch_inferior_event): Use SCOPE_EXIT.
1842
1843
1844 2019-01-23  Tom Tromey  <tom@tromey.com>
1845             Pedro Alves  <palves@redhat.com>
1846
1847         * infrun.c (disable_thread_events): Delete.
1848         (stop_all_threads): Use SCOPE_EXIT.
1849
1850 2019-01-23  Tom Tromey  <tom@tromey.com>
1851             Pedro Alves  <palves@redhat.com>
1852
1853         * symfile.c: Include forward-scope-exit.h.
1854         (clear_symtab_users_cleanup): Replace forward declaration with
1855         a FORWARD_SCOPE_EXIT.
1856         (syms_from_objfile_1): Use the forward_scope_exit and
1857         gdb::optional instead of cleanup_function.
1858         (reread_symbols): Use the forward_scope_exit instead of
1859         cleanup_function.
1860         (clear_symtab_users_cleanup): Remove function.
1861
1862 2019-01-23  Tom Tromey  <tom@tromey.com>
1863             Pedro Alves  <palves@redhat.com>
1864
1865         * linux-nat.c: Include scope-exit.h.
1866         (cleanup_target_stop): Remove.
1867         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1868         SCOPE_EXIT.
1869
1870 2019-01-23  Tom Tromey  <tom@tromey.com>
1871             Pedro Alves  <palves@redhat.com>
1872
1873         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1874         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1875
1876 2019-01-23  Tom Tromey  <tom@tromey.com>
1877             Andrew Burgess  <andrew.burgess@embecosm.com>
1878             Pedro Alves  <palves@redhat.com>
1879
1880         * infrun.c (fetch_inferior_event): Use scope_exit.
1881         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1882         * top.c (execute_command): Use scope_exit.
1883         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1884         * utils.c (do_bpstat_clear_actions_cleanup)
1885         (make_bpstat_clear_actions_cleanup): Remove.
1886
1887 2019-01-23  Tom Tromey  <tom@tromey.com>
1888             Pedro Alves  <palves@redhat.com>
1889
1890         * infrun.c: Include "common/scope-exit.h"
1891         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1892         (wait_for_inferior): Use SCOPE_EXIT.
1893         (fetch_inferior_event): Use scope_exit.
1894
1895 2019-01-23  Tom Tromey  <tom@tromey.com>
1896             Pedro Alves  <palves@redhat.com>
1897
1898         * breakpoint.c (create_breakpoint): Remove cleanup.
1899
1900 2019-01-23  Tom Tromey  <tom@tromey.com>
1901             Andrew Burgess  <andrew.burgess@embecosm.com>
1902             Pedro Alves  <palves@redhat.com>
1903
1904 2019-01-23  Pedro Alves  <palves@redhat.com>
1905
1906         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1907
1908 2019-01-23  Pedro Alves  <palves@redhat.com>
1909             Andrew Burgess  <andrew.burgess@embecosm.com>
1910
1911         * gdbthread.h: Include "common/forward-scope-exit.h".
1912         (scoped_finish_thread_state): Redefine custom class in terms of
1913         forward_scope_exit.
1914
1915 2019-01-23  Pedro Alves  <palves@redhat.com>
1916             Andrew Burgess  <andrew.burgess@embecosm.com>
1917
1918         * common/forward-scope-exit.h: New file.
1919
1920 2019-01-23  Pedro Alves  <palves@redhat.com>
1921             Andrew Burgess  <andrew.burgess@embecosm.com>
1922             Tom Tromey  <tom@tromey.com>
1923
1924         * common/scope-exit.h: New file.
1925
1926 2019-01-23  Pedro Alves  <palves@redhat.com>
1927
1928         * common/preprocessor.h (ESC): Rename to ...
1929         (ESC_PARENS): ... this.
1930         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1931         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1932
1933 2019-01-23  Tom Tromey  <tom@tromey.com>
1934
1935         * language.h (class scoped_switch_to_sym_language_if_auto):
1936         Initialize m_lang in both cases.
1937
1938 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1939
1940         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1941         with XCNEW.
1942
1943 2019-01-22  Tom Tromey  <tom@tromey.com>
1944
1945         * corelow.c: Do not include sys/file.h.
1946
1947 2019-01-22  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-wingeneral.h: Include gdb_curses.h.
1950
1951 2019-01-22  Tom Tromey  <tom@tromey.com>
1952
1953         * source-cache.h (class source_cache) <get_source_lines,
1954         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1955
1956 2019-01-22  Tom Tromey  <tom@tromey.com>
1957
1958         * remote-fileio.h (struct remote_target): Declare.
1959
1960 2019-01-22  Tom Tromey  <tom@tromey.com>
1961
1962         * python/py-arch.c: Do not include py-ref.h.
1963         * python/py-bpevent.c: Do not include py-ref.h.
1964         * python/py-cmd.c: Do not include py-ref.h.
1965         * python/py-continueevent.c: Do not include py-ref.h.
1966         * python/py-event.h: Do not include py-ref.h.
1967         * python/py-evtregistry.c: Do not include py-ref.h.
1968         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1969         * python/py-frame.c: Do not include py-ref.h.
1970         * python/py-framefilter.c: Do not include py-ref.h.
1971         * python/py-function.c: Do not include py-ref.h.
1972         * python/py-infevents.c: Do not include py-ref.h.
1973         * python/py-linetable.c: Do not include py-ref.h.
1974         * python/py-objfile.c: Do not include py-ref.h.
1975         * python/py-param.c: Do not include py-ref.h.
1976         * python/py-prettyprint.c: Do not include py-ref.h.
1977         * python/py-progspace.c: Do not include py-ref.h.
1978         * python/py-symbol.c: Do not include py-ref.h.
1979         * python/py-symtab.c: Do not include py-ref.h.
1980         * python/py-type.c: Do not include py-ref.h.
1981         * python/py-unwind.c: Do not include py-ref.h.
1982         * python/py-utils.c: Do not include py-ref.h.
1983         * python/py-value.c: Do not include py-ref.h.
1984         * python/py-varobj.c: Do not include py-ref.h.
1985         * python/py-xmethods.c: Do not include py-ref.h.
1986         * python/python.c: Do not include py-ref.h.
1987         * varobj.c: Do not include py-ref.h.
1988
1989 2019-01-22  Tom Tromey  <tom@tromey.com>
1990
1991         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1992         keyword for bcache.
1993
1994 2019-01-22  Tom Tromey  <tom@tromey.com>
1995
1996         * compile/compile-cplus-types.c: Remove a comment by #include.
1997
1998 2019-01-22  Tom Tromey  <tom@tromey.com>
1999
2000         * compile/gcc-c-plugin.h: Include compile-internal.h.
2001
2002 2019-01-22  Tom Tromey  <tom@tromey.com>
2003
2004         * stabsread.c (EXTERN): Do not define.
2005         (symnum, next_symbol_text_func, processing_gcc_compilation)
2006         (within_function, global_sym_chain, global_stabs)
2007         (previous_stab_code, this_object_header_files)
2008         (n_this_object_header_files)
2009         (n_allocated_this_object_header_files): Define.
2010         * stabsread.h (EXTERN): Never define.  Use "extern".
2011
2012 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2013
2014         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2015         history_value.
2016
2017 2019-01-21  Tom Tromey  <tom@tromey.com>
2018
2019         * ui-out.c: Fix includes.
2020         * tui/tui-source.c: Fix includes.
2021         * target.c: Fix includes.
2022         * remote.c: Fix includes.
2023         * regcache.c: Fix includes.
2024         * python/py-block.c: Fix includes.
2025         * printcmd.c: Fix includes.
2026         * or1k-tdep.c: Fix includes.
2027         * mi/mi-main.c: Fix includes.
2028         * m32r-tdep.c: Fix includes.
2029         * csky-tdep.c: Fix includes.
2030         * compile/compile-cplus-types.c: Fix includes.
2031         * cli/cli-interp.c: Fix includes.
2032
2033 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2034
2035         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2036         for padding.
2037
2038 2019-01-16  Tom Tromey  <tom@tromey.com>
2039
2040         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2041         earlier.
2042         (struct objfile) <msymbols_range>: Move from top level.
2043         <msymbols>: New method.
2044         (class objfile_msymbols): Remove.
2045         * symtab.c (default_collect_symbol_completion_matches_break_on):
2046         Update.
2047         * symmisc.c (dump_msymbols): Update.
2048         * stabsread.c (scan_file_globals): Update.
2049         * objc-lang.c (info_selectors_command, info_classes_command)
2050         (find_methods): Update.
2051         * minsyms.c (find_solib_trampoline_target): Update.
2052         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2053         * coffread.c (coff_symfile_read): Update.
2054         * ada-lang.c (ada_lookup_simple_minsym)
2055         (ada_collect_symbol_completion_matches): Update.
2056
2057 2019-01-16  Tom Tromey  <tom@tromey.com>
2058
2059         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2060         type.  Remove no-argument constructor.
2061         <iterator::operator++>: Simplify.
2062         <begin>: Update.
2063         <end>: Use minimal_symbol_count.
2064
2065 2019-01-16  Tom Tromey  <tom@tromey.com>
2066
2067         * objfiles.h (struct objfile) <psymtabs>: New method.
2068         (class objfile_psymtabs): Remove.
2069         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2070         typedef.
2071         <range>: New method.
2072         (require_partial_symbols): Change return type.
2073         * psymtab.c (require_partial_symbols)
2074         (psym_expand_symtabs_matching): Update.
2075         * mdebugread.c (parse_partial_symbols): Update.
2076         * dbxread.c (dbx_end_psymtab): Update.
2077
2078 2019-01-15  Tom Tromey  <tom@tromey.com>
2079
2080         * symtab.c (lookup_objfile_from_block)
2081         (lookup_symbol_in_objfile_symtabs)
2082         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2083         (find_line_symtab, info_sources_command)
2084         (default_collect_symbol_completion_matches_break_on)
2085         (make_source_files_completion_list): Update.
2086         * symmisc.c (print_objfile_statistics, dump_objfile)
2087         (maintenance_print_symbols, maintenance_info_symtabs)
2088         (maintenance_check_symtabs, maintenance_info_line_tables):
2089         Update.
2090         * source.c (select_source_symtab)
2091         (forget_cached_source_info_for_objfile): Update.
2092         * objfiles.h (class objfile_compunits): Remove.
2093         (struct objfile) <compunits_range>: New typedef.
2094         (compunits): New method.
2095         * objfiles.c (objfile_relocate1): Update.
2096         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2097         * maint.c (count_symtabs_and_blocks): Update.
2098         * linespec.c (iterate_over_all_matching_symtabs): Update.
2099         * cp-support.c (add_symbol_overload_list_qualified): Update.
2100         * coffread.c (coff_symtab_read): Update.
2101         * ada-lang.c (add_nonlocal_symbols)
2102         (ada_collect_symbol_completion_matches)
2103         (ada_add_global_exceptions): Update.
2104
2105 2019-01-15  Tom Tromey  <tom@tromey.com>
2106
2107         * progspace.h (program_space) <objfiles_safe_range>: New
2108         typedef.
2109         <objfiles_safe>: New method.
2110         * objfiles.h (class all_objfiles_safe): Remove.
2111         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2112         * jit.c (jit_inferior_exit_hook): Update.
2113
2114 2019-01-17  Tom Tromey  <tom@tromey.com>
2115
2116         * progspace.h (program_space) <objfiles_range>: New typedef.
2117         <objfiles>: New method.
2118         <objfiles_head>: Rename from objfiles.
2119         (object_files): Update.
2120         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2121         * guile/scm-pretty-print.c
2122         (ppscm_find_pretty_printer_from_objfiles): Update.
2123         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2124         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2125         Update.
2126         * python/py-progspace.c (pspy_get_objfiles): Update.
2127         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2128         Update.
2129         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2130         (objfpy_lookup_objfile_by_build_id): Update.
2131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2132         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2133         Update.
2134         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2135         (expand_symtab_containing_pc, lookup_objfile_from_block)
2136         (lookup_static_symbol, basic_lookup_transparent_type)
2137         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2138         (find_line_symtab, info_sources_command)
2139         (default_collect_symbol_completion_matches_break_on)
2140         (make_source_files_completion_list, find_main_name): Update.
2141         * symmisc.c (print_symbol_bcache_statistics)
2142         (print_objfile_statistics, maintenance_print_symbols)
2143         (maintenance_print_msymbols, maintenance_print_objfiles)
2144         (maintenance_info_symtabs, maintenance_check_symtabs)
2145         (maintenance_expand_symtabs, maintenance_info_line_tables):
2146         Update.
2147         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2148         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2149         (map_overlay_command, unmap_overlay_command)
2150         (simple_overlay_update, expand_symtabs_matching)
2151         (map_symbol_filenames): Update.
2152         * symfile-debug.c (set_debug_symfile): Update.
2153         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2154         Update.
2155         * source.c (select_source_symtab, forget_cached_source_info):
2156         Update.
2157         * solib.c (solib_read_symbols): Update.
2158         * solib-spu.c (append_ocl_sos): Update.
2159         * psymtab.c (maintenance_print_psymbols)
2160         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2161         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2162         * printcmd.c (info_symbol_command): Update.
2163         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2164         Update.
2165         * objfiles.h (class all_objfiles): Remove.
2166         * objfiles.c (have_partial_symbols, have_full_symbols)
2167         (have_minimal_symbols, qsort_cmp, update_section_map)
2168         (shared_objfile_contains_address_p)
2169         (default_iterate_over_objfiles_in_search_order): Update.
2170         * objc-lang.c (info_selectors_command, info_classes_command)
2171         (find_methods): Update.
2172         * minsyms.c (find_solib_trampoline_target): Update.
2173         * maint.c (maintenance_info_sections)
2174         (maintenance_translate_address, count_symtabs_and_blocks):
2175         Update.
2176         * main.c (captured_main_1): Update.
2177         * linux-thread-db.c (try_thread_db_load_from_pdir)
2178         (has_libpthread): Update.
2179         * linespec.c (iterate_over_all_matching_symtabs)
2180         (search_minsyms_for_name): Update.
2181         * jit.c (jit_find_objf_with_entry_addr): Update.
2182         * hppa-tdep.c (find_unwind_entry)
2183         (hppa_lookup_stub_minimal_symbol): Update.
2184         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2185         Update.
2186         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2187         (elf_gnu_ifunc_resolve_by_got): Update.
2188         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2189         * dwarf-index-write.c (save_gdb_index_command): Update.
2190         * cp-support.c (add_symbol_overload_list_qualified): Update.
2191         * breakpoint.c (create_overlay_event_breakpoint)
2192         (create_longjmp_master_breakpoint)
2193         (create_std_terminate_master_breakpoint)
2194         (create_exception_master_breakpoint): Update.
2195         * blockframe.c (find_pc_partial_function): Update.
2196         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2197         (ada_collect_symbol_completion_matches)
2198         (ada_add_global_exceptions): Update.
2199
2200 2019-01-17  Tom Tromey  <tom@tromey.com>
2201
2202         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2203         declare VEC.
2204         (solib_target_parse_libraries): Change return type.
2205         (library_list_start_segment, library_list_start_section)
2206         (library_list_end_library, library_list_start_library); Update.
2207         (solib_target_free_library_list): Remove.
2208         (solib_target_parse_libraries): Remove cleanup.  Change return
2209         type.
2210         (solib_target_current_sos): Update.
2211
2212 2019-01-17  Tom Tromey  <tromey@bapiya>
2213
2214         * valprint.c: Replace "the the" with "the".
2215         * symtab.c: Replace "the the" with "the".
2216         * solib.c: Replace "the the" with "the".
2217         * solib-dsbt.c: Replace "the the" with "the".
2218         * linespec.c: Replace "the the" with "the".
2219         * dwarf2loc.h: Replace "the the" with "the".
2220         * amd64-windows-tdep.c: Replace "the the" with "the".
2221         * aarch64-tdep.c: Replace "the the" with "the".
2222
2223 2019-01-16  Keith Seitz  <keiths@redhat.com>
2224
2225         PR gdb/23773
2226         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2227         <builder>: Rename to ..
2228         <m_builder>: ... this and make private.
2229         (dwarf2_cu::get_builder): New method.  Change all users of
2230         `builder' to use this method.
2231         (dwarf2_start_symtab): Move to ...
2232         (dwarf2_cu::start_symtab): ... here.  Update all callers
2233         (setup_type_unit_groups): Move to ...
2234         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2235         callers.
2236         (dwarf2_cu::reset_builder): New method.
2237         (process_full_compunit, process_full_type_unit): Use
2238         dwarf2_cu::reset_builder.
2239         (follow_die_offset): Record the ancestor CU if it is different
2240         from the followed DIE's CU.
2241         (follow_die_sig_1): Likewise.
2242
2243 2019-01-15  Tom Tromey  <tom@tromey.com>
2244
2245         * remote.c (class remote_state) <buf>: Now a char_vector.
2246         <buf_size>: Remove.
2247         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2248         parameter.
2249         (remote_target::getpkt_or_notif_sane_1)
2250         (remote_target::getpkt_sane)
2251         (remote_target::getpkt_or_notif_sane): Likewise.
2252         (class remote_target) <putpkt>: New overload.
2253         (remote_target::read_frame): Change type of "buf_p".  Remove
2254         sizeof_p parameter.
2255         (packet_ok): New overload.
2256         (packet_check_result): New overload.
2257         Update all uses.
2258
2259 2019-01-14  Tom Tromey  <tom@tromey.com>
2260
2261         * remote-notif.c (handle_notification, remote_notif_ack)
2262         (remote_notif_parse): Make "buf" const.
2263         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2264         const.
2265         (remote_notif_parse, remote_notif_ack, handle_notification):
2266         Likewise.
2267         * remote.c (remote_notif_stop_parse): Make "buf" const.
2268         (remote_target::remote_parse_stop_reply): Make "buf" const.
2269         (remote_notif_stop_ack): Make "buf" const.
2270
2271 2019-01-14  Tom Tromey  <tom@tromey.com>
2272
2273         * remote.c (remote_console_output): Make parameter const.
2274
2275 2019-01-14  Tom Tromey  <tom@tromey.com>
2276
2277         * target-debug.h (target_debug_print_signals): Constify.
2278         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2279         * procfs.c (procfs_target::pass_signals): Update.
2280         * linux-nat.c (linux_nat_target::pass_signals): Update.
2281         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2282         * target-delegates.c: Rebuild.
2283         * remote.c (remote_target::program_signals): Update.
2284         (remote_target::pass_signals): Update.
2285         * target.c (target_pass_signals): Constify argument.
2286         (target_program_signals): Likewise.
2287         * target.h (struct target_ops) <pass_signals, program_signals>:
2288         Constify argument.
2289         (target_pass_signals, target_program_signals): Constify argument.
2290
2291 2019-01-14  Tom Tromey  <tom@tromey.com>
2292
2293         PR tui/28819:
2294         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2295
2296 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2297
2298         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2299         field.
2300         * rs6000-tdep.c: Include reggroups.h.
2301         (IS_V_ALIAS_PSEUDOREG): Define.
2302         (rs6000_register_name): Return names for the "vX" aliases.
2303         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2304         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2305         aliases.  Call default_register_reggroup_p for all other
2306         pseudo-registers.
2307         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2308         New functions.
2309         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2310         Handle "vX" aliases.
2311         (v_alias_pseudo_register_collect): New function.
2312         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2313         (rs6000_gdbarch_init): Initialize "vX" aliases as
2314         pseudo-registers.  Restore registration of
2315         rs6000_pseudo_register_reggroup_p with
2316         set_tdesc_pseudo_register_reggroup_p.
2317
2318 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2319
2320         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2321         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2322         set_gdbarch_num_pseudo_regs.
2323
2324 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2325
2326         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2327         Remove arg prefixname, add do_set and do_show.
2328         Add member functions set_list and show_list.
2329         * cli/cli-style.c (class cli_style_option): Update accordingly.
2330         (style_set_list): Move to file scope.
2331         (style_show_list): Likewise.
2332         (set_style): Call help_list.
2333         (show_style): Call cmd_show_list.
2334         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2335         Update to use the new macro.
2336
2337 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2338
2339         * ada-lang.c (_initialize_ada_language): Expand the help text
2340         for the "catch exception" command.
2341
2342 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2343
2344         * symtab.c (matching_obj_sections): Initialize obj,
2345         declare it closer to its usage.
2346
2347 2019-01-10  Tom Tromey  <tom@tromey.com>
2348
2349         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2350         (basic_inf_threads_range): Remove.
2351         (inf_threads_range, inf_non_exited_threads_range)
2352         (safe_inf_threads_range): Use next_adapter.
2353
2354 2019-01-10  Keith Seitz  <keiths@redhat.com>
2355
2356         PR gdb/23712
2357         PR symtab/23010
2358         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2359         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2360
2361 2019-01-10  Keith Seitz  <keiths@redhat.com>
2362
2363         PR gdb/23712
2364         PR symtab/23010
2365         * dictionary.c (pending_to_vector): Remove.
2366         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2367         Remove _1 suffix, replacing functions of the same name.  Update
2368         all callers.
2369         (dict_create_hashed, dict_create_hashed_expandable)
2370         (dict_create_linear, dict_create_linear_expandable, dict_free)
2371         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2372         Make functions static.
2373
2374 2019-01-10  Keith Seitz  <keiths@redhat.com>
2375
2376         PR gdb/23712
2377         PR symtab/23010
2378         * dictionary.h (struct dictionary): Replace declaration with
2379         multidictionary.
2380         (dict_create_hashed, dict_create_hashed_expandable)
2381         (dict_create_linear, dict_create_linear_expandable)
2382         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2383         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2384         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2385         taking multidictionary argument.
2386         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2387         * block.h (struct block) <dict>: Change to multidictionary
2388         and rename `multidict'.
2389         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2390         symmisc.c: Update all dictionary references to multidictionary.
2391
2392 2019-01-10  Keith Seitz  <keiths@redhat.com>
2393
2394         PR gdb/23712
2395         PR symtab/23010
2396         * dictionary.c: Include unordered_map.
2397         (pending_to_vector): New function.
2398         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2399         Rewrite the non-"_1" functions to take vector instead
2400         of linked list.
2401         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2402         "new" _1 versions of the same name.
2403         (multidictionary): Define.
2404         (std::hash<enum language): New definition.
2405         (collate_pending_symbols_by_language, mdict_create_hashed)
2406         (mdict_create_hashed_expandable, mdict_create_linear)
2407         (mdict_create_linear_expandable, mdict_free)
2408         (find_language_dictionary, create_new_language_dictionary)
2409         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2410         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2411         (mdict_size, mdict_empty): New functions.
2412         * dictionary.h (mdict_iterator): Define.
2413
2414 2019-01-10  Pedro Alves  <palves@redhat.com>
2415
2416         * breakpoint.c (read_uploaded_action)
2417         (create_tracepoint_from_upload): Adjust to use
2418         gdb::unique_xmalloc_ptr.
2419         * ctf.c (ctf_write_uploaded_tp):
2420         (SET_ARRAY_FIELD): Use emplace_back.
2421         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2422         * tracefile-tfile.c (tfile_write_uploaded_tp):
2423         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2424         gdb::unique_xmalloc_ptr.
2425         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2426         at_string, cond_string, cmd_strings>: Replace char pointers
2427         with gdb::unique_xmalloc_ptr.
2428
2429 2019-01-10  Pedro Alves  <palves@redhat.com>
2430
2431         * solib-target.c (library_list_start_library): Don't xstrdup name.
2432
2433 2019-01-10  Pedro Alves  <palves@redhat.com>
2434
2435         * mdebugread.c (parse_partial_symbols): Use
2436         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2437
2438 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2439
2440         * linux-fork.c (scoped_switch_fork_info)
2441         <~scoped_switch_fork_info>: Fix incorrect variable name.
2442
2443 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * linux-fork.c (scoped_switch_fork_info)
2446         <scoped_switch_fork_info>: Make explicit.
2447         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2448
2449 2019-01-10  Tom Tromey  <tom@tromey.com>
2450
2451         * objfiles.h (objfile::reset_psymtabs): Update.
2452         * objfiles.c (objfile::objfile): Update.
2453         * psymtab.h (psymtab_storage::obstack): Update.
2454         (psymtab_storage::m_obstack): Use gdb::optional.
2455         (class psymtab_storage): Update comment.  Remove objfile
2456         parameter.
2457         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2458
2459 2019-01-10  Tom Tromey  <tom@tromey.com>
2460
2461         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2462         <free_psymtabs>: Now private.
2463         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2464         (allocate_psymtab): Use new method.
2465
2466 2019-01-10  Tom Tromey  <tom@tromey.com>
2467
2468         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2469         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2470         * mdebugread.c (parse_partial_symbols): Use
2471         allocate_dependencies.
2472         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2473         allocate_dependencies.
2474         (process_psymtab_comp_unit_reader)
2475         (build_type_psymtab_dependencies): Likewise.
2476         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2477
2478 2019-01-10  Tom Tromey  <tom@tromey.com>
2479
2480         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2481         PSYMBOL_SET_LANGUAGE.
2482         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2483
2484 2019-01-10  Tom Tromey  <tom@tromey.com>
2485
2486         * psymtab.h (psymtab_storage::obstack): New method.
2487         <m_obstack>: Rename from obstack; now private.
2488         * psymtab.c (psymtab_storage): Update.
2489         * dwarf2read.c (create_addrmap_from_index)
2490         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2491         Update.
2492
2493 2019-01-10  Tom Tromey  <tom@tromey.com>
2494
2495         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2496         * objfiles.h (objfile::reset_psymtabs): New method.
2497
2498 2019-01-10  Tom Tromey  <tom@tromey.com>
2499
2500         * symmisc.c (print_symbol_bcache_statistics): Update.
2501         (print_objfile_statistics): Update.
2502         * symfile.c (reread_symbols): Update.
2503         * psymtab.h (class psymtab_storage): New.
2504         * psymtab.c (psymtab_storage): New constructor.
2505         (~psymtab_storage): New destructor.
2506         (require_partial_symbols): Update.
2507         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2508         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2509         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2510         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2511         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2512         (start_psymtab_common, end_psymtab_common)
2513         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2514         (allocate_psymtab): Update.
2515         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2516         Update.
2517         (dump_psymtab_addrmap, maintenance_print_psymbols)
2518         (maintenance_check_psymtabs): Update.
2519         (class objfile_psymtabs): Move to objfiles.h.
2520         * psympriv.h (discard_psymtab): Now inline.
2521         (psymtab_discarder::psymtab_discarder): Update.
2522         (psymtab_discarder::~psymtab_discarder): Update.
2523         (ALL_OBJFILE_PSYMTABS): Rewrite.
2524         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2525         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2526         Remove fields.
2527         <partial_symtabs>: New field.
2528         (class objfile_psymtabs): Move from psymtab.h.  Update.
2529         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2530         psymbol_cache.
2531         (objfile::~objfile): Don't destroy psymbol_cache.
2532         * mdebugread.c (parse_partial_symbols): Update.
2533         * dwarf2read.c (create_addrmap_from_index)
2534         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2535         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2536         (add_partial_subprogram, dwarf2_ranges_read): Update.
2537         * dwarf-index-write.c (write_address_map)
2538         (write_one_signatured_type, recursively_write_psymbols)
2539         (class debug_names, class debug_names, write_psymtabs_to_index):
2540         Update.
2541
2542 2019-01-10  Tom Tromey  <tom@tromey.com>
2543
2544         * symtab.h (SYMBOL_SET_NAMES): Update.
2545         (symbol_set_names): Update.
2546         (MSYMBOL_SET_NAMES): Update.
2547         * symtab.c (symbol_set_names): Change argument to be an
2548         objfile_per_bfd_storage.
2549         * psymtab.c (add_psymbol_to_bcache): Update.
2550         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2551
2552 2019-01-10  Tom Tromey  <tom@tromey.com>
2553
2554         * symtab.c (create_demangled_names_hash): Change argument to be an
2555         objfile_per_bfd_storage.
2556         (symbol_set_names): Update.
2557
2558 2019-01-10  Tom Tromey  <tom@tromey.com>
2559
2560         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2561         init_psymbol_list.
2562         * psymtab.c (init_psymbol_list): Do nothing if already called.
2563         * psympriv.h (init_psymbol_list): Add comment.
2564         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2565         init_psymbol_list.
2566         * dbxread.c (dbx_symfile_read): Unconditionally call
2567         init_psymbol_list.
2568
2569 2019-01-10  Tom Tromey  <tom@tromey.com>
2570
2571         * xcoffread.c (scan_xcoff_symtab): Update.
2572         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2573         "where".
2574         * mdebugread.c (parse_partial_symbols)
2575         (handle_psymbol_enumerators): Update.
2576         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2577         * dbxread.c (read_dbx_symtab): Update.
2578         * psympriv.h (psymbol_placement): New enum.
2579         (add_psymbol_to_list): Update.
2580
2581 2019-01-10  Tom Tromey  <tom@tromey.com>
2582
2583         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2584         static_psymbols parameters.
2585         (scan_xcoff_symtab): Update.
2586         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2587         static_psymbols parameters.
2588         * psympriv.h (start_psymtab_common): Update.
2589         * mdebugread.c (parse_partial_symbols): Update.
2590         * dwarf2read.c (create_partial_symtab): Update.
2591         * dbxread.c (read_dbx_symtab): Update.
2592         (start_psymtab): Remove global_psymbols and static_psymbols
2593         parameters.
2594
2595 2019-01-10  Tom Tromey  <tom@tromey.com>
2596
2597         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2598         * psymtab.c (allocate_psymtab): Add comment.
2599         * psympriv.h (allocate_psymtab): Add comment.
2600         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2601         initializations.
2602         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2603
2604 2019-01-10  Tom Tromey  <tom@tromey.com>
2605
2606         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2607         Don't declare.
2608         * mipsread.c: Include mdebugread.h.
2609         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2610         Declare.
2611         * elfread.c: Include mdebugread.h.
2612
2613 2019-01-09  Tom Tromey  <tom@tromey.com>
2614
2615         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2616         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2617         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2618         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2619         (psym_lookup_symbol, psym_find_last_source_symtab)
2620         (psym_forget_cached_source_info, psym_print_stats)
2621         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2622         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2623         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2624         (psym_find_compunit_symtab_by_address)
2625         (maintenance_print_psymbols, maintenance_info_psymtabs)
2626         (maintenance_check_psymtabs): Use ranged for.
2627         * psymtab.h (class objfile_psymtabs): New.
2628         (require_partial_symbols): Return objfile_psymtabs.
2629         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2630
2631 2019-01-09  Tom Tromey  <tom@tromey.com>
2632
2633         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2634         (find_pc_mapped_section, list_overlays_command)
2635         (map_overlay_command, unmap_overlay_command)
2636         (simple_overlay_update): Use all_objfiles.
2637         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2638         * printcmd.c (info_symbol_command): Use all_objfiles.
2639         * objfiles.h (ALL_OBJSECTIONS): Remove.
2640         * maint.c (maintenance_translate_address): Use all_objfiles.
2641         * gcore.c (gcore_create_callback): Use all_objfiles.
2642         (objfile_find_memory_regions): Likewise.
2643
2644 2019-01-09  Tom Tromey  <tom@tromey.com>
2645
2646         * symtab.c (find_line_symtab, info_sources_command)
2647         (make_source_files_completion_list): Use objfile_compunits.
2648         * source.c (select_source_symtab): Use objfile_compunits.
2649         * objfiles.h (struct objfile): Update comment.
2650         (ALL_OBJFILES): Remove.
2651         (ALL_FILETABS): Remove.
2652         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2653         objfile_compunits.
2654
2655 2019-01-09  Tom Tromey  <tom@tromey.com>
2656
2657         * symmisc.c (print_objfile_statistics, dump_objfile)
2658         (maintenance_print_symbols): Use compunit_filetabs.
2659         * source.c (forget_cached_source_info_for_objfile): Use
2660         compunit_filetabs.
2661         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2662         (ALL_FILETABS): Use compunit_filetabs.
2663         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2664         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2665
2666 2019-01-09  Tom Tromey  <tom@tromey.com>
2667
2668         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2669         (compunit_filetabs): New.
2670         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2671         compunit_filetabs.
2672         (info_sources_command, make_source_files_completion_list): Remove
2673         declaration.
2674         * symmisc.c (print_objfile_statistics, dump_objfile)
2675         (maintenance_print_symbols): Remove declaration.
2676         (maintenance_info_symtabs): Use compunit_filetabs.
2677         (maintenance_info_line_tables): Likewise.
2678         * source.c (select_source_symtab): Change local variable name.
2679         (forget_cached_source_info_for_objfile): Remove declaration.
2680         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2681         * objfiles.c (objfile_relocate1): Remove declaration.
2682         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2683         declaration.
2684         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2685         * coffread.c (coff_symtab_read): Remove declaration.
2686         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2687         compunit_filetabs.
2688
2689 2019-01-09  Tom Tromey  <tom@tromey.com>
2690
2691         * symtab.c (lookup_objfile_from_block)
2692         (find_pc_sect_compunit_symtab, search_symbols)
2693         (default_collect_symbol_completion_matches_break_on): Use
2694         objfile_compunits.
2695         * objfiles.h (ALL_COMPUNITS): Remove.
2696         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2697         * cp-support.c (add_symbol_overload_list_qualified): Use
2698         objfile_compunits.
2699         * ada-lang.c (ada_collect_symbol_completion_matches)
2700         (ada_add_global_exceptions): Use objfile_compunits.
2701
2702 2019-01-09  Tom Tromey  <tom@tromey.com>
2703
2704         * source.c (select_source_symtab)
2705         (forget_cached_source_info_for_objfile): Remove declaration.
2706         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2707         declaration.
2708         * maint.c (count_symtabs_and_blocks): Remove declaration.
2709         * cp-support.c (add_symbol_overload_list_qualified): Remove
2710         declaration.
2711         * coffread.c (coff_symtab_read): Remove declaration.
2712         * symtab.c (lookup_symbol_in_objfile_symtabs)
2713         (basic_lookup_transparent_type_1): Use objfile_compunits.
2714         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2715         (info_sources_command, search_symbols)
2716         (default_collect_symbol_completion_matches_break_on)
2717         (make_source_files_completion_list): Remove declaration.
2718         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2719         (ada_collect_symbol_completion_matches)
2720         (ada_add_global_exceptions): Remove declaration.
2721         * linespec.c (iterate_over_all_matching_symtabs): Use
2722         objfile_compunits.
2723         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2724         (class objfile_compunits): New.
2725         (ALL_COMPUNITS): Use objfile_compunits.
2726         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2727         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2728         objfile_compunits.
2729         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2730
2731 2019-01-09  Tom Tromey  <tom@tromey.com>
2732
2733         * symtab.c (search_symbols)
2734         (default_collect_symbol_completion_matches_break_on): Use
2735         objfile_msymbols.
2736         * ada-lang.c (ada_lookup_simple_minsym)
2737         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2738         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2739         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2740         objfile_msymbols.
2741         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2742         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2743         * objc-lang.c (find_methods): Use objfile_msymbols.
2744         (info_selectors_command, info_classes_command): Likewise.
2745         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2746         * objfiles.h (class objfile_msymbols): New.
2747         (ALL_OBJFILE_MSYMBOLS): Remove.
2748         (ALL_MSYMBOLS): Remove.
2749
2750 2019-01-09  Tom Tromey  <tom@tromey.com>
2751
2752         * common/next-iterator.h (next_adapter): Add Iterator template
2753         parameter.
2754         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2755         (class all_objfiles_safe): New.
2756         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2757         * objfiles.c (put_objfile_before): Update comment.
2758         (add_separate_debug_objfile): Likewise.
2759         (free_all_objfiles): Use all_objfiles_safe.
2760         (objfile_purge_solibs): Likewise.
2761
2762 2019-01-09  Tom Tromey  <tom@tromey.com>
2763
2764         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2765         (expand_symtab_containing_pc, lookup_static_symbol)
2766         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2767         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2768         all_objfiles.
2769         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2770         * breakpoint.c (create_overlay_event_breakpoint)
2771         (create_longjmp_master_breakpoint)
2772         (create_std_terminate_master_breakpoint)
2773         (create_exception_master_breakpoint): Use all_objfiles.
2774         * linux-thread-db.c (try_thread_db_load_from_pdir)
2775         (has_libpthread): Use all_objfiles.
2776         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2777         * linespec.c (iterate_over_all_matching_symtabs)
2778         (search_minsyms_for_name): Use all_objfiles.
2779         * maint.c (maintenance_info_sections): Use all_objfiles.
2780         * main.c (captured_main_1): Use all_objfiles.
2781         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2782         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2783         * guile/scm-pretty-print.c
2784         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2785         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2786         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2787         (maintenance_print_msymbols): Use all_objfiles.
2788         * source.c (select_source_symtab): Use all_objfiles.
2789         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2790         * symfile.c (remove_symbol_file_command)
2791         (expand_symtabs_matching, map_symbol_filenames): Use
2792         all_objfiles.
2793         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2794         all_objfiles.
2795         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2796         * objc-lang.c (find_methods): Use all_objfiles.
2797         * objfiles.c (have_partial_symbols, have_full_symbols)
2798         (have_minimal_symbols, qsort_cmp)
2799         (default_iterate_over_objfiles_in_search_order): Use
2800         all_objfiles.
2801         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2802         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2803         (maintenance_check_psymtabs): Use all_objfiles.
2804         (ALL_PSYMTABS): Remove.
2805         * compile/compile-object-run.c (do_module_cleanup): Use
2806         all_objfiles.
2807         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2808         * cp-support.c (add_symbol_overload_list_qualified): Use
2809         all_objfiles.
2810         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2811         Use all_objfiles.
2812         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2813         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2814         all_objfiles.
2815         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2816         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2817         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2818         Uses all_objfiles.
2819         * solib.c (solib_read_symbols): Use all_objfiles
2820
2821 2019-01-09  Tom Tromey  <tom@tromey.com>
2822
2823         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2824         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2825         all_objfiles.
2826         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2827         * symmisc.c (print_symbol_bcache_statistics)
2828         (print_objfile_statistics, maintenance_print_objfiles)
2829         (maintenance_info_symtabs, maintenance_check_symtabs)
2830         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2831         all_objfiles.
2832         * source.c (forget_cached_source_info): Use all_objfiles.
2833         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2834         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2835         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2836         * objfiles.c (update_section_map): Use all_objfiles.
2837         (shared_objfile_contains_address_p): Likewise.
2838         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2839         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2840
2841 2019-01-09  Tom Tromey  <tom@tromey.com>
2842
2843         * common/next-iterator.h: New file.
2844         * objfiles.h (class all_objfiles): New.
2845         (struct objfile_iterator): New.
2846
2847 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2848
2849         * NEWS: Move the description of the changed "frame", "select-frame",
2850          and "info frame" commands to the Changed commands section.
2851
2852 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2853
2854         * gdbtypes.c (check_stub_method_group): Remove handling of old
2855         mangling schemes.
2856         * linespec.c (find_methods): Likewise.
2857         * stabsread.c (read_member_functions): Likewise.
2858         * valops.c (search_struct_method): Likewise.
2859         (value_struct_elt_for_reference): Likewise.
2860         * NEWS: Mention this change.
2861
2862 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2865         print_source_lines.
2866         * source.c (print_source_lines_base): Update line number check.
2867         (print_source_lines): New function.
2868         (source_lines_range::source_lines_range): New function.
2869         * source.h (class source_lines_range): New class.
2870         (print_source_lines): New declaration.
2871
2872 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2873
2874         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2875
2876 2019-01-08  Tom Tromey  <tom@tromey.com>
2877             Simon Marchi  <simon.marchi@ericsson.com>
2878
2879         PR gdb/24060
2880         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2881         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2882         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2883         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2884         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2885         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2886
2887 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * source.c (select_source_symtab): Move header comment to
2890         declaration in source.h.
2891         (forget_cached_source_info_for_objfile): Likewise.
2892         (forget_cached_source_info): Likewise.
2893         (identify_source_line): Likewise.
2894         * source.h (identify_source_line): Move declaration from symtab.h
2895         and add comment from source.c
2896         (print_source_lines): Likewise.
2897         (forget_cached_source_info_for_objfile): Likewise.
2898         (forget_cached_source_info): Likewise.
2899         (select_source_symtab): Likewise.
2900         (enum print_source_lines_flag): Move definition from symtab.h.
2901         * symtab.h (identify_source_line): Move declaration to source.h.
2902         (print_source_lines): Likewise.
2903         (forget_cached_source_info_for_objfile): Likewise.
2904         (forget_cached_source_info): Likewise.
2905         (select_source_symtab): Likewise.
2906         (enum print_source_lines_flag): Move definition to source.h.
2907         * tui/tui-hooks.c: Add 'source.h' include.
2908
2909 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * source.c (print_source_lines_base): Handle requests to print
2912         reverse line number sequences, and guard against empty lines
2913         string.
2914
2915 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2916
2917         * source.c (print_source_lines_base): Fix skip of '\r' if next
2918         character is '\n'.
2919
2920 2019-01-06  Tom Tromey  <tom@tromey.com>
2921
2922         * c-exp.y (struct c_parse_state) <macro_original_text,
2923         expansion_obstack>: New member.
2924         (macro_original_text, expansion_obstack): Remove globals.
2925         (scan_macro_expansion, scanning_macro_expansion)
2926         (finished_macro_expansion): Update.
2927         (scan_macro_cleanup): Remove.
2928         (yylex, c_parse): Update.
2929
2930 2019-01-06  Tom Tromey  <tom@tromey.com>
2931
2932         * c-exp.y (struct c_parse_state) <strings>: New member.
2933         (operator_stoken): Update.
2934
2935 2019-01-06  Tom Tromey  <tom@tromey.com>
2936
2937         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2938         (union type_stack_elt) <typelist_val>: Now a pointer to
2939         std::vector.
2940         (type_stack_cleanup): Don't declare.
2941         (push_typelist): Update.
2942         * parse.c (pop_typelist): Return a std::vector.
2943         (push_typelist): Take a std::vector.
2944         (follow_types): Update.  Do not free args.
2945         (type_stack_cleanup): Remove.
2946         * c-exp.y (struct c_parse_state): New.
2947         (cpstate): New global.
2948         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2949         (nonempty_typelist): Update.
2950         (func_mod): Create a new vector.
2951         (c_parse): Create a c_parse_state.
2952         (check_parameter_typelist): Do not delete params.
2953         (function_method): Update.  Do not delete type_list.
2954
2955 2019-01-06  Tom Tromey  <tom@tromey.com>
2956
2957         PR gdb/28155:
2958         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2959         check_typedef.
2960         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2961         (print_return_value): Likewise.
2962
2963 2019-01-05  Tom Tromey  <tom@tromey.com>
2964
2965         * contrib/cleanup_check.py: Remove.
2966         * contrib/gcc-with-excheck: Remove.
2967         * contrib/exsummary.py: Remove.
2968         * contrib/excheck.py: Remove.
2969
2970 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2971
2972         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2973         NULL. Initialize tpprev to NULL instead of assigning it
2974         to NULL on the next statement.
2975         * windows-nat.c (windows_delete_thread): Remove check for
2976         main_thread_id before printing thread exit notifications.
2977         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2978         Remove thread ID check against main_thread_id.
2979         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2980         windows_delete_thread.
2981         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2982
2983 2019-01-04  Tom Tromey  <tom@tromey.com>
2984
2985         * compile/compile.c (_initialize_compile): Use upper case for
2986         metasyntactic variables.
2987         * symmisc.c (_initialize_symmisc): Use upper case for
2988         metasyntactic variables.
2989         * psymtab.c (_initialize_psymtab): Use upper case for
2990         metasyntactic variables.
2991         * demangle.c (demangle_command): Use upper case for metasyntactic
2992         variables.
2993         (_initialize_demangler): Likewise.
2994         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2995         variables.
2996
2997 2019-01-03  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3000
3001 2019-01-03  Tom Tromey  <tom@tromey.com>
3002
3003         * python/py-symtab.c (salpy_str): Update.
3004         (struct salpy_sal_object) <symtab>: Now a PyObject.
3005         (salpy_dealloc): Update.
3006         (del_objfile_sal): Use gdbpy_ref.
3007
3008 2019-01-03  Tom Tromey  <tom@tromey.com>
3009
3010         * python/py-type.c (convert_field): Use new_reference.  Return
3011         gdbpy_ref.
3012         (make_fielditem): Return gdbpy_ref.
3013         (typy_fields): Update.
3014         (typy_getitem): Update.
3015         (field_name): Return gdbpy_ref.  Use new_reference.
3016         (typy_iterator_iternext): Update.
3017
3018 2019-01-03  Tom Tromey  <tom@tromey.com>
3019
3020         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3021
3022 2019-01-03  Tom Tromey  <tom@tromey.com>
3023
3024         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3025         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3026         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3027         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3028         (pspy_set_type_printers): Likewise.
3029         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3030         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3031         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3032         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3033         (objfpy_set_type_printers): Likewise.
3034
3035 2019-01-03  Tom Tromey  <tom@tromey.com>
3036
3037         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3038         (gdbpy_print_stack): Use gdbpy_err_fetch.
3039         * python/python-internal.h (class gdbpy_err_fetch): New class.
3040         (class gdbpy_enter) <m_error_type, m_error_value,
3041         m_error_traceback>: Remove.
3042         <m_error>: New member.
3043         (gdbpy_exception_to_string): Don't declare.
3044         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3045         * python/py-value.c (convert_value_from_python): Use
3046         gdbpy_err_fetch.
3047         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3048         gdbpy_exception_to_string.
3049         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3050         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3051         gdbpy_err_fetch.
3052
3053 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3054
3055         * linux-nat.c (delete_lwp_cleanup): Delete.
3056         (struct lwp_deleter): New struct.
3057         (lwp_info_up): New typedef.
3058         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3059         lwp_info_up.
3060
3061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * linux-fork.c (class scoped_switch_fork_info): New class.
3064         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3065
3066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         * valops.c (find_overload_match): Remove use of null_cleanup, and
3069         calls to do_cleanups.
3070
3071 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3072
3073         * compile/compile-cplus-types.c
3074         (compile_cplus_instance::decl_name): Handle changes to
3075         cp_func_name.
3076         * cp-support.c (cp_func_name): Update header comment, update
3077         return type.
3078         * cp-support.h (cp_func_name): Update return type in declaration.
3079         * valops.c (find_overload_match): Move temp_func local to top
3080         level of function and change its type.  Use temp_func to hold and
3081         delete temporary string obtained from cp_func_name.
3082
3083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3086         gdb::char_vector, remove cleanup, and update uses of `msg`.
3087
3088 2019-01-03  Jim Wilson  <jimw@sifive.com>
3089
3090         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3091
3092 2019-01-02  Tom Tromey  <tom@tromey.com>
3093
3094         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3095         (tdesc_parse_xml): Remove cleanups.
3096         * target-descriptions.h (make_cleanup_free_target_description):
3097         Don't declare.
3098         (target_desc_deleter): New struct.
3099         (target_desc_up): New typedef.
3100         * target-descriptions.c (target_desc_deleter::operator()): Rename
3101         from free_target_description.
3102         (make_cleanup_free_target_description): Remove.
3103
3104 2019-01-02  Tom Tromey  <tom@tromey.com>
3105
3106         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3107         constructor, destructor.
3108         (linespec_parser): Remove typedef.
3109         (~linespec_parser): Rename from linespec_parser_delete.
3110         (linespec_lex_to_end, linespec_complete_label)
3111         (linespec_complete): Update.
3112         (decode_line_full): Remove cleanups.
3113         (decode_line_1): Update.
3114
3115 2019-01-02  Tom Tromey  <tom@tromey.com>
3116
3117         * python/python-internal.h (inferior_to_inferior_object): Change
3118         return type.
3119         * python/py-exitedevent.c (create_exited_event_object): Update.
3120         * python/py-inferior.c (inferior_to_inferior_object): Return
3121         gdbpy_ref.
3122         (python_new_inferior, python_inferior_deleted)
3123         (thread_to_thread_object, delete_thread_object)
3124         (build_inferior_list, gdbpy_selected_inferior): Update.
3125         * python/py-infthread.c (create_thread_object): Update.  Also fail
3126         if inferior_to_inferior_object fails.
3127
3128 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3129
3130         * inferior.h (class inferior) <displaced_step_state>: New field.
3131         * infrun.h (struct displaced_step_state): Move here from
3132         infrun.c.  Initialize fields, add constructor.
3133         <inf>: Remove field.
3134         <reset>: New method.
3135         * infrun.c (struct displaced_step_inferior_state): Move to
3136         infrun.h.
3137         (displaced_step_inferior_states): Remove.
3138         (get_displaced_stepping_state): Adust.
3139         (displaced_step_in_progress_any_inferior): Adjust.
3140         (displaced_step_in_progress_thread): Adjust.
3141         (displaced_step_in_progress): Adjust.
3142         (add_displaced_stepping_state): Remove.
3143         (get_displaced_step_closure_by_addr): Adjust.
3144         (remove_displaced_stepping_state): Remove.
3145         (infrun_inferior_exit): Call displaced_step_state.reset.
3146         (use_displaced_stepping): Don't check for NULL.
3147         (displaced_step_prepare_throw): Call
3148         get_displaced_stepping_state.
3149         (displaced_step_fixup): Don't check for NULL.
3150         (prepare_for_detach): Don't check for NULL.
3151
3152 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3153
3154         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3155          in case of call that did not complete.
3156
3157 2019-01-02  Andrey Utkin  <autkin@undo.io>
3158
3159         * symfile.c (find_separate_debug_file): Fix search of debug files for
3160         remote debuggee.
3161
3162 2019-01-02  Tom Tromey  <tom@tromey.com>
3163
3164         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3165         indentation.
3166         * python/py-frame.c (frapy_older): Remove cast.
3167         (frapy_newer): Likewise.
3168         * python/py-breakpoint.c (local_setattro): Remove cast.
3169         * python/py-arch.c (archpy_name): Remove local variable.
3170         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3171
3172 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3173
3174         * unittests/basic_string_view/element_access/char/empty.cc:
3175         Fix year range in copyright header.
3176
3177 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3178
3179         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3180         Delete.
3181         <operator==>: Update with for removed field.
3182         <hash>: Likewise.
3183         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3184         <isa_features>: ...this.
3185         <abi_features>: New field.
3186         (riscv_isa_flen): Update comment.
3187         (riscv_abi_xlen): New declaration.
3188         (riscv_abi_flen): New declaration.
3189         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3190         isa_features.
3191         (riscv_abi_xlen): New function.
3192         (riscv_isa_flen): Update to get answer from isa_features.
3193         (riscv_abi_flen): New function.
3194         (riscv_has_fp_abi): Update to get answer from abi_features.
3195         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3196         xlen and flen.
3197         (riscv_call_info) <xlen, flen>: Update comment.
3198         (riscv_call_arg_struct): Remove invalid assertions
3199         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3200         is removed.
3201         (riscv_gdbarch_init): Gather isa features and abi features
3202         separately, ensure both match on the gdbarch when reusing an old
3203         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3204         a target with 64-bit float hardware.
3205
3206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3207
3208         * source.c (search_command_helper): Stop reverse search
3209         when line 1 has been searched.
3210
3211 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3212
3213         * record-full.c (record_full_base_target::close): Rewrite
3214         record_full_core_buf_list free logic.
3215
3216 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3217
3218         * break-catch-syscall.c (print_one_catch_syscall): xfree
3219         the last text.
3220
3221 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3222
3223         * top.c (print_gdb_version): Update Copyright year in version
3224         message.
3225
3226 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3227
3228         Update copyright year range in all GDB files.
3229
3230 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3231
3232         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3233
3234 For older changes see ChangeLog-2018.
3235 \f
3236 Local Variables:
3237 mode: change-log
3238 left-margin: 8
3239 fill-column: 74
3240 version-control: never
3241 coding: utf-8
3242 End:
3243