Add push_target overload
[external/binutils.git] / gdb / ChangeLog
1 2019-02-15  Tom Tromey  <tromey@adacore.com>
2
3         * target.h (push_target): Declare new overload.
4         * target.c (push_target): New overload, taking an rvalue reference.
5         * remote.c (remote_target::open_1): Use push_target overload.
6         * corelow.c (core_target_open): Use push_target overload.
7
8 2019-02-15  Tom Tromey  <tromey@adacore.com>
9
10         * ravenscar-thread.c (is_ravenscar_task)
11         (ravenscar_task_is_currently_active): Return bool.
12         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13         (_initialize_ravenscar): Remove "(void)".
14         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15         Return bool.
16
17 2019-02-15  Tom Tromey  <tromey@adacore.com>
18
19         * ravenscar-thread.c (ravenscar_runtime_initializer)
20         (has_ravenscar_runtime, get_running_thread_id)
21         (ravenscar_thread_target::resume): Fix indentation.
22
23 2019-02-15  Tom Tromey  <tromey@adacore.com>
24
25         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
26         from ravenscar_arch_ops.
27         (sparc_ravenscar_ops::fetch_registers)
28         (sparc_ravenscar_ops::store_registers): Now methods.
29         (sparc_ravenscar_prepare_to_store): Remove.
30         (sparc_ravenscar_ops): Redefine.
31         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
32         methods and destructor.  Remove members.
33         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
34         (ravenscar_thread_target::store_registers)
35         (ravenscar_thread_target::prepare_to_store): Update.
36         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
37         Remove.
38         (struct ppc_ravenscar_powerpc_ops): Derive from
39         ravenscar_arch_ops.
40         (ppc_ravenscar_powerpc_ops::fetch_registers)
41         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
42         (ppc_ravenscar_powerpc_ops): Redefine.
43         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
44         (ppc_ravenscar_e500_ops::fetch_registers)
45         (ppc_ravenscar_e500_ops::store_registers): Now methods.
46         (ppc_ravenscar_e500_ops): Redefine.
47         * aarch64-ravenscar-thread.c
48         (aarch64_ravenscar_generic_prepare_to_store): Remove.
49         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
50         (aarch64_ravenscar_fetch_registers)
51         (aarch64_ravenscar_store_registers): Now methods.
52         (aarch64_ravenscar_ops): Redefine.
53
54 2019-02-15  Tom Tromey  <tromey@adacore.com>
55
56         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
57         (ravenscar_thread_target::stopped_by_hw_breakpoint)
58         (ravenscar_thread_target::stopped_by_watchpoint)
59         (ravenscar_thread_target::stopped_data_address)
60         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
61
62 2019-02-15  Tom Tromey  <tromey@adacore.com>
63
64         * ravenscar-thread.c: Fix some typos.
65
66 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
67             Tom Tromey  <tromey@adacore.com>
68
69         * ada-lang.c (ada_exception_sal): Change addr_string to a
70         std::string.
71         (create_ada_exception_catchpoint): Update.
72
73 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
74             Tom Tromey  <tromey@adacore.com>
75
76         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
77         (bp_location_ops): Remove.
78         (base_breakpoint_allocate_location): Update.
79         (free_bp_location): Update.
80         * ada-lang.c (class ada_catchpoint_location)
81         <ada_catchpoint_location>: Remove ops parameter.
82         (ada_catchpoint_location_dtor): Remove.
83         (ada_catchpoint_location_ops): Remove.
84         (allocate_location_exception): Update.
85         * breakpoint.h (struct bp_location_ops): Remove.
86         (class bp_location) <bp_location>: Remove bp_location_ops
87         parameter.
88         <~bp_location>: Add destructor.
89         <ops>: Remove.
90
91 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
92             Pedro Alves  <palves@redhat.com>
93
94         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
95         'PATH_MAX'.
96
97 2019-02-14  David Michael  <fedora.dm0@gmail.com>
98             Samuel Thibault  <samuel.thibault@gnu.org>
99             Thomas Schwinge  <thomas@codesourcery.com>
100
101         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
102         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
103
104 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
105
106         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
107         (check_empty): Use "const char *".
108
109         * gnu-nat.c (gnu_nat_target::detach): Instead of
110         'detach_inferior (pid)' call
111         'detach_inferior (find_inferior_pid (pid))'.
112
113         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
114         'nat/fork-inferior.o'.
115         * gnu-nat.c: #include "nat/fork-inferior.h".
116
117         * gnu-nat.c (gnu_nat_target::detach): Instead of
118         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
119         * gnu-nat.h: #include "inf-child.h".
120         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
121         'i386_gnu_nat_target::fetch_registers'.
122         (gnu_store_registers): Rename/move to
123         'i386_gnu_nat_target::store_registers'.
124
125         * config/i386/nm-i386gnu.h: Don't "#include" any files.
126         * gnu-nat.h (mach_thread_info): New function.
127         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
128
129         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
130
131 2019-02-14  Frederic Konrad  <konrad@adacore.com>
132
133         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
134
135 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
136
137         * windows-nat.c (windows_add_thread): Add new parameter
138         "main_thread_p" with default value set to false.  Update
139         function documentation as well as all callers.
140         (windows_delete_thread): Likewise.
141         (fake_create_process): Update call to windows_add_thread.
142         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
143         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
144         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
145         call to windows_delete_thread.
146
147 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
148
149         * MAINTAINERS: Add Andrew Burgess as global maintainer.
150
151 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
152
153         * symfile.c (find_separate_debug_file): Use canonical path of
154         sysroot with child_path instead of gdb_sysroot if it is valid.
155
156 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
157
158         * symfile.c (find_separate_debug_file): Use child_path to
159         determine if an object file is under a sysroot.
160
161 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
162
163         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
164         unittests/child-path-selftests.c.
165         * common/pathstuff.c (child_path): New function.
166         * common/pathstuff.h (child_path): New prototype.
167         * unittests/child-path-selftests.c: New file.
168
169 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
170
171         * symfile.c (find_separate_debug_file): Look for separate debug
172         files in debug directories under the sysroot.
173
174 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
175
176         * symtab.h (struct minimal_symbol data_p): New const method.
177         (struct minimal_symbol text_p): Likewise.
178         * symtab.c (output_source_filename): Use file name style
179         to print file name.
180         (print_symbol_info): Likewise.
181         (print_msymbol_info): Use address style to print addresses.
182         Use function name style to print executable text symbols.
183         (expand_symtab_containing_pc): Use data_p.
184         (find_pc_sect_compunit_symtab): Likewise.
185
186 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
187
188         * breakpoint.c (describe_other_breakpoints): Use address style
189         to print addresses.
190         (say_where): Likewise.
191
192 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
193
194         * ada-typeprint.c (print_func_type): Print function name
195         style to print function name.
196         * c-typeprint.c (c_print_type_1): Likewise.
197
198 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
199
200         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
201         for execve.
202
203 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
204
205         * c-exp.y (direct_abs_decl): Use emplace_back to record the
206         type_stack.
207
208 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
209
210         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
211         TYPE_CODE_REF types.
212
213 2019-02-08  Jim Wilson  <jimw@sifive.com>
214
215         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
216         (riscv_linux_fregset): New.
217         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
218
219 2019-02-07  Tom Tromey  <tom@tromey.com>
220
221         * thread.c (thread_cancel_execution_command): Update.
222         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
223         methods.
224         (struct thread_fsm_ops): Remove.
225         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
226         (thread_fsm_should_stop, thread_fsm_return_value)
227         (thread_fsm_set_finished, thread_fsm_finished_p)
228         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
229         Don't declare.
230         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
231         * infrun.c (clear_proceed_status_thread)
232         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
233         (print_stop_event): Update.
234         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
235         Add constructor.
236         (step_command_fsm_ops): Remove.
237         (new_step_command_fsm): Remove.
238         (step_1): Update.
239         (step_command_fsm::should_stop): Rename from
240         step_command_fsm_should_stop.
241         (step_command_fsm::clean_up): Rename from
242         step_command_fsm_clean_up.
243         (step_command_fsm::do_async_reply_reason): Rename from
244         step_command_fsm_async_reply_reason.
245         (struct until_next_fsm): Inherit from thread_fsm.  Add
246         constructor.
247         (until_next_fsm_ops): Remove.
248         (new_until_next_fsm): Remove.
249         (until_next_fsm::should_stop): Rename from
250         until_next_fsm_should_stop.
251         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
252         (until_next_fsm::do_async_reply_reason): Rename from
253         until_next_fsm_async_reply_reason.
254         (struct finish_command_fsm): Inherit from thread_fsm.  Add
255         constructor.  Change type of breakpoint.
256         (finish_command_fsm_ops): Remove.
257         (new_finish_command_fsm): Remove.
258         (finish_command_fsm::should_stop): Rename from
259         finish_command_fsm_should_stop.
260         (finish_command_fsm::clean_up): Rename from
261         finish_command_fsm_clean_up.
262         (finish_command_fsm::return_value): Rename from
263         finish_command_fsm_return_value.
264         (finish_command_fsm::do_async_reply_reason): Rename from
265         finish_command_fsm_async_reply_reason.
266         (finish_command): Update.
267         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
268         Add constructor.
269         (call_thread_fsm_ops): Remove.
270         (call_thread_fsm::call_thread_fsm): Rename from
271         new_call_thread_fsm.
272         (call_thread_fsm::should_stop): Rename from
273         call_thread_fsm_should_stop.
274         (call_thread_fsm::should_notify_stop): Rename from
275         call_thread_fsm_should_notify_stop.
276         (run_inferior_call, call_function_by_hand_dummy): Update.
277         * cli/cli-interp.c (should_print_stop_to_console): Update.
278         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
279         Add constructor.  Change type of location_breakpoint,
280         caller_breakpoint.
281         (until_break_fsm_ops): Remove.
282         (new_until_break_fsm): Remove.
283         (until_break_fsm::should_stop): Rename from
284         until_break_fsm_should_stop.
285         (until_break_fsm::clean_up): Rename from
286         until_break_fsm_clean_up.
287         (until_break_fsm::do_async_reply_reason): Rename from
288         until_break_fsm_async_reply_reason.
289         (until_break_command): Update.
290         * thread-fsm.c: Remove.
291         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
292
293 2019-02-07  Tom Tromey  <tom@tromey.com>
294
295         * yy-remap.h: Add include guard.
296         * xtensa-tdep.h: Add include guard.
297         * xcoffread.h: Rename include guard.
298         * varobj-iter.h: Add include guard.
299         * tui/tui.h: Rename include guard.
300         * tui/tui-winsource.h: Rename include guard.
301         * tui/tui-wingeneral.h: Rename include guard.
302         * tui/tui-windata.h: Rename include guard.
303         * tui/tui-win.h: Rename include guard.
304         * tui/tui-stack.h: Rename include guard.
305         * tui/tui-source.h: Rename include guard.
306         * tui/tui-regs.h: Rename include guard.
307         * tui/tui-out.h: Rename include guard.
308         * tui/tui-layout.h: Rename include guard.
309         * tui/tui-io.h: Rename include guard.
310         * tui/tui-hooks.h: Rename include guard.
311         * tui/tui-file.h: Rename include guard.
312         * tui/tui-disasm.h: Rename include guard.
313         * tui/tui-data.h: Rename include guard.
314         * tui/tui-command.h: Rename include guard.
315         * tic6x-tdep.h: Add include guard.
316         * target/waitstatus.h: Rename include guard.
317         * target/wait.h: Rename include guard.
318         * target/target.h: Rename include guard.
319         * target/resume.h: Rename include guard.
320         * target-float.h: Rename include guard.
321         * stabsread.h: Add include guard.
322         * rs6000-tdep.h: Add include guard.
323         * riscv-fbsd-tdep.h: Add include guard.
324         * regformats/regdef.h: Rename include guard.
325         * record.h: Rename include guard.
326         * python/python.h: Rename include guard.
327         * python/python-internal.h: Rename include guard.
328         * python/py-stopevent.h: Rename include guard.
329         * python/py-ref.h: Rename include guard.
330         * python/py-record.h: Rename include guard.
331         * python/py-record-full.h: Rename include guard.
332         * python/py-record-btrace.h: Rename include guard.
333         * python/py-instruction.h: Rename include guard.
334         * python/py-events.h: Rename include guard.
335         * python/py-event.h: Rename include guard.
336         * procfs.h: Add include guard.
337         * proc-utils.h: Add include guard.
338         * p-lang.h: Add include guard.
339         * or1k-tdep.h: Rename include guard.
340         * observable.h: Rename include guard.
341         * nto-tdep.h: Rename include guard.
342         * nat/x86-linux.h: Rename include guard.
343         * nat/x86-linux-dregs.h: Rename include guard.
344         * nat/x86-gcc-cpuid.h: Add include guard.
345         * nat/x86-dregs.h: Rename include guard.
346         * nat/x86-cpuid.h: Rename include guard.
347         * nat/ppc-linux.h: Rename include guard.
348         * nat/mips-linux-watch.h: Rename include guard.
349         * nat/linux-waitpid.h: Rename include guard.
350         * nat/linux-ptrace.h: Rename include guard.
351         * nat/linux-procfs.h: Rename include guard.
352         * nat/linux-osdata.h: Rename include guard.
353         * nat/linux-nat.h: Rename include guard.
354         * nat/linux-namespaces.h: Rename include guard.
355         * nat/linux-btrace.h: Rename include guard.
356         * nat/glibc_thread_db.h: Rename include guard.
357         * nat/gdb_thread_db.h: Rename include guard.
358         * nat/gdb_ptrace.h: Rename include guard.
359         * nat/fork-inferior.h: Rename include guard.
360         * nat/amd64-linux-siginfo.h: Rename include guard.
361         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
362         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
363         * nat/aarch64-linux.h: Rename include guard.
364         * nat/aarch64-linux-hw-point.h: Rename include guard.
365         * mn10300-tdep.h: Add include guard.
366         * mips-linux-tdep.h: Add include guard.
367         * mi/mi-parse.h: Rename include guard.
368         * mi/mi-out.h: Rename include guard.
369         * mi/mi-main.h: Rename include guard.
370         * mi/mi-interp.h: Rename include guard.
371         * mi/mi-getopt.h: Rename include guard.
372         * mi/mi-console.h: Rename include guard.
373         * mi/mi-common.h: Rename include guard.
374         * mi/mi-cmds.h: Rename include guard.
375         * mi/mi-cmd-break.h: Rename include guard.
376         * m2-lang.h: Add include guard.
377         * location.h: Rename include guard.
378         * linux-record.h: Rename include guard.
379         * linux-nat.h: Add include guard.
380         * linux-fork.h: Add include guard.
381         * i386-darwin-tdep.h: Rename include guard.
382         * hppa-linux-offsets.h: Add include guard.
383         * guile/guile.h: Rename include guard.
384         * guile/guile-internal.h: Rename include guard.
385         * gnu-nat.h: Rename include guard.
386         * gdb-stabs.h: Rename include guard.
387         * frv-tdep.h: Add include guard.
388         * f-lang.h: Add include guard.
389         * event-loop.h: Add include guard.
390         * darwin-nat.h: Rename include guard.
391         * cp-abi.h: Rename include guard.
392         * config/sparc/nm-sol2.h: Rename include guard.
393         * config/nm-nto.h: Rename include guard.
394         * config/nm-linux.h: Add include guard.
395         * config/i386/nm-i386gnu.h: Rename include guard.
396         * config/djgpp/nl_types.h: Rename include guard.
397         * config/djgpp/langinfo.h: Rename include guard.
398         * compile/gcc-cp-plugin.h: Add include guard.
399         * compile/gcc-c-plugin.h: Add include guard.
400         * compile/compile.h: Rename include guard.
401         * compile/compile-object-run.h: Rename include guard.
402         * compile/compile-object-load.h: Rename include guard.
403         * compile/compile-internal.h: Rename include guard.
404         * compile/compile-cplus.h: Rename include guard.
405         * compile/compile-c.h: Rename include guard.
406         * common/xml-utils.h: Rename include guard.
407         * common/x86-xstate.h: Rename include guard.
408         * common/version.h: Rename include guard.
409         * common/vec.h: Rename include guard.
410         * common/tdesc.h: Rename include guard.
411         * common/selftest.h: Rename include guard.
412         * common/scoped_restore.h: Rename include guard.
413         * common/scoped_mmap.h: Rename include guard.
414         * common/scoped_fd.h: Rename include guard.
415         * common/safe-iterator.h: Rename include guard.
416         * common/run-time-clock.h: Rename include guard.
417         * common/refcounted-object.h: Rename include guard.
418         * common/queue.h: Rename include guard.
419         * common/ptid.h: Rename include guard.
420         * common/print-utils.h: Rename include guard.
421         * common/preprocessor.h: Rename include guard.
422         * common/pathstuff.h: Rename include guard.
423         * common/observable.h: Rename include guard.
424         * common/netstuff.h: Rename include guard.
425         * common/job-control.h: Rename include guard.
426         * common/host-defs.h: Rename include guard.
427         * common/gdb_wait.h: Rename include guard.
428         * common/gdb_vecs.h: Rename include guard.
429         * common/gdb_unlinker.h: Rename include guard.
430         * common/gdb_unique_ptr.h: Rename include guard.
431         * common/gdb_tilde_expand.h: Rename include guard.
432         * common/gdb_sys_time.h: Rename include guard.
433         * common/gdb_string_view.h: Rename include guard.
434         * common/gdb_splay_tree.h: Rename include guard.
435         * common/gdb_setjmp.h: Rename include guard.
436         * common/gdb_ref_ptr.h: Rename include guard.
437         * common/gdb_optional.h: Rename include guard.
438         * common/gdb_locale.h: Rename include guard.
439         * common/gdb_assert.h: Rename include guard.
440         * common/filtered-iterator.h: Rename include guard.
441         * common/filestuff.h: Rename include guard.
442         * common/fileio.h: Rename include guard.
443         * common/environ.h: Rename include guard.
444         * common/common-utils.h: Rename include guard.
445         * common/common-types.h: Rename include guard.
446         * common/common-regcache.h: Rename include guard.
447         * common/common-inferior.h: Rename include guard.
448         * common/common-gdbthread.h: Rename include guard.
449         * common/common-exceptions.h: Rename include guard.
450         * common/common-defs.h: Rename include guard.
451         * common/common-debug.h: Rename include guard.
452         * common/cleanups.h: Rename include guard.
453         * common/buffer.h: Rename include guard.
454         * common/btrace-common.h: Rename include guard.
455         * common/break-common.h: Rename include guard.
456         * cli/cli-utils.h: Rename include guard.
457         * cli/cli-style.h: Rename include guard.
458         * cli/cli-setshow.h: Rename include guard.
459         * cli/cli-script.h: Rename include guard.
460         * cli/cli-interp.h: Rename include guard.
461         * cli/cli-decode.h: Rename include guard.
462         * cli/cli-cmds.h: Rename include guard.
463         * charset-list.h: Add include guard.
464         * buildsym-legacy.h: Rename include guard.
465         * bfin-tdep.h: Add include guard.
466         * ax.h: Rename include guard.
467         * arm-linux-tdep.h: Add include guard.
468         * arm-fbsd-tdep.h: Add include guard.
469         * arch/xtensa.h: Rename include guard.
470         * arch/tic6x.h: Add include guard.
471         * arch/i386.h: Add include guard.
472         * arch/arm.h: Rename include guard.
473         * arch/arm-linux.h: Rename include guard.
474         * arch/arm-get-next-pcs.h: Rename include guard.
475         * arch/amd64.h: Add include guard.
476         * arch/aarch64-insn.h: Rename include guard.
477         * arch-utils.h: Rename include guard.
478         * annotate.h: Add include guard.
479         * amd64-darwin-tdep.h: Rename include guard.
480         * aarch64-linux-tdep.h: Add include guard.
481         * aarch64-fbsd-tdep.h: Add include guard.
482         * aarch32-linux-nat.h: Add include guard.
483
484 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
485
486         * macrotab.c (macro_define_internal): New function that
487         factorizes macro_define_object_internal and macro_define_function
488         code.
489         (macro_define_object_internal): Use macro_define_internal.
490         (macro_define_function): Likewise.
491
492 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
493
494         * macrocmd.c (extract_identifier): Return
495         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
496         callers.
497
498 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
499
500         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
501
502 2019-02-05  Tom Tromey  <tom@tromey.com>
503
504         * target.c (target_stack::unpush): Move assertion earlier.
505
506 2019-01-30  Tom Tromey  <tom@tromey.com>
507
508         PR python/23615:
509         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
510         (gdbpy_parse_and_eval): Likewise.
511         * python/python-internal.h (gdbpy_allow_threads): New class.
512
513 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
514
515         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
516         (aarch64_fbsd_fpregmap): Move earlier.
517         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
518         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
519         instead of individual calls to trad_frame_set_reg_addr.
520         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
521         earlier.
522         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
523         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
524         instead of individual calls to trad_frame_set_reg_addr.
525
526 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
527
528         * CONTRIBUTE: Replace contribution list with wiki link.
529
530 2019-01-25  Tom Tromey  <tom@tromey.com>
531
532         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
533
534 2019-01-25  Tom Tromey  <tom@tromey.com>
535
536         * xtensa-linux-nat.c: Fix common/ includes.
537         * xml-support.h: Fix common/ includes.
538         * xml-support.c: Fix common/ includes.
539         * x86-linux-nat.c: Fix common/ includes.
540         * windows-nat.c: Fix common/ includes.
541         * varobj.h: Fix common/ includes.
542         * varobj.c: Fix common/ includes.
543         * value.c: Fix common/ includes.
544         * valops.c: Fix common/ includes.
545         * utils.c: Fix common/ includes.
546         * unittests/xml-utils-selftests.c: Fix common/ includes.
547         * unittests/utils-selftests.c: Fix common/ includes.
548         * unittests/unpack-selftests.c: Fix common/ includes.
549         * unittests/tracepoint-selftests.c: Fix common/ includes.
550         * unittests/style-selftests.c: Fix common/ includes.
551         * unittests/string_view-selftests.c: Fix common/ includes.
552         * unittests/scoped_restore-selftests.c: Fix common/ includes.
553         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
554         * unittests/scoped_fd-selftests.c: Fix common/ includes.
555         * unittests/rsp-low-selftests.c: Fix common/ includes.
556         * unittests/parse-connection-spec-selftests.c: Fix common/
557         includes.
558         * unittests/optional-selftests.c: Fix common/ includes.
559         * unittests/offset-type-selftests.c: Fix common/ includes.
560         * unittests/observable-selftests.c: Fix common/ includes.
561         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
562         * unittests/memrange-selftests.c: Fix common/ includes.
563         * unittests/memory-map-selftests.c: Fix common/ includes.
564         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
565         * unittests/function-view-selftests.c: Fix common/ includes.
566         * unittests/environ-selftests.c: Fix common/ includes.
567         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
568         * unittests/common-utils-selftests.c: Fix common/ includes.
569         * unittests/cli-utils-selftests.c: Fix common/ includes.
570         * unittests/array-view-selftests.c: Fix common/ includes.
571         * ui-file.c: Fix common/ includes.
572         * tui/tui-io.c: Fix common/ includes.
573         * tracepoint.h: Fix common/ includes.
574         * tracepoint.c: Fix common/ includes.
575         * tracefile-tfile.c: Fix common/ includes.
576         * top.h: Fix common/ includes.
577         * top.c: Fix common/ includes.
578         * thread.c: Fix common/ includes.
579         * target/waitstatus.h: Fix common/ includes.
580         * target/waitstatus.c: Fix common/ includes.
581         * target.h: Fix common/ includes.
582         * target.c: Fix common/ includes.
583         * target-memory.c: Fix common/ includes.
584         * target-descriptions.c: Fix common/ includes.
585         * symtab.h: Fix common/ includes.
586         * symfile.c: Fix common/ includes.
587         * stap-probe.c: Fix common/ includes.
588         * spu-linux-nat.c: Fix common/ includes.
589         * sparc-nat.c: Fix common/ includes.
590         * source.c: Fix common/ includes.
591         * solib.c: Fix common/ includes.
592         * solib-target.c: Fix common/ includes.
593         * ser-unix.c: Fix common/ includes.
594         * ser-tcp.c: Fix common/ includes.
595         * ser-pipe.c: Fix common/ includes.
596         * ser-base.c: Fix common/ includes.
597         * selftest-arch.c: Fix common/ includes.
598         * s12z-tdep.c: Fix common/ includes.
599         * rust-exp.y: Fix common/ includes.
600         * rs6000-aix-tdep.c: Fix common/ includes.
601         * riscv-tdep.c: Fix common/ includes.
602         * remote.c: Fix common/ includes.
603         * remote-notif.h: Fix common/ includes.
604         * remote-fileio.h: Fix common/ includes.
605         * remote-fileio.c: Fix common/ includes.
606         * regcache.h: Fix common/ includes.
607         * regcache.c: Fix common/ includes.
608         * record-btrace.c: Fix common/ includes.
609         * python/python.c: Fix common/ includes.
610         * python/py-type.c: Fix common/ includes.
611         * python/py-inferior.c: Fix common/ includes.
612         * progspace.h: Fix common/ includes.
613         * producer.c: Fix common/ includes.
614         * procfs.c: Fix common/ includes.
615         * proc-api.c: Fix common/ includes.
616         * printcmd.c: Fix common/ includes.
617         * ppc-linux-nat.c: Fix common/ includes.
618         * parser-defs.h: Fix common/ includes.
619         * osdata.c: Fix common/ includes.
620         * obsd-nat.c: Fix common/ includes.
621         * nat/x86-linux.c: Fix common/ includes.
622         * nat/x86-linux-dregs.c: Fix common/ includes.
623         * nat/x86-dregs.h: Fix common/ includes.
624         * nat/x86-dregs.c: Fix common/ includes.
625         * nat/ppc-linux.c: Fix common/ includes.
626         * nat/mips-linux-watch.h: Fix common/ includes.
627         * nat/mips-linux-watch.c: Fix common/ includes.
628         * nat/linux-waitpid.c: Fix common/ includes.
629         * nat/linux-ptrace.h: Fix common/ includes.
630         * nat/linux-ptrace.c: Fix common/ includes.
631         * nat/linux-procfs.c: Fix common/ includes.
632         * nat/linux-personality.c: Fix common/ includes.
633         * nat/linux-osdata.c: Fix common/ includes.
634         * nat/linux-namespaces.c: Fix common/ includes.
635         * nat/linux-btrace.h: Fix common/ includes.
636         * nat/linux-btrace.c: Fix common/ includes.
637         * nat/fork-inferior.c: Fix common/ includes.
638         * nat/amd64-linux-siginfo.c: Fix common/ includes.
639         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
640         * nat/aarch64-linux.c: Fix common/ includes.
641         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
642         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
643         * namespace.h: Fix common/ includes.
644         * mips-linux-tdep.c: Fix common/ includes.
645         * minsyms.c: Fix common/ includes.
646         * mi/mi-parse.h: Fix common/ includes.
647         * mi/mi-main.c: Fix common/ includes.
648         * mi/mi-cmd-env.c: Fix common/ includes.
649         * memrange.h: Fix common/ includes.
650         * memattr.c: Fix common/ includes.
651         * maint.h: Fix common/ includes.
652         * maint.c: Fix common/ includes.
653         * main.c: Fix common/ includes.
654         * machoread.c: Fix common/ includes.
655         * location.c: Fix common/ includes.
656         * linux-thread-db.c: Fix common/ includes.
657         * linux-nat.c: Fix common/ includes.
658         * linux-fork.c: Fix common/ includes.
659         * inline-frame.c: Fix common/ includes.
660         * infrun.c: Fix common/ includes.
661         * inflow.c: Fix common/ includes.
662         * inferior.h: Fix common/ includes.
663         * inferior.c: Fix common/ includes.
664         * infcmd.c: Fix common/ includes.
665         * inf-ptrace.c: Fix common/ includes.
666         * inf-child.c: Fix common/ includes.
667         * ia64-linux-nat.c: Fix common/ includes.
668         * i387-tdep.c: Fix common/ includes.
669         * i386-tdep.c: Fix common/ includes.
670         * i386-linux-tdep.c: Fix common/ includes.
671         * i386-linux-nat.c: Fix common/ includes.
672         * i386-go32-tdep.c: Fix common/ includes.
673         * i386-fbsd-tdep.c: Fix common/ includes.
674         * i386-fbsd-nat.c: Fix common/ includes.
675         * guile/scm-type.c: Fix common/ includes.
676         * guile/guile.c: Fix common/ includes.
677         * go32-nat.c: Fix common/ includes.
678         * gnu-nat.c: Fix common/ includes.
679         * gdbthread.h: Fix common/ includes.
680         * gdbarch-selftests.c: Fix common/ includes.
681         * gdb_usleep.c: Fix common/ includes.
682         * gdb_select.h: Fix common/ includes.
683         * gdb_bfd.c: Fix common/ includes.
684         * gcore.c: Fix common/ includes.
685         * fork-child.c: Fix common/ includes.
686         * findvar.c: Fix common/ includes.
687         * fbsd-nat.c: Fix common/ includes.
688         * event-top.c: Fix common/ includes.
689         * event-loop.c: Fix common/ includes.
690         * dwarf2read.c: Fix common/ includes.
691         * dwarf2loc.c: Fix common/ includes.
692         * dwarf2-frame.c: Fix common/ includes.
693         * dwarf-index-cache.c: Fix common/ includes.
694         * dtrace-probe.c: Fix common/ includes.
695         * disasm-selftests.c: Fix common/ includes.
696         * defs.h: Fix common/ includes.
697         * csky-tdep.c: Fix common/ includes.
698         * cp-valprint.c: Fix common/ includes.
699         * cp-support.h: Fix common/ includes.
700         * cp-support.c: Fix common/ includes.
701         * corelow.c: Fix common/ includes.
702         * completer.h: Fix common/ includes.
703         * completer.c: Fix common/ includes.
704         * compile/compile.c: Fix common/ includes.
705         * compile/compile-loc2c.c: Fix common/ includes.
706         * compile/compile-cplus-types.c: Fix common/ includes.
707         * compile/compile-cplus-symbols.c: Fix common/ includes.
708         * command.h: Fix common/ includes.
709         * cli/cli-dump.c: Fix common/ includes.
710         * cli/cli-cmds.c: Fix common/ includes.
711         * charset.c: Fix common/ includes.
712         * build-id.c: Fix common/ includes.
713         * btrace.h: Fix common/ includes.
714         * btrace.c: Fix common/ includes.
715         * breakpoint.h: Fix common/ includes.
716         * breakpoint.c: Fix common/ includes.
717         * ax.h: 
718         (enum agent_op): Fix common/ includes.
719         * ax-general.c (struct aop_map): Fix common/ includes.
720         * ax-gdb.c: Fix common/ includes.
721         * auxv.c: Fix common/ includes.
722         * auto-load.c: Fix common/ includes.
723         * arm-tdep.c: Fix common/ includes.
724         * arch/riscv.c: Fix common/ includes.
725         * arch/ppc-linux-common.c: Fix common/ includes.
726         * arch/i386.c: Fix common/ includes.
727         * arch/arm.c: Fix common/ includes.
728         * arch/arm-linux.c: Fix common/ includes.
729         * arch/arm-get-next-pcs.c: Fix common/ includes.
730         * arch/amd64.c: Fix common/ includes.
731         * arch/aarch64.c: Fix common/ includes.
732         * arch/aarch64-insn.c: Fix common/ includes.
733         * arch-utils.c: Fix common/ includes.
734         * amd64-windows-tdep.c: Fix common/ includes.
735         * amd64-tdep.c: Fix common/ includes.
736         * amd64-sol2-tdep.c: Fix common/ includes.
737         * amd64-obsd-tdep.c: Fix common/ includes.
738         * amd64-nbsd-tdep.c: Fix common/ includes.
739         * amd64-linux-tdep.c: Fix common/ includes.
740         * amd64-linux-nat.c: Fix common/ includes.
741         * amd64-fbsd-tdep.c: Fix common/ includes.
742         * amd64-fbsd-nat.c: Fix common/ includes.
743         * amd64-dicos-tdep.c: Fix common/ includes.
744         * amd64-darwin-tdep.c: Fix common/ includes.
745         * agent.c: Fix common/ includes.
746         * ada-lang.h: Fix common/ includes.
747         * ada-lang.c: Fix common/ includes.
748         * aarch64-tdep.c: Fix common/ includes.
749
750 2019-01-25  Tom Tromey  <tom@tromey.com>
751
752         * common/create-version.sh: Use common/version.h.
753
754 2019-01-24  Pedro Alves  <palves@redhat.com>
755
756         * infrun.c (signal_stop, signal_print, signal_program)
757         (signal_catch, signal_pass): Now arrays instead of pointers.
758         (update_signals_program_target, do_target_resume)
759         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
760         * linux-nat.c (linux_nat_target::pass_signals)
761         (linux_nat_target::create_inferior, linux_nat_target::attach):
762         Adjust.
763         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
764         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
765         * procfs.c (procfs_target::pass_signals): Adjust.
766         * record-full.c (record_full_target::resume): Adjust.
767         * remote.c (remote_target::pass_signals)
768         (remote_target::program_signals): Adjust.
769         * target-debug.h (target_debug_print_signals): Now takes a
770         gdb::array_view as parameter.  Adjust.
771         * target.h (target_ops) <pass_signals, program_signals>: Replace
772         pointer and length parameters with gdb::array_view.
773         (target_pass_signals, target_program_signals): Likewise.
774         * target-delegates.c: Regenerate.
775
776 2019-01-24  Pedro Alves  <palves@redhat.com>
777
778         * common/forward-scope-exit.h
779         (forward_scope_exit::forward_scope_exit): Pass arguments to
780         m_bind_function directly, instead of creating a std::bind and
781         copying that.
782
783 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
784
785         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
786         for static members.
787         (pass_in_v_vfp_candidate): Likewise.
788
789 2019-01-23  Tom Tromey  <tom@tromey.com>
790             Pedro Alves  <palves@redhat.com>
791
792         * regcache.c (class regcache_invalidator): Remove.
793         (regcache::raw_write): Use make_scope_exit.
794
795 2019-01-23  Tom Tromey  <tom@tromey.com>
796
797         * ui-out.h (class ui_out_emit_type): Update comment.
798
799 2019-01-23  Tom Tromey  <tom@tromey.com>
800
801         * infrun.c (fetch_inferior_event): Update comment.
802
803 2019-01-23  Tom Tromey  <tom@tromey.com>
804             Pedro Alves  <palves@redhat.com>
805
806         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
807         parameter.
808         (fetch_inferior_event): Use SCOPE_EXIT.
809
810
811 2019-01-23  Tom Tromey  <tom@tromey.com>
812             Pedro Alves  <palves@redhat.com>
813
814         * infrun.c (disable_thread_events): Delete.
815         (stop_all_threads): Use SCOPE_EXIT.
816
817 2019-01-23  Tom Tromey  <tom@tromey.com>
818             Pedro Alves  <palves@redhat.com>
819
820         * symfile.c: Include forward-scope-exit.h.
821         (clear_symtab_users_cleanup): Replace forward declaration with
822         a FORWARD_SCOPE_EXIT.
823         (syms_from_objfile_1): Use the forward_scope_exit and
824         gdb::optional instead of cleanup_function.
825         (reread_symbols): Use the forward_scope_exit instead of
826         cleanup_function.
827         (clear_symtab_users_cleanup): Remove function.
828
829 2019-01-23  Tom Tromey  <tom@tromey.com>
830             Pedro Alves  <palves@redhat.com>
831
832         * linux-nat.c: Include scope-exit.h.
833         (cleanup_target_stop): Remove.
834         (linux_nat_target::static_tracepoint_markers_by_strid): Use
835         SCOPE_EXIT.
836
837 2019-01-23  Tom Tromey  <tom@tromey.com>
838             Pedro Alves  <palves@redhat.com>
839
840         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
841         (call_function_by_hand_dummy): Use SCOPE_EXIT.
842
843 2019-01-23  Tom Tromey  <tom@tromey.com>
844             Andrew Burgess  <andrew.burgess@embecosm.com>
845             Pedro Alves  <palves@redhat.com>
846
847         * infrun.c (fetch_inferior_event): Use scope_exit.
848         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
849         * top.c (execute_command): Use scope_exit.
850         * breakpoint.c (bpstat_do_actions): Use scope_exit.
851         * utils.c (do_bpstat_clear_actions_cleanup)
852         (make_bpstat_clear_actions_cleanup): Remove.
853
854 2019-01-23  Tom Tromey  <tom@tromey.com>
855             Pedro Alves  <palves@redhat.com>
856
857         * infrun.c: Include "common/scope-exit.h"
858         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
859         (wait_for_inferior): Use SCOPE_EXIT.
860         (fetch_inferior_event): Use scope_exit.
861
862 2019-01-23  Tom Tromey  <tom@tromey.com>
863             Pedro Alves  <palves@redhat.com>
864
865         * breakpoint.c (create_breakpoint): Remove cleanup.
866
867 2019-01-23  Tom Tromey  <tom@tromey.com>
868             Andrew Burgess  <andrew.burgess@embecosm.com>
869             Pedro Alves  <palves@redhat.com>
870
871 2019-01-23  Pedro Alves  <palves@redhat.com>
872
873         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
874
875 2019-01-23  Pedro Alves  <palves@redhat.com>
876             Andrew Burgess  <andrew.burgess@embecosm.com>
877
878         * gdbthread.h: Include "common/forward-scope-exit.h".
879         (scoped_finish_thread_state): Redefine custom class in terms of
880         forward_scope_exit.
881
882 2019-01-23  Pedro Alves  <palves@redhat.com>
883             Andrew Burgess  <andrew.burgess@embecosm.com>
884
885         * common/forward-scope-exit.h: New file.
886
887 2019-01-23  Pedro Alves  <palves@redhat.com>
888             Andrew Burgess  <andrew.burgess@embecosm.com>
889             Tom Tromey  <tom@tromey.com>
890
891         * common/scope-exit.h: New file.
892
893 2019-01-23  Pedro Alves  <palves@redhat.com>
894
895         * common/preprocessor.h (ESC): Rename to ...
896         (ESC_PARENS): ... this.
897         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
898         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
899
900 2019-01-23  Tom Tromey  <tom@tromey.com>
901
902         * language.h (class scoped_switch_to_sym_language_if_auto):
903         Initialize m_lang in both cases.
904
905 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
906
907         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
908         with XCNEW.
909
910 2019-01-22  Tom Tromey  <tom@tromey.com>
911
912         * corelow.c: Do not include sys/file.h.
913
914 2019-01-22  Tom Tromey  <tom@tromey.com>
915
916         * tui/tui-wingeneral.h: Include gdb_curses.h.
917
918 2019-01-22  Tom Tromey  <tom@tromey.com>
919
920         * source-cache.h (class source_cache) <get_source_lines,
921         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
922
923 2019-01-22  Tom Tromey  <tom@tromey.com>
924
925         * remote-fileio.h (struct remote_target): Declare.
926
927 2019-01-22  Tom Tromey  <tom@tromey.com>
928
929         * python/py-arch.c: Do not include py-ref.h.
930         * python/py-bpevent.c: Do not include py-ref.h.
931         * python/py-cmd.c: Do not include py-ref.h.
932         * python/py-continueevent.c: Do not include py-ref.h.
933         * python/py-event.h: Do not include py-ref.h.
934         * python/py-evtregistry.c: Do not include py-ref.h.
935         * python/py-finishbreakpoint.c: Do not include py-ref.h.
936         * python/py-frame.c: Do not include py-ref.h.
937         * python/py-framefilter.c: Do not include py-ref.h.
938         * python/py-function.c: Do not include py-ref.h.
939         * python/py-infevents.c: Do not include py-ref.h.
940         * python/py-linetable.c: Do not include py-ref.h.
941         * python/py-objfile.c: Do not include py-ref.h.
942         * python/py-param.c: Do not include py-ref.h.
943         * python/py-prettyprint.c: Do not include py-ref.h.
944         * python/py-progspace.c: Do not include py-ref.h.
945         * python/py-symbol.c: Do not include py-ref.h.
946         * python/py-symtab.c: Do not include py-ref.h.
947         * python/py-type.c: Do not include py-ref.h.
948         * python/py-unwind.c: Do not include py-ref.h.
949         * python/py-utils.c: Do not include py-ref.h.
950         * python/py-value.c: Do not include py-ref.h.
951         * python/py-varobj.c: Do not include py-ref.h.
952         * python/py-xmethods.c: Do not include py-ref.h.
953         * python/python.c: Do not include py-ref.h.
954         * varobj.c: Do not include py-ref.h.
955
956 2019-01-22  Tom Tromey  <tom@tromey.com>
957
958         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
959         keyword for bcache.
960
961 2019-01-22  Tom Tromey  <tom@tromey.com>
962
963         * compile/compile-cplus-types.c: Remove a comment by #include.
964
965 2019-01-22  Tom Tromey  <tom@tromey.com>
966
967         * compile/gcc-c-plugin.h: Include compile-internal.h.
968
969 2019-01-22  Tom Tromey  <tom@tromey.com>
970
971         * stabsread.c (EXTERN): Do not define.
972         (symnum, next_symbol_text_func, processing_gcc_compilation)
973         (within_function, global_sym_chain, global_stabs)
974         (previous_stab_code, this_object_header_files)
975         (n_this_object_header_files)
976         (n_allocated_this_object_header_files): Define.
977         * stabsread.h (EXTERN): Never define.  Use "extern".
978
979 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
980
981         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
982         history_value.
983
984 2019-01-21  Tom Tromey  <tom@tromey.com>
985
986         * ui-out.c: Fix includes.
987         * tui/tui-source.c: Fix includes.
988         * target.c: Fix includes.
989         * remote.c: Fix includes.
990         * regcache.c: Fix includes.
991         * python/py-block.c: Fix includes.
992         * printcmd.c: Fix includes.
993         * or1k-tdep.c: Fix includes.
994         * mi/mi-main.c: Fix includes.
995         * m32r-tdep.c: Fix includes.
996         * csky-tdep.c: Fix includes.
997         * compile/compile-cplus-types.c: Fix includes.
998         * cli/cli-interp.c: Fix includes.
999
1000 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1003         for padding.
1004
1005 2019-01-16  Tom Tromey  <tom@tromey.com>
1006
1007         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1008         earlier.
1009         (struct objfile) <msymbols_range>: Move from top level.
1010         <msymbols>: New method.
1011         (class objfile_msymbols): Remove.
1012         * symtab.c (default_collect_symbol_completion_matches_break_on):
1013         Update.
1014         * symmisc.c (dump_msymbols): Update.
1015         * stabsread.c (scan_file_globals): Update.
1016         * objc-lang.c (info_selectors_command, info_classes_command)
1017         (find_methods): Update.
1018         * minsyms.c (find_solib_trampoline_target): Update.
1019         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1020         * coffread.c (coff_symfile_read): Update.
1021         * ada-lang.c (ada_lookup_simple_minsym)
1022         (ada_collect_symbol_completion_matches): Update.
1023
1024 2019-01-16  Tom Tromey  <tom@tromey.com>
1025
1026         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1027         type.  Remove no-argument constructor.
1028         <iterator::operator++>: Simplify.
1029         <begin>: Update.
1030         <end>: Use minimal_symbol_count.
1031
1032 2019-01-16  Tom Tromey  <tom@tromey.com>
1033
1034         * objfiles.h (struct objfile) <psymtabs>: New method.
1035         (class objfile_psymtabs): Remove.
1036         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1037         typedef.
1038         <range>: New method.
1039         (require_partial_symbols): Change return type.
1040         * psymtab.c (require_partial_symbols)
1041         (psym_expand_symtabs_matching): Update.
1042         * mdebugread.c (parse_partial_symbols): Update.
1043         * dbxread.c (dbx_end_psymtab): Update.
1044
1045 2019-01-15  Tom Tromey  <tom@tromey.com>
1046
1047         * symtab.c (lookup_objfile_from_block)
1048         (lookup_symbol_in_objfile_symtabs)
1049         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1050         (find_line_symtab, info_sources_command)
1051         (default_collect_symbol_completion_matches_break_on)
1052         (make_source_files_completion_list): Update.
1053         * symmisc.c (print_objfile_statistics, dump_objfile)
1054         (maintenance_print_symbols, maintenance_info_symtabs)
1055         (maintenance_check_symtabs, maintenance_info_line_tables):
1056         Update.
1057         * source.c (select_source_symtab)
1058         (forget_cached_source_info_for_objfile): Update.
1059         * objfiles.h (class objfile_compunits): Remove.
1060         (struct objfile) <compunits_range>: New typedef.
1061         (compunits): New method.
1062         * objfiles.c (objfile_relocate1): Update.
1063         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1064         * maint.c (count_symtabs_and_blocks): Update.
1065         * linespec.c (iterate_over_all_matching_symtabs): Update.
1066         * cp-support.c (add_symbol_overload_list_qualified): Update.
1067         * coffread.c (coff_symtab_read): Update.
1068         * ada-lang.c (add_nonlocal_symbols)
1069         (ada_collect_symbol_completion_matches)
1070         (ada_add_global_exceptions): Update.
1071
1072 2019-01-15  Tom Tromey  <tom@tromey.com>
1073
1074         * progspace.h (program_space) <objfiles_safe_range>: New
1075         typedef.
1076         <objfiles_safe>: New method.
1077         * objfiles.h (class all_objfiles_safe): Remove.
1078         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1079         * jit.c (jit_inferior_exit_hook): Update.
1080
1081 2019-01-17  Tom Tromey  <tom@tromey.com>
1082
1083         * progspace.h (program_space) <objfiles_range>: New typedef.
1084         <objfiles>: New method.
1085         <objfiles_head>: Rename from objfiles.
1086         (object_files): Update.
1087         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1088         * guile/scm-pretty-print.c
1089         (ppscm_find_pretty_printer_from_objfiles): Update.
1090         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1091         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1092         Update.
1093         * python/py-progspace.c (pspy_get_objfiles): Update.
1094         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1095         Update.
1096         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1097         (objfpy_lookup_objfile_by_build_id): Update.
1098         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1099         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1100         Update.
1101         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1102         (expand_symtab_containing_pc, lookup_objfile_from_block)
1103         (lookup_static_symbol, basic_lookup_transparent_type)
1104         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1105         (find_line_symtab, info_sources_command)
1106         (default_collect_symbol_completion_matches_break_on)
1107         (make_source_files_completion_list, find_main_name): Update.
1108         * symmisc.c (print_symbol_bcache_statistics)
1109         (print_objfile_statistics, maintenance_print_symbols)
1110         (maintenance_print_msymbols, maintenance_print_objfiles)
1111         (maintenance_info_symtabs, maintenance_check_symtabs)
1112         (maintenance_expand_symtabs, maintenance_info_line_tables):
1113         Update.
1114         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1115         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1116         (map_overlay_command, unmap_overlay_command)
1117         (simple_overlay_update, expand_symtabs_matching)
1118         (map_symbol_filenames): Update.
1119         * symfile-debug.c (set_debug_symfile): Update.
1120         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1121         Update.
1122         * source.c (select_source_symtab, forget_cached_source_info):
1123         Update.
1124         * solib.c (solib_read_symbols): Update.
1125         * solib-spu.c (append_ocl_sos): Update.
1126         * psymtab.c (maintenance_print_psymbols)
1127         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1128         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1129         * printcmd.c (info_symbol_command): Update.
1130         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1131         Update.
1132         * objfiles.h (class all_objfiles): Remove.
1133         * objfiles.c (have_partial_symbols, have_full_symbols)
1134         (have_minimal_symbols, qsort_cmp, update_section_map)
1135         (shared_objfile_contains_address_p)
1136         (default_iterate_over_objfiles_in_search_order): Update.
1137         * objc-lang.c (info_selectors_command, info_classes_command)
1138         (find_methods): Update.
1139         * minsyms.c (find_solib_trampoline_target): Update.
1140         * maint.c (maintenance_info_sections)
1141         (maintenance_translate_address, count_symtabs_and_blocks):
1142         Update.
1143         * main.c (captured_main_1): Update.
1144         * linux-thread-db.c (try_thread_db_load_from_pdir)
1145         (has_libpthread): Update.
1146         * linespec.c (iterate_over_all_matching_symtabs)
1147         (search_minsyms_for_name): Update.
1148         * jit.c (jit_find_objf_with_entry_addr): Update.
1149         * hppa-tdep.c (find_unwind_entry)
1150         (hppa_lookup_stub_minimal_symbol): Update.
1151         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1152         Update.
1153         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1154         (elf_gnu_ifunc_resolve_by_got): Update.
1155         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1156         * dwarf-index-write.c (save_gdb_index_command): Update.
1157         * cp-support.c (add_symbol_overload_list_qualified): Update.
1158         * breakpoint.c (create_overlay_event_breakpoint)
1159         (create_longjmp_master_breakpoint)
1160         (create_std_terminate_master_breakpoint)
1161         (create_exception_master_breakpoint): Update.
1162         * blockframe.c (find_pc_partial_function): Update.
1163         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1164         (ada_collect_symbol_completion_matches)
1165         (ada_add_global_exceptions): Update.
1166
1167 2019-01-17  Tom Tromey  <tom@tromey.com>
1168
1169         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1170         declare VEC.
1171         (solib_target_parse_libraries): Change return type.
1172         (library_list_start_segment, library_list_start_section)
1173         (library_list_end_library, library_list_start_library); Update.
1174         (solib_target_free_library_list): Remove.
1175         (solib_target_parse_libraries): Remove cleanup.  Change return
1176         type.
1177         (solib_target_current_sos): Update.
1178
1179 2019-01-17  Tom Tromey  <tromey@bapiya>
1180
1181         * valprint.c: Replace "the the" with "the".
1182         * symtab.c: Replace "the the" with "the".
1183         * solib.c: Replace "the the" with "the".
1184         * solib-dsbt.c: Replace "the the" with "the".
1185         * linespec.c: Replace "the the" with "the".
1186         * dwarf2loc.h: Replace "the the" with "the".
1187         * amd64-windows-tdep.c: Replace "the the" with "the".
1188         * aarch64-tdep.c: Replace "the the" with "the".
1189
1190 2019-01-16  Keith Seitz  <keiths@redhat.com>
1191
1192         PR gdb/23773
1193         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1194         <builder>: Rename to ..
1195         <m_builder>: ... this and make private.
1196         (dwarf2_cu::get_builder): New method.  Change all users of
1197         `builder' to use this method.
1198         (dwarf2_start_symtab): Move to ...
1199         (dwarf2_cu::start_symtab): ... here.  Update all callers
1200         (setup_type_unit_groups): Move to ...
1201         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1202         callers.
1203         (dwarf2_cu::reset_builder): New method.
1204         (process_full_compunit, process_full_type_unit): Use
1205         dwarf2_cu::reset_builder.
1206         (follow_die_offset): Record the ancestor CU if it is different
1207         from the followed DIE's CU.
1208         (follow_die_sig_1): Likewise.
1209
1210 2019-01-15  Tom Tromey  <tom@tromey.com>
1211
1212         * remote.c (class remote_state) <buf>: Now a char_vector.
1213         <buf_size>: Remove.
1214         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1215         parameter.
1216         (remote_target::getpkt_or_notif_sane_1)
1217         (remote_target::getpkt_sane)
1218         (remote_target::getpkt_or_notif_sane): Likewise.
1219         (class remote_target) <putpkt>: New overload.
1220         (remote_target::read_frame): Change type of "buf_p".  Remove
1221         sizeof_p parameter.
1222         (packet_ok): New overload.
1223         (packet_check_result): New overload.
1224         Update all uses.
1225
1226 2019-01-14  Tom Tromey  <tom@tromey.com>
1227
1228         * remote-notif.c (handle_notification, remote_notif_ack)
1229         (remote_notif_parse): Make "buf" const.
1230         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1231         const.
1232         (remote_notif_parse, remote_notif_ack, handle_notification):
1233         Likewise.
1234         * remote.c (remote_notif_stop_parse): Make "buf" const.
1235         (remote_target::remote_parse_stop_reply): Make "buf" const.
1236         (remote_notif_stop_ack): Make "buf" const.
1237
1238 2019-01-14  Tom Tromey  <tom@tromey.com>
1239
1240         * remote.c (remote_console_output): Make parameter const.
1241
1242 2019-01-14  Tom Tromey  <tom@tromey.com>
1243
1244         * target-debug.h (target_debug_print_signals): Constify.
1245         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1246         * procfs.c (procfs_target::pass_signals): Update.
1247         * linux-nat.c (linux_nat_target::pass_signals): Update.
1248         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1249         * target-delegates.c: Rebuild.
1250         * remote.c (remote_target::program_signals): Update.
1251         (remote_target::pass_signals): Update.
1252         * target.c (target_pass_signals): Constify argument.
1253         (target_program_signals): Likewise.
1254         * target.h (struct target_ops) <pass_signals, program_signals>:
1255         Constify argument.
1256         (target_pass_signals, target_program_signals): Constify argument.
1257
1258 2019-01-14  Tom Tromey  <tom@tromey.com>
1259
1260         PR tui/28819:
1261         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1262
1263 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1264
1265         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1266         field.
1267         * rs6000-tdep.c: Include reggroups.h.
1268         (IS_V_ALIAS_PSEUDOREG): Define.
1269         (rs6000_register_name): Return names for the "vX" aliases.
1270         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1271         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1272         aliases.  Call default_register_reggroup_p for all other
1273         pseudo-registers.
1274         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1275         New functions.
1276         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1277         Handle "vX" aliases.
1278         (v_alias_pseudo_register_collect): New function.
1279         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1280         (rs6000_gdbarch_init): Initialize "vX" aliases as
1281         pseudo-registers.  Restore registration of
1282         rs6000_pseudo_register_reggroup_p with
1283         set_tdesc_pseudo_register_reggroup_p.
1284
1285 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1286
1287         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1288         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1289         set_gdbarch_num_pseudo_regs.
1290
1291 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1292
1293         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1294         Remove arg prefixname, add do_set and do_show.
1295         Add member functions set_list and show_list.
1296         * cli/cli-style.c (class cli_style_option): Update accordingly.
1297         (style_set_list): Move to file scope.
1298         (style_show_list): Likewise.
1299         (set_style): Call help_list.
1300         (show_style): Call cmd_show_list.
1301         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1302         Update to use the new macro.
1303
1304 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1305
1306         * ada-lang.c (_initialize_ada_language): Expand the help text
1307         for the "catch exception" command.
1308
1309 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1310
1311         * symtab.c (matching_obj_sections): Initialize obj,
1312         declare it closer to its usage.
1313
1314 2019-01-10  Tom Tromey  <tom@tromey.com>
1315
1316         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1317         (basic_inf_threads_range): Remove.
1318         (inf_threads_range, inf_non_exited_threads_range)
1319         (safe_inf_threads_range): Use next_adapter.
1320
1321 2019-01-10  Keith Seitz  <keiths@redhat.com>
1322
1323         PR gdb/23712
1324         PR symtab/23010
1325         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1326         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1327
1328 2019-01-10  Keith Seitz  <keiths@redhat.com>
1329
1330         PR gdb/23712
1331         PR symtab/23010
1332         * dictionary.c (pending_to_vector): Remove.
1333         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1334         Remove _1 suffix, replacing functions of the same name.  Update
1335         all callers.
1336         (dict_create_hashed, dict_create_hashed_expandable)
1337         (dict_create_linear, dict_create_linear_expandable, dict_free)
1338         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1339         Make functions static.
1340
1341 2019-01-10  Keith Seitz  <keiths@redhat.com>
1342
1343         PR gdb/23712
1344         PR symtab/23010
1345         * dictionary.h (struct dictionary): Replace declaration with
1346         multidictionary.
1347         (dict_create_hashed, dict_create_hashed_expandable)
1348         (dict_create_linear, dict_create_linear_expandable)
1349         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1350         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1351         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1352         taking multidictionary argument.
1353         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1354         * block.h (struct block) <dict>: Change to multidictionary
1355         and rename `multidict'.
1356         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1357         symmisc.c: Update all dictionary references to multidictionary.
1358
1359 2019-01-10  Keith Seitz  <keiths@redhat.com>
1360
1361         PR gdb/23712
1362         PR symtab/23010
1363         * dictionary.c: Include unordered_map.
1364         (pending_to_vector): New function.
1365         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1366         Rewrite the non-"_1" functions to take vector instead
1367         of linked list.
1368         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1369         "new" _1 versions of the same name.
1370         (multidictionary): Define.
1371         (std::hash<enum language): New definition.
1372         (collate_pending_symbols_by_language, mdict_create_hashed)
1373         (mdict_create_hashed_expandable, mdict_create_linear)
1374         (mdict_create_linear_expandable, mdict_free)
1375         (find_language_dictionary, create_new_language_dictionary)
1376         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1377         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1378         (mdict_size, mdict_empty): New functions.
1379         * dictionary.h (mdict_iterator): Define.
1380
1381 2019-01-10  Pedro Alves  <palves@redhat.com>
1382
1383         * breakpoint.c (read_uploaded_action)
1384         (create_tracepoint_from_upload): Adjust to use
1385         gdb::unique_xmalloc_ptr.
1386         * ctf.c (ctf_write_uploaded_tp):
1387         (SET_ARRAY_FIELD): Use emplace_back.
1388         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1389         * tracefile-tfile.c (tfile_write_uploaded_tp):
1390         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1391         gdb::unique_xmalloc_ptr.
1392         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1393         at_string, cond_string, cmd_strings>: Replace char pointers
1394         with gdb::unique_xmalloc_ptr.
1395
1396 2019-01-10  Pedro Alves  <palves@redhat.com>
1397
1398         * solib-target.c (library_list_start_library): Don't xstrdup name.
1399
1400 2019-01-10  Pedro Alves  <palves@redhat.com>
1401
1402         * mdebugread.c (parse_partial_symbols): Use
1403         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1404
1405 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * linux-fork.c (scoped_switch_fork_info)
1408         <~scoped_switch_fork_info>: Fix incorrect variable name.
1409
1410 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * linux-fork.c (scoped_switch_fork_info)
1413         <scoped_switch_fork_info>: Make explicit.
1414         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1415
1416 2019-01-10  Tom Tromey  <tom@tromey.com>
1417
1418         * objfiles.h (objfile::reset_psymtabs): Update.
1419         * objfiles.c (objfile::objfile): Update.
1420         * psymtab.h (psymtab_storage::obstack): Update.
1421         (psymtab_storage::m_obstack): Use gdb::optional.
1422         (class psymtab_storage): Update comment.  Remove objfile
1423         parameter.
1424         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1425
1426 2019-01-10  Tom Tromey  <tom@tromey.com>
1427
1428         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1429         <free_psymtabs>: Now private.
1430         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1431         (allocate_psymtab): Use new method.
1432
1433 2019-01-10  Tom Tromey  <tom@tromey.com>
1434
1435         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1436         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1437         * mdebugread.c (parse_partial_symbols): Use
1438         allocate_dependencies.
1439         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1440         allocate_dependencies.
1441         (process_psymtab_comp_unit_reader)
1442         (build_type_psymtab_dependencies): Likewise.
1443         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1444
1445 2019-01-10  Tom Tromey  <tom@tromey.com>
1446
1447         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1448         PSYMBOL_SET_LANGUAGE.
1449         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1450
1451 2019-01-10  Tom Tromey  <tom@tromey.com>
1452
1453         * psymtab.h (psymtab_storage::obstack): New method.
1454         <m_obstack>: Rename from obstack; now private.
1455         * psymtab.c (psymtab_storage): Update.
1456         * dwarf2read.c (create_addrmap_from_index)
1457         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1458         Update.
1459
1460 2019-01-10  Tom Tromey  <tom@tromey.com>
1461
1462         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1463         * objfiles.h (objfile::reset_psymtabs): New method.
1464
1465 2019-01-10  Tom Tromey  <tom@tromey.com>
1466
1467         * symmisc.c (print_symbol_bcache_statistics): Update.
1468         (print_objfile_statistics): Update.
1469         * symfile.c (reread_symbols): Update.
1470         * psymtab.h (class psymtab_storage): New.
1471         * psymtab.c (psymtab_storage): New constructor.
1472         (~psymtab_storage): New destructor.
1473         (require_partial_symbols): Update.
1474         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1475         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1476         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1477         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1478         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1479         (start_psymtab_common, end_psymtab_common)
1480         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1481         (allocate_psymtab): Update.
1482         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1483         Update.
1484         (dump_psymtab_addrmap, maintenance_print_psymbols)
1485         (maintenance_check_psymtabs): Update.
1486         (class objfile_psymtabs): Move to objfiles.h.
1487         * psympriv.h (discard_psymtab): Now inline.
1488         (psymtab_discarder::psymtab_discarder): Update.
1489         (psymtab_discarder::~psymtab_discarder): Update.
1490         (ALL_OBJFILE_PSYMTABS): Rewrite.
1491         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1492         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1493         Remove fields.
1494         <partial_symtabs>: New field.
1495         (class objfile_psymtabs): Move from psymtab.h.  Update.
1496         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1497         psymbol_cache.
1498         (objfile::~objfile): Don't destroy psymbol_cache.
1499         * mdebugread.c (parse_partial_symbols): Update.
1500         * dwarf2read.c (create_addrmap_from_index)
1501         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1502         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1503         (add_partial_subprogram, dwarf2_ranges_read): Update.
1504         * dwarf-index-write.c (write_address_map)
1505         (write_one_signatured_type, recursively_write_psymbols)
1506         (class debug_names, class debug_names, write_psymtabs_to_index):
1507         Update.
1508
1509 2019-01-10  Tom Tromey  <tom@tromey.com>
1510
1511         * symtab.h (SYMBOL_SET_NAMES): Update.
1512         (symbol_set_names): Update.
1513         (MSYMBOL_SET_NAMES): Update.
1514         * symtab.c (symbol_set_names): Change argument to be an
1515         objfile_per_bfd_storage.
1516         * psymtab.c (add_psymbol_to_bcache): Update.
1517         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1518
1519 2019-01-10  Tom Tromey  <tom@tromey.com>
1520
1521         * symtab.c (create_demangled_names_hash): Change argument to be an
1522         objfile_per_bfd_storage.
1523         (symbol_set_names): Update.
1524
1525 2019-01-10  Tom Tromey  <tom@tromey.com>
1526
1527         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1528         init_psymbol_list.
1529         * psymtab.c (init_psymbol_list): Do nothing if already called.
1530         * psympriv.h (init_psymbol_list): Add comment.
1531         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1532         init_psymbol_list.
1533         * dbxread.c (dbx_symfile_read): Unconditionally call
1534         init_psymbol_list.
1535
1536 2019-01-10  Tom Tromey  <tom@tromey.com>
1537
1538         * xcoffread.c (scan_xcoff_symtab): Update.
1539         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1540         "where".
1541         * mdebugread.c (parse_partial_symbols)
1542         (handle_psymbol_enumerators): Update.
1543         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1544         * dbxread.c (read_dbx_symtab): Update.
1545         * psympriv.h (psymbol_placement): New enum.
1546         (add_psymbol_to_list): Update.
1547
1548 2019-01-10  Tom Tromey  <tom@tromey.com>
1549
1550         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1551         static_psymbols parameters.
1552         (scan_xcoff_symtab): Update.
1553         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1554         static_psymbols parameters.
1555         * psympriv.h (start_psymtab_common): Update.
1556         * mdebugread.c (parse_partial_symbols): Update.
1557         * dwarf2read.c (create_partial_symtab): Update.
1558         * dbxread.c (read_dbx_symtab): Update.
1559         (start_psymtab): Remove global_psymbols and static_psymbols
1560         parameters.
1561
1562 2019-01-10  Tom Tromey  <tom@tromey.com>
1563
1564         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1565         * psymtab.c (allocate_psymtab): Add comment.
1566         * psympriv.h (allocate_psymtab): Add comment.
1567         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1568         initializations.
1569         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1570
1571 2019-01-10  Tom Tromey  <tom@tromey.com>
1572
1573         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1574         Don't declare.
1575         * mipsread.c: Include mdebugread.h.
1576         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1577         Declare.
1578         * elfread.c: Include mdebugread.h.
1579
1580 2019-01-09  Tom Tromey  <tom@tromey.com>
1581
1582         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1583         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1584         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1585         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1586         (psym_lookup_symbol, psym_find_last_source_symtab)
1587         (psym_forget_cached_source_info, psym_print_stats)
1588         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1589         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1590         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1591         (psym_find_compunit_symtab_by_address)
1592         (maintenance_print_psymbols, maintenance_info_psymtabs)
1593         (maintenance_check_psymtabs): Use ranged for.
1594         * psymtab.h (class objfile_psymtabs): New.
1595         (require_partial_symbols): Return objfile_psymtabs.
1596         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1597
1598 2019-01-09  Tom Tromey  <tom@tromey.com>
1599
1600         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1601         (find_pc_mapped_section, list_overlays_command)
1602         (map_overlay_command, unmap_overlay_command)
1603         (simple_overlay_update): Use all_objfiles.
1604         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1605         * printcmd.c (info_symbol_command): Use all_objfiles.
1606         * objfiles.h (ALL_OBJSECTIONS): Remove.
1607         * maint.c (maintenance_translate_address): Use all_objfiles.
1608         * gcore.c (gcore_create_callback): Use all_objfiles.
1609         (objfile_find_memory_regions): Likewise.
1610
1611 2019-01-09  Tom Tromey  <tom@tromey.com>
1612
1613         * symtab.c (find_line_symtab, info_sources_command)
1614         (make_source_files_completion_list): Use objfile_compunits.
1615         * source.c (select_source_symtab): Use objfile_compunits.
1616         * objfiles.h (struct objfile): Update comment.
1617         (ALL_OBJFILES): Remove.
1618         (ALL_FILETABS): Remove.
1619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1620         objfile_compunits.
1621
1622 2019-01-09  Tom Tromey  <tom@tromey.com>
1623
1624         * symmisc.c (print_objfile_statistics, dump_objfile)
1625         (maintenance_print_symbols): Use compunit_filetabs.
1626         * source.c (forget_cached_source_info_for_objfile): Use
1627         compunit_filetabs.
1628         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1629         (ALL_FILETABS): Use compunit_filetabs.
1630         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1631         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1632
1633 2019-01-09  Tom Tromey  <tom@tromey.com>
1634
1635         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1636         (compunit_filetabs): New.
1637         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1638         compunit_filetabs.
1639         (info_sources_command, make_source_files_completion_list): Remove
1640         declaration.
1641         * symmisc.c (print_objfile_statistics, dump_objfile)
1642         (maintenance_print_symbols): Remove declaration.
1643         (maintenance_info_symtabs): Use compunit_filetabs.
1644         (maintenance_info_line_tables): Likewise.
1645         * source.c (select_source_symtab): Change local variable name.
1646         (forget_cached_source_info_for_objfile): Remove declaration.
1647         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1648         * objfiles.c (objfile_relocate1): Remove declaration.
1649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1650         declaration.
1651         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1652         * coffread.c (coff_symtab_read): Remove declaration.
1653         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1654         compunit_filetabs.
1655
1656 2019-01-09  Tom Tromey  <tom@tromey.com>
1657
1658         * symtab.c (lookup_objfile_from_block)
1659         (find_pc_sect_compunit_symtab, search_symbols)
1660         (default_collect_symbol_completion_matches_break_on): Use
1661         objfile_compunits.
1662         * objfiles.h (ALL_COMPUNITS): Remove.
1663         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1664         * cp-support.c (add_symbol_overload_list_qualified): Use
1665         objfile_compunits.
1666         * ada-lang.c (ada_collect_symbol_completion_matches)
1667         (ada_add_global_exceptions): Use objfile_compunits.
1668
1669 2019-01-09  Tom Tromey  <tom@tromey.com>
1670
1671         * source.c (select_source_symtab)
1672         (forget_cached_source_info_for_objfile): Remove declaration.
1673         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1674         declaration.
1675         * maint.c (count_symtabs_and_blocks): Remove declaration.
1676         * cp-support.c (add_symbol_overload_list_qualified): Remove
1677         declaration.
1678         * coffread.c (coff_symtab_read): Remove declaration.
1679         * symtab.c (lookup_symbol_in_objfile_symtabs)
1680         (basic_lookup_transparent_type_1): Use objfile_compunits.
1681         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1682         (info_sources_command, search_symbols)
1683         (default_collect_symbol_completion_matches_break_on)
1684         (make_source_files_completion_list): Remove declaration.
1685         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1686         (ada_collect_symbol_completion_matches)
1687         (ada_add_global_exceptions): Remove declaration.
1688         * linespec.c (iterate_over_all_matching_symtabs): Use
1689         objfile_compunits.
1690         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1691         (class objfile_compunits): New.
1692         (ALL_COMPUNITS): Use objfile_compunits.
1693         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1694         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1695         objfile_compunits.
1696         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1697
1698 2019-01-09  Tom Tromey  <tom@tromey.com>
1699
1700         * symtab.c (search_symbols)
1701         (default_collect_symbol_completion_matches_break_on): Use
1702         objfile_msymbols.
1703         * ada-lang.c (ada_lookup_simple_minsym)
1704         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1705         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1706         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1707         objfile_msymbols.
1708         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1709         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1710         * objc-lang.c (find_methods): Use objfile_msymbols.
1711         (info_selectors_command, info_classes_command): Likewise.
1712         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1713         * objfiles.h (class objfile_msymbols): New.
1714         (ALL_OBJFILE_MSYMBOLS): Remove.
1715         (ALL_MSYMBOLS): Remove.
1716
1717 2019-01-09  Tom Tromey  <tom@tromey.com>
1718
1719         * common/next-iterator.h (next_adapter): Add Iterator template
1720         parameter.
1721         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1722         (class all_objfiles_safe): New.
1723         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1724         * objfiles.c (put_objfile_before): Update comment.
1725         (add_separate_debug_objfile): Likewise.
1726         (free_all_objfiles): Use all_objfiles_safe.
1727         (objfile_purge_solibs): Likewise.
1728
1729 2019-01-09  Tom Tromey  <tom@tromey.com>
1730
1731         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1732         (expand_symtab_containing_pc, lookup_static_symbol)
1733         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1734         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1735         all_objfiles.
1736         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1737         * breakpoint.c (create_overlay_event_breakpoint)
1738         (create_longjmp_master_breakpoint)
1739         (create_std_terminate_master_breakpoint)
1740         (create_exception_master_breakpoint): Use all_objfiles.
1741         * linux-thread-db.c (try_thread_db_load_from_pdir)
1742         (has_libpthread): Use all_objfiles.
1743         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1744         * linespec.c (iterate_over_all_matching_symtabs)
1745         (search_minsyms_for_name): Use all_objfiles.
1746         * maint.c (maintenance_info_sections): Use all_objfiles.
1747         * main.c (captured_main_1): Use all_objfiles.
1748         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1749         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1750         * guile/scm-pretty-print.c
1751         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1752         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1753         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1754         (maintenance_print_msymbols): Use all_objfiles.
1755         * source.c (select_source_symtab): Use all_objfiles.
1756         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1757         * symfile.c (remove_symbol_file_command)
1758         (expand_symtabs_matching, map_symbol_filenames): Use
1759         all_objfiles.
1760         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1761         all_objfiles.
1762         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1763         * objc-lang.c (find_methods): Use all_objfiles.
1764         * objfiles.c (have_partial_symbols, have_full_symbols)
1765         (have_minimal_symbols, qsort_cmp)
1766         (default_iterate_over_objfiles_in_search_order): Use
1767         all_objfiles.
1768         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1769         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1770         (maintenance_check_psymtabs): Use all_objfiles.
1771         (ALL_PSYMTABS): Remove.
1772         * compile/compile-object-run.c (do_module_cleanup): Use
1773         all_objfiles.
1774         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1775         * cp-support.c (add_symbol_overload_list_qualified): Use
1776         all_objfiles.
1777         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1778         Use all_objfiles.
1779         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1780         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1781         all_objfiles.
1782         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1783         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1784         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1785         Uses all_objfiles.
1786         * solib.c (solib_read_symbols): Use all_objfiles
1787
1788 2019-01-09  Tom Tromey  <tom@tromey.com>
1789
1790         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1791         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1792         all_objfiles.
1793         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1794         * symmisc.c (print_symbol_bcache_statistics)
1795         (print_objfile_statistics, maintenance_print_objfiles)
1796         (maintenance_info_symtabs, maintenance_check_symtabs)
1797         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1798         all_objfiles.
1799         * source.c (forget_cached_source_info): Use all_objfiles.
1800         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1801         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1802         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1803         * objfiles.c (update_section_map): Use all_objfiles.
1804         (shared_objfile_contains_address_p): Likewise.
1805         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1806         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1807
1808 2019-01-09  Tom Tromey  <tom@tromey.com>
1809
1810         * common/next-iterator.h: New file.
1811         * objfiles.h (class all_objfiles): New.
1812         (struct objfile_iterator): New.
1813
1814 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1815
1816         * NEWS: Move the description of the changed "frame", "select-frame",
1817          and "info frame" commands to the Changed commands section.
1818
1819 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1820
1821         * gdbtypes.c (check_stub_method_group): Remove handling of old
1822         mangling schemes.
1823         * linespec.c (find_methods): Likewise.
1824         * stabsread.c (read_member_functions): Likewise.
1825         * valops.c (search_struct_method): Likewise.
1826         (value_struct_elt_for_reference): Likewise.
1827         * NEWS: Mention this change.
1828
1829 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1832         print_source_lines.
1833         * source.c (print_source_lines_base): Update line number check.
1834         (print_source_lines): New function.
1835         (source_lines_range::source_lines_range): New function.
1836         * source.h (class source_lines_range): New class.
1837         (print_source_lines): New declaration.
1838
1839 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1840
1841         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1842
1843 2019-01-08  Tom Tromey  <tom@tromey.com>
1844             Simon Marchi  <simon.marchi@ericsson.com>
1845
1846         PR gdb/24060
1847         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1848         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1849         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1850         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1851         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1852         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1853
1854 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * source.c (select_source_symtab): Move header comment to
1857         declaration in source.h.
1858         (forget_cached_source_info_for_objfile): Likewise.
1859         (forget_cached_source_info): Likewise.
1860         (identify_source_line): Likewise.
1861         * source.h (identify_source_line): Move declaration from symtab.h
1862         and add comment from source.c
1863         (print_source_lines): Likewise.
1864         (forget_cached_source_info_for_objfile): Likewise.
1865         (forget_cached_source_info): Likewise.
1866         (select_source_symtab): Likewise.
1867         (enum print_source_lines_flag): Move definition from symtab.h.
1868         * symtab.h (identify_source_line): Move declaration to source.h.
1869         (print_source_lines): Likewise.
1870         (forget_cached_source_info_for_objfile): Likewise.
1871         (forget_cached_source_info): Likewise.
1872         (select_source_symtab): Likewise.
1873         (enum print_source_lines_flag): Move definition to source.h.
1874         * tui/tui-hooks.c: Add 'source.h' include.
1875
1876 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * source.c (print_source_lines_base): Handle requests to print
1879         reverse line number sequences, and guard against empty lines
1880         string.
1881
1882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * source.c (print_source_lines_base): Fix skip of '\r' if next
1885         character is '\n'.
1886
1887 2019-01-06  Tom Tromey  <tom@tromey.com>
1888
1889         * c-exp.y (struct c_parse_state) <macro_original_text,
1890         expansion_obstack>: New member.
1891         (macro_original_text, expansion_obstack): Remove globals.
1892         (scan_macro_expansion, scanning_macro_expansion)
1893         (finished_macro_expansion): Update.
1894         (scan_macro_cleanup): Remove.
1895         (yylex, c_parse): Update.
1896
1897 2019-01-06  Tom Tromey  <tom@tromey.com>
1898
1899         * c-exp.y (struct c_parse_state) <strings>: New member.
1900         (operator_stoken): Update.
1901
1902 2019-01-06  Tom Tromey  <tom@tromey.com>
1903
1904         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1905         (union type_stack_elt) <typelist_val>: Now a pointer to
1906         std::vector.
1907         (type_stack_cleanup): Don't declare.
1908         (push_typelist): Update.
1909         * parse.c (pop_typelist): Return a std::vector.
1910         (push_typelist): Take a std::vector.
1911         (follow_types): Update.  Do not free args.
1912         (type_stack_cleanup): Remove.
1913         * c-exp.y (struct c_parse_state): New.
1914         (cpstate): New global.
1915         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1916         (nonempty_typelist): Update.
1917         (func_mod): Create a new vector.
1918         (c_parse): Create a c_parse_state.
1919         (check_parameter_typelist): Do not delete params.
1920         (function_method): Update.  Do not delete type_list.
1921
1922 2019-01-06  Tom Tromey  <tom@tromey.com>
1923
1924         PR gdb/28155:
1925         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1926         check_typedef.
1927         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1928         (print_return_value): Likewise.
1929
1930 2019-01-05  Tom Tromey  <tom@tromey.com>
1931
1932         * contrib/cleanup_check.py: Remove.
1933         * contrib/gcc-with-excheck: Remove.
1934         * contrib/exsummary.py: Remove.
1935         * contrib/excheck.py: Remove.
1936
1937 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1938
1939         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1940         NULL. Initialize tpprev to NULL instead of assigning it
1941         to NULL on the next statement.
1942         * windows-nat.c (windows_delete_thread): Remove check for
1943         main_thread_id before printing thread exit notifications.
1944         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1945         Remove thread ID check against main_thread_id.
1946         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1947         windows_delete_thread.
1948         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1949
1950 2019-01-04  Tom Tromey  <tom@tromey.com>
1951
1952         * compile/compile.c (_initialize_compile): Use upper case for
1953         metasyntactic variables.
1954         * symmisc.c (_initialize_symmisc): Use upper case for
1955         metasyntactic variables.
1956         * psymtab.c (_initialize_psymtab): Use upper case for
1957         metasyntactic variables.
1958         * demangle.c (demangle_command): Use upper case for metasyntactic
1959         variables.
1960         (_initialize_demangler): Likewise.
1961         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1962         variables.
1963
1964 2019-01-03  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1967
1968 2019-01-03  Tom Tromey  <tom@tromey.com>
1969
1970         * python/py-symtab.c (salpy_str): Update.
1971         (struct salpy_sal_object) <symtab>: Now a PyObject.
1972         (salpy_dealloc): Update.
1973         (del_objfile_sal): Use gdbpy_ref.
1974
1975 2019-01-03  Tom Tromey  <tom@tromey.com>
1976
1977         * python/py-type.c (convert_field): Use new_reference.  Return
1978         gdbpy_ref.
1979         (make_fielditem): Return gdbpy_ref.
1980         (typy_fields): Update.
1981         (typy_getitem): Update.
1982         (field_name): Return gdbpy_ref.  Use new_reference.
1983         (typy_iterator_iternext): Update.
1984
1985 2019-01-03  Tom Tromey  <tom@tromey.com>
1986
1987         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1988
1989 2019-01-03  Tom Tromey  <tom@tromey.com>
1990
1991         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1992         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1993         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1994         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1995         (pspy_set_type_printers): Likewise.
1996         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1997         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1998         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1999         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2000         (objfpy_set_type_printers): Likewise.
2001
2002 2019-01-03  Tom Tromey  <tom@tromey.com>
2003
2004         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2005         (gdbpy_print_stack): Use gdbpy_err_fetch.
2006         * python/python-internal.h (class gdbpy_err_fetch): New class.
2007         (class gdbpy_enter) <m_error_type, m_error_value,
2008         m_error_traceback>: Remove.
2009         <m_error>: New member.
2010         (gdbpy_exception_to_string): Don't declare.
2011         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2012         * python/py-value.c (convert_value_from_python): Use
2013         gdbpy_err_fetch.
2014         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2015         gdbpy_exception_to_string.
2016         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2017         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2018         gdbpy_err_fetch.
2019
2020 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2021
2022         * linux-nat.c (delete_lwp_cleanup): Delete.
2023         (struct lwp_deleter): New struct.
2024         (lwp_info_up): New typedef.
2025         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2026         lwp_info_up.
2027
2028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * linux-fork.c (class scoped_switch_fork_info): New class.
2031         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2032
2033 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * valops.c (find_overload_match): Remove use of null_cleanup, and
2036         calls to do_cleanups.
2037
2038 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2039
2040         * compile/compile-cplus-types.c
2041         (compile_cplus_instance::decl_name): Handle changes to
2042         cp_func_name.
2043         * cp-support.c (cp_func_name): Update header comment, update
2044         return type.
2045         * cp-support.h (cp_func_name): Update return type in declaration.
2046         * valops.c (find_overload_match): Move temp_func local to top
2047         level of function and change its type.  Use temp_func to hold and
2048         delete temporary string obtained from cp_func_name.
2049
2050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2053         gdb::char_vector, remove cleanup, and update uses of `msg`.
2054
2055 2019-01-03  Jim Wilson  <jimw@sifive.com>
2056
2057         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2058
2059 2019-01-02  Tom Tromey  <tom@tromey.com>
2060
2061         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2062         (tdesc_parse_xml): Remove cleanups.
2063         * target-descriptions.h (make_cleanup_free_target_description):
2064         Don't declare.
2065         (target_desc_deleter): New struct.
2066         (target_desc_up): New typedef.
2067         * target-descriptions.c (target_desc_deleter::operator()): Rename
2068         from free_target_description.
2069         (make_cleanup_free_target_description): Remove.
2070
2071 2019-01-02  Tom Tromey  <tom@tromey.com>
2072
2073         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2074         constructor, destructor.
2075         (linespec_parser): Remove typedef.
2076         (~linespec_parser): Rename from linespec_parser_delete.
2077         (linespec_lex_to_end, linespec_complete_label)
2078         (linespec_complete): Update.
2079         (decode_line_full): Remove cleanups.
2080         (decode_line_1): Update.
2081
2082 2019-01-02  Tom Tromey  <tom@tromey.com>
2083
2084         * python/python-internal.h (inferior_to_inferior_object): Change
2085         return type.
2086         * python/py-exitedevent.c (create_exited_event_object): Update.
2087         * python/py-inferior.c (inferior_to_inferior_object): Return
2088         gdbpy_ref.
2089         (python_new_inferior, python_inferior_deleted)
2090         (thread_to_thread_object, delete_thread_object)
2091         (build_inferior_list, gdbpy_selected_inferior): Update.
2092         * python/py-infthread.c (create_thread_object): Update.  Also fail
2093         if inferior_to_inferior_object fails.
2094
2095 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2096
2097         * inferior.h (class inferior) <displaced_step_state>: New field.
2098         * infrun.h (struct displaced_step_state): Move here from
2099         infrun.c.  Initialize fields, add constructor.
2100         <inf>: Remove field.
2101         <reset>: New method.
2102         * infrun.c (struct displaced_step_inferior_state): Move to
2103         infrun.h.
2104         (displaced_step_inferior_states): Remove.
2105         (get_displaced_stepping_state): Adust.
2106         (displaced_step_in_progress_any_inferior): Adjust.
2107         (displaced_step_in_progress_thread): Adjust.
2108         (displaced_step_in_progress): Adjust.
2109         (add_displaced_stepping_state): Remove.
2110         (get_displaced_step_closure_by_addr): Adjust.
2111         (remove_displaced_stepping_state): Remove.
2112         (infrun_inferior_exit): Call displaced_step_state.reset.
2113         (use_displaced_stepping): Don't check for NULL.
2114         (displaced_step_prepare_throw): Call
2115         get_displaced_stepping_state.
2116         (displaced_step_fixup): Don't check for NULL.
2117         (prepare_for_detach): Don't check for NULL.
2118
2119 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2120
2121         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2122          in case of call that did not complete.
2123
2124 2019-01-02  Andrey Utkin  <autkin@undo.io>
2125
2126         * symfile.c (find_separate_debug_file): Fix search of debug files for
2127         remote debuggee.
2128
2129 2019-01-02  Tom Tromey  <tom@tromey.com>
2130
2131         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2132         indentation.
2133         * python/py-frame.c (frapy_older): Remove cast.
2134         (frapy_newer): Likewise.
2135         * python/py-breakpoint.c (local_setattro): Remove cast.
2136         * python/py-arch.c (archpy_name): Remove local variable.
2137         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2138
2139 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2140
2141         * unittests/basic_string_view/element_access/char/empty.cc:
2142         Fix year range in copyright header.
2143
2144 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2147         Delete.
2148         <operator==>: Update with for removed field.
2149         <hash>: Likewise.
2150         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2151         <isa_features>: ...this.
2152         <abi_features>: New field.
2153         (riscv_isa_flen): Update comment.
2154         (riscv_abi_xlen): New declaration.
2155         (riscv_abi_flen): New declaration.
2156         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2157         isa_features.
2158         (riscv_abi_xlen): New function.
2159         (riscv_isa_flen): Update to get answer from isa_features.
2160         (riscv_abi_flen): New function.
2161         (riscv_has_fp_abi): Update to get answer from abi_features.
2162         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2163         xlen and flen.
2164         (riscv_call_info) <xlen, flen>: Update comment.
2165         (riscv_call_arg_struct): Remove invalid assertions
2166         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2167         is removed.
2168         (riscv_gdbarch_init): Gather isa features and abi features
2169         separately, ensure both match on the gdbarch when reusing an old
2170         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2171         a target with 64-bit float hardware.
2172
2173 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2174
2175         * source.c (search_command_helper): Stop reverse search
2176         when line 1 has been searched.
2177
2178 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2179
2180         * record-full.c (record_full_base_target::close): Rewrite
2181         record_full_core_buf_list free logic.
2182
2183 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2184
2185         * break-catch-syscall.c (print_one_catch_syscall): xfree
2186         the last text.
2187
2188 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2189
2190         * top.c (print_gdb_version): Update Copyright year in version
2191         message.
2192
2193 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2194
2195         Update copyright year range in all GDB files.
2196
2197 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2198
2199         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2200
2201 For older changes see ChangeLog-2018.
2202 \f
2203 Local Variables:
2204 mode: change-log
2205 left-margin: 8
2206 fill-column: 74
2207 version-control: never
2208 coding: utf-8
2209 End:
2210