Make process_stratum_target::stratum "final"
[external/binutils.git] / gdb / ChangeLog
1 2019-04-18  Tom Tromey  <tromey@adacore.com>
2
3         * process-stratum-target.h (class process_stratum_target)
4         <stratum>: Add "final".
5
6 2019-04-17  Tom Tromey  <tromey@adacore.com>
7
8         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9         against nullptr before use.
10
11 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
12
13         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
14
15 2019-04-17  Jim Wilson  <jimw@sifive.com>
16             Andrew Burgess  <andrew.burgess@embecosm.com>
17
18         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
19         code read might fail, assume 4-byte breakpoint in that case.
20
21 2019-04-15  Leszek Swirski  <leszeks@google.com>
22
23         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
24         rather than a hand-rolled POD check when checking for forced MEMORY
25         classification.
26
27 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
28
29         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
30         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
31         function.
32         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
33         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
34         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
35         declaration.
36
37 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
38
39         * aarch64-linux-nat.c
40         (aarch64_linux_nat_target::thread_architecture): Add override.
41         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
42         each VQ.
43
44 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
45
46         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
47
48 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
49
50         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
51         target types of size 96-bits, add some additional comments, and
52         check that the builtin type we found was the correct size.
53
54 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
55
56         * utils.c (prompt_for_continue): Don't restore the styling at the
57         end, as applied_style has the wrong value.  This fixes styling in
58         long lists of file names that are interrupted by the "Continue?"
59         prompt.
60
61 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
62
63         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
64         * c-lang.c (c_language_defn): Likewise.
65         (cplus_language_defn): Likewise.
66         (asm_language_defn): Likewise.
67         (minimal_language_defn): Likewise.
68         * d-lang.c (d_language_defn): Likewise.
69         * f-lang.c (f_language_defn): Likewise.
70         * go-lang.c (go_language_defn): Likewise.
71         * language.c (unknown_language_defn): Likewise.
72         (auto_language_defn): Likewise.
73         * language.h (struct language_defn): Remove la_magic field.
74         (LANG_MAGIC): Delete.
75         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
76         * objc-lang.c (objc_language_defn): Likewise.
77         * opencl-lang.c (opencl_language_defn): Likewise.
78         * p-lang.c (pascal_language_defn): Likewise.
79         * rust-lang.c (rust_language_defn): Likewise.
80
81 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
82
83         * riscv-tdep.c (riscv_type_align): New function.
84         (riscv_type_alignment): Delete.
85         (riscv_arg_location): Use 'type_align'.
86         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
87
88 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
89
90         * gdbtypes.c (type_align): A struct with no non-static fields also
91         has alignment of 1.
92
93 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
94
95         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
96         component to 0.
97         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
98         member.
99         (riscv_struct_info::analyse): New implementation using new
100         analyse_inner member function.
101         (riscv_struct_info::field_offset): New member function.
102         (riscv_struct_info::m_offsets): New member variable.
103         (riscv_struct_info::analyse_inner): New private member function,
104         takes the old implementation of riscv_struct_info::analyse but
105         extended to track field offsets.
106         (riscv_call_arg_struct): Update the struct folding special cases
107         to handle cases where empty C++ structs, which are non-zero
108         length, are found.
109         (riscv_arg_location): Initialise the length of each location, a
110         non-zero length now indicates the location is in use.
111         (riscv_push_dummy_call): Allow for the first location having a
112         non-zero offset when setting up arguments.
113         (riscv_return_value): Likewise, but for return values.
114
115 2019-04-11  Tom Tromey  <tromey@adacore.com>
116
117         * utils.c (internal_vproblem): Make "msg" const.
118
119 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
120
121         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
122         * trad-frame.c (trad_frame_reset_saved_regs): New function.
123         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
124         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
125
126 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
127
128         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
129         function.
130         (fill_gregset): Call amd64_linux_collect_native_gregset instead
131         of amd64_collect_native_gregset.
132         (amd64_linux_nat_target::store_registers): Likewise.
133
134 2019-04-10  Tom Tromey  <tom@tromey.com>
135
136         * symtab.c (lookup_global_symbol_from_objfile)
137         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
138         * objfiles.h (class separate_debug_iterator): New.
139         (class separate_debug_range): New.
140         (struct objfile) <separate_debug_objfiles>: New method.
141         (objfile_separate_debug_iterate): Don't declare.
142         * objfiles.c (separate_debug_iterator::operator++): Rename from
143         objfile_separate_debug_iterate.
144         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
145         iterator.
146         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
147         iterator.
148
149 2019-04-10  Tom Tromey  <tom@tromey.com>
150
151         * symfile.c (reread_symbols): Remove old comment.
152         * objfiles.c (free_all_objfiles): Fix a typo.
153
154 2019-04-10  Tom Tromey  <tom@tromey.com>
155
156         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
157         * minsyms.c (lookup_minimal_symbol): Use foreach.
158         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
159         (lookup_minimal_symbol_solib_trampoline): Likewise.
160         * symfile.c (reread_symbols): Use foreach.
161
162 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
163             Tom Tromey  <tromey@adacore.com>
164
165         PR rust/24414:
166         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
167         (rust_lex_int_test): Change "value" to be LONGEST.
168         (rust_lex_tests): Add test for long integer literal.
169
170 2019-04-09  Tom Tromey  <tromey@adacore.com>
171
172         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
173         to bool.
174         (extended_remote_target::attach): Update.
175         (remote_target::remote_notice_new_inferior): Update.
176         (remote_target::add_current_inferior_and_thread): Update.
177         * inferior.c (exit_inferior_1): Use "false".
178         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
179
180 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
181
182         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
183         the "start" command.
184
185 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
186
187         * python/py-inferior.c (infpy_thread_from_thread_handle):
188         Adjust comments to reflect renaming of thread_from_thread_handle
189         to thread_from_handle.  Adjust keywords.  Fix type error message.
190         (inferior_object_methods): Add thread_from_handle.  Retain
191         thread_from_thread_handle, but mark it as deprecated.
192
193 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
194
195         * gdbthread.h (find_thread_by_handle): Revise declaration.
196         * thread.c (find_thread_by_handle): Likewise.  Adjust
197         implementation too.
198         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
199         support for buffer objects as handles.
200
201 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
202
203         * python/py-infthread.c (thpy_thread_handle): New function.
204         (thread_object_methods): Register thpy_thread_handle.
205
206 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
207
208         * gdbthread.h (thread_to_thread_handle): Declare.
209         * thread.c (gdbtypes.h): Include.
210         (thread_to_thread_handle): New function.
211
212         * target.h (struct target_ops): Add thread_info_to_thread_handle.
213         (target_thread_info_to_thread_handle): Declare.
214         * target.c (target_thread_info_to_thread_handle): New function.
215         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
216         * target-delegates.c: Regenerate.
217
218         * linux-thread-db.c (class thread_db_target): Add method
219         thread_info_to_thread_handle.
220         (thread_db_target::thread_info_to_thread_handle): Define.
221         * remote.c (class remote_target): Add new method
222         thread_info_to_thread_handle.
223         (remote_target::thread_info_to_thread_handle): Define.
224
225 2019-04-08  Pedro Alves  <palves@redhat.com>
226
227         * common/common-exceptions.c (throw_exception): Don't create
228         named object to throw; throw directly.
229         (throw_it): Likewise.  Don't initialize gdb_exception::message
230         here, with new; pass FMT and AP to the ctor instead.
231         * common/common-exceptions.h: Include <string>.
232         (gdb_exception::gdb_exception(enum return_reason, enum errors,
233         const char *, va_list)): New ctor.  Use std::make_shared.
234         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
235         errors)): Delete.
236         (gdb_exception_error::gdb_exception_error(enum errors, const char
237         *, va_list)): New.
238         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
239         Add assertion.
240         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
241         errors)): Delete.
242         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
243         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
244         Add assertion.
245
246 2019-04-08  Tom Tromey  <tom@tromey.com>
247
248         * valops.c (value_rtti_indirect_type): Replace throw_exception
249         with throw.
250         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
251         with throw.
252         * thread.c (thr_try_catch_cmd): Replace throw_exception with
253         throw.
254         * target.c (target_translate_tls_address): Replace throw_exception
255         with throw.
256         * stack.c (frame_apply_command_count): Replace throw_exception
257         with throw.
258         * solib-spu.c (append_ocl_sos): Replace throw_exception with
259         throw.
260         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
261         with throw.
262         * rs6000-tdep.c (rs6000_frame_cache)
263         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
264         * remote.c: Replace throw_exception with throw.
265         * record-full.c (record_full_message, record_full_wait_1)
266         (record_full_restore): Replace throw_exception with throw.
267         * record-btrace.c:
268         (get_thread_current_frame_id, record_btrace_start_replaying)
269         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
270         (cmd_record_btrace_start): Replace throw_exception with throw.
271         * parse.c (parse_exp_in_context_1): Replace throw_exception with
272         throw.
273         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
274         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
275         * linespec.c:
276         (find_linespec_symbols): Replace throw_exception with throw.
277         * infrun.c (displaced_step_prepare, resume): Replace
278         throw_exception with throw.
279         * infcmd.c (post_create_inferior): Replace throw_exception with
280         throw.
281         * inf-loop.c (inferior_event_handler): Replace throw_exception
282         with throw.
283         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
284         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
285         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
286         (get_prev_frame_always, get_frame_pc_if_available)
287         (get_frame_address_in_block_if_available, get_frame_language):
288         Replace throw_exception with throw.
289         * frame-unwind.c (frame_unwind_try_unwinder): Replace
290         throw_exception with throw.
291         * eval.c (fetch_subexp_value, evaluate_var_value)
292         (evaluate_funcall, evaluate_subexp_standard): Replace
293         throw_exception with throw.
294         * dwarf2loc.c (call_site_find_chain)
295         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
296         Replace throw_exception with throw.
297         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
298         with throw.
299         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
300         throw.
301         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
302         * completer.c (complete_line_internal): Replace throw_exception
303         with throw.
304         * compile/compile-object-run.c (compile_object_run): Replace
305         throw_exception with throw.
306         * cli/cli-script.c (process_next_line): Replace throw_exception
307         with throw.
308         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
309         (btrace_enable, btrace_maint_update_pt_packets): Replace
310         throw_exception with throw.
311         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
312         throw_exception with throw.
313         * break-catch-throw.c (re_set_exception_catchpoint): Replace
314         throw_exception with throw.
315         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
316         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
317         * aarch64-tdep.c (aarch64_make_prologue_cache)
318         (aarch64_make_stub_cache): Replace throw_exception with throw.
319
320 2019-04-08  Tom Tromey  <tom@tromey.com>
321
322         * common/common-exceptions.c (throw_exception): Rename from
323         throw_exception_cxx.  Remove old copy.  Make argument const.
324         (throw_it): Create and throw exception objects directly.
325         * common/common-exceptions.h (throw_exception): Make argument
326         const.
327         (struct gdb_exception_error): Add constructor.
328         (struct gdb_exception_quit): Add constructor.
329
330 2019-04-08  Tom Tromey  <tom@tromey.com>
331
332         * common/common-exceptions.h (exception_rethrow): Don't declare.
333         (TRY_SJLJ): Update comment.
334         (TRY, CATCH, END_CATCH): Remove.
335         * common/common-exceptions.c (exception_rethrow): Remove.
336
337 2019-04-08  Tom Tromey  <tom@tromey.com>
338
339         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
340         Remove.
341         (gdb_exception_error): Rename from
342         gdb_exception_RETURN_MASK_ERROR.
343         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
344         (gdb_quit_bad_alloc): Update.
345         * aarch64-tdep.c: Update.
346         * ada-lang.c: Update.
347         * ada-typeprint.c: Update.
348         * ada-valprint.c: Update.
349         * amd64-tdep.c: Update.
350         * arch-utils.c: Update.
351         * break-catch-throw.c: Update.
352         * breakpoint.c: Update.
353         * btrace.c: Update.
354         * c-varobj.c: Update.
355         * cli/cli-cmds.c: Update.
356         * cli/cli-interp.c: Update.
357         * cli/cli-script.c: Update.
358         * common/common-exceptions.c: Update.
359         * common/new-op.c: Update.
360         * common/selftest.c: Update.
361         * compile/compile-c-symbols.c: Update.
362         * compile/compile-cplus-symbols.c: Update.
363         * compile/compile-object-load.c: Update.
364         * compile/compile-object-run.c: Update.
365         * completer.c: Update.
366         * corelow.c: Update.
367         * cp-abi.c: Update.
368         * cp-support.c: Update.
369         * cp-valprint.c: Update.
370         * darwin-nat.c: Update.
371         * disasm-selftests.c: Update.
372         * dtrace-probe.c: Update.
373         * dwarf-index-cache.c: Update.
374         * dwarf-index-write.c: Update.
375         * dwarf2-frame-tailcall.c: Update.
376         * dwarf2-frame.c: Update.
377         * dwarf2loc.c: Update.
378         * dwarf2read.c: Update.
379         * eval.c: Update.
380         * event-loop.c: Update.
381         * event-top.c: Update.
382         * exec.c: Update.
383         * f-valprint.c: Update.
384         * fbsd-tdep.c: Update.
385         * frame-unwind.c: Update.
386         * frame.c: Update.
387         * gdbtypes.c: Update.
388         * gnu-v3-abi.c: Update.
389         * guile/guile-internal.h: Update.
390         * guile/scm-block.c: Update.
391         * guile/scm-breakpoint.c: Update.
392         * guile/scm-cmd.c: Update.
393         * guile/scm-disasm.c: Update.
394         * guile/scm-frame.c: Update.
395         * guile/scm-lazy-string.c: Update.
396         * guile/scm-math.c: Update.
397         * guile/scm-param.c: Update.
398         * guile/scm-ports.c: Update.
399         * guile/scm-pretty-print.c: Update.
400         * guile/scm-symbol.c: Update.
401         * guile/scm-symtab.c: Update.
402         * guile/scm-type.c: Update.
403         * guile/scm-value.c: Update.
404         * i386-linux-tdep.c: Update.
405         * i386-tdep.c: Update.
406         * inf-loop.c: Update.
407         * infcall.c: Update.
408         * infcmd.c: Update.
409         * infrun.c: Update.
410         * jit.c: Update.
411         * language.c: Update.
412         * linespec.c: Update.
413         * linux-fork.c: Update.
414         * linux-nat.c: Update.
415         * linux-tdep.c: Update.
416         * linux-thread-db.c: Update.
417         * main.c: Update.
418         * mi/mi-cmd-break.c: Update.
419         * mi/mi-cmd-stack.c: Update.
420         * mi/mi-interp.c: Update.
421         * mi/mi-main.c: Update.
422         * objc-lang.c: Update.
423         * p-valprint.c: Update.
424         * parse.c: Update.
425         * ppc-linux-tdep.c: Update.
426         * printcmd.c: Update.
427         * python/py-arch.c: Update.
428         * python/py-breakpoint.c: Update.
429         * python/py-cmd.c: Update.
430         * python/py-finishbreakpoint.c: Update.
431         * python/py-frame.c: Update.
432         * python/py-framefilter.c: Update.
433         * python/py-gdb-readline.c: Update.
434         * python/py-inferior.c: Update.
435         * python/py-infthread.c: Update.
436         * python/py-lazy-string.c: Update.
437         * python/py-linetable.c: Update.
438         * python/py-objfile.c: Update.
439         * python/py-param.c: Update.
440         * python/py-prettyprint.c: Update.
441         * python/py-progspace.c: Update.
442         * python/py-record-btrace.c: Update.
443         * python/py-record.c: Update.
444         * python/py-symbol.c: Update.
445         * python/py-type.c: Update.
446         * python/py-unwind.c: Update.
447         * python/py-utils.c: Update.
448         * python/py-value.c: Update.
449         * python/python.c: Update.
450         * record-btrace.c: Update.
451         * record-full.c: Update.
452         * remote-fileio.c: Update.
453         * remote.c: Update.
454         * riscv-tdep.c: Update.
455         * rs6000-aix-tdep.c: Update.
456         * rs6000-tdep.c: Update.
457         * rust-exp.y: Update.
458         * rust-lang.c: Update.
459         * s390-tdep.c: Update.
460         * selftest-arch.c: Update.
461         * solib-dsbt.c: Update.
462         * solib-frv.c: Update.
463         * solib-spu.c: Update.
464         * solib-svr4.c: Update.
465         * solib.c: Update.
466         * sparc64-linux-tdep.c: Update.
467         * stack.c: Update.
468         * symfile-mem.c: Update.
469         * symmisc.c: Update.
470         * target.c: Update.
471         * thread.c: Update.
472         * top.c: Update.
473         * tracefile-tfile.c: Update.
474         * tui/tui.c: Update.
475         * typeprint.c: Update.
476         * unittests/cli-utils-selftests.c: Update.
477         * unittests/parse-connection-spec-selftests.c: Update.
478         * valops.c: Update.
479         * valprint.c: Update.
480         * value.c: Update.
481         * varobj.c: Update.
482         * windows-nat.c: Update.
483         * x86-linux-nat.c: Update.
484         * xml-support.c: Update.
485
486 2019-04-08  Tom Tromey  <tom@tromey.com>
487
488         * xml-support.c: Use C++ exception handling.
489         * x86-linux-nat.c: Use C++ exception handling.
490         * windows-nat.c: Use C++ exception handling.
491         * varobj.c: Use C++ exception handling.
492         * value.c: Use C++ exception handling.
493         * valprint.c: Use C++ exception handling.
494         * valops.c: Use C++ exception handling.
495         * unittests/parse-connection-spec-selftests.c: Use C++ exception
496         handling.
497         * unittests/cli-utils-selftests.c: Use C++ exception handling.
498         * typeprint.c: Use C++ exception handling.
499         * tui/tui.c: Use C++ exception handling.
500         * tracefile-tfile.c: Use C++ exception handling.
501         * top.c: Use C++ exception handling.
502         * thread.c: Use C++ exception handling.
503         * target.c: Use C++ exception handling.
504         * symmisc.c: Use C++ exception handling.
505         * symfile-mem.c: Use C++ exception handling.
506         * stack.c: Use C++ exception handling.
507         * sparc64-linux-tdep.c: Use C++ exception handling.
508         * solib.c: Use C++ exception handling.
509         * solib-svr4.c: Use C++ exception handling.
510         * solib-spu.c: Use C++ exception handling.
511         * solib-frv.c: Use C++ exception handling.
512         * solib-dsbt.c: Use C++ exception handling.
513         * selftest-arch.c: Use C++ exception handling.
514         * s390-tdep.c: Use C++ exception handling.
515         * rust-lang.c: Use C++ exception handling.
516         * rust-exp.y: Use C++ exception handling.
517         * rs6000-tdep.c: Use C++ exception handling.
518         * rs6000-aix-tdep.c: Use C++ exception handling.
519         * riscv-tdep.c: Use C++ exception handling.
520         * remote.c: Use C++ exception handling.
521         * remote-fileio.c: Use C++ exception handling.
522         * record-full.c: Use C++ exception handling.
523         * record-btrace.c: Use C++ exception handling.
524         * python/python.c: Use C++ exception handling.
525         * python/py-value.c: Use C++ exception handling.
526         * python/py-utils.c: Use C++ exception handling.
527         * python/py-unwind.c: Use C++ exception handling.
528         * python/py-type.c: Use C++ exception handling.
529         * python/py-symbol.c: Use C++ exception handling.
530         * python/py-record.c: Use C++ exception handling.
531         * python/py-record-btrace.c: Use C++ exception handling.
532         * python/py-progspace.c: Use C++ exception handling.
533         * python/py-prettyprint.c: Use C++ exception handling.
534         * python/py-param.c: Use C++ exception handling.
535         * python/py-objfile.c: Use C++ exception handling.
536         * python/py-linetable.c: Use C++ exception handling.
537         * python/py-lazy-string.c: Use C++ exception handling.
538         * python/py-infthread.c: Use C++ exception handling.
539         * python/py-inferior.c: Use C++ exception handling.
540         * python/py-gdb-readline.c: Use C++ exception handling.
541         * python/py-framefilter.c: Use C++ exception handling.
542         * python/py-frame.c: Use C++ exception handling.
543         * python/py-finishbreakpoint.c: Use C++ exception handling.
544         * python/py-cmd.c: Use C++ exception handling.
545         * python/py-breakpoint.c: Use C++ exception handling.
546         * python/py-arch.c: Use C++ exception handling.
547         * printcmd.c: Use C++ exception handling.
548         * ppc-linux-tdep.c: Use C++ exception handling.
549         * parse.c: Use C++ exception handling.
550         * p-valprint.c: Use C++ exception handling.
551         * objc-lang.c: Use C++ exception handling.
552         * mi/mi-main.c: Use C++ exception handling.
553         * mi/mi-interp.c: Use C++ exception handling.
554         * mi/mi-cmd-stack.c: Use C++ exception handling.
555         * mi/mi-cmd-break.c: Use C++ exception handling.
556         * main.c: Use C++ exception handling.
557         * linux-thread-db.c: Use C++ exception handling.
558         * linux-tdep.c: Use C++ exception handling.
559         * linux-nat.c: Use C++ exception handling.
560         * linux-fork.c: Use C++ exception handling.
561         * linespec.c: Use C++ exception handling.
562         * language.c: Use C++ exception handling.
563         * jit.c: Use C++ exception handling.
564         * infrun.c: Use C++ exception handling.
565         * infcmd.c: Use C++ exception handling.
566         * infcall.c: Use C++ exception handling.
567         * inf-loop.c: Use C++ exception handling.
568         * i386-tdep.c: Use C++ exception handling.
569         * i386-linux-tdep.c: Use C++ exception handling.
570         * guile/scm-value.c: Use C++ exception handling.
571         * guile/scm-type.c: Use C++ exception handling.
572         * guile/scm-symtab.c: Use C++ exception handling.
573         * guile/scm-symbol.c: Use C++ exception handling.
574         * guile/scm-pretty-print.c: Use C++ exception handling.
575         * guile/scm-ports.c: Use C++ exception handling.
576         * guile/scm-param.c: Use C++ exception handling.
577         * guile/scm-math.c: Use C++ exception handling.
578         * guile/scm-lazy-string.c: Use C++ exception handling.
579         * guile/scm-frame.c: Use C++ exception handling.
580         * guile/scm-disasm.c: Use C++ exception handling.
581         * guile/scm-cmd.c: Use C++ exception handling.
582         * guile/scm-breakpoint.c: Use C++ exception handling.
583         * guile/scm-block.c: Use C++ exception handling.
584         * guile/guile-internal.h: Use C++ exception handling.
585         * gnu-v3-abi.c: Use C++ exception handling.
586         * gdbtypes.c: Use C++ exception handling.
587         * frame.c: Use C++ exception handling.
588         * frame-unwind.c: Use C++ exception handling.
589         * fbsd-tdep.c: Use C++ exception handling.
590         * f-valprint.c: Use C++ exception handling.
591         * exec.c: Use C++ exception handling.
592         * event-top.c: Use C++ exception handling.
593         * event-loop.c: Use C++ exception handling.
594         * eval.c: Use C++ exception handling.
595         * dwarf2read.c: Use C++ exception handling.
596         * dwarf2loc.c: Use C++ exception handling.
597         * dwarf2-frame.c: Use C++ exception handling.
598         * dwarf2-frame-tailcall.c: Use C++ exception handling.
599         * dwarf-index-write.c: Use C++ exception handling.
600         * dwarf-index-cache.c: Use C++ exception handling.
601         * dtrace-probe.c: Use C++ exception handling.
602         * disasm-selftests.c: Use C++ exception handling.
603         * darwin-nat.c: Use C++ exception handling.
604         * cp-valprint.c: Use C++ exception handling.
605         * cp-support.c: Use C++ exception handling.
606         * cp-abi.c: Use C++ exception handling.
607         * corelow.c: Use C++ exception handling.
608         * completer.c: Use C++ exception handling.
609         * compile/compile-object-run.c: Use C++ exception handling.
610         * compile/compile-object-load.c: Use C++ exception handling.
611         * compile/compile-cplus-symbols.c: Use C++ exception handling.
612         * compile/compile-c-symbols.c: Use C++ exception handling.
613         * common/selftest.c: Use C++ exception handling.
614         * common/new-op.c: Use C++ exception handling.
615         * cli/cli-script.c: Use C++ exception handling.
616         * cli/cli-interp.c: Use C++ exception handling.
617         * cli/cli-cmds.c: Use C++ exception handling.
618         * c-varobj.c: Use C++ exception handling.
619         * btrace.c: Use C++ exception handling.
620         * breakpoint.c: Use C++ exception handling.
621         * break-catch-throw.c: Use C++ exception handling.
622         * arch-utils.c: Use C++ exception handling.
623         * amd64-tdep.c: Use C++ exception handling.
624         * ada-valprint.c: Use C++ exception handling.
625         * ada-typeprint.c: Use C++ exception handling.
626         * ada-lang.c: Use C++ exception handling.
627         * aarch64-tdep.c: Use C++ exception handling.
628
629 2019-04-08  Tom Tromey  <tom@tromey.com>
630
631         * xml-support.c (gdb_xml_parser::parse): Update.
632         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
633         * value.c (show_convenience): Update.
634         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
635         (test_parse_flags_qcs): Update.
636         * thread.c (thr_try_catch_cmd): Update.
637         * target.c (target_translate_tls_address): Update.
638         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
639         (info_frame_command_core, frame_apply_command_count): Update.
640         * rust-exp.y (rust_lex_exception_test): Update.
641         * riscv-tdep.c (riscv_print_one_register_info): Update.
642         * remote.c (remote_target::enable_btrace): Update.
643         * record-btrace.c (record_btrace_enable_warn): Update.
644         * python/py-utils.c (gdbpy_convert_exception): Update.
645         * printcmd.c (do_one_display, print_variable_and_value): Update.
646         * mi/mi-main.c (mi_print_exception): Update.
647         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
648         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
649         * linux-nat.c (linux_nat_target::attach): Update.
650         * linux-fork.c (class scoped_switch_fork_info): Update.
651         * infrun.c (displaced_step_prepare): Update.
652         * infcall.c (call_function_by_hand_dummy): Update.
653         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
654         * gnu-v3-abi.c (print_one_vtable): Update.
655         * frame.c (get_prev_frame_always): Update.
656         * f-valprint.c (info_common_command_for_block): Update.
657         * exec.c (try_open_exec_file): Update.
658         * exceptions.c (print_exception, exception_print)
659         (exception_fprintf, exception_print_same): Update.
660         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
661         * dwarf-index-cache.c (index_cache::store)
662         (index_cache::lookup_gdb_index): Update.
663         * darwin-nat.c (maybe_cache_shell): Update.
664         * cp-valprint.c (cp_print_value_fields): Update.
665         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
666         (gcc_cplus_symbol_address): Update.
667         * compile/compile-c-symbols.c (gcc_convert_symbol)
668         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
669         * common/selftest.c: Update.
670         * common/common-exceptions.h (struct gdb_exception) <message>: Now
671         a std::string.
672         (exception_try_scope_entry, exception_try_scope_exit): Don't
673         declare.
674         (struct exception_try_scope): Remove.
675         (TRY): Don't use exception_try_scope.
676         (struct gdb_exception): Add constructor, operator=.
677         <what>: New method.
678         (struct gdb_exception_RETURN_MASK_ALL)
679         (struct gdb_exception_RETURN_MASK_ERROR)
680         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
681         (struct gdb_quit_bad_alloc): Update.
682         * common/common-exceptions.c (exception_none): Change
683         initializer.
684         (struct catcher) <state, exception>: Initialize inline.
685         <prev>: Remove member.
686         (current_catcher): Remove.
687         (catchers): New global.
688         (exceptions_state_mc_init): Simplify.
689         (catcher_pop): Remove.
690         (exceptions_state_mc, exceptions_state_mc_catch): Update.
691         (try_scope_depth, exception_try_scope_entry)
692         (exception_try_scope_exit): Remove.
693         (throw_exception_sjlj): Update.
694         (exception_messages, exception_messages_size): Remove.
695         (throw_it): Simplify.
696         (gdb_exception_sliced_copy): Remove.
697         (throw_exception_cxx): Update.
698         * cli/cli-script.c (script_from_file): Update.
699         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
700         Update.
701         * ada-valprint.c (ada_val_print): Update.
702         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
703         (create_excep_cond_exprs): Update.
704
705 2019-04-08  Tom Tromey  <tom@tromey.com>
706
707         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
708         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
709         (TRY, CATCH, END_CATCH): Remove some definitions.
710         * common/common-exceptions.c: Don't use GDB_XCPT.
711         (catcher_list_size): Remove.
712         (throw_exception, throw_it): Simplify.
713
714 2019-04-05  Tom Tromey  <tom@tromey.com>
715
716         Revert the header-sorting patch.
717         * ft32-tdep.c: Revert.
718         * frv-tdep.c: Revert.
719         * frv-linux-tdep.c: Revert.
720         * frame.c: Revert.
721         * frame-unwind.c: Revert.
722         * frame-base.c: Revert.
723         * fork-child.c: Revert.
724         * findvar.c: Revert.
725         * findcmd.c: Revert.
726         * filesystem.c: Revert.
727         * filename-seen-cache.h: Revert.
728         * filename-seen-cache.c: Revert.
729         * fbsd-tdep.c: Revert.
730         * fbsd-nat.h: Revert.
731         * fbsd-nat.c: Revert.
732         * f-valprint.c: Revert.
733         * f-typeprint.c: Revert.
734         * f-lang.c: Revert.
735         * extension.h: Revert.
736         * extension.c: Revert.
737         * extension-priv.h: Revert.
738         * expprint.c: Revert.
739         * exec.h: Revert.
740         * exec.c: Revert.
741         * exceptions.c: Revert.
742         * event-top.c: Revert.
743         * event-loop.c: Revert.
744         * eval.c: Revert.
745         * elfread.c: Revert.
746         * dwarf2read.h: Revert.
747         * dwarf2read.c: Revert.
748         * dwarf2loc.c: Revert.
749         * dwarf2expr.h: Revert.
750         * dwarf2expr.c: Revert.
751         * dwarf2-frame.c: Revert.
752         * dwarf2-frame-tailcall.c: Revert.
753         * dwarf-index-write.h: Revert.
754         * dwarf-index-write.c: Revert.
755         * dwarf-index-common.c: Revert.
756         * dwarf-index-cache.h: Revert.
757         * dwarf-index-cache.c: Revert.
758         * dummy-frame.c: Revert.
759         * dtrace-probe.c: Revert.
760         * disasm.h: Revert.
761         * disasm.c: Revert.
762         * disasm-selftests.c: Revert.
763         * dictionary.c: Revert.
764         * dicos-tdep.c: Revert.
765         * demangle.c: Revert.
766         * dcache.h: Revert.
767         * dcache.c: Revert.
768         * darwin-nat.h: Revert.
769         * darwin-nat.c: Revert.
770         * darwin-nat-info.c: Revert.
771         * d-valprint.c: Revert.
772         * d-namespace.c: Revert.
773         * d-lang.c: Revert.
774         * ctf.c: Revert.
775         * csky-tdep.c: Revert.
776         * csky-linux-tdep.c: Revert.
777         * cris-tdep.c: Revert.
778         * cris-linux-tdep.c: Revert.
779         * cp-valprint.c: Revert.
780         * cp-support.c: Revert.
781         * cp-namespace.c: Revert.
782         * cp-abi.c: Revert.
783         * corelow.c: Revert.
784         * corefile.c: Revert.
785         * continuations.c: Revert.
786         * completer.h: Revert.
787         * completer.c: Revert.
788         * complaints.c: Revert.
789         * coffread.c: Revert.
790         * coff-pe-read.c: Revert.
791         * cli-out.h: Revert.
792         * cli-out.c: Revert.
793         * charset.c: Revert.
794         * c-varobj.c: Revert.
795         * c-valprint.c: Revert.
796         * c-typeprint.c: Revert.
797         * c-lang.c: Revert.
798         * buildsym.c: Revert.
799         * buildsym-legacy.c: Revert.
800         * build-id.h: Revert.
801         * build-id.c: Revert.
802         * btrace.c: Revert.
803         * bsd-uthread.c: Revert.
804         * breakpoint.h: Revert.
805         * breakpoint.c: Revert.
806         * break-catch-throw.c: Revert.
807         * break-catch-syscall.c: Revert.
808         * break-catch-sig.c: Revert.
809         * blockframe.c: Revert.
810         * block.c: Revert.
811         * bfin-tdep.c: Revert.
812         * bfin-linux-tdep.c: Revert.
813         * bfd-target.c: Revert.
814         * bcache.c: Revert.
815         * ax-general.c: Revert.
816         * ax-gdb.h: Revert.
817         * ax-gdb.c: Revert.
818         * avr-tdep.c: Revert.
819         * auxv.c: Revert.
820         * auto-load.c: Revert.
821         * arm-wince-tdep.c: Revert.
822         * arm-tdep.c: Revert.
823         * arm-symbian-tdep.c: Revert.
824         * arm-pikeos-tdep.c: Revert.
825         * arm-obsd-tdep.c: Revert.
826         * arm-nbsd-tdep.c: Revert.
827         * arm-nbsd-nat.c: Revert.
828         * arm-linux-tdep.c: Revert.
829         * arm-linux-nat.c: Revert.
830         * arm-fbsd-tdep.c: Revert.
831         * arm-fbsd-nat.c: Revert.
832         * arm-bsd-tdep.c: Revert.
833         * arch-utils.c: Revert.
834         * arc-tdep.c: Revert.
835         * arc-newlib-tdep.c: Revert.
836         * annotate.h: Revert.
837         * annotate.c: Revert.
838         * amd64-windows-tdep.c: Revert.
839         * amd64-windows-nat.c: Revert.
840         * amd64-tdep.c: Revert.
841         * amd64-sol2-tdep.c: Revert.
842         * amd64-obsd-tdep.c: Revert.
843         * amd64-obsd-nat.c: Revert.
844         * amd64-nbsd-tdep.c: Revert.
845         * amd64-nbsd-nat.c: Revert.
846         * amd64-nat.c: Revert.
847         * amd64-linux-tdep.c: Revert.
848         * amd64-linux-nat.c: Revert.
849         * amd64-fbsd-tdep.c: Revert.
850         * amd64-fbsd-nat.c: Revert.
851         * amd64-dicos-tdep.c: Revert.
852         * amd64-darwin-tdep.c: Revert.
853         * amd64-bsd-nat.c: Revert.
854         * alpha-tdep.c: Revert.
855         * alpha-obsd-tdep.c: Revert.
856         * alpha-nbsd-tdep.c: Revert.
857         * alpha-mdebug-tdep.c: Revert.
858         * alpha-linux-tdep.c: Revert.
859         * alpha-linux-nat.c: Revert.
860         * alpha-bsd-tdep.c: Revert.
861         * alpha-bsd-nat.c: Revert.
862         * aix-thread.c: Revert.
863         * agent.c: Revert.
864         * addrmap.c: Revert.
865         * ada-varobj.c: Revert.
866         * ada-valprint.c: Revert.
867         * ada-typeprint.c: Revert.
868         * ada-tasks.c: Revert.
869         * ada-lang.c: Revert.
870         * aarch64-tdep.c: Revert.
871         * aarch64-ravenscar-thread.c: Revert.
872         * aarch64-newlib-tdep.c: Revert.
873         * aarch64-linux-tdep.c: Revert.
874         * aarch64-linux-nat.c: Revert.
875         * aarch64-fbsd-tdep.c: Revert.
876         * aarch64-fbsd-nat.c: Revert.
877         * aarch32-linux-nat.c: Revert.
878
879 2019-04-05  Tom Tromey  <tom@tromey.com>
880
881         * ft32-tdep.c: Sort headers.
882         * frv-tdep.c: Sort headers.
883         * frv-linux-tdep.c: Sort headers.
884         * frame.c: Sort headers.
885         * frame-unwind.c: Sort headers.
886         * frame-base.c: Sort headers.
887         * fork-child.c: Sort headers.
888         * findvar.c: Sort headers.
889         * findcmd.c: Sort headers.
890         * filesystem.c: Sort headers.
891         * filename-seen-cache.h: Sort headers.
892         * filename-seen-cache.c: Sort headers.
893         * fbsd-tdep.c: Sort headers.
894         * fbsd-nat.h: Sort headers.
895         * fbsd-nat.c: Sort headers.
896         * f-valprint.c: Sort headers.
897         * f-typeprint.c: Sort headers.
898         * f-lang.c: Sort headers.
899         * extension.h: Sort headers.
900         * extension.c: Sort headers.
901         * extension-priv.h: Sort headers.
902         * expprint.c: Sort headers.
903         * exec.h: Sort headers.
904         * exec.c: Sort headers.
905         * exceptions.c: Sort headers.
906         * event-top.c: Sort headers.
907         * event-loop.c: Sort headers.
908         * eval.c: Sort headers.
909         * elfread.c: Sort headers.
910         * dwarf2read.h: Sort headers.
911         * dwarf2read.c: Sort headers.
912         * dwarf2loc.c: Sort headers.
913         * dwarf2expr.h: Sort headers.
914         * dwarf2expr.c: Sort headers.
915         * dwarf2-frame.c: Sort headers.
916         * dwarf2-frame-tailcall.c: Sort headers.
917         * dwarf-index-write.h: Sort headers.
918         * dwarf-index-write.c: Sort headers.
919         * dwarf-index-common.c: Sort headers.
920         * dwarf-index-cache.h: Sort headers.
921         * dwarf-index-cache.c: Sort headers.
922         * dummy-frame.c: Sort headers.
923         * dtrace-probe.c: Sort headers.
924         * disasm.h: Sort headers.
925         * disasm.c: Sort headers.
926         * disasm-selftests.c: Sort headers.
927         * dictionary.c: Sort headers.
928         * dicos-tdep.c: Sort headers.
929         * demangle.c: Sort headers.
930         * dcache.h: Sort headers.
931         * dcache.c: Sort headers.
932         * darwin-nat.h: Sort headers.
933         * darwin-nat.c: Sort headers.
934         * darwin-nat-info.c: Sort headers.
935         * d-valprint.c: Sort headers.
936         * d-namespace.c: Sort headers.
937         * d-lang.c: Sort headers.
938         * ctf.c: Sort headers.
939         * csky-tdep.c: Sort headers.
940         * csky-linux-tdep.c: Sort headers.
941         * cris-tdep.c: Sort headers.
942         * cris-linux-tdep.c: Sort headers.
943         * cp-valprint.c: Sort headers.
944         * cp-support.c: Sort headers.
945         * cp-namespace.c: Sort headers.
946         * cp-abi.c: Sort headers.
947         * corelow.c: Sort headers.
948         * corefile.c: Sort headers.
949         * continuations.c: Sort headers.
950         * completer.h: Sort headers.
951         * completer.c: Sort headers.
952         * complaints.c: Sort headers.
953         * coffread.c: Sort headers.
954         * coff-pe-read.c: Sort headers.
955         * cli-out.h: Sort headers.
956         * cli-out.c: Sort headers.
957         * charset.c: Sort headers.
958         * c-varobj.c: Sort headers.
959         * c-valprint.c: Sort headers.
960         * c-typeprint.c: Sort headers.
961         * c-lang.c: Sort headers.
962         * buildsym.c: Sort headers.
963         * buildsym-legacy.c: Sort headers.
964         * build-id.h: Sort headers.
965         * build-id.c: Sort headers.
966         * btrace.c: Sort headers.
967         * bsd-uthread.c: Sort headers.
968         * breakpoint.h: Sort headers.
969         * breakpoint.c: Sort headers.
970         * break-catch-throw.c: Sort headers.
971         * break-catch-syscall.c: Sort headers.
972         * break-catch-sig.c: Sort headers.
973         * blockframe.c: Sort headers.
974         * block.c: Sort headers.
975         * bfin-tdep.c: Sort headers.
976         * bfin-linux-tdep.c: Sort headers.
977         * bfd-target.c: Sort headers.
978         * bcache.c: Sort headers.
979         * ax-general.c: Sort headers.
980         * ax-gdb.h: Sort headers.
981         * ax-gdb.c: Sort headers.
982         * avr-tdep.c: Sort headers.
983         * auxv.c: Sort headers.
984         * auto-load.c: Sort headers.
985         * arm-wince-tdep.c: Sort headers.
986         * arm-tdep.c: Sort headers.
987         * arm-symbian-tdep.c: Sort headers.
988         * arm-pikeos-tdep.c: Sort headers.
989         * arm-obsd-tdep.c: Sort headers.
990         * arm-nbsd-tdep.c: Sort headers.
991         * arm-nbsd-nat.c: Sort headers.
992         * arm-linux-tdep.c: Sort headers.
993         * arm-linux-nat.c: Sort headers.
994         * arm-fbsd-tdep.c: Sort headers.
995         * arm-fbsd-nat.c: Sort headers.
996         * arm-bsd-tdep.c: Sort headers.
997         * arch-utils.c: Sort headers.
998         * arc-tdep.c: Sort headers.
999         * arc-newlib-tdep.c: Sort headers.
1000         * annotate.h: Sort headers.
1001         * annotate.c: Sort headers.
1002         * amd64-windows-tdep.c: Sort headers.
1003         * amd64-windows-nat.c: Sort headers.
1004         * amd64-tdep.c: Sort headers.
1005         * amd64-sol2-tdep.c: Sort headers.
1006         * amd64-obsd-tdep.c: Sort headers.
1007         * amd64-obsd-nat.c: Sort headers.
1008         * amd64-nbsd-tdep.c: Sort headers.
1009         * amd64-nbsd-nat.c: Sort headers.
1010         * amd64-nat.c: Sort headers.
1011         * amd64-linux-tdep.c: Sort headers.
1012         * amd64-linux-nat.c: Sort headers.
1013         * amd64-fbsd-tdep.c: Sort headers.
1014         * amd64-fbsd-nat.c: Sort headers.
1015         * amd64-dicos-tdep.c: Sort headers.
1016         * amd64-darwin-tdep.c: Sort headers.
1017         * amd64-bsd-nat.c: Sort headers.
1018         * alpha-tdep.c: Sort headers.
1019         * alpha-obsd-tdep.c: Sort headers.
1020         * alpha-nbsd-tdep.c: Sort headers.
1021         * alpha-mdebug-tdep.c: Sort headers.
1022         * alpha-linux-tdep.c: Sort headers.
1023         * alpha-linux-nat.c: Sort headers.
1024         * alpha-bsd-tdep.c: Sort headers.
1025         * alpha-bsd-nat.c: Sort headers.
1026         * aix-thread.c: Sort headers.
1027         * agent.c: Sort headers.
1028         * addrmap.c: Sort headers.
1029         * ada-varobj.c: Sort headers.
1030         * ada-valprint.c: Sort headers.
1031         * ada-typeprint.c: Sort headers.
1032         * ada-tasks.c: Sort headers.
1033         * ada-lang.c: Sort headers.
1034         * aarch64-tdep.c: Sort headers.
1035         * aarch64-ravenscar-thread.c: Sort headers.
1036         * aarch64-newlib-tdep.c: Sort headers.
1037         * aarch64-linux-tdep.c: Sort headers.
1038         * aarch64-linux-nat.c: Sort headers.
1039         * aarch64-fbsd-tdep.c: Sort headers.
1040         * aarch64-fbsd-nat.c: Sort headers.
1041         * aarch32-linux-nat.c: Sort headers.
1042
1043 2019-04-04  Tom Tromey  <tom@tromey.com>
1044
1045         * varobj.c (varobj_create): Update.
1046         * rust-exp.y (struct rust_parser) <update_innermost_block,
1047         lookup_symbol>: New methods.
1048         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1049         Rename.
1050         (rust_parser::rust_lookup_type)
1051         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1052         * printcmd.c (display_command, do_one_display): Update.
1053         * parser-defs.h (struct parser_state) <parser_state>: Add
1054         "tracker" parameter.
1055         (block_tracker): New member.
1056         (class innermost_block_tracker) <innermost_block_tracker>: Add
1057         "types" parameter.
1058         <reset>: Remove method.
1059         (innermost_block): Don't declare.
1060         (null_post_parser): Update.
1061         * parse.c (innermost_block): Remove global.
1062         (write_dollar_variable): Update.
1063         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1064         Remove "tracker_types" parameter.
1065         (parse_expression): Add "tracker" parameter.
1066         (parse_expression_for_completion): Update.
1067         (null_post_parser): Add "tracker" parameter.
1068         * p-exp.y: Update rules.
1069         * m2-exp.y: Update rules.
1070         * language.h (struct language_defn) <la_post_parser>: Add
1071         "tracker" parameter.
1072         * go-exp.y: Update rules.
1073         * f-exp.y: Update rules.
1074         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1075         parameter.
1076         * d-exp.y: Update rules.
1077         * c-exp.y: Update rules.
1078         * breakpoint.c (set_breakpoint_condition): Create an
1079         innermost_block_tracker.
1080         (watch_command_1): Likewise.
1081         * ada-lang.c (resolve): Add "tracker" parameter.
1082         (resolve_subexp): Likewise.
1083         * ada-exp.y (write_var_from_sym): Update.
1084
1085 2019-04-04  Tom Tromey  <tom@tromey.com>
1086
1087         * type-stack.h: New file.
1088         * type-stack.c: New file.
1089         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1090         type-stack.h.
1091         (insert_into_type_stack, insert_type, push_type, push_type_int)
1092         (insert_type_address_space, pop_type, pop_type_int)
1093         (pop_typelist, pop_type_stack, append_type_stack)
1094         (push_type_stack, get_type_stack, push_typelist)
1095         (follow_type_instance_flags, follow_types): Don't declare.
1096         * parse.c (type_stack): Remove global.
1097         (parse_exp_in_context): Update.
1098         (insert_into_type_stack, insert_type, push_type, push_type_int)
1099         (insert_type_address_space, pop_type, pop_type_int)
1100         (pop_typelist, pop_type_stack, append_type_stack)
1101         (push_type_stack, get_type_stack, push_typelist)
1102         (follow_type_instance_flags, follow_types): Remove (moved to
1103         type-stack.c).
1104         * f-exp.y (type_stack): New global.
1105         Update rules.
1106         (push_kind_type, f_parse): Update.
1107         * d-exp.y (type_stack): New global.
1108         Update rules.
1109         (d_parse): Update.
1110         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1111         Update rules.
1112         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1113         (HFILES_NO_SRCDIR): Add type-stack.h.
1114
1115 2019-04-04  Tom Tromey  <tom@tromey.com>
1116
1117         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1118         (rust_parser::convert_ast_to_expression, rust_parse)
1119         (rust_lex_test_completion, rust_lex_tests): Update.
1120         * parser-defs.h (struct expr_completion_state): New.
1121         (struct parser_state) <parser_state>: Add completion parameter.
1122         <mark_struct_expression, mark_completion_tag>: New methods.
1123         <parse_completion, m_completion_state>: New members.
1124         (prefixify_expression, null_post_parser): Update.
1125         (mark_struct_expression, mark_completion_tag): Don't declare.
1126         * parse.c (parse_completion, expout_last_struct)
1127         (expout_tag_completion_type, expout_completion_name): Remove
1128         globals.
1129         (parser_state::mark_struct_expression)
1130         (parser_state::mark_completion_tag): Now methods.
1131         (prefixify_expression): Add last_struct parameter.
1132         (prefixify_subexp): Likewise.
1133         (parse_exp_1): Update.
1134         (parse_exp_in_context): Add cstate parameter.  Update.
1135         (parse_expression_for_completion): Create an
1136         expr_completion_state.
1137         (null_post_parser): Add "completion" parameter.
1138         * p-exp.y: Update rules.
1139         (yylex): Update.
1140         * language.h (struct language_defn) <la_post_parser>: Add
1141         "completing" parameter.
1142         * go-exp.y: Update rules.
1143         (lex_one_token): Update.
1144         * expression.h (parse_completion): Don't declare.
1145         * d-exp.y: Update rules.
1146         (lex_one_token): Update rules.
1147         * c-exp.y: Update rules.
1148         (lex_one_token): Update.
1149         * ada-lang.c (resolve): Add "parse_completion" parameter.
1150         (resolve_subexp): Likewise.
1151         (ada_resolve_function): Likewise.
1152
1153 2019-04-04  Tom Tromey  <tom@tromey.com>
1154
1155         * parser-defs.h (struct parser_state) <start_arglist,
1156         end_arglist>: New methods.
1157         <arglist_len, m_funcall_chain>: New members.
1158         (arglist_len, start_arglist, end_arglist): Don't declare.
1159         * parse.c (arglist_len, funcall_chain): Remove global.
1160         (start_arglist, end_arglist): Remove functions.
1161         (parse_exp_in_context): Update.
1162         * p-exp.y: Update rules.
1163         * m2-exp.y: Update rules.
1164         * go-exp.y: Update rules.
1165         * f-exp.y: Update rules.
1166         * d-exp.y: Update rules.
1167         * c-exp.y: Update rules.
1168
1169 2019-04-04  Tom Tromey  <tom@tromey.com>
1170
1171         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1172         lex_operator, push_back>: New methods.
1173         Update all rules.
1174         (rust_parser::lex_hex, lex_escape): Rename and update.
1175         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1176         (rust_parser::lex_operator): Rename and update.
1177         (rust_parser::lex_number, rustyylex, rustyyerror)
1178         (rust_lex_test_init, rust_lex_test_sequence)
1179         (rust_lex_test_push_back, rust_lex_tests): Update.
1180         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1181         parameter.
1182         <lexptr, prev_lexptr>: New members.
1183         (lexptr, prev_lexptr): Don't declare.
1184         * parse.c (lexptr, prev_lexptr): Remove globals.
1185         (parse_exp_in_context): Update.
1186         * p-exp.y (yylex, yyerror): Update.
1187         * m2-exp.y (parse_number, yylex, yyerror): Update.
1188         * go-exp.y (lex_one_token, yyerror): Update.
1189         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1190         * d-exp.y (lex_one_token, yyerror): Update.
1191         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1192         (lex_one_token, yyerror): Update.
1193         * ada-lex.l (YY_INPUT): Update.
1194         (rewind_to_char): Update.
1195         * ada-exp.y (yyerror): Update.
1196
1197 2019-04-04  Tom Tromey  <tom@tromey.com>
1198
1199         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1200         * parser-defs.h (struct parser_state) <parser_state>: Add new
1201         parameter.
1202         <comma_terminates>: New member.
1203         (comma_terminates): Don't declare global.
1204         * parse.c (comma_terminates): Remove global.
1205         (parse_exp_in_context): Update.
1206         * p-exp.y (yylex): Update.
1207         * m2-exp.y (yylex): Update.
1208         * go-exp.y (lex_one_token): Update.
1209         * f-exp.y (yylex): Update.
1210         * d-exp.y (lex_one_token): Update.
1211         * c-exp.y (lex_one_token): Update.
1212         * ada-lex.l: Update.
1213
1214 2019-04-04  Tom Tromey  <tom@tromey.com>
1215
1216         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1217         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1218         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1219         * parser-defs.h (paren_depth): Don't declare.
1220         * parse.c (paren_depth): Remove global.
1221         (parse_exp_in_context): Update.
1222         * p-exp.y (paren_depth): New global.
1223         (pascal_parse): Initialize it.
1224         * m2-exp.y (paren_depth): New global.
1225         (m2_parse): Initialize it.
1226         * go-exp.y (paren_depth): New global.
1227         (go_parse): Initialize it.
1228         * f-exp.y (paren_depth): New global.
1229         (f_parse): Initialize it.
1230         * d-exp.y (paren_depth): New global.
1231         (d_parse): Initialize it.
1232         * c-exp.y (paren_depth): New global.
1233         (c_parse): Initialize it.
1234         * ada-lex.l (paren_depth): New global.
1235         (lexer_init): Initialize it.
1236
1237 2019-04-04  Tom Tromey  <tom@tromey.com>
1238
1239         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1240         (rust_parser::convert_ast_to_type)
1241         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1242         * parser-defs.h (struct parser_state) <parser_state>: Add
1243         parameters.  Initialize new members.
1244         <expression_context_block, expression_context_pc>: New members.
1245         * parse.c (expression_context_block, expression_context_pc):
1246         Remove globals.
1247         (parse_exp_in_context): Update.
1248         * p-exp.y: Update all rules.
1249         (yylex): Update.
1250         * m2-exp.y: Update all rules.
1251         (yylex): Update.
1252         * go-exp.y (yylex): Update.
1253         * f-exp.y (yylex): Update.
1254         * d-exp.y: Update all rules.
1255         (yylex): Update.
1256         * c-exp.y: Update all rules.
1257         (lex_one_token, classify_name, yylex, c_parse): Update.
1258         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1259
1260 2019-04-04  Tom Tromey  <tom@tromey.com>
1261
1262         * gdbarch.h, gdbarch.c: Rebuild.
1263         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1264         * stap-probe.h: 
1265         (struct stap_parse_info): Replace "parser_state" with
1266         "expr_builder".
1267         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1268         (parser_state): New class.
1269         * parse.c (expr_builder): Rename.
1270         (expr_builder::release): Rename.
1271         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1272         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1273         (write_exp_elt_longcst, write_exp_elt_floatcst)
1274         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1275         (write_exp_string_vector, write_exp_bitstring)
1276         (write_exp_msymbol, mark_struct_expression)
1277         (write_dollar_variable)
1278         (insert_type_address_space, increase_expout_size): Replace
1279         "parser_state" with "expr_builder".
1280         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1281         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1282         "parser_state" with "expr_builder".
1283
1284 2019-04-04  Tom Tromey  <tom@tromey.com>
1285
1286         * rust-exp.y: Replace "parse_language" with method call.
1287         * p-exp.y: 
1288         (yylex): Replace "parse_language" with method call.
1289         * m2-exp.y: 
1290         (yylex): Replace "parse_language" with method call.
1291         * go-exp.y (classify_name): Replace "parse_language" with method
1292         call.
1293         * f-exp.y (yylex): Replace "parse_language" with method call.
1294         * d-exp.y (lex_one_token): Replace "parse_language" with method
1295         call.
1296         * c-exp.y: 
1297         (lex_one_token, classify_name, yylex): Replace "parse_language"
1298         with method call.
1299         * ada-exp.y (find_primitive_type, type_char)
1300         (type_system_address): Replace "parse_language" with method call.
1301
1302 2019-04-04  Tom Tromey  <tom@tromey.com>
1303
1304         * rust-exp.y: Replace "parse_gdbarch" with method call.
1305         * parse.c (write_dollar_variable, insert_type_address_space):
1306         Replace "parse_gdbarch" with method call.
1307         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1308         call.
1309         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1310         call.
1311         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1312         "parse_gdbarch" with method call.
1313         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1314         with method call.
1315         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1316         "parse_gdbarch" with method call.
1317         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1318         "parse_gdbarch" with method call.
1319         * c-exp.y (parse_type, parse_number, classify_name): Replace
1320         "parse_gdbarch" with method call.
1321         * ada-lex.l: Replace "parse_gdbarch" with method call.
1322         * ada-exp.y (parse_type, find_primitive_type, type_char)
1323         (type_system_address): Replace "parse_gdbarch" with method call.
1324
1325 2019-04-04  Tom Tromey  <tom@tromey.com>
1326
1327         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1328         * stap-probe.c (stap_parse_argument): Update.
1329         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1330         initial_size parameter.
1331         * rust-exp.y (rust_lex_tests): Update.
1332         * parse.c (parser_state): Update.
1333         (parse_exp_in_context): Update.
1334         * parser-defs.h (struct parser_state) <parser_state>: Remove
1335         "initial_size" parameter.
1336
1337 2019-04-04  Tom Tromey  <tom@tromey.com>
1338
1339         * parser-defs.h (increase_expout_size): Don't declare.
1340         * parse.c (increase_expout_size): Now static.
1341
1342 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1343
1344         * gnu-nat.c (gnu_nat_target::wait): Fix
1345         target_waitstatus_to_string call.
1346
1347 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * eval.c (evaluate_subexp_standard): Handle internal functions
1350         during Fortran function call handling.
1351
1352 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1353
1354         * NEWS: Mention new internal functions.
1355         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1356         (read_base_type): Use dwarf2_init_complex_target_type.
1357         * value.c (creal_internal_fn): New function.
1358         (cimag_internal_fn): New function.
1359         (_initialize_values): Register new internal functions.
1360
1361 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1362
1363         * infrun.c (stop_all_threads): If debug_infrun, always
1364         trace the wait status after wait_one, using
1365         target_waitstatus_to_string and target_pid_to_str.
1366         (handle_inferior_event): Replace various trace of
1367         wait status kind by a single trace.
1368         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1369         wait status kind image by target_waitstatus_to_string.
1370         * target/waitstatus.c (target_waitstatus_to_string): Fix
1371         obsolete comment.
1372
1373 2019-04-01  Tom Tromey  <tromey@adacore.com>
1374
1375         PR symtab/23331:
1376         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1377
1378 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1379             Pedro Alves  <palves@redhat.com>
1380
1381         * top.c (quit_force): Call 'finalize_values'.
1382         * value.c (finalize_values): New function.
1383         * value.h (finalize_values): Declare.
1384
1385 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1386
1387         * NEWS: Announce $_gdb_major and $_gdb_minor.
1388
1389         * top.c (init_gdb_version_vars): New function.
1390         (gdb_init): Call init_gdb_version_vars.
1391
1392 2019-03-29  Tom Tromey  <tromey@adacore.com>
1393
1394         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1395         help text.  Remove dead code.
1396
1397 2019-03-29  Keith Seitz  <keiths@redhat.com>
1398
1399         From Siddhesh Poyarekar:
1400         * f-lang.h (f77_get_upperbound): Return LONGEST.
1401         (f77_get_lowerbound): Likewise.
1402         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1403         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1404         print them.
1405         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1406         plongest to format print it.
1407         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1408         (f77_get_upperbound): Likewise.
1409         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1410         LOWER_BOUND to LONGEST.
1411         (f77_create_arrayprint_offset_tbl): Likewise.
1412
1413 2019-03-29  Keith Seitz  <keiths@redhat.com>
1414
1415         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1416         %s/pulongest for TYPE_LENGTH instead of %d in format
1417         strings.
1418         * ada-typerint.c (ada_print_type): Likewise.
1419         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1420         * compile/compile-c-support.c (generate_register_struct): Likewise.
1421         * gdbtypes.c (recursive_dump_type): Likewise.
1422         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1423         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1424         instead of %d in format strings.
1425         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1426         to std::min to ULONGEST.
1427         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1428         instead of %d in format strings.
1429         * tracepoint.c (info_scope_command): Likewise.
1430         * typeprint.c (print_offset_data::update)
1431         (print_offset_data::finish): Likewise.
1432         * xtensa-tdep.c (xtensa_store_return_value)
1433         (xtensa_push_dummy_call): Likewise.
1434
1435 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1436
1437         * windows-nat.c (display_selector): Fixed format specifications
1438         for 64-bit Cygwin.
1439
1440 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1441
1442         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1443
1444 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1445
1446         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1447         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1448         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1449         (nios2_linux_init_abi): Install it.
1450
1451 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1452
1453         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1454
1455 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1456
1457         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1458
1459 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1460             Tom Tromey  <tromey@adacore.com>
1461
1462         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1463
1464 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1465
1466         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1467         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1468         method to compute the bounds of range types. Also print "[evaluated]"
1469         if the bounds' values come from a dynamic evaluation.
1470
1471 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1474         whitespace when pretty printing is on.
1475
1476 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1477
1478         * ppc-linux-nat.c: Add include.
1479
1480 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1481
1482         * NEWS: Mention AArch64 Pointer Authentication.
1483
1484 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1485
1486         * arm-linux-nat.c: Add include.
1487
1488 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1489
1490         * source-cache.c (source_cache::get_source_lines): Re-read
1491         fullname after calling open_source_file.
1492
1493 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1494
1495         * NEWS: Mention TLS support for FreeBSD.
1496
1497 2019-03-25  Tom Tromey  <tromey@adacore.com>
1498
1499         * minsyms.c (BUNCH_SIZE): Update comment.
1500         (~minimal_symbol_reader): Remove old comment.
1501         (compact_minimal_symbols): Update comment.
1502         (minimal_symbol_reader::install): Remove old comment.  Update
1503         other comments.
1504
1505 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1506
1507         * s390-linux-nat.c: Add include.
1508
1509 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1510
1511         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1512         Call linux_get_hwcap.
1513         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1514         Likewise.
1515         (aarch64_linux_get_hwcap): Remove function.
1516         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1517         declaration.
1518         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1519         linux_get_hwcap.
1520         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1521         * linux-tdep.c (linux_get_hwcap): Add function.
1522         (linux_get_hwcap2): Likewise.
1523         * linux-tdep.h (linux_get_hwcap): Add declaration.
1524         (linux_get_hwcap2): Likewise.
1525         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1526         (ppc_linux_get_hwcap2): Likewise.
1527         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1528         linux_get_hwcap.
1529         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1530         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1531         (ppc_linux_nat_target::read_description): Likewise.
1532         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1533         * s390-linux-nat.c: Likewise.
1534         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1535
1536 2019-03-24  Tom Tromey  <tom@tromey.com>
1537
1538         * ada-lang.c (standard_lookup): Simplify initialization.
1539         (ada_lookup_symbol_nonlocal): Simplify return.
1540         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1541         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1542         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1543         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1544         initialization.
1545         * solib.c (solib_global_lookup): Simplify.
1546         * symtab.c (null_block_symbol): Remove.
1547         (symbol_cache_lookup): Simplify returns.
1548         (lookup_language_this): Simplify returns.
1549         (lookup_symbol_aux): Simplify return.
1550         (lookup_local_symbol): Simplify returns.
1551         (lookup_global_symbol_from_objfile): Simplify return.
1552         (lookup_symbol_in_objfile_symtabs)
1553         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1554         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1555         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1556         * cp-namespace.c (cp_lookup_bare_symbol)
1557         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1558         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1559         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1560         (cp_lookup_symbol_via_imports): Simplify initialization.
1561         (find_symbol_in_baseclass): Likewise.
1562         * symtab.h (null_block_symbol): Remove.
1563         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1564         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1565         (d_lookup_symbol_module): Likewise.
1566         (find_symbol_in_baseclass): Simplify initialization.
1567
1568 2019-03-24  Tom Tromey  <tom@tromey.com>
1569
1570         * expression.h: Don't include symtab.h.
1571         (struct block): Forward declare.
1572
1573 2019-03-24  Tom Tromey  <tom@tromey.com>
1574
1575         * c-exp.y (typebase): Remove casts.
1576         * gdbtypes.c (lookup_unsigned_typename, )
1577         (lookup_signed_typename): Remove cast.
1578         * eval.c (parse_to_comma_and_eval): Remove cast.
1579         * parse.c (write_dollar_variable): Remove cast.
1580         * block.h (struct block) <superblock>: Now const.
1581         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1582         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1583         (map_block): Make "block" const.
1584         * symfile.h (struct quick_symbol_functions)
1585         <map_matching_symbols>: Constify block argument to "callback".
1586         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1587         const.
1588         (find_pc_sect_compunit_symtab): Make "b" const.
1589         (find_symbol_at_address): Likewise.
1590         (search_symbols): Likewise.
1591         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1592         (dw2_debug_names_lookup_symbol): Likewise.
1593         (dw2_map_matching_symbols): Update.
1594         * p-valprint.c (pascal_val_print): Remove "block".
1595         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1596         (aux_add_nonlocal_symbols): Make "block" const.
1597         (resolve_subexp): Remove cast.
1598         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1599         const.
1600         (iterate_over_file_blocks): Likewise.
1601         * f-exp.y (%union) <bval>: Remove.
1602         * coffread.c (patch_opaque_types): Make "b" const.
1603         * spu-tdep.c (spu_catch_start): Make "block" const.
1604         * c-valprint.c (print_unpacked_pointer): Remove "block".
1605         * symmisc.c (dump_symtab_1): Make "b" const.
1606         (block_depth): Make "block" const.
1607         * d-exp.y (%union) <bval>: Remove.
1608         * cp-support.h (cp_lookup_rtti_type): Update.
1609         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1610         * psymtab.c (psym_lookup_symbol): Make "block" const.
1611         (maintenance_check_psymtabs): Make "b" const.
1612         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1613         (enumerate_locals, enumerate_args): Update.
1614         * python/py-symtab.c (stpy_global_block): Make "block" const.
1615         (stpy_static_block): Likewise.
1616         * inline-frame.c (block_starting_point_at): Make "new_block"
1617         const.
1618         * block.c (find_block_in_blockvector): Make return type const.
1619         (blockvector_for_pc_sect): Make "b" const.
1620         (find_block_in_blockvector): Make "b" const.
1621
1622 2019-03-23  Tom Tromey  <tom@tromey.com>
1623
1624         * varobj.c (varobj_create): Update.
1625         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1626         * printcmd.c (display_command, do_one_display): Don't reset
1627         innermost_block.
1628         * parser-defs.h (enum innermost_block_tracker_type): Move to
1629         expression.h.
1630         (innermost_block): Update comment.
1631         * parse.c (parse_exp_1): Add tracker_types parameter.
1632         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1633         tracker_types parameter.  Reset innermost_block.
1634         (parse_exp_in_context): Remove.
1635         (parse_expression_for_completion): Update.
1636         * objfiles.c (~objfile): Don't reset expression_context_block or
1637         innermost_block.
1638         * expression.h (enum innermost_block_tracker_type): Move from
1639         parser-defs.h.
1640         (parse_exp_1): Add tracker_types parameter.
1641         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1642         reset innermost_block.
1643
1644 2019-03-23  Tom Tromey  <tom@tromey.com>
1645
1646         * objfiles.h: Include bcache.h.
1647
1648 2019-03-23  Tom Tromey  <tom@tromey.com>
1649
1650         * linespec.c (get_current_search_block): Use
1651         scoped_restore_current_language.
1652         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1653
1654 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1655             Jiong Wang  <jiong.wang@arm.com>
1656
1657         * aarch64-linux-tdep.c
1658         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1659         section.
1660         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1661
1662 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1663             Jiong Wang  <jiong.wang@arm.com>
1664
1665         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1666         instructions.
1667         (aarch64_analyze_prologue_test): Add PACIASP test.
1668         (aarch64_prologue_prev_register): Unmask PC value.
1669
1670 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1671             Jiong Wang  <jiong.wang@arm.com>
1672
1673         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1674         (aarch64_dwarf2_prev_register): Unmask PC value.
1675         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1676         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1677         DW_CFA_AARCH64_negate_ra_state.
1678         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1679
1680 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1681             Jiong Wang  <jiong.wang@arm.com>
1682
1683         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1684         registers.
1685         (aarch64_pseudo_register_name): Likewise.
1686         (aarch64_pseudo_register_type): Likewise.
1687         (aarch64_pseudo_register_reggroup_p): Likewise.
1688         (aarch64_gdbarch_init): Add pauth registers.
1689         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1690         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1691         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1692         (struct gdbarch_tdep): Add regnum for ra_state.
1693
1694 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1695             Jiong Wang  <jiong.wang@arm.com>
1696
1697         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1698
1699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1700             Jiong Wang  <jiong.wang@arm.com>
1701
1702         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1703         function.
1704         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1705         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1706         (aarch64_gdbarch_init): Add puth registers.
1707         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1708         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1709         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1710
1711 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1712             Jiong Wang  <jiong.wang@arm.com>
1713
1714         * aarch64-linux-nat.c
1715         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1716         * aarch64-linux-tdep.c
1717         (aarch64_linux_core_read_description): Likewise.
1718         (aarch64_linux_get_hwcap): New function.
1719         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1720         (aarch64_linux_get_hwcap): New declaration.
1721
1722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1723             Jiong Wang  <jiong.wang@arm.com>
1724
1725         * aarch64-linux-nat.c
1726         (aarch64_linux_nat_target::read_description): Add pauth param.
1727         * aarch64-linux-tdep.c
1728         (aarch64_linux_core_read_description): Likewise.
1729         * aarch64-tdep.c (struct target_desc): Add in pauth.
1730         (aarch64_read_description): Add pauth param.
1731         (aarch64_gdbarch_init): Likewise.
1732         * aarch64-tdep.h (aarch64_read_description): Likewise.
1733         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1734         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1735         * features/Makefile: Add new files.
1736         * features/aarch64-pauth.c: New file.
1737         * features/aarch64-pauth.xml: New file.
1738
1739 2019-03-20  Tom Tromey  <tromey@adacore.com>
1740
1741         * infrun.c (handle_inferior_event): Rename from
1742         handle_inferior_event_1.  Create a scoped_value_mark.
1743         (handle_inferior_event): Remove.
1744
1745 2019-03-19  Tom Tromey  <tromey@adacore.com>
1746
1747         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1748         * infrun.h (print_stop_event): Add "displays" parameter.
1749         * infrun.c (print_stop_event): Add "displays" parameter.
1750
1751 2019-03-19  Pedro Alves  <palves@redhat.com>
1752
1753         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1754         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1755         to -1.  Fix TABs vs spaces.
1756         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1757         * tui/tui-out.h (tui_ui_out) Add intro comments.
1758         <m_line, m_start_of_line>: In-class initialize, and add describing
1759         comment.
1760
1761 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1762
1763         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1764         variable names.
1765         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1766
1767 2019-03-18  Pedro Alves  <palves@redhat.com>
1768             Eli Zaretskii <eliz@gnu.org>
1769
1770         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1771         m_line and m_start_of_line.
1772
1773 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1774
1775         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1776         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1777         it returns a newline.  This fixes a regression in TU mode, whereby
1778         the next line is output on the same screen line as the user input.
1779
1780 2019-03-18  Tom Tromey  <tromey@adacore.com>
1781
1782         * minsyms.c (minimal_symbol_reader::install): Remove call to
1783         obstack_blank.
1784
1785 2019-03-18  Pedro Alves  <palves@redhat.com>
1786
1787         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1788         New globals.
1789         (apply_style): New, factored out from ...
1790         (apply_ansi_escape): ... this.  Handle reverse video mode.
1791         (tui_set_reverse_mode): New function.
1792         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1793         * tui/tui-winsource.c (tui_show_source_line): Use
1794         tui_set_reverse_mode instead of setting A_STANDOUT.
1795         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1796         New setter methods.
1797
1798 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1799
1800         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1801         Handle tabs.
1802
1803 2019-03-18  Tom Tromey  <tromey@adacore.com>
1804
1805         * ada-lang.c (empty_array): Add "high" parameter.
1806         (ada_evaluate_subexp): Update.
1807
1808 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1809
1810         * unittests/string_view-selftests.c: Define
1811         _initialize_string_view_selftests unconditionally.
1812
1813 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1814
1815         PR gdb/24350
1816         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1817
1818 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1819
1820         PR gdb/24351
1821         * windows-nat.c (display_selector): Fix format specifiers.
1822
1823 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1824
1825         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1826         tui_refill_source_window instead of tui_refresh_win, to update the
1827         current execution line.  This fixes redisplay of the current line
1828         when stepping through the code with "next" or "step".
1829
1830 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1831
1832         * source-cache.c (source_cache::get_source_lines): Call
1833         find_source_lines to initialize s->nlines.  This fixes vertical
1834         scrolling of TUI source window when the DOWN arrow is pressed.
1835
1836 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1837
1838         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1839         linux-thread-db.c (_initialize_thread_db): Likewise.
1840
1841 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1842
1843         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1844         wclrtoeol in tui_show_source_line".  This reverts changes made in
1845         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1846
1847 2019-03-15  Tom Tromey  <tom@tromey.com>
1848
1849         * symtab.h (struct minimal_symbol): Derive from
1850         general_symbol_info.
1851         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1852         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1853         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1854         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1855         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1856         (MSYMBOL_SEARCH_NAME): Update.
1857         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1858         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1859         * minsyms.c (minimal_symbol_reader::record_full): Update.
1860
1861 2019-03-15  Tom Tromey  <tom@tromey.com>
1862
1863         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1864
1865 2019-03-15  Tom Tromey  <tom@tromey.com>
1866
1867         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1868         unique_xmalloc_ptr.
1869         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1870         Update.
1871         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1872         (build_minimal_symbol_hash_tables)
1873         (minimal_symbol_reader::install): Update.
1874
1875 2019-03-15  Tom Tromey  <tom@tromey.com>
1876
1877         * symtab.c (create_demangled_names_hash): Update.
1878         (symbol_set_names): Update.
1879         * objfiles.h (struct objfile_per_bfd_storage)
1880         <demangled_names_hash>: Now an htab_up.
1881         * objfiles.c (objfile_per_bfd_storage): Simplify.
1882
1883 2019-03-15  Tom Tromey  <tom@tromey.com>
1884
1885         * objfiles.h (struct objfile_per_bfd_storage): Declare
1886         destructor.
1887         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1888         New.
1889         (get_objfile_bfd_data): Use new.  Don't initialize
1890         language_of_main.
1891         (free_objfile_per_bfd_storage): Remove.
1892         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1893
1894 2019-03-15  Tom Tromey  <tom@tromey.com>
1895
1896         * symfile.c (reread_symbols): Update.
1897         * objfiles.c (objfile::objfile): Update.
1898         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1899         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1900         comment.
1901         (minimal_symbol_reader::install): Update.
1902         (terminate_minimal_symbol_table): Remove.
1903         * jit.c (jit_object_close_impl): Update.
1904
1905 2019-03-15  Tom Tromey  <tom@tromey.com>
1906
1907         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1908         initializations.
1909
1910 2019-03-15  Tom Tromey  <tom@tromey.com>
1911
1912         * objfiles.h (struct objfile_per_bfd_storage)
1913         <demangled_hash_languages>: Now a bitset.
1914         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1915         (lookup_minimal_symbol): Update.
1916
1917 2019-03-15  Tom Tromey  <tom@tromey.com>
1918
1919         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1920         Don't return the symbol.
1921         * coffread.c (record_minimal_symbol): Use record_full.
1922
1923 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1924
1925         The MS-Windows port of ncurses fails to switch to a color pair if
1926         one or both of the colors are the implicit default colors.  This
1927         change records the default colors when TUI is initialized, and
1928         then specifies them explicitly when a color pair uses the default
1929         colors.  This allows color styling in TUI mode on MS-Windows.
1930
1931         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1932         ncurses_norm_attr.
1933         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1934         colors in ncurses_norm_attr.
1935         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1936         "none", replace it with the default color recorded in
1937         ncurses_norm_attr.
1938
1939 2019-03-14  Tom Tromey  <tromey@adacore.com>
1940
1941         * source-cache.h (class source_cache) <get_source_lines>: Return
1942         std::string.
1943         * source-cache.c (source_cache::extract_lines): Handle case where
1944         first_pos==npos.  Return std::string.
1945         (source_cache::get_source_lines): Update.
1946
1947 2019-03-14  Tom Tromey  <tromey@adacore.com>
1948
1949         * NEWS: Add item for "style sources" commands.
1950         * source-cache.c (source_cache::get_source_lines): Check
1951         source_styling.
1952         * cli/cli-style.c (source_styling): New global.
1953         (_initialize_cli_style): Add "style sources" commands.
1954         (show_style_sources): New function.
1955         * cli/cli-style.h (source_styling): Declare.
1956
1957 2019-03-14  Pedro Alves  <palves@redhat.com>
1958             Tom Tromey  <tromey@adacore.com>
1959
1960         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1961         * tui/tui-winsource.c (tui_refill_source_window): New function,
1962         from...
1963         (tui_horizontal_source_scroll): ... here.  Move some logic.
1964         * cli/cli-style.c (set_style_enabled): Notify new observable.
1965         * tui/tui-hooks.c (tui_redisplay_source): New function.
1966         (tui_attach_detach_observers): Attach or detach
1967         tui_redisplay_source.
1968         * observable.h (source_styling_changed): New observable.
1969         * observable.c: Define source_styling_changed observable.
1970
1971 2019-03-13  Tom Tromey  <tromey@adacore.com>
1972
1973         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1974         (i386_gnu_nat_target::store_registers): Update.
1975         * target-debug.h (target_debug_print_std_string): New macro.
1976         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1977         * windows-tdep.c (display_one_tib): Update.
1978         * tui/tui-stack.c (tui_make_status_line): Update.
1979         * top.c (print_inferior_quit_action): Update.
1980         * thread.c (thr_try_catch_cmd): Update.
1981         (add_thread_with_info): Update.
1982         (thread_target_id_str): Update.
1983         (thr_try_catch_cmd): Update.
1984         (thread_command): Update.
1985         (thread_find_command): Update.
1986         * record-btrace.c (record_btrace_target::info_record)
1987         (record_btrace_resume_thread, record_btrace_target::resume)
1988         (record_btrace_cancel_resume, record_btrace_step_thread)
1989         (record_btrace_target::wait, record_btrace_target::wait)
1990         (record_btrace_target::wait, record_btrace_target::stop): Update.
1991         * progspace.c (print_program_space): Update.
1992         * process-stratum-target.c
1993         (process_stratum_target::thread_address_space): Update.
1994         * linux-fork.c (linux_fork_mourn_inferior)
1995         (detach_checkpoint_command, info_checkpoints_command)
1996         (linux_fork_context): Update.
1997         (linux_fork_detach): Update.
1998         (class scoped_switch_fork_info): Update.
1999         (delete_checkpoint_command): Update.
2000         * infrun.c (follow_fork_inferior): Update.
2001         (follow_fork_inferior): Update.
2002         (proceed_after_vfork_done): Update.
2003         (handle_vfork_child_exec_or_exit): Update.
2004         (follow_exec): Update.
2005         (displaced_step_prepare_throw): Update.
2006         (displaced_step_restore): Update.
2007         (start_step_over): Update.
2008         (resume_1): Update.
2009         (clear_proceed_status_thread): Update.
2010         (proceed): Update.
2011         (print_target_wait_results): Update.
2012         (do_target_wait): Update.
2013         (context_switch): Update.
2014         (stop_all_threads): Update.
2015         (restart_threads): Update.
2016         (finish_step_over): Update.
2017         (handle_signal_stop): Update.
2018         (switch_back_to_stepped_thread): Update.
2019         (keep_going_pass_signal): Update.
2020         (print_exited_reason): Update.
2021         (normal_stop): Update.
2022         * inferior.c (inferior_pid_to_str): Change return type.
2023         (print_selected_inferior): Update.
2024         (add_inferior): Update.
2025         (detach_inferior): Update.
2026         * dummy-frame.c (fprint_dummy_frames): Update.
2027         * dcache.c (dcache_info_1): Update.
2028         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2029         (btrace_fetch, btrace_clear): Update.
2030         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2031         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2032         type.
2033         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2034         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2035         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2036         * gdbarch.c, gdbarch.h: Rebuild.
2037         * gdbarch.sh (core_pid_to_str): Change return type.
2038         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2039         return type.
2040         (windows_nat_target::pid_to_str): Change return type.
2041         (windows_delete_thread): Update.
2042         (windows_nat_target::attach): Update.
2043         (windows_nat_target::files_info): Update.
2044         * target-delegates.c: Rebuild.
2045         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2046         return type.
2047         (sol_thread_target::pid_to_str): Change return type.
2048         * remote.c (class remote_target) <pid_to_str>: Change return
2049         type.
2050         (remote_target::pid_to_str): Change return type.
2051         (extended_remote_target::attach, remote_target::remote_stop_ns)
2052         (remote_target::remote_notif_remove_queued_reply)
2053         (remote_target::push_stop_reply, remote_target::disable_btrace):
2054         Update.
2055         (extended_remote_target::attach): Update.
2056         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2057         type.
2058         (gdbsim_target::pid_to_str): Change return type.
2059         * ravenscar-thread.c (struct ravenscar_thread_target)
2060         <pid_to_str>: Change return type.
2061         (ravenscar_thread_target::pid_to_str): Change return type.
2062         * procfs.c (class procfs_target) <pid_to_str>: Change return
2063         type.
2064         (procfs_target::pid_to_str): Change return type.
2065         (procfs_target::attach): Update.
2066         (procfs_target::detach): Update.
2067         (procfs_target::fetch_registers): Update.
2068         (procfs_target::store_registers): Update.
2069         (procfs_target::wait): Update.
2070         (procfs_target::files_info): Update.
2071         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2072         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2073         return type.
2074         (nto_procfs_target::pid_to_str): Change return type.
2075         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2076         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2077         return type.
2078         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2079         (exit_lwp): Update.
2080         (attach_proc_task_lwp_callback, get_detach_signal)
2081         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2082         (linux_nat_target::resume, wait_lwp, stop_callback)
2083         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2084         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2085         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2086         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2087         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2088         type.
2089         (inf_ptrace_target::attach): Update.
2090         (inf_ptrace_target::files_info): Update.
2091         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2092         type.
2093         (go32_nat_target::pid_to_str): Change return type.
2094         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2095         (gnu_nat_target::wait): Update.
2096         (gnu_nat_target::wait): Update.
2097         (gnu_nat_target::resume): Update.
2098         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2099         (fbsd_nat_target::wait): Update.
2100         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2101         type.
2102         (darwin_nat_target::attach): Update.
2103         * corelow.c (class core_target) <pid_to_str>: Change return type.
2104         (core_target::pid_to_str): Change return type.
2105         * target.c (normal_pid_to_str): Change return type.
2106         (default_pid_to_str): Likewise.
2107         (target_pid_to_str): Change return type.
2108         (target_translate_tls_address): Update.
2109         (target_announce_detach): Update.
2110         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2111         return type.
2112         (bsd_uthread_target::pid_to_str): Change return type.
2113         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2114         type.
2115         (bsd_kvm_target::pid_to_str): Change return type.
2116         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2117         return type.
2118         (aix_thread_target::pid_to_str): Change return type.
2119         * target.h (struct target_ops) <pid_to_str>: Change return type.
2120         (target_pid_to_str, normal_pid_to_str): Likewise.
2121         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2122         type.
2123         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2124         type.
2125         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2126         return type.
2127         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2128         type.
2129         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2130         type.
2131         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2132         return type.
2133
2134 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2135
2136         * NEWS: Mention that the new default MI version is 3.  Mention
2137         changes to the output of commands and events that deal with
2138         multi-location breakpoints.
2139         * breakpoint.c: Include "mi/mi-out.h".
2140         (print_one_breakpoint): Change output syntax if using MI version
2141         >= 3.
2142         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2143         New.
2144         (mi_multi_location_breakpoint_output_fixed): New.
2145         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2146         (mi_cmd_fix_multi_location_breakpoint_output): New.
2147         (mi_multi_location_breakpoint_output_fixed): New.
2148         * mi/mi-cmds.c (mi_cmds): Register command
2149         -fix-multi-location-breakpoint-output.
2150         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2151         interpreter "mi".
2152
2153 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2154
2155         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2156         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2157         instantiate mi_ui_out based on interpreter name.
2158         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2159         * mi/mi-main.c (mi_load_progress): Likewise.
2160
2161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2162
2163         * NEWS: Combine separate "New targets" sections for 8.3.
2164
2165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2166
2167         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2168         (ppcfbsd_init_abi): Install gdbarch
2169         "fetch_tls_load_module_address" and "get_thread_local_address"
2170         methods.
2171
2172 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2173
2174         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2175         (riscv_fbsd_init_abi): Install gdbarch
2176         "fetch_tls_load_module_address" and "get_thread_local_address"
2177         methods.
2178
2179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2180
2181         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2182         (i386fbsd_init_abi): Install gdbarch
2183         "fetch_tls_load_module_address" and "get_thread_local_address"
2184         methods.
2185
2186 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2187
2188         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2189         (amd64fbsd_init_abi): Install gdbarch
2190         "fetch_tls_load_module_address" and "get_thread_local_address"
2191         methods.
2192
2193 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2194
2195         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2196         (struct fbsd_pspace_data): New type.
2197         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2198         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2199         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2200         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2201         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2202
2203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2204
2205         * gdbtypes.c (lookup_struct_elt): New function.
2206         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2207         * gdbtypes.h (struct struct_elt): New type.
2208         (lookup_struct_elt): New prototype.
2209
2210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2211
2212         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2213         remove disabled code block.
2214
2215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2216
2217         * gdbarch.sh (get_thread_local_address): New method.
2218         * gdbarch.h, gdbarch.c: Regenerate.
2219         * target.c (target_translate_tls_address): Use
2220         gdbarch_get_thread_local_address if present instead of
2221         target::get_thread_local_address.
2222
2223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2224
2225         * target.h (target::get_thread_local_address): Update comment.
2226
2227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2228
2229         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2230         objfile->separate_debug_objfile_backlink if not NULL.
2231
2232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2233
2234         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2235         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2236         (amd64bsd_store_inferior_registers): Likewise.
2237         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2238         Enable segment base registers.
2239         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2240         PT_GETFSBASE and PT_GETGSBASE.
2241         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2242         PT_SETGSBASE.
2243         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2244         segment base registers.
2245         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2246
2247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2248
2249         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2250         Update calls to i386_target_description to add 'segments'
2251         parameter.
2252         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2253         add segment base registers.
2254         * arch/i386.c (i386_create_target_description): Add 'segments'
2255         parameter to enable segment base registers.
2256         * arch/i386.h (i386_create_target_description): Likewise.
2257         * features/i386/32bit-segments.xml: New file.
2258         * features/i386/32bit-segments.c: Generate.
2259         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2260         call to i386_target_description to add 'segments' parameter.
2261         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2262         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2263         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2264         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2265         if feature is present.
2266         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2267         Add 'segments' parameter to call to i386_target_description.
2268         (i386_target_description): Add 'segments' parameter to enable
2269         segment base registers.
2270         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2271         to call to i386_target_description.
2272         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2273         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2274         Define I386_NUM_REGS.
2275         (i386_target_description): Add 'segments' parameter to enable
2276         segment base registers.
2277
2278 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2279
2280         PR/24325
2281         * source-cache.c: #undef open and close, to avoid unresolved
2282         externals during linking.
2283
2284 2019-03-12  Tom Tromey  <tromey@adacore.com>
2285
2286         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2287         const.  Add initializers.
2288         (_initialize_remote): Don't initialize ptid globals.
2289
2290 2019-03-12  Pedro Alves  <palves@redhat.com>
2291
2292         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2293
2294 2019-03-12  Pedro Alves  <palves@redhat.com>
2295
2296         * cp-name-parser.y (main): Remove unused 'len' variable.
2297
2298 2019-03-12  Tom Tromey  <tromey@adacore.com>
2299
2300         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2301         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2302
2303 2019-03-12  Tom Tromey  <tromey@adacore.com>
2304
2305         * linux-nat.c (iterate_over_lwps): Update.
2306         (stop_callback): Remove parameter.
2307         (stop_wait_callback, detach_callback, resume_set_callback)
2308         (select_singlestep_lwp_callback, set_ignore_sigint)
2309         (status_callback, resumed_callback, resume_clear_callback)
2310         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2311         data parameter.
2312         (linux_nat_target::detach, linux_nat_target::resume)
2313         (linux_stop_and_wait_all_lwps, select_event_lwp)
2314         (linux_nat_filter_event, linux_nat_wait_1)
2315         (linux_nat_target::kill, linux_nat_target::stop)
2316         (linux_nat_target::stop): Update.
2317         (linux_nat_resume_callback): Change type.
2318         (resume_stopped_resumed_lwps, count_events_callback)
2319         (select_event_lwp_callback): Likewise.
2320         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2321         * arm-linux-nat.c (struct update_registers_data): Remove.
2322         (update_registers_callback): Change type.
2323         (arm_linux_insert_hw_breakpoint1): Update.
2324         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2325         parameter.
2326         (x86_linux_dr_set_addr): Update.
2327         (x86_linux_dr_set_control): Update.
2328         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2329         (iterate_over_lwps): Use gdb::function_view.
2330         * nat/aarch64-linux-hw-point.c (struct
2331         aarch64_dr_update_callback_param): Remove.
2332         (debug_reg_change_callback): Change type.
2333         (aarch64_notify_debug_reg_change): Update.
2334         * s390-linux-nat.c (s390_refresh_per_info): Update.
2335
2336 2019-03-11  Tom Tromey  <tromey@adacore.com>
2337
2338         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2339         redundant assignment to "this_cu".
2340
2341 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2342
2343         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2344
2345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2346
2347         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2348         from...
2349         (rank_one_type): ... this.
2350
2351 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2352
2353         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2354         from...
2355         (rank_one_type): ... this.
2356
2357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2358
2359         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2360         from...
2361         (rank_one_type): ... this.
2362
2363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2364
2365         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2366         from...
2367         (rank_one_type): ... this.
2368
2369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2370
2371         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2372         from...
2373         (rank_one_type): ... this.
2374
2375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2376
2377         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2378         from...
2379         (rank_one_type): ... this.
2380
2381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2382
2383         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2384         from...
2385         (rank_one_type): ... this.
2386
2387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2388
2389         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2390         from...
2391         (rank_one_type): ... this.
2392
2393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2394
2395         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2396         from...
2397         (rank_one_type): ... this.
2398
2399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2400
2401         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2402         from...
2403         (rank_one_type): ... this.
2404
2405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2406
2407         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2408         from...
2409         (rank_one_type): ... this.
2410
2411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2412
2413         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2414         from...
2415         (rank_one_type): ... this.
2416
2417 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2418
2419         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2420         inferior-events' shows the example events.
2421
2422 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2423
2424         Support styling on native MS-Windows console
2425
2426         PR/24315
2427         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2428         on MS-Windows if $TERM is not defined.
2429
2430         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2431
2432         * posix-hdep.c (gdb_console_fputs):
2433         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2434         functions.
2435         * ui-file.h (gdb_console_fputs): Add prototype.
2436
2437         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2438         back to fputs only if the former returns zero.
2439
2440 2019-03-07  Tom Tromey  <tom@tromey.com>
2441
2442         * symmisc.c (print_symbol_bcache_statistics): Update.
2443         (print_objfile_statistics): Update.
2444         * symfile.c (allocate_symtab): Update.
2445         * stabsread.c: Don't include bcache.h.
2446         * psymtab.h (struct psymbol_bcache): Don't declare.
2447         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2448         (psymbol_bcache_init, psymbol_bcache_free)
2449         (psymbol_bcache_get_bcache): Don't declare.
2450         * psymtab.c (struct psymbol_bcache): Remove.
2451         (psymtab_storage::psymtab_storage): Update.
2452         (psymtab_storage::~psymtab_storage): Update.
2453         (psymbol_bcache_init, psymbol_bcache_free)
2454         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2455         (add_psymbol_to_bcache): Update.
2456         (allocate_psymtab): Update.
2457         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2458         macro_cache>: No longer pointers.
2459         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2460         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2461         * macrotab.c (macro_bcache): Update.
2462         * macroexp.c: Don't include bcache.h.
2463         * gdbtypes.c (check_types_worklist): Update.
2464         (types_deeply_equal): Remove TRY/CATCH.  Update.
2465         * elfread.c (elf_symtab_read): Update.
2466         * dwarf2read.c: Don't include bcache.h.
2467         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2468         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2469         (print_bcache_statistics, bcache_memory_used): Don't declare.
2470         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2471         methods.  Rename all data members.
2472         * bcache.c (struct bcache): Move to bcache.h.
2473         (bcache::expand_hash_table): Rename from expand_hash_table.
2474         (bcache): Remove.
2475         (bcache::insert): Rename from bcache_full.
2476         (bcache::compare): Rename from bcache_compare.
2477         (bcache_xmalloc): Remove.
2478         (bcache::~bcache): Rename from bcache_xfree.
2479         (bcache::print_statistics): Rename from print_bcache_statistics.
2480         (bcache::memory_used): Rename from bcache_memory_used.
2481
2482 2019-03-07  Pedro Alves  <palves@redhat.com>
2483
2484         * infrun.c (normal_stop): Also check for
2485         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2486
2487 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * f-lang.c (value_from_host_double): Moved to...
2490         * value.c (value_from_host_double): ...here.
2491         * value.h (value_from_host_double): Declare.
2492         * guile/scm-math.c (vlscm_convert_typed_number): Use
2493         value_from_host_double.
2494         (vlscm_convert_number): Likewise.
2495         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2496         * python/py-value.c (convert_value_from_python): Likewise.
2497
2498 2019-03-06  Tom Tromey  <tom@tromey.com>
2499
2500         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2501
2502 2019-03-06  Tom Tromey  <tom@tromey.com>
2503
2504         * utils.h (free_current_contents): Don't declare.
2505         * utils.c (free_current_contents): Remove.
2506
2507 2019-03-06  Tom Tromey  <tom@tromey.com>
2508
2509         * top.c (quit_force): Update.
2510         * main.c (captured_command_loop): Update.
2511         * common/new-op.c (operator new): Update.
2512         * common/common-exceptions.c (struct catcher)
2513         <save_cleanup_chain>: Remove member.
2514         (exceptions_state_mc_init): Update.
2515         (exception_try_scope_entry): Return nullptr.
2516         (exception_try_scope_exit, exception_rethrow)
2517         (throw_exception_sjlj, throw_exception_cxx): Update.
2518         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2519         (all_cleanups, do_cleanups, discard_cleanups)
2520         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2521         (restore_cleanups, restore_final_cleanups): Don't declare.
2522         (do_final_cleanups): Remove parameter.
2523         * common/cleanups.c (cleanup_chain, make_cleanup)
2524         (make_cleanup_dtor, all_cleanups, do_cleanups)
2525         (discard_my_cleanups, discard_cleanups)
2526         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2527         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2528         (null_cleanup): Remove.
2529         (do_final_cleanups): Remove parameter.
2530
2531 2019-03-06  Tom Tromey  <tom@tromey.com>
2532
2533         * remote.c (remote_target::remote_parse_stop_reply): Use
2534         unique_xmalloc_ptr.
2535
2536 2019-03-06  Tom Tromey  <tom@tromey.com>
2537
2538         * stabsread.c (struct stabs_field_info): Rename from field_info.
2539         <list, fnlist>: Add initializers.
2540         <obstack>: New member.
2541         (read_member_functions, read_struct_fields, read_baseclasses):
2542         Allocate on obstack.  Don't use cleanups.
2543         (read_one_struct_field, read_member_functions, read_struct_fields)
2544         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2545         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2546         (read_struct_type): Update.
2547
2548 2019-03-06  Tom Tromey  <tom@tromey.com>
2549
2550         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2551         * common/filestuff.h (make_cleanup_close): Don't declare.
2552         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2553         Remove.
2554
2555 2019-03-06  Tom Tromey  <tom@tromey.com>
2556
2557         * solib-aix.c: Use make_scope_exit.
2558
2559 2019-03-06  Tom Tromey  <tom@tromey.com>
2560
2561         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2562         Use make_scope_exit.
2563
2564 2019-03-06  Tom Tromey  <tom@tromey.com>
2565
2566         * solib-svr4.c (disable_probes_interface): Remove parameter.
2567         (svr4_handle_solib_event): Use make_scope_exit.
2568
2569 2019-03-06  Tom Tromey  <tom@tromey.com>
2570
2571         * remote.c (struct stop_reply_deleter): Remove.
2572         (stop_reply_up): Update.
2573         (struct stop_reply): Derive from notif_event.  Don't typedef.
2574         <regcache>: Now a std::vector.
2575         (stop_reply_xfree): Remove.
2576         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2577         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2578         (remote_target::discard_pending_stop_replies): Use delete.
2579         (remote_target::remote_parse_stop_reply): Update.
2580         (remote_target::process_stop_reply): Update.
2581         * remote-notif.h (struct notif_event): Add virtual destructor.
2582         Remove "dtr" member.
2583         (struct notif_client) <alloc_event>: Return a unique_ptr.
2584         (notif_event_xfree): Don't declare.
2585         (notif_event_up): New typedef.
2586         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2587         (notif_event_xfree, do_notif_event_xfree): Remove.
2588         (remote_notif_state_xfree): Update.
2589
2590 2019-03-06  Tom Tromey  <tom@tromey.com>
2591
2592         * infrun.c (displaced_step_clear_cleanup): Now a
2593         forward_scope_exit type.
2594         (displaced_step_prepare_throw): Update.
2595         (displaced_step_fixup): Update.
2596
2597 2019-03-06  Tom Tromey  <tom@tromey.com>
2598
2599         * inferior.h (class inferior): Update comment.
2600         * gdbthread.h (class thread_info): Update comment.
2601
2602 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2603             Tom Tromey  <tom@tromey.com>
2604
2605         * stabsread.h (struct stab_section_list): Remove.
2606         (coffstab_build_psymtabs): Update.
2607         * dbxread.c (symbuf_sections): Now a std::vector.
2608         (sect_idx): New global.
2609         (fill_symbuf): Update.
2610         (coffstab_build_psymtabs): Change type of stabsects parameter.
2611         Update.
2612         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2613         std::vector.
2614         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2615         (coff_locate_sections): Update.
2616         (coff_symfile_read): Remove cleanups.  Update.
2617         (init_stringtab): Add storage parameter.
2618         (free_stringtab, free_stringtab_cleanup): Remove.
2619         (init_lineno): Add storage parameter.
2620         (free_linetab, free_linetab_cleanup): Remove.
2621
2622 2019-03-06  Pedro Alves  <palves@redhat.com>
2623
2624         * linux-fork.c (fork_info::clobber_regs): Delete.
2625         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2626         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2627         comment.  Adjust.
2628         (scoped_switch_fork_info::scoped_switch_fork_info)
2629         (checkpoint_command, linux_fork_context): Adjust
2630         fork_save_infrun_state calls.
2631
2632 2019-03-06  Pedro Alves  <palves@redhat.com>
2633
2634         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2635         (inf_has_multiple_threads): Return 'bool' and rewrite using
2636         inferior_info::threads().
2637
2638 2019-03-06  Pedro Alves  <palves@redhat.com>
2639
2640         * linux-fork.c: Include <list>.
2641         (fork_list): Now a std::list instance.
2642         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2643         (forks_exist_p, find_last_fork): Adjust.
2644         (new_fork): Delete.
2645         (one_fork_p): New.
2646         (add_fork): Adjust.
2647         (free_fork): Delete, folded into fork_info::~fork_info().
2648         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2649         Adjust.
2650         (init_fork_list): Delete.
2651         (linux_fork_killall, linux_fork_mourn_inferior)
2652         (linux_fork_detach, info_checkpoints_command): Adjust.
2653         (_initialize_linux_fork): No longer call init_fork_list.
2654
2655 2019-03-06  Pedro Alves  <palves@redhat.com>
2656
2657         * linux-fork.c (new_fork): New, split out of ...
2658         (add_fork): ... this.  Return void.  Move "first fork" special
2659         case from here, to ...
2660         (checkpoint_command): ... here.
2661         * linux-linux.h (add_fork): Return void.
2662
2663 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2666
2667 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2668             Chris January  <chris.january@arm.com>
2669             David Lecomber  <david.lecomber@arm.com>
2670
2671         * f-exp.y: New token, UNOP_INTRINSIC.
2672         (exp): New pattern using UNOP_INTRINSIC token.
2673         (f77_keywords): Add 'abs' keyword.
2674         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2675         (value_from_host_double): New function.
2676         (evaluate_subexp_f): Support UNOP_ABS.
2677
2678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2681         types.
2682
2683 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2686         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2687         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2688
2689 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2692
2693 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2694             Chris January  <chris.january@arm.com>
2695
2696         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2697         * f-exp.y: Define 'KIND' token.
2698         (exp): New pattern for KIND expressions.
2699         (ptype): Handle types with a kind extension.
2700         (direct_abs_decl): Extend to spot kind extensions.
2701         (f77_keywords): Add 'kind' to the list.
2702         (push_kind_type): New function.
2703         (convert_to_kind_type): New function.
2704         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2705         * parse.c (operator_length_standard): Likewise.
2706         * parser-defs.h (enum type_pieces): Add tp_kind.
2707         * std-operator.def: Add UNOP_KIND.
2708
2709 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * f-exp.y (f_parse): Set yydebug.
2712
2713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * f-lang.c (evaluate_subexp_f): New function.
2716         (exp_descriptor_f): New global.
2717         (f_language_defn): Use exp_descriptor_f instead of
2718         exp_descriptor_standard.
2719
2720 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * f-exp.y (struct token): Add comments.
2723         (dot_ops): Remove uppercase versions and the end marker.
2724         (f77_keywords): Likewise.
2725         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2726         entries in the dot_ops array are case insensitive, and use
2727         strncasecmp to compare strings.  Also some whitespace cleanup in
2728         this area.  Similar for the f77_keywords array, except entries in
2729         this list might be case sensitive.
2730
2731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * f-exp.y (struct f77_boolean_val): Add comments.
2734         (boolean_values): Remove uppercase versions, and end marker.
2735         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2736         and use strncasecmp to achieve case insensitivity.  Additionally,
2737         perform whitespace cleanup around this code.
2738
2739 2019-03-06  Tom Tromey  <tromey@adacore.com>
2740
2741         * remote-sim.c (gdbsim_target_open): Use result of
2742         gdb_argv::release.
2743
2744 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2745         Dirk Schubert  <dirk.schubert@arm.com>
2746         Chris January  <chris.january@arm.com>
2747
2748         * eval.c (evaluate_subexp_standard): Call Fortran argument
2749         wrapping logic.
2750         * f-lang.c (struct value): A value which can be passed into a
2751         Fortran function call.
2752         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2753         where appropriate.
2754         (struct type): Value ready for a Fortran function call.
2755         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2756         is needed.
2757         * f-lang.h (fortran_argument_convert): Declaration.
2758         (fortran_preserve_arg_pointer): Declaration.
2759         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2760
2761 2019-03-05  Tom Tromey  <tromey@adacore.com>
2762
2763         * python/py-prettyprint.c (print_string_repr): Remove #if.
2764         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2765
2766 2019-03-05  Tom Tromey  <tromey@adacore.com>
2767
2768         * target.c (the_dummy_target): Move later.  Change type to
2769         "dummy_target".
2770         (initialize_targets): Don't initialize the_dummy_target.
2771
2772 2019-03-05  Tom Tromey  <tromey@adacore.com>
2773
2774         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2775         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2776
2777 2019-03-05  Tom Tromey  <tromey@adacore.com>
2778
2779         * windows-nat.c (windows_nat_target::attach)
2780         (windows_nat_target::detach): Don't call gdb_flush.
2781         * valprint.c (generic_val_print, val_print, val_print_string):
2782         Don't call gdb_flush.
2783         * utils.c (defaulted_query): Don't call gdb_flush.
2784         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2785         * target.c (target_announce_detach): Don't call gdb_flush.
2786         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2787         * remote.c (extended_remote_target::attach): Don't call
2788         gdb_flush.
2789         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2790         * printcmd.c (do_examine): Don't call gdb_flush.
2791         (info_display_command): Don't call gdb_flush.
2792         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2793         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2794         * memattr.c (info_mem_command): Don't call gdb_flush.
2795         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2796         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2797         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2798         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2799         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2800         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2801         (gnu_nat_target::detach): Don't call gdb_flush.
2802         * f-valprint.c (f_val_print): Don't call gdb_flush.
2803         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2804         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2805         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2806         gdb_flush.
2807         * c-valprint.c (c_val_print): Don't call gdb_flush.
2808         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2809
2810 2019-03-05  Tom Tromey  <tromey@adacore.com>
2811
2812         * varobj.c (update_dynamic_varobj_children): Update.
2813         (install_default_visualizer): Use reset, not release.
2814         * value.c (set_internalvar): Update.
2815         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2816         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2817         ATTRIBUTE_UNUSED_RESULT.
2818
2819 2019-03-05  Tom Tromey  <tromey@adacore.com>
2820
2821         * remote.c (class scoped_remote_fd) <release>: Add
2822         ATTRIBUTE_UNUSED_RESULT.
2823
2824 2019-03-05  Tom Tromey  <tromey@adacore.com>
2825
2826         * macroexp.c (struct macro_buffer) <release>: Add
2827         ATTRIBUTE_UNUSED_RESULT.
2828
2829 2019-03-05  Tom Tromey  <tromey@adacore.com>
2830
2831         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2832         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2833         ATTRIBUTE_UNUSED_RESULT.
2834
2835 2019-03-05  Tom Tromey  <tromey@adacore.com>
2836
2837         * common/scoped_fd.h (class scoped_fd) <release>: Add
2838         ATTRIBUTE_UNUSED_RESULT.
2839
2840 2019-03-05  Tom Tromey  <tromey@adacore.com>
2841
2842         * parser-defs.h (struct parser_state) <release>: Add
2843         ATTRIBUTE_UNUSED_RESULT.
2844
2845 2019-03-05  Tom Tromey  <tromey@adacore.com>
2846
2847         * utils.h (class gdb_argv) <release>: Add
2848         ATTRIBUTE_UNUSED_RESULT.
2849         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2850
2851 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2852
2853         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2854         for-loop range, to avoid compiler warnings.
2855
2856         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2857         avoid compiler warnings about unused variables.
2858
2859         * NEWS: Mention end of support for native debugging on MS-Windows
2860         before XP.
2861
2862         PR gdb/24292
2863         * common/netstuff.c:
2864         * gdbserver/gdbreplay.c
2865         * gdbserver/remote-utils.c:
2866         * ser-tcp.c:
2867         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2868         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2869         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2870         'getaddrinfo' and 'freeaddrinfo' were not available before
2871         Windows XP, and mingw.org's MinGW headers by default define
2872         _WIN32_WINNT to 0x500.
2873
2874 2019-03-01  Gary Benson <gbenson@redhat.com>
2875
2876         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2877
2878 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2879             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2880
2881         PR gdb/8527
2882         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2883         set_sigint_trap, clear_sigint_trap.
2884
2885 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2886
2887         * target.c (target_detach): Clear the regcache and the
2888         frame cache.
2889
2890 2019-02-27  Pedro Alves  <palves@redhat.com>
2891
2892         * utils.c (set_screen_size): When we cap the height/width sizes,
2893         tweak the corresponding command variable to show "unlimited":
2894
2895 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2896             Pedro Alves  <palves@redhat.com>
2897
2898         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2899         before calling rl_set_screen_size.
2900
2901 2019-02-27  Tom Tromey  <tromey@adacore.com>
2902
2903         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2904         define.
2905         * python/py-value.c: Remove Python 2.4 workaround.
2906         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2907         workaround.
2908         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2909         Python 2.4 workaround.
2910         * python/python-internal.h: Remove Python 2.4 comment.
2911         (Py_ssize_t): Don't define.
2912         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2913         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2914         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2915         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2916         * python/python.c (do_start_initialization): Remove Python 2.4
2917         workaround.
2918         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2919         (print_children): Remove Python 2.4 workaround.
2920         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2921         workaround.
2922         (CHARBUFFERPROC_NAME): Remove.
2923         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2924         Python 2.4 workaround.
2925
2926 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2927
2928         * NEWS: Note minimum Python version.
2929
2930 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2931
2932         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2933         code from these functions.  Remove corresponding ifdefs.  Use
2934         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2935         Remove gotos and target of gotos.
2936         (infpy_search_memory): Likewise.
2937
2938 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2941         (hppa_gdbarch_init): Don't register deleted functions with
2942         gdbarch.
2943
2944 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2945
2946         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2947         (h8300_unwind_sp): Delete.
2948         (h8300_dummy_id): Delete.
2949         (h8300_gdbarch_init): Don't register deleted functions with
2950         gdbarch.
2951
2952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2955         (ft32_unwind_pc): Delete.
2956         (ft32_unwind_sp): Delete.
2957         (ft32_gdbarch_init): Don't register deleted functions with
2958         gdbarch.
2959
2960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2963         (frv_unwind_pc): Delete.
2964         (frv_unwind_sp): Delete.
2965         (frv_gdbarch_init): Don't register deleted functions with
2966         gdbarch.
2967
2968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2969
2970         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2971         (riscv_unwind_pc): Delete.
2972         (riscv_unwind_sp): Delete.
2973         (riscv_gdbarch_init): Don't register deleted functions with
2974         gdbarch.
2975
2976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2979         (csky_unwind_pc): Delete.
2980         (csky_unwind_sp): Delete.
2981         (csky_gdbarch_init): Don't register deleted functions with
2982         gdbarch.
2983
2984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2987         (cris_unwind_pc): Delete.
2988         (cris_unwind_sp): Delete.
2989         (cris_gdbarch_init): Don't register deleted functions with
2990         gdbarch.
2991
2992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2993
2994         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2995         (bfin_unwind_pc): Delete.
2996         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2997
2998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3001         (arm_unwind_pc): Delete.
3002         (arm_unwind_sp): Delete.
3003         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3004
3005 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3008         (arc_unwind_pc): Delete.
3009         (arc_unwind_sp): Delete.
3010         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3011
3012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3015         (alpha_unwind_pc): Delete.
3016         (alpha_gdbarch_init): Don't register deleted functions with
3017         gdbarch.
3018
3019 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3020
3021         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3022         (aarch64_unwind_pc): Delete.
3023         (aarch64_unwind_sp): Delete.
3024         (aarch64_gdbarch_init): Don't register deleted functions with
3025         gdbarch.
3026
3027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * gdbtypes.c (type_align): Don't consider static members when
3030         computing structure alignment.
3031
3032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3035         return 0 for other types.
3036         * arch-utils.c (default_type_align): Always return 0.
3037         * gdbarch.h: Regenerate.
3038         * gdbarch.sh (type_align): Extend comment.
3039         * gdbtypes.c (type_align): Add additional comments, always call
3040         gdbarch_type_align before applying the default rules.
3041         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3042         generic code will then apply a suitable default.
3043         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3044         types, return 0 for other types.
3045
3046 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3047
3048         * NEWS: Create a new section for the next release branch.
3049         Rename the section of the current branch, now that it has
3050         been cut.
3051
3052 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3053
3054         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3055         * version.in: Bump version to 8.3.50.DATE-git.
3056
3057 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3058
3059         * aix-thread.c (ptid_cmp): Remove unused variable.
3060         (get_signaled_thread): Likewise.
3061         (store_regs_user_thread): Likewise.
3062         (store_regs_kernel_thread): Likewise.
3063         (fetch_regs_kernel_thread): Remove shadowed variable.
3064
3065 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * features/riscv/32bit-cpu.xml: Add register numbers.
3068         * features/riscv/32bit-fpu.c: Regenerate.
3069         * features/riscv/32bit-fpu.xml: Add register numbers.
3070         * features/riscv/64bit-cpu.xml: Add register numbers.
3071         * features/riscv/64bit-fpu.c: Regenerate.
3072         * features/riscv/64bit-fpu.xml: Add register numbers.
3073
3074 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3075
3076         * NEWS: Mention two argument form of gdb.Value constructor.
3077         * python/py-value.c (convert_buffer_and_type_to_value): New
3078         function.
3079         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3080         Add support for handling an optional second argument.  Call
3081         convert_buffer_and_type_to_value as appropriate.
3082         * python/python-internal.h (Py_buffer_deleter): New struct.
3083         (Py_buffer_up): New typedef.
3084
3085 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3086
3087         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3088         instead of releasing ownership.
3089
3090 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3091
3092         * dwarf2read.c (open_and_init_dwp_file): Call
3093         elf_numsections instead of bfd_count_sections to initialize
3094         dwp_file->num_sections.
3095
3096 2019-02-25  Tom Tromey  <tromey@adacore.com>
3097
3098         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3099
3100 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3101
3102         * gcore.in: Add '--readnever' option when invoking GDB.
3103
3104 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         * MAINTAINERS: Update my email address.
3107
3108 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3109
3110         * build-id.c (build_id_to_debug_bfd_1): New function.
3111         (build_id_to_debug_bfd): Look for separate debug file in
3112         sysroot.
3113
3114 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3115
3116         * gdbarch.sh: Update the copyright year range that is placed into
3117         generated files.
3118
3119 2019-02-22  Keith Seitz  <keiths@redhat.com>
3120
3121         PR symtab/23853
3122         * linespec.c (create_sals_line_offset): Search for the default
3123         symtab's filename instead of its fullname.
3124
3125 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3126
3127         * NEWS: Update style defaults.
3128
3129 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3130
3131         * main.c (captured_main_1): Disable styling in batch mode.
3132
3133 2019-02-20  Tom Tromey  <tom@tromey.com>
3134
3135         * symtab.c (symtab_symbol_info): Fix typos.
3136
3137 2019-02-20  Tom Tromey  <tromey@adacore.com>
3138
3139         * findcmd.c (_initialize_mem_search): Use upper case for
3140         metasyntactic variables.
3141
3142 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3143
3144         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3145         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3146
3147 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3148
3149         * top.h (source_file_name): Change to std::string.
3150         * top.c (source_file_name): Likewise.
3151         (command_line_input): Adjust.
3152         * cli/cli-script.c (script_from_file): Adjust.
3153
3154 2019-02-19  Tom Tromey  <tromey@adacore.com>
3155
3156         * ravenscar-thread.c
3157         (ravenscar_thread_target::update_thread_list): Don't call
3158         ada_build_task_list.
3159         * ada-lang.h (ada_build_task_list): Don't declare.
3160         * ada-tasks.c (struct ada_tasks_inferior_data)
3161         <task_list_valid_p>: Now bool.
3162         (read_known_tasks, ada_task_list_changed)
3163         (ada_tasks_invalidate_inferior_data): Update.
3164         (read_known_tasks_array): Return bool.
3165         (read_known_tasks_list): Likewise.
3166         (read_known_tasks): Return void.
3167         (ada_build_task_list): Now static.
3168
3169 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3170
3171         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3172         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3173
3174 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3175
3176         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3177         variant for ada_tasks_pspace_data_handle and
3178         ada_tasks_inferior_data_handle.
3179         (ada_tasks_pspace_data_cleanup): New function.
3180         (ada_tasks_inferior_data_cleanup): New function.
3181
3182 2019-02-17  Tom Tromey  <tom@tromey.com>
3183
3184         * macrotab.h (macro_source_fullname): Return a std::string.
3185         * macrotab.c (macro_include, check_for_redefinition)
3186         (macro_undef, macro_lookup_definition, foreach_macro)
3187         (foreach_macro_in_scope): Update.
3188         (macro_source_fullname): Return a std::string.
3189         * macrocmd.c (show_pp_source_pos): Update.
3190
3191 2019-02-17  Tom Tromey  <tom@tromey.com>
3192
3193         * macrocmd.c (show_pp_source_pos): Style the file names.
3194
3195 2019-02-17  Tom Tromey  <tom@tromey.com>
3196
3197         PR tui/24197:
3198         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3199
3200 2019-02-17  Tom Tromey  <tom@tromey.com>
3201
3202         * ada-lang.c (user_select_syms): Use filtered printing.
3203         * utils.c (wrap_style): New global.
3204         (desired_style): Remove.
3205         (emit_style_escape): Add stream parameter.
3206         (set_output_style, reset_terminal_style, prompt_for_continue):
3207         Update.
3208         (flush_wrap_buffer): Only flush gdb_stdout.
3209         (wrap_here): Set wrap_style.
3210         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3211         treat escape sequences as a character.  Change when wrap buffer is
3212         flushed.
3213         (fputs_styled): Do not set the output style when the default is
3214         requested.
3215         * ui-style.h (struct ui_file_style) <is_default>: New method.
3216         * source.c (print_source_lines_base): Emit escape sequences in one
3217         piece.
3218
3219 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3220
3221         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3222         integers and enumeration types.
3223
3224 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3225
3226         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3227         instead of lookup_symbol_in_language
3228         (do_exact_match): New function.
3229         (ada_get_symbol_name_matcher): Return do_exact_match when
3230         doing a verbatim match.
3231
3232 2019-02-15  Tom Tromey  <tromey@adacore.com>
3233
3234         * ravenscar-thread.c (ravenscar_thread_target::resume)
3235         (ravenscar_thread_target::wait): Special case wildcard requests.
3236
3237 2019-02-15  Tom Tromey  <tromey@adacore.com>
3238
3239         * ravenscar-thread.c (base_ptid): Remove.
3240         (struct ravenscar_thread_target) <close>: New method.
3241         <m_base_ptid>: New member.
3242         <update_inferior_ptid, active_task, task_is_currently_active,
3243         runtime_initialized>: Declare methods.
3244         <ravenscar_thread_target>: Add constructor.
3245         (ravenscar_thread_target::task_is_currently_active)
3246         (ravenscar_thread_target::update_inferior_ptid)
3247         (ravenscar_runtime_initialized): Rename.  Now methods.
3248         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3249         (ravenscar_thread_target::update_thread_list): Update.
3250         (ravenscar_thread_target::active_task): Now method.
3251         (ravenscar_thread_target::store_registers)
3252         (ravenscar_thread_target::prepare_to_store)
3253         (ravenscar_thread_target::prepare_to_store)
3254         (ravenscar_thread_target::mourn_inferior): Update.
3255         (ravenscar_inferior_created): Use "new" to create target.
3256         (ravenscar_thread_target::get_ada_task_ptid): Update.
3257         (_initialize_ravenscar): Don't initialize base_ptid.
3258         (ravenscar_ops): Remove global.
3259
3260 2019-02-15  Tom Tromey  <tromey@adacore.com>
3261
3262         * target.h (push_target): Declare new overload.
3263         * target.c (push_target): New overload, taking an rvalue reference.
3264         * remote.c (remote_target::open_1): Use push_target overload.
3265         * corelow.c (core_target_open): Use push_target overload.
3266
3267 2019-02-15  Tom Tromey  <tromey@adacore.com>
3268
3269         * ravenscar-thread.c (is_ravenscar_task)
3270         (ravenscar_task_is_currently_active): Return bool.
3271         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3272         (_initialize_ravenscar): Remove "(void)".
3273         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3274         Return bool.
3275
3276 2019-02-15  Tom Tromey  <tromey@adacore.com>
3277
3278         * ravenscar-thread.c (ravenscar_runtime_initializer)
3279         (has_ravenscar_runtime, get_running_thread_id)
3280         (ravenscar_thread_target::resume): Fix indentation.
3281
3282 2019-02-15  Tom Tromey  <tromey@adacore.com>
3283
3284         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3285         from ravenscar_arch_ops.
3286         (sparc_ravenscar_ops::fetch_registers)
3287         (sparc_ravenscar_ops::store_registers): Now methods.
3288         (sparc_ravenscar_prepare_to_store): Remove.
3289         (sparc_ravenscar_ops): Redefine.
3290         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3291         methods and destructor.  Remove members.
3292         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3293         (ravenscar_thread_target::store_registers)
3294         (ravenscar_thread_target::prepare_to_store): Update.
3295         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3296         Remove.
3297         (struct ppc_ravenscar_powerpc_ops): Derive from
3298         ravenscar_arch_ops.
3299         (ppc_ravenscar_powerpc_ops::fetch_registers)
3300         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3301         (ppc_ravenscar_powerpc_ops): Redefine.
3302         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3303         (ppc_ravenscar_e500_ops::fetch_registers)
3304         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3305         (ppc_ravenscar_e500_ops): Redefine.
3306         * aarch64-ravenscar-thread.c
3307         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3308         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3309         (aarch64_ravenscar_fetch_registers)
3310         (aarch64_ravenscar_store_registers): Now methods.
3311         (aarch64_ravenscar_ops): Redefine.
3312
3313 2019-02-15  Tom Tromey  <tromey@adacore.com>
3314
3315         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3316         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3317         (ravenscar_thread_target::stopped_by_watchpoint)
3318         (ravenscar_thread_target::stopped_data_address)
3319         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3320
3321 2019-02-15  Tom Tromey  <tromey@adacore.com>
3322
3323         * ravenscar-thread.c: Fix some typos.
3324
3325 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3326             Tom Tromey  <tromey@adacore.com>
3327
3328         * ada-lang.c (ada_exception_sal): Change addr_string to a
3329         std::string.
3330         (create_ada_exception_catchpoint): Update.
3331
3332 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3333             Tom Tromey  <tromey@adacore.com>
3334
3335         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3336         (bp_location_ops): Remove.
3337         (base_breakpoint_allocate_location): Update.
3338         (free_bp_location): Update.
3339         * ada-lang.c (class ada_catchpoint_location)
3340         <ada_catchpoint_location>: Remove ops parameter.
3341         (ada_catchpoint_location_dtor): Remove.
3342         (ada_catchpoint_location_ops): Remove.
3343         (allocate_location_exception): Update.
3344         * breakpoint.h (struct bp_location_ops): Remove.
3345         (class bp_location) <bp_location>: Remove bp_location_ops
3346         parameter.
3347         <~bp_location>: Add destructor.
3348         <ops>: Remove.
3349
3350 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3351             Pedro Alves  <palves@redhat.com>
3352
3353         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3354         'PATH_MAX'.
3355
3356 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3357             Samuel Thibault  <samuel.thibault@gnu.org>
3358             Thomas Schwinge  <thomas@codesourcery.com>
3359
3360         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3361         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3362
3363 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3364
3365         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3366         (check_empty): Use "const char *".
3367
3368         * gnu-nat.c (gnu_nat_target::detach): Instead of
3369         'detach_inferior (pid)' call
3370         'detach_inferior (find_inferior_pid (pid))'.
3371
3372         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3373         'nat/fork-inferior.o'.
3374         * gnu-nat.c: #include "nat/fork-inferior.h".
3375
3376         * gnu-nat.c (gnu_nat_target::detach): Instead of
3377         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3378         * gnu-nat.h: #include "inf-child.h".
3379         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3380         'i386_gnu_nat_target::fetch_registers'.
3381         (gnu_store_registers): Rename/move to
3382         'i386_gnu_nat_target::store_registers'.
3383
3384         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3385         * gnu-nat.h (mach_thread_info): New function.
3386         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3387
3388         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3389
3390 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3391
3392         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3393
3394 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3395
3396         * windows-nat.c (windows_add_thread): Add new parameter
3397         "main_thread_p" with default value set to false.  Update
3398         function documentation as well as all callers.
3399         (windows_delete_thread): Likewise.
3400         (fake_create_process): Update call to windows_add_thread.
3401         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3402         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3403         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3404         call to windows_delete_thread.
3405
3406 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3407
3408         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3409
3410 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3411
3412         * symfile.c (find_separate_debug_file): Use canonical path of
3413         sysroot with child_path instead of gdb_sysroot if it is valid.
3414
3415 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3416
3417         * symfile.c (find_separate_debug_file): Use child_path to
3418         determine if an object file is under a sysroot.
3419
3420 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3421
3422         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3423         unittests/child-path-selftests.c.
3424         * common/pathstuff.c (child_path): New function.
3425         * common/pathstuff.h (child_path): New prototype.
3426         * unittests/child-path-selftests.c: New file.
3427
3428 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3429
3430         * symfile.c (find_separate_debug_file): Look for separate debug
3431         files in debug directories under the sysroot.
3432
3433 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3434
3435         * symtab.h (struct minimal_symbol data_p): New const method.
3436         (struct minimal_symbol text_p): Likewise.
3437         * symtab.c (output_source_filename): Use file name style
3438         to print file name.
3439         (print_symbol_info): Likewise.
3440         (print_msymbol_info): Use address style to print addresses.
3441         Use function name style to print executable text symbols.
3442         (expand_symtab_containing_pc): Use data_p.
3443         (find_pc_sect_compunit_symtab): Likewise.
3444
3445 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3446
3447         * breakpoint.c (describe_other_breakpoints): Use address style
3448         to print addresses.
3449         (say_where): Likewise.
3450
3451 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3452
3453         * ada-typeprint.c (print_func_type): Print function name
3454         style to print function name.
3455         * c-typeprint.c (c_print_type_1): Likewise.
3456
3457 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3458
3459         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3460         for execve.
3461
3462 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3465         type_stack.
3466
3467 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3468
3469         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3470         TYPE_CODE_REF types.
3471
3472 2019-02-08  Jim Wilson  <jimw@sifive.com>
3473
3474         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3475         (riscv_linux_fregset): New.
3476         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3477
3478 2019-02-07  Tom Tromey  <tom@tromey.com>
3479
3480         * thread.c (thread_cancel_execution_command): Update.
3481         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3482         methods.
3483         (struct thread_fsm_ops): Remove.
3484         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3485         (thread_fsm_should_stop, thread_fsm_return_value)
3486         (thread_fsm_set_finished, thread_fsm_finished_p)
3487         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3488         Don't declare.
3489         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3490         * infrun.c (clear_proceed_status_thread)
3491         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3492         (print_stop_event): Update.
3493         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3494         Add constructor.
3495         (step_command_fsm_ops): Remove.
3496         (new_step_command_fsm): Remove.
3497         (step_1): Update.
3498         (step_command_fsm::should_stop): Rename from
3499         step_command_fsm_should_stop.
3500         (step_command_fsm::clean_up): Rename from
3501         step_command_fsm_clean_up.
3502         (step_command_fsm::do_async_reply_reason): Rename from
3503         step_command_fsm_async_reply_reason.
3504         (struct until_next_fsm): Inherit from thread_fsm.  Add
3505         constructor.
3506         (until_next_fsm_ops): Remove.
3507         (new_until_next_fsm): Remove.
3508         (until_next_fsm::should_stop): Rename from
3509         until_next_fsm_should_stop.
3510         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3511         (until_next_fsm::do_async_reply_reason): Rename from
3512         until_next_fsm_async_reply_reason.
3513         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3514         constructor.  Change type of breakpoint.
3515         (finish_command_fsm_ops): Remove.
3516         (new_finish_command_fsm): Remove.
3517         (finish_command_fsm::should_stop): Rename from
3518         finish_command_fsm_should_stop.
3519         (finish_command_fsm::clean_up): Rename from
3520         finish_command_fsm_clean_up.
3521         (finish_command_fsm::return_value): Rename from
3522         finish_command_fsm_return_value.
3523         (finish_command_fsm::do_async_reply_reason): Rename from
3524         finish_command_fsm_async_reply_reason.
3525         (finish_command): Update.
3526         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3527         Add constructor.
3528         (call_thread_fsm_ops): Remove.
3529         (call_thread_fsm::call_thread_fsm): Rename from
3530         new_call_thread_fsm.
3531         (call_thread_fsm::should_stop): Rename from
3532         call_thread_fsm_should_stop.
3533         (call_thread_fsm::should_notify_stop): Rename from
3534         call_thread_fsm_should_notify_stop.
3535         (run_inferior_call, call_function_by_hand_dummy): Update.
3536         * cli/cli-interp.c (should_print_stop_to_console): Update.
3537         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3538         Add constructor.  Change type of location_breakpoint,
3539         caller_breakpoint.
3540         (until_break_fsm_ops): Remove.
3541         (new_until_break_fsm): Remove.
3542         (until_break_fsm::should_stop): Rename from
3543         until_break_fsm_should_stop.
3544         (until_break_fsm::clean_up): Rename from
3545         until_break_fsm_clean_up.
3546         (until_break_fsm::do_async_reply_reason): Rename from
3547         until_break_fsm_async_reply_reason.
3548         (until_break_command): Update.
3549         * thread-fsm.c: Remove.
3550         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3551
3552 2019-02-07  Tom Tromey  <tom@tromey.com>
3553
3554         * yy-remap.h: Add include guard.
3555         * xtensa-tdep.h: Add include guard.
3556         * xcoffread.h: Rename include guard.
3557         * varobj-iter.h: Add include guard.
3558         * tui/tui.h: Rename include guard.
3559         * tui/tui-winsource.h: Rename include guard.
3560         * tui/tui-wingeneral.h: Rename include guard.
3561         * tui/tui-windata.h: Rename include guard.
3562         * tui/tui-win.h: Rename include guard.
3563         * tui/tui-stack.h: Rename include guard.
3564         * tui/tui-source.h: Rename include guard.
3565         * tui/tui-regs.h: Rename include guard.
3566         * tui/tui-out.h: Rename include guard.
3567         * tui/tui-layout.h: Rename include guard.
3568         * tui/tui-io.h: Rename include guard.
3569         * tui/tui-hooks.h: Rename include guard.
3570         * tui/tui-file.h: Rename include guard.
3571         * tui/tui-disasm.h: Rename include guard.
3572         * tui/tui-data.h: Rename include guard.
3573         * tui/tui-command.h: Rename include guard.
3574         * tic6x-tdep.h: Add include guard.
3575         * target/waitstatus.h: Rename include guard.
3576         * target/wait.h: Rename include guard.
3577         * target/target.h: Rename include guard.
3578         * target/resume.h: Rename include guard.
3579         * target-float.h: Rename include guard.
3580         * stabsread.h: Add include guard.
3581         * rs6000-tdep.h: Add include guard.
3582         * riscv-fbsd-tdep.h: Add include guard.
3583         * regformats/regdef.h: Rename include guard.
3584         * record.h: Rename include guard.
3585         * python/python.h: Rename include guard.
3586         * python/python-internal.h: Rename include guard.
3587         * python/py-stopevent.h: Rename include guard.
3588         * python/py-ref.h: Rename include guard.
3589         * python/py-record.h: Rename include guard.
3590         * python/py-record-full.h: Rename include guard.
3591         * python/py-record-btrace.h: Rename include guard.
3592         * python/py-instruction.h: Rename include guard.
3593         * python/py-events.h: Rename include guard.
3594         * python/py-event.h: Rename include guard.
3595         * procfs.h: Add include guard.
3596         * proc-utils.h: Add include guard.
3597         * p-lang.h: Add include guard.
3598         * or1k-tdep.h: Rename include guard.
3599         * observable.h: Rename include guard.
3600         * nto-tdep.h: Rename include guard.
3601         * nat/x86-linux.h: Rename include guard.
3602         * nat/x86-linux-dregs.h: Rename include guard.
3603         * nat/x86-gcc-cpuid.h: Add include guard.
3604         * nat/x86-dregs.h: Rename include guard.
3605         * nat/x86-cpuid.h: Rename include guard.
3606         * nat/ppc-linux.h: Rename include guard.
3607         * nat/mips-linux-watch.h: Rename include guard.
3608         * nat/linux-waitpid.h: Rename include guard.
3609         * nat/linux-ptrace.h: Rename include guard.
3610         * nat/linux-procfs.h: Rename include guard.
3611         * nat/linux-osdata.h: Rename include guard.
3612         * nat/linux-nat.h: Rename include guard.
3613         * nat/linux-namespaces.h: Rename include guard.
3614         * nat/linux-btrace.h: Rename include guard.
3615         * nat/glibc_thread_db.h: Rename include guard.
3616         * nat/gdb_thread_db.h: Rename include guard.
3617         * nat/gdb_ptrace.h: Rename include guard.
3618         * nat/fork-inferior.h: Rename include guard.
3619         * nat/amd64-linux-siginfo.h: Rename include guard.
3620         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3621         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3622         * nat/aarch64-linux.h: Rename include guard.
3623         * nat/aarch64-linux-hw-point.h: Rename include guard.
3624         * mn10300-tdep.h: Add include guard.
3625         * mips-linux-tdep.h: Add include guard.
3626         * mi/mi-parse.h: Rename include guard.
3627         * mi/mi-out.h: Rename include guard.
3628         * mi/mi-main.h: Rename include guard.
3629         * mi/mi-interp.h: Rename include guard.
3630         * mi/mi-getopt.h: Rename include guard.
3631         * mi/mi-console.h: Rename include guard.
3632         * mi/mi-common.h: Rename include guard.
3633         * mi/mi-cmds.h: Rename include guard.
3634         * mi/mi-cmd-break.h: Rename include guard.
3635         * m2-lang.h: Add include guard.
3636         * location.h: Rename include guard.
3637         * linux-record.h: Rename include guard.
3638         * linux-nat.h: Add include guard.
3639         * linux-fork.h: Add include guard.
3640         * i386-darwin-tdep.h: Rename include guard.
3641         * hppa-linux-offsets.h: Add include guard.
3642         * guile/guile.h: Rename include guard.
3643         * guile/guile-internal.h: Rename include guard.
3644         * gnu-nat.h: Rename include guard.
3645         * gdb-stabs.h: Rename include guard.
3646         * frv-tdep.h: Add include guard.
3647         * f-lang.h: Add include guard.
3648         * event-loop.h: Add include guard.
3649         * darwin-nat.h: Rename include guard.
3650         * cp-abi.h: Rename include guard.
3651         * config/sparc/nm-sol2.h: Rename include guard.
3652         * config/nm-nto.h: Rename include guard.
3653         * config/nm-linux.h: Add include guard.
3654         * config/i386/nm-i386gnu.h: Rename include guard.
3655         * config/djgpp/nl_types.h: Rename include guard.
3656         * config/djgpp/langinfo.h: Rename include guard.
3657         * compile/gcc-cp-plugin.h: Add include guard.
3658         * compile/gcc-c-plugin.h: Add include guard.
3659         * compile/compile.h: Rename include guard.
3660         * compile/compile-object-run.h: Rename include guard.
3661         * compile/compile-object-load.h: Rename include guard.
3662         * compile/compile-internal.h: Rename include guard.
3663         * compile/compile-cplus.h: Rename include guard.
3664         * compile/compile-c.h: Rename include guard.
3665         * common/xml-utils.h: Rename include guard.
3666         * common/x86-xstate.h: Rename include guard.
3667         * common/version.h: Rename include guard.
3668         * common/vec.h: Rename include guard.
3669         * common/tdesc.h: Rename include guard.
3670         * common/selftest.h: Rename include guard.
3671         * common/scoped_restore.h: Rename include guard.
3672         * common/scoped_mmap.h: Rename include guard.
3673         * common/scoped_fd.h: Rename include guard.
3674         * common/safe-iterator.h: Rename include guard.
3675         * common/run-time-clock.h: Rename include guard.
3676         * common/refcounted-object.h: Rename include guard.
3677         * common/queue.h: Rename include guard.
3678         * common/ptid.h: Rename include guard.
3679         * common/print-utils.h: Rename include guard.
3680         * common/preprocessor.h: Rename include guard.
3681         * common/pathstuff.h: Rename include guard.
3682         * common/observable.h: Rename include guard.
3683         * common/netstuff.h: Rename include guard.
3684         * common/job-control.h: Rename include guard.
3685         * common/host-defs.h: Rename include guard.
3686         * common/gdb_wait.h: Rename include guard.
3687         * common/gdb_vecs.h: Rename include guard.
3688         * common/gdb_unlinker.h: Rename include guard.
3689         * common/gdb_unique_ptr.h: Rename include guard.
3690         * common/gdb_tilde_expand.h: Rename include guard.
3691         * common/gdb_sys_time.h: Rename include guard.
3692         * common/gdb_string_view.h: Rename include guard.
3693         * common/gdb_splay_tree.h: Rename include guard.
3694         * common/gdb_setjmp.h: Rename include guard.
3695         * common/gdb_ref_ptr.h: Rename include guard.
3696         * common/gdb_optional.h: Rename include guard.
3697         * common/gdb_locale.h: Rename include guard.
3698         * common/gdb_assert.h: Rename include guard.
3699         * common/filtered-iterator.h: Rename include guard.
3700         * common/filestuff.h: Rename include guard.
3701         * common/fileio.h: Rename include guard.
3702         * common/environ.h: Rename include guard.
3703         * common/common-utils.h: Rename include guard.
3704         * common/common-types.h: Rename include guard.
3705         * common/common-regcache.h: Rename include guard.
3706         * common/common-inferior.h: Rename include guard.
3707         * common/common-gdbthread.h: Rename include guard.
3708         * common/common-exceptions.h: Rename include guard.
3709         * common/common-defs.h: Rename include guard.
3710         * common/common-debug.h: Rename include guard.
3711         * common/cleanups.h: Rename include guard.
3712         * common/buffer.h: Rename include guard.
3713         * common/btrace-common.h: Rename include guard.
3714         * common/break-common.h: Rename include guard.
3715         * cli/cli-utils.h: Rename include guard.
3716         * cli/cli-style.h: Rename include guard.
3717         * cli/cli-setshow.h: Rename include guard.
3718         * cli/cli-script.h: Rename include guard.
3719         * cli/cli-interp.h: Rename include guard.
3720         * cli/cli-decode.h: Rename include guard.
3721         * cli/cli-cmds.h: Rename include guard.
3722         * charset-list.h: Add include guard.
3723         * buildsym-legacy.h: Rename include guard.
3724         * bfin-tdep.h: Add include guard.
3725         * ax.h: Rename include guard.
3726         * arm-linux-tdep.h: Add include guard.
3727         * arm-fbsd-tdep.h: Add include guard.
3728         * arch/xtensa.h: Rename include guard.
3729         * arch/tic6x.h: Add include guard.
3730         * arch/i386.h: Add include guard.
3731         * arch/arm.h: Rename include guard.
3732         * arch/arm-linux.h: Rename include guard.
3733         * arch/arm-get-next-pcs.h: Rename include guard.
3734         * arch/amd64.h: Add include guard.
3735         * arch/aarch64-insn.h: Rename include guard.
3736         * arch-utils.h: Rename include guard.
3737         * annotate.h: Add include guard.
3738         * amd64-darwin-tdep.h: Rename include guard.
3739         * aarch64-linux-tdep.h: Add include guard.
3740         * aarch64-fbsd-tdep.h: Add include guard.
3741         * aarch32-linux-nat.h: Add include guard.
3742
3743 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3744
3745         * macrotab.c (macro_define_internal): New function that
3746         factorizes macro_define_object_internal and macro_define_function
3747         code.
3748         (macro_define_object_internal): Use macro_define_internal.
3749         (macro_define_function): Likewise.
3750
3751 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3752
3753         * macrocmd.c (extract_identifier): Return
3754         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3755         callers.
3756
3757 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3758
3759         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3760
3761 2019-02-05  Tom Tromey  <tom@tromey.com>
3762
3763         * target.c (target_stack::unpush): Move assertion earlier.
3764
3765 2019-01-30  Tom Tromey  <tom@tromey.com>
3766
3767         PR python/23615:
3768         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3769         (gdbpy_parse_and_eval): Likewise.
3770         * python/python-internal.h (gdbpy_allow_threads): New class.
3771
3772 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3773
3774         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3775         (aarch64_fbsd_fpregmap): Move earlier.
3776         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3777         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3778         instead of individual calls to trad_frame_set_reg_addr.
3779         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3780         earlier.
3781         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3782         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3783         instead of individual calls to trad_frame_set_reg_addr.
3784
3785 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3786
3787         * CONTRIBUTE: Replace contribution list with wiki link.
3788
3789 2019-01-25  Tom Tromey  <tom@tromey.com>
3790
3791         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3792
3793 2019-01-25  Tom Tromey  <tom@tromey.com>
3794
3795         * xtensa-linux-nat.c: Fix common/ includes.
3796         * xml-support.h: Fix common/ includes.
3797         * xml-support.c: Fix common/ includes.
3798         * x86-linux-nat.c: Fix common/ includes.
3799         * windows-nat.c: Fix common/ includes.
3800         * varobj.h: Fix common/ includes.
3801         * varobj.c: Fix common/ includes.
3802         * value.c: Fix common/ includes.
3803         * valops.c: Fix common/ includes.
3804         * utils.c: Fix common/ includes.
3805         * unittests/xml-utils-selftests.c: Fix common/ includes.
3806         * unittests/utils-selftests.c: Fix common/ includes.
3807         * unittests/unpack-selftests.c: Fix common/ includes.
3808         * unittests/tracepoint-selftests.c: Fix common/ includes.
3809         * unittests/style-selftests.c: Fix common/ includes.
3810         * unittests/string_view-selftests.c: Fix common/ includes.
3811         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3812         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3813         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3814         * unittests/rsp-low-selftests.c: Fix common/ includes.
3815         * unittests/parse-connection-spec-selftests.c: Fix common/
3816         includes.
3817         * unittests/optional-selftests.c: Fix common/ includes.
3818         * unittests/offset-type-selftests.c: Fix common/ includes.
3819         * unittests/observable-selftests.c: Fix common/ includes.
3820         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3821         * unittests/memrange-selftests.c: Fix common/ includes.
3822         * unittests/memory-map-selftests.c: Fix common/ includes.
3823         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3824         * unittests/function-view-selftests.c: Fix common/ includes.
3825         * unittests/environ-selftests.c: Fix common/ includes.
3826         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3827         * unittests/common-utils-selftests.c: Fix common/ includes.
3828         * unittests/cli-utils-selftests.c: Fix common/ includes.
3829         * unittests/array-view-selftests.c: Fix common/ includes.
3830         * ui-file.c: Fix common/ includes.
3831         * tui/tui-io.c: Fix common/ includes.
3832         * tracepoint.h: Fix common/ includes.
3833         * tracepoint.c: Fix common/ includes.
3834         * tracefile-tfile.c: Fix common/ includes.
3835         * top.h: Fix common/ includes.
3836         * top.c: Fix common/ includes.
3837         * thread.c: Fix common/ includes.
3838         * target/waitstatus.h: Fix common/ includes.
3839         * target/waitstatus.c: Fix common/ includes.
3840         * target.h: Fix common/ includes.
3841         * target.c: Fix common/ includes.
3842         * target-memory.c: Fix common/ includes.
3843         * target-descriptions.c: Fix common/ includes.
3844         * symtab.h: Fix common/ includes.
3845         * symfile.c: Fix common/ includes.
3846         * stap-probe.c: Fix common/ includes.
3847         * spu-linux-nat.c: Fix common/ includes.
3848         * sparc-nat.c: Fix common/ includes.
3849         * source.c: Fix common/ includes.
3850         * solib.c: Fix common/ includes.
3851         * solib-target.c: Fix common/ includes.
3852         * ser-unix.c: Fix common/ includes.
3853         * ser-tcp.c: Fix common/ includes.
3854         * ser-pipe.c: Fix common/ includes.
3855         * ser-base.c: Fix common/ includes.
3856         * selftest-arch.c: Fix common/ includes.
3857         * s12z-tdep.c: Fix common/ includes.
3858         * rust-exp.y: Fix common/ includes.
3859         * rs6000-aix-tdep.c: Fix common/ includes.
3860         * riscv-tdep.c: Fix common/ includes.
3861         * remote.c: Fix common/ includes.
3862         * remote-notif.h: Fix common/ includes.
3863         * remote-fileio.h: Fix common/ includes.
3864         * remote-fileio.c: Fix common/ includes.
3865         * regcache.h: Fix common/ includes.
3866         * regcache.c: Fix common/ includes.
3867         * record-btrace.c: Fix common/ includes.
3868         * python/python.c: Fix common/ includes.
3869         * python/py-type.c: Fix common/ includes.
3870         * python/py-inferior.c: Fix common/ includes.
3871         * progspace.h: Fix common/ includes.
3872         * producer.c: Fix common/ includes.
3873         * procfs.c: Fix common/ includes.
3874         * proc-api.c: Fix common/ includes.
3875         * printcmd.c: Fix common/ includes.
3876         * ppc-linux-nat.c: Fix common/ includes.
3877         * parser-defs.h: Fix common/ includes.
3878         * osdata.c: Fix common/ includes.
3879         * obsd-nat.c: Fix common/ includes.
3880         * nat/x86-linux.c: Fix common/ includes.
3881         * nat/x86-linux-dregs.c: Fix common/ includes.
3882         * nat/x86-dregs.h: Fix common/ includes.
3883         * nat/x86-dregs.c: Fix common/ includes.
3884         * nat/ppc-linux.c: Fix common/ includes.
3885         * nat/mips-linux-watch.h: Fix common/ includes.
3886         * nat/mips-linux-watch.c: Fix common/ includes.
3887         * nat/linux-waitpid.c: Fix common/ includes.
3888         * nat/linux-ptrace.h: Fix common/ includes.
3889         * nat/linux-ptrace.c: Fix common/ includes.
3890         * nat/linux-procfs.c: Fix common/ includes.
3891         * nat/linux-personality.c: Fix common/ includes.
3892         * nat/linux-osdata.c: Fix common/ includes.
3893         * nat/linux-namespaces.c: Fix common/ includes.
3894         * nat/linux-btrace.h: Fix common/ includes.
3895         * nat/linux-btrace.c: Fix common/ includes.
3896         * nat/fork-inferior.c: Fix common/ includes.
3897         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3898         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3899         * nat/aarch64-linux.c: Fix common/ includes.
3900         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3901         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3902         * namespace.h: Fix common/ includes.
3903         * mips-linux-tdep.c: Fix common/ includes.
3904         * minsyms.c: Fix common/ includes.
3905         * mi/mi-parse.h: Fix common/ includes.
3906         * mi/mi-main.c: Fix common/ includes.
3907         * mi/mi-cmd-env.c: Fix common/ includes.
3908         * memrange.h: Fix common/ includes.
3909         * memattr.c: Fix common/ includes.
3910         * maint.h: Fix common/ includes.
3911         * maint.c: Fix common/ includes.
3912         * main.c: Fix common/ includes.
3913         * machoread.c: Fix common/ includes.
3914         * location.c: Fix common/ includes.
3915         * linux-thread-db.c: Fix common/ includes.
3916         * linux-nat.c: Fix common/ includes.
3917         * linux-fork.c: Fix common/ includes.
3918         * inline-frame.c: Fix common/ includes.
3919         * infrun.c: Fix common/ includes.
3920         * inflow.c: Fix common/ includes.
3921         * inferior.h: Fix common/ includes.
3922         * inferior.c: Fix common/ includes.
3923         * infcmd.c: Fix common/ includes.
3924         * inf-ptrace.c: Fix common/ includes.
3925         * inf-child.c: Fix common/ includes.
3926         * ia64-linux-nat.c: Fix common/ includes.
3927         * i387-tdep.c: Fix common/ includes.
3928         * i386-tdep.c: Fix common/ includes.
3929         * i386-linux-tdep.c: Fix common/ includes.
3930         * i386-linux-nat.c: Fix common/ includes.
3931         * i386-go32-tdep.c: Fix common/ includes.
3932         * i386-fbsd-tdep.c: Fix common/ includes.
3933         * i386-fbsd-nat.c: Fix common/ includes.
3934         * guile/scm-type.c: Fix common/ includes.
3935         * guile/guile.c: Fix common/ includes.
3936         * go32-nat.c: Fix common/ includes.
3937         * gnu-nat.c: Fix common/ includes.
3938         * gdbthread.h: Fix common/ includes.
3939         * gdbarch-selftests.c: Fix common/ includes.
3940         * gdb_usleep.c: Fix common/ includes.
3941         * gdb_select.h: Fix common/ includes.
3942         * gdb_bfd.c: Fix common/ includes.
3943         * gcore.c: Fix common/ includes.
3944         * fork-child.c: Fix common/ includes.
3945         * findvar.c: Fix common/ includes.
3946         * fbsd-nat.c: Fix common/ includes.
3947         * event-top.c: Fix common/ includes.
3948         * event-loop.c: Fix common/ includes.
3949         * dwarf2read.c: Fix common/ includes.
3950         * dwarf2loc.c: Fix common/ includes.
3951         * dwarf2-frame.c: Fix common/ includes.
3952         * dwarf-index-cache.c: Fix common/ includes.
3953         * dtrace-probe.c: Fix common/ includes.
3954         * disasm-selftests.c: Fix common/ includes.
3955         * defs.h: Fix common/ includes.
3956         * csky-tdep.c: Fix common/ includes.
3957         * cp-valprint.c: Fix common/ includes.
3958         * cp-support.h: Fix common/ includes.
3959         * cp-support.c: Fix common/ includes.
3960         * corelow.c: Fix common/ includes.
3961         * completer.h: Fix common/ includes.
3962         * completer.c: Fix common/ includes.
3963         * compile/compile.c: Fix common/ includes.
3964         * compile/compile-loc2c.c: Fix common/ includes.
3965         * compile/compile-cplus-types.c: Fix common/ includes.
3966         * compile/compile-cplus-symbols.c: Fix common/ includes.
3967         * command.h: Fix common/ includes.
3968         * cli/cli-dump.c: Fix common/ includes.
3969         * cli/cli-cmds.c: Fix common/ includes.
3970         * charset.c: Fix common/ includes.
3971         * build-id.c: Fix common/ includes.
3972         * btrace.h: Fix common/ includes.
3973         * btrace.c: Fix common/ includes.
3974         * breakpoint.h: Fix common/ includes.
3975         * breakpoint.c: Fix common/ includes.
3976         * ax.h: 
3977         (enum agent_op): Fix common/ includes.
3978         * ax-general.c (struct aop_map): Fix common/ includes.
3979         * ax-gdb.c: Fix common/ includes.
3980         * auxv.c: Fix common/ includes.
3981         * auto-load.c: Fix common/ includes.
3982         * arm-tdep.c: Fix common/ includes.
3983         * arch/riscv.c: Fix common/ includes.
3984         * arch/ppc-linux-common.c: Fix common/ includes.
3985         * arch/i386.c: Fix common/ includes.
3986         * arch/arm.c: Fix common/ includes.
3987         * arch/arm-linux.c: Fix common/ includes.
3988         * arch/arm-get-next-pcs.c: Fix common/ includes.
3989         * arch/amd64.c: Fix common/ includes.
3990         * arch/aarch64.c: Fix common/ includes.
3991         * arch/aarch64-insn.c: Fix common/ includes.
3992         * arch-utils.c: Fix common/ includes.
3993         * amd64-windows-tdep.c: Fix common/ includes.
3994         * amd64-tdep.c: Fix common/ includes.
3995         * amd64-sol2-tdep.c: Fix common/ includes.
3996         * amd64-obsd-tdep.c: Fix common/ includes.
3997         * amd64-nbsd-tdep.c: Fix common/ includes.
3998         * amd64-linux-tdep.c: Fix common/ includes.
3999         * amd64-linux-nat.c: Fix common/ includes.
4000         * amd64-fbsd-tdep.c: Fix common/ includes.
4001         * amd64-fbsd-nat.c: Fix common/ includes.
4002         * amd64-dicos-tdep.c: Fix common/ includes.
4003         * amd64-darwin-tdep.c: Fix common/ includes.
4004         * agent.c: Fix common/ includes.
4005         * ada-lang.h: Fix common/ includes.
4006         * ada-lang.c: Fix common/ includes.
4007         * aarch64-tdep.c: Fix common/ includes.
4008
4009 2019-01-25  Tom Tromey  <tom@tromey.com>
4010
4011         * common/create-version.sh: Use common/version.h.
4012
4013 2019-01-24  Pedro Alves  <palves@redhat.com>
4014
4015         * infrun.c (signal_stop, signal_print, signal_program)
4016         (signal_catch, signal_pass): Now arrays instead of pointers.
4017         (update_signals_program_target, do_target_resume)
4018         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4019         * linux-nat.c (linux_nat_target::pass_signals)
4020         (linux_nat_target::create_inferior, linux_nat_target::attach):
4021         Adjust.
4022         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4023         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4024         * procfs.c (procfs_target::pass_signals): Adjust.
4025         * record-full.c (record_full_target::resume): Adjust.
4026         * remote.c (remote_target::pass_signals)
4027         (remote_target::program_signals): Adjust.
4028         * target-debug.h (target_debug_print_signals): Now takes a
4029         gdb::array_view as parameter.  Adjust.
4030         * target.h (target_ops) <pass_signals, program_signals>: Replace
4031         pointer and length parameters with gdb::array_view.
4032         (target_pass_signals, target_program_signals): Likewise.
4033         * target-delegates.c: Regenerate.
4034
4035 2019-01-24  Pedro Alves  <palves@redhat.com>
4036
4037         * common/forward-scope-exit.h
4038         (forward_scope_exit::forward_scope_exit): Pass arguments to
4039         m_bind_function directly, instead of creating a std::bind and
4040         copying that.
4041
4042 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4043
4044         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4045         for static members.
4046         (pass_in_v_vfp_candidate): Likewise.
4047
4048 2019-01-23  Tom Tromey  <tom@tromey.com>
4049             Pedro Alves  <palves@redhat.com>
4050
4051         * regcache.c (class regcache_invalidator): Remove.
4052         (regcache::raw_write): Use make_scope_exit.
4053
4054 2019-01-23  Tom Tromey  <tom@tromey.com>
4055
4056         * ui-out.h (class ui_out_emit_type): Update comment.
4057
4058 2019-01-23  Tom Tromey  <tom@tromey.com>
4059
4060         * infrun.c (fetch_inferior_event): Update comment.
4061
4062 2019-01-23  Tom Tromey  <tom@tromey.com>
4063             Pedro Alves  <palves@redhat.com>
4064
4065         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4066         parameter.
4067         (fetch_inferior_event): Use SCOPE_EXIT.
4068
4069
4070 2019-01-23  Tom Tromey  <tom@tromey.com>
4071             Pedro Alves  <palves@redhat.com>
4072
4073         * infrun.c (disable_thread_events): Delete.
4074         (stop_all_threads): Use SCOPE_EXIT.
4075
4076 2019-01-23  Tom Tromey  <tom@tromey.com>
4077             Pedro Alves  <palves@redhat.com>
4078
4079         * symfile.c: Include forward-scope-exit.h.
4080         (clear_symtab_users_cleanup): Replace forward declaration with
4081         a FORWARD_SCOPE_EXIT.
4082         (syms_from_objfile_1): Use the forward_scope_exit and
4083         gdb::optional instead of cleanup_function.
4084         (reread_symbols): Use the forward_scope_exit instead of
4085         cleanup_function.
4086         (clear_symtab_users_cleanup): Remove function.
4087
4088 2019-01-23  Tom Tromey  <tom@tromey.com>
4089             Pedro Alves  <palves@redhat.com>
4090
4091         * linux-nat.c: Include scope-exit.h.
4092         (cleanup_target_stop): Remove.
4093         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4094         SCOPE_EXIT.
4095
4096 2019-01-23  Tom Tromey  <tom@tromey.com>
4097             Pedro Alves  <palves@redhat.com>
4098
4099         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4100         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4101
4102 2019-01-23  Tom Tromey  <tom@tromey.com>
4103             Andrew Burgess  <andrew.burgess@embecosm.com>
4104             Pedro Alves  <palves@redhat.com>
4105
4106         * infrun.c (fetch_inferior_event): Use scope_exit.
4107         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4108         * top.c (execute_command): Use scope_exit.
4109         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4110         * utils.c (do_bpstat_clear_actions_cleanup)
4111         (make_bpstat_clear_actions_cleanup): Remove.
4112
4113 2019-01-23  Tom Tromey  <tom@tromey.com>
4114             Pedro Alves  <palves@redhat.com>
4115
4116         * infrun.c: Include "common/scope-exit.h"
4117         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4118         (wait_for_inferior): Use SCOPE_EXIT.
4119         (fetch_inferior_event): Use scope_exit.
4120
4121 2019-01-23  Tom Tromey  <tom@tromey.com>
4122             Pedro Alves  <palves@redhat.com>
4123
4124         * breakpoint.c (create_breakpoint): Remove cleanup.
4125
4126 2019-01-23  Tom Tromey  <tom@tromey.com>
4127             Andrew Burgess  <andrew.burgess@embecosm.com>
4128             Pedro Alves  <palves@redhat.com>
4129
4130 2019-01-23  Pedro Alves  <palves@redhat.com>
4131
4132         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4133
4134 2019-01-23  Pedro Alves  <palves@redhat.com>
4135             Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * gdbthread.h: Include "common/forward-scope-exit.h".
4138         (scoped_finish_thread_state): Redefine custom class in terms of
4139         forward_scope_exit.
4140
4141 2019-01-23  Pedro Alves  <palves@redhat.com>
4142             Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * common/forward-scope-exit.h: New file.
4145
4146 2019-01-23  Pedro Alves  <palves@redhat.com>
4147             Andrew Burgess  <andrew.burgess@embecosm.com>
4148             Tom Tromey  <tom@tromey.com>
4149
4150         * common/scope-exit.h: New file.
4151
4152 2019-01-23  Pedro Alves  <palves@redhat.com>
4153
4154         * common/preprocessor.h (ESC): Rename to ...
4155         (ESC_PARENS): ... this.
4156         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4157         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4158
4159 2019-01-23  Tom Tromey  <tom@tromey.com>
4160
4161         * language.h (class scoped_switch_to_sym_language_if_auto):
4162         Initialize m_lang in both cases.
4163
4164 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4165
4166         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4167         with XCNEW.
4168
4169 2019-01-22  Tom Tromey  <tom@tromey.com>
4170
4171         * corelow.c: Do not include sys/file.h.
4172
4173 2019-01-22  Tom Tromey  <tom@tromey.com>
4174
4175         * tui/tui-wingeneral.h: Include gdb_curses.h.
4176
4177 2019-01-22  Tom Tromey  <tom@tromey.com>
4178
4179         * source-cache.h (class source_cache) <get_source_lines,
4180         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4181
4182 2019-01-22  Tom Tromey  <tom@tromey.com>
4183
4184         * remote-fileio.h (struct remote_target): Declare.
4185
4186 2019-01-22  Tom Tromey  <tom@tromey.com>
4187
4188         * python/py-arch.c: Do not include py-ref.h.
4189         * python/py-bpevent.c: Do not include py-ref.h.
4190         * python/py-cmd.c: Do not include py-ref.h.
4191         * python/py-continueevent.c: Do not include py-ref.h.
4192         * python/py-event.h: Do not include py-ref.h.
4193         * python/py-evtregistry.c: Do not include py-ref.h.
4194         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4195         * python/py-frame.c: Do not include py-ref.h.
4196         * python/py-framefilter.c: Do not include py-ref.h.
4197         * python/py-function.c: Do not include py-ref.h.
4198         * python/py-infevents.c: Do not include py-ref.h.
4199         * python/py-linetable.c: Do not include py-ref.h.
4200         * python/py-objfile.c: Do not include py-ref.h.
4201         * python/py-param.c: Do not include py-ref.h.
4202         * python/py-prettyprint.c: Do not include py-ref.h.
4203         * python/py-progspace.c: Do not include py-ref.h.
4204         * python/py-symbol.c: Do not include py-ref.h.
4205         * python/py-symtab.c: Do not include py-ref.h.
4206         * python/py-type.c: Do not include py-ref.h.
4207         * python/py-unwind.c: Do not include py-ref.h.
4208         * python/py-utils.c: Do not include py-ref.h.
4209         * python/py-value.c: Do not include py-ref.h.
4210         * python/py-varobj.c: Do not include py-ref.h.
4211         * python/py-xmethods.c: Do not include py-ref.h.
4212         * python/python.c: Do not include py-ref.h.
4213         * varobj.c: Do not include py-ref.h.
4214
4215 2019-01-22  Tom Tromey  <tom@tromey.com>
4216
4217         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4218         keyword for bcache.
4219
4220 2019-01-22  Tom Tromey  <tom@tromey.com>
4221
4222         * compile/compile-cplus-types.c: Remove a comment by #include.
4223
4224 2019-01-22  Tom Tromey  <tom@tromey.com>
4225
4226         * compile/gcc-c-plugin.h: Include compile-internal.h.
4227
4228 2019-01-22  Tom Tromey  <tom@tromey.com>
4229
4230         * stabsread.c (EXTERN): Do not define.
4231         (symnum, next_symbol_text_func, processing_gcc_compilation)
4232         (within_function, global_sym_chain, global_stabs)
4233         (previous_stab_code, this_object_header_files)
4234         (n_this_object_header_files)
4235         (n_allocated_this_object_header_files): Define.
4236         * stabsread.h (EXTERN): Never define.  Use "extern".
4237
4238 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4239
4240         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4241         history_value.
4242
4243 2019-01-21  Tom Tromey  <tom@tromey.com>
4244
4245         * ui-out.c: Fix includes.
4246         * tui/tui-source.c: Fix includes.
4247         * target.c: Fix includes.
4248         * remote.c: Fix includes.
4249         * regcache.c: Fix includes.
4250         * python/py-block.c: Fix includes.
4251         * printcmd.c: Fix includes.
4252         * or1k-tdep.c: Fix includes.
4253         * mi/mi-main.c: Fix includes.
4254         * m32r-tdep.c: Fix includes.
4255         * csky-tdep.c: Fix includes.
4256         * compile/compile-cplus-types.c: Fix includes.
4257         * cli/cli-interp.c: Fix includes.
4258
4259 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4260
4261         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4262         for padding.
4263
4264 2019-01-16  Tom Tromey  <tom@tromey.com>
4265
4266         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4267         earlier.
4268         (struct objfile) <msymbols_range>: Move from top level.
4269         <msymbols>: New method.
4270         (class objfile_msymbols): Remove.
4271         * symtab.c (default_collect_symbol_completion_matches_break_on):
4272         Update.
4273         * symmisc.c (dump_msymbols): Update.
4274         * stabsread.c (scan_file_globals): Update.
4275         * objc-lang.c (info_selectors_command, info_classes_command)
4276         (find_methods): Update.
4277         * minsyms.c (find_solib_trampoline_target): Update.
4278         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4279         * coffread.c (coff_symfile_read): Update.
4280         * ada-lang.c (ada_lookup_simple_minsym)
4281         (ada_collect_symbol_completion_matches): Update.
4282
4283 2019-01-16  Tom Tromey  <tom@tromey.com>
4284
4285         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4286         type.  Remove no-argument constructor.
4287         <iterator::operator++>: Simplify.
4288         <begin>: Update.
4289         <end>: Use minimal_symbol_count.
4290
4291 2019-01-16  Tom Tromey  <tom@tromey.com>
4292
4293         * objfiles.h (struct objfile) <psymtabs>: New method.
4294         (class objfile_psymtabs): Remove.
4295         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4296         typedef.
4297         <range>: New method.
4298         (require_partial_symbols): Change return type.
4299         * psymtab.c (require_partial_symbols)
4300         (psym_expand_symtabs_matching): Update.
4301         * mdebugread.c (parse_partial_symbols): Update.
4302         * dbxread.c (dbx_end_psymtab): Update.
4303
4304 2019-01-15  Tom Tromey  <tom@tromey.com>
4305
4306         * symtab.c (lookup_objfile_from_block)
4307         (lookup_symbol_in_objfile_symtabs)
4308         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4309         (find_line_symtab, info_sources_command)
4310         (default_collect_symbol_completion_matches_break_on)
4311         (make_source_files_completion_list): Update.
4312         * symmisc.c (print_objfile_statistics, dump_objfile)
4313         (maintenance_print_symbols, maintenance_info_symtabs)
4314         (maintenance_check_symtabs, maintenance_info_line_tables):
4315         Update.
4316         * source.c (select_source_symtab)
4317         (forget_cached_source_info_for_objfile): Update.
4318         * objfiles.h (class objfile_compunits): Remove.
4319         (struct objfile) <compunits_range>: New typedef.
4320         (compunits): New method.
4321         * objfiles.c (objfile_relocate1): Update.
4322         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4323         * maint.c (count_symtabs_and_blocks): Update.
4324         * linespec.c (iterate_over_all_matching_symtabs): Update.
4325         * cp-support.c (add_symbol_overload_list_qualified): Update.
4326         * coffread.c (coff_symtab_read): Update.
4327         * ada-lang.c (add_nonlocal_symbols)
4328         (ada_collect_symbol_completion_matches)
4329         (ada_add_global_exceptions): Update.
4330
4331 2019-01-15  Tom Tromey  <tom@tromey.com>
4332
4333         * progspace.h (program_space) <objfiles_safe_range>: New
4334         typedef.
4335         <objfiles_safe>: New method.
4336         * objfiles.h (class all_objfiles_safe): Remove.
4337         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4338         * jit.c (jit_inferior_exit_hook): Update.
4339
4340 2019-01-17  Tom Tromey  <tom@tromey.com>
4341
4342         * progspace.h (program_space) <objfiles_range>: New typedef.
4343         <objfiles>: New method.
4344         <objfiles_head>: Rename from objfiles.
4345         (object_files): Update.
4346         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4347         * guile/scm-pretty-print.c
4348         (ppscm_find_pretty_printer_from_objfiles): Update.
4349         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4350         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4351         Update.
4352         * python/py-progspace.c (pspy_get_objfiles): Update.
4353         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4354         Update.
4355         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4356         (objfpy_lookup_objfile_by_build_id): Update.
4357         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4358         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4359         Update.
4360         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4361         (expand_symtab_containing_pc, lookup_objfile_from_block)
4362         (lookup_static_symbol, basic_lookup_transparent_type)
4363         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4364         (find_line_symtab, info_sources_command)
4365         (default_collect_symbol_completion_matches_break_on)
4366         (make_source_files_completion_list, find_main_name): Update.
4367         * symmisc.c (print_symbol_bcache_statistics)
4368         (print_objfile_statistics, maintenance_print_symbols)
4369         (maintenance_print_msymbols, maintenance_print_objfiles)
4370         (maintenance_info_symtabs, maintenance_check_symtabs)
4371         (maintenance_expand_symtabs, maintenance_info_line_tables):
4372         Update.
4373         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4374         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4375         (map_overlay_command, unmap_overlay_command)
4376         (simple_overlay_update, expand_symtabs_matching)
4377         (map_symbol_filenames): Update.
4378         * symfile-debug.c (set_debug_symfile): Update.
4379         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4380         Update.
4381         * source.c (select_source_symtab, forget_cached_source_info):
4382         Update.
4383         * solib.c (solib_read_symbols): Update.
4384         * solib-spu.c (append_ocl_sos): Update.
4385         * psymtab.c (maintenance_print_psymbols)
4386         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4387         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4388         * printcmd.c (info_symbol_command): Update.
4389         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4390         Update.
4391         * objfiles.h (class all_objfiles): Remove.
4392         * objfiles.c (have_partial_symbols, have_full_symbols)
4393         (have_minimal_symbols, qsort_cmp, update_section_map)
4394         (shared_objfile_contains_address_p)
4395         (default_iterate_over_objfiles_in_search_order): Update.
4396         * objc-lang.c (info_selectors_command, info_classes_command)
4397         (find_methods): Update.
4398         * minsyms.c (find_solib_trampoline_target): Update.
4399         * maint.c (maintenance_info_sections)
4400         (maintenance_translate_address, count_symtabs_and_blocks):
4401         Update.
4402         * main.c (captured_main_1): Update.
4403         * linux-thread-db.c (try_thread_db_load_from_pdir)
4404         (has_libpthread): Update.
4405         * linespec.c (iterate_over_all_matching_symtabs)
4406         (search_minsyms_for_name): Update.
4407         * jit.c (jit_find_objf_with_entry_addr): Update.
4408         * hppa-tdep.c (find_unwind_entry)
4409         (hppa_lookup_stub_minimal_symbol): Update.
4410         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4411         Update.
4412         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4413         (elf_gnu_ifunc_resolve_by_got): Update.
4414         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4415         * dwarf-index-write.c (save_gdb_index_command): Update.
4416         * cp-support.c (add_symbol_overload_list_qualified): Update.
4417         * breakpoint.c (create_overlay_event_breakpoint)
4418         (create_longjmp_master_breakpoint)
4419         (create_std_terminate_master_breakpoint)
4420         (create_exception_master_breakpoint): Update.
4421         * blockframe.c (find_pc_partial_function): Update.
4422         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4423         (ada_collect_symbol_completion_matches)
4424         (ada_add_global_exceptions): Update.
4425
4426 2019-01-17  Tom Tromey  <tom@tromey.com>
4427
4428         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4429         declare VEC.
4430         (solib_target_parse_libraries): Change return type.
4431         (library_list_start_segment, library_list_start_section)
4432         (library_list_end_library, library_list_start_library); Update.
4433         (solib_target_free_library_list): Remove.
4434         (solib_target_parse_libraries): Remove cleanup.  Change return
4435         type.
4436         (solib_target_current_sos): Update.
4437
4438 2019-01-17  Tom Tromey  <tromey@bapiya>
4439
4440         * valprint.c: Replace "the the" with "the".
4441         * symtab.c: Replace "the the" with "the".
4442         * solib.c: Replace "the the" with "the".
4443         * solib-dsbt.c: Replace "the the" with "the".
4444         * linespec.c: Replace "the the" with "the".
4445         * dwarf2loc.h: Replace "the the" with "the".
4446         * amd64-windows-tdep.c: Replace "the the" with "the".
4447         * aarch64-tdep.c: Replace "the the" with "the".
4448
4449 2019-01-16  Keith Seitz  <keiths@redhat.com>
4450
4451         PR gdb/23773
4452         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4453         <builder>: Rename to ..
4454         <m_builder>: ... this and make private.
4455         (dwarf2_cu::get_builder): New method.  Change all users of
4456         `builder' to use this method.
4457         (dwarf2_start_symtab): Move to ...
4458         (dwarf2_cu::start_symtab): ... here.  Update all callers
4459         (setup_type_unit_groups): Move to ...
4460         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4461         callers.
4462         (dwarf2_cu::reset_builder): New method.
4463         (process_full_compunit, process_full_type_unit): Use
4464         dwarf2_cu::reset_builder.
4465         (follow_die_offset): Record the ancestor CU if it is different
4466         from the followed DIE's CU.
4467         (follow_die_sig_1): Likewise.
4468
4469 2019-01-15  Tom Tromey  <tom@tromey.com>
4470
4471         * remote.c (class remote_state) <buf>: Now a char_vector.
4472         <buf_size>: Remove.
4473         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4474         parameter.
4475         (remote_target::getpkt_or_notif_sane_1)
4476         (remote_target::getpkt_sane)
4477         (remote_target::getpkt_or_notif_sane): Likewise.
4478         (class remote_target) <putpkt>: New overload.
4479         (remote_target::read_frame): Change type of "buf_p".  Remove
4480         sizeof_p parameter.
4481         (packet_ok): New overload.
4482         (packet_check_result): New overload.
4483         Update all uses.
4484
4485 2019-01-14  Tom Tromey  <tom@tromey.com>
4486
4487         * remote-notif.c (handle_notification, remote_notif_ack)
4488         (remote_notif_parse): Make "buf" const.
4489         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4490         const.
4491         (remote_notif_parse, remote_notif_ack, handle_notification):
4492         Likewise.
4493         * remote.c (remote_notif_stop_parse): Make "buf" const.
4494         (remote_target::remote_parse_stop_reply): Make "buf" const.
4495         (remote_notif_stop_ack): Make "buf" const.
4496
4497 2019-01-14  Tom Tromey  <tom@tromey.com>
4498
4499         * remote.c (remote_console_output): Make parameter const.
4500
4501 2019-01-14  Tom Tromey  <tom@tromey.com>
4502
4503         * target-debug.h (target_debug_print_signals): Constify.
4504         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4505         * procfs.c (procfs_target::pass_signals): Update.
4506         * linux-nat.c (linux_nat_target::pass_signals): Update.
4507         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4508         * target-delegates.c: Rebuild.
4509         * remote.c (remote_target::program_signals): Update.
4510         (remote_target::pass_signals): Update.
4511         * target.c (target_pass_signals): Constify argument.
4512         (target_program_signals): Likewise.
4513         * target.h (struct target_ops) <pass_signals, program_signals>:
4514         Constify argument.
4515         (target_pass_signals, target_program_signals): Constify argument.
4516
4517 2019-01-14  Tom Tromey  <tom@tromey.com>
4518
4519         PR tui/28819:
4520         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4521
4522 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4523
4524         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4525         field.
4526         * rs6000-tdep.c: Include reggroups.h.
4527         (IS_V_ALIAS_PSEUDOREG): Define.
4528         (rs6000_register_name): Return names for the "vX" aliases.
4529         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4530         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4531         aliases.  Call default_register_reggroup_p for all other
4532         pseudo-registers.
4533         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4534         New functions.
4535         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4536         Handle "vX" aliases.
4537         (v_alias_pseudo_register_collect): New function.
4538         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4539         (rs6000_gdbarch_init): Initialize "vX" aliases as
4540         pseudo-registers.  Restore registration of
4541         rs6000_pseudo_register_reggroup_p with
4542         set_tdesc_pseudo_register_reggroup_p.
4543
4544 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4545
4546         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4547         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4548         set_gdbarch_num_pseudo_regs.
4549
4550 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4551
4552         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4553         Remove arg prefixname, add do_set and do_show.
4554         Add member functions set_list and show_list.
4555         * cli/cli-style.c (class cli_style_option): Update accordingly.
4556         (style_set_list): Move to file scope.
4557         (style_show_list): Likewise.
4558         (set_style): Call help_list.
4559         (show_style): Call cmd_show_list.
4560         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4561         Update to use the new macro.
4562
4563 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4564
4565         * ada-lang.c (_initialize_ada_language): Expand the help text
4566         for the "catch exception" command.
4567
4568 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4569
4570         * symtab.c (matching_obj_sections): Initialize obj,
4571         declare it closer to its usage.
4572
4573 2019-01-10  Tom Tromey  <tom@tromey.com>
4574
4575         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4576         (basic_inf_threads_range): Remove.
4577         (inf_threads_range, inf_non_exited_threads_range)
4578         (safe_inf_threads_range): Use next_adapter.
4579
4580 2019-01-10  Keith Seitz  <keiths@redhat.com>
4581
4582         PR gdb/23712
4583         PR symtab/23010
4584         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4585         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4586
4587 2019-01-10  Keith Seitz  <keiths@redhat.com>
4588
4589         PR gdb/23712
4590         PR symtab/23010
4591         * dictionary.c (pending_to_vector): Remove.
4592         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4593         Remove _1 suffix, replacing functions of the same name.  Update
4594         all callers.
4595         (dict_create_hashed, dict_create_hashed_expandable)
4596         (dict_create_linear, dict_create_linear_expandable, dict_free)
4597         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4598         Make functions static.
4599
4600 2019-01-10  Keith Seitz  <keiths@redhat.com>
4601
4602         PR gdb/23712
4603         PR symtab/23010
4604         * dictionary.h (struct dictionary): Replace declaration with
4605         multidictionary.
4606         (dict_create_hashed, dict_create_hashed_expandable)
4607         (dict_create_linear, dict_create_linear_expandable)
4608         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4609         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4610         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4611         taking multidictionary argument.
4612         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4613         * block.h (struct block) <dict>: Change to multidictionary
4614         and rename `multidict'.
4615         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4616         symmisc.c: Update all dictionary references to multidictionary.
4617
4618 2019-01-10  Keith Seitz  <keiths@redhat.com>
4619
4620         PR gdb/23712
4621         PR symtab/23010
4622         * dictionary.c: Include unordered_map.
4623         (pending_to_vector): New function.
4624         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4625         Rewrite the non-"_1" functions to take vector instead
4626         of linked list.
4627         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4628         "new" _1 versions of the same name.
4629         (multidictionary): Define.
4630         (std::hash<enum language): New definition.
4631         (collate_pending_symbols_by_language, mdict_create_hashed)
4632         (mdict_create_hashed_expandable, mdict_create_linear)
4633         (mdict_create_linear_expandable, mdict_free)
4634         (find_language_dictionary, create_new_language_dictionary)
4635         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4636         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4637         (mdict_size, mdict_empty): New functions.
4638         * dictionary.h (mdict_iterator): Define.
4639
4640 2019-01-10  Pedro Alves  <palves@redhat.com>
4641
4642         * breakpoint.c (read_uploaded_action)
4643         (create_tracepoint_from_upload): Adjust to use
4644         gdb::unique_xmalloc_ptr.
4645         * ctf.c (ctf_write_uploaded_tp):
4646         (SET_ARRAY_FIELD): Use emplace_back.
4647         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4648         * tracefile-tfile.c (tfile_write_uploaded_tp):
4649         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4650         gdb::unique_xmalloc_ptr.
4651         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4652         at_string, cond_string, cmd_strings>: Replace char pointers
4653         with gdb::unique_xmalloc_ptr.
4654
4655 2019-01-10  Pedro Alves  <palves@redhat.com>
4656
4657         * solib-target.c (library_list_start_library): Don't xstrdup name.
4658
4659 2019-01-10  Pedro Alves  <palves@redhat.com>
4660
4661         * mdebugread.c (parse_partial_symbols): Use
4662         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4663
4664 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * linux-fork.c (scoped_switch_fork_info)
4667         <~scoped_switch_fork_info>: Fix incorrect variable name.
4668
4669 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * linux-fork.c (scoped_switch_fork_info)
4672         <scoped_switch_fork_info>: Make explicit.
4673         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4674
4675 2019-01-10  Tom Tromey  <tom@tromey.com>
4676
4677         * objfiles.h (objfile::reset_psymtabs): Update.
4678         * objfiles.c (objfile::objfile): Update.
4679         * psymtab.h (psymtab_storage::obstack): Update.
4680         (psymtab_storage::m_obstack): Use gdb::optional.
4681         (class psymtab_storage): Update comment.  Remove objfile
4682         parameter.
4683         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4684
4685 2019-01-10  Tom Tromey  <tom@tromey.com>
4686
4687         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4688         <free_psymtabs>: Now private.
4689         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4690         (allocate_psymtab): Use new method.
4691
4692 2019-01-10  Tom Tromey  <tom@tromey.com>
4693
4694         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4695         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4696         * mdebugread.c (parse_partial_symbols): Use
4697         allocate_dependencies.
4698         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4699         allocate_dependencies.
4700         (process_psymtab_comp_unit_reader)
4701         (build_type_psymtab_dependencies): Likewise.
4702         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4703
4704 2019-01-10  Tom Tromey  <tom@tromey.com>
4705
4706         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4707         PSYMBOL_SET_LANGUAGE.
4708         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4709
4710 2019-01-10  Tom Tromey  <tom@tromey.com>
4711
4712         * psymtab.h (psymtab_storage::obstack): New method.
4713         <m_obstack>: Rename from obstack; now private.
4714         * psymtab.c (psymtab_storage): Update.
4715         * dwarf2read.c (create_addrmap_from_index)
4716         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4717         Update.
4718
4719 2019-01-10  Tom Tromey  <tom@tromey.com>
4720
4721         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4722         * objfiles.h (objfile::reset_psymtabs): New method.
4723
4724 2019-01-10  Tom Tromey  <tom@tromey.com>
4725
4726         * symmisc.c (print_symbol_bcache_statistics): Update.
4727         (print_objfile_statistics): Update.
4728         * symfile.c (reread_symbols): Update.
4729         * psymtab.h (class psymtab_storage): New.
4730         * psymtab.c (psymtab_storage): New constructor.
4731         (~psymtab_storage): New destructor.
4732         (require_partial_symbols): Update.
4733         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4734         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4735         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4736         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4737         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4738         (start_psymtab_common, end_psymtab_common)
4739         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4740         (allocate_psymtab): Update.
4741         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4742         Update.
4743         (dump_psymtab_addrmap, maintenance_print_psymbols)
4744         (maintenance_check_psymtabs): Update.
4745         (class objfile_psymtabs): Move to objfiles.h.
4746         * psympriv.h (discard_psymtab): Now inline.
4747         (psymtab_discarder::psymtab_discarder): Update.
4748         (psymtab_discarder::~psymtab_discarder): Update.
4749         (ALL_OBJFILE_PSYMTABS): Rewrite.
4750         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4751         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4752         Remove fields.
4753         <partial_symtabs>: New field.
4754         (class objfile_psymtabs): Move from psymtab.h.  Update.
4755         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4756         psymbol_cache.
4757         (objfile::~objfile): Don't destroy psymbol_cache.
4758         * mdebugread.c (parse_partial_symbols): Update.
4759         * dwarf2read.c (create_addrmap_from_index)
4760         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4761         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4762         (add_partial_subprogram, dwarf2_ranges_read): Update.
4763         * dwarf-index-write.c (write_address_map)
4764         (write_one_signatured_type, recursively_write_psymbols)
4765         (class debug_names, class debug_names, write_psymtabs_to_index):
4766         Update.
4767
4768 2019-01-10  Tom Tromey  <tom@tromey.com>
4769
4770         * symtab.h (SYMBOL_SET_NAMES): Update.
4771         (symbol_set_names): Update.
4772         (MSYMBOL_SET_NAMES): Update.
4773         * symtab.c (symbol_set_names): Change argument to be an
4774         objfile_per_bfd_storage.
4775         * psymtab.c (add_psymbol_to_bcache): Update.
4776         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4777
4778 2019-01-10  Tom Tromey  <tom@tromey.com>
4779
4780         * symtab.c (create_demangled_names_hash): Change argument to be an
4781         objfile_per_bfd_storage.
4782         (symbol_set_names): Update.
4783
4784 2019-01-10  Tom Tromey  <tom@tromey.com>
4785
4786         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4787         init_psymbol_list.
4788         * psymtab.c (init_psymbol_list): Do nothing if already called.
4789         * psympriv.h (init_psymbol_list): Add comment.
4790         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4791         init_psymbol_list.
4792         * dbxread.c (dbx_symfile_read): Unconditionally call
4793         init_psymbol_list.
4794
4795 2019-01-10  Tom Tromey  <tom@tromey.com>
4796
4797         * xcoffread.c (scan_xcoff_symtab): Update.
4798         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4799         "where".
4800         * mdebugread.c (parse_partial_symbols)
4801         (handle_psymbol_enumerators): Update.
4802         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4803         * dbxread.c (read_dbx_symtab): Update.
4804         * psympriv.h (psymbol_placement): New enum.
4805         (add_psymbol_to_list): Update.
4806
4807 2019-01-10  Tom Tromey  <tom@tromey.com>
4808
4809         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4810         static_psymbols parameters.
4811         (scan_xcoff_symtab): Update.
4812         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4813         static_psymbols parameters.
4814         * psympriv.h (start_psymtab_common): Update.
4815         * mdebugread.c (parse_partial_symbols): Update.
4816         * dwarf2read.c (create_partial_symtab): Update.
4817         * dbxread.c (read_dbx_symtab): Update.
4818         (start_psymtab): Remove global_psymbols and static_psymbols
4819         parameters.
4820
4821 2019-01-10  Tom Tromey  <tom@tromey.com>
4822
4823         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4824         * psymtab.c (allocate_psymtab): Add comment.
4825         * psympriv.h (allocate_psymtab): Add comment.
4826         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4827         initializations.
4828         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4829
4830 2019-01-10  Tom Tromey  <tom@tromey.com>
4831
4832         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4833         Don't declare.
4834         * mipsread.c: Include mdebugread.h.
4835         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4836         Declare.
4837         * elfread.c: Include mdebugread.h.
4838
4839 2019-01-09  Tom Tromey  <tom@tromey.com>
4840
4841         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4842         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4843         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4844         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4845         (psym_lookup_symbol, psym_find_last_source_symtab)
4846         (psym_forget_cached_source_info, psym_print_stats)
4847         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4848         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4849         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4850         (psym_find_compunit_symtab_by_address)
4851         (maintenance_print_psymbols, maintenance_info_psymtabs)
4852         (maintenance_check_psymtabs): Use ranged for.
4853         * psymtab.h (class objfile_psymtabs): New.
4854         (require_partial_symbols): Return objfile_psymtabs.
4855         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4856
4857 2019-01-09  Tom Tromey  <tom@tromey.com>
4858
4859         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4860         (find_pc_mapped_section, list_overlays_command)
4861         (map_overlay_command, unmap_overlay_command)
4862         (simple_overlay_update): Use all_objfiles.
4863         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4864         * printcmd.c (info_symbol_command): Use all_objfiles.
4865         * objfiles.h (ALL_OBJSECTIONS): Remove.
4866         * maint.c (maintenance_translate_address): Use all_objfiles.
4867         * gcore.c (gcore_create_callback): Use all_objfiles.
4868         (objfile_find_memory_regions): Likewise.
4869
4870 2019-01-09  Tom Tromey  <tom@tromey.com>
4871
4872         * symtab.c (find_line_symtab, info_sources_command)
4873         (make_source_files_completion_list): Use objfile_compunits.
4874         * source.c (select_source_symtab): Use objfile_compunits.
4875         * objfiles.h (struct objfile): Update comment.
4876         (ALL_OBJFILES): Remove.
4877         (ALL_FILETABS): Remove.
4878         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4879         objfile_compunits.
4880
4881 2019-01-09  Tom Tromey  <tom@tromey.com>
4882
4883         * symmisc.c (print_objfile_statistics, dump_objfile)
4884         (maintenance_print_symbols): Use compunit_filetabs.
4885         * source.c (forget_cached_source_info_for_objfile): Use
4886         compunit_filetabs.
4887         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4888         (ALL_FILETABS): Use compunit_filetabs.
4889         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4890         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4891
4892 2019-01-09  Tom Tromey  <tom@tromey.com>
4893
4894         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4895         (compunit_filetabs): New.
4896         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4897         compunit_filetabs.
4898         (info_sources_command, make_source_files_completion_list): Remove
4899         declaration.
4900         * symmisc.c (print_objfile_statistics, dump_objfile)
4901         (maintenance_print_symbols): Remove declaration.
4902         (maintenance_info_symtabs): Use compunit_filetabs.
4903         (maintenance_info_line_tables): Likewise.
4904         * source.c (select_source_symtab): Change local variable name.
4905         (forget_cached_source_info_for_objfile): Remove declaration.
4906         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4907         * objfiles.c (objfile_relocate1): Remove declaration.
4908         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4909         declaration.
4910         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4911         * coffread.c (coff_symtab_read): Remove declaration.
4912         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4913         compunit_filetabs.
4914
4915 2019-01-09  Tom Tromey  <tom@tromey.com>
4916
4917         * symtab.c (lookup_objfile_from_block)
4918         (find_pc_sect_compunit_symtab, search_symbols)
4919         (default_collect_symbol_completion_matches_break_on): Use
4920         objfile_compunits.
4921         * objfiles.h (ALL_COMPUNITS): Remove.
4922         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4923         * cp-support.c (add_symbol_overload_list_qualified): Use
4924         objfile_compunits.
4925         * ada-lang.c (ada_collect_symbol_completion_matches)
4926         (ada_add_global_exceptions): Use objfile_compunits.
4927
4928 2019-01-09  Tom Tromey  <tom@tromey.com>
4929
4930         * source.c (select_source_symtab)
4931         (forget_cached_source_info_for_objfile): Remove declaration.
4932         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4933         declaration.
4934         * maint.c (count_symtabs_and_blocks): Remove declaration.
4935         * cp-support.c (add_symbol_overload_list_qualified): Remove
4936         declaration.
4937         * coffread.c (coff_symtab_read): Remove declaration.
4938         * symtab.c (lookup_symbol_in_objfile_symtabs)
4939         (basic_lookup_transparent_type_1): Use objfile_compunits.
4940         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4941         (info_sources_command, search_symbols)
4942         (default_collect_symbol_completion_matches_break_on)
4943         (make_source_files_completion_list): Remove declaration.
4944         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4945         (ada_collect_symbol_completion_matches)
4946         (ada_add_global_exceptions): Remove declaration.
4947         * linespec.c (iterate_over_all_matching_symtabs): Use
4948         objfile_compunits.
4949         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4950         (class objfile_compunits): New.
4951         (ALL_COMPUNITS): Use objfile_compunits.
4952         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4953         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4954         objfile_compunits.
4955         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4956
4957 2019-01-09  Tom Tromey  <tom@tromey.com>
4958
4959         * symtab.c (search_symbols)
4960         (default_collect_symbol_completion_matches_break_on): Use
4961         objfile_msymbols.
4962         * ada-lang.c (ada_lookup_simple_minsym)
4963         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4964         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4965         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4966         objfile_msymbols.
4967         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4968         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4969         * objc-lang.c (find_methods): Use objfile_msymbols.
4970         (info_selectors_command, info_classes_command): Likewise.
4971         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4972         * objfiles.h (class objfile_msymbols): New.
4973         (ALL_OBJFILE_MSYMBOLS): Remove.
4974         (ALL_MSYMBOLS): Remove.
4975
4976 2019-01-09  Tom Tromey  <tom@tromey.com>
4977
4978         * common/next-iterator.h (next_adapter): Add Iterator template
4979         parameter.
4980         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4981         (class all_objfiles_safe): New.
4982         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4983         * objfiles.c (put_objfile_before): Update comment.
4984         (add_separate_debug_objfile): Likewise.
4985         (free_all_objfiles): Use all_objfiles_safe.
4986         (objfile_purge_solibs): Likewise.
4987
4988 2019-01-09  Tom Tromey  <tom@tromey.com>
4989
4990         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4991         (expand_symtab_containing_pc, lookup_static_symbol)
4992         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4993         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4994         all_objfiles.
4995         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4996         * breakpoint.c (create_overlay_event_breakpoint)
4997         (create_longjmp_master_breakpoint)
4998         (create_std_terminate_master_breakpoint)
4999         (create_exception_master_breakpoint): Use all_objfiles.
5000         * linux-thread-db.c (try_thread_db_load_from_pdir)
5001         (has_libpthread): Use all_objfiles.
5002         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5003         * linespec.c (iterate_over_all_matching_symtabs)
5004         (search_minsyms_for_name): Use all_objfiles.
5005         * maint.c (maintenance_info_sections): Use all_objfiles.
5006         * main.c (captured_main_1): Use all_objfiles.
5007         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5008         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5009         * guile/scm-pretty-print.c
5010         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5011         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5012         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5013         (maintenance_print_msymbols): Use all_objfiles.
5014         * source.c (select_source_symtab): Use all_objfiles.
5015         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5016         * symfile.c (remove_symbol_file_command)
5017         (expand_symtabs_matching, map_symbol_filenames): Use
5018         all_objfiles.
5019         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5020         all_objfiles.
5021         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5022         * objc-lang.c (find_methods): Use all_objfiles.
5023         * objfiles.c (have_partial_symbols, have_full_symbols)
5024         (have_minimal_symbols, qsort_cmp)
5025         (default_iterate_over_objfiles_in_search_order): Use
5026         all_objfiles.
5027         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5028         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5029         (maintenance_check_psymtabs): Use all_objfiles.
5030         (ALL_PSYMTABS): Remove.
5031         * compile/compile-object-run.c (do_module_cleanup): Use
5032         all_objfiles.
5033         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5034         * cp-support.c (add_symbol_overload_list_qualified): Use
5035         all_objfiles.
5036         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5037         Use all_objfiles.
5038         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5039         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5040         all_objfiles.
5041         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5042         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5043         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5044         Uses all_objfiles.
5045         * solib.c (solib_read_symbols): Use all_objfiles
5046
5047 2019-01-09  Tom Tromey  <tom@tromey.com>
5048
5049         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5050         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5051         all_objfiles.
5052         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5053         * symmisc.c (print_symbol_bcache_statistics)
5054         (print_objfile_statistics, maintenance_print_objfiles)
5055         (maintenance_info_symtabs, maintenance_check_symtabs)
5056         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5057         all_objfiles.
5058         * source.c (forget_cached_source_info): Use all_objfiles.
5059         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5060         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5061         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5062         * objfiles.c (update_section_map): Use all_objfiles.
5063         (shared_objfile_contains_address_p): Likewise.
5064         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5065         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5066
5067 2019-01-09  Tom Tromey  <tom@tromey.com>
5068
5069         * common/next-iterator.h: New file.
5070         * objfiles.h (class all_objfiles): New.
5071         (struct objfile_iterator): New.
5072
5073 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5074
5075         * NEWS: Move the description of the changed "frame", "select-frame",
5076          and "info frame" commands to the Changed commands section.
5077
5078 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5079
5080         * gdbtypes.c (check_stub_method_group): Remove handling of old
5081         mangling schemes.
5082         * linespec.c (find_methods): Likewise.
5083         * stabsread.c (read_member_functions): Likewise.
5084         * valops.c (search_struct_method): Likewise.
5085         (value_struct_elt_for_reference): Likewise.
5086         * NEWS: Mention this change.
5087
5088 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5091         print_source_lines.
5092         * source.c (print_source_lines_base): Update line number check.
5093         (print_source_lines): New function.
5094         (source_lines_range::source_lines_range): New function.
5095         * source.h (class source_lines_range): New class.
5096         (print_source_lines): New declaration.
5097
5098 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5099
5100         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5101
5102 2019-01-08  Tom Tromey  <tom@tromey.com>
5103             Simon Marchi  <simon.marchi@ericsson.com>
5104
5105         PR gdb/24060
5106         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5107         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5108         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5109         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5110         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5111         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5112
5113 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5114
5115         * source.c (select_source_symtab): Move header comment to
5116         declaration in source.h.
5117         (forget_cached_source_info_for_objfile): Likewise.
5118         (forget_cached_source_info): Likewise.
5119         (identify_source_line): Likewise.
5120         * source.h (identify_source_line): Move declaration from symtab.h
5121         and add comment from source.c
5122         (print_source_lines): Likewise.
5123         (forget_cached_source_info_for_objfile): Likewise.
5124         (forget_cached_source_info): Likewise.
5125         (select_source_symtab): Likewise.
5126         (enum print_source_lines_flag): Move definition from symtab.h.
5127         * symtab.h (identify_source_line): Move declaration to source.h.
5128         (print_source_lines): Likewise.
5129         (forget_cached_source_info_for_objfile): Likewise.
5130         (forget_cached_source_info): Likewise.
5131         (select_source_symtab): Likewise.
5132         (enum print_source_lines_flag): Move definition to source.h.
5133         * tui/tui-hooks.c: Add 'source.h' include.
5134
5135 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * source.c (print_source_lines_base): Handle requests to print
5138         reverse line number sequences, and guard against empty lines
5139         string.
5140
5141 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         * source.c (print_source_lines_base): Fix skip of '\r' if next
5144         character is '\n'.
5145
5146 2019-01-06  Tom Tromey  <tom@tromey.com>
5147
5148         * c-exp.y (struct c_parse_state) <macro_original_text,
5149         expansion_obstack>: New member.
5150         (macro_original_text, expansion_obstack): Remove globals.
5151         (scan_macro_expansion, scanning_macro_expansion)
5152         (finished_macro_expansion): Update.
5153         (scan_macro_cleanup): Remove.
5154         (yylex, c_parse): Update.
5155
5156 2019-01-06  Tom Tromey  <tom@tromey.com>
5157
5158         * c-exp.y (struct c_parse_state) <strings>: New member.
5159         (operator_stoken): Update.
5160
5161 2019-01-06  Tom Tromey  <tom@tromey.com>
5162
5163         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5164         (union type_stack_elt) <typelist_val>: Now a pointer to
5165         std::vector.
5166         (type_stack_cleanup): Don't declare.
5167         (push_typelist): Update.
5168         * parse.c (pop_typelist): Return a std::vector.
5169         (push_typelist): Take a std::vector.
5170         (follow_types): Update.  Do not free args.
5171         (type_stack_cleanup): Remove.
5172         * c-exp.y (struct c_parse_state): New.
5173         (cpstate): New global.
5174         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5175         (nonempty_typelist): Update.
5176         (func_mod): Create a new vector.
5177         (c_parse): Create a c_parse_state.
5178         (check_parameter_typelist): Do not delete params.
5179         (function_method): Update.  Do not delete type_list.
5180
5181 2019-01-06  Tom Tromey  <tom@tromey.com>
5182
5183         PR gdb/28155:
5184         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5185         check_typedef.
5186         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5187         (print_return_value): Likewise.
5188
5189 2019-01-05  Tom Tromey  <tom@tromey.com>
5190
5191         * contrib/cleanup_check.py: Remove.
5192         * contrib/gcc-with-excheck: Remove.
5193         * contrib/exsummary.py: Remove.
5194         * contrib/excheck.py: Remove.
5195
5196 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5197
5198         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5199         NULL. Initialize tpprev to NULL instead of assigning it
5200         to NULL on the next statement.
5201         * windows-nat.c (windows_delete_thread): Remove check for
5202         main_thread_id before printing thread exit notifications.
5203         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5204         Remove thread ID check against main_thread_id.
5205         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5206         windows_delete_thread.
5207         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5208
5209 2019-01-04  Tom Tromey  <tom@tromey.com>
5210
5211         * compile/compile.c (_initialize_compile): Use upper case for
5212         metasyntactic variables.
5213         * symmisc.c (_initialize_symmisc): Use upper case for
5214         metasyntactic variables.
5215         * psymtab.c (_initialize_psymtab): Use upper case for
5216         metasyntactic variables.
5217         * demangle.c (demangle_command): Use upper case for metasyntactic
5218         variables.
5219         (_initialize_demangler): Likewise.
5220         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5221         variables.
5222
5223 2019-01-03  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5226
5227 2019-01-03  Tom Tromey  <tom@tromey.com>
5228
5229         * python/py-symtab.c (salpy_str): Update.
5230         (struct salpy_sal_object) <symtab>: Now a PyObject.
5231         (salpy_dealloc): Update.
5232         (del_objfile_sal): Use gdbpy_ref.
5233
5234 2019-01-03  Tom Tromey  <tom@tromey.com>
5235
5236         * python/py-type.c (convert_field): Use new_reference.  Return
5237         gdbpy_ref.
5238         (make_fielditem): Return gdbpy_ref.
5239         (typy_fields): Update.
5240         (typy_getitem): Update.
5241         (field_name): Return gdbpy_ref.  Use new_reference.
5242         (typy_iterator_iternext): Update.
5243
5244 2019-01-03  Tom Tromey  <tom@tromey.com>
5245
5246         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5247
5248 2019-01-03  Tom Tromey  <tom@tromey.com>
5249
5250         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5251         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5252         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5253         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5254         (pspy_set_type_printers): Likewise.
5255         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5256         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5257         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5258         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5259         (objfpy_set_type_printers): Likewise.
5260
5261 2019-01-03  Tom Tromey  <tom@tromey.com>
5262
5263         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5264         (gdbpy_print_stack): Use gdbpy_err_fetch.
5265         * python/python-internal.h (class gdbpy_err_fetch): New class.
5266         (class gdbpy_enter) <m_error_type, m_error_value,
5267         m_error_traceback>: Remove.
5268         <m_error>: New member.
5269         (gdbpy_exception_to_string): Don't declare.
5270         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5271         * python/py-value.c (convert_value_from_python): Use
5272         gdbpy_err_fetch.
5273         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5274         gdbpy_exception_to_string.
5275         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5276         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5277         gdbpy_err_fetch.
5278
5279 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * linux-nat.c (delete_lwp_cleanup): Delete.
5282         (struct lwp_deleter): New struct.
5283         (lwp_info_up): New typedef.
5284         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5285         lwp_info_up.
5286
5287 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * linux-fork.c (class scoped_switch_fork_info): New class.
5290         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5291
5292 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5293
5294         * valops.c (find_overload_match): Remove use of null_cleanup, and
5295         calls to do_cleanups.
5296
5297 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5298
5299         * compile/compile-cplus-types.c
5300         (compile_cplus_instance::decl_name): Handle changes to
5301         cp_func_name.
5302         * cp-support.c (cp_func_name): Update header comment, update
5303         return type.
5304         * cp-support.h (cp_func_name): Update return type in declaration.
5305         * valops.c (find_overload_match): Move temp_func local to top
5306         level of function and change its type.  Use temp_func to hold and
5307         delete temporary string obtained from cp_func_name.
5308
5309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5310
5311         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5312         gdb::char_vector, remove cleanup, and update uses of `msg`.
5313
5314 2019-01-03  Jim Wilson  <jimw@sifive.com>
5315
5316         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5317
5318 2019-01-02  Tom Tromey  <tom@tromey.com>
5319
5320         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5321         (tdesc_parse_xml): Remove cleanups.
5322         * target-descriptions.h (make_cleanup_free_target_description):
5323         Don't declare.
5324         (target_desc_deleter): New struct.
5325         (target_desc_up): New typedef.
5326         * target-descriptions.c (target_desc_deleter::operator()): Rename
5327         from free_target_description.
5328         (make_cleanup_free_target_description): Remove.
5329
5330 2019-01-02  Tom Tromey  <tom@tromey.com>
5331
5332         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5333         constructor, destructor.
5334         (linespec_parser): Remove typedef.
5335         (~linespec_parser): Rename from linespec_parser_delete.
5336         (linespec_lex_to_end, linespec_complete_label)
5337         (linespec_complete): Update.
5338         (decode_line_full): Remove cleanups.
5339         (decode_line_1): Update.
5340
5341 2019-01-02  Tom Tromey  <tom@tromey.com>
5342
5343         * python/python-internal.h (inferior_to_inferior_object): Change
5344         return type.
5345         * python/py-exitedevent.c (create_exited_event_object): Update.
5346         * python/py-inferior.c (inferior_to_inferior_object): Return
5347         gdbpy_ref.
5348         (python_new_inferior, python_inferior_deleted)
5349         (thread_to_thread_object, delete_thread_object)
5350         (build_inferior_list, gdbpy_selected_inferior): Update.
5351         * python/py-infthread.c (create_thread_object): Update.  Also fail
5352         if inferior_to_inferior_object fails.
5353
5354 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5355
5356         * inferior.h (class inferior) <displaced_step_state>: New field.
5357         * infrun.h (struct displaced_step_state): Move here from
5358         infrun.c.  Initialize fields, add constructor.
5359         <inf>: Remove field.
5360         <reset>: New method.
5361         * infrun.c (struct displaced_step_inferior_state): Move to
5362         infrun.h.
5363         (displaced_step_inferior_states): Remove.
5364         (get_displaced_stepping_state): Adust.
5365         (displaced_step_in_progress_any_inferior): Adjust.
5366         (displaced_step_in_progress_thread): Adjust.
5367         (displaced_step_in_progress): Adjust.
5368         (add_displaced_stepping_state): Remove.
5369         (get_displaced_step_closure_by_addr): Adjust.
5370         (remove_displaced_stepping_state): Remove.
5371         (infrun_inferior_exit): Call displaced_step_state.reset.
5372         (use_displaced_stepping): Don't check for NULL.
5373         (displaced_step_prepare_throw): Call
5374         get_displaced_stepping_state.
5375         (displaced_step_fixup): Don't check for NULL.
5376         (prepare_for_detach): Don't check for NULL.
5377
5378 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5379
5380         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5381          in case of call that did not complete.
5382
5383 2019-01-02  Andrey Utkin  <autkin@undo.io>
5384
5385         * symfile.c (find_separate_debug_file): Fix search of debug files for
5386         remote debuggee.
5387
5388 2019-01-02  Tom Tromey  <tom@tromey.com>
5389
5390         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5391         indentation.
5392         * python/py-frame.c (frapy_older): Remove cast.
5393         (frapy_newer): Likewise.
5394         * python/py-breakpoint.c (local_setattro): Remove cast.
5395         * python/py-arch.c (archpy_name): Remove local variable.
5396         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5397
5398 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5399
5400         * unittests/basic_string_view/element_access/char/empty.cc:
5401         Fix year range in copyright header.
5402
5403 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5406         Delete.
5407         <operator==>: Update with for removed field.
5408         <hash>: Likewise.
5409         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5410         <isa_features>: ...this.
5411         <abi_features>: New field.
5412         (riscv_isa_flen): Update comment.
5413         (riscv_abi_xlen): New declaration.
5414         (riscv_abi_flen): New declaration.
5415         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5416         isa_features.
5417         (riscv_abi_xlen): New function.
5418         (riscv_isa_flen): Update to get answer from isa_features.
5419         (riscv_abi_flen): New function.
5420         (riscv_has_fp_abi): Update to get answer from abi_features.
5421         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5422         xlen and flen.
5423         (riscv_call_info) <xlen, flen>: Update comment.
5424         (riscv_call_arg_struct): Remove invalid assertions
5425         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5426         is removed.
5427         (riscv_gdbarch_init): Gather isa features and abi features
5428         separately, ensure both match on the gdbarch when reusing an old
5429         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5430         a target with 64-bit float hardware.
5431
5432 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5433
5434         * source.c (search_command_helper): Stop reverse search
5435         when line 1 has been searched.
5436
5437 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5438
5439         * record-full.c (record_full_base_target::close): Rewrite
5440         record_full_core_buf_list free logic.
5441
5442 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * break-catch-syscall.c (print_one_catch_syscall): xfree
5445         the last text.
5446
5447 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5448
5449         * top.c (print_gdb_version): Update Copyright year in version
5450         message.
5451
5452 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5453
5454         Update copyright year range in all GDB files.
5455
5456 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5457
5458         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5459
5460 For older changes see ChangeLog-2018.
5461 \f
5462 Local Variables:
5463 mode: change-log
5464 left-margin: 8
5465 fill-column: 74
5466 version-control: never
5467 coding: utf-8
5468 End:
5469