gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * symtab.c (create_demangled_names_hash): Update.
   4         (symbol_set_names): Update.
   5         * objfiles.h (struct objfile_per_bfd_storage)
   6         <demangled_names_hash>: Now an htab_up.
   7         * objfiles.c (objfile_per_bfd_storage): Simplify.
   8
   9 2019-03-15  Tom Tromey  <tom@tromey.com>
  10
  11         * objfiles.h (struct objfile_per_bfd_storage): Declare
  12         destructor.
  13         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  14         New.
  15         (get_objfile_bfd_data): Use new.  Don't initialize
  16         language_of_main.
  17         (free_objfile_per_bfd_storage): Remove.
  18         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  19
  20 2019-03-15  Tom Tromey  <tom@tromey.com>
  21
  22         * symfile.c (reread_symbols): Update.
  23         * objfiles.c (objfile::objfile): Update.
  24         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  25         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  26         comment.
  27         (minimal_symbol_reader::install): Update.
  28         (terminate_minimal_symbol_table): Remove.
  29         * jit.c (jit_object_close_impl): Update.
  30
  31 2019-03-15  Tom Tromey  <tom@tromey.com>
  32
  33         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  34         initializations.
  35
  36 2019-03-15  Tom Tromey  <tom@tromey.com>
  37
  38         * objfiles.h (struct objfile_per_bfd_storage)
  39         <demangled_hash_languages>: Now a bitset.
  40         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  41         (lookup_minimal_symbol): Update.
  42
  43 2019-03-15  Tom Tromey  <tom@tromey.com>
  44
  45         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  46         Don't return the symbol.
  47         * coffread.c (record_minimal_symbol): Use record_full.
  48
  49 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  50
  51         The MS-Windows port of ncurses fails to switch to a color pair if
  52         one or both of the colors are the implicit default colors.  This
  53         change records the default colors when TUI is initialized, and
  54         then specifies them explicitly when a color pair uses the default
  55         colors.  This allows color styling in TUI mode on MS-Windows.
  56
  57         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  58         ncurses_norm_attr.
  59         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  60         colors in ncurses_norm_attr.
  61         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  62         "none", replace it with the default color recorded in
  63         ncurses_norm_attr.
  64
  65 2019-03-14  Tom Tromey  <tromey@adacore.com>
  66
  67         * source-cache.h (class source_cache) <get_source_lines>: Return
  68         std::string.
  69         * source-cache.c (source_cache::extract_lines): Handle case where
  70         first_pos==npos.  Return std::string.
  71         (source_cache::get_source_lines): Update.
  72
  73 2019-03-14  Tom Tromey  <tromey@adacore.com>
  74
  75         * NEWS: Add item for "style sources" commands.
  76         * source-cache.c (source_cache::get_source_lines): Check
  77         source_styling.
  78         * cli/cli-style.c (source_styling): New global.
  79         (_initialize_cli_style): Add "style sources" commands.
  80         (show_style_sources): New function.
  81         * cli/cli-style.h (source_styling): Declare.
  82
  83 2019-03-14  Pedro Alves  <palves@redhat.com>
  84             Tom Tromey  <tromey@adacore.com>
  85
  86         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  87         * tui/tui-winsource.c (tui_refill_source_window): New function,
  88         from...
  89         (tui_horizontal_source_scroll): ... here.  Move some logic.
  90         * cli/cli-style.c (set_style_enabled): Notify new observable.
  91         * tui/tui-hooks.c (tui_redisplay_source): New function.
  92         (tui_attach_detach_observers): Attach or detach
  93         tui_redisplay_source.
  94         * observable.h (source_styling_changed): New observable.
  95         * observable.c: Define source_styling_changed observable.
  96
  97 2019-03-13  Tom Tromey  <tromey@adacore.com>
  98
  99         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 100         (i386_gnu_nat_target::store_registers): Update.
 101         * target-debug.h (target_debug_print_std_string): New macro.
 102         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 103         * windows-tdep.c (display_one_tib): Update.
 104         * tui/tui-stack.c (tui_make_status_line): Update.
 105         * top.c (print_inferior_quit_action): Update.
 106         * thread.c (thr_try_catch_cmd): Update.
 107         (add_thread_with_info): Update.
 108         (thread_target_id_str): Update.
 109         (thr_try_catch_cmd): Update.
 110         (thread_command): Update.
 111         (thread_find_command): Update.
 112         * record-btrace.c (record_btrace_target::info_record)
 113         (record_btrace_resume_thread, record_btrace_target::resume)
 114         (record_btrace_cancel_resume, record_btrace_step_thread)
 115         (record_btrace_target::wait, record_btrace_target::wait)
 116         (record_btrace_target::wait, record_btrace_target::stop): Update.
 117         * progspace.c (print_program_space): Update.
 118         * process-stratum-target.c
 119         (process_stratum_target::thread_address_space): Update.
 120         * linux-fork.c (linux_fork_mourn_inferior)
 121         (detach_checkpoint_command, info_checkpoints_command)
 122         (linux_fork_context): Update.
 123         (linux_fork_detach): Update.
 124         (class scoped_switch_fork_info): Update.
 125         (delete_checkpoint_command): Update.
 126         * infrun.c (follow_fork_inferior): Update.
 127         (follow_fork_inferior): Update.
 128         (proceed_after_vfork_done): Update.
 129         (handle_vfork_child_exec_or_exit): Update.
 130         (follow_exec): Update.
 131         (displaced_step_prepare_throw): Update.
 132         (displaced_step_restore): Update.
 133         (start_step_over): Update.
 134         (resume_1): Update.
 135         (clear_proceed_status_thread): Update.
 136         (proceed): Update.
 137         (print_target_wait_results): Update.
 138         (do_target_wait): Update.
 139         (context_switch): Update.
 140         (stop_all_threads): Update.
 141         (restart_threads): Update.
 142         (finish_step_over): Update.
 143         (handle_signal_stop): Update.
 144         (switch_back_to_stepped_thread): Update.
 145         (keep_going_pass_signal): Update.
 146         (print_exited_reason): Update.
 147         (normal_stop): Update.
 148         * inferior.c (inferior_pid_to_str): Change return type.
 149         (print_selected_inferior): Update.
 150         (add_inferior): Update.
 151         (detach_inferior): Update.
 152         * dummy-frame.c (fprint_dummy_frames): Update.
 153         * dcache.c (dcache_info_1): Update.
 154         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 155         (btrace_fetch, btrace_clear): Update.
 156         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 157         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 158         type.
 159         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 160         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 161         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 162         * gdbarch.c, gdbarch.h: Rebuild.
 163         * gdbarch.sh (core_pid_to_str): Change return type.
 164         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 165         return type.
 166         (windows_nat_target::pid_to_str): Change return type.
 167         (windows_delete_thread): Update.
 168         (windows_nat_target::attach): Update.
 169         (windows_nat_target::files_info): Update.
 170         * target-delegates.c: Rebuild.
 171         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 172         return type.
 173         (sol_thread_target::pid_to_str): Change return type.
 174         * remote.c (class remote_target) <pid_to_str>: Change return
 175         type.
 176         (remote_target::pid_to_str): Change return type.
 177         (extended_remote_target::attach, remote_target::remote_stop_ns)
 178         (remote_target::remote_notif_remove_queued_reply)
 179         (remote_target::push_stop_reply, remote_target::disable_btrace):
 180         Update.
 181         (extended_remote_target::attach): Update.
 182         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 183         type.
 184         (gdbsim_target::pid_to_str): Change return type.
 185         * ravenscar-thread.c (struct ravenscar_thread_target)
 186         <pid_to_str>: Change return type.
 187         (ravenscar_thread_target::pid_to_str): Change return type.
 188         * procfs.c (class procfs_target) <pid_to_str>: Change return
 189         type.
 190         (procfs_target::pid_to_str): Change return type.
 191         (procfs_target::attach): Update.
 192         (procfs_target::detach): Update.
 193         (procfs_target::fetch_registers): Update.
 194         (procfs_target::store_registers): Update.
 195         (procfs_target::wait): Update.
 196         (procfs_target::files_info): Update.
 197         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 198         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 199         return type.
 200         (nto_procfs_target::pid_to_str): Change return type.
 201         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 202         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 203         return type.
 204         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 205         (exit_lwp): Update.
 206         (attach_proc_task_lwp_callback, get_detach_signal)
 207         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 208         (linux_nat_target::resume, wait_lwp, stop_callback)
 209         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 210         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 211         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 212         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 213         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 214         type.
 215         (inf_ptrace_target::attach): Update.
 216         (inf_ptrace_target::files_info): Update.
 217         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 218         type.
 219         (go32_nat_target::pid_to_str): Change return type.
 220         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 221         (gnu_nat_target::wait): Update.
 222         (gnu_nat_target::wait): Update.
 223         (gnu_nat_target::resume): Update.
 224         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 225         (fbsd_nat_target::wait): Update.
 226         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 227         type.
 228         (darwin_nat_target::attach): Update.
 229         * corelow.c (class core_target) <pid_to_str>: Change return type.
 230         (core_target::pid_to_str): Change return type.
 231         * target.c (normal_pid_to_str): Change return type.
 232         (default_pid_to_str): Likewise.
 233         (target_pid_to_str): Change return type.
 234         (target_translate_tls_address): Update.
 235         (target_announce_detach): Update.
 236         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 237         return type.
 238         (bsd_uthread_target::pid_to_str): Change return type.
 239         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 240         type.
 241         (bsd_kvm_target::pid_to_str): Change return type.
 242         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 243         return type.
 244         (aix_thread_target::pid_to_str): Change return type.
 245         * target.h (struct target_ops) <pid_to_str>: Change return type.
 246         (target_pid_to_str, normal_pid_to_str): Likewise.
 247         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 248         type.
 249         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 250         type.
 251         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 252         return type.
 253         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 254         type.
 255         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 256         type.
 257         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 258         return type.
 259
 260 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 261
 262         * NEWS: Mention that the new default MI version is 3.  Mention
 263         changes to the output of commands and events that deal with
 264         multi-location breakpoints.
 265         * breakpoint.c: Include "mi/mi-out.h".
 266         (print_one_breakpoint): Change output syntax if using MI version
 267         >= 3.
 268         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 269         New.
 270         (mi_multi_location_breakpoint_output_fixed): New.
 271         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 272         (mi_cmd_fix_multi_location_breakpoint_output): New.
 273         (mi_multi_location_breakpoint_output_fixed): New.
 274         * mi/mi-cmds.c (mi_cmds): Register command
 275         -fix-multi-location-breakpoint-output.
 276         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 277         interpreter "mi".
 278
 279 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 280
 281         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 282         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 283         instantiate mi_ui_out based on interpreter name.
 284         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 285         * mi/mi-main.c (mi_load_progress): Likewise.
 286
 287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 288
 289         * NEWS: Combine separate "New targets" sections for 8.3.
 290
 291 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 292
 293         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 294         (ppcfbsd_init_abi): Install gdbarch
 295         "fetch_tls_load_module_address" and "get_thread_local_address"
 296         methods.
 297
 298 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 299
 300         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 301         (riscv_fbsd_init_abi): Install gdbarch
 302         "fetch_tls_load_module_address" and "get_thread_local_address"
 303         methods.
 304
 305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 306
 307         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 308         (i386fbsd_init_abi): Install gdbarch
 309         "fetch_tls_load_module_address" and "get_thread_local_address"
 310         methods.
 311
 312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 313
 314         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 315         (amd64fbsd_init_abi): Install gdbarch
 316         "fetch_tls_load_module_address" and "get_thread_local_address"
 317         methods.
 318
 319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 320
 321         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 322         (struct fbsd_pspace_data): New type.
 323         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 324         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 325         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 326         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 327         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 328
 329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 330
 331         * gdbtypes.c (lookup_struct_elt): New function.
 332         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 333         * gdbtypes.h (struct struct_elt): New type.
 334         (lookup_struct_elt): New prototype.
 335
 336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 337
 338         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 339         remove disabled code block.
 340
 341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 342
 343         * gdbarch.sh (get_thread_local_address): New method.
 344         * gdbarch.h, gdbarch.c: Regenerate.
 345         * target.c (target_translate_tls_address): Use
 346         gdbarch_get_thread_local_address if present instead of
 347         target::get_thread_local_address.
 348
 349 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 350
 351         * target.h (target::get_thread_local_address): Update comment.
 352
 353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 354
 355         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 356         objfile->separate_debug_objfile_backlink if not NULL.
 357
 358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 359
 360         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 361         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 362         (amd64bsd_store_inferior_registers): Likewise.
 363         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 364         Enable segment base registers.
 365         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 366         PT_GETFSBASE and PT_GETGSBASE.
 367         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 368         PT_SETGSBASE.
 369         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 370         segment base registers.
 371         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 372
 373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 374
 375         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 376         Update calls to i386_target_description to add 'segments'
 377         parameter.
 378         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 379         add segment base registers.
 380         * arch/i386.c (i386_create_target_description): Add 'segments'
 381         parameter to enable segment base registers.
 382         * arch/i386.h (i386_create_target_description): Likewise.
 383         * features/i386/32bit-segments.xml: New file.
 384         * features/i386/32bit-segments.c: Generate.
 385         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 386         call to i386_target_description to add 'segments' parameter.
 387         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 388         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 389         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 390         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 391         if feature is present.
 392         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 393         Add 'segments' parameter to call to i386_target_description.
 394         (i386_target_description): Add 'segments' parameter to enable
 395         segment base registers.
 396         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 397         to call to i386_target_description.
 398         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 399         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 400         Define I386_NUM_REGS.
 401         (i386_target_description): Add 'segments' parameter to enable
 402         segment base registers.
 403
 404 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 405
 406         PR/24325
 407         * source-cache.c: #undef open and close, to avoid unresolved
 408         externals during linking.
 409
 410 2019-03-12  Tom Tromey  <tromey@adacore.com>
 411
 412         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 413         const.  Add initializers.
 414         (_initialize_remote): Don't initialize ptid globals.
 415
 416 2019-03-12  Pedro Alves  <palves@redhat.com>
 417
 418         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 419
 420 2019-03-12  Pedro Alves  <palves@redhat.com>
 421
 422         * cp-name-parser.y (main): Remove unused 'len' variable.
 423
 424 2019-03-12  Tom Tromey  <tromey@adacore.com>
 425
 426         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 427         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 428
 429 2019-03-12  Tom Tromey  <tromey@adacore.com>
 430
 431         * linux-nat.c (iterate_over_lwps): Update.
 432         (stop_callback): Remove parameter.
 433         (stop_wait_callback, detach_callback, resume_set_callback)
 434         (select_singlestep_lwp_callback, set_ignore_sigint)
 435         (status_callback, resumed_callback, resume_clear_callback)
 436         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 437         data parameter.
 438         (linux_nat_target::detach, linux_nat_target::resume)
 439         (linux_stop_and_wait_all_lwps, select_event_lwp)
 440         (linux_nat_filter_event, linux_nat_wait_1)
 441         (linux_nat_target::kill, linux_nat_target::stop)
 442         (linux_nat_target::stop): Update.
 443         (linux_nat_resume_callback): Change type.
 444         (resume_stopped_resumed_lwps, count_events_callback)
 445         (select_event_lwp_callback): Likewise.
 446         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 447         * arm-linux-nat.c (struct update_registers_data): Remove.
 448         (update_registers_callback): Change type.
 449         (arm_linux_insert_hw_breakpoint1): Update.
 450         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 451         parameter.
 452         (x86_linux_dr_set_addr): Update.
 453         (x86_linux_dr_set_control): Update.
 454         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 455         (iterate_over_lwps): Use gdb::function_view.
 456         * nat/aarch64-linux-hw-point.c (struct
 457         aarch64_dr_update_callback_param): Remove.
 458         (debug_reg_change_callback): Change type.
 459         (aarch64_notify_debug_reg_change): Update.
 460         * s390-linux-nat.c (s390_refresh_per_info): Update.
 461
 462 2019-03-11  Tom Tromey  <tromey@adacore.com>
 463
 464         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 465         redundant assignment to "this_cu".
 466
 467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 468
 469         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 470
 471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 472
 473         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 474         from...
 475         (rank_one_type): ... this.
 476
 477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 478
 479         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 480         from...
 481         (rank_one_type): ... this.
 482
 483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 484
 485         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 486         from...
 487         (rank_one_type): ... this.
 488
 489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 490
 491         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 492         from...
 493         (rank_one_type): ... this.
 494
 495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 496
 497         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 498         from...
 499         (rank_one_type): ... this.
 500
 501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 502
 503         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 504         from...
 505         (rank_one_type): ... this.
 506
 507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 508
 509         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 510         from...
 511         (rank_one_type): ... this.
 512
 513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 514
 515         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 516         from...
 517         (rank_one_type): ... this.
 518
 519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 520
 521         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 522         from...
 523         (rank_one_type): ... this.
 524
 525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 526
 527         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 528         from...
 529         (rank_one_type): ... this.
 530
 531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 532
 533         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 534         from...
 535         (rank_one_type): ... this.
 536
 537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 538
 539         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 540         from...
 541         (rank_one_type): ... this.
 542
 543 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 544
 545         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 546         inferior-events' shows the example events.
 547
 548 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 549
 550         Support styling on native MS-Windows console
 551
 552         PR/24315
 553         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 554         on MS-Windows if $TERM is not defined.
 555
 556         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 557
 558         * posix-hdep.c (gdb_console_fputs):
 559         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 560         functions.
 561         * ui-file.h (gdb_console_fputs): Add prototype.
 562
 563         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 564         back to fputs only if the former returns zero.
 565
 566 2019-03-07  Tom Tromey  <tom@tromey.com>
 567
 568         * symmisc.c (print_symbol_bcache_statistics): Update.
 569         (print_objfile_statistics): Update.
 570         * symfile.c (allocate_symtab): Update.
 571         * stabsread.c: Don't include bcache.h.
 572         * psymtab.h (struct psymbol_bcache): Don't declare.
 573         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 574         (psymbol_bcache_init, psymbol_bcache_free)
 575         (psymbol_bcache_get_bcache): Don't declare.
 576         * psymtab.c (struct psymbol_bcache): Remove.
 577         (psymtab_storage::psymtab_storage): Update.
 578         (psymtab_storage::~psymtab_storage): Update.
 579         (psymbol_bcache_init, psymbol_bcache_free)
 580         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 581         (add_psymbol_to_bcache): Update.
 582         (allocate_psymtab): Update.
 583         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 584         macro_cache>: No longer pointers.
 585         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 586         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 587         * macrotab.c (macro_bcache): Update.
 588         * macroexp.c: Don't include bcache.h.
 589         * gdbtypes.c (check_types_worklist): Update.
 590         (types_deeply_equal): Remove TRY/CATCH.  Update.
 591         * elfread.c (elf_symtab_read): Update.
 592         * dwarf2read.c: Don't include bcache.h.
 593         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 594         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 595         (print_bcache_statistics, bcache_memory_used): Don't declare.
 596         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 597         methods.  Rename all data members.
 598         * bcache.c (struct bcache): Move to bcache.h.
 599         (bcache::expand_hash_table): Rename from expand_hash_table.
 600         (bcache): Remove.
 601         (bcache::insert): Rename from bcache_full.
 602         (bcache::compare): Rename from bcache_compare.
 603         (bcache_xmalloc): Remove.
 604         (bcache::~bcache): Rename from bcache_xfree.
 605         (bcache::print_statistics): Rename from print_bcache_statistics.
 606         (bcache::memory_used): Rename from bcache_memory_used.
 607
 608 2019-03-07  Pedro Alves  <palves@redhat.com>
 609
 610         * infrun.c (normal_stop): Also check for
 611         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 612
 613 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * f-lang.c (value_from_host_double): Moved to...
 616         * value.c (value_from_host_double): ...here.
 617         * value.h (value_from_host_double): Declare.
 618         * guile/scm-math.c (vlscm_convert_typed_number): Use
 619         value_from_host_double.
 620         (vlscm_convert_number): Likewise.
 621         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 622         * python/py-value.c (convert_value_from_python): Likewise.
 623
 624 2019-03-06  Tom Tromey  <tom@tromey.com>
 625
 626         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 627
 628 2019-03-06  Tom Tromey  <tom@tromey.com>
 629
 630         * utils.h (free_current_contents): Don't declare.
 631         * utils.c (free_current_contents): Remove.
 632
 633 2019-03-06  Tom Tromey  <tom@tromey.com>
 634
 635         * top.c (quit_force): Update.
 636         * main.c (captured_command_loop): Update.
 637         * common/new-op.c (operator new): Update.
 638         * common/common-exceptions.c (struct catcher)
 639         <save_cleanup_chain>: Remove member.
 640         (exceptions_state_mc_init): Update.
 641         (exception_try_scope_entry): Return nullptr.
 642         (exception_try_scope_exit, exception_rethrow)
 643         (throw_exception_sjlj, throw_exception_cxx): Update.
 644         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 645         (all_cleanups, do_cleanups, discard_cleanups)
 646         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 647         (restore_cleanups, restore_final_cleanups): Don't declare.
 648         (do_final_cleanups): Remove parameter.
 649         * common/cleanups.c (cleanup_chain, make_cleanup)
 650         (make_cleanup_dtor, all_cleanups, do_cleanups)
 651         (discard_my_cleanups, discard_cleanups)
 652         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 653         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 654         (null_cleanup): Remove.
 655         (do_final_cleanups): Remove parameter.
 656
 657 2019-03-06  Tom Tromey  <tom@tromey.com>
 658
 659         * remote.c (remote_target::remote_parse_stop_reply): Use
 660         unique_xmalloc_ptr.
 661
 662 2019-03-06  Tom Tromey  <tom@tromey.com>
 663
 664         * stabsread.c (struct stabs_field_info): Rename from field_info.
 665         <list, fnlist>: Add initializers.
 666         <obstack>: New member.
 667         (read_member_functions, read_struct_fields, read_baseclasses):
 668         Allocate on obstack.  Don't use cleanups.
 669         (read_one_struct_field, read_member_functions, read_struct_fields)
 670         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 671         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 672         (read_struct_type): Update.
 673
 674 2019-03-06  Tom Tromey  <tom@tromey.com>
 675
 676         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 677         * common/filestuff.h (make_cleanup_close): Don't declare.
 678         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 679         Remove.
 680
 681 2019-03-06  Tom Tromey  <tom@tromey.com>
 682
 683         * solib-aix.c: Use make_scope_exit.
 684
 685 2019-03-06  Tom Tromey  <tom@tromey.com>
 686
 687         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 688         Use make_scope_exit.
 689
 690 2019-03-06  Tom Tromey  <tom@tromey.com>
 691
 692         * solib-svr4.c (disable_probes_interface): Remove parameter.
 693         (svr4_handle_solib_event): Use make_scope_exit.
 694
 695 2019-03-06  Tom Tromey  <tom@tromey.com>
 696
 697         * remote.c (struct stop_reply_deleter): Remove.
 698         (stop_reply_up): Update.
 699         (struct stop_reply): Derive from notif_event.  Don't typedef.
 700         <regcache>: Now a std::vector.
 701         (stop_reply_xfree): Remove.
 702         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 703         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 704         (remote_target::discard_pending_stop_replies): Use delete.
 705         (remote_target::remote_parse_stop_reply): Update.
 706         (remote_target::process_stop_reply): Update.
 707         * remote-notif.h (struct notif_event): Add virtual destructor.
 708         Remove "dtr" member.
 709         (struct notif_client) <alloc_event>: Return a unique_ptr.
 710         (notif_event_xfree): Don't declare.
 711         (notif_event_up): New typedef.
 712         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 713         (notif_event_xfree, do_notif_event_xfree): Remove.
 714         (remote_notif_state_xfree): Update.
 715
 716 2019-03-06  Tom Tromey  <tom@tromey.com>
 717
 718         * infrun.c (displaced_step_clear_cleanup): Now a
 719         forward_scope_exit type.
 720         (displaced_step_prepare_throw): Update.
 721         (displaced_step_fixup): Update.
 722
 723 2019-03-06  Tom Tromey  <tom@tromey.com>
 724
 725         * inferior.h (class inferior): Update comment.
 726         * gdbthread.h (class thread_info): Update comment.
 727
 728 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 729             Tom Tromey  <tom@tromey.com>
 730
 731         * stabsread.h (struct stab_section_list): Remove.
 732         (coffstab_build_psymtabs): Update.
 733         * dbxread.c (symbuf_sections): Now a std::vector.
 734         (sect_idx): New global.
 735         (fill_symbuf): Update.
 736         (coffstab_build_psymtabs): Change type of stabsects parameter.
 737         Update.
 738         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 739         std::vector.
 740         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 741         (coff_locate_sections): Update.
 742         (coff_symfile_read): Remove cleanups.  Update.
 743         (init_stringtab): Add storage parameter.
 744         (free_stringtab, free_stringtab_cleanup): Remove.
 745         (init_lineno): Add storage parameter.
 746         (free_linetab, free_linetab_cleanup): Remove.
 747
 748 2019-03-06  Pedro Alves  <palves@redhat.com>
 749
 750         * linux-fork.c (fork_info::clobber_regs): Delete.
 751         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 752         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 753         comment.  Adjust.
 754         (scoped_switch_fork_info::scoped_switch_fork_info)
 755         (checkpoint_command, linux_fork_context): Adjust
 756         fork_save_infrun_state calls.
 757
 758 2019-03-06  Pedro Alves  <palves@redhat.com>
 759
 760         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 761         (inf_has_multiple_threads): Return 'bool' and rewrite using
 762         inferior_info::threads().
 763
 764 2019-03-06  Pedro Alves  <palves@redhat.com>
 765
 766         * linux-fork.c: Include <list>.
 767         (fork_list): Now a std::list instance.
 768         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 769         (forks_exist_p, find_last_fork): Adjust.
 770         (new_fork): Delete.
 771         (one_fork_p): New.
 772         (add_fork): Adjust.
 773         (free_fork): Delete, folded into fork_info::~fork_info().
 774         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 775         Adjust.
 776         (init_fork_list): Delete.
 777         (linux_fork_killall, linux_fork_mourn_inferior)
 778         (linux_fork_detach, info_checkpoints_command): Adjust.
 779         (_initialize_linux_fork): No longer call init_fork_list.
 780
 781 2019-03-06  Pedro Alves  <palves@redhat.com>
 782
 783         * linux-fork.c (new_fork): New, split out of ...
 784         (add_fork): ... this.  Return void.  Move "first fork" special
 785         case from here, to ...
 786         (checkpoint_command): ... here.
 787         * linux-linux.h (add_fork): Return void.
 788
 789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 792
 793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 794             Chris January  <chris.january@arm.com>
 795             David Lecomber  <david.lecomber@arm.com>
 796
 797         * f-exp.y: New token, UNOP_INTRINSIC.
 798         (exp): New pattern using UNOP_INTRINSIC token.
 799         (f77_keywords): Add 'abs' keyword.
 800         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 801         (value_from_host_double): New function.
 802         (evaluate_subexp_f): Support UNOP_ABS.
 803
 804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 807         types.
 808
 809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 812         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 813         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 814
 815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 818
 819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 820             Chris January  <chris.january@arm.com>
 821
 822         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 823         * f-exp.y: Define 'KIND' token.
 824         (exp): New pattern for KIND expressions.
 825         (ptype): Handle types with a kind extension.
 826         (direct_abs_decl): Extend to spot kind extensions.
 827         (f77_keywords): Add 'kind' to the list.
 828         (push_kind_type): New function.
 829         (convert_to_kind_type): New function.
 830         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 831         * parse.c (operator_length_standard): Likewise.
 832         * parser-defs.h (enum type_pieces): Add tp_kind.
 833         * std-operator.def: Add UNOP_KIND.
 834
 835 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * f-exp.y (f_parse): Set yydebug.
 838
 839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * f-lang.c (evaluate_subexp_f): New function.
 842         (exp_descriptor_f): New global.
 843         (f_language_defn): Use exp_descriptor_f instead of
 844         exp_descriptor_standard.
 845
 846 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 847
 848         * f-exp.y (struct token): Add comments.
 849         (dot_ops): Remove uppercase versions and the end marker.
 850         (f77_keywords): Likewise.
 851         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 852         entries in the dot_ops array are case insensitive, and use
 853         strncasecmp to compare strings.  Also some whitespace cleanup in
 854         this area.  Similar for the f77_keywords array, except entries in
 855         this list might be case sensitive.
 856
 857 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * f-exp.y (struct f77_boolean_val): Add comments.
 860         (boolean_values): Remove uppercase versions, and end marker.
 861         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 862         and use strncasecmp to achieve case insensitivity.  Additionally,
 863         perform whitespace cleanup around this code.
 864
 865 2019-03-06  Tom Tromey  <tromey@adacore.com>
 866
 867         * remote-sim.c (gdbsim_target_open): Use result of
 868         gdb_argv::release.
 869
 870 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 871         Dirk Schubert  <dirk.schubert@arm.com>
 872         Chris January  <chris.january@arm.com>
 873
 874         * eval.c (evaluate_subexp_standard): Call Fortran argument
 875         wrapping logic.
 876         * f-lang.c (struct value): A value which can be passed into a
 877         Fortran function call.
 878         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 879         where appropriate.
 880         (struct type): Value ready for a Fortran function call.
 881         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 882         is needed.
 883         * f-lang.h (fortran_argument_convert): Declaration.
 884         (fortran_preserve_arg_pointer): Declaration.
 885         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 886
 887 2019-03-05  Tom Tromey  <tromey@adacore.com>
 888
 889         * python/py-prettyprint.c (print_string_repr): Remove #if.
 890         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 891
 892 2019-03-05  Tom Tromey  <tromey@adacore.com>
 893
 894         * target.c (the_dummy_target): Move later.  Change type to
 895         "dummy_target".
 896         (initialize_targets): Don't initialize the_dummy_target.
 897
 898 2019-03-05  Tom Tromey  <tromey@adacore.com>
 899
 900         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 901         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 902
 903 2019-03-05  Tom Tromey  <tromey@adacore.com>
 904
 905         * windows-nat.c (windows_nat_target::attach)
 906         (windows_nat_target::detach): Don't call gdb_flush.
 907         * valprint.c (generic_val_print, val_print, val_print_string):
 908         Don't call gdb_flush.
 909         * utils.c (defaulted_query): Don't call gdb_flush.
 910         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 911         * target.c (target_announce_detach): Don't call gdb_flush.
 912         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 913         * remote.c (extended_remote_target::attach): Don't call
 914         gdb_flush.
 915         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 916         * printcmd.c (do_examine): Don't call gdb_flush.
 917         (info_display_command): Don't call gdb_flush.
 918         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 919         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 920         * memattr.c (info_mem_command): Don't call gdb_flush.
 921         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 922         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 923         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 924         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 925         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 926         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 927         (gnu_nat_target::detach): Don't call gdb_flush.
 928         * f-valprint.c (f_val_print): Don't call gdb_flush.
 929         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 930         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 931         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 932         gdb_flush.
 933         * c-valprint.c (c_val_print): Don't call gdb_flush.
 934         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 935
 936 2019-03-05  Tom Tromey  <tromey@adacore.com>
 937
 938         * varobj.c (update_dynamic_varobj_children): Update.
 939         (install_default_visualizer): Use reset, not release.
 940         * value.c (set_internalvar): Update.
 941         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 942         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 943         ATTRIBUTE_UNUSED_RESULT.
 944
 945 2019-03-05  Tom Tromey  <tromey@adacore.com>
 946
 947         * remote.c (class scoped_remote_fd) <release>: Add
 948         ATTRIBUTE_UNUSED_RESULT.
 949
 950 2019-03-05  Tom Tromey  <tromey@adacore.com>
 951
 952         * macroexp.c (struct macro_buffer) <release>: Add
 953         ATTRIBUTE_UNUSED_RESULT.
 954
 955 2019-03-05  Tom Tromey  <tromey@adacore.com>
 956
 957         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 958         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 959         ATTRIBUTE_UNUSED_RESULT.
 960
 961 2019-03-05  Tom Tromey  <tromey@adacore.com>
 962
 963         * common/scoped_fd.h (class scoped_fd) <release>: Add
 964         ATTRIBUTE_UNUSED_RESULT.
 965
 966 2019-03-05  Tom Tromey  <tromey@adacore.com>
 967
 968         * parser-defs.h (struct parser_state) <release>: Add
 969         ATTRIBUTE_UNUSED_RESULT.
 970
 971 2019-03-05  Tom Tromey  <tromey@adacore.com>
 972
 973         * utils.h (class gdb_argv) <release>: Add
 974         ATTRIBUTE_UNUSED_RESULT.
 975         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 976
 977 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 978
 979         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 980         for-loop range, to avoid compiler warnings.
 981
 982         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 983         avoid compiler warnings about unused variables.
 984
 985         * NEWS: Mention end of support for native debugging on MS-Windows
 986         before XP.
 987
 988         PR gdb/24292
 989         * common/netstuff.c:
 990         * gdbserver/gdbreplay.c
 991         * gdbserver/remote-utils.c:
 992         * ser-tcp.c:
 993         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 994         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 995         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 996         'getaddrinfo' and 'freeaddrinfo' were not available before
 997         Windows XP, and mingw.org's MinGW headers by default define
 998         _WIN32_WINNT to 0x500.
 999
1000 2019-03-01  Gary Benson <gbenson@redhat.com>
1001
1002         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1003
1004 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1005             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1006
1007         PR gdb/8527
1008         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1009         set_sigint_trap, clear_sigint_trap.
1010
1011 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1012
1013         * target.c (target_detach): Clear the regcache and the
1014         frame cache.
1015
1016 2019-02-27  Pedro Alves  <palves@redhat.com>
1017
1018         * utils.c (set_screen_size): When we cap the height/width sizes,
1019         tweak the corresponding command variable to show "unlimited":
1020
1021 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1022             Pedro Alves  <palves@redhat.com>
1023
1024         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1025         before calling rl_set_screen_size.
1026
1027 2019-02-27  Tom Tromey  <tromey@adacore.com>
1028
1029         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1030         define.
1031         * python/py-value.c: Remove Python 2.4 workaround.
1032         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1033         workaround.
1034         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1035         Python 2.4 workaround.
1036         * python/python-internal.h: Remove Python 2.4 comment.
1037         (Py_ssize_t): Don't define.
1038         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1039         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1040         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1041         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1042         * python/python.c (do_start_initialization): Remove Python 2.4
1043         workaround.
1044         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1045         (print_children): Remove Python 2.4 workaround.
1046         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1047         workaround.
1048         (CHARBUFFERPROC_NAME): Remove.
1049         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1050         Python 2.4 workaround.
1051
1052 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1053
1054         * NEWS: Note minimum Python version.
1055
1056 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1057
1058         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1059         code from these functions.  Remove corresponding ifdefs.  Use
1060         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1061         Remove gotos and target of gotos.
1062         (infpy_search_memory): Likewise.
1063
1064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1067         (hppa_gdbarch_init): Don't register deleted functions with
1068         gdbarch.
1069
1070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1073         (h8300_unwind_sp): Delete.
1074         (h8300_dummy_id): Delete.
1075         (h8300_gdbarch_init): Don't register deleted functions with
1076         gdbarch.
1077
1078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1081         (ft32_unwind_pc): Delete.
1082         (ft32_unwind_sp): Delete.
1083         (ft32_gdbarch_init): Don't register deleted functions with
1084         gdbarch.
1085
1086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1089         (frv_unwind_pc): Delete.
1090         (frv_unwind_sp): Delete.
1091         (frv_gdbarch_init): Don't register deleted functions with
1092         gdbarch.
1093
1094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1097         (riscv_unwind_pc): Delete.
1098         (riscv_unwind_sp): Delete.
1099         (riscv_gdbarch_init): Don't register deleted functions with
1100         gdbarch.
1101
1102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1105         (csky_unwind_pc): Delete.
1106         (csky_unwind_sp): Delete.
1107         (csky_gdbarch_init): Don't register deleted functions with
1108         gdbarch.
1109
1110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1113         (cris_unwind_pc): Delete.
1114         (cris_unwind_sp): Delete.
1115         (cris_gdbarch_init): Don't register deleted functions with
1116         gdbarch.
1117
1118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1121         (bfin_unwind_pc): Delete.
1122         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1123
1124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1127         (arm_unwind_pc): Delete.
1128         (arm_unwind_sp): Delete.
1129         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1130
1131 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1134         (arc_unwind_pc): Delete.
1135         (arc_unwind_sp): Delete.
1136         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1137
1138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1141         (alpha_unwind_pc): Delete.
1142         (alpha_gdbarch_init): Don't register deleted functions with
1143         gdbarch.
1144
1145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1148         (aarch64_unwind_pc): Delete.
1149         (aarch64_unwind_sp): Delete.
1150         (aarch64_gdbarch_init): Don't register deleted functions with
1151         gdbarch.
1152
1153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * gdbtypes.c (type_align): Don't consider static members when
1156         computing structure alignment.
1157
1158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1161         return 0 for other types.
1162         * arch-utils.c (default_type_align): Always return 0.
1163         * gdbarch.h: Regenerate.
1164         * gdbarch.sh (type_align): Extend comment.
1165         * gdbtypes.c (type_align): Add additional comments, always call
1166         gdbarch_type_align before applying the default rules.
1167         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1168         generic code will then apply a suitable default.
1169         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1170         types, return 0 for other types.
1171
1172 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1173
1174         * NEWS: Create a new section for the next release branch.
1175         Rename the section of the current branch, now that it has
1176         been cut.
1177
1178 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1179
1180         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1181         * version.in: Bump version to 8.3.50.DATE-git.
1182
1183 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1184
1185         * aix-thread.c (ptid_cmp): Remove unused variable.
1186         (get_signaled_thread): Likewise.
1187         (store_regs_user_thread): Likewise.
1188         (store_regs_kernel_thread): Likewise.
1189         (fetch_regs_kernel_thread): Remove shadowed variable.
1190
1191 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * features/riscv/32bit-cpu.xml: Add register numbers.
1194         * features/riscv/32bit-fpu.c: Regenerate.
1195         * features/riscv/32bit-fpu.xml: Add register numbers.
1196         * features/riscv/64bit-cpu.xml: Add register numbers.
1197         * features/riscv/64bit-fpu.c: Regenerate.
1198         * features/riscv/64bit-fpu.xml: Add register numbers.
1199
1200 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1201
1202         * NEWS: Mention two argument form of gdb.Value constructor.
1203         * python/py-value.c (convert_buffer_and_type_to_value): New
1204         function.
1205         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1206         Add support for handling an optional second argument.  Call
1207         convert_buffer_and_type_to_value as appropriate.
1208         * python/python-internal.h (Py_buffer_deleter): New struct.
1209         (Py_buffer_up): New typedef.
1210
1211 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1212
1213         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1214         instead of releasing ownership.
1215
1216 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1217
1218         * dwarf2read.c (open_and_init_dwp_file): Call
1219         elf_numsections instead of bfd_count_sections to initialize
1220         dwp_file->num_sections.
1221
1222 2019-02-25  Tom Tromey  <tromey@adacore.com>
1223
1224         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1225
1226 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1227
1228         * gcore.in: Add '--readnever' option when invoking GDB.
1229
1230 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1231
1232         * MAINTAINERS: Update my email address.
1233
1234 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1235
1236         * build-id.c (build_id_to_debug_bfd_1): New function.
1237         (build_id_to_debug_bfd): Look for separate debug file in
1238         sysroot.
1239
1240 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * gdbarch.sh: Update the copyright year range that is placed into
1243         generated files.
1244
1245 2019-02-22  Keith Seitz  <keiths@redhat.com>
1246
1247         PR symtab/23853
1248         * linespec.c (create_sals_line_offset): Search for the default
1249         symtab's filename instead of its fullname.
1250
1251 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1252
1253         * NEWS: Update style defaults.
1254
1255 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * main.c (captured_main_1): Disable styling in batch mode.
1258
1259 2019-02-20  Tom Tromey  <tom@tromey.com>
1260
1261         * symtab.c (symtab_symbol_info): Fix typos.
1262
1263 2019-02-20  Tom Tromey  <tromey@adacore.com>
1264
1265         * findcmd.c (_initialize_mem_search): Use upper case for
1266         metasyntactic variables.
1267
1268 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1271         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1272
1273 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1274
1275         * top.h (source_file_name): Change to std::string.
1276         * top.c (source_file_name): Likewise.
1277         (command_line_input): Adjust.
1278         * cli/cli-script.c (script_from_file): Adjust.
1279
1280 2019-02-19  Tom Tromey  <tromey@adacore.com>
1281
1282         * ravenscar-thread.c
1283         (ravenscar_thread_target::update_thread_list): Don't call
1284         ada_build_task_list.
1285         * ada-lang.h (ada_build_task_list): Don't declare.
1286         * ada-tasks.c (struct ada_tasks_inferior_data)
1287         <task_list_valid_p>: Now bool.
1288         (read_known_tasks, ada_task_list_changed)
1289         (ada_tasks_invalidate_inferior_data): Update.
1290         (read_known_tasks_array): Return bool.
1291         (read_known_tasks_list): Likewise.
1292         (read_known_tasks): Return void.
1293         (ada_build_task_list): Now static.
1294
1295 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1298         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1299
1300 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1301
1302         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1303         variant for ada_tasks_pspace_data_handle and
1304         ada_tasks_inferior_data_handle.
1305         (ada_tasks_pspace_data_cleanup): New function.
1306         (ada_tasks_inferior_data_cleanup): New function.
1307
1308 2019-02-17  Tom Tromey  <tom@tromey.com>
1309
1310         * macrotab.h (macro_source_fullname): Return a std::string.
1311         * macrotab.c (macro_include, check_for_redefinition)
1312         (macro_undef, macro_lookup_definition, foreach_macro)
1313         (foreach_macro_in_scope): Update.
1314         (macro_source_fullname): Return a std::string.
1315         * macrocmd.c (show_pp_source_pos): Update.
1316
1317 2019-02-17  Tom Tromey  <tom@tromey.com>
1318
1319         * macrocmd.c (show_pp_source_pos): Style the file names.
1320
1321 2019-02-17  Tom Tromey  <tom@tromey.com>
1322
1323         PR tui/24197:
1324         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1325
1326 2019-02-17  Tom Tromey  <tom@tromey.com>
1327
1328         * ada-lang.c (user_select_syms): Use filtered printing.
1329         * utils.c (wrap_style): New global.
1330         (desired_style): Remove.
1331         (emit_style_escape): Add stream parameter.
1332         (set_output_style, reset_terminal_style, prompt_for_continue):
1333         Update.
1334         (flush_wrap_buffer): Only flush gdb_stdout.
1335         (wrap_here): Set wrap_style.
1336         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1337         treat escape sequences as a character.  Change when wrap buffer is
1338         flushed.
1339         (fputs_styled): Do not set the output style when the default is
1340         requested.
1341         * ui-style.h (struct ui_file_style) <is_default>: New method.
1342         * source.c (print_source_lines_base): Emit escape sequences in one
1343         piece.
1344
1345 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1346
1347         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1348         integers and enumeration types.
1349
1350 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1351
1352         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1353         instead of lookup_symbol_in_language
1354         (do_exact_match): New function.
1355         (ada_get_symbol_name_matcher): Return do_exact_match when
1356         doing a verbatim match.
1357
1358 2019-02-15  Tom Tromey  <tromey@adacore.com>
1359
1360         * ravenscar-thread.c (ravenscar_thread_target::resume)
1361         (ravenscar_thread_target::wait): Special case wildcard requests.
1362
1363 2019-02-15  Tom Tromey  <tromey@adacore.com>
1364
1365         * ravenscar-thread.c (base_ptid): Remove.
1366         (struct ravenscar_thread_target) <close>: New method.
1367         <m_base_ptid>: New member.
1368         <update_inferior_ptid, active_task, task_is_currently_active,
1369         runtime_initialized>: Declare methods.
1370         <ravenscar_thread_target>: Add constructor.
1371         (ravenscar_thread_target::task_is_currently_active)
1372         (ravenscar_thread_target::update_inferior_ptid)
1373         (ravenscar_runtime_initialized): Rename.  Now methods.
1374         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1375         (ravenscar_thread_target::update_thread_list): Update.
1376         (ravenscar_thread_target::active_task): Now method.
1377         (ravenscar_thread_target::store_registers)
1378         (ravenscar_thread_target::prepare_to_store)
1379         (ravenscar_thread_target::prepare_to_store)
1380         (ravenscar_thread_target::mourn_inferior): Update.
1381         (ravenscar_inferior_created): Use "new" to create target.
1382         (ravenscar_thread_target::get_ada_task_ptid): Update.
1383         (_initialize_ravenscar): Don't initialize base_ptid.
1384         (ravenscar_ops): Remove global.
1385
1386 2019-02-15  Tom Tromey  <tromey@adacore.com>
1387
1388         * target.h (push_target): Declare new overload.
1389         * target.c (push_target): New overload, taking an rvalue reference.
1390         * remote.c (remote_target::open_1): Use push_target overload.
1391         * corelow.c (core_target_open): Use push_target overload.
1392
1393 2019-02-15  Tom Tromey  <tromey@adacore.com>
1394
1395         * ravenscar-thread.c (is_ravenscar_task)
1396         (ravenscar_task_is_currently_active): Return bool.
1397         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1398         (_initialize_ravenscar): Remove "(void)".
1399         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1400         Return bool.
1401
1402 2019-02-15  Tom Tromey  <tromey@adacore.com>
1403
1404         * ravenscar-thread.c (ravenscar_runtime_initializer)
1405         (has_ravenscar_runtime, get_running_thread_id)
1406         (ravenscar_thread_target::resume): Fix indentation.
1407
1408 2019-02-15  Tom Tromey  <tromey@adacore.com>
1409
1410         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1411         from ravenscar_arch_ops.
1412         (sparc_ravenscar_ops::fetch_registers)
1413         (sparc_ravenscar_ops::store_registers): Now methods.
1414         (sparc_ravenscar_prepare_to_store): Remove.
1415         (sparc_ravenscar_ops): Redefine.
1416         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1417         methods and destructor.  Remove members.
1418         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1419         (ravenscar_thread_target::store_registers)
1420         (ravenscar_thread_target::prepare_to_store): Update.
1421         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1422         Remove.
1423         (struct ppc_ravenscar_powerpc_ops): Derive from
1424         ravenscar_arch_ops.
1425         (ppc_ravenscar_powerpc_ops::fetch_registers)
1426         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1427         (ppc_ravenscar_powerpc_ops): Redefine.
1428         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1429         (ppc_ravenscar_e500_ops::fetch_registers)
1430         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1431         (ppc_ravenscar_e500_ops): Redefine.
1432         * aarch64-ravenscar-thread.c
1433         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1434         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1435         (aarch64_ravenscar_fetch_registers)
1436         (aarch64_ravenscar_store_registers): Now methods.
1437         (aarch64_ravenscar_ops): Redefine.
1438
1439 2019-02-15  Tom Tromey  <tromey@adacore.com>
1440
1441         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1442         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1443         (ravenscar_thread_target::stopped_by_watchpoint)
1444         (ravenscar_thread_target::stopped_data_address)
1445         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1446
1447 2019-02-15  Tom Tromey  <tromey@adacore.com>
1448
1449         * ravenscar-thread.c: Fix some typos.
1450
1451 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1452             Tom Tromey  <tromey@adacore.com>
1453
1454         * ada-lang.c (ada_exception_sal): Change addr_string to a
1455         std::string.
1456         (create_ada_exception_catchpoint): Update.
1457
1458 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1459             Tom Tromey  <tromey@adacore.com>
1460
1461         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1462         (bp_location_ops): Remove.
1463         (base_breakpoint_allocate_location): Update.
1464         (free_bp_location): Update.
1465         * ada-lang.c (class ada_catchpoint_location)
1466         <ada_catchpoint_location>: Remove ops parameter.
1467         (ada_catchpoint_location_dtor): Remove.
1468         (ada_catchpoint_location_ops): Remove.
1469         (allocate_location_exception): Update.
1470         * breakpoint.h (struct bp_location_ops): Remove.
1471         (class bp_location) <bp_location>: Remove bp_location_ops
1472         parameter.
1473         <~bp_location>: Add destructor.
1474         <ops>: Remove.
1475
1476 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1477             Pedro Alves  <palves@redhat.com>
1478
1479         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1480         'PATH_MAX'.
1481
1482 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1483             Samuel Thibault  <samuel.thibault@gnu.org>
1484             Thomas Schwinge  <thomas@codesourcery.com>
1485
1486         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1487         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1488
1489 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1490
1491         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1492         (check_empty): Use "const char *".
1493
1494         * gnu-nat.c (gnu_nat_target::detach): Instead of
1495         'detach_inferior (pid)' call
1496         'detach_inferior (find_inferior_pid (pid))'.
1497
1498         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1499         'nat/fork-inferior.o'.
1500         * gnu-nat.c: #include "nat/fork-inferior.h".
1501
1502         * gnu-nat.c (gnu_nat_target::detach): Instead of
1503         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1504         * gnu-nat.h: #include "inf-child.h".
1505         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1506         'i386_gnu_nat_target::fetch_registers'.
1507         (gnu_store_registers): Rename/move to
1508         'i386_gnu_nat_target::store_registers'.
1509
1510         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1511         * gnu-nat.h (mach_thread_info): New function.
1512         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1513
1514         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1515
1516 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1517
1518         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1519
1520 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1521
1522         * windows-nat.c (windows_add_thread): Add new parameter
1523         "main_thread_p" with default value set to false.  Update
1524         function documentation as well as all callers.
1525         (windows_delete_thread): Likewise.
1526         (fake_create_process): Update call to windows_add_thread.
1527         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1528         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1529         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1530         call to windows_delete_thread.
1531
1532 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1533
1534         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1535
1536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1537
1538         * symfile.c (find_separate_debug_file): Use canonical path of
1539         sysroot with child_path instead of gdb_sysroot if it is valid.
1540
1541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1542
1543         * symfile.c (find_separate_debug_file): Use child_path to
1544         determine if an object file is under a sysroot.
1545
1546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1547
1548         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1549         unittests/child-path-selftests.c.
1550         * common/pathstuff.c (child_path): New function.
1551         * common/pathstuff.h (child_path): New prototype.
1552         * unittests/child-path-selftests.c: New file.
1553
1554 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1555
1556         * symfile.c (find_separate_debug_file): Look for separate debug
1557         files in debug directories under the sysroot.
1558
1559 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1560
1561         * symtab.h (struct minimal_symbol data_p): New const method.
1562         (struct minimal_symbol text_p): Likewise.
1563         * symtab.c (output_source_filename): Use file name style
1564         to print file name.
1565         (print_symbol_info): Likewise.
1566         (print_msymbol_info): Use address style to print addresses.
1567         Use function name style to print executable text symbols.
1568         (expand_symtab_containing_pc): Use data_p.
1569         (find_pc_sect_compunit_symtab): Likewise.
1570
1571 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1572
1573         * breakpoint.c (describe_other_breakpoints): Use address style
1574         to print addresses.
1575         (say_where): Likewise.
1576
1577 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1578
1579         * ada-typeprint.c (print_func_type): Print function name
1580         style to print function name.
1581         * c-typeprint.c (c_print_type_1): Likewise.
1582
1583 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1584
1585         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1586         for execve.
1587
1588 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1589
1590         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1591         type_stack.
1592
1593 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1594
1595         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1596         TYPE_CODE_REF types.
1597
1598 2019-02-08  Jim Wilson  <jimw@sifive.com>
1599
1600         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1601         (riscv_linux_fregset): New.
1602         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1603
1604 2019-02-07  Tom Tromey  <tom@tromey.com>
1605
1606         * thread.c (thread_cancel_execution_command): Update.
1607         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1608         methods.
1609         (struct thread_fsm_ops): Remove.
1610         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1611         (thread_fsm_should_stop, thread_fsm_return_value)
1612         (thread_fsm_set_finished, thread_fsm_finished_p)
1613         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1614         Don't declare.
1615         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1616         * infrun.c (clear_proceed_status_thread)
1617         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1618         (print_stop_event): Update.
1619         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1620         Add constructor.
1621         (step_command_fsm_ops): Remove.
1622         (new_step_command_fsm): Remove.
1623         (step_1): Update.
1624         (step_command_fsm::should_stop): Rename from
1625         step_command_fsm_should_stop.
1626         (step_command_fsm::clean_up): Rename from
1627         step_command_fsm_clean_up.
1628         (step_command_fsm::do_async_reply_reason): Rename from
1629         step_command_fsm_async_reply_reason.
1630         (struct until_next_fsm): Inherit from thread_fsm.  Add
1631         constructor.
1632         (until_next_fsm_ops): Remove.
1633         (new_until_next_fsm): Remove.
1634         (until_next_fsm::should_stop): Rename from
1635         until_next_fsm_should_stop.
1636         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1637         (until_next_fsm::do_async_reply_reason): Rename from
1638         until_next_fsm_async_reply_reason.
1639         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1640         constructor.  Change type of breakpoint.
1641         (finish_command_fsm_ops): Remove.
1642         (new_finish_command_fsm): Remove.
1643         (finish_command_fsm::should_stop): Rename from
1644         finish_command_fsm_should_stop.
1645         (finish_command_fsm::clean_up): Rename from
1646         finish_command_fsm_clean_up.
1647         (finish_command_fsm::return_value): Rename from
1648         finish_command_fsm_return_value.
1649         (finish_command_fsm::do_async_reply_reason): Rename from
1650         finish_command_fsm_async_reply_reason.
1651         (finish_command): Update.
1652         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1653         Add constructor.
1654         (call_thread_fsm_ops): Remove.
1655         (call_thread_fsm::call_thread_fsm): Rename from
1656         new_call_thread_fsm.
1657         (call_thread_fsm::should_stop): Rename from
1658         call_thread_fsm_should_stop.
1659         (call_thread_fsm::should_notify_stop): Rename from
1660         call_thread_fsm_should_notify_stop.
1661         (run_inferior_call, call_function_by_hand_dummy): Update.
1662         * cli/cli-interp.c (should_print_stop_to_console): Update.
1663         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1664         Add constructor.  Change type of location_breakpoint,
1665         caller_breakpoint.
1666         (until_break_fsm_ops): Remove.
1667         (new_until_break_fsm): Remove.
1668         (until_break_fsm::should_stop): Rename from
1669         until_break_fsm_should_stop.
1670         (until_break_fsm::clean_up): Rename from
1671         until_break_fsm_clean_up.
1672         (until_break_fsm::do_async_reply_reason): Rename from
1673         until_break_fsm_async_reply_reason.
1674         (until_break_command): Update.
1675         * thread-fsm.c: Remove.
1676         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1677
1678 2019-02-07  Tom Tromey  <tom@tromey.com>
1679
1680         * yy-remap.h: Add include guard.
1681         * xtensa-tdep.h: Add include guard.
1682         * xcoffread.h: Rename include guard.
1683         * varobj-iter.h: Add include guard.
1684         * tui/tui.h: Rename include guard.
1685         * tui/tui-winsource.h: Rename include guard.
1686         * tui/tui-wingeneral.h: Rename include guard.
1687         * tui/tui-windata.h: Rename include guard.
1688         * tui/tui-win.h: Rename include guard.
1689         * tui/tui-stack.h: Rename include guard.
1690         * tui/tui-source.h: Rename include guard.
1691         * tui/tui-regs.h: Rename include guard.
1692         * tui/tui-out.h: Rename include guard.
1693         * tui/tui-layout.h: Rename include guard.
1694         * tui/tui-io.h: Rename include guard.
1695         * tui/tui-hooks.h: Rename include guard.
1696         * tui/tui-file.h: Rename include guard.
1697         * tui/tui-disasm.h: Rename include guard.
1698         * tui/tui-data.h: Rename include guard.
1699         * tui/tui-command.h: Rename include guard.
1700         * tic6x-tdep.h: Add include guard.
1701         * target/waitstatus.h: Rename include guard.
1702         * target/wait.h: Rename include guard.
1703         * target/target.h: Rename include guard.
1704         * target/resume.h: Rename include guard.
1705         * target-float.h: Rename include guard.
1706         * stabsread.h: Add include guard.
1707         * rs6000-tdep.h: Add include guard.
1708         * riscv-fbsd-tdep.h: Add include guard.
1709         * regformats/regdef.h: Rename include guard.
1710         * record.h: Rename include guard.
1711         * python/python.h: Rename include guard.
1712         * python/python-internal.h: Rename include guard.
1713         * python/py-stopevent.h: Rename include guard.
1714         * python/py-ref.h: Rename include guard.
1715         * python/py-record.h: Rename include guard.
1716         * python/py-record-full.h: Rename include guard.
1717         * python/py-record-btrace.h: Rename include guard.
1718         * python/py-instruction.h: Rename include guard.
1719         * python/py-events.h: Rename include guard.
1720         * python/py-event.h: Rename include guard.
1721         * procfs.h: Add include guard.
1722         * proc-utils.h: Add include guard.
1723         * p-lang.h: Add include guard.
1724         * or1k-tdep.h: Rename include guard.
1725         * observable.h: Rename include guard.
1726         * nto-tdep.h: Rename include guard.
1727         * nat/x86-linux.h: Rename include guard.
1728         * nat/x86-linux-dregs.h: Rename include guard.
1729         * nat/x86-gcc-cpuid.h: Add include guard.
1730         * nat/x86-dregs.h: Rename include guard.
1731         * nat/x86-cpuid.h: Rename include guard.
1732         * nat/ppc-linux.h: Rename include guard.
1733         * nat/mips-linux-watch.h: Rename include guard.
1734         * nat/linux-waitpid.h: Rename include guard.
1735         * nat/linux-ptrace.h: Rename include guard.
1736         * nat/linux-procfs.h: Rename include guard.
1737         * nat/linux-osdata.h: Rename include guard.
1738         * nat/linux-nat.h: Rename include guard.
1739         * nat/linux-namespaces.h: Rename include guard.
1740         * nat/linux-btrace.h: Rename include guard.
1741         * nat/glibc_thread_db.h: Rename include guard.
1742         * nat/gdb_thread_db.h: Rename include guard.
1743         * nat/gdb_ptrace.h: Rename include guard.
1744         * nat/fork-inferior.h: Rename include guard.
1745         * nat/amd64-linux-siginfo.h: Rename include guard.
1746         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1747         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1748         * nat/aarch64-linux.h: Rename include guard.
1749         * nat/aarch64-linux-hw-point.h: Rename include guard.
1750         * mn10300-tdep.h: Add include guard.
1751         * mips-linux-tdep.h: Add include guard.
1752         * mi/mi-parse.h: Rename include guard.
1753         * mi/mi-out.h: Rename include guard.
1754         * mi/mi-main.h: Rename include guard.
1755         * mi/mi-interp.h: Rename include guard.
1756         * mi/mi-getopt.h: Rename include guard.
1757         * mi/mi-console.h: Rename include guard.
1758         * mi/mi-common.h: Rename include guard.
1759         * mi/mi-cmds.h: Rename include guard.
1760         * mi/mi-cmd-break.h: Rename include guard.
1761         * m2-lang.h: Add include guard.
1762         * location.h: Rename include guard.
1763         * linux-record.h: Rename include guard.
1764         * linux-nat.h: Add include guard.
1765         * linux-fork.h: Add include guard.
1766         * i386-darwin-tdep.h: Rename include guard.
1767         * hppa-linux-offsets.h: Add include guard.
1768         * guile/guile.h: Rename include guard.
1769         * guile/guile-internal.h: Rename include guard.
1770         * gnu-nat.h: Rename include guard.
1771         * gdb-stabs.h: Rename include guard.
1772         * frv-tdep.h: Add include guard.
1773         * f-lang.h: Add include guard.
1774         * event-loop.h: Add include guard.
1775         * darwin-nat.h: Rename include guard.
1776         * cp-abi.h: Rename include guard.
1777         * config/sparc/nm-sol2.h: Rename include guard.
1778         * config/nm-nto.h: Rename include guard.
1779         * config/nm-linux.h: Add include guard.
1780         * config/i386/nm-i386gnu.h: Rename include guard.
1781         * config/djgpp/nl_types.h: Rename include guard.
1782         * config/djgpp/langinfo.h: Rename include guard.
1783         * compile/gcc-cp-plugin.h: Add include guard.
1784         * compile/gcc-c-plugin.h: Add include guard.
1785         * compile/compile.h: Rename include guard.
1786         * compile/compile-object-run.h: Rename include guard.
1787         * compile/compile-object-load.h: Rename include guard.
1788         * compile/compile-internal.h: Rename include guard.
1789         * compile/compile-cplus.h: Rename include guard.
1790         * compile/compile-c.h: Rename include guard.
1791         * common/xml-utils.h: Rename include guard.
1792         * common/x86-xstate.h: Rename include guard.
1793         * common/version.h: Rename include guard.
1794         * common/vec.h: Rename include guard.
1795         * common/tdesc.h: Rename include guard.
1796         * common/selftest.h: Rename include guard.
1797         * common/scoped_restore.h: Rename include guard.
1798         * common/scoped_mmap.h: Rename include guard.
1799         * common/scoped_fd.h: Rename include guard.
1800         * common/safe-iterator.h: Rename include guard.
1801         * common/run-time-clock.h: Rename include guard.
1802         * common/refcounted-object.h: Rename include guard.
1803         * common/queue.h: Rename include guard.
1804         * common/ptid.h: Rename include guard.
1805         * common/print-utils.h: Rename include guard.
1806         * common/preprocessor.h: Rename include guard.
1807         * common/pathstuff.h: Rename include guard.
1808         * common/observable.h: Rename include guard.
1809         * common/netstuff.h: Rename include guard.
1810         * common/job-control.h: Rename include guard.
1811         * common/host-defs.h: Rename include guard.
1812         * common/gdb_wait.h: Rename include guard.
1813         * common/gdb_vecs.h: Rename include guard.
1814         * common/gdb_unlinker.h: Rename include guard.
1815         * common/gdb_unique_ptr.h: Rename include guard.
1816         * common/gdb_tilde_expand.h: Rename include guard.
1817         * common/gdb_sys_time.h: Rename include guard.
1818         * common/gdb_string_view.h: Rename include guard.
1819         * common/gdb_splay_tree.h: Rename include guard.
1820         * common/gdb_setjmp.h: Rename include guard.
1821         * common/gdb_ref_ptr.h: Rename include guard.
1822         * common/gdb_optional.h: Rename include guard.
1823         * common/gdb_locale.h: Rename include guard.
1824         * common/gdb_assert.h: Rename include guard.
1825         * common/filtered-iterator.h: Rename include guard.
1826         * common/filestuff.h: Rename include guard.
1827         * common/fileio.h: Rename include guard.
1828         * common/environ.h: Rename include guard.
1829         * common/common-utils.h: Rename include guard.
1830         * common/common-types.h: Rename include guard.
1831         * common/common-regcache.h: Rename include guard.
1832         * common/common-inferior.h: Rename include guard.
1833         * common/common-gdbthread.h: Rename include guard.
1834         * common/common-exceptions.h: Rename include guard.
1835         * common/common-defs.h: Rename include guard.
1836         * common/common-debug.h: Rename include guard.
1837         * common/cleanups.h: Rename include guard.
1838         * common/buffer.h: Rename include guard.
1839         * common/btrace-common.h: Rename include guard.
1840         * common/break-common.h: Rename include guard.
1841         * cli/cli-utils.h: Rename include guard.
1842         * cli/cli-style.h: Rename include guard.
1843         * cli/cli-setshow.h: Rename include guard.
1844         * cli/cli-script.h: Rename include guard.
1845         * cli/cli-interp.h: Rename include guard.
1846         * cli/cli-decode.h: Rename include guard.
1847         * cli/cli-cmds.h: Rename include guard.
1848         * charset-list.h: Add include guard.
1849         * buildsym-legacy.h: Rename include guard.
1850         * bfin-tdep.h: Add include guard.
1851         * ax.h: Rename include guard.
1852         * arm-linux-tdep.h: Add include guard.
1853         * arm-fbsd-tdep.h: Add include guard.
1854         * arch/xtensa.h: Rename include guard.
1855         * arch/tic6x.h: Add include guard.
1856         * arch/i386.h: Add include guard.
1857         * arch/arm.h: Rename include guard.
1858         * arch/arm-linux.h: Rename include guard.
1859         * arch/arm-get-next-pcs.h: Rename include guard.
1860         * arch/amd64.h: Add include guard.
1861         * arch/aarch64-insn.h: Rename include guard.
1862         * arch-utils.h: Rename include guard.
1863         * annotate.h: Add include guard.
1864         * amd64-darwin-tdep.h: Rename include guard.
1865         * aarch64-linux-tdep.h: Add include guard.
1866         * aarch64-fbsd-tdep.h: Add include guard.
1867         * aarch32-linux-nat.h: Add include guard.
1868
1869 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1870
1871         * macrotab.c (macro_define_internal): New function that
1872         factorizes macro_define_object_internal and macro_define_function
1873         code.
1874         (macro_define_object_internal): Use macro_define_internal.
1875         (macro_define_function): Likewise.
1876
1877 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1878
1879         * macrocmd.c (extract_identifier): Return
1880         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1881         callers.
1882
1883 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1884
1885         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1886
1887 2019-02-05  Tom Tromey  <tom@tromey.com>
1888
1889         * target.c (target_stack::unpush): Move assertion earlier.
1890
1891 2019-01-30  Tom Tromey  <tom@tromey.com>
1892
1893         PR python/23615:
1894         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1895         (gdbpy_parse_and_eval): Likewise.
1896         * python/python-internal.h (gdbpy_allow_threads): New class.
1897
1898 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1899
1900         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1901         (aarch64_fbsd_fpregmap): Move earlier.
1902         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1903         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1904         instead of individual calls to trad_frame_set_reg_addr.
1905         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1906         earlier.
1907         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1908         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1909         instead of individual calls to trad_frame_set_reg_addr.
1910
1911 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1912
1913         * CONTRIBUTE: Replace contribution list with wiki link.
1914
1915 2019-01-25  Tom Tromey  <tom@tromey.com>
1916
1917         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1918
1919 2019-01-25  Tom Tromey  <tom@tromey.com>
1920
1921         * xtensa-linux-nat.c: Fix common/ includes.
1922         * xml-support.h: Fix common/ includes.
1923         * xml-support.c: Fix common/ includes.
1924         * x86-linux-nat.c: Fix common/ includes.
1925         * windows-nat.c: Fix common/ includes.
1926         * varobj.h: Fix common/ includes.
1927         * varobj.c: Fix common/ includes.
1928         * value.c: Fix common/ includes.
1929         * valops.c: Fix common/ includes.
1930         * utils.c: Fix common/ includes.
1931         * unittests/xml-utils-selftests.c: Fix common/ includes.
1932         * unittests/utils-selftests.c: Fix common/ includes.
1933         * unittests/unpack-selftests.c: Fix common/ includes.
1934         * unittests/tracepoint-selftests.c: Fix common/ includes.
1935         * unittests/style-selftests.c: Fix common/ includes.
1936         * unittests/string_view-selftests.c: Fix common/ includes.
1937         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1938         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1939         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1940         * unittests/rsp-low-selftests.c: Fix common/ includes.
1941         * unittests/parse-connection-spec-selftests.c: Fix common/
1942         includes.
1943         * unittests/optional-selftests.c: Fix common/ includes.
1944         * unittests/offset-type-selftests.c: Fix common/ includes.
1945         * unittests/observable-selftests.c: Fix common/ includes.
1946         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1947         * unittests/memrange-selftests.c: Fix common/ includes.
1948         * unittests/memory-map-selftests.c: Fix common/ includes.
1949         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1950         * unittests/function-view-selftests.c: Fix common/ includes.
1951         * unittests/environ-selftests.c: Fix common/ includes.
1952         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1953         * unittests/common-utils-selftests.c: Fix common/ includes.
1954         * unittests/cli-utils-selftests.c: Fix common/ includes.
1955         * unittests/array-view-selftests.c: Fix common/ includes.
1956         * ui-file.c: Fix common/ includes.
1957         * tui/tui-io.c: Fix common/ includes.
1958         * tracepoint.h: Fix common/ includes.
1959         * tracepoint.c: Fix common/ includes.
1960         * tracefile-tfile.c: Fix common/ includes.
1961         * top.h: Fix common/ includes.
1962         * top.c: Fix common/ includes.
1963         * thread.c: Fix common/ includes.
1964         * target/waitstatus.h: Fix common/ includes.
1965         * target/waitstatus.c: Fix common/ includes.
1966         * target.h: Fix common/ includes.
1967         * target.c: Fix common/ includes.
1968         * target-memory.c: Fix common/ includes.
1969         * target-descriptions.c: Fix common/ includes.
1970         * symtab.h: Fix common/ includes.
1971         * symfile.c: Fix common/ includes.
1972         * stap-probe.c: Fix common/ includes.
1973         * spu-linux-nat.c: Fix common/ includes.
1974         * sparc-nat.c: Fix common/ includes.
1975         * source.c: Fix common/ includes.
1976         * solib.c: Fix common/ includes.
1977         * solib-target.c: Fix common/ includes.
1978         * ser-unix.c: Fix common/ includes.
1979         * ser-tcp.c: Fix common/ includes.
1980         * ser-pipe.c: Fix common/ includes.
1981         * ser-base.c: Fix common/ includes.
1982         * selftest-arch.c: Fix common/ includes.
1983         * s12z-tdep.c: Fix common/ includes.
1984         * rust-exp.y: Fix common/ includes.
1985         * rs6000-aix-tdep.c: Fix common/ includes.
1986         * riscv-tdep.c: Fix common/ includes.
1987         * remote.c: Fix common/ includes.
1988         * remote-notif.h: Fix common/ includes.
1989         * remote-fileio.h: Fix common/ includes.
1990         * remote-fileio.c: Fix common/ includes.
1991         * regcache.h: Fix common/ includes.
1992         * regcache.c: Fix common/ includes.
1993         * record-btrace.c: Fix common/ includes.
1994         * python/python.c: Fix common/ includes.
1995         * python/py-type.c: Fix common/ includes.
1996         * python/py-inferior.c: Fix common/ includes.
1997         * progspace.h: Fix common/ includes.
1998         * producer.c: Fix common/ includes.
1999         * procfs.c: Fix common/ includes.
2000         * proc-api.c: Fix common/ includes.
2001         * printcmd.c: Fix common/ includes.
2002         * ppc-linux-nat.c: Fix common/ includes.
2003         * parser-defs.h: Fix common/ includes.
2004         * osdata.c: Fix common/ includes.
2005         * obsd-nat.c: Fix common/ includes.
2006         * nat/x86-linux.c: Fix common/ includes.
2007         * nat/x86-linux-dregs.c: Fix common/ includes.
2008         * nat/x86-dregs.h: Fix common/ includes.
2009         * nat/x86-dregs.c: Fix common/ includes.
2010         * nat/ppc-linux.c: Fix common/ includes.
2011         * nat/mips-linux-watch.h: Fix common/ includes.
2012         * nat/mips-linux-watch.c: Fix common/ includes.
2013         * nat/linux-waitpid.c: Fix common/ includes.
2014         * nat/linux-ptrace.h: Fix common/ includes.
2015         * nat/linux-ptrace.c: Fix common/ includes.
2016         * nat/linux-procfs.c: Fix common/ includes.
2017         * nat/linux-personality.c: Fix common/ includes.
2018         * nat/linux-osdata.c: Fix common/ includes.
2019         * nat/linux-namespaces.c: Fix common/ includes.
2020         * nat/linux-btrace.h: Fix common/ includes.
2021         * nat/linux-btrace.c: Fix common/ includes.
2022         * nat/fork-inferior.c: Fix common/ includes.
2023         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2024         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2025         * nat/aarch64-linux.c: Fix common/ includes.
2026         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2027         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2028         * namespace.h: Fix common/ includes.
2029         * mips-linux-tdep.c: Fix common/ includes.
2030         * minsyms.c: Fix common/ includes.
2031         * mi/mi-parse.h: Fix common/ includes.
2032         * mi/mi-main.c: Fix common/ includes.
2033         * mi/mi-cmd-env.c: Fix common/ includes.
2034         * memrange.h: Fix common/ includes.
2035         * memattr.c: Fix common/ includes.
2036         * maint.h: Fix common/ includes.
2037         * maint.c: Fix common/ includes.
2038         * main.c: Fix common/ includes.
2039         * machoread.c: Fix common/ includes.
2040         * location.c: Fix common/ includes.
2041         * linux-thread-db.c: Fix common/ includes.
2042         * linux-nat.c: Fix common/ includes.
2043         * linux-fork.c: Fix common/ includes.
2044         * inline-frame.c: Fix common/ includes.
2045         * infrun.c: Fix common/ includes.
2046         * inflow.c: Fix common/ includes.
2047         * inferior.h: Fix common/ includes.
2048         * inferior.c: Fix common/ includes.
2049         * infcmd.c: Fix common/ includes.
2050         * inf-ptrace.c: Fix common/ includes.
2051         * inf-child.c: Fix common/ includes.
2052         * ia64-linux-nat.c: Fix common/ includes.
2053         * i387-tdep.c: Fix common/ includes.
2054         * i386-tdep.c: Fix common/ includes.
2055         * i386-linux-tdep.c: Fix common/ includes.
2056         * i386-linux-nat.c: Fix common/ includes.
2057         * i386-go32-tdep.c: Fix common/ includes.
2058         * i386-fbsd-tdep.c: Fix common/ includes.
2059         * i386-fbsd-nat.c: Fix common/ includes.
2060         * guile/scm-type.c: Fix common/ includes.
2061         * guile/guile.c: Fix common/ includes.
2062         * go32-nat.c: Fix common/ includes.
2063         * gnu-nat.c: Fix common/ includes.
2064         * gdbthread.h: Fix common/ includes.
2065         * gdbarch-selftests.c: Fix common/ includes.
2066         * gdb_usleep.c: Fix common/ includes.
2067         * gdb_select.h: Fix common/ includes.
2068         * gdb_bfd.c: Fix common/ includes.
2069         * gcore.c: Fix common/ includes.
2070         * fork-child.c: Fix common/ includes.
2071         * findvar.c: Fix common/ includes.
2072         * fbsd-nat.c: Fix common/ includes.
2073         * event-top.c: Fix common/ includes.
2074         * event-loop.c: Fix common/ includes.
2075         * dwarf2read.c: Fix common/ includes.
2076         * dwarf2loc.c: Fix common/ includes.
2077         * dwarf2-frame.c: Fix common/ includes.
2078         * dwarf-index-cache.c: Fix common/ includes.
2079         * dtrace-probe.c: Fix common/ includes.
2080         * disasm-selftests.c: Fix common/ includes.
2081         * defs.h: Fix common/ includes.
2082         * csky-tdep.c: Fix common/ includes.
2083         * cp-valprint.c: Fix common/ includes.
2084         * cp-support.h: Fix common/ includes.
2085         * cp-support.c: Fix common/ includes.
2086         * corelow.c: Fix common/ includes.
2087         * completer.h: Fix common/ includes.
2088         * completer.c: Fix common/ includes.
2089         * compile/compile.c: Fix common/ includes.
2090         * compile/compile-loc2c.c: Fix common/ includes.
2091         * compile/compile-cplus-types.c: Fix common/ includes.
2092         * compile/compile-cplus-symbols.c: Fix common/ includes.
2093         * command.h: Fix common/ includes.
2094         * cli/cli-dump.c: Fix common/ includes.
2095         * cli/cli-cmds.c: Fix common/ includes.
2096         * charset.c: Fix common/ includes.
2097         * build-id.c: Fix common/ includes.
2098         * btrace.h: Fix common/ includes.
2099         * btrace.c: Fix common/ includes.
2100         * breakpoint.h: Fix common/ includes.
2101         * breakpoint.c: Fix common/ includes.
2102         * ax.h:
2103         (enum agent_op): Fix common/ includes.
2104         * ax-general.c (struct aop_map): Fix common/ includes.
2105         * ax-gdb.c: Fix common/ includes.
2106         * auxv.c: Fix common/ includes.
2107         * auto-load.c: Fix common/ includes.
2108         * arm-tdep.c: Fix common/ includes.
2109         * arch/riscv.c: Fix common/ includes.
2110         * arch/ppc-linux-common.c: Fix common/ includes.
2111         * arch/i386.c: Fix common/ includes.
2112         * arch/arm.c: Fix common/ includes.
2113         * arch/arm-linux.c: Fix common/ includes.
2114         * arch/arm-get-next-pcs.c: Fix common/ includes.
2115         * arch/amd64.c: Fix common/ includes.
2116         * arch/aarch64.c: Fix common/ includes.
2117         * arch/aarch64-insn.c: Fix common/ includes.
2118         * arch-utils.c: Fix common/ includes.
2119         * amd64-windows-tdep.c: Fix common/ includes.
2120         * amd64-tdep.c: Fix common/ includes.
2121         * amd64-sol2-tdep.c: Fix common/ includes.
2122         * amd64-obsd-tdep.c: Fix common/ includes.
2123         * amd64-nbsd-tdep.c: Fix common/ includes.
2124         * amd64-linux-tdep.c: Fix common/ includes.
2125         * amd64-linux-nat.c: Fix common/ includes.
2126         * amd64-fbsd-tdep.c: Fix common/ includes.
2127         * amd64-fbsd-nat.c: Fix common/ includes.
2128         * amd64-dicos-tdep.c: Fix common/ includes.
2129         * amd64-darwin-tdep.c: Fix common/ includes.
2130         * agent.c: Fix common/ includes.
2131         * ada-lang.h: Fix common/ includes.
2132         * ada-lang.c: Fix common/ includes.
2133         * aarch64-tdep.c: Fix common/ includes.
2134
2135 2019-01-25  Tom Tromey  <tom@tromey.com>
2136
2137         * common/create-version.sh: Use common/version.h.
2138
2139 2019-01-24  Pedro Alves  <palves@redhat.com>
2140
2141         * infrun.c (signal_stop, signal_print, signal_program)
2142         (signal_catch, signal_pass): Now arrays instead of pointers.
2143         (update_signals_program_target, do_target_resume)
2144         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2145         * linux-nat.c (linux_nat_target::pass_signals)
2146         (linux_nat_target::create_inferior, linux_nat_target::attach):
2147         Adjust.
2148         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2149         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2150         * procfs.c (procfs_target::pass_signals): Adjust.
2151         * record-full.c (record_full_target::resume): Adjust.
2152         * remote.c (remote_target::pass_signals)
2153         (remote_target::program_signals): Adjust.
2154         * target-debug.h (target_debug_print_signals): Now takes a
2155         gdb::array_view as parameter.  Adjust.
2156         * target.h (target_ops) <pass_signals, program_signals>: Replace
2157         pointer and length parameters with gdb::array_view.
2158         (target_pass_signals, target_program_signals): Likewise.
2159         * target-delegates.c: Regenerate.
2160
2161 2019-01-24  Pedro Alves  <palves@redhat.com>
2162
2163         * common/forward-scope-exit.h
2164         (forward_scope_exit::forward_scope_exit): Pass arguments to
2165         m_bind_function directly, instead of creating a std::bind and
2166         copying that.
2167
2168 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2169
2170         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2171         for static members.
2172         (pass_in_v_vfp_candidate): Likewise.
2173
2174 2019-01-23  Tom Tromey  <tom@tromey.com>
2175             Pedro Alves  <palves@redhat.com>
2176
2177         * regcache.c (class regcache_invalidator): Remove.
2178         (regcache::raw_write): Use make_scope_exit.
2179
2180 2019-01-23  Tom Tromey  <tom@tromey.com>
2181
2182         * ui-out.h (class ui_out_emit_type): Update comment.
2183
2184 2019-01-23  Tom Tromey  <tom@tromey.com>
2185
2186         * infrun.c (fetch_inferior_event): Update comment.
2187
2188 2019-01-23  Tom Tromey  <tom@tromey.com>
2189             Pedro Alves  <palves@redhat.com>
2190
2191         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2192         parameter.
2193         (fetch_inferior_event): Use SCOPE_EXIT.
2194
2195
2196 2019-01-23  Tom Tromey  <tom@tromey.com>
2197             Pedro Alves  <palves@redhat.com>
2198
2199         * infrun.c (disable_thread_events): Delete.
2200         (stop_all_threads): Use SCOPE_EXIT.
2201
2202 2019-01-23  Tom Tromey  <tom@tromey.com>
2203             Pedro Alves  <palves@redhat.com>
2204
2205         * symfile.c: Include forward-scope-exit.h.
2206         (clear_symtab_users_cleanup): Replace forward declaration with
2207         a FORWARD_SCOPE_EXIT.
2208         (syms_from_objfile_1): Use the forward_scope_exit and
2209         gdb::optional instead of cleanup_function.
2210         (reread_symbols): Use the forward_scope_exit instead of
2211         cleanup_function.
2212         (clear_symtab_users_cleanup): Remove function.
2213
2214 2019-01-23  Tom Tromey  <tom@tromey.com>
2215             Pedro Alves  <palves@redhat.com>
2216
2217         * linux-nat.c: Include scope-exit.h.
2218         (cleanup_target_stop): Remove.
2219         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2220         SCOPE_EXIT.
2221
2222 2019-01-23  Tom Tromey  <tom@tromey.com>
2223             Pedro Alves  <palves@redhat.com>
2224
2225         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2226         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2227
2228 2019-01-23  Tom Tromey  <tom@tromey.com>
2229             Andrew Burgess  <andrew.burgess@embecosm.com>
2230             Pedro Alves  <palves@redhat.com>
2231
2232         * infrun.c (fetch_inferior_event): Use scope_exit.
2233         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2234         * top.c (execute_command): Use scope_exit.
2235         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2236         * utils.c (do_bpstat_clear_actions_cleanup)
2237         (make_bpstat_clear_actions_cleanup): Remove.
2238
2239 2019-01-23  Tom Tromey  <tom@tromey.com>
2240             Pedro Alves  <palves@redhat.com>
2241
2242         * infrun.c: Include "common/scope-exit.h"
2243         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2244         (wait_for_inferior): Use SCOPE_EXIT.
2245         (fetch_inferior_event): Use scope_exit.
2246
2247 2019-01-23  Tom Tromey  <tom@tromey.com>
2248             Pedro Alves  <palves@redhat.com>
2249
2250         * breakpoint.c (create_breakpoint): Remove cleanup.
2251
2252 2019-01-23  Tom Tromey  <tom@tromey.com>
2253             Andrew Burgess  <andrew.burgess@embecosm.com>
2254             Pedro Alves  <palves@redhat.com>
2255
2256 2019-01-23  Pedro Alves  <palves@redhat.com>
2257
2258         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2259
2260 2019-01-23  Pedro Alves  <palves@redhat.com>
2261             Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * gdbthread.h: Include "common/forward-scope-exit.h".
2264         (scoped_finish_thread_state): Redefine custom class in terms of
2265         forward_scope_exit.
2266
2267 2019-01-23  Pedro Alves  <palves@redhat.com>
2268             Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * common/forward-scope-exit.h: New file.
2271
2272 2019-01-23  Pedro Alves  <palves@redhat.com>
2273             Andrew Burgess  <andrew.burgess@embecosm.com>
2274             Tom Tromey  <tom@tromey.com>
2275
2276         * common/scope-exit.h: New file.
2277
2278 2019-01-23  Pedro Alves  <palves@redhat.com>
2279
2280         * common/preprocessor.h (ESC): Rename to ...
2281         (ESC_PARENS): ... this.
2282         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2283         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2284
2285 2019-01-23  Tom Tromey  <tom@tromey.com>
2286
2287         * language.h (class scoped_switch_to_sym_language_if_auto):
2288         Initialize m_lang in both cases.
2289
2290 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2291
2292         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2293         with XCNEW.
2294
2295 2019-01-22  Tom Tromey  <tom@tromey.com>
2296
2297         * corelow.c: Do not include sys/file.h.
2298
2299 2019-01-22  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-wingeneral.h: Include gdb_curses.h.
2302
2303 2019-01-22  Tom Tromey  <tom@tromey.com>
2304
2305         * source-cache.h (class source_cache) <get_source_lines,
2306         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2307
2308 2019-01-22  Tom Tromey  <tom@tromey.com>
2309
2310         * remote-fileio.h (struct remote_target): Declare.
2311
2312 2019-01-22  Tom Tromey  <tom@tromey.com>
2313
2314         * python/py-arch.c: Do not include py-ref.h.
2315         * python/py-bpevent.c: Do not include py-ref.h.
2316         * python/py-cmd.c: Do not include py-ref.h.
2317         * python/py-continueevent.c: Do not include py-ref.h.
2318         * python/py-event.h: Do not include py-ref.h.
2319         * python/py-evtregistry.c: Do not include py-ref.h.
2320         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2321         * python/py-frame.c: Do not include py-ref.h.
2322         * python/py-framefilter.c: Do not include py-ref.h.
2323         * python/py-function.c: Do not include py-ref.h.
2324         * python/py-infevents.c: Do not include py-ref.h.
2325         * python/py-linetable.c: Do not include py-ref.h.
2326         * python/py-objfile.c: Do not include py-ref.h.
2327         * python/py-param.c: Do not include py-ref.h.
2328         * python/py-prettyprint.c: Do not include py-ref.h.
2329         * python/py-progspace.c: Do not include py-ref.h.
2330         * python/py-symbol.c: Do not include py-ref.h.
2331         * python/py-symtab.c: Do not include py-ref.h.
2332         * python/py-type.c: Do not include py-ref.h.
2333         * python/py-unwind.c: Do not include py-ref.h.
2334         * python/py-utils.c: Do not include py-ref.h.
2335         * python/py-value.c: Do not include py-ref.h.
2336         * python/py-varobj.c: Do not include py-ref.h.
2337         * python/py-xmethods.c: Do not include py-ref.h.
2338         * python/python.c: Do not include py-ref.h.
2339         * varobj.c: Do not include py-ref.h.
2340
2341 2019-01-22  Tom Tromey  <tom@tromey.com>
2342
2343         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2344         keyword for bcache.
2345
2346 2019-01-22  Tom Tromey  <tom@tromey.com>
2347
2348         * compile/compile-cplus-types.c: Remove a comment by #include.
2349
2350 2019-01-22  Tom Tromey  <tom@tromey.com>
2351
2352         * compile/gcc-c-plugin.h: Include compile-internal.h.
2353
2354 2019-01-22  Tom Tromey  <tom@tromey.com>
2355
2356         * stabsread.c (EXTERN): Do not define.
2357         (symnum, next_symbol_text_func, processing_gcc_compilation)
2358         (within_function, global_sym_chain, global_stabs)
2359         (previous_stab_code, this_object_header_files)
2360         (n_this_object_header_files)
2361         (n_allocated_this_object_header_files): Define.
2362         * stabsread.h (EXTERN): Never define.  Use "extern".
2363
2364 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2367         history_value.
2368
2369 2019-01-21  Tom Tromey  <tom@tromey.com>
2370
2371         * ui-out.c: Fix includes.
2372         * tui/tui-source.c: Fix includes.
2373         * target.c: Fix includes.
2374         * remote.c: Fix includes.
2375         * regcache.c: Fix includes.
2376         * python/py-block.c: Fix includes.
2377         * printcmd.c: Fix includes.
2378         * or1k-tdep.c: Fix includes.
2379         * mi/mi-main.c: Fix includes.
2380         * m32r-tdep.c: Fix includes.
2381         * csky-tdep.c: Fix includes.
2382         * compile/compile-cplus-types.c: Fix includes.
2383         * cli/cli-interp.c: Fix includes.
2384
2385 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2386
2387         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2388         for padding.
2389
2390 2019-01-16  Tom Tromey  <tom@tromey.com>
2391
2392         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2393         earlier.
2394         (struct objfile) <msymbols_range>: Move from top level.
2395         <msymbols>: New method.
2396         (class objfile_msymbols): Remove.
2397         * symtab.c (default_collect_symbol_completion_matches_break_on):
2398         Update.
2399         * symmisc.c (dump_msymbols): Update.
2400         * stabsread.c (scan_file_globals): Update.
2401         * objc-lang.c (info_selectors_command, info_classes_command)
2402         (find_methods): Update.
2403         * minsyms.c (find_solib_trampoline_target): Update.
2404         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2405         * coffread.c (coff_symfile_read): Update.
2406         * ada-lang.c (ada_lookup_simple_minsym)
2407         (ada_collect_symbol_completion_matches): Update.
2408
2409 2019-01-16  Tom Tromey  <tom@tromey.com>
2410
2411         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2412         type.  Remove no-argument constructor.
2413         <iterator::operator++>: Simplify.
2414         <begin>: Update.
2415         <end>: Use minimal_symbol_count.
2416
2417 2019-01-16  Tom Tromey  <tom@tromey.com>
2418
2419         * objfiles.h (struct objfile) <psymtabs>: New method.
2420         (class objfile_psymtabs): Remove.
2421         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2422         typedef.
2423         <range>: New method.
2424         (require_partial_symbols): Change return type.
2425         * psymtab.c (require_partial_symbols)
2426         (psym_expand_symtabs_matching): Update.
2427         * mdebugread.c (parse_partial_symbols): Update.
2428         * dbxread.c (dbx_end_psymtab): Update.
2429
2430 2019-01-15  Tom Tromey  <tom@tromey.com>
2431
2432         * symtab.c (lookup_objfile_from_block)
2433         (lookup_symbol_in_objfile_symtabs)
2434         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2435         (find_line_symtab, info_sources_command)
2436         (default_collect_symbol_completion_matches_break_on)
2437         (make_source_files_completion_list): Update.
2438         * symmisc.c (print_objfile_statistics, dump_objfile)
2439         (maintenance_print_symbols, maintenance_info_symtabs)
2440         (maintenance_check_symtabs, maintenance_info_line_tables):
2441         Update.
2442         * source.c (select_source_symtab)
2443         (forget_cached_source_info_for_objfile): Update.
2444         * objfiles.h (class objfile_compunits): Remove.
2445         (struct objfile) <compunits_range>: New typedef.
2446         (compunits): New method.
2447         * objfiles.c (objfile_relocate1): Update.
2448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2449         * maint.c (count_symtabs_and_blocks): Update.
2450         * linespec.c (iterate_over_all_matching_symtabs): Update.
2451         * cp-support.c (add_symbol_overload_list_qualified): Update.
2452         * coffread.c (coff_symtab_read): Update.
2453         * ada-lang.c (add_nonlocal_symbols)
2454         (ada_collect_symbol_completion_matches)
2455         (ada_add_global_exceptions): Update.
2456
2457 2019-01-15  Tom Tromey  <tom@tromey.com>
2458
2459         * progspace.h (program_space) <objfiles_safe_range>: New
2460         typedef.
2461         <objfiles_safe>: New method.
2462         * objfiles.h (class all_objfiles_safe): Remove.
2463         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2464         * jit.c (jit_inferior_exit_hook): Update.
2465
2466 2019-01-17  Tom Tromey  <tom@tromey.com>
2467
2468         * progspace.h (program_space) <objfiles_range>: New typedef.
2469         <objfiles>: New method.
2470         <objfiles_head>: Rename from objfiles.
2471         (object_files): Update.
2472         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2473         * guile/scm-pretty-print.c
2474         (ppscm_find_pretty_printer_from_objfiles): Update.
2475         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2476         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2477         Update.
2478         * python/py-progspace.c (pspy_get_objfiles): Update.
2479         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2480         Update.
2481         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2482         (objfpy_lookup_objfile_by_build_id): Update.
2483         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2484         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2485         Update.
2486         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2487         (expand_symtab_containing_pc, lookup_objfile_from_block)
2488         (lookup_static_symbol, basic_lookup_transparent_type)
2489         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2490         (find_line_symtab, info_sources_command)
2491         (default_collect_symbol_completion_matches_break_on)
2492         (make_source_files_completion_list, find_main_name): Update.
2493         * symmisc.c (print_symbol_bcache_statistics)
2494         (print_objfile_statistics, maintenance_print_symbols)
2495         (maintenance_print_msymbols, maintenance_print_objfiles)
2496         (maintenance_info_symtabs, maintenance_check_symtabs)
2497         (maintenance_expand_symtabs, maintenance_info_line_tables):
2498         Update.
2499         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2500         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2501         (map_overlay_command, unmap_overlay_command)
2502         (simple_overlay_update, expand_symtabs_matching)
2503         (map_symbol_filenames): Update.
2504         * symfile-debug.c (set_debug_symfile): Update.
2505         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2506         Update.
2507         * source.c (select_source_symtab, forget_cached_source_info):
2508         Update.
2509         * solib.c (solib_read_symbols): Update.
2510         * solib-spu.c (append_ocl_sos): Update.
2511         * psymtab.c (maintenance_print_psymbols)
2512         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2513         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2514         * printcmd.c (info_symbol_command): Update.
2515         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2516         Update.
2517         * objfiles.h (class all_objfiles): Remove.
2518         * objfiles.c (have_partial_symbols, have_full_symbols)
2519         (have_minimal_symbols, qsort_cmp, update_section_map)
2520         (shared_objfile_contains_address_p)
2521         (default_iterate_over_objfiles_in_search_order): Update.
2522         * objc-lang.c (info_selectors_command, info_classes_command)
2523         (find_methods): Update.
2524         * minsyms.c (find_solib_trampoline_target): Update.
2525         * maint.c (maintenance_info_sections)
2526         (maintenance_translate_address, count_symtabs_and_blocks):
2527         Update.
2528         * main.c (captured_main_1): Update.
2529         * linux-thread-db.c (try_thread_db_load_from_pdir)
2530         (has_libpthread): Update.
2531         * linespec.c (iterate_over_all_matching_symtabs)
2532         (search_minsyms_for_name): Update.
2533         * jit.c (jit_find_objf_with_entry_addr): Update.
2534         * hppa-tdep.c (find_unwind_entry)
2535         (hppa_lookup_stub_minimal_symbol): Update.
2536         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2537         Update.
2538         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2539         (elf_gnu_ifunc_resolve_by_got): Update.
2540         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2541         * dwarf-index-write.c (save_gdb_index_command): Update.
2542         * cp-support.c (add_symbol_overload_list_qualified): Update.
2543         * breakpoint.c (create_overlay_event_breakpoint)
2544         (create_longjmp_master_breakpoint)
2545         (create_std_terminate_master_breakpoint)
2546         (create_exception_master_breakpoint): Update.
2547         * blockframe.c (find_pc_partial_function): Update.
2548         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2549         (ada_collect_symbol_completion_matches)
2550         (ada_add_global_exceptions): Update.
2551
2552 2019-01-17  Tom Tromey  <tom@tromey.com>
2553
2554         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2555         declare VEC.
2556         (solib_target_parse_libraries): Change return type.
2557         (library_list_start_segment, library_list_start_section)
2558         (library_list_end_library, library_list_start_library); Update.
2559         (solib_target_free_library_list): Remove.
2560         (solib_target_parse_libraries): Remove cleanup.  Change return
2561         type.
2562         (solib_target_current_sos): Update.
2563
2564 2019-01-17  Tom Tromey  <tromey@bapiya>
2565
2566         * valprint.c: Replace "the the" with "the".
2567         * symtab.c: Replace "the the" with "the".
2568         * solib.c: Replace "the the" with "the".
2569         * solib-dsbt.c: Replace "the the" with "the".
2570         * linespec.c: Replace "the the" with "the".
2571         * dwarf2loc.h: Replace "the the" with "the".
2572         * amd64-windows-tdep.c: Replace "the the" with "the".
2573         * aarch64-tdep.c: Replace "the the" with "the".
2574
2575 2019-01-16  Keith Seitz  <keiths@redhat.com>
2576
2577         PR gdb/23773
2578         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2579         <builder>: Rename to ..
2580         <m_builder>: ... this and make private.
2581         (dwarf2_cu::get_builder): New method.  Change all users of
2582         `builder' to use this method.
2583         (dwarf2_start_symtab): Move to ...
2584         (dwarf2_cu::start_symtab): ... here.  Update all callers
2585         (setup_type_unit_groups): Move to ...
2586         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2587         callers.
2588         (dwarf2_cu::reset_builder): New method.
2589         (process_full_compunit, process_full_type_unit): Use
2590         dwarf2_cu::reset_builder.
2591         (follow_die_offset): Record the ancestor CU if it is different
2592         from the followed DIE's CU.
2593         (follow_die_sig_1): Likewise.
2594
2595 2019-01-15  Tom Tromey  <tom@tromey.com>
2596
2597         * remote.c (class remote_state) <buf>: Now a char_vector.
2598         <buf_size>: Remove.
2599         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2600         parameter.
2601         (remote_target::getpkt_or_notif_sane_1)
2602         (remote_target::getpkt_sane)
2603         (remote_target::getpkt_or_notif_sane): Likewise.
2604         (class remote_target) <putpkt>: New overload.
2605         (remote_target::read_frame): Change type of "buf_p".  Remove
2606         sizeof_p parameter.
2607         (packet_ok): New overload.
2608         (packet_check_result): New overload.
2609         Update all uses.
2610
2611 2019-01-14  Tom Tromey  <tom@tromey.com>
2612
2613         * remote-notif.c (handle_notification, remote_notif_ack)
2614         (remote_notif_parse): Make "buf" const.
2615         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2616         const.
2617         (remote_notif_parse, remote_notif_ack, handle_notification):
2618         Likewise.
2619         * remote.c (remote_notif_stop_parse): Make "buf" const.
2620         (remote_target::remote_parse_stop_reply): Make "buf" const.
2621         (remote_notif_stop_ack): Make "buf" const.
2622
2623 2019-01-14  Tom Tromey  <tom@tromey.com>
2624
2625         * remote.c (remote_console_output): Make parameter const.
2626
2627 2019-01-14  Tom Tromey  <tom@tromey.com>
2628
2629         * target-debug.h (target_debug_print_signals): Constify.
2630         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2631         * procfs.c (procfs_target::pass_signals): Update.
2632         * linux-nat.c (linux_nat_target::pass_signals): Update.
2633         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2634         * target-delegates.c: Rebuild.
2635         * remote.c (remote_target::program_signals): Update.
2636         (remote_target::pass_signals): Update.
2637         * target.c (target_pass_signals): Constify argument.
2638         (target_program_signals): Likewise.
2639         * target.h (struct target_ops) <pass_signals, program_signals>:
2640         Constify argument.
2641         (target_pass_signals, target_program_signals): Constify argument.
2642
2643 2019-01-14  Tom Tromey  <tom@tromey.com>
2644
2645         PR tui/28819:
2646         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2647
2648 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2649
2650         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2651         field.
2652         * rs6000-tdep.c: Include reggroups.h.
2653         (IS_V_ALIAS_PSEUDOREG): Define.
2654         (rs6000_register_name): Return names for the "vX" aliases.
2655         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2656         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2657         aliases.  Call default_register_reggroup_p for all other
2658         pseudo-registers.
2659         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2660         New functions.
2661         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2662         Handle "vX" aliases.
2663         (v_alias_pseudo_register_collect): New function.
2664         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2665         (rs6000_gdbarch_init): Initialize "vX" aliases as
2666         pseudo-registers.  Restore registration of
2667         rs6000_pseudo_register_reggroup_p with
2668         set_tdesc_pseudo_register_reggroup_p.
2669
2670 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2671
2672         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2673         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2674         set_gdbarch_num_pseudo_regs.
2675
2676 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2677
2678         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2679         Remove arg prefixname, add do_set and do_show.
2680         Add member functions set_list and show_list.
2681         * cli/cli-style.c (class cli_style_option): Update accordingly.
2682         (style_set_list): Move to file scope.
2683         (style_show_list): Likewise.
2684         (set_style): Call help_list.
2685         (show_style): Call cmd_show_list.
2686         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2687         Update to use the new macro.
2688
2689 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2690
2691         * ada-lang.c (_initialize_ada_language): Expand the help text
2692         for the "catch exception" command.
2693
2694 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2695
2696         * symtab.c (matching_obj_sections): Initialize obj,
2697         declare it closer to its usage.
2698
2699 2019-01-10  Tom Tromey  <tom@tromey.com>
2700
2701         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2702         (basic_inf_threads_range): Remove.
2703         (inf_threads_range, inf_non_exited_threads_range)
2704         (safe_inf_threads_range): Use next_adapter.
2705
2706 2019-01-10  Keith Seitz  <keiths@redhat.com>
2707
2708         PR gdb/23712
2709         PR symtab/23010
2710         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2711         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2712
2713 2019-01-10  Keith Seitz  <keiths@redhat.com>
2714
2715         PR gdb/23712
2716         PR symtab/23010
2717         * dictionary.c (pending_to_vector): Remove.
2718         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2719         Remove _1 suffix, replacing functions of the same name.  Update
2720         all callers.
2721         (dict_create_hashed, dict_create_hashed_expandable)
2722         (dict_create_linear, dict_create_linear_expandable, dict_free)
2723         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2724         Make functions static.
2725
2726 2019-01-10  Keith Seitz  <keiths@redhat.com>
2727
2728         PR gdb/23712
2729         PR symtab/23010
2730         * dictionary.h (struct dictionary): Replace declaration with
2731         multidictionary.
2732         (dict_create_hashed, dict_create_hashed_expandable)
2733         (dict_create_linear, dict_create_linear_expandable)
2734         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2735         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2736         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2737         taking multidictionary argument.
2738         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2739         * block.h (struct block) <dict>: Change to multidictionary
2740         and rename `multidict'.
2741         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2742         symmisc.c: Update all dictionary references to multidictionary.
2743
2744 2019-01-10  Keith Seitz  <keiths@redhat.com>
2745
2746         PR gdb/23712
2747         PR symtab/23010
2748         * dictionary.c: Include unordered_map.
2749         (pending_to_vector): New function.
2750         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2751         Rewrite the non-"_1" functions to take vector instead
2752         of linked list.
2753         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2754         "new" _1 versions of the same name.
2755         (multidictionary): Define.
2756         (std::hash<enum language): New definition.
2757         (collate_pending_symbols_by_language, mdict_create_hashed)
2758         (mdict_create_hashed_expandable, mdict_create_linear)
2759         (mdict_create_linear_expandable, mdict_free)
2760         (find_language_dictionary, create_new_language_dictionary)
2761         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2762         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2763         (mdict_size, mdict_empty): New functions.
2764         * dictionary.h (mdict_iterator): Define.
2765
2766 2019-01-10  Pedro Alves  <palves@redhat.com>
2767
2768         * breakpoint.c (read_uploaded_action)
2769         (create_tracepoint_from_upload): Adjust to use
2770         gdb::unique_xmalloc_ptr.
2771         * ctf.c (ctf_write_uploaded_tp):
2772         (SET_ARRAY_FIELD): Use emplace_back.
2773         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2774         * tracefile-tfile.c (tfile_write_uploaded_tp):
2775         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2776         gdb::unique_xmalloc_ptr.
2777         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2778         at_string, cond_string, cmd_strings>: Replace char pointers
2779         with gdb::unique_xmalloc_ptr.
2780
2781 2019-01-10  Pedro Alves  <palves@redhat.com>
2782
2783         * solib-target.c (library_list_start_library): Don't xstrdup name.
2784
2785 2019-01-10  Pedro Alves  <palves@redhat.com>
2786
2787         * mdebugread.c (parse_partial_symbols): Use
2788         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2789
2790 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2791
2792         * linux-fork.c (scoped_switch_fork_info)
2793         <~scoped_switch_fork_info>: Fix incorrect variable name.
2794
2795 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2796
2797         * linux-fork.c (scoped_switch_fork_info)
2798         <scoped_switch_fork_info>: Make explicit.
2799         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2800
2801 2019-01-10  Tom Tromey  <tom@tromey.com>
2802
2803         * objfiles.h (objfile::reset_psymtabs): Update.
2804         * objfiles.c (objfile::objfile): Update.
2805         * psymtab.h (psymtab_storage::obstack): Update.
2806         (psymtab_storage::m_obstack): Use gdb::optional.
2807         (class psymtab_storage): Update comment.  Remove objfile
2808         parameter.
2809         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2810
2811 2019-01-10  Tom Tromey  <tom@tromey.com>
2812
2813         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2814         <free_psymtabs>: Now private.
2815         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2816         (allocate_psymtab): Use new method.
2817
2818 2019-01-10  Tom Tromey  <tom@tromey.com>
2819
2820         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2821         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2822         * mdebugread.c (parse_partial_symbols): Use
2823         allocate_dependencies.
2824         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2825         allocate_dependencies.
2826         (process_psymtab_comp_unit_reader)
2827         (build_type_psymtab_dependencies): Likewise.
2828         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2829
2830 2019-01-10  Tom Tromey  <tom@tromey.com>
2831
2832         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2833         PSYMBOL_SET_LANGUAGE.
2834         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2835
2836 2019-01-10  Tom Tromey  <tom@tromey.com>
2837
2838         * psymtab.h (psymtab_storage::obstack): New method.
2839         <m_obstack>: Rename from obstack; now private.
2840         * psymtab.c (psymtab_storage): Update.
2841         * dwarf2read.c (create_addrmap_from_index)
2842         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2843         Update.
2844
2845 2019-01-10  Tom Tromey  <tom@tromey.com>
2846
2847         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2848         * objfiles.h (objfile::reset_psymtabs): New method.
2849
2850 2019-01-10  Tom Tromey  <tom@tromey.com>
2851
2852         * symmisc.c (print_symbol_bcache_statistics): Update.
2853         (print_objfile_statistics): Update.
2854         * symfile.c (reread_symbols): Update.
2855         * psymtab.h (class psymtab_storage): New.
2856         * psymtab.c (psymtab_storage): New constructor.
2857         (~psymtab_storage): New destructor.
2858         (require_partial_symbols): Update.
2859         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2860         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2861         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2862         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2863         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2864         (start_psymtab_common, end_psymtab_common)
2865         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2866         (allocate_psymtab): Update.
2867         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2868         Update.
2869         (dump_psymtab_addrmap, maintenance_print_psymbols)
2870         (maintenance_check_psymtabs): Update.
2871         (class objfile_psymtabs): Move to objfiles.h.
2872         * psympriv.h (discard_psymtab): Now inline.
2873         (psymtab_discarder::psymtab_discarder): Update.
2874         (psymtab_discarder::~psymtab_discarder): Update.
2875         (ALL_OBJFILE_PSYMTABS): Rewrite.
2876         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2877         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2878         Remove fields.
2879         <partial_symtabs>: New field.
2880         (class objfile_psymtabs): Move from psymtab.h.  Update.
2881         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2882         psymbol_cache.
2883         (objfile::~objfile): Don't destroy psymbol_cache.
2884         * mdebugread.c (parse_partial_symbols): Update.
2885         * dwarf2read.c (create_addrmap_from_index)
2886         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2887         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2888         (add_partial_subprogram, dwarf2_ranges_read): Update.
2889         * dwarf-index-write.c (write_address_map)
2890         (write_one_signatured_type, recursively_write_psymbols)
2891         (class debug_names, class debug_names, write_psymtabs_to_index):
2892         Update.
2893
2894 2019-01-10  Tom Tromey  <tom@tromey.com>
2895
2896         * symtab.h (SYMBOL_SET_NAMES): Update.
2897         (symbol_set_names): Update.
2898         (MSYMBOL_SET_NAMES): Update.
2899         * symtab.c (symbol_set_names): Change argument to be an
2900         objfile_per_bfd_storage.
2901         * psymtab.c (add_psymbol_to_bcache): Update.
2902         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2903
2904 2019-01-10  Tom Tromey  <tom@tromey.com>
2905
2906         * symtab.c (create_demangled_names_hash): Change argument to be an
2907         objfile_per_bfd_storage.
2908         (symbol_set_names): Update.
2909
2910 2019-01-10  Tom Tromey  <tom@tromey.com>
2911
2912         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2913         init_psymbol_list.
2914         * psymtab.c (init_psymbol_list): Do nothing if already called.
2915         * psympriv.h (init_psymbol_list): Add comment.
2916         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2917         init_psymbol_list.
2918         * dbxread.c (dbx_symfile_read): Unconditionally call
2919         init_psymbol_list.
2920
2921 2019-01-10  Tom Tromey  <tom@tromey.com>
2922
2923         * xcoffread.c (scan_xcoff_symtab): Update.
2924         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2925         "where".
2926         * mdebugread.c (parse_partial_symbols)
2927         (handle_psymbol_enumerators): Update.
2928         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2929         * dbxread.c (read_dbx_symtab): Update.
2930         * psympriv.h (psymbol_placement): New enum.
2931         (add_psymbol_to_list): Update.
2932
2933 2019-01-10  Tom Tromey  <tom@tromey.com>
2934
2935         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2936         static_psymbols parameters.
2937         (scan_xcoff_symtab): Update.
2938         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2939         static_psymbols parameters.
2940         * psympriv.h (start_psymtab_common): Update.
2941         * mdebugread.c (parse_partial_symbols): Update.
2942         * dwarf2read.c (create_partial_symtab): Update.
2943         * dbxread.c (read_dbx_symtab): Update.
2944         (start_psymtab): Remove global_psymbols and static_psymbols
2945         parameters.
2946
2947 2019-01-10  Tom Tromey  <tom@tromey.com>
2948
2949         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2950         * psymtab.c (allocate_psymtab): Add comment.
2951         * psympriv.h (allocate_psymtab): Add comment.
2952         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2953         initializations.
2954         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2955
2956 2019-01-10  Tom Tromey  <tom@tromey.com>
2957
2958         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2959         Don't declare.
2960         * mipsread.c: Include mdebugread.h.
2961         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2962         Declare.
2963         * elfread.c: Include mdebugread.h.
2964
2965 2019-01-09  Tom Tromey  <tom@tromey.com>
2966
2967         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2968         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2969         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2970         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2971         (psym_lookup_symbol, psym_find_last_source_symtab)
2972         (psym_forget_cached_source_info, psym_print_stats)
2973         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2974         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2975         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2976         (psym_find_compunit_symtab_by_address)
2977         (maintenance_print_psymbols, maintenance_info_psymtabs)
2978         (maintenance_check_psymtabs): Use ranged for.
2979         * psymtab.h (class objfile_psymtabs): New.
2980         (require_partial_symbols): Return objfile_psymtabs.
2981         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2982
2983 2019-01-09  Tom Tromey  <tom@tromey.com>
2984
2985         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2986         (find_pc_mapped_section, list_overlays_command)
2987         (map_overlay_command, unmap_overlay_command)
2988         (simple_overlay_update): Use all_objfiles.
2989         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2990         * printcmd.c (info_symbol_command): Use all_objfiles.
2991         * objfiles.h (ALL_OBJSECTIONS): Remove.
2992         * maint.c (maintenance_translate_address): Use all_objfiles.
2993         * gcore.c (gcore_create_callback): Use all_objfiles.
2994         (objfile_find_memory_regions): Likewise.
2995
2996 2019-01-09  Tom Tromey  <tom@tromey.com>
2997
2998         * symtab.c (find_line_symtab, info_sources_command)
2999         (make_source_files_completion_list): Use objfile_compunits.
3000         * source.c (select_source_symtab): Use objfile_compunits.
3001         * objfiles.h (struct objfile): Update comment.
3002         (ALL_OBJFILES): Remove.
3003         (ALL_FILETABS): Remove.
3004         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3005         objfile_compunits.
3006
3007 2019-01-09  Tom Tromey  <tom@tromey.com>
3008
3009         * symmisc.c (print_objfile_statistics, dump_objfile)
3010         (maintenance_print_symbols): Use compunit_filetabs.
3011         * source.c (forget_cached_source_info_for_objfile): Use
3012         compunit_filetabs.
3013         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3014         (ALL_FILETABS): Use compunit_filetabs.
3015         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3016         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3017
3018 2019-01-09  Tom Tromey  <tom@tromey.com>
3019
3020         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3021         (compunit_filetabs): New.
3022         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3023         compunit_filetabs.
3024         (info_sources_command, make_source_files_completion_list): Remove
3025         declaration.
3026         * symmisc.c (print_objfile_statistics, dump_objfile)
3027         (maintenance_print_symbols): Remove declaration.
3028         (maintenance_info_symtabs): Use compunit_filetabs.
3029         (maintenance_info_line_tables): Likewise.
3030         * source.c (select_source_symtab): Change local variable name.
3031         (forget_cached_source_info_for_objfile): Remove declaration.
3032         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3033         * objfiles.c (objfile_relocate1): Remove declaration.
3034         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3035         declaration.
3036         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3037         * coffread.c (coff_symtab_read): Remove declaration.
3038         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3039         compunit_filetabs.
3040
3041 2019-01-09  Tom Tromey  <tom@tromey.com>
3042
3043         * symtab.c (lookup_objfile_from_block)
3044         (find_pc_sect_compunit_symtab, search_symbols)
3045         (default_collect_symbol_completion_matches_break_on): Use
3046         objfile_compunits.
3047         * objfiles.h (ALL_COMPUNITS): Remove.
3048         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3049         * cp-support.c (add_symbol_overload_list_qualified): Use
3050         objfile_compunits.
3051         * ada-lang.c (ada_collect_symbol_completion_matches)
3052         (ada_add_global_exceptions): Use objfile_compunits.
3053
3054 2019-01-09  Tom Tromey  <tom@tromey.com>
3055
3056         * source.c (select_source_symtab)
3057         (forget_cached_source_info_for_objfile): Remove declaration.
3058         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3059         declaration.
3060         * maint.c (count_symtabs_and_blocks): Remove declaration.
3061         * cp-support.c (add_symbol_overload_list_qualified): Remove
3062         declaration.
3063         * coffread.c (coff_symtab_read): Remove declaration.
3064         * symtab.c (lookup_symbol_in_objfile_symtabs)
3065         (basic_lookup_transparent_type_1): Use objfile_compunits.
3066         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3067         (info_sources_command, search_symbols)
3068         (default_collect_symbol_completion_matches_break_on)
3069         (make_source_files_completion_list): Remove declaration.
3070         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3071         (ada_collect_symbol_completion_matches)
3072         (ada_add_global_exceptions): Remove declaration.
3073         * linespec.c (iterate_over_all_matching_symtabs): Use
3074         objfile_compunits.
3075         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3076         (class objfile_compunits): New.
3077         (ALL_COMPUNITS): Use objfile_compunits.
3078         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3079         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3080         objfile_compunits.
3081         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3082
3083 2019-01-09  Tom Tromey  <tom@tromey.com>
3084
3085         * symtab.c (search_symbols)
3086         (default_collect_symbol_completion_matches_break_on): Use
3087         objfile_msymbols.
3088         * ada-lang.c (ada_lookup_simple_minsym)
3089         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3090         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3091         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3092         objfile_msymbols.
3093         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3094         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3095         * objc-lang.c (find_methods): Use objfile_msymbols.
3096         (info_selectors_command, info_classes_command): Likewise.
3097         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3098         * objfiles.h (class objfile_msymbols): New.
3099         (ALL_OBJFILE_MSYMBOLS): Remove.
3100         (ALL_MSYMBOLS): Remove.
3101
3102 2019-01-09  Tom Tromey  <tom@tromey.com>
3103
3104         * common/next-iterator.h (next_adapter): Add Iterator template
3105         parameter.
3106         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3107         (class all_objfiles_safe): New.
3108         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3109         * objfiles.c (put_objfile_before): Update comment.
3110         (add_separate_debug_objfile): Likewise.
3111         (free_all_objfiles): Use all_objfiles_safe.
3112         (objfile_purge_solibs): Likewise.
3113
3114 2019-01-09  Tom Tromey  <tom@tromey.com>
3115
3116         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3117         (expand_symtab_containing_pc, lookup_static_symbol)
3118         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3119         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3120         all_objfiles.
3121         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3122         * breakpoint.c (create_overlay_event_breakpoint)
3123         (create_longjmp_master_breakpoint)
3124         (create_std_terminate_master_breakpoint)
3125         (create_exception_master_breakpoint): Use all_objfiles.
3126         * linux-thread-db.c (try_thread_db_load_from_pdir)
3127         (has_libpthread): Use all_objfiles.
3128         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3129         * linespec.c (iterate_over_all_matching_symtabs)
3130         (search_minsyms_for_name): Use all_objfiles.
3131         * maint.c (maintenance_info_sections): Use all_objfiles.
3132         * main.c (captured_main_1): Use all_objfiles.
3133         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3134         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3135         * guile/scm-pretty-print.c
3136         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3137         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3138         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3139         (maintenance_print_msymbols): Use all_objfiles.
3140         * source.c (select_source_symtab): Use all_objfiles.
3141         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3142         * symfile.c (remove_symbol_file_command)
3143         (expand_symtabs_matching, map_symbol_filenames): Use
3144         all_objfiles.
3145         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3146         all_objfiles.
3147         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3148         * objc-lang.c (find_methods): Use all_objfiles.
3149         * objfiles.c (have_partial_symbols, have_full_symbols)
3150         (have_minimal_symbols, qsort_cmp)
3151         (default_iterate_over_objfiles_in_search_order): Use
3152         all_objfiles.
3153         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3154         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3155         (maintenance_check_psymtabs): Use all_objfiles.
3156         (ALL_PSYMTABS): Remove.
3157         * compile/compile-object-run.c (do_module_cleanup): Use
3158         all_objfiles.
3159         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3160         * cp-support.c (add_symbol_overload_list_qualified): Use
3161         all_objfiles.
3162         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3163         Use all_objfiles.
3164         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3165         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3166         all_objfiles.
3167         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3168         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3169         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3170         Uses all_objfiles.
3171         * solib.c (solib_read_symbols): Use all_objfiles
3172
3173 2019-01-09  Tom Tromey  <tom@tromey.com>
3174
3175         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3176         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3177         all_objfiles.
3178         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3179         * symmisc.c (print_symbol_bcache_statistics)
3180         (print_objfile_statistics, maintenance_print_objfiles)
3181         (maintenance_info_symtabs, maintenance_check_symtabs)
3182         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3183         all_objfiles.
3184         * source.c (forget_cached_source_info): Use all_objfiles.
3185         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3186         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3187         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3188         * objfiles.c (update_section_map): Use all_objfiles.
3189         (shared_objfile_contains_address_p): Likewise.
3190         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3191         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3192
3193 2019-01-09  Tom Tromey  <tom@tromey.com>
3194
3195         * common/next-iterator.h: New file.
3196         * objfiles.h (class all_objfiles): New.
3197         (struct objfile_iterator): New.
3198
3199 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3200
3201         * NEWS: Move the description of the changed "frame", "select-frame",
3202          and "info frame" commands to the Changed commands section.
3203
3204 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3205
3206         * gdbtypes.c (check_stub_method_group): Remove handling of old
3207         mangling schemes.
3208         * linespec.c (find_methods): Likewise.
3209         * stabsread.c (read_member_functions): Likewise.
3210         * valops.c (search_struct_method): Likewise.
3211         (value_struct_elt_for_reference): Likewise.
3212         * NEWS: Mention this change.
3213
3214 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3217         print_source_lines.
3218         * source.c (print_source_lines_base): Update line number check.
3219         (print_source_lines): New function.
3220         (source_lines_range::source_lines_range): New function.
3221         * source.h (class source_lines_range): New class.
3222         (print_source_lines): New declaration.
3223
3224 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3225
3226         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3227
3228 2019-01-08  Tom Tromey  <tom@tromey.com>
3229             Simon Marchi  <simon.marchi@ericsson.com>
3230
3231         PR gdb/24060
3232         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3233         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3234         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3235         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3236         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3237         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3238
3239 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * source.c (select_source_symtab): Move header comment to
3242         declaration in source.h.
3243         (forget_cached_source_info_for_objfile): Likewise.
3244         (forget_cached_source_info): Likewise.
3245         (identify_source_line): Likewise.
3246         * source.h (identify_source_line): Move declaration from symtab.h
3247         and add comment from source.c
3248         (print_source_lines): Likewise.
3249         (forget_cached_source_info_for_objfile): Likewise.
3250         (forget_cached_source_info): Likewise.
3251         (select_source_symtab): Likewise.
3252         (enum print_source_lines_flag): Move definition from symtab.h.
3253         * symtab.h (identify_source_line): Move declaration to source.h.
3254         (print_source_lines): Likewise.
3255         (forget_cached_source_info_for_objfile): Likewise.
3256         (forget_cached_source_info): Likewise.
3257         (select_source_symtab): Likewise.
3258         (enum print_source_lines_flag): Move definition to source.h.
3259         * tui/tui-hooks.c: Add 'source.h' include.
3260
3261 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * source.c (print_source_lines_base): Handle requests to print
3264         reverse line number sequences, and guard against empty lines
3265         string.
3266
3267 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * source.c (print_source_lines_base): Fix skip of '\r' if next
3270         character is '\n'.
3271
3272 2019-01-06  Tom Tromey  <tom@tromey.com>
3273
3274         * c-exp.y (struct c_parse_state) <macro_original_text,
3275         expansion_obstack>: New member.
3276         (macro_original_text, expansion_obstack): Remove globals.
3277         (scan_macro_expansion, scanning_macro_expansion)
3278         (finished_macro_expansion): Update.
3279         (scan_macro_cleanup): Remove.
3280         (yylex, c_parse): Update.
3281
3282 2019-01-06  Tom Tromey  <tom@tromey.com>
3283
3284         * c-exp.y (struct c_parse_state) <strings>: New member.
3285         (operator_stoken): Update.
3286
3287 2019-01-06  Tom Tromey  <tom@tromey.com>
3288
3289         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3290         (union type_stack_elt) <typelist_val>: Now a pointer to
3291         std::vector.
3292         (type_stack_cleanup): Don't declare.
3293         (push_typelist): Update.
3294         * parse.c (pop_typelist): Return a std::vector.
3295         (push_typelist): Take a std::vector.
3296         (follow_types): Update.  Do not free args.
3297         (type_stack_cleanup): Remove.
3298         * c-exp.y (struct c_parse_state): New.
3299         (cpstate): New global.
3300         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3301         (nonempty_typelist): Update.
3302         (func_mod): Create a new vector.
3303         (c_parse): Create a c_parse_state.
3304         (check_parameter_typelist): Do not delete params.
3305         (function_method): Update.  Do not delete type_list.
3306
3307 2019-01-06  Tom Tromey  <tom@tromey.com>
3308
3309         PR gdb/28155:
3310         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3311         check_typedef.
3312         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3313         (print_return_value): Likewise.
3314
3315 2019-01-05  Tom Tromey  <tom@tromey.com>
3316
3317         * contrib/cleanup_check.py: Remove.
3318         * contrib/gcc-with-excheck: Remove.
3319         * contrib/exsummary.py: Remove.
3320         * contrib/excheck.py: Remove.
3321
3322 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3323
3324         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3325         NULL. Initialize tpprev to NULL instead of assigning it
3326         to NULL on the next statement.
3327         * windows-nat.c (windows_delete_thread): Remove check for
3328         main_thread_id before printing thread exit notifications.
3329         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3330         Remove thread ID check against main_thread_id.
3331         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3332         windows_delete_thread.
3333         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3334
3335 2019-01-04  Tom Tromey  <tom@tromey.com>
3336
3337         * compile/compile.c (_initialize_compile): Use upper case for
3338         metasyntactic variables.
3339         * symmisc.c (_initialize_symmisc): Use upper case for
3340         metasyntactic variables.
3341         * psymtab.c (_initialize_psymtab): Use upper case for
3342         metasyntactic variables.
3343         * demangle.c (demangle_command): Use upper case for metasyntactic
3344         variables.
3345         (_initialize_demangler): Likewise.
3346         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3347         variables.
3348
3349 2019-01-03  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3352
3353 2019-01-03  Tom Tromey  <tom@tromey.com>
3354
3355         * python/py-symtab.c (salpy_str): Update.
3356         (struct salpy_sal_object) <symtab>: Now a PyObject.
3357         (salpy_dealloc): Update.
3358         (del_objfile_sal): Use gdbpy_ref.
3359
3360 2019-01-03  Tom Tromey  <tom@tromey.com>
3361
3362         * python/py-type.c (convert_field): Use new_reference.  Return
3363         gdbpy_ref.
3364         (make_fielditem): Return gdbpy_ref.
3365         (typy_fields): Update.
3366         (typy_getitem): Update.
3367         (field_name): Return gdbpy_ref.  Use new_reference.
3368         (typy_iterator_iternext): Update.
3369
3370 2019-01-03  Tom Tromey  <tom@tromey.com>
3371
3372         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3373
3374 2019-01-03  Tom Tromey  <tom@tromey.com>
3375
3376         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3377         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3378         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3379         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3380         (pspy_set_type_printers): Likewise.
3381         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3382         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3383         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3384         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3385         (objfpy_set_type_printers): Likewise.
3386
3387 2019-01-03  Tom Tromey  <tom@tromey.com>
3388
3389         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3390         (gdbpy_print_stack): Use gdbpy_err_fetch.
3391         * python/python-internal.h (class gdbpy_err_fetch): New class.
3392         (class gdbpy_enter) <m_error_type, m_error_value,
3393         m_error_traceback>: Remove.
3394         <m_error>: New member.
3395         (gdbpy_exception_to_string): Don't declare.
3396         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3397         * python/py-value.c (convert_value_from_python): Use
3398         gdbpy_err_fetch.
3399         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3400         gdbpy_exception_to_string.
3401         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3402         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3403         gdbpy_err_fetch.
3404
3405 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * linux-nat.c (delete_lwp_cleanup): Delete.
3408         (struct lwp_deleter): New struct.
3409         (lwp_info_up): New typedef.
3410         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3411         lwp_info_up.
3412
3413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * linux-fork.c (class scoped_switch_fork_info): New class.
3416         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3417
3418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * valops.c (find_overload_match): Remove use of null_cleanup, and
3421         calls to do_cleanups.
3422
3423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * compile/compile-cplus-types.c
3426         (compile_cplus_instance::decl_name): Handle changes to
3427         cp_func_name.
3428         * cp-support.c (cp_func_name): Update header comment, update
3429         return type.
3430         * cp-support.h (cp_func_name): Update return type in declaration.
3431         * valops.c (find_overload_match): Move temp_func local to top
3432         level of function and change its type.  Use temp_func to hold and
3433         delete temporary string obtained from cp_func_name.
3434
3435 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3438         gdb::char_vector, remove cleanup, and update uses of `msg`.
3439
3440 2019-01-03  Jim Wilson  <jimw@sifive.com>
3441
3442         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3443
3444 2019-01-02  Tom Tromey  <tom@tromey.com>
3445
3446         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3447         (tdesc_parse_xml): Remove cleanups.
3448         * target-descriptions.h (make_cleanup_free_target_description):
3449         Don't declare.
3450         (target_desc_deleter): New struct.
3451         (target_desc_up): New typedef.
3452         * target-descriptions.c (target_desc_deleter::operator()): Rename
3453         from free_target_description.
3454         (make_cleanup_free_target_description): Remove.
3455
3456 2019-01-02  Tom Tromey  <tom@tromey.com>
3457
3458         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3459         constructor, destructor.
3460         (linespec_parser): Remove typedef.
3461         (~linespec_parser): Rename from linespec_parser_delete.
3462         (linespec_lex_to_end, linespec_complete_label)
3463         (linespec_complete): Update.
3464         (decode_line_full): Remove cleanups.
3465         (decode_line_1): Update.
3466
3467 2019-01-02  Tom Tromey  <tom@tromey.com>
3468
3469         * python/python-internal.h (inferior_to_inferior_object): Change
3470         return type.
3471         * python/py-exitedevent.c (create_exited_event_object): Update.
3472         * python/py-inferior.c (inferior_to_inferior_object): Return
3473         gdbpy_ref.
3474         (python_new_inferior, python_inferior_deleted)
3475         (thread_to_thread_object, delete_thread_object)
3476         (build_inferior_list, gdbpy_selected_inferior): Update.
3477         * python/py-infthread.c (create_thread_object): Update.  Also fail
3478         if inferior_to_inferior_object fails.
3479
3480 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3481
3482         * inferior.h (class inferior) <displaced_step_state>: New field.
3483         * infrun.h (struct displaced_step_state): Move here from
3484         infrun.c.  Initialize fields, add constructor.
3485         <inf>: Remove field.
3486         <reset>: New method.
3487         * infrun.c (struct displaced_step_inferior_state): Move to
3488         infrun.h.
3489         (displaced_step_inferior_states): Remove.
3490         (get_displaced_stepping_state): Adust.
3491         (displaced_step_in_progress_any_inferior): Adjust.
3492         (displaced_step_in_progress_thread): Adjust.
3493         (displaced_step_in_progress): Adjust.
3494         (add_displaced_stepping_state): Remove.
3495         (get_displaced_step_closure_by_addr): Adjust.
3496         (remove_displaced_stepping_state): Remove.
3497         (infrun_inferior_exit): Call displaced_step_state.reset.
3498         (use_displaced_stepping): Don't check for NULL.
3499         (displaced_step_prepare_throw): Call
3500         get_displaced_stepping_state.
3501         (displaced_step_fixup): Don't check for NULL.
3502         (prepare_for_detach): Don't check for NULL.
3503
3504 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3505
3506         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3507          in case of call that did not complete.
3508
3509 2019-01-02  Andrey Utkin  <autkin@undo.io>
3510
3511         * symfile.c (find_separate_debug_file): Fix search of debug files for
3512         remote debuggee.
3513
3514 2019-01-02  Tom Tromey  <tom@tromey.com>
3515
3516         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3517         indentation.
3518         * python/py-frame.c (frapy_older): Remove cast.
3519         (frapy_newer): Likewise.
3520         * python/py-breakpoint.c (local_setattro): Remove cast.
3521         * python/py-arch.c (archpy_name): Remove local variable.
3522         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3523
3524 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3525
3526         * unittests/basic_string_view/element_access/char/empty.cc:
3527         Fix year range in copyright header.
3528
3529 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3532         Delete.
3533         <operator==>: Update with for removed field.
3534         <hash>: Likewise.
3535         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3536         <isa_features>: ...this.
3537         <abi_features>: New field.
3538         (riscv_isa_flen): Update comment.
3539         (riscv_abi_xlen): New declaration.
3540         (riscv_abi_flen): New declaration.
3541         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3542         isa_features.
3543         (riscv_abi_xlen): New function.
3544         (riscv_isa_flen): Update to get answer from isa_features.
3545         (riscv_abi_flen): New function.
3546         (riscv_has_fp_abi): Update to get answer from abi_features.
3547         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3548         xlen and flen.
3549         (riscv_call_info) <xlen, flen>: Update comment.
3550         (riscv_call_arg_struct): Remove invalid assertions
3551         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3552         is removed.
3553         (riscv_gdbarch_init): Gather isa features and abi features
3554         separately, ensure both match on the gdbarch when reusing an old
3555         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3556         a target with 64-bit float hardware.
3557
3558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3559
3560         * source.c (search_command_helper): Stop reverse search
3561         when line 1 has been searched.
3562
3563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3564
3565         * record-full.c (record_full_base_target::close): Rewrite
3566         record_full_core_buf_list free logic.
3567
3568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3569
3570         * break-catch-syscall.c (print_one_catch_syscall): xfree
3571         the last text.
3572
3573 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3574
3575         * top.c (print_gdb_version): Update Copyright year in version
3576         message.
3577
3578 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3579
3580         Update copyright year range in all GDB files.
3581
3582 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3583
3584         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3585
3586 For older changes see ChangeLog-2018.
3587 \f
3588 Local Variables:
3589 mode: change-log
3590 left-margin: 8
3591 fill-column: 74
3592 version-control: never
3593 coding: utf-8
3594 End:
3595