gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * type-stack.h: New file.
   4         * type-stack.c: New file.
   5         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
   6         type-stack.h.
   7         (insert_into_type_stack, insert_type, push_type, push_type_int)
   8         (insert_type_address_space, pop_type, pop_type_int)
   9         (pop_typelist, pop_type_stack, append_type_stack)
  10         (push_type_stack, get_type_stack, push_typelist)
  11         (follow_type_instance_flags, follow_types): Don't declare.
  12         * parse.c (type_stack): Remove global.
  13         (parse_exp_in_context): Update.
  14         (insert_into_type_stack, insert_type, push_type, push_type_int)
  15         (insert_type_address_space, pop_type, pop_type_int)
  16         (pop_typelist, pop_type_stack, append_type_stack)
  17         (push_type_stack, get_type_stack, push_typelist)
  18         (follow_type_instance_flags, follow_types): Remove (moved to
  19         type-stack.c).
  20         * f-exp.y (type_stack): New global.
  21         Update rules.
  22         (push_kind_type, f_parse): Update.
  23         * d-exp.y (type_stack): New global.
  24         Update rules.
  25         (d_parse): Update.
  26         * c-exp.y (struct c_parse_state) <type_stack>: New member.
  27         Update rules.
  28         * Makefile.in (COMMON_SFILES): Add type-stack.c.
  29         (HFILES_NO_SRCDIR): Add type-stack.h.
  30
  31 2019-04-04  Tom Tromey  <tom@tromey.com>
  32
  33         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
  34         (rust_parser::convert_ast_to_expression, rust_parse)
  35         (rust_lex_test_completion, rust_lex_tests): Update.
  36         * parser-defs.h (struct expr_completion_state): New.
  37         (struct parser_state) <parser_state>: Add completion parameter.
  38         <mark_struct_expression, mark_completion_tag>: New methods.
  39         <parse_completion, m_completion_state>: New members.
  40         (prefixify_expression, null_post_parser): Update.
  41         (mark_struct_expression, mark_completion_tag): Don't declare.
  42         * parse.c (parse_completion, expout_last_struct)
  43         (expout_tag_completion_type, expout_completion_name): Remove
  44         globals.
  45         (parser_state::mark_struct_expression)
  46         (parser_state::mark_completion_tag): Now methods.
  47         (prefixify_expression): Add last_struct parameter.
  48         (prefixify_subexp): Likewise.
  49         (parse_exp_1): Update.
  50         (parse_exp_in_context): Add cstate parameter.  Update.
  51         (parse_expression_for_completion): Create an
  52         expr_completion_state.
  53         (null_post_parser): Add "completion" parameter.
  54         * p-exp.y: Update rules.
  55         (yylex): Update.
  56         * language.h (struct language_defn) <la_post_parser>: Add
  57         "completing" parameter.
  58         * go-exp.y: Update rules.
  59         (lex_one_token): Update.
  60         * expression.h (parse_completion): Don't declare.
  61         * d-exp.y: Update rules.
  62         (lex_one_token): Update rules.
  63         * c-exp.y: Update rules.
  64         (lex_one_token): Update.
  65         * ada-lang.c (resolve): Add "parse_completion" parameter.
  66         (resolve_subexp): Likewise.
  67         (ada_resolve_function): Likewise.
  68
  69 2019-04-04  Tom Tromey  <tom@tromey.com>
  70
  71         * parser-defs.h (struct parser_state) <start_arglist,
  72         end_arglist>: New methods.
  73         <arglist_len, m_funcall_chain>: New members.
  74         (arglist_len, start_arglist, end_arglist): Don't declare.
  75         * parse.c (arglist_len, funcall_chain): Remove global.
  76         (start_arglist, end_arglist): Remove functions.
  77         (parse_exp_in_context): Update.
  78         * p-exp.y: Update rules.
  79         * m2-exp.y: Update rules.
  80         * go-exp.y: Update rules.
  81         * f-exp.y: Update rules.
  82         * d-exp.y: Update rules.
  83         * c-exp.y: Update rules.
  84
  85 2019-04-04  Tom Tromey  <tom@tromey.com>
  86
  87         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
  88         lex_operator, push_back>: New methods.
  89         Update all rules.
  90         (rust_parser::lex_hex, lex_escape): Rename and update.
  91         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
  92         (rust_parser::lex_operator): Rename and update.
  93         (rust_parser::lex_number, rustyylex, rustyyerror)
  94         (rust_lex_test_init, rust_lex_test_sequence)
  95         (rust_lex_test_push_back, rust_lex_tests): Update.
  96         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
  97         parameter.
  98         <lexptr, prev_lexptr>: New members.
  99         (lexptr, prev_lexptr): Don't declare.
 100         * parse.c (lexptr, prev_lexptr): Remove globals.
 101         (parse_exp_in_context): Update.
 102         * p-exp.y (yylex, yyerror): Update.
 103         * m2-exp.y (parse_number, yylex, yyerror): Update.
 104         * go-exp.y (lex_one_token, yyerror): Update.
 105         * f-exp.y (match_string_literal, yylex, yyerror): Update.
 106         * d-exp.y (lex_one_token, yyerror): Update.
 107         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
 108         (lex_one_token, yyerror): Update.
 109         * ada-lex.l (YY_INPUT): Update.
 110         (rewind_to_char): Update.
 111         * ada-exp.y (yyerror): Update.
 112
 113 2019-04-04  Tom Tromey  <tom@tromey.com>
 114
 115         * rust-exp.y (rustyylex, rust_lex_tests): Update.
 116         * parser-defs.h (struct parser_state) <parser_state>: Add new
 117         parameter.
 118         <comma_terminates>: New member.
 119         (comma_terminates): Don't declare global.
 120         * parse.c (comma_terminates): Remove global.
 121         (parse_exp_in_context): Update.
 122         * p-exp.y (yylex): Update.
 123         * m2-exp.y (yylex): Update.
 124         * go-exp.y (lex_one_token): Update.
 125         * f-exp.y (yylex): Update.
 126         * d-exp.y (lex_one_token): Update.
 127         * c-exp.y (lex_one_token): Update.
 128         * ada-lex.l: Update.
 129
 130 2019-04-04  Tom Tromey  <tom@tromey.com>
 131
 132         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
 133         (rustyylex, rust_lex_test_init, rust_lex_test_one)
 134         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
 135         * parser-defs.h (paren_depth): Don't declare.
 136         * parse.c (paren_depth): Remove global.
 137         (parse_exp_in_context): Update.
 138         * p-exp.y (paren_depth): New global.
 139         (pascal_parse): Initialize it.
 140         * m2-exp.y (paren_depth): New global.
 141         (m2_parse): Initialize it.
 142         * go-exp.y (paren_depth): New global.
 143         (go_parse): Initialize it.
 144         * f-exp.y (paren_depth): New global.
 145         (f_parse): Initialize it.
 146         * d-exp.y (paren_depth): New global.
 147         (d_parse): Initialize it.
 148         * c-exp.y (paren_depth): New global.
 149         (c_parse): Initialize it.
 150         * ada-lex.l (paren_depth): New global.
 151         (lexer_init): Initialize it.
 152
 153 2019-04-04  Tom Tromey  <tom@tromey.com>
 154
 155         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
 156         (rust_parser::convert_ast_to_type)
 157         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 158         * parser-defs.h (struct parser_state) <parser_state>: Add
 159         parameters.  Initialize new members.
 160         <expression_context_block, expression_context_pc>: New members.
 161         * parse.c (expression_context_block, expression_context_pc):
 162         Remove globals.
 163         (parse_exp_in_context): Update.
 164         * p-exp.y: Update all rules.
 165         (yylex): Update.
 166         * m2-exp.y: Update all rules.
 167         (yylex): Update.
 168         * go-exp.y (yylex): Update.
 169         * f-exp.y (yylex): Update.
 170         * d-exp.y: Update all rules.
 171         (yylex): Update.
 172         * c-exp.y: Update all rules.
 173         (lex_one_token, classify_name, yylex, c_parse): Update.
 174         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 175
 176 2019-04-04  Tom Tromey  <tom@tromey.com>
 177
 178         * gdbarch.h, gdbarch.c: Rebuild.
 179         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 180         * stap-probe.h:
 181         (struct stap_parse_info): Replace "parser_state" with
 182         "expr_builder".
 183         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 184         (parser_state): New class.
 185         * parse.c (expr_builder): Rename.
 186         (expr_builder::release): Rename.
 187         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 188         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 189         (write_exp_elt_longcst, write_exp_elt_floatcst)
 190         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 191         (write_exp_string_vector, write_exp_bitstring)
 192         (write_exp_msymbol, mark_struct_expression)
 193         (write_dollar_variable)
 194         (insert_type_address_space, increase_expout_size): Replace
 195         "parser_state" with "expr_builder".
 196         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 197         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 198         "parser_state" with "expr_builder".
 199
 200 2019-04-04  Tom Tromey  <tom@tromey.com>
 201
 202         * rust-exp.y: Replace "parse_language" with method call.
 203         * p-exp.y:
 204         (yylex): Replace "parse_language" with method call.
 205         * m2-exp.y:
 206         (yylex): Replace "parse_language" with method call.
 207         * go-exp.y (classify_name): Replace "parse_language" with method
 208         call.
 209         * f-exp.y (yylex): Replace "parse_language" with method call.
 210         * d-exp.y (lex_one_token): Replace "parse_language" with method
 211         call.
 212         * c-exp.y:
 213         (lex_one_token, classify_name, yylex): Replace "parse_language"
 214         with method call.
 215         * ada-exp.y (find_primitive_type, type_char)
 216         (type_system_address): Replace "parse_language" with method call.
 217
 218 2019-04-04  Tom Tromey  <tom@tromey.com>
 219
 220         * rust-exp.y: Replace "parse_gdbarch" with method call.
 221         * parse.c (write_dollar_variable, insert_type_address_space):
 222         Replace "parse_gdbarch" with method call.
 223         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 224         call.
 225         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 226         call.
 227         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 228         "parse_gdbarch" with method call.
 229         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 230         with method call.
 231         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 232         "parse_gdbarch" with method call.
 233         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 234         "parse_gdbarch" with method call.
 235         * c-exp.y (parse_type, parse_number, classify_name): Replace
 236         "parse_gdbarch" with method call.
 237         * ada-lex.l: Replace "parse_gdbarch" with method call.
 238         * ada-exp.y (parse_type, find_primitive_type, type_char)
 239         (type_system_address): Replace "parse_gdbarch" with method call.
 240
 241 2019-04-04  Tom Tromey  <tom@tromey.com>
 242
 243         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 244         * stap-probe.c (stap_parse_argument): Update.
 245         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 246         initial_size parameter.
 247         * rust-exp.y (rust_lex_tests): Update.
 248         * parse.c (parser_state): Update.
 249         (parse_exp_in_context): Update.
 250         * parser-defs.h (struct parser_state) <parser_state>: Remove
 251         "initial_size" parameter.
 252
 253 2019-04-04  Tom Tromey  <tom@tromey.com>
 254
 255         * parser-defs.h (increase_expout_size): Don't declare.
 256         * parse.c (increase_expout_size): Now static.
 257
 258 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 259
 260         * gnu-nat.c (gnu_nat_target::wait): Fix
 261         target_waitstatus_to_string call.
 262
 263 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * eval.c (evaluate_subexp_standard): Handle internal functions
 266         during Fortran function call handling.
 267
 268 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 269
 270         * NEWS: Mention new internal functions.
 271         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 272         (read_base_type): Use dwarf2_init_complex_target_type.
 273         * value.c (creal_internal_fn): New function.
 274         (cimag_internal_fn): New function.
 275         (_initialize_values): Register new internal functions.
 276
 277 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 278
 279         * infrun.c (stop_all_threads): If debug_infrun, always
 280         trace the wait status after wait_one, using
 281         target_waitstatus_to_string and target_pid_to_str.
 282         (handle_inferior_event): Replace various trace of
 283         wait status kind by a single trace.
 284         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 285         wait status kind image by target_waitstatus_to_string.
 286         * target/waitstatus.c (target_waitstatus_to_string): Fix
 287         obsolete comment.
 288
 289 2019-04-01  Tom Tromey  <tromey@adacore.com>
 290
 291         PR symtab/23331:
 292         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 293
 294 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 295             Pedro Alves  <palves@redhat.com>
 296
 297         * top.c (quit_force): Call 'finalize_values'.
 298         * value.c (finalize_values): New function.
 299         * value.h (finalize_values): Declare.
 300
 301 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 302
 303         * NEWS: Announce $_gdb_major and $_gdb_minor.
 304
 305         * top.c (init_gdb_version_vars): New function.
 306         (gdb_init): Call init_gdb_version_vars.
 307
 308 2019-03-29  Tom Tromey  <tromey@adacore.com>
 309
 310         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 311         help text.  Remove dead code.
 312
 313 2019-03-29  Keith Seitz  <keiths@redhat.com>
 314
 315         From Siddhesh Poyarekar:
 316         * f-lang.h (f77_get_upperbound): Return LONGEST.
 317         (f77_get_lowerbound): Likewise.
 318         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 319         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 320         print them.
 321         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 322         plongest to format print it.
 323         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 324         (f77_get_upperbound): Likewise.
 325         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 326         LOWER_BOUND to LONGEST.
 327         (f77_create_arrayprint_offset_tbl): Likewise.
 328
 329 2019-03-29  Keith Seitz  <keiths@redhat.com>
 330
 331         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 332         %s/pulongest for TYPE_LENGTH instead of %d in format
 333         strings.
 334         * ada-typerint.c (ada_print_type): Likewise.
 335         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 336         * compile/compile-c-support.c (generate_register_struct): Likewise.
 337         * gdbtypes.c (recursive_dump_type): Likewise.
 338         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 339         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 340         instead of %d in format strings.
 341         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 342         to std::min to ULONGEST.
 343         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 344         instead of %d in format strings.
 345         * tracepoint.c (info_scope_command): Likewise.
 346         * typeprint.c (print_offset_data::update)
 347         (print_offset_data::finish): Likewise.
 348         * xtensa-tdep.c (xtensa_store_return_value)
 349         (xtensa_push_dummy_call): Likewise.
 350
 351 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 352
 353         * windows-nat.c (display_selector): Fixed format specifications
 354         for 64-bit Cygwin.
 355
 356 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 357
 358         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 359
 360 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 361
 362         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 363         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 364         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 365         (nios2_linux_init_abi): Install it.
 366
 367 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 368
 369         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 370
 371 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 372
 373         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 374
 375 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 376             Tom Tromey  <tromey@adacore.com>
 377
 378         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 379
 380 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 381
 382         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 383         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 384         method to compute the bounds of range types. Also print "[evaluated]"
 385         if the bounds' values come from a dynamic evaluation.
 386
 387 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 390         whitespace when pretty printing is on.
 391
 392 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 393
 394         * ppc-linux-nat.c: Add include.
 395
 396 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 397
 398         * NEWS: Mention AArch64 Pointer Authentication.
 399
 400 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 401
 402         * arm-linux-nat.c: Add include.
 403
 404 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 405
 406         * source-cache.c (source_cache::get_source_lines): Re-read
 407         fullname after calling open_source_file.
 408
 409 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 410
 411         * NEWS: Mention TLS support for FreeBSD.
 412
 413 2019-03-25  Tom Tromey  <tromey@adacore.com>
 414
 415         * minsyms.c (BUNCH_SIZE): Update comment.
 416         (~minimal_symbol_reader): Remove old comment.
 417         (compact_minimal_symbols): Update comment.
 418         (minimal_symbol_reader::install): Remove old comment.  Update
 419         other comments.
 420
 421 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 422
 423         * s390-linux-nat.c: Add include.
 424
 425 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 426
 427         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 428         Call linux_get_hwcap.
 429         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 430         Likewise.
 431         (aarch64_linux_get_hwcap): Remove function.
 432         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 433         declaration.
 434         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 435         linux_get_hwcap.
 436         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 437         * linux-tdep.c (linux_get_hwcap): Add function.
 438         (linux_get_hwcap2): Likewise.
 439         * linux-tdep.h (linux_get_hwcap): Add declaration.
 440         (linux_get_hwcap2): Likewise.
 441         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 442         (ppc_linux_get_hwcap2): Likewise.
 443         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 444         linux_get_hwcap.
 445         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 446         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 447         (ppc_linux_nat_target::read_description): Likewise.
 448         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 449         * s390-linux-nat.c: Likewise.
 450         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 451
 452 2019-03-24  Tom Tromey  <tom@tromey.com>
 453
 454         * ada-lang.c (standard_lookup): Simplify initialization.
 455         (ada_lookup_symbol_nonlocal): Simplify return.
 456         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 457         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 458         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 459         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 460         initialization.
 461         * solib.c (solib_global_lookup): Simplify.
 462         * symtab.c (null_block_symbol): Remove.
 463         (symbol_cache_lookup): Simplify returns.
 464         (lookup_language_this): Simplify returns.
 465         (lookup_symbol_aux): Simplify return.
 466         (lookup_local_symbol): Simplify returns.
 467         (lookup_global_symbol_from_objfile): Simplify return.
 468         (lookup_symbol_in_objfile_symtabs)
 469         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 470         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 471         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 472         * cp-namespace.c (cp_lookup_bare_symbol)
 473         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 474         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 475         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 476         (cp_lookup_symbol_via_imports): Simplify initialization.
 477         (find_symbol_in_baseclass): Likewise.
 478         * symtab.h (null_block_symbol): Remove.
 479         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 480         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 481         (d_lookup_symbol_module): Likewise.
 482         (find_symbol_in_baseclass): Simplify initialization.
 483
 484 2019-03-24  Tom Tromey  <tom@tromey.com>
 485
 486         * expression.h: Don't include symtab.h.
 487         (struct block): Forward declare.
 488
 489 2019-03-24  Tom Tromey  <tom@tromey.com>
 490
 491         * c-exp.y (typebase): Remove casts.
 492         * gdbtypes.c (lookup_unsigned_typename, )
 493         (lookup_signed_typename): Remove cast.
 494         * eval.c (parse_to_comma_and_eval): Remove cast.
 495         * parse.c (write_dollar_variable): Remove cast.
 496         * block.h (struct block) <superblock>: Now const.
 497         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 498         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 499         (map_block): Make "block" const.
 500         * symfile.h (struct quick_symbol_functions)
 501         <map_matching_symbols>: Constify block argument to "callback".
 502         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 503         const.
 504         (find_pc_sect_compunit_symtab): Make "b" const.
 505         (find_symbol_at_address): Likewise.
 506         (search_symbols): Likewise.
 507         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 508         (dw2_debug_names_lookup_symbol): Likewise.
 509         (dw2_map_matching_symbols): Update.
 510         * p-valprint.c (pascal_val_print): Remove "block".
 511         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 512         (aux_add_nonlocal_symbols): Make "block" const.
 513         (resolve_subexp): Remove cast.
 514         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 515         const.
 516         (iterate_over_file_blocks): Likewise.
 517         * f-exp.y (%union) <bval>: Remove.
 518         * coffread.c (patch_opaque_types): Make "b" const.
 519         * spu-tdep.c (spu_catch_start): Make "block" const.
 520         * c-valprint.c (print_unpacked_pointer): Remove "block".
 521         * symmisc.c (dump_symtab_1): Make "b" const.
 522         (block_depth): Make "block" const.
 523         * d-exp.y (%union) <bval>: Remove.
 524         * cp-support.h (cp_lookup_rtti_type): Update.
 525         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 526         * psymtab.c (psym_lookup_symbol): Make "block" const.
 527         (maintenance_check_psymtabs): Make "b" const.
 528         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 529         (enumerate_locals, enumerate_args): Update.
 530         * python/py-symtab.c (stpy_global_block): Make "block" const.
 531         (stpy_static_block): Likewise.
 532         * inline-frame.c (block_starting_point_at): Make "new_block"
 533         const.
 534         * block.c (find_block_in_blockvector): Make return type const.
 535         (blockvector_for_pc_sect): Make "b" const.
 536         (find_block_in_blockvector): Make "b" const.
 537
 538 2019-03-23  Tom Tromey  <tom@tromey.com>
 539
 540         * varobj.c (varobj_create): Update.
 541         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 542         * printcmd.c (display_command, do_one_display): Don't reset
 543         innermost_block.
 544         * parser-defs.h (enum innermost_block_tracker_type): Move to
 545         expression.h.
 546         (innermost_block): Update comment.
 547         * parse.c (parse_exp_1): Add tracker_types parameter.
 548         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 549         tracker_types parameter.  Reset innermost_block.
 550         (parse_exp_in_context): Remove.
 551         (parse_expression_for_completion): Update.
 552         * objfiles.c (~objfile): Don't reset expression_context_block or
 553         innermost_block.
 554         * expression.h (enum innermost_block_tracker_type): Move from
 555         parser-defs.h.
 556         (parse_exp_1): Add tracker_types parameter.
 557         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 558         reset innermost_block.
 559
 560 2019-03-23  Tom Tromey  <tom@tromey.com>
 561
 562         * objfiles.h: Include bcache.h.
 563
 564 2019-03-23  Tom Tromey  <tom@tromey.com>
 565
 566         * linespec.c (get_current_search_block): Use
 567         scoped_restore_current_language.
 568         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 569
 570 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 571             Jiong Wang  <jiong.wang@arm.com>
 572
 573         * aarch64-linux-tdep.c
 574         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 575         section.
 576         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 577
 578 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 579             Jiong Wang  <jiong.wang@arm.com>
 580
 581         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 582         instructions.
 583         (aarch64_analyze_prologue_test): Add PACIASP test.
 584         (aarch64_prologue_prev_register): Unmask PC value.
 585
 586 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 587             Jiong Wang  <jiong.wang@arm.com>
 588
 589         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 590         (aarch64_dwarf2_prev_register): Unmask PC value.
 591         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 592         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 593         DW_CFA_AARCH64_negate_ra_state.
 594         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 595
 596 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 597             Jiong Wang  <jiong.wang@arm.com>
 598
 599         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 600         registers.
 601         (aarch64_pseudo_register_name): Likewise.
 602         (aarch64_pseudo_register_type): Likewise.
 603         (aarch64_pseudo_register_reggroup_p): Likewise.
 604         (aarch64_gdbarch_init): Add pauth registers.
 605         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 606         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 607         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 608         (struct gdbarch_tdep): Add regnum for ra_state.
 609
 610 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 611             Jiong Wang  <jiong.wang@arm.com>
 612
 613         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 614
 615 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 616             Jiong Wang  <jiong.wang@arm.com>
 617
 618         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 619         function.
 620         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 621         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 622         (aarch64_gdbarch_init): Add puth registers.
 623         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 624         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 625         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 626
 627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 628             Jiong Wang  <jiong.wang@arm.com>
 629
 630         * aarch64-linux-nat.c
 631         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 632         * aarch64-linux-tdep.c
 633         (aarch64_linux_core_read_description): Likewise.
 634         (aarch64_linux_get_hwcap): New function.
 635         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 636         (aarch64_linux_get_hwcap): New declaration.
 637
 638 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 639             Jiong Wang  <jiong.wang@arm.com>
 640
 641         * aarch64-linux-nat.c
 642         (aarch64_linux_nat_target::read_description): Add pauth param.
 643         * aarch64-linux-tdep.c
 644         (aarch64_linux_core_read_description): Likewise.
 645         * aarch64-tdep.c (struct target_desc): Add in pauth.
 646         (aarch64_read_description): Add pauth param.
 647         (aarch64_gdbarch_init): Likewise.
 648         * aarch64-tdep.h (aarch64_read_description): Likewise.
 649         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 650         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 651         * features/Makefile: Add new files.
 652         * features/aarch64-pauth.c: New file.
 653         * features/aarch64-pauth.xml: New file.
 654
 655 2019-03-20  Tom Tromey  <tromey@adacore.com>
 656
 657         * infrun.c (handle_inferior_event): Rename from
 658         handle_inferior_event_1.  Create a scoped_value_mark.
 659         (handle_inferior_event): Remove.
 660
 661 2019-03-19  Tom Tromey  <tromey@adacore.com>
 662
 663         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 664         * infrun.h (print_stop_event): Add "displays" parameter.
 665         * infrun.c (print_stop_event): Add "displays" parameter.
 666
 667 2019-03-19  Pedro Alves  <palves@redhat.com>
 668
 669         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 670         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 671         to -1.  Fix TABs vs spaces.
 672         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 673         * tui/tui-out.h (tui_ui_out) Add intro comments.
 674         <m_line, m_start_of_line>: In-class initialize, and add describing
 675         comment.
 676
 677 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 678
 679         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 680         variable names.
 681         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 682
 683 2019-03-18  Pedro Alves  <palves@redhat.com>
 684             Eli Zaretskii <eliz@gnu.org>
 685
 686         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 687         m_line and m_start_of_line.
 688
 689 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 690
 691         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 692         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 693         it returns a newline.  This fixes a regression in TU mode, whereby
 694         the next line is output on the same screen line as the user input.
 695
 696 2019-03-18  Tom Tromey  <tromey@adacore.com>
 697
 698         * minsyms.c (minimal_symbol_reader::install): Remove call to
 699         obstack_blank.
 700
 701 2019-03-18  Pedro Alves  <palves@redhat.com>
 702
 703         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 704         New globals.
 705         (apply_style): New, factored out from ...
 706         (apply_ansi_escape): ... this.  Handle reverse video mode.
 707         (tui_set_reverse_mode): New function.
 708         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 709         * tui/tui-winsource.c (tui_show_source_line): Use
 710         tui_set_reverse_mode instead of setting A_STANDOUT.
 711         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 712         New setter methods.
 713
 714 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 715
 716         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 717         Handle tabs.
 718
 719 2019-03-18  Tom Tromey  <tromey@adacore.com>
 720
 721         * ada-lang.c (empty_array): Add "high" parameter.
 722         (ada_evaluate_subexp): Update.
 723
 724 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 725
 726         * unittests/string_view-selftests.c: Define
 727         _initialize_string_view_selftests unconditionally.
 728
 729 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 730
 731         PR gdb/24350
 732         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 733
 734 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 735
 736         PR gdb/24351
 737         * windows-nat.c (display_selector): Fix format specifiers.
 738
 739 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 740
 741         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 742         tui_refill_source_window instead of tui_refresh_win, to update the
 743         current execution line.  This fixes redisplay of the current line
 744         when stepping through the code with "next" or "step".
 745
 746 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 747
 748         * source-cache.c (source_cache::get_source_lines): Call
 749         find_source_lines to initialize s->nlines.  This fixes vertical
 750         scrolling of TUI source window when the DOWN arrow is pressed.
 751
 752 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 753
 754         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 755         linux-thread-db.c (_initialize_thread_db): Likewise.
 756
 757 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 758
 759         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 760         wclrtoeol in tui_show_source_line".  This reverts changes made in
 761         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 762
 763 2019-03-15  Tom Tromey  <tom@tromey.com>
 764
 765         * symtab.h (struct minimal_symbol): Derive from
 766         general_symbol_info.
 767         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 768         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 769         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 770         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 771         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 772         (MSYMBOL_SEARCH_NAME): Update.
 773         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 774         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 775         * minsyms.c (minimal_symbol_reader::record_full): Update.
 776
 777 2019-03-15  Tom Tromey  <tom@tromey.com>
 778
 779         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 780
 781 2019-03-15  Tom Tromey  <tom@tromey.com>
 782
 783         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 784         unique_xmalloc_ptr.
 785         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 786         Update.
 787         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 788         (build_minimal_symbol_hash_tables)
 789         (minimal_symbol_reader::install): Update.
 790
 791 2019-03-15  Tom Tromey  <tom@tromey.com>
 792
 793         * symtab.c (create_demangled_names_hash): Update.
 794         (symbol_set_names): Update.
 795         * objfiles.h (struct objfile_per_bfd_storage)
 796         <demangled_names_hash>: Now an htab_up.
 797         * objfiles.c (objfile_per_bfd_storage): Simplify.
 798
 799 2019-03-15  Tom Tromey  <tom@tromey.com>
 800
 801         * objfiles.h (struct objfile_per_bfd_storage): Declare
 802         destructor.
 803         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 804         New.
 805         (get_objfile_bfd_data): Use new.  Don't initialize
 806         language_of_main.
 807         (free_objfile_per_bfd_storage): Remove.
 808         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 809
 810 2019-03-15  Tom Tromey  <tom@tromey.com>
 811
 812         * symfile.c (reread_symbols): Update.
 813         * objfiles.c (objfile::objfile): Update.
 814         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 815         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 816         comment.
 817         (minimal_symbol_reader::install): Update.
 818         (terminate_minimal_symbol_table): Remove.
 819         * jit.c (jit_object_close_impl): Update.
 820
 821 2019-03-15  Tom Tromey  <tom@tromey.com>
 822
 823         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 824         initializations.
 825
 826 2019-03-15  Tom Tromey  <tom@tromey.com>
 827
 828         * objfiles.h (struct objfile_per_bfd_storage)
 829         <demangled_hash_languages>: Now a bitset.
 830         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 831         (lookup_minimal_symbol): Update.
 832
 833 2019-03-15  Tom Tromey  <tom@tromey.com>
 834
 835         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 836         Don't return the symbol.
 837         * coffread.c (record_minimal_symbol): Use record_full.
 838
 839 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 840
 841         The MS-Windows port of ncurses fails to switch to a color pair if
 842         one or both of the colors are the implicit default colors.  This
 843         change records the default colors when TUI is initialized, and
 844         then specifies them explicitly when a color pair uses the default
 845         colors.  This allows color styling in TUI mode on MS-Windows.
 846
 847         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 848         ncurses_norm_attr.
 849         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 850         colors in ncurses_norm_attr.
 851         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 852         "none", replace it with the default color recorded in
 853         ncurses_norm_attr.
 854
 855 2019-03-14  Tom Tromey  <tromey@adacore.com>
 856
 857         * source-cache.h (class source_cache) <get_source_lines>: Return
 858         std::string.
 859         * source-cache.c (source_cache::extract_lines): Handle case where
 860         first_pos==npos.  Return std::string.
 861         (source_cache::get_source_lines): Update.
 862
 863 2019-03-14  Tom Tromey  <tromey@adacore.com>
 864
 865         * NEWS: Add item for "style sources" commands.
 866         * source-cache.c (source_cache::get_source_lines): Check
 867         source_styling.
 868         * cli/cli-style.c (source_styling): New global.
 869         (_initialize_cli_style): Add "style sources" commands.
 870         (show_style_sources): New function.
 871         * cli/cli-style.h (source_styling): Declare.
 872
 873 2019-03-14  Pedro Alves  <palves@redhat.com>
 874             Tom Tromey  <tromey@adacore.com>
 875
 876         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 877         * tui/tui-winsource.c (tui_refill_source_window): New function,
 878         from...
 879         (tui_horizontal_source_scroll): ... here.  Move some logic.
 880         * cli/cli-style.c (set_style_enabled): Notify new observable.
 881         * tui/tui-hooks.c (tui_redisplay_source): New function.
 882         (tui_attach_detach_observers): Attach or detach
 883         tui_redisplay_source.
 884         * observable.h (source_styling_changed): New observable.
 885         * observable.c: Define source_styling_changed observable.
 886
 887 2019-03-13  Tom Tromey  <tromey@adacore.com>
 888
 889         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 890         (i386_gnu_nat_target::store_registers): Update.
 891         * target-debug.h (target_debug_print_std_string): New macro.
 892         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 893         * windows-tdep.c (display_one_tib): Update.
 894         * tui/tui-stack.c (tui_make_status_line): Update.
 895         * top.c (print_inferior_quit_action): Update.
 896         * thread.c (thr_try_catch_cmd): Update.
 897         (add_thread_with_info): Update.
 898         (thread_target_id_str): Update.
 899         (thr_try_catch_cmd): Update.
 900         (thread_command): Update.
 901         (thread_find_command): Update.
 902         * record-btrace.c (record_btrace_target::info_record)
 903         (record_btrace_resume_thread, record_btrace_target::resume)
 904         (record_btrace_cancel_resume, record_btrace_step_thread)
 905         (record_btrace_target::wait, record_btrace_target::wait)
 906         (record_btrace_target::wait, record_btrace_target::stop): Update.
 907         * progspace.c (print_program_space): Update.
 908         * process-stratum-target.c
 909         (process_stratum_target::thread_address_space): Update.
 910         * linux-fork.c (linux_fork_mourn_inferior)
 911         (detach_checkpoint_command, info_checkpoints_command)
 912         (linux_fork_context): Update.
 913         (linux_fork_detach): Update.
 914         (class scoped_switch_fork_info): Update.
 915         (delete_checkpoint_command): Update.
 916         * infrun.c (follow_fork_inferior): Update.
 917         (follow_fork_inferior): Update.
 918         (proceed_after_vfork_done): Update.
 919         (handle_vfork_child_exec_or_exit): Update.
 920         (follow_exec): Update.
 921         (displaced_step_prepare_throw): Update.
 922         (displaced_step_restore): Update.
 923         (start_step_over): Update.
 924         (resume_1): Update.
 925         (clear_proceed_status_thread): Update.
 926         (proceed): Update.
 927         (print_target_wait_results): Update.
 928         (do_target_wait): Update.
 929         (context_switch): Update.
 930         (stop_all_threads): Update.
 931         (restart_threads): Update.
 932         (finish_step_over): Update.
 933         (handle_signal_stop): Update.
 934         (switch_back_to_stepped_thread): Update.
 935         (keep_going_pass_signal): Update.
 936         (print_exited_reason): Update.
 937         (normal_stop): Update.
 938         * inferior.c (inferior_pid_to_str): Change return type.
 939         (print_selected_inferior): Update.
 940         (add_inferior): Update.
 941         (detach_inferior): Update.
 942         * dummy-frame.c (fprint_dummy_frames): Update.
 943         * dcache.c (dcache_info_1): Update.
 944         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 945         (btrace_fetch, btrace_clear): Update.
 946         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 947         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 948         type.
 949         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 950         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 951         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 952         * gdbarch.c, gdbarch.h: Rebuild.
 953         * gdbarch.sh (core_pid_to_str): Change return type.
 954         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 955         return type.
 956         (windows_nat_target::pid_to_str): Change return type.
 957         (windows_delete_thread): Update.
 958         (windows_nat_target::attach): Update.
 959         (windows_nat_target::files_info): Update.
 960         * target-delegates.c: Rebuild.
 961         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 962         return type.
 963         (sol_thread_target::pid_to_str): Change return type.
 964         * remote.c (class remote_target) <pid_to_str>: Change return
 965         type.
 966         (remote_target::pid_to_str): Change return type.
 967         (extended_remote_target::attach, remote_target::remote_stop_ns)
 968         (remote_target::remote_notif_remove_queued_reply)
 969         (remote_target::push_stop_reply, remote_target::disable_btrace):
 970         Update.
 971         (extended_remote_target::attach): Update.
 972         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 973         type.
 974         (gdbsim_target::pid_to_str): Change return type.
 975         * ravenscar-thread.c (struct ravenscar_thread_target)
 976         <pid_to_str>: Change return type.
 977         (ravenscar_thread_target::pid_to_str): Change return type.
 978         * procfs.c (class procfs_target) <pid_to_str>: Change return
 979         type.
 980         (procfs_target::pid_to_str): Change return type.
 981         (procfs_target::attach): Update.
 982         (procfs_target::detach): Update.
 983         (procfs_target::fetch_registers): Update.
 984         (procfs_target::store_registers): Update.
 985         (procfs_target::wait): Update.
 986         (procfs_target::files_info): Update.
 987         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 988         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 989         return type.
 990         (nto_procfs_target::pid_to_str): Change return type.
 991         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 992         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 993         return type.
 994         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 995         (exit_lwp): Update.
 996         (attach_proc_task_lwp_callback, get_detach_signal)
 997         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 998         (linux_nat_target::resume, wait_lwp, stop_callback)
 999         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1000         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1001         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1002         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1003         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1004         type.
1005         (inf_ptrace_target::attach): Update.
1006         (inf_ptrace_target::files_info): Update.
1007         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1008         type.
1009         (go32_nat_target::pid_to_str): Change return type.
1010         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1011         (gnu_nat_target::wait): Update.
1012         (gnu_nat_target::wait): Update.
1013         (gnu_nat_target::resume): Update.
1014         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1015         (fbsd_nat_target::wait): Update.
1016         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1017         type.
1018         (darwin_nat_target::attach): Update.
1019         * corelow.c (class core_target) <pid_to_str>: Change return type.
1020         (core_target::pid_to_str): Change return type.
1021         * target.c (normal_pid_to_str): Change return type.
1022         (default_pid_to_str): Likewise.
1023         (target_pid_to_str): Change return type.
1024         (target_translate_tls_address): Update.
1025         (target_announce_detach): Update.
1026         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1027         return type.
1028         (bsd_uthread_target::pid_to_str): Change return type.
1029         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1030         type.
1031         (bsd_kvm_target::pid_to_str): Change return type.
1032         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1033         return type.
1034         (aix_thread_target::pid_to_str): Change return type.
1035         * target.h (struct target_ops) <pid_to_str>: Change return type.
1036         (target_pid_to_str, normal_pid_to_str): Likewise.
1037         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1038         type.
1039         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1040         type.
1041         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1042         return type.
1043         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1044         type.
1045         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1046         type.
1047         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1048         return type.
1049
1050 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1051
1052         * NEWS: Mention that the new default MI version is 3.  Mention
1053         changes to the output of commands and events that deal with
1054         multi-location breakpoints.
1055         * breakpoint.c: Include "mi/mi-out.h".
1056         (print_one_breakpoint): Change output syntax if using MI version
1057         >= 3.
1058         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1059         New.
1060         (mi_multi_location_breakpoint_output_fixed): New.
1061         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1062         (mi_cmd_fix_multi_location_breakpoint_output): New.
1063         (mi_multi_location_breakpoint_output_fixed): New.
1064         * mi/mi-cmds.c (mi_cmds): Register command
1065         -fix-multi-location-breakpoint-output.
1066         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1067         interpreter "mi".
1068
1069 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1070
1071         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1072         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1073         instantiate mi_ui_out based on interpreter name.
1074         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1075         * mi/mi-main.c (mi_load_progress): Likewise.
1076
1077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1078
1079         * NEWS: Combine separate "New targets" sections for 8.3.
1080
1081 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1082
1083         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1084         (ppcfbsd_init_abi): Install gdbarch
1085         "fetch_tls_load_module_address" and "get_thread_local_address"
1086         methods.
1087
1088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1089
1090         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1091         (riscv_fbsd_init_abi): Install gdbarch
1092         "fetch_tls_load_module_address" and "get_thread_local_address"
1093         methods.
1094
1095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1096
1097         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1098         (i386fbsd_init_abi): Install gdbarch
1099         "fetch_tls_load_module_address" and "get_thread_local_address"
1100         methods.
1101
1102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1103
1104         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1105         (amd64fbsd_init_abi): Install gdbarch
1106         "fetch_tls_load_module_address" and "get_thread_local_address"
1107         methods.
1108
1109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1110
1111         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1112         (struct fbsd_pspace_data): New type.
1113         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1114         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1115         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1116         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1117         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1118
1119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1120
1121         * gdbtypes.c (lookup_struct_elt): New function.
1122         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1123         * gdbtypes.h (struct struct_elt): New type.
1124         (lookup_struct_elt): New prototype.
1125
1126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1127
1128         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1129         remove disabled code block.
1130
1131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1132
1133         * gdbarch.sh (get_thread_local_address): New method.
1134         * gdbarch.h, gdbarch.c: Regenerate.
1135         * target.c (target_translate_tls_address): Use
1136         gdbarch_get_thread_local_address if present instead of
1137         target::get_thread_local_address.
1138
1139 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1140
1141         * target.h (target::get_thread_local_address): Update comment.
1142
1143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1144
1145         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1146         objfile->separate_debug_objfile_backlink if not NULL.
1147
1148 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1149
1150         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1151         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1152         (amd64bsd_store_inferior_registers): Likewise.
1153         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1154         Enable segment base registers.
1155         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1156         PT_GETFSBASE and PT_GETGSBASE.
1157         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1158         PT_SETGSBASE.
1159         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1160         segment base registers.
1161         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1162
1163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1164
1165         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1166         Update calls to i386_target_description to add 'segments'
1167         parameter.
1168         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1169         add segment base registers.
1170         * arch/i386.c (i386_create_target_description): Add 'segments'
1171         parameter to enable segment base registers.
1172         * arch/i386.h (i386_create_target_description): Likewise.
1173         * features/i386/32bit-segments.xml: New file.
1174         * features/i386/32bit-segments.c: Generate.
1175         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1176         call to i386_target_description to add 'segments' parameter.
1177         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1178         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1179         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1180         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1181         if feature is present.
1182         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1183         Add 'segments' parameter to call to i386_target_description.
1184         (i386_target_description): Add 'segments' parameter to enable
1185         segment base registers.
1186         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1187         to call to i386_target_description.
1188         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1189         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1190         Define I386_NUM_REGS.
1191         (i386_target_description): Add 'segments' parameter to enable
1192         segment base registers.
1193
1194 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1195
1196         PR/24325
1197         * source-cache.c: #undef open and close, to avoid unresolved
1198         externals during linking.
1199
1200 2019-03-12  Tom Tromey  <tromey@adacore.com>
1201
1202         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1203         const.  Add initializers.
1204         (_initialize_remote): Don't initialize ptid globals.
1205
1206 2019-03-12  Pedro Alves  <palves@redhat.com>
1207
1208         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1209
1210 2019-03-12  Pedro Alves  <palves@redhat.com>
1211
1212         * cp-name-parser.y (main): Remove unused 'len' variable.
1213
1214 2019-03-12  Tom Tromey  <tromey@adacore.com>
1215
1216         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1217         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1218
1219 2019-03-12  Tom Tromey  <tromey@adacore.com>
1220
1221         * linux-nat.c (iterate_over_lwps): Update.
1222         (stop_callback): Remove parameter.
1223         (stop_wait_callback, detach_callback, resume_set_callback)
1224         (select_singlestep_lwp_callback, set_ignore_sigint)
1225         (status_callback, resumed_callback, resume_clear_callback)
1226         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1227         data parameter.
1228         (linux_nat_target::detach, linux_nat_target::resume)
1229         (linux_stop_and_wait_all_lwps, select_event_lwp)
1230         (linux_nat_filter_event, linux_nat_wait_1)
1231         (linux_nat_target::kill, linux_nat_target::stop)
1232         (linux_nat_target::stop): Update.
1233         (linux_nat_resume_callback): Change type.
1234         (resume_stopped_resumed_lwps, count_events_callback)
1235         (select_event_lwp_callback): Likewise.
1236         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1237         * arm-linux-nat.c (struct update_registers_data): Remove.
1238         (update_registers_callback): Change type.
1239         (arm_linux_insert_hw_breakpoint1): Update.
1240         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1241         parameter.
1242         (x86_linux_dr_set_addr): Update.
1243         (x86_linux_dr_set_control): Update.
1244         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1245         (iterate_over_lwps): Use gdb::function_view.
1246         * nat/aarch64-linux-hw-point.c (struct
1247         aarch64_dr_update_callback_param): Remove.
1248         (debug_reg_change_callback): Change type.
1249         (aarch64_notify_debug_reg_change): Update.
1250         * s390-linux-nat.c (s390_refresh_per_info): Update.
1251
1252 2019-03-11  Tom Tromey  <tromey@adacore.com>
1253
1254         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1255         redundant assignment to "this_cu".
1256
1257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1258
1259         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1260
1261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1262
1263         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1264         from...
1265         (rank_one_type): ... this.
1266
1267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1268
1269         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1270         from...
1271         (rank_one_type): ... this.
1272
1273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1274
1275         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1276         from...
1277         (rank_one_type): ... this.
1278
1279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1280
1281         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1282         from...
1283         (rank_one_type): ... this.
1284
1285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1286
1287         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1288         from...
1289         (rank_one_type): ... this.
1290
1291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1292
1293         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1294         from...
1295         (rank_one_type): ... this.
1296
1297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1298
1299         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1300         from...
1301         (rank_one_type): ... this.
1302
1303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1304
1305         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1306         from...
1307         (rank_one_type): ... this.
1308
1309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1310
1311         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1312         from...
1313         (rank_one_type): ... this.
1314
1315 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1316
1317         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1318         from...
1319         (rank_one_type): ... this.
1320
1321 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1322
1323         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1324         from...
1325         (rank_one_type): ... this.
1326
1327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1328
1329         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1330         from...
1331         (rank_one_type): ... this.
1332
1333 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1334
1335         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1336         inferior-events' shows the example events.
1337
1338 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1339
1340         Support styling on native MS-Windows console
1341
1342         PR/24315
1343         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1344         on MS-Windows if $TERM is not defined.
1345
1346         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1347
1348         * posix-hdep.c (gdb_console_fputs):
1349         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1350         functions.
1351         * ui-file.h (gdb_console_fputs): Add prototype.
1352
1353         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1354         back to fputs only if the former returns zero.
1355
1356 2019-03-07  Tom Tromey  <tom@tromey.com>
1357
1358         * symmisc.c (print_symbol_bcache_statistics): Update.
1359         (print_objfile_statistics): Update.
1360         * symfile.c (allocate_symtab): Update.
1361         * stabsread.c: Don't include bcache.h.
1362         * psymtab.h (struct psymbol_bcache): Don't declare.
1363         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1364         (psymbol_bcache_init, psymbol_bcache_free)
1365         (psymbol_bcache_get_bcache): Don't declare.
1366         * psymtab.c (struct psymbol_bcache): Remove.
1367         (psymtab_storage::psymtab_storage): Update.
1368         (psymtab_storage::~psymtab_storage): Update.
1369         (psymbol_bcache_init, psymbol_bcache_free)
1370         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1371         (add_psymbol_to_bcache): Update.
1372         (allocate_psymtab): Update.
1373         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1374         macro_cache>: No longer pointers.
1375         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1376         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1377         * macrotab.c (macro_bcache): Update.
1378         * macroexp.c: Don't include bcache.h.
1379         * gdbtypes.c (check_types_worklist): Update.
1380         (types_deeply_equal): Remove TRY/CATCH.  Update.
1381         * elfread.c (elf_symtab_read): Update.
1382         * dwarf2read.c: Don't include bcache.h.
1383         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1384         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1385         (print_bcache_statistics, bcache_memory_used): Don't declare.
1386         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1387         methods.  Rename all data members.
1388         * bcache.c (struct bcache): Move to bcache.h.
1389         (bcache::expand_hash_table): Rename from expand_hash_table.
1390         (bcache): Remove.
1391         (bcache::insert): Rename from bcache_full.
1392         (bcache::compare): Rename from bcache_compare.
1393         (bcache_xmalloc): Remove.
1394         (bcache::~bcache): Rename from bcache_xfree.
1395         (bcache::print_statistics): Rename from print_bcache_statistics.
1396         (bcache::memory_used): Rename from bcache_memory_used.
1397
1398 2019-03-07  Pedro Alves  <palves@redhat.com>
1399
1400         * infrun.c (normal_stop): Also check for
1401         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1402
1403 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1404
1405         * f-lang.c (value_from_host_double): Moved to...
1406         * value.c (value_from_host_double): ...here.
1407         * value.h (value_from_host_double): Declare.
1408         * guile/scm-math.c (vlscm_convert_typed_number): Use
1409         value_from_host_double.
1410         (vlscm_convert_number): Likewise.
1411         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1412         * python/py-value.c (convert_value_from_python): Likewise.
1413
1414 2019-03-06  Tom Tromey  <tom@tromey.com>
1415
1416         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1417
1418 2019-03-06  Tom Tromey  <tom@tromey.com>
1419
1420         * utils.h (free_current_contents): Don't declare.
1421         * utils.c (free_current_contents): Remove.
1422
1423 2019-03-06  Tom Tromey  <tom@tromey.com>
1424
1425         * top.c (quit_force): Update.
1426         * main.c (captured_command_loop): Update.
1427         * common/new-op.c (operator new): Update.
1428         * common/common-exceptions.c (struct catcher)
1429         <save_cleanup_chain>: Remove member.
1430         (exceptions_state_mc_init): Update.
1431         (exception_try_scope_entry): Return nullptr.
1432         (exception_try_scope_exit, exception_rethrow)
1433         (throw_exception_sjlj, throw_exception_cxx): Update.
1434         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1435         (all_cleanups, do_cleanups, discard_cleanups)
1436         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1437         (restore_cleanups, restore_final_cleanups): Don't declare.
1438         (do_final_cleanups): Remove parameter.
1439         * common/cleanups.c (cleanup_chain, make_cleanup)
1440         (make_cleanup_dtor, all_cleanups, do_cleanups)
1441         (discard_my_cleanups, discard_cleanups)
1442         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1443         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1444         (null_cleanup): Remove.
1445         (do_final_cleanups): Remove parameter.
1446
1447 2019-03-06  Tom Tromey  <tom@tromey.com>
1448
1449         * remote.c (remote_target::remote_parse_stop_reply): Use
1450         unique_xmalloc_ptr.
1451
1452 2019-03-06  Tom Tromey  <tom@tromey.com>
1453
1454         * stabsread.c (struct stabs_field_info): Rename from field_info.
1455         <list, fnlist>: Add initializers.
1456         <obstack>: New member.
1457         (read_member_functions, read_struct_fields, read_baseclasses):
1458         Allocate on obstack.  Don't use cleanups.
1459         (read_one_struct_field, read_member_functions, read_struct_fields)
1460         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1461         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1462         (read_struct_type): Update.
1463
1464 2019-03-06  Tom Tromey  <tom@tromey.com>
1465
1466         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1467         * common/filestuff.h (make_cleanup_close): Don't declare.
1468         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1469         Remove.
1470
1471 2019-03-06  Tom Tromey  <tom@tromey.com>
1472
1473         * solib-aix.c: Use make_scope_exit.
1474
1475 2019-03-06  Tom Tromey  <tom@tromey.com>
1476
1477         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1478         Use make_scope_exit.
1479
1480 2019-03-06  Tom Tromey  <tom@tromey.com>
1481
1482         * solib-svr4.c (disable_probes_interface): Remove parameter.
1483         (svr4_handle_solib_event): Use make_scope_exit.
1484
1485 2019-03-06  Tom Tromey  <tom@tromey.com>
1486
1487         * remote.c (struct stop_reply_deleter): Remove.
1488         (stop_reply_up): Update.
1489         (struct stop_reply): Derive from notif_event.  Don't typedef.
1490         <regcache>: Now a std::vector.
1491         (stop_reply_xfree): Remove.
1492         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1493         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1494         (remote_target::discard_pending_stop_replies): Use delete.
1495         (remote_target::remote_parse_stop_reply): Update.
1496         (remote_target::process_stop_reply): Update.
1497         * remote-notif.h (struct notif_event): Add virtual destructor.
1498         Remove "dtr" member.
1499         (struct notif_client) <alloc_event>: Return a unique_ptr.
1500         (notif_event_xfree): Don't declare.
1501         (notif_event_up): New typedef.
1502         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1503         (notif_event_xfree, do_notif_event_xfree): Remove.
1504         (remote_notif_state_xfree): Update.
1505
1506 2019-03-06  Tom Tromey  <tom@tromey.com>
1507
1508         * infrun.c (displaced_step_clear_cleanup): Now a
1509         forward_scope_exit type.
1510         (displaced_step_prepare_throw): Update.
1511         (displaced_step_fixup): Update.
1512
1513 2019-03-06  Tom Tromey  <tom@tromey.com>
1514
1515         * inferior.h (class inferior): Update comment.
1516         * gdbthread.h (class thread_info): Update comment.
1517
1518 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1519             Tom Tromey  <tom@tromey.com>
1520
1521         * stabsread.h (struct stab_section_list): Remove.
1522         (coffstab_build_psymtabs): Update.
1523         * dbxread.c (symbuf_sections): Now a std::vector.
1524         (sect_idx): New global.
1525         (fill_symbuf): Update.
1526         (coffstab_build_psymtabs): Change type of stabsects parameter.
1527         Update.
1528         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1529         std::vector.
1530         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1531         (coff_locate_sections): Update.
1532         (coff_symfile_read): Remove cleanups.  Update.
1533         (init_stringtab): Add storage parameter.
1534         (free_stringtab, free_stringtab_cleanup): Remove.
1535         (init_lineno): Add storage parameter.
1536         (free_linetab, free_linetab_cleanup): Remove.
1537
1538 2019-03-06  Pedro Alves  <palves@redhat.com>
1539
1540         * linux-fork.c (fork_info::clobber_regs): Delete.
1541         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1542         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1543         comment.  Adjust.
1544         (scoped_switch_fork_info::scoped_switch_fork_info)
1545         (checkpoint_command, linux_fork_context): Adjust
1546         fork_save_infrun_state calls.
1547
1548 2019-03-06  Pedro Alves  <palves@redhat.com>
1549
1550         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1551         (inf_has_multiple_threads): Return 'bool' and rewrite using
1552         inferior_info::threads().
1553
1554 2019-03-06  Pedro Alves  <palves@redhat.com>
1555
1556         * linux-fork.c: Include <list>.
1557         (fork_list): Now a std::list instance.
1558         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1559         (forks_exist_p, find_last_fork): Adjust.
1560         (new_fork): Delete.
1561         (one_fork_p): New.
1562         (add_fork): Adjust.
1563         (free_fork): Delete, folded into fork_info::~fork_info().
1564         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1565         Adjust.
1566         (init_fork_list): Delete.
1567         (linux_fork_killall, linux_fork_mourn_inferior)
1568         (linux_fork_detach, info_checkpoints_command): Adjust.
1569         (_initialize_linux_fork): No longer call init_fork_list.
1570
1571 2019-03-06  Pedro Alves  <palves@redhat.com>
1572
1573         * linux-fork.c (new_fork): New, split out of ...
1574         (add_fork): ... this.  Return void.  Move "first fork" special
1575         case from here, to ...
1576         (checkpoint_command): ... here.
1577         * linux-linux.h (add_fork): Return void.
1578
1579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1582
1583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1584             Chris January  <chris.january@arm.com>
1585             David Lecomber  <david.lecomber@arm.com>
1586
1587         * f-exp.y: New token, UNOP_INTRINSIC.
1588         (exp): New pattern using UNOP_INTRINSIC token.
1589         (f77_keywords): Add 'abs' keyword.
1590         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1591         (value_from_host_double): New function.
1592         (evaluate_subexp_f): Support UNOP_ABS.
1593
1594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1595
1596         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1597         types.
1598
1599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1602         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1603         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1604
1605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1608
1609 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1610             Chris January  <chris.january@arm.com>
1611
1612         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1613         * f-exp.y: Define 'KIND' token.
1614         (exp): New pattern for KIND expressions.
1615         (ptype): Handle types with a kind extension.
1616         (direct_abs_decl): Extend to spot kind extensions.
1617         (f77_keywords): Add 'kind' to the list.
1618         (push_kind_type): New function.
1619         (convert_to_kind_type): New function.
1620         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1621         * parse.c (operator_length_standard): Likewise.
1622         * parser-defs.h (enum type_pieces): Add tp_kind.
1623         * std-operator.def: Add UNOP_KIND.
1624
1625 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * f-exp.y (f_parse): Set yydebug.
1628
1629 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1630
1631         * f-lang.c (evaluate_subexp_f): New function.
1632         (exp_descriptor_f): New global.
1633         (f_language_defn): Use exp_descriptor_f instead of
1634         exp_descriptor_standard.
1635
1636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * f-exp.y (struct token): Add comments.
1639         (dot_ops): Remove uppercase versions and the end marker.
1640         (f77_keywords): Likewise.
1641         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1642         entries in the dot_ops array are case insensitive, and use
1643         strncasecmp to compare strings.  Also some whitespace cleanup in
1644         this area.  Similar for the f77_keywords array, except entries in
1645         this list might be case sensitive.
1646
1647 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * f-exp.y (struct f77_boolean_val): Add comments.
1650         (boolean_values): Remove uppercase versions, and end marker.
1651         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1652         and use strncasecmp to achieve case insensitivity.  Additionally,
1653         perform whitespace cleanup around this code.
1654
1655 2019-03-06  Tom Tromey  <tromey@adacore.com>
1656
1657         * remote-sim.c (gdbsim_target_open): Use result of
1658         gdb_argv::release.
1659
1660 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1661         Dirk Schubert  <dirk.schubert@arm.com>
1662         Chris January  <chris.january@arm.com>
1663
1664         * eval.c (evaluate_subexp_standard): Call Fortran argument
1665         wrapping logic.
1666         * f-lang.c (struct value): A value which can be passed into a
1667         Fortran function call.
1668         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1669         where appropriate.
1670         (struct type): Value ready for a Fortran function call.
1671         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1672         is needed.
1673         * f-lang.h (fortran_argument_convert): Declaration.
1674         (fortran_preserve_arg_pointer): Declaration.
1675         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1676
1677 2019-03-05  Tom Tromey  <tromey@adacore.com>
1678
1679         * python/py-prettyprint.c (print_string_repr): Remove #if.
1680         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1681
1682 2019-03-05  Tom Tromey  <tromey@adacore.com>
1683
1684         * target.c (the_dummy_target): Move later.  Change type to
1685         "dummy_target".
1686         (initialize_targets): Don't initialize the_dummy_target.
1687
1688 2019-03-05  Tom Tromey  <tromey@adacore.com>
1689
1690         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1691         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1692
1693 2019-03-05  Tom Tromey  <tromey@adacore.com>
1694
1695         * windows-nat.c (windows_nat_target::attach)
1696         (windows_nat_target::detach): Don't call gdb_flush.
1697         * valprint.c (generic_val_print, val_print, val_print_string):
1698         Don't call gdb_flush.
1699         * utils.c (defaulted_query): Don't call gdb_flush.
1700         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1701         * target.c (target_announce_detach): Don't call gdb_flush.
1702         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1703         * remote.c (extended_remote_target::attach): Don't call
1704         gdb_flush.
1705         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1706         * printcmd.c (do_examine): Don't call gdb_flush.
1707         (info_display_command): Don't call gdb_flush.
1708         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1709         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1710         * memattr.c (info_mem_command): Don't call gdb_flush.
1711         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1712         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1713         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1714         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1715         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1716         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1717         (gnu_nat_target::detach): Don't call gdb_flush.
1718         * f-valprint.c (f_val_print): Don't call gdb_flush.
1719         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1720         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1721         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1722         gdb_flush.
1723         * c-valprint.c (c_val_print): Don't call gdb_flush.
1724         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1725
1726 2019-03-05  Tom Tromey  <tromey@adacore.com>
1727
1728         * varobj.c (update_dynamic_varobj_children): Update.
1729         (install_default_visualizer): Use reset, not release.
1730         * value.c (set_internalvar): Update.
1731         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1732         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1733         ATTRIBUTE_UNUSED_RESULT.
1734
1735 2019-03-05  Tom Tromey  <tromey@adacore.com>
1736
1737         * remote.c (class scoped_remote_fd) <release>: Add
1738         ATTRIBUTE_UNUSED_RESULT.
1739
1740 2019-03-05  Tom Tromey  <tromey@adacore.com>
1741
1742         * macroexp.c (struct macro_buffer) <release>: Add
1743         ATTRIBUTE_UNUSED_RESULT.
1744
1745 2019-03-05  Tom Tromey  <tromey@adacore.com>
1746
1747         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1748         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1749         ATTRIBUTE_UNUSED_RESULT.
1750
1751 2019-03-05  Tom Tromey  <tromey@adacore.com>
1752
1753         * common/scoped_fd.h (class scoped_fd) <release>: Add
1754         ATTRIBUTE_UNUSED_RESULT.
1755
1756 2019-03-05  Tom Tromey  <tromey@adacore.com>
1757
1758         * parser-defs.h (struct parser_state) <release>: Add
1759         ATTRIBUTE_UNUSED_RESULT.
1760
1761 2019-03-05  Tom Tromey  <tromey@adacore.com>
1762
1763         * utils.h (class gdb_argv) <release>: Add
1764         ATTRIBUTE_UNUSED_RESULT.
1765         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1766
1767 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1768
1769         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1770         for-loop range, to avoid compiler warnings.
1771
1772         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1773         avoid compiler warnings about unused variables.
1774
1775         * NEWS: Mention end of support for native debugging on MS-Windows
1776         before XP.
1777
1778         PR gdb/24292
1779         * common/netstuff.c:
1780         * gdbserver/gdbreplay.c
1781         * gdbserver/remote-utils.c:
1782         * ser-tcp.c:
1783         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1784         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1785         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1786         'getaddrinfo' and 'freeaddrinfo' were not available before
1787         Windows XP, and mingw.org's MinGW headers by default define
1788         _WIN32_WINNT to 0x500.
1789
1790 2019-03-01  Gary Benson <gbenson@redhat.com>
1791
1792         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1793
1794 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1795             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1796
1797         PR gdb/8527
1798         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1799         set_sigint_trap, clear_sigint_trap.
1800
1801 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1802
1803         * target.c (target_detach): Clear the regcache and the
1804         frame cache.
1805
1806 2019-02-27  Pedro Alves  <palves@redhat.com>
1807
1808         * utils.c (set_screen_size): When we cap the height/width sizes,
1809         tweak the corresponding command variable to show "unlimited":
1810
1811 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1812             Pedro Alves  <palves@redhat.com>
1813
1814         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1815         before calling rl_set_screen_size.
1816
1817 2019-02-27  Tom Tromey  <tromey@adacore.com>
1818
1819         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1820         define.
1821         * python/py-value.c: Remove Python 2.4 workaround.
1822         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1823         workaround.
1824         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1825         Python 2.4 workaround.
1826         * python/python-internal.h: Remove Python 2.4 comment.
1827         (Py_ssize_t): Don't define.
1828         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1829         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1830         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1831         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1832         * python/python.c (do_start_initialization): Remove Python 2.4
1833         workaround.
1834         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1835         (print_children): Remove Python 2.4 workaround.
1836         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1837         workaround.
1838         (CHARBUFFERPROC_NAME): Remove.
1839         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1840         Python 2.4 workaround.
1841
1842 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1843
1844         * NEWS: Note minimum Python version.
1845
1846 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1847
1848         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1849         code from these functions.  Remove corresponding ifdefs.  Use
1850         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1851         Remove gotos and target of gotos.
1852         (infpy_search_memory): Likewise.
1853
1854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1857         (hppa_gdbarch_init): Don't register deleted functions with
1858         gdbarch.
1859
1860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1863         (h8300_unwind_sp): Delete.
1864         (h8300_dummy_id): Delete.
1865         (h8300_gdbarch_init): Don't register deleted functions with
1866         gdbarch.
1867
1868 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1871         (ft32_unwind_pc): Delete.
1872         (ft32_unwind_sp): Delete.
1873         (ft32_gdbarch_init): Don't register deleted functions with
1874         gdbarch.
1875
1876 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1879         (frv_unwind_pc): Delete.
1880         (frv_unwind_sp): Delete.
1881         (frv_gdbarch_init): Don't register deleted functions with
1882         gdbarch.
1883
1884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1887         (riscv_unwind_pc): Delete.
1888         (riscv_unwind_sp): Delete.
1889         (riscv_gdbarch_init): Don't register deleted functions with
1890         gdbarch.
1891
1892 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1893
1894         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1895         (csky_unwind_pc): Delete.
1896         (csky_unwind_sp): Delete.
1897         (csky_gdbarch_init): Don't register deleted functions with
1898         gdbarch.
1899
1900 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1903         (cris_unwind_pc): Delete.
1904         (cris_unwind_sp): Delete.
1905         (cris_gdbarch_init): Don't register deleted functions with
1906         gdbarch.
1907
1908 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1909
1910         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1911         (bfin_unwind_pc): Delete.
1912         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1913
1914 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1917         (arm_unwind_pc): Delete.
1918         (arm_unwind_sp): Delete.
1919         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1920
1921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1924         (arc_unwind_pc): Delete.
1925         (arc_unwind_sp): Delete.
1926         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1927
1928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1931         (alpha_unwind_pc): Delete.
1932         (alpha_gdbarch_init): Don't register deleted functions with
1933         gdbarch.
1934
1935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1936
1937         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1938         (aarch64_unwind_pc): Delete.
1939         (aarch64_unwind_sp): Delete.
1940         (aarch64_gdbarch_init): Don't register deleted functions with
1941         gdbarch.
1942
1943 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * gdbtypes.c (type_align): Don't consider static members when
1946         computing structure alignment.
1947
1948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1949
1950         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1951         return 0 for other types.
1952         * arch-utils.c (default_type_align): Always return 0.
1953         * gdbarch.h: Regenerate.
1954         * gdbarch.sh (type_align): Extend comment.
1955         * gdbtypes.c (type_align): Add additional comments, always call
1956         gdbarch_type_align before applying the default rules.
1957         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1958         generic code will then apply a suitable default.
1959         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1960         types, return 0 for other types.
1961
1962 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1963
1964         * NEWS: Create a new section for the next release branch.
1965         Rename the section of the current branch, now that it has
1966         been cut.
1967
1968 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1969
1970         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1971         * version.in: Bump version to 8.3.50.DATE-git.
1972
1973 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1974
1975         * aix-thread.c (ptid_cmp): Remove unused variable.
1976         (get_signaled_thread): Likewise.
1977         (store_regs_user_thread): Likewise.
1978         (store_regs_kernel_thread): Likewise.
1979         (fetch_regs_kernel_thread): Remove shadowed variable.
1980
1981 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1982
1983         * features/riscv/32bit-cpu.xml: Add register numbers.
1984         * features/riscv/32bit-fpu.c: Regenerate.
1985         * features/riscv/32bit-fpu.xml: Add register numbers.
1986         * features/riscv/64bit-cpu.xml: Add register numbers.
1987         * features/riscv/64bit-fpu.c: Regenerate.
1988         * features/riscv/64bit-fpu.xml: Add register numbers.
1989
1990 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1991
1992         * NEWS: Mention two argument form of gdb.Value constructor.
1993         * python/py-value.c (convert_buffer_and_type_to_value): New
1994         function.
1995         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1996         Add support for handling an optional second argument.  Call
1997         convert_buffer_and_type_to_value as appropriate.
1998         * python/python-internal.h (Py_buffer_deleter): New struct.
1999         (Py_buffer_up): New typedef.
2000
2001 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2002
2003         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2004         instead of releasing ownership.
2005
2006 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2007
2008         * dwarf2read.c (open_and_init_dwp_file): Call
2009         elf_numsections instead of bfd_count_sections to initialize
2010         dwp_file->num_sections.
2011
2012 2019-02-25  Tom Tromey  <tromey@adacore.com>
2013
2014         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2015
2016 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2017
2018         * gcore.in: Add '--readnever' option when invoking GDB.
2019
2020 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2021
2022         * MAINTAINERS: Update my email address.
2023
2024 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2025
2026         * build-id.c (build_id_to_debug_bfd_1): New function.
2027         (build_id_to_debug_bfd): Look for separate debug file in
2028         sysroot.
2029
2030 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2031
2032         * gdbarch.sh: Update the copyright year range that is placed into
2033         generated files.
2034
2035 2019-02-22  Keith Seitz  <keiths@redhat.com>
2036
2037         PR symtab/23853
2038         * linespec.c (create_sals_line_offset): Search for the default
2039         symtab's filename instead of its fullname.
2040
2041 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2042
2043         * NEWS: Update style defaults.
2044
2045 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2046
2047         * main.c (captured_main_1): Disable styling in batch mode.
2048
2049 2019-02-20  Tom Tromey  <tom@tromey.com>
2050
2051         * symtab.c (symtab_symbol_info): Fix typos.
2052
2053 2019-02-20  Tom Tromey  <tromey@adacore.com>
2054
2055         * findcmd.c (_initialize_mem_search): Use upper case for
2056         metasyntactic variables.
2057
2058 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2059
2060         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2061         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2062
2063 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2064
2065         * top.h (source_file_name): Change to std::string.
2066         * top.c (source_file_name): Likewise.
2067         (command_line_input): Adjust.
2068         * cli/cli-script.c (script_from_file): Adjust.
2069
2070 2019-02-19  Tom Tromey  <tromey@adacore.com>
2071
2072         * ravenscar-thread.c
2073         (ravenscar_thread_target::update_thread_list): Don't call
2074         ada_build_task_list.
2075         * ada-lang.h (ada_build_task_list): Don't declare.
2076         * ada-tasks.c (struct ada_tasks_inferior_data)
2077         <task_list_valid_p>: Now bool.
2078         (read_known_tasks, ada_task_list_changed)
2079         (ada_tasks_invalidate_inferior_data): Update.
2080         (read_known_tasks_array): Return bool.
2081         (read_known_tasks_list): Likewise.
2082         (read_known_tasks): Return void.
2083         (ada_build_task_list): Now static.
2084
2085 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2088         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2089
2090 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2091
2092         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2093         variant for ada_tasks_pspace_data_handle and
2094         ada_tasks_inferior_data_handle.
2095         (ada_tasks_pspace_data_cleanup): New function.
2096         (ada_tasks_inferior_data_cleanup): New function.
2097
2098 2019-02-17  Tom Tromey  <tom@tromey.com>
2099
2100         * macrotab.h (macro_source_fullname): Return a std::string.
2101         * macrotab.c (macro_include, check_for_redefinition)
2102         (macro_undef, macro_lookup_definition, foreach_macro)
2103         (foreach_macro_in_scope): Update.
2104         (macro_source_fullname): Return a std::string.
2105         * macrocmd.c (show_pp_source_pos): Update.
2106
2107 2019-02-17  Tom Tromey  <tom@tromey.com>
2108
2109         * macrocmd.c (show_pp_source_pos): Style the file names.
2110
2111 2019-02-17  Tom Tromey  <tom@tromey.com>
2112
2113         PR tui/24197:
2114         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2115
2116 2019-02-17  Tom Tromey  <tom@tromey.com>
2117
2118         * ada-lang.c (user_select_syms): Use filtered printing.
2119         * utils.c (wrap_style): New global.
2120         (desired_style): Remove.
2121         (emit_style_escape): Add stream parameter.
2122         (set_output_style, reset_terminal_style, prompt_for_continue):
2123         Update.
2124         (flush_wrap_buffer): Only flush gdb_stdout.
2125         (wrap_here): Set wrap_style.
2126         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2127         treat escape sequences as a character.  Change when wrap buffer is
2128         flushed.
2129         (fputs_styled): Do not set the output style when the default is
2130         requested.
2131         * ui-style.h (struct ui_file_style) <is_default>: New method.
2132         * source.c (print_source_lines_base): Emit escape sequences in one
2133         piece.
2134
2135 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2136
2137         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2138         integers and enumeration types.
2139
2140 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2141
2142         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2143         instead of lookup_symbol_in_language
2144         (do_exact_match): New function.
2145         (ada_get_symbol_name_matcher): Return do_exact_match when
2146         doing a verbatim match.
2147
2148 2019-02-15  Tom Tromey  <tromey@adacore.com>
2149
2150         * ravenscar-thread.c (ravenscar_thread_target::resume)
2151         (ravenscar_thread_target::wait): Special case wildcard requests.
2152
2153 2019-02-15  Tom Tromey  <tromey@adacore.com>
2154
2155         * ravenscar-thread.c (base_ptid): Remove.
2156         (struct ravenscar_thread_target) <close>: New method.
2157         <m_base_ptid>: New member.
2158         <update_inferior_ptid, active_task, task_is_currently_active,
2159         runtime_initialized>: Declare methods.
2160         <ravenscar_thread_target>: Add constructor.
2161         (ravenscar_thread_target::task_is_currently_active)
2162         (ravenscar_thread_target::update_inferior_ptid)
2163         (ravenscar_runtime_initialized): Rename.  Now methods.
2164         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2165         (ravenscar_thread_target::update_thread_list): Update.
2166         (ravenscar_thread_target::active_task): Now method.
2167         (ravenscar_thread_target::store_registers)
2168         (ravenscar_thread_target::prepare_to_store)
2169         (ravenscar_thread_target::prepare_to_store)
2170         (ravenscar_thread_target::mourn_inferior): Update.
2171         (ravenscar_inferior_created): Use "new" to create target.
2172         (ravenscar_thread_target::get_ada_task_ptid): Update.
2173         (_initialize_ravenscar): Don't initialize base_ptid.
2174         (ravenscar_ops): Remove global.
2175
2176 2019-02-15  Tom Tromey  <tromey@adacore.com>
2177
2178         * target.h (push_target): Declare new overload.
2179         * target.c (push_target): New overload, taking an rvalue reference.
2180         * remote.c (remote_target::open_1): Use push_target overload.
2181         * corelow.c (core_target_open): Use push_target overload.
2182
2183 2019-02-15  Tom Tromey  <tromey@adacore.com>
2184
2185         * ravenscar-thread.c (is_ravenscar_task)
2186         (ravenscar_task_is_currently_active): Return bool.
2187         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2188         (_initialize_ravenscar): Remove "(void)".
2189         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2190         Return bool.
2191
2192 2019-02-15  Tom Tromey  <tromey@adacore.com>
2193
2194         * ravenscar-thread.c (ravenscar_runtime_initializer)
2195         (has_ravenscar_runtime, get_running_thread_id)
2196         (ravenscar_thread_target::resume): Fix indentation.
2197
2198 2019-02-15  Tom Tromey  <tromey@adacore.com>
2199
2200         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2201         from ravenscar_arch_ops.
2202         (sparc_ravenscar_ops::fetch_registers)
2203         (sparc_ravenscar_ops::store_registers): Now methods.
2204         (sparc_ravenscar_prepare_to_store): Remove.
2205         (sparc_ravenscar_ops): Redefine.
2206         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2207         methods and destructor.  Remove members.
2208         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2209         (ravenscar_thread_target::store_registers)
2210         (ravenscar_thread_target::prepare_to_store): Update.
2211         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2212         Remove.
2213         (struct ppc_ravenscar_powerpc_ops): Derive from
2214         ravenscar_arch_ops.
2215         (ppc_ravenscar_powerpc_ops::fetch_registers)
2216         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2217         (ppc_ravenscar_powerpc_ops): Redefine.
2218         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2219         (ppc_ravenscar_e500_ops::fetch_registers)
2220         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2221         (ppc_ravenscar_e500_ops): Redefine.
2222         * aarch64-ravenscar-thread.c
2223         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2224         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2225         (aarch64_ravenscar_fetch_registers)
2226         (aarch64_ravenscar_store_registers): Now methods.
2227         (aarch64_ravenscar_ops): Redefine.
2228
2229 2019-02-15  Tom Tromey  <tromey@adacore.com>
2230
2231         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2232         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2233         (ravenscar_thread_target::stopped_by_watchpoint)
2234         (ravenscar_thread_target::stopped_data_address)
2235         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2236
2237 2019-02-15  Tom Tromey  <tromey@adacore.com>
2238
2239         * ravenscar-thread.c: Fix some typos.
2240
2241 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2242             Tom Tromey  <tromey@adacore.com>
2243
2244         * ada-lang.c (ada_exception_sal): Change addr_string to a
2245         std::string.
2246         (create_ada_exception_catchpoint): Update.
2247
2248 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2249             Tom Tromey  <tromey@adacore.com>
2250
2251         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2252         (bp_location_ops): Remove.
2253         (base_breakpoint_allocate_location): Update.
2254         (free_bp_location): Update.
2255         * ada-lang.c (class ada_catchpoint_location)
2256         <ada_catchpoint_location>: Remove ops parameter.
2257         (ada_catchpoint_location_dtor): Remove.
2258         (ada_catchpoint_location_ops): Remove.
2259         (allocate_location_exception): Update.
2260         * breakpoint.h (struct bp_location_ops): Remove.
2261         (class bp_location) <bp_location>: Remove bp_location_ops
2262         parameter.
2263         <~bp_location>: Add destructor.
2264         <ops>: Remove.
2265
2266 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2267             Pedro Alves  <palves@redhat.com>
2268
2269         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2270         'PATH_MAX'.
2271
2272 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2273             Samuel Thibault  <samuel.thibault@gnu.org>
2274             Thomas Schwinge  <thomas@codesourcery.com>
2275
2276         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2277         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2278
2279 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2280
2281         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2282         (check_empty): Use "const char *".
2283
2284         * gnu-nat.c (gnu_nat_target::detach): Instead of
2285         'detach_inferior (pid)' call
2286         'detach_inferior (find_inferior_pid (pid))'.
2287
2288         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2289         'nat/fork-inferior.o'.
2290         * gnu-nat.c: #include "nat/fork-inferior.h".
2291
2292         * gnu-nat.c (gnu_nat_target::detach): Instead of
2293         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2294         * gnu-nat.h: #include "inf-child.h".
2295         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2296         'i386_gnu_nat_target::fetch_registers'.
2297         (gnu_store_registers): Rename/move to
2298         'i386_gnu_nat_target::store_registers'.
2299
2300         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2301         * gnu-nat.h (mach_thread_info): New function.
2302         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2303
2304         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2305
2306 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2307
2308         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2309
2310 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2311
2312         * windows-nat.c (windows_add_thread): Add new parameter
2313         "main_thread_p" with default value set to false.  Update
2314         function documentation as well as all callers.
2315         (windows_delete_thread): Likewise.
2316         (fake_create_process): Update call to windows_add_thread.
2317         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2318         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2319         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2320         call to windows_delete_thread.
2321
2322 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2323
2324         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2325
2326 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2327
2328         * symfile.c (find_separate_debug_file): Use canonical path of
2329         sysroot with child_path instead of gdb_sysroot if it is valid.
2330
2331 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2332
2333         * symfile.c (find_separate_debug_file): Use child_path to
2334         determine if an object file is under a sysroot.
2335
2336 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2337
2338         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2339         unittests/child-path-selftests.c.
2340         * common/pathstuff.c (child_path): New function.
2341         * common/pathstuff.h (child_path): New prototype.
2342         * unittests/child-path-selftests.c: New file.
2343
2344 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2345
2346         * symfile.c (find_separate_debug_file): Look for separate debug
2347         files in debug directories under the sysroot.
2348
2349 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2350
2351         * symtab.h (struct minimal_symbol data_p): New const method.
2352         (struct minimal_symbol text_p): Likewise.
2353         * symtab.c (output_source_filename): Use file name style
2354         to print file name.
2355         (print_symbol_info): Likewise.
2356         (print_msymbol_info): Use address style to print addresses.
2357         Use function name style to print executable text symbols.
2358         (expand_symtab_containing_pc): Use data_p.
2359         (find_pc_sect_compunit_symtab): Likewise.
2360
2361 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * breakpoint.c (describe_other_breakpoints): Use address style
2364         to print addresses.
2365         (say_where): Likewise.
2366
2367 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2368
2369         * ada-typeprint.c (print_func_type): Print function name
2370         style to print function name.
2371         * c-typeprint.c (c_print_type_1): Likewise.
2372
2373 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2374
2375         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2376         for execve.
2377
2378 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2379
2380         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2381         type_stack.
2382
2383 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2384
2385         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2386         TYPE_CODE_REF types.
2387
2388 2019-02-08  Jim Wilson  <jimw@sifive.com>
2389
2390         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2391         (riscv_linux_fregset): New.
2392         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2393
2394 2019-02-07  Tom Tromey  <tom@tromey.com>
2395
2396         * thread.c (thread_cancel_execution_command): Update.
2397         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2398         methods.
2399         (struct thread_fsm_ops): Remove.
2400         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2401         (thread_fsm_should_stop, thread_fsm_return_value)
2402         (thread_fsm_set_finished, thread_fsm_finished_p)
2403         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2404         Don't declare.
2405         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2406         * infrun.c (clear_proceed_status_thread)
2407         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2408         (print_stop_event): Update.
2409         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2410         Add constructor.
2411         (step_command_fsm_ops): Remove.
2412         (new_step_command_fsm): Remove.
2413         (step_1): Update.
2414         (step_command_fsm::should_stop): Rename from
2415         step_command_fsm_should_stop.
2416         (step_command_fsm::clean_up): Rename from
2417         step_command_fsm_clean_up.
2418         (step_command_fsm::do_async_reply_reason): Rename from
2419         step_command_fsm_async_reply_reason.
2420         (struct until_next_fsm): Inherit from thread_fsm.  Add
2421         constructor.
2422         (until_next_fsm_ops): Remove.
2423         (new_until_next_fsm): Remove.
2424         (until_next_fsm::should_stop): Rename from
2425         until_next_fsm_should_stop.
2426         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2427         (until_next_fsm::do_async_reply_reason): Rename from
2428         until_next_fsm_async_reply_reason.
2429         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2430         constructor.  Change type of breakpoint.
2431         (finish_command_fsm_ops): Remove.
2432         (new_finish_command_fsm): Remove.
2433         (finish_command_fsm::should_stop): Rename from
2434         finish_command_fsm_should_stop.
2435         (finish_command_fsm::clean_up): Rename from
2436         finish_command_fsm_clean_up.
2437         (finish_command_fsm::return_value): Rename from
2438         finish_command_fsm_return_value.
2439         (finish_command_fsm::do_async_reply_reason): Rename from
2440         finish_command_fsm_async_reply_reason.
2441         (finish_command): Update.
2442         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2443         Add constructor.
2444         (call_thread_fsm_ops): Remove.
2445         (call_thread_fsm::call_thread_fsm): Rename from
2446         new_call_thread_fsm.
2447         (call_thread_fsm::should_stop): Rename from
2448         call_thread_fsm_should_stop.
2449         (call_thread_fsm::should_notify_stop): Rename from
2450         call_thread_fsm_should_notify_stop.
2451         (run_inferior_call, call_function_by_hand_dummy): Update.
2452         * cli/cli-interp.c (should_print_stop_to_console): Update.
2453         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2454         Add constructor.  Change type of location_breakpoint,
2455         caller_breakpoint.
2456         (until_break_fsm_ops): Remove.
2457         (new_until_break_fsm): Remove.
2458         (until_break_fsm::should_stop): Rename from
2459         until_break_fsm_should_stop.
2460         (until_break_fsm::clean_up): Rename from
2461         until_break_fsm_clean_up.
2462         (until_break_fsm::do_async_reply_reason): Rename from
2463         until_break_fsm_async_reply_reason.
2464         (until_break_command): Update.
2465         * thread-fsm.c: Remove.
2466         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2467
2468 2019-02-07  Tom Tromey  <tom@tromey.com>
2469
2470         * yy-remap.h: Add include guard.
2471         * xtensa-tdep.h: Add include guard.
2472         * xcoffread.h: Rename include guard.
2473         * varobj-iter.h: Add include guard.
2474         * tui/tui.h: Rename include guard.
2475         * tui/tui-winsource.h: Rename include guard.
2476         * tui/tui-wingeneral.h: Rename include guard.
2477         * tui/tui-windata.h: Rename include guard.
2478         * tui/tui-win.h: Rename include guard.
2479         * tui/tui-stack.h: Rename include guard.
2480         * tui/tui-source.h: Rename include guard.
2481         * tui/tui-regs.h: Rename include guard.
2482         * tui/tui-out.h: Rename include guard.
2483         * tui/tui-layout.h: Rename include guard.
2484         * tui/tui-io.h: Rename include guard.
2485         * tui/tui-hooks.h: Rename include guard.
2486         * tui/tui-file.h: Rename include guard.
2487         * tui/tui-disasm.h: Rename include guard.
2488         * tui/tui-data.h: Rename include guard.
2489         * tui/tui-command.h: Rename include guard.
2490         * tic6x-tdep.h: Add include guard.
2491         * target/waitstatus.h: Rename include guard.
2492         * target/wait.h: Rename include guard.
2493         * target/target.h: Rename include guard.
2494         * target/resume.h: Rename include guard.
2495         * target-float.h: Rename include guard.
2496         * stabsread.h: Add include guard.
2497         * rs6000-tdep.h: Add include guard.
2498         * riscv-fbsd-tdep.h: Add include guard.
2499         * regformats/regdef.h: Rename include guard.
2500         * record.h: Rename include guard.
2501         * python/python.h: Rename include guard.
2502         * python/python-internal.h: Rename include guard.
2503         * python/py-stopevent.h: Rename include guard.
2504         * python/py-ref.h: Rename include guard.
2505         * python/py-record.h: Rename include guard.
2506         * python/py-record-full.h: Rename include guard.
2507         * python/py-record-btrace.h: Rename include guard.
2508         * python/py-instruction.h: Rename include guard.
2509         * python/py-events.h: Rename include guard.
2510         * python/py-event.h: Rename include guard.
2511         * procfs.h: Add include guard.
2512         * proc-utils.h: Add include guard.
2513         * p-lang.h: Add include guard.
2514         * or1k-tdep.h: Rename include guard.
2515         * observable.h: Rename include guard.
2516         * nto-tdep.h: Rename include guard.
2517         * nat/x86-linux.h: Rename include guard.
2518         * nat/x86-linux-dregs.h: Rename include guard.
2519         * nat/x86-gcc-cpuid.h: Add include guard.
2520         * nat/x86-dregs.h: Rename include guard.
2521         * nat/x86-cpuid.h: Rename include guard.
2522         * nat/ppc-linux.h: Rename include guard.
2523         * nat/mips-linux-watch.h: Rename include guard.
2524         * nat/linux-waitpid.h: Rename include guard.
2525         * nat/linux-ptrace.h: Rename include guard.
2526         * nat/linux-procfs.h: Rename include guard.
2527         * nat/linux-osdata.h: Rename include guard.
2528         * nat/linux-nat.h: Rename include guard.
2529         * nat/linux-namespaces.h: Rename include guard.
2530         * nat/linux-btrace.h: Rename include guard.
2531         * nat/glibc_thread_db.h: Rename include guard.
2532         * nat/gdb_thread_db.h: Rename include guard.
2533         * nat/gdb_ptrace.h: Rename include guard.
2534         * nat/fork-inferior.h: Rename include guard.
2535         * nat/amd64-linux-siginfo.h: Rename include guard.
2536         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2537         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2538         * nat/aarch64-linux.h: Rename include guard.
2539         * nat/aarch64-linux-hw-point.h: Rename include guard.
2540         * mn10300-tdep.h: Add include guard.
2541         * mips-linux-tdep.h: Add include guard.
2542         * mi/mi-parse.h: Rename include guard.
2543         * mi/mi-out.h: Rename include guard.
2544         * mi/mi-main.h: Rename include guard.
2545         * mi/mi-interp.h: Rename include guard.
2546         * mi/mi-getopt.h: Rename include guard.
2547         * mi/mi-console.h: Rename include guard.
2548         * mi/mi-common.h: Rename include guard.
2549         * mi/mi-cmds.h: Rename include guard.
2550         * mi/mi-cmd-break.h: Rename include guard.
2551         * m2-lang.h: Add include guard.
2552         * location.h: Rename include guard.
2553         * linux-record.h: Rename include guard.
2554         * linux-nat.h: Add include guard.
2555         * linux-fork.h: Add include guard.
2556         * i386-darwin-tdep.h: Rename include guard.
2557         * hppa-linux-offsets.h: Add include guard.
2558         * guile/guile.h: Rename include guard.
2559         * guile/guile-internal.h: Rename include guard.
2560         * gnu-nat.h: Rename include guard.
2561         * gdb-stabs.h: Rename include guard.
2562         * frv-tdep.h: Add include guard.
2563         * f-lang.h: Add include guard.
2564         * event-loop.h: Add include guard.
2565         * darwin-nat.h: Rename include guard.
2566         * cp-abi.h: Rename include guard.
2567         * config/sparc/nm-sol2.h: Rename include guard.
2568         * config/nm-nto.h: Rename include guard.
2569         * config/nm-linux.h: Add include guard.
2570         * config/i386/nm-i386gnu.h: Rename include guard.
2571         * config/djgpp/nl_types.h: Rename include guard.
2572         * config/djgpp/langinfo.h: Rename include guard.
2573         * compile/gcc-cp-plugin.h: Add include guard.
2574         * compile/gcc-c-plugin.h: Add include guard.
2575         * compile/compile.h: Rename include guard.
2576         * compile/compile-object-run.h: Rename include guard.
2577         * compile/compile-object-load.h: Rename include guard.
2578         * compile/compile-internal.h: Rename include guard.
2579         * compile/compile-cplus.h: Rename include guard.
2580         * compile/compile-c.h: Rename include guard.
2581         * common/xml-utils.h: Rename include guard.
2582         * common/x86-xstate.h: Rename include guard.
2583         * common/version.h: Rename include guard.
2584         * common/vec.h: Rename include guard.
2585         * common/tdesc.h: Rename include guard.
2586         * common/selftest.h: Rename include guard.
2587         * common/scoped_restore.h: Rename include guard.
2588         * common/scoped_mmap.h: Rename include guard.
2589         * common/scoped_fd.h: Rename include guard.
2590         * common/safe-iterator.h: Rename include guard.
2591         * common/run-time-clock.h: Rename include guard.
2592         * common/refcounted-object.h: Rename include guard.
2593         * common/queue.h: Rename include guard.
2594         * common/ptid.h: Rename include guard.
2595         * common/print-utils.h: Rename include guard.
2596         * common/preprocessor.h: Rename include guard.
2597         * common/pathstuff.h: Rename include guard.
2598         * common/observable.h: Rename include guard.
2599         * common/netstuff.h: Rename include guard.
2600         * common/job-control.h: Rename include guard.
2601         * common/host-defs.h: Rename include guard.
2602         * common/gdb_wait.h: Rename include guard.
2603         * common/gdb_vecs.h: Rename include guard.
2604         * common/gdb_unlinker.h: Rename include guard.
2605         * common/gdb_unique_ptr.h: Rename include guard.
2606         * common/gdb_tilde_expand.h: Rename include guard.
2607         * common/gdb_sys_time.h: Rename include guard.
2608         * common/gdb_string_view.h: Rename include guard.
2609         * common/gdb_splay_tree.h: Rename include guard.
2610         * common/gdb_setjmp.h: Rename include guard.
2611         * common/gdb_ref_ptr.h: Rename include guard.
2612         * common/gdb_optional.h: Rename include guard.
2613         * common/gdb_locale.h: Rename include guard.
2614         * common/gdb_assert.h: Rename include guard.
2615         * common/filtered-iterator.h: Rename include guard.
2616         * common/filestuff.h: Rename include guard.
2617         * common/fileio.h: Rename include guard.
2618         * common/environ.h: Rename include guard.
2619         * common/common-utils.h: Rename include guard.
2620         * common/common-types.h: Rename include guard.
2621         * common/common-regcache.h: Rename include guard.
2622         * common/common-inferior.h: Rename include guard.
2623         * common/common-gdbthread.h: Rename include guard.
2624         * common/common-exceptions.h: Rename include guard.
2625         * common/common-defs.h: Rename include guard.
2626         * common/common-debug.h: Rename include guard.
2627         * common/cleanups.h: Rename include guard.
2628         * common/buffer.h: Rename include guard.
2629         * common/btrace-common.h: Rename include guard.
2630         * common/break-common.h: Rename include guard.
2631         * cli/cli-utils.h: Rename include guard.
2632         * cli/cli-style.h: Rename include guard.
2633         * cli/cli-setshow.h: Rename include guard.
2634         * cli/cli-script.h: Rename include guard.
2635         * cli/cli-interp.h: Rename include guard.
2636         * cli/cli-decode.h: Rename include guard.
2637         * cli/cli-cmds.h: Rename include guard.
2638         * charset-list.h: Add include guard.
2639         * buildsym-legacy.h: Rename include guard.
2640         * bfin-tdep.h: Add include guard.
2641         * ax.h: Rename include guard.
2642         * arm-linux-tdep.h: Add include guard.
2643         * arm-fbsd-tdep.h: Add include guard.
2644         * arch/xtensa.h: Rename include guard.
2645         * arch/tic6x.h: Add include guard.
2646         * arch/i386.h: Add include guard.
2647         * arch/arm.h: Rename include guard.
2648         * arch/arm-linux.h: Rename include guard.
2649         * arch/arm-get-next-pcs.h: Rename include guard.
2650         * arch/amd64.h: Add include guard.
2651         * arch/aarch64-insn.h: Rename include guard.
2652         * arch-utils.h: Rename include guard.
2653         * annotate.h: Add include guard.
2654         * amd64-darwin-tdep.h: Rename include guard.
2655         * aarch64-linux-tdep.h: Add include guard.
2656         * aarch64-fbsd-tdep.h: Add include guard.
2657         * aarch32-linux-nat.h: Add include guard.
2658
2659 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2660
2661         * macrotab.c (macro_define_internal): New function that
2662         factorizes macro_define_object_internal and macro_define_function
2663         code.
2664         (macro_define_object_internal): Use macro_define_internal.
2665         (macro_define_function): Likewise.
2666
2667 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2668
2669         * macrocmd.c (extract_identifier): Return
2670         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2671         callers.
2672
2673 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2674
2675         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2676
2677 2019-02-05  Tom Tromey  <tom@tromey.com>
2678
2679         * target.c (target_stack::unpush): Move assertion earlier.
2680
2681 2019-01-30  Tom Tromey  <tom@tromey.com>
2682
2683         PR python/23615:
2684         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2685         (gdbpy_parse_and_eval): Likewise.
2686         * python/python-internal.h (gdbpy_allow_threads): New class.
2687
2688 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2689
2690         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2691         (aarch64_fbsd_fpregmap): Move earlier.
2692         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2693         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2694         instead of individual calls to trad_frame_set_reg_addr.
2695         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2696         earlier.
2697         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2698         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2699         instead of individual calls to trad_frame_set_reg_addr.
2700
2701 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2702
2703         * CONTRIBUTE: Replace contribution list with wiki link.
2704
2705 2019-01-25  Tom Tromey  <tom@tromey.com>
2706
2707         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2708
2709 2019-01-25  Tom Tromey  <tom@tromey.com>
2710
2711         * xtensa-linux-nat.c: Fix common/ includes.
2712         * xml-support.h: Fix common/ includes.
2713         * xml-support.c: Fix common/ includes.
2714         * x86-linux-nat.c: Fix common/ includes.
2715         * windows-nat.c: Fix common/ includes.
2716         * varobj.h: Fix common/ includes.
2717         * varobj.c: Fix common/ includes.
2718         * value.c: Fix common/ includes.
2719         * valops.c: Fix common/ includes.
2720         * utils.c: Fix common/ includes.
2721         * unittests/xml-utils-selftests.c: Fix common/ includes.
2722         * unittests/utils-selftests.c: Fix common/ includes.
2723         * unittests/unpack-selftests.c: Fix common/ includes.
2724         * unittests/tracepoint-selftests.c: Fix common/ includes.
2725         * unittests/style-selftests.c: Fix common/ includes.
2726         * unittests/string_view-selftests.c: Fix common/ includes.
2727         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2728         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2729         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2730         * unittests/rsp-low-selftests.c: Fix common/ includes.
2731         * unittests/parse-connection-spec-selftests.c: Fix common/
2732         includes.
2733         * unittests/optional-selftests.c: Fix common/ includes.
2734         * unittests/offset-type-selftests.c: Fix common/ includes.
2735         * unittests/observable-selftests.c: Fix common/ includes.
2736         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2737         * unittests/memrange-selftests.c: Fix common/ includes.
2738         * unittests/memory-map-selftests.c: Fix common/ includes.
2739         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2740         * unittests/function-view-selftests.c: Fix common/ includes.
2741         * unittests/environ-selftests.c: Fix common/ includes.
2742         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2743         * unittests/common-utils-selftests.c: Fix common/ includes.
2744         * unittests/cli-utils-selftests.c: Fix common/ includes.
2745         * unittests/array-view-selftests.c: Fix common/ includes.
2746         * ui-file.c: Fix common/ includes.
2747         * tui/tui-io.c: Fix common/ includes.
2748         * tracepoint.h: Fix common/ includes.
2749         * tracepoint.c: Fix common/ includes.
2750         * tracefile-tfile.c: Fix common/ includes.
2751         * top.h: Fix common/ includes.
2752         * top.c: Fix common/ includes.
2753         * thread.c: Fix common/ includes.
2754         * target/waitstatus.h: Fix common/ includes.
2755         * target/waitstatus.c: Fix common/ includes.
2756         * target.h: Fix common/ includes.
2757         * target.c: Fix common/ includes.
2758         * target-memory.c: Fix common/ includes.
2759         * target-descriptions.c: Fix common/ includes.
2760         * symtab.h: Fix common/ includes.
2761         * symfile.c: Fix common/ includes.
2762         * stap-probe.c: Fix common/ includes.
2763         * spu-linux-nat.c: Fix common/ includes.
2764         * sparc-nat.c: Fix common/ includes.
2765         * source.c: Fix common/ includes.
2766         * solib.c: Fix common/ includes.
2767         * solib-target.c: Fix common/ includes.
2768         * ser-unix.c: Fix common/ includes.
2769         * ser-tcp.c: Fix common/ includes.
2770         * ser-pipe.c: Fix common/ includes.
2771         * ser-base.c: Fix common/ includes.
2772         * selftest-arch.c: Fix common/ includes.
2773         * s12z-tdep.c: Fix common/ includes.
2774         * rust-exp.y: Fix common/ includes.
2775         * rs6000-aix-tdep.c: Fix common/ includes.
2776         * riscv-tdep.c: Fix common/ includes.
2777         * remote.c: Fix common/ includes.
2778         * remote-notif.h: Fix common/ includes.
2779         * remote-fileio.h: Fix common/ includes.
2780         * remote-fileio.c: Fix common/ includes.
2781         * regcache.h: Fix common/ includes.
2782         * regcache.c: Fix common/ includes.
2783         * record-btrace.c: Fix common/ includes.
2784         * python/python.c: Fix common/ includes.
2785         * python/py-type.c: Fix common/ includes.
2786         * python/py-inferior.c: Fix common/ includes.
2787         * progspace.h: Fix common/ includes.
2788         * producer.c: Fix common/ includes.
2789         * procfs.c: Fix common/ includes.
2790         * proc-api.c: Fix common/ includes.
2791         * printcmd.c: Fix common/ includes.
2792         * ppc-linux-nat.c: Fix common/ includes.
2793         * parser-defs.h: Fix common/ includes.
2794         * osdata.c: Fix common/ includes.
2795         * obsd-nat.c: Fix common/ includes.
2796         * nat/x86-linux.c: Fix common/ includes.
2797         * nat/x86-linux-dregs.c: Fix common/ includes.
2798         * nat/x86-dregs.h: Fix common/ includes.
2799         * nat/x86-dregs.c: Fix common/ includes.
2800         * nat/ppc-linux.c: Fix common/ includes.
2801         * nat/mips-linux-watch.h: Fix common/ includes.
2802         * nat/mips-linux-watch.c: Fix common/ includes.
2803         * nat/linux-waitpid.c: Fix common/ includes.
2804         * nat/linux-ptrace.h: Fix common/ includes.
2805         * nat/linux-ptrace.c: Fix common/ includes.
2806         * nat/linux-procfs.c: Fix common/ includes.
2807         * nat/linux-personality.c: Fix common/ includes.
2808         * nat/linux-osdata.c: Fix common/ includes.
2809         * nat/linux-namespaces.c: Fix common/ includes.
2810         * nat/linux-btrace.h: Fix common/ includes.
2811         * nat/linux-btrace.c: Fix common/ includes.
2812         * nat/fork-inferior.c: Fix common/ includes.
2813         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2814         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2815         * nat/aarch64-linux.c: Fix common/ includes.
2816         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2817         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2818         * namespace.h: Fix common/ includes.
2819         * mips-linux-tdep.c: Fix common/ includes.
2820         * minsyms.c: Fix common/ includes.
2821         * mi/mi-parse.h: Fix common/ includes.
2822         * mi/mi-main.c: Fix common/ includes.
2823         * mi/mi-cmd-env.c: Fix common/ includes.
2824         * memrange.h: Fix common/ includes.
2825         * memattr.c: Fix common/ includes.
2826         * maint.h: Fix common/ includes.
2827         * maint.c: Fix common/ includes.
2828         * main.c: Fix common/ includes.
2829         * machoread.c: Fix common/ includes.
2830         * location.c: Fix common/ includes.
2831         * linux-thread-db.c: Fix common/ includes.
2832         * linux-nat.c: Fix common/ includes.
2833         * linux-fork.c: Fix common/ includes.
2834         * inline-frame.c: Fix common/ includes.
2835         * infrun.c: Fix common/ includes.
2836         * inflow.c: Fix common/ includes.
2837         * inferior.h: Fix common/ includes.
2838         * inferior.c: Fix common/ includes.
2839         * infcmd.c: Fix common/ includes.
2840         * inf-ptrace.c: Fix common/ includes.
2841         * inf-child.c: Fix common/ includes.
2842         * ia64-linux-nat.c: Fix common/ includes.
2843         * i387-tdep.c: Fix common/ includes.
2844         * i386-tdep.c: Fix common/ includes.
2845         * i386-linux-tdep.c: Fix common/ includes.
2846         * i386-linux-nat.c: Fix common/ includes.
2847         * i386-go32-tdep.c: Fix common/ includes.
2848         * i386-fbsd-tdep.c: Fix common/ includes.
2849         * i386-fbsd-nat.c: Fix common/ includes.
2850         * guile/scm-type.c: Fix common/ includes.
2851         * guile/guile.c: Fix common/ includes.
2852         * go32-nat.c: Fix common/ includes.
2853         * gnu-nat.c: Fix common/ includes.
2854         * gdbthread.h: Fix common/ includes.
2855         * gdbarch-selftests.c: Fix common/ includes.
2856         * gdb_usleep.c: Fix common/ includes.
2857         * gdb_select.h: Fix common/ includes.
2858         * gdb_bfd.c: Fix common/ includes.
2859         * gcore.c: Fix common/ includes.
2860         * fork-child.c: Fix common/ includes.
2861         * findvar.c: Fix common/ includes.
2862         * fbsd-nat.c: Fix common/ includes.
2863         * event-top.c: Fix common/ includes.
2864         * event-loop.c: Fix common/ includes.
2865         * dwarf2read.c: Fix common/ includes.
2866         * dwarf2loc.c: Fix common/ includes.
2867         * dwarf2-frame.c: Fix common/ includes.
2868         * dwarf-index-cache.c: Fix common/ includes.
2869         * dtrace-probe.c: Fix common/ includes.
2870         * disasm-selftests.c: Fix common/ includes.
2871         * defs.h: Fix common/ includes.
2872         * csky-tdep.c: Fix common/ includes.
2873         * cp-valprint.c: Fix common/ includes.
2874         * cp-support.h: Fix common/ includes.
2875         * cp-support.c: Fix common/ includes.
2876         * corelow.c: Fix common/ includes.
2877         * completer.h: Fix common/ includes.
2878         * completer.c: Fix common/ includes.
2879         * compile/compile.c: Fix common/ includes.
2880         * compile/compile-loc2c.c: Fix common/ includes.
2881         * compile/compile-cplus-types.c: Fix common/ includes.
2882         * compile/compile-cplus-symbols.c: Fix common/ includes.
2883         * command.h: Fix common/ includes.
2884         * cli/cli-dump.c: Fix common/ includes.
2885         * cli/cli-cmds.c: Fix common/ includes.
2886         * charset.c: Fix common/ includes.
2887         * build-id.c: Fix common/ includes.
2888         * btrace.h: Fix common/ includes.
2889         * btrace.c: Fix common/ includes.
2890         * breakpoint.h: Fix common/ includes.
2891         * breakpoint.c: Fix common/ includes.
2892         * ax.h:
2893         (enum agent_op): Fix common/ includes.
2894         * ax-general.c (struct aop_map): Fix common/ includes.
2895         * ax-gdb.c: Fix common/ includes.
2896         * auxv.c: Fix common/ includes.
2897         * auto-load.c: Fix common/ includes.
2898         * arm-tdep.c: Fix common/ includes.
2899         * arch/riscv.c: Fix common/ includes.
2900         * arch/ppc-linux-common.c: Fix common/ includes.
2901         * arch/i386.c: Fix common/ includes.
2902         * arch/arm.c: Fix common/ includes.
2903         * arch/arm-linux.c: Fix common/ includes.
2904         * arch/arm-get-next-pcs.c: Fix common/ includes.
2905         * arch/amd64.c: Fix common/ includes.
2906         * arch/aarch64.c: Fix common/ includes.
2907         * arch/aarch64-insn.c: Fix common/ includes.
2908         * arch-utils.c: Fix common/ includes.
2909         * amd64-windows-tdep.c: Fix common/ includes.
2910         * amd64-tdep.c: Fix common/ includes.
2911         * amd64-sol2-tdep.c: Fix common/ includes.
2912         * amd64-obsd-tdep.c: Fix common/ includes.
2913         * amd64-nbsd-tdep.c: Fix common/ includes.
2914         * amd64-linux-tdep.c: Fix common/ includes.
2915         * amd64-linux-nat.c: Fix common/ includes.
2916         * amd64-fbsd-tdep.c: Fix common/ includes.
2917         * amd64-fbsd-nat.c: Fix common/ includes.
2918         * amd64-dicos-tdep.c: Fix common/ includes.
2919         * amd64-darwin-tdep.c: Fix common/ includes.
2920         * agent.c: Fix common/ includes.
2921         * ada-lang.h: Fix common/ includes.
2922         * ada-lang.c: Fix common/ includes.
2923         * aarch64-tdep.c: Fix common/ includes.
2924
2925 2019-01-25  Tom Tromey  <tom@tromey.com>
2926
2927         * common/create-version.sh: Use common/version.h.
2928
2929 2019-01-24  Pedro Alves  <palves@redhat.com>
2930
2931         * infrun.c (signal_stop, signal_print, signal_program)
2932         (signal_catch, signal_pass): Now arrays instead of pointers.
2933         (update_signals_program_target, do_target_resume)
2934         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2935         * linux-nat.c (linux_nat_target::pass_signals)
2936         (linux_nat_target::create_inferior, linux_nat_target::attach):
2937         Adjust.
2938         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2939         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2940         * procfs.c (procfs_target::pass_signals): Adjust.
2941         * record-full.c (record_full_target::resume): Adjust.
2942         * remote.c (remote_target::pass_signals)
2943         (remote_target::program_signals): Adjust.
2944         * target-debug.h (target_debug_print_signals): Now takes a
2945         gdb::array_view as parameter.  Adjust.
2946         * target.h (target_ops) <pass_signals, program_signals>: Replace
2947         pointer and length parameters with gdb::array_view.
2948         (target_pass_signals, target_program_signals): Likewise.
2949         * target-delegates.c: Regenerate.
2950
2951 2019-01-24  Pedro Alves  <palves@redhat.com>
2952
2953         * common/forward-scope-exit.h
2954         (forward_scope_exit::forward_scope_exit): Pass arguments to
2955         m_bind_function directly, instead of creating a std::bind and
2956         copying that.
2957
2958 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2959
2960         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2961         for static members.
2962         (pass_in_v_vfp_candidate): Likewise.
2963
2964 2019-01-23  Tom Tromey  <tom@tromey.com>
2965             Pedro Alves  <palves@redhat.com>
2966
2967         * regcache.c (class regcache_invalidator): Remove.
2968         (regcache::raw_write): Use make_scope_exit.
2969
2970 2019-01-23  Tom Tromey  <tom@tromey.com>
2971
2972         * ui-out.h (class ui_out_emit_type): Update comment.
2973
2974 2019-01-23  Tom Tromey  <tom@tromey.com>
2975
2976         * infrun.c (fetch_inferior_event): Update comment.
2977
2978 2019-01-23  Tom Tromey  <tom@tromey.com>
2979             Pedro Alves  <palves@redhat.com>
2980
2981         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2982         parameter.
2983         (fetch_inferior_event): Use SCOPE_EXIT.
2984
2985
2986 2019-01-23  Tom Tromey  <tom@tromey.com>
2987             Pedro Alves  <palves@redhat.com>
2988
2989         * infrun.c (disable_thread_events): Delete.
2990         (stop_all_threads): Use SCOPE_EXIT.
2991
2992 2019-01-23  Tom Tromey  <tom@tromey.com>
2993             Pedro Alves  <palves@redhat.com>
2994
2995         * symfile.c: Include forward-scope-exit.h.
2996         (clear_symtab_users_cleanup): Replace forward declaration with
2997         a FORWARD_SCOPE_EXIT.
2998         (syms_from_objfile_1): Use the forward_scope_exit and
2999         gdb::optional instead of cleanup_function.
3000         (reread_symbols): Use the forward_scope_exit instead of
3001         cleanup_function.
3002         (clear_symtab_users_cleanup): Remove function.
3003
3004 2019-01-23  Tom Tromey  <tom@tromey.com>
3005             Pedro Alves  <palves@redhat.com>
3006
3007         * linux-nat.c: Include scope-exit.h.
3008         (cleanup_target_stop): Remove.
3009         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3010         SCOPE_EXIT.
3011
3012 2019-01-23  Tom Tromey  <tom@tromey.com>
3013             Pedro Alves  <palves@redhat.com>
3014
3015         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3016         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3017
3018 2019-01-23  Tom Tromey  <tom@tromey.com>
3019             Andrew Burgess  <andrew.burgess@embecosm.com>
3020             Pedro Alves  <palves@redhat.com>
3021
3022         * infrun.c (fetch_inferior_event): Use scope_exit.
3023         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3024         * top.c (execute_command): Use scope_exit.
3025         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3026         * utils.c (do_bpstat_clear_actions_cleanup)
3027         (make_bpstat_clear_actions_cleanup): Remove.
3028
3029 2019-01-23  Tom Tromey  <tom@tromey.com>
3030             Pedro Alves  <palves@redhat.com>
3031
3032         * infrun.c: Include "common/scope-exit.h"
3033         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3034         (wait_for_inferior): Use SCOPE_EXIT.
3035         (fetch_inferior_event): Use scope_exit.
3036
3037 2019-01-23  Tom Tromey  <tom@tromey.com>
3038             Pedro Alves  <palves@redhat.com>
3039
3040         * breakpoint.c (create_breakpoint): Remove cleanup.
3041
3042 2019-01-23  Tom Tromey  <tom@tromey.com>
3043             Andrew Burgess  <andrew.burgess@embecosm.com>
3044             Pedro Alves  <palves@redhat.com>
3045
3046 2019-01-23  Pedro Alves  <palves@redhat.com>
3047
3048         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3049
3050 2019-01-23  Pedro Alves  <palves@redhat.com>
3051             Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * gdbthread.h: Include "common/forward-scope-exit.h".
3054         (scoped_finish_thread_state): Redefine custom class in terms of
3055         forward_scope_exit.
3056
3057 2019-01-23  Pedro Alves  <palves@redhat.com>
3058             Andrew Burgess  <andrew.burgess@embecosm.com>
3059
3060         * common/forward-scope-exit.h: New file.
3061
3062 2019-01-23  Pedro Alves  <palves@redhat.com>
3063             Andrew Burgess  <andrew.burgess@embecosm.com>
3064             Tom Tromey  <tom@tromey.com>
3065
3066         * common/scope-exit.h: New file.
3067
3068 2019-01-23  Pedro Alves  <palves@redhat.com>
3069
3070         * common/preprocessor.h (ESC): Rename to ...
3071         (ESC_PARENS): ... this.
3072         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3073         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3074
3075 2019-01-23  Tom Tromey  <tom@tromey.com>
3076
3077         * language.h (class scoped_switch_to_sym_language_if_auto):
3078         Initialize m_lang in both cases.
3079
3080 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3081
3082         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3083         with XCNEW.
3084
3085 2019-01-22  Tom Tromey  <tom@tromey.com>
3086
3087         * corelow.c: Do not include sys/file.h.
3088
3089 2019-01-22  Tom Tromey  <tom@tromey.com>
3090
3091         * tui/tui-wingeneral.h: Include gdb_curses.h.
3092
3093 2019-01-22  Tom Tromey  <tom@tromey.com>
3094
3095         * source-cache.h (class source_cache) <get_source_lines,
3096         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3097
3098 2019-01-22  Tom Tromey  <tom@tromey.com>
3099
3100         * remote-fileio.h (struct remote_target): Declare.
3101
3102 2019-01-22  Tom Tromey  <tom@tromey.com>
3103
3104         * python/py-arch.c: Do not include py-ref.h.
3105         * python/py-bpevent.c: Do not include py-ref.h.
3106         * python/py-cmd.c: Do not include py-ref.h.
3107         * python/py-continueevent.c: Do not include py-ref.h.
3108         * python/py-event.h: Do not include py-ref.h.
3109         * python/py-evtregistry.c: Do not include py-ref.h.
3110         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3111         * python/py-frame.c: Do not include py-ref.h.
3112         * python/py-framefilter.c: Do not include py-ref.h.
3113         * python/py-function.c: Do not include py-ref.h.
3114         * python/py-infevents.c: Do not include py-ref.h.
3115         * python/py-linetable.c: Do not include py-ref.h.
3116         * python/py-objfile.c: Do not include py-ref.h.
3117         * python/py-param.c: Do not include py-ref.h.
3118         * python/py-prettyprint.c: Do not include py-ref.h.
3119         * python/py-progspace.c: Do not include py-ref.h.
3120         * python/py-symbol.c: Do not include py-ref.h.
3121         * python/py-symtab.c: Do not include py-ref.h.
3122         * python/py-type.c: Do not include py-ref.h.
3123         * python/py-unwind.c: Do not include py-ref.h.
3124         * python/py-utils.c: Do not include py-ref.h.
3125         * python/py-value.c: Do not include py-ref.h.
3126         * python/py-varobj.c: Do not include py-ref.h.
3127         * python/py-xmethods.c: Do not include py-ref.h.
3128         * python/python.c: Do not include py-ref.h.
3129         * varobj.c: Do not include py-ref.h.
3130
3131 2019-01-22  Tom Tromey  <tom@tromey.com>
3132
3133         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3134         keyword for bcache.
3135
3136 2019-01-22  Tom Tromey  <tom@tromey.com>
3137
3138         * compile/compile-cplus-types.c: Remove a comment by #include.
3139
3140 2019-01-22  Tom Tromey  <tom@tromey.com>
3141
3142         * compile/gcc-c-plugin.h: Include compile-internal.h.
3143
3144 2019-01-22  Tom Tromey  <tom@tromey.com>
3145
3146         * stabsread.c (EXTERN): Do not define.
3147         (symnum, next_symbol_text_func, processing_gcc_compilation)
3148         (within_function, global_sym_chain, global_stabs)
3149         (previous_stab_code, this_object_header_files)
3150         (n_this_object_header_files)
3151         (n_allocated_this_object_header_files): Define.
3152         * stabsread.h (EXTERN): Never define.  Use "extern".
3153
3154 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3155
3156         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3157         history_value.
3158
3159 2019-01-21  Tom Tromey  <tom@tromey.com>
3160
3161         * ui-out.c: Fix includes.
3162         * tui/tui-source.c: Fix includes.
3163         * target.c: Fix includes.
3164         * remote.c: Fix includes.
3165         * regcache.c: Fix includes.
3166         * python/py-block.c: Fix includes.
3167         * printcmd.c: Fix includes.
3168         * or1k-tdep.c: Fix includes.
3169         * mi/mi-main.c: Fix includes.
3170         * m32r-tdep.c: Fix includes.
3171         * csky-tdep.c: Fix includes.
3172         * compile/compile-cplus-types.c: Fix includes.
3173         * cli/cli-interp.c: Fix includes.
3174
3175 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3176
3177         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3178         for padding.
3179
3180 2019-01-16  Tom Tromey  <tom@tromey.com>
3181
3182         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3183         earlier.
3184         (struct objfile) <msymbols_range>: Move from top level.
3185         <msymbols>: New method.
3186         (class objfile_msymbols): Remove.
3187         * symtab.c (default_collect_symbol_completion_matches_break_on):
3188         Update.
3189         * symmisc.c (dump_msymbols): Update.
3190         * stabsread.c (scan_file_globals): Update.
3191         * objc-lang.c (info_selectors_command, info_classes_command)
3192         (find_methods): Update.
3193         * minsyms.c (find_solib_trampoline_target): Update.
3194         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3195         * coffread.c (coff_symfile_read): Update.
3196         * ada-lang.c (ada_lookup_simple_minsym)
3197         (ada_collect_symbol_completion_matches): Update.
3198
3199 2019-01-16  Tom Tromey  <tom@tromey.com>
3200
3201         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3202         type.  Remove no-argument constructor.
3203         <iterator::operator++>: Simplify.
3204         <begin>: Update.
3205         <end>: Use minimal_symbol_count.
3206
3207 2019-01-16  Tom Tromey  <tom@tromey.com>
3208
3209         * objfiles.h (struct objfile) <psymtabs>: New method.
3210         (class objfile_psymtabs): Remove.
3211         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3212         typedef.
3213         <range>: New method.
3214         (require_partial_symbols): Change return type.
3215         * psymtab.c (require_partial_symbols)
3216         (psym_expand_symtabs_matching): Update.
3217         * mdebugread.c (parse_partial_symbols): Update.
3218         * dbxread.c (dbx_end_psymtab): Update.
3219
3220 2019-01-15  Tom Tromey  <tom@tromey.com>
3221
3222         * symtab.c (lookup_objfile_from_block)
3223         (lookup_symbol_in_objfile_symtabs)
3224         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3225         (find_line_symtab, info_sources_command)
3226         (default_collect_symbol_completion_matches_break_on)
3227         (make_source_files_completion_list): Update.
3228         * symmisc.c (print_objfile_statistics, dump_objfile)
3229         (maintenance_print_symbols, maintenance_info_symtabs)
3230         (maintenance_check_symtabs, maintenance_info_line_tables):
3231         Update.
3232         * source.c (select_source_symtab)
3233         (forget_cached_source_info_for_objfile): Update.
3234         * objfiles.h (class objfile_compunits): Remove.
3235         (struct objfile) <compunits_range>: New typedef.
3236         (compunits): New method.
3237         * objfiles.c (objfile_relocate1): Update.
3238         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3239         * maint.c (count_symtabs_and_blocks): Update.
3240         * linespec.c (iterate_over_all_matching_symtabs): Update.
3241         * cp-support.c (add_symbol_overload_list_qualified): Update.
3242         * coffread.c (coff_symtab_read): Update.
3243         * ada-lang.c (add_nonlocal_symbols)
3244         (ada_collect_symbol_completion_matches)
3245         (ada_add_global_exceptions): Update.
3246
3247 2019-01-15  Tom Tromey  <tom@tromey.com>
3248
3249         * progspace.h (program_space) <objfiles_safe_range>: New
3250         typedef.
3251         <objfiles_safe>: New method.
3252         * objfiles.h (class all_objfiles_safe): Remove.
3253         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3254         * jit.c (jit_inferior_exit_hook): Update.
3255
3256 2019-01-17  Tom Tromey  <tom@tromey.com>
3257
3258         * progspace.h (program_space) <objfiles_range>: New typedef.
3259         <objfiles>: New method.
3260         <objfiles_head>: Rename from objfiles.
3261         (object_files): Update.
3262         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3263         * guile/scm-pretty-print.c
3264         (ppscm_find_pretty_printer_from_objfiles): Update.
3265         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3266         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3267         Update.
3268         * python/py-progspace.c (pspy_get_objfiles): Update.
3269         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3270         Update.
3271         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3272         (objfpy_lookup_objfile_by_build_id): Update.
3273         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3274         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3275         Update.
3276         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3277         (expand_symtab_containing_pc, lookup_objfile_from_block)
3278         (lookup_static_symbol, basic_lookup_transparent_type)
3279         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3280         (find_line_symtab, info_sources_command)
3281         (default_collect_symbol_completion_matches_break_on)
3282         (make_source_files_completion_list, find_main_name): Update.
3283         * symmisc.c (print_symbol_bcache_statistics)
3284         (print_objfile_statistics, maintenance_print_symbols)
3285         (maintenance_print_msymbols, maintenance_print_objfiles)
3286         (maintenance_info_symtabs, maintenance_check_symtabs)
3287         (maintenance_expand_symtabs, maintenance_info_line_tables):
3288         Update.
3289         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3290         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3291         (map_overlay_command, unmap_overlay_command)
3292         (simple_overlay_update, expand_symtabs_matching)
3293         (map_symbol_filenames): Update.
3294         * symfile-debug.c (set_debug_symfile): Update.
3295         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3296         Update.
3297         * source.c (select_source_symtab, forget_cached_source_info):
3298         Update.
3299         * solib.c (solib_read_symbols): Update.
3300         * solib-spu.c (append_ocl_sos): Update.
3301         * psymtab.c (maintenance_print_psymbols)
3302         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3303         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3304         * printcmd.c (info_symbol_command): Update.
3305         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3306         Update.
3307         * objfiles.h (class all_objfiles): Remove.
3308         * objfiles.c (have_partial_symbols, have_full_symbols)
3309         (have_minimal_symbols, qsort_cmp, update_section_map)
3310         (shared_objfile_contains_address_p)
3311         (default_iterate_over_objfiles_in_search_order): Update.
3312         * objc-lang.c (info_selectors_command, info_classes_command)
3313         (find_methods): Update.
3314         * minsyms.c (find_solib_trampoline_target): Update.
3315         * maint.c (maintenance_info_sections)
3316         (maintenance_translate_address, count_symtabs_and_blocks):
3317         Update.
3318         * main.c (captured_main_1): Update.
3319         * linux-thread-db.c (try_thread_db_load_from_pdir)
3320         (has_libpthread): Update.
3321         * linespec.c (iterate_over_all_matching_symtabs)
3322         (search_minsyms_for_name): Update.
3323         * jit.c (jit_find_objf_with_entry_addr): Update.
3324         * hppa-tdep.c (find_unwind_entry)
3325         (hppa_lookup_stub_minimal_symbol): Update.
3326         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3327         Update.
3328         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3329         (elf_gnu_ifunc_resolve_by_got): Update.
3330         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3331         * dwarf-index-write.c (save_gdb_index_command): Update.
3332         * cp-support.c (add_symbol_overload_list_qualified): Update.
3333         * breakpoint.c (create_overlay_event_breakpoint)
3334         (create_longjmp_master_breakpoint)
3335         (create_std_terminate_master_breakpoint)
3336         (create_exception_master_breakpoint): Update.
3337         * blockframe.c (find_pc_partial_function): Update.
3338         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3339         (ada_collect_symbol_completion_matches)
3340         (ada_add_global_exceptions): Update.
3341
3342 2019-01-17  Tom Tromey  <tom@tromey.com>
3343
3344         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3345         declare VEC.
3346         (solib_target_parse_libraries): Change return type.
3347         (library_list_start_segment, library_list_start_section)
3348         (library_list_end_library, library_list_start_library); Update.
3349         (solib_target_free_library_list): Remove.
3350         (solib_target_parse_libraries): Remove cleanup.  Change return
3351         type.
3352         (solib_target_current_sos): Update.
3353
3354 2019-01-17  Tom Tromey  <tromey@bapiya>
3355
3356         * valprint.c: Replace "the the" with "the".
3357         * symtab.c: Replace "the the" with "the".
3358         * solib.c: Replace "the the" with "the".
3359         * solib-dsbt.c: Replace "the the" with "the".
3360         * linespec.c: Replace "the the" with "the".
3361         * dwarf2loc.h: Replace "the the" with "the".
3362         * amd64-windows-tdep.c: Replace "the the" with "the".
3363         * aarch64-tdep.c: Replace "the the" with "the".
3364
3365 2019-01-16  Keith Seitz  <keiths@redhat.com>
3366
3367         PR gdb/23773
3368         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3369         <builder>: Rename to ..
3370         <m_builder>: ... this and make private.
3371         (dwarf2_cu::get_builder): New method.  Change all users of
3372         `builder' to use this method.
3373         (dwarf2_start_symtab): Move to ...
3374         (dwarf2_cu::start_symtab): ... here.  Update all callers
3375         (setup_type_unit_groups): Move to ...
3376         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3377         callers.
3378         (dwarf2_cu::reset_builder): New method.
3379         (process_full_compunit, process_full_type_unit): Use
3380         dwarf2_cu::reset_builder.
3381         (follow_die_offset): Record the ancestor CU if it is different
3382         from the followed DIE's CU.
3383         (follow_die_sig_1): Likewise.
3384
3385 2019-01-15  Tom Tromey  <tom@tromey.com>
3386
3387         * remote.c (class remote_state) <buf>: Now a char_vector.
3388         <buf_size>: Remove.
3389         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3390         parameter.
3391         (remote_target::getpkt_or_notif_sane_1)
3392         (remote_target::getpkt_sane)
3393         (remote_target::getpkt_or_notif_sane): Likewise.
3394         (class remote_target) <putpkt>: New overload.
3395         (remote_target::read_frame): Change type of "buf_p".  Remove
3396         sizeof_p parameter.
3397         (packet_ok): New overload.
3398         (packet_check_result): New overload.
3399         Update all uses.
3400
3401 2019-01-14  Tom Tromey  <tom@tromey.com>
3402
3403         * remote-notif.c (handle_notification, remote_notif_ack)
3404         (remote_notif_parse): Make "buf" const.
3405         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3406         const.
3407         (remote_notif_parse, remote_notif_ack, handle_notification):
3408         Likewise.
3409         * remote.c (remote_notif_stop_parse): Make "buf" const.
3410         (remote_target::remote_parse_stop_reply): Make "buf" const.
3411         (remote_notif_stop_ack): Make "buf" const.
3412
3413 2019-01-14  Tom Tromey  <tom@tromey.com>
3414
3415         * remote.c (remote_console_output): Make parameter const.
3416
3417 2019-01-14  Tom Tromey  <tom@tromey.com>
3418
3419         * target-debug.h (target_debug_print_signals): Constify.
3420         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3421         * procfs.c (procfs_target::pass_signals): Update.
3422         * linux-nat.c (linux_nat_target::pass_signals): Update.
3423         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3424         * target-delegates.c: Rebuild.
3425         * remote.c (remote_target::program_signals): Update.
3426         (remote_target::pass_signals): Update.
3427         * target.c (target_pass_signals): Constify argument.
3428         (target_program_signals): Likewise.
3429         * target.h (struct target_ops) <pass_signals, program_signals>:
3430         Constify argument.
3431         (target_pass_signals, target_program_signals): Constify argument.
3432
3433 2019-01-14  Tom Tromey  <tom@tromey.com>
3434
3435         PR tui/28819:
3436         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3437
3438 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3439
3440         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3441         field.
3442         * rs6000-tdep.c: Include reggroups.h.
3443         (IS_V_ALIAS_PSEUDOREG): Define.
3444         (rs6000_register_name): Return names for the "vX" aliases.
3445         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3446         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3447         aliases.  Call default_register_reggroup_p for all other
3448         pseudo-registers.
3449         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3450         New functions.
3451         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3452         Handle "vX" aliases.
3453         (v_alias_pseudo_register_collect): New function.
3454         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3455         (rs6000_gdbarch_init): Initialize "vX" aliases as
3456         pseudo-registers.  Restore registration of
3457         rs6000_pseudo_register_reggroup_p with
3458         set_tdesc_pseudo_register_reggroup_p.
3459
3460 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3461
3462         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3463         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3464         set_gdbarch_num_pseudo_regs.
3465
3466 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3467
3468         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3469         Remove arg prefixname, add do_set and do_show.
3470         Add member functions set_list and show_list.
3471         * cli/cli-style.c (class cli_style_option): Update accordingly.
3472         (style_set_list): Move to file scope.
3473         (style_show_list): Likewise.
3474         (set_style): Call help_list.
3475         (show_style): Call cmd_show_list.
3476         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3477         Update to use the new macro.
3478
3479 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3480
3481         * ada-lang.c (_initialize_ada_language): Expand the help text
3482         for the "catch exception" command.
3483
3484 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3485
3486         * symtab.c (matching_obj_sections): Initialize obj,
3487         declare it closer to its usage.
3488
3489 2019-01-10  Tom Tromey  <tom@tromey.com>
3490
3491         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3492         (basic_inf_threads_range): Remove.
3493         (inf_threads_range, inf_non_exited_threads_range)
3494         (safe_inf_threads_range): Use next_adapter.
3495
3496 2019-01-10  Keith Seitz  <keiths@redhat.com>
3497
3498         PR gdb/23712
3499         PR symtab/23010
3500         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3501         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3502
3503 2019-01-10  Keith Seitz  <keiths@redhat.com>
3504
3505         PR gdb/23712
3506         PR symtab/23010
3507         * dictionary.c (pending_to_vector): Remove.
3508         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3509         Remove _1 suffix, replacing functions of the same name.  Update
3510         all callers.
3511         (dict_create_hashed, dict_create_hashed_expandable)
3512         (dict_create_linear, dict_create_linear_expandable, dict_free)
3513         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3514         Make functions static.
3515
3516 2019-01-10  Keith Seitz  <keiths@redhat.com>
3517
3518         PR gdb/23712
3519         PR symtab/23010
3520         * dictionary.h (struct dictionary): Replace declaration with
3521         multidictionary.
3522         (dict_create_hashed, dict_create_hashed_expandable)
3523         (dict_create_linear, dict_create_linear_expandable)
3524         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3525         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3526         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3527         taking multidictionary argument.
3528         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3529         * block.h (struct block) <dict>: Change to multidictionary
3530         and rename `multidict'.
3531         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3532         symmisc.c: Update all dictionary references to multidictionary.
3533
3534 2019-01-10  Keith Seitz  <keiths@redhat.com>
3535
3536         PR gdb/23712
3537         PR symtab/23010
3538         * dictionary.c: Include unordered_map.
3539         (pending_to_vector): New function.
3540         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3541         Rewrite the non-"_1" functions to take vector instead
3542         of linked list.
3543         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3544         "new" _1 versions of the same name.
3545         (multidictionary): Define.
3546         (std::hash<enum language): New definition.
3547         (collate_pending_symbols_by_language, mdict_create_hashed)
3548         (mdict_create_hashed_expandable, mdict_create_linear)
3549         (mdict_create_linear_expandable, mdict_free)
3550         (find_language_dictionary, create_new_language_dictionary)
3551         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3552         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3553         (mdict_size, mdict_empty): New functions.
3554         * dictionary.h (mdict_iterator): Define.
3555
3556 2019-01-10  Pedro Alves  <palves@redhat.com>
3557
3558         * breakpoint.c (read_uploaded_action)
3559         (create_tracepoint_from_upload): Adjust to use
3560         gdb::unique_xmalloc_ptr.
3561         * ctf.c (ctf_write_uploaded_tp):
3562         (SET_ARRAY_FIELD): Use emplace_back.
3563         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3564         * tracefile-tfile.c (tfile_write_uploaded_tp):
3565         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3566         gdb::unique_xmalloc_ptr.
3567         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3568         at_string, cond_string, cmd_strings>: Replace char pointers
3569         with gdb::unique_xmalloc_ptr.
3570
3571 2019-01-10  Pedro Alves  <palves@redhat.com>
3572
3573         * solib-target.c (library_list_start_library): Don't xstrdup name.
3574
3575 2019-01-10  Pedro Alves  <palves@redhat.com>
3576
3577         * mdebugread.c (parse_partial_symbols): Use
3578         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3579
3580 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3581
3582         * linux-fork.c (scoped_switch_fork_info)
3583         <~scoped_switch_fork_info>: Fix incorrect variable name.
3584
3585 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3586
3587         * linux-fork.c (scoped_switch_fork_info)
3588         <scoped_switch_fork_info>: Make explicit.
3589         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3590
3591 2019-01-10  Tom Tromey  <tom@tromey.com>
3592
3593         * objfiles.h (objfile::reset_psymtabs): Update.
3594         * objfiles.c (objfile::objfile): Update.
3595         * psymtab.h (psymtab_storage::obstack): Update.
3596         (psymtab_storage::m_obstack): Use gdb::optional.
3597         (class psymtab_storage): Update comment.  Remove objfile
3598         parameter.
3599         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3600
3601 2019-01-10  Tom Tromey  <tom@tromey.com>
3602
3603         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3604         <free_psymtabs>: Now private.
3605         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3606         (allocate_psymtab): Use new method.
3607
3608 2019-01-10  Tom Tromey  <tom@tromey.com>
3609
3610         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3611         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3612         * mdebugread.c (parse_partial_symbols): Use
3613         allocate_dependencies.
3614         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3615         allocate_dependencies.
3616         (process_psymtab_comp_unit_reader)
3617         (build_type_psymtab_dependencies): Likewise.
3618         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3619
3620 2019-01-10  Tom Tromey  <tom@tromey.com>
3621
3622         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3623         PSYMBOL_SET_LANGUAGE.
3624         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3625
3626 2019-01-10  Tom Tromey  <tom@tromey.com>
3627
3628         * psymtab.h (psymtab_storage::obstack): New method.
3629         <m_obstack>: Rename from obstack; now private.
3630         * psymtab.c (psymtab_storage): Update.
3631         * dwarf2read.c (create_addrmap_from_index)
3632         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3633         Update.
3634
3635 2019-01-10  Tom Tromey  <tom@tromey.com>
3636
3637         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3638         * objfiles.h (objfile::reset_psymtabs): New method.
3639
3640 2019-01-10  Tom Tromey  <tom@tromey.com>
3641
3642         * symmisc.c (print_symbol_bcache_statistics): Update.
3643         (print_objfile_statistics): Update.
3644         * symfile.c (reread_symbols): Update.
3645         * psymtab.h (class psymtab_storage): New.
3646         * psymtab.c (psymtab_storage): New constructor.
3647         (~psymtab_storage): New destructor.
3648         (require_partial_symbols): Update.
3649         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3650         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3651         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3652         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3653         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3654         (start_psymtab_common, end_psymtab_common)
3655         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3656         (allocate_psymtab): Update.
3657         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3658         Update.
3659         (dump_psymtab_addrmap, maintenance_print_psymbols)
3660         (maintenance_check_psymtabs): Update.
3661         (class objfile_psymtabs): Move to objfiles.h.
3662         * psympriv.h (discard_psymtab): Now inline.
3663         (psymtab_discarder::psymtab_discarder): Update.
3664         (psymtab_discarder::~psymtab_discarder): Update.
3665         (ALL_OBJFILE_PSYMTABS): Rewrite.
3666         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3667         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3668         Remove fields.
3669         <partial_symtabs>: New field.
3670         (class objfile_psymtabs): Move from psymtab.h.  Update.
3671         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3672         psymbol_cache.
3673         (objfile::~objfile): Don't destroy psymbol_cache.
3674         * mdebugread.c (parse_partial_symbols): Update.
3675         * dwarf2read.c (create_addrmap_from_index)
3676         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3677         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3678         (add_partial_subprogram, dwarf2_ranges_read): Update.
3679         * dwarf-index-write.c (write_address_map)
3680         (write_one_signatured_type, recursively_write_psymbols)
3681         (class debug_names, class debug_names, write_psymtabs_to_index):
3682         Update.
3683
3684 2019-01-10  Tom Tromey  <tom@tromey.com>
3685
3686         * symtab.h (SYMBOL_SET_NAMES): Update.
3687         (symbol_set_names): Update.
3688         (MSYMBOL_SET_NAMES): Update.
3689         * symtab.c (symbol_set_names): Change argument to be an
3690         objfile_per_bfd_storage.
3691         * psymtab.c (add_psymbol_to_bcache): Update.
3692         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3693
3694 2019-01-10  Tom Tromey  <tom@tromey.com>
3695
3696         * symtab.c (create_demangled_names_hash): Change argument to be an
3697         objfile_per_bfd_storage.
3698         (symbol_set_names): Update.
3699
3700 2019-01-10  Tom Tromey  <tom@tromey.com>
3701
3702         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3703         init_psymbol_list.
3704         * psymtab.c (init_psymbol_list): Do nothing if already called.
3705         * psympriv.h (init_psymbol_list): Add comment.
3706         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3707         init_psymbol_list.
3708         * dbxread.c (dbx_symfile_read): Unconditionally call
3709         init_psymbol_list.
3710
3711 2019-01-10  Tom Tromey  <tom@tromey.com>
3712
3713         * xcoffread.c (scan_xcoff_symtab): Update.
3714         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3715         "where".
3716         * mdebugread.c (parse_partial_symbols)
3717         (handle_psymbol_enumerators): Update.
3718         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3719         * dbxread.c (read_dbx_symtab): Update.
3720         * psympriv.h (psymbol_placement): New enum.
3721         (add_psymbol_to_list): Update.
3722
3723 2019-01-10  Tom Tromey  <tom@tromey.com>
3724
3725         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3726         static_psymbols parameters.
3727         (scan_xcoff_symtab): Update.
3728         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3729         static_psymbols parameters.
3730         * psympriv.h (start_psymtab_common): Update.
3731         * mdebugread.c (parse_partial_symbols): Update.
3732         * dwarf2read.c (create_partial_symtab): Update.
3733         * dbxread.c (read_dbx_symtab): Update.
3734         (start_psymtab): Remove global_psymbols and static_psymbols
3735         parameters.
3736
3737 2019-01-10  Tom Tromey  <tom@tromey.com>
3738
3739         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3740         * psymtab.c (allocate_psymtab): Add comment.
3741         * psympriv.h (allocate_psymtab): Add comment.
3742         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3743         initializations.
3744         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3745
3746 2019-01-10  Tom Tromey  <tom@tromey.com>
3747
3748         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3749         Don't declare.
3750         * mipsread.c: Include mdebugread.h.
3751         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3752         Declare.
3753         * elfread.c: Include mdebugread.h.
3754
3755 2019-01-09  Tom Tromey  <tom@tromey.com>
3756
3757         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3758         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3759         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3760         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3761         (psym_lookup_symbol, psym_find_last_source_symtab)
3762         (psym_forget_cached_source_info, psym_print_stats)
3763         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3764         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3765         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3766         (psym_find_compunit_symtab_by_address)
3767         (maintenance_print_psymbols, maintenance_info_psymtabs)
3768         (maintenance_check_psymtabs): Use ranged for.
3769         * psymtab.h (class objfile_psymtabs): New.
3770         (require_partial_symbols): Return objfile_psymtabs.
3771         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3772
3773 2019-01-09  Tom Tromey  <tom@tromey.com>
3774
3775         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3776         (find_pc_mapped_section, list_overlays_command)
3777         (map_overlay_command, unmap_overlay_command)
3778         (simple_overlay_update): Use all_objfiles.
3779         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3780         * printcmd.c (info_symbol_command): Use all_objfiles.
3781         * objfiles.h (ALL_OBJSECTIONS): Remove.
3782         * maint.c (maintenance_translate_address): Use all_objfiles.
3783         * gcore.c (gcore_create_callback): Use all_objfiles.
3784         (objfile_find_memory_regions): Likewise.
3785
3786 2019-01-09  Tom Tromey  <tom@tromey.com>
3787
3788         * symtab.c (find_line_symtab, info_sources_command)
3789         (make_source_files_completion_list): Use objfile_compunits.
3790         * source.c (select_source_symtab): Use objfile_compunits.
3791         * objfiles.h (struct objfile): Update comment.
3792         (ALL_OBJFILES): Remove.
3793         (ALL_FILETABS): Remove.
3794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3795         objfile_compunits.
3796
3797 2019-01-09  Tom Tromey  <tom@tromey.com>
3798
3799         * symmisc.c (print_objfile_statistics, dump_objfile)
3800         (maintenance_print_symbols): Use compunit_filetabs.
3801         * source.c (forget_cached_source_info_for_objfile): Use
3802         compunit_filetabs.
3803         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3804         (ALL_FILETABS): Use compunit_filetabs.
3805         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3806         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3807
3808 2019-01-09  Tom Tromey  <tom@tromey.com>
3809
3810         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3811         (compunit_filetabs): New.
3812         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3813         compunit_filetabs.
3814         (info_sources_command, make_source_files_completion_list): Remove
3815         declaration.
3816         * symmisc.c (print_objfile_statistics, dump_objfile)
3817         (maintenance_print_symbols): Remove declaration.
3818         (maintenance_info_symtabs): Use compunit_filetabs.
3819         (maintenance_info_line_tables): Likewise.
3820         * source.c (select_source_symtab): Change local variable name.
3821         (forget_cached_source_info_for_objfile): Remove declaration.
3822         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3823         * objfiles.c (objfile_relocate1): Remove declaration.
3824         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3825         declaration.
3826         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3827         * coffread.c (coff_symtab_read): Remove declaration.
3828         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3829         compunit_filetabs.
3830
3831 2019-01-09  Tom Tromey  <tom@tromey.com>
3832
3833         * symtab.c (lookup_objfile_from_block)
3834         (find_pc_sect_compunit_symtab, search_symbols)
3835         (default_collect_symbol_completion_matches_break_on): Use
3836         objfile_compunits.
3837         * objfiles.h (ALL_COMPUNITS): Remove.
3838         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3839         * cp-support.c (add_symbol_overload_list_qualified): Use
3840         objfile_compunits.
3841         * ada-lang.c (ada_collect_symbol_completion_matches)
3842         (ada_add_global_exceptions): Use objfile_compunits.
3843
3844 2019-01-09  Tom Tromey  <tom@tromey.com>
3845
3846         * source.c (select_source_symtab)
3847         (forget_cached_source_info_for_objfile): Remove declaration.
3848         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3849         declaration.
3850         * maint.c (count_symtabs_and_blocks): Remove declaration.
3851         * cp-support.c (add_symbol_overload_list_qualified): Remove
3852         declaration.
3853         * coffread.c (coff_symtab_read): Remove declaration.
3854         * symtab.c (lookup_symbol_in_objfile_symtabs)
3855         (basic_lookup_transparent_type_1): Use objfile_compunits.
3856         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3857         (info_sources_command, search_symbols)
3858         (default_collect_symbol_completion_matches_break_on)
3859         (make_source_files_completion_list): Remove declaration.
3860         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3861         (ada_collect_symbol_completion_matches)
3862         (ada_add_global_exceptions): Remove declaration.
3863         * linespec.c (iterate_over_all_matching_symtabs): Use
3864         objfile_compunits.
3865         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3866         (class objfile_compunits): New.
3867         (ALL_COMPUNITS): Use objfile_compunits.
3868         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3869         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3870         objfile_compunits.
3871         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3872
3873 2019-01-09  Tom Tromey  <tom@tromey.com>
3874
3875         * symtab.c (search_symbols)
3876         (default_collect_symbol_completion_matches_break_on): Use
3877         objfile_msymbols.
3878         * ada-lang.c (ada_lookup_simple_minsym)
3879         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3880         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3881         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3882         objfile_msymbols.
3883         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3884         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3885         * objc-lang.c (find_methods): Use objfile_msymbols.
3886         (info_selectors_command, info_classes_command): Likewise.
3887         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3888         * objfiles.h (class objfile_msymbols): New.
3889         (ALL_OBJFILE_MSYMBOLS): Remove.
3890         (ALL_MSYMBOLS): Remove.
3891
3892 2019-01-09  Tom Tromey  <tom@tromey.com>
3893
3894         * common/next-iterator.h (next_adapter): Add Iterator template
3895         parameter.
3896         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3897         (class all_objfiles_safe): New.
3898         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3899         * objfiles.c (put_objfile_before): Update comment.
3900         (add_separate_debug_objfile): Likewise.
3901         (free_all_objfiles): Use all_objfiles_safe.
3902         (objfile_purge_solibs): Likewise.
3903
3904 2019-01-09  Tom Tromey  <tom@tromey.com>
3905
3906         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3907         (expand_symtab_containing_pc, lookup_static_symbol)
3908         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3909         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3910         all_objfiles.
3911         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3912         * breakpoint.c (create_overlay_event_breakpoint)
3913         (create_longjmp_master_breakpoint)
3914         (create_std_terminate_master_breakpoint)
3915         (create_exception_master_breakpoint): Use all_objfiles.
3916         * linux-thread-db.c (try_thread_db_load_from_pdir)
3917         (has_libpthread): Use all_objfiles.
3918         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3919         * linespec.c (iterate_over_all_matching_symtabs)
3920         (search_minsyms_for_name): Use all_objfiles.
3921         * maint.c (maintenance_info_sections): Use all_objfiles.
3922         * main.c (captured_main_1): Use all_objfiles.
3923         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3924         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3925         * guile/scm-pretty-print.c
3926         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3927         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3928         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3929         (maintenance_print_msymbols): Use all_objfiles.
3930         * source.c (select_source_symtab): Use all_objfiles.
3931         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3932         * symfile.c (remove_symbol_file_command)
3933         (expand_symtabs_matching, map_symbol_filenames): Use
3934         all_objfiles.
3935         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3936         all_objfiles.
3937         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3938         * objc-lang.c (find_methods): Use all_objfiles.
3939         * objfiles.c (have_partial_symbols, have_full_symbols)
3940         (have_minimal_symbols, qsort_cmp)
3941         (default_iterate_over_objfiles_in_search_order): Use
3942         all_objfiles.
3943         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3944         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3945         (maintenance_check_psymtabs): Use all_objfiles.
3946         (ALL_PSYMTABS): Remove.
3947         * compile/compile-object-run.c (do_module_cleanup): Use
3948         all_objfiles.
3949         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3950         * cp-support.c (add_symbol_overload_list_qualified): Use
3951         all_objfiles.
3952         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3953         Use all_objfiles.
3954         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3955         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3956         all_objfiles.
3957         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3958         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3959         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3960         Uses all_objfiles.
3961         * solib.c (solib_read_symbols): Use all_objfiles
3962
3963 2019-01-09  Tom Tromey  <tom@tromey.com>
3964
3965         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3966         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3967         all_objfiles.
3968         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3969         * symmisc.c (print_symbol_bcache_statistics)
3970         (print_objfile_statistics, maintenance_print_objfiles)
3971         (maintenance_info_symtabs, maintenance_check_symtabs)
3972         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3973         all_objfiles.
3974         * source.c (forget_cached_source_info): Use all_objfiles.
3975         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3976         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3977         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3978         * objfiles.c (update_section_map): Use all_objfiles.
3979         (shared_objfile_contains_address_p): Likewise.
3980         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3981         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3982
3983 2019-01-09  Tom Tromey  <tom@tromey.com>
3984
3985         * common/next-iterator.h: New file.
3986         * objfiles.h (class all_objfiles): New.
3987         (struct objfile_iterator): New.
3988
3989 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3990
3991         * NEWS: Move the description of the changed "frame", "select-frame",
3992          and "info frame" commands to the Changed commands section.
3993
3994 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3995
3996         * gdbtypes.c (check_stub_method_group): Remove handling of old
3997         mangling schemes.
3998         * linespec.c (find_methods): Likewise.
3999         * stabsread.c (read_member_functions): Likewise.
4000         * valops.c (search_struct_method): Likewise.
4001         (value_struct_elt_for_reference): Likewise.
4002         * NEWS: Mention this change.
4003
4004 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4007         print_source_lines.
4008         * source.c (print_source_lines_base): Update line number check.
4009         (print_source_lines): New function.
4010         (source_lines_range::source_lines_range): New function.
4011         * source.h (class source_lines_range): New class.
4012         (print_source_lines): New declaration.
4013
4014 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4015
4016         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4017
4018 2019-01-08  Tom Tromey  <tom@tromey.com>
4019             Simon Marchi  <simon.marchi@ericsson.com>
4020
4021         PR gdb/24060
4022         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4023         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4024         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4025         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4026         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4027         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4028
4029 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4030
4031         * source.c (select_source_symtab): Move header comment to
4032         declaration in source.h.
4033         (forget_cached_source_info_for_objfile): Likewise.
4034         (forget_cached_source_info): Likewise.
4035         (identify_source_line): Likewise.
4036         * source.h (identify_source_line): Move declaration from symtab.h
4037         and add comment from source.c
4038         (print_source_lines): Likewise.
4039         (forget_cached_source_info_for_objfile): Likewise.
4040         (forget_cached_source_info): Likewise.
4041         (select_source_symtab): Likewise.
4042         (enum print_source_lines_flag): Move definition from symtab.h.
4043         * symtab.h (identify_source_line): Move declaration to source.h.
4044         (print_source_lines): Likewise.
4045         (forget_cached_source_info_for_objfile): Likewise.
4046         (forget_cached_source_info): Likewise.
4047         (select_source_symtab): Likewise.
4048         (enum print_source_lines_flag): Move definition to source.h.
4049         * tui/tui-hooks.c: Add 'source.h' include.
4050
4051 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * source.c (print_source_lines_base): Handle requests to print
4054         reverse line number sequences, and guard against empty lines
4055         string.
4056
4057 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * source.c (print_source_lines_base): Fix skip of '\r' if next
4060         character is '\n'.
4061
4062 2019-01-06  Tom Tromey  <tom@tromey.com>
4063
4064         * c-exp.y (struct c_parse_state) <macro_original_text,
4065         expansion_obstack>: New member.
4066         (macro_original_text, expansion_obstack): Remove globals.
4067         (scan_macro_expansion, scanning_macro_expansion)
4068         (finished_macro_expansion): Update.
4069         (scan_macro_cleanup): Remove.
4070         (yylex, c_parse): Update.
4071
4072 2019-01-06  Tom Tromey  <tom@tromey.com>
4073
4074         * c-exp.y (struct c_parse_state) <strings>: New member.
4075         (operator_stoken): Update.
4076
4077 2019-01-06  Tom Tromey  <tom@tromey.com>
4078
4079         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4080         (union type_stack_elt) <typelist_val>: Now a pointer to
4081         std::vector.
4082         (type_stack_cleanup): Don't declare.
4083         (push_typelist): Update.
4084         * parse.c (pop_typelist): Return a std::vector.
4085         (push_typelist): Take a std::vector.
4086         (follow_types): Update.  Do not free args.
4087         (type_stack_cleanup): Remove.
4088         * c-exp.y (struct c_parse_state): New.
4089         (cpstate): New global.
4090         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4091         (nonempty_typelist): Update.
4092         (func_mod): Create a new vector.
4093         (c_parse): Create a c_parse_state.
4094         (check_parameter_typelist): Do not delete params.
4095         (function_method): Update.  Do not delete type_list.
4096
4097 2019-01-06  Tom Tromey  <tom@tromey.com>
4098
4099         PR gdb/28155:
4100         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4101         check_typedef.
4102         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4103         (print_return_value): Likewise.
4104
4105 2019-01-05  Tom Tromey  <tom@tromey.com>
4106
4107         * contrib/cleanup_check.py: Remove.
4108         * contrib/gcc-with-excheck: Remove.
4109         * contrib/exsummary.py: Remove.
4110         * contrib/excheck.py: Remove.
4111
4112 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4113
4114         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4115         NULL. Initialize tpprev to NULL instead of assigning it
4116         to NULL on the next statement.
4117         * windows-nat.c (windows_delete_thread): Remove check for
4118         main_thread_id before printing thread exit notifications.
4119         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4120         Remove thread ID check against main_thread_id.
4121         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4122         windows_delete_thread.
4123         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4124
4125 2019-01-04  Tom Tromey  <tom@tromey.com>
4126
4127         * compile/compile.c (_initialize_compile): Use upper case for
4128         metasyntactic variables.
4129         * symmisc.c (_initialize_symmisc): Use upper case for
4130         metasyntactic variables.
4131         * psymtab.c (_initialize_psymtab): Use upper case for
4132         metasyntactic variables.
4133         * demangle.c (demangle_command): Use upper case for metasyntactic
4134         variables.
4135         (_initialize_demangler): Likewise.
4136         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4137         variables.
4138
4139 2019-01-03  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4142
4143 2019-01-03  Tom Tromey  <tom@tromey.com>
4144
4145         * python/py-symtab.c (salpy_str): Update.
4146         (struct salpy_sal_object) <symtab>: Now a PyObject.
4147         (salpy_dealloc): Update.
4148         (del_objfile_sal): Use gdbpy_ref.
4149
4150 2019-01-03  Tom Tromey  <tom@tromey.com>
4151
4152         * python/py-type.c (convert_field): Use new_reference.  Return
4153         gdbpy_ref.
4154         (make_fielditem): Return gdbpy_ref.
4155         (typy_fields): Update.
4156         (typy_getitem): Update.
4157         (field_name): Return gdbpy_ref.  Use new_reference.
4158         (typy_iterator_iternext): Update.
4159
4160 2019-01-03  Tom Tromey  <tom@tromey.com>
4161
4162         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4163
4164 2019-01-03  Tom Tromey  <tom@tromey.com>
4165
4166         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4167         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4168         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4169         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4170         (pspy_set_type_printers): Likewise.
4171         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4172         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4173         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4174         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4175         (objfpy_set_type_printers): Likewise.
4176
4177 2019-01-03  Tom Tromey  <tom@tromey.com>
4178
4179         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4180         (gdbpy_print_stack): Use gdbpy_err_fetch.
4181         * python/python-internal.h (class gdbpy_err_fetch): New class.
4182         (class gdbpy_enter) <m_error_type, m_error_value,
4183         m_error_traceback>: Remove.
4184         <m_error>: New member.
4185         (gdbpy_exception_to_string): Don't declare.
4186         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4187         * python/py-value.c (convert_value_from_python): Use
4188         gdbpy_err_fetch.
4189         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4190         gdbpy_exception_to_string.
4191         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4192         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4193         gdbpy_err_fetch.
4194
4195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * linux-nat.c (delete_lwp_cleanup): Delete.
4198         (struct lwp_deleter): New struct.
4199         (lwp_info_up): New typedef.
4200         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4201         lwp_info_up.
4202
4203 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * linux-fork.c (class scoped_switch_fork_info): New class.
4206         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4207
4208 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * valops.c (find_overload_match): Remove use of null_cleanup, and
4211         calls to do_cleanups.
4212
4213 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * compile/compile-cplus-types.c
4216         (compile_cplus_instance::decl_name): Handle changes to
4217         cp_func_name.
4218         * cp-support.c (cp_func_name): Update header comment, update
4219         return type.
4220         * cp-support.h (cp_func_name): Update return type in declaration.
4221         * valops.c (find_overload_match): Move temp_func local to top
4222         level of function and change its type.  Use temp_func to hold and
4223         delete temporary string obtained from cp_func_name.
4224
4225 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4228         gdb::char_vector, remove cleanup, and update uses of `msg`.
4229
4230 2019-01-03  Jim Wilson  <jimw@sifive.com>
4231
4232         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4233
4234 2019-01-02  Tom Tromey  <tom@tromey.com>
4235
4236         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4237         (tdesc_parse_xml): Remove cleanups.
4238         * target-descriptions.h (make_cleanup_free_target_description):
4239         Don't declare.
4240         (target_desc_deleter): New struct.
4241         (target_desc_up): New typedef.
4242         * target-descriptions.c (target_desc_deleter::operator()): Rename
4243         from free_target_description.
4244         (make_cleanup_free_target_description): Remove.
4245
4246 2019-01-02  Tom Tromey  <tom@tromey.com>
4247
4248         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4249         constructor, destructor.
4250         (linespec_parser): Remove typedef.
4251         (~linespec_parser): Rename from linespec_parser_delete.
4252         (linespec_lex_to_end, linespec_complete_label)
4253         (linespec_complete): Update.
4254         (decode_line_full): Remove cleanups.
4255         (decode_line_1): Update.
4256
4257 2019-01-02  Tom Tromey  <tom@tromey.com>
4258
4259         * python/python-internal.h (inferior_to_inferior_object): Change
4260         return type.
4261         * python/py-exitedevent.c (create_exited_event_object): Update.
4262         * python/py-inferior.c (inferior_to_inferior_object): Return
4263         gdbpy_ref.
4264         (python_new_inferior, python_inferior_deleted)
4265         (thread_to_thread_object, delete_thread_object)
4266         (build_inferior_list, gdbpy_selected_inferior): Update.
4267         * python/py-infthread.c (create_thread_object): Update.  Also fail
4268         if inferior_to_inferior_object fails.
4269
4270 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4271
4272         * inferior.h (class inferior) <displaced_step_state>: New field.
4273         * infrun.h (struct displaced_step_state): Move here from
4274         infrun.c.  Initialize fields, add constructor.
4275         <inf>: Remove field.
4276         <reset>: New method.
4277         * infrun.c (struct displaced_step_inferior_state): Move to
4278         infrun.h.
4279         (displaced_step_inferior_states): Remove.
4280         (get_displaced_stepping_state): Adust.
4281         (displaced_step_in_progress_any_inferior): Adjust.
4282         (displaced_step_in_progress_thread): Adjust.
4283         (displaced_step_in_progress): Adjust.
4284         (add_displaced_stepping_state): Remove.
4285         (get_displaced_step_closure_by_addr): Adjust.
4286         (remove_displaced_stepping_state): Remove.
4287         (infrun_inferior_exit): Call displaced_step_state.reset.
4288         (use_displaced_stepping): Don't check for NULL.
4289         (displaced_step_prepare_throw): Call
4290         get_displaced_stepping_state.
4291         (displaced_step_fixup): Don't check for NULL.
4292         (prepare_for_detach): Don't check for NULL.
4293
4294 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4295
4296         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4297          in case of call that did not complete.
4298
4299 2019-01-02  Andrey Utkin  <autkin@undo.io>
4300
4301         * symfile.c (find_separate_debug_file): Fix search of debug files for
4302         remote debuggee.
4303
4304 2019-01-02  Tom Tromey  <tom@tromey.com>
4305
4306         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4307         indentation.
4308         * python/py-frame.c (frapy_older): Remove cast.
4309         (frapy_newer): Likewise.
4310         * python/py-breakpoint.c (local_setattro): Remove cast.
4311         * python/py-arch.c (archpy_name): Remove local variable.
4312         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4313
4314 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4315
4316         * unittests/basic_string_view/element_access/char/empty.cc:
4317         Fix year range in copyright header.
4318
4319 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4320
4321         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4322         Delete.
4323         <operator==>: Update with for removed field.
4324         <hash>: Likewise.
4325         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4326         <isa_features>: ...this.
4327         <abi_features>: New field.
4328         (riscv_isa_flen): Update comment.
4329         (riscv_abi_xlen): New declaration.
4330         (riscv_abi_flen): New declaration.
4331         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4332         isa_features.
4333         (riscv_abi_xlen): New function.
4334         (riscv_isa_flen): Update to get answer from isa_features.
4335         (riscv_abi_flen): New function.
4336         (riscv_has_fp_abi): Update to get answer from abi_features.
4337         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4338         xlen and flen.
4339         (riscv_call_info) <xlen, flen>: Update comment.
4340         (riscv_call_arg_struct): Remove invalid assertions
4341         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4342         is removed.
4343         (riscv_gdbarch_init): Gather isa features and abi features
4344         separately, ensure both match on the gdbarch when reusing an old
4345         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4346         a target with 64-bit float hardware.
4347
4348 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4349
4350         * source.c (search_command_helper): Stop reverse search
4351         when line 1 has been searched.
4352
4353 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4354
4355         * record-full.c (record_full_base_target::close): Rewrite
4356         record_full_core_buf_list free logic.
4357
4358 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4359
4360         * break-catch-syscall.c (print_one_catch_syscall): xfree
4361         the last text.
4362
4363 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4364
4365         * top.c (print_gdb_version): Update Copyright year in version
4366         message.
4367
4368 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4369
4370         Update copyright year range in all GDB files.
4371
4372 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4373
4374         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4375
4376 For older changes see ChangeLog-2018.
4377 \f
4378 Local Variables:
4379 mode: change-log
4380 left-margin: 8
4381 fill-column: 74
4382 version-control: never
4383 coding: utf-8
4384 End:
4385