gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_resize_all)
   4         (tui_source_window_base::update_tab_width)
   5         (tui_adjust_win_heights): Update.
   6         (tui_win_info::make_invisible_and_set_new_height): Rename from
   7         make_invisible_and_set_new_height.
   8         * tui/tui-data.h (struct tui_win_info)
   9         <make_invisible_and_set_new_height>: New method.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui.c: Update.
  14         * tui/tui-source.h (struct tui_source_window): Move from
  15         tui-data.h.
  16         * tui/tui-layout.c: Update.
  17         * tui/tui-disasm.c: Update.
  18         * tui/tui-data.h (struct tui_source_window): Move to
  19         tui-source.h.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  24         tui-data.h.
  25         * tui/tui-data.h (struct tui_disasm_window): Move to
  26         tui-disasm.h.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-regs.h (struct tui_data_item_window): Move from
  31         tui-data.h.
  32         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  33         * tui/tui-data.h (struct tui_data_item_window): Move to
  34         tui-regs.h.
  35         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui.c: Update.
  40         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  41         (tui_cmd_window::max_height): Move to tui-command.c.
  42         * tui/tui-layout.c: Update.
  43         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  44         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  45         tui-command.c.
  46         * tui/tui-command.h (struct tui_cmd_window): Move from
  47         tui-data.h.
  48         * tui/tui-command.c: Remove "structuring" comments.
  49         (tui_cmd_window::clear_detail)
  50         (tui_cmd_window::do_make_visible_with_new_height)
  51         (tui_cmd_window::max_height): Move from elsewhere.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
  56         Now static.
  57         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
  58         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui.c: Update.
  63         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  64         tui-regs.c.
  65         * tui/tui-windata.h: Remove file.
  66         * tui/tui-windata.c: Remove file.
  67         * tui/tui-win.c (tui_data_window::set_new_height)
  68         (tui_data_window::do_make_visible_with_new_height): Move to
  69         tui-regs.c.
  70         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  71         * tui/tui-regs.c: Remove "structuring" comments.
  72         (tui_data_window::first_data_item_displayed)
  73         (tui_data_window::delete_data_content_windows)
  74         (tui_data_window::erase_data_content)
  75         (tui_data_window::display_all_data)
  76         (tui_data_window::refresh_all)
  77         (tui_data_window::do_scroll_vertical)
  78         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  79         (tui_data_window::do_make_visible_with_new_height)
  80         (tui_data_window::refresh_window): Move from elsewhere.
  81         (_initialize_tui_regs): Move to end of file.
  82         * tui/tui-layout.c: Update.
  83         * tui/tui-hooks.c: Update.
  84         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  85         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  86         tui-regs.c.
  87         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  92         seen.
  93
  94 2019-07-17  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-win.c (tui_source_window_base::set_new_height)
  97         (tui_source_window_base::do_make_visible_with_new_height): Use
  98         m_has_locator field directly.
  99         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 100         method.
 101         (struct tui_source_window_base) <has_locator>: Likewise.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 106         Don't declare.
 107         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 108         Remove.
 109         * tui/tui-win.c (tui_source_window_base::set_new_height)
 110         (tui_source_window_base::set_new_height)
 111         (make_invisible_and_set_new_height)
 112         (tui_source_window_base::do_make_visible_with_new_height)
 113         (tui_source_window_base::do_make_visible_with_new_height):
 114         Update.
 115         * tui/tui-layout.c (show_source_disasm_command, show_data)
 116         (show_source_or_disasm_and_command): Update.
 117         * tui/tui-layout.c (show_layout): Update.
 118
 119 2019-07-17  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-layout.c (make_data_window): Remove.
 122         (show_data): Unify creation and re-initialization cases.
 123
 124 2019-07-17  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-layout.c (make_source_window, make_disasm_window):
 127         Remove.
 128         (show_data): Unify creation and re-initialization cases.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-layout.c (make_command_window): Remove.
 133         (show_source_disasm_command, show_source_or_disasm_and_command):
 134         Unify creation and re-initialization cases.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 139         creation and re-initialization cases.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-regs.c (tui_get_register): Return void.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 148         Simplify.
 149
 150 2019-07-17  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 153         resetting.
 154
 155 2019-07-17  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 158         * tui/tui-regs.c (tui_reg_layout): New function.
 159         (tui_show_registers, tui_reg_command): Use it.
 160         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 161         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 162         parameters.
 163         (tui_layout_command): Remove.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-layout.h (tui/tui-layout): Return void.
 168         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-layout.c (show_source_disasm_command, show_data):
 173         Update.
 174         (reset_locator): Remove.
 175         (show_source_or_disasm_and_command): Update.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-source.c (tui_source_window_base::reset): Remove
 180         win_type parameter.
 181         * tui/tui-layout.c (make_command_window, make_source_window)
 182         (make_disasm_window, make_data_window)
 183         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 184         (reset_locator, show_source_or_disasm_and_command): Update.
 185         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 186         win_type parameter.
 187         (struct tui_source_window_base) <reset>: Likewise.
 188
 189 2019-07-17  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-layout.c (show_source_disasm_command): Use
 192         reset_locator.
 193         (reset_locator): New function.
 194         (init_and_make_win): Remove.
 195         (show_source_or_disasm_and_command): Use reset_locator.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 200         condition.
 201         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 202         Remove condition.
 203         * tui/tui-source.c (tui_source_window_base::reset): New method.
 204         * tui/tui-layout.c (make_command_window): Don't call
 205         init_and_make_win.
 206         (make_source_window, make_disasm_window): Don't call
 207         make_source_or_disasm_window.
 208         (make_data_window): Don't call init_and_make_win.  Change calling
 209         convention.
 210         (show_source_disasm_command, show_data): Simplify.
 211         (make_source_or_disasm_window): Remove.
 212         (show_source_or_disasm_and_command): Simplify.
 213         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 214         (struct tui_source_window_base) <reset>: Likewise.
 215         <execution_info>: Remove initializer.
 216         * tui/tui-data.c (tui_source_window_base): Initialize
 217         execution_info.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 222         variable.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui.c (tui_rl_other_window): Update.
 227         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 228         superclass method first.  Always iterate over regs_content.
 229         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 230         method.
 231         * tui/tui-win.c (tui_set_focus_command): Update.
 232
 233 2019-07-17  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-win.c (tui_set_focus_command): Rename from
 236         tui_set_focus.  Call tui_enable.
 237         (tui_set_focus_command): Remove.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 242         refresh_window.
 243         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 244         touchwin.
 245         (tui_data_window::refresh_window): Call refresh_window on data
 246         items.  Always call superclass refresh_window.
 247         (tui_win_info::refresh): Remove.
 248         (tui_source_window_base::refresh_window): Update.
 249         (tui_refresh_all): Update.
 250         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 251         refresh_window.
 252         (show_source_or_disasm_and_command): Likewise.
 253         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 254         (struct tui_source_window_base) <refresh>: Likewise.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-winsource.c (tui_clear_source_content)
 259         (tui_show_source_content): Update.
 260         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 261         whether content is empty.
 262         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 263         Remove.
 264
 265 2019-07-17  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 268         window's contents.
 269         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 270         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 275         (struct tui_data_item_window): Update.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 280         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 281         defines.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-winsource.h (tui_erase_source_content)
 286         (tui_clear_source_content): Remove "display_prompt" parameter.
 287         * tui/tui-winsource.c (tui_update_source_window_as_is)
 288         (tui_update_source_windows_with_addr): Update.
 289         (tui_clear_source_content): Remove "display_prompt" parameter.
 290         (tui_erase_source_content): Likewise.  Simplify.
 291         (tui_show_source_content): Update.
 292         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 293         * tui/tui-stack.c (tui_show_frame_info): Update.
 294         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 295         Remove defines.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 300         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 301         parameter.
 302         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 303         parameter.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.c (tui_clear_source_content)
 308         (tui_show_source_content, tui_show_exec_info_content)
 309         (tui_clear_exec_info_content): Update.
 310         * tui/tui-stack.c (tui_show_locator_content): Update.
 311         (tui_show_frame_info): Update.
 312         * tui/tui-source.h (tui_source_window): Don't declare.
 313         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 314         from tui_source_is_displayed.
 315         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 316         Remove field.
 317         (struct tui_source_window_base) <content_in_use>: New field.  Now
 318         bool.
 319         (struct tui_source_window) <showing_source_p>: New method.
 320         (TUI_SRC_WIN): Change cast.
 321         * tui/tui-data.c (tui_initialize_static_data): Update.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 326         location_matches_p.
 327         * tui/tui-source.c (tui_source_window::location_matches_p): New
 328         method.
 329         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 330         method.
 331         * tui/tui-data.h (struct tui_source_window_base)
 332         <location_matches_p>: New method.
 333         (struct tui_source_window, struct tui_disasm_window)
 334         <location_matches_p>: Likewise.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-win.c (tui_set_win_height_command): Rename from
 339         tui_set_win_height.
 340         (tui_set_win_height_command): Remove.
 341
 342 2019-07-17  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-source.c (tui_source_window): New constructor.  Add
 345         observer.
 346         (~tui_source_window): New destructor.
 347         (tui_source_window::style_changed): New method.
 348         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 349         (tui_attach_detach_observers): Update.
 350         * tui/tui-data.h (struct tui_source_window): Make constructor not
 351         inline.  Add destructor.
 352         (struct tui_source_window) <style_changed>: New method.
 353         <m_observable>: New member.
 354
 355 2019-07-17  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 358         * tui/tui-win.c (tui_resize_all): Fix typo.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 363         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 364         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 365         * tui/tui-win.c (window_name_completer): Use foreach.
 366         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 367         (update_tab_width): Likewise.
 368         * tui/tui-layout.c (show_layout): Update.
 369         * tui/tui-data.h (class tui_window_iterator): New.
 370         (struct all_tui_windows): New.
 371         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 376         parameter.  Don't reference globals.
 377         (tui_reg_command): Update.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-regs.c (tui_show_registers): Simplify.
 382
 383 2019-07-17  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-regs.c (tui_show_registers): Update.
 386         (tui_show_register_group): Add win_info parameter.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 391         Rename from tui_display_reg_element_at_line.
 392         (tui_data_window::display_registers_from_line): Update.
 393         * tui/tui-data.h (struct tui_data_window)
 394         <display_reg_element_at_line>: New method.
 395
 396 2019-07-17  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-regs.h (tui_display_registers_from)
 399         (tui_display_registers_from_line): Don't declare.
 400         * tui/tui-windata.c (tui_data_window::display_all_data)
 401         (tui_data_window::refresh_all)
 402         (tui_data_window::do_scroll_vertical): Update.
 403         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 404         from tui_display_registers_from.
 405         (tui_display_reg_element_at_line): Update.
 406         (tui_data_window::display_registers_from_line): Rename from
 407         tui_display_registers_from_line.
 408         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 409         display_registers_from_line>: New methods.
 410
 411 2019-07-17  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 414         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 415         from tui_erase_data_content.
 416         (tui_data_window::display_all_data)
 417         (tui_data_window::refresh_all)
 418         (tui_data_window::do_scroll_vertical): Update.
 419         * tui/tui-regs.c (tui_show_registers): Update.
 420         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 421         New method.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 426         declare.
 427         * tui/tui-windata.c
 428         (tui_data_window::delete_data_content_windows): Rename from
 429         tui_delete_data_content_windows.
 430         (tui_data_window::display_all_data)
 431         (tui_data_window::do_scroll_vertical): Update.
 432         * tui/tui-data.h (struct tui_data_window)
 433         <delete_data_content_windows>: New method.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 438         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 443         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 444         from tui_display_all_data.
 445         * tui/tui-win.c
 446         (tui_data_window::do_make_visible_with_new_height): Update.
 447         * tui/tui-regs.c (tui_show_registers): Update.
 448         * tui/tui-layout.c (tui_set_layout): Update.
 449         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 450         method.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 455         * tui/tui-windata.c (tui_display_data_from): Remove.
 456         (tui_data_window::refresh_all): Update.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 461         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 462         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 463         tui_display_registers_from_line.
 464         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 465         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 466         "force_display" parameter.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 471         declare.
 472         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 473         Rename from tui_first_reg_element_no_inline.
 474         (tui_display_reg_element_at_line)
 475         (tui_display_registers_from_line): Update.
 476         * tui/tui-data.h (struct tui_data_window)
 477         <first_reg_element_no_inline>: New method.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-windata.c (tui_display_data_from)
 482         (tui_data_window::do_scroll_vertical): Update.
 483         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 484         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 485         Rename from tui_line_from_reg_element_no.
 486         (tui_display_registers_from_line): Update.
 487         * tui/tui-data.h (struct tui_data_window)
 488         <line_from_reg_element_no>: New method.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 493         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 494         tui_last_regs_line_no.
 495         (tui_display_reg_element_at_line)
 496         (tui_display_registers_from_line): Update.
 497         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 498         method.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         PR tui/24722:
 503         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 504         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 505         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 506         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 507         (tui_update_breakpoint_info): Likewise.
 508         * tui/tui-hooks.c (tui_event_create_breakpoint)
 509         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 510         Update.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 515
 516 2019-07-17  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-winsource.c (tui_update_source_window_as_is)
 519         (tui_update_source_windows_with_addr): Update.
 520         * tui/tui-source.h (tui_set_source_content)
 521         (tui_show_symtab_source): Add "win_info" parameter.
 522         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 523         parameter.
 524         (tui_show_symtab_source): Likewise.
 525
 526 2019-07-17  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-wingeneral.c
 529         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 530
 531 2019-07-17  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 534         (struct tui_cmd_window) <can_scroll>: New method.
 535         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 536         method.
 537
 538 2019-07-17  Tom Tromey  <tromey@adacore.com>
 539
 540         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 541         do_field_signed>: Rename.  Change type of "value".
 542         * ui-out.c (ui_out::field_signed): Rename from field_int.
 543         Change type of "value".
 544         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 545         type of "value".
 546         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 547         do_field_int.  Change type of "value".
 548         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 549         do_field_int.  Change type of "value".
 550         * tracepoint.c (trace_status_mi, tfind_1)
 551         (print_one_static_tracepoint_marker): Update.
 552         * thread.c (print_thread_info_1, print_selected_thread_frame):
 553         Update.
 554         * stack.c (print_frame, print_frame_info): Update.
 555         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 556         Update.
 557         * source.c (print_source_lines_base): Update.
 558         * skip.c (info_skip_command): Update.
 559         * record-btrace.c (btrace_ui_out_decode_error)
 560         (btrace_call_history_src_line): Update.
 561         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 562         Update.
 563         * progspace.c (print_program_space): Update.
 564         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 565         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 566         do_field_int.  Change type of "value".
 567         * mi/mi-out.c (mi_ui_out::do_table_begin)
 568         (mi_ui_out::do_table_header): Update.
 569         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 570         type of "value".
 571         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 572         (mi_cmd_data_list_changed_registers, output_register)
 573         (mi_cmd_data_read_memory, mi_load_progress)
 574         (mi_cmd_trace_frame_collected): Update.
 575         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 576         Update.
 577         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 578         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 579         (mi_cmd_var_list_children, varobj_update_one): Update.
 580         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 581         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 582         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 583         * inferior.c (print_inferior): Update.
 584         * gdb_bfd.c (print_one_bfd): Update.
 585         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 586         Update.
 587         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 588         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 589         do_field_int.  Change type of "value".
 590         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 591         do_field_int.  Change type of "value".
 592         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 593         (print_one_breakpoint_location, print_it_catch_fork)
 594         (print_one_catch_fork, print_it_catch_vfork)
 595         (print_one_catch_vfork, print_it_catch_solib)
 596         (print_it_catch_exec, print_it_ranged_breakpoint)
 597         (print_mention_watchpoint, print_mention_masked_watchpoint)
 598         (bkpt_print_it, update_static_tracepoint): Update.
 599         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 600         * break-catch-syscall.c (print_it_catch_syscall): Update.
 601         * ada-tasks.c (print_ada_task_info): Update.
 602         * ada-lang.c (print_it_exception, print_mention_exception):
 603         Update.
 604
 605 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 606
 607         PR breakpoints/24541
 608         * gdbarch.c: Regenerate.
 609         * gdbarch.h: Regenerate.
 610         * gdbarch.sh: Adjust return type and parameter types for
 611         'stap_adjust_register'.
 612         (i386_stap_adjust_register): Adjust signature and return new
 613         register name.
 614         * stap-probe.c (stap_parse_register_operand): Adjust use of
 615         'gdbarch_stap_adjust_register'.
 616
 617 2019-07-17  Tom Tromey  <tromey@adacore.com>
 618
 619         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 620         declare VEC.
 621         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 622         std::vector.
 623         (struct s390_process_info): Add initializers.
 624         (s390_add_process): Use new.
 625         (s390_linux_nat_target::low_forget_process): Use delete.
 626         (s390_linux_nat_target::low_new_fork)
 627         (s390_linux_nat_target::stopped_by_watchpoint)
 628         (s390_linux_nat_target::low_prepare_to_resume)
 629         (s390_linux_nat_target::insert_watchpoint)
 630         (s390_linux_nat_target::insert_hw_breakpoint)
 631         (s390_linux_nat_target::remove_watchpoint)
 632         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 633
 634 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 635
 636         * aarch64-fbsd-nat.c: Include regcache.h.
 637         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 638         argument.
 639         (aarch64_fbsd_nat_target::fetch_registers)
 640         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 641         variable.
 642         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 643
 644 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 645
 646         * fbsd-nat.c: Include gdbarch.h.
 647
 648 2019-07-15  Tom Tromey  <tromey@adacore.com>
 649
 650         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 651
 652 2019-07-15  Tom Tromey  <tromey@adacore.com>
 653
 654         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 655         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 656         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 657         * cli-out.c (cli_ui_out::do_field_int): New method.
 658         * ui-out.c (ui_out::field_unsigned): New method.
 659         * symfile.c (generic_load): Use field_unsigned.
 660         (print_transfer_performance): Likewise.
 661         * record-btrace.c (ui_out_field_uint): Remove.
 662         (btrace_call_history_insn_range, btrace_call_history): Use
 663         field_unsigned.
 664         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 665         field_unsigned.
 666         * ui-out.h (class ui_out) <field_unsigned>: New method.
 667         <do_field_unsigned>: Likewise.
 668
 669 2019-07-15  Tom Tromey  <tromey@adacore.com>
 670
 671         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 672         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 673         * target.c (flash_erase_command): Use field_string.
 674         * infrun.c (print_signal_received_reason): Use field_string.
 675         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 676         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 677         field_string.
 678         * ada-tasks.c (print_ada_task_info): Use field_string.
 679
 680 2019-07-15  Tom Tromey  <tromey@adacore.com>
 681
 682         * target.c (flash_erase_command): Use field_core_addr.
 683         * symfile.c (generic_load): Use field_core_addr.
 684         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 685         Use field_core_addr.
 686         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 687         field_core_addr.
 688
 689 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 692         value if its desired type is smaller than a CORE_ADDR and signed.
 693
 694 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 697         of changes to field names, and use new is_reference field to
 698         decide if a property is a reference or not.
 699         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 700         field.
 701         (struct dwarf2_property_baton): Update header comment, rename
 702         'referenced_type' to 'property_type' and update comments.
 703         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 704         default property type, store in property baton, update to take
 705         accound of renamed field.
 706         (read_func_scope): Update call to attr_to_dynamic_prop.
 707         (read_array_type): Likewise.
 708         (dwarf2_per_cu_addr_sized_int_type): New function.
 709         (read_subrange_index_type): Move type finding code to
 710         dwarf2_per_cu_addr_sized_int_type.
 711         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 712         (dwarf2_per_cu_addr_type): New function.
 713         (set_die_type): Update calls to attr_to_dynamic_prop.
 714
 715 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * dwarf2read.c (read_subrange_index_type): New function.
 718         (read_subrange_type): Move code into new function and call it.
 719         * gdbtypes.c (create_range_type): Add some asserts.
 720
 721 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 724         update return statements.
 725         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 726         declaration, and update comment to match.
 727         * gdbtypes.c (resolve_dynamic_array): Update call to
 728         dwarf2_evaluate_property to match new return type.
 729
 730 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * valarith.c (value_subscripted_rvalue): Change lowerbound
 733         parameter type from int to LONGEST.
 734         * value.h (value_subscripted_rvalue): Likewise in declaration.
 735
 736 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * cli/cli-utils.c (info_print_command_completer): New function.
 739         * cli/cli-utils.h: Add 'completer.h' include, and forward
 740         declaration for 'struct cmd_list_element'.
 741         (info_print_command_completer): Declare.
 742         * stack.c (_initialize_stack): Add completer for 'info locals' and
 743         'info args'.
 744         * symtab.c (_initialize_symtab): Add completer for 'info
 745         variables' and 'info functions'.
 746         * NEWS: Mention completion for additional info commands.
 747
 748 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * cli/cli-utils.c (extract_info_print_args): Delete.
 751         (extract_arg_maybe_quoted): Delete.
 752         (info_print_options_defs): New variable.
 753         (make_info_print_options_def_group): New function.
 754         (extract_info_print_options): Define new function.
 755         * cli/cli-utils.h (extract_info_print_args): Delete.
 756         (struct info_print_options): New structure.
 757         (extract_info_print_options): Declare new function.
 758         * stack.c (info_locals_command): Update to use new
 759         extract_info_print_options, also add a header comment.
 760         (info_args_command): Likewise.
 761         * symtab.c (info_variables_command): Likewise.
 762         (info_functions_command): Likewise.
 763
 764 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 765
 766         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 767         to extract string arguments.
 768         * common/common-utils.c (extract_string_maybe_quoted): New function.
 769         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 770
 771 2019-07-11  Tom Tromey  <tromey@adacore.com>
 772
 773         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 774         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 775         * top.h (gdbinit): Don't declare.
 776         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 777         into...
 778         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 779         * top.c (gdb_init): Don't call init_cli_cmds.
 780         (gdbinit): Remove.
 781         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 782
 783 2019-07-11  Tom Tromey  <tromey@adacore.com>
 784
 785         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 786         after it has been moved.
 787
 788 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 789
 790         * valops.c (value_must_coerce_to_target): Change return type to
 791         bool.
 792         * value.h (value_must_coerce_to_target): Likewise.
 793
 794 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 795
 796         * breakpoint.c (is_hardware_watchpoint): Remove
 797         forward-declaration.
 798         (is_masked_watchpoint): Change return type to bool.
 799         (is_tracepoint): Likewise.
 800         (is_breakpoint): Likewise.
 801         (is_hardware_watchpoint): Likewise.
 802         (is_watchpoint): Likewise.
 803         (is_no_memory_software_watchpoint): Likewise.
 804         (is_catchpoint): Likewise.
 805         (breakpoint_1): Make FILTER parameter's return type bool.
 806         is_masked_watchpoint): Change return type to bool.
 807         (save_breakpoints): Make FILTER parameter's return type bool.
 808         * breakpoint.h (is_breakpoint): Change return type to bool.
 809         (is_watchpoint): Likewise.
 810         (is_catchpoint): Likewise.
 811         (is_tracepoint): Likewise.
 812
 813 2019-07-10  Tom Tromey  <tom@tromey.com>
 814
 815         * defs.h: Don't include gdbarch.h.
 816         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 817         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 818         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 819         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 820         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 821         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 822         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 823         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 824         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 825         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 826         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 827         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 828         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 829         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 830         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 831         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 832         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 833         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 834         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 835         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 836         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 837         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 838         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 839         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 840         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 841         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 842         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 843
 844 2019-07-10  Tom Tromey  <tromey@adacore.com>
 845
 846         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 847         * breakpoint.c (init_ada_exception_breakpoint): Register as
 848         bp_catchpoint.
 849         (print_one_breakpoint_location, print_one_breakpoint): Use
 850         is_ada_exception_catchpoint.
 851         * ada-lang.c (class ada_catchpoint_location): Pass
 852         bp_loc_software_breakpoint to bp_location constructor.
 853         (is_ada_exception_catchpoint): New function.
 854
 855 2019-07-10  Tom Tromey  <tromey@adacore.com>
 856
 857         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 858         VEC.
 859         (struct arm_exidx_entry): New method operator<.
 860         (struct arm_exidx_data) <section_maps>: Change type.
 861         (arm_exidx_data_free): Remove.
 862         (arm_exidx_data_key): Change type.  Move lower.
 863         (arm_exidx_new_objfile): Update.
 864         (arm_compare_exidx_entries): Remove.
 865         (arm_find_exidx_entry, _initialize_arm_tdep)
 866
 867 2019-07-10  Tom Tromey  <tromey@adacore.com>
 868
 869         * solib-spu.c (ocl_program_data_key): Change type.
 870         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 871         Update.
 872
 873 2019-07-10  Tom Tromey  <tromey@adacore.com>
 874
 875         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 876         (struct solib_aix_inferior_data) <library_list>: Change type.
 877         (solib_aix_inferior_data_handle): Change type.
 878         (get_solib_aix_inferior_data): Update.
 879         (solib_aix_free_library_list): Remove.
 880         (library_list_start_library): Update.
 881         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 882         return type.
 883         (solib_aix_get_library_list)
 884         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 885         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 886
 887 2019-07-10  Tom Tromey  <tromey@adacore.com>
 888
 889         * solib-dsbt.c (struct dsbt_info): Add initializers.
 890         (solib_dsbt_pspace_data): Change type.
 891         (dsbt_pspace_data_cleanup): Remove.
 892         (get_dsbt_info, _initialize_dsbt_solib): Update.
 893
 894 2019-07-10  Tom Tromey  <tromey@adacore.com>
 895
 896         * spu-tdep.c (spu_overlay_data): Change type.
 897         (spu_get_overlay_table, spu_overlay_new_objfile)
 898         (_initialize_spu_tdep): Update.
 899
 900 2019-07-10  Tom Tromey  <tromey@adacore.com>
 901
 902         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 903         destructor.
 904         (dbx_objfile_data_key): Change type and declare later.
 905         (DBX_SYMFILE_INFO): Rewrite.
 906         * dbxread.c (dbx_objfile_data_key): Change type.
 907         (dbx_symfile_init): Update.
 908         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 909         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 910         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 911
 912 2019-07-10  Tom Tromey  <tromey@adacore.com>
 913
 914         * jit.c (jit_program_space_key): Change type.  Move lower.
 915         (get_jit_program_space_data): Update.
 916         (jit_program_space_data_cleanup): Remove.
 917         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 918         Update.
 919         (struct jit_program_space_data): Add initializers.
 920
 921 2019-07-10  Tom Tromey  <tromey@adacore.com>
 922
 923         * solib-darwin.c (struct darwin_info): Add initializers.
 924         (solib_darwin_pspace_data): Change type.
 925         (darwin_pspace_data_cleanup): Remove.
 926         (get_darwin_info, _initialize_darwin_solib): Update.
 927
 928 2019-07-10  Tom Tromey  <tromey@adacore.com>
 929
 930         * remote-sim.c (struct sim_inferior_data): Add initializers,
 931         constructor, and destructor.
 932         (sim_inferior_data_key): Change type.  Move lower.
 933         (check_for_duplicate_sim_descriptor): Update.
 934         (get_sim_inferior_data): Use new.  Update.
 935         (~sim_inferior_data_cleanup): Rename from
 936         sim_inferior_data_cleanup.  Simplify.
 937         (gdbsim_close_inferior, simulator_command)
 938         (sim_command_completer, _initialize_remote_sim): Update.
 939         (next_pid, INITIAL_PID): Move earlier.
 940
 941 2019-07-10  Tom Tromey  <tromey@adacore.com>
 942
 943         * python/python-internal.h (create_thread_object): Return
 944         gdbpy_ref.
 945         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 946         * python/py-inferior.c (struct threadlist_entry): Add
 947         constructor.
 948         <thread_obj>: Now a gdbpy_ref.
 949         (thread_to_thread_object): Update.
 950         (add_thread_object): Use new.
 951         (delete_thread_object): Use delete.
 952         (infpy_threads): Update.
 953         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 954         GIL.
 955
 956 2019-07-10  Tom Tromey  <tromey@adacore.com>
 957
 958         * valops.c (value_cast): Specialize error message for Ada.
 959
 960 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 961
 962         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 963
 964 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 965
 966         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 967         bpstat_should_step): Return bool, adjust comments.
 968         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 969         bpstat_should_step): Likewise.
 970
 971 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 972
 973         * features/Makefile: Use feature target descriptions for Arm.
 974         * features/arm/arm-core.c: Generate new file.
 975         * features/arm/arm-fpa.c: Likewise.
 976         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 977         * features/arm/arm-m-profile.c: Likewise.
 978         * features/arm/arm-vfpv2.c: Likewise.
 979         * features/arm/arm-vfpv3.c: Likewise.
 980         * features/arm/xscale-iwmmxt.c: Likewise.
 981         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 982
 983 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 984
 985         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 986         ptrace earlier.
 987
 988 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 989
 990         * features/aarch64-pauth.c: Regenerate.
 991
 992 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 993
 994         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 995         bool.
 996         (bpstat_what): Use false instead of 0.
 997
 998 2019-07-09  Pedro Alves  <palves@redhat.com>
 999
1000         * break-catch-throw.c (is_exception_catchpoint): New.
1001         * breakpoint.c (print_one_breakpoint_location): New parameter
1002         'raw_loc'.  Handle it.  Use
1003         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1004         looking at the breakpoint's type.
1005         (print_one_breakpoint): If handling "maint info breakpoints", also
1006         print locations of exception catchpoints.
1007         * breakpoint.h (is_exception_catchpoint): Declare.
1008
1009 2019-07-09  Pedro Alves  <palves@redhat.com>
1010
1011         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1012         "addr" field.
1013         (allocate_location_exception_catchpoint): New.
1014         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1015         (initialize_throw_catchpoint_ops): Install
1016         allocate_location_exception_catchpoint as allocate_location
1017         method.
1018         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1019         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1020         bp_loc_other.
1021         (breakpoint_address_is_meaningful): Delete.
1022         (bl_address_is_meaningful): New.
1023         (breakpoint_locations_match): Adjust comment.
1024         (bp_location_from_bp_type): New, factored out of...
1025         (bp_location::bp_location(breakpoint *)): ... this.
1026         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1027         factored out of...
1028         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1029         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1030         breakpoint_address_is_meaningful.
1031         (bp_locations_compare): Adjust comment.
1032         (update_global_location_list): Use bl_address_is_meaningful
1033         instead of breakpoint_address_is_meaningful.
1034         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1035         explicit.
1036         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1037         * python/py-breakpoint.c (bppy_get_location): No longer check
1038         whether location is null.
1039
1040 2019-07-09  Pedro Alves  <palves@redhat.com>
1041
1042         PR c++/15468
1043         * breakpoint.c (print_one_breakpoint_location): Remove
1044         single-location assert.
1045
1046 2019-07-09  Tom Tromey  <tom@tromey.com>
1047
1048         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1049         * configure: Rebuild.
1050         * configure.ac: Change common to gdbsupport.
1051         * gdbsupport: Rename from common.
1052         * acinclude.m4: Change common to gdbsupport.
1053         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1054         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1055         gdbsupport.
1056         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1057         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1058         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1059         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1060         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1061         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1062         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1063         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1064         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1065         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1066         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1067         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1068         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1069         coff-pe-read.c, command.h, compile/compile-c-support.c,
1070         compile/compile-c.h, compile/compile-cplus-symbols.c,
1071         compile/compile-cplus-types.c, compile/compile-cplus.h,
1072         compile/compile-loc2c.c, compile/compile.c, completer.c,
1073         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1074         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1075         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1076         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1077         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1078         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1079         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1080         features/aarch64-core.c, features/aarch64-fpu.c,
1081         features/aarch64-pauth.c, features/aarch64-sve.c,
1082         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1083         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1084         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1085         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1086         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1087         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1088         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1089         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1090         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1091         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1092         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1093         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1094         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1095         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1096         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1097         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1098         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1099         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1100         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1101         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1102         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1103         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1104         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1105         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1106         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1107         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1108         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1109         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1110         minsyms.c, mips-linux-tdep.c, namespace.h,
1111         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1112         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1113         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1114         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1115         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1116         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1117         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1118         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1119         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1120         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1121         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1122         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1123         procfs.c, producer.c, progspace.h, psymtab.h,
1124         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1125         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1126         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1127         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1128         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1129         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1130         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1131         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1132         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1133         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1134         target-memory.c, target.c, target.h, target/waitstatus.c,
1135         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1136         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1137         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1138         unittests/array-view-selftests.c,
1139         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1140         unittests/common-utils-selftests.c,
1141         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1142         unittests/format_pieces-selftests.c,
1143         unittests/function-view-selftests.c,
1144         unittests/lookup_name_info-selftests.c,
1145         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1146         unittests/mkdir-recursive-selftests.c,
1147         unittests/observable-selftests.c,
1148         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1149         unittests/parse-connection-spec-selftests.c,
1150         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1151         unittests/scoped_fd-selftests.c,
1152         unittests/scoped_mmap-selftests.c,
1153         unittests/scoped_restore-selftests.c,
1154         unittests/string_view-selftests.c, unittests/style-selftests.c,
1155         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1156         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1157         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1158         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1159         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1160         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1161
1162 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1165         bool value.
1166         (decode_digits_ordinary): Set explicit_line field in sal.
1167         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1168         symtab_and_line that was set on an explicit line number in
1169         assembler code.  Do always update the recorded symtab and line if
1170         we do skip the prologue.
1171
1172 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * breakpoint.c (set_breakpoint_location_function): Remove
1175         explicit_loc parameter.
1176         (momentary_breakpoint_from_master): Update call to
1177         set_breakpoint_location_function.
1178         (add_location_to_breakpoint): Likewise.
1179
1180 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1183         required features based on default bfd type when no specific bfd
1184         is present.
1185
1186 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1187
1188         * NEWS: Mention that GDB printf and eval commands can now print
1189         C-style and Ada-style convenience var strings without
1190         calling the inferior.
1191         * printcmd.c (printf_c_string): Locally print GDB internal var
1192         instead of transiting via the inferior.
1193         (printf_wide_c_string): Likewise.
1194
1195 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1196
1197         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1198
1199 2019-07-04  Tom Tromey  <tom@tromey.com>
1200
1201         PR tui/24724:
1202         * tui/tui-winsource.c (tui_clear_source_content): Update.
1203         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1204         (tui_update_breakpoint_info): Update.
1205         (tui_set_exec_info_content): Update.
1206         * tui/tui-source.c (tui_set_source_content_nil): Update.
1207         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1208         has_break.
1209         * tui/tui-data.h (enum tui_bp_flag): New.
1210         (tui_bp_flags): New enum flags type.
1211         (struct tui_source_element) <break_mode>: Change type.  Rename
1212         from has_break.
1213         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1214         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1215         constants.
1216         * tui/tui-winsource.h: Fix comment.
1217
1218 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1219
1220         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1221         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1222         (store_fpregs_to_thread)
1223         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1224         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1225         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1226         (IWMMXT_REGS_SIZE): Add define.
1227         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1228         (fetch_vfp_regs, store_vfp_regs)
1229         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1230         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1231
1232 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1233
1234         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1235         defines.
1236         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1237         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1238         (ARM_INT_REGISTER_SIZE): ...to this.
1239         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1240         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1241         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1242         (arm_linux_collect_gregset, supply_nwfpe_register)
1243         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1244         defines.
1245         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1246         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1247         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1248         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1249         (arm_return_in_memory, arm_store_return_value)
1250         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1251         (arm_record_ld_st_multiple): Likewise.
1252         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1253         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1254
1255 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1258         AARCH64_DISPLACED_MODIFIED_INSNS.
1259         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1260         (aarch64_displaced_step_copy_insn): Likewise.
1261         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1262         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1263         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1264         ARM_DISPLACED_MODIFIED_INSNS.
1265         * arm-tdep.c (arm_gdbarch_init): Likewise.
1266         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1267         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1268         (struct arm_displaced_step_closure): Use
1269         ARM_DISPLACED_MODIFIED_INSNS.
1270
1271 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1272
1273         * features/Makefile: Remove unused xml files.
1274         * features/aarch64.xml: Remove.
1275         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1276         * features/i386/amd64-avx-avx512.xml: Remove.
1277         * features/i386/amd64-avx-linux.xml: Remove.
1278         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1279         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1280         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1281         * features/i386/amd64-avx-mpx.xml: Remove.
1282         * features/i386/amd64-avx.xml: Remove.
1283         * features/i386/amd64-linux.xml: Remove.
1284         * features/i386/amd64-mpx-linux.xml: Remove.
1285         * features/i386/amd64-mpx.xml: Remove.
1286         * features/i386/amd64.xml: Remove.
1287         * features/i386/i386-avx-avx512-linux.xml: Remove.
1288         * features/i386/i386-avx-avx512.xml: Remove.
1289         * features/i386/i386-avx-linux.xml: Remove.
1290         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1291         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1292         * features/i386/i386-avx-mpx-linux.xml: Remove.
1293         * features/i386/i386-avx-mpx.xml: Remove.
1294         * features/i386/i386-avx.xml: Remove.
1295         * features/i386/i386-linux.xml: Remove.
1296         * features/i386/i386-mmx-linux.xml: Remove.
1297         * features/i386/i386-mmx.xml: Remove.
1298         * features/i386/i386-mpx-linux.xml: Remove.
1299         * features/i386/i386-mpx.xml: Remove.
1300         * features/i386/i386.xml: Remove.
1301         * features/i386/x32-avx-avx512-linux.xml: Remove.
1302         * features/i386/x32-avx-linux.xml: Remove.
1303         * features/i386/x32-linux.xml: Remove.
1304
1305 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * regformats/aarch64.dat: Remove.
1308         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1309         * regformats/i386/amd64-avx-linux.dat: Remove.
1310         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1311         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1312         * regformats/i386/amd64-linux.dat: Remove.
1313         * regformats/i386/amd64-mpx-linux.dat: Remove.
1314         * regformats/i386/amd64.dat: Remove.
1315         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1316         * regformats/i386/i386-avx-linux.dat: Remove.
1317         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1318         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1319         * regformats/i386/i386-linux.dat: Remove.
1320         * regformats/i386/i386-mmx-linux.dat: Remove.
1321         * regformats/i386/i386-mpx-linux.dat: Remove.
1322         * regformats/i386/i386.dat: Remove.
1323         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1324         * regformats/i386/x32-avx-linux.dat: Remove.
1325         * regformats/i386/x32-linux.dat: Remove.
1326
1327 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1328
1329         * aarch64-tdep.c: Remove xml self tests.
1330         * amd64-linux-tdep.c: Likewise.
1331         * amd64-tdep.c: Likewise.
1332         * i386-linux-tdep.c: Likewise.
1333         * i386-tdep.c: Likewise.
1334
1335 2019-07-03  Pedro Alves  <palves@redhat.com>
1336
1337         PR cli/24732
1338         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1339         (pipe_cmd_option_defs): New.
1340         (make_pipe_cmd_options_def_group): New.
1341         (pipe_command): Use gdb::option::process_options.
1342         (pipe_command_completer): New function.
1343         (_initialize_cli_cmds): Install completer for "pipe" command.
1344
1345 2019-07-03  Pedro Alves  <palves@redhat.com>
1346
1347         * cli/cli-option.c (union option_value) <string>: New field.
1348         (struct option_def_and_value): Add ctor, move ctor, dtor and
1349         use DISABLE_COPY_AND_ASSIGN.
1350         (option_def_and_value::clear_value): New.
1351         (parse_option, save_option_value_in_ctx, get_val_type_str)
1352         (add_setshow_cmds_for_options): Handle var_string.
1353         * cli-option.h (union option_def::var_address) <string>: New
1354         field.
1355         (struct string_option_def): New.
1356         * maint-test-options.c (struct test_options_opts): Add default
1357         ctor and use DISABLE_COPY_AND_ASSIGN.
1358         <string_opt>: New field.
1359         (test_options_opts::~test_options_opts): New.
1360         (test_options_opts::dump): Also dump "-string".
1361         (test_options_option_defs): Install "string.
1362
1363 2019-07-03  Pedro Alves  <palves@redhat.com>
1364
1365         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1366         option_value with a null enumeration.
1367         (complete_options): Save the option values in the context.
1368         (save_option_value_in_ctx): New, factored out from ...
1369         (process_options): ... here.
1370         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1371         of the function.
1372         * maint-test-options.c (test_options_opts::dump): New, factored
1373         out from ...
1374         (maintenance_test_options_command_mode): ... here.
1375         (maintenance_test_options_command_completion_result): Delete.
1376         (maintenance_test_options_command_completion_text): Update
1377         comment.
1378         (maintenance_show_test_options_completion_result): Change
1379         prototype.  Just print
1380         maintenance_test_options_command_completion_text.
1381         (save_completion_result): New.
1382         (maintenance_test_options_completer_mode): Pass options context to
1383         complete_options, and then save a dump.
1384         (_initialize_maint_test_options): Use add_cmd to install "maint
1385         show test-options-completion-result".
1386
1387 2019-07-03  Pedro Alves  <palves@redhat.com>
1388
1389         * NEWS (New commands): Mention "with" and "maint with".
1390         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1391         (with_command, with_command_completer): New.
1392         (pipe_command): Adjust to new repeat_previous
1393         interface.
1394         (_initialize_cli_cmds): Install the "with" command and its "w"
1395         alias.
1396         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1397         declarations.
1398         * cli/cli-setshow.c (parse_cli_var_uinteger)
1399         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1400         argument strings for all var_types.
1401         (get_setshow_command_value_string): New, factored out from ...
1402         (do_show_command): ... this.
1403         * cli/cli-setshow.h: Include <string>.
1404         (get_setshow_command_value_string): Declare.
1405         * command.h (repeat_previous): Now returns const char *.  Adjust
1406         comment.
1407         * maint.c: Include "cli/cli-cmds.h".
1408         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1409         (_initialize_maint_cmds): Register the "maintenance with" command.
1410         * top.c (repeat_previous): Move bits from pipe_command here:
1411         Return the saved command line, if any; error out if there's no
1412         command to relaunch.
1413
1414 2019-07-03  Pedro Alves  <palves@redhat.com>
1415
1416         * NEWS (New commands): Mention "maint set/show test-settings"
1417         instead of "maint test-settings".
1418         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1419         (maintenance_test_settings_set_list): Rename to ...
1420         (maintenance_set_test_settings_list): ... this.
1421         (maintenance_test_settings_show_list): Rename to  ...
1422         (maintenance_show_test_settings_list): ... this.
1423         (maintenance_test_settings_cmd): Delete.
1424         (maintenance_test_settings_set_cmd): ...
1425         (maintenance_set_test_settings_cmd): ... this.
1426         (maintenance_test_settings_show_cmd): ...
1427         (maintenance_show_test_settings_cmd): ... this.
1428         (maintenance_test_settings_show_value_cmd):
1429         (maintenance_show_test_settings_value_cmd): ... this.
1430         (_initialize_maint_test_settings): No longer install the "maint
1431         test-settings" prefix command.  Rename "maint test-settings set"
1432         to "maint set test-settings", and "maint test-settings show" to
1433         "maint show test-settings".  Adjust all subcommands.
1434
1435 2019-07-03  Pedro Alves  <palves@redhat.com>
1436
1437         * maint-test-settings.c: Fix file's intro comment.  Replace all
1438         references to "test-options" with references to "test-settings",
1439         in comments.
1440
1441 2019-07-03  Pedro Alves  <palves@redhat.com>
1442
1443         * maint-test-settings.c (maintenance_test_settings_xxx)
1444         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1445         New.
1446         (maintenance_test_settings_enums): Use them.
1447         (maintenance_test_settings_enum): Default to
1448         maintenance_test_settings_xxx.
1449         (_initialize_maint_test_settings): Initialize
1450         MAINTENANCE_TEST_SETTINGS_FILENAME.
1451
1452 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1453
1454         * breakpoint.h (remove_breakpoints_inf): Change return type to
1455         void, move function documentation here.
1456         * breakpoint.c (remove_breakpoints_inf): Change return type to
1457         void, move function documentation to header.
1458
1459 2019-07-02  Pedro Alves  <palves@redhat.com>
1460
1461         * NEWS (Completion improvements): Mention "info threads".
1462         * thread.c (struct info_threads_opts, info_threads_option_defs)
1463         (make_info_threads_options_def_group): New.
1464         (info_threads_command): Use gdb::option::process_options.
1465         (info_threads_command_completer): New.
1466         (_initialize_thread): Use gdb::option::build_help to build the
1467         help text for "info threads".
1468
1469 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1470
1471         * defs.h (generic_load): Move from here...
1472         * symfile.h (generic_load): ... to here.  Rename name parameter
1473         to args.
1474         * symfile.c (generic_load): Add comment.
1475
1476 2019-07-01  Tom Tromey  <tromey@adacore.com>
1477
1478         * dwarf2read.c
1479         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1480         declaration of without_params.  Fix formatting.
1481
1482 2019-07-01  Tom Tromey  <tromey@adacore.com>
1483
1484         * ada-exp.y (find_primitive_type): Update.
1485         * ada-lang.h (ada_lookup_symbol): Update.
1486         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1487         parameter.
1488         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1489
1490 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1491
1492         PR breakpoints/24541
1493         * gdbarch.c: Regenerate.
1494         * gdbarch.h: Regenerate.
1495         * gdbarch.sh: Add 'stap_adjust_register'.
1496         * i386-tdep.c: Include '<unordered_set>'.
1497         (i386_stap_adjust_register): New function.
1498         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1499         * stap-probe.c (stap_parse_register_operand): Call
1500         'gdbarch_stap_adjust_register'.
1501
1502 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1503
1504         PR python/24742
1505         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1506         * python/python.c (do_start_initialization): Use 'xmalloc'
1507         instead of 'PyMem_Malloc'.
1508
1509 2019-06-28  Tom Tromey  <tromey@adacore.com>
1510
1511         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1512         for Ada.
1513
1514 2019-06-27  Tom Tromey  <tromey@adacore.com>
1515
1516         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1517         objfile_key.
1518         (arm_find_mapping_symbol, arm_record_special_symbol)
1519         (_initialize_arm_tdep): Update.
1520         (arm_objfile_data_free): Remove.
1521
1522 2019-06-27  Tom Tromey  <tromey@adacore.com>
1523
1524         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1525         to cp_print_static_field.
1526
1527 2019-06-26  Tom Tromey  <tromey@adacore.com>
1528
1529         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1530         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1531         declare.
1532
1533 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1534
1535         * features/aarch64-core.c (create_feature_aarch64_core):
1536         Regenerate.
1537         * features/aarch64-core.xml: Add cpsr flags.
1538
1539 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1540
1541         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1542         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1543
1544 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1545
1546         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1547         field.
1548         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1549         use.
1550         (arm_record_special_symbol): Don't insert new symbol in sorted
1551         position, push it at the end.
1552
1553 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1554
1555         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1556         (arm_mapping_symbol_s): Remove.
1557         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1558         (arm_mapping_symbol_vec): New typedef.
1559         (struct arm_per_objfile): Add constructor.
1560         <section_maps>: Change type to
1561         std::unique_ptr<arm_mapping_symbol_vec[]>.
1562         (arm_compare_mapping_symbols): Remove.
1563         (arm_find_mapping_symbol): Adjust to section_maps type change.
1564         (arm_objfile_data_free): Call delete on arm_per_objfile.
1565         (arm_record_special_symbol): Adjust to section_maps type change.
1566         Allocate arm_per_objfile with new.
1567
1568 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1569
1570         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1571         with the command prefix.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1576         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1577
1578 2019-06-25  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1581         type.
1582         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1583         protected.
1584
1585 2019-06-25  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-winsource.c
1588         (tui_source_window_base::set_is_exec_point_at): Add check against
1589         LOA_ADDRESS.
1590
1591 2019-06-25  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-source.c (tui_set_source_content): Don't check before
1594         xfree.
1595         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-winsource.h (tui_update_source_window_as_is)
1600         (tui_alloc_source_buffer, tui_line_is_displayed)
1601         (tui_addr_is_displayed): Change type of win_info.
1602         * tui/tui-winsource.c (tui_update_source_window_as_is)
1603         (tui_clear_source_content, tui_show_source_line)
1604         (tui_show_source_content, tui_source_window_base::refill)
1605         (tui_source_window_base::set_is_exec_point_at)
1606         (tui_source_window_base::set_is_exec_point_at)
1607         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1608         (tui_alloc_source_buffer, tui_line_is_displayed)
1609         (tui_addr_is_displayed): Change type of win_info.  Update.
1610         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1611         (tui_source_window_base::do_make_visible_with_new_height):
1612         Update.
1613         * tui/tui-source.c (tui_set_source_content)
1614         (tui_set_source_content_nil)
1615         (tui_source_window::do_scroll_vertical): Update.
1616         * tui/tui-layout.c (show_layout): Update.
1617         * tui/tui-disasm.c (tui_set_disassem_content)
1618         (tui_disasm_window::do_scroll_vertical): Update.
1619         * tui/tui-data.h (tui_win_content): Remove.
1620         (struct tui_gen_win_info) <content, content_size>: Remove.
1621         (struct tui_source_element): Add initializers and destructor.
1622         (union tui_which_element, struct tui_win_element): Remove.
1623         (struct tui_source_window_base) <content>: New field.
1624         (struct tui_data_window): Remove destructor.
1625         (tui_alloc_content, tui_free_win_content)
1626         (tui_free_all_source_wins_content): Don't declare.
1627         * tui/tui-data.c (tui_initialize_static_data): Update.
1628         (init_content_element, tui_alloc_content): Remove.
1629         (~tui_gen_win_info): Update.
1630         (~tui_data_window, tui_free_all_source_wins_content)
1631         (tui_free_win_content, free_content, free_content_elements):
1632         Remove.
1633
1634 2019-06-25  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-winsource.h (tui_clear_source_content)
1637         (tui_erase_source_content, tui_show_source_content): Change type
1638         of win_info.
1639         * tui/tui-winsource.c (tui_clear_source_content)
1640         (tui_erase_source_content, tui_show_source_content): Change type
1641         of win_info.
1642         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1643         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1644         win_info.
1645         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1646         win_info.
1647         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1648
1649 2019-06-25  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-winsource.c (tui_clear_source_content)
1652         (tui_source_window_base::set_is_exec_point_at): Update.
1653         * tui/tui-source.c (tui_set_source_content_nil): Update.
1654         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1655         a bool.
1656         * tui/tui-data.c (init_content_element): Update.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1661         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1662         * tui/tui-layout.c (init_and_make_win): Update.
1663         * tui/tui.h (enum tui_win_type): Update.
1664         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1665         tui_win_is_auxillary.
1666         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1667         tui_win_is_auxillary.
1668
1669 2019-06-25  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1672         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1673         (tui_delete_data_content_windows, tui_display_all_data)
1674         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1675         Update.
1676         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1677         * tui/tui-regs.c (tui_last_regs_line_no)
1678         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1679         (tui_show_registers): Update.
1680         (tui_show_register_group): Return void.  Update.
1681         (tui_display_registers_from, tui_display_reg_element_at_line)
1682         (tui_display_registers_from_line, tui_check_register_values):
1683         Update.
1684         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1685         member.
1686         (struct tui_data_window) <regs_content>: Now a std::vector.
1687         <regs_content_count>: Remove.
1688         (tui_add_content_elements, tui_free_data_content): Don't declare.
1689         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1690         (init_content_element): Remove DATA_WIN case.  Add assert.
1691         (tui_add_content_elements): Remove.
1692         (tui_data_window): Update.
1693         (tui_free_data_content): Remove.
1694         (free_content_elements): Remove DATA_WIN case.
1695
1696 2019-06-25  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-data.c (tui_data_item_window): Update.
1699         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1700         * tui/tui-windata.c (tui_display_all_data)
1701         (tui_display_data_from_line): Update.
1702         (tui_check_data_values): Remove.
1703         * tui/tui-regs.c (tui_show_register_group)
1704         (tui_display_reg_element_at_line): Update.
1705         * tui/tui-hooks.c (tui_register_changed)
1706         (tui_refresh_frame_and_register_information): Call
1707         tui_check_register_values.
1708         * tui/tui-data.h (struct tui_data_window) <data_content,
1709         data_content_count, data_type>: Remove.
1710         (enum tui_data_type): Remove.
1711
1712         * tui/tui-data.c (tui_data_window::clear_detail)
1713         (~tui_data_window): Update.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1718         declare.
1719         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1720         Rename from tui_first_data_item_displayed.  Update.
1721         (tui_data_window::refresh_all)
1722         (tui_data_window::do_scroll_vertical): Update.
1723         * tui/tui-data.h (struct tui_data_window)
1724         <first_data_item_displayed>: Declare new method.
1725
1726 2019-06-25  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1729         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1730         contents...
1731         (tui_initialize_static_data): ...here.
1732
1733 2019-06-25  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1736         (tui_display_registers_from, tui_check_register_values): Update.
1737         (tui_display_register): Remove win_info parameter; update.
1738         (tui_get_register): Change type of parameters.
1739         * tui/tui-data.h (struct tui_data_element): Remove.
1740         (union tui_which_element) <data>: Remove.
1741         <data_window>: Change type.
1742         (struct tui_data_item_window): New.
1743         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1744         case.  Add assert.
1745         (~tui_data_item_window): New destructor.
1746         (free_content_elements): Remove DATA_ITEM_WIN case.
1747
1748 2019-06-25  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1751         Remove.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-data.h (struct tui_command_element): Remove.
1756         (union tui_which_element) <command>: Remove.
1757         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1758         assert.
1759         (free_content_elements): Remove CMD_WIN case.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-layout.c (tui_set_layout): Update.
1764         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1765         * tui/tui-data.c (layout_def): Update.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1770         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1771         (tui_source_window_base::set_new_height): Update.
1772         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1773         Update.
1774         (tui_set_locator_fullname, tui_set_locator_info)
1775         (tui_show_frame_info): Update.
1776         * tui/tui-source.c (tui_set_source_content)
1777         (tui_source_is_displayed): Update.
1778         * tui/tui-layout.c (show_source_disasm_command, show_data)
1779         (show_source_or_disasm_and_command): Update.
1780         * tui/tui-disasm.c (tui_set_disassem_content)
1781         (tui_get_begin_asm_address): Update.
1782         * tui/tui-data.h (struct tui_locator_element): Remove.
1783         (union tui_which_element) <locator>: Remove.
1784         (struct tui_locator_window): New.
1785         (tui_locator_win_info_ptr): Change return type.
1786         * tui/tui-data.c (_locator): Change type.
1787         (tui_locator_win_info_ptr): Change return type.
1788         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1789         (tui_alloc_content): Add assert.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-winsource.c
1794         (tui_exec_info_window::maybe_allocate_content): New method.
1795         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1796         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1797         (make_source_or_disasm_window): Add cast.
1798         * tui/tui-data.h (union tui_which_element) <simple_string>:
1799         Remove.
1800         (struct tui_source_info): New.
1801         (struct tui_source_window_base) <execution_info>: Change type.
1802         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1803         case, and add assert.
1804         (tui_alloc_content): Add assert.
1805
1806 2019-06-25  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1809         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1810         * tui/tui-data.c (tui_alloc_win_info): Remove.
1811
1812 2019-06-25  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1815         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1816         can_highlight.
1817
1818 2019-06-25  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1821         make_visible_with_new_height method.
1822         (tui_win_info::make_visible_with_new_height): New method.
1823         (tui_source_window_base::do_make_visible_with_new_height)
1824         (tui_data_window::do_make_visible_with_new_height)
1825         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1826         (make_visible_with_new_height): Remove.
1827         (tui_resize_all, tui_adjust_win_heights): Use
1828         make_visible_with_new_height method.
1829         * tui/tui-data.h (struct tui_win_info)
1830         <do_make_visible_with_new_height, make_visible_with_new_height>:
1831         New methods.
1832         (struct tui_source_window_base, struct tui_data_window)
1833         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1834         methods.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1839         method.
1840         (update_tab_width): Call update_tab_width method.
1841         * tui/tui-data.h (struct tui_win_info)
1842         (struct tui_source_window_base) <update_tab_width>: New methods.
1843
1844 2019-06-25  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1847         parameter.
1848         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1849         parameter.
1850         (tui_gen_win_info::make_visible): Update.
1851         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1852         parameter.
1853         * tui/tui-data.h (enum tui_box): New enum.
1854         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1855
1856 2019-06-25  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1859         init_and_make_win for EXEC_INFO_WIN.
1860         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1861         longer inline.
1862         (struct tui_win_info) <~tui_win_info>: Inline.
1863         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1864         Don't declare.
1865         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1866         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1867         Remove.
1868         (tui_initialize_static_data): Update.
1869         (~tui_gen_win_info): Handle more cleanup here.
1870         (~tui_source_window_base): Delete "execution_info".
1871         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1872
1873 2019-06-25  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-layout.c (make_command_window): Don't set
1876         can_highlight.
1877         (show_source_disasm_command): Call the reset method.
1878         (show_data): Don't set can_highlight.  Call the reset method.
1879         (tui_gen_win_info::reset): Rename from init_gen_win_info
1880         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1881         (show_source_or_disasm_and_command): Call the reset method.
1882         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1883         (struct tui_cmd_window): Set can_highlight.
1884
1885 2019-06-25  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1888         from make_visible.
1889         (tui_make_visible, tui_make_invisible): Rewrite.
1890         (tui_win_info::make_visible): Remove.
1891         (tui_source_window_base::make_visible): Update.
1892         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1893         method.  Moved from...
1894         (struct tui_win_info) <make_visible>: ...here.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.c
1899         (tui_source_window_base::do_scroll_horizontal): Remove direction
1900         parameter.
1901         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1902         direction parameter.
1903         * tui/tui-win.c (tui_win_info::forward_scroll)
1904         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1905         (tui_win_info::right_scroll): Update.
1906         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1907         direction parameter.
1908         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1909         direction parameter.
1910         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1911         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1912         Remove direction parameter.
1913         (struct tui_source_window_base, struct tui_source_window)
1914         (struct tui_disasm_window, struct tui_data_window)
1915         (struct tui_cmd_window): Update.
1916
1917 2019-06-25  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-winsource.h (tui_set_exec_info_content)
1920         (tui_show_exec_info_content, tui_erase_exec_info_content)
1921         (tui_clear_exec_info_content, tui_update_exec_info): Change
1922         argument to tui_source_window_base.
1923         * tui/tui-winsource.c (tui_set_exec_info_content)
1924         (tui_show_exec_info_content, tui_erase_exec_info_content)
1925         (tui_clear_exec_info_content, tui_update_exec_info): Change
1926         argument to tui_source_window_base.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1931         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1936         check.
1937
1938 2019-06-25  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1941         type to void.
1942         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1943         type to void.
1944         * tui/tui-source.c (tui_set_source_content): Update.
1945         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1946
1947 2019-06-25  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-win.c (window_name_completer, tui_set_focus)
1950         (tui_all_windows_info): Use name method.
1951         * tui/tui-data.h (struct tui_gen_win_info)
1952         (struct tui_source_window, struct tui_disasm_window)
1953         (struct tui_data_window, struct tui_cmd_window) <name>: New
1954         method.
1955         (tui_win_name): Don't declare.
1956         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1957         (tui_win_name): Remove.
1958
1959 2019-06-25  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-winsource.h (tui_update_source_window)
1962         (tui_update_source_window_as_is): Change parameter type.
1963         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1964         to be a tui_source_window_base.
1965         (tui_update_source_window_as_is): Likewise.
1966         * tui/tui-win.c (make_visible_with_new_height): Update.
1967
1968 2019-06-25  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-winsource.c (tui_erase_source_content)
1971         (tui_show_source_content, tui_show_exec_info_content)
1972         (tui_erase_exec_info_content): Use refresh_window method.
1973         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1974         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1975         from tui_refresh_win.
1976         (tui_data_window::refresh_window): New method.
1977         (tui_win_info::refresh, tui_source_window_base::refresh)
1978         (tui_refresh_all): Use refresh_window method.
1979         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1980         method.
1981         * tui/tui-regs.c (tui_display_register): Call refresh_window
1982         method.
1983         * tui/tui-layout.c (show_source_disasm_command)
1984         (show_source_or_disasm_and_command): Call refresh_window method.
1985         * tui/tui-data.h (struct tui_gen_win_info)
1986         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1987         New method.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui.c (tui_rl_other_window, tui_enable)
1992         (tui_is_window_visible, tui_get_command_dimension): Update.
1993         * tui/tui-winsource.c (tui_update_source_window_as_is)
1994         (tui_clear_source_content, tui_erase_source_content)
1995         (tui_show_source_line, tui_source_window_base::refill)
1996         (tui_source_window_base::do_scroll_horizontal)
1997         (tui_source_window_base::set_is_exec_point_at)
1998         (tui_update_breakpoint_info, tui_set_exec_info_content)
1999         (tui_alloc_source_buffer, tui_line_is_displayed)
2000         (tui_addr_is_displayed): Update.
2001         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2002         (tui_check_and_display_highlight_if_needed)
2003         (tui_win_info::make_visible, tui_win_info::refresh)
2004         (tui_refresh_all): Update.
2005         * tui/tui-windata.c (tui_first_data_item_displayed)
2006         (tui_delete_data_content_windows, tui_erase_data_content)
2007         (tui_display_all_data, tui_data_window::refresh_all)
2008         (tui_check_data_values): Update.
2009         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2010         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2011         (tui_win_info::backward_scroll, tui_refresh_all_win)
2012         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2013         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2014         (tui_source_window_base::set_new_height)
2015         (tui_data_window::set_new_height)
2016         (make_invisible_and_set_new_height)
2017         (make_visible_with_new_height, new_height_ok)
2018         (parse_scrolling_args): Update.
2019         * tui/tui-stack.c (tui_show_frame_info): Update.
2020         * tui/tui-source.c (tui_set_source_content)
2021         (tui_set_source_content_nil, tui_source_is_displayed)
2022         (tui_source_window::do_scroll_vertical): Update.
2023         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2024         (tui_display_registers_from, tui_display_reg_element_at_line)
2025         (tui_check_register_values, tui_reg_command): Update.
2026         * tui/tui-layout.c (tui_default_win_height)
2027         (show_source_disasm_command, show_data, init_and_make_win)
2028         (show_source_or_disasm_and_command): Update.
2029         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2030         (tui_redisplay_readline, tui_mld_flush)
2031         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2032         (tui_getc): Update.
2033         * tui/tui-disasm.c (tui_set_disassem_content)
2034         (tui_disasm_window::do_scroll_vertical): Update.
2035         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2036         Now virtual.
2037         (struct tui_win_info): Derive from tui_gen_win_info.
2038         <~tui_win_info>: Mark as override.
2039         <generic>: Remove member.
2040         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2041         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2042         (~tui_data_window, ~tui_win_info)
2043         (tui_free_all_source_wins_content): Update.
2044         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2045
2046 2019-06-25  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-layout.c (init_and_make_win): Use new.
2049         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2050         destructor, initializers.
2051         (tui_alloc_generic_win_info): Don't declare.
2052         * tui/tui-data.c (_locator): Add argument to constructor.
2053         (source_win, disasm_win): New globals.
2054         (exec_info): Remove.
2055         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2056         Update.
2057         (tui_alloc_generic_win_info): Remove.
2058         (init_content_element): Use new.
2059         (tui_win_info::tui_win_info): Update.
2060         (free_content_elements) <case DATA_WIN>: Use delete.
2061
2062 2019-06-25  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2065         * tui/tui-windata.c (tui_first_data_item_displayed)
2066         (tui_delete_data_content_windows): Update.
2067         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2068         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2069         (tui_display_registers_from, tui_check_register_values): Update.
2070         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2071         pointer.
2072         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2073         window.
2074         (tui_free_data_content): Update.
2075         (free_content_elements) <case DATA_WIN>: Free the window.
2076
2077 2019-06-25  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2080         Update.
2081         * tui/tui-layout.c (make_command_window)
2082         (show_source_disasm_command, show_data, init_and_make_win)
2083         (show_source_or_disasm_and_command): Update.
2084         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2085         method.
2086         <can_highight, is_highlighted>: Now bool.
2087         (tui_set_win_highlight): Don't declare.
2088         * tui/tui-data.c (tui_set_win_highlight): Remove.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-wingeneral.c (make_visible): Remove check of window
2093         type.
2094
2095 2019-06-25  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-win.c (tui_win_info::max_height)
2098         (tui_cmd_window::max_height): New methods.
2099         (new_height_ok): Call max_height.
2100         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2101         <max_height>: New method.
2102
2103 2019-06-25  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-win.c (tui_source_window_base::set_new_height)
2106         (tui_data_window::set_new_height): New methods.
2107         (make_invisible_and_set_new_height): Call set_new_height method.
2108         * tui/tui-data.h (struct tui_win_info)
2109         (struct tui_source_window_base, struct tui_data_window)
2110         <set_new_height>: New method.
2111
2112 2019-06-25  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2115         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2116         tui_refresh_data_win.
2117         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2118         method.
2119         (tui_refresh_all_win): Call the refresh_all method.
2120         (tui_set_focus): Likewise.
2121         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2122         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2123         Likewise.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-winsource.h (tui_refill_source_window)
2128         (tui_set_is_exec_point_at): Don't declare.
2129         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2130         (tui_source_window_base::refill): Rename from
2131         tui_refill_source_window.
2132         (tui_source_window_base::do_scroll_horizontal): Update.
2133         (tui_source_window_base::set_is_exec_point_at): Rename from
2134         tui_set_is_exec_point_at.
2135         (tui_update_all_breakpoint_info): Update.
2136         * tui/tui-stack.c (tui_show_frame_info): Update.
2137         * tui/tui-layout.c (show_data): Add cast.
2138         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2139         * tui/tui-data.h (struct tui_source_window_base) <refill,
2140         set_is_exec_point_at>: New methods.
2141         (tui_source_windows, tui_add_to_source_windows): Update types.
2142         (tui_add_to_source_windows): Remove redundant declaration.
2143         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2144         (tui_source_windows): Change return type.
2145         (tui_clear_source_windows_detail): Update.
2146         (tui_add_to_source_windows): Change type of parameter.
2147         (tui_free_all_source_wins_content): Update.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-wingeneral.c (tui_win_info::refresh)
2152         (tui_source_window_base::refresh): New methods.
2153         (tui_refresh_all): Call the refresh method.
2154         * tui/tui-data.h (struct tui_win_info)
2155         (struct tui_source_window_base) <refresh>: New method.
2156
2157 2019-06-25  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui.h (tui_is_window_visible): Return bool.
2160         * tui/tui.c (tui_is_window_visible): Return bool.
2161         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2162         (tui_make_visible, tui_make_invisible)
2163         (tui_win_info::make_visible)
2164         (tui_source_window_base::make_visible, make_all_visible)
2165         (tui_make_all_visible, tui_make_all_invisible): Update.
2166         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2167         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2168         bool.
2169         (struct tui_win_info, struct tui_source_window_base)
2170         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2171         * tui/tui-data.c (tui_init_generic_part): Update.
2172
2173 2019-06-25  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2176         (tui_source_window_base::make_visible): New methods.
2177         (make_all_visible): Make method call.
2178         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2179         (struct tui_source_window_base, struct tui_cmd_window): Override
2180         make_visible.
2181         (tui_win_is_source_type): Don't declare.
2182         * tui/tui-data.c (tui_win_is_source_type): Remove.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2187         NULL check.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2192         Inline constructor.  Add initializers for members.
2193         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2194         constructors; now inline in class.
2195
2196 2019-06-25  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-regs.c (tui_show_registers): Update.
2199         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2200         bool.
2201         * tui/tui-data.c (tui_data_window::clear_detail)
2202         (tui_data_window): Update.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-windata.c (tui_display_all_data)
2207         (tui_display_data_from_line, tui_display_data_from)
2208         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2209         Update.
2210         * tui/tui-regs.c (tui_last_regs_line_no)
2211         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2212         (tui_show_registers, tui_show_register_group)
2213         (tui_display_registers_from, tui_display_reg_element_at_line)
2214         (tui_display_registers_from_line, tui_check_register_values)
2215         (tui_reg_next, tui_reg_prev): Update.
2216         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2217         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2218         tui_data_window.
2219         (struct tui_win_info) <detail>: Remove.  Add new fields from
2220         tui_data_info.
2221         (TUI_DATA_WIN): Add cast.
2222         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2223         (~tui_data_window): Simplify.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-layout.c (show_source_disasm_command)
2228         (show_source_or_disasm_and_command): Update.
2229         * tui/tui-io.c (update_cmdwin_start_line)
2230         (tui_redisplay_readline): Update.
2231         * tui/tui-data.h (struct tui_command_info): Remove.
2232         (struct tui_win_info) <detail>: Remove command_info member.
2233         (struct tui_data_window) <start_line>: New member, from
2234         tui_command_info.
2235         (TUI_CMD_WIN): Add casts.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.c (tui_update_source_window)
2240         (tui_refill_source_window)
2241         (tui_source_window_base::do_scroll_horizontal)
2242         (tui_update_breakpoint_info, tui_set_exec_info_content)
2243         (tui_show_exec_info_content, tui_erase_exec_info_content)
2244         (tui_clear_exec_info_content): Update.
2245         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2246         Update.
2247         * tui/tui-win.c (make_invisible_and_set_new_height)
2248         (make_visible_with_new_height): Update.
2249         * tui/tui-source.c (tui_set_source_content)
2250         (tui_show_symtab_source): Update.
2251         * tui/tui-layout.c (extract_display_start_addr)
2252         (show_source_disasm_command, show_data)
2253         (make_source_or_disasm_window)
2254         (show_source_or_disasm_and_command): Update.
2255         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2256         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2257         "gdbarch".
2258         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2259         to tui_source_window_base.
2260         (struct tui_win_info) <detail>: Remove source_info member.
2261         (struct tui_source_window_base) <has_locator>: Inline.
2262         Move contents from tui_source_info; rename has_locator member to
2263         m_has_locator.
2264         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2265         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2266         header file.
2267         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2268         Simplify.
2269         (tui_free_all_source_wins_content): Cast to
2270         tui_source_window_base.
2271
2272 2019-06-25  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-win.c (make_invisible_and_set_new_height)
2275         (make_visible_with_new_height): Call has_locator method.
2276         * tui/tui-layout.c (show_source_disasm_command, show_data)
2277         (show_source_or_disasm_and_command): Update for bool change.
2278         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2279         (tui_win_info) <has_locator>: New method.
2280         (struct tui_source_window_base) <has_locator>: New method.
2281         (tui_win_has_locator): Don't declare.
2282         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2283         from tui_win_has_locator.
2284         (tui_source_window_base): Use false, not FALSE.
2285
2286 2019-06-25  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2289         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2290         clear_detail method directly.
2291         (tui_clear_win_detail): Remove.
2292
2293 2019-06-25  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2296         "this", not TUI_DISASM_WIN.
2297
2298 2019-06-25  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2301         declare.
2302         * tui/tui-winsource.c
2303         (tui_source_window_base::do_scroll_horizontal): Rename from
2304         tui_horizontal_source_scroll.
2305         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2306         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2307         from tui_vertical_data_scroll.
2308         * tui/tui-win.h (tui_scroll): Don't declare.
2309         * tui/tui-win.c (tui_win_info::forward_scroll)
2310         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2311         (tui_win_info::right_scroll): Rename and update.
2312         (tui_scroll_forward_command, tui_scroll_backward_command)
2313         (tui_scroll_left_command, tui_scroll_right_command): Update.
2314         (tui_scroll): Remove.
2315         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2316         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2317         from tui_vertical_source_scroll.
2318         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2319         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2320         from tui_vertical_disassem_scroll.
2321         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2322         do_scroll_horizontal>: New methods.
2323         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2324         Likewise.
2325         (struct tui_source_window_base): Add do_scroll_horizontal.
2326         (struct tui_source_window, struct tui_disasm_window): Add
2327         do_scroll_vertical.
2328         (struct tui_data_window, struct tui_cmd_window): Add
2329         do_scroll_horizontal and do_scroll_vertical.
2330         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-data.h (struct tui_source_window_base): New struct.
2335         (struct tui_source_window): Derive from tui_source_window_base.
2336         (struct tui_disasm_window): New struct.
2337         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2338         from tui_source_window::clear_detail.
2339         (tui_source_window_base): Rename from tui_source_window.
2340         (~tui_source_window_base): Rename from ~tui_source_window.
2341         (tui_alloc_win_info): Create a tui_disasm_window.
2342
2343 2019-06-25  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-data.h (struct tui_source_window)
2346         (struct tui_data_window): Declare destructors.
2347         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2348         destructors.
2349         (tui_win_info): Simplify.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.c (tui_display_main)
2354         (tui_update_source_windows_with_addr)
2355         (tui_update_all_breakpoint_info): Update.
2356         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2357         (new_height_ok, parse_scrolling_args): Update.
2358         * tui/tui-stack.c (tui_show_frame_info): Update.
2359         * tui/tui-data.h (struct tui_list): Remove.
2360         (tui_source_windows): Return a reference to a std::vector.
2361         * tui/tui-data.c (source_windows): Now a std::vector.
2362         (tui_source_windows): Change return type.
2363         (tui_clear_source_windows): Rewrite.
2364         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2365         (tui_free_all_source_wins_content): Rewrite.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2370         (struct tui_data_window, struct tui_cmd_window): Declare
2371         clear_detail method.
2372         * tui/tui-data.c (tui_source_window::clear_detail)
2373         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2374         methods.
2375         (tui_clear_win_detail): Simplify.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-layout.c (make_source_window, make_disasm_window)
2380         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2381         Return the new window.
2382         (show_source_disasm_command, show_data)
2383         (show_source_or_disasm_and_command): Update.
2384
2385 2019-06-25  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2388         parameter.  Return the new window.
2389         (show_source_disasm_command): Update and remove NULL check.
2390         (show_source_or_disasm_and_command): Update.
2391
2392 2019-06-25  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2395
2396 2019-06-25  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-data.h (struct tui_win_info): Make constructor
2399         protected.  Make destructor virtual.  Add initializers.
2400         (tui_source_window, tui_data_window, tui_cmd_window): New
2401         classes.
2402         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2403         constructor.  Add "type" parameter.
2404         (tui_source_window, tui_data_window, tui_cmd_window): New
2405         constructors.
2406         (tui_alloc_win_info): Instantiate the appropriate subclass.
2407
2408 2019-06-25  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-win.c (tui_resize_all): Use delete.
2411         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2412         destructor.
2413         (tui_free_window): Don't declare.
2414         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2415         Update.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-data.h (struct tui_win_info): Add constructor.
2420         * tui/tui-data.c (tui_alloc_win_info): Use new.
2421         (tui_free_window): Use delete.
2422
2423 2019-06-22  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2426         declare.
2427         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2428
2429 2019-06-22  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2432         declare.
2433         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2434
2435 2019-06-22  Tom de Vries  <tdevries@suse.de>
2436
2437         * dwarf2read.c (create_addrmap_from_aranges)
2438         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2439         instead of '%zu'.
2440
2441 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2442
2443         * dwarf2read.h (dwarf2_section_info_def): Remove.
2444         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2445         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2446         std::vector<dwarf2_section_info>.
2447         (struct dwo_file) <~dwo_file>: Remove.
2448         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2449         types field.
2450         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2451         (dwarf2_read_debug_names): Likewise.
2452         (create_debug_types_hash_table): Change parameter type to
2453         array_view, adjust code accordingly.
2454         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2455         (partial_die_info::fixup): Likewise.
2456         (determine_prefix): Likewise.
2457         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2458
2459 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2460
2461         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2462         gdb_bfd_ref_ptr.
2463         <~dwo_file>: Remove call to gdb_bfd_unref.
2464         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2465         gdb_bfd_ref_ptr::get.
2466
2467 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2468
2469         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2470         type to htab_up.
2471         * dwarf2read.c (struct dwo_file): Initialize fields.
2472         <~dwo_file>: New.
2473         (free_dwo_file): Remove, move content to ~dwo_file.
2474         (struct dwo_file_deleter): Remove.
2475         (dwo_file_up>: Remove custom deleter.
2476         (free_dwo_files): Remove.
2477         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2478         dwo_files.
2479         (process_skeletonless_type_units): Call unique_ptr::get.
2480         (allocate_dwo_file_hash_table): Add deleter to created hash
2481         table.  Change return type to htab_up.
2482         (lookup_dwo_file_slot): Don't memset dwo_file, call
2483         unique_ptr::get.
2484         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2485         (create_dwo_unit_in_dwp_v2): Likewise.
2486         (open_and_init_dwo_file): Likewise.
2487         (free_dwo_file_from_slot): Remove.
2488
2489 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2490
2491         * dwarf2read.h (struct dwarf2_section_info) <readin,
2492         is_virtual>: Change type to bool.
2493         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2494         true instead of 1.
2495
2496 2019-06-19  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-data.h (tui_init_content_element): Don't declare.
2499
2500 2019-06-19  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-data.h (tui_init_win_info): Don't declare.
2503
2504 2019-06-19  Tom de Vries  <tdevries@suse.de>
2505
2506         * dwarf2read.h (abstract_to_concrete): Change type to
2507         std::unordered_map<sect_offset, std::vector<sect_offset>,
2508         gdb::hash_enum<sect_offset>>.
2509
2510 2019-06-19  Tom Tromey  <tromey@adacore.com>
2511
2512         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2513         EVAL_AVOID_SIDE_EFFECTS specially.
2514
2515 2019-06-19  Tom Tromey  <tromey@adacore.com>
2516
2517         * source-cache.c (highlighter): New global.
2518         (source_cache::get_source_lines): Create a highlighter on demand.
2519
2520 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * defs.h (deprecated_interactive_hook): Delete declaration.
2523         * interps.c (clear_interpreter_hooks): Remove use of
2524         deprecated_interactive_hook.
2525         * top.c (deprecated_interactive_hook): Delete definition.
2526         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2527
2528 2019-06-18  Tom de Vries  <tdevries@suse.de>
2529
2530         PR gdb/24515
2531         * dwarf2read.h (abstract_to_concrete): Change type from
2532         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2533         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2534         * dwarf2read.c (read_variable): Update.
2535         (dwarf2_fetch_die_loc_sect_off): Update.
2536
2537 2019-06-17  Tom de Vries  <tdevries@suse.de>
2538
2539         PR gdb/24617
2540         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2541         accessing parent[parent_len - 1].
2542
2543 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2544
2545         PR gdb/24364
2546         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2547         call dtrace_process_dof with NULL dof.
2548
2549 2019-06-16  Tom de Vries  <tdevries@suse.de>
2550
2551         PR gdb/24445
2552         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2553
2554 2019-06-16  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2557         (make_all_visible): Use address of member.
2558
2559 2019-06-16  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2562         (tui_free_window, free_content, free_content_elements): Remove
2563         unnecessary cast.
2564         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2565         cast.
2566         * tui/tui-regs.c (tui_show_register_group)
2567         (tui_display_registers_from, tui_display_reg_element_at_line):
2568         Remove unnecessary cast.
2569
2570 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2571
2572         * linux-nat.c (normal_mask): Delete.
2573         (_initialize_linux_nat): Don't initialise normal_mask.
2574
2575 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2576
2577         PR gdb/24445
2578         * dwarf-index-write.h (write_psymtabs_to_index): Add
2579         dwz_basename parameter.
2580         * dwarf-index-write.c (write_gdbindex): Move file writing to
2581         write_gdbindex_1.  Change return type void.
2582         (assert_file_size): Move up, remove filename parameter.
2583         (write_gdbindex_1): New function.
2584         (write_debug_names): Change return type to void, call
2585         assert_file_size.
2586         (struct index_wip_file): New struct.
2587         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2588         file logic to index_wip_file.  Write index for dwz file if
2589         needed.
2590         (save_gdb_index_command): Pass basename of dwz file, if present.
2591         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2592         build-id of dwz file, if present.
2593         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2594         (dwarf2_get_dwz_file): Likewise.
2595         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2596         (dwarf2_get_dwz_file): Likewise.
2597
2598 2019-06-16  Tom Tromey  <tom@tromey.com>
2599
2600         * coffread.c (process_coff_symbol): Use xstrdup.
2601         * value.c (create_internalvar): Use xstrdup.
2602
2603 2019-06-16  Tom Tromey  <tom@tromey.com>
2604
2605         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2606         * breakpoint.c (stopin_command, stopat_command)
2607         (until_break_command, decode_location_default): Remove unnecessary
2608         cast.
2609         * utils.c (subset_compare): Remove unnecessary cast.
2610         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2611         cast.
2612         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2613         cast.
2614         * infcmd.c (path_command): Remove unnecessary cast.
2615         * coffread.c (decode_type): Remove unnecessary cast.
2616         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2617         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2618         * tui/tui-stack.c (tui_show_locator_content)
2619         (tui_show_frame_info): Remove unnecessary cast.
2620         * tui/tui-win.c (tui_scroll_forward_command)
2621         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2622         (parse_scrolling_args): Remove unnecessary cast.
2623         * tui/tui-data.c (init_win_info, tui_del_window)
2624         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2625         (free_content_elements): Remove unnecessary cast.
2626         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2627         unnecessary cast.
2628         * tui/tui-source.c (tui_set_source_content)
2629         (tui_vertical_source_scroll): Remove unnecessary cast.
2630         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2631         cast.
2632         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2633         * tui/tui-regs.c (tui_display_registers_from)
2634         (tui_display_register): Remove unnecessary cast.
2635         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2636         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2637         (make_visible): Remove unnecessary cast.
2638         * tui/tui-winsource.c (tui_erase_source_content)
2639         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2640         unnecessary cast.
2641         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2642         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2643         * stabsread.c (read_type, read_array_type, read_range_type):
2644         Remove unnecessary cast.
2645         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2646         (parse_symbol, parse_type, upgrade_type, parse_external)
2647         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2648         unnecessary cast.
2649         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2650
2651 2019-06-16  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-data.c (tui_alloc_generic_win_info)
2654         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2655         checks.
2656
2657 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2658             Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * f-typeprint.c (f_print_type): Don't return early for not
2661         associated or not allocated types.
2662         (f_type_print_varspec_suffix): Add print_rank parameter and print
2663         ranks of array types in case they dangling.
2664         (f_type_print_base): Add print_rank parameter.
2665
2666 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * NEWS: Mention new MI commands.
2669         * break-catch-throw.c (enum exception_event_kind): Move to
2670         breakpoint.h.
2671         (print_mention_exception_catchpoint): Output text as a single
2672         message.
2673         (catch_exception_command_1): Rename to...
2674         (catch_exception_event): ...this, make non-static, update header
2675         command, and change some parameter types.
2676         (catch_catch_command): Update for changes to
2677         catch_exception_command_1.
2678         (catch_throw_command): Likewise.
2679         (catch_rethrow_command): Likewise.
2680         * breakpoint.c (enum exception_event_kind): Delete.
2681         * breakpoint.h (enum exception_event_kind): Moved here from
2682         break-catch-throw.c.
2683         (catch_exception_event): Declare.
2684         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2685         (mi_cmd_catch_throw): New function.
2686         (mi_cmd_catch_rethrow): New function.
2687         (mi_cmd_catch_catch): New function.
2688         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2689         'catch-catch' entries.
2690         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2691         (mi_cmd_catch_rethrow): Declare.
2692         (mi_cmd_catch_catch): Declare.
2693
2694 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * annotate.c (annotate_source_line): Change return type to void,
2697         update implementation to match.
2698         * annotate.h (annotate_source_line): Change return type to void,
2699         update header comment.
2700         * stack.c (print_frame_info): Don't change what frame information
2701         is printed based on whether annotations are on or not.
2702
2703 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2706         (annotate_source): Make static.
2707         (annotate_source_line): Moved from source.c and renamed from
2708         identify_source_line.  Update the return type.
2709         * annotate.h (annotate_source): Delete declaration.
2710         (annotate_source_line): Declaration moved from source.h, and
2711         renamed from identify_source_line.  Return type updated.
2712         * source.c (identify_source_line): Moved to annotate.c and renamed
2713         to annotate_source_line.
2714         (info_line_command): Remove check of annotation_level.
2715         * source.h (identify_source_line): Move declaration to annotate.h
2716         and rename to annotate_source_line.
2717         * stack.c: Add 'annotate.h' include.
2718         (print_frame_info): Remove check of annotation_level before
2719         calling annotate_source_line.
2720
2721 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * source-cache.c (source_cache::get_plain_source_lines): Use
2724         open_source_file_with_line_charpos instead of just
2725         open_source_file, remove call to find_source_lines.
2726         (source_cache::get_source_lines): Likewise.
2727         * source.c (find_source_lines): Make static.
2728         (get_filename_and_charpos): Renamed into...
2729         (open_source_file_with_line_charpos): ..this along with changes to
2730         return a scoped_fd, and some other minor clean ups.
2731         (identify_source_line): Use open_source_file_with_line_charpos.
2732         (search_command_helper): Use open_source_file_with_line_charpos
2733         instead of just open_source_file, remove call to
2734         find_source_lines.
2735         * source.h (open_source_file_with_line_charpos): Declare new
2736         function.
2737         (find_source_lines): Delete declaration.
2738
2739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * source.c (get_filename_and_charpos): Remove fullname
2742         parameter.
2743         (identify_source_line): Update call to get_filename_and_charpos.
2744
2745 2019-06-14  Tom Tromey  <tromey@adacore.com>
2746
2747         PR gdb/24502:
2748         * ui-style.h (skip_ansi_escape): Update comment.
2749         * ui-file.h (class no_terminal_escape_file): New class.
2750         * ui-file.c (no_terminal_escape_file::write)
2751         (no_terminal_escape_file::puts): New methods.
2752         * cli/cli-logging.c (handle_redirections): Use
2753         no_terminal_escape_file.
2754
2755 2019-06-14  Tom Tromey  <tromey@adacore.com>
2756
2757         * NEWS: Move convenience variable news above Python news.
2758
2759 2019-06-14  Tom Tromey  <tom@tromey.com>
2760
2761         * gnulib: Move directory to top-level.
2762         * configure.ac: Don't configure gnulib.
2763         * configure: Rebuild.
2764         * common/common-defs.h: Use new path to gnulib.
2765         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2766         (GNULIB_H): Remove.
2767         (INCGNU): Look in new gnulib location.
2768         (HFILES_NO_SRCDIR): Remove gnulib files.
2769         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2770         (generated_files): Remove GNULIB_H.
2771         ($(LIBGNU), all-lib): Remove targets.
2772         (distclean): Don't mention GNULIB_BUILDDIR.
2773         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2774
2775 2019-06-14  Tom Tromey  <tromey@adacore.com>
2776
2777         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2778         Warn if symbol file does not provide any symbols.
2779
2780 2019-06-14  Tom Tromey  <tromey@adacore.com>
2781
2782         * source.c (find_and_open_source): Respect basenames_may_differ.
2783
2784 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * annotate.c (annotate_breakpoints_invalid): Make use of
2787         scoped_restore_terminal_state.
2788         (annotate_frames_invalid): Likewise.
2789
2790 2019-06-14  Tom Tromey  <tromey@adacore.com>
2791
2792         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2793         allow assignment to an internalvar.
2794
2795 2019-06-14  Tom Tromey  <tromey@adacore.com>
2796
2797         * ada-lex.l: Allow "_" in attribute names.
2798
2799 2019-06-14  Tom Tromey  <tromey@adacore.com>
2800
2801         PR gdb/24653:
2802         * regcache.c (registers_changed): Don't call alloca.
2803         * top.c (execute_command): Don't call alloca.
2804
2805 2019-06-13  Pedro Alves  <palves@redhat.com>
2806
2807         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2808         'expression'.  When parsing an expression, error out if there's
2809         junk after "unlimited".
2810         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2811         (do_set_command): Adjust calls to is_unlimited_literal.
2812
2813 2019-06-13  Pedro Alves  <palves@redhat.com>
2814
2815         * compile/compile.c (make_compile_options_def_group): Add braces
2816         around array_view initializer.
2817         * thread.c (make_thread_apply_all_options_def_group)
2818         (make_thread_apply_all_options_def_group): Likewise.
2819
2820 2019-06-13  Pedro Alves  <palves@redhat.com>
2821
2822         * NEWS (New commands): Mention "maint test-options
2823         require-delimiter", "maint test-options unknown-is-error", "maint
2824         test-options unknown-is-operand" and "maint show
2825         test-options-completion-result".
2826         (New command options, command completion): New section.
2827         (Completion improvements): New section.
2828         Mention that you can abbreviate "unlimited".
2829
2830 2019-06-13  Pedro Alves  <palves@redhat.com>
2831
2832         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2833         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2834         * unittests/cli-utils-selftests.c (test_parse_flags)
2835         (test_parse_flags_qcs): Delete.
2836         (test_cli_utils): Don't call deleted functions.
2837
2838 2019-06-13  Pedro Alves  <palves@redhat.com>
2839
2840         * thread.c: Include "cli/cli-option.h".
2841         (tp_array_compar_ascending): Global.
2842         (tp_array_compar): Delete function.
2843         (tp_array_compar_ascending, tp_array_compar_descending): New
2844         functions.
2845         (ascending_option_def, qcs_flag_option_def)
2846         (thr_qcs_flags_option_defs)
2847         (make_thread_apply_all_options_def_group)
2848         (make_thread_apply_options_def_group): New.
2849         (thread_apply_all_command): Use gdb::option::process_options.
2850         (thread_apply_command_completer)
2851         (thread_apply_all_command_completer): New.
2852         (thread_apply_command): Use gdb::option::process_options.
2853         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2854         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2855         to generate help text of "thread apply".  Adjust "taas"'s help.
2856         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2857         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2858
2859 2019-06-13  Pedro Alves  <palves@redhat.com>
2860
2861         * thread.c (thread_apply_command): Check for invalid TID with
2862         isdigit instead of !isalpha.
2863
2864 2019-06-13  Pedro Alves  <palves@redhat.com>
2865
2866         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2867         (validate_flags_qcs): New.
2868         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2869         (validate_flags_qcs): Declare.
2870         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2871         (make_frame_apply_options_def_group): New.
2872         (frame_apply_command_count): Process options with
2873         gdb::option::process_options.
2874         (frame_apply_completer): New.
2875         (frame_apply_level_completer, frame_apply_all_completer)
2876         (frame_apply_completer): New.
2877         (_initialize_stack): Update help of "frame apply", "frame apply
2878         level", "frame apply all" and "faas" to mention supported options
2879         and install command completers.
2880         * stack.h (frame_apply_all_completer): Declare.
2881         * thread.c: Include "stack.h".
2882         (tfaas_command): Add "--".
2883         (_initialize_thread): Update help "tfaas" to mention supported
2884         options and install command completer.
2885
2886 2019-06-13  Pedro Alves  <palves@redhat.com>
2887
2888         * completer.c (complete_nested_command_line): New.
2889         (gdb_completion_word_break_characters_throw): Add assertion.
2890         * completer.h (complete_nested_command_line): Declare.
2891
2892 2019-06-13  Pedro Alves  <palves@redhat.com>
2893
2894         * stack.c (parse_backtrace_qualifiers): New.
2895         (backtrace_command): Use it.
2896         (backtrace_command_completer): Complete on qualifiers.
2897
2898 2019-06-13  Pedro Alves  <palves@redhat.com>
2899
2900         * frame.c: Include "cli/cli-option.h.
2901         (user_set_backtrace_options): New.
2902         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2903         Delete.
2904         (get_prev_frame): Adjust.
2905         (boolean_option_def, uinteger_option_def)
2906         (set_backtrace_option_defs): New.
2907         (_initialize_frame): Adjust and use
2908         gdb::option::add_setshow_cmds_for_options to install "set
2909         backtrace past-main" and "set backtrace past-entry".
2910         * frame.h: Include "cli/cli-option.h".
2911         (struct frame_print_options): Forward declare.
2912         (print_frame_arguments_all, print_frame_arguments_scalars)
2913         (print_frame_arguments_none): Declare.
2914         (print_entry_values): Delete declaration.
2915         (struct frame_print_options, user_frame_print_options): New.
2916         (struct set_backtrace_options): New.
2917         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2918         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2919         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2920         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2921         (list_args_or_locals): Add frame_print_options parameter.
2922         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2923         * python/py-framefilter.c (enumerate_args): Pass down
2924         USER_FRAME_PRINT_OPTIONS.
2925         * stack.c: Include "cli/cli-option.h".
2926         (print_frame_arguments_all, print_frame_arguments_scalars)
2927         (print_frame_arguments_none): Declare.
2928         (print_raw_frame_arguments, print_entry_values): Delete.
2929         (user_frame_print_options): New.
2930         (boolean_option_def, enum_option_def, frame_print_option_defs):
2931         New.
2932         (struct backtrace_cmd_options): New.
2933         (bt_flag_option_def): New.
2934         (backtrace_command_option_defs): New.
2935         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2936         (print_frame_arg, read_frame_arg, print_frame_args)
2937         (print_frame_info, print_frame): Add frame_print_options parameter
2938         and use it.
2939         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2940         (backtrace_command_1): Add frame_print_options and
2941         backtrace_cmd_options parameters and use them.
2942         (make_backtrace_options_def_group): New.
2943         (backtrace_command): Process command options with
2944         gdb::option::process_options.
2945         (backtrace_command_completer): New.
2946         (_initialize_stack): Extend "backtrace"'s help to mention
2947         supported options.  Install completer for "backtrace".
2948         Install some settings commands with add_setshow_cmds_for_options.
2949
2950 2019-06-13  Pedro Alves  <palves@redhat.com>
2951
2952         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2953         and that "set/show print raw frame-arguments" are now deprecated.
2954
2955         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2956         command.
2957         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2958         * stack.c (_initialize_stack): Install "set/show print
2959         raw-frame-arguments", and deprecate "set/show print raw
2960         frame-arguments".
2961         * valprint.c (_initialize_valprint): Deprecate "set/show print
2962         raw".
2963
2964 2019-06-13  Pedro Alves  <palves@redhat.com>
2965
2966         * compile/compile.c (struct compile_options): New.
2967         (compile_flag_option_def, compile_command_option_defs)
2968         (make_compile_options_def_group): New.
2969         (compile_file_command): Handle options with
2970         gdb::option::process_options.
2971         (compile_file_command_completer): New function.
2972         (compile_code_command): Handle options with
2973         gdb::option::process_options.
2974         (compile_code_command_completer): New function.
2975         (_initialize_compiler): Install completers for "compile code" and
2976         "compile file".  Mention available options in "compile code" and
2977         "compile code"'s help.
2978         * completer.c (advance_to_completion_word): New, factored out from
2979         ...
2980         (advance_to_expression_complete_word_point): ... this.
2981         (advance_to_filename_complete_word_point): New.
2982         * completer.h (advance_to_filename_complete_word_point): New
2983         declaration.
2984
2985 2019-06-13  Pedro Alves  <palves@redhat.com>
2986
2987         * compile/compile.c: Include "cli/cli-option.h".
2988         (compile_print_value): Scope data pointer is now a
2989         value_print_options pointer; adjust.
2990         (compile_print_command): Process options.  Scope data pointer is
2991         now a value_print_options pointer; adjust.
2992         (_initialize_compile): Update "compile print"'s help to include
2993         supported options.  Install a completer for "compile print".
2994         * cp-valprint.c (show_vtblprint, show_objectprint)
2995         (show_static_field_print): Delete.
2996         (_initialize_cp_valprint): Don't install "set print
2997         static-members", "set print vtbl", "set print object" here.
2998         * printcmd.c: Include "cli/cli-option.h" and
2999         "common/gdb_optional.h".
3000         (print_command_parse_format): Rework to fill in a
3001         value_print_options instead of a format_data.
3002         (print_value): Change parameter type from format_data pointer to
3003         value_print_options reference.  Adjust.
3004         (print_command_1): Process options.  Adjust to pass down a
3005         value_print_options.
3006         (print_command_completer): New.
3007         (_initialize_printcmd): Install print_command_completer as
3008         handle_brkchars completer for the "print" command.  Update
3009         "print"'s help to include supported options.
3010         * valprint.c: Include "cli/cli-option.h".
3011         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3012         here from cp-valprint.c.
3013         (boolean_option_def, uinteger_option_def)
3014         (value_print_option_defs, make_value_print_options_def_group):
3015         New.  Use gdb::option::add_setshow_cmds_for_options to install
3016         "set print elements", "set print null-stop", "set print repeats",
3017         "set print pretty", "set print union", "set print array", "set
3018         print address", "set print symbol", "set print array-indexes".
3019         * valprint.h: Include <string> and "cli/cli-option.h".
3020         (make_value_print_options_def_group): Declare.
3021         (print_value): Change parameter type from format_data pointer to
3022         value_print_options reference.
3023         (print_command_completer): Declare.
3024
3025 2019-06-13  Pedro Alves  <palves@redhat.com>
3026
3027         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3028         (COMMON_SFILES): Add maint-test-settings.c.
3029         * cli/cli-decode.c (boolean_enums): New global, factored out from
3030         ...
3031         (add_setshow_boolean_cmd): ... here.
3032         * cli/cli-decode.h (boolean_enums): Declare.
3033         * cli/cli-option.c: New file.
3034         * cli/cli-option.h: New file.
3035         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3036         factored out from ...
3037         (parse_cli_boolean_value(const char *)): ... this.
3038         (is_unlimited_literal): Change parameter type to pointer to
3039         pointer.  Adjust and advance ARG pointer.
3040         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3041         (parse_cli_var_enum): New, factored out from ...
3042         (do_set_command): ... this.  Adjust.
3043         * cli/cli-setshow.h (parse_cli_boolean_value)
3044         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3045         (parse_cli_var_enum): Declare.
3046         * cli/cli-utils.c: Include "cli/cli-option.h".
3047         (get_ulongest): New.
3048         * cli/cli-utils.h (get_ulongest): Declare.
3049         (check_for_argument): New overloads.
3050         * maint-test-options.c: New file.
3051
3052 2019-06-13  Pedro Alves  <palves@redhat.com>
3053
3054         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3055         parse a range if "-" is at the end of the string.
3056
3057 2019-06-13  Pedro Alves  <palves@redhat.com>
3058
3059         * cli/cli-setshow.c (parse_auto_binary_operation)
3060         (parse_cli_boolean_value): Don't allow "o".
3061
3062 2019-06-13  Pedro Alves  <palves@redhat.com>
3063
3064         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3065         * NEWS: Mention maint test-settings KIND.
3066         * maint-test-settings.c: New file.
3067
3068 2019-06-13  Pedro Alves  <palves@redhat.com>
3069
3070         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3071         completer.
3072         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3073         "set" completers.
3074
3075 2019-06-13  Pedro Alves  <palves@redhat.com>
3076
3077         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3078         after item.
3079
3080 2019-06-13  Pedro Alves  <palves@redhat.com>
3081
3082         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3083
3084 2019-06-13  Pedro Alves <palves@redhat.com>
3085
3086         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3087         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3088         call.
3089         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3090         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3091         calls.
3092         (check_for_argument): Skip spaces after argument.
3093
3094 2019-06-13  Pedro Alves  <palves@redhat.com>
3095
3096         * thread.c (thread_apply_command): Adjust TID parsing.
3097         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3098         detected before end of string.
3099         (tid_is_in_list): Error out if LIST is invalid.
3100
3101 2019-06-13  Pedro Alves  <palves@redhat.com>
3102
3103         * completer.c (complete_line_internal_1): Rewind completion word
3104         point.
3105         (completion_tracker::advance_custom_word_point_by): Change
3106         parameter type to int.
3107         * completer.h (completion_tracker::advance_custom_word_point_by):
3108         Likewise.
3109
3110 2019-06-13  Pedro Alves  <palves@redhat.com>
3111
3112         * completer.c (advance_to_completion_word): Handle delimiters.
3113
3114 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3115
3116         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3117
3118 2019-06-11  Tom Tromey  <tom@tromey.com>
3119
3120         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3121         (xmalloc_failed): Move to alloc.c.
3122         * alloc.c: New file.
3123         * Makefile.in (COMMON_SFILES): Add alloc.c.
3124
3125 2019-06-11  Tom Tromey  <tom@tromey.com>
3126
3127         * nat/linux-waitpid.c: Don't include server.h.
3128         (linux_debug): Remove.
3129         (my_waitpid): Update.
3130
3131 2019-06-11  Tom Tromey  <tromey@adacore.com>
3132
3133         * infcall.c (_initialize_infcall): Remove trailing newline from
3134         help.
3135         * user-regs.c (_initialize_user_regs): Remove trailing newline
3136         from help.
3137         * typeprint.c (_initialize_typeprint): Remove trailing newline
3138         from help.
3139         * reverse.c (_initialize_reverse): Remove trailing newlines from
3140         help.
3141         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3142         from help.
3143         * language.c (add_set_language_command): Remove trailing newline
3144         from help.
3145         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3146         help.
3147         * disasm.c (_initialize_disasm): Remove trailing newline from
3148         help.
3149         * top.c (init_main): Remove trailing newline from help.
3150         * interps.c (_initialize_interpreter): Remove trailing newline
3151         from help.
3152         * btrace.c (_initialize_btrace): Remove trailing newlines from
3153         help.
3154         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3155         from help.
3156         * python/python.c (_initialize_python): Remove trailing newline
3157         from help.
3158         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3159         help.
3160         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3161         from help.  Reformat some text.
3162         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3163         from help.
3164         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3165         newline from help.
3166
3167 2019-06-11  Tom Tromey  <tromey@adacore.com>
3168
3169         * darwin-nat.c (darwin_decode_exception_message)
3170         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3171
3172 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3173
3174         * valops.c (value_slice): Check for not allocated or not
3175         associated values.
3176
3177 2019-06-10  Tom de Vries  <tdevries@suse.de>
3178
3179         PR gdb/24618
3180         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3181         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3182         invalid.
3183
3184 2019-06-10  Tom de Vries  <tdevries@suse.de>
3185
3186         PR gdb/24611
3187         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3188         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3189
3190 2019-06-10  Tom de Vries  <tdevries@suse.de>
3191
3192         PR symtab/24545
3193         * symtab.c (struct demangled_name_entry): Add language field.
3194         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3195         static minimal symbol".  Set and use language field.
3196
3197 2019-06-10  Tom Tromey  <tromey@adacore.com>
3198
3199         * ada-lang.c (_initialize_ada_language): Update help text.
3200
3201 2019-06-10  Tom Tromey  <tromey@adacore.com>
3202
3203         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3204         with a newline.
3205         * guile/guile.c (handle_boot_error): Don't end warning with a
3206         newline.
3207         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3208         warning with a newline.
3209         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3210         newline.
3211         (s12z_frame_cache): Likewise.
3212         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3213         a newline.
3214         * solib-svr4.c (disable_probes_interface): Don't end warning with
3215         a newline.
3216         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3217         newline.
3218         * python/python.c (do_finish_initialization): Don't end warning
3219         with a newline.
3220
3221 2019-06-10  Tom Tromey  <tom@tromey.com>
3222
3223         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3224         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3225         gdbpy_enter.
3226
3227 2019-06-10  Tom Tromey  <tromey@adacore.com>
3228
3229         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3230         data.
3231         (elf_new_init): Don't call stabsread_new_init.
3232         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3233         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3234         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3235
3236 2019-06-10  Tom de Vries  <tdevries@suse.de>
3237
3238         PR symtab/16264
3239         PR symtab/24517
3240         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3241
3242 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3243
3244         * source.c (find_and_open_source): Also rewrite relative file
3245         names.
3246
3247 2019-04-26  Amos Bird  <amosbird@gmail.com>
3248
3249         * annotate.c (annotate_thread_exited): Add "thread-exited"
3250         annotation.
3251
3252 2019-06-06  Tom Tromey  <tromey@adacore.com>
3253
3254         * maint.h (class scoped_command_stats): Use
3255         DISABLE_COPY_AND_ASSIGN.
3256         <print_time>: New method.
3257         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3258         print_time.
3259         (scoped_command_stats::print_time): New method.
3260
3261 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3264         instructions of lengths 6 or 8 bytes.
3265
3266 2019-06-04  Pedro Alves  <palves@redhat.com>
3267
3268         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3269
3270         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3271         * breakpoint.c (condition_completer): Likewise.
3272         * cli/cli-dump.c (scan_expression): Likewise.
3273         * common/filestuff.c (mkdir_recursive): Likewise.
3274         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3275         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3276         (gdb_abspath): Likewise.
3277         * compile/compile-cplus-types.c
3278         (compile_cplus_instance::decl_name): Likewise.
3279         * completer.c (complete_explicit_location):
3280         (signal_completer, reg_or_group_completer_1): Likewise.
3281         * cp-support.c (cp_remove_params_if_any): Likewise.
3282         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3283         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3284         * infcmd.c (strip_bg_char): Likewise.
3285         * linespec.c (copy_token_string): Likewise.
3286         * mi/mi-main.c (output_cores): Likewise.
3287         * psymtab.c (psymtab_search_name):
3288         * symfile.c (test_set_ext_lang_command): Likewise.
3289         * target.c (target_fileio_read_stralloc): Likewise.
3290         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3291         * value.c (complete_internalvar): Likewise.
3292
3293 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3294
3295         Add objfile property to gdb.Type.
3296         * NEWS: Mention Python API addition.
3297         * python/py-type.c (typy_get_objfile): New method.
3298
3299 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3300
3301         * NEWS: Mention the new set|show style [title|highlight].
3302         Mention changes to "show style", "help" and "apropos".
3303
3304 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3305
3306         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3307         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3308         instead of print_help_for_command.
3309         (print_doc_of_command): New function.
3310         (help_list): Add 'apropos -v word' suggestion.
3311         (print_help_for_command): Style the command name using title style.
3312         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3313         (_initialize_cli_cmds): Describe -v in apropos_command help.
3314
3315 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3316
3317         * cli/cli-style.h (cli_style_option): Add name in constructor,
3318         add m_name class member, add constructor with intensity,
3319         add name class function.
3320         (cli_style_option::add_setshow_commands): Remove name argument.
3321         (highlight_style, title_style): New styles.
3322         * cli/cli-style.c (do_show): New function that shows a style
3323         characteristic styling the style name with itself.
3324         (set_style_name): New function.
3325         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3326         Update all callers according to the changes in cli/cli-style.h.
3327         * utils.h (fputs_highlighted): New function.
3328         * utils.c (fputs_highlighted): Likewise.
3329
3330 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3331
3332         * NEWS: Mention new pipe command and new convenience variables.
3333
3334 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3335
3336         * cli/cli-cmds.c (pipe_command): New function.
3337         (_initialize_cli_cmds): Call add_com for pipe_command.
3338         Define | as an alias for pipe.
3339         (exit_status_set_internal_vars): New function.
3340         (shell_escape): Call exit_status_set_internal_vars.
3341         cli/cli-decode.c (find_command_name_length): Recognize | as
3342         a single character command.
3343
3344 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3345
3346         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3347         top.c (execute_command_to_ui_file): New function, mostly a copy
3348         of execute_command_to_string.
3349         (execute_command_to_string): Implement by calling
3350         execute_command_to_ui_file.
3351
3352 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3353
3354         * top.h (saved_command_line): Remove declaration.
3355         * top.c (previous_saved_command_line, previous_repeat_arguments):
3356         New variables.
3357         (saved_command_line): Make static, define together with other
3358         'repeat variables'.
3359         (dont_repeat): Clear repeat_arguments.
3360         (repeat_previous, get_saved_command_line, save_command_line):
3361         New functions.
3362         (gdb_init): Initialize saved_command_line
3363         and previous_saved_command_line.
3364         * main.c (captured_main_1): Remove saved_command_line initialization.
3365         * event-top.c (handle_line_of_input): Update to use
3366         the new 'repeat' related functions instead of direct access to
3367         saved_command_line.
3368         * command.h (repeat_previous, get_saved_command_line,
3369         save_command_line): New declarations.
3370         (dont_repeat): Add comment.
3371
3372 2019-05-30  Tom Tromey  <tromey@adacore.com>
3373
3374         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3375         Fix comment.
3376         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3377
3378 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3379
3380         PR cli/24587
3381         * completer.c (complete): Initialize variable word.
3382
3383 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3384
3385         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3386         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3387         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3388         'body' is NULL to the outter 'if', protecting the '!is_define'
3389         situation as well.
3390
3391 2019-05-29  Tom Tromey  <tromey@adacore.com>
3392
3393         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3394         (dwarf_unknown): New function.
3395         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3396         (dwarf_type_encoding_name): Use dwarf_unknown.
3397
3398 2019-05-29  Tom Tromey  <tromey@adacore.com>
3399
3400         PR c++/20020:
3401         * cp-valprint.c (cp_print_value_fields): Call
3402         cp_print_static_field inside "try".
3403
3404 2019-05-29  Tom Tromey  <tromey@adacore.com>
3405
3406         * inflow.c (struct terminal_info): Add default operator=.
3407         * configure: Rebuild.
3408         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3409         -Wdeprecated-copy-dtor, -Wredundant-move.
3410
3411 2019-05-29  Tom Tromey  <tromey@adacore.com>
3412
3413         * NEWS: Add entry.
3414         * infcmd.c (print_return_value_1): Handle finish_print
3415         option.
3416         (show_print_finish): New function.
3417         (_initialize_infcmd): Add "set/show print finish" commands.
3418         * valprint.c (user_print_options): Initialize new member.
3419         * valprint.h (struct value_print_options) <finish_print>: New
3420         member.
3421
3422 2019-05-28  Tom Tromey  <tromey@adacore.com>
3423
3424         * ada-lang.c (ada_remove_Xbn_suffix)
3425         (find_old_style_renaming_symbol)
3426         (parse_old_style_renaming): Remove.
3427         (ada_find_renaming_symbol): Don't call
3428         find_old_style_renaming_symbol.
3429         (ada_is_renaming_symbol): Rename from
3430         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3431         bool.  Now static.
3432         (ada_read_var_value): Update and simplify.
3433         * ada-exp.y (write_var_or_type): Remove old code.
3434
3435 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3436
3437         * event-top.c: Remove include comment.
3438         * inflow.c (class scoped_ignore_sigttou): Move from here...
3439         * inflow.h (class scoped_ignore_sigttou): ...to here.
3440         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3441         * top.c:  Remove include comment.
3442
3443 2019-05-27  Tom Tromey  <tom@tromey.com>
3444
3445         * NEWS: Fix typo.
3446
3447 2019-05-22  Tom Tromey  <tromey@adacore.com>
3448
3449         * target.c (target_follow_exec): Constify parameter.
3450         * target-delegates.c: Rebuild.
3451         * remote.c (remote_target::follow_exec): Constify parameter.
3452         * infrun.c (follow_exec): Constify parameter.
3453         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3454         (target_follow_exec): Likewise.
3455
3456 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3457
3458         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3459         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3460
3461 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3462
3463         * NEWS: Add debugredirect and testsuite sections.
3464
3465 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3466
3467         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3468         target descriptions using exclusively floating point register name
3469         aliases.
3470
3471 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3472
3473         PR gdb/18644:
3474         * f-lang.c (build_fortran_types): Handle the case where
3475         gdbarch_floatformat_for_type returns a nullptr.
3476
3477 2019-05-21  Tom de Vries  <tdevries@suse.de>
3478
3479         PR cli/24587
3480         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3481
3482 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3483
3484         PR gdb/18644:
3485         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3486         16-byte floats.
3487         * i386-tdep.c (i386_floatformat_for_type): Use
3488         floatformats_ia64_quad for the 16-byte floating point component
3489         within a fortran 32-byte complex number.
3490
3491 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3494         delete default constructor.
3495         (find_partial_die): Update to return const struct.
3496         (partial_die_parent_scope): Move variable declaration into scope
3497         of its use and change its type to auto.
3498         (guess_partial_die_structure_name): Likewise.
3499         (partial_die_info::fixup): Likewise.
3500
3501 2019-05-17  Tom Tromey  <tromey@adacore.com>
3502
3503         * source.c (find_and_open_source): Remove cast.
3504
3505 2019-05-17  Tom Tromey  <tromey@adacore.com>
3506
3507         * annotate.c (annotate_source): Make "filename" const.
3508         * annotate.h (annotate_source): Use const.
3509
3510 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3511
3512         * disasm.c (set_disassembler_options): Send errors to stderr.
3513
3514 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3517         (cli_interp_base::set_logging): Check debug_redirect.
3518         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3519         * cli/cli-logging.c (debug_redirect): Add static variable.
3520         (pop_output_files): Add default param.
3521         (handle_redirections): Print debug setting.
3522         (show_logging_command): Likewise.
3523         (_initialize_cli_logging): Add debugredirect command.
3524         * interps.c (current_interp_set_logging): Add debug_redirect
3525         parameter.
3526         * interps.h (set_logging): Add debug_redirect parameter.
3527         (current_interp_set_logging): Likewise.
3528         * mi/mi-common.h: Likewise.
3529         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3530
3531 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3532             Tom Tromey  <tromey@adacore.com>
3533
3534         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3535         directly.
3536         * cli/cli-interp.h (make_logging_output): Remove declaration.
3537         * cli/cli-logging.c (make_logging_output): Remove function.
3538         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3539         directly.
3540         * ui-file.c (tee_file::tee_file): Remove bools.
3541         (tee_file::~tee_file): Remove deletes.
3542         * ui-file.h (tee_file): Remove bools.
3543
3544 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3545
3546         * mi/mi-cmds.h (mi_cmd_complete): New function.
3547         * mi/mi-main.c (mi_cmd_complete): Likewise.
3548         * mi/mi-cmds.c: Define new MI command -complete.
3549         * NEWS: Mention new -complete command.
3550
3551 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3552
3553         * completer.h (complete): New function.
3554         * completer.c (complete): Likewise.
3555         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3556         function defined in completer.h.
3557
3558 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3559
3560         * MAINTAINERS (Write After Approval): Add myself.
3561
3562 2019-05-17  Tom de Vries  <tdevries@suse.de>
3563
3564         PR gdb/24094
3565         * dwarf2read.c (struct cu_partial_die_info): New struct.
3566         (find_partial_die): Return cu_partial_die_info.
3567         (partial_die_parent_scope, guess_partial_die_structure_name)
3568         (partial_die_info::fixup): Handle new return type of find_partial_die.
3569
3570 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3571
3572         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3573         "std::string", simplifying the algorithm.
3574
3575 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3576
3577         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3578         (stap_static_probe_ops::get_probes): Likewise.
3579
3580 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3581
3582         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3583         '-')" and "else if".
3584         (stap_parse_single_operand): Join checks for
3585         "gdbarch_stap_parse_special_token_p" and
3586         "gdbarch_stap_parse_special_token" in the same "if" statement.
3587         Invert check when verifying for operation on register
3588         displacement.
3589
3590 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3591
3592         * stap-probe.c (stap_get_opcode): Update comment.
3593         (stap_get_expected_argument_type): Likewise.
3594         (handle_stap_probe): Likewise.
3595
3596 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3597
3598         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3599         return type to 'bool'.  Adjust comment.  Use 'bool' when
3600         appropriate.
3601         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3602         * stap-probe.c (stap_parse_argument_1): Likewise.
3603         (stap_is_operator): Likewise.
3604         (stap_is_generic_prefix): Likewise.
3605         (stap_is_register_prefix): Likewise.
3606         (stap_is_register_indirection_prefix): Likewise.
3607         (stap_is_integer_prefix): Likewise.
3608         (stap_generic_check_suffix): Likewise.
3609         (stap_check_integer_suffix): Likewise.
3610         (stap_check_register_suffix): Likewise.
3611         (stap_check_register_indirection_suffix): Likewise.
3612         (stap_parse_register_operand): Likewise.
3613         (stap_parse_single_operand): Likewise.
3614         (stap_parse_argument_1): Likewise.
3615         (stap_probe::get_argument_count): Likewise.
3616         (stap_is_operator): Likewise.
3617
3618 2019-05-16  Tom Tromey  <tromey@adacore.com>
3619
3620         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3621         keyword to foreach.
3622
3623 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3624
3625         * linux-thread-db.c (try_thread_db_load_1): Change return type
3626         to bool.
3627         (try_thread_db_load): Likewise.
3628         (try_thread_db_load_from_pdir_1): Likewise.
3629         (try_thread_db_load_from_pdir): Likewise.
3630         (try_thread_db_load_from_sdir): Likewise.
3631         (try_thread_db_load_from_dir): Likewise.
3632         (thread_db_load_search): Likewise.
3633         (has_libpthread): Likewise.
3634         (thread_db_load): Likewise.
3635
3636 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3637
3638         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3639         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3640         NULL, and complain/return if that's the case.
3641
3642 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3643
3644         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3645         (advance, posn, abstract_read_memory): New functions.
3646         [struct mem_read_abstraction]: New struct.
3647         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3648
3649 2019-05-14  Tom Tromey  <tromey@adacore.com>
3650
3651         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3652         value is not lval_memory.
3653
3654 2019-05-14  Tom Tromey  <tromey@adacore.com>
3655
3656         * solib.c (info_sharedlibrary_command): Style the file name.
3657
3658 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3659
3660         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3661         (aarch64_vnv_type): Likewise.
3662         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3663         * common/tdesc.c: Likewise.
3664         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3665         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3666         * features/aarch64-fpu.xml: Add ieee half view.
3667         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3668         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3669         * gdbtypes.h (struct builtin_type): Likewise.
3670         (struct objfile_type): Likewise.
3671
3672 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3673
3674         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3675         typo.
3676         * location.h (string_to_event_location): Likewise.
3677
3678 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3679
3680         GDB 8.3 released.
3681
3682 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3683
3684         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3685         New variable declaration.
3686         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3687         New variable.
3688         (print_one_breakpoint): Use ui_out::test_flags and new global
3689         variable to compute use_fixed_output.
3690         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3691         Remove.
3692         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3693         (mi_multi_location_breakpoint_output_fixed): Remove.
3694         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3695         new variable.
3696         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3697         fix_multi_location_breakpoint_output flag if version >= 3.
3698         * ui-out.h (enum ui_out_flag)
3699         <fix_multi_location_breakpoint_output>: New enumerator.
3700
3701 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3702
3703         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3704
3705 2019-05-10  Tom Tromey  <tromey@adacore.com>
3706
3707         * ada-lang.c (catch_ada_completer): New function.
3708         (_initialize_ada_language): Use it.
3709
3710 2019-05-10  Tom Tromey  <tromey@adacore.com>
3711
3712         * thread.c (print_thread_info): Make "requested_threads" const.
3713         * gdbthread.h (print_thread_info): Make "requested_threads"
3714         const.
3715         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3716         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3717
3718 2019-05-08  Tom Tromey  <tom@tromey.com>
3719
3720         * gdbtypes.c (objfile_type_data): Change type.
3721         (objfile_type, _initialize_gdbtypes): Update.
3722
3723 2019-05-08  Tom Tromey  <tom@tromey.com>
3724
3725         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3726         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3727         (_initialize_dwarf2_frame): Update.
3728
3729 2019-05-08  Tom Tromey  <tom@tromey.com>
3730
3731         * objc-lang.c (objc_objfile_data): Change type.
3732         (find_methods): Update.
3733         (_initialize_objc_lang): Remove.
3734
3735 2019-05-08  Tom Tromey  <tom@tromey.com>
3736
3737         * stabsread.c (rs6000_builtin_type_data): Change type.
3738         (rs6000_builtin_type, _initialize_stabsread): Update.
3739
3740 2019-05-08  Tom Tromey  <tom@tromey.com>
3741
3742         * mips-tdep.c (mips_pdr_data): Remove.
3743         (_initialize_mips_tdep): Update.
3744
3745 2019-05-08  Tom Tromey  <tom@tromey.com>
3746
3747         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3748         (hppa_init_objfile_priv_data, read_unwind_info)
3749         (find_unwind_entry, _initialize_hppa_tdep): Update.
3750
3751 2019-05-08  Tom Tromey  <tom@tromey.com>
3752
3753         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3754         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3755         on obstack.
3756         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * mdebugread.c (basic_type_data): Change type.
3761         (basic_type, _initialize_mdebugread): Update.
3762
3763 2019-05-08  Tom Tromey  <tom@tromey.com>
3764
3765         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3766
3767 2019-05-08  Tom Tromey  <tom@tromey.com>
3768
3769         * nto-tdep.c (nto_inferior_data_reg): Change type.
3770         (nto_inferior_data): Update.
3771         (nto_inferior_data_cleanup, nto_new_inferior_data)
3772         (_initialize_nto_tdep): Remove.
3773         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3774
3775 2019-05-08  Tom Tromey  <tom@tromey.com>
3776
3777         * ada-lang.c (struct ada_inferior_data): Add initializers.
3778         (ada_inferior_data): Change type.
3779         (ada_inferior_data_cleanup): Remove.
3780         (get_ada_inferior_data, ada_inferior_exit)
3781         (struct ada_pspace_data): Add initializers, destructor.
3782         (ada_pspace_data_handle): Change type.
3783         (get_ada_pspace_data): Update.
3784         (ada_pspace_data_cleanup): Remove.
3785
3786 2019-05-08  Tom Tromey  <tom@tromey.com>
3787
3788         * coffread.c (struct coff_symfile_info): Add initializers.
3789         (coff_objfile_data_key): Move lower.  Change type.
3790         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3791         Update.
3792         (coff_free_info): Remove.
3793
3794 2019-05-08  Tom Tromey  <tom@tromey.com>
3795
3796         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3797         (fbsd_pspace_data_handle): Move lower.  Change type.
3798         (get_fbsd_pspace_data): Update.
3799         (fbsd_pspace_data_cleanup): Remove.
3800         (_initialize_fbsd_tdep): Update.
3801
3802 2019-05-08  Tom Tromey  <tom@tromey.com>
3803
3804         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3805         (get_ada_tasks_pspace_data): Update.
3806         (ada_tasks_pspace_data_cleanup): Remove.
3807         (_initialize_tasks): Update.
3808         (ada_tasks_inferior_data_handle): Change type.
3809         (get_ada_tasks_inferior_data): Update.
3810         (ada_tasks_inferior_data_cleanup): Remove.
3811         (struct ada_tasks_pspace_data): Add initializers.
3812
3813 2019-05-08  Tom Tromey  <tom@tromey.com>
3814
3815         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3816         * symfile-debug.c (debug_sym_get_probes): Change type.
3817         * stap-probe.c (handle_stap_probe):
3818         (stap_static_probe_ops::get_probes): Change type.
3819         * probe.h (class static_probe_ops) <get_probes>: Change type.
3820         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3821         (parse_probes_in_pspace): Update.
3822         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3823         Update.
3824         (any_static_probe_ops::get_probes): Change type.
3825         * elfread.c (elfread_data): New typedef.
3826         (probe_key): Change type.
3827         (elf_get_probes): Likewise.  Update.
3828         (probe_key_free): Remove.
3829         (_initialize_elfread): Update.
3830         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3831         Change type.
3832         (dtrace_process_dof_probe, dtrace_process_dof)
3833         (dtrace_static_probe_ops::get_probe): Change type.
3834
3835 2019-05-08  Tom Tromey  <tom@tromey.com>
3836
3837         * xcoffread.c (struct xcoff_symfile_info): Rename from
3838         coff_symfile_info.  Add initializers.
3839         (xcoff_objfile_data_key): Move lower.  Change type.
3840         (XCOFF_DATA): Rewrite.
3841         (xcoff_free_info): Remove.
3842         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3843         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3844         (xcoff_initial_scan): Update.
3845
3846 2019-05-08  Tom Tromey  <tom@tromey.com>
3847
3848         * solib-svr4.c (struct svr4_info): Add initializers and
3849         destructor.
3850         <probes_table>: Now an htab_up.
3851         (solib_svr4_pspace_data): Change type.
3852         (free_probes_table): Simplify.
3853         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3854         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3855         (probes_table_remove_objfile_probes, register_solib_event_probe)
3856         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3857         (_initialize_svr4_solib): Update.
3858
3859 2019-05-08  Tom Tromey  <tom@tromey.com>
3860
3861         * remote.c (remote_pspace_data): Change type.
3862         (remote_pspace_data_cleanup): Remove.
3863         (get_remote_exec_file, set_pspace_remote_exec_file)
3864         (_initialize_remote): Update.
3865
3866 2019-05-08  Tom Tromey  <tom@tromey.com>
3867
3868         * breakpoint.c (breakpoint_objfile_key): Change type.
3869         (get_breakpoint_objfile_data): Update.
3870         (free_breakpoint_objfile_data): Remove.
3871         (_initialize_breakpoint): Update.
3872
3873 2019-05-08  Tom Tromey  <tom@tromey.com>
3874
3875         * linux-tdep.c (struct linux_info): Add initializers.
3876         (linux_inferior_data): Move.  Change type.
3877         (invalidate_linux_cache_inf): Update.
3878         (linux_inferior_data_cleanup): Remove.
3879         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3880
3881 2019-05-08  Tom Tromey  <tom@tromey.com>
3882
3883         * auxv.c (auxv_inferior_data): Move.  Change type.
3884         (auxv_inferior_data_cleanup): Remove.
3885         (invalidate_auxv_cache_inf): Rewrite.
3886         (get_auxv_inferior_data, _initialize_auxv): Update.
3887
3888 2019-05-08  Tom Tromey  <tom@tromey.com>
3889
3890         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3891         (symfile_debug_objfile_data_key): Change type.
3892         (symfile_debug_installed, debug_qf_has_symbols)
3893         (debug_qf_find_last_source_symtab)
3894         (debug_qf_forget_cached_source_info)
3895         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3896         (debug_qf_print_stats, debug_qf_dump)
3897         (debug_qf_expand_symtabs_for_function)
3898         (debug_qf_expand_all_symtabs)
3899         (debug_qf_expand_symtabs_with_fullname)
3900         (debug_qf_map_matching_symbols)
3901         (debug_qf_expand_symtabs_matching)
3902         (debug_qf_find_pc_sect_compunit_symtab)
3903         (debug_qf_map_symbol_filenames)
3904         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3905         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3906         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3907         (debug_sym_read_linetable, debug_sym_relocate): Update.
3908         (symfile_debug_free_objfile): Remove.
3909         (install_symfile_debug_logging, _initialize_symfile_debug):
3910         Update.
3911
3912 2019-05-08  Tom Tromey  <tom@tromey.com>
3913
3914         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3915         allocate_on_obstack.
3916         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3917         (get_dwarf2_per_objfile): Update.
3918         (set_dwarf2_per_objfile): Remove.
3919         (dwarf2_has_info, dwarf2_get_section_info): Update.
3920         (dwarf2_free_objfile): Remove.
3921         (_initialize_dwarf2_read): Update.
3922
3923 2019-05-08  Tom Tromey  <tom@tromey.com>
3924
3925         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3926         initializers.
3927         <unsupported_script_warning_printed,
3928         script_not_found_warning_printed>: Now bool.
3929         (auto_load_pspace_data): Change type.
3930         (~auto_load_pspace_info): Rename from
3931         auto_load_pspace_data_cleanup.
3932         (get_auto_load_pspace_data, init_loaded_scripts_info)
3933         (clear_section_scripts, maybe_print_unsupported_script_warning)
3934         (maybe_print_script_not_found_warning, _initialize_auto_load):
3935         Update.
3936
3937 2019-05-08  Tom Tromey  <tom@tromey.com>
3938
3939         * objfiles.c (objfile_pspace_info): Add destructor and
3940         initializers.
3941         (objfiles_pspace_data): Change type.
3942         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3943         (get_objfile_pspace_data): Update.
3944         (objfiles_bfd_data): Change type.
3945         (get_objfile_bfd_data): Update.
3946         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3947
3948 2019-05-08  Tom Tromey  <tom@tromey.com>
3949
3950         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3951         Change type.
3952         (get_catch_syscall_inferior_data): Update.
3953         (catch_syscall_inferior_data_cleanup): Remove.
3954         (_initialize_break_catch_syscall): Update.
3955
3956 2019-05-08  Tom Tromey  <tom@tromey.com>
3957
3958         * inflow.c (struct terminal_info): Add destructor and
3959         initializers.
3960         (inflow_inferior_data): Change type.
3961         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3962         (get_inflow_inferior_data, inflow_inferior_exit)
3963         (swap_terminal_info, _initialize_inflow): Update.
3964
3965 2019-05-08  Tom Tromey  <tom@tromey.com>
3966
3967         * target-dcache.c (target_dcache_cleanup): Remove.
3968         (target_dcache_aspace_key): Change type.
3969         (target_dcache_init_p, target_dcache_invalidate)
3970         (target_dcache_get, target_dcache_get_or_init)
3971         (_initialize_target_dcache): Update.
3972         * dcache.h (struct dcache_deleter): New.
3973
3974 2019-05-08  Tom Tromey  <tom@tromey.com>
3975
3976         * symtab.c (struct symbol_cache): Add destructor and
3977         initializers.
3978         (symbol_cache_key): Move.  Change type.
3979         (make_symbol_cache, free_symbol_cache): Remove.
3980         (get_symbol_cache): Update.
3981         (symbol_cache_cleanup): Remove.
3982         (ALL_PSPACES, symbol_cache_flush)
3983         (maintenance_print_symbol_cache)
3984         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3985         Update.
3986
3987 2019-05-08  Tom Tromey  <tom@tromey.com>
3988
3989         * symtab.c (struct main_info): Add destructor and initializers.
3990         (main_progspace_key): Move.  Change type.
3991         (get_main_info): Update.
3992         (main_info_cleanup): Remove.
3993         (_initialize_symtab): Update.
3994
3995 2019-05-08  Tom Tromey  <tom@tromey.com>
3996
3997         * registry.h (DECLARE_REGISTRY): Define the _key class.
3998
3999 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * NEWS: Merge two 'New commands' sections.
4002
4003 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4004
4005         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4006         parameter and use Ada language definition instead.
4007         (ada_val_print_ptr): Remove unused language parameter.
4008         (ada_val_print_num): Remove language parameter and use Ada language
4009         definition instead.
4010         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4011         parameter.
4012         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4013         parameter and use Ada language definition instead.
4014         (ada_val_print_1): Update all ada_val_print_xxx calls.
4015         Remove language parameter.
4016         (ada_val_print): Update ada_val_print_1 call.
4017
4018 2019-05-08  Tom Tromey  <tromey@adacore.com>
4019
4020         * remote.c (remote_hw_watchpoint_limit)
4021         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4022         Now static.
4023
4024 2019-05-08  Tom Tromey  <tromey@adacore.com>
4025
4026         * maint.c (_initialize_maint_cmds): Move initialization code to
4027         remote.c.
4028         (watchdog, show_watchdog): Move to remote.c.
4029         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4030         "watchdog" static.
4031         (_initialize_remote): Move initialization code from maint.c.
4032         * defs.h (watchdog): Don't declare.
4033
4034 2019-05-08  Tom Tromey  <tromey@adacore.com>
4035
4036         * tui/tui-interp.c: Include main.h.
4037         * interps.c: Include main.h.
4038         * main.h (interpreter_p): Declare.
4039         * defs.h (interpreter_p): Don't declare.
4040
4041 2019-05-08  Tom Tromey  <tromey@adacore.com>
4042
4043         * dwarf2loc.c: Include dwarf2read.h.
4044         * defs.h (read_unsigned_leb128): Don't declare.
4045         * dwarf2read.h (read_unsigned_leb128): Declare.
4046
4047 2019-05-08  Tom Tromey  <tromey@adacore.com>
4048
4049         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4050         method.
4051
4052 2019-05-08  Tom Tromey  <tromey@adacore.com>
4053
4054         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4055         when no wrap column is set.
4056
4057 2019-05-08  Tom Tromey  <tromey@adacore.com>
4058
4059         * c-lang.c (c_get_string): Handle non-C-style arrays.
4060
4061 2019-05-08  Tom Tromey  <tromey@adacore.com>
4062
4063         * typeprint.c (print_offset_data::update): Print the bit offset,
4064         not the number of bits remaining.
4065
4066 2019-05-08  Tom Tromey  <tromey@adacore.com>
4067
4068         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4069         padding at end of comment.
4070
4071 2019-05-08  Tom Tromey  <tromey@adacore.com>
4072
4073         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4074         Compare main types.
4075
4076 2019-05-06  Tom Tromey  <tom@tromey.com>
4077
4078         * common/scoped_mmap.c: Include common-defs.h.
4079         * common/scoped_mmap.h: Don't include config.h.
4080
4081 2019-05-04  Tom Tromey  <tom@tromey.com>
4082
4083         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4084         (struct aarch64_call_info): Add initializers.
4085         <si>: Now a std::vector.
4086         (pass_on_stack, aarch64_push_dummy_call): Update.
4087
4088 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4089             Tom Tromey  <tom@tromey.com>
4090
4091         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4092         (ppc_threads): Now a std::vector.  Now static.
4093         (hwdebug_find_thread_points_by_tid)
4094         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4095         Update.
4096
4097 2019-05-04  Tom Tromey  <tom@tromey.com>
4098
4099         * arc-tdep.c (arc_tdesc_init): Return bool.
4100
4101 2019-05-04  Tom Tromey  <tom@tromey.com>
4102
4103         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4104         Use gdb_assert_not_reached.
4105
4106 2019-05-04  Tom Tromey  <tom@tromey.com>
4107
4108         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4109         "false".
4110
4111 2019-05-04  Tom Tromey  <tom@tromey.com>
4112
4113         * arc-tdep.c (arc_tdesc_init): Use bool.
4114
4115 2019-05-04  Tom Tromey  <tom@tromey.com>
4116
4117         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4118
4119 2019-05-04  Tom Tromey  <tom@tromey.com>
4120
4121         * cli/cli-cmds.c (valid_command_p): Return bool.
4122
4123 2019-05-04  Tom Tromey  <tom@tromey.com>
4124
4125         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4126         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4127
4128 2019-05-04  Raul Tambre  <raul@tambre.ee>
4129
4130         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4131         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4132         operator for comparison.
4133
4134 2019-05-04  Tom Tromey  <tom@tromey.com>
4135
4136         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4137         (lookup_partial_symbol, print_partial_symbols)
4138         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4139         (psymbol_compare): Update.
4140         (add_psymbol_to_bcache): Clear the entire psymbol.
4141         (maintenance_check_psymtabs): Update.
4142         * psympriv.h (struct partial_symbol): Don't derive from
4143         general_symbol_info.
4144         <obj_section, unrelocated_address, address,
4145         set_unrelocated_address>: Update.
4146         <ginfo>: New member.
4147         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4148         (debug_names::write_psymbols): Update.
4149
4150 2019-05-04  Tom de Vries  <tdevries@suse.de>
4151
4152         * contrib/cc-with-tweaks.sh: Support -n arg.
4153
4154 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4155
4156         * corelow.c (core_target::detach): Ensure frame cache and
4157         register caches are cleared.
4158         inferior.c (exit_inferior_1): Likewise.
4159
4160 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4161             Tom Tromey  <tom@tromey.com>
4162
4163         * dictionary.c (collate_pending_symbols_by_language): Remove
4164         "struct" from foreach.
4165         * symtab.c (lookup_global_symbol_from_objfile)
4166         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4167         foreach.
4168         * ser-tcp.c (net_open): Remove "struct" from foreach.
4169         * objfiles.c (objfile_relocate, objfile_rebase)
4170         (objfile_has_symbols): Remove "struct" from foreach.
4171         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4172         from foreach.
4173         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4174         foreach.
4175         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4176         "struct" from foreach.
4177         * ada-lang.c (create_excep_cond_exprs)
4178         (ada_exception_catchpoint_cond_string): Remove "struct" from
4179         foreach.
4180
4181 2019-05-03  Tom Tromey  <tromey@adacore.com>
4182
4183         * ada-exp.y (convert_char_literal): Check suffix of each
4184         enumerator.
4185
4186 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4187
4188         PR ada/21406:
4189         * ada-exp.y (yywrap): Don't define.
4190         * ada-lex.l (%option): Add noyywrap
4191         (yywrap): Remove.
4192
4193 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4194
4195         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4196         _WIN32_WINNT to the XP level, unless already defined to a higher
4197         level.
4198
4199         * unittests/parse-connection-spec-selftests.c:
4200         * ser-tcp.c:
4201         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4202         override.
4203
4204         * symfile.c (find_separate_debug_file): Remove colon from the
4205         drive spec of DOS/Windows file names of the target, so that the
4206         file name produced from DEBUGDIR and the target's directory will
4207         be valid on DOS/Windows systems.
4208
4209 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * rust-lang.c (val_print_struct): Handle printing structures
4212         containing strings.
4213
4214 2019-05-02  Tom Tromey  <tromey@adacore.com>
4215
4216         * valarith.c (_initialize_valarith): Remove.
4217
4218 2019-05-01  Tom Tromey  <tromey@adacore.com>
4219
4220         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4221         bitfields.
4222
4223 2019-05-01  Tom Tromey  <tromey@adacore.com>
4224
4225         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4226         for big-endian copies.
4227
4228 2019-04-30  Ali Tamur  <tamur@google.com>
4229         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4230         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4231         (read_3_bytes): New function.
4232
4233 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4234
4235         * windows-nat.c (main_thread_id): Delete.
4236         (handle_output_debug_string): Replace main_thread_id by
4237         current_event.dwThreadId.
4238         (fake_create_process): Likewise.
4239         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4240         Do not set main_thread_id.
4241         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4242         current_event.dwThreadId.
4243         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4244
4245 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4246
4247         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4248         Use current_event.dwThreadId instead of main_thread_id.
4249
4250 2019-04-30  Tom Tromey  <tromey@adacore.com>
4251
4252         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4253         (create_excep_cond_exprs): Iterate over program spaces.
4254         (ada_exception_catchpoint_cond_string): Examine all minimal
4255         symbols for exception types.
4256
4257 2019-04-30  Tom Tromey  <tromey@adacore.com>
4258
4259         PR c++/24470:
4260         * dwarf2read.c (process_structure_scope): Handle case where type
4261         has template parameters but no symbol was created.
4262
4263 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4264             Chris January  <chris.january@arm.com>
4265
4266         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4267         qualifier.
4268         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4269
4270 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * f-typeprint.c (f_print_type): Update rules for printing
4273         whitespace.
4274         (f_type_print_varspec_suffix): Likewise.
4275
4276 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4277             Chris January  <chris.january@arm.com>
4278
4279         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4280         function arguments.
4281
4282 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * f-lang.c (build_fortran_types): Change name of void type to
4285         lower case.
4286         * f-typeprint.c (f_type_print_base): Print the name of the void
4287         type, rather than a fixed string.
4288         * f-valprint.c (f_decorations): Use lower case void string.
4289
4290 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4291             Chris January  <chris.january@arm.com>
4292
4293         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4294         types for Fortran.
4295
4296 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4297             Chris January  <chris.january@arm.com>
4298             David Lecomber  <david.lecomber@arm.com>
4299
4300         * f-exp.y (BINOP_INTRINSIC): New token.
4301         (exp): New parser rule handling BINOP_INTRINSIC.
4302         (f77_keywords): Add new builtin procedures.
4303         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4304         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4305         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4306         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4307         (print_unop_subexp_f): New function.
4308         (print_binop_subexp_f): New function.
4309         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4310         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4311         (dump_subexp_body_f): Likewise.
4312         (operator_check_f): Likewise.
4313         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4314         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4315
4316 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4319         UNOP_KIND.
4320         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4321         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4322         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4323         (operator_length_f): New fuction.
4324         (print_subexp_f): New function.
4325         (op_name_f): New function.
4326         (dump_subexp_body_f): New function.
4327         (operator_check_f): New function.
4328         (exp_descriptor_f): Replace standard expression handling functions
4329         with new functions.
4330         * gdb/fortran-operator.def: New file.
4331         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4332         * gdb/std-operator.def: Remove UNOP_KIND.
4333
4334 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4335
4336         * std-operator.def: Remove unbalanced, stray double quote
4337         character.
4338
4339 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4340             Chris January  <chris.january@arm.com>
4341             Daniel Everett  <daniel.everett@arm.com>
4342             Nick Forrington  <nick.forrington@arm.com>
4343             Richard Bunt  <richard.bunt@arm.com>
4344
4345         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4346         of depth when printing anonymous structs or unions.
4347         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4348         Don't print either the top-level value, or the children if the
4349         max-depth is exceeded.
4350         (ppscm_print_children): When printing the key of a map, allow one
4351         extra level of depth.
4352         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4353         print either the top-level value, or the children if the max-depth
4354         is exceeded.
4355         (print_children): When printing the key of a map, allow one extra
4356         level of depth.
4357         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4358         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4359         (user_print_options): Initialise max_depth field.
4360         (val_print_scalar_or_string_type_p): New function.
4361         (val_print): Check to see if the max depth has been reached.
4362         (val_print_check_max_depth): Define new function.
4363         (show_print_max_depth): New function.
4364         (_initialize_valprint): Add 'print max-depth' option.
4365         * valprint.h (struct value_print_options) <max_depth>: New field.
4366         (val_print_check_max_depth): Declare new function.
4367         * NEWS: Document new feature.
4368
4369 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4370
4371         * ada-lang.c (ada_language_defn): Initialise new field.
4372         * c-lang.c (c_is_string_type_p): New function.
4373         (c_language_defn): Initialise new field.
4374         (cplus_language_defn): Initialise new field.
4375         (asm_language_defn): Initialise new field.
4376         (minimal_language_defn): Initialise new field.
4377         * c-lang.h (c_is_string_type_p): Declare new function.
4378         * d-lang.c (d_language_defn): Initialise new field.
4379         * f-lang.c (f_is_string_type_p): New function.
4380         (f_language_defn): Initialise new field.
4381         * go-lang.c (go_is_string_type_p): New function.
4382         (go_language_defn): Initialise new field.
4383         * language.c (default_is_string_type_p): New function.
4384         (unknown_language_defn): Initialise new field.
4385         (auto_language_defn): Initialise new field.
4386         * language.h (struct language_defn) <la_is_string_type_p>: New
4387         member variable.
4388         (default_is_string_type_p): Declare new function.
4389         * m2-lang.c (m2_language_defn): Initialise new field.
4390         * objc-lang.c (objc_language_defn): Initialise new field.
4391         * opencl-lang.c (opencl_language_defn): Initialise new field.
4392         * p-lang.c (pascal_is_string_type_p): New function.
4393         (pascal_language_defn): Initialise new field.
4394         * rust-lang.c (rust_is_string_type_p): New function.
4395         (rust_language_defn): Initialise new field.
4396
4397 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4400         New field.
4401         * ada-lang.c (ada_language_defn): Initialise new field.
4402         * c-lang.c (c_language_defn): Likewise.
4403         (cplus_language_defn): Likewise.
4404         (asm_language_defn): Likewise.
4405         (minimal_language_defn): Likewise.
4406         * d-lang.c (d_language_defn): Likewise.
4407         * f-lang.c (f_language_defn): Likewise.
4408         * go-lang.c (go_language_defn): Likewise.
4409         * language.c (unknown_language_defn): Likewise.
4410         (auto_language_defn): Likewise.
4411         * m2-lang.c (m2_language_defn): Likewise.
4412         * objc-lang.c (objc_language_defn): Likewise.
4413         * opencl-lang.c (opencl_language_defn): Likewise.
4414         * p-lang.c (pascal_language_defn): Likewise.
4415         * rust-lang.c (rust_language_defn): Likewise.
4416
4417 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * ada-lang.c (ada_is_character_type): Change return type to bool.
4420         (ada_is_string_type): Likewise.
4421         * ada-lang.h (ada_is_character_type): Update declaration
4422         (ada_is_string_type): Likewise.
4423
4424 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4425
4426         Support style in 'frame|thread apply'
4427
4428         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4429         * record.c (record_start, record_stop): Update callers of
4430         execute_command_to_string with false.
4431         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4432         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4433         methods.
4434         (class string_file): New constructor with term_out parameter.
4435         Override methods term_out and can_emit_style_escape.  New member
4436         term_out.
4437         (class stdio_file): Override can_emit_style_escape.
4438         (class tee_file): Override term_out and can_emit_style_escape.
4439         * utils.h (can_emit_style_escape): Remove.
4440         * utils.c (can_emit_style_escape): Likewise.
4441         Update all callers of can_emit_style_escape (SOMESTREAM) to
4442         SOMESTREAM->can_emit_style_escape.
4443         * source-cache.c (source_cache::get_source_lines): Likewise.
4444         * stack.c (frame_apply_command_count): Call execute_command_to_string
4445         passing the term_out characteristic of the current gdb_stdout.
4446         * thread.c (thr_try_catch_cmd): Likewise.
4447         * top.c (execute_command_to_string): pass term_out parameter
4448         to construct the string_file for the command output.
4449         * ui-file.c (term_cli_styling): New function (most code moved
4450         from utils.c can_emit_style_escape).
4451         (string_file::string_file, string_file::can_emit_style_escape,
4452         stdio_file::can_emit_style_escape, tee_file::term_out,
4453         tee_file::can_emit_style_escape): New functions.
4454
4455 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4456
4457         * NEWS: Mention the new set|show may-call-functions.
4458         * infcall.c (may_call_functions_p): New variable.
4459         (show_may_call_functions_p): New function.
4460         (call_function_by_hand_dummy): Throws an error if not
4461         may-call-functions.
4462         (_initialize_infcall): Call add_setshow_boolean_cmd for
4463         may-call-functions.
4464
4465 2019-04-25  Keith Seitz  <keiths@redhat.com>
4466
4467         PR c++/24367
4468         * cp-support.c (inspect_type): Don't attempt substitutions
4469         of symbol with the same name.
4470
4471 2019-04-25  Tom Tromey  <tromey@adacore.com>
4472
4473         PR gdb/24475:
4474         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4475         static.
4476
4477 2019-04-25  Tom Tromey  <tromey@adacore.com>
4478
4479         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4480         rvalue reference.
4481         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4482         (gdb_xml_parser::parse): Use std::move.
4483         * python/python-internal.h (gdbpy_convert_exception): Take a const
4484         reference.
4485         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4486         std::move.
4487         * python/py-utils.c (gdbpy_convert_exception): Take a const
4488         reference.
4489         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4490         Use std::move.
4491         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4492         Use std::move.
4493         * mi/mi-main.c (mi_print_exception): Take a const reference.
4494         * main.c (handle_command_errors): Take a const reference.
4495         * linespec.c (parse_linespec): Use std::move.
4496         * infcall.c (run_inferior_call): Use std::move.
4497         (call_function_by_hand_dummy): Use std::move.
4498         * exec.c (try_open_exec_file): Use std::move.
4499         * exceptions.h (exception_print, exception_fprintf)
4500         (exception_print_same): Update.
4501         * exceptions.c (print_exception, exception_print)
4502         (exception_fprintf, exception_print_same): Change parameters to
4503         const reference.
4504         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4505         * common/new-op.c: Use std::move.
4506         * common/common-exceptions.h (struct gdb_exception): Add move
4507         constructor.
4508         (struct gdb_exception_error, struct gdb_exception_quit, struct
4509         gdb_quit_bad_alloc): Change constructor to move constructor.
4510         (throw_exception): Change parameter to rvalue reference.
4511         * common/common-exceptions.c (throw_exception): Take rvalue
4512         reference.
4513         * cli/cli-interp.c (safe_execute_command): Use std::move.
4514         * breakpoint.c (insert_bp_location, location_to_sals): Use
4515         std::move.
4516
4517 2019-04-25  Tom Tromey  <tromey@adacore.com>
4518
4519         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4520         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4521         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4522         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4523         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4524         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4525         guile/scm-value.c: Use unpack.
4526         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4527         gdbscm_gdb_exception.
4528         (gdbscm_throw_gdb_exception): Likewise.
4529         (struct gdbscm_gdb_exception): New.
4530         (unpack): New function.
4531         (gdbscm_wrap): Use unpack.
4532
4533 2019-04-25  Tom Tromey  <tromey@adacore.com>
4534
4535         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4536         (gdb_rl_callback_handler): Use std::move.
4537         * common/common-exceptions.h (struct gdb_exception): Add move
4538         assignment operator.
4539         (throw_exception_sjlj): Change "exception" to const reference.
4540         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4541         (throw_exception_sjlj): Change "exception" to const reference.
4542
4543 2019-04-25  Tom Tromey  <tromey@adacore.com>
4544
4545         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4546         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4547         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4548         Update.
4549         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4550         Update.
4551         * mi/mi-interp.c (mi_interp::exec): Update.
4552         * linespec.c (parse_linespec): Update.
4553         * infcall.c (run_inferior_call): Update.
4554         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4555         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4556         (gdbscm_lookup_global_symbol): Update.
4557         * guile/scm-param.c (gdbscm_parameter_value): Update.
4558         * guile/scm-frame.c (gdbscm_frame_read_register)
4559         (gdbscm_frame_read_var): Update.
4560         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4561         * exec.c (try_open_exec_file): Update.
4562         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4563         (gdb_rl_callback_handler): Update.
4564         * common/common-exceptions.h (exception_none): Don't declare.
4565         * common/common-exceptions.c (exception_none): Don't define.
4566         (struct catcher) <exception>: Update.
4567         * cli/cli-interp.c (safe_execute_command): Update.
4568         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4569
4570 2019-04-25  Ali Tamur  <tamur@google.com>
4571
4572         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4573         (read_attribute_value): Likewise.
4574         (dwarf2_read_addr_index): Update comment.
4575         (read_str_index): Add DW_FORM_strx.
4576         (dwarf2_string_attr): Likewise.
4577         (dwarf2_const_value_attr): Likewise.
4578         (dump_die_shallow): Likewise.
4579         (dwarf2_fetch_constant_bytes): Likewise.
4580         (skip_form_bytes): Likewise.
4581         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4582
4583 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4584
4585         PR corefiles/11608
4586         PR corefiles/18187
4587         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4588         OFFSET.  Verify if current mapping contains an ELF header.
4589         (linux_find_memory_regions_full): Adjust call to
4590         dump_mapping_p.
4591
4592 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4593             Kang Li <kanglictf@gmail.com>
4594
4595         PR gdb/21600
4596
4597         * dwarf2-frame.c (read_initial_length): Be consistent about using
4598         unsigned representation of length.
4599         (decode_frame_entry_1): Likewise.  Check for wraparound of
4600         end pointer as well as buffer overflow.
4601
4602 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4603
4604         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4605         "vq".
4606
4607 2019-04-24  Tom Tromey  <tromey@adacore.com>
4608
4609         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4610
4611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * s12z-tdep.c (s12z_unwind_pc): Delete.
4614         (s12z_unwind_sp): Delete.
4615         (s12z_gdbarch_init): Don't register deleted functions with
4616         gdbarch.
4617
4618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * rl78-tdep.c (rl78_unwind_sp): Delete.
4621         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4622
4623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4626         (xstormy16_unwind_pc): Delete.
4627         (xstormy16_dummy_id): Delete.
4628         (xstormy16_gdbarch_init): Don't register deleted functions with
4629         gdbarch.
4630
4631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4632
4633         * vax-tdep.c (vax_unwind_pc): Delete.
4634         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4635
4636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * v850-tdep.c (v850_unwind_sp): Delete.
4639         (v850_unwind_pc): Delete.
4640         (v850_dummy_id): Delete.
4641         (v850_gdbarch_init): Don't register deleted functions with
4642         gdbarch.
4643
4644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4647         (tilegx_unwind_pc): Delete.
4648         (tilegx_unwind_dummy_id): Delete.
4649         (tilegx_gdbarch_init): Don't register deleted functions with
4650         gdbarch.
4651
4652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4653
4654         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4655         (tic6x_dummy_id): Delete.
4656         (tic6x_gdbarch_init): Don't register deleted functions with
4657         gdbarch.
4658
4659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * sparc-tdep.c (sparc_unwind_pc): Delete.
4662         (sparc32_gdbarch_init): Don't register deleted function with
4663         gdbarch.
4664
4665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * sh-tdep.c (sh_unwind_sp): Delete.
4668         (sh_unwind_pc): Delete.
4669         (sh_dummy_id): Delete.
4670         (sh_gdbarch_init): Don't register deleted functions with
4671         gdbarch.
4672
4673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * score-tdep.c (score_unwind_sp): Delete.
4676         (score_unwind_pc): Delete.
4677         (score_dummy_id): Delete.
4678         (score_gdbarch_init): Don't register deleted functions with
4679         gdbarch.
4680
4681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * rx-tdep.c (rx_unwind_pc): Delete.
4684         (rx_unwind_sp): Delete.
4685         (rx_dummy_id): Delete.
4686         (rx_gdbarch_init): Don't register deleted functions with
4687         gdbarch.  Update comment.
4688
4689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4690
4691         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4692         (rs6000_dummy_id): Delete.
4693         (rs6000_gdbarch_init): Don't register deleted functions with
4694         gdbarch.
4695
4696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * or1k-tdep.c (or1k_dummy_id): Delete.
4699         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4700
4701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4702
4703         * nios2-tdep.c (nios2_dummy_id): Delete.
4704         (nios2_unwind_sp): Delete.
4705         (nios2_gdbarch_init): Don't register deleted functions with
4706         gdbarch.
4707
4708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * nds32-tdep.c (nds32_dummy_id): Delete.
4711         (nds32_unwind_pc): Delete.
4712         (nds32_unwind_sp): Delete.
4713         (nds32_gdbarch_init): Don't register deleted functions with
4714         gdbarch.
4715
4716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4717
4718         * msp430-tdep.c (msp430_unwind_pc): Delete.
4719         (msp430_unwind_sp): Delete.
4720         (msp430_dummy_id): Delete.
4721         (msp430_gdbarch_init): Don't register deleted functions with
4722         gdbarch.
4723
4724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4725
4726         * moxie-tdep.c (moxie_unwind_sp): Delete.
4727         (moxie_unwind_pc): Delete.
4728         (moxie_dummy_id): Delete.
4729         (moxie_gdbarch_init): Don't register deleted functions with
4730         gdbarch.
4731
4732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4733
4734         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4735         (mn10300_unwind_pc): Delete.
4736         (mn10300_unwind_sp): Delete.
4737         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4738         mn10300_unwind_sp.
4739         (mn10300_frame_unwind_init): Don't register deleted functions with
4740         gdbarch.
4741
4742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * mep-tdep.c (mep_unwind_pc): Delete.
4745         (mep_unwind_sp): Delete.
4746         (mep_dummy_id): Delete.
4747         (mep_gdbarch_init): Don't register deleted functions with
4748         gdbarch.
4749
4750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4753         (m68hc11_unwind_sp): Delete.
4754         (m68hc11_gdbarch_init): Don't register deleted functions with
4755         gdbarch.
4756
4757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4758
4759         * m32r-tdep.c (m32r_unwind_sp): Delete.
4760         (m32r_unwind_pc): Delete.
4761         (m32r_dummy_id): Delete.
4762         (m32r_gdbarch_init): Don't register deleted functions with
4763         gdbarch.
4764
4765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * m32c-tdep.c (m32c_unwind_pc): Delete.
4768         (m32c_unwind_sp): Delete.
4769         (m32c_dummy_id): Delete.
4770         (m32c_gdbarch_init): Don't register deleted functions with
4771         gdbarch.
4772
4773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4776         (lm32_unwind_pc): Delete.
4777         (lm32_dummy_id): Delete.
4778         (lm32_gdbarch_init): Don't register deleted functions with
4779         gdbarch.
4780
4781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4782
4783         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4784         (iq2000_unwind_pc): Delete.
4785         (iq2000_dummy_id): Delete.
4786         (iq2000_gdbarch_init): Don't register deleted functions with
4787         gdbarch.
4788
4789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * nds32-tdep.c (nds32_type_align): Delete.
4792         (nds32_push_dummy_call): Use type_align instead.
4793
4794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * arm-tdep.c (arm_type_align): Only handle vector override case.
4797         (arm_push_dummy_call): Use type_align.
4798         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4799
4800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4803         case.
4804         (pass_on_stack): Use type_align.
4805         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4806         function.
4807
4808 2019-04-23  Tom Tromey  <tromey@adacore.com>
4809
4810         * dwarf2read.c (line_header::file_name_at): Remove unused
4811         overload.
4812
4813 2019-04-23  Tom de Vries  <tdevries@suse.de>
4814
4815         PR gdb/24438
4816         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4817         invocation.
4818
4819
4820 2019-03-27  Ali Tamur  <tamur@google.com>
4821
4822         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4823         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4824         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4825         (dwarf_expr_context::get_addr_index): Likewise
4826         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4827         (symbol_needs_eval_context::get_addr_index): Likewise
4828         (disassemble_dwarf_expression): Add DW_OP_addrx
4829         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4830         (read_cutu_die_from_dwo): Update comment
4831         (skip_one_die): Add DW_FORM_addrx
4832         (read_attribute_value): Likewise
4833         (var_decode_location): Add DW_OP_addrx
4834         (dwarf2_const_value_attr): Add DW_FORM_addrx
4835         (dump_die_shallow): Likewise
4836         (dwarf2_fetch_constant_bytes): Likewise
4837         (decode_locdesc): Add DW_OP_addrx
4838         (skip_form_bytes): Add DW_FORM_addrx
4839
4840 2019-04-22  Ali Tamur  <tamur@google.com>
4841
4842         * MAINTAINERS (Write After Approval): Add self.
4843
4844 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4845
4846         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4847         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4848         (open_symbol_file_object): Likewise.
4849         (svr4_default_sos): Add info parameter.
4850         (svr4_read_so_list): Likewise.
4851         (svr4_current_sos_direct): Adjust functions calls to pass down
4852         info.
4853         (svr4_current_sos_1): Add info parameter.
4854         (svr4_current_sos): Call get_svr4_info, pass info down to
4855         svr4_current_sos_1.
4856         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4857         get_svr4_info.
4858         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4859         get_svr4_info.
4860         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4861         to get_svr4_info.
4862         (probes_table_remove_objfile_probes): Likewise.
4863         (register_solib_event_probe): Add info parameter.
4864         (solist_update_incremental): Pass info parameter down to
4865         svr4_read_so_list.
4866         (disable_probes_interface): Add info parameter.
4867         (svr4_handle_solib_event): Pass current_program_space to
4868         get_svr4_info.  Adjust disable_probes_interface cleanup.
4869         (svr4_create_probe_breakpoints): Add info parameter, pass it
4870         down to register_solib_event_probe.
4871         (svr4_create_solib_event_breakpoints): Add info parameter,
4872         pass it down to svr4_create_probe_breakpoints.
4873         (enable_break): Pass info down to
4874         svr4_create_solib_event_breakpoints.
4875         (svr4_solib_create_inferior_hook): Pass current_program_space to
4876         get_svr4_info.
4877         (svr4_clear_solib): Likewise.
4878
4879 2019-04-22  Pedro Alves  <palves@redhat.com>
4880
4881         * solib-svr4.c (svr4_free_objfile_observer): New.
4882         (probe_and_action::objfile): New field.
4883         (probes_table_htab_remove_objfile_probes)
4884         (probes_table_remove_objfile_probes): New functions.
4885         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4886         in the new probe_and_action.  Don't store the probe in 'lookup'.
4887         (svr4_create_probe_breakpoints): Pass objfile to
4888         register_solib_event_probe.
4889         (_initialize_svr4_solib): Register a free_objfile observer.
4890
4891 2019-04-19  Tom Tromey  <tom@tromey.com>
4892
4893         * common/queue.h: Remove.
4894
4895 2019-04-19  Tom Tromey  <tom@tromey.com>
4896
4897         * event-loop.c: Don't include "common/queue.h".
4898
4899 2019-04-19  Tom Tromey  <tom@tromey.com>
4900
4901         * remote.c (remote_target): Use delete.
4902         * remote-notif.h: Include <list>, not "common/queue.h".
4903         (notif_client_p): Remove typedef.
4904         (remote_notif_state): Add constructor, destructor, initializer.
4905         <notif_queue>: Now a std::list.
4906         (remote_notif_state_xfree): Don't declare.
4907         * remote-notif.c (remote_notif_process, handle_notification)
4908         (remote_notif_state_allocate): Update.
4909         (~remote_notif_state): Rename from remote_notif_state_xfree.
4910
4911 2019-04-19  Tom Tromey  <tom@tromey.com>
4912
4913         * symfile.c (reread_symbols): Update.
4914         * objfiles.c (objfile_register_static_link)
4915         (objfile_lookup_static_link): Update
4916         (~objfile) Don't delete static_links.
4917         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4918
4919 2019-04-19  Tom Tromey  <tom@tromey.com>
4920
4921         * type-stack.h (struct type_stack) <insert>: Constify string.
4922         * type-stack.c (type_stack::insert): Constify string.
4923         * gdbtypes.h (lookup_template_type): Update.
4924         (address_space_name_to_int): Update.
4925         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4926         const.
4927         (lookup_template_type): Make name const.
4928         * c-exp.y: Update rules.
4929         (lex_one_token, classify_name, classify_inner_name)
4930         (c_print_token): Update.
4931         * p-exp.y: Update rules.
4932         (yylex): Update.
4933         * f-exp.y: Update rules.
4934         (yylex): Update.
4935         * d-exp.y: Update rules.
4936         (lex_one_token, classify_name, classify_inner_name): Update.
4937         * parse.c (write_dollar_variable, copy_name): Return std::string.
4938         * parser-defs.h (copy_name): Change return type.
4939         * m2-exp.y: Update rules.
4940         (yylex): Update.
4941         * go-exp.y (lex_one_token): Update.
4942         Update rules.
4943         (classify_unsafe_function, classify_packaged_name)
4944         (classify_name, yylex): Update.
4945
4946 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4947
4948         * configure.ac: add --enable-source-highlight switch.
4949         * configure: Regenerate.
4950         * top.c (print_gdb_version): plumb --enable-source-highlight
4951         status to "show configuration".
4952
4953 2019-04-19  Tom Tromey  <tromey@adacore.com>
4954
4955         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4956         Check ADA_TYPE_P.
4957         (empty_record, ada_template_to_fixed_record_type_1)
4958         (template_to_static_fixed_type)
4959         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4960         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4961         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4962         macros.
4963
4964 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4965
4966         PR symtab/24423:
4967         * source.c (print_source_lines_base): Advance "iter" when a
4968         control character is seen.
4969
4970 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4971
4972         * inferior.h (struct infcall_suspend_state_deleter):
4973         Catch exception in destructor to avoid crash.
4974
4975 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4976
4977         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4978         close to the add_com "shell".
4979
4980 2019-04-18  Tom Tromey  <tromey@adacore.com>
4981
4982         * process-stratum-target.h (class process_stratum_target)
4983         <stratum>: Add "final".
4984
4985 2019-04-17  Tom Tromey  <tromey@adacore.com>
4986
4987         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4988         against nullptr before use.
4989
4990 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4991
4992         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4993
4994 2019-04-17  Jim Wilson  <jimw@sifive.com>
4995             Andrew Burgess  <andrew.burgess@embecosm.com>
4996
4997         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4998         code read might fail, assume 4-byte breakpoint in that case.
4999
5000 2019-04-15  Leszek Swirski  <leszeks@google.com>
5001
5002         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5003         rather than a hand-rolled POD check when checking for forced MEMORY
5004         classification.
5005
5006 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5007
5008         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5009         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5010         function.
5011         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5012         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5013         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5014         declaration.
5015
5016 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5017
5018         * aarch64-linux-nat.c
5019         (aarch64_linux_nat_target::thread_architecture): Add override.
5020         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5021         each VQ.
5022
5023 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5024
5025         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5026
5027 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5030         target types of size 96-bits, add some additional comments, and
5031         check that the builtin type we found was the correct size.
5032
5033 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5034
5035         * utils.c (prompt_for_continue): Don't restore the styling at the
5036         end, as applied_style has the wrong value.  This fixes styling in
5037         long lists of file names that are interrupted by the "Continue?"
5038         prompt.
5039
5040 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5043         * c-lang.c (c_language_defn): Likewise.
5044         (cplus_language_defn): Likewise.
5045         (asm_language_defn): Likewise.
5046         (minimal_language_defn): Likewise.
5047         * d-lang.c (d_language_defn): Likewise.
5048         * f-lang.c (f_language_defn): Likewise.
5049         * go-lang.c (go_language_defn): Likewise.
5050         * language.c (unknown_language_defn): Likewise.
5051         (auto_language_defn): Likewise.
5052         * language.h (struct language_defn): Remove la_magic field.
5053         (LANG_MAGIC): Delete.
5054         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5055         * objc-lang.c (objc_language_defn): Likewise.
5056         * opencl-lang.c (opencl_language_defn): Likewise.
5057         * p-lang.c (pascal_language_defn): Likewise.
5058         * rust-lang.c (rust_language_defn): Likewise.
5059
5060 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * riscv-tdep.c (riscv_type_align): New function.
5063         (riscv_type_alignment): Delete.
5064         (riscv_arg_location): Use 'type_align'.
5065         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5066
5067 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5068
5069         * gdbtypes.c (type_align): A struct with no non-static fields also
5070         has alignment of 1.
5071
5072 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5075         component to 0.
5076         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5077         member.
5078         (riscv_struct_info::analyse): New implementation using new
5079         analyse_inner member function.
5080         (riscv_struct_info::field_offset): New member function.
5081         (riscv_struct_info::m_offsets): New member variable.
5082         (riscv_struct_info::analyse_inner): New private member function,
5083         takes the old implementation of riscv_struct_info::analyse but
5084         extended to track field offsets.
5085         (riscv_call_arg_struct): Update the struct folding special cases
5086         to handle cases where empty C++ structs, which are non-zero
5087         length, are found.
5088         (riscv_arg_location): Initialise the length of each location, a
5089         non-zero length now indicates the location is in use.
5090         (riscv_push_dummy_call): Allow for the first location having a
5091         non-zero offset when setting up arguments.
5092         (riscv_return_value): Likewise, but for return values.
5093
5094 2019-04-11  Tom Tromey  <tromey@adacore.com>
5095
5096         * utils.c (internal_vproblem): Make "msg" const.
5097
5098 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5099
5100         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5101         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5102         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5103         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5104
5105 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5106
5107         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5108         function.
5109         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5110         of amd64_collect_native_gregset.
5111         (amd64_linux_nat_target::store_registers): Likewise.
5112
5113 2019-04-10  Tom Tromey  <tom@tromey.com>
5114
5115         * symtab.c (lookup_global_symbol_from_objfile)
5116         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5117         * objfiles.h (class separate_debug_iterator): New.
5118         (class separate_debug_range): New.
5119         (struct objfile) <separate_debug_objfiles>: New method.
5120         (objfile_separate_debug_iterate): Don't declare.
5121         * objfiles.c (separate_debug_iterator::operator++): Rename from
5122         objfile_separate_debug_iterate.
5123         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5124         iterator.
5125         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5126         iterator.
5127
5128 2019-04-10  Tom Tromey  <tom@tromey.com>
5129
5130         * symfile.c (reread_symbols): Remove old comment.
5131         * objfiles.c (free_all_objfiles): Fix a typo.
5132
5133 2019-04-10  Tom Tromey  <tom@tromey.com>
5134
5135         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5136         * minsyms.c (lookup_minimal_symbol): Use foreach.
5137         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5138         (lookup_minimal_symbol_solib_trampoline): Likewise.
5139         * symfile.c (reread_symbols): Use foreach.
5140
5141 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5142             Tom Tromey  <tromey@adacore.com>
5143
5144         PR rust/24414:
5145         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5146         (rust_lex_int_test): Change "value" to be LONGEST.
5147         (rust_lex_tests): Add test for long integer literal.
5148
5149 2019-04-09  Tom Tromey  <tromey@adacore.com>
5150
5151         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5152         to bool.
5153         (extended_remote_target::attach): Update.
5154         (remote_target::remote_notice_new_inferior): Update.
5155         (remote_target::add_current_inferior_and_thread): Update.
5156         * inferior.c (exit_inferior_1): Use "false".
5157         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5158
5159 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5160
5161         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5162         the "start" command.
5163
5164 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5165
5166         * python/py-inferior.c (infpy_thread_from_thread_handle):
5167         Adjust comments to reflect renaming of thread_from_thread_handle
5168         to thread_from_handle.  Adjust keywords.  Fix type error message.
5169         (inferior_object_methods): Add thread_from_handle.  Retain
5170         thread_from_thread_handle, but mark it as deprecated.
5171
5172 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5173
5174         * gdbthread.h (find_thread_by_handle): Revise declaration.
5175         * thread.c (find_thread_by_handle): Likewise.  Adjust
5176         implementation too.
5177         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5178         support for buffer objects as handles.
5179
5180 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5181
5182         * python/py-infthread.c (thpy_thread_handle): New function.
5183         (thread_object_methods): Register thpy_thread_handle.
5184
5185 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5186
5187         * gdbthread.h (thread_to_thread_handle): Declare.
5188         * thread.c (gdbtypes.h): Include.
5189         (thread_to_thread_handle): New function.
5190
5191         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5192         (target_thread_info_to_thread_handle): Declare.
5193         * target.c (target_thread_info_to_thread_handle): New function.
5194         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5195         * target-delegates.c: Regenerate.
5196
5197         * linux-thread-db.c (class thread_db_target): Add method
5198         thread_info_to_thread_handle.
5199         (thread_db_target::thread_info_to_thread_handle): Define.
5200         * remote.c (class remote_target): Add new method
5201         thread_info_to_thread_handle.
5202         (remote_target::thread_info_to_thread_handle): Define.
5203
5204 2019-04-08  Pedro Alves  <palves@redhat.com>
5205
5206         * common/common-exceptions.c (throw_exception): Don't create
5207         named object to throw; throw directly.
5208         (throw_it): Likewise.  Don't initialize gdb_exception::message
5209         here, with new; pass FMT and AP to the ctor instead.
5210         * common/common-exceptions.h: Include <string>.
5211         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5212         const char *, va_list)): New ctor.  Use std::make_shared.
5213         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5214         errors)): Delete.
5215         (gdb_exception_error::gdb_exception_error(enum errors, const char
5216         *, va_list)): New.
5217         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5218         Add assertion.
5219         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5220         errors)): Delete.
5221         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5222         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5223         Add assertion.
5224
5225 2019-04-08  Tom Tromey  <tom@tromey.com>
5226
5227         * valops.c (value_rtti_indirect_type): Replace throw_exception
5228         with throw.
5229         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5230         with throw.
5231         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5232         throw.
5233         * target.c (target_translate_tls_address): Replace throw_exception
5234         with throw.
5235         * stack.c (frame_apply_command_count): Replace throw_exception
5236         with throw.
5237         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5238         throw.
5239         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5240         with throw.
5241         * rs6000-tdep.c (rs6000_frame_cache)
5242         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5243         * remote.c: Replace throw_exception with throw.
5244         * record-full.c (record_full_message, record_full_wait_1)
5245         (record_full_restore): Replace throw_exception with throw.
5246         * record-btrace.c:
5247         (get_thread_current_frame_id, record_btrace_start_replaying)
5248         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5249         (cmd_record_btrace_start): Replace throw_exception with throw.
5250         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5251         throw.
5252         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5253         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5254         * linespec.c:
5255         (find_linespec_symbols): Replace throw_exception with throw.
5256         * infrun.c (displaced_step_prepare, resume): Replace
5257         throw_exception with throw.
5258         * infcmd.c (post_create_inferior): Replace throw_exception with
5259         throw.
5260         * inf-loop.c (inferior_event_handler): Replace throw_exception
5261         with throw.
5262         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5263         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5264         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5265         (get_prev_frame_always, get_frame_pc_if_available)
5266         (get_frame_address_in_block_if_available, get_frame_language):
5267         Replace throw_exception with throw.
5268         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5269         throw_exception with throw.
5270         * eval.c (fetch_subexp_value, evaluate_var_value)
5271         (evaluate_funcall, evaluate_subexp_standard): Replace
5272         throw_exception with throw.
5273         * dwarf2loc.c (call_site_find_chain)
5274         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5275         Replace throw_exception with throw.
5276         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5277         with throw.
5278         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5279         throw.
5280         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5281         * completer.c (complete_line_internal): Replace throw_exception
5282         with throw.
5283         * compile/compile-object-run.c (compile_object_run): Replace
5284         throw_exception with throw.
5285         * cli/cli-script.c (process_next_line): Replace throw_exception
5286         with throw.
5287         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5288         (btrace_enable, btrace_maint_update_pt_packets): Replace
5289         throw_exception with throw.
5290         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5291         throw_exception with throw.
5292         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5293         throw_exception with throw.
5294         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5295         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5296         * aarch64-tdep.c (aarch64_make_prologue_cache)
5297         (aarch64_make_stub_cache): Replace throw_exception with throw.
5298
5299 2019-04-08  Tom Tromey  <tom@tromey.com>
5300
5301         * common/common-exceptions.c (throw_exception): Rename from
5302         throw_exception_cxx.  Remove old copy.  Make argument const.
5303         (throw_it): Create and throw exception objects directly.
5304         * common/common-exceptions.h (throw_exception): Make argument
5305         const.
5306         (struct gdb_exception_error): Add constructor.
5307         (struct gdb_exception_quit): Add constructor.
5308
5309 2019-04-08  Tom Tromey  <tom@tromey.com>
5310
5311         * common/common-exceptions.h (exception_rethrow): Don't declare.
5312         (TRY_SJLJ): Update comment.
5313         (TRY, CATCH, END_CATCH): Remove.
5314         * common/common-exceptions.c (exception_rethrow): Remove.
5315
5316 2019-04-08  Tom Tromey  <tom@tromey.com>
5317
5318         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5319         Remove.
5320         (gdb_exception_error): Rename from
5321         gdb_exception_RETURN_MASK_ERROR.
5322         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5323         (gdb_quit_bad_alloc): Update.
5324         * aarch64-tdep.c: Update.
5325         * ada-lang.c: Update.
5326         * ada-typeprint.c: Update.
5327         * ada-valprint.c: Update.
5328         * amd64-tdep.c: Update.
5329         * arch-utils.c: Update.
5330         * break-catch-throw.c: Update.
5331         * breakpoint.c: Update.
5332         * btrace.c: Update.
5333         * c-varobj.c: Update.
5334         * cli/cli-cmds.c: Update.
5335         * cli/cli-interp.c: Update.
5336         * cli/cli-script.c: Update.
5337         * common/common-exceptions.c: Update.
5338         * common/new-op.c: Update.
5339         * common/selftest.c: Update.
5340         * compile/compile-c-symbols.c: Update.
5341         * compile/compile-cplus-symbols.c: Update.
5342         * compile/compile-object-load.c: Update.
5343         * compile/compile-object-run.c: Update.
5344         * completer.c: Update.
5345         * corelow.c: Update.
5346         * cp-abi.c: Update.
5347         * cp-support.c: Update.
5348         * cp-valprint.c: Update.
5349         * darwin-nat.c: Update.
5350         * disasm-selftests.c: Update.
5351         * dtrace-probe.c: Update.
5352         * dwarf-index-cache.c: Update.
5353         * dwarf-index-write.c: Update.
5354         * dwarf2-frame-tailcall.c: Update.
5355         * dwarf2-frame.c: Update.
5356         * dwarf2loc.c: Update.
5357         * dwarf2read.c: Update.
5358         * eval.c: Update.
5359         * event-loop.c: Update.
5360         * event-top.c: Update.
5361         * exec.c: Update.
5362         * f-valprint.c: Update.
5363         * fbsd-tdep.c: Update.
5364         * frame-unwind.c: Update.
5365         * frame.c: Update.
5366         * gdbtypes.c: Update.
5367         * gnu-v3-abi.c: Update.
5368         * guile/guile-internal.h: Update.
5369         * guile/scm-block.c: Update.
5370         * guile/scm-breakpoint.c: Update.
5371         * guile/scm-cmd.c: Update.
5372         * guile/scm-disasm.c: Update.
5373         * guile/scm-frame.c: Update.
5374         * guile/scm-lazy-string.c: Update.
5375         * guile/scm-math.c: Update.
5376         * guile/scm-param.c: Update.
5377         * guile/scm-ports.c: Update.
5378         * guile/scm-pretty-print.c: Update.
5379         * guile/scm-symbol.c: Update.
5380         * guile/scm-symtab.c: Update.
5381         * guile/scm-type.c: Update.
5382         * guile/scm-value.c: Update.
5383         * i386-linux-tdep.c: Update.
5384         * i386-tdep.c: Update.
5385         * inf-loop.c: Update.
5386         * infcall.c: Update.
5387         * infcmd.c: Update.
5388         * infrun.c: Update.
5389         * jit.c: Update.
5390         * language.c: Update.
5391         * linespec.c: Update.
5392         * linux-fork.c: Update.
5393         * linux-nat.c: Update.
5394         * linux-tdep.c: Update.
5395         * linux-thread-db.c: Update.
5396         * main.c: Update.
5397         * mi/mi-cmd-break.c: Update.
5398         * mi/mi-cmd-stack.c: Update.
5399         * mi/mi-interp.c: Update.
5400         * mi/mi-main.c: Update.
5401         * objc-lang.c: Update.
5402         * p-valprint.c: Update.
5403         * parse.c: Update.
5404         * ppc-linux-tdep.c: Update.
5405         * printcmd.c: Update.
5406         * python/py-arch.c: Update.
5407         * python/py-breakpoint.c: Update.
5408         * python/py-cmd.c: Update.
5409         * python/py-finishbreakpoint.c: Update.
5410         * python/py-frame.c: Update.
5411         * python/py-framefilter.c: Update.
5412         * python/py-gdb-readline.c: Update.
5413         * python/py-inferior.c: Update.
5414         * python/py-infthread.c: Update.
5415         * python/py-lazy-string.c: Update.
5416         * python/py-linetable.c: Update.
5417         * python/py-objfile.c: Update.
5418         * python/py-param.c: Update.
5419         * python/py-prettyprint.c: Update.
5420         * python/py-progspace.c: Update.
5421         * python/py-record-btrace.c: Update.
5422         * python/py-record.c: Update.
5423         * python/py-symbol.c: Update.
5424         * python/py-type.c: Update.
5425         * python/py-unwind.c: Update.
5426         * python/py-utils.c: Update.
5427         * python/py-value.c: Update.
5428         * python/python.c: Update.
5429         * record-btrace.c: Update.
5430         * record-full.c: Update.
5431         * remote-fileio.c: Update.
5432         * remote.c: Update.
5433         * riscv-tdep.c: Update.
5434         * rs6000-aix-tdep.c: Update.
5435         * rs6000-tdep.c: Update.
5436         * rust-exp.y: Update.
5437         * rust-lang.c: Update.
5438         * s390-tdep.c: Update.
5439         * selftest-arch.c: Update.
5440         * solib-dsbt.c: Update.
5441         * solib-frv.c: Update.
5442         * solib-spu.c: Update.
5443         * solib-svr4.c: Update.
5444         * solib.c: Update.
5445         * sparc64-linux-tdep.c: Update.
5446         * stack.c: Update.
5447         * symfile-mem.c: Update.
5448         * symmisc.c: Update.
5449         * target.c: Update.
5450         * thread.c: Update.
5451         * top.c: Update.
5452         * tracefile-tfile.c: Update.
5453         * tui/tui.c: Update.
5454         * typeprint.c: Update.
5455         * unittests/cli-utils-selftests.c: Update.
5456         * unittests/parse-connection-spec-selftests.c: Update.
5457         * valops.c: Update.
5458         * valprint.c: Update.
5459         * value.c: Update.
5460         * varobj.c: Update.
5461         * windows-nat.c: Update.
5462         * x86-linux-nat.c: Update.
5463         * xml-support.c: Update.
5464
5465 2019-04-08  Tom Tromey  <tom@tromey.com>
5466
5467         * xml-support.c: Use C++ exception handling.
5468         * x86-linux-nat.c: Use C++ exception handling.
5469         * windows-nat.c: Use C++ exception handling.
5470         * varobj.c: Use C++ exception handling.
5471         * value.c: Use C++ exception handling.
5472         * valprint.c: Use C++ exception handling.
5473         * valops.c: Use C++ exception handling.
5474         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5475         handling.
5476         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5477         * typeprint.c: Use C++ exception handling.
5478         * tui/tui.c: Use C++ exception handling.
5479         * tracefile-tfile.c: Use C++ exception handling.
5480         * top.c: Use C++ exception handling.
5481         * thread.c: Use C++ exception handling.
5482         * target.c: Use C++ exception handling.
5483         * symmisc.c: Use C++ exception handling.
5484         * symfile-mem.c: Use C++ exception handling.
5485         * stack.c: Use C++ exception handling.
5486         * sparc64-linux-tdep.c: Use C++ exception handling.
5487         * solib.c: Use C++ exception handling.
5488         * solib-svr4.c: Use C++ exception handling.
5489         * solib-spu.c: Use C++ exception handling.
5490         * solib-frv.c: Use C++ exception handling.
5491         * solib-dsbt.c: Use C++ exception handling.
5492         * selftest-arch.c: Use C++ exception handling.
5493         * s390-tdep.c: Use C++ exception handling.
5494         * rust-lang.c: Use C++ exception handling.
5495         * rust-exp.y: Use C++ exception handling.
5496         * rs6000-tdep.c: Use C++ exception handling.
5497         * rs6000-aix-tdep.c: Use C++ exception handling.
5498         * riscv-tdep.c: Use C++ exception handling.
5499         * remote.c: Use C++ exception handling.
5500         * remote-fileio.c: Use C++ exception handling.
5501         * record-full.c: Use C++ exception handling.
5502         * record-btrace.c: Use C++ exception handling.
5503         * python/python.c: Use C++ exception handling.
5504         * python/py-value.c: Use C++ exception handling.
5505         * python/py-utils.c: Use C++ exception handling.
5506         * python/py-unwind.c: Use C++ exception handling.
5507         * python/py-type.c: Use C++ exception handling.
5508         * python/py-symbol.c: Use C++ exception handling.
5509         * python/py-record.c: Use C++ exception handling.
5510         * python/py-record-btrace.c: Use C++ exception handling.
5511         * python/py-progspace.c: Use C++ exception handling.
5512         * python/py-prettyprint.c: Use C++ exception handling.
5513         * python/py-param.c: Use C++ exception handling.
5514         * python/py-objfile.c: Use C++ exception handling.
5515         * python/py-linetable.c: Use C++ exception handling.
5516         * python/py-lazy-string.c: Use C++ exception handling.
5517         * python/py-infthread.c: Use C++ exception handling.
5518         * python/py-inferior.c: Use C++ exception handling.
5519         * python/py-gdb-readline.c: Use C++ exception handling.
5520         * python/py-framefilter.c: Use C++ exception handling.
5521         * python/py-frame.c: Use C++ exception handling.
5522         * python/py-finishbreakpoint.c: Use C++ exception handling.
5523         * python/py-cmd.c: Use C++ exception handling.
5524         * python/py-breakpoint.c: Use C++ exception handling.
5525         * python/py-arch.c: Use C++ exception handling.
5526         * printcmd.c: Use C++ exception handling.
5527         * ppc-linux-tdep.c: Use C++ exception handling.
5528         * parse.c: Use C++ exception handling.
5529         * p-valprint.c: Use C++ exception handling.
5530         * objc-lang.c: Use C++ exception handling.
5531         * mi/mi-main.c: Use C++ exception handling.
5532         * mi/mi-interp.c: Use C++ exception handling.
5533         * mi/mi-cmd-stack.c: Use C++ exception handling.
5534         * mi/mi-cmd-break.c: Use C++ exception handling.
5535         * main.c: Use C++ exception handling.
5536         * linux-thread-db.c: Use C++ exception handling.
5537         * linux-tdep.c: Use C++ exception handling.
5538         * linux-nat.c: Use C++ exception handling.
5539         * linux-fork.c: Use C++ exception handling.
5540         * linespec.c: Use C++ exception handling.
5541         * language.c: Use C++ exception handling.
5542         * jit.c: Use C++ exception handling.
5543         * infrun.c: Use C++ exception handling.
5544         * infcmd.c: Use C++ exception handling.
5545         * infcall.c: Use C++ exception handling.
5546         * inf-loop.c: Use C++ exception handling.
5547         * i386-tdep.c: Use C++ exception handling.
5548         * i386-linux-tdep.c: Use C++ exception handling.
5549         * guile/scm-value.c: Use C++ exception handling.
5550         * guile/scm-type.c: Use C++ exception handling.
5551         * guile/scm-symtab.c: Use C++ exception handling.
5552         * guile/scm-symbol.c: Use C++ exception handling.
5553         * guile/scm-pretty-print.c: Use C++ exception handling.
5554         * guile/scm-ports.c: Use C++ exception handling.
5555         * guile/scm-param.c: Use C++ exception handling.
5556         * guile/scm-math.c: Use C++ exception handling.
5557         * guile/scm-lazy-string.c: Use C++ exception handling.
5558         * guile/scm-frame.c: Use C++ exception handling.
5559         * guile/scm-disasm.c: Use C++ exception handling.
5560         * guile/scm-cmd.c: Use C++ exception handling.
5561         * guile/scm-breakpoint.c: Use C++ exception handling.
5562         * guile/scm-block.c: Use C++ exception handling.
5563         * guile/guile-internal.h: Use C++ exception handling.
5564         * gnu-v3-abi.c: Use C++ exception handling.
5565         * gdbtypes.c: Use C++ exception handling.
5566         * frame.c: Use C++ exception handling.
5567         * frame-unwind.c: Use C++ exception handling.
5568         * fbsd-tdep.c: Use C++ exception handling.
5569         * f-valprint.c: Use C++ exception handling.
5570         * exec.c: Use C++ exception handling.
5571         * event-top.c: Use C++ exception handling.
5572         * event-loop.c: Use C++ exception handling.
5573         * eval.c: Use C++ exception handling.
5574         * dwarf2read.c: Use C++ exception handling.
5575         * dwarf2loc.c: Use C++ exception handling.
5576         * dwarf2-frame.c: Use C++ exception handling.
5577         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5578         * dwarf-index-write.c: Use C++ exception handling.
5579         * dwarf-index-cache.c: Use C++ exception handling.
5580         * dtrace-probe.c: Use C++ exception handling.
5581         * disasm-selftests.c: Use C++ exception handling.
5582         * darwin-nat.c: Use C++ exception handling.
5583         * cp-valprint.c: Use C++ exception handling.
5584         * cp-support.c: Use C++ exception handling.
5585         * cp-abi.c: Use C++ exception handling.
5586         * corelow.c: Use C++ exception handling.
5587         * completer.c: Use C++ exception handling.
5588         * compile/compile-object-run.c: Use C++ exception handling.
5589         * compile/compile-object-load.c: Use C++ exception handling.
5590         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5591         * compile/compile-c-symbols.c: Use C++ exception handling.
5592         * common/selftest.c: Use C++ exception handling.
5593         * common/new-op.c: Use C++ exception handling.
5594         * cli/cli-script.c: Use C++ exception handling.
5595         * cli/cli-interp.c: Use C++ exception handling.
5596         * cli/cli-cmds.c: Use C++ exception handling.
5597         * c-varobj.c: Use C++ exception handling.
5598         * btrace.c: Use C++ exception handling.
5599         * breakpoint.c: Use C++ exception handling.
5600         * break-catch-throw.c: Use C++ exception handling.
5601         * arch-utils.c: Use C++ exception handling.
5602         * amd64-tdep.c: Use C++ exception handling.
5603         * ada-valprint.c: Use C++ exception handling.
5604         * ada-typeprint.c: Use C++ exception handling.
5605         * ada-lang.c: Use C++ exception handling.
5606         * aarch64-tdep.c: Use C++ exception handling.
5607
5608 2019-04-08  Tom Tromey  <tom@tromey.com>
5609
5610         * xml-support.c (gdb_xml_parser::parse): Update.
5611         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5612         * value.c (show_convenience): Update.
5613         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5614         (test_parse_flags_qcs): Update.
5615         * thread.c (thr_try_catch_cmd): Update.
5616         * target.c (target_translate_tls_address): Update.
5617         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5618         (info_frame_command_core, frame_apply_command_count): Update.
5619         * rust-exp.y (rust_lex_exception_test): Update.
5620         * riscv-tdep.c (riscv_print_one_register_info): Update.
5621         * remote.c (remote_target::enable_btrace): Update.
5622         * record-btrace.c (record_btrace_enable_warn): Update.
5623         * python/py-utils.c (gdbpy_convert_exception): Update.
5624         * printcmd.c (do_one_display, print_variable_and_value): Update.
5625         * mi/mi-main.c (mi_print_exception): Update.
5626         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5627         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5628         * linux-nat.c (linux_nat_target::attach): Update.
5629         * linux-fork.c (class scoped_switch_fork_info): Update.
5630         * infrun.c (displaced_step_prepare): Update.
5631         * infcall.c (call_function_by_hand_dummy): Update.
5632         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5633         * gnu-v3-abi.c (print_one_vtable): Update.
5634         * frame.c (get_prev_frame_always): Update.
5635         * f-valprint.c (info_common_command_for_block): Update.
5636         * exec.c (try_open_exec_file): Update.
5637         * exceptions.c (print_exception, exception_print)
5638         (exception_fprintf, exception_print_same): Update.
5639         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5640         * dwarf-index-cache.c (index_cache::store)
5641         (index_cache::lookup_gdb_index): Update.
5642         * darwin-nat.c (maybe_cache_shell): Update.
5643         * cp-valprint.c (cp_print_value_fields): Update.
5644         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5645         (gcc_cplus_symbol_address): Update.
5646         * compile/compile-c-symbols.c (gcc_convert_symbol)
5647         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5648         * common/selftest.c: Update.
5649         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5650         a std::string.
5651         (exception_try_scope_entry, exception_try_scope_exit): Don't
5652         declare.
5653         (struct exception_try_scope): Remove.
5654         (TRY): Don't use exception_try_scope.
5655         (struct gdb_exception): Add constructor, operator=.
5656         <what>: New method.
5657         (struct gdb_exception_RETURN_MASK_ALL)
5658         (struct gdb_exception_RETURN_MASK_ERROR)
5659         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5660         (struct gdb_quit_bad_alloc): Update.
5661         * common/common-exceptions.c (exception_none): Change
5662         initializer.
5663         (struct catcher) <state, exception>: Initialize inline.
5664         <prev>: Remove member.
5665         (current_catcher): Remove.
5666         (catchers): New global.
5667         (exceptions_state_mc_init): Simplify.
5668         (catcher_pop): Remove.
5669         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5670         (try_scope_depth, exception_try_scope_entry)
5671         (exception_try_scope_exit): Remove.
5672         (throw_exception_sjlj): Update.
5673         (exception_messages, exception_messages_size): Remove.
5674         (throw_it): Simplify.
5675         (gdb_exception_sliced_copy): Remove.
5676         (throw_exception_cxx): Update.
5677         * cli/cli-script.c (script_from_file): Update.
5678         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5679         Update.
5680         * ada-valprint.c (ada_val_print): Update.
5681         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5682         (create_excep_cond_exprs): Update.
5683
5684 2019-04-08  Tom Tromey  <tom@tromey.com>
5685
5686         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5687         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5688         (TRY, CATCH, END_CATCH): Remove some definitions.
5689         * common/common-exceptions.c: Don't use GDB_XCPT.
5690         (catcher_list_size): Remove.
5691         (throw_exception, throw_it): Simplify.
5692
5693 2019-04-05  Tom Tromey  <tom@tromey.com>
5694
5695         Revert the header-sorting patch.
5696         * ft32-tdep.c: Revert.
5697         * frv-tdep.c: Revert.
5698         * frv-linux-tdep.c: Revert.
5699         * frame.c: Revert.
5700         * frame-unwind.c: Revert.
5701         * frame-base.c: Revert.
5702         * fork-child.c: Revert.
5703         * findvar.c: Revert.
5704         * findcmd.c: Revert.
5705         * filesystem.c: Revert.
5706         * filename-seen-cache.h: Revert.
5707         * filename-seen-cache.c: Revert.
5708         * fbsd-tdep.c: Revert.
5709         * fbsd-nat.h: Revert.
5710         * fbsd-nat.c: Revert.
5711         * f-valprint.c: Revert.
5712         * f-typeprint.c: Revert.
5713         * f-lang.c: Revert.
5714         * extension.h: Revert.
5715         * extension.c: Revert.
5716         * extension-priv.h: Revert.
5717         * expprint.c: Revert.
5718         * exec.h: Revert.
5719         * exec.c: Revert.
5720         * exceptions.c: Revert.
5721         * event-top.c: Revert.
5722         * event-loop.c: Revert.
5723         * eval.c: Revert.
5724         * elfread.c: Revert.
5725         * dwarf2read.h: Revert.
5726         * dwarf2read.c: Revert.
5727         * dwarf2loc.c: Revert.
5728         * dwarf2expr.h: Revert.
5729         * dwarf2expr.c: Revert.
5730         * dwarf2-frame.c: Revert.
5731         * dwarf2-frame-tailcall.c: Revert.
5732         * dwarf-index-write.h: Revert.
5733         * dwarf-index-write.c: Revert.
5734         * dwarf-index-common.c: Revert.
5735         * dwarf-index-cache.h: Revert.
5736         * dwarf-index-cache.c: Revert.
5737         * dummy-frame.c: Revert.
5738         * dtrace-probe.c: Revert.
5739         * disasm.h: Revert.
5740         * disasm.c: Revert.
5741         * disasm-selftests.c: Revert.
5742         * dictionary.c: Revert.
5743         * dicos-tdep.c: Revert.
5744         * demangle.c: Revert.
5745         * dcache.h: Revert.
5746         * dcache.c: Revert.
5747         * darwin-nat.h: Revert.
5748         * darwin-nat.c: Revert.
5749         * darwin-nat-info.c: Revert.
5750         * d-valprint.c: Revert.
5751         * d-namespace.c: Revert.
5752         * d-lang.c: Revert.
5753         * ctf.c: Revert.
5754         * csky-tdep.c: Revert.
5755         * csky-linux-tdep.c: Revert.
5756         * cris-tdep.c: Revert.
5757         * cris-linux-tdep.c: Revert.
5758         * cp-valprint.c: Revert.
5759         * cp-support.c: Revert.
5760         * cp-namespace.c: Revert.
5761         * cp-abi.c: Revert.
5762         * corelow.c: Revert.
5763         * corefile.c: Revert.
5764         * continuations.c: Revert.
5765         * completer.h: Revert.
5766         * completer.c: Revert.
5767         * complaints.c: Revert.
5768         * coffread.c: Revert.
5769         * coff-pe-read.c: Revert.
5770         * cli-out.h: Revert.
5771         * cli-out.c: Revert.
5772         * charset.c: Revert.
5773         * c-varobj.c: Revert.
5774         * c-valprint.c: Revert.
5775         * c-typeprint.c: Revert.
5776         * c-lang.c: Revert.
5777         * buildsym.c: Revert.
5778         * buildsym-legacy.c: Revert.
5779         * build-id.h: Revert.
5780         * build-id.c: Revert.
5781         * btrace.c: Revert.
5782         * bsd-uthread.c: Revert.
5783         * breakpoint.h: Revert.
5784         * breakpoint.c: Revert.
5785         * break-catch-throw.c: Revert.
5786         * break-catch-syscall.c: Revert.
5787         * break-catch-sig.c: Revert.
5788         * blockframe.c: Revert.
5789         * block.c: Revert.
5790         * bfin-tdep.c: Revert.
5791         * bfin-linux-tdep.c: Revert.
5792         * bfd-target.c: Revert.
5793         * bcache.c: Revert.
5794         * ax-general.c: Revert.
5795         * ax-gdb.h: Revert.
5796         * ax-gdb.c: Revert.
5797         * avr-tdep.c: Revert.
5798         * auxv.c: Revert.
5799         * auto-load.c: Revert.
5800         * arm-wince-tdep.c: Revert.
5801         * arm-tdep.c: Revert.
5802         * arm-symbian-tdep.c: Revert.
5803         * arm-pikeos-tdep.c: Revert.
5804         * arm-obsd-tdep.c: Revert.
5805         * arm-nbsd-tdep.c: Revert.
5806         * arm-nbsd-nat.c: Revert.
5807         * arm-linux-tdep.c: Revert.
5808         * arm-linux-nat.c: Revert.
5809         * arm-fbsd-tdep.c: Revert.
5810         * arm-fbsd-nat.c: Revert.
5811         * arm-bsd-tdep.c: Revert.
5812         * arch-utils.c: Revert.
5813         * arc-tdep.c: Revert.
5814         * arc-newlib-tdep.c: Revert.
5815         * annotate.h: Revert.
5816         * annotate.c: Revert.
5817         * amd64-windows-tdep.c: Revert.
5818         * amd64-windows-nat.c: Revert.
5819         * amd64-tdep.c: Revert.
5820         * amd64-sol2-tdep.c: Revert.
5821         * amd64-obsd-tdep.c: Revert.
5822         * amd64-obsd-nat.c: Revert.
5823         * amd64-nbsd-tdep.c: Revert.
5824         * amd64-nbsd-nat.c: Revert.
5825         * amd64-nat.c: Revert.
5826         * amd64-linux-tdep.c: Revert.
5827         * amd64-linux-nat.c: Revert.
5828         * amd64-fbsd-tdep.c: Revert.
5829         * amd64-fbsd-nat.c: Revert.
5830         * amd64-dicos-tdep.c: Revert.
5831         * amd64-darwin-tdep.c: Revert.
5832         * amd64-bsd-nat.c: Revert.
5833         * alpha-tdep.c: Revert.
5834         * alpha-obsd-tdep.c: Revert.
5835         * alpha-nbsd-tdep.c: Revert.
5836         * alpha-mdebug-tdep.c: Revert.
5837         * alpha-linux-tdep.c: Revert.
5838         * alpha-linux-nat.c: Revert.
5839         * alpha-bsd-tdep.c: Revert.
5840         * alpha-bsd-nat.c: Revert.
5841         * aix-thread.c: Revert.
5842         * agent.c: Revert.
5843         * addrmap.c: Revert.
5844         * ada-varobj.c: Revert.
5845         * ada-valprint.c: Revert.
5846         * ada-typeprint.c: Revert.
5847         * ada-tasks.c: Revert.
5848         * ada-lang.c: Revert.
5849         * aarch64-tdep.c: Revert.
5850         * aarch64-ravenscar-thread.c: Revert.
5851         * aarch64-newlib-tdep.c: Revert.
5852         * aarch64-linux-tdep.c: Revert.
5853         * aarch64-linux-nat.c: Revert.
5854         * aarch64-fbsd-tdep.c: Revert.
5855         * aarch64-fbsd-nat.c: Revert.
5856         * aarch32-linux-nat.c: Revert.
5857
5858 2019-04-05  Tom Tromey  <tom@tromey.com>
5859
5860         * ft32-tdep.c: Sort headers.
5861         * frv-tdep.c: Sort headers.
5862         * frv-linux-tdep.c: Sort headers.
5863         * frame.c: Sort headers.
5864         * frame-unwind.c: Sort headers.
5865         * frame-base.c: Sort headers.
5866         * fork-child.c: Sort headers.
5867         * findvar.c: Sort headers.
5868         * findcmd.c: Sort headers.
5869         * filesystem.c: Sort headers.
5870         * filename-seen-cache.h: Sort headers.
5871         * filename-seen-cache.c: Sort headers.
5872         * fbsd-tdep.c: Sort headers.
5873         * fbsd-nat.h: Sort headers.
5874         * fbsd-nat.c: Sort headers.
5875         * f-valprint.c: Sort headers.
5876         * f-typeprint.c: Sort headers.
5877         * f-lang.c: Sort headers.
5878         * extension.h: Sort headers.
5879         * extension.c: Sort headers.
5880         * extension-priv.h: Sort headers.
5881         * expprint.c: Sort headers.
5882         * exec.h: Sort headers.
5883         * exec.c: Sort headers.
5884         * exceptions.c: Sort headers.
5885         * event-top.c: Sort headers.
5886         * event-loop.c: Sort headers.
5887         * eval.c: Sort headers.
5888         * elfread.c: Sort headers.
5889         * dwarf2read.h: Sort headers.
5890         * dwarf2read.c: Sort headers.
5891         * dwarf2loc.c: Sort headers.
5892         * dwarf2expr.h: Sort headers.
5893         * dwarf2expr.c: Sort headers.
5894         * dwarf2-frame.c: Sort headers.
5895         * dwarf2-frame-tailcall.c: Sort headers.
5896         * dwarf-index-write.h: Sort headers.
5897         * dwarf-index-write.c: Sort headers.
5898         * dwarf-index-common.c: Sort headers.
5899         * dwarf-index-cache.h: Sort headers.
5900         * dwarf-index-cache.c: Sort headers.
5901         * dummy-frame.c: Sort headers.
5902         * dtrace-probe.c: Sort headers.
5903         * disasm.h: Sort headers.
5904         * disasm.c: Sort headers.
5905         * disasm-selftests.c: Sort headers.
5906         * dictionary.c: Sort headers.
5907         * dicos-tdep.c: Sort headers.
5908         * demangle.c: Sort headers.
5909         * dcache.h: Sort headers.
5910         * dcache.c: Sort headers.
5911         * darwin-nat.h: Sort headers.
5912         * darwin-nat.c: Sort headers.
5913         * darwin-nat-info.c: Sort headers.
5914         * d-valprint.c: Sort headers.
5915         * d-namespace.c: Sort headers.
5916         * d-lang.c: Sort headers.
5917         * ctf.c: Sort headers.
5918         * csky-tdep.c: Sort headers.
5919         * csky-linux-tdep.c: Sort headers.
5920         * cris-tdep.c: Sort headers.
5921         * cris-linux-tdep.c: Sort headers.
5922         * cp-valprint.c: Sort headers.
5923         * cp-support.c: Sort headers.
5924         * cp-namespace.c: Sort headers.
5925         * cp-abi.c: Sort headers.
5926         * corelow.c: Sort headers.
5927         * corefile.c: Sort headers.
5928         * continuations.c: Sort headers.
5929         * completer.h: Sort headers.
5930         * completer.c: Sort headers.
5931         * complaints.c: Sort headers.
5932         * coffread.c: Sort headers.
5933         * coff-pe-read.c: Sort headers.
5934         * cli-out.h: Sort headers.
5935         * cli-out.c: Sort headers.
5936         * charset.c: Sort headers.
5937         * c-varobj.c: Sort headers.
5938         * c-valprint.c: Sort headers.
5939         * c-typeprint.c: Sort headers.
5940         * c-lang.c: Sort headers.
5941         * buildsym.c: Sort headers.
5942         * buildsym-legacy.c: Sort headers.
5943         * build-id.h: Sort headers.
5944         * build-id.c: Sort headers.
5945         * btrace.c: Sort headers.
5946         * bsd-uthread.c: Sort headers.
5947         * breakpoint.h: Sort headers.
5948         * breakpoint.c: Sort headers.
5949         * break-catch-throw.c: Sort headers.
5950         * break-catch-syscall.c: Sort headers.
5951         * break-catch-sig.c: Sort headers.
5952         * blockframe.c: Sort headers.
5953         * block.c: Sort headers.
5954         * bfin-tdep.c: Sort headers.
5955         * bfin-linux-tdep.c: Sort headers.
5956         * bfd-target.c: Sort headers.
5957         * bcache.c: Sort headers.
5958         * ax-general.c: Sort headers.
5959         * ax-gdb.h: Sort headers.
5960         * ax-gdb.c: Sort headers.
5961         * avr-tdep.c: Sort headers.
5962         * auxv.c: Sort headers.
5963         * auto-load.c: Sort headers.
5964         * arm-wince-tdep.c: Sort headers.
5965         * arm-tdep.c: Sort headers.
5966         * arm-symbian-tdep.c: Sort headers.
5967         * arm-pikeos-tdep.c: Sort headers.
5968         * arm-obsd-tdep.c: Sort headers.
5969         * arm-nbsd-tdep.c: Sort headers.
5970         * arm-nbsd-nat.c: Sort headers.
5971         * arm-linux-tdep.c: Sort headers.
5972         * arm-linux-nat.c: Sort headers.
5973         * arm-fbsd-tdep.c: Sort headers.
5974         * arm-fbsd-nat.c: Sort headers.
5975         * arm-bsd-tdep.c: Sort headers.
5976         * arch-utils.c: Sort headers.
5977         * arc-tdep.c: Sort headers.
5978         * arc-newlib-tdep.c: Sort headers.
5979         * annotate.h: Sort headers.
5980         * annotate.c: Sort headers.
5981         * amd64-windows-tdep.c: Sort headers.
5982         * amd64-windows-nat.c: Sort headers.
5983         * amd64-tdep.c: Sort headers.
5984         * amd64-sol2-tdep.c: Sort headers.
5985         * amd64-obsd-tdep.c: Sort headers.
5986         * amd64-obsd-nat.c: Sort headers.
5987         * amd64-nbsd-tdep.c: Sort headers.
5988         * amd64-nbsd-nat.c: Sort headers.
5989         * amd64-nat.c: Sort headers.
5990         * amd64-linux-tdep.c: Sort headers.
5991         * amd64-linux-nat.c: Sort headers.
5992         * amd64-fbsd-tdep.c: Sort headers.
5993         * amd64-fbsd-nat.c: Sort headers.
5994         * amd64-dicos-tdep.c: Sort headers.
5995         * amd64-darwin-tdep.c: Sort headers.
5996         * amd64-bsd-nat.c: Sort headers.
5997         * alpha-tdep.c: Sort headers.
5998         * alpha-obsd-tdep.c: Sort headers.
5999         * alpha-nbsd-tdep.c: Sort headers.
6000         * alpha-mdebug-tdep.c: Sort headers.
6001         * alpha-linux-tdep.c: Sort headers.
6002         * alpha-linux-nat.c: Sort headers.
6003         * alpha-bsd-tdep.c: Sort headers.
6004         * alpha-bsd-nat.c: Sort headers.
6005         * aix-thread.c: Sort headers.
6006         * agent.c: Sort headers.
6007         * addrmap.c: Sort headers.
6008         * ada-varobj.c: Sort headers.
6009         * ada-valprint.c: Sort headers.
6010         * ada-typeprint.c: Sort headers.
6011         * ada-tasks.c: Sort headers.
6012         * ada-lang.c: Sort headers.
6013         * aarch64-tdep.c: Sort headers.
6014         * aarch64-ravenscar-thread.c: Sort headers.
6015         * aarch64-newlib-tdep.c: Sort headers.
6016         * aarch64-linux-tdep.c: Sort headers.
6017         * aarch64-linux-nat.c: Sort headers.
6018         * aarch64-fbsd-tdep.c: Sort headers.
6019         * aarch64-fbsd-nat.c: Sort headers.
6020         * aarch32-linux-nat.c: Sort headers.
6021
6022 2019-04-04  Tom Tromey  <tom@tromey.com>
6023
6024         * varobj.c (varobj_create): Update.
6025         * rust-exp.y (struct rust_parser) <update_innermost_block,
6026         lookup_symbol>: New methods.
6027         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6028         Rename.
6029         (rust_parser::rust_lookup_type)
6030         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6031         * printcmd.c (display_command, do_one_display): Update.
6032         * parser-defs.h (struct parser_state) <parser_state>: Add
6033         "tracker" parameter.
6034         (block_tracker): New member.
6035         (class innermost_block_tracker) <innermost_block_tracker>: Add
6036         "types" parameter.
6037         <reset>: Remove method.
6038         (innermost_block): Don't declare.
6039         (null_post_parser): Update.
6040         * parse.c (innermost_block): Remove global.
6041         (write_dollar_variable): Update.
6042         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6043         Remove "tracker_types" parameter.
6044         (parse_expression): Add "tracker" parameter.
6045         (parse_expression_for_completion): Update.
6046         (null_post_parser): Add "tracker" parameter.
6047         * p-exp.y: Update rules.
6048         * m2-exp.y: Update rules.
6049         * language.h (struct language_defn) <la_post_parser>: Add
6050         "tracker" parameter.
6051         * go-exp.y: Update rules.
6052         * f-exp.y: Update rules.
6053         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6054         parameter.
6055         * d-exp.y: Update rules.
6056         * c-exp.y: Update rules.
6057         * breakpoint.c (set_breakpoint_condition): Create an
6058         innermost_block_tracker.
6059         (watch_command_1): Likewise.
6060         * ada-lang.c (resolve): Add "tracker" parameter.
6061         (resolve_subexp): Likewise.
6062         * ada-exp.y (write_var_from_sym): Update.
6063
6064 2019-04-04  Tom Tromey  <tom@tromey.com>
6065
6066         * type-stack.h: New file.
6067         * type-stack.c: New file.
6068         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6069         type-stack.h.
6070         (insert_into_type_stack, insert_type, push_type, push_type_int)
6071         (insert_type_address_space, pop_type, pop_type_int)
6072         (pop_typelist, pop_type_stack, append_type_stack)
6073         (push_type_stack, get_type_stack, push_typelist)
6074         (follow_type_instance_flags, follow_types): Don't declare.
6075         * parse.c (type_stack): Remove global.
6076         (parse_exp_in_context): Update.
6077         (insert_into_type_stack, insert_type, push_type, push_type_int)
6078         (insert_type_address_space, pop_type, pop_type_int)
6079         (pop_typelist, pop_type_stack, append_type_stack)
6080         (push_type_stack, get_type_stack, push_typelist)
6081         (follow_type_instance_flags, follow_types): Remove (moved to
6082         type-stack.c).
6083         * f-exp.y (type_stack): New global.
6084         Update rules.
6085         (push_kind_type, f_parse): Update.
6086         * d-exp.y (type_stack): New global.
6087         Update rules.
6088         (d_parse): Update.
6089         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6090         Update rules.
6091         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6092         (HFILES_NO_SRCDIR): Add type-stack.h.
6093
6094 2019-04-04  Tom Tromey  <tom@tromey.com>
6095
6096         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6097         (rust_parser::convert_ast_to_expression, rust_parse)
6098         (rust_lex_test_completion, rust_lex_tests): Update.
6099         * parser-defs.h (struct expr_completion_state): New.
6100         (struct parser_state) <parser_state>: Add completion parameter.
6101         <mark_struct_expression, mark_completion_tag>: New methods.
6102         <parse_completion, m_completion_state>: New members.
6103         (prefixify_expression, null_post_parser): Update.
6104         (mark_struct_expression, mark_completion_tag): Don't declare.
6105         * parse.c (parse_completion, expout_last_struct)
6106         (expout_tag_completion_type, expout_completion_name): Remove
6107         globals.
6108         (parser_state::mark_struct_expression)
6109         (parser_state::mark_completion_tag): Now methods.
6110         (prefixify_expression): Add last_struct parameter.
6111         (prefixify_subexp): Likewise.
6112         (parse_exp_1): Update.
6113         (parse_exp_in_context): Add cstate parameter.  Update.
6114         (parse_expression_for_completion): Create an
6115         expr_completion_state.
6116         (null_post_parser): Add "completion" parameter.
6117         * p-exp.y: Update rules.
6118         (yylex): Update.
6119         * language.h (struct language_defn) <la_post_parser>: Add
6120         "completing" parameter.
6121         * go-exp.y: Update rules.
6122         (lex_one_token): Update.
6123         * expression.h (parse_completion): Don't declare.
6124         * d-exp.y: Update rules.
6125         (lex_one_token): Update rules.
6126         * c-exp.y: Update rules.
6127         (lex_one_token): Update.
6128         * ada-lang.c (resolve): Add "parse_completion" parameter.
6129         (resolve_subexp): Likewise.
6130         (ada_resolve_function): Likewise.
6131
6132 2019-04-04  Tom Tromey  <tom@tromey.com>
6133
6134         * parser-defs.h (struct parser_state) <start_arglist,
6135         end_arglist>: New methods.
6136         <arglist_len, m_funcall_chain>: New members.
6137         (arglist_len, start_arglist, end_arglist): Don't declare.
6138         * parse.c (arglist_len, funcall_chain): Remove global.
6139         (start_arglist, end_arglist): Remove functions.
6140         (parse_exp_in_context): Update.
6141         * p-exp.y: Update rules.
6142         * m2-exp.y: Update rules.
6143         * go-exp.y: Update rules.
6144         * f-exp.y: Update rules.
6145         * d-exp.y: Update rules.
6146         * c-exp.y: Update rules.
6147
6148 2019-04-04  Tom Tromey  <tom@tromey.com>
6149
6150         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6151         lex_operator, push_back>: New methods.
6152         Update all rules.
6153         (rust_parser::lex_hex, lex_escape): Rename and update.
6154         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6155         (rust_parser::lex_operator): Rename and update.
6156         (rust_parser::lex_number, rustyylex, rustyyerror)
6157         (rust_lex_test_init, rust_lex_test_sequence)
6158         (rust_lex_test_push_back, rust_lex_tests): Update.
6159         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6160         parameter.
6161         <lexptr, prev_lexptr>: New members.
6162         (lexptr, prev_lexptr): Don't declare.
6163         * parse.c (lexptr, prev_lexptr): Remove globals.
6164         (parse_exp_in_context): Update.
6165         * p-exp.y (yylex, yyerror): Update.
6166         * m2-exp.y (parse_number, yylex, yyerror): Update.
6167         * go-exp.y (lex_one_token, yyerror): Update.
6168         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6169         * d-exp.y (lex_one_token, yyerror): Update.
6170         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6171         (lex_one_token, yyerror): Update.
6172         * ada-lex.l (YY_INPUT): Update.
6173         (rewind_to_char): Update.
6174         * ada-exp.y (yyerror): Update.
6175
6176 2019-04-04  Tom Tromey  <tom@tromey.com>
6177
6178         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6179         * parser-defs.h (struct parser_state) <parser_state>: Add new
6180         parameter.
6181         <comma_terminates>: New member.
6182         (comma_terminates): Don't declare global.
6183         * parse.c (comma_terminates): Remove global.
6184         (parse_exp_in_context): Update.
6185         * p-exp.y (yylex): Update.
6186         * m2-exp.y (yylex): Update.
6187         * go-exp.y (lex_one_token): Update.
6188         * f-exp.y (yylex): Update.
6189         * d-exp.y (lex_one_token): Update.
6190         * c-exp.y (lex_one_token): Update.
6191         * ada-lex.l: Update.
6192
6193 2019-04-04  Tom Tromey  <tom@tromey.com>
6194
6195         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6196         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6197         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6198         * parser-defs.h (paren_depth): Don't declare.
6199         * parse.c (paren_depth): Remove global.
6200         (parse_exp_in_context): Update.
6201         * p-exp.y (paren_depth): New global.
6202         (pascal_parse): Initialize it.
6203         * m2-exp.y (paren_depth): New global.
6204         (m2_parse): Initialize it.
6205         * go-exp.y (paren_depth): New global.
6206         (go_parse): Initialize it.
6207         * f-exp.y (paren_depth): New global.
6208         (f_parse): Initialize it.
6209         * d-exp.y (paren_depth): New global.
6210         (d_parse): Initialize it.
6211         * c-exp.y (paren_depth): New global.
6212         (c_parse): Initialize it.
6213         * ada-lex.l (paren_depth): New global.
6214         (lexer_init): Initialize it.
6215
6216 2019-04-04  Tom Tromey  <tom@tromey.com>
6217
6218         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6219         (rust_parser::convert_ast_to_type)
6220         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6221         * parser-defs.h (struct parser_state) <parser_state>: Add
6222         parameters.  Initialize new members.
6223         <expression_context_block, expression_context_pc>: New members.
6224         * parse.c (expression_context_block, expression_context_pc):
6225         Remove globals.
6226         (parse_exp_in_context): Update.
6227         * p-exp.y: Update all rules.
6228         (yylex): Update.
6229         * m2-exp.y: Update all rules.
6230         (yylex): Update.
6231         * go-exp.y (yylex): Update.
6232         * f-exp.y (yylex): Update.
6233         * d-exp.y: Update all rules.
6234         (yylex): Update.
6235         * c-exp.y: Update all rules.
6236         (lex_one_token, classify_name, yylex, c_parse): Update.
6237         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6238
6239 2019-04-04  Tom Tromey  <tom@tromey.com>
6240
6241         * gdbarch.h, gdbarch.c: Rebuild.
6242         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6243         * stap-probe.h:
6244         (struct stap_parse_info): Replace "parser_state" with
6245         "expr_builder".
6246         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6247         (parser_state): New class.
6248         * parse.c (expr_builder): Rename.
6249         (expr_builder::release): Rename.
6250         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6251         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6252         (write_exp_elt_longcst, write_exp_elt_floatcst)
6253         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6254         (write_exp_string_vector, write_exp_bitstring)
6255         (write_exp_msymbol, mark_struct_expression)
6256         (write_dollar_variable)
6257         (insert_type_address_space, increase_expout_size): Replace
6258         "parser_state" with "expr_builder".
6259         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6260         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6261         "parser_state" with "expr_builder".
6262
6263 2019-04-04  Tom Tromey  <tom@tromey.com>
6264
6265         * rust-exp.y: Replace "parse_language" with method call.
6266         * p-exp.y:
6267         (yylex): Replace "parse_language" with method call.
6268         * m2-exp.y:
6269         (yylex): Replace "parse_language" with method call.
6270         * go-exp.y (classify_name): Replace "parse_language" with method
6271         call.
6272         * f-exp.y (yylex): Replace "parse_language" with method call.
6273         * d-exp.y (lex_one_token): Replace "parse_language" with method
6274         call.
6275         * c-exp.y:
6276         (lex_one_token, classify_name, yylex): Replace "parse_language"
6277         with method call.
6278         * ada-exp.y (find_primitive_type, type_char)
6279         (type_system_address): Replace "parse_language" with method call.
6280
6281 2019-04-04  Tom Tromey  <tom@tromey.com>
6282
6283         * rust-exp.y: Replace "parse_gdbarch" with method call.
6284         * parse.c (write_dollar_variable, insert_type_address_space):
6285         Replace "parse_gdbarch" with method call.
6286         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6287         call.
6288         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6289         call.
6290         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6291         "parse_gdbarch" with method call.
6292         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6293         with method call.
6294         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6295         "parse_gdbarch" with method call.
6296         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6297         "parse_gdbarch" with method call.
6298         * c-exp.y (parse_type, parse_number, classify_name): Replace
6299         "parse_gdbarch" with method call.
6300         * ada-lex.l: Replace "parse_gdbarch" with method call.
6301         * ada-exp.y (parse_type, find_primitive_type, type_char)
6302         (type_system_address): Replace "parse_gdbarch" with method call.
6303
6304 2019-04-04  Tom Tromey  <tom@tromey.com>
6305
6306         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6307         * stap-probe.c (stap_parse_argument): Update.
6308         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6309         initial_size parameter.
6310         * rust-exp.y (rust_lex_tests): Update.
6311         * parse.c (parser_state): Update.
6312         (parse_exp_in_context): Update.
6313         * parser-defs.h (struct parser_state) <parser_state>: Remove
6314         "initial_size" parameter.
6315
6316 2019-04-04  Tom Tromey  <tom@tromey.com>
6317
6318         * parser-defs.h (increase_expout_size): Don't declare.
6319         * parse.c (increase_expout_size): Now static.
6320
6321 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6322
6323         * gnu-nat.c (gnu_nat_target::wait): Fix
6324         target_waitstatus_to_string call.
6325
6326 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6327
6328         * eval.c (evaluate_subexp_standard): Handle internal functions
6329         during Fortran function call handling.
6330
6331 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6332
6333         * NEWS: Mention new internal functions.
6334         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6335         (read_base_type): Use dwarf2_init_complex_target_type.
6336         * value.c (creal_internal_fn): New function.
6337         (cimag_internal_fn): New function.
6338         (_initialize_values): Register new internal functions.
6339
6340 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6341
6342         * infrun.c (stop_all_threads): If debug_infrun, always
6343         trace the wait status after wait_one, using
6344         target_waitstatus_to_string and target_pid_to_str.
6345         (handle_inferior_event): Replace various trace of
6346         wait status kind by a single trace.
6347         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6348         wait status kind image by target_waitstatus_to_string.
6349         * target/waitstatus.c (target_waitstatus_to_string): Fix
6350         obsolete comment.
6351
6352 2019-04-01  Tom Tromey  <tromey@adacore.com>
6353
6354         PR symtab/23331:
6355         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6356
6357 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6358             Pedro Alves  <palves@redhat.com>
6359
6360         * top.c (quit_force): Call 'finalize_values'.
6361         * value.c (finalize_values): New function.
6362         * value.h (finalize_values): Declare.
6363
6364 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6365
6366         * NEWS: Announce $_gdb_major and $_gdb_minor.
6367
6368         * top.c (init_gdb_version_vars): New function.
6369         (gdb_init): Call init_gdb_version_vars.
6370
6371 2019-03-29  Tom Tromey  <tromey@adacore.com>
6372
6373         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6374         help text.  Remove dead code.
6375
6376 2019-03-29  Keith Seitz  <keiths@redhat.com>
6377
6378         From Siddhesh Poyarekar:
6379         * f-lang.h (f77_get_upperbound): Return LONGEST.
6380         (f77_get_lowerbound): Likewise.
6381         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6382         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6383         print them.
6384         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6385         plongest to format print it.
6386         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6387         (f77_get_upperbound): Likewise.
6388         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6389         LOWER_BOUND to LONGEST.
6390         (f77_create_arrayprint_offset_tbl): Likewise.
6391
6392 2019-03-29  Keith Seitz  <keiths@redhat.com>
6393
6394         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6395         %s/pulongest for TYPE_LENGTH instead of %d in format
6396         strings.
6397         * ada-typerint.c (ada_print_type): Likewise.
6398         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6399         * compile/compile-c-support.c (generate_register_struct): Likewise.
6400         * gdbtypes.c (recursive_dump_type): Likewise.
6401         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6402         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6403         instead of %d in format strings.
6404         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6405         to std::min to ULONGEST.
6406         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6407         instead of %d in format strings.
6408         * tracepoint.c (info_scope_command): Likewise.
6409         * typeprint.c (print_offset_data::update)
6410         (print_offset_data::finish): Likewise.
6411         * xtensa-tdep.c (xtensa_store_return_value)
6412         (xtensa_push_dummy_call): Likewise.
6413
6414 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6415
6416         * windows-nat.c (display_selector): Fixed format specifications
6417         for 64-bit Cygwin.
6418
6419 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6420
6421         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6422
6423 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6424
6425         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6426         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6427         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6428         (nios2_linux_init_abi): Install it.
6429
6430 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6431
6432         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6433
6434 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6435
6436         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6437
6438 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6439             Tom Tromey  <tromey@adacore.com>
6440
6441         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6442
6443 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6444
6445         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6446         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6447         method to compute the bounds of range types. Also print "[evaluated]"
6448         if the bounds' values come from a dynamic evaluation.
6449
6450 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6453         whitespace when pretty printing is on.
6454
6455 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6456
6457         * ppc-linux-nat.c: Add include.
6458
6459 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6460
6461         * NEWS: Mention AArch64 Pointer Authentication.
6462
6463 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6464
6465         * arm-linux-nat.c: Add include.
6466
6467 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6468
6469         * source-cache.c (source_cache::get_source_lines): Re-read
6470         fullname after calling open_source_file.
6471
6472 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6473
6474         * NEWS: Mention TLS support for FreeBSD.
6475
6476 2019-03-25  Tom Tromey  <tromey@adacore.com>
6477
6478         * minsyms.c (BUNCH_SIZE): Update comment.
6479         (~minimal_symbol_reader): Remove old comment.
6480         (compact_minimal_symbols): Update comment.
6481         (minimal_symbol_reader::install): Remove old comment.  Update
6482         other comments.
6483
6484 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6485
6486         * s390-linux-nat.c: Add include.
6487
6488 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6489
6490         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6491         Call linux_get_hwcap.
6492         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6493         Likewise.
6494         (aarch64_linux_get_hwcap): Remove function.
6495         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6496         declaration.
6497         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6498         linux_get_hwcap.
6499         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6500         * linux-tdep.c (linux_get_hwcap): Add function.
6501         (linux_get_hwcap2): Likewise.
6502         * linux-tdep.h (linux_get_hwcap): Add declaration.
6503         (linux_get_hwcap2): Likewise.
6504         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6505         (ppc_linux_get_hwcap2): Likewise.
6506         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6507         linux_get_hwcap.
6508         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6509         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6510         (ppc_linux_nat_target::read_description): Likewise.
6511         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6512         * s390-linux-nat.c: Likewise.
6513         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6514
6515 2019-03-24  Tom Tromey  <tom@tromey.com>
6516
6517         * ada-lang.c (standard_lookup): Simplify initialization.
6518         (ada_lookup_symbol_nonlocal): Simplify return.
6519         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6520         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6521         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6522         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6523         initialization.
6524         * solib.c (solib_global_lookup): Simplify.
6525         * symtab.c (null_block_symbol): Remove.
6526         (symbol_cache_lookup): Simplify returns.
6527         (lookup_language_this): Simplify returns.
6528         (lookup_symbol_aux): Simplify return.
6529         (lookup_local_symbol): Simplify returns.
6530         (lookup_global_symbol_from_objfile): Simplify return.
6531         (lookup_symbol_in_objfile_symtabs)
6532         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6533         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6534         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6535         * cp-namespace.c (cp_lookup_bare_symbol)
6536         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6537         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6538         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6539         (cp_lookup_symbol_via_imports): Simplify initialization.
6540         (find_symbol_in_baseclass): Likewise.
6541         * symtab.h (null_block_symbol): Remove.
6542         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6543         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6544         (d_lookup_symbol_module): Likewise.
6545         (find_symbol_in_baseclass): Simplify initialization.
6546
6547 2019-03-24  Tom Tromey  <tom@tromey.com>
6548
6549         * expression.h: Don't include symtab.h.
6550         (struct block): Forward declare.
6551
6552 2019-03-24  Tom Tromey  <tom@tromey.com>
6553
6554         * c-exp.y (typebase): Remove casts.
6555         * gdbtypes.c (lookup_unsigned_typename, )
6556         (lookup_signed_typename): Remove cast.
6557         * eval.c (parse_to_comma_and_eval): Remove cast.
6558         * parse.c (write_dollar_variable): Remove cast.
6559         * block.h (struct block) <superblock>: Now const.
6560         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6561         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6562         (map_block): Make "block" const.
6563         * symfile.h (struct quick_symbol_functions)
6564         <map_matching_symbols>: Constify block argument to "callback".
6565         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6566         const.
6567         (find_pc_sect_compunit_symtab): Make "b" const.
6568         (find_symbol_at_address): Likewise.
6569         (search_symbols): Likewise.
6570         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6571         (dw2_debug_names_lookup_symbol): Likewise.
6572         (dw2_map_matching_symbols): Update.
6573         * p-valprint.c (pascal_val_print): Remove "block".
6574         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6575         (aux_add_nonlocal_symbols): Make "block" const.
6576         (resolve_subexp): Remove cast.
6577         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6578         const.
6579         (iterate_over_file_blocks): Likewise.
6580         * f-exp.y (%union) <bval>: Remove.
6581         * coffread.c (patch_opaque_types): Make "b" const.
6582         * spu-tdep.c (spu_catch_start): Make "block" const.
6583         * c-valprint.c (print_unpacked_pointer): Remove "block".
6584         * symmisc.c (dump_symtab_1): Make "b" const.
6585         (block_depth): Make "block" const.
6586         * d-exp.y (%union) <bval>: Remove.
6587         * cp-support.h (cp_lookup_rtti_type): Update.
6588         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6589         * psymtab.c (psym_lookup_symbol): Make "block" const.
6590         (maintenance_check_psymtabs): Make "b" const.
6591         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6592         (enumerate_locals, enumerate_args): Update.
6593         * python/py-symtab.c (stpy_global_block): Make "block" const.
6594         (stpy_static_block): Likewise.
6595         * inline-frame.c (block_starting_point_at): Make "new_block"
6596         const.
6597         * block.c (find_block_in_blockvector): Make return type const.
6598         (blockvector_for_pc_sect): Make "b" const.
6599         (find_block_in_blockvector): Make "b" const.
6600
6601 2019-03-23  Tom Tromey  <tom@tromey.com>
6602
6603         * varobj.c (varobj_create): Update.
6604         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6605         * printcmd.c (display_command, do_one_display): Don't reset
6606         innermost_block.
6607         * parser-defs.h (enum innermost_block_tracker_type): Move to
6608         expression.h.
6609         (innermost_block): Update comment.
6610         * parse.c (parse_exp_1): Add tracker_types parameter.
6611         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6612         tracker_types parameter.  Reset innermost_block.
6613         (parse_exp_in_context): Remove.
6614         (parse_expression_for_completion): Update.
6615         * objfiles.c (~objfile): Don't reset expression_context_block or
6616         innermost_block.
6617         * expression.h (enum innermost_block_tracker_type): Move from
6618         parser-defs.h.
6619         (parse_exp_1): Add tracker_types parameter.
6620         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6621         reset innermost_block.
6622
6623 2019-03-23  Tom Tromey  <tom@tromey.com>
6624
6625         * objfiles.h: Include bcache.h.
6626
6627 2019-03-23  Tom Tromey  <tom@tromey.com>
6628
6629         * linespec.c (get_current_search_block): Use
6630         scoped_restore_current_language.
6631         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6632
6633 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6634             Jiong Wang  <jiong.wang@arm.com>
6635
6636         * aarch64-linux-tdep.c
6637         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6638         section.
6639         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6640
6641 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6642             Jiong Wang  <jiong.wang@arm.com>
6643
6644         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6645         instructions.
6646         (aarch64_analyze_prologue_test): Add PACIASP test.
6647         (aarch64_prologue_prev_register): Unmask PC value.
6648
6649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6650             Jiong Wang  <jiong.wang@arm.com>
6651
6652         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6653         (aarch64_dwarf2_prev_register): Unmask PC value.
6654         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6655         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6656         DW_CFA_AARCH64_negate_ra_state.
6657         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6658
6659 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6660             Jiong Wang  <jiong.wang@arm.com>
6661
6662         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6663         registers.
6664         (aarch64_pseudo_register_name): Likewise.
6665         (aarch64_pseudo_register_type): Likewise.
6666         (aarch64_pseudo_register_reggroup_p): Likewise.
6667         (aarch64_gdbarch_init): Add pauth registers.
6668         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6669         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6670         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6671         (struct gdbarch_tdep): Add regnum for ra_state.
6672
6673 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6674             Jiong Wang  <jiong.wang@arm.com>
6675
6676         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6677
6678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6679             Jiong Wang  <jiong.wang@arm.com>
6680
6681         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6682         function.
6683         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6684         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6685         (aarch64_gdbarch_init): Add puth registers.
6686         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6687         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6688         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6689
6690 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6691             Jiong Wang  <jiong.wang@arm.com>
6692
6693         * aarch64-linux-nat.c
6694         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6695         * aarch64-linux-tdep.c
6696         (aarch64_linux_core_read_description): Likewise.
6697         (aarch64_linux_get_hwcap): New function.
6698         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6699         (aarch64_linux_get_hwcap): New declaration.
6700
6701 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6702             Jiong Wang  <jiong.wang@arm.com>
6703
6704         * aarch64-linux-nat.c
6705         (aarch64_linux_nat_target::read_description): Add pauth param.
6706         * aarch64-linux-tdep.c
6707         (aarch64_linux_core_read_description): Likewise.
6708         * aarch64-tdep.c (struct target_desc): Add in pauth.
6709         (aarch64_read_description): Add pauth param.
6710         (aarch64_gdbarch_init): Likewise.
6711         * aarch64-tdep.h (aarch64_read_description): Likewise.
6712         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6713         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6714         * features/Makefile: Add new files.
6715         * features/aarch64-pauth.c: New file.
6716         * features/aarch64-pauth.xml: New file.
6717
6718 2019-03-20  Tom Tromey  <tromey@adacore.com>
6719
6720         * infrun.c (handle_inferior_event): Rename from
6721         handle_inferior_event_1.  Create a scoped_value_mark.
6722         (handle_inferior_event): Remove.
6723
6724 2019-03-19  Tom Tromey  <tromey@adacore.com>
6725
6726         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6727         * infrun.h (print_stop_event): Add "displays" parameter.
6728         * infrun.c (print_stop_event): Add "displays" parameter.
6729
6730 2019-03-19  Pedro Alves  <palves@redhat.com>
6731
6732         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6733         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6734         to -1.  Fix TABs vs spaces.
6735         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6736         * tui/tui-out.h (tui_ui_out) Add intro comments.
6737         <m_line, m_start_of_line>: In-class initialize, and add describing
6738         comment.
6739
6740 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6741
6742         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6743         variable names.
6744         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6745
6746 2019-03-18  Pedro Alves  <palves@redhat.com>
6747             Eli Zaretskii <eliz@gnu.org>
6748
6749         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6750         m_line and m_start_of_line.
6751
6752 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6753
6754         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6755         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6756         it returns a newline.  This fixes a regression in TU mode, whereby
6757         the next line is output on the same screen line as the user input.
6758
6759 2019-03-18  Tom Tromey  <tromey@adacore.com>
6760
6761         * minsyms.c (minimal_symbol_reader::install): Remove call to
6762         obstack_blank.
6763
6764 2019-03-18  Pedro Alves  <palves@redhat.com>
6765
6766         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6767         New globals.
6768         (apply_style): New, factored out from ...
6769         (apply_ansi_escape): ... this.  Handle reverse video mode.
6770         (tui_set_reverse_mode): New function.
6771         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6772         * tui/tui-winsource.c (tui_show_source_line): Use
6773         tui_set_reverse_mode instead of setting A_STANDOUT.
6774         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6775         New setter methods.
6776
6777 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6778
6779         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6780         Handle tabs.
6781
6782 2019-03-18  Tom Tromey  <tromey@adacore.com>
6783
6784         * ada-lang.c (empty_array): Add "high" parameter.
6785         (ada_evaluate_subexp): Update.
6786
6787 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6788
6789         * unittests/string_view-selftests.c: Define
6790         _initialize_string_view_selftests unconditionally.
6791
6792 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6793
6794         PR gdb/24350
6795         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6796
6797 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6798
6799         PR gdb/24351
6800         * windows-nat.c (display_selector): Fix format specifiers.
6801
6802 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6803
6804         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6805         tui_refill_source_window instead of tui_refresh_win, to update the
6806         current execution line.  This fixes redisplay of the current line
6807         when stepping through the code with "next" or "step".
6808
6809 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6810
6811         * source-cache.c (source_cache::get_source_lines): Call
6812         find_source_lines to initialize s->nlines.  This fixes vertical
6813         scrolling of TUI source window when the DOWN arrow is pressed.
6814
6815 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6816
6817         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6818         linux-thread-db.c (_initialize_thread_db): Likewise.
6819
6820 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6821
6822         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6823         wclrtoeol in tui_show_source_line".  This reverts changes made in
6824         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6825
6826 2019-03-15  Tom Tromey  <tom@tromey.com>
6827
6828         * symtab.h (struct minimal_symbol): Derive from
6829         general_symbol_info.
6830         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6831         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6832         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6833         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6834         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6835         (MSYMBOL_SEARCH_NAME): Update.
6836         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6837         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6838         * minsyms.c (minimal_symbol_reader::record_full): Update.
6839
6840 2019-03-15  Tom Tromey  <tom@tromey.com>
6841
6842         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6843
6844 2019-03-15  Tom Tromey  <tom@tromey.com>
6845
6846         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6847         unique_xmalloc_ptr.
6848         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6849         Update.
6850         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6851         (build_minimal_symbol_hash_tables)
6852         (minimal_symbol_reader::install): Update.
6853
6854 2019-03-15  Tom Tromey  <tom@tromey.com>
6855
6856         * symtab.c (create_demangled_names_hash): Update.
6857         (symbol_set_names): Update.
6858         * objfiles.h (struct objfile_per_bfd_storage)
6859         <demangled_names_hash>: Now an htab_up.
6860         * objfiles.c (objfile_per_bfd_storage): Simplify.
6861
6862 2019-03-15  Tom Tromey  <tom@tromey.com>
6863
6864         * objfiles.h (struct objfile_per_bfd_storage): Declare
6865         destructor.
6866         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6867         New.
6868         (get_objfile_bfd_data): Use new.  Don't initialize
6869         language_of_main.
6870         (free_objfile_per_bfd_storage): Remove.
6871         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6872
6873 2019-03-15  Tom Tromey  <tom@tromey.com>
6874
6875         * symfile.c (reread_symbols): Update.
6876         * objfiles.c (objfile::objfile): Update.
6877         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6878         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6879         comment.
6880         (minimal_symbol_reader::install): Update.
6881         (terminate_minimal_symbol_table): Remove.
6882         * jit.c (jit_object_close_impl): Update.
6883
6884 2019-03-15  Tom Tromey  <tom@tromey.com>
6885
6886         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6887         initializations.
6888
6889 2019-03-15  Tom Tromey  <tom@tromey.com>
6890
6891         * objfiles.h (struct objfile_per_bfd_storage)
6892         <demangled_hash_languages>: Now a bitset.
6893         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6894         (lookup_minimal_symbol): Update.
6895
6896 2019-03-15  Tom Tromey  <tom@tromey.com>
6897
6898         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6899         Don't return the symbol.
6900         * coffread.c (record_minimal_symbol): Use record_full.
6901
6902 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6903
6904         The MS-Windows port of ncurses fails to switch to a color pair if
6905         one or both of the colors are the implicit default colors.  This
6906         change records the default colors when TUI is initialized, and
6907         then specifies them explicitly when a color pair uses the default
6908         colors.  This allows color styling in TUI mode on MS-Windows.
6909
6910         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6911         ncurses_norm_attr.
6912         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6913         colors in ncurses_norm_attr.
6914         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6915         "none", replace it with the default color recorded in
6916         ncurses_norm_attr.
6917
6918 2019-03-14  Tom Tromey  <tromey@adacore.com>
6919
6920         * source-cache.h (class source_cache) <get_source_lines>: Return
6921         std::string.
6922         * source-cache.c (source_cache::extract_lines): Handle case where
6923         first_pos==npos.  Return std::string.
6924         (source_cache::get_source_lines): Update.
6925
6926 2019-03-14  Tom Tromey  <tromey@adacore.com>
6927
6928         * NEWS: Add item for "style sources" commands.
6929         * source-cache.c (source_cache::get_source_lines): Check
6930         source_styling.
6931         * cli/cli-style.c (source_styling): New global.
6932         (_initialize_cli_style): Add "style sources" commands.
6933         (show_style_sources): New function.
6934         * cli/cli-style.h (source_styling): Declare.
6935
6936 2019-03-14  Pedro Alves  <palves@redhat.com>
6937             Tom Tromey  <tromey@adacore.com>
6938
6939         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6940         * tui/tui-winsource.c (tui_refill_source_window): New function,
6941         from...
6942         (tui_horizontal_source_scroll): ... here.  Move some logic.
6943         * cli/cli-style.c (set_style_enabled): Notify new observable.
6944         * tui/tui-hooks.c (tui_redisplay_source): New function.
6945         (tui_attach_detach_observers): Attach or detach
6946         tui_redisplay_source.
6947         * observable.h (source_styling_changed): New observable.
6948         * observable.c: Define source_styling_changed observable.
6949
6950 2019-03-13  Tom Tromey  <tromey@adacore.com>
6951
6952         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6953         (i386_gnu_nat_target::store_registers): Update.
6954         * target-debug.h (target_debug_print_std_string): New macro.
6955         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6956         * windows-tdep.c (display_one_tib): Update.
6957         * tui/tui-stack.c (tui_make_status_line): Update.
6958         * top.c (print_inferior_quit_action): Update.
6959         * thread.c (thr_try_catch_cmd): Update.
6960         (add_thread_with_info): Update.
6961         (thread_target_id_str): Update.
6962         (thr_try_catch_cmd): Update.
6963         (thread_command): Update.
6964         (thread_find_command): Update.
6965         * record-btrace.c (record_btrace_target::info_record)
6966         (record_btrace_resume_thread, record_btrace_target::resume)
6967         (record_btrace_cancel_resume, record_btrace_step_thread)
6968         (record_btrace_target::wait, record_btrace_target::wait)
6969         (record_btrace_target::wait, record_btrace_target::stop): Update.
6970         * progspace.c (print_program_space): Update.
6971         * process-stratum-target.c
6972         (process_stratum_target::thread_address_space): Update.
6973         * linux-fork.c (linux_fork_mourn_inferior)
6974         (detach_checkpoint_command, info_checkpoints_command)
6975         (linux_fork_context): Update.
6976         (linux_fork_detach): Update.
6977         (class scoped_switch_fork_info): Update.
6978         (delete_checkpoint_command): Update.
6979         * infrun.c (follow_fork_inferior): Update.
6980         (follow_fork_inferior): Update.
6981         (proceed_after_vfork_done): Update.
6982         (handle_vfork_child_exec_or_exit): Update.
6983         (follow_exec): Update.
6984         (displaced_step_prepare_throw): Update.
6985         (displaced_step_restore): Update.
6986         (start_step_over): Update.
6987         (resume_1): Update.
6988         (clear_proceed_status_thread): Update.
6989         (proceed): Update.
6990         (print_target_wait_results): Update.
6991         (do_target_wait): Update.
6992         (context_switch): Update.
6993         (stop_all_threads): Update.
6994         (restart_threads): Update.
6995         (finish_step_over): Update.
6996         (handle_signal_stop): Update.
6997         (switch_back_to_stepped_thread): Update.
6998         (keep_going_pass_signal): Update.
6999         (print_exited_reason): Update.
7000         (normal_stop): Update.
7001         * inferior.c (inferior_pid_to_str): Change return type.
7002         (print_selected_inferior): Update.
7003         (add_inferior): Update.
7004         (detach_inferior): Update.
7005         * dummy-frame.c (fprint_dummy_frames): Update.
7006         * dcache.c (dcache_info_1): Update.
7007         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7008         (btrace_fetch, btrace_clear): Update.
7009         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7010         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7011         type.
7012         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7013         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7014         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7015         * gdbarch.c, gdbarch.h: Rebuild.
7016         * gdbarch.sh (core_pid_to_str): Change return type.
7017         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7018         return type.
7019         (windows_nat_target::pid_to_str): Change return type.
7020         (windows_delete_thread): Update.
7021         (windows_nat_target::attach): Update.
7022         (windows_nat_target::files_info): Update.
7023         * target-delegates.c: Rebuild.
7024         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7025         return type.
7026         (sol_thread_target::pid_to_str): Change return type.
7027         * remote.c (class remote_target) <pid_to_str>: Change return
7028         type.
7029         (remote_target::pid_to_str): Change return type.
7030         (extended_remote_target::attach, remote_target::remote_stop_ns)
7031         (remote_target::remote_notif_remove_queued_reply)
7032         (remote_target::push_stop_reply, remote_target::disable_btrace):
7033         Update.
7034         (extended_remote_target::attach): Update.
7035         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7036         type.
7037         (gdbsim_target::pid_to_str): Change return type.
7038         * ravenscar-thread.c (struct ravenscar_thread_target)
7039         <pid_to_str>: Change return type.
7040         (ravenscar_thread_target::pid_to_str): Change return type.
7041         * procfs.c (class procfs_target) <pid_to_str>: Change return
7042         type.
7043         (procfs_target::pid_to_str): Change return type.
7044         (procfs_target::attach): Update.
7045         (procfs_target::detach): Update.
7046         (procfs_target::fetch_registers): Update.
7047         (procfs_target::store_registers): Update.
7048         (procfs_target::wait): Update.
7049         (procfs_target::files_info): Update.
7050         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7051         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7052         return type.
7053         (nto_procfs_target::pid_to_str): Change return type.
7054         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7055         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7056         return type.
7057         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7058         (exit_lwp): Update.
7059         (attach_proc_task_lwp_callback, get_detach_signal)
7060         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7061         (linux_nat_target::resume, wait_lwp, stop_callback)
7062         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7063         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7064         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7065         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7066         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7067         type.
7068         (inf_ptrace_target::attach): Update.
7069         (inf_ptrace_target::files_info): Update.
7070         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7071         type.
7072         (go32_nat_target::pid_to_str): Change return type.
7073         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7074         (gnu_nat_target::wait): Update.
7075         (gnu_nat_target::wait): Update.
7076         (gnu_nat_target::resume): Update.
7077         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7078         (fbsd_nat_target::wait): Update.
7079         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7080         type.
7081         (darwin_nat_target::attach): Update.
7082         * corelow.c (class core_target) <pid_to_str>: Change return type.
7083         (core_target::pid_to_str): Change return type.
7084         * target.c (normal_pid_to_str): Change return type.
7085         (default_pid_to_str): Likewise.
7086         (target_pid_to_str): Change return type.
7087         (target_translate_tls_address): Update.
7088         (target_announce_detach): Update.
7089         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7090         return type.
7091         (bsd_uthread_target::pid_to_str): Change return type.
7092         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7093         type.
7094         (bsd_kvm_target::pid_to_str): Change return type.
7095         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7096         return type.
7097         (aix_thread_target::pid_to_str): Change return type.
7098         * target.h (struct target_ops) <pid_to_str>: Change return type.
7099         (target_pid_to_str, normal_pid_to_str): Likewise.
7100         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7101         type.
7102         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7103         type.
7104         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7105         return type.
7106         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7107         type.
7108         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7109         type.
7110         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7111         return type.
7112
7113 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7114
7115         * NEWS: Mention that the new default MI version is 3.  Mention
7116         changes to the output of commands and events that deal with
7117         multi-location breakpoints.
7118         * breakpoint.c: Include "mi/mi-out.h".
7119         (print_one_breakpoint): Change output syntax if using MI version
7120         >= 3.
7121         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7122         New.
7123         (mi_multi_location_breakpoint_output_fixed): New.
7124         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7125         (mi_cmd_fix_multi_location_breakpoint_output): New.
7126         (mi_multi_location_breakpoint_output_fixed): New.
7127         * mi/mi-cmds.c (mi_cmds): Register command
7128         -fix-multi-location-breakpoint-output.
7129         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7130         interpreter "mi".
7131
7132 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7133
7134         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7135         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7136         instantiate mi_ui_out based on interpreter name.
7137         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7138         * mi/mi-main.c (mi_load_progress): Likewise.
7139
7140 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7141
7142         * NEWS: Combine separate "New targets" sections for 8.3.
7143
7144 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7145
7146         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7147         (ppcfbsd_init_abi): Install gdbarch
7148         "fetch_tls_load_module_address" and "get_thread_local_address"
7149         methods.
7150
7151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7152
7153         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7154         (riscv_fbsd_init_abi): Install gdbarch
7155         "fetch_tls_load_module_address" and "get_thread_local_address"
7156         methods.
7157
7158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7159
7160         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7161         (i386fbsd_init_abi): Install gdbarch
7162         "fetch_tls_load_module_address" and "get_thread_local_address"
7163         methods.
7164
7165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7166
7167         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7168         (amd64fbsd_init_abi): Install gdbarch
7169         "fetch_tls_load_module_address" and "get_thread_local_address"
7170         methods.
7171
7172 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7173
7174         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7175         (struct fbsd_pspace_data): New type.
7176         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7177         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7178         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7179         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7180         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7181
7182 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7183
7184         * gdbtypes.c (lookup_struct_elt): New function.
7185         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7186         * gdbtypes.h (struct struct_elt): New type.
7187         (lookup_struct_elt): New prototype.
7188
7189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7190
7191         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7192         remove disabled code block.
7193
7194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7195
7196         * gdbarch.sh (get_thread_local_address): New method.
7197         * gdbarch.h, gdbarch.c: Regenerate.
7198         * target.c (target_translate_tls_address): Use
7199         gdbarch_get_thread_local_address if present instead of
7200         target::get_thread_local_address.
7201
7202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7203
7204         * target.h (target::get_thread_local_address): Update comment.
7205
7206 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7207
7208         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7209         objfile->separate_debug_objfile_backlink if not NULL.
7210
7211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7212
7213         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7214         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7215         (amd64bsd_store_inferior_registers): Likewise.
7216         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7217         Enable segment base registers.
7218         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7219         PT_GETFSBASE and PT_GETGSBASE.
7220         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7221         PT_SETGSBASE.
7222         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7223         segment base registers.
7224         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7225
7226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7227
7228         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7229         Update calls to i386_target_description to add 'segments'
7230         parameter.
7231         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7232         add segment base registers.
7233         * arch/i386.c (i386_create_target_description): Add 'segments'
7234         parameter to enable segment base registers.
7235         * arch/i386.h (i386_create_target_description): Likewise.
7236         * features/i386/32bit-segments.xml: New file.
7237         * features/i386/32bit-segments.c: Generate.
7238         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7239         call to i386_target_description to add 'segments' parameter.
7240         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7241         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7242         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7243         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7244         if feature is present.
7245         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7246         Add 'segments' parameter to call to i386_target_description.
7247         (i386_target_description): Add 'segments' parameter to enable
7248         segment base registers.
7249         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7250         to call to i386_target_description.
7251         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7252         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7253         Define I386_NUM_REGS.
7254         (i386_target_description): Add 'segments' parameter to enable
7255         segment base registers.
7256
7257 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7258
7259         PR/24325
7260         * source-cache.c: #undef open and close, to avoid unresolved
7261         externals during linking.
7262
7263 2019-03-12  Tom Tromey  <tromey@adacore.com>
7264
7265         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7266         const.  Add initializers.
7267         (_initialize_remote): Don't initialize ptid globals.
7268
7269 2019-03-12  Pedro Alves  <palves@redhat.com>
7270
7271         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7272
7273 2019-03-12  Pedro Alves  <palves@redhat.com>
7274
7275         * cp-name-parser.y (main): Remove unused 'len' variable.
7276
7277 2019-03-12  Tom Tromey  <tromey@adacore.com>
7278
7279         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7280         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7281
7282 2019-03-12  Tom Tromey  <tromey@adacore.com>
7283
7284         * linux-nat.c (iterate_over_lwps): Update.
7285         (stop_callback): Remove parameter.
7286         (stop_wait_callback, detach_callback, resume_set_callback)
7287         (select_singlestep_lwp_callback, set_ignore_sigint)
7288         (status_callback, resumed_callback, resume_clear_callback)
7289         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7290         data parameter.
7291         (linux_nat_target::detach, linux_nat_target::resume)
7292         (linux_stop_and_wait_all_lwps, select_event_lwp)
7293         (linux_nat_filter_event, linux_nat_wait_1)
7294         (linux_nat_target::kill, linux_nat_target::stop)
7295         (linux_nat_target::stop): Update.
7296         (linux_nat_resume_callback): Change type.
7297         (resume_stopped_resumed_lwps, count_events_callback)
7298         (select_event_lwp_callback): Likewise.
7299         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7300         * arm-linux-nat.c (struct update_registers_data): Remove.
7301         (update_registers_callback): Change type.
7302         (arm_linux_insert_hw_breakpoint1): Update.
7303         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7304         parameter.
7305         (x86_linux_dr_set_addr): Update.
7306         (x86_linux_dr_set_control): Update.
7307         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7308         (iterate_over_lwps): Use gdb::function_view.
7309         * nat/aarch64-linux-hw-point.c (struct
7310         aarch64_dr_update_callback_param): Remove.
7311         (debug_reg_change_callback): Change type.
7312         (aarch64_notify_debug_reg_change): Update.
7313         * s390-linux-nat.c (s390_refresh_per_info): Update.
7314
7315 2019-03-11  Tom Tromey  <tromey@adacore.com>
7316
7317         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7318         redundant assignment to "this_cu".
7319
7320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7321
7322         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7323
7324 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7325
7326         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7327         from...
7328         (rank_one_type): ... this.
7329
7330 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7331
7332         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7333         from...
7334         (rank_one_type): ... this.
7335
7336 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7337
7338         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7339         from...
7340         (rank_one_type): ... this.
7341
7342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7343
7344         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7345         from...
7346         (rank_one_type): ... this.
7347
7348 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7349
7350         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7351         from...
7352         (rank_one_type): ... this.
7353
7354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7355
7356         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7357         from...
7358         (rank_one_type): ... this.
7359
7360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7361
7362         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7363         from...
7364         (rank_one_type): ... this.
7365
7366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7367
7368         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7369         from...
7370         (rank_one_type): ... this.
7371
7372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7373
7374         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7375         from...
7376         (rank_one_type): ... this.
7377
7378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7379
7380         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7381         from...
7382         (rank_one_type): ... this.
7383
7384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7385
7386         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7387         from...
7388         (rank_one_type): ... this.
7389
7390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7391
7392         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7393         from...
7394         (rank_one_type): ... this.
7395
7396 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7397
7398         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7399         inferior-events' shows the example events.
7400
7401 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7402
7403         Support styling on native MS-Windows console
7404
7405         PR/24315
7406         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7407         on MS-Windows if $TERM is not defined.
7408
7409         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7410
7411         * posix-hdep.c (gdb_console_fputs):
7412         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7413         functions.
7414         * ui-file.h (gdb_console_fputs): Add prototype.
7415
7416         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7417         back to fputs only if the former returns zero.
7418
7419 2019-03-07  Tom Tromey  <tom@tromey.com>
7420
7421         * symmisc.c (print_symbol_bcache_statistics): Update.
7422         (print_objfile_statistics): Update.
7423         * symfile.c (allocate_symtab): Update.
7424         * stabsread.c: Don't include bcache.h.
7425         * psymtab.h (struct psymbol_bcache): Don't declare.
7426         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7427         (psymbol_bcache_init, psymbol_bcache_free)
7428         (psymbol_bcache_get_bcache): Don't declare.
7429         * psymtab.c (struct psymbol_bcache): Remove.
7430         (psymtab_storage::psymtab_storage): Update.
7431         (psymtab_storage::~psymtab_storage): Update.
7432         (psymbol_bcache_init, psymbol_bcache_free)
7433         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7434         (add_psymbol_to_bcache): Update.
7435         (allocate_psymtab): Update.
7436         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7437         macro_cache>: No longer pointers.
7438         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7439         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7440         * macrotab.c (macro_bcache): Update.
7441         * macroexp.c: Don't include bcache.h.
7442         * gdbtypes.c (check_types_worklist): Update.
7443         (types_deeply_equal): Remove TRY/CATCH.  Update.
7444         * elfread.c (elf_symtab_read): Update.
7445         * dwarf2read.c: Don't include bcache.h.
7446         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7447         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7448         (print_bcache_statistics, bcache_memory_used): Don't declare.
7449         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7450         methods.  Rename all data members.
7451         * bcache.c (struct bcache): Move to bcache.h.
7452         (bcache::expand_hash_table): Rename from expand_hash_table.
7453         (bcache): Remove.
7454         (bcache::insert): Rename from bcache_full.
7455         (bcache::compare): Rename from bcache_compare.
7456         (bcache_xmalloc): Remove.
7457         (bcache::~bcache): Rename from bcache_xfree.
7458         (bcache::print_statistics): Rename from print_bcache_statistics.
7459         (bcache::memory_used): Rename from bcache_memory_used.
7460
7461 2019-03-07  Pedro Alves  <palves@redhat.com>
7462
7463         * infrun.c (normal_stop): Also check for
7464         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7465
7466 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * f-lang.c (value_from_host_double): Moved to...
7469         * value.c (value_from_host_double): ...here.
7470         * value.h (value_from_host_double): Declare.
7471         * guile/scm-math.c (vlscm_convert_typed_number): Use
7472         value_from_host_double.
7473         (vlscm_convert_number): Likewise.
7474         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7475         * python/py-value.c (convert_value_from_python): Likewise.
7476
7477 2019-03-06  Tom Tromey  <tom@tromey.com>
7478
7479         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7480
7481 2019-03-06  Tom Tromey  <tom@tromey.com>
7482
7483         * utils.h (free_current_contents): Don't declare.
7484         * utils.c (free_current_contents): Remove.
7485
7486 2019-03-06  Tom Tromey  <tom@tromey.com>
7487
7488         * top.c (quit_force): Update.
7489         * main.c (captured_command_loop): Update.
7490         * common/new-op.c (operator new): Update.
7491         * common/common-exceptions.c (struct catcher)
7492         <save_cleanup_chain>: Remove member.
7493         (exceptions_state_mc_init): Update.
7494         (exception_try_scope_entry): Return nullptr.
7495         (exception_try_scope_exit, exception_rethrow)
7496         (throw_exception_sjlj, throw_exception_cxx): Update.
7497         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7498         (all_cleanups, do_cleanups, discard_cleanups)
7499         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7500         (restore_cleanups, restore_final_cleanups): Don't declare.
7501         (do_final_cleanups): Remove parameter.
7502         * common/cleanups.c (cleanup_chain, make_cleanup)
7503         (make_cleanup_dtor, all_cleanups, do_cleanups)
7504         (discard_my_cleanups, discard_cleanups)
7505         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7506         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7507         (null_cleanup): Remove.
7508         (do_final_cleanups): Remove parameter.
7509
7510 2019-03-06  Tom Tromey  <tom@tromey.com>
7511
7512         * remote.c (remote_target::remote_parse_stop_reply): Use
7513         unique_xmalloc_ptr.
7514
7515 2019-03-06  Tom Tromey  <tom@tromey.com>
7516
7517         * stabsread.c (struct stabs_field_info): Rename from field_info.
7518         <list, fnlist>: Add initializers.
7519         <obstack>: New member.
7520         (read_member_functions, read_struct_fields, read_baseclasses):
7521         Allocate on obstack.  Don't use cleanups.
7522         (read_one_struct_field, read_member_functions, read_struct_fields)
7523         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7524         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7525         (read_struct_type): Update.
7526
7527 2019-03-06  Tom Tromey  <tom@tromey.com>
7528
7529         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7530         * common/filestuff.h (make_cleanup_close): Don't declare.
7531         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7532         Remove.
7533
7534 2019-03-06  Tom Tromey  <tom@tromey.com>
7535
7536         * solib-aix.c: Use make_scope_exit.
7537
7538 2019-03-06  Tom Tromey  <tom@tromey.com>
7539
7540         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7541         Use make_scope_exit.
7542
7543 2019-03-06  Tom Tromey  <tom@tromey.com>
7544
7545         * solib-svr4.c (disable_probes_interface): Remove parameter.
7546         (svr4_handle_solib_event): Use make_scope_exit.
7547
7548 2019-03-06  Tom Tromey  <tom@tromey.com>
7549
7550         * remote.c (struct stop_reply_deleter): Remove.
7551         (stop_reply_up): Update.
7552         (struct stop_reply): Derive from notif_event.  Don't typedef.
7553         <regcache>: Now a std::vector.
7554         (stop_reply_xfree): Remove.
7555         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7556         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7557         (remote_target::discard_pending_stop_replies): Use delete.
7558         (remote_target::remote_parse_stop_reply): Update.
7559         (remote_target::process_stop_reply): Update.
7560         * remote-notif.h (struct notif_event): Add virtual destructor.
7561         Remove "dtr" member.
7562         (struct notif_client) <alloc_event>: Return a unique_ptr.
7563         (notif_event_xfree): Don't declare.
7564         (notif_event_up): New typedef.
7565         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7566         (notif_event_xfree, do_notif_event_xfree): Remove.
7567         (remote_notif_state_xfree): Update.
7568
7569 2019-03-06  Tom Tromey  <tom@tromey.com>
7570
7571         * infrun.c (displaced_step_clear_cleanup): Now a
7572         forward_scope_exit type.
7573         (displaced_step_prepare_throw): Update.
7574         (displaced_step_fixup): Update.
7575
7576 2019-03-06  Tom Tromey  <tom@tromey.com>
7577
7578         * inferior.h (class inferior): Update comment.
7579         * gdbthread.h (class thread_info): Update comment.
7580
7581 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7582             Tom Tromey  <tom@tromey.com>
7583
7584         * stabsread.h (struct stab_section_list): Remove.
7585         (coffstab_build_psymtabs): Update.
7586         * dbxread.c (symbuf_sections): Now a std::vector.
7587         (sect_idx): New global.
7588         (fill_symbuf): Update.
7589         (coffstab_build_psymtabs): Change type of stabsects parameter.
7590         Update.
7591         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7592         std::vector.
7593         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7594         (coff_locate_sections): Update.
7595         (coff_symfile_read): Remove cleanups.  Update.
7596         (init_stringtab): Add storage parameter.
7597         (free_stringtab, free_stringtab_cleanup): Remove.
7598         (init_lineno): Add storage parameter.
7599         (free_linetab, free_linetab_cleanup): Remove.
7600
7601 2019-03-06  Pedro Alves  <palves@redhat.com>
7602
7603         * linux-fork.c (fork_info::clobber_regs): Delete.
7604         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7605         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7606         comment.  Adjust.
7607         (scoped_switch_fork_info::scoped_switch_fork_info)
7608         (checkpoint_command, linux_fork_context): Adjust
7609         fork_save_infrun_state calls.
7610
7611 2019-03-06  Pedro Alves  <palves@redhat.com>
7612
7613         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7614         (inf_has_multiple_threads): Return 'bool' and rewrite using
7615         inferior_info::threads().
7616
7617 2019-03-06  Pedro Alves  <palves@redhat.com>
7618
7619         * linux-fork.c: Include <list>.
7620         (fork_list): Now a std::list instance.
7621         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7622         (forks_exist_p, find_last_fork): Adjust.
7623         (new_fork): Delete.
7624         (one_fork_p): New.
7625         (add_fork): Adjust.
7626         (free_fork): Delete, folded into fork_info::~fork_info().
7627         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7628         Adjust.
7629         (init_fork_list): Delete.
7630         (linux_fork_killall, linux_fork_mourn_inferior)
7631         (linux_fork_detach, info_checkpoints_command): Adjust.
7632         (_initialize_linux_fork): No longer call init_fork_list.
7633
7634 2019-03-06  Pedro Alves  <palves@redhat.com>
7635
7636         * linux-fork.c (new_fork): New, split out of ...
7637         (add_fork): ... this.  Return void.  Move "first fork" special
7638         case from here, to ...
7639         (checkpoint_command): ... here.
7640         * linux-linux.h (add_fork): Return void.
7641
7642 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7645
7646 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7647             Chris January  <chris.january@arm.com>
7648             David Lecomber  <david.lecomber@arm.com>
7649
7650         * f-exp.y: New token, UNOP_INTRINSIC.
7651         (exp): New pattern using UNOP_INTRINSIC token.
7652         (f77_keywords): Add 'abs' keyword.
7653         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7654         (value_from_host_double): New function.
7655         (evaluate_subexp_f): Support UNOP_ABS.
7656
7657 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7660         types.
7661
7662 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7663
7664         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7665         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7666         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7667
7668 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7671
7672 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7673             Chris January  <chris.january@arm.com>
7674
7675         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7676         * f-exp.y: Define 'KIND' token.
7677         (exp): New pattern for KIND expressions.
7678         (ptype): Handle types with a kind extension.
7679         (direct_abs_decl): Extend to spot kind extensions.
7680         (f77_keywords): Add 'kind' to the list.
7681         (push_kind_type): New function.
7682         (convert_to_kind_type): New function.
7683         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7684         * parse.c (operator_length_standard): Likewise.
7685         * parser-defs.h (enum type_pieces): Add tp_kind.
7686         * std-operator.def: Add UNOP_KIND.
7687
7688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7689
7690         * f-exp.y (f_parse): Set yydebug.
7691
7692 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * f-lang.c (evaluate_subexp_f): New function.
7695         (exp_descriptor_f): New global.
7696         (f_language_defn): Use exp_descriptor_f instead of
7697         exp_descriptor_standard.
7698
7699 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * f-exp.y (struct token): Add comments.
7702         (dot_ops): Remove uppercase versions and the end marker.
7703         (f77_keywords): Likewise.
7704         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7705         entries in the dot_ops array are case insensitive, and use
7706         strncasecmp to compare strings.  Also some whitespace cleanup in
7707         this area.  Similar for the f77_keywords array, except entries in
7708         this list might be case sensitive.
7709
7710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7711
7712         * f-exp.y (struct f77_boolean_val): Add comments.
7713         (boolean_values): Remove uppercase versions, and end marker.
7714         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7715         and use strncasecmp to achieve case insensitivity.  Additionally,
7716         perform whitespace cleanup around this code.
7717
7718 2019-03-06  Tom Tromey  <tromey@adacore.com>
7719
7720         * remote-sim.c (gdbsim_target_open): Use result of
7721         gdb_argv::release.
7722
7723 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7724         Dirk Schubert  <dirk.schubert@arm.com>
7725         Chris January  <chris.january@arm.com>
7726
7727         * eval.c (evaluate_subexp_standard): Call Fortran argument
7728         wrapping logic.
7729         * f-lang.c (struct value): A value which can be passed into a
7730         Fortran function call.
7731         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7732         where appropriate.
7733         (struct type): Value ready for a Fortran function call.
7734         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7735         is needed.
7736         * f-lang.h (fortran_argument_convert): Declaration.
7737         (fortran_preserve_arg_pointer): Declaration.
7738         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7739
7740 2019-03-05  Tom Tromey  <tromey@adacore.com>
7741
7742         * python/py-prettyprint.c (print_string_repr): Remove #if.
7743         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7744
7745 2019-03-05  Tom Tromey  <tromey@adacore.com>
7746
7747         * target.c (the_dummy_target): Move later.  Change type to
7748         "dummy_target".
7749         (initialize_targets): Don't initialize the_dummy_target.
7750
7751 2019-03-05  Tom Tromey  <tromey@adacore.com>
7752
7753         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7754         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7755
7756 2019-03-05  Tom Tromey  <tromey@adacore.com>
7757
7758         * windows-nat.c (windows_nat_target::attach)
7759         (windows_nat_target::detach): Don't call gdb_flush.
7760         * valprint.c (generic_val_print, val_print, val_print_string):
7761         Don't call gdb_flush.
7762         * utils.c (defaulted_query): Don't call gdb_flush.
7763         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7764         * target.c (target_announce_detach): Don't call gdb_flush.
7765         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7766         * remote.c (extended_remote_target::attach): Don't call
7767         gdb_flush.
7768         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7769         * printcmd.c (do_examine): Don't call gdb_flush.
7770         (info_display_command): Don't call gdb_flush.
7771         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7772         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7773         * memattr.c (info_mem_command): Don't call gdb_flush.
7774         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7775         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7776         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7777         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7778         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7779         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7780         (gnu_nat_target::detach): Don't call gdb_flush.
7781         * f-valprint.c (f_val_print): Don't call gdb_flush.
7782         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7783         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7784         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7785         gdb_flush.
7786         * c-valprint.c (c_val_print): Don't call gdb_flush.
7787         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7788
7789 2019-03-05  Tom Tromey  <tromey@adacore.com>
7790
7791         * varobj.c (update_dynamic_varobj_children): Update.
7792         (install_default_visualizer): Use reset, not release.
7793         * value.c (set_internalvar): Update.
7794         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7795         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7796         ATTRIBUTE_UNUSED_RESULT.
7797
7798 2019-03-05  Tom Tromey  <tromey@adacore.com>
7799
7800         * remote.c (class scoped_remote_fd) <release>: Add
7801         ATTRIBUTE_UNUSED_RESULT.
7802
7803 2019-03-05  Tom Tromey  <tromey@adacore.com>
7804
7805         * macroexp.c (struct macro_buffer) <release>: Add
7806         ATTRIBUTE_UNUSED_RESULT.
7807
7808 2019-03-05  Tom Tromey  <tromey@adacore.com>
7809
7810         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7811         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7812         ATTRIBUTE_UNUSED_RESULT.
7813
7814 2019-03-05  Tom Tromey  <tromey@adacore.com>
7815
7816         * common/scoped_fd.h (class scoped_fd) <release>: Add
7817         ATTRIBUTE_UNUSED_RESULT.
7818
7819 2019-03-05  Tom Tromey  <tromey@adacore.com>
7820
7821         * parser-defs.h (struct parser_state) <release>: Add
7822         ATTRIBUTE_UNUSED_RESULT.
7823
7824 2019-03-05  Tom Tromey  <tromey@adacore.com>
7825
7826         * utils.h (class gdb_argv) <release>: Add
7827         ATTRIBUTE_UNUSED_RESULT.
7828         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7829
7830 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7831
7832         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7833         for-loop range, to avoid compiler warnings.
7834
7835         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7836         avoid compiler warnings about unused variables.
7837
7838         * NEWS: Mention end of support for native debugging on MS-Windows
7839         before XP.
7840
7841         PR gdb/24292
7842         * common/netstuff.c:
7843         * gdbserver/gdbreplay.c
7844         * gdbserver/remote-utils.c:
7845         * ser-tcp.c:
7846         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7847         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7848         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7849         'getaddrinfo' and 'freeaddrinfo' were not available before
7850         Windows XP, and mingw.org's MinGW headers by default define
7851         _WIN32_WINNT to 0x500.
7852
7853 2019-03-01  Gary Benson <gbenson@redhat.com>
7854
7855         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7856
7857 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7858             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7859
7860         PR gdb/8527
7861         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7862         set_sigint_trap, clear_sigint_trap.
7863
7864 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7865
7866         * target.c (target_detach): Clear the regcache and the
7867         frame cache.
7868
7869 2019-02-27  Pedro Alves  <palves@redhat.com>
7870
7871         * utils.c (set_screen_size): When we cap the height/width sizes,
7872         tweak the corresponding command variable to show "unlimited":
7873
7874 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7875             Pedro Alves  <palves@redhat.com>
7876
7877         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7878         before calling rl_set_screen_size.
7879
7880 2019-02-27  Tom Tromey  <tromey@adacore.com>
7881
7882         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7883         define.
7884         * python/py-value.c: Remove Python 2.4 workaround.
7885         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7886         workaround.
7887         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7888         Python 2.4 workaround.
7889         * python/python-internal.h: Remove Python 2.4 comment.
7890         (Py_ssize_t): Don't define.
7891         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7892         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7893         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7894         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7895         * python/python.c (do_start_initialization): Remove Python 2.4
7896         workaround.
7897         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7898         (print_children): Remove Python 2.4 workaround.
7899         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7900         workaround.
7901         (CHARBUFFERPROC_NAME): Remove.
7902         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7903         Python 2.4 workaround.
7904
7905 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7906
7907         * NEWS: Note minimum Python version.
7908
7909 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7910
7911         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7912         code from these functions.  Remove corresponding ifdefs.  Use
7913         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7914         Remove gotos and target of gotos.
7915         (infpy_search_memory): Likewise.
7916
7917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7918
7919         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7920         (hppa_gdbarch_init): Don't register deleted functions with
7921         gdbarch.
7922
7923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7924
7925         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7926         (h8300_unwind_sp): Delete.
7927         (h8300_dummy_id): Delete.
7928         (h8300_gdbarch_init): Don't register deleted functions with
7929         gdbarch.
7930
7931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7932
7933         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7934         (ft32_unwind_pc): Delete.
7935         (ft32_unwind_sp): Delete.
7936         (ft32_gdbarch_init): Don't register deleted functions with
7937         gdbarch.
7938
7939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7940
7941         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7942         (frv_unwind_pc): Delete.
7943         (frv_unwind_sp): Delete.
7944         (frv_gdbarch_init): Don't register deleted functions with
7945         gdbarch.
7946
7947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7948
7949         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7950         (riscv_unwind_pc): Delete.
7951         (riscv_unwind_sp): Delete.
7952         (riscv_gdbarch_init): Don't register deleted functions with
7953         gdbarch.
7954
7955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7956
7957         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7958         (csky_unwind_pc): Delete.
7959         (csky_unwind_sp): Delete.
7960         (csky_gdbarch_init): Don't register deleted functions with
7961         gdbarch.
7962
7963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7966         (cris_unwind_pc): Delete.
7967         (cris_unwind_sp): Delete.
7968         (cris_gdbarch_init): Don't register deleted functions with
7969         gdbarch.
7970
7971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7974         (bfin_unwind_pc): Delete.
7975         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7976
7977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7978
7979         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7980         (arm_unwind_pc): Delete.
7981         (arm_unwind_sp): Delete.
7982         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7983
7984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7987         (arc_unwind_pc): Delete.
7988         (arc_unwind_sp): Delete.
7989         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7990
7991 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7994         (alpha_unwind_pc): Delete.
7995         (alpha_gdbarch_init): Don't register deleted functions with
7996         gdbarch.
7997
7998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7999
8000         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8001         (aarch64_unwind_pc): Delete.
8002         (aarch64_unwind_sp): Delete.
8003         (aarch64_gdbarch_init): Don't register deleted functions with
8004         gdbarch.
8005
8006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8007
8008         * gdbtypes.c (type_align): Don't consider static members when
8009         computing structure alignment.
8010
8011 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8012
8013         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8014         return 0 for other types.
8015         * arch-utils.c (default_type_align): Always return 0.
8016         * gdbarch.h: Regenerate.
8017         * gdbarch.sh (type_align): Extend comment.
8018         * gdbtypes.c (type_align): Add additional comments, always call
8019         gdbarch_type_align before applying the default rules.
8020         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8021         generic code will then apply a suitable default.
8022         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8023         types, return 0 for other types.
8024
8025 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8026
8027         * NEWS: Create a new section for the next release branch.
8028         Rename the section of the current branch, now that it has
8029         been cut.
8030
8031 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8032
8033         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8034         * version.in: Bump version to 8.3.50.DATE-git.
8035
8036 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8037
8038         * aix-thread.c (ptid_cmp): Remove unused variable.
8039         (get_signaled_thread): Likewise.
8040         (store_regs_user_thread): Likewise.
8041         (store_regs_kernel_thread): Likewise.
8042         (fetch_regs_kernel_thread): Remove shadowed variable.
8043
8044 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * features/riscv/32bit-cpu.xml: Add register numbers.
8047         * features/riscv/32bit-fpu.c: Regenerate.
8048         * features/riscv/32bit-fpu.xml: Add register numbers.
8049         * features/riscv/64bit-cpu.xml: Add register numbers.
8050         * features/riscv/64bit-fpu.c: Regenerate.
8051         * features/riscv/64bit-fpu.xml: Add register numbers.
8052
8053 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8054
8055         * NEWS: Mention two argument form of gdb.Value constructor.
8056         * python/py-value.c (convert_buffer_and_type_to_value): New
8057         function.
8058         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8059         Add support for handling an optional second argument.  Call
8060         convert_buffer_and_type_to_value as appropriate.
8061         * python/python-internal.h (Py_buffer_deleter): New struct.
8062         (Py_buffer_up): New typedef.
8063
8064 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8065
8066         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8067         instead of releasing ownership.
8068
8069 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8070
8071         * dwarf2read.c (open_and_init_dwp_file): Call
8072         elf_numsections instead of bfd_count_sections to initialize
8073         dwp_file->num_sections.
8074
8075 2019-02-25  Tom Tromey  <tromey@adacore.com>
8076
8077         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8078
8079 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8080
8081         * gcore.in: Add '--readnever' option when invoking GDB.
8082
8083 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8084
8085         * MAINTAINERS: Update my email address.
8086
8087 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8088
8089         * build-id.c (build_id_to_debug_bfd_1): New function.
8090         (build_id_to_debug_bfd): Look for separate debug file in
8091         sysroot.
8092
8093 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * gdbarch.sh: Update the copyright year range that is placed into
8096         generated files.
8097
8098 2019-02-22  Keith Seitz  <keiths@redhat.com>
8099
8100         PR symtab/23853
8101         * linespec.c (create_sals_line_offset): Search for the default
8102         symtab's filename instead of its fullname.
8103
8104 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8105
8106         * NEWS: Update style defaults.
8107
8108 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8109
8110         * main.c (captured_main_1): Disable styling in batch mode.
8111
8112 2019-02-20  Tom Tromey  <tom@tromey.com>
8113
8114         * symtab.c (symtab_symbol_info): Fix typos.
8115
8116 2019-02-20  Tom Tromey  <tromey@adacore.com>
8117
8118         * findcmd.c (_initialize_mem_search): Use upper case for
8119         metasyntactic variables.
8120
8121 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8122
8123         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8124         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8125
8126 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8127
8128         * top.h (source_file_name): Change to std::string.
8129         * top.c (source_file_name): Likewise.
8130         (command_line_input): Adjust.
8131         * cli/cli-script.c (script_from_file): Adjust.
8132
8133 2019-02-19  Tom Tromey  <tromey@adacore.com>
8134
8135         * ravenscar-thread.c
8136         (ravenscar_thread_target::update_thread_list): Don't call
8137         ada_build_task_list.
8138         * ada-lang.h (ada_build_task_list): Don't declare.
8139         * ada-tasks.c (struct ada_tasks_inferior_data)
8140         <task_list_valid_p>: Now bool.
8141         (read_known_tasks, ada_task_list_changed)
8142         (ada_tasks_invalidate_inferior_data): Update.
8143         (read_known_tasks_array): Return bool.
8144         (read_known_tasks_list): Likewise.
8145         (read_known_tasks): Return void.
8146         (ada_build_task_list): Now static.
8147
8148 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8149
8150         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8151         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8152
8153 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8154
8155         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8156         variant for ada_tasks_pspace_data_handle and
8157         ada_tasks_inferior_data_handle.
8158         (ada_tasks_pspace_data_cleanup): New function.
8159         (ada_tasks_inferior_data_cleanup): New function.
8160
8161 2019-02-17  Tom Tromey  <tom@tromey.com>
8162
8163         * macrotab.h (macro_source_fullname): Return a std::string.
8164         * macrotab.c (macro_include, check_for_redefinition)
8165         (macro_undef, macro_lookup_definition, foreach_macro)
8166         (foreach_macro_in_scope): Update.
8167         (macro_source_fullname): Return a std::string.
8168         * macrocmd.c (show_pp_source_pos): Update.
8169
8170 2019-02-17  Tom Tromey  <tom@tromey.com>
8171
8172         * macrocmd.c (show_pp_source_pos): Style the file names.
8173
8174 2019-02-17  Tom Tromey  <tom@tromey.com>
8175
8176         PR tui/24197:
8177         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8178
8179 2019-02-17  Tom Tromey  <tom@tromey.com>
8180
8181         * ada-lang.c (user_select_syms): Use filtered printing.
8182         * utils.c (wrap_style): New global.
8183         (desired_style): Remove.
8184         (emit_style_escape): Add stream parameter.
8185         (set_output_style, reset_terminal_style, prompt_for_continue):
8186         Update.
8187         (flush_wrap_buffer): Only flush gdb_stdout.
8188         (wrap_here): Set wrap_style.
8189         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8190         treat escape sequences as a character.  Change when wrap buffer is
8191         flushed.
8192         (fputs_styled): Do not set the output style when the default is
8193         requested.
8194         * ui-style.h (struct ui_file_style) <is_default>: New method.
8195         * source.c (print_source_lines_base): Emit escape sequences in one
8196         piece.
8197
8198 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8199
8200         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8201         integers and enumeration types.
8202
8203 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8204
8205         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8206         instead of lookup_symbol_in_language
8207         (do_exact_match): New function.
8208         (ada_get_symbol_name_matcher): Return do_exact_match when
8209         doing a verbatim match.
8210
8211 2019-02-15  Tom Tromey  <tromey@adacore.com>
8212
8213         * ravenscar-thread.c (ravenscar_thread_target::resume)
8214         (ravenscar_thread_target::wait): Special case wildcard requests.
8215
8216 2019-02-15  Tom Tromey  <tromey@adacore.com>
8217
8218         * ravenscar-thread.c (base_ptid): Remove.
8219         (struct ravenscar_thread_target) <close>: New method.
8220         <m_base_ptid>: New member.
8221         <update_inferior_ptid, active_task, task_is_currently_active,
8222         runtime_initialized>: Declare methods.
8223         <ravenscar_thread_target>: Add constructor.
8224         (ravenscar_thread_target::task_is_currently_active)
8225         (ravenscar_thread_target::update_inferior_ptid)
8226         (ravenscar_runtime_initialized): Rename.  Now methods.
8227         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8228         (ravenscar_thread_target::update_thread_list): Update.
8229         (ravenscar_thread_target::active_task): Now method.
8230         (ravenscar_thread_target::store_registers)
8231         (ravenscar_thread_target::prepare_to_store)
8232         (ravenscar_thread_target::prepare_to_store)
8233         (ravenscar_thread_target::mourn_inferior): Update.
8234         (ravenscar_inferior_created): Use "new" to create target.
8235         (ravenscar_thread_target::get_ada_task_ptid): Update.
8236         (_initialize_ravenscar): Don't initialize base_ptid.
8237         (ravenscar_ops): Remove global.
8238
8239 2019-02-15  Tom Tromey  <tromey@adacore.com>
8240
8241         * target.h (push_target): Declare new overload.
8242         * target.c (push_target): New overload, taking an rvalue reference.
8243         * remote.c (remote_target::open_1): Use push_target overload.
8244         * corelow.c (core_target_open): Use push_target overload.
8245
8246 2019-02-15  Tom Tromey  <tromey@adacore.com>
8247
8248         * ravenscar-thread.c (is_ravenscar_task)
8249         (ravenscar_task_is_currently_active): Return bool.
8250         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8251         (_initialize_ravenscar): Remove "(void)".
8252         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8253         Return bool.
8254
8255 2019-02-15  Tom Tromey  <tromey@adacore.com>
8256
8257         * ravenscar-thread.c (ravenscar_runtime_initializer)
8258         (has_ravenscar_runtime, get_running_thread_id)
8259         (ravenscar_thread_target::resume): Fix indentation.
8260
8261 2019-02-15  Tom Tromey  <tromey@adacore.com>
8262
8263         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8264         from ravenscar_arch_ops.
8265         (sparc_ravenscar_ops::fetch_registers)
8266         (sparc_ravenscar_ops::store_registers): Now methods.
8267         (sparc_ravenscar_prepare_to_store): Remove.
8268         (sparc_ravenscar_ops): Redefine.
8269         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8270         methods and destructor.  Remove members.
8271         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8272         (ravenscar_thread_target::store_registers)
8273         (ravenscar_thread_target::prepare_to_store): Update.
8274         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8275         Remove.
8276         (struct ppc_ravenscar_powerpc_ops): Derive from
8277         ravenscar_arch_ops.
8278         (ppc_ravenscar_powerpc_ops::fetch_registers)
8279         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8280         (ppc_ravenscar_powerpc_ops): Redefine.
8281         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8282         (ppc_ravenscar_e500_ops::fetch_registers)
8283         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8284         (ppc_ravenscar_e500_ops): Redefine.
8285         * aarch64-ravenscar-thread.c
8286         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8287         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8288         (aarch64_ravenscar_fetch_registers)
8289         (aarch64_ravenscar_store_registers): Now methods.
8290         (aarch64_ravenscar_ops): Redefine.
8291
8292 2019-02-15  Tom Tromey  <tromey@adacore.com>
8293
8294         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8295         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8296         (ravenscar_thread_target::stopped_by_watchpoint)
8297         (ravenscar_thread_target::stopped_data_address)
8298         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8299
8300 2019-02-15  Tom Tromey  <tromey@adacore.com>
8301
8302         * ravenscar-thread.c: Fix some typos.
8303
8304 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8305             Tom Tromey  <tromey@adacore.com>
8306
8307         * ada-lang.c (ada_exception_sal): Change addr_string to a
8308         std::string.
8309         (create_ada_exception_catchpoint): Update.
8310
8311 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8312             Tom Tromey  <tromey@adacore.com>
8313
8314         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8315         (bp_location_ops): Remove.
8316         (base_breakpoint_allocate_location): Update.
8317         (free_bp_location): Update.
8318         * ada-lang.c (class ada_catchpoint_location)
8319         <ada_catchpoint_location>: Remove ops parameter.
8320         (ada_catchpoint_location_dtor): Remove.
8321         (ada_catchpoint_location_ops): Remove.
8322         (allocate_location_exception): Update.
8323         * breakpoint.h (struct bp_location_ops): Remove.
8324         (class bp_location) <bp_location>: Remove bp_location_ops
8325         parameter.
8326         <~bp_location>: Add destructor.
8327         <ops>: Remove.
8328
8329 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8330             Pedro Alves  <palves@redhat.com>
8331
8332         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8333         'PATH_MAX'.
8334
8335 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8336             Samuel Thibault  <samuel.thibault@gnu.org>
8337             Thomas Schwinge  <thomas@codesourcery.com>
8338
8339         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8340         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8341
8342 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8343
8344         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8345         (check_empty): Use "const char *".
8346
8347         * gnu-nat.c (gnu_nat_target::detach): Instead of
8348         'detach_inferior (pid)' call
8349         'detach_inferior (find_inferior_pid (pid))'.
8350
8351         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8352         'nat/fork-inferior.o'.
8353         * gnu-nat.c: #include "nat/fork-inferior.h".
8354
8355         * gnu-nat.c (gnu_nat_target::detach): Instead of
8356         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8357         * gnu-nat.h: #include "inf-child.h".
8358         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8359         'i386_gnu_nat_target::fetch_registers'.
8360         (gnu_store_registers): Rename/move to
8361         'i386_gnu_nat_target::store_registers'.
8362
8363         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8364         * gnu-nat.h (mach_thread_info): New function.
8365         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8366
8367         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8368
8369 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8370
8371         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8372
8373 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8374
8375         * windows-nat.c (windows_add_thread): Add new parameter
8376         "main_thread_p" with default value set to false.  Update
8377         function documentation as well as all callers.
8378         (windows_delete_thread): Likewise.
8379         (fake_create_process): Update call to windows_add_thread.
8380         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8381         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8382         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8383         call to windows_delete_thread.
8384
8385 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8386
8387         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8388
8389 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8390
8391         * symfile.c (find_separate_debug_file): Use canonical path of
8392         sysroot with child_path instead of gdb_sysroot if it is valid.
8393
8394 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8395
8396         * symfile.c (find_separate_debug_file): Use child_path to
8397         determine if an object file is under a sysroot.
8398
8399 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8400
8401         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8402         unittests/child-path-selftests.c.
8403         * common/pathstuff.c (child_path): New function.
8404         * common/pathstuff.h (child_path): New prototype.
8405         * unittests/child-path-selftests.c: New file.
8406
8407 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8408
8409         * symfile.c (find_separate_debug_file): Look for separate debug
8410         files in debug directories under the sysroot.
8411
8412 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8413
8414         * symtab.h (struct minimal_symbol data_p): New const method.
8415         (struct minimal_symbol text_p): Likewise.
8416         * symtab.c (output_source_filename): Use file name style
8417         to print file name.
8418         (print_symbol_info): Likewise.
8419         (print_msymbol_info): Use address style to print addresses.
8420         Use function name style to print executable text symbols.
8421         (expand_symtab_containing_pc): Use data_p.
8422         (find_pc_sect_compunit_symtab): Likewise.
8423
8424 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8425
8426         * breakpoint.c (describe_other_breakpoints): Use address style
8427         to print addresses.
8428         (say_where): Likewise.
8429
8430 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8431
8432         * ada-typeprint.c (print_func_type): Print function name
8433         style to print function name.
8434         * c-typeprint.c (c_print_type_1): Likewise.
8435
8436 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8437
8438         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8439         for execve.
8440
8441 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8442
8443         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8444         type_stack.
8445
8446 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8447
8448         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8449         TYPE_CODE_REF types.
8450
8451 2019-02-08  Jim Wilson  <jimw@sifive.com>
8452
8453         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8454         (riscv_linux_fregset): New.
8455         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8456
8457 2019-02-07  Tom Tromey  <tom@tromey.com>
8458
8459         * thread.c (thread_cancel_execution_command): Update.
8460         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8461         methods.
8462         (struct thread_fsm_ops): Remove.
8463         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8464         (thread_fsm_should_stop, thread_fsm_return_value)
8465         (thread_fsm_set_finished, thread_fsm_finished_p)
8466         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8467         Don't declare.
8468         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8469         * infrun.c (clear_proceed_status_thread)
8470         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8471         (print_stop_event): Update.
8472         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8473         Add constructor.
8474         (step_command_fsm_ops): Remove.
8475         (new_step_command_fsm): Remove.
8476         (step_1): Update.
8477         (step_command_fsm::should_stop): Rename from
8478         step_command_fsm_should_stop.
8479         (step_command_fsm::clean_up): Rename from
8480         step_command_fsm_clean_up.
8481         (step_command_fsm::do_async_reply_reason): Rename from
8482         step_command_fsm_async_reply_reason.
8483         (struct until_next_fsm): Inherit from thread_fsm.  Add
8484         constructor.
8485         (until_next_fsm_ops): Remove.
8486         (new_until_next_fsm): Remove.
8487         (until_next_fsm::should_stop): Rename from
8488         until_next_fsm_should_stop.
8489         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8490         (until_next_fsm::do_async_reply_reason): Rename from
8491         until_next_fsm_async_reply_reason.
8492         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8493         constructor.  Change type of breakpoint.
8494         (finish_command_fsm_ops): Remove.
8495         (new_finish_command_fsm): Remove.
8496         (finish_command_fsm::should_stop): Rename from
8497         finish_command_fsm_should_stop.
8498         (finish_command_fsm::clean_up): Rename from
8499         finish_command_fsm_clean_up.
8500         (finish_command_fsm::return_value): Rename from
8501         finish_command_fsm_return_value.
8502         (finish_command_fsm::do_async_reply_reason): Rename from
8503         finish_command_fsm_async_reply_reason.
8504         (finish_command): Update.
8505         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8506         Add constructor.
8507         (call_thread_fsm_ops): Remove.
8508         (call_thread_fsm::call_thread_fsm): Rename from
8509         new_call_thread_fsm.
8510         (call_thread_fsm::should_stop): Rename from
8511         call_thread_fsm_should_stop.
8512         (call_thread_fsm::should_notify_stop): Rename from
8513         call_thread_fsm_should_notify_stop.
8514         (run_inferior_call, call_function_by_hand_dummy): Update.
8515         * cli/cli-interp.c (should_print_stop_to_console): Update.
8516         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8517         Add constructor.  Change type of location_breakpoint,
8518         caller_breakpoint.
8519         (until_break_fsm_ops): Remove.
8520         (new_until_break_fsm): Remove.
8521         (until_break_fsm::should_stop): Rename from
8522         until_break_fsm_should_stop.
8523         (until_break_fsm::clean_up): Rename from
8524         until_break_fsm_clean_up.
8525         (until_break_fsm::do_async_reply_reason): Rename from
8526         until_break_fsm_async_reply_reason.
8527         (until_break_command): Update.
8528         * thread-fsm.c: Remove.
8529         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8530
8531 2019-02-07  Tom Tromey  <tom@tromey.com>
8532
8533         * yy-remap.h: Add include guard.
8534         * xtensa-tdep.h: Add include guard.
8535         * xcoffread.h: Rename include guard.
8536         * varobj-iter.h: Add include guard.
8537         * tui/tui.h: Rename include guard.
8538         * tui/tui-winsource.h: Rename include guard.
8539         * tui/tui-wingeneral.h: Rename include guard.
8540         * tui/tui-windata.h: Rename include guard.
8541         * tui/tui-win.h: Rename include guard.
8542         * tui/tui-stack.h: Rename include guard.
8543         * tui/tui-source.h: Rename include guard.
8544         * tui/tui-regs.h: Rename include guard.
8545         * tui/tui-out.h: Rename include guard.
8546         * tui/tui-layout.h: Rename include guard.
8547         * tui/tui-io.h: Rename include guard.
8548         * tui/tui-hooks.h: Rename include guard.
8549         * tui/tui-file.h: Rename include guard.
8550         * tui/tui-disasm.h: Rename include guard.
8551         * tui/tui-data.h: Rename include guard.
8552         * tui/tui-command.h: Rename include guard.
8553         * tic6x-tdep.h: Add include guard.
8554         * target/waitstatus.h: Rename include guard.
8555         * target/wait.h: Rename include guard.
8556         * target/target.h: Rename include guard.
8557         * target/resume.h: Rename include guard.
8558         * target-float.h: Rename include guard.
8559         * stabsread.h: Add include guard.
8560         * rs6000-tdep.h: Add include guard.
8561         * riscv-fbsd-tdep.h: Add include guard.
8562         * regformats/regdef.h: Rename include guard.
8563         * record.h: Rename include guard.
8564         * python/python.h: Rename include guard.
8565         * python/python-internal.h: Rename include guard.
8566         * python/py-stopevent.h: Rename include guard.
8567         * python/py-ref.h: Rename include guard.
8568         * python/py-record.h: Rename include guard.
8569         * python/py-record-full.h: Rename include guard.
8570         * python/py-record-btrace.h: Rename include guard.
8571         * python/py-instruction.h: Rename include guard.
8572         * python/py-events.h: Rename include guard.
8573         * python/py-event.h: Rename include guard.
8574         * procfs.h: Add include guard.
8575         * proc-utils.h: Add include guard.
8576         * p-lang.h: Add include guard.
8577         * or1k-tdep.h: Rename include guard.
8578         * observable.h: Rename include guard.
8579         * nto-tdep.h: Rename include guard.
8580         * nat/x86-linux.h: Rename include guard.
8581         * nat/x86-linux-dregs.h: Rename include guard.
8582         * nat/x86-gcc-cpuid.h: Add include guard.
8583         * nat/x86-dregs.h: Rename include guard.
8584         * nat/x86-cpuid.h: Rename include guard.
8585         * nat/ppc-linux.h: Rename include guard.
8586         * nat/mips-linux-watch.h: Rename include guard.
8587         * nat/linux-waitpid.h: Rename include guard.
8588         * nat/linux-ptrace.h: Rename include guard.
8589         * nat/linux-procfs.h: Rename include guard.
8590         * nat/linux-osdata.h: Rename include guard.
8591         * nat/linux-nat.h: Rename include guard.
8592         * nat/linux-namespaces.h: Rename include guard.
8593         * nat/linux-btrace.h: Rename include guard.
8594         * nat/glibc_thread_db.h: Rename include guard.
8595         * nat/gdb_thread_db.h: Rename include guard.
8596         * nat/gdb_ptrace.h: Rename include guard.
8597         * nat/fork-inferior.h: Rename include guard.
8598         * nat/amd64-linux-siginfo.h: Rename include guard.
8599         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8600         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8601         * nat/aarch64-linux.h: Rename include guard.
8602         * nat/aarch64-linux-hw-point.h: Rename include guard.
8603         * mn10300-tdep.h: Add include guard.
8604         * mips-linux-tdep.h: Add include guard.
8605         * mi/mi-parse.h: Rename include guard.
8606         * mi/mi-out.h: Rename include guard.
8607         * mi/mi-main.h: Rename include guard.
8608         * mi/mi-interp.h: Rename include guard.
8609         * mi/mi-getopt.h: Rename include guard.
8610         * mi/mi-console.h: Rename include guard.
8611         * mi/mi-common.h: Rename include guard.
8612         * mi/mi-cmds.h: Rename include guard.
8613         * mi/mi-cmd-break.h: Rename include guard.
8614         * m2-lang.h: Add include guard.
8615         * location.h: Rename include guard.
8616         * linux-record.h: Rename include guard.
8617         * linux-nat.h: Add include guard.
8618         * linux-fork.h: Add include guard.
8619         * i386-darwin-tdep.h: Rename include guard.
8620         * hppa-linux-offsets.h: Add include guard.
8621         * guile/guile.h: Rename include guard.
8622         * guile/guile-internal.h: Rename include guard.
8623         * gnu-nat.h: Rename include guard.
8624         * gdb-stabs.h: Rename include guard.
8625         * frv-tdep.h: Add include guard.
8626         * f-lang.h: Add include guard.
8627         * event-loop.h: Add include guard.
8628         * darwin-nat.h: Rename include guard.
8629         * cp-abi.h: Rename include guard.
8630         * config/sparc/nm-sol2.h: Rename include guard.
8631         * config/nm-nto.h: Rename include guard.
8632         * config/nm-linux.h: Add include guard.
8633         * config/i386/nm-i386gnu.h: Rename include guard.
8634         * config/djgpp/nl_types.h: Rename include guard.
8635         * config/djgpp/langinfo.h: Rename include guard.
8636         * compile/gcc-cp-plugin.h: Add include guard.
8637         * compile/gcc-c-plugin.h: Add include guard.
8638         * compile/compile.h: Rename include guard.
8639         * compile/compile-object-run.h: Rename include guard.
8640         * compile/compile-object-load.h: Rename include guard.
8641         * compile/compile-internal.h: Rename include guard.
8642         * compile/compile-cplus.h: Rename include guard.
8643         * compile/compile-c.h: Rename include guard.
8644         * common/xml-utils.h: Rename include guard.
8645         * common/x86-xstate.h: Rename include guard.
8646         * common/version.h: Rename include guard.
8647         * common/vec.h: Rename include guard.
8648         * common/tdesc.h: Rename include guard.
8649         * common/selftest.h: Rename include guard.
8650         * common/scoped_restore.h: Rename include guard.
8651         * common/scoped_mmap.h: Rename include guard.
8652         * common/scoped_fd.h: Rename include guard.
8653         * common/safe-iterator.h: Rename include guard.
8654         * common/run-time-clock.h: Rename include guard.
8655         * common/refcounted-object.h: Rename include guard.
8656         * common/queue.h: Rename include guard.
8657         * common/ptid.h: Rename include guard.
8658         * common/print-utils.h: Rename include guard.
8659         * common/preprocessor.h: Rename include guard.
8660         * common/pathstuff.h: Rename include guard.
8661         * common/observable.h: Rename include guard.
8662         * common/netstuff.h: Rename include guard.
8663         * common/job-control.h: Rename include guard.
8664         * common/host-defs.h: Rename include guard.
8665         * common/gdb_wait.h: Rename include guard.
8666         * common/gdb_vecs.h: Rename include guard.
8667         * common/gdb_unlinker.h: Rename include guard.
8668         * common/gdb_unique_ptr.h: Rename include guard.
8669         * common/gdb_tilde_expand.h: Rename include guard.
8670         * common/gdb_sys_time.h: Rename include guard.
8671         * common/gdb_string_view.h: Rename include guard.
8672         * common/gdb_splay_tree.h: Rename include guard.
8673         * common/gdb_setjmp.h: Rename include guard.
8674         * common/gdb_ref_ptr.h: Rename include guard.
8675         * common/gdb_optional.h: Rename include guard.
8676         * common/gdb_locale.h: Rename include guard.
8677         * common/gdb_assert.h: Rename include guard.
8678         * common/filtered-iterator.h: Rename include guard.
8679         * common/filestuff.h: Rename include guard.
8680         * common/fileio.h: Rename include guard.
8681         * common/environ.h: Rename include guard.
8682         * common/common-utils.h: Rename include guard.
8683         * common/common-types.h: Rename include guard.
8684         * common/common-regcache.h: Rename include guard.
8685         * common/common-inferior.h: Rename include guard.
8686         * common/common-gdbthread.h: Rename include guard.
8687         * common/common-exceptions.h: Rename include guard.
8688         * common/common-defs.h: Rename include guard.
8689         * common/common-debug.h: Rename include guard.
8690         * common/cleanups.h: Rename include guard.
8691         * common/buffer.h: Rename include guard.
8692         * common/btrace-common.h: Rename include guard.
8693         * common/break-common.h: Rename include guard.
8694         * cli/cli-utils.h: Rename include guard.
8695         * cli/cli-style.h: Rename include guard.
8696         * cli/cli-setshow.h: Rename include guard.
8697         * cli/cli-script.h: Rename include guard.
8698         * cli/cli-interp.h: Rename include guard.
8699         * cli/cli-decode.h: Rename include guard.
8700         * cli/cli-cmds.h: Rename include guard.
8701         * charset-list.h: Add include guard.
8702         * buildsym-legacy.h: Rename include guard.
8703         * bfin-tdep.h: Add include guard.
8704         * ax.h: Rename include guard.
8705         * arm-linux-tdep.h: Add include guard.
8706         * arm-fbsd-tdep.h: Add include guard.
8707         * arch/xtensa.h: Rename include guard.
8708         * arch/tic6x.h: Add include guard.
8709         * arch/i386.h: Add include guard.
8710         * arch/arm.h: Rename include guard.
8711         * arch/arm-linux.h: Rename include guard.
8712         * arch/arm-get-next-pcs.h: Rename include guard.
8713         * arch/amd64.h: Add include guard.
8714         * arch/aarch64-insn.h: Rename include guard.
8715         * arch-utils.h: Rename include guard.
8716         * annotate.h: Add include guard.
8717         * amd64-darwin-tdep.h: Rename include guard.
8718         * aarch64-linux-tdep.h: Add include guard.
8719         * aarch64-fbsd-tdep.h: Add include guard.
8720         * aarch32-linux-nat.h: Add include guard.
8721
8722 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8723
8724         * macrotab.c (macro_define_internal): New function that
8725         factorizes macro_define_object_internal and macro_define_function
8726         code.
8727         (macro_define_object_internal): Use macro_define_internal.
8728         (macro_define_function): Likewise.
8729
8730 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8731
8732         * macrocmd.c (extract_identifier): Return
8733         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8734         callers.
8735
8736 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8737
8738         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8739
8740 2019-02-05  Tom Tromey  <tom@tromey.com>
8741
8742         * target.c (target_stack::unpush): Move assertion earlier.
8743
8744 2019-01-30  Tom Tromey  <tom@tromey.com>
8745
8746         PR python/23615:
8747         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8748         (gdbpy_parse_and_eval): Likewise.
8749         * python/python-internal.h (gdbpy_allow_threads): New class.
8750
8751 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8752
8753         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8754         (aarch64_fbsd_fpregmap): Move earlier.
8755         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8756         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8757         instead of individual calls to trad_frame_set_reg_addr.
8758         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8759         earlier.
8760         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8761         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8762         instead of individual calls to trad_frame_set_reg_addr.
8763
8764 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8765
8766         * CONTRIBUTE: Replace contribution list with wiki link.
8767
8768 2019-01-25  Tom Tromey  <tom@tromey.com>
8769
8770         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8771
8772 2019-01-25  Tom Tromey  <tom@tromey.com>
8773
8774         * xtensa-linux-nat.c: Fix common/ includes.
8775         * xml-support.h: Fix common/ includes.
8776         * xml-support.c: Fix common/ includes.
8777         * x86-linux-nat.c: Fix common/ includes.
8778         * windows-nat.c: Fix common/ includes.
8779         * varobj.h: Fix common/ includes.
8780         * varobj.c: Fix common/ includes.
8781         * value.c: Fix common/ includes.
8782         * valops.c: Fix common/ includes.
8783         * utils.c: Fix common/ includes.
8784         * unittests/xml-utils-selftests.c: Fix common/ includes.
8785         * unittests/utils-selftests.c: Fix common/ includes.
8786         * unittests/unpack-selftests.c: Fix common/ includes.
8787         * unittests/tracepoint-selftests.c: Fix common/ includes.
8788         * unittests/style-selftests.c: Fix common/ includes.
8789         * unittests/string_view-selftests.c: Fix common/ includes.
8790         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8791         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8792         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8793         * unittests/rsp-low-selftests.c: Fix common/ includes.
8794         * unittests/parse-connection-spec-selftests.c: Fix common/
8795         includes.
8796         * unittests/optional-selftests.c: Fix common/ includes.
8797         * unittests/offset-type-selftests.c: Fix common/ includes.
8798         * unittests/observable-selftests.c: Fix common/ includes.
8799         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8800         * unittests/memrange-selftests.c: Fix common/ includes.
8801         * unittests/memory-map-selftests.c: Fix common/ includes.
8802         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8803         * unittests/function-view-selftests.c: Fix common/ includes.
8804         * unittests/environ-selftests.c: Fix common/ includes.
8805         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8806         * unittests/common-utils-selftests.c: Fix common/ includes.
8807         * unittests/cli-utils-selftests.c: Fix common/ includes.
8808         * unittests/array-view-selftests.c: Fix common/ includes.
8809         * ui-file.c: Fix common/ includes.
8810         * tui/tui-io.c: Fix common/ includes.
8811         * tracepoint.h: Fix common/ includes.
8812         * tracepoint.c: Fix common/ includes.
8813         * tracefile-tfile.c: Fix common/ includes.
8814         * top.h: Fix common/ includes.
8815         * top.c: Fix common/ includes.
8816         * thread.c: Fix common/ includes.
8817         * target/waitstatus.h: Fix common/ includes.
8818         * target/waitstatus.c: Fix common/ includes.
8819         * target.h: Fix common/ includes.
8820         * target.c: Fix common/ includes.
8821         * target-memory.c: Fix common/ includes.
8822         * target-descriptions.c: Fix common/ includes.
8823         * symtab.h: Fix common/ includes.
8824         * symfile.c: Fix common/ includes.
8825         * stap-probe.c: Fix common/ includes.
8826         * spu-linux-nat.c: Fix common/ includes.
8827         * sparc-nat.c: Fix common/ includes.
8828         * source.c: Fix common/ includes.
8829         * solib.c: Fix common/ includes.
8830         * solib-target.c: Fix common/ includes.
8831         * ser-unix.c: Fix common/ includes.
8832         * ser-tcp.c: Fix common/ includes.
8833         * ser-pipe.c: Fix common/ includes.
8834         * ser-base.c: Fix common/ includes.
8835         * selftest-arch.c: Fix common/ includes.
8836         * s12z-tdep.c: Fix common/ includes.
8837         * rust-exp.y: Fix common/ includes.
8838         * rs6000-aix-tdep.c: Fix common/ includes.
8839         * riscv-tdep.c: Fix common/ includes.
8840         * remote.c: Fix common/ includes.
8841         * remote-notif.h: Fix common/ includes.
8842         * remote-fileio.h: Fix common/ includes.
8843         * remote-fileio.c: Fix common/ includes.
8844         * regcache.h: Fix common/ includes.
8845         * regcache.c: Fix common/ includes.
8846         * record-btrace.c: Fix common/ includes.
8847         * python/python.c: Fix common/ includes.
8848         * python/py-type.c: Fix common/ includes.
8849         * python/py-inferior.c: Fix common/ includes.
8850         * progspace.h: Fix common/ includes.
8851         * producer.c: Fix common/ includes.
8852         * procfs.c: Fix common/ includes.
8853         * proc-api.c: Fix common/ includes.
8854         * printcmd.c: Fix common/ includes.
8855         * ppc-linux-nat.c: Fix common/ includes.
8856         * parser-defs.h: Fix common/ includes.
8857         * osdata.c: Fix common/ includes.
8858         * obsd-nat.c: Fix common/ includes.
8859         * nat/x86-linux.c: Fix common/ includes.
8860         * nat/x86-linux-dregs.c: Fix common/ includes.
8861         * nat/x86-dregs.h: Fix common/ includes.
8862         * nat/x86-dregs.c: Fix common/ includes.
8863         * nat/ppc-linux.c: Fix common/ includes.
8864         * nat/mips-linux-watch.h: Fix common/ includes.
8865         * nat/mips-linux-watch.c: Fix common/ includes.
8866         * nat/linux-waitpid.c: Fix common/ includes.
8867         * nat/linux-ptrace.h: Fix common/ includes.
8868         * nat/linux-ptrace.c: Fix common/ includes.
8869         * nat/linux-procfs.c: Fix common/ includes.
8870         * nat/linux-personality.c: Fix common/ includes.
8871         * nat/linux-osdata.c: Fix common/ includes.
8872         * nat/linux-namespaces.c: Fix common/ includes.
8873         * nat/linux-btrace.h: Fix common/ includes.
8874         * nat/linux-btrace.c: Fix common/ includes.
8875         * nat/fork-inferior.c: Fix common/ includes.
8876         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8877         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8878         * nat/aarch64-linux.c: Fix common/ includes.
8879         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8880         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8881         * namespace.h: Fix common/ includes.
8882         * mips-linux-tdep.c: Fix common/ includes.
8883         * minsyms.c: Fix common/ includes.
8884         * mi/mi-parse.h: Fix common/ includes.
8885         * mi/mi-main.c: Fix common/ includes.
8886         * mi/mi-cmd-env.c: Fix common/ includes.
8887         * memrange.h: Fix common/ includes.
8888         * memattr.c: Fix common/ includes.
8889         * maint.h: Fix common/ includes.
8890         * maint.c: Fix common/ includes.
8891         * main.c: Fix common/ includes.
8892         * machoread.c: Fix common/ includes.
8893         * location.c: Fix common/ includes.
8894         * linux-thread-db.c: Fix common/ includes.
8895         * linux-nat.c: Fix common/ includes.
8896         * linux-fork.c: Fix common/ includes.
8897         * inline-frame.c: Fix common/ includes.
8898         * infrun.c: Fix common/ includes.
8899         * inflow.c: Fix common/ includes.
8900         * inferior.h: Fix common/ includes.
8901         * inferior.c: Fix common/ includes.
8902         * infcmd.c: Fix common/ includes.
8903         * inf-ptrace.c: Fix common/ includes.
8904         * inf-child.c: Fix common/ includes.
8905         * ia64-linux-nat.c: Fix common/ includes.
8906         * i387-tdep.c: Fix common/ includes.
8907         * i386-tdep.c: Fix common/ includes.
8908         * i386-linux-tdep.c: Fix common/ includes.
8909         * i386-linux-nat.c: Fix common/ includes.
8910         * i386-go32-tdep.c: Fix common/ includes.
8911         * i386-fbsd-tdep.c: Fix common/ includes.
8912         * i386-fbsd-nat.c: Fix common/ includes.
8913         * guile/scm-type.c: Fix common/ includes.
8914         * guile/guile.c: Fix common/ includes.
8915         * go32-nat.c: Fix common/ includes.
8916         * gnu-nat.c: Fix common/ includes.
8917         * gdbthread.h: Fix common/ includes.
8918         * gdbarch-selftests.c: Fix common/ includes.
8919         * gdb_usleep.c: Fix common/ includes.
8920         * gdb_select.h: Fix common/ includes.
8921         * gdb_bfd.c: Fix common/ includes.
8922         * gcore.c: Fix common/ includes.
8923         * fork-child.c: Fix common/ includes.
8924         * findvar.c: Fix common/ includes.
8925         * fbsd-nat.c: Fix common/ includes.
8926         * event-top.c: Fix common/ includes.
8927         * event-loop.c: Fix common/ includes.
8928         * dwarf2read.c: Fix common/ includes.
8929         * dwarf2loc.c: Fix common/ includes.
8930         * dwarf2-frame.c: Fix common/ includes.
8931         * dwarf-index-cache.c: Fix common/ includes.
8932         * dtrace-probe.c: Fix common/ includes.
8933         * disasm-selftests.c: Fix common/ includes.
8934         * defs.h: Fix common/ includes.
8935         * csky-tdep.c: Fix common/ includes.
8936         * cp-valprint.c: Fix common/ includes.
8937         * cp-support.h: Fix common/ includes.
8938         * cp-support.c: Fix common/ includes.
8939         * corelow.c: Fix common/ includes.
8940         * completer.h: Fix common/ includes.
8941         * completer.c: Fix common/ includes.
8942         * compile/compile.c: Fix common/ includes.
8943         * compile/compile-loc2c.c: Fix common/ includes.
8944         * compile/compile-cplus-types.c: Fix common/ includes.
8945         * compile/compile-cplus-symbols.c: Fix common/ includes.
8946         * command.h: Fix common/ includes.
8947         * cli/cli-dump.c: Fix common/ includes.
8948         * cli/cli-cmds.c: Fix common/ includes.
8949         * charset.c: Fix common/ includes.
8950         * build-id.c: Fix common/ includes.
8951         * btrace.h: Fix common/ includes.
8952         * btrace.c: Fix common/ includes.
8953         * breakpoint.h: Fix common/ includes.
8954         * breakpoint.c: Fix common/ includes.
8955         * ax.h:
8956         (enum agent_op): Fix common/ includes.
8957         * ax-general.c (struct aop_map): Fix common/ includes.
8958         * ax-gdb.c: Fix common/ includes.
8959         * auxv.c: Fix common/ includes.
8960         * auto-load.c: Fix common/ includes.
8961         * arm-tdep.c: Fix common/ includes.
8962         * arch/riscv.c: Fix common/ includes.
8963         * arch/ppc-linux-common.c: Fix common/ includes.
8964         * arch/i386.c: Fix common/ includes.
8965         * arch/arm.c: Fix common/ includes.
8966         * arch/arm-linux.c: Fix common/ includes.
8967         * arch/arm-get-next-pcs.c: Fix common/ includes.
8968         * arch/amd64.c: Fix common/ includes.
8969         * arch/aarch64.c: Fix common/ includes.
8970         * arch/aarch64-insn.c: Fix common/ includes.
8971         * arch-utils.c: Fix common/ includes.
8972         * amd64-windows-tdep.c: Fix common/ includes.
8973         * amd64-tdep.c: Fix common/ includes.
8974         * amd64-sol2-tdep.c: Fix common/ includes.
8975         * amd64-obsd-tdep.c: Fix common/ includes.
8976         * amd64-nbsd-tdep.c: Fix common/ includes.
8977         * amd64-linux-tdep.c: Fix common/ includes.
8978         * amd64-linux-nat.c: Fix common/ includes.
8979         * amd64-fbsd-tdep.c: Fix common/ includes.
8980         * amd64-fbsd-nat.c: Fix common/ includes.
8981         * amd64-dicos-tdep.c: Fix common/ includes.
8982         * amd64-darwin-tdep.c: Fix common/ includes.
8983         * agent.c: Fix common/ includes.
8984         * ada-lang.h: Fix common/ includes.
8985         * ada-lang.c: Fix common/ includes.
8986         * aarch64-tdep.c: Fix common/ includes.
8987
8988 2019-01-25  Tom Tromey  <tom@tromey.com>
8989
8990         * common/create-version.sh: Use common/version.h.
8991
8992 2019-01-24  Pedro Alves  <palves@redhat.com>
8993
8994         * infrun.c (signal_stop, signal_print, signal_program)
8995         (signal_catch, signal_pass): Now arrays instead of pointers.
8996         (update_signals_program_target, do_target_resume)
8997         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8998         * linux-nat.c (linux_nat_target::pass_signals)
8999         (linux_nat_target::create_inferior, linux_nat_target::attach):
9000         Adjust.
9001         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9002         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9003         * procfs.c (procfs_target::pass_signals): Adjust.
9004         * record-full.c (record_full_target::resume): Adjust.
9005         * remote.c (remote_target::pass_signals)
9006         (remote_target::program_signals): Adjust.
9007         * target-debug.h (target_debug_print_signals): Now takes a
9008         gdb::array_view as parameter.  Adjust.
9009         * target.h (target_ops) <pass_signals, program_signals>: Replace
9010         pointer and length parameters with gdb::array_view.
9011         (target_pass_signals, target_program_signals): Likewise.
9012         * target-delegates.c: Regenerate.
9013
9014 2019-01-24  Pedro Alves  <palves@redhat.com>
9015
9016         * common/forward-scope-exit.h
9017         (forward_scope_exit::forward_scope_exit): Pass arguments to
9018         m_bind_function directly, instead of creating a std::bind and
9019         copying that.
9020
9021 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9022
9023         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9024         for static members.
9025         (pass_in_v_vfp_candidate): Likewise.
9026
9027 2019-01-23  Tom Tromey  <tom@tromey.com>
9028             Pedro Alves  <palves@redhat.com>
9029
9030         * regcache.c (class regcache_invalidator): Remove.
9031         (regcache::raw_write): Use make_scope_exit.
9032
9033 2019-01-23  Tom Tromey  <tom@tromey.com>
9034
9035         * ui-out.h (class ui_out_emit_type): Update comment.
9036
9037 2019-01-23  Tom Tromey  <tom@tromey.com>
9038
9039         * infrun.c (fetch_inferior_event): Update comment.
9040
9041 2019-01-23  Tom Tromey  <tom@tromey.com>
9042             Pedro Alves  <palves@redhat.com>
9043
9044         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9045         parameter.
9046         (fetch_inferior_event): Use SCOPE_EXIT.
9047
9048
9049 2019-01-23  Tom Tromey  <tom@tromey.com>
9050             Pedro Alves  <palves@redhat.com>
9051
9052         * infrun.c (disable_thread_events): Delete.
9053         (stop_all_threads): Use SCOPE_EXIT.
9054
9055 2019-01-23  Tom Tromey  <tom@tromey.com>
9056             Pedro Alves  <palves@redhat.com>
9057
9058         * symfile.c: Include forward-scope-exit.h.
9059         (clear_symtab_users_cleanup): Replace forward declaration with
9060         a FORWARD_SCOPE_EXIT.
9061         (syms_from_objfile_1): Use the forward_scope_exit and
9062         gdb::optional instead of cleanup_function.
9063         (reread_symbols): Use the forward_scope_exit instead of
9064         cleanup_function.
9065         (clear_symtab_users_cleanup): Remove function.
9066
9067 2019-01-23  Tom Tromey  <tom@tromey.com>
9068             Pedro Alves  <palves@redhat.com>
9069
9070         * linux-nat.c: Include scope-exit.h.
9071         (cleanup_target_stop): Remove.
9072         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9073         SCOPE_EXIT.
9074
9075 2019-01-23  Tom Tromey  <tom@tromey.com>
9076             Pedro Alves  <palves@redhat.com>
9077
9078         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9079         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9080
9081 2019-01-23  Tom Tromey  <tom@tromey.com>
9082             Andrew Burgess  <andrew.burgess@embecosm.com>
9083             Pedro Alves  <palves@redhat.com>
9084
9085         * infrun.c (fetch_inferior_event): Use scope_exit.
9086         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9087         * top.c (execute_command): Use scope_exit.
9088         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9089         * utils.c (do_bpstat_clear_actions_cleanup)
9090         (make_bpstat_clear_actions_cleanup): Remove.
9091
9092 2019-01-23  Tom Tromey  <tom@tromey.com>
9093             Pedro Alves  <palves@redhat.com>
9094
9095         * infrun.c: Include "common/scope-exit.h"
9096         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9097         (wait_for_inferior): Use SCOPE_EXIT.
9098         (fetch_inferior_event): Use scope_exit.
9099
9100 2019-01-23  Tom Tromey  <tom@tromey.com>
9101             Pedro Alves  <palves@redhat.com>
9102
9103         * breakpoint.c (create_breakpoint): Remove cleanup.
9104
9105 2019-01-23  Tom Tromey  <tom@tromey.com>
9106             Andrew Burgess  <andrew.burgess@embecosm.com>
9107             Pedro Alves  <palves@redhat.com>
9108
9109 2019-01-23  Pedro Alves  <palves@redhat.com>
9110
9111         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9112
9113 2019-01-23  Pedro Alves  <palves@redhat.com>
9114             Andrew Burgess  <andrew.burgess@embecosm.com>
9115
9116         * gdbthread.h: Include "common/forward-scope-exit.h".
9117         (scoped_finish_thread_state): Redefine custom class in terms of
9118         forward_scope_exit.
9119
9120 2019-01-23  Pedro Alves  <palves@redhat.com>
9121             Andrew Burgess  <andrew.burgess@embecosm.com>
9122
9123         * common/forward-scope-exit.h: New file.
9124
9125 2019-01-23  Pedro Alves  <palves@redhat.com>
9126             Andrew Burgess  <andrew.burgess@embecosm.com>
9127             Tom Tromey  <tom@tromey.com>
9128
9129         * common/scope-exit.h: New file.
9130
9131 2019-01-23  Pedro Alves  <palves@redhat.com>
9132
9133         * common/preprocessor.h (ESC): Rename to ...
9134         (ESC_PARENS): ... this.
9135         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9136         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9137
9138 2019-01-23  Tom Tromey  <tom@tromey.com>
9139
9140         * language.h (class scoped_switch_to_sym_language_if_auto):
9141         Initialize m_lang in both cases.
9142
9143 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9144
9145         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9146         with XCNEW.
9147
9148 2019-01-22  Tom Tromey  <tom@tromey.com>
9149
9150         * corelow.c: Do not include sys/file.h.
9151
9152 2019-01-22  Tom Tromey  <tom@tromey.com>
9153
9154         * tui/tui-wingeneral.h: Include gdb_curses.h.
9155
9156 2019-01-22  Tom Tromey  <tom@tromey.com>
9157
9158         * source-cache.h (class source_cache) <get_source_lines,
9159         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9160
9161 2019-01-22  Tom Tromey  <tom@tromey.com>
9162
9163         * remote-fileio.h (struct remote_target): Declare.
9164
9165 2019-01-22  Tom Tromey  <tom@tromey.com>
9166
9167         * python/py-arch.c: Do not include py-ref.h.
9168         * python/py-bpevent.c: Do not include py-ref.h.
9169         * python/py-cmd.c: Do not include py-ref.h.
9170         * python/py-continueevent.c: Do not include py-ref.h.
9171         * python/py-event.h: Do not include py-ref.h.
9172         * python/py-evtregistry.c: Do not include py-ref.h.
9173         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9174         * python/py-frame.c: Do not include py-ref.h.
9175         * python/py-framefilter.c: Do not include py-ref.h.
9176         * python/py-function.c: Do not include py-ref.h.
9177         * python/py-infevents.c: Do not include py-ref.h.
9178         * python/py-linetable.c: Do not include py-ref.h.
9179         * python/py-objfile.c: Do not include py-ref.h.
9180         * python/py-param.c: Do not include py-ref.h.
9181         * python/py-prettyprint.c: Do not include py-ref.h.
9182         * python/py-progspace.c: Do not include py-ref.h.
9183         * python/py-symbol.c: Do not include py-ref.h.
9184         * python/py-symtab.c: Do not include py-ref.h.
9185         * python/py-type.c: Do not include py-ref.h.
9186         * python/py-unwind.c: Do not include py-ref.h.
9187         * python/py-utils.c: Do not include py-ref.h.
9188         * python/py-value.c: Do not include py-ref.h.
9189         * python/py-varobj.c: Do not include py-ref.h.
9190         * python/py-xmethods.c: Do not include py-ref.h.
9191         * python/python.c: Do not include py-ref.h.
9192         * varobj.c: Do not include py-ref.h.
9193
9194 2019-01-22  Tom Tromey  <tom@tromey.com>
9195
9196         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9197         keyword for bcache.
9198
9199 2019-01-22  Tom Tromey  <tom@tromey.com>
9200
9201         * compile/compile-cplus-types.c: Remove a comment by #include.
9202
9203 2019-01-22  Tom Tromey  <tom@tromey.com>
9204
9205         * compile/gcc-c-plugin.h: Include compile-internal.h.
9206
9207 2019-01-22  Tom Tromey  <tom@tromey.com>
9208
9209         * stabsread.c (EXTERN): Do not define.
9210         (symnum, next_symbol_text_func, processing_gcc_compilation)
9211         (within_function, global_sym_chain, global_stabs)
9212         (previous_stab_code, this_object_header_files)
9213         (n_this_object_header_files)
9214         (n_allocated_this_object_header_files): Define.
9215         * stabsread.h (EXTERN): Never define.  Use "extern".
9216
9217 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9218
9219         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9220         history_value.
9221
9222 2019-01-21  Tom Tromey  <tom@tromey.com>
9223
9224         * ui-out.c: Fix includes.
9225         * tui/tui-source.c: Fix includes.
9226         * target.c: Fix includes.
9227         * remote.c: Fix includes.
9228         * regcache.c: Fix includes.
9229         * python/py-block.c: Fix includes.
9230         * printcmd.c: Fix includes.
9231         * or1k-tdep.c: Fix includes.
9232         * mi/mi-main.c: Fix includes.
9233         * m32r-tdep.c: Fix includes.
9234         * csky-tdep.c: Fix includes.
9235         * compile/compile-cplus-types.c: Fix includes.
9236         * cli/cli-interp.c: Fix includes.
9237
9238 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9239
9240         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9241         for padding.
9242
9243 2019-01-16  Tom Tromey  <tom@tromey.com>
9244
9245         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9246         earlier.
9247         (struct objfile) <msymbols_range>: Move from top level.
9248         <msymbols>: New method.
9249         (class objfile_msymbols): Remove.
9250         * symtab.c (default_collect_symbol_completion_matches_break_on):
9251         Update.
9252         * symmisc.c (dump_msymbols): Update.
9253         * stabsread.c (scan_file_globals): Update.
9254         * objc-lang.c (info_selectors_command, info_classes_command)
9255         (find_methods): Update.
9256         * minsyms.c (find_solib_trampoline_target): Update.
9257         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9258         * coffread.c (coff_symfile_read): Update.
9259         * ada-lang.c (ada_lookup_simple_minsym)
9260         (ada_collect_symbol_completion_matches): Update.
9261
9262 2019-01-16  Tom Tromey  <tom@tromey.com>
9263
9264         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9265         type.  Remove no-argument constructor.
9266         <iterator::operator++>: Simplify.
9267         <begin>: Update.
9268         <end>: Use minimal_symbol_count.
9269
9270 2019-01-16  Tom Tromey  <tom@tromey.com>
9271
9272         * objfiles.h (struct objfile) <psymtabs>: New method.
9273         (class objfile_psymtabs): Remove.
9274         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9275         typedef.
9276         <range>: New method.
9277         (require_partial_symbols): Change return type.
9278         * psymtab.c (require_partial_symbols)
9279         (psym_expand_symtabs_matching): Update.
9280         * mdebugread.c (parse_partial_symbols): Update.
9281         * dbxread.c (dbx_end_psymtab): Update.
9282
9283 2019-01-15  Tom Tromey  <tom@tromey.com>
9284
9285         * symtab.c (lookup_objfile_from_block)
9286         (lookup_symbol_in_objfile_symtabs)
9287         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9288         (find_line_symtab, info_sources_command)
9289         (default_collect_symbol_completion_matches_break_on)
9290         (make_source_files_completion_list): Update.
9291         * symmisc.c (print_objfile_statistics, dump_objfile)
9292         (maintenance_print_symbols, maintenance_info_symtabs)
9293         (maintenance_check_symtabs, maintenance_info_line_tables):
9294         Update.
9295         * source.c (select_source_symtab)
9296         (forget_cached_source_info_for_objfile): Update.
9297         * objfiles.h (class objfile_compunits): Remove.
9298         (struct objfile) <compunits_range>: New typedef.
9299         (compunits): New method.
9300         * objfiles.c (objfile_relocate1): Update.
9301         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9302         * maint.c (count_symtabs_and_blocks): Update.
9303         * linespec.c (iterate_over_all_matching_symtabs): Update.
9304         * cp-support.c (add_symbol_overload_list_qualified): Update.
9305         * coffread.c (coff_symtab_read): Update.
9306         * ada-lang.c (add_nonlocal_symbols)
9307         (ada_collect_symbol_completion_matches)
9308         (ada_add_global_exceptions): Update.
9309
9310 2019-01-15  Tom Tromey  <tom@tromey.com>
9311
9312         * progspace.h (program_space) <objfiles_safe_range>: New
9313         typedef.
9314         <objfiles_safe>: New method.
9315         * objfiles.h (class all_objfiles_safe): Remove.
9316         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9317         * jit.c (jit_inferior_exit_hook): Update.
9318
9319 2019-01-17  Tom Tromey  <tom@tromey.com>
9320
9321         * progspace.h (program_space) <objfiles_range>: New typedef.
9322         <objfiles>: New method.
9323         <objfiles_head>: Rename from objfiles.
9324         (object_files): Update.
9325         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9326         * guile/scm-pretty-print.c
9327         (ppscm_find_pretty_printer_from_objfiles): Update.
9328         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9329         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9330         Update.
9331         * python/py-progspace.c (pspy_get_objfiles): Update.
9332         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9333         Update.
9334         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9335         (objfpy_lookup_objfile_by_build_id): Update.
9336         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9337         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9338         Update.
9339         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9340         (expand_symtab_containing_pc, lookup_objfile_from_block)
9341         (lookup_static_symbol, basic_lookup_transparent_type)
9342         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9343         (find_line_symtab, info_sources_command)
9344         (default_collect_symbol_completion_matches_break_on)
9345         (make_source_files_completion_list, find_main_name): Update.
9346         * symmisc.c (print_symbol_bcache_statistics)
9347         (print_objfile_statistics, maintenance_print_symbols)
9348         (maintenance_print_msymbols, maintenance_print_objfiles)
9349         (maintenance_info_symtabs, maintenance_check_symtabs)
9350         (maintenance_expand_symtabs, maintenance_info_line_tables):
9351         Update.
9352         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9353         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9354         (map_overlay_command, unmap_overlay_command)
9355         (simple_overlay_update, expand_symtabs_matching)
9356         (map_symbol_filenames): Update.
9357         * symfile-debug.c (set_debug_symfile): Update.
9358         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9359         Update.
9360         * source.c (select_source_symtab, forget_cached_source_info):
9361         Update.
9362         * solib.c (solib_read_symbols): Update.
9363         * solib-spu.c (append_ocl_sos): Update.
9364         * psymtab.c (maintenance_print_psymbols)
9365         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9366         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9367         * printcmd.c (info_symbol_command): Update.
9368         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9369         Update.
9370         * objfiles.h (class all_objfiles): Remove.
9371         * objfiles.c (have_partial_symbols, have_full_symbols)
9372         (have_minimal_symbols, qsort_cmp, update_section_map)
9373         (shared_objfile_contains_address_p)
9374         (default_iterate_over_objfiles_in_search_order): Update.
9375         * objc-lang.c (info_selectors_command, info_classes_command)
9376         (find_methods): Update.
9377         * minsyms.c (find_solib_trampoline_target): Update.
9378         * maint.c (maintenance_info_sections)
9379         (maintenance_translate_address, count_symtabs_and_blocks):
9380         Update.
9381         * main.c (captured_main_1): Update.
9382         * linux-thread-db.c (try_thread_db_load_from_pdir)
9383         (has_libpthread): Update.
9384         * linespec.c (iterate_over_all_matching_symtabs)
9385         (search_minsyms_for_name): Update.
9386         * jit.c (jit_find_objf_with_entry_addr): Update.
9387         * hppa-tdep.c (find_unwind_entry)
9388         (hppa_lookup_stub_minimal_symbol): Update.
9389         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9390         Update.
9391         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9392         (elf_gnu_ifunc_resolve_by_got): Update.
9393         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9394         * dwarf-index-write.c (save_gdb_index_command): Update.
9395         * cp-support.c (add_symbol_overload_list_qualified): Update.
9396         * breakpoint.c (create_overlay_event_breakpoint)
9397         (create_longjmp_master_breakpoint)
9398         (create_std_terminate_master_breakpoint)
9399         (create_exception_master_breakpoint): Update.
9400         * blockframe.c (find_pc_partial_function): Update.
9401         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9402         (ada_collect_symbol_completion_matches)
9403         (ada_add_global_exceptions): Update.
9404
9405 2019-01-17  Tom Tromey  <tom@tromey.com>
9406
9407         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9408         declare VEC.
9409         (solib_target_parse_libraries): Change return type.
9410         (library_list_start_segment, library_list_start_section)
9411         (library_list_end_library, library_list_start_library); Update.
9412         (solib_target_free_library_list): Remove.
9413         (solib_target_parse_libraries): Remove cleanup.  Change return
9414         type.
9415         (solib_target_current_sos): Update.
9416
9417 2019-01-17  Tom Tromey  <tromey@bapiya>
9418
9419         * valprint.c: Replace "the the" with "the".
9420         * symtab.c: Replace "the the" with "the".
9421         * solib.c: Replace "the the" with "the".
9422         * solib-dsbt.c: Replace "the the" with "the".
9423         * linespec.c: Replace "the the" with "the".
9424         * dwarf2loc.h: Replace "the the" with "the".
9425         * amd64-windows-tdep.c: Replace "the the" with "the".
9426         * aarch64-tdep.c: Replace "the the" with "the".
9427
9428 2019-01-16  Keith Seitz  <keiths@redhat.com>
9429
9430         PR gdb/23773
9431         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9432         <builder>: Rename to ..
9433         <m_builder>: ... this and make private.
9434         (dwarf2_cu::get_builder): New method.  Change all users of
9435         `builder' to use this method.
9436         (dwarf2_start_symtab): Move to ...
9437         (dwarf2_cu::start_symtab): ... here.  Update all callers
9438         (setup_type_unit_groups): Move to ...
9439         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9440         callers.
9441         (dwarf2_cu::reset_builder): New method.
9442         (process_full_compunit, process_full_type_unit): Use
9443         dwarf2_cu::reset_builder.
9444         (follow_die_offset): Record the ancestor CU if it is different
9445         from the followed DIE's CU.
9446         (follow_die_sig_1): Likewise.
9447
9448 2019-01-15  Tom Tromey  <tom@tromey.com>
9449
9450         * remote.c (class remote_state) <buf>: Now a char_vector.
9451         <buf_size>: Remove.
9452         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9453         parameter.
9454         (remote_target::getpkt_or_notif_sane_1)
9455         (remote_target::getpkt_sane)
9456         (remote_target::getpkt_or_notif_sane): Likewise.
9457         (class remote_target) <putpkt>: New overload.
9458         (remote_target::read_frame): Change type of "buf_p".  Remove
9459         sizeof_p parameter.
9460         (packet_ok): New overload.
9461         (packet_check_result): New overload.
9462         Update all uses.
9463
9464 2019-01-14  Tom Tromey  <tom@tromey.com>
9465
9466         * remote-notif.c (handle_notification, remote_notif_ack)
9467         (remote_notif_parse): Make "buf" const.
9468         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9469         const.
9470         (remote_notif_parse, remote_notif_ack, handle_notification):
9471         Likewise.
9472         * remote.c (remote_notif_stop_parse): Make "buf" const.
9473         (remote_target::remote_parse_stop_reply): Make "buf" const.
9474         (remote_notif_stop_ack): Make "buf" const.
9475
9476 2019-01-14  Tom Tromey  <tom@tromey.com>
9477
9478         * remote.c (remote_console_output): Make parameter const.
9479
9480 2019-01-14  Tom Tromey  <tom@tromey.com>
9481
9482         * target-debug.h (target_debug_print_signals): Constify.
9483         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9484         * procfs.c (procfs_target::pass_signals): Update.
9485         * linux-nat.c (linux_nat_target::pass_signals): Update.
9486         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9487         * target-delegates.c: Rebuild.
9488         * remote.c (remote_target::program_signals): Update.
9489         (remote_target::pass_signals): Update.
9490         * target.c (target_pass_signals): Constify argument.
9491         (target_program_signals): Likewise.
9492         * target.h (struct target_ops) <pass_signals, program_signals>:
9493         Constify argument.
9494         (target_pass_signals, target_program_signals): Constify argument.
9495
9496 2019-01-14  Tom Tromey  <tom@tromey.com>
9497
9498         PR tui/28819:
9499         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9500
9501 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9502
9503         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9504         field.
9505         * rs6000-tdep.c: Include reggroups.h.
9506         (IS_V_ALIAS_PSEUDOREG): Define.
9507         (rs6000_register_name): Return names for the "vX" aliases.
9508         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9509         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9510         aliases.  Call default_register_reggroup_p for all other
9511         pseudo-registers.
9512         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9513         New functions.
9514         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9515         Handle "vX" aliases.
9516         (v_alias_pseudo_register_collect): New function.
9517         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9518         (rs6000_gdbarch_init): Initialize "vX" aliases as
9519         pseudo-registers.  Restore registration of
9520         rs6000_pseudo_register_reggroup_p with
9521         set_tdesc_pseudo_register_reggroup_p.
9522
9523 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9524
9525         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9526         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9527         set_gdbarch_num_pseudo_regs.
9528
9529 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9530
9531         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9532         Remove arg prefixname, add do_set and do_show.
9533         Add member functions set_list and show_list.
9534         * cli/cli-style.c (class cli_style_option): Update accordingly.
9535         (style_set_list): Move to file scope.
9536         (style_show_list): Likewise.
9537         (set_style): Call help_list.
9538         (show_style): Call cmd_show_list.
9539         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9540         Update to use the new macro.
9541
9542 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9543
9544         * ada-lang.c (_initialize_ada_language): Expand the help text
9545         for the "catch exception" command.
9546
9547 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9548
9549         * symtab.c (matching_obj_sections): Initialize obj,
9550         declare it closer to its usage.
9551
9552 2019-01-10  Tom Tromey  <tom@tromey.com>
9553
9554         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9555         (basic_inf_threads_range): Remove.
9556         (inf_threads_range, inf_non_exited_threads_range)
9557         (safe_inf_threads_range): Use next_adapter.
9558
9559 2019-01-10  Keith Seitz  <keiths@redhat.com>
9560
9561         PR gdb/23712
9562         PR symtab/23010
9563         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9564         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9565
9566 2019-01-10  Keith Seitz  <keiths@redhat.com>
9567
9568         PR gdb/23712
9569         PR symtab/23010
9570         * dictionary.c (pending_to_vector): Remove.
9571         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9572         Remove _1 suffix, replacing functions of the same name.  Update
9573         all callers.
9574         (dict_create_hashed, dict_create_hashed_expandable)
9575         (dict_create_linear, dict_create_linear_expandable, dict_free)
9576         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9577         Make functions static.
9578
9579 2019-01-10  Keith Seitz  <keiths@redhat.com>
9580
9581         PR gdb/23712
9582         PR symtab/23010
9583         * dictionary.h (struct dictionary): Replace declaration with
9584         multidictionary.
9585         (dict_create_hashed, dict_create_hashed_expandable)
9586         (dict_create_linear, dict_create_linear_expandable)
9587         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9588         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9589         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9590         taking multidictionary argument.
9591         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9592         * block.h (struct block) <dict>: Change to multidictionary
9593         and rename `multidict'.
9594         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9595         symmisc.c: Update all dictionary references to multidictionary.
9596
9597 2019-01-10  Keith Seitz  <keiths@redhat.com>
9598
9599         PR gdb/23712
9600         PR symtab/23010
9601         * dictionary.c: Include unordered_map.
9602         (pending_to_vector): New function.
9603         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9604         Rewrite the non-"_1" functions to take vector instead
9605         of linked list.
9606         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9607         "new" _1 versions of the same name.
9608         (multidictionary): Define.
9609         (std::hash<enum language): New definition.
9610         (collate_pending_symbols_by_language, mdict_create_hashed)
9611         (mdict_create_hashed_expandable, mdict_create_linear)
9612         (mdict_create_linear_expandable, mdict_free)
9613         (find_language_dictionary, create_new_language_dictionary)
9614         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9615         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9616         (mdict_size, mdict_empty): New functions.
9617         * dictionary.h (mdict_iterator): Define.
9618
9619 2019-01-10  Pedro Alves  <palves@redhat.com>
9620
9621         * breakpoint.c (read_uploaded_action)
9622         (create_tracepoint_from_upload): Adjust to use
9623         gdb::unique_xmalloc_ptr.
9624         * ctf.c (ctf_write_uploaded_tp):
9625         (SET_ARRAY_FIELD): Use emplace_back.
9626         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9627         * tracefile-tfile.c (tfile_write_uploaded_tp):
9628         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9629         gdb::unique_xmalloc_ptr.
9630         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9631         at_string, cond_string, cmd_strings>: Replace char pointers
9632         with gdb::unique_xmalloc_ptr.
9633
9634 2019-01-10  Pedro Alves  <palves@redhat.com>
9635
9636         * solib-target.c (library_list_start_library): Don't xstrdup name.
9637
9638 2019-01-10  Pedro Alves  <palves@redhat.com>
9639
9640         * mdebugread.c (parse_partial_symbols): Use
9641         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9642
9643 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9644
9645         * linux-fork.c (scoped_switch_fork_info)
9646         <~scoped_switch_fork_info>: Fix incorrect variable name.
9647
9648 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9649
9650         * linux-fork.c (scoped_switch_fork_info)
9651         <scoped_switch_fork_info>: Make explicit.
9652         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9653
9654 2019-01-10  Tom Tromey  <tom@tromey.com>
9655
9656         * objfiles.h (objfile::reset_psymtabs): Update.
9657         * objfiles.c (objfile::objfile): Update.
9658         * psymtab.h (psymtab_storage::obstack): Update.
9659         (psymtab_storage::m_obstack): Use gdb::optional.
9660         (class psymtab_storage): Update comment.  Remove objfile
9661         parameter.
9662         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9663
9664 2019-01-10  Tom Tromey  <tom@tromey.com>
9665
9666         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9667         <free_psymtabs>: Now private.
9668         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9669         (allocate_psymtab): Use new method.
9670
9671 2019-01-10  Tom Tromey  <tom@tromey.com>
9672
9673         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9674         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9675         * mdebugread.c (parse_partial_symbols): Use
9676         allocate_dependencies.
9677         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9678         allocate_dependencies.
9679         (process_psymtab_comp_unit_reader)
9680         (build_type_psymtab_dependencies): Likewise.
9681         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9682
9683 2019-01-10  Tom Tromey  <tom@tromey.com>
9684
9685         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9686         PSYMBOL_SET_LANGUAGE.
9687         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9688
9689 2019-01-10  Tom Tromey  <tom@tromey.com>
9690
9691         * psymtab.h (psymtab_storage::obstack): New method.
9692         <m_obstack>: Rename from obstack; now private.
9693         * psymtab.c (psymtab_storage): Update.
9694         * dwarf2read.c (create_addrmap_from_index)
9695         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9696         Update.
9697
9698 2019-01-10  Tom Tromey  <tom@tromey.com>
9699
9700         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9701         * objfiles.h (objfile::reset_psymtabs): New method.
9702
9703 2019-01-10  Tom Tromey  <tom@tromey.com>
9704
9705         * symmisc.c (print_symbol_bcache_statistics): Update.
9706         (print_objfile_statistics): Update.
9707         * symfile.c (reread_symbols): Update.
9708         * psymtab.h (class psymtab_storage): New.
9709         * psymtab.c (psymtab_storage): New constructor.
9710         (~psymtab_storage): New destructor.
9711         (require_partial_symbols): Update.
9712         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9713         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9714         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9715         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9716         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9717         (start_psymtab_common, end_psymtab_common)
9718         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9719         (allocate_psymtab): Update.
9720         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9721         Update.
9722         (dump_psymtab_addrmap, maintenance_print_psymbols)
9723         (maintenance_check_psymtabs): Update.
9724         (class objfile_psymtabs): Move to objfiles.h.
9725         * psympriv.h (discard_psymtab): Now inline.
9726         (psymtab_discarder::psymtab_discarder): Update.
9727         (psymtab_discarder::~psymtab_discarder): Update.
9728         (ALL_OBJFILE_PSYMTABS): Rewrite.
9729         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9730         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9731         Remove fields.
9732         <partial_symtabs>: New field.
9733         (class objfile_psymtabs): Move from psymtab.h.  Update.
9734         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9735         psymbol_cache.
9736         (objfile::~objfile): Don't destroy psymbol_cache.
9737         * mdebugread.c (parse_partial_symbols): Update.
9738         * dwarf2read.c (create_addrmap_from_index)
9739         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9740         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9741         (add_partial_subprogram, dwarf2_ranges_read): Update.
9742         * dwarf-index-write.c (write_address_map)
9743         (write_one_signatured_type, recursively_write_psymbols)
9744         (class debug_names, class debug_names, write_psymtabs_to_index):
9745         Update.
9746
9747 2019-01-10  Tom Tromey  <tom@tromey.com>
9748
9749         * symtab.h (SYMBOL_SET_NAMES): Update.
9750         (symbol_set_names): Update.
9751         (MSYMBOL_SET_NAMES): Update.
9752         * symtab.c (symbol_set_names): Change argument to be an
9753         objfile_per_bfd_storage.
9754         * psymtab.c (add_psymbol_to_bcache): Update.
9755         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9756
9757 2019-01-10  Tom Tromey  <tom@tromey.com>
9758
9759         * symtab.c (create_demangled_names_hash): Change argument to be an
9760         objfile_per_bfd_storage.
9761         (symbol_set_names): Update.
9762
9763 2019-01-10  Tom Tromey  <tom@tromey.com>
9764
9765         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9766         init_psymbol_list.
9767         * psymtab.c (init_psymbol_list): Do nothing if already called.
9768         * psympriv.h (init_psymbol_list): Add comment.
9769         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9770         init_psymbol_list.
9771         * dbxread.c (dbx_symfile_read): Unconditionally call
9772         init_psymbol_list.
9773
9774 2019-01-10  Tom Tromey  <tom@tromey.com>
9775
9776         * xcoffread.c (scan_xcoff_symtab): Update.
9777         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9778         "where".
9779         * mdebugread.c (parse_partial_symbols)
9780         (handle_psymbol_enumerators): Update.
9781         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9782         * dbxread.c (read_dbx_symtab): Update.
9783         * psympriv.h (psymbol_placement): New enum.
9784         (add_psymbol_to_list): Update.
9785
9786 2019-01-10  Tom Tromey  <tom@tromey.com>
9787
9788         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9789         static_psymbols parameters.
9790         (scan_xcoff_symtab): Update.
9791         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9792         static_psymbols parameters.
9793         * psympriv.h (start_psymtab_common): Update.
9794         * mdebugread.c (parse_partial_symbols): Update.
9795         * dwarf2read.c (create_partial_symtab): Update.
9796         * dbxread.c (read_dbx_symtab): Update.
9797         (start_psymtab): Remove global_psymbols and static_psymbols
9798         parameters.
9799
9800 2019-01-10  Tom Tromey  <tom@tromey.com>
9801
9802         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9803         * psymtab.c (allocate_psymtab): Add comment.
9804         * psympriv.h (allocate_psymtab): Add comment.
9805         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9806         initializations.
9807         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9808
9809 2019-01-10  Tom Tromey  <tom@tromey.com>
9810
9811         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9812         Don't declare.
9813         * mipsread.c: Include mdebugread.h.
9814         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9815         Declare.
9816         * elfread.c: Include mdebugread.h.
9817
9818 2019-01-09  Tom Tromey  <tom@tromey.com>
9819
9820         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9821         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9822         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9823         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9824         (psym_lookup_symbol, psym_find_last_source_symtab)
9825         (psym_forget_cached_source_info, psym_print_stats)
9826         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9827         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9828         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9829         (psym_find_compunit_symtab_by_address)
9830         (maintenance_print_psymbols, maintenance_info_psymtabs)
9831         (maintenance_check_psymtabs): Use ranged for.
9832         * psymtab.h (class objfile_psymtabs): New.
9833         (require_partial_symbols): Return objfile_psymtabs.
9834         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9835
9836 2019-01-09  Tom Tromey  <tom@tromey.com>
9837
9838         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9839         (find_pc_mapped_section, list_overlays_command)
9840         (map_overlay_command, unmap_overlay_command)
9841         (simple_overlay_update): Use all_objfiles.
9842         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9843         * printcmd.c (info_symbol_command): Use all_objfiles.
9844         * objfiles.h (ALL_OBJSECTIONS): Remove.
9845         * maint.c (maintenance_translate_address): Use all_objfiles.
9846         * gcore.c (gcore_create_callback): Use all_objfiles.
9847         (objfile_find_memory_regions): Likewise.
9848
9849 2019-01-09  Tom Tromey  <tom@tromey.com>
9850
9851         * symtab.c (find_line_symtab, info_sources_command)
9852         (make_source_files_completion_list): Use objfile_compunits.
9853         * source.c (select_source_symtab): Use objfile_compunits.
9854         * objfiles.h (struct objfile): Update comment.
9855         (ALL_OBJFILES): Remove.
9856         (ALL_FILETABS): Remove.
9857         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9858         objfile_compunits.
9859
9860 2019-01-09  Tom Tromey  <tom@tromey.com>
9861
9862         * symmisc.c (print_objfile_statistics, dump_objfile)
9863         (maintenance_print_symbols): Use compunit_filetabs.
9864         * source.c (forget_cached_source_info_for_objfile): Use
9865         compunit_filetabs.
9866         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9867         (ALL_FILETABS): Use compunit_filetabs.
9868         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9869         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9870
9871 2019-01-09  Tom Tromey  <tom@tromey.com>
9872
9873         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9874         (compunit_filetabs): New.
9875         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9876         compunit_filetabs.
9877         (info_sources_command, make_source_files_completion_list): Remove
9878         declaration.
9879         * symmisc.c (print_objfile_statistics, dump_objfile)
9880         (maintenance_print_symbols): Remove declaration.
9881         (maintenance_info_symtabs): Use compunit_filetabs.
9882         (maintenance_info_line_tables): Likewise.
9883         * source.c (select_source_symtab): Change local variable name.
9884         (forget_cached_source_info_for_objfile): Remove declaration.
9885         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9886         * objfiles.c (objfile_relocate1): Remove declaration.
9887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9888         declaration.
9889         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9890         * coffread.c (coff_symtab_read): Remove declaration.
9891         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9892         compunit_filetabs.
9893
9894 2019-01-09  Tom Tromey  <tom@tromey.com>
9895
9896         * symtab.c (lookup_objfile_from_block)
9897         (find_pc_sect_compunit_symtab, search_symbols)
9898         (default_collect_symbol_completion_matches_break_on): Use
9899         objfile_compunits.
9900         * objfiles.h (ALL_COMPUNITS): Remove.
9901         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9902         * cp-support.c (add_symbol_overload_list_qualified): Use
9903         objfile_compunits.
9904         * ada-lang.c (ada_collect_symbol_completion_matches)
9905         (ada_add_global_exceptions): Use objfile_compunits.
9906
9907 2019-01-09  Tom Tromey  <tom@tromey.com>
9908
9909         * source.c (select_source_symtab)
9910         (forget_cached_source_info_for_objfile): Remove declaration.
9911         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9912         declaration.
9913         * maint.c (count_symtabs_and_blocks): Remove declaration.
9914         * cp-support.c (add_symbol_overload_list_qualified): Remove
9915         declaration.
9916         * coffread.c (coff_symtab_read): Remove declaration.
9917         * symtab.c (lookup_symbol_in_objfile_symtabs)
9918         (basic_lookup_transparent_type_1): Use objfile_compunits.
9919         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9920         (info_sources_command, search_symbols)
9921         (default_collect_symbol_completion_matches_break_on)
9922         (make_source_files_completion_list): Remove declaration.
9923         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9924         (ada_collect_symbol_completion_matches)
9925         (ada_add_global_exceptions): Remove declaration.
9926         * linespec.c (iterate_over_all_matching_symtabs): Use
9927         objfile_compunits.
9928         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9929         (class objfile_compunits): New.
9930         (ALL_COMPUNITS): Use objfile_compunits.
9931         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9932         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9933         objfile_compunits.
9934         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9935
9936 2019-01-09  Tom Tromey  <tom@tromey.com>
9937
9938         * symtab.c (search_symbols)
9939         (default_collect_symbol_completion_matches_break_on): Use
9940         objfile_msymbols.
9941         * ada-lang.c (ada_lookup_simple_minsym)
9942         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9943         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9944         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9945         objfile_msymbols.
9946         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9947         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9948         * objc-lang.c (find_methods): Use objfile_msymbols.
9949         (info_selectors_command, info_classes_command): Likewise.
9950         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9951         * objfiles.h (class objfile_msymbols): New.
9952         (ALL_OBJFILE_MSYMBOLS): Remove.
9953         (ALL_MSYMBOLS): Remove.
9954
9955 2019-01-09  Tom Tromey  <tom@tromey.com>
9956
9957         * common/next-iterator.h (next_adapter): Add Iterator template
9958         parameter.
9959         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9960         (class all_objfiles_safe): New.
9961         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9962         * objfiles.c (put_objfile_before): Update comment.
9963         (add_separate_debug_objfile): Likewise.
9964         (free_all_objfiles): Use all_objfiles_safe.
9965         (objfile_purge_solibs): Likewise.
9966
9967 2019-01-09  Tom Tromey  <tom@tromey.com>
9968
9969         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9970         (expand_symtab_containing_pc, lookup_static_symbol)
9971         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9972         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9973         all_objfiles.
9974         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9975         * breakpoint.c (create_overlay_event_breakpoint)
9976         (create_longjmp_master_breakpoint)
9977         (create_std_terminate_master_breakpoint)
9978         (create_exception_master_breakpoint): Use all_objfiles.
9979         * linux-thread-db.c (try_thread_db_load_from_pdir)
9980         (has_libpthread): Use all_objfiles.
9981         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9982         * linespec.c (iterate_over_all_matching_symtabs)
9983         (search_minsyms_for_name): Use all_objfiles.
9984         * maint.c (maintenance_info_sections): Use all_objfiles.
9985         * main.c (captured_main_1): Use all_objfiles.
9986         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9987         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9988         * guile/scm-pretty-print.c
9989         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9990         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9991         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9992         (maintenance_print_msymbols): Use all_objfiles.
9993         * source.c (select_source_symtab): Use all_objfiles.
9994         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9995         * symfile.c (remove_symbol_file_command)
9996         (expand_symtabs_matching, map_symbol_filenames): Use
9997         all_objfiles.
9998         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9999         all_objfiles.
10000         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10001         * objc-lang.c (find_methods): Use all_objfiles.
10002         * objfiles.c (have_partial_symbols, have_full_symbols)
10003         (have_minimal_symbols, qsort_cmp)
10004         (default_iterate_over_objfiles_in_search_order): Use
10005         all_objfiles.
10006         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10007         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10008         (maintenance_check_psymtabs): Use all_objfiles.
10009         (ALL_PSYMTABS): Remove.
10010         * compile/compile-object-run.c (do_module_cleanup): Use
10011         all_objfiles.
10012         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10013         * cp-support.c (add_symbol_overload_list_qualified): Use
10014         all_objfiles.
10015         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10016         Use all_objfiles.
10017         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10018         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10019         all_objfiles.
10020         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10021         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10022         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10023         Uses all_objfiles.
10024         * solib.c (solib_read_symbols): Use all_objfiles
10025
10026 2019-01-09  Tom Tromey  <tom@tromey.com>
10027
10028         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10029         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10030         all_objfiles.
10031         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10032         * symmisc.c (print_symbol_bcache_statistics)
10033         (print_objfile_statistics, maintenance_print_objfiles)
10034         (maintenance_info_symtabs, maintenance_check_symtabs)
10035         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10036         all_objfiles.
10037         * source.c (forget_cached_source_info): Use all_objfiles.
10038         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10039         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10040         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10041         * objfiles.c (update_section_map): Use all_objfiles.
10042         (shared_objfile_contains_address_p): Likewise.
10043         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10044         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10045
10046 2019-01-09  Tom Tromey  <tom@tromey.com>
10047
10048         * common/next-iterator.h: New file.
10049         * objfiles.h (class all_objfiles): New.
10050         (struct objfile_iterator): New.
10051
10052 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10053
10054         * NEWS: Move the description of the changed "frame", "select-frame",
10055          and "info frame" commands to the Changed commands section.
10056
10057 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10058
10059         * gdbtypes.c (check_stub_method_group): Remove handling of old
10060         mangling schemes.
10061         * linespec.c (find_methods): Likewise.
10062         * stabsread.c (read_member_functions): Likewise.
10063         * valops.c (search_struct_method): Likewise.
10064         (value_struct_elt_for_reference): Likewise.
10065         * NEWS: Mention this change.
10066
10067 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10068
10069         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10070         print_source_lines.
10071         * source.c (print_source_lines_base): Update line number check.
10072         (print_source_lines): New function.
10073         (source_lines_range::source_lines_range): New function.
10074         * source.h (class source_lines_range): New class.
10075         (print_source_lines): New declaration.
10076
10077 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10078
10079         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10080
10081 2019-01-08  Tom Tromey  <tom@tromey.com>
10082             Simon Marchi  <simon.marchi@ericsson.com>
10083
10084         PR gdb/24060
10085         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10086         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10087         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10088         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10089         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10090         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10091
10092 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10093
10094         * source.c (select_source_symtab): Move header comment to
10095         declaration in source.h.
10096         (forget_cached_source_info_for_objfile): Likewise.
10097         (forget_cached_source_info): Likewise.
10098         (identify_source_line): Likewise.
10099         * source.h (identify_source_line): Move declaration from symtab.h
10100         and add comment from source.c
10101         (print_source_lines): Likewise.
10102         (forget_cached_source_info_for_objfile): Likewise.
10103         (forget_cached_source_info): Likewise.
10104         (select_source_symtab): Likewise.
10105         (enum print_source_lines_flag): Move definition from symtab.h.
10106         * symtab.h (identify_source_line): Move declaration to source.h.
10107         (print_source_lines): Likewise.
10108         (forget_cached_source_info_for_objfile): Likewise.
10109         (forget_cached_source_info): Likewise.
10110         (select_source_symtab): Likewise.
10111         (enum print_source_lines_flag): Move definition to source.h.
10112         * tui/tui-hooks.c: Add 'source.h' include.
10113
10114 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10115
10116         * source.c (print_source_lines_base): Handle requests to print
10117         reverse line number sequences, and guard against empty lines
10118         string.
10119
10120 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10121
10122         * source.c (print_source_lines_base): Fix skip of '\r' if next
10123         character is '\n'.
10124
10125 2019-01-06  Tom Tromey  <tom@tromey.com>
10126
10127         * c-exp.y (struct c_parse_state) <macro_original_text,
10128         expansion_obstack>: New member.
10129         (macro_original_text, expansion_obstack): Remove globals.
10130         (scan_macro_expansion, scanning_macro_expansion)
10131         (finished_macro_expansion): Update.
10132         (scan_macro_cleanup): Remove.
10133         (yylex, c_parse): Update.
10134
10135 2019-01-06  Tom Tromey  <tom@tromey.com>
10136
10137         * c-exp.y (struct c_parse_state) <strings>: New member.
10138         (operator_stoken): Update.
10139
10140 2019-01-06  Tom Tromey  <tom@tromey.com>
10141
10142         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10143         (union type_stack_elt) <typelist_val>: Now a pointer to
10144         std::vector.
10145         (type_stack_cleanup): Don't declare.
10146         (push_typelist): Update.
10147         * parse.c (pop_typelist): Return a std::vector.
10148         (push_typelist): Take a std::vector.
10149         (follow_types): Update.  Do not free args.
10150         (type_stack_cleanup): Remove.
10151         * c-exp.y (struct c_parse_state): New.
10152         (cpstate): New global.
10153         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10154         (nonempty_typelist): Update.
10155         (func_mod): Create a new vector.
10156         (c_parse): Create a c_parse_state.
10157         (check_parameter_typelist): Do not delete params.
10158         (function_method): Update.  Do not delete type_list.
10159
10160 2019-01-06  Tom Tromey  <tom@tromey.com>
10161
10162         PR gdb/28155:
10163         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10164         check_typedef.
10165         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10166         (print_return_value): Likewise.
10167
10168 2019-01-05  Tom Tromey  <tom@tromey.com>
10169
10170         * contrib/cleanup_check.py: Remove.
10171         * contrib/gcc-with-excheck: Remove.
10172         * contrib/exsummary.py: Remove.
10173         * contrib/excheck.py: Remove.
10174
10175 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10176
10177         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10178         NULL. Initialize tpprev to NULL instead of assigning it
10179         to NULL on the next statement.
10180         * windows-nat.c (windows_delete_thread): Remove check for
10181         main_thread_id before printing thread exit notifications.
10182         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10183         Remove thread ID check against main_thread_id.
10184         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10185         windows_delete_thread.
10186         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10187
10188 2019-01-04  Tom Tromey  <tom@tromey.com>
10189
10190         * compile/compile.c (_initialize_compile): Use upper case for
10191         metasyntactic variables.
10192         * symmisc.c (_initialize_symmisc): Use upper case for
10193         metasyntactic variables.
10194         * psymtab.c (_initialize_psymtab): Use upper case for
10195         metasyntactic variables.
10196         * demangle.c (demangle_command): Use upper case for metasyntactic
10197         variables.
10198         (_initialize_demangler): Likewise.
10199         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10200         variables.
10201
10202 2019-01-03  Tom Tromey  <tom@tromey.com>
10203
10204         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10205
10206 2019-01-03  Tom Tromey  <tom@tromey.com>
10207
10208         * python/py-symtab.c (salpy_str): Update.
10209         (struct salpy_sal_object) <symtab>: Now a PyObject.
10210         (salpy_dealloc): Update.
10211         (del_objfile_sal): Use gdbpy_ref.
10212
10213 2019-01-03  Tom Tromey  <tom@tromey.com>
10214
10215         * python/py-type.c (convert_field): Use new_reference.  Return
10216         gdbpy_ref.
10217         (make_fielditem): Return gdbpy_ref.
10218         (typy_fields): Update.
10219         (typy_getitem): Update.
10220         (field_name): Return gdbpy_ref.  Use new_reference.
10221         (typy_iterator_iternext): Update.
10222
10223 2019-01-03  Tom Tromey  <tom@tromey.com>
10224
10225         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10226
10227 2019-01-03  Tom Tromey  <tom@tromey.com>
10228
10229         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10230         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10231         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10232         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10233         (pspy_set_type_printers): Likewise.
10234         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10235         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10236         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10237         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10238         (objfpy_set_type_printers): Likewise.
10239
10240 2019-01-03  Tom Tromey  <tom@tromey.com>
10241
10242         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10243         (gdbpy_print_stack): Use gdbpy_err_fetch.
10244         * python/python-internal.h (class gdbpy_err_fetch): New class.
10245         (class gdbpy_enter) <m_error_type, m_error_value,
10246         m_error_traceback>: Remove.
10247         <m_error>: New member.
10248         (gdbpy_exception_to_string): Don't declare.
10249         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10250         * python/py-value.c (convert_value_from_python): Use
10251         gdbpy_err_fetch.
10252         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10253         gdbpy_exception_to_string.
10254         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10255         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10256         gdbpy_err_fetch.
10257
10258 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10259
10260         * linux-nat.c (delete_lwp_cleanup): Delete.
10261         (struct lwp_deleter): New struct.
10262         (lwp_info_up): New typedef.
10263         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10264         lwp_info_up.
10265
10266 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10267
10268         * linux-fork.c (class scoped_switch_fork_info): New class.
10269         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10270
10271 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * valops.c (find_overload_match): Remove use of null_cleanup, and
10274         calls to do_cleanups.
10275
10276 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10277
10278         * compile/compile-cplus-types.c
10279         (compile_cplus_instance::decl_name): Handle changes to
10280         cp_func_name.
10281         * cp-support.c (cp_func_name): Update header comment, update
10282         return type.
10283         * cp-support.h (cp_func_name): Update return type in declaration.
10284         * valops.c (find_overload_match): Move temp_func local to top
10285         level of function and change its type.  Use temp_func to hold and
10286         delete temporary string obtained from cp_func_name.
10287
10288 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10289
10290         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10291         gdb::char_vector, remove cleanup, and update uses of `msg`.
10292
10293 2019-01-03  Jim Wilson  <jimw@sifive.com>
10294
10295         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10296
10297 2019-01-02  Tom Tromey  <tom@tromey.com>
10298
10299         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10300         (tdesc_parse_xml): Remove cleanups.
10301         * target-descriptions.h (make_cleanup_free_target_description):
10302         Don't declare.
10303         (target_desc_deleter): New struct.
10304         (target_desc_up): New typedef.
10305         * target-descriptions.c (target_desc_deleter::operator()): Rename
10306         from free_target_description.
10307         (make_cleanup_free_target_description): Remove.
10308
10309 2019-01-02  Tom Tromey  <tom@tromey.com>
10310
10311         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10312         constructor, destructor.
10313         (linespec_parser): Remove typedef.
10314         (~linespec_parser): Rename from linespec_parser_delete.
10315         (linespec_lex_to_end, linespec_complete_label)
10316         (linespec_complete): Update.
10317         (decode_line_full): Remove cleanups.
10318         (decode_line_1): Update.
10319
10320 2019-01-02  Tom Tromey  <tom@tromey.com>
10321
10322         * python/python-internal.h (inferior_to_inferior_object): Change
10323         return type.
10324         * python/py-exitedevent.c (create_exited_event_object): Update.
10325         * python/py-inferior.c (inferior_to_inferior_object): Return
10326         gdbpy_ref.
10327         (python_new_inferior, python_inferior_deleted)
10328         (thread_to_thread_object, delete_thread_object)
10329         (build_inferior_list, gdbpy_selected_inferior): Update.
10330         * python/py-infthread.c (create_thread_object): Update.  Also fail
10331         if inferior_to_inferior_object fails.
10332
10333 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10334
10335         * inferior.h (class inferior) <displaced_step_state>: New field.
10336         * infrun.h (struct displaced_step_state): Move here from
10337         infrun.c.  Initialize fields, add constructor.
10338         <inf>: Remove field.
10339         <reset>: New method.
10340         * infrun.c (struct displaced_step_inferior_state): Move to
10341         infrun.h.
10342         (displaced_step_inferior_states): Remove.
10343         (get_displaced_stepping_state): Adust.
10344         (displaced_step_in_progress_any_inferior): Adjust.
10345         (displaced_step_in_progress_thread): Adjust.
10346         (displaced_step_in_progress): Adjust.
10347         (add_displaced_stepping_state): Remove.
10348         (get_displaced_step_closure_by_addr): Adjust.
10349         (remove_displaced_stepping_state): Remove.
10350         (infrun_inferior_exit): Call displaced_step_state.reset.
10351         (use_displaced_stepping): Don't check for NULL.
10352         (displaced_step_prepare_throw): Call
10353         get_displaced_stepping_state.
10354         (displaced_step_fixup): Don't check for NULL.
10355         (prepare_for_detach): Don't check for NULL.
10356
10357 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10358
10359         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10360          in case of call that did not complete.
10361
10362 2019-01-02  Andrey Utkin  <autkin@undo.io>
10363
10364         * symfile.c (find_separate_debug_file): Fix search of debug files for
10365         remote debuggee.
10366
10367 2019-01-02  Tom Tromey  <tom@tromey.com>
10368
10369         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10370         indentation.
10371         * python/py-frame.c (frapy_older): Remove cast.
10372         (frapy_newer): Likewise.
10373         * python/py-breakpoint.c (local_setattro): Remove cast.
10374         * python/py-arch.c (archpy_name): Remove local variable.
10375         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10376
10377 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10378
10379         * unittests/basic_string_view/element_access/char/empty.cc:
10380         Fix year range in copyright header.
10381
10382 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10385         Delete.
10386         <operator==>: Update with for removed field.
10387         <hash>: Likewise.
10388         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10389         <isa_features>: ...this.
10390         <abi_features>: New field.
10391         (riscv_isa_flen): Update comment.
10392         (riscv_abi_xlen): New declaration.
10393         (riscv_abi_flen): New declaration.
10394         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10395         isa_features.
10396         (riscv_abi_xlen): New function.
10397         (riscv_isa_flen): Update to get answer from isa_features.
10398         (riscv_abi_flen): New function.
10399         (riscv_has_fp_abi): Update to get answer from abi_features.
10400         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10401         xlen and flen.
10402         (riscv_call_info) <xlen, flen>: Update comment.
10403         (riscv_call_arg_struct): Remove invalid assertions
10404         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10405         is removed.
10406         (riscv_gdbarch_init): Gather isa features and abi features
10407         separately, ensure both match on the gdbarch when reusing an old
10408         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10409         a target with 64-bit float hardware.
10410
10411 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10412
10413         * source.c (search_command_helper): Stop reverse search
10414         when line 1 has been searched.
10415
10416 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10417
10418         * record-full.c (record_full_base_target::close): Rewrite
10419         record_full_core_buf_list free logic.
10420
10421 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10422
10423         * break-catch-syscall.c (print_one_catch_syscall): xfree
10424         the last text.
10425
10426 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10427
10428         * top.c (print_gdb_version): Update Copyright year in version
10429         message.
10430
10431 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10432
10433         Update copyright year range in all GDB files.
10434
10435 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10436
10437         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10438
10439 For older changes see ChangeLog-2018.
10440 \f
10441 Local Variables:
10442 mode: change-log
10443 left-margin: 8
10444 fill-column: 74
10445 version-control: never
10446 coding: utf-8
10447 End:
10448