Remove interp_name
[external/binutils.git] / gdb / ChangeLog
1 2018-05-25  Tom Tromey  <tom@tromey.com>
2
3         * interps.c (interp_name): Remove.
4         * mi/mi-interp.c (mi_interp::init): Update.
5         * interps.h (interp_name): Remove.
6         (~scoped_restore_interp): Update.
7         * tui/tui.c (tui_enable): Update.
8
9 2018-05-25  Tom Tromey  <tom@tromey.com>
10
11         * utils.c (fputs_maybe_filtered): Update.
12         * linespec.c (decode_line_full): Update.
13         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
14         (mi_print_breakpoint_for_event, mi_solib_loaded)
15         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
16         (mi_user_selected_context_changed): Update.
17         * mi/mi-main.c (mi_execute_command): Update.
18         * cli/cli-script.c (execute_control_command): Update.
19         * python/python.c (execute_gdb_command): Update.
20         * solib.c (info_sharedlibrary_command): Update.
21         * interps.c (interp_ui_out): Remove.
22         * interps.h (interp_ui_out): Remove.
23
24 2018-05-25  Tom Tromey  <tom@tromey.com>
25
26         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
27         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
28         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
29
30 2018-05-25  Tom Tromey  <tom@tromey.com>
31
32         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
33         * interps.c (interp_exec): Use scoped_restore.
34
35 2018-05-25  Tom Tromey  <tom@tromey.com>
36
37         * remote.c (remote_target::remote_file_get): Use
38         gdb::byte_vector.
39         (remote_target::remote_file_put): Likewise.
40
41 2018-05-25  Tom Tromey  <tom@tromey.com>
42
43         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
44         a std::string.
45         (get_pe_section_index, add_pe_exported_sym): Update.
46         (read_pe_exported_syms): Use gdb::def_vector.
47
48 2018-05-25  Tom Tromey  <tom@tromey.com>
49
50         * frame.c (remove_prev_frame): Remove.
51         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
52
53 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
54
55         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
56         Remove prototypes.
57         * mips-linux-nat.c (supply_fpregset): Always call
58         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
59         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
60         `mips_fill_fpregset'.
61         * mips-linux-tdep.c (mips_supply_fpregset)
62         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
63         (mips_fill_fpregset_wrapper): Remove functions.
64         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
65         (mips_linux_fpregset): Remove variable.
66         (mips_linux_iterate_over_regset_sections): Use
67         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
68         (mips_linux_o32_sigframe_init): Remove comment.
69
70 2018-05-25  Pedro Alves  <palves@redhat.com>
71
72         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
73         (struct readahead_cache, struct packet_reg, struct
74         remote_arch_state, class remote_state): Move higher up in the
75         file.
76         (remote_target::m_remote_state): Now an object instead of a pointer.
77         (remote_target::get_remote_state): Adjust.
78
79 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
80
81         * stack.c (select_and_print_frame): Delete.
82         (struct function_bounds): Move struct within function.
83         (func_command): Most content moved into new function
84         find_frame_for_function, use new function, print result, add
85         function comment.
86         (find_frame_for_function): New function, now returns a result.
87
88 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
89
90         * stack.c (iterate_over_block_arg_vars): Fix comment.
91         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
92
93 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
94
95         PR gdb/23203
96         * frame.c
97         (scoped_restore_selected_frame::scoped_restore_selected_frame):
98         Define.
99         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
100         Define.
101         * frame.h (class scoped_restore_selected_frame): New class.
102         * stack.c (print_frame_local_vars): Remove catching and rethrowing
103         of any exception, use scoped_restore_selected_frame to restore the
104         frame instead.
105
106 2018-05-24  Pedro Alves  <palves@redhat.com>
107
108         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
109         override.
110
111 2018-05-23  Tom Tromey  <tom@tromey.com>
112
113         * complaints.c (struct complaints): Remove.
114         (symfile_complaint_book): Remove.
115         (series): New global.
116         (complaint_internal): Update.
117         (clear_complaints): Update.
118
119 2018-05-23  Tom Tromey  <tom@tromey.com>
120
121         * complaints.c (counters): New global.
122         (struct complain): Remove.
123         (struct complaints) <root>: Remove.
124         (complaint_sentinel): Remove.
125         (symfile_complaint_book): Update.
126         (find_complaint) Remove.
127         (complaint_internal, clear_complaints): Update.
128
129 2018-05-23  Tom Tromey  <tom@tromey.com>
130
131         * complaints.c (struct complain) <file, line>: Remove.
132         (find_complaint): Remove file, line parameters.
133         (complaint_internal): Update.
134
135 2018-05-23  Tom Tromey  <tom@tromey.com>
136
137         * complaints.c (vcomplaint): Remove.
138         (complaint_internal) Merge in contents of vcomplaint.
139
140 2018-05-23  Tom Tromey  <tom@tromey.com>
141
142         * complaints.c (struct complaints) <explanation>: Remove.
143         (symfile_explanations): Remove.
144         (symfile_complaint_book): Update.
145         (vcomplaint): Update.
146         (struct explanation): Remove.
147
148 2018-05-23  Tom Tromey  <tom@tromey.com>
149
150         * complaints.c (symfile_complaints): Remove.
151         (complaint_internal): Remove "complaints" parameter.
152         (clear_complaints, vcomplaint): Remove "c" parameter.
153         (get_complaints): Remove.
154         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
155         (dwarf2_debug_line_missing_file_complaint)
156         (dwarf2_debug_line_missing_end_sequence_complaint)
157         (dwarf2_complex_location_expr_complaint)
158         (dwarf2_const_value_length_mismatch_complaint)
159         (dwarf2_section_buffer_overflow_complaint)
160         (dwarf2_macro_malformed_definition_complaint)
161         (dwarf2_invalid_attrib_class_complaint)
162         (create_addrmap_from_index, dw2_symtab_iter_next)
163         (dw2_expand_marked_cus)
164         (dw2_debug_names_iterator::find_vec_in_debug_names)
165         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
166         (create_debug_type_hash_table, init_cutu_and_read_dies)
167         (partial_die_parent_scope, add_partial_enumeration)
168         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
169         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
170         (read_import_statement, read_file_scope, create_dwo_cu_reader)
171         (create_cus_hash_table, create_dwp_hash_table)
172         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
173         (dwarf2_rnglists_process, dwarf2_ranges_process)
174         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
175         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
176         (handle_struct_member_die, process_structure_scope)
177         (read_array_type, read_common_block, read_module_type)
178         (read_tag_pointer_type, read_typedef, read_base_type)
179         (read_subrange_type, load_partial_dies, partial_die_info::read)
180         (partial_die_info::read, partial_die_info::read)
181         (partial_die_info::read, read_checked_initial_length_and_offset)
182         (dwarf2_string_attr, read_formatted_entries)
183         (dwarf_decode_line_header)
184         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
185         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
186         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
187         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
188         (get_signatured_type, get_DW_AT_signature_type)
189         (decode_locdesc, file_file_name, consume_improper_spaces)
190         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
191         (dwarf_decode_macro_bytes, dwarf_decode_macros)
192         (dwarf2_symbol_mark_computed, set_die_type)
193         (read_attribute_value): Update.
194         * stap-probe.c (handle_stap_probe, get_stap_base_address):
195         Update.
196         * dbxread.c (unknown_symtype_complaint)
197         (lbrac_mismatch_complaint, repeated_header_complaint)
198         (set_namestring, function_outside_compilation_unit_complaint)
199         (read_dbx_symtab, process_one_symbol): Update.
200         * gdbtypes.c (stub_noname_complaint): Update.
201         * windows-nat.c (handle_unload_dll): Update.
202         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
203         (decode_base_type): Update.
204         * xcoffread.c (bf_notfound_complaint, ef_complaint)
205         (eb_complaint, record_include_begin, record_include_end)
206         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
207         (process_xcoff_symbol, read_symbol)
208         (function_outside_compilation_unit_complaint)
209         (scan_xcoff_symtab): Update.
210         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
211         * buildsym.c (finish_block_internal, make_blockvector)
212         (end_symtab_get_static_block, augment_type_symtab): Update.
213         * dtrace-probe.c (dtrace_process_dof)
214         (dtrace_static_probe_ops::get_probes): Update.
215         * complaints.h (struct complaint): Don't declare.
216         (symfile_complaints): Remove.
217         (complaint_internal): Remove "complaints" parameter.
218         (complaint): Likewise.
219         (clear_complaints): Likewise.
220         * symfile.c (syms_from_objfile_1, finish_new_objfile)
221         (reread_symbols): Update.
222         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
223         (dwarf2_frame_cache, decode_frame_entry): Update.
224         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
225         * objc-lang.c (lookup_objc_class, lookup_child_selector)
226         (info_selectors_command): Update.
227         * macrotab.c (macro_include, check_for_redefinition)
228         (macro_undef): Update.
229         * objfiles.c (filter_overlapping_sections): Update.
230         * stabsread.c (invalid_cpp_abbrev_complaint)
231         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
232         (define_symbol, error_type, read_type, rs6000_builtin_type)
233         (stabs_method_name_from_physname, read_member_functions)
234         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
235         (attach_fields_to_type, complain_about_struct_wipeout)
236         (read_range_type, read_args, common_block_start)
237         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
238         Update.
239         * mdebugread.c (index_complaint, unknown_ext_complaint)
240         (basic_type_complaint, bad_tag_guess_complaint)
241         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
242         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
243         (parse_procedure, parse_lines)
244         (function_outside_compilation_unit_complaint)
245         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
246         (bad_tag_guess_complaint, reg_value_complaint): Update.
247         * cp-support.c (demangled_name_complaint): Update.
248         * macroscope.c (sal_macro_scope): Update.
249         * dwarf-index-write.c (class debug_names): Update.
250
251 2018-05-23  Tom Tromey  <tom@tromey.com>
252
253         * complaints.c (clear_complaints): Remove "noisy" parameter.
254         * complaints.h (clear_complaints): Update.
255         * symfile.c (syms_from_objfile_1, finish_new_objfile)
256         (reread_symbols): Update.
257
258 2018-05-23  Tom Tromey  <tom@tromey.com>
259
260         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
261         SUBSEQUENT_MESSAGE.
262         (vcomplaint, clear_complaints): Update.
263         (symfile_explanations): Remove some messages.
264
265 2018-05-23  Tom Tromey  <tom@tromey.com>
266
267         * complaints.c (internal_complaint): Remove.
268         * complaints.h (internal_complaint): Remove.
269
270 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
271
272         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
273
274 2018-05-22  Pedro Alves  <palves@redhat.com>
275
276         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
277         (remote_fileio_badfd, remote_fileio_return_errno)
278         (remote_fileio_return_success, remote_fileio_func_open)
279         (remote_fileio_func_open, remote_fileio_func_close)
280         (remote_fileio_func_read, remote_fileio_func_write)
281         (remote_fileio_func_lseek, remote_fileio_func_rename)
282         (remote_fileio_func_unlink, remote_fileio_func_stat)
283         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
284         (remote_fileio_func_isatty, remote_fileio_func_system): Add
285         remote_target parameter.
286         (remote_fio_func_map) <func>: Add remote_target parameter.
287         (do_remote_fileio_request, remote_fileio_request):
288         * remote-fileio.h (remote_fileio_request):
289         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
290         remote_target parameter.
291         (remote_notif_process, handle_notification): Adjust to pass down
292         the remote.
293         (remote_notif_state_allocate): Add remote_target parameter.  Save
294         it.
295         * remote-notif.h (struct remote_target): Forward declare.
296         (struct notif_client) <parse, ack, can_get_pending_events>: Add
297         remote_target parameter.
298         (struct remote_notif_state) <remote>: New field.
299         (remote_notif_ack, remote_notif_parse): Add remote_target
300         parameter.
301         (remote_notif_state_allocate, remote_notif_state_allocate): Add
302         remote_target parameter.
303         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
304         (threads_listing_context, rmt_thread_action, protocol_feature)
305         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
306         (packet_result, struct threads_listing_context, remote_state):
307         Move definitions and declarations higher up.
308         (remote_target) <~remote_target>: Declare.
309         (remote_download_command_source, remote_file_put, remote_file_get)
310         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
311         (remote_hostio_pread_vFile, remote_hostio_send_command)
312         (remote_hostio_set_filesystem, remote_hostio_open)
313         (remote_hostio_close, remote_hostio_unlink, remote_state)
314         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
315         (get_memory_write_packet_size, get_memory_read_packet_size)
316         (append_pending_thread_resumptions, remote_detach_1)
317         (append_resumption, remote_resume_with_vcont)
318         (add_current_inferior_and_thread, wait_ns, wait_as)
319         (process_stop_reply, remote_notice_new_inferior)
320         (process_initial_stop_replies, remote_add_thread)
321         (btrace_sync_conf, remote_btrace_maybe_reopen)
322         (remove_new_fork_children, kill_new_fork_children)
323         (discard_pending_stop_replies, stop_reply_queue_length)
324         (check_pending_events_prevent_wildcard_vcont)
325         (discard_pending_stop_replies_in_queue, stop_reply)
326         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
327         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
328         (remote_interrupt_as, remote_interrupt_ns)
329         (remote_get_noisy_reply, remote_query_attached)
330         (remote_add_inferior, remote_current_thread, get_current_thread)
331         (set_thread, set_general_thread, set_continue_thread)
332         (set_general_process, write_ptid)
333         (remote_unpack_thread_info_response, remote_get_threadinfo)
334         (parse_threadlist_response, remote_get_threadlist)
335         (remote_threadlist_iterator, remote_get_threads_with_ql)
336         (remote_get_threads_with_qxfer)
337         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
338         (get_offsets, remote_check_symbols, remote_supported_packet)
339         (remote_query_supported, remote_packet_size)
340         (remote_serial_quit_handler, remote_detach_pid)
341         (remote_vcont_probe, remote_resume_with_hc)
342         (send_interrupt_sequence, interrupt_query)
343         (remote_notif_get_pending_events, fetch_register_using_p)
344         (send_g_packet, process_g_packet, fetch_registers_using_g)
345         (store_register_using_P, store_registers_using_G)
346         (set_remote_traceframe, check_binary_download)
347         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
348         (remote_xfer_live_readonly_partial, remote_read_bytes)
349         (remote_send_printf, remote_flash_write, readchar)
350         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
351         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
352         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
353         (extended_remote_disable_randomization, extended_remote_run)
354         (send_environment_packet, extended_remote_environment_support)
355         (extended_remote_set_inferior_cwd, remote_write_qxfer)
356         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
357         (packet_command): Now methods of ...
358         (remote_target): ... this class.
359         (m_remote_state) <remote_target>: New field.
360         (struct remote_state) <stop_reply_queue,
361         remote_async_inferior_event_token, wait_forever_enabled_p>: New
362         fields.
363         (remote_state::remote_state): Allocate stop_reply_queue.
364         (remote_state): Delete global.
365         (get_remote_state_raw): Delete.
366         (remote_target::get_remote_state): Allocate m_remote_state on
367         demand.
368         (get_current_remote_target): New.
369         (remote_ops, extended_remote_ops): Delete.
370         (wait_forever_enabled_p, remote_async_inferior_event_token):
371         Delete, moved to struct remote_state.
372         (remote_target::close): Delete self.  Destruction bits split to
373         ...
374         (remote_target::~remote_target): ... this.
375         (show_memory_packet_size): Adjust to use
376         get_current_remote_target.
377         (struct protocol_feature) <func>: Add remote_target parameter.
378         All callers adjusted.
379         (curr_quit_handler_target): New.
380         (remote_serial_quit_handler): Reimplement.
381         (remote_target::open_1): Adjust to use get_current_remote_target.
382         Heap-allocate remote_target/extended_remote_target instances.
383         (vcont_builder::vcont_builder): Add remote_target parameter, and
384         save it in m_remote.  All callers adjusted.
385         (vcont_builder::m_remote): New field.
386         (vcont_builder::restart, vcont_builder::flush)
387         (vcont_builder::push_action): Use it.
388         (remote_target::commit_resume): Use it.
389         (struct queue_iter_param) <remote>: New field.
390         (remote_target::remove_new_fork_children): Fill in 'remote' field.
391         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
392         (check_pending_event_prevents_wildcard_vcont_callback)
393         (remote_target::check_pending_events_prevent_wildcard_vcont)
394         (remote_target::discard_pending_stop_replies)
395         (remote_target::discard_pending_stop_replies_in_queue)
396         (remote_target::remote_notif_remove_queued_reply): Fill in
397         'remote' field.
398         (remote_notif_get_pending_events): New.
399         (remote_target::readchar, remote_target::remote_serial_write):
400         Save/restore curr_quit_handler_target.
401         (putpkt): New.
402         (kill_new_fork_children): Fill in 'remote' field.
403         (packet_command): Use get_current_remote_target, defer to
404         remote_target method of same name.
405         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
406         parameter, and save it in m_remote.  All callers adjusted.
407         (scoped_remote_fd::release): Use m_remote.
408         (scoped_remote_fd::m_remote): New field.
409         (remote_file_put, remote_file_get, remote_file_delete): Use
410         get_current_remote_target, defer to remote_target method of same
411         name.
412         (remote_btrace_reset): Add remote_state paremeter.  Update all
413         callers.
414         (remote_async_inferior_event_handler). Pass down 'data'.
415         (remote_new_objfile): Use get_current_remote_target.
416         (remote_target::vcont_r_supported): New.
417         (set_range_stepping): Use get_current_remote_target and
418         remote_target::vcont_r_supported.
419         (_initialize_remote): Don't allocate 'remote_state' and
420         'stop_reply_queue' globals.
421         * remote.h (struct remote_target): Forward declare.
422         (getpkt, putpkt, remote_notif_get_pending_events): Add
423         'remote_target' parameter.
424
425 2018-05-22  Pedro Alves  <palves@redhat.com>
426
427         * remote.c (vcont_builder): Now a class.  Make all data members
428         private.
429         (vcont_builder) <vcont_builder, restart, flush, push_action>:
430         Declare methods.
431         (vcont_builder_restart): Rename to ...
432         (vcont_builder::restart): ... this.
433         (vcont_builder_flush): Rename to ...
434         (vcont_builder::flush): ... this.
435         (vcont_builder_push_action): Rename to ...
436         (vcont_builder::push_action): ... this.
437         (remote_target::commit_resume): Adjust.
438
439 2018-05-22  Pedro Alves  <palves@redhat.com>
440
441         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
442         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
443         (get_fixed_memory_packet_size): New.
444         (get_memory_packet_size): Use it.
445         (set_memory_packet_size): Don't override the config size with
446         DEFAULT_MAX_MEMORY_PACKET_SIZE.
447         (show_memory_packet_size): Use get_fixed_memory_packet_size.
448         Don't refer to get_memory_packet_size if not connected to a remote
449         target.  Show "(default)" if configured size is 0.
450
451 2018-05-22  Pedro Alves  <palves@redhat.com>
452
453         * remote.c (remote_target::mourn_inferior): Move
454         discard_pending_stop_replies call here from ...
455         (_initialize_remote): ... here.
456
457 2018-05-22  Pedro Alves  <palves@redhat.com>
458
459         * remote.c (compare_section_command): Remove set_general_process
460         call.
461
462 2018-05-22  Pedro Alves  <palves@redhat.com>
463
464         * remote.c (struct packet_reg, struct remote_arch_state):
465         Move higher up in the file.
466         (remote_state) <m_arch_states>: Store remote_arch_state values
467         instead of remote_arch_state pointers.
468         (remote_state::get_remote_arch_state): Adjust.
469
470 2018-05-22  Pedro Alves  <palves@redhat.com>
471
472         * remote.c: Include <unordered_map>.
473         (remote_state): Now a class.
474         (remote_state) <get_remote_arch_state>: Declare method.
475         <get_remote_arch_state>: New field.
476         (remote_arch_state) <remote_arch_state>: Declare ctor.
477         <regs>: Now a unique_ptr.
478         (remote_gdbarch_data_handle): Delete.
479         (get_remote_arch_state): Delete.
480         (remote_state::get_remote_arch_state): New.
481         (get_remote_state): Adjust to call remote_state's
482         get_remote_arch_state method.
483         (init_remote_state): Delete, bits factored out to ...
484         (remote_arch_state::remote_arch_state): ... this new method.
485         (get_remote_packet_size, get_memory_packet_size)
486         (process_g_packet, remote_target::fetch_registers)
487         (remote_target::prepare_to_store, store_registers_using_G)
488         (remote_target::store_registers, remote_target::get_trace_status):
489         Adjust to call remote_state's method.
490         (_initialize_remote): Remove reference to
491         remote_gdbarch_data_handle.
492
493 2018-05-22  Pedro Alves  <palves@redhat.com>
494
495         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
496         pread>: New method declarations.
497         (remote_target::open_1): Adjust.
498         (readahead_cache_invalidate): Rename to ...
499         (readahead_cache::invalidate): ... this, and adjust to be a class
500         method.
501         (readahead_cache_invalidate_fd): Rename to ...
502         (readahead_cache::invalidate_fd): ... this, and adjust to be a
503         class method.
504         (remote_hostio_pwrite): Adjust.
505         (remote_hostio_pread_from_cache): Rename to ...
506         (readahead_cache::pread): ... this, and adjust to be a class
507         method.
508         (remote_hostio_close): Adjust.
509
510 2018-05-22  Pedro Alves  <palves@redhat.com>
511
512         * remote.c (remote_hostio_close_cleanup): Delete.
513         (class scoped_remote_fd): New.
514         (remote_file_put, remote_file_get): Use it.
515
516 2018-05-22  Pedro Alves  <palves@redhat.com>
517
518         (struct vCont_action_support): Use bool and initialize all fields.
519         (struct readahead_cache): Initialize all fields.
520         (remote_state): Use bool and initialize all fields.
521         (remote_state::remote_state, remote_state::~remote_state): New.
522         (new_remote_state): Delete.
523         (_initialize_remote): Use new to allocate remote_state.
524
525 2018-05-22  Pedro Alves  <palves@redhat.com>
526             張俊芝  <zjz@zjz.name>
527
528         PR gdb/22973
529         * c-exp.y: Include "c-support.h".
530         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
531         of tolower.  Use c_ident_is_alpha to scan names.
532         * c-lang.c: Include "c-support.h".
533         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
534         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
535         * c-support.h: New file, with bits factored out from ...
536         * cp-name-parser.y: ... this file.
537         Include "c-support.h".
538         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
539         c-support.h and renamed.
540         (symbol_end, yylex): Adjust.
541
542 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
543
544         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
545         parameter type to CORE_ADDR.
546         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
547         parameter type in declaration to CORE_ADDR.
548         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
549         target_auxv_search to get AT_HWCAP and use the result to get the
550         target description.
551         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
552         to CORE_ADDR. Remove the cast of the return value to unsigned
553         long. Fix error predicate of target_auxv_search.
554         (ppc_linux_nat_target::read_description): Change the type of the
555         hwcap variable to CORE_ADDR.
556
557 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
558
559         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
560         if the size of fpscr is larger than 32 bits.
561
562 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
563
564         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
565         (ppc32_linux_vsxregmap): New global.
566         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
567         regcache_supply_regset, and regcache_collect_regset.
568         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
569         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
570         (fetch_vsx_register, store_vsx_register): Remove.
571         (fetch_vsx_registers): Add regno parameter. Get regset using
572         ppc_linux_vsxregset. Use regset to supply registers.
573         (store_vsx_registers): Add regno parameter. Get regset using
574         ppc_linux_vsxregset. Use regset to collect registers.
575         (fetch_register): Call fetch_vsx_registers instead of
576         fetch_vsx_register.
577         (store_register): Call store_vsx_registers instead of
578         store_vsx_register.
579         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
580         new regno parameter.
581         (store_ppc_registers): Call store_vsx_registers with -1 for the
582         new regno parameter.
583         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
584         (ppc_collect_vsxregset): Remove.
585
586 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
587
588         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
589         offset fields.
590         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
591         for vector register offset fields.
592         (ppc64_fbsd_reg_offsets): Likewise.
593         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
594         to vector register offset fields.
595         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
596         to vector register offset fields.
597         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
598         vector register offset fields.
599         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
600         initializers for vector register offset fields.
601         (rs6000_aix64_reg_offsets): Likewise.
602         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
603         (ppc_supply_vrregset): Remove.
604         (ppc_collect_vrregset): Remove.
605         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
606         (ppc_linux_vrregset) : New function.
607         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
608         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
609         (ppc32_linux_vrregset): Remove.
610         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
611         and use result instead of ppc32_linux_vrregset.
612         (ppc32_linux_reg_offsets): Remove initializers for vector register
613         offset fields.
614         (ppc64_linux_reg_offsets): Likewise.
615         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
616         * ppc-linux-nat.c: Include regset.h.
617         (gdb_vrregset_t): Adjust comment to account for little-endian
618         mode.
619         (supply_vrregset, fill_vrregset): Remove.
620         (fetch_altivec_register, store_altivec_register): Remove.
621         (fetch_altivec_registers): Add regno parameter. Get regset using
622         ppc_linux_vrregset. Use regset to supply registers.
623         (store_altivec_registers): Add regno parameter. Get regset using
624         ppc_linux_vrregset. Use regset to collect registers.
625         (fetch_register): Call fetch_altivec_registers instead of
626         fetch_altivec_register.
627         (store_register): Call store_altivec_registers instead of
628         store_altivec_register.
629         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
630         the new regno parameter.
631         (store_ppc_registers): Call store_altivec_registers with -1 for
632         the new regno parameter.
633
634 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
635
636         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
637         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
638         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
639         (gdb_vrregset_t): Change array type size to
640         PPC_LINUX_SIZEOF_VRREGSET.
641         (gdb_vsxregset_t): Change array type size to
642         PPC_LINUX_SIZEOF_VSXREGSET.
643         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
644         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
645         PPC_LINUX_SIZEOF_VSXREGSET.
646
647 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
648
649         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
650         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
651         nat/ppc-linux.c.
652         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
653         ppc_linux_target_wordsize with tid.
654         (ppc_linux_nat_target::read_description): Call ppc_linux_target
655         wordsize with tid.
656         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
657         (ppc64_64bit_inferior_p): Add static and inline specifiers.
658         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
659         tid parameter. Remove static specifier.
660         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
661         (ppc_linux_target_wordsize): New declaration.
662
663 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
664
665         * arch/ppc-linux-common.c: New file.
666         * arch/ppc-linux-common.h: New file.
667         * arch/ppc-linux-tdesc.h: New file.
668         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
669         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
670         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
671         arch/ppc-linux-tdesc.h.
672         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
673         arch/ppc-linux-tdesc.h.
674         (ppc_linux_nat_target::read_description): Remove target
675         description matching code. Fill a ppc_linux_features struct and
676         call ppc_linux_match_description with it. Move comment about ISA
677         2.05 to ppc-linux-common.c.
678         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
679         arch/ppc-linux-tdesc.h.
680         (ppc_linux_core_read_description): Remove target description
681         matching code. Fill a ppc_linux_features struct and call
682         ppc_linux_match_description with it.
683         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
684         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
685         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
686         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
687         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
688         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
689         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
690         (tdesc_powerpc_e500l): Remove.
691
692 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
693
694         * ada-lang.c (catch_assert_command): Pass empty string instead
695         of NULL for excep_string argument.
696
697 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
698
699         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
700         the width of the requested register exceeds the width of the
701         `ptrace' data type.
702
703 2018-05-21  Tom Tromey  <tom@tromey.com>
704
705         * printcmd.c (output_command): Remove.
706         (output_command_const): Rename to output_command.
707         * valprint.h (output_command): Rename from output_command_const.
708         * tracepoint.c (trace_dump_actions): Call output_command.
709
710 2018-05-21  Tom Tromey  <tom@tromey.com>
711
712         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
713         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
714         * ada-lang.h (create_ada_exception_catchpoint): Update.
715         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
716         std::string.
717         (create_excep_cond_exprs, ~ada_catchpoint)
718         (should_stop_exception, print_one_exception)
719         (print_mention_exception, print_recreate_exception): Update.
720         (ada_get_next_arg): Remove.
721         (catch_ada_exception_command_split): Use std::string.  Change type
722         of "excep_string", "cond_string".
723         (catch_ada_exception_command): Update.
724         (create_ada_exception_catchpoint): Change type of excep_string.
725         (ada_exception_sal): Remove excep_string parameter.
726         (~ada_catchpoint): Remove.
727
728 2018-05-21  Tom Tromey  <tom@tromey.com>
729
730         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
731         cleanup.
732
733 2018-05-21  Tom Tromey  <tom@tromey.com>
734
735         * ada-lang.c (ada_exception_message_1, ada_exception_message):
736         Return unique_xmalloc_ptr.
737         (print_it_exception): Update.
738
739 2018-05-21  Tom Tromey  <tom@tromey.com>
740
741         * tracepoint.c (trace_dump_actions): Use std::string.
742
743 2018-05-21  Tom Tromey  <tom@tromey.com>
744
745         * symfile.c (reread_symbols): Use std::string for original_name.
746
747 2018-05-21  Tom Tromey  <tom@tromey.com>
748
749         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
750         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
751         constructor.
752
753 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
754
755         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
756         instance to...
757         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
758         * objfiles.c (get_objfile_bfd_data): Allocate
759         objfile_per_bfd_storage with obstack_new when allocating on
760         obstack.
761
762 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
763
764         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
765         OBSTACK_ZALLOC.
766         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
767         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
768         * mdebugread.c (mdebug_build_psymtabs): Likewise.
769         (add_pending): Likewise.
770         (parse_symbol): Likewise.
771         (parse_partial_symbols): Likewise.
772         (psymtab_to_symtab_1): Likewise.
773         (new_psymtab): Likewise.
774         (elfmdebug_build_psymtabs): Likewise.
775         * minsyms.c (terminate_minimal_symbol_table): Likewise.
776         * objfiles.c (get_objfile_bfd_data): Likewise.
777         (objfile_register_static_link): Likewise.
778         * psymtab.c (allocate_psymtab): Likewise.
779         * stabsread.c (read_member_functions): Likewise.
780         * xcoffread.c (xcoff_end_psymtab): Likewise.
781
782 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
783
784         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
785         compiler supports std::is_trivially_constructible.
786         * common/poison.h: Include obstack.h.
787         (IsMallocable): Define to is_trivially_constructible if the
788         compiler supports it, define to true_type otherwise.
789         (xobnew): New.
790         (XOBNEW): Redefine.
791         (xobnewvec): New.
792         (XOBNEWVEC): Redefine.
793         * gdb_obstack.h (obstack_zalloc): New.
794         (OBSTACK_ZALLOC): Redefine.
795         (obstack_calloc): New.
796         (OBSTACK_CALLOC): Redefine.
797         (obstack_new): New.
798         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
799         (gdbarch_obstack): New declaration in gdbarch.h, definition in
800         gdbarch.c.
801         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
802         obstack_calloc/obstack_zalloc.
803         (gdbarch_obstack_zalloc): Remove.
804         * target-descriptions.c (tdesc_data_init): Use obstack_new.
805
806 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
807
808         * stack.c (backtrace_command_1): Remove useless variable int i.
809
810 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
811
812         * stack.c (print_frame_info): Fix comment.
813
814 2018-05-18  Tom Tromey  <tom@tromey.com>
815
816         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
817         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
818         (~dwarf2_per_objfile): Update
819         (dwarf2_get_dwz_file): Use new.
820         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
821         unique_ptr.
822
823 2018-05-18  Tom Tromey  <tom@tromey.com>
824
825         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
826         unique_ptr.
827         * dwarf2read.c (struct dwp_file): Add constructor and
828         initializers.
829         (open_and_init_dwp_file): Return a unique_ptr.
830         (dwarf2_per_objfile, create_dwp_hash_table)
831         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
832         (lookup_dwo_unit_in_dwp): Update.
833         (open_and_init_dwp_file, get_dwp_file): Update.
834
835 2018-05-18  Tom Tromey  <tom@tromey.com>
836
837         * dwarf2read.c (dwarf2_per_objfile): Update.
838         (struct mapped_index): Add initializers.
839         (dwarf2_read_index): Use new.
840         (dw2_symtab_iter_init): Update.
841         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
842         unique_ptr.
843
844 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
845
846         * dwarf2read.c (mapped_index) <total_size>: Remove.
847
848 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
849
850         * unittests/format_pieces-selftests.c (test_format_specifier):
851         Add ARI comments.
852
853 2018-05-18  Tom Tromey  <tom@tromey.com>
854
855         * c-typeprint.c (maybe_print_hole): New function.
856         (c_print_type_struct_field_offset): Update.
857         (c_type_print_base_struct_union): Call maybe_print_hole.
858
859 2018-05-17  Keith Seitz  <keiths@redhat.com>
860
861         * breakpoint.c (build_bpstat_chain): New function, moved from
862         bpstat_stop_status.
863         (bpstat_stop_status): Add optional parameter, `stop_chain'.
864         If no stop chain is passed, call build_bpstat_chain to build it.
865         * breakpoint.h (build_bpstat_chain): Declare.
866         (bpstat_stop_status): Move documentation here from breakpoint.c.
867         * infrun.c (handle_signal_stop): Before eliding inlined frames,
868         build the stop chain and pass it to skip_inline_frames.
869         Pass this stop chain to bpstat_stop_status.
870         * inline-frame.c: Include breakpoint.h.
871         (stopped_by_user_bp_inline_frame): New function.
872         (skip_inline_frames): Add parameter `stop_chain'.
873         Move documention to inline-frame.h.
874         If non-NULL, use stopped_by_user_bp_inline_frame to determine
875         whether the frame should be elided.
876         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
877         Add moved documentation and update for new parameter.
878
879 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
880
881         PR cli/14975
882         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
883         unittests/format_pieces-selftests.c.
884         * common/format.h (format_piece) <operator==>: New.
885         (format_pieces) <operator[]>: Remove.
886         * common/format.c (format_pieces::format_pieces): Handle \e.
887         * unittests/format_pieces-selftests.c: New.
888
889 2018-05-17  Tom Tromey  <tom@tromey.com>
890
891         PR symtab/23010:
892         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
893         (dw2_instantiate_symtab): Add skip_partial parameter.
894         (dw2_find_last_source_symtab, dw2_map_expand_apply)
895         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
896         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
897         (dw2_expand_symtabs_matching_one)
898         (dw2_find_pc_sect_compunit_symtab)
899         (dw2_debug_names_lookup_symbol)
900         (dw2_debug_names_expand_symtabs_for_function): Update.
901         (init_cutu_and_read_dies): Add skip_partial parameter.
902         (process_psymtab_comp_unit, build_type_psymtabs_1)
903         (process_skeletonless_type_unit, load_partial_comp_unit)
904         (psymtab_to_symtab_1): Update.
905         (load_full_comp_unit): Add skip_partial parameter.
906         (process_imported_unit_die, dwarf2_read_addr_index)
907         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
908         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
909         (read_signatured_type): Update.
910
911 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
912
913         * value.c (release_value): Remove unused variable.
914         (record_latest_value): Likewise.
915         (access_value_history): Likewise.
916         (preserve_values): Likewise.
917
918 2018-05-17  Tom Tromey  <tom@tromey.com>
919
920         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
921         Initialize.
922
923 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
924
925         PR gdb/22286
926         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
927         Also handle registers whose width is not a multiple of
928         PTRACE_TYPE_RET.
929         (linux_nat_trad_target::store_register): Likewise.
930
931 2018-05-16  Tom Tromey  <tom@tromey.com>
932
933         * gdbcore.h (core_bfd): Redefine.
934         * corelow.c (core_target::close): Update.
935         (core_target_open): Update.
936         * progspace.h (struct program_space) <cbfd>: Now a
937         gdb_bfd_ref_ptr.
938
939 2018-05-16  Tom Tromey  <tom@tromey.com>
940
941         PR cli/19551:
942         * symfile-add-flags.h (enum symfile_add_flags)
943         <SYMFILE_NOT_FILENAME>: New constant.
944         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
945         objfile name from BFD.
946         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
947         * minidebug.c (find_separate_debug_file_in_section): Put
948         ".gnu_debugdata" into BFD's file name.
949
950 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
951
952         * regcache.c (regcache_read_ftype, regcache_write_ftype):
953         Remove.
954
955 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
956
957         PR binutils/21446
958         * aarch64-tdep.c (aarch64_analyze_prologue,
959         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
960         Indicate not interested in errors.
961
962 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
963
964         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
965         Supply the MIPS_ZERO_REGNUM register.
966
967 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
968
969         * mips-tdep.c (mask_address_var): Make variable static.
970
971 2018-05-14  Tom Tromey  <tom@tromey.com>
972
973         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
974
975 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
976
977         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
978         FXSAVE_ADDR for the mxcsr register.
979
980 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
981
982         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
983
984 2018-05-11  Pedro Alves  <palves@redhat.com>
985
986         * corelow.c (core_target) <core_target>: No longer inline.
987         Initialize m_core_gdbarch, m_core_vec and build the section table
988         here.
989         <~core_target>: New.
990         <core_gdbarch, get_core_register_section>: New methods.
991         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
992         factored out from ...
993         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
994         (core_ops): Delete.
995         (sniff_core_bfd): Add gdbarch parameter.
996         (core_close): Delete, merged into ...
997         (core_target::close): ... here.  Delete self.
998         (core_close_cleanup): Delete.
999         (core_target_open): Allocate a core_target on the heap.  Use a
1000         unique_ptr instead of a cleanup.  Bits moved into the core_target
1001         ctor.  Adjust to use core_target methods instead of globals.
1002         (get_core_register_section): Rename to ...
1003         (core_target::get_core_register_section): ... this and adjust.
1004         (struct get_core_registers_cb_data): New.
1005         (get_core_registers_cb): Use it.  Use bool.
1006         (core_target::fetch_registers, core_target::files_info)
1007         (core_target::xfer_partial, core_target::read_description)
1008         (core_target::pid_to, core_target::thread_name): Adjust to
1009         reference class fields instead of globals.
1010         * target.h (struct target_ops_deleter, target_ops_up): New.
1011
1012 2018-05-11  Pedro Alves  <palves@redhat.com>
1013
1014         * corefile.c (core_file_command): Move to corelow.c.
1015         * corelow.c (the_core_target): Delete.
1016         (core_file_command): Moved from corefile.c.  Check exec_bfd
1017         instead of the_core_target.  Use target_detach instead of calling
1018         into the_core_target directly.
1019         (maybe_say_no_core_file_now): New.
1020         (core_target::detach): Use it.
1021         (_initialize_corelow): Remove references to the_core_target.
1022         * gdbcore.h (the_core_target): Delete.
1023
1024 2018-05-11  Tom Tromey  <tromey@redhat.com>
1025             Pedro Alves  <palves@redhat.com>
1026
1027         * corefile.c (core_bfd): Remove.
1028         * gdbcore.h (core_bfd): Now a macro.
1029         * progspace.h (struct program_space) <cbfd>: New field.
1030
1031 2018-05-11  Tom Tromey  <tom@tromey.com>
1032
1033         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1034         gdb::def_vector.
1035
1036 2018-05-10  Tom Tromey  <tom@tromey.com>
1037
1038         * configure: Rebuild.
1039         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1040
1041 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1042
1043         PR server/23158:
1044         * regformats/regdat.sh: Adjust script, following the addition
1045         of the new expedite_regs parameter to init_target_desc.
1046
1047 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1048     
1049         PR gdb/23127
1050         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1051         set_gdbarch_significant_addr_bit.
1052         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1053         set_gdbarch_significant_addr_bit.
1054         * utils.c (address_significant): Update to sign extend addr.
1055
1056 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1057
1058         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1059         (xtensa_linux_init_abi): Limit tdep->num_regs by
1060         tdep->num_nopriv_regs.
1061         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1062         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1063         not initialized.
1064
1065 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1066
1067         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1068
1069 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1072         (I387_MXCSR_INIT_VAL): New constant.
1073         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1074         buffer if it was supplied by the inferior.
1075         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1076         (i387_xsave_get_clear_bv): New function.
1077         (i387_supply_xsave): Only read x87 control registers from the
1078         xsave buffer if the feature is enabled, and the state will have
1079         been written, otherwise, provide a suitable default.
1080         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1081         including x87 control registers.  Update control registers if they
1082         have changed from the default value, and mark features as enabled
1083         as required.
1084         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1085
1086 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1087
1088         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1089
1090 2018-05-07  Tom Tromey  <tom@tromey.com>
1091
1092         * configure: Rebuild.
1093         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1094
1095 2018-05-07  Tom Tromey  <tom@tromey.com>
1096
1097         PR tdep/20362:
1098         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1099         bit.  Use correct value for VDIV.
1100
1101 2018-05-04  Tom Tromey  <tom@tromey.com>
1102
1103         * configure: Rebuild.
1104         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1105
1106 2018-05-04  Tom Tromey  <tom@tromey.com>
1107
1108         * linux-record.c (record_linux_system_call) <case
1109         RECORD_SYS_RECVFROM>: Add "break".
1110
1111 2018-05-04  Tom Tromey  <tom@tromey.com>
1112
1113         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1114         Add missing "break".
1115         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1116         Add missing "break".
1117
1118 2018-05-04  Tom Tromey  <tom@tromey.com>
1119
1120         * rs6000-tdep.c (ppc_process_record_op4)
1121         (ppc_process_record_op63): Add fall-through comment.
1122
1123 2018-05-04  Tom Tromey  <tom@tromey.com>
1124
1125         * i386-tdep.c (i386_process_record): Add fall-through comment.
1126
1127 2018-05-04  Tom Tromey  <tom@tromey.com>
1128
1129         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1130         comment.
1131
1132 2018-05-04  Tom Tromey  <tom@tromey.com>
1133
1134         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1135         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1136         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1137         comment.
1138         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1139         comment.
1140         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1141         comment.
1142
1143 2018-05-04  Tom Tromey  <tom@tromey.com>
1144
1145         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1146
1147 2018-05-04  Tom Tromey  <tom@tromey.com>
1148
1149         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1150         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1151         * symfile.c (section_is_mapped): Fix fall-through comment.
1152         * stabsread.c (define_symbol, read_member_functions): Fix
1153         fall-through comment.
1154         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1155         comment.
1156         * remote.c (remote_wait_as): Fix fall-through comment.
1157         * p-exp.y (yylex): Fix fall-through comment.
1158         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1159         comment.
1160         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1161         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1162         * jv-exp.y (yylex): Fix fall-through comment.
1163         * go-exp.y (lex_one_token): Fix fall-through comment.
1164         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1165         fall-through comment.
1166         * f-exp.y (yylex): Fix fall-through comment.
1167         * dwarf2read.c (process_die): Fix fall-through comments.
1168         * dbxread.c (process_one_symbol): Fix fall-through comment.
1169         * d-exp.y (lex_one_token): Fix fall-through comment.
1170         * cp-name-parser.y (yylex): Fix fall-through comment.
1171         * coffread.c (coff_symtab_read): Fix fall-through comment.
1172         * c-exp.y (lex_one_token): Fix fall-through comment.
1173         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1174         comment.
1175         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1176         comment.
1177
1178 2018-05-04  Tom Tromey  <tom@tromey.com>
1179
1180         PR python/22730:
1181         * NEWS: Mention gdb.execute change.
1182         * gdbcmd.h (execute_control_command): Don't declare.
1183         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1184         execute_control_commands, execute_control_commands_to_string.
1185         * cli/cli-script.h (execute_control_commands)
1186         (execute_control_commands_to_string): Declare.
1187         (execute_control_command): Add from_tty parameter.
1188         * cli/cli-script.c (execute_control_commands)
1189         (execute_control_commands_to_string): New functions.
1190         (execute_user_command): Use execute_control_commands.
1191         (execute_control_command_1): Add "from_tty" parameter.  Update.
1192         (execute_control_command): Likewise.
1193
1194 2018-05-04  Tom Tromey  <tom@tromey.com>
1195
1196         PR python/22731:
1197         * NEWS: Mention that breakpoint commands are writable.
1198         * python/py-breakpoint.c (bppy_set_commands): New function.
1199         (breakpoint_object_getset) <"commands">: Use it.
1200
1201 2018-05-04  Tom Tromey  <tom@tromey.com>
1202
1203         * tracepoint.c (actions_command): Update.
1204         * mi/mi-cmd-break.c (mi_command_line_array)
1205         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1206         (mi_read_next_line): Remove.
1207         (mi_cmd_break_commands): Update.
1208         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1209         function_view.
1210         * cli/cli-script.c (get_command_line): Update.
1211         (process_next_line): Use function_view.  Constify.
1212         (recurse_read_control_structure, read_command_lines)
1213         (read_command_lines_1): Change argument types to function_view.
1214         (do_define_command, document_command): Update.
1215         * breakpoint.h (check_tracepoint_command): Don't declare.
1216         * breakpoint.c (check_tracepoint_command): Remove.
1217         (commands_command_1, create_tracepoint_from_upload): Update.
1218
1219 2018-05-04  Tom Tromey  <tom@tromey.com>
1220
1221         PR gdb/11750:
1222         * cli/cli-script.h (enum command_control_type) <define_control>:
1223         New constant.
1224         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1225         (build_command_line, execute_control_command_1)
1226         (process_next_line): Likewise.
1227         (do_define_command): New function, extracted from define_command.
1228         (define_command): Use it.
1229
1230 2018-05-04  Tom Tromey  <tom@tromey.com>
1231
1232         * tracepoint.c (actions_command): Update.
1233         * cli/cli-script.h (read_command_lines): Update.
1234         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1235         (MAX_TMPBUF): Remove define.
1236         (define_command): Use string_printf.
1237         (document_command): Likewise.
1238         * breakpoint.c (commands_command_1): Update.
1239
1240 2018-05-04  Tom Tromey  <tom@tromey.com>
1241
1242         * top.c (execute_command): Update.
1243         * cli/cli-script.h (print_command_lines): Now varargs.
1244         * cli/cli-script.c (print_command_lines): Now varargs.
1245         (execute_control_command_1) <case while_control, case if_control>:
1246         Update.
1247
1248 2018-05-04  Tom Tromey  <tom@tromey.com>
1249
1250         * tracepoint.c (all_tracepoint_actions): Rename from
1251         all_tracepoint_actions_and_cleanup.  Change return type.
1252         (actions_command, encode_actions_1, encode_actions)
1253         (trace_dump_actions, tdump_command): Update.
1254         * remote.c (remote_download_command_source): Update.
1255         * python/python.c (gdbpy_eval_from_control_command)
1256         (python_command, python_interactive_command): Update.
1257         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1258         * guile/guile.c (guile_command)
1259         (gdbscm_eval_from_control_command, guile_command): Update.
1260         * compile/compile.c (compile_code_command)
1261         (compile_print_command, compile_to_object): Update.
1262         * cli/cli-script.h (struct command_lines_deleter): New.
1263         (counted_command_line): New typedef.
1264         (struct command_line): Add constructor, destructor.
1265         <body_list>: Remove.
1266         <body_list_0, body_list_1>: New members.
1267         (command_line_up): Remove typedef.
1268         (read_command_lines, read_command_lines_1, get_command_line):
1269         Update.
1270         (copy_command_lines): Don't declare.
1271         * cli/cli-script.c (build_command_line): Use "new".
1272         (get_command_line): Return counted_command_line.
1273         (print_command_lines, execute_user_command)
1274         (execute_control_command_1, while_command, if_command): Update.
1275         (realloc_body_list): Remove.
1276         (process_next_line, recurse_read_control_structure): Update.
1277         (read_command_lines, read_command_lines_1): Return counted_command_line.
1278         (free_command_lines): Use "delete".
1279         (copy_command_lines): Remove.
1280         (define_command, document_command, show_user_1): Update.
1281         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1282         a counted_command_line.
1283         * breakpoint.h (counted_command_line): Remove typedef.
1284         (breakpoint_set_commands): Update.
1285         * breakpoint.c (check_no_tracepoint_commands)
1286         (validate_commands_for_breakpoint): Update.
1287         (breakpoint_set_commands): Change commands to be a
1288         counted_command_line.
1289         (commands_command_1, update_dprintf_command_list)
1290         (create_tracepoint_from_upload): Update.
1291
1292 2018-05-04  Tom Tromey  <tom@tromey.com>
1293
1294         * cli/cli-decode.h (cmd_list_element): New constructor.
1295         (~cmd_list_element): New destructor.
1296         (struct cmd_list_element): Add initializers.
1297         * cli/cli-decode.c (do_add_cmd): Use "new".
1298         (delete_cmd): Use "delete".
1299
1300 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1301             Pedro Alves <palves@redhat.com>
1302
1303         PR breakpoints/19806 and support for PR external/20207.
1304         * NEWS: Mention Aarch64 watchpoint improvements.
1305         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1306         watchpoints and PR external/20207 watchpoints.
1307         * nat/aarch64-linux-hw-point.c
1308         (kernel_supports_any_contiguous_range): New.
1309         (aarch64_watchpoint_offset): New.
1310         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1311         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1312         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1313         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1314         next_addr_orig_p.  Support PR external/20207 watchpoints.
1315         (aarch64_downgrade_regs): New.
1316         (aarch64_dr_state_insert_one_point): New parameters offset and
1317         addr_orig.
1318         (aarch64_dr_state_remove_one_point): Likewise.
1319         (aarch64_handle_breakpoint): Update caller.
1320         (aarch64_handle_aligned_watchpoint): Likewise.
1321         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1322         aligned_offset.
1323         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1324         aarch64_downgrade_regs.
1325         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1326         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1327         (DR_CONTROL_MASK): ... this.
1328         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1329         (unsigned int aarch64_watchpoint_offset): New prototype.
1330         (aarch64_linux_set_debug_regs): Remove const from state.
1331         * utils.c (align_up, align_down): Move to ...
1332         * common/common-utils.c (align_up, align_down): ... here.
1333         * utils.h (align_up, align_down): Move to ...
1334         * common/common-utils.h (align_up, align_down): ... here.
1335
1336 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1337
1338         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1339         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1340         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1341         Re-implement to match the ABI as summarized in GCC's
1342         gcc/config/sparc/sparc.c.  All callers updated.
1343         (sparc32_store_arguments): Remove assertion.
1344
1345 2018-05-04  Tom Tromey  <tom@tromey.com>
1346
1347         * printcmd.c: Don't include tui.h.
1348         (decode_format): Use skip_spaces.
1349
1350 2018-05-04  Tom Tromey  <tom@tromey.com>
1351
1352         PR gdb/22619:
1353         * printcmd.c (last_count): New global.
1354         (x_command): Use saved count when repeating.
1355
1356 2018-05-04  Tom Tromey  <tom@tromey.com>
1357
1358         * nto-procfs.c (do_closedir_cleanup): Remove.
1359         (procfs_pidlist): Use gdb_dir_up.
1360         * procfs.c (do_closedir_cleanup): Remove.
1361         (proc_update_threads): Use gdb_dir_up.
1362         * common/filestuff.h (struct gdb_dir_deleter): New.
1363         (gdb_dir_up): New typedef.
1364
1365 2018-05-04  Tom Tromey  <tom@tromey.com>
1366
1367         * ada-lang.c (print_mention_exception): Use std::string.
1368
1369 2018-05-04  Tom Tromey  <tom@tromey.com>
1370
1371         * ada-lang.c (create_excep_cond_exprs): Update.
1372         (ada_exception_catchpoint_cond_string): Use std::string.
1373
1374 2018-05-04  Tom Tromey  <tom@tromey.com>
1375
1376         * ada-lang.c (xget_renaming_scope): Return std::string.
1377         (old_renaming_is_invisible): Update.
1378
1379 2018-05-04  Tom Tromey  <tom@tromey.com>
1380
1381         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1382         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1383
1384 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1385
1386         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1387
1388 2018-05-04  Tom Tromey  <tom@tromey.com>
1389
1390         * remote.c (remote_query_supported_append): Change type.
1391         (remote_check_symbols): Update.
1392
1393 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1394
1395         PR gdb/11420
1396         * configure.ac: Prepend libpython.
1397         * python/python-config.py: Likewise.
1398         * configure: Regenerate.
1399
1400 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1401
1402         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1403
1404 2018-05-03  Pedro Alves  <palves@redhat.com>
1405
1406         * s390-linux-nat.c
1407         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1408         override.  Write 'true' instead of '1'.
1409         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1410         declaration.
1411
1412 2018-05-02  Pedro Alves  <palves@redhat.com>
1413
1414         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1415         add_inf_child_target.
1416         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1417         add_inf_child_target.
1418         * aix-thread.c (aix_thread_target_info): New.
1419         (aix_thread_target) <shortname, longname, doc>: Delete.
1420         <info>: New.
1421         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1422         add_inf_child_target.
1423         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1424         add_inf_child_target.
1425         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1426         add_inf_child_target.
1427         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1428         add_inf_child_target.
1429         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1430         add_inf_child_target.
1431         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1432         add_inf_child_target.
1433         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1434         add_inf_child_target.
1435         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1436         add_inf_child_target.
1437         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1438         add_inf_child_target.
1439         * bfd-target.c (target_bfd_target_info): New.
1440         (target_bfd) <shortname, longname, doc>: Delete.
1441         <info>: New.
1442         * bsd-kvm.c (bsd_kvm_target_info): New.
1443         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1444         <info>: New.
1445         (bsd_kvm_target::open): Rename to ...
1446         (bsd_kvm_target_open): ... this.  Adjust.
1447         * bsd-uthread.c (bsd_uthread_target_info): New.
1448         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1449         <info>: New.
1450         * corefile.c (core_file_command): Adjust.
1451         * corelow.c (core_target_info): New.
1452         (core_target) <shortname, longname, doc>: Delete.
1453         <info>: New.
1454         (core_target::open): Rename to ...
1455         (core_target_open): ... this.  Adjust.
1456         * ctf.c (ctf_target_info): New.
1457         (ctf_target) <shortname, longname, doc>: Delete.
1458         <info>: New.
1459         (ctf_target::open): Rename to ...
1460         (ctf_target_open): ... this.
1461         (_initialize_ctf): Adjust.
1462         * exec.c (exec_target_info): New.
1463         (exec_target) <shortname, longname, doc>: Delete.
1464         <info>: New.
1465         (exec_target::open): Rename to ...
1466         (exec_target_open): ... this.
1467         * gdbcore.h (core_target_open): Declare.
1468         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1469         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1470         add_inf_child_target.
1471         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1472         add_inf_child_target.
1473         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1474         add_inf_child_target.
1475         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1476         add_inf_child_target.
1477         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1478         add_inf_child_target.
1479         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1480         add_inf_child_target.
1481         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1482         add_inf_child_target.
1483         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1484         add_inf_child_target.
1485         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1486         add_inf_child_target.
1487         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1488         add_inf_child_target.
1489         * inf-child.c (inf_child_target_info): New.
1490         (inf_child_target::info): New.
1491         (inf_child_open_target): Remove 'target' parameter.  Use
1492         get_native_target instead.
1493         (inf_child_target::open): Delete.
1494         (add_inf_child_target): New.
1495         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1496         Delete.
1497         <info>: New.
1498         (add_inf_child_target): Declare.
1499         (inf_child_open_target): Declare.
1500         * linux-thread-db.c (thread_db_target_info): New.
1501         (thread_db_target) <shortname, longname, doc>: Delete.
1502         <info>: New.
1503         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1504         add_inf_child_target.
1505         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1506         add_inf_child_target.
1507         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1508         add_inf_child_target.
1509         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1510         add_inf_child_target.
1511         * make-target-delegates (print_class): Adjust.
1512         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1513         add_inf_child_target.
1514         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1515         add_inf_child_target.
1516         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1517         add_inf_child_target.
1518         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1519         add_inf_child_target.
1520         * nto-procfs.c (nto_native_target_info): New.
1521         (nto_procfs_target_native) <shortname, longname, doc>:
1522         Delete.
1523         <info>: New.
1524         (nto_procfs_target_info): New.
1525         (nto_procfs_target_procfs) <shortname, longname, doc>:
1526         Delete.
1527         <info>: New.
1528         (init_procfs_targets): Adjust.
1529         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1530         add_inf_child_target.
1531         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1532         add_inf_child_target.
1533         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1534         add_inf_child_target.
1535         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1536         add_inf_child_target.
1537         * ravenscar-thread.c (ravenscar_target_info): New.
1538         (ravenscar_thread_target) <shortname, longname, doc>:
1539         Delete.
1540         <info>: New.
1541         * record-btrace.c (record_btrace_target_info):
1542         (record_btrace_target) <shortname, longname, doc>: Delete.
1543         <info>: New.
1544         (record_btrace_target::open): Rename to ...
1545         (record_btrace_target_open): ... this.  Adjust.
1546         * record-full.c (record_longname, record_doc): New.
1547         (record_full_base_target) <shortname, longname, doc>: Delete.
1548         <info>: New.
1549         (record_full_target_info): New.
1550         (record_full_target): <shortname>: Delete.
1551         <info>: New.
1552         (record_full_core_open_1, record_full_open_1): Update comments.
1553         (record_full_base_target::open): Rename to ...
1554         (record_full_open): ... this.
1555         (cmd_record_full_restore): Update.
1556         (_initialize_record_full): Update.
1557         * remote-sim.c (remote_sim_target_info): New.
1558         (gdbsim_target) <shortname, longname, doc>: Delete.
1559         <info>: New.
1560         (gdbsim_target::open): Rename to ...
1561         (gdbsim_target_open): ... this.
1562         (_initialize_remote_sim): Adjust.
1563         * remote.c (remote_doc): New.
1564         (remote_target_info): New.
1565         (remote_target) <shortname, longname, doc>: Delete.
1566         <info>: New.
1567         (extended_remote_target_info): New.
1568         (extended_remote_target) <shortname, longname, doc>: Delete.
1569         <info>: New.
1570         (remote_target::open_1): Make static.  Adjust.
1571         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1572         * s390-linux-nat.c (_initialize_s390_nat): Use
1573         add_inf_child_target.
1574         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1575         add_inf_child_target.
1576         * sol-thread.c (thread_db_target_info): New.
1577         (sol_thread_target) <shortname, longname, doc>: Delete.
1578         <info>: New.
1579         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1580         add_inf_child_target.
1581         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1582         add_inf_child_target.
1583         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1584         add_inf_child_target.
1585         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1586         add_inf_child_target.
1587         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1588         add_inf_child_target.
1589         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1590         add_inf_child_target.
1591         * spu-linux-nat.c (_initialize_spu_nat): Use
1592         add_inf_child_target.
1593         * spu-multiarch.c (spu_multiarch_target_info): New.
1594         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1595         <info>: New.
1596         * target-delegates.c: Regenerate.
1597         * target.c: Include <unordered_map>.
1598         (target_ops_p): Delete.
1599         (DEF_VEC_P(target_ops_p)): Delete.
1600         (target_factories): New.
1601         (test_target_info): New.
1602         (test_target_ops::info): New.
1603         (open_target): Adjust to use target_factories.
1604         (add_target_with_completer): Rename to ...
1605         (add_target): ... this.  Change prototype.  Register target_info
1606         and open callback in target_factories.  Register target_info in
1607         command context instead of target_ops.
1608         (add_target): Delete old implementation.
1609         (add_deprecated_target_alias): Change prototype.  Adjust.
1610         (the_native_target): New.
1611         (set_native_target, get_native_target): New.
1612         (find_default_run_target): Use the_native_target.
1613         (find_attach_target, find_run_target): Simplify.
1614         (target_ops::open): Delete.
1615         (dummy_target_info): New.
1616         (dummy_target::shortname, dummy_target::longname)
1617         (dummy_target::doc): Delete.
1618         (dummy_target::info): New.
1619         (debug_target::shortname, debug_target::longname)
1620         (debug_target::doc): Delete.
1621         (debug_target::info): New.
1622         * target.h (struct target_info): New.
1623         (target_ops::~target_ops): Add comment.
1624         (target_ops::info): New.
1625         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1626         longer virtual.  Implement in terms of target_info.
1627         (set_native_target, get_native_target): Declare.
1628         (target_open_ftype): New.
1629         (add_target, add_target_with_completer)
1630         (add_deprecated_target_alias): Change prototype.
1631         (test_target) <shortname, longname, doc>: Delete.
1632         <info>: New.
1633         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1634         add_inf_child_target.
1635         * tracefile-tfile.c (tfile_target_info): New.
1636         (tfile_target) <shortname, longname, doc>: Delete.
1637         <info>: New.
1638         (tfile_target::open): Rename to ...
1639         (tfile_target_open): ... this.
1640         (_initialize_tracefile_tfile): Adjust.
1641         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1642         add_inf_child_target.
1643         * windows-nat.c (_initialize_windows_nat): Use
1644         add_inf_child_target.
1645         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1646         add_inf_child_target.
1647
1648 2018-05-02  Pedro Alves  <palves@redhat.com>
1649
1650         * linux-nat.h (linux_nat_target) <low_new_thread,
1651         low_delete_thread, low_new_fork, low_forget_process,
1652         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1653         New virtual methods.
1654         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1655         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1656         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1657         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1658         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1659         Delete.
1660         * linux-fork.c (delete_fork): Adjust to call low method.
1661         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1662         (linux_nat_new_fork, linux_nat_forget_process_hook)
1663         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1664         (linux_nat_status_is_event):
1665         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1666         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1667         to call low method.
1668         (sigtrap_is_event): Rename to ...
1669         (linux_nat_target::low_status_is_event): ... this.
1670         (linux_nat_set_status_is_event): Delete.
1671         (save_stop_reason, linux_nat_wait_1)
1672         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1673         low methods.
1674         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1675         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1676         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1677         (linux_nat_set_prepare_to_resume): Delete.
1678         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1679         low virtual methods.
1680         * amd64-linux-nat.c: Likewise.
1681         * arm-linux-nat.c: Likewise.
1682         * i386-linux-nat.c: Likewise.
1683         * ia64-linux-nat.c: Likewise.
1684         * mips-linux-nat.c: Likewise.
1685         * ppc-linux-nat.c: Likewise.
1686         * s390-linux-nat.c: Likewise.
1687         * sparc64-linux-nat.c: Likewise.
1688         * x86-linux-nat.c: Likewise.
1689         * x86-linux-nat.h: Include "nat/x86-linux.h".
1690         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1691         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1692         Override methods.
1693
1694 2018-05-02  Pedro Alves  <palves@redhat.com>
1695
1696         * target.h (target_ops)
1697         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1698         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1699         stopped_by_watchpoint, have_continuable_watchpoint,
1700         stopped_data_address, watchpoint_addr_within_range,
1701         can_accel_watchpoint_condition, can_run, thread_alive,
1702         has_all_memory, has_memory, has_stack, has_registers,
1703         has_execution, can_async_p, is_async_p, supports_non_stop,
1704         always_non_stop_p, can_execute_reverse, supports_multi_process,
1705         supports_enable_disable_tracepoint,
1706         supports_disable_randomization, supports_string_tracing,
1707         supports_evaluation_of_breakpoint_conditions,
1708         can_run_breakpoint_commands, filesystem_is_local,
1709         can_download_tracepoint, get_trace_state_variable_value,
1710         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1711         record_is_replaying, record_will_replay,
1712         augmented_libraries_svr4_read>: Adjust to return bool.
1713         * aarch64-linux-nat.c: All implementations adjusted.
1714         * aix-thread.c: All implementations adjusted.
1715         * arm-linux-nat.c: All implementations adjusted.
1716         * breakpoint.c: All implementations adjusted.
1717         * bsd-kvm.c: All implementations adjusted.
1718         * bsd-uthread.c: All implementations adjusted.
1719         * corelow.c: All implementations adjusted.
1720         * ctf.c: All implementations adjusted.
1721         * darwin-nat.c: All implementations adjusted.
1722         * darwin-nat.h: All implementations adjusted.
1723         * exec.c: All implementations adjusted.
1724         * fbsd-nat.c: All implementations adjusted.
1725         * fbsd-nat.h: All implementations adjusted.
1726         * gnu-nat.c: All implementations adjusted.
1727         * gnu-nat.h: All implementations adjusted.
1728         * go32-nat.c: All implementations adjusted.
1729         * ia64-linux-nat.c: All implementations adjusted.
1730         * inf-child.c: All implementations adjusted.
1731         * inf-child.h: All implementations adjusted.
1732         * inf-ptrace.c: All implementations adjusted.
1733         * inf-ptrace.h: All implementations adjusted.
1734         * linux-nat.c: All implementations adjusted.
1735         * linux-nat.h: All implementations adjusted.
1736         * mips-linux-nat.c: All implementations adjusted.
1737         * nto-procfs.c: All implementations adjusted.
1738         * ppc-linux-nat.c: All implementations adjusted.
1739         * procfs.c: All implementations adjusted.
1740         * ravenscar-thread.c: All implementations adjusted.
1741         * record-btrace.c: All implementations adjusted.
1742         * record-full.c: All implementations adjusted.
1743         * remote-sim.c: All implementations adjusted.
1744         * remote.c: All implementations adjusted.
1745         * s390-linux-nat.c: All implementations adjusted.
1746         * sol-thread.c: All implementations adjusted.
1747         * spu-multiarch.c: All implementations adjusted.
1748         * target-delegates.c: All implementations adjusted.
1749         * target.c: All implementations adjusted.
1750         * target.h: All implementations adjusted.
1751         * tracefile-tfile.c: All implementations adjusted.
1752         * tracefile.c: All implementations adjusted.
1753         * tracefile.h: All implementations adjusted.
1754         * windows-nat.c: All implementations adjusted.
1755         * x86-linux-nat.h: All implementations adjusted.
1756         * x86-nat.h: All implementations adjusted.
1757
1758 2018-05-02  Pedro Alves  <palves@redhat.com>
1759
1760         * make-target-delegates (scan_target_h): Don't trim lines here.
1761         Replace sequences of tabs and/or whitespace with a single
1762         whitespace.
1763         (top level, parsing methods): Trim each line before processing it
1764         here.
1765
1766 2018-05-02  Pedro Alves  <palves@redhat.com>
1767             John Baldwin  <jhb@freebsd.org>
1768
1769         * target.h (enum strata) <debug_stratum>: New.
1770         (struct target_ops) <all delegation methods>: Replace by C++
1771         virtual methods, and drop "to_" prefix.  All references updated
1772         throughout.
1773         <to_shortname, to_longname, to_doc, to_data,
1774         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1775         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1776         virtual methods.  All references updated throughout.
1777         <can_attach, supports_terminal_ours, can_create_inferior,
1778         get_thread_control_capabilities, attach_no_wait>: New
1779         virtual methods.
1780         <insert_breakpoint, remove_breakpoint>: Now
1781         TARGET_DEFAULT_NORETURN methods.
1782         <info_proc>: Now returns bool.
1783         <to_magic>: Delete.
1784         (OPS_MAGIC): Delete.
1785         (current_target): Delete.  All references replaced by references
1786         to ...
1787         (target_stack): ... this.  New.
1788         (target_shortname, target_longname): Adjust.
1789         (target_can_run): Now a function declaration.
1790         (default_child_has_all_memory, default_child_has_memory)
1791         (default_child_has_stack, default_child_has_registers)
1792         (default_child_has_execution): Remove target_ops parameter.
1793         (complete_target_initialization): Delete.
1794         (memory_breakpoint_target): New template class.
1795         (test_target_ops): Refactor as a C++ class with virtual methods.
1796         * make-target-delegates (NAME_PART): Tighten.
1797         (POINTER_PART, CP_SYMBOL): New.
1798         (SIMPLE_RETURN_PART): Reimplement.
1799         (VEC_RETURN_PART): Expect less.
1800         (RETURN_PART, VIRTUAL_PART): New.
1801         (METHOD): Adjust to C++ virtual methods.
1802         (scan_target_h): Remove reference to C99.
1803         (dname): Output "target_ops::" prefix.
1804         (write_function_header): Adjust to output a C++ class method.
1805         (write_declaration): New.
1806         (write_delegator): Adjust to output a C++ class method.
1807         (tdname): Output "dummy_target::" prefix.
1808         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1809         method.
1810         (tdefault_names, debug_names): Delete.
1811         (return_types, tdefaults, styles, argtypes_array): New.
1812         (top level): All methods are delegators.
1813         (print_class): New.
1814         (top level): Print dummy_target and debug_target classes.
1815         * target-delegates.c: Regenerate.
1816         * target-debug.h (target_debug_print_enum_info_proc_what)
1817         (target_debug_print_thread_control_capabilities)
1818         (target_debug_print_thread_info_p): New.
1819         * target.c (dummy_target): Delete.
1820         (the_dummy_target, the_debug_target): New.
1821         (target_stack): Now extern.
1822         (set_targetdebug): Push/unpush debug target.
1823         (default_child_has_all_memory, default_child_has_memory)
1824         (default_child_has_stack, default_child_has_registers)
1825         (default_child_has_execution): Remove target_ops parameter.
1826         (complete_target_initialization): Delete.
1827         (add_target_with_completer): No longer call
1828         complete_target_initialization.
1829         (target_supports_terminal_ours): Use regular delegation.
1830         (update_current_target): Delete.
1831         (push_target): No longer check magic number.  Don't call
1832         update_current_target.
1833         (unpush_target): Don't call update_current_target.
1834         (target_is_pushed): No longer check magic number.
1835         (target_require_runnable): Skip for all stratums over
1836         process_stratum.
1837         (target_ops::info_proc): New.
1838         (target_info_proc): Use find_target_at and
1839         find_default_run_target.
1840         (target_supports_disable_randomization): Use regular delegation.
1841         (target_get_osdata): Use find_target_at.
1842         (target_ops::open, target_ops::close, target_ops::can_attach)
1843         (target_ops::attach, target_ops::can_create_inferior)
1844         (target_ops::create_inferior, target_ops::can_run)
1845         (target_can_run): New.
1846         (default_fileio_target): Use regular delegation.
1847         (target_ops::fileio_open, target_ops::fileio_pwrite)
1848         (target_ops::fileio_pread, target_ops::fileio_fstat)
1849         (target_ops::fileio_close, target_ops::fileio_unlink)
1850         (target_ops::fileio_readlink): New.
1851         (target_fileio_open_1, target_fileio_unlink)
1852         (target_fileio_readlink): Always call the target method.  Handle
1853         FILEIO_ENOSYS.
1854         (return_zero, return_zero_has_execution): Delete.
1855         (init_dummy_target): Delete.
1856         (dummy_target::dummy_target, dummy_target::shortname)
1857         (dummy_target::longname, dummy_target::doc)
1858         (debug_target::debug_target, debug_target::shortname)
1859         (debug_target::longname, debug_target::doc): New.
1860         (target_supports_delete_record): Use regular delegation.
1861         (setup_target_debug): Delete.
1862         (maintenance_print_target_stack): Skip debug_stratum.
1863         (initialize_targets): Instantiate the_dummy_target and
1864         the_debug_target.
1865         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1866         use target_stack.
1867         (target_auxv_search, fprint_target_auxv): Adjust.
1868         (info_auxv_command): Adjust to use target_stack.
1869         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1870         * exceptions.c (print_flush): Handle a NULL target_stack.
1871         * regcache.c (target_ops_no_register): Refactor as class with
1872         virtual methods.
1873
1874         * exec.c (exec_target): New class.
1875         (exec_ops): Now an exec_target.
1876         (exec_open, exec_close_1, exec_get_section_table)
1877         (exec_xfer_partial, exec_files_info, exec_has_memory)
1878         (exec_make_note_section): Refactor as exec_target methods.
1879         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1880         Delete.
1881         (exec_target::find_memory_regions): New.
1882         (_initialize_exec): Don't call init_exec_ops.
1883         * gdbcore.h (exec_file_clear): Delete.
1884
1885         * corefile.c (core_target): Delete.
1886         (core_file_command): Adjust.
1887         * corelow.c (core_target): New class.
1888         (the_core_target): New.
1889         (core_close): Remove target_ops parameter.
1890         (core_close_cleanup): Adjust.
1891         (core_target::close): New.
1892         (core_open, core_detach, get_core_registers, core_files_info)
1893         (core_xfer_partial, core_thread_alive, core_read_description)
1894         (core_pid_to_str, core_thread_name, core_has_memory)
1895         (core_has_stack, core_has_registers, core_info_proc): Rework as
1896         core_target methods.
1897         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1898         (_initialize_corelow): Initialize the_core_target.
1899         * gdbcore.h (core_target): Delete.
1900         (the_core_target): New.
1901
1902         * ctf.c: (ctf_target): New class.
1903         (ctf_ops): Now a ctf_target.
1904         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1905         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1906         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1907         methods.
1908         (init_ctf_ops): Delete.
1909         (_initialize_ctf): Don't call it.
1910         * tracefile-tfile.c (tfile_target): New class.
1911         (tfile_ops): Now a tfile_target.
1912         (tfile_open, tfile_close, tfile_files_info)
1913         (tfile_get_tracepoint_status, tfile_trace_find)
1914         (tfile_fetch_registers, tfile_xfer_partial)
1915         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1916         Refactor as tfile_target methods.
1917         (tfile_xfer_partial_features): Remove target_ops parameter.
1918         (init_tfile_ops): Delete.
1919         (_initialize_tracefile_tfile): Don't call it.
1920         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1921         (tracefile_has_stack, tracefile_has_registers)
1922         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1923         tracefile_target methods.
1924         (init_tracefile_ops): Delete.
1925         (tracefile_target::tracefile_target): New.
1926         * tracefile.h: Include "target.h".
1927         (tracefile_target): New class.
1928         (init_tracefile_ops): Delete.
1929
1930         * spu-multiarch.c (spu_multiarch_target): New class.
1931         (spu_ops): Now a spu_multiarch_target.
1932         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1933         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1934         (spu_search_memory, spu_mourn_inferior): Refactor as
1935         spu_multiarch_target methods.
1936         (init_spu_ops): Delete.
1937         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1938         complete_target_initialization.
1939
1940         * ravenscar-thread.c (ravenscar_thread_target): New class.
1941         (ravenscar_ops): Now a ravenscar_thread_target.
1942         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1943         (ravenscar_thread_alive, ravenscar_pid_to_str)
1944         (ravenscar_fetch_registers, ravenscar_store_registers)
1945         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1946         (ravenscar_stopped_by_hw_breakpoint)
1947         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1948         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1949         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1950         methods.
1951         (init_ravenscar_thread_ops): Delete.
1952         (_initialize_ravenscar): Remove references to
1953         init_ravenscar_thread_ops and complete_target_initialization.
1954
1955         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1956         (bsd_uthread_target): New class.
1957         (bsd_uthread_ops): Now a bsd_uthread_target.
1958         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1959         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1960         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1961         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1962         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1963         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1964         (bsd_uthread_target): Delete function.
1965         (_initialize_bsd_uthread): Remove reference to
1966         complete_target_initialization.
1967
1968         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1969         (target_bfd): ... this new class.
1970         (target_bfd_xfer_partial, target_bfd_get_section_table)
1971         (target_bfd_close): Refactor as target_bfd methods.
1972         (target_bfd::~target_bfd): New.
1973         (target_bfd_reopen): Adjust.
1974         (target_bfd::close): New.
1975
1976         * record-btrace.c (record_btrace_target): New class.
1977         (record_btrace_ops): Now a record_btrace_target.
1978         (record_btrace_open, record_btrace_stop_recording)
1979         (record_btrace_disconnect, record_btrace_close)
1980         (record_btrace_async, record_btrace_info)
1981         (record_btrace_insn_history, record_btrace_insn_history_range)
1982         (record_btrace_insn_history_from, record_btrace_call_history)
1983         (record_btrace_call_history_range)
1984         (record_btrace_call_history_from, record_btrace_record_method)
1985         (record_btrace_is_replaying, record_btrace_will_replay)
1986         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1987         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1988         (record_btrace_store_registers, record_btrace_prepare_to_store)
1989         (record_btrace_to_get_unwinder)
1990         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1991         (record_btrace_commit_resume, record_btrace_wait)
1992         (record_btrace_stop, record_btrace_can_execute_reverse)
1993         (record_btrace_stopped_by_sw_breakpoint)
1994         (record_btrace_supports_stopped_by_sw_breakpoint)
1995         (record_btrace_stopped_by_hw_breakpoint)
1996         (record_btrace_supports_stopped_by_hw_breakpoint)
1997         (record_btrace_update_thread_list, record_btrace_thread_alive)
1998         (record_btrace_goto_begin, record_btrace_goto_end)
1999         (record_btrace_goto, record_btrace_stop_replaying_all)
2000         (record_btrace_execution_direction)
2001         (record_btrace_prepare_to_generate_core)
2002         (record_btrace_done_generating_core): Refactor as
2003         record_btrace_target methods.
2004         (init_record_btrace_ops): Delete.
2005         (_initialize_record_btrace): Remove reference to
2006         init_record_btrace_ops.
2007         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2008         the execution_direction global.
2009         (record_full_base_target, record_full_target)
2010         (record_full_core_target): New classes.
2011         (record_full_ops): Now a record_full_target.
2012         (record_full_core_ops): Now a record_full_core_target.
2013         (record_full_target::detach, record_full_target::disconnect)
2014         (record_full_core_target::disconnect)
2015         (record_full_target::mourn_inferior, record_full_target::kill):
2016         New.
2017         (record_full_open, record_full_close, record_full_async): Refactor
2018         as methods of the record_full_base_target class.
2019         (record_full_resume, record_full_commit_resume): Refactor
2020         as methods of the record_full_target class.
2021         (record_full_wait, record_full_stopped_by_watchpoint)
2022         (record_full_stopped_data_address)
2023         (record_full_stopped_by_sw_breakpoint)
2024         (record_full_supports_stopped_by_sw_breakpoint)
2025         (record_full_stopped_by_hw_breakpoint)
2026         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2027         methods of the record_full_base_target class.
2028         (record_full_store_registers, record_full_xfer_partial)
2029         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2030         Refactor as methods of the record_full_target class.
2031         (record_full_can_execute_reverse, record_full_get_bookmark)
2032         (record_full_goto_bookmark, record_full_execution_direction)
2033         (record_full_record_method, record_full_info, record_full_delete)
2034         (record_full_is_replaying, record_full_will_replay)
2035         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2036         (record_full_stop_replaying): Refactor as methods of the
2037         record_full_base_target class.
2038         (record_full_core_resume, record_full_core_kill)
2039         (record_full_core_fetch_registers)
2040         (record_full_core_prepare_to_store)
2041         (record_full_core_store_registers, record_full_core_xfer_partial)
2042         (record_full_core_insert_breakpoint)
2043         (record_full_core_remove_breakpoint)
2044         (record_full_core_has_execution): Refactor
2045         as methods of the record_full_core_target class.
2046         (record_full_base_target::supports_delete_record): New.
2047         (init_record_full_ops): Delete.
2048         (init_record_full_core_ops): Delete.
2049         (record_full_save): Refactor as method of the
2050         record_full_base_target class.
2051         (_initialize_record_full): Remove references to
2052         init_record_full_ops and init_record_full_core_ops.
2053
2054         * remote.c (remote_target, extended_remote_target): New classes.
2055         (remote_ops): Now a remote_target.
2056         (extended_remote_ops): Now an extended_remote_target.
2057         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2058         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2059         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2060         (remote_pass_signals, remote_set_syscall_catchpoint)
2061         (remote_program_signals, )
2062         (remote_thread_always_alive): Remove target_ops parameter.
2063         (remote_thread_alive, remote_thread_name)
2064         (remote_update_thread_list, remote_threads_extra_info)
2065         (remote_static_tracepoint_marker_at)
2066         (remote_static_tracepoint_markers_by_strid)
2067         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2068         (remote_open): Refactor as methods of remote_target.
2069         (extended_remote_open, extended_remote_detach)
2070         (extended_remote_attach, extended_remote_post_attach):
2071         (extended_remote_supports_disable_randomization)
2072         (extended_remote_create_inferior): : Refactor as method of
2073         extended_remote_target.
2074         (remote_set_permissions, remote_open_1, remote_detach)
2075         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2076         (remote_resume, remote_commit_resume, remote_stop)
2077         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2078         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2079         (remote_prepare_to_store, remote_store_registers)
2080         (remote_flash_erase, remote_flash_done, remote_files_info)
2081         (remote_kill, remote_mourn, remote_insert_breakpoint)
2082         (remote_remove_breakpoint, remote_insert_watchpoint)
2083         (remote_watchpoint_addr_within_range)
2084         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2085         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2086         (remote_supports_stopped_by_sw_breakpoint)
2087         (remote_stopped_by_hw_breakpoint)
2088         (remote_supports_stopped_by_hw_breakpoint)
2089         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2090         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2091         (remote_verify_memory): Refactor as methods of remote_target.
2092         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2093         parameter.
2094         (remote_xfer_partial, remote_get_memory_xfer_limit)
2095         (remote_search_memory, remote_rcmd, remote_memory_map)
2096         (remote_pid_to_str, remote_get_thread_local_address)
2097         (remote_get_tib_address, remote_read_description): Refactor as
2098         methods of remote_target.
2099         (remote_target::fileio_open, remote_target::fileio_pwrite)
2100         (remote_target::fileio_pread, remote_target::fileio_close): New.
2101         (remote_hostio_readlink, remote_hostio_fstat)
2102         (remote_filesystem_is_local, remote_can_execute_reverse)
2103         (remote_supports_non_stop, remote_supports_disable_randomization)
2104         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2105         (remote_supports_enable_disable_tracepoint)
2106         (remote_supports_string_tracing)
2107         (remote_can_run_breakpoint_commands, remote_trace_init)
2108         (remote_download_tracepoint, remote_can_download_tracepoint)
2109         (remote_download_trace_state_variable, remote_enable_tracepoint)
2110         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2111         (remote_trace_start, remote_get_trace_status)
2112         (remote_get_tracepoint_status, remote_trace_stop)
2113         (remote_trace_find, remote_get_trace_state_variable_value)
2114         (remote_save_trace_data, remote_get_raw_trace_data)
2115         (remote_set_disconnected_tracing, remote_core_of_thread)
2116         (remote_set_circular_trace_buffer, remote_traceframe_info)
2117         (remote_get_min_fast_tracepoint_insn_len)
2118         (remote_set_trace_buffer_size, remote_set_trace_notes)
2119         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2120         (remote_disable_btrace, remote_teardown_btrace)
2121         (remote_read_btrace, remote_btrace_conf)
2122         (remote_augmented_libraries_svr4_read, remote_load)
2123         (remote_pid_to_exec_file, remote_can_do_single_step)
2124         (remote_execution_direction, remote_thread_handle_to_thread_info):
2125         Refactor as methods of remote_target.
2126         (init_remote_ops, init_extended_remote_ops): Delete.
2127         (remote_can_async_p, remote_is_async_p, remote_async)
2128         (remote_thread_events, remote_upload_tracepoints)
2129         (remote_upload_trace_state_variables): Refactor as methods of
2130         remote_target.
2131         (_initialize_remote): Remove references to init_remote_ops and
2132         init_extended_remote_ops.
2133
2134         * remote-sim.c (gdbsim_target): New class.
2135         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2136         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2137         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2138         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2139         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2140         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2141         Refactor as methods of gdbsim_target.
2142         (gdbsim_ops): Now a gdbsim_target.
2143         (init_gdbsim_ops): Delete.
2144         (gdbsim_cntrl_c): Adjust.
2145         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2146
2147         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2148         (the_amd64_linux_nat_target): New.
2149         (amd64_linux_fetch_inferior_registers)
2150         (amd64_linux_store_inferior_registers): Refactor as methods of
2151         amd64_linux_nat_target.
2152         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2153         * i386-linux-nat.c: Don't include "linux-nat.h".
2154         (i386_linux_nat_target): New class.
2155         (the_i386_linux_nat_target): New.
2156         (i386_linux_fetch_inferior_registers)
2157         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2158         as methods of i386_linux_nat_target.
2159         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2160         * inf-child.c (inf_child_ops): Delete.
2161         (inf_child_fetch_inferior_registers)
2162         (inf_child_store_inferior_registers): Delete.
2163         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2164         methods of inf_child_target.
2165         (inf_child_target::supports_terminal_ours)
2166         (inf_child_target::terminal_init)
2167         (inf_child_target::terminal_inferior)
2168         (inf_child_target::terminal_ours_for_output)
2169         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2170         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2171         New.
2172         (inf_child_open, inf_child_disconnect, inf_child_close)
2173         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2174         (inf_child_post_startup_inferior, inf_child_can_run)
2175         (inf_child_pid_to_exec_file): Refactor as methods of
2176         inf_child_target.
2177         (inf_child_follow_fork): Delete.
2178         (inf_child_target::can_create_inferior)
2179         (inf_child_target::can_attach): New.
2180         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2181         (inf_child_target::has_stack, inf_child_target::has_registers)
2182         (inf_child_target::has_execution): New.
2183         (inf_child_fileio_open, inf_child_fileio_pwrite)
2184         (inf_child_fileio_pread, inf_child_fileio_fstat)
2185         (inf_child_fileio_close, inf_child_fileio_unlink)
2186         (inf_child_fileio_readlink, inf_child_use_agent)
2187         (inf_child_can_use_agent): Refactor as methods of
2188         inf_child_target.
2189         (return_zero, inf_child_target): Delete.
2190         (inf_child_target::inf_child_target): New.
2191         * inf-child.h: Include "target.h".
2192         (inf_child_target): Delete function prototype.
2193         (inf_child_target): New class.
2194         (inf_child_open_target, inf_child_mourn_inferior)
2195         (inf_child_maybe_unpush_target): Delete.
2196         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2197         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2198         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2199         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2200         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2201         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2202         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2203         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2204         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2205         methods of inf_ptrace_target.
2206         (inf_ptrace_target): Delete function.
2207         * inf-ptrace.h: Include "inf-child.h".
2208         (inf_ptrace_target): Delete function declaration.
2209         (inf_ptrace_target): New class.
2210         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2211         * linux-nat.c (linux_target): New.
2212         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2213         (linux_nat_target::~linux_nat_target): New.
2214         (linux_child_post_attach, linux_child_post_startup_inferior)
2215         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2216         (linux_child_remove_fork_catchpoint)
2217         (linux_child_insert_vfork_catchpoint)
2218         (linux_child_remove_vfork_catchpoint)
2219         (linux_child_insert_exec_catchpoint)
2220         (linux_child_remove_exec_catchpoint)
2221         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2222         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2223         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2224         (linux_nat_stopped_data_address)
2225         (linux_nat_stopped_by_sw_breakpoint)
2226         (linux_nat_supports_stopped_by_sw_breakpoint)
2227         (linux_nat_stopped_by_hw_breakpoint)
2228         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2229         (linux_nat_kill, linux_nat_mourn_inferior)
2230         (linux_nat_xfer_partial, linux_nat_thread_alive)
2231         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2232         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2233         (linux_child_static_tracepoint_markers_by_strid)
2234         (linux_nat_is_async_p, linux_nat_can_async_p)
2235         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2236         (linux_nat_supports_multi_process)
2237         (linux_nat_supports_disable_randomization, linux_nat_async)
2238         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2239         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2240         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2241         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2242         methods of linux_nat_target.
2243         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2244         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2245         parameter.
2246         (check_stopped_by_watchpoint): Adjust.
2247         (linux_xfer_partial): Delete.
2248         (linux_target_install_ops, linux_target, linux_nat_add_target):
2249         Delete.
2250         (linux_nat_target::linux_nat_target): New.
2251         * linux-nat.h: Include "inf-ptrace.h".
2252         (linux_nat_target): New.
2253         (linux_target, linux_target_install_ops, linux_nat_add_target):
2254         Delete function declarations.
2255         (linux_target): Declare global.
2256         * linux-thread-db.c (thread_db_target): New.
2257         (thread_db_target::thread_db_target): New.
2258         (thread_db_ops): Delete.
2259         (the_thread_db_target): New.
2260         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2261         (thread_db_update_thread_list, thread_db_pid_to_str)
2262         (thread_db_extra_thread_info)
2263         (thread_db_thread_handle_to_thread_info)
2264         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2265         (thread_db_resume): Refactor as methods of thread_db_target.
2266         (init_thread_db_ops): Delete.
2267         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2268         * x86-linux-nat.c: Don't include "linux-nat.h".
2269         (super_post_startup_inferior): Delete.
2270         (x86_linux_nat_target::~x86_linux_nat_target): New.
2271         (x86_linux_child_post_startup_inferior)
2272         (x86_linux_read_description, x86_linux_enable_btrace)
2273         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2274         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2275         methods of x86_linux_nat_target.
2276         (x86_linux_create_target): Delete.  Bits folded ...
2277         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2278         pointer.
2279         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2280         (x86_linux_nat_target): New class.
2281         (x86_linux_create_target): Delete.
2282         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2283         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2284         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2285         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2286         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2287         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2288         make extern.
2289         (x86_use_watchpoints): Delete.
2290         * x86-nat.h: Include "breakpoint.h" and "target.h".
2291         (x86_use_watchpoints): Delete.
2292         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2293         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2294         (x86_insert_watchpoint, x86_remove_watchpoint)
2295         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2296         (x86_stopped_by_hw_breakpoint): New declarations.
2297         (x86_nat_target): New template class.
2298
2299         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2300         (the_ppc_linux_nat_target): New.
2301         (ppc_linux_fetch_inferior_registers)
2302         (ppc_linux_can_use_hw_breakpoint)
2303         (ppc_linux_region_ok_for_hw_watchpoint)
2304         (ppc_linux_ranged_break_num_registers)
2305         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2306         (ppc_linux_insert_mask_watchpoint)
2307         (ppc_linux_remove_mask_watchpoint)
2308         (ppc_linux_can_accel_watchpoint_condition)
2309         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2310         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2311         (ppc_linux_watchpoint_addr_within_range)
2312         (ppc_linux_masked_watch_num_registers)
2313         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2314         (ppc_linux_read_description): Refactor as methods of
2315         ppc_linux_nat_target.
2316         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2317
2318         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2319         (procfs_target): New class.
2320         (the_procfs_target): New.
2321         (procfs_target): Delete function.
2322         (procfs_auxv_parse, procfs_attach, procfs_detach)
2323         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2324         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2325         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2326         (procfs_create_inferior, procfs_update_thread_list)
2327         (procfs_thread_alive, procfs_pid_to_str)
2328         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2329         (procfs_stopped_data_address, procfs_insert_watchpoint)
2330         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2331         (proc_find_memory_regions, procfs_info_proc)
2332         (procfs_make_note_section): Refactor as methods of procfs_target.
2333         (_initialize_procfs): Adjust.
2334         * sol-thread.c (sol_thread_target): New class.
2335         (sol_thread_ops): Now a sol_thread_target.
2336         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2337         (sol_thread_fetch_registers, sol_thread_store_registers)
2338         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2339         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2340         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2341         (init_sol_thread_ops): Delete.
2342         (_initialize_sol_thread): Adjust.  Remove references to
2343         init_sol_thread_ops and complete_target_initialization.
2344
2345         * windows-nat.c (windows_nat_target): New class.
2346         (windows_fetch_inferior_registers)
2347         (windows_store_inferior_registers, windows_resume, windows_wait)
2348         (windows_attach, windows_detach, windows_pid_to_exec_file)
2349         (windows_files_info, windows_create_inferior)
2350         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2351         (windows_close, windows_pid_to_str, windows_xfer_partial)
2352         (windows_get_tib_address, windows_get_ada_task_ptid)
2353         (windows_thread_name, windows_thread_alive): Refactor as
2354         windows_nat_target methods.
2355         (do_initial_windows_stuff): Adjust.
2356         (windows_target): Delete function.
2357         (_initialize_windows_nat): Adjust.
2358
2359         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2360         (darwin_mourn_inferior, darwin_kill_inferior)
2361         (darwin_create_inferior, darwin_attach, darwin_detach)
2362         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2363         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2364         (darwin_supports_multi_process): Refactor as darwin_nat_target
2365         methods.
2366         (darwin_resume_to, darwin_files_info): Delete.
2367         (_initialize_darwin_inferior): Rename to ...
2368         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2369         * darwin-nat.h: Include "inf-child.h".
2370         (darwin_nat_target): New class.
2371         (darwin_complete_target): Delete.
2372         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2373         (darwin_target): New.
2374         (i386_darwin_fetch_inferior_registers)
2375         (i386_darwin_store_inferior_registers): Refactor as methods of
2376         darwin_nat_target.
2377         (darwin_complete_target): Delete, with ...
2378         (_initialize_i386_darwin_nat): ... bits factored out here.
2379
2380         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2381         (the_alpha_linux_nat_target): New.
2382         (alpha_linux_register_u_offset): Refactor as
2383         alpha_linux_nat_target method.
2384         (_initialize_alpha_linux_nat): Adjust.
2385         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2386         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2387         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2388         methods of linux_nat_trad_target.
2389         (linux_trad_target): Delete.
2390         * linux-nat-trad.h (linux_trad_target): Delete function.
2391         (linux_nat_trad_target): New class.
2392         * mips-linux-nat.c (mips_linux_nat_target): New class.
2393         (super_fetch_registers, super_store_registers, super_close):
2394         Delete.
2395         (the_mips_linux_nat_target): New.
2396         (mips64_linux_regsets_fetch_registers)
2397         (mips64_linux_regsets_store_registers)
2398         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2399         (mips_linux_register_u_offset, mips_linux_read_description)
2400         (mips_linux_can_use_hw_breakpoint)
2401         (mips_linux_stopped_by_watchpoint)
2402         (mips_linux_stopped_data_address)
2403         (mips_linux_region_ok_for_hw_watchpoint)
2404         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2405         (mips_linux_close): Refactor as methods of mips_linux_nat.
2406         (_initialize_mips_linux_nat): Adjust to C++ification.
2407
2408         * aix-thread.c (aix_thread_target): New class.
2409         (aix_thread_ops): Now an aix_thread_target.
2410         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2411         (aix_thread_fetch_registers, aix_thread_store_registers)
2412         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2413         (aix_thread_thread_alive, aix_thread_pid_to_str)
2414         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2415         Refactor as methods of aix_thread_target.
2416         (init_aix_thread_ops): Delete.
2417         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2418         and complete_target_initialization.
2419         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2420         (rs6000_nat_target): New class.
2421         (the_rs6000_nat_target): New.
2422         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2423         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2424         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2425         (super_create_inferior): Delete.
2426         (_initialize_rs6000_nat): Adjust to C++ification.
2427
2428         * arm-linux-nat.c (arm_linux_nat_target): New class.
2429         (the_arm_linux_nat_target): New.
2430         (arm_linux_fetch_inferior_registers)
2431         (arm_linux_store_inferior_registers, arm_linux_read_description)
2432         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2433         (arm_linux_remove_hw_breakpoint)
2434         (arm_linux_region_ok_for_hw_watchpoint)
2435         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2436         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2437         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2438         arm_linux_nat_target.
2439         (_initialize_arm_linux_nat): Adjust to C++ification.
2440
2441         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2442         (the_aarch64_linux_nat_target): New.
2443         (aarch64_linux_fetch_inferior_registers)
2444         (aarch64_linux_store_inferior_registers)
2445         (aarch64_linux_child_post_startup_inferior)
2446         (aarch64_linux_read_description)
2447         (aarch64_linux_can_use_hw_breakpoint)
2448         (aarch64_linux_insert_hw_breakpoint)
2449         (aarch64_linux_remove_hw_breakpoint)
2450         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2451         (aarch64_linux_region_ok_for_hw_watchpoint)
2452         (aarch64_linux_stopped_data_address)
2453         (aarch64_linux_stopped_by_watchpoint)
2454         (aarch64_linux_watchpoint_addr_within_range)
2455         (aarch64_linux_can_do_single_step): Refactor as methods of
2456         aarch64_linux_nat_target.
2457         (super_post_startup_inferior): Delete.
2458         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2459
2460         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2461         (the_hppa_linux_nat_target): New.
2462         (hppa_linux_fetch_inferior_registers)
2463         (hppa_linux_store_inferior_registers): Refactor as methods of
2464         hppa_linux_nat_target.
2465         (_initialize_hppa_linux_nat): Adjust to C++ification.
2466
2467         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2468         (the_ia64_linux_nat_target): New.
2469         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2470         (ia64_linux_stopped_data_address)
2471         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2472         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2473         ia64_linux_nat_target methods.
2474         (super_xfer_partial): Delete.
2475         (_initialize_ia64_linux_nat): Adjust to C++ification.
2476
2477         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2478         (the_m32r_linux_nat_target): New.
2479         (m32r_linux_fetch_inferior_registers)
2480         (m32r_linux_store_inferior_registers): Refactor as
2481         m32r_linux_nat_target methods.
2482         (_initialize_m32r_linux_nat): Adjust to C++ification.
2483
2484         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2485         (the_m68k_linux_nat_target): New.
2486         (m68k_linux_fetch_inferior_registers)
2487         (m68k_linux_store_inferior_registers): Refactor as
2488         m68k_linux_nat_target methods.
2489         (_initialize_m68k_linux_nat): Adjust to C++ification.
2490
2491         * s390-linux-nat.c (s390_linux_nat_target): New class.
2492         (the_s390_linux_nat_target): New.
2493         (s390_linux_fetch_inferior_registers)
2494         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2495         (s390_insert_watchpoint, s390_remove_watchpoint)
2496         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2497         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2498         (s390_auxv_parse, s390_read_description): Refactor as methods of
2499         s390_linux_nat_target.
2500         (_initialize_s390_nat): Adjust to C++ification.
2501
2502         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2503         (the_sparc_linux_nat_target): New.
2504         (_initialize_sparc_linux_nat): Adjust to C++ification.
2505         * sparc-nat.c (sparc_fetch_inferior_registers)
2506         (sparc_store_inferior_registers): Remove target_ops parameter.
2507         * sparc-nat.h (sparc_fetch_inferior_registers)
2508         (sparc_store_inferior_registers): Remove target_ops parameter.
2509         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2510         (the_sparc64_linux_nat_target): New.
2511         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2512
2513         * spu-linux-nat.c (spu_linux_nat_target): New class.
2514         (the_spu_linux_nat_target): New.
2515         (spu_child_post_startup_inferior, spu_child_post_attach)
2516         (spu_child_wait, spu_fetch_inferior_registers)
2517         (spu_store_inferior_registers, spu_xfer_partial)
2518         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2519         methods.
2520         (_initialize_spu_nat): Adjust to C++ification.
2521
2522         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2523         (the_tilegx_linux_nat_target): New.
2524         (fetch_inferior_registers, store_inferior_registers):
2525         Refactor as methods.
2526         (_initialize_tile_linux_nat): Adjust to C++ification.
2527
2528         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2529         (the_xtensa_linux_nat_target): New.
2530         (xtensa_linux_fetch_inferior_registers)
2531         (xtensa_linux_store_inferior_registers): Refactor as
2532         xtensa_linux_nat_target methods.
2533         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2534
2535         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2536         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2537         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2538         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2539         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2540         (fbsd_stopped_by_sw_breakpoint)
2541         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2542         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2543         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2544         (fbsd_post_startup_inferior, fbsd_post_attach)
2545         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2546         (fbsd_set_syscall_catchpoint)
2547         (super_xfer_partial, super_resume, super_wait)
2548         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2549         (fbsd_handle_debug_trap): Remove target_ops parameter.
2550         (fbsd_nat_add_target): Delete.
2551         * fbsd-nat.h: Include "inf-ptrace.h".
2552         (fbsd_nat_add_target): Delete.
2553         (USE_SIGTRAP_SIGINFO): Define.
2554         (fbsd_nat_target): New class.
2555
2556         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2557         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2558         (amd64bsd_target): Delete.
2559         * amd64-bsd-nat.h: New file.
2560         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2561         "x86-bsd-nat.h".
2562         (amd64_fbsd_nat_target): New class.
2563         (the_amd64_fbsd_nat_target): New.
2564         (amd64fbsd_read_description): Refactor as method of
2565         amd64_fbsd_nat_target.
2566         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2567         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2568         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2569         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2570         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2571         (i386bsd_target): Delete.
2572         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2573         (i386bsd_fetch_inferior_registers)
2574         (i386bsd_store_inferior_registers): Declare.
2575         (i386_bsd_nat_target): New class.
2576         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2577         (the_i386_fbsd_nat_target): New.
2578         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2579         i386_fbsd_nat_target methods.
2580         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2581         (_initialize_i386fbsd_nat): Adjust to C++ification.
2582         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2583         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2584         (_initialize_x86_bsd_nat): Adjust to C++ification.
2585         * x86-bsd-nat.h: Include "x86-nat.h".
2586         (x86bsd_target): Delete declaration.
2587         (x86bsd_nat_target): New class.
2588
2589         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2590         (the_aarch64_fbsd_nat_target): New.
2591         (aarch64_fbsd_fetch_inferior_registers)
2592         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2593         aarch64_fbsd_nat_target.
2594         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2595         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2596         (the_alpha_bsd_nat_target): New.
2597         (alphabsd_fetch_inferior_registers)
2598         (alphabsd_store_inferior_registers): Refactor as
2599         alpha_bsd_nat_target methods.
2600         (_initialize_alphabsd_nat): Refactor as methods of
2601         alpha_bsd_nat_target.
2602         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2603         (the_amd64_nbsd_nat_target): New.
2604         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2605         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2606         (the_amd64_obsd_nat_target): New.
2607         (_initialize_amd64obsd_nat): Adjust to C++ification.
2608         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2609         (the_arm_fbsd_nat_target): New.
2610         (arm_fbsd_fetch_inferior_registers)
2611         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2612         (_initialize_arm_fbsd_nat): Refactor as methods of
2613         arm_fbsd_nat_target.
2614         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2615         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2616         (the_arm_netbsd_nat_target): New.
2617         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2618         arm_netbsd_nat_target.
2619         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2620         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2621         (the_hppa_nbsd_nat_target): New.
2622         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2623         hppa_nbsd_nat_target methods.
2624         (_initialize_hppanbsd_nat): Adjust to C++ification.
2625         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2626         (the_hppa_obsd_nat_target): New.
2627         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2628         methods of hppa_obsd_nat_target.
2629         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2630         add_target.
2631         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2632         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2633         add_target.
2634         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2635         (_initialize_i386obsd_nat): Use add_target.
2636         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2637         (the_m68k_bsd_nat_target): New.
2638         (m68kbsd_fetch_inferior_registers)
2639         (m68kbsd_store_inferior_registers): Refactor as methods of
2640         m68k_bsd_nat_target.
2641         (_initialize_m68kbsd_nat): Adjust to C++ification.
2642         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2643         (the_mips_fbsd_nat_target): New.
2644         (mips_fbsd_fetch_inferior_registers)
2645         (mips_fbsd_store_inferior_registers): Refactor as methods of
2646         mips_fbsd_nat_target.
2647         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2648         add_target.
2649         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2650         (the_mips_nbsd_nat_target): New.
2651         (mipsnbsd_fetch_inferior_registers)
2652         (mipsnbsd_store_inferior_registers): Refactor as methods of
2653         mips_nbsd_nat_target.
2654         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2655         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2656         (the_mips64_obsd_nat_target): New.
2657         (mips64obsd_fetch_inferior_registers)
2658         (mips64obsd_store_inferior_registers): Refactor as methods of
2659         mips64_obsd_nat_target.
2660         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2661         add_target.
2662         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2663         nbsd_nat_target.
2664         * nbsd-nat.h: Include "inf-ptrace.h".
2665         (nbsd_nat_target): New class.
2666         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2667         (obsd_wait): Refactor as methods of obsd_nat_target.
2668         (obsd_add_target): Delete.
2669         * obsd-nat.h: Include "inf-ptrace.h".
2670         (obsd_nat_target): New class.
2671         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2672         (the_ppc_fbsd_nat_target): New.
2673         (ppcfbsd_fetch_inferior_registers)
2674         (ppcfbsd_store_inferior_registers): Refactor as methods of
2675         ppc_fbsd_nat_target.
2676         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2677         add_target.
2678         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2679         (the_ppc_nbsd_nat_target): New.
2680         (ppcnbsd_fetch_inferior_registers)
2681         (ppcnbsd_store_inferior_registers): Refactor as methods of
2682         ppc_nbsd_nat_target.
2683         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2684         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2685         (the_ppc_obsd_nat_target): New.
2686         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2687         methods of ppc_obsd_nat_target.
2688         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2689         add_target.
2690         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2691         (the_sh_nbsd_nat_target): New.
2692         (shnbsd_fetch_inferior_registers)
2693         (shnbsd_store_inferior_registers): Refactor as methods of
2694         sh_nbsd_nat_target.
2695         (_initialize_shnbsd_nat): Adjust to C++ification.
2696         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2697         (inf_ptrace_xfer_partial): Delete.
2698         (sparc_xfer_partial, sparc_target): Delete.
2699         * sparc-nat.h (sparc_fetch_inferior_registers)
2700         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2701         (sparc_target): Delete function declaration.
2702         (sparc_target): New template class.
2703         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2704         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2705         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2706         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2707         add_target.
2708         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2709         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2710         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2711         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2712         add_target.
2713         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2714         (the_vax_bsd_nat_target): New.
2715         (vaxbsd_fetch_inferior_registers)
2716         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2717         methods.
2718         (_initialize_vaxbsd_nat): Adjust to C++ification.
2719
2720         * bsd-kvm.c (bsd_kvm_target): New class.
2721         (bsd_kvm_ops): Now a bsd_kvm_target.
2722         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2723         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2724         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2725         bsd_kvm_target.
2726         (bsd_kvm_return_one): Delete.
2727         (bsd_kvm_add_target): Adjust to C++ification.
2728
2729         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2730         (nto_procfs_target_procfs): New classes.
2731         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2732         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2733         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2734         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2735         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2736         (procfs_remove_hw_breakpoint, procfs_resume)
2737         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2738         (procfs_kill_inferior, procfs_store_registers)
2739         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2740         as methods of nto_procfs_target.
2741         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2742         (nto_native_ops): Delete.
2743         (procfs_open, procfs_native_open): Delete.
2744         (nto_native_ops): Now an nto_procfs_target_native.
2745         (init_procfs_targets): Adjust to C++ification.
2746         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2747         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2748         Refactor as methods of nto_procfs_target.
2749
2750         * go32-nat.c (go32_nat_target): New class.
2751         (the_go32_nat_target): New.
2752         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2753         (go32_store_registers, go32_xfer_partial, go32_files_info)
2754         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2755         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2756         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2757         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2758         (go32_target): Delete.
2759         (_initialize_go32_nat): Adjust to C++ification.
2760
2761         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2762         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2763         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2764         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2765         gnu_nat_target.
2766         (gnu_target): Delete.
2767         * gnu-nat.h (gnu_target): Delete.
2768         (gnu_nat_target): New class.
2769         * i386-gnu-nat.c (gnu_base_target): New.
2770         (i386_gnu_nat_target): New class.
2771         (the_i386_gnu_nat_target): New.
2772         (_initialize_i386gnu_nat): Adjust to C++ification.
2773
2774 2018-05-02  Pedro Alves  <palves@redhat.com>
2775
2776         * bfd-target.c (target_bfd_xclose): Rename to ...
2777         (target_bfd_close): ... this.
2778         (target_bfd_reopen): Adjust.
2779         * target.c (target_close): Remove references to to_xclose.
2780         * target.h (target_ops::to_xclose): Delete.
2781         (target_ops::to_close): Update comments.
2782
2783 2018-05-02  Pedro Alves  <palves@redhat.com>
2784
2785         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2786         "linux-nat.h".
2787         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2788         * inf-ptrace.c (inf_ptrace_register_u_offset)
2789         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2790         (inf_ptrace_store_register, inf_ptrace_store_registers)
2791         (inf_ptrace_trad_target): Move to ...
2792         * linux-nat-trad.c: ... this new file.
2793         * linux-nat-trad.h: New file.
2794         * linux-nat.c (linux_target_install_ops): Make extern.
2795         (linux_trad_target): Delete.
2796         * linux-nat.h (linux_trad_target): Delete declaration.
2797         (linux_target_install_ops): Declare.
2798         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2799         "linux-nat.h".
2800
2801 2018-05-02  Pedro Alves  <palves@redhat.com>
2802
2803         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2804         procfs_target/add_target here.
2805         * procfs.c (procfs_target): Make static.
2806         (_initialize_procfs): Call add_target here.
2807         * procfs.h (struct target_ops): Remove forward declaration.
2808         (procfs_target): Remove declaration.
2809         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2810
2811 2018-05-02  Pedro Alves  <palves@redhat.com>
2812
2813         * procfs.c (procfs_stopped_by_watchpoint)
2814         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2815         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2816         Forward declare.
2817         (procfs_use_watchpoints): Delete, move contents...
2818         (procfs_target): ... here.
2819         * procfs.h (procfs_use_watchpoints): Delete declaration.
2820         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2821         procfs_use_watchpoints.
2822         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2823         procfs_use_watchpoints.
2824
2825 2018-05-02  Tom Tromey  <tom@tromey.com>
2826
2827         PR python/20084:
2828         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2829         and var_zuinteger_unlimited.
2830         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2831         and PARAM_ZUINTEGER_UNLIMITED.
2832         (set_parameter_value): Handle var_zuinteger and
2833         var_zuinteger_unlimited.
2834         (add_setshow_generic): Likewise.
2835         (parmpy_init): Likewise.
2836
2837 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2838
2839         PR rust/23124
2840         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2841         pointer is not null before dereferencing it.
2842
2843 2018-04-30  Tom Tromey  <tom@tromey.com>
2844
2845         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2846         is_mi_like_p.
2847
2848 2018-04-30  Tom Tromey  <tom@tromey.com>
2849
2850         * breakpoint.c (mention): Remove use of is_mi_like_p.
2851         (print_mention_ranged_breakpoint): Likewise.
2852         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2853         of is_mi_like_p.
2854
2855 2018-04-30  Tom Tromey  <tom@tromey.com>
2856
2857         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2858
2859 2018-04-30  Tom Tromey  <tom@tromey.com>
2860
2861         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2862         (info_spu_event_command): Remove some uses of is_mi_like_p.
2863
2864 2018-04-30  Tom Tromey  <tom@tromey.com>
2865
2866         * python/py-framefilter.c (py_print_single_arg)
2867         (enumerate_locals, py_print_args, py_print_frame): Remove some
2868         uses of is_mi_like_p.
2869
2870 2018-04-30  Tom Tromey  <tom@tromey.com>
2871
2872         * ui-out.c: Update.
2873         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2874         * ui-out.h (ui_out::is_mi_like_p): Now const.
2875         (ui_out::do_is_mi_like_p): Now const.
2876         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2877
2878 2018-04-30  Tom Tromey  <tom@tromey.com>
2879
2880         * varobj.c (varobj_set_visualizer): Use new_reference.
2881         * python/python.c (gdbpy_decode_line): Use new_reference.
2882         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2883         new_reference.
2884
2885 2018-04-30  Tom Tromey  <tom@tromey.com>
2886
2887         * varobj.c (install_new_value): Use new_reference.
2888         * value.h (value_incref): Return void.  Swap intro comment with
2889         value_decref.
2890         * value.c (set_value_parent): Use new_reference.
2891         (value_incref): Return void.  Update intro comment.
2892         (release_value): Use new_reference.
2893         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2894
2895 2018-04-30  Tom Tromey  <tom@tromey.com>
2896
2897         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2898         * gdb_bfd.h (new_bfd_ref): Remove.
2899         (gdb_bfd_open): Update comment.
2900         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2901         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2902         (gdb_bfd_fdopenr): Use new_reference.
2903         * exec.c (exec_file_attach): Use new_reference.
2904
2905 2018-04-30  Tom Tromey  <tom@tromey.com>
2906
2907         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2908         method.
2909
2910 2018-04-30  Tom Tromey  <tom@tromey.com>
2911
2912         * jit.c (jit_read_code_entry): Use type_align.
2913         * i386-tdep.c (i386_gdbarch_init): Don't call
2914         set_gdbarch_long_long_align_bit.
2915         * gdbarch.sh: Remove long_long_align_bit.
2916         * gdbarch.c, gdbarch.h: Rebuild.
2917         * arc-tdep.c (arc_type_align): New function.
2918         (arc_gdbarch_init): Use arc_type_align.  Don't call
2919         set_gdbarch_long_long_align_bit.
2920
2921 2018-04-30  Tom Tromey  <tom@tromey.com>
2922
2923         * rust-lang.c (rust_type_alignment): Remove.
2924         (rust_composite_type): Use type_align.
2925
2926 2018-04-30  Tom Tromey  <tom@tromey.com>
2927
2928         * NEWS: Mention Type.align.
2929         * python/py-type.c (typy_get_alignof): New function.
2930         (type_object_getset): Add "alignof".
2931
2932 2018-04-30  Tom Tromey  <tom@tromey.com>
2933
2934         PR exp/17095:
2935         * NEWS: Update.
2936         * std-operator.def (UNOP_ALIGNOF): New operator.
2937         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2938         New.
2939         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2940         * c-lang.c (c_op_print_tab): Add alignof.
2941         * c-exp.y (ALIGNOF): New token.
2942         (exp): Add "ALIGNOF" production.
2943         (ident_tokens): Add _Alignof and alignof.
2944
2945 2018-04-30  Tom Tromey  <tom@tromey.com>
2946
2947         * i386-tdep.c (i386_type_align): New function.
2948         (i386_gdbarch_init): Update.
2949         * gdbarch.sh (type_align): New method.
2950         * gdbarch.c, gdbarch.h: Rebuild.
2951         * arch-utils.h (default_type_align): Declare.
2952         * arch-utils.c (default_type_align): New function.
2953         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2954         (struct type) <align_log2>: New field.
2955         <instance_flags>: Now a bitfield.
2956         (TYPE_RAW_ALIGN): New macro.
2957         (type_align, type_raw_align, set_type_align): Declare.
2958         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2959         functions.
2960         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2961         (get_alignment, maybe_set_alignment): New functions.
2962         (read_structure_type, read_enumeration_type, read_array_type)
2963         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2964         (read_subrange_type, read_base_type): Set type alignment.
2965
2966 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2967
2968         * dwarf2read.c (read_index_from_section): Use bool.
2969
2970 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2971
2972         PR gdb/22950
2973         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2974         with #ifdef.
2975
2976 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2977
2978         PR build/22873
2979         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2980         last step, and do it atomically.
2981
2982 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2983
2984         * compile/compile-c-types.c (convert_int, convert_float):
2985         Update for C FE v1.
2986
2987 2018-04-27  Tom Tromey  <tom@tromey.com>
2988
2989         PR rust/22545:
2990         * rust-lang.c (rust_inclusive_range_type_p): New function.
2991         (rust_range): Handle inclusive ranges.
2992         (rust_compute_range): Likewise.
2993         * rust-exp.y (struct rust_op) <inclusive>: New field.
2994         (DOTDOTEQ): New constant.
2995         (range_expr): Add "..=" productions.
2996         (operator_tokens): Add "..=" token.
2997         (ast_range): Add "inclusive" parameter.
2998         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2999         ranges.
3000         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3001         bounds values.
3002         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3003         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3004         Update comments.
3005         * expprint.c (print_subexp_standard): Handle new bounds values.
3006         (dump_subexp_body_standard): Likewise.
3007
3008 2018-04-27  Tom Tromey  <tom@tromey.com>
3009
3010         * configure: Rebuild.
3011         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3012         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3013         "OVERRIDE".
3014         (class symbol_needs_eval_context): Likewise.
3015         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3016         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3017         "virtual".
3018         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3019         "override".
3020         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3021         * aarch64-tdep.c (instruction_reader::read): Use "override".
3022         (instruction_reader_test::read): Likewise.
3023         * arm-tdep.c (instruction_reader::read): Use "override".
3024         (instruction_reader_thumb::read): Likewise.
3025
3026 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3027
3028         PR remote/9665
3029         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3030         instead of remote_send.
3031         (remote_send): Remove.
3032
3033 2018-04-26  Pedro Alves  <palves@redhat.com>
3034
3035         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3036         find_function_start_sal instead of find_pc_line.
3037
3038 2018-04-26  Pedro Alves  <palves@redhat.com>
3039
3040         * breakpoint.c (set_breakpoint_location_function): Handle
3041         mst_data_gnu_ifunc.
3042         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3043         * elfread.c (elf_symtab_read): Give data symbols with
3044         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3045         (elf_rel_plt_read): Update comment.
3046         * linespec.c (convert_linespec_to_sals): Handle
3047         mst_data_gnu_ifunc.
3048         (minsym_found): Handle mst_data_gnu_ifunc.
3049         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3050         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3051         * parse.c (find_minsym_type_and_address): Handle
3052         mst_data_gnu_ifunc.
3053         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3054         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3055         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3056         comment.
3057         <mst_data_gnu_ifunc>: New enumerator.
3058
3059 2018-04-26  Pedro Alves  <palves@redhat.com>
3060
3061         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3062         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3063         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3064         Handle it.
3065         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3066         (lookup_minimal_symbol_by_pc): Adjust.
3067         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3068         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3069         * minsyms.h (lookup_msym_prefer): New enum.
3070         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3071         parameter by a lookup_msym_prefer parameter.
3072
3073 2018-04-26  Pedro Alves  <palves@redhat.com>
3074
3075         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3076         ends in "@plt" instead of looking at the symbol's section.
3077
3078 2018-04-26  Pedro Alves  <palves@redhat.com>
3079
3080         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3081         all references.
3082         (find_pc_partial_function_gnu_ifunc): Rename to ...
3083         (find_pc_partial_function): ... this, and remove references to
3084         'is_gnu_ifunc_p'.
3085         (find_pc_partial_function): Delete old implementation.
3086         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3087
3088 2018-04-26  Pedro Alves  <palves@redhat.com>
3089
3090         * linespec.c (struct bound_minimal_symbol_search_key): New.
3091         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3092         skip first line if we found a GNU ifunc minimal symbol by name.
3093         (compare_msymbols): Change parameters to work with a destructured
3094         lhs minsym.
3095         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3096         functions.
3097
3098 2018-04-26  Pedro Alves  <palves@redhat.com>
3099
3100         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3101         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3102         address/name.
3103         (add_location_to_breakpoint): Store the minsym and the objfile in
3104         the breakpoint location.
3105         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3106         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3107         Record the minsym in the sal.
3108         * symtab.h (symtab_and_line) <msymbol>: New field.
3109
3110 2018-04-26  Pedro Alves  <palves@redhat.com>
3111
3112         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3113         unless we actually resolved the ifunc.
3114
3115 2018-04-26  Pedro Alves  <palves@redhat.com>
3116
3117         * c-exp.y (variable production): Prefer ifunc minsyms over
3118         regular function symbols.
3119         * symtab.c (find_gnu_ifunc): New function.
3120         * minsyms.h (lookup_msym_prefer): New enum.
3121         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3122         parameter by a lookup_msym_prefer parameter.
3123         * symtab.h (find_gnu_ifunc): New declaration.
3124
3125 2018-04-26  Pedro Alves  <palves@redhat.com>
3126
3127         * blockframe.c (find_gnu_ifunc_target_type): New function.
3128         (find_function_type): New.
3129         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3130         return a value with a memory address.
3131         (eval_call): For calls to GNU ifunc functions, try to find the
3132         type of the target function from the type that the resolver
3133         returns.
3134         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3135         symbols.
3136         * infcall.c (find_function_return_type): Delete.
3137         (find_function_addr): Add 'function_type' parameter.  For calls to
3138         GNU ifunc functions, try to find the type of the target function
3139         from the type that the resolver returns, and return it via
3140         FUNCTION_TYPE.
3141         (call_function_by_hand_dummy): Adjust to use the function type
3142         returned by find_function_addr.
3143         (find_function_addr): Add 'function_type' parameter and move
3144         description here.
3145         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3146         declarations.
3147
3148 2018-04-26  Pedro Alves  <palves@redhat.com>
3149
3150         * c-exp.y (variable production): Skip finding an alias for ifunc
3151         symbols.
3152
3153 2018-04-26  Pedro Alves  <palves@redhat.com>
3154
3155         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3156
3157 2018-04-25  Pedro Alves  <palves@redhat.com>
3158
3159         * infcmd.c (kill_command): Print the pid as string, not the whole
3160         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3161         message.
3162         * remote.c (remote_detach_1): Print the pid as string, not the
3163         whole thread's ptid.
3164
3165 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3166             Sergio Durigan Junior  <sergiodj@redhat.com>
3167             Pedro Alves  <palves@redhat.com>
3168
3169         * infcmd.c (kill_command): Print message when inferior has
3170         been killed.
3171         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3172         '1'.
3173         (add_inferior): Improve message printed when
3174         'print_inferior_events' is on.
3175         (exit_inferior): Remove message printed when
3176         'print_inferior_events' is on.
3177         (detach_inferior): Improve message printed when
3178         'print_inferior_events' is on.
3179         (initialize_inferiors): Use 'add_inferior_silent' to set
3180         'current_inferior_'.
3181         * inferior.h (print_inferior_events): Declare here as
3182         'extern'.
3183         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3184         '[Detaching...]' messages when 'print_inferior_events' is on.
3185         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3186         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3187         'Detaching after fork from child...', replace it by '... from
3188         parent...'.
3189         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3190         prefix/suffix when printing 'Detaching...' messages.  Print
3191         them when 'print_inferior_events' is on.
3192         * remote.c (remote_detach_1): Print message when detaching
3193         from inferior and '!is_fork_parent'.
3194
3195 2018-04-24  Tom Tromey  <tom@tromey.com>
3196
3197         * cli-out.h: Reindent.
3198
3199 2018-04-24  Tom Tromey  <tom@tromey.com>
3200
3201         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3202         (cli_ui_out::do_field_string): Use fputs_filtered.
3203         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3204
3205 2018-04-23  Tom Tromey  <tom@tromey.com>
3206
3207         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3208         gdb::unique_xmalloc_ptr.
3209
3210 2018-04-23  Tom Tromey  <tom@tromey.com>
3211
3212         * configure: Rebuild.
3213
3214 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3215
3216         PR gdb/23095
3217         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3218         prepare_for_testing.  Set normal_bp to r_debug_state if target
3219         is bsd.
3220
3221 2018-04-21  Pedro Alves  <palves@redhat.com>
3222             Rajendra SY  <rajendra.sy@gmail.com>
3223
3224         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3225         * remote.c (extended_remote_attach): In all-stop mode, mark the
3226         thread as executing.
3227
3228 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3229
3230         * thread.c (thread_apply_all_command): Fix comment.
3231         (thread_command): Fix comment.
3232
3233 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3234
3235         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3236         parameter.
3237         * features/aarch64-core.c (create_feature_aarch64_core):
3238         Regenerate.
3239         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3240         Likewise.
3241         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3242         Likewise.
3243         * features/i386/32bit-avx512.c
3244         (create_feature_i386_32bit_avx512): Likewise.
3245         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3246         Likewise.
3247         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3248         Likewise.
3249         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3250         Likewise.
3251         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3252         Likewise.
3253         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3254         Likewise.
3255         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3256         Likewise.
3257         * features/i386/64bit-avx512.c
3258         (create_feature_i386_64bit_avx512): Likewise.
3259         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3260         Likewise.
3261         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3262         Likewise.
3263         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3264         Likewise.
3265         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3266         Likewise.
3267         * features/i386/64bit-segments.c
3268         (create_feature_i386_64bit_segments): Likewise.
3269         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3270         Likewise.
3271         * features/i386/x32-core.c
3272         (create_feature_i386_x32_core): Likewise.
3273         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3274         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3275         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3276         * target-descriptions.c: In generated code, don't pass xml
3277         filename.
3278
3279 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3280
3281         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3282         (print_xml_feature::visit_post): Likewise.
3283         (print_xml_feature::visit): Likewise.
3284         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3285         (print_xml_feature): Add new class.
3286         * regformats/regdat.sh: Null xmltarget on feature targets.
3287         * target-descriptions.c (struct target_desc): Add xmltarget.
3288         (maintenance_check_tdesc_xml_convert): Add unittest function.
3289         (tdesc_get_features_xml): Add function to get xml.
3290         (maintenance_check_xml_descriptions): Test xml generation.
3291         * xml-tdesc.c (string_read_description_xml): Add function.
3292         * xml-tdesc.h (string_read_description_xml): Add declaration.
3293
3294 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3295
3296         * features/Makefile: Add feature marker to targets with new style
3297         target descriptions.
3298         * regformats/aarch64.dat: Regenerate.
3299         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3300         * regformats/i386/amd64-avx-linux.dat: Likewise.
3301         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3302         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3303         * regformats/i386/amd64-linux.dat: Likewise.
3304         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3305         * regformats/i386/amd64.dat: Likewise.
3306         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3307         * regformats/i386/i386-avx-linux.dat: Likewise.
3308         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3309         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3310         * regformats/i386/i386-linux.dat: Likewise.
3311         * regformats/i386/i386-mmx-linux.dat: Likewise.
3312         * regformats/i386/i386-mpx-linux.dat: Likewise.
3313         * regformats/i386/i386.dat: Likewise.
3314         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3315         * regformats/i386/x32-avx-linux.dat: Likewise.
3316         * regformats/i386/x32-linux.dat: Likewise.
3317         * regformats/tic6x-c62x-linux.dat: Likewise.
3318         * regformats/tic6x-c64x-linux.dat: Likewise.
3319         * regformats/tic6x-c64xp-linux.dat: Likewise.
3320         * regformats/regdat.sh: Parse feature marker.
3321
3322 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3323
3324         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3325         (tdesc_osabi_name): Likewise.
3326         * target-descriptions.c (tdesc_architecture_name): Add new
3327         function.
3328         (tdesc_osabi_name): Likewise.
3329
3330 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3331
3332         * common/tdesc.c (tdesc_predefined_type): Move to here.
3333         (tdesc_named_type): Likewise.
3334         (tdesc_create_vector): Likewise.
3335         (tdesc_create_struct): Likewise.
3336         (tdesc_set_struct_size): Likewise.
3337         (tdesc_create_union): Likewise.
3338         (tdesc_create_flags): Likewise.
3339         (tdesc_create_enum): Likewise.
3340         (tdesc_add_field): Likewise.
3341         (tdesc_add_typed_bitfield): Likewise.
3342         (tdesc_add_bitfield): Likewise.
3343         (tdesc_add_flag): Likewise.
3344         (tdesc_add_enum_value): Likewise.
3345         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3346         (struct tdesc_type_vector): Likewise.
3347         (struct tdesc_type_field): Likewise.
3348         (struct tdesc_type_with_fields): Likewise.
3349         (tdesc_create_enum): Add declaration.
3350         (tdesc_add_typed_bitfield): Likewise.
3351         (tdesc_add_enum_value): Likewise.
3352         * target-descriptions.c (tdesc_type_field): Move from here.
3353         (tdesc_type_builtin): Likewise.
3354         (tdesc_type_vector): Likewise.
3355         (tdesc_type_with_fields): Likewise.
3356         (tdesc_predefined_types): Likewise.
3357         (tdesc_named_type): Likewise.
3358         (tdesc_create_vector): Likewise.
3359         (tdesc_create_struct): Likewise.
3360         (tdesc_set_struct_size): Likewise.
3361         (tdesc_create_union): Likewise.
3362         (tdesc_create_flags): Likewise.
3363         (tdesc_create_enum): Likewise.
3364         (tdesc_add_field): Likewise.
3365         (tdesc_add_typed_bitfield): Likewise.
3366         (tdesc_add_bitfield): Likewise.
3367         (tdesc_add_flag): Likewise.
3368         (tdesc_add_enum_value): Likewise.
3369         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3370         (tdesc_add_typed_bitfield): Likewise.
3371         (tdesc_add_enum_value): Likewise.
3372
3373 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3374
3375         * common/tdesc.c (tdesc_feature::accept): Move to here.
3376         (tdesc_feature::operator==): Likewise.
3377         (tdesc_create_reg): Likewise.
3378         * common/tdesc.h (tdesc_type_kind): Likewise.
3379         (struct tdesc_type): Likewise.
3380         (struct tdesc_feature): Likewise.
3381         * regformats/regdat.sh: Create a feature.
3382         * target-descriptions.c (tdesc_type_kind): Move from here.
3383         (tdesc_type): Likewise.
3384         (tdesc_type_up): Likewise.
3385         (tdesc_feature): Likewise.
3386         (tdesc_create_reg): Likewise.
3387
3388 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3389
3390         * Makefile.in: Add arch/tdesc.c
3391         * common/tdesc.c: New file.
3392         * common/tdesc.h (tdesc_element_visitor): Move to here.
3393         (tdesc_element): Likewise.
3394         (tdesc_reg): Likewise.
3395         (tdesc_reg_up): Likewise.
3396         * regformats/regdef.h (reg): Add offset to constructors.
3397         * target-descriptions.c (tdesc_element_visitor): Move from here.
3398         (tdesc_element): Likewise.
3399         (tdesc_reg): Likewise.
3400         (tdesc_reg_up): Likewise.
3401
3402 2018-04-17  Tom Tromey  <tom@tromey.com>
3403
3404         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3405         discriminant field.
3406
3407 2018-04-17  Tom Tromey  <tom@tromey.com>
3408
3409         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3410
3411 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3412
3413         * symtab.c (print_symbol_info): Skip printing filename and line
3414         number when `last' is NULL.
3415         (symtab_symbol_info): Use empty string instead of NULL for first
3416         invocation of print_symbol_info.
3417         (rbreak_command): Pass NULL to `last' parameter of
3418         print_symbol_info.
3419
3420 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3421
3422         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3423         instead of nullptr.
3424
3425 2018-04-16  Pedro Alves  <palves@redhat.com>
3426
3427         * MAINTAINERS (sh): Remove.
3428         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3429         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3430         (ALLDEPFILES): Remove sh64-tdep.c.
3431         * NEWS: Mentions that support for SH-5/SH64 is removed.
3432         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3433         (sh*-*-openbsd*): Ditto.
3434         (sh64-*-elf*): Remove.
3435         (sh*): Remove.
3436         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3437         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3438         * sh-tdep.c: No longer include "sh64-tdep.h".
3439         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3440         * sh64-tdep.c, sh64-tdep.h: Remove files.
3441
3442 2018-04-16  Pedro Alves  <palves@redhat.com>
3443
3444         * MAINTAINERS: Remove m88k.
3445         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3446         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3447         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3448         * NEWS: Mention that support for m88k was removed.
3449         * configure.host (m88*-*-*): Remove support.
3450         * configure.nat (m88k-*-*): Remove support.
3451         * configure.tgt (m88*-*-openbsd*): Remove.
3452         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3453
3454 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3455
3456         * configure.tgt (x86_tobjs): New variable.
3457         (amd64_tobjs, i386_tobjs): Use it.
3458
3459 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3460
3461         * symtab.c (print_symbol_info): Precede the symbol definition by
3462         the line number when available.
3463         * NEWS: Advertise this enhancement.
3464
3465 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3466
3467         * NEWS (New options): announce set/show record btrace cpu.
3468         * btrace.c: Include record-btrace.h.
3469         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3470         the vendor is unknown.
3471         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3472         Maybe overwrite the btrace configuration's cpu.
3473         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3474         (btrace_fetch): Add cpu parameter.  Update callers.
3475         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3476         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3477         errata workarounds if the vendor is unknown.
3478         * python/py-record-btrace.c: Include record-btrace.h.
3479         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3480         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3481         * record-btrace.c (record_btrace_cpu_state_kind): New.
3482         (record_btrace_cpu): New.
3483         (set_record_btrace_cpu_cmdlist): New.
3484         (record_btrace_get_cpu): New.
3485         (require_btrace_thread, record_btrace_info)
3486         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3487         (cmd_set_record_btrace_cpu_none): New.
3488         (cmd_set_record_btrace_cpu_auto): New.
3489         (cmd_set_record_btrace_cpu): New.
3490         (cmd_show_record_btrace_cpu): New.
3491         (_initialize_record_btrace): Initialize set/show record btrace cpu
3492         commands.
3493         * record-btrace.h (record_btrace_get_cpu): New.
3494
3495 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3496
3497         * record.c (set_record_command): Fix typo in message.
3498
3499 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3500
3501         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3502
3503 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3504
3505         * infrun.c (process_event_stop_test): Call
3506         gdbarch_in_indirect_branch_thunk.
3507         * gdbarch.sh (in_indirect_branch_thunk): New.
3508         * gdbarch.c: Regenerated.
3509         * gdbarch.h: Regenerated.
3510         * x86-tdep.h: New.
3511         * x86-tdep.c: New.
3512         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3513         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3514         (ALLDEPFILES): Add x86-tdep.c.
3515         * arch-utils.h (default_in_indirect_branch_thunk): New.
3516         * arch-utils.c (default_in_indirect_branch_thunk): New.
3517         * i386-tdep: Include x86-tdep.h.
3518         (i386_in_indirect_branch_thunk): New.
3519         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3520         function.
3521         * amd64-tdep: Include x86-tdep.h.
3522         (amd64_in_indirect_branch_thunk): New.
3523         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3524
3525 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3526
3527         PR gdb/23053
3528         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3529         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3530         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3531         regression.
3532
3533 2018-04-12  Tom Tromey  <tom@tromey.com>
3534
3535         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3536         (rust_evaluate_subexp): Likewise.
3537
3538 2018-04-12  Pedro Alves  <palves@redhat.com>
3539
3540         * procfs.c (procfs_detach): Make forward declaration's prototype
3541         match definition's protototype.
3542         (proc_get_LDT_entry): Remove stale do_cleanups call.
3543
3544 2018-04-12  Pedro Alves  <palves@redhat.com>
3545
3546         * target.h (target_ops::to_has_exited): Delete.
3547         (target_has_exited): Delete.
3548         * target-delegates.c: Regenerate.
3549
3550 2018-04-11  Pedro Alves  <palves@redhat.com>
3551
3552         * target.c (fileio_fh_t::t): Add comment.
3553         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3554         (target_fileio_close): Handle a NULL target.
3555         (invalidate_fileio_fh): New.
3556         (target_close): Call it.
3557         * remote.c (remote_hostio_send_command): No longer check whether
3558         remote_desc is open.
3559
3560 2018-04-11  Pedro Alves  <palves@redhat.com>
3561
3562         * target.c (fileio_fh_t): Make it a named struct instead of a
3563         typedef.
3564         (fileio_fh_t::is_closed): New method.
3565         (DEF_VEC_O (fileio_fh_t)): Remove.
3566         (fileio_fhandles): Now a std::vector.
3567         (is_closed_fileio_fh): Delete.
3568         (acquire_fileio_fd): Adjust.  Rename parameters.
3569         (release_fileio_fd): Adjust.
3570         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3571         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3572         (target_fileio_close): Adjust.
3573
3574 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3575
3576         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3577         index.
3578
3579 2018-04-10  Pedro Alves  <palves@redhat.com>
3580
3581         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3582         (scoped_finish_thread_state): New class.
3583         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3584         cleanup.
3585         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3586         (fetch_inferior_event, normal_stop): Likewise.
3587         * thread.c (finish_thread_state_cleanup): Delete.
3588
3589 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3590             Pedro Alves  <palves@redhat.com>
3591
3592         * value.c: Include "selftest.h" and "common/array-view.h".
3593         (struct range) <operator ==>: New.
3594         (test_ranges_contain): New.
3595         (check_ranges_vector): New.
3596         (test_insert_into_bit_range_vector): New.
3597         (_initialize_values): Register selftests.
3598         * common/array-view.h (operator==, operator!=): New.
3599
3600 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3601
3602         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3603         an iterator.
3604         * inline-frame.c: Include <algorithm>.
3605         (struct inline_state): Add constructor.
3606         (inline_state_s): Remove.
3607         (DEF_VEC_O(inline_state_s)): Remove.
3608         (inline_states): Change type to std::vector.
3609         (find_inline_frame_state): Adjust to std::vector.
3610         (allocate_inline_frame_state): Remove.
3611         (clear_inline_frame_state): Adjust to std::vector.
3612         (skip_inline_frames): Adjust to std::vector.
3613
3614 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3615
3616         * tracepoint.h (struct trace_state_variable): Add constructor.
3617         <name>: Change type to std::string.
3618         * tracepoint.c (tsv_s): Remove.
3619         (DEF_VEC_O(tsv_s)): Remove.
3620         (tvariables): Change to std::vector.
3621         (create_trace_state_variable): Adjust to std::vector.
3622         (find_trace_state_variable): Likewise.
3623         (find_trace_state_variable_by_number): Likewise.
3624         (delete_trace_state_variable): Likewise.
3625         (trace_variable_command): Adjust to std::string.
3626         (delete_trace_variable_command): Likewise.
3627         (tvariables_info_1): Adjust to std::vector.
3628         (save_trace_state_variables): Likewise.
3629         (start_tracing): Likewise.
3630         (merge_uploaded_trace_state_variables): Adjust to std::vector
3631         and std::string.
3632         * target.h (struct target_ops)
3633         <to_download_trace_state_variable>: Pass reference to
3634         trace_state_variable.
3635         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3636         * target-delegates.c: Re-generate.
3637         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3638         (mi_tsv_deleted): Likewise.
3639         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3640         * remote.c (remote_download_trace_state_variable): Change
3641         pointer to reference and adjust.
3642         * make-target-delegates (parse_argtypes): Handle references.
3643         (write_function_header): Likewise.
3644         (munge_type): Likewise.
3645
3646 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3647
3648         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3649         string_view-selftests.c.
3650         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3651         testsuite.
3652         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3653         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3654         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3655         * unittests/basic_string_view/element_access/char/1.cc:
3656         Likewise.
3657         * unittests/basic_string_view/element_access/char/empty.cc:
3658         Likewise.
3659         * unittests/basic_string_view/element_access/char/front_back.cc:
3660         Likewise.
3661         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3662         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3663         Likewise.
3664         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3665         Likewise.
3666         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3667         Likewise.
3668         * unittests/basic_string_view/operations/compare/char/1.cc:
3669         Likewise.
3670         * unittests/basic_string_view/operations/compare/char/13650.cc:
3671         Likewise.
3672         * unittests/basic_string_view/operations/copy/char/1.cc:
3673         Likewise.
3674         * unittests/basic_string_view/operations/data/char/1.cc:
3675         Likewise.
3676         * unittests/basic_string_view/operations/find/char/1.cc:
3677         Likewise.
3678         * unittests/basic_string_view/operations/find/char/2.cc:
3679         Likewise.
3680         * unittests/basic_string_view/operations/find/char/3.cc:
3681         Likewise.
3682         * unittests/basic_string_view/operations/find/char/4.cc:
3683         Likewise.
3684         * unittests/basic_string_view/operations/rfind/char/1.cc:
3685         Likewise.
3686         * unittests/basic_string_view/operations/rfind/char/2.cc:
3687         Likewise.
3688         * unittests/basic_string_view/operations/rfind/char/3.cc:
3689         Likewise.
3690         * unittests/basic_string_view/operations/substr/char/1.cc:
3691         Likewise.
3692         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3693         * unittests/string_view-selftests.c: New file.
3694
3695 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3696
3697         * unittests/basic_string_view/capacity/1.cc: New file.
3698         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3699         * unittests/basic_string_view/cons/char/1.cc: New file.
3700         * unittests/basic_string_view/cons/char/2.cc: New file.
3701         * unittests/basic_string_view/cons/char/3.cc: New file.
3702         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3703         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3704         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3705         * unittests/basic_string_view/element_access/char/1.cc: New file.
3706         * unittests/basic_string_view/element_access/char/2.cc: New file.
3707         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3708         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3709         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3710         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3711         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3712         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3713         * unittests/basic_string_view/include.cc: New file.
3714         * unittests/basic_string_view/inserters/char/1.cc: New file.
3715         * unittests/basic_string_view/inserters/char/2.cc: New file.
3716         * unittests/basic_string_view/inserters/char/3.cc: New file.
3717         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3718         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3719         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3720         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3721         * unittests/basic_string_view/literals/types.cc: New file.
3722         * unittests/basic_string_view/literals/values.cc: New file.
3723         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3724         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3725         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3726         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3727         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3728         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3729         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3730         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3731         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3732         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3733         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3734         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3735         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3736         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3737         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3738         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3739         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3740         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3741         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3742         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3743         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3744         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3745         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3746         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3747         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3748         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3749         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3750         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3751         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3752         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3753         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3754         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3755         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3756         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3757         * unittests/basic_string_view/operators/char/2.cc: New file.
3758         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3759         * unittests/basic_string_view/range_access/char/1.cc: New file.
3760         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3761         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3762         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3763         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3764         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3765         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3766         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3767         * unittests/basic_string_view/typedefs.cc: New file.
3768         * unittests/basic_string_view/types/1.cc: New file.
3769
3770 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3771
3772         * common/gdb_string_view.h: Remove libstdc++ implementation
3773         details, adjust to gdb reality.
3774         * common/gdb_string_view.tcc: Likewise.
3775         * cli/cli-script.c (struct string_view): Remove.
3776         (user_args) <m_args>: Change element type to gdb::string_view.
3777         (user_args::insert_args): Adjust.
3778
3779 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3780
3781         * common/gdb_string_view.h: New file.
3782         * common/gdb_string_view.tcc: New file.
3783
3784 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3785
3786         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3787         * configure: Re-generate.
3788
3789 2018-04-09  Pedro Alves  <palves@redhat.com>
3790
3791         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3792         (set_target_gdbarch): Call
3793         gdb::observers::architecture_changed.notify instead of
3794         observer_notify_architecture_changed.
3795
3796 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3797
3798         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3799         (do_restore_current_traceframe_cleanup): Remove.
3800         (restore_current_traceframe_cleanup_dtor): Remove.
3801         (make_cleanup_restore_current_traceframe): Remove.
3802         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3803         New.
3804         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3805         * infrun.c (fetch_inferior_event): Use
3806         scoped_restore_current_traceframe.
3807
3808 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3809
3810         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3811         Remove.
3812         <n_allocated_type_units>: Remove.
3813         <all_type_units>: Change to std::vector.
3814         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3815         to std::vector change.
3816         (dwarf2_per_objfile::get_cutu): Likewise.
3817         (dwarf2_per_objfile::get_tu): Likewise.
3818         (create_signatured_type_table_from_index): Likewise.
3819         (create_signatured_type_table_from_debug_names): Likewise.
3820         (dw2_symtab_iter_next): Likewise.
3821         (dw2_print_stats): Likewise.
3822         (dw2_expand_all_symtabs): Likewise.
3823         (dw2_expand_marked_cus): Likewise.
3824         (dw2_debug_names_iterator::next): Likewise.
3825         (dwarf2_initialize_objfile): Likewise.
3826         (add_signatured_type_cu_to_table): Likewise.
3827         (create_all_type_units): Likewise.
3828         (add_type_unit): Likewise.
3829         (struct tu_abbrev_offset): Add constructor.
3830         (build_type_psymtabs_1): Adjust to std::vector change.
3831         (print_tu_stats): Likewise.
3832         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3833         (write_debug_names): Likewise.
3834
3835 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3836
3837         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3838         Make an std::vector.
3839         <n_comp_units>: Remove.
3840         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3841         to std::vector change.
3842         (dwarf2_per_objfile::get_cutu): Likewise.
3843         (dwarf2_per_objfile::get_cu): Likewise.
3844         (create_cus_from_index): Likewise.
3845         (create_addrmap_from_index): Likewise.
3846         (create_addrmap_from_aranges): Likewise.
3847         (dwarf2_read_index): Likewise.
3848         (dw2_find_last_source_symtab): Likewise.
3849         (dw2_map_symtabs_matching_filename): Likewise.
3850         (dw2_symtab_iter_next): Likewise.
3851         (dw2_print_stats): Likewise.
3852         (dw2_expand_all_symtabs): Likewise.
3853         (dw2_expand_symtabs_with_fullname): Likewise.
3854         (dw2_expand_marked_cus): Likewise.
3855         (dw2_map_symbol_filenames): Likewise.
3856         (create_cus_from_debug_names): Likewise.
3857         (dwarf2_read_debug_names): Likewise.
3858         (dw2_debug_names_iterator::next): Likewise.
3859         (dwarf2_initialize_objfile): Likewise.
3860         (set_partial_user): Likewise.
3861         (dwarf2_build_psymtabs_hard): Likewise.
3862         (read_comp_units_from_section): Remove arguments, adjust to
3863         std::vector change.
3864         (create_all_comp_units): Adjust to std::vector and
3865         read_comp_units_from_section changes.
3866         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3867         change.
3868         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3869         (psyms_seen_size): Likewise.
3870         (write_gdbindex): Likewise.
3871         (write_debug_names): Likewise.
3872
3873 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3874
3875         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3876         with dwarf2_per_objfile.
3877         (create_cus_from_index): Likewise.
3878         (create_signatured_type_table_from_index): Likewise.
3879         (dwarf2_read_index): Likewise.
3880         (dwarf2_initialize_objfile): Likewise.
3881         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3882         per_cu rather than get_dwarf2_per_objfile.
3883
3884 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3885
3886         * dwarf2read.h (struct signatured_type): Forward declare.
3887         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3888         New methods.
3889         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3890         (dw2_get_cutu): ...this.
3891         (dwarf2_per_objfile::get_cu): Rename from...
3892         (dw2_get_cu): ...this.
3893         (dwarf2_per_objfile::get_tu): New.
3894         (create_addrmap_from_index): Adjust.
3895         (create_addrmap_from_aranges): Adjust.
3896         (dw2_find_last_source_symtab): Adjust.
3897         (dw2_map_symtabs_matching_filename): Adjust.
3898         (dw2_symtab_iter_next): Adjust.
3899         (dw2_print_stats): Adjust.
3900         (dw2_expand_all_symtabs): Adjust.
3901         (dw2_expand_symtabs_with_fullname): Adjust.
3902         (dw2_expand_marked_cus): Adjust.
3903         (dw_expand_symtabs_matching_file_matcher): Adjust.
3904         (dw2_map_symbol_filenames): Adjust.
3905         (dw2_debug_names_iterator::next): Adjust.
3906         (dwarf2_initialize_objfile): Adjust.
3907         (set_partial_user): Adjust.
3908         (dwarf2_build_psymtabs_hard): Adjust.
3909
3910 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3911
3912         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3913         Remove unused variables.
3914         (dw2_map_symtabs_matching_filename): Likewise.
3915         (dwarf2_record_block_ranges): Likewise.
3916         (dwarf2_read_addr_index): Likewise.
3917         (follow_die_offset): Likewise.
3918
3919 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3920
3921         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3922         to symbol_file_add_main.
3923
3924 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3925
3926         PR mi/22299
3927         * mi/mi-console.c (do_fputc_async_safe): New.
3928         (mi_console_file::write_async_safe): New.
3929         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3930         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3931         New.
3932         * ui-file.c (ui_file::putstrn): Adjust call to
3933         fputstrn_unfiltered.
3934         * utils.c (printchar): Replace do_fputs and do_fprintf
3935         parameters by do_fputc.
3936         (fputstr_filtered): Adjust call to printchar.
3937         (fputstr_unfiltered): Likewise.
3938         (fputstrn_filtered): Likewise.
3939         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3940         printchar.
3941         * utils.h (do_fputc_ftype): New typedef.
3942         (fputstrn_unfiltered): Add do_fputc parameter.
3943
3944 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3945
3946         * regformats/i386/i386-avx.dat: Remove.
3947
3948 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3949
3950         PR gdb/22979
3951         * amd64-tdep.c (amd64_none_init_abi): New function.
3952         (amd64_x32_none_init_abi): New function.
3953         (_initialize_amd64_tdep): Register handlers for x86-64 and
3954         x64_32 with GDB_OSABI_NONE.
3955         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3956         GDB_OSABI_NONE osabi.
3957
3958 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3959
3960         PR gdb/22980
3961         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3962         GDB_OSABI_NONE.
3963         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3964         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3965
3966 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3967
3968         * common/byte-vector.h (char_vector): New type.
3969         * target.h (target_read_alloc): Return
3970         gdb::optional<byte_vector>.
3971         (target_read_stralloc): Return gdb::optional<char_vector>.
3972         (target_get_osdata): Return gdb::optional<char_vector>.
3973         * target.c (target_read_alloc_1): Templatize.  Replacement
3974         manual memory management with vector.
3975         (target_read_alloc): Change return type, adjust.
3976         (target_read_stralloc): Change return type, adjust.
3977         (target_get_osdata): Change return type, adjust.
3978         * auxv.c (struct auxv_info) <length>: Remove.
3979         <data>: Change type to gdb::optional<byte_vector>.
3980         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3981         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3982         (target_auxv_search): Adjust.
3983         (fprint_target_auxv): Adjust.
3984         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3985         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3986         (linux_make_corefile_notes): Adjust.
3987         * osdata.c (get_osdata): Adjust.
3988         * remote.c (remote_get_threads_with_qxfer): Adjust.
3989         (remote_memory_map): Adjust.
3990         (remote_traceframe_info): Adjust.
3991         (btrace_read_config): Adjust.
3992         (remote_read_btrace): Adjust.
3993         (remote_pid_to_exec_file): Adjust.
3994         * solib-aix.c (solib_aix_get_library_list): Adjust.
3995         * solib-dsbt.c (decode_loadmap): Don't free buf.
3996         (dsbt_get_initial_loadmaps): Adjust.
3997         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3998         * solib-target.c (solib_target_current_sos): Adjust.
3999         * tracepoint.c (sdata_make_value): Adjust.
4000         * xml-support.c (xinclude_start_include): Adjust.
4001         (xml_fetch_content_from_file): Adjust.
4002         * xml-support.h (xml_fetch_another): Change return type.
4003         (xml_fetch_content_from_file): Change return type.
4004         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4005         * xml-tdesc.c (file_read_description_xml): Adjust.
4006         (fetch_available_features_from_target): Change return type.
4007         (target_fetch_description_xml): Adjust.
4008         (target_read_description_xml): Adjust.
4009
4010 2018-04-06  Tom Tromey  <tom@tromey.com>
4011
4012         * value.c (~value): Update.
4013         (struct value) <contents>: Now unique_xmalloc_ptr.
4014         (value_contents_bits_eq, allocate_value_contents)
4015         (value_contents_raw, value_contents_all_raw)
4016         (value_contents_for_printing, value_contents_for_printing_const)
4017         (set_value_enclosing_type): Update.
4018
4019 2018-04-06  Tom Tromey  <tom@tromey.com>
4020
4021         * value.c (range_s): Remove typedef, VEC.
4022         (struct range): Add operator<.
4023         (range_lessthan): Remove.
4024         (ranges_contain): Change type.
4025         (~value): Update.
4026         (struct value) <unavailable, optimized_out>: Now std::vector.
4027         (value_entirely_available)
4028         (value_entirely_covered_by_range_vector)
4029         (value_entirely_unavailable, value_entirely_optimized_out):
4030         Update.
4031         (insert_into_bit_range_vector): Change argument type.
4032         (find_first_range_overlap): Likewise.
4033         (struct ranges_and_idx, value_contents_bits_eq)
4034         (require_not_optimized_out, require_available): Update.
4035         (ranges_copy_adjusted): Change argument types.
4036         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4037
4038 2018-04-06  Tom Tromey  <tom@tromey.com>
4039
4040         * value.c (~value): Update.
4041         (struct value) <parent>: Now a value_ref_ptr.
4042         (value_parent, set_value_parent, value_address, value_copy):
4043         Update.
4044
4045 2018-04-06  Tom Tromey  <tom@tromey.com>
4046
4047         * value.c (struct value): Add constructor, destructor, and member
4048         initializers.
4049         (allocate_value_lazy, value_decref): Update.
4050
4051 2018-04-06  Tom Tromey  <tom@tromey.com>
4052
4053         * value.c (struct value) <released, next>: Remove.
4054         (all_values): Now a std::vector.
4055         (allocate_value_lazy): Update.
4056         (value_next): Remove.
4057         (value_mark, value_free_to_mark, release_value)
4058         (value_release_to_mark): Update.
4059
4060 2018-04-06  Tom Tromey  <tom@tromey.com>
4061
4062         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4063         (free_value_chain): Remove.
4064         * value.c (free_value_chain): Remove.
4065         (value_release_to_mark): Return a std::vector.
4066         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4067         std::vector.
4068         (check_condition): Update.
4069         * eval.c (fetch_subexp_value): Change "val_chain" to a
4070         std::vector.
4071         * breakpoint.c (update_watchpoint): Update.
4072         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4073
4074 2018-04-06  Tom Tromey  <tom@tromey.com>
4075
4076         * value.h (free_all_values): Remove.
4077         * value.c (free_all_values): Remove.
4078
4079 2018-04-06  Tom Tromey  <tom@tromey.com>
4080
4081         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4082         (value_history_chain, value_history_count): Remove.
4083         (value_history): New global.
4084         (record_latest_value, access_value_history, show_values)
4085         (preserve_values): Update.
4086
4087 2018-04-06  Tom Tromey  <tom@tromey.com>
4088
4089         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4090         * varobj.c (varobj_set_display_format, varobj_set_value)
4091         (install_default_visualizer, construct_visualizer)
4092         (install_new_value, ~varobj, varobj_get_value_type)
4093         (my_value_of_variable, varobj_editable_p): Update.
4094         * c-varobj.c (c_describe_child, c_value_of_variable)
4095         (cplus_number_of_children, cplus_describe_child): Update.
4096         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4097         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4098         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4099
4100 2018-04-06  Tom Tromey  <tom@tromey.com>
4101
4102         * printcmd.c (last_examine_address): Change type to
4103         value_ref_ptr.
4104         (do_examine, x_command): Update.
4105
4106 2018-04-06  Tom Tromey  <tom@tromey.com>
4107
4108         * value.c (release_value): Update.
4109         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4110         (struct bpstats) <val>: Now a value_ref_ptr.
4111         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4112         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4113         (~watchpoint, print_it_watchpoint, watch_command_1)
4114         (invalidate_bp_value_on_memory_change): Update.
4115
4116 2018-04-06  Tom Tromey  <tom@tromey.com>
4117
4118         * varobj.c (varobj_clear_saved_item)
4119         (update_dynamic_varobj_children, install_new_value, ~varobj):
4120         Update.
4121         * value.h (value_incref): Move declaration earlier.
4122         (value_decref): Rename from value_free.
4123         (struct value_ref_policy): New.
4124         (value_ref_ptr): New typedef.
4125         (struct value_deleter): Remove.
4126         (gdb_value_up): Remove typedef.
4127         (release_value): Change return type.
4128         (release_value_or_incref): Remove.
4129         * value.c (set_value_parent): Update.
4130         (value_incref): Change return type.
4131         (value_decref): Rename from value_free.
4132         (value_free_to_mark, free_all_values, free_value_chain): Update.
4133         (release_value): Return value_ref_ptr.
4134         (release_value_or_incref): Remove.
4135         (record_latest_value, set_internalvar, clear_internalvar):
4136         Update.
4137         * stack.c (info_frame_command): Don't call value_free.
4138         * python/py-value.c (valpy_dealloc, valpy_new)
4139         (value_to_value_object): Update.
4140         * printcmd.c (do_examine): Update.
4141         * opencl-lang.c (lval_func_free_closure): Update.
4142         * mi/mi-main.c (register_changed_p): Don't call value_free.
4143         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4144         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4145         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4146         value_free.
4147         * guile/scm-value.c (vlscm_free_value_smob)
4148         (vlscm_scm_from_value): Update.
4149         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4150         (frame_unwind_register_unsigned, get_frame_register_bytes)
4151         (put_frame_register_bytes): Don't call value_free.
4152         * findvar.c (address_from_register): Don't call value_free.
4153         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4154         * dwarf2loc.c (entry_data_value_free_closure)
4155         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4156         (dwarf2_evaluate_loc_desc_full): Update.
4157         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4158         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4159         (~watchpoint, watch_command_1)
4160         (invalidate_bp_value_on_memory_change): Update.
4161         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4162
4163 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4164
4165         PR gdb/23022
4166         * warning.m4: Add -Wno-error=deprecated-register.
4167         * configure: Re-generate.
4168
4169 2018-04-05  Tom Tromey  <tom@tromey.com>
4170
4171         * linespec.h: Remove include of "vec.h".
4172
4173 2018-04-05  Tom Tromey  <tom@tromey.com>
4174
4175         * linespec.c (typep): Remove typedef.
4176         (find_methods, find_superclass_methods): Take a std::vector.
4177         (find_method): Use std::vector.
4178
4179 2018-04-05  Tom Tromey  <tom@tromey.com>
4180
4181         * utils.c (compare_strings): Remove.
4182         * utils.h (compare_strings): Remove.
4183         * objc-lang.h (find_imps): Update.
4184         * objc-lang.c (find_methods): Take a std::vector.
4185         (uniquify_strings, find_imps): Likewise.
4186         * linespec.c (find_methods): Take a std::vector.
4187         (decode_objc): Use std::vector.
4188         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4189         a std::vector.
4190         (find_method, find_function_symbols): Use std::vector.
4191
4192 2018-04-05  Tom Tromey  <tom@tromey.com>
4193
4194         * completer.c (completion_tracker::completion_tracker): Remove
4195         cast.
4196         (completion_tracker::discard_completions): Likewise.
4197         * breakpoint.c (ambiguous_names_p): Remove cast.
4198         * ada-lang.c (_initialize_ada_language): Remove cast.
4199         * utils.h (streq): Update.
4200         (streq_hash): Add new declaration.
4201         * utils.c (streq): Return bool.
4202         (streq_hash): New function.
4203
4204 2018-04-05  Tom Tromey  <tom@tromey.com>
4205
4206         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4207         Remove a string copy.
4208
4209 2018-04-05  Tom Tromey  <tom@tromey.com>
4210
4211         * linespec.c (filter_results): Use std::vector.
4212         (decode_line_2, decode_line_full): Update.
4213
4214 2018-04-05  Tom Tromey  <tom@tromey.com>
4215
4216         * linespec.c (canonical_to_fullform): Return std::string.
4217         (filter_results): Update.
4218         (struct decode_line_2_item): Add constructor.
4219         <fullform, displayform>: Now std::string.
4220         (decode_line_2_compare_items): Now a std::sort comparator.
4221         (decode_line_2): Update.
4222
4223 2018-04-05  Tom Tromey  <tom@tromey.com>
4224
4225         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4226         (unexpected_linespec_error): Update.
4227         (linespec_parse_basic, parse_linespec): Update.
4228
4229 2018-04-05  Tom Tromey  <tom@tromey.com>
4230
4231         * linespec.c (linespec_parse_basic): Reindent.
4232
4233 2018-04-05  Tom Tromey  <tom@tromey.com>
4234
4235         * minsyms.h (iterate_over_minimal_symbols): Update.
4236         * minsyms.c (iterate_over_minimal_symbols): Take a
4237         gdb::function_view.
4238         * linespec.c (struct collect_minsyms): Remove.
4239         (compare_msyms): Now a std::sort comparator.
4240         (add_minsym): Add parameters.
4241         (search_minsyms_for_name): Update.  Use std::vector.
4242
4243 2018-04-03  Tom Tromey  <tom@tromey.com>
4244
4245         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4246         gdb::byte_vector.
4247
4248 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4249
4250         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4251
4252 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4253
4254         PR gdb/16959
4255         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
4256         printing static type.
4257
4258 2018-04-01  Tom Tromey  <tom@tromey.com>
4259
4260         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4261         (rs6000_xfer_shared_libraries): Update.
4262
4263 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4264
4265         * common/gdb_vecs.h (char_ptr): Remove.
4266         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4267
4268 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4269
4270         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4271         with std::vector.
4272         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4273
4274 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4275
4276         * tracepoint.h (struct uploaded_tp): Initialize fields.
4277         <actions, step_actions, cmd_strings>: Change type to
4278         std::vector<char *>.
4279         * tracepoint.c (get_uploaded_tp): Allocate with new.
4280         (free_uploaded_tps): Free with delete.
4281         (parse_tracepoint_definition): Adjust to std::vector change.
4282         * breakpoint.c (read_uploaded_action): Likewise.
4283         (create_tracepoint_from_upload): Likewise.
4284         * ctf.c (ctf_write_uploaded_tp): Likewise.
4285         (SET_ARRAY_FIELD): Likewise.
4286         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4287
4288 2018-03-30  Tom Tromey  <tom@tromey.com>
4289
4290         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4291         std::unique_ptr.
4292         (svr4_keep_data_in_core): Update.
4293         (svr4_read_so_list): Update.
4294
4295 2018-03-30  Tom Tromey  <tom@tromey.com>
4296
4297         * windows-nat.c (handle_output_debug_string, handle_exception):
4298         Update.
4299         * target.h (target_read_string): Update.
4300         * target.c (target_read_string): Change "string" to
4301         unique_xmalloc_ptr.
4302         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4303         Update.
4304         * solib-frv.c (frv_current_sos): Update.
4305         * solib-dsbt.c (dsbt_current_sos): Update.
4306         * solib-darwin.c (darwin_current_sos): Update.
4307         * linux-thread-db.c (inferior_has_bug): Update.
4308         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4309         Update.  Remove alloca.
4310         * ada-lang.c (ada_main_name): Update.
4311
4312 2018-03-30  Tom Tromey  <tom@tromey.com>
4313
4314         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4315         (struct dwo_file_deleter): New.
4316         (dwo_file_up): New typedef.
4317         (open_and_init_dwo_file): Use dwo_file_up.
4318         (free_dwo_file_cleanup): Remove.
4319
4320 2018-03-30  Tom Tromey  <tom@tromey.com>
4321
4322         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4323         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4324
4325 2018-03-30  Tom Tromey  <tom@tromey.com>
4326
4327         * dwarf2read.c (class free_cached_comp_units): New class.
4328         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4329         (free_cached_comp_units): Remove function.
4330
4331 2018-03-30  Tom Tromey  <tom@tromey.com>
4332
4333         * utils.h (make_cleanup_unpush_target): Remove.
4334         * inf-ptrace.c (struct target_unpusher): New.
4335         (target_unpush_up) New typedef.
4336         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4337         target_unpush_up.
4338         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4339
4340 2018-03-27  Tom Tromey  <tom@tromey.com>
4341
4342         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4343
4344 2018-03-27  Pedro Alves  <palves@redhat.com>
4345             Tom Tromey  <tom@tromey.com>
4346
4347         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4348         destructor.  Now a class.
4349         (gdb_readline_wrapper_cleanup): Remove function.
4350         (gdb_readline_wrapper): Remove cleanups.
4351
4352 2018-03-27  Tom Tromey  <tom@tromey.com>
4353
4354         * typeprint.h (struct type_print_options) <local_typedefs,
4355         global_typedefs>: Remove "struct" keyword.
4356         (class typedef_hash_table): New class.
4357         (recursively_update_typedef_hash, add_template_parameters)
4358         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4359         (find_typedef_in_hash): Don't declare.
4360         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4361         (typedef_hash_table::recursively_update): Rename from
4362         recursively_update_typedef_hash.  Now a member.
4363         (typedef_hash_table::add_template_parameters): Rename from
4364         add_template_parameters.  Now a member.
4365         (typedef_hash_table::typedef_hash_table): Now a constructor;
4366         rename from create_typedef_hash.
4367         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4368         rename from free_typedef_hash.
4369         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4370         (do_free_global_table): Remove.
4371         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4372         from copy_type_recursive.
4373         (create_global_typedef_table): Remove.
4374         (typedef_hash_table::find_global_typedef): Now a member of
4375         typedef_hash_table.
4376         (typedef_hash_table::find_typedef): Rename from
4377         find_typedef_in_hash; now a member.
4378         (whatis_exp): Update.
4379         * extension.h (struct ext_lang_type_printers): Add constructor and
4380         destructor.
4381         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4382         declare.
4383         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4384         Now a constructor; rename from start_ext_lang_type_printers.
4385         (ext_lang_type_printers): Now a destructor; rename from
4386         free_ext_lang_type_printers.
4387         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4388         Update.
4389         (c_type_print_base_struct_union): Update.  Remove cleanups.
4390
4391 2018-03-27  Tom Tromey  <tom@tromey.com>
4392
4393         * dwarf-index-write.c: Include <cmath>.
4394
4395 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4396
4397         * NEWS: Add entry describing new "set|show varsize-limit" command.
4398         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4399         command.
4400         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4401         "set variable".
4402
4403 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4404
4405         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4406         dwarf-index-write.c
4407         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4408         * dwarf-index-common.c: New file.
4409         * dwarf-index-common.h: New file.
4410         * dwarf-index-write.c: New file.
4411         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4412         (struct dwarf2_section_info): Move from here.
4413         (dwarf2_section_info_def): Likewise.
4414         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4415         (offset_type): Likewise.
4416         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4417         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4418         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4419         (byte_swap): Likewise.
4420         (MAYBE_SWAP): Likewise.
4421         (dwarf2_per_cu_ptr): Likewise.
4422         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4423         (struct tu_stats): Likewise.
4424         (struct dwarf2_per_objfile): Likewise.
4425         (struct dwarf2_per_cu_data): Likewise.
4426         (struct signatured_type): Likewise.
4427         (sig_type_ptr): Likewise.
4428         (DEF_VEC_P (sig_type_ptr)): Likewise.
4429         (INDEX4_SUFFIX): Likewise.
4430         (INDEX5_SUFFIX): Likewise.
4431         (DEBUG_STR_SUFFIX): Likewise.
4432         (dwarf2_read_section): Make non-static.
4433         (mapped_index_string_hash): Move from here.
4434         (dwarf5_djb_hash): Likewise.
4435         (file_write): Likewise.
4436         (class data_buf): Likewise.
4437         (struct symtab_index_entry): Likewise.
4438         (struct mapped_symtab): Likewise.
4439         (find_slot): Likewise.
4440         (hash_expand): Likewise.
4441         (add_index_entry): Likewise.
4442         (uniquify_cu_indices): Likewise.
4443         (class c_str_view): Likewise.
4444         (class c_str_view_hasher): Likewise.
4445         (class vector_hasher): Likewise.
4446         (write_hash_table): Likewise.
4447         (psym_index_map): Likewise.
4448         (struct addrmap_index_data): Likewise.
4449         (add_address_entry): Likewise.
4450         (add_address_entry_worker): Likewise.
4451         (write_address_map): Likewise.
4452         (symbol_kind): Likewise.
4453         (write_psymbols): Likewise.
4454         (struct signatured_type_index_data): Likewise.
4455         (write_one_signatured_type): Likewise.
4456         (recursively_count_psymbols): Likewise.
4457         (recursively_write_psymbols): Likewise.
4458         (class debug_names): Likewise.
4459         (check_dwarf64_offsets): Likewise.
4460         (psyms_seen_size): Likewise.
4461         (write_gdbindex): Likewise.
4462         (write_debug_names): Likewise.
4463         (assert_file_size): Likewise.
4464         (write_psymtabs_to_index): Likewise.
4465         (save_gdb_index_command): Likewise.
4466         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4467         command.
4468         * dwarf2read.h: New file.
4469
4470 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4471
4472         PR gdb/22670
4473         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4474         symbol name if the CU's language stores symbol names in linkage
4475         format.
4476         * language.h (struct language_defn)
4477         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4478         all instances of this struct.
4479
4480 2018-03-26  Tom Tromey  <tom@tromey.com>
4481
4482         * stack.c (backtrace_command_1): Remove verbose code.
4483
4484 2018-03-26  Tom Tromey  <tom@tromey.com>
4485
4486         * python/py-framefilter.c (py_print_type): Don't catch
4487         exceptions.  Return void.
4488         (py_print_value): Likewise.
4489         (py_print_single_arg): Likewise.
4490         (enumerate_args): Don't catch exceptions.
4491         (py_print_args): Likewise.
4492         (py_print_frame): Likewise.
4493         (gdbpy_apply_frame_filter): Catch exceptions here.
4494
4495 2018-03-26  Tom Tromey  <tom@tromey.com>
4496
4497         * stack.c (_initialize_stack): Remove trailing newlines from help
4498         text.  Add "Usage" line to "backtrace" help.
4499
4500 2018-03-26  Tom Tromey  <tom@tromey.com>
4501
4502         PR python/16486:
4503         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4504
4505 2018-03-26  Tom Tromey  <tom@tromey.com>
4506
4507         * python/py-framefilter.c (py_print_single_arg): Return
4508         EXT_LANG_BT_ERROR from catch.
4509
4510 2018-03-26  Tom Tromey  <tom@tromey.com>
4511
4512         PR backtrace/15584:
4513         * stack.c (backtrace_command_1): Move some code into no-filters
4514         "if".
4515
4516 2018-03-26  Tom Tromey  <tom@tromey.com>
4517
4518         * python/py-framefilter.c (throw_quit_or_print_exception): New
4519         function.
4520         (gdbpy_apply_frame_filter): Use it.
4521
4522 2018-03-26  Tom Tromey  <tom@tromey.com>
4523
4524         PR cli/17716:
4525         * python/py-framefilter.c (py_print_type, py_print_value)
4526         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4527         RETURN_MASK_ERROR.
4528
4529 2018-03-26  Tom Tromey  <tom@tromey.com>
4530
4531         * python/py-framefilter.c (enumerate_args): Use
4532         gdb::unique_xmalloc_ptr.
4533
4534 2018-03-26  Tom Tromey  <tom@tromey.com>
4535
4536         * python/py-framefilter.c (py_print_frame): Return
4537         EXT_LANG_BT_OK.
4538         (gdbpy_apply_frame_filter): Update comment.
4539         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4540         Remove.
4541         <EXT_LANG_BT_NO_FILTERS>: Change value.
4542
4543 2018-03-26  Tom Tromey  <tom@tromey.com>
4544
4545         PR backtrace/15582:
4546         * stack.c (backtrace_command): Parse "hide" argument.
4547         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4548         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4549         constant.
4550
4551 2018-03-26  Tom Tromey  <tom@tromey.com>
4552
4553         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4554         add "flags".
4555         (backtrace_command): Remove "fulltrace", add "flags".
4556
4557 2018-03-26  Tom Tromey  <tom@tromey.com>
4558
4559         * stack.c (backtrace_command): Rewrite command line parsing.
4560
4561 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4562
4563         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4564
4565 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4566
4567         * filename-seen-cache.h: Add include guard.
4568
4569 2018-03-26  Keith Seitz  <keiths@redhat.com>
4570
4571         * symfile.c (place_section): Remove "struct" from section_addr_info
4572         in comment.
4573         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4574         "struct" keyword from section_addr_info.
4575
4576 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4577
4578         * regformats/regdef.h (reg): Add constructors.
4579
4580 2018-03-25  Pedro Alves  <palves@redhat.com>
4581
4582         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4583         if then/else bodies in var_func_name extraction.
4584
4585 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4586
4587         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4588         lookup_minimal_symbol() to find symbol entry.
4589         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4590
4591 2018-03-23  Keith Seitz  <keiths@redhat.com>
4592
4593         PR c++/22968
4594         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4595         nested type definitions for C++, too.
4596
4597 2018-03-23  Tom Tromey  <tom@tromey.com>
4598
4599         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4600         a typedef.
4601         (macho_register_oso): Remove.
4602         (macho_symtab_read): Take a std::vector.
4603         (oso_el_compare_name): Now a std::sort comparator.
4604         (macho_symfile_read_all_oso): Take a std::vector.
4605         (macho_symfile_read): Use std::vector.  Remove cleanups.
4606
4607 2018-03-22  Tom Tromey  <tom@tromey.com>
4608
4609         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4610         (record_full_goto_bookmark): Use std::string.
4611
4612 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4613
4614         PR tdep/18295
4615         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4616         a single mask.
4617
4618 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4619
4620         * rs6000-tdep.c (store_insn_p): New function.
4621         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4622         and cr_reg to their unshifted values. Use store_insn_p to
4623         match LR saves using either R1 or fdata->alloca_reg. Use
4624         store_insn_p to match CR saves. Set alloca_reg_offset
4625         when alloca_reg and framep are set. Remove lr_reg shift
4626         when assigning to fdata->lr_register.
4627
4628 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4629
4630         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4631         command line args instead of emitting a warning.
4632
4633 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4634
4635         * tracepoint.h (struct static_tracepoint_marker): Initialize
4636         fields, define default constructor, move constructor and move
4637         assignment, disable the rest.
4638         <str_id, extra>: Make std::string.
4639         (release_static_tracepoint_marker): Remove.
4640         (free_current_marker): Remove.
4641         * tracepoint.c (free_current_marker): Remove.
4642         (parse_static_tracepoint_marker_definition): Adjust to
4643         std::string, use new hex2str overload.
4644         (release_static_tracepoint_marker): Remove.
4645         (print_one_static_tracepoint_marker): Get marker by reference
4646         and adjust to std::string.
4647         (info_static_tracepoint_markers_command): Adjust to std::vector
4648         changes
4649         * target.h (static_tracepoint_marker_p): Remove typedef.
4650         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4651         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4652         bool.
4653         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4654         * target-debug.h
4655         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4656         (target_debug_print_std_vector_static_tracepoint_marker): New.
4657         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4658         to...
4659         (target_debug_print_static_tracepoint_marker_p): ... this.
4660         * target-delegates.c: Re-generate.
4661         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4662         Make std::string.
4663         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4664         (decode_static_tracepoint_spec): Adjust to std::vector.
4665         (tracepoint_print_one_detail): Adjust to std::string.
4666         (strace_marker_decode_location): Adjust to std::string.
4667         (update_static_tracepoint): Adjust to std::string, remove call
4668         to release_static_tracepoint_marker.
4669         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4670         Adjust to std::vector.
4671         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4672         (remote_static_tracepoint_markers_by_strid): Adjust to
4673         std::vector.
4674         * common/rsp-low.h (hex2str): New overload with explicit count
4675         of bytes.
4676         * common/rsp-low.c (hex2str): New overload with explicit count
4677         of bytes.
4678         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4679         (_initialize_rsp_low_selftests): Add test_hex2str test.
4680         * unittests/tracepoint-selftests.c
4681         (test_parse_static_tracepoint_marker_definition): Adjust to
4682         std::string.
4683
4684 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4685
4686         * tracepoint.c (parse_static_tracepoint_marker_definition):
4687         Consider case where the definition is followed by more
4688         definitions.
4689         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4690         tracepoint-selftests.c.
4691         * unittests/tracepoint-selftests.c: New.
4692
4693 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4694
4695         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4696         Carvalho.
4697
4698 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4699
4700         * symtab.c (find_pc_sect_line): fixed indentation.
4701
4702 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4703
4704         * symtab.c (find_pc_sect_line): now uses binary search.
4705
4706 2018-03-19  Tom Tromey  <tom@tromey.com>
4707
4708         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4709         "IDENT" production.
4710
4711 2018-03-19  Pedro Alves  <palves@redhat.com>
4712             Tom Tromey  <tom@tromey.com>
4713
4714         * unittests/observable-selftests.c: New file.
4715         * common/observable.h: New file.
4716         * observable.h: New file.
4717         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4718         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4719         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4720         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4721         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4722         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4723         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4724         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4725         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4726         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4727         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4728         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4729         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4730         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4731         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4732         tui/tui-interp.c, valops.c: Update all users.
4733         * tui/tui-hooks.c (tui_bp_created_observer)
4734         (tui_bp_deleted_observer, tui_bp_modified_observer)
4735         (tui_inferior_exit_observer, tui_before_prompt_observer)
4736         (tui_normal_stop_observer, tui_register_changed_observer):
4737         Remove.
4738         (tui_observers_token): New global.
4739         (attach_or_detach, tui_attach_detach_observers): New functions.
4740         (tui_install_hooks, tui_remove_hooks): Use
4741         tui_attach_detach_observers.
4742         * record-btrace.c (record_btrace_thread_observer): Remove.
4743         (record_btrace_thread_observer_token): New global.
4744         * observer.sh: Remove.
4745         * observer.c: Rename to observable.c.
4746         * observable.c (namespace gdb_observers): Define new objects.
4747         (observer_debug): Move into gdb_observers namespace.
4748         (struct observer, struct observer_list, xalloc_observer_list_node)
4749         (xfree_observer_list_node, generic_observer_attach)
4750         (generic_observer_detach, generic_observer_notify): Remove.
4751         (_initialize_observer): Update.
4752         Don't include observer.inc.
4753         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4754         (clean mostlyclean): Likewise.
4755         (observer.h, observer.inc): Remove targets.
4756         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4757         (COMMON_SFILES): Use observable.c, not observer.c.
4758         * .gitignore: Remove observer.h.
4759
4760 2018-03-18  Tom Tromey  <tom@tromey.com>
4761
4762         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4763         gdb::def_vector.
4764         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4765
4766 2018-03-17  Tom Tromey  <tom@tromey.com>
4767
4768         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4769
4770 2018-03-17  Tom Tromey  <tom@tromey.com>
4771
4772         * target.c (class scoped_target_fd): New.
4773         (target_fileio_close_cleanup): Remove.
4774         (target_fileio_read_alloc_1): Use scoped_target_fd.
4775
4776 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4777
4778         * silent-rules.mk: New.
4779         * Makefile.in: Include silent-rules.mk
4780         (srcdir, VPATH, top_srcdir): Move up.
4781         (COMPILE): Add ECHO_CXX.
4782         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4783         (init.c): Add ECHO_INIT_C.
4784         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4785         (version.c): Add ECHO_GEN.
4786         (printcmd.o): Add ECHO_CXX.
4787         (target-float.o): Add ECHO_CXX.
4788         (ada-exp.o): Add ECHO_CXX.
4789         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4790         (insight$(EXEEXT)): Add ECHO_CXXLD.
4791         * gnulib/configure.ac: Add AM_SILENT_RULES.
4792         * gnulib/aclocal.m4: Re-generate.
4793         * gnulib/configure: Re-generate.
4794         * gnulib/import/Makefile.in: Re-generate.
4795
4796 2018-03-16  Tom Tromey  <tom@tromey.com>
4797
4798         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4799         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4800         * utils.c (do_free_section_addr_info)
4801         (make_cleanup_free_section_addr_info): Remove.
4802         * symfile.h (struct other_sections): Add constructor.
4803         (struct section_addr_info): Remove.
4804         (section_addr_info): New typedef.
4805         (struct sym_fns) <sym_offsets>: Change type of parameter.
4806         (build_section_addr_info_from_objfile)
4807         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4808         (default_symfile_offsets, symbol_file_add)
4809         (symbol_file_add_from_bfd)
4810         (build_section_addr_info_from_section_table): Update.
4811         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4812         * symfile.c (alloc_section_addr_info): Remove.
4813         (build_section_addr_info_from_section_table): Change return type.
4814         Update.
4815         (build_section_addr_info_from_bfd)
4816         (build_section_addr_info_from_objfile): Likewise.
4817         (free_section_addr_info): Remove.
4818         (relative_addr_info_to_section_offsets): Change type of "addrs".
4819         (addrs_section_compar): Now a std::sort comparator.
4820         (addrs_section_sort): Change return type.
4821         (addr_info_make_relative): Change type of "addrs".  Update.
4822         (default_symfile_offsets, syms_from_objfile_1)
4823         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4824         (symbol_file_add_separate): Update.
4825         (symbol_file_add): Change type of "addrs".  Update.
4826         (add_symbol_file_command): Update.  Remove cleanups.
4827         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4828         cleanups.
4829         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4830         * solib.c (solib_read_symbols): Update.
4831         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4832         * machoread.c (macho_symfile_offsets): Update.
4833         * jit.c (jit_bfd_try_read_symtab): Update.
4834
4835 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4836
4837         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4838         unittests/utils-selftests.c.
4839         * unittests/utils-selftests.c: New file.
4840
4841 2018-03-14  Tom Tromey  <tom@tromey.com>
4842
4843         PR cli/14977:
4844         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4845         for NULL.
4846
4847 2018-03-14  Tom Tromey  <tom@tromey.com>
4848
4849         PR cli/19918:
4850         * printcmd.c (printf_pointer): Allow "-" in format.
4851
4852 2018-03-14  Tom Tromey  <tom@tromey.com>
4853
4854         * printcmd.c (_initialize_printcmd): Add usage to printf.
4855
4856 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4857
4858         * MAINTAINERS: Update my email address.
4859
4860 2018-03-13  Tom Tromey  <tom@tromey.com>
4861
4862         * machoread.c (macho_check_dsym): Change filenamep to a
4863         std::string*.
4864         (macho_symfile_read): Update.
4865         * symfile.c (load_command): Use std::string.
4866
4867 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4870         to error message string.
4871         (riscv_register_name): Use xsnprintf instead of sprintf.
4872         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4873         internal_error.
4874         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4875         error.
4876         (riscv_push_dummy_call): Likewise.
4877
4878 2018-03-12  Tom Tromey  <tom@tromey.com>
4879
4880         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4881         Use gdb::byte_vector.
4882         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4883
4884 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4885
4886         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4887         parameter type to readable_regcache.
4888         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4889         the declaration.
4890
4891 2018-03-11  Tom Tromey  <tom@tromey.com>
4892
4893         * dwarf2read.c (struct nextfield): Add initializers.
4894         (struct nextfnfield): Remove.
4895         (struct fnfieldlist): Add initializers.  Remove "length" and
4896         "head", use std::vector.
4897         (struct decl_field_list): Remove.
4898         (struct field_info): Add initializers.
4899         <fields, baseclasses>: Now std::vector.
4900         <nbaseclasses, nfnfields, typedef_field_list_count,
4901         nested_types_list_count>: Remove.
4902         (dwarf2_add_field, dwarf2_add_type_defn)
4903         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4904         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4905         (process_structure_scope): Update.
4906
4907 2018-03-11  Tom Tromey  <tom@tromey.com>
4908
4909         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4910         for use by std::sort.
4911         (build_type_psymtabs_1): Use std::vector.
4912
4913 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4914
4915         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4916         and LIBMPFR in the printed configuration.
4917
4918 2018-03-08  Tom Tromey  <tom@tromey.com>
4919
4920         * source.c (get_filename_and_charpos): Use scoped_fd.
4921         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4922         (procfs_pidlist): Likewise.
4923         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4924         (iterate_over_mappings): Likewise.
4925
4926 2018-03-08  Tom Tromey  <tom@tromey.com>
4927
4928         * infcall.c (struct call_return_meta_info)
4929         <stack_temporaries_enabled>: Remove.
4930         (get_call_return_value, call_function_by_hand_dummy): Update.
4931         * thread.c (disable_thread_stack_temporaries): Remove.
4932         (enable_thread_stack_temporaries): Remove.
4933         (thread_stack_temporaries_enabled_p): Return bool.
4934         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4935         (get_last_thread_stack_temporary): Update.
4936         * eval.c (evaluate_subexp): Update.
4937         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4938         class, not a function.
4939         (value_ptr, value_vec): Remove typedefs.
4940         (class thread_info) <stack_temporaries_enabled>: Now bool.
4941         <stack_temporaries>: Now a std::vector.
4942         (thread_stack_temporaries_enabled_p)
4943         (value_in_thread_stack_temporaries): Return bool.
4944
4945 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4946
4947         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4948         (getpkt_or_notif_sane_1): Likewise.
4949
4950 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4951
4952         * build-id.c (build_id_to_debug_bfd): Use std::string.
4953
4954 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4955
4956         * build-id.c (find_separate_debug_file_by_buildid): Return
4957         std::string.
4958         * build-id.h (find_separate_debug_file_by_buildid): Return
4959         std::string.
4960         * coffread.c (coff_symfile_read): Adjust to std::string.
4961         * elfread.c (elf_symfile_read): Adjust to std::string.
4962         * symfile.c (separate_debug_file_exists): Change parameter to
4963         std::string.
4964         (find_separate_debug_file): Return std::string.
4965         (find_separate_debug_file_by_debuglink): Return std::string.
4966         * symfile.h (find_separate_debug_file_by_debuglink): Return
4967         std::string.
4968
4969 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4970
4971         * common/xml-utils.c (xml_escape_text): Move code to...
4972         (xml_escape_text_append): ... this new function.
4973         * common/xml-utils.h (xml_escape_text_append): New declaration.
4974         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4975         New function.
4976         (_initialize_xml_utils): register test_xml_escape_text_append as
4977         a selftest.
4978
4979 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4980
4981         * defs.h: Remove MAX_REGISTER_SIZE.
4982         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4983         asserts.
4984         * python/py-unwind.c (pyuw_sniffer): Likewise.
4985
4986 2018-03-07  Tom Tromey  <tom@tromey.com>
4987
4988         * linux-tdep.c (linux_info_proc): Update.
4989         * target.h (struct target_ops) <to_fileio_readlink>: Return
4990         optional<string>.
4991         (target_fileio_readlink): Return optional<string>.
4992         * remote.c (remote_hostio_readlink): Return optional<string>.
4993         * inf-child.c (inf_child_fileio_readlink): Return
4994         optional<string>.
4995         * target.c (target_fileio_readlink): Return optional<string>.
4996
4997 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4998
4999         * regcache.c (cooked_read_test): Add riscv to the list of
5000         architectures that have a save_reggroup.
5001
5002 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5003
5004         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5005         value is not a dynamic class object.
5006
5007 2018-03-06  Tom Tromey  <tom@tromey.com>
5008
5009         * rust-exp.y: Formatting fixes.
5010
5011 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * riscv-tdep.c (riscv_register_name): Remove target description
5014         support.
5015         (riscv_gdbarch_init): Remove target description check.
5016
5017 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5020         comment.
5021         * riscv-tdep.h: Likewise.
5022
5023 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5026         (riscv_pseudo_register_write): Delete.
5027         (riscv_gdbarch_init): Remove all use of pseudo registers.
5028
5029 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5030
5031         * record-btrace.c (btrace_print_lines): Replace cleanup
5032         parameter with RAII equivalents.
5033         (btrace_insn_history): Replace cleanup with RAII equivalents.
5034         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5035         make_cleanup_ui_out_tuple_begin_end): Remove.
5036         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5037         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5038         make_cleanup_ui_out_list_begin_end): Remove.
5039
5040 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5041
5042         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5043         parameter types to std::vector.  Use bool.
5044         (record_btrace_wait): Replace VEC(tp_t) with
5045         std::vector<thread_info *>.
5046         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5047
5048 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5049
5050         * record-btrace.c (record_btrace_disable_callback): Remove.
5051         (struct scoped_btrace_disable): New.
5052         (record_btrace_open): Use scoped_btrace_disable.
5053
5054 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5057         reading values from registers.
5058
5059 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5062         where appropriate.
5063
5064 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5065
5066         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5067         change parameter type.  Use GDB's print functions, and use
5068         core_addr_to_string where appropriate.
5069         (riscv_push_dummy_call): Use core_addr_to_string where
5070         appropriate, update call to riscv_print_arg_location, and reindent
5071         a few lines.
5072         (riscv_return_value): Update call to riscv_print_arg_location.
5073
5074 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5075             Tim Newsome <tim@sifive.com>
5076             Albert Ou <a0u@eecs.berkeley.edu>
5077             Darius Rad <darius@bluespec.com>
5078
5079         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5080         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5081         (ALLDEPFILES): Add riscv-tdep.c
5082         * configure.tgt: Add riscv support.
5083         * riscv-tdep.c: New file.
5084         * riscv-tdep.h: New file.
5085         * NEWS: Mention new target.
5086         * MAINTAINERS: Add entry for riscv.
5087
5088 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5091         fields within aggregates.
5092
5093 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5094
5095         * record-btrace.c (btrace_print_lines): Change type of flags to
5096         gdb_disassembly_flags.
5097
5098 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5099
5100         * fbsd-nat.c: Include "inf-ptrace.h".
5101         (USE_SIGTRAP_SIGINFO): Conditionally define.
5102         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5103         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5104         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5105         function.
5106         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5107         Likewise.
5108         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5109         Likewise.
5110         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5111         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5112         "supports_stopped_by_hw_breakpoint" target methods.
5113
5114 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5115
5116         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5117         * fbsd-nat.c (debug_fbsd_nat): New variable.
5118         (show_fbsd_nat_debug): New function.
5119         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5120         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5121
5122 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5123
5124         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5125         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5126         prototype.
5127         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5128         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5129         method.
5130
5131 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5132
5133         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5134         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5135
5136 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5137
5138         * charset.c (struct charset_vector): New.
5139         (charsets): Change type to charset_vector.
5140         (find_charset_names): Adjust.
5141         (add_one): Adjust.
5142         (_initialize_charset): Adjust.
5143
5144 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5145
5146         * progspace.h (struct program_space) <deleted_solibs>: Change
5147         type to std::vector<std::string>.
5148         * progspace.c (clear_program_space_solib_cache): Adjust.
5149         * breakpoint.c (print_solib_event): Adjust.
5150         (check_status_catch_solib): Adjust.
5151         * solib.c (update_solib_list): Adjust.
5152         * ui-out.h (class ui_out) <field_string>: New overload.
5153         * ui-out.c (ui_out::field_string): New overload.
5154
5155 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5156
5157         * progspace.h (struct program_space): Add constructor and
5158         destructor, initialize fields.
5159         (add_program_space): Remove.
5160         * progspace.c (add_program_space): Rename to...
5161         (program_space::program_space): ... this.
5162         (release_program_space): Rename to...
5163         (program_space::~program_space): ... this.
5164         (delete_program_space): Use delete to delete program_space.
5165         (initialize_progspace): Use new to allocate program_space.
5166         * inferior.c (add_inferior_with_spaces): Likewise.
5167         (clone_inferior_command): Likewise.
5168         * infrun.c (follow_fork_inferior): Likewise.
5169         (handle_vfork_child_exec_or_exit): Likewise.
5170
5171 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5172
5173         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5174         (delim_string_to_char_ptr_vec): Return std::vector of
5175         gdb::unique_xmalloc_ptr.
5176         (dirnames_to_char_ptr_vec_append): Take std::vector of
5177         gdb::unique_xmalloc_ptr.
5178         (dirnames_to_char_ptr_vec): Return std::vector of
5179         gdb::unique_xmalloc_ptr.
5180         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5181         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5182         (delim_string_to_char_ptr_vec): Return an std::vector of
5183         gdb::unique_xmalloc_ptr, adjust the code.
5184         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5185         gdb::unique_xmalloc_ptr, adjust the code.
5186         (dirnames_to_char_ptr_vec): Return an std::vector of
5187         gdb::unique_xmalloc_ptr, adjust the code.
5188         * auto-load.c (auto_load_safe_path_vec): Change type to
5189         std::vector of gdb::unique_xmalloc_ptr.
5190         (auto_load_expand_dir_vars): Return an std::vector of
5191         gdb::unique_xmalloc_ptr, adjust the code.
5192         (auto_load_safe_path_vec_update): Adjust.
5193         (filename_is_in_auto_load_safe_path_vec): Adjust.
5194         (auto_load_objfile_script_1): Adjust.
5195         * build-id.c (build_id_to_debug_bfd): Adjust.
5196         * linux-thread-db.c (thread_db_load_search): Adjust.
5197         * source.c (add_path): Adjust.
5198         (openp): Adjust.
5199         * symfile.c (find_separate_debug_file): Adjust.
5200         * utils.c (do_free_char_ptr_vec): Remove.
5201         (make_cleanup_free_char_ptr_vec): Remove.
5202
5203 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5204
5205         PR gdb/22907
5206         * common/pathstuff.c: Conditionally include "<windows.h>".
5207
5208 2018-03-01  Georg Sauthoff  <mail@georg.so>
5209
5210         PR gdb/22888
5211         * gcore.in: Quote variables and switch interpreter to bash.
5212
5213 2018-03-01  Tom Tromey  <tom@tromey.com>
5214
5215         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5216         assertion.  Add assertion for discriminant_index.
5217         (quirk_rust_enum): Use correct base type name in univariant case.
5218
5219 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5220
5221         * record.c (get_call_history_modifiers): Return a
5222         record_print_flags.
5223         (cmd_record_call_history): Adjust.
5224         * record-btrace.c (record_btrace_call_history): Adjust.
5225         (record_btrace_call_history_range): Adjust.
5226         (record_btrace_call_history_from): Adjust.
5227         * target-debug.h (target_debug_print_record_print_flags): New.
5228         * target-delegates.c: Re-generate.
5229         * target.c (target_call_history): Change flags type.
5230         (target_call_history_from): Likewise.
5231         (target_call_history_range): Likewise.
5232         * target.h (struct target_ops) <target_call_history>: Likewise.
5233         (target_call_history_from): Likewise.
5234         (target_call_history_range): Likewise.
5235
5236 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5237             Simon Marchi  <simon.marchi@polymtl.ca>
5238
5239         * common/common-utils.c: Include "sys/stat.h".
5240         (is_regular_file): Move here from "source.c"; change return
5241         type to "bool".
5242         * common/common-utils.h (is_regular_file): New prototype.
5243         * common/pathstuff.c (contains_dir_separator): New function.
5244         * common/pathstuff.h (contains_dir_separator): New prototype.
5245         * source.c: Don't include "sys/stat.h".
5246         (is_regular_file): Move to "common/common-utils.c".
5247
5248 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5249
5250         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5251         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5252         * auto-load.c: Include "common/pathstuff.h".
5253         * common/common-def.h (current_directory): Move here.
5254         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5255         function.
5256         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5257         prototype.
5258         * common/pathstuff.c: New file.
5259         * common/pathstuff.h: New file.
5260         * compile/compile.c: Include "common/pathstuff.h".
5261         * defs.h (current_directory): Move to "common/common-defs.h".
5262         * dwarf2read.c: Include "common/pathstuff.h".
5263         * exec.c: Likewise.
5264         * guile/scm-safe-call.c: Likewise.
5265         * linux-thread-db.c: Likewise.
5266         * main.c: Likewise.
5267         * nto-tdep.c: Likewise.
5268         * objfiles.c: Likewise.
5269         * source.c: Likewise.
5270         * symtab.c: Likewise.
5271         * utils.c: Include "common/pathstuff.h".
5272         (gdb_realpath): Move to "common/pathstuff.c".
5273         (gdb_realpath_keepfile): Likewise.
5274         (gdb_abspath): Likewise.
5275         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5276         (gdb_realpath_keepfile): Likewise.
5277         (gdb_abspath): Likewise.
5278
5279 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5280
5281         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5282         wildcard process pid for super_resume for kernels with a
5283         specific bug.
5284
5285 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5286
5287         * compile/compile.c (get_args): Add additional comments
5288         explaining function.
5289
5290 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5291             Tom Tromey  <tom@tromey.com>
5292
5293         * target.h (memory_write_request_s): Remove typedef.  Don't define
5294         VEC.
5295         (target_write_memory_blocks): Change argument to std::vector.
5296         (struct memory_write_request): Add constructor.
5297         * target-memory.c (compare_block_starting_address): Return bool.
5298         Change argument types.
5299         (claim_memory): Change arguments to use std::vector.
5300         (split_regular_and_flash_blocks, blocks_to_erase)
5301         (compute_garbled_blocks): Likewise.
5302         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5303         (target_write_memory_blocks): Change argument to std::vector.
5304         * symfile.c (struct load_section_data): Add constructor and
5305         destructor.  Use std::vector for "requests".
5306         (struct load_progress_data): Add initializers.
5307         (load_section_callback): Update.  Use "new".
5308         (clear_memory_write_data): Remove.
5309         (generic_load): Update.
5310
5311 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5312
5313         * arch/aarch64.h: Use common/tdesc.h.
5314
5315 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5316
5317         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5318         architecture with a 64-bit ABI.
5319
5320 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5321
5322         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5323         ahead of target description loading.
5324
5325 2018-02-26  Tom Tromey  <tom@tromey.com>
5326
5327         * stack.c (backtrace_command_1): Update.
5328         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5329         of "flags".
5330         * python/py-framefilter.c (py_print_frame)
5331         (gdbpy_apply_frame_filter): Change type of "flags".
5332         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5333         of "flags".
5334         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5335         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5336         * extension.h (enum frame_filter_flag): Rename from
5337         frame_filter_flags.
5338         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5339         (apply_ext_lang_frame_filter): Change type of "flags".
5340         * extension.c (apply_ext_lang_frame_filter): Change type of
5341         "flags".
5342         * extension-priv.h (struct extension_language_ops)
5343         <apply_frame_filter>: Change type of "flags".
5344
5345 2018-02-26  Tom Tromey  <tom@tromey.com>
5346
5347         PR python/16497:
5348         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5349         off-by-one in py_end computation.
5350         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5351         PRINT_MORE_FRAMES.
5352         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5353         constant.
5354
5355 2018-02-26  Tom Tromey  <tom@tromey.com>
5356
5357         * dwarf2read.c (struct variant_field): New.
5358         (struct nextfield) <variant>: New field.
5359         (dwarf2_add_field): Handle DW_TAG_variant_part.
5360         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5361         discriminated union.
5362         (read_structure_type): Handle DW_TAG_variant_part.
5363         (handle_struct_member_die): New function, extracted from
5364         process_structure_scope.  Handle DW_TAG_variant.
5365         (process_structure_scope): Handle discriminated unions.  Call
5366         handle_struct_member_die.
5367
5368 2018-02-26  Tom Tromey  <tom@tromey.com>
5369
5370         * rust-lang.h (rust_last_path_segment): Declare.
5371         * rust-lang.c (rust_last_path_segment): Now public.  Change
5372         contract.
5373         (struct disr_info): Remove.
5374         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5375         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5376         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5377         (rust_enum_p, rust_enum_variant): New function.
5378         (rust_underscore_fields): Remove "offset" parameter.
5379         (rust_print_enum): New function.
5380         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5381         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5382         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5383         enums.
5384         (rust_internal_print_type): New function, from rust_print_type.
5385         Remove enum code.
5386         (rust_print_type): Call rust_internal_print_type.
5387         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5388         Update enum handling.
5389         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5390         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5391         (rust_union_quirks): New functions.
5392         (process_full_comp_unit, process_full_type_unit): Call
5393         rust_union_quirks.
5394         (process_structure_scope): Update rust_unions if necessary.
5395
5396 2018-02-26  Tom Tromey  <tom@tromey.com>
5397
5398         * value.h (value_union_variant): Declare.
5399         * valops.c (value_union_variant): New function.
5400         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5401         (struct discriminant_info): New.
5402         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5403         enumerator.
5404         (struct main_type) <flag_discriminated_union>: New field.
5405
5406 2018-02-26  Tom Tromey  <tom@tromey.com>
5407
5408         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5409         unittests/unpack-selftests.c.
5410         * unittests/unpack-selftests.c: New file.
5411         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5412
5413 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5414
5415         * dwarf2read.c (struct partial_die_info) <read>: New method.
5416         (read_partial_die): Remove the declaration.
5417         (load_partial_dies): Update.
5418         (partial_die_info::partial_die_info):
5419         (read_partial_die): Change it to partial_die_info::read.
5420
5421 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5422
5423         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5424         (fixup_partial_die): Remove declaration.
5425         (scan_partial_symbols): Update.
5426         (partial_die_parent_scope): Likewise.
5427         (partial_die_full_name): Likewise.
5428         (fixup_partial_die): Change it to partial_die_info::fixup.
5429
5430 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5431
5432         * dwarf2read.c (read_partial_die): Update the declaration.
5433         (load_partial_dies): Caller update.
5434         (read_partial_die): Remove one argument abbrev_len.
5435
5436 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5437
5438         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5439         assignment operator.
5440         (load_partial_dies): Use ctor and copy ctor.
5441         (read_partial_die): Update.
5442         (dwarf2_cu::find_partial_die): Use ctor.
5443
5444 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5445
5446         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5447         (find_partial_die_in_comp_unit): Change it to
5448         dwarf2_cu::find_partial_die.
5449         (find_partial_die): Update.
5450
5451 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5452
5453         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5454         is NULL.
5455
5456 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5457
5458         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5459
5460 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5461
5462         * arch/amd64.h: Use common/tdesc.h.
5463         * arch/i386.c: Likewise.
5464         * arch/i386.h: Likewise.
5465         * arch/tic6x.c: Likewise.
5466         * arch/tdesc.h: Move file from here...
5467         * common/tdesc.h: ...to here.
5468         * features/aarch64-core.c: Regenerate.
5469         * features/aarch64-fpu.c: Regenerate.
5470         * features/i386/32bit-avx.c: Regenerate.
5471         * features/i386/32bit-avx512.c: Regenerate.
5472         * features/i386/32bit-core.c: Regenerate.
5473         * features/i386/32bit-linux.c: Regenerate.
5474         * features/i386/32bit-mpx.c: Regenerate.
5475         * features/i386/32bit-pkeys.c: Regenerate.
5476         * features/i386/32bit-sse.c: Regenerate.
5477         * features/i386/64bit-avx.c: Regenerate.
5478         * features/i386/64bit-avx512.c: Regenerate.
5479         * features/i386/64bit-core.c: Regenerate.
5480         * features/i386/64bit-linux.c: Regenerate.
5481         * features/i386/64bit-mpx.c: Regenerate.
5482         * features/i386/64bit-pkeys.c: Regenerate.
5483         * features/i386/64bit-segments.c: Regenerate.
5484         * features/i386/64bit-sse.c: Regenerate.
5485         * features/i386/x32-core.c: Regenerate.
5486         * features/tic6x-c6xp.c: Regenerate.
5487         * features/tic6x-core.c: Regenerate.
5488         * features/tic6x-gp.c: Regenerate.
5489         * target-descriptions.c: Use common/tdesc.h.
5490         * target-descriptions.h: Likewise.
5491
5492 2018-02-24  Tom Tromey  <tom@tromey.com>
5493
5494         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5495         (try_thread_db_load_from_dir, thread_db_load_search): Use
5496         std::string.
5497         (info_auto_load_libthread_db_compare): Return bool.  Change
5498         argument types.
5499         (info_auto_load_libthread_db): Use std::vector, std::string.
5500         Remove cleanups.
5501
5502 2018-02-24  Tom Tromey  <tom@tromey.com>
5503
5504         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5505         std::string.
5506         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5507         std::string*.
5508         * gdbarch.c: Rebuild.
5509         * gdbarch.h: Rebuild.
5510         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5511         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5512         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5513         std::string*.
5514
5515 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5516
5517         * gdbtypes.h (sect_offset): Change type to uint64_t.
5518         (sect_offset_str): New function.
5519         * dwarf2read.c (create_addrmap_from_aranges): Use
5520         sect_offset_str.
5521         (error_check_comp_unit_head): Likewise.
5522         (create_debug_type_hash_table): Likewise.
5523         (read_cutu_die_from_dwo): Likewise.
5524         (init_cutu_and_read_dies): Likewise.
5525         (init_cutu_and_read_dies_no_follow): Likewise.
5526         (process_psymtab_comp_unit_reader): Likewise.
5527         (partial_die_parent_scope): Likewise.
5528         (peek_die_abbrev): Likewise.
5529         (process_queue): Likewise.
5530         (dwarf2_physname): Likewise.
5531         (read_namespace_alias): Likewise.
5532         (read_import_statement): Likewise.
5533         (create_dwo_cu_reader): Likewise.
5534         (create_cus_hash_table): Likewise.
5535         (lookup_dwo_cutu): Likewise.
5536         (inherit_abstract_dies): Likewise.
5537         (read_func_scope): Likewise.
5538         (read_call_site_scope): Likewise.
5539         (dwarf2_add_member_fn): Likewise.
5540         (read_common_block): Likewise.
5541         (read_module_type): Likewise.
5542         (read_typedef): Likewise.
5543         (read_subrange_type): Likewise.
5544         (load_partial_dies): Likewise.
5545         (read_partial_die): Likewise.
5546         (find_partial_die): Likewise.
5547         (read_str_index): Likewise.
5548         (dwarf2_string_attr): Likewise.
5549         (build_error_marker_type): Likewise.
5550         (lookup_die_type): Likewise.
5551         (dump_die_shallow): Likewise.
5552         (follow_die_ref): Likewise.
5553         (dwarf2_fetch_die_loc_sect_off): Likewise.
5554         (dwarf2_fetch_constant_bytes): Likewise.
5555         (follow_die_sig): Likewise.
5556         (get_signatured_type): Likewise.
5557         (get_DW_AT_signature_type): Likewise.
5558         (dwarf2_find_containing_comp_unit): Likewise.
5559         (set_die_type): Likewise.
5560
5561 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5562
5563         * arch/aarch64.c: Include "common-defs.h".
5564         * arch/amd64.c: Likewise.
5565         * arch/i386.c: Likewise.
5566
5567 2018-02-21  Tom Tromey  <tom@tromey.com>
5568
5569         * value.h: (extract_field_op): Update.
5570         * eval.c (extract_field_op): Return a const char *.
5571         * expression.h (parse_expression_for_completion): Update.
5572         * completer.c (complete_expression): Update.
5573         (add_struct_fields): Make fieldname const.
5574         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5575         (mark_completion_tag, parse_exp_in_context_1): Update.
5576         (parse_expression_for_completion): Change "name" to
5577         unique_xmalloc_ptr*.
5578
5579 2018-02-21  Tom Tromey  <tom@tromey.com>
5580
5581         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5582
5583 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5584
5585         * avr-tdep.c (avr_read_pc): Change parameter type to
5586         readable_regcache.
5587         * gdbarch.sh (read_pc): Likewise.
5588         * gdbarch.c: Re-generated.
5589         * gdbarch.h: Re-generated.
5590         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5591         readable_regcache.
5592         * ia64-tdep.c (ia64_read_pc): Likewise.
5593         * mips-tdep.c (mips_read_pc): Likewise.
5594         * spu-tdep.c (spu_read_pc): Likewise.
5595
5596 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5597
5598         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5599         * regcache-dump.c: New file.
5600         * regcache.c: Move register_dump to regcache-dump.c.
5601         (maintenance_print_registers): Likewise.
5602         (maintenance_print_raw_registers): Likewise.
5603         (maintenance_print_cooked_registers): Likewise.
5604         (maintenance_print_register_groups): Likewise.
5605         (maintenance_print_remote_registers): Likewise.
5606         (_initialize_regcache): Likewise.
5607         * regcache.h (register_dump): Moved from regcache.c.
5608
5609 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5610
5611         * regcache.c (regcache::regcache): Update.
5612         (regcache::invalidate): Move it to detached_regcache::invalidate.
5613         (get_thread_arch_aspace_regcache): Update.
5614         (regcache::raw_update): Update.
5615         (regcache::cooked_read): Remove some code.
5616         (regcache::cooked_read_value): Likewise.
5617         (regcache::raw_write): Remove assert on m_readonly_p.
5618         (regcache::raw_supply_integer): Move it to
5619         detached_regcache::raw_supply_integer.
5620         (regcache::raw_supply_zeroed): Likewise.
5621         * regcache.h (detached_regcache) <raw_supply_integer>: New
5622         declaration.
5623         <raw_supply_zeroed, invalidate>: Likewise.
5624         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5625         <invalidate>: Likewise.
5626         <m_readonly_p>: Removed.
5627
5628 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5629
5630         * infcmd.c (get_return_value): Let stop_regs point to
5631         get_current_regcache.
5632         * regcache.c (regcache::regcache): Remove.
5633         (register_dump_reg_buffer): New class.
5634         (regcache_print): Adjust.
5635         * regcache.h (regcache): Remove constructors.
5636
5637 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5638
5639         * regcache.c (class register_dump): New class.
5640         (register_dump_regcache, register_dump_none): New class.
5641         (register_dump_remote, register_dump_groups): New class.
5642         (regcache_print): Update.
5643         * regcache.h (regcache_dump_what): Move it to regcache.c.
5644         (regcache) <dump>: Remove.
5645
5646 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5647
5648         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5649          reg_buffer_rw *.
5650         (jit_unwind_reg_set_impl): Call raw_supply.
5651         (jit_frame_sniffer): Use reg_buffer_rw.
5652         * record-full.c (record_full_core_regbuf): Change its type.
5653         (record_full_core_open_1): Use reg_buffer_rw.
5654         (record_full_close): Likewise.
5655         (record_full_core_fetch_registers): Use regcache->raw_supply.
5656         (record_full_core_store_registers): Likewise.
5657         * regcache.c (regcache::get_register_status): Move it to
5658         reg_buffer.
5659         (regcache_raw_set_cached_value): Remove.
5660         (regcache::raw_set_cached_value): Remove.
5661         (regcache::raw_write): Call raw_supply.
5662         (regcache::raw_supply): Move it to reg_buffer_rw.
5663         * regcache.h (regcache_raw_set_cached_value): Remove.
5664         (reg_buffer_rw): New class.
5665
5666 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5667
5668         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5669         readonly_detached_regcache.
5670         (dummy_frame_prev_register): Use regcache->cooked_read.
5671         * frame.c (frame_save_as_regcache): Change return type.
5672         (frame_pop): Update.
5673         * frame.h (frame_save_as_regcache): Update declaration.
5674         * inferior.h (get_infcall_suspend_state_regcache): Update
5675         declaration.
5676         * infrun.c (infcall_suspend_state) <registers>: use
5677         readonly_detached_regcache.
5678         (save_infcall_suspend_state): Don't use regcache_dup.
5679         (get_infcall_suspend_state_regcache): Change return type.
5680         * linux-fork.c (struct fork_info) <savedregs>: Change to
5681         readonly_detached_regcache.
5682         <pc>: New field.
5683         (fork_save_infrun_state): Don't use regcache_dup.
5684         (info_checkpoints_command): Adjust.
5685         * mi/mi-main.c (register_changed_p): Update declaration.
5686         (mi_cmd_data_list_changed_registers): Use
5687         readonly_detached_regcache.
5688         (register_changed_p): Change parameter type to
5689         readonly_detached_regcache.
5690         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5691         readonly_detached_regcache.
5692         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5693         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5694         New.
5695         (regcache::save): Move it to reg_buffer.
5696         (regcache::restore): Change parameter type.
5697         (regcache_dup): Remove.
5698         * regcache.h (reg_buffer) <save>: New method.
5699         (readonly_detached_regcache): New class.
5700         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5701         readonly_detached_regcache.
5702         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5703
5704 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5705
5706         * frame.c (frame_save_as_regcache): Use regcache method save.
5707         (frame_pop): Use regcache method restore.
5708         * infrun.c (restore_infcall_suspend_state): Likewise.
5709         * linux-fork.c (fork_load_infrun_state): Likewise.
5710         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5711         save.
5712         * regcache.c (regcache_save): Remove.
5713         (regcache::restore): More asserts.
5714         (regcache_cpy): Remove.
5715         * regcache.h (regcache_save): Remove the declaration.
5716         (regcache::restore): Move from private to public.
5717         Remove the friend declaration of regcache_cpy.
5718         (regcache_cpy): Remove declaration.
5719
5720 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5721
5722         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5723         parameter type to 'readable_regcache *'.
5724         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5725         * arm-tdep.c (arm_neon_quad_read): Likewise.
5726         (arm_pseudo_read): Likewise.
5727         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5728         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5729         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5730         * gdbarch.c: Re-generated.
5731         * gdbarch.h: Re-generated.
5732         * gdbarch.sh (pseudo_register_read): Change parameter type to
5733         'readable_regcache *'.
5734         (pseudo_register_read_value): Likewise.
5735         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5736         (h8300_pseudo_register_read): Likewise.
5737         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5738         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5739         (i386_pseudo_register_read_into_value): Likewise.
5740         (i386_pseudo_register_read_value): Likewise.
5741         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5742         declaration.
5743         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5744         * m32c-tdep.c (m32c_raw_read): Likewise.
5745         (m32c_read_flg): Likewise.
5746         (m32c_banked_register): Likewise.
5747         (m32c_banked_read): Likewise.
5748         (m32c_sb_read): Likewise.
5749         (m32c_part_read): Likewise.
5750         (m32c_cat_read): Likewise.
5751         (m32c_r3r2r1r0_read): Likewise.
5752         (m32c_pseudo_register_read): Likewise.
5753         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5754         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5755         (mep_pseudo_cr64_read): Likewise.
5756         (mep_pseudo_register_read): Likewise.
5757         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5758         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5759         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5760         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5761         (regcache::cooked_read): Likewise.
5762         (regcache::cooked_read_value): Likewise.
5763         (regcache_cooked_read_signed):
5764         (regcache::cooked_read): Likewise.
5765         * regcache.h (readable_regcache): New class.
5766         (regcache): Inherit readable_regcache.  Move some methods to
5767         readable_regcache.
5768         * rl78-tdep.c (rl78_pseudo_register_read): Change
5769         parameter type to 'readable_regcache *'.
5770         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5771         (e500_pseudo_register_read): Change parameter type to
5772         'readable_regcache *'.
5773         (dfp_pseudo_register_read): Likewise.
5774         (vsx_pseudo_register_read): Likewise.
5775         (efpr_pseudo_register_read): Likewise.
5776         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5777         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5778         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5779         (sh64_pseudo_register_read): Likewise.
5780         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5781         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5782         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5783         (spu_pseudo_register_read): Likewise.
5784         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5785         (xtensa_pseudo_register_read): Likewise.
5786
5787 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5788
5789         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5790         (regcache::arch): Move it to reg_buffer::arch.
5791         (regcache::register_buffer): Likewise.
5792         (regcache::assert_regnum): Likewise.
5793         (regcache::num_raw_registers): Likewise.
5794         * regcache.h (reg_buffer): New class.
5795         (regcache): Inherit reg_buffer.
5796
5797 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5798
5799         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5800         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5801
5802 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5803
5804         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5805
5806 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5807
5808         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5809         (SFILES): Remove common/*.c files.
5810         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5811         * common/common.host: Add common reference.
5812         * configure.ac: Likewise.
5813         * configure: Regenerate.
5814
5815 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5816
5817         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5818         (block_initialize_namespace): Use new.
5819         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5820         (dwarf2_free_objfile): Use delete.
5821         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5822         (copy_type_recursive): Use new.
5823         * gdb_obstack.h (allocate_on_obstack): New.
5824
5825 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5826
5827         PR gdb/22849
5828         * inferior.c (exit_inferior_1): Reset inf->control.
5829
5830 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5831
5832         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5833         declaration.
5834
5835 2018-02-14  Pedro Alves  <palves@redhat.com>
5836
5837         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5838         frame_cleanup_after_sniffer on exception.
5839
5840 2018-02-14  Tom Tromey  <tom@tromey.com>
5841
5842         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5843         const.
5844         (solib_bfd_open): Make pathname const.
5845         * solib.c (solib_bfd_open): Make pathname const.
5846         * solib-spu.c (spu_bfd_fopen): Make name const.
5847         (spu_bfd_open): Make pathname const.
5848         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5849         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5850
5851 2018-02-14  Tom Tromey  <tom@tromey.com>
5852
5853         * symfile.c (symfile_bfd_open): Update.
5854         * source.h (openp, source_full_path_of, find_and_open_source):
5855         Change argument type to unique_xmalloc_ptr.
5856         * source.c (openp): Take a unique_xmalloc_ptr.
5857         (source_full_path_of, find_and_open_source): Likewise.
5858         (open_source_file, symtab_to_fullname): Update.
5859         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5860         unique_xmalloc_ptr.
5861         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5862         (exec_file_find): Update.
5863         * psymtab.c (psymtab_to_fullname): Update.
5864         * nto-tdep.h (nto_find_and_open_solib): Update.
5865         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5866         unique_xmalloc_ptr.
5867         * exec.c (exec_file_attach): Update.
5868         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5869         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5870
5871 2018-02-14  Tom Tromey  <tom@tromey.com>
5872
5873         * solib.c: Include source.h.
5874         * nto-tdep.c: Include source.h.
5875         * mi/mi-cmd-env.c: Include source.h.
5876         * infcmd.c: Include source.h.
5877         * exec.c: Include source.h.
5878         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5879         (add_path, directory_switch, source_path, init_source_path): Move
5880         declarations...
5881         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5882         (add_path, directory_switch, source_path, init_source_path):
5883         ...here.
5884
5885 2018-02-14  Tom Tromey  <tom@tromey.com>
5886
5887         * solist.h (exec_file_find, solib_find): Return
5888         unique_xmalloc_ptr.
5889         (solib_bfd_fopen): Take a const char *.
5890         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5891         (exec_file_find, solib_find): Likewise.
5892         (solib_bfd_fopen): Do not take ownership of "pathname".
5893         (solib_bfd_open): Use unique_xmalloc_ptr.
5894         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5895         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5896         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5897         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5898
5899 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5900
5901         * ada-lang.c (name_match_type_from_name): Remove reference to
5902         ada_name_for_lookup in function's documentation.
5903         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5904
5905 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5906
5907         * defs.h (enum openp_flags): New enum.
5908         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5909         Move to enum openp_flags.
5910         (openp_flags): New enum flags.
5911         (openp): Change parameter type to openp_flags.
5912         * source.c (openp): Change parameter type to openp_flags.
5913         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5914         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5915
5916 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5917
5918         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5919         per-command.
5920
5921 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5924         into...
5925         (class dwarf2_queue_guard): ...the destructor of this new class.
5926         (dw2_do_instantiate_symtab): Create instance of the new class
5927         dwarf2_queue_guard, remove cleanup.
5928
5929 2018-02-09  Tom Tromey  <tom@tromey.com>
5930
5931         * source.c (find_source_lines): Don't reference past the end of
5932         the vector.
5933
5934 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5935
5936         * remote.c (remote_btrace_maybe_reopen): Change error message.
5937         * btrace.c (btrace_enable): Likewise.
5938         (parse_xml_btrace): Likewise.
5939         (parse_xml_btrace_conf): Likewise.
5940
5941 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5942
5943         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5944         (linux_enable_pt, linux_enable_bts): Call
5945         diagnose_perf_event_open_fail.
5946
5947 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5948
5949         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5950         Remove parameter and change return type.  Update callers.  Move it.
5951         (linux_enable_bts, linux_enable_pt): Improve error message.
5952         (linux_enable_pt): Remove zero buffer size check.
5953         (linux_enable_btrace): Improve error messages.  Remove NULL return
5954         check.
5955
5956 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5957
5958         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5959         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5960         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5961         (linux_supports_pt, linux_supports_btrace): Remove.
5962         (linux_enable_bts): Call cpu_supports_bts.
5963         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5964         * remote.c (remote_supports_btrace): Remove.
5965         (init_remote_ops): Remove remote_supports_btrace.
5966         * target-delegates.c: Regenerated.
5967         * target.c (target_supports_btrace): Remove.
5968         * target.h (target_ops) <to_supports_btrace>: Remove
5969         (target_supports_btrace): Remove.
5970         * x86-linux-nat.c (x86_linux_create_target): Remove
5971         linux_supports_btrace.
5972
5973 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5974
5975         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5976         btrace failed.
5977         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5978         exception and use message in own exception.
5979
5980 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5981
5982         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5983         (perf_event_pt_event_type): Use gdb_file_up.
5984         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5985         scoped_fd, and scoped_mmap.
5986
5987 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5988
5989         * common/scoped_mmap.h: New.
5990         * unittests/scoped_mmap-selftest.c: New.
5991         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5992         unittests/scoped_mmap-selftest.c.
5993
5994 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5995
5996         * common/scoped_fd.h: New.
5997         * unittests/scoped_fd-selftest.c: New.
5998         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5999         unittests/scoped_fd-selftest.c.
6000
6001 2018-02-09  Tom Tromey  <tom@tromey.com>
6002
6003         * auto-load.c (auto_load_section_scripts): Use
6004         gdb::unique_xmalloc_ptr.
6005
6006 2018-02-09  Tom Tromey  <tom@tromey.com>
6007
6008         * auto-load.c (execute_script_contents): Use std::string.
6009
6010 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6011
6012         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6013         Python function, rather than a new command.
6014
6015 2018-02-08  Tom Tromey  <tom@tromey.com>
6016
6017         * solib.c (solib_find_1): Use std::string.
6018         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6019
6020 2018-02-08  Tom Tromey  <tom@tromey.com>
6021
6022         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6023
6024 2018-02-08  Tom Tromey  <tom@tromey.com>
6025
6026         * source.c (find_source_lines): Use gdb::def_vector.
6027
6028 2018-02-08  Tom Tromey  <tom@tromey.com>
6029
6030         * macrocmd.c (struct temporary_macro_definition): New.
6031         (macro_define_command): Use temporary_macro_definition.  Remove
6032         cleanups.
6033         (free_macro_definition_ptr): Remove.
6034
6035 2018-02-08  Tom Tromey  <tom@tromey.com>
6036
6037         * macroexp.c (maybe_expand): Use std::string.
6038
6039 2018-02-08  Tom Tromey  <tom@tromey.com>
6040
6041         * macroexp.c (struct macro_buffer): Add initializers for some
6042         members.
6043         (init_buffer, init_shared_buffer, free_buffer)
6044         (free_buffer_return_text): Remove.
6045         (macro_buffer): New constructors.
6046         (~macro_buffer): New destructor.
6047         (macro_buffer::set_shared): New method.
6048         (macro_buffer::resize_buffer, macro_buffer::appendc)
6049         (macro_buffer::appendmem): Now methods, not free functions.
6050         (set_token, append_tokens_without_splicing, stringify)
6051         (macro_stringify): Update.
6052         (gather_arguments): Change return type.  Remove argc_p argument,
6053         add args_ptr argument.  Use std::vector.
6054         (substitute_args): Remove argc argument.  Accept std::vector.
6055         (expand): Update.  Use std::vector.
6056         (scan, macro_expand, macro_expand_next): Update.
6057
6058 2018-02-08  Tom Tromey  <tom@tromey.com>
6059
6060         * symtab.c (default_collect_symbol_completion_matches_break_on):
6061         Use unique_xmalloc_ptr.
6062         * macroscope.h: (sal_macro_scope, user_macro_scope)
6063         (default_macro_scope): Return unique_xmalloc_ptr.
6064         * macroscope.c (sal_macro_scope, user_macro_scope)
6065         (default_macro_scope): Return unique_xmalloc_ptr.
6066         * macroexp.h (macro_expand, macro_expand_once): Return
6067         unique_xmalloc_ptr.
6068         * macroexp.c (macro_expand, macro_expand_once): Return
6069         unique_xmalloc_ptr.
6070         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6071         (info_macro_command, info_macros_command): Use
6072         unique_xmalloc_ptr.
6073         * compile/compile-c-support.c (write_macro_definitions): Use
6074         unique_xmalloc_ptr.
6075         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6076
6077 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6078
6079         * value.c (value_static_field): Assign field type instead of
6080         containing type when returning an optimized out value.
6081
6082 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6083
6084         * ft32-tdep.c (ft32_read_pc): Remove.
6085         (ft32_write_pc): Remove.
6086         (ft32_gdbarch_init): Update.
6087         * m32r-tdep.c (m32r_read_pc): Remove.
6088         (m32r_gdbarch_init): Update.
6089         * mep-tdep.c (mep_read_pc): Remove.
6090         (mep_gdbarch_init): Update.
6091         * microblaze-tdep.c (microblaze_write_pc): Remove.
6092         (microblaze_gdbarch_init): Update.
6093         * mn10300-tdep.c (mn10300_read_pc): Remove.
6094         (mn10300_write_pc): Remove.
6095         (mn10300_gdbarch_init): Update.
6096         * moxie-tdep.c (moxie_read_pc): Remove.
6097         (moxie_write_pc): Remove.
6098         (moxie_gdbarch_init): Update.
6099
6100 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6101
6102         * expprint.c (print_subexp_standard): Handle
6103         OP_F77_UNDETERMINED_ARGLIST.
6104         (dump_subexp_body_standard): Likewise.
6105
6106 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6107
6108         * target-descriptions.c (tdesc_element_visitor) Add empty
6109         implementations.
6110         (tdesc_type): Move make_gdb_type from here.
6111         (tdesc_type_builtin): Likewise.
6112         (tdesc_type_vector): Likewise.
6113         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6114         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6115         (make_gdb_type_union): Likewise.
6116         (make_gdb_type_flags): Likewise.
6117         (make_gdb_type_enum): Likewise.
6118         (make_gdb_type): New function.
6119         (tdesc_register_type): Use static make_gdb_type.
6120
6121 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6122
6123         * infcmd.c (default_print_one_register_info): Align natural-format
6124         column values consistently one under another.
6125         (pad_to_column): New function.
6126
6127 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6128
6129         * dwarf2read.c (dwarf2_physname): Move commment.
6130
6131 2018-02-01  Leszek Swirski  <leszeks@google.com>
6132
6133         * varobj.c (varobj_formatted_print_options): Allow recursive
6134         pretty printing if pretty printing is enabled.
6135
6136 2018-02-01  Leszek Swirski  <leszeks@google.com>
6137
6138         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6139         names after a structop as a filename.
6140
6141 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6142
6143         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6144         (arm_record_coproc_data_proc): Likewise.
6145
6146 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6147
6148         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6149
6150 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6151
6152         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6153         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6154
6155 2018-01-31  Pedro Alves  <palves@redhat.com>
6156
6157         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6158         * inflow.c (child_terminal_save_inferior): Wrap reference to
6159         tcgetpgrp in HAVE_TERMIOS_H.
6160         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6161         _WIN32.
6162         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6163         always iterate over all inferiors.
6164         (gdbsim_cntrl_c): Adjust.
6165         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6166
6167 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6168
6169         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6170         index type is objfile-owned if the element type is as well.
6171
6172 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6173
6174         GDB 8.1 released.
6175
6176 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6177
6178         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6179         "features/s390x-linux64.c".
6180         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6181         s390_linux32 and s390x_linux64.
6182         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6183         default tdesc.
6184         * s390-tdep.c: Include "features/s390-linux32.c" and
6185         "features/s390x-linux64.c".
6186         (s390_tdesc_valid): Add check for tdesc_has_registers.
6187         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6188         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6189         tdesc_s390x_linux64.
6190         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6191         tdesc_s390x_linux64 to...
6192         * s390-tdep.h: ...here.
6193
6194 2018-01-30  Pedro Alves  <palves@redhat.com>
6195
6196         PR gdb/13211
6197         * config.in, configure: Regenerate.
6198         * configure.ac: Check for getpgid.
6199         * go32-nat.c (go32_pass_ctrlc): New.
6200         (go32_target): Install it.
6201         * inf-child.c (inf_child_target): Install
6202         child_terminal_save_inferior, child_pass_ctrlc and
6203         child_interrupt.
6204         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6205         (inf_ptrace_target): No longer install it.
6206         * infcmd.c (interrupt_target_1): Adjust.
6207         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6208         (child_interrupt): Declare.
6209         (inferior::terminal_state): New.
6210         * inflow.c (struct terminal_info): Update comments.
6211         (inferior_process_group): Delete.
6212         (terminal_is_ours): Delete.
6213         (gdb_tty_state): New.
6214         (child_terminal_init): Adjust.
6215         (is_gdb_terminal, sharing_input_terminal_1)
6216         (sharing_input_terminal): New functions.
6217         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6218         Set the process's actual process group in the foreground if
6219         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6220         mark terminal as the inferior's if not sharing GDB's terminal.
6221         Don't check attach_flag.
6222         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6223         pass down a target_terminal_state.
6224         (child_terminal_save_inferior): New, factored out from ...
6225         (child_terminal_ours_1): ... this.  Handle
6226         target_terminal_state::is_ours_for_output.
6227         (child_interrupt, child_pass_ctrlc): New.
6228         (inflow_inferior_exit): Clear the inferior's terminal_state.
6229         (copy_terminal_info): Copy the inferior's terminal state.
6230         (_initialize_inflow): Remove reference to terminal_is_ours.
6231         * inflow.h (inferior_process_group): Delete.
6232         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6233         * procfs.c (procfs_target): Don't install procfs_interrupt.
6234         (procfs_interrupt): Delete.
6235         * remote.c (remote_serial_quit_handler): Adjust.
6236         (remote_interrupt): Remove ptid parameter.  Adjust.
6237         * target-delegates.c: Regenerate.
6238         * target.c: Include "terminal.h".
6239         (target_terminal::terminal_state): Rename to ...
6240         (target_terminal::m_terminal_state): ... this.
6241         (target_terminal::init): Adjust.
6242         (target_terminal::inferior): Adjust to per-inferior
6243         terminal_state.
6244         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6245         (target_terminal::ours, target_terminal::ours_for_output): Use
6246         target_terminal_is_ours_kind.
6247         (target_interrupt): Remove ptid parameter.  Adjust.
6248         (default_target_pass_ctrlc): Adjust.
6249         * target.h (target_ops::to_terminal_save_inferior): New field.
6250         (target_ops::to_interrupt): Remove ptid_t parameter.
6251         (target_interrupt): Remove ptid_t parameter.  Update comment.
6252         (target_pass_ctrlc): Update comment.
6253         * target/target.h (target_terminal_state): New scoped enum,
6254         factored out of ...
6255         (target_terminal::terminal_state): ... here.
6256         (target_terminal::inferior): Update comments.
6257         (target_terminal::restore_inferior): New.
6258         (target_terminal::is_inferior, target_terminal::is_ours)
6259         (target_terminal::is_ours_for_output): Adjust.
6260         (target_terminal::scoped_restore_terminal_state): Adjust to
6261         rename, and call restore_inferior() instead of inferior().
6262         (target_terminal::scoped_restore_terminal_state::m_state): Change
6263         type.
6264         (target_terminal::terminal_state): Rename to ...
6265         (target_terminal::m_terminal_state): ... this and change type.
6266
6267 2018-01-30  Pedro Alves  <palves@redhat.com>
6268
6269         * linux-nat.c (wait_for_signal): New function.
6270         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6271         directly.
6272         (async_terminal_is_ours)
6273         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6274         (linux_nat_add_target): Don't override
6275         to_terminal_inferior/to_terminal_ours.
6276
6277 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6278
6279         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6280
6281 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6282
6283         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6284         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6285         dwarf2_per_objfile_free here.
6286         (dwarf2_per_objfile_free): Remove.
6287         (_initialize_dwarf2_read): Don't register
6288         dwarf2_per_objfile_free as a registry cleanup.
6289
6290 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6291
6292         Avoid compilation errors in MinGW native builds
6293
6294         The error is triggered by including python-internal.h, and the
6295         error message is:
6296
6297              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6298                       from build-gnulib/import/math.h:27,
6299                       from d:/usr/Python26/include/pyport.h:235,
6300                       from d:/usr/Python26/include/Python.h:58,
6301                       from python/python-internal.h:94,
6302                       from python/py-arch.c:24:
6303              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6304         using ::hypot;
6305                 ^~~~~
6306
6307         This happens because Python headers define 'hypot' to expand t
6308         '_hypot' in the Windows builds.
6309         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6310         'hypoth'.  This avoids a compilation error.
6311
6312 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6313
6314         * MAINTAINERS (Write After Approval): Fix ordering.
6315
6316 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6317
6318         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6319
6320 2018-01-26  Alan Modra  <amodra@gmail.com>
6321
6322         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6323         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6324         Remove nop.  Make const.  Comment.
6325         (powerpc32_plt_stub_so_2): New.
6326         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6327         Correct count.  Update uses.
6328         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6329         Move common code reading PLT entry word.  Correct
6330         powerpc32_plt_stub PLT address calculation.
6331         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6332         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6333         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6334         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6335         (ppc64_standard_linkage8): Likewise.
6336         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6337         Correct insns description.
6338         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6339
6340 2018-01-24  Pedro Alves  <palves@redhat.com>
6341
6342         GCC PR libstdc++/83906
6343         * gdbtypes.c (operator==(const dynamic_prop &,
6344         const dynamic_prop &)): New.
6345         (operator==(const range_bounds &, const range_bounds &)): New.
6346         (check_types_equal): Use them instead of memcmp.
6347         * gdbtypes.h (operator==(const dynamic_prop &,
6348         const dynamic_prop &)): Declare.
6349         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6350         (operator==(const range_bounds &, const range_bounds &)): Declare.
6351         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6352
6353 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6354
6355         * s390-linux-tdep.c (s390_record_address_mask)
6356         (s390_record_calc_disp_common, s390_record_calc_disp)
6357         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6358         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6359         (s390_process_record): Move to s390-tdep.c.
6360         (s390_linux_init_abi_any): Adjust.
6361         * s390-tdep.c (s390_record_address_mask)
6362         (s390_record_calc_disp_common, s390_record_calc_disp)
6363         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6364         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6365         (s390_process_record): Moved from s390-linux-tdep.c
6366         (s390_gdbarch_init): Adjust.
6367
6368 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6369
6370         * s390-linux-nat.c (s390-tdep.h): New include.
6371         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6372         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6373         (ALLDEPFILES): Add s390-tdep.c.
6374         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6375         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6376         * s390-tdep.h: ...this.  New file.
6377         * s390-linux-tdep.c (s390-tdep.h): New include.
6378         (_initialize_s390_tdep): Rename to...
6379         (_initialize_s390_linux_tdep): ...this and adjust.
6380         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6381         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6382         s390-tdep.h.
6383         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6384         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6385         (s390_is_partial_instruction, s390_software_single_step)
6386         (is_non_branch_ril, s390_displaced_step_copy_insn)
6387         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6388         (s390_prologue_data, s390_addr, s390_store, s390_load)
6389         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6390         (s390_register_call_saved, s390_guess_tracepoint_registers)
6391         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6392         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6393         (s390_pseudo_register_name, s390_pseudo_register_type)
6394         (s390_pseudo_register_read, s390_pseudo_register_write)
6395         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6396         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6397         (s390_addr_bits_remove, s390_address_class_type_flags)
6398         (s390_address_class_type_flags_to_name)
6399         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6400         (s390_function_arg_float, s390_function_arg_vector)
6401         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6402         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6403         (s390_frame_align, s390_register_return_value, s390_return_value)
6404         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6405         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6406         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6407         (s390_trad_frame_prev_register, s390_unwind_cache)
6408         (s390_prologue_frame_unwind_cache)
6409         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6410         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6411         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6412         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6413         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6414         (s390_frame_base_address, s390_local_base_address)
6415         (s390_frame_base, s390_gcc_target_options)
6416         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6417         (s390_validate_reg_range, s390_tdesc_valid)
6418         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6419         * s390-tdep.c: ...this.  New file.
6420
6421 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6422
6423         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6424         (s390_process_record, s390_gdbarch_tdep_alloc)
6425         (s390_linux_init_abi_any): Use/set new hook.
6426
6427 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6428
6429         * s390-linux-tdep.c (osabi.h): New include.
6430         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6431         (s390_linux_init_abi_any): New functions.
6432         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6433
6434 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6435
6436         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6437         tdesc_has_registers check
6438
6439 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6440
6441         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6442         (s390_validate_reg_range): New macro.
6443         (s390_gdbarch_init): Adjust.
6444
6445 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6446
6447         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6448         (s390_gdbarch_tdep_alloc): Adjust.
6449         (s390_gdbarch_init): Adjust.
6450
6451 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6452
6453         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6454         <have_tdb>: Change type to bool.
6455         (s390_gdbarch_tdep_alloc): Adjust.
6456         (s390_gdbarch_init): Adjust.
6457
6458 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6459
6460         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6461         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6462         (s390_gdbarch_tdep_alloc): New function.
6463         (s390_gdbarch_init): Allocate tdep at start and use its fields
6464         instead of separate variables.
6465
6466 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6467
6468         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6469         when looking for cached gdbarch and add comment for remaining.
6470
6471 2018-01-22  Pedro Alves  <palves@redhat.com>
6472             Sergio Durigan Junior  <sergiodj@redhat.com>
6473
6474         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6475         case.
6476
6477 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6478
6479         * MAINTAINERS: Update my company e-mail address.
6480
6481 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6482
6483         * regcache.c (cooked_write_test): New function.
6484         (_initialize_regcache): Register the test.
6485
6486 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6487
6488         * ia64-tdep.c (ia64_pseudo_register_read): Call
6489         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6490         * m32c-tdep.c (m32c_cat_read): Likewise.
6491         (m32c_r3r2r1r0_read): Likewise.
6492         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6493         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6494
6495 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6496
6497         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6498         method raw_read instead of regcache_raw_read.
6499         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6500         * arm-tdep.c (arm_neon_quad_read): Likewise.
6501         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6502         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6503         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6504         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6505         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6506         (i386_pseudo_register_read_into_value): Likewise.
6507         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6508         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6509         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6510         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6511         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6512         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6513         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6514         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6515         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6516
6517 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6518
6519         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6520         * configure.tgt: Remove target mt.
6521         * mt-tdep.c: Remove.
6522         * regcache.c (cooked_read_test): Remove the check for mt.
6523
6524 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6525
6526         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6527         instead of gdbarch_pseudo_register_read_value.
6528
6529 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6530
6531         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6532         language is Ada.
6533
6534 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6535
6536         * linespec.c (create_sals_line_offset): Remove code that preserved
6537         the symtab_and_line's line number.
6538
6539 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * varobj.c (varobj_create): Don't set valid_block when creating a
6542         floating varobj.
6543
6544 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * varobj.c (varobj_create): Remove out of date comment.
6547
6548 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         PR mi/20395
6551         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6552         updating innermost block.
6553         * parse.c (innermost_block_tracker::update): Take extra type
6554         parameter, and check types match before updating innermost block.
6555         (write_dollar_variable): Update innermost block for registers.
6556         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6557         (innermost_block_tracker::innermost_block_tracker): Initialise
6558         m_types member.
6559         (innermost_block_tracker::reset): Take type parameter.
6560         (innermost_block_tracker::update): Take type parameter, and pass
6561         type through as needed.
6562         (innermost_block_tracker::m_types): New member.
6563         * varobj.c (varobj_create): Pass type when reseting innermost
6564         block.
6565
6566 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6569         * ada-lang.c (resolve_subexp): Likewise.
6570         * breakpoint.c (set_breakpoint_condition) Likewise.
6571         (watch_command_1) Likewise.
6572         * c-exp.y (variable): Likewise.
6573         * d-exp.y (PrimaryExpression): Likewise.
6574         * f-exp.y (variable): Likewise.
6575         * go-exp.y (variable): Likewise.
6576         * m2-exp.y (variable): Likewise.
6577         * objfiles.c (objfile::~objfile): Likewise.
6578         * p-exp.y (variable): Likewise.
6579         * parse.c (innermost_block): Change type.
6580         * parser-defs.h (class innermost_block_tracker): New.
6581         (innermost_block): Change to innermost_block_tracker.
6582         * printcmd.c (display_command): Switch to innermost_block API.
6583         (do_one_display): Likewise.
6584         * rust-exp.y (do_one_display): Likewise.
6585         * symfile.c (clear_symtab_users): Likewise.
6586         * varobj.c (varobj_create): Switch to innermost_block API, replace
6587         use of innermost_block with block stored on varobj object.
6588
6589 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6590
6591         * expression.h (innermost_block): Remove declaration.
6592         * varobj.c: Add 'parser-defs.h' include.
6593
6594 2018-01-19  Tom Tromey  <tom@tromey.com>
6595
6596         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6597         symbols in the static and global blocks.
6598
6599 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6600
6601         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6602         gdb_ptrace.h, and move including gdb_wait.h ...
6603         * nat/linux-ptrace.h: ... to here.
6604
6605 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6606
6607         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6608         inf_ptrace_detach_success.
6609         (inf_ptrace_detach_success): Add inferior parameter, use it
6610         instead of inferior_ptid, pass it to detach_inferior.
6611         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6612         parameter.
6613         * inferior.c (detach_inferior): Add overload that takes an
6614         inferior object.
6615         * inferior.h (detach_inferior): Likewise.
6616         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6617         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6618         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6619
6620 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6621
6622         * target.h (struct target_ops) <to_detach>: Add inferior
6623         parameter.
6624         (target_detach): Likewise.
6625         * target.c (dispose_inferior): Pass inferior down.
6626         (target_detach): Pass inferior down.  Assert that it is equal to
6627         the current inferior.
6628         * aix-thread.c (aix_thread_detach): Pass inferior down.
6629         * corefile.c (core_file_command): Pass current_inferior() down.
6630         * corelow.c (core_detach): Add inferior parameter.
6631         * darwin-nat.c (darwin_detach): Likewise.
6632         * gnu-nat.c (gnu_detach): Likewise.
6633         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6634         * infcmd.c (detach_command): Pass current_inferior() down to
6635         target_detach.
6636         * infrun.c (follow_fork_inferior): Pass parent_inf to
6637         target_detach.
6638         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6639         target_detach.
6640         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6641         * linux-thread-db.c (thread_db_detach): Likewise.
6642         * nto-procfs.c (procfs_detach): Likewise.
6643         * procfs.c (procfs_detach): Likewise.
6644         * record.c (record_detach): Likewise.
6645         * record.h (struct inferior): Forward-declare.
6646         (record_detach): Add inferior parameter.
6647         * remote-sim.c (gdbsim_detach): Likewise.
6648         * remote.c (remote_detach_1): Likewise.
6649         (remote_detach): Likewise.
6650         (extended_remote_detach): Likewise.
6651         * sol-thread.c (sol_thread_detach): Likewise.
6652         * target-debug.h (target_debug_print_inferior_p): New macro.
6653         * target-delegates.c: Re-generate.
6654         * top.c (kill_or_detach): Pass inferior down to target_detach.
6655         * windows-nat.c (windows_detach): Add inferior parameter.
6656
6657 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6658
6659         * target.h (struct target_ops) <to_detach>: Remove args
6660         parameter.
6661         (target_detach): Likewise.
6662         * target.c (dispose_inferior): Adjust.
6663         (target_detach): Remove args parameter, adjust.
6664         * aix-thread.c (aix_thread_detach): Adjust.
6665         * corefile.c (core_file_command): Adjust.
6666         * corelow.c (core_detach): Adjust.
6667         * darwin-nat.c (darwin_detach): Adjust.
6668         * gnu-nat.c (gnu_detach): Adjust.
6669         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6670         * infcmd.c (detach_command): Adjust
6671         * infrun.c (follow_fork_inferior): Adjust.
6672         (handle_vfork_child_exec_or_exit): Adjust.
6673         * linux-fork.c (linux_fork_detach): Remove args parameter.
6674         * linux-fork.h (linux_fork_detach): Likewise.
6675         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6676         * linux-thread-db.c (thread_db_detach): Likewise.
6677         * nto-procfs.c (procfs_detach): Likewise.
6678         * procfs.c (procfs_detach): Likewise.
6679         (do_detach): Remove signo parameter.
6680         * record.c (record_detach): Remove args parameter.
6681         * record.h (record_detach): Likewise.
6682         * remote-sim.c (gdbsim_detach): Likewise.
6683         * remote.c (remote_detach_1): Likewise.
6684         (remote_detach): Likewise.
6685         (extended_remote_detach): Likewise.
6686         * sol-thread.c (sol_thread_detach): Likewise.
6687         * target-delegates.c: Re-generate.
6688         * top.c (struct qt_args) <args>: Remove field.
6689         (kill_or_detach): Don't pass args.
6690         (quit_force): Don't set args.
6691         * windows-nat.c (windows_detach): Remove args parameter.
6692
6693 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6694
6695         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6696         (arm_linux_init_abi): Install it.
6697
6698 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6699
6700         * osabi.c (gdb_osabi_names): Extend the regexp for
6701         arm-linux-gnueabihf.
6702
6703 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6704
6705         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6706         m_abbrevs.
6707         (abbrev_table::add_abbrev): Update.
6708         (abbrev_table::lookup_abbrev): Update.
6709
6710 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6711
6712         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6713
6714 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6715
6716         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6717         to "std::string".
6718
6719 2018-01-17  Tom Tromey  <tom@tromey.com>
6720
6721         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6722
6723 2018-01-17  Tom Tromey  <tom@tromey.com>
6724
6725         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6726         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6727         (create_array_type_with_stride): Update.
6728         * dwarf2read.c (set_die_type): Update.
6729
6730 2018-01-17  Tom Tromey  <tom@tromey.com>
6731
6732         * dwarf2read.c (delayed_method_info): Remove typedef.
6733         (dwarf2_cu::method_info): Now a std::vector.
6734         (add_to_method_list): Update.
6735         (free_delayed_list): Remove.
6736         (compute_delayed_physnames): Update.
6737         (process_full_comp_unit, process_full_type_unit): Clear the method
6738         list.  Remove cleanups.
6739         (psymtab_include_file_name): Add name_holder parameter.  Use
6740         unique_xmalloc_ptr.
6741         (dwarf_decode_lines): Update.
6742
6743 2018-01-17  Tom Tromey  <tom@tromey.com>
6744             Simon Marchi  <simon.marchi@ericsson.com>
6745
6746         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6747         (dwarf2_per_objfile::free_cached_comp_units)
6748         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6749         (init_cutu_and_read_dies_no_follow): Update.
6750         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6751         (dwarf2_cu::~dwarf2_cu): New.
6752         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6753         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6754
6755 2018-01-17  Tom Tromey  <tom@tromey.com>
6756             Simon Marchi  <simon.marchi@ericsson.com>
6757
6758         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6759         (struct die_reader_specs) <abbrev_table>: New member.
6760         (struct abbrev_table): Add constructor.
6761         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6762         <abbrev_obstack>: Now an auto_obstack.
6763         (abbrev_table_up): New typedef.
6764         (init_cu_die_reader): Add abbrev_table parameter.
6765         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6766         Add result_dwo_abbrev_table.
6767         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6768         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6769         Update.
6770         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6771         parameter.
6772         (skip_children): Update.
6773         (abbrev_table::alloc_abbrev): Rename from
6774         abbrev_table_alloc_abbrev.
6775         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6776         (abbrev_table::lookup_abbrev): Rename from
6777         abbrev_table_lookup_abbrev.
6778         (abbrev_table_read_table): Return abbrev_table_up.
6779         (abbrev_table_free, abbrev_table_free_cleanup)
6780         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6781         (load_partial_dies): Update.
6782
6783 2018-01-17  Tom Tromey  <tom@tromey.com>
6784
6785         * dwarf2read.c (dwarf2_compute_name): Update comment.
6786         (read_func_scope, read_variable): Update.
6787         (new_symbol): Remove.
6788         (new_symbol_full): Rename to new_symbol.
6789
6790 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6791
6792         PR gdb/16577
6793         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6794         a warning instead of throwing an error, set section size to 0 and return
6795         NULL.
6796         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6797
6798 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6799
6800         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6801         std::string.
6802         (linux_ptrace_attach_fail_reason_string): Likewise.
6803         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6804         Likewise.
6805         (linux_ptrace_attach_fail_reason_string): Likewise.
6806         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6807
6808 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6809
6810         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6811
6812 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6813
6814         PR gdb/21559
6815         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6816         checking for fs_base/gs_base fields in struct user_regs_struct.
6817         * configure: Regenerate.
6818
6819 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6820
6821         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6822         function.
6823         (aarch64_linux_init_abi): Install it to gdbarch hook
6824         gcc_target_options.
6825
6826 2018-01-15  Pedro Alves  <palves@redhat.com>
6827
6828         * common/signals-state-save-restore.c
6829         (save_original_signals_state): Fix typos.
6830
6831 2017-01-12  Tom Tromey  <tom@tromey.com>
6832             Sergio Durigan Junior  <sergiodj@redhat.com>
6833
6834         * Makefile.in (install-only): Install gdb-add-index.
6835
6836 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6837
6838         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6839
6840 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6841
6842         * infrun.c (keep_going_pass_signal): Clear step-over info when
6843         insert_breakpoints fails.
6844
6845 2018-01-11  Pedro Alves  <palves@redhat.com>
6846
6847         PR gdb/22583
6848         * infrun.c (resume): Rename to ...
6849         (resume_1): ... this.
6850         (resume): Reimplement as wrapper around resume_1.
6851
6852 2018-01-11  Pedro Alves  <palves@redhat.com>
6853
6854         PR remote/22597
6855         * remote.c (remote_parse_stop_reply): Default to the last-set
6856         general thread instead of to 'magic_null_ptid'.
6857
6858 2018-01-10  Pedro Alves  <palves@redhat.com>
6859
6860         * language.h (language_get_symbol_name_matcher): Rename ...
6861         (get_symbol_name_matcher): ... this.
6862         * language.c (language_get_symbol_name_matcher): Ditto.
6863         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6864         callers adjusted.
6865
6866 2018-01-10  Pedro Alves  <palves@redhat.com>
6867
6868         PR gdb/22670
6869         * dwarf2read.c
6870         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6871         Adjust to use language_get_symbol_name_matcher instead of
6872         language_defn::la_get_symbol_name_matcher.
6873         * language.c (language_get_symbol_name_matcher): If in Ada mode
6874         and the lookup name is a verbatim match, return Ada's matcher.
6875         * language.h (language_get_symbol_name_matcher): Adjust comment.
6876         (ada_lookup_name_info::verbatim_p):: New method.
6877
6878 2018-01-10  Pedro Alves  <palves@redhat.com>
6879
6880         PR gdb/22670
6881         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6882         minsym's language is language_auto or language_cplus, pass down
6883         language_ada instead.
6884         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6885
6886 2018-01-10  Pedro Alves  <palves@redhat.com>
6887
6888         PR gdb/22670
6889         * minsyms.c (linkage_name_str): New function.
6890         (iterate_over_minimal_symbols): Use it.
6891
6892 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6893
6894         * NEWS: Document that 'info proc' now works on FreeBSD.
6895
6896 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6897
6898         * configure.ac: Check for kinfo_getfile in libutil.
6899         * configure: Regenerate.
6900         * config.in: Regenerate.
6901         * fbsd-nat.c: Include "fbsd-tdep.h".
6902         (fbsd_fetch_cmdline): New.
6903         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6904         rather than calling error.
6905         (fbsd_info_proc): New.
6906         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6907         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6908         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6909
6910 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6911
6912         * fbsd-nat.c (struct free_deleter): Remove.
6913         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6914
6915 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6916
6917         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6918         NULL for an empty pathname.
6919
6920 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6921
6922         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6923         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6924         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6925         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6926         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6927         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6928         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6929         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6930         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6931         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6932         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6933         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6934         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6935         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6936         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6937
6938 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6939
6940         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6941         (gnu_xfer_auxv): New function.
6942         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6943         TARGET_OBJECT_AUXV.
6944
6945 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6946             Simon Marchi  <simon.marchi@ericsson.com>
6947
6948         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6949         common/selftest.c.
6950         (COMMON_OBS): Remove selftest.o.
6951         * configure.ac: Append selftest-arch.c and common/selftest.c to
6952         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6953         * configure: Re-generated.
6954         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6955         GDB_SELF_TEST.
6956         (maintenance_info_selftests): Likewise.
6957
6958 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6959
6960         * ada-valprint.c (val_print_packed_array_elements): Use
6961         proper number of elements when printing an array indexed
6962         by an enumeration type.
6963
6964 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6965
6966         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6967         (dw2_get_file_names_reader): Adjust.
6968         (lookup_dwo_signatured_type): Adjust.
6969         (lookup_dwp_signatured_type): Adjust.
6970         (lookup_signatured_type): Adjust.
6971         (create_type_unit_group): Adjust.
6972         (get_type_unit_group): Adjust.
6973         (process_psymtab_comp_unit_reader): Adjust.
6974         (build_type_psymtabs_reader): Adjust.
6975         (scan_partial_symbols): Adjust.
6976         (add_partial_symbol): Adjust.
6977         (add_partial_subprogram): Adjust.
6978         (peek_die_abbrev): Adjust.
6979         (fixup_go_packaging): Adjust.
6980         (process_imported_unit_die): Adjust.
6981         (dwarf2_compute_name): Adjust.
6982         (dwarf2_physname): Adjust.
6983         (read_import_statement): Adjust.
6984         (handle_DW_AT_stmt_list): Adjust.
6985         (read_file_scope): Adjust.
6986         (read_func_scope): Adjust.
6987         (read_lexical_block_scope): Adjust.
6988         (read_call_site_scope): Adjust.
6989         (read_variable): Adjust.
6990         (dwarf2_rnglists_process): Adjust.
6991         (dwarf2_ranges_process): Adjust.
6992         (dwarf2_ranges_read): Adjust.
6993         (dwarf2_get_pc_bounds): Adjust.
6994         (dwarf2_record_block_ranges): Adjust.
6995         (dwarf2_add_field): Adjust.
6996         (dwarf2_add_member_fn): Adjust.
6997         (read_structure_type): Adjust.
6998         (process_structure_scope): Adjust.
6999         (read_enumeration_type): Adjust.
7000         (read_array_type): Adjust.
7001         (mark_common_block_symbol_computed): Adjust.
7002         (read_common_block): Adjust.
7003         (read_namespace_type): Adjust.
7004         (read_namespace): Adjust.
7005         (read_module_type): Adjust.
7006         (read_tag_pointer_type): Adjust.
7007         (read_tag_ptr_to_member_type): Adjust.
7008         (read_tag_string_type): Adjust.
7009         (read_subroutine_type): Adjust.
7010         (read_typedef): Adjust.
7011         (read_base_type): Adjust.
7012         (attr_to_dynamic_prop): Adjust.
7013         (read_subrange_type): Adjust.
7014         (read_unspecified_type): Adjust.
7015         (dwarf2_read_abbrevs): Adjust.
7016         (load_partial_dies): Adjust.
7017         (read_partial_die): Adjust.
7018         (find_partial_die): Adjust.
7019         (guess_partial_die_structure_name): Adjust.
7020         (fixup_partial_die): Adjust.
7021         (read_attribute_value): Adjust.
7022         (read_addr_index): Adjust.
7023         (read_addr_index_from_leb128): Adjust.
7024         (read_str_index): Adjust.
7025         (dwarf2_string_attr): Adjust.
7026         (get_debug_line_section): Adjust.
7027         (dwarf_decode_line_header): Adjust.
7028         (lnp_state_machine::check_line_address): Adjust.
7029         (dwarf_decode_lines_1): Adjust.
7030         (dwarf_decode_lines): Adjust.
7031         (dwarf2_start_symtab): Adjust.
7032         (var_decode_location): Adjust.
7033         (new_symbol_full): Adjust.
7034         (dwarf2_const_value_data): Adjust.
7035         (dwarf2_const_value_attr): Adjust.
7036         (dwarf2_const_value): Adjust.
7037         (die_type): Adjust.
7038         (die_containing_type): Adjust.
7039         (build_error_marker_type): Adjust.
7040         (lookup_die_type): Adjust.
7041         (guess_full_die_structure_name): Adjust.
7042         (anonymous_struct_prefix): Adjust.
7043         (determine_prefix): Adjust.
7044         (dwarf2_name): Adjust.
7045         (follow_die_ref_or_sig): Adjust.
7046         (follow_die_offset): Adjust.
7047         (follow_die_ref): Adjust.
7048         (follow_die_sig_1): Adjust.
7049         (follow_die_sig): Adjust.
7050         (get_signatured_type): Adjust.
7051         (get_DW_AT_signature_type): Adjust.
7052         (decode_locdesc): Adjust.
7053         (dwarf_decode_macros): Adjust.
7054         (cu_debug_loc_section): Adjust.
7055         (fill_in_loclist_baton): Adjust.
7056         (dwarf2_symbol_mark_computed): Adjust.
7057         (init_one_comp_unit): Don't assign
7058         dwarf2_cu::dwarf2_per_objfile.
7059         (set_die_type): Adjust.
7060
7061 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7062
7063         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7064         <dwarf2_per_objfile>: New field.
7065         (dwarf2_per_objfile): Remove global.
7066         (get_dwarf2_per_objfile): New function.
7067         (set_dwarf2_per_objfile): New function.
7068         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7069         dwarf2_per_objfile.
7070         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7071         (read_abbrev_offset): Likewise.
7072         (read_indirect_string): Likewise.
7073         (read_indirect_line_string): Likewise.
7074         (read_indirect_string_at_offset): Likewise.
7075         (read_indirect_string_from_dwz): Likewise.
7076         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7077         dwarf2_per_objfile.
7078         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7079         (create_all_comp_units): Change objfile parameter to
7080         dwarf2_per_objfile.
7081         (create_all_type_units): Likewise.
7082         (process_queue): Add dwarf2_per_objfile parameter.
7083         (read_and_check_comp_unit_head): Likewise.
7084         (lookup_dwo_unit_in_dwp): Likewise.
7085         (get_dwp_file): Likewise.
7086         (process_cu_includes): Likewise.
7087         (struct free_dwo_file_cleanup_data): New struct.
7088         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7089         set_dwarf2_per_objfile.
7090         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7091         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7092         context, adjust calls.
7093         (dw2_instantiate_symtab): Likewise.
7094         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7095         (dw2_get_cu): Likewise.
7096         (create_cu_from_index_list): Change objfile parameter to
7097         dwarf2_per_objfile.
7098         (create_cus_from_index_list): Get dwarf2_per_objfile from
7099         context, adjust calls.
7100         (create_cus_from_index): Likewise.
7101         (create_signatured_type_table_from_index): Change objfile
7102         parameter to dwarf2_per_objfile.
7103         (create_signatured_type_table_from_debug_names): Change objfile
7104         parameter to dwarf2_per_objfile.
7105         (create_addrmap_from_index): Likewise.
7106         (create_addrmap_from_aranges): Likewise.
7107         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7108         (dw2_setup): Remove.
7109         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7110         context.
7111         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7112         get_dwarf2_per_objfile.
7113         (dw2_forget_cached_source_info): Likewise.
7114         (dw2_map_symtabs_matching_filename): Likewise.
7115         (struct dw2_symtab_iterator) <index>: Remove.
7116         <dwarf2_per_objfile>: New field.
7117         (dw2_symtab_iter_init): Replace index parameter with
7118         dwarf2_per_objfile.
7119         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7120         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7121         (dw2_print_stats): Likewise.
7122         (dw2_dump): Likewise.
7123         (dw2_expand_symtabs_for_function): Likewise.
7124         (dw2_expand_all_symtabs): Likewise.
7125         (dw2_expand_symtabs_with_fullname): Likewise.
7126         (dw2_expand_marked_cus): Replace index and objfile parameters
7127         with dwarf2_per_objfile.
7128         (dw_expand_symtabs_matching_file_matcher): Add
7129         dwarf2_per_objfile parameter and adjust calls.
7130         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7131         adjust calls.
7132         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7133         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7134         adjust calls.
7135         (create_cus_from_debug_names_list): Replace objfile parameter
7136         with dwarf2_per_objfile and adjust calls.
7137         (create_cus_from_debug_names): Likewise.
7138         (dwarf2_read_debug_names): Likewise.
7139         (mapped_debug_names::namei_to_name): Adjust call.
7140         (dw2_debug_names_iterator::next): Likewise.
7141         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7142         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7143         (dw2_debug_names_dump): Likewise.
7144         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7145         (dw2_debug_names_expand_symtabs_matching): Likewise.
7146         (dwarf2_initialize_objfile): Likewise.
7147         (dwarf2_build_psymtabs): Likewise.
7148         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7149         this_cu.
7150         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7151         (read_and_check_comp_unit_head): Likewise.
7152         (read_abbrev_offset): Likewise.
7153         (create_debug_type_hash_table): Likewise.
7154         (create_debug_types_hash_table): Likewise.
7155         (create_all_type_units): Replace objfile parameter with
7156         dwarf2_per_objfile.
7157         (add_type_unit): Add dwarf2_per_objfile parameter.
7158         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7159         with dwarf2_per_objfile.
7160         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7161         (lookup_dwp_signatured_type): Likewise.
7162         (lookup_signatured_type): Likewise.
7163         (read_cutu_die_from_dwo): Likewise.
7164         (init_tu_and_read_dwo_dies): Likewise.
7165         (init_cutu_and_read_dies): Likewise.
7166         (init_cutu_and_read_dies_no_follow): Likewise.
7167         (allocate_type_unit_groups_table): Add objfile parameter.
7168         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7169         (get_type_unit_group): Likewise.
7170         (process_psymtab_comp_unit): Update call.
7171         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7172         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7173         (print_tu_stats): Likewise.
7174         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7175         in void* parameter.
7176         (build_type_psymtabs): Change objfile parameter to
7177         dwarf2_per_objfile.
7178         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7179         passed in void* parameter.
7180         (process_skeletonless_type_units): Change objfile parameter to
7181         dwarf2_per_objfile.
7182         (set_partial_user): Likewise.
7183         (dwarf2_build_psymtabs_hard): Likewise.
7184         (read_comp_units_from_section): Likewise.
7185         (create_all_comp_units): Likewise.
7186         (scan_partial_symbols): Update calls.
7187         (add_partial_symbol): Likewise.
7188         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7189         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7190         (process_queue): Add dwarf2_per_objfile parameter.
7191         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7192         (compute_compunit_symtab_includes): Likewise.
7193         (process_cu_includes): Add dwarf2_per_objfile parameter.
7194         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7195         (process_full_type_unit): Likewise.
7196         (process_imported_unit_die): Update call.
7197         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7198         (read_file_scope): Likewise.
7199         (allocate_dwo_file_hash_table): Add objfile parameter.
7200         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7201         (create_cus_hash_table): Likewise.
7202         (create_dwp_hash_table): Likewise.
7203         (create_dwo_unit_in_dwp_v1): Likewise.
7204         (create_dwp_v2_section): Likewise.
7205         (create_dwo_unit_in_dwp_v2): Likewise.
7206         (lookup_dwo_unit_in_dwp): Likewise.
7207         (try_open_dwop_file): Likewise.
7208         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7209         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7210         cleanup to include a reference to dwarf2_per_objfile.
7211         (open_dwp_file): Add dwarf2_per_objfile parameter.
7212         (open_and_init_dwp_file): Likewise.
7213         (get_dwp_file): Likewise.
7214         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7215         (queue_and_load_all_dwo_tus): Update call.
7216         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7217         data.
7218         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7219         (dwarf2_ranges_process): Likewise.
7220         (dwarf2_get_pc_bounds): Likewise.
7221         (mark_common_block_symbol_computed): Likewise.
7222         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7223         (dwarf2_read_abbrevs): Update call.
7224         (read_partial_die): Use dwarf2_per_objfile from cu.
7225         (find_partial_die): Likewise.
7226         (fixup_partial_die): Likewise.
7227         (read_attribute_value): Likewise.
7228         (read_indirect_string_at_offset_from): Add objfile parameter.
7229         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7230         parameter.
7231         (read_indirect_string_from_dwz): Add objfile parameter.
7232         (read_indirect_string): Add objfile parameter.
7233         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7234         (read_addr_index): Use dwarf2_per_objfile from cu.
7235         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7236         call dw2_setup.
7237         (read_str_index): Use dwarf2_per_objfile from cu.
7238         (get_debug_line_section): Likewise.
7239         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7240         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7241         (new_symbol_full): Use dwarf2_per_objfile from cu.
7242         (build_error_marker_type): Likewise.
7243         (lookup_die_type): Likewise.
7244         (determine_prefix): Likewise.
7245         (follow_die_offset): Likewise.
7246         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7247         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7248         (dwarf2_fetch_die_type_sect_off): Likewise.
7249         (dwarf2_get_die_type): Likewise.
7250         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7251         (get_signatured_type): Likewise.
7252         (get_DW_AT_signature_type): Likewise.
7253         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7254         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7255         (cu_debug_loc_section): Likewise.
7256         (fill_in_loclist_baton): Likewise.
7257         (dwarf2_symbol_mark_computed): Likewise.
7258         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7259         dwarf2_per_objfile.
7260         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7261         parameter.
7262         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7263         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7264         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7265         (set_die_type): Use dwarf2_free_objfile from cu.
7266         (get_die_type_at_offset): Likewise.
7267         (dwarf2_per_objfile_free): Don't assign global variable.
7268         (debug_names) <constructor>: Add dwarf2_per_objfile
7269         parameter, update m_debugstrlookup construction.
7270         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7271         parameter.
7272         <m_dwarf2_per_objfile>: New field.
7273         <lookup>: Use m_dwarf2_per_objfile.
7274         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7275         (psyms_seen_size): Likewise.
7276         (write_gdbindex): Replace objfile parameter with
7277         dwarf2_per_objfile.
7278         (write_debug_names): Likewise.
7279         (write_psymtabs_to_index): Likewise.
7280         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7281         calls.
7282
7283 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7284
7285         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7286         <dwarf2_per_objfile>: New field.
7287         (struct dwarf2_per_cu_data) <objfile>: Remove.
7288         <dwarf2_per_objfile>: New field.
7289         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7290         of objfile.
7291         (create_signatured_type_table_from_index): Likewise.
7292         (create_debug_type_hash_table): Likewise.
7293         (fill_in_sig_entry_from_dwo_entry): Likewise.
7294         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7295         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7296         objfile.
7297         (create_partial_symtab): Access objfile through
7298         dwarf2_per_objfile.
7299         (process_psymtab_comp_unit_reader): Likewise.
7300         (read_comp_units_from_section): Likewise.
7301         (scan_partial_symbols): Likewise.
7302         (add_partial_symbol): Likewise.
7303         (add_partial_subprogram): Likewise.
7304         (peek_die_abbrev): Likewise.
7305         (fixup_go_packaging): Likewise.
7306         (process_full_comp_unit): Likewise.
7307         (process_full_type_unit): Likewise.
7308         (process_imported_unit_die): Likewise.
7309         (dwarf2_compute_name): Likewise.
7310         (dwarf2_physname): Likewise.
7311         (read_import_statement): Likewise.
7312         (create_cus_hash_table): Assign dwarf2_physname instead of
7313         objfile.
7314         (read_func_scope): Access objfile through dwarf2_per_objfile.
7315         (read_lexical_block_scope): Likewise.
7316         (read_call_site_scope): Likewise.
7317         (read_variable): Likewise.
7318         (dwarf2_rnglists_process): Likewise.
7319         (dwarf2_ranges_process): Likewise.
7320         (dwarf2_ranges_read): Likewise.
7321         (dwarf2_record_block_ranges): Likewise.
7322         (dwarf2_add_field): Likewise.
7323         (dwarf2_add_member_fn): Likewise.
7324         (read_structure_type): Likewise.
7325         (process_structure_scope): Likewise.
7326         (read_enumeration_type): Likewise.
7327         (read_array_type): Likewise.
7328         (read_common_block): Likewise.
7329         (read_namespace_type): Likewise.
7330         (read_namespace): Likewise.
7331         (read_module_type): Likewise.
7332         (read_tag_pointer_type): Likewise.
7333         (read_tag_ptr_to_member_type): Likewise.
7334         (read_tag_string_type): Likewise.
7335         (read_subroutine_type): Likewise.
7336         (read_typedef): Likewise.
7337         (read_base_type): Likewise.
7338         (attr_to_dynamic_prop): Likewise.
7339         (read_subrange_type): Likewise.
7340         (read_unspecified_type): Likewise.
7341         (load_partial_dies): Likewise.
7342         (read_partial_die): Likewise.
7343         (find_partial_die): Likewise.
7344         (guess_partial_die_structure_name): Likewise.
7345         (fixup_partial_die): Likewise.
7346         (read_attribute_value): Likewise.
7347         (read_addr_index_from_leb128): Likewise.
7348         (dwarf2_read_addr_index): Likewise.
7349         (dwarf2_string_attr): Likewise.
7350         (lnp_state_machine::check_line_address): Likewise.
7351         (dwarf_decode_lines_1): Likewise.
7352         (dwarf_decode_lines): Likewise.
7353         (dwarf2_start_symtab): Likewise.
7354         (var_decode_location): Likewise.
7355         (new_symbol_full): Likewise.
7356         (dwarf2_const_value_data): Likewise.
7357         (dwarf2_const_value_attr): Likewise.
7358         (dwarf2_const_value): Likewise.
7359         (die_type): Likewise.
7360         (die_containing_type): Likewise.
7361         (lookup_die_type): Likewise.
7362         (guess_full_die_structure_name): Likewise.
7363         (anonymous_struct_prefix): Likewise.
7364         (dwarf2_name): Likewise.
7365         (follow_die_ref_or_sig): Likewise.
7366         (follow_die_offset): Likewise.
7367         (follow_die_ref): Likewise.
7368         (dwarf2_fetch_die_loc_sect_off): Likewise.
7369         (dwarf2_fetch_constant_bytes): Likewise.
7370         (dwarf2_fetch_die_type_sect_off): Likewise.
7371         (dwarf2_get_die_type): Likewise.
7372         (follow_die_sig): Likewise.
7373         (decode_locdesc): Likewise.
7374         (dwarf2_per_cu_objfile): Likewise.
7375         (dwarf2_per_cu_text_offset): Likewise.
7376         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7377         objfile.
7378         (set_die_type): Access objfile through
7379         dwarf2_per_objfile.
7380
7381 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7382
7383         * valprint.c (converted_character_d): Remove typedef.
7384         (DEF_VEC_O (converted_character_d)): Remove.
7385         (count_next_character): Use std::vector.
7386         (print_converted_chars_to_obstack): Likewise.
7387         (generic_printstr): Likewise.
7388
7389 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7390
7391         * xml-support.h (struct gdb_xml_value): Add constructor.
7392         <value>: Change type to unique_xmalloc_ptr.
7393         (gdb_xml_value_s): Remove typedef.
7394         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7395         (gdb_xml_element_start_handler): Change parameter type to
7396         std::vector.
7397         (xml_find_attribute): Likewise.
7398         * xml-support.c (xml_find_attribute): Change parameter type to
7399         std::vector and adjust.
7400         (gdb_xml_values_cleanup): Remove.
7401         (gdb_xml_parser::start_element): Adjust to std::vector.
7402         (xinclude_start_include): Change paraeter type to std::vector
7403         and adjust.
7404         * btrace.c (check_xml_btrace_version): Likewise.
7405         (parse_xml_btrace_block): Likewise.
7406         (parse_xml_btrace_pt_config_cpu): Likewise.
7407         (parse_xml_btrace_pt): Likewise.
7408         (parse_xml_btrace_conf_bts): Likewise.
7409         (parse_xml_btrace_conf_pt): Likewise.
7410         * memory-map.c (memory_map_start_memory): Likewise.
7411         (memory_map_start_property): Likewise.
7412         * osdata.c (osdata_start_osdata): Likewise.
7413         (osdata_start_item): Likewise.
7414         (osdata_start_column): Likewise.
7415         * remote.c (start_thread): Likewise.
7416         * solib-aix.c (library_list_start_library): Likewise.
7417         (library_list_start_list): Likewise.
7418         * solib-svr4.c (library_list_start_library): Likewise.
7419         (svr4_library_list_start_list): Likewise.
7420         * solib-target.c (library_list_start_segment): Likewise.
7421         (library_list_start_section): Likewise.
7422         (library_list_start_library): Likewise.
7423         (library_list_start_list): Likewise.
7424         * tracepoint.c (traceframe_info_start_memory): Likewise.
7425         (traceframe_info_start_tvar): Likewise.
7426         * xml-syscall.c (syscall_start_syscall): Likewise.
7427         * xml-tdesc.c (tdesc_start_target): Likewise.
7428         (tdesc_start_feature): Likewise.
7429         (tdesc_start_reg): Likewise.
7430         (tdesc_start_union): Likewise.
7431         (tdesc_start_struct): Likewise.
7432         (tdesc_start_flags): Likewise.
7433         (tdesc_start_enum): Likewise.
7434         (tdesc_start_field): Likewise.
7435         (tdesc_start_enum_value): Likewise.
7436         (tdesc_start_vector): Likewise.
7437
7438 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7439
7440         * extension.h (struct xmethod_worker) <clone>: Remove.
7441         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7442         Remove.
7443         (python_xmethod_worker::clone): Remove.
7444         * valops.c (find_overload_match): Use std::move instead of
7445         clone.
7446
7447 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7448
7449         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7450         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7451         <free_xmethod_worker_data>: Remove.
7452         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7453         <get_xmethod_arg_types>: Remove.
7454         <get_xmethod_result_type>: Remove.
7455         <invoke_xmethod>: Remove.
7456         * extension.c (new_xmethod_worker): Remove.
7457         (clone_xmethod_worker): Remove.
7458         (get_matching_xmethod_workers): Return void, pass std::vector by
7459         pointer.
7460         (get_xmethod_arg_types): Rename to...
7461         (xmethod_worker::get_arg_types): ... this, and adjust.
7462         (get_xmethod_result_type): Rename to...
7463         (xmethod_worker::get_result_type): ... this, and adjust.
7464         (invoke_xmethod): Remove.
7465         (free_xmethod_worker): Remove.
7466         (free_xmethod_worker_vec): Remove.
7467         * extension.h (enum ext_lang_rc): Move here from
7468         extension-priv.h.
7469         (struct xmethod_worker): Add constructor and destructor.
7470         <data>: Remove.
7471         <value>: Remove.
7472         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7473         virtual pure methods.
7474         <get_arg_types, get_result_type>: New methods.
7475         (xmethod_worker_ptr): Remove typedef.
7476         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7477         (xmethod_worker_vec): Remove typedef.
7478         (xmethod_worker_up): New typedef.
7479         (invoke_xmethod): Remove.
7480         (clone_xmethod_worker): Remove.
7481         (free_xmethod_worker): Remove.
7482         (free_xmethod_worker_vec): Remove.
7483         (get_xmethod_arg_types): Remove.
7484         (get_xmethod_result_type): Remove.
7485         * valops.c (find_method_list): Use std::vector, don't use
7486         intermediate vector.
7487         (value_find_oload_method_list): Use std::vector.
7488         (find_overload_match): Use std::vector.
7489         (find_oload_champ): Use std::vector.
7490         * value.c (value_free): Use operator delete.
7491         (value_of_xmethod): Rename to...
7492         (value_from_xmethod): ... this.  Don't assign
7493         xmethod_worker::value, take rvalue-reference.
7494         (result_type_of_xmethod): Adjust.
7495         (call_xmethod): Adjust.
7496         * value.h: Include extension.h.
7497         (struct xmethod_worker): Don't forward-declare.
7498         (value_of_xmethod): Rename to...
7499         (value_from_xmethod): ... this, take rvalue-reference.
7500         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7501         (struct python_xmethod_worker): ... this, add constructor and
7502         destructor.
7503         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7504         (gdbpy_free_xmethod_worker_data): Rename to...
7505         (python_xmethod_worker::~python_xmethod_worker): ... this and
7506         adjust.
7507         (gdbpy_clone_xmethod_worker_data): Rename to...
7508         (python_xmethod_worker::clone): ... this and adjust.
7509         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7510         temporary vector.
7511         (gdbpy_get_xmethod_arg_types): Rename to...
7512         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7513         (gdbpy_get_xmethod_result_type): Rename to...
7514         (python_xmethod_worker::do_get_result_type): ... this and
7515         adjust.
7516         (gdbpy_invoke_xmethod): Rename to...
7517         (python_xmethod_worker::invoke): ... this and adjust.
7518         (new_python_xmethod_worker): Rename to...
7519         (python_xmethod_worker::python_xmethod_worker): ... this and
7520         adjust.
7521         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7522         Remove.
7523         (gdbpy_free_xmethod_worker_data): Remove.
7524         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7525         (gdbpy_get_xmethod_arg_types): Remove.
7526         (gdbpy_get_xmethod_result_type): Remove.
7527         (gdbpy_invoke_xmethod): Remove.
7528         * python/python.c (python_extension_ops): Remove obsolete
7529         callbacks.
7530
7531 2018-01-05  Pedro Alves  <palves@redhat.com>
7532
7533         PR gdb/18653
7534         * common/signals-state-save-restore.c
7535         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7536         find a custom handler preinstalled, instead of internal erroring.
7537         But only warn if !quiet.
7538         * common/signals-state-save-restore.h
7539         (save_original_signals_state): New parameter 'quiet'.
7540         * main.c (captured_main_1): Move save_original_signals_state call
7541         after option handling, and pass QUIET.
7542
7543 2018-01-05  Pedro Alves  <palves@redhat.com>
7544
7545         * spu-tdep.c (spu_catch_start): Pass
7546         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7547
7548 2018-01-05  Pedro Alves  <palves@redhat.com>
7549
7550         PR gdb/22670
7551         * ada-lang.c (literal_symbol_name_matcher): New function.
7552         (ada_get_symbol_name_matcher): Use it for
7553         symbol_name_match_type::SEARCH_NAME.
7554         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7555         it down instead of assuming symbol_name_match_type::FULL.
7556         * block.h (block_lookup_symbol): New parameter 'match_type'.
7557         * c-valprint.c (print_unpacked_pointer): Use
7558         lookup_symbol_search_name instead of lookup_symbol.
7559         * compile/compile-object-load.c (get_out_value_type): Pass down
7560         symbol_name_match_type::SEARCH_NAME.
7561         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7562         symbol_name_match_type::FULL.
7563         * cp-support.c (cp_get_symbol_name_matcher): Handle
7564         symbol_name_match_type::SEARCH_NAME.
7565         * infrun.c (insert_exception_resume_breakpoint): Use
7566         lookup_symbol_search_name.
7567         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7568         * psymtab.c (maintenance_check_psymtabs): Use
7569         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7570         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7571         SYMBOL_SEARCH_NAME.
7572         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7573         if symbol_name_match_type::SEARCH_NAME.
7574         (lookup_symbol_in_language): Pass down
7575         symbol_name_match_type::FULL.
7576         (lookup_symbol_search_name): New.
7577         (lookup_language_this): Pass down
7578         symbol_name_match_type::SEARCH_NAME.
7579         (lookup_symbol_aux, lookup_local_symbol): New parameter
7580         'match_type'.  Pass it down.
7581         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7582         (lookup_symbol_search_name): New declaration.
7583         (lookup_symbol_in_block): New 'match_type' parameter.
7584
7585 2018-01-05  Pedro Alves  <palves@redhat.com>
7586
7587         PR gdb/22670
7588         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7589         ada_lookup_symbol.
7590         (ada_lookup_symbol): Reimplement in terms of
7591         ada_lookup_symbol_list, bits factored out from
7592         ada_lookup_encoded_symbol.
7593
7594 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7595
7596         * ada-exp.y (write_object_renaming): When subscripting an array
7597         using a symbol as the index, pass the block in call to
7598         ada_lookup_encoded_symbol when looking that symbol up.
7599
7600 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7601
7602         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7603         TYPE_INDEX_TYPE.
7604
7605 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7606
7607         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7608         the case where VALUE_LVAL (val0) is not lval_memory.
7609
7610 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7611
7612         * ada-valprint.c (print_optional_low_bound): Handle
7613         character-indexed array printing like boolean-indexed array
7614         printing.
7615
7616 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7617
7618         * NEWS: Create a new section for the next release branch.
7619         Rename the section of the current branch, now that it has
7620         been cut.
7621
7622 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7623
7624         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7625         * version.in: Bump version to 8.1.50.DATE-git.
7626
7627 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7628
7629         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7630         Add field.
7631         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7632         Add field.
7633         (default_exception_support_info) <catch_handlers_sym>: Add field.
7634         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7635         (ada_exception_name_addr_1): Add "catch handlers" handling.
7636         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7637         Update all callers.
7638         (create_excep_cond_exprs) <ex>: Add parameter.
7639         (re_set_exception): Update create_excep_cond_exprs call.
7640         (print_it_exception, print_one_exception, print_mention_exception)
7641         (print_recreate_exception): Add "catch handler" handling.
7642         (allocate_location_catch_handlers, re_set_catch_handlers)
7643         (check_status_catch_handlers, print_it_catch_handlers)
7644         (print_one_catch_handlers, print_mention_catch_handlers)
7645         (print_recreate_catch_handlers): New function.
7646         (catch_handlers_breakpoint_ops): New variable.
7647         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7648         Add parameter.  Add "catch handler" handling.
7649         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7650         Add "catch handler" handling.
7651         (ada_exception_catchpoint_cond_string): Add "catch handler"
7652         handling.
7653         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7654         call.
7655         (catch_ada_handlers_command): New function.
7656         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7657         operations structure.
7658         (_initialize_ada_language): Add "catch handlers" command entry.
7659         * NEWS: Document "catch handlers" feature.
7660
7661 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7662
7663         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7664         account when creating the array type of the slice.
7665         (ada_value_slice): Likewise.
7666
7667 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7668
7669         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7670         New enum value.
7671         (create_array_type_with_stride): Add byte_stride_prop parameter.
7672         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7673         New parameter.  Update all callers in this file.
7674         (array_type_has_dynamic_stride): New function.
7675         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7676         of arrays with dynamic byte strides.
7677         * dwarf2read.c (read_array_type): Add support for dynamic
7678         DW_AT_byte_stride attributes.
7679
7680 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7681
7682         * dwarf2read.c (read_unspecified_type): Treat
7683         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7684
7685 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7686
7687         Update copyright year range in all GDB files.
7688
7689 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7690
7691         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7692         and gdb/testsuite/gdb.base/step-line.c.
7693
7694 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7695
7696         * copyright.py (main): Dump the contents of
7697         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7698         even if BY_HAND is empty.
7699
7700 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7701
7702         * top.c (print_gdb_version): Update Copyright year in version
7703         message.
7704
7705 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7706
7707         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7708
7709 For older changes see ChangeLog-2017.
7710 \f
7711 Local Variables:
7712 mode: change-log
7713 left-margin: 8
7714 fill-column: 74
7715 version-control: never
7716 coding: utf-8
7717 End: